summaryrefslogtreecommitdiffstats
path: root/generic/tcl.h
diff options
context:
space:
mode:
Diffstat (limited to 'generic/tcl.h')
-rw-r--r--generic/tcl.h7
1 files changed, 1 insertions, 6 deletions
diff --git a/generic/tcl.h b/generic/tcl.h
index c34f84a..5885e15 100644
--- a/generic/tcl.h
+++ b/generic/tcl.h
@@ -13,7 +13,7 @@
* See the file "license.terms" for information on usage and redistribution
* of this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tcl.h,v 1.156 2003/04/05 01:25:10 dkf Exp $
+ * RCS: @(#) $Id: tcl.h,v 1.157 2003/04/16 23:33:43 dgp Exp $
*/
#ifndef _TCL
@@ -632,18 +632,13 @@ typedef struct stat *Tcl_OldStat_;
*/
typedef enum {
TCL_INT, TCL_DOUBLE, TCL_EITHER, TCL_WIDE_INT
-#ifdef TCL_WIDE_INT_IS_LONG
- = TCL_INT
-#endif
} Tcl_ValueType;
typedef struct Tcl_Value {
Tcl_ValueType type; /* Indicates intValue or doubleValue is
* valid, or both. */
long intValue; /* Integer value. */
double doubleValue; /* Double-precision floating value. */
-#ifndef TCL_WIDE_INT_IS_LONG
Tcl_WideInt wideValue; /* Wide (min. 64-bit) integer value. */
-#endif
} Tcl_Value;
/*
Object.h8
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.cpp766
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.h58
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSObject.h27
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.cpp5
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.h1
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.cpp399
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.h42
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/PropertySlot.h10
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/ScopeChain.h4
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/Structure.cpp6
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.cpp11
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.h1
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/UString.cpp15
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/runtime/UString.h3
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.cpp6
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.h2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/CurrentTime.cpp8
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.cpp (renamed from src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.cpp)110
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.h (renamed from src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.h)14
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Deque.h2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/FastAllocBase.h3
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/FastMalloc.cpp2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/HashCountedSet.h3
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/HashMap.h2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/HashSet.h3
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h4
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/MessageQueue.h14
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h136
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/RandomNumberSeed.h2
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/RefPtr.h3
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/SegmentedVector.h (renamed from src/3rdparty/webkit/JavaScriptCore/bytecompiler/SegmentedVector.h)98
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/StringExtras.h4
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Threading.h28
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingNone.cpp4
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingPthreads.cpp57
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h37
-rw-r--r--src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp40
-rw-r--r--src/3rdparty/webkit/VERSION4
-rw-r--r--src/3rdparty/webkit/WebCore/ChangeLog97951
-rw-r--r--src/3rdparty/webkit/WebCore/ChangeLog-2006-12-3122
-rw-r--r--src/3rdparty/webkit/WebCore/ChangeLog-2007-10-1418
-rw-r--r--src/3rdparty/webkit/WebCore/ChangeLog-2008-08-1020
-rw-r--r--src/3rdparty/webkit/WebCore/ChangeLog-2009-06-1697559
-rw-r--r--src/3rdparty/webkit/WebCore/DerivedSources.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/DateMath.h (renamed from src/3rdparty/webkit/WebCore/ForwardingHeaders/runtime/DateMath.h)0
-rw-r--r--src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/FastAllocBase.h4
-rw-r--r--src/3rdparty/webkit/WebCore/WebCore.pro88
-rw-r--r--src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.cpp17
-rw-r--r--src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.h3
-rw-r--r--src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.cpp58
-rw-r--r--src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.h2
-rw-r--r--src/3rdparty/webkit/WebCore/accessibility/AccessibilityTableCell.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp27
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDOMBinding.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.cpp86
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.h11
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.cpp205
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.h116
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDataGridColumnListCustom.cpp49
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.cpp80
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.h75
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSHTMLAppletElementCustom.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSHTMLDataGridElementCustom.cpp50
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSHTMLEmbedElementCustom.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSHTMLObjectElementCustom.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSHistoryCustom.cpp18
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSLocationCustom.cpp20
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSMessagePortCustom.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSStorageCustom.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/JSWorkerContextCustom.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/ScriptController.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/ScriptController.h6
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/ScriptEventListener.cpp11
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/ScriptSourceCode.h2
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/StringSourceProvider.h1
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/js/WorkerScriptController.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/scripts/CodeGenerator.pm35
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorJS.pm187
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorObjC.pm28
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorV8.pm2191
-rw-r--r--src/3rdparty/webkit/WebCore/bindings/scripts/IDLParser.pm4
-rw-r--r--src/3rdparty/webkit/WebCore/bridge/qt/qt_runtime.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/config.h5
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.cpp17
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.h3
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSPrimitiveValue.h2
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.h4
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.idl2
-rw-r--r--src/3rdparty/webkit/WebCore/css/CSSStyleSelector.cpp16
-rw-r--r--src/3rdparty/webkit/WebCore/css/html4.css20
-rw-r--r--src/3rdparty/webkit/WebCore/css/mediaControls.css56
-rw-r--r--src/3rdparty/webkit/WebCore/css/mediaControlsQT.css51
-rw-r--r--src/3rdparty/webkit/WebCore/css/themeChromiumLinux.css (renamed from src/3rdparty/webkit/WebCore/dom/MessagePortProxy.h)28
-rw-r--r--src/3rdparty/webkit/WebCore/css/view-source.css4
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Clipboard.h7
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Clipboard.idl1
-rw-r--r--src/3rdparty/webkit/WebCore/dom/ContainerNode.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/dom/DOMImplementation.cpp10
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Document.cpp28
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Document.h1
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Document.idl72
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Element.cpp11
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Element.h3
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Element.idl71
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessageChannel.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessagePort.cpp254
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessagePort.h68
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessagePort.idl3
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessagePortChannel.cpp64
-rw-r--r--src/3rdparty/webkit/WebCore/dom/MessagePortChannel.h103
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Node.cpp186
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Node.h69
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Node.idl41
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Position.cpp14
-rw-r--r--src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Range.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/dom/RangeBoundaryPoint.h9
-rw-r--r--src/3rdparty/webkit/WebCore/dom/ScriptElement.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/dom/ScriptExecutionContext.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/dom/SelectElement.cpp14
-rw-r--r--src/3rdparty/webkit/WebCore/dom/SelectElement.h9
-rw-r--r--src/3rdparty/webkit/WebCore/dom/Tokenizer.h8
-rw-r--r--src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.cpp222
-rw-r--r--src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.h129
-rw-r--r--src/3rdparty/webkit/WebCore/editing/BreakBlockquoteCommand.cpp10
-rw-r--r--src/3rdparty/webkit/WebCore/editing/CompositeEditCommand.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/editing/Editor.cpp18
-rw-r--r--src/3rdparty/webkit/WebCore/editing/EditorCommand.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.cpp117
-rw-r--r--src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.h4
-rw-r--r--src/3rdparty/webkit/WebCore/editing/InsertParagraphSeparatorCommand.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/editing/InsertTextCommand.cpp16
-rw-r--r--src/3rdparty/webkit/WebCore/editing/SelectionController.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/editing/TextIterator.cpp211
-rw-r--r--src/3rdparty/webkit/WebCore/editing/TextIterator.h52
-rw-r--r--src/3rdparty/webkit/WebCore/editing/TypingCommand.cpp41
-rw-r--r--src/3rdparty/webkit/WebCore/editing/TypingCommand.h6
-rw-r--r--src/3rdparty/webkit/WebCore/editing/gtk/SelectionControllerGtk.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/editing/htmlediting.cpp22
-rw-r--r--src/3rdparty/webkit/WebCore/editing/htmlediting.h5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/CSSGrammar.cpp877
-rw-r--r--src/3rdparty/webkit/WebCore/generated/CSSGrammar.h109
-rw-r--r--src/3rdparty/webkit/WebCore/generated/DatePrototype.lut.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/Grammar.cpp1020
-rw-r--r--src/3rdparty/webkit/WebCore/generated/Grammar.h109
-rw-r--r--src/3rdparty/webkit/WebCore/generated/HTMLElementFactory.cpp28
-rw-r--r--src/3rdparty/webkit/WebCore/generated/HTMLNames.cpp140
-rw-r--r--src/3rdparty/webkit/WebCore/generated/HTMLNames.h34
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSAttr.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSAttr.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSBarInfo.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCDATASection.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSCharsetRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSFontFaceRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSImportRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSMediaRule.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSPageRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSPrimitiveValue.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSRule.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSRuleList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSStyleRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSStyleSheet.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSValue.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSValueList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSVariablesDeclaration.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCSSVariablesRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCanvasGradient.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCanvasPattern.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCanvasRenderingContext2D.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCharacterData.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSClientRect.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSClientRectList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSClipboard.cpp22
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSClipboard.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSComment.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSConsole.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCoordinates.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSCounter.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMCoreException.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMImplementation.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMParser.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMSelection.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMStringList.cpp214
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp86
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDOMWindow.h12
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.cpp289
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.h98
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.cpp301
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.h (renamed from src/3rdparty/webkit/WebCore/generated/JSDOMStringList.h)45
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDatabase.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDatabase.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDocument.cpp852
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDocument.h79
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDocumentFragment.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDocumentType.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSDocumentType.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSElement.cpp849
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSElement.h79
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSEntity.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSEntityReference.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSEventException.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSFile.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSFileList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSGeolocation.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSGeoposition.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAnchorElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.cpp10
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAreaElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBRElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBaseElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBaseFontElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBlockquoteElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.cpp170
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.h14
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLButtonElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLCanvasElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDListElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.cpp212
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.h74
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.cpp212
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.h74
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.cpp202
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.h77
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.cpp181
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.h70
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDirectoryElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDivElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLDocument.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLElement.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLElementWrapperFactory.cpp32
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.cpp10
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFieldSetElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFontElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFormElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFrameElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.cpp170
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.h14
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLHRElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLHeadElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLHeadingElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLHtmlElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLIFrameElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLImageElement.cpp38
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLInputElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLIsIndexElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLLIElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLLabelElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLLegendElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLLinkElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMapElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMarqueeElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.cpp23
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMenuElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLMetaElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLModElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOListElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOptGroupElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLParagraphElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLParamElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLPreElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLQuoteElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLScriptElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLSelectElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLStyleElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableCellElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableColElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableRowElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTextAreaElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLTitleElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLUListElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHistory.cpp16
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSHistory.h5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSImageData.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSInspectorController.cpp10
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSKeyboardEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSLocation.cpp18
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSLocation.h7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMediaError.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMediaError.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMediaList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMessageChannel.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMessageEvent.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMessagePort.cpp58
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMessagePort.h5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMimeType.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMimeTypeArray.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMouseEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSMutationEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNamedNodeMap.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNavigator.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNode.cpp893
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNode.h82
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNodeFilter.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNodeIterator.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNodeList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNodeList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSNotation.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSONObject.lut.h15
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSOverflowEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSPlugin.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSPluginArray.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSPositionError.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSProcessingInstruction.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSProgressEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSRange.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSRangeException.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSRect.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLError.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLError.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAngle.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAngle.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGColor.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGColor.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDocument.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGDocument.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGException.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGException.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncGElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncGElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncRElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncRElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEGaussianBlurElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEGaussianBlurElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEImageElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEImageElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEMergeElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEMergeElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEMergeNodeElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEMergeNodeElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEOffsetElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEOffsetElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEPointLightElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFEPointLightElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFESpecularLightingElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFESpecularLightingElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFESpotLightElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFESpotLightElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFETileElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFETileElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFETurbulenceElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFETurbulenceElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFilterElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFilterElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceFormatElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceFormatElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceNameElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceNameElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceSrcElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceSrcElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceUriElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGFontFaceUriElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGForeignObjectElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGForeignObjectElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGlyphElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGlyphElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGradientElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGGradientElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGHKernElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGHKernElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGImageElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGImageElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLength.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLength.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLengthList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLengthList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLineElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLineElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLinearGradientElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGLinearGradientElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMarkerElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMarkerElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMaskElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMaskElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMatrix.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMatrix.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMetadataElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMetadataElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMissingGlyphElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGMissingGlyphElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGNumber.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGNumber.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGNumberList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGNumberList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPaint.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPaint.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSeg.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSeg.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegArcAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegArcAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegArcRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegArcRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegClosePath.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegClosePath.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicSmoothAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicSmoothAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicSmoothRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoCubicSmoothRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticSmoothAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticSmoothAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticSmoothRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegCurvetoQuadraticSmoothRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoHorizontalAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoHorizontalAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoHorizontalRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoHorizontalRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoVerticalAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoVerticalAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoVerticalRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegLinetoVerticalRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegMovetoAbs.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegMovetoAbs.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegMovetoRel.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPathSegMovetoRel.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPatternElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPatternElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPoint.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPoint.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPointList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPointList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPolygonElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPolygonElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPolylineElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPolylineElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPreserveAspectRatio.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGPreserveAspectRatio.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRadialGradientElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRadialGradientElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRect.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRect.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRectElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRectElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRenderingIntent.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGRenderingIntent.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSVGElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSVGElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGScriptElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGScriptElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSetElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSetElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStopElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStopElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStringList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStringList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStyleElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGStyleElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSwitchElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSwitchElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSymbolElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGSymbolElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTRefElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTRefElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTSpanElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTSpanElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextContentElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextContentElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextPathElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextPathElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextPositioningElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTextPositioningElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTitleElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTitleElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTransform.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTransform.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTransformList.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGTransformList.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGUnitTypes.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGUnitTypes.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGUseElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGUseElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGViewElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGViewElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGZoomEvent.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSSVGZoomEvent.h2
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSScreen.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStorage.cpp17
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStorage.h7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStorageEvent.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStorageEvent.h4
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStyleSheet.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSStyleSheetList.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSText.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSTextEvent.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSTextMetrics.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSTimeRanges.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSTreeWalker.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSUIEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSVoidCallback.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitAnimationEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitCSSKeyframeRule.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitCSSKeyframesRule.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitCSSMatrix.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitCSSTransformValue.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitPoint.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWebKitTransitionEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWheelEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorker.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorker.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerContext.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerContext.h3
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerLocation.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerLocation.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerNavigator.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSWorkerNavigator.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXMLHttpRequest.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXMLHttpRequestException.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXMLHttpRequestProgressEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXMLHttpRequestUpload.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXMLSerializer.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathEvaluator.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathEvaluator.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathException.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathException.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathExpression.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathExpression.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathNSResolver.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathNSResolver.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathResult.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/generated/JSXPathResult.h1
-rw-r--r--src/3rdparty/webkit/WebCore/generated/UserAgentStyleSheets.h6
-rw-r--r--src/3rdparty/webkit/WebCore/generated/UserAgentStyleSheetsData.cpp1130
-rw-r--r--src/3rdparty/webkit/WebCore/generated/XPathGrammar.cpp418
-rw-r--r--src/3rdparty/webkit/WebCore/generated/XPathGrammar.h64
-rw-r--r--src/3rdparty/webkit/WebCore/history/HistoryItem.cpp15
-rw-r--r--src/3rdparty/webkit/WebCore/history/HistoryItem.h16
-rw-r--r--src/3rdparty/webkit/WebCore/history/qt/HistoryItemQt.cpp114
-rw-r--r--src/3rdparty/webkit/WebCore/html/CanvasRenderingContext2D.cpp94
-rw-r--r--src/3rdparty/webkit/WebCore/html/CanvasRenderingContext2D.h9
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumn.cpp (renamed from src/3rdparty/webkit/WebCore/dom/DOMStringList.cpp)17
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumn.h90
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumn.idl48
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumnList.cpp98
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumnList.h48
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridColumnList.idl45
-rw-r--r--src/3rdparty/webkit/WebCore/html/DataGridDataSource.h (renamed from src/3rdparty/webkit/WebCore/bindings/js/JSDOMStringListCustom.cpp)31
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLAppletElement.idl4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLAttributeNames.in30
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLBodyElement.cpp110
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLBodyElement.h28
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLBodyElement.idl31
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridCellElement.cpp91
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridCellElement.h58
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridCellElement.idl41
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridColElement.cpp102
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridColElement.h58
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridColElement.idl40
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridElement.cpp104
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridElement.h71
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridElement.idl40
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridRowElement.cpp78
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridRowElement.h52
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLDataGridRowElement.idl (renamed from src/3rdparty/webkit/WebCore/dom/DOMStringList.idl)22
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLElement.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLElement.idl12
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLElementsAllInOne.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLEmbedElement.idl4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLFormControlElement.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLFrameSetElement.cpp134
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLFrameSetElement.h37
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLFrameSetElement.idl29
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLImageElement.idl18
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLInputElement.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLLinkElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLMediaElement.cpp148
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLMediaElement.h21
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLMediaElement.idl3
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLObjectElement.idl4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLParser.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLSelectElement.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLSelectElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLStyleElement.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLTableColElement.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLTagNames.in4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLTokenizer.cpp64
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLTokenizer.h4
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLVideoElement.cpp14
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLVideoElement.h6
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLViewSourceDocument.cpp13
-rw-r--r--src/3rdparty/webkit/WebCore/html/HTMLViewSourceDocument.h5
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/ConsoleMessage.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorController.cpp96
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorController.h13
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorController.idl4
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorDOMStorageResource.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorDatabaseResource.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorFrontend.cpp18
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorFrontend.h14
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorJSONObject.cpp (renamed from src/3rdparty/webkit/WebCore/inspector/JSONObject.cpp)26
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorJSONObject.h (renamed from src/3rdparty/webkit/WebCore/inspector/JSONObject.h)14
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/InspectorResource.cpp14
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/Console.js74
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/DatabaseQueryView.js6
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/Images/resourcesSilhouette.pngbin0 -> 42925 bytes-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/ObjectPropertiesSection.js11
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/ProfileView.js74
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/ProfilesPanel.js6
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/Script.js13
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/ScriptsPanel.js29
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/TextPrompt.js13
-rw-r--r--src/3rdparty/webkit/WebCore/inspector/front-end/inspector.css10
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedCSSStyleSheet.h2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedFont.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedFont.h2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedImage.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedImage.h2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedResource.cpp55
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedResource.h7
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedScript.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedScript.h2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedXSLStyleSheet.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/loader/CachedXSLStyleSheet.h2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/DocLoader.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/loader/DocumentLoader.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/DocumentThreadableLoader.cpp11
-rw-r--r--src/3rdparty/webkit/WebCore/loader/DocumentThreadableLoader.h5
-rw-r--r--src/3rdparty/webkit/WebCore/loader/EmptyClients.h12
-rw-r--r--src/3rdparty/webkit/WebCore/loader/FrameLoader.cpp97
-rw-r--r--src/3rdparty/webkit/WebCore/loader/FrameLoader.h7
-rw-r--r--src/3rdparty/webkit/WebCore/loader/FrameLoaderClient.h7
-rw-r--r--src/3rdparty/webkit/WebCore/loader/TextResourceDecoder.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/loader/ThreadableLoader.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/loader/ThreadableLoader.h7
-rw-r--r--src/3rdparty/webkit/WebCore/loader/WorkerThreadableLoader.cpp50
-rw-r--r--src/3rdparty/webkit/WebCore/loader/WorkerThreadableLoader.h18
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCache.cpp28
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCache.h9
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCacheGroup.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCacheResource.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCacheResource.h3
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/ApplicationCacheStorage.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/DOMApplicationCache.cpp60
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/DOMApplicationCache.h6
-rw-r--r--src/3rdparty/webkit/WebCore/loader/appcache/DOMApplicationCache.idl11
-rw-r--r--src/3rdparty/webkit/WebCore/loader/loader.cpp47
-rw-r--r--src/3rdparty/webkit/WebCore/loader/loader.h28
-rw-r--r--src/3rdparty/webkit/WebCore/page/Chrome.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/page/Console.cpp29
-rw-r--r--src/3rdparty/webkit/WebCore/page/ContextMenuClient.h1
-rw-r--r--src/3rdparty/webkit/WebCore/page/DOMWindow.cpp40
-rw-r--r--src/3rdparty/webkit/WebCore/page/DOMWindow.h1
-rw-r--r--src/3rdparty/webkit/WebCore/page/DOMWindow.idl9
-rw-r--r--src/3rdparty/webkit/WebCore/page/DragController.cpp121
-rw-r--r--src/3rdparty/webkit/WebCore/page/DragController.h4
-rw-r--r--src/3rdparty/webkit/WebCore/page/EventHandler.cpp38
-rw-r--r--src/3rdparty/webkit/WebCore/page/EventHandler.h6
-rw-r--r--src/3rdparty/webkit/WebCore/page/Frame.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/page/FrameView.cpp36
-rw-r--r--src/3rdparty/webkit/WebCore/page/FrameView.h1
-rw-r--r--src/3rdparty/webkit/WebCore/page/History.idl4
-rw-r--r--src/3rdparty/webkit/WebCore/page/Location.idl6
-rw-r--r--src/3rdparty/webkit/WebCore/page/Page.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/page/Page.h17
-rw-r--r--src/3rdparty/webkit/WebCore/page/PageGroup.cpp20
-rw-r--r--src/3rdparty/webkit/WebCore/page/PageGroup.h10
-rw-r--r--src/3rdparty/webkit/WebCore/page/SecurityOrigin.cpp93
-rw-r--r--src/3rdparty/webkit/WebCore/page/SecurityOrigin.h7
-rw-r--r--src/3rdparty/webkit/WebCore/page/Settings.cpp19
-rw-r--r--src/3rdparty/webkit/WebCore/page/Settings.h8
-rw-r--r--src/3rdparty/webkit/WebCore/page/XSSAuditor.cpp171
-rw-r--r--src/3rdparty/webkit/WebCore/page/XSSAuditor.h104
-rw-r--r--src/3rdparty/webkit/WebCore/page/animation/CompositeAnimation.cpp173
-rw-r--r--src/3rdparty/webkit/WebCore/page/animation/ImplicitAnimation.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/page/animation/ImplicitAnimation.h4
-rw-r--r--src/3rdparty/webkit/WebCore/page/win/FrameCGWin.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/ContextMenu.cpp16
-rw-r--r--src/3rdparty/webkit/WebCore/platform/FileChooser.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/KeyboardCodes.h4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/Logging.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/Logging.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/PlatformWheelEvent.h4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/PurgeableBuffer.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/ScrollView.cpp20
-rw-r--r--src/3rdparty/webkit/WebCore/platform/ScrollView.h5
-rw-r--r--src/3rdparty/webkit/WebCore/platform/Scrollbar.h1
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/CursorAndroid.cpp295
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/DragDataAndroid.cpp (renamed from src/3rdparty/webkit/WebCore/dom/StaticStringList.h)97
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/EventLoopAndroid.cpp38
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/FileChooserAndroid.cpp61
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/FileSystemAndroid.cpp131
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/KeyEventAndroid.cpp273
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/KeyboardCodes.h545
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/LocalizedStringsAndroid.cpp (renamed from src/3rdparty/webkit/WebCore/dom/StaticStringList.cpp)45
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/PopupMenuAndroid.cpp57
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/RenderThemeAndroid.cpp334
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/RenderThemeAndroid.h109
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/ScreenAndroid.cpp109
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/ScrollViewAndroid.cpp105
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/SearchPopupMenuAndroid.cpp52
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/SystemTimeAndroid.cpp37
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/TemporaryLinkStubs.cpp673
-rw-r--r--src/3rdparty/webkit/WebCore/platform/android/WidgetAndroid.cpp128
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/Color.cpp35
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/Color.h1
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FloatPoint.h9
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FloatRect.h5
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/Font.cpp22
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/Font.h13
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FontCache.cpp22
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FontFallbackList.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FontFallbackList.h14
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/FontFastPath.cpp15
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/IntPoint.h29
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/IntRect.h8
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/IntSize.h7
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/MediaPlayer.cpp39
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/MediaPlayer.h39
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/MediaPlayerPrivate.h13
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FEBlend.h3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FEColorMatrix.h3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FEComponentTransfer.h3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FEComposite.h3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/Filter.h14
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FilterEffect.cpp37
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/FilterEffect.h35
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/SourceAlpha.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/SourceGraphic.cpp18
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/filters/SourceGraphic.h4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/qt/FontFallbackListQt.cpp15
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/qt/GraphicsContextQt.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/qt/ImageDecoderQt.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/qt/ImageDecoderQt.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/platform/graphics/transforms/TransformationMatrix.h4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/image-decoders/ImageDecoder.h193
-rw-r--r--src/3rdparty/webkit/WebCore/platform/image-decoders/cairo/ImageDecoderCairo.cpp124
-rw-r--r--src/3rdparty/webkit/WebCore/platform/image-decoders/wx/ImageDecoderWx.cpp172
-rw-r--r--src/3rdparty/webkit/WebCore/platform/mac/ClipboardMac.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/mac/ClipboardMac.mm25
-rw-r--r--src/3rdparty/webkit/WebCore/platform/mac/LoggingMac.mm2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/HTTPParsers.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/HTTPParsers.h1
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/ResourceResponseBase.cpp34
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/ResourceResponseBase.h4
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/qt/QNetworkReplyHandler.cpp36
-rw-r--r--src/3rdparty/webkit/WebCore/platform/network/qt/QNetworkReplyHandler.h8
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/ClipboardQt.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/ClipboardQt.h5
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/LoggingQt.cpp44
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/PlatformKeyboardEventQt.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/RenderThemeQt.cpp129
-rw-r--r--src/3rdparty/webkit/WebCore/platform/qt/RenderThemeQt.h15
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/BidiResolver.h25
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/PlatformString.h10
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/String.cpp31
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/StringImpl.cpp17
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/StringImpl.h2
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/android/TextBreakIteratorInternalICU.cpp36
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/qt/StringQt.cpp16
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/symbian/StringImplSymbian.cpp53
-rw-r--r--src/3rdparty/webkit/WebCore/platform/text/symbian/StringSymbian.cpp50
-rw-r--r--src/3rdparty/webkit/WebCore/platform/win/SystemTimeWin.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/plugins/PluginDebug.h4
-rw-r--r--src/3rdparty/webkit/WebCore/plugins/mac/PluginPackageMac.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/plugins/mac/PluginViewMac.cpp29
-rw-r--r--src/3rdparty/webkit/WebCore/plugins/qt/PluginPackageQt.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/AutoTableLayout.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/FixedTableLayout.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/InlineFlowBox.cpp33
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/InlineFlowBox.h6
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/InlineTextBox.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/MediaControlElements.cpp49
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/MediaControlElements.h4
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBlock.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBlock.h15
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBox.cpp50
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBox.h6
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBoxModelObject.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderBoxModelObject.h3
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderDataGrid.cpp122
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderDataGrid.h70
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderFieldset.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderImage.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayer.cpp92
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayer.h18
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayerBacking.cpp175
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayerBacking.h16
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayerCompositor.cpp431
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderLayerCompositor.h32
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderMedia.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderMediaControls.cpp38
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderMenuList.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderObject.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderObject.h10
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderPartObject.cpp20
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderReplica.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderScrollbar.h1
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTable.cpp21
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTableCell.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTableCol.cpp23
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTableCol.h7
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTextControl.cpp8
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTextControlMultiLine.cpp3
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTextControlSingleLine.cpp23
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTheme.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderTheme.h28
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumLinux.cpp546
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumLinux.h98
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumMac.h9
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumMac.mm25
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumSkia.cpp621
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumSkia.h146
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumWin.cpp417
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeChromiumWin.h84
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeMac.h7
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeSafari.cpp47
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeSafari.h9
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeWin.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderThemeWin.h7
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderVideo.cpp35
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/RenderVideo.h15
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/SVGRenderSupport.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/bidi.cpp175
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/style/RenderStyle.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/style/RenderStyle.h6
-rw-r--r--src/3rdparty/webkit/WebCore/rendering/style/StyleRareInheritedData.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/storage/LocalStorage.cpp172
-rw-r--r--src/3rdparty/webkit/WebCore/storage/LocalStorageTask.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/storage/LocalStorageTask.h22
-rw-r--r--src/3rdparty/webkit/WebCore/storage/LocalStorageThread.cpp24
-rw-r--r--src/3rdparty/webkit/WebCore/storage/LocalStorageThread.h14
-rw-r--r--src/3rdparty/webkit/WebCore/storage/SessionStorageArea.cpp89
-rw-r--r--src/3rdparty/webkit/WebCore/storage/SessionStorageArea.h57
-rw-r--r--src/3rdparty/webkit/WebCore/storage/Storage.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/storage/Storage.h4
-rw-r--r--src/3rdparty/webkit/WebCore/storage/Storage.idl3
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageArea.cpp155
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageArea.h67
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageAreaSync.cpp (renamed from src/3rdparty/webkit/WebCore/storage/LocalStorageArea.cpp)259
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageAreaSync.h (renamed from src/3rdparty/webkit/WebCore/storage/LocalStorageArea.h)60
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageEvent.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageEvent.h4
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageEvent.idl3
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageMap.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageMap.h4
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageNamespace.cpp129
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageNamespace.h (renamed from src/3rdparty/webkit/WebCore/storage/SessionStorage.h)52
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageSyncManager.cpp (renamed from src/3rdparty/webkit/WebCore/storage/SessionStorage.cpp)79
-rw-r--r--src/3rdparty/webkit/WebCore/storage/StorageSyncManager.h (renamed from src/3rdparty/webkit/WebCore/storage/LocalStorage.h)42
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGAnimatedProperty.h2
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGDocument.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGDocument.h2
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGImageElement.cpp11
-rw-r--r--src/3rdparty/webkit/WebCore/svg/SVGUseElement.cpp6
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/SVGImage.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/SVGResourceFilter.cpp45
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/SVGResourceFilter.h7
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEDisplacementMap.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEFlood.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEGaussianBlur.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEImage.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEImage.h2
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEMerge.cpp34
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEMerge.h3
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEMorphology.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEOffset.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFEOffset.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFESpecularLighting.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFETile.cpp41
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFETile.h1
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFilter.cpp39
-rw-r--r--src/3rdparty/webkit/WebCore/svg/graphics/filters/SVGFilter.h4
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLAnchorElement.cpp1
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLCardElement.cpp5
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLCardElement.h1
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLDoElement.cpp7
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLDoElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLElement.cpp4
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLElement.h4
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLFieldSetElement.cpp13
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLFieldSetElement.h2
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLOptGroupElement.cpp12
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLOptGroupElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLPostfieldElement.cpp25
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLPostfieldElement.h9
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLSetvarElement.cpp19
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLSetvarElement.h8
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLTimerElement.cpp17
-rw-r--r--src/3rdparty/webkit/WebCore/wml/WMLTimerElement.h3
-rw-r--r--src/3rdparty/webkit/WebCore/workers/Worker.cpp26
-rw-r--r--src/3rdparty/webkit/WebCore/workers/Worker.h14
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerContext.cpp29
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerContext.idl2
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerLoaderProxy.h64
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerMessagingProxy.cpp13
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerMessagingProxy.h11
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerScriptLoader.cpp (renamed from src/3rdparty/webkit/WebCore/workers/WorkerImportScriptsClient.cpp)66
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerScriptLoader.h (renamed from src/3rdparty/webkit/WebCore/workers/WorkerImportScriptsClient.h)39
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerScriptLoaderClient.h (renamed from src/3rdparty/webkit/WebCore/dom/DOMStringList.h)23
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerThread.cpp9
-rw-r--r--src/3rdparty/webkit/WebCore/workers/WorkerThread.h11
-rw-r--r--src/3rdparty/webkit/WebCore/xml/XMLHttpRequest.cpp2
-rw-r--r--src/3rdparty/webkit/WebCore/xml/XPathFunctions.cpp8
-rw-r--r--src/3rdparty/webkit/WebKit.pri9
-rw-r--r--src/3rdparty/webkit/WebKit/ChangeLog8
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebelement.cpp16
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebframe.cpp28
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebframe.h4
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebframe_p.h2
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebhistory.cpp139
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebhistory.h24
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebhistory_p.h27
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebpage.cpp112
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebpage.h13
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebpage_p.h3
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebsettings.cpp9
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebsettings.h2
-rw-r--r--src/3rdparty/webkit/WebKit/qt/Api/qwebview.cpp15
-rw-r--r--src/3rdparty/webkit/WebKit/qt/ChangeLog278
-rw-r--r--src/3rdparty/webkit/WebKit/qt/WebCoreSupport/ContextMenuClientQt.cpp6
-rw-r--r--src/3rdparty/webkit/WebKit/qt/WebCoreSupport/ContextMenuClientQt.h1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp8
-rw-r--r--src/3rdparty/webkit/WebKit/qt/docs/qtwebkit.qdoc5
-rw-r--r--src/3rdparty/webkit/WebKit/qt/docs/qtwebkit.qdocconf3
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp3
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page1.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page2.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page3.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page4.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page5.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/data/page6.html1
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/qwebhistory.pro7
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/tst_qwebhistory.cpp326
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/qwebhistory/tst_qwebhistory.qrc11
-rw-r--r--src/3rdparty/webkit/WebKit/qt/tests/tests.pro2
1138 files changed, 171055 insertions, 145237 deletions
diff --git a/src/3rdparty/webkit/ChangeLog b/src/3rdparty/webkit/ChangeLog
index 1946d56..f2cc9a2 100644
--- a/src/3rdparty/webkit/ChangeLog
+++ b/src/3rdparty/webkit/ChangeLog
@@ -1,3 +1,72 @@
+2009-06-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Jan Alonzo.
+
+ Adding files for the new test case for loading statuses.
+
+ * GNUmakefile.am:
+
+2009-06-15 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ Version bump in preparation for 1.1.10 release.
+
+ * configure.ac:
+
+2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Xan Lopez.
+
+ Refactor handling of options in the build-webkit script
+
+ Options are now defined in one place, and then reused when creating
+ the usage help text, the arguments to GetOptions(), and when passing
+ the options on to the underlying port-dependent build systems.
+
+ This allows the Qt port to read the defaults for the options from the
+ pro file (dynamically), and to pass the options on to qmake at build.
+
+ * configure.ac:
+
+2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ [Qt] Fix release build detection
+ https://bugs.webkit.org/show_bug.cgi?id=26267
+
+ * WebKit.pri:
+
+2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Xan Lopez.
+
+ Add unit tests for our WebKitNetworkRequest object.
+
+ * GNUmakefile.am:
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ Version bump in preparation for 1.1.9 release.
+
+ * configure.ac:
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25415
+ [GTK][ATK] Please implement support for get_text_at_offset
+
+ Add new dependency on the Gail utils library, needed for our a11y
+ implementation.
+
+ * GNUmakefile.am:
+ * configure.ac:
+
2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Jan Alonzo.
diff --git a/src/3rdparty/webkit/JavaScriptCore/API/JSBase.h b/src/3rdparty/webkit/JavaScriptCore/API/JSBase.h
index 6f012ca..9f3d88e 100644
--- a/src/3rdparty/webkit/JavaScriptCore/API/JSBase.h
+++ b/src/3rdparty/webkit/JavaScriptCore/API/JSBase.h
@@ -69,6 +69,14 @@ typedef struct OpaqueJSValue* JSObjectRef;
#define JS_EXPORT
#elif defined(__GNUC__)
#define JS_EXPORT __attribute__((visibility("default")))
+#elif defined(_WIN32_WCE)
+ #if defined(JS_BUILDING_JS)
+ #define JS_EXPORT __declspec(dllexport)
+ #elif defined(JS_IMPORT_JS)
+ #define JS_EXPORT __declspec(dllimport)
+ #else
+ #define JS_EXPORT
+ #endif
#elif defined(WIN32) || defined(_WIN32)
/*
* TODO: Export symbols with JS_EXPORT when using MSVC.
diff --git a/src/3rdparty/webkit/JavaScriptCore/ChangeLog b/src/3rdparty/webkit/JavaScriptCore/ChangeLog
index fbda515..c8bba0f 100644
--- a/src/3rdparty/webkit/JavaScriptCore/ChangeLog
+++ b/src/3rdparty/webkit/JavaScriptCore/ChangeLog
@@ -1,39240 +1,978 @@
-2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+2009-06-26 Oliver Hunt <oliver@apple.com>
- Reviewed by Simon Hausmann.
-
- [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
-
- * JavaScriptCore.pri:
- * JavaScriptCore.pro:
- * jsc.pro:
-
-2009-06-07 Gavin Barraclough <barraclough@apple.com>
-
- RS by Sam Weinig.
-
- Remove bonus bogus \n from last commit.
-
- * jit/JITStubs.cpp:
- (JSC::):
-
-2009-06-07 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Change the implementation of op_throw so the stub function always modifies its
- return address - if it doesn't find a 'catch' it will switch to a trampoline
- to force a return from JIT execution. This saves memory, by avoiding the need
- for a unique return for every op_throw.
-
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_throw):
- JITStubs::cti_op_throw now always changes its return address,
- remove return code generated after the stub call (this is now
- handled by ctiOpThrowNotCaught).
- * jit/JITStubs.cpp:
- (JSC::):
- Add ctiOpThrowNotCaught definitions.
- (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- Change cti_op_throw to always change its return address.
- * jit/JITStubs.h:
- Add ctiOpThrowNotCaught declaration.
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Rudder stamped by Sam Weinig.
-
- Add missing ASSERT.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::getRelocatedAddress):
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Switch storePtrWithPatch to take the initial immediate value as an argument.
-
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::storePtrWithPatch):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_jsr):
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove patchLength..tByIdExternalLoadPrefix magic numbers from JIT.h.
-
- These aren't really suitable values to be tracking within common code
- of the JIT, since they are not (and realistically cannot) be checked
- by ASSERTs, as the other repatch offsets are. Move this functionality
- (skipping the REX prefix when patching load instructions to LEAs on
- x86-64) into the X86Assembler.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadPtrToLEA):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::repatchLoadPtrToLEA):
- * jit/JIT.h:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
-
-2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
-
- Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
-
- <https://bugs.webkit.org/show_bug.cgi?id=26160>
-
- Reviewed by Alexey Proskuryakov.
-
- Use /bin/ln instead of ln for cases where this command is used with -h option.
- As this option is not supported by GNU fileutils, this change helps users
- who have GNU fileutils in their PATH.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Remove DoubleNotEqual floating point comparison condition for now -
- it is not used, and it is unclear the semantics are correct (I think
- this comparison would actually give you not-equal-or-unordered, which
- might be what is wanted... we can revisit this interface & get it
- right when required).
-
- Also, fix asserts in branchArith32 ops. All adds & subs can check
- for Signed, multiply only sets OF so can only check for overflow.
-
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::):
- (JSC::MacroAssemblerX86Common::branchAdd32):
- (JSC::MacroAssemblerX86Common::branchMul32):
- (JSC::MacroAssemblerX86Common::branchSub32):
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Minor tidy up in JITStubs.
-
- * jit/JITStubs.cpp:
- (JSC::StackHack::StackHack):
- * jit/JITStubs.h:
-
-2009-06-05 Koen Kooi <koen@dominion.thruhere.net>
-
- Reviewed by Xan Lopez.
-
- Build fix for glib unicode backend.
-
- * wtf/unicode/glib/UnicodeMacrosFromICU.h:
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- 3 tiny cleanups:
-
- * assembler/MacroAssemblerX86.h:
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- store*() methods should take an ImplicitAddress, rather than an Address.
- * assembler/X86Assembler.h:
- Make patchPointer private.
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_ret):
- Remove empty line at end of function.
-
-2009-06-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Encapsulate many uses of void* in the assembler & jit with types that provide
- more semantic information. The new types are:
-
- * MacroAssemblerCodePtr - this wraps a pointer into JIT generated code.
- * FunctionPtr - this wraps a pointer to a C/C++ function in JSC.
- * ReturnAddressPtr - this wraps a return address resulting from a 'call' instruction.
-
- Wrapping these types allows for stronger type-checking than is possible with everything
- represented a void*. For example, it is now enforced by the type system that near
- calls can only be linked to JIT code and not to C functions in JSC (this was previously
- required, but could not be enforced on the interface).
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::dataLocation):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::executableAddress):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA):
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::operator!):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::reset):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
- (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
- (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
- (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
- (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
- (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue):
- (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::addressForLookup):
- (JSC::AbstractMacroAssembler::trampolineAt):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
- (JSC::::CodeLocationCommon::instructionAtOffset):
- (JSC::::CodeLocationCommon::labelAtOffset):
- (JSC::::CodeLocationCommon::jumpAtOffset):
- (JSC::::CodeLocationCommon::callAtOffset):
- (JSC::::CodeLocationCommon::nearCallAtOffset):
- (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
- (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- * assembler/MacroAssemblerCodeRef.h:
- (JSC::FunctionPtr::FunctionPtr):
- (JSC::FunctionPtr::value):
- (JSC::FunctionPtr::executableAddress):
- (JSC::ReturnAddressPtr::ReturnAddressPtr):
- (JSC::ReturnAddressPtr::value):
- (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
- (JSC::MacroAssemblerCodePtr::executableAddress):
- (JSC::MacroAssemblerCodePtr::dataLocation):
- (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::patchPointerForCall):
- * jit/JIT.cpp:
- (JSC::ctiPatchNearCallByReturnAddress):
- (JSC::ctiPatchCallByReturnAddress):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::JIT::compileCTIMachineTrampolines):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- * jit/JITCode.h:
- (JSC::JITCode::operator !):
- (JSC::JITCode::addressForCall):
- (JSC::JITCode::offsetOf):
- (JSC::JITCode::execute):
- (JSC::JITCode::size):
- (JSC::JITCode::HostFunction):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitNakedCall):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- * jit/JITStubs.cpp:
- (JSC::JITThunks::JITThunks):
- (JSC::JITThunks::tryCachePutByID):
- (JSC::JITThunks::tryCacheGetByID):
- (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- * jit/JITStubs.h:
- (JSC::JITThunks::ctiArrayLengthTrampoline):
- (JSC::JITThunks::ctiStringLengthTrampoline):
- (JSC::JITThunks::ctiVirtualCallPreLink):
- (JSC::JITThunks::ctiVirtualCallLink):
- (JSC::JITThunks::ctiVirtualCall):
- (JSC::JITThunks::ctiNativeCallThunk):
- * yarr/RegexJIT.h:
- (JSC::Yarr::RegexCodeBlock::operator!):
- (JSC::Yarr::RegexCodeBlock::execute):
-
-2009-06-05 Antti Koivisto <antti@apple.com>
-
- Try to unbreak Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-06-03 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=13128
- Safari not obeying cache header
-
- Export JSC::parseDate()
-
- * JavaScriptCore.exp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2009-06-04 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug in property caching of getters and setters.
-
- Make sure that the transition logic accounts for getters and setters.
- If we don't we end up screwing up the transition tables so that some
- transitions will start incorrectly believing that they need to check
- for getters and setters.
-
- * runtime/JSObject.cpp:
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- * runtime/JSObject.h:
- (JSC::):
- * runtime/Structure.h:
-
-2009-06-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Minor tweak to PatchBuffer, change it so it no longer holds a CodeRef, and instead
- holds a separate code pointer and executable pool. Since it now always holds its
- own copy of the code size, and to simplify the construction sequence, it's neater
- this way.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
- (JSC::AbstractMacroAssembler::PatchBuffer::finalizeCode):
- (JSC::AbstractMacroAssembler::PatchBuffer::code):
- (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
-
-2009-06-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Remove 'JIT_STUB_ARGUMENT_STACK' this is unused and untested.
-
- This just leaves JIT_STUB_ARGUMENT_REGISTER and JIT_STUB_ARGUMENT_VA_LIST.
- Since JIT_STUB_ARGUMENT_REGISTER is the sensible configuration on most platforms,
- remove this define and make this the default behaviour.
- Platforms must now define JIT_STUB_ARGUMENT_VA_LIST to get crazy va_list voodoo,
- if they so desire.
-
- (Refactoring of #ifdefs only, no functional change, no performance impact.)
-
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- * jit/JITStubs.cpp:
- (JSC::):
- * jit/JITStubs.h:
- * wtf/Platform.h:
-
-2009-06-04 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Sam Weinig.
-
- * jit/JITArithmetic.cpp:
- Remove some redundant typedefs, unused since arithmetic was added to the MacroAssembler interface.
-
-2009-06-04 Brent Fulgham <bfulgham@webkit.org>
-
- Build fix due to header include problem.
-
- * interpreter/Interpreter.h: Remove wtf from includes so that
- compile can find the headers in expected places.
-
-2009-06-04 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- HashTable class (JavaScriptCore/wtf/HashTable.h) doesn't instantiated by 'new', so
- inheritance was removed. HashTable struct has been instantiated by operator new in
- JSGlobalData.cpp:106.
- HashTable couldn't inherited from FastAllocBase since struct with inheritance is
- no longer POD, so HashTable struct has been instantiated by fastNew, destroyed by
- fastDelete.
-
- * interpreter/Interpreter.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::~JSGlobalData):
- * wtf/HashTable.h:
-
-2009-06-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Wrap the code that plants pushes/pops planted by JIT in explanatorily named
- methods; move property storage reallocation into a standard stub function.
-
- ~No performance impact (possible <1% progression on x86-64, likely just noise).
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- Wrap calls to push/pop.
- * jit/JIT.h:
- Declare the new wrapper methods.
- * jit/JITInlineMethods.h:
- (JSC::JIT::preverveReturnAddressAfterCall):
- (JSC::JIT::restoreReturnAddressBeforeReturn):
- Define the new wrapper methods.
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_end):
- (JSC::JIT::emit_op_ret):
- Wrap calls to push/pop.
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- Move property storage reallocation into a standard stub function.
- * jit/JITStubs.cpp:
- (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- * jit/JITStubs.h:
- (JSC::JITStubs::):
-
-2009-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- [Qt] Single-threaded QtWebKit configuration
- <https://bugs.webkit.org/show_bug.cgi?id=26015>
-
- * JavaScriptCore.pri: Use ThreadingNone.cpp instead of
- ThreadingQt.cpp and make sure ENABLE_JSC_MULTIPLE_THREADS is turned off
- when ENABLE_SINGLE_THREADED is tuned on
- * wtf/ThreadingNone.cpp:
- (WTF::ThreadCondition::wait): Fix compilation warning.
- (WTF::ThreadCondition::timedWait): Ditto.
-
-2009-06-02 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
-
- * Configurations/Base.xcconfig:
-
-2009-06-02 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Sam Weinig.
-
- Use C-style comments in Platform.h so it can be included from C
- files.
-
- * wtf/Platform.h:
-
-2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
-
- This fixes the Windows-build if the user does not have a /tmp directory.
-
- * pcre/dftables:
-
-2009-06-02 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver ">>" Hunt.
-
- emitSlow_op_rshift is linking the wrong number of slow cases, if !supportsFloatingPoint().
- Fixerate, and refactor/comment the code a little to make it clearer what is going on.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::emit_op_rshift):
- (JSC::JIT::emitSlow_op_rshift):
-
-2009-06-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by NOBODY - speculative windows build fix (errm, for the other patch!).
-
- * jit/JITStubs.cpp:
- (JSC::):
-
-2009-06-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by NOBODY - speculative windows build fix.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::::CodeLocationCall::CodeLocationCall):
- (JSC::::CodeLocationNearCall::CodeLocationNearCall):
-
-2009-06-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Olliej Hunt.
-
- Change JITStub functions from being static members on the JITStub class to be
- global extern "C" functions, and switch their the function signature declaration
- in the definition of the functions to be C-macro generated. This makes it easier
- to work with the stub functions from assembler code (since the names no longer
- require mangling), and by delaring the functions with a macro we can look at
- also auto-generating asm thunks to wrap the JITStub functions to perform the
- work currently in 'restoreArgumentReference' (as a memory saving).
-
- Making this change also forces us to be a bit more realistic about what is private
- on the Register and CallFrame objects. Presently most everything on these classes
- is private, and the classes have plenty of friends. We could befriend all the
- global functions to perpetuate the delusion of encapsulation, but using friends is
- a bit of a sledgehammer solution here - since friends can poke around with all of
- the class's privates, and since all the major classes taht operate on Regsiters are
- currently friends, right there is currently in practice very little protection at
- all. Better to start removing friend delclarations, and exposing just the parts
- that need to be exposed.
-
- * interpreter/CallFrame.h:
- (JSC::ExecState::returnPC):
- (JSC::ExecState::setCallerFrame):
- (JSC::ExecState::returnValueRegister):
- (JSC::ExecState::setArgumentCount):
- (JSC::ExecState::setCallee):
- (JSC::ExecState::setCodeBlock):
- * interpreter/Interpreter.h:
- * interpreter/Register.h:
- (JSC::Register::Register):
- (JSC::Register::i):
- * jit/JITStubs.cpp:
- (JSC::):
- (JSC::JITThunks::JITThunks):
- (JSC::JITThunks::tryCachePutByID):
- (JSC::JITThunks::tryCacheGetByID):
- (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- * jit/JITStubs.h:
- (JSC::JITStubs::):
- * runtime/JSFunction.h:
- (JSC::JSFunction::nativeFunction):
- (JSC::JSFunction::classInfo):
- * runtime/JSGlobalData.h:
-
-2009-06-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Tidy up the literal parser.
-
- Make the number lexing in the LiteralParser exactly match the JSON spec, which
- makes us cover more cases, but also more strict. Also made string lexing only
- allow double-quoted strings.
-
- * runtime/LiteralParser.cpp:
- (JSC::LiteralParser::Lexer::lex):
- (JSC::LiteralParser::Lexer::lexString):
- (JSC::LiteralParser::Lexer::lexNumber):
-
-2009-06-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam "WX" Weinig.
-
- Allow the JIT to operate without relying on use of RWX memory, on platforms where this is supported.
-
- This patch adds a switch to Platform.h (ENABLE_ASSEMBLER_WX_EXCLUSIVE) which enables this mode of operation.
- When this flag is set, all executable memory will be allocated RX, and switched to RW only whilst being
- modified. Upon completion of code generation the protection is switched back to RX to allow execution.
-
- Further optimization will be required before it is desirable to enable this mode of operation by default;
- enabling this presently incurs a 5%-10% regression.
-
- (Submitting disabled - no performance impact).
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::fromFunctionPointer):
- (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToFunction):
- (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
- (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
- (JSC::::CodeLocationCommon::nearCallAtOffset):
- (JSC::::CodeLocationCall::CodeLocationCall):
- (JSC::::CodeLocationNearCall::CodeLocationNearCall):
- * assembler/AssemblerBuffer.h:
- (JSC::AssemblerBuffer::executableCopy):
- * assembler/X86Assembler.h:
- (JSC::CAN_SIGN_EXTEND_U32_64):
- (JSC::X86Assembler::linkJump):
- (JSC::X86Assembler::linkCall):
- (JSC::X86Assembler::patchPointer):
- (JSC::X86Assembler::relinkJump):
- (JSC::X86Assembler::relinkCall):
- (JSC::X86Assembler::repatchInt32):
- (JSC::X86Assembler::repatchPointer):
- (JSC::X86Assembler::repatchLoadToLEA):
- (JSC::X86Assembler::patchInt32):
- (JSC::X86Assembler::patchRel32):
- * jit/ExecutableAllocator.h:
- (JSC::ExecutableAllocator::):
- (JSC::ExecutableAllocator::makeWritable):
- (JSC::ExecutableAllocator::makeExecutable):
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- * jit/ExecutableAllocatorPosix.cpp:
- (JSC::ExecutablePool::systemAlloc):
- (JSC::ExecutablePool::systemRelease):
- (JSC::ExecutableAllocator::reprotectRegion):
- * jit/ExecutableAllocatorWin.cpp:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- * wtf/Platform.h:
-
-2009-05-29 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- Inherits Interpreter class from FastAllocBase because it has been
- instantiated by 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
-
- * interpreter/Interpreter.h:
-
-2009-06-01 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY (windows build fix).
-
- Add exports for windows (corresponding to the JavaScriptCore.exp modification
- in the previous change).
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-06-01 David Levin <levin@chromium.org>
-
- Reviewed by Darin Alder and Maciej Stachowiak.
-
- Bug 26057: StringImpl should share buffers with UString.
- https://bugs.webkit.org/show_bug.cgi?id=26057
-
- * JavaScriptCore.exp:
- * runtime/UString.cpp:
- (JSC::UString::Rep::create):
- (JSC::UString::BaseString::sharedBuffer): Only do the sharing when
- the buffer exceeds a certain size. The size was tuned by running
- various dom benchmarks with numbers ranging from 20 to 800 and finding
- a place that seemed to do the best overall.
- * runtime/UString.h:
-
-2009-05-31 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Olliej "you just need to change NativeFunctionWrapper.h" Hunt.
-
- Add ENABLE_JIT_OPTIMIZE_NATIVE_CALL switch to allow JIT to operate without native call optimizations.
-
- * runtime/NativeFunctionWrapper.h:
- * wtf/Platform.h:
-
-2009-05-30 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
- "Maximum call stack size exceeded"
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks.
- We need a limit of at least 100 to run the benchmark above.
- (JSC::arrayProtoFuncToLocaleString): Ditto.
- (JSC::arrayProtoFuncJoin): Ditto.
-
-2009-05-28 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Added new build flag --filters for Mac. More details in WebCore/ChangeLog.
-
- * Configurations/FeatureDefines.xcconfig:
-
-2009-05-27 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz
-
- We should always check for exceptions after creating a CachedCall, this wasn't being done in
- the string replace logic.
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
-
-2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed (make distcheck) build fix; adding missing headers.
-
- * GNUmakefile.am:
-
-2009-05-27 Jessie Berlin <jberlin@apple.com>
-
- Reviewed by Adam Roben
-
- Fix the Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Gustavo Noronha.
-
- When building on Windows, consider Windows specific files.
-
- * GNUmakefile.am:
-
-2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Maciej Stachowiak.
-
- When building with MinGW, don't use the __declspec(dl{import,export})
- decorations and rely on the linker to use its nifty auto-import feature.
- It is extremely hard to get the decorations right with MinGW in general
- and impossible in WebKit, where the resulting shared library is linking
- together some static libraries.
-
- * config.h:
-
-2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- https://bugs.webkit.org/show_bug.cgi?id=25613
-
- Be able to use GOwnPtr for GHashTable as well. The assumption
- is that the hash table has been created with g_hash_table_new_full
- and has proper destruction functions.
-
- * wtf/GOwnPtr.cpp:
- (WTF::GHashTable):
- * wtf/GOwnPtr.h:
-
-2009-05-26 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6924033> REGRESSION: Assertion failure due to forward references
-
- Add a pattern type for forward references to ensure that we don't confuse the
- quantifier alternatives assertion.
-
- * yarr/RegexCompiler.cpp:
- (JSC::Yarr::RegexPatternConstructor::atomBackReference):
- (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- * yarr/RegexInterpreter.cpp:
- (JSC::Yarr::ByteCompiler::emitDisjunction):
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::generateTerm):
- * yarr/RegexPattern.h:
- (JSC::Yarr::PatternTerm::):
- (JSC::Yarr::PatternTerm::PatternTerm):
- (JSC::Yarr::PatternTerm::ForwardReference):
-
-2009-05-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
- and also an ASSERT failure on http://ihasahotdog.com/.
-
- When overwriting a property on a dictionary with a cached specific value,
- clear the cache if new value being written is different.
-
- * JavaScriptCore.exp:
- Export the new symbols.
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_get_by_id_method_check_second):
- Close dictionary prototypes upon caching a method access, as would happen when caching
- a regular get_by_id.
- * runtime/JSObject.h:
- (JSC::JSObject::propertyStorage):
- (JSC::JSObject::locationForOffset):
- Make these methods private.
- (JSC::JSObject::putDirectInternal):
- When overwriting a property on a dictionary with a cached specific value,
- clear the cache if new value being written is different.
- * runtime/Structure.cpp:
- (JSC::Structure::despecifyDictionaryFunction):
- Reset the specific value field for a given property in a dictionary.
- (JSC::Structure::despecifyFunctionTransition):
- Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).
- * runtime/Structure.h:
- Declare new method.
-
-2009-05-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver "pieces of eight" Hunt.
-
- When reseting RegexPattern class, should fully reset the class, not just bits of it.
- In particular, we delete the cached character classes (for wordchars, etc), but do
- not reset the set of pointers to the cached classes. In the case of a repeated parse
- due to an illegal back-reference we will continue to use the deleted character class.
-
- * yarr/RegexPattern.h:
- (JSC::Yarr::RegexPattern::reset):
-
-2009-05-26 Brent Fulgham <bfulgham@webkit.org>
-
- Build fix to correct r44161.
-
- * wtf/FastAllocBase.h:
-
-2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
-
- Reviewed by Maciej Stachowiak.
-
- Inherite HashTable from FastAllocBase, because it has been instantiated by
- 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
-
- * wtf/HashTable.h:
- * wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
-
-2009-05-25 David Levin <levin@chromium.org>
-
- Reviewed by Maciej Stachowiak and Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=25126
- Allow the buffer underlying UString to be shared.
-
- In order to not grow the underlying size of any structure,
- there is a union in the Rep string which holds
- + m_sharedBuffer -- a pointer to the shared ref counted buffer
- if the class is BaseString and the buffer is being shared OR
- + m_baseString -- the BaseString if the class is only UString::Rep
- but not a UString::BaseString
-
- Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
- it is in a union.
-
- No change in sunspider perf.
-
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * runtime/UString.cpp:
- (JSC::UString::Rep::share):
- (JSC::UString::Rep::destroy):
- (JSC::UString::BaseString::sharedBuffer):
- (JSC::UString::BaseString::setSharedBuffer):
- (JSC::UString::BaseString::slowIsBufferReadOnly):
- (JSC::expandCapacity):
- (JSC::UString::Rep::reserveCapacity):
- (JSC::UString::expandPreCapacity):
- (JSC::concatenate):
- (JSC::UString::append):
- * runtime/UString.h:
- (JSC::UString::Rep::Rep):
- (JSC::UString::Rep::):
- (JSC::UString::BaseString::isShared):
- (JSC::UString::BaseString::isBufferReadOnly):
- (JSC::UString::Rep::baseString):
- * wtf/CrossThreadRefCounted.h:
- (WTF::CrossThreadRefCounted::isShared):
- * wtf/OwnFastMallocPtr.h: Added.
- (WTF::OwnFastMallocPtr::OwnFastMallocPtr):
- (WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
- (WTF::OwnFastMallocPtr::get):
- (WTF::OwnFastMallocPtr::release):
-
-2009-05-25 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it
-
- * wtf/Platform.h:
-
-2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Maciej Stachowiak.
-
- The functions written in assembly need to have a leading
- underscore on Windows too.
-
- * jit/JITStubs.cpp:
-
-2009-05-24 Steve Falkenburg <sfalken@apple.com>
-
- Build fix for experimental PGO Windows target.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
-
- <https://bugs.webkit.org/show_bug.cgi?id=25495>
-
- Reviewed by Oliver Hunt.
-
- * GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
- * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
-
- * wtf/OwnPtr.h:
- (WTF::OwnPtr::OwnPtr): Added constructors that take a
- PassOwnPtr. Also added a copy constructor declaration that's
- required when assigning a PassOwnPtr to a stack-based OwnPtr.
- (WTF::operator=): Added assignment operator methods that take a
- PassOwnPtr.
- (WTF::swap): Reformatted.
- (WTF::operator==): Whitespace changes.
- (WTF::operator!=): Ditto.
-
- * wtf/OwnPtrCommon.h: Added.
- (WTF::deleteOwnedPtr):
-
- * wtf/PassOwnPtr.h: Added.
- (WTF::PassOwnPtr::PassOwnPtr):
- (WTF::PassOwnPtr::~PassOwnPtr):
- (WTF::PassOwnPtr::get):
- (WTF::PassOwnPtr::clear):
- (WTF::PassOwnPtr::release):
- (WTF::PassOwnPtr::operator*):
- (WTF::PassOwnPtr::operator->):
- (WTF::PassOwnPtr::operator!):
- (WTF::PassOwnPtr::operator UnspecifiedBoolType):
- (WTF::::operator):
- (WTF::operator==):
- (WTF::operator!=):
- (WTF::static_pointer_cast):
- (WTF::const_pointer_cast):
- (WTF::getPtr):
-
-2009-05-23 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
+ Reviewed by Dan Bernstein.
- Remove interpreter specific logic from the JIT builds.
+ <rdar://problem/7009684> REGRESSION(r45039): Crashes inside JSEvent::put on PowerPC (26746)
+ <https://bugs.webkit.org/show_bug.cgi?id=26746>
- This saves ~100k in JSC release builds.
+ Fix for r45039 incorrectly uncached a get_by_id by converting it to put_by_id. Clearly this
+ is less than correct. This patch corrects that error.
* interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * interpreter/Interpreter.h:
- * wtf/Platform.h:
-
-2009-05-22 Mark Rowe <mrowe@apple.com>
-
- Part two of an attempted Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-22 Mark Rowe <mrowe@apple.com>
-
- Part one of an attempted Windows build fix.
+ (JSC::Interpreter::tryCacheGetByID):
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+2009-06-26 Eric Seidel <eric@webkit.org>
-2009-05-21 Gavin Barraclough <barraclough@apple.com>
+ No review, only rolling out r45259.
- Reviewed by Geoff Garen.
+ Roll out r45259 after crash appeared on the bots:
+ plugins/undefined-property-crash.html
+ ASSERTION FAILED: s <= HeapConstants<heapType>::cellSize
+ (leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278
+ void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])
- op_method_check
-
- Optimize method calls, by caching specific function values within the Structure.
- The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
- where the property access is being used to read a function to be passed to op-call (i.e.
- 'foo.bar();'). This patch modifies the Structure class such that when a property is
- put to an object for the first time we will check if the value is a function. If it is,
- we will cache the function value on the Structure. A Structure in such a state guarantees
- that not only does a property with the given identifier exist on the object, but also that
- its value is unchanged. Upon any further attempt to put a property with the same identifier
- (but a different value) to the object, it will transition back to a normal Structure (where
- it will guarantee the presence but not the value of the property).
-
- op_method_check makes use of the new information made available by the Structure, by
- augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
- check will be emitted prior to the property access reading the function value, and the JIT
- will generate an extra (initially unlinked but patchable) set of checks prior to the regular
- JIT code for get_by_id. The new code will do inline structure and prototype structure check
- (unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
- an immediate load of the function value, rather than using memory accesses to load the value
- from the obejct's property storage array. If the method check fails it will revert, or if
- the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
- just as any other regular op_get_by_id would.
-
- ~2.5% on v8-tests, due to a ~9% progression on richards.
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::::put):
- (JSC::::staticFunctionGetter):
- * API/JSObjectRef.cpp:
- (JSObjectMakeConstructor):
- * JavaScriptCore.exp:
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::differenceBetween):
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::moveWithPatch):
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * bytecode/CodeBlock.h:
- (JSC::getMethodCallLinkInfoReturnLocation):
- (JSC::CodeBlock::getMethodCallLinkInfo):
- (JSC::CodeBlock::addMethodCallLinkInfos):
- (JSC::CodeBlock::methodCallLinkInfo):
- * bytecode/Opcode.h:
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitMethodCheck):
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
- * jit/JITOpcodes.cpp:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::emit_op_method_check):
- (JSC::JIT::emitSlow_op_method_check):
- (JSC::JIT::emit_op_get_by_id):
- (JSC::JIT::emitSlow_op_get_by_id):
- (JSC::JIT::emit_op_put_by_id):
- (JSC::JIT::emitSlow_op_put_by_id):
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::patchMethodCallProto):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_get_by_id_method_check):
- (JSC::JITStubs::cti_op_get_by_id_method_check_second):
- * jit/JITStubs.h:
- * jsc.cpp:
- (GlobalObject::GlobalObject):
- * parser/Nodes.cpp:
- (JSC::FunctionCallDotNode::emitBytecode):
- * runtime/Arguments.cpp:
- (JSC::Arguments::put):
- * runtime/ArrayConstructor.cpp:
- (JSC::ArrayConstructor::ArrayConstructor):
- * runtime/BooleanConstructor.cpp:
- (JSC::BooleanConstructor::BooleanConstructor):
- * runtime/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- * runtime/ErrorConstructor.cpp:
- (JSC::ErrorConstructor::ErrorConstructor):
- (JSC::constructError):
- * runtime/ErrorPrototype.cpp:
- (JSC::ErrorPrototype::ErrorPrototype):
- * runtime/FunctionConstructor.cpp:
- (JSC::FunctionConstructor::FunctionConstructor):
- * runtime/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::FunctionPrototype):
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::InternalFunction):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::put):
- (JSC::JSActivation::putWithAttributes):
- * runtime/JSByteArray.cpp:
- (JSC::JSByteArray::JSByteArray):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::getOwnPropertySlot):
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::putWithAttributes):
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::mark):
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
- (JSC::JSGlobalObject::methodCallDummy):
- * runtime/JSObject.cpp:
- (JSC::JSObject::put):
- (JSC::JSObject::putWithAttributes):
- (JSC::JSObject::deleteProperty):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- (JSC::JSObject::getPropertyAttributes):
- (JSC::JSObject::getPropertySpecificFunction):
- (JSC::JSObject::putDirectFunction):
- (JSC::JSObject::putDirectFunctionWithoutTransition):
- * runtime/JSObject.h:
- (JSC::getJSFunction):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::putDirect):
- (JSC::JSObject::putDirectWithoutTransition):
- * runtime/LiteralParser.cpp:
- (JSC::LiteralParser::parseObject):
- * runtime/Lookup.cpp:
- (JSC::setUpStaticFunctionSlot):
+ * runtime/DateInstance.cpp:
+ * runtime/Identifier.cpp:
* runtime/Lookup.h:
- (JSC::lookupPut):
- * runtime/MathObject.cpp:
- (JSC::MathObject::MathObject):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- (JSC::NativeErrorConstructor::construct):
- * runtime/NativeErrorPrototype.cpp:
- (JSC::NativeErrorPrototype::NativeErrorPrototype):
- * runtime/NumberConstructor.cpp:
- (JSC::NumberConstructor::NumberConstructor):
- * runtime/ObjectConstructor.cpp:
- (JSC::ObjectConstructor::ObjectConstructor):
- * runtime/PropertyMapHashTable.h:
- (JSC::PropertyMapEntry::PropertyMapEntry):
- * runtime/PrototypeFunction.cpp:
- (JSC::PrototypeFunction::PrototypeFunction):
- * runtime/PutPropertySlot.h:
- (JSC::PutPropertySlot::):
- (JSC::PutPropertySlot::PutPropertySlot):
- (JSC::PutPropertySlot::setNewProperty):
- (JSC::PutPropertySlot::setDespecifyFunctionProperty):
- (JSC::PutPropertySlot::isCacheable):
- (JSC::PutPropertySlot::cachedOffset):
* runtime/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::RegExpConstructor):
- * runtime/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
- * runtime/StringPrototype.cpp:
- (JSC::StringPrototype::StringPrototype):
- * runtime/Structure.cpp:
- (JSC::Structure::Structure):
- (JSC::Structure::~Structure):
- (JSC::Structure::materializePropertyMap):
- (JSC::Structure::addPropertyTransitionToExistingStructure):
- (JSC::Structure::addPropertyTransition):
- (JSC::Structure::changeFunctionTransition):
- (JSC::Structure::addPropertyWithoutTransition):
- (JSC::Structure::get):
- (JSC::Structure::despecifyFunction):
- (JSC::Structure::put):
- (JSC::Structure::remove):
- * runtime/Structure.h:
- (JSC::Structure::get):
- (JSC::Structure::specificFunction):
- * runtime/StructureTransitionTable.h:
- (JSC::StructureTransitionTableHashTraits::emptyValue):
- * wtf/Platform.h:
-
-2009-05-22 Brent Fulgham <bfulgham@webkit.org>
-
- Reviewed by Steve Falkenburg.
-
- https://bugs.webkit.org/show_bug.cgi?id=25950
- JavaScriptCore Fails to build on Windows (Cairo) due to CoreFoundation
- link requirement.
-
- Modify project to add new Debug_CFLite and Release_CFLite targets. These
- use the new JavaScriptCoreCFLite.vsprops to link against CFLite.dll.
- Existing projects are changed to use the new JavaScriptCoreCF.vsprops
- to link against CoreFoundation.dll.
-
- The JavaScriptCoreCommon.vsprops is modified to remove the link
- against CoreFoundation.dll.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
-
-2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=15914
- [GTK] Implement Unicode functionality using GLib
-
- Original patch by Jürg Billeter and Naiem Shaik.
- Implementing WTF Unicode functionality based on GLib.
-
- * GNUmakefile.am:
- * wtf/unicode/Unicode.h:
- * wtf/unicode/glib: Added.
- * wtf/unicode/glib/UnicodeGLib.cpp: Added.
- (WTF::Unicode::foldCase):
- (WTF::Unicode::toLower):
- (WTF::Unicode::toUpper):
- (WTF::Unicode::direction):
- (WTF::Unicode::umemcasecmp):
- * wtf/unicode/glib/UnicodeGLib.h: Added.
- (WTF::Unicode::):
- (WTF::Unicode::toLower):
- (WTF::Unicode::toUpper):
- (WTF::Unicode::toTitleCase):
- (WTF::Unicode::isArabicChar):
- (WTF::Unicode::isFormatChar):
- (WTF::Unicode::isSeparatorSpace):
- (WTF::Unicode::isPrintableChar):
- (WTF::Unicode::isDigit):
- (WTF::Unicode::isPunct):
- (WTF::Unicode::mirroredChar):
- (WTF::Unicode::category):
- (WTF::Unicode::isLower):
- (WTF::Unicode::digitValue):
- (WTF::Unicode::combiningClass):
- (WTF::Unicode::decompositionType):
- * wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
-
-2009-05-21 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- Add MacroAssemblerCodeRef.h to file list.
-
- * GNUmakefile.am:
-
-2009-05-21 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Darin Adler.
- Addition of MacroAssemblerCodeRef.h rubber stamped by Geoff Garen.
-
- Refactor JIT code-handle objects. The representation of generated code is currently
- a bit of a mess. We have a class JITCode which wraps the pointer to a block of
- generated code, but this object does not reference the executable pool meaning that
- external events (the pool being derefed) could make the pointer become invalid.
- To overcome this both the JIT and Yarr implement further (and similar) objects to
- wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
- CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
- copy of the code pointer which is used almost (but not entirely) uniquely to access
- the JIT code for a function.
-
- Rationalization of all this:
-
- * Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
- * Change the JIT & Yarr to internally handle code using CodeRefs.
- * Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
- * Remove the (now) redundant code pointer from FunctionBodyNode.
-
- While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
- and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
- 'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
-
- This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
- which may have a number of uses. It may be helpful should we wish to switch our generation
- model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
- give us an oportunity to cache flush as necessary.
-
- No performance impact.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
- (JSC::AbstractMacroAssembler::CodeRef::CodeRef):
- (JSC::AbstractMacroAssembler::CodeRef::trampolineAt):
- (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
- (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
- (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- (JSC::AbstractMacroAssembler::PatchBuffer::complete):
- (JSC::AbstractMacroAssembler::PatchBuffer::finalize):
- (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::CodeBlock):
- (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
- (JSC::CodeBlock::setJITCode):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::getBytecodeIndex):
- (JSC::CodeBlock::executablePool):
- * interpreter/CallFrameClosure.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute):
- (JSC::Interpreter::prepareForRepeatCall):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- (JSC::JIT::linkCall):
- * jit/JIT.h:
- * jit/JITCode.h:
- (JSC::JITCode::JITCode):
- (JSC::JITCode::operator bool):
- (JSC::JITCode::addressForCall):
- (JSC::JITCode::offsetOf):
- (JSC::JITCode::execute):
- (JSC::JITCode::size):
- (JSC::JITCode::executablePool):
- (JSC::JITCode::HostFunction):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_vm_lazyLinkCall):
- * parser/Nodes.cpp:
- (JSC::ProgramNode::generateJITCode):
- (JSC::EvalNode::generateJITCode):
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::createNativeThunk):
- (JSC::FunctionBodyNode::generateJITCode):
- * parser/Nodes.h:
- (JSC::ScopeNode::generatedJITCode):
- (JSC::ScopeNode::getExecutablePool):
- (JSC::ScopeNode::setJITCode):
- (JSC::ProgramNode::jitCode):
- (JSC::EvalNode::jitCode):
- (JSC::FunctionBodyNode::jitCode):
- * runtime/RegExp.cpp:
- (JSC::RegExp::match):
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::compile):
- (JSC::Yarr::jitCompileRegex):
- (JSC::Yarr::executeRegex):
- * yarr/RegexJIT.h:
- (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
- (JSC::Yarr::RegexCodeBlock::pcreFallback):
- (JSC::Yarr::RegexCodeBlock::setFallback):
- (JSC::Yarr::RegexCodeBlock::operator bool):
- (JSC::Yarr::RegexCodeBlock::set):
- (JSC::Yarr::RegexCodeBlock::execute):
-
-2009-05-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- <rdar://problem/6910264> REGRESSION: Cached DOM global object property access fails in browser (25921)
- <https://bugs.webkit.org/show_bug.cgi?id=25921>
-
- When caching properties on the global object we need to ensure that we're
- not attempting to cache through a shell object.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::resolveGlobal):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_resolve_global):
-
-2009-05-21 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
-
-2009-05-21 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 25945: Add support for MADV_FREE to TCMalloc
- <https://bugs.webkit.org/show_bug.cgi?id=25945>
- <rdar://problem/6910754>
-
- Add support for MADV_FREE to TCMalloc_SystemRelease for platforms that
- don't also support MADV_FREE_REUSE. The code is identical to the MADV_DONTNEED
- case except for the advice passed to madvise(), so combining the two cases
- makes the most sense.
-
- * wtf/Platform.h: Only define HAVE_MADV_FREE when not building on Tiger or
- Leopard, because while it is defined on these platforms it actually does
- nothing.
- * wtf/TCSystemAlloc.cpp:
- (TCMalloc_SystemRelease): use MADV_FREE if it is available; otherwise use
- MADV_DONTNEED.
-
-2009-05-21 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
- Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page
-
- The debugger currently retrieves the arguments object from an activation rather than pulling
- it from a call frame. This is unreliable to due to the recent optimization to lazily create
- the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
- but for now we force eager creation of the arguments object when debugging.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
-
-2009-05-21 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
- <https://bugs.webkit.org/show_bug.cgi?id=25912>
-
- This causes no change on SunSpider.
-
- * runtime/NumberPrototype.cpp:
- (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the
- temporary buffer has sufficient space to store the result, and move the
- explicit null-termination closer to the memcpy() for easier visual inspection
- of the code.
- (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT
- that the temporary buffer has sufficient space to store the result. There
- is no explicit null-termination because this is done by the caller. The
- same is already true for exponentialPartToString().
- (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly
- null-terminate the result, and ASSERT that the temporary buffer has sufficient
- space to store the result.
-
-2009-05-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Cleanup the JSGlobalData when exiting early with the usage statement in jsc.
-
- * jsc.cpp:
- (printUsageStatement):
- (parseArguments):
- (jscmain):
-
-2009-05-20 Stephanie Lewis <slewis@apple.com>
-
- Update the order files. <rdar://problem/6881750> Generate new order files.
-
- * JavaScriptCore.order:
-
-2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Replace WREC with YARR + YARR_JIT for the Qt port. This is only
- used when compiled with JIT support for now, so it is a drop-in
- replacement for the WREC usage. Still including the wrec headers
- as they are being referred from RegExp.h, though the contents of
- that header it protected by "#if ENABLE(WREC)".
-
- * JavaScriptCore.pri:
-
-2009-05-20 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Eric Seidel.
-
- Fix GTK debug build.
-
- The function dumpDisjunction, compiled with debug enabled, uses
- printf, which needs stdio.h to be included.
-
- * yarr/RegexInterpreter.cpp:
-
-2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- BUG 25843: [Qt] Remove qt-port build flag
- <https://bugs.webkit.org/show_bug.cgi?id=25843>
-
- * JavaScriptCore.pro:
-
-
-2009-05-19 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix.
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.
-
-2009-05-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
- Mac OS X at <unknown binary> • 0x9274241c
-
- (Original patch by Joe Sokol and Ronnie Misra.)
-
- SunSpider says 1.004x faster.
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated
- math that sometimes used to overflow, just release the full range of the
- register file.
-
- * interpreter/RegisterFile.h:
- (JSC::isPageAligned):
- (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's
- safe to release the full range of the register file.
-
- (JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
- new end is not smaller than the old end. (Also, doing so used to cause
- numeric overflow, unmapping basically the whole process from memory.)
-
-2009-05-19 Oliver Hunt <oliver@apple.com>
-
- RS=Mark Rowe.
-
- <rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
- <https://bugs.webkit.org/show_bug.cgi?id=25717>
-
- Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
- resulting in weird bugs in the nightly builds.
-
- * parser/Nodes.cpp:
- * parser/Nodes.h:
- (JSC::ExpressionNode::isNumber):
- (JSC::ExpressionNode::isString):
- (JSC::ExpressionNode::isNull):
- (JSC::ExpressionNode::isPure):
- (JSC::ExpressionNode::isLocation):
- (JSC::ExpressionNode::isResolveNode):
- (JSC::ExpressionNode::isBracketAccessorNode):
- (JSC::ExpressionNode::isDotAccessorNode):
- (JSC::ExpressionNode::isFuncExprNode):
- (JSC::ExpressionNode::isSimpleArray):
- (JSC::ExpressionNode::isAdd):
- (JSC::ExpressionNode::resultDescriptor):
- (JSC::StatementNode::firstLine):
- (JSC::StatementNode::lastLine):
- (JSC::StatementNode::isEmptyStatement):
- (JSC::StatementNode::isReturnNode):
- (JSC::StatementNode::isExprStatement):
- (JSC::StatementNode::isBlock):
- (JSC::NullNode::isNull):
- (JSC::BooleanNode::isPure):
- (JSC::NumberNode::value):
- (JSC::NumberNode::setValue):
- (JSC::NumberNode::isNumber):
- (JSC::NumberNode::isPure):
- (JSC::StringNode::isPure):
- (JSC::StringNode::isString):
- (JSC::ResolveNode::identifier):
- (JSC::ResolveNode::isLocation):
- (JSC::ResolveNode::isResolveNode):
- (JSC::BracketAccessorNode::isLocation):
- (JSC::BracketAccessorNode::isBracketAccessorNode):
- (JSC::DotAccessorNode::base):
- (JSC::DotAccessorNode::identifier):
- (JSC::DotAccessorNode::isLocation):
- (JSC::DotAccessorNode::isDotAccessorNode):
- (JSC::TypeOfResolveNode::identifier):
- (JSC::AddNode::isAdd):
- (JSC::BlockNode::isBlock):
- (JSC::EmptyStatementNode::isEmptyStatement):
- (JSC::ExprStatementNode::isExprStatement):
- (JSC::ReturnNode::isReturnNode):
- (JSC::ScopeNode::sourceURL):
- (JSC::ProgramNode::bytecode):
- (JSC::EvalNode::bytecode):
- (JSC::FunctionBodyNode::parameters):
- (JSC::FunctionBodyNode::toSourceString):
- (JSC::FunctionBodyNode::bytecode):
- (JSC::FuncExprNode::isFuncExprNode):
-
-2009-05-19 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- - speed up string comparison, especially for short strings
-
- ~1% on SunSpider
-
- * JavaScriptCore.exp:
- * runtime/UString.cpp:
+ * runtime/RegExpObject.h:
+ * runtime/ScopeChain.h:
* runtime/UString.h:
- (JSC::operator==): Inline UString's operator==, since it is called from
- hot places in the runtime. Also, specialize 2-char strings in a similar way to
- 1-char, since we're taking the hit of a switch anyway.
-
-2009-05-18 Maciej Stachowiak <mjs@apple.com>
- Reviewed by Gavin Barraclough.
-
- - for polymorphic prototype lookups, increase the number of slots from 4 to 8
-
- ~4% faster on v8 raytrace benchmark
-
- * bytecode/Instruction.h:
-
-2009-05-18 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - tighten up the code for the load_varargs stub
-
- ~1-2% on v8-raytrace
-
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that
- the compiler didn't feel like hoisting for us. Remove unneeded exception check.
-
-2009-05-18 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Geoff Garen.
-
- - Improve code generation for access to prototype properties
-
- ~0.4% speedup on SunSpider.
-
- Based on a suggestion from Geoff Garen.
-
- * jit/JIT.h:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetDirectOffset):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
-
-2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Gavin Barraclough.
-
- Enable YARR, and disable WREC for GTK+.
-
- * GNUmakefile.am:
- * yarr/RegexParser.h:
-
-2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [Gtk] Various autotools build refactoring and fixes
- https://bugs.webkit.org/show_bug.cgi?id=25286
-
- Add -no-install and -no-fast-install to programs and tests that we
- don't install. Also remove -O2 since this is already handled at
- configure time.
-
- * GNUmakefile.am:
-
-2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [Gtk] Various autotools build refactoring and fixes
- https://bugs.webkit.org/show_bug.cgi?id=25286
-
- Add JavaScriptCore/ to JSC include path only since it's not
- required when building WebCore.
-
- * GNUmakefile.am:
-
-2009-05-17 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
-2009-05-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Looking like MSVC doesn't like static variables in inline methods?
- Make the state of the SSE2 check a static variable on the class
- MacroAssemblerX86Common as a speculative build fix for Windows.
-
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
- (JSC::MacroAssemblerX86Common::branchDouble):
- (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
- (JSC::MacroAssemblerX86Common::isSSE2Present):
- (JSC::MacroAssemblerX86Common::):
- * jit/JIT.cpp:
-
-2009-05-15 Adam Roben <aroben@apple.com>
-
- Add some assembler headers to JavaScriptCore.vcproj
-
- This is just a convenience for Windows developers.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2009-05-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
- API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
- FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
- hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
- other methods ASSERT_NOT_REACHED().
-
- * assembler/AbstractMacroAssembler.h:
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::MacroAssemblerX86):
- (JSC::MacroAssemblerX86::branch32):
- (JSC::MacroAssemblerX86::branchPtrWithPatch):
- (JSC::MacroAssemblerX86::supportsFloatingPoint):
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::):
- (JSC::MacroAssemblerX86Common::loadDouble):
- (JSC::MacroAssemblerX86Common::storeDouble):
- (JSC::MacroAssemblerX86Common::addDouble):
- (JSC::MacroAssemblerX86Common::subDouble):
- (JSC::MacroAssemblerX86Common::mulDouble):
- (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
- (JSC::MacroAssemblerX86Common::branchDouble):
- (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
- (JSC::MacroAssemblerX86Common::branch32):
- (JSC::MacroAssemblerX86Common::branch16):
- (JSC::MacroAssemblerX86Common::branchTest32):
- (JSC::MacroAssemblerX86Common::branchAdd32):
- (JSC::MacroAssemblerX86Common::branchMul32):
- (JSC::MacroAssemblerX86Common::branchSub32):
- (JSC::MacroAssemblerX86Common::set32):
- (JSC::MacroAssemblerX86Common::setTest32):
- (JSC::MacroAssemblerX86Common::x86Condition):
- (JSC::MacroAssemblerX86Common::isSSE2Present):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::movePtrToDouble):
- (JSC::MacroAssemblerX86_64::moveDoubleToPtr):
- (JSC::MacroAssemblerX86_64::setPtr):
- (JSC::MacroAssemblerX86_64::branchPtr):
- (JSC::MacroAssemblerX86_64::branchTestPtr):
- (JSC::MacroAssemblerX86_64::branchAddPtr):
- (JSC::MacroAssemblerX86_64::branchSubPtr):
- (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
- * assembler/X86Assembler.h:
- * jit/JIT.cpp:
- (JSC::JIT::JIT):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::emit_op_rshift):
- (JSC::JIT::emitSlow_op_rshift):
- (JSC::JIT::emitSlow_op_jnless):
- (JSC::JIT::emitSlow_op_jnlesseq):
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::emit_op_add):
- (JSC::JIT::emitSlow_op_add):
- (JSC::JIT::emit_op_mul):
- (JSC::JIT::emitSlow_op_mul):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
-
-2009-05-15 Francisco Tolmasky <francisco@280north.com>
-
- BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
- <https://bugs.webkit.org/show_bug.cgi?id=25467>
-
- Reviewed by Adam Roben.
-
- * JavaScriptCore.exp: Added calculatedFunctionName
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
- * debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode.
- (JSC::DebuggerCallFrame::calculatedFunctionName):
- * debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.
-
-2009-05-14 Gavin Barraclough <barraclough@apple.com>
-
- Build fix, not reviewed.
-
- Quick fixes for JIT builds with OPTIMIZE flags disabled.
-
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compilePutByIdHotPath):
-
-2009-05-14 Steve Falkenburg <sfalken@apple.com>
-
- Back out incorrect Windows build fix
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2009-05-14 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2009-05-14 Adam Roben <aroben@apple.com>
-
- Windows jsc build fix
-
- r43648 modified jsc.vcproj's post-build event not to try to copy files
- that aren't present. Then r43661 mistakenly un-did that modification.
- This patch restores the modification from r43648, but puts the code in
- jscCommon.vsprops (where it should have been added in r43648).
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty
- VCPostBuildEventTool tags.
- * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build
- event command line to match the one in jsc.vcproj from r43648.
-
-2009-05-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25325
-
- Make sure pthread_self() is declared before it gets called in Collector.cpp
-
- * runtime/Collector.cpp: Include pthread.h in most Unix-like platforms
- (not just for OPENBSD)
-
-2009-05-14 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>.
- Bug 25785: Segfault in mark when using JSObjectMakeConstructor
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does.
- * API/tests/testapi.c:
- (main): Add a test case.
- * runtime/JSObject.h:
- (JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this,
- but the cause of the failure is not clear from the assertion itself.
-
-2009-05-14 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Darin Adler.
-
- <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
-
- The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
- Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
- if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
-
- * Configurations/Base.xcconfig:
-
-2009-05-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Checking register file bounds should be a ptr comparison (m_end is a Register*).
- Also, the compare should be unsigned, pointers don'ts go negative.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
-
-2009-05-13 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)
-
- op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
- This leads to bad happen.
-
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_loop_if_less):
- (JSC::JIT::emitSlow_op_loop_if_less):
-
-2009-05-13 Dmitry Titov <dimich@chromium.org>
-
- Rubber-stamped by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25746
- Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
-
- * JavaScriptCore.exp:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingThread::start):
- (JSC::SamplingThread::stop):
- * bytecode/SamplingTool.h:
- * wtf/CrossThreadRefCounted.h:
- (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
- (WTF::::ref):
- (WTF::::deref):
- * wtf/Threading.h:
- * wtf/ThreadingNone.cpp:
- * wtf/ThreadingPthreads.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::identifierByPthreadHandle):
- (WTF::establishIdentifierForPthreadHandle):
- (WTF::pthreadHandleForIdentifier):
- (WTF::clearPthreadHandleForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
- * wtf/ThreadingWin.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::storeThreadHandleByIdentifier):
- (WTF::threadHandleForIdentifier):
- (WTF::clearThreadHandleForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
- * wtf/gtk/ThreadingGtk.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::identifierByGthreadHandle):
- (WTF::establishIdentifierForThread):
- (WTF::threadForIdentifier):
- (WTF::clearThreadForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
- * wtf/qt/ThreadingQt.cpp:
- (WTF::threadMapMutex):
- (WTF::threadMap):
- (WTF::identifierByQthreadHandle):
- (WTF::establishIdentifierForThread):
- (WTF::clearThreadForIdentifier):
- (WTF::threadForIdentifier):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
-2009-05-13 Darin Adler <darin@apple.com>
-
- Revert the parser arena change. It was a slowdown, not a speedup.
- Better luck next time (I'll break it up into pieces).
-
-2009-05-13 Darin Adler <darin@apple.com>
-
- Tiger build fix.
-
- * parser/Grammar.y: Add back empty code blocks, needed by older
- versions of bison on certain rules.
-
-2009-05-13 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2009-05-13 Adam Roben <aroben@apple.com>
-
- Windows build fixes after r43642
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- Updated.
-
- * debugger/Debugger.cpp:
- * runtime/ArrayConstructor.cpp:
- * runtime/JSArray.cpp:
- * runtime/RegExp.cpp:
- * runtime/RegExpConstructor.cpp:
- * runtime/RegExpPrototype.cpp:
- * runtime/StringPrototype.cpp:
- Added missing #includes.
-
-2009-05-13 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 25674: syntax tree nodes should use arena allocation
- https://bugs.webkit.org/show_bug.cgi?id=25674
-
- Step 3: Add some actual arena allocation. About 1% SunSpider speedup.
-
- * JavaScriptCore.exp: Updated.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
- contains const Identifier* now.
- (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const
- Identifier&.
- * bytecompiler/BytecodeGenerator.h: Ditto
-
- * bytecompiler/SegmentedVector.h: Added isEmpty.
-
- * debugger/Debugger.cpp:
- (JSC::Debugger::recompileAllJSFunctions): Moved this function here from
- WebCore so WebCore doesn't need the details of FunctionBodyNode.
- * debugger/Debugger.h: Ditto.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute): Updated since VarStack contains const
- Identifier* now.
-
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body
- rather than on the function object, since we can't easily have inlined
- access to the FunctionBodyNode in JSFunction.h since WebCore needs
- access to that header.
- (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
- * profiler/Profiler.cpp:
- (JSC::Profiler::createCallIdentifier): Ditto.
-
- * parser/Grammar.y: Use JSGlobalData* to pass the global data pointer
- around whenever possible instead of using void*. Changed
- SET_EXCEPTION_LOCATION from a macro to an inline function. Marked
- the structure-creating functions inline. Changed the VarStack to use
- identifier pointers instead of actual identifiers. This takes
- advantage of the fact that all identifier pointers come from the
- arena and avoids reference count churn. Changed Identifier* to
- const Identifier* to make sure we don't modify any by accident.
- Used identifiers for regular expression strings too, using the new
- scanRegExp that has out parameters instead of the old one that relied
- on side effects in the Lexer. Move the creation of numeric identifiers
- out of this file and into the PropertyNode constructor.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
- (JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
- and changed to call ParserArena.
- (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier*
- as well as a prefix character argument so we can handle the /= case
- without a string append.
- (JSC::Lexer::skipRegExp): Added. Skips a regular expression without
- allocating Identifier objects.
- (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern,
- and m_flags, and added code to set m_arena to 0.
- * parser/Lexer.h: Updated for changes above.
-
- * parser/NodeConstructors.h:
- (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
- on the arena.
- (JSC::ParserArenaDeletable::operator new): Changed to call the
- allocateDeletable function on the arena instead of deleteWithArena.
- (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead
- of UString since these come from the parser which makes identifiers.
- (JSC::PropertyNode::PropertyNode): Added new constructor that makes
- numeric identifiers. Some day we might want to optimize this for
- integers so it doesn't create a string for each one.
- (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
- since it's now a const Identifier& so it can't be left uninitialized.
- (JSC::BreakNode::BreakNode): Ditto.
- (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
- to keep track of the statements rather than a separate statement vector.
- (JSC::BlockNode::BlockNode): Ditto.
- (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
-
- * parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
- It seemed strangely out of place in the header.
- (JSC::ThrowableExpressionData::emitThrowError): Added an overload for
- UString as well as Identifier.
- (JSC::SourceElements::singleStatement): Added.
- (JSC::SourceElements::lastStatement): Added.
- (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags
- are now Identifier instead of UString. Also changed the throwError code
- to use the substitution mechanism instead of doing a string append.
- (JSC::SourceElements::emitBytecode): Added. Replaces the old
- statementListEmitCode function, since we now keep the SourceElements
- objects around.
- (JSC::BlockNode::lastStatement): Added.
- (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
- statementListEmitCode.
- (JSC::CaseClauseNode::emitBytecode): Added.
- (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
- instead of statementListEmitCode.
- (JSC::ScopeNodeData::ScopeNodeData): Changed to store the
- SourceElements* instead of using releaseContentsIntoVector.
- (JSC::ScopeNode::emitStatementsBytecode): Added.
- (JSC::ScopeNode::singleStatement): Added.
- (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
- of statementListEmitCode.
- (JSC::EvalNode::emitBytecode): Ditto.
- (JSC::EvalNode::generateBytecode): Removed code to clear the children
- vector. This optimization is no longer possible since everything is in
- a single arena.
- (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
- insetad of statementListEmitCode and check for the return node using
- the new functions.
-
- * parser/Nodes.h: Changed VarStack to store const Identifier* instead
- of Identifier and rely on the arena to control lifetime. Added a new
- ParserArenaFreeable class. Made ParserArenaDeletable inherit from
- FastAllocBase instead of having its own operator new. Base the Node
- class on ParserArenaFreeable. Changed the various Node classes
- to use const Identifier& instead of Identifier to avoid the need to
- call their destructors and allow them to function as "freeable" in the
- arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
- Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
- CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
- as a base class since they do not descend from Node. Eliminated the
- StatementVector type and instead have various classes use SourceElements*
- instead of StatementVector. This prevents those classes from having th
- use ParserArenaDeletable to make sure the vector destructor is called.
-
- * parser/Parser.cpp:
- (JSC::Parser::parse): Pass the arena to the lexer.
-
- * parser/Parser.h: Added an include of ParserArena.h, which is no longer
- included by Nodes.h.
-
- * parser/ParserArena.cpp:
- (JSC::ParserArena::ParserArena): Added. Initializes the new members,
- m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
- (JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
- since we store only the current pointer and the end of pool pointer.
- (JSC::ParserArena::deallocateObjects): Added. Contains the common
- memory-deallocation logic used by both the destructor and the
- reset function.
- (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
- (JSC::ParserArena::reset): Ditto. Also added code to zero out the
- new structures, and switched to use clear() instead of shrink(0) since
- we don't really reuse arenas.
- (JSC::ParserArena::makeNumericIdentifier): Added.
- (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
- is empty.
- (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
- since this is used only for assertions at the moment.
-
- * parser/ParserArena.h: Added an actual arena of "freeable" objects,
- ones that don't need destructors to be called. Also added the segmented
- vector of identifiers that used to be in the Lexer.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::extractFunctionBody): Use singleStatement function rather than
- getting at a StatementVector.
-
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncToString): Call isHostFunction on the body
- rather than the function object.
-
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::JSFunction): Moved the structure version of this in
- here from the header. It's not hot enough that it needs to be inlined.
- (JSC::JSFunction::isHostFunction): Moved this in here from the header.
- It's now a helper to be used only within the class.
- (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that
- it needs to be inlined, and we want to be able to compile the header
- without the definition of FunctionBodyNode.
-
- * runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was
- exposing too much JavaScriptCore dependency to WebCore. Because of this
- change and some changes made to WebCore, we could now export a lot fewer
- headers from JavaScriptCore, but I have not done that yet in this check-in.
- Made a couple functions non-inline. Removes some isHostFunction() assertions.
-
- * wtf/FastAllocBase.h: Added the conventional using statements we use in
- WTF so we can use identifiers from the WTF namespace without explicit
- namespace qualification or namespace directive. This is the usual WTF style,
- although it's unconventional in the C++ world. We use the namespace primarily
- for link-time disambiguation, not compile-time.
-
- * wtf/FastMalloc.cpp: Fixed an incorrect comment.
-
-2009-05-13 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix: add JITStubCall.h to files list.
-
- * GNUmakefile.am:
-
-2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Unreviewed build fix, as suggested by Yael Aharon <yael.aharon@nokia.com>.
-
- * wtf/qt/ThreadingQt.cpp:
- (WTF::waitForThreadCompletion): renamed IsValid to isValid.
-
-2009-05-13 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
- WebCore/config.h.
-
- * wtf/Platform.h:
-
-2009-05-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
- (enabled using ENABLE(SAMPLING_COUNTERS)). To count events within a single function
- use the class 'SamplingCounter', where the counter may be incremented from multiple
- functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
- heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
- Further description of these classes is provided alongside their definition in
- SamplingTool.h.
-
- Counters may be incremented from c++ by calling the 'count()' method on the counter,
- or may be incremented by JIT code by using the 'emitCount()' method within the JIT.
-
- This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.
-
- * JavaScriptCore.exp:
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::addWithCarry32):
- (JSC::MacroAssemblerX86::and32):
- (JSC::MacroAssemblerX86::or32):
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::and32):
- (JSC::MacroAssemblerX86Common::or32):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::and32):
- (JSC::MacroAssemblerX86_64::or32):
- (JSC::MacroAssemblerX86_64::addPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::adcl_im):
- (JSC::X86Assembler::addq_im):
- (JSC::X86Assembler::andl_im):
- (JSC::X86Assembler::orl_im):
- * bytecode/SamplingTool.cpp:
- (JSC::AbstractSamplingCounter::dump):
- * bytecode/SamplingTool.h:
- (JSC::AbstractSamplingCounter::count):
- (JSC::GlobalSamplingCounter::name):
- (JSC::SamplingCounter::SamplingCounter):
- * jit/JIT.h:
- * jit/JITCall.cpp:
- (JSC::):
- * jit/JITInlineMethods.h:
- (JSC::JIT::setSamplingFlag):
- (JSC::JIT::clearSamplingFlag):
- (JSC::JIT::emitCount):
- * jsc.cpp:
- (runWithScripts):
- * parser/Nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
- * wtf/Platform.h:
-
-2009-05-13 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
-
-2009-05-12 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
-
-2009-05-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading http://www.sears.com
-
- We created the arguments objects before an op_push_scope but not
- before op_push_new_scope, this meant a null arguments object could
- be resolved inside catch blocks.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitPushNewScope):
-
-2009-05-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading http://www.monster.com; http://www.cnet.com
- <https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)
-
- Following on from the lazy arguments creation patch, it's now
- possible for an activation to to have a null register in the callframe
- so we can't just blindly mark the local registers in an activation,
- and must null check first instead.
-
- * API/tests/testapi.c:
- (functionGC):
- * API/tests/testapi.js:
- (bludgeonArguments.return.g):
- (bludgeonArguments):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::mark):
-
-2009-05-12 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Geoff Garen.
-
- WTF_USE_CTI_REPATCH_PIC is no longer used, remove.
-
- * jit/JIT.h:
- * jit/JITStubCall.h:
-
-2009-05-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- We've run into some problems where changing the size of the class JIT leads to
- performance fluctuations. Try forcing alignment in an attempt to stabalize this.
-
- * jit/JIT.h:
-
-2009-05-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Add ParserArena.cpp to the build.
-
- * JavaScriptCoreSources.bkl:
-
-2009-05-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Unsigned underflow on 64bit cannot be treated as a negative number
-
- This code included some placeswhere we deliberately create negative offsets
- from unsigned values, on 32bit this is "safe", but in 64bit builds much
- badness occurs. Solution is to use signed types as nature intended.
-
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_load_varargs):
-
-2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Holger Freyther.
-
- [Gtk] Various autotools build refactoring and fixes
- https://bugs.webkit.org/show_bug.cgi?id=25286
-
- Define WTF_USE_JSC for the Gtk port.
-
- * wtf/Platform.h:
-
-2009-05-12 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - allow all of strictEqual to be inlined into cti_op_stricteq once again
-
- We had this optimization once but accidentally lost it at some point.
-
- * runtime/Operations.h:
- (JSC::JSValue::strictEqualSlowCaseInline):
- (JSC::JSValue::strictEqual):
-
-2009-05-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
+ Reviewed by Simon Hausmann.
- instanceof should throw if the constructor being tested does not implement
- 'HasInstance" (i.e. is a function). Instead we were returning false.
+ Add support for QDataStream operators to Vector.
- * interpreter/Interpreter.cpp:
- (JSC::isInvalidParamForIn):
- (JSC::isInvalidParamForInstanceOf):
- (JSC::Interpreter::privateExecute):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_instanceof):
- * tests/mozilla/ecma_2/instanceof/instanceof-003.js:
- Fix broken test case.
- * tests/mozilla/ecma_2/instanceof/regress-7635.js:
- Remove broken test case (was an exact duplicate of a test in instanceof-003.js).
+ * wtf/Vector.h:
+ (WTF::operator<<):
+ (WTF::operator>>):
-2009-05-12 Oliver Hunt <oliver@apple.com>
+2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
- Improve function call forwarding performance
-
- Make creation of the Arguments object occur lazily, so it
- is not necessarily created for every function that references
- it. Then add logic to Function.apply to allow it to avoid
- allocating the Arguments object at all. Helps a lot with
- the function forwarding/binding logic in jQuery, Prototype,
- and numerous other JS libraries.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * bytecode/Opcode.h:
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::registerFor):
- (JSC::BytecodeGenerator::willResolveToArguments):
- (JSC::BytecodeGenerator::uncheckedRegisterForArguments):
- (JSC::BytecodeGenerator::createArgumentsIfNecessary):
- (JSC::BytecodeGenerator::emitCallEval):
- (JSC::BytecodeGenerator::emitPushScope):
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JIT.h:
- * jit/JITOpcodes.cpp:
- (JSC::JIT::emit_op_create_arguments):
- (JSC::JIT::emit_op_init_arguments):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_tear_off_arguments):
- (JSC::JITStubs::cti_op_load_varargs):
- * parser/Nodes.cpp:
- (JSC::ApplyFunctionCallDotNode::emitBytecode):
-
-2009-05-11 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Enable use of SamplingFlags directly from JIT code.
-
- * bytecode/SamplingTool.h:
- * jit/JIT.h:
- (JSC::JIT::sampleCodeBlock):
- (JSC::JIT::sampleInstruction):
- * jit/JITInlineMethods.h:
- (JSC::JIT::setSamplingFlag):
- (JSC::JIT::clearSamplingFlag):
-
-2009-05-11 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Implement JIT generation for instanceof for non-objects (always returns false).
- Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.
-
- 0.5% progression on v8 tests overall, due to 3.5% on early-boyer.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * runtime/JSObject.cpp:
- (JSC::JSObject::hasInstance):
- * runtime/TypeInfo.h:
- (JSC::TypeInfo::TypeInfo):
-
-2009-05-11 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A little more JIT refactoring.
-
- Rearranged code to more clearly indicate what's conditionally compiled
- and why. Now, all shared code is at the top of our JIT files, and all
- #if'd code is at the bottom. #if'd code is delineated by large comments.
-
- Moved functions that relate to the JIT but don't explicitly do codegen
- into JIT.cpp. Refactored SSE2 check to store its result as a data member
- in the JIT.
-
- * jit/JIT.cpp:
- (JSC::isSSE2Present):
- (JSC::JIT::JIT):
- (JSC::JIT::unlinkCall):
- (JSC::JIT::linkCall):
- * jit/JIT.h:
- (JSC::JIT::isSSE2Present):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::emit_op_mod):
- (JSC::JIT::emitSlow_op_mod):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallVarargs):
- (JSC::JIT::compileOpCallVarargsSlowCase):
-
-2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- * JavaScriptCore.pri: Build the new JITOpcodes.cpp
-
-2009-05-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- More re-factoring of JIT code generation. Use a macro to
- forward the main switch-statement cases to the helper functions.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
-
-2009-05-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- More re-factoring of JIT code generation to move opcode generation
- to helper functions outside the main switch-statement and gave those
- helper functions standardized names. This patch covers the remaining
- slow cases.
-
- * jit/JIT.cpp:
- * jit/JIT.h:
- * jit/JITOpcodes.cpp:
-
-2009-05-11 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * GNUmakefile.am: Added JITOpcodes.cpp and JITStubCall.h to the project.
-
-2009-05-11 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
- JITOpcodes.cpp and JITStubCall.h to the project.
-
-2009-05-11 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Some JIT refactoring.
-
- Moved JITStubCall* into its own header.
-
- Modified JITStubCall to ASSERT that its return value is handled correctly.
- Also, replaced function template with explicit instantiations to resolve
- some confusion.
-
- Replaced all uses of emit{Get,Put}CTIArgument with explicit peeks, pokes,
- and calls to killLastResultRegister().
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- * jit/JITCall.cpp:
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- * jit/JITPropertyAccess.cpp:
- * jit/JITStubCall.h: Copied from jit/JIT.h.
- (JSC::JITStubCall::JITStubCall):
- (JSC::JITStubCall::addArgument):
- (JSC::JITStubCall::call):
- (JSC::JITStubCall::):
-
-2009-05-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Start re-factoring JIT code generation to move opcode generation
- to helper functions outside the main switch-statement and gave those
- helper functions standardized names. This patch only covers the main
- pass and all the arithmetic opcodes in the slow path.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- * jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
- * jit/JITPropertyAccess.cpp:
-
-2009-05-11 Steve Falkenburg <sfalken@apple.com>
-
- Re-add experimental PGO configs.
-
- Reviewed by Adam Roben.
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
- * JavaScriptCore.vcproj/JavaScriptCore.sln:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2009-05-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey "1" Garen.
-
- Rip out the !USE(CTI_REPATCH_PIC) code. It was untested and unused.
+ Make the opcode sampler work once again.
* jit/JIT.h:
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdSelfList):
+ (JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compileCTIMachineTrampolines):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::tryCachePutByID):
- (JSC::JITStubs::tryCacheGetByID):
-
-2009-05-11 Dmitry Titov <dimich@chromium.org>
-
- GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.
-
- * wtf/ThreadingPthreads.cpp: used #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().
-
-2009-05-11 Adam Roben <aroben@apple.com>
-
- Build fix for newer versions of GCC
-
- * wtf/ThreadingPthreads.cpp: Added a declaration of
- waitForThreadCompletion before its definition to silence a warning.
-
-2009-05-11 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov and Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25348
- Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
-
- * wtf/Threading.h:
- (WTF::ThreadIdentifier::ThreadIdentifier):
- (WTF::ThreadIdentifier::isValid):
- (WTF::ThreadIdentifier::invalidate):
- (WTF::ThreadIdentifier::platformId):
- ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
- methods that are used across the code on thread ids: construction, comparisons,
- check for 'valid' state etc. '0' is used as invalid id, which happens to just work
- with all platform-specific thread id implementations.
-
- All the following files repeatedly reflect the new ThreadIdentifier for each platform.
- We remove ThreadMap and threadMapMutex from all of them, remove the functions that
- populated/searched/cleared the map and add platform-specific comparison operators
- for ThreadIdentifier.
-
- There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
- public build uses WTF threading functions with old type of ThreadingIdentifier.
- The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
- functions so the deprecated ones can be removed.
-
- * wtf/gtk/ThreadingGtk.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
- * wtf/ThreadingNone.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
-
- * wtf/ThreadingPthreads.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
- (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac.
- Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t.
- This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can
- load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous
- decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t.
- This function will be removed as soon as Safari 4 will release next public build.
-
- * wtf/qt/ThreadingQt.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
- * wtf/ThreadingWin.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
- counter as a thread ID and mapped it into platform ID. Windows was using native thread
- id and mapped it into thread handle. Since we can always obtain a thread handle
- by thread id, createThread now closes the handle.
- (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
- it means the thread already exited.
- (WTF::detachThread):
- (WTF::currentThread):
- (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
- (WTF::waitForThreadCompletionDeprecated): same.
- (WTF::currentThreadDeprecated): same.
- (WTF::createThreadDeprecated): same.
-
- * bytecode/SamplingTool.h:
- * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
-
- * JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions
- since they now take a different type as a parameter.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
- that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
-
-2009-05-11 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 25560: REGRESSION (r34821): "string value".__proto__ gets the wrong object.
- https://bugs.webkit.org/show_bug.cgi?id=25560
- rdar://problem/6861069
-
- I missed this case back a year ago when I sped up handling
- of JavaScript wrappers. Easy to fix.
-
- * runtime/JSObject.h:
- (JSC::JSValue::get): Return the prototype itself if the property name
- is __proto__.
- * runtime/JSString.cpp:
- (JSC::JSString::getOwnPropertySlot): Ditto.
-
-2009-05-09 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetFromCallFrameHeaderPtr):
- (JSC::JIT::emitGetFromCallFrameHeader32):
-
-2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix. Build ParserAreana.cpp for Qt
-
- * JavaScriptCore.pri:
-
-2009-05-11 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24536
-
- Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
- unless Profile.h is included.
-
- * profiler/ProfileGenerator.h:
-
-2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24284
-
- * JavaScriptCore.pri: coding style modified
- * jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES
-
-2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by NOBODY (build fix).
-
- Also add ParserArena, in addition to AllInOne, for release builds,
- since adding it to AllInOne breaks Mac.
-
- * GNUmakefile.am:
-
-2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed build fix. Adding ParserArena to the autotools build.
-
- * GNUmakefile.am:
-
-2009-05-11 Adam Roben <aroben@apple.com>
-
- More Windows build fixes after r43479
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- Export ParserArena::reset.
-
-2009-05-11 Adam Roben <aroben@apple.com>
-
- Windows build fixes after r43479
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
- ParserArena to the project.
-
- * parser/NodeConstructors.h: Added a missing include.
- (JSC::ParserArenaDeletable::operator new): Marked these as inline.
-
-2009-05-10 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Geoff Garen.
-
- - fixed REGRESSION(r43432): Many JavaScriptCore tests crash in 64-bit
- https://bugs.webkit.org/show_bug.cgi?id=25680
-
- Accound for the 64-bit instruction prefix when rewriting mov to lea on 64-bit.
-
- * jit/JIT.h:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
-
-2009-05-10 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 25674: syntax tree nodes should use arena allocation
- https://bugs.webkit.org/show_bug.cgi?id=25674
-
- Part two: Remove reference counting from most nodes.
-
- * JavaScriptCore.exp: Updated.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Added ParserArena.h and .cpp.
-
- * parser/Grammar.y: Replaced uses of ParserRefCountedData with uses of
- ParserArenaData. Took out now-nonfunctional code that tries to manually
- release declaration list. Changed the new calls that create FuncDeclNode
- and FuncExprNode so that they use the proper version of operator new for
- the reference-counted idiom, not the deletion idiom.
-
- * parser/NodeConstructors.h:
- (JSC::ParserArenaDeletable::operator new): Added.
- (JSC::ParserArenaRefCounted::ParserArenaRefCounted): Added.
- (JSC::Node::Node): Removed ParserRefCounted initializer.
- (JSC::ElementNode::ElementNode): Ditto.
- (JSC::PropertyNode::PropertyNode): Ditto.
- (JSC::ArgumentsNode::ArgumentsNode): Ditto.
- (JSC::SourceElements::SourceElements): Ditto.
- (JSC::ParameterNode::ParameterNode): Ditto.
- (JSC::FuncExprNode::FuncExprNode): Added ParserArenaRefCounted initializer.
- (JSC::FuncDeclNode::FuncDeclNode): Ditto.
- (JSC::CaseClauseNode::CaseClauseNode): Removed ParserRefCounted initializer.
- (JSC::ClauseListNode::ClauseListNode): Ditto.
- (JSC::CaseBlockNode::CaseBlockNode): Ditto.
-
- * parser/NodeInfo.h: Replaced uses of ParserRefCountedData with uses of
- ParserArenaData.
-
- * parser/Nodes.cpp:
- (JSC::ScopeNode::ScopeNode): Added ParserArenaRefCounted initializer.
- (JSC::ProgramNode::create): Use the proper version of operator new for
- the reference-counted idiom, not the deletion idiom. Use the arena
- contains function instead of the vecctor find function.
- (JSC::EvalNode::create): Use the proper version of operator new for
- the reference-counted idiom, not the deletion idiom. Use the arena
- reset function instead of the vector shrink function.
- (JSC::FunctionBodyNode::createNativeThunk): Use the proper version
- of operator new for the reference-counted idiom, not the deletion idiom.
- (JSC::FunctionBodyNode::create): More of the same.
-
- * parser/Nodes.h: Added ParserArenaDeletable and ParserArenaRefCounted
- to replace ParserRefCounted. Fixed inheritance so only the classes that
- need reference counting inherit from ParserArenaRefCounted.
-
- * parser/Parser.cpp:
- (JSC::Parser::parse): Set m_sourceElements to 0 since it now starts
- uninitialized. Just set it to 0 again in the failure case, since it's
- now just a raw pointer, not an owning one.
- (JSC::Parser::reparseInPlace): Removed now-unneeded get() function.
- (JSC::Parser::didFinishParsing): Replaced uses of ParserRefCountedData
- with uses of ParserArenaData.
-
- * parser/Parser.h: Less RefPtr, more arena.
-
- * parser/ParserArena.cpp: Added.
- * parser/ParserArena.h: Added.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::~JSGlobalData): Removed arena-related code, since it's
- now in the Parser.
- (JSC::JSGlobalData::createLeaked): Removed unneeded #ifndef.
- (JSC::JSGlobalData::createNativeThunk): Tweaked #if a bit.
-
- * runtime/JSGlobalData.h: Removed parserArena, which is now in Parser.
-
- * wtf/RefCounted.h: Added deletionHasBegun function, for use in
- assertions to catch deletion not done by the deref function.
-
-2009-05-10 David Kilzer <ddkilzer@apple.com>
-
- Part 2: Try to fix the Windows build by adding a symbol which is really just a re-mangling of a changed method signature
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-10 David Kilzer <ddkilzer@apple.com>
-
- Try to fix the Windows build by removing an unknown symbol
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-10 David Kilzer <ddkilzer@apple.com>
-
- Touch Nodes.cpp to try to fix Windows build
-
- * parser/Nodes.cpp: Removed whitespace.
-
-2009-05-10 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Quick fix for failures seen on buildbot. Maciej plans a better fix later.
-
- * wtf/dtoa.cpp: Change the hardcoded number of 32-bit words in a BigInt
- from 32 to 64. Parsing "1e500", for example, requires more than 32 words.
-
-2009-05-10 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 25674: syntax tree nodes should use arena allocation
- Part one: Change lifetimes so we won't have to use reference
- counting so much, but don't eliminate the reference counts
- entirely yet.
-
- * JavaScriptCore.exp: Updated.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator): Update for use of raw pointers
- instead of RefPtr.
- (JSC::BytecodeGenerator::emitCall): Ditto.
- (JSC::BytecodeGenerator::emitConstruct): Ditto.
-
- * parser/Grammar.y: Update node creating code to use new (JSGlobalData*)
- instead of the plain new. At the moment this is just a hook for future
- arena allocation; it's inline and JSGlobalData* is not used.
-
- * parser/NodeConstructors.h: Updated for name change of parserObjects to
- parserArena. Also added explicit initialization for raw pointers that used
- to be RefPtr. Also removed some uses of get() that aren't needed now that
- the pointers are raw pointers. Also eliminated m_parameter from FuncExprNode
- and FuncDeclNode. Also changed node-creating code to use new (JSGlobalData*)
- as above.
-
- * parser/Nodes.cpp: Eliminated NodeReleaser and all use of it.
- (JSC::ParserRefCounted::ParserRefCounted): Updated for name change of
- parserObjects to parserArena.
- (JSC::SourceElements::append): Use raw pointers.
- (JSC::ArrayNode::emitBytecode): Ditto.
- (JSC::ArrayNode::isSimpleArray): Ditto.
- (JSC::ArrayNode::toArgumentList): Ditto.
- (JSC::ObjectLiteralNode::emitBytecode): Ditto.
- (JSC::PropertyListNode::emitBytecode): Ditto.
- (JSC::BracketAccessorNode::emitBytecode): Ditto.
- (JSC::DotAccessorNode::emitBytecode): Ditto.
- (JSC::ArgumentListNode::emitBytecode): Ditto.
- (JSC::NewExprNode::emitBytecode): Ditto.
- (JSC::EvalFunctionCallNode::emitBytecode): Ditto.
- (JSC::FunctionCallValueNode::emitBytecode): Ditto.
- (JSC::FunctionCallResolveNode::emitBytecode): Ditto.
- (JSC::FunctionCallBracketNode::emitBytecode): Ditto.
- (JSC::FunctionCallDotNode::emitBytecode): Ditto.
- (JSC::CallFunctionCallDotNode::emitBytecode): Ditto.
- (JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto.
- (JSC::PostfixBracketNode::emitBytecode): Ditto.
- (JSC::PostfixDotNode::emitBytecode): Ditto.
- (JSC::DeleteBracketNode::emitBytecode): Ditto.
- (JSC::DeleteDotNode::emitBytecode): Ditto.
- (JSC::DeleteValueNode::emitBytecode): Ditto.
- (JSC::VoidNode::emitBytecode): Ditto.
- (JSC::TypeOfValueNode::emitBytecode): Ditto.
- (JSC::PrefixBracketNode::emitBytecode): Ditto.
- (JSC::PrefixDotNode::emitBytecode): Ditto.
- (JSC::UnaryOpNode::emitBytecode): Ditto.
- (JSC::BinaryOpNode::emitStrcat): Ditto.
- (JSC::BinaryOpNode::emitBytecode): Ditto.
- (JSC::EqualNode::emitBytecode): Ditto.
- (JSC::StrictEqualNode::emitBytecode): Ditto.
- (JSC::ReverseBinaryOpNode::emitBytecode): Ditto.
- (JSC::ThrowableBinaryOpNode::emitBytecode): Ditto.
- (JSC::InstanceOfNode::emitBytecode): Ditto.
- (JSC::LogicalOpNode::emitBytecode): Ditto.
- (JSC::ConditionalNode::emitBytecode): Ditto.
- (JSC::ReadModifyResolveNode::emitBytecode): Ditto.
- (JSC::AssignResolveNode::emitBytecode): Ditto.
- (JSC::AssignDotNode::emitBytecode): Ditto.
- (JSC::ReadModifyDotNode::emitBytecode): Ditto.
- (JSC::AssignBracketNode::emitBytecode): Ditto.
- (JSC::ReadModifyBracketNode::emitBytecode): Ditto.
- (JSC::CommaNode::emitBytecode): Ditto.
- (JSC::ConstDeclNode::emitCodeSingle): Ditto.
- (JSC::ConstDeclNode::emitBytecode): Ditto.
- (JSC::ConstStatementNode::emitBytecode): Ditto.
- (JSC::statementListEmitCode): Ditto.
- (JSC::BlockNode::emitBytecode): Ditto.
- (JSC::ExprStatementNode::emitBytecode): Ditto.
- (JSC::VarStatementNode::emitBytecode): Ditto.
- (JSC::IfNode::emitBytecode): Ditto.
- (JSC::IfElseNode::emitBytecode): Ditto.
- (JSC::DoWhileNode::emitBytecode): Ditto.
- (JSC::WhileNode::emitBytecode): Ditto.
- (JSC::ForNode::emitBytecode): Ditto.
- (JSC::ForInNode::emitBytecode): Ditto.
- (JSC::ReturnNode::emitBytecode): Ditto.
- (JSC::WithNode::emitBytecode): Ditto.
- (JSC::CaseBlockNode::tryOptimizedSwitch): Ditto.
- (JSC::CaseBlockNode::emitBytecodeForBlock): Ditto.
- (JSC::SwitchNode::emitBytecode): Ditto.
- (JSC::LabelNode::emitBytecode): Ditto.
- (JSC::ThrowNode::emitBytecode): Ditto.
- (JSC::TryNode::emitBytecode): Ditto.
- (JSC::ScopeNodeData::ScopeNodeData): Use swap to transfer ownership
- of the arena, varStack and functionStack.
- (JSC::ScopeNode::ScopeNode): Pass in the arena when creating the
- ScopeNodeData.
- (JSC::ProgramNode::ProgramNode): Made this inline since it's used
- in only one place.
- (JSC::ProgramNode::create): Changed this to return a PassRefPtr since
- we plan to have the scope nodes be outside the arena, so they will need
- some kind of ownership transfer (maybe auto_ptr instead of PassRefPtr
- in the future, though). Remove the node from the newly-created arena to
- avoid a circular reference. Later we'll keep the node out of the arena
- by using a different operator new, but for now it's the ParserRefCounted
- constructor that puts the node into the arena, and there's no way to
- bypass that.
- (JSC::EvalNode::EvalNode): Ditto.
- (JSC::EvalNode::create): Ditto.
- (JSC::FunctionBodyNode::FunctionBodyNode): Ditto.
- (JSC::FunctionBodyNode::createNativeThunk): Moved the code that
- reseets the arena here instead of the caller.
- (JSC::FunctionBodyNode::create): Same change as the other create
- functions above.
- (JSC::FunctionBodyNode::emitBytecode): Use raw pointers.
-
- * parser/Nodes.h: Removed NodeReleaser. Changed FunctionStack to
- use raw pointers. Removed the releaseNodes function. Added an override
- of operator new that takes a JSGlobalData* to prepare for future arena use.
- Use raw pointers instead of RefPtr everywhere possible.
-
- * parser/Parser.cpp:
- (JSC::Parser::reparseInPlace): Pass the arena in.
-
- * parser/Parser.h:
- (JSC::Parser::parse): Updated for name change of parserObjects to parserArena.
- (JSC::Parser::reparse): Ditto.
- * runtime/FunctionConstructor.cpp:
- (JSC::extractFunctionBody): Ditto.
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::~JSGlobalData): Ditto.
- (JSC::JSGlobalData::createNativeThunk): Moved arena manipulation into the
- FunctionBodyNode::createNativeThunk function.
-
- * runtime/JSGlobalData.h: Tweaked formatting and renamed parserObjects to
- parserArena.
-
- * wtf/NotFound.h: Added the usual "using WTF" to this header to match the
- rest of WTF.
-
-2009-05-10 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=25670
- Remove no longer valid chunk of code from dtoa.
-
- * wtf/dtoa.cpp:
- (WTF::dtoa): Removed invalid code.
-
-2009-05-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- "Class const *" is the same as "const Class*", use the latter syntax consistently.
-
- See <http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.9>.
-
- * pcre/pcre_compile.cpp:
- (calculateCompiledPatternLength):
- * runtime/JSObject.h:
- (JSC::JSObject::offsetForLocation):
- (JSC::JSObject::locationForOffset):
-
-2009-05-10 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- - speedup dtoa/strtod
-
- Added a bunch of inlining, and replaced malloc with stack allocation.
-
- 0.5% SunSpider speedup (7% on string-tagcloud).
-
- * runtime/NumberPrototype.cpp:
- (JSC::integerPartNoExp):
- (JSC::numberProtoFuncToExponential):
- * runtime/UString.cpp:
- (JSC::concatenate):
- (JSC::UString::from):
- * wtf/dtoa.cpp:
- (WTF::BigInt::BigInt):
- (WTF::BigInt::operator=):
- (WTF::Balloc):
- (WTF::Bfree):
- (WTF::multadd):
- (WTF::s2b):
- (WTF::i2b):
- (WTF::mult):
- (WTF::pow5mult):
- (WTF::lshift):
- (WTF::cmp):
- (WTF::diff):
- (WTF::b2d):
- (WTF::d2b):
- (WTF::ratio):
- (WTF::strtod):
- (WTF::quorem):
- (WTF::freedtoa):
- (WTF::dtoa):
- * wtf/dtoa.h:
-
-2009-05-09 Mike Hommey <glandium@debian.org>
-
- Reviewed by Geoffrey Garen. Landed by Jan Alonzo.
-
- Enable JIT on x86-64 gtk+
- https://bugs.webkit.org/show_bug.cgi?id=24724
-
- * GNUmakefile.am:
-
-2009-05-09 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Removed the last non-call-related manually managed JIT stub call.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall
- abstraction, instead of emitPutJITStubArg.
-
-2009-05-09 Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25653
- PLATFORM(X86_64) inherits ia64
-
- __ia64__ is defined by gcc in an IA64 arch and has completely
- nothing in common with X86-64 exept both are from Intel and have
- an 64bit address space. That's it. Since code seems to expect x86
- here, ia64 has to go.
-
- * wtf/Platform.h:
-
-2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
-
- Suggested by Geoffrey Garen.
-
- Assume SSE2 is present on X86-64 and on MAC X86-32. This fixes a
- build breakage on non-Mac X86-64 when JIT is enabled.
-
- * jit/JITArithmetic.cpp:
-
-2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
-
- Build fix, adding missing files to make dist.
-
- * GNUmakefile.am:
-
-2009-05-09 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::patchLoadToLEA):
-
-2009-05-09 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::patchLoadToLEA):
-
-2009-05-09 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Original patch by John McCall. Updated by Cameron Zwarich. Further refined by me.
-
- - Assorted speedups to property access
-
- ~.3%-1% speedup on SunSpider
-
- 1) When we know from the structure ID that an object is using inline storage, plant direct
- loads and stores against it; no need to indirect through storage pointer.
-
- 2) Also because of the above, union the property storage pointer with the first inline property
- slot and add an extra inline property slot.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction):
- (JSC::AbstractMacroAssembler::CodeLocationInstruction::patchLoadToLEA):
- (JSC::::CodeLocationCommon::instructionAtOffset):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::storePtr):
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::store32):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::storePtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::movq_EAXm):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::patchLoadToLEA):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JIT.h:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compilePutDirectOffset):
- (JSC::JIT::compileGetDirectOffset):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::removeDirect):
- * runtime/JSObject.h:
- (JSC::JSObject::propertyStorage):
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getOffset):
- (JSC::JSObject::offsetForLocation):
- (JSC::JSObject::locationForOffset):
- (JSC::JSObject::getDirectOffset):
- (JSC::JSObject::putDirectOffset):
- (JSC::JSObject::isUsingInlineStorage):
- (JSC::JSObject::):
- (JSC::JSObject::JSObject):
- (JSC::JSObject::~JSObject):
- (JSC::Structure::isUsingInlineStorage):
- (JSC::JSObject::putDirect):
- (JSC::JSObject::putDirectWithoutTransition):
- (JSC::JSObject::allocatePropertyStorageInline):
- * runtime/Structure.h:
-
-2009-05-09 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Changed all our JIT stubs so that they return a maximum of 1 JS value or
- two non-JS pointers, and do all other value returning through out
- parameters, in preparation for 64bit JS values on a 32bit system.
-
- Stubs that used to return two JSValues now return one JSValue and take
- and out parameter specifying where in the register array the second
- value should go.
-
- SunSpider reports no change.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_post_inc):
- (JSC::JIT::compileFastArithSlow_op_post_dec):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_call_arityCheck):
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_post_inc):
- (JSC::JITStubs::cti_op_resolve_with_base):
- (JSC::JITStubs::cti_op_post_dec):
- * jit/JITStubs.h:
- (JSC::):
-
-2009-05-08 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed <rdar://problem/6634956> CrashTracer: [REGRESSION] >400 crashes
- in Safari at com.apple.JavaScriptCore • JSC::BytecodeGenerator::emitComplexJumpScopes + 468
- https://bugs.webkit.org/show_bug.cgi?id=25658
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitComplexJumpScopes): Guard the whole loop
- with a bounds check. The old loop logic would decrement and read topScope
- without a bounds check, which could cause crashes on page boundaries.
-
-2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by NOBODY (BuildFix).
-
- Gtk fix: add LiteralParser to the build script per r43424.
-
- Add LiteralParser to the Qt and Wx build scripts too.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCoreSources.bkl:
-
-2009-05-08 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough and Darin Adler.
-
- Add a limited literal parser for eval to handle object and array literals fired at eval
-
- This is a simplified parser and lexer that we can throw at strings passed to eval
- in case a site is using eval to parse JSON (eg. json2.js). The lexer is intentionally
- limited (in effect it's whitelisting a limited "common" subset of the JSON grammar)
- as this decreases the likelihood of us wating time attempting to parse any significant
- amount of non-JSON content.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::callEval):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval):
- * runtime/LiteralParser.cpp: Added.
- (JSC::isStringCharacter):
- (JSC::LiteralParser::Lexer::lex):
- (JSC::LiteralParser::Lexer::lexString):
- (JSC::LiteralParser::Lexer::lexNumber):
- (JSC::LiteralParser::parseStatement):
- (JSC::LiteralParser::parseExpression):
- (JSC::LiteralParser::parseArray):
- (JSC::LiteralParser::parseObject):
- (JSC::LiteralParser::StackGuard::StackGuard):
- (JSC::LiteralParser::StackGuard::~StackGuard):
- (JSC::LiteralParser::StackGuard::isSafe):
- * runtime/LiteralParser.h: Added.
- (JSC::LiteralParser::LiteralParser):
- (JSC::LiteralParser::attemptJSONParse):
- (JSC::LiteralParser::):
- (JSC::LiteralParser::Lexer::Lexer):
- (JSC::LiteralParser::Lexer::next):
- (JSC::LiteralParser::Lexer::currentToken):
- (JSC::LiteralParser::abortParse):
-
-2009-05-08 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Restored a Mozilla JS test I accidentally gutted.
-
- * tests/mozilla/ecma/Array/15.4.4.2.js:
- (getTestCases):
- (test):
-
-2009-05-08 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- More abstraction for JITStub calls from JITed code.
-
- Added a JITStubCall class that automatically handles things like assigning
- arguments to different stack slots and storing return values. Deployed
- the class in about a billion places. A bunch more places remain to be
- fixed up, but this is a good stopping point for now.
-
- * jit/JIT.cpp:
- (JSC::JIT::emitTimeoutCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- (JSC::JIT::JSRInfo::JSRInfo):
- (JSC::JITStubCall::JITStubCall):
- (JSC::JITStubCall::addArgument):
+ (JSC::JIT::compilePatchGetArrayLength):
+ * jit/JITStubCall.h:
(JSC::JITStubCall::call):
- (JSC::JITStubCall::):
- (JSC::CallEvalJITStub::CallEvalJITStub):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_lshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_jnless):
- (JSC::JIT::compileFastArithSlow_op_bitand):
- (JSC::JIT::compileFastArithSlow_op_mod):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArithSlow_op_post_inc):
- (JSC::JIT::compileFastArithSlow_op_post_dec):
- (JSC::JIT::compileFastArithSlow_op_pre_inc):
- (JSC::JIT::compileFastArithSlow_op_pre_dec):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArith_op_sub):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::compileFastArithSlow_op_add):
- (JSC::JIT::compileFastArithSlow_op_mul):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_resolve_with_base):
-2009-05-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
- Add a new opcode jnlesseq, and optimize its compilation in the JIT using
- techniques similar to what were used to optimize jnless in r43363.
-
- This gives a 0.7% speedup on SunSpider, particularly on the tests 3d-cube,
- control-flow-recursive, date-format-xparb, and string-base64.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Add support for dumping op_jnlesseq.
- * bytecode/Opcode.h: Add op_jnlesseq to the list of opcodes.
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitJumpIfFalse): Add a peephole optimization
- for op_jnlesseq when emitting lesseq followed by a jump.
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute): Add case for op_jnlesseq.
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass): Add case for op_jnlesseq.
- (JSC::JIT::privateCompileSlowCases): Add case for op_jnlesseq.
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_jnlesseq): Added.
- (JSC::JIT::compileFastArithSlow_op_jnlesseq): Added.
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_jlesseq): Added.
- * jit/JITStubs.h:
-
-2009-05-08 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix test failures on 64-bit
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_jnless): Avoid accidentaly treating an
- immediate int as an immediate float in the 64-bit value representation.
-
-2009-05-08 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Oliver Hunt.
-
- Removing an empty constructor and an uncalled, empty function seems to be a
- pretty solid 1% regeression on my machine, so I'm going to put them back.
- Um. Yeah, this this pretty pointles and makes no sense at all. I officially
- lose the will to live in 3... 2...
-
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingTool::notifyOfScope):
- * bytecode/SamplingTool.h:
- (JSC::SamplingTool::~SamplingTool):
-
-2009-05-08 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver "I see lots of ifdefs" Hunt.
-
- Fix (kinda) for sampling tool breakage. The codeblock sampling tool has become
- b0rked due to recent changes in native function calling. The initialization of
- a ScopeNode appears to now occur before the sampling tool (or possibly the
- interpreter has been brought into existence, wihich leads to crashyness).
-
- This patch doesn't fix the problem. The crash occurs when tracking a Scope, but
- we shouldn't need to track scopes when we're just sampling opcodes, not
- codeblocks. Not retaining Scopes when just opcode sampling will reduce sampling
- overhead reducing any instrumentation skew, which is a good thing. As a side
- benefit this patch also gets the opcode sampling going again, albeit in a bit of
- a lame way. Will come back later with a proper fix from codeblock sampling.
-
- * JavaScriptCore.exp:
- * bytecode/SamplingTool.cpp:
- (JSC::compareLineCountInfoSampling):
- (JSC::SamplingTool::dump):
- * bytecode/SamplingTool.h:
- (JSC::SamplingTool::SamplingTool):
- * parser/Nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
-
-2009-05-07 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
- Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
-
- Roll out r43366 as it removed symbols that Safari 4 Beta uses.
-
- * JavaScriptCore.exp:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingThread::start):
- (JSC::SamplingThread::stop):
- * bytecode/SamplingTool.h:
- * wtf/CrossThreadRefCounted.h:
- (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
- (WTF::::ref):
- (WTF::::deref):
- * wtf/Threading.h:
- * wtf/ThreadingNone.cpp:
- * wtf/ThreadingPthreads.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::identifierByPthreadHandle):
- (WTF::establishIdentifierForPthreadHandle):
- (WTF::pthreadHandleForIdentifier):
- (WTF::clearPthreadHandleForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
- * wtf/ThreadingWin.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::storeThreadHandleByIdentifier):
- (WTF::threadHandleForIdentifier):
- (WTF::clearThreadHandleForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
- * wtf/gtk/ThreadingGtk.cpp:
- (WTF::threadMapMutex):
- (WTF::initializeThreading):
- (WTF::threadMap):
- (WTF::identifierByGthreadHandle):
- (WTF::establishIdentifierForThread):
- (WTF::threadForIdentifier):
- (WTF::clearThreadForIdentifier):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
- * wtf/qt/ThreadingQt.cpp:
- (WTF::threadMapMutex):
- (WTF::threadMap):
- (WTF::identifierByQthreadHandle):
- (WTF::establishIdentifierForThread):
- (WTF::clearThreadForIdentifier):
- (WTF::threadForIdentifier):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
-2009-05-07 Gustavo Noronha Silva <gns@gnome.org>
-
- Suggested by Oliver Hunt.
-
- Also check for Linux for the special-cased calling convention.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * wtf/Platform.h:
-
-2009-05-07 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Previously, when appending to an existing string and growing the underlying buffer,
- we would actually allocate 110% of the required size in order to give us some space
- to expand into. Now we treat strings differently based on their size:
-
- Small Strings (up to 4 pages):
- Expand the allocation size to 112.5% of the amount requested. This is largely sicking
- to our previous policy, however 112.5% is cheaper to calculate.
-
- Medium Strings (up to 128 pages):
- For pages covering multiple pages over-allocation is less of a concern - any unused
- space will not be paged in if it is not used, so this is purely a VM overhead. For
- these strings allocate 2x the requested size.
-
- Large Strings (to infinity and beyond!):
- Revert to our 112.5% policy - probably best to limit the amount of unused VM we allow
- any individual string be responsible for.
-
- Additionally, round small allocations up to a multiple of 16 bytes, and medium and
- large allocations up to a multiple of page size.
-
- ~1.5% progression on Sunspider, due to 5% improvement on tagcloud & 15% on validate.
-
- * runtime/UString.cpp:
- (JSC::expandedSize):
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed a minor sequencing error introduced by recent Parser speedups.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::createNativeThunk): Missed a spot in my last patch.
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- * wtf/Platform.h: Reverted an accidental (and performance-catastrophic)
- change.
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed a minor sequencing error introduced by recent Parser speedups.
-
- * parser/Parser.cpp:
- (JSC::Parser::reparseInPlace): Missed a spot in my last patch.
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed a minor sequencing error introduced by recent Parser speedups.
-
- * parser/Parser.cpp:
- (JSC::Parser::parse):
- * parser/Parser.h:
- (JSC::Parser::parse):
- (JSC::Parser::reparse): Shrink the parsedObjects vector after allocating
- the root node, to avoid leaving a stray node in the vector, since that's
- a slight memory leak, and it causes problems during JSGlobalData teardown.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::~JSGlobalData): ASSERT that we're not being torn
- down while we think we're still parsing, since that would cause lots of
- bad memory references during our destruction.
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Replaced two more macros with references to the JITStackFrame structure.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- * jit/JITStubs.cpp:
- (JSC::):
- * jit/JITStubs.h:
-
-2009-05-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve native call performance
-
- Fix the windows build by adding calling convention declarations everywhere,
- chose fastcall as that seemed most sensible given we were having to declare
- the convention explicitly. In addition switched to fastcall on mac in the
- deluded belief that documented fastcall behavior on windows would match
- actual its actual behavior.
-
- * API/JSCallbackFunction.h:
- * API/JSCallbackObject.h:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- * interpreter/CallFrame.h:
- (JSC::ExecState::argumentCount):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jsc.cpp:
- (functionPrint):
- (functionDebug):
- (functionGC):
- (functionVersion):
- (functionRun):
- (functionLoad):
- (functionSetSamplingFlags):
- (functionClearSamplingFlags):
- (functionReadline):
- (functionQuit):
- * runtime/ArrayConstructor.cpp:
- (JSC::callArrayConstructor):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncToString):
- (JSC::arrayProtoFuncToLocaleString):
- (JSC::arrayProtoFuncJoin):
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncReverse):
- (JSC::arrayProtoFuncShift):
- (JSC::arrayProtoFuncSlice):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncSplice):
- (JSC::arrayProtoFuncUnShift):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncReduce):
- (JSC::arrayProtoFuncReduceRight):
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanConstructor.cpp:
- (JSC::callBooleanConstructor):
- * runtime/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncToString):
- (JSC::booleanProtoFuncValueOf):
- * runtime/CallData.h:
- * runtime/DateConstructor.cpp:
- (JSC::callDate):
- (JSC::dateParse):
- (JSC::dateNow):
- (JSC::dateUTC):
- * runtime/DatePrototype.cpp:
- (JSC::dateProtoFuncToString):
- (JSC::dateProtoFuncToUTCString):
- (JSC::dateProtoFuncToDateString):
- (JSC::dateProtoFuncToTimeString):
- (JSC::dateProtoFuncToLocaleString):
- (JSC::dateProtoFuncToLocaleDateString):
- (JSC::dateProtoFuncToLocaleTimeString):
- (JSC::dateProtoFuncGetTime):
- (JSC::dateProtoFuncGetFullYear):
- (JSC::dateProtoFuncGetUTCFullYear):
- (JSC::dateProtoFuncToGMTString):
- (JSC::dateProtoFuncGetMonth):
- (JSC::dateProtoFuncGetUTCMonth):
- (JSC::dateProtoFuncGetDate):
- (JSC::dateProtoFuncGetUTCDate):
- (JSC::dateProtoFuncGetDay):
- (JSC::dateProtoFuncGetUTCDay):
- (JSC::dateProtoFuncGetHours):
- (JSC::dateProtoFuncGetUTCHours):
- (JSC::dateProtoFuncGetMinutes):
- (JSC::dateProtoFuncGetUTCMinutes):
- (JSC::dateProtoFuncGetSeconds):
- (JSC::dateProtoFuncGetUTCSeconds):
- (JSC::dateProtoFuncGetMilliSeconds):
- (JSC::dateProtoFuncGetUTCMilliseconds):
- (JSC::dateProtoFuncGetTimezoneOffset):
- (JSC::dateProtoFuncSetTime):
- (JSC::dateProtoFuncSetMilliSeconds):
- (JSC::dateProtoFuncSetUTCMilliseconds):
- (JSC::dateProtoFuncSetSeconds):
- (JSC::dateProtoFuncSetUTCSeconds):
- (JSC::dateProtoFuncSetMinutes):
- (JSC::dateProtoFuncSetUTCMinutes):
- (JSC::dateProtoFuncSetHours):
- (JSC::dateProtoFuncSetUTCHours):
- (JSC::dateProtoFuncSetDate):
- (JSC::dateProtoFuncSetUTCDate):
- (JSC::dateProtoFuncSetMonth):
- (JSC::dateProtoFuncSetUTCMonth):
- (JSC::dateProtoFuncSetFullYear):
- (JSC::dateProtoFuncSetUTCFullYear):
- (JSC::dateProtoFuncSetYear):
- (JSC::dateProtoFuncGetYear):
- * runtime/ErrorConstructor.cpp:
- (JSC::callErrorConstructor):
- * runtime/ErrorPrototype.cpp:
- (JSC::errorProtoFuncToString):
- * runtime/FunctionConstructor.cpp:
- (JSC::callFunctionConstructor):
- * runtime/FunctionPrototype.cpp:
- (JSC::callFunctionPrototype):
- (JSC::functionProtoFuncToString):
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall):
- * runtime/JSFunction.h:
- (JSC::JSFunction::nativeFunction):
- (JSC::JSFunction::setScopeChain):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval):
- (JSC::globalFuncParseInt):
- (JSC::globalFuncParseFloat):
- (JSC::globalFuncIsNaN):
- (JSC::globalFuncIsFinite):
- (JSC::globalFuncDecodeURI):
- (JSC::globalFuncDecodeURIComponent):
- (JSC::globalFuncEncodeURI):
- (JSC::globalFuncEncodeURIComponent):
- (JSC::globalFuncEscape):
- (JSC::globalFuncUnescape):
- (JSC::globalFuncJSCPrint):
- * runtime/JSGlobalObjectFunctions.h:
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncAbs):
- (JSC::mathProtoFuncACos):
- (JSC::mathProtoFuncASin):
- (JSC::mathProtoFuncATan):
- (JSC::mathProtoFuncATan2):
- (JSC::mathProtoFuncCeil):
- (JSC::mathProtoFuncCos):
- (JSC::mathProtoFuncExp):
- (JSC::mathProtoFuncFloor):
- (JSC::mathProtoFuncLog):
- (JSC::mathProtoFuncMax):
- (JSC::mathProtoFuncMin):
- (JSC::mathProtoFuncPow):
- (JSC::mathProtoFuncRandom):
- (JSC::mathProtoFuncRound):
- (JSC::mathProtoFuncSin):
- (JSC::mathProtoFuncSqrt):
- (JSC::mathProtoFuncTan):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::callNativeErrorConstructor):
- * runtime/NativeFunctionWrapper.h:
- * runtime/NumberConstructor.cpp:
- (JSC::callNumberConstructor):
- * runtime/NumberPrototype.cpp:
- (JSC::numberProtoFuncToString):
- (JSC::numberProtoFuncToLocaleString):
- (JSC::numberProtoFuncValueOf):
- (JSC::numberProtoFuncToFixed):
- (JSC::numberProtoFuncToExponential):
- (JSC::numberProtoFuncToPrecision):
- * runtime/ObjectConstructor.cpp:
- (JSC::callObjectConstructor):
- * runtime/ObjectPrototype.cpp:
- (JSC::objectProtoFuncValueOf):
- (JSC::objectProtoFuncHasOwnProperty):
- (JSC::objectProtoFuncIsPrototypeOf):
- (JSC::objectProtoFuncDefineGetter):
- (JSC::objectProtoFuncDefineSetter):
- (JSC::objectProtoFuncLookupGetter):
- (JSC::objectProtoFuncLookupSetter):
- (JSC::objectProtoFuncPropertyIsEnumerable):
- (JSC::objectProtoFuncToLocaleString):
- (JSC::objectProtoFuncToString):
- * runtime/ObjectPrototype.h:
- * runtime/RegExpConstructor.cpp:
- (JSC::callRegExpConstructor):
- * runtime/RegExpObject.cpp:
- (JSC::callRegExpObject):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncTest):
- (JSC::regExpProtoFuncExec):
- (JSC::regExpProtoFuncCompile):
- (JSC::regExpProtoFuncToString):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCode):
- (JSC::callStringConstructor):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncToString):
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncIndexOf):
- (JSC::stringProtoFuncLastIndexOf):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- (JSC::stringProtoFuncSlice):
- (JSC::stringProtoFuncSplit):
- (JSC::stringProtoFuncSubstr):
- (JSC::stringProtoFuncSubstring):
- (JSC::stringProtoFuncToLowerCase):
- (JSC::stringProtoFuncToUpperCase):
- (JSC::stringProtoFuncLocaleCompare):
- (JSC::stringProtoFuncBig):
- (JSC::stringProtoFuncSmall):
- (JSC::stringProtoFuncBlink):
- (JSC::stringProtoFuncBold):
- (JSC::stringProtoFuncFixed):
- (JSC::stringProtoFuncItalics):
- (JSC::stringProtoFuncStrike):
- (JSC::stringProtoFuncSub):
- (JSC::stringProtoFuncSup):
- (JSC::stringProtoFuncFontcolor):
- (JSC::stringProtoFuncFontsize):
- (JSC::stringProtoFuncAnchor):
- (JSC::stringProtoFuncLink):
- * wtf/Platform.h:
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Rolled out a portion of r43352 because it broke 64bit.
-
- * jit/JITStubs.h:
-
-2009-05-07 Kevin Ollivier <kevino@theolliviers.com>
-
- Build fix for functions reaturning ThreadIdentifier.
-
- * wtf/ThreadingNone.cpp:
- (WTF::createThreadInternal):
- (WTF::currentThread):
-
-2009-05-07 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by John Honeycutt.
-
- - enable optimization case im the last patch that I accidentally had disabled.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_jnless):
-
-2009-05-07 Dmitry Titov <dimich@chromium.org>
-
- Attempt to fix Win build.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_jnless):
-
-2009-05-07 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov and Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25348
- Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
-
- * wtf/Threading.h:
- (WTF::ThreadIdentifier::ThreadIdentifier):
- (WTF::ThreadIdentifier::isValid):
- (WTF::ThreadIdentifier::invalidate):
- (WTF::ThreadIdentifier::platformId):
- ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
- methods that are used across the code on thread ids: construction, comparisons,
- check for 'valid' state etc. '0' is used as invalid id, which happens to just work
- with all platform-specific thread id implementations.
-
- All the following files repeatedly reflect the new ThreadIdentifier for each platform.
- We remove ThreadMap and threadMapMutex from all of them, remove the functions that
- populated/searched/cleared the map and add platform-specific comparison operators
- for ThreadIdentifier.
-
- * wtf/gtk/ThreadingGtk.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
- * wtf/ThreadingNone.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
-
- * wtf/ThreadingPthreads.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::detachThread):
- (WTF::currentThread):
-
- * wtf/qt/ThreadingQt.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal):
- (WTF::waitForThreadCompletion):
- (WTF::currentThread):
-
- * wtf/ThreadingWin.cpp:
- (WTF::ThreadIdentifier::operator==):
- (WTF::ThreadIdentifier::operator!=):
- (WTF::initializeThreading):
- (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
- counter as a thread ID and mapped it into platform ID. Windows was using native thread
- id and mapped it into thread handle. Since we can always obtain a thread handle
- by thread id, createThread now closes the handle.
- (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
- it means the thread already exited.
- (WTF::detachThread):
- (WTF::currentThread):
- (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
- (WTF::waitForThreadCompletionDeprecated): same.
- (WTF::currentThreadDeprecated): same.
- (WTF::createThreadDeprecated): same.
-
- * bytecode/SamplingTool.h:
- * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
-
- * JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names
- since they now take a different type as a parameter.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
- that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
-
-2009-05-07 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Sam Weinig.
-
- - optimize various cases of branch-fused less
-
- 1% speedup on SunSpider overall
- 13% speedup on math-cordic
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- op_loop_if_less: Optimize case of constant as first operand, just as case of constant as
- second operand.
- op_jnless: Factored out into compileFastArith_op_jnless.
- (JSC::JIT::privateCompileSlowCases):
- op_jnless: Factored out into compileFastArithSlow_op_jnless.
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_jnless): Factored out from main compile loop.
- - Generate inline code for comparison of constant immediate int as first operand to another
- immediate int, as for loop_if_less
-
- (JSC::JIT::compileFastArithSlow_op_jnless):
- - Generate inline code for comparing two floating point numbers.
- - Generate code for both cases of comparing a floating point number to a constant immediate
- int.
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Fix dumping of op_jnless (tangentially related bugfix).
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Added the return address of a stub function to the JITStackFrame abstraction.
-
- * jit/JIT.cpp:
- * jit/JIT.h:
- * jit/JITStubs.cpp:
- (JSC::):
- (JSC::StackHack::StackHack):
- (JSC::StackHack::~StackHack):
- (JSC::returnToThrowTrampoline):
- (JSC::JITStubs::cti_op_convert_this):
- (JSC::JITStubs::cti_op_end):
- (JSC::JITStubs::cti_op_add):
- (JSC::JITStubs::cti_op_pre_inc):
- (JSC::JITStubs::cti_timeout_check):
- (JSC::JITStubs::cti_register_file_check):
- (JSC::JITStubs::cti_op_loop_if_less):
- (JSC::JITStubs::cti_op_loop_if_lesseq):
- (JSC::JITStubs::cti_op_new_object):
- (JSC::JITStubs::cti_op_put_by_id_generic):
- (JSC::JITStubs::cti_op_get_by_id_generic):
- (JSC::JITStubs::cti_op_put_by_id):
- (JSC::JITStubs::cti_op_put_by_id_second):
- (JSC::JITStubs::cti_op_put_by_id_fail):
- (JSC::JITStubs::cti_op_get_by_id):
- (JSC::JITStubs::cti_op_get_by_id_second):
- (JSC::JITStubs::cti_op_get_by_id_self_fail):
- (JSC::JITStubs::cti_op_get_by_id_proto_list):
- (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
- (JSC::JITStubs::cti_op_get_by_id_proto_fail):
- (JSC::JITStubs::cti_op_get_by_id_array_fail):
- (JSC::JITStubs::cti_op_get_by_id_string_fail):
- (JSC::JITStubs::cti_op_instanceof):
- (JSC::JITStubs::cti_op_del_by_id):
- (JSC::JITStubs::cti_op_mul):
- (JSC::JITStubs::cti_op_new_func):
- (JSC::JITStubs::cti_op_call_JSFunction):
- (JSC::JITStubs::cti_op_call_arityCheck):
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_vm_lazyLinkCall):
- (JSC::JITStubs::cti_op_push_activation):
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_create_arguments):
- (JSC::JITStubs::cti_op_create_arguments_no_params):
- (JSC::JITStubs::cti_op_tear_off_activation):
- (JSC::JITStubs::cti_op_tear_off_arguments):
- (JSC::JITStubs::cti_op_profile_will_call):
- (JSC::JITStubs::cti_op_profile_did_call):
- (JSC::JITStubs::cti_op_ret_scopeChain):
- (JSC::JITStubs::cti_op_new_array):
- (JSC::JITStubs::cti_op_resolve):
- (JSC::JITStubs::cti_op_construct_JSConstruct):
- (JSC::JITStubs::cti_op_construct_NotJSConstruct):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_string):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_sub):
- (JSC::JITStubs::cti_op_put_by_val):
- (JSC::JITStubs::cti_op_put_by_val_array):
- (JSC::JITStubs::cti_op_put_by_val_byte_array):
- (JSC::JITStubs::cti_op_lesseq):
- (JSC::JITStubs::cti_op_loop_if_true):
- (JSC::JITStubs::cti_op_load_varargs):
- (JSC::JITStubs::cti_op_negate):
- (JSC::JITStubs::cti_op_resolve_base):
- (JSC::JITStubs::cti_op_resolve_skip):
- (JSC::JITStubs::cti_op_resolve_global):
- (JSC::JITStubs::cti_op_div):
- (JSC::JITStubs::cti_op_pre_dec):
- (JSC::JITStubs::cti_op_jless):
- (JSC::JITStubs::cti_op_not):
- (JSC::JITStubs::cti_op_jtrue):
- (JSC::JITStubs::cti_op_post_inc):
- (JSC::JITStubs::cti_op_eq):
- (JSC::JITStubs::cti_op_lshift):
- (JSC::JITStubs::cti_op_bitand):
- (JSC::JITStubs::cti_op_rshift):
- (JSC::JITStubs::cti_op_bitnot):
- (JSC::JITStubs::cti_op_resolve_with_base):
- (JSC::JITStubs::cti_op_new_func_exp):
- (JSC::JITStubs::cti_op_mod):
- (JSC::JITStubs::cti_op_less):
- (JSC::JITStubs::cti_op_neq):
- (JSC::JITStubs::cti_op_post_dec):
- (JSC::JITStubs::cti_op_urshift):
- (JSC::JITStubs::cti_op_bitxor):
- (JSC::JITStubs::cti_op_new_regexp):
- (JSC::JITStubs::cti_op_bitor):
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_op_throw):
- (JSC::JITStubs::cti_op_get_pnames):
- (JSC::JITStubs::cti_op_next_pname):
- (JSC::JITStubs::cti_op_push_scope):
- (JSC::JITStubs::cti_op_pop_scope):
- (JSC::JITStubs::cti_op_typeof):
- (JSC::JITStubs::cti_op_is_undefined):
- (JSC::JITStubs::cti_op_is_boolean):
- (JSC::JITStubs::cti_op_is_number):
- (JSC::JITStubs::cti_op_is_string):
- (JSC::JITStubs::cti_op_is_object):
- (JSC::JITStubs::cti_op_is_function):
- (JSC::JITStubs::cti_op_stricteq):
- (JSC::JITStubs::cti_op_to_primitive):
- (JSC::JITStubs::cti_op_strcat):
- (JSC::JITStubs::cti_op_nstricteq):
- (JSC::JITStubs::cti_op_to_jsnumber):
- (JSC::JITStubs::cti_op_in):
- (JSC::JITStubs::cti_op_push_new_scope):
- (JSC::JITStubs::cti_op_jmp_scopes):
- (JSC::JITStubs::cti_op_put_by_index):
- (JSC::JITStubs::cti_op_switch_imm):
- (JSC::JITStubs::cti_op_switch_char):
- (JSC::JITStubs::cti_op_switch_string):
- (JSC::JITStubs::cti_op_del_by_val):
- (JSC::JITStubs::cti_op_put_getter):
- (JSC::JITStubs::cti_op_put_setter):
- (JSC::JITStubs::cti_op_new_error):
- (JSC::JITStubs::cti_op_debug):
- (JSC::JITStubs::cti_vm_throw):
- * jit/JITStubs.h:
- (JSC::JITStackFrame::returnAddressSlot):
-
-2009-05-07 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::lex): Fix missing braces. This would make us always
- take the slower case for string parsing and Visual Studio correctly
- noticed unreachable code.
-
-2009-05-07 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 25589: goto instead of state machine in lexer
- https://bugs.webkit.org/show_bug.cgi?id=25589
-
- SunSpider is 0.8% faster.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::currentCharacter): Added.
- (JSC::Lexer::currentOffset): Changed to call currentCharacter for clarity.
- (JSC::Lexer::setCode): Removed code to set now-obsolete m_skipLineEnd.
- (JSC::Lexer::shiftLineTerminator): Added. Handles line numbers and the
- two-character line terminators.
- (JSC::Lexer::makeIdentifier): Changed to take characters and length rather
- than a vector, since we now make these directly out of the source buffer
- when possible.
- (JSC::Lexer::lastTokenWasRestrKeyword): Added.
- (JSC::isNonASCIIIdentStart): Broke out the non-inline part.
- (JSC::isIdentStart): Moved here.
- (JSC::isNonASCIIIdentPart): Broke out the non-inline part.
- (JSC::isIdentPart): Moved here.
- (JSC::singleEscape): Moved here, and removed some unneeded cases.
- (JSC::Lexer::record8): Moved here.
- (JSC::Lexer::record16): Moved here.
- (JSC::Lexer::lex): Rewrote this whole function to use goto and not use
- a state machine. Got rid of most of the local variables. Also rolled the
- matchPunctuator function in here.
- (JSC::Lexer::scanRegExp): Changed to use the new version of isLineTerminator.
- Clear m_buffer16 after using it instead of before.
-
- * parser/Lexer.h: Removed State enum, setDone function, nextLine function,
- lookupKeywordFunction, one of the isLineTerminator functions, m_done data member,
- m_skipLineEnd data member, and m_state data member. Added shiftLineTerminator
- function, currentCharacter function, and changed the arguments to the makeIdentifier
- function. Removed one branch from the isLineTerminator function.
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace): Streamlined the case where we don't replace anything.
-
-2009-05-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Removed a few more special constants, and replaced them with uses of
- the JITStackFrame struct.
-
- Removed one of the two possible definitions of VoidPtrPair. The Mac
- definition was more elegant, but SunSpider doesn't think it's any
- faster, and it's net less elegant to have two ways of doing things.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- * jit/JITStubs.h:
- (JSC::):
-
-2009-05-07 Darin Adler <darin@apple.com>
-
- * runtime/ScopeChain.h:
- (JSC::ScopeChainNode::~ScopeChainNode): Tweak formatting.
-
-2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix the build thread stack base determination build on Symbian,
- by moving the code block before PLATFORM(UNIX), which is also
- enabled on Symbian builds.
-
- * runtime/Collector.cpp:
- (JSC::currentThreadStackBase):
-
-2009-05-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Fix crash due to incorrectly using an invalid scopechain
-
- stringProtoFuncReplace was checking for an exception on a CachedCall
- by asking for the cached callframes exception. Unfortunately this
- could crash in certain circumstances as CachedCall does not guarantee
- a valid callframe following a call. Even more unfortunately the check
- was entirely unnecessary as there is only a single exception slot per
- global data, so it was already checked via the initial exec->hadException()
- check.
-
- To make bugs like this more obvious, i've added a debug only destructor
- to ScopeChainNode that 0's all of its fields. This exposed a crash in
- the standard javascriptcore tests.
+ Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
+ unnecessary WTF:: usings.
+ Remove existing unnecessary WTF:: usings.
+ * interpreter/Interpreter.h:
+ * profiler/CallIdentifier.h:
* runtime/ScopeChain.h:
- (JSC::ScopeChainNode::~ScopeChainNode):
- (JSC::ScopeChain::~ScopeChain):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
-
-2009-05-07 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Enable op_strcat across += assignments. This patch allows the lhs of a read/modify node
- to be included within the concatenation operation, and also modifies the implementation
- of the concatenation to attempt to reuse and cat onto the leftmost string, rather than
- always allocating a new empty output string to copy into (as was previously the behaviour).
-
- ~0.5% progression, due to a 3%-3.5% progression on the string tests (particularly validate).
-
- * parser/Nodes.cpp:
- (JSC::BinaryOpNode::emitStrcat):
- (JSC::emitReadModifyAssignment):
- (JSC::ReadModifyResolveNode::emitBytecode):
- (JSC::ReadModifyDotNode::emitBytecode):
- (JSC::ReadModifyBracketNode::emitBytecode):
- * parser/Nodes.h:
- * runtime/Operations.h:
- (JSC::concatenateStrings):
- * runtime/UString.cpp:
- (JSC::UString::reserveCapacity):
- * runtime/UString.h:
-
-2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Oliver Hunt.
-
- Fix the build on Windows without JIT: interpreter/RegisterFile.h needs
- roundUpAllocationSize, which is protected by #if ENABLED(ASSEMBLER).
- Moved the #ifdef down and always offer the function.
-
- * jit/ExecutableAllocator.h:
-
-2009-05-06 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Gavin "++" Barraclough.
-
- Added some abstraction around the JIT stub calling convention by creating
- a struct to represent the persistent stack frame JIT code shares with
- JIT stubs.
-
- SunSpider reports no change.
-
- * jit/JIT.h:
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_convert_this):
- (JSC::JITStubs::cti_op_end):
- (JSC::JITStubs::cti_op_add):
- (JSC::JITStubs::cti_op_pre_inc):
- (JSC::JITStubs::cti_timeout_check):
- (JSC::JITStubs::cti_register_file_check):
- (JSC::JITStubs::cti_op_loop_if_less):
- (JSC::JITStubs::cti_op_loop_if_lesseq):
- (JSC::JITStubs::cti_op_new_object):
- (JSC::JITStubs::cti_op_put_by_id_generic):
- (JSC::JITStubs::cti_op_get_by_id_generic):
- (JSC::JITStubs::cti_op_put_by_id):
- (JSC::JITStubs::cti_op_put_by_id_second):
- (JSC::JITStubs::cti_op_put_by_id_fail):
- (JSC::JITStubs::cti_op_get_by_id):
- (JSC::JITStubs::cti_op_get_by_id_second):
- (JSC::JITStubs::cti_op_get_by_id_self_fail):
- (JSC::JITStubs::cti_op_get_by_id_proto_list):
- (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
- (JSC::JITStubs::cti_op_get_by_id_proto_fail):
- (JSC::JITStubs::cti_op_get_by_id_array_fail):
- (JSC::JITStubs::cti_op_get_by_id_string_fail):
- (JSC::JITStubs::cti_op_instanceof):
- (JSC::JITStubs::cti_op_del_by_id):
- (JSC::JITStubs::cti_op_mul):
- (JSC::JITStubs::cti_op_new_func):
- (JSC::JITStubs::cti_op_call_JSFunction):
- (JSC::JITStubs::cti_op_call_arityCheck):
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_vm_lazyLinkCall):
- (JSC::JITStubs::cti_op_push_activation):
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_create_arguments):
- (JSC::JITStubs::cti_op_create_arguments_no_params):
- (JSC::JITStubs::cti_op_tear_off_activation):
- (JSC::JITStubs::cti_op_tear_off_arguments):
- (JSC::JITStubs::cti_op_profile_will_call):
- (JSC::JITStubs::cti_op_profile_did_call):
- (JSC::JITStubs::cti_op_ret_scopeChain):
- (JSC::JITStubs::cti_op_new_array):
- (JSC::JITStubs::cti_op_resolve):
- (JSC::JITStubs::cti_op_construct_JSConstruct):
- (JSC::JITStubs::cti_op_construct_NotJSConstruct):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_string):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_sub):
- (JSC::JITStubs::cti_op_put_by_val):
- (JSC::JITStubs::cti_op_put_by_val_array):
- (JSC::JITStubs::cti_op_put_by_val_byte_array):
- (JSC::JITStubs::cti_op_lesseq):
- (JSC::JITStubs::cti_op_loop_if_true):
- (JSC::JITStubs::cti_op_load_varargs):
- (JSC::JITStubs::cti_op_negate):
- (JSC::JITStubs::cti_op_resolve_base):
- (JSC::JITStubs::cti_op_resolve_skip):
- (JSC::JITStubs::cti_op_resolve_global):
- (JSC::JITStubs::cti_op_div):
- (JSC::JITStubs::cti_op_pre_dec):
- (JSC::JITStubs::cti_op_jless):
- (JSC::JITStubs::cti_op_not):
- (JSC::JITStubs::cti_op_jtrue):
- (JSC::JITStubs::cti_op_post_inc):
- (JSC::JITStubs::cti_op_eq):
- (JSC::JITStubs::cti_op_lshift):
- (JSC::JITStubs::cti_op_bitand):
- (JSC::JITStubs::cti_op_rshift):
- (JSC::JITStubs::cti_op_bitnot):
- (JSC::JITStubs::cti_op_resolve_with_base):
- (JSC::JITStubs::cti_op_new_func_exp):
- (JSC::JITStubs::cti_op_mod):
- (JSC::JITStubs::cti_op_less):
- (JSC::JITStubs::cti_op_neq):
- (JSC::JITStubs::cti_op_post_dec):
- (JSC::JITStubs::cti_op_urshift):
- (JSC::JITStubs::cti_op_bitxor):
- (JSC::JITStubs::cti_op_new_regexp):
- (JSC::JITStubs::cti_op_bitor):
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_op_throw):
- (JSC::JITStubs::cti_op_get_pnames):
- (JSC::JITStubs::cti_op_next_pname):
- (JSC::JITStubs::cti_op_push_scope):
- (JSC::JITStubs::cti_op_pop_scope):
- (JSC::JITStubs::cti_op_typeof):
- (JSC::JITStubs::cti_op_is_undefined):
- (JSC::JITStubs::cti_op_is_boolean):
- (JSC::JITStubs::cti_op_is_number):
- (JSC::JITStubs::cti_op_is_string):
- (JSC::JITStubs::cti_op_is_object):
- (JSC::JITStubs::cti_op_is_function):
- (JSC::JITStubs::cti_op_stricteq):
- (JSC::JITStubs::cti_op_to_primitive):
- (JSC::JITStubs::cti_op_strcat):
- (JSC::JITStubs::cti_op_nstricteq):
- (JSC::JITStubs::cti_op_to_jsnumber):
- (JSC::JITStubs::cti_op_in):
- (JSC::JITStubs::cti_op_push_new_scope):
- (JSC::JITStubs::cti_op_jmp_scopes):
- (JSC::JITStubs::cti_op_put_by_index):
- (JSC::JITStubs::cti_op_switch_imm):
- (JSC::JITStubs::cti_op_switch_char):
- (JSC::JITStubs::cti_op_switch_string):
- (JSC::JITStubs::cti_op_del_by_val):
- (JSC::JITStubs::cti_op_put_getter):
- (JSC::JITStubs::cti_op_put_setter):
- (JSC::JITStubs::cti_op_new_error):
- (JSC::JITStubs::cti_op_debug):
- (JSC::JITStubs::cti_vm_throw):
- * jit/JITStubs.h:
- (JSC::):
-
-2009-05-06 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak & Darin Adler.
-
- Improve string concatenation (as coded in JS as a sequence of adds).
-
- Detect patterns corresponding to string concatenation, and change the bytecode
- generation to emit a new op_strcat instruction. By handling the full set of
- additions within a single function we do not need allocate JSString wrappers
- for intermediate results, and we can calculate the size of the output string
- prior to allocating storage, in order to prevent reallocation of the buffer.
-
- 1.5%-2% progression on Sunspider, largely due to a 30% progression on date-format-xparb.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- Add new opcodes.
- * bytecode/Opcode.h:
- Add new opcodes.
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitStrcat):
- (JSC::BytecodeGenerator::emitToPrimitive):
- Add generation of new opcodes.
- * bytecompiler/BytecodeGenerator.h:
- Add generation of new opcodes.
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- Add implmentation of new opcodes.
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- Add implmentation of new opcodes.
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_to_primitive):
- (JSC::JITStubs::cti_op_strcat):
- Add implmentation of new opcodes.
- * jit/JITStubs.h:
- Add implmentation of new opcodes.
- * parser/Nodes.cpp:
- (JSC::BinaryOpNode::emitStrcat):
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::ReadModifyResolveNode::emitBytecode):
- Add generation of new opcodes.
- * parser/Nodes.h:
- (JSC::ExpressionNode::):
- (JSC::AddNode::):
- Add methods to allow identification of add nodes.
- * parser/ResultType.h:
- (JSC::ResultType::definitelyIsString):
- (JSC::ResultType::forAdd):
- Fix error in detection of adds that will produce string results.
- * runtime/Operations.h:
- (JSC::concatenateStrings):
- Add implmentation of new opcodes.
- * runtime/UString.cpp:
- (JSC::UString::appendNumeric):
- Add methods to append numbers to an existing string.
- * runtime/UString.h:
- (JSC::UString::Rep::createEmptyBuffer):
- (JSC::UString::BaseString::BaseString):
- Add support for creating an empty string with a non-zero capacity available in the BaseString.
-
-2009-05-06 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Made RefCounted::m_refCount private.
-
- * runtime/Structure.h: Removed addressOfCount.
- * wtf/RefCounted.h: Made m_refCount private.
- Added addressOfCount.
-
-2009-05-06 Darin Adler <darin@apple.com>
-
- Fixed assertion seen a lot!
-
- * parser/Nodes.cpp:
- (JSC::FunctionBodyNode::~FunctionBodyNode): Removed now-bogus assertion.
-
-2009-05-06 Darin Adler <darin@apple.com>
-
- Working with Sam Weinig.
-
- Redo parse tree constructor optimization without breaking the Windows
- build the way I did yesterday. The previous try broke the build by adding
- an include of Lexer.h and all its dependencies that had to work outside
- the JavaScriptCore project.
-
- * GNUmakefile.am: Added NodeConstructors.h.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- Removed byteocde directory -- we no longer are trying to include Lexer.h
- outside JavaScriptCore.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Change SegmentedVector.h
- and Lexer.h back to internal files. Added NodeConstructors.h.
-
- * parser/Grammar.y: Added include of NodeConstructors.h.
- Changed use of ConstDeclNode to use public functions.
-
- * parser/NodeConstructors.h: Copied from parser/Nodes.h.
- Just contains the inlined constructors now.
-
- * parser/Nodes.cpp: Added include of NodeConstructors.h.
- Moved node constructors into the header.
- (JSC::FunctionBodyNode::FunctionBodyNode): Removed m_refCount
- initialization.
-
- * parser/Nodes.h: Removed all the constructor definitions, and also
- removed the JSC_FAST_CALL from them since these are all inlined, so the
- calling convention is irrelevant. Made more things private. Used a data
- member for operator opcodes instead of a virtual function. Removed the
- special FunctionBodyNode::ref/deref functions since the default functions
- are now just as fast.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::extractFunctionBody): Fixed types here so we don't typecast until
- after we do type checking.
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- Fix the Qt build on Windows.
-
- * JavaScriptCore.pri: Define BUILDING_JavaScriptCore/WTF to get the meaning
- of the JS_EXPORTDATA macros correct
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- Enable the JIT for the Qt build on Windows.
-
- * JavaScriptCore.pri:
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Tweak JavaScriptCore.pri for being able to override the generated sources dir for the
- generated_files target.
-
- * JavaScriptCore.pri:
-
-2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Build QtWebKit as a framework on Mac
-
- This implies both debug and release build by default, unless
- one of the --debug or --release config options are passed to
- the build-webkit script.
-
- Frameworks can be disabled by passing CONFIG+=webkit_no_framework
- to the build-webkit script.
-
- To be able to build both debug and release targets in parallel
- we have to use separate output directories for the generated
- sources, which is not optimal, but required to avoid race conditions.
-
- An optimization would be to only require this spit-up on Mac.
-
- * JavaScriptCore.pri:
- * JavaScriptCore.pro:
- * jsc.pro:
-
-2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
-
- A couple of the generators left the bison output file in the source
- tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
- work well when building release and debug configurations in parallel.
-
- * JavaScriptCore.pri:
-
-2009-05-05 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Simplified a bit of codegen.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2009-05-05 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Moved all the JIT stub related code into one place.
-
- * jit/JIT.cpp:
- * jit/JIT.h:
- * jit/JITCode.h:
- * jit/JITStubs.cpp:
- (JSC::):
- * jit/JITStubs.h:
-
-2009-05-05 Sam Weinig <sam@webkit.org>
-
- Try to fix Windows build.
-
- Move Node constructor to the .cpp file.
-
- * parser/Nodes.cpp:
- * parser/Nodes.h:
-
-2009-05-05 Darin Adler <darin@apple.com>
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
- Try to fix Mac build.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Made SegmentedVector.h private.
-
-2009-05-05 Darin Adler <darin@apple.com>
-
- Try to fix Mac build.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Made Lexer.h private.
-
-2009-05-05 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 25569: make ParserRefCounted use conventional reference counting
- https://bugs.webkit.org/show_bug.cgi?id=25569
-
- SunSpider speedup of about 1.6%.
-
- * JavaScriptCore.exp: Updated.
-
- * parser/Nodes.cpp:
- (JSC::NodeReleaser::releaseAllNodes): ALWAYS_INLINE.
- (JSC::NodeReleaser::adopt): Ditto.
- (JSC::ParserRefCounted::ParserRefCounted): Removed most of the code.
- Add the object to a Vector<RefPtr> that gets cleared after parsing.
- (JSC::ParserRefCounted::~ParserRefCounted): Removed most of the code.
-
- * parser/Nodes.h: Made ParserRefCounted inherit from RefCounted and
- made inline versions of the constructor and destructor. Made the
- Node constructor inline.
-
- * parser/Parser.cpp:
- (JSC::Parser::parse): Call globalData->parserObjects.shrink(0) after
- parsing, where it used to call ParserRefCounted::deleteNewObjects.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Eliminated code to manage the
- newParserObjects and parserObjectExtraRefCounts.
- (JSC::JSGlobalData::~JSGlobalData): Ditto.
-
- * runtime/JSGlobalData.h: Replaced the HashSet and HashCountedSet
- with a Vector.
-
- * wtf/PassRefPtr.h:
- (WTF::PassRefPtr::~PassRefPtr): The most common thing to do with a
- PassRefPtr in hot code is to pass it and then destroy it once it's
- set to zero. Help the optimizer by telling it that's true.
-
-2009-05-05 Xan Lopez <xlopez@igalia.com> and Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Oliver Hunt.
-
- Disable the NativeFunctionWrapper for all non-Mac ports for now,
- as it is also crashing on Linux/x86.
-
- * runtime/NativeFunctionWrapper.h:
-
-2009-05-05 Steve Falkenburg <sfalken@apple.com>
-
- Fix build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Expose toThisObject for the DOM Window
-
- * JavaScriptCore.exp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Make windows go again until i work out the
- accursed calling convention).
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * jit/JIT.cpp:
- * runtime/NativeFunctionWrapper.h:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Fix windows debug builds).
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Hopefully the last fix).
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Fix the build fix caused by a different build fix).
-
- * parser/Nodes.cpp:
- * parser/Nodes.h:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (No idea how my changes could have broken these).
-
- * runtime/DatePrototype.cpp:
- * runtime/RegExpObject.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Why should i expect msvc to list all the errors in a file?).
-
- * parser/Nodes.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Fix warning, and another missing include).
-
- * jit/JIT.cpp:
- * parser/Nodes.h:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (More build fixes).
-
- * runtime/ErrorPrototype.cpp:
- * runtime/JSGlobalObject.cpp:
- * runtime/NumberPrototype.cpp:
- * runtime/ObjectPrototype.cpp:
- * runtime/StringConstructor.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Will the fixes never end?).
-
- * runtime/FunctionPrototype.h:
- * runtime/Lookup.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (More build fixes).
-
- * jit/JIT.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (More build fixing).
-
- * runtime/CallData.h:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- * runtime/ArrayConstructor.cpp:
- * runtime/BooleanPrototype.cpp:
- * runtime/DateConstructor.cpp:
- * runtime/Error.cpp:
- * runtime/ObjectConstructor.cpp:
- * runtime/RegExpPrototype.cpp:
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Buildfix).
-
- Add missing file
-
- * runtime/NativeFunctionWrapper.h: Copied from JavaScriptCore/jit/ExecutableAllocator.cpp.
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 25559: Improve native function call performance
- <https://bugs.webkit.org/show_bug.cgi?id=25559>
-
- In order to cache calls to native functions we now make the standard
- prototype functions use a small assembly thunk that converts the JS
- calling convention into the native calling convention. As this is
- only beneficial in the JIT we use the NativeFunctionWrapper typedef
- to alternate between PrototypeFunction and JSFunction to keep the
- code sane. This change from PrototypeFunction to NativeFunctionWrapper
- is the bulk of this patch.
-
- * JavaScriptCore.exp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::call):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::addPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::leaq_mr):
- (JSC::X86Assembler::call_m):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute):
- (JSC::Interpreter::prepareForRepeatCall):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::JIT::compileCTIMachineTrampolines):
- * jit/JITCall.cpp:
- (JSC::JIT::linkCall):
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCall):
- * jit/JITCode.h:
- (JSC::JITCode::operator bool):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetFromCallFrameHeader):
- (JSC::JIT::emitGetFromCallFrameHeader32):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::JITStubs):
- (JSC::JITStubs::cti_op_call_JSFunction):
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_vm_lazyLinkCall):
- (JSC::JITStubs::cti_op_construct_JSConstruct):
- * jit/JITStubs.h:
- (JSC::JITStubs::ctiNativeCallThunk):
- * jsc.cpp:
- (GlobalObject::GlobalObject):
- * parser/Nodes.cpp:
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::createNativeThunk):
- (JSC::FunctionBodyNode::generateJITCode):
- * parser/Nodes.h:
- (JSC::FunctionBodyNode::):
- (JSC::FunctionBodyNode::generatedJITCode):
- (JSC::FunctionBodyNode::jitCode):
- * profiler/Profiler.cpp:
- (JSC::Profiler::createCallIdentifier):
- * runtime/ArgList.h:
- * runtime/ArrayPrototype.cpp:
- (JSC::isNumericCompareFunction):
- * runtime/BooleanPrototype.cpp:
- (JSC::BooleanPrototype::BooleanPrototype):
- * runtime/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- * runtime/ErrorPrototype.cpp:
- (JSC::ErrorPrototype::ErrorPrototype):
- * runtime/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::addFunctionProperties):
- (JSC::functionProtoFuncToString):
- * runtime/FunctionPrototype.h:
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::~JSFunction):
- (JSC::JSFunction::mark):
- (JSC::JSFunction::getCallData):
- (JSC::JSFunction::call):
- (JSC::JSFunction::argumentsGetter):
- (JSC::JSFunction::callerGetter):
- (JSC::JSFunction::lengthGetter):
- (JSC::JSFunction::getOwnPropertySlot):
- (JSC::JSFunction::put):
- (JSC::JSFunction::deleteProperty):
- (JSC::JSFunction::getConstructData):
- (JSC::JSFunction::construct):
- * runtime/JSFunction.h:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::setScope):
- (JSC::JSFunction::scope):
- (JSC::JSFunction::isHostFunction):
- (JSC::JSFunction::scopeChain):
- (JSC::JSFunction::clearScopeChain):
- (JSC::JSFunction::setScopeChain):
- (JSC::JSFunction::nativeFunction):
- (JSC::JSFunction::setNativeFunction):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::~JSGlobalData):
- (JSC::JSGlobalData::createNativeThunk):
- * runtime/JSGlobalData.h:
- (JSC::JSGlobalData::nativeFunctionThunk):
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- * runtime/JSGlobalObject.h:
- * runtime/Lookup.cpp:
- (JSC::setUpStaticFunctionSlot):
- * runtime/Lookup.h:
- * runtime/NumberPrototype.cpp:
- (JSC::NumberPrototype::NumberPrototype):
- * runtime/ObjectPrototype.cpp:
- (JSC::ObjectPrototype::ObjectPrototype):
- * runtime/RegExpPrototype.cpp:
- (JSC::RegExpPrototype::RegExpPrototype):
- * runtime/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
-
-2009-05-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- For convenience, let the sampling flags tool clear multiple flags at once.
-
- * jsc.cpp:
- (GlobalObject::GlobalObject):
- (functionSetSamplingFlags):
- (functionClearSamplingFlags):
-
-2009-05-04 Maciej Stachowiak <mjs@apple.com>
-
- Rubber stamped by Gavin.
-
- - inline Vector::resize for a ~1.5% speedup on string-tagcloud
-
- * wtf/Vector.h:
- (WTF::Vector::resize): Inline
-
-2009-05-03 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
-
-2009-05-03 Mark Rowe <mrowe@apple.com>
-
- Fix the 64-bit build.
-
- * API/APICast.h:
- (toJS):
- (toRef):
- * runtime/JSNumberCell.cpp:
- (JSC::jsAPIMangledNumber):
- * runtime/JSNumberCell.h:
-
-2009-05-02 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back in one last time (I hope).
-
-2009-05-03 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back out. It still breaks windows.
-
-2009-05-03 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back in.
-
-2009-05-02 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 25519: streamline lexer by handling BOMs differently
- https://bugs.webkit.org/show_bug.cgi?id=25519
-
- Roughly 1% faster SunSpider.
-
- * parser/Grammar.y: Tweak formatting a bit.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members
- that are set up by setCode.
- (JSC::Lexer::currentOffset): Added. Used where the old code would look at
- m_currentOffset.
- (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything
- to handle BOM characters.
- (JSC::Lexer::shift2): Ditto.
- (JSC::Lexer::shift3): Ditto.
- (JSC::Lexer::shift4): Ditto.
- (JSC::Lexer::setCode): Updated for name change from yylineno to m_line.
- Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword.
- Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old
- m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code
- to scan for a BOM character and call copyCodeWithoutBOMs() if we find any.
- (JSC::Lexer::copyCodeWithoutBOMs): Added.
- (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line.
- (JSC::Lexer::makeIdentifier): Moved up higher in the file.
- (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to
- use a switch statement instead of just if statements.
- (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to
- have fewer branches.
- (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old
- m_restrKeyword boolean.
- (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use
- fewer branches in the ASCII but not identifier case.
- (JSC::Lexer::isIdentPart): Ditto.
- (JSC::Lexer::singleEscape): Moved up higher in the file.
- (JSC::Lexer::convertOctal): Moved up higher in the file.
- (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use
- toASCIIHexValue instead of rolling our own here.
- (JSC::Lexer::convertUnicode): Ditto.
- (JSC::Lexer::record8): Moved up higher in the file.
- (JSC::Lexer::record16): Moved up higher in the file.
- (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF
- and m_skipCR with m_skipLineEnd, which requires fewer branches in the
- main lexer loop. Use currentOffset instead of m_currentOffset. Removed
- unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit.
- Split out the two cases for InIdentifierOrKeyword and InIdentifier.
- Added special case tight loops for identifiers and other simple states.
- Removed a branch from the code that sets m_atLineStart to false using goto.
- Streamlined the number-handling code so we don't check for the same types
- twice for non-numeric cases and don't add a null to m_buffer8 when it's
- not being used. Removed m_eatNextIdentifier, which wasn't working anyway,
- and m_restrKeyword, which is redundant with m_lastToken. Set the
- m_delimited flag without using a branch.
- (JSC::Lexer::scanRegExp): Tweaked style a bit.
- (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after
- parsing. Clear out UString objects in the more conventional way.
- (JSC::Lexer::sourceCode): Made this no-longer inline since it has more
- work to do in the case where we stripped BOMs.
-
- * parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex
- function, which is the same as toASCIIHexValue. Removed isHexDigit
- function, which is the same as isASCIIHedDigit. Replaced shift with four
- separate shift functions. Removed isWhiteSpace function that passes
- m_current, instead just passing m_current explicitly. Removed isOctalDigit,
- which is the same as isASCIIOctalDigit. Eliminated unused arguments from
- matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the
- makeIdentifier function out of the header. Added lastTokenWasRestrKeyword
- function. Added new constants for m_skipLineEnd. Removed unused yycolumn,
- m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken,
- m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2,
- m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and
- m_codeWithoutBOMs.
-
- * parser/SourceProvider.h: Added hasBOMs function. In the future this can
- be used to tell the lexer about strings known not to have BOMs.
-
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
-
- * wtf/ASCIICType.h: Added using statements to match the design of the
- other WTF headers.
-
-2009-05-02 Ada Chan <adachan@apple.com>
-
- Fix windows build (when doing a clean build)
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Simplified null-ish JSValues.
-
- Replaced calls to noValue() with calls to JSValue() (which is what
- noValue() returned). Removed noValue().
-
- Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
- Its one remaining use is for construction of hash table deleted values.
- For that specific task, I made a new, private constructor with a special
- tag. Removed jsImpossibleValue().
-
- Removed "JSValue()" initialiazers, since default construction happens...
- by default.
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::::call):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitLoad):
- * bytecompiler/BytecodeGenerator.h:
- * debugger/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate):
- * debugger/DebuggerCallFrame.h:
- (JSC::DebuggerCallFrame::DebuggerCallFrame):
- * interpreter/CallFrame.h:
- (JSC::ExecState::clearException):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveLastCaller):
- * interpreter/Register.h:
- (JSC::Register::Register):
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCall):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_vm_throw):
- * profiler/Profiler.cpp:
- (JSC::Profiler::willExecute):
- (JSC::Profiler::didExecute):
- * runtime/ArrayPrototype.cpp:
- (JSC::getProperty):
- * runtime/Completion.cpp:
- (JSC::evaluate):
- * runtime/Completion.h:
- (JSC::Completion::Completion):
- * runtime/GetterSetter.cpp:
- (JSC::GetterSetter::getPrimitiveNumber):
- * runtime/JSArray.cpp:
- (JSC::JSArray::putSlowCase):
- (JSC::JSArray::deleteProperty):
- (JSC::JSArray::increaseVectorLength):
- (JSC::JSArray::setLength):
- (JSC::JSArray::pop):
- (JSC::JSArray::sort):
- (JSC::JSArray::compactForSorting):
- * runtime/JSCell.cpp:
- (JSC::JSCell::getJSNumber):
- * runtime/JSCell.h:
- (JSC::JSValue::getJSNumber):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::fromNumberOutsideIntegerRange):
- (JSC::JSImmediate::from):
- * runtime/JSNumberCell.cpp:
- (JSC::jsNumberCell):
- * runtime/JSObject.cpp:
- (JSC::callDefaultValueFunction):
- * runtime/JSObject.h:
- (JSC::JSObject::getDirect):
- * runtime/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::toPrimitive):
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::next):
- * runtime/JSValue.h:
- (JSC::JSValue::):
- (JSC::JSValueHashTraits::constructDeletedValue):
- (JSC::JSValueHashTraits::isDeletedValue):
- (JSC::JSValue::JSValue):
- * runtime/JSWrapperObject.h:
- (JSC::JSWrapperObject::JSWrapperObject):
- * runtime/Operations.h:
- (JSC::resolveBase):
- * runtime/PropertySlot.h:
- (JSC::PropertySlot::clearBase):
- (JSC::PropertySlot::clearValue):
-
-2009-05-02 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - speed up the lexer in various ways
-
- ~2% command-line SunSpider speedup
-
- * parser/Lexer.cpp:
- (JSC::Lexer::setCode): Moved below shift() so it can inline.
- (JSC::Lexer::scanRegExp): Use resize(0) instead of clear() on Vectors, since the intent
- here is not to free the underlying buffer.
- (JSC::Lexer::lex): ditto; also, change the loop logic a bit for the main lexing loop
- to avoid branching on !m_done twice per iteration. Now we only check it once.
- (JSC::Lexer::shift): Make this ALWAYS_INLINE and tag an unusual branch as UNLIKELY
- * parser/Lexer.h:
- (JSC::Lexer::makeIdentifier): force to be ALWAYS_INLINE
- * wtf/Vector.h:
- (WTF::::append): force to be ALWAYS_INLINE (may have helped in ways other than parsing but it wasn't
- getting inlined in a hot code path in the lexer)
-
-2009-05-01 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore.make:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Fix 64bit build.
-
- * runtime/JSNumberCell.h:
- (JSC::JSValue::JSValue):
- * runtime/JSValue.h:
- (JSC::jsNumber):
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Roll out JavaScriptCore API number marshaling.
-
- * API/APICast.h:
- (toJS):
- (toRef):
- * API/JSBase.cpp:
- (JSEvaluateScript):
- (JSCheckScriptSyntax):
- * API/JSCallbackConstructor.cpp:
- (JSC::constructJSCallback):
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::getOwnPropertySlot):
- (JSC::::put):
- (JSC::::deleteProperty):
- (JSC::::construct):
- (JSC::::hasInstance):
- (JSC::::call):
- (JSC::::toNumber):
- (JSC::::toString):
- (JSC::::staticValueGetter):
- (JSC::::callbackGetter):
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunction):
- (JSObjectMakeArray):
- (JSObjectMakeDate):
- (JSObjectMakeError):
- (JSObjectMakeRegExp):
- (JSObjectGetPrototype):
- (JSObjectSetPrototype):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectGetPropertyAtIndex):
- (JSObjectSetPropertyAtIndex):
- (JSObjectDeleteProperty):
- (JSObjectCallAsFunction):
- (JSObjectCallAsConstructor):
- * API/JSValueRef.cpp:
- (JSValueGetType):
- (JSValueIsUndefined):
- (JSValueIsNull):
- (JSValueIsBoolean):
- (JSValueIsNumber):
- (JSValueIsString):
- (JSValueIsObject):
- (JSValueIsObjectOfClass):
- (JSValueIsEqual):
- (JSValueIsStrictEqual):
- (JSValueIsInstanceOfConstructor):
- (JSValueMakeUndefined):
- (JSValueMakeNull):
- (JSValueMakeBoolean):
- (JSValueMakeNumber):
- (JSValueMakeString):
- (JSValueToBoolean):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- (JSValueProtect):
- (JSValueUnprotect):
- * JavaScriptCore.exp:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- * runtime/JSNumberCell.cpp:
- * runtime/JSNumberCell.h:
- * runtime/JSValue.h:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Fix windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Fix the build.
-
- * JavaScriptCore.exp:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey "Too Far!" Garen.
-
- Move JS number construction into JSValue.
-
- * runtime/JSImmediate.h:
- * runtime/JSNumberCell.h:
- (JSC::JSValue::JSValue):
- * runtime/JSValue.h:
- (JSC::jsNumber):
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff "The Minneapolis" Garen.
-
- Add mechanism to vend heap allocated JS numbers to JavaScriptCore API clients with a
- representation that is independent of the number representation in the VM.
- - Numbers leaving the interpreter are converted to a tagged JSNumberCell.
- - The numbers coming into the interpreter (asserted to be the tagged JSNumberCell) are
- converted back to the VM's internal number representation.
-
- * API/APICast.h:
- (toJS):
- (toRef):
- * API/JSBase.cpp:
- (JSEvaluateScript):
- (JSCheckScriptSyntax):
- * API/JSCallbackConstructor.cpp:
- (JSC::constructJSCallback):
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::getOwnPropertySlot):
- (JSC::::put):
- (JSC::::deleteProperty):
- (JSC::::construct):
- (JSC::::hasInstance):
- (JSC::::call):
- (JSC::::toNumber):
- (JSC::::toString):
- (JSC::::staticValueGetter):
- (JSC::::callbackGetter):
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunction):
- (JSObjectMakeArray):
- (JSObjectMakeDate):
- (JSObjectMakeError):
- (JSObjectMakeRegExp):
- (JSObjectGetPrototype):
- (JSObjectSetPrototype):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectGetPropertyAtIndex):
- (JSObjectSetPropertyAtIndex):
- (JSObjectDeleteProperty):
- (JSObjectCallAsFunction):
- (JSObjectCallAsConstructor):
- * API/JSValueRef.cpp:
- (JSValueGetType):
- (JSValueIsUndefined):
- (JSValueIsNull):
- (JSValueIsBoolean):
- (JSValueIsNumber):
- (JSValueIsString):
- (JSValueIsObject):
- (JSValueIsObjectOfClass):
- (JSValueIsEqual):
- (JSValueIsStrictEqual):
- (JSValueIsInstanceOfConstructor):
- (JSValueMakeUndefined):
- (JSValueMakeNull):
- (JSValueMakeBoolean):
- (JSValueMakeNumber):
- (JSValueMakeString):
- (JSValueToBoolean):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- (JSValueProtect):
- (JSValueUnprotect):
- * runtime/JSNumberCell.cpp:
- (JSC::jsAPIMangledNumber):
- * runtime/JSNumberCell.h:
- (JSC::JSNumberCell::isAPIMangledNumber):
- (JSC::JSNumberCell::):
- (JSC::JSNumberCell::JSNumberCell):
- (JSC::JSValue::isAPIMangledNumber):
- * runtime/JSValue.h:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 6.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 5.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 4.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 3.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 2.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Windows build fix take 1.
+ * wtf/FastAllocBase.h:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+2009-06-24 David Levin <levin@chromium.org>
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
+ Fix all builds.
- Rubber Stamped by Sam Weinig.
-
- Renamed JSValuePtr => JSValue.
-
- * API/APICast.h:
- (toJS):
- (toRef):
- * API/JSCallbackConstructor.h:
- (JSC::JSCallbackConstructor::createStructure):
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackFunction.h:
- (JSC::JSCallbackFunction::createStructure):
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::createStructure):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::asCallbackObject):
- (JSC::::put):
- (JSC::::hasInstance):
- (JSC::::call):
- (JSC::::staticValueGetter):
- (JSC::::staticFunctionGetter):
- (JSC::::callbackGetter):
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- (JSObjectMakeConstructor):
- (JSObjectSetPrototype):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectGetPropertyAtIndex):
- (JSObjectSetPropertyAtIndex):
- * API/JSValueRef.cpp:
- (JSValueGetType):
- (JSValueIsUndefined):
- (JSValueIsNull):
- (JSValueIsBoolean):
- (JSValueIsNumber):
- (JSValueIsString):
- (JSValueIsObject):
- (JSValueIsObjectOfClass):
- (JSValueIsEqual):
- (JSValueIsStrictEqual):
- (JSValueIsInstanceOfConstructor):
- (JSValueToBoolean):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- (JSValueProtect):
- (JSValueUnprotect):
- * JavaScriptCore.exp:
- * bytecode/CodeBlock.cpp:
- (JSC::valueToSourceString):
- (JSC::constantName):
- (JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
- (JSC::CodeBlock::getConstant):
- (JSC::CodeBlock::addUnexpectedConstant):
- (JSC::CodeBlock::unexpectedConstant):
- * bytecode/EvalCodeCache.h:
- (JSC::EvalCodeCache::get):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::addConstant):
- (JSC::BytecodeGenerator::addUnexpectedConstant):
- (JSC::BytecodeGenerator::emitLoad):
- (JSC::BytecodeGenerator::emitGetScopedVar):
- (JSC::BytecodeGenerator::emitPutScopedVar):
- (JSC::BytecodeGenerator::emitNewError):
- (JSC::keyForImmediateSwitch):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
- (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- * debugger/Debugger.cpp:
- (JSC::evaluateInGlobalCallFrame):
- * debugger/Debugger.h:
- * debugger/DebuggerActivation.cpp:
- (JSC::DebuggerActivation::put):
- (JSC::DebuggerActivation::putWithAttributes):
- (JSC::DebuggerActivation::lookupGetter):
- (JSC::DebuggerActivation::lookupSetter):
- * debugger/DebuggerActivation.h:
- (JSC::DebuggerActivation::createStructure):
- * debugger/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate):
- * debugger/DebuggerCallFrame.h:
- (JSC::DebuggerCallFrame::DebuggerCallFrame):
- (JSC::DebuggerCallFrame::exception):
- * interpreter/CachedCall.h:
- (JSC::CachedCall::CachedCall):
- (JSC::CachedCall::call):
- (JSC::CachedCall::setThis):
- (JSC::CachedCall::setArgument):
- * interpreter/CallFrame.cpp:
- (JSC::CallFrame::thisValue):
- (JSC::CallFrame::dumpCaller):
- * interpreter/CallFrame.h:
- (JSC::ExecState::setException):
- (JSC::ExecState::exception):
- (JSC::ExecState::exceptionSlot):
- * interpreter/CallFrameClosure.h:
- (JSC::CallFrameClosure::setArgument):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::resolve):
- (JSC::Interpreter::resolveSkip):
- (JSC::Interpreter::resolveGlobal):
- (JSC::Interpreter::resolveBase):
- (JSC::Interpreter::resolveBaseAndProperty):
- (JSC::Interpreter::resolveBaseAndFunc):
- (JSC::isNotObject):
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::unwindCallFrame):
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::prepareForRepeatCall):
- (JSC::Interpreter::createExceptionScope):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- (JSC::Interpreter::retrieveCaller):
- (JSC::Interpreter::retrieveLastCaller):
- * interpreter/Interpreter.h:
- * interpreter/Register.h:
- (JSC::Register::):
- (JSC::Register::Register):
- (JSC::Register::jsValue):
- * jit/JIT.cpp:
- (JSC::):
- (JSC::JIT::privateCompileMainPass):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_mod):
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCall):
- * jit/JITCode.h:
- (JSC::):
- (JSC::JITCode::execute):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::getConstantOperand):
- (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
- (JSC::JIT::emitInitRegister):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::tryCachePutByID):
- (JSC::JITStubs::tryCacheGetByID):
- (JSC::JITStubs::cti_op_convert_this):
- (JSC::JITStubs::cti_op_add):
- (JSC::JITStubs::cti_op_pre_inc):
- (JSC::JITStubs::cti_op_loop_if_less):
- (JSC::JITStubs::cti_op_loop_if_lesseq):
- (JSC::JITStubs::cti_op_get_by_id_generic):
- (JSC::JITStubs::cti_op_get_by_id):
- (JSC::JITStubs::cti_op_get_by_id_second):
- (JSC::JITStubs::cti_op_get_by_id_self_fail):
- (JSC::JITStubs::cti_op_get_by_id_proto_list):
- (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
- (JSC::JITStubs::cti_op_get_by_id_proto_fail):
- (JSC::JITStubs::cti_op_get_by_id_array_fail):
- (JSC::JITStubs::cti_op_get_by_id_string_fail):
- (JSC::JITStubs::cti_op_instanceof):
- (JSC::JITStubs::cti_op_del_by_id):
- (JSC::JITStubs::cti_op_mul):
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_resolve):
- (JSC::JITStubs::cti_op_construct_NotJSConstruct):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_string):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_sub):
- (JSC::JITStubs::cti_op_put_by_val):
- (JSC::JITStubs::cti_op_put_by_val_array):
- (JSC::JITStubs::cti_op_put_by_val_byte_array):
- (JSC::JITStubs::cti_op_lesseq):
- (JSC::JITStubs::cti_op_loop_if_true):
- (JSC::JITStubs::cti_op_load_varargs):
- (JSC::JITStubs::cti_op_negate):
- (JSC::JITStubs::cti_op_resolve_base):
- (JSC::JITStubs::cti_op_resolve_skip):
- (JSC::JITStubs::cti_op_resolve_global):
- (JSC::JITStubs::cti_op_div):
- (JSC::JITStubs::cti_op_pre_dec):
- (JSC::JITStubs::cti_op_jless):
- (JSC::JITStubs::cti_op_not):
- (JSC::JITStubs::cti_op_jtrue):
- (JSC::JITStubs::cti_op_post_inc):
- (JSC::JITStubs::cti_op_eq):
- (JSC::JITStubs::cti_op_lshift):
- (JSC::JITStubs::cti_op_bitand):
- (JSC::JITStubs::cti_op_rshift):
- (JSC::JITStubs::cti_op_bitnot):
- (JSC::JITStubs::cti_op_resolve_with_base):
- (JSC::JITStubs::cti_op_mod):
- (JSC::JITStubs::cti_op_less):
- (JSC::JITStubs::cti_op_neq):
- (JSC::JITStubs::cti_op_post_dec):
- (JSC::JITStubs::cti_op_urshift):
- (JSC::JITStubs::cti_op_bitxor):
- (JSC::JITStubs::cti_op_bitor):
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_op_throw):
- (JSC::JITStubs::cti_op_next_pname):
- (JSC::JITStubs::cti_op_typeof):
- (JSC::JITStubs::cti_op_is_undefined):
- (JSC::JITStubs::cti_op_is_boolean):
- (JSC::JITStubs::cti_op_is_number):
- (JSC::JITStubs::cti_op_is_string):
- (JSC::JITStubs::cti_op_is_object):
- (JSC::JITStubs::cti_op_is_function):
- (JSC::JITStubs::cti_op_stricteq):
- (JSC::JITStubs::cti_op_nstricteq):
- (JSC::JITStubs::cti_op_to_jsnumber):
- (JSC::JITStubs::cti_op_in):
- (JSC::JITStubs::cti_op_switch_imm):
- (JSC::JITStubs::cti_op_switch_char):
- (JSC::JITStubs::cti_op_switch_string):
- (JSC::JITStubs::cti_op_del_by_val):
- (JSC::JITStubs::cti_op_new_error):
- (JSC::JITStubs::cti_vm_throw):
- * jit/JITStubs.h:
- * jsc.cpp:
- (functionPrint):
- (functionDebug):
- (functionGC):
- (functionVersion):
- (functionRun):
- (functionLoad):
- (functionSetSamplingFlag):
- (functionClearSamplingFlag):
- (functionReadline):
- (functionQuit):
- * parser/Nodes.cpp:
- (JSC::processClauseList):
- * profiler/ProfileGenerator.cpp:
- (JSC::ProfileGenerator::addParentForConsoleStart):
- * profiler/Profiler.cpp:
- (JSC::Profiler::willExecute):
- (JSC::Profiler::didExecute):
- (JSC::Profiler::createCallIdentifier):
- * profiler/Profiler.h:
- * runtime/ArgList.cpp:
- (JSC::MarkedArgumentBuffer::slowAppend):
- * runtime/ArgList.h:
- (JSC::MarkedArgumentBuffer::at):
- (JSC::MarkedArgumentBuffer::append):
- (JSC::ArgList::ArgList):
- (JSC::ArgList::at):
- * runtime/Arguments.cpp:
- (JSC::Arguments::put):
- * runtime/Arguments.h:
- (JSC::Arguments::createStructure):
- (JSC::asArguments):
- * runtime/ArrayConstructor.cpp:
- (JSC::callArrayConstructor):
- * runtime/ArrayPrototype.cpp:
- (JSC::getProperty):
- (JSC::putProperty):
- (JSC::arrayProtoFuncToString):
- (JSC::arrayProtoFuncToLocaleString):
- (JSC::arrayProtoFuncJoin):
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncReverse):
- (JSC::arrayProtoFuncShift):
- (JSC::arrayProtoFuncSlice):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncSplice):
- (JSC::arrayProtoFuncUnShift):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncReduce):
- (JSC::arrayProtoFuncReduceRight):
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanConstructor.cpp:
- (JSC::callBooleanConstructor):
- (JSC::constructBooleanFromImmediateBoolean):
- * runtime/BooleanConstructor.h:
- * runtime/BooleanObject.h:
- (JSC::asBooleanObject):
- * runtime/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncToString):
- (JSC::booleanProtoFuncValueOf):
- * runtime/CallData.cpp:
- (JSC::call):
- * runtime/CallData.h:
- * runtime/Collector.cpp:
- (JSC::Heap::protect):
- (JSC::Heap::unprotect):
- (JSC::Heap::heap):
- * runtime/Collector.h:
- * runtime/Completion.cpp:
- (JSC::evaluate):
- * runtime/Completion.h:
- (JSC::Completion::Completion):
- (JSC::Completion::value):
- (JSC::Completion::setValue):
- * runtime/ConstructData.cpp:
- (JSC::construct):
- * runtime/ConstructData.h:
- * runtime/DateConstructor.cpp:
- (JSC::constructDate):
- (JSC::callDate):
- (JSC::dateParse):
- (JSC::dateNow):
- (JSC::dateUTC):
- * runtime/DateInstance.h:
- (JSC::asDateInstance):
- * runtime/DatePrototype.cpp:
- (JSC::dateProtoFuncToString):
- (JSC::dateProtoFuncToUTCString):
- (JSC::dateProtoFuncToDateString):
- (JSC::dateProtoFuncToTimeString):
- (JSC::dateProtoFuncToLocaleString):
- (JSC::dateProtoFuncToLocaleDateString):
- (JSC::dateProtoFuncToLocaleTimeString):
- (JSC::dateProtoFuncGetTime):
- (JSC::dateProtoFuncGetFullYear):
- (JSC::dateProtoFuncGetUTCFullYear):
- (JSC::dateProtoFuncToGMTString):
- (JSC::dateProtoFuncGetMonth):
- (JSC::dateProtoFuncGetUTCMonth):
- (JSC::dateProtoFuncGetDate):
- (JSC::dateProtoFuncGetUTCDate):
- (JSC::dateProtoFuncGetDay):
- (JSC::dateProtoFuncGetUTCDay):
- (JSC::dateProtoFuncGetHours):
- (JSC::dateProtoFuncGetUTCHours):
- (JSC::dateProtoFuncGetMinutes):
- (JSC::dateProtoFuncGetUTCMinutes):
- (JSC::dateProtoFuncGetSeconds):
- (JSC::dateProtoFuncGetUTCSeconds):
- (JSC::dateProtoFuncGetMilliSeconds):
- (JSC::dateProtoFuncGetUTCMilliseconds):
- (JSC::dateProtoFuncGetTimezoneOffset):
- (JSC::dateProtoFuncSetTime):
- (JSC::setNewValueFromTimeArgs):
- (JSC::setNewValueFromDateArgs):
- (JSC::dateProtoFuncSetMilliSeconds):
- (JSC::dateProtoFuncSetUTCMilliseconds):
- (JSC::dateProtoFuncSetSeconds):
- (JSC::dateProtoFuncSetUTCSeconds):
- (JSC::dateProtoFuncSetMinutes):
- (JSC::dateProtoFuncSetUTCMinutes):
- (JSC::dateProtoFuncSetHours):
- (JSC::dateProtoFuncSetUTCHours):
- (JSC::dateProtoFuncSetDate):
- (JSC::dateProtoFuncSetUTCDate):
- (JSC::dateProtoFuncSetMonth):
- (JSC::dateProtoFuncSetUTCMonth):
- (JSC::dateProtoFuncSetFullYear):
- (JSC::dateProtoFuncSetUTCFullYear):
- (JSC::dateProtoFuncSetYear):
- (JSC::dateProtoFuncGetYear):
- * runtime/DatePrototype.h:
- (JSC::DatePrototype::createStructure):
- * runtime/ErrorConstructor.cpp:
- (JSC::callErrorConstructor):
- * runtime/ErrorPrototype.cpp:
- (JSC::errorProtoFuncToString):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createInterruptedExecutionException):
- (JSC::createError):
- (JSC::createStackOverflowError):
- (JSC::createUndefinedVariableError):
- (JSC::createErrorMessage):
- (JSC::createInvalidParamError):
- (JSC::createNotAConstructorError):
- (JSC::createNotAFunctionError):
- * runtime/ExceptionHelpers.h:
- * runtime/FunctionConstructor.cpp:
- (JSC::callFunctionConstructor):
- * runtime/FunctionPrototype.cpp:
- (JSC::callFunctionPrototype):
- (JSC::functionProtoFuncToString):
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall):
- * runtime/FunctionPrototype.h:
- (JSC::FunctionPrototype::createStructure):
- * runtime/GetterSetter.cpp:
- (JSC::GetterSetter::toPrimitive):
- (JSC::GetterSetter::getPrimitiveNumber):
- * runtime/GetterSetter.h:
- (JSC::asGetterSetter):
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::displayName):
- * runtime/InternalFunction.h:
- (JSC::InternalFunction::createStructure):
- (JSC::asInternalFunction):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::getOwnPropertySlot):
- (JSC::JSActivation::put):
- (JSC::JSActivation::putWithAttributes):
- (JSC::JSActivation::argumentsGetter):
- * runtime/JSActivation.h:
- (JSC::JSActivation::createStructure):
- (JSC::asActivation):
- * runtime/JSArray.cpp:
- (JSC::storageSize):
- (JSC::JSArray::JSArray):
- (JSC::JSArray::getOwnPropertySlot):
- (JSC::JSArray::put):
- (JSC::JSArray::putSlowCase):
- (JSC::JSArray::deleteProperty):
- (JSC::JSArray::setLength):
- (JSC::JSArray::pop):
- (JSC::JSArray::push):
- (JSC::JSArray::mark):
- (JSC::compareNumbersForQSort):
- (JSC::JSArray::sortNumeric):
- (JSC::JSArray::sort):
- (JSC::JSArray::compactForSorting):
- (JSC::JSArray::checkConsistency):
- (JSC::constructArray):
- * runtime/JSArray.h:
- (JSC::JSArray::getIndex):
- (JSC::JSArray::setIndex):
- (JSC::JSArray::createStructure):
- (JSC::asArray):
- (JSC::isJSArray):
- * runtime/JSByteArray.cpp:
- (JSC::JSByteArray::createStructure):
- (JSC::JSByteArray::put):
- * runtime/JSByteArray.h:
- (JSC::JSByteArray::getIndex):
- (JSC::JSByteArray::setIndex):
- (JSC::asByteArray):
- (JSC::isJSByteArray):
- * runtime/JSCell.cpp:
- (JSC::JSCell::put):
- (JSC::JSCell::getJSNumber):
- * runtime/JSCell.h:
- (JSC::asCell):
- (JSC::JSValue::asCell):
- (JSC::JSValue::isString):
- (JSC::JSValue::isGetterSetter):
- (JSC::JSValue::isObject):
- (JSC::JSValue::getString):
- (JSC::JSValue::getObject):
- (JSC::JSValue::getCallData):
- (JSC::JSValue::getConstructData):
- (JSC::JSValue::getUInt32):
- (JSC::JSValue::getTruncatedInt32):
- (JSC::JSValue::getTruncatedUInt32):
- (JSC::JSValue::mark):
- (JSC::JSValue::marked):
- (JSC::JSValue::toPrimitive):
- (JSC::JSValue::getPrimitiveNumber):
- (JSC::JSValue::toBoolean):
- (JSC::JSValue::toNumber):
- (JSC::JSValue::toString):
- (JSC::JSValue::toObject):
- (JSC::JSValue::toThisObject):
- (JSC::JSValue::needsThisConversion):
- (JSC::JSValue::toThisString):
- (JSC::JSValue::getJSNumber):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::call):
- (JSC::JSFunction::argumentsGetter):
- (JSC::JSFunction::callerGetter):
- (JSC::JSFunction::lengthGetter):
- (JSC::JSFunction::getOwnPropertySlot):
- (JSC::JSFunction::put):
- (JSC::JSFunction::construct):
- * runtime/JSFunction.h:
- (JSC::JSFunction::createStructure):
- (JSC::asFunction):
- * runtime/JSGlobalData.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::markIfNeeded):
- (JSC::JSGlobalObject::put):
- (JSC::JSGlobalObject::putWithAttributes):
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::resetPrototype):
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::createStructure):
- (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo):
- (JSC::asGlobalObject):
- (JSC::Structure::prototypeForLookup):
- (JSC::Structure::prototypeChain):
- (JSC::Structure::isValid):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::encode):
- (JSC::decode):
- (JSC::globalFuncEval):
- (JSC::globalFuncParseInt):
- (JSC::globalFuncParseFloat):
- (JSC::globalFuncIsNaN):
- (JSC::globalFuncIsFinite):
- (JSC::globalFuncDecodeURI):
- (JSC::globalFuncDecodeURIComponent):
- (JSC::globalFuncEncodeURI):
- (JSC::globalFuncEncodeURIComponent):
- (JSC::globalFuncEscape):
- (JSC::globalFuncUnescape):
- (JSC::globalFuncJSCPrint):
- * runtime/JSGlobalObjectFunctions.h:
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject):
- (JSC::JSImmediate::toObject):
- (JSC::JSImmediate::prototype):
- (JSC::JSImmediate::toString):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::isImmediate):
- (JSC::JSImmediate::isNumber):
- (JSC::JSImmediate::isIntegerNumber):
- (JSC::JSImmediate::isDoubleNumber):
- (JSC::JSImmediate::isPositiveIntegerNumber):
- (JSC::JSImmediate::isBoolean):
- (JSC::JSImmediate::isUndefinedOrNull):
- (JSC::JSImmediate::isEitherImmediate):
- (JSC::JSImmediate::areBothImmediate):
- (JSC::JSImmediate::areBothImmediateIntegerNumbers):
- (JSC::JSImmediate::makeValue):
- (JSC::JSImmediate::makeInt):
- (JSC::JSImmediate::makeDouble):
- (JSC::JSImmediate::makeBool):
- (JSC::JSImmediate::makeUndefined):
- (JSC::JSImmediate::makeNull):
- (JSC::JSImmediate::doubleValue):
- (JSC::JSImmediate::intValue):
- (JSC::JSImmediate::uintValue):
- (JSC::JSImmediate::boolValue):
- (JSC::JSImmediate::rawValue):
- (JSC::JSImmediate::trueImmediate):
- (JSC::JSImmediate::falseImmediate):
- (JSC::JSImmediate::undefinedImmediate):
- (JSC::JSImmediate::nullImmediate):
- (JSC::JSImmediate::zeroImmediate):
- (JSC::JSImmediate::oneImmediate):
- (JSC::JSImmediate::impossibleValue):
- (JSC::JSImmediate::toBoolean):
- (JSC::JSImmediate::getTruncatedUInt32):
- (JSC::JSImmediate::fromNumberOutsideIntegerRange):
- (JSC::JSImmediate::from):
- (JSC::JSImmediate::getTruncatedInt32):
- (JSC::JSImmediate::toDouble):
- (JSC::JSImmediate::getUInt32):
- (JSC::JSValue::JSValue):
- (JSC::JSValue::isUndefinedOrNull):
- (JSC::JSValue::isBoolean):
- (JSC::JSValue::getBoolean):
- (JSC::JSValue::toInt32):
- (JSC::JSValue::toUInt32):
- (JSC::JSValue::isCell):
- (JSC::JSValue::isInt32Fast):
- (JSC::JSValue::getInt32Fast):
- (JSC::JSValue::isUInt32Fast):
- (JSC::JSValue::getUInt32Fast):
- (JSC::JSValue::makeInt32Fast):
- (JSC::JSValue::areBothInt32Fast):
- (JSC::JSFastMath::canDoFastBitwiseOperations):
- (JSC::JSFastMath::equal):
- (JSC::JSFastMath::notEqual):
- (JSC::JSFastMath::andImmediateNumbers):
- (JSC::JSFastMath::xorImmediateNumbers):
- (JSC::JSFastMath::orImmediateNumbers):
- (JSC::JSFastMath::canDoFastRshift):
- (JSC::JSFastMath::canDoFastUrshift):
- (JSC::JSFastMath::rightShiftImmediateNumbers):
- (JSC::JSFastMath::canDoFastAdditiveOperations):
- (JSC::JSFastMath::addImmediateNumbers):
- (JSC::JSFastMath::subImmediateNumbers):
- (JSC::JSFastMath::incImmediateNumber):
- (JSC::JSFastMath::decImmediateNumber):
- * runtime/JSNotAnObject.cpp:
- (JSC::JSNotAnObject::toPrimitive):
- (JSC::JSNotAnObject::getPrimitiveNumber):
- (JSC::JSNotAnObject::put):
- * runtime/JSNotAnObject.h:
- (JSC::JSNotAnObject::createStructure):
- * runtime/JSNumberCell.cpp:
- (JSC::JSNumberCell::toPrimitive):
- (JSC::JSNumberCell::getPrimitiveNumber):
- (JSC::JSNumberCell::getJSNumber):
- (JSC::jsNumberCell):
- * runtime/JSNumberCell.h:
- (JSC::JSNumberCell::createStructure):
- (JSC::isNumberCell):
- (JSC::asNumberCell):
- (JSC::jsNumber):
- (JSC::JSValue::isDoubleNumber):
- (JSC::JSValue::getDoubleNumber):
- (JSC::JSValue::isNumber):
- (JSC::JSValue::uncheckedGetNumber):
- (JSC::jsNaN):
- (JSC::JSValue::toJSNumber):
- (JSC::JSValue::getNumber):
- (JSC::JSValue::numberToInt32):
- (JSC::JSValue::numberToUInt32):
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::put):
- (JSC::JSObject::putWithAttributes):
- (JSC::callDefaultValueFunction):
- (JSC::JSObject::getPrimitiveNumber):
- (JSC::JSObject::defaultValue):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- (JSC::JSObject::lookupGetter):
- (JSC::JSObject::lookupSetter):
- (JSC::JSObject::hasInstance):
- (JSC::JSObject::toNumber):
- (JSC::JSObject::toString):
- (JSC::JSObject::fillGetterPropertySlot):
- * runtime/JSObject.h:
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::offsetForLocation):
- (JSC::JSObject::locationForOffset):
- (JSC::JSObject::getDirectOffset):
- (JSC::JSObject::putDirectOffset):
- (JSC::JSObject::createStructure):
- (JSC::asObject):
- (JSC::JSObject::prototype):
- (JSC::JSObject::setPrototype):
- (JSC::JSValue::isObject):
- (JSC::JSObject::inlineGetOwnPropertySlot):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSObject::getPropertySlot):
- (JSC::JSObject::get):
- (JSC::JSObject::putDirect):
- (JSC::JSObject::putDirectWithoutTransition):
- (JSC::JSObject::toPrimitive):
- (JSC::JSValue::get):
- (JSC::JSValue::put):
- (JSC::JSObject::allocatePropertyStorageInline):
- * runtime/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::toPrimitive):
- (JSC::JSPropertyNameIterator::getPrimitiveNumber):
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::create):
- (JSC::JSPropertyNameIterator::next):
- * runtime/JSStaticScopeObject.cpp:
- (JSC::JSStaticScopeObject::put):
- (JSC::JSStaticScopeObject::putWithAttributes):
- * runtime/JSStaticScopeObject.h:
- (JSC::JSStaticScopeObject::JSStaticScopeObject):
- (JSC::JSStaticScopeObject::createStructure):
- * runtime/JSString.cpp:
- (JSC::JSString::toPrimitive):
- (JSC::JSString::getPrimitiveNumber):
- (JSC::JSString::getOwnPropertySlot):
- * runtime/JSString.h:
- (JSC::JSString::createStructure):
- (JSC::asString):
- (JSC::isJSString):
- (JSC::JSValue::toThisJSString):
- * runtime/JSValue.cpp:
- (JSC::JSValue::toInteger):
- (JSC::JSValue::toIntegerPreserveNaN):
- * runtime/JSValue.h:
- (JSC::JSValue::makeImmediate):
- (JSC::JSValue::asValue):
- (JSC::noValue):
- (JSC::jsImpossibleValue):
- (JSC::jsNull):
- (JSC::jsUndefined):
- (JSC::jsBoolean):
- (JSC::operator==):
- (JSC::operator!=):
- (JSC::JSValue::encode):
- (JSC::JSValue::decode):
- (JSC::JSValue::JSValue):
- (JSC::JSValue::operator bool):
- (JSC::JSValue::operator==):
- (JSC::JSValue::operator!=):
- (JSC::JSValue::isUndefined):
- (JSC::JSValue::isNull):
- * runtime/JSVariableObject.h:
- (JSC::JSVariableObject::symbolTablePut):
- (JSC::JSVariableObject::symbolTablePutWithAttributes):
- * runtime/JSWrapperObject.h:
- (JSC::JSWrapperObject::internalValue):
- (JSC::JSWrapperObject::setInternalValue):
- * runtime/Lookup.cpp:
- (JSC::setUpStaticFunctionSlot):
- * runtime/Lookup.h:
- (JSC::lookupPut):
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncAbs):
- (JSC::mathProtoFuncACos):
- (JSC::mathProtoFuncASin):
- (JSC::mathProtoFuncATan):
- (JSC::mathProtoFuncATan2):
- (JSC::mathProtoFuncCeil):
- (JSC::mathProtoFuncCos):
- (JSC::mathProtoFuncExp):
- (JSC::mathProtoFuncFloor):
- (JSC::mathProtoFuncLog):
- (JSC::mathProtoFuncMax):
- (JSC::mathProtoFuncMin):
- (JSC::mathProtoFuncPow):
- (JSC::mathProtoFuncRandom):
- (JSC::mathProtoFuncRound):
- (JSC::mathProtoFuncSin):
- (JSC::mathProtoFuncSqrt):
- (JSC::mathProtoFuncTan):
- * runtime/MathObject.h:
- (JSC::MathObject::createStructure):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::callNativeErrorConstructor):
- * runtime/NumberConstructor.cpp:
- (JSC::numberConstructorNaNValue):
- (JSC::numberConstructorNegInfinity):
- (JSC::numberConstructorPosInfinity):
- (JSC::numberConstructorMaxValue):
- (JSC::numberConstructorMinValue):
- (JSC::callNumberConstructor):
- * runtime/NumberConstructor.h:
- (JSC::NumberConstructor::createStructure):
- * runtime/NumberObject.cpp:
- (JSC::NumberObject::getJSNumber):
- (JSC::constructNumber):
- * runtime/NumberObject.h:
- * runtime/NumberPrototype.cpp:
- (JSC::numberProtoFuncToString):
- (JSC::numberProtoFuncToLocaleString):
- (JSC::numberProtoFuncValueOf):
- (JSC::numberProtoFuncToFixed):
- (JSC::numberProtoFuncToExponential):
- (JSC::numberProtoFuncToPrecision):
- * runtime/ObjectConstructor.cpp:
- (JSC::constructObject):
- (JSC::callObjectConstructor):
- * runtime/ObjectPrototype.cpp:
- (JSC::objectProtoFuncValueOf):
- (JSC::objectProtoFuncHasOwnProperty):
- (JSC::objectProtoFuncIsPrototypeOf):
- (JSC::objectProtoFuncDefineGetter):
- (JSC::objectProtoFuncDefineSetter):
- (JSC::objectProtoFuncLookupGetter):
- (JSC::objectProtoFuncLookupSetter):
- (JSC::objectProtoFuncPropertyIsEnumerable):
- (JSC::objectProtoFuncToLocaleString):
- (JSC::objectProtoFuncToString):
- * runtime/ObjectPrototype.h:
- * runtime/Operations.cpp:
- (JSC::JSValue::equalSlowCase):
- (JSC::JSValue::strictEqualSlowCase):
- (JSC::throwOutOfMemoryError):
- (JSC::jsAddSlowCase):
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::jsIsFunctionType):
- * runtime/Operations.h:
- (JSC::JSValue::equal):
- (JSC::JSValue::equalSlowCaseInline):
- (JSC::JSValue::strictEqual):
- (JSC::JSValue::strictEqualSlowCaseInline):
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAdd):
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::resolveBase):
- * runtime/PropertySlot.cpp:
- (JSC::PropertySlot::functionGetter):
- * runtime/PropertySlot.h:
- (JSC::PropertySlot::PropertySlot):
- (JSC::PropertySlot::getValue):
- (JSC::PropertySlot::putValue):
- (JSC::PropertySlot::setValueSlot):
- (JSC::PropertySlot::setValue):
- (JSC::PropertySlot::setCustom):
- (JSC::PropertySlot::setCustomIndex):
- (JSC::PropertySlot::slotBase):
- (JSC::PropertySlot::setBase):
- (JSC::PropertySlot::):
- * runtime/Protect.h:
- (JSC::gcProtect):
- (JSC::gcUnprotect):
- (JSC::ProtectedPtr::operator JSValue):
- (JSC::ProtectedJSValue::ProtectedJSValue):
- (JSC::ProtectedJSValue::get):
- (JSC::ProtectedJSValue::operator JSValue):
- (JSC::ProtectedJSValue::operator->):
- (JSC::ProtectedJSValue::~ProtectedJSValue):
- (JSC::ProtectedJSValue::operator=):
- (JSC::operator==):
- (JSC::operator!=):
- * runtime/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::getBackref):
- (JSC::RegExpConstructor::getLastParen):
- (JSC::RegExpConstructor::getLeftContext):
- (JSC::RegExpConstructor::getRightContext):
- (JSC::regExpConstructorDollar1):
- (JSC::regExpConstructorDollar2):
- (JSC::regExpConstructorDollar3):
- (JSC::regExpConstructorDollar4):
- (JSC::regExpConstructorDollar5):
- (JSC::regExpConstructorDollar6):
- (JSC::regExpConstructorDollar7):
- (JSC::regExpConstructorDollar8):
- (JSC::regExpConstructorDollar9):
- (JSC::regExpConstructorInput):
- (JSC::regExpConstructorMultiline):
- (JSC::regExpConstructorLastMatch):
- (JSC::regExpConstructorLastParen):
- (JSC::regExpConstructorLeftContext):
- (JSC::regExpConstructorRightContext):
- (JSC::RegExpConstructor::put):
- (JSC::setRegExpConstructorInput):
- (JSC::setRegExpConstructorMultiline):
- (JSC::constructRegExp):
- (JSC::callRegExpConstructor):
- * runtime/RegExpConstructor.h:
- (JSC::RegExpConstructor::createStructure):
- (JSC::asRegExpConstructor):
- * runtime/RegExpMatchesArray.h:
- (JSC::RegExpMatchesArray::put):
- * runtime/RegExpObject.cpp:
- (JSC::regExpObjectGlobal):
- (JSC::regExpObjectIgnoreCase):
- (JSC::regExpObjectMultiline):
- (JSC::regExpObjectSource):
- (JSC::regExpObjectLastIndex):
- (JSC::RegExpObject::put):
- (JSC::setRegExpObjectLastIndex):
- (JSC::RegExpObject::test):
- (JSC::RegExpObject::exec):
- (JSC::callRegExpObject):
- * runtime/RegExpObject.h:
- (JSC::RegExpObject::createStructure):
- (JSC::asRegExpObject):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncTest):
- (JSC::regExpProtoFuncExec):
- (JSC::regExpProtoFuncCompile):
- (JSC::regExpProtoFuncToString):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCodeSlowCase):
- (JSC::stringFromCharCode):
- (JSC::callStringConstructor):
- * runtime/StringObject.cpp:
- (JSC::StringObject::put):
- * runtime/StringObject.h:
- (JSC::StringObject::createStructure):
- (JSC::asStringObject):
- * runtime/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncToString):
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncIndexOf):
- (JSC::stringProtoFuncLastIndexOf):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- (JSC::stringProtoFuncSlice):
- (JSC::stringProtoFuncSplit):
- (JSC::stringProtoFuncSubstr):
- (JSC::stringProtoFuncSubstring):
- (JSC::stringProtoFuncToLowerCase):
- (JSC::stringProtoFuncToUpperCase):
- (JSC::stringProtoFuncLocaleCompare):
- (JSC::stringProtoFuncBig):
- (JSC::stringProtoFuncSmall):
- (JSC::stringProtoFuncBlink):
- (JSC::stringProtoFuncBold):
- (JSC::stringProtoFuncFixed):
- (JSC::stringProtoFuncItalics):
- (JSC::stringProtoFuncStrike):
- (JSC::stringProtoFuncSub):
- (JSC::stringProtoFuncSup):
- (JSC::stringProtoFuncFontcolor):
- (JSC::stringProtoFuncFontsize):
- (JSC::stringProtoFuncAnchor):
- (JSC::stringProtoFuncLink):
- * runtime/Structure.cpp:
- (JSC::Structure::Structure):
- (JSC::Structure::changePrototypeTransition):
- * runtime/Structure.h:
- (JSC::Structure::create):
- (JSC::Structure::setPrototypeWithoutTransition):
- (JSC::Structure::storedPrototype):
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam "That doesn't look like what I thought it looks like" Weinig.
-
- Beefed up the JSValuePtr class and removed some non-JSValuePtr dependencies
- on JSImmediate, in prepapration for making JSImmediate an implementation
- detail of JSValuePtr.
-
- SunSpider reports no change.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_mod):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt): Updated for interface changes.
-
- * runtime/JSImmediate.h:
- (JSC::JSValuePtr::JSValuePtr):
- * runtime/JSValue.h:
- (JSC::JSValuePtr::):
- (JSC::jsImpossibleValue):
- (JSC::jsNull):
- (JSC::jsUndefined):
- (JSC::jsBoolean):
- (JSC::JSValuePtr::encode):
- (JSC::JSValuePtr::decode):
- (JSC::JSValuePtr::JSValuePtr):
- (JSC::JSValuePtr::operator bool):
- (JSC::JSValuePtr::operator==):
- (JSC::JSValuePtr::operator!=):
- (JSC::JSValuePtr::isUndefined):
- (JSC::JSValuePtr::isNull): Changed jsImpossibleValue(), jsNull(),
- jsUndefined(), and jsBoolean() to operate in terms of JSValuePtr instead
- of JSImmediate.
-
- * wtf/StdLibExtras.h:
- (WTF::bitwise_cast): Fixed up for clarity.
-
-2009-04-30 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug fix for rdar:/6845379. If a case-insensitive regex contains
- a character class containing a range with an upper bound of \uFFFF
- the parser will infinite-loop whist adding other-case characters
- for characters in the range that do have another case.
-
- * yarr/RegexCompiler.cpp:
- (JSC::Yarr::CharacterClassConstructor::putRange):
-
-2009-04-30 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- OPCODE_SAMPLING without CODEBLOCK_SAMPLING is currently broken,
- since SamplingTool::Sample::isNull() checks the m_codeBlock
- member (which is always null without CODEBLOCK_SAMPLING).
-
- Restructure the checks so make this work again.
-
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingTool::doRun):
- * bytecode/SamplingTool.h:
- (JSC::SamplingTool::Sample::isNull):
-
-2009-04-30 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- - Concatenate final three strings in simple replace case at one go
-
- ~0.2% SunSpider speedup
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of
- taking substrings and concatenating three strings.
- * runtime/UString.cpp:
- (JSC::UString::replaceRange): New helper function.
- * runtime/UString.h:
-
-2009-04-30 Geoffrey Garen <ggaren@apple.com>
-
- Rubber Stamped by Gavin Barraclough.
-
- Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
- encoding for JSValuePtrs.
-
- * API/APICast.h:
- (toJS):
* bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
- (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
* interpreter/Register.h:
- (JSC::Register::):
- * jit/JIT.cpp:
- (JSC::):
- * jit/JIT.h:
- * jit/JITCode.h:
- (JSC::):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_add):
- (JSC::JITStubs::cti_op_pre_inc):
- (JSC::JITStubs::cti_op_get_by_id_generic):
- (JSC::JITStubs::cti_op_get_by_id):
- (JSC::JITStubs::cti_op_get_by_id_second):
- (JSC::JITStubs::cti_op_get_by_id_self_fail):
- (JSC::JITStubs::cti_op_get_by_id_proto_list):
- (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
- (JSC::JITStubs::cti_op_get_by_id_proto_fail):
- (JSC::JITStubs::cti_op_get_by_id_array_fail):
- (JSC::JITStubs::cti_op_get_by_id_string_fail):
- (JSC::JITStubs::cti_op_instanceof):
- (JSC::JITStubs::cti_op_del_by_id):
- (JSC::JITStubs::cti_op_mul):
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_resolve):
- (JSC::JITStubs::cti_op_construct_NotJSConstruct):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_string):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_sub):
- (JSC::JITStubs::cti_op_lesseq):
- (JSC::JITStubs::cti_op_negate):
- (JSC::JITStubs::cti_op_resolve_base):
- (JSC::JITStubs::cti_op_resolve_skip):
- (JSC::JITStubs::cti_op_resolve_global):
- (JSC::JITStubs::cti_op_div):
- (JSC::JITStubs::cti_op_pre_dec):
- (JSC::JITStubs::cti_op_not):
- (JSC::JITStubs::cti_op_eq):
- (JSC::JITStubs::cti_op_lshift):
- (JSC::JITStubs::cti_op_bitand):
- (JSC::JITStubs::cti_op_rshift):
- (JSC::JITStubs::cti_op_bitnot):
- (JSC::JITStubs::cti_op_mod):
- (JSC::JITStubs::cti_op_less):
- (JSC::JITStubs::cti_op_neq):
- (JSC::JITStubs::cti_op_urshift):
- (JSC::JITStubs::cti_op_bitxor):
- (JSC::JITStubs::cti_op_bitor):
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_op_throw):
- (JSC::JITStubs::cti_op_next_pname):
- (JSC::JITStubs::cti_op_typeof):
- (JSC::JITStubs::cti_op_is_undefined):
- (JSC::JITStubs::cti_op_is_boolean):
- (JSC::JITStubs::cti_op_is_number):
- (JSC::JITStubs::cti_op_is_string):
- (JSC::JITStubs::cti_op_is_object):
- (JSC::JITStubs::cti_op_is_function):
- (JSC::JITStubs::cti_op_stricteq):
- (JSC::JITStubs::cti_op_nstricteq):
- (JSC::JITStubs::cti_op_to_jsnumber):
- (JSC::JITStubs::cti_op_in):
- (JSC::JITStubs::cti_op_del_by_val):
- (JSC::JITStubs::cti_vm_throw):
- * jit/JITStubs.h:
- * runtime/JSValue.h:
- (JSC::JSValuePtr::encode):
- (JSC::JSValuePtr::decode):
-
-2009-04-30 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver "Abandon Ship!" Hunt.
-
- Fix a leak in Yarr.
-
- All Disjunctions should be recorded in RegexPattern::m_disjunctions,
- so that they can be freed at the end of compilation - copyDisjunction
- is failing to do so.
-
- * yarr/RegexCompiler.cpp:
- (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
-
-2009-04-30 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Add function to CallFrame for dumping the current JS caller
-
- Added debug only method CallFrame::dumpCaller() that provide the call location
- of the deepest currently executing JS function.
-
- * interpreter/CallFrame.cpp:
- (JSC::CallFrame::dumpCaller):
- * interpreter/CallFrame.h:
-
-2009-04-30 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Geoff Garen.
-
- - make BaseStrings have themselves as a base, instead of nothing, to remove common branches
-
- ~0.7% SunSpider speedup
-
- * runtime/UString.h:
- (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null.
- (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.
-
-2009-04-30 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Two quick improvements to SamplingFlags mechanism.
-
- SamplingFlags::ScopedFlag class to provide support for automagically
- clearing a flag as it goes out of scope, and add a little more detail
- to the output generated by the tool.
-
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingFlags::stop):
- * bytecode/SamplingTool.h:
- (JSC::SamplingFlags::ScopedFlag::ScopedFlag):
- (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):
-
-2009-04-30 Adam Roben <aroben@apple.com>
-
- Restore build event steps that were truncated in r43082
-
- Rubber-stamped by Steve Falkenburg.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
- Re-copied the command lines for the build events from the pre-r43082
- .vcproj files.
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary
- attribute.
-
-2009-04-30 Adam Roben <aroben@apple.com>
-
- Move settings from .vcproj files to .vsprops files within the
- JavaScriptCore directory
-
- Moving the settings to a .vsprops file means that we will only have to
- change a single setting to affect all configurations, instead of one
- setting per configuration.
-
- Reviewed by Steve Falkenburg.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.vcproj/testapi/testapi.vcproj:
- Moved settings from these files to the new .vsprops files. Note that
- testapi.vcproj had a lot of overrides of default settings that were
- the same as the defaults, which I've removed.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added.
- * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added.
- * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added.
- * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25470
- Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
-
- * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
-
-2009-04-30 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- - speed up string concatenation by reorganizing some simple cases
- 0.7% SunSpider speedup
-
- * runtime/UString.cpp:
- (JSC::concatenate): Put fast case for appending a single character
- before the empty string special cases; streamline code a bit to
- delay computing values that are not needed in the fast path.
-
-2009-04-30 Gavin Barraclough <barraclough@apple.com>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
-
- Add SamplingFlags mechanism.
-
- This mechanism allows fine-grained JSC and JavaScript program aware
- performance measurement. The mechanism provides a set of 32 flags,
- numbered #1..#32. Flag #16 is initially set, and all other flags
- are cleared. Flags may be set and cleared from within
-
- Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
- Disabled by default, no performance impact. Flags may be modified
- by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
- from within JSC implementation, or by calling setSamplingFlag() and
- clearSamplingFlag() from JavaScript.
-
- The flags are sampled with a frequency of 10000Hz, and the highest
- set flag in recorded, allowing multiple events to be measured (with
- the highest flag number representing the highest priority).
-
- Disabled by default; no performance impact.
-
- * JavaScriptCore.exp:
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingFlags::sample):
- (JSC::SamplingFlags::start):
- (JSC::SamplingFlags::stop):
- (JSC::SamplingThread::threadStartFunc):
- (JSC::SamplingThread::start):
- (JSC::SamplingThread::stop):
- (JSC::ScopeSampleRecord::sample):
- (JSC::SamplingTool::doRun):
- (JSC::SamplingTool::sample):
- (JSC::SamplingTool::start):
- (JSC::SamplingTool::stop):
- * bytecode/SamplingTool.h:
- (JSC::SamplingFlags::setFlag):
- (JSC::SamplingFlags::clearFlag):
- (JSC::SamplingTool::SamplingTool):
- * jsc.cpp:
- (GlobalObject::GlobalObject):
- (functionSetSamplingFlag):
- (functionClearSamplingFlag):
- (runWithScripts):
- * wtf/Platform.h:
-
-2009-04-29 Sam Weinig <sam@webkit.org>
-
- Another attempt to fix the windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-04-29 Sam Weinig <sam@webkit.org>
-
- Try and fix the windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-04-29 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver "Peg-Leg" Hunt.
-
- Coallesce input checking and reduce futzing with the index position
- between alternatives and iterations of the main loop of a regex,
- when run in YARR.
-
- Consider the following regex: /foo|bar/
-
- Prior to this patch, this will be implemented something like this pseudo-code description:
- loop:
- check_for_available_input(3) // this increments the index by 3, for the first alterantive.
- if (available) { test "foo" }
- decrement_index(3)
- check_for_available_input(3) // this increments the index by 3, for the second alterantive.
- if (available) { test "bar" }
- decrement_index(3)
- check_for_available_input(1) // can we loop again?
- if (available) { goto loop }
-
- With these changes it will look more like this:
-
- check_for_available_input(3) // this increments the index by 3, for the first alterantive.
- if (!available) { goto fail }
- loop:
- test "foo"
- test "bar"
- check_for_available_input(1) // can we loop again?
- if (available) { goto loop }
- fail:
-
-
- This gives about a 5% gain on v8-regex, no change on Sunspider.
-
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo):
- (JSC::Yarr::RegexGenerator::generateDisjunction):
-
-2009-04-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Clean up ArgList to be a trivial type
-
- Separate out old ArgList logic to handle buffering and marking arguments
- into a distinct MarkedArgumentBuffer type. ArgList becomes a trivial
- struct of a pointer and length.
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunction):
- (JSObjectMakeArray):
- (JSObjectMakeDate):
- (JSObjectMakeError):
- (JSObjectMakeRegExp):
- (JSObjectCallAsFunction):
- (JSObjectCallAsConstructor):
- * JavaScriptCore.exp:
- * interpreter/CallFrame.h:
- (JSC::ExecState::emptyList):
- * runtime/ArgList.cpp:
- (JSC::ArgList::getSlice):
- (JSC::MarkedArgumentBuffer::markLists):
- (JSC::MarkedArgumentBuffer::slowAppend):
- * runtime/ArgList.h:
- (JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
- (JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
- (JSC::ArgList::ArgList):
- (JSC::ArgList::at):
- (JSC::ArgList::isEmpty):
- (JSC::ArgList::size):
- (JSC::ArgList::begin):
- (JSC::ArgList::end):
- * runtime/Arguments.cpp:
- (JSC::Arguments::fillArgList):
- * runtime/Arguments.h:
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncReduce):
- (JSC::arrayProtoFuncReduceRight):
- * runtime/Collector.cpp:
- (JSC::Heap::collect):
- * runtime/Collector.h:
- (JSC::Heap::markListSet):
- * runtime/CommonIdentifiers.h:
- * runtime/Error.cpp:
- (JSC::Error::create):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- * runtime/JSArray.cpp:
- (JSC::JSArray::JSArray):
- (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
- (JSC::JSArray::fillArgList):
- (JSC::constructArray):
- * runtime/JSArray.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSGlobalData.h:
- * runtime/JSObject.cpp:
- (JSC::JSObject::put):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCodeSlowCase):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncMatch):
-
-2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25334
-
- Fix Qt build when ENABLE_JIT is explicitly set to 1
- to overrule defaults.
-
- * JavaScriptCore.pri:
+ https://bugs.webkit.org/show_bug.cgi?id=26677
-2009-04-29 Oliver Hunt <oliver@apple.com>
+ Inherits CodeBlock class from FastAllocBase because it
+ has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.
- Reviewed by Steve Falkenburg.
-
- Crash in profiler due to incorrect assuming displayName would be a string.
-
- Fixed by adding a type guard.
-
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::displayName):
-
-2009-04-28 Geoffrey Garen <ggaren@apple.com>
-
- Rubber stamped by Beth Dakin.
-
- Removed scaffolding supporting dynamically converting between 32bit and
- 64bit value representations.
-
- * API/JSCallbackConstructor.cpp:
- (JSC::constructJSCallback):
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::construct):
- (JSC::::call):
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
- (JSC::CodeBlock::getConstant):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitEqualityOp):
- * interpreter/CallFrame.cpp:
- (JSC::CallFrame::thisValue):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::createExceptionScope):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- * interpreter/Register.h:
- (JSC::Register::):
- (JSC::Register::Register):
- (JSC::Register::jsValue):
- (JSC::Register::marked):
- (JSC::Register::mark):
- (JSC::Register::i):
- (JSC::Register::activation):
- (JSC::Register::arguments):
- (JSC::Register::callFrame):
- (JSC::Register::codeBlock):
- (JSC::Register::function):
- (JSC::Register::propertyNameIterator):
- (JSC::Register::scopeChain):
- (JSC::Register::vPC):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_load_varargs):
- (JSC::JITStubs::cti_op_call_eval):
- * jsc.cpp:
- (functionPrint):
- (functionDebug):
- (functionRun):
- (functionLoad):
- * runtime/ArgList.h:
- (JSC::ArgList::at):
- * runtime/Arguments.cpp:
- (JSC::Arguments::copyToRegisters):
- (JSC::Arguments::fillArgList):
- (JSC::Arguments::getOwnPropertySlot):
- * runtime/ArrayConstructor.cpp:
- (JSC::constructArrayWithSizeQuirk):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncJoin):
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncSlice):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncSplice):
- (JSC::arrayProtoFuncUnShift):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncReduce):
- (JSC::arrayProtoFuncReduceRight):
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanConstructor.cpp:
- (JSC::constructBoolean):
- (JSC::callBooleanConstructor):
- * runtime/DateConstructor.cpp:
- (JSC::constructDate):
- (JSC::dateParse):
- (JSC::dateUTC):
- * runtime/DatePrototype.cpp:
- (JSC::formatLocaleDate):
- (JSC::fillStructuresUsingTimeArgs):
- (JSC::fillStructuresUsingDateArgs):
- (JSC::dateProtoFuncSetTime):
- (JSC::dateProtoFuncSetYear):
- * runtime/ErrorConstructor.cpp:
- (JSC::constructError):
- * runtime/FunctionConstructor.cpp:
- (JSC::constructFunction):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall):
- * runtime/JSArray.cpp:
- (JSC::JSArray::JSArray):
- (JSC::constructArray):
- * runtime/JSArray.h:
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::encode):
- (JSC::decode):
- (JSC::globalFuncEval):
- (JSC::globalFuncParseInt):
- (JSC::globalFuncParseFloat):
- (JSC::globalFuncIsNaN):
- (JSC::globalFuncIsFinite):
- (JSC::globalFuncEscape):
- (JSC::globalFuncUnescape):
- (JSC::globalFuncJSCPrint):
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncAbs):
- (JSC::mathProtoFuncACos):
- (JSC::mathProtoFuncASin):
- (JSC::mathProtoFuncATan):
- (JSC::mathProtoFuncATan2):
- (JSC::mathProtoFuncCeil):
- (JSC::mathProtoFuncCos):
- (JSC::mathProtoFuncExp):
- (JSC::mathProtoFuncFloor):
- (JSC::mathProtoFuncLog):
- (JSC::mathProtoFuncMax):
- (JSC::mathProtoFuncMin):
- (JSC::mathProtoFuncPow):
- (JSC::mathProtoFuncRound):
- (JSC::mathProtoFuncSin):
- (JSC::mathProtoFuncSqrt):
- (JSC::mathProtoFuncTan):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::construct):
- * runtime/NumberConstructor.cpp:
- (JSC::constructWithNumberConstructor):
- (JSC::callNumberConstructor):
- * runtime/NumberPrototype.cpp:
- (JSC::numberProtoFuncToString):
- (JSC::numberProtoFuncToFixed):
- (JSC::numberProtoFuncToExponential):
- (JSC::numberProtoFuncToPrecision):
- * runtime/ObjectConstructor.cpp:
- (JSC::constructObject):
- * runtime/ObjectPrototype.cpp:
- (JSC::objectProtoFuncHasOwnProperty):
- (JSC::objectProtoFuncIsPrototypeOf):
- (JSC::objectProtoFuncDefineGetter):
- (JSC::objectProtoFuncDefineSetter):
- (JSC::objectProtoFuncLookupGetter):
- (JSC::objectProtoFuncLookupSetter):
- (JSC::objectProtoFuncPropertyIsEnumerable):
- * runtime/PropertySlot.h:
- (JSC::PropertySlot::getValue):
- * runtime/RegExpConstructor.cpp:
- (JSC::constructRegExp):
- * runtime/RegExpObject.cpp:
- (JSC::RegExpObject::match):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncCompile):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCodeSlowCase):
- (JSC::stringFromCharCode):
- (JSC::constructWithStringConstructor):
- (JSC::callStringConstructor):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncIndexOf):
- (JSC::stringProtoFuncLastIndexOf):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- (JSC::stringProtoFuncSlice):
- (JSC::stringProtoFuncSplit):
- (JSC::stringProtoFuncSubstr):
- (JSC::stringProtoFuncSubstring):
- (JSC::stringProtoFuncLocaleCompare):
- (JSC::stringProtoFuncFontcolor):
- (JSC::stringProtoFuncFontsize):
- (JSC::stringProtoFuncAnchor):
- (JSC::stringProtoFuncLink):
-
-2009-04-28 David Kilzer <ddkilzer@apple.com>
-
- A little more hardening for UString
-
- Reviewed by Maciej Stachowiak.
-
- Revised fix for <rdar://problem/5861045> in r42644.
-
- * runtime/UString.cpp:
- (JSC::newCapacityWithOverflowCheck): Added.
- (JSC::concatenate): Used newCapacityWithOverflowCheck().
- (JSC::UString::append): Ditto.
-
-2009-04-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bring back r42969, this time with correct codegen
- Add logic to the codegen for right shift to avoid jumping to a helper function
- when shifting a small floating point value.
-
- * jit/JITArithmetic.cpp:
- (isSSE2Present):
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
-
-2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
-
- wxMSW build fix. Switch JSCore build back to static.
-
- * API/JSBase.h:
- * config.h:
- * jscore.bkl:
-
-2009-04-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Roll out r42969, due to hangs in build bot.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- (JSC::isSSE2Present):
-
-2009-04-28 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed: fix distcheck build, add (even more) missing files to list.
-
- * GNUmakefile.am:
-
-2009-04-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Improve performance of string indexing
-
- Add a cti_get_by_val_string function to specialise indexing into a string object.
- This gives us a slight performance win on a number of string tests.
-
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_string):
- * jit/JITStubs.h:
-
-2009-04-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Improve performance of right shifts of large or otherwise floating point values.
-
- Add logic to the codegen for right shift to avoid jumping to a helper function
- when shifting a small floating point value.
-
- * jit/JITArithmetic.cpp:
- (isSSE2Present): Moved to the head of file.
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
-
-2009-04-28 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed: fix distcheck build, add (more) missing files to list.
-
- * GNUmakefile.am:
-
-2009-04-28 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed: fix distcheck build, add missing header to file list.
-
- * GNUmakefile.am:
-
-2009-04-28 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Maciej "Henry Morgan" Stachowiak.
-
- Enable YARR.
- (Again.)
-
- * wtf/Platform.h:
-
-2009-04-27 Gavin Barraclough <barraclough@apple.com>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
-
- Tweak a loop condition to keep GCC happy,
- some GCCs seem to be having issues with this. :-/
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::breakTarget):
- * wtf/Platform.h:
-
-2009-04-27 Adam Roben <aroben@apple.com>
-
- Windows Debug build fix
-
- Not sure why the buildbots weren't affected by this problem.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS
- re-order the file list, and added JavaScriptCore[_debug].def to the
- project. This was not necessary for the fix, but made making the fix
- easier.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- Removed a function that no longer exists.
-
-2009-04-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Weinig Sam.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25416
- "Cached prototype accesses unsafely hoist property storage load above structure checks."
- Do not hoist the load of the pointer to the property storage array.
-
- No performance impact.
-
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
-
-2009-04-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoffrey "Gaffe or energy?" Garen.
-
- Randomize address requested by ExecutableAllocatorFixedVMPool.
-
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
-
-2009-04-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Remove scons-based build system.
-
- * JavaScriptCore.scons: Removed.
-
-2009-04-25 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Buildfix).
-
- Make HAVE_MADV_FREE darwin only for now
-
- * wtf/Platform.h:
-
-2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Gtk build fix - check if we have MADV_FREE before using it.
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::releaseExcessCapacity):
- * wtf/Platform.h:
-
-2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Switching JSCore from a static lib to a dynamic lib
- to match the Apple build and fix symbol exports.
-
- * jscore.bkl:
-
-2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Rubber-stamped by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25337
- Move ThreadingQt.cpp under the qt directory.
-
- * JavaScriptCore.pri:
- * wtf/ThreadingQt.cpp: Removed.
- * wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.
-
-2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Rubber-stamped by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25338
- Move ThreadingGtk.cpp under the gtk directory.
-
- * GNUmakefile.am:
- * wtf/ThreadingGtk.cpp: Removed.
- * wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
-
-2009-04-24 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam "Wesley" Weinig.
-
- Improve performance to YARR interpreter.
- (From about 3x slower than PCRE on regex-dna to about 30% slower).
-
- * yarr/RegexCompiler.cpp:
- (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- * yarr/RegexInterpreter.cpp:
- (JSC::Yarr::Interpreter::checkCharacter):
- (JSC::Yarr::Interpreter::checkCasedCharacter):
- (JSC::Yarr::Interpreter::backtrackPatternCharacter):
- (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
- (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
- (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
- (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
- (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
- (JSC::Yarr::Interpreter::matchDisjunction):
- (JSC::Yarr::Interpreter::interpret):
- (JSC::Yarr::ByteCompiler::atomPatternCharacter):
- (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
- (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
- (JSC::Yarr::ByteCompiler::closeAlternative):
- (JSC::Yarr::ByteCompiler::closeBodyAlternative):
- (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
- (JSC::Yarr::ByteCompiler::regexBegin):
- (JSC::Yarr::ByteCompiler::regexEnd):
- (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
- (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
- (JSC::Yarr::ByteCompiler::emitDisjunction):
- * yarr/RegexInterpreter.h:
- (JSC::Yarr::ByteTerm::):
- (JSC::Yarr::ByteTerm::ByteTerm):
- (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
- (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
- (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
- (JSC::Yarr::ByteTerm::AlternativeBegin):
- (JSC::Yarr::ByteTerm::AlternativeDisjunction):
- (JSC::Yarr::ByteTerm::AlternativeEnd):
- (JSC::Yarr::ByteTerm::SubpatternBegin):
- (JSC::Yarr::ByteTerm::SubpatternEnd):
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
- * yarr/RegexPattern.h:
-
-2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com>
-
- Rubber-stamped by Mark Rowe.
-
- * wtf/CurrentTime.h: Fix a typo in a comment.
-
-2009-04-24 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Add reinterpret_cast
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::releaseExcessCapacity):
-
-2009-04-23 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- <rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion
-
- We now track the maximum extent of the RegisterFile, and when we reach the final
- return from JS (so the stack portion of the registerfile becomes empty) we see
- if that extent is greater than maxExcessCapacity. If it is we use madvise or
- VirtualFree to release the physical pages that were backing the excess.
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::releaseExcessCapacity):
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- (JSC::RegisterFile::shrink):
- (JSC::RegisterFile::grow):
-
-2009-04-23 Mark Rowe <mrowe@apple.com>
-
- With great sadness and a heavy heart I switch us back from YARR to WREC in
- order to restore greenness to the world once more.
-
- * wtf/Platform.h:
-
-2009-04-23 Mark Rowe <mrowe@apple.com>
-
- More Windows build fixage.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-
-2009-04-23 Mark Rowe <mrowe@apple.com>
-
- Attempt to fix the Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove a symbol that no longer exists.
-
-2009-04-23 Francisco Tolmasky <francisco@280north.com>
-
- BUG 24604: WebKit profiler reports incorrect total times
- <https://bugs.webkit.org/show_bug.cgi?id=24604>
-
- Reviewed by Timothy Hatcher and Kevin McCullough.
-
- * JavaScriptCore.exp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * profiler/CallIdentifier.h:
- (JSC::CallIdentifier::Hash::hash):
- (JSC::CallIdentifier::Hash::equal):
- (JSC::CallIdentifier::hash):
- (WTF::):
- * profiler/HeavyProfile.cpp: Removed.
- * profiler/HeavyProfile.h: Removed.
- * profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile
- (JSC::Profile::create):
- * profiler/Profile.h:
- * profiler/ProfileNode.cpp:
- * profiler/ProfileNode.h:
- * profiler/TreeProfile.cpp: Removed.
- * profiler/TreeProfile.h: Removed.
-
-2009-04-23 Gavin Barraclough <barraclough@apple.com>
-
- Not Reviewed.
-
- Speculative Windows build fix II.
-
- * yarr/RegexInterpreter.cpp:
-
-2009-04-23 Gavin Barraclough <barraclough@apple.com>
-
- Not Reviewed.
-
- Speculative Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * runtime/RegExp.cpp:
-
-2009-04-23 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by salty sea dogs Sam & Geoff.
-
- Enable YARR_JIT by default (where supported), replacing WREC.
-
- * wtf/Platform.h:
-
-2009-04-23 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff "Dread Pirate Roberts" Garen.
-
- Various small fixes to YARR JIT, in preparation for enabling it by default.
-
- * Correctly index into the callframe when storing restart addresses for
- nested alternatives.
- * Allow backtracking back into matched alternatives of parentheses.
- * Fix callframe offset calculation for parenthetical assertions.
- * When a set of parenthese are quantified with a fixed and variable portion,
- and the variable portion is quantified once, this should not reset the
- pattern match on failure to match (the last match from the firxed portion
- should be preserved).
- * Up the pattern size limit to match PCRE's new limit.
- * Unlclosed parentheses should be reported with the message "missing )".
-
- * wtf/Platform.h:
- * yarr/RegexCompiler.cpp:
- (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
- (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- * yarr/RegexInterpreter.cpp:
- (JSC::Yarr::Interpreter::matchParentheses):
- (JSC::Yarr::Interpreter::backtrackParentheses):
- (JSC::Yarr::ByteCompiler::emitDisjunction):
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
- (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
- (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
- (JSC::Yarr::RegexGenerator::generateTerm):
- (JSC::Yarr::executeRegex):
- * yarr/RegexParser.h:
- (JSC::Yarr::Parser::):
- (JSC::Yarr::Parser::parseTokens):
- (JSC::Yarr::Parser::parse):
- * yarr/RegexPattern.h:
- (JSC::Yarr::PatternTerm::):
- (JSC::Yarr::PatternTerm::PatternTerm):
-
-2009-04-22 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Gavin Barraclough.
-
- Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments.
-
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::addToFreeList):
- (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- (JSC::FixedVMPoolAllocator::alloc):
- (JSC::FixedVMPoolAllocator::free):
- (JSC::FixedVMPoolAllocator::isWithinVMPool):
-
-2009-04-22 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Gavin Barraclough.
-
- Add some assertions to FixedVMPoolAllocator to guard against cases where we
- attempt to free memory that didn't originate from the pool, or we attempt to
- hand out a bogus address from alloc.
-
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::release):
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- (JSC::FixedVMPoolAllocator::alloc):
- (JSC::FixedVMPoolAllocator::free):
- (JSC::FixedVMPoolAllocator::isWithinVMPool):
-
-2009-04-22 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Sam "Blackbeard" Weinig.
-
- Although pirates do spell the word 'generate' as 'genertate',
- webkit developers do not. Fixertate.
-
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::generateAssertionBOL):
- (JSC::Yarr::RegexGenerator::generateAssertionEOL):
- (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary):
- (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle):
- (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
- (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed):
- (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
- (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
- (JSC::Yarr::RegexGenerator::generateCharacterClassSingle):
- (JSC::Yarr::RegexGenerator::generateCharacterClassFixed):
- (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
- (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy):
- (JSC::Yarr::RegexGenerator::generateTerm):
-
-2009-04-22 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam "Blackbeard" Weinig.
-
- Improvements to YARR JIT. This patch expands support in three key areas:
- * Add (temporary) support for falling back to PCRE for expressions not supported.
- * Add support for x86_64 and Windows.
- * Add support for singly quantified parentheses (? and ??), alternatives within
- parentheses, and parenthetical assertions.
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::match):
- * yarr/RegexJIT.cpp:
- (JSC::Yarr::RegexGenerator::storeToFrame):
- (JSC::Yarr::RegexGenerator::storeToFrameWithPatch):
- (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
- (JSC::Yarr::RegexGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
- (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
- (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm):
- (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
- (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
- (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump):
- (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks):
- (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom):
- (JSC::Yarr::RegexGenerator::genertateAssertionBOL):
- (JSC::Yarr::RegexGenerator::genertateAssertionEOL):
- (JSC::Yarr::RegexGenerator::matchAssertionWordchar):
- (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy):
- (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
- (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
- (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
- (JSC::Yarr::RegexGenerator::generateTerm):
- (JSC::Yarr::RegexGenerator::generateDisjunction):
- (JSC::Yarr::RegexGenerator::generateEnter):
- (JSC::Yarr::RegexGenerator::generateReturn):
- (JSC::Yarr::RegexGenerator::RegexGenerator):
- (JSC::Yarr::RegexGenerator::generate):
- (JSC::Yarr::RegexGenerator::compile):
- (JSC::Yarr::RegexGenerator::generationFailed):
- (JSC::Yarr::jitCompileRegex):
- (JSC::Yarr::executeRegex):
- * yarr/RegexJIT.h:
- (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
- (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
-
-2009-04-22 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Darin Adler.
-
- Fix for <rdar://problem/6816957>
- Turn off Geolocation by default
-
- * Configurations/FeatureDefines.xcconfig:
-
-2009-04-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Buildfix).
-
- * interpreter/CachedCall.h:
-
-2009-04-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- * runtime/StringPrototype.cpp:
-
-2009-04-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Improve String.replace performance slightly
-
- Apply our vm reentry caching logic to String.replace with global
- regexes.
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
-
-2009-04-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich and Oliver Hunt.
-
- Re-Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
- fast/workers/use-machine-stack.html (22531)
-
- SunSpider reports no change.
-
- Use a larger recursion limit on the main thread (because we can, and
- there's some evidence that it may improve compatibility), and a smaller
- recursion limit on secondary threads (because they tend to have smaller
- stacks).
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute):
- (JSC::Interpreter::prepareForRepeatCall):
- * interpreter/Interpreter.h:
- (JSC::): Ditto. I wrote the recursion test slightly funny, so that the
- common case remains a simple compare to constant.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncToString):
- (JSC::arrayProtoFuncToLocaleString):
- (JSC::arrayProtoFuncJoin): Conservatively, set the array recursion limits
- to the lower, secondary thread limit. We can do something fancier if
- compatibility moves us, but this seems sufficient for now.
-
-2009-04-21 Geoffrey Garen <ggaren@apple.com>
-
- Rubber-stamped by Adam Roben.
-
- Disabled one more Mozilla JS test because it fails intermittently on Windows.
- (See https://bugs.webkit.org/show_bug.cgi?id=25160.)
-
- * tests/mozilla/expected.html:
-
-2009-04-21 Adam Roben <aroben@apple.com>
-
- Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
- configuration
-
- This matches the naming scheme for WebKit.dll, and will be necessary
- once Safari links against JavaScriptCore.dll. This change also causes
- run-safari not to fail (because the launcher printed by FindSafari was
- always looking for JavaScriptCore.dll, never
- JavaScriptCore_debug.dll).
-
- Part of Bug 25305: can't run safari or drt on windows
- <https://bugs.webkit.org/show_bug.cgi?id=25305>
-
- Reviewed by Steve Falkenburg and Sam Weinig.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.vcproj/testapi/testapi.vcproj:
- Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
-
-2009-04-21 Adam Roben <aroben@apple.com>
-
- Fix JavaScriptCore build on VC++ Express
-
- Reviewed by Steve Falkenburg and Sam Weinig.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Link
- explicitly against gdi32.lib and oleaut32.lib.
-
-2009-04-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Mark Rowe.
-
- Tiger crash fix: Put VM tags in their own header file, and fixed up the
- #ifdefs so they're not used on Tiger.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- * jit/ExecutableAllocatorPosix.cpp:
- (JSC::ExecutablePool::systemAlloc):
- * runtime/Collector.cpp:
- (JSC::allocateBlock):
- * wtf/VMTags.h: Added.
-
-2009-04-20 Steve Falkenburg <sfalken@apple.com>
-
- More Windows build fixes.
-
- * JavaScriptCore.vcproj/JavaScriptCore.make: Copy DLLs, PDBs.
- * JavaScriptCore.vcproj/JavaScriptCore.resources: Added.
- * JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist: Added.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Added.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add version stamping, resource copying.
-
-2009-04-20 Steve Falkenburg <sfalken@apple.com>
-
- Separate JavaScriptCore.dll from WebKit.dll.
- Slight performance improvement or no change on benchmarks.
-
- Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
- and simplifies standalone JavaScriptCore builds.
-
- Reviewed by Oliver Hunt.
-
- * API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
- * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
- * runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
- * runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
- * runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
- * runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
- * runtime/UString.h: Specify JS_EXPORTDATA on exported data.
+ https://bugs.webkit.org/show_bug.cgi?id=26676
-2009-04-20 Sam Weinig <sam@webkit.org>
+ Inherits BytecodeGenerator class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.
- Reviewed by Kevin McCullough.
-
- Always tag mmaped memory on darwin and clean up #defines
- now that they are a little bigger.
-
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- * jit/ExecutableAllocatorPosix.cpp:
- (JSC::ExecutablePool::systemAlloc):
- * runtime/Collector.cpp:
- (JSC::allocateBlock):
-
-2009-04-20 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Tim Hatcher.
-
- Add licenses for xcconfig files.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
- * Configurations/FeatureDefines.xcconfig:
- * Configurations/JavaScriptCore.xcconfig:
- * Configurations/Version.xcconfig:
-
-2009-04-20 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Build fix for Qt port (after r42646). Not reviewed.
-
- * wtf/unicode/qt4/UnicodeQt4.h: Added U16_PREV.
-
-2009-04-19 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Better fix for JSStringCreateWithCFString hardening.
-
- * API/JSStringRefCF.cpp:
- (JSStringCreateWithCFString):
-
-2009-04-19 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/5860954>
- Harden JSStringCreateWithCFString against malformed CFStringRefs.
-
- * API/JSStringRefCF.cpp:
- (JSStringCreateWithCFString):
-
-2009-04-19 David Kilzer <ddkilzer@apple.com>
-
- Make FEATURE_DEFINES completely dynamic
-
- Reviewed by Darin Adler.
-
- Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
- variables for each feature, making it possible to remove all
- knowledge of FEATURE_DEFINES from build-webkit.
-
- * Configurations/FeatureDefines.xcconfig: Extract a variable
- from FEATURE_DEFINES for each feature setting.
-
-2009-04-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix typo. s/VM_MEMORY_JAVASCRIPT_JIT_REGISTER_FILE/VM_MEMORY_JAVASCRIPT_CORE/
-
- * runtime/Collector.cpp:
- (JSC::allocateBlock): Fix bozo typo.
-
-2009-04-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for <rdar://problem/6801555> Tag JavaScript memory on SnowLeopard
-
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- * jit/ExecutableAllocatorFixedVMPool.cpp:
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- * jit/ExecutableAllocatorPosix.cpp:
- (JSC::ExecutablePool::systemAlloc):
- * runtime/Collector.cpp:
- (JSC::allocateBlock):
-
-2009-04-18 Drew Wilson <amw@apple.com>
-
- <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
-
- Reviewed by Dan Bernstein.
-
- * wtf/unicode/icu/UnicodeIcu.h:
- (WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic): Added.
-
-2009-04-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix for <rdar://problem/5861045>
- A little bit of hardening for UString.
-
- * runtime/UString.cpp:
- (JSC::concatenate):
- (JSC::UString::append):
-
-2009-04-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe and Dan Bernstein.
-
- Fix for <rdar://problem/5861188>
- A little bit of hardening for Vector.
-
- * wtf/Vector.h:
- (WTF::Vector<T, inlineCapacity>::append):
- (WTF::Vector<T, inlineCapacity>::insert):
-
-2009-04-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- On x86_64, make all JIT-code allocations from a new heap, managed
- by FixedVMPoolAllocator. This class allocates a single large (2Gb)
- pool of virtual memory from which all further allocations take place.
- Since all JIT code is allocated from this pool, we can continue to
- safely assume (as is already asserted) that it will always be possible
- to link any JIT-code to JIT-code jumps and calls.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- Add new file.
- * jit/ExecutableAllocatorFixedVMPool.cpp: Added.
- (JSC::FreeListEntry::FreeListEntry):
- (JSC::AVLTreeAbstractorForFreeList::get_less):
- (JSC::AVLTreeAbstractorForFreeList::set_less):
- (JSC::AVLTreeAbstractorForFreeList::get_greater):
- (JSC::AVLTreeAbstractorForFreeList::set_greater):
- (JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
- (JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
- (JSC::AVLTreeAbstractorForFreeList::null):
- (JSC::AVLTreeAbstractorForFreeList::compare_key_key):
- (JSC::AVLTreeAbstractorForFreeList::compare_key_node):
- (JSC::AVLTreeAbstractorForFreeList::compare_node_node):
- (JSC::sortFreeListEntriesByPointer):
- (JSC::sortCommonSizedAllocations):
- (JSC::FixedVMPoolAllocator::release):
- (JSC::FixedVMPoolAllocator::reuse):
- (JSC::FixedVMPoolAllocator::addToFreeList):
- (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
- (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- (JSC::FixedVMPoolAllocator::alloc):
- (JSC::FixedVMPoolAllocator::free):
- (JSC::ExecutableAllocator::intializePageSize):
- (JSC::ExecutablePool::systemAlloc):
- (JSC::ExecutablePool::systemRelease):
- The new 2Gb heap class!
- * jit/ExecutableAllocatorPosix.cpp:
- Disable use of this implementation on x86_64.
- * wtf/AVLTree.h:
- Add missing variable initialization.
- (WTF::::remove):
-
-2009-04-17 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix bug where the VM reentry cache would not correctly unroll the cached callframe
-
- Fix a check that was intended to mark a cached call as invalid when the callframe could
- not be constructed. Instead it was just checking that there was a place to put the
- exception. This eventually results in a non-recoverable RegisterFile starvation.
-
- * interpreter/CachedCall.h:
- (JSC::CachedCall::CachedCall):
- (JSC::CachedCall::call): add assertion to ensure we don't use a bad callframe
-
-2009-04-17 David Kilzer <ddkilzer@apple.com>
-
- Simplify FEATURE_DEFINES definition
-
- Reviewed by Darin Adler.
-
- This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
- variables to their own FeatureDefines.xcconfig file. It also
- extracts a new ENABLE_GEOLOCATION variable so that
- FEATURE_DEFINES only needs to be defined once.
-
- * Configurations/FeatureDefines.xcconfig: Added.
- * Configurations/JavaScriptCore.xcconfig: Removed definition of
- ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include
- of FeatureDefines.xcconfig.
- * JavaScriptCore.xcodeproj/project.pbxproj: Added
- FeatureDefines.xcconfig file.
-
-2009-04-08 Mihnea Ovidenie <mihnea@adobe.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 25027: JavaScript parseInt wrong on negative numbers
- <https://bugs.webkit.org/show_bug.cgi?id=25027>
-
- When dealing with negative numbers, parseInt should use ceil instead of floor.
-
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt):
-
-2009-04-16 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size
-
- Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit. Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.
-
- * create_hash_table:
- * runtime/Lookup.cpp:
- (JSC::HashTable::createTable):
- (JSC::HashTable::deleteTable):
- * runtime/Lookup.h:
- (JSC::HashEntry::initialize):
- (JSC::HashEntry::next):
- (JSC::HashTable::entry):
- * runtime/Structure.cpp:
- (JSC::Structure::getEnumerableNamesFromClassInfoTable):
-
-2009-04-16 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Fix subtle error in optimised VM reentry in Array.sort
-
- Basically to ensure we don't accidentally invalidate the cached callframe
- we should be using the cached callframe rather than our own exec state.
- While the old behaviour was wrong i have been unable to actually create a
- test case where anything actually ends up going wrong.
-
- * interpreter/CachedCall.h:
- (JSC::CachedCall::newCallFrame):
- * runtime/JSArray.cpp:
- (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
-
-2009-04-16 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Optimise op_resolve_base
-
- If we can statically find a property we are trying to resolve
- the base of, the base is guaranteed to be the global object.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitResolveBase):
-
-2009-04-16 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve performance of read-write-modify operators
-
- Implement cross scope optimisation for read-write-modify
- operators, to avoid unnecessary calls to property resolve
- helper functions.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::emitLoadGlobalObject):
- (JSC::BytecodeGenerator::emitResolveWithBase):
* bytecompiler/BytecodeGenerator.h:
-2009-04-16 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve performance of remaining array enumeration functions
-
- Make use of function entry cache for remaining Array enumeration functions.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
-
-2009-04-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve performance of Array.sort
-
- Cache the VM entry for Array.sort when using a JS comparison function.
-
- * runtime/JSArray.cpp:
- (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
- (JSC::JSArray::sort):
-
-2009-04-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 25229: Need support for Array.prototype.reduceRight
- <https://bugs.webkit.org/show_bug.cgi?id=25229>
-
- Implement Array.reduceRight
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncReduceRight):
-
-2009-04-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 25227: Array.filter triggers an assertion when the target array shrinks while being filtered
- <https://bugs.webkit.org/show_bug.cgi?id=25227>
-
- We correct this simply by making the fast array path fall back on the slow path if
- we ever discover the fast access is unsafe.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncFilter):
-
-2009-04-13 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 25159: Support Array.prototype.reduce
- <https://bugs.webkit.org/show_bug.cgi?id=25159>
-
- Implement Array.prototype.reduce
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncReduce):
-
-2009-04-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Move CallFrameClosure from inside the Interpreter class to its own file.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/CachedCall.h:
- * interpreter/CallFrameClosure.h: Copied from JavaScriptCore/yarr/RegexJIT.h.
- (JSC::CallFrameClosure::setArgument):
- (JSC::CallFrameClosure::resetCallFrame):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::prepareForRepeatCall):
- * interpreter/Interpreter.h:
-
-2009-04-14 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
- Bug 25202: Improve performance of repeated callbacks into the VM
-
- Add the concept of a CachedCall to native code for use in Array
- prototype and similar functions where a single callback function
- is called repeatedly with the same number of arguments.
-
- Used Array.prototype.filter as the test function and got a 50% win
- over a naive non-caching specialised version. This makes the native
- implementation of Array.prototype.filter faster than the JS one once
- more.
-
- * JavaScriptCore.vcproj/JavaScriptCore.sln:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/CachedCall.h: Added.
- (JSC::CachedCall::CachedCall):
- (JSC::CachedCall::call):
- (JSC::CachedCall::setThis):
- (JSC::CachedCall::setArgument):
- (JSC::CachedCall::~CachedCall):
- CachedCall is a wrapper that automates the calling and teardown
- for a CallFrameClosure
- * interpreter/CallFrame.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::prepareForRepeatCall):
- Create the basic entry closure for a function
- (JSC::Interpreter::execute):
- A new ::execute method to enter the interpreter from a closure
- (JSC::Interpreter::endRepeatCall):
- Clear the entry closure
- * interpreter/Interpreter.h:
- (JSC::Interpreter::CallFrameClosure::setArgument):
- (JSC::Interpreter::CallFrameClosure::resetCallFrame):
- Helper functions to simplify setting up the closure's callframe
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncFilter):
-
-2009-04-14 Xan Lopez <xlopez@igalia.com>
-
- Fix the build.
-
- Add the yarr headers (and only the headers) to the build, so that
- RegExp.cpp can compile. The headers are ifdefed out with yarr
- disabled, so we don't need anything else for now.
-
- * GNUmakefile.am:
-
-2009-04-14 Adam Roben <aroben@apple.com>
-
- Remove support for profile-guided optimization on Windows
-
- Rubber-stamped by Steve Falkenburg.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed
- the Release_PGO configuration. Also let VS re-order the source files
- list.
-
-2009-04-14 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- * GNUmakefile.am:
-
-2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix when building minidom. Not reviewed.
-
- Use C-style comment instead of C++ style since autotools builds
- minidom using gcc and not g++.
-
- * wtf/Platform.h:
-
-2009-04-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by NOBODY - speculative build fix.
-
- * runtime/RegExp.h:
-
-2009-04-13 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cap'n Geoff Garen.
-
- Yarr!
- (Yet another regex runtime).
-
- Currently disabled by default since the interpreter, whilst awesomely
- functional, has not been optimized and is likely slower than PCRE, and
- the JIT, whilst faster than WREC, is presently incomplete and does not
- fallback to using an interpreter for the cases it cannot handle.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::move):
- (JSC::MacroAssemblerX86Common::swap):
- (JSC::MacroAssemblerX86Common::signExtend32ToPtr):
- (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
- (JSC::MacroAssemblerX86Common::branch32):
- (JSC::MacroAssemblerX86Common::branch16):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::cmpw_im):
- (JSC::X86Assembler::testw_rr):
- (JSC::X86Assembler::X86InstructionFormatter::immediate16):
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::~RegExp):
- (JSC::RegExp::create):
- (JSC::RegExp::compile):
- (JSC::RegExp::match):
- * runtime/RegExp.h:
- * wtf/Platform.h:
- * yarr: Added.
- * yarr/RegexCompiler.cpp: Added.
- (JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
- (JSC::Yarr::CharacterClassConstructor::reset):
- (JSC::Yarr::CharacterClassConstructor::append):
- (JSC::Yarr::CharacterClassConstructor::putChar):
- (JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
- (JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
- (JSC::Yarr::CharacterClassConstructor::putRange):
- (JSC::Yarr::CharacterClassConstructor::charClass):
- (JSC::Yarr::CharacterClassConstructor::addSorted):
- (JSC::Yarr::CharacterClassConstructor::addSortedRange):
- (JSC::Yarr::newlineCreate):
- (JSC::Yarr::digitsCreate):
- (JSC::Yarr::spacesCreate):
- (JSC::Yarr::wordcharCreate):
- (JSC::Yarr::nondigitsCreate):
- (JSC::Yarr::nonspacesCreate):
- (JSC::Yarr::nonwordcharCreate):
- (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor):
- (JSC::Yarr::RegexPatternConstructor::~RegexPatternConstructor):
- (JSC::Yarr::RegexPatternConstructor::reset):
- (JSC::Yarr::RegexPatternConstructor::assertionBOL):
- (JSC::Yarr::RegexPatternConstructor::assertionEOL):
- (JSC::Yarr::RegexPatternConstructor::assertionWordBoundary):
- (JSC::Yarr::RegexPatternConstructor::atomPatternCharacter):
- (JSC::Yarr::RegexPatternConstructor::atomBuiltInCharacterClass):
- (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBegin):
- (JSC::Yarr::RegexPatternConstructor::atomCharacterClassAtom):
- (JSC::Yarr::RegexPatternConstructor::atomCharacterClassRange):
- (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBuiltIn):
- (JSC::Yarr::RegexPatternConstructor::atomCharacterClassEnd):
- (JSC::Yarr::RegexPatternConstructor::atomParenthesesSubpatternBegin):
- (JSC::Yarr::RegexPatternConstructor::atomParentheticalAssertionBegin):
- (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
- (JSC::Yarr::RegexPatternConstructor::atomBackReference):
- (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
- (JSC::Yarr::RegexPatternConstructor::copyTerm):
- (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
- (JSC::Yarr::RegexPatternConstructor::disjunction):
- (JSC::Yarr::RegexPatternConstructor::regexBegin):
- (JSC::Yarr::RegexPatternConstructor::regexEnd):
- (JSC::Yarr::RegexPatternConstructor::regexError):
- (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- (JSC::Yarr::RegexPatternConstructor::setupDisjunctionOffsets):
- (JSC::Yarr::RegexPatternConstructor::setupOffsets):
- (JSC::Yarr::compileRegex):
- * yarr/RegexCompiler.h: Added.
- * yarr/RegexInterpreter.cpp: Added.
- (JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
- (JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
- (JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
- (JSC::Yarr::Interpreter::DisjunctionContext::operator new):
- (JSC::Yarr::Interpreter::allocDisjunctionContext):
- (JSC::Yarr::Interpreter::freeDisjunctionContext):
- (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
- (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
- (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
- (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
- (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
- (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
- (JSC::Yarr::Interpreter::InputStream::InputStream):
- (JSC::Yarr::Interpreter::InputStream::next):
- (JSC::Yarr::Interpreter::InputStream::rewind):
- (JSC::Yarr::Interpreter::InputStream::read):
- (JSC::Yarr::Interpreter::InputStream::readChecked):
- (JSC::Yarr::Interpreter::InputStream::reread):
- (JSC::Yarr::Interpreter::InputStream::prev):
- (JSC::Yarr::Interpreter::InputStream::getPos):
- (JSC::Yarr::Interpreter::InputStream::setPos):
- (JSC::Yarr::Interpreter::InputStream::atStart):
- (JSC::Yarr::Interpreter::InputStream::atEnd):
- (JSC::Yarr::Interpreter::InputStream::checkInput):
- (JSC::Yarr::Interpreter::InputStream::uncheckInput):
- (JSC::Yarr::Interpreter::testCharacterClass):
- (JSC::Yarr::Interpreter::tryConsumeCharacter):
- (JSC::Yarr::Interpreter::checkCharacter):
- (JSC::Yarr::Interpreter::tryConsumeCharacterClass):
- (JSC::Yarr::Interpreter::checkCharacterClass):
- (JSC::Yarr::Interpreter::tryConsumeBackReference):
- (JSC::Yarr::Interpreter::matchAssertionBOL):
- (JSC::Yarr::Interpreter::matchAssertionEOL):
- (JSC::Yarr::Interpreter::matchAssertionWordBoundary):
- (JSC::Yarr::Interpreter::matchPatternCharacter):
- (JSC::Yarr::Interpreter::backtrackPatternCharacter):
- (JSC::Yarr::Interpreter::matchCharacterClass):
- (JSC::Yarr::Interpreter::backtrackCharacterClass):
- (JSC::Yarr::Interpreter::matchBackReference):
- (JSC::Yarr::Interpreter::backtrackBackReference):
- (JSC::Yarr::Interpreter::recordParenthesesMatch):
- (JSC::Yarr::Interpreter::resetMatches):
- (JSC::Yarr::Interpreter::resetAssertionMatches):
- (JSC::Yarr::Interpreter::parenthesesDoBacktrack):
- (JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
- (JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
- (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
- (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
- (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceBegin):
- (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceEnd):
- (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceBegin):
- (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceEnd):
- (JSC::Yarr::Interpreter::matchParentheses):
- (JSC::Yarr::Interpreter::backtrackParentheses):
- (JSC::Yarr::Interpreter::matchTerm):
- (JSC::Yarr::Interpreter::backtrackTerm):
- (JSC::Yarr::Interpreter::matchAlternative):
- (JSC::Yarr::Interpreter::matchDisjunction):
- (JSC::Yarr::Interpreter::matchNonZeroDisjunction):
- (JSC::Yarr::Interpreter::interpret):
- (JSC::Yarr::Interpreter::Interpreter):
- (JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
- (JSC::Yarr::ByteCompiler::ByteCompiler):
- (JSC::Yarr::ByteCompiler::compile):
- (JSC::Yarr::ByteCompiler::checkInput):
- (JSC::Yarr::ByteCompiler::assertionBOL):
- (JSC::Yarr::ByteCompiler::assertionEOL):
- (JSC::Yarr::ByteCompiler::assertionWordBoundary):
- (JSC::Yarr::ByteCompiler::atomPatternCharacter):
- (JSC::Yarr::ByteCompiler::atomCharacterClass):
- (JSC::Yarr::ByteCompiler::atomBackReference):
- (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
- (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
- (JSC::Yarr::ByteCompiler::popParenthesesStack):
- (JSC::Yarr::ByteCompiler::dumpDisjunction):
- (JSC::Yarr::ByteCompiler::closeAlternative):
- (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
- (JSC::Yarr::ByteCompiler::regexBegin):
- (JSC::Yarr::ByteCompiler::regexEnd):
- (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
- (JSC::Yarr::ByteCompiler::emitDisjunction):
- (JSC::Yarr::byteCompileRegex):
- (JSC::Yarr::interpretRegex):
- * yarr/RegexInterpreter.h: Added.
- (JSC::Yarr::ByteTerm::):
- (JSC::Yarr::ByteTerm::ByteTerm):
- (JSC::Yarr::ByteTerm::BOL):
- (JSC::Yarr::ByteTerm::CheckInput):
- (JSC::Yarr::ByteTerm::EOL):
- (JSC::Yarr::ByteTerm::WordBoundary):
- (JSC::Yarr::ByteTerm::BackReference):
- (JSC::Yarr::ByteTerm::AlternativeBegin):
- (JSC::Yarr::ByteTerm::AlternativeDisjunction):
- (JSC::Yarr::ByteTerm::AlternativeEnd):
- (JSC::Yarr::ByteTerm::PatternEnd):
- (JSC::Yarr::ByteTerm::invert):
- (JSC::Yarr::ByteTerm::capture):
- (JSC::Yarr::ByteDisjunction::ByteDisjunction):
- (JSC::Yarr::BytecodePattern::BytecodePattern):
- (JSC::Yarr::BytecodePattern::~BytecodePattern):
- * yarr/RegexJIT.cpp: Added.
- (JSC::Yarr::RegexGenerator::optimizeAlternative):
- (JSC::Yarr::RegexGenerator::matchCharacterClassRange):
- (JSC::Yarr::RegexGenerator::matchCharacterClass):
- (JSC::Yarr::RegexGenerator::jumpIfNoAvailableInput):
- (JSC::Yarr::RegexGenerator::jumpIfAvailableInput):
- (JSC::Yarr::RegexGenerator::checkInput):
- (JSC::Yarr::RegexGenerator::atEndOfInput):
- (JSC::Yarr::RegexGenerator::notAtEndOfInput):
- (JSC::Yarr::RegexGenerator::jumpIfCharEquals):
- (JSC::Yarr::RegexGenerator::jumpIfCharNotEquals):
- (JSC::Yarr::RegexGenerator::readCharacter):
- (JSC::Yarr::RegexGenerator::storeToFrame):
- (JSC::Yarr::RegexGenerator::loadFromFrame):
- (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState):
- (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
- (JSC::Yarr::RegexGenerator::TermGenerationState::alternativeValid):
- (JSC::Yarr::RegexGenerator::TermGenerationState::nextAlternative):
- (JSC::Yarr::RegexGenerator::TermGenerationState::alternative):
- (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm):
- (JSC::Yarr::RegexGenerator::TermGenerationState::termValid):
- (JSC::Yarr::RegexGenerator::TermGenerationState::nextTerm):
- (JSC::Yarr::RegexGenerator::TermGenerationState::term):
- (JSC::Yarr::RegexGenerator::TermGenerationState::lookaheadTerm):
- (JSC::Yarr::RegexGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
- (JSC::Yarr::RegexGenerator::TermGenerationState::inputOffset):
- (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
- (JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackGenerated):
- (JSC::Yarr::RegexGenerator::jumpToBacktrackCheckEmitPending):
- (JSC::Yarr::RegexGenerator::genertateAssertionBOL):
- (JSC::Yarr::RegexGenerator::genertateAssertionEOL):
- (JSC::Yarr::RegexGenerator::matchAssertionWordchar):
- (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy):
- (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy):
- (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy):
- (JSC::Yarr::RegexGenerator::generateParenthesesSingleDisjunctionOneAlternative):
- (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
- (JSC::Yarr::RegexGenerator::generateTerm):
- (JSC::Yarr::RegexGenerator::generateDisjunction):
- (JSC::Yarr::RegexGenerator::RegexGenerator):
- (JSC::Yarr::RegexGenerator::generate):
- (JSC::Yarr::jitCompileRegex):
- (JSC::Yarr::executeRegex):
- * yarr/RegexJIT.h: Added.
- (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
- * yarr/RegexParser.h: Added.
- (JSC::Yarr::):
- (JSC::Yarr::Parser::):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacterUnescaped):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::end):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::flush):
- (JSC::Yarr::Parser::CharacterClassParserDelegate::):
- (JSC::Yarr::Parser::Parser):
- (JSC::Yarr::Parser::parseEscape):
- (JSC::Yarr::Parser::parseAtomEscape):
- (JSC::Yarr::Parser::parseCharacterClassEscape):
- (JSC::Yarr::Parser::parseCharacterClass):
- (JSC::Yarr::Parser::parseParenthesesBegin):
- (JSC::Yarr::Parser::parseParenthesesEnd):
- (JSC::Yarr::Parser::parseQuantifier):
- (JSC::Yarr::Parser::parseTokens):
- (JSC::Yarr::Parser::parse):
- (JSC::Yarr::Parser::saveState):
- (JSC::Yarr::Parser::restoreState):
- (JSC::Yarr::Parser::atEndOfPattern):
- (JSC::Yarr::Parser::peek):
- (JSC::Yarr::Parser::peekIsDigit):
- (JSC::Yarr::Parser::peekDigit):
- (JSC::Yarr::Parser::consume):
- (JSC::Yarr::Parser::consumeDigit):
- (JSC::Yarr::Parser::consumeNumber):
- (JSC::Yarr::Parser::consumeOctal):
- (JSC::Yarr::Parser::tryConsume):
- (JSC::Yarr::Parser::tryConsumeHex):
- (JSC::Yarr::parse):
- * yarr/RegexPattern.h: Added.
- (JSC::Yarr::CharacterRange::CharacterRange):
- (JSC::Yarr::):
- (JSC::Yarr::PatternTerm::):
- (JSC::Yarr::PatternTerm::PatternTerm):
- (JSC::Yarr::PatternTerm::BOL):
- (JSC::Yarr::PatternTerm::EOL):
- (JSC::Yarr::PatternTerm::WordBoundary):
- (JSC::Yarr::PatternTerm::invert):
- (JSC::Yarr::PatternTerm::capture):
- (JSC::Yarr::PatternTerm::quantify):
- (JSC::Yarr::PatternAlternative::PatternAlternative):
- (JSC::Yarr::PatternAlternative::lastTerm):
- (JSC::Yarr::PatternAlternative::removeLastTerm):
- (JSC::Yarr::PatternDisjunction::PatternDisjunction):
- (JSC::Yarr::PatternDisjunction::~PatternDisjunction):
- (JSC::Yarr::PatternDisjunction::addNewAlternative):
- (JSC::Yarr::RegexPattern::RegexPattern):
- (JSC::Yarr::RegexPattern::~RegexPattern):
- (JSC::Yarr::RegexPattern::reset):
- (JSC::Yarr::RegexPattern::containsIllegalBackReference):
- (JSC::Yarr::RegexPattern::newlineCharacterClass):
- (JSC::Yarr::RegexPattern::digitsCharacterClass):
- (JSC::Yarr::RegexPattern::spacesCharacterClass):
- (JSC::Yarr::RegexPattern::wordcharCharacterClass):
- (JSC::Yarr::RegexPattern::nondigitsCharacterClass):
- (JSC::Yarr::RegexPattern::nonspacesCharacterClass):
- (JSC::Yarr::RegexPattern::nonwordcharCharacterClass):
-
-2009-04-13 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Missed code from last patch).
-
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::displayName):
- (JSC::InternalFunction::calculatedDisplayName):
- * runtime/InternalFunction.h:
-
-2009-04-13 Francisco Tolmasky <francisco@280north.com>
-
- Reviewed by Oliver Hunt.
-
- BUG 25171: It should be possible to manually set the name of an anonymous function
- <https://bugs.webkit.org/show_bug.cgi?id=25171>
-
- This change adds the displayName property to functions, which when set overrides the
- normal name when appearing in the console.
-
- * profiler/Profiler.cpp:
- (JSC::createCallIdentifierFromFunctionImp): Changed call to InternalFunction::name to InternalFunction::calculatedDisplayName
- * runtime/CommonIdentifiers.h: Added displayName common identifier.
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::displayName): Access to user settable displayName property
- (JSC::InternalFunction::calculatedDisplayName): Returns displayName if it exists, if not then the natural name
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Disabled another JavaScriptCore test because it fails on Windows but
- not Mac, so it makes the bots red.
-
- * tests/mozilla/expected.html:
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
+ Reviewed by Maciej Stachowiak.
- Disabled two JavaScriptCore tests because they fail on Window or Mac but
- not both, so they make the bots red.
-
- * tests/mozilla/expected.html: Updated expected results.
-
-2009-04-09 Ben Murdoch <benm@google.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25091
- The Android platform requires threads to be registered with the VM.
- This patch implements this behaviour inside ThreadingPthreads.cpp.
-
- * wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM.
- (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards.
- (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly.
-
-2009-04-09 David Kilzer <ddkilzer@apple.com>
-
- Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
-
- Rolled r42345 back in. The build failure was caused by an
- internal script which had not been updated the same way that
- build-webkit was updated.
-
- * Configurations/JavaScriptCore.xcconfig:
-
-2009-04-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
- It broke Mac build, and I don't know how to fix it.
-
- * Configurations/JavaScriptCore.xcconfig:
-
-2009-04-09 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- Checking for __GLIBCXX__ being bigger than some date is not enough
- to get std::tr1, C++0x has to be in use too. Add another check for
- __GXX_EXPERIMENTAL_CXX0X__.
+ https://bugs.webkit.org/show_bug.cgi?id=26675
- * wtf/TypeTraits.h:
+ Inherits Register class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
-2009-04-08 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Adam Roben.
-
- Fix assertion failure in function.apply
-
- The result of excess arguments to function.apply is irrelevant
- so we don't need to provide a result register. We were providing
- temporary result register but not ref'ing it resulting in an
- assertion failure.
-
- * parser/Nodes.cpp:
- (JSC::ApplyFunctionCallDotNode::emitBytecode):
-
-2009-04-08 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
-
- Reviewed by Darin Adler and Maciej Stachowiak.
-
- Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
- that SVG DOM Objective-C bindings may be optionally disabled.
-
- * Configurations/JavaScriptCore.xcconfig: Added
- ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in
- FEATURE_DEFINES.
+ * interpreter/Register.h:
-2009-04-08 Paul Pedriana <ppedriana@ea.com>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20422
- Allow custom memory allocation control.
- * wtf/FastAllocBase.h:
- New added file. Implements allocation base class.
- * wtf/TypeTraits.h:
- Augments existing type traits support as needed by FastAllocBase.
- * wtf/FastMalloc.h:
- Changed to support FastMalloc match validation.
- * wtf/FastMalloc.cpp:
- Changed to support FastMalloc match validation.
- * wtf/Platform.h:
- Added ENABLE_FAST_MALLOC_MATCH_VALIDATION; defaults to 0.
- * GNUmakefile.am:
- Updated to include added FastAllocBase.h.
- * JavaScriptCore.xcodeproj/project.pbxproj:
- Updated to include added FastAllocBase.h.
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- Updated to include added FastAllocBase.h.
-
-2009-04-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
+ https://bugs.webkit.org/show_bug.cgi?id=26674
- Improve function.apply performance
+ Inherits HashMap class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.
- Jump through a few hoops to improve performance of function.apply in the general case.
-
- In the case of zero or one arguments, or if there are only two arguments and the
- second is an array literal we treat function.apply as function.call.
-
- Otherwise we use the new opcodes op_load_varargs and op_call_varargs to do the .apply call
- without re-entering the virtual machine.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * bytecode/Opcode.h:
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
- (JSC::BytecodeGenerator::emitLoadVarargs):
- (JSC::BytecodeGenerator::emitCallVarargs):
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCallVarargsSetupArgs):
- (JSC::JIT::compileOpCallVarargs):
- (JSC::JIT::compileOpCallVarargsSlowCase):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_load_varargs):
- * jit/JITStubs.h:
- * parser/Grammar.y:
- * parser/Nodes.cpp:
- (JSC::ArrayNode::isSimpleArray):
- (JSC::ArrayNode::toArgumentList):
- (JSC::CallFunctionCallDotNode::emitBytecode):
- (JSC::ApplyFunctionCallDotNode::emitBytecode):
- * parser/Nodes.h:
- (JSC::ExpressionNode::):
- (JSC::ApplyFunctionCallDotNode::):
- * runtime/Arguments.cpp:
- (JSC::Arguments::copyToRegisters):
- (JSC::Arguments::fillArgList):
- * runtime/Arguments.h:
- (JSC::Arguments::numProvidedArguments):
- * runtime/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::addFunctionProperties):
- * runtime/FunctionPrototype.h:
- * runtime/JSArray.cpp:
- (JSC::JSArray::copyToRegisters):
- * runtime/JSArray.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::mark):
- * runtime/JSGlobalObject.h:
+ * wtf/HashMap.h:
-2009-04-08 Alexey Proskuryakov <ap@webkit.org>
+2009-06-24 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=25073
- JavaScriptCore tests don't run if time zone is not PST
-
- * API/tests/testapi.c:
- (timeZoneIsPST): Added a function that checks whether the time zone is PST, using the same
- method as functions in DateMath.cpp do for formatting the result.
- (main): Skip date string format test if the time zone is not PST.
-
-2009-04-07 David Levin <levin@chromium.org>
-
- Reviewed by Sam Weinig and Geoff Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=25039
- UString refactoring to support UChar* sharing.
-
- No change in sunspider perf.
-
- * runtime/SmallStrings.cpp:
- (JSC::SmallStringsStorage::SmallStringsStorage):
- * runtime/UString.cpp:
- (JSC::initializeStaticBaseString):
- (JSC::initializeUString):
- (JSC::UString::BaseString::isShared):
- Encapsulate the meaning behind the refcount == 1 checks because
- this needs to do slightly more when sharing is added.
- (JSC::concatenate):
- (JSC::UString::append):
- (JSC::UString::operator=):
- * runtime/UString.h:
- Make m_baseString part of a union to get rid of casts, but make it protected because
- it is tricky to use it correctly since it is only valid when the Rep is not a BaseString.
- The void* will be filled in when sharing is added.
-
- Add constructors due to the making members protected and it make ensuring proper
- initialization work better (like in SmallStringsStorage).
- (JSC::UString::Rep::create):
- (JSC::UString::Rep::Rep):
- (JSC::UString::Rep::):
- (JSC::UString::BaseString::BaseString):
- (JSC::UString::Rep::setBaseString):
- (JSC::UString::Rep::baseString):
-
-2009-04-04 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25033
- dtoa.cpp segfaults with g++ 4.4.0
-
- g++ 4.4.0 seems to be more strict about aliasing rules, so it
- produces incorrect code if dtoa.cpp is compiled with
- -fstrict-aliasing (it also emits a ton of warnings, so fair enough
- I guess). The problem was that we were only casting variables to
- union types in order to do type punning, but GCC and the C
- standard require that we actually use a union to store the value.
-
- This patch does just that, the code is mostly copied from the dtoa
- version in GCC:
- http://gcc.gnu.org/viewcvs/trunk/libjava/classpath/native/fdlibm/dtoa.c?view=markup.
-
- * wtf/dtoa.cpp:
- (WTF::ulp):
- (WTF::b2d):
- (WTF::ratio):
- (WTF::hexnan):
- (WTF::strtod):
- (WTF::dtoa):
-
-2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix for Win port. Build the assembler sources to get missing functions.
-
- * JavaScriptCoreSources.bkl:
- * jscore.bkl:
- * wtf/Platform.h:
-
-2009-04-02 Darin Adler <darin@apple.com>
+ <rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'
- Reviewed by Kevin Decker.
+ The problem was caused by the page returned with a function using a
+ var declaration list containing around ~3000 variables. The solution
+ to this is to flatten the comma expression representation and make
+ codegen comma expressions and initializer lists iterative rather than
+ recursive.
- <rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer
-
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize
- callFunction as we do the other data members that are used in the mark function.
-
-2009-04-02 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon Hausmann
-
- https://bugs.webkit.org/show_bug.cgi?id=24490
-
- Implement WTF::ThreadSpecific in the Qt build using
- QThreadStorage.
-
- * wtf/ThreadSpecific.h:
-
-2009-04-01 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=24990
- Put SECTORDER_FLAGS into xcconfig files.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2009-03-27 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix non-AllInOneFile builds.
-
- * bytecompiler/BytecodeGenerator.cpp:
-
-2009-03-27 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve performance of Function.prototype.call
- <https://bugs.webkit.org/show_bug.cgi?id=24907>
-
- Optimistically assume that expression.call(..) is going to be a call to
- Function.prototype.call, and handle it specially to attempt to reduce the
- degree of VM reentrancy.
-
- When everything goes right this removes the vm reentry improving .call()
- by around a factor of 10.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * bytecode/Opcode.h:
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
* parser/Grammar.y:
+ * parser/NodeConstructors.h:
+ (JSC::CommaNode::CommaNode):
* parser/Nodes.cpp:
- (JSC::CallFunctionCallDotNode::emitBytecode):
+ (JSC::CommaNode::emitBytecode):
* parser/Nodes.h:
- (JSC::CallFunctionCallDotNode::):
- * runtime/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::addFunctionProperties):
- * runtime/FunctionPrototype.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::mark):
- * runtime/JSGlobalObject.h:
-
-2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Darin Adler.
-
- Bug 24884: Include strings.h for strcasecmp()
- https://bugs.webkit.org/show_bug.cgi?id=24884
+ (JSC::ExpressionNode::isCommaNode):
+ (JSC::CommaNode::isCommaNode):
+ (JSC::CommaNode::append):
- * runtime/DateMath.cpp: Reversed previous change including strings.h
- * wtf/StringExtras.h: Include strings.h here is available
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
-2009-03-26 Adam Roben <aroben@apple.com>
-
- Copy testapi.js to $WebKitOutputDir on Windows
-
- Part of Bug 24856: run-javascriptcore-tests should run testapi on
- Windows
- <https://bugs.webkit.org/show_bug.cgi?id=24856>
-
- This matches what Mac does, which will help once we enable running
- testapi from run-javascriptcore-tests on Windows.
-
- Reviewed by Steve Falkenburg.
-
- * JavaScriptCore.vcproj/testapi/testapi.vcproj: Copy testapi.js next
- to testapi.exe.
-
-2009-03-25 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix exception handling for instanceof in the interpreter.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
-
-2009-03-25 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed <rdar://problem/6724011> Write to freed memory in JSC::Label::deref
- when reloading http://helpme.att.net/speedtest/
-
- * bytecompiler/BytecodeGenerator.h: Reversed the declaration order for
- m_labelScopes and m_labels to reverse their destruction order.
- m_labelScopes has references to memory within m_labels, so its destructor
- needs to run first.
-
-2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Correct warnings which in some environments are treated as errors.
-
- * wtf/dtoa.cpp:
- (WTF::b2d):
- (WTF::d2b):
- (WTF::strtod):
- (WTF::dtoa):
-
-2009-03-24 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Darin Adler.
-
- Explicitly define HAVE_LANGINFO_H on Darwin. Fixes the wx build bot jscore
- test failure.
-
- https://bugs.webkit.org/show_bug.cgi?id=24780
-
- * wtf/Platform.h:
-
-2009-03-23 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix className() for API defined class
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::::className):
- * API/tests/testapi.c:
- (EmptyObject_class):
- (main):
- * API/tests/testapi.js:
-
-2009-03-23 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Make testapi assertions run in release builds, so that testapi actually
- works in a release build.
-
- Many of the testapi assertions have side effects that are necessary, and
- given testapi is a testing program, perf impact of an assertion is not
- important, so it makes sense to apply the assertions in release builds
- anyway.
-
- * API/tests/testapi.c:
- (EvilExceptionObject_hasInstance):
-
-2009-03-23 David Kilzer <ddkilzer@apple.com>
-
- Provide JavaScript exception information after slow script timeout
-
- Reviewed by Oliver Hunt.
-
- * runtime/Completion.cpp:
- (JSC::evaluate): Set the exception object as the Completion
- object's value for slow script timeouts. This is used in
- WebCore when reporting the exception.
- * runtime/ExceptionHelpers.cpp:
- (JSC::InterruptedExecutionError::toString): Added. Provides a
- description message for the exception when it is reported.
-
-2009-03-23 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=24674
- Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations
-
- Make sure strftime never returns 2-digits years to avoid ambiguity
- and a crash. We wrap this new code option in HAVE_LANGINFO_H,
- since it is apparently not available in all platforms.
-
- * runtime/DatePrototype.cpp:
- (JSC::formatLocaleDate):
- * wtf/Platform.h:
-
-2009-03-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix exception handling in API
-
- We can't just use the ExecState exception slot for returning exceptions
- from class introspection functions provided through the API as many JSC
- functions will explicitly clear the ExecState exception when returning.
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::JSCallbackObject<Base>::getOwnPropertySlot):
- (JSC::JSCallbackObject<Base>::put):
- (JSC::JSCallbackObject<Base>::deleteProperty):
- (JSC::JSCallbackObject<Base>::construct):
- (JSC::JSCallbackObject<Base>::hasInstance):
- (JSC::JSCallbackObject<Base>::call):
- (JSC::JSCallbackObject<Base>::toNumber):
- (JSC::JSCallbackObject<Base>::toString):
- (JSC::JSCallbackObject<Base>::staticValueGetter):
- (JSC::JSCallbackObject<Base>::callbackGetter):
- * API/tests/testapi.c:
- (MyObject_hasProperty):
- (MyObject_getProperty):
- (MyObject_setProperty):
- (MyObject_deleteProperty):
- (MyObject_callAsFunction):
- (MyObject_callAsConstructor):
- (MyObject_hasInstance):
- (EvilExceptionObject_hasInstance):
- (EvilExceptionObject_convertToType):
- (EvilExceptionObject_class):
- (main):
- * API/tests/testapi.js:
- (EvilExceptionObject.hasInstance):
- (EvilExceptionObject.toNumber):
- (EvilExceptionObject.toStringExplicit):
-
-2009-03-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20049: testapi failure: MyObject - 0 should be NaN but instead is 1.
- <https://bugs.webkit.org/show_bug.cgi?id=20049>
- <rdar://problem/6079127>
-
- In this case, the test is wrong. According to the ECMA spec, subtraction
- uses ToNumber, not ToPrimitive. Change the test to match the spec.
-
- * API/tests/testapi.js:
-
-2009-03-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Ensure that JSObjectMakeFunction doesn't produce incorrect line numbers.
-
- Also make test api correctly propagate failures.
-
- * API/tests/testapi.c:
- (main):
- * runtime/FunctionConstructor.cpp:
- (JSC::constructFunction):
-
-2009-03-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe.
-
- Improve testapi by making it report failures in a way we can pick up
- from our test scripts.
-
- * API/tests/testapi.c:
- (assertEqualsAsBoolean):
- (assertEqualsAsNumber):
- (assertEqualsAsUTF8String):
- (assertEqualsAsCharactersPtr):
- (main):
- * API/tests/testapi.js:
- (pass):
- (fail):
- (shouldBe):
- (shouldThrow):
-
-2009-03-20 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24535
-
- Fixes missing line terminator character (;) after macro call.
- It is common practice to add the trailing ";" where macros are substituted
- and not where they are defined with #define.
- This change is consistent with other macro declarations across webkit,
- and it also solves compilation failure with symbian compilers.
-
- * runtime/UString.cpp:
- * wtf/Assertions.h:
-
-2009-03-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed a JavaScriptCore crash on the Windows buildbot.
-
- * bytecompiler/BytecodeGenerator.h: Reduced the AST recursion limit.
- Apparently, Windows has small stacks.
-
-2009-03-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- A little cleanup in the RegisterFile code.
-
- Moved large inline functions out of the class declaration, to make it
- more readable.
-
- Switched over to using the roundUpAllocationSize function to avoid
- duplicate code and subtle bugs.
-
- Renamed m_maxCommitted to m_commitEnd, to match m_end.
-
- Renamed allocationSize to commitSize because it's the chunk size for
- committing memory, not allocating memory.
-
- SunSpider reports no change.
-
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- (JSC::RegisterFile::shrink):
- (JSC::RegisterFile::grow):
- * jit/ExecutableAllocator.h:
- (JSC::roundUpAllocationSize):
-
-2009-03-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.
-
- SunSpider reports no change. I also verified in the disassembly that
- we end up with a single compare to constant.
-
- * runtime/Collector.cpp:
- (JSC::Heap::heapAllocate):
-
-2009-03-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich and Oliver Hunt.
-
- Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
- fast/workers/use-machine-stack.html (22531)
-
- Dialed down the re-entry allowance to 64 (from 128).
-
- On a 512K stack, this leaves about 64K for other code on the stack while
- JavaScript is running. Not perfect, but it solves our crash on PPC.
-
- Different platforms may want to dial this down even more.
-
- Also, substantially shrunk BytecodeGenerator. Since we allocate one on
- the stack in order to throw a stack overflow exception -- well, let's
- just say the old code had an appreciation for irony.
-
- SunSpider reports no change.
-
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.h:
- (JSC::):
-
-2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 24350: REGRESSION: Safari 4 breaks SPAW wysiwyg editor multiple instances
- <https://bugs.webkit.org/show_bug.cgi?id=24350>
- <rdar://problem/6674182>
-
- The SPAW editor's JavaScript assumes that toString() on a function
- constructed with the Function constructor produces a function with
- a newline after the opening brace.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::constructFunction): Add a newline after the opening brace of the
- function's source code.
-
-2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Geoff Garen.
-
- Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
- <https://bugs.webkit.org/show_bug.cgi?id=23771>
- <rdar://problem/6561016>
-
- * API/tests/testapi.c:
- (main): Add a test for this bug.
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the
- last object in the prototype chain to the object prototype when the
- object prototype is already the last object in the prototype chain.
-
-2009-03-19 Timothy Hatcher <timothy@apple.com>
-
- <rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers
-
- Reviewed by Darin Adler.
-
- * wtf/Platform.h: Added HAVE_RUNLOOP_TIMER for PLATFORM(MAC).
-
-2009-03-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fixed <rdar://problem/6279213> Regular expression run-time complexity
- limit too low for long inputs (21485)
-
- I raised PCRE's "matchLimit" (limit on backtracking) by an order of
- magnitude. This fixes all the reported examples of timing out on legitimate
- regular expression matches.
-
- In my testing on a Core Duo MacBook Pro, the longest you can get stuck
- trying to match a string is still under 1s, so this seems like a safe change.
-
- I can think of a number of better solutions that are more complicated,
- but this is a good improvement for now.
-
- * pcre/pcre_exec.cpp:
-
-2009-03-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
- pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)
-
- Bumped the pattern size limit to 1MB, and standardized it between PCRE
- and WREC. (Empirical testing says that we can easily compile a 1MB regular
- expression without risking a hang. Other browsers support bigger regular
- expressions, but also hang.)
-
- SunSpider reports no change.
-
- I started with a patch posted to Bugzilla by Erik Corry (erikcorry@google.com).
-
- * pcre/pcre_internal.h:
- (put3ByteValue):
- (get3ByteValue):
- (put3ByteValueAndAdvance):
- (putLinkValueAllowZero):
- (getLinkValueAllowZero): Made PCRE's "LINK_SIZE" (the number of bytes
- used to record jumps between bytecodes) 3, to accomodate larger potential
- jumps. Bumped PCRE's "MAX_PATTERN_SIZE" to 1MB. (Technically, at this
- LINK_SIZE, we can support even larger patterns, but we risk a hang during
- compilation, and it's not clear that such large patterns are important
- on the web.)
-
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp): Match PCRE's maximum pattern size,
- to avoid quirks between platforms.
-
-2009-03-18 Ada Chan <adachan@apple.com>
-
- Rolling out r41818 since it broke the windows build.
- Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory
-
- * runtime/DatePrototype.cpp:
- (JSC::formatLocaleDate):
-
-2009-03-17 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- <rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
- <https://bugs.webkit.org/show_bug.cgi?id=24654>
-
- If the return value for a function is in a local register we need
- to copy it before executing any finalisers, otherwise it is possible
- for the finaliser to clobber the result.
-
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::hasFinaliser):
- * parser/Nodes.cpp:
- (JSC::ReturnNode::emitBytecode):
-
-2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Mark Rowe.
-
- Move BUILDING_ON_* defines into Platform.h to make them available to other ports.
- Also tweak the defines so that they work with the default values set by
- AvailabilityMacros.h.
-
- https://bugs.webkit.org/show_bug.cgi?id=24630
-
- * JavaScriptCorePrefix.h:
- * wtf/Platform.h:
-
-2009-03-15 Simon Fraser <simon.fraser@apple.com>
-
- Revert r41718 because it broke DumpRenderTree on Tiger.
-
- * JavaScriptCorePrefix.h:
- * wtf/Platform.h:
-
-2009-03-15 Kevin Ollivier <kevino@theolliviers.com>
-
- Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
- Platform.h so that they're defined for all ports building on Mac, and tweak
- the definitions of those macros based on Mark Rowe's suggestions to accomodate
- cases where the values may not be <= to the .0 release for that version.
-
- * JavaScriptCorePrefix.h:
- * wtf/Platform.h:
-
-2009-03-13 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- Take advantage of the ability of recent versions of Xcode to easily switch the active
- architecture.
-
- * Configurations/DebugRelease.xcconfig:
-
-2009-03-13 Mark Rowe <mrowe@apple.com>
-
- Reviewed by David Kilzer.
-
- Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
- switching between building in Xcode and via build-webkit.
-
- build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
- Derived Sources build settings. When building in Xcode, this setting isn't present so
- Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
- being generated, and the files that include it being rebuilt.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is
- already newer than the input file.
-
-2009-03-13 Norbert Leser <norbert.leser@nokia.com>
+ Reviewed by Maciej Stachowiak.
- Reviewed by Darin Adler.
+ https://bugs.webkit.org/show_bug.cgi?id=26645
- Resolved name conflict with globally defined tzname in Symbian.
- Replaced with different name instead of using namespace qualifier
- (appeared to be less clumsy).
+ Inherits ScopeChainNode class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.
- * runtime/DateMath.cpp:
+ * wtf/RefPtr.h:
-2009-03-12 Mark Rowe <mrowe@apple.com>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
- <rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages
-
- * wtf/FastMalloc.cpp:
- (WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
- span as well so that the flag in the merged span is accurate.
- * wtf/Platform.h:
- * wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.
- (TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
- (TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.
- * wtf/TCSystemAlloc.h:
-
-2009-03-12 Adam Treat <adam.treat@torchmobile.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26648
- Reviewed by NOBODY (Build fix).
-
- Include string.h for strlen usage.
-
- * wtf/Threading.cpp:
+ Inherits Deque class from FastAllocBase because it has been
+ instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
+ JavaScriptCore/wtf/MainThread.cpp:62.
-2009-03-12 David Kilzer <ddkilzer@apple.com>
+ * wtf/Deque.h:
- Add NO_RETURN attribute to runInteractive() when not using readline
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
- * jsc.cpp:
- (runInteractive): If the readline library is not used, this method
- will never return, thus the NO_RETURN attribute is needed to prevent
- a gcc warning.
-
-2009-03-12 Adam Roben <aroben@apple.com>
-
- Adopt setThreadNameInternal on Windows
-
- Also changed a Windows-only assertion about thread name length to an
- all-platform log message.
-
- Reviewed by Adam Treat.
-
- * wtf/Threading.cpp:
- (WTF::createThread): Warn if the thread name is longer than 31
- characters, as Visual Studio will truncate names longer than that
- length.
-
- * wtf/ThreadingWin.cpp:
- (WTF::setThreadNameInternal): Renamed from setThreadName and changed
- to always operate on the current thread.
- (WTF::initializeThreading): Changed to use setThreadNameInternal.
- (WTF::createThreadInternal): Removed call to setThreadName. This is
- now handled by threadEntryPoint and setThreadNameInternal.
-
-2009-03-11 David Kilzer <ddkilzer@apple.com>
-
- Clarify comments regarding order of FEATURE_DEFINES
+ https://bugs.webkit.org/show_bug.cgi?id=26644
- Rubber-stamped by Mark Rowe.
+ Inherits RefPtr class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.
- * Configurations/JavaScriptCore.xcconfig: Added warning about
- the consequences when FEATURE_DEFINES are not kept in sync.
+ * wtf/RefPtr.h:
-2009-03-11 Dan Bernstein <mitz@apple.com>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
- - WTF support for fixing <rdar://problem/3919124> Thai text selection
- in Safari is incorrect
-
- * wtf/unicode/icu/UnicodeIcu.h:
- (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns
- whether the character has Unicode line breaking property value SA
- ("Complex Context").
- * wtf/unicode/qt4/UnicodeQt4.h:
- (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an
- implementation that always returns false.
-
-2009-03-11 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Give threads names on platforms with pthread_setname_np.
-
- * wtf/Threading.cpp:
- (WTF::NewThreadContext::NewThreadContext): Initialize thread name.
- (WTF::threadEntryPoint): Call setThreadNameInternal.
- (WTF::createThread): Pass thread name.
-
- * wtf/Threading.h: Added new comments, setThreadNameInternal.
-
- * wtf/ThreadingGtk.cpp:
- (WTF::setThreadNameInternal): Added. Empty.
- * wtf/ThreadingNone.cpp:
- (WTF::setThreadNameInternal): Added. Empty.
- * wtf/ThreadingPthreads.cpp:
- (WTF::setThreadNameInternal): Call pthread_setname_np when available.
- * wtf/ThreadingQt.cpp:
- (WTF::setThreadNameInternal): Added. Empty.
- * wtf/ThreadingWin.cpp:
- (WTF::setThreadNameInternal): Added. Empty.
-
-2009-03-11 Adam Roben <aroben@apple.com>
-
- Change the Windows implementation of ThreadSpecific to use functions
- instead of extern globals
-
- This will make it easier to export ThreadSpecific from WebKit.
-
- Reviewed by John Sullivan.
+ Inherits HashSet class from FastAllocBase, because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.
- * API/JSBase.cpp:
- (JSEvaluateScript):
- Touched this file to force ThreadSpecific.h to be copied into
- $WebKitOutputDir.
-
- * wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount()
- and g_tls_keys with tlsKeys().
-
- (WTF::::ThreadSpecific):
- (WTF::::~ThreadSpecific):
- (WTF::::get):
- (WTF::::set):
- (WTF::::destroy):
- Updated to use the new functions.
-
- * wtf/ThreadSpecificWin.cpp:
- (WTF::tlsKeyCount):
- (WTF::tlsKeys):
- Added.
-
- (WTF::ThreadSpecificThreadExit): Changed to use the new functions.
-
-2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Geoff Garen.
-
- Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
- <https://bugs.webkit.org/show_bug.cgi?id=24291>
- <rdar://problem/6663472>
-
- Add an extra newline to the end of the body of the program text constructed
- by the Function constructor for parsing. This allows single line comments to
- be handled correctly by the parser.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::constructFunction):
-
-2009-03-09 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
- <rdar://problem/6657774>
-
- r41508 actually exposed a pre-existing bug where we were not invalidating the result
- register cache at jump targets. This causes problems when condition loads occur in an
- expression -- namely through the ?: and || operators. This patch corrects these issues
- by marking the target of all forward jumps as being a jump target, and then clears the
- result register cache when ever it starts generating code for a targeted instruction.
-
- I do not believe it is possible to cause this class of failure outside of a single
- expression, and expressions only provide forward branches, so this should resolve this
- entire class of bug. That said i've included a test case that gets as close as possible
- to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
- problem in future.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::Label::isUsed):
- (JSC::AbstractMacroAssembler::Label::used):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::JmpDst::JmpDst):
- (JSC::X86Assembler::JmpDst::isUsed):
- (JSC::X86Assembler::JmpDst::used):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
+ * wtf/HashSet.h:
-2009-03-09 David Levin <levin@chromium.org>
+2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
- Bug 23175: String and UString should be able to share a UChar* buffer.
- <https://bugs.webkit.org/show_bug.cgi?id=23175>
-
- Add CrossThreadRefCounted.
-
- * wtf/CrossThreadRefCounted.h: Added.
- (WTF::CrossThreadRefCounted::create):
- (WTF::CrossThreadRefCounted::isShared):
- (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe):
- (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread):
- (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
- (WTF::CrossThreadRefCounted::~CrossThreadRefCounted):
- (WTF::CrossThreadRefCounted::ref):
- (WTF::CrossThreadRefCounted::deref):
- (WTF::CrossThreadRefCounted::release):
- (WTF::CrossThreadRefCounted::copy):
- (WTF::CrossThreadRefCounted::threadSafeDeref):
- * wtf/RefCounted.h:
- * wtf/Threading.h:
- (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase):
- (WTF::ThreadSafeSharedBase::derefBase):
- (WTF::ThreadSafeShared::ThreadSafeShared):
- (WTF::ThreadSafeShared::deref):
-
-2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=24353
- Allow to overrule default build options for Qt build.
-
- * JavaScriptCore.pri: Allow to overrule ENABLE_JIT
-
-2009-03-08 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (build fix).
-
- Build fix.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncConcat):
-
-2009-03-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 24268: RuntimeArray is not a fully implemented JSArray
- <https://bugs.webkit.org/show_bug.cgi?id=24268>
-
- Don't cast a type to JSArray, just because it reportsArray as a supertype
- in the JS type system. Doesn't appear feasible to create a testcase
- unfortunately as setting up the failure conditions requires internal access
- to JSC not present in DRT.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncConcat):
-
-2009-03-06 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- When preforming an op_mov, preserve any existing register mapping.
-
- ~0.5% progression on v8 tests x86-64.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>
-
- Bug 24382: request to add SH4 platform
-
- <https://bugs.webkit.org/show_bug.cgi?id=24382>
-
- Reviewed by David Kilzer.
-
- * wtf/Platform.h: Added support for SH4 platform.
-
-2009-03-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Writes of constant values to SF registers should be made with direct memory
- writes where possible, rather than moving the value via a hardware register.
-
- ~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.
-
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::storePtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::movq_i32m):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2009-03-05 Mark Rowe <mrowe@apple.com>
-
- Fix the build.
-
- Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.
-
- * runtime/NumberConstructor.cpp:
- (JSC::numberConstructorNaNValue):
- (JSC::numberConstructorNegInfinity):
- (JSC::numberConstructorPosInfinity):
- (JSC::numberConstructorMaxValue):
- (JSC::numberConstructorMinValue):
-
-2009-03-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space
-
- The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
- to record the memory containing and individual span as an administrative region, when all memory
- allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
- via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
- "MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.
-
- Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
- These two cases are handled differently.
-
- PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
- first object in an allocated region contains the link to the previously allocated region. To record
- the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
- each allocated region we encounter.
-
- TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
- the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
- at each position rather than the nodes themselves.
-
- A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
- so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
- range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
- them with a single call. A similar approach is also used by AdminRegionRecorder.
-
- * wtf/FastMalloc.cpp:
- (WTF::PageHeapAllocator::Init):
- (WTF::PageHeapAllocator::New):
- (WTF::PageHeapAllocator::recordAdministrativeRegions):
- (WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
- (WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
- (WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
- (WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
- (WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
- (WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
- (WTF::TCMallocStats::AdminRegionRecorder::visit):
- (WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
- (WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
- (WTF::TCMallocStats::FastMallocZone::enumerate):
- (WTF::TCMallocStats::FastMallocZone::FastMallocZone):
- (WTF::TCMallocStats::FastMallocZone::init):
- * wtf/TCPageMap.h:
- (TCMalloc_PageMap2::visitValues):
- (TCMalloc_PageMap2::visitAllocations):
- (TCMalloc_PageMap3::visitValues):
- (TCMalloc_PageMap3::visitAllocations):
-
-2009-03-04 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24359
- Repaint throttling mechanism
-
- Set ENABLE_REPAINT_THROTTLING to 0 by default.
-
- * wtf/Platform.h:
-
-2009-03-03 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
-
- Reviewed by Mark Rowe.
-
- * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based
- on PLATFORM_NAME to work around the missing definition on Tiger.
- Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.
-
-2009-03-03 Kevin McCullough <kmccullough@apple.com>
+ Inherits Vector class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6639110> console.profile() doesn't work without a title
-
- * profiler/Profiler.cpp:
- (JSC::Profiler::startProfiling): assert if there is not title to ensure
- we don't start profiling without one.
-
-2009-03-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Enable Geolocation (except on Tiger and Leopard).
-
- * Configurations/JavaScriptCore.xcconfig:
-
-2009-03-01 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig
-
- Reviewed by Mark Rowe.
-
- * Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable
- based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define
- it as a preprocessor macro by modifying
- GCC_PREPROCESSOR_DEFINITIONS.
- * JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate
- DTrace header" script phase to check for HAVE_DTRACE instead of
- MACOSX_DEPLOYMENT_TARGET.
- * wtf/Platform.h: Removed definition of HAVE_DTRACE macro since
- it's defined in Base.xcconfig now.
-
-2009-03-01 Horia Olaru <olaru@adobe.com>
-
- By looking in grammar.y there are only a few types of statement nodes
- on which the debugger should stop.
+ * wtf/Vector.h:
- Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
- the "statementListEmitCode" method as long as the necessary hooks can be
- added in each "emitCode".
+2009-06-24 Norbert Leser <norbert.leser@nokia.com>
- https://bugs.webkit.org/show_bug.cgi?id=21073
+ Reviewed by Maciej Stachoviak.
- Reviewed by Kevin McCullough.
+ The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
+ (each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
+ Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
+ the stack overflows immediately on Symbian hardware (max. 80 kB).
+ Proposed change allocates generator objects on heap.
+ Performance impact (if any) should be negligible and change is proposed as general fix,
+ rather than ifdef'd for SYMBIAN.
* parser/Nodes.cpp:
- (JSC::ConstStatementNode::emitBytecode):
- (JSC::statementListEmitCode):
- (JSC::EmptyStatementNode::emitBytecode):
- (JSC::ExprStatementNode::emitBytecode):
- (JSC::VarStatementNode::emitBytecode):
- (JSC::IfNode::emitBytecode):
- (JSC::IfElseNode::emitBytecode):
- (JSC::DoWhileNode::emitBytecode):
- (JSC::WhileNode::emitBytecode):
- (JSC::ForNode::emitBytecode):
- (JSC::ForInNode::emitBytecode):
- (JSC::ContinueNode::emitBytecode):
- (JSC::BreakNode::emitBytecode):
- (JSC::ReturnNode::emitBytecode):
- (JSC::WithNode::emitBytecode):
- (JSC::SwitchNode::emitBytecode):
- (JSC::LabelNode::emitBytecode):
- (JSC::ThrowNode::emitBytecode):
- (JSC::TryNode::emitBytecode):
- * parser/Nodes.h:
-
-2009-02-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix bug #23614. Switches on double precision values were incorrectly
- truncating the scrutinee value. E.g.:
-
- switch (1.1) { case 1: print("FAIL"); }
-
- Was resulting in FAIL.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::cti_op_switch_imm):
-
-2009-02-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Integer Immediate representation need not be canonical in x86 JIT code.
- On x86-64 we already have loosened the requirement that the int immediate
- representation in canonical, we should bring x86 into line.
-
- This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
- should reduce memory footoprint (reduces JIT code size).
-
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- (JSC::JIT::emitJumpIfImmediateNumber):
- (JSC::JIT::emitJumpIfNotImmediateNumber):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
-
-2009-02-26 Carol Szabo <carol.szabo@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24099
- ARM Compiler Warnings in pcre_exec.cpp
-
- * pcre/pcre_exec.cpp:
- (match):
+ (JSC::ProgramNode::generateBytecode):
+ (JSC::EvalNode::generateBytecode):
+ (JSC::EvalNode::bytecodeForExceptionInfoReparse):
+ (JSC::FunctionBodyNode::generateBytecode):
+ (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
-2009-02-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+2009-06-23 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
- Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
- <https://bugs.webkit.org/show_bug.cgi?id=24086>
- <rdar://problem/6625111>
-
- The numeric sort optimization in r40993 generated bytecode for a function
- without generating JIT code. This breaks an assumption in some parts of
- the JIT's function calling logic that the presence of a CodeBlock implies
- the existence of JIT code.
-
- In order to fix this, we simply generate JIT code whenever we check whether
- a function is a numeric sort function. This only incurs an additional cost
- in the case when the function is a numeric sort function, in which case it
- is not expensive to generate JIT code for it.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::isNumericCompareFunction):
-
-2009-02-25 Geoffrey Garen <ggaren@apple.com>
+ <rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
+ <https://bugs.webkit.org/show_bug.cgi?id=26593>
- Reviewed by Maciej Stachowiak.
-
- Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
- messages on hotmail (24052)
-
- The bug was that for-in enumeration used a cached prototype chain without
- validating that it was up-to-date.
-
- This led me to refactor prototype chain caching so it was easier to work
- with and harder to get wrong.
-
- After a bit of inlining, this patch is performance-neutral on SunSpider
- and the v8 benchmarks.
+ Do not attempt to cache structure chains if they contain a dictionary at any level.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
- (JSC::JITStubs::tryCachePutByID):
- (JSC::JITStubs::tryCacheGetByID):
- (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See
- lines beginning with "-" and smile.
-
- * runtime/JSGlobalObject.h:
- (JSC::Structure::prototypeForLookup): A shout out to const.
-
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to
- see if our cached structure chain is equal to the object's structure chain,
- since in the case of a cache hit, we share references to the same structure
- chain.
-
- * runtime/Operations.h:
- (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored
- goodness.
-
- * runtime/PropertyNameArray.h:
- (JSC::PropertyNameArray::PropertyNameArray):
- (JSC::PropertyNameArray::setShouldCache):
- (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache"
- to communicate that the client is specifying a recommendation, not a
- capability.
-
+ (JSC::JITThunks::tryCachePutByID):
* runtime/Structure.cpp:
- (JSC::Structure::Structure): No need to initialize a RefPtr.
- (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper
- functions.
-
- (JSC::Structure::prototypeChain): New centralized accessor for a prototype
- chain. Revalidates on every access, since the objects in the prototype
- chain may have mutated.
-
- (JSC::Structure::isValid): Helper function for revalidating a cached
- prototype chain.
-
- (JSC::Structure::getEnumerableNamesFromPropertyTable):
- (JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
- getEnumerablePropertyNames.
-
- * runtime/Structure.h:
-
+ (JSC::Structure::getEnumerablePropertyNames):
+ (JSC::Structure::addPropertyTransition):
* runtime/StructureChain.cpp:
- (JSC::StructureChain::StructureChain):
+ (JSC::StructureChain::isCacheable):
* runtime/StructureChain.h:
- (JSC::StructureChain::create): No need for structureChainsAreEqual, since
- we use pointer equality now. Refactored StructureChain to make a little
- more sense and eliminate special cases for null prototypes.
-
-2009-02-25 Steve Falkenburg <sfalken@apple.com>
-
- Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
- Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.
-
- Reviewed by Adam Roben.
-
- * jsc.cpp:
- (main):
-2009-02-24 Geoffrey Garen <ggaren@apple.com>
+2009-06-23 Yong Li <yong.li@torchmobile.com>
- Build fix?
+ Reviewed by George Staikos.
- * GNUmakefile.am:
+ https://bugs.webkit.org/show_bug.cgi?id=26654
+ Add the proper export define for the JavaScriptCore API when building for WINCE.
-2009-02-24 Mark Rowe <mrowe@apple.com>
+ * API/JSBase.h:
- Reviewed by Oliver Hunt.
+2009-06-23 Joe Mason <joe.mason@torchmobile.com>
- <rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros
+ Reviewed by Adam Treat.
- * API/JSBasePrivate.h:
- * API/JSContextRef.h:
- * API/JSObjectRef.h:
- * API/WebKitAvailability.h:
+ Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
-2009-02-23 Geoffrey Garen <ggaren@apple.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26611
+ Implement currentThreadStackBase on WINCE by adding a global,
+ g_stackBase, which must be set to the address of a local variable
+ by the caller before calling any WebKit function that invokes JSC.
- Reviewed by Sam Weinig.
-
- Next step in splitting JIT functionality out of the Interpreter class:
- Moved vptr storage from Interpreter to JSGlobalData, so it could be shared
- between Interpreter and JITStubs, and moved the *Trampoline JIT stubs
- into the JITStubs class. Also added a VPtrSet class to encapsulate vptr
- hacks during JSGlobalData initialization.
-
- SunSpider says 0.4% faster. Meh.
+ * runtime/Collector.cpp:
+ (JSC::isPageWritable):
+ (JSC::getStackBase):
+ Starts at the top of the stack and returns the entire range of
+ consecutive writable pages as an estimate of the actual stack.
+ This will be much bigger than the actual stack range, so some
+ dead objects can't be collected, but it guarantees live objects
+ aren't collected prematurely.
- * JavaScriptCore.exp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::JIT::compileCTIMachineTrampolines):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::JITStubs):
- (JSC::JITStubs::tryCacheGetByID):
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_put_by_val):
- (JSC::JITStubs::cti_op_put_by_val_array):
- (JSC::JITStubs::cti_op_put_by_val_byte_array):
- (JSC::JITStubs::cti_op_is_string):
- * jit/JITStubs.h:
- (JSC::JITStubs::ctiArrayLengthTrampoline):
- (JSC::JITStubs::ctiStringLengthTrampoline):
- (JSC::JITStubs::ctiVirtualCallPreLink):
- (JSC::JITStubs::ctiVirtualCallLink):
- (JSC::JITStubs::ctiVirtualCall):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- * runtime/JSArray.h:
- (JSC::isJSArray):
- * runtime/JSByteArray.h:
- (JSC::asByteArray):
- (JSC::isJSByteArray):
- * runtime/JSCell.h:
- * runtime/JSFunction.h:
- * runtime/JSGlobalData.cpp:
- (JSC::VPtrSet::VPtrSet):
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::create):
- (JSC::JSGlobalData::sharedInstance):
- * runtime/JSGlobalData.h:
- * runtime/JSString.h:
- (JSC::isJSString):
- * runtime/Operations.h:
- (JSC::jsLess):
- (JSC::jsLessEq):
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
+ (JSC::currentThreadStackBase):
+ On WinCE, returns g_stackBase if set or call getStackBase as a
+ fallback if not.
-2009-02-23 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+2009-06-23 Oliver Hunt <oliver@apple.com>
- Reviewed by Oliver Hunt.
+ Reviewed by Alexey Proskuryakov.
- Bug 23787: Allow JIT to generate SSE2 code if using GCC
- <https://bugs.webkit.org/show_bug.cgi?id=23787>
+ Fix stupid performance problem in the LiteralParser
- GCC version of the cpuid check.
+ The LiteralParser was making a new UString in order to use
+ toDouble, however UString's toDouble allows a much wider range
+ of numberic strings than the LiteralParser accepts, and requires
+ an additional heap allocation or two for the construciton of the
+ UString. To rectify this we just call WTF::dtoa directly using
+ a stack allocated buffer to hold the validated numeric literal.
- * jit/JITArithmetic.cpp:
- (JSC::isSSE2Present): previous assembly code fixed.
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::Lexer::lexNumber):
+ (JSC::LiteralParser::parse):
+ * runtime/LiteralParser.h:
-2009-02-23 David Levin <levin@chromium.org>
+2009-06-22 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
- Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
- <https://bugs.webkit.org/show_bug.cgi?id=24047>
+ Bug 26640: JSON.stringify needs to special case Boolean objects
+ <https://bugs.webkit.org/show_bug.cgi?id=26640>
- * wtf/MessageQueue.h:
- (WTF::MessageQueue::infiniteTime):
- Allows for one to call waitForMessageFilteredWithTimeout and wait forever.
+ Add special case handling of the Boolean object so we match current
+ ES5 errata.
- (WTF::MessageQueue::alwaysTruePredicate):
- (WTF::MessageQueue::waitForMessage):
- Made waitForMessage call waitForMessageFilteredWithTimeout, so that there is less
- duplicate code.
+ * runtime/JSONObject.cpp:
+ (JSC::unwrapBoxedPrimitive): renamed from unwrapNumberOrString
+ (JSC::gap):
+ (JSC::Stringifier::appendStringifiedValue):
- (WTF::MessageQueue::waitForMessageFilteredWithTimeout):
+2009-06-22 Oliver Hunt <oliver@apple.com>
- * wtf/ThreadingQt.cpp:
- (WTF::ThreadCondition::timedWait):
- * wtf/ThreadingWin.cpp:
- (WTF::ThreadCondition::timedWait):
- Made these two implementations consistent with the pthread and gtk implementations.
- Currently, the time calculations would overflow when passed large values.
-
-2009-02-23 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Adam Roben.
+ Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=24096
- PLATFORM(MAC)->PLATFORM(CF) since we want to use the CF functions in Chrome on OS X.
+ Bug 26591: Support revivers in JSON.parse
+ <https://bugs.webkit.org/show_bug.cgi?id=26591>
- * wtf/CurrentTime.cpp:
+ Add reviver support to JSON.parse. This completes the JSON object.
-2009-02-22 Geoffrey Garen <ggaren@apple.com>
+ * runtime/JSONObject.cpp:
+ (JSC::Walker::Walker):
+ (JSC::Walker::callReviver):
+ (JSC::Walker::walk):
+ (JSC::JSONProtoFuncParse):
- Build fix?
+2009-06-21 Oliver Hunt <oliver@apple.com>
- * GNUmakefile.am:
+ Reviewed by Darin Adler.
-2009-02-22 Geoffrey Garen <ggaren@apple.com>
+ Bug 26592: Support standard toJSON functions
+ <https://bugs.webkit.org/show_bug.cgi?id=26592>
- Build fix.
+ Add support for the standard Date.toJSON function.
- * GNUmakefile.am:
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncToJSON):
-2009-02-22 Geoffrey Garen <ggaren@apple.com>
+2009-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
- Next step in splitting JIT functionality out of the Interpreter class:
- Created a JITStubs class and renamed Interpreter::cti_* to JITStubs::cti_*.
-
- Also, moved timeout checking into its own class, located in JSGlobalData,
- so both the Interpreter and the JIT could have access to it.
+ Bug 26594: JSC needs to support Date.toISOString
+ <https://bugs.webkit.org/show_bug.cgi?id=26594>
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * interpreter/CallFrame.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::privateExecute):
- * interpreter/Interpreter.h:
- * interpreter/Register.h:
- * jit/JIT.cpp:
- (JSC::):
- (JSC::JIT::emitTimeoutCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArithSlow_op_lshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_bitand):
- (JSC::JIT::compileFastArithSlow_op_mod):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArithSlow_op_post_inc):
- (JSC::JIT::compileFastArithSlow_op_post_dec):
- (JSC::JIT::compileFastArithSlow_op_pre_inc):
- (JSC::JIT::compileFastArithSlow_op_pre_dec):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArith_op_sub):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::compileFastArithSlow_op_add):
- (JSC::JIT::compileFastArithSlow_op_mul):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * jit/JITStubs.cpp:
- (JSC::JITStubs::tryCachePutByID):
- (JSC::JITStubs::tryCacheGetByID):
- (JSC::JITStubs::cti_op_convert_this):
- (JSC::JITStubs::cti_op_end):
- (JSC::JITStubs::cti_op_add):
- (JSC::JITStubs::cti_op_pre_inc):
- (JSC::JITStubs::cti_timeout_check):
- (JSC::JITStubs::cti_register_file_check):
- (JSC::JITStubs::cti_op_loop_if_less):
- (JSC::JITStubs::cti_op_loop_if_lesseq):
- (JSC::JITStubs::cti_op_new_object):
- (JSC::JITStubs::cti_op_put_by_id_generic):
- (JSC::JITStubs::cti_op_get_by_id_generic):
- (JSC::JITStubs::cti_op_put_by_id):
- (JSC::JITStubs::cti_op_put_by_id_second):
- (JSC::JITStubs::cti_op_put_by_id_fail):
- (JSC::JITStubs::cti_op_get_by_id):
- (JSC::JITStubs::cti_op_get_by_id_second):
- (JSC::JITStubs::cti_op_get_by_id_self_fail):
- (JSC::JITStubs::cti_op_get_by_id_proto_list):
- (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
- (JSC::JITStubs::cti_op_get_by_id_proto_fail):
- (JSC::JITStubs::cti_op_get_by_id_array_fail):
- (JSC::JITStubs::cti_op_get_by_id_string_fail):
- (JSC::JITStubs::cti_op_instanceof):
- (JSC::JITStubs::cti_op_del_by_id):
- (JSC::JITStubs::cti_op_mul):
- (JSC::JITStubs::cti_op_new_func):
- (JSC::JITStubs::cti_op_call_JSFunction):
- (JSC::JITStubs::cti_op_call_arityCheck):
- (JSC::JITStubs::cti_vm_dontLazyLinkCall):
- (JSC::JITStubs::cti_vm_lazyLinkCall):
- (JSC::JITStubs::cti_op_push_activation):
- (JSC::JITStubs::cti_op_call_NotJSFunction):
- (JSC::JITStubs::cti_op_create_arguments):
- (JSC::JITStubs::cti_op_create_arguments_no_params):
- (JSC::JITStubs::cti_op_tear_off_activation):
- (JSC::JITStubs::cti_op_tear_off_arguments):
- (JSC::JITStubs::cti_op_profile_will_call):
- (JSC::JITStubs::cti_op_profile_did_call):
- (JSC::JITStubs::cti_op_ret_scopeChain):
- (JSC::JITStubs::cti_op_new_array):
- (JSC::JITStubs::cti_op_resolve):
- (JSC::JITStubs::cti_op_construct_JSConstruct):
- (JSC::JITStubs::cti_op_construct_NotJSConstruct):
- (JSC::JITStubs::cti_op_get_by_val):
- (JSC::JITStubs::cti_op_get_by_val_byte_array):
- (JSC::JITStubs::cti_op_resolve_func):
- (JSC::JITStubs::cti_op_sub):
- (JSC::JITStubs::cti_op_put_by_val):
- (JSC::JITStubs::cti_op_put_by_val_array):
- (JSC::JITStubs::cti_op_put_by_val_byte_array):
- (JSC::JITStubs::cti_op_lesseq):
- (JSC::JITStubs::cti_op_loop_if_true):
- (JSC::JITStubs::cti_op_negate):
- (JSC::JITStubs::cti_op_resolve_base):
- (JSC::JITStubs::cti_op_resolve_skip):
- (JSC::JITStubs::cti_op_resolve_global):
- (JSC::JITStubs::cti_op_div):
- (JSC::JITStubs::cti_op_pre_dec):
- (JSC::JITStubs::cti_op_jless):
- (JSC::JITStubs::cti_op_not):
- (JSC::JITStubs::cti_op_jtrue):
- (JSC::JITStubs::cti_op_post_inc):
- (JSC::JITStubs::cti_op_eq):
- (JSC::JITStubs::cti_op_lshift):
- (JSC::JITStubs::cti_op_bitand):
- (JSC::JITStubs::cti_op_rshift):
- (JSC::JITStubs::cti_op_bitnot):
- (JSC::JITStubs::cti_op_resolve_with_base):
- (JSC::JITStubs::cti_op_new_func_exp):
- (JSC::JITStubs::cti_op_mod):
- (JSC::JITStubs::cti_op_less):
- (JSC::JITStubs::cti_op_neq):
- (JSC::JITStubs::cti_op_post_dec):
- (JSC::JITStubs::cti_op_urshift):
- (JSC::JITStubs::cti_op_bitxor):
- (JSC::JITStubs::cti_op_new_regexp):
- (JSC::JITStubs::cti_op_bitor):
- (JSC::JITStubs::cti_op_call_eval):
- (JSC::JITStubs::cti_op_throw):
- (JSC::JITStubs::cti_op_get_pnames):
- (JSC::JITStubs::cti_op_next_pname):
- (JSC::JITStubs::cti_op_push_scope):
- (JSC::JITStubs::cti_op_pop_scope):
- (JSC::JITStubs::cti_op_typeof):
- (JSC::JITStubs::cti_op_is_undefined):
- (JSC::JITStubs::cti_op_is_boolean):
- (JSC::JITStubs::cti_op_is_number):
- (JSC::JITStubs::cti_op_is_string):
- (JSC::JITStubs::cti_op_is_object):
- (JSC::JITStubs::cti_op_is_function):
- (JSC::JITStubs::cti_op_stricteq):
- (JSC::JITStubs::cti_op_nstricteq):
- (JSC::JITStubs::cti_op_to_jsnumber):
- (JSC::JITStubs::cti_op_in):
- (JSC::JITStubs::cti_op_push_new_scope):
- (JSC::JITStubs::cti_op_jmp_scopes):
- (JSC::JITStubs::cti_op_put_by_index):
- (JSC::JITStubs::cti_op_switch_imm):
- (JSC::JITStubs::cti_op_switch_char):
- (JSC::JITStubs::cti_op_switch_string):
- (JSC::JITStubs::cti_op_del_by_val):
- (JSC::JITStubs::cti_op_put_getter):
- (JSC::JITStubs::cti_op_put_setter):
- (JSC::JITStubs::cti_op_new_error):
- (JSC::JITStubs::cti_op_debug):
- (JSC::JITStubs::cti_vm_throw):
- * jit/JITStubs.h:
- (JSC::):
- * runtime/JSFunction.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSGlobalData.h:
- * runtime/JSGlobalObject.cpp:
- * runtime/JSGlobalObject.h:
- * runtime/TimeoutChecker.cpp: Copied from interpreter/Interpreter.cpp.
- (JSC::TimeoutChecker::TimeoutChecker):
- (JSC::TimeoutChecker::reset):
- (JSC::TimeoutChecker::didTimeOut):
- * runtime/TimeoutChecker.h: Copied from interpreter/Interpreter.h.
- (JSC::TimeoutChecker::setTimeoutInterval):
- (JSC::TimeoutChecker::ticksUntilNextCheck):
- (JSC::TimeoutChecker::start):
- (JSC::TimeoutChecker::stop):
-
-2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed build fix after r41100.
-
- * GNUmakefile.am:
+ Add support for Date.toISOString.
-2009-02-20 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6606660> 2==null returns true in 64bit jit
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncToISOString):
- Code for op_eq_null and op_neq_null was incorrectly performing
- a 32bit compare, which truncated the type tag from an integer
- immediate, leading to incorrect behaviour.
+2009-06-21 Oliver Hunt <oliver@apple.com>
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::setPtr):
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::setPtr):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
+ Reviewed by NOBODY (Build fix).
-2009-02-19 Geoffrey Garen <ggaren@apple.com>
+ Remove dead code.
- Reviewed by Gavin Barraclough.
-
- First step in splitting JIT functionality out of the Interpreter class:
- Created JITStubs.h/.cpp, and moved Interpreter::cti_* into JITStubs.cpp.
-
- Functions that the Interpreter and JITStubs share moved to Operations.h/.cpp.
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::parse):
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::resolveBase):
- (JSC::Interpreter::checkTimeout):
- (JSC::Interpreter::privateExecute):
- * interpreter/Interpreter.h:
- * jit/JITStubs.cpp: Copied from interpreter/Interpreter.cpp.
- (JSC::Interpreter::cti_op_resolve_base):
- * jit/JITStubs.h: Copied from interpreter/Interpreter.h.
- * runtime/Operations.cpp:
- (JSC::jsAddSlowCase):
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::jsIsFunctionType):
- * runtime/Operations.h:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAdd):
- (JSC::cachePrototypeChain):
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::resolveBase):
-
-2009-02-19 Gavin Barraclough <barraclough@apple.com>
+2009-06-21 Oliver Hunt <oliver@apple.com>
- Reviewed by Oliver Hunt.
+ Reviewed by Darin Adler and Cameron Zwarich.
- Fix for x86-64. Where the JavaScriptCore text segment lies outside
- a 2gb range of the heap containing JIT generated code, callbacks
- from JIT code to the stub functions in Interpreter will be incorrectly
- linked.
+ Bug 26587: Support JSON.parse
+ <https://bugs.webkit.org/show_bug.cgi?id=26587>
- No performance impact on Sunspider, 1% regression on v8-tests,
- due to a 3% regression on richards.
+ Extend the LiteralParser to support the full strict JSON
+ grammar, fix a few places where the grammar was incorrectly
+ lenient. Doesn't yet support the JSON.parse reviver function
+ but that does not block the JSON.parse functionality itself.
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::Call::Call):
- (JSC::AbstractMacroAssembler::Jump::link):
- (JSC::AbstractMacroAssembler::Jump::linkTo):
- (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
- (JSC::AbstractMacroAssembler::differenceBetween):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::tailRecursiveCall):
- (JSC::MacroAssembler::makeTailRecursiveCall):
- * assembler/MacroAssemblerX86.h:
- (JSC::MacroAssemblerX86::call):
- * assembler/MacroAssemblerX86Common.h:
- * assembler/MacroAssemblerX86_64.h:
- (JSC::MacroAssemblerX86_64::call):
- (JSC::MacroAssemblerX86_64::moveWithPatch):
- (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
- (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::jmp_r):
- (JSC::X86Assembler::linkJump):
- (JSC::X86Assembler::patchJump):
- (JSC::X86Assembler::patchCall):
- (JSC::X86Assembler::linkCall):
- (JSC::X86Assembler::patchAddress):
* interpreter/Interpreter.cpp:
- (JSC::Interpreter::tryCTICachePutByID):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompilePutByIdReplace):
+ (JSC::Interpreter::callEval):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ * runtime/JSONObject.cpp:
+ (JSC::JSONProtoFuncParse):
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::Lexer::lex):
+ (JSC::isSafeStringCharacter):
+ (JSC::LiteralParser::Lexer::lexString):
+ (JSC::LiteralParser::parse):
+ * runtime/LiteralParser.h:
+ (JSC::LiteralParser::LiteralParser):
+ (JSC::LiteralParser::tryJSONParse):
+ (JSC::LiteralParser::):
+ (JSC::LiteralParser::Lexer::Lexer):
-2009-02-18 Geoffrey Garen <ggaren@apple.com>
+2009-06-21 David Levin <levin@chromium.org>
- Reviewed by Oliver Hunt.
-
- Simplified .call and .apply in preparation for optimizing them. Also,
- a little cleanup.
+ Reviewed by NOBODY (speculative build fix for windows).
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall): No need to do any specific conversion on
- 'this' -- op_convert_this will do it if necessary.
+ Simply removed some whitespace form this file to make windows build wtf and
+ hopefully copy the new MessageQueque.h so that WebCore picks it up.
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject): Slightly relaxed the rules on
- toThisObject to allow for 'undefined', which can be passed through
- .call and .apply.
+ * wtf/Assertions.cpp:
-2009-02-19 David Levin <levin@chromium.org>
+2009-06-21 Drew Wilson <atwilson@google.com>
- Reviewed by Alexey Proskuryakov.
+ Reviewed by David Levin.
- Bug 23976: MessageQueue needs a way to wait for a message that satisfies an arbitrary criteria.
- <https://bugs.webkit.org/show_bug.cgi?id=23976>
+ <https://bugs.webkit.org/show_bug.cgi?id=25043>
+ Added support for multi-threaded MessagePorts.
- * wtf/Deque.h:
- (WTF::Deque<T>::findIf):
* wtf/MessageQueue.h:
- (WTF::MessageQueue<T>::waitForMessageFiltered):
-
-2009-02-18 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23974: Deque::Remove would be a useful method.
- <https://bugs.webkit.org/show_bug.cgi?id=23974>
-
- Add Deque::remove and DequeIteratorBase<T>::operator=.
-
- Why was operator= added? Every concrete iterator (DequeIterator..DequeConstReverseIterator)
- was calling DequeIteratorBase::assign(), which called Base::operator=(). Base::operator=()
- was not implemented. This went unnoticed because the iterator copy code has been unused.
-
- * wtf/Deque.h:
- (WTF::Deque<T>::remove):
- (WTF::DequeIteratorBase<T>::removeFromIteratorsList):
- (WTF::DequeIteratorBase<T>::operator=):
- (WTF::DequeIteratorBase<T>::~DequeIteratorBase):
-
-2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Fix symbols.filter location, and add other missing files to the
- autotools build, so that make dist works.
-
- * GNUmakefile.am:
-
-2009-02-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
- bot.
-
- Technically, both behaviors are OK, but we might as well keep this test
- passing.
-
- * runtime/FunctionPrototype.cpp:
- (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon
- after a trailing '}', since '}' ends a block, indicating the end of a
- statement.
-
-2009-02-17 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * runtime/FunctionPrototype.cpp:
-
-2009-02-17 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Add assertion to guard against oversized pc relative calls.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::link):
-
-2009-02-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
- fails to load.
-
- amnestyusa.org uses the Optimist JavaScript library, which adds event
- listeners by concatenating string-ified functions. This is only sure to
- be syntactically valid if the string-ified functions end in semicolons.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::isWhiteSpace):
- * parser/Lexer.h:
- (JSC::Lexer::isWhiteSpace):
- (JSC::Lexer::isLineTerminator): Added some helper functions for examining
- whitespace.
-
- * runtime/FunctionPrototype.cpp:
- (JSC::appendSemicolonIfNeeded):
- (JSC::functionProtoFuncToString): When string-ifying a function, insert
- a semicolon in the last non-whitespace position, if one doesn't already exist.
-
-2009-02-16 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Roll out r41022 as it breaks qt and gtk builds
-
- * jit/JITArithmetic.cpp:
- (JSC::isSSE2Present):
-
-2009-02-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for <rdar://problem/6468156>
- REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)
-
- No performance regression.
-
- * runtime/Arguments.cpp:
- (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been
- overridden.
+ (WTF::::appendAndCheckEmpty):
+ Added API to test whether the queue was empty before adding an element.
+
+2009-06-20 David D. Kilzer <ddkilzer@webkit.org>
-2009-02-16 Mark Rowe <mrowe@apple.com>
+ Fix namespace comment in SegmentedVector.h
- Build fix.
+ * wtf/SegmentedVector.h: Updated namespace comment to reflect
+ new namespace after r44897.
- * wtf/FastMalloc.cpp:
- (WTF::TCMallocStats::):
- (WTF::TCMallocStats::FastMallocZone::FastMallocZone):
+2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
-2009-02-16 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+ Bug 24986: ARM JIT port
+ <https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
- Bug 23787: Allow JIT to generate SSE2 code if using GCC
- <https://bugs.webkit.org/show_bug.cgi?id=23787>
-
- GCC version of the cpuid check.
-
- * jit/JITArithmetic.cpp:
- (JSC::isSSE2Present): GCC assembly code added.
- 6.6% progression on x86 Linux with JIT and WREC on SunSpider if using SSE2 capable machine.
-
-2009-02-13 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=23960
- Crash Fix.
-
- Don't depend on 'initializeThreading()' to come before a call to 'isMainThread()'
- as QtWebKit only calls 'initializeThreading()' during QWebPage construction.
-
- A client app may well make a call to QWebSettings::iconForUrl() for instance
- before creating a QWebPage and that call to QWebSettings triggers an
- ASSERT(isMainThread()) deep within WebCore.
+ An Iterator added for SegmentedVector. Currently
+ only the pre ++ operator is supported.
- * wtf/ThreadingQt.cpp:
- (WTF::isMainThread):
+ * wtf/SegmentedVector.h:
+ (WTF::SegmentedVectorIterator::~SegmentedVectorIterator):
+ (WTF::SegmentedVectorIterator::operator*):
+ (WTF::SegmentedVectorIterator::operator->):
+ (WTF::SegmentedVectorIterator::operator++):
+ (WTF::SegmentedVectorIterator::operator==):
+ (WTF::SegmentedVectorIterator::operator!=):
+ (WTF::SegmentedVectorIterator::operator=):
+ (WTF::SegmentedVectorIterator::SegmentedVectorIterator):
+ (WTF::SegmentedVector::alloc):
+ (WTF::SegmentedVector::begin):
+ (WTF::SegmentedVector::end):
-2009-02-13 Gavin Barraclough <barraclough@apple.com>
+2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
- Reviewed by Darin Adler.
-
- Some data in the instruction stream is potentially uninitialized - fix this.
-
- Change the OperandTypes constructor so that uninitialized memory in the int
- is zeroed, and modify the Instruction constructor taking an Opcode so that
- if !HAVE(COMPUTED_GOTO) (i.e. when Opcode is an enum, and is potentially only
- a byte) it zeros the Instruction first before writing the opcode.
-
- * bytecode/Instruction.h:
- (JSC::Instruction::Instruction):
- * parser/ResultType.h:
- (JSC::OperandTypes::OperandTypes):
-
-2009-02-13 Geoffrey Garen <ggaren@apple.com>
-
- Build fix for non_JIT platforms.
-
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::setIsNumericCompareFunction):
- (JSC::CodeBlock::isNumericCompareFunction):
-
-2009-02-13 Geoffrey Garen <ggaren@apple.com>
+ Bug 24986: ARM JIT port
+ <https://bugs.webkit.org/show_bug.cgi?id=24986>
- Reviewed by Darin Adler.
-
- Fixed <rdar://problem/6584057> Optimize sort by JS numeric comparison
- function not to run the comparison function
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::CodeBlock):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::setIsNumericCompareFunction):
- (JSC::CodeBlock::isNumericCompareFunction): Added the ability to track
- whether a CodeBlock performs a sort-like numeric comparison.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate): Set the isNumericCompareFunction bit
- after compiling.
-
- * parser/Nodes.cpp:
- (JSC::FunctionBodyNode::emitBytecode): Fixed a bug that caused us to
- codegen an extra return at the end of all functions (eek!), since this
- made it harder / weirder to detect the numeric comparison pattern in
- bytecode.
-
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncSort): Use the isNumericCompareFunction bit to do
- a faster sort if we can.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::extractFunctionBody):
- (JSC::constructFunction):
- * runtime/FunctionConstructor.h: Renamed and exported extractFunctionBody for
- use in initializing lazyNumericCompareFunction.
-
- * runtime/JSArray.cpp:
- (JSC::compareNumbersForQSort):
- (JSC::compareByStringPairForQSort):
- (JSC::JSArray::sortNumeric):
- (JSC::JSArray::sort):
- * runtime/JSArray.h: Added a fast numeric sort. Renamed ArrayQSortPair
- to be more specific since we do different kinds of qsort now.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::numericCompareFunction):
- (JSC::JSGlobalData::ClientData::~ClientData):
- * runtime/JSGlobalData.h: Added helper data for computing the
- isNumericCompareFunction bit.
-
-2009-02-13 Darin Adler <darin@apple.com>
-
- * Configurations/JavaScriptCore.xcconfig: Undo accidental commit of this file.
-
-2009-02-12 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt and Alexey Proskuryakov.
-
- Speed up a couple string functions.
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncIndexOf): Added a fast path for cases where the second
- argument is either missing or an integer.
- (JSC::stringProtoFuncBig): Use jsNontrivialString since the string is guaranteed
- to be 2 or more characters long.
- (JSC::stringProtoFuncSmall): Ditto.
- (JSC::stringProtoFuncBlink): Ditto.
- (JSC::stringProtoFuncBold): Ditto.
- (JSC::stringProtoFuncItalics): Ditto.
- (JSC::stringProtoFuncStrike): Ditto.
- (JSC::stringProtoFuncSub): Ditto.
- (JSC::stringProtoFuncSup): Ditto.
- (JSC::stringProtoFuncFontcolor): Ditto.
- (JSC::stringProtoFuncFontsize): Make the fast path Sam recently added even faster
- by avoiding all but the minimum memory allocation.
- (JSC::stringProtoFuncAnchor): Use jsNontrivialString.
- (JSC::stringProtoFuncLink): Added a fast path.
-
- * runtime/UString.cpp:
- (JSC::UString::find): Added a fast path for single-character search strings.
-
-2009-02-13 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Bug 23926: Race condition in callOnMainThreadAndWait
- <https://bugs.webkit.org/show_bug.cgi?id=23926>
-
- * wtf/MainThread.cpp:
- Removed callOnMainThreadAndWait since it isn't used.
-
-2009-02-13 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Jon Honeycutt.
-
- Math.random is really slow on windows.
-
- Math.random calls WTF::randomNumber which is implemented as
- the secure rand_s on windows. Unfortunately rand_s is an order
- of magnitude slower than arc4random. For this reason I've
- added "weakRandomNumber" for use by JavaScript's Math Object.
- In the long term we should look at using our own secure PRNG
- in place of the system, but this will do for now.
-
- 30% win on SunSpider on Windows, resolving most of the remaining
- disparity vs. Mac.
-
- * runtime/MathObject.cpp:
- (JSC::MathObject::MathObject):
- (JSC::mathProtoFuncRandom):
- * wtf/RandomNumber.cpp:
- (WTF::weakRandomNumber):
- (WTF::randomNumber):
- * wtf/RandomNumber.h:
- * wtf/RandomNumberSeed.h:
- (WTF::initializeWeakRandomNumberGenerator):
-
-2009-02-12 Mark Rowe <mrowe@apple.com>
-
- Fix the build for other platforms.
+ Reviewed by Oliver Hunt.
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
+ Move SegmentedVector to /wtf subdirectory
+ and change "namespace JSC" to "namespace WTF"
-2009-02-12 Gavin Barraclough <barraclough@apple.com>
+ Additional build file updates by David Kilzer.
- Reviewed by Sam Weinig.
+ * GNUmakefile.am: Updated path to SegmentedVector.h.
+ * JavaScriptCore.order: Updated SegmentedVector namespace from
+ JSC to WTF in mangled C++ method name.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ Removed reference to bytecompiler\SegmentedVector.h.
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to
+ wtf\SegmentedVector.h.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Moved
+ SegmentedVector.h definition from bytecompiler subdirectory to
+ wtf subdirectory.
+ * bytecompiler/BytecodeGenerator.h: Updated #include path to
+ SegmentedVector.h and prepended WTF:: namespace to its use.
+ * parser/Lexer.h: Ditto.
+ * wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h.
+ (WTF::SegmentedVector::SegmentedVector):
+ (WTF::SegmentedVector::~SegmentedVector):
+ (WTF::SegmentedVector::size):
+ (WTF::SegmentedVector::at):
+ (WTF::SegmentedVector::operator[]):
+ (WTF::SegmentedVector::last):
+ (WTF::SegmentedVector::append):
+ (WTF::SegmentedVector::removeLast):
+ (WTF::SegmentedVector::grow):
+ (WTF::SegmentedVector::clear):
+ (WTF::SegmentedVector::deleteAllSegments):
+ (WTF::SegmentedVector::segmentExistsFor):
+ (WTF::SegmentedVector::segmentFor):
+ (WTF::SegmentedVector::subscriptFor):
+ (WTF::SegmentedVector::ensureSegmentsFor):
+ (WTF::SegmentedVector::ensureSegment):
- Remove (/reduce) use of hard-wired register names from the JIT.
- Currently there is no abstraction of registers used in the JIT,
- which has a number of negative consequences. Hard-wiring x86
- register names makes the JIT less portable to other platforms,
- and prevents us from performing dynamic register allocation to
- attempt to maintain more temporary values in machine registers.
- (The latter will be more important on x86-64, where we have more
- registers to make use of).
+2009-06-19 Gavin Barraclough <barraclough@apple.com>
- Also, remove MacroAssembler::mod32. This was not providing a
- useful abstraction, and was not in keeping with the rest of the
- MacroAssembler interface, in having specific register requirements.
+ Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).
- * assembler/MacroAssemblerX86Common.h:
* jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::emitGetVariableObjectRegister):
+ (JSC::JIT::emitPutVariableObjectRegister):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_lshift):
- (JSC::JIT::compileFastArithSlow_op_lshift):
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- (JSC::JIT::compileFastArith_op_bitand):
- (JSC::JIT::compileFastArithSlow_op_bitand):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArithSlow_op_mod):
- (JSC::JIT::compileFastArith_op_post_inc):
- (JSC::JIT::compileFastArithSlow_op_post_inc):
- (JSC::JIT::compileFastArith_op_post_dec):
- (JSC::JIT::compileFastArithSlow_op_post_dec):
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileFastArithSlow_op_pre_inc):
- (JSC::JIT::compileFastArith_op_pre_dec):
- (JSC::JIT::compileFastArithSlow_op_pre_dec):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::emit_op_rshift):
+ (JSC::JIT::emitSlow_op_jnless):
+ (JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::compileBinaryArithOp):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCallEvalSetupArgs):
- (JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::emitPutVirtualRegister):
- (JSC::JIT::emitNakedCall):
(JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
-
-2009-02-12 Horia Olaru <olaru@adobe.com>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23400
-
- When throwing an exception within an eval argument string, the dst parameter was
- modified in the functions below and the return value for eval was altered. Changed
- the emitNode call in JSC::ThrowNode::emitBytecode to use a temporary register
- to store its results instead of dst. The JSC::FunctionCallResolveNode::emitBytecode
- would load the function within the dst registry, also altering the result returned
- by eval. Replaced it with another temporary.
-
- * parser/Nodes.cpp:
- (JSC::FunctionCallResolveNode::emitBytecode):
- (JSC::ThrowNode::emitBytecode):
-
-2009-02-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Speed up String.prototype.fontsize.
-
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncFontsize): Specialize for defined/commonly used values.
-
-2009-02-12 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Correctness fix.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber): Divide by the maximum representable value, which
- is different on each platform now, to get values between 0 and 1.
-
-2009-02-12 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
-
-2009-02-12 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed <rdar://problem/6582048>.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber): Make only one call to the random number generator
- on platforms where the generator is cryptographically secure. The value
- of randomness over and above cryptographically secure randomness is not
- clear, and it caused some performance problems.
-
-2009-02-12 Adam Roben <aroben@apple.com>
-
- Fix lots of Perl warnings when building JavaScriptCoreGenerated on
- Windows
-
- Reviewed by John Sullivan.
-
- * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- Create the docs/ directory so that we can write bytecode.html into it.
- This matches what JavaScriptCore.xcodeproj does.
-
-2009-02-12 Simon Hausmann <simon.hausmann@nokia.com>
-
- Rubber-stamped by Lars.
-
- Re-enable the JIT in the Qt build with -fno-stack-protector on Linux.
-
- * JavaScriptCore.pri:
-
-2009-02-11 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23705
- Fix the UI freeze caused by Worker generating a flood of messages.
- Measure time we spend in executing posted work items. If too much time is spent
- without returning to the run loop, exit and reschedule.
-
- * wtf/MainThread.h:
- Added initializeMainThreadPlatform() to initialize low-level mechanism for posting
- work items from thread to thread. This removes #ifdefs for WIN and CHROMIUM from platform-independent code.
-
- * wtf/MainThread.cpp:
- (WTF::initializeMainThread):
- (WTF::dispatchFunctionsFromMainThread):
- Instead of dispatching all work items in the queue, dispatch them one by one
- and measure elapsed time. After a threshold, reschedule and quit.
-
- (WTF::callOnMainThread):
- (WTF::callOnMainThreadAndWait):
- Only schedule dispatch if the queue was empty - to avoid many posted messages in the run loop queue.
-
- * wtf/mac/MainThreadMac.mm:
- (WTF::scheduleDispatchFunctionsOnMainThread):
- Use static instance of the mainThreadCaller instead of allocating and releasing it each time.
- (WTF::initializeMainThreadPlatform):
- * wtf/gtk/MainThreadChromium.cpp:
- (WTF::initializeMainThreadPlatform):
- * wtf/gtk/MainThreadGtk.cpp:
- (WTF::initializeMainThreadPlatform):
- * wtf/qt/MainThreadQt.cpp:
- (WTF::initializeMainThreadPlatform):
- * wtf/win/MainThreadWin.cpp:
- (WTF::initializeMainThreadPlatform):
- * wtf/wx/MainThreadWx.cpp:
- (WTF::initializeMainThreadPlatform):
-
-2009-02-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Style cleanup.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
- (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
- (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
- (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
- (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::::CodeLocationCommon::labelAtOffset):
- (JSC::::CodeLocationCommon::jumpAtOffset):
- (JSC::::CodeLocationCommon::callAtOffset):
- (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
- (JSC::::CodeLocationCommon::dataLabel32AtOffset):
-
-2009-02-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- * assembler/AbstractMacroAssembler.h: Fix comments.
-
-2009-02-11 Alexey Proskuryakov <ap@webkit.org>
-
- Trying to fix wx build.
-
- * bytecode/JumpTable.h: Include "MacroAssembler.h", not <MacroAssembler.h>.
- * jscore.bkl: Added assembler directory to search paths.
-
-2009-02-10 Gavin Barraclough <barraclough@apple.com>
-
- Build
- fix.
- (Narrow
- changelog
- for
- dhyatt).
-
- * bytecode/Instruction.h:
- (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
- (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
-
-2009-02-10 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Reduce use of void* / reinterpret_cast in JIT repatching code,
- add strong types for Calls and for the various types of pointers
- we retain into the JIT generated instruction stream.
-
- No performance impact.
-
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
- (JSC::AbstractMacroAssembler::ImmPtr::asIntptr):
- (JSC::AbstractMacroAssembler::Imm32::Imm32):
- (JSC::AbstractMacroAssembler::Label::Label):
- (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
- (JSC::AbstractMacroAssembler::Call::Call):
- (JSC::AbstractMacroAssembler::Call::link):
- (JSC::AbstractMacroAssembler::Call::linkTo):
- (JSC::AbstractMacroAssembler::Jump::Jump):
- (JSC::AbstractMacroAssembler::Jump::linkTo):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
- (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
- (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
- (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
- (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
- (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
- (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
- (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
- (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
- (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- (JSC::AbstractMacroAssembler::PatchBuffer::trampolineAt):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
- (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- (JSC::AbstractMacroAssembler::PatchBuffer::locationOf):
- (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
- (JSC::AbstractMacroAssembler::differenceBetween):
- (JSC::::CodeLocationCommon::labelAtOffset):
- (JSC::::CodeLocationCommon::jumpAtOffset):
- (JSC::::CodeLocationCommon::callAtOffset):
- (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
- (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- * assembler/MacroAssemblerX86Common.h:
- (JSC::MacroAssemblerX86Common::call):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::getCallReturnOffset):
- * bytecode/CodeBlock.h:
- (JSC::CallLinkInfo::CallLinkInfo):
- (JSC::getStructureStubInfoReturnLocation):
- (JSC::getCallLinkInfoReturnLocation):
- * bytecode/Instruction.h:
- (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
- (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- * bytecode/JumpTable.h:
- (JSC::StringJumpTable::ctiForValue):
- (JSC::SimpleJumpTable::ctiForValue):
- * bytecode/StructureStubInfo.h:
- (JSC::StructureStubInfo::StructureStubInfo):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitCatch):
- (JSC::prepareJumpTableForStringSwitch):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::getPolymorphicAccessStructureListSlot):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_vm_throw):
- * jit/JIT.cpp:
- (JSC::ctiSetReturnAddress):
- (JSC::ctiPatchCallByReturnAddress):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JIT::compileGetByIdSelf):
- (JSC::JIT::compileGetByIdProto):
- (JSC::JIT::compileGetByIdChain):
- (JSC::JIT::compilePutByIdReplace):
- (JSC::JIT::compilePutByIdTransition):
- (JSC::JIT::compilePatchGetArrayLength):
- (JSC::JIT::emitCTICall):
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::linkCall):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::emitCTICall_internal):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
-
-2009-02-10 Adam Roben <aroben@apple.com>
-
- Windows build fix after r40813
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added profiler/ to the include
- path so that Profiler.h can be found.
-
-2009-02-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Provide a class type for a generated block of JIT code.
- Also changes the return address -> bytecode index map to
- track the return addess as an unsigned offset into the code
- instead of a ptrdiff_t in terms of void**s - the latter is
- equal to the actual offset / sizeof(void*), making it a
- potentially lossy representation.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/AbstractMacroAssembler.h:
- (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::getCallReturnOffset):
- * bytecode/CodeBlock.h:
- (JSC::CallReturnOffsetToBytecodeIndex::CallReturnOffsetToBytecodeIndex):
- (JSC::getCallReturnOffset):
- (JSC::CodeBlock::getBytecodeIndex):
- (JSC::CodeBlock::jitCode):
- (JSC::CodeBlock::callReturnIndexVector):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- (JSC::):
- * jit/JITCall.cpp:
- (JSC::JIT::linkCall):
- * jit/JITCode.h: Added.
- (JSC::):
- (JSC::JITCode::JITCode):
- (JSC::JITCode::operator bool):
- (JSC::JITCode::addressForCall):
- (JSC::JITCode::offsetOf):
- (JSC::JITCode::execute):
-
-2009-02-09 John Grabowski <jrg@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23856
- Change the definition of "main thread" for Chromium on OSX.
- It does not match the DARWIN definition.
-
- * wtf/ThreadingPthreads.cpp:
- (WTF::initializeThreading):
- (WTF::isMainThread):
-
-2009-02-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Minor bugfix, incorrect check meant that subtraction causing integer overflow
- would be missed on x86-64 JIT.
-
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOp):
-
-2009-02-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- A more sensible register allocation for x86-64.
-
- When WREC was ported to x86-64 it stuck with the same register allocation as x86.
- This requires registers to be reordered on entry into WREC generated code, since
- argument passing is different on x86-64 and x86 (regparm(3)). This patch switches
- x86-64 to use a native register allocation, that does not require argument registers
- to be reordered.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateReturnSuccess):
- (JSC::WREC::Generator::generateReturnFailure):
- * wrec/WRECGenerator.h:
-
-2009-02-05 Adam Roben <aroben@apple.com>
-
- Build fix
-
- Rubberstamped by Sam Weinig.
-
- * wtf/TypeTraits.h: Include Platform.h, since this header uses macros
- defined there.
-
-2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23747
- Add Chromium threading-related files.
-
- * wtf/MainThread.cpp: Added platform guard to initializeMainThread.
- * wtf/chromium/ChromiumThreading.h: Added.
- * wtf/chromium/MainThreadChromium.cpp: Added.
- (WTF::initializeMainThread):
- (WTF::scheduleDispatchFunctionsOnMainThread):
-
-2009-02-05 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
- <https://bugs.webkit.org/show_bug.cgi?id=23713>
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
-
- * wtf/HashTraits.h:
- Remove unnecessary header file that I missed when moving out the type traits form this file.
-
- * wtf/TypeTraits.cpp: Added.
- (WTF::):
- * wtf/TypeTraits.h:
- Moved the compile asserts into TypeTraits.cpp file.
-
-2009-02-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver 'the nun' Hunt.
-
- Add -e switch to jsc to enable evaluation of scripts passed on the command line.
-
- * jsc.cpp:
- (Script::Script):
- (runWithScripts):
- (printUsageStatement):
- (parseArguments):
- (jscmain):
-
-2009-02-04 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Sam 'Big Mac' Weinig.
-
- * assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
- * assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
- * assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
- * assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
-
-2009-02-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
- platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
- platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
- the plaform-specific code generation forming a big meaty patty of methods like 'add32',
- 'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
- MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
- and backwards branch methods, all of which can be described in a platform independent
- way using methods from the base class. The AbstractMacroAssembler is templated on the
- type of the assembler class that will be used for code generation, and the three layers
- are held together with the cocktail stick of inheritance.
-
- The above description is a slight simplification since the MacroAssemblerX86 is actually
- formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
- bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
- which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
- specific to the given platform).
-
- I'm landing these changes first without splitting the classes across multiple files,
- I will follow up with a second patch to split up the file MacroAssembler.h.
-
- * assembler/MacroAssembler.h:
- (JSC::AbstractMacroAssembler::):
- (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
- (JSC::AbstractMacroAssembler::DataLabelPtr::patch):
- (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32):
- (JSC::AbstractMacroAssembler::DataLabel32::patch):
- (JSC::AbstractMacroAssembler::Label::Label):
- (JSC::AbstractMacroAssembler::Jump::Jump):
- (JSC::AbstractMacroAssembler::Jump::link):
- (JSC::AbstractMacroAssembler::Jump::linkTo):
- (JSC::AbstractMacroAssembler::Jump::patch):
- (JSC::AbstractMacroAssembler::JumpList::link):
- (JSC::AbstractMacroAssembler::JumpList::linkTo):
- (JSC::AbstractMacroAssembler::PatchBuffer::link):
- (JSC::AbstractMacroAssembler::PatchBuffer::addressOf):
- (JSC::AbstractMacroAssembler::PatchBuffer::setPtr):
- (JSC::AbstractMacroAssembler::size):
- (JSC::AbstractMacroAssembler::copyCode):
- (JSC::AbstractMacroAssembler::label):
- (JSC::AbstractMacroAssembler::align):
- (JSC::AbstractMacroAssembler::differenceBetween):
- (JSC::MacroAssemblerX86Common::xor32):
- (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
- (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
- (JSC::MacroAssemblerX86Common::move):
- (JSC::MacroAssemblerX86Common::swap):
- (JSC::MacroAssemblerX86Common::signExtend32ToPtr):
- (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
- (JSC::MacroAssemblerX86Common::branch32):
- (JSC::MacroAssemblerX86Common::jump):
- (JSC::MacroAssemblerX86_64::add32):
- (JSC::MacroAssemblerX86_64::sub32):
- (JSC::MacroAssemblerX86_64::load32):
- (JSC::MacroAssemblerX86_64::store32):
- (JSC::MacroAssemblerX86_64::addPtr):
- (JSC::MacroAssemblerX86_64::andPtr):
- (JSC::MacroAssemblerX86_64::orPtr):
- (JSC::MacroAssemblerX86_64::rshiftPtr):
- (JSC::MacroAssemblerX86_64::subPtr):
- (JSC::MacroAssemblerX86_64::xorPtr):
- (JSC::MacroAssemblerX86_64::loadPtr):
- (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
- (JSC::MacroAssemblerX86_64::storePtr):
- (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
- (JSC::MacroAssemblerX86_64::branchPtr):
- (JSC::MacroAssemblerX86_64::branchTestPtr):
- (JSC::MacroAssemblerX86_64::branchAddPtr):
- (JSC::MacroAssemblerX86_64::branchSubPtr):
- (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
- (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- (JSC::MacroAssemblerX86::add32):
- (JSC::MacroAssemblerX86::sub32):
- (JSC::MacroAssemblerX86::load32):
- (JSC::MacroAssemblerX86::store32):
- (JSC::MacroAssemblerX86::branch32):
- (JSC::MacroAssemblerX86::branchPtrWithPatch):
- (JSC::MacroAssemblerX86::storePtrWithPatch):
- (JSC::MacroAssembler::pop):
- (JSC::MacroAssembler::peek):
- (JSC::MacroAssembler::poke):
- (JSC::MacroAssembler::branchPtr):
- (JSC::MacroAssembler::branch32):
- (JSC::MacroAssembler::branch16):
- (JSC::MacroAssembler::branchTestPtr):
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::andPtr):
- (JSC::MacroAssembler::orPtr):
- (JSC::MacroAssembler::rshiftPtr):
- (JSC::MacroAssembler::subPtr):
- (JSC::MacroAssembler::xorPtr):
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
- (JSC::MacroAssembler::branchAddPtr):
- (JSC::MacroAssembler::branchSubPtr):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOp):
-
-2009-02-04 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23681
- Worker tests crash in debug builds if run --singly
-
- The crash happened because worker threads continued running while debug-only static objects
- were already being destroyed on main thread.
-
- * runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get
- destroyed.
-
- * wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.
-
-2009-02-03 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=23715
-
- Simplify MacroAssembler interface, by combining comparison methods.
- Seprate operations are combined as follows:
- jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
- j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
- j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
- set*32 -> set32
-
- Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
- instead of as multiplicands (1,2,4,8).
-
- This patch singificantly reduces replication of code, and increases functionality supported
- by the MacroAssembler. No performance impact.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::):
- (JSC::MacroAssembler::branchPtr):
- (JSC::MacroAssembler::branchPtrWithPatch):
- (JSC::MacroAssembler::branch32):
- (JSC::MacroAssembler::branch16):
- (JSC::MacroAssembler::branchTestPtr):
- (JSC::MacroAssembler::branchTest32):
- (JSC::MacroAssembler::branchAddPtr):
- (JSC::MacroAssembler::branchAdd32):
- (JSC::MacroAssembler::branchMul32):
- (JSC::MacroAssembler::branchSubPtr):
- (JSC::MacroAssembler::branchSub32):
- (JSC::MacroAssembler::set32):
- (JSC::MacroAssembler::setTest32):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::jccRel32):
- (JSC::X86Assembler::setccOpcode):
- (JSC::X86Assembler::cmpq_mr):
- (JSC::X86Assembler::setcc_r):
- (JSC::X86Assembler::sete_r):
- (JSC::X86Assembler::setne_r):
- (JSC::X86Assembler::jne):
- (JSC::X86Assembler::je):
- (JSC::X86Assembler::jl):
- (JSC::X86Assembler::jb):
- (JSC::X86Assembler::jle):
- (JSC::X86Assembler::jbe):
- (JSC::X86Assembler::jge):
- (JSC::X86Assembler::jg):
- (JSC::X86Assembler::ja):
- (JSC::X86Assembler::jae):
- (JSC::X86Assembler::jo):
- (JSC::X86Assembler::jp):
- (JSC::X86Assembler::js):
- (JSC::X86Assembler::jcc):
- (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_lshift):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArith_op_post_inc):
- (JSC::JIT::compileFastArith_op_post_dec):
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileFastArith_op_pre_dec):
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITInlineMethods.h:
(JSC::JIT::checkStructure):
- (JSC::JIT::emitJumpIfJSCell):
- (JSC::JIT::emitJumpIfNotJSCell):
- (JSC::JIT::emitJumpIfImmediateNumber):
- (JSC::JIT::emitJumpIfNotImmediateNumber):
- (JSC::JIT::emitJumpIfImmediateInteger):
- (JSC::JIT::emitJumpIfNotImmediateInteger):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- * jit/JITPropertyAccess.cpp:
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_instanceof):
+ (JSC::JIT::emit_op_get_scoped_var):
+ (JSC::JIT::emit_op_put_scoped_var):
+ (JSC::JIT::emit_op_construct_verify):
+ (JSC::JIT::emit_op_resolve_global):
+ (JSC::JIT::emit_op_jeq_null):
+ (JSC::JIT::emit_op_jneq_null):
+ (JSC::JIT::emit_op_to_jsnumber):
+ (JSC::JIT::emit_op_catch):
+ (JSC::JIT::emit_op_eq_null):
+ (JSC::JIT::emit_op_neq_null):
+ (JSC::JIT::emit_op_convert_this):
+ (JSC::JIT::emit_op_profile_will_call):
+ (JSC::JIT::emit_op_profile_did_call):
+ (JSC::JIT::emitSlow_op_get_by_val):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::emit_op_get_by_val):
+ (JSC::JIT::emit_op_put_by_val):
+ (JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::emit_op_put_by_id):
+ (JSC::JIT::compilePutDirectOffset):
+ (JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- * runtime/RegExp.cpp:
- (JSC::RegExp::match):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateIncrementIndex):
- (JSC::WREC::Generator::generateLoadCharacter):
- (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
- (JSC::WREC::Generator::generateBackreferenceQuantifier):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacterPair):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::generateBackreference):
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
- when shrinking down from a size that was greater than the inline capacity.
-
- Reviewed by Maciej
-
- * wtf/Vector.h:
- (WTF::VectorBuffer::VectorBuffer):
- (WTF::VectorBuffer::allocateBuffer):
-
-2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Added accessor for JSByteArray storage.
-
- * runtime/JSByteArray.h:
- (JSC::JSByteArray::storage):
-
-2009-02-03 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23560
- Implement SharedTimer on WorkerRunLoop
-
- * JavaScriptCore.exp:
- Forgot to expose ThreadCondition::timedWait() in one of previous patches.
-
-2009-02-02 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
- <rdar://problem/6543487>
-
- In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
- itself recursively, it will incorrectly emit (and thus consume) the next single character
- match in the current character class. As WREC uses a binary search this out of sequence
- codegen could result in a character match being missed and so cause the regex to produce
- incorrect results.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
- https://bugs.webkit.org/show_bug.cgi?id=23676
-
- * API/JSObjectRef.cpp:
- (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
- * parser/Lexer.cpp:
- (JSC::Lexer::Lexer): Ditto.
- (JSC::Lexer::clear): Ditto.
-
- * wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of
- reserveCapacity for use when the vector is brand new (still size 0 with no
- capacity other than the inline capacity).
-
-2009-01-30 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- <rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.
-
- * wtf/Platform.h:
-
-2009-01-30 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe and Sam Weinig.
-
- Finally fix load() to propagate exceptions correctly.
-
- * jsc.cpp:
- (functionLoad):
-
-2009-01-30 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23618
- Templated worker tasks should be more error proof to use.
- Fix Chromium build.
-
- * wtf/TypeTraits.h:
- (WTF::IsConvertibleToInteger::IsConvertibleToDouble):
- Avoid "possible loss of data" warning when using Microsoft's C++ compiler
- by avoiding an implicit conversion of int types to doubles.
-
-2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Bug 23580: GNU mode RVCT compilation support
- <https://bugs.webkit.org/show_bug.cgi?id=23580>
-
- * pcre/pcre_exec.cpp: Use COMPILER(GCC) instead of __GNUC__.
- * wtf/FastMalloc.cpp: Ditto.
- (WTF::TCMallocStats::):
- * wtf/Platform.h: Don't define COMPILER(GCC) with RVCT --gnu.
-
-2009-01-30 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23618: Templated worker tasks should be more error proof to use
- <https://bugs.webkit.org/show_bug.cgi?id=23618>
-
- Add the type traits needed for the generic worker tasks
- and compile asserts for them.
-
- Add a summary header to the TypeTraits.h file to explain what is in there.
-
- Add a note to explain IsPod's deficiencies.
-
- * wtf/TypeTraits.h:
-
-2009-01-30 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
- <https://bugs.webkit.org/show_bug.cgi?id=23616>
-
- * wtf/TypeTraits.h: Moved RemovePointer, IsPod, IsInteger to this file.
-
- * wtf/OwnPtr.h: Use RemovePointer from TypeTraits.h.
- * wtf/RetainPtr.h: Ditto.
-
- * wtf/HashTraits.h: Use IsInteger from TypeTraits.h.
-
- * wtf/VectorTraits.h: Use IsPod from TypeTraits.h.
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- Added TypeTraits.h.
-
-2009-01-29 Stephanie Lewis <slewis@apple.com>
-
- RS by Oliver Hunt.
-
- Update the order files.
-
- * JavaScriptCore.order:
-
-2009-01-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 23551: Crash on page load with profiler enabled and running
- <https://bugs.webkit.org/show_bug.cgi?id=23551>
- <rdar://problem/6529521>
-
- Interpreter::execute(FunctionBodyNode*, ...) calls Profiler::didExecute()
- with a stale CallFrame. If some part of the scope chain has already been
- freed, Profiler::didExecute() will crash when attempting to get the lexical
- global object. The fix is to make the didExecute() call use the caller's
- CallFrame, not the one made for the function call. In this case, the
- willExecute() call should also be changed to match.
-
- Since this occurs in the actual inspector JS, it is difficult to reduce.
- I couldn't make a layout test.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::execute):
-
-2009-01-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Fix for <rdar://problem/6525537>
- Hang occurs when closing Installer window (iTunes, Aperture)
-
- * JavaScriptCore.exp: Export JSGlobalData::sharedInstance.
-
-2009-01-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Initial patch by Mark Rowe.
-
- <rdar://problem/6519356>
- REGRESSION (r36006): "out of memory" alert running dromaeo on Windows
-
- Report the cost of the ArrayStorage vector more accurately/often.
-
- * runtime/JSArray.cpp:
- (JSC::JSArray::JSArray): Report the extra cost even for a filled array
- because JSString using the single character optimization and immediates
- wont increase the cost themselves.
- (JSC::JSArray::putSlowCase): Update the cost when increasing the size of
- the array.
- (JSC::JSArray::increaseVectorLength): Ditto.
-
-2009-01-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Fix for <rdar://problem/6129678>
- REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view
-
- Iterating the properties of activation objects accessed through the WebKit debugging
- APIs was broken by forced conversion of JSActivation to the global object. To fix this,
- we use a proxy activation object that acts more like a normal JSObject.
-
- * debugger/DebuggerActivation.cpp: Added.
- (JSC::DebuggerActivation::DebuggerActivation):
- (JSC::DebuggerActivation::mark):
- (JSC::DebuggerActivation::className):
- (JSC::DebuggerActivation::getOwnPropertySlot):
- (JSC::DebuggerActivation::put):
- (JSC::DebuggerActivation::putWithAttributes):
- (JSC::DebuggerActivation::deleteProperty):
- (JSC::DebuggerActivation::getPropertyNames):
- (JSC::DebuggerActivation::getPropertyAttributes):
- (JSC::DebuggerActivation::defineGetter):
- (JSC::DebuggerActivation::defineSetter):
- (JSC::DebuggerActivation::lookupGetter):
- (JSC::DebuggerActivation::lookupSetter):
- * debugger/DebuggerActivation.h: Added.
- Proxy JSActivation object for Debugging.
-
- * runtime/JSActivation.h:
- (JSC::JSActivation::isActivationObject): Added.
- * runtime/JSObject.h:
- (JSC::JSObject::isActivationObject): Added.
-
-2009-01-28 David Kilzer <ddkilzer@apple.com>
-
- Bug 23490: Remove initialRefCount argument from RefCounted class
-
- <https://bugs.webkit.org/show_bug.cgi?id=23490>
-
- Reviewed by Darin Adler.
-
- RefCountedBase now always starts with a ref count of 1, so there
- is no need to pass the initialRefCount into the class anymore.
-
- * wtf/ByteArray.h:
- (WTF::ByteArray::ByteArray): Removed call to RefCounted(1).
- * wtf/RefCounted.h:
- (WTF::RefCountedBase::RefCountedBase): Changed to start with a
- ref count of 1.
- (WTF::RefCounted::RefCounted): Removed initialRefCount argument
- and removed call to RefCounted(1).
-
-2009-01-26 Adele Peterson <adele@apple.com>
-
- Build fix.
-
- * debugger/Debugger.cpp:
-
-2009-01-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixes for eq null & neq null, on 64-bit JIT.
- https://bugs.webkit.org/show_bug.cgi?id=23559
-
- This patch degrades 64-bit JIT performance on some benchmarks,
- due to the whole not-being-incorrect thing.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2009-01-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Gavin Barraclough.
-
- Bug 23552: Dashcode evaluator no longer works after making ExecStates actual call frames
- <https://bugs.webkit.org/show_bug.cgi?id=23552>
- <rdar://problem/6398839>
-
- * JavaScriptCore.exp:
- * debugger/Debugger.cpp:
- (JSC::evaluateInGlobalCallFrame): Added so that WebScriptCallFrame can
- evaluate JS starting from a global call frame.
- * debugger/Debugger.h:
-
-2009-01-25 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- Improve the consistency of settings in our .xcconfig files.
-
- * Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS to match other projects.
-
-2009-01-25 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- Turn on the following warnings:
-
- -Wcast-qual
- -Wextra-tokens
- -Wformat=2
- -Winit-self
- -Wmissing-noreturn
- -Wpacked
- -Wrendundant-decls
-
- * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
- -W for clarity since we don't have to support the older versions of gcc that require the
- old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
- -Wno-format-y2k since we can have that one on now.
-
-2009-01-25 Judit Jasz <jasy@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- Compilation problem fixing
- http://bugs.webkit.org/show_bug.cgi?id=23497
-
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall): Use JSValuePtr::encode.
-
-2009-01-25 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- Fourth patch: Deal with the last few stray warnings.
-
- * parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
- This makes both separate compilation and all-in-one compilation work with the
- -Wredundant-decls warning.
-
-2009-01-25 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- Third patch: Use the noreturn attribute on functions that don't
- return to prepare for the use of the -Wmissing-noreturn warning.
-
- * jit/JITCall.cpp:
- (JSC::unreachable): Added NO_RETURN.
- * jsc.cpp:
- (functionQuit): Ditto.
- (printUsageStatement): Ditto.
- * wtf/AlwaysInline.h: Added definition of NO_RETURN.
-
-2009-01-24 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Force inlining of Lexer::matchPunctuator
-
- 2.2% win when parsing jQuery, Mootools, Prototype, etc
-
- * parser/Lexer.h:
-
-2009-01-23 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix for <rdar://problem/6126212>
- Ensure that callbacks out from the JSC interface are only allowed
- to return in reverse-chronological order to that in which they were
- made. If we allow earlier callbacks to return first, then this may
- result in setions of the RegisterFile in use by another thread
- being trampled.
-
- See uber-comment in JSLock.h for details.
-
- * runtime/JSLock.cpp:
- (JSC::JSLock::DropAllLocks::DropAllLocks):
- (JSC::JSLock::DropAllLocks::~DropAllLocks):
-
-2009-01-23 Darin Adler <darin@apple.com>
-
- Try to fix WX build.
-
- * runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h>
- for the definition of UChar.
-
-2009-01-23 Anders Carlsson <andersca@apple.com>
-
- * Configurations/Base.xcconfig:
- GCC 4.0 build fix.
-
- * runtime/JSNumberCell.h:
- 64-bit build fix.
-
-2009-01-23 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Turn on -Wmissing-prototypes and fix the warnings.
-
- * API/JSClassRef.cpp:
- (clearReferenceToPrototype):
- * Configurations/Base.xcconfig:
- * runtime/Collector.cpp:
- (JSC::getPlatformThreadRegisters):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createError):
- * runtime/JSGlobalObjectFunctions.h:
- * runtime/JSNumberCell.h:
- * runtime/UString.cpp:
- (JSC::initializeStaticBaseString):
- (JSC::createRep):
- * wtf/FastMalloc.cpp:
- * wtf/Threading.cpp:
-
-2009-01-22 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Anders Carlsson.
-
- Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
-
- Current versions of Xcode only respect it for C and Objective-C files,
- and our code doesn't currently compile if it is applied to C++ and
- Objective-C++ files.
-
- * Configurations/Base.xcconfig:
-
-2009-01-22 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=23489
-
- Return currentTime() in correct units for the two early return cases.
-
- Reviewed by Mark Rowe.
-
- * wtf/CurrentTime.cpp:
- (WTF::currentTime):
-
-2009-01-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix for <rdar://problem/6439247>
- FastMalloc allocating an extra 4MB of meta-data on 64-bit
-
- Rely on the fact that on all known x86-64 platforms only use 48 bits of
- address space to shrink the initial size of the PageMap from ~4MB to 120K.
- For 64-bit we still use a 3-level radix tree, but now each level is only 12
- bits wide.
-
- No performance change.
-
- * wtf/FastMalloc.cpp:
- (WTF::MapSelector): Add specialization for 64 bit that takes into account the
- 16 bits of unused address space on x86-64.
-
-2009-01-22 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
- fast/js/numeric-conversion.html is broken, and corresponding
- <rdar://problem/6514842>
-
- The basic problem here is that parseInt(Infinity) should be NaN,
- but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
-
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt):
-
-2009-01-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- <rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
- <https://bugs.webkit.org/show_bug.cgi?id=23479>
-
- Automatic semicolon insertion was resulting in this being accepted in the initial
- nodeless parsing, but subsequent reparsing for code generation would fail, leading
- to a crash. The solution is to ensure that reparsing a function performs parsing
- in the same state as the initial parse. We do this by modifying the saved source
- ranges to include rather than exclude the opening and closing braces.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): add an assertion for successful recompile
- * parser/Lexer.h:
- (JSC::Lexer::sourceCode): include rather than exclude braces.
- * parser/Nodes.h:
- (JSC::FunctionBodyNode::toSourceString): No need to append braces anymore.
-
-2009-01-22 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23373
-
- Implement ThreadCondition::timedWait().
- Since we borrow the code for condition variables from other sources,
- I did the same for timedWait(). See comments in ThreadingWin.cpp for
- rationale and more info.
-
- * wtf/CONTRIBUTORS.pthreads-win32:
- Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself
- is included into wtf/ThreadingWin32.cpp.
-
- * wtf/Threading.h:
- * wtf/ThreadingWin.cpp:
- Additional info and Pthreads-win32 license at the beginning.
- (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32.
- (WTF::PlatformCondition::signal): same
- (WTF::ThreadCondition::ThreadCondition):
- (WTF::ThreadCondition::~ThreadCondition):
- (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait.
- (WTF::ThreadCondition::timedWait): same
- (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal.
- (WTF::ThreadCondition::broadcast): same
-
-2009-01-21 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.
-
- We need to check all numbers in integer switches, not just those
- represented as integer JSImmediates.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_switch_imm):
-
-2009-01-21 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
-
-2009-01-21 Alexey Proskuryakov <ap@webkit.org>
-
- Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23456
- Function argument names leak
-
- * parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
-
-2009-01-20 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Windows build fix
-
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
-
-2009-01-20 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Mark Rowe.
-
- Structure property table deleted offset maps are being leaked.
- Probably shouldn't be doing that.
-
- https://bugs.webkit.org/show_bug.cgi?id=23442
-
- * runtime/Structure.cpp:
- (JSC::Structure::~Structure):
-
-2009-01-20 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (build fix).
-
- Attempt to fix gtk build
-
- * GNUmakefile.am:
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- * runtime/StringPrototype.cpp:
- (JSC::substituteBackreferences): Add back the initialization to fix the build.
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- First patch: Fix some simple cases of various warnings.
-
- * pcre/pcre_compile.cpp:
- (jsRegExpCompile): Use const_cast to change const-ness.
-
- * runtime/StringPrototype.cpp:
- (JSC::substituteBackreferences): Remove unneeded initialization and
- use UChar instead of unsigned short for UTF-16 values.
-
- * wtf/dtoa.cpp:
- (WTF::strtod): Use const_cast to change const-ness.
-
-2009-01-20 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (build fix).
-
- Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl
-
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCoreSources.bkl:
-
-2009-01-20 Oliver Hunt <oliver@apple.com>
-
- RS=Dan Bernstein.
-
- Move runtime/ByteArray to wtf/ByteArray
-
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * runtime/JSByteArray.cpp:
- * runtime/JSByteArray.h:
- * wtf/ByteArray.cpp: Renamed from JavaScriptCore/runtime/ByteArray.cpp.
- (WTF::ByteArray::create):
- * wtf/ByteArray.h: Renamed from JavaScriptCore/runtime/ByteArray.h.
- (WTF::ByteArray::length):
- (WTF::ByteArray::set):
- (WTF::ByteArray::get):
- (WTF::ByteArray::data):
- (WTF::ByteArray::deref):
- (WTF::ByteArray::ByteArray):
-
-2009-01-19 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Gavin Barraclough.
-
- Remove temporary operator-> from JSValuePtr.
-
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::call):
- (JSC::::toNumber):
- (JSC::::toString):
- * API/JSObjectRef.cpp:
- (JSObjectSetPrototype):
- * API/JSValueRef.cpp:
- (JSValueGetType):
- (JSValueIsUndefined):
- (JSValueIsNull):
- (JSValueIsBoolean):
- (JSValueIsNumber):
- (JSValueIsString):
- (JSValueIsObject):
- (JSValueIsObjectOfClass):
- (JSValueToBoolean):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- * bytecode/CodeBlock.cpp:
- (JSC::valueToSourceString):
- (JSC::CodeBlock::mark):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::isKnownNotImmediate):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitEqualityOp):
- (JSC::keyForImmediateSwitch):
- * interpreter/Interpreter.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAddSlowCase):
- (JSC::jsAdd):
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::jsIsFunctionType):
- (JSC::isNotObject):
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::throwException):
- (JSC::cachePrototypeChain):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
- (JSC::Interpreter::cti_op_get_by_id_proto_fail):
- (JSC::Interpreter::cti_op_get_by_id_array_fail):
- (JSC::Interpreter::cti_op_get_by_id_string_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_construct_JSConstruct):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_get_by_val_byte_array):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_put_by_val_byte_array):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_push_scope):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_is_boolean):
- (JSC::Interpreter::cti_op_is_number):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_put_by_index):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_op_del_by_val):
- (JSC::Interpreter::cti_op_put_getter):
- (JSC::Interpreter::cti_op_put_setter):
- (JSC::Interpreter::cti_op_new_error):
- * interpreter/Interpreter.h:
- (JSC::Interpreter::isJSArray):
- (JSC::Interpreter::isJSString):
- (JSC::Interpreter::isJSByteArray):
- * interpreter/Register.h:
- (JSC::Register::marked):
- (JSC::Register::mark):
- * jit/JITInlineMethods.h:
- (JSC::JIT::getConstantOperandImmediateInt):
- (JSC::JIT::isOperandConstantImmediateInt):
- * jsc.cpp:
- (functionPrint):
- (functionDebug):
- (functionRun):
- (functionLoad):
- (runWithScripts):
- (runInteractive):
- * parser/Nodes.cpp:
- (JSC::processClauseList):
- * profiler/ProfileGenerator.cpp:
- (JSC::ProfileGenerator::addParentForConsoleStart):
- * profiler/Profiler.cpp:
- (JSC::Profiler::createCallIdentifier):
- * runtime/ArrayConstructor.cpp:
- (JSC::constructArrayWithSizeQuirk):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncToString):
- (JSC::arrayProtoFuncToLocaleString):
- (JSC::arrayProtoFuncJoin):
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncReverse):
- (JSC::arrayProtoFuncShift):
- (JSC::arrayProtoFuncSlice):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncSplice):
- (JSC::arrayProtoFuncUnShift):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanConstructor.cpp:
- (JSC::constructBoolean):
- (JSC::callBooleanConstructor):
- * runtime/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncToString):
- (JSC::booleanProtoFuncValueOf):
- * runtime/Collector.cpp:
- (JSC::Heap::protect):
- (JSC::Heap::unprotect):
- (JSC::Heap::heap):
- (JSC::Heap::collect):
- (JSC::typeName):
- * runtime/Completion.cpp:
- (JSC::evaluate):
- * runtime/DateConstructor.cpp:
- (JSC::constructDate):
- (JSC::dateParse):
- (JSC::dateUTC):
- * runtime/DateInstance.h:
- (JSC::DateInstance::internalNumber):
- * runtime/DatePrototype.cpp:
- (JSC::formatLocaleDate):
- (JSC::fillStructuresUsingTimeArgs):
- (JSC::fillStructuresUsingDateArgs):
- (JSC::dateProtoFuncToString):
- (JSC::dateProtoFuncToUTCString):
- (JSC::dateProtoFuncToDateString):
- (JSC::dateProtoFuncToTimeString):
- (JSC::dateProtoFuncToLocaleString):
- (JSC::dateProtoFuncToLocaleDateString):
- (JSC::dateProtoFuncToLocaleTimeString):
- (JSC::dateProtoFuncGetTime):
- (JSC::dateProtoFuncGetFullYear):
- (JSC::dateProtoFuncGetUTCFullYear):
- (JSC::dateProtoFuncToGMTString):
- (JSC::dateProtoFuncGetMonth):
- (JSC::dateProtoFuncGetUTCMonth):
- (JSC::dateProtoFuncGetDate):
- (JSC::dateProtoFuncGetUTCDate):
- (JSC::dateProtoFuncGetDay):
- (JSC::dateProtoFuncGetUTCDay):
- (JSC::dateProtoFuncGetHours):
- (JSC::dateProtoFuncGetUTCHours):
- (JSC::dateProtoFuncGetMinutes):
- (JSC::dateProtoFuncGetUTCMinutes):
- (JSC::dateProtoFuncGetSeconds):
- (JSC::dateProtoFuncGetUTCSeconds):
- (JSC::dateProtoFuncGetMilliSeconds):
- (JSC::dateProtoFuncGetUTCMilliseconds):
- (JSC::dateProtoFuncGetTimezoneOffset):
- (JSC::dateProtoFuncSetTime):
- (JSC::setNewValueFromTimeArgs):
- (JSC::setNewValueFromDateArgs):
- (JSC::dateProtoFuncSetYear):
- (JSC::dateProtoFuncGetYear):
- * runtime/ErrorConstructor.cpp:
- (JSC::constructError):
- * runtime/ErrorPrototype.cpp:
- (JSC::errorProtoFuncToString):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createError):
- (JSC::createErrorMessage):
- * runtime/FunctionConstructor.cpp:
- (JSC::constructFunction):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncToString):
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall):
- * runtime/GetterSetter.cpp:
- (JSC::GetterSetter::toObject):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::getOwnPropertySlot):
- * runtime/JSArray.cpp:
- (JSC::JSArray::put):
- (JSC::JSArray::mark):
- (JSC::JSArray::sort):
- (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
- (JSC::JSArray::compactForSorting):
- * runtime/JSByteArray.h:
- (JSC::JSByteArray::setIndex):
- * runtime/JSCell.h:
- (JSC::asCell):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::call):
- (JSC::JSFunction::construct):
- * runtime/JSGlobalObject.cpp:
- (JSC::markIfNeeded):
- (JSC::lastInPrototypeChain):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::encode):
- (JSC::decode):
- (JSC::globalFuncEval):
- (JSC::globalFuncParseInt):
- (JSC::globalFuncParseFloat):
- (JSC::globalFuncIsNaN):
- (JSC::globalFuncIsFinite):
- (JSC::globalFuncEscape):
- (JSC::globalFuncUnescape):
- (JSC::globalFuncJSCPrint):
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject):
- (JSC::JSImmediate::toObject):
- (JSC::JSImmediate::prototype):
- (JSC::JSImmediate::toString):
- * runtime/JSImmediate.h:
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::put):
- (JSC::callDefaultValueFunction):
- (JSC::JSObject::getPrimitiveNumber):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- (JSC::JSObject::lookupGetter):
- (JSC::JSObject::lookupSetter):
- (JSC::JSObject::hasInstance):
- (JSC::JSObject::toNumber):
- (JSC::JSObject::toString):
- * runtime/JSObject.h:
- (JSC::JSObject::JSObject):
- (JSC::JSObject::inlineGetOwnPropertySlot):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSObject::getPropertySlot):
- (JSC::JSValuePtr::get):
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::create):
- * runtime/JSString.cpp:
- (JSC::JSString::getOwnPropertySlot):
- * runtime/JSValue.h:
- * runtime/JSWrapperObject.cpp:
- (JSC::JSWrapperObject::mark):
- * runtime/JSWrapperObject.h:
- (JSC::JSWrapperObject::setInternalValue):
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncAbs):
- (JSC::mathProtoFuncACos):
- (JSC::mathProtoFuncASin):
- (JSC::mathProtoFuncATan):
- (JSC::mathProtoFuncATan2):
- (JSC::mathProtoFuncCeil):
- (JSC::mathProtoFuncCos):
- (JSC::mathProtoFuncExp):
- (JSC::mathProtoFuncFloor):
- (JSC::mathProtoFuncLog):
- (JSC::mathProtoFuncMax):
- (JSC::mathProtoFuncMin):
- (JSC::mathProtoFuncPow):
- (JSC::mathProtoFuncRound):
- (JSC::mathProtoFuncSin):
- (JSC::mathProtoFuncSqrt):
- (JSC::mathProtoFuncTan):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- (JSC::NativeErrorConstructor::construct):
- * runtime/NumberConstructor.cpp:
- (JSC::constructWithNumberConstructor):
- (JSC::callNumberConstructor):
- * runtime/NumberPrototype.cpp:
- (JSC::numberProtoFuncToString):
- (JSC::numberProtoFuncToLocaleString):
- (JSC::numberProtoFuncValueOf):
- (JSC::numberProtoFuncToFixed):
- (JSC::numberProtoFuncToExponential):
- (JSC::numberProtoFuncToPrecision):
- * runtime/ObjectConstructor.cpp:
- (JSC::constructObject):
- * runtime/ObjectPrototype.cpp:
- (JSC::objectProtoFuncValueOf):
- (JSC::objectProtoFuncHasOwnProperty):
- (JSC::objectProtoFuncIsPrototypeOf):
- (JSC::objectProtoFuncDefineGetter):
- (JSC::objectProtoFuncDefineSetter):
- (JSC::objectProtoFuncLookupGetter):
- (JSC::objectProtoFuncLookupSetter):
- (JSC::objectProtoFuncPropertyIsEnumerable):
- (JSC::objectProtoFuncToLocaleString):
- (JSC::objectProtoFuncToString):
- * runtime/Operations.h:
- (JSC::JSValuePtr::equalSlowCaseInline):
- (JSC::JSValuePtr::strictEqual):
- (JSC::JSValuePtr::strictEqualSlowCaseInline):
- * runtime/Protect.h:
- (JSC::gcProtect):
- (JSC::gcUnprotect):
- * runtime/RegExpConstructor.cpp:
- (JSC::setRegExpConstructorInput):
- (JSC::setRegExpConstructorMultiline):
- (JSC::constructRegExp):
- * runtime/RegExpObject.cpp:
- (JSC::setRegExpObjectLastIndex):
- (JSC::RegExpObject::match):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncTest):
- (JSC::regExpProtoFuncExec):
- (JSC::regExpProtoFuncCompile):
- (JSC::regExpProtoFuncToString):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCodeSlowCase):
- (JSC::stringFromCharCode):
- (JSC::constructWithStringConstructor):
- (JSC::callStringConstructor):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncToString):
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncIndexOf):
- (JSC::stringProtoFuncLastIndexOf):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- (JSC::stringProtoFuncSlice):
- (JSC::stringProtoFuncSplit):
- (JSC::stringProtoFuncSubstr):
- (JSC::stringProtoFuncSubstring):
- (JSC::stringProtoFuncToLowerCase):
- (JSC::stringProtoFuncToUpperCase):
- (JSC::stringProtoFuncLocaleCompare):
- (JSC::stringProtoFuncBig):
- (JSC::stringProtoFuncSmall):
- (JSC::stringProtoFuncBlink):
- (JSC::stringProtoFuncBold):
- (JSC::stringProtoFuncFixed):
- (JSC::stringProtoFuncItalics):
- (JSC::stringProtoFuncStrike):
- (JSC::stringProtoFuncSub):
- (JSC::stringProtoFuncSup):
- (JSC::stringProtoFuncFontcolor):
- (JSC::stringProtoFuncFontsize):
- (JSC::stringProtoFuncAnchor):
- (JSC::stringProtoFuncLink):
- * runtime/Structure.cpp:
- (JSC::Structure::Structure):
- (JSC::Structure::getEnumerablePropertyNames):
- (JSC::Structure::createCachedPrototypeChain):
- * runtime/Structure.h:
- (JSC::Structure::mark):
- * runtime/StructureChain.cpp:
- (JSC::StructureChain::StructureChain):
-
-2009-01-19 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
- <https://bugs.webkit.org/show_bug.cgi?id=23409>
- <rdar://problem/6505723>
-
- Test: fast/js/string-replace-3.html
-
- * runtime/StringPrototype.cpp:
- (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure
- how this ever worked.
-
-2009-01-16 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
- registers, save reloading them every time they're used.
-
- Draws x86-64 jit performance close to that of i386 jit.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::subPtr):
- (JSC::MacroAssembler::jnzPtr):
- (JSC::MacroAssembler::jzPtr):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOpSlowCase):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpIfJSCell):
- (JSC::JIT::emitJumpIfNotJSCell):
- (JSC::JIT::emitJumpIfImmediateNumber):
- (JSC::JIT::emitJumpIfNotImmediateNumber):
- (JSC::JIT::emitJumpIfImmediateInteger):
- (JSC::JIT::emitJumpIfNotImmediateInteger):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
-
-2009-01-16 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add support to x86-64 JIT for inline double precision arithmetic ops.
- +5/6% on x86-64, JIT enabled, sunspider.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::addPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::movq_rr):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArithSlow_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArithSlow_op_mul):
- (JSC::JIT::compileFastArith_op_sub):
- (JSC::JIT::compileFastArithSlow_op_sub):
- * parser/ResultType.h:
- (JSC::ResultType::isReusable):
- (JSC::ResultType::isInt32):
- (JSC::ResultType::definitelyIsNumber):
- (JSC::ResultType::mightBeNumber):
- (JSC::ResultType::isNotNumber):
- (JSC::ResultType::unknownType):
-
-2009-01-16 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
+ * jit/JITStubs.cpp:
+ (JSC::JITThunks::JITThunks):
- Fixes for SamplingTool.
+2009-06-19 Gavin Barraclough <barraclough@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=23390
+ Reviewed by NOBODY (Windows build fix).
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::storePtr):
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingTool::run):
- (JSC::SamplingTool::dump):
- * bytecode/SamplingTool.h:
- (JSC::SamplingTool::encodeSample):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
* jit/JIT.h:
- (JSC::JIT::samplingToolTrackCodeBlock):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
- (JSC::JIT::emitCTICall_internal):
-
-2009-01-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
- turn "c" into "" when stripping \\c_ character
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing
- control escapes inside character classes.
-
-2009-01-16 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parseParentheses): Removed unreachable code.
-
-2009-01-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
- on assertion gives incorrect result (23075)
-
- https://bugs.webkit.org/show_bug.cgi?id=23075
- * pcre/pcre_compile.cpp:
- (compileBranch): Throw away an assertion if it's followed by a quantifier
- with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.
+2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare
- case of an assertion with a quantifier with a 0 minimum, since we
- don't handle quantified subexpressions yet, and in this special case,
- we can't just throw away the quantifier.
-
-2009-01-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add support in ResultType to track that the results of bitops
- are always of type int32_t.
-
- * parser/Nodes.cpp:
- (JSC::ReadModifyResolveNode::emitBytecode):
- (JSC::ReadModifyDotNode::emitBytecode):
- (JSC::ReadModifyBracketNode::emitBytecode):
- * parser/Nodes.h:
- (JSC::ExpressionNode::):
- (JSC::BooleanNode::):
- (JSC::NumberNode::):
- (JSC::StringNode::):
- (JSC::PrePostResolveNode::):
- (JSC::TypeOfResolveNode::):
- (JSC::TypeOfValueNode::):
- (JSC::UnaryPlusNode::):
- (JSC::NegateNode::):
- (JSC::BitwiseNotNode::):
- (JSC::LogicalNotNode::):
- (JSC::MultNode::):
- (JSC::DivNode::):
- (JSC::ModNode::):
- (JSC::SubNode::):
- (JSC::LeftShiftNode::):
- (JSC::RightShiftNode::):
- (JSC::UnsignedRightShiftNode::):
- (JSC::LessNode::):
- (JSC::GreaterNode::):
- (JSC::LessEqNode::):
- (JSC::GreaterEqNode::):
- (JSC::InstanceOfNode::):
- (JSC::EqualNode::):
- (JSC::NotEqualNode::):
- (JSC::StrictEqualNode::):
- (JSC::NotStrictEqualNode::):
- (JSC::BitAndNode::):
- (JSC::BitOrNode::):
- (JSC::BitXOrNode::):
- (JSC::LogicalOpNode::):
- * parser/ResultType.h:
- (JSC::ResultType::isInt32):
- (JSC::ResultType::isNotNumber):
- (JSC::ResultType::booleanType):
- (JSC::ResultType::numberType):
- (JSC::ResultType::numberTypeCanReuse):
- (JSC::ResultType::numberTypeCanReuseIsInt32):
- (JSC::ResultType::stringOrNumberTypeCanReuse):
- (JSC::ResultType::stringType):
- (JSC::ResultType::unknownType):
- (JSC::ResultType::forAdd):
- (JSC::ResultType::forBitOp):
- (JSC::OperandTypes::OperandTypes):
-
-2009-01-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add support for integer addition, subtraction and multiplication
- in JIT code on x86-64.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::mul32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::joMul32):
- (JSC::MacroAssembler::joSub32):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArithSlow_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArithSlow_op_mul):
- (JSC::JIT::compileFastArith_op_sub):
- (JSC::JIT::compileFastArithSlow_op_sub):
-
-2009-01-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
+ Reviewed by Gavin Barraclough.
- On x86-64 allow JSImmediate to encode 64-bit double precision values.
- This patch only affects builds that set USE(ALTERNATE_JSIMMEDIATE).
- Updates the implementation of JSValuePtr:: and JSImmediate:: methods
- that operate on neumeric values to be be aware of the new representation.
- When this representation is in use, the class JSNumberCell is redundant
- and is compiled out.
+ Reorganize ARM architecture specific macros.
+ Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).
- The format of the new immediate representation is documented in JSImmediate.h.
+ Bug 24986: ARM JIT port
+ <https://bugs.webkit.org/show_bug.cgi?id=24986>
- * JavaScriptCore.exp:
+ * assembler/ARMv7Assembler.h:
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MacroAssembler.h:
- (JSC::MacroAssembler::subPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::subq_rr):
- (JSC::X86Assembler::movq_rr):
- (JSC::X86Assembler::ucomisd_rr):
- (JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
+ * assembler/MacroAssemblerCodeRef.h:
+ (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
+ * jit/ExecutableAllocator.h:
+ (JSC::ExecutableAllocator::cacheFlush):
* jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_lshift):
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArith_op_bitand):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArith_op_post_inc):
- (JSC::JIT::compileFastArith_op_post_dec):
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileFastArith_op_pre_dec):
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
* jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpIfBothJSCells):
- (JSC::JIT::emitJumpIfEitherNumber):
- (JSC::JIT::emitJumpIfNotEitherNumber):
- (JSC::JIT::emitJumpIfImmediateIntegerNumber):
- (JSC::JIT::emitJumpIfNotImmediateIntegerNumber):
- (JSC::JIT::emitJumpIfNotImmediateIntegerNumbers):
- (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumber):
- (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumbers):
- (JSC::JIT::emitFastArithDeTagImmediate):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
- * runtime/JSCell.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject):
- (JSC::JSImmediate::toObject):
- (JSC::JSImmediate::toString):
- * runtime/JSImmediate.h:
- (JSC::wtf_reinterpret_cast):
- (JSC::JSImmediate::isNumber):
- (JSC::JSImmediate::isIntegerNumber):
- (JSC::JSImmediate::isDoubleNumber):
- (JSC::JSImmediate::isPositiveIntegerNumber):
- (JSC::JSImmediate::areBothImmediateIntegerNumbers):
- (JSC::JSImmediate::makeInt):
- (JSC::JSImmediate::makeDouble):
- (JSC::JSImmediate::doubleValue):
- (JSC::doubleToBoolean):
- (JSC::JSImmediate::toBoolean):
- (JSC::JSImmediate::getTruncatedUInt32):
- (JSC::JSImmediate::makeOutOfIntegerRange):
- (JSC::JSImmediate::from):
- (JSC::JSImmediate::getTruncatedInt32):
- (JSC::JSImmediate::toDouble):
- (JSC::JSImmediate::getUInt32):
- (JSC::JSValuePtr::isInt32Fast):
- (JSC::JSValuePtr::isUInt32Fast):
- (JSC::JSValuePtr::areBothInt32Fast):
- (JSC::JSFastMath::canDoFastBitwiseOperations):
- (JSC::JSFastMath::xorImmediateNumbers):
- (JSC::JSFastMath::canDoFastRshift):
- (JSC::JSFastMath::canDoFastUrshift):
- (JSC::JSFastMath::rightShiftImmediateNumbers):
- (JSC::JSFastMath::canDoFastAdditiveOperations):
- (JSC::JSFastMath::addImmediateNumbers):
- (JSC::JSFastMath::subImmediateNumbers):
- * runtime/JSNumberCell.cpp:
- (JSC::jsNumberCell):
- * runtime/JSNumberCell.h:
- (JSC::createNumberStructure):
- (JSC::isNumberCell):
- (JSC::asNumberCell):
- (JSC::jsNumber):
- (JSC::JSValuePtr::isDoubleNumber):
- (JSC::JSValuePtr::getDoubleNumber):
- (JSC::JSValuePtr::isNumber):
- (JSC::JSValuePtr::uncheckedGetNumber):
- (JSC::jsNaN):
- (JSC::JSValuePtr::getNumber):
- (JSC::JSValuePtr::numberToInt32):
- (JSC::JSValuePtr::numberToUInt32):
- * runtime/JSValue.h:
- * runtime/NumberConstructor.cpp:
- (JSC::numberConstructorNegInfinity):
- (JSC::numberConstructorPosInfinity):
- (JSC::numberConstructorMaxValue):
- (JSC::numberConstructorMinValue):
- * runtime/NumberObject.cpp:
- (JSC::constructNumber):
- * runtime/NumberObject.h:
- * runtime/Operations.h:
- (JSC::JSValuePtr::equal):
- (JSC::JSValuePtr::equalSlowCaseInline):
- (JSC::JSValuePtr::strictEqual):
- (JSC::JSValuePtr::strictEqualSlowCaseInline):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ * jit/JITStubs.cpp:
+ * jit/JITStubs.h:
* wtf/Platform.h:
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::generateEnter):
+ (JSC::Yarr::RegexGenerator::generateReturn):
-2009-01-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- <rdar://problem/6045018>
- REGRESSION (r34838): JavaScript objects appear to be leaked after loading google.com
-
- Subtract the number of JSStrings cached in SmallStrings when calculating the
- number of live JSObjects.
-
- * runtime/Collector.cpp:
- (JSC::Heap::objectCount):
- * runtime/SmallStrings.cpp:
- (JSC::SmallStrings::count):
- * runtime/SmallStrings.h:
-
-2009-01-15 Sam Weinig <sam@webkit.org>
-
- Fix Qt build.
-
- * runtime/Collector.cpp:
-
-2009-01-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Fix crash seen running fast/canvas.
-
- Make sure to mark the ScopeNode and CodeBlock being created
- in the re-parse for exception information.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
- * parser/Nodes.h:
- (JSC::ScopeNode::mark):
- * runtime/Collector.cpp:
- (JSC::Heap::collect):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSGlobalData.h:
-
-2009-01-15 Craig Schlenter <craig.schlenter@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23347
- Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails on Linux
-
- * wtf/ThreadingPthreads.cpp: included limits.h as INT_MAX is defined there.
-
-2009-01-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at sfgate.com
- <https://bugs.webkit.org/show_bug.cgi?id=23225> <rdar://problem/6487432>
-
- Character position for open and closing brace was incorrectly referencing m_position to
- record their position in a source document, however this is unsafe as BOMs may lead to
- m_position being an arbitrary position from the real position of the current character.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::matchPunctuator):
-
-2009-01-14 David Kilzer <ddkilzer@apple.com>
-
- Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html
-
- <https://bugs.webkit.org/show_bug.cgi?id=23153>
-
- Reviewed by Darin Adler.
-
- Instead of building bytecode.html into ${SRCROOT}/docs/bytecode.html, build it
- into ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/docs/bytecode.html.
-
- Also fixes make-bytecode-docs.pl to actually generate documentation.
-
- * DerivedSources.make: Changed bytecode.html to be built into local docs
- directory in ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore.
- * JavaScriptCore.xcodeproj/project.pbxproj: Added "/docs" to the end of the
- "mkdir -p" command so that the docs subdirectory is automatically created.
- * docs/make-bytecode-docs.pl: Changed BEGIN_OPCODE to DEFINE_OPCODE so that
- documentation is actually generated.
-
-2009-01-14 Adam Treat <adam.treat@torchmobile.com>
-
- Build fix for Qt from Dmitry Titov.
-
- * wtf/ThreadingQt.cpp:
- (WTF::ThreadCondition::timedWait):
-
-2009-01-14 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly
-
- EvalCodeBlock's do not reference the functions that are declared inside the eval
- code, this means that simply marking the EvalCodeBlock through the global object
- is insufficient to mark the declared functions. This patch corrects this by
- explicitly marking the CodeBlocks of all the functions declared in the cached
- EvalNode.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::mark):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::hasFunctions):
- * bytecode/EvalCodeCache.h:
- (JSC::EvalCodeCache::mark):
- * parser/Nodes.cpp:
- (JSC::ScopeNodeData::mark):
- (JSC::EvalNode::mark):
- * parser/Nodes.h:
-
-2009-01-14 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23312
- Implement MessageQueue::waitForMessageTimed()
- Also fixed ThreadCondition::timedWait() to take absolute time, as discussed on webkit-dev.
- Win32 version of timedWait still has to be implemented.
-
- * wtf/MessageQueue.h:
- (WTF::MessageQueueWaitResult: new enum for the result of MessageQueue::waitForMessageTimed.
- (WTF::MessageQueue::waitForMessage):
- (WTF::MessageQueue::waitForMessageTimed): New method.
- * wtf/Threading.h:
- * wtf/ThreadingGtk.cpp:
- (WTF::ThreadCondition::timedWait): changed to use absolute time instead of interval.
- * wtf/ThreadingNone.cpp:
- (WTF::ThreadCondition::timedWait): ditto.
- * wtf/ThreadingPthreads.cpp:
- (WTF::ThreadCondition::timedWait): ditto.
- * wtf/ThreadingQt.cpp:
- (WTF::ThreadCondition::timedWait): ditto.
- * wtf/ThreadingWin.cpp:
- (WTF::ThreadCondition::timedWait): ditto. The actual Win32 code is still to be implemented.
-
-2009-01-14 Dean McNamee <deanm@chromium.org>
-
- Reviewed by Darin Adler and Oliver hunt.
-
- Correctly match allocation functions by implementing a custom deref().
-
- https://bugs.webkit.org/show_bug.cgi?id=23315
-
- * runtime/ByteArray.h:
- (JSC::ByteArray::deref):
- (JSC::ByteArray::ByteArray):
-
-2009-01-14 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - update copyright
-
- * Info.plist:
-
-2009-01-13 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler and Oliver Hunt.
-
- <rdar://problem/6489314> REGRESSION: Business widget's front side
- fails to render correctly when flipping widget
-
- The problem here is that parseInt was parsing NaN as 0. This patch
- corrects that by parsing NaN as NaN. This matches our old behavior
- and Firefox.
-
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt):
-
-2009-01-13 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for: https://bugs.webkit.org/show_bug.cgi?id=23292
-
- Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.
-
- * runtime/JSImmediate.h:
- (JSC::JSFastMath::canDoFastAdditiveOperations):
-
-2009-01-13 Zalan Bujtas <zbujtas@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23290
- Fix JSImmediate::isImmediate(src) to !src->isCell()
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
-
-2009-01-13 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23281
- Fix the Chromium Win build.
- Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
- Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
- while they have their own implementation even on Windows.
-
- * wtf/CurrentTime.cpp:
- (WTF::currentTime):
-
-2009-01-12 Gavin Barraclough <barraclough@apple.com>
+2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
- Make the JSImmediate interface private.
-
- All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
- directly. The key missing methods on JSValuePtr are:
+ Fix armv7 JIT build issues.
- * isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
- * isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
- * isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.
+ Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
+ and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.
- The JIT is allowed full access to JSImmediate, since it needs to be able to directly
- manipulate JSValuePtrs. The Interpreter is provided access to perform operations directly
- on JSValuePtrs through the new JSFastMath interface.
+ * Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
+ * Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
- No performance impact.
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::::toNumber):
- * API/JSValueRef.cpp:
- (JSValueIsEqual):
- (JSValueIsStrictEqual):
- * JavaScriptCore.exp:
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::isKnownNotImmediate):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::keyForImmediateSwitch):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
- (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- * interpreter/Interpreter.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAdd):
- (JSC::jsIsObjectType):
- (JSC::cachePrototypeChain):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_get_by_val_byte_array):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_put_by_val_byte_array):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_call_eval):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_vm_throw):
- * interpreter/Interpreter.h:
- (JSC::Interpreter::isJSArray):
- (JSC::Interpreter::isJSString):
- (JSC::Interpreter::isJSByteArray):
* jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
- (JSC::JIT::isStrictEqCaseHandledInJITCode):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArith_op_bitand):
- (JSC::JIT::compileFastArith_op_mod):
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
- (JSC::JIT::getConstantOperandImmediateInt):
- (JSC::JIT::isOperandConstantImmediateInt):
- * parser/Nodes.cpp:
- (JSC::processClauseList):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncValueOf):
- * runtime/Collector.cpp:
- (JSC::Heap::protect):
- (JSC::Heap::unprotect):
- (JSC::Heap::heap):
- * runtime/JSByteArray.cpp:
- (JSC::JSByteArray::getOwnPropertySlot):
- * runtime/JSByteArray.h:
- (JSC::JSByteArray::getIndex):
- * runtime/JSCell.cpp:
- * runtime/JSCell.h:
- (JSC::JSValuePtr::isNumberCell):
- (JSC::JSValuePtr::asCell):
- (JSC::JSValuePtr::isNumber):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt):
- * runtime/JSImmediate.h:
- (JSC::js0):
- (JSC::jsImpossibleValue):
- (JSC::JSValuePtr::toInt32):
- (JSC::JSValuePtr::toUInt32):
- (JSC::JSValuePtr::isCell):
- (JSC::JSValuePtr::isInt32Fast):
- (JSC::JSValuePtr::getInt32Fast):
- (JSC::JSValuePtr::isUInt32Fast):
- (JSC::JSValuePtr::getUInt32Fast):
- (JSC::JSValuePtr::makeInt32Fast):
- (JSC::JSValuePtr::areBothInt32Fast):
- (JSC::JSFastMath::canDoFastBitwiseOperations):
- (JSC::JSFastMath::equal):
- (JSC::JSFastMath::notEqual):
- (JSC::JSFastMath::andImmediateNumbers):
- (JSC::JSFastMath::xorImmediateNumbers):
- (JSC::JSFastMath::orImmediateNumbers):
- (JSC::JSFastMath::canDoFastRshift):
- (JSC::JSFastMath::canDoFastUrshift):
- (JSC::JSFastMath::rightShiftImmediateNumbers):
- (JSC::JSFastMath::canDoFastAdditiveOperations):
- (JSC::JSFastMath::addImmediateNumbers):
- (JSC::JSFastMath::subImmediateNumbers):
- (JSC::JSFastMath::incImmediateNumber):
- (JSC::JSFastMath::decImmediateNumber):
- * runtime/JSNumberCell.h:
- (JSC::JSValuePtr::asNumberCell):
- (JSC::jsNumber):
- (JSC::JSValuePtr::uncheckedGetNumber):
- (JSC::JSNumberCell::toInt32):
- (JSC::JSNumberCell::toUInt32):
- (JSC::JSValuePtr::toJSNumber):
- (JSC::JSValuePtr::getNumber):
- (JSC::JSValuePtr::numberToInt32):
- (JSC::JSValuePtr::numberToUInt32):
- * runtime/JSObject.h:
- (JSC::JSValuePtr::isObject):
- (JSC::JSValuePtr::get):
- (JSC::JSValuePtr::put):
- * runtime/JSValue.cpp:
- (JSC::JSValuePtr::toInteger):
- (JSC::JSValuePtr::toIntegerPreserveNaN):
- * runtime/JSValue.h:
- * runtime/Operations.cpp:
- (JSC::JSValuePtr::equalSlowCase):
- (JSC::JSValuePtr::strictEqualSlowCase):
- * runtime/Operations.h:
- (JSC::JSValuePtr::equal):
- (JSC::JSValuePtr::equalSlowCaseInline):
- (JSC::JSValuePtr::strictEqual):
- (JSC::JSValuePtr::strictEqualSlowCaseInline):
- * runtime/Protect.h:
- (JSC::gcProtect):
- (JSC::gcUnprotect):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- * runtime/Structure.cpp:
- (JSC::Structure::createCachedPrototypeChain):
-
-2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
-
- Since date time functions have moved here, now the wx port JSC
- needs to depend on wx.
-
- * jscore.bkl:
-
-2009-01-11 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23245
-
- Add initializeThreading to key places in JS API to ensure that
- UString is properly initialized.
-
- * API/JSContextRef.cpp:
- (JSContextGroupCreate):
- (JSGlobalContextCreate):
- * API/JSObjectRef.cpp:
- (JSClassCreate):
- * API/JSStringRef.cpp:
- (JSStringCreateWithCharacters):
- (JSStringCreateWithUTF8CString):
- * API/JSStringRefCF.cpp:
- (JSStringCreateWithCFString):
-
-2009-01-11 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23175
-
- Separate out BaseString information from UString::Rep and make all baseString access go through
- a member function, so that it may be used for something else (in the future) in the BaseString
- case.
-
- * runtime/SmallStrings.cpp:
- (JSC::SmallStringsStorage::rep):
- (JSC::SmallStringsStorage::SmallStringsStorage):
- (JSC::SmallStrings::SmallStrings):
- (JSC::SmallStrings::mark):
- Adjust to account for the changes in UString and put the UString in place in
- SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.
-
- * runtime/SmallStrings.h:
- * runtime/UString.cpp:
- (JSC::initializeStaticBaseString):
- (JSC::initializeUString):
- (JSC::UString::Rep::create):
- (JSC::UString::Rep::destroy):
- (JSC::UString::Rep::checkConsistency):
- (JSC::expandCapacity):
- (JSC::UString::expandPreCapacity):
- (JSC::concatenate):
- (JSC::UString::append):
- (JSC::UString::operator=):
- * runtime/UString.h:
- (JSC::UString::Rep::baseIsSelf):
- (JSC::UString::Rep::setBaseString):
- (JSC::UString::Rep::baseString):
- (JSC::UString::Rep::):
- (JSC::UString::Rep::null):
- (JSC::UString::Rep::empty):
- (JSC::UString::Rep::data):
- (JSC::UString::cost):
- Separate out the items out used by base strings from those used in Rep's that only
- point to base strings. (This potentially saves 24 bytes per Rep.)
-
-2009-01-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23239: improve handling of unused arguments in JavaScriptCore
- https://bugs.webkit.org/show_bug.cgi?id=23239
-
- * runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if
- so we can use this on all platforms. Changed valueOf to share the same
- function with getTime, since the contents of the two are identical. Removed
- a FIXME since the idea isn't really specific enough or helpful enough to
- need to sit here in the source code.
- (JSC::formatLocaleDate): Changed the Mac version of this function to take
- the same arguments as the non-Mac version so the caller doesn't have to
- special-case the two platforms. Also made the formatString array be const;
- before the characters were, but the array was a modifiable global variable.
- (JSC::dateProtoFuncToLocaleString): Changed to call the new unified
- version of formatLocaleDate and remove the ifdef.
- (JSC::dateProtoFuncToLocaleDateString): Ditto.
- (JSC::dateProtoFuncToLocaleTimeString): Ditto.
-
- * runtime/JSNotAnObject.cpp:
- (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the
- old UNUSED_PARAM.
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter
- is actually unused.
-
- * wtf/TCSystemAlloc.cpp:
- (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter
- is actually unused.
- (TCMalloc_SystemCommit): Changed to omit the argument names instead of using
- UNUSED_PARAM.
-
-2009-01-11 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix the build (whoops)
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_get_by_val):
-
-2009-01-11 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler and Anders Carlsson
-
- Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
-
- Restructure the code slightly, and add comments per Darin's suggestions
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_get_by_val_byte_array):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_byte_array):
-
-2009-01-11 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Whoops, I accidentally removed an exception check from fast the
- fast path for string indexing when i originally landed the
- byte array logic.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_get_by_val):
-
-2009-01-11 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
- <https://bugs.webkit.org/show_bug.cgi?id=23128>
-
- Fairly simple patch, add specialised versions of cti_op_get/put_by_val
- that assume ByteArray, thus avoiding a few branches in the case of bytearray
- manipulation.
-
- No effect on SunSpider. 15% win on the original testcase.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_get_by_val_byte_array):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_byte_array):
- * interpreter/Interpreter.h:
-
-2009-01-11 Alexey Proskuryakov <ap@webkit.org>
-
- Try to fix Windows build.
-
- * wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in
- DateMath.cpp, with constant definition in DateTime.h)
-
-2009-01-11 Alexey Proskuryakov <ap@webkit.org>
-
- Try to fix Windows build.
-
- * wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.
+ (JSC::JIT::restoreArgumentReference):
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_catch):
+ * jit/JITStubs.cpp:
+ (JSC::JITThunks::JITThunks):
-2009-01-11 Dmitry Titov <dimich@chromium.org>
+2009-06-19 Adam Treat <adam.treat@torchmobile.com>
- Reviewed by Darin Adler.
+ Blind attempt at build fix.
- https://bugs.webkit.org/show_bug.cgi?id=23207
- Moved currentTime() to from WebCore to WTF.
-
- * GNUmakefile.am:
- * JavaScriptCore.exp: added export for WTF::currentTime()
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * runtime/DateMath.cpp:
- (JSC::getCurrentUTCTimeWithMicroseconds): This function had another implementation of currentTime(), essentially. Now uses WTF version.
- * wtf/CurrentTime.cpp: Added.
- (WTF::currentTime):
- (WTF::highResUpTime):
- (WTF::lowResUTCTime):
- (WTF::qpcAvailable):
- * wtf/CurrentTime.h: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
-2009-01-09 Gavin Barraclough <barraclough@apple.com>
+2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
- Stage two of converting JSValue from a pointer to a class type.
- Remove the class JSValue. The functionallity has been transitioned
- into the wrapper class type JSValuePtr.
+ Inherits CallIdentifier struct from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.
- The last stage will be to rename JSValuePtr to JSValue, remove the
- overloaded -> operator, and switch operations on JSValuePtrs from
- using '->' to use '.' instead.
+ * wtf/HashCountedSet.h:
- * API/APICast.h:
- * JavaScriptCore.exp:
- * runtime/JSCell.h:
- (JSC::asCell):
- (JSC::JSValuePtr::asCell):
- (JSC::JSValuePtr::isNumber):
- (JSC::JSValuePtr::isString):
- (JSC::JSValuePtr::isGetterSetter):
- (JSC::JSValuePtr::isObject):
- (JSC::JSValuePtr::getNumber):
- (JSC::JSValuePtr::getString):
- (JSC::JSValuePtr::getObject):
- (JSC::JSValuePtr::getCallData):
- (JSC::JSValuePtr::getConstructData):
- (JSC::JSValuePtr::getUInt32):
- (JSC::JSValuePtr::getTruncatedInt32):
- (JSC::JSValuePtr::getTruncatedUInt32):
- (JSC::JSValuePtr::mark):
- (JSC::JSValuePtr::marked):
- (JSC::JSValuePtr::toPrimitive):
- (JSC::JSValuePtr::getPrimitiveNumber):
- (JSC::JSValuePtr::toBoolean):
- (JSC::JSValuePtr::toNumber):
- (JSC::JSValuePtr::toString):
- (JSC::JSValuePtr::toObject):
- (JSC::JSValuePtr::toThisObject):
- (JSC::JSValuePtr::needsThisConversion):
- (JSC::JSValuePtr::toThisString):
- (JSC::JSValuePtr::getJSNumber):
- * runtime/JSImmediate.h:
- (JSC::JSValuePtr::isUndefined):
- (JSC::JSValuePtr::isNull):
- (JSC::JSValuePtr::isUndefinedOrNull):
- (JSC::JSValuePtr::isBoolean):
- (JSC::JSValuePtr::getBoolean):
- (JSC::JSValuePtr::toInt32):
- (JSC::JSValuePtr::toUInt32):
- * runtime/JSNumberCell.h:
- (JSC::JSValuePtr::uncheckedGetNumber):
- (JSC::JSValuePtr::toJSNumber):
- * runtime/JSObject.h:
- (JSC::JSValuePtr::isObject):
- (JSC::JSValuePtr::get):
- (JSC::JSValuePtr::put):
- * runtime/JSString.h:
- (JSC::JSValuePtr::toThisJSString):
- * runtime/JSValue.cpp:
- (JSC::JSValuePtr::toInteger):
- (JSC::JSValuePtr::toIntegerPreserveNaN):
- (JSC::JSValuePtr::toInt32SlowCase):
- (JSC::JSValuePtr::toUInt32SlowCase):
- * runtime/JSValue.h:
- (JSC::JSValuePtr::makeImmediate):
- (JSC::JSValuePtr::immediateValue):
- (JSC::JSValuePtr::JSValuePtr):
- (JSC::JSValuePtr::operator->):
- (JSC::JSValuePtr::operator bool):
- (JSC::JSValuePtr::operator==):
- (JSC::JSValuePtr::operator!=):
- (JSC::JSValuePtr::encode):
- (JSC::JSValuePtr::decode):
- (JSC::JSValuePtr::toFloat):
- (JSC::JSValuePtr::asValue):
- (JSC::operator==):
- (JSC::operator!=):
-
-2009-01-09 David Levin <levin@chromium.org>
+2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
- https://bugs.webkit.org/show_bug.cgi?id=23175
-
- Adjustment to previous patch. Remove call to initilizeThreading from JSGlobalCreate
- and fix jsc.cpp instead.
+ https://bugs.webkit.org/show_bug.cgi?id=26540
+ Modify the test shell to add a new function 'checkSyntax' that will
+ only parse the source instead of executing it. In this way we can test
+ pure parsing performance against some of the larger scripts in the wild.
* jsc.cpp:
- (main):
- (jscmain):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::create):
-
-2009-01-09 Sam Weinig <sam@webkit.org>
-
- Roll r39720 back in with a working interpreted mode.
-
-2009-01-09 David Levin <levin@chromium.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23175
-
- Added a template to make the pointer and flags combination
- in UString more readable and less error prone.
-
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- Added PtrAndFlags.h (and sorted the xcode project file).
-
- * runtime/Identifier.cpp:
- (JSC::Identifier::add):
- (JSC::Identifier::addSlowCase):
- * runtime/InitializeThreading.cpp:
- (JSC::initializeThreadingOnce):
- Made the init threading initialize the UString globals. Before
- these were initilized using {} but that became harder due to the
- addition of this tempalte class.
-
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::create):
- * runtime/PropertyNameArray.cpp:
- (JSC::PropertyNameArray::add):
- * runtime/UString.cpp:
- (JSC::initializeStaticBaseString):
- (JSC::initializeUString):
- (JSC::UString::Rep::create):
- (JSC::UString::Rep::createFromUTF8):
- (JSC::createRep):
- (JSC::UString::UString):
- (JSC::concatenate):
- (JSC::UString::operator=):
- (JSC::UString::makeNull):
- (JSC::UString::nullRep):
- * runtime/UString.h:
- (JSC::UString::Rep::identifierTable):
- (JSC::UString::Rep::setIdentifierTable):
- (JSC::UString::Rep::isStatic):
- (JSC::UString::Rep::setStatic):
- (JSC::UString::Rep::):
- (JSC::UString::Rep::null):
- (JSC::UString::Rep::empty):
- (JSC::UString::isNull):
- (JSC::UString::null):
- (JSC::UString::UString):
-
- * wtf/PtrAndFlags.h: Added.
- (WTF::PtrAndFlags::PtrAndFlags):
- (WTF::PtrAndFlags::isFlagSet):
- (WTF::PtrAndFlags::setFlag):
- (WTF::PtrAndFlags::clearFlag):
- (WTF::PtrAndFlags::get):
- (WTF::PtrAndFlags::set):
- A simple way to layer together a pointer and 2 flags. It relies on the pointer being 4 byte aligned,
- which should happen for all allocators (due to aligning pointers, int's, etc. on 4 byte boundaries).
-
-2009-01-08 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by -O-l-i-v-e-r- -H-u-n-t- Sam Weinig (sorry, Sam!).
-
- Encode immediates in the low word of JSValuePtrs, on x86-64.
-
- On 32-bit platforms a JSValuePtr may represent a 31-bit signed integer.
- On 64-bit platforms, if USE(ALTERNATE_JSIMMEDIATE) is defined, a full
- 32-bit integer may be stored in an immediate.
-
- Presently USE(ALTERNATE_JSIMMEDIATE) uses the same encoding as the default
- immediate format - the value is left shifted by one, so a one bit tag can
- be added to indicate the value is an immediate. However this means that
- values must be commonly be detagged (by right shifting by one) before
- arithmetic operations can be performed on immediates. This patch modifies
- the formattting so the the high bits of the immediate mark values as being
- integer.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::not32):
- (JSC::MacroAssembler::orPtr):
- (JSC::MacroAssembler::zeroExtend32ToPtr):
- (JSC::MacroAssembler::jaePtr):
- (JSC::MacroAssembler::jbPtr):
- (JSC::MacroAssembler::jnzPtr):
- (JSC::MacroAssembler::jzPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::notl_r):
- (JSC::X86Assembler::testq_i32r):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_lshift):
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArith_op_bitand):
- (JSC::JIT::compileFastArithSlow_op_bitand):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArithSlow_op_mod):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArith_op_post_inc):
- (JSC::JIT::compileFastArith_op_post_dec):
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileFastArith_op_pre_dec):
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpIfJSCell):
- (JSC::JIT::emitJumpIfNotJSCell):
- (JSC::JIT::emitJumpIfImmNum):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
- (JSC::JIT::emitFastArithDeTagImmediate):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithImmToInt):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
- (JSC::JIT::emitTagAsBoolImmediate):
- * jit/JITPropertyAccess.cpp:
- (JSC::resizePropertyStorage):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::isNumber):
- (JSC::JSImmediate::isPositiveNumber):
- (JSC::JSImmediate::areBothImmediateNumbers):
- (JSC::JSImmediate::xorImmediateNumbers):
- (JSC::JSImmediate::rightShiftImmediateNumbers):
- (JSC::JSImmediate::canDoFastAdditiveOperations):
- (JSC::JSImmediate::addImmediateNumbers):
- (JSC::JSImmediate::subImmediateNumbers):
- (JSC::JSImmediate::makeInt):
- (JSC::JSImmediate::toBoolean):
- * wtf/Platform.h:
-
-2009-01-08 Sam Weinig <sam@webkit.org>
-
- Revert r39720. It broke Interpreted mode.
-
-2009-01-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23197
- Delay creating the PCVector until an exception is thrown
- Part of <rdar://problem/6469060>
- Don't store exception information for a CodeBlock until first exception is thrown
-
- - Change the process for re-parsing/re-generating bytecode for exception information
- to use data from the original CodeBlock (offsets of GlobalResolve instructions) to
- aid in creating an identical instruction stream on re-parse, instead of padding
- interchangeable opcodes, which would result in different JITed code.
- - Fix bug where the wrong ScopeChainNode was used when re-parsing/regenerating from
- within some odd modified scope chains.
- - Lazily create the pcVector by re-JITing the regenerated CodeBlock and stealing the
- the pcVector from it.
-
- Saves ~2MB on Membuster head.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
- (JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
- (JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
- * bytecode/CodeBlock.h:
- (JSC::JITCodeRef::JITCodeRef):
- (JSC::GlobalResolveInfo::GlobalResolveInfo):
- (JSC::CodeBlock::getBytecodeIndex):
- (JSC::CodeBlock::addGlobalResolveInstruction):
- (JSC::CodeBlock::addGlobalResolveInfo):
- (JSC::CodeBlock::addFunctionRegisterInfo):
- (JSC::CodeBlock::hasExceptionInfo):
- (JSC::CodeBlock::pcVector):
- (JSC::EvalCodeBlock::EvalCodeBlock):
- (JSC::EvalCodeBlock::baseScopeDepth):
- * bytecode/Opcode.h:
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::emitResolve):
- (JSC::BytecodeGenerator::emitGetScopedVar):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::setRegeneratingForExceptionInfo):
- * interpreter/Interpreter.cpp:
- (JSC::bytecodeOffsetForPC):
- (JSC::Interpreter::unwindCallFrame):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveLastCaller):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_vm_throw):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- * parser/Nodes.cpp:
- (JSC::EvalNode::generateBytecode):
- (JSC::EvalNode::bytecodeForExceptionInfoReparse):
- (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
- * parser/Nodes.h:
-
-2009-01-08 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Add Win32 implementation of ThreadSpecific.
- https://bugs.webkit.org/show_bug.cgi?id=22614
-
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * wtf/ThreadSpecific.h:
- (WTF::ThreadSpecific::ThreadSpecific):
- (WTF::ThreadSpecific::~ThreadSpecific):
- (WTF::ThreadSpecific::get):
- (WTF::ThreadSpecific::set):
- (WTF::ThreadSpecific::destroy):
- * wtf/ThreadSpecificWin.cpp: Added.
- (WTF::ThreadSpecificThreadExit):
- * wtf/ThreadingWin.cpp:
- (WTF::wtfThreadEntryPoint):
-
-2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix compilation with Qt on NetBSD.
-
- * runtime/Collector.cpp:
- (JSC::currentThreadStackBase): Use PLATFORM(NETBSD) to enter the
- code path to retrieve the stack base using pthread_attr_get_np.
- The PTHREAD_NP_H define is not used because the header file does
- not exist on NetBSD, but the function is declared nevertheless.
- * wtf/Platform.h: Introduce WTF_PLATFORM_NETBSD.
-
-2009-01-07 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- <rdar://problem/6469060> Don't store exception information for a CodeBlock until first exception is thrown
-
- Don't initially store exception information (lineNumber/expressionRange/getByIdExcecptionInfo)
- in CodeBlocks blocks. Instead, re-parse for the data on demand and cache it then.
-
- One important change that was needed to make this work was to pad op_get_global_var with nops to
- be the same length as op_resolve_global, since one could be replaced for the other on re-parsing,
- and we want to keep the offsets bytecode offsets the same.
-
- 1.3MB improvement on Membuster head.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Update op_get_global_var to account for the padding.
- (JSC::CodeBlock::dumpStatistics): Add more statistic dumping.
- (JSC::CodeBlock::CodeBlock): Initialize m_exceptionInfo.
- (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): Re-parses the CodeBlocks
- associated SourceCode and steals the ExceptionInfo from it.
- (JSC::CodeBlock::lineNumberForBytecodeOffset): Creates the exception info on demand.
- (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto.
- (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::numberOfExceptionHandlers): Updated to account for m_exceptionInfo indirection.
- (JSC::CodeBlock::addExceptionHandler): Ditto.
- (JSC::CodeBlock::exceptionHandler): Ditto.
- (JSC::CodeBlock::clearExceptionInfo): Ditto.
- (JSC::CodeBlock::addExpressionInfo): Ditto.
- (JSC::CodeBlock::addGetByIdExceptionInfo): Ditto.
- (JSC::CodeBlock::numberOfLineInfos): Ditto.
- (JSC::CodeBlock::addLineInfo): Ditto.
- (JSC::CodeBlock::lastLineInfo): Ditto.
-
- * bytecode/Opcode.h: Change length of op_get_global_var to match op_resolve_global.
-
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingTool::dump): Add comment indicating why it is okay not to pass a CallFrame.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate): Clear the exception info after generation for Function and Eval
- Code when not in regenerate for exception info mode.
- (JSC::BytecodeGenerator::BytecodeGenerator): Initialize m_regeneratingForExceptionInfo to false.
- (JSC::BytecodeGenerator::emitGetScopedVar): Pad op_get_global_var with 2 nops.
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::setRegeneratingForExcpeptionInfo): Added.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::throwException): Pass the CallFrame to exception info accessors.
- (JSC::Interpreter::privateExecute): Ditto.
- (JSC::Interpreter::retrieveLastCaller): Ditto.
- (JSC::Interpreter::cti_op_new_error): Ditto.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass): Pass the current bytecode offset instead of hard coding the
- line number, the stub will do the accessing if it gets called.
-
- * parser/Nodes.cpp:
- (JSC::ProgramNode::emitBytecode): Moved.
- (JSC::ProgramNode::generateBytecode): Moved.
- (JSC::EvalNode::create): Moved.
- (JSC::EvalNode::bytecodeForExceptionInfoReparse): Added.
- (JSC::FunctionBodyNode::generateBytecode): Rename reparse to reparseInPlace.
- (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse): Addded.
-
- * parser/Nodes.h:
- (JSC::ScopeNode::features): Added getter.
- * parser/Parser.cpp:
- (JSC::Parser::reparseInPlace): Renamed from reparse.
- * parser/Parser.h:
- (JSC::Parser::reparse): Added. Re-parses the passed in Node into
- a new Node.
- * runtime/ExceptionHelpers.cpp:
- (JSC::createUndefinedVariableError): Pass along CallFrame.
- (JSC::createInvalidParamError): Ditto.
- (JSC::createNotAConstructorError): Ditto.
- (JSC::createNotAFunctionError): Ditto.
- (JSC::createNotAnObjectError): Ditto.
-
-2009-01-06 Gavin Barraclough <baraclough@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Replace accidentally removed references in BytecodeGenerator, deleting these
- will be hindering the sharing of constant numbers and strings.
-
- The code to add a new constant (either number or string) to their respective
- map works by attempting to add a null entry, then checking the result of the
- add for null. The first time, this should return the null (or noValue).
- The code checks for null (to see if this is the initial add), and then allocates
- a new number / string object. This code relies on the result returned from
- the add to the map being stored as a reference, such that the allocated object
- will be stored in the map, and will be resused if the same constant is encountered
- again. By failing to use a reference we will be leaking GC object for each
- additional entry added to the map. As GC objects they should be clollected,
- be we should no be allocatin them in the first place.
-
- https://bugs.webkit.org/show_bug.cgi?id=23158
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitLoad):
-
-2009-01-06 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6040850> JavaScript register file should use VirtualAlloc on Windows
-
- Fairly simple, just reserve 4Mb of address space for the
- register file, and then commit one section at a time. We
- don't release committed memory as we drop back, but then
- mac doesn't either so this probably not too much of a
- problem.
-
- * interpreter/RegisterFile.cpp:
- (JSC::RegisterFile::~RegisterFile):
- * interpreter/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- (JSC::RegisterFile::grow):
-
-2009-01-06 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23142
- ThreadGlobalData leaks seen on buildbot
-
- * wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Temporarily reset the thread
- specific value to make getter work on Mac OS X.
-
- * wtf/Platform.h: Touch this file again to make sure all Windows builds use the most recent
- version of ThreadSpecific.h.
-
-2009-01-05 Gavin Barraclough <baraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Replace all uses of JSValue* with a new smart pointer type, JSValuePtr.
-
- A JavaScript value may be a heap object or boxed primitive, represented by a
- pointer, or may be an unboxed immediate value, such as an integer. Since a
- value may dynamically need to contain either a pointer value or an immediate,
- we encode immediates as pointer values (since all valid JSCell pointers are
- allocated at alligned addesses, unaligned addresses are available to encode
- immediates). As such all JavaScript values are represented using a JSValue*.
-
- This implementation is encumbered by a number of constraints. It ties the
- JSValue representation to the size of pointer on the platform, which, for
- example, means that we currently can represent different ranges of integers
- as immediates on x86 and x86-64. It also prevents us from overloading the
- to-boolean conversion used to test for noValue() - effectively forcing us
- to represent noValue() as 0. This would potentially be problematic were we
- to wish to encode integer values differently (e.g. were we to use the v8
- encoding, where pointers are tagged with 1 and integers with 0, then the
- immediate integer 0 would conflict with noValue()).
-
- This patch replaces all usage of JSValue* with a new class, JSValuePtr,
- which encapsulates the pointer. JSValuePtr maintains the same interface as
- JSValue*, overloading operator-> and operator bool such that previous
- operations in the code on variables of type JSValue* are still supported.
-
- In order to provide a ProtectPtr<> type with support for the new value
- representation (without using the internal JSValue type directly), a new
- ProtectJSValuePtr type has been added, equivalent to the previous type
- ProtectPtr<JSValue>.
-
- This patch is likely the first in a sequence of three changes. With the
- value now encapsulated it will likely make sense to migrate the functionality
- from JSValue into JSValuePtr, such that the internal pointer representation
- need not be exposed. Through migrating the functionality to the wrapper
- class the existing JSValue should be rendered redundant, and the class is
- likely to be removed (the JSValuePtr now wrapping a pointer to a JSCell).
- At this stage it will likely make sense to rename JSValuePtr to JSValue.
-
- https://bugs.webkit.org/show_bug.cgi?id=23114
-
- * API/APICast.h:
- (toJS):
- (toRef):
- * API/JSBase.cpp:
- (JSEvaluateScript):
- * API/JSCallbackConstructor.h:
- (JSC::JSCallbackConstructor::createStructure):
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::call):
- * API/JSCallbackFunction.h:
- (JSC::JSCallbackFunction::createStructure):
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::createStructure):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::asCallbackObject):
- (JSC::::put):
- (JSC::::hasInstance):
- (JSC::::call):
- (JSC::::staticValueGetter):
- (JSC::::staticFunctionGetter):
- (JSC::::callbackGetter):
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- (JSObjectMakeConstructor):
- (JSObjectSetPrototype):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectGetPropertyAtIndex):
- (JSObjectSetPropertyAtIndex):
- * API/JSValueRef.cpp:
- (JSValueGetType):
- (JSValueIsUndefined):
- (JSValueIsNull):
- (JSValueIsBoolean):
- (JSValueIsNumber):
- (JSValueIsString):
- (JSValueIsObject):
- (JSValueIsObjectOfClass):
- (JSValueIsEqual):
- (JSValueIsStrictEqual):
- (JSValueIsInstanceOfConstructor):
- (JSValueToBoolean):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- (JSValueProtect):
- (JSValueUnprotect):
- * JavaScriptCore.exp:
- * bytecode/CodeBlock.cpp:
- (JSC::valueToSourceString):
- (JSC::constantName):
- (JSC::CodeBlock::dump):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::getConstant):
- (JSC::CodeBlock::addUnexpectedConstant):
- (JSC::CodeBlock::unexpectedConstant):
- * bytecode/EvalCodeCache.h:
- (JSC::EvalCodeCache::get):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::addConstant):
- (JSC::BytecodeGenerator::addUnexpectedConstant):
- (JSC::BytecodeGenerator::emitLoad):
- (JSC::BytecodeGenerator::emitLoadJSV):
- (JSC::BytecodeGenerator::emitGetScopedVar):
- (JSC::BytecodeGenerator::emitPutScopedVar):
- (JSC::BytecodeGenerator::emitNewError):
- (JSC::keyForImmediateSwitch):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
- (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- * debugger/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate):
- * debugger/DebuggerCallFrame.h:
- (JSC::DebuggerCallFrame::DebuggerCallFrame):
- (JSC::DebuggerCallFrame::exception):
- * interpreter/CallFrame.cpp:
- (JSC::CallFrame::thisValue):
- * interpreter/CallFrame.h:
- (JSC::ExecState::setException):
- (JSC::ExecState::exception):
- (JSC::ExecState::exceptionSlot):
- (JSC::ExecState::hadException):
- * interpreter/Interpreter.cpp:
- (JSC::fastIsNumber):
- (JSC::fastToInt32):
- (JSC::fastToUInt32):
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAddSlowCase):
- (JSC::jsAdd):
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::jsIsFunctionType):
- (JSC::Interpreter::resolve):
- (JSC::Interpreter::resolveSkip):
- (JSC::Interpreter::resolveGlobal):
- (JSC::inlineResolveBase):
- (JSC::Interpreter::resolveBase):
- (JSC::Interpreter::resolveBaseAndProperty):
- (JSC::Interpreter::resolveBaseAndFunc):
- (JSC::isNotObject):
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::unwindCallFrame):
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::checkTimeout):
- (JSC::Interpreter::createExceptionScope):
- (JSC::cachePrototypeChain):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- (JSC::Interpreter::retrieveCaller):
- (JSC::Interpreter::retrieveLastCaller):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::returnToThrowTrampoline):
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_op_loop_if_less):
- (JSC::Interpreter::cti_op_loop_if_lesseq):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
- (JSC::Interpreter::cti_op_get_by_id_proto_fail):
- (JSC::Interpreter::cti_op_get_by_id_array_fail):
- (JSC::Interpreter::cti_op_get_by_id_string_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_lesseq):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_resolve_base):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_jless):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_less):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_call_eval):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_next_pname):
- (JSC::Interpreter::cti_op_typeof):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_is_boolean):
- (JSC::Interpreter::cti_op_is_number):
- (JSC::Interpreter::cti_op_is_string):
- (JSC::Interpreter::cti_op_is_object):
- (JSC::Interpreter::cti_op_is_function):
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_op_del_by_val):
- (JSC::Interpreter::cti_op_new_error):
- (JSC::Interpreter::cti_vm_throw):
- * interpreter/Interpreter.h:
- (JSC::Interpreter::isJSArray):
- (JSC::Interpreter::isJSString):
- * interpreter/Register.h:
- (JSC::Register::):
- (JSC::Register::Register):
- (JSC::Register::jsValue):
- (JSC::Register::getJSValue):
- * jit/JIT.cpp:
- (JSC::):
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- (JSC::):
- (JSC::JIT::execute):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCall):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::getConstantOperand):
- (JSC::JIT::isOperandConstant31BitImmediateInt):
- (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
- (JSC::JIT::emitInitRegister):
- * jit/JITPropertyAccess.cpp:
- (JSC::resizePropertyStorage):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * jsc.cpp:
- (functionPrint):
- (functionDebug):
- (functionGC):
- (functionVersion):
- (functionRun):
- (functionLoad):
- (functionReadline):
- (functionQuit):
- * parser/Nodes.cpp:
- (JSC::NullNode::emitBytecode):
- (JSC::ArrayNode::emitBytecode):
- (JSC::FunctionCallValueNode::emitBytecode):
- (JSC::FunctionCallResolveNode::emitBytecode):
- (JSC::VoidNode::emitBytecode):
- (JSC::ConstDeclNode::emitCodeSingle):
- (JSC::ReturnNode::emitBytecode):
- (JSC::processClauseList):
- (JSC::EvalNode::emitBytecode):
- (JSC::FunctionBodyNode::emitBytecode):
- (JSC::ProgramNode::emitBytecode):
- * profiler/ProfileGenerator.cpp:
- (JSC::ProfileGenerator::addParentForConsoleStart):
- * profiler/Profiler.cpp:
- (JSC::Profiler::willExecute):
- (JSC::Profiler::didExecute):
- (JSC::Profiler::createCallIdentifier):
- * profiler/Profiler.h:
- * runtime/ArgList.cpp:
- (JSC::ArgList::slowAppend):
- * runtime/ArgList.h:
- (JSC::ArgList::at):
- (JSC::ArgList::append):
- * runtime/Arguments.cpp:
- (JSC::Arguments::put):
- * runtime/Arguments.h:
- (JSC::Arguments::createStructure):
- (JSC::asArguments):
- * runtime/ArrayConstructor.cpp:
- (JSC::callArrayConstructor):
- * runtime/ArrayPrototype.cpp:
- (JSC::getProperty):
- (JSC::putProperty):
- (JSC::arrayProtoFuncToString):
- (JSC::arrayProtoFuncToLocaleString):
- (JSC::arrayProtoFuncJoin):
- (JSC::arrayProtoFuncConcat):
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- (JSC::arrayProtoFuncReverse):
- (JSC::arrayProtoFuncShift):
- (JSC::arrayProtoFuncSlice):
- (JSC::arrayProtoFuncSort):
- (JSC::arrayProtoFuncSplice):
- (JSC::arrayProtoFuncUnShift):
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncMap):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncForEach):
- (JSC::arrayProtoFuncSome):
- (JSC::arrayProtoFuncIndexOf):
- (JSC::arrayProtoFuncLastIndexOf):
- * runtime/BooleanConstructor.cpp:
- (JSC::callBooleanConstructor):
- (JSC::constructBooleanFromImmediateBoolean):
- * runtime/BooleanConstructor.h:
- * runtime/BooleanObject.h:
- (JSC::asBooleanObject):
- * runtime/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncToString):
- (JSC::booleanProtoFuncValueOf):
- * runtime/CallData.cpp:
- (JSC::call):
- * runtime/CallData.h:
- * runtime/Collector.cpp:
- (JSC::Heap::protect):
- (JSC::Heap::unprotect):
- (JSC::Heap::heap):
- (JSC::Heap::collect):
- * runtime/Collector.h:
- * runtime/Completion.cpp:
- (JSC::evaluate):
- * runtime/Completion.h:
- (JSC::Completion::Completion):
- (JSC::Completion::value):
- (JSC::Completion::setValue):
- (JSC::Completion::isValueCompletion):
- * runtime/ConstructData.cpp:
- (JSC::construct):
- * runtime/ConstructData.h:
- * runtime/DateConstructor.cpp:
- (JSC::constructDate):
- (JSC::callDate):
- (JSC::dateParse):
- (JSC::dateNow):
- (JSC::dateUTC):
- * runtime/DateInstance.h:
- (JSC::asDateInstance):
- * runtime/DatePrototype.cpp:
- (JSC::dateProtoFuncToString):
- (JSC::dateProtoFuncToUTCString):
- (JSC::dateProtoFuncToDateString):
- (JSC::dateProtoFuncToTimeString):
- (JSC::dateProtoFuncToLocaleString):
- (JSC::dateProtoFuncToLocaleDateString):
- (JSC::dateProtoFuncToLocaleTimeString):
- (JSC::dateProtoFuncValueOf):
- (JSC::dateProtoFuncGetTime):
- (JSC::dateProtoFuncGetFullYear):
- (JSC::dateProtoFuncGetUTCFullYear):
- (JSC::dateProtoFuncToGMTString):
- (JSC::dateProtoFuncGetMonth):
- (JSC::dateProtoFuncGetUTCMonth):
- (JSC::dateProtoFuncGetDate):
- (JSC::dateProtoFuncGetUTCDate):
- (JSC::dateProtoFuncGetDay):
- (JSC::dateProtoFuncGetUTCDay):
- (JSC::dateProtoFuncGetHours):
- (JSC::dateProtoFuncGetUTCHours):
- (JSC::dateProtoFuncGetMinutes):
- (JSC::dateProtoFuncGetUTCMinutes):
- (JSC::dateProtoFuncGetSeconds):
- (JSC::dateProtoFuncGetUTCSeconds):
- (JSC::dateProtoFuncGetMilliSeconds):
- (JSC::dateProtoFuncGetUTCMilliseconds):
- (JSC::dateProtoFuncGetTimezoneOffset):
- (JSC::dateProtoFuncSetTime):
- (JSC::setNewValueFromTimeArgs):
- (JSC::setNewValueFromDateArgs):
- (JSC::dateProtoFuncSetMilliSeconds):
- (JSC::dateProtoFuncSetUTCMilliseconds):
- (JSC::dateProtoFuncSetSeconds):
- (JSC::dateProtoFuncSetUTCSeconds):
- (JSC::dateProtoFuncSetMinutes):
- (JSC::dateProtoFuncSetUTCMinutes):
- (JSC::dateProtoFuncSetHours):
- (JSC::dateProtoFuncSetUTCHours):
- (JSC::dateProtoFuncSetDate):
- (JSC::dateProtoFuncSetUTCDate):
- (JSC::dateProtoFuncSetMonth):
- (JSC::dateProtoFuncSetUTCMonth):
- (JSC::dateProtoFuncSetFullYear):
- (JSC::dateProtoFuncSetUTCFullYear):
- (JSC::dateProtoFuncSetYear):
- (JSC::dateProtoFuncGetYear):
- * runtime/DatePrototype.h:
- (JSC::DatePrototype::createStructure):
- * runtime/ErrorConstructor.cpp:
- (JSC::callErrorConstructor):
- * runtime/ErrorPrototype.cpp:
- (JSC::errorProtoFuncToString):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createInterruptedExecutionException):
- (JSC::createError):
- (JSC::createStackOverflowError):
- (JSC::createUndefinedVariableError):
- (JSC::createErrorMessage):
- (JSC::createInvalidParamError):
- (JSC::createNotAConstructorError):
- (JSC::createNotAFunctionError):
- * runtime/ExceptionHelpers.h:
- * runtime/FunctionConstructor.cpp:
- (JSC::callFunctionConstructor):
- * runtime/FunctionPrototype.cpp:
- (JSC::callFunctionPrototype):
- (JSC::functionProtoFuncToString):
- (JSC::functionProtoFuncApply):
- (JSC::functionProtoFuncCall):
- * runtime/FunctionPrototype.h:
- (JSC::FunctionPrototype::createStructure):
- * runtime/GetterSetter.cpp:
- (JSC::GetterSetter::toPrimitive):
- (JSC::GetterSetter::getPrimitiveNumber):
- * runtime/GetterSetter.h:
- (JSC::asGetterSetter):
- * runtime/InitializeThreading.cpp:
- * runtime/InternalFunction.h:
- (JSC::InternalFunction::createStructure):
- (JSC::asInternalFunction):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::getOwnPropertySlot):
- (JSC::JSActivation::put):
- (JSC::JSActivation::putWithAttributes):
- (JSC::JSActivation::argumentsGetter):
- * runtime/JSActivation.h:
- (JSC::JSActivation::createStructure):
- (JSC::asActivation):
- * runtime/JSArray.cpp:
- (JSC::storageSize):
- (JSC::JSArray::JSArray):
- (JSC::JSArray::getOwnPropertySlot):
- (JSC::JSArray::put):
- (JSC::JSArray::putSlowCase):
- (JSC::JSArray::deleteProperty):
- (JSC::JSArray::getPropertyNames):
- (JSC::JSArray::setLength):
- (JSC::JSArray::pop):
- (JSC::JSArray::push):
- (JSC::JSArray::mark):
- (JSC::JSArray::sort):
- (JSC::JSArray::compactForSorting):
- (JSC::JSArray::checkConsistency):
- (JSC::constructArray):
- * runtime/JSArray.h:
- (JSC::JSArray::getIndex):
- (JSC::JSArray::setIndex):
- (JSC::JSArray::createStructure):
- (JSC::asArray):
- * runtime/JSCell.cpp:
- (JSC::JSCell::put):
- (JSC::JSCell::getJSNumber):
- * runtime/JSCell.h:
- (JSC::asCell):
- (JSC::JSValue::asCell):
- (JSC::JSValue::toPrimitive):
- (JSC::JSValue::getPrimitiveNumber):
- (JSC::JSValue::getJSNumber):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::call):
- (JSC::JSFunction::argumentsGetter):
- (JSC::JSFunction::callerGetter):
- (JSC::JSFunction::lengthGetter):
- (JSC::JSFunction::getOwnPropertySlot):
- (JSC::JSFunction::put):
- (JSC::JSFunction::construct):
- * runtime/JSFunction.h:
- (JSC::JSFunction::createStructure):
- (JSC::asFunction):
- * runtime/JSGlobalData.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::markIfNeeded):
- (JSC::JSGlobalObject::put):
- (JSC::JSGlobalObject::putWithAttributes):
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::resetPrototype):
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::createStructure):
- (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo):
- (JSC::asGlobalObject):
- (JSC::Structure::prototypeForLookup):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::encode):
- (JSC::decode):
- (JSC::globalFuncEval):
- (JSC::globalFuncParseInt):
- (JSC::globalFuncParseFloat):
- (JSC::globalFuncIsNaN):
- (JSC::globalFuncIsFinite):
- (JSC::globalFuncDecodeURI):
- (JSC::globalFuncDecodeURIComponent):
- (JSC::globalFuncEncodeURI):
- (JSC::globalFuncEncodeURIComponent):
- (JSC::globalFuncEscape):
- (JSC::globalFuncUnescape):
- (JSC::globalFuncJSCPrint):
- * runtime/JSGlobalObjectFunctions.h:
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject):
- (JSC::JSImmediate::toObject):
- (JSC::JSImmediate::prototype):
- (JSC::JSImmediate::toString):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::isImmediate):
- (JSC::JSImmediate::isNumber):
- (JSC::JSImmediate::isPositiveNumber):
- (JSC::JSImmediate::isBoolean):
- (JSC::JSImmediate::isUndefinedOrNull):
- (JSC::JSImmediate::isNegative):
- (JSC::JSImmediate::isEitherImmediate):
- (JSC::JSImmediate::isAnyImmediate):
- (JSC::JSImmediate::areBothImmediate):
- (JSC::JSImmediate::areBothImmediateNumbers):
- (JSC::JSImmediate::andImmediateNumbers):
- (JSC::JSImmediate::xorImmediateNumbers):
- (JSC::JSImmediate::orImmediateNumbers):
- (JSC::JSImmediate::rightShiftImmediateNumbers):
- (JSC::JSImmediate::canDoFastAdditiveOperations):
- (JSC::JSImmediate::addImmediateNumbers):
- (JSC::JSImmediate::subImmediateNumbers):
- (JSC::JSImmediate::incImmediateNumber):
- (JSC::JSImmediate::decImmediateNumber):
- (JSC::JSImmediate::makeValue):
- (JSC::JSImmediate::makeInt):
- (JSC::JSImmediate::makeBool):
- (JSC::JSImmediate::makeUndefined):
- (JSC::JSImmediate::makeNull):
- (JSC::JSImmediate::intValue):
- (JSC::JSImmediate::uintValue):
- (JSC::JSImmediate::boolValue):
- (JSC::JSImmediate::rawValue):
- (JSC::JSImmediate::trueImmediate):
- (JSC::JSImmediate::falseImmediate):
- (JSC::JSImmediate::undefinedImmediate):
- (JSC::JSImmediate::nullImmediate):
- (JSC::JSImmediate::zeroImmediate):
- (JSC::JSImmediate::oneImmediate):
- (JSC::JSImmediate::impossibleValue):
- (JSC::JSImmediate::toBoolean):
- (JSC::JSImmediate::getTruncatedUInt32):
- (JSC::JSImmediate::from):
- (JSC::JSImmediate::getTruncatedInt32):
- (JSC::JSImmediate::toDouble):
- (JSC::JSImmediate::getUInt32):
- (JSC::jsNull):
- (JSC::jsBoolean):
- (JSC::jsUndefined):
- (JSC::JSValue::isUndefined):
- (JSC::JSValue::isNull):
- (JSC::JSValue::isUndefinedOrNull):
- (JSC::JSValue::isBoolean):
- (JSC::JSValue::getBoolean):
- (JSC::JSValue::toInt32):
- (JSC::JSValue::toUInt32):
- (JSC::toInt32):
- (JSC::toUInt32):
- * runtime/JSNotAnObject.cpp:
- (JSC::JSNotAnObject::toPrimitive):
- (JSC::JSNotAnObject::getPrimitiveNumber):
- (JSC::JSNotAnObject::put):
- * runtime/JSNotAnObject.h:
- (JSC::JSNotAnObject::createStructure):
- * runtime/JSNumberCell.cpp:
- (JSC::JSNumberCell::toPrimitive):
- (JSC::JSNumberCell::getPrimitiveNumber):
- (JSC::JSNumberCell::getJSNumber):
- (JSC::jsNumberCell):
- (JSC::jsNaN):
- * runtime/JSNumberCell.h:
- (JSC::JSNumberCell::createStructure):
- (JSC::asNumberCell):
- (JSC::jsNumber):
- (JSC::JSValue::toJSNumber):
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::put):
- (JSC::JSObject::putWithAttributes):
- (JSC::callDefaultValueFunction):
- (JSC::JSObject::getPrimitiveNumber):
- (JSC::JSObject::defaultValue):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- (JSC::JSObject::lookupGetter):
- (JSC::JSObject::lookupSetter):
- (JSC::JSObject::hasInstance):
- (JSC::JSObject::toNumber):
- (JSC::JSObject::toString):
- (JSC::JSObject::fillGetterPropertySlot):
- * runtime/JSObject.h:
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::offsetForLocation):
- (JSC::JSObject::locationForOffset):
- (JSC::JSObject::getDirectOffset):
- (JSC::JSObject::putDirectOffset):
- (JSC::JSObject::createStructure):
- (JSC::asObject):
- (JSC::JSObject::prototype):
- (JSC::JSObject::setPrototype):
- (JSC::JSObject::inlineGetOwnPropertySlot):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSObject::getPropertySlot):
- (JSC::JSObject::get):
- (JSC::JSObject::putDirect):
- (JSC::JSObject::putDirectWithoutTransition):
- (JSC::JSObject::toPrimitive):
- (JSC::JSValue::get):
- (JSC::JSValue::put):
- (JSC::JSObject::allocatePropertyStorageInline):
- * runtime/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::toPrimitive):
- (JSC::JSPropertyNameIterator::getPrimitiveNumber):
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::create):
- (JSC::JSPropertyNameIterator::next):
- * runtime/JSStaticScopeObject.cpp:
- (JSC::JSStaticScopeObject::put):
- (JSC::JSStaticScopeObject::putWithAttributes):
- * runtime/JSStaticScopeObject.h:
- (JSC::JSStaticScopeObject::JSStaticScopeObject):
- (JSC::JSStaticScopeObject::createStructure):
- * runtime/JSString.cpp:
- (JSC::JSString::toPrimitive):
- (JSC::JSString::getPrimitiveNumber):
- (JSC::JSString::getOwnPropertySlot):
- * runtime/JSString.h:
- (JSC::JSString::createStructure):
- (JSC::asString):
- * runtime/JSValue.h:
- (JSC::JSValuePtr::makeImmediate):
- (JSC::JSValuePtr::immediateValue):
- (JSC::JSValuePtr::JSValuePtr):
- (JSC::JSValuePtr::operator->):
- (JSC::JSValuePtr::hasValue):
- (JSC::JSValuePtr::operator==):
- (JSC::JSValuePtr::operator!=):
- (JSC::JSValuePtr::encode):
- (JSC::JSValuePtr::decode):
- (JSC::JSValue::asValue):
- (JSC::noValue):
- (JSC::operator==):
- (JSC::operator!=):
- * runtime/JSVariableObject.h:
- (JSC::JSVariableObject::symbolTablePut):
- (JSC::JSVariableObject::symbolTablePutWithAttributes):
- * runtime/JSWrapperObject.cpp:
- (JSC::JSWrapperObject::mark):
- * runtime/JSWrapperObject.h:
- (JSC::JSWrapperObject::internalValue):
- (JSC::JSWrapperObject::setInternalValue):
- * runtime/Lookup.cpp:
- (JSC::setUpStaticFunctionSlot):
- * runtime/Lookup.h:
- (JSC::lookupPut):
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncAbs):
- (JSC::mathProtoFuncACos):
- (JSC::mathProtoFuncASin):
- (JSC::mathProtoFuncATan):
- (JSC::mathProtoFuncATan2):
- (JSC::mathProtoFuncCeil):
- (JSC::mathProtoFuncCos):
- (JSC::mathProtoFuncExp):
- (JSC::mathProtoFuncFloor):
- (JSC::mathProtoFuncLog):
- (JSC::mathProtoFuncMax):
- (JSC::mathProtoFuncMin):
- (JSC::mathProtoFuncPow):
- (JSC::mathProtoFuncRandom):
- (JSC::mathProtoFuncRound):
- (JSC::mathProtoFuncSin):
- (JSC::mathProtoFuncSqrt):
- (JSC::mathProtoFuncTan):
- * runtime/MathObject.h:
- (JSC::MathObject::createStructure):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::callNativeErrorConstructor):
- * runtime/NumberConstructor.cpp:
- (JSC::numberConstructorNaNValue):
- (JSC::numberConstructorNegInfinity):
- (JSC::numberConstructorPosInfinity):
- (JSC::numberConstructorMaxValue):
- (JSC::numberConstructorMinValue):
- (JSC::callNumberConstructor):
- * runtime/NumberConstructor.h:
- (JSC::NumberConstructor::createStructure):
- * runtime/NumberObject.cpp:
- (JSC::NumberObject::getJSNumber):
- (JSC::constructNumberFromImmediateNumber):
- * runtime/NumberObject.h:
- * runtime/NumberPrototype.cpp:
- (JSC::numberProtoFuncToString):
- (JSC::numberProtoFuncToLocaleString):
- (JSC::numberProtoFuncValueOf):
- (JSC::numberProtoFuncToFixed):
- (JSC::numberProtoFuncToExponential):
- (JSC::numberProtoFuncToPrecision):
- * runtime/ObjectConstructor.cpp:
- (JSC::constructObject):
- (JSC::callObjectConstructor):
- * runtime/ObjectPrototype.cpp:
- (JSC::objectProtoFuncValueOf):
- (JSC::objectProtoFuncHasOwnProperty):
- (JSC::objectProtoFuncIsPrototypeOf):
- (JSC::objectProtoFuncDefineGetter):
- (JSC::objectProtoFuncDefineSetter):
- (JSC::objectProtoFuncLookupGetter):
- (JSC::objectProtoFuncLookupSetter):
- (JSC::objectProtoFuncPropertyIsEnumerable):
- (JSC::objectProtoFuncToLocaleString):
- (JSC::objectProtoFuncToString):
- * runtime/ObjectPrototype.h:
- * runtime/Operations.cpp:
- (JSC::equal):
- (JSC::equalSlowCase):
- (JSC::strictEqual):
- (JSC::strictEqualSlowCase):
- (JSC::throwOutOfMemoryError):
- * runtime/Operations.h:
- (JSC::equalSlowCaseInline):
- (JSC::strictEqualSlowCaseInline):
- * runtime/PropertySlot.cpp:
- (JSC::PropertySlot::functionGetter):
- * runtime/PropertySlot.h:
- (JSC::PropertySlot::PropertySlot):
- (JSC::PropertySlot::getValue):
- (JSC::PropertySlot::putValue):
- (JSC::PropertySlot::setValueSlot):
- (JSC::PropertySlot::setValue):
- (JSC::PropertySlot::setCustom):
- (JSC::PropertySlot::setCustomIndex):
- (JSC::PropertySlot::slotBase):
- (JSC::PropertySlot::setBase):
- (JSC::PropertySlot::):
- * runtime/Protect.h:
- (JSC::gcProtect):
- (JSC::gcUnprotect):
- (JSC::ProtectedPtr::ProtectedPtr):
- (JSC::ProtectedPtr::operator JSValuePtr):
- (JSC::ProtectedJSValuePtr::ProtectedJSValuePtr):
- (JSC::ProtectedJSValuePtr::get):
- (JSC::ProtectedJSValuePtr::operator JSValuePtr):
- (JSC::ProtectedJSValuePtr::operator->):
- (JSC::::ProtectedPtr):
- (JSC::::~ProtectedPtr):
- (JSC::::operator):
- (JSC::ProtectedJSValuePtr::~ProtectedJSValuePtr):
- (JSC::ProtectedJSValuePtr::operator=):
- (JSC::operator==):
- (JSC::operator!=):
- * runtime/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::getBackref):
- (JSC::RegExpConstructor::getLastParen):
- (JSC::RegExpConstructor::getLeftContext):
- (JSC::RegExpConstructor::getRightContext):
- (JSC::regExpConstructorDollar1):
- (JSC::regExpConstructorDollar2):
- (JSC::regExpConstructorDollar3):
- (JSC::regExpConstructorDollar4):
- (JSC::regExpConstructorDollar5):
- (JSC::regExpConstructorDollar6):
- (JSC::regExpConstructorDollar7):
- (JSC::regExpConstructorDollar8):
- (JSC::regExpConstructorDollar9):
- (JSC::regExpConstructorInput):
- (JSC::regExpConstructorMultiline):
- (JSC::regExpConstructorLastMatch):
- (JSC::regExpConstructorLastParen):
- (JSC::regExpConstructorLeftContext):
- (JSC::regExpConstructorRightContext):
- (JSC::RegExpConstructor::put):
- (JSC::setRegExpConstructorInput):
- (JSC::setRegExpConstructorMultiline):
- (JSC::constructRegExp):
- (JSC::callRegExpConstructor):
- * runtime/RegExpConstructor.h:
- (JSC::RegExpConstructor::createStructure):
- (JSC::asRegExpConstructor):
- * runtime/RegExpMatchesArray.h:
- (JSC::RegExpMatchesArray::put):
- * runtime/RegExpObject.cpp:
- (JSC::regExpObjectGlobal):
- (JSC::regExpObjectIgnoreCase):
- (JSC::regExpObjectMultiline):
- (JSC::regExpObjectSource):
- (JSC::regExpObjectLastIndex):
- (JSC::RegExpObject::put):
- (JSC::setRegExpObjectLastIndex):
- (JSC::RegExpObject::test):
- (JSC::RegExpObject::exec):
- (JSC::callRegExpObject):
- * runtime/RegExpObject.h:
- (JSC::RegExpObject::createStructure):
- (JSC::asRegExpObject):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncTest):
- (JSC::regExpProtoFuncExec):
- (JSC::regExpProtoFuncCompile):
- (JSC::regExpProtoFuncToString):
- * runtime/StringConstructor.cpp:
- (JSC::stringFromCharCodeSlowCase):
- (JSC::stringFromCharCode):
- (JSC::callStringConstructor):
- * runtime/StringObject.cpp:
- (JSC::StringObject::put):
- * runtime/StringObject.h:
- (JSC::StringObject::createStructure):
- (JSC::asStringObject):
- * runtime/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncToString):
- (JSC::stringProtoFuncCharAt):
- (JSC::stringProtoFuncCharCodeAt):
- (JSC::stringProtoFuncConcat):
- (JSC::stringProtoFuncIndexOf):
- (JSC::stringProtoFuncLastIndexOf):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- (JSC::stringProtoFuncSlice):
- (JSC::stringProtoFuncSplit):
- (JSC::stringProtoFuncSubstr):
- (JSC::stringProtoFuncSubstring):
- (JSC::stringProtoFuncToLowerCase):
- (JSC::stringProtoFuncToUpperCase):
- (JSC::stringProtoFuncLocaleCompare):
- (JSC::stringProtoFuncBig):
- (JSC::stringProtoFuncSmall):
- (JSC::stringProtoFuncBlink):
- (JSC::stringProtoFuncBold):
- (JSC::stringProtoFuncFixed):
- (JSC::stringProtoFuncItalics):
- (JSC::stringProtoFuncStrike):
- (JSC::stringProtoFuncSub):
- (JSC::stringProtoFuncSup):
- (JSC::stringProtoFuncFontcolor):
- (JSC::stringProtoFuncFontsize):
- (JSC::stringProtoFuncAnchor):
- (JSC::stringProtoFuncLink):
- * runtime/Structure.cpp:
- (JSC::Structure::Structure):
- (JSC::Structure::changePrototypeTransition):
- (JSC::Structure::createCachedPrototypeChain):
- * runtime/Structure.h:
- (JSC::Structure::create):
- (JSC::Structure::setPrototypeWithoutTransition):
- (JSC::Structure::storedPrototype):
-
-2009-01-06 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- <https://bugs.webkit.org/show_bug.cgi?id=23085> [jsfunfuzz] Over released ScopeChainNode
- <rdar://problem/6474110>
-
- So this delightful bug was caused by our unwind code using a ScopeChain to perform
- the unwind. The ScopeChain would ref the initial top of the scope chain, then deref
- the resultant top of scope chain, which is incorrect.
-
- This patch removes the dependency on ScopeChain for the unwind, and i've filed
- <https://bugs.webkit.org/show_bug.cgi?id=23144> to look into the unintuitive
- ScopeChain behaviour.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::throwException):
-
-2009-01-06 Adam Roben <aroben@apple.com>
-
- Hopeful Windows crash-on-launch fix
-
- * wtf/Platform.h: Force a world rebuild by touching this file.
-
-2009-01-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by NOBODY (Build fix).
-
- * GNUmakefile.am:Add ByteArray.cpp too
-
-2009-01-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by NOBODY (Speculative build fix).
-
- AllInOneFile.cpp does not include the JSByteArray.cpp include it...
-
- * GNUmakefile.am:
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix Wx build
-
- * JavaScriptCoreSources.bkl:
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Windows build fixes
-
- Rubber-stamped by Alice Liu.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- * runtime/ByteArray.cpp:
- (JSC::ByteArray::create):
- * runtime/ByteArray.h:
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- CanvasPixelArray performance is too slow
- <https://bugs.webkit.org/show_bug.cgi?id=23123>
-
- The fix to this is to devirtualise get and put in a manner similar to
- JSString and JSArray. To do this I've added a ByteArray implementation
- and JSByteArray wrapper to JSC. We can then do vptr comparisons to
- devirtualise the calls.
-
- This devirtualisation improves performance by 1.5-2x in my somewhat ad
- hoc tests.
-
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_put_by_val):
- * interpreter/Interpreter.h:
- (JSC::Interpreter::isJSByteArray):
- * runtime/ByteArray.cpp: Added.
- (JSC::ByteArray::create):
- * runtime/ByteArray.h: Added.
- (JSC::ByteArray::length):
- (JSC::ByteArray::set):
- (JSC::ByteArray::get):
- (JSC::ByteArray::data):
- (JSC::ByteArray::ByteArray):
- * runtime/JSByteArray.cpp: Added.
- (JSC::):
- (JSC::JSByteArray::JSByteArray):
- (JSC::JSByteArray::createStructure):
- (JSC::JSByteArray::getOwnPropertySlot):
- (JSC::JSByteArray::put):
- (JSC::JSByteArray::getPropertyNames):
- * runtime/JSByteArray.h: Added.
- (JSC::JSByteArray::canAccessIndex):
- (JSC::JSByteArray::getIndex):
- (JSC::JSByteArray::setIndex):
- (JSC::JSByteArray::classInfo):
- (JSC::JSByteArray::length):
- (JSC::JSByteArray::):
- (JSC::JSByteArray::JSByteArray):
- (JSC::asByteArray):
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23073
- <rdar://problem/6471129> Workers crash on Windows Release builds
-
- * wtf/ThreadSpecific.h:
- (WTF::ThreadSpecific::destroy): Changed to clear the pointer only after data object
- destruction is finished - otherwise, WebCore::ThreadGlobalData destructor was re-creating
- the object in order to access atomic string table.
- (WTF::ThreadSpecific::operator T*): Symmetrically, set up the per-thread pointer before
- data constructor is called.
-
- * wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): Remove a Windows-only hack to finalize
- a thread - pthreadVC2 is a DLL, so it gets thread detached messages, and cleans up thread
- specific data automatically. Besides, this code wasn't even compiled in for some time now.
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23115
- Create a version of ASSERT for use with otherwise unused variables
-
- * wtf/Assertions.h: Added ASSERT_UNUSED.
-
- * jit/ExecutableAllocatorPosix.cpp:
- (JSC::ExecutablePool::systemRelease):
- * runtime/Collector.cpp:
- (JSC::Heap::destroy):
- (JSC::Heap::heapAllocate):
- * runtime/JSNotAnObject.cpp:
- (JSC::JSNotAnObject::toPrimitive):
- (JSC::JSNotAnObject::getPrimitiveNumber):
- (JSC::JSNotAnObject::toBoolean):
- (JSC::JSNotAnObject::toNumber):
- (JSC::JSNotAnObject::toString):
- (JSC::JSNotAnObject::getOwnPropertySlot):
- (JSC::JSNotAnObject::put):
- (JSC::JSNotAnObject::deleteProperty):
- (JSC::JSNotAnObject::getPropertyNames):
- * wtf/TCSystemAlloc.cpp:
- (TCMalloc_SystemRelease):
- Use it in some places that used other idioms for this purpose.
-
-2009-01-04 Alice Liu <alice.liu@apple.com>
-
- <rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.
-
- Reviewed by Darin Adler.
-
- * runtime/Structure.cpp:
- (JSC::Structure::Structure): Remove m_transitionCount
- (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up.
- (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount.
- (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount.
- (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
- * runtime/Structure.h:
- Changed s_maxTransitionLength and m_offset from size_t to signed char. m_offset will never become greater than 64
- because the structure transitions to a dictionary at that time.
- (JSC::Structure::transitionCount): method to replace the data member
-
-2009-01-04 Darin Adler <darin@apple.com>
-
- Reviewed by David Kilzer.
-
- Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.
- https://bugs.webkit.org/show_bug.cgi?id=15114
-
- * wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.
-
-2009-01-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Change the pcVector from storing native code pointers to storing offsets
- from the base pointer. This will allow us to generate the pcVector on demand
- for exceptions.
-
- * bytecode/CodeBlock.h:
- (JSC::PC::PC):
- (JSC::getNativePCOffset):
- (JSC::CodeBlock::getBytecodeIndex):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
-
-2009-01-02 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- * runtime/ScopeChain.cpp:
-
-2009-01-02 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- [jsfunfuzz] unwind logic for exceptions in eval fails to account for dynamic scope external to the eval
- https://bugs.webkit.org/show_bug.cgi?id=23078
-
- This bug was caused by eval codeblocks being generated without accounting
- for the depth of the scope chain they inherited. This meant that exception
- handlers would understate their expected scope chain depth, which in turn
- led to incorrectly removing nodes from the scope chain.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::emitCatch):
- * bytecompiler/BytecodeGenerator.h:
- * interpreter/Interpreter.cpp:
- (JSC::depth):
- * runtime/ScopeChain.cpp:
- (JSC::ScopeChain::localDepth):
- * runtime/ScopeChain.h:
- (JSC::ScopeChainNode::deref):
- (JSC::ScopeChainNode::ref):
+ (GlobalObject::GlobalObject):
+ (functionCheckSyntax):
-2009-01-02 David Smith <catfish.man@gmail.com>
+2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=22699
- Enable NodeList caching for getElementsByTagName
-
- * wtf/HashFunctions.h: Moved the definition of PHI here and renamed to stringHashingStartValue
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Attempt to fix Qt Linux build after r39553
-
- * wtf/RandomNumberSeed.h: Include <sys/time.h> for gettimeofday().
- Include <sys/types.h> and <unistd.h> for getpid().
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Bug 23081: These files are no longer part of the KDE libraries
+ Inherits HashCountedSet class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
- <https://bugs.webkit.org/show_bug.cgi?id=23081>
-
- Reviewed by Darin Adler.
-
- Removed "This file is part of the KDE libraries" comment from
- source files. Added or updated Apple copyrights as well.
-
- * parser/Lexer.h:
* wtf/HashCountedSet.h:
- * wtf/RetainPtr.h:
- * wtf/VectorTraits.h:
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Bug 23080: Remove last vestiges of KJS references
-
- <https://bugs.webkit.org/show_bug.cgi?id=23080>
-
- Reviewed by Darin Adler.
- Also updated Apple copyright statements.
-
- * DerivedSources.make: Changed bison "kjsyy" prefix to "jscyy".
- * GNUmakefile.am: Ditto.
- * JavaScriptCore.pri: Ditto. Also changed KJSBISON to JSCBISON
- and kjsbison to jscbison.
-
- * JavaScriptCoreSources.bkl: Changed JSCORE_KJS_SOURCES to
- JSCORE_JSC_SOURCES.
- * jscore.bkl: Ditto.
-
- * create_hash_table: Updated copyright and removed old comment.
-
- * parser/Grammar.y: Changed "kjsyy" prefix to "jscyy" prefix.
- * parser/Lexer.cpp: Ditto. Also changed KJS_DEBUG_LEX to
- JSC_DEBUG_LEX.
- (jscyylex):
- (JSC::Lexer::lex):
- * parser/Parser.cpp: Ditto.
- (JSC::Parser::parse):
-
- * pcre/dftables: Changed "kjs_pcre_" prefix to "jsc_pcre_".
- * pcre/pcre_compile.cpp: Ditto.
- (getOthercaseRange):
- (encodeUTF8):
- (compileBranch):
- (calculateCompiledPatternLength):
- * pcre/pcre_exec.cpp: Ditto.
- (matchRef):
- (getUTF8CharAndIncrementLength):
- (match):
- * pcre/pcre_internal.h: Ditto.
- (toLowerCase):
- (flipCase):
- (classBitmapForChar):
- (charTypeForChar):
- * pcre/pcre_tables.cpp: Ditto.
- * pcre/pcre_ucp_searchfuncs.cpp: Ditto.
- (jsc_pcre_ucp_othercase):
- * pcre/pcre_xclass.cpp: Ditto.
- (getUTF8CharAndAdvancePointer):
- (jsc_pcre_xclass):
-
- * runtime/Collector.h: Updated header guards using the
- clean-header-guards script.
- * runtime/CollectorHeapIterator.h: Added missing header guard.
- * runtime/Identifier.h: Updated header guards.
- * runtime/JSFunction.h: Fixed end-of-namespace comment.
-
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset): Renamed "kjsprint" debug function
- to "jscprint". Changed implementation method from
- globalFuncKJSPrint() to globalFuncJSCPrint().
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncJSCPrint): Renamed from globalFuncKJSPrint().
- * runtime/JSGlobalObjectFunctions.h: Ditto.
-
- * runtime/JSImmediate.h: Updated header guards.
- * runtime/JSLock.h: Ditto.
- * runtime/JSType.h: Ditto.
- * runtime/JSWrapperObject.h: Ditto.
- * runtime/Lookup.h: Ditto.
- * runtime/Operations.h: Ditto.
- * runtime/Protect.h: Ditto.
- * runtime/RegExp.h: Ditto.
- * runtime/UString.h: Ditto.
+2009-06-19 Yong Li <yong.li@torchmobile.com>
- * tests/mozilla/js1_5/Array/regress-157652.js: Changed "KJS"
- reference in comment to "JSC".
+ Reviewed by George Staikos.
- * wrec/CharacterClassConstructor.cpp: Change "kjs_pcre_" function
- prefixes to "jsc_pcre_".
- (JSC::WREC::CharacterClassConstructor::put):
- (JSC::WREC::CharacterClassConstructor::flush):
+ https://bugs.webkit.org/show_bug.cgi?id=26558
+ Declare these symbols extern for WINCE as they are provided by libce.
- * wtf/unicode/Unicode.h: Change "KJS_" header guard to "WTF_".
- * wtf/unicode/icu/UnicodeIcu.h: Ditto.
- * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
+ * runtime/DateConstructor.cpp:
+ * runtime/DatePrototype.cpp:
+ (JSC::formatLocaleDate):
-2009-01-02 Oliver Hunt <oliver@apple.com>
+2009-06-19 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
- Make randomNumber generate 2^53 values instead of 2^32 (or 2^31 for rand() platforms)
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
+ <rdar://problem/6988973> ScopeChain leak in interpreter builds
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Remove declaration for JSC::Identifier::initializeIdentifierThreading()
-
- Reviewed by Alexey Proskuryakov.
-
- * runtime/Identifier.h:
- (JSC::Identifier::initializeIdentifierThreading): Removed
- declaration since the implementation was removed in r34412.
-
-2009-01-01 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- String.replace does not support $& replacement metacharacter when search term is not a RegExp
- <https://bugs.webkit.org/show_bug.cgi?id=21431>
- <rdar://problem/6274993>
-
- Test: fast/js/string-replace-3.html
-
- * runtime/StringPrototype.cpp:
- (JSC::substituteBackreferences): Added a null check here so we won't try to handle $$-$9
- backreferences when the search term is a string, not a RegExp. Added a check for 0 so we
- won't try to handle $0 or $00 as a backreference.
- (JSC::stringProtoFuncReplace): Added a call to substituteBackreferences.
-
-2009-01-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Darin Adler.
-
- Allow 32-bit integers to be stored in JSImmediates, on x64-bit.
- Presently the top 32-bits of a 64-bit JSImmediate serve as a sign extension of a 31-bit
- int stored in the low word (shifted left by one, to make room for a tag). In the new
- format, the top 31-bits serve as a sign extension of a 32-bit int, still shifted left by
- one.
-
- The new behavior is enabled using a flag in Platform.h, 'WTF_USE_ALTERNATE_JSIMMEDIATE'.
- When this is set the constants defining the range of ints allowed to be stored as
- JSImmediate values is extended. The code in JSImmediate.h can safely operate on either
- format. This patch updates the JIT so that it can also operate with the new format.
-
- ~2% progression on x86-64, with & without the JIT, on sunspider & v8 tests.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::orPtr):
- (JSC::MacroAssembler::or32):
- (JSC::MacroAssembler::rshiftPtr):
- (JSC::MacroAssembler::rshift32):
- (JSC::MacroAssembler::subPtr):
- (JSC::MacroAssembler::xorPtr):
- (JSC::MacroAssembler::xor32):
- (JSC::MacroAssembler::move):
- (JSC::MacroAssembler::compareImm64ForBranch):
- (JSC::MacroAssembler::compareImm64ForBranchEquality):
- (JSC::MacroAssembler::jePtr):
- (JSC::MacroAssembler::jgePtr):
- (JSC::MacroAssembler::jlPtr):
- (JSC::MacroAssembler::jlePtr):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jnzSubPtr):
- (JSC::MacroAssembler::joAddPtr):
- (JSC::MacroAssembler::jzSubPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::addq_rr):
- (JSC::X86Assembler::orq_ir):
- (JSC::X86Assembler::subq_ir):
- (JSC::X86Assembler::xorq_rr):
- (JSC::X86Assembler::sarq_CLr):
- (JSC::X86Assembler::sarq_i8r):
- (JSC::X86Assembler::cmpq_ir):
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileFastArith_op_lshift):
- (JSC::JIT::compileFastArithSlow_op_lshift):
- (JSC::JIT::compileFastArith_op_rshift):
- (JSC::JIT::compileFastArithSlow_op_rshift):
- (JSC::JIT::compileFastArith_op_bitand):
- (JSC::JIT::compileFastArithSlow_op_bitand):
- (JSC::JIT::compileFastArith_op_mod):
- (JSC::JIT::compileFastArithSlow_op_mod):
- (JSC::JIT::compileFastArith_op_add):
- (JSC::JIT::compileFastArithSlow_op_add):
- (JSC::JIT::compileFastArith_op_mul):
- (JSC::JIT::compileFastArithSlow_op_mul):
- (JSC::JIT::compileFastArith_op_post_inc):
- (JSC::JIT::compileFastArithSlow_op_post_inc):
- (JSC::JIT::compileFastArith_op_post_dec):
- (JSC::JIT::compileFastArithSlow_op_post_dec):
- (JSC::JIT::compileFastArith_op_pre_inc):
- (JSC::JIT::compileFastArithSlow_op_pre_inc):
- (JSC::JIT::compileFastArith_op_pre_dec):
- (JSC::JIT::compileFastArithSlow_op_pre_dec):
- (JSC::JIT::compileBinaryArithOp):
- * jit/JITInlineMethods.h:
- (JSC::JIT::getConstantOperand):
- (JSC::JIT::getConstantOperandImmediateInt):
- (JSC::JIT::isOperandConstantImmediateInt):
- (JSC::JIT::isOperandConstant31BitImmediateInt):
- (JSC::JIT::emitFastArithDeTagImmediate):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithImmToInt):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::isPositiveNumber):
- (JSC::JSImmediate::isNegative):
- (JSC::JSImmediate::rightShiftImmediateNumbers):
- (JSC::JSImmediate::canDoFastAdditiveOperations):
- (JSC::JSImmediate::makeValue):
- (JSC::JSImmediate::makeInt):
- (JSC::JSImmediate::makeBool):
- (JSC::JSImmediate::intValue):
- (JSC::JSImmediate::rawValue):
- (JSC::JSImmediate::toBoolean):
- (JSC::JSImmediate::from):
- * wtf/Platform.h:
-
-2008-12-31 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- [jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable in a catch block
- <https://bugs.webkit.org/show_bug.cgi?id=23063>
-
- Eval inside a catch block attempts to use the catch block's static scope in
- an unsafe way by attempting to add new properties to the scope. This patch
- fixes this issue simply by preventing the catch block from using a static
- scope if it contains an eval.
-
- * parser/Grammar.y:
- * parser/Nodes.cpp:
- (JSC::TryNode::emitBytecode):
- * parser/Nodes.h:
- (JSC::TryNode::):
-
-2008-12-31 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- [jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
- <https://bugs.webkit.org/show_bug.cgi?id=23062>
-
- This was caused by the expression information for the initial resolve of
- eval not being emitted. If this resolve was the first instruction that
- could throw an exception the information search would fail leading to an
- assertion failure. If it was not the first throwable opcode the wrong
- expression information would used.
-
- Fix is simply to emit the expression info.
-
- * parser/Nodes.cpp:
- (JSC::EvalFunctionCallNode::emitBytecode):
-
-2008-12-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 23054: Caching of global lookups occurs even when the global object has become a dictionary
- <https://bugs.webkit.org/show_bug.cgi?id=23054>
- <rdar://problem/6469905>
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::resolveGlobal): Do not cache lookup if the global
- object has transitioned to a dictionary.
- (JSC::Interpreter::cti_op_resolve_global): Do not cache lookup if the
- global object has transitioned to a dictionary.
-
-2008-12-30 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler.
-
- <https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correctly protect their scope object
- <rdar://problem/6469742> Crash in JSC::TypeInfo::hasStandardGetOwnPropertySlot() running jsfunfuzz
-
- The problem that caused this was that with nodes were not correctly protecting
- the final object that was placed in the scope chain. We correct this by forcing
- the use of a temporary register (which stops us relying on a local register
- protecting the scope) and changing the behaviour of op_push_scope so that it
- will store the final scope object.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitPushScope):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_push_scope):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * parser/Nodes.cpp:
- (JSC::WithNode::emitBytecode):
-
-2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Sam Weinig.
-
- Bug 23037: Parsing and reparsing disagree on automatic semicolon insertion
- <https://bugs.webkit.org/show_bug.cgi?id=23037>
- <rdar://problem/6467124>
-
- Parsing and reparsing disagree about automatic semicolon insertion, so that a
- function like
-
- function() { a = 1, }
-
- is parsed as being syntactically valid but gets a syntax error upon reparsing.
- This leads to an assertion failure in Parser::reparse(). It is not that big of
- an issue in practice, because in a Release build such a function will return
- 'undefined' when called.
-
- In this case, we are not following the spec and it should be a syntax error.
- However, unless there is a newline separating the ',' and the '}', WebKit would
- not treat it as a syntax error in the past either. It would be a bit of work to
- make the automatic semicolon insertion match the spec exactly, so this patch
- changes it to match our past behaviour.
-
- The problem is that even during reparsing, the Lexer adds a semicolon at the
- end of the input, which confuses allowAutomaticSemicolon(), because it is
- expecting either a '}', the end of input, or a terminator like a newline.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::Lexer): Initialize m_isReparsing to false.
- (JSC::Lexer::lex): Do not perform automatic semicolon insertion in the Lexer if
- we are in the middle of reparsing.
- (JSC::Lexer::clear): Set m_isReparsing to false.
- * parser/Lexer.h:
- (JSC::Lexer::setIsReparsing): Added.
- * parser/Parser.cpp:
- (JSC::Parser::reparse): Call Lexer::setIsReparsing() to notify the Lexer of
- reparsing.
-
-2008-12-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Yet another attempt to fix Tiger.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
-
-2008-12-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Tiger build fix (correct this time)
-
- * wtf/RandomNumber.cpp:
-
-2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Revert r39509, because kjsyydebug is used in the generated code if YYDEBUG is 1.
-
- * parser/Grammar.y:
-
-2008-12-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Tiger build fix.
-
- * wtf/RandomNumber.cpp:
-
-2008-12-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6358108> Insecure randomness in Math.random() leads to user tracking
-
- Switch to arc4random on PLATFORM(DARWIN), this is ~1.5x slower than random(), but the
- it is still so fast that there is no fathomable way it could be a bottleneck for anything.
-
- randomNumber is called in two places
- * During form submission where it is called once per form
- * Math.random in JSC. For this difference to show up you have to be looping on
- a cached local copy of random, for a large (>10000) calls.
-
- No change in SunSpider.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
- * wtf/RandomNumberSeed.h:
- (WTF::initializeRandomNumberGenerator):
-
-2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Sam Weinig.
-
- Remove unused kjsyydebug #define.
-
- * parser/Grammar.y:
-
-2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt and Sam Weinig.
-
- Bug 23029: REGRESSION (r39337): jsfunfuzz generates identical test files
- <https://bugs.webkit.org/show_bug.cgi?id=23029>
- <rdar://problem/6469185>
-
- The unification of random number generation in r39337 resulted in random()
- being initialized on Darwin, but rand() actually being used. Fix this by
- making randomNumber() use random() instead of rand() on Darwin.
-
- * wtf/RandomNumber.cpp:
- (WTF::randomNumber):
-
-2008-12-29 Sam Weinig <sam@webkit.org>
-
- Fix buildbots.
-
- * runtime/Structure.cpp:
-
-2008-12-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=23026
- Move the deleted offsets vector into the PropertyMap
-
- Saves 3 words per Structure.
-
- * runtime/PropertyMapHashTable.h:
- * runtime/Structure.cpp:
- (JSC::Structure::addPropertyTransition):
- (JSC::Structure::changePrototypeTransition):
- (JSC::Structure::getterSetterTransition):
- (JSC::Structure::toDictionaryTransition):
- (JSC::Structure::fromDictionaryTransition):
- (JSC::Structure::copyPropertyTable):
- (JSC::Structure::put):
- (JSC::Structure::remove):
- (JSC::Structure::rehashPropertyMapHashTable):
- * runtime/Structure.h:
- (JSC::Structure::propertyStorageSize):
-
-2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Change code using m_body.get() as a boolean to take advantage of the
- implicit conversion of RefPtr to boolean.
+ Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
+ path.
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
-
-2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 22840: REGRESSION (r38349): Gmail doesn't load with profiling enabled
- <https://bugs.webkit.org/show_bug.cgi?id=22840>
- <rdar://problem/6468077>
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitNewArray): Add an assertion that the range
- of registers passed to op_new_array is sequential.
- (JSC::BytecodeGenerator::emitCall): Correct the relocation of registers
- when emitting profiler hooks so that registers aren't leaked. Also, add
- an assertion that the 'this' register is always ref'd (because it is),
- remove the needless protection of the 'this' register when relocating,
- and add an assertion that the range of registers passed to op_call for
- function call arguments is sequential.
- (JSC::BytecodeGenerator::emitConstruct): Correct the relocation of
- registers when emitting profiler hooks so that registers aren't leaked.
- Also, add an assertion that the range of registers passed to op_construct
- for function call arguments is sequential.
-
-2008-12-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- <rdar://problem/6467376> Race condition in WTF::currentThread can lead to a thread using two different identifiers during its lifetime
-
- If a newly-created thread calls WTF::currentThread() before WTF::createThread calls establishIdentifierForPthreadHandle
- then more than one identifier will be used for the same thread. We can avoid this by adding some extra synchronization
- during thread creation that delays the execution of the thread function until the thread identifier has been set up, and
- an assertion to catch this problem should it reappear in the future.
-
- * wtf/Threading.cpp: Added.
- (WTF::NewThreadContext::NewThreadContext):
- (WTF::threadEntryPoint):
- (WTF::createThread): Add cross-platform createThread function that delays the execution of the thread function until
- after the thread identifier has been set up.
- * wtf/Threading.h:
- * wtf/ThreadingGtk.cpp:
- (WTF::establishIdentifierForThread):
- (WTF::createThreadInternal):
- * wtf/ThreadingNone.cpp:
- (WTF::createThreadInternal):
- * wtf/ThreadingPthreads.cpp:
- (WTF::establishIdentifierForPthreadHandle):
- (WTF::createThreadInternal):
- * wtf/ThreadingQt.cpp:
- (WTF::identifierByQthreadHandle):
- (WTF::establishIdentifierForThread):
- (WTF::createThreadInternal):
- * wtf/ThreadingWin.cpp:
- (WTF::storeThreadHandleByIdentifier):
- (WTF::createThreadInternal):
-
- Add Threading.cpp to the build.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
-
-2008-12-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove unused method.
-
- * runtime/Structure.h: Remove mutableTypeInfo.
-
-2008-12-22 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix rounding / bounds / signed comparison bug in ExecutableAllocator.
-
- ExecutableAllocator::alloc assumed that m_freePtr would be aligned. This was
- not always true, since the first allocation from an additional pool would not
- be rounded up. Subsequent allocations would be unaligned, and too much memory
- could be erroneously allocated from the pool, when the size requested was
- available, but the size rounded up to word granularity was not available in the
- pool. This may result in the value of m_freePtr being greater than m_end.
-
- Under these circumstances, the unsigned check for space will always pass,
- resulting in pointers to memory outside of the arena being returned, and
- ultimately segfaulty goodness when attempting to memcpy the hot freshly jitted
- code from the AssemblerBuffer.
-
- https://bugs.webkit.org/show_bug.cgi?id=22974
- ... and probably many, many more.
-
- * jit/ExecutableAllocator.h:
- (JSC::ExecutablePool::alloc):
- (JSC::ExecutablePool::roundUpAllocationSize):
- (JSC::ExecutablePool::ExecutablePool):
- (JSC::ExecutablePool::poolAllocate):
-
-2008-12-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Rename all uses of the term "repatch" to "patch".
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::DataLabelPtr::patch):
- (JSC::MacroAssembler::DataLabel32::patch):
- (JSC::MacroAssembler::Jump::patch):
- (JSC::MacroAssembler::PatchBuffer::PatchBuffer):
- (JSC::MacroAssembler::PatchBuffer::setPtr):
- (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
- (JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
- (JSC::MacroAssembler::storePtrWithPatch):
- (JSC::MacroAssembler::jnePtrWithPatch):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::patchAddress):
- (JSC::X86Assembler::patchImmediate):
- (JSC::X86Assembler::patchPointer):
- (JSC::X86Assembler::patchBranchOffset):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- * jit/JIT.cpp:
- (JSC::ctiPatchCallByReturnAddress):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::linkCall):
- (JSC::JIT::compileOpCall):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
-
-2008-12-22 Adam Roben <aroben@apple.com>
-
- Build fix after r39428
-
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSlowCase): Added a missing MacroAssembler::
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by George Staikos.
-
- Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
-
- * wtf/RandomNumber.cpp:
- * wtf/RandomNumber.h:
- * wtf/RandomNumberSeed.h:
-
-2008-12-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by George Staikos.
-
- Fix copyright of the new RandomNumber* files.
-
- * wtf/RandomNumber.cpp:
- * wtf/RandomNumber.h:
- * wtf/RandomNumberSeed.h:
-
-2008-12-21 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt & Cameron Zwarich.
-
- Add support for call and property access repatching on x86-64.
-
- No change in performance on current configurations (2x impovement on v8-tests with JIT enabled on x86-64).
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::DataLabelPtr::repatch):
- (JSC::MacroAssembler::DataLabelPtr::operator X86Assembler::JmpDst):
- (JSC::MacroAssembler::DataLabel32::repatch):
- (JSC::MacroAssembler::RepatchBuffer::addressOf):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::loadPtrWithAddressOffsetRepatch):
- (JSC::MacroAssembler::storePtrWithAddressOffsetRepatch):
- (JSC::MacroAssembler::jePtr):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jnePtrWithRepatch):
- (JSC::MacroAssembler::differenceBetween):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::addl_im):
- (JSC::X86Assembler::subl_im):
- (JSC::X86Assembler::cmpl_rm):
- (JSC::X86Assembler::movq_rm_disp32):
- (JSC::X86Assembler::movq_mr_disp32):
- (JSC::X86Assembler::repatchPointer):
- (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITCall.cpp:
- (JSC::JIT::unlinkCall):
- (JSC::JIT::linkCall):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::resizePropertyStorage):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- * wtf/Platform.h:
-
-2008-12-20 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Port optimized property access generation to the MacroAssembler.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::AbsoluteAddress::AbsoluteAddress):
- (JSC::MacroAssembler::DataLabelPtr::repatch):
- (JSC::MacroAssembler::DataLabel32::DataLabel32):
- (JSC::MacroAssembler::DataLabel32::repatch):
- (JSC::MacroAssembler::Label::operator X86Assembler::JmpDst):
- (JSC::MacroAssembler::Jump::repatch):
- (JSC::MacroAssembler::JumpList::empty):
- (JSC::MacroAssembler::RepatchBuffer::link):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::and32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::loadPtrWithAddressRepatch):
- (JSC::MacroAssembler::storePtrWithAddressRepatch):
- (JSC::MacroAssembler::push):
- (JSC::MacroAssembler::ja32):
- (JSC::MacroAssembler::jePtr):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jnePtrWithRepatch):
- (JSC::MacroAssembler::align):
- (JSC::MacroAssembler::differenceBetween):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::movl_rm_disp32):
- (JSC::X86Assembler::movl_mr_disp32):
- (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32):
- (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
- * jit/JIT.cpp:
- (JSC::ctiRepatchCallByReturnAddress):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::resizePropertyStorage):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * wtf/RefCounted.h:
- (WTF::RefCountedBase::addressOfCount):
-
-2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=22686
-
- Added file which was missing to the javascriptcore_sources
- variable, so that it shows up in the tarball created by `make
- dist'.
-
- * GNUmakefile.am:
-
-2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Antti Koivisto.
-
- Build fix when building JS API tests with a c89 c compiler
-
- Do not use C++ style comments and convert them to C comments.
-
* wtf/Platform.h:
-2008-12-18 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Same as last revision, adding cases for pre & post inc & dec.
-
- https://bugs.webkit.org/show_bug.cgi?id=22928
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2008-12-18 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixes for the JIT's handling of JSImmediate values on x86-64.
- On 64-bit systems, the code in JSImmediate.h relies on the upper
- bits of a JSImmediate being a sign extension of the low 32-bits.
- This was not being enforced by the JIT, since a number of inline
- operations were being performed on 32-bit values in registers, and
- when a 32-bit result is written to a register on x86-64 the value
- is zero-extended to 64-bits.
-
- This fix honors previous behavoir. A better fix in the long run
- (when the JIT is enabled by default) may be to change JSImmediate.h
- so it no longer relies on the upper bits of the pointer,... though
- if we're going to change JSImmediate.h for 64-bit, we probably may
- as well change the format so that the full range of 32-bit ints can
- be stored, rather than just 31-bits.
-
- https://bugs.webkit.org/show_bug.cgi?id=22925
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::andPtr):
- (JSC::MacroAssembler::orPtr):
- (JSC::MacroAssembler::or32):
- (JSC::MacroAssembler::xor32):
- (JSC::MacroAssembler::xorPtr):
- (JSC::MacroAssembler::signExtend32ToPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::andq_rr):
- (JSC::X86Assembler::andq_ir):
- (JSC::X86Assembler::orq_rr):
- (JSC::X86Assembler::xorq_ir):
- (JSC::X86Assembler::movsxd_rr):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
- (JSC::JIT::emitFastArithImmToInt):
-
-2008-12-18 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Just a tidy up - rename & refactor some the #defines configuring the JIT.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_end):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_timeout_check):
- (JSC::Interpreter::cti_register_file_check):
- (JSC::Interpreter::cti_op_loop_if_less):
- (JSC::Interpreter::cti_op_loop_if_lesseq):
- (JSC::Interpreter::cti_op_new_object):
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
- (JSC::Interpreter::cti_op_get_by_id_proto_fail):
- (JSC::Interpreter::cti_op_get_by_id_array_fail):
- (JSC::Interpreter::cti_op_get_by_id_string_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_new_func):
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_op_call_arityCheck):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- (JSC::Interpreter::cti_op_push_activation):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_create_arguments):
- (JSC::Interpreter::cti_op_create_arguments_no_params):
- (JSC::Interpreter::cti_op_tear_off_activation):
- (JSC::Interpreter::cti_op_tear_off_arguments):
- (JSC::Interpreter::cti_op_profile_will_call):
- (JSC::Interpreter::cti_op_profile_did_call):
- (JSC::Interpreter::cti_op_ret_scopeChain):
- (JSC::Interpreter::cti_op_new_array):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_JSConstruct):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_lesseq):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_resolve_base):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_jless):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_new_func_exp):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_less):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_new_regexp):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_call_eval):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_get_pnames):
- (JSC::Interpreter::cti_op_next_pname):
- (JSC::Interpreter::cti_op_push_scope):
- (JSC::Interpreter::cti_op_pop_scope):
- (JSC::Interpreter::cti_op_typeof):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_is_boolean):
- (JSC::Interpreter::cti_op_is_number):
- (JSC::Interpreter::cti_op_is_string):
- (JSC::Interpreter::cti_op_is_object):
- (JSC::Interpreter::cti_op_is_function):
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_push_new_scope):
- (JSC::Interpreter::cti_op_jmp_scopes):
- (JSC::Interpreter::cti_op_put_by_index):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_op_del_by_val):
- (JSC::Interpreter::cti_op_put_getter):
- (JSC::Interpreter::cti_op_put_setter):
- (JSC::Interpreter::cti_op_new_error):
- (JSC::Interpreter::cti_op_debug):
- (JSC::Interpreter::cti_vm_throw):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- * wtf/Platform.h:
-
-2008-12-18 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
- <https://bugs.webkit.org/show_bug.cgi?id=21855>
- <rdar://problem/6278244>
-
- Move DynamicGlobalObjectScope to JSGlobalObject.h so that it can be used
- from WebCore.
-
- * interpreter/Interpreter.cpp:
- * runtime/JSGlobalObject.h:
- (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
- (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
-
-2008-12-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22393
- Segfault when caching property accesses to primitive cells.
-
- Changed some asObject casts to asCell casts in cases where a primitive
- value may be a cell and not an object.
-
- Re-enabled property caching for primitives in cases where it had been
- disabled because of this bug.
-
- Updated a comment to better explain something Darin thought needed
- explaining in an old patch review.
-
- * interpreter/Interpreter.cpp:
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
-
-2008-12-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixes for Sunspider failures with the JIT enabled on x86-64.
-
- * assembler/MacroAssembler.h:
- Switch the order of the RegisterID & Address form of je32, to keep it consistent with jne32.
- * jit/JIT.cpp:
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- Port the m_ctiVirtualCall tramopline generation to use the MacroAssembler interface.
- * jit/JITCall.cpp:
- Fix bug in the non-optimizing code path, vptr check should have been to the memory address pointer
- to by the register, not to the register itself.
- * wrec/WRECGenerator.cpp:
- See assembler/MacroAssembler.h, above.
-
-2008-12-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- print("Hello, 64-bit jitted world!");
- Get hello-world working through the JIT, on x86-64.
-
- * assembler/X86Assembler.h:
- Fix encoding of opcode + RegisterID format instructions for 64-bit.
- * interpreter/Interpreter.cpp:
- * interpreter/Interpreter.h:
- Make VoidPtrPair actually be a pair of void*s.
- (Possibly should make this change for 32-bit Mac platforms, too - but won't change 32-bit behaviour in this patch).
- * jit/JIT.cpp:
- * jit/JIT.h:
- Provide names for the timeoutCheckRegister & callFrameRegister on x86-64,
- force x86-64 ctiTrampoline arguments onto the stack,
- implement the asm trampolines for x86-64,
- implement the restoreArgumentReference methods for x86-64 calling conventions.
- * jit/JITCall.cpp:
- * jit/JITInlineMethods.h:
- * wtf/Platform.h:
- Add switch settings to ENABLE(JIT), on PLATFORM(X86_64) (currently still disabled).
-
-2008-12-17 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Add more CodeBlock statistics.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dumpStatistics):
+2009-06-19 Yong Li <yong.li@torchmobile.com>
-2008-12-17 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22897
- <rdar://problem/6428342>
- Look into feasibility of discarding bytecode after native codegen
-
- Clear the bytecode Instruction vector at the end JIT generation.
-
- Saves 4.8 MB on Membuster head.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Add logging for the case that someone tries
- to dump the instructions of a CodeBlock that has had its bytecode
- vector cleared.
- (JSC::CodeBlock::CodeBlock): Initialize the instructionCount
- (JSC::CodeBlock::handlerForBytecodeOffset): Use instructionCount instead
- of the size of the instruction vector in the assertion.
- (JSC::CodeBlock::lineNumberForBytecodeOffset): Ditto.
- (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto.
- (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
- (JSC::CodeBlock::functionRegisterForBytecodeOffset): Ditto.
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::setInstructionCount): Store the instruction vector size
- in debug builds for assertions.
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile): Clear the bytecode vector unless we
- have compiled with Opcode sampling where we will continue to require it
-
-2008-12-17 Cary Clark <caryclark@google.com>
-
- Reviewed by Darin Adler.
- Landed by Adam Barth.
-
- Add ENABLE_TEXT_CARET to permit the ANDROID platform
- to invalidate and draw the caret in a separate thread.
-
- * wtf/Platform.h:
- Default ENABLE_TEXT_CARET to 1.
-
-2008-12-17 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Don't use unique context group in JSGlobalContextCreate() on Tiger or Leopard, take two.
-
- * API/JSContextRef.cpp: The previous patch that claimed to do this was making Tiger and
- Leopard always use unique context group instead.
-
-2008-12-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22838
- Remove dependency on the bytecode Instruction buffer in Interpreter::throwException
- Part of <rdar://problem/6428342>
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::functionRegisterForBytecodeOffset): Added. Function to get
- a function Register index in a callFrame for a bytecode offset.
- (JSC::CodeBlock::shrinkToFit): Shrink m_getByIdExceptionInfo and m_functionRegisterInfos.
- * bytecode/CodeBlock.h:
- (JSC::FunctionRegisterInfo::FunctionRegisterInfo): Added.
- (JSC::CodeBlock::addFunctionRegisterInfo):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitCall):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::throwException): Use functionRegisterForBytecodeOffset in JIT
- mode.
-
-2008-12-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough.
+ Reviewed by George Staikos.
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22837
- Remove dependency on the bytecode Instruction buffer in Interpreter::cti_op_call_NotJSFunction
- Part of <rdar://problem/6428342>
+ https://bugs.webkit.org/show_bug.cgi?id=26543
+ Windows CE uses 'GetLastError' instead of 'errno.'
- * interpreter/CallFrame.h: Added comment regarding returnPC storing a void*.
- * interpreter/Interpreter.cpp:
- (JSC::bytecodeOffsetForPC): We no longer have any cases of the PC
- being in the instruction stream for JIT, so we can remove the check.
- (JSC::Interpreter::cti_op_call_NotJSFunction): Use the CTI_RETURN_ADDRESS
- as the call frame returnPC as it is only necessary for looking up when
- throwing an exception.
* interpreter/RegisterFile.h:
- (JSC::RegisterFile::): Added comment regarding returnPC storing a void*.
- * jit/JIT.h: Remove ARG_instr4.
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSetupArgs): Don't pass the instruction pointer.
-
-2008-12-16 Darin Adler <darin@apple.com>
-
- Reviewed and landed by Cameron Zwarich.
-
- Preparatory work for fixing
-
- Bug 22887: Make UString::Rep use RefCounted rather than implementing its own ref counting
- <https://bugs.webkit.org/show_bug.cgi?id=22887>
-
- Change the various string translators used by Identifier:add() so that
- they never zero the ref count of a newly created UString::Rep.
-
- * runtime/Identifier.cpp:
- (JSC::CStringTranslator::translate):
- (JSC::Identifier::add):
- (JSC::UCharBufferTranslator::translate):
-
-2008-12-16 Gavin Barraclough <barraclough@apple.com>
-
- Build fix for 'doze.
-
- * assembler/AssemblerBuffer.h:
-
-2008-12-16 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Make the JIT compile on x86-64.
- This largely involves populting the missing calls in MacroAssembler.h.
- In addition some reinterpret_casts need removing from the JIT, and the
- repatching property access code will need to be fully compiled out for
- now. The changes in interpret.cpp are to reorder the functions so that
- the _generic forms come before all other property access methods, and
- then to place all property access methods other than the generic forms
- under control of the ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS macro.
-
- No performance impact.
-
- * assembler/AssemblerBuffer.h:
- (JSC::AssemblerBuffer::putInt64Unchecked):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::load32):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::storePtrWithRepatch):
- (JSC::MacroAssembler::store32):
- (JSC::MacroAssembler::poke):
- (JSC::MacroAssembler::move):
- (JSC::MacroAssembler::testImm64):
- (JSC::MacroAssembler::jePtr):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jnzPtr):
- (JSC::MacroAssembler::jzPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::cmpq_rr):
- (JSC::X86Assembler::cmpq_rm):
- (JSC::X86Assembler::cmpq_im):
- (JSC::X86Assembler::testq_i32m):
- (JSC::X86Assembler::movl_mEAX):
- (JSC::X86Assembler::movl_i32r):
- (JSC::X86Assembler::movl_EAXm):
- (JSC::X86Assembler::movq_rm):
- (JSC::X86Assembler::movq_mEAX):
- (JSC::X86Assembler::movq_mr):
- (JSC::X86Assembler::movq_i64r):
- (JSC::X86Assembler::movl_mr):
- (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64):
- (JSC::X86Assembler::X86InstructionFormatter::immediate64):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCall):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- * runtime/JSImmediate.h:
- (JSC::JSImmediate::makeInt):
-
-2008-12-16 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22869: REGRESSION (r38407): http://news.cnet.com/8301-13579_3-9953533-37.html crashes
- <https://bugs.webkit.org/show_bug.cgi?id=22869>
- <rdar://problem/6402499>
-
- Before r38407, Structure::m_nameInPrevious was ref'd due to it being
- stored in a PropertyMap. However, PropertyMaps are created lazily after
- r38407, so Structure::m_nameInPrevious is not necessarily ref'd while
- it is being used. Making it a RefPtr instead of a raw pointer fixes
- the problem.
-
- Unfortunately, the crash in the bug is rather intermittent, and it is
- impossible to add an assertion in UString::Ref::ref() to catch this bug
- because some users of UString::Rep deliberately zero out the reference
- count. Therefore, there is no layout test accompanying this bug fix.
-
- * runtime/Structure.cpp:
- (JSC::Structure::~Structure): Use get().
- (JSC::Structure::materializePropertyMap): Use get().
- (JSC::Structure::addPropertyTransitionToExistingStructure): Use get().
- (JSC::Structure::addPropertyTransition): Use get().
- * runtime/Structure.h: Make Structure::m_nameInPrevious a RefPtr instead
- of a raw pointer.
-
-2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Attempt to fix win build. No 'using namespace WTF' in this file, needs manual WTF:: prefix.
- Not sure why the build works as is here.
-
- * runtime/MathObject.cpp:
- (JSC::mathProtoFuncRandom):
-
-2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22876
-
- Unify random number generation in JavaScriptCore & WebCore, by introducing
- wtf/RandomNumber.h and moving wtf_random/wtf_random_init out of MathExtras.h.
-
- wtf_random_init() has been renamed to initializeRandomNumberGenerator() and
- lives in it's own private header: wtf/RandomNumberSeed.h, only intended to
- be used from within JavaScriptCore.
-
- wtf_random() has been renamed to randomNumber() and lives in a public header
- wtf/RandomNumber.h, usable from within JavaScriptCore & WebCore. It encapsulates
- the code taking care of initializing the random number generator (only when
- building without ENABLE(JSC_MULTIPLE_THREADS), otherwhise initializeThreading()
- already took care of that).
-
- Functional change on darwin: Use random() instead of rand(), as it got a larger
- period (more randomness). HTMLFormElement already contains this implementation
- and I just moved it in randomNumber(), as special case for PLATFORM(DARWIN).
-
- * GNUmakefile.am: Add RandomNumber.(cpp/h) / RandomNumberSeed.h.
- * JavaScriptCore.exp: Ditto.
- * JavaScriptCore.pri: Ditto.
- * JavaScriptCore.scons: Ditto.
- * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- * JavaScriptCoreSources.bkl: Ditto.
- * runtime/MathObject.cpp: Use new WTF::randomNumber() functionality.
- (JSC::mathProtoFuncRandom):
- * wtf/MathExtras.h: Move wtf_random / wtf_random_init to new files.
- * wtf/RandomNumber.cpp: Added.
- (WTF::randomNumber):
- * wtf/RandomNumber.h: Added.
- * wtf/RandomNumberSeed.h: Added. Internal usage within JSC only.
- (WTF::initializeRandomNumberGenerator):
- * wtf/ThreadingGtk.cpp: Rename wtf_random_init() to initializeRandomNumberGenerator().
- (WTF::initializeThreading):
- * wtf/ThreadingPthreads.cpp: Ditto.
- (WTF::initializeThreading):
- * wtf/ThreadingQt.cpp: Ditto.
- (WTF::initializeThreading):
- * wtf/ThreadingWin.cpp: Ditto.
- (WTF::initializeThreading):
-
-2008-12-16 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Qt/Win build fix
-
- * JavaScriptCore.pri:
-
-2008-12-15 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix the build with GCC 4.0.
-
- * Configurations/JavaScriptCore.xcconfig: GCC 4.0 appears to have a bug when compiling with -funwind-tables on,
- so don't use it with that compiler version.
-
-2008-12-15 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Cameron Zwarich.
-
- <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
-
-2008-12-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Don't use unique context group in JSGlobalContextCreate() on Tiger or Leopard.
-
- * API/JSContextRef.cpp: (JSGlobalContextCreate):
-
-2008-12-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6445089> Mach ports leak from worker threads
-
- * interpreter/Interpreter.cpp: (JSC::getCPUTime):
- Deallocate the thread self port.
-
-2008-12-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Mark Rowe.
-
- Construct stack frames in JIT code, so that backtracing can still work.
- <rdar://problem/6447870> JIT should play nice with attempts to take stack traces
-
- * jit/JIT.cpp:
- (JSC::):
- (JSC::JIT::privateCompileMainPass):
-
-2008-12-15 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6402262> JavaScriptCore needs exception handling tables in order to get stack traces without frame pointers
-
- * Configurations/JavaScriptCore.xcconfig:
-
-2008-12-15 Gavin Barraclough <barraclough@apple.com>
-
- Rubber stamped by Mark Rowe.
-
- Revert r39226 / Bug 22818: Unify JIT callback argument access OS X / Windows
- This causes Acid3 failures – reverting for now & will revisit later.
- https://bugs.webkit.org/show_bug.cgi?id=22873
-
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- (JSC::JIT::emitCTICall_internal):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- * wtf/Platform.h:
-
-2008-12-15 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6427048> crash due to infinite recursion after setting window.__proto__ = window
-
- Replaced toGlobalObject with the more generally useful unwrappedObject and used it to
- fix the cycle detection code in put(__proto__).
-
- * JavaScriptCore.exp: Updated.
-
- * runtime/JSGlobalObject.cpp: Removed toGlobalObject. We now use unwrappedObject instead.
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::isGlobalObject): Ditto.
-
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval): Use unwrappedObject and isGlobalObject here rather than toGlobalObject.
-
- * runtime/JSObject.cpp:
- (JSC::JSObject::put): Rewrote prototype cycle checking loop. Use unwrappedObject in the loop now.
- (JSC::JSObject::unwrappedObject): Replaced toGlobalObject with this new function.
- * runtime/JSObject.h: More of the same.
-
-2008-12-15 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- Visual Studio requires visibility of forward declarations to match class declaration.
-
- * assembler/X86Assembler.h:
-
-2008-12-15 Gustavo Noronha Silva <kov@kov.eti.br>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22686
-
- GTK+ build fix.
-
- * GNUmakefile.am:
-
-2008-12-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Add support to X86Assembler emitting instructions that access all 16 registers on x86-64.
- Add a new formating class, that is reponsible for both emitting the opcode bytes and the
- ModRm bytes of an instruction in a single call; this can insert the REX byte as necessary
- before the opcode, but has access to the register numbers to build the REX.
-
- * assembler/AssemblerBuffer.h:
- (JSC::AssemblerBuffer::isAligned):
- (JSC::AssemblerBuffer::data):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::and32):
- (JSC::MacroAssembler::or32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::xor32):
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::load32):
- (JSC::MacroAssembler::load16):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::storePtrWithRepatch):
- (JSC::MacroAssembler::store32):
- (JSC::MacroAssembler::pop):
- (JSC::MacroAssembler::push):
- (JSC::MacroAssembler::compareImm32ForBranch):
- (JSC::MacroAssembler::compareImm32ForBranchEquality):
- (JSC::MacroAssembler::testImm32):
- (JSC::MacroAssembler::jae32):
- (JSC::MacroAssembler::jb32):
- (JSC::MacroAssembler::je16):
- (JSC::MacroAssembler::jg32):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jne32):
- (JSC::MacroAssembler::jump):
- * assembler/X86Assembler.h:
- (JSC::X86::):
- (JSC::X86Assembler::):
- (JSC::X86Assembler::size):
- (JSC::X86Assembler::push_r):
- (JSC::X86Assembler::pop_r):
- (JSC::X86Assembler::push_i32):
- (JSC::X86Assembler::push_m):
- (JSC::X86Assembler::pop_m):
- (JSC::X86Assembler::addl_rr):
- (JSC::X86Assembler::addl_mr):
- (JSC::X86Assembler::addl_ir):
- (JSC::X86Assembler::addq_ir):
- (JSC::X86Assembler::addl_im):
- (JSC::X86Assembler::andl_rr):
- (JSC::X86Assembler::andl_ir):
- (JSC::X86Assembler::orl_rr):
- (JSC::X86Assembler::orl_mr):
- (JSC::X86Assembler::orl_ir):
- (JSC::X86Assembler::subl_rr):
- (JSC::X86Assembler::subl_mr):
- (JSC::X86Assembler::subl_ir):
- (JSC::X86Assembler::subl_im):
- (JSC::X86Assembler::xorl_rr):
- (JSC::X86Assembler::xorl_ir):
- (JSC::X86Assembler::sarl_i8r):
- (JSC::X86Assembler::sarl_CLr):
- (JSC::X86Assembler::shll_i8r):
- (JSC::X86Assembler::shll_CLr):
- (JSC::X86Assembler::imull_rr):
- (JSC::X86Assembler::imull_i32r):
- (JSC::X86Assembler::idivl_r):
- (JSC::X86Assembler::cmpl_rr):
- (JSC::X86Assembler::cmpl_rm):
- (JSC::X86Assembler::cmpl_mr):
- (JSC::X86Assembler::cmpl_ir):
- (JSC::X86Assembler::cmpl_ir_force32):
- (JSC::X86Assembler::cmpl_im):
- (JSC::X86Assembler::cmpl_im_force32):
- (JSC::X86Assembler::cmpw_rm):
- (JSC::X86Assembler::testl_rr):
- (JSC::X86Assembler::testl_i32r):
- (JSC::X86Assembler::testl_i32m):
- (JSC::X86Assembler::testq_rr):
- (JSC::X86Assembler::testq_i32r):
- (JSC::X86Assembler::testb_i8r):
- (JSC::X86Assembler::sete_r):
- (JSC::X86Assembler::setz_r):
- (JSC::X86Assembler::setne_r):
- (JSC::X86Assembler::setnz_r):
- (JSC::X86Assembler::cdq):
- (JSC::X86Assembler::xchgl_rr):
- (JSC::X86Assembler::movl_rr):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::movl_mr):
- (JSC::X86Assembler::movl_i32r):
- (JSC::X86Assembler::movl_i32m):
- (JSC::X86Assembler::movq_rr):
- (JSC::X86Assembler::movq_rm):
- (JSC::X86Assembler::movq_mr):
- (JSC::X86Assembler::movzwl_mr):
- (JSC::X86Assembler::movzbl_rr):
- (JSC::X86Assembler::leal_mr):
- (JSC::X86Assembler::call):
- (JSC::X86Assembler::jmp):
- (JSC::X86Assembler::jmp_r):
- (JSC::X86Assembler::jmp_m):
- (JSC::X86Assembler::jne):
- (JSC::X86Assembler::jnz):
- (JSC::X86Assembler::je):
- (JSC::X86Assembler::jl):
- (JSC::X86Assembler::jb):
- (JSC::X86Assembler::jle):
- (JSC::X86Assembler::jbe):
- (JSC::X86Assembler::jge):
- (JSC::X86Assembler::jg):
- (JSC::X86Assembler::ja):
- (JSC::X86Assembler::jae):
- (JSC::X86Assembler::jo):
- (JSC::X86Assembler::jp):
- (JSC::X86Assembler::js):
- (JSC::X86Assembler::addsd_rr):
- (JSC::X86Assembler::addsd_mr):
- (JSC::X86Assembler::cvtsi2sd_rr):
- (JSC::X86Assembler::cvttsd2si_rr):
- (JSC::X86Assembler::movd_rr):
- (JSC::X86Assembler::movsd_rm):
- (JSC::X86Assembler::movsd_mr):
- (JSC::X86Assembler::mulsd_rr):
- (JSC::X86Assembler::mulsd_mr):
- (JSC::X86Assembler::pextrw_irr):
- (JSC::X86Assembler::subsd_rr):
- (JSC::X86Assembler::subsd_mr):
- (JSC::X86Assembler::ucomis_rr):
- (JSC::X86Assembler::int3):
- (JSC::X86Assembler::ret):
- (JSC::X86Assembler::predictNotTaken):
- (JSC::X86Assembler::label):
- (JSC::X86Assembler::align):
- (JSC::X86Assembler::link):
- (JSC::X86Assembler::executableCopy):
- (JSC::X86Assembler::X86InstructionFormater::prefix):
- (JSC::X86Assembler::X86InstructionFormater::oneByteOp):
- (JSC::X86Assembler::X86InstructionFormater::twoByteOp):
- (JSC::X86Assembler::X86InstructionFormater::oneByteOp64):
- (JSC::X86Assembler::X86InstructionFormater::oneByteOp8):
- (JSC::X86Assembler::X86InstructionFormater::twoByteOp8):
- (JSC::X86Assembler::X86InstructionFormater::instructionImmediate8):
- (JSC::X86Assembler::X86InstructionFormater::instructionImmediate32):
- (JSC::X86Assembler::X86InstructionFormater::instructionRel32):
- (JSC::X86Assembler::X86InstructionFormater::size):
- (JSC::X86Assembler::X86InstructionFormater::isAligned):
- (JSC::X86Assembler::X86InstructionFormater::data):
- (JSC::X86Assembler::X86InstructionFormater::executableCopy):
- (JSC::X86Assembler::X86InstructionFormater::registerModRM):
- (JSC::X86Assembler::X86InstructionFormater::memoryModRM):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
-
-2008-12-15 Darin Adler <darin@apple.com>
-
- * interpreter/RegisterFile.h: Tweak include formatting.
-
-2008-12-15 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix for Gtk+.
-
- * interpreter/RegisterFile.h: Include stdio.h for fprintf
-
-2008-12-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time
-
- * interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- Improve error handling: if mmap fails, crash immediately, and print out the reason.
-
-2008-12-13 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Re-enable WREC on 64-bit.
- Implements one of the MacroAssembler::jnzPtr methods, previously only implemented for 32-bit x86.
-
- https://bugs.webkit.org/show_bug.cgi?id=22849
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::testImm64):
- (JSC::MacroAssembler::jnzPtr):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::testq_i32r):
- (JSC::X86Assembler::testq_rr):
- * wtf/Platform.h:
-
-2008-12-13 Gavin Barraclough <barraclough@apple.com>
-
- Fix PPC builds.
+ (JSC::RegisterFile::RegisterFile):
+ (JSC::RegisterFile::grow):
- * assembler/MacroAssembler.h:
+2009-06-19 David Levin <levin@chromium.org>
-2008-12-13 Gavin Barraclough <barraclough@apple.com>
+ Reviewed by NOBODY (Windows build fix).
- Build fix only, no review.
+ Add export for Windows corresponding to OSX export done in r44844.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- * bytecode/CodeBlock.h:
+2009-06-18 Oliver Hunt <oliver@apple.com>
-2008-12-13 Gavin Barraclough <barraclough@apple.com>
+ Reviewed by Gavin "Viceroy of Venezuela" Barraclough.
- Reviewed by Cameron Zwarich.
+ Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
+ <https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>
- Port the remainder of the JIT, bar calling convention related code, and code
- implementing optimizations which can be disabled, to use the MacroAssembler.
+ We need to make sure that each native function instance correctly unlinks any references to it
+ when it is collected. Allowing this to happen required a few changes:
+ * Every native function needs a codeblock to track the link information
+ * To have this codeblock, every function now also needs its own functionbodynode
+ so we no longer get to have a single shared instance.
+ * Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::DataLabelPtr::DataLabelPtr):
- (JSC::MacroAssembler::RepatchBuffer::RepatchBuffer):
- (JSC::MacroAssembler::RepatchBuffer::link):
- (JSC::MacroAssembler::RepatchBuffer::addressOf):
- (JSC::MacroAssembler::RepatchBuffer::setPtr):
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::lshift32):
- (JSC::MacroAssembler::mod32):
- (JSC::MacroAssembler::rshift32):
- (JSC::MacroAssembler::storePtrWithRepatch):
- (JSC::MacroAssembler::jnzPtr):
- (JSC::MacroAssembler::jzPtr):
- (JSC::MacroAssembler::jump):
- (JSC::MacroAssembler::label):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::xchgl_rr):
- (JSC::X86Assembler::jmp_m):
- (JSC::X86Assembler::repatchAddress):
- (JSC::X86Assembler::getRelocatedAddress):
+ * JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- * bytecode/CodeBlock.h:
- (JSC::JITCodeRef::JITCodeRef):
- (JSC::CodeBlock::setJITCode):
- (JSC::CodeBlock::jitCode):
- (JSC::CodeBlock::executablePool):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileLinkPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JumpTable::JumpTable):
- (JSC::JIT::emitCTICall):
- (JSC::JIT::JSRInfo::JSRInfo):
- * jit/JITArithmetic.cpp:
- * jit/JITCall.cpp:
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::emitCTICall_internal):
- (JSC::JIT::checkStructure):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::addSlowCase):
- (JSC::JIT::addJump):
- (JSC::JIT::emitJumpSlowToHot):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
-
-2008-12-12 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix the failures of the following layout tests, which regressed in
- r39255:
-
- fast/dom/StyleSheet/ownerNode-lifetime-2.html
- fast/xsl/transform-xhr-doc.xhtml
-
- The binary search in CodeBlock::getByIdExceptionInfoForBytecodeOffset()
- doesn't guarantee that it actually finds a match, so add an explicit check
- for this.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
-
-2008-12-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Replace emitPutCallArg methods with emitPutJITStubArg methods. Primarily to make the argument numbering
- more sensible (1-based incrementing by 1, rather than 0-based incrementing by 4). The CTI name also seems
- to be being deprecated from the code generally.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCallEvalSetupArgs):
- (JSC::JIT::compileOpConstructSetupArgs):
- (JSC::JIT::compileOpCall):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitPutJITStubArg):
- (JSC::JIT::emitPutJITStubArgConstant):
- (JSC::JIT::emitGetJITStubArg):
- (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
-
-2008-12-12 Gavin Barraclough <barraclough@apple.com>
-
- Fix windows builds.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
-
-2008-12-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove loop counter 'i' from the JIT generation passes, replace with a member m_bytecodeIndex.
-
- No impact on performance.
-
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JmpTable::JmpTable):
- (JSC::JIT::emitCTICall):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::emitGetVirtualRegisters):
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::emitCTICall_internal):
- (JSC::JIT::emitJumpSlowCaseIfJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
- (JSC::JIT::emitFastArithIntToImmOrSlowCase):
- (JSC::JIT::addSlowCase):
- (JSC::JIT::addJump):
- (JSC::JIT::emitJumpSlowToHot):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compilePutByIdSlowCase):
-
-2008-12-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- <rdar://problem/6428342> Look into feasibility of discarding bytecode after native codegen
-
- Move more JIT functionality to using offsets into the Instruction buffer
- instead of raw pointers. Two to go!
-
- * interpreter/Interpreter.cpp:
- (JSC::bytecodeOffsetForPC): Rename from vPCForPC.
- (JSC::Interpreter::resolve): Pass offset to exception helper.
- (JSC::Interpreter::resolveSkip): Ditto.
- (JSC::Interpreter::resolveGlobal): Ditto.
- (JSC::Interpreter::resolveBaseAndProperty): Ditto.
- (JSC::Interpreter::resolveBaseAndFunc): Ditto.
- (JSC::isNotObject): Ditto.
- (JSC::Interpreter::unwindCallFrame): Call bytecodeOffsetForPC.
- (JSC::Interpreter::throwException): Use offsets instead of vPCs.
- (JSC::Interpreter::privateExecute): Pass offset to exception helper.
- (JSC::Interpreter::retrieveLastCaller): Ditto.
- (JSC::Interpreter::cti_op_instanceof): Ditto.
- (JSC::Interpreter::cti_op_call_NotJSFunction): Ditto.
- (JSC::Interpreter::cti_op_resolve): Pass offset to exception helper.
- (JSC::Interpreter::cti_op_construct_NotJSConstruct): Ditto.
- (JSC::Interpreter::cti_op_resolve_func): Ditto.
- (JSC::Interpreter::cti_op_resolve_skip): Ditto.
- (JSC::Interpreter::cti_op_resolve_global): Ditto.
- (JSC::Interpreter::cti_op_resolve_with_base): Ditto.
- (JSC::Interpreter::cti_op_throw): Ditto.
- (JSC::Interpreter::cti_op_in): Ditto.
- (JSC::Interpreter::cti_vm_throw): Ditto.
- * interpreter/Interpreter.h:
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass): Don't pass unnecessary vPC to stub.
- * jit/JIT.h: Remove ARG_instr1 - ARG_instr3 and ARG_instr5 - ARG_instr6.
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallEvalSetupArgs): Don't pass unnecessary vPC to stub..
- (JSC::JIT::compileOpConstructSetupArgs): Ditto.
-
- * runtime/ExceptionHelpers.cpp:
- (JSC::createUndefinedVariableError): Take an offset instead of vPC.
- (JSC::createInvalidParamError): Ditto.
- (JSC::createNotAConstructorError): Ditto.
- (JSC::createNotAFunctionError): Ditto.
- (JSC::createNotAnObjectError): Ditto.
- * runtime/ExceptionHelpers.h:
-
-2008-12-12 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 22835: Crash during bytecode generation when comparing to null
- <https://bugs.webkit.org/show_bug.cgi?id=22835>
- <rdar://problem/6286749>
-
- Change the special cases in bytecode generation for comparison to null
- to use tempDestination().
-
- * parser/Nodes.cpp:
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::EqualNode::emitBytecode):
-
-2008-12-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Move slow-cases of JIT code generation over to the MacroAssembler interface.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::Label::Label):
- (JSC::MacroAssembler::jae32):
- (JSC::MacroAssembler::jg32):
- (JSC::MacroAssembler::jzPtr):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- (JSC::JIT::emitGetVariableObjectRegister):
- (JSC::JIT::emitPutVariableObjectRegister):
- * jit/JIT.h:
- (JSC::SlowCaseEntry::SlowCaseEntry):
- (JSC::JIT::getSlowCase):
- (JSC::JIT::linkSlowCase):
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOpSlowCase):
- * jit/JITCall.cpp:
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- (JSC::JIT::linkSlowCaseIfNotJSCell):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
-
-2008-12-12 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 22828: Do not inspect bytecode instruction stream for op_get_by_id exception information
- <https://bugs.webkit.org/show_bug.cgi?id=22828>
-
- In order to remove the bytecode instruction stream after generating
- native code, all inspection of bytecode instructions at runtime must
- be removed. One particular instance of this is the special handling of
- exceptions thrown by the op_get_by_id emitted directly before an
- op_construct or an op_instanceof. This patch moves that information to
- an auxiliary data structure in CodeBlock.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::addGetByIdExceptionInfo):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitConstruct):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
- * parser/Nodes.cpp:
- (JSC::InstanceOfNode::emitBytecode):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createNotAnObjectError):
-
-2008-12-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Change exception information accessors to take offsets into the bytecode
- instruction buffer instead of pointers so that they can work even even
- if the bytecode buffer is purged.
-
- * bytecode/CodeBlock.cpp:
- (JSC::instructionOffsetForNth):
+ Constructor for NativeCode CodeBlock
+ (JSC::CodeBlock::derefStructures):
+ (JSC::CodeBlock::refStructures):
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
- * bytecode/CodeBlock.h:
- * bytecode/SamplingTool.cpp:
- (JSC::SamplingTool::dump):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveLastCaller):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * runtime/ExceptionHelpers.cpp:
- (JSC::createUndefinedVariableError):
- (JSC::createInvalidParamError):
- (JSC::createNotAConstructorError):
- (JSC::createNotAFunctionError):
- (JSC::createNotAnObjectError):
-
-2008-12-12 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Tiny bit of refactoring in quantifier generation.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
-
-2008-12-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Remove dependancy on having the Instruction buffer in order to
- deref Structures used for property access and global resolves.
- Instead, we put references to the necessary Structures in auxiliary
- data structures on the CodeBlock. This is not an ideal solution,
- as we still pay for having the Structures in two places and we
- would like to eventually just hold on to offsets into the machine
- code buffer.
-
- - Also removes CodeBlock bloat in non-JIT by #ifdefing the JIT
- only data structures.
+ (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
+ (JSC::CodeBlock::functionRegisterForBytecodeOffset):
+ (JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
+ (JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
+ (JSC::CodeBlock::setJITCode):
+ Add assertions to ensure we don't try and use NativeCode CodeBlocks as
+ a normal codeblock.
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * bytecode/CodeBlock.cpp:
- (JSC::isGlobalResolve):
- (JSC::isPropertyAccess):
- (JSC::instructionOffsetForNth):
- (JSC::printGlobalResolveInfo):
- (JSC::printStructureStubInfo):
- (JSC::CodeBlock::printStructures):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
- (JSC::GlobalResolveInfo::GlobalResolveInfo):
- (JSC::getNativePC):
- (JSC::CodeBlock::instructions):
- (JSC::CodeBlock::getStubInfo):
- (JSC::CodeBlock::getBytecodeIndex):
- (JSC::CodeBlock::addPropertyAccessInstruction):
- (JSC::CodeBlock::addGlobalResolveInstruction):
- (JSC::CodeBlock::numberOfStructureStubInfos):
- (JSC::CodeBlock::addStructureStubInfo):
- (JSC::CodeBlock::structureStubInfo):
- (JSC::CodeBlock::addGlobalResolveInfo):
- (JSC::CodeBlock::globalResolveInfo):
- (JSC::CodeBlock::numberOfCallLinkInfos):
- (JSC::CodeBlock::addCallLinkInfo):
- (JSC::CodeBlock::callLinkInfo):
- * bytecode/Instruction.h:
- (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
- (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- * bytecode/Opcode.h:
(JSC::):
- * bytecode/StructureStubInfo.cpp: Copied from bytecode/CodeBlock.cpp.
- (JSC::StructureStubInfo::deref):
- * bytecode/StructureStubInfo.h: Copied from bytecode/CodeBlock.h.
- (JSC::StructureStubInfo::StructureStubInfo):
- (JSC::StructureStubInfo::initGetByIdSelf):
- (JSC::StructureStubInfo::initGetByIdProto):
- (JSC::StructureStubInfo::initGetByIdChain):
- (JSC::StructureStubInfo::initGetByIdSelfList):
- (JSC::StructureStubInfo::initGetByIdProtoList):
- (JSC::StructureStubInfo::initPutByIdTransition):
- (JSC::StructureStubInfo::initPutByIdReplace):
- (JSC::StructureStubInfo::):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitResolve):
- (JSC::BytecodeGenerator::emitGetById):
- (JSC::BytecodeGenerator::emitPutById):
- (JSC::BytecodeGenerator::emitCall):
- (JSC::BytecodeGenerator::emitConstruct):
- (JSC::BytecodeGenerator::emitCatch):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::getPolymorphicAccessStructureListSlot):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_resolve_global):
- * jit/JIT.cpp:
- (JSC::JIT::JIT):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
-
-2008-12-11 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Remove CTI_ARGUMENTS mode, use va_start implementation on Windows,
- unifying JIT callback (cti_*) argument access on OS X & Windows
-
- No performance impact.
-
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitCTICall):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- * wtf/Platform.h:
-
-2008-12-11 Holger Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=20953
-
- For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
- implementation. This is one of the reasons why the Qt port is currently not
- using WebCore/platform/graphics/Font.cpp. By allowing to not use
- the simple/fast-path the Qt port will be able to use it.
-
- Introduce USE(FONT_FAST_PATH) and define it for every port but the
- Qt one.
-
- * wtf/Platform.h: Enable USE(FONT_FAST_PATH)
-
-2008-12-11 Gabor Loki <loki@inf.u-szeged.hu>
-
- Reviewed by Darin Adler and landed by Holger Freyther.
-
- <https://bugs.webkit.org/show_bug.cgi?id=22648>
- Fix threading on Qt-port and Gtk-port for Sampling tool.
-
- * wtf/ThreadingGtk.cpp:
- (WTF::waitForThreadCompletion):
- * wtf/ThreadingQt.cpp:
- (WTF::waitForThreadCompletion):
-
-2008-12-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 22734: Debugger crashes when stepping into a function call in a return statement
- <https://bugs.webkit.org/show_bug.cgi?id=22734>
- <rdar://problem/6426796>
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator): The DebuggerCallFrame uses
- the 'this' value stored in a callFrame, so op_convert_this should be
- emitted at the beginning of a function body when generating bytecode
- with debug hooks.
- * debugger/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::thisObject): The assertion inherent in the call
- to asObject() here is valid, because any 'this' value should have been
- converted to a JSObject*.
-
-2008-12-10 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Port more of the JIT to use the MacroAssembler interface.
-
- Everything in the main pass, bar a few corner cases (operations with required
- registers, or calling convention code). Slightly refactors array creation,
- moving the offset calculation into the callFrame into C code (reducing code
- planted).
-
- Overall this appears to be a 1% win on v8-tests, due to the smaller immediates
- being planted (in jfalse in particular).
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_new_array):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
-
-2008-12-10 Sam Weinig <sam@webkit.org>
-
- Fix non-JIT builds.
-
- * bytecode/CodeBlock.h:
-
-2008-12-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- <rdar://problem/6428332> Remove the CTI return address table from CodeBlock
-
- Step 2:
-
- Convert the return address table from a HashMap to a sorted Vector. This
- reduces the size of the data structure by ~4.5MB on Membuster head.
-
- SunSpider reports a 0.5% progression.
-
- * bytecode/CodeBlock.cpp:
- (JSC::sizeInBytes): Generic method to get the cost of a Vector.
- (JSC::CodeBlock::dumpStatistics): Add dumping of member sizes.
- * bytecode/CodeBlock.h:
- (JSC::PC::PC): Struct representing NativePC -> VirtualPC mappings.
- (JSC::getNativePC): Helper for binary chop.
- (JSC::CodeBlock::getBytecodeIndex): Used to get the VirtualPC from a
- NativePC using a binary chop of the pcVector.
- (JSC::CodeBlock::pcVector): Accessor.
-
- * interpreter/Interpreter.cpp:
- (JSC::vPCForPC): Use getBytecodeIndex instead of jitReturnAddressVPCMap().get().
- (JSC::Interpreter::cti_op_instanceof): Ditto.
- (JSC::Interpreter::cti_op_resolve): Ditto.
- (JSC::Interpreter::cti_op_resolve_func): Ditto.
- (JSC::Interpreter::cti_op_resolve_skip): Ditto.
- (JSC::Interpreter::cti_op_resolve_with_base): Ditto.
- (JSC::Interpreter::cti_op_throw): Ditto.
- (JSC::Interpreter::cti_op_in): Ditto.
- (JSC::Interpreter::cti_vm_throw): Ditto.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile): Reserve exact capacity and fill the pcVector.
-
-2008-12-09 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Added WREC support for an assertion followed by a quantifier. Fixed
- PCRE to match.
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since
- it's meaningless. (Firefox does the same.)
-
- * pcre/pcre_compile.cpp:
- (compileBranch): ditto.
-
-2008-12-09 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- In preparation for compiling WREC without PCRE:
-
- Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
- match in cases where it didn't already.
-
- Changed JavaScriptCore to report syntax errors detected by WREC, rather
- than falling back on PCRE any time WREC sees an error.
-
- * pcre/pcre_compile.cpp:
- (checkEscape): Relaxed parsing of \c and \N escapes to be more
- web-compatible.
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported
- a syntax error.
-
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp): Fixed some error reporting to
- match PCRE.
-
- * wrec/WRECParser.cpp: Added error messages that match PCRE.
-
- (JSC::WREC::Parser::consumeGreedyQuantifier):
- (JSC::WREC::Parser::parseParentheses):
- (JSC::WREC::Parser::parseCharacterClass):
- (JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
- use the new setError API.
-
- (JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
- to be more web-compatible.
-
- (JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
- quantifier and a quantifier with no prefix, like PCRE does.
-
- (JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.
-
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::error):
- (JSC::WREC::Parser::syntaxError):
- (JSC::WREC::Parser::parsePattern):
- (JSC::WREC::Parser::reset):
- (JSC::WREC::Parser::setError): Store error messages instead of error codes,
- to provide for exception messages. Use a setter for reporting errors, so
- errors detected early are not overwritten by errors detected later.
-
-2008-12-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Use va_args to access cti function arguments.
- https://bugs.webkit.org/show_bug.cgi?id=22774
-
- This may be a minor regression, but we'll take the hit if so to reduce fragility.
-
- * interpreter/Interpreter.cpp:
- * interpreter/Interpreter.h:
-
-2008-12-09 Sam Weinig <sam@webkit.org>
-
- Reviewed twice by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22752
- Clear SymbolTable after codegen for Function codeblocks that
- don't require an activation
-
- This is a ~1.5MB improvement on Membuster-head.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables
- and total size used by symbol tables.
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate): Clear the symbol table here.
-
-2008-12-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Remove unnecessary extra lookup when throwing an exception.
- We used to first lookup the target offset using getHandlerForVPC
- and then we would lookup the native code stub using
- nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
- the HandlerInfo.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
- * bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::throwException): Return a HandlerInfo instead of
- and Instruction offset.
- (JSC::Interpreter::privateExecute): Get the offset from HandlerInfo.
- (JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo.
- (JSC::Interpreter::cti_vm_throw): Ditto.
- * interpreter/Interpreter.h:
-
-2008-12-09 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- Speculative fix for the Chromium-Windows bot.
- Add JavaScriptCore/os-win32 to the include path (for stdint.h)
- Strangely it builds fine on my local windows box (or at least doesn't hit this error)
-
- * JavaScriptCore.scons:
-
-2008-12-09 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Add ExecutableAllocator files missing from Scons build.
-
- * JavaScriptCore.scons:
-
-2008-12-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=22631
- Allow ScriptCallFrame query names of functions in the call stack.
-
- * JavaScriptCore.exp: added InternalFunction::name and
- UString operator==() as exported symbol
-
-2008-12-08 Judit Jasz <jasy@inf.u-szeged.hu>
-
- Reviewed and tweaked by Cameron Zwarich.
-
- Bug 22352: Annotate opcodes with their length
- <https://bugs.webkit.org/show_bug.cgi?id=22352>
-
- * bytecode/Opcode.cpp:
- * bytecode/Opcode.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
-
-2008-12-08 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Implemented more of the relaxed and somewhat weird rules for deciding
- how to interpret a non-pattern-character.
-
- * wrec/Escapes.h:
- (JSC::WREC::Escape::):
- (JSC::WREC::Escape::Escape): Eliminated Escape::None because it was
- unused. If you see an '\\', it's either a valid escape or an error.
-
- * wrec/Quantifier.h:
- (JSC::WREC::Quantifier::Quantifier):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier): Renamed "noMaxSpecified"
- to "Infinity", since that's what it means.
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::consumeGreedyQuantifier): Re-wrote {n,m} parsing rules
- because they were too strict before. Added support for backtracking
- in the case where the {n,m} fails to parse as a quantifier, and yet is
- not a syntax error.
-
- (JSC::WREC::Parser::parseCharacterClass):
- (JSC::WREC::Parser::parseNonCharacterEscape): Eliminated Escape::None,
- as above.
-
- (JSC::WREC::Parser::consumeEscape): Don't treat ASCII and _ escapes
- as syntax errors. See fast/regex/non-pattern-characters.html.
-
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::SavedState::SavedState):
- (JSC::WREC::Parser::SavedState::restore): Added a state backtracker,
- since parsing {n,m} forms requires backtracking if the form turns out
- not to be a quantifier.
-
-2008-12-08 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Refactored WREC parsing so that only one piece of code needs to know
- the relaxed and somewhat weird rules for deciding how to interpret a
- non-pattern-character, in preparation for implementing those rules.
-
- Also, implemented the relaxed and somewhat weird rules for '}' and ']'.
-
- * wrec/WREC.cpp: Reduced the regular expression size limit. Now that
- WREC handles ']' properly, it compiles fast/js/regexp-charclass-crash.html,
- which makes it hang at the old limit. (The old limit was based on the
- misimpression that the same value in PCRE limited the regular expression
- pattern size; in reality, it limited the expected compiled regular
- expression size. WREC doesn't have a way to calculate an expected
- compiled regular expression size, but this should be good enough.)
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::parsePatternCharacterSequence): Nixed this function because
- it contained a second copy of the logic for handling non-pattern-characters,
- which is about to get a lot more complicated.
-
- (JSC::WREC::PatternCharacterSequence::PatternCharacterSequence):
- (JSC::WREC::PatternCharacterSequence::size):
- (JSC::WREC::PatternCharacterSequence::append):
- (JSC::WREC::PatternCharacterSequence::flush): Helper object for generating
- an optimized sequence of pattern characters.
-
- (JSC::WREC::Parser::parseNonCharacterEscape): Renamed to reflect the fact
- that the main parseAlternative loop handles character escapes.
-
- (JSC::WREC::Parser::parseAlternative): Moved pattern character sequence
- logic from parsePatternCharacterSequence to here, using
- PatternCharacterSequence to help with the details.
-
- * wrec/WRECParser.h: Updated for renames.
-
-2008-12-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- <rdar://problem/6166088> Give JSGlobalContextCreate a behavior that is concurrency aware,
- and un-deprecate it
-
- * API/JSContextRef.cpp: (JSGlobalContextCreate):
- * API/JSContextRef.h:
- Use a unique context group for the context, unless the application was linked against old
- JavaScriptCore.
-
-2008-12-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for <rdar://problem/6428332> Remove the CTI return address table from CodeBlock
-
- Step 1:
-
- Remove use of jitReturnAddressVPCMap when looking for vPC to store Structures
- in for cached lookup. Instead, use the offset in the StructureStubInfo that is
- already required.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dumpStatistics): Fix extraneous semicolon.
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- * jit/JIT.h:
- (JSC::JIT::compileGetByIdSelf):
- (JSC::JIT::compileGetByIdProto):
- (JSC::JIT::compileGetByIdChain):
- (JSC::JIT::compilePutByIdReplace):
- (JSC::JIT::compilePutByIdTransition):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength): Remove extra call to getStubInfo.
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
-
-2008-12-08 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Port the op_j?n?eq_null JIT code generation to use the MacroAssembler,
- and clean up slightly at the same time. The 'j' forms currently compare,
- then set a register, then compare again, then branch. Branch directly on
- the result of the first compare.
-
- Around a 1% progression on deltablue, crypto & early boyer, for about 1/2%
- overall on v8-tests.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdSlowCase):
-
-2008-12-08 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Expand MacroAssembler to support more operations, required by the JIT.
-
- Generally adds more operations and permutations of operands to the existing
- interface. Rename 'jset' to 'jnz' and 'jnset' to 'jz', which seem clearer,
- and require that immediate pointer operands (though not pointer addresses to
- load and store instructions) are wrapped in a ImmPtr() type, akin to Imm32().
-
- No performance impact.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::):
- (JSC::MacroAssembler::ImmPtr::ImmPtr):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::and32):
- (JSC::MacroAssembler::or32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::xor32):
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::load32):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::store32):
- (JSC::MacroAssembler::poke):
- (JSC::MacroAssembler::move):
- (JSC::MacroAssembler::testImm32):
- (JSC::MacroAssembler::jae32):
- (JSC::MacroAssembler::jb32):
- (JSC::MacroAssembler::jePtr):
- (JSC::MacroAssembler::je32):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jne32):
- (JSC::MacroAssembler::jnzPtr):
- (JSC::MacroAssembler::jnz32):
- (JSC::MacroAssembler::jzPtr):
- (JSC::MacroAssembler::jz32):
- (JSC::MacroAssembler::joSub32):
- (JSC::MacroAssembler::jump):
- (JSC::MacroAssembler::sete32):
- (JSC::MacroAssembler::setne32):
- (JSC::MacroAssembler::setnz32):
- (JSC::MacroAssembler::setz32):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::addl_mr):
- (JSC::X86Assembler::andl_i8r):
- (JSC::X86Assembler::cmpl_rm):
- (JSC::X86Assembler::cmpl_mr):
- (JSC::X86Assembler::cmpl_i8m):
- (JSC::X86Assembler::subl_mr):
- (JSC::X86Assembler::testl_i32m):
- (JSC::X86Assembler::xorl_i32r):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::modRm_opmsib):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::emitPutCTIArgConstant):
- (JSC::JIT::emitPutCTIParam):
- (JSC::JIT::emitPutImmediateToCallFrameHeader):
- (JSC::JIT::emitInitRegister):
- (JSC::JIT::checkStructure):
- (JSC::JIT::emitJumpIfJSCell):
- (JSC::JIT::emitJumpIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
-
-2008-12-08 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed a bug where WREC would allow a quantifier whose minimum was
- greater than its maximum.
-
- * wrec/Quantifier.h:
- (JSC::WREC::Quantifier::Quantifier): ASSERT that the quantifier is not
- backwards.
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::consumeGreedyQuantifier): Verify that the minimum
- is not greater than the maximum.
-
-2008-12-08 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- * JavaScriptCore.scons: add bytecode/JumpTable.cpp
-
-2008-12-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=22716
- <rdar://problem/6428315>
- Add RareData structure to CodeBlock for infrequently used auxiliary data
- members.
-
- Reduces memory on Membuster-head by ~.5MB
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::dumpStatistics):
- (JSC::CodeBlock::mark):
- (JSC::CodeBlock::getHandlerForVPC):
- (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC):
- (JSC::CodeBlock::shrinkToFit):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::numberOfExceptionHandlers):
- (JSC::CodeBlock::addExceptionHandler):
- (JSC::CodeBlock::exceptionHandler):
- (JSC::CodeBlock::addFunction):
- (JSC::CodeBlock::function):
- (JSC::CodeBlock::addUnexpectedConstant):
- (JSC::CodeBlock::unexpectedConstant):
- (JSC::CodeBlock::addRegExp):
- (JSC::CodeBlock::regexp):
- (JSC::CodeBlock::numberOfImmediateSwitchJumpTables):
- (JSC::CodeBlock::addImmediateSwitchJumpTable):
- (JSC::CodeBlock::immediateSwitchJumpTable):
- (JSC::CodeBlock::numberOfCharacterSwitchJumpTables):
- (JSC::CodeBlock::addCharacterSwitchJumpTable):
- (JSC::CodeBlock::characterSwitchJumpTable):
- (JSC::CodeBlock::numberOfStringSwitchJumpTables):
- (JSC::CodeBlock::addStringSwitchJumpTable):
- (JSC::CodeBlock::stringSwitchJumpTable):
- (JSC::CodeBlock::evalCodeCache):
- (JSC::CodeBlock::createRareDataIfNecessary):
-
-2008-11-26 Peter Kasting <pkasting@google.com>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=16814
- Allow ports to disable ActiveX->NPAPI conversion for Media Player.
- Improve handling of miscellaneous ActiveX objects.
-
- * wtf/Platform.h: Add another ENABLE(...).
-
-2008-12-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Add dumping of CodeBlock member structure usage.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dumpStatistics):
- * bytecode/EvalCodeCache.h:
- (JSC::EvalCodeCache::isEmpty):
-
-2008-12-08 David Kilzer <ddkilzer@apple.com>
-
- Bug 22555: Sort "children" sections in Xcode project files
-
- <https://bugs.webkit.org/show_bug.cgi?id=22555>
-
- Reviewed by Eric Seidel.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Sorted.
-
-2008-12-08 Tony Chang <tony@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Enable Pan scrolling only when building on PLATFORM(WIN_OS)
- Previously platforms like Apple Windows WebKit, Cairo Windows WebKit,
- Wx and Chromium were enabling it explicitly, now we just turn it on
- for all WIN_OS, later platforms can turn it off as needed on Windows
- (or turn it on under Linux, etc.)
- https://bugs.webkit.org/show_bug.cgi?id=22698
-
- * wtf/Platform.h:
-
-2008-12-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Add basic memory statistics dumping for CodeBlock.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dumpStatistics):
- (JSC::CodeBlock::CodeBlock):
- (JSC::CodeBlock::~CodeBlock):
- * bytecode/CodeBlock.h:
-
-2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Linux build with newer gcc/glibc.
-
- * jit/ExecutableAllocatorPosix.cpp: Include unistd.h for
- getpagesize(), according to
- http://opengroup.org/onlinepubs/007908775/xsh/getpagesize.html
-
-2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the build with Qt on Windows.
-
- * JavaScriptCore.pri: Compile ExecutableAllocatorWin.cpp on Windows.
-
-2008-12-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Buildfix).
-
- Fix non-WREC builds
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
-
-2008-12-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Put ENABLE(ASSEMBLER) guards around use of ExecutableAllocator in global data
-
- Correct Qt and Gtk project files
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * runtime/JSGlobalData.h:
-
-2008-12-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Add new files to other projects.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.pro:
-
-2008-12-07 Oliver Hunt <oliver@apple.com>
-
- Rubber stamped by Mark Rowe.
-
- Rename ExecutableAllocatorMMAP to the more sensible ExecutableAllocatorPosix
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jit/ExecutableAllocator.h:
- * jit/ExecutableAllocatorPosix.cpp: Renamed from JavaScriptCore/jit/ExecutableAllocatorMMAP.cpp.
- (JSC::ExecutableAllocator::intializePageSize):
- (JSC::ExecutablePool::systemAlloc):
- (JSC::ExecutablePool::systemRelease):
-
-2008-12-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich and Sam Weinig
-
- <rdar://problem/6309878> Need more granular control over allocation of executable memory (21783)
- <https://bugs.webkit.org/show_bug.cgi?id=21783>
-
- Add a new allocator for use by the JIT that provides executable pages, so
- we can get rid of the current hack that makes the entire heap executable.
-
- 1-2% progression on SunSpider-v8, 1% on SunSpider. Reduces memory usage as well!
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/AssemblerBuffer.h:
- (JSC::AssemblerBuffer::size):
- (JSC::AssemblerBuffer::executableCopy):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::size):
- (JSC::MacroAssembler::copyCode):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::size):
- (JSC::X86Assembler::executableCopy):
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::~CodeBlock):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::executablePool):
- (JSC::CodeBlock::setExecutablePool):
- * bytecode/Instruction.h:
- (JSC::PolymorphicAccessStructureList::derefStructures):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::~Interpreter):
- * interpreter/Interpreter.h:
- * jit/ExecutableAllocator.cpp: Added.
- * jit/ExecutableAllocator.h: Added.
- (JSC::ExecutablePool::create):
- (JSC::ExecutablePool::alloc):
- (JSC::ExecutablePool::~ExecutablePool):
- (JSC::ExecutablePool::available):
- (JSC::ExecutablePool::ExecutablePool):
- (JSC::ExecutablePool::poolAllocate):
- (JSC::ExecutableAllocator::ExecutableAllocator):
- (JSC::ExecutableAllocator::poolForSize):
- (JSC::ExecutablePool::sizeForAllocation):
- * jit/ExecutableAllocatorMMAP.cpp: Added.
- (JSC::ExecutableAllocator::intializePageSize):
- (JSC::ExecutablePool::systemAlloc):
- (JSC::ExecutablePool::systemRelease):
- * jit/ExecutableAllocatorWin.cpp: Added.
- (JSC::ExecutableAllocator::intializePageSize):
- (JSC::ExecutablePool::systemAlloc):
- (JSC::ExecutablePool::systemRelease):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- (JSC::JIT::compileCTIMachineTrampolines):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- * parser/Nodes.cpp:
- (JSC::RegExpNode::emitBytecode):
- * runtime/JSGlobalData.h:
- (JSC::JSGlobalData::poolForSize):
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::create):
- (JSC::RegExp::~RegExp):
- * runtime/RegExp.h:
- * runtime/RegExpConstructor.cpp:
- (JSC::constructRegExp):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncCompile):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
- * wrec/WRECGenerator.h:
- * wtf/FastMalloc.cpp:
- * wtf/FastMalloc.h:
- * wtf/TCSystemAlloc.cpp:
- (TryMmap):
- (TryVirtualAlloc):
- (TryDevMem):
- (TCMalloc_SystemRelease):
-
-2008-12-06 Sam Weinig <sam@webkit.org>
-
- Fix the Gtk build.
-
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compilePutByIdHotPath):
-
-2008-12-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich,
-
- Move CodeBlock constructor into the .cpp file.
-
- Sunspider reports a .7% progression, but I can only assume this
- is noise.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::CodeBlock):
- * bytecode/CodeBlock.h:
-
-2008-12-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Split JumpTable code into its own file.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * bytecode/CodeBlock.cpp:
- * bytecode/CodeBlock.h:
- * bytecode/JumpTable.cpp: Copied from bytecode/CodeBlock.cpp.
- * bytecode/JumpTable.h: Copied from bytecode/CodeBlock.h.
-
-2008-12-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22715
- Encapsulate more CodeBlock members in preparation
- of moving some of them to a rare data structure.
-
- * bytecode/CodeBlock.cpp:
- (JSC::locationForOffset):
- (JSC::printConditionalJump):
- (JSC::printGetByIdOp):
- (JSC::printPutByIdOp):
- (JSC::CodeBlock::printStructure):
- (JSC::CodeBlock::printStructures):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::unlinkCallers):
- (JSC::CodeBlock::derefStructures):
- (JSC::CodeBlock::refStructures):
- (JSC::CodeBlock::mark):
- (JSC::CodeBlock::getHandlerForVPC):
- (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC):
- (JSC::CodeBlock::lineNumberForVPC):
- (JSC::CodeBlock::expressionRangeForVPC):
- (JSC::CodeBlock::shrinkToFit):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- (JSC::CodeBlock::addCaller):
- (JSC::CodeBlock::removeCaller):
- (JSC::CodeBlock::isKnownNotImmediate):
- (JSC::CodeBlock::isConstantRegisterIndex):
- (JSC::CodeBlock::getConstant):
- (JSC::CodeBlock::isTemporaryRegisterIndex):
- (JSC::CodeBlock::getStubInfo):
- (JSC::CodeBlock::getCallLinkInfo):
- (JSC::CodeBlock::instructions):
- (JSC::CodeBlock::setJITCode):
- (JSC::CodeBlock::jitCode):
- (JSC::CodeBlock::ownerNode):
- (JSC::CodeBlock::setGlobalData):
- (JSC::CodeBlock::setThisRegister):
- (JSC::CodeBlock::thisRegister):
- (JSC::CodeBlock::setNeedsFullScopeChain):
- (JSC::CodeBlock::needsFullScopeChain):
- (JSC::CodeBlock::setUsesEval):
- (JSC::CodeBlock::usesEval):
- (JSC::CodeBlock::setUsesArguments):
- (JSC::CodeBlock::usesArguments):
- (JSC::CodeBlock::codeType):
(JSC::CodeBlock::source):
(JSC::CodeBlock::sourceOffset):
- (JSC::CodeBlock::addGlobalResolveInstruction):
- (JSC::CodeBlock::numberOfPropertyAccessInstructions):
- (JSC::CodeBlock::addPropertyAccessInstruction):
- (JSC::CodeBlock::propertyAccessInstruction):
- (JSC::CodeBlock::numberOfCallLinkInfos):
- (JSC::CodeBlock::addCallLinkInfo):
- (JSC::CodeBlock::callLinkInfo):
- (JSC::CodeBlock::numberOfJumpTargets):
- (JSC::CodeBlock::addJumpTarget):
- (JSC::CodeBlock::jumpTarget):
- (JSC::CodeBlock::lastJumpTarget):
- (JSC::CodeBlock::numberOfExceptionHandlers):
- (JSC::CodeBlock::addExceptionHandler):
- (JSC::CodeBlock::exceptionHandler):
- (JSC::CodeBlock::addExpressionInfo):
- (JSC::CodeBlock::numberOfLineInfos):
- (JSC::CodeBlock::addLineInfo):
- (JSC::CodeBlock::lastLineInfo):
- (JSC::CodeBlock::jitReturnAddressVPCMap):
- (JSC::CodeBlock::numberOfIdentifiers):
- (JSC::CodeBlock::addIdentifier):
- (JSC::CodeBlock::identifier):
- (JSC::CodeBlock::numberOfConstantRegisters):
- (JSC::CodeBlock::addConstantRegister):
- (JSC::CodeBlock::constantRegister):
- (JSC::CodeBlock::addFunction):
- (JSC::CodeBlock::function):
- (JSC::CodeBlock::addFunctionExpression):
- (JSC::CodeBlock::functionExpression):
- (JSC::CodeBlock::addUnexpectedConstant):
- (JSC::CodeBlock::unexpectedConstant):
- (JSC::CodeBlock::addRegExp):
- (JSC::CodeBlock::regexp):
- (JSC::CodeBlock::symbolTable):
(JSC::CodeBlock::evalCodeCache):
- New inline setters/getters.
-
- (JSC::ProgramCodeBlock::ProgramCodeBlock):
- (JSC::ProgramCodeBlock::~ProgramCodeBlock):
- (JSC::ProgramCodeBlock::clearGlobalObject):
- * bytecode/SamplingTool.cpp:
- (JSC::ScopeSampleRecord::sample):
- (JSC::SamplingTool::dump):
- * bytecompiler/BytecodeGenerator.cpp:
- * bytecompiler/BytecodeGenerator.h:
- * bytecompiler/Label.h:
- * interpreter/CallFrame.cpp:
- * interpreter/Interpreter.cpp:
- * jit/JIT.cpp:
- * jit/JITCall.cpp:
- * jit/JITInlineMethods.h:
- * jit/JITPropertyAccess.cpp:
- * parser/Nodes.cpp:
- * runtime/Arguments.h:
- * runtime/ExceptionHelpers.cpp:
- * runtime/JSActivation.cpp:
- * runtime/JSActivation.h:
- * runtime/JSGlobalObject.cpp:
- Change direct access to use new getter/setters.
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Prevent GCC4.2 from hanging when trying to compile Interpreter.cpp.
- Added "-fno-var-tracking" compiler flag.
-
- https://bugs.webkit.org/show_bug.cgi?id=22704
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
-
- je, jg etc take an immediate operand as the second argument, but for the
- equality branches (je, jne) the immediate operand was the first argument. This
- was unnecessarily inconsistent. Change je, jne methods to take the immediate
- as the second argument.
-
- https://bugs.webkit.org/show_bug.cgi?id=22703
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::je32):
- (JSC::MacroAssembler::jne32):
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacterPair):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Second tranche of porting JIT.cpp to MacroAssembler interface.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::mul32):
- (JSC::MacroAssembler::jl32):
- (JSC::MacroAssembler::jnzSub32):
- (JSC::MacroAssembler::joAdd32):
- (JSC::MacroAssembler::joMul32):
- (JSC::MacroAssembler::jzSub32):
- * jit/JIT.cpp:
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
-
-2008-12-05 David Kilzer <ddkilzer@apple.com>
-
- Bug 22609: Provide a build-time choice when generating hash tables for properties of built-in DOM objects
-
- <https://bugs.webkit.org/show_bug.cgi?id=22609>
- <rdar://problem/6331749>
-
- Reviewed by Darin Adler.
-
- Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
-
- Added back the code that generates a "compact" hash (instead of a
- perfect hash) as a build-time option using the
- ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
-
- * create_hash_table: Rename variables to differentiate perfect hash
- values from compact hash values. Added back code to compute compact
- hash tables. Generate both hash table sizes and emit
- conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
- * runtime/Lookup.cpp:
- (JSC::HashTable::createTable): Added version of createTable() for
- use with compact hash tables.
- (JSC::HashTable::deleteTable): Updated to work with compact hash
- tables.
- * runtime/Lookup.h: Defined ENABLE(PERFECT_HASH_SIZE) macro here.
- (JSC::HashEntry::initialize): Set m_next to zero when using compact
- hash tables.
- (JSC::HashEntry::setNext): Added for compact hash tables.
- (JSC::HashEntry::next): Added for compact hash tables.
- (JSC::HashTable::entry): Added version of entry() for use with
- compact hash tables.
- * runtime/Structure.cpp:
- (JSC::Structure::getEnumerablePropertyNames): Updated to work with
- compact hash tables.
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove redundant calls to JIT::emitSlowScriptCheck.
- This is checked in the hot path, so is not needed on the slow path - and the code
- was being planted before the start of the slow case, so was completely unreachable!
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileSlowCases):
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Move JIT::compileOpStrictEq to MacroAssembler interface.
-
- The rewrite also looks like a small (<1%) performance progression.
-
- https://bugs.webkit.org/show_bug.cgi?id=22697
-
- * jit/JIT.cpp:
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitJumpIfJSCell):
- (JSC::JIT::emitJumpSlowCaseIfJSCell):
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove m_assembler from MacroAssembler::Jump.
- Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer
- than "link(this)". But maintaining this doubles the size of Jump, which
- is even more unfortunate for the JIT, since there are many large structures
- holding JmpSrcs. Probably best to remove it.
-
- https://bugs.webkit.org/show_bug.cgi?id=22693
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::Jump::Jump):
- (JSC::MacroAssembler::Jump::link):
- (JSC::MacroAssembler::Jump::linkTo):
- (JSC::MacroAssembler::JumpList::link):
- (JSC::MacroAssembler::JumpList::linkTo):
- (JSC::MacroAssembler::jae32):
- (JSC::MacroAssembler::je32):
- (JSC::MacroAssembler::je16):
- (JSC::MacroAssembler::jg32):
- (JSC::MacroAssembler::jge32):
- (JSC::MacroAssembler::jl32):
- (JSC::MacroAssembler::jle32):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jne32):
- (JSC::MacroAssembler::jnset32):
- (JSC::MacroAssembler::jset32):
- (JSC::MacroAssembler::jump):
- (JSC::MacroAssembler::jzSub32):
- (JSC::MacroAssembler::joAdd32):
- (JSC::MacroAssembler::call):
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateBackreferenceQuantifier):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateParenthesesAssertion):
- (JSC::WREC::Generator::generateParenthesesInvertedAssertion):
- (JSC::WREC::Generator::generateParenthesesNonGreedy):
- (JSC::WREC::Generator::generateParenthesesResetTrampoline):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::generateBackreference):
- (JSC::WREC::Generator::terminateAlternative):
- (JSC::WREC::Generator::terminateDisjunction):
- * wrec/WRECParser.h:
-
-2008-12-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Simplify JIT generated checks for timeout code, by moving more work into the C function.
- https://bugs.webkit.org/show_bug.cgi?id=22688
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_timeout_check):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::emitSlowScriptCheck):
-
-2008-12-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Encapsulate access to jump tables in the CodeBlock in preparation
- of moving them to a rare data structure.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::shrinkToFit):
- * bytecode/CodeBlock.h:
- (JSC::CodeBlock::numberOfImmediateSwitchJumpTables):
- (JSC::CodeBlock::addImmediateSwitchJumpTable):
- (JSC::CodeBlock::immediateSwitchJumpTable):
- (JSC::CodeBlock::numberOfCharacterSwitchJumpTables):
- (JSC::CodeBlock::addCharacterSwitchJumpTable):
- (JSC::CodeBlock::characterSwitchJumpTable):
- (JSC::CodeBlock::numberOfStringSwitchJumpTables):
- (JSC::CodeBlock::addStringSwitchJumpTable):
- (JSC::CodeBlock::stringSwitchJumpTable):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate):
- (JSC::BytecodeGenerator::endSwitch):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
-
-2008-12-05 Adam Roben <aroben@apple.com>
-
- Windows build fix after r39020
-
- * jit/JITInlineMethods.h:
- (JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- Add some apparently-missing __.
-
-2008-12-04 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22673
-
- Added support for the assertion (?=) and inverted assertion (?!) atoms
- in WREC.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateParenthesesAssertion):
- (JSC::WREC::Generator::generateParenthesesInvertedAssertion): Split the
- old (unused) generateParentheses into these two functions, with more
- limited capabilities.
-
- * wrec/WRECGenerator.h:
- (JSC::WREC::Generator::): Moved an enum to the top of the class definition,
- to match the WebKit style, and removed a defunct comment.
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parseParentheses):
- (JSC::WREC::Parser::consumeParenthesesType):
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::): Added support for parsing (?=) and (?!).
-
-2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
-
- Rubber-stamped by Tor Arne Vestbø.
-
- Disable the JIT for the Qt build alltogether again, after observing
- more miscompilations in a wider range of newer gcc versions.
-
- * JavaScriptCore.pri:
-
-2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Disable the JIT for the Qt build on Linux unless gcc is >= 4.2,
- due to miscompilations.
-
- * JavaScriptCore.pri:
-
-2008-12-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Start porting the JIT to use the MacroAssembler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22671
- No change in performance.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::Jump::operator X86Assembler::JmpSrc):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::and32):
- (JSC::MacroAssembler::lshift32):
- (JSC::MacroAssembler::rshift32):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::store32):
- (JSC::MacroAssembler::poke):
- (JSC::MacroAssembler::move):
- (JSC::MacroAssembler::compareImm32ForBranchEquality):
- (JSC::MacroAssembler::jnePtr):
- (JSC::MacroAssembler::jnset32):
- (JSC::MacroAssembler::jset32):
- (JSC::MacroAssembler::jzeroSub32):
- (JSC::MacroAssembler::joverAdd32):
- (JSC::MacroAssembler::call):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::shll_i8r):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp:
- (JSC::JIT::compileBinaryArithOp):
- * jit/JITInlineMethods.h:
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::emitPutCTIArg):
- (JSC::JIT::emitPutCTIArgConstant):
- (JSC::JIT::emitGetCTIArg):
- (JSC::JIT::emitPutCTIArgFromVirtualRegister):
- (JSC::JIT::emitPutCTIParam):
- (JSC::JIT::emitGetCTIParam):
- (JSC::JIT::emitPutToCallFrameHeader):
- (JSC::JIT::emitPutImmediateToCallFrameHeader):
- (JSC::JIT::emitGetFromCallFrameHeader):
- (JSC::JIT::emitPutVirtualRegister):
- (JSC::JIT::emitInitRegister):
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::restoreArgumentReference):
- (JSC::JIT::restoreArgumentReferenceForTrampoline):
- (JSC::JIT::emitCTICall):
- (JSC::JIT::checkStructure):
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
- (JSC::JIT::emitFastArithDeTagImmediate):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
- (JSC::JIT::emitFastArithImmToInt):
- (JSC::JIT::emitFastArithIntToImmOrSlowCase):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
- (JSC::JIT::emitTagAsBoolImmediate):
- * jit/JITPropertyAccess.cpp:
- (JSC::JIT::privateCompilePutByIdTransition):
-
-2008-12-04 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Some refactoring for generateGreedyQuantifier.
-
- SunSpider reports no change (possibly a 0.3% speedup).
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateGreedyQuantifier): Clarified label
- meanings and unified some logic to simplify things.
-
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::parseAlternative): Added a version of parseAlternative
- that can jump to a Label, instead of a JumpList, upon failure. (Eventually,
- when we have a true Label class, this will be redundant.) This makes
- things easier for generateGreedyQuantifier, because it can avoid
- explicitly linking things.
-
-2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Fix crashes in the Qt build on Linux/i386 with non-executable memory
- by enabling TCSystemAlloc and the PROT_EXEC flag for mmap.
-
- * JavaScriptCore.pri: Enable the use of TCSystemAlloc if the JIT is
- enabled.
- * wtf/TCSystemAlloc.cpp: Extend the PROT_EXEC permissions to
- PLATFORM(QT).
-
-2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Enable ENABLE_JIT_OPTIMIZE_CALL, ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
- and ENABLE_JIT_OPTIMIZE_ARITHMETIC, as suggested by Niko.
-
- * JavaScriptCore.pri:
-
-2008-12-04 Kent Hansen <khansen@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Enable the JSC jit for the Qt build by default for release builds on
- linux-g++ and win32-msvc.
-
- * JavaScriptCore.pri:
-
-2008-12-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Allow JIT to function without property access repatching and arithmetic optimizations.
- Controlled by ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS and ENABLE_JIT_OPTIMIZE_ARITHMETIC switches.
-
- https://bugs.webkit.org/show_bug.cgi?id=22643
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITArithmetic.cpp: Copied from jit/JIT.cpp.
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- * jit/JITPropertyAccess.cpp: Copied from jit/JIT.cpp.
- (JSC::JIT::compileGetByIdHotPath):
- (JSC::JIT::compileGetByIdSlowCase):
- (JSC::JIT::compilePutByIdHotPath):
- (JSC::JIT::compilePutByIdSlowCase):
- (JSC::resizePropertyStorage):
- (JSC::transitionWillNeedStorageRealloc):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * wtf/Platform.h:
-
-2008-12-03 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Optimized sequences of characters in regular expressions by comparing
- two characters at a time.
-
- 1-2% speedup on SunSpider, 19-25% speedup on regexp-dna.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::load32):
- (JSC::MacroAssembler::jge32): Filled out a few more macro methods.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::movl_mr): Added a verion of movl_mr that operates
- without an offset, to allow the macro assembler to optmize for that case.
-
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp): Test the saved value of index
- instead of the index register when checking for "end of input." The
- index register doesn't increment by 1 in an orderly fashion, so testing
- it for == "end of input" is not valid.
-
- Also, jump all the way to "return failure" upon reaching "end of input,"
- instead of executing the next alternative. This is more logical, and
- it's a slight optimization in the case of an expression with many alternatives.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateIncrementIndex): Added support for
- jumping to a failure label in the case where the index has reached "end
- of input."
-
- (JSC::WREC::Generator::generatePatternCharacterSequence):
- (JSC::WREC::Generator::generatePatternCharacterPair): This is the
- optmization. It's basically like generatePatternCharacter, but it runs two
- characters at a time.
-
- (JSC::WREC::Generator::generatePatternCharacter): Changed to use isASCII,
- since it's clearer than comparing to a magic hex value.
-
- * wrec/WRECGenerator.h:
-
-2008-12-03 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Allow JIT to operate without the call-repatching optimization.
- Controlled by ENABLE(JIT_OPTIMIZE_CALL), defaults on, disabling
- this leads to significant performance regression.
-
- https://bugs.webkit.org/show_bug.cgi?id=22639
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * jit/JITCall.cpp: Copied from jit/JIT.cpp.
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCallEvalSetupArgs):
- (JSC::JIT::compileOpConstructSetupArgs):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpCallSlowCase):
- (JSC::unreachable):
- * jit/JITInlineMethods.h: Copied from jit/JIT.cpp.
- (JSC::JIT::checkStructure):
- (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
- (JSC::JIT::emitTagAsBoolImmediate):
- * wtf/Platform.h:
-
-2008-12-03 Eric Seidel <eric@webkit.org>
-
- Rubber-stamped by David Hyatt.
-
- Make HAVE_ACCESSIBILITY only define if !defined
-
- * wtf/Platform.h:
-
-2008-12-03 Sam Weinig <sam@webkit.org>
-
- Fix build.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::orl_i32r):
-
-2008-12-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
- an 256 byte inline capacity.
-
- 1% progression on Sunspider.
-
- * assembler/AssemblerBuffer.h:
- (JSC::AssemblerBuffer::AssemblerBuffer):
- (JSC::AssemblerBuffer::~AssemblerBuffer):
- (JSC::AssemblerBuffer::grow):
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::MacroAssembler):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::X86Assembler):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::JIT):
- * parser/Nodes.cpp:
- (JSC::RegExpNode::emitBytecode):
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::create):
- * runtime/RegExp.h:
- * runtime/RegExpConstructor.cpp:
- (JSC::constructRegExp):
- * runtime/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncCompile):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
- * wrec/WRECGenerator.h:
- (JSC::WREC::Generator::Generator):
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::Parser):
-
-2008-12-03 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt, with help from Gavin Barraclough.
-
- orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
- orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
- a new orl_i32r that actually does a 32bit OR.
-
- (32bit OR is currently unused, but a patch I'm working on uses it.)
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::orl_i8r): The old orl_i32r.
- (JSC::X86Assembler::orl_i32r): The new orl_i32r.
-
- * jit/JIT.cpp:
- (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
- (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit
- values.
-
-2008-12-03 Dean Jackson <dino@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Helper functions for turn -> degrees.
- https://bugs.webkit.org/show_bug.cgi?id=22497
-
- * wtf/MathExtras.h:
- (turn2deg):
- (deg2turn):
-
-2008-12-02 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 22504: Crashes during code generation occur due to refing of ignoredResult()
- <https://bugs.webkit.org/show_bug.cgi?id=22504>
-
- Since ignoredResult() was implemented by casting 1 to a RegisterID*, any
- attempt to ref ignoredResult() results in a crash. This will occur in
- code generation of a function body where a node emits another node with
- the dst that was passed to it, and then refs the returned RegisterID*.
-
- To fix this problem, make ignoredResult() a member function of
- BytecodeGenerator that simply returns a pointe to a fixed RegisterID
- member of BytecodeGenerator.
-
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::ignoredResult):
- * bytecompiler/RegisterID.h:
- * parser/Nodes.cpp:
- (JSC::NullNode::emitBytecode):
- (JSC::BooleanNode::emitBytecode):
- (JSC::NumberNode::emitBytecode):
- (JSC::StringNode::emitBytecode):
- (JSC::RegExpNode::emitBytecode):
- (JSC::ThisNode::emitBytecode):
- (JSC::ResolveNode::emitBytecode):
- (JSC::ObjectLiteralNode::emitBytecode):
- (JSC::PostfixResolveNode::emitBytecode):
- (JSC::PostfixBracketNode::emitBytecode):
- (JSC::PostfixDotNode::emitBytecode):
- (JSC::DeleteValueNode::emitBytecode):
- (JSC::VoidNode::emitBytecode):
- (JSC::TypeOfResolveNode::emitBytecode):
- (JSC::TypeOfValueNode::emitBytecode):
- (JSC::PrefixResolveNode::emitBytecode):
- (JSC::AssignResolveNode::emitBytecode):
- (JSC::CommaNode::emitBytecode):
- (JSC::ForNode::emitBytecode):
- (JSC::ForInNode::emitBytecode):
- (JSC::ReturnNode::emitBytecode):
- (JSC::ThrowNode::emitBytecode):
- (JSC::FunctionBodyNode::emitBytecode):
- (JSC::FuncDeclNode::emitBytecode):
-
-2008-12-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22537
- REGRESSION (r38745): Assertion failure in jsSubstring() at ge.com
-
- The bug was that index would become greater than length, so our
- "end of input" checks, which all check "index == length", would fail.
-
- The solution is to check for end of input before incrementing index,
- to ensure that index is always <= length.
-
- As a side benefit, generateJumpIfEndOfInput can now use je instead of
- jg, which should be slightly faster.
-
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateJumpIfEndOfInput):
-
-2008-12-02 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Plant shift right immediate instructions, which are awesome.
- https://bugs.webkit.org/show_bug.cgi?id=22610
- ~5% on the v8-crypto test.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
-
-2008-12-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Cleaned up SegmentedVector by abstracting segment access into helper
- functions.
-
- SunSpider reports no change.
-
- * bytecompiler/SegmentedVector.h:
- (JSC::SegmentedVector::SegmentedVector):
- (JSC::SegmentedVector::~SegmentedVector):
- (JSC::SegmentedVector::size):
- (JSC::SegmentedVector::at):
- (JSC::SegmentedVector::operator[]):
- (JSC::SegmentedVector::last):
- (JSC::SegmentedVector::append):
- (JSC::SegmentedVector::removeLast):
- (JSC::SegmentedVector::grow):
- (JSC::SegmentedVector::clear):
- (JSC::SegmentedVector::deleteAllSegments):
- (JSC::SegmentedVector::segmentFor):
- (JSC::SegmentedVector::subscriptFor):
- (JSC::SegmentedVector::ensureSegmentsFor):
- (JSC::SegmentedVector::ensureSegment):
-
-2008-12-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <zwarich@apple.com>.)
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22482
- REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
- message when running the V8 Raytrace benchmark
-
- Rolled out r37991. It didn't properly save xmm0, which is caller-save,
- before calling helper functions.
-
- SunSpider and v8 benchmarks show little change -- possibly a .2%
- SunSpider regression, possibly a .2% v8 benchmark speedup.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * bytecode/Instruction.h:
- (JSC::Instruction::):
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::emitUnaryOp):
- * bytecompiler/BytecodeGenerator.h:
- (JSC::BytecodeGenerator::emitToJSNumber):
- (JSC::BytecodeGenerator::emitTypeOf):
- (JSC::BytecodeGenerator::emitGetPropertyNames):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- * jit/JIT.h:
- * parser/Nodes.cpp:
- (JSC::UnaryOpNode::emitBytecode):
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::EqualNode::emitBytecode):
- * parser/ResultType.h:
- (JSC::ResultType::isReusable):
- (JSC::ResultType::mightBeNumber):
- * runtime/JSNumberCell.h:
-
-2008-12-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Remove unused (sampling only, and derivable) argument to JIT::emitCTICall.
- https://bugs.webkit.org/show_bug.cgi?id=22587
-
- * jit/JIT.cpp:
- (JSC::JIT::emitCTICall):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- * jit/JIT.h:
-
-2008-12-02 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Fix the inheritance chain for JSFunction.
-
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::info): Add InternalFunction::info as parent class
-
-2008-12-02 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix ability to include JavaScriptCore.pri from other .pro files.
-
- * JavaScriptCore.pri: Moved -O3 setting into the .pro files.
- * JavaScriptCore.pro:
- * jsc.pro:
-
-2008-12-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich, with help from Gavin Barraclough.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22583.
-
- Refactored regular expression parsing to parse sequences of characters
- as a single unit, in preparation for optimizing sequences of characters.
-
- SunSpider reports no change.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * wrec/Escapes.h: Added. Set of classes for representing an escaped
- token in a pattern.
-
- * wrec/Quantifier.h:
- (JSC::WREC::Quantifier::Quantifier): Simplified this constructor slightly,
- to match the new Escape constructor.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generatePatternCharacterSequence):
- * wrec/WRECGenerator.h: Added an interface for generating a sequence
- of pattern characters at a time. It doesn't do anything special yet.
-
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::consumeGreedyQuantifier):
- (JSC::WREC::Parser::consumeQuantifier): Renamed "parse" to "consume" in
- these functions, to match "consumeEscape."
-
- (JSC::WREC::Parser::parsePatternCharacterSequence): New function for
- iteratively aggregating a sequence of characters in a pattern.
-
- (JSC::WREC::Parser::parseCharacterClassQuantifier):
- (JSC::WREC::Parser::parseBackreferenceQuantifier): Renamed "parse" to
- "consume" in these functions, to match "consumeEscape."
-
- (JSC::WREC::Parser::parseCharacterClass): Refactored to use the common
- escape processing code in consumeEscape.
-
- (JSC::WREC::Parser::parseEscape): Refactored to use the common
- escape processing code in consumeEscape.
-
- (JSC::WREC::Parser::consumeEscape): Factored escaped token processing
- into a common function, since we were doing this in a few places.
-
- (JSC::WREC::Parser::parseTerm): Refactored to use the common
- escape processing code in consumeEscape.
-
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::consumeOctal): Refactored to use a helper function
- for reading a digit.
-
-2008-12-01 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
- <https://bugs.webkit.org/show_bug.cgi?id=20340>
-
- SegmentedVector currently frees segments and reallocates them when used
- as a stack. This can lead to unsafe use of pointers into freed segments.
-
- In order to fix this problem, SegmentedVector will be changed to only
- grow and never shrink. Also, rename the reserveCapacity() member
- function to grow() to match the actual usage in BytecodeGenerator, where
- this function is used to allocate a group of registers at once, rather
- than merely saving space for them.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator): Use grow() instead of
- reserveCapacity().
- * bytecompiler/SegmentedVector.h:
- (JSC::SegmentedVector::SegmentedVector):
- (JSC::SegmentedVector::last):
- (JSC::SegmentedVector::append):
- (JSC::SegmentedVector::removeLast):
- (JSC::SegmentedVector::grow): Renamed from reserveCapacity().
- (JSC::SegmentedVector::clear):
-
-2008-12-01 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Anders Carlsson.
-
- Disable WREC for x86_64 since memory allocated by the system allocator is not marked executable,
- which causes 64-bit debug builds to crash. Once we have a dedicated allocator for executable
- memory we can turn this back on.
-
- * wtf/Platform.h:
-
-2008-12-01 Antti Koivisto <antti@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Restore inline buffer after vector is shrunk back below its inline capacity.
-
- * wtf/Vector.h:
- (WTF::):
- (WTF::VectorBuffer::restoreInlineBufferIfNeeded):
- (WTF::::shrinkCapacity):
-
-2008-11-30 Antti Koivisto <antti@apple.com>
-
- Reviewed by Mark Rowe.
-
- Try to return free pages in the current thread cache too.
-
- * wtf/FastMalloc.cpp:
- (WTF::TCMallocStats::releaseFastMallocFreeMemory):
-
-2008-12-01 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22567
- Make HashTable work as expected with respect to threads. Specifically, it has class-level
- thread safety and constant methods work on constant objects without synchronization.
-
- No observable change in behavior, so no test. This only affects debug builds.
-
- * wtf/HashTable.cpp:
- (WTF::hashTableStatsMutex):
- (WTF::HashTableStats::~HashTableStats):
- (WTF::HashTableStats::recordCollisionAtCount):
- Guarded variable access with a mutex.
-
- * wtf/HashTable.h:
- (WTF::::lookup):
- (WTF::::lookupForWriting):
- (WTF::::fullLookupForWriting):
- (WTF::::add):
- (WTF::::reinsert):
- (WTF::::remove):
- (WTF::::rehash):
- Changed increments of static variables to use atomicIncrement.
-
- (WTF::::invalidateIterators):
- (WTF::addIterator):
- (WTF::removeIterator):
- Guarded mutable access with a mutex.
-
-2008-11-29 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Enable WREC on PLATFORM(X86_64). This change predominantly requires changes to the
- WREC::Generator::generateEnter method to support the x86-64 ABI, and addition of
- support for a limited number of quadword operations in the X86Assembler.
-
- This patch will cause the JS heap to be allocated with RWX permissions on 64-bit Mac
- platforms. This is a regression with respect to previous 64-bit behaviour, but is no
- more permissive than on 32-bit builds. This issue should be addressed at some point.
- (This is tracked by bug #21783.)
-
- https://bugs.webkit.org/show_bug.cgi?id=22554
- Greater than 4x speedup on regexp-dna, on x86-64.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::addPtr):
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::pop):
- (JSC::MacroAssembler::push):
- (JSC::MacroAssembler::move):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::movq_rr):
- (JSC::X86Assembler::addl_i8m):
- (JSC::X86Assembler::addl_i32r):
- (JSC::X86Assembler::addq_i8r):
- (JSC::X86Assembler::addq_i32r):
- (JSC::X86Assembler::movq_mr):
- (JSC::X86Assembler::movq_rm):
- * wrec/WREC.h:
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateReturnSuccess):
- (JSC::WREC::Generator::generateReturnFailure):
- * wtf/Platform.h:
- * wtf/TCSystemAlloc.cpp:
-
-2008-12-01 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Preliminary work for bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
- <https://bugs.webkit.org/show_bug.cgi?id=20340>
-
- SegmentedVector currently frees segments and reallocates them when used
- as a stack. This can lead to unsafe use of pointers into freed segments.
-
- In order to fix this problem, SegmentedVector will be changed to only
- grow and never shrink, with the sole exception of clearing all of its
- data, a capability that is required by Lexer. This patch changes the
- public interface to only allow for these capabilities.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator): Use reserveCapacity()
- instead of resize() for m_globals and m_parameters.
- * bytecompiler/SegmentedVector.h:
- (JSC::SegmentedVector::resize): Removed.
- (JSC::SegmentedVector::reserveCapacity): Added.
- (JSC::SegmentedVector::clear): Added.
- (JSC::SegmentedVector::shrink): Removed.
- (JSC::SegmentedVector::grow): Removed.
- * parser/Lexer.cpp:
- (JSC::Lexer::clear): Use clear() instead of resize(0).
-
-2008-11-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Renames jumps to m_jumps in JumpList.
-
- * assembler/MacroAssembler.h:
- (JSC::MacroAssembler::JumpList::link):
- (JSC::MacroAssembler::JumpList::linkTo):
- (JSC::MacroAssembler::JumpList::append):
-
-2008-11-30 Antti Koivisto <antti@apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22557
-
- Report free size in central and thread caches too.
-
- * wtf/FastMalloc.cpp:
- (WTF::TCMallocStats::fastMallocStatistics):
- * wtf/FastMalloc.h:
-
-2008-11-29 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22557
- Add statistics for JavaScript GC heap.
-
- * JavaScriptCore.exp:
- * runtime/Collector.cpp:
- (JSC::Heap::objectCount):
- (JSC::addToStatistics):
- (JSC::Heap::statistics):
- * runtime/Collector.h:
-
-2008-11-29 Antti Koivisto <antti@apple.com>
-
- Fix debug build by adding a stub method.
-
- * wtf/FastMalloc.cpp:
- (WTF::fastMallocStatistics):
-
-2008-11-29 Antti Koivisto <antti@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22557
-
- Add function for getting basic statistics from FastMalloc.
-
- * JavaScriptCore.exp:
- * wtf/FastMalloc.cpp:
- (WTF::DLL_Length):
- (WTF::TCMalloc_PageHeap::ReturnedBytes):
- (WTF::TCMallocStats::fastMallocStatistics):
- * wtf/FastMalloc.h:
-
-2008-11-29 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- The C++ standard does not automatically grant the friendships of an
- enclosing class to its nested subclasses, so we should do so explicitly.
- This fixes the GCC 4.0 build, although both GCC 4.2 and Visual C++ 2005
- accept the incorrect code as it is.
-
- * assembler/MacroAssembler.h:
-
-2008-11-29 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Add the class MacroAssembler to provide some abstraction of code generation,
- and change WREC to make use of this class, rather than directly accessing
- the X86Assembler.
-
- This patch also allows WREC to be compiled without the rest of the JIT enabled.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/MacroAssembler.h: Added.
- (JSC::MacroAssembler::):
- (JSC::MacroAssembler::MacroAssembler):
- (JSC::MacroAssembler::copyCode):
- (JSC::MacroAssembler::Address::Address):
- (JSC::MacroAssembler::ImplicitAddress::ImplicitAddress):
- (JSC::MacroAssembler::BaseIndex::BaseIndex):
- (JSC::MacroAssembler::Label::Label):
- (JSC::MacroAssembler::Jump::Jump):
- (JSC::MacroAssembler::Jump::link):
- (JSC::MacroAssembler::Jump::linkTo):
- (JSC::MacroAssembler::JumpList::link):
- (JSC::MacroAssembler::JumpList::linkTo):
- (JSC::MacroAssembler::JumpList::append):
- (JSC::MacroAssembler::Imm32::Imm32):
- (JSC::MacroAssembler::add32):
- (JSC::MacroAssembler::or32):
- (JSC::MacroAssembler::sub32):
- (JSC::MacroAssembler::loadPtr):
- (JSC::MacroAssembler::load32):
- (JSC::MacroAssembler::load16):
- (JSC::MacroAssembler::storePtr):
- (JSC::MacroAssembler::store32):
- (JSC::MacroAssembler::pop):
- (JSC::MacroAssembler::push):
- (JSC::MacroAssembler::peek):
- (JSC::MacroAssembler::poke):
- (JSC::MacroAssembler::move):
- (JSC::MacroAssembler::compareImm32ForBranch):
- (JSC::MacroAssembler::compareImm32ForBranchEquality):
- (JSC::MacroAssembler::jae32):
- (JSC::MacroAssembler::je32):
- (JSC::MacroAssembler::je16):
- (JSC::MacroAssembler::jg32):
- (JSC::MacroAssembler::jge32):
- (JSC::MacroAssembler::jl32):
- (JSC::MacroAssembler::jle32):
- (JSC::MacroAssembler::jne32):
- (JSC::MacroAssembler::jump):
- (JSC::MacroAssembler::breakpoint):
- (JSC::MacroAssembler::ret):
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::cmpw_rm):
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::Interpreter):
- * interpreter/Interpreter.h:
- (JSC::Interpreter::assemblerBuffer):
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- * wrec/WREC.cpp:
- (JSC::WREC::Generator::compileRegExp):
- * wrec/WREC.h:
- * wrec/WRECFunctors.cpp:
- (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom):
- (JSC::WREC::GenerateCharacterClassFunctor::generateAtom):
- (JSC::WREC::GenerateBackreferenceFunctor::generateAtom):
- (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
- * wrec/WRECFunctors.h:
- (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateReturnSuccess):
- (JSC::WREC::Generator::generateSaveIndex):
- (JSC::WREC::Generator::generateIncrementIndex):
- (JSC::WREC::Generator::generateLoadCharacter):
- (JSC::WREC::Generator::generateJumpIfEndOfInput):
- (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
- (JSC::WREC::Generator::generateReturnFailure):
- (JSC::WREC::Generator::generateBacktrack1):
- (JSC::WREC::Generator::generateBacktrackBackreference):
- (JSC::WREC::Generator::generateBackreferenceQuantifier):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateParentheses):
- (JSC::WREC::Generator::generateParenthesesNonGreedy):
- (JSC::WREC::Generator::generateParenthesesResetTrampoline):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::generateBackreference):
- (JSC::WREC::Generator::terminateAlternative):
- (JSC::WREC::Generator::terminateDisjunction):
- * wrec/WRECGenerator.h:
- (JSC::WREC::Generator::Generator):
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parsePatternCharacterQualifier):
- (JSC::WREC::Parser::parseCharacterClassQuantifier):
- (JSC::WREC::Parser::parseBackreferenceQuantifier):
- (JSC::WREC::Parser::parseParentheses):
- (JSC::WREC::Parser::parseCharacterClass):
- (JSC::WREC::Parser::parseOctalEscape):
- (JSC::WREC::Parser::parseEscape):
- (JSC::WREC::Parser::parseTerm):
- (JSC::WREC::Parser::parseDisjunction):
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::Parser):
- (JSC::WREC::Parser::parsePattern):
- (JSC::WREC::Parser::parseAlternative):
- * wtf/Platform.h:
-
-2008-11-28 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix compilation on Windows CE
-
- Port away from the use of errno after calling strtol(), instead
- detect conversion errors by checking the result and the stop
- position.
-
- * runtime/DateMath.cpp:
- (JSC::parseLong):
- (JSC::parseDate):
-
-2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.
-
- * runtime/DateMath.cpp:
- (JSC::lowResUTCTime):
-
-2008-11-28 Simon Hausmann <hausmann@webkit.org>
-
- Rubber-stamped by Tor Arne Vestbø.
-
- Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.
-
- * runtime/JSGlobalObjectFunctions.cpp:
-
-2008-11-27 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- r38825 made JSFunction::m_body private, but some inspector code in
- WebCore sets the field. Add setters for it.
-
- * runtime/JSFunction.h:
- (JSC::JSFunction::setBody):
-
-2008-11-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix FIXME by adding accessor for JSFunction's m_body property.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- * profiler/Profiler.cpp:
- (JSC::createCallIdentifierFromFunctionImp):
- * runtime/Arguments.h:
- (JSC::Arguments::getArgumentsData):
- (JSC::Arguments::Arguments):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncToString):
- * runtime/JSFunction.h:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::body):
-
-2008-11-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Remove unused member variables from ProgramNode.
-
- * parser/Nodes.h:
-
-2008-11-27 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Enable mouse panning feaure on Windows Cairo build.
- See http://bugs.webkit.org/show_bug.cgi?id=22525
-
- * wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
-
-2008-11-27 Alp Toker <alp@nuanti.com>
-
- Change recently introduced C++ comments in Platform.h to C comments to
- fix the minidom build with traditional C.
-
- Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
- API header breakage at build time.
-
- * GNUmakefile.am:
- * wtf/Platform.h:
-
-2008-11-27 Alp Toker <alp@nuanti.com>
-
- Remove C++ comment from JavaScriptCore API headers (introduced r35449).
- Fixes build for ANSI C applications using the public API.
-
- * API/WebKitAvailability.h:
-
-2008-11-26 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Fix the JSC Chromium Mac build by adding JavaScriptCore/icu into the include path
-
- * JavaScriptCore.scons:
-
-2008-11-25 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Remove the unused member function JSFunction::getParameterName().
-
- * runtime/JSFunction.cpp:
- * runtime/JSFunction.h:
-
-2008-11-24 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Polymorpic caching for get by id chain. Similar to the polymorphic caching already implemented
- for self and proto accesses (implemented by allowing multiple trampolines to be JIT genertaed,
- and linked together) - the get by id chain caching is implemented as a genericization of the
- proto list caching, allowing cached access lists to contain a mix of proto and proto chain
- accesses (since in JS style inheritance hierarchies you may commonly see a mix of properties
- being overridden on the direct prototype, or higher up its prototype chain).
-
- In order to allow this patch to compile there is a fix to appease gcc 4.2 compiler issues
- (removing the jumps between fall-through cases in privateExecute).
-
- This patch also removes redundant immediate checking from the reptach code, and fixes a related
- memory leak (failure to deallocate trampolines).
-
- ~2% progression on v8 tests (bulk on the win on deltablue)
-
- * bytecode/Instruction.h:
- (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::):
- (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
- (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- (JSC::PolymorphicAccessStructureList::derefStructures):
- * interpreter/Interpreter.cpp:
- (JSC::countPrototypeChainEntriesAndCheckForProxies):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::getPolymorphicAccessStructureListSlot):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChainList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * jit/JIT.h:
- (JSC::JIT::compileGetByIdChainList):
-
-2008-11-25 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Move the collect() call in Heap::heapAllocate() that is conditionally
- compiled under COLLECT_ON_EVERY_ALLOCATION so that it is before we get
- information about the heap. This was causing assertion failures for me
- while I was reducing a bug.
-
- * runtime/Collector.cpp:
- (JSC::Heap::heapAllocate):
-
-2008-11-24 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 13790: Function declarations are not treated as statements (used to affect starcraft2.com)
- <https://bugs.webkit.org/show_bug.cgi?id=13790>
-
- Modify the parser to treat function declarations as statements,
- simplifying the grammar in the process. Technically, according to the
- grammar in the ECMA spec, function declarations are not statements and
- can not be used everywhere that statements can, but it is not worth the
- possibility compatibility issues just to stick to the spec in this case.
-
- * parser/Grammar.y:
- * parser/Nodes.cpp:
- (JSC::FuncDeclNode::emitBytecode): Avoid returning ignoredResult()
- as a result, because it causes a crash in DoWhileNode::emitBytecode().
-
-2008-11-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Unroll the regexp matching loop by 1. 10% speedup on simple matching
- stress test. No change on SunSpider.
-
- (I decided not to unroll to arbitrary levels because the returns diminsh
- quickly.)
-
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateJumpIfEndOfInput):
- (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
- * wrec/WRECGenerator.h:
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::error):
- (JSC::WREC::Parser::parsePattern):
-
-2008-11-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Removed some unnecessary "Generator::" prefixes.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateReturnSuccess):
- (JSC::WREC::Generator::generateSaveIndex):
- (JSC::WREC::Generator::generateIncrementIndex):
- (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
- (JSC::WREC::Generator::generateReturnFailure):
-
-2008-11-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Made a bunch of WREC::Parser functions private, and added an explicit
- "reset()" function, so a parser can be reused.
-
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::Parser):
- (JSC::WREC::Parser::generator):
- (JSC::WREC::Parser::ignoreCase):
- (JSC::WREC::Parser::multiline):
- (JSC::WREC::Parser::recordSubpattern):
- (JSC::WREC::Parser::numSubpatterns):
- (JSC::WREC::Parser::parsePattern):
- (JSC::WREC::Parser::parseAlternative):
- (JSC::WREC::Parser::reset):
-
-2008-11-24 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Implement repatching for get by id chain.
- Previously the access is performed in a function stub, in the repatch form
- the trampoline is not called to; instead the hot path is relinked to jump
- directly to the trampoline, if it fails it will jump to the slow case.
-
- https://bugs.webkit.org/show_bug.cgi?id=22449
- 3% progression on deltablue.
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
-
-2008-11-24 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=20746
-
- Various small compilation fixes to make the Qt port of WebKit
- compile on Windows CE.
-
- * config.h: Don't set _CRT_RAND_S for CE, it's not available.
- * jsc.cpp: Disabled use of debugger includes for CE. It
- does not have the debugging functions.
- * runtime/DateMath.cpp: Use localtime() on Windows CE.
- * wtf/Assertions.cpp: Compile on Windows CE without debugger.
- * wtf/Assertions.h: Include windows.h before defining ASSERT.
- * wtf/MathExtras.h: Include stdlib.h instead of xmath.h.
- * wtf/Platform.h: Disable ERRNO_H and detect endianess based
- on the Qt endianess. On Qt for Windows CE the endianess is
- defined by the vendor specific build spec.
- * wtf/Threading.h: Use the volatile-less atomic functions.
- * wtf/dtoa.cpp: Compile without errno.
- * wtf/win/MainThreadWin.cpp: Don't include windows.h on CE after
- Assertions.h due to the redefinition of ASSERT.
-
-2008-11-22 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Replace accidentally deleted immediate check from get by id chain trampoline.
- https://bugs.webkit.org/show_bug.cgi?id=22413
-
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileGetByIdChain):
-
-2008-11-21 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Add (really) polymorphic caching for get by id self.
- Very similar to caching of prototype accesses, described below.
-
- Oh, also, probably shouldn't have been leaking those structure list objects.
-
- 4% preogression on deltablue.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::derefStructures):
- (JSC::PrototypeStructureList::derefStructures):
- * bytecode/Instruction.h:
- * bytecode/Opcode.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileGetByIdSelfList):
- (JSC::JIT::patchGetByIdSelf):
- * jit/JIT.h:
- (JSC::JIT::compileGetByIdSelfList):
-
-2008-11-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed many crashes seen 'round the world (but only in release builds).
-
- Update outputParameter offset to reflect slight re-ordering of push
- instructions in r38669.
-
- * wrec/WRECGenerator.cpp:
-
-2008-11-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A little more RegExp refactoring.
-
- Deployed a helper function for reading the next character. Used the "link
- vector of jumps" helper in a place I missed before.
-
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateLoadCharacter):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- * wrec/WRECGenerator.h:
-
-2008-11-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22402
- Replace abort() with CRASH()
-
- * wtf/Assertions.h: Added a different method to crash, which should work even is 0xbbadbeef
- is a valid memory address.
-
- * runtime/Collector.cpp:
- * wtf/FastMalloc.cpp:
- * wtf/FastMalloc.h:
- * wtf/TCSpinLock.h:
- Replace abort() with CRASH().
-
-2008-11-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reverted fix for bug 22042 (Replace abort() with CRASH()), because it was breaking
- FOR_EACH_OPCODE_ID macro somehow, making Safari crash.
-
- * runtime/Collector.cpp:
- (JSC::Heap::heapAllocate):
- (JSC::Heap::collect):
- * wtf/Assertions.h:
- * wtf/FastMalloc.cpp:
- (WTF::fastMalloc):
- (WTF::fastCalloc):
- (WTF::fastRealloc):
- (WTF::InitSizeClasses):
- (WTF::PageHeapAllocator::New):
- (WTF::TCMallocStats::do_malloc):
- * wtf/FastMalloc.h:
- * wtf/TCSpinLock.h:
- (TCMalloc_SpinLock::Init):
- (TCMalloc_SpinLock::Finalize):
- (TCMalloc_SpinLock::Lock):
- (TCMalloc_SpinLock::Unlock):
-
-2008-11-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A little more RegExp refactoring.
-
- Moved all assembly from WREC.cpp into WRECGenerator helper functions.
- This should help with portability and readability.
-
- Removed ASSERTs after calls to executableCopy(), and changed
- executableCopy() to ASSERT instead.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::executableCopy):
- * jit/JIT.cpp:
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateEnter):
- (JSC::WREC::Generator::generateReturnSuccess):
- (JSC::WREC::Generator::generateSaveIndex):
- (JSC::WREC::Generator::generateIncrementIndex):
- (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
- (JSC::WREC::Generator::generateReturnFailure):
- * wrec/WRECGenerator.h:
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::ignoreCase):
- (JSC::WREC::Parser::generator):
-
-2008-11-21 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix.
-
- * wtf/Assertions.h: Use ::abort for C++ code.
-
-2008-11-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22402
- Replace abort() with CRASH()
-
- * wtf/Assertions.h: Added abort() after an attempt to crash for extra safety.
-
- * runtime/Collector.cpp:
- * wtf/FastMalloc.cpp:
- * wtf/FastMalloc.h:
- * wtf/TCSpinLock.h:
- Replace abort() with CRASH().
-
-2008-11-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed wrec => generator.
-
- * wrec/WRECFunctors.cpp:
- (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom):
- (JSC::WREC::GeneratePatternCharacterFunctor::backtrack):
- (JSC::WREC::GenerateCharacterClassFunctor::generateAtom):
- (JSC::WREC::GenerateCharacterClassFunctor::backtrack):
- (JSC::WREC::GenerateBackreferenceFunctor::generateAtom):
- (JSC::WREC::GenerateBackreferenceFunctor::backtrack):
- (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
-
-2008-11-19 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Darin Adler.
-
- Add support for (really) polymorphic caching of prototype accesses.
-
- If a cached prototype access misses, cti_op_get_by_id_proto_list is called.
- When this occurs the Structure pointers from the instruction stream are copied
- off into a new ProtoStubInfo object. A second prototype access trampoline is
- generated, and chained onto the first. Subsequent missed call to
- cti_op_get_by_id_proto_list_append, which append futher new trampolines, up to
- PROTOTYPE_LIST_CACHE_SIZE (currently 4). If any of the misses result in an
- access other than to a direct prototype property, list formation is halted (or
- for the initial miss, does not take place at all).
-
- Separate fail case functions are provided for each access since this contributes
- to the performance progression (enables better processor branch prediction).
-
- Overall this is a near 5% progression on v8, with around 10% wins on richards
- and deltablue.
-
- * bytecode/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::derefStructures):
- * bytecode/Instruction.h:
- (JSC::ProtoStructureList::ProtoStubInfo::set):
- (JSC::ProtoStructureList::ProtoStructureList):
- (JSC::Instruction::Instruction):
- (JSC::Instruction::):
- * bytecode/Opcode.h:
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id_self_fail):
- (JSC::Interpreter::cti_op_get_by_id_proto_list):
- (JSC::Interpreter::cti_op_get_by_id_proto_list_append):
- (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
- (JSC::Interpreter::cti_op_get_by_id_proto_fail):
- (JSC::Interpreter::cti_op_get_by_id_chain_fail):
- (JSC::Interpreter::cti_op_get_by_id_array_fail):
- (JSC::Interpreter::cti_op_get_by_id_string_fail):
- * interpreter/Interpreter.h:
- * jit/JIT.cpp:
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdProtoList):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * jit/JIT.h:
- (JSC::JIT::compileGetByIdProtoList):
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Try and fix the tiger build.
-
- * parser/Grammar.y:
-
-2008-11-20 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Make JavaScriptCore Chromium build under Windows (cmd only, cygwin almost works)
- https://bugs.webkit.org/show_bug.cgi?id=22347
-
- * JavaScriptCore.scons:
- * parser/Parser.cpp: Add using std::auto_ptr since we use auto_ptr
-
-2008-11-20 Steve Falkenburg <sfalken@apple.com>
-
- Fix build.
-
- Reviewed by Sam Weinig.
-
- * parser/Parser.cpp:
- (JSC::Parser::reparse):
-
-2008-11-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A little more RegExp refactoring.
-
- Created a helper function in the assembler for linking a vector of
- JmpSrc to a location, and deployed it in a bunch of places.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::link):
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateParentheses):
- (JSC::WREC::Generator::generateParenthesesResetTrampoline):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::terminateAlternative):
- (JSC::WREC::Generator::terminateDisjunction):
- * wrec/WRECParser.cpp:
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::consumeHex):
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Fix non-mac builds.
-
- * parser/Lexer.cpp:
- * parser/Parser.cpp:
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=22385
- <rdar://problem/6390179>
- Lazily reparse FunctionBodyNodes on first execution.
-
- - Saves 57MB on Membuster head.
-
- * bytecompiler/BytecodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate): Remove vector shrinking since this is now
- handled by destroying the ScopeNodeData after generation.
-
- * parser/Grammar.y: Add alternate NoNode version of the grammar
- that does not create nodes. This is used to lazily create FunctionBodyNodes
- on first execution.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::setCode): Fix bug where on reparse, the Lexer was confused about
- what position and length meant. Position is the current position in the original
- data buffer (important for getting correct line/column information) and length
- the end offset in the original buffer.
- * parser/Lexer.h:
- (JSC::Lexer::sourceCode): Positions are relative to the beginning of the buffer.
-
- * parser/Nodes.cpp:
- (JSC::ScopeNodeData::ScopeNodeData): Move initialization of ScopeNode data here.
- (JSC::ScopeNode::ScopeNode): Add constructor that only sets the JSGlobalData
- for FunctionBodyNode stubs.
- (JSC::ScopeNode::~ScopeNode): Release m_children now that we don't inherit from
- BlockNode.
- (JSC::ScopeNode::releaseNodes): Ditto.
- (JSC::EvalNode::generateBytecode): Only shrink m_children, as we need to keep around
- the rest of the data.
- (JSC::FunctionBodyNode::FunctionBodyNode): Add constructor that only sets the
- JSGlobalData.
- (JSC::FunctionBodyNode::create): Ditto.
- (JSC::FunctionBodyNode::generateBytecode): If we don't have the data, do a reparse
- to construct it. Then after generation, destroy the data.
- (JSC::ProgramNode::generateBytecode): After generation, destroy the AST data.
- * parser/Nodes.h:
- (JSC::ExpressionNode::): Add isFuncExprNode for FunctionConstructor.
- (JSC::StatementNode::): Add isExprStatementNode for FunctionConstructor.
- (JSC::ExprStatementNode::): Ditto.
- (JSC::ExprStatementNode::expr): Add accessor for FunctionConstructor.
- (JSC::FuncExprNode::): Add isFuncExprNode for FunctionConstructor
-
- (JSC::ScopeNode::adoptData): Adopts a ScopeNodeData.
- (JSC::ScopeNode::data): Accessor for ScopeNodeData.
- (JSC::ScopeNode::destroyData): Deletes the ScopeNodeData.
- (JSC::ScopeNode::setFeatures): Added.
- (JSC::ScopeNode::varStack): Added assert.
- (JSC::ScopeNode::functionStack): Ditto.
- (JSC::ScopeNode::children): Ditto.
- (JSC::ScopeNode::neededConstants): Ditto.
- Factor m_varStack, m_functionStack, m_children and m_numConstants into ScopeNodeData.
-
- * parser/Parser.cpp:
- (JSC::Parser::reparse): Reparse the SourceCode in the FunctionBodyNode and set
- set up the ScopeNodeData for it.
- * parser/Parser.h:
-
- * parser/SourceCode.h:
- (JSC::SourceCode::endOffset): Added for use in the lexer.
-
- * runtime/FunctionConstructor.cpp:
- (JSC::getFunctionBody): Assuming a ProgramNode with one FunctionExpression in it,
- get the FunctionBodyNode. Any issues signifies a parse failure in constructFunction.
- (JSC::constructFunction): Make parsing functions in the form new Function(""), easier
- by concatenating the strings together (with some glue) and parsing the function expression
- as a ProgramNode from which we can receive the FunctionBodyNode. This has the added benefit
- of not having special parsing code for the arguments and lazily constructing the
- FunctionBodyNode's AST on first execution.
-
- * runtime/Identifier.h:
- (JSC::operator!=): Added.
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Speedup the lexer to offset coming re-parsing patch.
-
- - .6% progression on Sunspider.
-
- * bytecompiler/SegmentedVector.h:
- (JSC::SegmentedVector::shrink): Fixed bug where m_size would not be
- set when shrinking to 0.
-
- * parser/Lexer.cpp:
- (JSC::Lexer::Lexer):
- (JSC::Lexer::isIdentStart): Use isASCIIAlpha and isASCII to avoid going into ICU in the common cases.
- (JSC::Lexer::isIdentPart): Use isASCIIAlphanumeric and isASCII to avoid going into ICU in the common cases
- (JSC::isDecimalDigit): Use version in ASCIICType.h. Inlining it was a regression.
- (JSC::Lexer::isHexDigit): Ditto.
- (JSC::Lexer::isOctalDigit): Ditto.
- (JSC::Lexer::clear): Resize the m_identifiers SegmentedVector to initial
- capacity
- * parser/Lexer.h: Remove unused m_strings vector. Make m_identifiers
- a SegmentedVector<Identifier> to avoid allocating a new Identifier* for
- each identifier found. The SegmentedVector is need so we can passes
- references to the Identifier to the parser, which remain valid even when
- the vector is resized.
- (JSC::Lexer::makeIdentifier): Inline and return a reference to the added
- Identifier.
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Add isASCII to ASCIICType. Use coming soon!
-
- * wtf/ASCIICType.h:
- (WTF::isASCII):
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Add OwnPtr constructor and OwnPtr::adopt that take an auto_ptr.
-
- * wtf/OwnPtr.h:
- (WTF::OwnPtr::OwnPtr):
- (WTF::OwnPtr::adopt):
-
-2008-11-20 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22364
- Crashes seen on Tiger buildbots due to worker threads exhausting pthread keys
-
- * runtime/Collector.cpp:
- (JSC::Heap::Heap):
- (JSC::Heap::destroy):
- (JSC::Heap::makeUsableFromMultipleThreads):
- (JSC::Heap::registerThread):
- * runtime/Collector.h:
- Pthread key for tracking threads is only created on request now, because this is a limited
- resource, and thread tracking is not needed for worker heaps, or for WebCore heap.
-
- * API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): Call makeUsableFromMultipleThreads().
-
- * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::sharedInstance): Ditto.
-
- * runtime/JSGlobalData.h: (JSC::JSGlobalData::makeUsableFromMultipleThreads): Just forward
- the call to Heap, which clients need not know about, ideally.
-
-2008-11-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A little more WREC refactoring.
-
- Removed the "Register" suffix from register names in WREC, and renamed:
- currentPosition => index
- currentValue => character
- quantifierCount => repeatCount
-
- Added a top-level parsePattern function to the WREC parser, which
- allowed me to remove the error() and atEndOfPattern() accessors.
-
- Factored out an MSVC customization into a constant.
-
- Renamed nextLabel => beginPattern.
-
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateBacktrack1):
- (JSC::WREC::Generator::generateBacktrackBackreference):
- (JSC::WREC::Generator::generateBackreferenceQuantifier):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateParentheses):
- (JSC::WREC::Generator::generateParenthesesResetTrampoline):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::generateBackreference):
- (JSC::WREC::Generator::generateDisjunction):
- (JSC::WREC::Generator::terminateDisjunction):
- * wrec/WRECGenerator.h:
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::parsePattern):
-
-2008-11-19 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22361
- A little more RegExp refactoring.
-
- Consistently named variables holding the starting position at which
- regexp matching should begin to "startOffset".
-
- A few more "regExpObject" => "regExpConstructor" changes.
-
- Refactored RegExpObject::match for clarity, and replaced a slow "get"
- of the "global" property with a fast access to the global bit.
-
- Made the error message you see when RegExpObject::match has no input a
- little more informative, as in Firefox.
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::match):
- * runtime/RegExp.h:
- * runtime/RegExpObject.cpp:
- (JSC::RegExpObject::match):
- * runtime/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
-
-2008-11-19 Geoffrey Garen <ggaren@apple.com>
+ (JSC::CodeBlock::createRareDataIfNecessary):
+ More assertions.
- Reviewed by Sam Weinig.
-
- A little more refactoring.
-
- Removed the "emit" and "emitUnlinked" prefixes from the assembler.
-
- Moved the JmpSrc and JmpDst class definitions to the top of the X86
- assembler class, in accordance with WebKit style guidelines.
-
- * assembler/X86Assembler.h:
- (JSC::X86Assembler::JmpSrc::JmpSrc):
- (JSC::X86Assembler::JmpDst::JmpDst):
- (JSC::X86Assembler::int3):
- (JSC::X86Assembler::pushl_m):
- (JSC::X86Assembler::popl_m):
- (JSC::X86Assembler::movl_rr):
- (JSC::X86Assembler::addl_rr):
- (JSC::X86Assembler::addl_i8r):
- (JSC::X86Assembler::addl_i8m):
- (JSC::X86Assembler::addl_i32r):
- (JSC::X86Assembler::addl_mr):
- (JSC::X86Assembler::andl_rr):
- (JSC::X86Assembler::andl_i32r):
- (JSC::X86Assembler::cmpl_i8r):
- (JSC::X86Assembler::cmpl_rr):
- (JSC::X86Assembler::cmpl_rm):
- (JSC::X86Assembler::cmpl_mr):
- (JSC::X86Assembler::cmpl_i32r):
- (JSC::X86Assembler::cmpl_i32m):
- (JSC::X86Assembler::cmpl_i8m):
- (JSC::X86Assembler::cmpw_rm):
- (JSC::X86Assembler::orl_rr):
- (JSC::X86Assembler::orl_mr):
- (JSC::X86Assembler::orl_i32r):
- (JSC::X86Assembler::subl_rr):
- (JSC::X86Assembler::subl_i8r):
- (JSC::X86Assembler::subl_i8m):
- (JSC::X86Assembler::subl_i32r):
- (JSC::X86Assembler::subl_mr):
- (JSC::X86Assembler::testl_i32r):
- (JSC::X86Assembler::testl_i32m):
- (JSC::X86Assembler::testl_rr):
- (JSC::X86Assembler::xorl_i8r):
- (JSC::X86Assembler::xorl_rr):
- (JSC::X86Assembler::sarl_i8r):
- (JSC::X86Assembler::sarl_CLr):
- (JSC::X86Assembler::shl_i8r):
- (JSC::X86Assembler::shll_CLr):
- (JSC::X86Assembler::imull_rr):
- (JSC::X86Assembler::imull_i32r):
- (JSC::X86Assembler::idivl_r):
- (JSC::X86Assembler::negl_r):
- (JSC::X86Assembler::movl_mr):
- (JSC::X86Assembler::movzbl_rr):
- (JSC::X86Assembler::movzwl_mr):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::movl_i32r):
- (JSC::X86Assembler::movl_i32m):
- (JSC::X86Assembler::leal_mr):
- (JSC::X86Assembler::jmp_r):
- (JSC::X86Assembler::jmp_m):
- (JSC::X86Assembler::movsd_mr):
- (JSC::X86Assembler::xorpd_mr):
- (JSC::X86Assembler::movsd_rm):
- (JSC::X86Assembler::movd_rr):
- (JSC::X86Assembler::cvtsi2sd_rr):
- (JSC::X86Assembler::cvttsd2si_rr):
- (JSC::X86Assembler::addsd_mr):
- (JSC::X86Assembler::subsd_mr):
- (JSC::X86Assembler::mulsd_mr):
- (JSC::X86Assembler::addsd_rr):
- (JSC::X86Assembler::subsd_rr):
- (JSC::X86Assembler::mulsd_rr):
- (JSC::X86Assembler::ucomis_rr):
- (JSC::X86Assembler::pextrw_irr):
- (JSC::X86Assembler::call):
- (JSC::X86Assembler::jmp):
- (JSC::X86Assembler::jne):
- (JSC::X86Assembler::jnz):
- (JSC::X86Assembler::je):
- (JSC::X86Assembler::jl):
- (JSC::X86Assembler::jb):
- (JSC::X86Assembler::jle):
- (JSC::X86Assembler::jbe):
- (JSC::X86Assembler::jge):
- (JSC::X86Assembler::jg):
- (JSC::X86Assembler::ja):
- (JSC::X86Assembler::jae):
- (JSC::X86Assembler::jo):
- (JSC::X86Assembler::jp):
- (JSC::X86Assembler::js):
- (JSC::X86Assembler::predictNotTaken):
- (JSC::X86Assembler::convertToFastCall):
- (JSC::X86Assembler::restoreArgumentReference):
- (JSC::X86Assembler::restoreArgumentReferenceForTrampoline):
- (JSC::X86Assembler::modRm_rr):
- (JSC::X86Assembler::modRm_rr_Unchecked):
- (JSC::X86Assembler::modRm_rm):
- (JSC::X86Assembler::modRm_rm_Unchecked):
- (JSC::X86Assembler::modRm_rmsib):
- (JSC::X86Assembler::modRm_opr):
- (JSC::X86Assembler::modRm_opr_Unchecked):
- (JSC::X86Assembler::modRm_opm):
- (JSC::X86Assembler::modRm_opm_Unchecked):
- (JSC::X86Assembler::modRm_opmsib):
* jit/JIT.cpp:
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::emitNakedFastCall):
- (JSC::JIT::emitCTICall):
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithIntToImmOrSlowCase):
- (JSC::JIT::emitArithIntToImmWithJump):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- (JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileCTIMachineTrampolines):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECGenerator.cpp:
- (JSC::WREC::Generator::generateBackreferenceQuantifier):
- (JSC::WREC::Generator::generateNonGreedyQuantifier):
- (JSC::WREC::Generator::generateGreedyQuantifier):
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateParentheses):
- (JSC::WREC::Generator::generateParenthesesNonGreedy):
- (JSC::WREC::Generator::generateParenthesesResetTrampoline):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- (JSC::WREC::Generator::generateBackreference):
- (JSC::WREC::Generator::generateDisjunction):
-
-2008-11-19 Simon Hausmann <hausmann@webkit.org>
-
- Sun CC build fix, removed trailing comman for last enum value.
-
- * wtf/unicode/qt4/UnicodeQt4.h:
- (WTF::Unicode::):
-
-2008-11-19 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Expand the workaround for Apple GCC compiler bug <rdar://problem/6354696> to all versions of GCC 4.0.1.
- It has been observed with builds 5465 (Xcode 3.0) and 5484 (Xcode 3.1), and there is no evidence
- that it has been fixed in newer builds of GCC 4.0.1.
-
- This addresses <https://bugs.webkit.org/show_bug.cgi?id=22351> (WebKit nightly crashes on launch on 10.4.11).
-
- * wtf/StdLibExtras.h:
-
-2008-11-18 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak and Geoff Garen.
-
- Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
- <https://bugs.webkit.org/show_bug.cgi?id=22287>
-
- Fix a typo in the number cell reuse code where the first and second
- operands are sometimes confused.
-
- * jit/JIT.cpp:
- (JSC::JIT::compileBinaryArithOpSlowCase):
-
-2008-11-18 Dan Bernstein <mitz@apple.com>
-
- - try to fix the Windows build
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
-
-2008-11-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Minor RegExp cleanup.
-
- SunSpider says no change.
-
- * runtime/RegExpObject.cpp:
- (JSC::RegExpObject::match): Renamed "regExpObj" to "regExpConstructor".
-
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp): Instead of checking for a NULL output vector,
- ASSERT that the output vector is not NULL. (The rest of WREC is not
- safe to use with a NULL output vector, and we probably don't want to
- spend the time and/or performance to make it safe.)
-
-2008-11-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- A little more renaming and refactoring.
-
- VM_CHECK_EXCEPTION() => CHECK_FOR_EXCEPTION().
- NEXT_INSTRUCTION => NEXT_INSTRUCTION().
-
- Removed the "Error_" and "TempError_" prefixes from WREC error types.
-
- Refactored the WREC parser so it doesn't need a "setError" function,
- and changed "isEndOfPattern" and its use -- they read kind of backwards
- before.
-
- Changed our "TODO:" error messages at least to say something, since you
- can't say "TODO:" in shipping software.
-
- * interpreter/Interpreter.cpp:
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_op_loop_if_less):
- (JSC::Interpreter::cti_op_loop_if_lesseq):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_lesseq):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_jless):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_less):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_push_scope):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_del_by_val):
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WRECParser.cpp:
- (JSC::WREC::Parser::parseGreedyQuantifier):
- (JSC::WREC::Parser::parseParentheses):
- (JSC::WREC::Parser::parseCharacterClass):
- (JSC::WREC::Parser::parseEscape):
- * wrec/WRECParser.h:
- (JSC::WREC::Parser::):
- (JSC::WREC::Parser::atEndOfPattern):
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22337
- Enable workers by default
-
- * Configurations/JavaScriptCore.xcconfig: Define ENABLE_WORKERS.
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- - Windows build fix
-
- * wrec/WRECFunctors.h:
- * wrec/WRECGenerator.h:
- * wrec/WRECParser.h:
- CharacterClass is a struct, not a class, fix forward declarations.
-
-2008-11-18 Dan Bernstein <mitz@apple.com>
-
- - Windows build fix
-
- * assembler/X86Assembler.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * wrec/Quantifier.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * assembler/AssemblerBuffer.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Split WREC classes out into individual files, with a few modifications
- to more closely match the WebKit coding style.
-
- * GNUmakefile.am:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler/X86Assembler.h:
- * runtime/RegExp.cpp:
- * wrec/CharacterClass.cpp: Copied from wrec/CharacterClassConstructor.cpp.
- (JSC::WREC::CharacterClass::newline):
- (JSC::WREC::CharacterClass::digits):
- (JSC::WREC::CharacterClass::spaces):
- (JSC::WREC::CharacterClass::wordchar):
- (JSC::WREC::CharacterClass::nondigits):
- (JSC::WREC::CharacterClass::nonspaces):
- (JSC::WREC::CharacterClass::nonwordchar):
- * wrec/CharacterClass.h: Copied from wrec/CharacterClassConstructor.h.
- * wrec/CharacterClassConstructor.cpp:
- (JSC::WREC::CharacterClassConstructor::addSortedRange):
- (JSC::WREC::CharacterClassConstructor::append):
- * wrec/CharacterClassConstructor.h:
- * wrec/Quantifier.h: Copied from wrec/WREC.h.
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WREC.h:
- * wrec/WRECFunctors.cpp: Copied from wrec/WREC.cpp.
- * wrec/WRECFunctors.h: Copied from wrec/WREC.cpp.
- (JSC::WREC::GenerateAtomFunctor::~GenerateAtomFunctor):
- (JSC::WREC::GeneratePatternCharacterFunctor::GeneratePatternCharacterFunctor):
- (JSC::WREC::GenerateCharacterClassFunctor::GenerateCharacterClassFunctor):
- (JSC::WREC::GenerateBackreferenceFunctor::GenerateBackreferenceFunctor):
- (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
- * wrec/WRECGenerator.cpp: Copied from wrec/WREC.cpp.
- (JSC::WREC::Generator::generatePatternCharacter):
- (JSC::WREC::Generator::generateCharacterClassInvertedRange):
- (JSC::WREC::Generator::generateCharacterClassInverted):
- (JSC::WREC::Generator::generateCharacterClass):
- (JSC::WREC::Generator::generateParentheses):
- (JSC::WREC::Generator::generateAssertionBOL):
- (JSC::WREC::Generator::generateAssertionEOL):
- (JSC::WREC::Generator::generateAssertionWordBoundary):
- * wrec/WRECGenerator.h: Copied from wrec/WREC.h.
- * wrec/WRECParser.cpp: Copied from wrec/WREC.cpp.
- (JSC::WREC::Parser::parseGreedyQuantifier):
- (JSC::WREC::Parser::parseCharacterClassQuantifier):
- (JSC::WREC::Parser::parseParentheses):
- (JSC::WREC::Parser::parseCharacterClass):
- (JSC::WREC::Parser::parseEscape):
- (JSC::WREC::Parser::parseTerm):
- * wrec/WRECParser.h: Copied from wrec/WREC.h.
- (JSC::WREC::Parser::):
- (JSC::WREC::Parser::Parser):
- (JSC::WREC::Parser::setError):
- (JSC::WREC::Parser::error):
- (JSC::WREC::Parser::recordSubpattern):
- (JSC::WREC::Parser::numSubpatterns):
- (JSC::WREC::Parser::ignoreCase):
- (JSC::WREC::Parser::multiline):
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix a few builds.
-
- * JavaScriptCoreSources.bkl:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix a few builds.
-
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/CTI.* => jit/JIT.*.
-
- Removed VM.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp: Removed.
- * VM/CTI.h: Removed.
- * bytecode/CodeBlock.cpp:
- * interpreter/Interpreter.cpp:
- * jit: Added.
- * jit/JIT.cpp: Copied from VM/CTI.cpp.
- * jit/JIT.h: Copied from VM/CTI.h.
- * runtime/RegExp.cpp:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved runtime/ExecState.* => interpreter/CallFrame.*.
-
- * API/JSBase.cpp:
- * API/OpaqueJSString.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * debugger/DebuggerCallFrame.h:
- * interpreter/CallFrame.cpp: Copied from runtime/ExecState.cpp.
- * interpreter/CallFrame.h: Copied from runtime/ExecState.h.
- * interpreter/Interpreter.cpp:
- * parser/Nodes.cpp:
- * profiler/ProfileGenerator.cpp:
- * profiler/Profiler.cpp:
- * runtime/ClassInfo.h:
- * runtime/Collector.cpp:
- * runtime/Completion.cpp:
- * runtime/ExceptionHelpers.cpp:
- * runtime/ExecState.cpp: Removed.
- * runtime/ExecState.h: Removed.
- * runtime/Identifier.cpp:
- * runtime/JSFunction.cpp:
- * runtime/JSGlobalObjectFunctions.cpp:
- * runtime/JSLock.cpp:
- * runtime/JSNumberCell.h:
- * runtime/JSObject.h:
- * runtime/JSString.h:
- * runtime/Lookup.h:
- * runtime/PropertyNameArray.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * API/APICast.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * API/APICast.h:
- * runtime/ExecState.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/SamplingTool.* => bytecode/SamplingTool.*.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/SamplingTool.cpp: Removed.
- * VM/SamplingTool.h: Removed.
- * bytecode/SamplingTool.cpp: Copied from VM/SamplingTool.cpp.
- * bytecode/SamplingTool.h: Copied from VM/SamplingTool.h.
- * jsc.cpp:
- (runWithScripts):
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * runtime/ExecState.h:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/ExceptionHelpers.cpp => runtime/ExceptionHelpers.cpp.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/ExceptionHelpers.cpp: Removed.
- * runtime/ExceptionHelpers.cpp: Copied from VM/ExceptionHelpers.cpp.
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/RegisterFile.cpp => interpreter/RegisterFile.cpp.
-
- * AllInOneFile.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/RegisterFile.cpp: Removed.
- * interpreter/RegisterFile.cpp: Copied from VM/RegisterFile.cpp.
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved:
- VM/ExceptionHelpers.h => runtime/ExceptionHelpers.h
- VM/Register.h => interpreter/Register.h
- VM/RegisterFile.h => interpreter/RegisterFile.h
-
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/ExceptionHelpers.h: Removed.
- * VM/Register.h: Removed.
- * VM/RegisterFile.h: Removed.
- * interpreter/Register.h: Copied from VM/Register.h.
- * interpreter/RegisterFile.h: Copied from VM/RegisterFile.h.
- * runtime/ExceptionHelpers.h: Copied from VM/ExceptionHelpers.h.
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * JavaScriptCore.pri:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/Machine.cpp => interpreter/Interpreter.cpp.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/Machine.cpp: Removed.
- * interpreter/Interpreter.cpp: Copied from VM/Machine.cpp.
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved VM/Machine.h => interpreter/Interpreter.h
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/ExceptionHelpers.cpp:
- * VM/Machine.cpp:
- * VM/Machine.h: Removed.
- * VM/SamplingTool.cpp:
- * bytecode/CodeBlock.cpp:
- * bytecompiler/BytecodeGenerator.cpp:
- * bytecompiler/BytecodeGenerator.h:
- * debugger/DebuggerCallFrame.cpp:
- * interpreter: Added.
- * interpreter/Interpreter.h: Copied from VM/Machine.h.
- * profiler/ProfileGenerator.cpp:
- * runtime/Arguments.h:
- * runtime/ArrayPrototype.cpp:
- * runtime/Collector.cpp:
- * runtime/Completion.cpp:
- * runtime/ExecState.h:
- * runtime/FunctionPrototype.cpp:
- * runtime/JSActivation.cpp:
- * runtime/JSFunction.cpp:
- * runtime/JSGlobalData.cpp:
- * runtime/JSGlobalObject.cpp:
- * runtime/JSGlobalObjectFunctions.cpp:
- * wrec/WREC.cpp:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved runtime/Interpreter.cpp => runtime/Completion.cpp.
-
- Moved functions from Interpreter.h to Completion.h, and removed
- Interpreter.h from the project.
-
- * API/JSBase.cpp:
- * AllInOneFile.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * jsc.cpp:
- * runtime/Completion.cpp: Copied from runtime/Interpreter.cpp.
- * runtime/Completion.h:
- * runtime/Interpreter.cpp: Removed.
- * runtime/Interpreter.h: Removed.
-
-2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- <https://bugs.webkit.org/show_bug.cgi?id=22312>
- Fix PCRE include path problem on Qt-port
-
- * JavaScriptCore.pri:
- * pcre/pcre.pri:
-
-2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- <https://bugs.webkit.org/show_bug.cgi?id=22313>
- Add missing CTI source to the build system on Qt-port
-
- * JavaScriptCore.pri:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix JSGlue build.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * jsc.pro:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * JavaScriptCore.pri:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * JavaScriptCore.pri:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- More file moves:
-
- VM/CodeBlock.* => bytecode/CodeBlock.*
- VM/EvalCodeCache.h => bytecode/EvalCodeCache.h
- VM/Instruction.h => bytecode/Instruction.h
- VM/Opcode.* => bytecode/Opcode.*
-
- * GNUmakefile.am:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/CodeBlock.cpp: Removed.
- * VM/CodeBlock.h: Removed.
- * VM/EvalCodeCache.h: Removed.
- * VM/Instruction.h: Removed.
- * VM/Opcode.cpp: Removed.
- * VM/Opcode.h: Removed.
- * bytecode: Added.
- * bytecode/CodeBlock.cpp: Copied from VM/CodeBlock.cpp.
- * bytecode/CodeBlock.h: Copied from VM/CodeBlock.h.
- * bytecode/EvalCodeCache.h: Copied from VM/EvalCodeCache.h.
- * bytecode/Instruction.h: Copied from VM/Instruction.h.
- * bytecode/Opcode.cpp: Copied from VM/Opcode.cpp.
- * bytecode/Opcode.h: Copied from VM/Opcode.h.
- * jsc.pro:
- * jscore.bkl:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix a few more builds.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCoreSources.bkl:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * GNUmakefile.am:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Some file moves:
-
- VM/LabelID.h => bytecompiler/Label.h
- VM/RegisterID.h => bytecompiler/RegisterID.h
- VM/SegmentedVector.h => bytecompiler/SegmentedVector.h
- bytecompiler/CodeGenerator.* => bytecompiler/BytecodeGenerator.*
-
- * AllInOneFile.cpp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/LabelID.h: Removed.
- * VM/RegisterID.h: Removed.
- * VM/SegmentedVector.h: Removed.
- * bytecompiler/BytecodeGenerator.cpp: Copied from bytecompiler/CodeGenerator.cpp.
- * bytecompiler/BytecodeGenerator.h: Copied from bytecompiler/CodeGenerator.h.
- * bytecompiler/CodeGenerator.cpp: Removed.
- * bytecompiler/CodeGenerator.h: Removed.
- * bytecompiler/Label.h: Copied from VM/LabelID.h.
- * bytecompiler/LabelScope.h:
- * bytecompiler/RegisterID.h: Copied from VM/RegisterID.h.
- * bytecompiler/SegmentedVector.h: Copied from VM/SegmentedVector.h.
- * jsc.cpp:
- * parser/Nodes.cpp:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved masm => assembler and split "AssemblerBuffer.h" out of "X86Assembler.h".
-
- Also renamed ENABLE_MASM to ENABLE_ASSEMBLER.
-
- * GNUmakefile.am:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * assembler: Added.
- * assembler/AssemblerBuffer.h: Copied from masm/X86Assembler.h.
- (JSC::AssemblerBuffer::AssemblerBuffer):
- (JSC::AssemblerBuffer::~AssemblerBuffer):
- (JSC::AssemblerBuffer::ensureSpace):
- (JSC::AssemblerBuffer::isAligned):
- (JSC::AssemblerBuffer::putByteUnchecked):
- (JSC::AssemblerBuffer::putByte):
- (JSC::AssemblerBuffer::putShortUnchecked):
- (JSC::AssemblerBuffer::putShort):
- (JSC::AssemblerBuffer::putIntUnchecked):
- (JSC::AssemblerBuffer::putInt):
- (JSC::AssemblerBuffer::data):
- (JSC::AssemblerBuffer::size):
- (JSC::AssemblerBuffer::reset):
- (JSC::AssemblerBuffer::executableCopy):
- (JSC::AssemblerBuffer::grow):
- * assembler/X86Assembler.h: Copied from masm/X86Assembler.h.
- * masm: Removed.
- * masm/X86Assembler.h: Removed.
- * wtf/Platform.h:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * GNUmakefile.am:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Fixed tyop.
-
- * VM/CTI.cpp:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix windows build.
-
- * VM/CTI.cpp:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * GNUmakefile.am:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed ENABLE_CTI and ENABLE(CTI) to ENABLE_JIT and ENABLE(JIT).
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::~CodeBlock):
- * VM/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- * VM/Machine.cpp:
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::initialize):
- (JSC::Interpreter::~Interpreter):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::privateExecute):
- * VM/Machine.h:
- * bytecompiler/CodeGenerator.cpp:
- (JSC::prepareJumpTableForStringSwitch):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::~JSFunction):
- * runtime/JSGlobalData.h:
- * wrec/WREC.h:
- * wtf/Platform.h:
- * wtf/TCSystemAlloc.cpp:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix gtk build.
-
- * VM/CTI.cpp:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by a few people on squirrelfish-dev.
-
- Renamed CTI => JIT.
-
- * VM/CTI.cpp:
- (JSC::JIT::killLastResultRegister):
- (JSC::JIT::emitGetVirtualRegister):
- (JSC::JIT::emitGetVirtualRegisters):
- (JSC::JIT::emitPutCTIArgFromVirtualRegister):
- (JSC::JIT::emitPutCTIArg):
- (JSC::JIT::emitGetCTIArg):
- (JSC::JIT::emitPutCTIArgConstant):
- (JSC::JIT::getConstantImmediateNumericArg):
- (JSC::JIT::emitPutCTIParam):
- (JSC::JIT::emitGetCTIParam):
- (JSC::JIT::emitPutToCallFrameHeader):
- (JSC::JIT::emitGetFromCallFrameHeader):
- (JSC::JIT::emitPutVirtualRegister):
- (JSC::JIT::emitInitRegister):
- (JSC::JIT::printBytecodeOperandTypes):
- (JSC::JIT::emitAllocateNumber):
- (JSC::JIT::emitNakedCall):
- (JSC::JIT::emitNakedFastCall):
- (JSC::JIT::emitCTICall):
- (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- (JSC::JIT::linkSlowCaseIfNotJSCell):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
- (JSC::JIT::getDeTaggedConstantImmediate):
- (JSC::JIT::emitFastArithDeTagImmediate):
- (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::JIT::emitFastArithReTagImmediate):
- (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
- (JSC::JIT::emitFastArithImmToInt):
- (JSC::JIT::emitFastArithIntToImmOrSlowCase):
- (JSC::JIT::emitFastArithIntToImmNoCheck):
- (JSC::JIT::emitArithIntToImmWithJump):
- (JSC::JIT::emitTagAsBoolImmediate):
- (JSC::JIT::JIT):
- (JSC::JIT::compileOpCallInitializeCallFrame):
- (JSC::JIT::compileOpCallSetupArgs):
- (JSC::JIT::compileOpCallEvalSetupArgs):
- (JSC::JIT::compileOpConstructSetupArgs):
- (JSC::JIT::compileOpCall):
- (JSC::JIT::compileOpStrictEq):
- (JSC::JIT::emitSlowScriptCheck):
- (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::JIT::compileBinaryArithOp):
- (JSC::JIT::compileBinaryArithOpSlowCase):
- (JSC::JIT::privateCompileMainPass):
- (JSC::JIT::privateCompileLinkPass):
- (JSC::JIT::privateCompileSlowCases):
- (JSC::JIT::privateCompile):
- (JSC::JIT::privateCompileGetByIdSelf):
- (JSC::JIT::privateCompileGetByIdProto):
- (JSC::JIT::privateCompileGetByIdChain):
- (JSC::JIT::privateCompilePutByIdReplace):
- (JSC::JIT::privateCompilePutByIdTransition):
- (JSC::JIT::unlinkCall):
(JSC::JIT::linkCall):
- (JSC::JIT::privateCompileCTIMachineTrampolines):
- (JSC::JIT::freeCTIMachineTrampolines):
- (JSC::JIT::patchGetByIdSelf):
- (JSC::JIT::patchPutByIdReplace):
- (JSC::JIT::privateCompilePatchGetArrayLength):
- (JSC::JIT::emitGetVariableObjectRegister):
- (JSC::JIT::emitPutVariableObjectRegister):
- * VM/CTI.h:
- (JSC::JIT::compile):
- (JSC::JIT::compileGetByIdSelf):
- (JSC::JIT::compileGetByIdProto):
- (JSC::JIT::compileGetByIdChain):
- (JSC::JIT::compilePutByIdReplace):
- (JSC::JIT::compilePutByIdTransition):
- (JSC::JIT::compileCTIMachineTrampolines):
- (JSC::JIT::compilePatchGetArrayLength):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::unlinkCallers):
- * VM/Machine.cpp:
- (JSC::Interpreter::initialize):
- (JSC::Interpreter::~Interpreter):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- * VM/Machine.h:
- * VM/RegisterFile.h:
- * parser/Nodes.h:
- * runtime/JSArray.h:
- * runtime/JSCell.h:
- * runtime/JSFunction.h:
- * runtime/JSImmediate.h:
- * runtime/JSNumberCell.h:
- * runtime/JSObject.h:
- * runtime/JSString.h:
- * runtime/JSVariableObject.h:
- * runtime/ScopeChain.h:
- * runtime/Structure.h:
- * runtime/TypeInfo.h:
- * runtime/UString.h:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix wx build.
-
- * jscore.bkl:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Nixed X86:: and X86Assembler:: prefixes in a lot of places using typedefs.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetVirtualRegister):
- (JSC::CTI::emitGetVirtualRegisters):
- (JSC::CTI::emitPutCTIArgFromVirtualRegister):
- (JSC::CTI::emitPutCTIArg):
- (JSC::CTI::emitGetCTIArg):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutVirtualRegister):
- (JSC::CTI::emitNakedCall):
- (JSC::CTI::emitNakedFastCall):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::CTI::emitFastArithReTagImmediate):
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- (JSC::CTI::emitFastArithImmToInt):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::emitFastArithIntToImmNoCheck):
- (JSC::CTI::emitArithIntToImmWithJump):
- (JSC::CTI::emitTagAsBoolImmediate):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::emitGetVariableObjectRegister):
- (JSC::CTI::emitPutVariableObjectRegister):
- * VM/CTI.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JmpTable::JmpTable):
- (JSC::SlowCaseEntry::SlowCaseEntry):
- (JSC::CTI::JSRInfo::JSRInfo):
- * wrec/WREC.h:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * JavaScriptCore.pri:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed OBJECT_OFFSET => FIELD_OFFSET
-
- Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in
- more places.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::emitGetVariableObjectRegister):
- (JSC::CTI::emitPutVariableObjectRegister):
- * runtime/JSValue.h:
- * runtime/JSVariableObject.h:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renames:
-
- X86Assembler::copy => X86Assembler::executableCopy
- AssemblerBuffer::copy => AssemblerBuffer::executableCopy
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- * masm/X86Assembler.h:
- (JSC::AssemblerBuffer::executableCopy):
- (JSC::X86Assembler::executableCopy):
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed WREC => JSC::WREC, removing JSC:: prefix in a lot of places.
- Renamed WRECFunction => WREC::CompiledRegExp, and deployed this type
- name in place of a few casts.
-
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::~RegExp):
- (JSC::RegExp::match):
- * runtime/RegExp.h:
- * wrec/CharacterClassConstructor.cpp:
- * wrec/CharacterClassConstructor.h:
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WREC.h:
- (JSC::WREC::Generator::Generator):
- (JSC::WREC::Parser::Parser):
- (JSC::WREC::Parser::parseAlternative):
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed BytecodeInterpreter => Interpreter.
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::freeCTIMachineTrampolines):
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructures):
- (JSC::CodeBlock::derefStructures):
- (JSC::CodeBlock::refStructures):
- * VM/Machine.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::Interpreter::resolve):
- (JSC::Interpreter::resolveSkip):
- (JSC::Interpreter::resolveGlobal):
- (JSC::Interpreter::resolveBase):
- (JSC::Interpreter::resolveBaseAndProperty):
- (JSC::Interpreter::resolveBaseAndFunc):
- (JSC::Interpreter::slideRegisterWindowForCall):
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::initialize):
- (JSC::Interpreter::~Interpreter):
- (JSC::Interpreter::dumpCallFrame):
- (JSC::Interpreter::dumpRegisters):
- (JSC::Interpreter::isOpcode):
- (JSC::Interpreter::unwindCallFrame):
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::debug):
- (JSC::Interpreter::resetTimeoutCheck):
- (JSC::Interpreter::checkTimeout):
- (JSC::Interpreter::createExceptionScope):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::Interpreter::uncachePutByID):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::uncacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- (JSC::Interpreter::retrieveCaller):
- (JSC::Interpreter::retrieveLastCaller):
- (JSC::Interpreter::findFunctionCallFrame):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_end):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_timeout_check):
- (JSC::Interpreter::cti_register_file_check):
- (JSC::Interpreter::cti_op_loop_if_less):
- (JSC::Interpreter::cti_op_loop_if_lesseq):
- (JSC::Interpreter::cti_op_new_object):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_new_func):
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_op_call_arityCheck):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- (JSC::Interpreter::cti_op_push_activation):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_create_arguments):
- (JSC::Interpreter::cti_op_create_arguments_no_params):
- (JSC::Interpreter::cti_op_tear_off_activation):
- (JSC::Interpreter::cti_op_tear_off_arguments):
- (JSC::Interpreter::cti_op_profile_will_call):
- (JSC::Interpreter::cti_op_profile_did_call):
- (JSC::Interpreter::cti_op_ret_scopeChain):
- (JSC::Interpreter::cti_op_new_array):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_JSConstruct):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_lesseq):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_resolve_base):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_jless):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_new_func_exp):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_less):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_new_regexp):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_call_eval):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_get_pnames):
- (JSC::Interpreter::cti_op_next_pname):
- (JSC::Interpreter::cti_op_push_scope):
- (JSC::Interpreter::cti_op_pop_scope):
- (JSC::Interpreter::cti_op_typeof):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_is_boolean):
- (JSC::Interpreter::cti_op_is_number):
- (JSC::Interpreter::cti_op_is_string):
- (JSC::Interpreter::cti_op_is_object):
- (JSC::Interpreter::cti_op_is_function):
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_push_new_scope):
- (JSC::Interpreter::cti_op_jmp_scopes):
- (JSC::Interpreter::cti_op_put_by_index):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_op_del_by_val):
- (JSC::Interpreter::cti_op_put_getter):
- (JSC::Interpreter::cti_op_put_setter):
- (JSC::Interpreter::cti_op_new_error):
- (JSC::Interpreter::cti_op_debug):
- (JSC::Interpreter::cti_vm_throw):
- * VM/Machine.h:
- * VM/Register.h:
- * VM/SamplingTool.h:
- (JSC::SamplingTool::SamplingTool):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate):
- (JSC::BytecodeGenerator::BytecodeGenerator):
- * jsc.cpp:
- (runWithScripts):
- * runtime/ExecState.h:
- (JSC::ExecState::interpreter):
- * runtime/JSCell.h:
- * runtime/JSFunction.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSGlobalData.h:
- * runtime/JSString.h:
- * wrec/WREC.cpp:
- (WREC::compileRegExp):
- * wrec/WREC.h:
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Roll out r38461 (my last patch) because it broke the world.
-
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- A few more renames:
-
- BytecodeInterpreter => Interpreter
- WREC => JSC::WREC, removing JSC:: prefix in a lot of places
- X86Assembler::copy => X86Assembler::executableCopy
- AssemblerBuffer::copy => AssemblerBuffer::executableCopy
- WRECFunction => WREC::RegExpFunction
- OBJECT_OFFSET => FIELD_OFFSET
-
- Also:
-
- Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in more places.
- Nixed X86:: and X86Assembler:: prefixes in a lot of places using typedefs
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::):
- (JSC::CTI::emitGetVirtualRegister):
- (JSC::CTI::emitGetVirtualRegisters):
- (JSC::CTI::emitPutCTIArgFromVirtualRegister):
- (JSC::CTI::emitPutCTIArg):
- (JSC::CTI::emitGetCTIArg):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutVirtualRegister):
- (JSC::CTI::emitNakedCall):
- (JSC::CTI::emitNakedFastCall):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::CTI::emitFastArithReTagImmediate):
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- (JSC::CTI::emitFastArithImmToInt):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::emitFastArithIntToImmNoCheck):
- (JSC::CTI::emitArithIntToImmWithJump):
- (JSC::CTI::emitTagAsBoolImmediate):
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::freeCTIMachineTrampolines):
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::emitGetVariableObjectRegister):
- (JSC::CTI::emitPutVariableObjectRegister):
- * VM/CTI.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JmpTable::JmpTable):
- (JSC::SlowCaseEntry::SlowCaseEntry):
- (JSC::CTI::JSRInfo::JSRInfo):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructures):
- (JSC::CodeBlock::derefStructures):
- (JSC::CodeBlock::refStructures):
- * VM/Machine.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::Interpreter::resolve):
- (JSC::Interpreter::resolveSkip):
- (JSC::Interpreter::resolveGlobal):
- (JSC::Interpreter::resolveBase):
- (JSC::Interpreter::resolveBaseAndProperty):
- (JSC::Interpreter::resolveBaseAndFunc):
- (JSC::Interpreter::slideRegisterWindowForCall):
- (JSC::Interpreter::callEval):
- (JSC::Interpreter::Interpreter):
- (JSC::Interpreter::initialize):
- (JSC::Interpreter::~Interpreter):
- (JSC::Interpreter::dumpCallFrame):
- (JSC::Interpreter::dumpRegisters):
- (JSC::Interpreter::isOpcode):
- (JSC::Interpreter::unwindCallFrame):
- (JSC::Interpreter::throwException):
- (JSC::Interpreter::execute):
- (JSC::Interpreter::debug):
- (JSC::Interpreter::resetTimeoutCheck):
- (JSC::Interpreter::checkTimeout):
- (JSC::Interpreter::createExceptionScope):
- (JSC::Interpreter::tryCachePutByID):
- (JSC::Interpreter::uncachePutByID):
- (JSC::Interpreter::tryCacheGetByID):
- (JSC::Interpreter::uncacheGetByID):
- (JSC::Interpreter::privateExecute):
- (JSC::Interpreter::retrieveArguments):
- (JSC::Interpreter::retrieveCaller):
- (JSC::Interpreter::retrieveLastCaller):
- (JSC::Interpreter::findFunctionCallFrame):
- (JSC::Interpreter::tryCTICachePutByID):
- (JSC::Interpreter::tryCTICacheGetByID):
- (JSC::):
- (JSC::Interpreter::cti_op_convert_this):
- (JSC::Interpreter::cti_op_end):
- (JSC::Interpreter::cti_op_add):
- (JSC::Interpreter::cti_op_pre_inc):
- (JSC::Interpreter::cti_timeout_check):
- (JSC::Interpreter::cti_register_file_check):
- (JSC::Interpreter::cti_op_loop_if_less):
- (JSC::Interpreter::cti_op_loop_if_lesseq):
- (JSC::Interpreter::cti_op_new_object):
- (JSC::Interpreter::cti_op_put_by_id):
- (JSC::Interpreter::cti_op_put_by_id_second):
- (JSC::Interpreter::cti_op_put_by_id_generic):
- (JSC::Interpreter::cti_op_put_by_id_fail):
- (JSC::Interpreter::cti_op_get_by_id):
- (JSC::Interpreter::cti_op_get_by_id_second):
- (JSC::Interpreter::cti_op_get_by_id_generic):
- (JSC::Interpreter::cti_op_get_by_id_fail):
- (JSC::Interpreter::cti_op_instanceof):
- (JSC::Interpreter::cti_op_del_by_id):
- (JSC::Interpreter::cti_op_mul):
- (JSC::Interpreter::cti_op_new_func):
- (JSC::Interpreter::cti_op_call_JSFunction):
- (JSC::Interpreter::cti_op_call_arityCheck):
- (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- (JSC::Interpreter::cti_vm_lazyLinkCall):
- (JSC::Interpreter::cti_op_push_activation):
- (JSC::Interpreter::cti_op_call_NotJSFunction):
- (JSC::Interpreter::cti_op_create_arguments):
- (JSC::Interpreter::cti_op_create_arguments_no_params):
- (JSC::Interpreter::cti_op_tear_off_activation):
- (JSC::Interpreter::cti_op_tear_off_arguments):
- (JSC::Interpreter::cti_op_profile_will_call):
- (JSC::Interpreter::cti_op_profile_did_call):
- (JSC::Interpreter::cti_op_ret_scopeChain):
- (JSC::Interpreter::cti_op_new_array):
- (JSC::Interpreter::cti_op_resolve):
- (JSC::Interpreter::cti_op_construct_JSConstruct):
- (JSC::Interpreter::cti_op_construct_NotJSConstruct):
- (JSC::Interpreter::cti_op_get_by_val):
- (JSC::Interpreter::cti_op_resolve_func):
- (JSC::Interpreter::cti_op_sub):
- (JSC::Interpreter::cti_op_put_by_val):
- (JSC::Interpreter::cti_op_put_by_val_array):
- (JSC::Interpreter::cti_op_lesseq):
- (JSC::Interpreter::cti_op_loop_if_true):
- (JSC::Interpreter::cti_op_negate):
- (JSC::Interpreter::cti_op_resolve_base):
- (JSC::Interpreter::cti_op_resolve_skip):
- (JSC::Interpreter::cti_op_resolve_global):
- (JSC::Interpreter::cti_op_div):
- (JSC::Interpreter::cti_op_pre_dec):
- (JSC::Interpreter::cti_op_jless):
- (JSC::Interpreter::cti_op_not):
- (JSC::Interpreter::cti_op_jtrue):
- (JSC::Interpreter::cti_op_post_inc):
- (JSC::Interpreter::cti_op_eq):
- (JSC::Interpreter::cti_op_lshift):
- (JSC::Interpreter::cti_op_bitand):
- (JSC::Interpreter::cti_op_rshift):
- (JSC::Interpreter::cti_op_bitnot):
- (JSC::Interpreter::cti_op_resolve_with_base):
- (JSC::Interpreter::cti_op_new_func_exp):
- (JSC::Interpreter::cti_op_mod):
- (JSC::Interpreter::cti_op_less):
- (JSC::Interpreter::cti_op_neq):
- (JSC::Interpreter::cti_op_post_dec):
- (JSC::Interpreter::cti_op_urshift):
- (JSC::Interpreter::cti_op_bitxor):
- (JSC::Interpreter::cti_op_new_regexp):
- (JSC::Interpreter::cti_op_bitor):
- (JSC::Interpreter::cti_op_call_eval):
- (JSC::Interpreter::cti_op_throw):
- (JSC::Interpreter::cti_op_get_pnames):
- (JSC::Interpreter::cti_op_next_pname):
- (JSC::Interpreter::cti_op_push_scope):
- (JSC::Interpreter::cti_op_pop_scope):
- (JSC::Interpreter::cti_op_typeof):
- (JSC::Interpreter::cti_op_is_undefined):
- (JSC::Interpreter::cti_op_is_boolean):
- (JSC::Interpreter::cti_op_is_number):
- (JSC::Interpreter::cti_op_is_string):
- (JSC::Interpreter::cti_op_is_object):
- (JSC::Interpreter::cti_op_is_function):
- (JSC::Interpreter::cti_op_stricteq):
- (JSC::Interpreter::cti_op_nstricteq):
- (JSC::Interpreter::cti_op_to_jsnumber):
- (JSC::Interpreter::cti_op_in):
- (JSC::Interpreter::cti_op_push_new_scope):
- (JSC::Interpreter::cti_op_jmp_scopes):
- (JSC::Interpreter::cti_op_put_by_index):
- (JSC::Interpreter::cti_op_switch_imm):
- (JSC::Interpreter::cti_op_switch_char):
- (JSC::Interpreter::cti_op_switch_string):
- (JSC::Interpreter::cti_op_del_by_val):
- (JSC::Interpreter::cti_op_put_getter):
- (JSC::Interpreter::cti_op_put_setter):
- (JSC::Interpreter::cti_op_new_error):
- (JSC::Interpreter::cti_op_debug):
- (JSC::Interpreter::cti_vm_throw):
- * VM/Machine.h:
- * VM/Register.h:
- * VM/SamplingTool.cpp:
- (JSC::SamplingTool::dump):
- * VM/SamplingTool.h:
- (JSC::SamplingTool::SamplingTool):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::generate):
- (JSC::BytecodeGenerator::BytecodeGenerator):
- * jsc.cpp:
- (runWithScripts):
- * masm/X86Assembler.h:
- (JSC::AssemblerBuffer::executableCopy):
- (JSC::X86Assembler::executableCopy):
- * runtime/ExecState.h:
- (JSC::ExecState::interpreter):
- * runtime/JSCell.h:
- * runtime/JSFunction.h:
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * runtime/JSGlobalData.h:
- * runtime/JSImmediate.h:
- * runtime/JSString.h:
- * runtime/JSValue.h:
- * runtime/JSVariableObject.h:
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::~RegExp):
- (JSC::RegExp::match):
- * runtime/RegExp.h:
- * wrec/CharacterClassConstructor.cpp:
- * wrec/CharacterClassConstructor.h:
- * wrec/WREC.cpp:
- (JSC::WREC::compileRegExp):
- * wrec/WREC.h:
- (JSC::WREC::Generator::Generator):
- (JSC::WREC::Parser::):
- (JSC::WREC::Parser::Parser):
- (JSC::WREC::Parser::parseAlternative):
-
-2008-11-16 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21810
- Remove use of static C++ objects that are destroyed at exit time (destructors)
-
- Conditionally have the DEFINE_STATIC_LOCAL workaround <rdar://problem/6354696>
- (Codegen issue with C++ static reference in gcc build 5465) based upon the compiler
- build versions. It will use the:
- static T& = *new T;
- style for all other compilers.
-
- * wtf/StdLibExtras.h:
-
-2008-11-16 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22290
- Remove cross-heap GC and MessagePort multi-threading support
-
- It is broken (and may not be implementable at all), and no longer needed, as we
- don't use MessagePorts for communication with workers any more.
-
- * JavaScriptCore.exp:
- * runtime/Collector.cpp:
- (JSC::Heap::collect):
- * runtime/JSGlobalObject.cpp:
- * runtime/JSGlobalObject.h:
- Remove hooks for cross-heap GC.
-
-2008-11-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Cleanup jsc command line code a little.
-
- * jsc.cpp:
- (functionQuit):
- (main): Use standard exit status macros
- (cleanupGlobalData): Factor out cleanup code into this function.
- (printUsageStatement): Use standard exit status macros.
-
-2008-11-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Cleanup BytecodeGenerator constructors.
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- * bytecompiler/CodeGenerator.h:
- * parser/Nodes.cpp:
- (JSC::ProgramNode::generateBytecode):
-
-2008-11-15 Darin Adler <darin@apple.com>
-
- Rubber stamped by Geoff Garen.
-
- - do the long-planned StructureID -> Structure rename
-
- * API/JSCallbackConstructor.cpp:
- (JSC::JSCallbackConstructor::JSCallbackConstructor):
- * API/JSCallbackConstructor.h:
- (JSC::JSCallbackConstructor::createStructure):
- * API/JSCallbackFunction.h:
- (JSC::JSCallbackFunction::createStructure):
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::createStructure):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::JSCallbackObject):
- * API/JSValueRef.cpp:
- (JSValueIsInstanceOfConstructor):
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.scons:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/CTI.cpp:
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::transitionWillNeedStorageRealloc):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- * VM/CTI.h:
- (JSC::CTI::compileGetByIdSelf):
- (JSC::CTI::compileGetByIdProto):
- (JSC::CTI::compileGetByIdChain):
- (JSC::CTI::compilePutByIdReplace):
- (JSC::CTI::compilePutByIdTransition):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructure):
- (JSC::CodeBlock::printStructures):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::derefStructures):
- (JSC::CodeBlock::refStructures):
- * VM/CodeBlock.h:
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
- (JSC::Instruction::):
- * VM/Machine.cpp:
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::BytecodeInterpreter::resolveGlobal):
- (JSC::BytecodeInterpreter::BytecodeInterpreter):
- (JSC::cachePrototypeChain):
- (JSC::BytecodeInterpreter::tryCachePutByID):
- (JSC::BytecodeInterpreter::uncachePutByID):
- (JSC::BytecodeInterpreter::tryCacheGetByID):
- (JSC::BytecodeInterpreter::uncacheGetByID):
- (JSC::BytecodeInterpreter::privateExecute):
- (JSC::BytecodeInterpreter::tryCTICachePutByID):
- (JSC::BytecodeInterpreter::tryCTICacheGetByID):
- (JSC::BytecodeInterpreter::cti_op_instanceof):
- (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct):
- (JSC::BytecodeInterpreter::cti_op_resolve_global):
- (JSC::BytecodeInterpreter::cti_op_is_undefined):
- * runtime/Arguments.h:
- (JSC::Arguments::createStructure):
- * runtime/ArrayConstructor.cpp:
- (JSC::ArrayConstructor::ArrayConstructor):
- * runtime/ArrayConstructor.h:
- * runtime/ArrayPrototype.cpp:
- (JSC::ArrayPrototype::ArrayPrototype):
- * runtime/ArrayPrototype.h:
- * runtime/BatchedTransitionOptimizer.h:
- (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
- (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
- * runtime/BooleanConstructor.cpp:
- (JSC::BooleanConstructor::BooleanConstructor):
- * runtime/BooleanConstructor.h:
- * runtime/BooleanObject.cpp:
- (JSC::BooleanObject::BooleanObject):
- * runtime/BooleanObject.h:
- * runtime/BooleanPrototype.cpp:
- (JSC::BooleanPrototype::BooleanPrototype):
- * runtime/BooleanPrototype.h:
- * runtime/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- * runtime/DateConstructor.h:
- * runtime/DateInstance.cpp:
- (JSC::DateInstance::DateInstance):
- * runtime/DateInstance.h:
- * runtime/DatePrototype.cpp:
- (JSC::DatePrototype::DatePrototype):
- * runtime/DatePrototype.h:
- (JSC::DatePrototype::createStructure):
- * runtime/ErrorConstructor.cpp:
- (JSC::ErrorConstructor::ErrorConstructor):
- * runtime/ErrorConstructor.h:
- * runtime/ErrorInstance.cpp:
- (JSC::ErrorInstance::ErrorInstance):
- * runtime/ErrorInstance.h:
- * runtime/ErrorPrototype.cpp:
- (JSC::ErrorPrototype::ErrorPrototype):
- * runtime/ErrorPrototype.h:
- * runtime/FunctionConstructor.cpp:
- (JSC::FunctionConstructor::FunctionConstructor):
- * runtime/FunctionConstructor.h:
- * runtime/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::FunctionPrototype):
- (JSC::FunctionPrototype::addFunctionProperties):
- * runtime/FunctionPrototype.h:
- (JSC::FunctionPrototype::createStructure):
- * runtime/GlobalEvalFunction.cpp:
- (JSC::GlobalEvalFunction::GlobalEvalFunction):
- * runtime/GlobalEvalFunction.h:
- * runtime/Identifier.h:
- * runtime/InternalFunction.cpp:
- (JSC::InternalFunction::InternalFunction):
- * runtime/InternalFunction.h:
- (JSC::InternalFunction::createStructure):
- (JSC::InternalFunction::InternalFunction):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::JSActivation):
- * runtime/JSActivation.h:
- (JSC::JSActivation::createStructure):
- * runtime/JSArray.cpp:
- (JSC::JSArray::JSArray):
- * runtime/JSArray.h:
- (JSC::JSArray::createStructure):
- * runtime/JSCell.h:
- (JSC::JSCell::JSCell):
- (JSC::JSCell::isObject):
- (JSC::JSCell::isString):
- (JSC::JSCell::structure):
- (JSC::JSValue::needsThisConversion):
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::construct):
- * runtime/JSFunction.h:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::createStructure):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::createLeaked):
- * runtime/JSGlobalData.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::markIfNeeded):
- (JSC::JSGlobalObject::reset):
- * runtime/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObject):
- (JSC::JSGlobalObject::argumentsStructure):
- (JSC::JSGlobalObject::arrayStructure):
- (JSC::JSGlobalObject::booleanObjectStructure):
- (JSC::JSGlobalObject::callbackConstructorStructure):
- (JSC::JSGlobalObject::callbackFunctionStructure):
- (JSC::JSGlobalObject::callbackObjectStructure):
- (JSC::JSGlobalObject::dateStructure):
- (JSC::JSGlobalObject::emptyObjectStructure):
- (JSC::JSGlobalObject::errorStructure):
- (JSC::JSGlobalObject::functionStructure):
- (JSC::JSGlobalObject::numberObjectStructure):
- (JSC::JSGlobalObject::prototypeFunctionStructure):
- (JSC::JSGlobalObject::regExpMatchesArrayStructure):
- (JSC::JSGlobalObject::regExpStructure):
- (JSC::JSGlobalObject::stringObjectStructure):
- (JSC::JSGlobalObject::createStructure):
- (JSC::Structure::prototypeForLookup):
- * runtime/JSNotAnObject.h:
- (JSC::JSNotAnObject::createStructure):
- * runtime/JSNumberCell.h:
- (JSC::JSNumberCell::createStructure):
- (JSC::JSNumberCell::JSNumberCell):
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::put):
- (JSC::JSObject::deleteProperty):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- (JSC::JSObject::getPropertyAttributes):
- (JSC::JSObject::getPropertyNames):
- (JSC::JSObject::removeDirect):
- (JSC::JSObject::createInheritorID):
- * runtime/JSObject.h:
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::hasCustomProperties):
- (JSC::JSObject::hasGetterSetterProperties):
- (JSC::JSObject::createStructure):
- (JSC::JSObject::JSObject):
- (JSC::JSObject::~JSObject):
- (JSC::JSObject::prototype):
- (JSC::JSObject::setPrototype):
- (JSC::JSObject::setStructure):
- (JSC::JSObject::inheritorID):
- (JSC::JSObject::inlineGetOwnPropertySlot):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSCell::fastGetOwnPropertySlot):
- (JSC::JSObject::putDirect):
- (JSC::JSObject::putDirectWithoutTransition):
- (JSC::JSObject::transitionTo):
- * runtime/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::next):
- * runtime/JSStaticScopeObject.h:
- (JSC::JSStaticScopeObject::JSStaticScopeObject):
- (JSC::JSStaticScopeObject::createStructure):
- * runtime/JSString.h:
- (JSC::JSString::JSString):
- (JSC::JSString::createStructure):
- * runtime/JSVariableObject.h:
- (JSC::JSVariableObject::JSVariableObject):
- * runtime/JSWrapperObject.h:
- (JSC::JSWrapperObject::JSWrapperObject):
- * runtime/MathObject.cpp:
- (JSC::MathObject::MathObject):
- * runtime/MathObject.h:
- (JSC::MathObject::createStructure):
- * runtime/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- * runtime/NativeErrorConstructor.h:
- * runtime/NativeErrorPrototype.cpp:
- (JSC::NativeErrorPrototype::NativeErrorPrototype):
- * runtime/NativeErrorPrototype.h:
- * runtime/NumberConstructor.cpp:
- (JSC::NumberConstructor::NumberConstructor):
- * runtime/NumberConstructor.h:
- (JSC::NumberConstructor::createStructure):
- * runtime/NumberObject.cpp:
- (JSC::NumberObject::NumberObject):
- * runtime/NumberObject.h:
- * runtime/NumberPrototype.cpp:
- (JSC::NumberPrototype::NumberPrototype):
- * runtime/NumberPrototype.h:
- * runtime/ObjectConstructor.cpp:
- (JSC::ObjectConstructor::ObjectConstructor):
- * runtime/ObjectConstructor.h:
- * runtime/ObjectPrototype.cpp:
- (JSC::ObjectPrototype::ObjectPrototype):
- * runtime/ObjectPrototype.h:
- * runtime/Operations.h:
- (JSC::equalSlowCaseInline):
- * runtime/PropertyNameArray.h:
- (JSC::PropertyNameArrayData::setCachedStructure):
- (JSC::PropertyNameArrayData::cachedStructure):
- (JSC::PropertyNameArrayData::setCachedPrototypeChain):
- (JSC::PropertyNameArrayData::cachedPrototypeChain):
- (JSC::PropertyNameArrayData::PropertyNameArrayData):
- * runtime/PrototypeFunction.cpp:
- (JSC::PrototypeFunction::PrototypeFunction):
- * runtime/PrototypeFunction.h:
- * runtime/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::RegExpConstructor):
- * runtime/RegExpConstructor.h:
- (JSC::RegExpConstructor::createStructure):
- * runtime/RegExpObject.cpp:
- (JSC::RegExpObject::RegExpObject):
- * runtime/RegExpObject.h:
- (JSC::RegExpObject::createStructure):
- * runtime/RegExpPrototype.cpp:
- (JSC::RegExpPrototype::RegExpPrototype):
- * runtime/RegExpPrototype.h:
- * runtime/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
- * runtime/StringConstructor.h:
- * runtime/StringObject.cpp:
- (JSC::StringObject::StringObject):
- * runtime/StringObject.h:
- (JSC::StringObject::createStructure):
- * runtime/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::create):
- (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- * runtime/StringPrototype.cpp:
- (JSC::StringPrototype::StringPrototype):
- * runtime/StringPrototype.h:
- * runtime/Structure.cpp: Copied from JavaScriptCore/runtime/StructureID.cpp.
- (JSC::Structure::dumpStatistics):
- (JSC::Structure::Structure):
- (JSC::Structure::~Structure):
- (JSC::Structure::startIgnoringLeaks):
- (JSC::Structure::stopIgnoringLeaks):
- (JSC::Structure::materializePropertyMap):
- (JSC::Structure::getEnumerablePropertyNames):
- (JSC::Structure::clearEnumerationCache):
- (JSC::Structure::growPropertyStorageCapacity):
- (JSC::Structure::addPropertyTransitionToExistingStructure):
- (JSC::Structure::addPropertyTransition):
- (JSC::Structure::removePropertyTransition):
- (JSC::Structure::changePrototypeTransition):
- (JSC::Structure::getterSetterTransition):
- (JSC::Structure::toDictionaryTransition):
- (JSC::Structure::fromDictionaryTransition):
- (JSC::Structure::addPropertyWithoutTransition):
- (JSC::Structure::removePropertyWithoutTransition):
- (JSC::Structure::createCachedPrototypeChain):
- (JSC::Structure::checkConsistency):
- (JSC::Structure::copyPropertyTable):
- (JSC::Structure::get):
- (JSC::Structure::put):
- (JSC::Structure::remove):
- (JSC::Structure::insertIntoPropertyMapHashTable):
- (JSC::Structure::createPropertyMapHashTable):
- (JSC::Structure::expandPropertyMapHashTable):
- (JSC::Structure::rehashPropertyMapHashTable):
- (JSC::Structure::getEnumerablePropertyNamesInternal):
- * runtime/Structure.h: Copied from JavaScriptCore/runtime/StructureID.h.
- (JSC::Structure::create):
- (JSC::Structure::previousID):
- (JSC::Structure::setCachedPrototypeChain):
- (JSC::Structure::cachedPrototypeChain):
- (JSC::Structure::):
- (JSC::Structure::get):
- * runtime/StructureChain.cpp: Copied from JavaScriptCore/runtime/StructureIDChain.cpp.
- (JSC::StructureChain::StructureChain):
- (JSC::structureChainsAreEqual):
- * runtime/StructureChain.h: Copied from JavaScriptCore/runtime/StructureIDChain.h.
- (JSC::StructureChain::create):
- (JSC::StructureChain::head):
- * runtime/StructureID.cpp: Removed.
- * runtime/StructureID.h: Removed.
- * runtime/StructureIDChain.cpp: Removed.
- * runtime/StructureIDChain.h: Removed.
- * runtime/StructureIDTransitionTable.h: Removed.
- * runtime/StructureTransitionTable.h: Copied from JavaScriptCore/runtime/StructureIDTransitionTable.h.
-
-2008-11-15 Darin Adler <darin@apple.com>
-
- - fix non-WREC build
-
- * runtime/RegExp.cpp: Put "using namespace WREC" inside #if ENABLE(WREC).
-
-2008-11-15 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Timothy Hatcher.
-
- As ThreadingNone doesn't implement threads, isMainThread should return true,
- not false.
-
- https://bugs.webkit.org/show_bug.cgi?id=22285
-
- * wtf/ThreadingNone.cpp:
- (WTF::isMainThread):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved all WREC-related code into WREC.cpp and put it in a WREC namespace.
- Removed the WREC prefix from class names.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/Machine.h:
- (JSC::BytecodeInterpreter::assemblerBuffer):
- * masm/X86Assembler.h:
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
- * wrec/CharacterClassConstructor.cpp:
- * wrec/CharacterClassConstructor.h:
- * wrec/WREC.cpp:
- (WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
- (WREC::GeneratePatternCharacterFunctor::generateAtom):
- (WREC::GeneratePatternCharacterFunctor::backtrack):
- (WREC::GenerateCharacterClassFunctor::generateAtom):
- (WREC::GenerateCharacterClassFunctor::backtrack):
- (WREC::GenerateBackreferenceFunctor::generateAtom):
- (WREC::GenerateBackreferenceFunctor::backtrack):
- (WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
- (WREC::GenerateParenthesesNonGreedyFunctor::backtrack):
- (WREC::Generator::generateBacktrack1):
- (WREC::Generator::generateBacktrackBackreference):
- (WREC::Generator::generateBackreferenceQuantifier):
- (WREC::Generator::generateNonGreedyQuantifier):
- (WREC::Generator::generateGreedyQuantifier):
- (WREC::Generator::generatePatternCharacter):
- (WREC::Generator::generateCharacterClassInvertedRange):
- (WREC::Generator::generateCharacterClassInverted):
- (WREC::Generator::generateCharacterClass):
- (WREC::Generator::generateParentheses):
- (WREC::Generator::generateParenthesesNonGreedy):
- (WREC::Generator::generateParenthesesResetTrampoline):
- (WREC::Generator::generateAssertionBOL):
- (WREC::Generator::generateAssertionEOL):
- (WREC::Generator::generateAssertionWordBoundary):
- (WREC::Generator::generateBackreference):
- (WREC::Generator::generateDisjunction):
- (WREC::Generator::terminateDisjunction):
- (WREC::Parser::parseGreedyQuantifier):
- (WREC::Parser::parseQuantifier):
- (WREC::Parser::parsePatternCharacterQualifier):
- (WREC::Parser::parseCharacterClassQuantifier):
- (WREC::Parser::parseBackreferenceQuantifier):
- (WREC::Parser::parseParentheses):
- (WREC::Parser::parseCharacterClass):
- (WREC::Parser::parseOctalEscape):
- (WREC::Parser::parseEscape):
- (WREC::Parser::parseTerm):
- (WREC::Parser::parseDisjunction):
- (WREC::compileRegExp):
- * wrec/WREC.h:
- (WREC::Generator::Generator):
- (WREC::Parser::Parser):
- (WREC::Parser::parseAlternative):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Changed another case of "m_jit" to "m_assembler".
-
- * VM/CTI.cpp:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
- (JSC::WRECGenerator::WRECGenerator):
- (JSC::WRECParser::WRECParser):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed "jit" to "assembler" and, for brevity, replaced *jit.* with __
- using a macro.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetVirtualRegister):
- (JSC::CTI::emitPutCTIArgFromVirtualRegister):
- (JSC::CTI::emitPutCTIArg):
- (JSC::CTI::emitGetCTIArg):
- (JSC::CTI::emitPutCTIArgConstant):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutVirtualRegister):
- (JSC::CTI::emitInitRegister):
- (JSC::CTI::emitAllocateNumber):
- (JSC::CTI::emitNakedCall):
- (JSC::CTI::emitNakedFastCall):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::linkSlowCaseIfNotJSCell):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::CTI::emitFastArithReTagImmediate):
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- (JSC::CTI::emitFastArithImmToInt):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::emitFastArithIntToImmNoCheck):
- (JSC::CTI::emitArithIntToImmWithJump):
- (JSC::CTI::emitTagAsBoolImmediate):
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileLinkPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::emitGetVariableObjectRegister):
- (JSC::CTI::emitPutVariableObjectRegister):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generateBacktrack1):
- (JSC::WRECGenerator::generateBacktrackBackreference):
- (JSC::WRECGenerator::generateBackreferenceQuantifier):
- (JSC::WRECGenerator::generateNonGreedyQuantifier):
- (JSC::WRECGenerator::generateGreedyQuantifier):
- (JSC::WRECGenerator::generatePatternCharacter):
- (JSC::WRECGenerator::generateCharacterClassInvertedRange):
- (JSC::WRECGenerator::generateCharacterClassInverted):
- (JSC::WRECGenerator::generateCharacterClass):
- (JSC::WRECGenerator::generateParentheses):
- (JSC::WRECGenerator::generateParenthesesNonGreedy):
- (JSC::WRECGenerator::generateParenthesesResetTrampoline):
- (JSC::WRECGenerator::generateAssertionBOL):
- (JSC::WRECGenerator::generateAssertionEOL):
- (JSC::WRECGenerator::generateAssertionWordBoundary):
- (JSC::WRECGenerator::generateBackreference):
- (JSC::WRECGenerator::generateDisjunction):
- (JSC::WRECGenerator::terminateDisjunction):
-
-2008-11-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Remove dead method declaration.
-
- * bytecompiler/CodeGenerator.h:
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed LabelID to Label, Label::isForwardLabel to Label::isForward.
-
- * VM/LabelID.h:
- (JSC::Label::Label):
- (JSC::Label::isForward):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::newLabel):
- (JSC::BytecodeGenerator::emitLabel):
- (JSC::BytecodeGenerator::emitJump):
- (JSC::BytecodeGenerator::emitJumpIfTrue):
- (JSC::BytecodeGenerator::emitJumpIfFalse):
- (JSC::BytecodeGenerator::pushFinallyContext):
- (JSC::BytecodeGenerator::emitComplexJumpScopes):
- (JSC::BytecodeGenerator::emitJumpScopes):
- (JSC::BytecodeGenerator::emitNextPropertyName):
- (JSC::BytecodeGenerator::emitCatch):
- (JSC::BytecodeGenerator::emitJumpSubroutine):
- (JSC::prepareJumpTableForImmediateSwitch):
- (JSC::prepareJumpTableForCharacterSwitch):
- (JSC::prepareJumpTableForStringSwitch):
- (JSC::BytecodeGenerator::endSwitch):
- * bytecompiler/CodeGenerator.h:
- * bytecompiler/LabelScope.h:
- (JSC::LabelScope::LabelScope):
- (JSC::LabelScope::breakTarget):
- (JSC::LabelScope::continueTarget):
- * parser/Nodes.cpp:
- (JSC::LogicalOpNode::emitBytecode):
- (JSC::ConditionalNode::emitBytecode):
- (JSC::IfNode::emitBytecode):
- (JSC::IfElseNode::emitBytecode):
- (JSC::DoWhileNode::emitBytecode):
- (JSC::WhileNode::emitBytecode):
- (JSC::ForNode::emitBytecode):
- (JSC::ForInNode::emitBytecode):
- (JSC::ReturnNode::emitBytecode):
- (JSC::CaseBlockNode::emitBytecodeForBlock):
- (JSC::TryNode::emitBytecode):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed JITCodeBuffer to AssemblerBuffer and renamed its data members
- to be more like the rest of our buffer classes, with a size and a
- capacity.
-
- Added an assert in the unchecked put case to match the test in the checked
- put case.
-
- Changed a C-style cast to a C++-style cast.
-
- Renamed MAX_INSTRUCTION_SIZE to maxInstructionSize.
-
- * VM/CTI.cpp:
- (JSC::CTI::CTI):
- (JSC::CTI::compileRegExp):
- * VM/Machine.cpp:
- (JSC::BytecodeInterpreter::BytecodeInterpreter):
- * VM/Machine.h:
- (JSC::BytecodeInterpreter::assemblerBuffer):
- * masm/X86Assembler.h:
- (JSC::AssemblerBuffer::AssemblerBuffer):
- (JSC::AssemblerBuffer::~AssemblerBuffer):
- (JSC::AssemblerBuffer::ensureSpace):
- (JSC::AssemblerBuffer::isAligned):
- (JSC::AssemblerBuffer::putByteUnchecked):
- (JSC::AssemblerBuffer::putByte):
- (JSC::AssemblerBuffer::putShortUnchecked):
- (JSC::AssemblerBuffer::putShort):
- (JSC::AssemblerBuffer::putIntUnchecked):
- (JSC::AssemblerBuffer::putInt):
- (JSC::AssemblerBuffer::data):
- (JSC::AssemblerBuffer::size):
- (JSC::AssemblerBuffer::reset):
- (JSC::AssemblerBuffer::copy):
- (JSC::AssemblerBuffer::grow):
- (JSC::X86Assembler::):
- (JSC::X86Assembler::X86Assembler):
- (JSC::X86Assembler::testl_i32r):
- (JSC::X86Assembler::movl_mr):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::movl_i32m):
- (JSC::X86Assembler::emitCall):
- (JSC::X86Assembler::label):
- (JSC::X86Assembler::emitUnlinkedJmp):
- (JSC::X86Assembler::emitUnlinkedJne):
- (JSC::X86Assembler::emitUnlinkedJe):
- (JSC::X86Assembler::emitUnlinkedJl):
- (JSC::X86Assembler::emitUnlinkedJb):
- (JSC::X86Assembler::emitUnlinkedJle):
- (JSC::X86Assembler::emitUnlinkedJbe):
- (JSC::X86Assembler::emitUnlinkedJge):
- (JSC::X86Assembler::emitUnlinkedJg):
- (JSC::X86Assembler::emitUnlinkedJa):
- (JSC::X86Assembler::emitUnlinkedJae):
- (JSC::X86Assembler::emitUnlinkedJo):
- (JSC::X86Assembler::emitUnlinkedJp):
- (JSC::X86Assembler::emitUnlinkedJs):
- (JSC::X86Assembler::link):
- (JSC::X86Assembler::emitModRm_rr):
- (JSC::X86Assembler::emitModRm_rm):
- (JSC::X86Assembler::emitModRm_opr):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Suggested by Maciej Stachowiak.
-
- Reverted most "opcode" => "bytecode" renames. We use "bytecode" as a
- mass noun to refer to a stream of instructions. Each instruction may be
- an opcode or an operand.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCTICall):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructureIDs):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::derefStructureIDs):
- (JSC::CodeBlock::refStructureIDs):
- * VM/CodeBlock.h:
- * VM/ExceptionHelpers.cpp:
- (JSC::createNotAnObjectError):
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
- (JSC::Instruction::):
- * VM/Machine.cpp:
- (JSC::BytecodeInterpreter::isOpcode):
- (JSC::BytecodeInterpreter::throwException):
- (JSC::BytecodeInterpreter::tryCachePutByID):
- (JSC::BytecodeInterpreter::uncachePutByID):
- (JSC::BytecodeInterpreter::tryCacheGetByID):
- (JSC::BytecodeInterpreter::uncacheGetByID):
- (JSC::BytecodeInterpreter::privateExecute):
- (JSC::BytecodeInterpreter::tryCTICachePutByID):
- (JSC::BytecodeInterpreter::tryCTICacheGetByID):
- * VM/Machine.h:
- (JSC::BytecodeInterpreter::getOpcode):
- (JSC::BytecodeInterpreter::getOpcodeID):
- (JSC::BytecodeInterpreter::isCallBytecode):
- * VM/Opcode.cpp:
- (JSC::):
- (JSC::OpcodeStats::OpcodeStats):
- (JSC::compareOpcodeIndices):
- (JSC::compareOpcodePairIndices):
- (JSC::OpcodeStats::~OpcodeStats):
- (JSC::OpcodeStats::recordInstruction):
- (JSC::OpcodeStats::resetLastInstruction):
- * VM/Opcode.h:
- (JSC::):
- (JSC::padOpcodeName):
- * VM/SamplingTool.cpp:
- (JSC::ScopeSampleRecord::sample):
- (JSC::SamplingTool::run):
- (JSC::compareOpcodeIndicesSampling):
- (JSC::SamplingTool::dump):
- * VM/SamplingTool.h:
- (JSC::ScopeSampleRecord::ScopeSampleRecord):
- (JSC::SamplingTool::SamplingTool):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::emitLabel):
- (JSC::BytecodeGenerator::emitOpcode):
- (JSC::BytecodeGenerator::emitJump):
- (JSC::BytecodeGenerator::emitJumpIfTrue):
- (JSC::BytecodeGenerator::emitJumpIfFalse):
- (JSC::BytecodeGenerator::emitMove):
- (JSC::BytecodeGenerator::emitUnaryOp):
- (JSC::BytecodeGenerator::emitPreInc):
- (JSC::BytecodeGenerator::emitPreDec):
- (JSC::BytecodeGenerator::emitPostInc):
- (JSC::BytecodeGenerator::emitPostDec):
- (JSC::BytecodeGenerator::emitBinaryOp):
- (JSC::BytecodeGenerator::emitEqualityOp):
- (JSC::BytecodeGenerator::emitUnexpectedLoad):
- (JSC::BytecodeGenerator::emitInstanceOf):
- (JSC::BytecodeGenerator::emitResolve):
- (JSC::BytecodeGenerator::emitGetScopedVar):
- (JSC::BytecodeGenerator::emitPutScopedVar):
- (JSC::BytecodeGenerator::emitResolveBase):
- (JSC::BytecodeGenerator::emitResolveWithBase):
- (JSC::BytecodeGenerator::emitResolveFunction):
- (JSC::BytecodeGenerator::emitGetById):
- (JSC::BytecodeGenerator::emitPutById):
- (JSC::BytecodeGenerator::emitPutGetter):
- (JSC::BytecodeGenerator::emitPutSetter):
- (JSC::BytecodeGenerator::emitDeleteById):
- (JSC::BytecodeGenerator::emitGetByVal):
- (JSC::BytecodeGenerator::emitPutByVal):
- (JSC::BytecodeGenerator::emitDeleteByVal):
- (JSC::BytecodeGenerator::emitPutByIndex):
- (JSC::BytecodeGenerator::emitNewObject):
- (JSC::BytecodeGenerator::emitNewArray):
- (JSC::BytecodeGenerator::emitNewFunction):
- (JSC::BytecodeGenerator::emitNewRegExp):
- (JSC::BytecodeGenerator::emitNewFunctionExpression):
- (JSC::BytecodeGenerator::emitCall):
- (JSC::BytecodeGenerator::emitReturn):
- (JSC::BytecodeGenerator::emitUnaryNoDstOp):
- (JSC::BytecodeGenerator::emitConstruct):
- (JSC::BytecodeGenerator::emitPopScope):
- (JSC::BytecodeGenerator::emitDebugHook):
- (JSC::BytecodeGenerator::emitComplexJumpScopes):
- (JSC::BytecodeGenerator::emitJumpScopes):
- (JSC::BytecodeGenerator::emitNextPropertyName):
- (JSC::BytecodeGenerator::emitCatch):
- (JSC::BytecodeGenerator::emitNewError):
- (JSC::BytecodeGenerator::emitJumpSubroutine):
- (JSC::BytecodeGenerator::emitSubroutineReturn):
- (JSC::BytecodeGenerator::emitPushNewScope):
- (JSC::BytecodeGenerator::beginSwitch):
- * bytecompiler/CodeGenerator.h:
- * jsc.cpp:
- (runWithScripts):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::emitModRm_opr):
- (JSC::X86Assembler::emitModRm_opr_Unchecked):
- (JSC::X86Assembler::emitModRm_opm):
- (JSC::X86Assembler::emitModRm_opm_Unchecked):
- (JSC::X86Assembler::emitModRm_opmsib):
- * parser/Nodes.cpp:
- (JSC::UnaryOpNode::emitBytecode):
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::ReverseBinaryOpNode::emitBytecode):
- (JSC::ThrowableBinaryOpNode::emitBytecode):
- (JSC::emitReadModifyAssignment):
- (JSC::ScopeNode::ScopeNode):
- * parser/Nodes.h:
- (JSC::UnaryPlusNode::):
- (JSC::NegateNode::):
- (JSC::BitwiseNotNode::):
- (JSC::LogicalNotNode::):
- (JSC::MultNode::):
- (JSC::DivNode::):
- (JSC::ModNode::):
- (JSC::AddNode::):
- (JSC::SubNode::):
- (JSC::LeftShiftNode::):
- (JSC::RightShiftNode::):
- (JSC::UnsignedRightShiftNode::):
- (JSC::LessNode::):
- (JSC::GreaterNode::):
- (JSC::LessEqNode::):
- (JSC::GreaterEqNode::):
- (JSC::InstanceOfNode::):
- (JSC::InNode::):
- (JSC::EqualNode::):
- (JSC::NotEqualNode::):
- (JSC::StrictEqualNode::):
- (JSC::NotStrictEqualNode::):
- (JSC::BitAndNode::):
- (JSC::BitOrNode::):
- (JSC::BitXOrNode::):
- * runtime/StructureID.cpp:
- (JSC::StructureID::fromDictionaryTransition):
- * wtf/Platform.h:
+ Update logic to allow native function caching
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renames:
-
- CodeGenerator => BytecodeGenerator
- emitCodeForBlock => emitBytecodeForBlock
- generatedByteCode => generatedBytecode
- generateCode => generateBytecode
-
- * JavaScriptCore.exp:
- * bytecompiler/CodeGenerator.cpp:
- (JSC::BytecodeGenerator::setDumpsGeneratedCode):
- (JSC::BytecodeGenerator::generate):
- (JSC::BytecodeGenerator::addVar):
- (JSC::BytecodeGenerator::addGlobalVar):
- (JSC::BytecodeGenerator::allocateConstants):
- (JSC::BytecodeGenerator::BytecodeGenerator):
- (JSC::BytecodeGenerator::addParameter):
- (JSC::BytecodeGenerator::registerFor):
- (JSC::BytecodeGenerator::constRegisterFor):
- (JSC::BytecodeGenerator::isLocal):
- (JSC::BytecodeGenerator::isLocalConstant):
- (JSC::BytecodeGenerator::newRegister):
- (JSC::BytecodeGenerator::newTemporary):
- (JSC::BytecodeGenerator::highestUsedRegister):
- (JSC::BytecodeGenerator::newLabelScope):
- (JSC::BytecodeGenerator::newLabel):
- (JSC::BytecodeGenerator::emitLabel):
- (JSC::BytecodeGenerator::emitBytecode):
- (JSC::BytecodeGenerator::retrieveLastBinaryOp):
- (JSC::BytecodeGenerator::retrieveLastUnaryOp):
- (JSC::BytecodeGenerator::rewindBinaryOp):
- (JSC::BytecodeGenerator::rewindUnaryOp):
- (JSC::BytecodeGenerator::emitJump):
- (JSC::BytecodeGenerator::emitJumpIfTrue):
- (JSC::BytecodeGenerator::emitJumpIfFalse):
- (JSC::BytecodeGenerator::addConstant):
- (JSC::BytecodeGenerator::addUnexpectedConstant):
- (JSC::BytecodeGenerator::addRegExp):
- (JSC::BytecodeGenerator::emitMove):
- (JSC::BytecodeGenerator::emitUnaryOp):
- (JSC::BytecodeGenerator::emitPreInc):
- (JSC::BytecodeGenerator::emitPreDec):
- (JSC::BytecodeGenerator::emitPostInc):
- (JSC::BytecodeGenerator::emitPostDec):
- (JSC::BytecodeGenerator::emitBinaryOp):
- (JSC::BytecodeGenerator::emitEqualityOp):
- (JSC::BytecodeGenerator::emitLoad):
- (JSC::BytecodeGenerator::emitUnexpectedLoad):
- (JSC::BytecodeGenerator::findScopedProperty):
- (JSC::BytecodeGenerator::emitInstanceOf):
- (JSC::BytecodeGenerator::emitResolve):
- (JSC::BytecodeGenerator::emitGetScopedVar):
- (JSC::BytecodeGenerator::emitPutScopedVar):
- (JSC::BytecodeGenerator::emitResolveBase):
- (JSC::BytecodeGenerator::emitResolveWithBase):
- (JSC::BytecodeGenerator::emitResolveFunction):
- (JSC::BytecodeGenerator::emitGetById):
- (JSC::BytecodeGenerator::emitPutById):
- (JSC::BytecodeGenerator::emitPutGetter):
- (JSC::BytecodeGenerator::emitPutSetter):
- (JSC::BytecodeGenerator::emitDeleteById):
- (JSC::BytecodeGenerator::emitGetByVal):
- (JSC::BytecodeGenerator::emitPutByVal):
- (JSC::BytecodeGenerator::emitDeleteByVal):
- (JSC::BytecodeGenerator::emitPutByIndex):
- (JSC::BytecodeGenerator::emitNewObject):
- (JSC::BytecodeGenerator::emitNewArray):
- (JSC::BytecodeGenerator::emitNewFunction):
- (JSC::BytecodeGenerator::emitNewRegExp):
- (JSC::BytecodeGenerator::emitNewFunctionExpression):
- (JSC::BytecodeGenerator::emitCall):
- (JSC::BytecodeGenerator::emitCallEval):
- (JSC::BytecodeGenerator::emitReturn):
- (JSC::BytecodeGenerator::emitUnaryNoDstOp):
- (JSC::BytecodeGenerator::emitConstruct):
- (JSC::BytecodeGenerator::emitPushScope):
- (JSC::BytecodeGenerator::emitPopScope):
- (JSC::BytecodeGenerator::emitDebugHook):
- (JSC::BytecodeGenerator::pushFinallyContext):
- (JSC::BytecodeGenerator::popFinallyContext):
- (JSC::BytecodeGenerator::breakTarget):
- (JSC::BytecodeGenerator::continueTarget):
- (JSC::BytecodeGenerator::emitComplexJumpScopes):
- (JSC::BytecodeGenerator::emitJumpScopes):
- (JSC::BytecodeGenerator::emitNextPropertyName):
- (JSC::BytecodeGenerator::emitCatch):
- (JSC::BytecodeGenerator::emitNewError):
- (JSC::BytecodeGenerator::emitJumpSubroutine):
- (JSC::BytecodeGenerator::emitSubroutineReturn):
- (JSC::BytecodeGenerator::emitPushNewScope):
- (JSC::BytecodeGenerator::beginSwitch):
- (JSC::BytecodeGenerator::endSwitch):
- (JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):
- * bytecompiler/CodeGenerator.h:
- * jsc.cpp:
- (runWithScripts):
+ * jit/JITStubs.cpp:
* parser/Nodes.cpp:
- (JSC::ThrowableExpressionData::emitThrowError):
- (JSC::NullNode::emitBytecode):
- (JSC::BooleanNode::emitBytecode):
- (JSC::NumberNode::emitBytecode):
- (JSC::StringNode::emitBytecode):
- (JSC::RegExpNode::emitBytecode):
- (JSC::ThisNode::emitBytecode):
- (JSC::ResolveNode::isPure):
- (JSC::ResolveNode::emitBytecode):
- (JSC::ArrayNode::emitBytecode):
- (JSC::ObjectLiteralNode::emitBytecode):
- (JSC::PropertyListNode::emitBytecode):
- (JSC::BracketAccessorNode::emitBytecode):
- (JSC::DotAccessorNode::emitBytecode):
- (JSC::ArgumentListNode::emitBytecode):
- (JSC::NewExprNode::emitBytecode):
- (JSC::EvalFunctionCallNode::emitBytecode):
- (JSC::FunctionCallValueNode::emitBytecode):
- (JSC::FunctionCallResolveNode::emitBytecode):
- (JSC::FunctionCallBracketNode::emitBytecode):
- (JSC::FunctionCallDotNode::emitBytecode):
- (JSC::emitPreIncOrDec):
- (JSC::emitPostIncOrDec):
- (JSC::PostfixResolveNode::emitBytecode):
- (JSC::PostfixBracketNode::emitBytecode):
- (JSC::PostfixDotNode::emitBytecode):
- (JSC::PostfixErrorNode::emitBytecode):
- (JSC::DeleteResolveNode::emitBytecode):
- (JSC::DeleteBracketNode::emitBytecode):
- (JSC::DeleteDotNode::emitBytecode):
- (JSC::DeleteValueNode::emitBytecode):
- (JSC::VoidNode::emitBytecode):
- (JSC::TypeOfResolveNode::emitBytecode):
- (JSC::TypeOfValueNode::emitBytecode):
- (JSC::PrefixResolveNode::emitBytecode):
- (JSC::PrefixBracketNode::emitBytecode):
- (JSC::PrefixDotNode::emitBytecode):
- (JSC::PrefixErrorNode::emitBytecode):
- (JSC::UnaryOpNode::emitBytecode):
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::EqualNode::emitBytecode):
- (JSC::StrictEqualNode::emitBytecode):
- (JSC::ReverseBinaryOpNode::emitBytecode):
- (JSC::ThrowableBinaryOpNode::emitBytecode):
- (JSC::InstanceOfNode::emitBytecode):
- (JSC::LogicalOpNode::emitBytecode):
- (JSC::ConditionalNode::emitBytecode):
- (JSC::emitReadModifyAssignment):
- (JSC::ReadModifyResolveNode::emitBytecode):
- (JSC::AssignResolveNode::emitBytecode):
- (JSC::AssignDotNode::emitBytecode):
- (JSC::ReadModifyDotNode::emitBytecode):
- (JSC::AssignErrorNode::emitBytecode):
- (JSC::AssignBracketNode::emitBytecode):
- (JSC::ReadModifyBracketNode::emitBytecode):
- (JSC::CommaNode::emitBytecode):
- (JSC::ConstDeclNode::emitCodeSingle):
- (JSC::ConstDeclNode::emitBytecode):
- (JSC::ConstStatementNode::emitBytecode):
- (JSC::statementListEmitCode):
- (JSC::BlockNode::emitBytecode):
- (JSC::EmptyStatementNode::emitBytecode):
- (JSC::DebuggerStatementNode::emitBytecode):
- (JSC::ExprStatementNode::emitBytecode):
- (JSC::VarStatementNode::emitBytecode):
- (JSC::IfNode::emitBytecode):
- (JSC::IfElseNode::emitBytecode):
- (JSC::DoWhileNode::emitBytecode):
- (JSC::WhileNode::emitBytecode):
- (JSC::ForNode::emitBytecode):
- (JSC::ForInNode::emitBytecode):
- (JSC::ContinueNode::emitBytecode):
- (JSC::BreakNode::emitBytecode):
- (JSC::ReturnNode::emitBytecode):
- (JSC::WithNode::emitBytecode):
- (JSC::CaseBlockNode::emitBytecodeForBlock):
- (JSC::SwitchNode::emitBytecode):
- (JSC::LabelNode::emitBytecode):
- (JSC::ThrowNode::emitBytecode):
- (JSC::TryNode::emitBytecode):
- (JSC::EvalNode::emitBytecode):
- (JSC::EvalNode::generateBytecode):
- (JSC::FunctionBodyNode::generateBytecode):
- (JSC::FunctionBodyNode::emitBytecode):
- (JSC::ProgramNode::emitBytecode):
- (JSC::ProgramNode::generateBytecode):
- (JSC::FuncDeclNode::emitBytecode):
- (JSC::FuncExprNode::emitBytecode):
+ (JSC::FunctionBodyNode::createNativeThunk):
+ (JSC::FunctionBodyNode::isHostFunction):
* parser/Nodes.h:
- (JSC::ExpressionNode::):
- (JSC::BooleanNode::):
- (JSC::NumberNode::):
- (JSC::StringNode::):
- (JSC::ProgramNode::):
- (JSC::EvalNode::):
- (JSC::FunctionBodyNode::):
- * runtime/Arguments.h:
- (JSC::Arguments::getArgumentsData):
- (JSC::JSActivation::copyRegisters):
- * runtime/JSActivation.cpp:
- (JSC::JSActivation::mark):
- * runtime/JSActivation.h:
- (JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed all forms of "byte code" "opcode" "op code" "code" "bitcode"
- etc. to "bytecode".
-
- * VM/CTI.cpp:
- (JSC::CTI::printBytecodeOperandTypes):
- (JSC::CTI::emitAllocateNumber):
- (JSC::CTI::emitNakedCall):
- (JSC::CTI::emitNakedFastCall):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
- (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/CTI.h:
- (JSC::CallRecord::CallRecord):
- (JSC::SwitchRecord::SwitchRecord):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructureIDs):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::derefStructureIDs):
- (JSC::CodeBlock::refStructureIDs):
- * VM/CodeBlock.h:
- (JSC::StructureStubInfo::StructureStubInfo):
- * VM/ExceptionHelpers.cpp:
- (JSC::createNotAnObjectError):
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
- (JSC::Instruction::):
- * VM/Machine.cpp:
- (JSC::BytecodeInterpreter::isBytecode):
- (JSC::BytecodeInterpreter::throwException):
- (JSC::BytecodeInterpreter::execute):
- (JSC::BytecodeInterpreter::tryCachePutByID):
- (JSC::BytecodeInterpreter::uncachePutByID):
- (JSC::BytecodeInterpreter::tryCacheGetByID):
- (JSC::BytecodeInterpreter::uncacheGetByID):
- (JSC::BytecodeInterpreter::privateExecute):
- (JSC::BytecodeInterpreter::tryCTICachePutByID):
- (JSC::BytecodeInterpreter::tryCTICacheGetByID):
- (JSC::BytecodeInterpreter::cti_op_call_JSFunction):
- (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall):
- (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall):
- * VM/Machine.h:
- (JSC::BytecodeInterpreter::getBytecode):
- (JSC::BytecodeInterpreter::getBytecodeID):
- (JSC::BytecodeInterpreter::isCallBytecode):
- * VM/Opcode.cpp:
- (JSC::):
- (JSC::BytecodeStats::BytecodeStats):
- (JSC::compareBytecodeIndices):
- (JSC::compareBytecodePairIndices):
- (JSC::BytecodeStats::~BytecodeStats):
- (JSC::BytecodeStats::recordInstruction):
- (JSC::BytecodeStats::resetLastInstruction):
- * VM/Opcode.h:
- (JSC::):
- (JSC::padBytecodeName):
- * VM/SamplingTool.cpp:
- (JSC::ScopeSampleRecord::sample):
- (JSC::SamplingTool::run):
- (JSC::compareBytecodeIndicesSampling):
- (JSC::SamplingTool::dump):
- * VM/SamplingTool.h:
- (JSC::ScopeSampleRecord::ScopeSampleRecord):
- (JSC::SamplingTool::SamplingTool):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate):
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::emitLabel):
- (JSC::CodeGenerator::emitBytecode):
- (JSC::CodeGenerator::emitJump):
- (JSC::CodeGenerator::emitJumpIfTrue):
- (JSC::CodeGenerator::emitJumpIfFalse):
- (JSC::CodeGenerator::emitMove):
- (JSC::CodeGenerator::emitUnaryOp):
- (JSC::CodeGenerator::emitPreInc):
- (JSC::CodeGenerator::emitPreDec):
- (JSC::CodeGenerator::emitPostInc):
- (JSC::CodeGenerator::emitPostDec):
- (JSC::CodeGenerator::emitBinaryOp):
- (JSC::CodeGenerator::emitEqualityOp):
- (JSC::CodeGenerator::emitUnexpectedLoad):
- (JSC::CodeGenerator::emitInstanceOf):
- (JSC::CodeGenerator::emitResolve):
- (JSC::CodeGenerator::emitGetScopedVar):
- (JSC::CodeGenerator::emitPutScopedVar):
- (JSC::CodeGenerator::emitResolveBase):
- (JSC::CodeGenerator::emitResolveWithBase):
- (JSC::CodeGenerator::emitResolveFunction):
- (JSC::CodeGenerator::emitGetById):
- (JSC::CodeGenerator::emitPutById):
- (JSC::CodeGenerator::emitPutGetter):
- (JSC::CodeGenerator::emitPutSetter):
- (JSC::CodeGenerator::emitDeleteById):
- (JSC::CodeGenerator::emitGetByVal):
- (JSC::CodeGenerator::emitPutByVal):
- (JSC::CodeGenerator::emitDeleteByVal):
- (JSC::CodeGenerator::emitPutByIndex):
- (JSC::CodeGenerator::emitNewObject):
- (JSC::CodeGenerator::emitNewArray):
- (JSC::CodeGenerator::emitNewFunction):
- (JSC::CodeGenerator::emitNewRegExp):
- (JSC::CodeGenerator::emitNewFunctionExpression):
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitReturn):
- (JSC::CodeGenerator::emitUnaryNoDstOp):
- (JSC::CodeGenerator::emitConstruct):
- (JSC::CodeGenerator::emitPopScope):
- (JSC::CodeGenerator::emitDebugHook):
- (JSC::CodeGenerator::emitComplexJumpScopes):
- (JSC::CodeGenerator::emitJumpScopes):
- (JSC::CodeGenerator::emitNextPropertyName):
- (JSC::CodeGenerator::emitCatch):
- (JSC::CodeGenerator::emitNewError):
- (JSC::CodeGenerator::emitJumpSubroutine):
- (JSC::CodeGenerator::emitSubroutineReturn):
- (JSC::CodeGenerator::emitPushNewScope):
- (JSC::CodeGenerator::beginSwitch):
- (JSC::CodeGenerator::endSwitch):
- * bytecompiler/CodeGenerator.h:
- (JSC::CodeGenerator::emitNode):
- * jsc.cpp:
- (runWithScripts):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::emitModRm_opr):
- (JSC::X86Assembler::emitModRm_opr_Unchecked):
- (JSC::X86Assembler::emitModRm_opm):
- (JSC::X86Assembler::emitModRm_opm_Unchecked):
- (JSC::X86Assembler::emitModRm_opmsib):
- * parser/Nodes.cpp:
- (JSC::NullNode::emitBytecode):
- (JSC::BooleanNode::emitBytecode):
- (JSC::NumberNode::emitBytecode):
- (JSC::StringNode::emitBytecode):
- (JSC::RegExpNode::emitBytecode):
- (JSC::ThisNode::emitBytecode):
- (JSC::ResolveNode::emitBytecode):
- (JSC::ArrayNode::emitBytecode):
- (JSC::ObjectLiteralNode::emitBytecode):
- (JSC::PropertyListNode::emitBytecode):
- (JSC::BracketAccessorNode::emitBytecode):
- (JSC::DotAccessorNode::emitBytecode):
- (JSC::ArgumentListNode::emitBytecode):
- (JSC::NewExprNode::emitBytecode):
- (JSC::EvalFunctionCallNode::emitBytecode):
- (JSC::FunctionCallValueNode::emitBytecode):
- (JSC::FunctionCallResolveNode::emitBytecode):
- (JSC::FunctionCallBracketNode::emitBytecode):
- (JSC::FunctionCallDotNode::emitBytecode):
- (JSC::PostfixResolveNode::emitBytecode):
- (JSC::PostfixBracketNode::emitBytecode):
- (JSC::PostfixDotNode::emitBytecode):
- (JSC::PostfixErrorNode::emitBytecode):
- (JSC::DeleteResolveNode::emitBytecode):
- (JSC::DeleteBracketNode::emitBytecode):
- (JSC::DeleteDotNode::emitBytecode):
- (JSC::DeleteValueNode::emitBytecode):
- (JSC::VoidNode::emitBytecode):
- (JSC::TypeOfResolveNode::emitBytecode):
- (JSC::TypeOfValueNode::emitBytecode):
- (JSC::PrefixResolveNode::emitBytecode):
- (JSC::PrefixBracketNode::emitBytecode):
- (JSC::PrefixDotNode::emitBytecode):
- (JSC::PrefixErrorNode::emitBytecode):
- (JSC::UnaryOpNode::emitBytecode):
- (JSC::BinaryOpNode::emitBytecode):
- (JSC::EqualNode::emitBytecode):
- (JSC::StrictEqualNode::emitBytecode):
- (JSC::ReverseBinaryOpNode::emitBytecode):
- (JSC::ThrowableBinaryOpNode::emitBytecode):
- (JSC::InstanceOfNode::emitBytecode):
- (JSC::LogicalOpNode::emitBytecode):
- (JSC::ConditionalNode::emitBytecode):
- (JSC::emitReadModifyAssignment):
- (JSC::ReadModifyResolveNode::emitBytecode):
- (JSC::AssignResolveNode::emitBytecode):
- (JSC::AssignDotNode::emitBytecode):
- (JSC::ReadModifyDotNode::emitBytecode):
- (JSC::AssignErrorNode::emitBytecode):
- (JSC::AssignBracketNode::emitBytecode):
- (JSC::ReadModifyBracketNode::emitBytecode):
- (JSC::CommaNode::emitBytecode):
- (JSC::ConstDeclNode::emitBytecode):
- (JSC::ConstStatementNode::emitBytecode):
- (JSC::BlockNode::emitBytecode):
- (JSC::EmptyStatementNode::emitBytecode):
- (JSC::DebuggerStatementNode::emitBytecode):
- (JSC::ExprStatementNode::emitBytecode):
- (JSC::VarStatementNode::emitBytecode):
- (JSC::IfNode::emitBytecode):
- (JSC::IfElseNode::emitBytecode):
- (JSC::DoWhileNode::emitBytecode):
- (JSC::WhileNode::emitBytecode):
- (JSC::ForNode::emitBytecode):
- (JSC::ForInNode::emitBytecode):
- (JSC::ContinueNode::emitBytecode):
- (JSC::BreakNode::emitBytecode):
- (JSC::ReturnNode::emitBytecode):
- (JSC::WithNode::emitBytecode):
- (JSC::SwitchNode::emitBytecode):
- (JSC::LabelNode::emitBytecode):
- (JSC::ThrowNode::emitBytecode):
- (JSC::TryNode::emitBytecode):
- (JSC::ScopeNode::ScopeNode):
- (JSC::EvalNode::emitBytecode):
- (JSC::FunctionBodyNode::emitBytecode):
- (JSC::ProgramNode::emitBytecode):
- (JSC::FuncDeclNode::emitBytecode):
- (JSC::FuncExprNode::emitBytecode):
- * parser/Nodes.h:
- (JSC::UnaryPlusNode::):
- (JSC::NegateNode::):
- (JSC::BitwiseNotNode::):
- (JSC::LogicalNotNode::):
- (JSC::MultNode::):
- (JSC::DivNode::):
- (JSC::ModNode::):
- (JSC::AddNode::):
- (JSC::SubNode::):
- (JSC::LeftShiftNode::):
- (JSC::RightShiftNode::):
- (JSC::UnsignedRightShiftNode::):
- (JSC::LessNode::):
- (JSC::GreaterNode::):
- (JSC::LessEqNode::):
- (JSC::GreaterEqNode::):
- (JSC::InstanceOfNode::):
- (JSC::InNode::):
- (JSC::EqualNode::):
- (JSC::NotEqualNode::):
- (JSC::StrictEqualNode::):
- (JSC::NotStrictEqualNode::):
- (JSC::BitAndNode::):
- (JSC::BitOrNode::):
- (JSC::BitXOrNode::):
- (JSC::ProgramNode::):
- (JSC::EvalNode::):
- (JSC::FunctionBodyNode::):
- * runtime/JSNotAnObject.h:
- * runtime/StructureID.cpp:
- (JSC::StructureID::fromDictionaryTransition):
- * wtf/Platform.h:
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Renamed Machine to BytecodeInterpreter.
-
- Nixed the Interpreter class, and changed its two functions to stand-alone
- functions.
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::freeCTIMachineTrampolines):
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructureIDs):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::derefStructureIDs):
- (JSC::CodeBlock::refStructureIDs):
- * VM/ExceptionHelpers.cpp:
- (JSC::createNotAnObjectError):
- * VM/Machine.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::BytecodeInterpreter::resolve):
- (JSC::BytecodeInterpreter::resolveSkip):
- (JSC::BytecodeInterpreter::resolveGlobal):
- (JSC::BytecodeInterpreter::resolveBase):
- (JSC::BytecodeInterpreter::resolveBaseAndProperty):
- (JSC::BytecodeInterpreter::resolveBaseAndFunc):
- (JSC::BytecodeInterpreter::slideRegisterWindowForCall):
- (JSC::BytecodeInterpreter::callEval):
- (JSC::BytecodeInterpreter::BytecodeInterpreter):
- (JSC::BytecodeInterpreter::initialize):
- (JSC::BytecodeInterpreter::~BytecodeInterpreter):
- (JSC::BytecodeInterpreter::dumpCallFrame):
- (JSC::BytecodeInterpreter::dumpRegisters):
- (JSC::BytecodeInterpreter::isOpcode):
- (JSC::BytecodeInterpreter::unwindCallFrame):
- (JSC::BytecodeInterpreter::throwException):
- (JSC::BytecodeInterpreter::execute):
- (JSC::BytecodeInterpreter::debug):
- (JSC::BytecodeInterpreter::resetTimeoutCheck):
- (JSC::BytecodeInterpreter::checkTimeout):
- (JSC::BytecodeInterpreter::createExceptionScope):
- (JSC::BytecodeInterpreter::tryCachePutByID):
- (JSC::BytecodeInterpreter::uncachePutByID):
- (JSC::BytecodeInterpreter::tryCacheGetByID):
- (JSC::BytecodeInterpreter::uncacheGetByID):
- (JSC::BytecodeInterpreter::privateExecute):
- (JSC::BytecodeInterpreter::retrieveArguments):
- (JSC::BytecodeInterpreter::retrieveCaller):
- (JSC::BytecodeInterpreter::retrieveLastCaller):
- (JSC::BytecodeInterpreter::findFunctionCallFrame):
- (JSC::BytecodeInterpreter::tryCTICachePutByID):
- (JSC::BytecodeInterpreter::tryCTICacheGetByID):
- (JSC::BytecodeInterpreter::cti_op_convert_this):
- (JSC::BytecodeInterpreter::cti_op_end):
- (JSC::BytecodeInterpreter::cti_op_add):
- (JSC::BytecodeInterpreter::cti_op_pre_inc):
- (JSC::BytecodeInterpreter::cti_timeout_check):
- (JSC::BytecodeInterpreter::cti_register_file_check):
- (JSC::BytecodeInterpreter::cti_op_loop_if_less):
- (JSC::BytecodeInterpreter::cti_op_loop_if_lesseq):
- (JSC::BytecodeInterpreter::cti_op_new_object):
- (JSC::BytecodeInterpreter::cti_op_put_by_id):
- (JSC::BytecodeInterpreter::cti_op_put_by_id_second):
- (JSC::BytecodeInterpreter::cti_op_put_by_id_generic):
- (JSC::BytecodeInterpreter::cti_op_put_by_id_fail):
- (JSC::BytecodeInterpreter::cti_op_get_by_id):
- (JSC::BytecodeInterpreter::cti_op_get_by_id_second):
- (JSC::BytecodeInterpreter::cti_op_get_by_id_generic):
- (JSC::BytecodeInterpreter::cti_op_get_by_id_fail):
- (JSC::BytecodeInterpreter::cti_op_instanceof):
- (JSC::BytecodeInterpreter::cti_op_del_by_id):
- (JSC::BytecodeInterpreter::cti_op_mul):
- (JSC::BytecodeInterpreter::cti_op_new_func):
- (JSC::BytecodeInterpreter::cti_op_call_JSFunction):
- (JSC::BytecodeInterpreter::cti_op_call_arityCheck):
- (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall):
- (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall):
- (JSC::BytecodeInterpreter::cti_op_push_activation):
- (JSC::BytecodeInterpreter::cti_op_call_NotJSFunction):
- (JSC::BytecodeInterpreter::cti_op_create_arguments):
- (JSC::BytecodeInterpreter::cti_op_create_arguments_no_params):
- (JSC::BytecodeInterpreter::cti_op_tear_off_activation):
- (JSC::BytecodeInterpreter::cti_op_tear_off_arguments):
- (JSC::BytecodeInterpreter::cti_op_profile_will_call):
- (JSC::BytecodeInterpreter::cti_op_profile_did_call):
- (JSC::BytecodeInterpreter::cti_op_ret_scopeChain):
- (JSC::BytecodeInterpreter::cti_op_new_array):
- (JSC::BytecodeInterpreter::cti_op_resolve):
- (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct):
- (JSC::BytecodeInterpreter::cti_op_construct_NotJSConstruct):
- (JSC::BytecodeInterpreter::cti_op_get_by_val):
- (JSC::BytecodeInterpreter::cti_op_resolve_func):
- (JSC::BytecodeInterpreter::cti_op_sub):
- (JSC::BytecodeInterpreter::cti_op_put_by_val):
- (JSC::BytecodeInterpreter::cti_op_put_by_val_array):
- (JSC::BytecodeInterpreter::cti_op_lesseq):
- (JSC::BytecodeInterpreter::cti_op_loop_if_true):
- (JSC::BytecodeInterpreter::cti_op_negate):
- (JSC::BytecodeInterpreter::cti_op_resolve_base):
- (JSC::BytecodeInterpreter::cti_op_resolve_skip):
- (JSC::BytecodeInterpreter::cti_op_resolve_global):
- (JSC::BytecodeInterpreter::cti_op_div):
- (JSC::BytecodeInterpreter::cti_op_pre_dec):
- (JSC::BytecodeInterpreter::cti_op_jless):
- (JSC::BytecodeInterpreter::cti_op_not):
- (JSC::BytecodeInterpreter::cti_op_jtrue):
- (JSC::BytecodeInterpreter::cti_op_post_inc):
- (JSC::BytecodeInterpreter::cti_op_eq):
- (JSC::BytecodeInterpreter::cti_op_lshift):
- (JSC::BytecodeInterpreter::cti_op_bitand):
- (JSC::BytecodeInterpreter::cti_op_rshift):
- (JSC::BytecodeInterpreter::cti_op_bitnot):
- (JSC::BytecodeInterpreter::cti_op_resolve_with_base):
- (JSC::BytecodeInterpreter::cti_op_new_func_exp):
- (JSC::BytecodeInterpreter::cti_op_mod):
- (JSC::BytecodeInterpreter::cti_op_less):
- (JSC::BytecodeInterpreter::cti_op_neq):
- (JSC::BytecodeInterpreter::cti_op_post_dec):
- (JSC::BytecodeInterpreter::cti_op_urshift):
- (JSC::BytecodeInterpreter::cti_op_bitxor):
- (JSC::BytecodeInterpreter::cti_op_new_regexp):
- (JSC::BytecodeInterpreter::cti_op_bitor):
- (JSC::BytecodeInterpreter::cti_op_call_eval):
- (JSC::BytecodeInterpreter::cti_op_throw):
- (JSC::BytecodeInterpreter::cti_op_get_pnames):
- (JSC::BytecodeInterpreter::cti_op_next_pname):
- (JSC::BytecodeInterpreter::cti_op_push_scope):
- (JSC::BytecodeInterpreter::cti_op_pop_scope):
- (JSC::BytecodeInterpreter::cti_op_typeof):
- (JSC::BytecodeInterpreter::cti_op_is_undefined):
- (JSC::BytecodeInterpreter::cti_op_is_boolean):
- (JSC::BytecodeInterpreter::cti_op_is_number):
- (JSC::BytecodeInterpreter::cti_op_is_string):
- (JSC::BytecodeInterpreter::cti_op_is_object):
- (JSC::BytecodeInterpreter::cti_op_is_function):
- (JSC::BytecodeInterpreter::cti_op_stricteq):
- (JSC::BytecodeInterpreter::cti_op_nstricteq):
- (JSC::BytecodeInterpreter::cti_op_to_jsnumber):
- (JSC::BytecodeInterpreter::cti_op_in):
- (JSC::BytecodeInterpreter::cti_op_push_new_scope):
- (JSC::BytecodeInterpreter::cti_op_jmp_scopes):
- (JSC::BytecodeInterpreter::cti_op_put_by_index):
- (JSC::BytecodeInterpreter::cti_op_switch_imm):
- (JSC::BytecodeInterpreter::cti_op_switch_char):
- (JSC::BytecodeInterpreter::cti_op_switch_string):
- (JSC::BytecodeInterpreter::cti_op_del_by_val):
- (JSC::BytecodeInterpreter::cti_op_put_getter):
- (JSC::BytecodeInterpreter::cti_op_put_setter):
- (JSC::BytecodeInterpreter::cti_op_new_error):
- (JSC::BytecodeInterpreter::cti_op_debug):
- (JSC::BytecodeInterpreter::cti_vm_throw):
- * VM/Machine.h:
- * VM/Register.h:
- * VM/SamplingTool.cpp:
- (JSC::SamplingTool::run):
- * VM/SamplingTool.h:
- (JSC::SamplingTool::SamplingTool):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate):
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::emitOpcode):
- * debugger/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate):
- * jsc.cpp:
- (runWithScripts):
- * parser/Nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
- * profiler/ProfileGenerator.cpp:
- (JSC::ProfileGenerator::addParentForConsoleStart):
- * runtime/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncPop):
- (JSC::arrayProtoFuncPush):
- * runtime/Collector.cpp:
- (JSC::Heap::collect):
- * runtime/ExecState.h:
- (JSC::ExecState::interpreter):
- * runtime/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- * runtime/Interpreter.cpp:
- (JSC::Interpreter::evaluate):
- * runtime/JSCell.h:
- * runtime/JSFunction.cpp:
- (JSC::JSFunction::call):
- (JSC::JSFunction::argumentsGetter):
- (JSC::JSFunction::callerGetter):
- (JSC::JSFunction::construct):
- * runtime/JSFunction.h:
+ (JSC::JSFunction::mark):
* runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
- * runtime/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::~JSGlobalObject):
- (JSC::JSGlobalObject::setTimeoutTime):
- (JSC::JSGlobalObject::startTimeoutCheck):
- (JSC::JSGlobalObject::stopTimeoutCheck):
- (JSC::JSGlobalObject::mark):
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval):
- * runtime/JSString.h:
- * runtime/RegExp.cpp:
- (JSC::RegExp::RegExp):
-
-2008-11-15 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Sam Weinig.
-
- - Remove SymbolTable from FunctionBodyNode and move it to CodeBlock
-
- It's not needed for functions that have never been executed, so no
- need to waste the memory. Saves ~4M on membuster after 30 pages.
-
- * VM/CodeBlock.h:
- * VM/Machine.cpp:
- (JSC::Machine::retrieveArguments):
- * parser/Nodes.cpp:
- (JSC::EvalNode::generateCode):
- (JSC::FunctionBodyNode::generateCode):
- * parser/Nodes.h:
- * runtime/JSActivation.h:
- (JSC::JSActivation::JSActivationData::JSActivationData):
-
-2008-11-14 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22259: Make all opcodes use eax as their final result register
- <https://bugs.webkit.org/show_bug.cgi?id=22259>
-
- Change one case of op_add (and the corresponding slow case) to use eax
- rather than edx. Also, change the order in which the two results of
- resolve_func and resolve_base are emitted so that the retrieved value is
- put last into eax.
-
- This gives no performance change on SunSpider or the V8 benchmark suite
- when run in either harness.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
-
-2008-11-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Geoff has this wacky notion that emitGetArg and emitPutArg should be related to
- doing the same thing. Crazy.
-
- Rename the methods for accessing virtual registers to say 'VirtualRegister' in the
- name, and those for setting up the arguments for CTI methods to contain 'CTIArg'.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetVirtualRegister):
- (JSC::CTI::emitGetVirtualRegisters):
- (JSC::CTI::emitPutCTIArgFromVirtualRegister):
- (JSC::CTI::emitPutCTIArg):
- (JSC::CTI::emitGetCTIArg):
- (JSC::CTI::emitPutCTIArgConstant):
- (JSC::CTI::emitPutVirtualRegister):
- (JSC::CTI::compileOpCallSetupArgs):
- (JSC::CTI::compileOpCallEvalSetupArgs):
- (JSC::CTI::compileOpConstructSetupArgs):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- * VM/CTI.h:
-
-2008-11-14 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Antti Koivisto
-
- Fix potential build break by adding StdLibExtras.h
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
-
-2008-11-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Generate less code for the slow cases of op_call and op_construct.
- https://bugs.webkit.org/show_bug.cgi?id=22272
-
- 1% progression on v8 tests.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitRetrieveArg):
- (JSC::CTI::emitNakedCall):
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- (JSC::getCallLinkInfoReturnLocation):
- (JSC::CodeBlock::getCallLinkInfo):
- * VM/Machine.cpp:
- (JSC::Machine::Machine):
- (JSC::Machine::cti_vm_dontLazyLinkCall):
- (JSC::Machine::cti_vm_lazyLinkCall):
- * VM/Machine.h:
-
-2008-11-14 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Alder.
-
- https://bugs.webkit.org/show_bug.cgi?id=21810
- Remove use of static C++ objects that are destroyed at exit time (destructors)
-
- Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
- exit-time destructor. Update code that was changed to fix this issue that ran
- into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
- in gcc build 5465). Also typdefs for template types needed to be added in some
- cases so the type could make it through the macro successfully.
-
- Basically code of the form:
- static T m;
- becomes:
- DEFINE_STATIC_LOCAL(T, m, ());
-
- Also any code of the form:
- static T& m = *new T;
- also becomes:
- DEFINE_STATIC_LOCAL(T, m, ());
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * wtf/MainThread.cpp:
- (WTF::mainThreadFunctionQueueMutex):
- (WTF::functionQueue):
- * wtf/StdLibExtras.h: Added. Add DEFINE_STATIC_LOCAL macro
- * wtf/ThreadingPthreads.cpp:
- (WTF::threadMapMutex):
- (WTF::threadMap):
- (WTF::identifierByPthreadHandle):
-
-2008-11-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22269
- Reduce PropertyMap usage
-
- From observation of StructureID statistics, it became clear that many
- StructureID's were not being used as StructureIDs themselves, but rather
- only being necessary as links in the transition chain. Acknowledging this
- and that PropertyMaps stored in StructureIDs can be treated as caches, that
- is that they can be reconstructed on demand, it became clear that we could
- reduce the memory consumption of StructureIDs by only keeping PropertyMaps
- for the StructureIDs that need them the most.
-
- The specific strategy used to reduce the number of StructureIDs with
- PropertyMaps is to take the previous StructureIDs PropertyMap when initially
- transitioning (addPropertyTransition) from it and clearing out the pointer
- in the process. The next time we need to do the same transition, for instance
- repeated calls to the same constructor, we use the new addPropertyTransitionToExistingStructure
- first, which allows us not to need the PropertyMap to determine if the property
- exists already, since a transition to that property would require it not already
- be present in the StructureID. Should there be no transition, the PropertyMap
- can be constructed on demand (via materializePropertyMap) to determine if the put is a
- replace or a transition to a new StructureID.
-
- Reduces memory use on Membuster head test (30 pages open) by ~15MB.
-
- * JavaScriptCore.exp:
- * runtime/JSObject.h:
- (JSC::JSObject::putDirect): First use addPropertyTransitionToExistingStructure
- so that we can avoid building the PropertyMap on subsequent similar object
- creations.
- * runtime/PropertyMapHashTable.h:
- (JSC::PropertyMapEntry::PropertyMapEntry): Add version of constructor which takes
- all values to be used when lazily building the PropertyMap.
- * runtime/StructureID.cpp:
- (JSC::StructureID::dumpStatistics): Add statistics on the number of StructureIDs
- with PropertyMaps.
- (JSC::StructureID::StructureID): Rename m_cachedTransistionOffset to m_offset
- (JSC::isPowerOf2):
- (JSC::nextPowerOf2):
- (JSC::sizeForKeyCount): Returns the expected size of a PropertyMap for a key count.
- (JSC::StructureID::materializePropertyMap): Builds the PropertyMap out of its previous pointer chain.
- (JSC::StructureID::addPropertyTransitionToExistingStructure): Only transitions if there is a
- an existing transition.
- (JSC::StructureID::addPropertyTransition): Instead of always copying the ProperyMap, try and take
- it from it previous pointer.
- (JSC::StructureID::removePropertyTransition): Simplify by calling toDictionaryTransition() to do
- transition work.
- (JSC::StructureID::changePrototypeTransition): Build the PropertyMap if necessary before transitioning
- because once you have transitioned, you will not be able to reconstruct it afterwards as there is no
- previous pointer, pinning the ProperyMap as well.
- (JSC::StructureID::getterSetterTransition): Ditto.
- (JSC::StructureID::toDictionaryTransition): Pin the PropertyMap so that it is not destroyed on further transitions.
- (JSC::StructureID::fromDictionaryTransition): We can only transition back from a dictionary transition if there
- are no deleted offsets.
- (JSC::StructureID::addPropertyWithoutTransition): Build PropertyMap on demands and pin.
- (JSC::StructureID::removePropertyWithoutTransition): Ditto.
- (JSC::StructureID::get): Build on demand.
- (JSC::StructureID::createPropertyMapHashTable): Add version of create that takes a size
- for on demand building.
- (JSC::StructureID::expandPropertyMapHashTable):
- (JSC::StructureID::rehashPropertyMapHashTable):
- (JSC::StructureID::getEnumerablePropertyNamesInternal): Build PropertyMap on demand.
- * runtime/StructureID.h:
- (JSC::StructureID::propertyStorageSize): Account for StructureIDs without PropertyMaps.
- (JSC::StructureID::isEmpty): Ditto.
- (JSC::StructureID::materializePropertyMapIfNecessary):
- (JSC::StructureID::get): Build PropertyMap on demand
-
-2008-11-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
-
- Reviewed by Simon Hausmann.
-
- <https://bugs.webkit.org/show_bug.cgi?id=21500>
-
- JavaScriptCore build with -O3 flag instead of -O2 (gcc).
- 2.02% speedup on SunSpider (Qt-port on Linux)
- 1.10% speedup on V8 (Qt-port on Linux)
- 3.45% speedup on WindScorpion (Qt-port on Linux)
-
- * JavaScriptCore.pri:
-
-2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>
-
- Reviewed by Darin Adler.
-
- Compile fix for RVCT.
-
- In reality, it is two fixes:
-
- 1. Remove typename. I believe typename can only be used when the named
- type depends on the template parameters, which it doesn't in this
- case, so I think this is more correct.
- 2. Replace ::iterator scope with specialized typedef. This is to work
- around a bug in RVCT.
-
- https://bugs.webkit.org/show_bug.cgi?id=22260
-
- * wtf/ListHashSet.h:
- (WTF::::find):
-
-2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>
-
- Reviewed by Darin Adler.
-
- Compile fix for WINSCW.
-
- This fix doesn't protect against implicit conversions from bool to
- integers, but most likely that will be caught on another platform.
-
- https://bugs.webkit.org/show_bug.cgi?id=22260
-
- * wtf/PassRefPtr.h:
- (WTF::PassRefPtr::operator bool):
- * wtf/RefPtr.h:
- (WTF::RefPtr::operator bool):
-
-2008-11-14 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22245: Move wtf/dtoa.h into the WTF namespace
- <https://bugs.webkit.org/show_bug.cgi?id=22245>
-
- Move wtf/dtoa.h into the WTF namespace from the JSC namespace. This
- introduces some ambiguities in name lookups, so I changed all uses of
- the functions in wtf/dtoa.h to explicitly state the namespace.
-
- * JavaScriptCore.exp:
- * parser/Lexer.cpp:
- (JSC::Lexer::lex):
- * runtime/InitializeThreading.cpp:
- * runtime/JSGlobalObjectFunctions.cpp:
- (JSC::parseInt):
- * runtime/NumberPrototype.cpp:
- (JSC::integerPartNoExp):
- (JSC::numberProtoFuncToExponential):
- * runtime/UString.cpp:
- (JSC::concatenate):
- (JSC::UString::from):
- (JSC::UString::toDouble):
- * wtf/dtoa.cpp:
- * wtf/dtoa.h:
-
-2008-11-14 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 22257: Enable redundant read optimizations for results generated by compileBinaryArithOp()
- <https://bugs.webkit.org/show_bug.cgi?id=22257>
-
- This shows no change in performance on either SunSpider or the V8
- benchmark suite, but it removes an ugly special case and allows for
- future optimizations to be implemented in a cleaner fashion.
-
- This patch was essentially given to me by Gavin Barraclough upon my
- request, but I did regression and performance testing so that he could
- work on something else.
-
- * VM/CTI.cpp:
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): Move the final
- result to eax if it is not already there.
- (JSC::CTI::compileBinaryArithOp): Remove the killing of the final result
- register that disables the optimization.
-
-2008-11-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Adam Roben.
-
- Add a Scons-based build system for building
- the Chromium-Mac build of JavaScriptCore.
- https://bugs.webkit.org/show_bug.cgi?id=21991
-
- * JavaScriptCore.scons: Added.
- * SConstruct: Added.
-
-2008-11-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Adam Roben.
-
- Add PLATFORM(CHROMIUM) to the "we don't use cairo" blacklist
- until https://bugs.webkit.org/show_bug.cgi?id=22250 is fixed.
-
- * wtf/Platform.h:
-
-2008-11-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- In r38375 the 'jsc' shell was changed to improve teardown on quit. The
- main() function in jsc.cpp uses Structured Exception Handling, so Visual
- C++ emits a warning when destructors are used.
-
- In order to speculatively fix the Windows build, this patch changes that
- code to use explicit pointer manipulation and locking rather than smart
- pointers and RAII.
-
- * jsc.cpp:
- (main):
-
-2008-11-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22246: Get arguments for opcodes together to eliminate more redundant memory reads
- <https://bugs.webkit.org/show_bug.cgi?id=22246>
-
- It is common for opcodes to read their first operand into eax and their
- second operand into edx. If the value intended for the second operand is
- in eax, we should first move eax to the register for the second operand
- and then read the first operand into eax.
-
- This is a 0.5% speedup on SunSpider and a 2.0% speedup on the V8
- benchmark suite when measured using the V8 harness.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArgs):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
-
-2008-11-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22238: Avoid unnecessary reads of temporaries when the target machine register is not eax
- <https://bugs.webkit.org/show_bug.cgi?id=22238>
-
- Enable the optimization of not reading a value back from memory that we
- just wrote when the target machine register is not eax. In order to do
- this, the code generation for op_put_global_var must be changed to
- read its argument into a register before overwriting eax.
-
- This is a 0.5% speedup on SunSpider and shows no change on the V8
- benchmark suite when run in either harness.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::privateCompileMainPass):
-
-2008-11-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Perform teardown in the 'jsc' shell in order to suppress annoying and
- misleading leak messages. There is still a lone JSC::Node leaking when
- quit() is called, but hopefully that can be fixed as well.
-
- * jsc.cpp:
- (functionQuit):
- (main):
-
-2008-11-13 Mike Pinkerton <pinkerton@chromium.org>
-
- Reviewed by Sam Weinig.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22087
- Need correct platform defines for Mac Chromium
-
- Set the appropriate platform defines for Mac Chromium, which is
- similar to PLATFORM(MAC), but isn't.
-
- * wtf/Platform.h:
-
-2008-11-13 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - remove immediate checks from native codegen for known non-immediate cases like "this"
-
- ~.5% speedup on v8 benchmarks
-
- In the future we can extend this model to remove all sorts of
- typechecks based on local type info or type inference.
-
- I also added an assertion to verify that all slow cases linked as
- many slow case jumps as the corresponding fast case generated, and
- fixed the pre-existing cases where this was not true.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::linkSlowCaseIfNotJSCell):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- (JSC::CodeBlock::isKnownNotImmediate):
-
-2008-11-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21943: Avoid needless reads of temporary values in CTI code
- <https://bugs.webkit.org/show_bug.cgi?id=21943>
-
- If an opcode needs to load a virtual register and a previous opcode left
- the contents of that virtual register in a machine register, use the
- value in the machine register rather than getting it from memory.
-
- In order to perform this optimization, it is necessary to know the
- jump tagets in the CodeBlock. For temporaries, the only problematic
- jump targets are binary logical operators and the ternary conditional
- operator. However, if this optimization were to be extended to local
- variable registers as well, other jump targets would need to be
- included, like switch statement cases and the beginnings of catch
- blocks.
-
- This optimization also requires that the fast case and the slow case
- of an opcode use emitPutResult() on the same register, which was chosen
- to be eax, as that is the register into which we read the first operand
- of opcodes. In order to make this the case, we needed to add some mov
- instructions to the slow cases of some instructions.
-
- This optimizaton is not applied whenever compileBinaryArithOp() is used
- to compile an opcode, because different machine registers may be used to
- store the final result. It seems possible to rewrite the code generation
- in compileBinaryArithOp() to allow for this optimization.
-
- This optimization is also not applied when generating slow cases,
- because some fast cases overwrite the value of eax before jumping to the
- slow case. In the future, it may be possible to apply this optimization
- to slow cases as well, but it did not seem to be a speedup when testing
- an early version of this patch.
-
- This is a 1.0% speedup on SunSpider and a 6.3% speedup on the V8
- benchmark suite.
-
- * VM/CTI.cpp:
- (JSC::CTI::killLastResultRegister):
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutResult):
- (JSC::CTI::emitCTICall):
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileOpStrictEq):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- (JSC::CodeBlock::isTemporaryRegisterIndex):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitLabel):
-
-2008-11-12 Alp Toker <alp@nuanti.com>
-
- autotools build system fix-up only. Add FloatQuad.h to the source
- lists and sort them.
-
- * GNUmakefile.am:
-
-2008-11-12 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22192
- +37 failures in fast/profiler
-
- along with Darin's review comments in
- https://bugs.webkit.org/show_bug.cgi?id=22174
- Simplified op_call by nixing its responsibility for moving the value of
- "this" into the first argument slot
-
- * VM/Machine.cpp:
- (JSC::returnToThrowTrampoline):
- (JSC::throwStackOverflowError):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_call_arityCheck):
- (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since
- functions are better than macros.
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitConstruct): Ensure that the function register
- is preserved if profiling is enabled, since the profiler uses that
- register.
-
- * runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation,
- because I had a hard time understanding what "throwReturnAddress" meant.
-
-2008-11-12 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Roll in r38322, now that test failures have been fixed.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCallSetupArgs):
- (JSC::CTI::compileOpCallEvalSetupArgs):
- (JSC::CTI::compileOpConstructSetupArgs):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/Machine.cpp:
- (JSC::Machine::callEval):
- (JSC::Machine::dumpCallFrame):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::execute):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_call_arityCheck):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitCallEval):
- (JSC::CodeGenerator::emitConstruct):
- * bytecompiler/CodeGenerator.h:
- * parser/Nodes.cpp:
- (JSC::EvalFunctionCallNode::emitCode):
- (JSC::FunctionCallValueNode::emitCode):
- (JSC::FunctionCallResolveNode::emitCode):
- (JSC::FunctionCallBracketNode::emitCode):
- (JSC::FunctionCallDotNode::emitCode):
- * parser/Nodes.h:
- (JSC::ScopeNode::neededConstants):
-
-2008-11-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22201
- Integer conversion in array.length was safe signed values,
- but the length is unsigned.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompilePatchGetArrayLength):
-
-2008-11-12 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Mark Rowe.
-
- Roll out r38322 due to test failures on the bots.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCallSetupArgs):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/Machine.cpp:
- (JSC::Machine::callEval):
- (JSC::Machine::dumpCallFrame):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::execute):
- (JSC::Machine::privateExecute):
- (JSC::Machine::throwStackOverflowPreviousFrame):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_call_arityCheck):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitCallEval):
- (JSC::CodeGenerator::emitConstruct):
- * bytecompiler/CodeGenerator.h:
- * parser/Nodes.cpp:
- (JSC::EvalFunctionCallNode::emitCode):
- (JSC::FunctionCallValueNode::emitCode):
- (JSC::FunctionCallResolveNode::emitCode):
- (JSC::FunctionCallBracketNode::emitCode):
- (JSC::FunctionCallDotNode::emitCode):
- * parser/Nodes.h:
- (JSC::ScopeNode::neededConstants):
-
-2008-11-11 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22174
- Simplified op_call by nixing its responsibility for moving the value of
- "this" into the first argument slot.
-
- Instead, the caller emits an explicit load or mov instruction, or relies
- on implicit knowledge that "this" is already in the first argument slot.
- As a result, two operands to op_call are gone: firstArg and thisVal.
-
- SunSpider and v8 tests show no change in bytecode or CTI.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCallSetupArgs):
- (JSC::CTI::compileOpCallEvalSetupArgs):
- (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions
- of setting up arguments to op_call, because they're more different than
- they are the same -- even more so with this patch.
-
- (JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
- match op_call anymore.
-
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
- for changes mentioned above.
-
- * VM/CTI.h:
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.
-
- * VM/Machine.cpp:
- (JSC::Machine::callEval): Updated for new bytecode format of call / construct.
-
- (JSC::Machine::dumpCallFrame):
- (JSC::Machine::dumpRegisters): Simplified these debugging functions,
- taking advantage of the new call frame layout.
-
- (JSC::Machine::execute): Fixed up the eval version of execute to be
- friendlier to calls in the new format.
-
- (JSC::Machine::privateExecute): Implemented the new call format in
- bytecode.
-
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
- call format.
-
- Fixed a latent bug in stack overflow checking that is now hit because
- the register layout has changed a bit -- namely: when throwing a stack
- overflow exception inside an op_call helper, we need to account for the
- fact that the current call frame is only half-constructed, and use the
- parent call frame instead.
-
- * VM/Machine.h:
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitCallEval):
- (JSC::CodeGenerator::emitConstruct):
- * bytecompiler/CodeGenerator.h: Updated codegen to match the new call
- format.
-
- * parser/Nodes.cpp:
- (JSC::EvalFunctionCallNode::emitCode):
- (JSC::FunctionCallValueNode::emitCode):
- (JSC::FunctionCallResolveNode::emitCode):
- (JSC::FunctionCallBracketNode::emitCode):
- (JSC::FunctionCallDotNode::emitCode):
- * parser/Nodes.h:
- (JSC::ScopeNode::neededConstants): ditto
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove an unused forwarding header for a file that no longer exists.
-
- * ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
-
-2008-11-11 Mark Rowe <mrowe@apple.com>
-
- Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
- by failure to update all instances of "kjs" to their new locations.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-11-11 Alexey Proskuryakov <ap@webkit.org>
-
- Rubber-stamped by Adam Roben.
-
- * wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter):
- Fix indentation a little more.
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Clean up EvalCodeCache to match our coding style a bit more.
-
- * VM/EvalCodeCache.h:
- (JSC::EvalCodeCache::get):
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
- <https://bugs.webkit.org/show_bug.cgi?id=22179>
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CodeBlock.h:
- * VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
- * VM/Machine.cpp:
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove the 'm_' prefix from the fields of the SwitchRecord struct.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompile):
- * VM/CTI.h:
- (JSC::SwitchRecord):
- (JSC::SwitchRecord::SwitchRecord):
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Make asInteger() a static function so that it has internal linkage.
-
- * VM/CTI.cpp:
- (JSC::asInteger):
-
-2008-11-11 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Mark Rowe.
-
- - shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)
-
- No perf regression combined with the last patch (each seems like a small regression individually)
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate):
- * parser/Nodes.h:
- (JSC::SourceElements::releaseContentsIntoVector):
- * wtf/Vector.h:
- (WTF::Vector::shrinkToFit):
-
-2008-11-11 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Mark Rowe.
-
- - remove inline capacity from declaration stacks (15M savings on membuster test)
-
- No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.
-
- * JavaScriptCore.exp:
- * parser/Nodes.h:
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- While r38286 removed the need for the m_callFrame member variable of
- CTI, it should be also be removed.
-
- * VM/CTI.h:
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Make CTI::asInteger() a non-member function, since it needs no access to
- any of CTI's member variables.
-
- * VM/CTI.cpp:
- (JSC::asInteger):
- * VM/CTI.h:
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
- usual convention elsewhere.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Make CTI::getConstant() a member function of CodeBlock instead.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- (JSC::CodeBlock::getConstant):
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Rename CodeBlock::isConstant() to isConstantRegisterIndex().
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.h:
- (JSC::CodeBlock::isConstantRegisterIndex):
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp):
-
-2008-11-10 Gavin Barraclough <barraclough@apple.com>
-
- Build fix for non-CTI builds.
-
- * VM/Machine.cpp:
- (JSC::Machine::initialize):
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove the unused labels member variable of CodeBlock.
-
- * VM/CodeBlock.h:
- * VM/LabelID.h:
- (JSC::LabelID::setLocation):
-
-2008-11-10 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
- Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
- pointer to the global data directly, since this is available at the point the Machine is constructed).
- Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.
-
- * VM/CTI.cpp:
- (JSC::CTI::getConstant):
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::CTI):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompileCTIMachineTrampolines):
- (JSC::CTI::freeCTIMachineTrampolines):
- * VM/CTI.h:
- (JSC::CTI::compile):
- (JSC::CTI::compileGetByIdSelf):
- (JSC::CTI::compileGetByIdProto):
- (JSC::CTI::compileGetByIdChain):
- (JSC::CTI::compilePutByIdReplace):
- (JSC::CTI::compilePutByIdTransition):
- (JSC::CTI::compileCTIMachineTrampolines):
- (JSC::CTI::compilePatchGetArrayLength):
- * VM/Machine.cpp:
- (JSC::Machine::initialize):
- (JSC::Machine::~Machine):
- (JSC::Machine::execute):
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::tryCTICacheGetByID):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_lazyLinkCall):
- * VM/Machine.h:
- * masm/X86Assembler.h:
- (JSC::JITCodeBuffer::isAligned):
- (JSC::X86Assembler::):
- (JSC::X86Assembler::align):
- * runtime/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
-
-2008-11-10 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Antti Koivisto.
-
- - Make Vector::clear() release the Vector's memory (1MB savings on membuster)
- https://bugs.webkit.org/show_bug.cgi?id=22170
-
- * wtf/Vector.h:
- (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as
- well as size, otherwise shrinking capacity to 0 can fail to reset
- the capacity and thus cause a future crash.
- (WTF::Vector::~Vector): Shrink size not capacity; we only need
- to call destructors, the buffer will be freed anyway.
- (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0).
- (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where
- the size is greater than the new capacity, to work with types that have no
- default constructor.
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Split multiple definitions into separate lines.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileBinaryArithOp):
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
- <https://bugs.webkit.org/show_bug.cgi?id=22162>
-
- There is no more need for the cachedValueGetter hack now that we have
- PropertySlot::setValue(), so we should remove it.
-
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- (JSC::::getOwnPropertySlot):
-
-2008-11-10 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
- <https://bugs.webkit.org/show_bug.cgi?id=22152>
-
- With the recent change to adopt asType() style cast functions with
- assertions instead of static_casts in many places, the assertion for
- the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
- failing when using any nontrivial client of the JavaScriptCore API.
- The cast isn't even necessary to call slot.setCustom(), so it should
- be removed.
-
- * API/JSCallbackObjectFunctions.h:
- (JSC::JSCallbackObject::getOwnPropertySlot):
-
-2008-11-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Adam Roben.
-
- A few coding style fixes for AVLTree.
-
- * wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards.
- (WTF::AVLTree::Iterator::start_iter): Fixed indentation
-
- * runtime/JSArray.cpp: Added "using namepace WTF".
-
-2008-11-09 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Speculatively fix the non-AllInOne build.
-
- * runtime/NativeErrorConstructor.cpp:
-
-2008-11-09 Darin Adler <darin@apple.com>
-
- Reviewed by Tim Hatcher.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22149
- remove unused code from the parser
-
- * AllInOneFile.cpp: Removed nodes2string.cpp.
- * GNUmakefile.am: Ditto.
- * JavaScriptCore.exp: Ditto.
- * JavaScriptCore.pri: Ditto.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- * JavaScriptCoreSources.bkl: Ditto.
-
- * VM/CodeBlock.h: Added include.
-
- * VM/Machine.cpp: (JSC::Machine::execute): Use the types from
- DeclarationStacks as DeclarationStacks:: rather than Node:: since
- "Node" really has little to do with it.
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator): Ditto.
-
- * jsc.cpp:
- (Options::Options): Removed prettyPrint option.
- (runWithScripts): Ditto.
- (printUsageStatement): Ditto.
- (parseArguments): Ditto.
- (jscmain): Ditto.
-
- * parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
-
- * parser/Nodes.cpp:
- (JSC::ThrowableExpressionData::emitThrowError): Use inline functions
- instead of direct member access for ThrowableExpressionData values.
- (JSC::BracketAccessorNode::emitCode): Ditto.
- (JSC::DotAccessorNode::emitCode): Ditto.
- (JSC::NewExprNode::emitCode): Ditto.
- (JSC::EvalFunctionCallNode::emitCode): Ditto.
- (JSC::FunctionCallValueNode::emitCode): Ditto.
- (JSC::FunctionCallResolveNode::emitCode): Ditto.
- (JSC::FunctionCallBracketNode::emitCode): Ditto.
- (JSC::FunctionCallDotNode::emitCode): Ditto.
- (JSC::PostfixResolveNode::emitCode): Ditto.
- (JSC::PostfixBracketNode::emitCode): Ditto.
- (JSC::PostfixDotNode::emitCode): Ditto.
- (JSC::DeleteResolveNode::emitCode): Ditto.
- (JSC::DeleteBracketNode::emitCode): Ditto.
- (JSC::DeleteDotNode::emitCode): Ditto.
- (JSC::PrefixResolveNode::emitCode): Ditto.
- (JSC::PrefixBracketNode::emitCode): Ditto.
- (JSC::PrefixDotNode::emitCode): Ditto.
- (JSC::ThrowableBinaryOpNode::emitCode): Ditto.
- (JSC::InstanceOfNode::emitCode): Ditto.
- (JSC::ReadModifyResolveNode::emitCode): Ditto.
- (JSC::AssignResolveNode::emitCode): Ditto.
- (JSC::AssignDotNode::emitCode): Ditto.
- (JSC::ReadModifyDotNode::emitCode): Ditto.
- (JSC::AssignBracketNode::emitCode): Ditto.
- (JSC::ReadModifyBracketNode::emitCode): Ditto.
- (JSC::statementListEmitCode): Take a const StatementVector instead
- of a non-const one. Also removed unused statementListPushFIFO.
- (JSC::ForInNode::emitCode): Inline functions instead of member access.
- (JSC::ThrowNode::emitCode): Ditto.
- (JSC::EvalNode::emitCode): Ditto.
- (JSC::FunctionBodyNode::emitCode): Ditto.
- (JSC::ProgramNode::emitCode): Ditto.
-
- * parser/Nodes.h: Removed unused includes and forward declarations.
- Removed Precedence enum. Made many more members private instead of
- protected or public. Removed unused NodeStack typedef. Moved the
- VarStack and FunctionStack typedefs from Node to ScopeNode. Made
- Node::emitCode pure virtual and changed classes that don't emit
- any code to inherit from ParserRefCounted rather than Node.
- Moved isReturnNode from Node to StatementNode. Removed the
- streamTo, precedence, and needsParensIfLeftmost functions from
- all classes. Removed the ImmediateNumberNode class and make
- NumberNode::setValue nonvirtual.
-
- * parser/nodes2string.cpp: Removed.
-
-2008-11-09 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig and Maciej Stachowiak.
- Includes some work done by Chris Brichford.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=14886
- Stack overflow due to deeply nested parse tree doing repeated string concatentation
-
- Test: fast/js/large-expressions.html
-
- 1) Code generation is recursive, so takes stack proportional to the complexity
- of the source code expression. Fixed by setting an arbitrary recursion limit
- of 10,000 nodes.
-
- 2) Destruction of the syntax tree was recursive. Fixed by introducing a
- non-recursive mechanism for destroying the tree.
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0.
- (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code
- to throw a "too deep" exception.
- * bytecompiler/CodeGenerator.h:
- (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed
- the maximum depth.
-
- * parser/Nodes.cpp:
- (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors
- to avoid recursive calls to destructors for nodes inside this one.
- (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions.
- Also added releaseNodes functions and calls to releaseAllNodes inside destructors
- for each class derived from Node that has RefPtr to other nodes.
- (JSC::NodeReleaser::adopt): Added. Used by the release function.
- (JSC::NodeReleaser::adoptFunctionBodyNode): Added.
-
- * parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes
- that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts
- of an older solution to the non-recursive destruction problem that works only for
- lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode
- to use BinaryOpNode as a base class to avoid some duplicated code.
-
-2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after addition of JSCore parser and bycompiler dirs. Also cleanup
- the JSCore Bakefile's group names to be consistent.
-
- * JavaScriptCoreSources.bkl:
- * jscore.bkl:
-
-2008-11-07 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
- <https://bugs.webkit.org/show_bug.cgi?id=21801>
-
- Fix the constant register check in the 'typeof' optimization in
- CodeGenerator, which was completely broken after r37821.
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp):
-
-2008-11-07 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 22129: Move CTI::isConstant() to CodeBlock
- <https://bugs.webkit.org/show_bug.cgi?id=22129>
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- (JSC::CodeBlock::isConstant):
-
-2008-11-07 Alp Toker <alp@nuanti.com>
-
- autotools fix. Always use the configured perl binary (which may be
- different to the one in $PATH) when generating sources.
-
- * GNUmakefile.am:
-
-2008-11-07 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
- build scripts.
-
- * DerivedSources.make:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCoreSources.bkl:
-
-2008-11-07 Alp Toker <alp@nuanti.com>
-
- More grammar.cpp -> Grammar.cpp build fixes.
-
- * AllInOneFile.cpp:
- * GNUmakefile.am:
-
-2008-11-07 Simon Hausmann <hausmann@webkit.org>
-
- Fix the build on case-sensitive file systems. grammar.y was renamed to
- Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
- notice this change because of stale files.
-
- * parser/Lexer.cpp:
-
-2008-11-07 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
- variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
- and m_nextConstantIndex respectively. This is to distinguish these from
- member variables like m_lastConstant, which are actually RefPtrs to
- Registers.
-
- * bytecompiler/CodeGenerator.cpp:
- (JSC::CodeGenerator::addGlobalVar):
- (JSC::CodeGenerator::allocateConstants):
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::addParameter):
- (JSC::CodeGenerator::addConstant):
- * bytecompiler/CodeGenerator.h:
-
-2008-11-06 Gavin Barraclough barraclough@apple.com
-
- Reviewed by Oliver Hunt.
-
- Do not make a cti_* call to perform an op_call unless either:
- (1) The codeblock for the function body has not been generated.
- (2) The number of arguments passed does not match the callee arity.
-
- ~1% progression on sunspider --v8
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_call_arityCheck):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/Machine.h:
- * kjs/nodes.h:
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Move the remaining files in the kjs subdirectory of JavaScriptCore to
- a new parser subdirectory, and remove the kjs subdirectory entirely.
-
- * AllInOneFile.cpp:
- * DerivedSources.make:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/CodeBlock.h:
- * VM/ExceptionHelpers.cpp:
- * VM/SamplingTool.h:
- * bytecompiler/CodeGenerator.h:
- * jsc.pro:
- * jscore.bkl:
- * kjs: Removed.
- * kjs/NodeInfo.h: Removed.
- * kjs/Parser.cpp: Removed.
- * kjs/Parser.h: Removed.
- * kjs/ResultType.h: Removed.
- * kjs/SourceCode.h: Removed.
- * kjs/SourceProvider.h: Removed.
- * kjs/grammar.y: Removed.
- * kjs/keywords.table: Removed.
- * kjs/lexer.cpp: Removed.
- * kjs/lexer.h: Removed.
- * kjs/nodes.cpp: Removed.
- * kjs/nodes.h: Removed.
- * kjs/nodes2string.cpp: Removed.
- * parser: Added.
- * parser/Grammar.y: Copied from kjs/grammar.y.
- * parser/Keywords.table: Copied from kjs/keywords.table.
- * parser/Lexer.cpp: Copied from kjs/lexer.cpp.
- * parser/Lexer.h: Copied from kjs/lexer.h.
- * parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
- * parser/Nodes.cpp: Copied from kjs/nodes.cpp.
- * parser/Nodes.h: Copied from kjs/nodes.h.
- * parser/Parser.cpp: Copied from kjs/Parser.cpp.
- * parser/Parser.h: Copied from kjs/Parser.h.
- * parser/ResultType.h: Copied from kjs/ResultType.h.
- * parser/SourceCode.h: Copied from kjs/SourceCode.h.
- * parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
- * parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
- * pcre/pcre.pri:
- * pcre/pcre_exec.cpp:
- * runtime/FunctionConstructor.cpp:
- * runtime/JSActivation.h:
- * runtime/JSFunction.h:
- * runtime/JSGlobalData.cpp:
- * runtime/JSGlobalObjectFunctions.cpp:
- * runtime/JSObject.cpp:
- (JSC::JSObject::toNumber):
- * runtime/RegExp.cpp:
-
-2008-11-06 Adam Roben <aroben@apple.com>
-
- Windows build fix after r38196
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the
- include path.
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Create a new bytecompiler subdirectory of JavaScriptCore and move some
- relevant files to it.
-
- * AllInOneFile.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/CodeGenerator.cpp: Removed.
- * VM/CodeGenerator.h: Removed.
- * bytecompiler: Added.
- * bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
- * bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
- * bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
- * jscore.bkl:
- * kjs/LabelScope.h: Removed.
-
-2008-11-06 Adam Roben <aroben@apple.com>
-
- Windows clean build fix after r38155
-
- Rubberstamped by Cameron Zwarich.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
- the post-build event for the move of create_hash_table out of kjs/.
-
-2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22107
-
- Bug uncovered during RVCT port in functions not used. get_lt() and
- get_gt() takes only one argument - remove second argument where
- applicable.
-
- * wtf/AVLTree.h:
- (JSC::AVLTree::remove): Remove second argument of get_lt/get_gt().
- (JSC::AVLTree::subst): Ditto.
-
-2008-11-06 Alp Toker <alp@nuanti.com>
-
- Reviewed by Cameron Zwarich.
-
- https://bugs.webkit.org/show_bug.cgi?id=22033
- [GTK] CTI/Linux r38064 crashes; JIT requires executable memory
-
- Mark pages allocated by the FastMalloc mmap code path executable with
- PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
- non-executable memory (like ExecShield on Fedora Linux) when the JIT
- is enabled.
-
- This patch does not resolve the issue on debug builds so affected
- developers may still need to pass --disable-jit to configure.
-
- * wtf/TCSystemAlloc.cpp:
- (TryMmap):
- (TryDevMem):
- (TCMalloc_SystemRelease):
-
-2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>
-
- Reviewed by Cameron Zwarich.
-
- Bug 22099: Make the Qt port build the JSC shell in the correct place
- <https://bugs.webkit.org/show_bug.cgi?id=22099>
-
- Adjust include paths and build destination dir for the 'jsc' executable
- in the Qt build.
-
- * jsc.pro:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Implemented the block allocation on Symbian through heap allocation.
-
- Unfortunately there is no way to allocate virtual memory. The Posix
- layer provides mmap() but no anonymous mapping. So this is a very slow
- solution but it should work as a start.
-
- * runtime/Collector.cpp:
- (JSC::allocateBlock):
- (JSC::freeBlock):
-
-2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Borrow some math functions from the MSVC port to the build with the
- RVCT compiler.
-
- * wtf/MathExtras.h:
- (isinf):
- (isnan):
- (signbit):
-
-2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Include strings.h for strncasecmp().
- This is needed for compilation inside Symbian and it is also
- confirmed by the man-page on Linux.
-
- * runtime/DateMath.cpp:
-
-2008-11-06 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Implemented currentThreadStackBase for Symbian.
-
- * runtime/Collector.cpp:
- (JSC::currentThreadStackBase):
-
-2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- RVCT does not support tm_gmtoff field, so disable that code just like
- for MSVC.
-
- * runtime/DateMath.h:
- (JSC::GregorianDateTime::GregorianDateTime):
- (JSC::GregorianDateTime::operator tm):
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
- on top of the Posix layer.
-
- * wtf/Platform.h:
-
-2008-11-06 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Added __SYMBIAN32__ condition for defining PLATFORM(SYMBIAN).
-
- * wtf/Platform.h:
-
-2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Added WINSCW compiler define for Symbian S60.
-
- * wtf/Platform.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
- MINSCW compiler.
-
- * wtf/Vector.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Define capabilities of the SYMBIAN platform. Some of the system
- headers are actually dependent on RVCT.
-
- * wtf/Platform.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Add missing stddef.h header needed for compilation in Symbian.
-
- * runtime/Collector.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.
-
- * wtf/Platform.h:
-
-2008-11-06 Simon Hausmann <hausmann@webkit.org>
-
- Fix the Qt build, adjust include paths after move of jsc.pro.
-
- * jsc.pro:
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
- rename it to jsc.cpp to reflect the name of the binary compiled from it.
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * jsc.cpp: Copied from kjs/Shell.cpp.
- * jsc.pro:
- * jscore.bkl:
- * kjs/Shell.cpp: Removed.
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move create_hash_table and jsc.pro out of the kjs directory and into the
- root directory of JavaScriptCore.
-
- * DerivedSources.make:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * create_hash_table: Copied from kjs/create_hash_table.
- * jsc.pro: Copied from kjs/jsc.pro.
- * kjs/create_hash_table: Removed.
- * kjs/jsc.pro: Removed.
- * make-generated-sources.sh:
-
-2008-11-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=22094
-
- Fix for bug where the callee incorrectly recieves the caller's lexical
- global object as this, rather than its own. Implementation closely
- follows the spec, passing jsNull, checking in the callee and replacing
- with the global object where necessary.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_call_eval):
- * runtime/JSCell.h:
- (JSC::JSValue::toThisObject):
- * runtime/JSImmediate.cpp:
- (JSC::JSImmediate::toThisObject):
- * runtime/JSImmediate.h:
-
-2008-11-05 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix after Operations.cpp move.
-
- * JavaScriptCoreSources.bkl:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the build for case-sensitive build systems and wxWindows.
-
- * JavaScriptCoreSources.bkl:
- * kjs/create_hash_table:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the build for case-sensitive build systems.
-
- * JavaScriptCoreSources.bkl:
- * kjs/Shell.cpp:
- * runtime/Interpreter.cpp:
- * runtime/JSArray.cpp:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the build for case-sensitive build systems.
-
- * API/JSBase.cpp:
- * API/JSObjectRef.cpp:
- * runtime/CommonIdentifiers.h:
- * runtime/Identifier.cpp:
- * runtime/InitializeThreading.cpp:
- * runtime/InternalFunction.h:
- * runtime/JSString.h:
- * runtime/Lookup.h:
- * runtime/PropertyNameArray.h:
- * runtime/PropertySlot.h:
- * runtime/StructureID.cpp:
- * runtime/StructureID.h:
- * runtime/UString.cpp:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move more files to the runtime subdirectory of JavaScriptCore.
-
- * API/APICast.h:
- * API/JSBase.cpp:
- * API/JSCallbackObject.cpp:
- * API/JSClassRef.cpp:
- * API/JSClassRef.h:
- * API/JSStringRefCF.cpp:
- * API/JSValueRef.cpp:
- * API/OpaqueJSString.cpp:
- * API/OpaqueJSString.h:
- * AllInOneFile.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- * VM/Machine.cpp:
- * VM/RegisterFile.h:
- * debugger/Debugger.h:
- * kjs/SourceProvider.h:
- * kjs/TypeInfo.h: Removed.
- * kjs/collector.cpp: Removed.
- * kjs/collector.h: Removed.
- * kjs/completion.h: Removed.
- * kjs/create_hash_table:
- * kjs/identifier.cpp: Removed.
- * kjs/identifier.h: Removed.
- * kjs/interpreter.cpp: Removed.
- * kjs/interpreter.h: Removed.
- * kjs/lexer.cpp:
- * kjs/lexer.h:
- * kjs/lookup.cpp: Removed.
- * kjs/lookup.h: Removed.
- * kjs/nodes.cpp:
- * kjs/nodes.h:
- * kjs/operations.cpp: Removed.
- * kjs/operations.h: Removed.
- * kjs/protect.h: Removed.
- * kjs/regexp.cpp: Removed.
- * kjs/regexp.h: Removed.
- * kjs/ustring.cpp: Removed.
- * kjs/ustring.h: Removed.
- * pcre/pcre_exec.cpp:
- * profiler/CallIdentifier.h:
- * profiler/Profile.h:
- * runtime/ArrayConstructor.cpp:
- * runtime/ArrayPrototype.cpp:
- * runtime/ArrayPrototype.h:
- * runtime/Collector.cpp: Copied from kjs/collector.cpp.
- * runtime/Collector.h: Copied from kjs/collector.h.
- * runtime/CollectorHeapIterator.h:
- * runtime/Completion.h: Copied from kjs/completion.h.
- * runtime/ErrorPrototype.cpp:
- * runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
- * runtime/Identifier.h: Copied from kjs/identifier.h.
- * runtime/InitializeThreading.cpp:
- * runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
- * runtime/Interpreter.h: Copied from kjs/interpreter.h.
- * runtime/JSCell.h:
- * runtime/JSGlobalData.cpp:
- * runtime/JSGlobalData.h:
- * runtime/JSLock.cpp:
- * runtime/JSNumberCell.cpp:
- * runtime/JSNumberCell.h:
- * runtime/JSObject.cpp:
- * runtime/JSValue.h:
- * runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
- * runtime/Lookup.h: Copied from kjs/lookup.h.
- * runtime/MathObject.cpp:
- * runtime/NativeErrorPrototype.cpp:
- * runtime/NumberPrototype.cpp:
- * runtime/Operations.cpp: Copied from kjs/operations.cpp.
- * runtime/Operations.h: Copied from kjs/operations.h.
- * runtime/PropertyMapHashTable.h:
- * runtime/Protect.h: Copied from kjs/protect.h.
- * runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
- * runtime/RegExp.h: Copied from kjs/regexp.h.
- * runtime/RegExpConstructor.cpp:
- * runtime/RegExpObject.h:
- * runtime/RegExpPrototype.cpp:
- * runtime/SmallStrings.h:
- * runtime/StringObjectThatMasqueradesAsUndefined.h:
- * runtime/StructureID.cpp:
- * runtime/StructureID.h:
- * runtime/StructureIDTransitionTable.h:
- * runtime/SymbolTable.h:
- * runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
- * runtime/UString.cpp: Copied from kjs/ustring.cpp.
- * runtime/UString.h: Copied from kjs/ustring.h.
- * wrec/CharacterClassConstructor.h:
- * wrec/WREC.h:
-
-2008-11-05 Geoffrey Garen <ggaren@apple.com>
-
- Suggested by Darin Adler.
-
- Removed two copy constructors that the compiler can generate for us
- automatically.
-
- * VM/LabelID.h:
- (JSC::LabelID::setLocation):
- (JSC::LabelID::offsetFrom):
- (JSC::LabelID::ref):
- (JSC::LabelID::refCount):
- * kjs/LabelScope.h:
-
-2008-11-05 Anders Carlsson <andersca@apple.com>
-
- Fix Snow Leopard build.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Steve Falkenburg.
-
- Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
- their movement in the filesystem.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore.
-
- * AllInOneFile.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/dtoa.cpp: Removed.
- * kjs/dtoa.h: Removed.
- * wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
- * wtf/dtoa.h: Copied from kjs/dtoa.h.
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move kjs/config.h to the top level of JavaScriptCore.
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * config.h: Copied from kjs/config.h.
- * kjs/config.h: Removed.
-
-2008-11-04 Darin Adler <darin@apple.com>
-
- Reviewed by Tim Hatcher.
-
- * wtf/ThreadingNone.cpp: Tweak formatting.
-
-2008-11-03 Darin Adler <darin@apple.com>
-
- Reviewed by Tim Hatcher.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22061
- create script to check for exit-time destructors
-
- * JavaScriptCore.exp: Changed to export functions rather than
- a global for the atomically initialized static mutex.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Added a script
- phase that runs the check-for-exit-time-destructors script.
-
- * wtf/MainThread.cpp:
- (WTF::mainThreadFunctionQueueMutex): Changed to leak an object
- rather than using an exit time destructor.
- (WTF::functionQueue): Ditto.
- * wtf/unicode/icu/CollatorICU.cpp:
- (WTF::cachedCollatorMutex): Ditto.
-
- * wtf/Threading.h: Changed other platforms to share the Windows
- approach where the mutex is internal and the functions are exported.
- * wtf/ThreadingGtk.cpp:
- (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
- (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
- * wtf/ThreadingNone.cpp:
- (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
- (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
- * wtf/ThreadingPthreads.cpp:
- (WTF::threadMapMutex): Changed to leak an object rather than using
- an exit time destructor.
- (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
- (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
- (WTF::threadMap): Changed to leak an object rather than using
- an exit time destructor.
- * wtf/ThreadingQt.cpp:
- (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
- (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
- * wtf/ThreadingWin.cpp:
- (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.
-
-2008-11-04 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
- the location of JSStaticScopeObject.{cpp,h}.
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Move AllInOneFile.cpp to the top level of JavaScriptCore.
-
- * AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
- * GNUmakefile.am:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/AllInOneFile.cpp: Removed.
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Add NodeInfo.h to the JavaScriptCore Xcode project.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-11-03 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Maciej Stachowiak.
-
- Move more files into the runtime subdirectory of JavaScriptCore.
-
- * API/JSBase.cpp:
- * API/JSCallbackConstructor.cpp:
- * API/JSCallbackFunction.cpp:
- * API/JSClassRef.cpp:
- * API/OpaqueJSString.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/AllInOneFile.cpp:
- * kjs/ArgList.cpp: Removed.
- * kjs/ArgList.h: Removed.
- * kjs/Arguments.cpp: Removed.
- * kjs/Arguments.h: Removed.
- * kjs/BatchedTransitionOptimizer.h: Removed.
- * kjs/CollectorHeapIterator.h: Removed.
- * kjs/CommonIdentifiers.cpp: Removed.
- * kjs/CommonIdentifiers.h: Removed.
- * kjs/ExecState.cpp: Removed.
- * kjs/ExecState.h: Removed.
- * kjs/GetterSetter.cpp: Removed.
- * kjs/GetterSetter.h: Removed.
- * kjs/InitializeThreading.cpp: Removed.
- * kjs/InitializeThreading.h: Removed.
- * kjs/JSActivation.cpp: Removed.
- * kjs/JSActivation.h: Removed.
- * kjs/JSGlobalData.cpp: Removed.
- * kjs/JSGlobalData.h: Removed.
- * kjs/JSLock.cpp: Removed.
- * kjs/JSLock.h: Removed.
- * kjs/JSStaticScopeObject.cpp: Removed.
- * kjs/JSStaticScopeObject.h: Removed.
- * kjs/JSType.h: Removed.
- * kjs/PropertyNameArray.cpp: Removed.
- * kjs/PropertyNameArray.h: Removed.
- * kjs/ScopeChain.cpp: Removed.
- * kjs/ScopeChain.h: Removed.
- * kjs/ScopeChainMark.h: Removed.
- * kjs/SymbolTable.h: Removed.
- * kjs/Tracing.d: Removed.
- * kjs/Tracing.h: Removed.
- * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
- * runtime/ArgList.h: Copied from kjs/ArgList.h.
- * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
- * runtime/Arguments.h: Copied from kjs/Arguments.h.
- * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
- * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
- * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
- * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
- * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
- * runtime/ExecState.h: Copied from kjs/ExecState.h.
- * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
- * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
- * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
- * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
- * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
- * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
- * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
- * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
- * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
- * runtime/JSLock.h: Copied from kjs/JSLock.h.
- * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
- * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
- * runtime/JSType.h: Copied from kjs/JSType.h.
- * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
- * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
- * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
- * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
- * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
- * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
- * runtime/Tracing.d: Copied from kjs/Tracing.d.
- * runtime/Tracing.h: Copied from kjs/Tracing.h.
-
-2008-11-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
- turning it on does not require a full rebuild.
-
- * runtime/StructureID.cpp:
- (JSC::StructureID::dumpStatistics):
- * runtime/StructureID.h:
-
-2008-11-03 Alp Toker <alp@nuanti.com>
-
- Reviewed by Geoffrey Garen.
-
- Fix warning when building on Darwin without JSC_MULTIPLE_THREADS
- enabled.
-
- * kjs/InitializeThreading.cpp:
-
-2008-11-02 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
- <https://bugs.webkit.org/show_bug.cgi?id=22042>
-
- Rename parameter name to avoid ASSERT.
-
- * VM/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- (JSC::ProgramCodeBlock::ProgramCodeBlock):
- (JSC::EvalCodeBlock::EvalCodeBlock):
-
-2008-11-02 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 22035: Remove the '_' suffix on constructor parameter names for structs
- <https://bugs.webkit.org/show_bug.cgi?id=22035>
-
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
- * VM/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- (JSC::ProgramCodeBlock::ProgramCodeBlock):
- (JSC::EvalCodeBlock::EvalCodeBlock):
- * wrec/WREC.h:
- (JSC::Quantifier::Quantifier):
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Geoff Garen.
-
- Rename SourceRange.h to SourceCode.h.
-
- * API/JSBase.cpp:
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CodeBlock.h:
- * kjs/SourceCode.h: Copied from kjs/SourceRange.h.
- * kjs/SourceRange.h: Removed.
- * kjs/grammar.y:
- * kjs/lexer.h:
- * kjs/nodes.cpp:
- (JSC::ForInNode::ForInNode):
- * kjs/nodes.h:
- (JSC::ThrowableExpressionData::setExceptionSourceCode):
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
- <https://bugs.webkit.org/show_bug.cgi?id=22019>
-
- The JSC::Interpreter::shouldPrintExceptions() function is not used at
- all in JavaScriptCore, so it should be moved to WebCore::Console, its
- only user.
-
- * JavaScriptCore.exp:
- * kjs/interpreter.cpp:
- * kjs/interpreter.h:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Windows build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Remove the call to Interpreter::setShouldPrintExceptions() from the
- GlobalObject constructor in the shell. The shouldPrintExceptions()
- information is not used anywhere in JavaScriptCore, only in WebCore.
-
- * kjs/Shell.cpp:
- (GlobalObject::GlobalObject):
-
-2008-10-31 Kevin Ollivier <kevino@theolliviers.com>
-
- wxMSW build fix.
-
- * wtf/Threading.h:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move more files from the kjs subdirectory of JavaScriptCore to the
- runtime subdirectory.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/AllInOneFile.cpp:
- * kjs/RegExpConstructor.cpp: Removed.
- * kjs/RegExpConstructor.h: Removed.
- * kjs/RegExpMatchesArray.h: Removed.
- * kjs/RegExpObject.cpp: Removed.
- * kjs/RegExpObject.h: Removed.
- * kjs/RegExpPrototype.cpp: Removed.
- * kjs/RegExpPrototype.h: Removed.
- * runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
- * runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
- * runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
- * runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
- * runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
- * runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
- * runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.
-
-2008-10-31 Mark Rowe <mrowe@apple.com>
-
- Revert an incorrect portion of r38034.
-
- * profiler/ProfilerServer.mm:
-
-2008-10-31 Mark Rowe <mrowe@apple.com>
-
- Fix the 64-bit build.
-
- Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
- with the common Obj-C idiom self = [super init];
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Change a header guard to match our coding style.
-
- * kjs/InitializeThreading.h:
-
-2008-10-30 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
- AST uses way too much memory
-
- Removed a word from StatementNode by nixing LabelStack and turning it
- into a compile-time data structure managed by CodeGenerator.
-
- v8 tests and SunSpider, run by Gavin, report no change.
-
- * GNUmakefile.am:
- * JavaScriptCore.order:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/AllInOneFile.cpp:
- * JavaScriptCoreSources.bkl: I sure hope this builds!
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::newLabelScope):
- (JSC::CodeGenerator::breakTarget):
- (JSC::CodeGenerator::continueTarget):
- * VM/CodeGenerator.h: Nixed the JumpContext system because it depended
- on a LabelStack in the AST, and it was a little cumbersome on the client
- side. Replaced with LabelScope, which tracks all break / continue
- information in the CodeGenerator, just like we track LabelIDs and other
- stacks of compile-time data.
-
- * kjs/LabelScope.h: Added.
- (JSC::LabelScope::):
- (JSC::LabelScope::LabelScope):
- (JSC::LabelScope::ref):
- (JSC::LabelScope::deref):
- (JSC::LabelScope::refCount):
- (JSC::LabelScope::breakTarget):
- (JSC::LabelScope::continueTarget):
- (JSC::LabelScope::type):
- (JSC::LabelScope::name):
- (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything
- you might want to know about a break-able / continue-able scope.
-
- * kjs/LabelStack.cpp: Removed.
- * kjs/LabelStack.h: Removed.
-
- * kjs/grammar.y: No need to push labels at parse time -- we don't store
- LabelStacks in the AST anymore.
-
- * kjs/nodes.cpp:
- (JSC::DoWhileNode::emitCode):
- (JSC::WhileNode::emitCode):
- (JSC::ForNode::emitCode):
- (JSC::ForInNode::emitCode):
- (JSC::ContinueNode::emitCode):
- (JSC::BreakNode::emitCode):
- (JSC::SwitchNode::emitCode):
- (JSC::LabelNode::emitCode):
- * kjs/nodes.h:
- (JSC::StatementNode::):
- (JSC::LabelNode::): Use LabelScope where we used to use JumpContext.
- Simplified a bunch of code. Touched up label-related error messages a
- bit.
-
- * kjs/nodes2string.cpp:
- (JSC::LabelNode::streamTo): Updated for rename.
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22005: Move StructureIDChain into its own file
- <https://bugs.webkit.org/show_bug.cgi?id=22005>
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * runtime/StructureID.cpp:
- * runtime/StructureID.h:
- * runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
- * runtime/StructureIDChain.h: Copied from runtime/StructureID.h.
-
-2008-10-31 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2008-10-31 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-10-31 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - fix storage leak seen on buildbot
-
- Some other cleanup too. The storage leak was caused by the fact
- that HashTraits<CallIdentifier>::needsDestruction was false, so
- the call identifier objects didn't get deleted.
-
- * profiler/CallIdentifier.h:
-
- Added a default constructor to create empty call identifiers.
-
- Changed the normal constructor to use const UString&
- to avoid extra copying and reference count thrash.
-
- Removed the explicit copy constructor definition, since it's what
- the compiler will automatically generate. (Rule of thumb: Either
- you need both a custom copy constructor and a custom assignment
- operator, or neither.)
-
- Moved the CallIdentifier hash function out of the WTF namespace;
- there's no reason to put it there.
-
- Changed the CallIdentifier hash function to be a struct rather than
- a specialization of the IntHash struct template. Having it be
- a specialization made no sense, since CallIdentifier is not an integer,
- and did no good.
-
- Removed explicit definition of emptyValueIsZero in the hash traits,
- since inheriting from GenericHashTraits already makes that false.
-
- Removed explicit definition of emptyValue, instead relying on the
- default constructor and GenericHashTraits.
-
- Removed explicit definition of needsDestruction, because we want it
- to have its default value: true, not false. This fixes the leak!
-
- Changed constructDeletedValue and isDeletedValue to use a line number
- of numeric_limits<unsigned>::max() to indicate a value is deleted.
- Previously this used empty strings for the empty value and null strings
- for the deleted value, but it's more efficient to use null for both.
-
-2008-10-31 Timothy Hatcher <timothy@apple.com>
-
- Emit the WillExecuteStatement debugger hook before the for loop body
- when the statement node for the body isn't a block. This allows
- breakpoints on those statements in the Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=22004
-
- Reviewed by Darin Adler.
-
- * kjs/nodes.cpp:
- (JSC::ForNode::emitCode): Emit the WillExecuteStatement
- debugger hook before the statement node if isn't a block.
- Also emit the WillExecuteStatement debugger hook for the
- loop as the first op-code.
- (JSC::ForInNode::emitCode): Ditto.
-
-2008-10-31 Timothy Hatcher <timothy@apple.com>
-
- Fixes console warnings about not having an autorelease pool.
- Also fixes the build for Snow Leopard, by including individual
- Foundation headers instead of Foundation.h.
-
- https://bugs.webkit.org/show_bug.cgi?id=21995
-
- Reviewed by Oliver Hunt.
-
- * profiler/ProfilerServer.mm:
- (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Speculative wxWindows build fix.
-
- * JavaScriptCoreSources.bkl:
- * jscore.bkl:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Maciej Stachowiak.
-
- Move VM/JSPropertyNameIterator.cpp and VM/JSPropertyNameIterator.h to
- the runtime directory.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * VM/JSPropertyNameIterator.cpp: Removed.
- * VM/JSPropertyNameIterator.h: Removed.
- * runtime/JSPropertyNameIterator.cpp: Copied from VM/JSPropertyNameIterator.cpp.
- * runtime/JSPropertyNameIterator.h: Copied from VM/JSPropertyNameIterator.h.
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Speculative wxWindows build fix.
-
- * jscore.bkl:
-
-2008-10-30 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Jon Homeycutt.
-
- Explicitly default to building for only the native architecture in debug and release builds.
-
- * Configurations/DebugRelease.xcconfig:
-
-2008-10-30 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Create a debugger directory in JavaScriptCore and move the relevant
- files to it.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CodeBlock.cpp:
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- * debugger: Added.
- * debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
- * debugger/Debugger.h: Copied from kjs/debugger.h.
- * debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
- * debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
- * kjs/AllInOneFile.cpp:
- * kjs/DebuggerCallFrame.cpp: Removed.
- * kjs/DebuggerCallFrame.h: Removed.
- * kjs/Parser.cpp:
- * kjs/Parser.h:
- * kjs/debugger.cpp: Removed.
- * kjs/debugger.h: Removed.
- * kjs/interpreter.cpp:
- * kjs/nodes.cpp:
- * runtime/FunctionConstructor.cpp:
- * runtime/JSGlobalObject.cpp:
-
-2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
-
- gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
- warnings; add some parentheses to disambiguate things. No functional
- changes, so no tests.
-
- https://bugs.webkit.org/show_bug.cgi?id=21973
- Add parentheses to clean up some gcc warnings
-
- Reviewed by Dan Bernstein.
-
- * wtf/ASCIICType.h:
- (WTF::isASCIIAlphanumeric):
- (WTF::isASCIIHexDigit):
-
-2008-10-30 Kevin Lindeman <klindeman@apple.com>
-
- Adds ProfilerServer, which is a distributed notification listener
- that allows starting and stopping the profiler remotely for use
- in conjunction with the profiler's DTace probes.
-
- https://bugs.webkit.org/show_bug.cgi?id=21719
-
- Reviewed by Timothy Hatcher.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Calls startProfilerServerIfNeeded.
- * profiler/ProfilerServer.h: Added.
- * profiler/ProfilerServer.mm: Added.
- (+[ProfilerServer sharedProfileServer]):
- (-[ProfilerServer init]):
- (-[ProfilerServer startProfiling]):
- (-[ProfilerServer stopProfiling]):
- (JSC::startProfilerServerIfNeeded):
-
-2008-10-30 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix after PropertyMap and StructureID merge.
-
- * JavaScriptCoreSources.bkl:
-
-2008-10-30 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Mark Rowe.
-
- Change the JavaScriptCore Xcode project to use relative paths for the
- PCRE source files.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-10-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich and Geoffrey Garen.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21989
- Merge PropertyMap and StructureID
-
- - Move PropertyMap code into StructureID in preparation for lazily
- creating the map on gets.
- - Make remove with transition explicit by adding removePropertyTransition.
- - Make the put/remove without transition explicit.
- - Make cache invalidation part of put/remove without transition.
-
- 1% speedup on SunSpider; 0.5% speedup on v8 suite.
-
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/AllInOneFile.cpp:
- * kjs/identifier.h:
- * runtime/JSObject.cpp:
- (JSC::JSObject::removeDirect):
- * runtime/JSObject.h:
- (JSC::JSObject::putDirect):
- * runtime/PropertyMap.cpp: Removed.
- * runtime/PropertyMap.h: Removed.
- * runtime/PropertyMapHashTable.h: Copied from runtime/PropertyMap.h.
- * runtime/StructureID.cpp:
- (JSC::StructureID::dumpStatistics):
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
- (JSC::StructureID::getEnumerablePropertyNames):
- (JSC::StructureID::addPropertyTransition):
- (JSC::StructureID::removePropertyTransition):
- (JSC::StructureID::toDictionaryTransition):
- (JSC::StructureID::changePrototypeTransition):
- (JSC::StructureID::getterSetterTransition):
- (JSC::StructureID::addPropertyWithoutTransition):
- (JSC::StructureID::removePropertyWithoutTransition):
- (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
- (JSC::StructureID::checkConsistency):
- (JSC::StructureID::copyPropertyTable):
- (JSC::StructureID::get):
- (JSC::StructureID::put):
- (JSC::StructureID::remove):
- (JSC::StructureID::insertIntoPropertyMapHashTable):
- (JSC::StructureID::expandPropertyMapHashTable):
- (JSC::StructureID::createPropertyMapHashTable):
- (JSC::StructureID::rehashPropertyMapHashTable):
- (JSC::comparePropertyMapEntryIndices):
- (JSC::StructureID::getEnumerablePropertyNamesInternal):
- * runtime/StructureID.h:
- (JSC::StructureID::propertyStorageSize):
- (JSC::StructureID::isEmpty):
- (JSC::StructureID::get):
-
-2008-10-30 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
- <https://bugs.webkit.org/show_bug.cgi?id=21987>
-
- CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
- register as ecx, but it should be tempReg1, which is ecx at all of its
- callsites.
-
- * VM/CTI.cpp:
- (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
-
-2008-10-30 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 21985: Opcodes should use eax as their destination register whenever possible
- <https://bugs.webkit.org/show_bug.cgi?id=21985>
-
- Change more opcodes to use eax as the register for their final result,
- and change calls to emitPutResult() that pass eax to rely on the default
- value of eax.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
-
-2008-10-30 Alp Toker <alp@nuanti.com>
-
- Build fix attempt for older gcc on the trunk-mac-intel build bot
- (error: initializer for scalar variable requires one element).
-
- Modify the initializer syntax slightly with an additional comma.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_post_dec):
-
-2008-10-30 Alp Toker <alp@nuanti.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=21571
- VoidPtrPair breaks CTI on Linux
-
- The VoidPtrPair return change made in r37457 does not work on Linux
- since POD structs aren't passed in registers.
-
- This patch uses a union to vectorize VoidPtrPair to a uint64_t and
- matches Darwin/MSVC fixing CTI/WREC on Linux.
-
- Alexey reports no measurable change in Mac performance with this fix.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_post_dec):
- * VM/Machine.h:
- (JSC::):
-
-2008-10-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Initial work to reduce cost of JSNumberCell allocation
-
- This does the initial work needed to bring more of number
- allocation into CTI code directly, rather than just falling
- back onto the slow paths if we can't guarantee that a number
- cell can be reused.
-
- Initial implementation only used by op_negate to make sure
- it all works. In a negate heavy (though not dominated) test
- it results in a 10% win in the non-reusable cell case.
-
- * VM/CTI.cpp:
- (JSC::):
- (JSC::CTI::emitAllocateNumber):
- (JSC::CTI::emitNakedFastCall):
- (JSC::CTI::emitArithIntToImmWithJump):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitUnaryOp):
- * VM/CodeGenerator.h:
- (JSC::CodeGenerator::emitToJSNumber):
- (JSC::CodeGenerator::emitTypeOf):
- (JSC::CodeGenerator::emitGetPropertyNames):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- * VM/Machine.h:
- * kjs/ResultType.h:
- (JSC::ResultType::isReusableNumber):
- (JSC::ResultType::toInt):
- * kjs/nodes.cpp:
- (JSC::UnaryOpNode::emitCode):
- (JSC::BinaryOpNode::emitCode):
- (JSC::EqualNode::emitCode):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::negl_r):
- (JSC::X86Assembler::xorpd_mr):
- * runtime/JSNumberCell.h:
- (JSC::JSNumberCell::JSNumberCell):
-
-2008-10-29 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6326563> Crash on launch
-
- For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
-
- Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
- callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
- the explicit lock/unlock functions, we can avoid this.
-
- Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
-
- Reviewed by Darin Adler.
-
- * wtf/Threading.h:
- (WTF::lockAtomicallyInitializedStaticMutex):
- (WTF::unlockAtomicallyInitializedStaticMutex):
- * wtf/ThreadingWin.cpp:
- (WTF::lockAtomicallyInitializedStaticMutex):
- (WTF::unlockAtomicallyInitializedStaticMutex):
-
-2008-10-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Remove direct use of PropertyMap.
-
- * JavaScriptCore.exp:
- * runtime/JSObject.cpp:
- (JSC::JSObject::mark):
- (JSC::JSObject::put):
- (JSC::JSObject::deleteProperty):
- (JSC::JSObject::getPropertyAttributes):
- (JSC::JSObject::removeDirect):
- * runtime/JSObject.h:
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::hasCustomProperties):
- (JSC::JSObject::JSObject):
- (JSC::JSObject::putDirect):
- * runtime/PropertyMap.cpp:
- (JSC::PropertyMap::get):
- * runtime/PropertyMap.h:
- (JSC::PropertyMap::isEmpty):
- (JSC::PropertyMap::get):
- * runtime/StructureID.cpp:
- (JSC::StructureID::dumpStatistics):
- * runtime/StructureID.h:
- (JSC::StructureID::propertyStorageSize):
- (JSC::StructureID::get):
- (JSC::StructureID::put):
- (JSC::StructureID::remove):
- (JSC::StructureID::isEmpty):
-
-2008-10-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Rename and move the StructureID transition table to its own file.
-
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * runtime/StructureID.cpp:
- (JSC::StructureID::addPropertyTransition):
- * runtime/StructureID.h:
- (JSC::StructureID::):
- * runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h.
- (JSC::StructureIDTransitionTableHash::hash):
- (JSC::StructureIDTransitionTableHash::equal):
-
-2008-10-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21958
- Pack bits in StructureID to reduce the size of each StructureID by 2 words.
-
- * runtime/PropertyMap.h:
- (JSC::PropertyMap::propertyMapSize):
- * runtime/StructureID.cpp:
- (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping.
- (JSC::StructureID::StructureID):
- * runtime/StructureID.h:
-
-2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after addition of runtime and ImageBuffer changes.
-
- * JavaScriptCoreSources.bkl:
- * jscore.bkl:
-
-2008-10-29 Timothy Hatcher <timothy@apple.com>
-
- Emit the WillExecuteStatement debugger hook before the "else" body
- when there is no block for the "else" body. This allows breakpoints
- on those statements in the Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=21944
-
- Reviewed by Maciej Stachowiak.
-
- * kjs/nodes.cpp:
- (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement
- debugger hook before the else node if isn't a block.
-
-2008-10-29 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix.
-
- * JavaScriptCore.exp: Export HashTable::deleteTable().
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- Fix builddir != srcdir builds after kjs -> runtime breakage. Sources
- may now be generated in both kjs/ and runtime/.
-
- Also sort the sources list for readability.
-
- * GNUmakefile.am:
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- Reviewed by Cameron Zwarich.
-
- Build fix attempt after kjs -> runtime rename.
-
- * GNUmakefile.am:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Remove a duplicate includes directory.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Attempt to fix the Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2008-10-28 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - export WTF::atomicallyInitializedStaticMutex
-
- * JavaScriptCore.exp:
-
-2008-10-28 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed CodeBlock dumping to accurately report constant register indices.
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- More Qt build fixes.
-
- * JavaScriptCore.pri:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the Qt build, hopefully for real this time.
-
- * JavaScriptCore.pri:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the Qt build.
-
- * JavaScriptCore.pri:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Create a runtime directory in JavaScriptCore and begin moving files to
- it. This is the first step towards removing the kjs directory and
- placing files in more meaningful subdirectories of JavaScriptCore.
-
- * API/JSBase.cpp:
- * API/JSCallbackConstructor.cpp:
- * API/JSCallbackConstructor.h:
- * API/JSCallbackFunction.cpp:
- * API/JSClassRef.cpp:
- * API/JSClassRef.h:
- * API/JSStringRefCF.cpp:
- * API/JSValueRef.cpp:
- * API/OpaqueJSString.cpp:
- * DerivedSources.make:
- * GNUmakefile.am:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/AllInOneFile.cpp:
- * kjs/ArrayConstructor.cpp: Removed.
- * kjs/ArrayConstructor.h: Removed.
- * kjs/ArrayPrototype.cpp: Removed.
- * kjs/ArrayPrototype.h: Removed.
- * kjs/BooleanConstructor.cpp: Removed.
- * kjs/BooleanConstructor.h: Removed.
- * kjs/BooleanObject.cpp: Removed.
- * kjs/BooleanObject.h: Removed.
- * kjs/BooleanPrototype.cpp: Removed.
- * kjs/BooleanPrototype.h: Removed.
- * kjs/CallData.cpp: Removed.
- * kjs/CallData.h: Removed.
- * kjs/ClassInfo.h: Removed.
- * kjs/ConstructData.cpp: Removed.
- * kjs/ConstructData.h: Removed.
- * kjs/DateConstructor.cpp: Removed.
- * kjs/DateConstructor.h: Removed.
- * kjs/DateInstance.cpp: Removed.
- * kjs/DateInstance.h: Removed.
- * kjs/DateMath.cpp: Removed.
- * kjs/DateMath.h: Removed.
- * kjs/DatePrototype.cpp: Removed.
- * kjs/DatePrototype.h: Removed.
- * kjs/Error.cpp: Removed.
- * kjs/Error.h: Removed.
- * kjs/ErrorConstructor.cpp: Removed.
- * kjs/ErrorConstructor.h: Removed.
- * kjs/ErrorInstance.cpp: Removed.
- * kjs/ErrorInstance.h: Removed.
- * kjs/ErrorPrototype.cpp: Removed.
- * kjs/ErrorPrototype.h: Removed.
- * kjs/FunctionConstructor.cpp: Removed.
- * kjs/FunctionConstructor.h: Removed.
- * kjs/FunctionPrototype.cpp: Removed.
- * kjs/FunctionPrototype.h: Removed.
- * kjs/GlobalEvalFunction.cpp: Removed.
- * kjs/GlobalEvalFunction.h: Removed.
- * kjs/InternalFunction.cpp: Removed.
- * kjs/InternalFunction.h: Removed.
- * kjs/JSArray.cpp: Removed.
- * kjs/JSArray.h: Removed.
- * kjs/JSCell.cpp: Removed.
- * kjs/JSCell.h: Removed.
- * kjs/JSFunction.cpp: Removed.
- * kjs/JSFunction.h: Removed.
- * kjs/JSGlobalObject.cpp: Removed.
- * kjs/JSGlobalObject.h: Removed.
- * kjs/JSGlobalObjectFunctions.cpp: Removed.
- * kjs/JSGlobalObjectFunctions.h: Removed.
- * kjs/JSImmediate.cpp: Removed.
- * kjs/JSImmediate.h: Removed.
- * kjs/JSNotAnObject.cpp: Removed.
- * kjs/JSNotAnObject.h: Removed.
- * kjs/JSNumberCell.cpp: Removed.
- * kjs/JSNumberCell.h: Removed.
- * kjs/JSObject.cpp: Removed.
- * kjs/JSObject.h: Removed.
- * kjs/JSString.cpp: Removed.
- * kjs/JSString.h: Removed.
- * kjs/JSValue.cpp: Removed.
- * kjs/JSValue.h: Removed.
- * kjs/JSVariableObject.cpp: Removed.
- * kjs/JSVariableObject.h: Removed.
- * kjs/JSWrapperObject.cpp: Removed.
- * kjs/JSWrapperObject.h: Removed.
- * kjs/MathObject.cpp: Removed.
- * kjs/MathObject.h: Removed.
- * kjs/NativeErrorConstructor.cpp: Removed.
- * kjs/NativeErrorConstructor.h: Removed.
- * kjs/NativeErrorPrototype.cpp: Removed.
- * kjs/NativeErrorPrototype.h: Removed.
- * kjs/NumberConstructor.cpp: Removed.
- * kjs/NumberConstructor.h: Removed.
- * kjs/NumberObject.cpp: Removed.
- * kjs/NumberObject.h: Removed.
- * kjs/NumberPrototype.cpp: Removed.
- * kjs/NumberPrototype.h: Removed.
- * kjs/ObjectConstructor.cpp: Removed.
- * kjs/ObjectConstructor.h: Removed.
- * kjs/ObjectPrototype.cpp: Removed.
- * kjs/ObjectPrototype.h: Removed.
- * kjs/PropertyMap.cpp: Removed.
- * kjs/PropertyMap.h: Removed.
- * kjs/PropertySlot.cpp: Removed.
- * kjs/PropertySlot.h: Removed.
- * kjs/PrototypeFunction.cpp: Removed.
- * kjs/PrototypeFunction.h: Removed.
- * kjs/PutPropertySlot.h: Removed.
- * kjs/SmallStrings.cpp: Removed.
- * kjs/SmallStrings.h: Removed.
- * kjs/StringConstructor.cpp: Removed.
- * kjs/StringConstructor.h: Removed.
- * kjs/StringObject.cpp: Removed.
- * kjs/StringObject.h: Removed.
- * kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
- * kjs/StringPrototype.cpp: Removed.
- * kjs/StringPrototype.h: Removed.
- * kjs/StructureID.cpp: Removed.
- * kjs/StructureID.h: Removed.
- * kjs/completion.h:
- * kjs/interpreter.h:
- * runtime: Added.
- * runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
- * runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
- * runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
- * runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
- * runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
- * runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
- * runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
- * runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
- * runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
- * runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
- * runtime/CallData.cpp: Copied from kjs/CallData.cpp.
- * runtime/CallData.h: Copied from kjs/CallData.h.
- * runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
- * runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
- * runtime/ConstructData.h: Copied from kjs/ConstructData.h.
- * runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
- * runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
- * runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
- * runtime/DateInstance.h: Copied from kjs/DateInstance.h.
- * runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
- * runtime/DateMath.h: Copied from kjs/DateMath.h.
- * runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
- * runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
- * runtime/Error.cpp: Copied from kjs/Error.cpp.
- * runtime/Error.h: Copied from kjs/Error.h.
- * runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
- * runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
- * runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
- * runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
- * runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
- * runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
- * runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
- * runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
- * runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
- * runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
- * runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
- * runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
- * runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
- * runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
- * runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
- * runtime/JSArray.h: Copied from kjs/JSArray.h.
- * runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
- * runtime/JSCell.h: Copied from kjs/JSCell.h.
- * runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
- * runtime/JSFunction.h: Copied from kjs/JSFunction.h.
- * runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
- * runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
- * runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
- * runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
- * runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
- * runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
- * runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
- * runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
- * runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
- * runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
- * runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
- * runtime/JSObject.h: Copied from kjs/JSObject.h.
- * runtime/JSString.cpp: Copied from kjs/JSString.cpp.
- * runtime/JSString.h: Copied from kjs/JSString.h.
- * runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
- * runtime/JSValue.h: Copied from kjs/JSValue.h.
- * runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
- * runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
- * runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
- * runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
- * runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
- * runtime/MathObject.h: Copied from kjs/MathObject.h.
- * runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
- * runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
- * runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
- * runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
- * runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
- * runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
- * runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
- * runtime/NumberObject.h: Copied from kjs/NumberObject.h.
- * runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
- * runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
- * runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
- * runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
- * runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
- * runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
- * runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
- * runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
- * runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
- * runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
- * runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
- * runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
- * runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
- * runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
- * runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
- * runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
- * runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
- * runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
- * runtime/StringObject.h: Copied from kjs/StringObject.h.
- * runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
- * runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
- * runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
- * runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
- * runtime/StructureID.h: Copied from kjs/StructureID.h.
-
-2008-10-28 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
- Sampler reports bogus time in op_enter during 3d-raytrace.js
-
- Fixed a bug where we would pass the incorrect Instruction* during some
- parts of CTI codegen.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/SamplingTool.cpp:
- (JSC::SamplingTool::run):
- * wtf/Platform.h:
-
-2008-10-28 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- -Removed unused includes.
- Apparent .4% speedup in Sunspider
-
- * kjs/JSObject.cpp:
- * kjs/interpreter.cpp:
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- Include copyright license files in the autotools dist target.
-
- Change suggested by Mike Hommey.
-
- * GNUmakefile.am:
-
-2008-10-27 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Stop discarding CodeBlock samples that can't be charged to a specific
- opcode. Instead, charge the relevant CodeBlock, and provide a footnote
- explaining the situation.
-
- This will help us tell which CodeBlocks are hot, even if we can't
- identify specific lines of code within the CodeBlocks.
-
- * VM/SamplingTool.cpp:
- (JSC::ScopeSampleRecord::sample):
- (JSC::compareScopeSampleRecords):
- (JSC::SamplingTool::dump):
-
- * VM/SamplingTool.h:
- (JSC::ScopeSampleRecord::ScopeSampleRecord):
- (JSC::ScopeSampleRecord::~ScopeSampleRecord):
-
-2008-10-27 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
- when sampling the v8 tests.
-
- * VM/SamplingTool.cpp:
- (JSC::SamplingTool::run):
- (JSC::SamplingTool::notifyOfScope):
- * VM/SamplingTool.h: Since new ScopeNodes can be created after
- the SamplingTools has begun sampling, reads and writes to / from the
- map need to be synchronized. Shark says this doesn't measurably increase
- sampling overhead.
-
-2008-10-25 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): Provide a dummy value to the
- HostCallRecord in CTI non-sampling builds, to silence compiler warning.
-
-2008-10-25 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Windows build.
-
- * VM/SamplingTool.h:
- (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to
- silence compiler warning.
-
-2008-10-25 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig, with Gavin Barraclough's help.
-
- Fixed Sampling Tool:
- - Made CodeBlock sampling work with CTI
- - Improved accuracy by unifying most sampling data into a single
- 32bit word, which can be written / read atomically.
- - Split out three different #ifdefs for modularity: OPCODE_SAMPLING;
- CODEBLOCK_SAMPLING; OPCODE_STATS.
- - Improved reporting clarity
- - Refactored for code clarity
-
- * JavaScriptCore.exp: Exported another symbol.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCTICall):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface
- for encoding samples. (This required passing the current vPC to a lot
- more functions, since the unified interface samples the current vPC.)
- Added hooks for writing the current CodeBlock* on function entry and
- after a function call, for the sake of the CodeBlock sampler. Removed
- obsolete hook for clearing the current sample inside op_end. Also removed
- the custom enum used to differentiate flavors of op_call, since the
- OpcodeID enum works just as well. (This was important in an earlier
- version of the patch, but now it's just cleanup.)
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::lineNumberForVPC):
- * VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC
- to be robust against vPCs not recorded for exception handling, since
- the Sampler may ask for an arbitrary vPC.
-
- * VM/Machine.cpp:
- (JSC::Machine::execute):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- * VM/Machine.h:
- (JSC::Machine::setSampler):
- (JSC::Machine::sampler):
- (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed
- Machine to use SamplingTool helper objects to record movement in and
- out of host code. This makes samples a bit more precise.
-
- * VM/Opcode.cpp:
- (JSC::OpcodeStats::~OpcodeStats):
- * VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding,
- to accomodate our more verbose opcode names.
-
- * VM/SamplingTool.cpp:
- (JSC::ScopeSampleRecord::sample): Only count a sample toward our total
- if we actually record it. This solves cases where a CodeBlock will
- claim to have been sampled many times, with reported samples that don't
- match.
-
- (JSC::SamplingTool::run): Read the current sample into a Sample helper
- object, to ensure that the data doesn't change while we're analyzing it,
- and to help decode the data. Only access the CodeBlock sampling hash
- table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
- runs can operate with even less overhead.
-
- (JSC::SamplingTool::dump): I reorganized this code a lot to print the
- most important info at the top, print as a table, annotate and document
- the stuff I didn't understand when I started, etc.
-
- * VM/SamplingTool.h: New helper classes, described above.
-
- * kjs/Parser.h:
- * kjs/Shell.cpp:
- (runWithScripts):
- * kjs/nodes.cpp:
- (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.
-
- * wtf/Platform.h: Moved sampling #defines here, since our custom is to
- put ENABLE #defines into Platform.h. Made explicit the fact that
- CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.
-
-2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- JSC Build fix, not reviewed.
-
- * VM/CTI.cpp: add missing include stdio.h for debug builds
-
-2008-10-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Get rid of a bonus ASSERT when using a null string as a regexp.
- Specifically calling: RegularExpression::match() with String::empty()
- will hit this ASSERT.
- Chromium hits this, but I don't know of any way to make a layout test.
-
- * pcre/pcre_exec.cpp:
- (jsRegExpExecute):
-
-2008-10-24 Alexey Proskuryakov <ap@webkit.org>
-
- Suggested and rubber-stamped by Geoff Garen.
-
- Fix a crash when opening Font Picker.
-
- The change also hopefully fixes this bug, which I could never reproduce:
- https://bugs.webkit.org/show_bug.cgi?id=20241
- <rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close
-
- * API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of
- dynamic one.
-
-2008-10-24 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove ScopeChainNode::bottom() and inline it into its only caller,
- ScopeChainnode::globalObject().
-
- * kjs/JSGlobalObject.h:
- (JSC::ScopeChainNode::globalObject):
- * kjs/ScopeChain.h:
- (JSC::ScopeChain::bottom):
-
-2008-10-24 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21862: Create JSFunction prototype property lazily
- <https://bugs.webkit.org/show_bug.cgi?id=21862>
-
- This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
- benchmark suite, including a 3.8% speedup on Earley-Boyer.
-
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::getOwnPropertySlot):
- * kjs/nodes.cpp:
- (JSC::FuncDeclNode::makeFunction):
- (JSC::FuncExprNode::makeFunction):
-
-2008-10-24 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21475
-
- Provide support for the Geolocation API
-
- http://dev.w3.org/geo/api/spec-source.html
-
- * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0
-
-2008-10-24 Darin Adler <darin@apple.com>
-
- - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
-
- * API/APICast.h:
- * API/JSCallbackConstructor.h:
- * API/JSCallbackFunction.cpp:
- * API/JSCallbackFunction.h:
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- * API/JSValueRef.cpp:
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- * VM/CodeGenerator.h:
- * VM/ExceptionHelpers.cpp:
- * VM/ExceptionHelpers.h:
- * VM/JSPropertyNameIterator.cpp:
- * VM/JSPropertyNameIterator.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * VM/Register.h:
- * kjs/ArgList.cpp:
- * kjs/ArgList.h:
- * kjs/Arguments.cpp:
- * kjs/Arguments.h:
- * kjs/ArrayConstructor.cpp:
- * kjs/ArrayPrototype.cpp:
- * kjs/BooleanConstructor.cpp:
- * kjs/BooleanConstructor.h:
- * kjs/BooleanObject.h:
- * kjs/BooleanPrototype.cpp:
- * kjs/CallData.cpp:
- * kjs/CallData.h:
- * kjs/ConstructData.cpp:
- * kjs/ConstructData.h:
- * kjs/DateConstructor.cpp:
- * kjs/DateInstance.h:
- * kjs/DatePrototype.cpp:
- * kjs/DatePrototype.h:
- * kjs/DebuggerCallFrame.cpp:
- * kjs/DebuggerCallFrame.h:
- * kjs/ErrorConstructor.cpp:
- * kjs/ErrorPrototype.cpp:
- * kjs/ExecState.cpp:
- * kjs/ExecState.h:
- * kjs/FunctionConstructor.cpp:
- * kjs/FunctionPrototype.cpp:
- * kjs/FunctionPrototype.h:
- * kjs/GetterSetter.cpp:
- * kjs/GetterSetter.h:
- * kjs/InternalFunction.h:
- * kjs/JSActivation.cpp:
- * kjs/JSActivation.h:
- * kjs/JSArray.cpp:
- * kjs/JSArray.h:
- * kjs/JSCell.cpp:
- * kjs/JSCell.h:
- * kjs/JSFunction.cpp:
- * kjs/JSFunction.h:
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.cpp:
- * kjs/JSGlobalObject.h:
- * kjs/JSGlobalObjectFunctions.cpp:
- * kjs/JSGlobalObjectFunctions.h:
- * kjs/JSImmediate.cpp:
- * kjs/JSImmediate.h:
- * kjs/JSNotAnObject.cpp:
- * kjs/JSNotAnObject.h:
- * kjs/JSNumberCell.cpp:
- * kjs/JSNumberCell.h:
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- * kjs/JSStaticScopeObject.cpp:
- * kjs/JSStaticScopeObject.h:
- * kjs/JSString.cpp:
- * kjs/JSString.h:
- * kjs/JSValue.h:
- * kjs/JSVariableObject.h:
- * kjs/JSWrapperObject.h:
- * kjs/MathObject.cpp:
- * kjs/MathObject.h:
- * kjs/NativeErrorConstructor.cpp:
- * kjs/NumberConstructor.cpp:
- * kjs/NumberConstructor.h:
- * kjs/NumberObject.cpp:
- * kjs/NumberObject.h:
- * kjs/NumberPrototype.cpp:
- * kjs/ObjectConstructor.cpp:
- * kjs/ObjectPrototype.cpp:
- * kjs/ObjectPrototype.h:
- * kjs/PropertyMap.h:
- * kjs/PropertySlot.cpp:
- * kjs/PropertySlot.h:
- * kjs/RegExpConstructor.cpp:
- * kjs/RegExpConstructor.h:
- * kjs/RegExpMatchesArray.h:
- * kjs/RegExpObject.cpp:
- * kjs/RegExpObject.h:
- * kjs/RegExpPrototype.cpp:
- * kjs/Shell.cpp:
- * kjs/StringConstructor.cpp:
- * kjs/StringObject.cpp:
- * kjs/StringObject.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- * kjs/StringPrototype.cpp:
- * kjs/StructureID.cpp:
- * kjs/StructureID.h:
- * kjs/collector.cpp:
- * kjs/collector.h:
- * kjs/completion.h:
- * kjs/grammar.y:
- * kjs/interpreter.cpp:
- * kjs/interpreter.h:
- * kjs/lookup.cpp:
- * kjs/lookup.h:
- * kjs/nodes.h:
- * kjs/operations.cpp:
- * kjs/operations.h:
- * kjs/protect.h:
- * profiler/ProfileGenerator.cpp:
- * profiler/Profiler.cpp:
- * profiler/Profiler.h:
- Use JSValue* instead of JSValuePtr.
-
-2008-10-24 David Kilzer <ddkilzer@apple.com>
-
- Rolled out r37840.
-
- * wtf/Platform.h:
-
-2008-10-23 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21475
-
- Provide support for the Geolocation API
-
- http://dev.w3.org/geo/api/spec-source.html
-
- * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0
-
-2008-10-23 David Kilzer <ddkilzer@apple.com>
-
- Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
-
- <https://bugs.webkit.org/show_bug.cgi?id=21832>
-
- Reviewed by Sam Weinig.
-
- * pcre/dftables: Use imported tempfile() from File::Temp instead of
- 'new File::Temp' to make the script work with Perl 5.10.
-
-2008-10-23 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix hideous pathological case performance when looking up repatch info, bug #21727.
-
- When repatching JIT code to optimize we look up records providing information about
- the generated code (also used to track recsources used in linking to be later released).
- The lookup was being performed using a linear scan of all such records.
-
- (1) Split up the different types of reptach information. This means we can search them
- separately, and in some cases should reduce their size.
- (2) In the case of property accesses, search with a binary chop over the data.
- (3) In the case of calls, pass a pointer to the repatch info into the relink function.
-
- * VM/CTI.cpp:
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::unlinkCall):
- (JSC::CTI::linkCall):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::unlinkCallers):
- (JSC::CodeBlock::derefStructureIDs):
- * VM/CodeBlock.h:
- (JSC::StructureStubInfo::StructureStubInfo):
- (JSC::CallLinkInfo::CallLinkInfo):
- (JSC::CallLinkInfo::setUnlinked):
- (JSC::CallLinkInfo::isLinked):
- (JSC::getStructureStubInfoReturnLocation):
- (JSC::binaryChop):
- (JSC::CodeBlock::addCaller):
- (JSC::CodeBlock::getStubInfo):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitResolve):
- (JSC::CodeGenerator::emitGetById):
- (JSC::CodeGenerator::emitPutById):
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitConstruct):
- * VM/Machine.cpp:
- (JSC::Machine::cti_vm_lazyLinkCall):
-
-2008-10-23 Peter Kasting <pkasting@google.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=21833
- Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
-
- * wtf/Platform.h:
-
-2008-10-23 David Kilzer <ddkilzer@apple.com>
-
- Bug 21831: Fix create_hash_table for Perl 5.10
-
- <https://bugs.webkit.org/show_bug.cgi?id=21831>
-
- Reviewed by Sam Weinig.
-
- * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
- doesn't try to use @nameEntries.
-
-2008-10-23 Darin Adler <darin@apple.com>
-
- - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
- to remove the JSValuePtr class, to fix two problems
-
- 1) slowness under MSVC, since it doesn't handle a
- class with a single pointer in it as efficiently
- as a pointer
-
- 2) uninitialized pointers in Vector
-
- * JavaScriptCore.exp: Updated.
-
- * API/APICast.h:
- (toRef):
- * VM/CTI.cpp:
- (JSC::CTI::asInteger):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::addConstant):
- * VM/CodeGenerator.h:
- (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue):
- (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_vm_throw):
- Removed calls to payload functions.
-
- * VM/Register.h:
- (JSC::Register::Register): Removed overload for JSCell and call
- to payload function.
-
- * kjs/JSCell.h: Changed JSCell to derive from JSValue again.
- Removed JSValuePtr constructor.
- (JSC::asCell): Changed cast from reinterpret_cast to static_cast.
-
- * kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.
-
- * kjs/JSValue.h:
- (JSC::JSValue::JSValue): Added empty protected inline constructor back.
- (JSC::JSValue::~JSValue): Same for destructor.
- Removed == and != operator for JSValuePtr.
-
- * kjs/PropertySlot.h:
- (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue*
- and added a const_cast.
-
- * kjs/protect.h: Removed overloads and specialization for JSValuePtr.
-
-2008-10-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Really "fix" CTI mode on windows 2k3.
-
- This adds new methods fastMallocExecutable and fastFreeExecutable
- to wrap allocation for cti code. This still just makes fastMalloc
- return executable memory all the time, which will be fixed in a
- later patch.
-
- However in windows debug builds all executable allocations will be
- allocated on separate executable pages, which should resolve any
- remaining 2k3 issues. Conveniently the 2k3 bot will now also fail
- if there are any fastFree vs. fastFreeExecutable errors.
-
- * ChangeLog:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::~CodeBlock):
- * kjs/regexp.cpp:
- (JSC::RegExp::~RegExp):
- * masm/X86Assembler.h:
- (JSC::JITCodeBuffer::copy):
- * wtf/FastMalloc.cpp:
- (WTF::fastMallocExecutable):
- (WTF::fastFreeExecutable):
- (WTF::TCMallocStats::fastMallocExecutable):
- (WTF::TCMallocStats::fastFreeExecutable):
- * wtf/FastMalloc.h:
-
-2008-10-22 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21294
- Bug 21294: Devirtualize getOwnPropertySlot()
-
- A bit over 3% faster on V8 tests.
-
- * JavascriptCore.exp: Export leak-related functions..
-
- * API/JSCallbackConstructor.h:
- (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot
- since this class doesn't override getPropertySlot.
- * API/JSCallbackFunction.h:
- (JSC::JSCallbackFunction::createStructureID): Ditto.
-
- * VM/ExceptionHelpers.cpp:
- (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure
- that's created just for this class instead of trying to share a single "null
- prototype" structure.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_create_arguments_no_params): Rename
- Arguments::ArgumentsNoParameters to Arguments::NoParameters.
-
- * kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to
- Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters
- to Arguments::NoParameters.
- (JSC::Arguments::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
- (JSC::Arguments::Arguments): Added an assertion that there are no parameters.
-
- * kjs/DatePrototype.h:
- (JSC::DatePrototype::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * kjs/FunctionPrototype.h:
- (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot
- since this class doesn't override getPropertySlot.
- * kjs/InternalFunction.h:
- (JSC::InternalFunction::createStructureID): Ditto.
-
- * kjs/JSArray.h:
- (JSC::JSArray::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual
- version that uses the structure bit to decide whether to call the virtual
- version.
-
- * kjs/JSFunction.h:
- (JSC::JSFunction::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed
- nullProtoStructureID.
- * kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.
-
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * kjs/JSNotAnObject.h:
- (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure
- that's created just for this class instead of trying to share a single "null
- prototype" structure.
- (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function
- virtual for clarity and made it private since no one should call it if they
- already have a pointer to this specific type.
- (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just
- for this class instead of trying to share a single "null prototype" structure.
- (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * kjs/JSObject.h:
- (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot.
- (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code
- between getOwnPropertySlot and fastGetOwnPropertySlot.
- (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the
- functions that call them. Moved the guts of this function into
- inlineGetOwnPropertySlot.
- (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the
- HasStandardGetOwnPropertySlot bit and if it's set, calls
- inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot.
- (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot.
- (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.
-
- * kjs/JSWrapperObject.h: Made constructor protected to emphasize that
- this class is only a base class and never instantiated.
-
- * kjs/MathObject.h:
- (JSC::MathObject::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
- * kjs/NumberConstructor.h:
- (JSC::NumberConstructor::createStructureID): Ditto.
- * kjs/RegExpConstructor.h:
- (JSC::RegExpConstructor::createStructureID): Ditto.
- * kjs/RegExpObject.h:
- (JSC::RegExpObject::createStructureID): Ditto.
- * kjs/StringObject.h:
- (JSC::StringObject::createStructureID): Ditto.
-
- * kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and
- hasStandardGetOwnPropertySlot accessor function.
-
-2008-10-22 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
- <https://bugs.webkit.org/show_bug.cgi?id=21803>
-
- Fuse op_jfalse with op_eq_null and op_neq_null to make the new opcodes
- op_jeq_null and op_jneq_null.
-
- This is a 2.6% speedup on the V8 Raytrace benchmark, and strangely also
- a 4.7% speedup on the V8 Arguments benchmark, even though it uses
- neither of the two new opcodes.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitJumpIfTrue):
- (JSC::CodeGenerator::emitJumpIfFalse):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- * VM/Opcode.h:
-
-2008-10-22 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
- https://bugs.webkit.org/show_bug.cgi?id=21757
-
- PLATFORM(CHROMIUM) implies HAVE_ACCESSIBILITY
-
- * wtf/Platform.h:
-
-2008-10-22 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Correct opcode names in documentation.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-21 Oliver Hunt <oliver@apple.com>
-
- RS=Maciej Stachowiak.
-
- Force FastMalloc to make all allocated pages executable in
- a vague hope this will allow the Win2k3 bot to be able to
- run tests.
-
- Filed Bug 21783: Need more granular control over allocation of executable memory
- to cover a more granular version of this patch.
-
- * wtf/TCSystemAlloc.cpp:
- (TryVirtualAlloc):
-
-2008-10-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21769
- MessagePort should be GC protected if there are messages to be delivered
-
- * wtf/MessageQueue.h:
- (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue
- state, thus likely to cause race conditions.
-
-2008-10-21 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - convert post-increment to pre-increment in a couple more places for speed
-
- Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
- them down a little on my computer.)
-
- * kjs/nodes.cpp:
- (JSC::statementListEmitCode): Removed default argument, since we always want
- to specify this explicitly.
- (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the
- same thing as 0.
- (JSC::ReturnNode::emitCode): Ditto.
- (JSC::ThrowNode::emitCode): Ditto.
- (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we
- don't have to compute the result of function statements.
-
-2008-10-21 Peter Kasting <pkasting@google.com>
-
- Reviewed by Maciej Stachowiak.
-
- Fix an include of a non-public header to use "" instead of <>.
-
- * API/JSProfilerPrivate.cpp:
-
-2008-10-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
- REGRESSION: 12 JSC tests fail
-
- The JSGlobalObject was mutating the shared nullProtoStructureID when
- used in jsc. Instead of using nullProtoStructureID, use a new StructureID.
-
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- (JSC::::JSCallbackObject):
- * API/JSContextRef.cpp:
- (JSGlobalContextCreateInGroup):
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObject):
- * kjs/Shell.cpp:
- (GlobalObject::GlobalObject):
- (jscmain):
-
-2008-10-20 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Remove an untaken branch in CodeGenerator::emitJumpIfFalse(). This
- function is never called with a backwards target LabelID, and there is
- even an assertion to this effect at the top of the function body.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitJumpIfFalse):
-
-2008-10-20 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Add opcode documentation for undocumented opcodes.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
- Don't create intermediate StructureIDs for builtin objects
-
- Second stage in reduce number of StructureIDs created when initializing the
- JSGlobalObject.
-
- - Use putDirectWithoutTransition for the remaining singleton objects to reduce
- the number of StructureIDs create for about:blank from 132 to 73.
-
- * kjs/ArrayConstructor.cpp:
- (JSC::ArrayConstructor::ArrayConstructor):
- * kjs/BooleanConstructor.cpp:
- (JSC::BooleanConstructor::BooleanConstructor):
- * kjs/BooleanPrototype.cpp:
- (JSC::BooleanPrototype::BooleanPrototype):
- * kjs/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- * kjs/ErrorConstructor.cpp:
- (JSC::ErrorConstructor::ErrorConstructor):
- * kjs/ErrorPrototype.cpp:
- (JSC::ErrorPrototype::ErrorPrototype):
- * kjs/FunctionConstructor.cpp:
- (JSC::FunctionConstructor::FunctionConstructor):
- * kjs/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::FunctionPrototype):
- (JSC::FunctionPrototype::addFunctionProperties):
- * kjs/FunctionPrototype.h:
- (JSC::FunctionPrototype::createStructureID):
- * kjs/InternalFunction.cpp:
- * kjs/InternalFunction.h:
- (JSC::InternalFunction::InternalFunction):
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- * kjs/JSObject.h:
- * kjs/MathObject.cpp:
- (JSC::MathObject::MathObject):
- * kjs/NumberConstructor.cpp:
- (JSC::NumberConstructor::NumberConstructor):
- * kjs/NumberPrototype.cpp:
- (JSC::NumberPrototype::NumberPrototype):
- * kjs/ObjectConstructor.cpp:
- (JSC::ObjectConstructor::ObjectConstructor):
- * kjs/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::RegExpConstructor):
- * kjs/RegExpPrototype.cpp:
- (JSC::RegExpPrototype::RegExpPrototype):
- * kjs/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
- * kjs/StringPrototype.cpp:
- (JSC::StringPrototype::StringPrototype):
- * kjs/StructureID.cpp:
- (JSC::StructureID::dumpStatistics):
- * kjs/StructureID.h:
- (JSC::StructureID::setPrototypeWithoutTransition):
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Fix autotools dist build target by listing recently added header
- files only. Not reviewed.
-
- * GNUmakefile.am:
-
-2008-10-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Anders Carlsson.
-
- * VM/Machine.cpp:
- (JSC::Machine::tryCacheGetByID): Removed a redundant and sometimes
- incorrect cast, which started ASSERTing after Darin's last checkin.
-
-2008-10-20 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Re-enable CTI, which I accidentally disabled while checking in fixes
- to bytecode.
-
- * wtf/Platform.h:
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Rubber-stamped by Mark Rowe.
-
- Typo fix in function name: mimimum -> minimum.
-
- * kjs/DateMath.cpp:
- (JSC::minimumYearForDST):
- (JSC::equivalentYearForDST):
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Reviewed by Mark Rowe.
-
- Use pthread instead of GThread where possible in the GTK+ port. This
- fixes issues with global initialisation, particularly on GTK+/Win32
- where a late g_thread_init() will cause hangs.
-
- * GNUmakefile.am:
- * wtf/Platform.h:
- * wtf/Threading.h:
- * wtf/ThreadingGtk.cpp:
- * wtf/ThreadingPthreads.cpp:
-
-2008-10-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
- Emit profiling instrumentation only if the Web Inspector's profiling
- feature is enabled
-
- 22.2% speedup on empty function call benchmark.
- 2.9% speedup on v8 benchmark.
- 0.7% speedup on SunSpider.
-
- Lesser but similar speedups in bytecode.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases): Nixed JITed profiler hooks. Profiler
- hooks now have their own opcodes. Added support for compiling profiler
- hook opcodes.
-
- (JSC::CodeBlock::dump): Dump support for the new profiling opcodes.
-
- * VM/CodeGenerator.h:
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitConstruct): Conditionally emit profiling hooks
- around call and construct, at the call site. (It's easier to get things
- right this way, if you have profiled code calling non-profiled code.
- Also, you get a slightly more accurate profile, since you charge the full
- cost of the call / construct operation to the callee.)
-
- Also, fixed a bug where construct would fetch the ".prototype" property
- from the constructor before evaluating the arguments to the constructor,
- incorrectly allowing an "invalid constructor" exception to short-circuit
- argument evaluation. I encountered this bug when trying to make
- constructor exceptions work with profiling.
-
- * VM/Machine.cpp:
- (JSC::Machine::callEval): Removed obsolete profiler hooks.
- (JSC::Machine::throwException): Added a check for an exception thrown
- within a call instruction. We didn't need this before because the call
- instruction would check for a valid call before involing the profiler.
- (JSC::Machine::execute): Added a didExecute hook at the end of top-level
- function invocation, since op_ret no longer does this for us.
+2009-06-18 Gavin Barraclough <barraclough@apple.com>
- (JSC::Machine::privateExecute): Removed obsolete profiler hooks. Added
- profiler opcodes. Changed some ++vPC to vPC[x] notation, since the
- latter is better for performance, and it makes reasoning about the
- current opcode in exception handling much simpler.
+ Reviewed by NOBODY (Windows build fix).
- (JSC::Machine::cti_op_call_NotJSFunction): Removed obsolete profiler
- hooks.
+ * wtf/DateMath.cpp:
+ (WTF::calculateUTCOffset):
- (JSC::Machine::cti_op_create_arguments_no_params): Added missing
- CTI_STACK_HACK that I noticed when adding CTI_STACK_HACK to the new
- profiler opcode functions.
-
- (JSC::Machine::cti_op_profile_will_call):
- (JSC::Machine::cti_op_profile_did_call): The new profiler opcode
- functions.
-
- (JSC::Machine::cti_op_construct_NotJSConstruct): Removed obsolete profiler
- hooks.
-
- * VM/Machine.h:
- (JSC::Machine::isCallOpcode): Helper for exception handling.
-
- * VM/Opcode.h: Declare new opcodes.
-
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::supportsProfiling): Added virtual interface that
- allows WebCore to specify whether the target global object has the Web
- Inspector's profiling feature enabled.
-
- * profiler/Profiler.cpp:
- (JSC::Profiler::willExecute):
- (JSC::Profiler::didExecute):
- (JSC::Profiler::createCallIdentifier):
- * profiler/Profiler.h: Added support for invoking the profiler with
- an arbitrary JSValue*, and not a known object. We didn't need this
- before because the call instruction would check for a valid call before
- involing the profiler.
-
-2008-10-20 Darin Adler <darin@apple.com>
+2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
- - get CTI working on Windows again
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCTICall): Add an overload for functions that
- return JSObject*.
- * VM/CTI.h: Use JSValue* and JSObject* as return types for
- cti_op functions. Apparently, MSVC doesn't handle returning
- the JSValuePtr struct in a register. We'll have to look into
- this more.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstructFast):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_vm_throw):
- Change these functions to return pointer types, and never
- JSValuePtr.
- * VM/Machine.h: Ditto.
-
-2008-10-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed some recent break-age in bytecode mode.
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::printStructureIDs): Fixed up an ASSERT caused by
- Gavin's last checkin. This is a temporary fix so I can keep on moving.
- I'll send email about what I think is an underlying problem soon.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): Removed a redundant and sometimes
- incorrect cast, which started ASSERTing after Darin's last checkin.
-
-2008-10-20 Darin Adler <darin@apple.com>
-
- - another similar Windows build fix
-
- * VM/CTI.cpp: Changed return type to JSObject* instead of JSValuePtr.
-
-2008-10-20 Darin Adler <darin@apple.com>
-
- - try to fix Windows build
-
- * VM/CTI.cpp: Use JSValue* instead of JSValuePtr for ctiTrampoline.
- * VM/CTI.h: Ditto.
-
-2008-10-19 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - finish https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_profiler): Use asFunction.
- (JSC::Machine::cti_vm_lazyLinkCall): Ditto.
- (JSC::Machine::cti_op_construct_JSConstructFast): Use asObject.
-
- * kjs/JSCell.h: Re-sort friend classes. Eliminate inheritance from
- JSValue. Changed cast in asCell from static_cast to reinterpret_cast.
- Removed JSValue::getNumber(double&) and one of JSValue::getObject
- overloads.
-
- * kjs/JSValue.h: Made the private constructor and destructor both
- non-virtual and also remove the definitions. This class can never
- be instantiated or derived.
-
-2008-10-19 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Change JSValuePtr from a typedef into a class. This allows us to support
- conversion from JSCell* to JSValuePtr even if JSCell isn't derived from
- JSValue.
-
- * JavaScriptCore.exp: Updated symbols that involve JSValuePtr, since
- it's now a distinct type.
-
- * API/APICast.h:
- (toRef): Extract the JSValuePtr payload explicitly since we can't just
- cast any more.
- * VM/CTI.cpp:
- (JSC::CTI::asInteger): Ditto.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::addConstant): Get at the payload directly.
- (JSC::CodeGenerator::emitLoad): Added an overload of JSCell* because
- otherwise classes derived from JSValue end up calling the bool
- overload instead of JSValuePtr.
- * VM/CodeGenerator.h: Ditto. Also update traits to use JSValue*
- and the payload functions.
-
- * VM/Register.h: Added a JSCell* overload and use of payload functions.
-
- * kjs/JSCell.h:
- (JSC::asCell): Use payload function.
- (JSC::JSValue::asCell): Use JSValue* instead of JSValuePtr.
- (JSC::JSValuePtr::JSValuePtr): Added. Constructor that takes JSCell*
- and creates a JSValuePtr.
-
- * kjs/JSImmediate.h: Added JSValuePtr class. Also updated makeValue
- and makeInt to work with JSValue* and the payload function.
-
- * kjs/JSValue.h: Added == and != operators for JSValuePtr. Put them
- here because eventually all the JSValue functions should go here
- except what's needed by JSImmediate. Also fix asValue to use
- JSValue* instead of JSValuePtr.
-
- * kjs/PropertySlot.h: Change constructor to take JSValuePtr.
+ Timezone calculation incorrect in Venezuela.
- * kjs/protect.h: Update gcProtect functions to work with JSCell*
- as well as JSValuePtr. Also updated the ProtectedPtr<JSValuePtr>
- specialization to work more directly. Also changed all the call
- sites to use gcProtectNullTolerant.
+ https://bugs.webkit.org/show_bug.cgi?id=26531
+ <rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3
-2008-10-19 Darin Adler <darin@apple.com>
+ The problem is that we're calculating the timezone relative to 01/01/2000,
+ but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
+ According to the spec, section 15.9.1.9 states "the time since the beginning
+ of the year", presumably meaning the *current* year. Change the calculation
+ to be based on whatever the current year is, rather than a canned date.
- Reviewed by Oliver Hunt.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Remove most uses of JSValue, which will be removed in a future patch.
-
- * VM/Machine.cpp:
- (JSC::fastToUInt32): Call toUInt32SlowCase function; no longer a member
- of JSValue.
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::toInt32): Ditto.
- (JSC::JSNumberCell::toUInt32): Ditto.
-
- * kjs/JSValue.cpp:
- (JSC::toInt32SlowCase): Made a non-member function.
- (JSC::JSValue::toInt32SlowCase): Changed to call non-member function.
- (JSC::toUInt32SlowCase): More of the same.
- (JSC::JSValue::toUInt32SlowCase): Ditto.
-
- * kjs/JSValue.h: Moved static member function so they are no longer
- member functions at all.
-
- * VM/CTI.h: Removed forward declaration of JSValue.
- * VM/ExceptionHelpers.h: Ditto.
- * kjs/CallData.h: Ditto.
- * kjs/ConstructData.h: Ditto.
- * kjs/JSGlobalObjectFunctions.h: Ditto.
- * kjs/PropertyMap.h: Ditto.
- * kjs/StructureID.h: Ditto.
- * kjs/collector.h: Ditto.
- * kjs/completion.h: Ditto.
-
- * kjs/grammar.y:
- (JSC::makeBitwiseNotNode): Call new non-member toInt32 function.
- (JSC::makeLeftShiftNode): More of the same.
- (JSC::makeRightShiftNode): Ditto.
-
- * kjs/protect.h: Added a specialization for ProtectedPtr<JSValuePtr>
- so this can be used with JSValuePtr.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Tweak a little more to get closer to where we can make JSValuePtr a class.
-
- * API/APICast.h:
- (toJS): Change back to JSValue* here, since we're converting the
- pointer type.
- * VM/CTI.cpp:
- (JSC::CTI::unlinkCall): Call asPointer.
- * VM/CTI.h: Cast to JSValue* here, since it's a pointer cast.
- * kjs/DebuggerCallFrame.h:
- (JSC::DebuggerCallFrame::DebuggerCallFrame): Call noValue.
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Call noValue.
- * kjs/JSImmediate.cpp:
- (JSC::JSImmediate::toObject): Remove unneeded const_cast.
- * kjs/JSWrapperObject.h:
- (JSC::JSWrapperObject::JSWrapperObject): Call noValue.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - fix non-all-in-one build
-
- * kjs/completion.h:
- (JSC::Completion::Completion): Add include of JSValue.h.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - fix assertions I introduced with my casting changes
-
- These were showing up as failures in the JavaScriptCore tests.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_instanceof): Remove the bogus asCell casting that
- was at the top of the function, and instead cast at the point of use.
- (JSC::Machine::cti_op_construct_NotJSConstruct): Moved the cast to
- object after checking the construct type.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - fix non-all-in-one build
-
- * kjs/JSGlobalObjectFunctions.h: Add include of JSImmedate.h (for now).
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - fix build
-
- * kjs/interpreter.h: Include JSValue.h instead of JSImmediate.h.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- * kjs/interpreter.h: Fix include of JSImmediate.h.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - fix non-all-in-one build
-
- * kjs/interpreter.h: Add include of JSImmediate.h.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - fix non-all-in-one build
-
- * kjs/ConstructData.h: Add include of JSImmedate.h (for now).
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - try to fix Windows build
-
- * VM/Machine.cpp:
- (JSC::Machine::Machine): Use JSCell* type since MSVC seems to only allow
- calling ~JSCell directly if it's a JSCell*.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - next step on https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
- changing JSValuePtr to be a class, and then eventually renaming it
- to JSValue once that's done.
-
- * JavaScriptCore.exp: Update entry points, since some now take JSValue*
- instead of const JSValue*.
-
- * API/APICast.h:
- * API/JSCallbackConstructor.h:
- * API/JSCallbackFunction.cpp:
- * API/JSCallbackFunction.h:
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- * API/JSValueRef.cpp:
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- * VM/CodeGenerator.h:
- * VM/ExceptionHelpers.cpp:
- * VM/ExceptionHelpers.h:
- * VM/JSPropertyNameIterator.cpp:
- * VM/JSPropertyNameIterator.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * VM/Register.h:
- * kjs/ArgList.cpp:
- * kjs/ArgList.h:
- * kjs/Arguments.cpp:
- * kjs/Arguments.h:
- * kjs/ArrayConstructor.cpp:
- * kjs/ArrayPrototype.cpp:
- * kjs/BooleanConstructor.cpp:
- * kjs/BooleanConstructor.h:
- * kjs/BooleanObject.h:
- * kjs/BooleanPrototype.cpp:
- * kjs/CallData.cpp:
- * kjs/CallData.h:
- * kjs/ConstructData.cpp:
- * kjs/ConstructData.h:
- * kjs/DateConstructor.cpp:
- * kjs/DateInstance.h:
- * kjs/DatePrototype.cpp:
- * kjs/DebuggerCallFrame.cpp:
- * kjs/DebuggerCallFrame.h:
- * kjs/ErrorConstructor.cpp:
- * kjs/ErrorPrototype.cpp:
- * kjs/ExecState.cpp:
- * kjs/ExecState.h:
- * kjs/FunctionConstructor.cpp:
- * kjs/FunctionPrototype.cpp:
- * kjs/GetterSetter.cpp:
- * kjs/GetterSetter.h:
- * kjs/InternalFunction.h:
- * kjs/JSActivation.cpp:
- * kjs/JSActivation.h:
- * kjs/JSArray.cpp:
- * kjs/JSArray.h:
- * kjs/JSCell.cpp:
- * kjs/JSCell.h:
- * kjs/JSFunction.cpp:
- * kjs/JSFunction.h:
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.cpp:
- * kjs/JSGlobalObject.h:
- * kjs/JSGlobalObjectFunctions.cpp:
- * kjs/JSGlobalObjectFunctions.h:
- * kjs/JSImmediate.cpp:
- * kjs/JSImmediate.h:
- * kjs/JSNotAnObject.cpp:
- * kjs/JSNotAnObject.h:
- * kjs/JSNumberCell.cpp:
- * kjs/JSNumberCell.h:
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- * kjs/JSStaticScopeObject.cpp:
- * kjs/JSStaticScopeObject.h:
- * kjs/JSString.cpp:
- * kjs/JSString.h:
- * kjs/JSValue.h:
- * kjs/JSVariableObject.h:
- * kjs/JSWrapperObject.h:
- * kjs/MathObject.cpp:
- * kjs/NativeErrorConstructor.cpp:
- * kjs/NumberConstructor.cpp:
- * kjs/NumberConstructor.h:
- * kjs/NumberObject.cpp:
- * kjs/NumberObject.h:
- * kjs/NumberPrototype.cpp:
- * kjs/ObjectConstructor.cpp:
- * kjs/ObjectPrototype.cpp:
- * kjs/ObjectPrototype.h:
- * kjs/PropertyMap.h:
- * kjs/PropertySlot.cpp:
- * kjs/PropertySlot.h:
- * kjs/RegExpConstructor.cpp:
- * kjs/RegExpConstructor.h:
- * kjs/RegExpMatchesArray.h:
- * kjs/RegExpObject.cpp:
- * kjs/RegExpObject.h:
- * kjs/RegExpPrototype.cpp:
- * kjs/Shell.cpp:
- * kjs/StringConstructor.cpp:
- * kjs/StringObject.cpp:
- * kjs/StringObject.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- * kjs/StringPrototype.cpp:
- * kjs/StructureID.cpp:
- * kjs/StructureID.h:
- * kjs/collector.cpp:
- * kjs/collector.h:
- * kjs/completion.h:
- * kjs/grammar.y:
- * kjs/interpreter.cpp:
- * kjs/interpreter.h:
- * kjs/lookup.cpp:
- * kjs/lookup.h:
- * kjs/nodes.h:
- * kjs/operations.cpp:
- * kjs/operations.h:
- * kjs/protect.h:
- * profiler/ProfileGenerator.cpp:
- Replace JSValue* with JSValuePtr.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_eval): Removed stray parentheses from my
- last check-in.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - first step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Remove casts from JSValue* to derived classes, replacing them with
- calls to inline casting functions. These functions are also a bit
- better than aidrect cast because they also do a runtime assertion.
-
- Removed use of 0 as for JSValue*, changing call sites to use a
- noValue() function instead.
-
- Move things needed by classes derived from JSValue out of the class,
- since the classes won't be deriving from JSValue any more soon.
-
- I did most of these changes by changing JSValue to not be JSValue* any
- more, then fixing a lot of the compilation problems, then rolling out
- the JSValue change.
-
- 1.011x as fast on SunSpider (presumably due to some of the Machine.cpp changes)
-
- * API/APICast.h: Removed unneeded forward declarations.
-
- * API/JSCallbackObject.h: Added an asCallbackObject function for casting.
- * API/JSCallbackObjectFunctions.h:
- (JSC::JSCallbackObject::asCallbackObject): Added.
- (JSC::JSCallbackObject::getOwnPropertySlot): Use asObject.
- (JSC::JSCallbackObject::call): Use noValue.
- (JSC::JSCallbackObject::staticValueGetter): Use asCallbackObject.
- (JSC::JSCallbackObject::staticFunctionGetter): Ditto.
- (JSC::JSCallbackObject::callbackGetter): Ditto.
-
- * JavaScriptCore.exp: Updated.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Added RegExpMatchesArray.h.
-
- * VM/CTI.cpp:
- (JSC::CTI::asInteger): Added. For use casting a JSValue to an integer.
- (JSC::CTI::emitGetArg): Use asInteger.
- (JSC::CTI::emitGetPutArg): Ditto.
- (JSC::CTI::getConstantImmediateNumericArg): Ditto. Also use noValue.
- (JSC::CTI::emitInitRegister): Use asInteger.
- (JSC::CTI::getDeTaggedConstantImmediate): Ditto.
- (JSC::CTI::compileOpCallInitializeCallFrame): Ditto.
- (JSC::CTI::compileOpCall): Ditto.
- (JSC::CTI::compileOpStrictEq): Ditto.
- (JSC::CTI::privateCompileMainPass): Ditto.
- (JSC::CTI::privateCompileGetByIdProto): Ditto.
- (JSC::CTI::privateCompileGetByIdChain): Ditto.
- (JSC::CTI::privateCompilePutByIdTransition): Ditto.
- * VM/CTI.h: Rewrite the ARG-related macros to use C++ casts instead of
- C casts and get rid of some extra parentheses. Addd declaration of
- asInteger.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp): Use asString.
- (JSC::CodeGenerator::emitLoad): Use noValue.
- (JSC::CodeGenerator::findScopedProperty): Change globalObject argument
- to JSObject* instead of JSValue*.
- (JSC::CodeGenerator::emitResolve): Remove unneeded cast.
- (JSC::CodeGenerator::emitGetScopedVar): Use asCell.
- (JSC::CodeGenerator::emitPutScopedVar): Ditto.
- * VM/CodeGenerator.h: Changed out argument of findScopedProperty.
- Also change the JSValueMap to use PtrHash explicitly instead of
- getting it from DefaultHash.
-
- * VM/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::toPrimitive): Use noValue.
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::next): Ditto.
-
- * VM/Machine.cpp:
- (JSC::fastIsNumber): Moved isImmediate check here instead of
- checking for 0 inside Heap::isNumber. Use asCell and asNumberCell.
- (JSC::fastToInt32): Ditto.
- (JSC::fastToUInt32): Ditto.
- (JSC::jsLess): Use asString.
- (JSC::jsLessEq): Ditto.
- (JSC::jsAdd): Ditto.
- (JSC::jsTypeStringForValue): Use asObject.
- (JSC::jsIsObjectType): Ditto.
- (JSC::jsIsFunctionType): Ditto.
- (JSC::inlineResolveBase): Use noValue.
- (JSC::Machine::callEval): Use asString. Initialize result to
- undefined, not 0.
- (JSC::Machine::Machine): Remove unneeded casts to JSCell*.
- (JSC::Machine::throwException): Use asObject.
- (JSC::Machine::debug): Remove explicit calls to the DebuggerCallFrame
- constructor.
- (JSC::Machine::checkTimeout): Use noValue.
- (JSC::cachePrototypeChain): Use asObject.
- (JSC::Machine::tryCachePutByID): Use asCell.
- (JSC::Machine::tryCacheGetByID): Use aCell and asObject.
- (JSC::Machine::privateExecute): Use noValue, asCell, asObject, asString,
- asArray, asActivation, asFunction. Changed code that creates call frames
- for host functions to pass 0 for the function pointer -- the call frame
- needs a JSFunction* and a host function object is not one. This was
- caught by the assertions in the casting functions. Also remove some
- unneeded casts in cases where two values are compared.
- (JSC::Machine::retrieveLastCaller): Use noValue.
- (JSC::Machine::tryCTICachePutByID): Use asCell.
- (JSC::Machine::tryCTICacheGetByID): Use aCell and asObject.
- (JSC::setUpThrowTrampolineReturnAddress): Added this function to restore
- the PIC-branch-avoidance that was recently lost.
- (JSC::Machine::cti_op_add): Use asString.
- (JSC::Machine::cti_op_instanceof): Use asCell and asObject.
- (JSC::Machine::cti_op_call_JSFunction): Use asFunction.
- (JSC::Machine::cti_op_call_NotJSFunction): Changed code to pass 0 for
- the function pointer, since we don't have a JSFunction. Use asObject.
- (JSC::Machine::cti_op_tear_off_activation): Use asActivation.
- (JSC::Machine::cti_op_construct_JSConstruct): Use asFunction and asObject.
- (JSC::Machine::cti_op_construct_NotJSConstruct): use asObject.
- (JSC::Machine::cti_op_get_by_val): Use asArray and asString.
- (JSC::Machine::cti_op_resolve_func): Use asPointer; this helps prepare
- us for a situation where JSValue is not a pointer.
- (JSC::Machine::cti_op_put_by_val): Use asArray.
- (JSC::Machine::cti_op_put_by_val_array): Ditto.
- (JSC::Machine::cti_op_resolve_global): Use asGlobalObject.
- (JSC::Machine::cti_op_post_inc): Change VM_CHECK_EXCEPTION_2 to
- VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after
- that point. Also use asPointer.
- (JSC::Machine::cti_op_resolve_with_base): Use asPointer.
- (JSC::Machine::cti_op_post_dec): Change VM_CHECK_EXCEPTION_2 to
- VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after
- that point. Also use asPointer.
- (JSC::Machine::cti_op_call_eval): Use asObject, noValue, and change
- VM_CHECK_EXCEPTION_ARG to VM_THROW_EXCEPTION_AT_END.
- (JSC::Machine::cti_op_throw): Change return value to a JSValue*.
- (JSC::Machine::cti_op_in): Use asObject.
- (JSC::Machine::cti_op_switch_char): Use asString.
- (JSC::Machine::cti_op_switch_string): Ditto.
- (JSC::Machine::cti_op_put_getter): Use asObject.
- (JSC::Machine::cti_op_put_setter): Ditto.
- (JSC::Machine::cti_vm_throw): Change return value to a JSValue*.
- Use noValue.
- * VM/Machine.h: Change return values of both cti_op_throw and
- cti_vm_throw to JSValue*.
-
- * VM/Register.h: Remove nullJSValue, which is the same thing
- as noValue(). Also removed unneeded definition of JSValue.
-
- * kjs/ArgList.h: Removed unneeded definition of JSValue.
-
- * kjs/Arguments.h:
- (JSC::asArguments): Added.
-
- * kjs/ArrayPrototype.cpp:
- (JSC::getProperty): Use noValue.
- (JSC::arrayProtoFuncToString): Use asArray.
- (JSC::arrayProtoFuncToLocaleString): Ditto.
- (JSC::arrayProtoFuncConcat): Ditto.
- (JSC::arrayProtoFuncPop): Ditto. Also removed unneeded initialization
- of the result, which is set in both sides of the branch.
- (JSC::arrayProtoFuncPush): Ditto.
- (JSC::arrayProtoFuncShift): Removed unneeded initialization
- of the result, which is set in both sides of the branch.
- (JSC::arrayProtoFuncSort): Use asArray.
-
- * kjs/BooleanObject.h:
- (JSC::asBooleanObject): Added.
-
- * kjs/BooleanPrototype.cpp:
- (JSC::booleanProtoFuncToString): Use asBooleanObject.
- (JSC::booleanProtoFuncValueOf): Ditto.
-
- * kjs/CallData.cpp:
- (JSC::call): Use asObject and asFunction.
- * kjs/ConstructData.cpp:
- (JSC::construct): Ditto.
-
- * kjs/DateConstructor.cpp:
- (JSC::constructDate): Use asDateInstance.
-
- * kjs/DateInstance.h:
- (JSC::asDateInstance): Added.
-
- * kjs/DatePrototype.cpp:
- (JSC::dateProtoFuncToString): Use asDateInstance.
- (JSC::dateProtoFuncToUTCString): Ditto.
- (JSC::dateProtoFuncToDateString): Ditto.
- (JSC::dateProtoFuncToTimeString): Ditto.
- (JSC::dateProtoFuncToLocaleString): Ditto.
- (JSC::dateProtoFuncToLocaleDateString): Ditto.
- (JSC::dateProtoFuncToLocaleTimeString): Ditto.
- (JSC::dateProtoFuncValueOf): Ditto.
- (JSC::dateProtoFuncGetTime): Ditto.
- (JSC::dateProtoFuncGetFullYear): Ditto.
- (JSC::dateProtoFuncGetUTCFullYear): Ditto.
- (JSC::dateProtoFuncToGMTString): Ditto.
- (JSC::dateProtoFuncGetMonth): Ditto.
- (JSC::dateProtoFuncGetUTCMonth): Ditto.
- (JSC::dateProtoFuncGetDate): Ditto.
- (JSC::dateProtoFuncGetUTCDate): Ditto.
- (JSC::dateProtoFuncGetDay): Ditto.
- (JSC::dateProtoFuncGetUTCDay): Ditto.
- (JSC::dateProtoFuncGetHours): Ditto.
- (JSC::dateProtoFuncGetUTCHours): Ditto.
- (JSC::dateProtoFuncGetMinutes): Ditto.
- (JSC::dateProtoFuncGetUTCMinutes): Ditto.
- (JSC::dateProtoFuncGetSeconds): Ditto.
- (JSC::dateProtoFuncGetUTCSeconds): Ditto.
- (JSC::dateProtoFuncGetMilliSeconds): Ditto.
- (JSC::dateProtoFuncGetUTCMilliseconds): Ditto.
- (JSC::dateProtoFuncGetTimezoneOffset): Ditto.
- (JSC::dateProtoFuncSetTime): Ditto.
- (JSC::setNewValueFromTimeArgs): Ditto.
- (JSC::setNewValueFromDateArgs): Ditto.
- (JSC::dateProtoFuncSetYear): Ditto.
- (JSC::dateProtoFuncGetYear): Ditto.
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::thisObject): Use asObject.
- (JSC::DebuggerCallFrame::evaluate): Use noValue.
- * kjs/DebuggerCallFrame.h: Added a constructor that
- takes only a callFrame.
-
- * kjs/ExecState.h:
- (JSC::ExecState::clearException): Use noValue.
-
- * kjs/FunctionPrototype.cpp:
- (JSC::functionProtoFuncToString): Use asFunction.
- (JSC::functionProtoFuncApply): Use asArguments and asArray.
-
- * kjs/GetterSetter.cpp:
- (JSC::GetterSetter::getPrimitiveNumber): Use noValue.
-
- * kjs/GetterSetter.h:
- (JSC::asGetterSetter): Added.
-
- * kjs/InternalFunction.cpp:
- (JSC::InternalFunction::name): Use asString.
-
- * kjs/InternalFunction.h:
- (JSC::asInternalFunction): Added.
-
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::argumentsGetter): Use asActivation.
-
- * kjs/JSActivation.h:
- (JSC::asActivation): Added.
-
- * kjs/JSArray.cpp:
- (JSC::JSArray::putSlowCase): Use noValue.
- (JSC::JSArray::deleteProperty): Ditto.
- (JSC::JSArray::increaseVectorLength): Ditto.
- (JSC::JSArray::setLength): Ditto.
- (JSC::JSArray::pop): Ditto.
- (JSC::JSArray::sort): Ditto.
- (JSC::JSArray::compactForSorting): Ditto.
- * kjs/JSArray.h:
- (JSC::asArray): Added.
-
- * kjs/JSCell.cpp:
- (JSC::JSCell::getJSNumber): Use noValue.
-
- * kjs/JSCell.h:
- (JSC::asCell): Added.
- (JSC::JSValue::asCell): Changed to not preserve const.
- Given the wide use of JSValue* and JSCell*, it's not
- really useful to use const.
- (JSC::JSValue::isNumber): Use asValue.
- (JSC::JSValue::isString): Ditto.
- (JSC::JSValue::isGetterSetter): Ditto.
- (JSC::JSValue::isObject): Ditto.
- (JSC::JSValue::getNumber): Ditto.
- (JSC::JSValue::getString): Ditto.
- (JSC::JSValue::getObject): Ditto.
- (JSC::JSValue::getCallData): Ditto.
- (JSC::JSValue::getConstructData): Ditto.
- (JSC::JSValue::getUInt32): Ditto.
- (JSC::JSValue::getTruncatedInt32): Ditto.
- (JSC::JSValue::getTruncatedUInt32): Ditto.
- (JSC::JSValue::mark): Ditto.
- (JSC::JSValue::marked): Ditto.
- (JSC::JSValue::toPrimitive): Ditto.
- (JSC::JSValue::getPrimitiveNumber): Ditto.
- (JSC::JSValue::toBoolean): Ditto.
- (JSC::JSValue::toNumber): Ditto.
- (JSC::JSValue::toString): Ditto.
- (JSC::JSValue::toObject): Ditto.
- (JSC::JSValue::toThisObject): Ditto.
- (JSC::JSValue::needsThisConversion): Ditto.
- (JSC::JSValue::toThisString): Ditto.
- (JSC::JSValue::getJSNumber): Ditto.
-
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::argumentsGetter): Use asFunction.
- (JSC::JSFunction::callerGetter): Ditto.
- (JSC::JSFunction::lengthGetter): Ditto.
- (JSC::JSFunction::construct): Use asObject.
-
- * kjs/JSFunction.h:
- (JSC::asFunction): Added.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::lastInPrototypeChain): Use asObject.
-
- * kjs/JSGlobalObject.h:
- (JSC::asGlobalObject): Added.
- (JSC::ScopeChainNode::globalObject): Use asGlobalObject.
-
- * kjs/JSImmediate.h: Added noValue, asPointer, and makeValue
- functions. Use rawValue, makeValue, and noValue consistently
- instead of doing reinterpret_cast in various functions.
-
- * kjs/JSNumberCell.h:
- (JSC::asNumberCell): Added.
- (JSC::JSValue::uncheckedGetNumber): Use asValue and asNumberCell.
- (JSC::JSValue::toJSNumber): Use asValue.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::put): Use asObject and asGetterSetter.
- (JSC::callDefaultValueFunction): Use noValue.
- (JSC::JSObject::defineGetter): Use asGetterSetter.
- (JSC::JSObject::defineSetter): Ditto.
- (JSC::JSObject::lookupGetter): Ditto. Also use asObject.
- (JSC::JSObject::lookupSetter): Ditto.
- (JSC::JSObject::hasInstance): Use asObject.
- (JSC::JSObject::fillGetterPropertySlot): Use asGetterSetter.
-
- * kjs/JSObject.h:
- (JSC::JSObject::getDirect): Use noValue.
- (JSC::asObject): Added.
- (JSC::JSValue::isObject): Use asValue.
- (JSC::JSObject::get): Removed unneeded const_cast.
- (JSC::JSObject::getPropertySlot): Use asObject.
- (JSC::JSValue::get): Removed unneeded const_cast.
- Use asValue, asCell, and asObject.
- (JSC::JSValue::put): Ditto.
- (JSC::JSObject::allocatePropertyStorageInline): Fixed spelling
- of "oldPropertStorage".
-
- * kjs/JSString.cpp:
- (JSC::JSString::getOwnPropertySlot): Use asObject.
-
- * kjs/JSString.h:
- (JSC::asString): Added.
- (JSC::JSValue::toThisJSString): Use asValue.
-
- * kjs/JSValue.h: Make PreferredPrimitiveType a top level enum
- instead of a member of JSValue. Added an asValue function that
- returns this. Removed overload of asCell for const. Use asValue
- instead of getting right at this.
-
- * kjs/ObjectPrototype.cpp:
- (JSC::objectProtoFuncIsPrototypeOf): Use asObject.
- (JSC::objectProtoFuncDefineGetter): Ditto.
- (JSC::objectProtoFuncDefineSetter): Ditto.
-
- * kjs/PropertySlot.h:
- (JSC::PropertySlot::PropertySlot): Take a const JSValue* so the
- callers don't have to worry about const.
- (JSC::PropertySlot::clearBase): Use noValue.
- (JSC::PropertySlot::clearValue): Ditto.
-
- * kjs/RegExpConstructor.cpp:
- (JSC::regExpConstructorDollar1): Use asRegExpConstructor.
- (JSC::regExpConstructorDollar2): Ditto.
- (JSC::regExpConstructorDollar3): Ditto.
- (JSC::regExpConstructorDollar4): Ditto.
- (JSC::regExpConstructorDollar5): Ditto.
- (JSC::regExpConstructorDollar6): Ditto.
- (JSC::regExpConstructorDollar7): Ditto.
- (JSC::regExpConstructorDollar8): Ditto.
- (JSC::regExpConstructorDollar9): Ditto.
- (JSC::regExpConstructorInput): Ditto.
- (JSC::regExpConstructorMultiline): Ditto.
- (JSC::regExpConstructorLastMatch): Ditto.
- (JSC::regExpConstructorLastParen): Ditto.
- (JSC::regExpConstructorLeftContext): Ditto.
- (JSC::regExpConstructorRightContext): Ditto.
- (JSC::setRegExpConstructorInput): Ditto.
- (JSC::setRegExpConstructorMultiline): Ditto.
- (JSC::constructRegExp): Use asObject.
-
- * kjs/RegExpConstructor.h:
- (JSC::asRegExpConstructor): Added.
-
- * kjs/RegExpObject.cpp:
- (JSC::regExpObjectGlobal): Use asRegExpObject.
- (JSC::regExpObjectIgnoreCase): Ditto.
- (JSC::regExpObjectMultiline): Ditto.
- (JSC::regExpObjectSource): Ditto.
- (JSC::regExpObjectLastIndex): Ditto.
- (JSC::setRegExpObjectLastIndex): Ditto.
- (JSC::callRegExpObject): Ditto.
-
- * kjs/RegExpObject.h:
- (JSC::asRegExpObject): Added.
-
- * kjs/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncTest): Use asRegExpObject.
- (JSC::regExpProtoFuncExec): Ditto.
- (JSC::regExpProtoFuncCompile): Ditto.
- (JSC::regExpProtoFuncToString): Ditto.
-
- * kjs/StringObject.h:
- (JSC::StringObject::internalValue): Use asString.
- (JSC::asStringObject): Added.
-
- * kjs/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace): Use asRegExpObject.
- (JSC::stringProtoFuncToString): Ue asStringObject.
- (JSC::stringProtoFuncMatch): Use asRegExpObject.
- (JSC::stringProtoFuncSearch): Ditto.
- (JSC::stringProtoFuncSplit): Ditto.
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames): Use asObject.
- (JSC::StructureID::createCachedPrototypeChain): Ditto.
- (JSC::StructureIDChain::StructureIDChain): Use asCell and asObject.
-
- * kjs/collector.h:
- (JSC::Heap::isNumber): Removed null handling. This can only be called
- on valid cells.
- (JSC::Heap::cellBlock): Removed overload for const and non-const.
- Whether the JSCell* is const or not really should have no effect on
- whether you can modify the collector block it's in.
-
- * kjs/interpreter.cpp:
- (JSC::Interpreter::evaluate): Use noValue and noObject.
-
- * kjs/nodes.cpp:
- (JSC::FunctionCallResolveNode::emitCode): Use JSObject for the global
- object rather than JSValue.
- (JSC::PostfixResolveNode::emitCode): Ditto.
- (JSC::PrefixResolveNode::emitCode): Ditto.
- (JSC::ReadModifyResolveNode::emitCode): Ditto.
- (JSC::AssignResolveNode::emitCode): Ditto.
-
- * kjs/operations.h:
- (JSC::equalSlowCaseInline): Use asString, asCell, asNumberCell,
- (JSC::strictEqualSlowCaseInline): Ditto.
-
-2008-10-18 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21702: Special op_create_activation for the case where there are no named parameters
- <https://bugs.webkit.org/show_bug.cgi?id=21702>
-
- This is a 2.5% speedup on the V8 Raytrace benchmark and a 1.1% speedup
- on the V8 Earley-Boyer benchmark.
+ No performance impact.
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_create_arguments_no_params):
- * VM/Machine.h:
- * kjs/Arguments.h:
- (JSC::Arguments::):
- (JSC::Arguments::Arguments):
+ * wtf/DateMath.cpp:
+ (WTF::calculateUTCOffset):
-2008-10-17 Maciej Stachowiak <mjs@apple.com>
+2009-06-18 Gavin Barraclough <barraclough@apple.com>
- Reviewed by Cameron Zwarich.
-
- - in debug builds, alter the stack to avoid blowing out MallocStackLogging
-
- (In essence, while executing a CTI function we alter the return
- address to jscGeneratedNativeCode so that a single consistent
- function is on the stack instead of many random functions without
- symbols.)
-
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::doSetReturnAddress):
- (JSC::):
- (JSC::StackHack::StackHack):
- (JSC::StackHack::~StackHack):
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_end):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_timeout_check):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_loop_if_less):
- (JSC::Machine::cti_op_loop_if_lesseq):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_second):
- (JSC::Machine::cti_op_put_by_id_generic):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_call_profiler):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_lazyLinkCall):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstructFast):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_put_by_val):
- (JSC::Machine::cti_op_put_by_val_array):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_jless):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_post_dec):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_get_pnames):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_push_scope):
- (JSC::Machine::cti_op_pop_scope):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_jmp_scopes):
- (JSC::Machine::cti_op_put_by_index):
- (JSC::Machine::cti_op_switch_imm):
- (JSC::Machine::cti_op_switch_char):
- (JSC::Machine::cti_op_switch_string):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_put_getter):
- (JSC::Machine::cti_op_put_setter):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_op_debug):
- (JSC::Machine::cti_vm_throw):
-
-2008-10-17 Gavin Barraclough <barraclough@apple.com>
-
- Optimize op_call by allowing call sites to be directly linked to callees.
-
- For the hot path of op_call, CTI now generates a check (initially for an impossible
- value), and the first time the call is executed we attempt to link the call directly
- to the callee. We can currently only do so if the arity of the caller and callee
- match. The (optimized) setup for the call on the hot path is linked directly to
- the ctiCode for the callee, without indirection.
-
- Two forms of the slow case of the call are generated, the first will be executed the
- first time the call is reached. As well as this path attempting to link the call to
- a callee, it also relinks the slow case to a second slow case, which will not continue
- to attempt relinking the call. (This policy could be changed in future, but for not
- this is intended to prevent thrashing).
+ Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).
- If a callee that the caller has been linked to is garbage collected, then the link
- in the caller's JIt code will be reset back to a value that cannot match - to prevent
- any false positive matches.
+ (Reintroducing patch added in r44492, and reverted in r44796.)
- ~20% progression on deltablue & richards, >12% overall reduction in v8-tests
- runtime, one or two percent progression on sunspider.
-
- Reviewed by Oliver Hunt.
+ Change the implementation of op_throw so the stub function always modifies its
+ return address - if it doesn't find a 'catch' it will switch to a trampoline
+ to force a return from JIT execution. This saves memory, by avoiding the need
+ for a unique return for every op_throw.
- * VM/CTI.cpp:
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_throw):
+ JITStubs::cti_op_throw now always changes its return address,
+ remove return code generated after the stub call (this is now
+ handled by ctiOpThrowNotCaught).
+ * jit/JITStubs.cpp:
(JSC::):
- (JSC::CTI::emitNakedCall):
- (JSC::unreachable):
- (JSC::CTI::compileOpCallInitializeCallFrame):
- (JSC::CTI::compileOpCallSetupArgs):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::unlinkCall):
- (JSC::CTI::linkCall):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::~CodeBlock):
- (JSC::CodeBlock::unlinkCallers):
- (JSC::CodeBlock::derefStructureIDs):
- * VM/CodeBlock.h:
- (JSC::StructureStubInfo::StructureStubInfo):
- (JSC::CallLinkInfo::CallLinkInfo):
- (JSC::CodeBlock::addCaller):
- (JSC::CodeBlock::removeCaller):
- (JSC::CodeBlock::getStubInfo):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitConstruct):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_profiler):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_lazyLinkCall):
- (JSC::Machine::cti_op_construct_JSConstructFast):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- * VM/Machine.h:
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::~JSFunction):
- * kjs/JSFunction.h:
- * kjs/nodes.h:
- (JSC::FunctionBodyNode::):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::getDifferenceBetweenLabels):
-
-2008-10-17 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Geoff Garen.
-
- - remove ASSERT that makes the leaks buildbot cry
-
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::JSFunction):
-
-2008-10-17 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich
-
- - don't bother to do arguments tearoff when it will have no effect
-
- ~1% on v8 raytrace
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitReturn):
-
-2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Sam Weinig. Landed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=21603
- [GTK] Minor fixes to GOwnPtr
-
- * wtf/GOwnPtr.cpp:
- (WTF::GError):
- (WTF::GList):
- (WTF::GCond):
- (WTF::GMutex):
- (WTF::GPatternSpec):
- (WTF::GDir):
- * wtf/GOwnPtr.h:
- (WTF::freeOwnedGPtr):
- (WTF::GOwnPtr::~GOwnPtr):
- (WTF::GOwnPtr::outPtr):
- (WTF::GOwnPtr::set):
- (WTF::GOwnPtr::clear):
- * wtf/Threading.h:
-
-2008-10-17 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - speed up transitions that resize the property storage a fair bit
-
- ~3% speedup on v8 RayTrace benchmark, ~1% on DeltaBlue
-
- * VM/CTI.cpp:
- (JSC::resizePropertyStorage): renamed from transitionObject, and reduced to just resize
- the object's property storage with one inline call.
- (JSC::CTI::privateCompilePutByIdTransition): Use a separate function for property storage
- resize, but still do all the rest of the work in assembly in that case, and pass the known
- compile-time constants of old and new size rather than structureIDs, saving a bunch of
- redundant memory access.
- * kjs/JSObject.cpp:
- (JSC::JSObject::allocatePropertyStorage): Just call the inline version.
- * kjs/JSObject.h:
- (JSC::JSObject::allocatePropertyStorageInline): Inline version of allocatePropertyStorage
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::pushl_i32): Add code to assmeble push of a constant; code originally by Cameron Zwarich.
-
-2008-10-17 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Remove some C style casts.
-
- * masm/X86Assembler.h:
- (JSC::JITCodeBuffer::putIntUnchecked):
- (JSC::X86Assembler::link):
- (JSC::X86Assembler::linkAbsoluteAddress):
- (JSC::X86Assembler::getRelocatedAddress):
-
-2008-10-17 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Maciej Stachowiak.
-
- Remove some C style casts.
-
- * VM/CTI.cpp:
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- * VM/Machine.cpp:
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::tryCTICacheGetByID):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_fail):
-
-2008-10-17 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - Avoid restoring the caller's 'r' value in op_ret
- https://bugs.webkit.org/show_bug.cgi?id=21319
-
- This patch stops writing the call frame at call and return points;
- instead it does so immediately before any CTI call.
-
- 0.5% speedup or so on the v8 benchmark
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCTICall):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/CTI.h:
-
-2008-10-17 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Make WREC require CTI because it won't actually compile otherwise.
-
- * wtf/Platform.h:
-
-2008-10-16 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Geoff Garen.
-
- - fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
- - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
-
- This time there is no performance regression; we can avoid having
- to use the fastcall calling convention for CTI functions by using
- varargs to prevent the compiler from moving things around on the
- stack.
-
- * Configurations/DebugRelease.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- * VM/Machine.h:
- * wtf/Platform.h:
+ Add ctiOpThrowNotCaught definitions.
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ Change cti_op_throw to always change its return address.
+ * jit/JITStubs.h:
+ Add ctiOpThrowNotCaught declaration.
-2008-10-16 Maciej Stachowiak <mjs@apple.com>
+2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
- - fix for REGRESSION: r37631 causing crashes on buildbot
- https://bugs.webkit.org/show_bug.cgi?id=21682
-
- * kjs/collector.cpp:
- (JSC::Heap::collect): Avoid crashing when a GC occurs while no global objects are live.
-
-2008-10-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
- Don't create intermediate StructureIDs for builtin objects
-
- First step in reduce number of StructureIDs created when initializing the
- JSGlobalObject.
-
- - In order to avoid creating the intermediate StructureIDs use the new putDirectWithoutTransition
- and putDirectFunctionWithoutTransition to add properties to JSObjects without transitioning
- the StructureID. This patch just implements this strategy for ObjectPrototype but alone
- reduces the number of StructureIDs create for about:blank by 10, from 142 to 132.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- * kjs/JSObject.cpp:
- (JSC::JSObject::putDirectFunctionWithoutTransition):
- * kjs/JSObject.h:
- (JSC::JSObject::putDirectWithoutTransition):
- * kjs/ObjectPrototype.cpp:
- (JSC::ObjectPrototype::ObjectPrototype):
- * kjs/ObjectPrototype.h:
- * kjs/StructureID.cpp:
- (JSC::StructureID::addPropertyWithoutTransition):
- * kjs/StructureID.h:
-
-2008-10-16 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix for: REGRESSION: over 100 StructureIDs leak loading about:blank (result of fix for bug 21633)
-
- Apparent slight progression (< 0.5%) on v8 benchmarks and SunSpider.
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::~StructureID): Don't deref this object's parent's pointer to
- itself from the destructor; that doesn't even make sense.
- (JSC::StructureID::addPropertyTransition): Don't refer the single transition;
- the rule is that parent StructureIDs are ref'd but child ones are not. Refing
- the child creates a cycle.
-
-2008-10-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21609
- Make MessagePorts protect their peers across heaps
+ <rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
- * JavaScriptCore.exp:
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::markCrossHeapDependentObjects):
- * kjs/JSGlobalObject.h:
- * kjs/collector.cpp:
- (JSC::Heap::collect):
- Before GC sweep phase, a function supplied by global object is now called for all global
- objects in the heap, making it possible to implement cross-heap dependencies.
-
-2008-10-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21610
- run-webkit-threads --threaded crashes in StructureID destructor
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
- Protect access to a static (debug-only) HashSet with a lock.
-
-2008-10-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Goeffrey Garen.
-
- Add function to dump statistics for StructureIDs.
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::dumpStatistics):
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
- * kjs/StructureID.h:
-
-2008-10-15 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21633: Avoid using a HashMap when there is only a single transition
- <https://bugs.webkit.org/show_bug.cgi?id=21633>
-
- This is a 0.8% speedup on SunSpider and between a 0.5% and 1.0% speedup
- on the V8 benchmark suite, depending on which harness we use. It will
- also slightly reduce the memory footprint of a StructureID.
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
- (JSC::StructureID::addPropertyTransition):
- * kjs/StructureID.h:
- (JSC::StructureID::):
-
-2008-10-15 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
-
- Reviewed by Geoffrey Garen.
-
- 1.40% speedup on SunSpider, 1.44% speedup on V8. (Linux)
-
- No change on Mac.
-
- * VM/Machine.cpp:
- (JSC::fastIsNumber): ALWAYS_INLINE modifier added.
-
-2008-10-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
- Start the debugger without reloading the inspected page
-
- * JavaScriptCore.exp: New symbols.
- * JavaScriptCore.xcodeproj/project.pbxproj: New files.
-
- * VM/CodeBlock.h:
- (JSC::EvalCodeCache::get): Updated for tweak to parsing API.
-
- * kjs/CollectorHeapIterator.h: Added. An iterator for the object heap,
- which we use to find all the live functions and recompile them.
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate): Updated for tweak to parsing API.
-
- * kjs/FunctionConstructor.cpp:
- (JSC::constructFunction): Updated for tweak to parsing API.
-
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::JSFunction): Try to validate our SourceCode in debug
- builds by ASSERTing that it's syntactically valid. This doesn't catch
- all SourceCode bugs, but it catches a lot of them.
-
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval): Updated for tweak to parsing API.
-
- * kjs/Parser.cpp:
- (JSC::Parser::parse):
- * kjs/Parser.h:
- (JSC::Parser::parse): Tweaked the parser to make it possible to parse
- without an ExecState, and to allow the client to specify a debugger to
- notify (or not) about the source we parse. This allows the inspector
- to recompile even though no JavaScript is executing, then notify the
- debugger about all source code when it's done.
-
- * kjs/Shell.cpp:
- (prettyPrintScript): Updated for tweak to parsing API.
-
- * kjs/SourceRange.h:
- (JSC::SourceCode::isNull): Added to help with ASSERTs.
-
- * kjs/collector.cpp:
- (JSC::Heap::heapAllocate):
- (JSC::Heap::sweep):
- (JSC::Heap::primaryHeapBegin):
- (JSC::Heap::primaryHeapEnd):
- * kjs/collector.h:
- (JSC::): Moved a bunch of declarations around to enable compilation of
- CollectorHeapIterator.
-
- * kjs/interpreter.cpp:
- (JSC::Interpreter::checkSyntax):
- (JSC::Interpreter::evaluate): Updated for tweak to parsing API.
-
- * kjs/lexer.h:
- (JSC::Lexer::sourceCode): BUG FIX: Calculate SourceCode ranges relative
- to the SourceCode range in which we're lexing, otherwise nested functions
- that are compiled individually get SourceCode ranges that don't reflect
- their nesting.
-
- * kjs/nodes.cpp:
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::finishParsing):
- (JSC::FunctionBodyNode::create):
- (JSC::FunctionBodyNode::copyParameters):
- * kjs/nodes.h:
- (JSC::ScopeNode::setSource):
- (JSC::FunctionBodyNode::parameterCount): Added some helper functions for
- copying one FunctionBodyNode's parameters to another. The recompiler uses
- these when calling "finishParsing".
-
-2008-10-15 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Darin Adler.
-
- - part of https://bugs.webkit.org/show_bug.cgi?id=20746
- Fix compilation on Windows CE.
-
- str(n)icmp, strdup and vsnprintf are not available on Windows CE,
- they are called _str(n)icmp, etc. instead
-
- * wtf/StringExtras.h: Added inline function implementations.
-
-2008-10-15 Gabor Loki <loki@inf.u-szeged.hu>
-
- Reviewed by Cameron Zwarich.
-
- <https://bugs.webkit.org/show_bug.cgi?id=20912>
- Use simple uint32_t multiplication on op_mul if both operands are
- immediate number and they are between zero and 0x7FFF.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-09 Darin Fisher <darin@chromium.org>
-
- Reviewed by Sam Weinig.
-
- Make pan scrolling a platform configurable option.
- https://bugs.webkit.org/show_bug.cgi?id=21515
-
- * wtf/Platform.h: Add ENABLE_PAN_SCROLLING
-
-2008-10-14 Maciej Stachowiak <mjs@apple.com>
-
- Rubber stamped by Sam Weinig.
-
- - revert r37572 and r37581 for now
-
- Turns out GCC 4.2 is still a (small) regression, we'll have to do
- more work to turn it on.
-
- * Configurations/DebugRelease.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_end):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_timeout_check):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_loop_if_less):
- (JSC::Machine::cti_op_loop_if_lesseq):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_second):
- (JSC::Machine::cti_op_put_by_id_generic):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_put_by_val):
- (JSC::Machine::cti_op_put_by_val_array):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_jless):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_post_dec):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_get_pnames):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_push_scope):
- (JSC::Machine::cti_op_pop_scope):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_jmp_scopes):
- (JSC::Machine::cti_op_put_by_index):
- (JSC::Machine::cti_op_switch_imm):
- (JSC::Machine::cti_op_switch_char):
- (JSC::Machine::cti_op_switch_string):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_put_getter):
- (JSC::Machine::cti_op_put_setter):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_op_debug):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitRestoreArgumentReference):
- (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
- * wtf/Platform.h:
-
-2008-10-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20256
- Array.push and other standard methods disappear
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::~JSGlobalData):
- Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS -
- these tables reference IdentifierTable, which is always per-GlobalData.
-
-2008-10-14 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL
-
- This is a small regression for GCC 4.0, but simplifies the code
- for future improvements and lets us focus on GCC 4.2+ and MSVC.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_end):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_timeout_check):
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_loop_if_less):
- (JSC::Machine::cti_op_loop_if_lesseq):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_second):
- (JSC::Machine::cti_op_put_by_id_generic):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_put_by_val):
- (JSC::Machine::cti_op_put_by_val_array):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_jless):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_post_dec):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_get_pnames):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_push_scope):
- (JSC::Machine::cti_op_pop_scope):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_jmp_scopes):
- (JSC::Machine::cti_op_put_by_index):
- (JSC::Machine::cti_op_switch_imm):
- (JSC::Machine::cti_op_switch_char):
- (JSC::Machine::cti_op_switch_string):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_put_getter):
- (JSC::Machine::cti_op_put_setter):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_op_debug):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitRestoreArgumentReference):
- (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
- * wtf/Platform.h:
-
-2008-10-13 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - make Machine::getArgumentsData an Arguments method and inline it
-
- ~2% on v8 raytrace
-
- * VM/Machine.cpp:
- * kjs/Arguments.h:
- (JSC::Machine::getArgumentsData):
-
-2008-10-13 Alp Toker <alp@nuanti.com>
-
- Fix autotools dist build target by listing recently added header
- files only. Not reviewed.
-
- * GNUmakefile.am:
-
-2008-10-13 Maciej Stachowiak <mjs@apple.com>
-
- Rubber stamped by Mark Rowe.
-
- - fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
- - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
-
- * Configurations/DebugRelease.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-10-13 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21541: Move RegisterFile growth check to callee
- <https://bugs.webkit.org/show_bug.cgi?id=21541>
-
- Move the RegisterFile growth check to the callee in the common case,
- where some of the information is known statically at JIT time. There is
- still a check in the caller in the case where the caller provides too
- few arguments.
-
- This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
- the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
- 1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
- SunSpider.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompile):
- * VM/Machine.cpp:
- (JSC::Machine::cti_register_file_check):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/Machine.h:
- * VM/RegisterFile.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::cmpl_mr):
- (JSC::X86Assembler::emitUnlinkedJg):
-
-2008-10-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
- 5 false positive StructureID leaks
-
- - Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
- - Add create method to JSGlolalData to be used when the data will be intentionally
- leaked and ignore all leaks caused the StructureIDs stored in it.
+ - Exposed functions now needed by WebCore.
* JavaScriptCore.exp:
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::createLeaked):
- * kjs/JSGlobalData.h:
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
- (JSC::StructureID::startIgnoringLeaks):
- (JSC::StructureID::stopIgnoringLeaks):
- * kjs/StructureID.h:
-
-2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Darin Adler. Landed by Jan Alonzo.
-
- WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
- http://bugs.webkit.org/show_bug.cgi?id=20483
-
- Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
- allocated by GLib and start the conversion to use it.
-
- * GNUmakefile.am:
- * wtf/GOwnPtr.cpp: Added.
- (WTF::GError):
- (WTF::GList):
- (WTF::GCond):
- (WTF::GMutex):
- (WTF::GPatternSpec):
- (WTF::GDir):
- * wtf/GOwnPtr.h: Added.
- (WTF::freeOwnedPtr):
- (WTF::GOwnPtr::GOwnPtr):
- (WTF::GOwnPtr::~GOwnPtr):
- (WTF::GOwnPtr::get):
- (WTF::GOwnPtr::release):
- (WTF::GOwnPtr::rawPtr):
- (WTF::GOwnPtr::set):
- (WTF::GOwnPtr::clear):
- (WTF::GOwnPtr::operator*):
- (WTF::GOwnPtr::operator->):
- (WTF::GOwnPtr::operator!):
- (WTF::GOwnPtr::operator UnspecifiedBoolType):
- (WTF::GOwnPtr::swap):
- (WTF::swap):
- (WTF::operator==):
- (WTF::operator!=):
- (WTF::getPtr):
- * wtf/Threading.h:
- * wtf/ThreadingGtk.cpp:
- (WTF::Mutex::~Mutex):
- (WTF::Mutex::lock):
- (WTF::Mutex::tryLock):
- (WTF::Mutex::unlock):
- (WTF::ThreadCondition::~ThreadCondition):
- (WTF::ThreadCondition::wait):
- (WTF::ThreadCondition::timedWait):
- (WTF::ThreadCondition::signal):
- (WTF::ThreadCondition::broadcast):
-
-2008-10-12 Gabriella Toth <gtoth@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- - part of https://bugs.webkit.org/show_bug.cgi?id=21055
- Bug 21055: not invoked functions
-
- * kjs/nodes.cpp: Deleted a function that is not invoked:
- statementListInitializeVariableAccessStack.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- * wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
- * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21556
- Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
-
- * wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
- * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
-
-2008-10-12 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- Make the append method that takes a Vector more strict - it now requires the elements
- of the vector to be appended same type as the elements of the Vector they're being appended to.
-
- This would cause problems when dealing with Vectors containing other Vectors.
-
- * wtf/Vector.h:
- (WTF::::append):
-
-2008-10-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Clean up RegExpMatchesArray.h to match our coding style.
-
- * kjs/RegExpMatchesArray.h:
- (JSC::RegExpMatchesArray::getOwnPropertySlot):
- (JSC::RegExpMatchesArray::put):
- (JSC::RegExpMatchesArray::deleteProperty):
- (JSC::RegExpMatchesArray::getPropertyNames):
-
-2008-10-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 21525: 55 StructureID leaks on Wikitravel's main page
- <https://bugs.webkit.org/show_bug.cgi?id=21525>
-
- Bug 21533: Simple JavaScript code leaks StructureIDs
- <https://bugs.webkit.org/show_bug.cgi?id=21533>
-
- StructureID::getEnumerablePropertyNames() ends up calling back to itself
- via JSObject::getPropertyNames(), which causes the PropertyNameArray to
- be cached twice. This leads to a memory leak in almost every use of
- JSObject::getPropertyNames() on an object. The fix here is based on a
- suggestion of Sam Weinig.
-
- This patch also fixes every StructureID leaks that occurs while running
- the Mozilla MemBuster test.
-
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArray::PropertyNameArray):
- (JSC::PropertyNameArray::setCacheable):
- (JSC::PropertyNameArray::cacheable):
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames):
-
-2008-10-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Use fastcall calling convention on GCC > 4.0
-
- Results in a 2-3% improvement in GCC 4.2 performance, so
- that it is no longer a regression vs. GCC 4.0
-
- * VM/CTI.cpp:
- * VM/Machine.h:
- * wtf/Platform.h:
-
-2008-10-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- - Add a workaround for a bug in ceil in Darwin libc.
- - Remove old workarounds for JS math functions that are not needed
- anymore.
-
- The math functions are heavily tested by fast/js/math.html.
-
- * kjs/MathObject.cpp:
- (JSC::mathProtoFuncAbs): Remove workaround.
- (JSC::mathProtoFuncCeil): Ditto.
- (JSC::mathProtoFuncFloor): Ditto.
- * wtf/MathExtras.h:
- (wtf_ceil): Add ceil workaround for darwin.
-
-2008-10-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler
-
- Add Assertions to JSObject constructor.
-
- * kjs/JSObject.h:
- (JSC::JSObject::JSObject):
-
-2008-10-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Remove now unused m_getterSetterFlag variable from PropertyMap.
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::operator=):
- * kjs/PropertyMap.h:
- (JSC::PropertyMap::PropertyMap):
-
-2008-10-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Add leaks checking to StructureID.
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::~StructureID):
-
-2008-10-09 Alp Toker <alp@nuanti.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=20760
- Implement support for x86 Linux in CTI
-
- Prepare to enable CTI/WREC on supported architectures.
-
- Make it possible to use the CTI_ARGUMENT workaround with GCC as well
- as MSVC by fixing some preprocessor conditionals.
-
- Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
- don't actually enable it except when building with MSVC. GCC on Win32
- remains untested.
-
- Adapt inline ASM code to use the global symbol underscore prefix only
- on Darwin and to call the properly mangled Machine::cti_vm_throw
- symbol name depending on CTI_ARGUMENT.
-
- Also avoid global inclusion of the JIT infrastructure headers
- throughout WebCore and WebKit causing recompilation of about ~1500
- source files after modification to X86Assembler.h, CTI.h, WREC.h,
- which are only used deep inside JavaScriptCore.
-
- * GNUmakefile.am:
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * kjs/regexp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::~RegExp):
- (JSC::RegExp::match):
- * kjs/regexp.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitConvertToFastCall):
- (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
- (JSC::X86Assembler::emitRestoreArgumentReference):
-
-2008-10-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix for bug #21160, x=0;1/(x*-1) == -Infinity
-
- * ChangeLog:
- * VM/CTI.cpp:
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::emitUnlinkedJs):
-
-2008-10-09 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
- <https://bugs.webkit.org/show_bug.cgi?id=21459>
-
- After r37324, an Arguments object does not mark an associated activation
- object. This change was made because Arguments no longer directly used
- the activation object in any way. However, if an activation is torn off,
- then the backing store of Arguments becomes the register array of the
- activation object. Arguments directly marks all of the arguments, but
- the activation object is being collected, which causes its register
- array to be freed and new memory to be allocated in its place.
-
- Unfortunately, it does not seem possible to reproduce this issue in a
- layout test.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::mark):
- * kjs/Arguments.h:
- (JSC::Arguments::setActivation):
- (JSC::Arguments::Arguments):
- (JSC::JSActivation::copyRegisters):
-
-2008-10-09 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon.
-
- Build fix for MinGW.
-
- * wtf/AlwaysInline.h:
-
-2008-10-08 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21497: REGRESSION (r37433): Bytecode JSC tests are severely broken
- <https://bugs.webkit.org/show_bug.cgi?id=21497>
-
- Fix a typo in r37433 that causes the failure of a large number of JSC
- tests with the bytecode interpreter enabled.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-08 Mark Rowe <mrowe@apple.com>
-
- Windows build fix.
-
- * VM/CTI.cpp:
- (JSC::): Update type of argument to ctiTrampoline.
-
-2008-10-08 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21403
- Bug 21403: use new CallFrame class rather than Register* for call frame manipulation
-
- Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
- client over to the new name.
-
- Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
- as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
- accessor functions to get at things in the frame.
-
- Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
- JSGlobalData* and in other cases eliminating them entirely.
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunctionWithCallback):
- (JSObjectMakeFunction):
- (JSObjectHasProperty):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectDeleteProperty):
- * API/OpaqueJSString.cpp:
- * API/OpaqueJSString.h:
- * VM/CTI.cpp:
- (JSC::CTI::getConstant):
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp):
- (JSC::CodeGenerator::emitLoad):
- (JSC::CodeGenerator::emitUnexpectedLoad):
- (JSC::CodeGenerator::emitConstruct):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAddSlowCase):
- (JSC::jsAdd):
- (JSC::jsTypeStringForValue):
- (JSC::Machine::resolve):
- (JSC::Machine::resolveSkip):
- (JSC::Machine::resolveGlobal):
- (JSC::inlineResolveBase):
- (JSC::Machine::resolveBase):
- (JSC::Machine::resolveBaseAndProperty):
- (JSC::Machine::resolveBaseAndFunc):
- (JSC::Machine::slideRegisterWindowForCall):
- (JSC::isNotObject):
- (JSC::Machine::callEval):
- (JSC::Machine::dumpCallFrame):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::throwException):
- (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
- (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
- (JSC::Machine::execute):
- (JSC::Machine::debug):
- (JSC::Machine::createExceptionScope):
- (JSC::cachePrototypeChain):
- (JSC::Machine::tryCachePutByID):
- (JSC::Machine::tryCacheGetByID):
- (JSC::Machine::privateExecute):
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::retrieveCaller):
- (JSC::Machine::retrieveLastCaller):
- (JSC::Machine::findFunctionCallFrame):
- (JSC::Machine::getArgumentsData):
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::getCTIArrayLengthTrampoline):
- (JSC::Machine::getCTIStringLengthTrampoline):
- (JSC::Machine::tryCTICacheGetByID):
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_end):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_timeout_check):
- (JSC::Machine::cti_op_loop_if_less):
- (JSC::Machine::cti_op_loop_if_lesseq):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_second):
- (JSC::Machine::cti_op_put_by_id_generic):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_put_by_val):
- (JSC::Machine::cti_op_put_by_val_array):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_jless):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_post_dec):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_get_pnames):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_push_scope):
- (JSC::Machine::cti_op_pop_scope):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_jmp_scopes):
- (JSC::Machine::cti_op_put_by_index):
- (JSC::Machine::cti_op_switch_imm):
- (JSC::Machine::cti_op_switch_char):
- (JSC::Machine::cti_op_switch_string):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_put_getter):
- (JSC::Machine::cti_op_put_setter):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_op_debug):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * VM/Register.h:
- * VM/RegisterFile.h:
- * kjs/Arguments.h:
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::functionName):
- (JSC::DebuggerCallFrame::type):
- (JSC::DebuggerCallFrame::thisObject):
- (JSC::DebuggerCallFrame::evaluate):
- * kjs/DebuggerCallFrame.h:
- * kjs/ExecState.cpp:
- (JSC::CallFrame::thisValue):
- * kjs/ExecState.h:
- * kjs/FunctionConstructor.cpp:
- (JSC::constructFunction):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::JSActivation):
- (JSC::JSActivation::argumentsGetter):
- * kjs/JSActivation.h:
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init):
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval):
- * kjs/JSVariableObject.h:
- * kjs/Parser.cpp:
- (JSC::Parser::parse):
- * kjs/RegExpConstructor.cpp:
- (JSC::constructRegExp):
- * kjs/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncCompile):
- * kjs/Shell.cpp:
- (prettyPrintScript):
- * kjs/StringPrototype.cpp:
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- * kjs/identifier.cpp:
- (JSC::Identifier::checkSameIdentifierTable):
- * kjs/interpreter.cpp:
- (JSC::Interpreter::checkSyntax):
- (JSC::Interpreter::evaluate):
- * kjs/nodes.cpp:
- (JSC::ThrowableExpressionData::emitThrowError):
- (JSC::RegExpNode::emitCode):
- (JSC::ArrayNode::emitCode):
- (JSC::InstanceOfNode::emitCode):
- * kjs/nodes.h:
- * kjs/regexp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::create):
- * kjs/regexp.h:
- * profiler/HeavyProfile.h:
- * profiler/Profile.h:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
-
-2008-10-08 Mark Rowe <mrowe@apple.com>
-
- Typed by Maciej Stachowiak, reviewed by Mark Rowe.
-
- Fix crash in fast/js/constant-folding.html with CTI disabled.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-08 Timothy Hatcher <timothy@apple.com>
-
- Roll out r37427 because it causes an infinite recursion loading about:blank.
-
- https://bugs.webkit.org/show_bug.cgi?id=21476
-
-2008-10-08 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21403
- Bug 21403: use new CallFrame class rather than Register* for call frame manipulation
-
- Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
- client over to the new name.
-
- Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
- as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
- accessor functions to get at things in the frame.
-
- Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
- JSGlobalData* and in other cases eliminating them entirely.
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunctionWithCallback):
- (JSObjectMakeFunction):
- (JSObjectHasProperty):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectDeleteProperty):
- * API/OpaqueJSString.cpp:
- * API/OpaqueJSString.h:
- * VM/CTI.cpp:
- (JSC::CTI::getConstant):
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
- (JSC::CTI::printOpcodeOperandTypes):
- (JSC::CTI::CTI):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp):
- (JSC::CodeGenerator::emitLoad):
- (JSC::CodeGenerator::emitUnexpectedLoad):
- (JSC::CodeGenerator::emitConstruct):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::jsLess):
- (JSC::jsLessEq):
- (JSC::jsAddSlowCase):
- (JSC::jsAdd):
- (JSC::jsTypeStringForValue):
- (JSC::Machine::resolve):
- (JSC::Machine::resolveSkip):
- (JSC::Machine::resolveGlobal):
- (JSC::inlineResolveBase):
- (JSC::Machine::resolveBase):
- (JSC::Machine::resolveBaseAndProperty):
- (JSC::Machine::resolveBaseAndFunc):
- (JSC::Machine::slideRegisterWindowForCall):
- (JSC::isNotObject):
- (JSC::Machine::callEval):
- (JSC::Machine::dumpCallFrame):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::throwException):
- (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
- (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
- (JSC::Machine::execute):
- (JSC::Machine::debug):
- (JSC::Machine::createExceptionScope):
- (JSC::cachePrototypeChain):
- (JSC::Machine::tryCachePutByID):
- (JSC::Machine::tryCacheGetByID):
- (JSC::Machine::privateExecute):
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::retrieveCaller):
- (JSC::Machine::retrieveLastCaller):
- (JSC::Machine::findFunctionCallFrame):
- (JSC::Machine::getArgumentsData):
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::getCTIArrayLengthTrampoline):
- (JSC::Machine::getCTIStringLengthTrampoline):
- (JSC::Machine::tryCTICacheGetByID):
- (JSC::Machine::cti_op_convert_this):
- (JSC::Machine::cti_op_end):
- (JSC::Machine::cti_op_add):
- (JSC::Machine::cti_op_pre_inc):
- (JSC::Machine::cti_timeout_check):
- (JSC::Machine::cti_op_loop_if_less):
- (JSC::Machine::cti_op_loop_if_lesseq):
- (JSC::Machine::cti_op_new_object):
- (JSC::Machine::cti_op_put_by_id):
- (JSC::Machine::cti_op_put_by_id_second):
- (JSC::Machine::cti_op_put_by_id_generic):
- (JSC::Machine::cti_op_put_by_id_fail):
- (JSC::Machine::cti_op_get_by_id):
- (JSC::Machine::cti_op_get_by_id_second):
- (JSC::Machine::cti_op_get_by_id_generic):
- (JSC::Machine::cti_op_get_by_id_fail):
- (JSC::Machine::cti_op_instanceof):
- (JSC::Machine::cti_op_del_by_id):
- (JSC::Machine::cti_op_mul):
- (JSC::Machine::cti_op_new_func):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- (JSC::Machine::cti_op_new_array):
- (JSC::Machine::cti_op_resolve):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_get_by_val):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_sub):
- (JSC::Machine::cti_op_put_by_val):
- (JSC::Machine::cti_op_put_by_val_array):
- (JSC::Machine::cti_op_lesseq):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_negate):
- (JSC::Machine::cti_op_resolve_base):
- (JSC::Machine::cti_op_resolve_skip):
- (JSC::Machine::cti_op_resolve_global):
- (JSC::Machine::cti_op_div):
- (JSC::Machine::cti_op_pre_dec):
- (JSC::Machine::cti_op_jless):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_lshift):
- (JSC::Machine::cti_op_bitand):
- (JSC::Machine::cti_op_rshift):
- (JSC::Machine::cti_op_bitnot):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_new_func_exp):
- (JSC::Machine::cti_op_mod):
- (JSC::Machine::cti_op_less):
- (JSC::Machine::cti_op_neq):
- (JSC::Machine::cti_op_post_dec):
- (JSC::Machine::cti_op_urshift):
- (JSC::Machine::cti_op_bitxor):
- (JSC::Machine::cti_op_new_regexp):
- (JSC::Machine::cti_op_bitor):
- (JSC::Machine::cti_op_call_eval):
- (JSC::Machine::cti_op_throw):
- (JSC::Machine::cti_op_get_pnames):
- (JSC::Machine::cti_op_next_pname):
- (JSC::Machine::cti_op_push_scope):
- (JSC::Machine::cti_op_pop_scope):
- (JSC::Machine::cti_op_typeof):
- (JSC::Machine::cti_op_to_jsnumber):
- (JSC::Machine::cti_op_in):
- (JSC::Machine::cti_op_push_new_scope):
- (JSC::Machine::cti_op_jmp_scopes):
- (JSC::Machine::cti_op_put_by_index):
- (JSC::Machine::cti_op_switch_imm):
- (JSC::Machine::cti_op_switch_char):
- (JSC::Machine::cti_op_switch_string):
- (JSC::Machine::cti_op_del_by_val):
- (JSC::Machine::cti_op_put_getter):
- (JSC::Machine::cti_op_put_setter):
- (JSC::Machine::cti_op_new_error):
- (JSC::Machine::cti_op_debug):
- (JSC::Machine::cti_vm_throw):
- * VM/Machine.h:
- * VM/Register.h:
- * VM/RegisterFile.h:
- * kjs/Arguments.h:
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::functionName):
- (JSC::DebuggerCallFrame::type):
- (JSC::DebuggerCallFrame::thisObject):
- (JSC::DebuggerCallFrame::evaluate):
- * kjs/DebuggerCallFrame.h:
- * kjs/ExecState.cpp:
- (JSC::CallFrame::thisValue):
- * kjs/ExecState.h:
- * kjs/FunctionConstructor.cpp:
- (JSC::constructFunction):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::JSActivation):
- (JSC::JSActivation::argumentsGetter):
- * kjs/JSActivation.h:
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init):
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval):
- * kjs/JSVariableObject.h:
- * kjs/Parser.cpp:
- (JSC::Parser::parse):
- * kjs/RegExpConstructor.cpp:
- (JSC::constructRegExp):
- * kjs/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncCompile):
- * kjs/Shell.cpp:
- (prettyPrintScript):
- * kjs/StringPrototype.cpp:
- (JSC::stringProtoFuncMatch):
- (JSC::stringProtoFuncSearch):
- * kjs/identifier.cpp:
- (JSC::Identifier::checkSameIdentifierTable):
- * kjs/interpreter.cpp:
- (JSC::Interpreter::checkSyntax):
- (JSC::Interpreter::evaluate):
- * kjs/nodes.cpp:
- (JSC::ThrowableExpressionData::emitThrowError):
- (JSC::RegExpNode::emitCode):
- (JSC::ArrayNode::emitCode):
- (JSC::InstanceOfNode::emitCode):
- * kjs/nodes.h:
- * kjs/regexp.cpp:
- (JSC::RegExp::RegExp):
- (JSC::RegExp::create):
- * kjs/regexp.h:
- * profiler/HeavyProfile.h:
- * profiler/Profile.h:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
-
-2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Oliver Hunt.
-
- Avoid endless loops when compiling without the computed goto
- optimization.
-
- NEXT_OPCODE expands to "continue", which will not work inside
- loops.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-10-08 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Re-landing the following fix with the crashing bug in it fixed (r37405):
-
- - optimize away multiplication by constant 1.0
-
- 2.3% speedup on v8 RayTrace benchmark
-
- Apparently it's not uncommon for JavaScript code to multiply by
- constant 1.0 in the mistaken belief that this converts integer to
- floating point and that there is any operational difference.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for
- case where parameter is already number.
- (JSC::CTI::privateCompileSlowCases): ditto
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): ditto
- * kjs/grammar.y:
- (makeMultNode): Transform as follows:
- +FOO * BAR ==> FOO * BAR
- FOO * +BAR ==> FOO * BAR
- FOO * 1 ==> +FOO
- 1 * FOO ==> +FOO
- (makeDivNode): Transform as follows:
- +FOO / BAR ==> FOO / BAR
- FOO / +BAR ==> FOO / BAR
- (makeSubNode): Transform as follows:
- +FOO - BAR ==> FOO - BAR
- FOO - +BAR ==> FOO - BAR
- * kjs/nodes.h:
- (JSC::ExpressionNode::stripUnaryPlus): Helper for above
- grammar.y changes
- (JSC::UnaryPlusNode::stripUnaryPlus): ditto
-
-2008-10-08 Maciej Stachowiak <mjs@apple.com>
+2009-06-17 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
-
- - correctly handle appending -0 to a string, it should stringify as just 0
-
- * kjs/ustring.cpp:
- (JSC::concatenate):
-
-2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Simon.
-
- Fix WebKit compilation with VC2008SP1
-
- Apply the TR1 workaround for JavaScriptCore, too.
-
- * JavaScriptCore.pro:
-
-2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compilation errors on VS2008 64Bit
-
- * kjs/collector.cpp:
- (JSC::currentThreadStackBase):
-
-2008-10-08 André Pönitz <apoenitz@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compilation with Qt namespaces.
-
- * wtf/Threading.h:
-
-2008-10-07 Sam Weinig <sam@webkit.org>
- Roll out r37405.
+ Bug 26429: Make JSON.stringify non-recursive so it can handle objects
+ of arbitrary complexity
+ https://bugs.webkit.org/show_bug.cgi?id=26429
-2008-10-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Switch CTI runtime calls to the fastcall calling convention
-
- Basically this means that we get to store the argument for CTI
- calls in the ECX register, which saves a register->memory write
- and subsequent memory->register read.
-
- This is a 1.7% progression in SunSpider and 2.4% on commandline
- v8 tests on Windows
-
- * VM/CTI.cpp:
- (JSC::):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- * VM/CTI.h:
- * VM/Machine.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitRestoreArgumentReference):
- (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
- We need this to correctly reload ecx from inside certain property access
- trampolines.
- * wtf/Platform.h:
-
-2008-10-07 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Mark Rowe.
-
- - optimize away multiplication by constant 1.0
-
- 2.3% speedup on v8 RayTrace benchmark
-
- Apparently it's not uncommon for JavaScript code to multiply by
- constant 1.0 in the mistaken belief that this converts integer to
- floating point and that there is any operational difference.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for
- case where parameter is already number.
- (JSC::CTI::privateCompileSlowCases): ditto
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): ditto
- * kjs/grammar.y:
- (makeMultNode): Transform as follows:
- +FOO * BAR ==> FOO * BAR
- FOO * +BAR ==> FOO * BAR
- FOO * 1 ==> +FOO
- 1 * FOO ==> +FOO
- (makeDivNode): Transform as follows:
- +FOO / BAR ==> FOO / BAR
- FOO / +BAR ==> FOO / BAR
- (makeSubNode): Transform as follows:
- +FOO - BAR ==> FOO - BAR
- FOO - +BAR ==> FOO - BAR
- * kjs/nodes.h:
- (JSC::ExpressionNode::stripUnaryPlus): Helper for above
- grammar.y changes
- (JSC::UnaryPlusNode::stripUnaryPlus): ditto
-
-2008-10-07 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - make constant folding code more consistent
-
- Added a makeSubNode to match add, mult and div; use the makeFooNode functions always,
- instead of allocating nodes directly in other places in the grammar.
+ For marking I decided not to use gcProtect, because this is inside the engine
+ so it's easy enough to just do marking. And that darned gcProtect does locking!
+ Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
+ for that class says "FIXME: Remove all clients of this API, then remove this API."
- * kjs/grammar.y:
-
-2008-10-07 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Move hasGetterSetterProperties flag from PropertyMap to StructureID.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::put):
- (JSC::JSObject::defineGetter):
- (JSC::JSObject::defineSetter):
- * kjs/JSObject.h:
- (JSC::JSObject::hasGetterSetterProperties):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSObject::getOwnPropertySlot):
- * kjs/PropertyMap.h:
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::addPropertyTransition):
- (JSC::StructureID::toDictionaryTransition):
- (JSC::StructureID::changePrototypeTransition):
- (JSC::StructureID::getterSetterTransition):
- * kjs/StructureID.h:
- (JSC::StructureID::hasGetterSetterProperties):
- (JSC::StructureID::setHasGetterSetterProperties):
-
-2008-10-07 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
+ * runtime/Collector.cpp:
+ (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
- Roll r37370 back in with bug fixes.
+ * runtime/CommonIdentifiers.cpp:
+ (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
+ * runtime/CommonIdentifiers.h: Ditto.
- - PropertyMap::storageSize() should reflect the number of keys + deletedOffsets
- and has nothing to do with the internal deletedSentinel count anymore.
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
+ * runtime/JSGlobalData.h: Added firstStringifierToMark.
+
+ * runtime/JSONObject.cpp: Cut down the includes to the needed ones only.
+ (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string
+ objects to get their number and string values.
+ (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used
+ to wrap an identifier or integer so we don't have to do any work unless we
+ actually call a replacer.
+ (JSC::ReplacerPropertyName::value): Added.
+ (JSC::gap): Added. Helper function for the Stringifier constructor.
+ (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added.
+ The class is used to wrap an identifier or integer so we don't have to
+ allocate a number or string until we actually call toJSON or a replacer.
+ (JSC::PropertyNameForFunctionCall::asJSValue): Added.
+ (JSC::Stringifier::Stringifier): Updated and moved out of the class
+ definition. Added code to hook this into a singly linked list for marking.
+ (JSC::Stringifier::~Stringifier): Remove from the singly linked list.
+ (JSC::Stringifier::mark): Mark all the objects in the holder stacks.
+ (JSC::Stringifier::stringify): Updated.
+ (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit.
+ (JSC::Stringifier::toJSON): Renamed from toJSONValue.
+ (JSC::Stringifier::appendStringifiedValue): Renamed from stringify.
+ Added code to use the m_holderStack to do non-recursive stringify of
+ objects and arrays. This code also uses the timeout checker since in
+ pathological cases it could be slow even without calling into the
+ JavaScript virtual machine.
+ (JSC::Stringifier::willIndent): Added.
+ (JSC::Stringifier::indent): Added.
+ (JSC::Stringifier::unindent): Added.
+ (JSC::Stringifier::startNewLine): Added.
+ (JSC::Stringifier::Holder::Holder): Added.
+ (JSC::Stringifier::Holder::appendNextProperty): Added. This is the
+ function that handles the format of arrays and objects.
+ (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom
+ of the file so the JSONObject class is not interleaved with the
+ Stringifier class.
+ (JSC::JSONObject::markStringifiers): Added. Calls mark.
+ (JSC::JSONProtoFuncStringify): Streamlined the code here. The code
+ to compute the gap string is now a separate function.
+
+ * runtime/JSONObject.h: Made everything private. Added markStringifiers.
+
+2009-06-17 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com
+
+ Roll out r43849 as it appears that we cannot rely on the address of
+ an objects property storage being constant even if the structure is
+ unchanged.
-2008-10-07 Gavin Barraclough <barraclough@apple.com>
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetDirectOffset):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
- Reviewed by Oliver Hunt.
+2009-06-17 Gavin Barraclough <barraclough@apple.com>
- Move callframe initialization into JIT code, again.
-
- As a part of the restructuring the second result from functions is now
- returned in edx, allowing the new value of 'r' to be returned via a
- register, and stored to the stack from JIT code, too.
+ Rubber Stamped by Mark Rowe.
- 4.5% progression on v8-tests. (3% in their harness)
+ Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.
- * VM/CTI.cpp:
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_throw):
+ * jit/JITStubs.cpp:
(JSC::):
- (JSC::CTI::emitCall):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/CTI.h:
- (JSC::CallRecord::CallRecord):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_resolve_func):
- (JSC::Machine::cti_op_post_inc):
- (JSC::Machine::cti_op_resolve_with_base):
- (JSC::Machine::cti_op_post_dec):
- * VM/Machine.h:
- * kjs/JSFunction.h:
- * kjs/ScopeChain.h:
-
-2008-10-07 Mark Rowe <mrowe@apple.com>
-
- Fix typo in method name.
-
- * wrec/WREC.cpp:
- * wrec/WREC.h:
-
-2008-10-07 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Mark Rowe.
-
- Roll out r37370.
-
-2008-10-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21415
- Improve the division between PropertyStorageArray and PropertyMap
-
- - Rework ProperyMap to store offsets in the value so that they don't
- change when rehashing. This allows us not to have to keep the
- PropertyStorageArray in sync and thus not have to pass it in.
- - Rename PropertyMap::getOffset -> PropertyMap::get since put/remove
- now also return offsets.
- - A Vector of deleted offsets is now needed since the storage is out of
- band.
-
- 1% win on SunSpider. Wash on V8 suite.
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::transitionWillNeedStorageRealloc):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- Transition logic can be greatly simplified by the fact that
- the storage capacity is always known, and is correct for the
- inline case.
- * kjs/JSObject.cpp:
- (JSC::JSObject::put): Rename getOffset -> get.
- (JSC::JSObject::deleteProperty): Ditto.
- (JSC::JSObject::getPropertyAttributes): Ditto.
- (JSC::JSObject::removeDirect): Use returned offset to
- clear the value in the PropertyNameArray.
- (JSC::JSObject::allocatePropertyStorage): Add assert.
- * kjs/JSObject.h:
- (JSC::JSObject::getDirect): Rename getOffset -> get
- (JSC::JSObject::getDirectLocation): Rename getOffset -> get
- (JSC::JSObject::putDirect): Use propertyStorageCapacity to determine whether
- or not to resize. Also, since put now returns an offset (and thus
- addPropertyTransition does also) setting of the PropertyStorageArray is
- now done here.
- (JSC::JSObject::transitionTo):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::checkConsistency): PropertyStorageArray is no longer
- passed in.
- (JSC::PropertyMap::operator=): Copy the delete offsets vector.
- (JSC::PropertyMap::put): Instead of setting the PropertyNameArray
- explicitly, return the offset where the value should go.
- (JSC::PropertyMap::remove): Instead of removing from the PropertyNameArray
- explicitly, return the offset where the value should be removed.
- (JSC::PropertyMap::get): Switch to using the stored offset, instead
- of the implicit one.
- (JSC::PropertyMap::insert):
- (JSC::PropertyMap::expand): This is never called when m_table is null,
- so remove that branch and add it as an assertion.
- (JSC::PropertyMap::createTable): Consistency checks no longer take
- a PropertyNameArray.
- (JSC::PropertyMap::rehash): No need to rehash the PropertyNameArray
- now that it is completely out of band.
- * kjs/PropertyMap.h:
- (JSC::PropertyMapEntry::PropertyMapEntry): Store offset into PropertyNameArray.
- (JSC::PropertyMap::get): Switch to using the stored offset, instead
- of the implicit one.
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID): Initialize the propertyStorageCapacity to
- JSObject::inlineStorageCapacity.
- (JSC::StructureID::growPropertyStorageCapacity): Grow the storage capacity as
- described below.
- (JSC::StructureID::addPropertyTransition): Copy the storage capacity.
- (JSC::StructureID::toDictionaryTransition): Ditto.
- (JSC::StructureID::changePrototypeTransition): Ditto.
- (JSC::StructureID::getterSetterTransition): Ditto.
- * kjs/StructureID.h:
- (JSC::StructureID::propertyStorageCapacity): Add propertyStorageCapacity
- which is the current capacity for the JSObjects PropertyStorageArray.
- It starts at the JSObject::inlineStorageCapacity (currently 2), then
- when it first needs to be resized moves to the JSObject::nonInlineBaseStorageCapacity
- (currently 16), and after that doubles each time.
-
-2008-10-06 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21396: Remove the OptionalCalleeActivation call frame slot
- <https://bugs.webkit.org/show_bug.cgi?id=21396>
-
- Remove the OptionalCalleeActivation call frame slot. We have to be
- careful to store the activation object in a register, because objects
- in the scope chain do not get marked.
-
- This is a 0.3% speedup on both SunSpider and the V8 benchmark.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::emitReturn):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_push_activation):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/Machine.h:
- (JSC::Machine::initializeCallFrame):
- * VM/RegisterFile.h:
- (JSC::RegisterFile::):
-
-2008-10-06 Tony Chang <tony@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Chromium doesn't use pthreads on windows, so make its use conditional.
-
- Also convert a WORD to a DWORD to avoid a compiler warning. This
- matches the other methods around it.
-
- * wtf/ThreadingWin.cpp:
- (WTF::wtfThreadEntryPoint):
- (WTF::ThreadCondition::broadcast):
-
-2008-10-06 Mark Mentovai <mark@moxienet.com>
-
- Reviewed by Tim Hatcher.
-
- Allow ENABLE_DASHBOARD_SUPPORT and ENABLE_MAC_JAVA_BRIDGE to be
- disabled on the Mac.
-
- https://bugs.webkit.org/show_bug.cgi?id=21333
-
- * wtf/Platform.h:
-
-2008-10-06 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21416
- Pass 0 for size to VirtualAlloc, as documented by MSDN.
- Identified by Application Verifier.
-
- Reviewed by Darin Adler.
-
- * kjs/collector.cpp:
- (KJS::freeBlock):
-
-2008-10-06 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcheri and Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=21412
- Bug 21412: Refactor user initiated profile count to be more stable
- - Export UString::from for use with creating the profile title.
-
- * JavaScriptCore.exp:
-
-2008-10-06 Maciej Stachowiak <mjs@apple.com>
-
- Not reviewed. Build fix.
-
- - revert toBoolean changes (r37333 and r37335); need to make WebCore work with these
-
- * API/JSValueRef.cpp:
- (JSValueToBoolean):
- * ChangeLog:
- * JavaScriptCore.exp:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- * kjs/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncSome):
- * kjs/BooleanConstructor.cpp:
- (JSC::constructBoolean):
- (JSC::callBooleanConstructor):
- * kjs/GetterSetter.h:
- * kjs/JSCell.h:
- (JSC::JSValue::toBoolean):
- * kjs/JSNumberCell.cpp:
- (JSC::JSNumberCell::toBoolean):
- * kjs/JSNumberCell.h:
- * kjs/JSObject.cpp:
- (JSC::JSObject::toBoolean):
- * kjs/JSObject.h:
- * kjs/JSString.cpp:
- (JSC::JSString::toBoolean):
- * kjs/JSString.h:
- * kjs/JSValue.h:
- * kjs/RegExpConstructor.cpp:
- (JSC::setRegExpConstructorMultiline):
- * kjs/RegExpObject.cpp:
- (JSC::RegExpObject::match):
- * kjs/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncToString):
-
-2008-10-06 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Sam Weinig.
-
- - optimize op_jtrue, op_loop_if_true and op_not in various ways
- https://bugs.webkit.org/show_bug.cgi?id=21404
-
- 1) Make JSValue::toBoolean nonvirtual and completely inline by
- making use of the StructureID type field.
-
- 2) Make JSValue::toBoolean not take an ExecState; doesn't need it.
-
- 3) Make op_not, op_loop_if_true and op_jtrue not read the
- ExecState (toBoolean doesn't need it any more) and not check
- exceptions (toBoolean can't throw).
-
- * API/JSValueRef.cpp:
- (JSValueToBoolean):
- * JavaScriptCore.exp:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_loop_if_true):
- (JSC::Machine::cti_op_not):
- (JSC::Machine::cti_op_jtrue):
- * kjs/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncFilter):
- (JSC::arrayProtoFuncEvery):
- (JSC::arrayProtoFuncSome):
- * kjs/BooleanConstructor.cpp:
- (JSC::constructBoolean):
- (JSC::callBooleanConstructor):
- * kjs/GetterSetter.h:
- * kjs/JSCell.h:
- (JSC::JSValue::toBoolean):
- * kjs/JSNumberCell.cpp:
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::toBoolean):
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- (JSC::JSObject::toBoolean):
- (JSC::JSCell::toBoolean):
- * kjs/JSString.cpp:
- * kjs/JSString.h:
- (JSC::JSString::toBoolean):
- * kjs/JSValue.h:
- * kjs/RegExpConstructor.cpp:
- (JSC::setRegExpConstructorMultiline):
- * kjs/RegExpObject.cpp:
- (JSC::RegExpObject::match):
- * kjs/RegExpPrototype.cpp:
- (JSC::regExpProtoFuncToString):
-
-2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon.
-
- Build fix for MinGW.
-
- * JavaScriptCore.pri:
- * kjs/DateMath.cpp:
- (JSC::highResUpTime):
-
-2008-10-05 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Remove ScopeNode::containsClosures() now that it is unused.
-
- * kjs/nodes.h:
- (JSC::ScopeNode::containsClosures):
-
-2008-10-05 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix releas-only test failures caused by the fix to bug 21375
-
- * VM/Machine.cpp:
- (JSC::Machine::unwindCallFrame): Update ExecState while unwinding call frames;
- it now matters more to have a still-valid ExecState, since dynamicGlobalObject
- will make use of the ExecState's scope chain.
- * VM/Machine.h:
-
-2008-10-05 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
- <https://bugs.webkit.org/show_bug.cgi?id=21364>
-
- Use information from the parser to detect whether an activation is
- needed or 'arguments' is used, and emit explicit instructions to tear
- them off before op_ret. This allows a branch to be removed from op_ret
- and simplifies some other code. This does cause a small change in the
- behaviour of 'f.arguments'; it is no longer live when 'arguments' is not
- mentioned in the lexical scope of the function.
-
- It should now be easy to remove the OptionaCalleeActivation slot in the
- call frame, but this will be done in a later patch.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitReturn):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::privateExecute):
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_tear_off_activation):
- (JSC::Machine::cti_op_tear_off_arguments):
- * VM/Machine.h:
- * VM/Opcode.h:
- * kjs/Arguments.cpp:
- (JSC::Arguments::mark):
- * kjs/Arguments.h:
- (JSC::Arguments::isTornOff):
- (JSC::Arguments::Arguments):
- (JSC::Arguments::copyRegisters):
- (JSC::JSActivation::copyRegisters):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::argumentsGetter):
- * kjs/JSActivation.h:
-
-2008-10-05 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - fixed "REGRESSION (r37297): fast/js/deep-recursion-test takes too long and times out"
- https://bugs.webkit.org/show_bug.cgi?id=21375
-
- The problem is that dynamicGlobalObject had become O(N) in number
- of call frames, but unwinding the stack for an exception called it
- for every call frame, resulting in O(N^2) behavior for an
- exception thrown from inside deep recursion.
-
- Instead of doing it that way, stash the dynamic global object in JSGlobalData.
-
- * JavaScriptCore.exp:
- * VM/Machine.cpp:
- (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Helper class to temporarily
- store and later restore a dynamicGlobalObject in JSGlobalData.
- (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
- (JSC::Machine::execute): In each version, establish a DynamicGlobalObjectScope.
- For ProgramNode, always establish set new dynamicGlobalObject, for FunctionBody and Eval,
- only if none is currently set.
- * VM/Machine.h:
- * kjs/ExecState.h:
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Ininitalize new dynamicGlobalObject field to 0.
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.h:
- (JSC::ExecState::dynamicGlobalObject): Moved here from ExecState for benefit of inlining.
- Return lexical global object if this is a globalExec(), otherwise look in JSGlobalData
- for the one stashed there.
-
-2008-10-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Avoid an extra lookup when transitioning to an existing StructureID
- by caching the offset of property that caused the transition.
-
- 1% win on V8 suite. Wash on SunSpider.
-
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::put):
- * kjs/PropertyMap.h:
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::addPropertyTransition):
- * kjs/StructureID.h:
- (JSC::StructureID::setCachedTransistionOffset):
- (JSC::StructureID::cachedTransistionOffset):
-
-2008-10-05 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
- <https://bugs.webkit.org/show_bug.cgi?id=21364>
-
- This patch does not yet remove the branch, but it does a bit of refactoring
- so that a CodeGenerator now knows whether the associated CodeBlock will need
- a full scope before doing any code generation. This makes it possible to emit
- explicit tear-off instructions before every op_ret.
-
- * VM/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate):
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::emitPushScope):
- (JSC::CodeGenerator::emitPushNewScope):
- * kjs/nodes.h:
- (JSC::ScopeNode::needsActivation):
-
-2008-10-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fix for bug #21387 - using SamplingTool with CTI.
-
- (1) A repatch offset offset changes due to an additional instruction to update SamplingTool state.
- (2) Fix an incusion order problem due to ExecState changes.
- (3) Change to a MACHINE_SAMPLING macro, use of exec should now be accessing global data.
-
- * VM/CTI.h:
- (JSC::CTI::execute):
- * VM/SamplingTool.h:
- (JSC::SamplingTool::privateExecuteReturned):
- * kjs/Shell.cpp:
-
-2008-10-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-10-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=21320
- leaks of PropertyNameArrayData seen on buildbot
-
- - Fix RefPtr cycle by making PropertyNameArrayData's pointer back
- to the StructureID a weak pointer.
-
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArrayData::setCachedStructureID):
- (JSC::PropertyNameArrayData::cachedStructureID):
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames):
- (JSC::StructureID::clearEnumerationCache):
- (JSC::StructureID::~StructureID):
-
-2008-10-04 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21295
- Bug 21295: Replace ExecState with a call frame Register pointer
-
- 10% faster on Richards; other v8 benchmarks faster too.
- A wash on SunSpider.
-
- This does the minimum necessary to get the speedup. Next step in
- cleaning this up is to replace ExecState with a CallFrame class,
- and be more judicious about when to pass a call frame and when
- to pass a global data pointer, global object pointer, or perhaps
- something else entirely.
-
- * VM/CTI.cpp: Remove the debug-only check of the exception in
- ctiVMThrowTrampoline -- already checked in the code the trampoline
- jumps to, so not all that useful. Removed the exec argument from
- ctiTrampoline. Removed emitDebugExceptionCheck -- no longer needed.
- (JSC::CTI::emitCall): Removed code to set ExecState::m_callFrame.
- (JSC::CTI::privateCompileMainPass): Removed code in catch to extract
- the exception from ExecState::m_exception; instead, the code that
- jumps into catch will make sure the exception is already in eax.
- * VM/CTI.h: Removed exec from the ctiTrampoline. Also removed the
- non-helpful "volatile". Temporarily left ARG_exec in as a synonym
- for ARG_r; I'll change that on a future cleanup pass when introducing
- more use of the CallFrame type.
- (JSC::CTI::execute): Removed the ExecState* argument.
-
- * VM/ExceptionHelpers.cpp:
- (JSC::InterruptedExecutionError::InterruptedExecutionError): Take
- JSGlobalData* instead of ExecState*.
- (JSC::createInterruptedExecutionException): Ditto.
- * VM/ExceptionHelpers.h: Ditto. Also removed an unneeded include.
-
- * VM/Machine.cpp:
- (JSC::slideRegisterWindowForCall): Removed the exec and
- exceptionValue arguments. Changed to return 0 when there's a stack
- overflow rather than using a separate exception argument to cut
- down on memory accesses in the calling convention.
- (JSC::Machine::unwindCallFrame): Removed the exec argument when
- constructing a DebuggerCallFrame. Also removed code to set
- ExecState::m_callFrame.
- (JSC::Machine::throwException): Removed the exec argument when
- construction a DebuggerCallFrame.
- (JSC::Machine::execute): Updated to use the register instead of
- ExecState and also removed various uses of ExecState.
- (JSC::Machine::debug):
- (JSC::Machine::privateExecute): Put globalData into a local
- variable so it can be used throughout the interpreter. Changed
- the VM_CHECK_EXCEPTION to get the exception in globalData instead
- of through ExecState.
- (JSC::Machine::retrieveLastCaller): Turn exec into a registers
- pointer by calling registers() instead of by getting m_callFrame.
- (JSC::Machine::callFrame): Ditto.
- Tweaked exception macros. Made new versions for when you know
- you have an exception. Get at global exception with ARG_globalData.
- Got rid of the need to pass in the return value type.
- (JSC::Machine::cti_op_add): Update to use new version of exception
- macros.
- (JSC::Machine::cti_op_pre_inc): Ditto.
- (JSC::Machine::cti_timeout_check): Ditto.
- (JSC::Machine::cti_op_instanceof): Ditto.
- (JSC::Machine::cti_op_new_func): Ditto.
- (JSC::Machine::cti_op_call_JSFunction): Optimized by using the
- ARG values directly instead of through local variables -- this gets
- rid of code that just shuffles things around in the stack frame.
- Also get rid of ExecState and update for the new way exceptions are
- handled in slideRegisterWindowForCall.
- (JSC::Machine::cti_vm_compile): Update to make exec out of r since
- they are both the same thing now.
- (JSC::Machine::cti_op_call_NotJSFunction): Ditto.
- (JSC::Machine::cti_op_init_arguments): Ditto.
- (JSC::Machine::cti_op_resolve): Ditto.
- (JSC::Machine::cti_op_construct_JSConstruct): Ditto.
- (JSC::Machine::cti_op_construct_NotJSConstruct): Ditto.
- (JSC::Machine::cti_op_resolve_func): Ditto.
- (JSC::Machine::cti_op_put_by_val): Ditto.
- (JSC::Machine::cti_op_put_by_val_array): Ditto.
- (JSC::Machine::cti_op_resolve_skip): Ditto.
- (JSC::Machine::cti_op_resolve_global): Ditto.
- (JSC::Machine::cti_op_post_inc): Ditto.
- (JSC::Machine::cti_op_resolve_with_base): Ditto.
- (JSC::Machine::cti_op_post_dec): Ditto.
- (JSC::Machine::cti_op_call_eval): Ditto.
- (JSC::Machine::cti_op_throw): Ditto. Also rearranged to return
- the exception value as the return value so it can be used by
- op_catch.
- (JSC::Machine::cti_op_push_scope): Ditto.
- (JSC::Machine::cti_op_in): Ditto.
- (JSC::Machine::cti_op_del_by_val): Ditto.
- (JSC::Machine::cti_vm_throw): Ditto. Also rearranged to return
- the exception value as the return value so it can be used by
- op_catch.
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::functionName): Pass globalData.
- (JSC::DebuggerCallFrame::evaluate): Eliminated code to make a
- new ExecState.
- * kjs/DebuggerCallFrame.h: Removed ExecState argument from
- constructor.
-
- * kjs/ExecState.h: Eliminated all data members and made ExecState
- inherit privately from Register instead. Also added a typedef to
- the future name for this class, which is CallFrame. It's just a
- Register* that knows it's a pointer at a call frame. The new class
- can't be constructed or copied. Changed all functions to use
- the this pointer instead of m_callFrame. Changed exception-related
- functions to access an exception in JSGlobalData. Removed functions
- used by CTI to pass the return address to the throw machinery --
- this is now done directly with a global in the global data.
-
- * kjs/FunctionPrototype.cpp:
- (JSC::functionProtoFuncToString): Pass globalData instead of exec.
-
- * kjs/InternalFunction.cpp:
- (JSC::InternalFunction::name): Take globalData instead of exec.
- * kjs/InternalFunction.h: Ditto.
-
- * kjs/JSGlobalData.cpp: Initialize the new exception global to 0.
- * kjs/JSGlobalData.h: Declare two new globals. One for the current
- exception and another for the return address used by CTI to
- implement the throw operation.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init): Removed code to set up globalExec,
- which is now the same thing as globalCallFrame.
- (JSC::JSGlobalObject::reset): Get globalExec from our globalExec
- function so we don't have to repeat the logic twice.
- (JSC::JSGlobalObject::mark): Removed code to mark the exception;
- the exception is now stored in JSGlobalData and marked there.
- (JSC::JSGlobalObject::globalExec): Return a pointer to the end
- of the global call frame.
- * kjs/JSGlobalObject.h: Removed the globalExec data member.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::putDirectFunction): Pass globalData instead of exec.
-
- * kjs/collector.cpp:
- (JSC::Heap::collect): Mark the global exception.
-
- * profiler/ProfileGenerator.cpp:
- (JSC::ProfileGenerator::addParentForConsoleStart): Pass globalData
- instead of exec to createCallIdentifier.
-
- * profiler/Profiler.cpp:
- (JSC::Profiler::willExecute): Pass globalData instead of exec to
- createCallIdentifier.
- (JSC::Profiler::didExecute): Ditto.
- (JSC::Profiler::createCallIdentifier): Take globalData instead of
- exec.
- (JSC::createCallIdentifierFromFunctionImp): Ditto.
- * profiler/Profiler.h: Change interface to take a JSGlobalData
- instead of an ExecState.
-
-2008-10-04 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 21369: Add opcode documentation for all undocumented opcodes
- <https://bugs.webkit.org/show_bug.cgi?id=21369>
-
- This patch adds opcode documentation for all undocumented opcodes, and
- it also renames op_init_arguments to op_create_arguments.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_create_arguments):
- * VM/Machine.h:
- * VM/Opcode.h:
-
-2008-10-03 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - "this" object in methods called on primitives should be wrapper object
- https://bugs.webkit.org/show_bug.cgi?id=21362
-
- I changed things so that functions which use "this" do a fast
- version of toThisObject conversion if needed. Currently we miss
- the conversion entirely, at least for primitive types. Using
- TypeInfo and the primitive check, I made the fast case bail out
- pretty fast.
-
- This is inexplicably an 1.007x SunSpider speedup (and a wash on V8 benchmarks).
-
- Also renamed some opcodes for clarity:
-
- init ==> enter
- init_activation ==> enter_with_activation
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate):
- (JSC::CodeGenerator::CodeGenerator):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_convert_this):
- * VM/Machine.h:
- * VM/Opcode.h:
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::JSActivation):
- * kjs/JSActivation.h:
- (JSC::JSActivation::createStructureID):
- * kjs/JSCell.h:
- (JSC::JSValue::needsThisConversion):
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * kjs/JSGlobalData.h:
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::createStructureID):
- * kjs/JSStaticScopeObject.h:
- (JSC::JSStaticScopeObject::JSStaticScopeObject):
- (JSC::JSStaticScopeObject::createStructureID):
- * kjs/JSString.h:
- (JSC::JSString::createStructureID):
- * kjs/JSValue.h:
- * kjs/TypeInfo.h:
- (JSC::TypeInfo::needsThisConversion):
- * kjs/nodes.h:
- (JSC::ScopeNode::usesThis):
-
-2008-10-03 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
- <https://bugs.webkit.org/show_bug.cgi?id=21356>
-
- The RegisterFile decreases in size (measured in terms of numbers of
- Registers) as the size of a Register increases. This causes
-
- js1_5/Regress/regress-159334.js
-
- to fail in 64-bit debug builds. This fix makes the RegisterFile on all
- platforms the same size that it is in 32-bit Release builds.
-
- * VM/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
-
-2008-10-03 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - Some code cleanup to how we handle code features.
-
- 1) Rename FeatureInfo typedef to CodeFeatures.
- 2) Rename NodeFeatureInfo template to NodeInfo.
- 3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
- 4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
- of ClosureFeature.
- 5) Make setUsersArguments() not take an argument since it only goes one way.
-
- * JavaScriptCore.exp:
- * VM/CodeBlock.h:
- (JSC::CodeBlock::CodeBlock):
- * kjs/NodeInfo.h:
- * kjs/Parser.cpp:
- (JSC::Parser::didFinishParsing):
- * kjs/Parser.h:
- (JSC::Parser::parse):
- * kjs/grammar.y:
- * kjs/nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
- (JSC::ProgramNode::ProgramNode):
- (JSC::ProgramNode::create):
- (JSC::EvalNode::EvalNode):
- (JSC::EvalNode::create):
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::create):
- * kjs/nodes.h:
- (JSC::ScopeNode::usesEval):
- (JSC::ScopeNode::containsClosures):
- (JSC::ScopeNode::usesArguments):
- (JSC::ScopeNode::setUsesArguments):
-
-2008-10-03 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
- <https://bugs.webkit.org/show_bug.cgi?id=21343>
-
- A fix was landed for this issue in r37253, and the ChangeLog assumes
- that it is a compiler bug, but it turns out that it is a subtle issue
- with mixing signed and unsigned 32-bit values in a 64-bit environment.
- In order to properly fix this bug, we should convert our signed offsets
- into the register file to use ptrdiff_t.
-
- This may not be the only instance of this issue, but I will land this
- fix first and look for more later.
-
- * VM/Machine.cpp:
- (JSC::Machine::getArgumentsData):
- * VM/Machine.h:
- * kjs/Arguments.cpp:
- (JSC::Arguments::getOwnPropertySlot):
- * kjs/Arguments.h:
- (JSC::Arguments::init):
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- * VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.
-
- * kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added
- declarations of JSGlobalData overloads of jsNumberCell.
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- - try to fix Windows build
-
- * kjs/ScopeChain.h: Add forward declaration of JSGlobalData.
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
- Turn ExecState into a call frame pointer.
-
- Remove m_globalObject and m_globalData from ExecState.
-
- SunSpider says this is a wash (slightly faster but not statistically
- significant); which is good enough since it's a preparation step and
- not supposed to be a spedup.
-
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::JSCallbackFunction):
- * kjs/ArrayConstructor.cpp:
- (JSC::ArrayConstructor::ArrayConstructor):
- * kjs/BooleanConstructor.cpp:
- (JSC::BooleanConstructor::BooleanConstructor):
- * kjs/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- * kjs/ErrorConstructor.cpp:
- (JSC::ErrorConstructor::ErrorConstructor):
- * kjs/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::FunctionPrototype):
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::JSFunction):
- * kjs/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- * kjs/NumberConstructor.cpp:
- (JSC::NumberConstructor::NumberConstructor):
- * kjs/ObjectConstructor.cpp:
- (JSC::ObjectConstructor::ObjectConstructor):
- * kjs/PrototypeFunction.cpp:
- (JSC::PrototypeFunction::PrototypeFunction):
- * kjs/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::RegExpConstructor):
- * kjs/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
- Pass JSGlobalData* instead of ExecState* to the InternalFunction
- constructor.
-
- * API/OpaqueJSString.cpp: Added now-needed include.
-
- * JavaScriptCore.exp: Updated.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData
- instead of ARGS_exec.
-
- * VM/CTI.h: Added a new argument to the CTI, the global data pointer.
- While it's possible to get to the global data pointer using the
- ExecState pointer, it's slow enough that it's better to just keep
- it around in the CTI arguments.
-
- * VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.
-
- * VM/Machine.cpp:
- (JSC::Machine::execute): Pass fewer arguments when constructing
- ExecState, and pass the global data pointer when invoking CTI.
- (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global
- object, which is in the scope chain of the first call frame.
- (JSC::Machine::cti_op_add): Use globalData instead of exec when
- possible, to keep fast cases fast, since it's now more expensive to
- get to it through the exec pointer.
- (JSC::Machine::cti_timeout_check): Ditto.
- (JSC::Machine::cti_op_put_by_id_second): Ditto.
- (JSC::Machine::cti_op_get_by_id_second): Ditto.
- (JSC::Machine::cti_op_mul): Ditto.
- (JSC::Machine::cti_vm_compile): Ditto.
- (JSC::Machine::cti_op_get_by_val): Ditto.
- (JSC::Machine::cti_op_sub): Ditto.
- (JSC::Machine::cti_op_put_by_val): Ditto.
- (JSC::Machine::cti_op_put_by_val_array): Ditto.
- (JSC::Machine::cti_op_negate): Ditto.
- (JSC::Machine::cti_op_div): Ditto.
- (JSC::Machine::cti_op_pre_dec): Ditto.
- (JSC::Machine::cti_op_post_inc): Ditto.
- (JSC::Machine::cti_op_lshift): Ditto.
- (JSC::Machine::cti_op_bitand): Ditto.
- (JSC::Machine::cti_op_rshift): Ditto.
- (JSC::Machine::cti_op_bitnot): Ditto.
- (JSC::Machine::cti_op_mod): Ditto.
- (JSC::Machine::cti_op_post_dec): Ditto.
- (JSC::Machine::cti_op_urshift): Ditto.
- (JSC::Machine::cti_op_bitxor): Ditto.
- (JSC::Machine::cti_op_bitor): Ditto.
- (JSC::Machine::cti_op_call_eval): Ditto.
- (JSC::Machine::cti_op_throw): Ditto.
- (JSC::Machine::cti_op_is_string): Ditto.
- (JSC::Machine::cti_op_debug): Ditto.
- (JSC::Machine::cti_vm_throw): Ditto.
-
- * VM/Machine.h: Added firstCallFrame.
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when
- constructing ExecState.
-
- * kjs/ExecState.cpp: Deleted contents. Later we'll remove the
- file altogether.
-
- * kjs/ExecState.h: Removed m_globalObject and m_globalData.
- Moved CodeType into another header.
- (JSC::ExecState::ExecState): Take only a single argument, a
- call frame pointer.
- (JSC::ExecState::dynamicGlobalObject): Get the object from
- the first call frame since it's no longer stored.
- (JSC::ExecState::globalData): Get the global data from the
- scope chain, since we no longer store a pointer to it here.
- (JSC::ExecState::identifierTable): Ditto.
- (JSC::ExecState::propertyNames): Ditto.
- (JSC::ExecState::emptyList): Ditto.
- (JSC::ExecState::lexer): Ditto.
- (JSC::ExecState::parser): Ditto.
- (JSC::ExecState::machine): Ditto.
- (JSC::ExecState::arrayTable): Ditto.
- (JSC::ExecState::dateTable): Ditto.
- (JSC::ExecState::mathTable): Ditto.
- (JSC::ExecState::numberTable): Ditto.
- (JSC::ExecState::regExpTable): Ditto.
- (JSC::ExecState::regExpConstructorTable): Ditto.
- (JSC::ExecState::stringTable): Ditto.
- (JSC::ExecState::heap): Ditto.
-
- * kjs/FunctionConstructor.cpp:
- (JSC::FunctionConstructor::FunctionConstructor): Pass
- JSGlobalData* instead of ExecState* to the InternalFunction
- constructor.
- (JSC::constructFunction): Pass the global data pointer when
- constructing a new scope chain.
-
- * kjs/InternalFunction.cpp:
- (JSC::InternalFunction::InternalFunction): Take a JSGlobalData*
- instead of an ExecState*. Later we can change more places to
- work this way -- it's more efficient to take the type you need
- since the caller might already have it.
- * kjs/InternalFunction.h: Ditto.
-
- * kjs/JSCell.h:
- (JSC::JSCell::operator new): Added an overload that takes a
- JSGlobalData* so you can construct without an ExecState*.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init): Moved creation of the global scope
- chain in here, since it now requires a pointer to the global data.
- Moved the initialization of the call frame in here since it requires
- the global scope chain node. Removed the extra argument to ExecState
- when creating the global ExecState*.
- * kjs/JSGlobalObject.h: Removed initialization of globalScopeChain
- and the call frame from the JSGlobalObjectData constructor. Added
- a thisValue argument to the init function.
-
- * kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take
- JSGlobalData* rather than ExecState*.
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::operator new): Added a version that takes
- JSGlobalData*.
- (JSC::JSNumberCell::JSNumberCell): Ditto.
- (JSC::jsNumber): Ditto.
- * kjs/JSString.cpp:
- (JSC::jsString): Ditto.
- (JSC::jsSubstring): Ditto.
- (JSC::jsOwnedString): Ditto.
- * kjs/JSString.h:
- (JSC::JSString::JSString): Changed to take JSGlobalData*.
- (JSC::jsEmptyString): Added a version that takes JSGlobalData*.
- (JSC::jsSingleCharacterString): Ditto.
- (JSC::jsSingleCharacterSubstring): Ditto.
- (JSC::jsNontrivialString): Ditto.
- (JSC::JSString::getIndex): Ditto.
- (JSC::jsString): Ditto.
- (JSC::jsSubstring): Ditto.
- (JSC::jsOwnedString): Ditto.
-
- * kjs/ScopeChain.h: Added a globalData pointer to each node.
- (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData
- pointer.
- (JSC::ScopeChainNode::push): Set the global data pointer in the
- new node.
- (JSC::ScopeChain::ScopeChain): Take a globalData argument.
-
- * kjs/SmallStrings.cpp:
- (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of
- ExecState*.
- (JSC::SmallStrings::createSingleCharacterString): Ditto.
- * kjs/SmallStrings.h:
- (JSC::SmallStrings::emptyString): Ditto.
- (JSC::SmallStrings::singleCharacterString): Ditto.
-
-2008-10-03 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
- <https://bugs.webkit.org/show_bug.cgi?id=21343>
-
- Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
- llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
- on SunSpider in 32-bit, although that might be entirely random.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::getOwnPropertySlot):
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- Rubber stamped by Alexey Proskuryakov.
-
- * kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change
- this tool to use public JavaScriptCore API instead.
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- Suggested by Alexey Proskuryakov.
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because
- it's too late to ref the JSGlobalData object once it's already being
- destroyed. In practice this is not a problem because WebCore's JSGlobalData
- is never destroyed and JSGlobalContextRelease takes care of calling
- heap.destroy() in advance.
-
-2008-10-02 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.
-
- 5.6% win on SunSpider on windows.
-
- * VM/CTI.cpp:
- (JSC::isSSE2Present):
- (JSC::CTI::compileBinaryArithOp):
- (JSC::CTI::compileBinaryArithOpSlowCase):
-
-2008-10-03 Maciej Stachowiak <mjs@apple.com>
-
- Rubber stamped by Cameron Zwarich.
-
- - fix mistaken change of | to || which caused a big perf regression on EarleyBoyer
-
- * kjs/grammar.y:
-
-2008-10-02 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21321
- Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
-
- 1.019x as fast on SunSpider.
-
- * API/JSBase.cpp:
- (JSEvaluateScript): Use heap. instead of heap-> to work with the heap.
- (JSCheckScriptSyntax): Ditto.
- (JSGarbageCollect): Ditto.
- (JSReportExtraMemoryCost): Ditto.
- * API/JSContextRef.cpp:
- (JSGlobalContextRetain): Ditto.
- (JSGlobalContextRelease): Destroy the heap with the destroy function instead
- of the delete operator.
- (JSContextGetGlobalObject): Use heap. instead of heap-> to work with the heap.
- * API/JSObjectRef.cpp:
- (JSObjectMake): Use heap. instead of heap-> to work with the heap.
- (JSObjectMakeFunctionWithCallback): Ditto.
- (JSObjectMakeConstructor): Ditto.
- (JSObjectMakeFunction): Ditto.
- (JSObjectMakeArray): Ditto.
- (JSObjectMakeDate): Ditto.
- (JSObjectMakeError): Ditto.
- (JSObjectMakeRegExp): Ditto.
- (JSObjectHasProperty): Ditto.
- (JSObjectGetProperty): Ditto.
- (JSObjectSetProperty): Ditto.
- (JSObjectGetPropertyAtIndex): Ditto.
- (JSObjectSetPropertyAtIndex): Ditto.
- (JSObjectDeleteProperty): Ditto.
- (JSObjectCallAsFunction): Ditto.
- (JSObjectCallAsConstructor): Ditto.
- (JSObjectCopyPropertyNames): Ditto.
- (JSPropertyNameAccumulatorAddName): Ditto.
- * API/JSValueRef.cpp:
- (JSValueIsEqual): Ditto.
- (JSValueIsInstanceOfConstructor): Ditto.
- (JSValueMakeNumber): Ditto.
- (JSValueMakeString): Ditto.
- (JSValueToNumber): Ditto.
- (JSValueToStringCopy): Ditto.
- (JSValueToObject): Ditto.
- (JSValueProtect): Ditto.
- (JSValueUnprotect): Ditto.
-
- * kjs/ExecState.h:
- (JSC::ExecState::heap): Update to use the & operator.
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Update to initialize a heap member
- instead of calling new to make a heap.
- (JSC::JSGlobalData::~JSGlobalData): Destroy the heap with the destroy
- function instead of the delete operator.
- * kjs/JSGlobalData.h: Change from Heap* to a Heap.
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::mark): Use the & operator here.
- (JSC::JSGlobalObject::operator new): Use heap. instead of heap-> to work
- with the heap.
-
-2008-10-02 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21317: Replace RegisterFile size and capacity information with Register pointers
- <https://bugs.webkit.org/show_bug.cgi?id=21317>
-
- This is a 2.3% speedup on the V8 DeltaBlue benchmark, a 3.3% speedup on
- the V8 Raytrace benchmark, and a 1.0% speedup on SunSpider.
-
- * VM/Machine.cpp:
- (JSC::slideRegisterWindowForCall):
- (JSC::Machine::callEval):
- (JSC::Machine::execute):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/RegisterFile.cpp:
- (JSC::RegisterFile::~RegisterFile):
- * VM/RegisterFile.h:
- (JSC::RegisterFile::RegisterFile):
- (JSC::RegisterFile::start):
- (JSC::RegisterFile::end):
- (JSC::RegisterFile::size):
- (JSC::RegisterFile::shrink):
- (JSC::RegisterFile::grow):
- (JSC::RegisterFile::lastGlobal):
- (JSC::RegisterFile::markGlobals):
- (JSC::RegisterFile::markCallFrames):
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::copyGlobalsTo):
-
-2008-10-02 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Darin Adler.
-
- Change bitwise operations introduced in r37166 to boolean operations. We
- only use bitwise operations over boolean operations for increasing
- performance in extremely hot code, but that does not apply to anything
- in the parser.
-
- * kjs/grammar.y:
-
-2008-10-02 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for bug #21232 - should reset m_isPendingDash on flush,
- and should allow '\-' as beginning or end of a range (though
- not to specifiy a range itself).
-
- * ChangeLog:
- * wrec/CharacterClassConstructor.cpp:
- (JSC::CharacterClassConstructor::put):
- (JSC::CharacterClassConstructor::flush):
- * wrec/CharacterClassConstructor.h:
- (JSC::CharacterClassConstructor::flushBeforeEscapedHyphen):
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generateDisjunction):
- (JSC::WRECParser::parseCharacterClass):
- (JSC::WRECParser::parseDisjunction):
- * wrec/WREC.h:
-
-2008-10-02 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - remove the "static" from declarations in a header file, since we
- don't want them to have internal linkage
-
- * VM/Machine.h: Remove the static keyword from the constant and the
- three inline functions that Geoff just moved here.
-
-2008-10-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21283.
- Profiler Crashes When Started
-
- * VM/Machine.cpp:
- * VM/Machine.h:
- (JSC::makeHostCallFramePointer):
- (JSC::isHostCallFrame):
- (JSC::stripHostCallFrameBit): Moved some things to the header so
- JSGlobalObject could use them.
-
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Call the
- new makeHostCallFramePointer API, since 0 no longer indicates a host
- call frame.
-
-2008-10-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21304
- Stop using a static wrapper map for WebCore JS bindings
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- (JSC::JSGlobalData::~JSGlobalData):
- (JSC::JSGlobalData::ClientData::~ClientData):
- * kjs/JSGlobalData.h:
- Added a client data member to JSGlobalData. WebCore will use it to store bindings-related
- global data.
-
- * JavaScriptCore.exp: Export virtual ClientData destructor.
-
-2008-10-02 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * kjs/Error.h:
-
-2008-10-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler and Cameron Zwarich.
-
- Preliminary step toward dynamic recompilation: Standardized and
- simplified the parsing interface.
-
- The main goal in this patch is to make it easy to ask for a duplicate
- compilation, and get back a duplicate result -- same source URL, same
- debugger / profiler ID, same toString behavior, etc.
-
- The basic unit of compilation and evaluation is now SourceCode, which
- encompasses a SourceProvider, a range in that provider, and a starting
- line number.
-
- A SourceProvider now encompasses a source URL, and *is* a source ID,
- since a pointer is a unique identifier.
-
- * API/JSBase.cpp:
- (JSEvaluateScript):
- (JSCheckScriptSyntax): Provide a SourceCode to the Interpreter, since
- other APIs are no longer supported.
-
- * VM/CodeBlock.h:
- (JSC::EvalCodeCache::get): Provide a SourceCode to the Interpreter, since
- other APIs are no longer supported.
- (JSC::CodeBlock::CodeBlock): ASSERT something that used to be ASSERTed
- by our caller -- this is a better bottleneck.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator): Updated for the fact that
- FunctionBodyNode's parameters are no longer a WTF::Vector.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::Arguments): ditto
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate): Provide a SourceCode to the Parser,
- since other APIs are no longer supported.
-
- * kjs/FunctionConstructor.cpp:
- (JSC::constructFunction): Provide a SourceCode to the Parser, since
- other APIs are no longer supported. Adopt FunctionBodyNode's new
- "finishParsing" API.
-
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::lengthGetter):
- (JSC::JSFunction::getParameterName): Updated for the fact that
- FunctionBodyNode's parameters are no longer a wtf::Vector.
-
- * kjs/JSFunction.h: Nixed some cruft.
-
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncEval): Provide a SourceCode to the Parser, since
- other APIs are no longer supported.
-
- * kjs/Parser.cpp:
- (JSC::Parser::parse): Require a SourceCode argument, instead of a bunch
- of broken out parameters. Stop tracking sourceId as an integer, since we
- use the SourceProvider pointer for this now. Don't clamp the
- startingLineNumber, since SourceCode does that now.
-
- * kjs/Parser.h:
- (JSC::Parser::parse): Standardized the parsing interface to require a
- SourceCode.
-
- * kjs/Shell.cpp:
- (functionRun):
- (functionLoad):
- (prettyPrintScript):
- (runWithScripts):
- (runInteractive): Provide a SourceCode to the Interpreter, since
- other APIs are no longer supported.
-
- * kjs/SourceProvider.h:
- (JSC::SourceProvider::SourceProvider):
- (JSC::SourceProvider::url):
- (JSC::SourceProvider::asId):
- (JSC::UStringSourceProvider::create):
- (JSC::UStringSourceProvider::UStringSourceProvider): Added new
- responsibilities described above.
-
- * kjs/SourceRange.h:
- (JSC::SourceCode::SourceCode):
- (JSC::SourceCode::toString):
- (JSC::SourceCode::provider):
- (JSC::SourceCode::firstLine):
- (JSC::SourceCode::data):
- (JSC::SourceCode::length): Added new responsibilities described above.
- Renamed SourceRange to SourceCode, based on review feedback. Added
- a makeSource function for convenience.
-
- * kjs/debugger.h: Provide a SourceCode to the client, since other APIs
- are no longer supported.
-
- * kjs/grammar.y: Provide startingLineNumber when creating a SourceCode.
-
- * kjs/debugger.h: Treat sourceId as intptr_t to avoid loss of precision
- on 64bit platforms.
-
- * kjs/interpreter.cpp:
- (JSC::Interpreter::checkSyntax):
- (JSC::Interpreter::evaluate):
- * kjs/interpreter.h: Require a SourceCode instead of broken out arguments.
-
- * kjs/lexer.cpp:
- (JSC::Lexer::setCode):
- * kjs/lexer.h:
- (JSC::Lexer::sourceRange): Fold together the SourceProvider and line number
- into a SourceCode. Fixed a bug where the Lexer would accidentally keep
- alive the last SourceProvider forever.
-
- * kjs/nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
- (JSC::ProgramNode::ProgramNode):
- (JSC::ProgramNode::create):
- (JSC::EvalNode::EvalNode):
- (JSC::EvalNode::generateCode):
- (JSC::EvalNode::create):
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::finishParsing):
- (JSC::FunctionBodyNode::create):
- (JSC::FunctionBodyNode::generateCode):
- (JSC::ProgramNode::generateCode):
- (JSC::FunctionBodyNode::paramString):
- * kjs/nodes.h:
- (JSC::ScopeNode::):
- (JSC::ScopeNode::sourceId):
- (JSC::FunctionBodyNode::):
- (JSC::FunctionBodyNode::parameterCount):
- (JSC::FuncExprNode::):
- (JSC::FuncDeclNode::): Store a SourceCode in all ScopeNodes, since
- SourceCode is now responsible for tracking URL, ID, etc. Streamlined
- some ad hoc FunctionBodyNode fixups into a "finishParsing" function, to
- help make clear what you need to do in order to finish parsing a
- FunctionBodyNode.
-
- * wtf/Vector.h:
- (WTF::::releaseBuffer): Don't ASSERT that releaseBuffer() is only called
- when buffer is not 0, since FunctionBodyNode is more than happy
- to get back a 0 buffer, and other functions like RefPtr::release() allow
- for 0, too.
-
-2008-10-01 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21289: REGRESSION (r37160): Inspector crashes on load
- <https://bugs.webkit.org/show_bug.cgi?id=21289>
-
- The code in Arguments::mark() in r37160 was wrong. It marks indices in
- d->registers, but that makes no sense (they are local variables, not
- arguments). It should mark those indices in d->registerArray instead.
-
- This patch also changes Arguments::copyRegisters() to use d->numParameters
- instead of recomputing it.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::mark):
- * kjs/Arguments.h:
- (JSC::Arguments::copyRegisters):
-
-2008-09-30 Darin Adler <darin@apple.com>
-
- Reviewed by Eric Seidel.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21214
- work on getting rid of ExecState
-
- Eliminate some unneeded uses of dynamicGlobalObject.
-
- * API/JSClassRef.cpp:
- (OpaqueJSClass::contextData): Changed to use a map in the global data instead
- of on the global object. Also fixed to use only a single hash table lookup.
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeConstructor): Use lexicalGlobalObject rather than dynamicGlobalObject
- to get the object prototype.
-
- * kjs/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncToString): Use arrayVisitedElements set in global data rather
- than in the global object.
- (JSC::arrayProtoFuncToLocaleString): Ditto.
- (JSC::arrayProtoFuncJoin): Ditto.
-
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData): Don't initialize opaqueJSClassData, since
- it's no longer a pointer.
- (JSC::JSGlobalData::~JSGlobalData): We still need to delete all the values, but
- we don't need to delete the map since it's no longer a pointer.
-
- * kjs/JSGlobalData.h: Made opaqueJSClassData a map instead of a pointer to a map.
- Also added arrayVisitedElements.
-
- * kjs/JSGlobalObject.h: Removed arrayVisitedElements.
-
- * kjs/Shell.cpp:
- (functionRun): Use lexicalGlobalObject instead of dynamicGlobalObject.
- (functionLoad): Ditto.
-
-2008-10-01 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Speculative Windows build fix.
-
- * kjs/grammar.y:
-
-2008-10-01 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 21123: using "arguments" in a function should not force creation of an activation object
- <https://bugs.webkit.org/show_bug.cgi?id=21123>
-
- Make the 'arguments' object not require a JSActivation. We store the
- 'arguments' object in the OptionalCalleeArguments call frame slot. We
- need to be able to get the original 'arguments' object to tear it off
- when returning from a function, but 'arguments' may be assigned to in a
- number of ways.
-
- Therefore, we use the OptionalCalleeArguments slot when we want to get
- the original activation or we know that 'arguments' was not assigned a
- different value. When 'arguments' may have been assigned a new value,
- we use a new local variable that is initialized with 'arguments'. Since
- a function parameter named 'arguments' may overwrite the value of
- 'arguments', we also need to be careful to look up 'arguments' in the
- symbol table, so we get the parameter named 'arguments' instead of the
- local variable that we have added for holding the 'arguments' object.
-
- This is a 19.1% win on the V8 Raytrace benchmark using the SunSpider
- harness, and a 20.7% win using the V8 harness. This amounts to a 6.5%
- total speedup on the V8 benchmark suite using the V8 harness.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- * VM/Machine.cpp:
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::privateExecute):
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::cti_op_init_arguments):
- (JSC::Machine::cti_op_ret_activation_arguments):
- * VM/Machine.h:
- * VM/RegisterFile.h:
- (JSC::RegisterFile::):
- * kjs/Arguments.cpp:
- (JSC::Arguments::mark):
- (JSC::Arguments::fillArgList):
- (JSC::Arguments::getOwnPropertySlot):
- (JSC::Arguments::put):
- * kjs/Arguments.h:
- (JSC::Arguments::setRegisters):
- (JSC::Arguments::init):
- (JSC::Arguments::Arguments):
- (JSC::Arguments::copyRegisters):
- (JSC::JSActivation::copyRegisters):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::argumentsGetter):
- * kjs/JSActivation.h:
- (JSC::JSActivation::JSActivationData::JSActivationData):
- * kjs/grammar.y:
- * kjs/nodes.h:
- (JSC::ScopeNode::setUsesArguments):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::orl_mr):
-
-2008-10-01 Kevin McCullough <kmccullough@apple.com>
-
- Rubberstamped by Geoff Garen.
-
- Remove BreakpointCheckStatement because it's not used anymore.
- No effect on sunspider or the jsc tests.
-
- * kjs/nodes.cpp:
- * kjs/nodes.h:
-
-2008-09-30 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Improve performance of CTI on windows.
-
- Currently on platforms where the compiler doesn't allow us to safely
- index relative to the address of a parameter we need to actually
- provide a pointer to CTI runtime call arguments. This patch improves
- performance in this case by making the CTI logic for restoring this
- parameter much less conservative by only resetting it before we actually
- make a call, rather than between each and every SF bytecode we generate
- code for.
-
- This results in a 3.6% progression on the v8 benchmark when compiled with MSVC.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCall):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompilePutByIdTransition):
- * VM/CTI.h:
- * masm/X86Assembler.h:
- * wtf/Platform.h:
-
-2008-09-30 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - track uses of "this", "with" and "catch" in the parser
-
- Knowing this up front will be useful for future optimizations.
-
- Perf and correctness remain the same.
-
- * kjs/NodeInfo.h:
- * kjs/grammar.y:
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ * jit/JITStubs.h:
-2008-09-30 Sam Weinig <sam@webkit.org>
+2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
- Add WebKitAvailability macros for JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError,
- and JSObjectMakeRegExp
-
- * API/JSObjectRef.h:
-
-2008-09-30 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21214
- work on getting rid of ExecState
-
- Replaced the m_prev field of ExecState with a bit in the
- call frame pointer to indicate "host" call frames.
-
- * VM/Machine.cpp:
- (JSC::makeHostCallFramePointer): Added. Sets low bit.
- (JSC::isHostCallFrame): Added. Checks low bit.
- (JSC::stripHostCallFrameBit): Added. Clears low bit.
- (JSC::Machine::unwindCallFrame): Replaced null check that was
- formerly used to detect host call frames with an isHostCallFrame check.
- (JSC::Machine::execute): Pass in a host call frame pointer rather than
- always passing 0 when starting execution from the host. This allows us
- to follow the entire call frame pointer chain when desired, or to stop
- at the host calls when that's desired.
- (JSC::Machine::privateExecute): Replaced null check that was
- formerly used to detect host call frames with an isHostCallFrame check.
- (JSC::Machine::retrieveCaller): Ditto.
- (JSC::Machine::retrieveLastCaller): Ditto.
- (JSC::Machine::callFrame): Removed the code to walk up m_prev pointers
- and replaced it with code that uses the caller pointer and uses the
- stripHostCallFrameBit function.
-
- * kjs/ExecState.cpp: Removed m_prev.
- * kjs/ExecState.h: Ditto.
-
-2008-09-30 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Move all detection of 'arguments' in a lexical scope to the parser, in
- preparation for fixing
-
- Bug 21123: using "arguments" in a function should not force creation of an activation object
- <https://bugs.webkit.org/show_bug.cgi?id=21123>
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- * kjs/NodeInfo.h:
- * kjs/grammar.y:
-
-2008-09-30 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- * kjs/Shell.cpp:
- (runWithScripts): Fixed indentation.
-
-2008-09-30 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Build fix. Move InternalFunction::classInfo implementation into the .cpp
- file to prevent the vtable for InternalFunction being generated as a weak symbol.
- Has no effect on SunSpider.
-
- * kjs/InternalFunction.cpp:
- (JSC::InternalFunction::classInfo):
- * kjs/InternalFunction.h:
-
-2008-09-29 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Darin Adler.
-
- - optimize appending a number to a string
- https://bugs.webkit.org/show_bug.cgi?id=21203
-
- It's pretty common in real-world code (and on some of the v8
- benchmarks) to append a number to a string, so I made this one of
- the fast cases, and also added support to UString to do it
- directly without allocating a temporary UString.
-
- ~1% speedup on v8 benchmark.
-
- * VM/Machine.cpp:
- (JSC::jsAddSlowCase): Make this NEVER_INLINE because somehow otherwise
- the change is a regression.
- (JSC::jsAdd): Handle number + string special case.
- (JSC::Machine::cti_op_add): Integrate much of the logic of jsAdd to
- avoid exception check in the str + str, num + num and str + num cases.
- * kjs/ustring.cpp:
- (JSC::expandedSize): Make this a non-member function, since it needs to be
- called in non-member functions but not outside this file.
- (JSC::expandCapacity): Ditto.
- (JSC::UString::expandCapacity): Call the non-member version.
- (JSC::createRep): Helper to make a rep from a char*.
- (JSC::UString::UString): Use above helper.
- (JSC::concatenate): Guts of concatenating constructor for cases where first
- item is a UString::Rep, and second is a UChar* and length, or a char*.
- (JSC::UString::append): Implement for cases where first item is a UString::Rep,
- and second is an int or double. Sadly duplicates logic of UString::from(int)
- and UString::from(double).
- * kjs/ustring.h:
-
-2008-09-29 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21214
- work on getting rid of ExecState
-
- * JavaScriptCore.exp: Updated since JSGlobalObject::init
- no longer takes a parameter.
-
- * VM/Machine.cpp:
- (JSC::Machine::execute): Removed m_registerFile argument
- for ExecState constructors.
-
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue
- argument for ExecState constructor.
-
- * kjs/ExecState.cpp:
- (JSC::ExecState::ExecState): Removed globalThisValue and
- registerFile arguments to constructors.
-
- * kjs/ExecState.h: Removed m_globalThisValue and
- m_registerFile data members.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init): Removed globalThisValue
- argument for ExecState constructor.
-
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter
- for the init function.
-
-2008-09-29 Geoffrey Garen <ggaren@apple.com>
-
- Rubber-stamped by Cameron Zwarich.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21225
- Machine::retrieveLastCaller should check for a NULL codeBlock
-
- In order to crash, you would need to call retrieveCaller in a situation
- where you had two host call frames in a row in the register file. I
- don't know how to make that happen, or if it's even possible, so I don't
- have a test case -- but better safe than sorry!
-
- * VM/Machine.cpp:
- (JSC::Machine::retrieveLastCaller):
-
-2008-09-29 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Store the callee ScopeChain, not the caller ScopeChain, in the call frame
- header. Nix the "scopeChain" local variable and ExecState::m_scopeChain, and
- access the callee ScopeChain through the call frame header instead.
-
- Profit: call + return are simpler, because they don't have to update the
- "scopeChain" local variable, or ExecState::m_scopeChain.
-
- Because CTI keeps "r" in a register, reading the callee ScopeChain relative
- to "r" can be very fast, in any cases we care to optimize.
-
- 0% speedup on empty function call benchmark. (5.5% speedup in bytecode.)
- 0% speedup on SunSpider. (7.5% speedup on controlflow-recursive.)
- 2% speedup on SunSpider --v8.
- 2% speedup on v8 benchmark.
-
- * VM/CTI.cpp: Changed scope chain access to read the scope chain from
- the call frame header. Sped up op_ret by changing it not to fuss with
- the "scopeChain" local variable or ExecState::m_scopeChain.
-
- * VM/CTI.h: Updated CTI trampolines not to take a ScopeChainNode*
- argument, since that's stored in the call frame header now.
-
- * VM/Machine.cpp: Access "scopeChain" and "codeBlock" through new helper
- functions that read from the call frame header. Updated functions operating
- on ExecState::m_callFrame to account for / take advantage of the fact that
- Exec:m_callFrame is now never NULL.
-
- Fixed a bug in op_construct, where it would use the caller's default
- object prototype, rather than the callee's, when constructing a new object.
-
- * VM/Machine.h: Made some helper functions available. Removed
- ScopeChainNode* arguments to a lot of functions, since the ScopeChainNode*
- is now stored in the call frame header.
-
- * VM/RegisterFile.h: Renamed "CallerScopeChain" to "ScopeChain", since
- that's what it is now.
-
- * kjs/DebuggerCallFrame.cpp: Updated for change to ExecState signature.
-
- * kjs/ExecState.cpp:
- * kjs/ExecState.h: Nixed ExecState::m_callFrame, along with the unused
- isGlobalObject function.
-
- * kjs/JSGlobalObject.cpp:
- * kjs/JSGlobalObject.h: Gave the global object a fake call frame in
- which to store the global scope chain, since our code now assumes that
- it can always read the scope chain out of the ExecState's call frame.
-
-2008-09-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Sam Weinig.
-
- Remove the isActivationObject() virtual method on JSObject and use
- StructureID information instead. This should be slightly faster, but
- isActivationObject() is only used in assertions and unwinding the stack
- for exceptions.
-
- * VM/Machine.cpp:
- (JSC::depth):
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_ret_activation):
- * kjs/JSActivation.cpp:
- * kjs/JSActivation.h:
- * kjs/JSObject.h:
-
-2008-09-29 Peter Gal <galpeter@inf.u-szeged.hu>
-
- Reviewed and tweaked by Darin Adler.
-
- Fix build for non-all-in-one platforms.
-
- * kjs/StringPrototype.cpp: Added missing ASCIICType.h include.
-
-2008-09-29 Bradley T. Hughes <bradley.hughes@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix compilation with icpc
-
- * wtf/HashSet.h:
- (WTF::::find):
- (WTF::::contains):
-
-2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Changed copyright from Trolltech ASA to Nokia.
-
- Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
-
-
- * wtf/qt/MainThreadQt.cpp:
-
-2008-09-29 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Lars Knoll.
-
- Don't accidentially install libJavaScriptCore.a for the build inside
- Qt.
-
- * JavaScriptCore.pro:
-
-2008-09-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21200: Allow direct access to 'arguments' without using op_resolve
- <https://bugs.webkit.org/show_bug.cgi?id=21200>
-
- Allow fast access to the 'arguments' object by adding an extra slot to
- the callframe to store it.
-
- This is a 3.0% speedup on the V8 Raytrace benchmark.
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::registerFor):
- * VM/CodeGenerator.h:
- (JSC::CodeGenerator::registerFor):
- * VM/Machine.cpp:
- (JSC::Machine::initializeCallFrame):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::privateExecute):
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_create_arguments):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/Machine.h:
- * VM/Opcode.h:
- * VM/RegisterFile.h:
- (JSC::RegisterFile::):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::mark):
- (JSC::JSActivation::argumentsGetter):
- * kjs/JSActivation.h:
- (JSC::JSActivation::JSActivationData::JSActivationData):
- * kjs/NodeInfo.h:
- * kjs/Parser.cpp:
- (JSC::Parser::didFinishParsing):
- * kjs/Parser.h:
- (JSC::Parser::parse):
- * kjs/grammar.y:
- * kjs/nodes.cpp:
- (JSC::ScopeNode::ScopeNode):
- (JSC::ProgramNode::ProgramNode):
- (JSC::ProgramNode::create):
- (JSC::EvalNode::EvalNode):
- (JSC::EvalNode::create):
- (JSC::FunctionBodyNode::FunctionBodyNode):
- (JSC::FunctionBodyNode::create):
- * kjs/nodes.h:
- (JSC::ScopeNode::usesArguments):
-
-2008-09-28 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add an ASCII fast-path to toLowerCase and toUpperCase.
-
- The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
- to the less common non-ASCII case.
-
- This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
- to the non-locale variants of the functions. toLocaleLowerCase and toLocaleUpperCase now use the non-locale
- variants of the functions directly.
-
- * kjs/StringPrototype.cpp:
- (JSC::stringProtoFuncToLowerCase):
- (JSC::stringProtoFuncToUpperCase):
-
-2008-09-28 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Speed up parseInt and parseFloat.
-
- Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
- and use that instead. This is a 7% win on a parseInt/parseFloat micro-benchmark.
-
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::parseInt):
- (JSC::parseFloat):
-
-2008-09-28 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by David Hyatt.
-
- In Qt's initializeThreading re-use an existing thread identifier for the main
- thread if it exists.
-
- currentThread() implicitly creates new identifiers and it could be that
- it is called before initializeThreading().
-
- * wtf/ThreadingQt.cpp:
- (WTF::initializeThreading):
-
-2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
-
- Added Machine::retrieveCaller to the export list.
-
- Reviewed by Kevin McCullough and Tim Hatcher.
-
- * JavaScriptCore.exp: Added Machine::retrieveCaller.
-
-2008-09-27 Anders Carlsson <andersca@apple.com>
-
- Fix build.
-
- * VM/CTI.cpp:
- (JSC::):
-
-2008-09-27 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- https://bugs.webkit.org/show_bug.cgi?id=21175
-
- Store the callee CodeBlock, not the caller CodeBlock, in the call frame
- header. Nix the "codeBlock" local variable, and access the callee
- CodeBlock through the call frame header instead.
-
- Profit: call + return are simpler, because they don't have to update the
- "codeBlock" local variable.
-
- Because CTI keeps "r" in a register, reading the callee CodeBlock relative
- to "r" can be very fast, in any cases we care to optimize. Presently,
- no such cases seem important.
-
- Also, stop writing "dst" to the call frame header. CTI doesn't use it.
-
- 21.6% speedup on empty function call benchmark.
- 3.8% speedup on SunSpider --v8.
- 2.1% speedup on v8 benchmark.
- 0.7% speedup on SunSpider (6% speedup on controlflow-recursive).
-
- Small regression in bytecode, because currently every op_ret reads the
- callee CodeBlock to check needsFullScopeChain, and bytecode does not
- keep "r" in a register. On-balance, this is probably OK, since CTI is
- our high-performance execution model. Also, this should go away once
- we make needsFullScopeChain statically determinable at parse time.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall): The speedup!
- (JSC::CTI::privateCompileSlowCases): ditto
-
- * VM/CTI.h:
- (JSC::): Fixed up magic trampoline constants to account for the nixed
- "codeBlock" argument.
- (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock"
- argument, since codeBlock is now stored in the call frame header.
-
- * VM/Machine.cpp: Read the callee CodeBlock from the register file. Use
- a NULL CallerRegisters in the call frame header to signal a built-in
- caller, since CodeBlock is now never NULL.
-
- * VM/Machine.h: Made some stand-alone functions Machine member functions
- so they could call the private codeBlock() accessor in the Register
- class, of which Machine is a friend. Renamed "CallerCodeBlock" to
- "CodeBlock", since it's no longer the caller's CodeBlock.
-
- * VM/RegisterFile.h: Marked some methods const to accommodate a
- const RegisterFile* being passed around in Machine.cpp.
-
-2008-09-26 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix. Not reviewed.
-
- Narrow-down the target of the JavaScriptCore .lut.h generator so
- it won't try to create the WebCore .lut.hs.
-
- * GNUmakefile.am:
-
-2008-09-26 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Tim Hatcher.
-
- Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
-
- * Configurations/JavaScriptCore.xcconfig:
-
-2008-09-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Anders Carlson.
-
- Change the name 'sc' to 'scopeChainNode' in a few places.
-
- * kjs/nodes.cpp:
- (JSC::EvalNode::generateCode):
- (JSC::FunctionBodyNode::generateCode):
- (JSC::ProgramNode::generateCode):
-
-2008-09-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
- Speedup static property get/put
-
- Convert getting/setting static property values to use static functions
- instead of storing an integer and switching in getValueProperty/putValueProperty.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::deleteProperty):
- (JSC::JSObject::getPropertyAttributes):
- * kjs/MathObject.cpp:
- (JSC::MathObject::getOwnPropertySlot):
- * kjs/NumberConstructor.cpp:
- (JSC::numberConstructorNaNValue):
- (JSC::numberConstructorNegInfinity):
- (JSC::numberConstructorPosInfinity):
- (JSC::numberConstructorMaxValue):
- (JSC::numberConstructorMinValue):
- * kjs/PropertySlot.h:
- (JSC::PropertySlot::):
- * kjs/RegExpConstructor.cpp:
- (JSC::regExpConstructorDollar1):
- (JSC::regExpConstructorDollar2):
- (JSC::regExpConstructorDollar3):
- (JSC::regExpConstructorDollar4):
- (JSC::regExpConstructorDollar5):
- (JSC::regExpConstructorDollar6):
- (JSC::regExpConstructorDollar7):
- (JSC::regExpConstructorDollar8):
- (JSC::regExpConstructorDollar9):
- (JSC::regExpConstructorInput):
- (JSC::regExpConstructorMultiline):
- (JSC::regExpConstructorLastMatch):
- (JSC::regExpConstructorLastParen):
- (JSC::regExpConstructorLeftContext):
- (JSC::regExpConstructorRightContext):
- (JSC::setRegExpConstructorInput):
- (JSC::setRegExpConstructorMultiline):
- (JSC::RegExpConstructor::setInput):
- (JSC::RegExpConstructor::setMultiline):
- (JSC::RegExpConstructor::multiline):
- * kjs/RegExpConstructor.h:
- * kjs/RegExpObject.cpp:
- (JSC::regExpObjectGlobal):
- (JSC::regExpObjectIgnoreCase):
- (JSC::regExpObjectMultiline):
- (JSC::regExpObjectSource):
- (JSC::regExpObjectLastIndex):
- (JSC::setRegExpObjectLastIndex):
- * kjs/RegExpObject.h:
- (JSC::RegExpObject::setLastIndex):
- (JSC::RegExpObject::lastIndex):
- (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames):
- * kjs/create_hash_table:
- * kjs/lexer.cpp:
- (JSC::Lexer::lex):
- * kjs/lookup.cpp:
- (JSC::HashTable::createTable):
- (JSC::HashTable::deleteTable):
- (JSC::setUpStaticFunctionSlot):
- * kjs/lookup.h:
- (JSC::HashEntry::initialize):
- (JSC::HashEntry::setKey):
- (JSC::HashEntry::key):
- (JSC::HashEntry::attributes):
- (JSC::HashEntry::function):
- (JSC::HashEntry::functionLength):
- (JSC::HashEntry::propertyGetter):
- (JSC::HashEntry::propertyPutter):
- (JSC::HashEntry::lexerValue):
- (JSC::HashEntry::):
- (JSC::HashTable::entry):
- (JSC::getStaticPropertySlot):
- (JSC::getStaticValueSlot):
- (JSC::lookupPut):
-
-2008-09-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak & Oliver Hunt.
-
- Add support for reusing temporary JSNumberCells. This change is based on the observation
- that if the result of certain operations is a JSNumberCell and is consumed by a subsequent
- operation that would produce a JSNumberCell, we can reuse the object rather than allocating
- a fresh one. E.g. given the expression ((a * b) * c), we can statically determine that
- (a * b) will have a numeric result (or else it will have thrown an exception), so the result
- will either be a JSNumberCell or a JSImmediate.
-
- This patch changes three areas of JSC:
- * The AST now tracks type information about the result of each node.
- * This information is consumed in bytecode compilation, and certain bytecode operations
- now carry the statically determined type information about their operands.
- * CTI uses the information in a number of fashions:
- * Where an operand to certain arithmetic operations is reusable, it will plant code
- to try to perform the operation in JIT code & reuse the cell, where appropriate.
- * Where it can be statically determined that an operand can only be numeric (typically
- the result of another arithmetic operation) the code will not redundantly check that
- the JSCell is a JSNumberCell.
- * Where either of the operands to an add are non-numeric do not plant an optimized
- arithmetic code path, just call straight out to the C function.
-
- +6% Sunspider (10% progression on 3D, 16% progression on math, 60% progression on access-nbody),
- +1% v8-tests (improvements in raytrace & crypto)
-
- * VM/CTI.cpp: Add optimized code generation with reuse of temporary JSNumberCells.
- * VM/CTI.h:
- * kjs/JSNumberCell.h:
- * masm/X86Assembler.h:
-
- * VM/CodeBlock.cpp: Add type information to specific bytecodes.
- * VM/CodeGenerator.cpp:
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
-
- * kjs/nodes.cpp: Track static type information for nodes.
- * kjs/nodes.h:
- * kjs/ResultDescriptor.h: (Added)
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-09-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by George Staikos, Maciej Stachowiak.
-
- Add utility functions needed for upcoming WML code.
-
- * wtf/ASCIICType.h:
- (WTF::isASCIIPrintable):
-
-2008-09-26 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Reverted the part of r36614 that used static data because static data
- is not thread-safe.
-
-2008-09-26 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Removed dynamic check for whether the callee needs an activation object.
- Replaced with callee code to create the activation object.
-
- 0.5% speedup on SunSpider.
- No change on v8 benchmark. (Might be a speedup, but it's in range of the
- variance.)
-
- 0.7% speedup on v8 benchmark in bytecode.
- 1.3% speedup on empty call benchmark in bytecode.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass): Added support for op_init_activation,
- the new opcode that specifies that the callee's initialization should
- create an activation object.
- (JSC::CTI::privateCompile): Removed previous code that did a similar
- thing in an ad-hoc way.
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Added a case for dumping op_init_activation.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::generate): Added fixup code to change op_init to
- op_init_activation if necessary. (With a better parser, we would know
- which to use from the beginning.)
-
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
- (WTF::): Faster traits for the instruction vector. An earlier version
- of this patch relied on inserting at the beginning of the vector, and
- depended on this change for speed.
-
- * VM/Machine.cpp:
- (JSC::Machine::execute): Removed clients of setScopeChain, the old
- abstraction for dynamically checking for whether an activation object
- needed to be created.
- (JSC::Machine::privateExecute): ditto
-
- (JSC::Machine::cti_op_push_activation): Renamed this function from
- cti_vm_updateScopeChain, and made it faster by removing the call to
- setScopeChain.
- * VM/Machine.h:
-
- * VM/Opcode.h: Declared op_init_activation.
-
-2008-09-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Move most of the return code back into the callee, now that the callee
- doesn't have to calculate anything dynamically.
-
- 11.5% speedup on empty function call benchmark.
-
- SunSpider says 0.3% faster. SunSpider --v8 says no change.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
-
-2008-09-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Remove staticFunctionGetter. There is only one remaining user of
- staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
-
- * JavaScriptCore.exp:
- * kjs/lookup.cpp:
- * kjs/lookup.h:
-
-2008-09-24 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - inline JIT fast case of op_neq
- - remove extra level of function call indirection from slow cases of eq and neq
-
- 1% speedup on Richards
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_eq):
- (JSC::Machine::cti_op_neq):
- * kjs/operations.cpp:
- (JSC::equal):
- (JSC::equalSlowCase):
- * kjs/operations.h:
- (JSC::equalSlowCaseInline):
-
-2008-09-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
- <rdar://problem/6243534>
- Crash below Function.apply when using a runtime array as the argument list
-
- Test: plugins/bindings-array-apply-crash.html
-
- * kjs/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply): Revert to the slow case if the object inherits from
- JSArray (via ClassInfo) but is not a JSArray.
-
-2008-09-24 Kevin McCullough <kmccullough@apple.com>
-
- Style change.
-
- * kjs/nodes.cpp:
- (JSC::statementListEmitCode):
-
-2008-09-24 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff.
-
- Bug 21031: Breakpoints in the condition of loops only breaks the first
- time
- - Now when setting breakpoints in the condition of a loop (for, while,
- for in, and do while) will successfully break each time throught the
- loop.
- - For 'for' loops we need a little more complicated behavior that cannot
- be accomplished without some more significant changes:
- https://bugs.webkit.org/show_bug.cgi?id=21073
-
- * kjs/nodes.cpp:
- (JSC::statementListEmitCode): We don't want to blindly emit a debug hook
- at the first line of loops, instead let the loop emit the debug hooks.
- (JSC::DoWhileNode::emitCode):
- (JSC::WhileNode::emitCode):
- (JSC::ForNode::emitCode):
- (JSC::ForInNode::emitCode):
- * kjs/nodes.h:
- (JSC::StatementNode::):
- (JSC::DoWhileNode::):
- (JSC::WhileNode::):
- (JSC::ForInNode::):
-
-2008-09-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed <rdar://problem/5605532> Need a SPI for telling JS the size of
- the objects it retains
-
- * API/tests/testapi.c: Test the new SPI a little.
-
- * API/JSSPI.cpp: Add the new SPI.
- * API/JSSPI.h: Add the new SPI.
- * JavaScriptCore.exp: Add the new SPI.
- * JavaScriptCore.xcodeproj/project.pbxproj: Add the new SPI.
-
-2008-09-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- * API/JSBase.h: Filled in some missing function names.
-
-2008-09-24 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21057
- Crash in RegisterID::deref() running fast/canvas/canvas-putImageData.html
-
- * VM/CodeGenerator.h: Changed declaration order to ensure the
- m_lastConstant, which is a RefPtr that points into m_calleeRegisters,
- has its destructor called before the destructor for m_calleeRegisters.
-
-2008-09-24 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21047
- speed up ret_activation with inlining
-
- About 1% on v8-raytrace.
-
- * JavaScriptCore.exp: Removed JSVariableObject::setRegisters.
-
- * kjs/JSActivation.cpp: Moved copyRegisters to the header to make it inline.
- * kjs/JSActivation.h:
- (JSC::JSActivation::copyRegisters): Moved here. Also removed the registerArraySize
- argument to setRegisters, since the object doesn't need to store the number of
- registers.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset): Removed unnecessary clearing left over from when we
- used this on objects that weren't brand new. These days, this function is really
- just part of the constructor.
-
- * kjs/JSGlobalObject.h: Added registerArraySize to JSGlobalObjectData, since
- JSVariableObjectData no longer needs it. Added a setRegisters override here
- that handles storing the size.
-
- * kjs/JSStaticScopeObject.h: Removed code to set registerArraySize, since it
- no longer exists.
-
- * kjs/JSVariableObject.cpp: Moved copyRegisterArray and setRegisters to the
- header to make them inline.
- * kjs/JSVariableObject.h: Removed registerArraySize from JSVariableObjectData,
- since it was only used for the global object.
- (JSC::JSVariableObject::copyRegisterArray): Moved here ot make it inline.
- (JSC::JSVariableObject::setRegisters): Moved here to make it inline. Also
- removed the code to set registerArraySize and changed an if statement into
- an assert to save an unnnecessary branch.
-
-2008-09-24 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - inline PropertyMap::getOffset to speed up polymorphic lookups
-
- ~1.5% speedup on v8 benchmark
- no effect on SunSpider
-
- * JavaScriptCore.exp:
- * kjs/PropertyMap.cpp:
- * kjs/PropertyMap.h:
- (JSC::PropertyMap::getOffset):
-
-2008-09-24 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=20992
- Build fails on GTK+ Mac OS
-
- * wtf/ThreadingGtk.cpp: Remove platform ifdef as suggested by
- Richard Hult.
- (WTF::initializeThreading):
-
-2008-09-23 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 19968: Slow Script at www.huffingtonpost.com
- <https://bugs.webkit.org/show_bug.cgi?id=19968>
-
- Finally found the cause of this accursed issue. It is triggered
- by synchronous creation of a new global object from JS. The new
- global object resets the timer state in this execution group's
- Machine, taking timerCheckCount to 0. Then when JS returns the
- timerCheckCount is decremented making it non-zero. The next time
- we execute JS we will start the timeout counter, however the non-zero
- timeoutCheckCount means we don't reset the timer information. This
- means that the timeout check is now checking the cumulative time
- since the creation of the global object rather than the time since
- JS was last entered. At this point the slow script dialog is guaranteed
- to eventually be displayed incorrectly unless a page is loaded
- asynchronously (which will reset everything into a sane state).
-
- The fix for this is rather trivial -- the JSGlobalObject constructor
- should not be resetting the machine timer state.
-
- * VM/Machine.cpp:
- (JSC::Machine::Machine):
- Now that we can't rely on the GlobalObject initialising the timeout
- state, we do it in the Machine constructor.
-
- * VM/Machine.h:
- (JSC::Machine::stopTimeoutCheck):
- Add assertions to guard against this happening.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::init):
- Don't reset the timeout state.
+ <rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit
-2008-09-23 Geoffrey Garen <ggaren@apple.com>
+ On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.
- Reviewed by Oliver Hunt.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21038 | <rdar://problem/6240812>
- Uncaught exceptions in regex replace callbacks crash webkit
-
- This was a combination of two problems:
-
- (1) the replace function would continue execution after an exception
- had been thrown.
-
- (2) In some cases, the Machine would return 0 in the case of an exception,
- despite the fact that a few clients dereference the Machine's return
- value without first checking for an exception.
-
- * VM/Machine.cpp:
- (JSC::Machine::execute):
-
- ^ Return jsNull() instead of 0 in the case of an exception, since some
- clients depend on using our return value.
-
- ^ ASSERT that execution does not continue after an exception has been
- thrown, to help catch problems like this in the future.
-
- * kjs/StringPrototype.cpp:
- (JSC::stringProtoFuncReplace):
-
- ^ Stop execution if an exception has been thrown.
-
-2008-09-23 Geoffrey Garen <ggaren@apple.com>
-
- Try to fix the windows build.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
-
-2008-09-23 Alp Toker <alp@nuanti.com>
-
- Build fix.
-
- * VM/CTI.h:
-
-2008-09-23 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- * wtf/Platform.h: Removed duplicate #if.
-
-2008-09-23 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Changed the layout of the call frame from
-
- { header, parameters, locals | constants, temporaries }
-
- to
-
- { parameters, header | locals, constants, temporaries }
-
- This simplifies function entry+exit, and enables a number of future
- optimizations.
-
- 13.5% speedup on empty call benchmark for bytecode; 23.6% speedup on
- empty call benchmark for CTI.
-
- SunSpider says no change. SunSpider --v8 says 1% faster.
-
- * VM/CTI.cpp:
-
- Added a bit of abstraction for calculating whether a register is a
- constant, since this patch changes that calculation:
- (JSC::CTI::isConstant):
- (JSC::CTI::getConstant):
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::getConstantImmediateNumericArg):
-
- Updated for changes to callframe header location:
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::printOpcodeOperandTypes):
-
- Renamed to spite Oliver:
- (JSC::CTI::emitInitRegister):
-
- Added an abstraction for emitting a call through a register, so that
- calls through registers generate exception info, too:
- (JSC::CTI::emitCall):
-
- Updated to match the new callframe header layout, and to support calls
- through registers, which have no destination address:
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
-
- * VM/CTI.h:
-
- More of the above:
- (JSC::CallRecord::CallRecord):
-
- * VM/CodeBlock.cpp:
-
- Updated for new register layout:
- (JSC::registerName):
- (JSC::CodeBlock::dump):
-
- * VM/CodeBlock.h:
-
- Updated CodeBlock to track slightly different information about the
- register frame, and tweaked the style of an ASSERT_NOT_REACHED.
- (JSC::CodeBlock::CodeBlock):
- (JSC::CodeBlock::getStubInfo):
-
- * VM/CodeGenerator.cpp:
-
- Added some abstraction around constant register allocation, since this
- patch changes it, changed codegen to account for the new callframe
- layout, and added abstraction around register fetching code
- that used to assume that all local registers lived at negative indices,
- since vars now live at positive indices:
- (JSC::CodeGenerator::generate):
- (JSC::CodeGenerator::addVar):
- (JSC::CodeGenerator::addGlobalVar):
- (JSC::CodeGenerator::allocateConstants):
- (JSC::CodeGenerator::CodeGenerator):
- (JSC::CodeGenerator::addParameter):
- (JSC::CodeGenerator::registerFor):
- (JSC::CodeGenerator::constRegisterFor):
- (JSC::CodeGenerator::newRegister):
- (JSC::CodeGenerator::newTemporary):
- (JSC::CodeGenerator::highestUsedRegister):
- (JSC::CodeGenerator::addConstant):
-
- ASSERT that our caller referenced the registers it passed to us.
- Otherwise, we might overwrite them with parameters:
- (JSC::CodeGenerator::emitCall):
- (JSC::CodeGenerator::emitConstruct):
-
- * VM/CodeGenerator.h:
-
- Added some abstraction for getting a RegisterID for a given index,
- since the rules are a little weird:
- (JSC::CodeGenerator::registerFor):
-
- * VM/Machine.cpp:
-
- Utility function to transform a machine return PC to a virtual machine
- return VPC, for the sake of stack unwinding, since both PCs are stored
- in the same location now:
- (JSC::vPCForPC):
-
- Tweaked to account for new call frame:
- (JSC::Machine::initializeCallFrame):
-
- Tweaked to account for registerOffset supplied by caller:
- (JSC::slideRegisterWindowForCall):
-
- Tweaked to account for new register layout:
- (JSC::scopeChainForCall):
- (JSC::Machine::callEval):
- (JSC::Machine::dumpRegisters):
- (JSC::Machine::unwindCallFrame):
- (JSC::Machine::execute):
-
- Changed op_call and op_construct to implement the new calling convention:
- (JSC::Machine::privateExecute):
-
- Tweaked to account for the new register layout:
- (JSC::Machine::retrieveArguments):
- (JSC::Machine::retrieveCaller):
- (JSC::Machine::retrieveLastCaller):
- (JSC::Machine::callFrame):
- (JSC::Machine::getArgumentsData):
-
- Changed CTI call helpers to implement the new calling convention:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_call_NotJSFunction):
- (JSC::Machine::cti_op_ret_activation):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_construct_JSConstruct):
- (JSC::Machine::cti_op_construct_NotJSConstruct):
- (JSC::Machine::cti_op_call_eval):
-
- * VM/Machine.h:
-
- * VM/Opcode.h:
-
- Renamed op_initialise_locals to op_init, because this opcode
- doesn't initialize all locals, and it doesn't initialize only locals.
- Also, to spite Oliver.
-
- * VM/RegisterFile.h:
-
- New call frame enumeration values:
- (JSC::RegisterFile::):
-
- Simplified the calculation of whether a RegisterID is a temporary,
- since we can no longer assume that all positive non-constant registers
- are temporaries:
- * VM/RegisterID.h:
- (JSC::RegisterID::RegisterID):
- (JSC::RegisterID::setTemporary):
- (JSC::RegisterID::isTemporary):
-
- Renamed firstArgumentIndex to firstParameterIndex because the assumption
- that this variable pertained to the actual arguments supplied by the
- caller caused me to write some buggy code:
- * kjs/Arguments.cpp:
- (JSC::ArgumentsData::ArgumentsData):
- (JSC::Arguments::Arguments):
- (JSC::Arguments::fillArgList):
- (JSC::Arguments::getOwnPropertySlot):
- (JSC::Arguments::put):
-
- Updated for new call frame layout:
- * kjs/DebuggerCallFrame.cpp:
- (JSC::DebuggerCallFrame::functionName):
- (JSC::DebuggerCallFrame::type):
- * kjs/DebuggerCallFrame.h:
-
- Changed the activation object to account for the fact that a call frame
- header now sits between parameters and local variables. This change
- requires all variable objects to do their own marking, since they
- now use their register storage differently:
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::mark):
- (JSC::JSActivation::copyRegisters):
- (JSC::JSActivation::createArgumentsObject):
- * kjs/JSActivation.h:
-
- Updated global object to use the new interfaces required by the change
- to JSActivation above:
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- (JSC::JSGlobalObject::mark):
- (JSC::JSGlobalObject::copyGlobalsFrom):
- (JSC::JSGlobalObject::copyGlobalsTo):
- * kjs/JSGlobalObject.h:
- (JSC::JSGlobalObject::addStaticGlobals):
-
- Updated static scope object to use the new interfaces required by the
- change to JSActivation above:
- * kjs/JSStaticScopeObject.cpp:
- (JSC::JSStaticScopeObject::mark):
- (JSC::JSStaticScopeObject::~JSStaticScopeObject):
- * kjs/JSStaticScopeObject.h:
- (JSC::JSStaticScopeObject::JSStaticScopeObject):
- (JSC::JSStaticScopeObject::d):
-
- Updated variable object to use the new interfaces required by the
- change to JSActivation above:
- * kjs/JSVariableObject.cpp:
- (JSC::JSVariableObject::copyRegisterArray):
- (JSC::JSVariableObject::setRegisters):
- * kjs/JSVariableObject.h:
-
- Changed the bit twiddling in symbol table not to assume that all indices
- are negative, since they can be positive now:
- * kjs/SymbolTable.h:
- (JSC::SymbolTableEntry::SymbolTableEntry):
- (JSC::SymbolTableEntry::isNull):
- (JSC::SymbolTableEntry::getIndex):
- (JSC::SymbolTableEntry::getAttributes):
- (JSC::SymbolTableEntry::setAttributes):
- (JSC::SymbolTableEntry::isReadOnly):
- (JSC::SymbolTableEntry::pack):
- (JSC::SymbolTableEntry::isValidIndex):
-
- Changed call and construct nodes to ref their functions and/or bases,
- so that emitCall/emitConstruct doesn't overwrite them with parameters.
- Also, updated for rename to registerFor:
- * kjs/nodes.cpp:
- (JSC::ResolveNode::emitCode):
- (JSC::NewExprNode::emitCode):
- (JSC::EvalFunctionCallNode::emitCode):
- (JSC::FunctionCallValueNode::emitCode):
- (JSC::FunctionCallResolveNode::emitCode):
- (JSC::FunctionCallBracketNode::emitCode):
- (JSC::FunctionCallDotNode::emitCode):
- (JSC::PostfixResolveNode::emitCode):
- (JSC::DeleteResolveNode::emitCode):
- (JSC::TypeOfResolveNode::emitCode):
- (JSC::PrefixResolveNode::emitCode):
- (JSC::ReadModifyResolveNode::emitCode):
- (JSC::AssignResolveNode::emitCode):
- (JSC::ConstDeclNode::emitCodeSingle):
- (JSC::ForInNode::emitCode):
-
- Added abstraction for getting exception info out of a call through a
- register:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitCall):
-
- Removed duplicate #if:
- * wtf/Platform.h:
-
-2008-09-23 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Darin.
-
- Bug 21030: The JS debugger breaks on the do of a do-while not the while
- (where the conditional statement is)
- https://bugs.webkit.org/show_bug.cgi?id=21030
- Now the statementListEmitCode detects if a do-while node is being
- emited and emits the debug hook on the last line instead of the first.
-
- This change had no effect on sunspider.
-
- * kjs/nodes.cpp:
- (JSC::statementListEmitCode):
- * kjs/nodes.h:
- (JSC::StatementNode::isDoWhile):
- (JSC::DoWhileNode::isDoWhile):
-
-2008-09-23 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - inline the fast case of instanceof
- https://bugs.webkit.org/show_bug.cgi?id=20818
-
- ~2% speedup on EarleyBoyer test.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_instanceof):
-
-2008-09-23 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - add forgotten slow case logic for !==
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileSlowCases):
-
-2008-09-23 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - inline the fast cases of !==, same as for ===
-
- 2.9% speedup on EarleyBoyer benchmark
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpStrictEq): Factored stricteq codegen into this function,
- and parameterized so it can do the reverse version as well.
- (JSC::CTI::privateCompileMainPass): Use the above for stricteq and nstricteq.
- * VM/CTI.h:
- (JSC::CTI::): Declare above stuff.
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_nstricteq): Removed fast cases, now handled inline.
-
-2008-09-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20989: Aguments constructor should put 'callee' and 'length' properties in a more efficient way
- <https://bugs.webkit.org/show_bug.cgi?id=20989>
-
- Make special cases for the 'callee' and 'length' properties in the
- Arguments object.
-
- This is somewhere between a 7.8% speedup and a 10% speedup on the V8
- Raytrace benchmark, depending on whether it is run alone or with the
- other V8 benchmarks.
-
- * kjs/Arguments.cpp:
- (JSC::ArgumentsData::ArgumentsData):
- (JSC::Arguments::Arguments):
- (JSC::Arguments::mark):
- (JSC::Arguments::getOwnPropertySlot):
- (JSC::Arguments::put):
- (JSC::Arguments::deleteProperty):
-
-2008-09-23 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Darin.
-
- - speed up instanceof some more
- https://bugs.webkit.org/show_bug.cgi?id=20818
-
- ~2% speedup on EarleyBoyer
-
- The idea here is to record in the StructureID whether the class
- needs a special hasInstance or if it can use the normal logic from
- JSObject.
-
- Based on this I inlined the real work directly into
- cti_op_instanceof and put the fastest checks up front and the
- error handling at the end (so it should be fairly straightforward
- to split off the beginning to be inlined if desired).
-
- I only did this for CTI, not the bytecode interpreter.
-
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::createStructureID):
- * ChangeLog:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_instanceof):
- * kjs/JSImmediate.h:
- (JSC::JSImmediate::isAnyImmediate):
- * kjs/TypeInfo.h:
- (JSC::TypeInfo::overridesHasInstance):
- (JSC::TypeInfo::flags):
-
-2008-09-22 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21019
- make FunctionBodyNode::ref/deref fast
-
- Speeds up v8-raytrace by 7.2%.
-
- * kjs/nodes.cpp:
- (JSC::FunctionBodyNode::FunctionBodyNode): Initialize m_refCount to 0.
- * kjs/nodes.h:
- (JSC::FunctionBodyNode::ref): Call base class ref once, and thereafter use
- m_refCount.
- (JSC::FunctionBodyNode::deref): Ditto, but the deref side.
-
-2008-09-22 Darin Adler <darin@apple.com>
-
- Pointed out by Sam Weinig.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::fillArgList): Fix bad copy and paste. Oops!
-
-2008-09-22 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20983
- ArgumentsData should have some room to allocate some extra arguments inline
-
- Speeds up v8-raytrace by 5%.
-
- * kjs/Arguments.cpp:
- (JSC::ArgumentsData::ArgumentsData): Use a fixed buffer if there are 4 or fewer
- extra arguments.
- (JSC::Arguments::Arguments): Use a fixed buffer if there are 4 or fewer
- extra arguments.
- (JSC::Arguments::~Arguments): Delete the buffer if necessary.
- (JSC::Arguments::mark): Update since extraArguments are now Register.
- (JSC::Arguments::fillArgList): Added special case for the only case that's
- actually used in the practice, when there are no parameters. There are some
- other special cases in there too, but that's the only one that matters.
- (JSC::Arguments::getOwnPropertySlot): Updated to use setValueSlot since there's
- no operation to get you at the JSValue* inside a Register as a "slot".
-
-2008-09-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21014
- Speed up for..in by using StructureID to avoid calls to hasProperty
-
- Speeds up fasta by 8%.
-
- * VM/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::invalidate):
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::next):
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArrayData::begin):
- (JSC::PropertyNameArrayData::end):
- (JSC::PropertyNameArrayData::setCachedStructureID):
- (JSC::PropertyNameArrayData::cachedStructureID):
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames):
- (JSC::structureIDChainsAreEqual):
- * kjs/StructureID.h:
-
-2008-09-22 Kelvin Sherlock <ksherlock@gmail.com>
-
- Updated and tweaked by Sam Weinig.
-
- Reviewed by Geoffrey Garen.
-
- Bug 20020: Proposed enhancement to JavaScriptCore API
- <https://bugs.webkit.org/show_bug.cgi?id=20020>
-
- Add JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError, and JSObjectMakeRegExp
- functions to create JavaScript Array, Date, Error, and RegExp objects, respectively.
-
- * API/JSObjectRef.cpp: The functions
- * API/JSObjectRef.h: Function prototype and documentation
- * JavaScriptCore.exp: Added functions to exported function list
- * API/tests/testapi.c: Added basic functionality tests.
-
- * kjs/DateConstructor.cpp:
- Replaced static JSObject* constructDate(ExecState* exec, JSObject*, const ArgList& args)
- with JSObject* constructDate(ExecState* exec, const ArgList& args).
- Added static JSObject* constructWithDateConstructor(ExecState* exec, JSObject*, const ArgList& args) function
-
- * kjs/DateConstructor.h:
- added prototype for JSObject* constructDate(ExecState* exec, const ArgList& args)
-
- * kjs/ErrorConstructor.cpp:
- removed static qualifier from ErrorInstance* constructError(ExecState* exec, const ArgList& args)
-
- * kjs/ErrorConstructor.h:
- added prototype for ErrorInstance* constructError(ExecState* exec, const ArgList& args)
-
- * kjs/RegExpConstructor.cpp:
- removed static qualifier from JSObject* constructRegExp(ExecState* exec, const ArgList& args)
-
- * kjs/RegExpConstructor.h:
- added prototype for JSObject* constructRegExp(ExecState* exec, const ArgList& args)
-
-2008-09-22 Matt Lilek <webkit@mattlilek.com>
-
- Not reviewed, Windows build fix.
-
- * kjs/Arguments.cpp:
- * kjs/FunctionPrototype.cpp:
-
-2008-09-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=20982
- Speed up the apply method of functions by special-casing array and 'arguments' objects
-
- 1% speedup on v8-raytrace.
-
- Test: fast/js/function-apply.html
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::fillArgList):
- * kjs/Arguments.h:
- * kjs/FunctionPrototype.cpp:
- (JSC::functionProtoFuncApply):
- * kjs/JSArray.cpp:
- (JSC::JSArray::fillArgList):
- * kjs/JSArray.h:
-
-2008-09-22 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20993
- Array.push/pop need optimized cases for JSArray
-
- 3% or so speedup on DeltaBlue benchmark.
-
- * kjs/ArrayPrototype.cpp:
- (JSC::arrayProtoFuncPop): Call JSArray::pop when appropriate.
- (JSC::arrayProtoFuncPush): Call JSArray::push when appropriate.
-
- * kjs/JSArray.cpp:
- (JSC::JSArray::putSlowCase): Set m_fastAccessCutoff when appropriate, getting
- us into the fast code path.
- (JSC::JSArray::pop): Added.
- (JSC::JSArray::push): Added.
- * kjs/JSArray.h: Added push and pop.
-
- * kjs/operations.cpp:
- (JSC::throwOutOfMemoryError): Don't inline this. Helps us avoid PIC branches.
+ No performance impact.
-2008-09-22 Maciej Stachowiak <mjs@apple.com>
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_rshift):
- Reviewed by Cameron Zwarich.
-
- - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
+2009-06-17 Adam Treat <adam.treat@torchmobile.com>
- Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
-
- 2.2% speedup on EarleyBoyer benchmark.
-
- * API/JSCallbackConstructor.cpp:
- * API/JSCallbackConstructor.h:
- (JSC::JSCallbackConstructor::createStructureID):
- * API/JSCallbackFunction.cpp:
- * API/JSCallbackFunction.h:
- (JSC::JSCallbackFunction::createStructureID):
- * API/JSCallbackObject.h:
- (JSC::JSCallbackObject::createStructureID):
- * API/JSCallbackObjectFunctions.h:
- (JSC::::hasInstance):
- * API/JSValueRef.cpp:
- (JSValueIsInstanceOfConstructor):
- * JavaScriptCore.exp:
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_instanceof):
- * kjs/InternalFunction.cpp:
- * kjs/InternalFunction.h:
- (JSC::InternalFunction::createStructureID):
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- * kjs/TypeInfo.h:
- (JSC::TypeInfo::implementsHasInstance):
-
-2008-09-22 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Based on initial work by Darin Adler.
-
- - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
- - use this to JIT inline code for eq_null and neq_null
- https://bugs.webkit.org/show_bug.cgi?id=20823
+ Reviewed by George Staikos.
- 0.5% speedup on SunSpider
- ~4% speedup on Richards benchmark
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/Machine.cpp:
- (JSC::jsTypeStringForValue):
- (JSC::jsIsObjectType):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_is_undefined):
- * VM/Machine.h:
- * kjs/JSCell.h:
- * kjs/JSValue.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::create):
- (JSC::StringObjectThatMasqueradesAsUndefined::createStructureID):
- * kjs/StructureID.h:
- (JSC::StructureID::mutableTypeInfo):
- * kjs/TypeInfo.h:
- (JSC::TypeInfo::TypeInfo):
- (JSC::TypeInfo::masqueradesAsUndefined):
- * kjs/operations.cpp:
- (JSC::equal):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::setne_r):
- (JSC::X86Assembler::setnz_r):
- (JSC::X86Assembler::testl_i32m):
-
-2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Initialize QCoreApplication in kjs binary/Shell.cpp
-
- This allows us to use QCoreApplication::instance() to
- get the main thread in ThreadingQt.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=23155
+ Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- * kjs/Shell.cpp:
+ * jsc.cpp:
(main):
- * wtf/ThreadingQt.cpp:
- (WTF::initializeThreading):
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- - blind attempt to fix non-all-in-one builds
-
- * kjs/JSGlobalObject.cpp: Added includes of Arguments.h and RegExpObject.h.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- - fix debug build
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::addPropertyTransition): Use typeInfo().type() instead of m_type.
- (JSC::StructureID::createCachedPrototypeChain): Ditto.
-
-2008-09-21 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Darin Adler.
-
- - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
- https://bugs.webkit.org/show_bug.cgi?id=20981
-
- * JavaScriptCore.exp:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompilePutByIdTransition):
- * VM/Machine.cpp:
- (JSC::jsIsObjectType):
- (JSC::Machine::Machine):
- * kjs/AllInOneFile.cpp:
- * kjs/JSCell.h:
- (JSC::JSCell::isObject):
- (JSC::JSCell::isString):
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::reset):
- * kjs/JSGlobalObject.h:
- (JSC::StructureID::prototypeForLookup):
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::createStructureID):
- * kjs/JSObject.cpp:
- (JSC::JSObject::createInheritorID):
- * kjs/JSObject.h:
- (JSC::JSObject::createStructureID):
- * kjs/JSString.h:
- (JSC::JSString::createStructureID):
- * kjs/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- * kjs/RegExpConstructor.cpp:
- * kjs/RegExpMatchesArray.h: Added.
- (JSC::RegExpMatchesArray::getOwnPropertySlot):
- (JSC::RegExpMatchesArray::put):
- (JSC::RegExpMatchesArray::deleteProperty):
- (JSC::RegExpMatchesArray::getPropertyNames):
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::addPropertyTransition):
- (JSC::StructureID::toDictionaryTransition):
- (JSC::StructureID::changePrototypeTransition):
- (JSC::StructureID::getterSetterTransition):
- * kjs/StructureID.h:
- (JSC::StructureID::create):
- (JSC::StructureID::typeInfo):
- * kjs/TypeInfo.h: Added.
- (JSC::TypeInfo::TypeInfo):
- (JSC::TypeInfo::type):
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix crash logging into Gmail due to recent Arguments change
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::Arguments): Fix window where mark() function could
- see d->extraArguments with uninitialized contents.
- (JSC::Arguments::mark): Check d->extraArguments for 0 to handle two
- cases: 1) Inside the constructor before it's initialized.
- 2) numArguments <= numParameters.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- - fix loose end from the "duplicate constant values" patch
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitLoad): Add a special case for values the
- hash table can't handle.
-
-2008-09-21 Mark Rowe <mrowe@apple.com>
-
- Fix the non-AllInOneFile build.
-
- * kjs/Arguments.cpp: Add missing #include.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich and Mark Rowe.
-
- - fix test failure caused by my recent IndexToNameMap patch
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::deleteProperty): Added the accidentally-omitted
- check of the boolean result from toArrayIndex.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20975
- inline immediate-number case of ==
-
- * VM/CTI.h: Renamed emitJumpSlowCaseIfNotImm to
- emitJumpSlowCaseIfNotImmNum, since the old name was incorrect.
-
- * VM/CTI.cpp: Updated for new name.
- (JSC::CTI::privateCompileMainPass): Added op_eq.
- (JSC::CTI::privateCompileSlowCases): Added op_eq.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_eq): Removed fast case, since it's now
- compiled.
-
-2008-09-21 Peter Gal <galpter@inf.u-szeged.hu>
-
- Reviewed by Tim Hatcher and Eric Seidel.
-
- Fix the QT/Linux JavaScriptCore segmentation fault.
- https://bugs.webkit.org/show_bug.cgi?id=20914
-
- * wtf/ThreadingQt.cpp:
- (WTF::initializeThreading): Use currentThread() if
- platform is not a MAC (like in pre 36541 revisions)
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- * kjs/debugger.h: Removed some unneeded includes and declarations.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20972
- speed up Arguments further by eliminating the IndexToNameMap
-
- No change on SunSpider. 1.29x as fast on V8 Raytrace.
-
- * kjs/Arguments.cpp: Moved ArgumentsData in here. Eliminated the
- indexToNameMap and hadDeletes data members. Changed extraArguments into
- an OwnArrayPtr and added deletedArguments, another OwnArrayPtr.
- Replaced numExtraArguments with numParameters, since that's what's
- used more directly in hot code paths.
- (JSC::Arguments::Arguments): Pass in argument count instead of ArgList.
- Initialize ArgumentsData the new way.
- (JSC::Arguments::mark): Updated.
- (JSC::Arguments::getOwnPropertySlot): Overload for the integer form so
- we don't have to convert integers to identifiers just to get an argument.
- Integrated the deleted case with the fast case.
- (JSC::Arguments::put): Ditto.
- (JSC::Arguments::deleteProperty): Ditto.
-
- * kjs/Arguments.h: Minimized includes. Made everything private. Added
- overloads for the integral property name case. Eliminated mappedIndexSetter.
- Moved ArgumentsData into the .cpp file.
-
- * kjs/IndexToNameMap.cpp: Emptied out and prepared for deletion.
- * kjs/IndexToNameMap.h: Ditto.
-
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::createArgumentsObject): Elminated ArgList.
-
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/AllInOneFile.cpp:
- Removed IndexToNameMap.
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitLoad): One more tweak: Wrote this in a slightly
- clearer style.
-
-2008-09-21 Judit Jasz <jasy@inf.u-szeged.hu>
-
- Reviewed and tweaked by Darin Adler.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20645
- Elminate duplicate constant values in CodeBlocks.
-
- Seems to be a wash on SunSpider.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitLoad): Use m_numberMap and m_stringMap to guarantee
- we emit the same JSValue* for identical numbers and strings.
- * VM/CodeGenerator.h: Added overload of emitLoad for const Identifier&.
- Add NumberMap and IdentifierStringMap types and m_numberMap and m_stringMap.
- * kjs/nodes.cpp:
- (JSC::StringNode::emitCode): Call the new emitLoad and let it do the
- JSString creation.
-
-2008-09-21 Paul Pedriana <webkit@pedriana.com>
-
- Reviewed and tweaked by Darin Adler.
-
- - https://bugs.webkit.org/show_bug.cgi?id=16925
- Fixed lack of Vector buffer alignment for both GCC and MSVC.
- Since there's no portable way to do this, for now we don't support
- other compilers.
-
- * wtf/Vector.h: Added WTF_ALIGH_ON, WTF_ALIGNED, AlignedBufferChar, and AlignedBuffer.
- Use AlignedBuffer insteadof an array of char in VectorBuffer.
-
-2008-09-21 Gabor Loki <loki@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- - https://bugs.webkit.org/show_bug.cgi?id=19408
- Add lightweight constant folding to the parser for *, /, + (only for numbers), <<, >>, ~ operators.
-
- 1.008x as fast on SunSpider.
-
- * kjs/grammar.y:
- (makeNegateNode): Fold if expression is a number > 0.
- (makeBitwiseNotNode): Fold if expression is a number.
- (makeMultNode): Fold if expressions are both numbers.
- (makeDivNode): Fold if expressions are both numbers.
- (makeAddNode): Fold if expressions are both numbers.
- (makeLeftShiftNode): Fold if expressions are both numbers.
- (makeRightShiftNode): Fold if expressions are both numbers.
-
-2008-09-21 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver.
-
- - speed up === operator by generating inline machine code for the fast paths
- https://bugs.webkit.org/show_bug.cgi?id=20820
-
- * VM/CTI.cpp:
- (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumber):
- (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumbers):
- (JSC::CTI::emitJumpSlowCaseIfNotImmediates):
- (JSC::CTI::emitTagAsBoolImmediate):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_stricteq):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::sete_r):
- (JSC::X86Assembler::setz_r):
- (JSC::X86Assembler::movzbl_rr):
- (JSC::X86Assembler::emitUnlinkedJnz):
-
-2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Free memory allocated for extra arguments in the destructor of the
- Arguments object.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::~Arguments):
- * kjs/Arguments.h:
-
-2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20815: 'arguments' object creation is non-optimal
- <https://bugs.webkit.org/show_bug.cgi?id=20815>
-
- Fix our inefficient way of creating the arguments object by only
- creating named properties for each of the arguments after a use of the
- 'delete' statement. This patch also speeds up access to the 'arguments'
- object slightly, but it still does not use the array fast path for
- indexed access that exists for many opcodes.
-
- This is about a 20% improvement on the V8 Raytrace benchmark, and a 1.5%
- improvement on the Earley-Boyer benchmark, which gives a 4% improvement
- overall.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::Arguments):
- (JSC::Arguments::mark):
- (JSC::Arguments::getOwnPropertySlot):
- (JSC::Arguments::put):
- (JSC::Arguments::deleteProperty):
- * kjs/Arguments.h:
- (JSC::Arguments::ArgumentsData::ArgumentsData):
- * kjs/IndexToNameMap.h:
- (JSC::IndexToNameMap::size):
- * kjs/JSActivation.cpp:
- (JSC::JSActivation::createArgumentsObject):
- * kjs/JSActivation.h:
- (JSC::JSActivation::uncheckedSymbolTableGet):
- (JSC::JSActivation::uncheckedSymbolTableGetValue):
- (JSC::JSActivation::uncheckedSymbolTablePut):
- * kjs/JSFunction.h:
- (JSC::JSFunction::numParameters):
-
-2008-09-20 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix crash seen on buildbot
-
- * kjs/JSGlobalObject.cpp:
- (JSC::JSGlobalObject::mark): Add back mark of arrayPrototype,
- deleted by accident in my recent check-in.
-
-2008-09-20 Maciej Stachowiak <mjs@apple.com>
-
- Not reviewed, build fix.
-
- - speculative fix for non-AllInOne builds
-
- * kjs/operations.h:
-
-2008-09-20 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Darin Adler.
-
- - assorted optimizations to === and !== operators
- (work towards <https://bugs.webkit.org/show_bug.cgi?id=20820>)
-
- 2.5% speedup on earley-boyer test
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_stricteq): Use inline version of
- strictEqualSlowCase; remove unneeded exception check.
- (JSC::Machine::cti_op_nstricteq): ditto
- * kjs/operations.cpp:
- (JSC::strictEqual): Use strictEqualSlowCaseInline
- (JSC::strictEqualSlowCase): ditto
- * kjs/operations.h:
- (JSC::strictEqualSlowCaseInline): Version of strictEqualSlowCase that can be inlined,
- since the extra function call indirection is a lose for CTI.
-
-2008-09-20 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - finish https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- This also includes some optimizations that make the change an overall
- small speedup. Without those it was a bit of a slowdown.
-
- * API/JSCallbackConstructor.cpp:
- (JSC::JSCallbackConstructor::JSCallbackConstructor): Take a structure.
- * API/JSCallbackConstructor.h: Ditto.
- * API/JSCallbackFunction.cpp:
- (JSC::JSCallbackFunction::JSCallbackFunction): Pass a structure.
- * API/JSCallbackObject.h: Take a structure.
- * API/JSCallbackObjectFunctions.h:
- (JSC::JSCallbackObject::JSCallbackObject): Ditto.
-
- * API/JSClassRef.cpp:
- (OpaqueJSClass::prototype): Pass in a structure. Call setPrototype
- if there's a custom prototype involved.
- * API/JSObjectRef.cpp:
- (JSObjectMake): Ditto.
- (JSObjectMakeConstructor): Pass in a structure.
-
- * JavaScriptCore.exp: Updated.
-
- * VM/Machine.cpp:
- (JSC::jsLess): Added a special case for when both arguments are strings.
- This avoids converting both strings to with UString::toDouble.
- (JSC::jsLessEq): Ditto.
- (JSC::Machine::privateExecute): Pass in a structure.
- (JSC::Machine::cti_op_construct_JSConstruct): Ditto.
- (JSC::Machine::cti_op_new_regexp): Ditto.
- (JSC::Machine::cti_op_is_string): Ditto.
- * VM/Machine.h: Made isJSString public so it can be used in the CTI.
-
- * kjs/Arguments.cpp:
- (JSC::Arguments::Arguments): Pass in a structure.
-
- * kjs/JSCell.h: Mark constructor explicit.
-
- * kjs/JSGlobalObject.cpp:
- (JSC::markIfNeeded): Added an overload for marking structures.
- (JSC::JSGlobalObject::reset): Eliminate code to set data members to
- zero. We now do that in the constructor, and we no longer use this
- anywhere except in the constructor. Added code to create structures.
- Pass structures rather than prototypes when creating objects.
- (JSC::JSGlobalObject::mark): Mark the structures.
-
- * kjs/JSGlobalObject.h: Removed unneeded class declarations.
- Added initializers for raw pointers in JSGlobalObjectData so
- everything starts with a 0. Added structure data and accessor
- functions.
-
- * kjs/JSImmediate.cpp:
- (JSC::JSImmediate::nonInlineNaN): Added.
- * kjs/JSImmediate.h:
- (JSC::JSImmediate::toDouble): Rewrote to avoid PIC branches.
-
- * kjs/JSNumberCell.cpp:
- (JSC::jsNumberCell): Made non-inline to avoid PIC branches
- in functions that call this one.
- (JSC::jsNaN): Ditto.
- * kjs/JSNumberCell.h: Ditto.
-
- * kjs/JSObject.h: Removed constructor that takes a prototype.
- All callers now pass structures.
-
- * kjs/ArrayConstructor.cpp:
- (JSC::ArrayConstructor::ArrayConstructor):
- (JSC::constructArrayWithSizeQuirk):
- * kjs/ArrayConstructor.h:
- * kjs/ArrayPrototype.cpp:
- (JSC::ArrayPrototype::ArrayPrototype):
- * kjs/ArrayPrototype.h:
- * kjs/BooleanConstructor.cpp:
- (JSC::BooleanConstructor::BooleanConstructor):
- (JSC::constructBoolean):
- (JSC::constructBooleanFromImmediateBoolean):
- * kjs/BooleanConstructor.h:
- * kjs/BooleanObject.cpp:
- (JSC::BooleanObject::BooleanObject):
- * kjs/BooleanObject.h:
- * kjs/BooleanPrototype.cpp:
- (JSC::BooleanPrototype::BooleanPrototype):
- * kjs/BooleanPrototype.h:
- * kjs/DateConstructor.cpp:
- (JSC::DateConstructor::DateConstructor):
- (JSC::constructDate):
- * kjs/DateConstructor.h:
- * kjs/DateInstance.cpp:
- (JSC::DateInstance::DateInstance):
- * kjs/DateInstance.h:
- * kjs/DatePrototype.cpp:
- (JSC::DatePrototype::DatePrototype):
- * kjs/DatePrototype.h:
- * kjs/ErrorConstructor.cpp:
- (JSC::ErrorConstructor::ErrorConstructor):
- (JSC::constructError):
- * kjs/ErrorConstructor.h:
- * kjs/ErrorInstance.cpp:
- (JSC::ErrorInstance::ErrorInstance):
- * kjs/ErrorInstance.h:
- * kjs/ErrorPrototype.cpp:
- (JSC::ErrorPrototype::ErrorPrototype):
- * kjs/ErrorPrototype.h:
- * kjs/FunctionConstructor.cpp:
- (JSC::FunctionConstructor::FunctionConstructor):
- * kjs/FunctionConstructor.h:
- * kjs/FunctionPrototype.cpp:
- (JSC::FunctionPrototype::FunctionPrototype):
- (JSC::FunctionPrototype::addFunctionProperties):
- * kjs/FunctionPrototype.h:
- * kjs/GlobalEvalFunction.cpp:
- (JSC::GlobalEvalFunction::GlobalEvalFunction):
- * kjs/GlobalEvalFunction.h:
- * kjs/InternalFunction.cpp:
- (JSC::InternalFunction::InternalFunction):
- * kjs/InternalFunction.h:
- (JSC::InternalFunction::InternalFunction):
- * kjs/JSArray.cpp:
- (JSC::JSArray::JSArray):
- (JSC::constructEmptyArray):
- (JSC::constructArray):
- * kjs/JSArray.h:
- * kjs/JSFunction.cpp:
- (JSC::JSFunction::JSFunction):
- (JSC::JSFunction::construct):
- * kjs/JSObject.cpp:
- (JSC::constructEmptyObject):
- * kjs/JSString.cpp:
- (JSC::StringObject::create):
- * kjs/JSWrapperObject.h:
- * kjs/MathObject.cpp:
- (JSC::MathObject::MathObject):
- * kjs/MathObject.h:
- * kjs/NativeErrorConstructor.cpp:
- (JSC::NativeErrorConstructor::NativeErrorConstructor):
- (JSC::NativeErrorConstructor::construct):
- * kjs/NativeErrorConstructor.h:
- * kjs/NativeErrorPrototype.cpp:
- (JSC::NativeErrorPrototype::NativeErrorPrototype):
- * kjs/NativeErrorPrototype.h:
- * kjs/NumberConstructor.cpp:
- (JSC::NumberConstructor::NumberConstructor):
- (JSC::constructWithNumberConstructor):
- * kjs/NumberConstructor.h:
- * kjs/NumberObject.cpp:
- (JSC::NumberObject::NumberObject):
- (JSC::constructNumber):
- (JSC::constructNumberFromImmediateNumber):
- * kjs/NumberObject.h:
- * kjs/NumberPrototype.cpp:
- (JSC::NumberPrototype::NumberPrototype):
- * kjs/NumberPrototype.h:
- * kjs/ObjectConstructor.cpp:
- (JSC::ObjectConstructor::ObjectConstructor):
- (JSC::constructObject):
- * kjs/ObjectConstructor.h:
- * kjs/ObjectPrototype.cpp:
- (JSC::ObjectPrototype::ObjectPrototype):
- * kjs/ObjectPrototype.h:
- * kjs/PrototypeFunction.cpp:
- (JSC::PrototypeFunction::PrototypeFunction):
- * kjs/PrototypeFunction.h:
- * kjs/RegExpConstructor.cpp:
- (JSC::RegExpConstructor::RegExpConstructor):
- (JSC::RegExpMatchesArray::RegExpMatchesArray):
- (JSC::constructRegExp):
- * kjs/RegExpConstructor.h:
- * kjs/RegExpObject.cpp:
- (JSC::RegExpObject::RegExpObject):
- * kjs/RegExpObject.h:
- * kjs/RegExpPrototype.cpp:
- (JSC::RegExpPrototype::RegExpPrototype):
- * kjs/RegExpPrototype.h:
- * kjs/Shell.cpp:
- (GlobalObject::GlobalObject):
- * kjs/StringConstructor.cpp:
- (JSC::StringConstructor::StringConstructor):
- (JSC::constructWithStringConstructor):
- * kjs/StringConstructor.h:
- * kjs/StringObject.cpp:
- (JSC::StringObject::StringObject):
- * kjs/StringObject.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- * kjs/StringPrototype.cpp:
- (JSC::StringPrototype::StringPrototype):
- * kjs/StringPrototype.h:
- Take and pass structures.
-
-2008-09-19 Alp Toker <alp@nuanti.com>
-
- Build fix for the 'gold' linker and recent binutils. New behaviour
- requires that we link to used libraries explicitly.
-
- * GNUmakefile.am:
-
-2008-09-19 Sam Weinig <sam@webkit.org>
-
- Roll r36694 back in. It did not cause the crash.
-
- * JavaScriptCore.exp:
- * VM/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::invalidate):
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::create):
- * kjs/JSObject.cpp:
- (JSC::JSObject::getPropertyNames):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::getEnumerablePropertyNames):
- * kjs/PropertyMap.h:
- * kjs/PropertyNameArray.cpp:
- (JSC::PropertyNameArray::add):
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArrayData::create):
- (JSC::PropertyNameArrayData::propertyNameVector):
- (JSC::PropertyNameArrayData::setCachedPrototypeChain):
- (JSC::PropertyNameArrayData::cachedPrototypeChain):
- (JSC::PropertyNameArrayData::begin):
- (JSC::PropertyNameArrayData::end):
- (JSC::PropertyNameArrayData::PropertyNameArrayData):
- (JSC::PropertyNameArray::PropertyNameArray):
- (JSC::PropertyNameArray::addKnownUnique):
- (JSC::PropertyNameArray::size):
- (JSC::PropertyNameArray::operator[]):
- (JSC::PropertyNameArray::begin):
- (JSC::PropertyNameArray::end):
- (JSC::PropertyNameArray::setData):
- (JSC::PropertyNameArray::data):
- (JSC::PropertyNameArray::releaseData):
- * kjs/StructureID.cpp:
- (JSC::structureIDChainsAreEqual):
- (JSC::StructureID::getEnumerablePropertyNames):
- (JSC::StructureID::clearEnumerationCache):
- (JSC::StructureID::createCachedPrototypeChain):
- * kjs/StructureID.h:
-
-2008-09-19 Sam Weinig <sam@webkit.org>
-
- Roll out r36694.
-
- * JavaScriptCore.exp:
- * VM/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::invalidate):
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::create):
- * kjs/JSObject.cpp:
- (JSC::JSObject::getPropertyNames):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::getEnumerablePropertyNames):
- * kjs/PropertyMap.h:
- * kjs/PropertyNameArray.cpp:
- (JSC::PropertyNameArray::add):
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArray::PropertyNameArray):
- (JSC::PropertyNameArray::addKnownUnique):
- (JSC::PropertyNameArray::begin):
- (JSC::PropertyNameArray::end):
- (JSC::PropertyNameArray::size):
- (JSC::PropertyNameArray::operator[]):
- (JSC::PropertyNameArray::releaseIdentifiers):
- * kjs/StructureID.cpp:
- (JSC::StructureID::getEnumerablePropertyNames):
- * kjs/StructureID.h:
- (JSC::StructureID::clearEnumerationCache):
-
-2008-09-19 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Improve peformance of local variable initialisation.
-
- Pull local and constant initialisation out of slideRegisterWindowForCall
- and into its own opcode. This allows the JIT to generate the initialisation
- code for a function directly into the instruction stream and so avoids a few
- branches on function entry.
-
- Results a 1% progression in SunSpider, particularly in a number of the bitop
- tests where the called functions are very fast.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitInitialiseRegister):
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::CodeGenerator):
- * VM/Machine.cpp:
- (JSC::slideRegisterWindowForCall):
- (JSC::Machine::privateExecute):
- * VM/Opcode.h:
-
-2008-09-19 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=20928
- Speed up JS property enumeration by caching entire PropertyNameArray
-
- 1.3% speedup on Sunspider, 30% on string-fasta.
-
- * JavaScriptCore.exp:
- * VM/JSPropertyNameIterator.cpp:
- (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::invalidate):
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- (JSC::JSPropertyNameIterator::create):
- * kjs/JSObject.cpp:
- (JSC::JSObject::getPropertyNames):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::getEnumerablePropertyNames):
- * kjs/PropertyMap.h:
- * kjs/PropertyNameArray.cpp:
- (JSC::PropertyNameArray::add):
- * kjs/PropertyNameArray.h:
- (JSC::PropertyNameArrayData::create):
- (JSC::PropertyNameArrayData::propertyNameVector):
- (JSC::PropertyNameArrayData::setCachedPrototypeChain):
- (JSC::PropertyNameArrayData::cachedPrototypeChain):
- (JSC::PropertyNameArrayData::begin):
- (JSC::PropertyNameArrayData::end):
- (JSC::PropertyNameArrayData::PropertyNameArrayData):
- (JSC::PropertyNameArray::PropertyNameArray):
- (JSC::PropertyNameArray::addKnownUnique):
- (JSC::PropertyNameArray::size):
- (JSC::PropertyNameArray::operator[]):
- (JSC::PropertyNameArray::begin):
- (JSC::PropertyNameArray::end):
- (JSC::PropertyNameArray::setData):
- (JSC::PropertyNameArray::data):
- (JSC::PropertyNameArray::releaseData):
- * kjs/ScopeChain.cpp:
- (JSC::ScopeChainNode::print):
- * kjs/StructureID.cpp:
- (JSC::structureIDChainsAreEqual):
- (JSC::StructureID::getEnumerablePropertyNames):
- (JSC::StructureID::clearEnumerationCache):
- (JSC::StructureID::createCachedPrototypeChain):
- * kjs/StructureID.h:
-
-2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Maciej Stachowiak.
-
- Fix a mismatched new[]/delete in JSObject::allocatePropertyStorage
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::allocatePropertyStorage): Spotted by valgrind.
-
-2008-09-19 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- * JavaScriptCore.exp: Exported constructEmptyObject for use in WebCore.
-
- * kjs/JSGlobalObject.h: Changed the protected constructor to take a
- structure instead of a prototype.
-
- * kjs/JSVariableObject.h: Removed constructor that takes a prototype.
-
-2008-09-19 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Use the template hoisting technique on the RefCounted class. This reduces the code bloat due to
- non-template methods' code been copied for each instance of the template.
- The patch splits RefCounted between a base class that holds non-template methods and attributes
- and the template RefCounted class that keeps the same functionnality.
-
- On my Linux with gcc 4.3 for the Gtk port, this is:
- - a ~600KB save on libwebkit.so in release.
- - a ~1.6MB save on libwebkit.so in debug.
-
- It is a wash on Sunspider and a small win on Dromaeo (not sure it is relevant).
- On the whole, it should be a small win as we reduce the compiled code size and the only
- new function call should be inlined by the compiler.
-
- * wtf/RefCounted.h:
- (WTF::RefCountedBase::ref): Copied from RefCounted.
- (WTF::RefCountedBase::hasOneRef): Ditto.
- (WTF::RefCountedBase::refCount): Ditto.
- (WTF::RefCountedBase::RefCountedBase): Ditto.
- (WTF::RefCountedBase::~RefCountedBase): Ditto.
- (WTF::RefCountedBase::derefBase): Tweaked from the RefCounted version to remove
- template section.
- (WTF::RefCounted::RefCounted):
- (WTF::RefCounted::deref): Small wrapper around RefCountedBase::derefBase().
- (WTF::RefCounted::~RefCounted): Keep private destructor.
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- * kjs/lookup.h: Removed things here that were used only in WebCore:
- cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE,
- and JSC_IMPLEMENT_PROTOTYPE.
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20927
- simplify/streamline the code to turn strings into identifiers while parsing
-
- * kjs/grammar.y: Get rid of string from the union, and use ident for STRING as
- well as for IDENT.
-
- * kjs/lexer.cpp:
- (JSC::Lexer::lex): Use makeIdentifier instead of makeUString for String.
- * kjs/lexer.h: Remove makeUString.
-
- * kjs/nodes.h: Changed StringNode to hold an Identifier instead of UString.
-
- * VM/CodeGenerator.cpp:
- (JSC::keyForCharacterSwitch): Updated since StringNode now holds an Identifier.
- (JSC::prepareJumpTableForStringSwitch): Ditto.
- * kjs/nodes.cpp:
- (JSC::StringNode::emitCode): Ditto. The comment from here is now in the lexer.
- (JSC::processClauseList): Ditto.
- * kjs/nodes2string.cpp:
- (JSC::StringNode::streamTo): Ditto.
-
-2008-09-18 Sam Weinig <sam@webkit.org>
-
- Fix style.
-
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
-
-2008-09-18 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
- Bug 20911: REGRESSION(r36480?): Reproducible assertion failure below derefStructureIDs 64-bit JavaScriptCore
- <https://bugs.webkit.org/show_bug.cgi?id=20911>
+2009-06-17 George Staikos <george.staikos@torchmobile.com>
- The problem was simply caused by the int constructor for Instruction
- failing to initialise the full struct in 64bit builds.
-
- * VM/Instruction.h:
- (JSC::Instruction::Instruction):
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- - fix release build
-
- * wtf/RefCountedLeakCounter.cpp: Removed stray "static".
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- * kjs/JSGlobalObject.h: Tiny style guideline tweak.
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20925
- LEAK messages appear every time I quit
-
- * JavaScriptCore.exp: Updated, and also added an export
- needed for future WebCore use of JSC::StructureID.
-
- * wtf/RefCountedLeakCounter.cpp:
- (WTF::RefCountedLeakCounter::suppressMessages): Added.
- (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added.
- (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit.
- (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to
- log the reason there was no leak checking done.
- (WTF::RefCountedLeakCounter::increment): Tweaked a bit.
- (WTF::RefCountedLeakCounter::decrement): Ditto.
-
- * wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two
- new functions, suppressMessages and cancelMessageSuppression. Also
- added m_ prefixes to the data member names.
-
-2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=20437
-
- Add a proper #define to define which XML Parser implementation to use. Client
- code can use #if USE(QXMLSTREAM) to decide if the Qt XML StreamReader
- implementation is going to be used.
-
- * wtf/Platform.h:
-
-2008-09-18 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Make a Unicode non-breaking space count as a whitespace character in
- PCRE. This change was already made in WREC, and it fixes one of the
- Mozilla JS tests. Since it is now fixed in PCRE as well, we can check
- in a new set of expected test results.
-
- * pcre/pcre_internal.h:
- (isSpaceChar):
- * tests/mozilla/expected.html:
-
-2008-09-18 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Mark Rowe and Maciej Stachowiak.
-
- add an option use arch to specify which architecture to run.
-
- * tests/mozilla/jsDriver.pl:
-
-2008-09-17 Oliver Hunt <oliver@apple.com>
-
- Correctly restore argument reference prior to SFX runtime calls.
-
- Reviewed by Steve Falkenburg.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
-
-2008-09-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20876: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
- <https://bugs.webkit.org/show_bug.cgi?id=20876>
-
- r36417 and r36427 caused an get_by_id opcode to be emitted before the
- instanceof and construct opcodes, in order to enable inline caching of
- the prototype property. Unfortunately, this regressed some tests dealing
- with exceptions thrown by 'instanceof' and the 'new' operator. We fix
- these problems by detecting whether an "is not an object" exception is
- thrown before op_instanceof or op_construct, and emit the proper
- exception in those cases.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitConstruct):
- * VM/CodeGenerator.h:
- * VM/ExceptionHelpers.cpp:
- (JSC::createInvalidParamError):
- (JSC::createNotAConstructorError):
- (JSC::createNotAnObjectError):
- * VM/ExceptionHelpers.h:
- * VM/Machine.cpp:
- (JSC::Machine::getOpcode):
- (JSC::Machine::privateExecute):
- * VM/Machine.h:
- * kjs/nodes.cpp:
- (JSC::NewExprNode::emitCode):
- (JSC::InstanceOfNode::emitCode):
-
-2008-09-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- JIT generation cti_op_construct_verify.
-
- Quarter to half percent progression on v8-tests.
- Roughly not change on SunSpider (possible minor progression).
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/Machine.cpp:
- * VM/Machine.h:
-
-2008-09-15 Steve Falkenburg <sfalken@apple.com>
-
- Improve timer accuracy for JavaScript Date object on Windows.
-
- Use a combination of ftime and QueryPerformanceCounter.
- ftime returns the information we want, but doesn't have sufficient resolution.
- QueryPerformanceCounter has high resolution, but is only usable to measure time intervals.
- To combine them, we call ftime and QueryPerformanceCounter initially. Later calls will use
- QueryPerformanceCounter by itself, adding the delta to the saved ftime. We re-sync to
- correct for drift if the low-res and high-res elapsed time between calls differs by more
- than twice the low-resolution timer resolution.
-
- QueryPerformanceCounter may be inaccurate due to a problems with:
- - some PCI bridge chipsets (http://support.microsoft.com/kb/274323)
- - BIOS bugs (http://support.microsoft.com/kb/895980/)
- - BIOS/HAL bugs on multiprocessor/multicore systems (http://msdn.microsoft.com/en-us/library/ms644904.aspx)
-
- Reviewed by Darin Adler.
-
- * kjs/DateMath.cpp:
- (JSC::highResUpTime):
- (JSC::lowResUTCTime):
- (JSC::qpcAvailable):
- (JSC::getCurrentUTCTimeWithMicroseconds):
-
-2008-09-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Implement JIT generation of CallFrame initialization, for op_call.
-
- 1% sunspider 2.5% v8-tests.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_op_call_NotJSFunction):
-
-2008-09-17 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Optimizations for op_call in CTI. Move check for (ctiCode == 0) into JIT code,
- move copying of scopeChain for CodeBlocks that needFullScopeChain into head of
- functions, instead of checking prior to making the call.
-
- 3% on v8-tests (4% on richards, 6% in delta-blue)
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- * VM/Machine.cpp:
- (JSC::Machine::execute):
- (JSC::Machine::cti_op_call_JSFunction):
- (JSC::Machine::cti_vm_compile):
- (JSC::Machine::cti_vm_updateScopeChain):
- (JSC::Machine::cti_op_construct_JSConstruct):
- * VM/Machine.h:
-
-2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Fix the QtWebKit/Mac build
-
- * wtf/ThreadingQt.cpp:
- (WTF::initializeThreading): use QCoreApplication to get the main thread
-
-2008-09-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20857: REGRESSION (r36427): ASSERTION FAILED: m_refCount >= 0 in RegisterID::deref()
- <https://bugs.webkit.org/show_bug.cgi?id=20857>
-
- Fix a problem stemming from the slightly unsafe behaviour of the
- CodeGenerator::finalDestination() method by putting the "func" argument
- of the emitConstruct() method in a RefPtr in its caller. Also, add an
- assertion guaranteeing that this is always the case.
-
- CodeGenerator::finalDestination() is still incorrect and can cause
- problems with a different allocator; see bug 20340 for more details.
-
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitConstruct):
- * kjs/nodes.cpp:
- (JSC::NewExprNode::emitCode):
-
-2008-09-16 Alice Liu <alice.liu@apple.com>
-
- build fix.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
-
-2008-09-16 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- CTI code generation for op_ret. The majority of the work
- (updating variables on the stack & on exec) can be performed
- directly in generated code.
-
- We still need to check, & to call out to C-code to handle
- activation records, profiling, and full scope chains.
-
- +1.5% Sunspider, +5/6% v8 tests.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_ret_activation):
- (JSC::Machine::cti_op_ret_profiler):
- (JSC::Machine::cti_op_ret_scopeChain):
- * VM/Machine.h:
-
-2008-09-16 Dimitri Glazkov <dglazkov@chromium.org>
-
- Fix the Windows build.
-
- Add some extra parentheses to stop MSVC from complaining so much.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- * kjs/operations.cpp:
- (JSC::strictEqual):
-
-2008-09-15 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - speed up the === and !== operators by choosing the fast cases better
-
- No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_stricteq):
- (JSC::Machine::cti_op_nstricteq):
- * kjs/JSImmediate.h:
- (JSC::JSImmediate::areBothImmediate):
- * kjs/operations.cpp:
- (JSC::strictEqual):
- (JSC::strictEqualSlowCase):
- * kjs/operations.h:
-
-2008-09-15 Oliver Hunt <oliver@apple.com>
-
- RS=Sam Weinig.
-
- Coding style cleanup.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
-
-2008-09-15 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 20874: op_resolve does not do any form of caching
- <https://bugs.webkit.org/show_bug.cgi?id=20874>
-
- This patch adds an op_resolve_global opcode to handle (and cache)
- property lookup we can statically determine must occur on the global
- object (if at all).
-
- 3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
- 10% in math-partial-sums
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::findScopedProperty):
- (JSC::CodeGenerator::emitResolve):
- * VM/Machine.cpp:
- (JSC::resolveGlobal):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_resolve_global):
- * VM/Machine.h:
- * VM/Opcode.h:
-
-2008-09-15 Sam Weinig <sam@webkit.org>
-
- Roll out r36462. It broke document.all.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::Machine):
- (JSC::Machine::cti_op_eq_null):
- (JSC::Machine::cti_op_neq_null):
- * VM/Machine.h:
- (JSC::Machine::isJSString):
- * kjs/JSCell.h:
- * kjs/JSWrapperObject.h:
- * kjs/StringObject.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
-
-2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
- <https://bugs.webkit.org/show_bug.cgi?id=20863>
-
- r36427 changed the number of arguments to op_construct without changing
- the argument index for the vPC in the call to initializeCallFrame() in
- the CTI case. This caused a JSC test failure. Correcting the argument
- index fixes the test failure.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_construct_JSConstruct):
-
-2008-09-15 Mark Rowe <mrowe@apple.com>
-
- Fix GCC 4.2 build.
-
- * VM/CTI.h:
-
-2008-09-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Fixed a typo in op_get_by_id_chain that caused it to miss every time
- in the interpreter.
-
- Also, a little cleanup.
-
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): Set up baseObject before entering the
- loop, so we compare against the right values.
-
-2008-09-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Removed the CalledAsConstructor flag from the call frame header. Now,
- we use an explicit opcode at the call site to fix up constructor results.
-
- SunSpider says 0.4% faster.
-
- cti_op_construct_verify is an out-of-line function call for now, but we
- can fix that once StructureID holds type information like isObject.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
-
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
-
- * VM/CodeGenerator.cpp: Codegen for the new opcode. Also...
- (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value.
- (JSC::CodeGenerator::emitConstruct): ... ditto.
-
- * VM/Machine.cpp: No more CalledAsConstructor
- (JSC::Machine::privateExecute): Implementation for the new opcode.
- (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were
- called as a constructor.
- (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
- * VM/Machine.h:
-
- * VM/Opcode.h: Declare new opcode.
-
- * VM/RegisterFile.h:
- (JSC::RegisterFile::): No more CalledAsConstructor
-
-2008-09-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
- StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
- masquerading may be handled differently (through the StructureIDs - see bug
- #20823).
-
- >1% on v8-tests.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitJumpSlowCaseIfIsJSCell):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (JSC::Machine::Machine):
- (JSC::Machine::cti_op_eq_null):
- (JSC::Machine::cti_op_neq_null):
- * VM/Machine.h:
- (JSC::Machine::doesMasqueradesAsUndefined):
- * kjs/JSWrapperObject.h:
- (JSC::JSWrapperObject::):
- (JSC::JSWrapperObject::JSWrapperObject):
- * kjs/StringObject.h:
- (JSC::StringObject::StringObject):
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
-
-2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Oliver Hunt.
-
- r36427 broke CodeBlock::dump() by changing the number of arguments to
- op_construct without changing the code that prints it. This patch fixes
- it by printing the additional argument.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
-
-2008-09-15 Adam Roben <aroben@apple.com>
-
- Build fix
-
- * kjs/StructureID.cpp: Removed a stray semicolon.
-
-2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Fix a crash in fast/js/exception-expression-offset.html caused by not
- updating all mentions of the length of op_construct in r36427.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_construct_NotJSConstruct):
-
-2008-09-15 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix layout test failure introduced by fix for 20849
-
- (The failing test was fast/js/delete-then-put.html)
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::removeDirect): Clear enumeration cache
- in the dictionary case.
- * kjs/JSObject.h:
- (JSC::JSObject::putDirect): Ditto.
- * kjs/StructureID.h:
- (JSC::StructureID::clearEnumerationCache): Inline to handle the
- clear.
-
-2008-09-15 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - fix JSC test failures introduced by fix for 20849
-
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
-
-2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
- <https://bugs.webkit.org/show_bug.cgi?id=20851>
-
- r36410 introduced an optimization for parseInt() that is incorrect when
- its argument is larger than the range of a 32-bit integer. If the
- argument is a number that is not an immediate integer, then the correct
- behaviour is to return the floor of its value, unless it is an infinite
- value, in which case the correct behaviour is to return 0.
-
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt):
-
-2008-09-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
- Cache property names for getEnumerablePropertyNames in the StructureID.
-
- ~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
- on the v8 test suite.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::getPropertyNames):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::getEnumerablePropertyNames):
- * kjs/PropertyMap.h:
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::getEnumerablePropertyNames):
- * kjs/StructureID.h:
-
-2008-09-14 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - speed up JS construction by extracting "prototype" lookup so PIC applies.
-
- ~0.5% speedup on SunSpider
- Speeds up some of the V8 tests as well, most notably earley-boyer.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileOpCall): Account for extra arg for prototype.
- (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): Expect prototype arg in op_construct.
- (JSC::Machine::cti_op_construct_JSConstruct): ditto
- (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
-
-2008-09-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Add a protected destructor for RefCounted.
-
- It is wrong to call its destructor directly, because (1) this should be taken care of by
- deref(), and (2) many classes that use RefCounted have non-virtual destructors.
-
- No change in behavior.
-
- * wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
-
-2008-09-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Accelerated property accesses.
-
- Inline more of the array access code into the JIT code for get/put_by_val.
- Accelerate get/put_by_id by speculatively inlining a disable direct access
- into the hot path of the code, and repatch this with the correct StructureID
- and property map offset once these are known. In the case of accesses to the
- prototype and reading the array-length a trampoline is genertaed, and the
- branch to the slow-case is relinked to jump to this.
-
- By repatching, we mean rewriting the x86 instruction stream. Instructions are
- only modified in a simple fasion - altering immediate operands, memory access
- deisplacements, and branch offsets.
-
- For regular get_by_id/put_by_id accesses to an object, a StructureID in an
- instruction's immediate operant is updateded, and a memory access operation's
- displacement is updated to access the correct field on the object. In the case
- of more complex accesses (array length and get_by_id_prototype) the offset on
- the branch to slow-case is updated, to now jump to a trampoline.
-
- +2.8% sunspider, +13% v8-tests
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCall):
- (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
- (JSC::CTI::CTI):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateCompilePutByIdTransition):
- (JSC::CTI::privateCompileArrayLengthTrampoline):
- (JSC::CTI::privateCompileStringLengthTrampoline):
- (JSC::CTI::patchGetByIdSelf):
- (JSC::CTI::patchPutByIdReplace):
- (JSC::CTI::privateCompilePatchGetArrayLength):
- (JSC::CTI::privateCompilePatchGetStringLength):
- * VM/CTI.h:
- (JSC::CTI::compileGetByIdSelf):
- (JSC::CTI::compileGetByIdProto):
- (JSC::CTI::compileGetByIdChain):
- (JSC::CTI::compilePutByIdReplace):
- (JSC::CTI::compilePutByIdTransition):
- (JSC::CTI::compileArrayLengthTrampoline):
- (JSC::CTI::compileStringLengthTrampoline):
- (JSC::CTI::compilePatchGetArrayLength):
- (JSC::CTI::compilePatchGetStringLength):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::~CodeBlock):
- * VM/CodeBlock.h:
- (JSC::StructureStubInfo::StructureStubInfo):
- (JSC::CodeBlock::getStubInfo):
- * VM/Machine.cpp:
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::tryCTICacheGetByID):
- (JSC::Machine::cti_op_put_by_val_array):
- * VM/Machine.h:
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::cmpl_i8m):
- (JSC::X86Assembler::emitUnlinkedJa):
- (JSC::X86Assembler::getRelocatedAddress):
- (JSC::X86Assembler::getDifferenceBetweenLabels):
- (JSC::X86Assembler::emitModRm_opmsib):
-
-2008-09-14 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - split the "prototype" lookup for hasInstance into opcode stream so it can be cached
-
- ~5% speedup on v8 earley-boyer test
-
- * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- * API/JSCallbackObjectFunctions.h:
- (JSC::::hasInstance): Ditto.
- * API/JSValueRef.cpp:
- (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass): Pass along prototype.
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump): Print third arg.
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
- is a third argument.
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute): Pass along the prototype.
- (JSC::Machine::cti_op_instanceof): ditto
- * kjs/JSObject.cpp:
- (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- * kjs/JSObject.h:
- * kjs/nodes.cpp:
- (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
- property and pass that register to instanceof.
- * kjs/nodes.h:
-
-2008-09-14 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove unnecessary virtual function call from cti_op_call_JSFunction -
- ~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
-
- * VM/Machine.cpp:
- (JSC::Machine::cti_op_call_JSFunction):
-
-2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20827: the 'typeof' operator is slow
- <https://bugs.webkit.org/show_bug.cgi?id=20827>
-
- Optimize the 'typeof' operator when its result is compared to a constant
- string.
-
- This is a 5.5% speedup on the V8 Earley-Boyer test.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitEqualityOp):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::jsIsObjectType):
- (JSC::jsIsFunctionType):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_is_undefined):
- (JSC::Machine::cti_op_is_boolean):
- (JSC::Machine::cti_op_is_number):
- (JSC::Machine::cti_op_is_string):
- (JSC::Machine::cti_op_is_object):
- (JSC::Machine::cti_op_is_function):
- * VM/Machine.h:
- * VM/Opcode.h:
- * kjs/nodes.cpp:
- (JSC::BinaryOpNode::emitCode):
- (JSC::EqualNode::emitCode):
- (JSC::StrictEqualNode::emitCode):
- * kjs/nodes.h:
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
- Speed up parseInt for numbers
-
- Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
- No change on the v8 suite.
-
- * kjs/JSGlobalObjectFunctions.cpp:
- (JSC::globalFuncParseInt): Don't convert numbers to strings just to
- convert them back to numbers.
-
-2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20816: op_lesseq should be optimized
- <https://bugs.webkit.org/show_bug.cgi?id=20816>
-
- Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.
-
- This is a 9.4% speedup on the V8 Crypto benchmark.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitJumpIfTrue):
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_loop_if_lesseq):
- * VM/Machine.h:
- * VM/Opcode.h:
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Cleanup Sampling code.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitCall):
- (JSC::CTI::privateCompileMainPass):
- * VM/CTI.h:
- (JSC::CTI::execute):
- * VM/SamplingTool.cpp:
- (JSC::):
- (JSC::SamplingTool::run):
- (JSC::SamplingTool::dump):
- * VM/SamplingTool.h:
- (JSC::SamplingTool::callingHostFunction):
-
-2008-09-13 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 20821: Cache property transitions to speed up object initialization
- https://bugs.webkit.org/show_bug.cgi?id=20821
-
- Implement a transition cache to improve the performance of new properties
- being added to objects. This is extremely beneficial in constructors and
- shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
- overall)
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::):
- (JSC::transitionWillNeedStorageRealloc):
- (JSC::CTI::privateCompilePutByIdTransition):
- * VM/CTI.h:
- (JSC::CTI::compilePutByIdTransition):
- * VM/CodeBlock.cpp:
- (JSC::printPutByIdOp):
- (JSC::CodeBlock::printStructureIDs):
- (JSC::CodeBlock::dump):
- (JSC::CodeBlock::derefStructureIDs):
- (JSC::CodeBlock::refStructureIDs):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::emitPutById):
- * VM/Machine.cpp:
- (JSC::cachePrototypeChain):
- (JSC::Machine::tryCachePutByID):
- (JSC::Machine::tryCacheGetByID):
- (JSC::Machine::privateExecute):
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::tryCTICacheGetByID):
- * VM/Machine.h:
- * VM/Opcode.h:
- * kjs/JSObject.h:
- (JSC::JSObject::putDirect):
- (JSC::JSObject::transitionTo):
- * kjs/PutPropertySlot.h:
- (JSC::PutPropertySlot::PutPropertySlot):
- (JSC::PutPropertySlot::wasTransition):
- (JSC::PutPropertySlot::setWasTransition):
- * kjs/StructureID.cpp:
- (JSC::StructureID::transitionTo):
- (JSC::StructureIDChain::StructureIDChain):
- * kjs/StructureID.h:
- (JSC::StructureID::previousID):
- (JSC::StructureID::setCachedPrototypeChain):
- (JSC::StructureID::cachedPrototypeChain):
- (JSC::StructureID::propertyMap):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::addl_i8m):
- (JSC::X86Assembler::subl_i8m):
-
-2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20819: JSValue::isObject() is slow
- <https://bugs.webkit.org/show_bug.cgi?id=20819>
-
- Optimize JSCell::isObject() and JSCell::isString() by making them
- non-virtual calls that rely on the StructureID type information.
-
- This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
- benchmark suite.
-
- * JavaScriptCore.exp:
- * kjs/JSCell.cpp:
- * kjs/JSCell.h:
- (JSC::JSCell::isObject):
- (JSC::JSCell::isString):
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- * kjs/JSString.cpp:
- * kjs/JSString.h:
- (JSC::JSString::JSString):
- * kjs/StructureID.h:
- (JSC::StructureID::type):
-
-2008-09-11 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
- crash on CNN and on Dromaeo.
- Fix Missing close tag in vcproj.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
-
-2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Not reviewed.
-
- Correct an SVN problem with the last commit and actually add the new
- files.
-
- * wrec/CharacterClassConstructor.cpp: Added.
- (JSC::):
- (JSC::getCharacterClassNewline):
- (JSC::getCharacterClassDigits):
- (JSC::getCharacterClassSpaces):
- (JSC::getCharacterClassWordchar):
- (JSC::getCharacterClassNondigits):
- (JSC::getCharacterClassNonspaces):
- (JSC::getCharacterClassNonwordchar):
- (JSC::CharacterClassConstructor::addSorted):
- (JSC::CharacterClassConstructor::addSortedRange):
- (JSC::CharacterClassConstructor::put):
- (JSC::CharacterClassConstructor::flush):
- (JSC::CharacterClassConstructor::append):
- * wrec/CharacterClassConstructor.h: Added.
- (JSC::CharacterClassConstructor::CharacterClassConstructor):
- (JSC::CharacterClassConstructor::isUpsideDown):
- (JSC::CharacterClassConstructor::charClass):
-
-2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20788: Split CharacterClassConstructor into its own file
- <https://bugs.webkit.org/show_bug.cgi?id=20788>
-
- Split CharacterClassConstructor into its own file and clean up some
- style issues.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * wrec/CharacterClassConstructor.cpp: Added.
- (JSC::):
- (JSC::getCharacterClassNewline):
- (JSC::getCharacterClassDigits):
- (JSC::getCharacterClassSpaces):
- (JSC::getCharacterClassWordchar):
- (JSC::getCharacterClassNondigits):
- (JSC::getCharacterClassNonspaces):
- (JSC::getCharacterClassNonwordchar):
- (JSC::CharacterClassConstructor::addSorted):
- (JSC::CharacterClassConstructor::addSortedRange):
- (JSC::CharacterClassConstructor::put):
- (JSC::CharacterClassConstructor::flush):
- (JSC::CharacterClassConstructor::append):
- * wrec/CharacterClassConstructor.h: Added.
- (JSC::CharacterClassConstructor::CharacterClassConstructor):
- (JSC::CharacterClassConstructor::isUpsideDown):
- (JSC::CharacterClassConstructor::charClass):
- * wrec/WREC.cpp:
- (JSC::WRECParser::parseCharacterClass):
-
-2008-09-10 Simon Hausmann <hausmann@webkit.org>
-
- Not reviewed but trivial one-liner for yet unused macro.
-
- Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.
-
- (part of https://bugs.webkit.org/show_bug.cgi?id=20746)
-
- * wtf/Platform.h:
-
-2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Oliver Hunt.
-
- Fix a typo by renaming the overloaded orl_rr that takes an immediate to
- orl_i32r.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::orl_i32r):
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generatePatternCharacter):
- (JSC::WRECGenerator::generateCharacterClassInverted):
-
-2008-09-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Add inline property storage for JSObject.
-
- 1.2% progression on Sunspider. .5% progression on the v8 test suite.
-
- * JavaScriptCore.exp:
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- * kjs/JSObject.cpp:
- (JSC::JSObject::mark): There is no reason to check storageSize now that
- we start from 0.
- (JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
- * kjs/JSObject.h:
- (JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr
- now so there is no reason to .get()
- (JSC::JSObject::usingInlineStorage):
- (JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the
- inline storage.
- (JSC::JSObject::~JSObject): Free the heap storage if not using the inline
- storage.
- (JSC::JSObject::putDirect): Switch to the heap storage only when we know
- we know that we are about to add a property that will overflow the inline
- storage.
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is
- now handled by JSObject.
- (JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
- * kjs/PropertyMap.h:
- (JSC::PropertyMap::storageSize): Rename from markingCount.
- * kjs/StructureID.cpp:
- (JSC::StructureID::addPropertyTransition): Don't resize the property storage
- if we are using inline storage.
- * kjs/StructureID.h:
-
-2008-09-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Inline immediate number version of op_mul.
-
- Renamed mull_rr to imull_rr as that's what it's
- actually doing, and added imull_i32r for the constant
- case immediate multiply.
-
- 1.1% improvement to SunSpider.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::):
- (JSC::X86Assembler::imull_rr):
- (JSC::X86Assembler::imull_i32r):
-
-2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Not reviewed.
-
- Mac build fix.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-09-09 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Add optimised access to known properties on the global object.
-
- Improve cross scope access to the global object by emitting
- code to access it directly rather than by walking the scope chain.
-
- This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::emitGetVariableObjectRegister):
- (JSC::CTI::emitPutVariableObjectRegister):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (JSC::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (JSC::CodeGenerator::findScopedProperty):
- (JSC::CodeGenerator::emitResolve):
- (JSC::CodeGenerator::emitGetScopedVar):
- (JSC::CodeGenerator::emitPutScopedVar):
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (JSC::Machine::privateExecute):
- * VM/Opcode.h:
- * kjs/nodes.cpp:
- (JSC::FunctionCallResolveNode::emitCode):
- (JSC::PostfixResolveNode::emitCode):
- (JSC::PrefixResolveNode::emitCode):
- (JSC::ReadModifyResolveNode::emitCode):
- (JSC::AssignResolveNode::emitCode):
-
-2008-09-10 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Oliver.
-
- - enable polymorphic inline caching of properties of primitives
-
- 1.012x speedup on SunSpider.
-
- We create special structure IDs for JSString and
- JSNumberCell. Unlike normal structure IDs, these cannot hold the
- true prototype. Due to JS autoboxing semantics, the prototype used
- when looking up string or number properties depends on the lexical
- global object of the call site, not the creation site. Thus we
- enable StructureIDs to handle this quirk for primitives.
-
- Everything else should be straightforward.
-
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- * VM/CTI.h:
- (JSC::CTI::compileGetByIdProto):
- (JSC::CTI::compileGetByIdChain):
- * VM/JSPropertyNameIterator.h:
- (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- * VM/Machine.cpp:
- (JSC::Machine::Machine):
- (JSC::cachePrototypeChain):
- (JSC::Machine::tryCachePutByID):
- (JSC::Machine::tryCacheGetByID):
- (JSC::Machine::privateExecute):
- (JSC::Machine::tryCTICachePutByID):
- (JSC::Machine::tryCTICacheGetByID):
- * kjs/GetterSetter.h:
- (JSC::GetterSetter::GetterSetter):
- * kjs/JSCell.h:
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.h:
- (JSC::StructureID::prototypeForLookup):
- * kjs/JSNumberCell.h:
- (JSC::JSNumberCell::JSNumberCell):
- (JSC::jsNumberCell):
- * kjs/JSObject.h:
- (JSC::JSObject::prototype):
- * kjs/JSString.cpp:
- (JSC::jsString):
- (JSC::jsSubstring):
- (JSC::jsOwnedString):
- * kjs/JSString.h:
- (JSC::JSString::JSString):
- (JSC::JSString::):
- (JSC::jsSingleCharacterString):
- (JSC::jsSingleCharacterSubstring):
- (JSC::jsNontrivialString):
- * kjs/SmallStrings.cpp:
- (JSC::SmallStrings::createEmptyString):
- (JSC::SmallStrings::createSingleCharacterString):
- * kjs/StructureID.cpp:
- (JSC::StructureID::StructureID):
- (JSC::StructureID::addPropertyTransition):
- (JSC::StructureID::getterSetterTransition):
- (JSC::StructureIDChain::StructureIDChain):
- * kjs/StructureID.h:
- (JSC::StructureID::create):
- (JSC::StructureID::storedPrototype):
-
-2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=20746
-
- Added WINCE platform macro.
-
- * wtf/Platform.h:
-
-2008-09-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Remove unnecessary override of getOffset.
-
- Sunspider reports this as a .6% progression.
-
- * JavaScriptCore.exp:
- * kjs/JSObject.h:
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::getOwnPropertySlotForWrite):
- (JSC::JSObject::putDirect):
- * kjs/PropertyMap.cpp:
- * kjs/PropertyMap.h:
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20759: Remove MacroAssembler
- <https://bugs.webkit.org/show_bug.cgi?id=20759>
-
- Remove MacroAssembler and move its functionality to X86Assembler.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::emitPutArg):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutResult):
- (JSC::CTI::emitDebugExceptionCheck):
- (JSC::CTI::emitJumpSlowCaseIfNotImm):
- (JSC::CTI::emitJumpSlowCaseIfNotImms):
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithReTagImmediate):
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- (JSC::CTI::emitFastArithImmToInt):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::emitFastArithIntToImmNoCheck):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateArrayLengthTrampoline):
- (JSC::CTI::privateStringLengthTrampoline):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- (JSC::CallRecord::CallRecord):
- (JSC::JmpTable::JmpTable):
- (JSC::SlowCaseEntry::SlowCaseEntry):
- (JSC::CTI::JSRInfo::JSRInfo):
- * masm/MacroAssembler.h: Removed.
- * masm/MacroAssemblerWin.cpp: Removed.
- * masm/X86Assembler.h:
- (JSC::X86Assembler::emitConvertToFastCall):
- (JSC::X86Assembler::emitRestoreArgumentReference):
- * wrec/WREC.h:
- (JSC::WRECGenerator::WRECGenerator):
- (JSC::WRECParser::WRECParser):
-
-2008-09-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Don't waste the first item in the PropertyStorage.
-
- - Fix typo (makingCount -> markingCount)
- - Remove undefined method declaration.
-
- No change on Sunspider.
-
- * kjs/JSObject.cpp:
- (JSC::JSObject::mark):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::put):
- (JSC::PropertyMap::remove):
- (JSC::PropertyMap::getOffset):
- (JSC::PropertyMap::insert):
- (JSC::PropertyMap::rehash):
- (JSC::PropertyMap::resizePropertyStorage):
- (JSC::PropertyMap::checkConsistency):
- * kjs/PropertyMap.h:
- (JSC::PropertyMap::markingCount): Fix typo.
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Not reviewed.
-
- Speculative Windows build fix.
-
- * masm/MacroAssemblerWin.cpp:
- (JSC::MacroAssembler::emitConvertToFastCall):
- (JSC::MacroAssembler::emitRestoreArgumentReference):
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20755: Create an X86 namespace for register names and other things
- <https://bugs.webkit.org/show_bug.cgi?id=20755>
-
- Create an X86 namespace to put X86 register names. Perhaps I will move
- opcode names here later as well.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::emitPutArg):
- (JSC::CTI::emitPutArgConstant):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutResult):
- (JSC::CTI::emitDebugExceptionCheck):
- (JSC::CTI::emitJumpSlowCaseIfNotImms):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateArrayLengthTrampoline):
- (JSC::CTI::privateStringLengthTrampoline):
- (JSC::CTI::compileRegExp):
- * VM/CTI.h:
- * masm/X86Assembler.h:
- (JSC::X86::):
- (JSC::X86Assembler::emitModRm_rm):
- (JSC::X86Assembler::emitModRm_rm_Unchecked):
- (JSC::X86Assembler::emitModRm_rmsib):
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generateNonGreedyQuantifier):
- (JSC::WRECGenerator::generateGreedyQuantifier):
- (JSC::WRECGenerator::generateParentheses):
- (JSC::WRECGenerator::generateBackreference):
- (JSC::WRECGenerator::gernerateDisjunction):
- * wrec/WREC.h:
-
-2008-09-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Remove unnecessary friend declaration.
-
- * kjs/PropertyMap.h:
-
-2008-09-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Replace uses of PropertyMap::get and PropertyMap::getLocation with
- PropertyMap::getOffset.
-
- Sunspider reports this as a .6% improvement.
-
- * JavaScriptCore.exp:
- * kjs/JSObject.cpp:
- (JSC::JSObject::put):
- (JSC::JSObject::deleteProperty):
- (JSC::JSObject::getPropertyAttributes):
- * kjs/JSObject.h:
- (JSC::JSObject::getDirect):
- (JSC::JSObject::getDirectLocation):
- (JSC::JSObject::locationForOffset):
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMap::remove):
- (JSC::PropertyMap::getOffset):
- * kjs/PropertyMap.h:
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Sam Weinig.
-
- Bug 20754: Remove emit prefix from assembler opcode methods
- <https://bugs.webkit.org/show_bug.cgi?id=20754>
-
- * VM/CTI.cpp:
- (JSC::CTI::emitGetArg):
- (JSC::CTI::emitGetPutArg):
- (JSC::CTI::emitPutArg):
- (JSC::CTI::emitPutArgConstant):
- (JSC::CTI::emitPutCTIParam):
- (JSC::CTI::emitGetCTIParam):
- (JSC::CTI::emitPutToCallFrameHeader):
- (JSC::CTI::emitGetFromCallFrameHeader):
- (JSC::CTI::emitPutResult):
- (JSC::CTI::emitDebugExceptionCheck):
- (JSC::CTI::emitCall):
- (JSC::CTI::emitJumpSlowCaseIfNotImm):
- (JSC::CTI::emitJumpSlowCaseIfNotImms):
- (JSC::CTI::emitFastArithDeTagImmediate):
- (JSC::CTI::emitFastArithReTagImmediate):
- (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
- (JSC::CTI::emitFastArithImmToInt):
- (JSC::CTI::emitFastArithIntToImmOrSlowCase):
- (JSC::CTI::emitFastArithIntToImmNoCheck):
- (JSC::CTI::compileOpCall):
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- (JSC::CTI::privateCompile):
- (JSC::CTI::privateCompileGetByIdSelf):
- (JSC::CTI::privateCompileGetByIdProto):
- (JSC::CTI::privateCompileGetByIdChain):
- (JSC::CTI::privateCompilePutByIdReplace):
- (JSC::CTI::privateArrayLengthTrampoline):
- (JSC::CTI::privateStringLengthTrampoline):
- (JSC::CTI::compileRegExp):
- * masm/MacroAssemblerWin.cpp:
- (JSC::MacroAssembler::emitConvertToFastCall):
- (JSC::MacroAssembler::emitRestoreArgumentReference):
- * masm/X86Assembler.h:
- (JSC::X86Assembler::pushl_r):
- (JSC::X86Assembler::pushl_m):
- (JSC::X86Assembler::popl_r):
- (JSC::X86Assembler::popl_m):
- (JSC::X86Assembler::movl_rr):
- (JSC::X86Assembler::addl_rr):
- (JSC::X86Assembler::addl_i8r):
- (JSC::X86Assembler::addl_i32r):
- (JSC::X86Assembler::addl_mr):
- (JSC::X86Assembler::andl_rr):
- (JSC::X86Assembler::andl_i32r):
- (JSC::X86Assembler::cmpl_i8r):
- (JSC::X86Assembler::cmpl_rr):
- (JSC::X86Assembler::cmpl_rm):
- (JSC::X86Assembler::cmpl_i32r):
- (JSC::X86Assembler::cmpl_i32m):
- (JSC::X86Assembler::cmpw_rm):
- (JSC::X86Assembler::orl_rr):
- (JSC::X86Assembler::subl_rr):
- (JSC::X86Assembler::subl_i8r):
- (JSC::X86Assembler::subl_i32r):
- (JSC::X86Assembler::subl_mr):
- (JSC::X86Assembler::testl_i32r):
- (JSC::X86Assembler::testl_rr):
- (JSC::X86Assembler::xorl_i8r):
- (JSC::X86Assembler::xorl_rr):
- (JSC::X86Assembler::sarl_i8r):
- (JSC::X86Assembler::sarl_CLr):
- (JSC::X86Assembler::shl_i8r):
- (JSC::X86Assembler::shll_CLr):
- (JSC::X86Assembler::mull_rr):
- (JSC::X86Assembler::idivl_r):
- (JSC::X86Assembler::cdq):
- (JSC::X86Assembler::movl_mr):
- (JSC::X86Assembler::movzwl_mr):
- (JSC::X86Assembler::movl_rm):
- (JSC::X86Assembler::movl_i32r):
- (JSC::X86Assembler::movl_i32m):
- (JSC::X86Assembler::leal_mr):
- (JSC::X86Assembler::ret):
- (JSC::X86Assembler::jmp_r):
- (JSC::X86Assembler::jmp_m):
- (JSC::X86Assembler::call_r):
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generateBacktrack1):
- (JSC::WRECGenerator::generateBacktrackBackreference):
- (JSC::WRECGenerator::generateBackreferenceQuantifier):
- (JSC::WRECGenerator::generateNonGreedyQuantifier):
- (JSC::WRECGenerator::generateGreedyQuantifier):
- (JSC::WRECGenerator::generatePatternCharacter):
- (JSC::WRECGenerator::generateCharacterClassInvertedRange):
- (JSC::WRECGenerator::generateCharacterClassInverted):
- (JSC::WRECGenerator::generateCharacterClass):
- (JSC::WRECGenerator::generateParentheses):
- (JSC::WRECGenerator::gererateParenthesesResetTrampoline):
- (JSC::WRECGenerator::generateAssertionBOL):
- (JSC::WRECGenerator::generateAssertionEOL):
- (JSC::WRECGenerator::generateAssertionWordBoundary):
- (JSC::WRECGenerator::generateBackreference):
- (JSC::WRECGenerator::gernerateDisjunction):
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Clean up the WREC code some more.
-
- * VM/CTI.cpp:
- (JSC::CTI::compileRegExp):
- * wrec/WREC.cpp:
- (JSC::getCharacterClassNewline):
- (JSC::getCharacterClassDigits):
- (JSC::getCharacterClassSpaces):
- (JSC::getCharacterClassWordchar):
- (JSC::getCharacterClassNondigits):
- (JSC::getCharacterClassNonspaces):
- (JSC::getCharacterClassNonwordchar):
- (JSC::WRECGenerator::generateBacktrack1):
- (JSC::WRECGenerator::generateBacktrackBackreference):
- (JSC::WRECGenerator::generateBackreferenceQuantifier):
- (JSC::WRECGenerator::generateNonGreedyQuantifier):
- (JSC::WRECGenerator::generateGreedyQuantifier):
- (JSC::WRECGenerator::generatePatternCharacter):
- (JSC::WRECGenerator::generateCharacterClassInvertedRange):
- (JSC::WRECGenerator::generateCharacterClassInverted):
- (JSC::WRECGenerator::generateCharacterClass):
- (JSC::WRECGenerator::generateParentheses):
- (JSC::WRECGenerator::gererateParenthesesResetTrampoline):
- (JSC::WRECGenerator::generateAssertionBOL):
- (JSC::WRECGenerator::generateAssertionEOL):
- (JSC::WRECGenerator::generateAssertionWordBoundary):
- (JSC::WRECGenerator::generateBackreference):
- (JSC::WRECGenerator::gernerateDisjunction):
- (JSC::WRECParser::parseCharacterClass):
- (JSC::WRECParser::parseEscape):
- (JSC::WRECParser::parseTerm):
- * wrec/WREC.h:
-
-2008-09-09 Mark Rowe <mrowe@apple.com>
-
- Build fix, rubber-stamped by Anders Carlsson.
-
- Silence spurious build warnings about missing format attributes on functions in Assertions.cpp.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-09-09 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Fix builds using the "debug" variant.
-
- This reverts r36130 and tweaks Identifier to export the same symbols for Debug
- and Release configurations.
-
- * Configurations/JavaScriptCore.xcconfig:
- * DerivedSources.make:
- * JavaScriptCore.Debug.exp: Removed.
- * JavaScriptCore.base.exp: Removed.
- * JavaScriptCore.exp: Added.
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/identifier.cpp:
- (JSC::Identifier::addSlowCase): #ifdef the call to checkSameIdentifierTable so that
- there is no overhead in Release builds.
- (JSC::Identifier::checkSameIdentifierTable): Add empty functions for Release builds.
- * kjs/identifier.h:
- (JSC::Identifier::add): #ifdef the calls to checkSameIdentifierTable so that there is
- no overhead in Release builds, and remove the inline definitions of checkSameIdentifierTable.
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Clean up WREC a bit to bring it closer to our coding style guidelines.
-
- * wrec/WREC.cpp:
- (JSC::):
- (JSC::getCharacterClass_newline):
- (JSC::getCharacterClass_d):
- (JSC::getCharacterClass_s):
- (JSC::getCharacterClass_w):
- (JSC::getCharacterClass_D):
- (JSC::getCharacterClass_S):
- (JSC::getCharacterClass_W):
- (JSC::CharacterClassConstructor::append):
- (JSC::WRECGenerator::generateNonGreedyQuantifier):
- (JSC::WRECGenerator::generateGreedyQuantifier):
- (JSC::WRECGenerator::generateCharacterClassInverted):
- (JSC::WRECParser::parseQuantifier):
- (JSC::WRECParser::parsePatternCharacterQualifier):
- (JSC::WRECParser::parseCharacterClassQuantifier):
- (JSC::WRECParser::parseBackreferenceQuantifier):
- * wrec/WREC.h:
- (JSC::Quantifier::):
- (JSC::Quantifier::Quantifier):
-
-2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Try MIME charset names before trying IANA names
- ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
-
- * wtf/StringExtras.h: (strcasecmp): Added.
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Mark Rowe.
-
- Bug 20719: REGRESSION (r36135-36244): Hangs, then crashes after several seconds
- <https://bugs.webkit.org/show_bug.cgi?id=20719>
- <rdar://problem/6205787>
-
- Fix a typo in the case-insensitive matching of character patterns.
-
- * wrec/WREC.cpp:
- (JSC::WRECGenerator::generatePatternCharacter):
-
-2008-09-09 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Sam Weinig.
-
- - allow polymorphic inline cache to handle Math object functions and possibly other similar things
-
- 1.012x speedup on SunSpider.
-
- * kjs/MathObject.cpp:
- (JSC::MathObject::getOwnPropertySlot):
- * kjs/lookup.cpp:
- (JSC::setUpStaticFunctionSlot):
- * kjs/lookup.h:
- (JSC::getStaticPropertySlot):
-
-2008-09-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak and Oliver Hunt.
-
- Split storage of properties out of the PropertyMap and into the JSObject
- to allow sharing PropertyMap on the StructureID. In order to get this
- function correctly, the StructureID's transition mappings were changed to
- transition based on property name and attribute pairs, instead of just
- property name.
-
- - Removes the single property optimization now that the PropertyMap is shared.
- This will be replaced by in-lining some values on the JSObject.
-
- This is a wash on Sunspider and a 6.7% win on the v8 test suite.
-
- * JavaScriptCore.base.exp:
- * VM/CTI.cpp:
- (JSC::CTI::privateCompileGetByIdSelf): Get the storage directly off the JSObject.
- (JSC::CTI::privateCompileGetByIdProto): Ditto.
- (JSC::CTI::privateCompileGetByIdChain): Ditto.
- (JSC::CTI::privateCompilePutByIdReplace): Ditto.
- * kjs/JSObject.cpp:
- (JSC::JSObject::mark): Mark the PropertyStorage.
- (JSC::JSObject::put): Update to get the propertyMap of the StructureID.
- (JSC::JSObject::deleteProperty): Ditto.
- (JSC::JSObject::defineGetter): Return early if the property is already a getter/setter.
- (JSC::JSObject::defineSetter): Ditto.
- (JSC::JSObject::getPropertyAttributes): Update to get the propertyMap of the StructureID
- (JSC::JSObject::getPropertyNames): Ditto.
- (JSC::JSObject::removeDirect): Ditto.
- * kjs/JSObject.h: Remove PropertyMap and add PropertyStorage.
- (JSC::JSObject::propertyStorage): return the PropertyStorage.
- (JSC::JSObject::getDirect): Update to get the propertyMap of the StructureID.
- (JSC::JSObject::getDirectLocation): Ditto.
- (JSC::JSObject::offsetForLocation): Compute location directly.
- (JSC::JSObject::hasCustomProperties): Update to get the propertyMap of the StructureID.
- (JSC::JSObject::hasGetterSetterProperties): Ditto.
- (JSC::JSObject::getDirectOffset): Get by indexing into PropertyStorage.
- (JSC::JSObject::putDirectOffset): Put by indexing into PropertyStorage.
- (JSC::JSObject::getOwnPropertySlotForWrite): Update to get the propertyMap of the StructureID.
- (JSC::JSObject::getOwnPropertySlot): Ditto.
- (JSC::JSObject::putDirect): Move putting into the StructureID unless the property already exists.
- * kjs/PropertyMap.cpp: Use the propertyStorage as the storage for the JSValues.
- (JSC::PropertyMap::checkConsistency):
- (JSC::PropertyMap::operator=):
- (JSC::PropertyMap::~PropertyMap):
- (JSC::PropertyMap::get):
- (JSC::PropertyMap::getLocation):
- (JSC::PropertyMap::put):
- (JSC::PropertyMap::getOffset):
- (JSC::PropertyMap::insert):
- (JSC::PropertyMap::expand):
- (JSC::PropertyMap::rehash):
- (JSC::PropertyMap::createTable):
- (JSC::PropertyMap::resizePropertyStorage): Resize the storage to match the size of the map
- (JSC::PropertyMap::remove):
- (JSC::PropertyMap::getEnumerablePropertyNames):
- * kjs/PropertyMap.h:
- (JSC::PropertyMapEntry::PropertyMapEntry):
- (JSC::PropertyMap::isEmpty):
- (JSC::PropertyMap::size):
- (JSC::PropertyMap::makingCount):
- (JSC::PropertyMap::PropertyMap):
-
- * kjs/StructureID.cpp:
- (JSC::StructureID::addPropertyTransition): Transitions now are based off the property name
- and attributes.
- (JSC::StructureID::toDictionaryTransition): Copy the map.
- (JSC::StructureID::changePrototypeTransition): Copy the map.
- (JSC::StructureID::getterSetterTransition): Copy the map.
- (JSC::StructureID::~StructureID):
- * kjs/StructureID.h:
- (JSC::TransitionTableHash::hash): Custom hash for transition map.
- (JSC::TransitionTableHash::equal): Ditto.
- (JSC::TransitionTableHashTraits::emptyValue): Custom traits for transition map
- (JSC::TransitionTableHashTraits::constructDeletedValue): Ditto.
- (JSC::TransitionTableHashTraits::isDeletedValue): Ditto.
- (JSC::StructureID::propertyMap): Added.
-
-2008-09-08 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 20694: Slow Script error pops up when running Dromaeo tests
-
- Correct error in timeout logic where execution tick count would
- be reset to incorrect value due to incorrect offset and indirection.
- Codegen for the slow script dialog was factored out into a separate
- method (emitSlowScriptCheck) rather than having multiple copies of
- the same code. Also added calls to generate slow script checks
- for loop_if_less and loop_if_true opcodes.
-
- * VM/CTI.cpp:
- (JSC::CTI::emitSlowScriptCheck):
- (JSC::CTI::privateCompileMainPass):
- (JSC::CTI::privateCompileSlowCases):
- * VM/CTI.h:
-
-2008-09-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Remove references to the removed WRECompiler class.
-
- * VM/Machine.h:
- * wrec/WREC.h:
-
-2008-09-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Mark Rowe.
-
- Fix the build with CTI enabled but WREC disabled.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
-
-2008-09-08 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * kjs/nodes.h:
- (JSC::StatementNode::):
- (JSC::BlockNode::):
-
-2008-09-08 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff.
-
- <rdar://problem/6134407> Breakpoints in for loops, while loops or
- conditions without curly braces don't break. (19306)
- -Statement Lists already emit debug hooks but conditionals without
- brackets are not lists.
-
- * kjs/nodes.cpp:
- (KJS::IfNode::emitCode):
- (KJS::IfElseNode::emitCode):
- (KJS::DoWhileNode::emitCode):
- (KJS::WhileNode::emitCode):
- (KJS::ForNode::emitCode):
- (KJS::ForInNode::emitCode):
- * kjs/nodes.h:
- (KJS::StatementNode::):
- (KJS::BlockNode::):
-
-2008-09-08 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - Cache the code generated for eval to speed up SunSpider and web sites
- https://bugs.webkit.org/show_bug.cgi?id=20718
-
- 1.052x on SunSpider
- 2.29x on date-format-tofte
-
- Lots of real sites seem to get many hits on this cache as well,
- including GMail, Google Spreadsheets, Slate and Digg (the last of
- these gets over 100 hits on initial page load).
-
- * VM/CodeBlock.h:
- (JSC::EvalCodeCache::get):
- * VM/Machine.cpp:
- (JSC::Machine::callEval):
- (JSC::Machine::privateExecute):
- (JSC::Machine::cti_op_call_eval):
- * VM/Machine.h:
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20711: Change KJS prefix on preprocessor macros to JSC
- <https://bugs.webkit.org/show_bug.cgi?id=20711>
-
- * kjs/CommonIdentifiers.cpp:
- (JSC::CommonIdentifiers::CommonIdentifiers):
- * kjs/CommonIdentifiers.h:
- * kjs/PropertySlot.h:
- (JSC::PropertySlot::getValue):
- (JSC::PropertySlot::putValue):
- (JSC::PropertySlot::setValueSlot):
- (JSC::PropertySlot::setValue):
- (JSC::PropertySlot::setRegisterSlot):
- * kjs/lookup.h:
- * kjs/nodes.cpp:
- * kjs/nodes.h:
- (JSC::Node::):
- (JSC::ExpressionNode::):
- (JSC::StatementNode::):
- (JSC::NullNode::):
- (JSC::BooleanNode::):
- (JSC::NumberNode::):
- (JSC::ImmediateNumberNode::):
- (JSC::StringNode::):
- (JSC::RegExpNode::):
- (JSC::ThisNode::):
- (JSC::ResolveNode::):
- (JSC::ElementNode::):
- (JSC::ArrayNode::):
- (JSC::PropertyNode::):
- (JSC::PropertyListNode::):
- (JSC::ObjectLiteralNode::):
- (JSC::BracketAccessorNode::):
- (JSC::DotAccessorNode::):
- (JSC::ArgumentListNode::):
- (JSC::ArgumentsNode::):
- (JSC::NewExprNode::):
- (JSC::EvalFunctionCallNode::):
- (JSC::FunctionCallValueNode::):
- (JSC::FunctionCallResolveNode::):
- (JSC::FunctionCallBracketNode::):
- (JSC::FunctionCallDotNode::):
- (JSC::PrePostResolveNode::):
- (JSC::PostfixResolveNode::):
- (JSC::PostfixBracketNode::):
- (JSC::PostfixDotNode::):
- (JSC::PostfixErrorNode::):
- (JSC::DeleteResolveNode::):
- (JSC::DeleteBracketNode::):
- (JSC::DeleteDotNode::):
- (JSC::DeleteValueNode::):
- (JSC::VoidNode::):
- (JSC::TypeOfResolveNode::):
- (JSC::TypeOfValueNode::):
- (JSC::PrefixResolveNode::):
- (JSC::PrefixBracketNode::):
- (JSC::PrefixDotNode::):
- (JSC::PrefixErrorNode::):
- (JSC::UnaryPlusNode::):
- (JSC::NegateNode::):
- (JSC::BitwiseNotNode::):
- (JSC::LogicalNotNode::):
- (JSC::MultNode::):
- (JSC::DivNode::):
- (JSC::ModNode::):
- (JSC::AddNode::):
- (JSC::SubNode::):
- (JSC::LeftShiftNode::):
- (JSC::RightShiftNode::):
- (JSC::UnsignedRightShiftNode::):
- (JSC::LessNode::):
- (JSC::GreaterNode::):
- (JSC::LessEqNode::):
- (JSC::GreaterEqNode::):
- (JSC::ThrowableBinaryOpNode::):
- (JSC::InstanceOfNode::):
- (JSC::InNode::):
- (JSC::EqualNode::):
- (JSC::NotEqualNode::):
- (JSC::StrictEqualNode::):
- (JSC::NotStrictEqualNode::):
- (JSC::BitAndNode::):
- (JSC::BitOrNode::):
- (JSC::BitXOrNode::):
- (JSC::LogicalOpNode::):
- (JSC::ConditionalNode::):
- (JSC::ReadModifyResolveNode::):
- (JSC::AssignResolveNode::):
- (JSC::ReadModifyBracketNode::):
- (JSC::AssignBracketNode::):
- (JSC::AssignDotNode::):
- (JSC::ReadModifyDotNode::):
- (JSC::AssignErrorNode::):
- (JSC::CommaNode::):
- (JSC::VarDeclCommaNode::):
- (JSC::ConstDeclNode::):
- (JSC::ConstStatementNode::):
- (JSC::EmptyStatementNode::):
- (JSC::DebuggerStatementNode::):
- (JSC::ExprStatementNode::):
- (JSC::VarStatementNode::):
- (JSC::IfNode::):
- (JSC::IfElseNode::):
- (JSC::DoWhileNode::):
- (JSC::WhileNode::):
- (JSC::ForNode::):
- (JSC::ContinueNode::):
- (JSC::BreakNode::):
- (JSC::ReturnNode::):
- (JSC::WithNode::):
- (JSC::LabelNode::):
- (JSC::ThrowNode::):
- (JSC::TryNode::):
- (JSC::ParameterNode::):
- (JSC::ScopeNode::):
- (JSC::ProgramNode::):
- (JSC::EvalNode::):
- (JSC::FunctionBodyNode::):
- (JSC::FuncExprNode::):
- (JSC::FuncDeclNode::):
- (JSC::CaseClauseNode::):
- (JSC::ClauseListNode::):
- (JSC::CaseBlockNode::):
- (JSC::SwitchNode::):
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20704: Replace the KJS namespace
- <https://bugs.webkit.org/show_bug.cgi?id=20704>
-
- Rename the KJS namespace to JSC. There are still some uses of KJS in
- preprocessor macros and comments, but these will also be changed some
- time in the near future.
-
- * API/APICast.h:
- (toJS):
- (toRef):
- (toGlobalRef):
- * API/JSBase.cpp:
- * API/JSCallbackConstructor.cpp:
- * API/JSCallbackConstructor.h:
- * API/JSCallbackFunction.cpp:
- * API/JSCallbackFunction.h:
- * API/JSCallbackObject.cpp:
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- * API/JSClassRef.cpp:
- (OpaqueJSClass::staticValues):
- (OpaqueJSClass::staticFunctions):
- * API/JSClassRef.h:
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- * API/JSProfilerPrivate.cpp:
- * API/JSStringRef.cpp:
- * API/JSValueRef.cpp:
- (JSValueGetType):
- * API/OpaqueJSString.cpp:
- * API/OpaqueJSString.h:
- * JavaScriptCore.Debug.exp:
- * JavaScriptCore.base.exp:
- * VM/CTI.cpp:
- (JSC::):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- * VM/CodeGenerator.h:
- * VM/ExceptionHelpers.cpp:
- * VM/ExceptionHelpers.h:
- * VM/Instruction.h:
- * VM/JSPropertyNameIterator.cpp:
- * VM/JSPropertyNameIterator.h:
- * VM/LabelID.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * VM/Opcode.cpp:
- * VM/Opcode.h:
- * VM/Register.h:
- (WTF::):
- * VM/RegisterFile.cpp:
- * VM/RegisterFile.h:
- * VM/RegisterID.h:
- (WTF::):
- * VM/SamplingTool.cpp:
- * VM/SamplingTool.h:
- * VM/SegmentedVector.h:
- * kjs/ArgList.cpp:
- * kjs/ArgList.h:
- * kjs/Arguments.cpp:
- * kjs/Arguments.h:
- * kjs/ArrayConstructor.cpp:
- * kjs/ArrayConstructor.h:
- * kjs/ArrayPrototype.cpp:
- * kjs/ArrayPrototype.h:
- * kjs/BatchedTransitionOptimizer.h:
- * kjs/BooleanConstructor.cpp:
- * kjs/BooleanConstructor.h:
- * kjs/BooleanObject.cpp:
- * kjs/BooleanObject.h:
- * kjs/BooleanPrototype.cpp:
- * kjs/BooleanPrototype.h:
- * kjs/CallData.cpp:
- * kjs/CallData.h:
- * kjs/ClassInfo.h:
- * kjs/CommonIdentifiers.cpp:
- * kjs/CommonIdentifiers.h:
- * kjs/ConstructData.cpp:
- * kjs/ConstructData.h:
- * kjs/DateConstructor.cpp:
- * kjs/DateConstructor.h:
- * kjs/DateInstance.cpp:
- (JSC::DateInstance::msToGregorianDateTime):
- * kjs/DateInstance.h:
- * kjs/DateMath.cpp:
- * kjs/DateMath.h:
- * kjs/DatePrototype.cpp:
- * kjs/DatePrototype.h:
- * kjs/DebuggerCallFrame.cpp:
- * kjs/DebuggerCallFrame.h:
- * kjs/Error.cpp:
- * kjs/Error.h:
- * kjs/ErrorConstructor.cpp:
- * kjs/ErrorConstructor.h:
- * kjs/ErrorInstance.cpp:
- * kjs/ErrorInstance.h:
- * kjs/ErrorPrototype.cpp:
- * kjs/ErrorPrototype.h:
- * kjs/ExecState.cpp:
- * kjs/ExecState.h:
- * kjs/FunctionConstructor.cpp:
- * kjs/FunctionConstructor.h:
- * kjs/FunctionPrototype.cpp:
- * kjs/FunctionPrototype.h:
- * kjs/GetterSetter.cpp:
- * kjs/GetterSetter.h:
- * kjs/GlobalEvalFunction.cpp:
- * kjs/GlobalEvalFunction.h:
- * kjs/IndexToNameMap.cpp:
- * kjs/IndexToNameMap.h:
- * kjs/InitializeThreading.cpp:
- * kjs/InitializeThreading.h:
- * kjs/InternalFunction.cpp:
- * kjs/InternalFunction.h:
- (JSC::InternalFunction::InternalFunction):
- * kjs/JSActivation.cpp:
- * kjs/JSActivation.h:
- * kjs/JSArray.cpp:
- * kjs/JSArray.h:
- * kjs/JSCell.cpp:
- * kjs/JSCell.h:
- * kjs/JSFunction.cpp:
- * kjs/JSFunction.h:
- (JSC::JSFunction::JSFunction):
- * kjs/JSGlobalData.cpp:
- (JSC::JSGlobalData::JSGlobalData):
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.cpp:
- * kjs/JSGlobalObject.h:
- * kjs/JSGlobalObjectFunctions.cpp:
- * kjs/JSGlobalObjectFunctions.h:
- * kjs/JSImmediate.cpp:
- * kjs/JSImmediate.h:
- * kjs/JSLock.cpp:
- * kjs/JSLock.h:
- * kjs/JSNotAnObject.cpp:
- * kjs/JSNotAnObject.h:
- * kjs/JSNumberCell.cpp:
- * kjs/JSNumberCell.h:
- * kjs/JSObject.cpp:
- * kjs/JSObject.h:
- * kjs/JSStaticScopeObject.cpp:
- * kjs/JSStaticScopeObject.h:
- * kjs/JSString.cpp:
- * kjs/JSString.h:
- * kjs/JSType.h:
- * kjs/JSValue.cpp:
- * kjs/JSValue.h:
- * kjs/JSVariableObject.cpp:
- * kjs/JSVariableObject.h:
- * kjs/JSWrapperObject.cpp:
- * kjs/JSWrapperObject.h:
- * kjs/LabelStack.cpp:
- * kjs/LabelStack.h:
- * kjs/MathObject.cpp:
- * kjs/MathObject.h:
- * kjs/NativeErrorConstructor.cpp:
- * kjs/NativeErrorConstructor.h:
- * kjs/NativeErrorPrototype.cpp:
- * kjs/NativeErrorPrototype.h:
- * kjs/NodeInfo.h:
- * kjs/NumberConstructor.cpp:
- * kjs/NumberConstructor.h:
- * kjs/NumberObject.cpp:
- * kjs/NumberObject.h:
- * kjs/NumberPrototype.cpp:
- * kjs/NumberPrototype.h:
- * kjs/ObjectConstructor.cpp:
- * kjs/ObjectConstructor.h:
- * kjs/ObjectPrototype.cpp:
- * kjs/ObjectPrototype.h:
- * kjs/Parser.cpp:
- * kjs/Parser.h:
- * kjs/PropertyMap.cpp:
- (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
- * kjs/PropertyMap.h:
- * kjs/PropertyNameArray.cpp:
- * kjs/PropertyNameArray.h:
- * kjs/PropertySlot.cpp:
- * kjs/PropertySlot.h:
- * kjs/PrototypeFunction.cpp:
- * kjs/PrototypeFunction.h:
- * kjs/PutPropertySlot.h:
- * kjs/RegExpConstructor.cpp:
- * kjs/RegExpConstructor.h:
- * kjs/RegExpObject.cpp:
- * kjs/RegExpObject.h:
- * kjs/RegExpPrototype.cpp:
- * kjs/RegExpPrototype.h:
- * kjs/ScopeChain.cpp:
- * kjs/ScopeChain.h:
- * kjs/ScopeChainMark.h:
- * kjs/Shell.cpp:
- (jscmain):
- * kjs/SmallStrings.cpp:
- * kjs/SmallStrings.h:
- * kjs/SourceProvider.h:
- * kjs/SourceRange.h:
- * kjs/StringConstructor.cpp:
- * kjs/StringConstructor.h:
- * kjs/StringObject.cpp:
- * kjs/StringObject.h:
- * kjs/StringObjectThatMasqueradesAsUndefined.h:
- * kjs/StringPrototype.cpp:
- * kjs/StringPrototype.h:
- * kjs/StructureID.cpp:
- * kjs/StructureID.h:
- * kjs/SymbolTable.h:
- * kjs/collector.cpp:
- * kjs/collector.h:
- * kjs/completion.h:
- * kjs/create_hash_table:
- * kjs/debugger.cpp:
- * kjs/debugger.h:
- * kjs/dtoa.cpp:
- * kjs/dtoa.h:
- * kjs/grammar.y:
- * kjs/identifier.cpp:
- * kjs/identifier.h:
- (JSC::Identifier::equal):
- * kjs/interpreter.cpp:
- * kjs/interpreter.h:
- * kjs/lexer.cpp:
- (JSC::Lexer::Lexer):
- (JSC::Lexer::clear):
- (JSC::Lexer::makeIdentifier):
- * kjs/lexer.h:
- * kjs/lookup.cpp:
- * kjs/lookup.h:
- * kjs/nodes.cpp:
- * kjs/nodes.h:
- * kjs/nodes2string.cpp:
- * kjs/operations.cpp:
- * kjs/operations.h:
- * kjs/protect.h:
- * kjs/regexp.cpp:
- * kjs/regexp.h:
- * kjs/ustring.cpp:
- * kjs/ustring.h:
- (JSC::operator!=):
- (JSC::IdentifierRepHash::hash):
- (WTF::):
- * masm/MacroAssembler.h:
- * masm/MacroAssemblerWin.cpp:
- * masm/X86Assembler.h:
- * pcre/pcre_exec.cpp:
- * profiler/CallIdentifier.h:
- (WTF::):
- * profiler/HeavyProfile.cpp:
- * profiler/HeavyProfile.h:
- * profiler/Profile.cpp:
- * profiler/Profile.h:
- * profiler/ProfileGenerator.cpp:
- * profiler/ProfileGenerator.h:
- * profiler/ProfileNode.cpp:
- * profiler/ProfileNode.h:
- * profiler/Profiler.cpp:
- * profiler/Profiler.h:
- * profiler/TreeProfile.cpp:
- * profiler/TreeProfile.h:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
- * wtf/AVLTree.h:
-
-2008-09-07 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - rename IA32MacroAssembler class to X86Assembler
-
- We otherwise call the platform X86, and also, I don't see any macros.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * masm/IA32MacroAsm.h: Removed.
- * masm/MacroAssembler.h:
- (KJS::MacroAssembler::MacroAssembler):
- * masm/MacroAssemblerWin.cpp:
- (KJS::MacroAssembler::emitRestoreArgumentReference):
- * masm/X86Assembler.h: Copied from masm/IA32MacroAsm.h.
- (KJS::X86Assembler::X86Assembler):
- * wrec/WREC.cpp:
- (KJS::WRECGenerator::generateNonGreedyQuantifier):
- (KJS::WRECGenerator::generateGreedyQuantifier):
- (KJS::WRECGenerator::generateParentheses):
- (KJS::WRECGenerator::generateBackreference):
- (KJS::WRECGenerator::gernerateDisjunction):
- * wrec/WREC.h:
-
-2008-09-07 Cameron Zwarich <cwzwarich@webkit.org>
-
- Not reviewed.
-
- Visual C++ seems to have some odd casting rules, so just convert the
- offending cast back to a C-style cast for now.
-
- * kjs/collector.cpp:
- (KJS::otherThreadStackPointer):
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Mark Rowe.
-
- Attempt to fix the Windows build by using a const_cast to cast regs.Esp
- to a uintptr_t instead of a reinterpret_cast.
-
- * kjs/collector.cpp:
- (KJS::otherThreadStackPointer):
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Sam Weinig.
-
- Remove C-style casts from kjs/collector.cpp.
-
- * kjs/collector.cpp:
- (KJS::Heap::heapAllocate):
- (KJS::currentThreadStackBase):
- (KJS::Heap::markConservatively):
- (KJS::otherThreadStackPointer):
- (KJS::Heap::markOtherThreadConservatively):
- (KJS::Heap::sweep):
-
-2008-09-07 Mark Rowe <mrowe@apple.com>
-
- Build fix for the debug variant.
-
- * DerivedSources.make: Also use the .Debug.exp exports file when building the debug variant.
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Timothy Hatcher.
-
- Remove C-style casts from the CTI code.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitGetArg):
- (KJS::CTI::emitGetPutArg):
- (KJS::ctiRepatchCallByReturnAddress):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompileMainPass):
- (KJS::CTI::privateCompileGetByIdSelf):
- (KJS::CTI::privateCompileGetByIdProto):
- (KJS::CTI::privateCompileGetByIdChain):
- (KJS::CTI::privateCompilePutByIdReplace):
- (KJS::CTI::privateArrayLengthTrampoline):
- (KJS::CTI::privateStringLengthTrampoline):
-
-=== End merge of squirrelfish-extreme ===
-
-2008-09-06 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig. Adapted somewhat by Maciej Stachowiak.
-
- - refactor WREC to share more of the JIT infrastructure with CTI
-
- * VM/CTI.cpp:
- (KJS::CTI::emitGetArg):
- (KJS::CTI::emitGetPutArg):
- (KJS::CTI::emitPutArg):
- (KJS::CTI::emitPutArgConstant):
- (KJS::CTI::emitPutCTIParam):
- (KJS::CTI::emitGetCTIParam):
- (KJS::CTI::emitPutToCallFrameHeader):
- (KJS::CTI::emitGetFromCallFrameHeader):
- (KJS::CTI::emitPutResult):
- (KJS::CTI::emitDebugExceptionCheck):
- (KJS::CTI::emitJumpSlowCaseIfNotImm):
- (KJS::CTI::emitJumpSlowCaseIfNotImms):
- (KJS::CTI::emitFastArithDeTagImmediate):
- (KJS::CTI::emitFastArithReTagImmediate):
- (KJS::CTI::emitFastArithPotentiallyReTagImmediate):
- (KJS::CTI::emitFastArithImmToInt):
- (KJS::CTI::emitFastArithIntToImmOrSlowCase):
- (KJS::CTI::emitFastArithIntToImmNoCheck):
- (KJS::CTI::CTI):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompileMainPass):
- (KJS::CTI::privateCompileSlowCases):
- (KJS::CTI::privateCompile):
- (KJS::CTI::privateCompileGetByIdSelf):
- (KJS::CTI::privateCompileGetByIdProto):
- (KJS::CTI::privateCompileGetByIdChain):
- (KJS::CTI::privateCompilePutByIdReplace):
- (KJS::CTI::privateArrayLengthTrampoline):
- (KJS::CTI::privateStringLengthTrampoline):
- (KJS::CTI::compileRegExp):
- * VM/CTI.h:
- (KJS::CallRecord::CallRecord):
- (KJS::JmpTable::JmpTable):
- (KJS::SlowCaseEntry::SlowCaseEntry):
- (KJS::CTI::JSRInfo::JSRInfo):
- * kjs/regexp.cpp:
- (KJS::RegExp::RegExp):
- * wrec/WREC.cpp:
- (KJS::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
- (KJS::GeneratePatternCharacterFunctor::generateAtom):
- (KJS::GeneratePatternCharacterFunctor::backtrack):
- (KJS::GenerateCharacterClassFunctor::generateAtom):
- (KJS::GenerateCharacterClassFunctor::backtrack):
- (KJS::GenerateBackreferenceFunctor::generateAtom):
- (KJS::GenerateBackreferenceFunctor::backtrack):
- (KJS::GenerateParenthesesNonGreedyFunctor::generateAtom):
- (KJS::GenerateParenthesesNonGreedyFunctor::backtrack):
- (KJS::WRECGenerate::generateBacktrack1):
- (KJS::WRECGenerate::generateBacktrackBackreference):
- (KJS::WRECGenerate::generateBackreferenceQuantifier):
- (KJS::WRECGenerate::generateNonGreedyQuantifier):
- (KJS::WRECGenerate::generateGreedyQuantifier):
- (KJS::WRECGenerate::generatePatternCharacter):
- (KJS::WRECGenerate::generateCharacterClassInvertedRange):
- (KJS::WRECGenerate::generateCharacterClassInverted):
- (KJS::WRECGenerate::generateCharacterClass):
- (KJS::WRECGenerate::generateParentheses):
- (KJS::WRECGenerate::generateParenthesesNonGreedy):
- (KJS::WRECGenerate::gererateParenthesesResetTrampoline):
- (KJS::WRECGenerate::generateAssertionBOL):
- (KJS::WRECGenerate::generateAssertionEOL):
- (KJS::WRECGenerate::generateAssertionWordBoundary):
- (KJS::WRECGenerate::generateBackreference):
- (KJS::WRECGenerate::gernerateDisjunction):
- (KJS::WRECGenerate::terminateDisjunction):
- (KJS::WRECParser::parseGreedyQuantifier):
- (KJS::WRECParser::parseQuantifier):
- (KJS::WRECParser::parsePatternCharacterQualifier):
- (KJS::WRECParser::parseCharacterClassQuantifier):
- (KJS::WRECParser::parseBackreferenceQuantifier):
- (KJS::WRECParser::parseParentheses):
- (KJS::WRECParser::parseCharacterClass):
- (KJS::WRECParser::parseOctalEscape):
- (KJS::WRECParser::parseEscape):
- (KJS::WRECParser::parseTerm):
- (KJS::WRECParser::parseDisjunction):
- * wrec/WREC.h:
- (KJS::WRECGenerate::WRECGenerate):
- (KJS::WRECParser::):
- (KJS::WRECParser::WRECParser):
- (KJS::WRECParser::parseAlternative):
- (KJS::WRECParser::isEndOfPattern):
-
-2008-09-06 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix the sampler build.
-
- * VM/SamplingTool.h:
-
-2008-09-06 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Jump through the necessary hoops required to make MSVC cooperate with SFX
-
- We now explicitly declare the calling convention on all cti_op_* cfunctions,
- and return int instead of bool where appropriate (despite the cdecl calling
- convention seems to state MSVC generates code that returns the result value
- through ecx). SFX behaves slightly differently under MSVC, specifically it
- stores the base argument address for the cti_op_* functions in the first
- argument, and then does the required stack manipulation through that pointer.
- This is necessary as MSVC's optimisations assume they have complete control
- of the stack, and periodically elide our stack manipulations, or move
- values in unexpected ways. MSVC also frequently produces tail calls which may
- clobber the first argument, so the MSVC path is slightly less efficient due
- to the need to restore it.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- (KJS::):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompileMainPass):
- (KJS::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * masm/MacroAssembler.h:
- (KJS::MacroAssembler::emitConvertToFastCall):
- * masm/MacroAssemblerIA32GCC.cpp: Removed.
- For performance reasons we need these no-op functions to be inlined.
-
- * masm/MacroAssemblerWin.cpp:
- (KJS::MacroAssembler::emitRestoreArgumentReference):
- * wtf/Platform.h:
-
-2008-09-05 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Maciej Stachowiak, or maybe the other way around.
-
- Added the ability to coalesce JITCode buffer grow operations by first
- growing the buffer and then executing unchecked puts to it.
-
- About a 2% speedup on date-format-tofte.
-
- * VM/CTI.cpp:
- (KJS::CTI::compileOpCall):
- * masm/IA32MacroAsm.h:
- (KJS::JITCodeBuffer::ensureSpace):
- (KJS::JITCodeBuffer::putByteUnchecked):
- (KJS::JITCodeBuffer::putByte):
- (KJS::JITCodeBuffer::putShortUnchecked):
- (KJS::JITCodeBuffer::putShort):
- (KJS::JITCodeBuffer::putIntUnchecked):
- (KJS::JITCodeBuffer::putInt):
- (KJS::IA32MacroAssembler::emitTestl_i32r):
- (KJS::IA32MacroAssembler::emitMovl_mr):
- (KJS::IA32MacroAssembler::emitMovl_rm):
- (KJS::IA32MacroAssembler::emitMovl_i32m):
- (KJS::IA32MacroAssembler::emitUnlinkedJe):
- (KJS::IA32MacroAssembler::emitModRm_rr):
- (KJS::IA32MacroAssembler::emitModRm_rr_Unchecked):
- (KJS::IA32MacroAssembler::emitModRm_rm_Unchecked):
- (KJS::IA32MacroAssembler::emitModRm_rm):
- (KJS::IA32MacroAssembler::emitModRm_opr):
- (KJS::IA32MacroAssembler::emitModRm_opr_Unchecked):
- (KJS::IA32MacroAssembler::emitModRm_opm_Unchecked):
-
-2008-09-05 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Disable WREC and CTI on platforms that we have not yet had a chance to test with.
-
- * wtf/Platform.h:
-
-2008-09-05 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Use jo instead of a mask compare when fetching array.length and
- string.length. 4% speedup on array.length / string.length torture
- test.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateArrayLengthTrampoline):
- (KJS::CTI::privateStringLengthTrampoline):
-
-2008-09-05 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Removed a CTI compilation pass by recording labels during bytecode
- generation. This is more to reduce complexity than it is to improve
- performance.
-
- SunSpider reports no change.
-
- CodeBlock now keeps a "labels" set, which holds the offsets of all the
- instructions that can be jumped to.
-
- * VM/CTI.cpp: Nixed a pass.
-
- * VM/CodeBlock.h: Added a "labels" set.
-
- * VM/LabelID.h: No need for a special LableID for holding jump
- destinations, since the CodeBlock now knows all jump destinations.
-
- * wtf/HashTraits.h: New hash traits to accomodate putting offset 0 in
- the set.
-
- * kjs/nodes.cpp:
- (KJS::TryNode::emitCode): Emit a dummy label to record sret targets.
-
-2008-09-05 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt and Gavin Barraclough.
-
- Move the JITCodeBuffer onto Machine and remove the static variables.
-
- * VM/CTI.cpp: Initialize m_jit with the Machine's code buffer.
- * VM/Machine.cpp:
- (KJS::Machine::Machine): Allocate a JITCodeBuffer.
- * VM/Machine.h:
- * kjs/RegExpConstructor.cpp:
- (KJS::constructRegExp): Pass the ExecState through.
- * kjs/RegExpPrototype.cpp:
- (KJS::regExpProtoFuncCompile): Ditto.
- * kjs/StringPrototype.cpp:
- (KJS::stringProtoFuncMatch): Ditto.
- (KJS::stringProtoFuncSearch): Ditto.
- * kjs/nodes.cpp:
- (KJS::RegExpNode::emitCode): Compile the pattern at code generation time
- so that we have access to an ExecState.
- * kjs/nodes.h:
- (KJS::RegExpNode::):
- * kjs/nodes2string.cpp:
- * kjs/regexp.cpp:
- (KJS::RegExp::RegExp): Pass the ExecState through.
- (KJS::RegExp::create): Ditto.
- * kjs/regexp.h:
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::IA32MacroAssembler): Reset the JITCodeBuffer when we are
- constructed.
- * wrec/WREC.cpp:
- (KJS::WRECompiler::compile): Retrieve the JITCodeBuffer from the Machine.
- * wrec/WREC.h:
-
-2008-09-05 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt and Gavin Barraclough.
-
- Fix the build when CTI is disabled.
-
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::~CodeBlock):
- * VM/CodeGenerator.cpp:
- (KJS::prepareJumpTableForStringSwitch):
- * VM/Machine.cpp:
- (KJS::Machine::Machine):
- (KJS::Machine::~Machine):
-
-2008-09-05 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Mark Rowe.
-
- Fix some windows abi issues.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompileMainPass):
- (KJS::CTI::privateCompileSlowCases):
- * VM/CTI.h:
- (KJS::CallRecord::CallRecord):
- (KJS::):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_post_inc):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_post_dec):
- * VM/Machine.h:
-
-2008-09-05 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix ecma/FunctionObjects/15.3.5.3.js after I broke it in r93.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_call_NotJSFunction): Restore m_callFrame to the correct value after making the native call.
- (KJS::Machine::cti_op_construct_NotJSConstruct): Ditto.
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix fast/dom/Window/console-functions.html.
-
- The call frame on the ExecState was not being updated on calls into native functions. This meant that functions
- such as console.log would use the line number of the last JS function on the call stack.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_call_NotJSFunction): Update the ExecState's call frame before making a native function call,
- and restore it when the function is done.
- (KJS::Machine::cti_op_construct_NotJSConstruct): Ditto.
-
-2008-09-05 Oliver Hunt <oliver@apple.com>
-
- Start bringing up SFX on windows.
-
- Reviewed by Mark Rowe and Sam Weinig
-
- Start doing the work to bring up SFX on windows. Initially
- just working on WREC, as it does not make any calls so reduces
- the amount of code that needs to be corrected.
-
- Start abstracting the CTI JIT codegen engine.
-
- * ChangeLog:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- * masm/IA32MacroAsm.h:
- * masm/MacroAssembler.h: Added.
- (KJS::MacroAssembler::MacroAssembler):
- * masm/MacroAssemblerIA32GCC.cpp: Added.
- (KJS::MacroAssembler::emitConvertToFastCall):
- * masm/MacroAssemblerWin.cpp: Added.
- (KJS::MacroAssembler::emitConvertToFastCall):
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseGreedyQuantifier):
- (KJS::WRECompiler::parseCharacterClass):
- (KJS::WRECompiler::parseEscape):
- (KJS::WRECompiler::compilePattern):
- * wrec/WREC.h:
-
-2008-09-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Support for slow scripts (timeout checking).
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompileMainPass):
- (KJS::CTI::privateCompile):
- * VM/Machine.cpp:
- (KJS::slideRegisterWindowForCall):
- (KJS::Machine::cti_timeout_check):
- (KJS::Machine::cti_vm_throw):
-
-2008-09-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Third round of style cleanup.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/CodeBlock.h:
- * VM/Machine.cpp:
- * VM/Machine.h:
- * kjs/ExecState.h:
-
-2008-09-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Jon Honeycutt.
-
- Second round of style cleanup.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * wrec/WREC.h:
-
-2008-09-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- First round of style cleanup.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * masm/IA32MacroAsm.h:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
-
-2008-09-04 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Mark Rowe.
-
- Merged http://trac.webkit.org/changeset/36081 to work with CTI.
-
- * VM/Machine.cpp:
- (KJS::Machine::tryCtiCacheGetByID):
-
-2008-09-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Enable profiling in CTI.
-
- * VM/CTI.h:
- (KJS::):
- (KJS::CTI::execute):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_call_JSFunction):
- (KJS::Machine::cti_op_call_NotJSFunction):
- (KJS::Machine::cti_op_ret):
- (KJS::Machine::cti_op_construct_JSConstruct):
- (KJS::Machine::cti_op_construct_NotJSConstruct):
-
-2008-09-04 Victor Hernandez <vhernandez@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Fixed an #if to support using WREC without CTI.
-
- * kjs/regexp.cpp:
- (KJS::RegExp::match):
-
-2008-09-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- The array/string length trampolines are owned by the Machine, not the codeblock that compiled them.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateArrayLengthTrampoline):
- (KJS::CTI::privateStringLengthTrampoline):
- * VM/Machine.cpp:
- (KJS::Machine::~Machine):
- * VM/Machine.h:
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Gavin Barraclough and Sam Weinig.
-
- Fix a crash on launch of jsc when GuardMalloc is enabled.
-
- * kjs/ScopeChain.h:
- (KJS::ScopeChain::ScopeChain): Initialize m_node to 0 when we have no valid scope chain.
- (KJS::ScopeChain::~ScopeChain): Null-check m_node before calling deref.
-
-2008-09-03 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Fix inspector and fast array access so that it bounds
- checks correctly.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main):
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::):
- (KJS::IA32MacroAssembler::emitUnlinkedJb):
- (KJS::IA32MacroAssembler::emitUnlinkedJbe):
-
-2008-09-03 Mark Rowe <mrowe@apple.com>
-
- Move the assertion after the InitializeAndReturn block, as
- that is used even when CTI is enabled.
-
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
-
-2008-09-03 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Replace calls to exit with ASSERT_WITH_MESSAGE or ASSERT_NOT_REACHED.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- (KJS::Machine::cti_vm_throw):
-
-2008-09-03 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Tweak JavaScriptCore to compile on non-x86 platforms. This is achieved
- by wrapping more code with ENABLE(CTI), ENABLE(WREC), and PLATFORM(X86)
- #if's.
-
- * VM/CTI.cpp:
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::printStructureIDs): Use %td as the format specifier for
- printing a ptrdiff_t.
- * VM/Machine.cpp:
- * VM/Machine.h:
- * kjs/regexp.cpp:
- (KJS::RegExp::RegExp):
- (KJS::RegExp::~RegExp):
- (KJS::RegExp::match):
- * kjs/regexp.h:
- * masm/IA32MacroAsm.h:
- * wrec/WREC.cpp:
- * wrec/WREC.h:
- * wtf/Platform.h: Only enable CTI and WREC on x86. Add an extra define to
- track whether any MASM-using features are enabled.
-
-2008-09-03 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Copy Geoff's array/string length optimization for CTI.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateArrayLengthTrampoline):
- (KJS::CTI::privateStringLengthTrampoline):
- * VM/CTI.h:
- (KJS::CTI::compileArrayLengthTrampoline):
- (KJS::CTI::compileStringLengthTrampoline):
- * VM/Machine.cpp:
- (KJS::Machine::Machine):
- (KJS::Machine::getCtiArrayLengthTrampoline):
- (KJS::Machine::getCtiStringLengthTrampoline):
- (KJS::Machine::tryCtiCacheGetByID):
- (KJS::Machine::cti_op_get_by_id_second):
- * VM/Machine.h:
- * kjs/JSString.h:
- * kjs/ustring.h:
-
-2008-09-03 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Implement fast array accesses in CTI - 2-3% progression on sunspider.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitFastArithIntToImmNoCheck):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- * VM/CTI.h:
- * kjs/JSArray.h:
-
-2008-09-02 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Enable fast property access support in CTI.
-
- * VM/CTI.cpp:
- (KJS::ctiSetReturnAddress):
- (KJS::ctiRepatchCallByReturnAddress):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- (KJS::CTI::privateCompileGetByIdSelf):
- (KJS::CTI::privateCompileGetByIdProto):
- (KJS::CTI::privateCompileGetByIdChain):
- (KJS::CTI::privateCompilePutByIdReplace):
- * VM/CTI.h:
- (KJS::CTI::compileGetByIdSelf):
- (KJS::CTI::compileGetByIdProto):
- (KJS::CTI::compileGetByIdChain):
- (KJS::CTI::compilePutByIdReplace):
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::~CodeBlock):
- * VM/CodeBlock.h:
- * VM/Machine.cpp:
- (KJS::doSetReturnAddressVmThrowTrampoline):
- (KJS::Machine::tryCtiCachePutByID):
- (KJS::Machine::tryCtiCacheGetByID):
- (KJS::Machine::cti_op_put_by_id):
- (KJS::Machine::cti_op_put_by_id_second):
- (KJS::Machine::cti_op_put_by_id_generic):
- (KJS::Machine::cti_op_put_by_id_fail):
- (KJS::Machine::cti_op_get_by_id):
- (KJS::Machine::cti_op_get_by_id_second):
- (KJS::Machine::cti_op_get_by_id_generic):
- (KJS::Machine::cti_op_get_by_id_fail):
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_vm_throw):
- * VM/Machine.h:
- * kjs/JSCell.h:
- * kjs/JSObject.h:
- * kjs/PropertyMap.h:
- * kjs/StructureID.cpp:
- (KJS::StructureIDChain::StructureIDChain):
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::emitCmpl_i32m):
- (KJS::IA32MacroAssembler::emitMovl_mr):
- (KJS::IA32MacroAssembler::emitMovl_rm):
-
-2008-09-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- A backslash (\) at the of a RegEx should produce an error.
- Fixes fast/regex/test1.html.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseEscape):
-
-2008-09-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Link jumps for the slow case of op_loop_if_less. Fixes acid3.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass4_SlowCases):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Maciej Stachowiak.
-
- Switch WREC on by default.
-
- * wtf/Platform.h:
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix two failures in fast/regex/test1.html
- - \- in a character class should be treated as a literal -
- - A missing max quantifier needs to be treated differently than
- a null max quantifier.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::generateNonGreedyQuantifier):
- (KJS::WRECompiler::generateGreedyQuantifier):
- (KJS::WRECompiler::parseCharacterClass):
- * wrec/WREC.h:
- (KJS::Quantifier::Quantifier):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix crash in fast/js/kde/evil-n.html
-
- * kjs/regexp.cpp: Always pass a non-null offset vector to the wrec function.
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- Add pattern length limit fixing one test in fast/js.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::compile):
- * wrec/WREC.h:
- (KJS::WRECompiler::):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- Make octal escape parsing/back-reference parsing more closely match
- prior behavior fixing one test in fast/js.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseCharacterClass): 8 and 9 should be IdentityEscaped
- (KJS::WRECompiler::parseEscape):
- * wrec/WREC.h:
- (KJS::WRECompiler::peekDigit):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- Fix one mozilla test.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::generateCharacterClassInverted): Fix incorrect not
- ascii upper check.
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- Parse octal escapes in character classes fixing one mozilla test.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseCharacterClass):
- (KJS::WRECompiler::parseOctalEscape):
- * wrec/WREC.h:
- (KJS::WRECompiler::consumeOctal):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fixes two mozilla tests with WREC enabled.
-
- * wrec/WREC.cpp:
- (KJS::CharacterClassConstructor::append): Keep the character class sorted
- when appending another character class.
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Mark Rowe.
-
- Fixes two mozilla tests with WREC enabled.
-
- * wrec/WREC.cpp:
- (KJS::CharacterClassConstructor::addSortedRange): Insert the range at the correct position
- instead of appending it to the end.
-
-2008-09-01 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Move cross-compilation unit call into NEVER_INLINE function.
-
- * VM/Machine.cpp:
- (KJS::doSetReturnAddressVmThrowTrampoline):
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Fix one test in fast/js.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_construct_NotJSConstruct): Throw a createNotAConstructorError,
- instead of a createNotAFunctionError.
-
-2008-08-31 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Zero-cost exception handling. This patch takes the exception checking
- back of the hot path. When an exception occurs in a Machine::cti*
- method, the return address to JIT code is recorded, and is then
- overwritten with a pointer to a trampoline routine. When the method
- returns the trampoline will cause the cti_vm_throw method to be invoked.
-
- cti_vm_throw uses the return address preserved above, to discover the
- vPC of the bytecode that raised the exception (using a map build during
- translation). From the VPC of the faulting bytecode the vPC of a catch
- routine may be discovered (unwinding the stack where necesary), and then
- a bytecode address for the catch routine is looked up. Final cti_vm_throw
- overwrites its return address to JIT code again, to trampoline directly
- to the catch routine.
-
- cti_op_throw is handled in a similar fashion.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitPutCTIParam):
- (KJS::CTI::emitPutToCallFrameHeader):
- (KJS::CTI::emitGetFromCallFrameHeader):
- (KJS::ctiSetReturnAddressForArgs):
- (KJS::CTI::emitDebugExceptionCheck):
- (KJS::CTI::printOpcodeOperandTypes):
- (KJS::CTI::emitCall):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::CallRecord::CallRecord):
- (KJS::):
- (KJS::CTI::execute):
- * VM/CodeBlock.h:
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- (KJS::Machine::cti_op_instanceof):
- (KJS::Machine::cti_op_call_NotJSFunction):
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_op_in):
- (KJS::Machine::cti_vm_throw):
- * VM/RegisterFile.h:
- (KJS::RegisterFile::):
- * kjs/ExecState.h:
- (KJS::ExecState::setCtiReturnAddress):
- (KJS::ExecState::ctiReturnAddress):
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::):
- (KJS::IA32MacroAssembler::emitPushl_m):
- (KJS::IA32MacroAssembler::emitPopl_m):
- (KJS::IA32MacroAssembler::getRelocatedAddress):
-
-2008-08-31 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fall back to PCRE for any regexp containing parentheses until we correctly backtrack within them.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseParentheses):
- * wrec/WREC.h:
- (KJS::WRECompiler::):
-
-2008-08-31 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix several issues within ecma_3/RegExp/perlstress-001.js with WREC enabled.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::generateNonGreedyQuantifier): Compare with the maximum quantifier count rather than the minimum.
- (KJS::WRECompiler::generateAssertionEOL): Do a register-to-register comparison rather than immediate-to-register.
- (KJS::WRECompiler::parseCharacterClass): Pass through the correct inversion flag.
-
-2008-08-30 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Re-fix the six remaining failures in the Mozilla JavaScript tests in a manner that does not kill performance.
- This shows up as a 0.6% progression on SunSpider on my machine.
-
- Grow the JITCodeBuffer's underlying buffer when we run out of space rather than just bailing out.
-
- * VM/CodeBlock.h:
- (KJS::CodeBlock::~CodeBlock): Switch to using fastFree now that JITCodeBuffer::copy uses fastMalloc.
- * kjs/regexp.cpp: Ditto.
- * masm/IA32MacroAsm.h:
- (KJS::JITCodeBuffer::growBuffer):
- (KJS::JITCodeBuffer::JITCodeBuffer):
- (KJS::JITCodeBuffer::~JITCodeBuffer):
- (KJS::JITCodeBuffer::putByte):
- (KJS::JITCodeBuffer::putShort):
- (KJS::JITCodeBuffer::putInt):
- (KJS::JITCodeBuffer::reset):
- (KJS::JITCodeBuffer::copy):
-
-2008-08-29 Oliver Hunt <oliver@apple.com>
-
- RS=Maciej
-
- Roll out previous patch as it causes a 5% performance regression
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp:
- (KJS::getJCB):
- (KJS::CTI::privateCompile):
- * VM/CodeBlock.h:
- (KJS::CodeBlock::~CodeBlock):
- * masm/IA32MacroAsm.h:
- (KJS::JITCodeBuffer::JITCodeBuffer):
- (KJS::JITCodeBuffer::putByte):
- (KJS::JITCodeBuffer::putShort):
- (KJS::JITCodeBuffer::putInt):
- (KJS::JITCodeBuffer::getEIP):
- (KJS::JITCodeBuffer::start):
- (KJS::JITCodeBuffer::getOffset):
- (KJS::JITCodeBuffer::reset):
- (KJS::JITCodeBuffer::copy):
- (KJS::IA32MacroAssembler::emitModRm_rr):
- (KJS::IA32MacroAssembler::emitModRm_rm):
- (KJS::IA32MacroAssembler::emitModRm_rmsib):
- (KJS::IA32MacroAssembler::IA32MacroAssembler):
- (KJS::IA32MacroAssembler::emitInt3):
- (KJS::IA32MacroAssembler::emitPushl_r):
- (KJS::IA32MacroAssembler::emitPopl_r):
- (KJS::IA32MacroAssembler::emitMovl_rr):
- (KJS::IA32MacroAssembler::emitAddl_rr):
- (KJS::IA32MacroAssembler::emitAddl_i8r):
- (KJS::IA32MacroAssembler::emitAddl_i32r):
- (KJS::IA32MacroAssembler::emitAddl_mr):
- (KJS::IA32MacroAssembler::emitAndl_rr):
- (KJS::IA32MacroAssembler::emitAndl_i32r):
- (KJS::IA32MacroAssembler::emitCmpl_i8r):
- (KJS::IA32MacroAssembler::emitCmpl_rr):
- (KJS::IA32MacroAssembler::emitCmpl_rm):
- (KJS::IA32MacroAssembler::emitCmpl_i32r):
- (KJS::IA32MacroAssembler::emitCmpl_i32m):
- (KJS::IA32MacroAssembler::emitCmpw_rm):
- (KJS::IA32MacroAssembler::emitOrl_rr):
- (KJS::IA32MacroAssembler::emitOrl_i8r):
- (KJS::IA32MacroAssembler::emitSubl_rr):
- (KJS::IA32MacroAssembler::emitSubl_i8r):
- (KJS::IA32MacroAssembler::emitSubl_i32r):
- (KJS::IA32MacroAssembler::emitSubl_mr):
- (KJS::IA32MacroAssembler::emitTestl_i32r):
- (KJS::IA32MacroAssembler::emitTestl_rr):
- (KJS::IA32MacroAssembler::emitXorl_i8r):
- (KJS::IA32MacroAssembler::emitXorl_rr):
- (KJS::IA32MacroAssembler::emitSarl_i8r):
- (KJS::IA32MacroAssembler::emitSarl_CLr):
- (KJS::IA32MacroAssembler::emitShl_i8r):
- (KJS::IA32MacroAssembler::emitShll_CLr):
- (KJS::IA32MacroAssembler::emitMull_rr):
- (KJS::IA32MacroAssembler::emitIdivl_r):
- (KJS::IA32MacroAssembler::emitCdq):
- (KJS::IA32MacroAssembler::emitMovl_mr):
- (KJS::IA32MacroAssembler::emitMovzwl_mr):
- (KJS::IA32MacroAssembler::emitMovl_rm):
- (KJS::IA32MacroAssembler::emitMovl_i32r):
- (KJS::IA32MacroAssembler::emitMovl_i32m):
- (KJS::IA32MacroAssembler::emitLeal_mr):
- (KJS::IA32MacroAssembler::emitRet):
- (KJS::IA32MacroAssembler::emitJmpN_r):
- (KJS::IA32MacroAssembler::emitJmpN_m):
- (KJS::IA32MacroAssembler::emitCall):
- (KJS::IA32MacroAssembler::label):
- (KJS::IA32MacroAssembler::emitUnlinkedJmp):
- (KJS::IA32MacroAssembler::emitUnlinkedJne):
- (KJS::IA32MacroAssembler::emitUnlinkedJe):
- (KJS::IA32MacroAssembler::emitUnlinkedJl):
- (KJS::IA32MacroAssembler::emitUnlinkedJle):
- (KJS::IA32MacroAssembler::emitUnlinkedJge):
- (KJS::IA32MacroAssembler::emitUnlinkedJae):
- (KJS::IA32MacroAssembler::emitUnlinkedJo):
- (KJS::IA32MacroAssembler::link):
- * wrec/WREC.cpp:
- (KJS::WRECompiler::compilePattern):
- (KJS::WRECompiler::compile):
- * wrec/WREC.h:
-
-2008-08-29 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Have JITCodeBuffer manage a Vector containing the generated code so that it can grow
- as needed when generating code for a large function. This fixes all six remaining failures
- in Mozilla tests in both debug and release builds.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile):
- * VM/CodeBlock.h:
- (KJS::CodeBlock::~CodeBlock):
- * masm/IA32MacroAsm.h:
- (KJS::JITCodeBuffer::putByte):
- (KJS::JITCodeBuffer::putShort):
- (KJS::JITCodeBuffer::putInt):
- (KJS::JITCodeBuffer::getEIP):
- (KJS::JITCodeBuffer::start):
- (KJS::JITCodeBuffer::getOffset):
- (KJS::JITCodeBuffer::getCode):
- (KJS::IA32MacroAssembler::emitModRm_rr):
- * wrec/WREC.cpp:
- (KJS::WRECompiler::compilePattern):
- * wrec/WREC.h:
-
-2008-08-29 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Implement parsing of octal escapes in regular expressions. This fixes three Mozilla tests.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::parseOctalEscape):
- (KJS::WRECompiler::parseEscape): Parse the escape sequence as an octal escape if it has a leading zero.
- Add a FIXME about treating invalid backreferences as octal escapes in the future.
- * wrec/WREC.h:
- (KJS::WRECompiler::consumeNumber): Multiply by 10 rather than 0 so that we handle numbers with more than
- one digit.
- * wtf/ASCIICType.h:
- (WTF::isASCIIOctalDigit):
-
-2008-08-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Pass vPC to instanceof method. Fixes 2 mozilla tests in debug.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_instanceof):
-
-2008-08-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Pass vPCs to resolve methods for correct exception creation. Fixes
- 17 mozilla tests in debug.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_resolve_with_base):
-
-2008-08-29 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Remembering to actually throw the exception passed to op throw helps.
- Regressions 19 -> 6.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_vm_throw):
-
-2008-08-29 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Sam Weinig.
-
- Support for exception unwinding the stack.
-
- Once upon a time, Sam asked me for a bettr ChangeLog entry. The return address
- is now preserved on entry to a JIT code function (if we preserve lazily we need
- restore the native return address during exception stack unwind). This takes
- the number of regressions down from ~150 to 19.
-
- * VM/CTI.cpp:
- (KJS::getJCB):
- (KJS::CTI::emitExceptionCheck):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::):
- * VM/Machine.cpp:
- (KJS::Machine::throwException):
- (KJS::Machine::cti_op_call_JSFunction):
- (KJS::Machine::cti_op_call_NotJSFunction):
- (KJS::Machine::cti_op_construct_JSConstruct):
- (KJS::Machine::cti_op_construct_NotJSConstruct):
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_vm_throw):
-
-2008-08-29 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix js1_2/regexp/word_boundary.js and four other Mozilla tests with WREC enabled.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::generateCharacterClassInvertedRange): If none of the exact matches
- succeeded, jump to failure.
- (KJS::WRECompiler::compilePattern): Restore and increment the current position stored
- on the stack to ensure that it will be reset to the correct position after a failed
- match has consumed input.
-
-2008-08-29 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix a hang in ecma_3/RegExp/15.10.2-1.js with WREC enabled.
- A backreference with a quantifier would get stuck in an infinite
- loop if the captured range was empty.
-
- * wrec/WREC.cpp:
- (KJS::WRECompiler::generateBackreferenceQuantifier): If the captured range
- was empty, do not attempt to match the backreference.
- (KJS::WRECompiler::parseBackreferenceQuantifier):
- * wrec/WREC.h:
- (KJS::Quantifier::):
-
-2008-08-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Implement op_debug.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::debug):
- (KJS::Machine::privateExecute):
- (KJS::Machine::cti_op_debug):
- * VM/Machine.h:
-
-2008-08-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Implement op_switch_string fixing 1 mozilla test and one test in fast/js.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::SwitchRecord::):
- (KJS::SwitchRecord::SwitchRecord):
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::dump):
- * VM/CodeBlock.h:
- (KJS::ExpressionRangeInfo::):
- (KJS::StringJumpTable::offsetForValue):
- (KJS::StringJumpTable::ctiForValue):
- (KJS::SimpleJumpTable::add):
- (KJS::SimpleJumpTable::ctiForValue):
- * VM/CodeGenerator.cpp:
- (KJS::prepareJumpTableForStringSwitch):
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- (KJS::Machine::cti_op_switch_string):
- * VM/Machine.h:
-
-2008-08-28 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Do not recurse on the machine stack when executing op_call.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitGetPutArg):
- (KJS::CTI::emitPutArg):
- (KJS::CTI::emitPutArgConstant):
- (KJS::CTI::compileOpCall):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::):
- (KJS::CTI::compile):
- (KJS::CTI::execute):
- (KJS::CTI::):
- * VM/Machine.cpp:
- (KJS::Machine::Machine):
- (KJS::Machine::execute):
- (KJS::Machine::cti_op_call_JSFunction):
- (KJS::Machine::cti_op_call_NotJSFunction):
- (KJS::Machine::cti_op_ret):
- (KJS::Machine::cti_op_construct_JSConstruct):
- (KJS::Machine::cti_op_construct_NotJSConstruct):
- (KJS::Machine::cti_op_call_eval):
- * VM/Machine.h:
- * VM/Register.h:
- (KJS::Register::Register):
- * VM/RegisterFile.h:
- (KJS::RegisterFile::):
- * kjs/InternalFunction.h:
- (KJS::InternalFunction::InternalFunction):
- * kjs/JSFunction.h:
- (KJS::JSFunction::JSFunction):
- * kjs/ScopeChain.h:
- (KJS::ScopeChain::ScopeChain):
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::):
- (KJS::IA32MacroAssembler::emitModRm_opm):
- (KJS::IA32MacroAssembler::emitCmpl_i32m):
- (KJS::IA32MacroAssembler::emitCallN_r):
-
-2008-08-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Exit instead of crashing in ctiUnsupported and ctiTimedOut.
-
- * VM/Machine.cpp:
- (KJS::ctiUnsupported):
- (KJS::ctiTimedOut):
-
-2008-08-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Implement codegen for op_jsr and op_sret.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::CTI::JSRInfo::JSRInfo):
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::emitJmpN_m):
- (KJS::IA32MacroAssembler::linkAbsoluteAddress):
-
-2008-08-28 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Initial support for exceptions (throw / catch must occur in same CodeBlock).
-
- * VM/CTI.cpp:
- (KJS::CTI::emitExceptionCheck):
- (KJS::CTI::emitCall):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::nativeExceptionCodeForHandlerVPC):
- * VM/CodeBlock.h:
- * VM/CodeGenerator.cpp:
- (KJS::CodeGenerator::emitCatch):
- * VM/Machine.cpp:
- (KJS::Machine::throwException):
- (KJS::Machine::privateExecute):
- (KJS::ctiUnsupported):
- (KJS::ctiTimedOut):
- (KJS::Machine::cti_op_add):
- (KJS::Machine::cti_op_pre_inc):
- (KJS::Machine::cti_timeout_check):
- (KJS::Machine::cti_op_loop_if_less):
- (KJS::Machine::cti_op_put_by_id):
- (KJS::Machine::cti_op_get_by_id):
- (KJS::Machine::cti_op_instanceof):
- (KJS::Machine::cti_op_del_by_id):
- (KJS::Machine::cti_op_mul):
- (KJS::Machine::cti_op_call):
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_construct):
- (KJS::Machine::cti_op_get_by_val):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_sub):
- (KJS::Machine::cti_op_put_by_val):
- (KJS::Machine::cti_op_lesseq):
- (KJS::Machine::cti_op_loop_if_true):
- (KJS::Machine::cti_op_negate):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_div):
- (KJS::Machine::cti_op_pre_dec):
- (KJS::Machine::cti_op_jless):
- (KJS::Machine::cti_op_not):
- (KJS::Machine::cti_op_jtrue):
- (KJS::Machine::cti_op_post_inc):
- (KJS::Machine::cti_op_eq):
- (KJS::Machine::cti_op_lshift):
- (KJS::Machine::cti_op_bitand):
- (KJS::Machine::cti_op_rshift):
- (KJS::Machine::cti_op_bitnot):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_mod):
- (KJS::Machine::cti_op_less):
- (KJS::Machine::cti_op_neq):
- (KJS::Machine::cti_op_post_dec):
- (KJS::Machine::cti_op_urshift):
- (KJS::Machine::cti_op_bitxor):
- (KJS::Machine::cti_op_bitor):
- (KJS::Machine::cti_op_call_eval):
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_op_push_scope):
- (KJS::Machine::cti_op_stricteq):
- (KJS::Machine::cti_op_nstricteq):
- (KJS::Machine::cti_op_to_jsnumber):
- (KJS::Machine::cti_op_in):
- (KJS::Machine::cti_op_del_by_val):
- (KJS::Machine::cti_vm_throw):
- * VM/Machine.h:
- * kjs/ExecState.h:
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::emitCmpl_i32m):
-
-2008-08-28 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Print debugging info to stderr so that run-webkit-tests can capture it.
- This makes it easy to check whether test failures are due to unimplemented
- op codes, missing support for exceptions, etc.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::printOpcodeOperandTypes):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- (KJS::CTI::privateCompile):
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- (KJS::ctiException):
- (KJS::ctiUnsupported):
- (KJS::Machine::cti_op_call):
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_construct):
- (KJS::Machine::cti_op_get_by_val):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_call_eval):
-
-2008-08-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Gavin Barraclough and Maciej Stachowiak.
-
- Fix fast/js/bitwise-and-on-undefined.html.
-
- A temporary value in the slow path of op_bitand was being stored in edx, but was
- being clobbered by emitGetPutArg before we used it. To fix this, emitGetPutArg
- now takes a third argument that specifies the scratch register to use when loading
- from memory. This allows us to avoid clobbering the temporary in op_bitand.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitGetPutArg):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- * VM/CTI.h:
-
-2008-08-27 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Switch CTI on by default.
-
- * wtf/Platform.h:
-
-2008-08-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix the build of the full WebKit stack.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Mark two new headers as private so they can be pulled in from WebCore.
- * VM/CTI.h: Fix build issues that show up when compiled with GCC 4.2 as part of WebCore.
- * wrec/WREC.h: Ditto.
-
-2008-08-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implement op_new_error. Does not fix any tests as it is always followed by the unimplemented op_throw.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_new_error):
- * VM/Machine.h:
-
-2008-08-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Implement op_put_getter and op_put_setter.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_put_getter):
- (KJS::Machine::cti_op_put_setter):
- * VM/Machine.h:
-
-2008-08-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Implement op_del_by_val fixing 3 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_del_by_val):
- * VM/Machine.h:
-
-2008-08-27 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Quick & dirty fix to get SamplingTool sampling op_call.
-
- * VM/SamplingTool.h:
- (KJS::SamplingTool::callingHostFunction):
-
-2008-08-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Fix op_put_by_index.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main): Use emitPutArgConstant instead of emitGetPutArg
- for the property value.
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_put_by_index): Get the property value from the correct argument.
-
-2008-08-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Implement op_switch_imm in the CTI fixing 13 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_switch_imm):
- * VM/Machine.h:
-
-2008-08-27 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Implement op_switch_char in CTI.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitCall):
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- (KJS::CallRecord::CallRecord):
- (KJS::SwitchRecord::SwitchRecord):
- * VM/CodeBlock.h:
- (KJS::SimpleJumpTable::SimpleJumpTable::ctiForValue):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_switch_char):
- * VM/Machine.h:
- * masm/IA32MacroAsm.h:
- (KJS::IA32MacroAssembler::):
- (KJS::IA32MacroAssembler::emitJmpN_r):
- (KJS::IA32MacroAssembler::getRelocatedAddress):
- * wtf/Platform.h:
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Implement op_put_by_index to fix 1 mozilla test.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_put_by_index):
- * VM/Machine.h:
-
-2008-08-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- More fixes from Geoff's review.
-
- * VM/CTI.cpp:
- (KJS::CTI::emitGetArg):
- (KJS::CTI::emitGetPutArg):
- (KJS::CTI::emitPutArg):
- (KJS::CTI::emitPutArgConstant):
- (KJS::CTI::getConstantImmediateNumericArg):
- (KJS::CTI::emitGetCTIParam):
- (KJS::CTI::emitPutResult):
- (KJS::CTI::emitCall):
- (KJS::CTI::emitJumpSlowCaseIfNotImm):
- (KJS::CTI::emitJumpSlowCaseIfNotImms):
- (KJS::CTI::getDeTaggedConstantImmediate):
- (KJS::CTI::emitFastArithDeTagImmediate):
- (KJS::CTI::emitFastArithReTagImmediate):
- (KJS::CTI::emitFastArithPotentiallyReTagImmediate):
- (KJS::CTI::emitFastArithImmToInt):
- (KJS::CTI::emitFastArithIntToImmOrSlowCase):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Implement op_jmp_scopes to fix 2 Mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_push_new_scope): Update ExecState::m_scopeChain after calling ARG_setScopeChain.
- (KJS::Machine::cti_op_jmp_scopes):
- * VM/Machine.h:
-
-2008-08-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- WebKit Regular Expression Compiler. (set ENABLE_WREC = 1 in Platform.h).
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/regexp.cpp:
- * kjs/regexp.h:
- * wrec: Added.
- * wrec/WREC.cpp: Added.
- * wrec/WREC.h: Added.
- * wtf/Platform.h:
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Oliver Hunt.
-
- Remove bogus assertion.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_del_by_id):
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implement op_push_new_scope and stub out op_catch. This fixes 11 Mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_push_new_scope):
- (KJS::Machine::cti_op_catch):
- * VM/Machine.h:
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Clean up op_resolve_base so that it shares its implementation with the bytecode interpreter.
-
- * VM/Machine.cpp:
- (KJS::inlineResolveBase):
- (KJS::resolveBase):
-
-2008-08-26 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add codegen support for op_instanceof, fixing 15 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_instanceof):
- (KJS::Machine::cti_op_del_by_id):
- * VM/Machine.h:
- * wtf/Platform.h:
-
-2008-08-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fixes for initial review comments.
-
- * VM/CTI.cpp:
- (KJS::CTI::ctiCompileGetArg):
- (KJS::CTI::ctiCompileGetPutArg):
- (KJS::CTI::ctiCompilePutResult):
- (KJS::CTI::ctiCompileCall):
- (KJS::CTI::CTI):
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::printOpcodeOperandTypes):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- (KJS::CTI::privateCompile):
- * VM/CTI.h:
- * VM/Register.h:
- * kjs/JSValue.h:
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Fix up exception checking code.
-
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_call):
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_construct):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_call_eval):
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix slowcase for op_post_inc and op_post_dec fixing 2 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass4_SlowCases):
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implement op_in, fixing 8 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_in):
- * VM/Machine.h:
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Don't hardcode the size of a Register for op_new_array. Fixes a crash
- seen during the Mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main):
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Add support for op_push_scope and op_pop_scope, fixing 20 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/CTI.h:
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_push_scope):
- (KJS::Machine::cti_op_pop_scope):
- * VM/Machine.h:
-
-2008-08-26 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Add codegen support for op_del_by_id, fixing 49 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
- * VM/Machine.cpp:
- (KJS::Machine::cti_op_del_by_id):
- * VM/Machine.h:
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Gavin Barraclough and Geoff Garen.
-
- Don't hardcode the size of a Register for op_get_scoped_var and op_put_scoped_var
- fixing 513 mozilla tests in debug build.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass2_Main):
-
-2008-08-26 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Added code generator support for op_loop, fixing around 60 mozilla tests.
-
- * VM/CTI.cpp:
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::privateCompile_pass2_Main):
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Set -fomit-frame-pointer in the correct location.
-
- * Configurations/JavaScriptCore.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-08-26 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Inital cut of CTI, Geoff's review fixes to follow.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/CTI.cpp: Added.
- (KJS::getJCB):
- (KJS::CTI::ctiCompileGetArg):
- (KJS::CTI::ctiCompileGetPutArg):
- (KJS::CTI::ctiCompilePutArg):
- (KJS::CTI::ctiCompilePutArgImm):
- (KJS::CTI::ctiImmediateNumericArg):
- (KJS::CTI::ctiCompileGetCTIParam):
- (KJS::CTI::ctiCompilePutResult):
- (KJS::CTI::ctiCompileCall):
- (KJS::CTI::slowCaseIfNotImm):
- (KJS::CTI::slowCaseIfNotImms):
- (KJS::CTI::ctiFastArithDeTagConstImmediate):
- (KJS::CTI::ctiFastArithDeTagImmediate):
- (KJS::CTI::ctiFastArithReTagImmediate):
- (KJS::CTI::ctiFastArithPotentiallyReTagImmediate):
- (KJS::CTI::ctiFastArithImmToInt):
- (KJS::CTI::ctiFastArithIntToImmOrSlowCase):
- (KJS::CTI::CTI):
- (KJS::CTI::privateCompile_pass1_Scan):
- (KJS::CTI::ctiCompileAdd):
- (KJS::CTI::ctiCompileAddImm):
- (KJS::CTI::ctiCompileAddImmNotInt):
- (KJS::CTI::TEMP_HACK_PRINT_TYPES):
- (KJS::CTI::privateCompile_pass2_Main):
- (KJS::CTI::privateCompile_pass3_Link):
- (KJS::CTI::privateCompile_pass4_SlowCases):
- (KJS::CTI::privateCompile):
- * VM/CTI.h: Added.
- (KJS::CTI2Result::CTI2Result):
- (KJS::CallRecord::CallRecord):
- (KJS::JmpTable::JmpTable):
- (KJS::SlowCaseEntry::SlowCaseEntry):
- (KJS::CTI::compile):
- (KJS::CTI::LabelInfo::LabelInfo):
- * VM/CodeBlock.h:
- (KJS::CodeBlock::CodeBlock):
- (KJS::CodeBlock::~CodeBlock):
- * VM/Machine.cpp:
- (KJS::Machine::execute):
- (KJS::Machine::privateExecute):
- (KJS::ctiException):
- (KJS::ctiUnsupported):
- (KJS::ctiTimedOut):
- (KJS::Machine::cti_op_end):
- (KJS::Machine::cti_op_add):
- (KJS::Machine::cti_op_pre_inc):
- (KJS::Machine::cti_timeout_check):
- (KJS::Machine::cti_op_loop_if_less):
- (KJS::Machine::cti_op_new_object):
- (KJS::Machine::cti_op_put_by_id):
- (KJS::Machine::cti_op_get_by_id):
- (KJS::Machine::cti_op_mul):
- (KJS::Machine::cti_op_new_func):
- (KJS::Machine::cti_op_call):
- (KJS::Machine::cti_op_ret):
- (KJS::Machine::cti_op_new_array):
- (KJS::Machine::cti_op_resolve):
- (KJS::Machine::cti_op_construct):
- (KJS::Machine::cti_op_get_by_val):
- (KJS::Machine::cti_op_resolve_func):
- (KJS::Machine::cti_op_sub):
- (KJS::Machine::cti_op_put_by_val):
- (KJS::Machine::cti_op_lesseq):
- (KJS::Machine::cti_op_loop_if_true):
- (KJS::Machine::cti_op_negate):
- (KJS::Machine::cti_op_resolve_base):
- (KJS::Machine::cti_op_resolve_skip):
- (KJS::Machine::cti_op_div):
- (KJS::Machine::cti_op_pre_dec):
- (KJS::Machine::cti_op_jless):
- (KJS::Machine::cti_op_not):
- (KJS::Machine::cti_op_jtrue):
- (KJS::Machine::cti_op_post_inc):
- (KJS::Machine::cti_op_eq):
- (KJS::Machine::cti_op_lshift):
- (KJS::Machine::cti_op_bitand):
- (KJS::Machine::cti_op_rshift):
- (KJS::Machine::cti_op_bitnot):
- (KJS::Machine::cti_op_resolve_with_base):
- (KJS::Machine::cti_op_new_func_exp):
- (KJS::Machine::cti_op_mod):
- (KJS::Machine::cti_op_less):
- (KJS::Machine::cti_op_neq):
- (KJS::Machine::cti_op_post_dec):
- (KJS::Machine::cti_op_urshift):
- (KJS::Machine::cti_op_bitxor):
- (KJS::Machine::cti_op_new_regexp):
- (KJS::Machine::cti_op_bitor):
- (KJS::Machine::cti_op_call_eval):
- (KJS::Machine::cti_op_throw):
- (KJS::Machine::cti_op_get_pnames):
- (KJS::Machine::cti_op_next_pname):
- (KJS::Machine::cti_op_typeof):
- (KJS::Machine::cti_op_stricteq):
- (KJS::Machine::cti_op_nstricteq):
- (KJS::Machine::cti_op_to_jsnumber):
- * VM/Machine.h:
- * VM/Register.h:
- (KJS::Register::jsValue):
- (KJS::Register::getJSValue):
- (KJS::Register::codeBlock):
- (KJS::Register::scopeChain):
- (KJS::Register::i):
- (KJS::Register::r):
- (KJS::Register::vPC):
- (KJS::Register::jsPropertyNameIterator):
- * VM/SamplingTool.cpp:
- (KJS::):
- (KJS::SamplingTool::run):
- (KJS::SamplingTool::dump):
- * VM/SamplingTool.h:
- * kjs/JSImmediate.h:
- (KJS::JSImmediate::zeroImmediate):
- (KJS::JSImmediate::oneImmediate):
- * kjs/JSValue.h:
- * kjs/JSVariableObject.h:
- (KJS::JSVariableObject::JSVariableObjectData::offsetOf_registers):
- (KJS::JSVariableObject::offsetOf_d):
- (KJS::JSVariableObject::offsetOf_Data_registers):
- * masm: Added.
- * masm/IA32MacroAsm.h: Added.
- (KJS::JITCodeBuffer::JITCodeBuffer):
- (KJS::JITCodeBuffer::putByte):
- (KJS::JITCodeBuffer::putShort):
- (KJS::JITCodeBuffer::putInt):
- (KJS::JITCodeBuffer::getEIP):
- (KJS::JITCodeBuffer::start):
- (KJS::JITCodeBuffer::getOffset):
- (KJS::JITCodeBuffer::reset):
- (KJS::JITCodeBuffer::copy):
- (KJS::IA32MacroAssembler::):
- (KJS::IA32MacroAssembler::emitModRm_rr):
- (KJS::IA32MacroAssembler::emitModRm_rm):
- (KJS::IA32MacroAssembler::emitModRm_rmsib):
- (KJS::IA32MacroAssembler::emitModRm_opr):
- (KJS::IA32MacroAssembler::emitModRm_opm):
- (KJS::IA32MacroAssembler::IA32MacroAssembler):
- (KJS::IA32MacroAssembler::emitInt3):
- (KJS::IA32MacroAssembler::emitPushl_r):
- (KJS::IA32MacroAssembler::emitPopl_r):
- (KJS::IA32MacroAssembler::emitMovl_rr):
- (KJS::IA32MacroAssembler::emitAddl_rr):
- (KJS::IA32MacroAssembler::emitAddl_i8r):
- (KJS::IA32MacroAssembler::emitAddl_i32r):
- (KJS::IA32MacroAssembler::emitAddl_mr):
- (KJS::IA32MacroAssembler::emitAndl_rr):
- (KJS::IA32MacroAssembler::emitAndl_i32r):
- (KJS::IA32MacroAssembler::emitCmpl_i8r):
- (KJS::IA32MacroAssembler::emitCmpl_rr):
- (KJS::IA32MacroAssembler::emitCmpl_rm):
- (KJS::IA32MacroAssembler::emitCmpl_i32r):
- (KJS::IA32MacroAssembler::emitCmpw_rm):
- (KJS::IA32MacroAssembler::emitOrl_rr):
- (KJS::IA32MacroAssembler::emitOrl_i8r):
- (KJS::IA32MacroAssembler::emitSubl_rr):
- (KJS::IA32MacroAssembler::emitSubl_i8r):
- (KJS::IA32MacroAssembler::emitSubl_i32r):
- (KJS::IA32MacroAssembler::emitSubl_mr):
- (KJS::IA32MacroAssembler::emitTestl_i32r):
- (KJS::IA32MacroAssembler::emitTestl_rr):
- (KJS::IA32MacroAssembler::emitXorl_i8r):
- (KJS::IA32MacroAssembler::emitXorl_rr):
- (KJS::IA32MacroAssembler::emitSarl_i8r):
- (KJS::IA32MacroAssembler::emitSarl_CLr):
- (KJS::IA32MacroAssembler::emitShl_i8r):
- (KJS::IA32MacroAssembler::emitShll_CLr):
- (KJS::IA32MacroAssembler::emitMull_rr):
- (KJS::IA32MacroAssembler::emitIdivl_r):
- (KJS::IA32MacroAssembler::emitCdq):
- (KJS::IA32MacroAssembler::emitMovl_mr):
- (KJS::IA32MacroAssembler::emitMovzwl_mr):
- (KJS::IA32MacroAssembler::emitMovl_rm):
- (KJS::IA32MacroAssembler::emitMovl_i32r):
- (KJS::IA32MacroAssembler::emitMovl_i32m):
- (KJS::IA32MacroAssembler::emitLeal_mr):
- (KJS::IA32MacroAssembler::emitRet):
- (KJS::IA32MacroAssembler::JmpSrc::JmpSrc):
- (KJS::IA32MacroAssembler::JmpDst::JmpDst):
- (KJS::IA32MacroAssembler::emitCall):
- (KJS::IA32MacroAssembler::label):
- (KJS::IA32MacroAssembler::emitUnlinkedJmp):
- (KJS::IA32MacroAssembler::emitUnlinkedJne):
- (KJS::IA32MacroAssembler::emitUnlinkedJe):
- (KJS::IA32MacroAssembler::emitUnlinkedJl):
- (KJS::IA32MacroAssembler::emitUnlinkedJle):
- (KJS::IA32MacroAssembler::emitUnlinkedJge):
- (KJS::IA32MacroAssembler::emitUnlinkedJae):
- (KJS::IA32MacroAssembler::emitUnlinkedJo):
- (KJS::IA32MacroAssembler::emitPredictionNotTaken):
- (KJS::IA32MacroAssembler::link):
- (KJS::IA32MacroAssembler::copy):
- * wtf/Platform.h:
-
-2008-08-26 Oliver Hunt <oliver@apple.com>
-
- RS=Maciej.
-
- Enabled -fomit-frame-pointer on Release and Production builds, add additional Profiling build config for shark, etc.
-
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-=== Start merge of squirrelfish-extreme ===
-
-2008-09-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Fix the Mac Debug build by adding symbols that are exported only in a
- Debug configuration.
-
- * Configurations/JavaScriptCore.xcconfig:
- * DerivedSources.make:
- * JavaScriptCore.Debug.exp: Added.
- * JavaScriptCore.base.exp: Copied from JavaScriptCore.exp.
- * JavaScriptCore.exp: Removed.
- * JavaScriptCore.xcodeproj/project.pbxproj:
-
-2008-09-05 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20681
- JSPropertyNameIterator functions need to be inlined
-
- 1.007x as fast on SunSpider overall
- 1.081x as fast on SunSpider math-cordic
-
- * VM/JSPropertyNameIterator.cpp: Moved functions out of here.
- * VM/JSPropertyNameIterator.h:
- (KJS::JSPropertyNameIterator::JSPropertyNameIterator): Moved
- this into the header and marked it inline.
- (KJS::JSPropertyNameIterator::create): Ditto.
- (KJS::JSPropertyNameIterator::next): Ditto.
-
-2008-09-05 Darin Adler <darin@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20673
- single-character strings are churning in the Identifier table
-
- 1.007x as fast on SunSpider overall
- 1.167x as fast on SunSpider string-fasta
-
- * JavaScriptCore.exp: Updated.
- * kjs/SmallStrings.cpp:
- (KJS::SmallStrings::singleCharacterStringRep): Added.
- * kjs/SmallStrings.h: Added singleCharacterStringRep for clients that
- need just a UString, not a JSString.
- * kjs/identifier.cpp:
- (KJS::Identifier::add): Added special cases for single character strings
- so that the UString::Rep that ends up in the identifier table is the one
- from the single-character string optimization; otherwise we end up having
- to look it up in the identifier table over and over again.
- (KJS::Identifier::addSlowCase): Ditto.
- (KJS::Identifier::checkSameIdentifierTable): Made this function an empty
- inline in release builds so that callers don't have to put #ifndef NDEBUG
- at each call site.
- * kjs/identifier.h:
- (KJS::Identifier::add): Removed #ifndef NDEBUG around the calls to
- checkSameIdentifierTable.
- (KJS::Identifier::checkSameIdentifierTable): Added. Empty inline version
- for NDEBUG builds.
-
-2008-09-05 Mark Rowe <mrowe@apple.com>
-
- Build fix.
-
- * kjs/JSObject.h: Move the inline virtual destructor after a non-inline
- virtual function so that the symbol for the vtable is not marked as a
- weakly exported symbol.
-
-2008-09-05 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20671
- JavaScriptCore string manipulation spends too much time in memcpy
-
- 1.011x as fast on SunSpider overall
- 1.028x as fast on SunSpider string tests
-
- For small strings, use a loop rather than calling memcpy. The loop can
- be faster because there's no function call overhead, and because it can
- assume the pointers are aligned instead of checking that. Currently the
- threshold is set at 20 characters, based on some testing on one particular
- computer. Later we can tune this for various platforms by setting
- USTRING_COPY_CHARS_INLINE_CUTOFF appropriately, but it does no great harm
- if not perfectly tuned.
-
- * kjs/ustring.cpp:
- (KJS::overflowIndicator): Removed bogus const.
- (KJS::maxUChars): Ditto.
- (KJS::copyChars): Added.
- (KJS::UString::Rep::createCopying): Call copyChars instead of memcpy.
- Also eliminated need for const_cast.
- (KJS::UString::expandPreCapacity): Ditto.
- (KJS::concatenate): Ditto.
- (KJS::UString::spliceSubstringsWithSeparators): Ditto.
- (KJS::UString::append): Ditto.
-
-2008-09-05 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Sam and Alexey.
-
- Make the profiler work with a null exec state. This will allow other
- applications start the profiler to get DTrace probes going without
- needing a WebView.
-
- * ChangeLog:
- * profiler/ProfileGenerator.cpp:
- (KJS::ProfileGenerator::ProfileGenerator):
- (KJS::ProfileGenerator::willExecute):
- (KJS::ProfileGenerator::didExecute):
- * profiler/Profiler.cpp:
- (KJS::Profiler::startProfiling):
- (KJS::Profiler::stopProfiling):
- (KJS::dispatchFunctionToProfiles):
-
-2008-09-04 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Fixed an off-by-one error that would cause the StructureIDChain to
- be one object too short.
-
- Can't construct a test case because other factors make this not crash
- (yet!).
-
- * kjs/StructureID.cpp:
- (KJS::StructureIDChain::StructureIDChain):
-
-2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes.
-
- * JavaScriptCoreSources.bkl:
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Eric Seidel.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
- Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
-
- * Configurations/JavaScriptCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
- * wtf/Platform.h: Set ENABLE_DASHBOARD_SUPPORT for PLATFORM(MAC).
-
-2008-09-04 Adele Peterson <adele@apple.com>
-
- Build fix.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.vcproj/jsc/jsc.vcproj:
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Mac build fix.
-
- * kjs/config.h: Only check the value of HAVE_CONFIG_H if it is defined.
-
-2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Eric Seidel.
-
- http://bugs.webkit.org/show_bug.cgi?id=20380
- [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
-
- * kjs/config.h: Include the configuration header generated by
- autotools if available.
-
-2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Fix the QtWebKit build to match changes in r36016
-
- * JavaScriptCore.pri:
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Fix the 64-bit build.
-
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::printStructureID): Store the instruction offset into an unsigned local
- to avoid a warning related to format specifiers.
- (KJS::CodeBlock::printStructureIDs): Ditto.
-
-2008-09-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Oliver Hunt.
-
- Correct the spelling of 'entryIndices'.
-
- * kjs/PropertyMap.cpp:
- (KJS::PropertyMap::get):
- (KJS::PropertyMap::getLocation):
- (KJS::PropertyMap::put):
- (KJS::PropertyMap::insert):
- (KJS::PropertyMap::remove):
- (KJS::PropertyMap::checkConsistency):
- * kjs/PropertyMap.h:
- (KJS::PropertyMapHashTable::entries):
- (KJS::PropertyMap::getOffset):
- (KJS::PropertyMap::putOffset):
- (KJS::PropertyMap::offsetForTableLocation):
-
-2008-09-03 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed <rdar://problem/6193925> REGRESSION: Crash occurs at
- KJS::Machine::privateExecute() when attempting to load my Mobile Gallery
- (http://www.me.com/gallery/#home)
-
- also
-
- https://bugs.webkit.org/show_bug.cgi?id=20633 Crash in privateExecute
- @ cs.byu.edu
-
- The underlying problem was that we would cache prototype properties
- even if the prototype was a dictionary.
-
- The fix is to transition a prototype back from dictionary to normal
- status when an opcode caches access to it. (This is better than just
- refusing to cache, since a heavily accessed prototype is almost
- certainly not a true dictionary.)
-
- * VM/Machine.cpp:
- (KJS::Machine::tryCacheGetByID):
- * kjs/JSObject.h:
-
-2008-09-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam.
-
- Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
-
- * Configurations/JavaScriptCore.xcconfig: add missing ENABLE_*
- * wtf/ASCIICType.h: include <wtf/Assertions.h> since it depends on it.
- * wtf/Platform.h:
-
-2008-09-03 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- Remove the rest of the "zombie" code from the profiler.
- - There is no longer a need for the ProfilerClient callback mechanism.
-
- * API/JSProfilerPrivate.cpp:
- (JSStartProfiling):
- * JavaScriptCore.exp:
- * profiler/HeavyProfile.h:
- * profiler/ProfileGenerator.cpp:
- (KJS::ProfileGenerator::create):
- (KJS::ProfileGenerator::ProfileGenerator):
- * profiler/ProfileGenerator.h:
- (KJS::ProfileGenerator::profileGroup):
- * profiler/Profiler.cpp:
- (KJS::Profiler::startProfiling):
- (KJS::Profiler::stopProfiling): Immediately return the profile when
- stopped instead of using a callback.
- * profiler/Profiler.h:
- * profiler/TreeProfile.h:
-
-2008-09-03 Adele Peterson <adele@apple.com>
-
- Build fix.
-
- * wtf/win/MainThreadWin.cpp:
-
-2008-09-02 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Darin and Tim.
-
- Remove most of the "zombie" mode from the profiler. Next we will need
- to remove the client callback mechanism in profiles.
-
- - This simplifies the code, leverages the recent changes I've made in
- getting line numbers from SquirrelFish, and is a slight speed
- improvement on SunSpider.
- - Also the "zombie" mode was a constant source of odd edge cases and
- obscure bugs so it's good to remove since all of its issues may not have
- been found.
-
- * API/JSProfilerPrivate.cpp: No need to call didFinishAllExecution() any
- more.
- (JSEndProfiling):
- * JavaScriptCore.exp: Export the new signature of retrieveLastCaller()
- * VM/Machine.cpp:
- (KJS::Machine::execute): No need to call didFinishAllExecution() any
- more.
- (KJS::Machine::retrieveCaller): Now operates on InternalFunctions now
- since the RegisterFile is no longer guaranteeded to store only
- JSFunctions
- (KJS::Machine::retrieveLastCaller): Now also retrieve the function's
- name
- (KJS::Machine::callFrame): A result of changing retrieveCaller()
- * VM/Machine.h:
- * VM/Register.h:
- * kjs/JSGlobalObject.cpp:
- (KJS::JSGlobalObject::~JSGlobalObject):
- * kjs/nodes.h:
- * profiler/ProfileGenerator.cpp:
- (KJS::ProfileGenerator::create): Now pass the original exec and get the
- global exec and client when necessary. We need the original exec so we
- can have the stack frame where profiling started.
- (KJS::ProfileGenerator::ProfileGenerator): ditto.
- (KJS::ProfileGenerator::addParentForConsoleStart): This is where the
- parent to star of the profile is added, if there is one.
- (KJS::ProfileGenerator::willExecute): Remove uglyness!
- (KJS::ProfileGenerator::didExecute): Ditto!
- (KJS::ProfileGenerator::stopProfiling):
- (KJS::ProfileGenerator::removeProfileStart): Use a better way to find
- and remove the function we are looking for.
- (KJS::ProfileGenerator::removeProfileEnd): Ditto.
- * profiler/ProfileGenerator.h:
- (KJS::ProfileGenerator::client):
- * profiler/ProfileNode.cpp:
- (KJS::ProfileNode::removeChild): Add a better way to remove a child from
- a ProfileNode.
- (KJS::ProfileNode::stopProfiling):
- (KJS::ProfileNode::debugPrintData): Modified a debug-only diagnostic
- function to be sane.
- * profiler/ProfileNode.h:
- * profiler/Profiler.cpp: Change to pass the original exec state.
- (KJS::Profiler::startProfiling):
- (KJS::Profiler::stopProfiling):
- (KJS::Profiler::willExecute):
- (KJS::Profiler::didExecute):
- (KJS::Profiler::createCallIdentifier):
- * profiler/Profiler.h:
-
-2008-09-01 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Implement callOnMainThreadAndWait().
-
- This will be useful when a background thread needs to perform UI calls synchronously
- (e.g. an openDatabase() call cannot return until the user answers to a confirmation dialog).
-
- * wtf/MainThread.cpp:
- (WTF::FunctionWithContext::FunctionWithContext): Added a ThreadCondition member. When
- non-zero, the condition is signalled after the function is called.
- (WTF::mainThreadFunctionQueueMutex): Renamed from functionQueueMutex, sinc this is no longer
- static. Changed to be initialized from initializeThreading() to avoid lock contention.
- (WTF::initializeMainThread): On non-Windows platforms, just call mainThreadFunctionQueueMutex.
- (WTF::dispatchFunctionsFromMainThread): Signal synchronous calls when done.
- (WTF::callOnMainThread): Updated for functionQueueMutex rename.
- (WTF::callOnMainThreadAndWait): Added.
-
- * wtf/MainThread.h: Added callOnMainThreadAndWait(); initializeMainThread() now exists on
- all platforms.
-
- * wtf/win/MainThreadWin.cpp: (WTF::initializeMainThread): Added a callOnMainThreadAndWait()
- call to initialize function queue mutex.
-
- * wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
- * wtf/ThreadingPthreads.cpp: (WTF::initializeThreading):
- * wtf/ThreadingQt.cpp: (WTF::initializeThreading):
- Only initialize mainThreadIdentifier on non-Darwin platforms. It was not guaranteed to be
- accurate on Darwin.
-
-2008-09-03 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Use isUndefinedOrNull() instead of separate checks for each in op_eq_null
- and op_neq_null.
-
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
-
-2008-09-02 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- Bug 20296: OpcodeStats doesn't build on platforms which don't have mergesort().
- <https://bugs.webkit.org/show_bug.cgi?id=20296>
-
- * VM/Opcode.cpp:
- (KJS::OpcodeStats::~OpcodeStats): mergesort() replaced with qsort()
-
-2008-09-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fast path for array.length and string.length.
-
- SunSpider says 0.5% faster.
-
-2008-09-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Added optimized paths for comparing to null.
-
- SunSpider says 0.5% faster.
-
-2008-09-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Changed jsDriver.pl to dump the exact text you would need in order to
- reproduce a test result. This enables a fast workflow where you copy
- and paste a test failure in the terminal.
-
- * tests/mozilla/jsDriver.pl:
-
-2008-09-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implemented the rest of Darin's review comments for the 09-01 inline
- caching patch.
-
- SunSpider says 0.5% faster, but that seems like noise.
-
- * JavaScriptCore.xcodeproj/project.pbxproj: Put PutPropertySlot into
- its own file, and added BatchedTransitionOptimizer.
-
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::~CodeBlock): Use array indexing instead of a pointer
- iterator.
-
- * VM/CodeGenerator.cpp:
- (KJS::CodeGenerator::CodeGenerator): Used BatchedTransitionOptimizer to
- make batched put and remove for declared variables fast, without forever
- pessimizing the global object. Removed the old getDirect/removeDirect hack
- that tried to do the same in a more limited way.
-
- * VM/CodeGenerator.h: Moved IdentifierRepHash to the KJS namespace since
- it doesn't specialize anything in WTF.
-
- * VM/Machine.cpp:
- (KJS::Machine::Machine): Nixed the DummyConstruct tag because it was
- confusingly named.
-
- (KJS::Machine::execute): Used BatchedTransitionOptimizer, as above. Fixed
- up some comments.
-
- (KJS::cachePrototypeChain): Cast to JSObject*, since it's more specific.
-
- (KJS::Machine::tryCachePutByID): Use isNull() instead of comparing to
- jsNull(), since isNull() leaves more options open for the future.
- (KJS::Machine::tryCacheGetByID): ditto
- (KJS::Machine::privateExecute): ditto
-
- * VM/SamplingTool.cpp:
- (KJS::SamplingTool::dump): Use C++-style cast, to match our style
- guidelines.
-
- * kjs/BatchedTransitionOptimizer.h: Added. New class that allows host
- code to add a batch of properties to an object in an efficient way.
-
- * kjs/JSActivation.cpp: Use isNull(), as above.
-
- * kjs/JSArray.cpp: Get rid of DummyConstruct tag, as above.
- * kjs/JSArray.h:
-
- * kjs/JSGlobalData.cpp: Nixed two unused StructureIDs.
- * kjs/JSGlobalData.h:
-
- * kjs/JSImmediate.cpp: Use isNull(), as above.
-
- * kjs/JSObject.cpp:
- (KJS::JSObject::mark): Moved mark tracing code elsewhere, to make this
- function more readable.
-
- (KJS::JSObject::put): Use isNull(), as above.
-
- (KJS::JSObject::createInheritorID): Return a raw pointer, since the
- object is owned by a data member, not necessarily the caller.
- * kjs/JSObject.h:
-
- * kjs/JSString.cpp: Use isNull(), as above.
-
- * kjs/PropertyMap.h: Updated to use PropertySlot::invalidOffset.
-
- * kjs/PropertySlot.h: Changed KJS_INVALID_OFFSET to WTF::notFound
- because C macros are so 80's.
-
- * kjs/PutPropertySlot.h: Added. Split out of PropertySlot.h. Also renamed
- PutPropertySlot::SlotType to PutPropertySlot::Type, and slotBase to base,
- since "slot" was redundant.
-
- * kjs/StructureID.cpp: Added a new transition *away* from dictionary
- status, to support BatchedTransitionOptimizer.
-
- (KJS::StructureIDChain::StructureIDChain): No need to store m_size as
- a data member, so keep it in a local, which might be faster.
- * kjs/StructureID.h:
-
- * kjs/SymbolTable.h: Moved IdentifierRepHash to KJS namespace, as above.
- * kjs/ustring.h:
-
-2008-09-02 Adam Roben <aroben@apple.com>
-
- Windows build fixes
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add
- StructureID.{cpp,h} to the project. Also let VS reorder this file.
- * VM/CodeBlock.cpp: Include StringExtras so that snprintf will be
- defined on Windows.
-
-2008-09-01 Sam Weinig <sam@webkit.org>
-
- Fix release build.
-
- * JavaScriptCore.exp:
-
-2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Gtk buildfix
-
- * GNUmakefile.am:
- * kjs/PropertyMap.cpp: rename Identifier.h to identifier.h
- * kjs/StructureID.cpp: include JSObject.h
-
-2008-09-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- First cut at inline caching for access to vanilla JavaScript properties.
-
- SunSpider says 4% faster. Tests heavy on dictionary-like access have
- regressed a bit -- we have a lot of room to improve in this area,
- but this patch is over-ripe as-is.
-
- JSCells now have a StructureID that uniquely identifies their layout,
- and holds their prototype.
-
- JSValue::put takes a PropertySlot& argument, so it can fill in details
- about where it put a value, for the sake of caching.
-
- * VM/CodeGenerator.cpp:
- (KJS::CodeGenerator::CodeGenerator): Avoid calling removeDirect if we
- can, since it disables inline caching in the global object. This can
- probably improve in the future.
-
- * kjs/JSGlobalObject.cpp: Nixed reset(), since it complicates caching, and
- wasn't really necessary.
-
- * kjs/JSObject.cpp: Tweaked getter / setter behavior not to rely on the
- IsGetterSetter flag, since the flag was buggy. This is necessary in order
- to avoid accidentally accessing a getter / setter as a normal property.
-
- Also changed getter / setter creation to honor ReadOnly, matching Mozilla.
-
- * kjs/PropertyMap.cpp: Nixed clear(), since it complicates caching and
- isn't necessary.
-
- * kjs/Shell.cpp: Moved SamplingTool dumping outside the loop. This allows
- you to aggregate sampling of multiple files (or the same file repeatedly),
- which helped me track down regressions.
-
- * kjs/ustring.h: Moved IdentifierRepHash here to share it.
-
-2008-09-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Eagerly allocate the Math object's numeric constants. This avoids
- constantly reallocating them in loops, and also ensures that the Math
- object will not use the single property optimization, which makes
- properties ineligible for caching.
-
- SunSpider reports a small speedup, in combination with inline caching.
-
- * kjs/MathObject.cpp:
- (KJS::MathObject::MathObject):
- (KJS::MathObject::getOwnPropertySlot):
- * kjs/MathObject.h:
-
-2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix, not reviewed.
-
- * GNUmakefile.am: Add SmallStrings.cpp in both release and debug builds
-
-2008-08-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20577: REGRESSION (r36006): Gmail is broken
- <https://bugs.webkit.org/show_bug.cgi?id=20577>
-
- r36006 changed stringProtoFuncSubstr() so that it is uses the more
- efficient jsSubstring(), rather than using UString::substr() and then
- calling jsString(). However, the change did not account for the case
- where the start and the length of the substring extend beyond the length
- of the original string. This patch corrects that.
-
- * kjs/StringPrototype.cpp:
- (KJS::stringProtoFuncSubstr):
-
-2008-08-31 Simon Hausmann <hausmann@wekit.org>
-
- Unreviewed build fix (with gcc 4.3)
-
- * kjs/ustring.h: Properly forward declare operator== for UString and
- the the concatenate functions inside the KJS namespace.
-
-2008-08-30 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20333
- improve JavaScript speed when handling single-character strings
-
- 1.035x as fast on SunSpider overall.
- 1.127x as fast on SunSpider string tests.
- 1.910x as fast on SunSpider string-base64 test.
-
- * API/JSObjectRef.cpp:
- (JSObjectMakeFunction): Removed unneeded explicit construction of UString.
-
- * GNUmakefile.am: Added SmallStrings.h and SmallStrings.cpp.
- * JavaScriptCore.pri: Ditto.
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Ditto.
- * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- * JavaScriptCoreSources.bkl: Ditto.
-
- * JavaScriptCore.exp: Updated.
-
- * VM/Machine.cpp:
- (KJS::jsAddSlowCase): Changed to use a code path that doesn't involve
- a UString constructor. This avoids an extra jump caused by the "in charge"
- vs. "not in charge" constructors.
- (KJS::jsAdd): Ditto.
- (KJS::jsTypeStringForValue): Adopted jsNontrivialString.
-
- * kjs/ArrayPrototype.cpp:
- (KJS::arrayProtoFuncToString): Adopted jsEmptyString.
- (KJS::arrayProtoFuncToLocaleString): Ditto.
- (KJS::arrayProtoFuncJoin): Ditto.
- * kjs/BooleanPrototype.cpp:
- (KJS::booleanProtoFuncToString): Adopted jsNontrivialString.
- * kjs/DateConstructor.cpp:
- (KJS::callDate): Ditto.
- * kjs/DatePrototype.cpp:
- (KJS::formatLocaleDate): Adopted jsEmptyString and jsNontrivialString.
- (KJS::dateProtoFuncToString): Ditto.
- (KJS::dateProtoFuncToUTCString): Ditto.
- (KJS::dateProtoFuncToDateString): Ditto.
- (KJS::dateProtoFuncToTimeString): Ditto.
- (KJS::dateProtoFuncToLocaleString): Ditto.
- (KJS::dateProtoFuncToLocaleDateString): Ditto.
- (KJS::dateProtoFuncToLocaleTimeString): Ditto.
- (KJS::dateProtoFuncToGMTString): Ditto.
-
- * kjs/ErrorPrototype.cpp:
- (KJS::ErrorPrototype::ErrorPrototype): Ditto.
- (KJS::errorProtoFuncToString): Ditto.
-
- * kjs/JSGlobalData.h: Added SmallStrings.
-
- * kjs/JSString.cpp:
- (KJS::jsString): Eliminated the overload that takes a const char*.
- Added code to use SmallStrings to get strings of small sizes rather
- than creating a new JSString every time.
- (KJS::jsSubstring): Added. Used when creating a string from a substring
- to avoid creating a JSString in cases where the substring will end up
- empty or as one character.
- (KJS::jsOwnedString): Added the same code as in jsString.
-
- * kjs/JSString.h: Added new functions jsEmptyString, jsSingleCharacterString,
- jsSingleCharacterSubstring, jsSubstring, and jsNontrivialString for various
- cases where we want to create JSString, and want special handling for small
- strings.
- (KJS::JSString::JSString): Added an overload that takes a PassRefPtr of
- a UString::Rep so you don't have to construct a UString; PassRefPtr can be
- more efficient.
- (KJS::jsEmptyString): Added.
- (KJS::jsSingleCharacterString): Added.
- (KJS::jsSingleCharacterSubstring): Added.
- (KJS::jsNontrivialString): Added.
- (KJS::JSString::getIndex): Adopted jsSingleCharacterSubstring.
- (KJS::JSString::getStringPropertySlot): Ditto.
-
- * kjs/NumberPrototype.cpp:
- (KJS::numberProtoFuncToFixed): Adopted jsNontrivialString.
- (KJS::numberProtoFuncToExponential): Ditto.
- (KJS::numberProtoFuncToPrecision): Ditto.
-
- * kjs/ObjectPrototype.cpp:
- (KJS::objectProtoFuncToLocaleString): Adopted toThisJSString.
- (KJS::objectProtoFuncToString): Adopted jsNontrivialString.
-
- * kjs/RegExpConstructor.cpp: Separated the lastInput value that's used
- with the lastOvector to return matches from the input value that can be
- changed via JavaScript. They will be equal in many cases, but not all.
- (KJS::RegExpConstructor::performMatch): Set input.
- (KJS::RegExpMatchesArray::RegExpMatchesArray): Ditto.
- (KJS::RegExpMatchesArray::fillArrayInstance): Adopted jsSubstring. Also,
- use input rather than lastInput in the appropriate place.
- (KJS::RegExpConstructor::getBackref): Adopted jsSubstring and jsEmptyString.
- Added code to handle the case where there is no backref -- before this
- depended on range checking in UString::substr which is not present in
- jsSubstring.
- (KJS::RegExpConstructor::getLastParen): Ditto.
- (KJS::RegExpConstructor::getLeftContext): Ditto.
- (KJS::RegExpConstructor::getRightContext): Ditto.
- (KJS::RegExpConstructor::getValueProperty): Use input rather than lastInput.
- Also adopt jsEmptyString.
- (KJS::RegExpConstructor::putValueProperty): Ditto.
- (KJS::RegExpConstructor::input): Ditto.
-
- * kjs/RegExpPrototype.cpp:
- (KJS::regExpProtoFuncToString): Adopt jsNonTrivialString. Also changed to
- use UString::append to append single characters rather than using += and
- a C-style string.
-
- * kjs/SmallStrings.cpp: Added.
- (KJS::SmallStringsStorage::SmallStringsStorage): Construct the
- buffer and UString::Rep for all 256 single-character strings for
- the U+0000 through U+00FF. This covers all the values used in
- the base64 test as well as most values seen elsewhere on the web
- as well. It's possible that later we might fix this to only work
- for U+0000 through U+007F but the others are used quite a bit in
- the current version of the base64 test.
- (KJS::SmallStringsStorage::~SmallStringsStorage): Free memory.
- (KJS::SmallStrings::SmallStrings): Create a set of small strings,
- initially not created; created later when they are used.
- (KJS::SmallStrings::~SmallStrings): Deallocate. Not left compiler
- generated because the SmallStringsStorage class's destructor needs
- to be visible.
- (KJS::SmallStrings::mark): Mark all the strings.
- (KJS::SmallStrings::createEmptyString): Create a cell for the
- empty string. Called only the first time.
- (KJS::SmallStrings::createSingleCharacterString): Create a cell
- for one of the single-character strings. Called only the first time.
- * kjs/SmallStrings.h: Added.
-
- * kjs/StringConstructor.cpp:
- (KJS::stringFromCharCodeSlowCase): Factored out of strinFromCharCode.
- Only used for cases where the caller does not pass exactly one argument.
- (KJS::stringFromCharCode): Adopted jsSingleCharacterString.
- (KJS::callStringConstructor): Adopted jsEmptyString.
-
- * kjs/StringObject.cpp:
- (KJS::StringObject::StringObject): Adopted jsEmptyString.
-
- * kjs/StringPrototype.cpp:
- (KJS::stringProtoFuncReplace): Adopted jsSubstring.
- (KJS::stringProtoFuncCharAt): Adopted jsEmptyString and
- jsSingleCharacterSubstring and also added a special case when the
- index is an immediate number to avoid conversion to and from floating
- point, since that's the common case.
- (KJS::stringProtoFuncCharCodeAt): Ditto.
- (KJS::stringProtoFuncMatch): Adopted jsSubstring and jsEmptyString.
- (KJS::stringProtoFuncSlice): Adopted jsSubstring and
- jsSingleCharacterSubstring. Also got rid of some unneeded locals and
- removed unneeded code to set the length property of the array, since it
- is automatically updated as values are added to the array.
- (KJS::stringProtoFuncSplit): Adopted jsEmptyString.
- (KJS::stringProtoFuncSubstr): Adopted jsSubstring.
- (KJS::stringProtoFuncSubstring): Ditto.
-
- * kjs/collector.cpp:
- (KJS::Heap::collect): Added a call to mark SmallStrings.
-
- * kjs/ustring.cpp:
- (KJS::UString::expandedSize): Made this a static member function since
- it doesn't need to look at any data members.
- (KJS::UString::expandCapacity): Use a non-inline function, makeNull, to
- set the rep to null in failure cases. This avoids adding a PIC branch for
- the normal case when there is no failure.
- (KJS::UString::expandPreCapacity): Ditto.
- (KJS::UString::UString): Ditto.
- (KJS::concatenate): Refactored the concatenation constructor into this
- separate function. Calling the concatenation constructor was leading to
- an extra branch because of the in-charge vs. not-in-charge versions not
- both being inlined, and this was showing up as nearly 1% on Shark. Also
- added a special case for when the second string is a single character,
- since it's a common idiom to build up a string that way and we can do
- things much more quickly, without involving memcpy for example. Also
- adopted the non-inline function, nullRep, for the same reason given for
- makeNull above.
- (KJS::UString::append): Adopted makeNull for failure cases.
- (KJS::UString::operator=): Ditto.
- (KJS::UString::toDouble): Added a special case for converting single
- character strings to numbers. We're doing this a ton of times while
- running the base64 test.
- (KJS::operator==): Added special cases so we can compare single-character
- strings without calling memcmp. Later we might want to special case other
- short lengths similarly.
- (KJS::UString::makeNull): Added.
- (KJS::UString::nullRep): Added.
- * kjs/ustring.h: Added declarations for the nullRep and makeNull. Changed
- expandedSize to be a static member function. Added a declaration of the
- concatenate function. Removed the concatenation constructor. Rewrote
- operator+ to use the concatenate function.
-
-2008-08-29 Anders Carlsson <andersca@apple.com>
-
- Build fix.
-
- * VM/Machine.cpp:
- (KJS::getCPUTime):
-
-2008-08-29 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6174667>
- When a machine is under heavy load, the Slow Script dialog often comes up many times and just gets in the way
-
- Instead of using clock time, use the CPU time spent executing the current thread when
- determining if the script has been running for too long.
-
- * VM/Machine.cpp:
- (KJS::getCPUTime):
- (KJS::Machine::checkTimeout):
-
-2008-08-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Sam Weinig.
-
- Change 'term' to 'expr' in variable names to standardize terminology.
-
- * kjs/nodes.cpp:
- (KJS::BinaryOpNode::emitCode):
- (KJS::ReverseBinaryOpNode::emitCode):
- (KJS::ThrowableBinaryOpNode::emitCode):
- * kjs/nodes.h:
- (KJS::BinaryOpNode::BinaryOpNode):
- (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode):
- (KJS::MultNode::):
- (KJS::DivNode::):
- (KJS::ModNode::):
- (KJS::AddNode::):
- (KJS::SubNode::):
- (KJS::LeftShiftNode::):
- (KJS::RightShiftNode::):
- (KJS::UnsignedRightShiftNode::):
- (KJS::LessNode::):
- (KJS::GreaterNode::):
- (KJS::LessEqNode::):
- (KJS::GreaterEqNode::):
- (KJS::ThrowableBinaryOpNode::):
- (KJS::InstanceOfNode::):
- (KJS::InNode::):
- (KJS::EqualNode::):
- (KJS::NotEqualNode::):
- (KJS::StrictEqualNode::):
- (KJS::NotStrictEqualNode::):
- (KJS::BitAndNode::):
- (KJS::BitOrNode::):
- (KJS::BitXOrNode::):
- * kjs/nodes2string.cpp:
- (KJS::MultNode::streamTo):
- (KJS::DivNode::streamTo):
- (KJS::ModNode::streamTo):
- (KJS::AddNode::streamTo):
- (KJS::SubNode::streamTo):
- (KJS::LeftShiftNode::streamTo):
- (KJS::RightShiftNode::streamTo):
- (KJS::UnsignedRightShiftNode::streamTo):
- (KJS::LessNode::streamTo):
- (KJS::GreaterNode::streamTo):
- (KJS::LessEqNode::streamTo):
- (KJS::GreaterEqNode::streamTo):
- (KJS::InstanceOfNode::streamTo):
- (KJS::InNode::streamTo):
- (KJS::EqualNode::streamTo):
- (KJS::NotEqualNode::streamTo):
- (KJS::StrictEqualNode::streamTo):
- (KJS::NotStrictEqualNode::streamTo):
- (KJS::BitAndNode::streamTo):
- (KJS::BitXOrNode::streamTo):
- (KJS::BitOrNode::streamTo):
-
-2008-08-28 Alp Toker <alp@nuanti.com>
-
- GTK+ dist/build fix. List newly added header files.
-
- * GNUmakefile.am:
-
-2008-08-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Change to throw a ReferenceError at runtime instead of a ParseError
- at parse time, when the left hand side expression of a for-in statement
- is not an lvalue.
-
- * kjs/grammar.y:
- * kjs/nodes.cpp:
- (KJS::ForInNode::emitCode):
-
-2008-08-28 Alexey Proskuryakov <ap@webkit.org>
-
- Not reviewed, build fix (at least for OpenBSD, posssibly more).
-
- https://bugs.webkit.org/show_bug.cgi?id=20545
- missing #include <unistd.h> in JavaScriptCore/VM/SamplingTool.cpp
-
- * VM/SamplingTool.cpp: add the missing include.
-
-2008-08-26 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff and Cameron.
-
- <rdar://problem/6174603> Hitting assertion in Register::codeBlock when
- loading facebook (20516).
-
- - This was a result of my line numbers change. After a host function is
- called the stack does not get reset correctly.
- - Oddly this also appears to be a slight speedup on SunSpider.
-
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
-
-2008-08-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff and Tim.
-
- Export new API methods.
-
- * JavaScriptCore.exp:
-
-2008-08-25 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff, Tim and Mark.
-
- <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
- in the console said what file and line number they came from
- - Lay the foundation for getting line numbers and other data from the
- JavaScript engine. With the cleanup in kjs/ExecState this is actually
- a slight performance improvement.
-
- * JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * VM/Machine.cpp: Now Host and JS functions set a call frame on the
- exec state, so this and the profiler code were pulled out of the
- branches.
- (KJS::Machine::privateExecute):
- (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID
- and sourceURL for the previously called function.
- * VM/Machine.h:
- * kjs/ExecState.cpp: Remove references to JSFunction since it's not used
- anywhere.
- * kjs/ExecState.h:
-
-2008-08-25 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
- contexts in the current context's group.
-
- This is only really necessary when the last reference is released, but there is no way to
- determine that, and no harm in collecting slightly more often.
-
- * API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not
- being destroyed.
-
-2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
- <https://bugs.webkit.org/show_bug.cgi?id=20093>
-
- Clear exceptions after evaluating any code in the JSC shell. We do not
- report exceptions that are caused by calling toString on the final
- valued, but at least we avoid incorrect behaviour.
-
- Also, print any exceptions that occurred while evaluating code at the
- interactive prompt, not just while evaluating code from a file.
-
- * kjs/Shell.cpp:
- (runWithScripts):
- (runInteractive):
-
-2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver.
-
- Remove an unnecessary RefPtr to a RegisterID.
-
- * kjs/nodes.cpp:
- (KJS::DeleteBracketNode::emitCode):
-
-2008-08-24 Mark Rowe <mrowe@apple.com>
+ Reviewed by Adam Treat.
- Reviewed by Oliver Hunt.
+ https://bugs.webkit.org/show_bug.cgi?id=23155
+ Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- Use the correct version number for when JSGlobalContextCreate was introduced.
-
- * API/JSContextRef.h:
-
-2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Mark Rowe.
-
- Remove modelines.
-
- * API/APICast.h:
- * API/JSBase.cpp:
- * API/JSCallbackConstructor.cpp:
- * API/JSCallbackConstructor.h:
- * API/JSCallbackFunction.cpp:
- * API/JSCallbackFunction.h:
- * API/JSCallbackObject.cpp:
- * API/JSCallbackObject.h:
- * API/JSCallbackObjectFunctions.h:
- * API/JSClassRef.cpp:
- * API/JSContextRef.cpp:
- * API/JSObjectRef.cpp:
- * API/JSProfilerPrivate.cpp:
- * API/JSStringRef.cpp:
- * API/JSStringRefBSTR.cpp:
- * API/JSStringRefCF.cpp:
- * API/JSValueRef.cpp:
- * API/tests/JSNode.c:
- * API/tests/JSNode.h:
- * API/tests/JSNodeList.c:
- * API/tests/JSNodeList.h:
- * API/tests/Node.c:
- * API/tests/Node.h:
- * API/tests/NodeList.c:
- * API/tests/NodeList.h:
- * API/tests/minidom.c:
- * API/tests/minidom.js:
- * API/tests/testapi.c:
- * API/tests/testapi.js:
- * JavaScriptCore.pro:
- * kjs/FunctionConstructor.h:
- * kjs/FunctionPrototype.h:
- * kjs/JSArray.h:
- * kjs/JSString.h:
- * kjs/JSWrapperObject.cpp:
- * kjs/NumberConstructor.h:
- * kjs/NumberObject.h:
- * kjs/NumberPrototype.h:
- * kjs/lexer.h:
- * kjs/lookup.h:
+ * config.h:
+ * jsc.cpp:
* wtf/Assertions.cpp:
* wtf/Assertions.h:
- * wtf/HashCountedSet.h:
- * wtf/HashFunctions.h:
- * wtf/HashIterators.h:
- * wtf/HashMap.h:
- * wtf/HashSet.h:
- * wtf/HashTable.h:
- * wtf/HashTraits.h:
- * wtf/ListHashSet.h:
- * wtf/ListRefPtr.h:
- * wtf/Noncopyable.h:
- * wtf/OwnArrayPtr.h:
- * wtf/OwnPtr.h:
- * wtf/PassRefPtr.h:
+ * wtf/CurrentTime.cpp:
+ (WTF::lowResUTCTime):
+ * wtf/DateMath.cpp:
+ (WTF::getLocalTime):
+ * wtf/MathExtras.h:
* wtf/Platform.h:
- * wtf/RefPtr.h:
- * wtf/RefPtrHashMap.h:
- * wtf/RetainPtr.h:
- * wtf/UnusedParam.h:
- * wtf/Vector.h:
- * wtf/VectorTraits.h:
- * wtf/unicode/Unicode.h:
- * wtf/unicode/icu/UnicodeIcu.h:
-
-2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver.
-
- Some cleanup to match our coding style.
-
- * VM/CodeGenerator.h:
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- * kjs/ExecState.cpp:
- * kjs/ExecState.h:
- * kjs/completion.h:
- * kjs/identifier.cpp:
- (KJS::Identifier::equal):
- (KJS::CStringTranslator::hash):
- (KJS::CStringTranslator::equal):
- (KJS::CStringTranslator::translate):
- (KJS::UCharBufferTranslator::equal):
- (KJS::UCharBufferTranslator::translate):
- (KJS::Identifier::remove):
- * kjs/operations.h:
-
-2008-08-20 Alexey Proskuryakov <ap@webkit.org>
-
- Windows build fix.
-
- * API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
-
-2008-08-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
-
- * kjs/JSGlobalData.cpp:
- (KJS::JSGlobalData::~JSGlobalData):
- (KJS::JSGlobalData::JSGlobalData): Re-add shared instance.
- (KJS::JSGlobalData::sharedInstanceExists): Ditto.
- (KJS::JSGlobalData::sharedInstance): Ditto.
- (KJS::JSGlobalData::sharedInstanceInternal): Ditto.
-
- * API/JSContextRef.h: Deprecated JSGlobalContextCreate(). Added a very conservative
- description of its threading model (nothing is allowed).
-
- * API/JSContextRef.cpp:
- (JSGlobalContextCreate): Use shared JSGlobalData.
- (JSGlobalContextCreateInGroup): Support passing NULL group to request a unique one.
- (JSGlobalContextRetain): Added back locking.
- (JSGlobalContextRelease): Ditto.
- (JSContextGetGlobalObject): Ditto.
-
- * API/tests/minidom.c: (main):
- * API/tests/testapi.c: (main):
- Switched to JSGlobalContextCreateInGroup() to avoid deprecation warnings.
-
- * JavaScriptCore.exp: Re-added JSLock methods. Added JSGlobalContextCreateInGroup (d'oh!).
-
- * API/JSBase.cpp:
- (JSEvaluateScript):
- (JSCheckScriptSyntax):
- (JSGarbageCollect):
- * API/JSCallbackConstructor.cpp:
- (KJS::constructJSCallback):
- * API/JSCallbackFunction.cpp:
- (KJS::JSCallbackFunction::call):
- * API/JSCallbackObjectFunctions.h:
- (KJS::::init):
- (KJS::::getOwnPropertySlot):
- (KJS::::put):
- (KJS::::deleteProperty):
- (KJS::::construct):
- (KJS::::hasInstance):
- (KJS::::call):
- (KJS::::getPropertyNames):
- (KJS::::toNumber):
- (KJS::::toString):
- (KJS::::staticValueGetter):
- (KJS::::callbackGetter):
- * API/JSObjectRef.cpp:
- (JSObjectMake):
- (JSObjectMakeFunctionWithCallback):
- (JSObjectMakeConstructor):
- (JSObjectMakeFunction):
- (JSObjectHasProperty):
- (JSObjectGetProperty):
- (JSObjectSetProperty):
- (JSObjectGetPropertyAtIndex):
- (JSObjectSetPropertyAtIndex):
- (JSObjectDeleteProperty):
- (JSObjectCallAsFunction):
- (JSObjectCallAsConstructor):
- (JSObjectCopyPropertyNames):
- (JSPropertyNameArrayRelease):
- (JSPropertyNameAccumulatorAddName):
- * API/JSValueRef.cpp:
- (JSValueIsEqual):
- (JSValueIsInstanceOfConstructor):
- (JSValueMakeNumber):
- (JSValueMakeString):
- (JSValueToNumber):
- (JSValueToStringCopy):
- (JSValueToObject):
- (JSValueProtect):
- (JSValueUnprotect):
- * ForwardingHeaders/JavaScriptCore/JSLock.h: Added.
- * GNUmakefile.am:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- * kjs/AllInOneFile.cpp:
- * kjs/JSGlobalData.h:
- * kjs/JSGlobalObject.cpp:
- (KJS::JSGlobalObject::~JSGlobalObject):
- (KJS::JSGlobalObject::init):
- * kjs/JSLock.cpp: Added.
- (KJS::createJSLockCount):
- (KJS::JSLock::lockCount):
- (KJS::setLockCount):
- (KJS::JSLock::JSLock):
- (KJS::JSLock::lock):
- (KJS::JSLock::unlock):
- (KJS::JSLock::currentThreadIsHoldingLock):
- (KJS::JSLock::DropAllLocks::DropAllLocks):
- (KJS::JSLock::DropAllLocks::~DropAllLocks):
- * kjs/JSLock.h: Added.
- (KJS::JSLock::JSLock):
- (KJS::JSLock::~JSLock):
- * kjs/Shell.cpp:
- (functionGC):
- (jscmain):
- * kjs/collector.cpp:
- (KJS::Heap::~Heap):
- (KJS::Heap::heapAllocate):
- (KJS::Heap::setGCProtectNeedsLocking):
- (KJS::Heap::protect):
- (KJS::Heap::unprotect):
- (KJS::Heap::collect):
- * kjs/identifier.cpp:
- * kjs/interpreter.cpp:
- (KJS::Interpreter::checkSyntax):
- (KJS::Interpreter::evaluate):
- Re-added implicit locking.
-
-2008-08-19 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim and Mark.
-
- Implement DTrace hooks for dashcode and instruments.
-
- * API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be
- turned on from a client. The DTrace probes were added within the
- profiler mechanism for performance reasons so the profiler must be
- started to enable tracing.
- (JSStartProfiling):
- (JSEndProfiling):
- * API/JSProfilerPrivate.h: Added. Ditto.
- * JavaScriptCore.exp: Exposing the start/stop methods to clients.
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * kjs/Tracing.d: Define the DTrace probes.
- * kjs/Tracing.h: Ditto.
- * profiler/ProfileGenerator.cpp: Implement the DTrace probes in the
- profiler.
- (KJS::ProfileGenerator::willExecute):
- (KJS::ProfileGenerator::didExecute):
-
-2008-08-19 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * kjs/operations.cpp:
- (KJS::equal):
-
-2008-08-18 Timothy Hatcher <timothy@apple.com>
-
- Fix an assertion when generating a heavy profile because the
- empty value and deleted value of CallIdentifier where equal.
-
- https://bugs.webkit.org/show_bug.cgi?id=20439
-
- Reviewed by Dan Bernstein.
-
- * profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier
- use empty strings for URL and function name.
-
-2008-08-12 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff.
-
- - eliminate JSValue::type()
-
- This will make it slightly easier to change the JSImmediate design without
- having to touch so many call sites.
-
- SunSpider says this change is a wash (looked like a slight speedup, but not
- statistically significant).
-
- * API/JSStringRef.cpp: Removed include of JSType.h.
- * API/JSValueRef.cpp: Removed include of JSType.h.
- (JSValueGetType): Replaced use of JSValue::type() with
- JSValue::is functions.
-
- * JavaScriptCore.exp: Updated.
-
- * VM/JSPropertyNameIterator.cpp: Removed type() implementation.
- (KJS::JSPropertyNameIterator::toPrimitive): Changed to take
- PreferredPrimitiveType argument instead of JSType.
- * VM/JSPropertyNameIterator.h: Ditto.
-
- * VM/Machine.cpp:
- (KJS::fastIsNumber): Updated for name change.
- (KJS::fastToInt32): Ditto.
- (KJS::fastToUInt32): Ditto.
- (KJS::jsAddSlowCase): Updated toPrimitive caller for change from
- JSType to PreferredPrimitiveType.
- (KJS::jsAdd): Replaced calls to JSValue::type() with calls to
- JSValue::isString().
- (KJS::jsTypeStringForValue): Replaced calls to JSValue::type()
- with multiple calls to JSValue::is -- we could make this a
- virtual function instead if we want to have faster performance.
- (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32
- to JSImmediate::getTruncatedUInt32 for consistency with other functions.
- Changed two calls of JSValue::type() to JSValue::isString().
-
- * kjs/GetterSetter.cpp:
- (KJS::GetterSetter::toPrimitive): Changed to take
- PreferredPrimitiveType argument instead of JSType.
- (KJS::GetterSetter::isGetterSetter): Added.
- * kjs/GetterSetter.h:
-
- * kjs/JSCell.cpp:
- (KJS::JSCell::isString): Added.
- (KJS::JSCell::isGetterSetter): Added.
- (KJS::JSCell::isObject): Added.
-
- * kjs/JSCell.h: Eliminated type function. Added isGetterSetter.
- Made isString and isObject virtual. Changed toPrimitive to take
- PreferredPrimitiveType argument instead of JSType.
- (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance.
- (KJS::JSValue::isGetterSetter): Added.
- (KJS::JSValue::toPrimitive): Changed to take
- PreferredPrimitiveType argument instead of JSType.
-
- * kjs/JSImmediate.h: Removed JSValue::type() and replaced
- JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32.
- (KJS::JSImmediate::isEitherImmediate): Added.
-
- * kjs/JSNotAnObject.cpp:
- (KJS::JSNotAnObject::toPrimitive): Changed to take
- PreferredPrimitiveType argument instead of JSType.
- * kjs/JSNotAnObject.h: Ditto.
- * kjs/JSNumberCell.cpp:
- (KJS::JSNumberCell::toPrimitive): Ditto.
- * kjs/JSNumberCell.h:
- (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no
- other "slow" version of this once you have a JSNumberCell, so there's
- no need for "fast" in the name. It's a feature that this hides the
- base class toInt32, which does the same job less efficiently (and has
- an additional ExecState argument).
- (KJS::JSNumberCell::toUInt32): Ditto.
-
- * kjs/JSObject.cpp:
- (KJS::callDefaultValueFunction): Use isGetterSetter instead of type.
- (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType.
- (KJS::JSObject::defaultValue): Ditto.
- (KJS::JSObject::defineGetter): Use isGetterSetter.
- (KJS::JSObject::defineSetter): Ditto.
- (KJS::JSObject::lookupGetter): Ditto.
- (KJS::JSObject::lookupSetter): Ditto.
- (KJS::JSObject::toNumber): Use PreferredPrimitiveType.
- (KJS::JSObject::toString): Ditto.
- (KJS::JSObject::isObject): Added.
-
- * kjs/JSObject.h:
- (KJS::JSObject::inherits): Call the isObject from JSCell; it's now
- hidden by our override of isObject.
- (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter
- instead of type.
- (KJS::JSObject::getOwnPropertySlot): Ditto.
- (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
-
- * kjs/JSString.cpp:
- (KJS::JSString::toPrimitive): Use PreferredPrimitiveType.
- (KJS::JSString::isString): Added.
- * kjs/JSString.h: Ditto.
-
- * kjs/JSValue.h: Removed type(), added isGetterSetter(). Added
- PreferredPrimitiveType enum and used it as the argument for the
- toPrimitive function.
- (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
-
- * kjs/collector.cpp:
- (KJS::typeName): Changed to use JSCell::is functions instead of
- calling JSCell::type.
-
- * kjs/collector.h:
- (KJS::Heap::isNumber): Renamed from fastIsNumber.
-
- * kjs/nodes.h: Added now-needed include of JSType, since the type
- is used here to record types of values in the tree.
-
- * kjs/operations.cpp:
- (KJS::equal): Rewrote to no longer depend on type().
- (KJS::strictEqual): Ditto.
-
-2008-08-18 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- If there are no nodes in a profile all the time should be attributed to
- (idle)
-
- * profiler/Profile.cpp: If ther are no nodes make sure we still process
- the head.
- (KJS::Profile::forEach):
- * profiler/ProfileGenerator.cpp: Remove some useless code.
- (KJS::ProfileGenerator::stopProfiling):
-
-2008-08-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej.
-
- Make JSGlobalContextRetain/Release actually work.
-
- * API/JSContextRef.cpp:
- (JSGlobalContextRetain):
- (JSGlobalContextRelease):
- Ref/deref global data to give checking for globalData.refCount() some sense.
-
- * API/tests/testapi.c: (main): Added a test for this bug.
-
- * kjs/JSGlobalData.cpp:
- (KJS::JSGlobalData::~JSGlobalData):
- While checking for memory leaks, found that JSGlobalData::emptyList has changed to
- a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.
-
-2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej.
-
- Change the counting of constants so that preincrement and predecrement of
- const local variables are considered unexpected loads.
-
- * kjs/nodes.cpp:
- (KJS::PrefixResolveNode::emitCode):
- * kjs/nodes.h:
- (KJS::ScopeNode::neededConstants):
-
-2008-08-17 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- <rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
- <https://bugs.webkit.org/show_bug.cgi?id=20386>
-
- This crash was caused by "depth()" incorrectly determining the scope depth
- of a 0 depth function without a full scope chain. Because such a function
- would not have an activation the depth function would return the scope depth
- of the parent frame, thus triggering an incorrect unwind. Any subsequent
- look up that walked the scope chain would result in incorrect behaviour,
- leading to a crash or incorrect variable resolution. This can only actually
- happen in try...finally statements as that's the only path that can result in
- the need to unwind the scope chain, but not force the function to need a
- full scope chain.
-
- The fix is simply to check for this case before attempting to walk the scope chain.
-
- * VM/Machine.cpp:
- (KJS::depth):
- (KJS::Machine::throwException):
-
-2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej.
-
- Bug 20419: Remove op_jless
- <https://bugs.webkit.org/show_bug.cgi?id=20419>
-
- Remove op_jless, which is rarely used now that we have op_loop_if_less.
-
- * VM/CodeBlock.cpp:
- (KJS::CodeBlock::dump):
- * VM/CodeGenerator.cpp:
- (KJS::CodeGenerator::emitJumpIfTrue):
- * VM/Machine.cpp:
- (KJS::Machine::privateExecute):
- * VM/Opcode.h:
-
-2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Dan Bernstein.
-
- Fix a typo in r35807 that is also causing build failures for
- non-AllInOne builds.
-
- * kjs/NumberConstructor.cpp:
-
-2008-08-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Made room for a free word in JSCell.
-
- SunSpider says no change.
-
- I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
- store auxiliary data in a secondary structure.
-
- I changed InternalFunction to store the function's name in the property
- map.
-
- I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
- JSDOMWindowBaseData could inherit from it safely. (It's a strange design
- for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
- but that's really our only option, given the size constraint.)
-
- I also added a bunch of compile-time ASSERTs, and removed lots of comments
- in JSObject.h because they were often out of date, and they got in the
- way of reading what was actually going on.
-
- Also renamed JSArray::getLength to JSArray::length, to match our style
- guidelines.
-
-2008-08-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Sped up property access for array.length and string.length by adding a
- mechanism for returning a temporary value directly instead of returning
- a pointer to a function that retrieves the value.
-
- Also removed some unused cruft from PropertySlot.
-
- SunSpider says 0.5% - 1.2% faster.
-
- NOTE: This optimization is not a good idea in general, because it's
- actually a pessimization in the case of resolve for assignment,
- and it may get in the way of other optimizations in the future.
-
-2008-08-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Disable dead code stripping in debug builds.
-
- * Configurations/Base.xcconfig:
- * JavaScriptCore.xcodeproj/project.pbxproj:
+ * wtf/StringExtras.h:
+ * wtf/Threading.h:
+ * wtf/win/MainThreadWin.cpp:
-2008-08-15 Mark Rowe <mrowe@apple.com>
+2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
- <rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
-
- * wtf/FastMalloc.cpp:
- (WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
- a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
- (WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
- be used when calculating local addresses.
- (WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
-
-2008-08-15 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Geoff Garen.
-
- <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
-
- * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
- between the Debug configuration and debug Production variant.
- * JavaScriptCore.xcodeproj/project.pbxproj: Enable the debug variant.
-
-2008-08-15 Mark Rowe <mrowe@apple.com>
-
- Fix the 64-bit build.
+ <rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
- Add extra cast to avoid warnings about loss of precision when casting from
- JSValue* to an integer type.
+ Remove PropertySlot::putValue - PropertySlots should only be used for getting,
+ not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
+ which is what it really was being used to ask, and remove some other getOwnPropertySlot
+ & getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.
- * kjs/JSImmediate.h:
- (KJS::JSImmediate::intValue):
- (KJS::JSImmediate::uintValue):
-
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
-
- Still fixing Windows build.
-
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString
- to yet another place.
-
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
-
- Trying to fix non-Apple builds.
-
- * ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
-
-2008-08-15 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Geoff Garen.
-
- Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
- JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
- JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
- but instead holds an immediate value encoded within the pointer. This patch changes the
- encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
- a 31 bit value to be stored. All other immediates are tagged with the value 10, and
- distinguished by a secondary tag.
-
- Roughly +2% on SunSpider.
-
- * kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
- descption of new layout.
-
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
-
- More build fixes.
-
- * API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
- * API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
- * JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::hasOwnPropertyForWrite):
+ * runtime/JSObject.h:
+ * runtime/JSStaticScopeObject.cpp:
+ * runtime/JSStaticScopeObject.h:
+ * runtime/PropertySlot.h:
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+2009-06-16 Gavin Barraclough <barraclough@apple.com>
- Build fix.
+ Reviewed by Oliver hunt.
- * JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
+ Temporarily partially disable r44492, since this is causing some problems on internal builds.
- * kjs/identifier.cpp:
- (KJS::Identifier::checkSameIdentifierTable):
- * kjs/identifier.h:
- (KJS::Identifier::add):
- Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be
- non-inline in release builds, too.
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_throw):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- * JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
+2009-06-16 Sam Weinig <sam@webkit.org>
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+ Fix windows build.
- Reviewed by Geoff Garen.
+ * jit/JIT.cpp:
+ (JSC::JIT::JIT):
- JSStringRef is created context-free, but can get linked to one via an identifier table,
- breaking an implicit API contract.
-
- Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
-
- * API/APICast.h: Removed toRef/toJS conversions for JSStringRef, as this is no longer a
- simple typecast.
-
- * kjs/identifier.cpp:
- (KJS::Identifier::checkSameIdentifierTable):
- * kjs/identifier.h:
- (KJS::Identifier::add):
- (KJS::UString::checkSameIdentifierTable):
- Added assertions to verify that an identifier is not being added to a different JSGlobalData.
-
- * API/JSObjectRef.cpp:
- (OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray): Changed OpaqueJSPropertyNameArray to
- hold JSStringRefs. This is necessary to avoid having to construct (and leak) a new instance
- in JSPropertyNameArrayGetNameAtIndex(), now that making a JSStringRef is not just a typecast.
-
- * API/OpaqueJSString.cpp: Added.
- (OpaqueJSString::create):
- (OpaqueJSString::ustring):
- (OpaqueJSString::identifier):
- * API/OpaqueJSString.h: Added.
- (OpaqueJSString::create):
- (OpaqueJSString::characters):
- (OpaqueJSString::length):
- (OpaqueJSString::OpaqueJSString):
- (OpaqueJSString::~OpaqueJSString):
-
- * API/JSBase.cpp:
- (JSEvaluateScript):
- (JSCheckScriptSyntax):
- * API/JSCallbackObjectFunctions.h:
- (KJS::::getOwnPropertySlot):
- (KJS::::put):
- (KJS::::deleteProperty):
- (KJS::::staticValueGetter):
- (KJS::::callbackGetter):
- * API/JSStringRef.cpp:
- (JSStringCreateWithCharacters):
- (JSStringCreateWithUTF8CString):
- (JSStringRetain):
- (JSStringRelease):
- (JSStringGetLength):
- (JSStringGetCharactersPtr):
- (JSStringGetMaximumUTF8CStringSize):
- (JSStringGetUTF8CString):
- (JSStringIsEqual):
- * API/JSStringRefCF.cpp:
- (JSStringCreateWithCFString):
- (JSStringCopyCFString):
- * API/JSValueRef.cpp:
- (JSValueMakeString):
- (JSValueToStringCopy):
- Updated to use OpaqueJSString.
-
- * GNUmakefile.am:
- * JavaScriptCore.exp:
- * JavaScriptCore.pri:
- * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- * JavaScriptCoreSources.bkl:
- Added OpaqueJSString.
-
-2008-08-14 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- <rdar://problem/6115819> Notify of profile in console
- - Profiles now have a unique ID so that they can be linked to the
- console message that announces that a profile completed.
-
- * profiler/HeavyProfile.cpp:
- (KJS::HeavyProfile::HeavyProfile):
- * profiler/Profile.cpp:
- (KJS::Profile::create):
- (KJS::Profile::Profile):
- * profiler/Profile.h:
- (KJS::Profile::uid):
- * profiler/ProfileGenerator.cpp:
- (KJS::ProfileGenerator::create):
- (KJS::ProfileGenerator::ProfileGenerator):
- * profiler/ProfileGenerator.h:
- * profiler/Profiler.cpp:
- (KJS::Profiler::startProfiling):
- * profiler/TreeProfile.cpp:
- (KJS::TreeProfile::create):
- (KJS::TreeProfile::TreeProfile):
- * profiler/TreeProfile.h:
-
-2008-08-13 Geoffrey Garen <ggaren@apple.com>
+2009-06-16 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
-
- Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
- fillGetterProperty, which references a global function pointer,
- out-of-line.
-
- .2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
- custom property access benchmark for objects with one property.
-
- * kjs/JSObject.cpp:
- (KJS::JSObject::fillGetterPropertySlot):
-
-2008-08-13 Alp Toker <alp@nuanti.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20349
- WTF::initializeThreading() fails if threading is already initialized
- Fix threading initialization logic to support cases where
- g_thread_init() has already been called elsewhere.
+ Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
+ it for each type of stub using the return address to find the correct
+ offset.
- Resolves database-related crashers reported in several applications.
-
- * wtf/ThreadingGtk.cpp:
- (WTF::initializeThreading):
-
-2008-08-13 Brad Hughes <bhughes@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
-
- The latest upgrade of the intel compiler allows us to compile all of
- Qt with optimizations enabled (yay!).
-
- * JavaScriptCore.pro:
-
-2008-08-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Geoff Garen.
-
- Add peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )
-
- This is a very slight win in sunspider, and a fairly substantial win
- in hot code that does if(!...), etc.
-
- * VM/CodeGenerator.cpp:
- (KJS::CodeGenerator::retrieveLastUnaryOp):
- (KJS::CodeGenerator::rewindBinaryOp):
- (KJS::CodeGenerator::rewindUnaryOp):
- (KJS::CodeGenerator::emitJumpIfFalse):
- * VM/CodeGenerator.h:
-
-2008-08-12 Dan Bernstein <mitz@apple.com>
-
- - JavaScriptCore part of <rdar://problem/6121636>
- Make fast*alloc() abort() on failure and add "try" variants that
- return NULL on failure.
-
- Reviewed by Darin Adler.
-
- * JavaScriptCore.exp: Exported tryFastCalloc().
- * VM/RegisterFile.h:
- (KJS::RegisterFile::RegisterFile): Removed an ASSERT().
- * kjs/JSArray.cpp:
- (KJS::JSArray::putSlowCase): Changed to use tryFastRealloc().
- (KJS::JSArray::increaseVectorLength): Ditto.
- * kjs/ustring.cpp:
- (KJS::allocChars): Changed to use tryFastMalloc().
- (KJS::reallocChars): Changed to use tryFastRealloc().
- * wtf/FastMalloc.cpp:
- (WTF::fastZeroedMalloc): Removed null checking of fastMalloc()'s result
- and removed extra call to InvokeNewHook().
- (WTF::tryFastZeroedMalloc): Added. Uses tryFastMalloc().
- (WTF::tryFastMalloc): Renamed fastMalloc() to this.
- (WTF::fastMalloc): Added. This version abort()s if allocation fails.
- (WTF::tryFastCalloc): Renamed fastCalloc() to this.
- (WTF::fastCalloc): Added. This version abort()s if allocation fails.
- (WTF::tryFastRealloc): Renamed fastRealloc() to this.
- (WTF::fastRealloc): Added. This version abort()s if allocation fails.
- (WTF::do_malloc): Made this a function template. When the abortOnFailure
- template parameter is set, the function abort()s on failure to allocate.
- Otherwise, it sets errno to ENOMEM and returns zero.
- (WTF::TCMallocStats::fastMalloc): Defined to abort() on failure.
- (WTF::TCMallocStats::tryFastMalloc): Added. Does not abort() on
- failure.
- (WTF::TCMallocStats::fastCalloc): Defined to abort() on failure.
- (WTF::TCMallocStats::tryFastCalloc): Added. Does not abort() on
- failure.
- (WTF::TCMallocStats::fastRealloc): Defined to abort() on failure.
- (WTF::TCMallocStats::tryFastRealloc): Added. Does not abort() on
- failure.
- * wtf/FastMalloc.h: Declared the "try" variants.
-
-2008-08-11 Adam Roben <aroben@apple.com>
-
- Move WTF::notFound into its own header so that it can be used
- independently of Vector
-
- Rubberstamped by Darin Adler.
-
- * JavaScriptCore.vcproj/WTF/WTF.vcproj:
- * JavaScriptCore.xcodeproj/project.pbxproj:
- Added NotFound.h to the project.
- * wtf/NotFound.h: Added. Moved the notFound constant here...
- * wtf/Vector.h: ...from here.
-
-2008-08-11 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit
-
- * API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
-
- * kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while
- sweeping the heap.
+ * jit/JIT.cpp:
+ (JSC::JIT::JIT):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdSelfList):
+ (JSC::JIT::compileGetByIdProtoList):
+ (JSC::JIT::compileGetByIdChainList):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdTransition):
+ (JSC::JIT::compileCTIMachineTrampolines):
+ (JSC::JIT::compilePatchGetArrayLength):
+ * jit/JITStubCall.h:
+ (JSC::JITStubCall::call):
-== Rolled over to ChangeLog-2008-08-10 ==
+== Rolled over to ChangeLog-2009-06-16 ==
diff --git a/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2007-10-14 b/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2007-10-14
index a91f1ff..693f966 100644
--- a/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2007-10-14
+++ b/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2007-10-14
@@ -756,7 +756,7 @@
* wtf/Platform.h: Also test if __arm__ is defined.
-2007-08-25 Peter Kasting <zerodpx@gmail.org>
+2007-08-25 Peter Kasting <pkasting@google.com>
Reviewed by Maciej Stachowiak.
@@ -766,7 +766,7 @@
* wtf/Vector.h:
(WTF::Vector::operator[]): Only provide versions of operator[] that takes a size_t argument.
-2007-08-25 Peter Kasting <zerodpx@gmail.org>
+2007-08-25 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
@@ -786,7 +786,7 @@
* kjs/object.cpp:
-2007-08-15 Peter Kasting <zerodpx@gmail.org>
+2007-08-15 Peter Kasting <pkasting@google.com>
Reviewed by Darin.
@@ -4435,7 +4435,7 @@
Interestingly, even the single-threaded testkjs shows a speed gain
from removing the pthread_is_threaded_np() short-circuit. Not sure why.
-2007-03-04 Don Gibson <dgibson77@gmail.com>
+2007-03-04 Peter Kasting <pkasting@google.com>
Reviewed by Nikolas Zimmermann.
diff --git a/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2009-06-16 b/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2009-06-16
new file mode 100644
index 0000000..52d3c36
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/ChangeLog-2009-06-16
@@ -0,0 +1,39978 @@
+2009-06-15 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber Stamped by Sam Weinig.
+
+ Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
+ mixed up, but we have decided to fix on refering to the process that takes place
+ at the end of code generation as 'linking', and on any modifications that take
+ place later (and once the code has potentially already been executed) as 'patching'.
+
+ However, the term 'PatchBuffer' is already in use, and needs to be repurposed.
+
+ To try to minimize confusion, we're going to switch the terminology over in stages,
+ so for now we'll refer to later modifications as 'repatching'. This means that the
+ new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.
+
+ This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
+ state for a week or so to try to avoid to much overlap of the meaning of the term
+ 'PatchBuffer', then will come back and rename 'RepatchBuffer'.
+
+ * assembler/ARMv7Assembler.h:
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer):
+ (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::compile):
+
+2009-06-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Having moved most of their functionality into the RepatchBuffer class,
+ we can simplify the CodeLocation* classes.
+
+ The CodeLocation* classes are currently a tangle of templatey and friendly
+ badness, burried in the middle of AbstractMacroAssembler. Having moved
+ the ability to repatch out into RepatchBufer they are now do-nothing wrappers
+ on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.
+
+ Simplify the code, and move them off into their own header.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::PatchBuffer::patch):
+ * assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h.
+ (JSC::CodeLocationCommon::CodeLocationCommon):
+ (JSC::CodeLocationInstruction::CodeLocationInstruction):
+ (JSC::CodeLocationLabel::CodeLocationLabel):
+ (JSC::CodeLocationJump::CodeLocationJump):
+ (JSC::CodeLocationCall::CodeLocationCall):
+ (JSC::CodeLocationNearCall::CodeLocationNearCall):
+ (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32):
+ (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
+ (JSC::CodeLocationCommon::instructionAtOffset):
+ (JSC::CodeLocationCommon::labelAtOffset):
+ (JSC::CodeLocationCommon::jumpAtOffset):
+ (JSC::CodeLocationCommon::callAtOffset):
+ (JSC::CodeLocationCommon::nearCallAtOffset):
+ (JSC::CodeLocationCommon::dataLabelPtrAtOffset):
+ (JSC::CodeLocationCommon::dataLabel32AtOffset):
+ * assembler/MacroAssemblerCodeRef.h:
+ (JSC::MacroAssemblerCodePtr::operator!):
+ * bytecode/CodeBlock.h:
+ (JSC::getStructureStubInfoReturnLocation):
+ (JSC::getCallLinkInfoReturnLocation):
+ (JSC::getMethodCallLinkInfoReturnLocation):
+ * bytecode/Instruction.h:
+ * bytecode/JumpTable.h:
+ (JSC::StringJumpTable::ctiForValue):
+ (JSC::SimpleJumpTable::ctiForValue):
+ * bytecode/StructureStubInfo.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitCatch):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
+
+2009-06-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
+ wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
+ it made sense to roll out the use of ReturnAddressPtr a little further into
+ JITStubs (which had always been the intention).
+
+ No performance impact.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
+ * assembler/MacroAssemblerCodeRef.h:
+ (JSC::ReturnAddressPtr::ReturnAddressPtr):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::getStubInfo):
+ (JSC::CodeBlock::getCallLinkInfo):
+ (JSC::CodeBlock::getMethodCallLinkInfo):
+ (JSC::CodeBlock::getBytecodeIndex):
+ * interpreter/Interpreter.cpp:
+ (JSC::bytecodeOffsetForPC):
+ * jit/JIT.cpp:
+ (JSC::ctiPatchNearCallByReturnAddress):
+ (JSC::ctiPatchCallByReturnAddress):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdTransition):
+ (JSC::JIT::compilePatchGetArrayLength):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * jit/JITStubs.cpp:
+ (JSC::JITThunks::tryCachePutByID):
+ (JSC::JITThunks::tryCacheGetByID):
+ (JSC::StackHack::StackHack):
+ (JSC::returnToThrowTrampoline):
+ (JSC::throwStackOverflowError):
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ * jit/JITStubs.h:
+ (JSC::):
+ (JSC::JITStackFrame::returnAddressSlot):
+ * runtime/JSGlobalData.h:
+
+2009-06-15 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6974857>
+
+ Define ENABLE_3D_RENDERING when building on 10.6, and move ENABLE_3D_RENDERING
+ switch from config.h to wtf/Platform.h.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * wtf/Platform.h:
+
+2009-06-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Move repatching methods into a set of methods on a class. This will allow us to
+ coallesce memory reprotection calls. Really, we want this class to be called
+ PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
+ to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
+ want the CodeLocationFoo types anymore (they are now only really there to provide
+ type safety, and that is completely undermined by the way we use offsets). Then
+ the link & patch buffers should delegate the actual patching calls to the
+ architecture-specific layer of the MacroAssembler. Landing all these changes as a
+ sequence of patches.
+
+ No performance impact.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relink):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::repatch):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
+ * jit/JIT.cpp:
+ (JSC::ctiPatchNearCallByReturnAddress):
+ (JSC::ctiPatchCallByReturnAddress):
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchMethodCallProto):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2009-06-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Hunt & Oliver Garen.
+
+ We are currently generating two copies of the slow path for op_call for no reason. Stop that.
+
+ Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
+ for use when linking. However this is now looked up using the return address (as we do for
+ property accesses) so the two paths are now identical.
+
+ No performance impact, reduces memory footprint.
+
+ * bytecode/CodeBlock.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::linkCall):
+ * jit/JIT.h:
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+
+2009-06-12 Dave Hyatt <hyatt@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26373
+
+ Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
+ Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
+ on Snow Leopard at first.
+
+ * wtf/Threading.h:
+ (WTF::ReadWriteLock::impl):
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::ReadWriteLock::ReadWriteLock):
+ (WTF::ReadWriteLock::~ReadWriteLock):
+ (WTF::ReadWriteLock::readLock):
+ (WTF::ReadWriteLock::tryReadLock):
+ (WTF::ReadWriteLock::writeLock):
+ (WTF::ReadWriteLock::tryWriteLock):
+ (WTF::ReadWriteLock::unlock):
+
+2009-06-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Make LiteralParser non-recursive
+
+ Convert LiteralParser from using a simple recursive descent parser
+ to a hand rolled PDA. Relatively simple conversion, but required
+ modifications to MarkedArgumentBuffer to make it more suitable as
+ a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
+ in future as there are many other cases where it will be useful to
+ have such a class.
+
+ * runtime/ArgList.h:
+ (JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
+ (JSC::MarkedArgumentBuffer::append):
+ (JSC::MarkedArgumentBuffer::removeLast):
+ (JSC::MarkedArgumentBuffer::last):
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::parse):
+ * runtime/LiteralParser.h:
+ (JSC::LiteralParser::LiteralParser):
+ (JSC::LiteralParser::tryLiteralParse):
+ (JSC::LiteralParser::):
+
+2009-06-12 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (build fix for windows).
+
+ Adjust the exports for JSC on Windows like what was done for OSX in
+ the previous commit.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-06-12 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ UString shouldn't create sharedBuffer for SmallStrings.
+ https://bugs.webkit.org/show_bug.cgi?id=26360
+
+ The methods changed are not used by JSC, so there is no JS perf impact. However,
+ there is a potential DOM perf impact, so I re-ran several of the tests that
+ I ran previously and ensured that the perf stay the same which caused me to
+ adjust the minLengthToShare.
+
+ * JavaScriptCore.exp:
+ * runtime/UString.cpp:
+ (JSC::UString::Rep::sharedBuffer):
+ Determines if the buffer being shared is big enough before doing so.
+ Previously, BaseString::sharedBuffer was called but it would only know
+ the length of the base string (BaseString::len) which may not be the same
+ as the string being shared (Rep::len).
+ (JSC::UString::BaseString::sharedBuffer):
+ This is now only be used by Rep::sharedBuffer. which does the length check.
+ * runtime/UString.h:
+
+2009-06-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26191
+ Remove xmath include in MathExtras.h, because it is not needed and also
+ breaks VS2008 builds with TR1 turned on.
+
+ * wtf/MathExtras.h: Removed xmath include.
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
+
+2009-06-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Adding JSONObject.cpp to the build.
+
+ * JavaScriptCoreSources.bkl:
+
+2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Jan Michael Alonzo.
+
+ [Qt] Fix build break
+ https://bugs.webkit.org/show_bug.cgi?id=26340
+
+ * JavaScriptCore.pri: Add JSONObject.cpp to LUT files.
+
+2009-06-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (build fix).
+
+ Lower stringify recursion limit to deal with small windows stack.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * runtime/JSONObject.cpp:
+ (JSC::Stringifier::):
+
+2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Fix compilation warnings
+ <https://bugs.webkit.org/show_bug.cgi?id=26015>
+
+ * wtf/ThreadingNone.cpp:
+ (WTF::ThreadCondition::wait): Fix compilation warning.
+ (WTF::ThreadCondition::timedWait): Ditto.
+
+2009-06-10 Brent Fulgham <bfulgham@webkit.org>
+
+ Build fix for Windows target.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ Correct missing </File> tag after @r44550 that prevents the
+ project from being loaded in the Visual Studio IDE.
+
+2009-06-09 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber Stamped by Mark Rowe.
+
+ Tidy up a couple of comments.
+
+ * assembler/ARMv7Assembler.h:
+ Fix date in copyright, neaten up a couple of comments.
+ * assembler/MacroAssemblerARMv7.h:
+ Fix date in copyright.
+
+2009-06-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 26249: Support JSON.stringify
+ <https://bugs.webkit.org/show_bug.cgi?id=26249>
+
+ Implement JSON.stringify. This patch handles all the semantics of the ES5
+ JSON.stringify function, including replacer functions and arrays and both
+ string and numeric gap arguments.
+
+ Currently uses a clamped recursive algorithm basically identical to the spec
+ description but with a few minor tweaks for performance and corrected semantics
+ discussed in the es-discuss mailing list.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::jsonTable):
+ * runtime/CommonIdentifiers.h:
+ add toJSON to the list of common identifiers
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::~JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ Add support for the JSON object lookup table
+
+ * runtime/JSONObject.cpp: Added.
+ (JSC::):
+ (JSC::JSONObject::getOwnPropertySlot):
+ (JSC::Stringifier::):
+ (JSC::Stringifier::Stringifier):
+ (JSC::Stringifier::stringify):
+ (JSC::Stringifier::appendString):
+
+ (JSC::Stringifier::StringKeyGenerator::StringKeyGenerator):
+ (JSC::Stringifier::StringKeyGenerator::getKey):
+ (JSC::Stringifier::IntKeyGenerator::IntKeyGenerator):
+ (JSC::Stringifier::IntKeyGenerator::getKey):
+ These KeyGenerator classes are used to abstract away the lazy evaluation of keys for
+ toJSON and replacer functions.
+
+ (JSC::Stringifier::toJSONValue):
+ (JSC::Stringifier::stringifyArray):
+ (JSC::Stringifier::stringifyObject):
+ (JSC::JSONProtoFuncStringify):
+ * runtime/JSONObject.h: Added.
+ (JSC::JSONObject:::JSObject):
+ (JSC::JSONObject::classInfo):
+ (JSC::JSONObject::createStructure):
+
+2009-06-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS on ARMv7 platforms.
+
+ These optimizations function correctly with no further changes.
+
+ * wtf/Platform.h:
+ Change to enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS.
+
+2009-06-09 Gavin Barraclough <barraclough@apple.com>
+
+ Not Reviewed, build fix.
+
+ * assembler/MacroAssemblerARMv7.h:
+
+2009-06-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Enable JIT_OPTIMIZE_ARITHMETIC on ARMv7 platforms.
+
+ Temporarily split support for 'branchTruncateDoubleToInt32' onto its own switch
+ ('supportsFloatingPointTruncate'). See comment in MacroAssemblerARMv7, we need
+ to work out wherther we are going to be able to support the current interface on
+ all platforms, or whether this should be refactored.
+
+ * assembler/MacroAssemblerARMv7.h:
+ (JSC::MacroAssemblerARMv7::supportsFloatingPoint):
+ Add implementation of supportsFloatingPointTruncate (returns true).
+ (JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
+ Add implementation of supportsFloatingPointTruncate (returns false).
+ (JSC::MacroAssemblerARMv7::loadDouble):
+ (JSC::MacroAssemblerARMv7::storeDouble):
+ (JSC::MacroAssemblerARMv7::addDouble):
+ (JSC::MacroAssemblerARMv7::subDouble):
+ (JSC::MacroAssemblerARMv7::mulDouble):
+ (JSC::MacroAssemblerARMv7::convertInt32ToDouble):
+ (JSC::MacroAssemblerARMv7::branchDouble):
+ Implement FP code genertion operations.
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
+ Add implementation of supportsFloatingPointTruncate (returns true).
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
+ Add implementation of supportsFloatingPointTruncate (returns true).
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_rshift):
+ Changed to call supportsFloatingPointTruncate().
+ (JSC::JIT::emitSlow_op_rshift):
+ Changed to call supportsFloatingPointTruncate().
+ * wtf/Platform.h:
+ Change to enable JIT_OPTIMIZE_ARITHMETIC.
+
+2009-06-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Mark Rowe & Geoff Garen.
+
+ Enable JIT_OPTIMIZE_PROPERTY_ACCESS on ARMv7 platforms.
+
+ Firm up interface for planting load intructions that will be repatched by
+ repatchLoadPtrToLEA(). This method should now no longer be applied to just
+ any loadPtr instruction.
+
+ * assembler/MacroAssemblerARMv7.h:
+ (JSC::MacroAssemblerARMv7::loadPtrWithPatchToLEA):
+ Implement loadPtrWithPatchToLEA interface (plants a load with a fixed width address).
+ (JSC::MacroAssemblerARMv7::move):
+ (JSC::MacroAssemblerARMv7::nearCall):
+ (JSC::MacroAssemblerARMv7::call):
+ (JSC::MacroAssemblerARMv7::moveWithPatch):
+ (JSC::MacroAssemblerARMv7::tailRecursiveCall):
+ Switch to use common method 'moveFixedWidthEncoding()' to perform fixed width (often patchable) loads.
+ (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
+ Move an immediate to a register, always plants movT3/movt instruction pair.
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::loadPtrWithPatchToLEA):
+ Implement loadPtrWithPatchToLEA interface (just a regular 32-bit load on x86).
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::loadPtrWithPatchToLEA):
+ Implement loadPtrWithPatchToLEA interface (just a regular 64-bit load on x86_64).
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::emit_op_put_by_id):
+ * wtf/Platform.h:
+ Change to enable JIT_OPTIMIZE_PROPERTY_ACCESS.
+
+2009-06-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Enable JS language JIT for ARM thumb2 platforms. Add ARMv7 specific
+ asm & constants, add appropriate configuration switches to Platform.h.
+
+ Landing this disabled until jump linking is completed (see YARR jit patch).
+
+ * assembler/MacroAssemblerARMv7.h:
+ (JSC::MacroAssemblerARMv7::load32):
+ Fix: should load pointer with ImmPtr not Imm32.
+ (JSC::MacroAssemblerARMv7::store32):
+ Fix: should load pointer with ImmPtr not Imm32.
+ (JSC::MacroAssemblerARMv7::move):
+ Fix: When moving an Imm32 that is actually a pointer, should call movT3()
+ not mov(), to ensure code generation is repeatable (for exception handling).
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ Disable JIT_OPTIMIZE_NATIVE_CALL specific code generation if the optimization is not enabled.
+ * jit/JIT.h:
+ Add ARMv7 specific values of constants & register names.
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::preverveReturnAddressAfterCall):
+ (JSC::JIT::restoreReturnAddressBeforeReturn):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ Implement for ARMv7 (move value to/from lr).
+ * jit/JITStubs.cpp:
+ Add JIT entry/thow trampolines, add macro to add thunk wrapper around stub routines.
+ * jit/JITStubs.h:
+ (JSC::JITStackFrame::returnAddressSlot):
+ Add ARMv7 stack frame object.
+ * wtf/Platform.h:
+ Add changes necessary to allow JIT to build on this platform, disabled.
+
+2009-06-08 Mark Rowe <mrowe@apple.com>
+
+ Speculative GTK build fix.
+
+ * wtf/DateMath.cpp:
+
+2009-06-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Previous patch caused a regression.
+
+ Restructure so no new (empty, inline) function calls are added on x86.
+
+ * jit/ExecutableAllocator.h:
+ (JSC::ExecutableAllocator::makeWritable):
+ (JSC::ExecutableAllocator::makeExecutable):
+ (JSC::ExecutableAllocator::reprotectRegion):
+ (JSC::ExecutableAllocator::cacheFlush):
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, GTK build fix (thanks, bdash).
+
+ * GNUmakefile.am: Moved DateMath with all other wtf kin.
+
+2009-06-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Add (incomplete) support to YARR for running with the jit enabled
+ on Arm thumb2 platforms. Adds new Assembler/MacroAssembler classes,
+ along with cache flushing support, tweaks to MacroAssemblerCodePtr
+ to support decorated thumb code pointers, and new enter/exit code
+ to YARR jit for the platform.
+
+ Support for this platform is still under development - the assembler
+ currrently only supports planting and linking jumps with a 16Mb range.
+ As such, initially commiting in a disabled state.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Add new assembler files.
+ * assembler/ARMv7Assembler.h: Added.
+ Add new Assembler.
+ * assembler/AbstractMacroAssembler.h:
+ Tweaks to ensure sizes of pointer values planted in JIT code do not change.
+ * assembler/MacroAssembler.h:
+ On ARMv7 platforms use MacroAssemblerARMv7.
+ * assembler/MacroAssemblerARMv7.h: Added.
+ Add new MacroAssembler.
+ * assembler/MacroAssemblerCodeRef.h:
+ (JSC::FunctionPtr::FunctionPtr):
+ Add better ASSERT.
+ (JSC::ReturnAddressPtr::ReturnAddressPtr):
+ Add better ASSERT.
+ (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
+ On ARMv7, MacroAssemblerCodePtr's mush be 'decorated' with a low bit set,
+ to indicate to the processor that the code is thumb code, not traditional
+ 32-bit ARM.
+ (JSC::MacroAssemblerCodePtr::dataLocation):
+ On ARMv7, decoration must be removed.
+ * jit/ExecutableAllocator.h:
+ (JSC::ExecutableAllocator::makeWritable):
+ Reformatted, no change.
+ (JSC::ExecutableAllocator::makeExecutable):
+ When marking code executable also cache flush it, where necessary.
+ (JSC::ExecutableAllocator::MakeWritable::MakeWritable):
+ Only use the null implementation of this class if both !ASSEMBLER_WX_EXCLUSIVE
+ and running on x86(_64) - on other platforms we may also need ensure that
+ makeExecutable is called at the end to flush caches.
+ (JSC::ExecutableAllocator::reprotectRegion):
+ Reformatted, no change.
+ (JSC::ExecutableAllocator::cacheFlush):
+ Cache flush a region of memory, or platforms where this is necessary.
+ * wtf/Platform.h:
+ Add changes necessary to allow YARR jit to build on this platform, disabled.
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::generateEnter):
+ (JSC::Yarr::RegexGenerator::generateReturn):
+ Add support to these methods for ARMv7.
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, fix my previous fix.
+
+ * runtime/DateInstance.cpp:
+ (JSC::DateInstance::msToGregorianDateTime): Use WTF namespace qualifier to
+ disambiguate func signatures.
+
+2009-06-08 Mark Rowe <mrowe@apple.com>
+
+ Attempt to fix the Tiger build.
+
+ * wtf/Platform.h: Only test the value of the macro once we know it is defined.
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, another Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, projectile-fixing Windows build.
+
+ * runtime/DateConversion.cpp: Added StringExtras include.
+ * wtf/DateMath.cpp: Replaced math with algorithm include (looking for std::min def for Windows).
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, Windows build fix.
+
+ * runtime/DateConstructor.cpp: Changed to use WTF namespace.
+ * runtime/DateConversion.cpp: Added UString include.
+ * runtime/DateInstance.cpp: Changed to use WTF namespace.
+ * wtf/DateMath.cpp: Added math include.
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26238
+ Move most of runtime/DateMath functions to wtf/DateMath, and split off conversion-related
+ helpers to DateConversion.
+
+ * AllInOneFile.cpp: Changed DateMath->DateConversion.
+ * GNUmakefile.am: Ditto and added DateMath.
+ * JavaScriptCore.exp: Ditto.
+ * JavaScriptCore.pri: Ditto.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added DateMath.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
+ * JavaScriptCoreSources.bkl: Ditto.
+ * pcre/pcre_exec.cpp: Changed to use DateMath.
+ * profiler/ProfileNode.cpp:
+ (JSC::getCount): Changed to use DateConversion.
+ * runtime/DateConstructor.cpp: Ditto.
+ * runtime/DateConversion.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp.
+ (JSC::parseDate): Refactored to use null-terminated characters as input.
+ * runtime/DateConversion.h: Copied from JavaScriptCore/runtime/DateMath.h.
+ * runtime/DateInstance.cpp: Changed to use wtf/DateMath.
+ * runtime/DateInstance.h: Ditto.
+ * runtime/DateMath.cpp: Removed.
+ * runtime/DateMath.h: Removed.
+ * runtime/DatePrototype.cpp: Ditto.
+ * runtime/InitializeThreading.cpp: Ditto.
+ * wtf/DateMath.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp.
+ * wtf/DateMath.h: Copied from JavaScriptCore/runtime/DateMath.h.
+
+2009-06-08 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
+
+2009-06-07 David Kilzer <ddkilzer@apple.com>
+
+ Make JavaScriptCore compile for iPhone and iPhone Simulator
+
+ Reviewed by Gavin Barraclough.
+
+ * Configurations/Base.xcconfig: Split GCC_ENABLE_OBJC_GC on
+ $(REAL_PLATFORM_NAME). Added $(ARCHS_UNIVERSAL_IPHONE_OS) to
+ VALID_ARCHS. Added REAL_PLATFORM_NAME_iphoneos,
+ REAL_PLATFORM_NAME_iphonesimulator, HAVE_DTRACE_iphoneos and
+ HAVE_DTRACE_iphonesimulator variables.
+ * Configurations/DebugRelase.xcconfig: Split ARCHS definition on
+ $(REAL_PLATFORM_NAME).
+ * Configurations/JavaScriptCore.xcconfig: Added
+ EXPORTED_SYMBOLS_FILE_armv6 and EXPORTED_SYMBOLS_FILE_armv7
+ variables. Split OTHER_LDFLAGS into OTHER_LDFLAGS_BASE and
+ OTHER_LDFLAGS_$(REAL_PLATFORM_NAME) since CoreServices.framework
+ is only linked to on Mac OS X.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Removed references
+ to CoreServices.framework since it's linked using OTHER_LDFLAGS
+ in JavaScriptCore.xcconfig.
+ * profiler/ProfilerServer.mm: Added #import for iPhone
+ Simulator.
+ (-[ProfilerServer init]): Conditionalize use of
+ NSDistributedNotificationCenter to non-iPhone or iPhone
+ Simulator.
+ * wtf/FastMalloc.cpp:
+ (WTF::TCMallocStats::): Build fix for iPhone and iPhone
+ Simulator.
+ * wtf/Platform.h: Defined PLATFORM(IPHONE) and
+ PLATFORM(IPHONE_SIMULATOR).
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::setThreadNameInternal): Build fix for iPhone and iPhone
+ Simulator.
+
+2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
+
+ * JavaScriptCore.pri:
+ * JavaScriptCore.pro:
+ * jsc.pro:
+
+2009-06-07 Gavin Barraclough <barraclough@apple.com>
+
+ RS by Sam Weinig.
+
+ Remove bonus bogus \n from last commit.
+
+ * jit/JITStubs.cpp:
+ (JSC::):
+
+2009-06-07 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Change the implementation of op_throw so the stub function always modifies its
+ return address - if it doesn't find a 'catch' it will switch to a trampoline
+ to force a return from JIT execution. This saves memory, by avoiding the need
+ for a unique return for every op_throw.
+
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_throw):
+ JITStubs::cti_op_throw now always changes its return address,
+ remove return code generated after the stub call (this is now
+ handled by ctiOpThrowNotCaught).
+ * jit/JITStubs.cpp:
+ (JSC::):
+ Add ctiOpThrowNotCaught definitions.
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ Change cti_op_throw to always change its return address.
+ * jit/JITStubs.h:
+ Add ctiOpThrowNotCaught declaration.
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Rudder stamped by Sam Weinig.
+
+ Add missing ASSERT.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::getRelocatedAddress):
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Switch storePtrWithPatch to take the initial immediate value as an argument.
+
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::storePtrWithPatch):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::storePtrWithPatch):
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_jsr):
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove patchLength..tByIdExternalLoadPrefix magic numbers from JIT.h.
+
+ These aren't really suitable values to be tracking within common code
+ of the JIT, since they are not (and realistically cannot) be checked
+ by ASSERTs, as the other repatch offsets are. Move this functionality
+ (skipping the REX prefix when patching load instructions to LEAs on
+ x86-64) into the X86Assembler.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadPtrToLEA):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::repatchLoadPtrToLEA):
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+
+2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
+
+ <https://bugs.webkit.org/show_bug.cgi?id=26160>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Use /bin/ln instead of ln for cases where this command is used with -h option.
+ As this option is not supported by GNU fileutils, this change helps users
+ who have GNU fileutils in their PATH.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove DoubleNotEqual floating point comparison condition for now -
+ it is not used, and it is unclear the semantics are correct (I think
+ this comparison would actually give you not-equal-or-unordered, which
+ might be what is wanted... we can revisit this interface & get it
+ right when required).
+
+ Also, fix asserts in branchArith32 ops. All adds & subs can check
+ for Signed, multiply only sets OF so can only check for overflow.
+
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::):
+ (JSC::MacroAssemblerX86Common::branchAdd32):
+ (JSC::MacroAssemblerX86Common::branchMul32):
+ (JSC::MacroAssemblerX86Common::branchSub32):
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Minor tidy up in JITStubs.
+
+ * jit/JITStubs.cpp:
+ (JSC::StackHack::StackHack):
+ * jit/JITStubs.h:
+
+2009-06-05 Koen Kooi <koen@dominion.thruhere.net>
+
+ Reviewed by Xan Lopez.
+
+ Build fix for glib unicode backend.
+
+ * wtf/unicode/glib/UnicodeMacrosFromICU.h:
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ 3 tiny cleanups:
+
+ * assembler/MacroAssemblerX86.h:
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::storePtrWithPatch):
+ store*() methods should take an ImplicitAddress, rather than an Address.
+ * assembler/X86Assembler.h:
+ Make patchPointer private.
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_ret):
+ Remove empty line at end of function.
+
+2009-06-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Encapsulate many uses of void* in the assembler & jit with types that provide
+ more semantic information. The new types are:
+
+ * MacroAssemblerCodePtr - this wraps a pointer into JIT generated code.
+ * FunctionPtr - this wraps a pointer to a C/C++ function in JSC.
+ * ReturnAddressPtr - this wraps a return address resulting from a 'call' instruction.
+
+ Wrapping these types allows for stronger type-checking than is possible with everything
+ represented a void*. For example, it is now enforced by the type system that near
+ calls can only be linked to JIT code and not to C functions in JSC (this was previously
+ required, but could not be enforced on the interface).
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::dataLocation):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::executableAddress):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA):
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::operator!):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::reset):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::addressForLookup):
+ (JSC::AbstractMacroAssembler::trampolineAt):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
+ (JSC::::CodeLocationCommon::instructionAtOffset):
+ (JSC::::CodeLocationCommon::labelAtOffset):
+ (JSC::::CodeLocationCommon::jumpAtOffset):
+ (JSC::::CodeLocationCommon::callAtOffset):
+ (JSC::::CodeLocationCommon::nearCallAtOffset):
+ (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
+ (JSC::::CodeLocationCommon::dataLabel32AtOffset):
+ * assembler/MacroAssemblerCodeRef.h:
+ (JSC::FunctionPtr::FunctionPtr):
+ (JSC::FunctionPtr::value):
+ (JSC::FunctionPtr::executableAddress):
+ (JSC::ReturnAddressPtr::ReturnAddressPtr):
+ (JSC::ReturnAddressPtr::value):
+ (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
+ (JSC::MacroAssemblerCodePtr::executableAddress):
+ (JSC::MacroAssemblerCodePtr::dataLocation):
+ (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::patchPointerForCall):
+ * jit/JIT.cpp:
+ (JSC::ctiPatchNearCallByReturnAddress):
+ (JSC::ctiPatchCallByReturnAddress):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::JIT::compileCTIMachineTrampolines):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ * jit/JITCode.h:
+ (JSC::JITCode::operator !):
+ (JSC::JITCode::addressForCall):
+ (JSC::JITCode::offsetOf):
+ (JSC::JITCode::execute):
+ (JSC::JITCode::size):
+ (JSC::JITCode::HostFunction):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitNakedCall):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * jit/JITStubs.cpp:
+ (JSC::JITThunks::JITThunks):
+ (JSC::JITThunks::tryCachePutByID):
+ (JSC::JITThunks::tryCacheGetByID):
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ * jit/JITStubs.h:
+ (JSC::JITThunks::ctiArrayLengthTrampoline):
+ (JSC::JITThunks::ctiStringLengthTrampoline):
+ (JSC::JITThunks::ctiVirtualCallPreLink):
+ (JSC::JITThunks::ctiVirtualCallLink):
+ (JSC::JITThunks::ctiVirtualCall):
+ (JSC::JITThunks::ctiNativeCallThunk):
+ * yarr/RegexJIT.h:
+ (JSC::Yarr::RegexCodeBlock::operator!):
+ (JSC::Yarr::RegexCodeBlock::execute):
+
+2009-06-05 Antti Koivisto <antti@apple.com>
+
+ Try to unbreak Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-06-03 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13128
+ Safari not obeying cache header
+
+ Export JSC::parseDate()
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2009-06-04 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug in property caching of getters and setters.
+
+ Make sure that the transition logic accounts for getters and setters.
+ If we don't we end up screwing up the transition tables so that some
+ transitions will start incorrectly believing that they need to check
+ for getters and setters.
+
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ * runtime/JSObject.h:
+ (JSC::):
+ * runtime/Structure.h:
+
+2009-06-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Minor tweak to PatchBuffer, change it so it no longer holds a CodeRef, and instead
+ holds a separate code pointer and executable pool. Since it now always holds its
+ own copy of the code size, and to simplify the construction sequence, it's neater
+ this way.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
+ (JSC::AbstractMacroAssembler::PatchBuffer::finalizeCode):
+ (JSC::AbstractMacroAssembler::PatchBuffer::code):
+ (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
+
+2009-06-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove 'JIT_STUB_ARGUMENT_STACK' this is unused and untested.
+
+ This just leaves JIT_STUB_ARGUMENT_REGISTER and JIT_STUB_ARGUMENT_VA_LIST.
+ Since JIT_STUB_ARGUMENT_REGISTER is the sensible configuration on most platforms,
+ remove this define and make this the default behaviour.
+ Platforms must now define JIT_STUB_ARGUMENT_VA_LIST to get crazy va_list voodoo,
+ if they so desire.
+
+ (Refactoring of #ifdefs only, no functional change, no performance impact.)
+
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ * jit/JITStubs.cpp:
+ (JSC::):
+ * jit/JITStubs.h:
+ * wtf/Platform.h:
+
+2009-06-04 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Sam Weinig.
+
+ * jit/JITArithmetic.cpp:
+ Remove some redundant typedefs, unused since arithmetic was added to the MacroAssembler interface.
+
+2009-06-04 Brent Fulgham <bfulgham@webkit.org>
+
+ Build fix due to header include problem.
+
+ * interpreter/Interpreter.h: Remove wtf from includes so that
+ compile can find the headers in expected places.
+
+2009-06-04 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ HashTable class (JavaScriptCore/wtf/HashTable.h) doesn't instantiated by 'new', so
+ inheritance was removed. HashTable struct has been instantiated by operator new in
+ JSGlobalData.cpp:106.
+ HashTable couldn't inherited from FastAllocBase since struct with inheritance is
+ no longer POD, so HashTable struct has been instantiated by fastNew, destroyed by
+ fastDelete.
+
+ * interpreter/Interpreter.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::~JSGlobalData):
+ * wtf/HashTable.h:
+
+2009-06-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Wrap the code that plants pushes/pops planted by JIT in explanatorily named
+ methods; move property storage reallocation into a standard stub function.
+
+ ~No performance impact (possible <1% progression on x86-64, likely just noise).
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ Wrap calls to push/pop.
+ * jit/JIT.h:
+ Declare the new wrapper methods.
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::preverveReturnAddressAfterCall):
+ (JSC::JIT::restoreReturnAddressBeforeReturn):
+ Define the new wrapper methods.
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_end):
+ (JSC::JIT::emit_op_ret):
+ Wrap calls to push/pop.
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ Move property storage reallocation into a standard stub function.
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ * jit/JITStubs.h:
+ (JSC::JITStubs::):
+
+2009-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ [Qt] Single-threaded QtWebKit configuration
+ <https://bugs.webkit.org/show_bug.cgi?id=26015>
+
+ * JavaScriptCore.pri: Use ThreadingNone.cpp instead of
+ ThreadingQt.cpp and make sure ENABLE_JSC_MULTIPLE_THREADS is turned off
+ when ENABLE_SINGLE_THREADED is tuned on
+ * wtf/ThreadingNone.cpp:
+ (WTF::ThreadCondition::wait): Fix compilation warning.
+ (WTF::ThreadCondition::timedWait): Ditto.
+
+2009-06-02 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
+
+ * Configurations/Base.xcconfig:
+
+2009-06-02 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Sam Weinig.
+
+ Use C-style comments in Platform.h so it can be included from C
+ files.
+
+ * wtf/Platform.h:
+
+2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
+
+ This fixes the Windows-build if the user does not have a /tmp directory.
+
+ * pcre/dftables:
+
+2009-06-02 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver ">>" Hunt.
+
+ emitSlow_op_rshift is linking the wrong number of slow cases, if !supportsFloatingPoint().
+ Fixerate, and refactor/comment the code a little to make it clearer what is going on.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_rshift):
+ (JSC::JIT::emitSlow_op_rshift):
+
+2009-06-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by NOBODY - speculative windows build fix (errm, for the other patch!).
+
+ * jit/JITStubs.cpp:
+ (JSC::):
+
+2009-06-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by NOBODY - speculative windows build fix.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::::CodeLocationCall::CodeLocationCall):
+ (JSC::::CodeLocationNearCall::CodeLocationNearCall):
+
+2009-06-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Olliej Hunt.
+
+ Change JITStub functions from being static members on the JITStub class to be
+ global extern "C" functions, and switch their the function signature declaration
+ in the definition of the functions to be C-macro generated. This makes it easier
+ to work with the stub functions from assembler code (since the names no longer
+ require mangling), and by delaring the functions with a macro we can look at
+ also auto-generating asm thunks to wrap the JITStub functions to perform the
+ work currently in 'restoreArgumentReference' (as a memory saving).
+
+ Making this change also forces us to be a bit more realistic about what is private
+ on the Register and CallFrame objects. Presently most everything on these classes
+ is private, and the classes have plenty of friends. We could befriend all the
+ global functions to perpetuate the delusion of encapsulation, but using friends is
+ a bit of a sledgehammer solution here - since friends can poke around with all of
+ the class's privates, and since all the major classes taht operate on Regsiters are
+ currently friends, right there is currently in practice very little protection at
+ all. Better to start removing friend delclarations, and exposing just the parts
+ that need to be exposed.
+
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::returnPC):
+ (JSC::ExecState::setCallerFrame):
+ (JSC::ExecState::returnValueRegister):
+ (JSC::ExecState::setArgumentCount):
+ (JSC::ExecState::setCallee):
+ (JSC::ExecState::setCodeBlock):
+ * interpreter/Interpreter.h:
+ * interpreter/Register.h:
+ (JSC::Register::Register):
+ (JSC::Register::i):
+ * jit/JITStubs.cpp:
+ (JSC::):
+ (JSC::JITThunks::JITThunks):
+ (JSC::JITThunks::tryCachePutByID):
+ (JSC::JITThunks::tryCacheGetByID):
+ (JSC::JITStubs::DEFINE_STUB_FUNCTION):
+ * jit/JITStubs.h:
+ (JSC::JITStubs::):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::nativeFunction):
+ (JSC::JSFunction::classInfo):
+ * runtime/JSGlobalData.h:
+
+2009-06-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Tidy up the literal parser.
+
+ Make the number lexing in the LiteralParser exactly match the JSON spec, which
+ makes us cover more cases, but also more strict. Also made string lexing only
+ allow double-quoted strings.
+
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::Lexer::lex):
+ (JSC::LiteralParser::Lexer::lexString):
+ (JSC::LiteralParser::Lexer::lexNumber):
+
+2009-06-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam "WX" Weinig.
+
+ Allow the JIT to operate without relying on use of RWX memory, on platforms where this is supported.
+
+ This patch adds a switch to Platform.h (ENABLE_ASSEMBLER_WX_EXCLUSIVE) which enables this mode of operation.
+ When this flag is set, all executable memory will be allocated RX, and switched to RW only whilst being
+ modified. Upon completion of code generation the protection is switched back to RX to allow execution.
+
+ Further optimization will be required before it is desirable to enable this mode of operation by default;
+ enabling this presently incurs a 5%-10% regression.
+
+ (Submitting disabled - no performance impact).
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::fromFunctionPointer):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToFunction):
+ (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
+ (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::patch):
+ (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
+ (JSC::::CodeLocationCommon::nearCallAtOffset):
+ (JSC::::CodeLocationCall::CodeLocationCall):
+ (JSC::::CodeLocationNearCall::CodeLocationNearCall):
+ * assembler/AssemblerBuffer.h:
+ (JSC::AssemblerBuffer::executableCopy):
+ * assembler/X86Assembler.h:
+ (JSC::CAN_SIGN_EXTEND_U32_64):
+ (JSC::X86Assembler::linkJump):
+ (JSC::X86Assembler::linkCall):
+ (JSC::X86Assembler::patchPointer):
+ (JSC::X86Assembler::relinkJump):
+ (JSC::X86Assembler::relinkCall):
+ (JSC::X86Assembler::repatchInt32):
+ (JSC::X86Assembler::repatchPointer):
+ (JSC::X86Assembler::repatchLoadToLEA):
+ (JSC::X86Assembler::patchInt32):
+ (JSC::X86Assembler::patchRel32):
+ * jit/ExecutableAllocator.h:
+ (JSC::ExecutableAllocator::):
+ (JSC::ExecutableAllocator::makeWritable):
+ (JSC::ExecutableAllocator::makeExecutable):
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ * jit/ExecutableAllocatorPosix.cpp:
+ (JSC::ExecutablePool::systemAlloc):
+ (JSC::ExecutablePool::systemRelease):
+ (JSC::ExecutableAllocator::reprotectRegion):
+ * jit/ExecutableAllocatorWin.cpp:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ * wtf/Platform.h:
+
+2009-05-29 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ Inherits Interpreter class from FastAllocBase because it has been
+ instantiated by 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
+
+ * interpreter/Interpreter.h:
+
+2009-06-01 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (windows build fix).
+
+ Add exports for windows (corresponding to the JavaScriptCore.exp modification
+ in the previous change).
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-06-01 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Alder and Maciej Stachowiak.
+
+ Bug 26057: StringImpl should share buffers with UString.
+ https://bugs.webkit.org/show_bug.cgi?id=26057
+
+ * JavaScriptCore.exp:
+ * runtime/UString.cpp:
+ (JSC::UString::Rep::create):
+ (JSC::UString::BaseString::sharedBuffer): Only do the sharing when
+ the buffer exceeds a certain size. The size was tuned by running
+ various dom benchmarks with numbers ranging from 20 to 800 and finding
+ a place that seemed to do the best overall.
+ * runtime/UString.h:
+
+2009-05-31 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Olliej "you just need to change NativeFunctionWrapper.h" Hunt.
+
+ Add ENABLE_JIT_OPTIMIZE_NATIVE_CALL switch to allow JIT to operate without native call optimizations.
+
+ * runtime/NativeFunctionWrapper.h:
+ * wtf/Platform.h:
+
+2009-05-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
+ "Maximum call stack size exceeded"
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks.
+ We need a limit of at least 100 to run the benchmark above.
+ (JSC::arrayProtoFuncToLocaleString): Ditto.
+ (JSC::arrayProtoFuncJoin): Ditto.
+
+2009-05-28 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Added new build flag --filters for Mac. More details in WebCore/ChangeLog.
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2009-05-27 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz
+
+ We should always check for exceptions after creating a CachedCall, this wasn't being done in
+ the string replace logic.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+
+2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed (make distcheck) build fix; adding missing headers.
+
+ * GNUmakefile.am:
+
+2009-05-27 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Adam Roben
+
+ Fix the Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Gustavo Noronha.
+
+ When building on Windows, consider Windows specific files.
+
+ * GNUmakefile.am:
+
+2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Maciej Stachowiak.
+
+ When building with MinGW, don't use the __declspec(dl{import,export})
+ decorations and rely on the linker to use its nifty auto-import feature.
+ It is extremely hard to get the decorations right with MinGW in general
+ and impossible in WebKit, where the resulting shared library is linking
+ together some static libraries.
+
+ * config.h:
+
+2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25613
+
+ Be able to use GOwnPtr for GHashTable as well. The assumption
+ is that the hash table has been created with g_hash_table_new_full
+ and has proper destruction functions.
+
+ * wtf/GOwnPtr.cpp:
+ (WTF::GHashTable):
+ * wtf/GOwnPtr.h:
+
+2009-05-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6924033> REGRESSION: Assertion failure due to forward references
+
+ Add a pattern type for forward references to ensure that we don't confuse the
+ quantifier alternatives assertion.
+
+ * yarr/RegexCompiler.cpp:
+ (JSC::Yarr::RegexPatternConstructor::atomBackReference):
+ (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
+ * yarr/RegexInterpreter.cpp:
+ (JSC::Yarr::ByteCompiler::emitDisjunction):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::generateTerm):
+ * yarr/RegexPattern.h:
+ (JSC::Yarr::PatternTerm::):
+ (JSC::Yarr::PatternTerm::PatternTerm):
+ (JSC::Yarr::PatternTerm::ForwardReference):
+
+2009-05-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
+ and also an ASSERT failure on http://ihasahotdog.com/.
+
+ When overwriting a property on a dictionary with a cached specific value,
+ clear the cache if new value being written is different.
+
+ * JavaScriptCore.exp:
+ Export the new symbols.
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_get_by_id_method_check_second):
+ Close dictionary prototypes upon caching a method access, as would happen when caching
+ a regular get_by_id.
+ * runtime/JSObject.h:
+ (JSC::JSObject::propertyStorage):
+ (JSC::JSObject::locationForOffset):
+ Make these methods private.
+ (JSC::JSObject::putDirectInternal):
+ When overwriting a property on a dictionary with a cached specific value,
+ clear the cache if new value being written is different.
+ * runtime/Structure.cpp:
+ (JSC::Structure::despecifyDictionaryFunction):
+ Reset the specific value field for a given property in a dictionary.
+ (JSC::Structure::despecifyFunctionTransition):
+ Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).
+ * runtime/Structure.h:
+ Declare new method.
+
+2009-05-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver "pieces of eight" Hunt.
+
+ When reseting RegexPattern class, should fully reset the class, not just bits of it.
+ In particular, we delete the cached character classes (for wordchars, etc), but do
+ not reset the set of pointers to the cached classes. In the case of a repeated parse
+ due to an illegal back-reference we will continue to use the deleted character class.
+
+ * yarr/RegexPattern.h:
+ (JSC::Yarr::RegexPattern::reset):
+
+2009-05-26 Brent Fulgham <bfulgham@webkit.org>
+
+ Build fix to correct r44161.
+
+ * wtf/FastAllocBase.h:
+
+2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
+
+ Reviewed by Maciej Stachowiak.
+
+ Inherite HashTable from FastAllocBase, because it has been instantiated by
+ 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
+
+ * wtf/HashTable.h:
+ * wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
+
+2009-05-25 David Levin <levin@chromium.org>
+
+ Reviewed by Maciej Stachowiak and Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25126
+ Allow the buffer underlying UString to be shared.
+
+ In order to not grow the underlying size of any structure,
+ there is a union in the Rep string which holds
+ + m_sharedBuffer -- a pointer to the shared ref counted buffer
+ if the class is BaseString and the buffer is being shared OR
+ + m_baseString -- the BaseString if the class is only UString::Rep
+ but not a UString::BaseString
+
+ Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
+ it is in a union.
+
+ No change in sunspider perf.
+
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * runtime/UString.cpp:
+ (JSC::UString::Rep::share):
+ (JSC::UString::Rep::destroy):
+ (JSC::UString::BaseString::sharedBuffer):
+ (JSC::UString::BaseString::setSharedBuffer):
+ (JSC::UString::BaseString::slowIsBufferReadOnly):
+ (JSC::expandCapacity):
+ (JSC::UString::Rep::reserveCapacity):
+ (JSC::UString::expandPreCapacity):
+ (JSC::concatenate):
+ (JSC::UString::append):
+ * runtime/UString.h:
+ (JSC::UString::Rep::Rep):
+ (JSC::UString::Rep::):
+ (JSC::UString::BaseString::isShared):
+ (JSC::UString::BaseString::isBufferReadOnly):
+ (JSC::UString::Rep::baseString):
+ * wtf/CrossThreadRefCounted.h:
+ (WTF::CrossThreadRefCounted::isShared):
+ * wtf/OwnFastMallocPtr.h: Added.
+ (WTF::OwnFastMallocPtr::OwnFastMallocPtr):
+ (WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
+ (WTF::OwnFastMallocPtr::get):
+ (WTF::OwnFastMallocPtr::release):
+
+2009-05-25 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it
+
+ * wtf/Platform.h:
+
+2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Maciej Stachowiak.
+
+ The functions written in assembly need to have a leading
+ underscore on Windows too.
+
+ * jit/JITStubs.cpp:
+
+2009-05-24 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix for experimental PGO Windows target.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25495>
+
+ Reviewed by Oliver Hunt.
+
+ * GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
+
+ * wtf/OwnPtr.h:
+ (WTF::OwnPtr::OwnPtr): Added constructors that take a
+ PassOwnPtr. Also added a copy constructor declaration that's
+ required when assigning a PassOwnPtr to a stack-based OwnPtr.
+ (WTF::operator=): Added assignment operator methods that take a
+ PassOwnPtr.
+ (WTF::swap): Reformatted.
+ (WTF::operator==): Whitespace changes.
+ (WTF::operator!=): Ditto.
+
+ * wtf/OwnPtrCommon.h: Added.
+ (WTF::deleteOwnedPtr):
+
+ * wtf/PassOwnPtr.h: Added.
+ (WTF::PassOwnPtr::PassOwnPtr):
+ (WTF::PassOwnPtr::~PassOwnPtr):
+ (WTF::PassOwnPtr::get):
+ (WTF::PassOwnPtr::clear):
+ (WTF::PassOwnPtr::release):
+ (WTF::PassOwnPtr::operator*):
+ (WTF::PassOwnPtr::operator->):
+ (WTF::PassOwnPtr::operator!):
+ (WTF::PassOwnPtr::operator UnspecifiedBoolType):
+ (WTF::::operator):
+ (WTF::operator==):
+ (WTF::operator!=):
+ (WTF::static_pointer_cast):
+ (WTF::const_pointer_cast):
+ (WTF::getPtr):
+
+2009-05-23 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove interpreter specific logic from the JIT builds.
+
+ This saves ~100k in JSC release builds.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * interpreter/Interpreter.h:
+ * wtf/Platform.h:
+
+2009-05-22 Mark Rowe <mrowe@apple.com>
+
+ Part two of an attempted Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-22 Mark Rowe <mrowe@apple.com>
+
+ Part one of an attempted Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ op_method_check
+
+ Optimize method calls, by caching specific function values within the Structure.
+ The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
+ where the property access is being used to read a function to be passed to op-call (i.e.
+ 'foo.bar();'). This patch modifies the Structure class such that when a property is
+ put to an object for the first time we will check if the value is a function. If it is,
+ we will cache the function value on the Structure. A Structure in such a state guarantees
+ that not only does a property with the given identifier exist on the object, but also that
+ its value is unchanged. Upon any further attempt to put a property with the same identifier
+ (but a different value) to the object, it will transition back to a normal Structure (where
+ it will guarantee the presence but not the value of the property).
+
+ op_method_check makes use of the new information made available by the Structure, by
+ augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
+ check will be emitted prior to the property access reading the function value, and the JIT
+ will generate an extra (initially unlinked but patchable) set of checks prior to the regular
+ JIT code for get_by_id. The new code will do inline structure and prototype structure check
+ (unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
+ an immediate load of the function value, rather than using memory accesses to load the value
+ from the obejct's property storage array. If the method check fails it will revert, or if
+ the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
+ just as any other regular op_get_by_id would.
+
+ ~2.5% on v8-tests, due to a ~9% progression on richards.
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::put):
+ (JSC::::staticFunctionGetter):
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeConstructor):
+ * JavaScriptCore.exp:
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::differenceBetween):
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::moveWithPatch):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/CodeBlock.h:
+ (JSC::getMethodCallLinkInfoReturnLocation):
+ (JSC::CodeBlock::getMethodCallLinkInfo):
+ (JSC::CodeBlock::addMethodCallLinkInfos):
+ (JSC::CodeBlock::methodCallLinkInfo):
+ * bytecode/Opcode.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitMethodCheck):
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
+ * jit/JITOpcodes.cpp:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::emit_op_method_check):
+ (JSC::JIT::emitSlow_op_method_check):
+ (JSC::JIT::emit_op_get_by_id):
+ (JSC::JIT::emitSlow_op_get_by_id):
+ (JSC::JIT::emit_op_put_by_id):
+ (JSC::JIT::emitSlow_op_put_by_id):
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::patchMethodCallProto):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_get_by_id_method_check):
+ (JSC::JITStubs::cti_op_get_by_id_method_check_second):
+ * jit/JITStubs.h:
+ * jsc.cpp:
+ (GlobalObject::GlobalObject):
+ * parser/Nodes.cpp:
+ (JSC::FunctionCallDotNode::emitBytecode):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::put):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::ArrayConstructor::ArrayConstructor):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::BooleanConstructor::BooleanConstructor):
+ * runtime/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::ErrorConstructor::ErrorConstructor):
+ (JSC::constructError):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::ErrorPrototype::ErrorPrototype):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::FunctionConstructor::FunctionConstructor):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::FunctionPrototype):
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::InternalFunction):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::put):
+ (JSC::JSActivation::putWithAttributes):
+ * runtime/JSByteArray.cpp:
+ (JSC::JSByteArray::JSByteArray):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::getOwnPropertySlot):
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::putWithAttributes):
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::mark):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
+ (JSC::JSGlobalObject::methodCallDummy):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::put):
+ (JSC::JSObject::putWithAttributes):
+ (JSC::JSObject::deleteProperty):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ (JSC::JSObject::getPropertyAttributes):
+ (JSC::JSObject::getPropertySpecificFunction):
+ (JSC::JSObject::putDirectFunction):
+ (JSC::JSObject::putDirectFunctionWithoutTransition):
+ * runtime/JSObject.h:
+ (JSC::getJSFunction):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::putDirectWithoutTransition):
+ * runtime/LiteralParser.cpp:
+ (JSC::LiteralParser::parseObject):
+ * runtime/Lookup.cpp:
+ (JSC::setUpStaticFunctionSlot):
+ * runtime/Lookup.h:
+ (JSC::lookupPut):
+ * runtime/MathObject.cpp:
+ (JSC::MathObject::MathObject):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ (JSC::NativeErrorConstructor::construct):
+ * runtime/NativeErrorPrototype.cpp:
+ (JSC::NativeErrorPrototype::NativeErrorPrototype):
+ * runtime/NumberConstructor.cpp:
+ (JSC::NumberConstructor::NumberConstructor):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::ObjectConstructor::ObjectConstructor):
+ * runtime/PropertyMapHashTable.h:
+ (JSC::PropertyMapEntry::PropertyMapEntry):
+ * runtime/PrototypeFunction.cpp:
+ (JSC::PrototypeFunction::PrototypeFunction):
+ * runtime/PutPropertySlot.h:
+ (JSC::PutPropertySlot::):
+ (JSC::PutPropertySlot::PutPropertySlot):
+ (JSC::PutPropertySlot::setNewProperty):
+ (JSC::PutPropertySlot::setDespecifyFunctionProperty):
+ (JSC::PutPropertySlot::isCacheable):
+ (JSC::PutPropertySlot::cachedOffset):
+ * runtime/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::RegExpConstructor):
+ * runtime/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+ * runtime/StringPrototype.cpp:
+ (JSC::StringPrototype::StringPrototype):
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure):
+ (JSC::Structure::~Structure):
+ (JSC::Structure::materializePropertyMap):
+ (JSC::Structure::addPropertyTransitionToExistingStructure):
+ (JSC::Structure::addPropertyTransition):
+ (JSC::Structure::changeFunctionTransition):
+ (JSC::Structure::addPropertyWithoutTransition):
+ (JSC::Structure::get):
+ (JSC::Structure::despecifyFunction):
+ (JSC::Structure::put):
+ (JSC::Structure::remove):
+ * runtime/Structure.h:
+ (JSC::Structure::get):
+ (JSC::Structure::specificFunction):
+ * runtime/StructureTransitionTable.h:
+ (JSC::StructureTransitionTableHashTraits::emptyValue):
+ * wtf/Platform.h:
+
+2009-05-22 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Steve Falkenburg.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25950
+ JavaScriptCore Fails to build on Windows (Cairo) due to CoreFoundation
+ link requirement.
+
+ Modify project to add new Debug_CFLite and Release_CFLite targets. These
+ use the new JavaScriptCoreCFLite.vsprops to link against CFLite.dll.
+ Existing projects are changed to use the new JavaScriptCoreCF.vsprops
+ to link against CoreFoundation.dll.
+
+ The JavaScriptCoreCommon.vsprops is modified to remove the link
+ against CoreFoundation.dll.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+
+2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15914
+ [GTK] Implement Unicode functionality using GLib
+
+ Original patch by Jürg Billeter and Naiem Shaik.
+ Implementing WTF Unicode functionality based on GLib.
+
+ * GNUmakefile.am:
+ * wtf/unicode/Unicode.h:
+ * wtf/unicode/glib: Added.
+ * wtf/unicode/glib/UnicodeGLib.cpp: Added.
+ (WTF::Unicode::foldCase):
+ (WTF::Unicode::toLower):
+ (WTF::Unicode::toUpper):
+ (WTF::Unicode::direction):
+ (WTF::Unicode::umemcasecmp):
+ * wtf/unicode/glib/UnicodeGLib.h: Added.
+ (WTF::Unicode::):
+ (WTF::Unicode::toLower):
+ (WTF::Unicode::toUpper):
+ (WTF::Unicode::toTitleCase):
+ (WTF::Unicode::isArabicChar):
+ (WTF::Unicode::isFormatChar):
+ (WTF::Unicode::isSeparatorSpace):
+ (WTF::Unicode::isPrintableChar):
+ (WTF::Unicode::isDigit):
+ (WTF::Unicode::isPunct):
+ (WTF::Unicode::mirroredChar):
+ (WTF::Unicode::category):
+ (WTF::Unicode::isLower):
+ (WTF::Unicode::digitValue):
+ (WTF::Unicode::combiningClass):
+ (WTF::Unicode::decompositionType):
+ * wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
+
+2009-05-21 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ Add MacroAssemblerCodeRef.h to file list.
+
+ * GNUmakefile.am:
+
+2009-05-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+ Addition of MacroAssemblerCodeRef.h rubber stamped by Geoff Garen.
+
+ Refactor JIT code-handle objects. The representation of generated code is currently
+ a bit of a mess. We have a class JITCode which wraps the pointer to a block of
+ generated code, but this object does not reference the executable pool meaning that
+ external events (the pool being derefed) could make the pointer become invalid.
+ To overcome this both the JIT and Yarr implement further (and similar) objects to
+ wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
+ CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
+ copy of the code pointer which is used almost (but not entirely) uniquely to access
+ the JIT code for a function.
+
+ Rationalization of all this:
+
+ * Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
+ * Change the JIT & Yarr to internally handle code using CodeRefs.
+ * Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
+ * Remove the (now) redundant code pointer from FunctionBodyNode.
+
+ While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
+ and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
+ 'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
+
+ This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
+ which may have a number of uses. It may be helpful should we wish to switch our generation
+ model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
+ give us an oportunity to cache flush as necessary.
+
+ No performance impact.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
+ (JSC::AbstractMacroAssembler::CodeRef::CodeRef):
+ (JSC::AbstractMacroAssembler::CodeRef::trampolineAt):
+ (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
+ (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
+ (JSC::AbstractMacroAssembler::PatchBuffer::patch):
+ (JSC::AbstractMacroAssembler::PatchBuffer::complete):
+ (JSC::AbstractMacroAssembler::PatchBuffer::finalize):
+ (JSC::AbstractMacroAssembler::PatchBuffer::entry):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
+ (JSC::CodeBlock::setJITCode):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::getBytecodeIndex):
+ (JSC::CodeBlock::executablePool):
+ * interpreter/CallFrameClosure.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::prepareForRepeatCall):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::linkCall):
+ * jit/JIT.h:
+ * jit/JITCode.h:
+ (JSC::JITCode::JITCode):
+ (JSC::JITCode::operator bool):
+ (JSC::JITCode::addressForCall):
+ (JSC::JITCode::offsetOf):
+ (JSC::JITCode::execute):
+ (JSC::JITCode::size):
+ (JSC::JITCode::executablePool):
+ (JSC::JITCode::HostFunction):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_vm_lazyLinkCall):
+ * parser/Nodes.cpp:
+ (JSC::ProgramNode::generateJITCode):
+ (JSC::EvalNode::generateJITCode):
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::createNativeThunk):
+ (JSC::FunctionBodyNode::generateJITCode):
+ * parser/Nodes.h:
+ (JSC::ScopeNode::generatedJITCode):
+ (JSC::ScopeNode::getExecutablePool):
+ (JSC::ScopeNode::setJITCode):
+ (JSC::ProgramNode::jitCode):
+ (JSC::EvalNode::jitCode):
+ (JSC::FunctionBodyNode::jitCode):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::match):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::compile):
+ (JSC::Yarr::jitCompileRegex):
+ (JSC::Yarr::executeRegex):
+ * yarr/RegexJIT.h:
+ (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
+ (JSC::Yarr::RegexCodeBlock::pcreFallback):
+ (JSC::Yarr::RegexCodeBlock::setFallback):
+ (JSC::Yarr::RegexCodeBlock::operator bool):
+ (JSC::Yarr::RegexCodeBlock::set):
+ (JSC::Yarr::RegexCodeBlock::execute):
+
+2009-05-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ <rdar://problem/6910264> REGRESSION: Cached DOM global object property access fails in browser (25921)
+ <https://bugs.webkit.org/show_bug.cgi?id=25921>
+
+ When caching properties on the global object we need to ensure that we're
+ not attempting to cache through a shell object.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::resolveGlobal):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_resolve_global):
+
+2009-05-21 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
+
+2009-05-21 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 25945: Add support for MADV_FREE to TCMalloc
+ <https://bugs.webkit.org/show_bug.cgi?id=25945>
+ <rdar://problem/6910754>
+
+ Add support for MADV_FREE to TCMalloc_SystemRelease for platforms that
+ don't also support MADV_FREE_REUSE. The code is identical to the MADV_DONTNEED
+ case except for the advice passed to madvise(), so combining the two cases
+ makes the most sense.
+
+ * wtf/Platform.h: Only define HAVE_MADV_FREE when not building on Tiger or
+ Leopard, because while it is defined on these platforms it actually does
+ nothing.
+ * wtf/TCSystemAlloc.cpp:
+ (TCMalloc_SystemRelease): use MADV_FREE if it is available; otherwise use
+ MADV_DONTNEED.
+
+2009-05-21 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
+ Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page
+
+ The debugger currently retrieves the arguments object from an activation rather than pulling
+ it from a call frame. This is unreliable to due to the recent optimization to lazily create
+ the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
+ but for now we force eager creation of the arguments object when debugging.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+
+2009-05-21 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
+ <https://bugs.webkit.org/show_bug.cgi?id=25912>
+
+ This causes no change on SunSpider.
+
+ * runtime/NumberPrototype.cpp:
+ (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the
+ temporary buffer has sufficient space to store the result, and move the
+ explicit null-termination closer to the memcpy() for easier visual inspection
+ of the code.
+ (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT
+ that the temporary buffer has sufficient space to store the result. There
+ is no explicit null-termination because this is done by the caller. The
+ same is already true for exponentialPartToString().
+ (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly
+ null-terminate the result, and ASSERT that the temporary buffer has sufficient
+ space to store the result.
+
+2009-05-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Cleanup the JSGlobalData when exiting early with the usage statement in jsc.
+
+ * jsc.cpp:
+ (printUsageStatement):
+ (parseArguments):
+ (jscmain):
+
+2009-05-20 Stephanie Lewis <slewis@apple.com>
+
+ Update the order files. <rdar://problem/6881750> Generate new order files.
+
+ * JavaScriptCore.order:
+
+2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Replace WREC with YARR + YARR_JIT for the Qt port. This is only
+ used when compiled with JIT support for now, so it is a drop-in
+ replacement for the WREC usage. Still including the wrec headers
+ as they are being referred from RegExp.h, though the contents of
+ that header it protected by "#if ENABLE(WREC)".
+
+ * JavaScriptCore.pri:
+
+2009-05-20 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Eric Seidel.
+
+ Fix GTK debug build.
+
+ The function dumpDisjunction, compiled with debug enabled, uses
+ printf, which needs stdio.h to be included.
+
+ * yarr/RegexInterpreter.cpp:
+
+2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ BUG 25843: [Qt] Remove qt-port build flag
+ <https://bugs.webkit.org/show_bug.cgi?id=25843>
+
+ * JavaScriptCore.pro:
+
+
+2009-05-19 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix.
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.
+
+2009-05-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
+ Mac OS X at <unknown binary> • 0x9274241c
+
+ (Original patch by Joe Sokol and Ronnie Misra.)
+
+ SunSpider says 1.004x faster.
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated
+ math that sometimes used to overflow, just release the full range of the
+ register file.
+
+ * interpreter/RegisterFile.h:
+ (JSC::isPageAligned):
+ (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's
+ safe to release the full range of the register file.
+
+ (JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
+ new end is not smaller than the old end. (Also, doing so used to cause
+ numeric overflow, unmapping basically the whole process from memory.)
+
+2009-05-19 Oliver Hunt <oliver@apple.com>
+
+ RS=Mark Rowe.
+
+ <rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
+ <https://bugs.webkit.org/show_bug.cgi?id=25717>
+
+ Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
+ resulting in weird bugs in the nightly builds.
+
+ * parser/Nodes.cpp:
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::isNumber):
+ (JSC::ExpressionNode::isString):
+ (JSC::ExpressionNode::isNull):
+ (JSC::ExpressionNode::isPure):
+ (JSC::ExpressionNode::isLocation):
+ (JSC::ExpressionNode::isResolveNode):
+ (JSC::ExpressionNode::isBracketAccessorNode):
+ (JSC::ExpressionNode::isDotAccessorNode):
+ (JSC::ExpressionNode::isFuncExprNode):
+ (JSC::ExpressionNode::isSimpleArray):
+ (JSC::ExpressionNode::isAdd):
+ (JSC::ExpressionNode::resultDescriptor):
+ (JSC::StatementNode::firstLine):
+ (JSC::StatementNode::lastLine):
+ (JSC::StatementNode::isEmptyStatement):
+ (JSC::StatementNode::isReturnNode):
+ (JSC::StatementNode::isExprStatement):
+ (JSC::StatementNode::isBlock):
+ (JSC::NullNode::isNull):
+ (JSC::BooleanNode::isPure):
+ (JSC::NumberNode::value):
+ (JSC::NumberNode::setValue):
+ (JSC::NumberNode::isNumber):
+ (JSC::NumberNode::isPure):
+ (JSC::StringNode::isPure):
+ (JSC::StringNode::isString):
+ (JSC::ResolveNode::identifier):
+ (JSC::ResolveNode::isLocation):
+ (JSC::ResolveNode::isResolveNode):
+ (JSC::BracketAccessorNode::isLocation):
+ (JSC::BracketAccessorNode::isBracketAccessorNode):
+ (JSC::DotAccessorNode::base):
+ (JSC::DotAccessorNode::identifier):
+ (JSC::DotAccessorNode::isLocation):
+ (JSC::DotAccessorNode::isDotAccessorNode):
+ (JSC::TypeOfResolveNode::identifier):
+ (JSC::AddNode::isAdd):
+ (JSC::BlockNode::isBlock):
+ (JSC::EmptyStatementNode::isEmptyStatement):
+ (JSC::ExprStatementNode::isExprStatement):
+ (JSC::ReturnNode::isReturnNode):
+ (JSC::ScopeNode::sourceURL):
+ (JSC::ProgramNode::bytecode):
+ (JSC::EvalNode::bytecode):
+ (JSC::FunctionBodyNode::parameters):
+ (JSC::FunctionBodyNode::toSourceString):
+ (JSC::FunctionBodyNode::bytecode):
+ (JSC::FuncExprNode::isFuncExprNode):
+
+2009-05-19 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ - speed up string comparison, especially for short strings
+
+ ~1% on SunSpider
+
+ * JavaScriptCore.exp:
+ * runtime/UString.cpp:
+ * runtime/UString.h:
+ (JSC::operator==): Inline UString's operator==, since it is called from
+ hot places in the runtime. Also, specialize 2-char strings in a similar way to
+ 1-char, since we're taking the hit of a switch anyway.
+
+2009-05-18 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ - for polymorphic prototype lookups, increase the number of slots from 4 to 8
+
+ ~4% faster on v8 raytrace benchmark
+
+ * bytecode/Instruction.h:
+
+2009-05-18 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - tighten up the code for the load_varargs stub
+
+ ~1-2% on v8-raytrace
+
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that
+ the compiler didn't feel like hoisting for us. Remove unneeded exception check.
+
+2009-05-18 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - Improve code generation for access to prototype properties
+
+ ~0.4% speedup on SunSpider.
+
+ Based on a suggestion from Geoff Garen.
+
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetDirectOffset):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Gavin Barraclough.
+
+ Enable YARR, and disable WREC for GTK+.
+
+ * GNUmakefile.am:
+ * yarr/RegexParser.h:
+
+2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] Various autotools build refactoring and fixes
+ https://bugs.webkit.org/show_bug.cgi?id=25286
+
+ Add -no-install and -no-fast-install to programs and tests that we
+ don't install. Also remove -O2 since this is already handled at
+ configure time.
+
+ * GNUmakefile.am:
+
+2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] Various autotools build refactoring and fixes
+ https://bugs.webkit.org/show_bug.cgi?id=25286
+
+ Add JavaScriptCore/ to JSC include path only since it's not
+ required when building WebCore.
+
+ * GNUmakefile.am:
+
+2009-05-17 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2009-05-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Looking like MSVC doesn't like static variables in inline methods?
+ Make the state of the SSE2 check a static variable on the class
+ MacroAssemblerX86Common as a speculative build fix for Windows.
+
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
+ (JSC::MacroAssemblerX86Common::branchDouble):
+ (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
+ (JSC::MacroAssemblerX86Common::isSSE2Present):
+ (JSC::MacroAssemblerX86Common::):
+ * jit/JIT.cpp:
+
+2009-05-15 Adam Roben <aroben@apple.com>
+
+ Add some assembler headers to JavaScriptCore.vcproj
+
+ This is just a convenience for Windows developers.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2009-05-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
+ API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
+ FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
+ hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
+ other methods ASSERT_NOT_REACHED().
+
+ * assembler/AbstractMacroAssembler.h:
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::MacroAssemblerX86):
+ (JSC::MacroAssemblerX86::branch32):
+ (JSC::MacroAssemblerX86::branchPtrWithPatch):
+ (JSC::MacroAssemblerX86::supportsFloatingPoint):
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::):
+ (JSC::MacroAssemblerX86Common::loadDouble):
+ (JSC::MacroAssemblerX86Common::storeDouble):
+ (JSC::MacroAssemblerX86Common::addDouble):
+ (JSC::MacroAssemblerX86Common::subDouble):
+ (JSC::MacroAssemblerX86Common::mulDouble):
+ (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
+ (JSC::MacroAssemblerX86Common::branchDouble):
+ (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
+ (JSC::MacroAssemblerX86Common::branch32):
+ (JSC::MacroAssemblerX86Common::branch16):
+ (JSC::MacroAssemblerX86Common::branchTest32):
+ (JSC::MacroAssemblerX86Common::branchAdd32):
+ (JSC::MacroAssemblerX86Common::branchMul32):
+ (JSC::MacroAssemblerX86Common::branchSub32):
+ (JSC::MacroAssemblerX86Common::set32):
+ (JSC::MacroAssemblerX86Common::setTest32):
+ (JSC::MacroAssemblerX86Common::x86Condition):
+ (JSC::MacroAssemblerX86Common::isSSE2Present):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::movePtrToDouble):
+ (JSC::MacroAssemblerX86_64::moveDoubleToPtr):
+ (JSC::MacroAssemblerX86_64::setPtr):
+ (JSC::MacroAssemblerX86_64::branchPtr):
+ (JSC::MacroAssemblerX86_64::branchTestPtr):
+ (JSC::MacroAssemblerX86_64::branchAddPtr):
+ (JSC::MacroAssemblerX86_64::branchSubPtr):
+ (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
+ * assembler/X86Assembler.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::JIT):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_rshift):
+ (JSC::JIT::emitSlow_op_rshift):
+ (JSC::JIT::emitSlow_op_jnless):
+ (JSC::JIT::emitSlow_op_jnlesseq):
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::emit_op_add):
+ (JSC::JIT::emitSlow_op_add):
+ (JSC::JIT::emit_op_mul):
+ (JSC::JIT::emitSlow_op_mul):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+
+2009-05-15 Francisco Tolmasky <francisco@280north.com>
+
+ BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
+ <https://bugs.webkit.org/show_bug.cgi?id=25467>
+
+ Reviewed by Adam Roben.
+
+ * JavaScriptCore.exp: Added calculatedFunctionName
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
+ * debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode.
+ (JSC::DebuggerCallFrame::calculatedFunctionName):
+ * debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.
+
+2009-05-14 Gavin Barraclough <barraclough@apple.com>
+
+ Build fix, not reviewed.
+
+ Quick fixes for JIT builds with OPTIMIZE flags disabled.
+
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compilePutByIdHotPath):
+
+2009-05-14 Steve Falkenburg <sfalken@apple.com>
+
+ Back out incorrect Windows build fix
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2009-05-14 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2009-05-14 Adam Roben <aroben@apple.com>
+
+ Windows jsc build fix
+
+ r43648 modified jsc.vcproj's post-build event not to try to copy files
+ that aren't present. Then r43661 mistakenly un-did that modification.
+ This patch restores the modification from r43648, but puts the code in
+ jscCommon.vsprops (where it should have been added in r43648).
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty
+ VCPostBuildEventTool tags.
+ * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build
+ event command line to match the one in jsc.vcproj from r43648.
+
+2009-05-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25325
+
+ Make sure pthread_self() is declared before it gets called in Collector.cpp
+
+ * runtime/Collector.cpp: Include pthread.h in most Unix-like platforms
+ (not just for OPENBSD)
+
+2009-05-14 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>.
+ Bug 25785: Segfault in mark when using JSObjectMakeConstructor
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does.
+ * API/tests/testapi.c:
+ (main): Add a test case.
+ * runtime/JSObject.h:
+ (JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this,
+ but the cause of the failure is not clear from the assertion itself.
+
+2009-05-14 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Darin Adler.
+
+ <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
+
+ The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
+ Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
+ if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
+
+ * Configurations/Base.xcconfig:
+
+2009-05-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Checking register file bounds should be a ptr comparison (m_end is a Register*).
+ Also, the compare should be unsigned, pointers don'ts go negative.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+
+2009-05-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)
+
+ op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
+ This leads to bad happen.
+
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_loop_if_less):
+ (JSC::JIT::emitSlow_op_loop_if_less):
+
+2009-05-13 Dmitry Titov <dimich@chromium.org>
+
+ Rubber-stamped by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25746
+ Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingThread::start):
+ (JSC::SamplingThread::stop):
+ * bytecode/SamplingTool.h:
+ * wtf/CrossThreadRefCounted.h:
+ (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
+ (WTF::::ref):
+ (WTF::::deref):
+ * wtf/Threading.h:
+ * wtf/ThreadingNone.cpp:
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::identifierByPthreadHandle):
+ (WTF::establishIdentifierForPthreadHandle):
+ (WTF::pthreadHandleForIdentifier):
+ (WTF::clearPthreadHandleForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+ * wtf/ThreadingWin.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::storeThreadHandleByIdentifier):
+ (WTF::threadHandleForIdentifier):
+ (WTF::clearThreadHandleForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+ * wtf/gtk/ThreadingGtk.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::identifierByGthreadHandle):
+ (WTF::establishIdentifierForThread):
+ (WTF::threadForIdentifier):
+ (WTF::clearThreadForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+ * wtf/qt/ThreadingQt.cpp:
+ (WTF::threadMapMutex):
+ (WTF::threadMap):
+ (WTF::identifierByQthreadHandle):
+ (WTF::establishIdentifierForThread):
+ (WTF::clearThreadForIdentifier):
+ (WTF::threadForIdentifier):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+2009-05-13 Darin Adler <darin@apple.com>
+
+ Revert the parser arena change. It was a slowdown, not a speedup.
+ Better luck next time (I'll break it up into pieces).
+
+2009-05-13 Darin Adler <darin@apple.com>
+
+ Tiger build fix.
+
+ * parser/Grammar.y: Add back empty code blocks, needed by older
+ versions of bison on certain rules.
+
+2009-05-13 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2009-05-13 Adam Roben <aroben@apple.com>
+
+ Windows build fixes after r43642
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ Updated.
+
+ * debugger/Debugger.cpp:
+ * runtime/ArrayConstructor.cpp:
+ * runtime/JSArray.cpp:
+ * runtime/RegExp.cpp:
+ * runtime/RegExpConstructor.cpp:
+ * runtime/RegExpPrototype.cpp:
+ * runtime/StringPrototype.cpp:
+ Added missing #includes.
+
+2009-05-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 25674: syntax tree nodes should use arena allocation
+ https://bugs.webkit.org/show_bug.cgi?id=25674
+
+ Step 3: Add some actual arena allocation. About 1% SunSpider speedup.
+
+ * JavaScriptCore.exp: Updated.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
+ contains const Identifier* now.
+ (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const
+ Identifier&.
+ * bytecompiler/BytecodeGenerator.h: Ditto
+
+ * bytecompiler/SegmentedVector.h: Added isEmpty.
+
+ * debugger/Debugger.cpp:
+ (JSC::Debugger::recompileAllJSFunctions): Moved this function here from
+ WebCore so WebCore doesn't need the details of FunctionBodyNode.
+ * debugger/Debugger.h: Ditto.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute): Updated since VarStack contains const
+ Identifier* now.
+
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body
+ rather than on the function object, since we can't easily have inlined
+ access to the FunctionBodyNode in JSFunction.h since WebCore needs
+ access to that header.
+ (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::createCallIdentifier): Ditto.
+
+ * parser/Grammar.y: Use JSGlobalData* to pass the global data pointer
+ around whenever possible instead of using void*. Changed
+ SET_EXCEPTION_LOCATION from a macro to an inline function. Marked
+ the structure-creating functions inline. Changed the VarStack to use
+ identifier pointers instead of actual identifiers. This takes
+ advantage of the fact that all identifier pointers come from the
+ arena and avoids reference count churn. Changed Identifier* to
+ const Identifier* to make sure we don't modify any by accident.
+ Used identifiers for regular expression strings too, using the new
+ scanRegExp that has out parameters instead of the old one that relied
+ on side effects in the Lexer. Move the creation of numeric identifiers
+ out of this file and into the PropertyNode constructor.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
+ (JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
+ and changed to call ParserArena.
+ (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier*
+ as well as a prefix character argument so we can handle the /= case
+ without a string append.
+ (JSC::Lexer::skipRegExp): Added. Skips a regular expression without
+ allocating Identifier objects.
+ (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern,
+ and m_flags, and added code to set m_arena to 0.
+ * parser/Lexer.h: Updated for changes above.
+
+ * parser/NodeConstructors.h:
+ (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
+ on the arena.
+ (JSC::ParserArenaDeletable::operator new): Changed to call the
+ allocateDeletable function on the arena instead of deleteWithArena.
+ (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead
+ of UString since these come from the parser which makes identifiers.
+ (JSC::PropertyNode::PropertyNode): Added new constructor that makes
+ numeric identifiers. Some day we might want to optimize this for
+ integers so it doesn't create a string for each one.
+ (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
+ since it's now a const Identifier& so it can't be left uninitialized.
+ (JSC::BreakNode::BreakNode): Ditto.
+ (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
+ to keep track of the statements rather than a separate statement vector.
+ (JSC::BlockNode::BlockNode): Ditto.
+ (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
+
+ * parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
+ It seemed strangely out of place in the header.
+ (JSC::ThrowableExpressionData::emitThrowError): Added an overload for
+ UString as well as Identifier.
+ (JSC::SourceElements::singleStatement): Added.
+ (JSC::SourceElements::lastStatement): Added.
+ (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags
+ are now Identifier instead of UString. Also changed the throwError code
+ to use the substitution mechanism instead of doing a string append.
+ (JSC::SourceElements::emitBytecode): Added. Replaces the old
+ statementListEmitCode function, since we now keep the SourceElements
+ objects around.
+ (JSC::BlockNode::lastStatement): Added.
+ (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
+ statementListEmitCode.
+ (JSC::CaseClauseNode::emitBytecode): Added.
+ (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
+ instead of statementListEmitCode.
+ (JSC::ScopeNodeData::ScopeNodeData): Changed to store the
+ SourceElements* instead of using releaseContentsIntoVector.
+ (JSC::ScopeNode::emitStatementsBytecode): Added.
+ (JSC::ScopeNode::singleStatement): Added.
+ (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
+ of statementListEmitCode.
+ (JSC::EvalNode::emitBytecode): Ditto.
+ (JSC::EvalNode::generateBytecode): Removed code to clear the children
+ vector. This optimization is no longer possible since everything is in
+ a single arena.
+ (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
+ insetad of statementListEmitCode and check for the return node using
+ the new functions.
+
+ * parser/Nodes.h: Changed VarStack to store const Identifier* instead
+ of Identifier and rely on the arena to control lifetime. Added a new
+ ParserArenaFreeable class. Made ParserArenaDeletable inherit from
+ FastAllocBase instead of having its own operator new. Base the Node
+ class on ParserArenaFreeable. Changed the various Node classes
+ to use const Identifier& instead of Identifier to avoid the need to
+ call their destructors and allow them to function as "freeable" in the
+ arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
+ Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
+ CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
+ as a base class since they do not descend from Node. Eliminated the
+ StatementVector type and instead have various classes use SourceElements*
+ instead of StatementVector. This prevents those classes from having th
+ use ParserArenaDeletable to make sure the vector destructor is called.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::parse): Pass the arena to the lexer.
+
+ * parser/Parser.h: Added an include of ParserArena.h, which is no longer
+ included by Nodes.h.
+
+ * parser/ParserArena.cpp:
+ (JSC::ParserArena::ParserArena): Added. Initializes the new members,
+ m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
+ (JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
+ since we store only the current pointer and the end of pool pointer.
+ (JSC::ParserArena::deallocateObjects): Added. Contains the common
+ memory-deallocation logic used by both the destructor and the
+ reset function.
+ (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
+ (JSC::ParserArena::reset): Ditto. Also added code to zero out the
+ new structures, and switched to use clear() instead of shrink(0) since
+ we don't really reuse arenas.
+ (JSC::ParserArena::makeNumericIdentifier): Added.
+ (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
+ is empty.
+ (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
+ since this is used only for assertions at the moment.
+
+ * parser/ParserArena.h: Added an actual arena of "freeable" objects,
+ ones that don't need destructors to be called. Also added the segmented
+ vector of identifiers that used to be in the Lexer.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::extractFunctionBody): Use singleStatement function rather than
+ getting at a StatementVector.
+
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncToString): Call isHostFunction on the body
+ rather than the function object.
+
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction): Moved the structure version of this in
+ here from the header. It's not hot enough that it needs to be inlined.
+ (JSC::JSFunction::isHostFunction): Moved this in here from the header.
+ It's now a helper to be used only within the class.
+ (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that
+ it needs to be inlined, and we want to be able to compile the header
+ without the definition of FunctionBodyNode.
+
+ * runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was
+ exposing too much JavaScriptCore dependency to WebCore. Because of this
+ change and some changes made to WebCore, we could now export a lot fewer
+ headers from JavaScriptCore, but I have not done that yet in this check-in.
+ Made a couple functions non-inline. Removes some isHostFunction() assertions.
+
+ * wtf/FastAllocBase.h: Added the conventional using statements we use in
+ WTF so we can use identifiers from the WTF namespace without explicit
+ namespace qualification or namespace directive. This is the usual WTF style,
+ although it's unconventional in the C++ world. We use the namespace primarily
+ for link-time disambiguation, not compile-time.
+
+ * wtf/FastMalloc.cpp: Fixed an incorrect comment.
+
+2009-05-13 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix: add JITStubCall.h to files list.
+
+ * GNUmakefile.am:
+
+2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Unreviewed build fix, as suggested by Yael Aharon <yael.aharon@nokia.com>.
+
+ * wtf/qt/ThreadingQt.cpp:
+ (WTF::waitForThreadCompletion): renamed IsValid to isValid.
+
+2009-05-13 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
+ WebCore/config.h.
+
+ * wtf/Platform.h:
+
+2009-05-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
+ (enabled using ENABLE(SAMPLING_COUNTERS)). To count events within a single function
+ use the class 'SamplingCounter', where the counter may be incremented from multiple
+ functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
+ heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
+ Further description of these classes is provided alongside their definition in
+ SamplingTool.h.
+
+ Counters may be incremented from c++ by calling the 'count()' method on the counter,
+ or may be incremented by JIT code by using the 'emitCount()' method within the JIT.
+
+ This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.
+
+ * JavaScriptCore.exp:
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::addWithCarry32):
+ (JSC::MacroAssemblerX86::and32):
+ (JSC::MacroAssemblerX86::or32):
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::and32):
+ (JSC::MacroAssemblerX86Common::or32):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::and32):
+ (JSC::MacroAssemblerX86_64::or32):
+ (JSC::MacroAssemblerX86_64::addPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::adcl_im):
+ (JSC::X86Assembler::addq_im):
+ (JSC::X86Assembler::andl_im):
+ (JSC::X86Assembler::orl_im):
+ * bytecode/SamplingTool.cpp:
+ (JSC::AbstractSamplingCounter::dump):
+ * bytecode/SamplingTool.h:
+ (JSC::AbstractSamplingCounter::count):
+ (JSC::GlobalSamplingCounter::name):
+ (JSC::SamplingCounter::SamplingCounter):
+ * jit/JIT.h:
+ * jit/JITCall.cpp:
+ (JSC::):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::setSamplingFlag):
+ (JSC::JIT::clearSamplingFlag):
+ (JSC::JIT::emitCount):
+ * jsc.cpp:
+ (runWithScripts):
+ * parser/Nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+ * wtf/Platform.h:
+
+2009-05-13 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+
+2009-05-12 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+
+2009-05-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading http://www.sears.com
+
+ We created the arguments objects before an op_push_scope but not
+ before op_push_new_scope, this meant a null arguments object could
+ be resolved inside catch blocks.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitPushNewScope):
+
+2009-05-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading http://www.monster.com; http://www.cnet.com
+ <https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)
+
+ Following on from the lazy arguments creation patch, it's now
+ possible for an activation to to have a null register in the callframe
+ so we can't just blindly mark the local registers in an activation,
+ and must null check first instead.
+
+ * API/tests/testapi.c:
+ (functionGC):
+ * API/tests/testapi.js:
+ (bludgeonArguments.return.g):
+ (bludgeonArguments):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::mark):
+
+2009-05-12 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Geoff Garen.
+
+ WTF_USE_CTI_REPATCH_PIC is no longer used, remove.
+
+ * jit/JIT.h:
+ * jit/JITStubCall.h:
+
+2009-05-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ We've run into some problems where changing the size of the class JIT leads to
+ performance fluctuations. Try forcing alignment in an attempt to stabalize this.
+
+ * jit/JIT.h:
+
+2009-05-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Add ParserArena.cpp to the build.
+
+ * JavaScriptCoreSources.bkl:
+
+2009-05-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Unsigned underflow on 64bit cannot be treated as a negative number
+
+ This code included some placeswhere we deliberately create negative offsets
+ from unsigned values, on 32bit this is "safe", but in 64bit builds much
+ badness occurs. Solution is to use signed types as nature intended.
+
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_load_varargs):
+
+2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ [Gtk] Various autotools build refactoring and fixes
+ https://bugs.webkit.org/show_bug.cgi?id=25286
+
+ Define WTF_USE_JSC for the Gtk port.
+
+ * wtf/Platform.h:
+
+2009-05-12 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - allow all of strictEqual to be inlined into cti_op_stricteq once again
+
+ We had this optimization once but accidentally lost it at some point.
+
+ * runtime/Operations.h:
+ (JSC::JSValue::strictEqualSlowCaseInline):
+ (JSC::JSValue::strictEqual):
+
+2009-05-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ instanceof should throw if the constructor being tested does not implement
+ 'HasInstance" (i.e. is a function). Instead we were returning false.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::isInvalidParamForIn):
+ (JSC::isInvalidParamForInstanceOf):
+ (JSC::Interpreter::privateExecute):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_instanceof):
+ * tests/mozilla/ecma_2/instanceof/instanceof-003.js:
+ Fix broken test case.
+ * tests/mozilla/ecma_2/instanceof/regress-7635.js:
+ Remove broken test case (was an exact duplicate of a test in instanceof-003.js).
+
+2009-05-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve function call forwarding performance
+
+ Make creation of the Arguments object occur lazily, so it
+ is not necessarily created for every function that references
+ it. Then add logic to Function.apply to allow it to avoid
+ allocating the Arguments object at all. Helps a lot with
+ the function forwarding/binding logic in jQuery, Prototype,
+ and numerous other JS libraries.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/Opcode.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::registerFor):
+ (JSC::BytecodeGenerator::willResolveToArguments):
+ (JSC::BytecodeGenerator::uncheckedRegisterForArguments):
+ (JSC::BytecodeGenerator::createArgumentsIfNecessary):
+ (JSC::BytecodeGenerator::emitCallEval):
+ (JSC::BytecodeGenerator::emitPushScope):
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JIT.h:
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_create_arguments):
+ (JSC::JIT::emit_op_init_arguments):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_tear_off_arguments):
+ (JSC::JITStubs::cti_op_load_varargs):
+ * parser/Nodes.cpp:
+ (JSC::ApplyFunctionCallDotNode::emitBytecode):
+
+2009-05-11 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Enable use of SamplingFlags directly from JIT code.
+
+ * bytecode/SamplingTool.h:
+ * jit/JIT.h:
+ (JSC::JIT::sampleCodeBlock):
+ (JSC::JIT::sampleInstruction):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::setSamplingFlag):
+ (JSC::JIT::clearSamplingFlag):
+
+2009-05-11 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Implement JIT generation for instanceof for non-objects (always returns false).
+ Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.
+
+ 0.5% progression on v8 tests overall, due to 3.5% on early-boyer.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::hasInstance):
+ * runtime/TypeInfo.h:
+ (JSC::TypeInfo::TypeInfo):
+
+2009-05-11 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more JIT refactoring.
+
+ Rearranged code to more clearly indicate what's conditionally compiled
+ and why. Now, all shared code is at the top of our JIT files, and all
+ #if'd code is at the bottom. #if'd code is delineated by large comments.
+
+ Moved functions that relate to the JIT but don't explicitly do codegen
+ into JIT.cpp. Refactored SSE2 check to store its result as a data member
+ in the JIT.
+
+ * jit/JIT.cpp:
+ (JSC::isSSE2Present):
+ (JSC::JIT::JIT):
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ * jit/JIT.h:
+ (JSC::JIT::isSSE2Present):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_mod):
+ (JSC::JIT::emitSlow_op_mod):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallVarargs):
+ (JSC::JIT::compileOpCallVarargsSlowCase):
+
+2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ * JavaScriptCore.pri: Build the new JITOpcodes.cpp
+
+2009-05-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ More re-factoring of JIT code generation. Use a macro to
+ forward the main switch-statement cases to the helper functions.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+
+2009-05-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ More re-factoring of JIT code generation to move opcode generation
+ to helper functions outside the main switch-statement and gave those
+ helper functions standardized names. This patch covers the remaining
+ slow cases.
+
+ * jit/JIT.cpp:
+ * jit/JIT.h:
+ * jit/JITOpcodes.cpp:
+
+2009-05-11 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * GNUmakefile.am: Added JITOpcodes.cpp and JITStubCall.h to the project.
+
+2009-05-11 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
+ JITOpcodes.cpp and JITStubCall.h to the project.
+
+2009-05-11 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Some JIT refactoring.
+
+ Moved JITStubCall* into its own header.
+
+ Modified JITStubCall to ASSERT that its return value is handled correctly.
+ Also, replaced function template with explicit instantiations to resolve
+ some confusion.
+
+ Replaced all uses of emit{Get,Put}CTIArgument with explicit peeks, pokes,
+ and calls to killLastResultRegister().
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ * jit/JITCall.cpp:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ * jit/JITPropertyAccess.cpp:
+ * jit/JITStubCall.h: Copied from jit/JIT.h.
+ (JSC::JITStubCall::JITStubCall):
+ (JSC::JITStubCall::addArgument):
+ (JSC::JITStubCall::call):
+ (JSC::JITStubCall::):
+
+2009-05-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Start re-factoring JIT code generation to move opcode generation
+ to helper functions outside the main switch-statement and gave those
+ helper functions standardized names. This patch only covers the main
+ pass and all the arithmetic opcodes in the slow path.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ * jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
+ * jit/JITPropertyAccess.cpp:
+
+2009-05-11 Steve Falkenburg <sfalken@apple.com>
+
+ Re-add experimental PGO configs.
+
+ Reviewed by Adam Roben.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+ * JavaScriptCore.vcproj/JavaScriptCore.sln:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2009-05-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey "1" Garen.
+
+ Rip out the !USE(CTI_REPATCH_PIC) code. It was untested and unused.
+
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdChainList):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compileCTIMachineTrampolines):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::tryCachePutByID):
+ (JSC::JITStubs::tryCacheGetByID):
+
+2009-05-11 Dmitry Titov <dimich@chromium.org>
+
+ GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.
+
+ * wtf/ThreadingPthreads.cpp: used #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().
+
+2009-05-11 Adam Roben <aroben@apple.com>
+
+ Build fix for newer versions of GCC
+
+ * wtf/ThreadingPthreads.cpp: Added a declaration of
+ waitForThreadCompletion before its definition to silence a warning.
+
+2009-05-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov and Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25348
+ Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
+
+ * wtf/Threading.h:
+ (WTF::ThreadIdentifier::ThreadIdentifier):
+ (WTF::ThreadIdentifier::isValid):
+ (WTF::ThreadIdentifier::invalidate):
+ (WTF::ThreadIdentifier::platformId):
+ ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
+ methods that are used across the code on thread ids: construction, comparisons,
+ check for 'valid' state etc. '0' is used as invalid id, which happens to just work
+ with all platform-specific thread id implementations.
+
+ All the following files repeatedly reflect the new ThreadIdentifier for each platform.
+ We remove ThreadMap and threadMapMutex from all of them, remove the functions that
+ populated/searched/cleared the map and add platform-specific comparison operators
+ for ThreadIdentifier.
+
+ There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
+ public build uses WTF threading functions with old type of ThreadingIdentifier.
+ The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
+ functions so the deprecated ones can be removed.
+
+ * wtf/gtk/ThreadingGtk.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+ * wtf/ThreadingNone.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+ (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac.
+ Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t.
+ This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can
+ load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous
+ decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t.
+ This function will be removed as soon as Safari 4 will release next public build.
+
+ * wtf/qt/ThreadingQt.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+ * wtf/ThreadingWin.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
+ counter as a thread ID and mapped it into platform ID. Windows was using native thread
+ id and mapped it into thread handle. Since we can always obtain a thread handle
+ by thread id, createThread now closes the handle.
+ (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
+ it means the thread already exited.
+ (WTF::detachThread):
+ (WTF::currentThread):
+ (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
+ (WTF::waitForThreadCompletionDeprecated): same.
+ (WTF::currentThreadDeprecated): same.
+ (WTF::createThreadDeprecated): same.
+
+ * bytecode/SamplingTool.h:
+ * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
+
+ * JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions
+ since they now take a different type as a parameter.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
+ that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
+
+2009-05-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 25560: REGRESSION (r34821): "string value".__proto__ gets the wrong object.
+ https://bugs.webkit.org/show_bug.cgi?id=25560
+ rdar://problem/6861069
+
+ I missed this case back a year ago when I sped up handling
+ of JavaScript wrappers. Easy to fix.
+
+ * runtime/JSObject.h:
+ (JSC::JSValue::get): Return the prototype itself if the property name
+ is __proto__.
+ * runtime/JSString.cpp:
+ (JSC::JSString::getOwnPropertySlot): Ditto.
+
+2009-05-09 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetFromCallFrameHeaderPtr):
+ (JSC::JIT::emitGetFromCallFrameHeader32):
+
+2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix. Build ParserAreana.cpp for Qt
+
+ * JavaScriptCore.pri:
+
+2009-05-11 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24536
+
+ Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
+ unless Profile.h is included.
+
+ * profiler/ProfileGenerator.h:
+
+2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24284
+
+ * JavaScriptCore.pri: coding style modified
+ * jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES
+
+2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by NOBODY (build fix).
+
+ Also add ParserArena, in addition to AllInOne, for release builds,
+ since adding it to AllInOne breaks Mac.
+
+ * GNUmakefile.am:
+
+2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed build fix. Adding ParserArena to the autotools build.
+
+ * GNUmakefile.am:
+
+2009-05-11 Adam Roben <aroben@apple.com>
+
+ More Windows build fixes after r43479
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ Export ParserArena::reset.
+
+2009-05-11 Adam Roben <aroben@apple.com>
+
+ Windows build fixes after r43479
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
+ ParserArena to the project.
+
+ * parser/NodeConstructors.h: Added a missing include.
+ (JSC::ParserArenaDeletable::operator new): Marked these as inline.
+
+2009-05-10 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - fixed REGRESSION(r43432): Many JavaScriptCore tests crash in 64-bit
+ https://bugs.webkit.org/show_bug.cgi?id=25680
+
+ Accound for the 64-bit instruction prefix when rewriting mov to lea on 64-bit.
+
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+
+2009-05-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 25674: syntax tree nodes should use arena allocation
+ https://bugs.webkit.org/show_bug.cgi?id=25674
+
+ Part two: Remove reference counting from most nodes.
+
+ * JavaScriptCore.exp: Updated.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Added ParserArena.h and .cpp.
+
+ * parser/Grammar.y: Replaced uses of ParserRefCountedData with uses of
+ ParserArenaData. Took out now-nonfunctional code that tries to manually
+ release declaration list. Changed the new calls that create FuncDeclNode
+ and FuncExprNode so that they use the proper version of operator new for
+ the reference-counted idiom, not the deletion idiom.
+
+ * parser/NodeConstructors.h:
+ (JSC::ParserArenaDeletable::operator new): Added.
+ (JSC::ParserArenaRefCounted::ParserArenaRefCounted): Added.
+ (JSC::Node::Node): Removed ParserRefCounted initializer.
+ (JSC::ElementNode::ElementNode): Ditto.
+ (JSC::PropertyNode::PropertyNode): Ditto.
+ (JSC::ArgumentsNode::ArgumentsNode): Ditto.
+ (JSC::SourceElements::SourceElements): Ditto.
+ (JSC::ParameterNode::ParameterNode): Ditto.
+ (JSC::FuncExprNode::FuncExprNode): Added ParserArenaRefCounted initializer.
+ (JSC::FuncDeclNode::FuncDeclNode): Ditto.
+ (JSC::CaseClauseNode::CaseClauseNode): Removed ParserRefCounted initializer.
+ (JSC::ClauseListNode::ClauseListNode): Ditto.
+ (JSC::CaseBlockNode::CaseBlockNode): Ditto.
+
+ * parser/NodeInfo.h: Replaced uses of ParserRefCountedData with uses of
+ ParserArenaData.
+
+ * parser/Nodes.cpp:
+ (JSC::ScopeNode::ScopeNode): Added ParserArenaRefCounted initializer.
+ (JSC::ProgramNode::create): Use the proper version of operator new for
+ the reference-counted idiom, not the deletion idiom. Use the arena
+ contains function instead of the vecctor find function.
+ (JSC::EvalNode::create): Use the proper version of operator new for
+ the reference-counted idiom, not the deletion idiom. Use the arena
+ reset function instead of the vector shrink function.
+ (JSC::FunctionBodyNode::createNativeThunk): Use the proper version
+ of operator new for the reference-counted idiom, not the deletion idiom.
+ (JSC::FunctionBodyNode::create): More of the same.
+
+ * parser/Nodes.h: Added ParserArenaDeletable and ParserArenaRefCounted
+ to replace ParserRefCounted. Fixed inheritance so only the classes that
+ need reference counting inherit from ParserArenaRefCounted.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::parse): Set m_sourceElements to 0 since it now starts
+ uninitialized. Just set it to 0 again in the failure case, since it's
+ now just a raw pointer, not an owning one.
+ (JSC::Parser::reparseInPlace): Removed now-unneeded get() function.
+ (JSC::Parser::didFinishParsing): Replaced uses of ParserRefCountedData
+ with uses of ParserArenaData.
+
+ * parser/Parser.h: Less RefPtr, more arena.
+
+ * parser/ParserArena.cpp: Added.
+ * parser/ParserArena.h: Added.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::~JSGlobalData): Removed arena-related code, since it's
+ now in the Parser.
+ (JSC::JSGlobalData::createLeaked): Removed unneeded #ifndef.
+ (JSC::JSGlobalData::createNativeThunk): Tweaked #if a bit.
+
+ * runtime/JSGlobalData.h: Removed parserArena, which is now in Parser.
+
+ * wtf/RefCounted.h: Added deletionHasBegun function, for use in
+ assertions to catch deletion not done by the deref function.
+
+2009-05-10 David Kilzer <ddkilzer@apple.com>
+
+ Part 2: Try to fix the Windows build by adding a symbol which is really just a re-mangling of a changed method signature
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-10 David Kilzer <ddkilzer@apple.com>
+
+ Try to fix the Windows build by removing an unknown symbol
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-10 David Kilzer <ddkilzer@apple.com>
+
+ Touch Nodes.cpp to try to fix Windows build
+
+ * parser/Nodes.cpp: Removed whitespace.
+
+2009-05-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Quick fix for failures seen on buildbot. Maciej plans a better fix later.
+
+ * wtf/dtoa.cpp: Change the hardcoded number of 32-bit words in a BigInt
+ from 32 to 64. Parsing "1e500", for example, requires more than 32 words.
+
+2009-05-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 25674: syntax tree nodes should use arena allocation
+ Part one: Change lifetimes so we won't have to use reference
+ counting so much, but don't eliminate the reference counts
+ entirely yet.
+
+ * JavaScriptCore.exp: Updated.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator): Update for use of raw pointers
+ instead of RefPtr.
+ (JSC::BytecodeGenerator::emitCall): Ditto.
+ (JSC::BytecodeGenerator::emitConstruct): Ditto.
+
+ * parser/Grammar.y: Update node creating code to use new (JSGlobalData*)
+ instead of the plain new. At the moment this is just a hook for future
+ arena allocation; it's inline and JSGlobalData* is not used.
+
+ * parser/NodeConstructors.h: Updated for name change of parserObjects to
+ parserArena. Also added explicit initialization for raw pointers that used
+ to be RefPtr. Also removed some uses of get() that aren't needed now that
+ the pointers are raw pointers. Also eliminated m_parameter from FuncExprNode
+ and FuncDeclNode. Also changed node-creating code to use new (JSGlobalData*)
+ as above.
+
+ * parser/Nodes.cpp: Eliminated NodeReleaser and all use of it.
+ (JSC::ParserRefCounted::ParserRefCounted): Updated for name change of
+ parserObjects to parserArena.
+ (JSC::SourceElements::append): Use raw pointers.
+ (JSC::ArrayNode::emitBytecode): Ditto.
+ (JSC::ArrayNode::isSimpleArray): Ditto.
+ (JSC::ArrayNode::toArgumentList): Ditto.
+ (JSC::ObjectLiteralNode::emitBytecode): Ditto.
+ (JSC::PropertyListNode::emitBytecode): Ditto.
+ (JSC::BracketAccessorNode::emitBytecode): Ditto.
+ (JSC::DotAccessorNode::emitBytecode): Ditto.
+ (JSC::ArgumentListNode::emitBytecode): Ditto.
+ (JSC::NewExprNode::emitBytecode): Ditto.
+ (JSC::EvalFunctionCallNode::emitBytecode): Ditto.
+ (JSC::FunctionCallValueNode::emitBytecode): Ditto.
+ (JSC::FunctionCallResolveNode::emitBytecode): Ditto.
+ (JSC::FunctionCallBracketNode::emitBytecode): Ditto.
+ (JSC::FunctionCallDotNode::emitBytecode): Ditto.
+ (JSC::CallFunctionCallDotNode::emitBytecode): Ditto.
+ (JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto.
+ (JSC::PostfixBracketNode::emitBytecode): Ditto.
+ (JSC::PostfixDotNode::emitBytecode): Ditto.
+ (JSC::DeleteBracketNode::emitBytecode): Ditto.
+ (JSC::DeleteDotNode::emitBytecode): Ditto.
+ (JSC::DeleteValueNode::emitBytecode): Ditto.
+ (JSC::VoidNode::emitBytecode): Ditto.
+ (JSC::TypeOfValueNode::emitBytecode): Ditto.
+ (JSC::PrefixBracketNode::emitBytecode): Ditto.
+ (JSC::PrefixDotNode::emitBytecode): Ditto.
+ (JSC::UnaryOpNode::emitBytecode): Ditto.
+ (JSC::BinaryOpNode::emitStrcat): Ditto.
+ (JSC::BinaryOpNode::emitBytecode): Ditto.
+ (JSC::EqualNode::emitBytecode): Ditto.
+ (JSC::StrictEqualNode::emitBytecode): Ditto.
+ (JSC::ReverseBinaryOpNode::emitBytecode): Ditto.
+ (JSC::ThrowableBinaryOpNode::emitBytecode): Ditto.
+ (JSC::InstanceOfNode::emitBytecode): Ditto.
+ (JSC::LogicalOpNode::emitBytecode): Ditto.
+ (JSC::ConditionalNode::emitBytecode): Ditto.
+ (JSC::ReadModifyResolveNode::emitBytecode): Ditto.
+ (JSC::AssignResolveNode::emitBytecode): Ditto.
+ (JSC::AssignDotNode::emitBytecode): Ditto.
+ (JSC::ReadModifyDotNode::emitBytecode): Ditto.
+ (JSC::AssignBracketNode::emitBytecode): Ditto.
+ (JSC::ReadModifyBracketNode::emitBytecode): Ditto.
+ (JSC::CommaNode::emitBytecode): Ditto.
+ (JSC::ConstDeclNode::emitCodeSingle): Ditto.
+ (JSC::ConstDeclNode::emitBytecode): Ditto.
+ (JSC::ConstStatementNode::emitBytecode): Ditto.
+ (JSC::statementListEmitCode): Ditto.
+ (JSC::BlockNode::emitBytecode): Ditto.
+ (JSC::ExprStatementNode::emitBytecode): Ditto.
+ (JSC::VarStatementNode::emitBytecode): Ditto.
+ (JSC::IfNode::emitBytecode): Ditto.
+ (JSC::IfElseNode::emitBytecode): Ditto.
+ (JSC::DoWhileNode::emitBytecode): Ditto.
+ (JSC::WhileNode::emitBytecode): Ditto.
+ (JSC::ForNode::emitBytecode): Ditto.
+ (JSC::ForInNode::emitBytecode): Ditto.
+ (JSC::ReturnNode::emitBytecode): Ditto.
+ (JSC::WithNode::emitBytecode): Ditto.
+ (JSC::CaseBlockNode::tryOptimizedSwitch): Ditto.
+ (JSC::CaseBlockNode::emitBytecodeForBlock): Ditto.
+ (JSC::SwitchNode::emitBytecode): Ditto.
+ (JSC::LabelNode::emitBytecode): Ditto.
+ (JSC::ThrowNode::emitBytecode): Ditto.
+ (JSC::TryNode::emitBytecode): Ditto.
+ (JSC::ScopeNodeData::ScopeNodeData): Use swap to transfer ownership
+ of the arena, varStack and functionStack.
+ (JSC::ScopeNode::ScopeNode): Pass in the arena when creating the
+ ScopeNodeData.
+ (JSC::ProgramNode::ProgramNode): Made this inline since it's used
+ in only one place.
+ (JSC::ProgramNode::create): Changed this to return a PassRefPtr since
+ we plan to have the scope nodes be outside the arena, so they will need
+ some kind of ownership transfer (maybe auto_ptr instead of PassRefPtr
+ in the future, though). Remove the node from the newly-created arena to
+ avoid a circular reference. Later we'll keep the node out of the arena
+ by using a different operator new, but for now it's the ParserRefCounted
+ constructor that puts the node into the arena, and there's no way to
+ bypass that.
+ (JSC::EvalNode::EvalNode): Ditto.
+ (JSC::EvalNode::create): Ditto.
+ (JSC::FunctionBodyNode::FunctionBodyNode): Ditto.
+ (JSC::FunctionBodyNode::createNativeThunk): Moved the code that
+ reseets the arena here instead of the caller.
+ (JSC::FunctionBodyNode::create): Same change as the other create
+ functions above.
+ (JSC::FunctionBodyNode::emitBytecode): Use raw pointers.
+
+ * parser/Nodes.h: Removed NodeReleaser. Changed FunctionStack to
+ use raw pointers. Removed the releaseNodes function. Added an override
+ of operator new that takes a JSGlobalData* to prepare for future arena use.
+ Use raw pointers instead of RefPtr everywhere possible.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::reparseInPlace): Pass the arena in.
+
+ * parser/Parser.h:
+ (JSC::Parser::parse): Updated for name change of parserObjects to parserArena.
+ (JSC::Parser::reparse): Ditto.
+ * runtime/FunctionConstructor.cpp:
+ (JSC::extractFunctionBody): Ditto.
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::~JSGlobalData): Ditto.
+ (JSC::JSGlobalData::createNativeThunk): Moved arena manipulation into the
+ FunctionBodyNode::createNativeThunk function.
+
+ * runtime/JSGlobalData.h: Tweaked formatting and renamed parserObjects to
+ parserArena.
+
+ * wtf/NotFound.h: Added the usual "using WTF" to this header to match the
+ rest of WTF.
+
+2009-05-10 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25670
+ Remove no longer valid chunk of code from dtoa.
+
+ * wtf/dtoa.cpp:
+ (WTF::dtoa): Removed invalid code.
+
+2009-05-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ "Class const *" is the same as "const Class*", use the latter syntax consistently.
+
+ See <http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.9>.
+
+ * pcre/pcre_compile.cpp:
+ (calculateCompiledPatternLength):
+ * runtime/JSObject.h:
+ (JSC::JSObject::offsetForLocation):
+ (JSC::JSObject::locationForOffset):
+
+2009-05-10 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - speedup dtoa/strtod
+
+ Added a bunch of inlining, and replaced malloc with stack allocation.
+
+ 0.5% SunSpider speedup (7% on string-tagcloud).
+
+ * runtime/NumberPrototype.cpp:
+ (JSC::integerPartNoExp):
+ (JSC::numberProtoFuncToExponential):
+ * runtime/UString.cpp:
+ (JSC::concatenate):
+ (JSC::UString::from):
+ * wtf/dtoa.cpp:
+ (WTF::BigInt::BigInt):
+ (WTF::BigInt::operator=):
+ (WTF::Balloc):
+ (WTF::Bfree):
+ (WTF::multadd):
+ (WTF::s2b):
+ (WTF::i2b):
+ (WTF::mult):
+ (WTF::pow5mult):
+ (WTF::lshift):
+ (WTF::cmp):
+ (WTF::diff):
+ (WTF::b2d):
+ (WTF::d2b):
+ (WTF::ratio):
+ (WTF::strtod):
+ (WTF::quorem):
+ (WTF::freedtoa):
+ (WTF::dtoa):
+ * wtf/dtoa.h:
+
+2009-05-09 Mike Hommey <glandium@debian.org>
+
+ Reviewed by Geoffrey Garen. Landed by Jan Alonzo.
+
+ Enable JIT on x86-64 gtk+
+ https://bugs.webkit.org/show_bug.cgi?id=24724
+
+ * GNUmakefile.am:
+
+2009-05-09 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Removed the last non-call-related manually managed JIT stub call.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall
+ abstraction, instead of emitPutJITStubArg.
+
+2009-05-09 Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25653
+ PLATFORM(X86_64) inherits ia64
+
+ __ia64__ is defined by gcc in an IA64 arch and has completely
+ nothing in common with X86-64 exept both are from Intel and have
+ an 64bit address space. That's it. Since code seems to expect x86
+ here, ia64 has to go.
+
+ * wtf/Platform.h:
+
+2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
+
+ Suggested by Geoffrey Garen.
+
+ Assume SSE2 is present on X86-64 and on MAC X86-32. This fixes a
+ build breakage on non-Mac X86-64 when JIT is enabled.
+
+ * jit/JITArithmetic.cpp:
+
+2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
+
+ Build fix, adding missing files to make dist.
+
+ * GNUmakefile.am:
+
+2009-05-09 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::patchLoadToLEA):
+
+2009-05-09 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::patchLoadToLEA):
+
+2009-05-09 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Original patch by John McCall. Updated by Cameron Zwarich. Further refined by me.
+
+ - Assorted speedups to property access
+
+ ~.3%-1% speedup on SunSpider
+
+ 1) When we know from the structure ID that an object is using inline storage, plant direct
+ loads and stores against it; no need to indirect through storage pointer.
+
+ 2) Also because of the above, union the property storage pointer with the first inline property
+ slot and add an extra inline property slot.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction):
+ (JSC::AbstractMacroAssembler::CodeLocationInstruction::patchLoadToLEA):
+ (JSC::::CodeLocationCommon::instructionAtOffset):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::storePtr):
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::store32):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::storePtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::movq_EAXm):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::patchLoadToLEA):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compilePutDirectOffset):
+ (JSC::JIT::compileGetDirectOffset):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::removeDirect):
+ * runtime/JSObject.h:
+ (JSC::JSObject::propertyStorage):
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getOffset):
+ (JSC::JSObject::offsetForLocation):
+ (JSC::JSObject::locationForOffset):
+ (JSC::JSObject::getDirectOffset):
+ (JSC::JSObject::putDirectOffset):
+ (JSC::JSObject::isUsingInlineStorage):
+ (JSC::JSObject::):
+ (JSC::JSObject::JSObject):
+ (JSC::JSObject::~JSObject):
+ (JSC::Structure::isUsingInlineStorage):
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::putDirectWithoutTransition):
+ (JSC::JSObject::allocatePropertyStorageInline):
+ * runtime/Structure.h:
+
+2009-05-09 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Changed all our JIT stubs so that they return a maximum of 1 JS value or
+ two non-JS pointers, and do all other value returning through out
+ parameters, in preparation for 64bit JS values on a 32bit system.
+
+ Stubs that used to return two JSValues now return one JSValue and take
+ and out parameter specifying where in the register array the second
+ value should go.
+
+ SunSpider reports no change.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_post_inc):
+ (JSC::JIT::compileFastArithSlow_op_post_dec):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_call_arityCheck):
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_post_inc):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+ (JSC::JITStubs::cti_op_post_dec):
+ * jit/JITStubs.h:
+ (JSC::):
+
+2009-05-08 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed <rdar://problem/6634956> CrashTracer: [REGRESSION] >400 crashes
+ in Safari at com.apple.JavaScriptCore • JSC::BytecodeGenerator::emitComplexJumpScopes + 468
+ https://bugs.webkit.org/show_bug.cgi?id=25658
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitComplexJumpScopes): Guard the whole loop
+ with a bounds check. The old loop logic would decrement and read topScope
+ without a bounds check, which could cause crashes on page boundaries.
+
+2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by NOBODY (BuildFix).
+
+ Gtk fix: add LiteralParser to the build script per r43424.
+
+ Add LiteralParser to the Qt and Wx build scripts too.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCoreSources.bkl:
+
+2009-05-08 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough and Darin Adler.
+
+ Add a limited literal parser for eval to handle object and array literals fired at eval
+
+ This is a simplified parser and lexer that we can throw at strings passed to eval
+ in case a site is using eval to parse JSON (eg. json2.js). The lexer is intentionally
+ limited (in effect it's whitelisting a limited "common" subset of the JSON grammar)
+ as this decreases the likelihood of us wating time attempting to parse any significant
+ amount of non-JSON content.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::callEval):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ * runtime/LiteralParser.cpp: Added.
+ (JSC::isStringCharacter):
+ (JSC::LiteralParser::Lexer::lex):
+ (JSC::LiteralParser::Lexer::lexString):
+ (JSC::LiteralParser::Lexer::lexNumber):
+ (JSC::LiteralParser::parseStatement):
+ (JSC::LiteralParser::parseExpression):
+ (JSC::LiteralParser::parseArray):
+ (JSC::LiteralParser::parseObject):
+ (JSC::LiteralParser::StackGuard::StackGuard):
+ (JSC::LiteralParser::StackGuard::~StackGuard):
+ (JSC::LiteralParser::StackGuard::isSafe):
+ * runtime/LiteralParser.h: Added.
+ (JSC::LiteralParser::LiteralParser):
+ (JSC::LiteralParser::attemptJSONParse):
+ (JSC::LiteralParser::):
+ (JSC::LiteralParser::Lexer::Lexer):
+ (JSC::LiteralParser::Lexer::next):
+ (JSC::LiteralParser::Lexer::currentToken):
+ (JSC::LiteralParser::abortParse):
+
+2009-05-08 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Restored a Mozilla JS test I accidentally gutted.
+
+ * tests/mozilla/ecma/Array/15.4.4.2.js:
+ (getTestCases):
+ (test):
+
+2009-05-08 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ More abstraction for JITStub calls from JITed code.
+
+ Added a JITStubCall class that automatically handles things like assigning
+ arguments to different stack slots and storing return values. Deployed
+ the class in about a billion places. A bunch more places remain to be
+ fixed up, but this is a good stopping point for now.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::emitTimeoutCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ (JSC::JIT::JSRInfo::JSRInfo):
+ (JSC::JITStubCall::JITStubCall):
+ (JSC::JITStubCall::addArgument):
+ (JSC::JITStubCall::call):
+ (JSC::JITStubCall::):
+ (JSC::CallEvalJITStub::CallEvalJITStub):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_lshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_jnless):
+ (JSC::JIT::compileFastArithSlow_op_bitand):
+ (JSC::JIT::compileFastArithSlow_op_mod):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArithSlow_op_post_inc):
+ (JSC::JIT::compileFastArithSlow_op_post_dec):
+ (JSC::JIT::compileFastArithSlow_op_pre_inc):
+ (JSC::JIT::compileFastArithSlow_op_pre_dec):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::compileFastArithSlow_op_add):
+ (JSC::JIT::compileFastArithSlow_op_mul):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+
+2009-05-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add a new opcode jnlesseq, and optimize its compilation in the JIT using
+ techniques similar to what were used to optimize jnless in r43363.
+
+ This gives a 0.7% speedup on SunSpider, particularly on the tests 3d-cube,
+ control-flow-recursive, date-format-xparb, and string-base64.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Add support for dumping op_jnlesseq.
+ * bytecode/Opcode.h: Add op_jnlesseq to the list of opcodes.
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitJumpIfFalse): Add a peephole optimization
+ for op_jnlesseq when emitting lesseq followed by a jump.
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute): Add case for op_jnlesseq.
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass): Add case for op_jnlesseq.
+ (JSC::JIT::privateCompileSlowCases): Add case for op_jnlesseq.
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_jnlesseq): Added.
+ (JSC::JIT::compileFastArithSlow_op_jnlesseq): Added.
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_jlesseq): Added.
+ * jit/JITStubs.h:
+
+2009-05-08 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix test failures on 64-bit
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_jnless): Avoid accidentaly treating an
+ immediate int as an immediate float in the 64-bit value representation.
+
+2009-05-08 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Oliver Hunt.
+
+ Removing an empty constructor and an uncalled, empty function seems to be a
+ pretty solid 1% regeression on my machine, so I'm going to put them back.
+ Um. Yeah, this this pretty pointles and makes no sense at all. I officially
+ lose the will to live in 3... 2...
+
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingTool::notifyOfScope):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingTool::~SamplingTool):
+
+2009-05-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver "I see lots of ifdefs" Hunt.
+
+ Fix (kinda) for sampling tool breakage. The codeblock sampling tool has become
+ b0rked due to recent changes in native function calling. The initialization of
+ a ScopeNode appears to now occur before the sampling tool (or possibly the
+ interpreter has been brought into existence, wihich leads to crashyness).
+
+ This patch doesn't fix the problem. The crash occurs when tracking a Scope, but
+ we shouldn't need to track scopes when we're just sampling opcodes, not
+ codeblocks. Not retaining Scopes when just opcode sampling will reduce sampling
+ overhead reducing any instrumentation skew, which is a good thing. As a side
+ benefit this patch also gets the opcode sampling going again, albeit in a bit of
+ a lame way. Will come back later with a proper fix from codeblock sampling.
+
+ * JavaScriptCore.exp:
+ * bytecode/SamplingTool.cpp:
+ (JSC::compareLineCountInfoSampling):
+ (JSC::SamplingTool::dump):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingTool::SamplingTool):
+ * parser/Nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+
+2009-05-07 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
+ Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
+
+ Roll out r43366 as it removed symbols that Safari 4 Beta uses.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingThread::start):
+ (JSC::SamplingThread::stop):
+ * bytecode/SamplingTool.h:
+ * wtf/CrossThreadRefCounted.h:
+ (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
+ (WTF::::ref):
+ (WTF::::deref):
+ * wtf/Threading.h:
+ * wtf/ThreadingNone.cpp:
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::identifierByPthreadHandle):
+ (WTF::establishIdentifierForPthreadHandle):
+ (WTF::pthreadHandleForIdentifier):
+ (WTF::clearPthreadHandleForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+ * wtf/ThreadingWin.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::storeThreadHandleByIdentifier):
+ (WTF::threadHandleForIdentifier):
+ (WTF::clearThreadHandleForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+ * wtf/gtk/ThreadingGtk.cpp:
+ (WTF::threadMapMutex):
+ (WTF::initializeThreading):
+ (WTF::threadMap):
+ (WTF::identifierByGthreadHandle):
+ (WTF::establishIdentifierForThread):
+ (WTF::threadForIdentifier):
+ (WTF::clearThreadForIdentifier):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+ * wtf/qt/ThreadingQt.cpp:
+ (WTF::threadMapMutex):
+ (WTF::threadMap):
+ (WTF::identifierByQthreadHandle):
+ (WTF::establishIdentifierForThread):
+ (WTF::clearThreadForIdentifier):
+ (WTF::threadForIdentifier):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+2009-05-07 Gustavo Noronha Silva <gns@gnome.org>
+
+ Suggested by Oliver Hunt.
+
+ Also check for Linux for the special-cased calling convention.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * wtf/Platform.h:
+
+2009-05-07 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Previously, when appending to an existing string and growing the underlying buffer,
+ we would actually allocate 110% of the required size in order to give us some space
+ to expand into. Now we treat strings differently based on their size:
+
+ Small Strings (up to 4 pages):
+ Expand the allocation size to 112.5% of the amount requested. This is largely sicking
+ to our previous policy, however 112.5% is cheaper to calculate.
+
+ Medium Strings (up to 128 pages):
+ For pages covering multiple pages over-allocation is less of a concern - any unused
+ space will not be paged in if it is not used, so this is purely a VM overhead. For
+ these strings allocate 2x the requested size.
+
+ Large Strings (to infinity and beyond!):
+ Revert to our 112.5% policy - probably best to limit the amount of unused VM we allow
+ any individual string be responsible for.
+
+ Additionally, round small allocations up to a multiple of 16 bytes, and medium and
+ large allocations up to a multiple of page size.
+
+ ~1.5% progression on Sunspider, due to 5% improvement on tagcloud & 15% on validate.
+
+ * runtime/UString.cpp:
+ (JSC::expandedSize):
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed a minor sequencing error introduced by recent Parser speedups.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::createNativeThunk): Missed a spot in my last patch.
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ * wtf/Platform.h: Reverted an accidental (and performance-catastrophic)
+ change.
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed a minor sequencing error introduced by recent Parser speedups.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::reparseInPlace): Missed a spot in my last patch.
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed a minor sequencing error introduced by recent Parser speedups.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::parse):
+ * parser/Parser.h:
+ (JSC::Parser::parse):
+ (JSC::Parser::reparse): Shrink the parsedObjects vector after allocating
+ the root node, to avoid leaving a stray node in the vector, since that's
+ a slight memory leak, and it causes problems during JSGlobalData teardown.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::~JSGlobalData): ASSERT that we're not being torn
+ down while we think we're still parsing, since that would cause lots of
+ bad memory references during our destruction.
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Replaced two more macros with references to the JITStackFrame structure.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ * jit/JITStubs.cpp:
+ (JSC::):
+ * jit/JITStubs.h:
+
+2009-05-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve native call performance
+
+ Fix the windows build by adding calling convention declarations everywhere,
+ chose fastcall as that seemed most sensible given we were having to declare
+ the convention explicitly. In addition switched to fastcall on mac in the
+ deluded belief that documented fastcall behavior on windows would match
+ actual its actual behavior.
+
+ * API/JSCallbackFunction.h:
+ * API/JSCallbackObject.h:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::argumentCount):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jsc.cpp:
+ (functionPrint):
+ (functionDebug):
+ (functionGC):
+ (functionVersion):
+ (functionRun):
+ (functionLoad):
+ (functionSetSamplingFlags):
+ (functionClearSamplingFlags):
+ (functionReadline):
+ (functionQuit):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::callArrayConstructor):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin):
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncReverse):
+ (JSC::arrayProtoFuncShift):
+ (JSC::arrayProtoFuncSlice):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncSplice):
+ (JSC::arrayProtoFuncUnShift):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncReduce):
+ (JSC::arrayProtoFuncReduceRight):
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::callBooleanConstructor):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncToString):
+ (JSC::booleanProtoFuncValueOf):
+ * runtime/CallData.h:
+ * runtime/DateConstructor.cpp:
+ (JSC::callDate):
+ (JSC::dateParse):
+ (JSC::dateNow):
+ (JSC::dateUTC):
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncToString):
+ (JSC::dateProtoFuncToUTCString):
+ (JSC::dateProtoFuncToDateString):
+ (JSC::dateProtoFuncToTimeString):
+ (JSC::dateProtoFuncToLocaleString):
+ (JSC::dateProtoFuncToLocaleDateString):
+ (JSC::dateProtoFuncToLocaleTimeString):
+ (JSC::dateProtoFuncGetTime):
+ (JSC::dateProtoFuncGetFullYear):
+ (JSC::dateProtoFuncGetUTCFullYear):
+ (JSC::dateProtoFuncToGMTString):
+ (JSC::dateProtoFuncGetMonth):
+ (JSC::dateProtoFuncGetUTCMonth):
+ (JSC::dateProtoFuncGetDate):
+ (JSC::dateProtoFuncGetUTCDate):
+ (JSC::dateProtoFuncGetDay):
+ (JSC::dateProtoFuncGetUTCDay):
+ (JSC::dateProtoFuncGetHours):
+ (JSC::dateProtoFuncGetUTCHours):
+ (JSC::dateProtoFuncGetMinutes):
+ (JSC::dateProtoFuncGetUTCMinutes):
+ (JSC::dateProtoFuncGetSeconds):
+ (JSC::dateProtoFuncGetUTCSeconds):
+ (JSC::dateProtoFuncGetMilliSeconds):
+ (JSC::dateProtoFuncGetUTCMilliseconds):
+ (JSC::dateProtoFuncGetTimezoneOffset):
+ (JSC::dateProtoFuncSetTime):
+ (JSC::dateProtoFuncSetMilliSeconds):
+ (JSC::dateProtoFuncSetUTCMilliseconds):
+ (JSC::dateProtoFuncSetSeconds):
+ (JSC::dateProtoFuncSetUTCSeconds):
+ (JSC::dateProtoFuncSetMinutes):
+ (JSC::dateProtoFuncSetUTCMinutes):
+ (JSC::dateProtoFuncSetHours):
+ (JSC::dateProtoFuncSetUTCHours):
+ (JSC::dateProtoFuncSetDate):
+ (JSC::dateProtoFuncSetUTCDate):
+ (JSC::dateProtoFuncSetMonth):
+ (JSC::dateProtoFuncSetUTCMonth):
+ (JSC::dateProtoFuncSetFullYear):
+ (JSC::dateProtoFuncSetUTCFullYear):
+ (JSC::dateProtoFuncSetYear):
+ (JSC::dateProtoFuncGetYear):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::callErrorConstructor):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::errorProtoFuncToString):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::callFunctionConstructor):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::callFunctionPrototype):
+ (JSC::functionProtoFuncToString):
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::nativeFunction):
+ (JSC::JSFunction::setScopeChain):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ (JSC::globalFuncParseInt):
+ (JSC::globalFuncParseFloat):
+ (JSC::globalFuncIsNaN):
+ (JSC::globalFuncIsFinite):
+ (JSC::globalFuncDecodeURI):
+ (JSC::globalFuncDecodeURIComponent):
+ (JSC::globalFuncEncodeURI):
+ (JSC::globalFuncEncodeURIComponent):
+ (JSC::globalFuncEscape):
+ (JSC::globalFuncUnescape):
+ (JSC::globalFuncJSCPrint):
+ * runtime/JSGlobalObjectFunctions.h:
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncAbs):
+ (JSC::mathProtoFuncACos):
+ (JSC::mathProtoFuncASin):
+ (JSC::mathProtoFuncATan):
+ (JSC::mathProtoFuncATan2):
+ (JSC::mathProtoFuncCeil):
+ (JSC::mathProtoFuncCos):
+ (JSC::mathProtoFuncExp):
+ (JSC::mathProtoFuncFloor):
+ (JSC::mathProtoFuncLog):
+ (JSC::mathProtoFuncMax):
+ (JSC::mathProtoFuncMin):
+ (JSC::mathProtoFuncPow):
+ (JSC::mathProtoFuncRandom):
+ (JSC::mathProtoFuncRound):
+ (JSC::mathProtoFuncSin):
+ (JSC::mathProtoFuncSqrt):
+ (JSC::mathProtoFuncTan):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::callNativeErrorConstructor):
+ * runtime/NativeFunctionWrapper.h:
+ * runtime/NumberConstructor.cpp:
+ (JSC::callNumberConstructor):
+ * runtime/NumberPrototype.cpp:
+ (JSC::numberProtoFuncToString):
+ (JSC::numberProtoFuncToLocaleString):
+ (JSC::numberProtoFuncValueOf):
+ (JSC::numberProtoFuncToFixed):
+ (JSC::numberProtoFuncToExponential):
+ (JSC::numberProtoFuncToPrecision):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::callObjectConstructor):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncValueOf):
+ (JSC::objectProtoFuncHasOwnProperty):
+ (JSC::objectProtoFuncIsPrototypeOf):
+ (JSC::objectProtoFuncDefineGetter):
+ (JSC::objectProtoFuncDefineSetter):
+ (JSC::objectProtoFuncLookupGetter):
+ (JSC::objectProtoFuncLookupSetter):
+ (JSC::objectProtoFuncPropertyIsEnumerable):
+ (JSC::objectProtoFuncToLocaleString):
+ (JSC::objectProtoFuncToString):
+ * runtime/ObjectPrototype.h:
+ * runtime/RegExpConstructor.cpp:
+ (JSC::callRegExpConstructor):
+ * runtime/RegExpObject.cpp:
+ (JSC::callRegExpObject):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncTest):
+ (JSC::regExpProtoFuncExec):
+ (JSC::regExpProtoFuncCompile):
+ (JSC::regExpProtoFuncToString):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCode):
+ (JSC::callStringConstructor):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncToString):
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncIndexOf):
+ (JSC::stringProtoFuncLastIndexOf):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ (JSC::stringProtoFuncSlice):
+ (JSC::stringProtoFuncSplit):
+ (JSC::stringProtoFuncSubstr):
+ (JSC::stringProtoFuncSubstring):
+ (JSC::stringProtoFuncToLowerCase):
+ (JSC::stringProtoFuncToUpperCase):
+ (JSC::stringProtoFuncLocaleCompare):
+ (JSC::stringProtoFuncBig):
+ (JSC::stringProtoFuncSmall):
+ (JSC::stringProtoFuncBlink):
+ (JSC::stringProtoFuncBold):
+ (JSC::stringProtoFuncFixed):
+ (JSC::stringProtoFuncItalics):
+ (JSC::stringProtoFuncStrike):
+ (JSC::stringProtoFuncSub):
+ (JSC::stringProtoFuncSup):
+ (JSC::stringProtoFuncFontcolor):
+ (JSC::stringProtoFuncFontsize):
+ (JSC::stringProtoFuncAnchor):
+ (JSC::stringProtoFuncLink):
+ * wtf/Platform.h:
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Rolled out a portion of r43352 because it broke 64bit.
+
+ * jit/JITStubs.h:
+
+2009-05-07 Kevin Ollivier <kevino@theolliviers.com>
+
+ Build fix for functions reaturning ThreadIdentifier.
+
+ * wtf/ThreadingNone.cpp:
+ (WTF::createThreadInternal):
+ (WTF::currentThread):
+
+2009-05-07 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by John Honeycutt.
+
+ - enable optimization case im the last patch that I accidentally had disabled.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_jnless):
+
+2009-05-07 Dmitry Titov <dimich@chromium.org>
+
+ Attempt to fix Win build.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_jnless):
+
+2009-05-07 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov and Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25348
+ Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
+
+ * wtf/Threading.h:
+ (WTF::ThreadIdentifier::ThreadIdentifier):
+ (WTF::ThreadIdentifier::isValid):
+ (WTF::ThreadIdentifier::invalidate):
+ (WTF::ThreadIdentifier::platformId):
+ ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
+ methods that are used across the code on thread ids: construction, comparisons,
+ check for 'valid' state etc. '0' is used as invalid id, which happens to just work
+ with all platform-specific thread id implementations.
+
+ All the following files repeatedly reflect the new ThreadIdentifier for each platform.
+ We remove ThreadMap and threadMapMutex from all of them, remove the functions that
+ populated/searched/cleared the map and add platform-specific comparison operators
+ for ThreadIdentifier.
+
+ * wtf/gtk/ThreadingGtk.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+ * wtf/ThreadingNone.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::detachThread):
+ (WTF::currentThread):
+
+ * wtf/qt/ThreadingQt.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal):
+ (WTF::waitForThreadCompletion):
+ (WTF::currentThread):
+
+ * wtf/ThreadingWin.cpp:
+ (WTF::ThreadIdentifier::operator==):
+ (WTF::ThreadIdentifier::operator!=):
+ (WTF::initializeThreading):
+ (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
+ counter as a thread ID and mapped it into platform ID. Windows was using native thread
+ id and mapped it into thread handle. Since we can always obtain a thread handle
+ by thread id, createThread now closes the handle.
+ (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
+ it means the thread already exited.
+ (WTF::detachThread):
+ (WTF::currentThread):
+ (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
+ (WTF::waitForThreadCompletionDeprecated): same.
+ (WTF::currentThreadDeprecated): same.
+ (WTF::createThreadDeprecated): same.
+
+ * bytecode/SamplingTool.h:
+ * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
+
+ * JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names
+ since they now take a different type as a parameter.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
+ that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
+
+2009-05-07 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - optimize various cases of branch-fused less
+
+ 1% speedup on SunSpider overall
+ 13% speedup on math-cordic
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ op_loop_if_less: Optimize case of constant as first operand, just as case of constant as
+ second operand.
+ op_jnless: Factored out into compileFastArith_op_jnless.
+ (JSC::JIT::privateCompileSlowCases):
+ op_jnless: Factored out into compileFastArithSlow_op_jnless.
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_jnless): Factored out from main compile loop.
+ - Generate inline code for comparison of constant immediate int as first operand to another
+ immediate int, as for loop_if_less
+
+ (JSC::JIT::compileFastArithSlow_op_jnless):
+ - Generate inline code for comparing two floating point numbers.
+ - Generate code for both cases of comparing a floating point number to a constant immediate
+ int.
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Fix dumping of op_jnless (tangentially related bugfix).
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Added the return address of a stub function to the JITStackFrame abstraction.
+
+ * jit/JIT.cpp:
+ * jit/JIT.h:
+ * jit/JITStubs.cpp:
+ (JSC::):
+ (JSC::StackHack::StackHack):
+ (JSC::StackHack::~StackHack):
+ (JSC::returnToThrowTrampoline):
+ (JSC::JITStubs::cti_op_convert_this):
+ (JSC::JITStubs::cti_op_end):
+ (JSC::JITStubs::cti_op_add):
+ (JSC::JITStubs::cti_op_pre_inc):
+ (JSC::JITStubs::cti_timeout_check):
+ (JSC::JITStubs::cti_register_file_check):
+ (JSC::JITStubs::cti_op_loop_if_less):
+ (JSC::JITStubs::cti_op_loop_if_lesseq):
+ (JSC::JITStubs::cti_op_new_object):
+ (JSC::JITStubs::cti_op_put_by_id_generic):
+ (JSC::JITStubs::cti_op_get_by_id_generic):
+ (JSC::JITStubs::cti_op_put_by_id):
+ (JSC::JITStubs::cti_op_put_by_id_second):
+ (JSC::JITStubs::cti_op_put_by_id_fail):
+ (JSC::JITStubs::cti_op_get_by_id):
+ (JSC::JITStubs::cti_op_get_by_id_second):
+ (JSC::JITStubs::cti_op_get_by_id_self_fail):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
+ (JSC::JITStubs::cti_op_get_by_id_proto_fail):
+ (JSC::JITStubs::cti_op_get_by_id_array_fail):
+ (JSC::JITStubs::cti_op_get_by_id_string_fail):
+ (JSC::JITStubs::cti_op_instanceof):
+ (JSC::JITStubs::cti_op_del_by_id):
+ (JSC::JITStubs::cti_op_mul):
+ (JSC::JITStubs::cti_op_new_func):
+ (JSC::JITStubs::cti_op_call_JSFunction):
+ (JSC::JITStubs::cti_op_call_arityCheck):
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_vm_lazyLinkCall):
+ (JSC::JITStubs::cti_op_push_activation):
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_create_arguments):
+ (JSC::JITStubs::cti_op_create_arguments_no_params):
+ (JSC::JITStubs::cti_op_tear_off_activation):
+ (JSC::JITStubs::cti_op_tear_off_arguments):
+ (JSC::JITStubs::cti_op_profile_will_call):
+ (JSC::JITStubs::cti_op_profile_did_call):
+ (JSC::JITStubs::cti_op_ret_scopeChain):
+ (JSC::JITStubs::cti_op_new_array):
+ (JSC::JITStubs::cti_op_resolve):
+ (JSC::JITStubs::cti_op_construct_JSConstruct):
+ (JSC::JITStubs::cti_op_construct_NotJSConstruct):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_string):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_sub):
+ (JSC::JITStubs::cti_op_put_by_val):
+ (JSC::JITStubs::cti_op_put_by_val_array):
+ (JSC::JITStubs::cti_op_put_by_val_byte_array):
+ (JSC::JITStubs::cti_op_lesseq):
+ (JSC::JITStubs::cti_op_loop_if_true):
+ (JSC::JITStubs::cti_op_load_varargs):
+ (JSC::JITStubs::cti_op_negate):
+ (JSC::JITStubs::cti_op_resolve_base):
+ (JSC::JITStubs::cti_op_resolve_skip):
+ (JSC::JITStubs::cti_op_resolve_global):
+ (JSC::JITStubs::cti_op_div):
+ (JSC::JITStubs::cti_op_pre_dec):
+ (JSC::JITStubs::cti_op_jless):
+ (JSC::JITStubs::cti_op_not):
+ (JSC::JITStubs::cti_op_jtrue):
+ (JSC::JITStubs::cti_op_post_inc):
+ (JSC::JITStubs::cti_op_eq):
+ (JSC::JITStubs::cti_op_lshift):
+ (JSC::JITStubs::cti_op_bitand):
+ (JSC::JITStubs::cti_op_rshift):
+ (JSC::JITStubs::cti_op_bitnot):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+ (JSC::JITStubs::cti_op_new_func_exp):
+ (JSC::JITStubs::cti_op_mod):
+ (JSC::JITStubs::cti_op_less):
+ (JSC::JITStubs::cti_op_neq):
+ (JSC::JITStubs::cti_op_post_dec):
+ (JSC::JITStubs::cti_op_urshift):
+ (JSC::JITStubs::cti_op_bitxor):
+ (JSC::JITStubs::cti_op_new_regexp):
+ (JSC::JITStubs::cti_op_bitor):
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_op_throw):
+ (JSC::JITStubs::cti_op_get_pnames):
+ (JSC::JITStubs::cti_op_next_pname):
+ (JSC::JITStubs::cti_op_push_scope):
+ (JSC::JITStubs::cti_op_pop_scope):
+ (JSC::JITStubs::cti_op_typeof):
+ (JSC::JITStubs::cti_op_is_undefined):
+ (JSC::JITStubs::cti_op_is_boolean):
+ (JSC::JITStubs::cti_op_is_number):
+ (JSC::JITStubs::cti_op_is_string):
+ (JSC::JITStubs::cti_op_is_object):
+ (JSC::JITStubs::cti_op_is_function):
+ (JSC::JITStubs::cti_op_stricteq):
+ (JSC::JITStubs::cti_op_to_primitive):
+ (JSC::JITStubs::cti_op_strcat):
+ (JSC::JITStubs::cti_op_nstricteq):
+ (JSC::JITStubs::cti_op_to_jsnumber):
+ (JSC::JITStubs::cti_op_in):
+ (JSC::JITStubs::cti_op_push_new_scope):
+ (JSC::JITStubs::cti_op_jmp_scopes):
+ (JSC::JITStubs::cti_op_put_by_index):
+ (JSC::JITStubs::cti_op_switch_imm):
+ (JSC::JITStubs::cti_op_switch_char):
+ (JSC::JITStubs::cti_op_switch_string):
+ (JSC::JITStubs::cti_op_del_by_val):
+ (JSC::JITStubs::cti_op_put_getter):
+ (JSC::JITStubs::cti_op_put_setter):
+ (JSC::JITStubs::cti_op_new_error):
+ (JSC::JITStubs::cti_op_debug):
+ (JSC::JITStubs::cti_vm_throw):
+ * jit/JITStubs.h:
+ (JSC::JITStackFrame::returnAddressSlot):
+
+2009-05-07 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::lex): Fix missing braces. This would make us always
+ take the slower case for string parsing and Visual Studio correctly
+ noticed unreachable code.
+
+2009-05-07 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 25589: goto instead of state machine in lexer
+ https://bugs.webkit.org/show_bug.cgi?id=25589
+
+ SunSpider is 0.8% faster.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::currentCharacter): Added.
+ (JSC::Lexer::currentOffset): Changed to call currentCharacter for clarity.
+ (JSC::Lexer::setCode): Removed code to set now-obsolete m_skipLineEnd.
+ (JSC::Lexer::shiftLineTerminator): Added. Handles line numbers and the
+ two-character line terminators.
+ (JSC::Lexer::makeIdentifier): Changed to take characters and length rather
+ than a vector, since we now make these directly out of the source buffer
+ when possible.
+ (JSC::Lexer::lastTokenWasRestrKeyword): Added.
+ (JSC::isNonASCIIIdentStart): Broke out the non-inline part.
+ (JSC::isIdentStart): Moved here.
+ (JSC::isNonASCIIIdentPart): Broke out the non-inline part.
+ (JSC::isIdentPart): Moved here.
+ (JSC::singleEscape): Moved here, and removed some unneeded cases.
+ (JSC::Lexer::record8): Moved here.
+ (JSC::Lexer::record16): Moved here.
+ (JSC::Lexer::lex): Rewrote this whole function to use goto and not use
+ a state machine. Got rid of most of the local variables. Also rolled the
+ matchPunctuator function in here.
+ (JSC::Lexer::scanRegExp): Changed to use the new version of isLineTerminator.
+ Clear m_buffer16 after using it instead of before.
+
+ * parser/Lexer.h: Removed State enum, setDone function, nextLine function,
+ lookupKeywordFunction, one of the isLineTerminator functions, m_done data member,
+ m_skipLineEnd data member, and m_state data member. Added shiftLineTerminator
+ function, currentCharacter function, and changed the arguments to the makeIdentifier
+ function. Removed one branch from the isLineTerminator function.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace): Streamlined the case where we don't replace anything.
+
+2009-05-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Removed a few more special constants, and replaced them with uses of
+ the JITStackFrame struct.
+
+ Removed one of the two possible definitions of VoidPtrPair. The Mac
+ definition was more elegant, but SunSpider doesn't think it's any
+ faster, and it's net less elegant to have two ways of doing things.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ * jit/JITStubs.h:
+ (JSC::):
+
+2009-05-07 Darin Adler <darin@apple.com>
+
+ * runtime/ScopeChain.h:
+ (JSC::ScopeChainNode::~ScopeChainNode): Tweak formatting.
+
+2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix the build thread stack base determination build on Symbian,
+ by moving the code block before PLATFORM(UNIX), which is also
+ enabled on Symbian builds.
+
+ * runtime/Collector.cpp:
+ (JSC::currentThreadStackBase):
+
+2009-05-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix crash due to incorrectly using an invalid scopechain
+
+ stringProtoFuncReplace was checking for an exception on a CachedCall
+ by asking for the cached callframes exception. Unfortunately this
+ could crash in certain circumstances as CachedCall does not guarantee
+ a valid callframe following a call. Even more unfortunately the check
+ was entirely unnecessary as there is only a single exception slot per
+ global data, so it was already checked via the initial exec->hadException()
+ check.
+
+ To make bugs like this more obvious, i've added a debug only destructor
+ to ScopeChainNode that 0's all of its fields. This exposed a crash in
+ the standard javascriptcore tests.
+
+ * runtime/ScopeChain.h:
+ (JSC::ScopeChainNode::~ScopeChainNode):
+ (JSC::ScopeChain::~ScopeChain):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+
+2009-05-07 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Enable op_strcat across += assignments. This patch allows the lhs of a read/modify node
+ to be included within the concatenation operation, and also modifies the implementation
+ of the concatenation to attempt to reuse and cat onto the leftmost string, rather than
+ always allocating a new empty output string to copy into (as was previously the behaviour).
+
+ ~0.5% progression, due to a 3%-3.5% progression on the string tests (particularly validate).
+
+ * parser/Nodes.cpp:
+ (JSC::BinaryOpNode::emitStrcat):
+ (JSC::emitReadModifyAssignment):
+ (JSC::ReadModifyResolveNode::emitBytecode):
+ (JSC::ReadModifyDotNode::emitBytecode):
+ (JSC::ReadModifyBracketNode::emitBytecode):
+ * parser/Nodes.h:
+ * runtime/Operations.h:
+ (JSC::concatenateStrings):
+ * runtime/UString.cpp:
+ (JSC::UString::reserveCapacity):
+ * runtime/UString.h:
+
+2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix the build on Windows without JIT: interpreter/RegisterFile.h needs
+ roundUpAllocationSize, which is protected by #if ENABLED(ASSEMBLER).
+ Moved the #ifdef down and always offer the function.
+
+ * jit/ExecutableAllocator.h:
+
+2009-05-06 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin "++" Barraclough.
+
+ Added some abstraction around the JIT stub calling convention by creating
+ a struct to represent the persistent stack frame JIT code shares with
+ JIT stubs.
+
+ SunSpider reports no change.
+
+ * jit/JIT.h:
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_convert_this):
+ (JSC::JITStubs::cti_op_end):
+ (JSC::JITStubs::cti_op_add):
+ (JSC::JITStubs::cti_op_pre_inc):
+ (JSC::JITStubs::cti_timeout_check):
+ (JSC::JITStubs::cti_register_file_check):
+ (JSC::JITStubs::cti_op_loop_if_less):
+ (JSC::JITStubs::cti_op_loop_if_lesseq):
+ (JSC::JITStubs::cti_op_new_object):
+ (JSC::JITStubs::cti_op_put_by_id_generic):
+ (JSC::JITStubs::cti_op_get_by_id_generic):
+ (JSC::JITStubs::cti_op_put_by_id):
+ (JSC::JITStubs::cti_op_put_by_id_second):
+ (JSC::JITStubs::cti_op_put_by_id_fail):
+ (JSC::JITStubs::cti_op_get_by_id):
+ (JSC::JITStubs::cti_op_get_by_id_second):
+ (JSC::JITStubs::cti_op_get_by_id_self_fail):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
+ (JSC::JITStubs::cti_op_get_by_id_proto_fail):
+ (JSC::JITStubs::cti_op_get_by_id_array_fail):
+ (JSC::JITStubs::cti_op_get_by_id_string_fail):
+ (JSC::JITStubs::cti_op_instanceof):
+ (JSC::JITStubs::cti_op_del_by_id):
+ (JSC::JITStubs::cti_op_mul):
+ (JSC::JITStubs::cti_op_new_func):
+ (JSC::JITStubs::cti_op_call_JSFunction):
+ (JSC::JITStubs::cti_op_call_arityCheck):
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_vm_lazyLinkCall):
+ (JSC::JITStubs::cti_op_push_activation):
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_create_arguments):
+ (JSC::JITStubs::cti_op_create_arguments_no_params):
+ (JSC::JITStubs::cti_op_tear_off_activation):
+ (JSC::JITStubs::cti_op_tear_off_arguments):
+ (JSC::JITStubs::cti_op_profile_will_call):
+ (JSC::JITStubs::cti_op_profile_did_call):
+ (JSC::JITStubs::cti_op_ret_scopeChain):
+ (JSC::JITStubs::cti_op_new_array):
+ (JSC::JITStubs::cti_op_resolve):
+ (JSC::JITStubs::cti_op_construct_JSConstruct):
+ (JSC::JITStubs::cti_op_construct_NotJSConstruct):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_string):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_sub):
+ (JSC::JITStubs::cti_op_put_by_val):
+ (JSC::JITStubs::cti_op_put_by_val_array):
+ (JSC::JITStubs::cti_op_put_by_val_byte_array):
+ (JSC::JITStubs::cti_op_lesseq):
+ (JSC::JITStubs::cti_op_loop_if_true):
+ (JSC::JITStubs::cti_op_load_varargs):
+ (JSC::JITStubs::cti_op_negate):
+ (JSC::JITStubs::cti_op_resolve_base):
+ (JSC::JITStubs::cti_op_resolve_skip):
+ (JSC::JITStubs::cti_op_resolve_global):
+ (JSC::JITStubs::cti_op_div):
+ (JSC::JITStubs::cti_op_pre_dec):
+ (JSC::JITStubs::cti_op_jless):
+ (JSC::JITStubs::cti_op_not):
+ (JSC::JITStubs::cti_op_jtrue):
+ (JSC::JITStubs::cti_op_post_inc):
+ (JSC::JITStubs::cti_op_eq):
+ (JSC::JITStubs::cti_op_lshift):
+ (JSC::JITStubs::cti_op_bitand):
+ (JSC::JITStubs::cti_op_rshift):
+ (JSC::JITStubs::cti_op_bitnot):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+ (JSC::JITStubs::cti_op_new_func_exp):
+ (JSC::JITStubs::cti_op_mod):
+ (JSC::JITStubs::cti_op_less):
+ (JSC::JITStubs::cti_op_neq):
+ (JSC::JITStubs::cti_op_post_dec):
+ (JSC::JITStubs::cti_op_urshift):
+ (JSC::JITStubs::cti_op_bitxor):
+ (JSC::JITStubs::cti_op_new_regexp):
+ (JSC::JITStubs::cti_op_bitor):
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_op_throw):
+ (JSC::JITStubs::cti_op_get_pnames):
+ (JSC::JITStubs::cti_op_next_pname):
+ (JSC::JITStubs::cti_op_push_scope):
+ (JSC::JITStubs::cti_op_pop_scope):
+ (JSC::JITStubs::cti_op_typeof):
+ (JSC::JITStubs::cti_op_is_undefined):
+ (JSC::JITStubs::cti_op_is_boolean):
+ (JSC::JITStubs::cti_op_is_number):
+ (JSC::JITStubs::cti_op_is_string):
+ (JSC::JITStubs::cti_op_is_object):
+ (JSC::JITStubs::cti_op_is_function):
+ (JSC::JITStubs::cti_op_stricteq):
+ (JSC::JITStubs::cti_op_to_primitive):
+ (JSC::JITStubs::cti_op_strcat):
+ (JSC::JITStubs::cti_op_nstricteq):
+ (JSC::JITStubs::cti_op_to_jsnumber):
+ (JSC::JITStubs::cti_op_in):
+ (JSC::JITStubs::cti_op_push_new_scope):
+ (JSC::JITStubs::cti_op_jmp_scopes):
+ (JSC::JITStubs::cti_op_put_by_index):
+ (JSC::JITStubs::cti_op_switch_imm):
+ (JSC::JITStubs::cti_op_switch_char):
+ (JSC::JITStubs::cti_op_switch_string):
+ (JSC::JITStubs::cti_op_del_by_val):
+ (JSC::JITStubs::cti_op_put_getter):
+ (JSC::JITStubs::cti_op_put_setter):
+ (JSC::JITStubs::cti_op_new_error):
+ (JSC::JITStubs::cti_op_debug):
+ (JSC::JITStubs::cti_vm_throw):
+ * jit/JITStubs.h:
+ (JSC::):
+
+2009-05-06 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak & Darin Adler.
+
+ Improve string concatenation (as coded in JS as a sequence of adds).
+
+ Detect patterns corresponding to string concatenation, and change the bytecode
+ generation to emit a new op_strcat instruction. By handling the full set of
+ additions within a single function we do not need allocate JSString wrappers
+ for intermediate results, and we can calculate the size of the output string
+ prior to allocating storage, in order to prevent reallocation of the buffer.
+
+ 1.5%-2% progression on Sunspider, largely due to a 30% progression on date-format-xparb.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ Add new opcodes.
+ * bytecode/Opcode.h:
+ Add new opcodes.
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitStrcat):
+ (JSC::BytecodeGenerator::emitToPrimitive):
+ Add generation of new opcodes.
+ * bytecompiler/BytecodeGenerator.h:
+ Add generation of new opcodes.
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ Add implmentation of new opcodes.
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ Add implmentation of new opcodes.
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_to_primitive):
+ (JSC::JITStubs::cti_op_strcat):
+ Add implmentation of new opcodes.
+ * jit/JITStubs.h:
+ Add implmentation of new opcodes.
+ * parser/Nodes.cpp:
+ (JSC::BinaryOpNode::emitStrcat):
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::ReadModifyResolveNode::emitBytecode):
+ Add generation of new opcodes.
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::):
+ (JSC::AddNode::):
+ Add methods to allow identification of add nodes.
+ * parser/ResultType.h:
+ (JSC::ResultType::definitelyIsString):
+ (JSC::ResultType::forAdd):
+ Fix error in detection of adds that will produce string results.
+ * runtime/Operations.h:
+ (JSC::concatenateStrings):
+ Add implmentation of new opcodes.
+ * runtime/UString.cpp:
+ (JSC::UString::appendNumeric):
+ Add methods to append numbers to an existing string.
+ * runtime/UString.h:
+ (JSC::UString::Rep::createEmptyBuffer):
+ (JSC::UString::BaseString::BaseString):
+ Add support for creating an empty string with a non-zero capacity available in the BaseString.
+
+2009-05-06 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Made RefCounted::m_refCount private.
+
+ * runtime/Structure.h: Removed addressOfCount.
+ * wtf/RefCounted.h: Made m_refCount private.
+ Added addressOfCount.
+
+2009-05-06 Darin Adler <darin@apple.com>
+
+ Fixed assertion seen a lot!
+
+ * parser/Nodes.cpp:
+ (JSC::FunctionBodyNode::~FunctionBodyNode): Removed now-bogus assertion.
+
+2009-05-06 Darin Adler <darin@apple.com>
+
+ Working with Sam Weinig.
+
+ Redo parse tree constructor optimization without breaking the Windows
+ build the way I did yesterday. The previous try broke the build by adding
+ an include of Lexer.h and all its dependencies that had to work outside
+ the JavaScriptCore project.
+
+ * GNUmakefile.am: Added NodeConstructors.h.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+ Removed byteocde directory -- we no longer are trying to include Lexer.h
+ outside JavaScriptCore.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Change SegmentedVector.h
+ and Lexer.h back to internal files. Added NodeConstructors.h.
+
+ * parser/Grammar.y: Added include of NodeConstructors.h.
+ Changed use of ConstDeclNode to use public functions.
+
+ * parser/NodeConstructors.h: Copied from parser/Nodes.h.
+ Just contains the inlined constructors now.
+
+ * parser/Nodes.cpp: Added include of NodeConstructors.h.
+ Moved node constructors into the header.
+ (JSC::FunctionBodyNode::FunctionBodyNode): Removed m_refCount
+ initialization.
+
+ * parser/Nodes.h: Removed all the constructor definitions, and also
+ removed the JSC_FAST_CALL from them since these are all inlined, so the
+ calling convention is irrelevant. Made more things private. Used a data
+ member for operator opcodes instead of a virtual function. Removed the
+ special FunctionBodyNode::ref/deref functions since the default functions
+ are now just as fast.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::extractFunctionBody): Fixed types here so we don't typecast until
+ after we do type checking.
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ Fix the Qt build on Windows.
+
+ * JavaScriptCore.pri: Define BUILDING_JavaScriptCore/WTF to get the meaning
+ of the JS_EXPORTDATA macros correct
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ Enable the JIT for the Qt build on Windows.
+
+ * JavaScriptCore.pri:
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Tweak JavaScriptCore.pri for being able to override the generated sources dir for the
+ generated_files target.
+
+ * JavaScriptCore.pri:
+
+2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Build QtWebKit as a framework on Mac
+
+ This implies both debug and release build by default, unless
+ one of the --debug or --release config options are passed to
+ the build-webkit script.
+
+ Frameworks can be disabled by passing CONFIG+=webkit_no_framework
+ to the build-webkit script.
+
+ To be able to build both debug and release targets in parallel
+ we have to use separate output directories for the generated
+ sources, which is not optimal, but required to avoid race conditions.
+
+ An optimization would be to only require this spit-up on Mac.
+
+ * JavaScriptCore.pri:
+ * JavaScriptCore.pro:
+ * jsc.pro:
+
+2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
+
+ A couple of the generators left the bison output file in the source
+ tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
+ work well when building release and debug configurations in parallel.
+
+ * JavaScriptCore.pri:
+
+2009-05-05 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Simplified a bit of codegen.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-05-05 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Moved all the JIT stub related code into one place.
+
+ * jit/JIT.cpp:
+ * jit/JIT.h:
+ * jit/JITCode.h:
+ * jit/JITStubs.cpp:
+ (JSC::):
+ * jit/JITStubs.h:
+
+2009-05-05 Sam Weinig <sam@webkit.org>
+
+ Try to fix Windows build.
+
+ Move Node constructor to the .cpp file.
+
+ * parser/Nodes.cpp:
+ * parser/Nodes.h:
+
+2009-05-05 Darin Adler <darin@apple.com>
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+ Try to fix Mac build.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Made SegmentedVector.h private.
+
+2009-05-05 Darin Adler <darin@apple.com>
+
+ Try to fix Mac build.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Made Lexer.h private.
+
+2009-05-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 25569: make ParserRefCounted use conventional reference counting
+ https://bugs.webkit.org/show_bug.cgi?id=25569
+
+ SunSpider speedup of about 1.6%.
+
+ * JavaScriptCore.exp: Updated.
+
+ * parser/Nodes.cpp:
+ (JSC::NodeReleaser::releaseAllNodes): ALWAYS_INLINE.
+ (JSC::NodeReleaser::adopt): Ditto.
+ (JSC::ParserRefCounted::ParserRefCounted): Removed most of the code.
+ Add the object to a Vector<RefPtr> that gets cleared after parsing.
+ (JSC::ParserRefCounted::~ParserRefCounted): Removed most of the code.
+
+ * parser/Nodes.h: Made ParserRefCounted inherit from RefCounted and
+ made inline versions of the constructor and destructor. Made the
+ Node constructor inline.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::parse): Call globalData->parserObjects.shrink(0) after
+ parsing, where it used to call ParserRefCounted::deleteNewObjects.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Eliminated code to manage the
+ newParserObjects and parserObjectExtraRefCounts.
+ (JSC::JSGlobalData::~JSGlobalData): Ditto.
+
+ * runtime/JSGlobalData.h: Replaced the HashSet and HashCountedSet
+ with a Vector.
+
+ * wtf/PassRefPtr.h:
+ (WTF::PassRefPtr::~PassRefPtr): The most common thing to do with a
+ PassRefPtr in hot code is to pass it and then destroy it once it's
+ set to zero. Help the optimizer by telling it that's true.
+
+2009-05-05 Xan Lopez <xlopez@igalia.com> and Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Oliver Hunt.
+
+ Disable the NativeFunctionWrapper for all non-Mac ports for now,
+ as it is also crashing on Linux/x86.
+
+ * runtime/NativeFunctionWrapper.h:
+
+2009-05-05 Steve Falkenburg <sfalken@apple.com>
+
+ Fix build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Expose toThisObject for the DOM Window
+
+ * JavaScriptCore.exp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Make windows go again until i work out the
+ accursed calling convention).
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * jit/JIT.cpp:
+ * runtime/NativeFunctionWrapper.h:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Fix windows debug builds).
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Hopefully the last fix).
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Fix the build fix caused by a different build fix).
+
+ * parser/Nodes.cpp:
+ * parser/Nodes.h:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (No idea how my changes could have broken these).
+
+ * runtime/DatePrototype.cpp:
+ * runtime/RegExpObject.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Why should i expect msvc to list all the errors in a file?).
+
+ * parser/Nodes.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Fix warning, and another missing include).
+
+ * jit/JIT.cpp:
+ * parser/Nodes.h:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (More build fixes).
+
+ * runtime/ErrorPrototype.cpp:
+ * runtime/JSGlobalObject.cpp:
+ * runtime/NumberPrototype.cpp:
+ * runtime/ObjectPrototype.cpp:
+ * runtime/StringConstructor.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Will the fixes never end?).
+
+ * runtime/FunctionPrototype.h:
+ * runtime/Lookup.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (More build fixes).
+
+ * jit/JIT.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (More build fixing).
+
+ * runtime/CallData.h:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ * runtime/ArrayConstructor.cpp:
+ * runtime/BooleanPrototype.cpp:
+ * runtime/DateConstructor.cpp:
+ * runtime/Error.cpp:
+ * runtime/ObjectConstructor.cpp:
+ * runtime/RegExpPrototype.cpp:
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Buildfix).
+
+ Add missing file
+
+ * runtime/NativeFunctionWrapper.h: Copied from JavaScriptCore/jit/ExecutableAllocator.cpp.
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 25559: Improve native function call performance
+ <https://bugs.webkit.org/show_bug.cgi?id=25559>
+
+ In order to cache calls to native functions we now make the standard
+ prototype functions use a small assembly thunk that converts the JS
+ calling convention into the native calling convention. As this is
+ only beneficial in the JIT we use the NativeFunctionWrapper typedef
+ to alternate between PrototypeFunction and JSFunction to keep the
+ code sane. This change from PrototypeFunction to NativeFunctionWrapper
+ is the bulk of this patch.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::call):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::addPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::leaq_mr):
+ (JSC::X86Assembler::call_m):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::prepareForRepeatCall):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::JIT::compileCTIMachineTrampolines):
+ * jit/JITCall.cpp:
+ (JSC::JIT::linkCall):
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCall):
+ * jit/JITCode.h:
+ (JSC::JITCode::operator bool):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetFromCallFrameHeader):
+ (JSC::JIT::emitGetFromCallFrameHeader32):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::JITStubs):
+ (JSC::JITStubs::cti_op_call_JSFunction):
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_vm_lazyLinkCall):
+ (JSC::JITStubs::cti_op_construct_JSConstruct):
+ * jit/JITStubs.h:
+ (JSC::JITStubs::ctiNativeCallThunk):
+ * jsc.cpp:
+ (GlobalObject::GlobalObject):
+ * parser/Nodes.cpp:
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::createNativeThunk):
+ (JSC::FunctionBodyNode::generateJITCode):
+ * parser/Nodes.h:
+ (JSC::FunctionBodyNode::):
+ (JSC::FunctionBodyNode::generatedJITCode):
+ (JSC::FunctionBodyNode::jitCode):
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::createCallIdentifier):
+ * runtime/ArgList.h:
+ * runtime/ArrayPrototype.cpp:
+ (JSC::isNumericCompareFunction):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::BooleanPrototype::BooleanPrototype):
+ * runtime/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::ErrorPrototype::ErrorPrototype):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::addFunctionProperties):
+ (JSC::functionProtoFuncToString):
+ * runtime/FunctionPrototype.h:
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::~JSFunction):
+ (JSC::JSFunction::mark):
+ (JSC::JSFunction::getCallData):
+ (JSC::JSFunction::call):
+ (JSC::JSFunction::argumentsGetter):
+ (JSC::JSFunction::callerGetter):
+ (JSC::JSFunction::lengthGetter):
+ (JSC::JSFunction::getOwnPropertySlot):
+ (JSC::JSFunction::put):
+ (JSC::JSFunction::deleteProperty):
+ (JSC::JSFunction::getConstructData):
+ (JSC::JSFunction::construct):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::setScope):
+ (JSC::JSFunction::scope):
+ (JSC::JSFunction::isHostFunction):
+ (JSC::JSFunction::scopeChain):
+ (JSC::JSFunction::clearScopeChain):
+ (JSC::JSFunction::setScopeChain):
+ (JSC::JSFunction::nativeFunction):
+ (JSC::JSFunction::setNativeFunction):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::~JSGlobalData):
+ (JSC::JSGlobalData::createNativeThunk):
+ * runtime/JSGlobalData.h:
+ (JSC::JSGlobalData::nativeFunctionThunk):
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ * runtime/JSGlobalObject.h:
+ * runtime/Lookup.cpp:
+ (JSC::setUpStaticFunctionSlot):
+ * runtime/Lookup.h:
+ * runtime/NumberPrototype.cpp:
+ (JSC::NumberPrototype::NumberPrototype):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::ObjectPrototype::ObjectPrototype):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::RegExpPrototype::RegExpPrototype):
+ * runtime/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+
+2009-05-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ For convenience, let the sampling flags tool clear multiple flags at once.
+
+ * jsc.cpp:
+ (GlobalObject::GlobalObject):
+ (functionSetSamplingFlags):
+ (functionClearSamplingFlags):
+
+2009-05-04 Maciej Stachowiak <mjs@apple.com>
+
+ Rubber stamped by Gavin.
+
+ - inline Vector::resize for a ~1.5% speedup on string-tagcloud
+
+ * wtf/Vector.h:
+ (WTF::Vector::resize): Inline
+
+2009-05-03 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
+
+2009-05-03 Mark Rowe <mrowe@apple.com>
+
+ Fix the 64-bit build.
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ * runtime/JSNumberCell.cpp:
+ (JSC::jsAPIMangledNumber):
+ * runtime/JSNumberCell.h:
+
+2009-05-02 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back in one last time (I hope).
+
+2009-05-03 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back out. It still breaks windows.
+
+2009-05-03 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back in.
+
+2009-05-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 25519: streamline lexer by handling BOMs differently
+ https://bugs.webkit.org/show_bug.cgi?id=25519
+
+ Roughly 1% faster SunSpider.
+
+ * parser/Grammar.y: Tweak formatting a bit.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members
+ that are set up by setCode.
+ (JSC::Lexer::currentOffset): Added. Used where the old code would look at
+ m_currentOffset.
+ (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything
+ to handle BOM characters.
+ (JSC::Lexer::shift2): Ditto.
+ (JSC::Lexer::shift3): Ditto.
+ (JSC::Lexer::shift4): Ditto.
+ (JSC::Lexer::setCode): Updated for name change from yylineno to m_line.
+ Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword.
+ Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old
+ m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code
+ to scan for a BOM character and call copyCodeWithoutBOMs() if we find any.
+ (JSC::Lexer::copyCodeWithoutBOMs): Added.
+ (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line.
+ (JSC::Lexer::makeIdentifier): Moved up higher in the file.
+ (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to
+ use a switch statement instead of just if statements.
+ (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to
+ have fewer branches.
+ (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old
+ m_restrKeyword boolean.
+ (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use
+ fewer branches in the ASCII but not identifier case.
+ (JSC::Lexer::isIdentPart): Ditto.
+ (JSC::Lexer::singleEscape): Moved up higher in the file.
+ (JSC::Lexer::convertOctal): Moved up higher in the file.
+ (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use
+ toASCIIHexValue instead of rolling our own here.
+ (JSC::Lexer::convertUnicode): Ditto.
+ (JSC::Lexer::record8): Moved up higher in the file.
+ (JSC::Lexer::record16): Moved up higher in the file.
+ (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF
+ and m_skipCR with m_skipLineEnd, which requires fewer branches in the
+ main lexer loop. Use currentOffset instead of m_currentOffset. Removed
+ unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit.
+ Split out the two cases for InIdentifierOrKeyword and InIdentifier.
+ Added special case tight loops for identifiers and other simple states.
+ Removed a branch from the code that sets m_atLineStart to false using goto.
+ Streamlined the number-handling code so we don't check for the same types
+ twice for non-numeric cases and don't add a null to m_buffer8 when it's
+ not being used. Removed m_eatNextIdentifier, which wasn't working anyway,
+ and m_restrKeyword, which is redundant with m_lastToken. Set the
+ m_delimited flag without using a branch.
+ (JSC::Lexer::scanRegExp): Tweaked style a bit.
+ (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after
+ parsing. Clear out UString objects in the more conventional way.
+ (JSC::Lexer::sourceCode): Made this no-longer inline since it has more
+ work to do in the case where we stripped BOMs.
+
+ * parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex
+ function, which is the same as toASCIIHexValue. Removed isHexDigit
+ function, which is the same as isASCIIHedDigit. Replaced shift with four
+ separate shift functions. Removed isWhiteSpace function that passes
+ m_current, instead just passing m_current explicitly. Removed isOctalDigit,
+ which is the same as isASCIIOctalDigit. Eliminated unused arguments from
+ matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the
+ makeIdentifier function out of the header. Added lastTokenWasRestrKeyword
+ function. Added new constants for m_skipLineEnd. Removed unused yycolumn,
+ m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken,
+ m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2,
+ m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and
+ m_codeWithoutBOMs.
+
+ * parser/SourceProvider.h: Added hasBOMs function. In the future this can
+ be used to tell the lexer about strings known not to have BOMs.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
+
+ * wtf/ASCIICType.h: Added using statements to match the design of the
+ other WTF headers.
+
+2009-05-02 Ada Chan <adachan@apple.com>
+
+ Fix windows build (when doing a clean build)
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Simplified null-ish JSValues.
+
+ Replaced calls to noValue() with calls to JSValue() (which is what
+ noValue() returned). Removed noValue().
+
+ Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
+ Its one remaining use is for construction of hash table deleted values.
+ For that specific task, I made a new, private constructor with a special
+ tag. Removed jsImpossibleValue().
+
+ Removed "JSValue()" initialiazers, since default construction happens...
+ by default.
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::call):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitLoad):
+ * bytecompiler/BytecodeGenerator.h:
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate):
+ * debugger/DebuggerCallFrame.h:
+ (JSC::DebuggerCallFrame::DebuggerCallFrame):
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::clearException):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveLastCaller):
+ * interpreter/Register.h:
+ (JSC::Register::Register):
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCall):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_vm_throw):
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::willExecute):
+ (JSC::Profiler::didExecute):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::getProperty):
+ * runtime/Completion.cpp:
+ (JSC::evaluate):
+ * runtime/Completion.h:
+ (JSC::Completion::Completion):
+ * runtime/GetterSetter.cpp:
+ (JSC::GetterSetter::getPrimitiveNumber):
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::putSlowCase):
+ (JSC::JSArray::deleteProperty):
+ (JSC::JSArray::increaseVectorLength):
+ (JSC::JSArray::setLength):
+ (JSC::JSArray::pop):
+ (JSC::JSArray::sort):
+ (JSC::JSArray::compactForSorting):
+ * runtime/JSCell.cpp:
+ (JSC::JSCell::getJSNumber):
+ * runtime/JSCell.h:
+ (JSC::JSValue::getJSNumber):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::fromNumberOutsideIntegerRange):
+ (JSC::JSImmediate::from):
+ * runtime/JSNumberCell.cpp:
+ (JSC::jsNumberCell):
+ * runtime/JSObject.cpp:
+ (JSC::callDefaultValueFunction):
+ * runtime/JSObject.h:
+ (JSC::JSObject::getDirect):
+ * runtime/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::toPrimitive):
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::next):
+ * runtime/JSValue.h:
+ (JSC::JSValue::):
+ (JSC::JSValueHashTraits::constructDeletedValue):
+ (JSC::JSValueHashTraits::isDeletedValue):
+ (JSC::JSValue::JSValue):
+ * runtime/JSWrapperObject.h:
+ (JSC::JSWrapperObject::JSWrapperObject):
+ * runtime/Operations.h:
+ (JSC::resolveBase):
+ * runtime/PropertySlot.h:
+ (JSC::PropertySlot::clearBase):
+ (JSC::PropertySlot::clearValue):
+
+2009-05-02 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up the lexer in various ways
+
+ ~2% command-line SunSpider speedup
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::setCode): Moved below shift() so it can inline.
+ (JSC::Lexer::scanRegExp): Use resize(0) instead of clear() on Vectors, since the intent
+ here is not to free the underlying buffer.
+ (JSC::Lexer::lex): ditto; also, change the loop logic a bit for the main lexing loop
+ to avoid branching on !m_done twice per iteration. Now we only check it once.
+ (JSC::Lexer::shift): Make this ALWAYS_INLINE and tag an unusual branch as UNLIKELY
+ * parser/Lexer.h:
+ (JSC::Lexer::makeIdentifier): force to be ALWAYS_INLINE
+ * wtf/Vector.h:
+ (WTF::::append): force to be ALWAYS_INLINE (may have helped in ways other than parsing but it wasn't
+ getting inlined in a hot code path in the lexer)
+
+2009-05-01 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Fix 64bit build.
+
+ * runtime/JSNumberCell.h:
+ (JSC::JSValue::JSValue):
+ * runtime/JSValue.h:
+ (JSC::jsNumber):
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Roll out JavaScriptCore API number marshaling.
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax):
+ * API/JSCallbackConstructor.cpp:
+ (JSC::constructJSCallback):
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::getOwnPropertySlot):
+ (JSC::::put):
+ (JSC::::deleteProperty):
+ (JSC::::construct):
+ (JSC::::hasInstance):
+ (JSC::::call):
+ (JSC::::toNumber):
+ (JSC::::toString):
+ (JSC::::staticValueGetter):
+ (JSC::::callbackGetter):
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunction):
+ (JSObjectMakeArray):
+ (JSObjectMakeDate):
+ (JSObjectMakeError):
+ (JSObjectMakeRegExp):
+ (JSObjectGetPrototype):
+ (JSObjectSetPrototype):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectGetPropertyAtIndex):
+ (JSObjectSetPropertyAtIndex):
+ (JSObjectDeleteProperty):
+ (JSObjectCallAsFunction):
+ (JSObjectCallAsConstructor):
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsUndefined):
+ (JSValueIsNull):
+ (JSValueIsBoolean):
+ (JSValueIsNumber):
+ (JSValueIsString):
+ (JSValueIsObject):
+ (JSValueIsObjectOfClass):
+ (JSValueIsEqual):
+ (JSValueIsStrictEqual):
+ (JSValueIsInstanceOfConstructor):
+ (JSValueMakeUndefined):
+ (JSValueMakeNull):
+ (JSValueMakeBoolean):
+ (JSValueMakeNumber):
+ (JSValueMakeString):
+ (JSValueToBoolean):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ (JSValueProtect):
+ (JSValueUnprotect):
+ * JavaScriptCore.exp:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ * runtime/JSNumberCell.cpp:
+ * runtime/JSNumberCell.h:
+ * runtime/JSValue.h:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Fix windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Fix the build.
+
+ * JavaScriptCore.exp:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey "Too Far!" Garen.
+
+ Move JS number construction into JSValue.
+
+ * runtime/JSImmediate.h:
+ * runtime/JSNumberCell.h:
+ (JSC::JSValue::JSValue):
+ * runtime/JSValue.h:
+ (JSC::jsNumber):
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff "The Minneapolis" Garen.
+
+ Add mechanism to vend heap allocated JS numbers to JavaScriptCore API clients with a
+ representation that is independent of the number representation in the VM.
+ - Numbers leaving the interpreter are converted to a tagged JSNumberCell.
+ - The numbers coming into the interpreter (asserted to be the tagged JSNumberCell) are
+ converted back to the VM's internal number representation.
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax):
+ * API/JSCallbackConstructor.cpp:
+ (JSC::constructJSCallback):
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::getOwnPropertySlot):
+ (JSC::::put):
+ (JSC::::deleteProperty):
+ (JSC::::construct):
+ (JSC::::hasInstance):
+ (JSC::::call):
+ (JSC::::toNumber):
+ (JSC::::toString):
+ (JSC::::staticValueGetter):
+ (JSC::::callbackGetter):
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunction):
+ (JSObjectMakeArray):
+ (JSObjectMakeDate):
+ (JSObjectMakeError):
+ (JSObjectMakeRegExp):
+ (JSObjectGetPrototype):
+ (JSObjectSetPrototype):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectGetPropertyAtIndex):
+ (JSObjectSetPropertyAtIndex):
+ (JSObjectDeleteProperty):
+ (JSObjectCallAsFunction):
+ (JSObjectCallAsConstructor):
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsUndefined):
+ (JSValueIsNull):
+ (JSValueIsBoolean):
+ (JSValueIsNumber):
+ (JSValueIsString):
+ (JSValueIsObject):
+ (JSValueIsObjectOfClass):
+ (JSValueIsEqual):
+ (JSValueIsStrictEqual):
+ (JSValueIsInstanceOfConstructor):
+ (JSValueMakeUndefined):
+ (JSValueMakeNull):
+ (JSValueMakeBoolean):
+ (JSValueMakeNumber):
+ (JSValueMakeString):
+ (JSValueToBoolean):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ (JSValueProtect):
+ (JSValueUnprotect):
+ * runtime/JSNumberCell.cpp:
+ (JSC::jsAPIMangledNumber):
+ * runtime/JSNumberCell.h:
+ (JSC::JSNumberCell::isAPIMangledNumber):
+ (JSC::JSNumberCell::):
+ (JSC::JSNumberCell::JSNumberCell):
+ (JSC::JSValue::isAPIMangledNumber):
+ * runtime/JSValue.h:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 6.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 5.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 4.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 3.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 2.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Windows build fix take 1.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber Stamped by Sam Weinig.
+
+ Renamed JSValuePtr => JSValue.
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ * API/JSCallbackConstructor.h:
+ (JSC::JSCallbackConstructor::createStructure):
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackFunction.h:
+ (JSC::JSCallbackFunction::createStructure):
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::createStructure):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::asCallbackObject):
+ (JSC::::put):
+ (JSC::::hasInstance):
+ (JSC::::call):
+ (JSC::::staticValueGetter):
+ (JSC::::staticFunctionGetter):
+ (JSC::::callbackGetter):
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeConstructor):
+ (JSObjectSetPrototype):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectGetPropertyAtIndex):
+ (JSObjectSetPropertyAtIndex):
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsUndefined):
+ (JSValueIsNull):
+ (JSValueIsBoolean):
+ (JSValueIsNumber):
+ (JSValueIsString):
+ (JSValueIsObject):
+ (JSValueIsObjectOfClass):
+ (JSValueIsEqual):
+ (JSValueIsStrictEqual):
+ (JSValueIsInstanceOfConstructor):
+ (JSValueToBoolean):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ (JSValueProtect):
+ (JSValueUnprotect):
+ * JavaScriptCore.exp:
+ * bytecode/CodeBlock.cpp:
+ (JSC::valueToSourceString):
+ (JSC::constantName):
+ (JSC::CodeBlock::dump):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::getConstant):
+ (JSC::CodeBlock::addUnexpectedConstant):
+ (JSC::CodeBlock::unexpectedConstant):
+ * bytecode/EvalCodeCache.h:
+ (JSC::EvalCodeCache::get):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::addConstant):
+ (JSC::BytecodeGenerator::addUnexpectedConstant):
+ (JSC::BytecodeGenerator::emitLoad):
+ (JSC::BytecodeGenerator::emitGetScopedVar):
+ (JSC::BytecodeGenerator::emitPutScopedVar):
+ (JSC::BytecodeGenerator::emitNewError):
+ (JSC::keyForImmediateSwitch):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
+ (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
+ * debugger/Debugger.cpp:
+ (JSC::evaluateInGlobalCallFrame):
+ * debugger/Debugger.h:
+ * debugger/DebuggerActivation.cpp:
+ (JSC::DebuggerActivation::put):
+ (JSC::DebuggerActivation::putWithAttributes):
+ (JSC::DebuggerActivation::lookupGetter):
+ (JSC::DebuggerActivation::lookupSetter):
+ * debugger/DebuggerActivation.h:
+ (JSC::DebuggerActivation::createStructure):
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate):
+ * debugger/DebuggerCallFrame.h:
+ (JSC::DebuggerCallFrame::DebuggerCallFrame):
+ (JSC::DebuggerCallFrame::exception):
+ * interpreter/CachedCall.h:
+ (JSC::CachedCall::CachedCall):
+ (JSC::CachedCall::call):
+ (JSC::CachedCall::setThis):
+ (JSC::CachedCall::setArgument):
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::thisValue):
+ (JSC::CallFrame::dumpCaller):
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::setException):
+ (JSC::ExecState::exception):
+ (JSC::ExecState::exceptionSlot):
+ * interpreter/CallFrameClosure.h:
+ (JSC::CallFrameClosure::setArgument):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::resolve):
+ (JSC::Interpreter::resolveSkip):
+ (JSC::Interpreter::resolveGlobal):
+ (JSC::Interpreter::resolveBase):
+ (JSC::Interpreter::resolveBaseAndProperty):
+ (JSC::Interpreter::resolveBaseAndFunc):
+ (JSC::isNotObject):
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::unwindCallFrame):
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::prepareForRepeatCall):
+ (JSC::Interpreter::createExceptionScope):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ (JSC::Interpreter::retrieveCaller):
+ (JSC::Interpreter::retrieveLastCaller):
+ * interpreter/Interpreter.h:
+ * interpreter/Register.h:
+ (JSC::Register::):
+ (JSC::Register::Register):
+ (JSC::Register::jsValue):
+ * jit/JIT.cpp:
+ (JSC::):
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_mod):
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCall):
+ * jit/JITCode.h:
+ (JSC::):
+ (JSC::JITCode::execute):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::getConstantOperand):
+ (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
+ (JSC::JIT::emitInitRegister):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::tryCachePutByID):
+ (JSC::JITStubs::tryCacheGetByID):
+ (JSC::JITStubs::cti_op_convert_this):
+ (JSC::JITStubs::cti_op_add):
+ (JSC::JITStubs::cti_op_pre_inc):
+ (JSC::JITStubs::cti_op_loop_if_less):
+ (JSC::JITStubs::cti_op_loop_if_lesseq):
+ (JSC::JITStubs::cti_op_get_by_id_generic):
+ (JSC::JITStubs::cti_op_get_by_id):
+ (JSC::JITStubs::cti_op_get_by_id_second):
+ (JSC::JITStubs::cti_op_get_by_id_self_fail):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
+ (JSC::JITStubs::cti_op_get_by_id_proto_fail):
+ (JSC::JITStubs::cti_op_get_by_id_array_fail):
+ (JSC::JITStubs::cti_op_get_by_id_string_fail):
+ (JSC::JITStubs::cti_op_instanceof):
+ (JSC::JITStubs::cti_op_del_by_id):
+ (JSC::JITStubs::cti_op_mul):
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_resolve):
+ (JSC::JITStubs::cti_op_construct_NotJSConstruct):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_string):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_sub):
+ (JSC::JITStubs::cti_op_put_by_val):
+ (JSC::JITStubs::cti_op_put_by_val_array):
+ (JSC::JITStubs::cti_op_put_by_val_byte_array):
+ (JSC::JITStubs::cti_op_lesseq):
+ (JSC::JITStubs::cti_op_loop_if_true):
+ (JSC::JITStubs::cti_op_load_varargs):
+ (JSC::JITStubs::cti_op_negate):
+ (JSC::JITStubs::cti_op_resolve_base):
+ (JSC::JITStubs::cti_op_resolve_skip):
+ (JSC::JITStubs::cti_op_resolve_global):
+ (JSC::JITStubs::cti_op_div):
+ (JSC::JITStubs::cti_op_pre_dec):
+ (JSC::JITStubs::cti_op_jless):
+ (JSC::JITStubs::cti_op_not):
+ (JSC::JITStubs::cti_op_jtrue):
+ (JSC::JITStubs::cti_op_post_inc):
+ (JSC::JITStubs::cti_op_eq):
+ (JSC::JITStubs::cti_op_lshift):
+ (JSC::JITStubs::cti_op_bitand):
+ (JSC::JITStubs::cti_op_rshift):
+ (JSC::JITStubs::cti_op_bitnot):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+ (JSC::JITStubs::cti_op_mod):
+ (JSC::JITStubs::cti_op_less):
+ (JSC::JITStubs::cti_op_neq):
+ (JSC::JITStubs::cti_op_post_dec):
+ (JSC::JITStubs::cti_op_urshift):
+ (JSC::JITStubs::cti_op_bitxor):
+ (JSC::JITStubs::cti_op_bitor):
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_op_throw):
+ (JSC::JITStubs::cti_op_next_pname):
+ (JSC::JITStubs::cti_op_typeof):
+ (JSC::JITStubs::cti_op_is_undefined):
+ (JSC::JITStubs::cti_op_is_boolean):
+ (JSC::JITStubs::cti_op_is_number):
+ (JSC::JITStubs::cti_op_is_string):
+ (JSC::JITStubs::cti_op_is_object):
+ (JSC::JITStubs::cti_op_is_function):
+ (JSC::JITStubs::cti_op_stricteq):
+ (JSC::JITStubs::cti_op_nstricteq):
+ (JSC::JITStubs::cti_op_to_jsnumber):
+ (JSC::JITStubs::cti_op_in):
+ (JSC::JITStubs::cti_op_switch_imm):
+ (JSC::JITStubs::cti_op_switch_char):
+ (JSC::JITStubs::cti_op_switch_string):
+ (JSC::JITStubs::cti_op_del_by_val):
+ (JSC::JITStubs::cti_op_new_error):
+ (JSC::JITStubs::cti_vm_throw):
+ * jit/JITStubs.h:
+ * jsc.cpp:
+ (functionPrint):
+ (functionDebug):
+ (functionGC):
+ (functionVersion):
+ (functionRun):
+ (functionLoad):
+ (functionSetSamplingFlag):
+ (functionClearSamplingFlag):
+ (functionReadline):
+ (functionQuit):
+ * parser/Nodes.cpp:
+ (JSC::processClauseList):
+ * profiler/ProfileGenerator.cpp:
+ (JSC::ProfileGenerator::addParentForConsoleStart):
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::willExecute):
+ (JSC::Profiler::didExecute):
+ (JSC::Profiler::createCallIdentifier):
+ * profiler/Profiler.h:
+ * runtime/ArgList.cpp:
+ (JSC::MarkedArgumentBuffer::slowAppend):
+ * runtime/ArgList.h:
+ (JSC::MarkedArgumentBuffer::at):
+ (JSC::MarkedArgumentBuffer::append):
+ (JSC::ArgList::ArgList):
+ (JSC::ArgList::at):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::put):
+ * runtime/Arguments.h:
+ (JSC::Arguments::createStructure):
+ (JSC::asArguments):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::callArrayConstructor):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::getProperty):
+ (JSC::putProperty):
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin):
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncReverse):
+ (JSC::arrayProtoFuncShift):
+ (JSC::arrayProtoFuncSlice):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncSplice):
+ (JSC::arrayProtoFuncUnShift):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncReduce):
+ (JSC::arrayProtoFuncReduceRight):
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::callBooleanConstructor):
+ (JSC::constructBooleanFromImmediateBoolean):
+ * runtime/BooleanConstructor.h:
+ * runtime/BooleanObject.h:
+ (JSC::asBooleanObject):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncToString):
+ (JSC::booleanProtoFuncValueOf):
+ * runtime/CallData.cpp:
+ (JSC::call):
+ * runtime/CallData.h:
+ * runtime/Collector.cpp:
+ (JSC::Heap::protect):
+ (JSC::Heap::unprotect):
+ (JSC::Heap::heap):
+ * runtime/Collector.h:
+ * runtime/Completion.cpp:
+ (JSC::evaluate):
+ * runtime/Completion.h:
+ (JSC::Completion::Completion):
+ (JSC::Completion::value):
+ (JSC::Completion::setValue):
+ * runtime/ConstructData.cpp:
+ (JSC::construct):
+ * runtime/ConstructData.h:
+ * runtime/DateConstructor.cpp:
+ (JSC::constructDate):
+ (JSC::callDate):
+ (JSC::dateParse):
+ (JSC::dateNow):
+ (JSC::dateUTC):
+ * runtime/DateInstance.h:
+ (JSC::asDateInstance):
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncToString):
+ (JSC::dateProtoFuncToUTCString):
+ (JSC::dateProtoFuncToDateString):
+ (JSC::dateProtoFuncToTimeString):
+ (JSC::dateProtoFuncToLocaleString):
+ (JSC::dateProtoFuncToLocaleDateString):
+ (JSC::dateProtoFuncToLocaleTimeString):
+ (JSC::dateProtoFuncGetTime):
+ (JSC::dateProtoFuncGetFullYear):
+ (JSC::dateProtoFuncGetUTCFullYear):
+ (JSC::dateProtoFuncToGMTString):
+ (JSC::dateProtoFuncGetMonth):
+ (JSC::dateProtoFuncGetUTCMonth):
+ (JSC::dateProtoFuncGetDate):
+ (JSC::dateProtoFuncGetUTCDate):
+ (JSC::dateProtoFuncGetDay):
+ (JSC::dateProtoFuncGetUTCDay):
+ (JSC::dateProtoFuncGetHours):
+ (JSC::dateProtoFuncGetUTCHours):
+ (JSC::dateProtoFuncGetMinutes):
+ (JSC::dateProtoFuncGetUTCMinutes):
+ (JSC::dateProtoFuncGetSeconds):
+ (JSC::dateProtoFuncGetUTCSeconds):
+ (JSC::dateProtoFuncGetMilliSeconds):
+ (JSC::dateProtoFuncGetUTCMilliseconds):
+ (JSC::dateProtoFuncGetTimezoneOffset):
+ (JSC::dateProtoFuncSetTime):
+ (JSC::setNewValueFromTimeArgs):
+ (JSC::setNewValueFromDateArgs):
+ (JSC::dateProtoFuncSetMilliSeconds):
+ (JSC::dateProtoFuncSetUTCMilliseconds):
+ (JSC::dateProtoFuncSetSeconds):
+ (JSC::dateProtoFuncSetUTCSeconds):
+ (JSC::dateProtoFuncSetMinutes):
+ (JSC::dateProtoFuncSetUTCMinutes):
+ (JSC::dateProtoFuncSetHours):
+ (JSC::dateProtoFuncSetUTCHours):
+ (JSC::dateProtoFuncSetDate):
+ (JSC::dateProtoFuncSetUTCDate):
+ (JSC::dateProtoFuncSetMonth):
+ (JSC::dateProtoFuncSetUTCMonth):
+ (JSC::dateProtoFuncSetFullYear):
+ (JSC::dateProtoFuncSetUTCFullYear):
+ (JSC::dateProtoFuncSetYear):
+ (JSC::dateProtoFuncGetYear):
+ * runtime/DatePrototype.h:
+ (JSC::DatePrototype::createStructure):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::callErrorConstructor):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::errorProtoFuncToString):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createInterruptedExecutionException):
+ (JSC::createError):
+ (JSC::createStackOverflowError):
+ (JSC::createUndefinedVariableError):
+ (JSC::createErrorMessage):
+ (JSC::createInvalidParamError):
+ (JSC::createNotAConstructorError):
+ (JSC::createNotAFunctionError):
+ * runtime/ExceptionHelpers.h:
+ * runtime/FunctionConstructor.cpp:
+ (JSC::callFunctionConstructor):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::callFunctionPrototype):
+ (JSC::functionProtoFuncToString):
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall):
+ * runtime/FunctionPrototype.h:
+ (JSC::FunctionPrototype::createStructure):
+ * runtime/GetterSetter.cpp:
+ (JSC::GetterSetter::toPrimitive):
+ (JSC::GetterSetter::getPrimitiveNumber):
+ * runtime/GetterSetter.h:
+ (JSC::asGetterSetter):
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::displayName):
+ * runtime/InternalFunction.h:
+ (JSC::InternalFunction::createStructure):
+ (JSC::asInternalFunction):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::getOwnPropertySlot):
+ (JSC::JSActivation::put):
+ (JSC::JSActivation::putWithAttributes):
+ (JSC::JSActivation::argumentsGetter):
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::createStructure):
+ (JSC::asActivation):
+ * runtime/JSArray.cpp:
+ (JSC::storageSize):
+ (JSC::JSArray::JSArray):
+ (JSC::JSArray::getOwnPropertySlot):
+ (JSC::JSArray::put):
+ (JSC::JSArray::putSlowCase):
+ (JSC::JSArray::deleteProperty):
+ (JSC::JSArray::setLength):
+ (JSC::JSArray::pop):
+ (JSC::JSArray::push):
+ (JSC::JSArray::mark):
+ (JSC::compareNumbersForQSort):
+ (JSC::JSArray::sortNumeric):
+ (JSC::JSArray::sort):
+ (JSC::JSArray::compactForSorting):
+ (JSC::JSArray::checkConsistency):
+ (JSC::constructArray):
+ * runtime/JSArray.h:
+ (JSC::JSArray::getIndex):
+ (JSC::JSArray::setIndex):
+ (JSC::JSArray::createStructure):
+ (JSC::asArray):
+ (JSC::isJSArray):
+ * runtime/JSByteArray.cpp:
+ (JSC::JSByteArray::createStructure):
+ (JSC::JSByteArray::put):
+ * runtime/JSByteArray.h:
+ (JSC::JSByteArray::getIndex):
+ (JSC::JSByteArray::setIndex):
+ (JSC::asByteArray):
+ (JSC::isJSByteArray):
+ * runtime/JSCell.cpp:
+ (JSC::JSCell::put):
+ (JSC::JSCell::getJSNumber):
+ * runtime/JSCell.h:
+ (JSC::asCell):
+ (JSC::JSValue::asCell):
+ (JSC::JSValue::isString):
+ (JSC::JSValue::isGetterSetter):
+ (JSC::JSValue::isObject):
+ (JSC::JSValue::getString):
+ (JSC::JSValue::getObject):
+ (JSC::JSValue::getCallData):
+ (JSC::JSValue::getConstructData):
+ (JSC::JSValue::getUInt32):
+ (JSC::JSValue::getTruncatedInt32):
+ (JSC::JSValue::getTruncatedUInt32):
+ (JSC::JSValue::mark):
+ (JSC::JSValue::marked):
+ (JSC::JSValue::toPrimitive):
+ (JSC::JSValue::getPrimitiveNumber):
+ (JSC::JSValue::toBoolean):
+ (JSC::JSValue::toNumber):
+ (JSC::JSValue::toString):
+ (JSC::JSValue::toObject):
+ (JSC::JSValue::toThisObject):
+ (JSC::JSValue::needsThisConversion):
+ (JSC::JSValue::toThisString):
+ (JSC::JSValue::getJSNumber):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::call):
+ (JSC::JSFunction::argumentsGetter):
+ (JSC::JSFunction::callerGetter):
+ (JSC::JSFunction::lengthGetter):
+ (JSC::JSFunction::getOwnPropertySlot):
+ (JSC::JSFunction::put):
+ (JSC::JSFunction::construct):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::createStructure):
+ (JSC::asFunction):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::markIfNeeded):
+ (JSC::JSGlobalObject::put):
+ (JSC::JSGlobalObject::putWithAttributes):
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::resetPrototype):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::createStructure):
+ (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo):
+ (JSC::asGlobalObject):
+ (JSC::Structure::prototypeForLookup):
+ (JSC::Structure::prototypeChain):
+ (JSC::Structure::isValid):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::encode):
+ (JSC::decode):
+ (JSC::globalFuncEval):
+ (JSC::globalFuncParseInt):
+ (JSC::globalFuncParseFloat):
+ (JSC::globalFuncIsNaN):
+ (JSC::globalFuncIsFinite):
+ (JSC::globalFuncDecodeURI):
+ (JSC::globalFuncDecodeURIComponent):
+ (JSC::globalFuncEncodeURI):
+ (JSC::globalFuncEncodeURIComponent):
+ (JSC::globalFuncEscape):
+ (JSC::globalFuncUnescape):
+ (JSC::globalFuncJSCPrint):
+ * runtime/JSGlobalObjectFunctions.h:
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject):
+ (JSC::JSImmediate::toObject):
+ (JSC::JSImmediate::prototype):
+ (JSC::JSImmediate::toString):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::isImmediate):
+ (JSC::JSImmediate::isNumber):
+ (JSC::JSImmediate::isIntegerNumber):
+ (JSC::JSImmediate::isDoubleNumber):
+ (JSC::JSImmediate::isPositiveIntegerNumber):
+ (JSC::JSImmediate::isBoolean):
+ (JSC::JSImmediate::isUndefinedOrNull):
+ (JSC::JSImmediate::isEitherImmediate):
+ (JSC::JSImmediate::areBothImmediate):
+ (JSC::JSImmediate::areBothImmediateIntegerNumbers):
+ (JSC::JSImmediate::makeValue):
+ (JSC::JSImmediate::makeInt):
+ (JSC::JSImmediate::makeDouble):
+ (JSC::JSImmediate::makeBool):
+ (JSC::JSImmediate::makeUndefined):
+ (JSC::JSImmediate::makeNull):
+ (JSC::JSImmediate::doubleValue):
+ (JSC::JSImmediate::intValue):
+ (JSC::JSImmediate::uintValue):
+ (JSC::JSImmediate::boolValue):
+ (JSC::JSImmediate::rawValue):
+ (JSC::JSImmediate::trueImmediate):
+ (JSC::JSImmediate::falseImmediate):
+ (JSC::JSImmediate::undefinedImmediate):
+ (JSC::JSImmediate::nullImmediate):
+ (JSC::JSImmediate::zeroImmediate):
+ (JSC::JSImmediate::oneImmediate):
+ (JSC::JSImmediate::impossibleValue):
+ (JSC::JSImmediate::toBoolean):
+ (JSC::JSImmediate::getTruncatedUInt32):
+ (JSC::JSImmediate::fromNumberOutsideIntegerRange):
+ (JSC::JSImmediate::from):
+ (JSC::JSImmediate::getTruncatedInt32):
+ (JSC::JSImmediate::toDouble):
+ (JSC::JSImmediate::getUInt32):
+ (JSC::JSValue::JSValue):
+ (JSC::JSValue::isUndefinedOrNull):
+ (JSC::JSValue::isBoolean):
+ (JSC::JSValue::getBoolean):
+ (JSC::JSValue::toInt32):
+ (JSC::JSValue::toUInt32):
+ (JSC::JSValue::isCell):
+ (JSC::JSValue::isInt32Fast):
+ (JSC::JSValue::getInt32Fast):
+ (JSC::JSValue::isUInt32Fast):
+ (JSC::JSValue::getUInt32Fast):
+ (JSC::JSValue::makeInt32Fast):
+ (JSC::JSValue::areBothInt32Fast):
+ (JSC::JSFastMath::canDoFastBitwiseOperations):
+ (JSC::JSFastMath::equal):
+ (JSC::JSFastMath::notEqual):
+ (JSC::JSFastMath::andImmediateNumbers):
+ (JSC::JSFastMath::xorImmediateNumbers):
+ (JSC::JSFastMath::orImmediateNumbers):
+ (JSC::JSFastMath::canDoFastRshift):
+ (JSC::JSFastMath::canDoFastUrshift):
+ (JSC::JSFastMath::rightShiftImmediateNumbers):
+ (JSC::JSFastMath::canDoFastAdditiveOperations):
+ (JSC::JSFastMath::addImmediateNumbers):
+ (JSC::JSFastMath::subImmediateNumbers):
+ (JSC::JSFastMath::incImmediateNumber):
+ (JSC::JSFastMath::decImmediateNumber):
+ * runtime/JSNotAnObject.cpp:
+ (JSC::JSNotAnObject::toPrimitive):
+ (JSC::JSNotAnObject::getPrimitiveNumber):
+ (JSC::JSNotAnObject::put):
+ * runtime/JSNotAnObject.h:
+ (JSC::JSNotAnObject::createStructure):
+ * runtime/JSNumberCell.cpp:
+ (JSC::JSNumberCell::toPrimitive):
+ (JSC::JSNumberCell::getPrimitiveNumber):
+ (JSC::JSNumberCell::getJSNumber):
+ (JSC::jsNumberCell):
+ * runtime/JSNumberCell.h:
+ (JSC::JSNumberCell::createStructure):
+ (JSC::isNumberCell):
+ (JSC::asNumberCell):
+ (JSC::jsNumber):
+ (JSC::JSValue::isDoubleNumber):
+ (JSC::JSValue::getDoubleNumber):
+ (JSC::JSValue::isNumber):
+ (JSC::JSValue::uncheckedGetNumber):
+ (JSC::jsNaN):
+ (JSC::JSValue::toJSNumber):
+ (JSC::JSValue::getNumber):
+ (JSC::JSValue::numberToInt32):
+ (JSC::JSValue::numberToUInt32):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::put):
+ (JSC::JSObject::putWithAttributes):
+ (JSC::callDefaultValueFunction):
+ (JSC::JSObject::getPrimitiveNumber):
+ (JSC::JSObject::defaultValue):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ (JSC::JSObject::lookupGetter):
+ (JSC::JSObject::lookupSetter):
+ (JSC::JSObject::hasInstance):
+ (JSC::JSObject::toNumber):
+ (JSC::JSObject::toString):
+ (JSC::JSObject::fillGetterPropertySlot):
+ * runtime/JSObject.h:
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::offsetForLocation):
+ (JSC::JSObject::locationForOffset):
+ (JSC::JSObject::getDirectOffset):
+ (JSC::JSObject::putDirectOffset):
+ (JSC::JSObject::createStructure):
+ (JSC::asObject):
+ (JSC::JSObject::prototype):
+ (JSC::JSObject::setPrototype):
+ (JSC::JSValue::isObject):
+ (JSC::JSObject::inlineGetOwnPropertySlot):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSObject::getPropertySlot):
+ (JSC::JSObject::get):
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::putDirectWithoutTransition):
+ (JSC::JSObject::toPrimitive):
+ (JSC::JSValue::get):
+ (JSC::JSValue::put):
+ (JSC::JSObject::allocatePropertyStorageInline):
+ * runtime/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::toPrimitive):
+ (JSC::JSPropertyNameIterator::getPrimitiveNumber):
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::create):
+ (JSC::JSPropertyNameIterator::next):
+ * runtime/JSStaticScopeObject.cpp:
+ (JSC::JSStaticScopeObject::put):
+ (JSC::JSStaticScopeObject::putWithAttributes):
+ * runtime/JSStaticScopeObject.h:
+ (JSC::JSStaticScopeObject::JSStaticScopeObject):
+ (JSC::JSStaticScopeObject::createStructure):
+ * runtime/JSString.cpp:
+ (JSC::JSString::toPrimitive):
+ (JSC::JSString::getPrimitiveNumber):
+ (JSC::JSString::getOwnPropertySlot):
+ * runtime/JSString.h:
+ (JSC::JSString::createStructure):
+ (JSC::asString):
+ (JSC::isJSString):
+ (JSC::JSValue::toThisJSString):
+ * runtime/JSValue.cpp:
+ (JSC::JSValue::toInteger):
+ (JSC::JSValue::toIntegerPreserveNaN):
+ * runtime/JSValue.h:
+ (JSC::JSValue::makeImmediate):
+ (JSC::JSValue::asValue):
+ (JSC::noValue):
+ (JSC::jsImpossibleValue):
+ (JSC::jsNull):
+ (JSC::jsUndefined):
+ (JSC::jsBoolean):
+ (JSC::operator==):
+ (JSC::operator!=):
+ (JSC::JSValue::encode):
+ (JSC::JSValue::decode):
+ (JSC::JSValue::JSValue):
+ (JSC::JSValue::operator bool):
+ (JSC::JSValue::operator==):
+ (JSC::JSValue::operator!=):
+ (JSC::JSValue::isUndefined):
+ (JSC::JSValue::isNull):
+ * runtime/JSVariableObject.h:
+ (JSC::JSVariableObject::symbolTablePut):
+ (JSC::JSVariableObject::symbolTablePutWithAttributes):
+ * runtime/JSWrapperObject.h:
+ (JSC::JSWrapperObject::internalValue):
+ (JSC::JSWrapperObject::setInternalValue):
+ * runtime/Lookup.cpp:
+ (JSC::setUpStaticFunctionSlot):
+ * runtime/Lookup.h:
+ (JSC::lookupPut):
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncAbs):
+ (JSC::mathProtoFuncACos):
+ (JSC::mathProtoFuncASin):
+ (JSC::mathProtoFuncATan):
+ (JSC::mathProtoFuncATan2):
+ (JSC::mathProtoFuncCeil):
+ (JSC::mathProtoFuncCos):
+ (JSC::mathProtoFuncExp):
+ (JSC::mathProtoFuncFloor):
+ (JSC::mathProtoFuncLog):
+ (JSC::mathProtoFuncMax):
+ (JSC::mathProtoFuncMin):
+ (JSC::mathProtoFuncPow):
+ (JSC::mathProtoFuncRandom):
+ (JSC::mathProtoFuncRound):
+ (JSC::mathProtoFuncSin):
+ (JSC::mathProtoFuncSqrt):
+ (JSC::mathProtoFuncTan):
+ * runtime/MathObject.h:
+ (JSC::MathObject::createStructure):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::callNativeErrorConstructor):
+ * runtime/NumberConstructor.cpp:
+ (JSC::numberConstructorNaNValue):
+ (JSC::numberConstructorNegInfinity):
+ (JSC::numberConstructorPosInfinity):
+ (JSC::numberConstructorMaxValue):
+ (JSC::numberConstructorMinValue):
+ (JSC::callNumberConstructor):
+ * runtime/NumberConstructor.h:
+ (JSC::NumberConstructor::createStructure):
+ * runtime/NumberObject.cpp:
+ (JSC::NumberObject::getJSNumber):
+ (JSC::constructNumber):
+ * runtime/NumberObject.h:
+ * runtime/NumberPrototype.cpp:
+ (JSC::numberProtoFuncToString):
+ (JSC::numberProtoFuncToLocaleString):
+ (JSC::numberProtoFuncValueOf):
+ (JSC::numberProtoFuncToFixed):
+ (JSC::numberProtoFuncToExponential):
+ (JSC::numberProtoFuncToPrecision):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::constructObject):
+ (JSC::callObjectConstructor):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncValueOf):
+ (JSC::objectProtoFuncHasOwnProperty):
+ (JSC::objectProtoFuncIsPrototypeOf):
+ (JSC::objectProtoFuncDefineGetter):
+ (JSC::objectProtoFuncDefineSetter):
+ (JSC::objectProtoFuncLookupGetter):
+ (JSC::objectProtoFuncLookupSetter):
+ (JSC::objectProtoFuncPropertyIsEnumerable):
+ (JSC::objectProtoFuncToLocaleString):
+ (JSC::objectProtoFuncToString):
+ * runtime/ObjectPrototype.h:
+ * runtime/Operations.cpp:
+ (JSC::JSValue::equalSlowCase):
+ (JSC::JSValue::strictEqualSlowCase):
+ (JSC::throwOutOfMemoryError):
+ (JSC::jsAddSlowCase):
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::jsIsFunctionType):
+ * runtime/Operations.h:
+ (JSC::JSValue::equal):
+ (JSC::JSValue::equalSlowCaseInline):
+ (JSC::JSValue::strictEqual):
+ (JSC::JSValue::strictEqualSlowCaseInline):
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAdd):
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::resolveBase):
+ * runtime/PropertySlot.cpp:
+ (JSC::PropertySlot::functionGetter):
+ * runtime/PropertySlot.h:
+ (JSC::PropertySlot::PropertySlot):
+ (JSC::PropertySlot::getValue):
+ (JSC::PropertySlot::putValue):
+ (JSC::PropertySlot::setValueSlot):
+ (JSC::PropertySlot::setValue):
+ (JSC::PropertySlot::setCustom):
+ (JSC::PropertySlot::setCustomIndex):
+ (JSC::PropertySlot::slotBase):
+ (JSC::PropertySlot::setBase):
+ (JSC::PropertySlot::):
+ * runtime/Protect.h:
+ (JSC::gcProtect):
+ (JSC::gcUnprotect):
+ (JSC::ProtectedPtr::operator JSValue):
+ (JSC::ProtectedJSValue::ProtectedJSValue):
+ (JSC::ProtectedJSValue::get):
+ (JSC::ProtectedJSValue::operator JSValue):
+ (JSC::ProtectedJSValue::operator->):
+ (JSC::ProtectedJSValue::~ProtectedJSValue):
+ (JSC::ProtectedJSValue::operator=):
+ (JSC::operator==):
+ (JSC::operator!=):
+ * runtime/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::getBackref):
+ (JSC::RegExpConstructor::getLastParen):
+ (JSC::RegExpConstructor::getLeftContext):
+ (JSC::RegExpConstructor::getRightContext):
+ (JSC::regExpConstructorDollar1):
+ (JSC::regExpConstructorDollar2):
+ (JSC::regExpConstructorDollar3):
+ (JSC::regExpConstructorDollar4):
+ (JSC::regExpConstructorDollar5):
+ (JSC::regExpConstructorDollar6):
+ (JSC::regExpConstructorDollar7):
+ (JSC::regExpConstructorDollar8):
+ (JSC::regExpConstructorDollar9):
+ (JSC::regExpConstructorInput):
+ (JSC::regExpConstructorMultiline):
+ (JSC::regExpConstructorLastMatch):
+ (JSC::regExpConstructorLastParen):
+ (JSC::regExpConstructorLeftContext):
+ (JSC::regExpConstructorRightContext):
+ (JSC::RegExpConstructor::put):
+ (JSC::setRegExpConstructorInput):
+ (JSC::setRegExpConstructorMultiline):
+ (JSC::constructRegExp):
+ (JSC::callRegExpConstructor):
+ * runtime/RegExpConstructor.h:
+ (JSC::RegExpConstructor::createStructure):
+ (JSC::asRegExpConstructor):
+ * runtime/RegExpMatchesArray.h:
+ (JSC::RegExpMatchesArray::put):
+ * runtime/RegExpObject.cpp:
+ (JSC::regExpObjectGlobal):
+ (JSC::regExpObjectIgnoreCase):
+ (JSC::regExpObjectMultiline):
+ (JSC::regExpObjectSource):
+ (JSC::regExpObjectLastIndex):
+ (JSC::RegExpObject::put):
+ (JSC::setRegExpObjectLastIndex):
+ (JSC::RegExpObject::test):
+ (JSC::RegExpObject::exec):
+ (JSC::callRegExpObject):
+ * runtime/RegExpObject.h:
+ (JSC::RegExpObject::createStructure):
+ (JSC::asRegExpObject):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncTest):
+ (JSC::regExpProtoFuncExec):
+ (JSC::regExpProtoFuncCompile):
+ (JSC::regExpProtoFuncToString):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCodeSlowCase):
+ (JSC::stringFromCharCode):
+ (JSC::callStringConstructor):
+ * runtime/StringObject.cpp:
+ (JSC::StringObject::put):
+ * runtime/StringObject.h:
+ (JSC::StringObject::createStructure):
+ (JSC::asStringObject):
+ * runtime/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncToString):
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncIndexOf):
+ (JSC::stringProtoFuncLastIndexOf):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ (JSC::stringProtoFuncSlice):
+ (JSC::stringProtoFuncSplit):
+ (JSC::stringProtoFuncSubstr):
+ (JSC::stringProtoFuncSubstring):
+ (JSC::stringProtoFuncToLowerCase):
+ (JSC::stringProtoFuncToUpperCase):
+ (JSC::stringProtoFuncLocaleCompare):
+ (JSC::stringProtoFuncBig):
+ (JSC::stringProtoFuncSmall):
+ (JSC::stringProtoFuncBlink):
+ (JSC::stringProtoFuncBold):
+ (JSC::stringProtoFuncFixed):
+ (JSC::stringProtoFuncItalics):
+ (JSC::stringProtoFuncStrike):
+ (JSC::stringProtoFuncSub):
+ (JSC::stringProtoFuncSup):
+ (JSC::stringProtoFuncFontcolor):
+ (JSC::stringProtoFuncFontsize):
+ (JSC::stringProtoFuncAnchor):
+ (JSC::stringProtoFuncLink):
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure):
+ (JSC::Structure::changePrototypeTransition):
+ * runtime/Structure.h:
+ (JSC::Structure::create):
+ (JSC::Structure::setPrototypeWithoutTransition):
+ (JSC::Structure::storedPrototype):
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam "That doesn't look like what I thought it looks like" Weinig.
+
+ Beefed up the JSValuePtr class and removed some non-JSValuePtr dependencies
+ on JSImmediate, in prepapration for making JSImmediate an implementation
+ detail of JSValuePtr.
+
+ SunSpider reports no change.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_mod):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt): Updated for interface changes.
+
+ * runtime/JSImmediate.h:
+ (JSC::JSValuePtr::JSValuePtr):
+ * runtime/JSValue.h:
+ (JSC::JSValuePtr::):
+ (JSC::jsImpossibleValue):
+ (JSC::jsNull):
+ (JSC::jsUndefined):
+ (JSC::jsBoolean):
+ (JSC::JSValuePtr::encode):
+ (JSC::JSValuePtr::decode):
+ (JSC::JSValuePtr::JSValuePtr):
+ (JSC::JSValuePtr::operator bool):
+ (JSC::JSValuePtr::operator==):
+ (JSC::JSValuePtr::operator!=):
+ (JSC::JSValuePtr::isUndefined):
+ (JSC::JSValuePtr::isNull): Changed jsImpossibleValue(), jsNull(),
+ jsUndefined(), and jsBoolean() to operate in terms of JSValuePtr instead
+ of JSImmediate.
+
+ * wtf/StdLibExtras.h:
+ (WTF::bitwise_cast): Fixed up for clarity.
+
+2009-04-30 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug fix for rdar:/6845379. If a case-insensitive regex contains
+ a character class containing a range with an upper bound of \uFFFF
+ the parser will infinite-loop whist adding other-case characters
+ for characters in the range that do have another case.
+
+ * yarr/RegexCompiler.cpp:
+ (JSC::Yarr::CharacterClassConstructor::putRange):
+
+2009-04-30 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ OPCODE_SAMPLING without CODEBLOCK_SAMPLING is currently broken,
+ since SamplingTool::Sample::isNull() checks the m_codeBlock
+ member (which is always null without CODEBLOCK_SAMPLING).
+
+ Restructure the checks so make this work again.
+
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingTool::doRun):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingTool::Sample::isNull):
+
+2009-04-30 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ - Concatenate final three strings in simple replace case at one go
+
+ ~0.2% SunSpider speedup
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of
+ taking substrings and concatenating three strings.
+ * runtime/UString.cpp:
+ (JSC::UString::replaceRange): New helper function.
+ * runtime/UString.h:
+
+2009-04-30 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber Stamped by Gavin Barraclough.
+
+ Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
+ encoding for JSValuePtrs.
+
+ * API/APICast.h:
+ (toJS):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
+ (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
+ * interpreter/Register.h:
+ (JSC::Register::):
+ * jit/JIT.cpp:
+ (JSC::):
+ * jit/JIT.h:
+ * jit/JITCode.h:
+ (JSC::):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_add):
+ (JSC::JITStubs::cti_op_pre_inc):
+ (JSC::JITStubs::cti_op_get_by_id_generic):
+ (JSC::JITStubs::cti_op_get_by_id):
+ (JSC::JITStubs::cti_op_get_by_id_second):
+ (JSC::JITStubs::cti_op_get_by_id_self_fail):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
+ (JSC::JITStubs::cti_op_get_by_id_proto_fail):
+ (JSC::JITStubs::cti_op_get_by_id_array_fail):
+ (JSC::JITStubs::cti_op_get_by_id_string_fail):
+ (JSC::JITStubs::cti_op_instanceof):
+ (JSC::JITStubs::cti_op_del_by_id):
+ (JSC::JITStubs::cti_op_mul):
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_resolve):
+ (JSC::JITStubs::cti_op_construct_NotJSConstruct):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_string):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_sub):
+ (JSC::JITStubs::cti_op_lesseq):
+ (JSC::JITStubs::cti_op_negate):
+ (JSC::JITStubs::cti_op_resolve_base):
+ (JSC::JITStubs::cti_op_resolve_skip):
+ (JSC::JITStubs::cti_op_resolve_global):
+ (JSC::JITStubs::cti_op_div):
+ (JSC::JITStubs::cti_op_pre_dec):
+ (JSC::JITStubs::cti_op_not):
+ (JSC::JITStubs::cti_op_eq):
+ (JSC::JITStubs::cti_op_lshift):
+ (JSC::JITStubs::cti_op_bitand):
+ (JSC::JITStubs::cti_op_rshift):
+ (JSC::JITStubs::cti_op_bitnot):
+ (JSC::JITStubs::cti_op_mod):
+ (JSC::JITStubs::cti_op_less):
+ (JSC::JITStubs::cti_op_neq):
+ (JSC::JITStubs::cti_op_urshift):
+ (JSC::JITStubs::cti_op_bitxor):
+ (JSC::JITStubs::cti_op_bitor):
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_op_throw):
+ (JSC::JITStubs::cti_op_next_pname):
+ (JSC::JITStubs::cti_op_typeof):
+ (JSC::JITStubs::cti_op_is_undefined):
+ (JSC::JITStubs::cti_op_is_boolean):
+ (JSC::JITStubs::cti_op_is_number):
+ (JSC::JITStubs::cti_op_is_string):
+ (JSC::JITStubs::cti_op_is_object):
+ (JSC::JITStubs::cti_op_is_function):
+ (JSC::JITStubs::cti_op_stricteq):
+ (JSC::JITStubs::cti_op_nstricteq):
+ (JSC::JITStubs::cti_op_to_jsnumber):
+ (JSC::JITStubs::cti_op_in):
+ (JSC::JITStubs::cti_op_del_by_val):
+ (JSC::JITStubs::cti_vm_throw):
+ * jit/JITStubs.h:
+ * runtime/JSValue.h:
+ (JSC::JSValuePtr::encode):
+ (JSC::JSValuePtr::decode):
+
+2009-04-30 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver "Abandon Ship!" Hunt.
+
+ Fix a leak in Yarr.
+
+ All Disjunctions should be recorded in RegexPattern::m_disjunctions,
+ so that they can be freed at the end of compilation - copyDisjunction
+ is failing to do so.
+
+ * yarr/RegexCompiler.cpp:
+ (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
+
+2009-04-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Add function to CallFrame for dumping the current JS caller
+
+ Added debug only method CallFrame::dumpCaller() that provide the call location
+ of the deepest currently executing JS function.
+
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::dumpCaller):
+ * interpreter/CallFrame.h:
+
+2009-04-30 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - make BaseStrings have themselves as a base, instead of nothing, to remove common branches
+
+ ~0.7% SunSpider speedup
+
+ * runtime/UString.h:
+ (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null.
+ (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.
+
+2009-04-30 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Two quick improvements to SamplingFlags mechanism.
+
+ SamplingFlags::ScopedFlag class to provide support for automagically
+ clearing a flag as it goes out of scope, and add a little more detail
+ to the output generated by the tool.
+
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingFlags::stop):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingFlags::ScopedFlag::ScopedFlag):
+ (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):
+
+2009-04-30 Adam Roben <aroben@apple.com>
+
+ Restore build event steps that were truncated in r43082
+
+ Rubber-stamped by Steve Falkenburg.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+ * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
+ * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
+ Re-copied the command lines for the build events from the pre-r43082
+ .vcproj files.
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary
+ attribute.
+
+2009-04-30 Adam Roben <aroben@apple.com>
+
+ Move settings from .vcproj files to .vsprops files within the
+ JavaScriptCore directory
+
+ Moving the settings to a .vsprops file means that we will only have to
+ change a single setting to affect all configurations, instead of one
+ setting per configuration.
+
+ Reviewed by Steve Falkenburg.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.vcproj/testapi/testapi.vcproj:
+ Moved settings from these files to the new .vsprops files. Note that
+ testapi.vcproj had a lot of overrides of default settings that were
+ the same as the defaults, which I've removed.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added.
+ * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added.
+ * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added.
+ * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25470
+ Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
+
+ * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
+
+2009-04-30 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - speed up string concatenation by reorganizing some simple cases
+
+ 0.7% SunSpider speedup
+
+ * runtime/UString.cpp:
+ (JSC::concatenate): Put fast case for appending a single character
+ before the empty string special cases; streamline code a bit to
+ delay computing values that are not needed in the fast path.
+
+2009-04-30 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add SamplingFlags mechanism.
+
+ This mechanism allows fine-grained JSC and JavaScript program aware
+ performance measurement. The mechanism provides a set of 32 flags,
+ numbered #1..#32. Flag #16 is initially set, and all other flags
+ are cleared. Flags may be set and cleared from within
+
+ Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
+ Disabled by default, no performance impact. Flags may be modified
+ by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
+ from within JSC implementation, or by calling setSamplingFlag() and
+ clearSamplingFlag() from JavaScript.
+
+ The flags are sampled with a frequency of 10000Hz, and the highest
+ set flag in recorded, allowing multiple events to be measured (with
+ the highest flag number representing the highest priority).
+
+ Disabled by default; no performance impact.
+
+ * JavaScriptCore.exp:
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingFlags::sample):
+ (JSC::SamplingFlags::start):
+ (JSC::SamplingFlags::stop):
+ (JSC::SamplingThread::threadStartFunc):
+ (JSC::SamplingThread::start):
+ (JSC::SamplingThread::stop):
+ (JSC::ScopeSampleRecord::sample):
+ (JSC::SamplingTool::doRun):
+ (JSC::SamplingTool::sample):
+ (JSC::SamplingTool::start):
+ (JSC::SamplingTool::stop):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingFlags::setFlag):
+ (JSC::SamplingFlags::clearFlag):
+ (JSC::SamplingTool::SamplingTool):
+ * jsc.cpp:
+ (GlobalObject::GlobalObject):
+ (functionSetSamplingFlag):
+ (functionClearSamplingFlag):
+ (runWithScripts):
+ * wtf/Platform.h:
+
+2009-04-29 Sam Weinig <sam@webkit.org>
+
+ Another attempt to fix the windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-04-29 Sam Weinig <sam@webkit.org>
+
+ Try and fix the windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-04-29 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver "Peg-Leg" Hunt.
+
+ Coallesce input checking and reduce futzing with the index position
+ between alternatives and iterations of the main loop of a regex,
+ when run in YARR.
+
+ Consider the following regex: /foo|bar/
+
+ Prior to this patch, this will be implemented something like this pseudo-code description:
+
+ loop:
+ check_for_available_input(3) // this increments the index by 3, for the first alterantive.
+ if (available) { test "foo" }
+ decrement_index(3)
+ check_for_available_input(3) // this increments the index by 3, for the second alterantive.
+ if (available) { test "bar" }
+ decrement_index(3)
+ check_for_available_input(1) // can we loop again?
+ if (available) { goto loop }
+
+ With these changes it will look more like this:
+
+ check_for_available_input(3) // this increments the index by 3, for the first alterantive.
+ if (!available) { goto fail }
+ loop:
+ test "foo"
+ test "bar"
+ check_for_available_input(1) // can we loop again?
+ if (available) { goto loop }
+ fail:
+
+
+ This gives about a 5% gain on v8-regex, no change on Sunspider.
+
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo):
+ (JSC::Yarr::RegexGenerator::generateDisjunction):
+
+2009-04-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Clean up ArgList to be a trivial type
+
+ Separate out old ArgList logic to handle buffering and marking arguments
+ into a distinct MarkedArgumentBuffer type. ArgList becomes a trivial
+ struct of a pointer and length.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunction):
+ (JSObjectMakeArray):
+ (JSObjectMakeDate):
+ (JSObjectMakeError):
+ (JSObjectMakeRegExp):
+ (JSObjectCallAsFunction):
+ (JSObjectCallAsConstructor):
+ * JavaScriptCore.exp:
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::emptyList):
+ * runtime/ArgList.cpp:
+ (JSC::ArgList::getSlice):
+ (JSC::MarkedArgumentBuffer::markLists):
+ (JSC::MarkedArgumentBuffer::slowAppend):
+ * runtime/ArgList.h:
+ (JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
+ (JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
+ (JSC::ArgList::ArgList):
+ (JSC::ArgList::at):
+ (JSC::ArgList::isEmpty):
+ (JSC::ArgList::size):
+ (JSC::ArgList::begin):
+ (JSC::ArgList::end):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::fillArgList):
+ * runtime/Arguments.h:
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncReduce):
+ (JSC::arrayProtoFuncReduceRight):
+ * runtime/Collector.cpp:
+ (JSC::Heap::collect):
+ * runtime/Collector.h:
+ (JSC::Heap::markListSet):
+ * runtime/CommonIdentifiers.h:
+ * runtime/Error.cpp:
+ (JSC::Error::create):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::JSArray):
+ (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
+ (JSC::JSArray::fillArgList):
+ (JSC::constructArray):
+ * runtime/JSArray.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::put):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCodeSlowCase):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncMatch):
+
+2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25334
+
+ Fix Qt build when ENABLE_JIT is explicitly set to 1
+ to overrule defaults.
+
+ * JavaScriptCore.pri:
+
+2009-04-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Steve Falkenburg.
+
+ Crash in profiler due to incorrect assuming displayName would be a string.
+
+ Fixed by adding a type guard.
+
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::displayName):
+
+2009-04-28 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber stamped by Beth Dakin.
+
+ Removed scaffolding supporting dynamically converting between 32bit and
+ 64bit value representations.
+
+ * API/JSCallbackConstructor.cpp:
+ (JSC::constructJSCallback):
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::construct):
+ (JSC::::call):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::getConstant):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitEqualityOp):
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::thisValue):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::createExceptionScope):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ * interpreter/Register.h:
+ (JSC::Register::):
+ (JSC::Register::Register):
+ (JSC::Register::jsValue):
+ (JSC::Register::marked):
+ (JSC::Register::mark):
+ (JSC::Register::i):
+ (JSC::Register::activation):
+ (JSC::Register::arguments):
+ (JSC::Register::callFrame):
+ (JSC::Register::codeBlock):
+ (JSC::Register::function):
+ (JSC::Register::propertyNameIterator):
+ (JSC::Register::scopeChain):
+ (JSC::Register::vPC):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_load_varargs):
+ (JSC::JITStubs::cti_op_call_eval):
+ * jsc.cpp:
+ (functionPrint):
+ (functionDebug):
+ (functionRun):
+ (functionLoad):
+ * runtime/ArgList.h:
+ (JSC::ArgList::at):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::copyToRegisters):
+ (JSC::Arguments::fillArgList):
+ (JSC::Arguments::getOwnPropertySlot):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::constructArrayWithSizeQuirk):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncJoin):
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncSlice):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncSplice):
+ (JSC::arrayProtoFuncUnShift):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncReduce):
+ (JSC::arrayProtoFuncReduceRight):
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::constructBoolean):
+ (JSC::callBooleanConstructor):
+ * runtime/DateConstructor.cpp:
+ (JSC::constructDate):
+ (JSC::dateParse):
+ (JSC::dateUTC):
+ * runtime/DatePrototype.cpp:
+ (JSC::formatLocaleDate):
+ (JSC::fillStructuresUsingTimeArgs):
+ (JSC::fillStructuresUsingDateArgs):
+ (JSC::dateProtoFuncSetTime):
+ (JSC::dateProtoFuncSetYear):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::constructError):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall):
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::JSArray):
+ (JSC::constructArray):
+ * runtime/JSArray.h:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::encode):
+ (JSC::decode):
+ (JSC::globalFuncEval):
+ (JSC::globalFuncParseInt):
+ (JSC::globalFuncParseFloat):
+ (JSC::globalFuncIsNaN):
+ (JSC::globalFuncIsFinite):
+ (JSC::globalFuncEscape):
+ (JSC::globalFuncUnescape):
+ (JSC::globalFuncJSCPrint):
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncAbs):
+ (JSC::mathProtoFuncACos):
+ (JSC::mathProtoFuncASin):
+ (JSC::mathProtoFuncATan):
+ (JSC::mathProtoFuncATan2):
+ (JSC::mathProtoFuncCeil):
+ (JSC::mathProtoFuncCos):
+ (JSC::mathProtoFuncExp):
+ (JSC::mathProtoFuncFloor):
+ (JSC::mathProtoFuncLog):
+ (JSC::mathProtoFuncMax):
+ (JSC::mathProtoFuncMin):
+ (JSC::mathProtoFuncPow):
+ (JSC::mathProtoFuncRound):
+ (JSC::mathProtoFuncSin):
+ (JSC::mathProtoFuncSqrt):
+ (JSC::mathProtoFuncTan):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::construct):
+ * runtime/NumberConstructor.cpp:
+ (JSC::constructWithNumberConstructor):
+ (JSC::callNumberConstructor):
+ * runtime/NumberPrototype.cpp:
+ (JSC::numberProtoFuncToString):
+ (JSC::numberProtoFuncToFixed):
+ (JSC::numberProtoFuncToExponential):
+ (JSC::numberProtoFuncToPrecision):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::constructObject):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncHasOwnProperty):
+ (JSC::objectProtoFuncIsPrototypeOf):
+ (JSC::objectProtoFuncDefineGetter):
+ (JSC::objectProtoFuncDefineSetter):
+ (JSC::objectProtoFuncLookupGetter):
+ (JSC::objectProtoFuncLookupSetter):
+ (JSC::objectProtoFuncPropertyIsEnumerable):
+ * runtime/PropertySlot.h:
+ (JSC::PropertySlot::getValue):
+ * runtime/RegExpConstructor.cpp:
+ (JSC::constructRegExp):
+ * runtime/RegExpObject.cpp:
+ (JSC::RegExpObject::match):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCodeSlowCase):
+ (JSC::stringFromCharCode):
+ (JSC::constructWithStringConstructor):
+ (JSC::callStringConstructor):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncIndexOf):
+ (JSC::stringProtoFuncLastIndexOf):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ (JSC::stringProtoFuncSlice):
+ (JSC::stringProtoFuncSplit):
+ (JSC::stringProtoFuncSubstr):
+ (JSC::stringProtoFuncSubstring):
+ (JSC::stringProtoFuncLocaleCompare):
+ (JSC::stringProtoFuncFontcolor):
+ (JSC::stringProtoFuncFontsize):
+ (JSC::stringProtoFuncAnchor):
+ (JSC::stringProtoFuncLink):
+
+2009-04-28 David Kilzer <ddkilzer@apple.com>
+
+ A little more hardening for UString
+
+ Reviewed by Maciej Stachowiak.
+
+ Revised fix for <rdar://problem/5861045> in r42644.
+
+ * runtime/UString.cpp:
+ (JSC::newCapacityWithOverflowCheck): Added.
+ (JSC::concatenate): Used newCapacityWithOverflowCheck().
+ (JSC::UString::append): Ditto.
+
+2009-04-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bring back r42969, this time with correct codegen
+
+ Add logic to the codegen for right shift to avoid jumping to a helper function
+ when shifting a small floating point value.
+
+ * jit/JITArithmetic.cpp:
+ (isSSE2Present):
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+
+2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
+
+ wxMSW build fix. Switch JSCore build back to static.
+
+ * API/JSBase.h:
+ * config.h:
+ * jscore.bkl:
+
+2009-04-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Roll out r42969, due to hangs in build bot.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ (JSC::isSSE2Present):
+
+2009-04-28 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed: fix distcheck build, add (even more) missing files to list.
+
+ * GNUmakefile.am:
+
+2009-04-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Improve performance of string indexing
+
+ Add a cti_get_by_val_string function to specialise indexing into a string object.
+ This gives us a slight performance win on a number of string tests.
+
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_string):
+ * jit/JITStubs.h:
+
+2009-04-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Improve performance of right shifts of large or otherwise floating point values.
+
+ Add logic to the codegen for right shift to avoid jumping to a helper function
+ when shifting a small floating point value.
+
+ * jit/JITArithmetic.cpp:
+ (isSSE2Present): Moved to the head of file.
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+
+2009-04-28 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed: fix distcheck build, add (more) missing files to list.
+
+ * GNUmakefile.am:
+
+2009-04-28 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed: fix distcheck build, add missing header to file list.
+
+ * GNUmakefile.am:
+
+2009-04-28 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Maciej "Henry Morgan" Stachowiak.
+
+ Enable YARR.
+ (Again.)
+
+ * wtf/Platform.h:
+
+2009-04-27 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Tweak a loop condition to keep GCC happy,
+ some GCCs seem to be having issues with this. :-/
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::breakTarget):
+ * wtf/Platform.h:
+
+2009-04-27 Adam Roben <aroben@apple.com>
+
+ Windows Debug build fix
+
+ Not sure why the buildbots weren't affected by this problem.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS
+ re-order the file list, and added JavaScriptCore[_debug].def to the
+ project. This was not necessary for the fix, but made making the fix
+ easier.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+ Removed a function that no longer exists.
+
+2009-04-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Weinig Sam.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25416
+ "Cached prototype accesses unsafely hoist property storage load above structure checks."
+
+ Do not hoist the load of the pointer to the property storage array.
+
+ No performance impact.
+
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+
+2009-04-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoffrey "Gaffe or energy?" Garen.
+
+ Randomize address requested by ExecutableAllocatorFixedVMPool.
+
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+
+2009-04-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove scons-based build system.
+
+ * JavaScriptCore.scons: Removed.
+
+2009-04-25 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Buildfix).
+
+ Make HAVE_MADV_FREE darwin only for now
+
+ * wtf/Platform.h:
+
+2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Gtk build fix - check if we have MADV_FREE before using it.
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::releaseExcessCapacity):
+ * wtf/Platform.h:
+
+2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Switching JSCore from a static lib to a dynamic lib
+ to match the Apple build and fix symbol exports.
+
+ * jscore.bkl:
+
+2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25337
+ Move ThreadingQt.cpp under the qt directory.
+
+ * JavaScriptCore.pri:
+ * wtf/ThreadingQt.cpp: Removed.
+ * wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.
+
+2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25338
+ Move ThreadingGtk.cpp under the gtk directory.
+
+ * GNUmakefile.am:
+ * wtf/ThreadingGtk.cpp: Removed.
+ * wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
+
+2009-04-24 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam "Wesley" Weinig.
+
+ Improve performance to YARR interpreter.
+ (From about 3x slower than PCRE on regex-dna to about 30% slower).
+
+ * yarr/RegexCompiler.cpp:
+ (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
+ * yarr/RegexInterpreter.cpp:
+ (JSC::Yarr::Interpreter::checkCharacter):
+ (JSC::Yarr::Interpreter::checkCasedCharacter):
+ (JSC::Yarr::Interpreter::backtrackPatternCharacter):
+ (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
+ (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
+ (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
+ (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
+ (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
+ (JSC::Yarr::Interpreter::matchDisjunction):
+ (JSC::Yarr::Interpreter::interpret):
+ (JSC::Yarr::ByteCompiler::atomPatternCharacter):
+ (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
+ (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
+ (JSC::Yarr::ByteCompiler::closeAlternative):
+ (JSC::Yarr::ByteCompiler::closeBodyAlternative):
+ (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
+ (JSC::Yarr::ByteCompiler::regexBegin):
+ (JSC::Yarr::ByteCompiler::regexEnd):
+ (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
+ (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
+ (JSC::Yarr::ByteCompiler::emitDisjunction):
+ * yarr/RegexInterpreter.h:
+ (JSC::Yarr::ByteTerm::):
+ (JSC::Yarr::ByteTerm::ByteTerm):
+ (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
+ (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
+ (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
+ (JSC::Yarr::ByteTerm::AlternativeBegin):
+ (JSC::Yarr::ByteTerm::AlternativeDisjunction):
+ (JSC::Yarr::ByteTerm::AlternativeEnd):
+ (JSC::Yarr::ByteTerm::SubpatternBegin):
+ (JSC::Yarr::ByteTerm::SubpatternEnd):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
+ * yarr/RegexPattern.h:
+
+2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ * wtf/CurrentTime.h: Fix a typo in a comment.
+
+2009-04-24 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Add reinterpret_cast
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::releaseExcessCapacity):
+
+2009-04-23 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ <rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion
+
+ We now track the maximum extent of the RegisterFile, and when we reach the final
+ return from JS (so the stack portion of the registerfile becomes empty) we see
+ if that extent is greater than maxExcessCapacity. If it is we use madvise or
+ VirtualFree to release the physical pages that were backing the excess.
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::releaseExcessCapacity):
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ (JSC::RegisterFile::shrink):
+ (JSC::RegisterFile::grow):
+
+2009-04-23 Mark Rowe <mrowe@apple.com>
+
+ With great sadness and a heavy heart I switch us back from YARR to WREC in
+ order to restore greenness to the world once more.
+
+ * wtf/Platform.h:
+
+2009-04-23 Mark Rowe <mrowe@apple.com>
+
+ More Windows build fixage.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
+
+2009-04-23 Mark Rowe <mrowe@apple.com>
+
+ Attempt to fix the Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove a symbol that no longer exists.
+
+2009-04-23 Francisco Tolmasky <francisco@280north.com>
+
+ BUG 24604: WebKit profiler reports incorrect total times
+ <https://bugs.webkit.org/show_bug.cgi?id=24604>
+
+ Reviewed by Timothy Hatcher and Kevin McCullough.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * profiler/CallIdentifier.h:
+ (JSC::CallIdentifier::Hash::hash):
+ (JSC::CallIdentifier::Hash::equal):
+ (JSC::CallIdentifier::hash):
+ (WTF::):
+ * profiler/HeavyProfile.cpp: Removed.
+ * profiler/HeavyProfile.h: Removed.
+ * profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile
+ (JSC::Profile::create):
+ * profiler/Profile.h:
+ * profiler/ProfileNode.cpp:
+ * profiler/ProfileNode.h:
+ * profiler/TreeProfile.cpp: Removed.
+ * profiler/TreeProfile.h: Removed.
+
+2009-04-23 Gavin Barraclough <barraclough@apple.com>
+
+ Not Reviewed.
+
+ Speculative Windows build fix II.
+
+ * yarr/RegexInterpreter.cpp:
+
+2009-04-23 Gavin Barraclough <barraclough@apple.com>
+
+ Not Reviewed.
+
+ Speculative Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * runtime/RegExp.cpp:
+
+2009-04-23 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by salty sea dogs Sam & Geoff.
+
+ Enable YARR_JIT by default (where supported), replacing WREC.
+
+ * wtf/Platform.h:
+
+2009-04-23 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff "Dread Pirate Roberts" Garen.
+
+ Various small fixes to YARR JIT, in preparation for enabling it by default.
+
+ * Correctly index into the callframe when storing restart addresses for
+ nested alternatives.
+ * Allow backtracking back into matched alternatives of parentheses.
+ * Fix callframe offset calculation for parenthetical assertions.
+ * When a set of parenthese are quantified with a fixed and variable portion,
+ and the variable portion is quantified once, this should not reset the
+ pattern match on failure to match (the last match from the firxed portion
+ should be preserved).
+ * Up the pattern size limit to match PCRE's new limit.
+ * Unlclosed parentheses should be reported with the message "missing )".
+
+ * wtf/Platform.h:
+ * yarr/RegexCompiler.cpp:
+ (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
+ (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
+ * yarr/RegexInterpreter.cpp:
+ (JSC::Yarr::Interpreter::matchParentheses):
+ (JSC::Yarr::Interpreter::backtrackParentheses):
+ (JSC::Yarr::ByteCompiler::emitDisjunction):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
+ (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
+ (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
+ (JSC::Yarr::RegexGenerator::generateTerm):
+ (JSC::Yarr::executeRegex):
+ * yarr/RegexParser.h:
+ (JSC::Yarr::Parser::):
+ (JSC::Yarr::Parser::parseTokens):
+ (JSC::Yarr::Parser::parse):
+ * yarr/RegexPattern.h:
+ (JSC::Yarr::PatternTerm::):
+ (JSC::Yarr::PatternTerm::PatternTerm):
+
+2009-04-22 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Gavin Barraclough.
+
+ Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments.
+
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::addToFreeList):
+ (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ (JSC::FixedVMPoolAllocator::alloc):
+ (JSC::FixedVMPoolAllocator::free):
+ (JSC::FixedVMPoolAllocator::isWithinVMPool):
+
+2009-04-22 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Gavin Barraclough.
+
+ Add some assertions to FixedVMPoolAllocator to guard against cases where we
+ attempt to free memory that didn't originate from the pool, or we attempt to
+ hand out a bogus address from alloc.
+
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::release):
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ (JSC::FixedVMPoolAllocator::alloc):
+ (JSC::FixedVMPoolAllocator::free):
+ (JSC::FixedVMPoolAllocator::isWithinVMPool):
+
+2009-04-22 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Sam "Blackbeard" Weinig.
+
+ Although pirates do spell the word 'generate' as 'genertate',
+ webkit developers do not. Fixertate.
+
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::generateAssertionBOL):
+ (JSC::Yarr::RegexGenerator::generateAssertionEOL):
+ (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary):
+ (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle):
+ (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
+ (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed):
+ (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
+ (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
+ (JSC::Yarr::RegexGenerator::generateCharacterClassSingle):
+ (JSC::Yarr::RegexGenerator::generateCharacterClassFixed):
+ (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
+ (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy):
+ (JSC::Yarr::RegexGenerator::generateTerm):
+
+2009-04-22 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam "Blackbeard" Weinig.
+
+ Improvements to YARR JIT. This patch expands support in three key areas:
+ * Add (temporary) support for falling back to PCRE for expressions not supported.
+ * Add support for x86_64 and Windows.
+ * Add support for singly quantified parentheses (? and ??), alternatives within
+ parentheses, and parenthetical assertions.
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::match):
+ * yarr/RegexJIT.cpp:
+ (JSC::Yarr::RegexGenerator::storeToFrame):
+ (JSC::Yarr::RegexGenerator::storeToFrameWithPatch):
+ (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
+ (JSC::Yarr::RegexGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom):
+ (JSC::Yarr::RegexGenerator::genertateAssertionBOL):
+ (JSC::Yarr::RegexGenerator::genertateAssertionEOL):
+ (JSC::Yarr::RegexGenerator::matchAssertionWordchar):
+ (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy):
+ (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
+ (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
+ (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
+ (JSC::Yarr::RegexGenerator::generateTerm):
+ (JSC::Yarr::RegexGenerator::generateDisjunction):
+ (JSC::Yarr::RegexGenerator::generateEnter):
+ (JSC::Yarr::RegexGenerator::generateReturn):
+ (JSC::Yarr::RegexGenerator::RegexGenerator):
+ (JSC::Yarr::RegexGenerator::generate):
+ (JSC::Yarr::RegexGenerator::compile):
+ (JSC::Yarr::RegexGenerator::generationFailed):
+ (JSC::Yarr::jitCompileRegex):
+ (JSC::Yarr::executeRegex):
+ * yarr/RegexJIT.h:
+ (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
+ (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
+
+2009-04-22 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Darin Adler.
+
+ Fix for <rdar://problem/6816957>
+ Turn off Geolocation by default
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2009-04-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Buildfix).
+
+ * interpreter/CachedCall.h:
+
+2009-04-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ * runtime/StringPrototype.cpp:
+
+2009-04-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Improve String.replace performance slightly
+
+ Apply our vm reentry caching logic to String.replace with global
+ regexes.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+
+2009-04-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich and Oliver Hunt.
+
+ Re-Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
+ fast/workers/use-machine-stack.html (22531)
+
+ SunSpider reports no change.
+
+ Use a larger recursion limit on the main thread (because we can, and
+ there's some evidence that it may improve compatibility), and a smaller
+ recursion limit on secondary threads (because they tend to have smaller
+ stacks).
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::prepareForRepeatCall):
+ * interpreter/Interpreter.h:
+ (JSC::): Ditto. I wrote the recursion test slightly funny, so that the
+ common case remains a simple compare to constant.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin): Conservatively, set the array recursion limits
+ to the lower, secondary thread limit. We can do something fancier if
+ compatibility moves us, but this seems sufficient for now.
+
+2009-04-21 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber-stamped by Adam Roben.
+
+ Disabled one more Mozilla JS test because it fails intermittently on Windows.
+ (See https://bugs.webkit.org/show_bug.cgi?id=25160.)
+
+ * tests/mozilla/expected.html:
+
+2009-04-21 Adam Roben <aroben@apple.com>
+
+ Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
+ configuration
+
+ This matches the naming scheme for WebKit.dll, and will be necessary
+ once Safari links against JavaScriptCore.dll. This change also causes
+ run-safari not to fail (because the launcher printed by FindSafari was
+ always looking for JavaScriptCore.dll, never
+ JavaScriptCore_debug.dll).
+
+ Part of Bug 25305: can't run safari or drt on windows
+ <https://bugs.webkit.org/show_bug.cgi?id=25305>
+
+ Reviewed by Steve Falkenburg and Sam Weinig.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.vcproj/testapi/testapi.vcproj:
+ Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
+
+2009-04-21 Adam Roben <aroben@apple.com>
+
+ Fix JavaScriptCore build on VC++ Express
+
+ Reviewed by Steve Falkenburg and Sam Weinig.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Link
+ explicitly against gdi32.lib and oleaut32.lib.
+
+2009-04-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Tiger crash fix: Put VM tags in their own header file, and fixed up the
+ #ifdefs so they're not used on Tiger.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ * jit/ExecutableAllocatorPosix.cpp:
+ (JSC::ExecutablePool::systemAlloc):
+ * runtime/Collector.cpp:
+ (JSC::allocateBlock):
+ * wtf/VMTags.h: Added.
+
+2009-04-20 Steve Falkenburg <sfalken@apple.com>
+
+ More Windows build fixes.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.make: Copy DLLs, PDBs.
+ * JavaScriptCore.vcproj/JavaScriptCore.resources: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Added.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add version stamping, resource copying.
+
+2009-04-20 Steve Falkenburg <sfalken@apple.com>
+
+ Separate JavaScriptCore.dll from WebKit.dll.
+ Slight performance improvement or no change on benchmarks.
+
+ Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
+ and simplifies standalone JavaScriptCore builds.
+
+ Reviewed by Oliver Hunt.
+
+ * API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
+ * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
+ * runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
+ * runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
+ * runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
+ * runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
+ * runtime/UString.h: Specify JS_EXPORTDATA on exported data.
+
+2009-04-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Kevin McCullough.
+
+ Always tag mmaped memory on darwin and clean up #defines
+ now that they are a little bigger.
+
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ * jit/ExecutableAllocatorPosix.cpp:
+ (JSC::ExecutablePool::systemAlloc):
+ * runtime/Collector.cpp:
+ (JSC::allocateBlock):
+
+2009-04-20 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Tim Hatcher.
+
+ Add licenses for xcconfig files.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ * Configurations/FeatureDefines.xcconfig:
+ * Configurations/JavaScriptCore.xcconfig:
+ * Configurations/Version.xcconfig:
+
+2009-04-20 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Build fix for Qt port (after r42646). Not reviewed.
+
+ * wtf/unicode/qt4/UnicodeQt4.h: Added U16_PREV.
+
+2009-04-19 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Better fix for JSStringCreateWithCFString hardening.
+
+ * API/JSStringRefCF.cpp:
+ (JSStringCreateWithCFString):
+
+2009-04-19 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/5860954>
+ Harden JSStringCreateWithCFString against malformed CFStringRefs.
+
+ * API/JSStringRefCF.cpp:
+ (JSStringCreateWithCFString):
+
+2009-04-19 David Kilzer <ddkilzer@apple.com>
+
+ Make FEATURE_DEFINES completely dynamic
+
+ Reviewed by Darin Adler.
+
+ Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
+ variables for each feature, making it possible to remove all
+ knowledge of FEATURE_DEFINES from build-webkit.
+
+ * Configurations/FeatureDefines.xcconfig: Extract a variable
+ from FEATURE_DEFINES for each feature setting.
+
+2009-04-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix typo. s/VM_MEMORY_JAVASCRIPT_JIT_REGISTER_FILE/VM_MEMORY_JAVASCRIPT_CORE/
+
+ * runtime/Collector.cpp:
+ (JSC::allocateBlock): Fix bozo typo.
+
+2009-04-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for <rdar://problem/6801555> Tag JavaScript memory on SnowLeopard
+
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ * jit/ExecutableAllocatorPosix.cpp:
+ (JSC::ExecutablePool::systemAlloc):
+ * runtime/Collector.cpp:
+ (JSC::allocateBlock):
+
+2009-04-18 Drew Wilson <amw@apple.com>
+
+ <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
+
+ Reviewed by Dan Bernstein.
+
+ * wtf/unicode/icu/UnicodeIcu.h:
+ (WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic): Added.
+
+2009-04-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix for <rdar://problem/5861045>
+ A little bit of hardening for UString.
+
+ * runtime/UString.cpp:
+ (JSC::concatenate):
+ (JSC::UString::append):
+
+2009-04-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe and Dan Bernstein.
+
+ Fix for <rdar://problem/5861188>
+ A little bit of hardening for Vector.
+
+ * wtf/Vector.h:
+ (WTF::Vector<T, inlineCapacity>::append):
+ (WTF::Vector<T, inlineCapacity>::insert):
+
+2009-04-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ On x86_64, make all JIT-code allocations from a new heap, managed
+ by FixedVMPoolAllocator. This class allocates a single large (2Gb)
+ pool of virtual memory from which all further allocations take place.
+ Since all JIT code is allocated from this pool, we can continue to
+ safely assume (as is already asserted) that it will always be possible
+ to link any JIT-code to JIT-code jumps and calls.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Add new file.
+ * jit/ExecutableAllocatorFixedVMPool.cpp: Added.
+ (JSC::FreeListEntry::FreeListEntry):
+ (JSC::AVLTreeAbstractorForFreeList::get_less):
+ (JSC::AVLTreeAbstractorForFreeList::set_less):
+ (JSC::AVLTreeAbstractorForFreeList::get_greater):
+ (JSC::AVLTreeAbstractorForFreeList::set_greater):
+ (JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
+ (JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
+ (JSC::AVLTreeAbstractorForFreeList::null):
+ (JSC::AVLTreeAbstractorForFreeList::compare_key_key):
+ (JSC::AVLTreeAbstractorForFreeList::compare_key_node):
+ (JSC::AVLTreeAbstractorForFreeList::compare_node_node):
+ (JSC::sortFreeListEntriesByPointer):
+ (JSC::sortCommonSizedAllocations):
+ (JSC::FixedVMPoolAllocator::release):
+ (JSC::FixedVMPoolAllocator::reuse):
+ (JSC::FixedVMPoolAllocator::addToFreeList):
+ (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
+ (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
+ (JSC::FixedVMPoolAllocator::alloc):
+ (JSC::FixedVMPoolAllocator::free):
+ (JSC::ExecutableAllocator::intializePageSize):
+ (JSC::ExecutablePool::systemAlloc):
+ (JSC::ExecutablePool::systemRelease):
+ The new 2Gb heap class!
+ * jit/ExecutableAllocatorPosix.cpp:
+ Disable use of this implementation on x86_64.
+ * wtf/AVLTree.h:
+ Add missing variable initialization.
+ (WTF::::remove):
+
+2009-04-17 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix bug where the VM reentry cache would not correctly unroll the cached callframe
+
+ Fix a check that was intended to mark a cached call as invalid when the callframe could
+ not be constructed. Instead it was just checking that there was a place to put the
+ exception. This eventually results in a non-recoverable RegisterFile starvation.
+
+ * interpreter/CachedCall.h:
+ (JSC::CachedCall::CachedCall):
+ (JSC::CachedCall::call): add assertion to ensure we don't use a bad callframe
+
+2009-04-17 David Kilzer <ddkilzer@apple.com>
+
+ Simplify FEATURE_DEFINES definition
+
+ Reviewed by Darin Adler.
+
+ This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
+ variables to their own FeatureDefines.xcconfig file. It also
+ extracts a new ENABLE_GEOLOCATION variable so that
+ FEATURE_DEFINES only needs to be defined once.
+
+ * Configurations/FeatureDefines.xcconfig: Added.
+ * Configurations/JavaScriptCore.xcconfig: Removed definition of
+ ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include
+ of FeatureDefines.xcconfig.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Added
+ FeatureDefines.xcconfig file.
+
+2009-04-08 Mihnea Ovidenie <mihnea@adobe.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 25027: JavaScript parseInt wrong on negative numbers
+ <https://bugs.webkit.org/show_bug.cgi?id=25027>
+
+ When dealing with negative numbers, parseInt should use ceil instead of floor.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt):
+
+2009-04-16 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size
+
+ Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit. Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.
+
+ * create_hash_table:
+ * runtime/Lookup.cpp:
+ (JSC::HashTable::createTable):
+ (JSC::HashTable::deleteTable):
+ * runtime/Lookup.h:
+ (JSC::HashEntry::initialize):
+ (JSC::HashEntry::next):
+ (JSC::HashTable::entry):
+ * runtime/Structure.cpp:
+ (JSC::Structure::getEnumerableNamesFromClassInfoTable):
+
+2009-04-16 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix subtle error in optimised VM reentry in Array.sort
+
+ Basically to ensure we don't accidentally invalidate the cached callframe
+ we should be using the cached callframe rather than our own exec state.
+ While the old behaviour was wrong i have been unable to actually create a
+ test case where anything actually ends up going wrong.
+
+ * interpreter/CachedCall.h:
+ (JSC::CachedCall::newCallFrame):
+ * runtime/JSArray.cpp:
+ (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
+
+2009-04-16 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Optimise op_resolve_base
+
+ If we can statically find a property we are trying to resolve
+ the base of, the base is guaranteed to be the global object.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitResolveBase):
+
+2009-04-16 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve performance of read-write-modify operators
+
+ Implement cross scope optimisation for read-write-modify
+ operators, to avoid unnecessary calls to property resolve
+ helper functions.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::emitLoadGlobalObject):
+ (JSC::BytecodeGenerator::emitResolveWithBase):
+ * bytecompiler/BytecodeGenerator.h:
+
+2009-04-16 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve performance of remaining array enumeration functions
+
+ Make use of function entry cache for remaining Array enumeration functions.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+
+2009-04-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve performance of Array.sort
+
+ Cache the VM entry for Array.sort when using a JS comparison function.
+
+ * runtime/JSArray.cpp:
+ (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
+ (JSC::JSArray::sort):
+
+2009-04-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 25229: Need support for Array.prototype.reduceRight
+ <https://bugs.webkit.org/show_bug.cgi?id=25229>
+
+ Implement Array.reduceRight
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncReduceRight):
+
+2009-04-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 25227: Array.filter triggers an assertion when the target array shrinks while being filtered
+ <https://bugs.webkit.org/show_bug.cgi?id=25227>
+
+ We correct this simply by making the fast array path fall back on the slow path if
+ we ever discover the fast access is unsafe.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncFilter):
+
+2009-04-13 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 25159: Support Array.prototype.reduce
+ <https://bugs.webkit.org/show_bug.cgi?id=25159>
+
+ Implement Array.prototype.reduce
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncReduce):
+
+2009-04-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Move CallFrameClosure from inside the Interpreter class to its own file.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/CachedCall.h:
+ * interpreter/CallFrameClosure.h: Copied from JavaScriptCore/yarr/RegexJIT.h.
+ (JSC::CallFrameClosure::setArgument):
+ (JSC::CallFrameClosure::resetCallFrame):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::prepareForRepeatCall):
+ * interpreter/Interpreter.h:
+
+2009-04-14 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 25202: Improve performance of repeated callbacks into the VM
+
+ Add the concept of a CachedCall to native code for use in Array
+ prototype and similar functions where a single callback function
+ is called repeatedly with the same number of arguments.
+
+ Used Array.prototype.filter as the test function and got a 50% win
+ over a naive non-caching specialised version. This makes the native
+ implementation of Array.prototype.filter faster than the JS one once
+ more.
+
+ * JavaScriptCore.vcproj/JavaScriptCore.sln:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/CachedCall.h: Added.
+ (JSC::CachedCall::CachedCall):
+ (JSC::CachedCall::call):
+ (JSC::CachedCall::setThis):
+ (JSC::CachedCall::setArgument):
+ (JSC::CachedCall::~CachedCall):
+ CachedCall is a wrapper that automates the calling and teardown
+ for a CallFrameClosure
+ * interpreter/CallFrame.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::prepareForRepeatCall):
+ Create the basic entry closure for a function
+ (JSC::Interpreter::execute):
+ A new ::execute method to enter the interpreter from a closure
+ (JSC::Interpreter::endRepeatCall):
+ Clear the entry closure
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::CallFrameClosure::setArgument):
+ (JSC::Interpreter::CallFrameClosure::resetCallFrame):
+ Helper functions to simplify setting up the closure's callframe
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncFilter):
+
+2009-04-14 Xan Lopez <xlopez@igalia.com>
+
+ Fix the build.
+
+ Add the yarr headers (and only the headers) to the build, so that
+ RegExp.cpp can compile. The headers are ifdefed out with yarr
+ disabled, so we don't need anything else for now.
+
+ * GNUmakefile.am:
+
+2009-04-14 Adam Roben <aroben@apple.com>
+
+ Remove support for profile-guided optimization on Windows
+
+ Rubber-stamped by Steve Falkenburg.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed
+ the Release_PGO configuration. Also let VS re-order the source files
+ list.
+
+2009-04-14 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ * GNUmakefile.am:
+
+2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix when building minidom. Not reviewed.
+
+ Use C-style comment instead of C++ style since autotools builds
+ minidom using gcc and not g++.
+
+ * wtf/Platform.h:
+
+2009-04-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by NOBODY - speculative build fix.
+
+ * runtime/RegExp.h:
+
+2009-04-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cap'n Geoff Garen.
+
+ Yarr!
+ (Yet another regex runtime).
+
+ Currently disabled by default since the interpreter, whilst awesomely
+ functional, has not been optimized and is likely slower than PCRE, and
+ the JIT, whilst faster than WREC, is presently incomplete and does not
+ fallback to using an interpreter for the cases it cannot handle.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::move):
+ (JSC::MacroAssemblerX86Common::swap):
+ (JSC::MacroAssemblerX86Common::signExtend32ToPtr):
+ (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
+ (JSC::MacroAssemblerX86Common::branch32):
+ (JSC::MacroAssemblerX86Common::branch16):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::cmpw_im):
+ (JSC::X86Assembler::testw_rr):
+ (JSC::X86Assembler::X86InstructionFormatter::immediate16):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::~RegExp):
+ (JSC::RegExp::create):
+ (JSC::RegExp::compile):
+ (JSC::RegExp::match):
+ * runtime/RegExp.h:
+ * wtf/Platform.h:
+ * yarr: Added.
+ * yarr/RegexCompiler.cpp: Added.
+ (JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
+ (JSC::Yarr::CharacterClassConstructor::reset):
+ (JSC::Yarr::CharacterClassConstructor::append):
+ (JSC::Yarr::CharacterClassConstructor::putChar):
+ (JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
+ (JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
+ (JSC::Yarr::CharacterClassConstructor::putRange):
+ (JSC::Yarr::CharacterClassConstructor::charClass):
+ (JSC::Yarr::CharacterClassConstructor::addSorted):
+ (JSC::Yarr::CharacterClassConstructor::addSortedRange):
+ (JSC::Yarr::newlineCreate):
+ (JSC::Yarr::digitsCreate):
+ (JSC::Yarr::spacesCreate):
+ (JSC::Yarr::wordcharCreate):
+ (JSC::Yarr::nondigitsCreate):
+ (JSC::Yarr::nonspacesCreate):
+ (JSC::Yarr::nonwordcharCreate):
+ (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor):
+ (JSC::Yarr::RegexPatternConstructor::~RegexPatternConstructor):
+ (JSC::Yarr::RegexPatternConstructor::reset):
+ (JSC::Yarr::RegexPatternConstructor::assertionBOL):
+ (JSC::Yarr::RegexPatternConstructor::assertionEOL):
+ (JSC::Yarr::RegexPatternConstructor::assertionWordBoundary):
+ (JSC::Yarr::RegexPatternConstructor::atomPatternCharacter):
+ (JSC::Yarr::RegexPatternConstructor::atomBuiltInCharacterClass):
+ (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBegin):
+ (JSC::Yarr::RegexPatternConstructor::atomCharacterClassAtom):
+ (JSC::Yarr::RegexPatternConstructor::atomCharacterClassRange):
+ (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBuiltIn):
+ (JSC::Yarr::RegexPatternConstructor::atomCharacterClassEnd):
+ (JSC::Yarr::RegexPatternConstructor::atomParenthesesSubpatternBegin):
+ (JSC::Yarr::RegexPatternConstructor::atomParentheticalAssertionBegin):
+ (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
+ (JSC::Yarr::RegexPatternConstructor::atomBackReference):
+ (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
+ (JSC::Yarr::RegexPatternConstructor::copyTerm):
+ (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
+ (JSC::Yarr::RegexPatternConstructor::disjunction):
+ (JSC::Yarr::RegexPatternConstructor::regexBegin):
+ (JSC::Yarr::RegexPatternConstructor::regexEnd):
+ (JSC::Yarr::RegexPatternConstructor::regexError):
+ (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
+ (JSC::Yarr::RegexPatternConstructor::setupDisjunctionOffsets):
+ (JSC::Yarr::RegexPatternConstructor::setupOffsets):
+ (JSC::Yarr::compileRegex):
+ * yarr/RegexCompiler.h: Added.
+ * yarr/RegexInterpreter.cpp: Added.
+ (JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
+ (JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
+ (JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
+ (JSC::Yarr::Interpreter::DisjunctionContext::operator new):
+ (JSC::Yarr::Interpreter::allocDisjunctionContext):
+ (JSC::Yarr::Interpreter::freeDisjunctionContext):
+ (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
+ (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
+ (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
+ (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
+ (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
+ (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
+ (JSC::Yarr::Interpreter::InputStream::InputStream):
+ (JSC::Yarr::Interpreter::InputStream::next):
+ (JSC::Yarr::Interpreter::InputStream::rewind):
+ (JSC::Yarr::Interpreter::InputStream::read):
+ (JSC::Yarr::Interpreter::InputStream::readChecked):
+ (JSC::Yarr::Interpreter::InputStream::reread):
+ (JSC::Yarr::Interpreter::InputStream::prev):
+ (JSC::Yarr::Interpreter::InputStream::getPos):
+ (JSC::Yarr::Interpreter::InputStream::setPos):
+ (JSC::Yarr::Interpreter::InputStream::atStart):
+ (JSC::Yarr::Interpreter::InputStream::atEnd):
+ (JSC::Yarr::Interpreter::InputStream::checkInput):
+ (JSC::Yarr::Interpreter::InputStream::uncheckInput):
+ (JSC::Yarr::Interpreter::testCharacterClass):
+ (JSC::Yarr::Interpreter::tryConsumeCharacter):
+ (JSC::Yarr::Interpreter::checkCharacter):
+ (JSC::Yarr::Interpreter::tryConsumeCharacterClass):
+ (JSC::Yarr::Interpreter::checkCharacterClass):
+ (JSC::Yarr::Interpreter::tryConsumeBackReference):
+ (JSC::Yarr::Interpreter::matchAssertionBOL):
+ (JSC::Yarr::Interpreter::matchAssertionEOL):
+ (JSC::Yarr::Interpreter::matchAssertionWordBoundary):
+ (JSC::Yarr::Interpreter::matchPatternCharacter):
+ (JSC::Yarr::Interpreter::backtrackPatternCharacter):
+ (JSC::Yarr::Interpreter::matchCharacterClass):
+ (JSC::Yarr::Interpreter::backtrackCharacterClass):
+ (JSC::Yarr::Interpreter::matchBackReference):
+ (JSC::Yarr::Interpreter::backtrackBackReference):
+ (JSC::Yarr::Interpreter::recordParenthesesMatch):
+ (JSC::Yarr::Interpreter::resetMatches):
+ (JSC::Yarr::Interpreter::resetAssertionMatches):
+ (JSC::Yarr::Interpreter::parenthesesDoBacktrack):
+ (JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
+ (JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
+ (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
+ (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
+ (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceBegin):
+ (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceEnd):
+ (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceBegin):
+ (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceEnd):
+ (JSC::Yarr::Interpreter::matchParentheses):
+ (JSC::Yarr::Interpreter::backtrackParentheses):
+ (JSC::Yarr::Interpreter::matchTerm):
+ (JSC::Yarr::Interpreter::backtrackTerm):
+ (JSC::Yarr::Interpreter::matchAlternative):
+ (JSC::Yarr::Interpreter::matchDisjunction):
+ (JSC::Yarr::Interpreter::matchNonZeroDisjunction):
+ (JSC::Yarr::Interpreter::interpret):
+ (JSC::Yarr::Interpreter::Interpreter):
+ (JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
+ (JSC::Yarr::ByteCompiler::ByteCompiler):
+ (JSC::Yarr::ByteCompiler::compile):
+ (JSC::Yarr::ByteCompiler::checkInput):
+ (JSC::Yarr::ByteCompiler::assertionBOL):
+ (JSC::Yarr::ByteCompiler::assertionEOL):
+ (JSC::Yarr::ByteCompiler::assertionWordBoundary):
+ (JSC::Yarr::ByteCompiler::atomPatternCharacter):
+ (JSC::Yarr::ByteCompiler::atomCharacterClass):
+ (JSC::Yarr::ByteCompiler::atomBackReference):
+ (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
+ (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
+ (JSC::Yarr::ByteCompiler::popParenthesesStack):
+ (JSC::Yarr::ByteCompiler::dumpDisjunction):
+ (JSC::Yarr::ByteCompiler::closeAlternative):
+ (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
+ (JSC::Yarr::ByteCompiler::regexBegin):
+ (JSC::Yarr::ByteCompiler::regexEnd):
+ (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
+ (JSC::Yarr::ByteCompiler::emitDisjunction):
+ (JSC::Yarr::byteCompileRegex):
+ (JSC::Yarr::interpretRegex):
+ * yarr/RegexInterpreter.h: Added.
+ (JSC::Yarr::ByteTerm::):
+ (JSC::Yarr::ByteTerm::ByteTerm):
+ (JSC::Yarr::ByteTerm::BOL):
+ (JSC::Yarr::ByteTerm::CheckInput):
+ (JSC::Yarr::ByteTerm::EOL):
+ (JSC::Yarr::ByteTerm::WordBoundary):
+ (JSC::Yarr::ByteTerm::BackReference):
+ (JSC::Yarr::ByteTerm::AlternativeBegin):
+ (JSC::Yarr::ByteTerm::AlternativeDisjunction):
+ (JSC::Yarr::ByteTerm::AlternativeEnd):
+ (JSC::Yarr::ByteTerm::PatternEnd):
+ (JSC::Yarr::ByteTerm::invert):
+ (JSC::Yarr::ByteTerm::capture):
+ (JSC::Yarr::ByteDisjunction::ByteDisjunction):
+ (JSC::Yarr::BytecodePattern::BytecodePattern):
+ (JSC::Yarr::BytecodePattern::~BytecodePattern):
+ * yarr/RegexJIT.cpp: Added.
+ (JSC::Yarr::RegexGenerator::optimizeAlternative):
+ (JSC::Yarr::RegexGenerator::matchCharacterClassRange):
+ (JSC::Yarr::RegexGenerator::matchCharacterClass):
+ (JSC::Yarr::RegexGenerator::jumpIfNoAvailableInput):
+ (JSC::Yarr::RegexGenerator::jumpIfAvailableInput):
+ (JSC::Yarr::RegexGenerator::checkInput):
+ (JSC::Yarr::RegexGenerator::atEndOfInput):
+ (JSC::Yarr::RegexGenerator::notAtEndOfInput):
+ (JSC::Yarr::RegexGenerator::jumpIfCharEquals):
+ (JSC::Yarr::RegexGenerator::jumpIfCharNotEquals):
+ (JSC::Yarr::RegexGenerator::readCharacter):
+ (JSC::Yarr::RegexGenerator::storeToFrame):
+ (JSC::Yarr::RegexGenerator::loadFromFrame):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::alternativeValid):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::nextAlternative):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::alternative):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::termValid):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::nextTerm):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::term):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::lookaheadTerm):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::inputOffset):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
+ (JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackGenerated):
+ (JSC::Yarr::RegexGenerator::jumpToBacktrackCheckEmitPending):
+ (JSC::Yarr::RegexGenerator::genertateAssertionBOL):
+ (JSC::Yarr::RegexGenerator::genertateAssertionEOL):
+ (JSC::Yarr::RegexGenerator::matchAssertionWordchar):
+ (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy):
+ (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy):
+ (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy):
+ (JSC::Yarr::RegexGenerator::generateParenthesesSingleDisjunctionOneAlternative):
+ (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
+ (JSC::Yarr::RegexGenerator::generateTerm):
+ (JSC::Yarr::RegexGenerator::generateDisjunction):
+ (JSC::Yarr::RegexGenerator::RegexGenerator):
+ (JSC::Yarr::RegexGenerator::generate):
+ (JSC::Yarr::jitCompileRegex):
+ (JSC::Yarr::executeRegex):
+ * yarr/RegexJIT.h: Added.
+ (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
+ * yarr/RegexParser.h: Added.
+ (JSC::Yarr::):
+ (JSC::Yarr::Parser::):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacterUnescaped):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::end):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::flush):
+ (JSC::Yarr::Parser::CharacterClassParserDelegate::):
+ (JSC::Yarr::Parser::Parser):
+ (JSC::Yarr::Parser::parseEscape):
+ (JSC::Yarr::Parser::parseAtomEscape):
+ (JSC::Yarr::Parser::parseCharacterClassEscape):
+ (JSC::Yarr::Parser::parseCharacterClass):
+ (JSC::Yarr::Parser::parseParenthesesBegin):
+ (JSC::Yarr::Parser::parseParenthesesEnd):
+ (JSC::Yarr::Parser::parseQuantifier):
+ (JSC::Yarr::Parser::parseTokens):
+ (JSC::Yarr::Parser::parse):
+ (JSC::Yarr::Parser::saveState):
+ (JSC::Yarr::Parser::restoreState):
+ (JSC::Yarr::Parser::atEndOfPattern):
+ (JSC::Yarr::Parser::peek):
+ (JSC::Yarr::Parser::peekIsDigit):
+ (JSC::Yarr::Parser::peekDigit):
+ (JSC::Yarr::Parser::consume):
+ (JSC::Yarr::Parser::consumeDigit):
+ (JSC::Yarr::Parser::consumeNumber):
+ (JSC::Yarr::Parser::consumeOctal):
+ (JSC::Yarr::Parser::tryConsume):
+ (JSC::Yarr::Parser::tryConsumeHex):
+ (JSC::Yarr::parse):
+ * yarr/RegexPattern.h: Added.
+ (JSC::Yarr::CharacterRange::CharacterRange):
+ (JSC::Yarr::):
+ (JSC::Yarr::PatternTerm::):
+ (JSC::Yarr::PatternTerm::PatternTerm):
+ (JSC::Yarr::PatternTerm::BOL):
+ (JSC::Yarr::PatternTerm::EOL):
+ (JSC::Yarr::PatternTerm::WordBoundary):
+ (JSC::Yarr::PatternTerm::invert):
+ (JSC::Yarr::PatternTerm::capture):
+ (JSC::Yarr::PatternTerm::quantify):
+ (JSC::Yarr::PatternAlternative::PatternAlternative):
+ (JSC::Yarr::PatternAlternative::lastTerm):
+ (JSC::Yarr::PatternAlternative::removeLastTerm):
+ (JSC::Yarr::PatternDisjunction::PatternDisjunction):
+ (JSC::Yarr::PatternDisjunction::~PatternDisjunction):
+ (JSC::Yarr::PatternDisjunction::addNewAlternative):
+ (JSC::Yarr::RegexPattern::RegexPattern):
+ (JSC::Yarr::RegexPattern::~RegexPattern):
+ (JSC::Yarr::RegexPattern::reset):
+ (JSC::Yarr::RegexPattern::containsIllegalBackReference):
+ (JSC::Yarr::RegexPattern::newlineCharacterClass):
+ (JSC::Yarr::RegexPattern::digitsCharacterClass):
+ (JSC::Yarr::RegexPattern::spacesCharacterClass):
+ (JSC::Yarr::RegexPattern::wordcharCharacterClass):
+ (JSC::Yarr::RegexPattern::nondigitsCharacterClass):
+ (JSC::Yarr::RegexPattern::nonspacesCharacterClass):
+ (JSC::Yarr::RegexPattern::nonwordcharCharacterClass):
+
+2009-04-13 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Missed code from last patch).
+
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::displayName):
+ (JSC::InternalFunction::calculatedDisplayName):
+ * runtime/InternalFunction.h:
+
+2009-04-13 Francisco Tolmasky <francisco@280north.com>
+
+ Reviewed by Oliver Hunt.
+
+ BUG 25171: It should be possible to manually set the name of an anonymous function
+ <https://bugs.webkit.org/show_bug.cgi?id=25171>
+
+ This change adds the displayName property to functions, which when set overrides the
+ normal name when appearing in the console.
+
+ * profiler/Profiler.cpp:
+ (JSC::createCallIdentifierFromFunctionImp): Changed call to InternalFunction::name to InternalFunction::calculatedDisplayName
+ * runtime/CommonIdentifiers.h: Added displayName common identifier.
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::displayName): Access to user settable displayName property
+ (JSC::InternalFunction::calculatedDisplayName): Returns displayName if it exists, if not then the natural name
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Disabled another JavaScriptCore test because it fails on Windows but
+ not Mac, so it makes the bots red.
+
+ * tests/mozilla/expected.html:
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Disabled two JavaScriptCore tests because they fail on Window or Mac but
+ not both, so they make the bots red.
+
+ * tests/mozilla/expected.html: Updated expected results.
+
+2009-04-09 Ben Murdoch <benm@google.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25091
+ The Android platform requires threads to be registered with the VM.
+ This patch implements this behaviour inside ThreadingPthreads.cpp.
+
+ * wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM.
+ (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards.
+ (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly.
+
+2009-04-09 David Kilzer <ddkilzer@apple.com>
+
+ Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
+
+ Rolled r42345 back in. The build failure was caused by an
+ internal script which had not been updated the same way that
+ build-webkit was updated.
+
+ * Configurations/JavaScriptCore.xcconfig:
+
+2009-04-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
+ It broke Mac build, and I don't know how to fix it.
+
+ * Configurations/JavaScriptCore.xcconfig:
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ Checking for __GLIBCXX__ being bigger than some date is not enough
+ to get std::tr1, C++0x has to be in use too. Add another check for
+ __GXX_EXPERIMENTAL_CXX0X__.
+
+ * wtf/TypeTraits.h:
+
+2009-04-08 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Fix assertion failure in function.apply
+
+ The result of excess arguments to function.apply is irrelevant
+ so we don't need to provide a result register. We were providing
+ temporary result register but not ref'ing it resulting in an
+ assertion failure.
+
+ * parser/Nodes.cpp:
+ (JSC::ApplyFunctionCallDotNode::emitBytecode):
+
+2009-04-08 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
+
+ Reviewed by Darin Adler and Maciej Stachowiak.
+
+ Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
+ that SVG DOM Objective-C bindings may be optionally disabled.
+
+ * Configurations/JavaScriptCore.xcconfig: Added
+ ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in
+ FEATURE_DEFINES.
+
+2009-04-08 Paul Pedriana <ppedriana@ea.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20422
+ Allow custom memory allocation control.
+
+ * wtf/FastAllocBase.h:
+ New added file. Implements allocation base class.
+ * wtf/TypeTraits.h:
+ Augments existing type traits support as needed by FastAllocBase.
+ * wtf/FastMalloc.h:
+ Changed to support FastMalloc match validation.
+ * wtf/FastMalloc.cpp:
+ Changed to support FastMalloc match validation.
+ * wtf/Platform.h:
+ Added ENABLE_FAST_MALLOC_MATCH_VALIDATION; defaults to 0.
+ * GNUmakefile.am:
+ Updated to include added FastAllocBase.h.
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Updated to include added FastAllocBase.h.
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ Updated to include added FastAllocBase.h.
+
+2009-04-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Improve function.apply performance
+
+ Jump through a few hoops to improve performance of function.apply in the general case.
+
+ In the case of zero or one arguments, or if there are only two arguments and the
+ second is an array literal we treat function.apply as function.call.
+
+ Otherwise we use the new opcodes op_load_varargs and op_call_varargs to do the .apply call
+ without re-entering the virtual machine.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/Opcode.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
+ (JSC::BytecodeGenerator::emitLoadVarargs):
+ (JSC::BytecodeGenerator::emitCallVarargs):
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCallVarargsSetupArgs):
+ (JSC::JIT::compileOpCallVarargs):
+ (JSC::JIT::compileOpCallVarargsSlowCase):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_load_varargs):
+ * jit/JITStubs.h:
+ * parser/Grammar.y:
+ * parser/Nodes.cpp:
+ (JSC::ArrayNode::isSimpleArray):
+ (JSC::ArrayNode::toArgumentList):
+ (JSC::CallFunctionCallDotNode::emitBytecode):
+ (JSC::ApplyFunctionCallDotNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::):
+ (JSC::ApplyFunctionCallDotNode::):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::copyToRegisters):
+ (JSC::Arguments::fillArgList):
+ * runtime/Arguments.h:
+ (JSC::Arguments::numProvidedArguments):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::addFunctionProperties):
+ * runtime/FunctionPrototype.h:
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::copyToRegisters):
+ * runtime/JSArray.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::mark):
+ * runtime/JSGlobalObject.h:
+
+2009-04-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25073
+ JavaScriptCore tests don't run if time zone is not PST
+
+ * API/tests/testapi.c:
+ (timeZoneIsPST): Added a function that checks whether the time zone is PST, using the same
+ method as functions in DateMath.cpp do for formatting the result.
+ (main): Skip date string format test if the time zone is not PST.
+
+2009-04-07 David Levin <levin@chromium.org>
+
+ Reviewed by Sam Weinig and Geoff Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25039
+ UString refactoring to support UChar* sharing.
+
+ No change in sunspider perf.
+
+ * runtime/SmallStrings.cpp:
+ (JSC::SmallStringsStorage::SmallStringsStorage):
+ * runtime/UString.cpp:
+ (JSC::initializeStaticBaseString):
+ (JSC::initializeUString):
+ (JSC::UString::BaseString::isShared):
+ Encapsulate the meaning behind the refcount == 1 checks because
+ this needs to do slightly more when sharing is added.
+ (JSC::concatenate):
+ (JSC::UString::append):
+ (JSC::UString::operator=):
+ * runtime/UString.h:
+ Make m_baseString part of a union to get rid of casts, but make it protected because
+ it is tricky to use it correctly since it is only valid when the Rep is not a BaseString.
+ The void* will be filled in when sharing is added.
+
+ Add constructors due to the making members protected and it make ensuring proper
+ initialization work better (like in SmallStringsStorage).
+ (JSC::UString::Rep::create):
+ (JSC::UString::Rep::Rep):
+ (JSC::UString::Rep::):
+ (JSC::UString::BaseString::BaseString):
+ (JSC::UString::Rep::setBaseString):
+ (JSC::UString::Rep::baseString):
+
+2009-04-04 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25033
+ dtoa.cpp segfaults with g++ 4.4.0
+
+ g++ 4.4.0 seems to be more strict about aliasing rules, so it
+ produces incorrect code if dtoa.cpp is compiled with
+ -fstrict-aliasing (it also emits a ton of warnings, so fair enough
+ I guess). The problem was that we were only casting variables to
+ union types in order to do type punning, but GCC and the C
+ standard require that we actually use a union to store the value.
+
+ This patch does just that, the code is mostly copied from the dtoa
+ version in GCC:
+ http://gcc.gnu.org/viewcvs/trunk/libjava/classpath/native/fdlibm/dtoa.c?view=markup.
+
+ * wtf/dtoa.cpp:
+ (WTF::ulp):
+ (WTF::b2d):
+ (WTF::ratio):
+ (WTF::hexnan):
+ (WTF::strtod):
+ (WTF::dtoa):
+
+2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix for Win port. Build the assembler sources to get missing functions.
+
+ * JavaScriptCoreSources.bkl:
+ * jscore.bkl:
+ * wtf/Platform.h:
+
+2009-04-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ <rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer
+
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize
+ callFunction as we do the other data members that are used in the mark function.
+
+2009-04-02 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann
+
+ https://bugs.webkit.org/show_bug.cgi?id=24490
+
+ Implement WTF::ThreadSpecific in the Qt build using
+ QThreadStorage.
+
+ * wtf/ThreadSpecific.h:
+
+2009-04-01 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24990
+ Put SECTORDER_FLAGS into xcconfig files.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2009-03-27 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix non-AllInOneFile builds.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+
+2009-03-27 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve performance of Function.prototype.call
+ <https://bugs.webkit.org/show_bug.cgi?id=24907>
+
+ Optimistically assume that expression.call(..) is going to be a call to
+ Function.prototype.call, and handle it specially to attempt to reduce the
+ degree of VM reentrancy.
+
+ When everything goes right this removes the vm reentry improving .call()
+ by around a factor of 10.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/Opcode.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * parser/Grammar.y:
+ * parser/Nodes.cpp:
+ (JSC::CallFunctionCallDotNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::CallFunctionCallDotNode::):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::addFunctionProperties):
+ * runtime/FunctionPrototype.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::mark):
+ * runtime/JSGlobalObject.h:
+
+2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 24884: Include strings.h for strcasecmp()
+ https://bugs.webkit.org/show_bug.cgi?id=24884
+
+ * runtime/DateMath.cpp: Reversed previous change including strings.h
+ * wtf/StringExtras.h: Include strings.h here is available
+
+2009-03-26 Adam Roben <aroben@apple.com>
+
+ Copy testapi.js to $WebKitOutputDir on Windows
+
+ Part of Bug 24856: run-javascriptcore-tests should run testapi on
+ Windows
+ <https://bugs.webkit.org/show_bug.cgi?id=24856>
+
+ This matches what Mac does, which will help once we enable running
+ testapi from run-javascriptcore-tests on Windows.
+
+ Reviewed by Steve Falkenburg.
+
+ * JavaScriptCore.vcproj/testapi/testapi.vcproj: Copy testapi.js next
+ to testapi.exe.
+
+2009-03-25 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix exception handling for instanceof in the interpreter.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+
+2009-03-25 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed <rdar://problem/6724011> Write to freed memory in JSC::Label::deref
+ when reloading http://helpme.att.net/speedtest/
+
+ * bytecompiler/BytecodeGenerator.h: Reversed the declaration order for
+ m_labelScopes and m_labels to reverse their destruction order.
+ m_labelScopes has references to memory within m_labels, so its destructor
+ needs to run first.
+
+2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Correct warnings which in some environments are treated as errors.
+
+ * wtf/dtoa.cpp:
+ (WTF::b2d):
+ (WTF::d2b):
+ (WTF::strtod):
+ (WTF::dtoa):
+
+2009-03-24 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Darin Adler.
+
+ Explicitly define HAVE_LANGINFO_H on Darwin. Fixes the wx build bot jscore
+ test failure.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24780
+
+ * wtf/Platform.h:
+
+2009-03-23 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix className() for API defined class
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::className):
+ * API/tests/testapi.c:
+ (EmptyObject_class):
+ (main):
+ * API/tests/testapi.js:
+
+2009-03-23 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Make testapi assertions run in release builds, so that testapi actually
+ works in a release build.
+
+ Many of the testapi assertions have side effects that are necessary, and
+ given testapi is a testing program, perf impact of an assertion is not
+ important, so it makes sense to apply the assertions in release builds
+ anyway.
+
+ * API/tests/testapi.c:
+ (EvilExceptionObject_hasInstance):
+
+2009-03-23 David Kilzer <ddkilzer@apple.com>
+
+ Provide JavaScript exception information after slow script timeout
+
+ Reviewed by Oliver Hunt.
+
+ * runtime/Completion.cpp:
+ (JSC::evaluate): Set the exception object as the Completion
+ object's value for slow script timeouts. This is used in
+ WebCore when reporting the exception.
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::InterruptedExecutionError::toString): Added. Provides a
+ description message for the exception when it is reported.
+
+2009-03-23 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24674
+ Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations
+
+ Make sure strftime never returns 2-digits years to avoid ambiguity
+ and a crash. We wrap this new code option in HAVE_LANGINFO_H,
+ since it is apparently not available in all platforms.
+
+ * runtime/DatePrototype.cpp:
+ (JSC::formatLocaleDate):
+ * wtf/Platform.h:
+
+2009-03-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix exception handling in API
+
+ We can't just use the ExecState exception slot for returning exceptions
+ from class introspection functions provided through the API as many JSC
+ functions will explicitly clear the ExecState exception when returning.
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::JSCallbackObject<Base>::getOwnPropertySlot):
+ (JSC::JSCallbackObject<Base>::put):
+ (JSC::JSCallbackObject<Base>::deleteProperty):
+ (JSC::JSCallbackObject<Base>::construct):
+ (JSC::JSCallbackObject<Base>::hasInstance):
+ (JSC::JSCallbackObject<Base>::call):
+ (JSC::JSCallbackObject<Base>::toNumber):
+ (JSC::JSCallbackObject<Base>::toString):
+ (JSC::JSCallbackObject<Base>::staticValueGetter):
+ (JSC::JSCallbackObject<Base>::callbackGetter):
+ * API/tests/testapi.c:
+ (MyObject_hasProperty):
+ (MyObject_getProperty):
+ (MyObject_setProperty):
+ (MyObject_deleteProperty):
+ (MyObject_callAsFunction):
+ (MyObject_callAsConstructor):
+ (MyObject_hasInstance):
+ (EvilExceptionObject_hasInstance):
+ (EvilExceptionObject_convertToType):
+ (EvilExceptionObject_class):
+ (main):
+ * API/tests/testapi.js:
+ (EvilExceptionObject.hasInstance):
+ (EvilExceptionObject.toNumber):
+ (EvilExceptionObject.toStringExplicit):
+
+2009-03-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20049: testapi failure: MyObject - 0 should be NaN but instead is 1.
+ <https://bugs.webkit.org/show_bug.cgi?id=20049>
+ <rdar://problem/6079127>
+
+ In this case, the test is wrong. According to the ECMA spec, subtraction
+ uses ToNumber, not ToPrimitive. Change the test to match the spec.
+
+ * API/tests/testapi.js:
+
+2009-03-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Ensure that JSObjectMakeFunction doesn't produce incorrect line numbers.
+
+ Also make test api correctly propagate failures.
+
+ * API/tests/testapi.c:
+ (main):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+
+2009-03-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Improve testapi by making it report failures in a way we can pick up
+ from our test scripts.
+
+ * API/tests/testapi.c:
+ (assertEqualsAsBoolean):
+ (assertEqualsAsNumber):
+ (assertEqualsAsUTF8String):
+ (assertEqualsAsCharactersPtr):
+ (main):
+ * API/tests/testapi.js:
+ (pass):
+ (fail):
+ (shouldBe):
+ (shouldThrow):
+
+2009-03-20 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24535
+
+ Fixes missing line terminator character (;) after macro call.
+ It is common practice to add the trailing ";" where macros are substituted
+ and not where they are defined with #define.
+ This change is consistent with other macro declarations across webkit,
+ and it also solves compilation failure with symbian compilers.
+
+ * runtime/UString.cpp:
+ * wtf/Assertions.h:
+
+2009-03-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed a JavaScriptCore crash on the Windows buildbot.
+
+ * bytecompiler/BytecodeGenerator.h: Reduced the AST recursion limit.
+ Apparently, Windows has small stacks.
+
+2009-03-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ A little cleanup in the RegisterFile code.
+
+ Moved large inline functions out of the class declaration, to make it
+ more readable.
+
+ Switched over to using the roundUpAllocationSize function to avoid
+ duplicate code and subtle bugs.
+
+ Renamed m_maxCommitted to m_commitEnd, to match m_end.
+
+ Renamed allocationSize to commitSize because it's the chunk size for
+ committing memory, not allocating memory.
+
+ SunSpider reports no change.
+
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ (JSC::RegisterFile::shrink):
+ (JSC::RegisterFile::grow):
+ * jit/ExecutableAllocator.h:
+ (JSC::roundUpAllocationSize):
+
+2009-03-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.
+
+ SunSpider reports no change. I also verified in the disassembly that
+ we end up with a single compare to constant.
+
+ * runtime/Collector.cpp:
+ (JSC::Heap::heapAllocate):
+
+2009-03-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich and Oliver Hunt.
+
+ Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
+ fast/workers/use-machine-stack.html (22531)
+
+ Dialed down the re-entry allowance to 64 (from 128).
+
+ On a 512K stack, this leaves about 64K for other code on the stack while
+ JavaScript is running. Not perfect, but it solves our crash on PPC.
+
+ Different platforms may want to dial this down even more.
+
+ Also, substantially shrunk BytecodeGenerator. Since we allocate one on
+ the stack in order to throw a stack overflow exception -- well, let's
+ just say the old code had an appreciation for irony.
+
+ SunSpider reports no change.
+
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.h:
+ (JSC::):
+
+2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 24350: REGRESSION: Safari 4 breaks SPAW wysiwyg editor multiple instances
+ <https://bugs.webkit.org/show_bug.cgi?id=24350>
+ <rdar://problem/6674182>
+
+ The SPAW editor's JavaScript assumes that toString() on a function
+ constructed with the Function constructor produces a function with
+ a newline after the opening brace.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction): Add a newline after the opening brace of the
+ function's source code.
+
+2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Geoff Garen.
+
+ Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
+ <https://bugs.webkit.org/show_bug.cgi?id=23771>
+ <rdar://problem/6561016>
+
+ * API/tests/testapi.c:
+ (main): Add a test for this bug.
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the
+ last object in the prototype chain to the object prototype when the
+ object prototype is already the last object in the prototype chain.
+
+2009-03-19 Timothy Hatcher <timothy@apple.com>
+
+ <rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers
+
+ Reviewed by Darin Adler.
+
+ * wtf/Platform.h: Added HAVE_RUNLOOP_TIMER for PLATFORM(MAC).
+
+2009-03-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixed <rdar://problem/6279213> Regular expression run-time complexity
+ limit too low for long inputs (21485)
+
+ I raised PCRE's "matchLimit" (limit on backtracking) by an order of
+ magnitude. This fixes all the reported examples of timing out on legitimate
+ regular expression matches.
+
+ In my testing on a Core Duo MacBook Pro, the longest you can get stuck
+ trying to match a string is still under 1s, so this seems like a safe change.
+
+ I can think of a number of better solutions that are more complicated,
+ but this is a good improvement for now.
+
+ * pcre/pcre_exec.cpp:
+
+2009-03-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
+ pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)
+
+ Bumped the pattern size limit to 1MB, and standardized it between PCRE
+ and WREC. (Empirical testing says that we can easily compile a 1MB regular
+ expression without risking a hang. Other browsers support bigger regular
+ expressions, but also hang.)
+
+ SunSpider reports no change.
+
+ I started with a patch posted to Bugzilla by Erik Corry (erikcorry@google.com).
+
+ * pcre/pcre_internal.h:
+ (put3ByteValue):
+ (get3ByteValue):
+ (put3ByteValueAndAdvance):
+ (putLinkValueAllowZero):
+ (getLinkValueAllowZero): Made PCRE's "LINK_SIZE" (the number of bytes
+ used to record jumps between bytecodes) 3, to accomodate larger potential
+ jumps. Bumped PCRE's "MAX_PATTERN_SIZE" to 1MB. (Technically, at this
+ LINK_SIZE, we can support even larger patterns, but we risk a hang during
+ compilation, and it's not clear that such large patterns are important
+ on the web.)
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp): Match PCRE's maximum pattern size,
+ to avoid quirks between platforms.
+
+2009-03-18 Ada Chan <adachan@apple.com>
+
+ Rolling out r41818 since it broke the windows build.
+ Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory
+
+ * runtime/DatePrototype.cpp:
+ (JSC::formatLocaleDate):
+
+2009-03-17 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ <rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
+ <https://bugs.webkit.org/show_bug.cgi?id=24654>
+
+ If the return value for a function is in a local register we need
+ to copy it before executing any finalisers, otherwise it is possible
+ for the finaliser to clobber the result.
+
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::hasFinaliser):
+ * parser/Nodes.cpp:
+ (JSC::ReturnNode::emitBytecode):
+
+2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Mark Rowe.
+
+ Move BUILDING_ON_* defines into Platform.h to make them available to other ports.
+ Also tweak the defines so that they work with the default values set by
+ AvailabilityMacros.h.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24630
+
+ * JavaScriptCorePrefix.h:
+ * wtf/Platform.h:
+
+2009-03-15 Simon Fraser <simon.fraser@apple.com>
+
+ Revert r41718 because it broke DumpRenderTree on Tiger.
+
+ * JavaScriptCorePrefix.h:
+ * wtf/Platform.h:
+
+2009-03-15 Kevin Ollivier <kevino@theolliviers.com>
+
+ Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
+ Platform.h so that they're defined for all ports building on Mac, and tweak
+ the definitions of those macros based on Mark Rowe's suggestions to accomodate
+ cases where the values may not be <= to the .0 release for that version.
+
+ * JavaScriptCorePrefix.h:
+ * wtf/Platform.h:
+
+2009-03-13 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Take advantage of the ability of recent versions of Xcode to easily switch the active
+ architecture.
+
+ * Configurations/DebugRelease.xcconfig:
+
+2009-03-13 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
+ switching between building in Xcode and via build-webkit.
+
+ build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
+ Derived Sources build settings. When building in Xcode, this setting isn't present so
+ Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
+ being generated, and the files that include it being rebuilt.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is
+ already newer than the input file.
+
+2009-03-13 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Resolved name conflict with globally defined tzname in Symbian.
+ Replaced with different name instead of using namespace qualifier
+ (appeared to be less clumsy).
+
+ * runtime/DateMath.cpp:
+
+2009-03-12 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages
+
+ * wtf/FastMalloc.cpp:
+ (WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
+ span as well so that the flag in the merged span is accurate.
+ * wtf/Platform.h:
+ * wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.
+ (TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
+ (TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.
+ * wtf/TCSystemAlloc.h:
+
+2009-03-12 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Include string.h for strlen usage.
+
+ * wtf/Threading.cpp:
+
+2009-03-12 David Kilzer <ddkilzer@apple.com>
+
+ Add NO_RETURN attribute to runInteractive() when not using readline
+
+ Reviewed by Darin Adler.
+
+ * jsc.cpp:
+ (runInteractive): If the readline library is not used, this method
+ will never return, thus the NO_RETURN attribute is needed to prevent
+ a gcc warning.
+
+2009-03-12 Adam Roben <aroben@apple.com>
+
+ Adopt setThreadNameInternal on Windows
+
+ Also changed a Windows-only assertion about thread name length to an
+ all-platform log message.
+
+ Reviewed by Adam Treat.
+
+ * wtf/Threading.cpp:
+ (WTF::createThread): Warn if the thread name is longer than 31
+ characters, as Visual Studio will truncate names longer than that
+ length.
+
+ * wtf/ThreadingWin.cpp:
+ (WTF::setThreadNameInternal): Renamed from setThreadName and changed
+ to always operate on the current thread.
+ (WTF::initializeThreading): Changed to use setThreadNameInternal.
+ (WTF::createThreadInternal): Removed call to setThreadName. This is
+ now handled by threadEntryPoint and setThreadNameInternal.
+
+2009-03-11 David Kilzer <ddkilzer@apple.com>
+
+ Clarify comments regarding order of FEATURE_DEFINES
+
+ Rubber-stamped by Mark Rowe.
+
+ * Configurations/JavaScriptCore.xcconfig: Added warning about
+ the consequences when FEATURE_DEFINES are not kept in sync.
+
+2009-03-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - WTF support for fixing <rdar://problem/3919124> Thai text selection
+ in Safari is incorrect
+
+ * wtf/unicode/icu/UnicodeIcu.h:
+ (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns
+ whether the character has Unicode line breaking property value SA
+ ("Complex Context").
+ * wtf/unicode/qt4/UnicodeQt4.h:
+ (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an
+ implementation that always returns false.
+
+2009-03-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Give threads names on platforms with pthread_setname_np.
+
+ * wtf/Threading.cpp:
+ (WTF::NewThreadContext::NewThreadContext): Initialize thread name.
+ (WTF::threadEntryPoint): Call setThreadNameInternal.
+ (WTF::createThread): Pass thread name.
+
+ * wtf/Threading.h: Added new comments, setThreadNameInternal.
+
+ * wtf/ThreadingGtk.cpp:
+ (WTF::setThreadNameInternal): Added. Empty.
+ * wtf/ThreadingNone.cpp:
+ (WTF::setThreadNameInternal): Added. Empty.
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::setThreadNameInternal): Call pthread_setname_np when available.
+ * wtf/ThreadingQt.cpp:
+ (WTF::setThreadNameInternal): Added. Empty.
+ * wtf/ThreadingWin.cpp:
+ (WTF::setThreadNameInternal): Added. Empty.
+
+2009-03-11 Adam Roben <aroben@apple.com>
+
+ Change the Windows implementation of ThreadSpecific to use functions
+ instead of extern globals
+
+ This will make it easier to export ThreadSpecific from WebKit.
+
+ Reviewed by John Sullivan.
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ Touched this file to force ThreadSpecific.h to be copied into
+ $WebKitOutputDir.
+
+ * wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount()
+ and g_tls_keys with tlsKeys().
+
+ (WTF::::ThreadSpecific):
+ (WTF::::~ThreadSpecific):
+ (WTF::::get):
+ (WTF::::set):
+ (WTF::::destroy):
+ Updated to use the new functions.
+
+ * wtf/ThreadSpecificWin.cpp:
+ (WTF::tlsKeyCount):
+ (WTF::tlsKeys):
+ Added.
+
+ (WTF::ThreadSpecificThreadExit): Changed to use the new functions.
+
+2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Geoff Garen.
+
+ Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
+ <https://bugs.webkit.org/show_bug.cgi?id=24291>
+ <rdar://problem/6663472>
+
+ Add an extra newline to the end of the body of the program text constructed
+ by the Function constructor for parsing. This allows single line comments to
+ be handled correctly by the parser.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+
+2009-03-09 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
+ <rdar://problem/6657774>
+
+ r41508 actually exposed a pre-existing bug where we were not invalidating the result
+ register cache at jump targets. This causes problems when condition loads occur in an
+ expression -- namely through the ?: and || operators. This patch corrects these issues
+ by marking the target of all forward jumps as being a jump target, and then clears the
+ result register cache when ever it starts generating code for a targeted instruction.
+
+ I do not believe it is possible to cause this class of failure outside of a single
+ expression, and expressions only provide forward branches, so this should resolve this
+ entire class of bug. That said i've included a test case that gets as close as possible
+ to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
+ problem in future.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::Label::isUsed):
+ (JSC::AbstractMacroAssembler::Label::used):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::JmpDst::JmpDst):
+ (JSC::X86Assembler::JmpDst::isUsed):
+ (JSC::X86Assembler::JmpDst::used):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-03-09 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23175: String and UString should be able to share a UChar* buffer.
+ <https://bugs.webkit.org/show_bug.cgi?id=23175>
+
+ Add CrossThreadRefCounted.
+
+ * wtf/CrossThreadRefCounted.h: Added.
+ (WTF::CrossThreadRefCounted::create):
+ (WTF::CrossThreadRefCounted::isShared):
+ (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe):
+ (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread):
+ (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
+ (WTF::CrossThreadRefCounted::~CrossThreadRefCounted):
+ (WTF::CrossThreadRefCounted::ref):
+ (WTF::CrossThreadRefCounted::deref):
+ (WTF::CrossThreadRefCounted::release):
+ (WTF::CrossThreadRefCounted::copy):
+ (WTF::CrossThreadRefCounted::threadSafeDeref):
+ * wtf/RefCounted.h:
+ * wtf/Threading.h:
+ (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase):
+ (WTF::ThreadSafeSharedBase::derefBase):
+ (WTF::ThreadSafeShared::ThreadSafeShared):
+ (WTF::ThreadSafeShared::deref):
+
+2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24353
+ Allow to overrule default build options for Qt build.
+
+ * JavaScriptCore.pri: Allow to overrule ENABLE_JIT
+
+2009-03-08 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (build fix).
+
+ Build fix.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncConcat):
+
+2009-03-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 24268: RuntimeArray is not a fully implemented JSArray
+ <https://bugs.webkit.org/show_bug.cgi?id=24268>
+
+ Don't cast a type to JSArray, just because it reportsArray as a supertype
+ in the JS type system. Doesn't appear feasible to create a testcase
+ unfortunately as setting up the failure conditions requires internal access
+ to JSC not present in DRT.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncConcat):
+
+2009-03-06 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ When preforming an op_mov, preserve any existing register mapping.
+
+ ~0.5% progression on v8 tests x86-64.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>
+
+ Bug 24382: request to add SH4 platform
+
+ <https://bugs.webkit.org/show_bug.cgi?id=24382>
+
+ Reviewed by David Kilzer.
+
+ * wtf/Platform.h: Added support for SH4 platform.
+
+2009-03-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Writes of constant values to SF registers should be made with direct memory
+ writes where possible, rather than moving the value via a hardware register.
+
+ ~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.
+
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::storePtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::movq_i32m):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-03-05 Mark Rowe <mrowe@apple.com>
+
+ Fix the build.
+
+ Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.
+
+ * runtime/NumberConstructor.cpp:
+ (JSC::numberConstructorNaNValue):
+ (JSC::numberConstructorNegInfinity):
+ (JSC::numberConstructorPosInfinity):
+ (JSC::numberConstructorMaxValue):
+ (JSC::numberConstructorMinValue):
+
+2009-03-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space
+
+ The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
+ to record the memory containing and individual span as an administrative region, when all memory
+ allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
+ via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
+ "MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.
+
+ Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
+ These two cases are handled differently.
+
+ PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
+ first object in an allocated region contains the link to the previously allocated region. To record
+ the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
+ each allocated region we encounter.
+
+ TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
+ the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
+ at each position rather than the nodes themselves.
+
+ A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
+ so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
+ range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
+ them with a single call. A similar approach is also used by AdminRegionRecorder.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::PageHeapAllocator::Init):
+ (WTF::PageHeapAllocator::New):
+ (WTF::PageHeapAllocator::recordAdministrativeRegions):
+ (WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
+ (WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
+ (WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
+ (WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
+ (WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
+ (WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
+ (WTF::TCMallocStats::AdminRegionRecorder::visit):
+ (WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
+ (WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
+ (WTF::TCMallocStats::FastMallocZone::enumerate):
+ (WTF::TCMallocStats::FastMallocZone::FastMallocZone):
+ (WTF::TCMallocStats::FastMallocZone::init):
+ * wtf/TCPageMap.h:
+ (TCMalloc_PageMap2::visitValues):
+ (TCMalloc_PageMap2::visitAllocations):
+ (TCMalloc_PageMap3::visitValues):
+ (TCMalloc_PageMap3::visitAllocations):
+
+2009-03-04 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24359
+ Repaint throttling mechanism
+
+ Set ENABLE_REPAINT_THROTTLING to 0 by default.
+
+ * wtf/Platform.h:
+
+2009-03-03 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
+
+ Reviewed by Mark Rowe.
+
+ * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based
+ on PLATFORM_NAME to work around the missing definition on Tiger.
+ Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.
+
+2009-03-03 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6639110> console.profile() doesn't work without a title
+
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::startProfiling): assert if there is not title to ensure
+ we don't start profiling without one.
+
+2009-03-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Enable Geolocation (except on Tiger and Leopard).
+
+ * Configurations/JavaScriptCore.xcconfig:
+
+2009-03-01 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig
+
+ Reviewed by Mark Rowe.
+
+ * Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable
+ based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define
+ it as a preprocessor macro by modifying
+ GCC_PREPROCESSOR_DEFINITIONS.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate
+ DTrace header" script phase to check for HAVE_DTRACE instead of
+ MACOSX_DEPLOYMENT_TARGET.
+ * wtf/Platform.h: Removed definition of HAVE_DTRACE macro since
+ it's defined in Base.xcconfig now.
+
+2009-03-01 Horia Olaru <olaru@adobe.com>
+
+ By looking in grammar.y there are only a few types of statement nodes
+ on which the debugger should stop.
+
+ Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
+ the "statementListEmitCode" method as long as the necessary hooks can be
+ added in each "emitCode".
+
+ https://bugs.webkit.org/show_bug.cgi?id=21073
+
+ Reviewed by Kevin McCullough.
+
+ * parser/Nodes.cpp:
+ (JSC::ConstStatementNode::emitBytecode):
+ (JSC::statementListEmitCode):
+ (JSC::EmptyStatementNode::emitBytecode):
+ (JSC::ExprStatementNode::emitBytecode):
+ (JSC::VarStatementNode::emitBytecode):
+ (JSC::IfNode::emitBytecode):
+ (JSC::IfElseNode::emitBytecode):
+ (JSC::DoWhileNode::emitBytecode):
+ (JSC::WhileNode::emitBytecode):
+ (JSC::ForNode::emitBytecode):
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ContinueNode::emitBytecode):
+ (JSC::BreakNode::emitBytecode):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::WithNode::emitBytecode):
+ (JSC::SwitchNode::emitBytecode):
+ (JSC::LabelNode::emitBytecode):
+ (JSC::ThrowNode::emitBytecode):
+ (JSC::TryNode::emitBytecode):
+ * parser/Nodes.h:
+
+2009-02-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix bug #23614. Switches on double precision values were incorrectly
+ truncating the scrutinee value. E.g.:
+
+ switch (1.1) { case 1: print("FAIL"); }
+
+ Was resulting in FAIL.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::cti_op_switch_imm):
+
+2009-02-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Integer Immediate representation need not be canonical in x86 JIT code.
+ On x86-64 we already have loosened the requirement that the int immediate
+ representation in canonical, we should bring x86 into line.
+
+ This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
+ should reduce memory footoprint (reduces JIT code size).
+
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ (JSC::JIT::emitJumpIfImmediateNumber):
+ (JSC::JIT::emitJumpIfNotImmediateNumber):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+
+2009-02-26 Carol Szabo <carol.szabo@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24099
+ ARM Compiler Warnings in pcre_exec.cpp
+
+ * pcre/pcre_exec.cpp:
+ (match):
+
+2009-02-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
+ <https://bugs.webkit.org/show_bug.cgi?id=24086>
+ <rdar://problem/6625111>
+
+ The numeric sort optimization in r40993 generated bytecode for a function
+ without generating JIT code. This breaks an assumption in some parts of
+ the JIT's function calling logic that the presence of a CodeBlock implies
+ the existence of JIT code.
+
+ In order to fix this, we simply generate JIT code whenever we check whether
+ a function is a numeric sort function. This only incurs an additional cost
+ in the case when the function is a numeric sort function, in which case it
+ is not expensive to generate JIT code for it.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::isNumericCompareFunction):
+
+2009-02-25 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
+ messages on hotmail (24052)
+
+ The bug was that for-in enumeration used a cached prototype chain without
+ validating that it was up-to-date.
+
+ This led me to refactor prototype chain caching so it was easier to work
+ with and harder to get wrong.
+
+ After a bit of inlining, this patch is performance-neutral on SunSpider
+ and the v8 benchmarks.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::Interpreter::tryCacheGetByID):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::tryCachePutByID):
+ (JSC::JITStubs::tryCacheGetByID):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See
+ lines beginning with "-" and smile.
+
+ * runtime/JSGlobalObject.h:
+ (JSC::Structure::prototypeForLookup): A shout out to const.
+
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to
+ see if our cached structure chain is equal to the object's structure chain,
+ since in the case of a cache hit, we share references to the same structure
+ chain.
+
+ * runtime/Operations.h:
+ (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored
+ goodness.
+
+ * runtime/PropertyNameArray.h:
+ (JSC::PropertyNameArray::PropertyNameArray):
+ (JSC::PropertyNameArray::setShouldCache):
+ (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache"
+ to communicate that the client is specifying a recommendation, not a
+ capability.
+
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure): No need to initialize a RefPtr.
+ (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper
+ functions.
+
+ (JSC::Structure::prototypeChain): New centralized accessor for a prototype
+ chain. Revalidates on every access, since the objects in the prototype
+ chain may have mutated.
+
+ (JSC::Structure::isValid): Helper function for revalidating a cached
+ prototype chain.
+
+ (JSC::Structure::getEnumerableNamesFromPropertyTable):
+ (JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
+ getEnumerablePropertyNames.
+
+ * runtime/Structure.h:
+
+ * runtime/StructureChain.cpp:
+ (JSC::StructureChain::StructureChain):
+ * runtime/StructureChain.h:
+ (JSC::StructureChain::create): No need for structureChainsAreEqual, since
+ we use pointer equality now. Refactored StructureChain to make a little
+ more sense and eliminate special cases for null prototypes.
+
+2009-02-25 Steve Falkenburg <sfalken@apple.com>
+
+ Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
+ Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.
+
+ Reviewed by Adam Roben.
+
+ * jsc.cpp:
+ (main):
+
+2009-02-24 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix?
+
+ * GNUmakefile.am:
+
+2009-02-24 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros
+
+ * API/JSBasePrivate.h:
+ * API/JSContextRef.h:
+ * API/JSObjectRef.h:
+ * API/WebKitAvailability.h:
+
+2009-02-23 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Next step in splitting JIT functionality out of the Interpreter class:
+ Moved vptr storage from Interpreter to JSGlobalData, so it could be shared
+ between Interpreter and JITStubs, and moved the *Trampoline JIT stubs
+ into the JITStubs class. Also added a VPtrSet class to encapsulate vptr
+ hacks during JSGlobalData initialization.
+
+ SunSpider says 0.4% faster. Meh.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::JIT::compileCTIMachineTrampolines):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::JITStubs):
+ (JSC::JITStubs::tryCacheGetByID):
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_put_by_val):
+ (JSC::JITStubs::cti_op_put_by_val_array):
+ (JSC::JITStubs::cti_op_put_by_val_byte_array):
+ (JSC::JITStubs::cti_op_is_string):
+ * jit/JITStubs.h:
+ (JSC::JITStubs::ctiArrayLengthTrampoline):
+ (JSC::JITStubs::ctiStringLengthTrampoline):
+ (JSC::JITStubs::ctiVirtualCallPreLink):
+ (JSC::JITStubs::ctiVirtualCallLink):
+ (JSC::JITStubs::ctiVirtualCall):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ * runtime/JSArray.h:
+ (JSC::isJSArray):
+ * runtime/JSByteArray.h:
+ (JSC::asByteArray):
+ (JSC::isJSByteArray):
+ * runtime/JSCell.h:
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::VPtrSet::VPtrSet):
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::create):
+ (JSC::JSGlobalData::sharedInstance):
+ * runtime/JSGlobalData.h:
+ * runtime/JSString.h:
+ (JSC::isJSString):
+ * runtime/Operations.h:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+
+2009-02-23 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23787: Allow JIT to generate SSE2 code if using GCC
+ <https://bugs.webkit.org/show_bug.cgi?id=23787>
+
+ GCC version of the cpuid check.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::isSSE2Present): previous assembly code fixed.
+
+2009-02-23 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
+ <https://bugs.webkit.org/show_bug.cgi?id=24047>
+
+ * wtf/MessageQueue.h:
+ (WTF::MessageQueue::infiniteTime):
+ Allows for one to call waitForMessageFilteredWithTimeout and wait forever.
+
+ (WTF::MessageQueue::alwaysTruePredicate):
+ (WTF::MessageQueue::waitForMessage):
+ Made waitForMessage call waitForMessageFilteredWithTimeout, so that there is less
+ duplicate code.
+
+ (WTF::MessageQueue::waitForMessageFilteredWithTimeout):
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::ThreadCondition::timedWait):
+ * wtf/ThreadingWin.cpp:
+ (WTF::ThreadCondition::timedWait):
+ Made these two implementations consistent with the pthread and gtk implementations.
+ Currently, the time calculations would overflow when passed large values.
+
+2009-02-23 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24096
+ PLATFORM(MAC)->PLATFORM(CF) since we want to use the CF functions in Chrome on OS X.
+
+ * wtf/CurrentTime.cpp:
+
+2009-02-22 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix?
+
+ * GNUmakefile.am:
+
+2009-02-22 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * GNUmakefile.am:
+
+2009-02-22 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Next step in splitting JIT functionality out of the Interpreter class:
+ Created a JITStubs class and renamed Interpreter::cti_* to JITStubs::cti_*.
+
+ Also, moved timeout checking into its own class, located in JSGlobalData,
+ so both the Interpreter and the JIT could have access to it.
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * interpreter/CallFrame.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::privateExecute):
+ * interpreter/Interpreter.h:
+ * interpreter/Register.h:
+ * jit/JIT.cpp:
+ (JSC::):
+ (JSC::JIT::emitTimeoutCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArithSlow_op_lshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_bitand):
+ (JSC::JIT::compileFastArithSlow_op_mod):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArithSlow_op_post_inc):
+ (JSC::JIT::compileFastArithSlow_op_post_dec):
+ (JSC::JIT::compileFastArithSlow_op_pre_inc):
+ (JSC::JIT::compileFastArithSlow_op_pre_dec):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::compileFastArithSlow_op_add):
+ (JSC::JIT::compileFastArithSlow_op_mul):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * jit/JITStubs.cpp:
+ (JSC::JITStubs::tryCachePutByID):
+ (JSC::JITStubs::tryCacheGetByID):
+ (JSC::JITStubs::cti_op_convert_this):
+ (JSC::JITStubs::cti_op_end):
+ (JSC::JITStubs::cti_op_add):
+ (JSC::JITStubs::cti_op_pre_inc):
+ (JSC::JITStubs::cti_timeout_check):
+ (JSC::JITStubs::cti_register_file_check):
+ (JSC::JITStubs::cti_op_loop_if_less):
+ (JSC::JITStubs::cti_op_loop_if_lesseq):
+ (JSC::JITStubs::cti_op_new_object):
+ (JSC::JITStubs::cti_op_put_by_id_generic):
+ (JSC::JITStubs::cti_op_get_by_id_generic):
+ (JSC::JITStubs::cti_op_put_by_id):
+ (JSC::JITStubs::cti_op_put_by_id_second):
+ (JSC::JITStubs::cti_op_put_by_id_fail):
+ (JSC::JITStubs::cti_op_get_by_id):
+ (JSC::JITStubs::cti_op_get_by_id_second):
+ (JSC::JITStubs::cti_op_get_by_id_self_fail):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list):
+ (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
+ (JSC::JITStubs::cti_op_get_by_id_proto_fail):
+ (JSC::JITStubs::cti_op_get_by_id_array_fail):
+ (JSC::JITStubs::cti_op_get_by_id_string_fail):
+ (JSC::JITStubs::cti_op_instanceof):
+ (JSC::JITStubs::cti_op_del_by_id):
+ (JSC::JITStubs::cti_op_mul):
+ (JSC::JITStubs::cti_op_new_func):
+ (JSC::JITStubs::cti_op_call_JSFunction):
+ (JSC::JITStubs::cti_op_call_arityCheck):
+ (JSC::JITStubs::cti_vm_dontLazyLinkCall):
+ (JSC::JITStubs::cti_vm_lazyLinkCall):
+ (JSC::JITStubs::cti_op_push_activation):
+ (JSC::JITStubs::cti_op_call_NotJSFunction):
+ (JSC::JITStubs::cti_op_create_arguments):
+ (JSC::JITStubs::cti_op_create_arguments_no_params):
+ (JSC::JITStubs::cti_op_tear_off_activation):
+ (JSC::JITStubs::cti_op_tear_off_arguments):
+ (JSC::JITStubs::cti_op_profile_will_call):
+ (JSC::JITStubs::cti_op_profile_did_call):
+ (JSC::JITStubs::cti_op_ret_scopeChain):
+ (JSC::JITStubs::cti_op_new_array):
+ (JSC::JITStubs::cti_op_resolve):
+ (JSC::JITStubs::cti_op_construct_JSConstruct):
+ (JSC::JITStubs::cti_op_construct_NotJSConstruct):
+ (JSC::JITStubs::cti_op_get_by_val):
+ (JSC::JITStubs::cti_op_get_by_val_byte_array):
+ (JSC::JITStubs::cti_op_resolve_func):
+ (JSC::JITStubs::cti_op_sub):
+ (JSC::JITStubs::cti_op_put_by_val):
+ (JSC::JITStubs::cti_op_put_by_val_array):
+ (JSC::JITStubs::cti_op_put_by_val_byte_array):
+ (JSC::JITStubs::cti_op_lesseq):
+ (JSC::JITStubs::cti_op_loop_if_true):
+ (JSC::JITStubs::cti_op_negate):
+ (JSC::JITStubs::cti_op_resolve_base):
+ (JSC::JITStubs::cti_op_resolve_skip):
+ (JSC::JITStubs::cti_op_resolve_global):
+ (JSC::JITStubs::cti_op_div):
+ (JSC::JITStubs::cti_op_pre_dec):
+ (JSC::JITStubs::cti_op_jless):
+ (JSC::JITStubs::cti_op_not):
+ (JSC::JITStubs::cti_op_jtrue):
+ (JSC::JITStubs::cti_op_post_inc):
+ (JSC::JITStubs::cti_op_eq):
+ (JSC::JITStubs::cti_op_lshift):
+ (JSC::JITStubs::cti_op_bitand):
+ (JSC::JITStubs::cti_op_rshift):
+ (JSC::JITStubs::cti_op_bitnot):
+ (JSC::JITStubs::cti_op_resolve_with_base):
+ (JSC::JITStubs::cti_op_new_func_exp):
+ (JSC::JITStubs::cti_op_mod):
+ (JSC::JITStubs::cti_op_less):
+ (JSC::JITStubs::cti_op_neq):
+ (JSC::JITStubs::cti_op_post_dec):
+ (JSC::JITStubs::cti_op_urshift):
+ (JSC::JITStubs::cti_op_bitxor):
+ (JSC::JITStubs::cti_op_new_regexp):
+ (JSC::JITStubs::cti_op_bitor):
+ (JSC::JITStubs::cti_op_call_eval):
+ (JSC::JITStubs::cti_op_throw):
+ (JSC::JITStubs::cti_op_get_pnames):
+ (JSC::JITStubs::cti_op_next_pname):
+ (JSC::JITStubs::cti_op_push_scope):
+ (JSC::JITStubs::cti_op_pop_scope):
+ (JSC::JITStubs::cti_op_typeof):
+ (JSC::JITStubs::cti_op_is_undefined):
+ (JSC::JITStubs::cti_op_is_boolean):
+ (JSC::JITStubs::cti_op_is_number):
+ (JSC::JITStubs::cti_op_is_string):
+ (JSC::JITStubs::cti_op_is_object):
+ (JSC::JITStubs::cti_op_is_function):
+ (JSC::JITStubs::cti_op_stricteq):
+ (JSC::JITStubs::cti_op_nstricteq):
+ (JSC::JITStubs::cti_op_to_jsnumber):
+ (JSC::JITStubs::cti_op_in):
+ (JSC::JITStubs::cti_op_push_new_scope):
+ (JSC::JITStubs::cti_op_jmp_scopes):
+ (JSC::JITStubs::cti_op_put_by_index):
+ (JSC::JITStubs::cti_op_switch_imm):
+ (JSC::JITStubs::cti_op_switch_char):
+ (JSC::JITStubs::cti_op_switch_string):
+ (JSC::JITStubs::cti_op_del_by_val):
+ (JSC::JITStubs::cti_op_put_getter):
+ (JSC::JITStubs::cti_op_put_setter):
+ (JSC::JITStubs::cti_op_new_error):
+ (JSC::JITStubs::cti_op_debug):
+ (JSC::JITStubs::cti_vm_throw):
+ * jit/JITStubs.h:
+ (JSC::):
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ * runtime/JSGlobalObject.h:
+ * runtime/TimeoutChecker.cpp: Copied from interpreter/Interpreter.cpp.
+ (JSC::TimeoutChecker::TimeoutChecker):
+ (JSC::TimeoutChecker::reset):
+ (JSC::TimeoutChecker::didTimeOut):
+ * runtime/TimeoutChecker.h: Copied from interpreter/Interpreter.h.
+ (JSC::TimeoutChecker::setTimeoutInterval):
+ (JSC::TimeoutChecker::ticksUntilNextCheck):
+ (JSC::TimeoutChecker::start):
+ (JSC::TimeoutChecker::stop):
+
+2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed build fix after r41100.
+
+ * GNUmakefile.am:
+
+2009-02-20 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6606660> 2==null returns true in 64bit jit
+
+ Code for op_eq_null and op_neq_null was incorrectly performing
+ a 32bit compare, which truncated the type tag from an integer
+ immediate, leading to incorrect behaviour.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::setPtr):
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::setPtr):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-02-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ First step in splitting JIT functionality out of the Interpreter class:
+ Created JITStubs.h/.cpp, and moved Interpreter::cti_* into JITStubs.cpp.
+
+ Functions that the Interpreter and JITStubs share moved to Operations.h/.cpp.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::resolveBase):
+ (JSC::Interpreter::checkTimeout):
+ (JSC::Interpreter::privateExecute):
+ * interpreter/Interpreter.h:
+ * jit/JITStubs.cpp: Copied from interpreter/Interpreter.cpp.
+ (JSC::Interpreter::cti_op_resolve_base):
+ * jit/JITStubs.h: Copied from interpreter/Interpreter.h.
+ * runtime/Operations.cpp:
+ (JSC::jsAddSlowCase):
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::jsIsFunctionType):
+ * runtime/Operations.h:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAdd):
+ (JSC::cachePrototypeChain):
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::resolveBase):
+
+2009-02-19 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for x86-64. Where the JavaScriptCore text segment lies outside
+ a 2gb range of the heap containing JIT generated code, callbacks
+ from JIT code to the stub functions in Interpreter will be incorrectly
+ linked.
+
+ No performance impact on Sunspider, 1% regression on v8-tests,
+ due to a 3% regression on richards.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::Call::Call):
+ (JSC::AbstractMacroAssembler::Jump::link):
+ (JSC::AbstractMacroAssembler::Jump::linkTo):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
+ (JSC::AbstractMacroAssembler::differenceBetween):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::tailRecursiveCall):
+ (JSC::MacroAssembler::makeTailRecursiveCall):
+ * assembler/MacroAssemblerX86.h:
+ (JSC::MacroAssemblerX86::call):
+ * assembler/MacroAssemblerX86Common.h:
+ * assembler/MacroAssemblerX86_64.h:
+ (JSC::MacroAssemblerX86_64::call):
+ (JSC::MacroAssemblerX86_64::moveWithPatch):
+ (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
+ (JSC::MacroAssemblerX86_64::storePtrWithPatch):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::jmp_r):
+ (JSC::X86Assembler::linkJump):
+ (JSC::X86Assembler::patchJump):
+ (JSC::X86Assembler::patchCall):
+ (JSC::X86Assembler::linkCall):
+ (JSC::X86Assembler::patchAddress):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::tryCTICachePutByID):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompilePutByIdReplace):
+
+2009-02-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Simplified .call and .apply in preparation for optimizing them. Also,
+ a little cleanup.
+
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall): No need to do any specific conversion on
+ 'this' -- op_convert_this will do it if necessary.
+
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject): Slightly relaxed the rules on
+ toThisObject to allow for 'undefined', which can be passed through
+ .call and .apply.
+
+2009-02-19 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23976: MessageQueue needs a way to wait for a message that satisfies an arbitrary criteria.
+ <https://bugs.webkit.org/show_bug.cgi?id=23976>
+
+ * wtf/Deque.h:
+ (WTF::Deque<T>::findIf):
+ * wtf/MessageQueue.h:
+ (WTF::MessageQueue<T>::waitForMessageFiltered):
+
+2009-02-18 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23974: Deque::Remove would be a useful method.
+ <https://bugs.webkit.org/show_bug.cgi?id=23974>
+
+ Add Deque::remove and DequeIteratorBase<T>::operator=.
+
+ Why was operator= added? Every concrete iterator (DequeIterator..DequeConstReverseIterator)
+ was calling DequeIteratorBase::assign(), which called Base::operator=(). Base::operator=()
+ was not implemented. This went unnoticed because the iterator copy code has been unused.
+
+ * wtf/Deque.h:
+ (WTF::Deque<T>::remove):
+ (WTF::DequeIteratorBase<T>::removeFromIteratorsList):
+ (WTF::DequeIteratorBase<T>::operator=):
+ (WTF::DequeIteratorBase<T>::~DequeIteratorBase):
+
+2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Fix symbols.filter location, and add other missing files to the
+ autotools build, so that make dist works.
+
+ * GNUmakefile.am:
+
+2009-02-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
+ bot.
+
+ Technically, both behaviors are OK, but we might as well keep this test
+ passing.
+
+ * runtime/FunctionPrototype.cpp:
+ (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon
+ after a trailing '}', since '}' ends a block, indicating the end of a
+ statement.
+
+2009-02-17 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * runtime/FunctionPrototype.cpp:
+
+2009-02-17 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Add assertion to guard against oversized pc relative calls.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::link):
+
+2009-02-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
+ fails to load.
+
+ amnestyusa.org uses the Optimist JavaScript library, which adds event
+ listeners by concatenating string-ified functions. This is only sure to
+ be syntactically valid if the string-ified functions end in semicolons.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::isWhiteSpace):
+ * parser/Lexer.h:
+ (JSC::Lexer::isWhiteSpace):
+ (JSC::Lexer::isLineTerminator): Added some helper functions for examining
+ whitespace.
+
+ * runtime/FunctionPrototype.cpp:
+ (JSC::appendSemicolonIfNeeded):
+ (JSC::functionProtoFuncToString): When string-ifying a function, insert
+ a semicolon in the last non-whitespace position, if one doesn't already exist.
+
+2009-02-16 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Roll out r41022 as it breaks qt and gtk builds
+
+ * jit/JITArithmetic.cpp:
+ (JSC::isSSE2Present):
+
+2009-02-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for <rdar://problem/6468156>
+ REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)
+
+ No performance regression.
+
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been
+ overridden.
+
+2009-02-16 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::TCMallocStats::):
+ (WTF::TCMallocStats::FastMallocZone::FastMallocZone):
+
+2009-02-16 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23787: Allow JIT to generate SSE2 code if using GCC
+ <https://bugs.webkit.org/show_bug.cgi?id=23787>
+
+ GCC version of the cpuid check.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::isSSE2Present): GCC assembly code added.
+ 6.6% progression on x86 Linux with JIT and WREC on SunSpider if using SSE2 capable machine.
+
+2009-02-13 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23960
+ Crash Fix.
+
+ Don't depend on 'initializeThreading()' to come before a call to 'isMainThread()'
+ as QtWebKit only calls 'initializeThreading()' during QWebPage construction.
+
+ A client app may well make a call to QWebSettings::iconForUrl() for instance
+ before creating a QWebPage and that call to QWebSettings triggers an
+ ASSERT(isMainThread()) deep within WebCore.
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::isMainThread):
+
+2009-02-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Some data in the instruction stream is potentially uninitialized - fix this.
+
+ Change the OperandTypes constructor so that uninitialized memory in the int
+ is zeroed, and modify the Instruction constructor taking an Opcode so that
+ if !HAVE(COMPUTED_GOTO) (i.e. when Opcode is an enum, and is potentially only
+ a byte) it zeros the Instruction first before writing the opcode.
+
+ * bytecode/Instruction.h:
+ (JSC::Instruction::Instruction):
+ * parser/ResultType.h:
+ (JSC::OperandTypes::OperandTypes):
+
+2009-02-13 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix for non_JIT platforms.
+
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::setIsNumericCompareFunction):
+ (JSC::CodeBlock::isNumericCompareFunction):
+
+2009-02-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed <rdar://problem/6584057> Optimize sort by JS numeric comparison
+ function not to run the comparison function
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::CodeBlock):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::setIsNumericCompareFunction):
+ (JSC::CodeBlock::isNumericCompareFunction): Added the ability to track
+ whether a CodeBlock performs a sort-like numeric comparison.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate): Set the isNumericCompareFunction bit
+ after compiling.
+
+ * parser/Nodes.cpp:
+ (JSC::FunctionBodyNode::emitBytecode): Fixed a bug that caused us to
+ codegen an extra return at the end of all functions (eek!), since this
+ made it harder / weirder to detect the numeric comparison pattern in
+ bytecode.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncSort): Use the isNumericCompareFunction bit to do
+ a faster sort if we can.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::extractFunctionBody):
+ (JSC::constructFunction):
+ * runtime/FunctionConstructor.h: Renamed and exported extractFunctionBody for
+ use in initializing lazyNumericCompareFunction.
+
+ * runtime/JSArray.cpp:
+ (JSC::compareNumbersForQSort):
+ (JSC::compareByStringPairForQSort):
+ (JSC::JSArray::sortNumeric):
+ (JSC::JSArray::sort):
+ * runtime/JSArray.h: Added a fast numeric sort. Renamed ArrayQSortPair
+ to be more specific since we do different kinds of qsort now.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::numericCompareFunction):
+ (JSC::JSGlobalData::ClientData::~ClientData):
+ * runtime/JSGlobalData.h: Added helper data for computing the
+ isNumericCompareFunction bit.
+
+2009-02-13 Darin Adler <darin@apple.com>
+
+ * Configurations/JavaScriptCore.xcconfig: Undo accidental commit of this file.
+
+2009-02-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt and Alexey Proskuryakov.
+
+ Speed up a couple string functions.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncIndexOf): Added a fast path for cases where the second
+ argument is either missing or an integer.
+ (JSC::stringProtoFuncBig): Use jsNontrivialString since the string is guaranteed
+ to be 2 or more characters long.
+ (JSC::stringProtoFuncSmall): Ditto.
+ (JSC::stringProtoFuncBlink): Ditto.
+ (JSC::stringProtoFuncBold): Ditto.
+ (JSC::stringProtoFuncItalics): Ditto.
+ (JSC::stringProtoFuncStrike): Ditto.
+ (JSC::stringProtoFuncSub): Ditto.
+ (JSC::stringProtoFuncSup): Ditto.
+ (JSC::stringProtoFuncFontcolor): Ditto.
+ (JSC::stringProtoFuncFontsize): Make the fast path Sam recently added even faster
+ by avoiding all but the minimum memory allocation.
+ (JSC::stringProtoFuncAnchor): Use jsNontrivialString.
+ (JSC::stringProtoFuncLink): Added a fast path.
+
+ * runtime/UString.cpp:
+ (JSC::UString::find): Added a fast path for single-character search strings.
+
+2009-02-13 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23926: Race condition in callOnMainThreadAndWait
+ <https://bugs.webkit.org/show_bug.cgi?id=23926>
+
+ * wtf/MainThread.cpp:
+ Removed callOnMainThreadAndWait since it isn't used.
+
+2009-02-13 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Jon Honeycutt.
+
+ Math.random is really slow on windows.
+
+ Math.random calls WTF::randomNumber which is implemented as
+ the secure rand_s on windows. Unfortunately rand_s is an order
+ of magnitude slower than arc4random. For this reason I've
+ added "weakRandomNumber" for use by JavaScript's Math Object.
+ In the long term we should look at using our own secure PRNG
+ in place of the system, but this will do for now.
+
+ 30% win on SunSpider on Windows, resolving most of the remaining
+ disparity vs. Mac.
+
+ * runtime/MathObject.cpp:
+ (JSC::MathObject::MathObject):
+ (JSC::mathProtoFuncRandom):
+ * wtf/RandomNumber.cpp:
+ (WTF::weakRandomNumber):
+ (WTF::randomNumber):
+ * wtf/RandomNumber.h:
+ * wtf/RandomNumberSeed.h:
+ (WTF::initializeWeakRandomNumberGenerator):
+
+2009-02-12 Mark Rowe <mrowe@apple.com>
+
+ Fix the build for other platforms.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+
+2009-02-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove (/reduce) use of hard-wired register names from the JIT.
+ Currently there is no abstraction of registers used in the JIT,
+ which has a number of negative consequences. Hard-wiring x86
+ register names makes the JIT less portable to other platforms,
+ and prevents us from performing dynamic register allocation to
+ attempt to maintain more temporary values in machine registers.
+ (The latter will be more important on x86-64, where we have more
+ registers to make use of).
+
+ Also, remove MacroAssembler::mod32. This was not providing a
+ useful abstraction, and was not in keeping with the rest of the
+ MacroAssembler interface, in having specific register requirements.
+
+ * assembler/MacroAssemblerX86Common.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_lshift):
+ (JSC::JIT::compileFastArithSlow_op_lshift):
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ (JSC::JIT::compileFastArith_op_bitand):
+ (JSC::JIT::compileFastArithSlow_op_bitand):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArithSlow_op_mod):
+ (JSC::JIT::compileFastArith_op_post_inc):
+ (JSC::JIT::compileFastArithSlow_op_post_inc):
+ (JSC::JIT::compileFastArith_op_post_dec):
+ (JSC::JIT::compileFastArithSlow_op_post_dec):
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileFastArithSlow_op_pre_inc):
+ (JSC::JIT::compileFastArith_op_pre_dec):
+ (JSC::JIT::compileFastArithSlow_op_pre_dec):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCallEvalSetupArgs):
+ (JSC::JIT::compileOpConstructSetupArgs):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::emitPutVirtualRegister):
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+
+2009-02-12 Horia Olaru <olaru@adobe.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23400
+
+ When throwing an exception within an eval argument string, the dst parameter was
+ modified in the functions below and the return value for eval was altered. Changed
+ the emitNode call in JSC::ThrowNode::emitBytecode to use a temporary register
+ to store its results instead of dst. The JSC::FunctionCallResolveNode::emitBytecode
+ would load the function within the dst registry, also altering the result returned
+ by eval. Replaced it with another temporary.
+
+ * parser/Nodes.cpp:
+ (JSC::FunctionCallResolveNode::emitBytecode):
+ (JSC::ThrowNode::emitBytecode):
+
+2009-02-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Speed up String.prototype.fontsize.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncFontsize): Specialize for defined/commonly used values.
+
+2009-02-12 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Correctness fix.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber): Divide by the maximum representable value, which
+ is different on each platform now, to get values between 0 and 1.
+
+2009-02-12 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+
+2009-02-12 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed <rdar://problem/6582048>.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber): Make only one call to the random number generator
+ on platforms where the generator is cryptographically secure. The value
+ of randomness over and above cryptographically secure randomness is not
+ clear, and it caused some performance problems.
+
+2009-02-12 Adam Roben <aroben@apple.com>
+
+ Fix lots of Perl warnings when building JavaScriptCoreGenerated on
+ Windows
+
+ Reviewed by John Sullivan.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
+ Create the docs/ directory so that we can write bytecode.html into it.
+ This matches what JavaScriptCore.xcodeproj does.
+
+2009-02-12 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Lars.
+
+ Re-enable the JIT in the Qt build with -fno-stack-protector on Linux.
+
+ * JavaScriptCore.pri:
+
+2009-02-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23705
+ Fix the UI freeze caused by Worker generating a flood of messages.
+ Measure time we spend in executing posted work items. If too much time is spent
+ without returning to the run loop, exit and reschedule.
+
+ * wtf/MainThread.h:
+ Added initializeMainThreadPlatform() to initialize low-level mechanism for posting
+ work items from thread to thread. This removes #ifdefs for WIN and CHROMIUM from platform-independent code.
+
+ * wtf/MainThread.cpp:
+ (WTF::initializeMainThread):
+ (WTF::dispatchFunctionsFromMainThread):
+ Instead of dispatching all work items in the queue, dispatch them one by one
+ and measure elapsed time. After a threshold, reschedule and quit.
+
+ (WTF::callOnMainThread):
+ (WTF::callOnMainThreadAndWait):
+ Only schedule dispatch if the queue was empty - to avoid many posted messages in the run loop queue.
+
+ * wtf/mac/MainThreadMac.mm:
+ (WTF::scheduleDispatchFunctionsOnMainThread):
+ Use static instance of the mainThreadCaller instead of allocating and releasing it each time.
+ (WTF::initializeMainThreadPlatform):
+ * wtf/gtk/MainThreadChromium.cpp:
+ (WTF::initializeMainThreadPlatform):
+ * wtf/gtk/MainThreadGtk.cpp:
+ (WTF::initializeMainThreadPlatform):
+ * wtf/qt/MainThreadQt.cpp:
+ (WTF::initializeMainThreadPlatform):
+ * wtf/win/MainThreadWin.cpp:
+ (WTF::initializeMainThreadPlatform):
+ * wtf/wx/MainThreadWx.cpp:
+ (WTF::initializeMainThreadPlatform):
+
+2009-02-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Style cleanup.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::::CodeLocationCommon::labelAtOffset):
+ (JSC::::CodeLocationCommon::jumpAtOffset):
+ (JSC::::CodeLocationCommon::callAtOffset):
+ (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
+ (JSC::::CodeLocationCommon::dataLabel32AtOffset):
+
+2009-02-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ * assembler/AbstractMacroAssembler.h: Fix comments.
+
+2009-02-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Trying to fix wx build.
+
+ * bytecode/JumpTable.h: Include "MacroAssembler.h", not <MacroAssembler.h>.
+ * jscore.bkl: Added assembler directory to search paths.
+
+2009-02-10 Gavin Barraclough <barraclough@apple.com>
+
+ Build
+ fix.
+ (Narrow
+ changelog
+ for
+ dhyatt).
+
+ * bytecode/Instruction.h:
+ (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
+ (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
+
+2009-02-10 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Reduce use of void* / reinterpret_cast in JIT repatching code,
+ add strong types for Calls and for the various types of pointers
+ we retain into the JIT generated instruction stream.
+
+ No performance impact.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
+ (JSC::AbstractMacroAssembler::ImmPtr::asIntptr):
+ (JSC::AbstractMacroAssembler::Imm32::Imm32):
+ (JSC::AbstractMacroAssembler::Label::Label):
+ (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
+ (JSC::AbstractMacroAssembler::Call::Call):
+ (JSC::AbstractMacroAssembler::Call::link):
+ (JSC::AbstractMacroAssembler::Call::linkTo):
+ (JSC::AbstractMacroAssembler::Jump::Jump):
+ (JSC::AbstractMacroAssembler::Jump::linkTo):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
+ (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
+ (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
+ (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
+ (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
+ (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
+ (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
+ (JSC::AbstractMacroAssembler::PatchBuffer::entry):
+ (JSC::AbstractMacroAssembler::PatchBuffer::trampolineAt):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
+ (JSC::AbstractMacroAssembler::PatchBuffer::patch):
+ (JSC::AbstractMacroAssembler::PatchBuffer::locationOf):
+ (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
+ (JSC::AbstractMacroAssembler::differenceBetween):
+ (JSC::::CodeLocationCommon::labelAtOffset):
+ (JSC::::CodeLocationCommon::jumpAtOffset):
+ (JSC::::CodeLocationCommon::callAtOffset):
+ (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
+ (JSC::::CodeLocationCommon::dataLabel32AtOffset):
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::call):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::getCallReturnOffset):
+ * bytecode/CodeBlock.h:
+ (JSC::CallLinkInfo::CallLinkInfo):
+ (JSC::getStructureStubInfoReturnLocation):
+ (JSC::getCallLinkInfoReturnLocation):
+ * bytecode/Instruction.h:
+ (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
+ (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
+ * bytecode/JumpTable.h:
+ (JSC::StringJumpTable::ctiForValue):
+ (JSC::SimpleJumpTable::ctiForValue):
+ * bytecode/StructureStubInfo.h:
+ (JSC::StructureStubInfo::StructureStubInfo):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitCatch):
+ (JSC::prepareJumpTableForStringSwitch):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::getPolymorphicAccessStructureListSlot):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_vm_throw):
+ * jit/JIT.cpp:
+ (JSC::ctiSetReturnAddress):
+ (JSC::ctiPatchCallByReturnAddress):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JIT::compileGetByIdSelf):
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdReplace):
+ (JSC::JIT::compilePutByIdTransition):
+ (JSC::JIT::compilePatchGetArrayLength):
+ (JSC::JIT::emitCTICall):
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::emitCTICall_internal):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+
+2009-02-10 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r40813
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added profiler/ to the include
+ path so that Profiler.h can be found.
+
+2009-02-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Provide a class type for a generated block of JIT code.
+ Also changes the return address -> bytecode index map to
+ track the return addess as an unsigned offset into the code
+ instead of a ptrdiff_t in terms of void**s - the latter is
+ equal to the actual offset / sizeof(void*), making it a
+ potentially lossy representation.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::getCallReturnOffset):
+ * bytecode/CodeBlock.h:
+ (JSC::CallReturnOffsetToBytecodeIndex::CallReturnOffsetToBytecodeIndex):
+ (JSC::getCallReturnOffset):
+ (JSC::CodeBlock::getBytecodeIndex):
+ (JSC::CodeBlock::jitCode):
+ (JSC::CodeBlock::callReturnIndexVector):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ (JSC::):
+ * jit/JITCall.cpp:
+ (JSC::JIT::linkCall):
+ * jit/JITCode.h: Added.
+ (JSC::):
+ (JSC::JITCode::JITCode):
+ (JSC::JITCode::operator bool):
+ (JSC::JITCode::addressForCall):
+ (JSC::JITCode::offsetOf):
+ (JSC::JITCode::execute):
+
+2009-02-09 John Grabowski <jrg@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23856
+ Change the definition of "main thread" for Chromium on OSX.
+ It does not match the DARWIN definition.
+
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::initializeThreading):
+ (WTF::isMainThread):
+
+2009-02-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Minor bugfix, incorrect check meant that subtraction causing integer overflow
+ would be missed on x86-64 JIT.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOp):
+
+2009-02-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ A more sensible register allocation for x86-64.
+
+ When WREC was ported to x86-64 it stuck with the same register allocation as x86.
+ This requires registers to be reordered on entry into WREC generated code, since
+ argument passing is different on x86-64 and x86 (regparm(3)). This patch switches
+ x86-64 to use a native register allocation, that does not require argument registers
+ to be reordered.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateReturnSuccess):
+ (JSC::WREC::Generator::generateReturnFailure):
+ * wrec/WRECGenerator.h:
+
+2009-02-05 Adam Roben <aroben@apple.com>
+
+ Build fix
+
+ Rubberstamped by Sam Weinig.
+
+ * wtf/TypeTraits.h: Include Platform.h, since this header uses macros
+ defined there.
+
+2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23747
+ Add Chromium threading-related files.
+
+ * wtf/MainThread.cpp: Added platform guard to initializeMainThread.
+ * wtf/chromium/ChromiumThreading.h: Added.
+ * wtf/chromium/MainThreadChromium.cpp: Added.
+ (WTF::initializeMainThread):
+ (WTF::scheduleDispatchFunctionsOnMainThread):
+
+2009-02-05 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
+ <https://bugs.webkit.org/show_bug.cgi?id=23713>
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+
+ * wtf/HashTraits.h:
+ Remove unnecessary header file that I missed when moving out the type traits form this file.
+
+ * wtf/TypeTraits.cpp: Added.
+ (WTF::):
+ * wtf/TypeTraits.h:
+ Moved the compile asserts into TypeTraits.cpp file.
+
+2009-02-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver 'the nun' Hunt.
+
+ Add -e switch to jsc to enable evaluation of scripts passed on the command line.
+
+ * jsc.cpp:
+ (Script::Script):
+ (runWithScripts):
+ (printUsageStatement):
+ (parseArguments):
+ (jscmain):
+
+2009-02-04 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Sam 'Big Mac' Weinig.
+
+ * assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
+ * assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
+ * assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
+ * assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
+
+2009-02-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
+ platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
+ platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
+ the plaform-specific code generation forming a big meaty patty of methods like 'add32',
+ 'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
+ MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
+ and backwards branch methods, all of which can be described in a platform independent
+ way using methods from the base class. The AbstractMacroAssembler is templated on the
+ type of the assembler class that will be used for code generation, and the three layers
+ are held together with the cocktail stick of inheritance.
+
+ The above description is a slight simplification since the MacroAssemblerX86 is actually
+ formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
+ bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
+ which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
+ specific to the given platform).
+
+ I'm landing these changes first without splitting the classes across multiple files,
+ I will follow up with a second patch to split up the file MacroAssembler.h.
+
+ * assembler/MacroAssembler.h:
+ (JSC::AbstractMacroAssembler::):
+ (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
+ (JSC::AbstractMacroAssembler::DataLabelPtr::patch):
+ (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32):
+ (JSC::AbstractMacroAssembler::DataLabel32::patch):
+ (JSC::AbstractMacroAssembler::Label::Label):
+ (JSC::AbstractMacroAssembler::Jump::Jump):
+ (JSC::AbstractMacroAssembler::Jump::link):
+ (JSC::AbstractMacroAssembler::Jump::linkTo):
+ (JSC::AbstractMacroAssembler::Jump::patch):
+ (JSC::AbstractMacroAssembler::JumpList::link):
+ (JSC::AbstractMacroAssembler::JumpList::linkTo):
+ (JSC::AbstractMacroAssembler::PatchBuffer::link):
+ (JSC::AbstractMacroAssembler::PatchBuffer::addressOf):
+ (JSC::AbstractMacroAssembler::PatchBuffer::setPtr):
+ (JSC::AbstractMacroAssembler::size):
+ (JSC::AbstractMacroAssembler::copyCode):
+ (JSC::AbstractMacroAssembler::label):
+ (JSC::AbstractMacroAssembler::align):
+ (JSC::AbstractMacroAssembler::differenceBetween):
+ (JSC::MacroAssemblerX86Common::xor32):
+ (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
+ (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
+ (JSC::MacroAssemblerX86Common::move):
+ (JSC::MacroAssemblerX86Common::swap):
+ (JSC::MacroAssemblerX86Common::signExtend32ToPtr):
+ (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
+ (JSC::MacroAssemblerX86Common::branch32):
+ (JSC::MacroAssemblerX86Common::jump):
+ (JSC::MacroAssemblerX86_64::add32):
+ (JSC::MacroAssemblerX86_64::sub32):
+ (JSC::MacroAssemblerX86_64::load32):
+ (JSC::MacroAssemblerX86_64::store32):
+ (JSC::MacroAssemblerX86_64::addPtr):
+ (JSC::MacroAssemblerX86_64::andPtr):
+ (JSC::MacroAssemblerX86_64::orPtr):
+ (JSC::MacroAssemblerX86_64::rshiftPtr):
+ (JSC::MacroAssemblerX86_64::subPtr):
+ (JSC::MacroAssemblerX86_64::xorPtr):
+ (JSC::MacroAssemblerX86_64::loadPtr):
+ (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
+ (JSC::MacroAssemblerX86_64::storePtr):
+ (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
+ (JSC::MacroAssemblerX86_64::branchPtr):
+ (JSC::MacroAssemblerX86_64::branchTestPtr):
+ (JSC::MacroAssemblerX86_64::branchAddPtr):
+ (JSC::MacroAssemblerX86_64::branchSubPtr):
+ (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
+ (JSC::MacroAssemblerX86_64::storePtrWithPatch):
+ (JSC::MacroAssemblerX86::add32):
+ (JSC::MacroAssemblerX86::sub32):
+ (JSC::MacroAssemblerX86::load32):
+ (JSC::MacroAssemblerX86::store32):
+ (JSC::MacroAssemblerX86::branch32):
+ (JSC::MacroAssemblerX86::branchPtrWithPatch):
+ (JSC::MacroAssemblerX86::storePtrWithPatch):
+ (JSC::MacroAssembler::pop):
+ (JSC::MacroAssembler::peek):
+ (JSC::MacroAssembler::poke):
+ (JSC::MacroAssembler::branchPtr):
+ (JSC::MacroAssembler::branch32):
+ (JSC::MacroAssembler::branch16):
+ (JSC::MacroAssembler::branchTestPtr):
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::andPtr):
+ (JSC::MacroAssembler::orPtr):
+ (JSC::MacroAssembler::rshiftPtr):
+ (JSC::MacroAssembler::subPtr):
+ (JSC::MacroAssembler::xorPtr):
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
+ (JSC::MacroAssembler::branchAddPtr):
+ (JSC::MacroAssembler::branchSubPtr):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOp):
+
+2009-02-04 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23681
+ Worker tests crash in debug builds if run --singly
+
+ The crash happened because worker threads continued running while debug-only static objects
+ were already being destroyed on main thread.
+
+ * runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get
+ destroyed.
+
+ * wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.
+
+2009-02-03 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23715
+
+ Simplify MacroAssembler interface, by combining comparison methods.
+ Seprate operations are combined as follows:
+ jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
+ j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
+ j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
+ set*32 -> set32
+
+ Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
+ instead of as multiplicands (1,2,4,8).
+
+ This patch singificantly reduces replication of code, and increases functionality supported
+ by the MacroAssembler. No performance impact.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::):
+ (JSC::MacroAssembler::branchPtr):
+ (JSC::MacroAssembler::branchPtrWithPatch):
+ (JSC::MacroAssembler::branch32):
+ (JSC::MacroAssembler::branch16):
+ (JSC::MacroAssembler::branchTestPtr):
+ (JSC::MacroAssembler::branchTest32):
+ (JSC::MacroAssembler::branchAddPtr):
+ (JSC::MacroAssembler::branchAdd32):
+ (JSC::MacroAssembler::branchMul32):
+ (JSC::MacroAssembler::branchSubPtr):
+ (JSC::MacroAssembler::branchSub32):
+ (JSC::MacroAssembler::set32):
+ (JSC::MacroAssembler::setTest32):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::jccRel32):
+ (JSC::X86Assembler::setccOpcode):
+ (JSC::X86Assembler::cmpq_mr):
+ (JSC::X86Assembler::setcc_r):
+ (JSC::X86Assembler::sete_r):
+ (JSC::X86Assembler::setne_r):
+ (JSC::X86Assembler::jne):
+ (JSC::X86Assembler::je):
+ (JSC::X86Assembler::jl):
+ (JSC::X86Assembler::jb):
+ (JSC::X86Assembler::jle):
+ (JSC::X86Assembler::jbe):
+ (JSC::X86Assembler::jge):
+ (JSC::X86Assembler::jg):
+ (JSC::X86Assembler::ja):
+ (JSC::X86Assembler::jae):
+ (JSC::X86Assembler::jo):
+ (JSC::X86Assembler::jp):
+ (JSC::X86Assembler::js):
+ (JSC::X86Assembler::jcc):
+ (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_lshift):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArith_op_post_inc):
+ (JSC::JIT::compileFastArith_op_post_dec):
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileFastArith_op_pre_dec):
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::checkStructure):
+ (JSC::JIT::emitJumpIfJSCell):
+ (JSC::JIT::emitJumpIfNotJSCell):
+ (JSC::JIT::emitJumpIfImmediateNumber):
+ (JSC::JIT::emitJumpIfNotImmediateNumber):
+ (JSC::JIT::emitJumpIfImmediateInteger):
+ (JSC::JIT::emitJumpIfNotImmediateInteger):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::match):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateIncrementIndex):
+ (JSC::WREC::Generator::generateLoadCharacter):
+ (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
+ (JSC::WREC::Generator::generateBackreferenceQuantifier):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacterPair):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::generateBackreference):
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
+ when shrinking down from a size that was greater than the inline capacity.
+
+ Reviewed by Maciej
+
+ * wtf/Vector.h:
+ (WTF::VectorBuffer::VectorBuffer):
+ (WTF::VectorBuffer::allocateBuffer):
+
+2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Added accessor for JSByteArray storage.
+
+ * runtime/JSByteArray.h:
+ (JSC::JSByteArray::storage):
+
+2009-02-03 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23560
+ Implement SharedTimer on WorkerRunLoop
+
+ * JavaScriptCore.exp:
+ Forgot to expose ThreadCondition::timedWait() in one of previous patches.
+
+2009-02-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
+ <rdar://problem/6543487>
+
+ In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
+ itself recursively, it will incorrectly emit (and thus consume) the next single character
+ match in the current character class. As WREC uses a binary search this out of sequence
+ codegen could result in a character match being missed and so cause the regex to produce
+ incorrect results.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
+ https://bugs.webkit.org/show_bug.cgi?id=23676
+
+ * API/JSObjectRef.cpp:
+ (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
+ * parser/Lexer.cpp:
+ (JSC::Lexer::Lexer): Ditto.
+ (JSC::Lexer::clear): Ditto.
+
+ * wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of
+ reserveCapacity for use when the vector is brand new (still size 0 with no
+ capacity other than the inline capacity).
+
+2009-01-30 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ <rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.
+
+ * wtf/Platform.h:
+
+2009-01-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe and Sam Weinig.
+
+ Finally fix load() to propagate exceptions correctly.
+
+ * jsc.cpp:
+ (functionLoad):
+
+2009-01-30 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23618
+ Templated worker tasks should be more error proof to use.
+ Fix Chromium build.
+
+ * wtf/TypeTraits.h:
+ (WTF::IsConvertibleToInteger::IsConvertibleToDouble):
+ Avoid "possible loss of data" warning when using Microsoft's C++ compiler
+ by avoiding an implicit conversion of int types to doubles.
+
+2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Bug 23580: GNU mode RVCT compilation support
+ <https://bugs.webkit.org/show_bug.cgi?id=23580>
+
+ * pcre/pcre_exec.cpp: Use COMPILER(GCC) instead of __GNUC__.
+ * wtf/FastMalloc.cpp: Ditto.
+ (WTF::TCMallocStats::):
+ * wtf/Platform.h: Don't define COMPILER(GCC) with RVCT --gnu.
+
+2009-01-30 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23618: Templated worker tasks should be more error proof to use
+ <https://bugs.webkit.org/show_bug.cgi?id=23618>
+
+ Add the type traits needed for the generic worker tasks
+ and compile asserts for them.
+
+ Add a summary header to the TypeTraits.h file to explain what is in there.
+
+ Add a note to explain IsPod's deficiencies.
+
+ * wtf/TypeTraits.h:
+
+2009-01-30 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
+ <https://bugs.webkit.org/show_bug.cgi?id=23616>
+
+ * wtf/TypeTraits.h: Moved RemovePointer, IsPod, IsInteger to this file.
+
+ * wtf/OwnPtr.h: Use RemovePointer from TypeTraits.h.
+ * wtf/RetainPtr.h: Ditto.
+
+ * wtf/HashTraits.h: Use IsInteger from TypeTraits.h.
+
+ * wtf/VectorTraits.h: Use IsPod from TypeTraits.h.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Added TypeTraits.h.
+
+2009-01-29 Stephanie Lewis <slewis@apple.com>
+
+ RS by Oliver Hunt.
+
+ Update the order files.
+
+ * JavaScriptCore.order:
+
+2009-01-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23551: Crash on page load with profiler enabled and running
+ <https://bugs.webkit.org/show_bug.cgi?id=23551>
+ <rdar://problem/6529521>
+
+ Interpreter::execute(FunctionBodyNode*, ...) calls Profiler::didExecute()
+ with a stale CallFrame. If some part of the scope chain has already been
+ freed, Profiler::didExecute() will crash when attempting to get the lexical
+ global object. The fix is to make the didExecute() call use the caller's
+ CallFrame, not the one made for the function call. In this case, the
+ willExecute() call should also be changed to match.
+
+ Since this occurs in the actual inspector JS, it is difficult to reduce.
+ I couldn't make a layout test.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+
+2009-01-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix for <rdar://problem/6525537>
+ Hang occurs when closing Installer window (iTunes, Aperture)
+
+ * JavaScriptCore.exp: Export JSGlobalData::sharedInstance.
+
+2009-01-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Initial patch by Mark Rowe.
+
+ <rdar://problem/6519356>
+ REGRESSION (r36006): "out of memory" alert running dromaeo on Windows
+
+ Report the cost of the ArrayStorage vector more accurately/often.
+
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::JSArray): Report the extra cost even for a filled array
+ because JSString using the single character optimization and immediates
+ wont increase the cost themselves.
+ (JSC::JSArray::putSlowCase): Update the cost when increasing the size of
+ the array.
+ (JSC::JSArray::increaseVectorLength): Ditto.
+
+2009-01-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Fix for <rdar://problem/6129678>
+ REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view
+
+ Iterating the properties of activation objects accessed through the WebKit debugging
+ APIs was broken by forced conversion of JSActivation to the global object. To fix this,
+ we use a proxy activation object that acts more like a normal JSObject.
+
+ * debugger/DebuggerActivation.cpp: Added.
+ (JSC::DebuggerActivation::DebuggerActivation):
+ (JSC::DebuggerActivation::mark):
+ (JSC::DebuggerActivation::className):
+ (JSC::DebuggerActivation::getOwnPropertySlot):
+ (JSC::DebuggerActivation::put):
+ (JSC::DebuggerActivation::putWithAttributes):
+ (JSC::DebuggerActivation::deleteProperty):
+ (JSC::DebuggerActivation::getPropertyNames):
+ (JSC::DebuggerActivation::getPropertyAttributes):
+ (JSC::DebuggerActivation::defineGetter):
+ (JSC::DebuggerActivation::defineSetter):
+ (JSC::DebuggerActivation::lookupGetter):
+ (JSC::DebuggerActivation::lookupSetter):
+ * debugger/DebuggerActivation.h: Added.
+ Proxy JSActivation object for Debugging.
+
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::isActivationObject): Added.
+ * runtime/JSObject.h:
+ (JSC::JSObject::isActivationObject): Added.
+
+2009-01-28 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23490: Remove initialRefCount argument from RefCounted class
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23490>
+
+ Reviewed by Darin Adler.
+
+ RefCountedBase now always starts with a ref count of 1, so there
+ is no need to pass the initialRefCount into the class anymore.
+
+ * wtf/ByteArray.h:
+ (WTF::ByteArray::ByteArray): Removed call to RefCounted(1).
+ * wtf/RefCounted.h:
+ (WTF::RefCountedBase::RefCountedBase): Changed to start with a
+ ref count of 1.
+ (WTF::RefCounted::RefCounted): Removed initialRefCount argument
+ and removed call to RefCounted(1).
+
+2009-01-26 Adele Peterson <adele@apple.com>
+
+ Build fix.
+
+ * debugger/Debugger.cpp:
+
+2009-01-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes for eq null & neq null, on 64-bit JIT.
+ https://bugs.webkit.org/show_bug.cgi?id=23559
+
+ This patch degrades 64-bit JIT performance on some benchmarks,
+ due to the whole not-being-incorrect thing.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2009-01-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 23552: Dashcode evaluator no longer works after making ExecStates actual call frames
+ <https://bugs.webkit.org/show_bug.cgi?id=23552>
+ <rdar://problem/6398839>
+
+ * JavaScriptCore.exp:
+ * debugger/Debugger.cpp:
+ (JSC::evaluateInGlobalCallFrame): Added so that WebScriptCallFrame can
+ evaluate JS starting from a global call frame.
+ * debugger/Debugger.h:
+
+2009-01-25 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Improve the consistency of settings in our .xcconfig files.
+
+ * Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS to match other projects.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Turn on the following warnings:
+
+ -Wcast-qual
+ -Wextra-tokens
+ -Wformat=2
+ -Winit-self
+ -Wmissing-noreturn
+ -Wpacked
+ -Wrendundant-decls
+
+ * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
+ -W for clarity since we don't have to support the older versions of gcc that require the
+ old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
+ -Wno-format-y2k since we can have that one on now.
+
+2009-01-25 Judit Jasz <jasy@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ Compilation problem fixing
+ http://bugs.webkit.org/show_bug.cgi?id=23497
+
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall): Use JSValuePtr::encode.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Fourth patch: Deal with the last few stray warnings.
+
+ * parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
+ This makes both separate compilation and all-in-one compilation work with the
+ -Wredundant-decls warning.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Third patch: Use the noreturn attribute on functions that don't
+ return to prepare for the use of the -Wmissing-noreturn warning.
+
+ * jit/JITCall.cpp:
+ (JSC::unreachable): Added NO_RETURN.
+ * jsc.cpp:
+ (functionQuit): Ditto.
+ (printUsageStatement): Ditto.
+ * wtf/AlwaysInline.h: Added definition of NO_RETURN.
+
+2009-01-24 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Force inlining of Lexer::matchPunctuator
+
+ 2.2% win when parsing jQuery, Mootools, Prototype, etc
+
+ * parser/Lexer.h:
+
+2009-01-23 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix for <rdar://problem/6126212>
+ Ensure that callbacks out from the JSC interface are only allowed
+ to return in reverse-chronological order to that in which they were
+ made. If we allow earlier callbacks to return first, then this may
+ result in setions of the RegisterFile in use by another thread
+ being trampled.
+
+ See uber-comment in JSLock.h for details.
+
+ * runtime/JSLock.cpp:
+ (JSC::JSLock::DropAllLocks::DropAllLocks):
+ (JSC::JSLock::DropAllLocks::~DropAllLocks):
+
+2009-01-23 Darin Adler <darin@apple.com>
+
+ Try to fix WX build.
+
+ * runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h>
+ for the definition of UChar.
+
+2009-01-23 Anders Carlsson <andersca@apple.com>
+
+ * Configurations/Base.xcconfig:
+ GCC 4.0 build fix.
+
+ * runtime/JSNumberCell.h:
+ 64-bit build fix.
+
+2009-01-23 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Turn on -Wmissing-prototypes and fix the warnings.
+
+ * API/JSClassRef.cpp:
+ (clearReferenceToPrototype):
+ * Configurations/Base.xcconfig:
+ * runtime/Collector.cpp:
+ (JSC::getPlatformThreadRegisters):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createError):
+ * runtime/JSGlobalObjectFunctions.h:
+ * runtime/JSNumberCell.h:
+ * runtime/UString.cpp:
+ (JSC::initializeStaticBaseString):
+ (JSC::createRep):
+ * wtf/FastMalloc.cpp:
+ * wtf/Threading.cpp:
+
+2009-01-22 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Anders Carlsson.
+
+ Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
+
+ Current versions of Xcode only respect it for C and Objective-C files,
+ and our code doesn't currently compile if it is applied to C++ and
+ Objective-C++ files.
+
+ * Configurations/Base.xcconfig:
+
+2009-01-22 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=23489
+
+ Return currentTime() in correct units for the two early return cases.
+
+ Reviewed by Mark Rowe.
+
+ * wtf/CurrentTime.cpp:
+ (WTF::currentTime):
+
+2009-01-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix for <rdar://problem/6439247>
+ FastMalloc allocating an extra 4MB of meta-data on 64-bit
+
+ Rely on the fact that on all known x86-64 platforms only use 48 bits of
+ address space to shrink the initial size of the PageMap from ~4MB to 120K.
+ For 64-bit we still use a 3-level radix tree, but now each level is only 12
+ bits wide.
+
+ No performance change.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::MapSelector): Add specialization for 64 bit that takes into account the
+ 16 bits of unused address space on x86-64.
+
+2009-01-22 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
+ fast/js/numeric-conversion.html is broken, and corresponding
+ <rdar://problem/6514842>
+
+ The basic problem here is that parseInt(Infinity) should be NaN,
+ but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt):
+
+2009-01-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ <rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
+ <https://bugs.webkit.org/show_bug.cgi?id=23479>
+
+ Automatic semicolon insertion was resulting in this being accepted in the initial
+ nodeless parsing, but subsequent reparsing for code generation would fail, leading
+ to a crash. The solution is to ensure that reparsing a function performs parsing
+ in the same state as the initial parse. We do this by modifying the saved source
+ ranges to include rather than exclude the opening and closing braces.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): add an assertion for successful recompile
+ * parser/Lexer.h:
+ (JSC::Lexer::sourceCode): include rather than exclude braces.
+ * parser/Nodes.h:
+ (JSC::FunctionBodyNode::toSourceString): No need to append braces anymore.
+
+2009-01-22 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23373
+
+ Implement ThreadCondition::timedWait().
+ Since we borrow the code for condition variables from other sources,
+ I did the same for timedWait(). See comments in ThreadingWin.cpp for
+ rationale and more info.
+
+ * wtf/CONTRIBUTORS.pthreads-win32:
+ Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself
+ is included into wtf/ThreadingWin32.cpp.
+
+ * wtf/Threading.h:
+ * wtf/ThreadingWin.cpp:
+ Additional info and Pthreads-win32 license at the beginning.
+ (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32.
+ (WTF::PlatformCondition::signal): same
+ (WTF::ThreadCondition::ThreadCondition):
+ (WTF::ThreadCondition::~ThreadCondition):
+ (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait.
+ (WTF::ThreadCondition::timedWait): same
+ (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal.
+ (WTF::ThreadCondition::broadcast): same
+
+2009-01-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.
+
+ We need to check all numbers in integer switches, not just those
+ represented as integer JSImmediates.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_switch_imm):
+
+2009-01-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+
+2009-01-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23456
+ Function argument names leak
+
+ * parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
+
+2009-01-20 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Windows build fix
+
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+
+2009-01-20 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Structure property table deleted offset maps are being leaked.
+ Probably shouldn't be doing that.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23442
+
+ * runtime/Structure.cpp:
+ (JSC::Structure::~Structure):
+
+2009-01-20 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (build fix).
+
+ Attempt to fix gtk build
+
+ * GNUmakefile.am:
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ * runtime/StringPrototype.cpp:
+ (JSC::substituteBackreferences): Add back the initialization to fix the build.
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ First patch: Fix some simple cases of various warnings.
+
+ * pcre/pcre_compile.cpp:
+ (jsRegExpCompile): Use const_cast to change const-ness.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::substituteBackreferences): Remove unneeded initialization and
+ use UChar instead of unsigned short for UTF-16 values.
+
+ * wtf/dtoa.cpp:
+ (WTF::strtod): Use const_cast to change const-ness.
+
+2009-01-20 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (build fix).
+
+ Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl
+
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCoreSources.bkl:
+
+2009-01-20 Oliver Hunt <oliver@apple.com>
+
+ RS=Dan Bernstein.
+
+ Move runtime/ByteArray to wtf/ByteArray
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * runtime/JSByteArray.cpp:
+ * runtime/JSByteArray.h:
+ * wtf/ByteArray.cpp: Renamed from JavaScriptCore/runtime/ByteArray.cpp.
+ (WTF::ByteArray::create):
+ * wtf/ByteArray.h: Renamed from JavaScriptCore/runtime/ByteArray.h.
+ (WTF::ByteArray::length):
+ (WTF::ByteArray::set):
+ (WTF::ByteArray::get):
+ (WTF::ByteArray::data):
+ (WTF::ByteArray::deref):
+ (WTF::ByteArray::ByteArray):
+
+2009-01-19 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Gavin Barraclough.
+
+ Remove temporary operator-> from JSValuePtr.
+
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::call):
+ (JSC::::toNumber):
+ (JSC::::toString):
+ * API/JSObjectRef.cpp:
+ (JSObjectSetPrototype):
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsUndefined):
+ (JSValueIsNull):
+ (JSValueIsBoolean):
+ (JSValueIsNumber):
+ (JSValueIsString):
+ (JSValueIsObject):
+ (JSValueIsObjectOfClass):
+ (JSValueToBoolean):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ * bytecode/CodeBlock.cpp:
+ (JSC::valueToSourceString):
+ (JSC::CodeBlock::mark):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::isKnownNotImmediate):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitEqualityOp):
+ (JSC::keyForImmediateSwitch):
+ * interpreter/Interpreter.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAddSlowCase):
+ (JSC::jsAdd):
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::jsIsFunctionType):
+ (JSC::isNotObject):
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::throwException):
+ (JSC::cachePrototypeChain):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
+ (JSC::Interpreter::cti_op_get_by_id_proto_fail):
+ (JSC::Interpreter::cti_op_get_by_id_array_fail):
+ (JSC::Interpreter::cti_op_get_by_id_string_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_construct_JSConstruct):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_get_by_val_byte_array):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_put_by_val_byte_array):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_push_scope):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_is_boolean):
+ (JSC::Interpreter::cti_op_is_number):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_put_by_index):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_op_del_by_val):
+ (JSC::Interpreter::cti_op_put_getter):
+ (JSC::Interpreter::cti_op_put_setter):
+ (JSC::Interpreter::cti_op_new_error):
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::isJSArray):
+ (JSC::Interpreter::isJSString):
+ (JSC::Interpreter::isJSByteArray):
+ * interpreter/Register.h:
+ (JSC::Register::marked):
+ (JSC::Register::mark):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::getConstantOperandImmediateInt):
+ (JSC::JIT::isOperandConstantImmediateInt):
+ * jsc.cpp:
+ (functionPrint):
+ (functionDebug):
+ (functionRun):
+ (functionLoad):
+ (runWithScripts):
+ (runInteractive):
+ * parser/Nodes.cpp:
+ (JSC::processClauseList):
+ * profiler/ProfileGenerator.cpp:
+ (JSC::ProfileGenerator::addParentForConsoleStart):
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::createCallIdentifier):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::constructArrayWithSizeQuirk):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin):
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncReverse):
+ (JSC::arrayProtoFuncShift):
+ (JSC::arrayProtoFuncSlice):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncSplice):
+ (JSC::arrayProtoFuncUnShift):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::constructBoolean):
+ (JSC::callBooleanConstructor):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncToString):
+ (JSC::booleanProtoFuncValueOf):
+ * runtime/Collector.cpp:
+ (JSC::Heap::protect):
+ (JSC::Heap::unprotect):
+ (JSC::Heap::heap):
+ (JSC::Heap::collect):
+ (JSC::typeName):
+ * runtime/Completion.cpp:
+ (JSC::evaluate):
+ * runtime/DateConstructor.cpp:
+ (JSC::constructDate):
+ (JSC::dateParse):
+ (JSC::dateUTC):
+ * runtime/DateInstance.h:
+ (JSC::DateInstance::internalNumber):
+ * runtime/DatePrototype.cpp:
+ (JSC::formatLocaleDate):
+ (JSC::fillStructuresUsingTimeArgs):
+ (JSC::fillStructuresUsingDateArgs):
+ (JSC::dateProtoFuncToString):
+ (JSC::dateProtoFuncToUTCString):
+ (JSC::dateProtoFuncToDateString):
+ (JSC::dateProtoFuncToTimeString):
+ (JSC::dateProtoFuncToLocaleString):
+ (JSC::dateProtoFuncToLocaleDateString):
+ (JSC::dateProtoFuncToLocaleTimeString):
+ (JSC::dateProtoFuncGetTime):
+ (JSC::dateProtoFuncGetFullYear):
+ (JSC::dateProtoFuncGetUTCFullYear):
+ (JSC::dateProtoFuncToGMTString):
+ (JSC::dateProtoFuncGetMonth):
+ (JSC::dateProtoFuncGetUTCMonth):
+ (JSC::dateProtoFuncGetDate):
+ (JSC::dateProtoFuncGetUTCDate):
+ (JSC::dateProtoFuncGetDay):
+ (JSC::dateProtoFuncGetUTCDay):
+ (JSC::dateProtoFuncGetHours):
+ (JSC::dateProtoFuncGetUTCHours):
+ (JSC::dateProtoFuncGetMinutes):
+ (JSC::dateProtoFuncGetUTCMinutes):
+ (JSC::dateProtoFuncGetSeconds):
+ (JSC::dateProtoFuncGetUTCSeconds):
+ (JSC::dateProtoFuncGetMilliSeconds):
+ (JSC::dateProtoFuncGetUTCMilliseconds):
+ (JSC::dateProtoFuncGetTimezoneOffset):
+ (JSC::dateProtoFuncSetTime):
+ (JSC::setNewValueFromTimeArgs):
+ (JSC::setNewValueFromDateArgs):
+ (JSC::dateProtoFuncSetYear):
+ (JSC::dateProtoFuncGetYear):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::constructError):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::errorProtoFuncToString):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createError):
+ (JSC::createErrorMessage):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncToString):
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall):
+ * runtime/GetterSetter.cpp:
+ (JSC::GetterSetter::toObject):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::getOwnPropertySlot):
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::put):
+ (JSC::JSArray::mark):
+ (JSC::JSArray::sort):
+ (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
+ (JSC::JSArray::compactForSorting):
+ * runtime/JSByteArray.h:
+ (JSC::JSByteArray::setIndex):
+ * runtime/JSCell.h:
+ (JSC::asCell):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::call):
+ (JSC::JSFunction::construct):
+ * runtime/JSGlobalObject.cpp:
+ (JSC::markIfNeeded):
+ (JSC::lastInPrototypeChain):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::encode):
+ (JSC::decode):
+ (JSC::globalFuncEval):
+ (JSC::globalFuncParseInt):
+ (JSC::globalFuncParseFloat):
+ (JSC::globalFuncIsNaN):
+ (JSC::globalFuncIsFinite):
+ (JSC::globalFuncEscape):
+ (JSC::globalFuncUnescape):
+ (JSC::globalFuncJSCPrint):
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject):
+ (JSC::JSImmediate::toObject):
+ (JSC::JSImmediate::prototype):
+ (JSC::JSImmediate::toString):
+ * runtime/JSImmediate.h:
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::put):
+ (JSC::callDefaultValueFunction):
+ (JSC::JSObject::getPrimitiveNumber):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ (JSC::JSObject::lookupGetter):
+ (JSC::JSObject::lookupSetter):
+ (JSC::JSObject::hasInstance):
+ (JSC::JSObject::toNumber):
+ (JSC::JSObject::toString):
+ * runtime/JSObject.h:
+ (JSC::JSObject::JSObject):
+ (JSC::JSObject::inlineGetOwnPropertySlot):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSObject::getPropertySlot):
+ (JSC::JSValuePtr::get):
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::create):
+ * runtime/JSString.cpp:
+ (JSC::JSString::getOwnPropertySlot):
+ * runtime/JSValue.h:
+ * runtime/JSWrapperObject.cpp:
+ (JSC::JSWrapperObject::mark):
+ * runtime/JSWrapperObject.h:
+ (JSC::JSWrapperObject::setInternalValue):
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncAbs):
+ (JSC::mathProtoFuncACos):
+ (JSC::mathProtoFuncASin):
+ (JSC::mathProtoFuncATan):
+ (JSC::mathProtoFuncATan2):
+ (JSC::mathProtoFuncCeil):
+ (JSC::mathProtoFuncCos):
+ (JSC::mathProtoFuncExp):
+ (JSC::mathProtoFuncFloor):
+ (JSC::mathProtoFuncLog):
+ (JSC::mathProtoFuncMax):
+ (JSC::mathProtoFuncMin):
+ (JSC::mathProtoFuncPow):
+ (JSC::mathProtoFuncRound):
+ (JSC::mathProtoFuncSin):
+ (JSC::mathProtoFuncSqrt):
+ (JSC::mathProtoFuncTan):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ (JSC::NativeErrorConstructor::construct):
+ * runtime/NumberConstructor.cpp:
+ (JSC::constructWithNumberConstructor):
+ (JSC::callNumberConstructor):
+ * runtime/NumberPrototype.cpp:
+ (JSC::numberProtoFuncToString):
+ (JSC::numberProtoFuncToLocaleString):
+ (JSC::numberProtoFuncValueOf):
+ (JSC::numberProtoFuncToFixed):
+ (JSC::numberProtoFuncToExponential):
+ (JSC::numberProtoFuncToPrecision):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::constructObject):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncValueOf):
+ (JSC::objectProtoFuncHasOwnProperty):
+ (JSC::objectProtoFuncIsPrototypeOf):
+ (JSC::objectProtoFuncDefineGetter):
+ (JSC::objectProtoFuncDefineSetter):
+ (JSC::objectProtoFuncLookupGetter):
+ (JSC::objectProtoFuncLookupSetter):
+ (JSC::objectProtoFuncPropertyIsEnumerable):
+ (JSC::objectProtoFuncToLocaleString):
+ (JSC::objectProtoFuncToString):
+ * runtime/Operations.h:
+ (JSC::JSValuePtr::equalSlowCaseInline):
+ (JSC::JSValuePtr::strictEqual):
+ (JSC::JSValuePtr::strictEqualSlowCaseInline):
+ * runtime/Protect.h:
+ (JSC::gcProtect):
+ (JSC::gcUnprotect):
+ * runtime/RegExpConstructor.cpp:
+ (JSC::setRegExpConstructorInput):
+ (JSC::setRegExpConstructorMultiline):
+ (JSC::constructRegExp):
+ * runtime/RegExpObject.cpp:
+ (JSC::setRegExpObjectLastIndex):
+ (JSC::RegExpObject::match):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncTest):
+ (JSC::regExpProtoFuncExec):
+ (JSC::regExpProtoFuncCompile):
+ (JSC::regExpProtoFuncToString):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCodeSlowCase):
+ (JSC::stringFromCharCode):
+ (JSC::constructWithStringConstructor):
+ (JSC::callStringConstructor):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncToString):
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncIndexOf):
+ (JSC::stringProtoFuncLastIndexOf):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ (JSC::stringProtoFuncSlice):
+ (JSC::stringProtoFuncSplit):
+ (JSC::stringProtoFuncSubstr):
+ (JSC::stringProtoFuncSubstring):
+ (JSC::stringProtoFuncToLowerCase):
+ (JSC::stringProtoFuncToUpperCase):
+ (JSC::stringProtoFuncLocaleCompare):
+ (JSC::stringProtoFuncBig):
+ (JSC::stringProtoFuncSmall):
+ (JSC::stringProtoFuncBlink):
+ (JSC::stringProtoFuncBold):
+ (JSC::stringProtoFuncFixed):
+ (JSC::stringProtoFuncItalics):
+ (JSC::stringProtoFuncStrike):
+ (JSC::stringProtoFuncSub):
+ (JSC::stringProtoFuncSup):
+ (JSC::stringProtoFuncFontcolor):
+ (JSC::stringProtoFuncFontsize):
+ (JSC::stringProtoFuncAnchor):
+ (JSC::stringProtoFuncLink):
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure):
+ (JSC::Structure::getEnumerablePropertyNames):
+ (JSC::Structure::createCachedPrototypeChain):
+ * runtime/Structure.h:
+ (JSC::Structure::mark):
+ * runtime/StructureChain.cpp:
+ (JSC::StructureChain::StructureChain):
+
+2009-01-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
+ <https://bugs.webkit.org/show_bug.cgi?id=23409>
+ <rdar://problem/6505723>
+
+ Test: fast/js/string-replace-3.html
+
+ * runtime/StringPrototype.cpp:
+ (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure
+ how this ever worked.
+
+2009-01-16 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
+ registers, save reloading them every time they're used.
+
+ Draws x86-64 jit performance close to that of i386 jit.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::subPtr):
+ (JSC::MacroAssembler::jnzPtr):
+ (JSC::MacroAssembler::jzPtr):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpIfJSCell):
+ (JSC::JIT::emitJumpIfNotJSCell):
+ (JSC::JIT::emitJumpIfImmediateNumber):
+ (JSC::JIT::emitJumpIfNotImmediateNumber):
+ (JSC::JIT::emitJumpIfImmediateInteger):
+ (JSC::JIT::emitJumpIfNotImmediateInteger):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+
+2009-01-16 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add support to x86-64 JIT for inline double precision arithmetic ops.
+ +5/6% on x86-64, JIT enabled, sunspider.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::addPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::movq_rr):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArithSlow_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArithSlow_op_mul):
+ (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::compileFastArithSlow_op_sub):
+ * parser/ResultType.h:
+ (JSC::ResultType::isReusable):
+ (JSC::ResultType::isInt32):
+ (JSC::ResultType::definitelyIsNumber):
+ (JSC::ResultType::mightBeNumber):
+ (JSC::ResultType::isNotNumber):
+ (JSC::ResultType::unknownType):
+
+2009-01-16 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fixes for SamplingTool.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23390
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::storePtr):
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingTool::run):
+ (JSC::SamplingTool::dump):
+ * bytecode/SamplingTool.h:
+ (JSC::SamplingTool::encodeSample):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ (JSC::JIT::samplingToolTrackCodeBlock):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitCTICall_internal):
+
+2009-01-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
+ turn "c" into "" when stripping \\c_ character
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing
+ control escapes inside character classes.
+
+2009-01-16 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parseParentheses): Removed unreachable code.
+
+2009-01-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
+ on assertion gives incorrect result (23075)
+
+ https://bugs.webkit.org/show_bug.cgi?id=23075
+
+ * pcre/pcre_compile.cpp:
+ (compileBranch): Throw away an assertion if it's followed by a quantifier
+ with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare
+ case of an assertion with a quantifier with a 0 minimum, since we
+ don't handle quantified subexpressions yet, and in this special case,
+ we can't just throw away the quantifier.
+
+2009-01-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add support in ResultType to track that the results of bitops
+ are always of type int32_t.
+
+ * parser/Nodes.cpp:
+ (JSC::ReadModifyResolveNode::emitBytecode):
+ (JSC::ReadModifyDotNode::emitBytecode):
+ (JSC::ReadModifyBracketNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::):
+ (JSC::BooleanNode::):
+ (JSC::NumberNode::):
+ (JSC::StringNode::):
+ (JSC::PrePostResolveNode::):
+ (JSC::TypeOfResolveNode::):
+ (JSC::TypeOfValueNode::):
+ (JSC::UnaryPlusNode::):
+ (JSC::NegateNode::):
+ (JSC::BitwiseNotNode::):
+ (JSC::LogicalNotNode::):
+ (JSC::MultNode::):
+ (JSC::DivNode::):
+ (JSC::ModNode::):
+ (JSC::SubNode::):
+ (JSC::LeftShiftNode::):
+ (JSC::RightShiftNode::):
+ (JSC::UnsignedRightShiftNode::):
+ (JSC::LessNode::):
+ (JSC::GreaterNode::):
+ (JSC::LessEqNode::):
+ (JSC::GreaterEqNode::):
+ (JSC::InstanceOfNode::):
+ (JSC::EqualNode::):
+ (JSC::NotEqualNode::):
+ (JSC::StrictEqualNode::):
+ (JSC::NotStrictEqualNode::):
+ (JSC::BitAndNode::):
+ (JSC::BitOrNode::):
+ (JSC::BitXOrNode::):
+ (JSC::LogicalOpNode::):
+ * parser/ResultType.h:
+ (JSC::ResultType::isInt32):
+ (JSC::ResultType::isNotNumber):
+ (JSC::ResultType::booleanType):
+ (JSC::ResultType::numberType):
+ (JSC::ResultType::numberTypeCanReuse):
+ (JSC::ResultType::numberTypeCanReuseIsInt32):
+ (JSC::ResultType::stringOrNumberTypeCanReuse):
+ (JSC::ResultType::stringType):
+ (JSC::ResultType::unknownType):
+ (JSC::ResultType::forAdd):
+ (JSC::ResultType::forBitOp):
+ (JSC::OperandTypes::OperandTypes):
+
+2009-01-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add support for integer addition, subtraction and multiplication
+ in JIT code on x86-64.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::mul32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::joMul32):
+ (JSC::MacroAssembler::joSub32):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArithSlow_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArithSlow_op_mul):
+ (JSC::JIT::compileFastArith_op_sub):
+ (JSC::JIT::compileFastArithSlow_op_sub):
+
+2009-01-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ On x86-64 allow JSImmediate to encode 64-bit double precision values.
+ This patch only affects builds that set USE(ALTERNATE_JSIMMEDIATE).
+ Updates the implementation of JSValuePtr:: and JSImmediate:: methods
+ that operate on neumeric values to be be aware of the new representation.
+ When this representation is in use, the class JSNumberCell is redundant
+ and is compiled out.
+
+ The format of the new immediate representation is documented in JSImmediate.h.
+
+ * JavaScriptCore.exp:
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::subPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::subq_rr):
+ (JSC::X86Assembler::movq_rr):
+ (JSC::X86Assembler::ucomisd_rr):
+ (JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_lshift):
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArith_op_bitand):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArith_op_post_inc):
+ (JSC::JIT::compileFastArith_op_post_dec):
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileFastArith_op_pre_dec):
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpIfBothJSCells):
+ (JSC::JIT::emitJumpIfEitherNumber):
+ (JSC::JIT::emitJumpIfNotEitherNumber):
+ (JSC::JIT::emitJumpIfImmediateIntegerNumber):
+ (JSC::JIT::emitJumpIfNotImmediateIntegerNumber):
+ (JSC::JIT::emitJumpIfNotImmediateIntegerNumbers):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumber):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumbers):
+ (JSC::JIT::emitFastArithDeTagImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+ * runtime/JSCell.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject):
+ (JSC::JSImmediate::toObject):
+ (JSC::JSImmediate::toString):
+ * runtime/JSImmediate.h:
+ (JSC::wtf_reinterpret_cast):
+ (JSC::JSImmediate::isNumber):
+ (JSC::JSImmediate::isIntegerNumber):
+ (JSC::JSImmediate::isDoubleNumber):
+ (JSC::JSImmediate::isPositiveIntegerNumber):
+ (JSC::JSImmediate::areBothImmediateIntegerNumbers):
+ (JSC::JSImmediate::makeInt):
+ (JSC::JSImmediate::makeDouble):
+ (JSC::JSImmediate::doubleValue):
+ (JSC::doubleToBoolean):
+ (JSC::JSImmediate::toBoolean):
+ (JSC::JSImmediate::getTruncatedUInt32):
+ (JSC::JSImmediate::makeOutOfIntegerRange):
+ (JSC::JSImmediate::from):
+ (JSC::JSImmediate::getTruncatedInt32):
+ (JSC::JSImmediate::toDouble):
+ (JSC::JSImmediate::getUInt32):
+ (JSC::JSValuePtr::isInt32Fast):
+ (JSC::JSValuePtr::isUInt32Fast):
+ (JSC::JSValuePtr::areBothInt32Fast):
+ (JSC::JSFastMath::canDoFastBitwiseOperations):
+ (JSC::JSFastMath::xorImmediateNumbers):
+ (JSC::JSFastMath::canDoFastRshift):
+ (JSC::JSFastMath::canDoFastUrshift):
+ (JSC::JSFastMath::rightShiftImmediateNumbers):
+ (JSC::JSFastMath::canDoFastAdditiveOperations):
+ (JSC::JSFastMath::addImmediateNumbers):
+ (JSC::JSFastMath::subImmediateNumbers):
+ * runtime/JSNumberCell.cpp:
+ (JSC::jsNumberCell):
+ * runtime/JSNumberCell.h:
+ (JSC::createNumberStructure):
+ (JSC::isNumberCell):
+ (JSC::asNumberCell):
+ (JSC::jsNumber):
+ (JSC::JSValuePtr::isDoubleNumber):
+ (JSC::JSValuePtr::getDoubleNumber):
+ (JSC::JSValuePtr::isNumber):
+ (JSC::JSValuePtr::uncheckedGetNumber):
+ (JSC::jsNaN):
+ (JSC::JSValuePtr::getNumber):
+ (JSC::JSValuePtr::numberToInt32):
+ (JSC::JSValuePtr::numberToUInt32):
+ * runtime/JSValue.h:
+ * runtime/NumberConstructor.cpp:
+ (JSC::numberConstructorNegInfinity):
+ (JSC::numberConstructorPosInfinity):
+ (JSC::numberConstructorMaxValue):
+ (JSC::numberConstructorMinValue):
+ * runtime/NumberObject.cpp:
+ (JSC::constructNumber):
+ * runtime/NumberObject.h:
+ * runtime/Operations.h:
+ (JSC::JSValuePtr::equal):
+ (JSC::JSValuePtr::equalSlowCaseInline):
+ (JSC::JSValuePtr::strictEqual):
+ (JSC::JSValuePtr::strictEqualSlowCaseInline):
+ * wtf/Platform.h:
+
+2009-01-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ <rdar://problem/6045018>
+ REGRESSION (r34838): JavaScript objects appear to be leaked after loading google.com
+
+ Subtract the number of JSStrings cached in SmallStrings when calculating the
+ number of live JSObjects.
+
+ * runtime/Collector.cpp:
+ (JSC::Heap::objectCount):
+ * runtime/SmallStrings.cpp:
+ (JSC::SmallStrings::count):
+ * runtime/SmallStrings.h:
+
+2009-01-15 Sam Weinig <sam@webkit.org>
+
+ Fix Qt build.
+
+ * runtime/Collector.cpp:
+
+2009-01-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix crash seen running fast/canvas.
+
+ Make sure to mark the ScopeNode and CodeBlock being created
+ in the re-parse for exception information.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
+ * parser/Nodes.h:
+ (JSC::ScopeNode::mark):
+ * runtime/Collector.cpp:
+ (JSC::Heap::collect):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSGlobalData.h:
+
+2009-01-15 Craig Schlenter <craig.schlenter@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23347
+ Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails on Linux
+
+ * wtf/ThreadingPthreads.cpp: included limits.h as INT_MAX is defined there.
+
+2009-01-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at sfgate.com
+ <https://bugs.webkit.org/show_bug.cgi?id=23225> <rdar://problem/6487432>
+
+ Character position for open and closing brace was incorrectly referencing m_position to
+ record their position in a source document, however this is unsafe as BOMs may lead to
+ m_position being an arbitrary position from the real position of the current character.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::matchPunctuator):
+
+2009-01-14 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23153>
+
+ Reviewed by Darin Adler.
+
+ Instead of building bytecode.html into ${SRCROOT}/docs/bytecode.html, build it
+ into ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/docs/bytecode.html.
+
+ Also fixes make-bytecode-docs.pl to actually generate documentation.
+
+ * DerivedSources.make: Changed bytecode.html to be built into local docs
+ directory in ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Added "/docs" to the end of the
+ "mkdir -p" command so that the docs subdirectory is automatically created.
+ * docs/make-bytecode-docs.pl: Changed BEGIN_OPCODE to DEFINE_OPCODE so that
+ documentation is actually generated.
+
+2009-01-14 Adam Treat <adam.treat@torchmobile.com>
+
+ Build fix for Qt from Dmitry Titov.
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::ThreadCondition::timedWait):
+
+2009-01-14 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly
+
+ EvalCodeBlock's do not reference the functions that are declared inside the eval
+ code, this means that simply marking the EvalCodeBlock through the global object
+ is insufficient to mark the declared functions. This patch corrects this by
+ explicitly marking the CodeBlocks of all the functions declared in the cached
+ EvalNode.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::mark):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::hasFunctions):
+ * bytecode/EvalCodeCache.h:
+ (JSC::EvalCodeCache::mark):
+ * parser/Nodes.cpp:
+ (JSC::ScopeNodeData::mark):
+ (JSC::EvalNode::mark):
+ * parser/Nodes.h:
+
+2009-01-14 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23312
+ Implement MessageQueue::waitForMessageTimed()
+ Also fixed ThreadCondition::timedWait() to take absolute time, as discussed on webkit-dev.
+ Win32 version of timedWait still has to be implemented.
+
+ * wtf/MessageQueue.h:
+ (WTF::MessageQueueWaitResult: new enum for the result of MessageQueue::waitForMessageTimed.
+ (WTF::MessageQueue::waitForMessage):
+ (WTF::MessageQueue::waitForMessageTimed): New method.
+ * wtf/Threading.h:
+ * wtf/ThreadingGtk.cpp:
+ (WTF::ThreadCondition::timedWait): changed to use absolute time instead of interval.
+ * wtf/ThreadingNone.cpp:
+ (WTF::ThreadCondition::timedWait): ditto.
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::ThreadCondition::timedWait): ditto.
+ * wtf/ThreadingQt.cpp:
+ (WTF::ThreadCondition::timedWait): ditto.
+ * wtf/ThreadingWin.cpp:
+ (WTF::ThreadCondition::timedWait): ditto. The actual Win32 code is still to be implemented.
+
+2009-01-14 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Darin Adler and Oliver hunt.
+
+ Correctly match allocation functions by implementing a custom deref().
+
+ https://bugs.webkit.org/show_bug.cgi?id=23315
+
+ * runtime/ByteArray.h:
+ (JSC::ByteArray::deref):
+ (JSC::ByteArray::ByteArray):
+
+2009-01-14 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - update copyright
+
+ * Info.plist:
+
+2009-01-13 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler and Oliver Hunt.
+
+ <rdar://problem/6489314> REGRESSION: Business widget's front side
+ fails to render correctly when flipping widget
+
+ The problem here is that parseInt was parsing NaN as 0. This patch
+ corrects that by parsing NaN as NaN. This matches our old behavior
+ and Firefox.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt):
+
+2009-01-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for: https://bugs.webkit.org/show_bug.cgi?id=23292
+
+ Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.
+
+ * runtime/JSImmediate.h:
+ (JSC::JSFastMath::canDoFastAdditiveOperations):
+
+2009-01-13 Zalan Bujtas <zbujtas@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23290
+ Fix JSImmediate::isImmediate(src) to !src->isCell()
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+
+2009-01-13 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23281
+ Fix the Chromium Win build.
+ Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
+ Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
+ while they have their own implementation even on Windows.
+
+ * wtf/CurrentTime.cpp:
+ (WTF::currentTime):
+
+2009-01-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Make the JSImmediate interface private.
+
+ All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
+ directly. The key missing methods on JSValuePtr are:
+
+ * isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
+ * isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
+ * isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.
+
+ The JIT is allowed full access to JSImmediate, since it needs to be able to directly
+ manipulate JSValuePtrs. The Interpreter is provided access to perform operations directly
+ on JSValuePtrs through the new JSFastMath interface.
+
+ No performance impact.
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::toNumber):
+ * API/JSValueRef.cpp:
+ (JSValueIsEqual):
+ (JSValueIsStrictEqual):
+ * JavaScriptCore.exp:
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::isKnownNotImmediate):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::keyForImmediateSwitch):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
+ (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
+ * interpreter/Interpreter.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAdd):
+ (JSC::jsIsObjectType):
+ (JSC::cachePrototypeChain):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_get_by_val_byte_array):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_put_by_val_byte_array):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_call_eval):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_vm_throw):
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::isJSArray):
+ (JSC::Interpreter::isJSString):
+ (JSC::Interpreter::isJSByteArray):
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JIT.h:
+ (JSC::JIT::isStrictEqCaseHandledInJITCode):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArith_op_bitand):
+ (JSC::JIT::compileFastArith_op_mod):
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::compileOpCall):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::getConstantOperandImmediateInt):
+ (JSC::JIT::isOperandConstantImmediateInt):
+ * parser/Nodes.cpp:
+ (JSC::processClauseList):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncValueOf):
+ * runtime/Collector.cpp:
+ (JSC::Heap::protect):
+ (JSC::Heap::unprotect):
+ (JSC::Heap::heap):
+ * runtime/JSByteArray.cpp:
+ (JSC::JSByteArray::getOwnPropertySlot):
+ * runtime/JSByteArray.h:
+ (JSC::JSByteArray::getIndex):
+ * runtime/JSCell.cpp:
+ * runtime/JSCell.h:
+ (JSC::JSValuePtr::isNumberCell):
+ (JSC::JSValuePtr::asCell):
+ (JSC::JSValuePtr::isNumber):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt):
+ * runtime/JSImmediate.h:
+ (JSC::js0):
+ (JSC::jsImpossibleValue):
+ (JSC::JSValuePtr::toInt32):
+ (JSC::JSValuePtr::toUInt32):
+ (JSC::JSValuePtr::isCell):
+ (JSC::JSValuePtr::isInt32Fast):
+ (JSC::JSValuePtr::getInt32Fast):
+ (JSC::JSValuePtr::isUInt32Fast):
+ (JSC::JSValuePtr::getUInt32Fast):
+ (JSC::JSValuePtr::makeInt32Fast):
+ (JSC::JSValuePtr::areBothInt32Fast):
+ (JSC::JSFastMath::canDoFastBitwiseOperations):
+ (JSC::JSFastMath::equal):
+ (JSC::JSFastMath::notEqual):
+ (JSC::JSFastMath::andImmediateNumbers):
+ (JSC::JSFastMath::xorImmediateNumbers):
+ (JSC::JSFastMath::orImmediateNumbers):
+ (JSC::JSFastMath::canDoFastRshift):
+ (JSC::JSFastMath::canDoFastUrshift):
+ (JSC::JSFastMath::rightShiftImmediateNumbers):
+ (JSC::JSFastMath::canDoFastAdditiveOperations):
+ (JSC::JSFastMath::addImmediateNumbers):
+ (JSC::JSFastMath::subImmediateNumbers):
+ (JSC::JSFastMath::incImmediateNumber):
+ (JSC::JSFastMath::decImmediateNumber):
+ * runtime/JSNumberCell.h:
+ (JSC::JSValuePtr::asNumberCell):
+ (JSC::jsNumber):
+ (JSC::JSValuePtr::uncheckedGetNumber):
+ (JSC::JSNumberCell::toInt32):
+ (JSC::JSNumberCell::toUInt32):
+ (JSC::JSValuePtr::toJSNumber):
+ (JSC::JSValuePtr::getNumber):
+ (JSC::JSValuePtr::numberToInt32):
+ (JSC::JSValuePtr::numberToUInt32):
+ * runtime/JSObject.h:
+ (JSC::JSValuePtr::isObject):
+ (JSC::JSValuePtr::get):
+ (JSC::JSValuePtr::put):
+ * runtime/JSValue.cpp:
+ (JSC::JSValuePtr::toInteger):
+ (JSC::JSValuePtr::toIntegerPreserveNaN):
+ * runtime/JSValue.h:
+ * runtime/Operations.cpp:
+ (JSC::JSValuePtr::equalSlowCase):
+ (JSC::JSValuePtr::strictEqualSlowCase):
+ * runtime/Operations.h:
+ (JSC::JSValuePtr::equal):
+ (JSC::JSValuePtr::equalSlowCaseInline):
+ (JSC::JSValuePtr::strictEqual):
+ (JSC::JSValuePtr::strictEqualSlowCaseInline):
+ * runtime/Protect.h:
+ (JSC::gcProtect):
+ (JSC::gcUnprotect):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ * runtime/Structure.cpp:
+ (JSC::Structure::createCachedPrototypeChain):
+
+2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ Since date time functions have moved here, now the wx port JSC
+ needs to depend on wx.
+
+ * jscore.bkl:
+
+2009-01-11 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23245
+
+ Add initializeThreading to key places in JS API to ensure that
+ UString is properly initialized.
+
+ * API/JSContextRef.cpp:
+ (JSContextGroupCreate):
+ (JSGlobalContextCreate):
+ * API/JSObjectRef.cpp:
+ (JSClassCreate):
+ * API/JSStringRef.cpp:
+ (JSStringCreateWithCharacters):
+ (JSStringCreateWithUTF8CString):
+ * API/JSStringRefCF.cpp:
+ (JSStringCreateWithCFString):
+
+2009-01-11 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23175
+
+ Separate out BaseString information from UString::Rep and make all baseString access go through
+ a member function, so that it may be used for something else (in the future) in the BaseString
+ case.
+
+ * runtime/SmallStrings.cpp:
+ (JSC::SmallStringsStorage::rep):
+ (JSC::SmallStringsStorage::SmallStringsStorage):
+ (JSC::SmallStrings::SmallStrings):
+ (JSC::SmallStrings::mark):
+ Adjust to account for the changes in UString and put the UString in place in
+ SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.
+
+ * runtime/SmallStrings.h:
+ * runtime/UString.cpp:
+ (JSC::initializeStaticBaseString):
+ (JSC::initializeUString):
+ (JSC::UString::Rep::create):
+ (JSC::UString::Rep::destroy):
+ (JSC::UString::Rep::checkConsistency):
+ (JSC::expandCapacity):
+ (JSC::UString::expandPreCapacity):
+ (JSC::concatenate):
+ (JSC::UString::append):
+ (JSC::UString::operator=):
+ * runtime/UString.h:
+ (JSC::UString::Rep::baseIsSelf):
+ (JSC::UString::Rep::setBaseString):
+ (JSC::UString::Rep::baseString):
+ (JSC::UString::Rep::):
+ (JSC::UString::Rep::null):
+ (JSC::UString::Rep::empty):
+ (JSC::UString::Rep::data):
+ (JSC::UString::cost):
+ Separate out the items out used by base strings from those used in Rep's that only
+ point to base strings. (This potentially saves 24 bytes per Rep.)
+
+2009-01-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23239: improve handling of unused arguments in JavaScriptCore
+ https://bugs.webkit.org/show_bug.cgi?id=23239
+
+ * runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if
+ so we can use this on all platforms. Changed valueOf to share the same
+ function with getTime, since the contents of the two are identical. Removed
+ a FIXME since the idea isn't really specific enough or helpful enough to
+ need to sit here in the source code.
+ (JSC::formatLocaleDate): Changed the Mac version of this function to take
+ the same arguments as the non-Mac version so the caller doesn't have to
+ special-case the two platforms. Also made the formatString array be const;
+ before the characters were, but the array was a modifiable global variable.
+ (JSC::dateProtoFuncToLocaleString): Changed to call the new unified
+ version of formatLocaleDate and remove the ifdef.
+ (JSC::dateProtoFuncToLocaleDateString): Ditto.
+ (JSC::dateProtoFuncToLocaleTimeString): Ditto.
+
+ * runtime/JSNotAnObject.cpp:
+ (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the
+ old UNUSED_PARAM.
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter
+ is actually unused.
+
+ * wtf/TCSystemAlloc.cpp:
+ (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter
+ is actually unused.
+ (TCMalloc_SystemCommit): Changed to omit the argument names instead of using
+ UNUSED_PARAM.
+
+2009-01-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix the build (whoops)
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_get_by_val):
+
+2009-01-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler and Anders Carlsson
+
+ Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
+
+ Restructure the code slightly, and add comments per Darin's suggestions
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_get_by_val_byte_array):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_byte_array):
+
+2009-01-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Whoops, I accidentally removed an exception check from fast the
+ fast path for string indexing when i originally landed the
+ byte array logic.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_get_by_val):
+
+2009-01-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
+ <https://bugs.webkit.org/show_bug.cgi?id=23128>
+
+ Fairly simple patch, add specialised versions of cti_op_get/put_by_val
+ that assume ByteArray, thus avoiding a few branches in the case of bytearray
+ manipulation.
+
+ No effect on SunSpider. 15% win on the original testcase.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_get_by_val_byte_array):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_byte_array):
+ * interpreter/Interpreter.h:
+
+2009-01-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Try to fix Windows build.
+
+ * wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in
+ DateMath.cpp, with constant definition in DateTime.h)
+
+2009-01-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Try to fix Windows build.
+
+ * wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.
+
+2009-01-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23207
+ Moved currentTime() to from WebCore to WTF.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp: added export for WTF::currentTime()
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * runtime/DateMath.cpp:
+ (JSC::getCurrentUTCTimeWithMicroseconds): This function had another implementation of currentTime(), essentially. Now uses WTF version.
+ * wtf/CurrentTime.cpp: Added.
+ (WTF::currentTime):
+ (WTF::highResUpTime):
+ (WTF::lowResUTCTime):
+ (WTF::qpcAvailable):
+ * wtf/CurrentTime.h: Added.
+
+2009-01-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Stage two of converting JSValue from a pointer to a class type.
+ Remove the class JSValue. The functionallity has been transitioned
+ into the wrapper class type JSValuePtr.
+
+ The last stage will be to rename JSValuePtr to JSValue, remove the
+ overloaded -> operator, and switch operations on JSValuePtrs from
+ using '->' to use '.' instead.
+
+ * API/APICast.h:
+ * JavaScriptCore.exp:
+ * runtime/JSCell.h:
+ (JSC::asCell):
+ (JSC::JSValuePtr::asCell):
+ (JSC::JSValuePtr::isNumber):
+ (JSC::JSValuePtr::isString):
+ (JSC::JSValuePtr::isGetterSetter):
+ (JSC::JSValuePtr::isObject):
+ (JSC::JSValuePtr::getNumber):
+ (JSC::JSValuePtr::getString):
+ (JSC::JSValuePtr::getObject):
+ (JSC::JSValuePtr::getCallData):
+ (JSC::JSValuePtr::getConstructData):
+ (JSC::JSValuePtr::getUInt32):
+ (JSC::JSValuePtr::getTruncatedInt32):
+ (JSC::JSValuePtr::getTruncatedUInt32):
+ (JSC::JSValuePtr::mark):
+ (JSC::JSValuePtr::marked):
+ (JSC::JSValuePtr::toPrimitive):
+ (JSC::JSValuePtr::getPrimitiveNumber):
+ (JSC::JSValuePtr::toBoolean):
+ (JSC::JSValuePtr::toNumber):
+ (JSC::JSValuePtr::toString):
+ (JSC::JSValuePtr::toObject):
+ (JSC::JSValuePtr::toThisObject):
+ (JSC::JSValuePtr::needsThisConversion):
+ (JSC::JSValuePtr::toThisString):
+ (JSC::JSValuePtr::getJSNumber):
+ * runtime/JSImmediate.h:
+ (JSC::JSValuePtr::isUndefined):
+ (JSC::JSValuePtr::isNull):
+ (JSC::JSValuePtr::isUndefinedOrNull):
+ (JSC::JSValuePtr::isBoolean):
+ (JSC::JSValuePtr::getBoolean):
+ (JSC::JSValuePtr::toInt32):
+ (JSC::JSValuePtr::toUInt32):
+ * runtime/JSNumberCell.h:
+ (JSC::JSValuePtr::uncheckedGetNumber):
+ (JSC::JSValuePtr::toJSNumber):
+ * runtime/JSObject.h:
+ (JSC::JSValuePtr::isObject):
+ (JSC::JSValuePtr::get):
+ (JSC::JSValuePtr::put):
+ * runtime/JSString.h:
+ (JSC::JSValuePtr::toThisJSString):
+ * runtime/JSValue.cpp:
+ (JSC::JSValuePtr::toInteger):
+ (JSC::JSValuePtr::toIntegerPreserveNaN):
+ (JSC::JSValuePtr::toInt32SlowCase):
+ (JSC::JSValuePtr::toUInt32SlowCase):
+ * runtime/JSValue.h:
+ (JSC::JSValuePtr::makeImmediate):
+ (JSC::JSValuePtr::immediateValue):
+ (JSC::JSValuePtr::JSValuePtr):
+ (JSC::JSValuePtr::operator->):
+ (JSC::JSValuePtr::operator bool):
+ (JSC::JSValuePtr::operator==):
+ (JSC::JSValuePtr::operator!=):
+ (JSC::JSValuePtr::encode):
+ (JSC::JSValuePtr::decode):
+ (JSC::JSValuePtr::toFloat):
+ (JSC::JSValuePtr::asValue):
+ (JSC::operator==):
+ (JSC::operator!=):
+
+2009-01-09 David Levin <levin@chromium.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23175
+
+ Adjustment to previous patch. Remove call to initilizeThreading from JSGlobalCreate
+ and fix jsc.cpp instead.
+
+ * jsc.cpp:
+ (main):
+ (jscmain):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::create):
+
+2009-01-09 Sam Weinig <sam@webkit.org>
+
+ Roll r39720 back in with a working interpreted mode.
+
+2009-01-09 David Levin <levin@chromium.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23175
+
+ Added a template to make the pointer and flags combination
+ in UString more readable and less error prone.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Added PtrAndFlags.h (and sorted the xcode project file).
+
+ * runtime/Identifier.cpp:
+ (JSC::Identifier::add):
+ (JSC::Identifier::addSlowCase):
+ * runtime/InitializeThreading.cpp:
+ (JSC::initializeThreadingOnce):
+ Made the init threading initialize the UString globals. Before
+ these were initilized using {} but that became harder due to the
+ addition of this tempalte class.
+
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::create):
+ * runtime/PropertyNameArray.cpp:
+ (JSC::PropertyNameArray::add):
+ * runtime/UString.cpp:
+ (JSC::initializeStaticBaseString):
+ (JSC::initializeUString):
+ (JSC::UString::Rep::create):
+ (JSC::UString::Rep::createFromUTF8):
+ (JSC::createRep):
+ (JSC::UString::UString):
+ (JSC::concatenate):
+ (JSC::UString::operator=):
+ (JSC::UString::makeNull):
+ (JSC::UString::nullRep):
+ * runtime/UString.h:
+ (JSC::UString::Rep::identifierTable):
+ (JSC::UString::Rep::setIdentifierTable):
+ (JSC::UString::Rep::isStatic):
+ (JSC::UString::Rep::setStatic):
+ (JSC::UString::Rep::):
+ (JSC::UString::Rep::null):
+ (JSC::UString::Rep::empty):
+ (JSC::UString::isNull):
+ (JSC::UString::null):
+ (JSC::UString::UString):
+
+ * wtf/PtrAndFlags.h: Added.
+ (WTF::PtrAndFlags::PtrAndFlags):
+ (WTF::PtrAndFlags::isFlagSet):
+ (WTF::PtrAndFlags::setFlag):
+ (WTF::PtrAndFlags::clearFlag):
+ (WTF::PtrAndFlags::get):
+ (WTF::PtrAndFlags::set):
+ A simple way to layer together a pointer and 2 flags. It relies on the pointer being 4 byte aligned,
+ which should happen for all allocators (due to aligning pointers, int's, etc. on 4 byte boundaries).
+
+2009-01-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by -O-l-i-v-e-r- -H-u-n-t- Sam Weinig (sorry, Sam!).
+
+ Encode immediates in the low word of JSValuePtrs, on x86-64.
+
+ On 32-bit platforms a JSValuePtr may represent a 31-bit signed integer.
+ On 64-bit platforms, if USE(ALTERNATE_JSIMMEDIATE) is defined, a full
+ 32-bit integer may be stored in an immediate.
+
+ Presently USE(ALTERNATE_JSIMMEDIATE) uses the same encoding as the default
+ immediate format - the value is left shifted by one, so a one bit tag can
+ be added to indicate the value is an immediate. However this means that
+ values must be commonly be detagged (by right shifting by one) before
+ arithmetic operations can be performed on immediates. This patch modifies
+ the formattting so the the high bits of the immediate mark values as being
+ integer.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::not32):
+ (JSC::MacroAssembler::orPtr):
+ (JSC::MacroAssembler::zeroExtend32ToPtr):
+ (JSC::MacroAssembler::jaePtr):
+ (JSC::MacroAssembler::jbPtr):
+ (JSC::MacroAssembler::jnzPtr):
+ (JSC::MacroAssembler::jzPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::notl_r):
+ (JSC::X86Assembler::testq_i32r):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_lshift):
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArith_op_bitand):
+ (JSC::JIT::compileFastArithSlow_op_bitand):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArithSlow_op_mod):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArith_op_post_inc):
+ (JSC::JIT::compileFastArith_op_post_dec):
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileFastArith_op_pre_dec):
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpIfJSCell):
+ (JSC::JIT::emitJumpIfNotJSCell):
+ (JSC::JIT::emitJumpIfImmNum):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
+ (JSC::JIT::emitFastArithDeTagImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithImmToInt):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+ (JSC::JIT::emitTagAsBoolImmediate):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::resizePropertyStorage):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::isNumber):
+ (JSC::JSImmediate::isPositiveNumber):
+ (JSC::JSImmediate::areBothImmediateNumbers):
+ (JSC::JSImmediate::xorImmediateNumbers):
+ (JSC::JSImmediate::rightShiftImmediateNumbers):
+ (JSC::JSImmediate::canDoFastAdditiveOperations):
+ (JSC::JSImmediate::addImmediateNumbers):
+ (JSC::JSImmediate::subImmediateNumbers):
+ (JSC::JSImmediate::makeInt):
+ (JSC::JSImmediate::toBoolean):
+ * wtf/Platform.h:
+
+2009-01-08 Sam Weinig <sam@webkit.org>
+
+ Revert r39720. It broke Interpreted mode.
+
+2009-01-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23197
+ Delay creating the PCVector until an exception is thrown
+ Part of <rdar://problem/6469060>
+ Don't store exception information for a CodeBlock until first exception is thrown
+
+ - Change the process for re-parsing/re-generating bytecode for exception information
+ to use data from the original CodeBlock (offsets of GlobalResolve instructions) to
+ aid in creating an identical instruction stream on re-parse, instead of padding
+ interchangeable opcodes, which would result in different JITed code.
+ - Fix bug where the wrong ScopeChainNode was used when re-parsing/regenerating from
+ within some odd modified scope chains.
+ - Lazily create the pcVector by re-JITing the regenerated CodeBlock and stealing the
+ the pcVector from it.
+
+ Saves ~2MB on Membuster head.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
+ (JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
+ (JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
+ * bytecode/CodeBlock.h:
+ (JSC::JITCodeRef::JITCodeRef):
+ (JSC::GlobalResolveInfo::GlobalResolveInfo):
+ (JSC::CodeBlock::getBytecodeIndex):
+ (JSC::CodeBlock::addGlobalResolveInstruction):
+ (JSC::CodeBlock::addGlobalResolveInfo):
+ (JSC::CodeBlock::addFunctionRegisterInfo):
+ (JSC::CodeBlock::hasExceptionInfo):
+ (JSC::CodeBlock::pcVector):
+ (JSC::EvalCodeBlock::EvalCodeBlock):
+ (JSC::EvalCodeBlock::baseScopeDepth):
+ * bytecode/Opcode.h:
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::emitResolve):
+ (JSC::BytecodeGenerator::emitGetScopedVar):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::setRegeneratingForExceptionInfo):
+ * interpreter/Interpreter.cpp:
+ (JSC::bytecodeOffsetForPC):
+ (JSC::Interpreter::unwindCallFrame):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveLastCaller):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_vm_throw):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ * parser/Nodes.cpp:
+ (JSC::EvalNode::generateBytecode):
+ (JSC::EvalNode::bytecodeForExceptionInfoReparse):
+ (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
+ * parser/Nodes.h:
+
+2009-01-08 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add Win32 implementation of ThreadSpecific.
+ https://bugs.webkit.org/show_bug.cgi?id=22614
+
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * wtf/ThreadSpecific.h:
+ (WTF::ThreadSpecific::ThreadSpecific):
+ (WTF::ThreadSpecific::~ThreadSpecific):
+ (WTF::ThreadSpecific::get):
+ (WTF::ThreadSpecific::set):
+ (WTF::ThreadSpecific::destroy):
+ * wtf/ThreadSpecificWin.cpp: Added.
+ (WTF::ThreadSpecificThreadExit):
+ * wtf/ThreadingWin.cpp:
+ (WTF::wtfThreadEntryPoint):
+
+2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix compilation with Qt on NetBSD.
+
+ * runtime/Collector.cpp:
+ (JSC::currentThreadStackBase): Use PLATFORM(NETBSD) to enter the
+ code path to retrieve the stack base using pthread_attr_get_np.
+ The PTHREAD_NP_H define is not used because the header file does
+ not exist on NetBSD, but the function is declared nevertheless.
+ * wtf/Platform.h: Introduce WTF_PLATFORM_NETBSD.
+
+2009-01-07 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ <rdar://problem/6469060> Don't store exception information for a CodeBlock until first exception is thrown
+
+ Don't initially store exception information (lineNumber/expressionRange/getByIdExcecptionInfo)
+ in CodeBlocks blocks. Instead, re-parse for the data on demand and cache it then.
+
+ One important change that was needed to make this work was to pad op_get_global_var with nops to
+ be the same length as op_resolve_global, since one could be replaced for the other on re-parsing,
+ and we want to keep the offsets bytecode offsets the same.
+
+ 1.3MB improvement on Membuster head.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Update op_get_global_var to account for the padding.
+ (JSC::CodeBlock::dumpStatistics): Add more statistic dumping.
+ (JSC::CodeBlock::CodeBlock): Initialize m_exceptionInfo.
+ (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): Re-parses the CodeBlocks
+ associated SourceCode and steals the ExceptionInfo from it.
+ (JSC::CodeBlock::lineNumberForBytecodeOffset): Creates the exception info on demand.
+ (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto.
+ (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::numberOfExceptionHandlers): Updated to account for m_exceptionInfo indirection.
+ (JSC::CodeBlock::addExceptionHandler): Ditto.
+ (JSC::CodeBlock::exceptionHandler): Ditto.
+ (JSC::CodeBlock::clearExceptionInfo): Ditto.
+ (JSC::CodeBlock::addExpressionInfo): Ditto.
+ (JSC::CodeBlock::addGetByIdExceptionInfo): Ditto.
+ (JSC::CodeBlock::numberOfLineInfos): Ditto.
+ (JSC::CodeBlock::addLineInfo): Ditto.
+ (JSC::CodeBlock::lastLineInfo): Ditto.
+
+ * bytecode/Opcode.h: Change length of op_get_global_var to match op_resolve_global.
+
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingTool::dump): Add comment indicating why it is okay not to pass a CallFrame.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate): Clear the exception info after generation for Function and Eval
+ Code when not in regenerate for exception info mode.
+ (JSC::BytecodeGenerator::BytecodeGenerator): Initialize m_regeneratingForExceptionInfo to false.
+ (JSC::BytecodeGenerator::emitGetScopedVar): Pad op_get_global_var with 2 nops.
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::setRegeneratingForExcpeptionInfo): Added.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException): Pass the CallFrame to exception info accessors.
+ (JSC::Interpreter::privateExecute): Ditto.
+ (JSC::Interpreter::retrieveLastCaller): Ditto.
+ (JSC::Interpreter::cti_op_new_error): Ditto.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass): Pass the current bytecode offset instead of hard coding the
+ line number, the stub will do the accessing if it gets called.
+
+ * parser/Nodes.cpp:
+ (JSC::ProgramNode::emitBytecode): Moved.
+ (JSC::ProgramNode::generateBytecode): Moved.
+ (JSC::EvalNode::create): Moved.
+ (JSC::EvalNode::bytecodeForExceptionInfoReparse): Added.
+ (JSC::FunctionBodyNode::generateBytecode): Rename reparse to reparseInPlace.
+ (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse): Addded.
+
+ * parser/Nodes.h:
+ (JSC::ScopeNode::features): Added getter.
+ * parser/Parser.cpp:
+ (JSC::Parser::reparseInPlace): Renamed from reparse.
+ * parser/Parser.h:
+ (JSC::Parser::reparse): Added. Re-parses the passed in Node into
+ a new Node.
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createUndefinedVariableError): Pass along CallFrame.
+ (JSC::createInvalidParamError): Ditto.
+ (JSC::createNotAConstructorError): Ditto.
+ (JSC::createNotAFunctionError): Ditto.
+ (JSC::createNotAnObjectError): Ditto.
+
+2009-01-06 Gavin Barraclough <baraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Replace accidentally removed references in BytecodeGenerator, deleting these
+ will be hindering the sharing of constant numbers and strings.
+
+ The code to add a new constant (either number or string) to their respective
+ map works by attempting to add a null entry, then checking the result of the
+ add for null. The first time, this should return the null (or noValue).
+ The code checks for null (to see if this is the initial add), and then allocates
+ a new number / string object. This code relies on the result returned from
+ the add to the map being stored as a reference, such that the allocated object
+ will be stored in the map, and will be resused if the same constant is encountered
+ again. By failing to use a reference we will be leaking GC object for each
+ additional entry added to the map. As GC objects they should be clollected,
+ be we should no be allocatin them in the first place.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23158
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitLoad):
+
+2009-01-06 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6040850> JavaScript register file should use VirtualAlloc on Windows
+
+ Fairly simple, just reserve 4Mb of address space for the
+ register file, and then commit one section at a time. We
+ don't release committed memory as we drop back, but then
+ mac doesn't either so this probably not too much of a
+ problem.
+
+ * interpreter/RegisterFile.cpp:
+ (JSC::RegisterFile::~RegisterFile):
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ (JSC::RegisterFile::grow):
+
+2009-01-06 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23142
+ ThreadGlobalData leaks seen on buildbot
+
+ * wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Temporarily reset the thread
+ specific value to make getter work on Mac OS X.
+
+ * wtf/Platform.h: Touch this file again to make sure all Windows builds use the most recent
+ version of ThreadSpecific.h.
+
+2009-01-05 Gavin Barraclough <baraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Replace all uses of JSValue* with a new smart pointer type, JSValuePtr.
+
+ A JavaScript value may be a heap object or boxed primitive, represented by a
+ pointer, or may be an unboxed immediate value, such as an integer. Since a
+ value may dynamically need to contain either a pointer value or an immediate,
+ we encode immediates as pointer values (since all valid JSCell pointers are
+ allocated at alligned addesses, unaligned addresses are available to encode
+ immediates). As such all JavaScript values are represented using a JSValue*.
+
+ This implementation is encumbered by a number of constraints. It ties the
+ JSValue representation to the size of pointer on the platform, which, for
+ example, means that we currently can represent different ranges of integers
+ as immediates on x86 and x86-64. It also prevents us from overloading the
+ to-boolean conversion used to test for noValue() - effectively forcing us
+ to represent noValue() as 0. This would potentially be problematic were we
+ to wish to encode integer values differently (e.g. were we to use the v8
+ encoding, where pointers are tagged with 1 and integers with 0, then the
+ immediate integer 0 would conflict with noValue()).
+
+ This patch replaces all usage of JSValue* with a new class, JSValuePtr,
+ which encapsulates the pointer. JSValuePtr maintains the same interface as
+ JSValue*, overloading operator-> and operator bool such that previous
+ operations in the code on variables of type JSValue* are still supported.
+
+ In order to provide a ProtectPtr<> type with support for the new value
+ representation (without using the internal JSValue type directly), a new
+ ProtectJSValuePtr type has been added, equivalent to the previous type
+ ProtectPtr<JSValue>.
+
+ This patch is likely the first in a sequence of three changes. With the
+ value now encapsulated it will likely make sense to migrate the functionality
+ from JSValue into JSValuePtr, such that the internal pointer representation
+ need not be exposed. Through migrating the functionality to the wrapper
+ class the existing JSValue should be rendered redundant, and the class is
+ likely to be removed (the JSValuePtr now wrapping a pointer to a JSCell).
+ At this stage it will likely make sense to rename JSValuePtr to JSValue.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23114
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ * API/JSCallbackConstructor.h:
+ (JSC::JSCallbackConstructor::createStructure):
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::call):
+ * API/JSCallbackFunction.h:
+ (JSC::JSCallbackFunction::createStructure):
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::createStructure):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::asCallbackObject):
+ (JSC::::put):
+ (JSC::::hasInstance):
+ (JSC::::call):
+ (JSC::::staticValueGetter):
+ (JSC::::staticFunctionGetter):
+ (JSC::::callbackGetter):
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeConstructor):
+ (JSObjectSetPrototype):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectGetPropertyAtIndex):
+ (JSObjectSetPropertyAtIndex):
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsUndefined):
+ (JSValueIsNull):
+ (JSValueIsBoolean):
+ (JSValueIsNumber):
+ (JSValueIsString):
+ (JSValueIsObject):
+ (JSValueIsObjectOfClass):
+ (JSValueIsEqual):
+ (JSValueIsStrictEqual):
+ (JSValueIsInstanceOfConstructor):
+ (JSValueToBoolean):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ (JSValueProtect):
+ (JSValueUnprotect):
+ * JavaScriptCore.exp:
+ * bytecode/CodeBlock.cpp:
+ (JSC::valueToSourceString):
+ (JSC::constantName):
+ (JSC::CodeBlock::dump):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::getConstant):
+ (JSC::CodeBlock::addUnexpectedConstant):
+ (JSC::CodeBlock::unexpectedConstant):
+ * bytecode/EvalCodeCache.h:
+ (JSC::EvalCodeCache::get):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::addConstant):
+ (JSC::BytecodeGenerator::addUnexpectedConstant):
+ (JSC::BytecodeGenerator::emitLoad):
+ (JSC::BytecodeGenerator::emitLoadJSV):
+ (JSC::BytecodeGenerator::emitGetScopedVar):
+ (JSC::BytecodeGenerator::emitPutScopedVar):
+ (JSC::BytecodeGenerator::emitNewError):
+ (JSC::keyForImmediateSwitch):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
+ (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate):
+ * debugger/DebuggerCallFrame.h:
+ (JSC::DebuggerCallFrame::DebuggerCallFrame):
+ (JSC::DebuggerCallFrame::exception):
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::thisValue):
+ * interpreter/CallFrame.h:
+ (JSC::ExecState::setException):
+ (JSC::ExecState::exception):
+ (JSC::ExecState::exceptionSlot):
+ (JSC::ExecState::hadException):
+ * interpreter/Interpreter.cpp:
+ (JSC::fastIsNumber):
+ (JSC::fastToInt32):
+ (JSC::fastToUInt32):
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAddSlowCase):
+ (JSC::jsAdd):
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::jsIsFunctionType):
+ (JSC::Interpreter::resolve):
+ (JSC::Interpreter::resolveSkip):
+ (JSC::Interpreter::resolveGlobal):
+ (JSC::inlineResolveBase):
+ (JSC::Interpreter::resolveBase):
+ (JSC::Interpreter::resolveBaseAndProperty):
+ (JSC::Interpreter::resolveBaseAndFunc):
+ (JSC::isNotObject):
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::unwindCallFrame):
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::checkTimeout):
+ (JSC::Interpreter::createExceptionScope):
+ (JSC::cachePrototypeChain):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ (JSC::Interpreter::retrieveCaller):
+ (JSC::Interpreter::retrieveLastCaller):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::returnToThrowTrampoline):
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_op_loop_if_less):
+ (JSC::Interpreter::cti_op_loop_if_lesseq):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
+ (JSC::Interpreter::cti_op_get_by_id_proto_fail):
+ (JSC::Interpreter::cti_op_get_by_id_array_fail):
+ (JSC::Interpreter::cti_op_get_by_id_string_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_lesseq):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_resolve_base):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_jless):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_less):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_call_eval):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_next_pname):
+ (JSC::Interpreter::cti_op_typeof):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_is_boolean):
+ (JSC::Interpreter::cti_op_is_number):
+ (JSC::Interpreter::cti_op_is_string):
+ (JSC::Interpreter::cti_op_is_object):
+ (JSC::Interpreter::cti_op_is_function):
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_op_del_by_val):
+ (JSC::Interpreter::cti_op_new_error):
+ (JSC::Interpreter::cti_vm_throw):
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::isJSArray):
+ (JSC::Interpreter::isJSString):
+ * interpreter/Register.h:
+ (JSC::Register::):
+ (JSC::Register::Register):
+ (JSC::Register::jsValue):
+ (JSC::Register::getJSValue):
+ * jit/JIT.cpp:
+ (JSC::):
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ (JSC::):
+ (JSC::JIT::execute):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCall):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::getConstantOperand):
+ (JSC::JIT::isOperandConstant31BitImmediateInt):
+ (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
+ (JSC::JIT::emitInitRegister):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::resizePropertyStorage):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * jsc.cpp:
+ (functionPrint):
+ (functionDebug):
+ (functionGC):
+ (functionVersion):
+ (functionRun):
+ (functionLoad):
+ (functionReadline):
+ (functionQuit):
+ * parser/Nodes.cpp:
+ (JSC::NullNode::emitBytecode):
+ (JSC::ArrayNode::emitBytecode):
+ (JSC::FunctionCallValueNode::emitBytecode):
+ (JSC::FunctionCallResolveNode::emitBytecode):
+ (JSC::VoidNode::emitBytecode):
+ (JSC::ConstDeclNode::emitCodeSingle):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::processClauseList):
+ (JSC::EvalNode::emitBytecode):
+ (JSC::FunctionBodyNode::emitBytecode):
+ (JSC::ProgramNode::emitBytecode):
+ * profiler/ProfileGenerator.cpp:
+ (JSC::ProfileGenerator::addParentForConsoleStart):
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::willExecute):
+ (JSC::Profiler::didExecute):
+ (JSC::Profiler::createCallIdentifier):
+ * profiler/Profiler.h:
+ * runtime/ArgList.cpp:
+ (JSC::ArgList::slowAppend):
+ * runtime/ArgList.h:
+ (JSC::ArgList::at):
+ (JSC::ArgList::append):
+ * runtime/Arguments.cpp:
+ (JSC::Arguments::put):
+ * runtime/Arguments.h:
+ (JSC::Arguments::createStructure):
+ (JSC::asArguments):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::callArrayConstructor):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::getProperty):
+ (JSC::putProperty):
+ (JSC::arrayProtoFuncToString):
+ (JSC::arrayProtoFuncToLocaleString):
+ (JSC::arrayProtoFuncJoin):
+ (JSC::arrayProtoFuncConcat):
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ (JSC::arrayProtoFuncReverse):
+ (JSC::arrayProtoFuncShift):
+ (JSC::arrayProtoFuncSlice):
+ (JSC::arrayProtoFuncSort):
+ (JSC::arrayProtoFuncSplice):
+ (JSC::arrayProtoFuncUnShift):
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncMap):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncForEach):
+ (JSC::arrayProtoFuncSome):
+ (JSC::arrayProtoFuncIndexOf):
+ (JSC::arrayProtoFuncLastIndexOf):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::callBooleanConstructor):
+ (JSC::constructBooleanFromImmediateBoolean):
+ * runtime/BooleanConstructor.h:
+ * runtime/BooleanObject.h:
+ (JSC::asBooleanObject):
+ * runtime/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncToString):
+ (JSC::booleanProtoFuncValueOf):
+ * runtime/CallData.cpp:
+ (JSC::call):
+ * runtime/CallData.h:
+ * runtime/Collector.cpp:
+ (JSC::Heap::protect):
+ (JSC::Heap::unprotect):
+ (JSC::Heap::heap):
+ (JSC::Heap::collect):
+ * runtime/Collector.h:
+ * runtime/Completion.cpp:
+ (JSC::evaluate):
+ * runtime/Completion.h:
+ (JSC::Completion::Completion):
+ (JSC::Completion::value):
+ (JSC::Completion::setValue):
+ (JSC::Completion::isValueCompletion):
+ * runtime/ConstructData.cpp:
+ (JSC::construct):
+ * runtime/ConstructData.h:
+ * runtime/DateConstructor.cpp:
+ (JSC::constructDate):
+ (JSC::callDate):
+ (JSC::dateParse):
+ (JSC::dateNow):
+ (JSC::dateUTC):
+ * runtime/DateInstance.h:
+ (JSC::asDateInstance):
+ * runtime/DatePrototype.cpp:
+ (JSC::dateProtoFuncToString):
+ (JSC::dateProtoFuncToUTCString):
+ (JSC::dateProtoFuncToDateString):
+ (JSC::dateProtoFuncToTimeString):
+ (JSC::dateProtoFuncToLocaleString):
+ (JSC::dateProtoFuncToLocaleDateString):
+ (JSC::dateProtoFuncToLocaleTimeString):
+ (JSC::dateProtoFuncValueOf):
+ (JSC::dateProtoFuncGetTime):
+ (JSC::dateProtoFuncGetFullYear):
+ (JSC::dateProtoFuncGetUTCFullYear):
+ (JSC::dateProtoFuncToGMTString):
+ (JSC::dateProtoFuncGetMonth):
+ (JSC::dateProtoFuncGetUTCMonth):
+ (JSC::dateProtoFuncGetDate):
+ (JSC::dateProtoFuncGetUTCDate):
+ (JSC::dateProtoFuncGetDay):
+ (JSC::dateProtoFuncGetUTCDay):
+ (JSC::dateProtoFuncGetHours):
+ (JSC::dateProtoFuncGetUTCHours):
+ (JSC::dateProtoFuncGetMinutes):
+ (JSC::dateProtoFuncGetUTCMinutes):
+ (JSC::dateProtoFuncGetSeconds):
+ (JSC::dateProtoFuncGetUTCSeconds):
+ (JSC::dateProtoFuncGetMilliSeconds):
+ (JSC::dateProtoFuncGetUTCMilliseconds):
+ (JSC::dateProtoFuncGetTimezoneOffset):
+ (JSC::dateProtoFuncSetTime):
+ (JSC::setNewValueFromTimeArgs):
+ (JSC::setNewValueFromDateArgs):
+ (JSC::dateProtoFuncSetMilliSeconds):
+ (JSC::dateProtoFuncSetUTCMilliseconds):
+ (JSC::dateProtoFuncSetSeconds):
+ (JSC::dateProtoFuncSetUTCSeconds):
+ (JSC::dateProtoFuncSetMinutes):
+ (JSC::dateProtoFuncSetUTCMinutes):
+ (JSC::dateProtoFuncSetHours):
+ (JSC::dateProtoFuncSetUTCHours):
+ (JSC::dateProtoFuncSetDate):
+ (JSC::dateProtoFuncSetUTCDate):
+ (JSC::dateProtoFuncSetMonth):
+ (JSC::dateProtoFuncSetUTCMonth):
+ (JSC::dateProtoFuncSetFullYear):
+ (JSC::dateProtoFuncSetUTCFullYear):
+ (JSC::dateProtoFuncSetYear):
+ (JSC::dateProtoFuncGetYear):
+ * runtime/DatePrototype.h:
+ (JSC::DatePrototype::createStructure):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::callErrorConstructor):
+ * runtime/ErrorPrototype.cpp:
+ (JSC::errorProtoFuncToString):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createInterruptedExecutionException):
+ (JSC::createError):
+ (JSC::createStackOverflowError):
+ (JSC::createUndefinedVariableError):
+ (JSC::createErrorMessage):
+ (JSC::createInvalidParamError):
+ (JSC::createNotAConstructorError):
+ (JSC::createNotAFunctionError):
+ * runtime/ExceptionHelpers.h:
+ * runtime/FunctionConstructor.cpp:
+ (JSC::callFunctionConstructor):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::callFunctionPrototype):
+ (JSC::functionProtoFuncToString):
+ (JSC::functionProtoFuncApply):
+ (JSC::functionProtoFuncCall):
+ * runtime/FunctionPrototype.h:
+ (JSC::FunctionPrototype::createStructure):
+ * runtime/GetterSetter.cpp:
+ (JSC::GetterSetter::toPrimitive):
+ (JSC::GetterSetter::getPrimitiveNumber):
+ * runtime/GetterSetter.h:
+ (JSC::asGetterSetter):
+ * runtime/InitializeThreading.cpp:
+ * runtime/InternalFunction.h:
+ (JSC::InternalFunction::createStructure):
+ (JSC::asInternalFunction):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::getOwnPropertySlot):
+ (JSC::JSActivation::put):
+ (JSC::JSActivation::putWithAttributes):
+ (JSC::JSActivation::argumentsGetter):
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::createStructure):
+ (JSC::asActivation):
+ * runtime/JSArray.cpp:
+ (JSC::storageSize):
+ (JSC::JSArray::JSArray):
+ (JSC::JSArray::getOwnPropertySlot):
+ (JSC::JSArray::put):
+ (JSC::JSArray::putSlowCase):
+ (JSC::JSArray::deleteProperty):
+ (JSC::JSArray::getPropertyNames):
+ (JSC::JSArray::setLength):
+ (JSC::JSArray::pop):
+ (JSC::JSArray::push):
+ (JSC::JSArray::mark):
+ (JSC::JSArray::sort):
+ (JSC::JSArray::compactForSorting):
+ (JSC::JSArray::checkConsistency):
+ (JSC::constructArray):
+ * runtime/JSArray.h:
+ (JSC::JSArray::getIndex):
+ (JSC::JSArray::setIndex):
+ (JSC::JSArray::createStructure):
+ (JSC::asArray):
+ * runtime/JSCell.cpp:
+ (JSC::JSCell::put):
+ (JSC::JSCell::getJSNumber):
+ * runtime/JSCell.h:
+ (JSC::asCell):
+ (JSC::JSValue::asCell):
+ (JSC::JSValue::toPrimitive):
+ (JSC::JSValue::getPrimitiveNumber):
+ (JSC::JSValue::getJSNumber):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::call):
+ (JSC::JSFunction::argumentsGetter):
+ (JSC::JSFunction::callerGetter):
+ (JSC::JSFunction::lengthGetter):
+ (JSC::JSFunction::getOwnPropertySlot):
+ (JSC::JSFunction::put):
+ (JSC::JSFunction::construct):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::createStructure):
+ (JSC::asFunction):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::markIfNeeded):
+ (JSC::JSGlobalObject::put):
+ (JSC::JSGlobalObject::putWithAttributes):
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::resetPrototype):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::createStructure):
+ (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo):
+ (JSC::asGlobalObject):
+ (JSC::Structure::prototypeForLookup):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::encode):
+ (JSC::decode):
+ (JSC::globalFuncEval):
+ (JSC::globalFuncParseInt):
+ (JSC::globalFuncParseFloat):
+ (JSC::globalFuncIsNaN):
+ (JSC::globalFuncIsFinite):
+ (JSC::globalFuncDecodeURI):
+ (JSC::globalFuncDecodeURIComponent):
+ (JSC::globalFuncEncodeURI):
+ (JSC::globalFuncEncodeURIComponent):
+ (JSC::globalFuncEscape):
+ (JSC::globalFuncUnescape):
+ (JSC::globalFuncJSCPrint):
+ * runtime/JSGlobalObjectFunctions.h:
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject):
+ (JSC::JSImmediate::toObject):
+ (JSC::JSImmediate::prototype):
+ (JSC::JSImmediate::toString):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::isImmediate):
+ (JSC::JSImmediate::isNumber):
+ (JSC::JSImmediate::isPositiveNumber):
+ (JSC::JSImmediate::isBoolean):
+ (JSC::JSImmediate::isUndefinedOrNull):
+ (JSC::JSImmediate::isNegative):
+ (JSC::JSImmediate::isEitherImmediate):
+ (JSC::JSImmediate::isAnyImmediate):
+ (JSC::JSImmediate::areBothImmediate):
+ (JSC::JSImmediate::areBothImmediateNumbers):
+ (JSC::JSImmediate::andImmediateNumbers):
+ (JSC::JSImmediate::xorImmediateNumbers):
+ (JSC::JSImmediate::orImmediateNumbers):
+ (JSC::JSImmediate::rightShiftImmediateNumbers):
+ (JSC::JSImmediate::canDoFastAdditiveOperations):
+ (JSC::JSImmediate::addImmediateNumbers):
+ (JSC::JSImmediate::subImmediateNumbers):
+ (JSC::JSImmediate::incImmediateNumber):
+ (JSC::JSImmediate::decImmediateNumber):
+ (JSC::JSImmediate::makeValue):
+ (JSC::JSImmediate::makeInt):
+ (JSC::JSImmediate::makeBool):
+ (JSC::JSImmediate::makeUndefined):
+ (JSC::JSImmediate::makeNull):
+ (JSC::JSImmediate::intValue):
+ (JSC::JSImmediate::uintValue):
+ (JSC::JSImmediate::boolValue):
+ (JSC::JSImmediate::rawValue):
+ (JSC::JSImmediate::trueImmediate):
+ (JSC::JSImmediate::falseImmediate):
+ (JSC::JSImmediate::undefinedImmediate):
+ (JSC::JSImmediate::nullImmediate):
+ (JSC::JSImmediate::zeroImmediate):
+ (JSC::JSImmediate::oneImmediate):
+ (JSC::JSImmediate::impossibleValue):
+ (JSC::JSImmediate::toBoolean):
+ (JSC::JSImmediate::getTruncatedUInt32):
+ (JSC::JSImmediate::from):
+ (JSC::JSImmediate::getTruncatedInt32):
+ (JSC::JSImmediate::toDouble):
+ (JSC::JSImmediate::getUInt32):
+ (JSC::jsNull):
+ (JSC::jsBoolean):
+ (JSC::jsUndefined):
+ (JSC::JSValue::isUndefined):
+ (JSC::JSValue::isNull):
+ (JSC::JSValue::isUndefinedOrNull):
+ (JSC::JSValue::isBoolean):
+ (JSC::JSValue::getBoolean):
+ (JSC::JSValue::toInt32):
+ (JSC::JSValue::toUInt32):
+ (JSC::toInt32):
+ (JSC::toUInt32):
+ * runtime/JSNotAnObject.cpp:
+ (JSC::JSNotAnObject::toPrimitive):
+ (JSC::JSNotAnObject::getPrimitiveNumber):
+ (JSC::JSNotAnObject::put):
+ * runtime/JSNotAnObject.h:
+ (JSC::JSNotAnObject::createStructure):
+ * runtime/JSNumberCell.cpp:
+ (JSC::JSNumberCell::toPrimitive):
+ (JSC::JSNumberCell::getPrimitiveNumber):
+ (JSC::JSNumberCell::getJSNumber):
+ (JSC::jsNumberCell):
+ (JSC::jsNaN):
+ * runtime/JSNumberCell.h:
+ (JSC::JSNumberCell::createStructure):
+ (JSC::asNumberCell):
+ (JSC::jsNumber):
+ (JSC::JSValue::toJSNumber):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::put):
+ (JSC::JSObject::putWithAttributes):
+ (JSC::callDefaultValueFunction):
+ (JSC::JSObject::getPrimitiveNumber):
+ (JSC::JSObject::defaultValue):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ (JSC::JSObject::lookupGetter):
+ (JSC::JSObject::lookupSetter):
+ (JSC::JSObject::hasInstance):
+ (JSC::JSObject::toNumber):
+ (JSC::JSObject::toString):
+ (JSC::JSObject::fillGetterPropertySlot):
+ * runtime/JSObject.h:
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::offsetForLocation):
+ (JSC::JSObject::locationForOffset):
+ (JSC::JSObject::getDirectOffset):
+ (JSC::JSObject::putDirectOffset):
+ (JSC::JSObject::createStructure):
+ (JSC::asObject):
+ (JSC::JSObject::prototype):
+ (JSC::JSObject::setPrototype):
+ (JSC::JSObject::inlineGetOwnPropertySlot):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSObject::getPropertySlot):
+ (JSC::JSObject::get):
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::putDirectWithoutTransition):
+ (JSC::JSObject::toPrimitive):
+ (JSC::JSValue::get):
+ (JSC::JSValue::put):
+ (JSC::JSObject::allocatePropertyStorageInline):
+ * runtime/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::toPrimitive):
+ (JSC::JSPropertyNameIterator::getPrimitiveNumber):
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::create):
+ (JSC::JSPropertyNameIterator::next):
+ * runtime/JSStaticScopeObject.cpp:
+ (JSC::JSStaticScopeObject::put):
+ (JSC::JSStaticScopeObject::putWithAttributes):
+ * runtime/JSStaticScopeObject.h:
+ (JSC::JSStaticScopeObject::JSStaticScopeObject):
+ (JSC::JSStaticScopeObject::createStructure):
+ * runtime/JSString.cpp:
+ (JSC::JSString::toPrimitive):
+ (JSC::JSString::getPrimitiveNumber):
+ (JSC::JSString::getOwnPropertySlot):
+ * runtime/JSString.h:
+ (JSC::JSString::createStructure):
+ (JSC::asString):
+ * runtime/JSValue.h:
+ (JSC::JSValuePtr::makeImmediate):
+ (JSC::JSValuePtr::immediateValue):
+ (JSC::JSValuePtr::JSValuePtr):
+ (JSC::JSValuePtr::operator->):
+ (JSC::JSValuePtr::hasValue):
+ (JSC::JSValuePtr::operator==):
+ (JSC::JSValuePtr::operator!=):
+ (JSC::JSValuePtr::encode):
+ (JSC::JSValuePtr::decode):
+ (JSC::JSValue::asValue):
+ (JSC::noValue):
+ (JSC::operator==):
+ (JSC::operator!=):
+ * runtime/JSVariableObject.h:
+ (JSC::JSVariableObject::symbolTablePut):
+ (JSC::JSVariableObject::symbolTablePutWithAttributes):
+ * runtime/JSWrapperObject.cpp:
+ (JSC::JSWrapperObject::mark):
+ * runtime/JSWrapperObject.h:
+ (JSC::JSWrapperObject::internalValue):
+ (JSC::JSWrapperObject::setInternalValue):
+ * runtime/Lookup.cpp:
+ (JSC::setUpStaticFunctionSlot):
+ * runtime/Lookup.h:
+ (JSC::lookupPut):
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncAbs):
+ (JSC::mathProtoFuncACos):
+ (JSC::mathProtoFuncASin):
+ (JSC::mathProtoFuncATan):
+ (JSC::mathProtoFuncATan2):
+ (JSC::mathProtoFuncCeil):
+ (JSC::mathProtoFuncCos):
+ (JSC::mathProtoFuncExp):
+ (JSC::mathProtoFuncFloor):
+ (JSC::mathProtoFuncLog):
+ (JSC::mathProtoFuncMax):
+ (JSC::mathProtoFuncMin):
+ (JSC::mathProtoFuncPow):
+ (JSC::mathProtoFuncRandom):
+ (JSC::mathProtoFuncRound):
+ (JSC::mathProtoFuncSin):
+ (JSC::mathProtoFuncSqrt):
+ (JSC::mathProtoFuncTan):
+ * runtime/MathObject.h:
+ (JSC::MathObject::createStructure):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::callNativeErrorConstructor):
+ * runtime/NumberConstructor.cpp:
+ (JSC::numberConstructorNaNValue):
+ (JSC::numberConstructorNegInfinity):
+ (JSC::numberConstructorPosInfinity):
+ (JSC::numberConstructorMaxValue):
+ (JSC::numberConstructorMinValue):
+ (JSC::callNumberConstructor):
+ * runtime/NumberConstructor.h:
+ (JSC::NumberConstructor::createStructure):
+ * runtime/NumberObject.cpp:
+ (JSC::NumberObject::getJSNumber):
+ (JSC::constructNumberFromImmediateNumber):
+ * runtime/NumberObject.h:
+ * runtime/NumberPrototype.cpp:
+ (JSC::numberProtoFuncToString):
+ (JSC::numberProtoFuncToLocaleString):
+ (JSC::numberProtoFuncValueOf):
+ (JSC::numberProtoFuncToFixed):
+ (JSC::numberProtoFuncToExponential):
+ (JSC::numberProtoFuncToPrecision):
+ * runtime/ObjectConstructor.cpp:
+ (JSC::constructObject):
+ (JSC::callObjectConstructor):
+ * runtime/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncValueOf):
+ (JSC::objectProtoFuncHasOwnProperty):
+ (JSC::objectProtoFuncIsPrototypeOf):
+ (JSC::objectProtoFuncDefineGetter):
+ (JSC::objectProtoFuncDefineSetter):
+ (JSC::objectProtoFuncLookupGetter):
+ (JSC::objectProtoFuncLookupSetter):
+ (JSC::objectProtoFuncPropertyIsEnumerable):
+ (JSC::objectProtoFuncToLocaleString):
+ (JSC::objectProtoFuncToString):
+ * runtime/ObjectPrototype.h:
+ * runtime/Operations.cpp:
+ (JSC::equal):
+ (JSC::equalSlowCase):
+ (JSC::strictEqual):
+ (JSC::strictEqualSlowCase):
+ (JSC::throwOutOfMemoryError):
+ * runtime/Operations.h:
+ (JSC::equalSlowCaseInline):
+ (JSC::strictEqualSlowCaseInline):
+ * runtime/PropertySlot.cpp:
+ (JSC::PropertySlot::functionGetter):
+ * runtime/PropertySlot.h:
+ (JSC::PropertySlot::PropertySlot):
+ (JSC::PropertySlot::getValue):
+ (JSC::PropertySlot::putValue):
+ (JSC::PropertySlot::setValueSlot):
+ (JSC::PropertySlot::setValue):
+ (JSC::PropertySlot::setCustom):
+ (JSC::PropertySlot::setCustomIndex):
+ (JSC::PropertySlot::slotBase):
+ (JSC::PropertySlot::setBase):
+ (JSC::PropertySlot::):
+ * runtime/Protect.h:
+ (JSC::gcProtect):
+ (JSC::gcUnprotect):
+ (JSC::ProtectedPtr::ProtectedPtr):
+ (JSC::ProtectedPtr::operator JSValuePtr):
+ (JSC::ProtectedJSValuePtr::ProtectedJSValuePtr):
+ (JSC::ProtectedJSValuePtr::get):
+ (JSC::ProtectedJSValuePtr::operator JSValuePtr):
+ (JSC::ProtectedJSValuePtr::operator->):
+ (JSC::::ProtectedPtr):
+ (JSC::::~ProtectedPtr):
+ (JSC::::operator):
+ (JSC::ProtectedJSValuePtr::~ProtectedJSValuePtr):
+ (JSC::ProtectedJSValuePtr::operator=):
+ (JSC::operator==):
+ (JSC::operator!=):
+ * runtime/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::getBackref):
+ (JSC::RegExpConstructor::getLastParen):
+ (JSC::RegExpConstructor::getLeftContext):
+ (JSC::RegExpConstructor::getRightContext):
+ (JSC::regExpConstructorDollar1):
+ (JSC::regExpConstructorDollar2):
+ (JSC::regExpConstructorDollar3):
+ (JSC::regExpConstructorDollar4):
+ (JSC::regExpConstructorDollar5):
+ (JSC::regExpConstructorDollar6):
+ (JSC::regExpConstructorDollar7):
+ (JSC::regExpConstructorDollar8):
+ (JSC::regExpConstructorDollar9):
+ (JSC::regExpConstructorInput):
+ (JSC::regExpConstructorMultiline):
+ (JSC::regExpConstructorLastMatch):
+ (JSC::regExpConstructorLastParen):
+ (JSC::regExpConstructorLeftContext):
+ (JSC::regExpConstructorRightContext):
+ (JSC::RegExpConstructor::put):
+ (JSC::setRegExpConstructorInput):
+ (JSC::setRegExpConstructorMultiline):
+ (JSC::constructRegExp):
+ (JSC::callRegExpConstructor):
+ * runtime/RegExpConstructor.h:
+ (JSC::RegExpConstructor::createStructure):
+ (JSC::asRegExpConstructor):
+ * runtime/RegExpMatchesArray.h:
+ (JSC::RegExpMatchesArray::put):
+ * runtime/RegExpObject.cpp:
+ (JSC::regExpObjectGlobal):
+ (JSC::regExpObjectIgnoreCase):
+ (JSC::regExpObjectMultiline):
+ (JSC::regExpObjectSource):
+ (JSC::regExpObjectLastIndex):
+ (JSC::RegExpObject::put):
+ (JSC::setRegExpObjectLastIndex):
+ (JSC::RegExpObject::test):
+ (JSC::RegExpObject::exec):
+ (JSC::callRegExpObject):
+ * runtime/RegExpObject.h:
+ (JSC::RegExpObject::createStructure):
+ (JSC::asRegExpObject):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncTest):
+ (JSC::regExpProtoFuncExec):
+ (JSC::regExpProtoFuncCompile):
+ (JSC::regExpProtoFuncToString):
+ * runtime/StringConstructor.cpp:
+ (JSC::stringFromCharCodeSlowCase):
+ (JSC::stringFromCharCode):
+ (JSC::callStringConstructor):
+ * runtime/StringObject.cpp:
+ (JSC::StringObject::put):
+ * runtime/StringObject.h:
+ (JSC::StringObject::createStructure):
+ (JSC::asStringObject):
+ * runtime/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncToString):
+ (JSC::stringProtoFuncCharAt):
+ (JSC::stringProtoFuncCharCodeAt):
+ (JSC::stringProtoFuncConcat):
+ (JSC::stringProtoFuncIndexOf):
+ (JSC::stringProtoFuncLastIndexOf):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ (JSC::stringProtoFuncSlice):
+ (JSC::stringProtoFuncSplit):
+ (JSC::stringProtoFuncSubstr):
+ (JSC::stringProtoFuncSubstring):
+ (JSC::stringProtoFuncToLowerCase):
+ (JSC::stringProtoFuncToUpperCase):
+ (JSC::stringProtoFuncLocaleCompare):
+ (JSC::stringProtoFuncBig):
+ (JSC::stringProtoFuncSmall):
+ (JSC::stringProtoFuncBlink):
+ (JSC::stringProtoFuncBold):
+ (JSC::stringProtoFuncFixed):
+ (JSC::stringProtoFuncItalics):
+ (JSC::stringProtoFuncStrike):
+ (JSC::stringProtoFuncSub):
+ (JSC::stringProtoFuncSup):
+ (JSC::stringProtoFuncFontcolor):
+ (JSC::stringProtoFuncFontsize):
+ (JSC::stringProtoFuncAnchor):
+ (JSC::stringProtoFuncLink):
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure):
+ (JSC::Structure::changePrototypeTransition):
+ (JSC::Structure::createCachedPrototypeChain):
+ * runtime/Structure.h:
+ (JSC::Structure::create):
+ (JSC::Structure::setPrototypeWithoutTransition):
+ (JSC::Structure::storedPrototype):
+
+2009-01-06 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23085> [jsfunfuzz] Over released ScopeChainNode
+ <rdar://problem/6474110>
+
+ So this delightful bug was caused by our unwind code using a ScopeChain to perform
+ the unwind. The ScopeChain would ref the initial top of the scope chain, then deref
+ the resultant top of scope chain, which is incorrect.
+
+ This patch removes the dependency on ScopeChain for the unwind, and i've filed
+ <https://bugs.webkit.org/show_bug.cgi?id=23144> to look into the unintuitive
+ ScopeChain behaviour.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException):
+
+2009-01-06 Adam Roben <aroben@apple.com>
+
+ Hopeful Windows crash-on-launch fix
+
+ * wtf/Platform.h: Force a world rebuild by touching this file.
+
+2009-01-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by NOBODY (Build fix).
+
+ * GNUmakefile.am:Add ByteArray.cpp too
+
+2009-01-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by NOBODY (Speculative build fix).
+
+ AllInOneFile.cpp does not include the JSByteArray.cpp include it...
+
+ * GNUmakefile.am:
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix Wx build
+
+ * JavaScriptCoreSources.bkl:
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Windows build fixes
+
+ Rubber-stamped by Alice Liu.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ * runtime/ByteArray.cpp:
+ (JSC::ByteArray::create):
+ * runtime/ByteArray.h:
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ CanvasPixelArray performance is too slow
+ <https://bugs.webkit.org/show_bug.cgi?id=23123>
+
+ The fix to this is to devirtualise get and put in a manner similar to
+ JSString and JSArray. To do this I've added a ByteArray implementation
+ and JSByteArray wrapper to JSC. We can then do vptr comparisons to
+ devirtualise the calls.
+
+ This devirtualisation improves performance by 1.5-2x in my somewhat ad
+ hoc tests.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_put_by_val):
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::isJSByteArray):
+ * runtime/ByteArray.cpp: Added.
+ (JSC::ByteArray::create):
+ * runtime/ByteArray.h: Added.
+ (JSC::ByteArray::length):
+ (JSC::ByteArray::set):
+ (JSC::ByteArray::get):
+ (JSC::ByteArray::data):
+ (JSC::ByteArray::ByteArray):
+ * runtime/JSByteArray.cpp: Added.
+ (JSC::):
+ (JSC::JSByteArray::JSByteArray):
+ (JSC::JSByteArray::createStructure):
+ (JSC::JSByteArray::getOwnPropertySlot):
+ (JSC::JSByteArray::put):
+ (JSC::JSByteArray::getPropertyNames):
+ * runtime/JSByteArray.h: Added.
+ (JSC::JSByteArray::canAccessIndex):
+ (JSC::JSByteArray::getIndex):
+ (JSC::JSByteArray::setIndex):
+ (JSC::JSByteArray::classInfo):
+ (JSC::JSByteArray::length):
+ (JSC::JSByteArray::):
+ (JSC::JSByteArray::JSByteArray):
+ (JSC::asByteArray):
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23073
+ <rdar://problem/6471129> Workers crash on Windows Release builds
+
+ * wtf/ThreadSpecific.h:
+ (WTF::ThreadSpecific::destroy): Changed to clear the pointer only after data object
+ destruction is finished - otherwise, WebCore::ThreadGlobalData destructor was re-creating
+ the object in order to access atomic string table.
+ (WTF::ThreadSpecific::operator T*): Symmetrically, set up the per-thread pointer before
+ data constructor is called.
+
+ * wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): Remove a Windows-only hack to finalize
+ a thread - pthreadVC2 is a DLL, so it gets thread detached messages, and cleans up thread
+ specific data automatically. Besides, this code wasn't even compiled in for some time now.
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23115
+ Create a version of ASSERT for use with otherwise unused variables
+
+ * wtf/Assertions.h: Added ASSERT_UNUSED.
+
+ * jit/ExecutableAllocatorPosix.cpp:
+ (JSC::ExecutablePool::systemRelease):
+ * runtime/Collector.cpp:
+ (JSC::Heap::destroy):
+ (JSC::Heap::heapAllocate):
+ * runtime/JSNotAnObject.cpp:
+ (JSC::JSNotAnObject::toPrimitive):
+ (JSC::JSNotAnObject::getPrimitiveNumber):
+ (JSC::JSNotAnObject::toBoolean):
+ (JSC::JSNotAnObject::toNumber):
+ (JSC::JSNotAnObject::toString):
+ (JSC::JSNotAnObject::getOwnPropertySlot):
+ (JSC::JSNotAnObject::put):
+ (JSC::JSNotAnObject::deleteProperty):
+ (JSC::JSNotAnObject::getPropertyNames):
+ * wtf/TCSystemAlloc.cpp:
+ (TCMalloc_SystemRelease):
+ Use it in some places that used other idioms for this purpose.
+
+2009-01-04 Alice Liu <alice.liu@apple.com>
+
+ <rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.
+
+ Reviewed by Darin Adler.
+
+ * runtime/Structure.cpp:
+ (JSC::Structure::Structure): Remove m_transitionCount
+ (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up.
+ (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount.
+ (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount.
+ (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
+ * runtime/Structure.h:
+ Changed s_maxTransitionLength and m_offset from size_t to signed char. m_offset will never become greater than 64
+ because the structure transitions to a dictionary at that time.
+ (JSC::Structure::transitionCount): method to replace the data member
+
+2009-01-04 Darin Adler <darin@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.
+ https://bugs.webkit.org/show_bug.cgi?id=15114
+
+ * wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.
+
+2009-01-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Change the pcVector from storing native code pointers to storing offsets
+ from the base pointer. This will allow us to generate the pcVector on demand
+ for exceptions.
+
+ * bytecode/CodeBlock.h:
+ (JSC::PC::PC):
+ (JSC::getNativePCOffset):
+ (JSC::CodeBlock::getBytecodeIndex):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+
+2009-01-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ * runtime/ScopeChain.cpp:
+
+2009-01-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ [jsfunfuzz] unwind logic for exceptions in eval fails to account for dynamic scope external to the eval
+ https://bugs.webkit.org/show_bug.cgi?id=23078
+
+ This bug was caused by eval codeblocks being generated without accounting
+ for the depth of the scope chain they inherited. This meant that exception
+ handlers would understate their expected scope chain depth, which in turn
+ led to incorrectly removing nodes from the scope chain.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::emitCatch):
+ * bytecompiler/BytecodeGenerator.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::depth):
+ * runtime/ScopeChain.cpp:
+ (JSC::ScopeChain::localDepth):
+ * runtime/ScopeChain.h:
+ (JSC::ScopeChainNode::deref):
+ (JSC::ScopeChainNode::ref):
+
+2009-01-02 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22699
+ Enable NodeList caching for getElementsByTagName
+
+ * wtf/HashFunctions.h: Moved the definition of PHI here and renamed to stringHashingStartValue
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Attempt to fix Qt Linux build after r39553
+
+ * wtf/RandomNumberSeed.h: Include <sys/time.h> for gettimeofday().
+ Include <sys/types.h> and <unistd.h> for getpid().
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23081: These files are no longer part of the KDE libraries
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23081>
+
+ Reviewed by Darin Adler.
+
+ Removed "This file is part of the KDE libraries" comment from
+ source files. Added or updated Apple copyrights as well.
+
+ * parser/Lexer.h:
+ * wtf/HashCountedSet.h:
+ * wtf/RetainPtr.h:
+ * wtf/VectorTraits.h:
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23080: Remove last vestiges of KJS references
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23080>
+
+ Reviewed by Darin Adler.
+
+ Also updated Apple copyright statements.
+
+ * DerivedSources.make: Changed bison "kjsyy" prefix to "jscyy".
+ * GNUmakefile.am: Ditto.
+ * JavaScriptCore.pri: Ditto. Also changed KJSBISON to JSCBISON
+ and kjsbison to jscbison.
+
+ * JavaScriptCoreSources.bkl: Changed JSCORE_KJS_SOURCES to
+ JSCORE_JSC_SOURCES.
+ * jscore.bkl: Ditto.
+
+ * create_hash_table: Updated copyright and removed old comment.
+
+ * parser/Grammar.y: Changed "kjsyy" prefix to "jscyy" prefix.
+ * parser/Lexer.cpp: Ditto. Also changed KJS_DEBUG_LEX to
+ JSC_DEBUG_LEX.
+ (jscyylex):
+ (JSC::Lexer::lex):
+ * parser/Parser.cpp: Ditto.
+ (JSC::Parser::parse):
+
+ * pcre/dftables: Changed "kjs_pcre_" prefix to "jsc_pcre_".
+ * pcre/pcre_compile.cpp: Ditto.
+ (getOthercaseRange):
+ (encodeUTF8):
+ (compileBranch):
+ (calculateCompiledPatternLength):
+ * pcre/pcre_exec.cpp: Ditto.
+ (matchRef):
+ (getUTF8CharAndIncrementLength):
+ (match):
+ * pcre/pcre_internal.h: Ditto.
+ (toLowerCase):
+ (flipCase):
+ (classBitmapForChar):
+ (charTypeForChar):
+ * pcre/pcre_tables.cpp: Ditto.
+ * pcre/pcre_ucp_searchfuncs.cpp: Ditto.
+ (jsc_pcre_ucp_othercase):
+ * pcre/pcre_xclass.cpp: Ditto.
+ (getUTF8CharAndAdvancePointer):
+ (jsc_pcre_xclass):
+
+ * runtime/Collector.h: Updated header guards using the
+ clean-header-guards script.
+ * runtime/CollectorHeapIterator.h: Added missing header guard.
+ * runtime/Identifier.h: Updated header guards.
+ * runtime/JSFunction.h: Fixed end-of-namespace comment.
+
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset): Renamed "kjsprint" debug function
+ to "jscprint". Changed implementation method from
+ globalFuncKJSPrint() to globalFuncJSCPrint().
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncJSCPrint): Renamed from globalFuncKJSPrint().
+ * runtime/JSGlobalObjectFunctions.h: Ditto.
+
+ * runtime/JSImmediate.h: Updated header guards.
+ * runtime/JSLock.h: Ditto.
+ * runtime/JSType.h: Ditto.
+ * runtime/JSWrapperObject.h: Ditto.
+ * runtime/Lookup.h: Ditto.
+ * runtime/Operations.h: Ditto.
+ * runtime/Protect.h: Ditto.
+ * runtime/RegExp.h: Ditto.
+ * runtime/UString.h: Ditto.
+
+ * tests/mozilla/js1_5/Array/regress-157652.js: Changed "KJS"
+ reference in comment to "JSC".
+
+ * wrec/CharacterClassConstructor.cpp: Change "kjs_pcre_" function
+ prefixes to "jsc_pcre_".
+ (JSC::WREC::CharacterClassConstructor::put):
+ (JSC::WREC::CharacterClassConstructor::flush):
+
+ * wtf/unicode/Unicode.h: Change "KJS_" header guard to "WTF_".
+ * wtf/unicode/icu/UnicodeIcu.h: Ditto.
+ * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
+
+2009-01-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Make randomNumber generate 2^53 values instead of 2^32 (or 2^31 for rand() platforms)
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Remove declaration for JSC::Identifier::initializeIdentifierThreading()
+
+ Reviewed by Alexey Proskuryakov.
+
+ * runtime/Identifier.h:
+ (JSC::Identifier::initializeIdentifierThreading): Removed
+ declaration since the implementation was removed in r34412.
+
+2009-01-01 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ String.replace does not support $& replacement metacharacter when search term is not a RegExp
+ <https://bugs.webkit.org/show_bug.cgi?id=21431>
+ <rdar://problem/6274993>
+
+ Test: fast/js/string-replace-3.html
+
+ * runtime/StringPrototype.cpp:
+ (JSC::substituteBackreferences): Added a null check here so we won't try to handle $$-$9
+ backreferences when the search term is a string, not a RegExp. Added a check for 0 so we
+ won't try to handle $0 or $00 as a backreference.
+ (JSC::stringProtoFuncReplace): Added a call to substituteBackreferences.
+
+2009-01-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Allow 32-bit integers to be stored in JSImmediates, on x64-bit.
+ Presently the top 32-bits of a 64-bit JSImmediate serve as a sign extension of a 31-bit
+ int stored in the low word (shifted left by one, to make room for a tag). In the new
+ format, the top 31-bits serve as a sign extension of a 32-bit int, still shifted left by
+ one.
+
+ The new behavior is enabled using a flag in Platform.h, 'WTF_USE_ALTERNATE_JSIMMEDIATE'.
+ When this is set the constants defining the range of ints allowed to be stored as
+ JSImmediate values is extended. The code in JSImmediate.h can safely operate on either
+ format. This patch updates the JIT so that it can also operate with the new format.
+
+ ~2% progression on x86-64, with & without the JIT, on sunspider & v8 tests.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::orPtr):
+ (JSC::MacroAssembler::or32):
+ (JSC::MacroAssembler::rshiftPtr):
+ (JSC::MacroAssembler::rshift32):
+ (JSC::MacroAssembler::subPtr):
+ (JSC::MacroAssembler::xorPtr):
+ (JSC::MacroAssembler::xor32):
+ (JSC::MacroAssembler::move):
+ (JSC::MacroAssembler::compareImm64ForBranch):
+ (JSC::MacroAssembler::compareImm64ForBranchEquality):
+ (JSC::MacroAssembler::jePtr):
+ (JSC::MacroAssembler::jgePtr):
+ (JSC::MacroAssembler::jlPtr):
+ (JSC::MacroAssembler::jlePtr):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jnzSubPtr):
+ (JSC::MacroAssembler::joAddPtr):
+ (JSC::MacroAssembler::jzSubPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::addq_rr):
+ (JSC::X86Assembler::orq_ir):
+ (JSC::X86Assembler::subq_ir):
+ (JSC::X86Assembler::xorq_rr):
+ (JSC::X86Assembler::sarq_CLr):
+ (JSC::X86Assembler::sarq_i8r):
+ (JSC::X86Assembler::cmpq_ir):
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileFastArith_op_lshift):
+ (JSC::JIT::compileFastArithSlow_op_lshift):
+ (JSC::JIT::compileFastArith_op_rshift):
+ (JSC::JIT::compileFastArithSlow_op_rshift):
+ (JSC::JIT::compileFastArith_op_bitand):
+ (JSC::JIT::compileFastArithSlow_op_bitand):
+ (JSC::JIT::compileFastArith_op_mod):
+ (JSC::JIT::compileFastArithSlow_op_mod):
+ (JSC::JIT::compileFastArith_op_add):
+ (JSC::JIT::compileFastArithSlow_op_add):
+ (JSC::JIT::compileFastArith_op_mul):
+ (JSC::JIT::compileFastArithSlow_op_mul):
+ (JSC::JIT::compileFastArith_op_post_inc):
+ (JSC::JIT::compileFastArithSlow_op_post_inc):
+ (JSC::JIT::compileFastArith_op_post_dec):
+ (JSC::JIT::compileFastArithSlow_op_post_dec):
+ (JSC::JIT::compileFastArith_op_pre_inc):
+ (JSC::JIT::compileFastArithSlow_op_pre_inc):
+ (JSC::JIT::compileFastArith_op_pre_dec):
+ (JSC::JIT::compileFastArithSlow_op_pre_dec):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::getConstantOperand):
+ (JSC::JIT::getConstantOperandImmediateInt):
+ (JSC::JIT::isOperandConstantImmediateInt):
+ (JSC::JIT::isOperandConstant31BitImmediateInt):
+ (JSC::JIT::emitFastArithDeTagImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithImmToInt):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::isPositiveNumber):
+ (JSC::JSImmediate::isNegative):
+ (JSC::JSImmediate::rightShiftImmediateNumbers):
+ (JSC::JSImmediate::canDoFastAdditiveOperations):
+ (JSC::JSImmediate::makeValue):
+ (JSC::JSImmediate::makeInt):
+ (JSC::JSImmediate::makeBool):
+ (JSC::JSImmediate::intValue):
+ (JSC::JSImmediate::rawValue):
+ (JSC::JSImmediate::toBoolean):
+ (JSC::JSImmediate::from):
+ * wtf/Platform.h:
+
+2008-12-31 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ [jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable in a catch block
+ <https://bugs.webkit.org/show_bug.cgi?id=23063>
+
+ Eval inside a catch block attempts to use the catch block's static scope in
+ an unsafe way by attempting to add new properties to the scope. This patch
+ fixes this issue simply by preventing the catch block from using a static
+ scope if it contains an eval.
+
+ * parser/Grammar.y:
+ * parser/Nodes.cpp:
+ (JSC::TryNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::TryNode::):
+
+2008-12-31 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ [jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
+ <https://bugs.webkit.org/show_bug.cgi?id=23062>
+
+ This was caused by the expression information for the initial resolve of
+ eval not being emitted. If this resolve was the first instruction that
+ could throw an exception the information search would fail leading to an
+ assertion failure. If it was not the first throwable opcode the wrong
+ expression information would used.
+
+ Fix is simply to emit the expression info.
+
+ * parser/Nodes.cpp:
+ (JSC::EvalFunctionCallNode::emitBytecode):
+
+2008-12-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23054: Caching of global lookups occurs even when the global object has become a dictionary
+ <https://bugs.webkit.org/show_bug.cgi?id=23054>
+ <rdar://problem/6469905>
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::resolveGlobal): Do not cache lookup if the global
+ object has transitioned to a dictionary.
+ (JSC::Interpreter::cti_op_resolve_global): Do not cache lookup if the
+ global object has transitioned to a dictionary.
+
+2008-12-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correctly protect their scope object
+ <rdar://problem/6469742> Crash in JSC::TypeInfo::hasStandardGetOwnPropertySlot() running jsfunfuzz
+
+ The problem that caused this was that with nodes were not correctly protecting
+ the final object that was placed in the scope chain. We correct this by forcing
+ the use of a temporary register (which stops us relying on a local register
+ protecting the scope) and changing the behaviour of op_push_scope so that it
+ will store the final scope object.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitPushScope):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_push_scope):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * parser/Nodes.cpp:
+ (JSC::WithNode::emitBytecode):
+
+2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23037: Parsing and reparsing disagree on automatic semicolon insertion
+ <https://bugs.webkit.org/show_bug.cgi?id=23037>
+ <rdar://problem/6467124>
+
+ Parsing and reparsing disagree about automatic semicolon insertion, so that a
+ function like
+
+ function() { a = 1, }
+
+ is parsed as being syntactically valid but gets a syntax error upon reparsing.
+ This leads to an assertion failure in Parser::reparse(). It is not that big of
+ an issue in practice, because in a Release build such a function will return
+ 'undefined' when called.
+
+ In this case, we are not following the spec and it should be a syntax error.
+ However, unless there is a newline separating the ',' and the '}', WebKit would
+ not treat it as a syntax error in the past either. It would be a bit of work to
+ make the automatic semicolon insertion match the spec exactly, so this patch
+ changes it to match our past behaviour.
+
+ The problem is that even during reparsing, the Lexer adds a semicolon at the
+ end of the input, which confuses allowAutomaticSemicolon(), because it is
+ expecting either a '}', the end of input, or a terminator like a newline.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::Lexer): Initialize m_isReparsing to false.
+ (JSC::Lexer::lex): Do not perform automatic semicolon insertion in the Lexer if
+ we are in the middle of reparsing.
+ (JSC::Lexer::clear): Set m_isReparsing to false.
+ * parser/Lexer.h:
+ (JSC::Lexer::setIsReparsing): Added.
+ * parser/Parser.cpp:
+ (JSC::Parser::reparse): Call Lexer::setIsReparsing() to notify the Lexer of
+ reparsing.
+
+2008-12-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Yet another attempt to fix Tiger.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+
+2008-12-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Tiger build fix (correct this time)
+
+ * wtf/RandomNumber.cpp:
+
+2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Revert r39509, because kjsyydebug is used in the generated code if YYDEBUG is 1.
+
+ * parser/Grammar.y:
+
+2008-12-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Tiger build fix.
+
+ * wtf/RandomNumber.cpp:
+
+2008-12-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6358108> Insecure randomness in Math.random() leads to user tracking
+
+ Switch to arc4random on PLATFORM(DARWIN), this is ~1.5x slower than random(), but the
+ it is still so fast that there is no fathomable way it could be a bottleneck for anything.
+
+ randomNumber is called in two places
+ * During form submission where it is called once per form
+ * Math.random in JSC. For this difference to show up you have to be looping on
+ a cached local copy of random, for a large (>10000) calls.
+
+ No change in SunSpider.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+ * wtf/RandomNumberSeed.h:
+ (WTF::initializeRandomNumberGenerator):
+
+2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Sam Weinig.
+
+ Remove unused kjsyydebug #define.
+
+ * parser/Grammar.y:
+
+2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt and Sam Weinig.
+
+ Bug 23029: REGRESSION (r39337): jsfunfuzz generates identical test files
+ <https://bugs.webkit.org/show_bug.cgi?id=23029>
+ <rdar://problem/6469185>
+
+ The unification of random number generation in r39337 resulted in random()
+ being initialized on Darwin, but rand() actually being used. Fix this by
+ making randomNumber() use random() instead of rand() on Darwin.
+
+ * wtf/RandomNumber.cpp:
+ (WTF::randomNumber):
+
+2008-12-29 Sam Weinig <sam@webkit.org>
+
+ Fix buildbots.
+
+ * runtime/Structure.cpp:
+
+2008-12-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=23026
+ Move the deleted offsets vector into the PropertyMap
+
+ Saves 3 words per Structure.
+
+ * runtime/PropertyMapHashTable.h:
+ * runtime/Structure.cpp:
+ (JSC::Structure::addPropertyTransition):
+ (JSC::Structure::changePrototypeTransition):
+ (JSC::Structure::getterSetterTransition):
+ (JSC::Structure::toDictionaryTransition):
+ (JSC::Structure::fromDictionaryTransition):
+ (JSC::Structure::copyPropertyTable):
+ (JSC::Structure::put):
+ (JSC::Structure::remove):
+ (JSC::Structure::rehashPropertyMapHashTable):
+ * runtime/Structure.h:
+ (JSC::Structure::propertyStorageSize):
+
+2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Change code using m_body.get() as a boolean to take advantage of the
+ implicit conversion of RefPtr to boolean.
+
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::~JSFunction):
+
+2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 22840: REGRESSION (r38349): Gmail doesn't load with profiling enabled
+ <https://bugs.webkit.org/show_bug.cgi?id=22840>
+ <rdar://problem/6468077>
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitNewArray): Add an assertion that the range
+ of registers passed to op_new_array is sequential.
+ (JSC::BytecodeGenerator::emitCall): Correct the relocation of registers
+ when emitting profiler hooks so that registers aren't leaked. Also, add
+ an assertion that the 'this' register is always ref'd (because it is),
+ remove the needless protection of the 'this' register when relocating,
+ and add an assertion that the range of registers passed to op_call for
+ function call arguments is sequential.
+ (JSC::BytecodeGenerator::emitConstruct): Correct the relocation of
+ registers when emitting profiler hooks so that registers aren't leaked.
+ Also, add an assertion that the range of registers passed to op_construct
+ for function call arguments is sequential.
+
+2008-12-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ <rdar://problem/6467376> Race condition in WTF::currentThread can lead to a thread using two different identifiers during its lifetime
+
+ If a newly-created thread calls WTF::currentThread() before WTF::createThread calls establishIdentifierForPthreadHandle
+ then more than one identifier will be used for the same thread. We can avoid this by adding some extra synchronization
+ during thread creation that delays the execution of the thread function until the thread identifier has been set up, and
+ an assertion to catch this problem should it reappear in the future.
+
+ * wtf/Threading.cpp: Added.
+ (WTF::NewThreadContext::NewThreadContext):
+ (WTF::threadEntryPoint):
+ (WTF::createThread): Add cross-platform createThread function that delays the execution of the thread function until
+ after the thread identifier has been set up.
+ * wtf/Threading.h:
+ * wtf/ThreadingGtk.cpp:
+ (WTF::establishIdentifierForThread):
+ (WTF::createThreadInternal):
+ * wtf/ThreadingNone.cpp:
+ (WTF::createThreadInternal):
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::establishIdentifierForPthreadHandle):
+ (WTF::createThreadInternal):
+ * wtf/ThreadingQt.cpp:
+ (WTF::identifierByQthreadHandle):
+ (WTF::establishIdentifierForThread):
+ (WTF::createThreadInternal):
+ * wtf/ThreadingWin.cpp:
+ (WTF::storeThreadHandleByIdentifier):
+ (WTF::createThreadInternal):
+
+ Add Threading.cpp to the build.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+
+2008-12-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove unused method.
+
+ * runtime/Structure.h: Remove mutableTypeInfo.
+
+2008-12-22 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix rounding / bounds / signed comparison bug in ExecutableAllocator.
+
+ ExecutableAllocator::alloc assumed that m_freePtr would be aligned. This was
+ not always true, since the first allocation from an additional pool would not
+ be rounded up. Subsequent allocations would be unaligned, and too much memory
+ could be erroneously allocated from the pool, when the size requested was
+ available, but the size rounded up to word granularity was not available in the
+ pool. This may result in the value of m_freePtr being greater than m_end.
+
+ Under these circumstances, the unsigned check for space will always pass,
+ resulting in pointers to memory outside of the arena being returned, and
+ ultimately segfaulty goodness when attempting to memcpy the hot freshly jitted
+ code from the AssemblerBuffer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22974
+ ... and probably many, many more.
+
+ * jit/ExecutableAllocator.h:
+ (JSC::ExecutablePool::alloc):
+ (JSC::ExecutablePool::roundUpAllocationSize):
+ (JSC::ExecutablePool::ExecutablePool):
+ (JSC::ExecutablePool::poolAllocate):
+
+2008-12-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Rename all uses of the term "repatch" to "patch".
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::DataLabelPtr::patch):
+ (JSC::MacroAssembler::DataLabel32::patch):
+ (JSC::MacroAssembler::Jump::patch):
+ (JSC::MacroAssembler::PatchBuffer::PatchBuffer):
+ (JSC::MacroAssembler::PatchBuffer::setPtr):
+ (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
+ (JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
+ (JSC::MacroAssembler::storePtrWithPatch):
+ (JSC::MacroAssembler::jnePtrWithPatch):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::patchAddress):
+ (JSC::X86Assembler::patchImmediate):
+ (JSC::X86Assembler::patchPointer):
+ (JSC::X86Assembler::patchBranchOffset):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ * jit/JIT.cpp:
+ (JSC::ctiPatchCallByReturnAddress):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ (JSC::JIT::compileOpCall):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+
+2008-12-22 Adam Roben <aroben@apple.com>
+
+ Build fix after r39428
+
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSlowCase): Added a missing MacroAssembler::
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by George Staikos.
+
+ Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
+
+ * wtf/RandomNumber.cpp:
+ * wtf/RandomNumber.h:
+ * wtf/RandomNumberSeed.h:
+
+2008-12-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by George Staikos.
+
+ Fix copyright of the new RandomNumber* files.
+
+ * wtf/RandomNumber.cpp:
+ * wtf/RandomNumber.h:
+ * wtf/RandomNumberSeed.h:
+
+2008-12-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt & Cameron Zwarich.
+
+ Add support for call and property access repatching on x86-64.
+
+ No change in performance on current configurations (2x impovement on v8-tests with JIT enabled on x86-64).
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::DataLabelPtr::repatch):
+ (JSC::MacroAssembler::DataLabelPtr::operator X86Assembler::JmpDst):
+ (JSC::MacroAssembler::DataLabel32::repatch):
+ (JSC::MacroAssembler::RepatchBuffer::addressOf):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::loadPtrWithAddressOffsetRepatch):
+ (JSC::MacroAssembler::storePtrWithAddressOffsetRepatch):
+ (JSC::MacroAssembler::jePtr):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jnePtrWithRepatch):
+ (JSC::MacroAssembler::differenceBetween):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::addl_im):
+ (JSC::X86Assembler::subl_im):
+ (JSC::X86Assembler::cmpl_rm):
+ (JSC::X86Assembler::movq_rm_disp32):
+ (JSC::X86Assembler::movq_mr_disp32):
+ (JSC::X86Assembler::repatchPointer):
+ (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITCall.cpp:
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::resizePropertyStorage):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ * wtf/Platform.h:
+
+2008-12-20 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Port optimized property access generation to the MacroAssembler.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::AbsoluteAddress::AbsoluteAddress):
+ (JSC::MacroAssembler::DataLabelPtr::repatch):
+ (JSC::MacroAssembler::DataLabel32::DataLabel32):
+ (JSC::MacroAssembler::DataLabel32::repatch):
+ (JSC::MacroAssembler::Label::operator X86Assembler::JmpDst):
+ (JSC::MacroAssembler::Jump::repatch):
+ (JSC::MacroAssembler::JumpList::empty):
+ (JSC::MacroAssembler::RepatchBuffer::link):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::and32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::loadPtrWithAddressRepatch):
+ (JSC::MacroAssembler::storePtrWithAddressRepatch):
+ (JSC::MacroAssembler::push):
+ (JSC::MacroAssembler::ja32):
+ (JSC::MacroAssembler::jePtr):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jnePtrWithRepatch):
+ (JSC::MacroAssembler::align):
+ (JSC::MacroAssembler::differenceBetween):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::movl_rm_disp32):
+ (JSC::X86Assembler::movl_mr_disp32):
+ (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32):
+ (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
+ * jit/JIT.cpp:
+ (JSC::ctiRepatchCallByReturnAddress):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::resizePropertyStorage):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * wtf/RefCounted.h:
+ (WTF::RefCountedBase::addressOfCount):
+
+2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22686
+
+ Added file which was missing to the javascriptcore_sources
+ variable, so that it shows up in the tarball created by `make
+ dist'.
+
+ * GNUmakefile.am:
+
+2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Antti Koivisto.
+
+ Build fix when building JS API tests with a c89 c compiler
+
+ Do not use C++ style comments and convert them to C comments.
+
+ * wtf/Platform.h:
+
+2008-12-18 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Same as last revision, adding cases for pre & post inc & dec.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22928
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2008-12-18 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixes for the JIT's handling of JSImmediate values on x86-64.
+ On 64-bit systems, the code in JSImmediate.h relies on the upper
+ bits of a JSImmediate being a sign extension of the low 32-bits.
+ This was not being enforced by the JIT, since a number of inline
+ operations were being performed on 32-bit values in registers, and
+ when a 32-bit result is written to a register on x86-64 the value
+ is zero-extended to 64-bits.
+
+ This fix honors previous behavoir. A better fix in the long run
+ (when the JIT is enabled by default) may be to change JSImmediate.h
+ so it no longer relies on the upper bits of the pointer,... though
+ if we're going to change JSImmediate.h for 64-bit, we probably may
+ as well change the format so that the full range of 32-bit ints can
+ be stored, rather than just 31-bits.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22925
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::andPtr):
+ (JSC::MacroAssembler::orPtr):
+ (JSC::MacroAssembler::or32):
+ (JSC::MacroAssembler::xor32):
+ (JSC::MacroAssembler::xorPtr):
+ (JSC::MacroAssembler::signExtend32ToPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::andq_rr):
+ (JSC::X86Assembler::andq_ir):
+ (JSC::X86Assembler::orq_rr):
+ (JSC::X86Assembler::xorq_ir):
+ (JSC::X86Assembler::movsxd_rr):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+ (JSC::JIT::emitFastArithImmToInt):
+
+2008-12-18 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Just a tidy up - rename & refactor some the #defines configuring the JIT.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_end):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_timeout_check):
+ (JSC::Interpreter::cti_register_file_check):
+ (JSC::Interpreter::cti_op_loop_if_less):
+ (JSC::Interpreter::cti_op_loop_if_lesseq):
+ (JSC::Interpreter::cti_op_new_object):
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
+ (JSC::Interpreter::cti_op_get_by_id_proto_fail):
+ (JSC::Interpreter::cti_op_get_by_id_array_fail):
+ (JSC::Interpreter::cti_op_get_by_id_string_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_new_func):
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_op_call_arityCheck):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ (JSC::Interpreter::cti_op_push_activation):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_create_arguments):
+ (JSC::Interpreter::cti_op_create_arguments_no_params):
+ (JSC::Interpreter::cti_op_tear_off_activation):
+ (JSC::Interpreter::cti_op_tear_off_arguments):
+ (JSC::Interpreter::cti_op_profile_will_call):
+ (JSC::Interpreter::cti_op_profile_did_call):
+ (JSC::Interpreter::cti_op_ret_scopeChain):
+ (JSC::Interpreter::cti_op_new_array):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_JSConstruct):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_lesseq):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_resolve_base):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_jless):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_new_func_exp):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_less):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_new_regexp):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_call_eval):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_get_pnames):
+ (JSC::Interpreter::cti_op_next_pname):
+ (JSC::Interpreter::cti_op_push_scope):
+ (JSC::Interpreter::cti_op_pop_scope):
+ (JSC::Interpreter::cti_op_typeof):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_is_boolean):
+ (JSC::Interpreter::cti_op_is_number):
+ (JSC::Interpreter::cti_op_is_string):
+ (JSC::Interpreter::cti_op_is_object):
+ (JSC::Interpreter::cti_op_is_function):
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_push_new_scope):
+ (JSC::Interpreter::cti_op_jmp_scopes):
+ (JSC::Interpreter::cti_op_put_by_index):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_op_del_by_val):
+ (JSC::Interpreter::cti_op_put_getter):
+ (JSC::Interpreter::cti_op_put_setter):
+ (JSC::Interpreter::cti_op_new_error):
+ (JSC::Interpreter::cti_op_debug):
+ (JSC::Interpreter::cti_vm_throw):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ * wtf/Platform.h:
+
+2008-12-18 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
+ <https://bugs.webkit.org/show_bug.cgi?id=21855>
+ <rdar://problem/6278244>
+
+ Move DynamicGlobalObjectScope to JSGlobalObject.h so that it can be used
+ from WebCore.
+
+ * interpreter/Interpreter.cpp:
+ * runtime/JSGlobalObject.h:
+ (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
+ (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
+
+2008-12-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22393
+ Segfault when caching property accesses to primitive cells.
+
+ Changed some asObject casts to asCell casts in cases where a primitive
+ value may be a cell and not an object.
+
+ Re-enabled property caching for primitives in cases where it had been
+ disabled because of this bug.
+
+ Updated a comment to better explain something Darin thought needed
+ explaining in an old patch review.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+
+2008-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixes for Sunspider failures with the JIT enabled on x86-64.
+
+ * assembler/MacroAssembler.h:
+ Switch the order of the RegisterID & Address form of je32, to keep it consistent with jne32.
+ * jit/JIT.cpp:
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ Port the m_ctiVirtualCall tramopline generation to use the MacroAssembler interface.
+ * jit/JITCall.cpp:
+ Fix bug in the non-optimizing code path, vptr check should have been to the memory address pointer
+ to by the register, not to the register itself.
+ * wrec/WRECGenerator.cpp:
+ See assembler/MacroAssembler.h, above.
+
+2008-12-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ print("Hello, 64-bit jitted world!");
+ Get hello-world working through the JIT, on x86-64.
+
+ * assembler/X86Assembler.h:
+ Fix encoding of opcode + RegisterID format instructions for 64-bit.
+ * interpreter/Interpreter.cpp:
+ * interpreter/Interpreter.h:
+ Make VoidPtrPair actually be a pair of void*s.
+ (Possibly should make this change for 32-bit Mac platforms, too - but won't change 32-bit behaviour in this patch).
+ * jit/JIT.cpp:
+ * jit/JIT.h:
+ Provide names for the timeoutCheckRegister & callFrameRegister on x86-64,
+ force x86-64 ctiTrampoline arguments onto the stack,
+ implement the asm trampolines for x86-64,
+ implement the restoreArgumentReference methods for x86-64 calling conventions.
+ * jit/JITCall.cpp:
+ * jit/JITInlineMethods.h:
+ * wtf/Platform.h:
+ Add switch settings to ENABLE(JIT), on PLATFORM(X86_64) (currently still disabled).
+
+2008-12-17 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Add more CodeBlock statistics.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpStatistics):
+
+2008-12-17 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22897
+ <rdar://problem/6428342>
+ Look into feasibility of discarding bytecode after native codegen
+
+ Clear the bytecode Instruction vector at the end JIT generation.
+
+ Saves 4.8 MB on Membuster head.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Add logging for the case that someone tries
+ to dump the instructions of a CodeBlock that has had its bytecode
+ vector cleared.
+ (JSC::CodeBlock::CodeBlock): Initialize the instructionCount
+ (JSC::CodeBlock::handlerForBytecodeOffset): Use instructionCount instead
+ of the size of the instruction vector in the assertion.
+ (JSC::CodeBlock::lineNumberForBytecodeOffset): Ditto.
+ (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto.
+ (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
+ (JSC::CodeBlock::functionRegisterForBytecodeOffset): Ditto.
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::setInstructionCount): Store the instruction vector size
+ in debug builds for assertions.
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile): Clear the bytecode vector unless we
+ have compiled with Opcode sampling where we will continue to require it
+
+2008-12-17 Cary Clark <caryclark@google.com>
+
+ Reviewed by Darin Adler.
+ Landed by Adam Barth.
+
+ Add ENABLE_TEXT_CARET to permit the ANDROID platform
+ to invalidate and draw the caret in a separate thread.
+
+ * wtf/Platform.h:
+ Default ENABLE_TEXT_CARET to 1.
+
+2008-12-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Don't use unique context group in JSGlobalContextCreate() on Tiger or Leopard, take two.
+
+ * API/JSContextRef.cpp: The previous patch that claimed to do this was making Tiger and
+ Leopard always use unique context group instead.
+
+2008-12-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22838
+ Remove dependency on the bytecode Instruction buffer in Interpreter::throwException
+ Part of <rdar://problem/6428342>
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::functionRegisterForBytecodeOffset): Added. Function to get
+ a function Register index in a callFrame for a bytecode offset.
+ (JSC::CodeBlock::shrinkToFit): Shrink m_getByIdExceptionInfo and m_functionRegisterInfos.
+ * bytecode/CodeBlock.h:
+ (JSC::FunctionRegisterInfo::FunctionRegisterInfo): Added.
+ (JSC::CodeBlock::addFunctionRegisterInfo):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitCall):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException): Use functionRegisterForBytecodeOffset in JIT
+ mode.
+
+2008-12-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22837
+ Remove dependency on the bytecode Instruction buffer in Interpreter::cti_op_call_NotJSFunction
+ Part of <rdar://problem/6428342>
+
+ * interpreter/CallFrame.h: Added comment regarding returnPC storing a void*.
+ * interpreter/Interpreter.cpp:
+ (JSC::bytecodeOffsetForPC): We no longer have any cases of the PC
+ being in the instruction stream for JIT, so we can remove the check.
+ (JSC::Interpreter::cti_op_call_NotJSFunction): Use the CTI_RETURN_ADDRESS
+ as the call frame returnPC as it is only necessary for looking up when
+ throwing an exception.
+ * interpreter/RegisterFile.h:
+ (JSC::RegisterFile::): Added comment regarding returnPC storing a void*.
+ * jit/JIT.h: Remove ARG_instr4.
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSetupArgs): Don't pass the instruction pointer.
+
+2008-12-16 Darin Adler <darin@apple.com>
+
+ Reviewed and landed by Cameron Zwarich.
+
+ Preparatory work for fixing
+
+ Bug 22887: Make UString::Rep use RefCounted rather than implementing its own ref counting
+ <https://bugs.webkit.org/show_bug.cgi?id=22887>
+
+ Change the various string translators used by Identifier:add() so that
+ they never zero the ref count of a newly created UString::Rep.
+
+ * runtime/Identifier.cpp:
+ (JSC::CStringTranslator::translate):
+ (JSC::Identifier::add):
+ (JSC::UCharBufferTranslator::translate):
+
+2008-12-16 Gavin Barraclough <barraclough@apple.com>
+
+ Build fix for 'doze.
+
+ * assembler/AssemblerBuffer.h:
+
+2008-12-16 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Make the JIT compile on x86-64.
+ This largely involves populting the missing calls in MacroAssembler.h.
+ In addition some reinterpret_casts need removing from the JIT, and the
+ repatching property access code will need to be fully compiled out for
+ now. The changes in interpret.cpp are to reorder the functions so that
+ the _generic forms come before all other property access methods, and
+ then to place all property access methods other than the generic forms
+ under control of the ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS macro.
+
+ No performance impact.
+
+ * assembler/AssemblerBuffer.h:
+ (JSC::AssemblerBuffer::putInt64Unchecked):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::load32):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::storePtrWithRepatch):
+ (JSC::MacroAssembler::store32):
+ (JSC::MacroAssembler::poke):
+ (JSC::MacroAssembler::move):
+ (JSC::MacroAssembler::testImm64):
+ (JSC::MacroAssembler::jePtr):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jnzPtr):
+ (JSC::MacroAssembler::jzPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::cmpq_rr):
+ (JSC::X86Assembler::cmpq_rm):
+ (JSC::X86Assembler::cmpq_im):
+ (JSC::X86Assembler::testq_i32m):
+ (JSC::X86Assembler::movl_mEAX):
+ (JSC::X86Assembler::movl_i32r):
+ (JSC::X86Assembler::movl_EAXm):
+ (JSC::X86Assembler::movq_rm):
+ (JSC::X86Assembler::movq_mEAX):
+ (JSC::X86Assembler::movq_mr):
+ (JSC::X86Assembler::movq_i64r):
+ (JSC::X86Assembler::movl_mr):
+ (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64):
+ (JSC::X86Assembler::X86InstructionFormatter::immediate64):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCall):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ * runtime/JSImmediate.h:
+ (JSC::JSImmediate::makeInt):
+
+2008-12-16 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22869: REGRESSION (r38407): http://news.cnet.com/8301-13579_3-9953533-37.html crashes
+ <https://bugs.webkit.org/show_bug.cgi?id=22869>
+ <rdar://problem/6402499>
+
+ Before r38407, Structure::m_nameInPrevious was ref'd due to it being
+ stored in a PropertyMap. However, PropertyMaps are created lazily after
+ r38407, so Structure::m_nameInPrevious is not necessarily ref'd while
+ it is being used. Making it a RefPtr instead of a raw pointer fixes
+ the problem.
+
+ Unfortunately, the crash in the bug is rather intermittent, and it is
+ impossible to add an assertion in UString::Ref::ref() to catch this bug
+ because some users of UString::Rep deliberately zero out the reference
+ count. Therefore, there is no layout test accompanying this bug fix.
+
+ * runtime/Structure.cpp:
+ (JSC::Structure::~Structure): Use get().
+ (JSC::Structure::materializePropertyMap): Use get().
+ (JSC::Structure::addPropertyTransitionToExistingStructure): Use get().
+ (JSC::Structure::addPropertyTransition): Use get().
+ * runtime/Structure.h: Make Structure::m_nameInPrevious a RefPtr instead
+ of a raw pointer.
+
+2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Attempt to fix win build. No 'using namespace WTF' in this file, needs manual WTF:: prefix.
+ Not sure why the build works as is here.
+
+ * runtime/MathObject.cpp:
+ (JSC::mathProtoFuncRandom):
+
+2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22876
+
+ Unify random number generation in JavaScriptCore & WebCore, by introducing
+ wtf/RandomNumber.h and moving wtf_random/wtf_random_init out of MathExtras.h.
+
+ wtf_random_init() has been renamed to initializeRandomNumberGenerator() and
+ lives in it's own private header: wtf/RandomNumberSeed.h, only intended to
+ be used from within JavaScriptCore.
+
+ wtf_random() has been renamed to randomNumber() and lives in a public header
+ wtf/RandomNumber.h, usable from within JavaScriptCore & WebCore. It encapsulates
+ the code taking care of initializing the random number generator (only when
+ building without ENABLE(JSC_MULTIPLE_THREADS), otherwhise initializeThreading()
+ already took care of that).
+
+ Functional change on darwin: Use random() instead of rand(), as it got a larger
+ period (more randomness). HTMLFormElement already contains this implementation
+ and I just moved it in randomNumber(), as special case for PLATFORM(DARWIN).
+
+ * GNUmakefile.am: Add RandomNumber.(cpp/h) / RandomNumberSeed.h.
+ * JavaScriptCore.exp: Ditto.
+ * JavaScriptCore.pri: Ditto.
+ * JavaScriptCore.scons: Ditto.
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
+ * JavaScriptCoreSources.bkl: Ditto.
+ * runtime/MathObject.cpp: Use new WTF::randomNumber() functionality.
+ (JSC::mathProtoFuncRandom):
+ * wtf/MathExtras.h: Move wtf_random / wtf_random_init to new files.
+ * wtf/RandomNumber.cpp: Added.
+ (WTF::randomNumber):
+ * wtf/RandomNumber.h: Added.
+ * wtf/RandomNumberSeed.h: Added. Internal usage within JSC only.
+ (WTF::initializeRandomNumberGenerator):
+ * wtf/ThreadingGtk.cpp: Rename wtf_random_init() to initializeRandomNumberGenerator().
+ (WTF::initializeThreading):
+ * wtf/ThreadingPthreads.cpp: Ditto.
+ (WTF::initializeThreading):
+ * wtf/ThreadingQt.cpp: Ditto.
+ (WTF::initializeThreading):
+ * wtf/ThreadingWin.cpp: Ditto.
+ (WTF::initializeThreading):
+
+2008-12-16 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Qt/Win build fix
+
+ * JavaScriptCore.pri:
+
+2008-12-15 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix the build with GCC 4.0.
+
+ * Configurations/JavaScriptCore.xcconfig: GCC 4.0 appears to have a bug when compiling with -funwind-tables on,
+ so don't use it with that compiler version.
+
+2008-12-15 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Cameron Zwarich.
+
+ <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+
+2008-12-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Don't use unique context group in JSGlobalContextCreate() on Tiger or Leopard.
+
+ * API/JSContextRef.cpp: (JSGlobalContextCreate):
+
+2008-12-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6445089> Mach ports leak from worker threads
+
+ * interpreter/Interpreter.cpp: (JSC::getCPUTime):
+ Deallocate the thread self port.
+
+2008-12-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Construct stack frames in JIT code, so that backtracing can still work.
+ <rdar://problem/6447870> JIT should play nice with attempts to take stack traces
+
+ * jit/JIT.cpp:
+ (JSC::):
+ (JSC::JIT::privateCompileMainPass):
+
+2008-12-15 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6402262> JavaScriptCore needs exception handling tables in order to get stack traces without frame pointers
+
+ * Configurations/JavaScriptCore.xcconfig:
+
+2008-12-15 Gavin Barraclough <barraclough@apple.com>
+
+ Rubber stamped by Mark Rowe.
+
+ Revert r39226 / Bug 22818: Unify JIT callback argument access OS X / Windows
+ This causes Acid3 failures – reverting for now & will revisit later.
+ https://bugs.webkit.org/show_bug.cgi?id=22873
+
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ (JSC::JIT::emitCTICall_internal):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ * wtf/Platform.h:
+
+2008-12-15 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6427048> crash due to infinite recursion after setting window.__proto__ = window
+
+ Replaced toGlobalObject with the more generally useful unwrappedObject and used it to
+ fix the cycle detection code in put(__proto__).
+
+ * JavaScriptCore.exp: Updated.
+
+ * runtime/JSGlobalObject.cpp: Removed toGlobalObject. We now use unwrappedObject instead.
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::isGlobalObject): Ditto.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval): Use unwrappedObject and isGlobalObject here rather than toGlobalObject.
+
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::put): Rewrote prototype cycle checking loop. Use unwrappedObject in the loop now.
+ (JSC::JSObject::unwrappedObject): Replaced toGlobalObject with this new function.
+ * runtime/JSObject.h: More of the same.
+
+2008-12-15 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ Visual Studio requires visibility of forward declarations to match class declaration.
+
+ * assembler/X86Assembler.h:
+
+2008-12-15 Gustavo Noronha Silva <kov@kov.eti.br>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22686
+
+ GTK+ build fix.
+
+ * GNUmakefile.am:
+
+2008-12-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Add support to X86Assembler emitting instructions that access all 16 registers on x86-64.
+ Add a new formating class, that is reponsible for both emitting the opcode bytes and the
+ ModRm bytes of an instruction in a single call; this can insert the REX byte as necessary
+ before the opcode, but has access to the register numbers to build the REX.
+
+ * assembler/AssemblerBuffer.h:
+ (JSC::AssemblerBuffer::isAligned):
+ (JSC::AssemblerBuffer::data):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::and32):
+ (JSC::MacroAssembler::or32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::xor32):
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::load32):
+ (JSC::MacroAssembler::load16):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::storePtrWithRepatch):
+ (JSC::MacroAssembler::store32):
+ (JSC::MacroAssembler::pop):
+ (JSC::MacroAssembler::push):
+ (JSC::MacroAssembler::compareImm32ForBranch):
+ (JSC::MacroAssembler::compareImm32ForBranchEquality):
+ (JSC::MacroAssembler::testImm32):
+ (JSC::MacroAssembler::jae32):
+ (JSC::MacroAssembler::jb32):
+ (JSC::MacroAssembler::je16):
+ (JSC::MacroAssembler::jg32):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jne32):
+ (JSC::MacroAssembler::jump):
+ * assembler/X86Assembler.h:
+ (JSC::X86::):
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::size):
+ (JSC::X86Assembler::push_r):
+ (JSC::X86Assembler::pop_r):
+ (JSC::X86Assembler::push_i32):
+ (JSC::X86Assembler::push_m):
+ (JSC::X86Assembler::pop_m):
+ (JSC::X86Assembler::addl_rr):
+ (JSC::X86Assembler::addl_mr):
+ (JSC::X86Assembler::addl_ir):
+ (JSC::X86Assembler::addq_ir):
+ (JSC::X86Assembler::addl_im):
+ (JSC::X86Assembler::andl_rr):
+ (JSC::X86Assembler::andl_ir):
+ (JSC::X86Assembler::orl_rr):
+ (JSC::X86Assembler::orl_mr):
+ (JSC::X86Assembler::orl_ir):
+ (JSC::X86Assembler::subl_rr):
+ (JSC::X86Assembler::subl_mr):
+ (JSC::X86Assembler::subl_ir):
+ (JSC::X86Assembler::subl_im):
+ (JSC::X86Assembler::xorl_rr):
+ (JSC::X86Assembler::xorl_ir):
+ (JSC::X86Assembler::sarl_i8r):
+ (JSC::X86Assembler::sarl_CLr):
+ (JSC::X86Assembler::shll_i8r):
+ (JSC::X86Assembler::shll_CLr):
+ (JSC::X86Assembler::imull_rr):
+ (JSC::X86Assembler::imull_i32r):
+ (JSC::X86Assembler::idivl_r):
+ (JSC::X86Assembler::cmpl_rr):
+ (JSC::X86Assembler::cmpl_rm):
+ (JSC::X86Assembler::cmpl_mr):
+ (JSC::X86Assembler::cmpl_ir):
+ (JSC::X86Assembler::cmpl_ir_force32):
+ (JSC::X86Assembler::cmpl_im):
+ (JSC::X86Assembler::cmpl_im_force32):
+ (JSC::X86Assembler::cmpw_rm):
+ (JSC::X86Assembler::testl_rr):
+ (JSC::X86Assembler::testl_i32r):
+ (JSC::X86Assembler::testl_i32m):
+ (JSC::X86Assembler::testq_rr):
+ (JSC::X86Assembler::testq_i32r):
+ (JSC::X86Assembler::testb_i8r):
+ (JSC::X86Assembler::sete_r):
+ (JSC::X86Assembler::setz_r):
+ (JSC::X86Assembler::setne_r):
+ (JSC::X86Assembler::setnz_r):
+ (JSC::X86Assembler::cdq):
+ (JSC::X86Assembler::xchgl_rr):
+ (JSC::X86Assembler::movl_rr):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::movl_mr):
+ (JSC::X86Assembler::movl_i32r):
+ (JSC::X86Assembler::movl_i32m):
+ (JSC::X86Assembler::movq_rr):
+ (JSC::X86Assembler::movq_rm):
+ (JSC::X86Assembler::movq_mr):
+ (JSC::X86Assembler::movzwl_mr):
+ (JSC::X86Assembler::movzbl_rr):
+ (JSC::X86Assembler::leal_mr):
+ (JSC::X86Assembler::call):
+ (JSC::X86Assembler::jmp):
+ (JSC::X86Assembler::jmp_r):
+ (JSC::X86Assembler::jmp_m):
+ (JSC::X86Assembler::jne):
+ (JSC::X86Assembler::jnz):
+ (JSC::X86Assembler::je):
+ (JSC::X86Assembler::jl):
+ (JSC::X86Assembler::jb):
+ (JSC::X86Assembler::jle):
+ (JSC::X86Assembler::jbe):
+ (JSC::X86Assembler::jge):
+ (JSC::X86Assembler::jg):
+ (JSC::X86Assembler::ja):
+ (JSC::X86Assembler::jae):
+ (JSC::X86Assembler::jo):
+ (JSC::X86Assembler::jp):
+ (JSC::X86Assembler::js):
+ (JSC::X86Assembler::addsd_rr):
+ (JSC::X86Assembler::addsd_mr):
+ (JSC::X86Assembler::cvtsi2sd_rr):
+ (JSC::X86Assembler::cvttsd2si_rr):
+ (JSC::X86Assembler::movd_rr):
+ (JSC::X86Assembler::movsd_rm):
+ (JSC::X86Assembler::movsd_mr):
+ (JSC::X86Assembler::mulsd_rr):
+ (JSC::X86Assembler::mulsd_mr):
+ (JSC::X86Assembler::pextrw_irr):
+ (JSC::X86Assembler::subsd_rr):
+ (JSC::X86Assembler::subsd_mr):
+ (JSC::X86Assembler::ucomis_rr):
+ (JSC::X86Assembler::int3):
+ (JSC::X86Assembler::ret):
+ (JSC::X86Assembler::predictNotTaken):
+ (JSC::X86Assembler::label):
+ (JSC::X86Assembler::align):
+ (JSC::X86Assembler::link):
+ (JSC::X86Assembler::executableCopy):
+ (JSC::X86Assembler::X86InstructionFormater::prefix):
+ (JSC::X86Assembler::X86InstructionFormater::oneByteOp):
+ (JSC::X86Assembler::X86InstructionFormater::twoByteOp):
+ (JSC::X86Assembler::X86InstructionFormater::oneByteOp64):
+ (JSC::X86Assembler::X86InstructionFormater::oneByteOp8):
+ (JSC::X86Assembler::X86InstructionFormater::twoByteOp8):
+ (JSC::X86Assembler::X86InstructionFormater::instructionImmediate8):
+ (JSC::X86Assembler::X86InstructionFormater::instructionImmediate32):
+ (JSC::X86Assembler::X86InstructionFormater::instructionRel32):
+ (JSC::X86Assembler::X86InstructionFormater::size):
+ (JSC::X86Assembler::X86InstructionFormater::isAligned):
+ (JSC::X86Assembler::X86InstructionFormater::data):
+ (JSC::X86Assembler::X86InstructionFormater::executableCopy):
+ (JSC::X86Assembler::X86InstructionFormater::registerModRM):
+ (JSC::X86Assembler::X86InstructionFormater::memoryModRM):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2008-12-15 Darin Adler <darin@apple.com>
+
+ * interpreter/RegisterFile.h: Tweak include formatting.
+
+2008-12-15 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix for Gtk+.
+
+ * interpreter/RegisterFile.h: Include stdio.h for fprintf
+
+2008-12-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time
+
+ * interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
+ Improve error handling: if mmap fails, crash immediately, and print out the reason.
+
+2008-12-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Re-enable WREC on 64-bit.
+ Implements one of the MacroAssembler::jnzPtr methods, previously only implemented for 32-bit x86.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22849
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::testImm64):
+ (JSC::MacroAssembler::jnzPtr):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::testq_i32r):
+ (JSC::X86Assembler::testq_rr):
+ * wtf/Platform.h:
+
+2008-12-13 Gavin Barraclough <barraclough@apple.com>
+
+ Fix PPC builds.
+
+ * assembler/MacroAssembler.h:
+
+2008-12-13 Gavin Barraclough <barraclough@apple.com>
+
+ Build fix only, no review.
+
+ * bytecode/CodeBlock.h:
+
+2008-12-13 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Port the remainder of the JIT, bar calling convention related code, and code
+ implementing optimizations which can be disabled, to use the MacroAssembler.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::DataLabelPtr::DataLabelPtr):
+ (JSC::MacroAssembler::RepatchBuffer::RepatchBuffer):
+ (JSC::MacroAssembler::RepatchBuffer::link):
+ (JSC::MacroAssembler::RepatchBuffer::addressOf):
+ (JSC::MacroAssembler::RepatchBuffer::setPtr):
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::lshift32):
+ (JSC::MacroAssembler::mod32):
+ (JSC::MacroAssembler::rshift32):
+ (JSC::MacroAssembler::storePtrWithRepatch):
+ (JSC::MacroAssembler::jnzPtr):
+ (JSC::MacroAssembler::jzPtr):
+ (JSC::MacroAssembler::jump):
+ (JSC::MacroAssembler::label):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::xchgl_rr):
+ (JSC::X86Assembler::jmp_m):
+ (JSC::X86Assembler::repatchAddress):
+ (JSC::X86Assembler::getRelocatedAddress):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::CodeBlock):
+ * bytecode/CodeBlock.h:
+ (JSC::JITCodeRef::JITCodeRef):
+ (JSC::CodeBlock::setJITCode):
+ (JSC::CodeBlock::jitCode):
+ (JSC::CodeBlock::executablePool):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileLinkPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JumpTable::JumpTable):
+ (JSC::JIT::emitCTICall):
+ (JSC::JIT::JSRInfo::JSRInfo):
+ * jit/JITArithmetic.cpp:
+ * jit/JITCall.cpp:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::emitCTICall_internal):
+ (JSC::JIT::checkStructure):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::addSlowCase):
+ (JSC::JIT::addJump):
+ (JSC::JIT::emitJumpSlowToHot):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2008-12-12 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix the failures of the following layout tests, which regressed in
+ r39255:
+
+ fast/dom/StyleSheet/ownerNode-lifetime-2.html
+ fast/xsl/transform-xhr-doc.xhtml
+
+ The binary search in CodeBlock::getByIdExceptionInfoForBytecodeOffset()
+ doesn't guarantee that it actually finds a match, so add an explicit check
+ for this.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
+
+2008-12-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Replace emitPutCallArg methods with emitPutJITStubArg methods. Primarily to make the argument numbering
+ more sensible (1-based incrementing by 1, rather than 0-based incrementing by 4). The CTI name also seems
+ to be being deprecated from the code generally.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCallEvalSetupArgs):
+ (JSC::JIT::compileOpConstructSetupArgs):
+ (JSC::JIT::compileOpCall):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitPutJITStubArg):
+ (JSC::JIT::emitPutJITStubArgConstant):
+ (JSC::JIT::emitGetJITStubArg):
+ (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+
+2008-12-12 Gavin Barraclough <barraclough@apple.com>
+
+ Fix windows builds.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+
+2008-12-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove loop counter 'i' from the JIT generation passes, replace with a member m_bytecodeIndex.
+
+ No impact on performance.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JmpTable::JmpTable):
+ (JSC::JIT::emitCTICall):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::emitGetVirtualRegisters):
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::emitCTICall_internal):
+ (JSC::JIT::emitJumpSlowCaseIfJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
+ (JSC::JIT::emitFastArithIntToImmOrSlowCase):
+ (JSC::JIT::addSlowCase):
+ (JSC::JIT::addJump):
+ (JSC::JIT::emitJumpSlowToHot):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compilePutByIdSlowCase):
+
+2008-12-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ <rdar://problem/6428342> Look into feasibility of discarding bytecode after native codegen
+
+ Move more JIT functionality to using offsets into the Instruction buffer
+ instead of raw pointers. Two to go!
+
+ * interpreter/Interpreter.cpp:
+ (JSC::bytecodeOffsetForPC): Rename from vPCForPC.
+ (JSC::Interpreter::resolve): Pass offset to exception helper.
+ (JSC::Interpreter::resolveSkip): Ditto.
+ (JSC::Interpreter::resolveGlobal): Ditto.
+ (JSC::Interpreter::resolveBaseAndProperty): Ditto.
+ (JSC::Interpreter::resolveBaseAndFunc): Ditto.
+ (JSC::isNotObject): Ditto.
+ (JSC::Interpreter::unwindCallFrame): Call bytecodeOffsetForPC.
+ (JSC::Interpreter::throwException): Use offsets instead of vPCs.
+ (JSC::Interpreter::privateExecute): Pass offset to exception helper.
+ (JSC::Interpreter::retrieveLastCaller): Ditto.
+ (JSC::Interpreter::cti_op_instanceof): Ditto.
+ (JSC::Interpreter::cti_op_call_NotJSFunction): Ditto.
+ (JSC::Interpreter::cti_op_resolve): Pass offset to exception helper.
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct): Ditto.
+ (JSC::Interpreter::cti_op_resolve_func): Ditto.
+ (JSC::Interpreter::cti_op_resolve_skip): Ditto.
+ (JSC::Interpreter::cti_op_resolve_global): Ditto.
+ (JSC::Interpreter::cti_op_resolve_with_base): Ditto.
+ (JSC::Interpreter::cti_op_throw): Ditto.
+ (JSC::Interpreter::cti_op_in): Ditto.
+ (JSC::Interpreter::cti_vm_throw): Ditto.
+ * interpreter/Interpreter.h:
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass): Don't pass unnecessary vPC to stub.
+ * jit/JIT.h: Remove ARG_instr1 - ARG_instr3 and ARG_instr5 - ARG_instr6.
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallEvalSetupArgs): Don't pass unnecessary vPC to stub..
+ (JSC::JIT::compileOpConstructSetupArgs): Ditto.
+
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createUndefinedVariableError): Take an offset instead of vPC.
+ (JSC::createInvalidParamError): Ditto.
+ (JSC::createNotAConstructorError): Ditto.
+ (JSC::createNotAFunctionError): Ditto.
+ (JSC::createNotAnObjectError): Ditto.
+ * runtime/ExceptionHelpers.h:
+
+2008-12-12 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 22835: Crash during bytecode generation when comparing to null
+ <https://bugs.webkit.org/show_bug.cgi?id=22835>
+ <rdar://problem/6286749>
+
+ Change the special cases in bytecode generation for comparison to null
+ to use tempDestination().
+
+ * parser/Nodes.cpp:
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::EqualNode::emitBytecode):
+
+2008-12-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Move slow-cases of JIT code generation over to the MacroAssembler interface.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::Label::Label):
+ (JSC::MacroAssembler::jae32):
+ (JSC::MacroAssembler::jg32):
+ (JSC::MacroAssembler::jzPtr):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::emitGetVariableObjectRegister):
+ (JSC::JIT::emitPutVariableObjectRegister):
+ * jit/JIT.h:
+ (JSC::SlowCaseEntry::SlowCaseEntry):
+ (JSC::JIT::getSlowCase):
+ (JSC::JIT::linkSlowCase):
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+ (JSC::JIT::linkSlowCaseIfNotJSCell):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+
+2008-12-12 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 22828: Do not inspect bytecode instruction stream for op_get_by_id exception information
+ <https://bugs.webkit.org/show_bug.cgi?id=22828>
+
+ In order to remove the bytecode instruction stream after generating
+ native code, all inspection of bytecode instructions at runtime must
+ be removed. One particular instance of this is the special handling of
+ exceptions thrown by the op_get_by_id emitted directly before an
+ op_construct or an op_instanceof. This patch moves that information to
+ an auxiliary data structure in CodeBlock.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::addGetByIdExceptionInfo):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitConstruct):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
+ * parser/Nodes.cpp:
+ (JSC::InstanceOfNode::emitBytecode):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createNotAnObjectError):
+
+2008-12-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Change exception information accessors to take offsets into the bytecode
+ instruction buffer instead of pointers so that they can work even even
+ if the bytecode buffer is purged.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::instructionOffsetForNth):
+ (JSC::CodeBlock::handlerForBytecodeOffset):
+ (JSC::CodeBlock::lineNumberForBytecodeOffset):
+ (JSC::CodeBlock::expressionRangeForBytecodeOffset):
+ * bytecode/CodeBlock.h:
+ * bytecode/SamplingTool.cpp:
+ (JSC::SamplingTool::dump):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveLastCaller):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * runtime/ExceptionHelpers.cpp:
+ (JSC::createUndefinedVariableError):
+ (JSC::createInvalidParamError):
+ (JSC::createNotAConstructorError):
+ (JSC::createNotAFunctionError):
+ (JSC::createNotAnObjectError):
+
+2008-12-12 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Tiny bit of refactoring in quantifier generation.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+
+2008-12-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove dependancy on having the Instruction buffer in order to
+ deref Structures used for property access and global resolves.
+ Instead, we put references to the necessary Structures in auxiliary
+ data structures on the CodeBlock. This is not an ideal solution,
+ as we still pay for having the Structures in two places and we
+ would like to eventually just hold on to offsets into the machine
+ code buffer.
+
+ - Also removes CodeBlock bloat in non-JIT by #ifdefing the JIT
+ only data structures.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * bytecode/CodeBlock.cpp:
+ (JSC::isGlobalResolve):
+ (JSC::isPropertyAccess):
+ (JSC::instructionOffsetForNth):
+ (JSC::printGlobalResolveInfo):
+ (JSC::printStructureStubInfo):
+ (JSC::CodeBlock::printStructures):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::shrinkToFit):
+ * bytecode/CodeBlock.h:
+ (JSC::GlobalResolveInfo::GlobalResolveInfo):
+ (JSC::getNativePC):
+ (JSC::CodeBlock::instructions):
+ (JSC::CodeBlock::getStubInfo):
+ (JSC::CodeBlock::getBytecodeIndex):
+ (JSC::CodeBlock::addPropertyAccessInstruction):
+ (JSC::CodeBlock::addGlobalResolveInstruction):
+ (JSC::CodeBlock::numberOfStructureStubInfos):
+ (JSC::CodeBlock::addStructureStubInfo):
+ (JSC::CodeBlock::structureStubInfo):
+ (JSC::CodeBlock::addGlobalResolveInfo):
+ (JSC::CodeBlock::globalResolveInfo):
+ (JSC::CodeBlock::numberOfCallLinkInfos):
+ (JSC::CodeBlock::addCallLinkInfo):
+ (JSC::CodeBlock::callLinkInfo):
+ * bytecode/Instruction.h:
+ (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
+ (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
+ * bytecode/Opcode.h:
+ (JSC::):
+ * bytecode/StructureStubInfo.cpp: Copied from bytecode/CodeBlock.cpp.
+ (JSC::StructureStubInfo::deref):
+ * bytecode/StructureStubInfo.h: Copied from bytecode/CodeBlock.h.
+ (JSC::StructureStubInfo::StructureStubInfo):
+ (JSC::StructureStubInfo::initGetByIdSelf):
+ (JSC::StructureStubInfo::initGetByIdProto):
+ (JSC::StructureStubInfo::initGetByIdChain):
+ (JSC::StructureStubInfo::initGetByIdSelfList):
+ (JSC::StructureStubInfo::initGetByIdProtoList):
+ (JSC::StructureStubInfo::initPutByIdTransition):
+ (JSC::StructureStubInfo::initPutByIdReplace):
+ (JSC::StructureStubInfo::):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitResolve):
+ (JSC::BytecodeGenerator::emitGetById):
+ (JSC::BytecodeGenerator::emitPutById):
+ (JSC::BytecodeGenerator::emitCall):
+ (JSC::BytecodeGenerator::emitConstruct):
+ (JSC::BytecodeGenerator::emitCatch):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::getPolymorphicAccessStructureListSlot):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_resolve_global):
+ * jit/JIT.cpp:
+ (JSC::JIT::JIT):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+
+2008-12-11 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove CTI_ARGUMENTS mode, use va_start implementation on Windows,
+ unifying JIT callback (cti_*) argument access on OS X & Windows
+
+ No performance impact.
+
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitCTICall):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ * wtf/Platform.h:
+
+2008-12-11 Holger Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20953
+
+ For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
+ implementation. This is one of the reasons why the Qt port is currently not
+ using WebCore/platform/graphics/Font.cpp. By allowing to not use
+ the simple/fast-path the Qt port will be able to use it.
+
+ Introduce USE(FONT_FAST_PATH) and define it for every port but the
+ Qt one.
+
+ * wtf/Platform.h: Enable USE(FONT_FAST_PATH)
+
+2008-12-11 Gabor Loki <loki@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler and landed by Holger Freyther.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22648>
+ Fix threading on Qt-port and Gtk-port for Sampling tool.
+
+ * wtf/ThreadingGtk.cpp:
+ (WTF::waitForThreadCompletion):
+ * wtf/ThreadingQt.cpp:
+ (WTF::waitForThreadCompletion):
+
+2008-12-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 22734: Debugger crashes when stepping into a function call in a return statement
+ <https://bugs.webkit.org/show_bug.cgi?id=22734>
+ <rdar://problem/6426796>
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator): The DebuggerCallFrame uses
+ the 'this' value stored in a callFrame, so op_convert_this should be
+ emitted at the beginning of a function body when generating bytecode
+ with debug hooks.
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::thisObject): The assertion inherent in the call
+ to asObject() here is valid, because any 'this' value should have been
+ converted to a JSObject*.
+
+2008-12-10 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Port more of the JIT to use the MacroAssembler interface.
+
+ Everything in the main pass, bar a few corner cases (operations with required
+ registers, or calling convention code). Slightly refactors array creation,
+ moving the offset calculation into the callFrame into C code (reducing code
+ planted).
+
+ Overall this appears to be a 1% win on v8-tests, due to the smaller immediates
+ being planted (in jfalse in particular).
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_new_array):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+
+2008-12-10 Sam Weinig <sam@webkit.org>
+
+ Fix non-JIT builds.
+
+ * bytecode/CodeBlock.h:
+
+2008-12-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ <rdar://problem/6428332> Remove the CTI return address table from CodeBlock
+
+ Step 2:
+
+ Convert the return address table from a HashMap to a sorted Vector. This
+ reduces the size of the data structure by ~4.5MB on Membuster head.
+
+ SunSpider reports a 0.5% progression.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::sizeInBytes): Generic method to get the cost of a Vector.
+ (JSC::CodeBlock::dumpStatistics): Add dumping of member sizes.
+ * bytecode/CodeBlock.h:
+ (JSC::PC::PC): Struct representing NativePC -> VirtualPC mappings.
+ (JSC::getNativePC): Helper for binary chop.
+ (JSC::CodeBlock::getBytecodeIndex): Used to get the VirtualPC from a
+ NativePC using a binary chop of the pcVector.
+ (JSC::CodeBlock::pcVector): Accessor.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::vPCForPC): Use getBytecodeIndex instead of jitReturnAddressVPCMap().get().
+ (JSC::Interpreter::cti_op_instanceof): Ditto.
+ (JSC::Interpreter::cti_op_resolve): Ditto.
+ (JSC::Interpreter::cti_op_resolve_func): Ditto.
+ (JSC::Interpreter::cti_op_resolve_skip): Ditto.
+ (JSC::Interpreter::cti_op_resolve_with_base): Ditto.
+ (JSC::Interpreter::cti_op_throw): Ditto.
+ (JSC::Interpreter::cti_op_in): Ditto.
+ (JSC::Interpreter::cti_vm_throw): Ditto.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile): Reserve exact capacity and fill the pcVector.
+
+2008-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Added WREC support for an assertion followed by a quantifier. Fixed
+ PCRE to match.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since
+ it's meaningless. (Firefox does the same.)
+
+ * pcre/pcre_compile.cpp:
+ (compileBranch): ditto.
+
+2008-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ In preparation for compiling WREC without PCRE:
+
+ Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
+ match in cases where it didn't already.
+
+ Changed JavaScriptCore to report syntax errors detected by WREC, rather
+ than falling back on PCRE any time WREC sees an error.
+
+ * pcre/pcre_compile.cpp:
+ (checkEscape): Relaxed parsing of \c and \N escapes to be more
+ web-compatible.
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported
+ a syntax error.
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp): Fixed some error reporting to
+ match PCRE.
+
+ * wrec/WRECParser.cpp: Added error messages that match PCRE.
+
+ (JSC::WREC::Parser::consumeGreedyQuantifier):
+ (JSC::WREC::Parser::parseParentheses):
+ (JSC::WREC::Parser::parseCharacterClass):
+ (JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
+ use the new setError API.
+
+ (JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
+ to be more web-compatible.
+
+ (JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
+ quantifier and a quantifier with no prefix, like PCRE does.
+
+ (JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.
+
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::error):
+ (JSC::WREC::Parser::syntaxError):
+ (JSC::WREC::Parser::parsePattern):
+ (JSC::WREC::Parser::reset):
+ (JSC::WREC::Parser::setError): Store error messages instead of error codes,
+ to provide for exception messages. Use a setter for reporting errors, so
+ errors detected early are not overwritten by errors detected later.
+
+2008-12-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Use va_args to access cti function arguments.
+ https://bugs.webkit.org/show_bug.cgi?id=22774
+
+ This may be a minor regression, but we'll take the hit if so to reduce fragility.
+
+ * interpreter/Interpreter.cpp:
+ * interpreter/Interpreter.h:
+
+2008-12-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed twice by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22752
+ Clear SymbolTable after codegen for Function codeblocks that
+ don't require an activation
+
+ This is a ~1.5MB improvement on Membuster-head.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables
+ and total size used by symbol tables.
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate): Clear the symbol table here.
+
+2008-12-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove unnecessary extra lookup when throwing an exception.
+ We used to first lookup the target offset using getHandlerForVPC
+ and then we would lookup the native code stub using
+ nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
+ the HandlerInfo.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
+ * bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::throwException): Return a HandlerInfo instead of
+ and Instruction offset.
+ (JSC::Interpreter::privateExecute): Get the offset from HandlerInfo.
+ (JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo.
+ (JSC::Interpreter::cti_vm_throw): Ditto.
+ * interpreter/Interpreter.h:
+
+2008-12-09 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ Speculative fix for the Chromium-Windows bot.
+ Add JavaScriptCore/os-win32 to the include path (for stdint.h)
+ Strangely it builds fine on my local windows box (or at least doesn't hit this error)
+
+ * JavaScriptCore.scons:
+
+2008-12-09 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Add ExecutableAllocator files missing from Scons build.
+
+ * JavaScriptCore.scons:
+
+2008-12-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22631
+ Allow ScriptCallFrame query names of functions in the call stack.
+
+ * JavaScriptCore.exp: added InternalFunction::name and
+ UString operator==() as exported symbol
+
+2008-12-08 Judit Jasz <jasy@inf.u-szeged.hu>
+
+ Reviewed and tweaked by Cameron Zwarich.
+
+ Bug 22352: Annotate opcodes with their length
+ <https://bugs.webkit.org/show_bug.cgi?id=22352>
+
+ * bytecode/Opcode.cpp:
+ * bytecode/Opcode.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+
+2008-12-08 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Implemented more of the relaxed and somewhat weird rules for deciding
+ how to interpret a non-pattern-character.
+
+ * wrec/Escapes.h:
+ (JSC::WREC::Escape::):
+ (JSC::WREC::Escape::Escape): Eliminated Escape::None because it was
+ unused. If you see an '\\', it's either a valid escape or an error.
+
+ * wrec/Quantifier.h:
+ (JSC::WREC::Quantifier::Quantifier):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier): Renamed "noMaxSpecified"
+ to "Infinity", since that's what it means.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::consumeGreedyQuantifier): Re-wrote {n,m} parsing rules
+ because they were too strict before. Added support for backtracking
+ in the case where the {n,m} fails to parse as a quantifier, and yet is
+ not a syntax error.
+
+ (JSC::WREC::Parser::parseCharacterClass):
+ (JSC::WREC::Parser::parseNonCharacterEscape): Eliminated Escape::None,
+ as above.
+
+ (JSC::WREC::Parser::consumeEscape): Don't treat ASCII and _ escapes
+ as syntax errors. See fast/regex/non-pattern-characters.html.
+
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::SavedState::SavedState):
+ (JSC::WREC::Parser::SavedState::restore): Added a state backtracker,
+ since parsing {n,m} forms requires backtracking if the form turns out
+ not to be a quantifier.
+
+2008-12-08 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Refactored WREC parsing so that only one piece of code needs to know
+ the relaxed and somewhat weird rules for deciding how to interpret a
+ non-pattern-character, in preparation for implementing those rules.
+
+ Also, implemented the relaxed and somewhat weird rules for '}' and ']'.
+
+ * wrec/WREC.cpp: Reduced the regular expression size limit. Now that
+ WREC handles ']' properly, it compiles fast/js/regexp-charclass-crash.html,
+ which makes it hang at the old limit. (The old limit was based on the
+ misimpression that the same value in PCRE limited the regular expression
+ pattern size; in reality, it limited the expected compiled regular
+ expression size. WREC doesn't have a way to calculate an expected
+ compiled regular expression size, but this should be good enough.)
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::parsePatternCharacterSequence): Nixed this function because
+ it contained a second copy of the logic for handling non-pattern-characters,
+ which is about to get a lot more complicated.
+
+ (JSC::WREC::PatternCharacterSequence::PatternCharacterSequence):
+ (JSC::WREC::PatternCharacterSequence::size):
+ (JSC::WREC::PatternCharacterSequence::append):
+ (JSC::WREC::PatternCharacterSequence::flush): Helper object for generating
+ an optimized sequence of pattern characters.
+
+ (JSC::WREC::Parser::parseNonCharacterEscape): Renamed to reflect the fact
+ that the main parseAlternative loop handles character escapes.
+
+ (JSC::WREC::Parser::parseAlternative): Moved pattern character sequence
+ logic from parsePatternCharacterSequence to here, using
+ PatternCharacterSequence to help with the details.
+
+ * wrec/WRECParser.h: Updated for renames.
+
+2008-12-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ <rdar://problem/6166088> Give JSGlobalContextCreate a behavior that is concurrency aware,
+ and un-deprecate it
+
+ * API/JSContextRef.cpp: (JSGlobalContextCreate):
+ * API/JSContextRef.h:
+ Use a unique context group for the context, unless the application was linked against old
+ JavaScriptCore.
+
+2008-12-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for <rdar://problem/6428332> Remove the CTI return address table from CodeBlock
+
+ Step 1:
+
+ Remove use of jitReturnAddressVPCMap when looking for vPC to store Structures
+ in for cached lookup. Instead, use the offset in the StructureStubInfo that is
+ already required.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpStatistics): Fix extraneous semicolon.
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdSelf):
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdReplace):
+ (JSC::JIT::compilePutByIdTransition):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength): Remove extra call to getStubInfo.
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+
+2008-12-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Port the op_j?n?eq_null JIT code generation to use the MacroAssembler,
+ and clean up slightly at the same time. The 'j' forms currently compare,
+ then set a register, then compare again, then branch. Branch directly on
+ the result of the first compare.
+
+ Around a 1% progression on deltablue, crypto & early boyer, for about 1/2%
+ overall on v8-tests.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdSlowCase):
+
+2008-12-08 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Expand MacroAssembler to support more operations, required by the JIT.
+
+ Generally adds more operations and permutations of operands to the existing
+ interface. Rename 'jset' to 'jnz' and 'jnset' to 'jz', which seem clearer,
+ and require that immediate pointer operands (though not pointer addresses to
+ load and store instructions) are wrapped in a ImmPtr() type, akin to Imm32().
+
+ No performance impact.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::):
+ (JSC::MacroAssembler::ImmPtr::ImmPtr):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::and32):
+ (JSC::MacroAssembler::or32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::xor32):
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::load32):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::store32):
+ (JSC::MacroAssembler::poke):
+ (JSC::MacroAssembler::move):
+ (JSC::MacroAssembler::testImm32):
+ (JSC::MacroAssembler::jae32):
+ (JSC::MacroAssembler::jb32):
+ (JSC::MacroAssembler::jePtr):
+ (JSC::MacroAssembler::je32):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jne32):
+ (JSC::MacroAssembler::jnzPtr):
+ (JSC::MacroAssembler::jnz32):
+ (JSC::MacroAssembler::jzPtr):
+ (JSC::MacroAssembler::jz32):
+ (JSC::MacroAssembler::joSub32):
+ (JSC::MacroAssembler::jump):
+ (JSC::MacroAssembler::sete32):
+ (JSC::MacroAssembler::setne32):
+ (JSC::MacroAssembler::setnz32):
+ (JSC::MacroAssembler::setz32):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::addl_mr):
+ (JSC::X86Assembler::andl_i8r):
+ (JSC::X86Assembler::cmpl_rm):
+ (JSC::X86Assembler::cmpl_mr):
+ (JSC::X86Assembler::cmpl_i8m):
+ (JSC::X86Assembler::subl_mr):
+ (JSC::X86Assembler::testl_i32m):
+ (JSC::X86Assembler::xorl_i32r):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::modRm_opmsib):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::emitPutCTIArgConstant):
+ (JSC::JIT::emitPutCTIParam):
+ (JSC::JIT::emitPutImmediateToCallFrameHeader):
+ (JSC::JIT::emitInitRegister):
+ (JSC::JIT::checkStructure):
+ (JSC::JIT::emitJumpIfJSCell):
+ (JSC::JIT::emitJumpIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+
+2008-12-08 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed a bug where WREC would allow a quantifier whose minimum was
+ greater than its maximum.
+
+ * wrec/Quantifier.h:
+ (JSC::WREC::Quantifier::Quantifier): ASSERT that the quantifier is not
+ backwards.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::consumeGreedyQuantifier): Verify that the minimum
+ is not greater than the maximum.
+
+2008-12-08 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ * JavaScriptCore.scons: add bytecode/JumpTable.cpp
+
+2008-12-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=22716
+ <rdar://problem/6428315>
+ Add RareData structure to CodeBlock for infrequently used auxiliary data
+ members.
+
+ Reduces memory on Membuster-head by ~.5MB
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::dumpStatistics):
+ (JSC::CodeBlock::mark):
+ (JSC::CodeBlock::getHandlerForVPC):
+ (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC):
+ (JSC::CodeBlock::shrinkToFit):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::numberOfExceptionHandlers):
+ (JSC::CodeBlock::addExceptionHandler):
+ (JSC::CodeBlock::exceptionHandler):
+ (JSC::CodeBlock::addFunction):
+ (JSC::CodeBlock::function):
+ (JSC::CodeBlock::addUnexpectedConstant):
+ (JSC::CodeBlock::unexpectedConstant):
+ (JSC::CodeBlock::addRegExp):
+ (JSC::CodeBlock::regexp):
+ (JSC::CodeBlock::numberOfImmediateSwitchJumpTables):
+ (JSC::CodeBlock::addImmediateSwitchJumpTable):
+ (JSC::CodeBlock::immediateSwitchJumpTable):
+ (JSC::CodeBlock::numberOfCharacterSwitchJumpTables):
+ (JSC::CodeBlock::addCharacterSwitchJumpTable):
+ (JSC::CodeBlock::characterSwitchJumpTable):
+ (JSC::CodeBlock::numberOfStringSwitchJumpTables):
+ (JSC::CodeBlock::addStringSwitchJumpTable):
+ (JSC::CodeBlock::stringSwitchJumpTable):
+ (JSC::CodeBlock::evalCodeCache):
+ (JSC::CodeBlock::createRareDataIfNecessary):
+
+2008-11-26 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16814
+ Allow ports to disable ActiveX->NPAPI conversion for Media Player.
+ Improve handling of miscellaneous ActiveX objects.
+
+ * wtf/Platform.h: Add another ENABLE(...).
+
+2008-12-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Add dumping of CodeBlock member structure usage.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpStatistics):
+ * bytecode/EvalCodeCache.h:
+ (JSC::EvalCodeCache::isEmpty):
+
+2008-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22555: Sort "children" sections in Xcode project files
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22555>
+
+ Reviewed by Eric Seidel.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Sorted.
+
+2008-12-08 Tony Chang <tony@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Enable Pan scrolling only when building on PLATFORM(WIN_OS)
+ Previously platforms like Apple Windows WebKit, Cairo Windows WebKit,
+ Wx and Chromium were enabling it explicitly, now we just turn it on
+ for all WIN_OS, later platforms can turn it off as needed on Windows
+ (or turn it on under Linux, etc.)
+ https://bugs.webkit.org/show_bug.cgi?id=22698
+
+ * wtf/Platform.h:
+
+2008-12-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Add basic memory statistics dumping for CodeBlock.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpStatistics):
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::CodeBlock::~CodeBlock):
+ * bytecode/CodeBlock.h:
+
+2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Linux build with newer gcc/glibc.
+
+ * jit/ExecutableAllocatorPosix.cpp: Include unistd.h for
+ getpagesize(), according to
+ http://opengroup.org/onlinepubs/007908775/xsh/getpagesize.html
+
+2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the build with Qt on Windows.
+
+ * JavaScriptCore.pri: Compile ExecutableAllocatorWin.cpp on Windows.
+
+2008-12-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Buildfix).
+
+ Fix non-WREC builds
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+
+2008-12-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Put ENABLE(ASSEMBLER) guards around use of ExecutableAllocator in global data
+
+ Correct Qt and Gtk project files
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * runtime/JSGlobalData.h:
+
+2008-12-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Add new files to other projects.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.pro:
+
+2008-12-07 Oliver Hunt <oliver@apple.com>
+
+ Rubber stamped by Mark Rowe.
+
+ Rename ExecutableAllocatorMMAP to the more sensible ExecutableAllocatorPosix
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jit/ExecutableAllocator.h:
+ * jit/ExecutableAllocatorPosix.cpp: Renamed from JavaScriptCore/jit/ExecutableAllocatorMMAP.cpp.
+ (JSC::ExecutableAllocator::intializePageSize):
+ (JSC::ExecutablePool::systemAlloc):
+ (JSC::ExecutablePool::systemRelease):
+
+2008-12-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich and Sam Weinig
+
+ <rdar://problem/6309878> Need more granular control over allocation of executable memory (21783)
+ <https://bugs.webkit.org/show_bug.cgi?id=21783>
+
+ Add a new allocator for use by the JIT that provides executable pages, so
+ we can get rid of the current hack that makes the entire heap executable.
+
+ 1-2% progression on SunSpider-v8, 1% on SunSpider. Reduces memory usage as well!
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/AssemblerBuffer.h:
+ (JSC::AssemblerBuffer::size):
+ (JSC::AssemblerBuffer::executableCopy):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::size):
+ (JSC::MacroAssembler::copyCode):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::size):
+ (JSC::X86Assembler::executableCopy):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::~CodeBlock):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::executablePool):
+ (JSC::CodeBlock::setExecutablePool):
+ * bytecode/Instruction.h:
+ (JSC::PolymorphicAccessStructureList::derefStructures):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::~Interpreter):
+ * interpreter/Interpreter.h:
+ * jit/ExecutableAllocator.cpp: Added.
+ * jit/ExecutableAllocator.h: Added.
+ (JSC::ExecutablePool::create):
+ (JSC::ExecutablePool::alloc):
+ (JSC::ExecutablePool::~ExecutablePool):
+ (JSC::ExecutablePool::available):
+ (JSC::ExecutablePool::ExecutablePool):
+ (JSC::ExecutablePool::poolAllocate):
+ (JSC::ExecutableAllocator::ExecutableAllocator):
+ (JSC::ExecutableAllocator::poolForSize):
+ (JSC::ExecutablePool::sizeForAllocation):
+ * jit/ExecutableAllocatorMMAP.cpp: Added.
+ (JSC::ExecutableAllocator::intializePageSize):
+ (JSC::ExecutablePool::systemAlloc):
+ (JSC::ExecutablePool::systemRelease):
+ * jit/ExecutableAllocatorWin.cpp: Added.
+ (JSC::ExecutableAllocator::intializePageSize):
+ (JSC::ExecutablePool::systemAlloc):
+ (JSC::ExecutablePool::systemRelease):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ (JSC::JIT::compileCTIMachineTrampolines):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ * parser/Nodes.cpp:
+ (JSC::RegExpNode::emitBytecode):
+ * runtime/JSGlobalData.h:
+ (JSC::JSGlobalData::poolForSize):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::create):
+ (JSC::RegExp::~RegExp):
+ * runtime/RegExp.h:
+ * runtime/RegExpConstructor.cpp:
+ (JSC::constructRegExp):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+ * wrec/WRECGenerator.h:
+ * wtf/FastMalloc.cpp:
+ * wtf/FastMalloc.h:
+ * wtf/TCSystemAlloc.cpp:
+ (TryMmap):
+ (TryVirtualAlloc):
+ (TryDevMem):
+ (TCMalloc_SystemRelease):
+
+2008-12-06 Sam Weinig <sam@webkit.org>
+
+ Fix the Gtk build.
+
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compilePutByIdHotPath):
+
+2008-12-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich,
+
+ Move CodeBlock constructor into the .cpp file.
+
+ Sunspider reports a .7% progression, but I can only assume this
+ is noise.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::CodeBlock):
+ * bytecode/CodeBlock.h:
+
+2008-12-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Split JumpTable code into its own file.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * bytecode/CodeBlock.cpp:
+ * bytecode/CodeBlock.h:
+ * bytecode/JumpTable.cpp: Copied from bytecode/CodeBlock.cpp.
+ * bytecode/JumpTable.h: Copied from bytecode/CodeBlock.h.
+
+2008-12-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22715
+ Encapsulate more CodeBlock members in preparation
+ of moving some of them to a rare data structure.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::locationForOffset):
+ (JSC::printConditionalJump):
+ (JSC::printGetByIdOp):
+ (JSC::printPutByIdOp):
+ (JSC::CodeBlock::printStructure):
+ (JSC::CodeBlock::printStructures):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::unlinkCallers):
+ (JSC::CodeBlock::derefStructures):
+ (JSC::CodeBlock::refStructures):
+ (JSC::CodeBlock::mark):
+ (JSC::CodeBlock::getHandlerForVPC):
+ (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC):
+ (JSC::CodeBlock::lineNumberForVPC):
+ (JSC::CodeBlock::expressionRangeForVPC):
+ (JSC::CodeBlock::shrinkToFit):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::CodeBlock::addCaller):
+ (JSC::CodeBlock::removeCaller):
+ (JSC::CodeBlock::isKnownNotImmediate):
+ (JSC::CodeBlock::isConstantRegisterIndex):
+ (JSC::CodeBlock::getConstant):
+ (JSC::CodeBlock::isTemporaryRegisterIndex):
+ (JSC::CodeBlock::getStubInfo):
+ (JSC::CodeBlock::getCallLinkInfo):
+ (JSC::CodeBlock::instructions):
+ (JSC::CodeBlock::setJITCode):
+ (JSC::CodeBlock::jitCode):
+ (JSC::CodeBlock::ownerNode):
+ (JSC::CodeBlock::setGlobalData):
+ (JSC::CodeBlock::setThisRegister):
+ (JSC::CodeBlock::thisRegister):
+ (JSC::CodeBlock::setNeedsFullScopeChain):
+ (JSC::CodeBlock::needsFullScopeChain):
+ (JSC::CodeBlock::setUsesEval):
+ (JSC::CodeBlock::usesEval):
+ (JSC::CodeBlock::setUsesArguments):
+ (JSC::CodeBlock::usesArguments):
+ (JSC::CodeBlock::codeType):
+ (JSC::CodeBlock::source):
+ (JSC::CodeBlock::sourceOffset):
+ (JSC::CodeBlock::addGlobalResolveInstruction):
+ (JSC::CodeBlock::numberOfPropertyAccessInstructions):
+ (JSC::CodeBlock::addPropertyAccessInstruction):
+ (JSC::CodeBlock::propertyAccessInstruction):
+ (JSC::CodeBlock::numberOfCallLinkInfos):
+ (JSC::CodeBlock::addCallLinkInfo):
+ (JSC::CodeBlock::callLinkInfo):
+ (JSC::CodeBlock::numberOfJumpTargets):
+ (JSC::CodeBlock::addJumpTarget):
+ (JSC::CodeBlock::jumpTarget):
+ (JSC::CodeBlock::lastJumpTarget):
+ (JSC::CodeBlock::numberOfExceptionHandlers):
+ (JSC::CodeBlock::addExceptionHandler):
+ (JSC::CodeBlock::exceptionHandler):
+ (JSC::CodeBlock::addExpressionInfo):
+ (JSC::CodeBlock::numberOfLineInfos):
+ (JSC::CodeBlock::addLineInfo):
+ (JSC::CodeBlock::lastLineInfo):
+ (JSC::CodeBlock::jitReturnAddressVPCMap):
+ (JSC::CodeBlock::numberOfIdentifiers):
+ (JSC::CodeBlock::addIdentifier):
+ (JSC::CodeBlock::identifier):
+ (JSC::CodeBlock::numberOfConstantRegisters):
+ (JSC::CodeBlock::addConstantRegister):
+ (JSC::CodeBlock::constantRegister):
+ (JSC::CodeBlock::addFunction):
+ (JSC::CodeBlock::function):
+ (JSC::CodeBlock::addFunctionExpression):
+ (JSC::CodeBlock::functionExpression):
+ (JSC::CodeBlock::addUnexpectedConstant):
+ (JSC::CodeBlock::unexpectedConstant):
+ (JSC::CodeBlock::addRegExp):
+ (JSC::CodeBlock::regexp):
+ (JSC::CodeBlock::symbolTable):
+ (JSC::CodeBlock::evalCodeCache):
+ New inline setters/getters.
+
+ (JSC::ProgramCodeBlock::ProgramCodeBlock):
+ (JSC::ProgramCodeBlock::~ProgramCodeBlock):
+ (JSC::ProgramCodeBlock::clearGlobalObject):
+ * bytecode/SamplingTool.cpp:
+ (JSC::ScopeSampleRecord::sample):
+ (JSC::SamplingTool::dump):
+ * bytecompiler/BytecodeGenerator.cpp:
+ * bytecompiler/BytecodeGenerator.h:
+ * bytecompiler/Label.h:
+ * interpreter/CallFrame.cpp:
+ * interpreter/Interpreter.cpp:
+ * jit/JIT.cpp:
+ * jit/JITCall.cpp:
+ * jit/JITInlineMethods.h:
+ * jit/JITPropertyAccess.cpp:
+ * parser/Nodes.cpp:
+ * runtime/Arguments.h:
+ * runtime/ExceptionHelpers.cpp:
+ * runtime/JSActivation.cpp:
+ * runtime/JSActivation.h:
+ * runtime/JSGlobalObject.cpp:
+ Change direct access to use new getter/setters.
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Prevent GCC4.2 from hanging when trying to compile Interpreter.cpp.
+ Added "-fno-var-tracking" compiler flag.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22704
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
+
+ je, jg etc take an immediate operand as the second argument, but for the
+ equality branches (je, jne) the immediate operand was the first argument. This
+ was unnecessarily inconsistent. Change je, jne methods to take the immediate
+ as the second argument.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22703
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::je32):
+ (JSC::MacroAssembler::jne32):
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacterPair):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Second tranche of porting JIT.cpp to MacroAssembler interface.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::mul32):
+ (JSC::MacroAssembler::jl32):
+ (JSC::MacroAssembler::jnzSub32):
+ (JSC::MacroAssembler::joAdd32):
+ (JSC::MacroAssembler::joMul32):
+ (JSC::MacroAssembler::jzSub32):
+ * jit/JIT.cpp:
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+
+2008-12-05 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22609: Provide a build-time choice when generating hash tables for properties of built-in DOM objects
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22609>
+ <rdar://problem/6331749>
+
+ Reviewed by Darin Adler.
+
+ Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
+
+ Added back the code that generates a "compact" hash (instead of a
+ perfect hash) as a build-time option using the
+ ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
+
+ * create_hash_table: Rename variables to differentiate perfect hash
+ values from compact hash values. Added back code to compute compact
+ hash tables. Generate both hash table sizes and emit
+ conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
+ * runtime/Lookup.cpp:
+ (JSC::HashTable::createTable): Added version of createTable() for
+ use with compact hash tables.
+ (JSC::HashTable::deleteTable): Updated to work with compact hash
+ tables.
+ * runtime/Lookup.h: Defined ENABLE(PERFECT_HASH_SIZE) macro here.
+ (JSC::HashEntry::initialize): Set m_next to zero when using compact
+ hash tables.
+ (JSC::HashEntry::setNext): Added for compact hash tables.
+ (JSC::HashEntry::next): Added for compact hash tables.
+ (JSC::HashTable::entry): Added version of entry() for use with
+ compact hash tables.
+ * runtime/Structure.cpp:
+ (JSC::Structure::getEnumerablePropertyNames): Updated to work with
+ compact hash tables.
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove redundant calls to JIT::emitSlowScriptCheck.
+ This is checked in the hot path, so is not needed on the slow path - and the code
+ was being planted before the start of the slow case, so was completely unreachable!
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileSlowCases):
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Move JIT::compileOpStrictEq to MacroAssembler interface.
+
+ The rewrite also looks like a small (<1%) performance progression.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22697
+
+ * jit/JIT.cpp:
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitJumpIfJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfJSCell):
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove m_assembler from MacroAssembler::Jump.
+ Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer
+ than "link(this)". But maintaining this doubles the size of Jump, which
+ is even more unfortunate for the JIT, since there are many large structures
+ holding JmpSrcs. Probably best to remove it.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22693
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::Jump::Jump):
+ (JSC::MacroAssembler::Jump::link):
+ (JSC::MacroAssembler::Jump::linkTo):
+ (JSC::MacroAssembler::JumpList::link):
+ (JSC::MacroAssembler::JumpList::linkTo):
+ (JSC::MacroAssembler::jae32):
+ (JSC::MacroAssembler::je32):
+ (JSC::MacroAssembler::je16):
+ (JSC::MacroAssembler::jg32):
+ (JSC::MacroAssembler::jge32):
+ (JSC::MacroAssembler::jl32):
+ (JSC::MacroAssembler::jle32):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jne32):
+ (JSC::MacroAssembler::jnset32):
+ (JSC::MacroAssembler::jset32):
+ (JSC::MacroAssembler::jump):
+ (JSC::MacroAssembler::jzSub32):
+ (JSC::MacroAssembler::joAdd32):
+ (JSC::MacroAssembler::call):
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateBackreferenceQuantifier):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateParenthesesAssertion):
+ (JSC::WREC::Generator::generateParenthesesInvertedAssertion):
+ (JSC::WREC::Generator::generateParenthesesNonGreedy):
+ (JSC::WREC::Generator::generateParenthesesResetTrampoline):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::generateBackreference):
+ (JSC::WREC::Generator::terminateAlternative):
+ (JSC::WREC::Generator::terminateDisjunction):
+ * wrec/WRECParser.h:
+
+2008-12-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Simplify JIT generated checks for timeout code, by moving more work into the C function.
+ https://bugs.webkit.org/show_bug.cgi?id=22688
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_timeout_check):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::emitSlowScriptCheck):
+
+2008-12-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Encapsulate access to jump tables in the CodeBlock in preparation
+ of moving them to a rare data structure.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::shrinkToFit):
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::numberOfImmediateSwitchJumpTables):
+ (JSC::CodeBlock::addImmediateSwitchJumpTable):
+ (JSC::CodeBlock::immediateSwitchJumpTable):
+ (JSC::CodeBlock::numberOfCharacterSwitchJumpTables):
+ (JSC::CodeBlock::addCharacterSwitchJumpTable):
+ (JSC::CodeBlock::characterSwitchJumpTable):
+ (JSC::CodeBlock::numberOfStringSwitchJumpTables):
+ (JSC::CodeBlock::addStringSwitchJumpTable):
+ (JSC::CodeBlock::stringSwitchJumpTable):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate):
+ (JSC::BytecodeGenerator::endSwitch):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+
+2008-12-05 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r39020
+
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ Add some apparently-missing __.
+
+2008-12-04 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22673
+
+ Added support for the assertion (?=) and inverted assertion (?!) atoms
+ in WREC.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateParenthesesAssertion):
+ (JSC::WREC::Generator::generateParenthesesInvertedAssertion): Split the
+ old (unused) generateParentheses into these two functions, with more
+ limited capabilities.
+
+ * wrec/WRECGenerator.h:
+ (JSC::WREC::Generator::): Moved an enum to the top of the class definition,
+ to match the WebKit style, and removed a defunct comment.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parseParentheses):
+ (JSC::WREC::Parser::consumeParenthesesType):
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::): Added support for parsing (?=) and (?!).
+
+2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Tor Arne Vestbø.
+
+ Disable the JIT for the Qt build alltogether again, after observing
+ more miscompilations in a wider range of newer gcc versions.
+
+ * JavaScriptCore.pri:
+
+2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Disable the JIT for the Qt build on Linux unless gcc is >= 4.2,
+ due to miscompilations.
+
+ * JavaScriptCore.pri:
+
+2008-12-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Start porting the JIT to use the MacroAssembler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22671
+ No change in performance.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::Jump::operator X86Assembler::JmpSrc):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::and32):
+ (JSC::MacroAssembler::lshift32):
+ (JSC::MacroAssembler::rshift32):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::store32):
+ (JSC::MacroAssembler::poke):
+ (JSC::MacroAssembler::move):
+ (JSC::MacroAssembler::compareImm32ForBranchEquality):
+ (JSC::MacroAssembler::jnePtr):
+ (JSC::MacroAssembler::jnset32):
+ (JSC::MacroAssembler::jset32):
+ (JSC::MacroAssembler::jzeroSub32):
+ (JSC::MacroAssembler::joverAdd32):
+ (JSC::MacroAssembler::call):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::shll_i8r):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::compileBinaryArithOp):
+ * jit/JITInlineMethods.h:
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::emitPutCTIArg):
+ (JSC::JIT::emitPutCTIArgConstant):
+ (JSC::JIT::emitGetCTIArg):
+ (JSC::JIT::emitPutCTIArgFromVirtualRegister):
+ (JSC::JIT::emitPutCTIParam):
+ (JSC::JIT::emitGetCTIParam):
+ (JSC::JIT::emitPutToCallFrameHeader):
+ (JSC::JIT::emitPutImmediateToCallFrameHeader):
+ (JSC::JIT::emitGetFromCallFrameHeader):
+ (JSC::JIT::emitPutVirtualRegister):
+ (JSC::JIT::emitInitRegister):
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::restoreArgumentReference):
+ (JSC::JIT::restoreArgumentReferenceForTrampoline):
+ (JSC::JIT::emitCTICall):
+ (JSC::JIT::checkStructure):
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
+ (JSC::JIT::emitFastArithDeTagImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+ (JSC::JIT::emitFastArithImmToInt):
+ (JSC::JIT::emitFastArithIntToImmOrSlowCase):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+ (JSC::JIT::emitTagAsBoolImmediate):
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompilePutByIdTransition):
+
+2008-12-04 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Some refactoring for generateGreedyQuantifier.
+
+ SunSpider reports no change (possibly a 0.3% speedup).
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateGreedyQuantifier): Clarified label
+ meanings and unified some logic to simplify things.
+
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::parseAlternative): Added a version of parseAlternative
+ that can jump to a Label, instead of a JumpList, upon failure. (Eventually,
+ when we have a true Label class, this will be redundant.) This makes
+ things easier for generateGreedyQuantifier, because it can avoid
+ explicitly linking things.
+
+2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Fix crashes in the Qt build on Linux/i386 with non-executable memory
+ by enabling TCSystemAlloc and the PROT_EXEC flag for mmap.
+
+ * JavaScriptCore.pri: Enable the use of TCSystemAlloc if the JIT is
+ enabled.
+ * wtf/TCSystemAlloc.cpp: Extend the PROT_EXEC permissions to
+ PLATFORM(QT).
+
+2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Enable ENABLE_JIT_OPTIMIZE_CALL, ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
+ and ENABLE_JIT_OPTIMIZE_ARITHMETIC, as suggested by Niko.
+
+ * JavaScriptCore.pri:
+
+2008-12-04 Kent Hansen <khansen@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Enable the JSC jit for the Qt build by default for release builds on
+ linux-g++ and win32-msvc.
+
+ * JavaScriptCore.pri:
+
+2008-12-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Allow JIT to function without property access repatching and arithmetic optimizations.
+ Controlled by ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS and ENABLE_JIT_OPTIMIZE_ARITHMETIC switches.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22643
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITArithmetic.cpp: Copied from jit/JIT.cpp.
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ * jit/JITPropertyAccess.cpp: Copied from jit/JIT.cpp.
+ (JSC::JIT::compileGetByIdHotPath):
+ (JSC::JIT::compileGetByIdSlowCase):
+ (JSC::JIT::compilePutByIdHotPath):
+ (JSC::JIT::compilePutByIdSlowCase):
+ (JSC::resizePropertyStorage):
+ (JSC::transitionWillNeedStorageRealloc):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * wtf/Platform.h:
+
+2008-12-03 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Optimized sequences of characters in regular expressions by comparing
+ two characters at a time.
+
+ 1-2% speedup on SunSpider, 19-25% speedup on regexp-dna.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::load32):
+ (JSC::MacroAssembler::jge32): Filled out a few more macro methods.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::movl_mr): Added a verion of movl_mr that operates
+ without an offset, to allow the macro assembler to optmize for that case.
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp): Test the saved value of index
+ instead of the index register when checking for "end of input." The
+ index register doesn't increment by 1 in an orderly fashion, so testing
+ it for == "end of input" is not valid.
+
+ Also, jump all the way to "return failure" upon reaching "end of input,"
+ instead of executing the next alternative. This is more logical, and
+ it's a slight optimization in the case of an expression with many alternatives.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateIncrementIndex): Added support for
+ jumping to a failure label in the case where the index has reached "end
+ of input."
+
+ (JSC::WREC::Generator::generatePatternCharacterSequence):
+ (JSC::WREC::Generator::generatePatternCharacterPair): This is the
+ optmization. It's basically like generatePatternCharacter, but it runs two
+ characters at a time.
+
+ (JSC::WREC::Generator::generatePatternCharacter): Changed to use isASCII,
+ since it's clearer than comparing to a magic hex value.
+
+ * wrec/WRECGenerator.h:
+
+2008-12-03 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Allow JIT to operate without the call-repatching optimization.
+ Controlled by ENABLE(JIT_OPTIMIZE_CALL), defaults on, disabling
+ this leads to significant performance regression.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22639
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITCall.cpp: Copied from jit/JIT.cpp.
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCallEvalSetupArgs):
+ (JSC::JIT::compileOpConstructSetupArgs):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpCallSlowCase):
+ (JSC::unreachable):
+ * jit/JITInlineMethods.h: Copied from jit/JIT.cpp.
+ (JSC::JIT::checkStructure):
+ (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+ (JSC::JIT::emitTagAsBoolImmediate):
+ * wtf/Platform.h:
+
+2008-12-03 Eric Seidel <eric@webkit.org>
+
+ Rubber-stamped by David Hyatt.
+
+ Make HAVE_ACCESSIBILITY only define if !defined
+
+ * wtf/Platform.h:
+
+2008-12-03 Sam Weinig <sam@webkit.org>
+
+ Fix build.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::orl_i32r):
+
+2008-12-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
+ an 256 byte inline capacity.
+
+ 1% progression on Sunspider.
+
+ * assembler/AssemblerBuffer.h:
+ (JSC::AssemblerBuffer::AssemblerBuffer):
+ (JSC::AssemblerBuffer::~AssemblerBuffer):
+ (JSC::AssemblerBuffer::grow):
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::MacroAssembler):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::X86Assembler):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::JIT):
+ * parser/Nodes.cpp:
+ (JSC::RegExpNode::emitBytecode):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::create):
+ * runtime/RegExp.h:
+ * runtime/RegExpConstructor.cpp:
+ (JSC::constructRegExp):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+ * wrec/WRECGenerator.h:
+ (JSC::WREC::Generator::Generator):
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::Parser):
+
+2008-12-03 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt, with help from Gavin Barraclough.
+
+ orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
+ orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
+ a new orl_i32r that actually does a 32bit OR.
+
+ (32bit OR is currently unused, but a patch I'm working on uses it.)
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::orl_i8r): The old orl_i32r.
+ (JSC::X86Assembler::orl_i32r): The new orl_i32r.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+ (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit
+ values.
+
+2008-12-03 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Helper functions for turn -> degrees.
+ https://bugs.webkit.org/show_bug.cgi?id=22497
+
+ * wtf/MathExtras.h:
+ (turn2deg):
+ (deg2turn):
+
+2008-12-02 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 22504: Crashes during code generation occur due to refing of ignoredResult()
+ <https://bugs.webkit.org/show_bug.cgi?id=22504>
+
+ Since ignoredResult() was implemented by casting 1 to a RegisterID*, any
+ attempt to ref ignoredResult() results in a crash. This will occur in
+ code generation of a function body where a node emits another node with
+ the dst that was passed to it, and then refs the returned RegisterID*.
+
+ To fix this problem, make ignoredResult() a member function of
+ BytecodeGenerator that simply returns a pointe to a fixed RegisterID
+ member of BytecodeGenerator.
+
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::ignoredResult):
+ * bytecompiler/RegisterID.h:
+ * parser/Nodes.cpp:
+ (JSC::NullNode::emitBytecode):
+ (JSC::BooleanNode::emitBytecode):
+ (JSC::NumberNode::emitBytecode):
+ (JSC::StringNode::emitBytecode):
+ (JSC::RegExpNode::emitBytecode):
+ (JSC::ThisNode::emitBytecode):
+ (JSC::ResolveNode::emitBytecode):
+ (JSC::ObjectLiteralNode::emitBytecode):
+ (JSC::PostfixResolveNode::emitBytecode):
+ (JSC::PostfixBracketNode::emitBytecode):
+ (JSC::PostfixDotNode::emitBytecode):
+ (JSC::DeleteValueNode::emitBytecode):
+ (JSC::VoidNode::emitBytecode):
+ (JSC::TypeOfResolveNode::emitBytecode):
+ (JSC::TypeOfValueNode::emitBytecode):
+ (JSC::PrefixResolveNode::emitBytecode):
+ (JSC::AssignResolveNode::emitBytecode):
+ (JSC::CommaNode::emitBytecode):
+ (JSC::ForNode::emitBytecode):
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::ThrowNode::emitBytecode):
+ (JSC::FunctionBodyNode::emitBytecode):
+ (JSC::FuncDeclNode::emitBytecode):
+
+2008-12-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22537
+ REGRESSION (r38745): Assertion failure in jsSubstring() at ge.com
+
+ The bug was that index would become greater than length, so our
+ "end of input" checks, which all check "index == length", would fail.
+
+ The solution is to check for end of input before incrementing index,
+ to ensure that index is always <= length.
+
+ As a side benefit, generateJumpIfEndOfInput can now use je instead of
+ jg, which should be slightly faster.
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateJumpIfEndOfInput):
+
+2008-12-02 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Plant shift right immediate instructions, which are awesome.
+ https://bugs.webkit.org/show_bug.cgi?id=22610
+ ~5% on the v8-crypto test.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+
+2008-12-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Cleaned up SegmentedVector by abstracting segment access into helper
+ functions.
+
+ SunSpider reports no change.
+
+ * bytecompiler/SegmentedVector.h:
+ (JSC::SegmentedVector::SegmentedVector):
+ (JSC::SegmentedVector::~SegmentedVector):
+ (JSC::SegmentedVector::size):
+ (JSC::SegmentedVector::at):
+ (JSC::SegmentedVector::operator[]):
+ (JSC::SegmentedVector::last):
+ (JSC::SegmentedVector::append):
+ (JSC::SegmentedVector::removeLast):
+ (JSC::SegmentedVector::grow):
+ (JSC::SegmentedVector::clear):
+ (JSC::SegmentedVector::deleteAllSegments):
+ (JSC::SegmentedVector::segmentFor):
+ (JSC::SegmentedVector::subscriptFor):
+ (JSC::SegmentedVector::ensureSegmentsFor):
+ (JSC::SegmentedVector::ensureSegment):
+
+2008-12-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <zwarich@apple.com>.)
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22482
+ REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
+ message when running the V8 Raytrace benchmark
+
+ Rolled out r37991. It didn't properly save xmm0, which is caller-save,
+ before calling helper functions.
+
+ SunSpider and v8 benchmarks show little change -- possibly a .2%
+ SunSpider regression, possibly a .2% v8 benchmark speedup.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * bytecode/Instruction.h:
+ (JSC::Instruction::):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitUnaryOp):
+ * bytecompiler/BytecodeGenerator.h:
+ (JSC::BytecodeGenerator::emitToJSNumber):
+ (JSC::BytecodeGenerator::emitTypeOf):
+ (JSC::BytecodeGenerator::emitGetPropertyNames):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * parser/Nodes.cpp:
+ (JSC::UnaryOpNode::emitBytecode):
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::EqualNode::emitBytecode):
+ * parser/ResultType.h:
+ (JSC::ResultType::isReusable):
+ (JSC::ResultType::mightBeNumber):
+ * runtime/JSNumberCell.h:
+
+2008-12-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove unused (sampling only, and derivable) argument to JIT::emitCTICall.
+ https://bugs.webkit.org/show_bug.cgi?id=22587
+
+ * jit/JIT.cpp:
+ (JSC::JIT::emitCTICall):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ * jit/JIT.h:
+
+2008-12-02 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix the inheritance chain for JSFunction.
+
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::info): Add InternalFunction::info as parent class
+
+2008-12-02 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix ability to include JavaScriptCore.pri from other .pro files.
+
+ * JavaScriptCore.pri: Moved -O3 setting into the .pro files.
+ * JavaScriptCore.pro:
+ * jsc.pro:
+
+2008-12-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich, with help from Gavin Barraclough.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22583.
+
+ Refactored regular expression parsing to parse sequences of characters
+ as a single unit, in preparation for optimizing sequences of characters.
+
+ SunSpider reports no change.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * wrec/Escapes.h: Added. Set of classes for representing an escaped
+ token in a pattern.
+
+ * wrec/Quantifier.h:
+ (JSC::WREC::Quantifier::Quantifier): Simplified this constructor slightly,
+ to match the new Escape constructor.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generatePatternCharacterSequence):
+ * wrec/WRECGenerator.h: Added an interface for generating a sequence
+ of pattern characters at a time. It doesn't do anything special yet.
+
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::consumeGreedyQuantifier):
+ (JSC::WREC::Parser::consumeQuantifier): Renamed "parse" to "consume" in
+ these functions, to match "consumeEscape."
+
+ (JSC::WREC::Parser::parsePatternCharacterSequence): New function for
+ iteratively aggregating a sequence of characters in a pattern.
+
+ (JSC::WREC::Parser::parseCharacterClassQuantifier):
+ (JSC::WREC::Parser::parseBackreferenceQuantifier): Renamed "parse" to
+ "consume" in these functions, to match "consumeEscape."
+
+ (JSC::WREC::Parser::parseCharacterClass): Refactored to use the common
+ escape processing code in consumeEscape.
+
+ (JSC::WREC::Parser::parseEscape): Refactored to use the common
+ escape processing code in consumeEscape.
+
+ (JSC::WREC::Parser::consumeEscape): Factored escaped token processing
+ into a common function, since we were doing this in a few places.
+
+ (JSC::WREC::Parser::parseTerm): Refactored to use the common
+ escape processing code in consumeEscape.
+
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::consumeOctal): Refactored to use a helper function
+ for reading a digit.
+
+2008-12-01 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
+ <https://bugs.webkit.org/show_bug.cgi?id=20340>
+
+ SegmentedVector currently frees segments and reallocates them when used
+ as a stack. This can lead to unsafe use of pointers into freed segments.
+
+ In order to fix this problem, SegmentedVector will be changed to only
+ grow and never shrink. Also, rename the reserveCapacity() member
+ function to grow() to match the actual usage in BytecodeGenerator, where
+ this function is used to allocate a group of registers at once, rather
+ than merely saving space for them.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator): Use grow() instead of
+ reserveCapacity().
+ * bytecompiler/SegmentedVector.h:
+ (JSC::SegmentedVector::SegmentedVector):
+ (JSC::SegmentedVector::last):
+ (JSC::SegmentedVector::append):
+ (JSC::SegmentedVector::removeLast):
+ (JSC::SegmentedVector::grow): Renamed from reserveCapacity().
+ (JSC::SegmentedVector::clear):
+
+2008-12-01 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Anders Carlsson.
+
+ Disable WREC for x86_64 since memory allocated by the system allocator is not marked executable,
+ which causes 64-bit debug builds to crash. Once we have a dedicated allocator for executable
+ memory we can turn this back on.
+
+ * wtf/Platform.h:
+
+2008-12-01 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Restore inline buffer after vector is shrunk back below its inline capacity.
+
+ * wtf/Vector.h:
+ (WTF::):
+ (WTF::VectorBuffer::restoreInlineBufferIfNeeded):
+ (WTF::::shrinkCapacity):
+
+2008-11-30 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Try to return free pages in the current thread cache too.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::TCMallocStats::releaseFastMallocFreeMemory):
+
+2008-12-01 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22567
+ Make HashTable work as expected with respect to threads. Specifically, it has class-level
+ thread safety and constant methods work on constant objects without synchronization.
+
+ No observable change in behavior, so no test. This only affects debug builds.
+
+ * wtf/HashTable.cpp:
+ (WTF::hashTableStatsMutex):
+ (WTF::HashTableStats::~HashTableStats):
+ (WTF::HashTableStats::recordCollisionAtCount):
+ Guarded variable access with a mutex.
+
+ * wtf/HashTable.h:
+ (WTF::::lookup):
+ (WTF::::lookupForWriting):
+ (WTF::::fullLookupForWriting):
+ (WTF::::add):
+ (WTF::::reinsert):
+ (WTF::::remove):
+ (WTF::::rehash):
+ Changed increments of static variables to use atomicIncrement.
+
+ (WTF::::invalidateIterators):
+ (WTF::addIterator):
+ (WTF::removeIterator):
+ Guarded mutable access with a mutex.
+
+2008-11-29 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Enable WREC on PLATFORM(X86_64). This change predominantly requires changes to the
+ WREC::Generator::generateEnter method to support the x86-64 ABI, and addition of
+ support for a limited number of quadword operations in the X86Assembler.
+
+ This patch will cause the JS heap to be allocated with RWX permissions on 64-bit Mac
+ platforms. This is a regression with respect to previous 64-bit behaviour, but is no
+ more permissive than on 32-bit builds. This issue should be addressed at some point.
+ (This is tracked by bug #21783.)
+
+ https://bugs.webkit.org/show_bug.cgi?id=22554
+ Greater than 4x speedup on regexp-dna, on x86-64.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::addPtr):
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::pop):
+ (JSC::MacroAssembler::push):
+ (JSC::MacroAssembler::move):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::movq_rr):
+ (JSC::X86Assembler::addl_i8m):
+ (JSC::X86Assembler::addl_i32r):
+ (JSC::X86Assembler::addq_i8r):
+ (JSC::X86Assembler::addq_i32r):
+ (JSC::X86Assembler::movq_mr):
+ (JSC::X86Assembler::movq_rm):
+ * wrec/WREC.h:
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateReturnSuccess):
+ (JSC::WREC::Generator::generateReturnFailure):
+ * wtf/Platform.h:
+ * wtf/TCSystemAlloc.cpp:
+
+2008-12-01 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Preliminary work for bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
+ <https://bugs.webkit.org/show_bug.cgi?id=20340>
+
+ SegmentedVector currently frees segments and reallocates them when used
+ as a stack. This can lead to unsafe use of pointers into freed segments.
+
+ In order to fix this problem, SegmentedVector will be changed to only
+ grow and never shrink, with the sole exception of clearing all of its
+ data, a capability that is required by Lexer. This patch changes the
+ public interface to only allow for these capabilities.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator): Use reserveCapacity()
+ instead of resize() for m_globals and m_parameters.
+ * bytecompiler/SegmentedVector.h:
+ (JSC::SegmentedVector::resize): Removed.
+ (JSC::SegmentedVector::reserveCapacity): Added.
+ (JSC::SegmentedVector::clear): Added.
+ (JSC::SegmentedVector::shrink): Removed.
+ (JSC::SegmentedVector::grow): Removed.
+ * parser/Lexer.cpp:
+ (JSC::Lexer::clear): Use clear() instead of resize(0).
+
+2008-11-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Renames jumps to m_jumps in JumpList.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::JumpList::link):
+ (JSC::MacroAssembler::JumpList::linkTo):
+ (JSC::MacroAssembler::JumpList::append):
+
+2008-11-30 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22557
+
+ Report free size in central and thread caches too.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::TCMallocStats::fastMallocStatistics):
+ * wtf/FastMalloc.h:
+
+2008-11-29 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22557
+ Add statistics for JavaScript GC heap.
+
+ * JavaScriptCore.exp:
+ * runtime/Collector.cpp:
+ (JSC::Heap::objectCount):
+ (JSC::addToStatistics):
+ (JSC::Heap::statistics):
+ * runtime/Collector.h:
+
+2008-11-29 Antti Koivisto <antti@apple.com>
+
+ Fix debug build by adding a stub method.
+
+ * wtf/FastMalloc.cpp:
+ (WTF::fastMallocStatistics):
+
+2008-11-29 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22557
+
+ Add function for getting basic statistics from FastMalloc.
+
+ * JavaScriptCore.exp:
+ * wtf/FastMalloc.cpp:
+ (WTF::DLL_Length):
+ (WTF::TCMalloc_PageHeap::ReturnedBytes):
+ (WTF::TCMallocStats::fastMallocStatistics):
+ * wtf/FastMalloc.h:
+
+2008-11-29 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ The C++ standard does not automatically grant the friendships of an
+ enclosing class to its nested subclasses, so we should do so explicitly.
+ This fixes the GCC 4.0 build, although both GCC 4.2 and Visual C++ 2005
+ accept the incorrect code as it is.
+
+ * assembler/MacroAssembler.h:
+
+2008-11-29 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Add the class MacroAssembler to provide some abstraction of code generation,
+ and change WREC to make use of this class, rather than directly accessing
+ the X86Assembler.
+
+ This patch also allows WREC to be compiled without the rest of the JIT enabled.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/MacroAssembler.h: Added.
+ (JSC::MacroAssembler::):
+ (JSC::MacroAssembler::MacroAssembler):
+ (JSC::MacroAssembler::copyCode):
+ (JSC::MacroAssembler::Address::Address):
+ (JSC::MacroAssembler::ImplicitAddress::ImplicitAddress):
+ (JSC::MacroAssembler::BaseIndex::BaseIndex):
+ (JSC::MacroAssembler::Label::Label):
+ (JSC::MacroAssembler::Jump::Jump):
+ (JSC::MacroAssembler::Jump::link):
+ (JSC::MacroAssembler::Jump::linkTo):
+ (JSC::MacroAssembler::JumpList::link):
+ (JSC::MacroAssembler::JumpList::linkTo):
+ (JSC::MacroAssembler::JumpList::append):
+ (JSC::MacroAssembler::Imm32::Imm32):
+ (JSC::MacroAssembler::add32):
+ (JSC::MacroAssembler::or32):
+ (JSC::MacroAssembler::sub32):
+ (JSC::MacroAssembler::loadPtr):
+ (JSC::MacroAssembler::load32):
+ (JSC::MacroAssembler::load16):
+ (JSC::MacroAssembler::storePtr):
+ (JSC::MacroAssembler::store32):
+ (JSC::MacroAssembler::pop):
+ (JSC::MacroAssembler::push):
+ (JSC::MacroAssembler::peek):
+ (JSC::MacroAssembler::poke):
+ (JSC::MacroAssembler::move):
+ (JSC::MacroAssembler::compareImm32ForBranch):
+ (JSC::MacroAssembler::compareImm32ForBranchEquality):
+ (JSC::MacroAssembler::jae32):
+ (JSC::MacroAssembler::je32):
+ (JSC::MacroAssembler::je16):
+ (JSC::MacroAssembler::jg32):
+ (JSC::MacroAssembler::jge32):
+ (JSC::MacroAssembler::jl32):
+ (JSC::MacroAssembler::jle32):
+ (JSC::MacroAssembler::jne32):
+ (JSC::MacroAssembler::jump):
+ (JSC::MacroAssembler::breakpoint):
+ (JSC::MacroAssembler::ret):
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::cmpw_rm):
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+ * interpreter/Interpreter.h:
+ (JSC::Interpreter::assemblerBuffer):
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ * wrec/WREC.cpp:
+ (JSC::WREC::Generator::compileRegExp):
+ * wrec/WREC.h:
+ * wrec/WRECFunctors.cpp:
+ (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom):
+ (JSC::WREC::GenerateCharacterClassFunctor::generateAtom):
+ (JSC::WREC::GenerateBackreferenceFunctor::generateAtom):
+ (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
+ * wrec/WRECFunctors.h:
+ (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateReturnSuccess):
+ (JSC::WREC::Generator::generateSaveIndex):
+ (JSC::WREC::Generator::generateIncrementIndex):
+ (JSC::WREC::Generator::generateLoadCharacter):
+ (JSC::WREC::Generator::generateJumpIfEndOfInput):
+ (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
+ (JSC::WREC::Generator::generateReturnFailure):
+ (JSC::WREC::Generator::generateBacktrack1):
+ (JSC::WREC::Generator::generateBacktrackBackreference):
+ (JSC::WREC::Generator::generateBackreferenceQuantifier):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateParentheses):
+ (JSC::WREC::Generator::generateParenthesesNonGreedy):
+ (JSC::WREC::Generator::generateParenthesesResetTrampoline):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::generateBackreference):
+ (JSC::WREC::Generator::terminateAlternative):
+ (JSC::WREC::Generator::terminateDisjunction):
+ * wrec/WRECGenerator.h:
+ (JSC::WREC::Generator::Generator):
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parsePatternCharacterQualifier):
+ (JSC::WREC::Parser::parseCharacterClassQuantifier):
+ (JSC::WREC::Parser::parseBackreferenceQuantifier):
+ (JSC::WREC::Parser::parseParentheses):
+ (JSC::WREC::Parser::parseCharacterClass):
+ (JSC::WREC::Parser::parseOctalEscape):
+ (JSC::WREC::Parser::parseEscape):
+ (JSC::WREC::Parser::parseTerm):
+ (JSC::WREC::Parser::parseDisjunction):
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::Parser):
+ (JSC::WREC::Parser::parsePattern):
+ (JSC::WREC::Parser::parseAlternative):
+ * wtf/Platform.h:
+
+2008-11-28 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix compilation on Windows CE
+
+ Port away from the use of errno after calling strtol(), instead
+ detect conversion errors by checking the result and the stop
+ position.
+
+ * runtime/DateMath.cpp:
+ (JSC::parseLong):
+ (JSC::parseDate):
+
+2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.
+
+ * runtime/DateMath.cpp:
+ (JSC::lowResUTCTime):
+
+2008-11-28 Simon Hausmann <hausmann@webkit.org>
+
+ Rubber-stamped by Tor Arne Vestbø.
+
+ Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.
+
+ * runtime/JSGlobalObjectFunctions.cpp:
+
+2008-11-27 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ r38825 made JSFunction::m_body private, but some inspector code in
+ WebCore sets the field. Add setters for it.
+
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::setBody):
+
+2008-11-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix FIXME by adding accessor for JSFunction's m_body property.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ * profiler/Profiler.cpp:
+ (JSC::createCallIdentifierFromFunctionImp):
+ * runtime/Arguments.h:
+ (JSC::Arguments::getArgumentsData):
+ (JSC::Arguments::Arguments):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncToString):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::body):
+
+2008-11-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Remove unused member variables from ProgramNode.
+
+ * parser/Nodes.h:
+
+2008-11-27 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Enable mouse panning feaure on Windows Cairo build.
+ See http://bugs.webkit.org/show_bug.cgi?id=22525
+
+ * wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
+
+2008-11-27 Alp Toker <alp@nuanti.com>
+
+ Change recently introduced C++ comments in Platform.h to C comments to
+ fix the minidom build with traditional C.
+
+ Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
+ API header breakage at build time.
+
+ * GNUmakefile.am:
+ * wtf/Platform.h:
+
+2008-11-27 Alp Toker <alp@nuanti.com>
+
+ Remove C++ comment from JavaScriptCore API headers (introduced r35449).
+ Fixes build for ANSI C applications using the public API.
+
+ * API/WebKitAvailability.h:
+
+2008-11-26 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Fix the JSC Chromium Mac build by adding JavaScriptCore/icu into the include path
+
+ * JavaScriptCore.scons:
+
+2008-11-25 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove the unused member function JSFunction::getParameterName().
+
+ * runtime/JSFunction.cpp:
+ * runtime/JSFunction.h:
+
+2008-11-24 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Polymorpic caching for get by id chain. Similar to the polymorphic caching already implemented
+ for self and proto accesses (implemented by allowing multiple trampolines to be JIT genertaed,
+ and linked together) - the get by id chain caching is implemented as a genericization of the
+ proto list caching, allowing cached access lists to contain a mix of proto and proto chain
+ accesses (since in JS style inheritance hierarchies you may commonly see a mix of properties
+ being overridden on the direct prototype, or higher up its prototype chain).
+
+ In order to allow this patch to compile there is a fix to appease gcc 4.2 compiler issues
+ (removing the jumps between fall-through cases in privateExecute).
+
+ This patch also removes redundant immediate checking from the reptach code, and fixes a related
+ memory leak (failure to deallocate trampolines).
+
+ ~2% progression on v8 tests (bulk on the win on deltablue)
+
+ * bytecode/Instruction.h:
+ (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::):
+ (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
+ (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
+ (JSC::PolymorphicAccessStructureList::derefStructures):
+ * interpreter/Interpreter.cpp:
+ (JSC::countPrototypeChainEntriesAndCheckForProxies):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::getPolymorphicAccessStructureListSlot):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChainList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdChainList):
+
+2008-11-25 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Move the collect() call in Heap::heapAllocate() that is conditionally
+ compiled under COLLECT_ON_EVERY_ALLOCATION so that it is before we get
+ information about the heap. This was causing assertion failures for me
+ while I was reducing a bug.
+
+ * runtime/Collector.cpp:
+ (JSC::Heap::heapAllocate):
+
+2008-11-24 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 13790: Function declarations are not treated as statements (used to affect starcraft2.com)
+ <https://bugs.webkit.org/show_bug.cgi?id=13790>
+
+ Modify the parser to treat function declarations as statements,
+ simplifying the grammar in the process. Technically, according to the
+ grammar in the ECMA spec, function declarations are not statements and
+ can not be used everywhere that statements can, but it is not worth the
+ possibility compatibility issues just to stick to the spec in this case.
+
+ * parser/Grammar.y:
+ * parser/Nodes.cpp:
+ (JSC::FuncDeclNode::emitBytecode): Avoid returning ignoredResult()
+ as a result, because it causes a crash in DoWhileNode::emitBytecode().
+
+2008-11-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Unroll the regexp matching loop by 1. 10% speedup on simple matching
+ stress test. No change on SunSpider.
+
+ (I decided not to unroll to arbitrary levels because the returns diminsh
+ quickly.)
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateJumpIfEndOfInput):
+ (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
+ * wrec/WRECGenerator.h:
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::error):
+ (JSC::WREC::Parser::parsePattern):
+
+2008-11-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Removed some unnecessary "Generator::" prefixes.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateReturnSuccess):
+ (JSC::WREC::Generator::generateSaveIndex):
+ (JSC::WREC::Generator::generateIncrementIndex):
+ (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
+ (JSC::WREC::Generator::generateReturnFailure):
+
+2008-11-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Made a bunch of WREC::Parser functions private, and added an explicit
+ "reset()" function, so a parser can be reused.
+
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::Parser):
+ (JSC::WREC::Parser::generator):
+ (JSC::WREC::Parser::ignoreCase):
+ (JSC::WREC::Parser::multiline):
+ (JSC::WREC::Parser::recordSubpattern):
+ (JSC::WREC::Parser::numSubpatterns):
+ (JSC::WREC::Parser::parsePattern):
+ (JSC::WREC::Parser::parseAlternative):
+ (JSC::WREC::Parser::reset):
+
+2008-11-24 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Implement repatching for get by id chain.
+ Previously the access is performed in a function stub, in the repatch form
+ the trampoline is not called to; instead the hot path is relinked to jump
+ directly to the trampoline, if it fails it will jump to the slow case.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22449
+ 3% progression on deltablue.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2008-11-24 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20746
+
+ Various small compilation fixes to make the Qt port of WebKit
+ compile on Windows CE.
+
+ * config.h: Don't set _CRT_RAND_S for CE, it's not available.
+ * jsc.cpp: Disabled use of debugger includes for CE. It
+ does not have the debugging functions.
+ * runtime/DateMath.cpp: Use localtime() on Windows CE.
+ * wtf/Assertions.cpp: Compile on Windows CE without debugger.
+ * wtf/Assertions.h: Include windows.h before defining ASSERT.
+ * wtf/MathExtras.h: Include stdlib.h instead of xmath.h.
+ * wtf/Platform.h: Disable ERRNO_H and detect endianess based
+ on the Qt endianess. On Qt for Windows CE the endianess is
+ defined by the vendor specific build spec.
+ * wtf/Threading.h: Use the volatile-less atomic functions.
+ * wtf/dtoa.cpp: Compile without errno.
+ * wtf/win/MainThreadWin.cpp: Don't include windows.h on CE after
+ Assertions.h due to the redefinition of ASSERT.
+
+2008-11-22 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Replace accidentally deleted immediate check from get by id chain trampoline.
+ https://bugs.webkit.org/show_bug.cgi?id=22413
+
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileGetByIdChain):
+
+2008-11-21 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add (really) polymorphic caching for get by id self.
+ Very similar to caching of prototype accesses, described below.
+
+ Oh, also, probably shouldn't have been leaking those structure list objects.
+
+ 4% preogression on deltablue.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::derefStructures):
+ (JSC::PrototypeStructureList::derefStructures):
+ * bytecode/Instruction.h:
+ * bytecode/Opcode.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileGetByIdSelfList):
+ (JSC::JIT::patchGetByIdSelf):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdSelfList):
+
+2008-11-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed many crashes seen 'round the world (but only in release builds).
+
+ Update outputParameter offset to reflect slight re-ordering of push
+ instructions in r38669.
+
+ * wrec/WRECGenerator.cpp:
+
+2008-11-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more RegExp refactoring.
+
+ Deployed a helper function for reading the next character. Used the "link
+ vector of jumps" helper in a place I missed before.
+
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateLoadCharacter):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ * wrec/WRECGenerator.h:
+
+2008-11-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22402
+ Replace abort() with CRASH()
+
+ * wtf/Assertions.h: Added a different method to crash, which should work even is 0xbbadbeef
+ is a valid memory address.
+
+ * runtime/Collector.cpp:
+ * wtf/FastMalloc.cpp:
+ * wtf/FastMalloc.h:
+ * wtf/TCSpinLock.h:
+ Replace abort() with CRASH().
+
+2008-11-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reverted fix for bug 22042 (Replace abort() with CRASH()), because it was breaking
+ FOR_EACH_OPCODE_ID macro somehow, making Safari crash.
+
+ * runtime/Collector.cpp:
+ (JSC::Heap::heapAllocate):
+ (JSC::Heap::collect):
+ * wtf/Assertions.h:
+ * wtf/FastMalloc.cpp:
+ (WTF::fastMalloc):
+ (WTF::fastCalloc):
+ (WTF::fastRealloc):
+ (WTF::InitSizeClasses):
+ (WTF::PageHeapAllocator::New):
+ (WTF::TCMallocStats::do_malloc):
+ * wtf/FastMalloc.h:
+ * wtf/TCSpinLock.h:
+ (TCMalloc_SpinLock::Init):
+ (TCMalloc_SpinLock::Finalize):
+ (TCMalloc_SpinLock::Lock):
+ (TCMalloc_SpinLock::Unlock):
+
+2008-11-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more RegExp refactoring.
+
+ Moved all assembly from WREC.cpp into WRECGenerator helper functions.
+ This should help with portability and readability.
+
+ Removed ASSERTs after calls to executableCopy(), and changed
+ executableCopy() to ASSERT instead.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::executableCopy):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateEnter):
+ (JSC::WREC::Generator::generateReturnSuccess):
+ (JSC::WREC::Generator::generateSaveIndex):
+ (JSC::WREC::Generator::generateIncrementIndex):
+ (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
+ (JSC::WREC::Generator::generateReturnFailure):
+ * wrec/WRECGenerator.h:
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::ignoreCase):
+ (JSC::WREC::Parser::generator):
+
+2008-11-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * wtf/Assertions.h: Use ::abort for C++ code.
+
+2008-11-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22402
+ Replace abort() with CRASH()
+
+ * wtf/Assertions.h: Added abort() after an attempt to crash for extra safety.
+
+ * runtime/Collector.cpp:
+ * wtf/FastMalloc.cpp:
+ * wtf/FastMalloc.h:
+ * wtf/TCSpinLock.h:
+ Replace abort() with CRASH().
+
+2008-11-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed wrec => generator.
+
+ * wrec/WRECFunctors.cpp:
+ (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom):
+ (JSC::WREC::GeneratePatternCharacterFunctor::backtrack):
+ (JSC::WREC::GenerateCharacterClassFunctor::generateAtom):
+ (JSC::WREC::GenerateCharacterClassFunctor::backtrack):
+ (JSC::WREC::GenerateBackreferenceFunctor::generateAtom):
+ (JSC::WREC::GenerateBackreferenceFunctor::backtrack):
+ (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
+
+2008-11-19 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Add support for (really) polymorphic caching of prototype accesses.
+
+ If a cached prototype access misses, cti_op_get_by_id_proto_list is called.
+ When this occurs the Structure pointers from the instruction stream are copied
+ off into a new ProtoStubInfo object. A second prototype access trampoline is
+ generated, and chained onto the first. Subsequent missed call to
+ cti_op_get_by_id_proto_list_append, which append futher new trampolines, up to
+ PROTOTYPE_LIST_CACHE_SIZE (currently 4). If any of the misses result in an
+ access other than to a direct prototype property, list formation is halted (or
+ for the initial miss, does not take place at all).
+
+ Separate fail case functions are provided for each access since this contributes
+ to the performance progression (enables better processor branch prediction).
+
+ Overall this is a near 5% progression on v8, with around 10% wins on richards
+ and deltablue.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::derefStructures):
+ * bytecode/Instruction.h:
+ (JSC::ProtoStructureList::ProtoStubInfo::set):
+ (JSC::ProtoStructureList::ProtoStructureList):
+ (JSC::Instruction::Instruction):
+ (JSC::Instruction::):
+ * bytecode/Opcode.h:
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id_self_fail):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list_append):
+ (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
+ (JSC::Interpreter::cti_op_get_by_id_proto_fail):
+ (JSC::Interpreter::cti_op_get_by_id_chain_fail):
+ (JSC::Interpreter::cti_op_get_by_id_array_fail):
+ (JSC::Interpreter::cti_op_get_by_id_string_fail):
+ * interpreter/Interpreter.h:
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdProtoList):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * jit/JIT.h:
+ (JSC::JIT::compileGetByIdProtoList):
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Try and fix the tiger build.
+
+ * parser/Grammar.y:
+
+2008-11-20 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Make JavaScriptCore Chromium build under Windows (cmd only, cygwin almost works)
+ https://bugs.webkit.org/show_bug.cgi?id=22347
+
+ * JavaScriptCore.scons:
+ * parser/Parser.cpp: Add using std::auto_ptr since we use auto_ptr
+
+2008-11-20 Steve Falkenburg <sfalken@apple.com>
+
+ Fix build.
+
+ Reviewed by Sam Weinig.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::reparse):
+
+2008-11-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more RegExp refactoring.
+
+ Created a helper function in the assembler for linking a vector of
+ JmpSrc to a location, and deployed it in a bunch of places.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::link):
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateParentheses):
+ (JSC::WREC::Generator::generateParenthesesResetTrampoline):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::terminateAlternative):
+ (JSC::WREC::Generator::terminateDisjunction):
+ * wrec/WRECParser.cpp:
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::consumeHex):
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Fix non-mac builds.
+
+ * parser/Lexer.cpp:
+ * parser/Parser.cpp:
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=22385
+ <rdar://problem/6390179>
+ Lazily reparse FunctionBodyNodes on first execution.
+
+ - Saves 57MB on Membuster head.
+
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate): Remove vector shrinking since this is now
+ handled by destroying the ScopeNodeData after generation.
+
+ * parser/Grammar.y: Add alternate NoNode version of the grammar
+ that does not create nodes. This is used to lazily create FunctionBodyNodes
+ on first execution.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::setCode): Fix bug where on reparse, the Lexer was confused about
+ what position and length meant. Position is the current position in the original
+ data buffer (important for getting correct line/column information) and length
+ the end offset in the original buffer.
+ * parser/Lexer.h:
+ (JSC::Lexer::sourceCode): Positions are relative to the beginning of the buffer.
+
+ * parser/Nodes.cpp:
+ (JSC::ScopeNodeData::ScopeNodeData): Move initialization of ScopeNode data here.
+ (JSC::ScopeNode::ScopeNode): Add constructor that only sets the JSGlobalData
+ for FunctionBodyNode stubs.
+ (JSC::ScopeNode::~ScopeNode): Release m_children now that we don't inherit from
+ BlockNode.
+ (JSC::ScopeNode::releaseNodes): Ditto.
+ (JSC::EvalNode::generateBytecode): Only shrink m_children, as we need to keep around
+ the rest of the data.
+ (JSC::FunctionBodyNode::FunctionBodyNode): Add constructor that only sets the
+ JSGlobalData.
+ (JSC::FunctionBodyNode::create): Ditto.
+ (JSC::FunctionBodyNode::generateBytecode): If we don't have the data, do a reparse
+ to construct it. Then after generation, destroy the data.
+ (JSC::ProgramNode::generateBytecode): After generation, destroy the AST data.
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::): Add isFuncExprNode for FunctionConstructor.
+ (JSC::StatementNode::): Add isExprStatementNode for FunctionConstructor.
+ (JSC::ExprStatementNode::): Ditto.
+ (JSC::ExprStatementNode::expr): Add accessor for FunctionConstructor.
+ (JSC::FuncExprNode::): Add isFuncExprNode for FunctionConstructor
+
+ (JSC::ScopeNode::adoptData): Adopts a ScopeNodeData.
+ (JSC::ScopeNode::data): Accessor for ScopeNodeData.
+ (JSC::ScopeNode::destroyData): Deletes the ScopeNodeData.
+ (JSC::ScopeNode::setFeatures): Added.
+ (JSC::ScopeNode::varStack): Added assert.
+ (JSC::ScopeNode::functionStack): Ditto.
+ (JSC::ScopeNode::children): Ditto.
+ (JSC::ScopeNode::neededConstants): Ditto.
+ Factor m_varStack, m_functionStack, m_children and m_numConstants into ScopeNodeData.
+
+ * parser/Parser.cpp:
+ (JSC::Parser::reparse): Reparse the SourceCode in the FunctionBodyNode and set
+ set up the ScopeNodeData for it.
+ * parser/Parser.h:
+
+ * parser/SourceCode.h:
+ (JSC::SourceCode::endOffset): Added for use in the lexer.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::getFunctionBody): Assuming a ProgramNode with one FunctionExpression in it,
+ get the FunctionBodyNode. Any issues signifies a parse failure in constructFunction.
+ (JSC::constructFunction): Make parsing functions in the form new Function(""), easier
+ by concatenating the strings together (with some glue) and parsing the function expression
+ as a ProgramNode from which we can receive the FunctionBodyNode. This has the added benefit
+ of not having special parsing code for the arguments and lazily constructing the
+ FunctionBodyNode's AST on first execution.
+
+ * runtime/Identifier.h:
+ (JSC::operator!=): Added.
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Speedup the lexer to offset coming re-parsing patch.
+
+ - .6% progression on Sunspider.
+
+ * bytecompiler/SegmentedVector.h:
+ (JSC::SegmentedVector::shrink): Fixed bug where m_size would not be
+ set when shrinking to 0.
+
+ * parser/Lexer.cpp:
+ (JSC::Lexer::Lexer):
+ (JSC::Lexer::isIdentStart): Use isASCIIAlpha and isASCII to avoid going into ICU in the common cases.
+ (JSC::Lexer::isIdentPart): Use isASCIIAlphanumeric and isASCII to avoid going into ICU in the common cases
+ (JSC::isDecimalDigit): Use version in ASCIICType.h. Inlining it was a regression.
+ (JSC::Lexer::isHexDigit): Ditto.
+ (JSC::Lexer::isOctalDigit): Ditto.
+ (JSC::Lexer::clear): Resize the m_identifiers SegmentedVector to initial
+ capacity
+ * parser/Lexer.h: Remove unused m_strings vector. Make m_identifiers
+ a SegmentedVector<Identifier> to avoid allocating a new Identifier* for
+ each identifier found. The SegmentedVector is need so we can passes
+ references to the Identifier to the parser, which remain valid even when
+ the vector is resized.
+ (JSC::Lexer::makeIdentifier): Inline and return a reference to the added
+ Identifier.
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Add isASCII to ASCIICType. Use coming soon!
+
+ * wtf/ASCIICType.h:
+ (WTF::isASCII):
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Add OwnPtr constructor and OwnPtr::adopt that take an auto_ptr.
+
+ * wtf/OwnPtr.h:
+ (WTF::OwnPtr::OwnPtr):
+ (WTF::OwnPtr::adopt):
+
+2008-11-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22364
+ Crashes seen on Tiger buildbots due to worker threads exhausting pthread keys
+
+ * runtime/Collector.cpp:
+ (JSC::Heap::Heap):
+ (JSC::Heap::destroy):
+ (JSC::Heap::makeUsableFromMultipleThreads):
+ (JSC::Heap::registerThread):
+ * runtime/Collector.h:
+ Pthread key for tracking threads is only created on request now, because this is a limited
+ resource, and thread tracking is not needed for worker heaps, or for WebCore heap.
+
+ * API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): Call makeUsableFromMultipleThreads().
+
+ * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::sharedInstance): Ditto.
+
+ * runtime/JSGlobalData.h: (JSC::JSGlobalData::makeUsableFromMultipleThreads): Just forward
+ the call to Heap, which clients need not know about, ideally.
+
+2008-11-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more WREC refactoring.
+
+ Removed the "Register" suffix from register names in WREC, and renamed:
+ currentPosition => index
+ currentValue => character
+ quantifierCount => repeatCount
+
+ Added a top-level parsePattern function to the WREC parser, which
+ allowed me to remove the error() and atEndOfPattern() accessors.
+
+ Factored out an MSVC customization into a constant.
+
+ Renamed nextLabel => beginPattern.
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateBacktrack1):
+ (JSC::WREC::Generator::generateBacktrackBackreference):
+ (JSC::WREC::Generator::generateBackreferenceQuantifier):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateParentheses):
+ (JSC::WREC::Generator::generateParenthesesResetTrampoline):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::generateBackreference):
+ (JSC::WREC::Generator::generateDisjunction):
+ (JSC::WREC::Generator::terminateDisjunction):
+ * wrec/WRECGenerator.h:
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::parsePattern):
+
+2008-11-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22361
+ A little more RegExp refactoring.
+
+ Consistently named variables holding the starting position at which
+ regexp matching should begin to "startOffset".
+
+ A few more "regExpObject" => "regExpConstructor" changes.
+
+ Refactored RegExpObject::match for clarity, and replaced a slow "get"
+ of the "global" property with a fast access to the global bit.
+
+ Made the error message you see when RegExpObject::match has no input a
+ little more informative, as in Firefox.
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::match):
+ * runtime/RegExp.h:
+ * runtime/RegExpObject.cpp:
+ (JSC::RegExpObject::match):
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+
+2008-11-19 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A little more refactoring.
+
+ Removed the "emit" and "emitUnlinked" prefixes from the assembler.
+
+ Moved the JmpSrc and JmpDst class definitions to the top of the X86
+ assembler class, in accordance with WebKit style guidelines.
+
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::JmpSrc::JmpSrc):
+ (JSC::X86Assembler::JmpDst::JmpDst):
+ (JSC::X86Assembler::int3):
+ (JSC::X86Assembler::pushl_m):
+ (JSC::X86Assembler::popl_m):
+ (JSC::X86Assembler::movl_rr):
+ (JSC::X86Assembler::addl_rr):
+ (JSC::X86Assembler::addl_i8r):
+ (JSC::X86Assembler::addl_i8m):
+ (JSC::X86Assembler::addl_i32r):
+ (JSC::X86Assembler::addl_mr):
+ (JSC::X86Assembler::andl_rr):
+ (JSC::X86Assembler::andl_i32r):
+ (JSC::X86Assembler::cmpl_i8r):
+ (JSC::X86Assembler::cmpl_rr):
+ (JSC::X86Assembler::cmpl_rm):
+ (JSC::X86Assembler::cmpl_mr):
+ (JSC::X86Assembler::cmpl_i32r):
+ (JSC::X86Assembler::cmpl_i32m):
+ (JSC::X86Assembler::cmpl_i8m):
+ (JSC::X86Assembler::cmpw_rm):
+ (JSC::X86Assembler::orl_rr):
+ (JSC::X86Assembler::orl_mr):
+ (JSC::X86Assembler::orl_i32r):
+ (JSC::X86Assembler::subl_rr):
+ (JSC::X86Assembler::subl_i8r):
+ (JSC::X86Assembler::subl_i8m):
+ (JSC::X86Assembler::subl_i32r):
+ (JSC::X86Assembler::subl_mr):
+ (JSC::X86Assembler::testl_i32r):
+ (JSC::X86Assembler::testl_i32m):
+ (JSC::X86Assembler::testl_rr):
+ (JSC::X86Assembler::xorl_i8r):
+ (JSC::X86Assembler::xorl_rr):
+ (JSC::X86Assembler::sarl_i8r):
+ (JSC::X86Assembler::sarl_CLr):
+ (JSC::X86Assembler::shl_i8r):
+ (JSC::X86Assembler::shll_CLr):
+ (JSC::X86Assembler::imull_rr):
+ (JSC::X86Assembler::imull_i32r):
+ (JSC::X86Assembler::idivl_r):
+ (JSC::X86Assembler::negl_r):
+ (JSC::X86Assembler::movl_mr):
+ (JSC::X86Assembler::movzbl_rr):
+ (JSC::X86Assembler::movzwl_mr):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::movl_i32r):
+ (JSC::X86Assembler::movl_i32m):
+ (JSC::X86Assembler::leal_mr):
+ (JSC::X86Assembler::jmp_r):
+ (JSC::X86Assembler::jmp_m):
+ (JSC::X86Assembler::movsd_mr):
+ (JSC::X86Assembler::xorpd_mr):
+ (JSC::X86Assembler::movsd_rm):
+ (JSC::X86Assembler::movd_rr):
+ (JSC::X86Assembler::cvtsi2sd_rr):
+ (JSC::X86Assembler::cvttsd2si_rr):
+ (JSC::X86Assembler::addsd_mr):
+ (JSC::X86Assembler::subsd_mr):
+ (JSC::X86Assembler::mulsd_mr):
+ (JSC::X86Assembler::addsd_rr):
+ (JSC::X86Assembler::subsd_rr):
+ (JSC::X86Assembler::mulsd_rr):
+ (JSC::X86Assembler::ucomis_rr):
+ (JSC::X86Assembler::pextrw_irr):
+ (JSC::X86Assembler::call):
+ (JSC::X86Assembler::jmp):
+ (JSC::X86Assembler::jne):
+ (JSC::X86Assembler::jnz):
+ (JSC::X86Assembler::je):
+ (JSC::X86Assembler::jl):
+ (JSC::X86Assembler::jb):
+ (JSC::X86Assembler::jle):
+ (JSC::X86Assembler::jbe):
+ (JSC::X86Assembler::jge):
+ (JSC::X86Assembler::jg):
+ (JSC::X86Assembler::ja):
+ (JSC::X86Assembler::jae):
+ (JSC::X86Assembler::jo):
+ (JSC::X86Assembler::jp):
+ (JSC::X86Assembler::js):
+ (JSC::X86Assembler::predictNotTaken):
+ (JSC::X86Assembler::convertToFastCall):
+ (JSC::X86Assembler::restoreArgumentReference):
+ (JSC::X86Assembler::restoreArgumentReferenceForTrampoline):
+ (JSC::X86Assembler::modRm_rr):
+ (JSC::X86Assembler::modRm_rr_Unchecked):
+ (JSC::X86Assembler::modRm_rm):
+ (JSC::X86Assembler::modRm_rm_Unchecked):
+ (JSC::X86Assembler::modRm_rmsib):
+ (JSC::X86Assembler::modRm_opr):
+ (JSC::X86Assembler::modRm_opr_Unchecked):
+ (JSC::X86Assembler::modRm_opm):
+ (JSC::X86Assembler::modRm_opm_Unchecked):
+ (JSC::X86Assembler::modRm_opmsib):
+ * jit/JIT.cpp:
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::emitNakedFastCall):
+ (JSC::JIT::emitCTICall):
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithIntToImmOrSlowCase):
+ (JSC::JIT::emitArithIntToImmWithJump):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECGenerator.cpp:
+ (JSC::WREC::Generator::generateBackreferenceQuantifier):
+ (JSC::WREC::Generator::generateNonGreedyQuantifier):
+ (JSC::WREC::Generator::generateGreedyQuantifier):
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateParentheses):
+ (JSC::WREC::Generator::generateParenthesesNonGreedy):
+ (JSC::WREC::Generator::generateParenthesesResetTrampoline):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ (JSC::WREC::Generator::generateBackreference):
+ (JSC::WREC::Generator::generateDisjunction):
+
+2008-11-19 Simon Hausmann <hausmann@webkit.org>
+
+ Sun CC build fix, removed trailing comman for last enum value.
+
+ * wtf/unicode/qt4/UnicodeQt4.h:
+ (WTF::Unicode::):
+
+2008-11-19 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Expand the workaround for Apple GCC compiler bug <rdar://problem/6354696> to all versions of GCC 4.0.1.
+ It has been observed with builds 5465 (Xcode 3.0) and 5484 (Xcode 3.1), and there is no evidence
+ that it has been fixed in newer builds of GCC 4.0.1.
+
+ This addresses <https://bugs.webkit.org/show_bug.cgi?id=22351> (WebKit nightly crashes on launch on 10.4.11).
+
+ * wtf/StdLibExtras.h:
+
+2008-11-18 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak and Geoff Garen.
+
+ Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
+ <https://bugs.webkit.org/show_bug.cgi?id=22287>
+
+ Fix a typo in the number cell reuse code where the first and second
+ operands are sometimes confused.
+
+ * jit/JIT.cpp:
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+
+2008-11-18 Dan Bernstein <mitz@apple.com>
+
+ - try to fix the Windows build
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+
+2008-11-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Minor RegExp cleanup.
+
+ SunSpider says no change.
+
+ * runtime/RegExpObject.cpp:
+ (JSC::RegExpObject::match): Renamed "regExpObj" to "regExpConstructor".
+
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp): Instead of checking for a NULL output vector,
+ ASSERT that the output vector is not NULL. (The rest of WREC is not
+ safe to use with a NULL output vector, and we probably don't want to
+ spend the time and/or performance to make it safe.)
+
+2008-11-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ A little more renaming and refactoring.
+
+ VM_CHECK_EXCEPTION() => CHECK_FOR_EXCEPTION().
+ NEXT_INSTRUCTION => NEXT_INSTRUCTION().
+
+ Removed the "Error_" and "TempError_" prefixes from WREC error types.
+
+ Refactored the WREC parser so it doesn't need a "setError" function,
+ and changed "isEndOfPattern" and its use -- they read kind of backwards
+ before.
+
+ Changed our "TODO:" error messages at least to say something, since you
+ can't say "TODO:" in shipping software.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_op_loop_if_less):
+ (JSC::Interpreter::cti_op_loop_if_lesseq):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_lesseq):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_jless):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_less):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_push_scope):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_del_by_val):
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WRECParser.cpp:
+ (JSC::WREC::Parser::parseGreedyQuantifier):
+ (JSC::WREC::Parser::parseParentheses):
+ (JSC::WREC::Parser::parseCharacterClass):
+ (JSC::WREC::Parser::parseEscape):
+ * wrec/WRECParser.h:
+ (JSC::WREC::Parser::):
+ (JSC::WREC::Parser::atEndOfPattern):
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22337
+ Enable workers by default
+
+ * Configurations/JavaScriptCore.xcconfig: Define ENABLE_WORKERS.
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ - Windows build fix
+
+ * wrec/WRECFunctors.h:
+ * wrec/WRECGenerator.h:
+ * wrec/WRECParser.h:
+ CharacterClass is a struct, not a class, fix forward declarations.
+
+2008-11-18 Dan Bernstein <mitz@apple.com>
+
+ - Windows build fix
+
+ * assembler/X86Assembler.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * wrec/Quantifier.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * assembler/AssemblerBuffer.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Split WREC classes out into individual files, with a few modifications
+ to more closely match the WebKit coding style.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler/X86Assembler.h:
+ * runtime/RegExp.cpp:
+ * wrec/CharacterClass.cpp: Copied from wrec/CharacterClassConstructor.cpp.
+ (JSC::WREC::CharacterClass::newline):
+ (JSC::WREC::CharacterClass::digits):
+ (JSC::WREC::CharacterClass::spaces):
+ (JSC::WREC::CharacterClass::wordchar):
+ (JSC::WREC::CharacterClass::nondigits):
+ (JSC::WREC::CharacterClass::nonspaces):
+ (JSC::WREC::CharacterClass::nonwordchar):
+ * wrec/CharacterClass.h: Copied from wrec/CharacterClassConstructor.h.
+ * wrec/CharacterClassConstructor.cpp:
+ (JSC::WREC::CharacterClassConstructor::addSortedRange):
+ (JSC::WREC::CharacterClassConstructor::append):
+ * wrec/CharacterClassConstructor.h:
+ * wrec/Quantifier.h: Copied from wrec/WREC.h.
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WREC.h:
+ * wrec/WRECFunctors.cpp: Copied from wrec/WREC.cpp.
+ * wrec/WRECFunctors.h: Copied from wrec/WREC.cpp.
+ (JSC::WREC::GenerateAtomFunctor::~GenerateAtomFunctor):
+ (JSC::WREC::GeneratePatternCharacterFunctor::GeneratePatternCharacterFunctor):
+ (JSC::WREC::GenerateCharacterClassFunctor::GenerateCharacterClassFunctor):
+ (JSC::WREC::GenerateBackreferenceFunctor::GenerateBackreferenceFunctor):
+ (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
+ * wrec/WRECGenerator.cpp: Copied from wrec/WREC.cpp.
+ (JSC::WREC::Generator::generatePatternCharacter):
+ (JSC::WREC::Generator::generateCharacterClassInvertedRange):
+ (JSC::WREC::Generator::generateCharacterClassInverted):
+ (JSC::WREC::Generator::generateCharacterClass):
+ (JSC::WREC::Generator::generateParentheses):
+ (JSC::WREC::Generator::generateAssertionBOL):
+ (JSC::WREC::Generator::generateAssertionEOL):
+ (JSC::WREC::Generator::generateAssertionWordBoundary):
+ * wrec/WRECGenerator.h: Copied from wrec/WREC.h.
+ * wrec/WRECParser.cpp: Copied from wrec/WREC.cpp.
+ (JSC::WREC::Parser::parseGreedyQuantifier):
+ (JSC::WREC::Parser::parseCharacterClassQuantifier):
+ (JSC::WREC::Parser::parseParentheses):
+ (JSC::WREC::Parser::parseCharacterClass):
+ (JSC::WREC::Parser::parseEscape):
+ (JSC::WREC::Parser::parseTerm):
+ * wrec/WRECParser.h: Copied from wrec/WREC.h.
+ (JSC::WREC::Parser::):
+ (JSC::WREC::Parser::Parser):
+ (JSC::WREC::Parser::setError):
+ (JSC::WREC::Parser::error):
+ (JSC::WREC::Parser::recordSubpattern):
+ (JSC::WREC::Parser::numSubpatterns):
+ (JSC::WREC::Parser::ignoreCase):
+ (JSC::WREC::Parser::multiline):
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix a few builds.
+
+ * JavaScriptCoreSources.bkl:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix a few builds.
+
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/CTI.* => jit/JIT.*.
+
+ Removed VM.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp: Removed.
+ * VM/CTI.h: Removed.
+ * bytecode/CodeBlock.cpp:
+ * interpreter/Interpreter.cpp:
+ * jit: Added.
+ * jit/JIT.cpp: Copied from VM/CTI.cpp.
+ * jit/JIT.h: Copied from VM/CTI.h.
+ * runtime/RegExp.cpp:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved runtime/ExecState.* => interpreter/CallFrame.*.
+
+ * API/JSBase.cpp:
+ * API/OpaqueJSString.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * debugger/DebuggerCallFrame.h:
+ * interpreter/CallFrame.cpp: Copied from runtime/ExecState.cpp.
+ * interpreter/CallFrame.h: Copied from runtime/ExecState.h.
+ * interpreter/Interpreter.cpp:
+ * parser/Nodes.cpp:
+ * profiler/ProfileGenerator.cpp:
+ * profiler/Profiler.cpp:
+ * runtime/ClassInfo.h:
+ * runtime/Collector.cpp:
+ * runtime/Completion.cpp:
+ * runtime/ExceptionHelpers.cpp:
+ * runtime/ExecState.cpp: Removed.
+ * runtime/ExecState.h: Removed.
+ * runtime/Identifier.cpp:
+ * runtime/JSFunction.cpp:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ * runtime/JSLock.cpp:
+ * runtime/JSNumberCell.h:
+ * runtime/JSObject.h:
+ * runtime/JSString.h:
+ * runtime/Lookup.h:
+ * runtime/PropertyNameArray.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * API/APICast.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * API/APICast.h:
+ * runtime/ExecState.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/SamplingTool.* => bytecode/SamplingTool.*.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/SamplingTool.cpp: Removed.
+ * VM/SamplingTool.h: Removed.
+ * bytecode/SamplingTool.cpp: Copied from VM/SamplingTool.cpp.
+ * bytecode/SamplingTool.h: Copied from VM/SamplingTool.h.
+ * jsc.cpp:
+ (runWithScripts):
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * runtime/ExecState.h:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/ExceptionHelpers.cpp => runtime/ExceptionHelpers.cpp.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/ExceptionHelpers.cpp: Removed.
+ * runtime/ExceptionHelpers.cpp: Copied from VM/ExceptionHelpers.cpp.
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/RegisterFile.cpp => interpreter/RegisterFile.cpp.
+
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/RegisterFile.cpp: Removed.
+ * interpreter/RegisterFile.cpp: Copied from VM/RegisterFile.cpp.
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved:
+ VM/ExceptionHelpers.h => runtime/ExceptionHelpers.h
+ VM/Register.h => interpreter/Register.h
+ VM/RegisterFile.h => interpreter/RegisterFile.h
+
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/ExceptionHelpers.h: Removed.
+ * VM/Register.h: Removed.
+ * VM/RegisterFile.h: Removed.
+ * interpreter/Register.h: Copied from VM/Register.h.
+ * interpreter/RegisterFile.h: Copied from VM/RegisterFile.h.
+ * runtime/ExceptionHelpers.h: Copied from VM/ExceptionHelpers.h.
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * JavaScriptCore.pri:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/Machine.cpp => interpreter/Interpreter.cpp.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/Machine.cpp: Removed.
+ * interpreter/Interpreter.cpp: Copied from VM/Machine.cpp.
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved VM/Machine.h => interpreter/Interpreter.h
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/ExceptionHelpers.cpp:
+ * VM/Machine.cpp:
+ * VM/Machine.h: Removed.
+ * VM/SamplingTool.cpp:
+ * bytecode/CodeBlock.cpp:
+ * bytecompiler/BytecodeGenerator.cpp:
+ * bytecompiler/BytecodeGenerator.h:
+ * debugger/DebuggerCallFrame.cpp:
+ * interpreter: Added.
+ * interpreter/Interpreter.h: Copied from VM/Machine.h.
+ * profiler/ProfileGenerator.cpp:
+ * runtime/Arguments.h:
+ * runtime/ArrayPrototype.cpp:
+ * runtime/Collector.cpp:
+ * runtime/Completion.cpp:
+ * runtime/ExecState.h:
+ * runtime/FunctionPrototype.cpp:
+ * runtime/JSActivation.cpp:
+ * runtime/JSFunction.cpp:
+ * runtime/JSGlobalData.cpp:
+ * runtime/JSGlobalObject.cpp:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ * wrec/WREC.cpp:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved runtime/Interpreter.cpp => runtime/Completion.cpp.
+
+ Moved functions from Interpreter.h to Completion.h, and removed
+ Interpreter.h from the project.
+
+ * API/JSBase.cpp:
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * jsc.cpp:
+ * runtime/Completion.cpp: Copied from runtime/Interpreter.cpp.
+ * runtime/Completion.h:
+ * runtime/Interpreter.cpp: Removed.
+ * runtime/Interpreter.h: Removed.
+
+2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22312>
+ Fix PCRE include path problem on Qt-port
+
+ * JavaScriptCore.pri:
+ * pcre/pcre.pri:
+
+2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22313>
+ Add missing CTI source to the build system on Qt-port
+
+ * JavaScriptCore.pri:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix JSGlue build.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * jsc.pro:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * JavaScriptCore.pri:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * JavaScriptCore.pri:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ More file moves:
+
+ VM/CodeBlock.* => bytecode/CodeBlock.*
+ VM/EvalCodeCache.h => bytecode/EvalCodeCache.h
+ VM/Instruction.h => bytecode/Instruction.h
+ VM/Opcode.* => bytecode/Opcode.*
+
+ * GNUmakefile.am:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/CodeBlock.cpp: Removed.
+ * VM/CodeBlock.h: Removed.
+ * VM/EvalCodeCache.h: Removed.
+ * VM/Instruction.h: Removed.
+ * VM/Opcode.cpp: Removed.
+ * VM/Opcode.h: Removed.
+ * bytecode: Added.
+ * bytecode/CodeBlock.cpp: Copied from VM/CodeBlock.cpp.
+ * bytecode/CodeBlock.h: Copied from VM/CodeBlock.h.
+ * bytecode/EvalCodeCache.h: Copied from VM/EvalCodeCache.h.
+ * bytecode/Instruction.h: Copied from VM/Instruction.h.
+ * bytecode/Opcode.cpp: Copied from VM/Opcode.cpp.
+ * bytecode/Opcode.h: Copied from VM/Opcode.h.
+ * jsc.pro:
+ * jscore.bkl:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix a few more builds.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCoreSources.bkl:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * GNUmakefile.am:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Some file moves:
+
+ VM/LabelID.h => bytecompiler/Label.h
+ VM/RegisterID.h => bytecompiler/RegisterID.h
+ VM/SegmentedVector.h => bytecompiler/SegmentedVector.h
+ bytecompiler/CodeGenerator.* => bytecompiler/BytecodeGenerator.*
+
+ * AllInOneFile.cpp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/LabelID.h: Removed.
+ * VM/RegisterID.h: Removed.
+ * VM/SegmentedVector.h: Removed.
+ * bytecompiler/BytecodeGenerator.cpp: Copied from bytecompiler/CodeGenerator.cpp.
+ * bytecompiler/BytecodeGenerator.h: Copied from bytecompiler/CodeGenerator.h.
+ * bytecompiler/CodeGenerator.cpp: Removed.
+ * bytecompiler/CodeGenerator.h: Removed.
+ * bytecompiler/Label.h: Copied from VM/LabelID.h.
+ * bytecompiler/LabelScope.h:
+ * bytecompiler/RegisterID.h: Copied from VM/RegisterID.h.
+ * bytecompiler/SegmentedVector.h: Copied from VM/SegmentedVector.h.
+ * jsc.cpp:
+ * parser/Nodes.cpp:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved masm => assembler and split "AssemblerBuffer.h" out of "X86Assembler.h".
+
+ Also renamed ENABLE_MASM to ENABLE_ASSEMBLER.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * assembler: Added.
+ * assembler/AssemblerBuffer.h: Copied from masm/X86Assembler.h.
+ (JSC::AssemblerBuffer::AssemblerBuffer):
+ (JSC::AssemblerBuffer::~AssemblerBuffer):
+ (JSC::AssemblerBuffer::ensureSpace):
+ (JSC::AssemblerBuffer::isAligned):
+ (JSC::AssemblerBuffer::putByteUnchecked):
+ (JSC::AssemblerBuffer::putByte):
+ (JSC::AssemblerBuffer::putShortUnchecked):
+ (JSC::AssemblerBuffer::putShort):
+ (JSC::AssemblerBuffer::putIntUnchecked):
+ (JSC::AssemblerBuffer::putInt):
+ (JSC::AssemblerBuffer::data):
+ (JSC::AssemblerBuffer::size):
+ (JSC::AssemblerBuffer::reset):
+ (JSC::AssemblerBuffer::executableCopy):
+ (JSC::AssemblerBuffer::grow):
+ * assembler/X86Assembler.h: Copied from masm/X86Assembler.h.
+ * masm: Removed.
+ * masm/X86Assembler.h: Removed.
+ * wtf/Platform.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * GNUmakefile.am:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Fixed tyop.
+
+ * VM/CTI.cpp:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix windows build.
+
+ * VM/CTI.cpp:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * GNUmakefile.am:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed ENABLE_CTI and ENABLE(CTI) to ENABLE_JIT and ENABLE(JIT).
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::~CodeBlock):
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ * VM/Machine.cpp:
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::initialize):
+ (JSC::Interpreter::~Interpreter):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::privateExecute):
+ * VM/Machine.h:
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::prepareJumpTableForStringSwitch):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::~JSFunction):
+ * runtime/JSGlobalData.h:
+ * wrec/WREC.h:
+ * wtf/Platform.h:
+ * wtf/TCSystemAlloc.cpp:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix gtk build.
+
+ * VM/CTI.cpp:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by a few people on squirrelfish-dev.
+
+ Renamed CTI => JIT.
+
+ * VM/CTI.cpp:
+ (JSC::JIT::killLastResultRegister):
+ (JSC::JIT::emitGetVirtualRegister):
+ (JSC::JIT::emitGetVirtualRegisters):
+ (JSC::JIT::emitPutCTIArgFromVirtualRegister):
+ (JSC::JIT::emitPutCTIArg):
+ (JSC::JIT::emitGetCTIArg):
+ (JSC::JIT::emitPutCTIArgConstant):
+ (JSC::JIT::getConstantImmediateNumericArg):
+ (JSC::JIT::emitPutCTIParam):
+ (JSC::JIT::emitGetCTIParam):
+ (JSC::JIT::emitPutToCallFrameHeader):
+ (JSC::JIT::emitGetFromCallFrameHeader):
+ (JSC::JIT::emitPutVirtualRegister):
+ (JSC::JIT::emitInitRegister):
+ (JSC::JIT::printBytecodeOperandTypes):
+ (JSC::JIT::emitAllocateNumber):
+ (JSC::JIT::emitNakedCall):
+ (JSC::JIT::emitNakedFastCall):
+ (JSC::JIT::emitCTICall):
+ (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
+ (JSC::JIT::linkSlowCaseIfNotJSCell):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
+ (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
+ (JSC::JIT::getDeTaggedConstantImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediate):
+ (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::JIT::emitFastArithReTagImmediate):
+ (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+ (JSC::JIT::emitFastArithImmToInt):
+ (JSC::JIT::emitFastArithIntToImmOrSlowCase):
+ (JSC::JIT::emitFastArithIntToImmNoCheck):
+ (JSC::JIT::emitArithIntToImmWithJump):
+ (JSC::JIT::emitTagAsBoolImmediate):
+ (JSC::JIT::JIT):
+ (JSC::JIT::compileOpCallInitializeCallFrame):
+ (JSC::JIT::compileOpCallSetupArgs):
+ (JSC::JIT::compileOpCallEvalSetupArgs):
+ (JSC::JIT::compileOpConstructSetupArgs):
+ (JSC::JIT::compileOpCall):
+ (JSC::JIT::compileOpStrictEq):
+ (JSC::JIT::emitSlowScriptCheck):
+ (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::JIT::compileBinaryArithOp):
+ (JSC::JIT::compileBinaryArithOpSlowCase):
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileLinkPass):
+ (JSC::JIT::privateCompileSlowCases):
+ (JSC::JIT::privateCompile):
+ (JSC::JIT::privateCompileGetByIdSelf):
+ (JSC::JIT::privateCompileGetByIdProto):
+ (JSC::JIT::privateCompileGetByIdChain):
+ (JSC::JIT::privateCompilePutByIdReplace):
+ (JSC::JIT::privateCompilePutByIdTransition):
+ (JSC::JIT::unlinkCall):
+ (JSC::JIT::linkCall):
+ (JSC::JIT::privateCompileCTIMachineTrampolines):
+ (JSC::JIT::freeCTIMachineTrampolines):
+ (JSC::JIT::patchGetByIdSelf):
+ (JSC::JIT::patchPutByIdReplace):
+ (JSC::JIT::privateCompilePatchGetArrayLength):
+ (JSC::JIT::emitGetVariableObjectRegister):
+ (JSC::JIT::emitPutVariableObjectRegister):
+ * VM/CTI.h:
+ (JSC::JIT::compile):
+ (JSC::JIT::compileGetByIdSelf):
+ (JSC::JIT::compileGetByIdProto):
+ (JSC::JIT::compileGetByIdChain):
+ (JSC::JIT::compilePutByIdReplace):
+ (JSC::JIT::compilePutByIdTransition):
+ (JSC::JIT::compileCTIMachineTrampolines):
+ (JSC::JIT::compilePatchGetArrayLength):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::unlinkCallers):
+ * VM/Machine.cpp:
+ (JSC::Interpreter::initialize):
+ (JSC::Interpreter::~Interpreter):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ * VM/Machine.h:
+ * VM/RegisterFile.h:
+ * parser/Nodes.h:
+ * runtime/JSArray.h:
+ * runtime/JSCell.h:
+ * runtime/JSFunction.h:
+ * runtime/JSImmediate.h:
+ * runtime/JSNumberCell.h:
+ * runtime/JSObject.h:
+ * runtime/JSString.h:
+ * runtime/JSVariableObject.h:
+ * runtime/ScopeChain.h:
+ * runtime/Structure.h:
+ * runtime/TypeInfo.h:
+ * runtime/UString.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix wx build.
+
+ * jscore.bkl:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Nixed X86:: and X86Assembler:: prefixes in a lot of places using typedefs.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetVirtualRegister):
+ (JSC::CTI::emitGetVirtualRegisters):
+ (JSC::CTI::emitPutCTIArgFromVirtualRegister):
+ (JSC::CTI::emitPutCTIArg):
+ (JSC::CTI::emitGetCTIArg):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutVirtualRegister):
+ (JSC::CTI::emitNakedCall):
+ (JSC::CTI::emitNakedFastCall):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::CTI::emitFastArithReTagImmediate):
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ (JSC::CTI::emitFastArithImmToInt):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::emitFastArithIntToImmNoCheck):
+ (JSC::CTI::emitArithIntToImmWithJump):
+ (JSC::CTI::emitTagAsBoolImmediate):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::emitGetVariableObjectRegister):
+ (JSC::CTI::emitPutVariableObjectRegister):
+ * VM/CTI.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JmpTable::JmpTable):
+ (JSC::SlowCaseEntry::SlowCaseEntry):
+ (JSC::CTI::JSRInfo::JSRInfo):
+ * wrec/WREC.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * JavaScriptCore.pri:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed OBJECT_OFFSET => FIELD_OFFSET
+
+ Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in
+ more places.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::emitGetVariableObjectRegister):
+ (JSC::CTI::emitPutVariableObjectRegister):
+ * runtime/JSValue.h:
+ * runtime/JSVariableObject.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renames:
+
+ X86Assembler::copy => X86Assembler::executableCopy
+ AssemblerBuffer::copy => AssemblerBuffer::executableCopy
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ * masm/X86Assembler.h:
+ (JSC::AssemblerBuffer::executableCopy):
+ (JSC::X86Assembler::executableCopy):
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed WREC => JSC::WREC, removing JSC:: prefix in a lot of places.
+ Renamed WRECFunction => WREC::CompiledRegExp, and deployed this type
+ name in place of a few casts.
+
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::~RegExp):
+ (JSC::RegExp::match):
+ * runtime/RegExp.h:
+ * wrec/CharacterClassConstructor.cpp:
+ * wrec/CharacterClassConstructor.h:
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WREC.h:
+ (JSC::WREC::Generator::Generator):
+ (JSC::WREC::Parser::Parser):
+ (JSC::WREC::Parser::parseAlternative):
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed BytecodeInterpreter => Interpreter.
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::freeCTIMachineTrampolines):
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructures):
+ (JSC::CodeBlock::derefStructures):
+ (JSC::CodeBlock::refStructures):
+ * VM/Machine.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::Interpreter::resolve):
+ (JSC::Interpreter::resolveSkip):
+ (JSC::Interpreter::resolveGlobal):
+ (JSC::Interpreter::resolveBase):
+ (JSC::Interpreter::resolveBaseAndProperty):
+ (JSC::Interpreter::resolveBaseAndFunc):
+ (JSC::Interpreter::slideRegisterWindowForCall):
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::initialize):
+ (JSC::Interpreter::~Interpreter):
+ (JSC::Interpreter::dumpCallFrame):
+ (JSC::Interpreter::dumpRegisters):
+ (JSC::Interpreter::isOpcode):
+ (JSC::Interpreter::unwindCallFrame):
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::debug):
+ (JSC::Interpreter::resetTimeoutCheck):
+ (JSC::Interpreter::checkTimeout):
+ (JSC::Interpreter::createExceptionScope):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::Interpreter::uncachePutByID):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::uncacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ (JSC::Interpreter::retrieveCaller):
+ (JSC::Interpreter::retrieveLastCaller):
+ (JSC::Interpreter::findFunctionCallFrame):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_end):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_timeout_check):
+ (JSC::Interpreter::cti_register_file_check):
+ (JSC::Interpreter::cti_op_loop_if_less):
+ (JSC::Interpreter::cti_op_loop_if_lesseq):
+ (JSC::Interpreter::cti_op_new_object):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_new_func):
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_op_call_arityCheck):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ (JSC::Interpreter::cti_op_push_activation):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_create_arguments):
+ (JSC::Interpreter::cti_op_create_arguments_no_params):
+ (JSC::Interpreter::cti_op_tear_off_activation):
+ (JSC::Interpreter::cti_op_tear_off_arguments):
+ (JSC::Interpreter::cti_op_profile_will_call):
+ (JSC::Interpreter::cti_op_profile_did_call):
+ (JSC::Interpreter::cti_op_ret_scopeChain):
+ (JSC::Interpreter::cti_op_new_array):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_JSConstruct):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_lesseq):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_resolve_base):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_jless):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_new_func_exp):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_less):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_new_regexp):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_call_eval):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_get_pnames):
+ (JSC::Interpreter::cti_op_next_pname):
+ (JSC::Interpreter::cti_op_push_scope):
+ (JSC::Interpreter::cti_op_pop_scope):
+ (JSC::Interpreter::cti_op_typeof):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_is_boolean):
+ (JSC::Interpreter::cti_op_is_number):
+ (JSC::Interpreter::cti_op_is_string):
+ (JSC::Interpreter::cti_op_is_object):
+ (JSC::Interpreter::cti_op_is_function):
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_push_new_scope):
+ (JSC::Interpreter::cti_op_jmp_scopes):
+ (JSC::Interpreter::cti_op_put_by_index):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_op_del_by_val):
+ (JSC::Interpreter::cti_op_put_getter):
+ (JSC::Interpreter::cti_op_put_setter):
+ (JSC::Interpreter::cti_op_new_error):
+ (JSC::Interpreter::cti_op_debug):
+ (JSC::Interpreter::cti_vm_throw):
+ * VM/Machine.h:
+ * VM/Register.h:
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::SamplingTool):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate):
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ * jsc.cpp:
+ (runWithScripts):
+ * runtime/ExecState.h:
+ (JSC::ExecState::interpreter):
+ * runtime/JSCell.h:
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSString.h:
+ * wrec/WREC.cpp:
+ (WREC::compileRegExp):
+ * wrec/WREC.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Roll out r38461 (my last patch) because it broke the world.
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ A few more renames:
+
+ BytecodeInterpreter => Interpreter
+ WREC => JSC::WREC, removing JSC:: prefix in a lot of places
+ X86Assembler::copy => X86Assembler::executableCopy
+ AssemblerBuffer::copy => AssemblerBuffer::executableCopy
+ WRECFunction => WREC::RegExpFunction
+ OBJECT_OFFSET => FIELD_OFFSET
+
+ Also:
+
+ Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in more places.
+ Nixed X86:: and X86Assembler:: prefixes in a lot of places using typedefs
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::emitGetVirtualRegister):
+ (JSC::CTI::emitGetVirtualRegisters):
+ (JSC::CTI::emitPutCTIArgFromVirtualRegister):
+ (JSC::CTI::emitPutCTIArg):
+ (JSC::CTI::emitGetCTIArg):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutVirtualRegister):
+ (JSC::CTI::emitNakedCall):
+ (JSC::CTI::emitNakedFastCall):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::CTI::emitFastArithReTagImmediate):
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ (JSC::CTI::emitFastArithImmToInt):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::emitFastArithIntToImmNoCheck):
+ (JSC::CTI::emitArithIntToImmWithJump):
+ (JSC::CTI::emitTagAsBoolImmediate):
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::freeCTIMachineTrampolines):
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::emitGetVariableObjectRegister):
+ (JSC::CTI::emitPutVariableObjectRegister):
+ * VM/CTI.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JmpTable::JmpTable):
+ (JSC::SlowCaseEntry::SlowCaseEntry):
+ (JSC::CTI::JSRInfo::JSRInfo):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructures):
+ (JSC::CodeBlock::derefStructures):
+ (JSC::CodeBlock::refStructures):
+ * VM/Machine.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::Interpreter::resolve):
+ (JSC::Interpreter::resolveSkip):
+ (JSC::Interpreter::resolveGlobal):
+ (JSC::Interpreter::resolveBase):
+ (JSC::Interpreter::resolveBaseAndProperty):
+ (JSC::Interpreter::resolveBaseAndFunc):
+ (JSC::Interpreter::slideRegisterWindowForCall):
+ (JSC::Interpreter::callEval):
+ (JSC::Interpreter::Interpreter):
+ (JSC::Interpreter::initialize):
+ (JSC::Interpreter::~Interpreter):
+ (JSC::Interpreter::dumpCallFrame):
+ (JSC::Interpreter::dumpRegisters):
+ (JSC::Interpreter::isOpcode):
+ (JSC::Interpreter::unwindCallFrame):
+ (JSC::Interpreter::throwException):
+ (JSC::Interpreter::execute):
+ (JSC::Interpreter::debug):
+ (JSC::Interpreter::resetTimeoutCheck):
+ (JSC::Interpreter::checkTimeout):
+ (JSC::Interpreter::createExceptionScope):
+ (JSC::Interpreter::tryCachePutByID):
+ (JSC::Interpreter::uncachePutByID):
+ (JSC::Interpreter::tryCacheGetByID):
+ (JSC::Interpreter::uncacheGetByID):
+ (JSC::Interpreter::privateExecute):
+ (JSC::Interpreter::retrieveArguments):
+ (JSC::Interpreter::retrieveCaller):
+ (JSC::Interpreter::retrieveLastCaller):
+ (JSC::Interpreter::findFunctionCallFrame):
+ (JSC::Interpreter::tryCTICachePutByID):
+ (JSC::Interpreter::tryCTICacheGetByID):
+ (JSC::):
+ (JSC::Interpreter::cti_op_convert_this):
+ (JSC::Interpreter::cti_op_end):
+ (JSC::Interpreter::cti_op_add):
+ (JSC::Interpreter::cti_op_pre_inc):
+ (JSC::Interpreter::cti_timeout_check):
+ (JSC::Interpreter::cti_register_file_check):
+ (JSC::Interpreter::cti_op_loop_if_less):
+ (JSC::Interpreter::cti_op_loop_if_lesseq):
+ (JSC::Interpreter::cti_op_new_object):
+ (JSC::Interpreter::cti_op_put_by_id):
+ (JSC::Interpreter::cti_op_put_by_id_second):
+ (JSC::Interpreter::cti_op_put_by_id_generic):
+ (JSC::Interpreter::cti_op_put_by_id_fail):
+ (JSC::Interpreter::cti_op_get_by_id):
+ (JSC::Interpreter::cti_op_get_by_id_second):
+ (JSC::Interpreter::cti_op_get_by_id_generic):
+ (JSC::Interpreter::cti_op_get_by_id_fail):
+ (JSC::Interpreter::cti_op_instanceof):
+ (JSC::Interpreter::cti_op_del_by_id):
+ (JSC::Interpreter::cti_op_mul):
+ (JSC::Interpreter::cti_op_new_func):
+ (JSC::Interpreter::cti_op_call_JSFunction):
+ (JSC::Interpreter::cti_op_call_arityCheck):
+ (JSC::Interpreter::cti_vm_dontLazyLinkCall):
+ (JSC::Interpreter::cti_vm_lazyLinkCall):
+ (JSC::Interpreter::cti_op_push_activation):
+ (JSC::Interpreter::cti_op_call_NotJSFunction):
+ (JSC::Interpreter::cti_op_create_arguments):
+ (JSC::Interpreter::cti_op_create_arguments_no_params):
+ (JSC::Interpreter::cti_op_tear_off_activation):
+ (JSC::Interpreter::cti_op_tear_off_arguments):
+ (JSC::Interpreter::cti_op_profile_will_call):
+ (JSC::Interpreter::cti_op_profile_did_call):
+ (JSC::Interpreter::cti_op_ret_scopeChain):
+ (JSC::Interpreter::cti_op_new_array):
+ (JSC::Interpreter::cti_op_resolve):
+ (JSC::Interpreter::cti_op_construct_JSConstruct):
+ (JSC::Interpreter::cti_op_construct_NotJSConstruct):
+ (JSC::Interpreter::cti_op_get_by_val):
+ (JSC::Interpreter::cti_op_resolve_func):
+ (JSC::Interpreter::cti_op_sub):
+ (JSC::Interpreter::cti_op_put_by_val):
+ (JSC::Interpreter::cti_op_put_by_val_array):
+ (JSC::Interpreter::cti_op_lesseq):
+ (JSC::Interpreter::cti_op_loop_if_true):
+ (JSC::Interpreter::cti_op_negate):
+ (JSC::Interpreter::cti_op_resolve_base):
+ (JSC::Interpreter::cti_op_resolve_skip):
+ (JSC::Interpreter::cti_op_resolve_global):
+ (JSC::Interpreter::cti_op_div):
+ (JSC::Interpreter::cti_op_pre_dec):
+ (JSC::Interpreter::cti_op_jless):
+ (JSC::Interpreter::cti_op_not):
+ (JSC::Interpreter::cti_op_jtrue):
+ (JSC::Interpreter::cti_op_post_inc):
+ (JSC::Interpreter::cti_op_eq):
+ (JSC::Interpreter::cti_op_lshift):
+ (JSC::Interpreter::cti_op_bitand):
+ (JSC::Interpreter::cti_op_rshift):
+ (JSC::Interpreter::cti_op_bitnot):
+ (JSC::Interpreter::cti_op_resolve_with_base):
+ (JSC::Interpreter::cti_op_new_func_exp):
+ (JSC::Interpreter::cti_op_mod):
+ (JSC::Interpreter::cti_op_less):
+ (JSC::Interpreter::cti_op_neq):
+ (JSC::Interpreter::cti_op_post_dec):
+ (JSC::Interpreter::cti_op_urshift):
+ (JSC::Interpreter::cti_op_bitxor):
+ (JSC::Interpreter::cti_op_new_regexp):
+ (JSC::Interpreter::cti_op_bitor):
+ (JSC::Interpreter::cti_op_call_eval):
+ (JSC::Interpreter::cti_op_throw):
+ (JSC::Interpreter::cti_op_get_pnames):
+ (JSC::Interpreter::cti_op_next_pname):
+ (JSC::Interpreter::cti_op_push_scope):
+ (JSC::Interpreter::cti_op_pop_scope):
+ (JSC::Interpreter::cti_op_typeof):
+ (JSC::Interpreter::cti_op_is_undefined):
+ (JSC::Interpreter::cti_op_is_boolean):
+ (JSC::Interpreter::cti_op_is_number):
+ (JSC::Interpreter::cti_op_is_string):
+ (JSC::Interpreter::cti_op_is_object):
+ (JSC::Interpreter::cti_op_is_function):
+ (JSC::Interpreter::cti_op_stricteq):
+ (JSC::Interpreter::cti_op_nstricteq):
+ (JSC::Interpreter::cti_op_to_jsnumber):
+ (JSC::Interpreter::cti_op_in):
+ (JSC::Interpreter::cti_op_push_new_scope):
+ (JSC::Interpreter::cti_op_jmp_scopes):
+ (JSC::Interpreter::cti_op_put_by_index):
+ (JSC::Interpreter::cti_op_switch_imm):
+ (JSC::Interpreter::cti_op_switch_char):
+ (JSC::Interpreter::cti_op_switch_string):
+ (JSC::Interpreter::cti_op_del_by_val):
+ (JSC::Interpreter::cti_op_put_getter):
+ (JSC::Interpreter::cti_op_put_setter):
+ (JSC::Interpreter::cti_op_new_error):
+ (JSC::Interpreter::cti_op_debug):
+ (JSC::Interpreter::cti_vm_throw):
+ * VM/Machine.h:
+ * VM/Register.h:
+ * VM/SamplingTool.cpp:
+ (JSC::SamplingTool::dump):
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::SamplingTool):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::generate):
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ * jsc.cpp:
+ (runWithScripts):
+ * masm/X86Assembler.h:
+ (JSC::AssemblerBuffer::executableCopy):
+ (JSC::X86Assembler::executableCopy):
+ * runtime/ExecState.h:
+ (JSC::ExecState::interpreter):
+ * runtime/JSCell.h:
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSImmediate.h:
+ * runtime/JSString.h:
+ * runtime/JSValue.h:
+ * runtime/JSVariableObject.h:
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::~RegExp):
+ (JSC::RegExp::match):
+ * runtime/RegExp.h:
+ * wrec/CharacterClassConstructor.cpp:
+ * wrec/CharacterClassConstructor.h:
+ * wrec/WREC.cpp:
+ (JSC::WREC::compileRegExp):
+ * wrec/WREC.h:
+ (JSC::WREC::Generator::Generator):
+ (JSC::WREC::Parser::):
+ (JSC::WREC::Parser::Parser):
+ (JSC::WREC::Parser::parseAlternative):
+
+2008-11-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+ Remove use of static C++ objects that are destroyed at exit time (destructors)
+
+ Conditionally have the DEFINE_STATIC_LOCAL workaround <rdar://problem/6354696>
+ (Codegen issue with C++ static reference in gcc build 5465) based upon the compiler
+ build versions. It will use the:
+ static T& = *new T;
+ style for all other compilers.
+
+ * wtf/StdLibExtras.h:
+
+2008-11-16 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22290
+ Remove cross-heap GC and MessagePort multi-threading support
+
+ It is broken (and may not be implementable at all), and no longer needed, as we
+ don't use MessagePorts for communication with workers any more.
+
+ * JavaScriptCore.exp:
+ * runtime/Collector.cpp:
+ (JSC::Heap::collect):
+ * runtime/JSGlobalObject.cpp:
+ * runtime/JSGlobalObject.h:
+ Remove hooks for cross-heap GC.
+
+2008-11-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Cleanup jsc command line code a little.
+
+ * jsc.cpp:
+ (functionQuit):
+ (main): Use standard exit status macros
+ (cleanupGlobalData): Factor out cleanup code into this function.
+ (printUsageStatement): Use standard exit status macros.
+
+2008-11-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Cleanup BytecodeGenerator constructors.
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ * bytecompiler/CodeGenerator.h:
+ * parser/Nodes.cpp:
+ (JSC::ProgramNode::generateBytecode):
+
+2008-11-15 Darin Adler <darin@apple.com>
+
+ Rubber stamped by Geoff Garen.
+
+ - do the long-planned StructureID -> Structure rename
+
+ * API/JSCallbackConstructor.cpp:
+ (JSC::JSCallbackConstructor::JSCallbackConstructor):
+ * API/JSCallbackConstructor.h:
+ (JSC::JSCallbackConstructor::createStructure):
+ * API/JSCallbackFunction.h:
+ (JSC::JSCallbackFunction::createStructure):
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::createStructure):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::JSCallbackObject):
+ * API/JSValueRef.cpp:
+ (JSValueIsInstanceOfConstructor):
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.scons:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/CTI.cpp:
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::transitionWillNeedStorageRealloc):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ * VM/CTI.h:
+ (JSC::CTI::compileGetByIdSelf):
+ (JSC::CTI::compileGetByIdProto):
+ (JSC::CTI::compileGetByIdChain):
+ (JSC::CTI::compilePutByIdReplace):
+ (JSC::CTI::compilePutByIdTransition):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructure):
+ (JSC::CodeBlock::printStructures):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::derefStructures):
+ (JSC::CodeBlock::refStructures):
+ * VM/CodeBlock.h:
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+ (JSC::Instruction::):
+ * VM/Machine.cpp:
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::BytecodeInterpreter::resolveGlobal):
+ (JSC::BytecodeInterpreter::BytecodeInterpreter):
+ (JSC::cachePrototypeChain):
+ (JSC::BytecodeInterpreter::tryCachePutByID):
+ (JSC::BytecodeInterpreter::uncachePutByID):
+ (JSC::BytecodeInterpreter::tryCacheGetByID):
+ (JSC::BytecodeInterpreter::uncacheGetByID):
+ (JSC::BytecodeInterpreter::privateExecute):
+ (JSC::BytecodeInterpreter::tryCTICachePutByID):
+ (JSC::BytecodeInterpreter::tryCTICacheGetByID):
+ (JSC::BytecodeInterpreter::cti_op_instanceof):
+ (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct):
+ (JSC::BytecodeInterpreter::cti_op_resolve_global):
+ (JSC::BytecodeInterpreter::cti_op_is_undefined):
+ * runtime/Arguments.h:
+ (JSC::Arguments::createStructure):
+ * runtime/ArrayConstructor.cpp:
+ (JSC::ArrayConstructor::ArrayConstructor):
+ * runtime/ArrayConstructor.h:
+ * runtime/ArrayPrototype.cpp:
+ (JSC::ArrayPrototype::ArrayPrototype):
+ * runtime/ArrayPrototype.h:
+ * runtime/BatchedTransitionOptimizer.h:
+ (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
+ (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
+ * runtime/BooleanConstructor.cpp:
+ (JSC::BooleanConstructor::BooleanConstructor):
+ * runtime/BooleanConstructor.h:
+ * runtime/BooleanObject.cpp:
+ (JSC::BooleanObject::BooleanObject):
+ * runtime/BooleanObject.h:
+ * runtime/BooleanPrototype.cpp:
+ (JSC::BooleanPrototype::BooleanPrototype):
+ * runtime/BooleanPrototype.h:
+ * runtime/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ * runtime/DateConstructor.h:
+ * runtime/DateInstance.cpp:
+ (JSC::DateInstance::DateInstance):
+ * runtime/DateInstance.h:
+ * runtime/DatePrototype.cpp:
+ (JSC::DatePrototype::DatePrototype):
+ * runtime/DatePrototype.h:
+ (JSC::DatePrototype::createStructure):
+ * runtime/ErrorConstructor.cpp:
+ (JSC::ErrorConstructor::ErrorConstructor):
+ * runtime/ErrorConstructor.h:
+ * runtime/ErrorInstance.cpp:
+ (JSC::ErrorInstance::ErrorInstance):
+ * runtime/ErrorInstance.h:
+ * runtime/ErrorPrototype.cpp:
+ (JSC::ErrorPrototype::ErrorPrototype):
+ * runtime/ErrorPrototype.h:
+ * runtime/FunctionConstructor.cpp:
+ (JSC::FunctionConstructor::FunctionConstructor):
+ * runtime/FunctionConstructor.h:
+ * runtime/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::FunctionPrototype):
+ (JSC::FunctionPrototype::addFunctionProperties):
+ * runtime/FunctionPrototype.h:
+ (JSC::FunctionPrototype::createStructure):
+ * runtime/GlobalEvalFunction.cpp:
+ (JSC::GlobalEvalFunction::GlobalEvalFunction):
+ * runtime/GlobalEvalFunction.h:
+ * runtime/Identifier.h:
+ * runtime/InternalFunction.cpp:
+ (JSC::InternalFunction::InternalFunction):
+ * runtime/InternalFunction.h:
+ (JSC::InternalFunction::createStructure):
+ (JSC::InternalFunction::InternalFunction):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::JSActivation):
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::createStructure):
+ * runtime/JSArray.cpp:
+ (JSC::JSArray::JSArray):
+ * runtime/JSArray.h:
+ (JSC::JSArray::createStructure):
+ * runtime/JSCell.h:
+ (JSC::JSCell::JSCell):
+ (JSC::JSCell::isObject):
+ (JSC::JSCell::isString):
+ (JSC::JSCell::structure):
+ (JSC::JSValue::needsThisConversion):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::construct):
+ * runtime/JSFunction.h:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::createStructure):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::createLeaked):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::markIfNeeded):
+ (JSC::JSGlobalObject::reset):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObject):
+ (JSC::JSGlobalObject::argumentsStructure):
+ (JSC::JSGlobalObject::arrayStructure):
+ (JSC::JSGlobalObject::booleanObjectStructure):
+ (JSC::JSGlobalObject::callbackConstructorStructure):
+ (JSC::JSGlobalObject::callbackFunctionStructure):
+ (JSC::JSGlobalObject::callbackObjectStructure):
+ (JSC::JSGlobalObject::dateStructure):
+ (JSC::JSGlobalObject::emptyObjectStructure):
+ (JSC::JSGlobalObject::errorStructure):
+ (JSC::JSGlobalObject::functionStructure):
+ (JSC::JSGlobalObject::numberObjectStructure):
+ (JSC::JSGlobalObject::prototypeFunctionStructure):
+ (JSC::JSGlobalObject::regExpMatchesArrayStructure):
+ (JSC::JSGlobalObject::regExpStructure):
+ (JSC::JSGlobalObject::stringObjectStructure):
+ (JSC::JSGlobalObject::createStructure):
+ (JSC::Structure::prototypeForLookup):
+ * runtime/JSNotAnObject.h:
+ (JSC::JSNotAnObject::createStructure):
+ * runtime/JSNumberCell.h:
+ (JSC::JSNumberCell::createStructure):
+ (JSC::JSNumberCell::JSNumberCell):
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::put):
+ (JSC::JSObject::deleteProperty):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ (JSC::JSObject::getPropertyAttributes):
+ (JSC::JSObject::getPropertyNames):
+ (JSC::JSObject::removeDirect):
+ (JSC::JSObject::createInheritorID):
+ * runtime/JSObject.h:
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::hasCustomProperties):
+ (JSC::JSObject::hasGetterSetterProperties):
+ (JSC::JSObject::createStructure):
+ (JSC::JSObject::JSObject):
+ (JSC::JSObject::~JSObject):
+ (JSC::JSObject::prototype):
+ (JSC::JSObject::setPrototype):
+ (JSC::JSObject::setStructure):
+ (JSC::JSObject::inheritorID):
+ (JSC::JSObject::inlineGetOwnPropertySlot):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSCell::fastGetOwnPropertySlot):
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::putDirectWithoutTransition):
+ (JSC::JSObject::transitionTo):
+ * runtime/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::next):
+ * runtime/JSStaticScopeObject.h:
+ (JSC::JSStaticScopeObject::JSStaticScopeObject):
+ (JSC::JSStaticScopeObject::createStructure):
+ * runtime/JSString.h:
+ (JSC::JSString::JSString):
+ (JSC::JSString::createStructure):
+ * runtime/JSVariableObject.h:
+ (JSC::JSVariableObject::JSVariableObject):
+ * runtime/JSWrapperObject.h:
+ (JSC::JSWrapperObject::JSWrapperObject):
+ * runtime/MathObject.cpp:
+ (JSC::MathObject::MathObject):
+ * runtime/MathObject.h:
+ (JSC::MathObject::createStructure):
+ * runtime/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ * runtime/NativeErrorConstructor.h:
+ * runtime/NativeErrorPrototype.cpp:
+ (JSC::NativeErrorPrototype::NativeErrorPrototype):
+ * runtime/NativeErrorPrototype.h:
+ * runtime/NumberConstructor.cpp:
+ (JSC::NumberConstructor::NumberConstructor):
+ * runtime/NumberConstructor.h:
+ (JSC::NumberConstructor::createStructure):
+ * runtime/NumberObject.cpp:
+ (JSC::NumberObject::NumberObject):
+ * runtime/NumberObject.h:
+ * runtime/NumberPrototype.cpp:
+ (JSC::NumberPrototype::NumberPrototype):
+ * runtime/NumberPrototype.h:
+ * runtime/ObjectConstructor.cpp:
+ (JSC::ObjectConstructor::ObjectConstructor):
+ * runtime/ObjectConstructor.h:
+ * runtime/ObjectPrototype.cpp:
+ (JSC::ObjectPrototype::ObjectPrototype):
+ * runtime/ObjectPrototype.h:
+ * runtime/Operations.h:
+ (JSC::equalSlowCaseInline):
+ * runtime/PropertyNameArray.h:
+ (JSC::PropertyNameArrayData::setCachedStructure):
+ (JSC::PropertyNameArrayData::cachedStructure):
+ (JSC::PropertyNameArrayData::setCachedPrototypeChain):
+ (JSC::PropertyNameArrayData::cachedPrototypeChain):
+ (JSC::PropertyNameArrayData::PropertyNameArrayData):
+ * runtime/PrototypeFunction.cpp:
+ (JSC::PrototypeFunction::PrototypeFunction):
+ * runtime/PrototypeFunction.h:
+ * runtime/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::RegExpConstructor):
+ * runtime/RegExpConstructor.h:
+ (JSC::RegExpConstructor::createStructure):
+ * runtime/RegExpObject.cpp:
+ (JSC::RegExpObject::RegExpObject):
+ * runtime/RegExpObject.h:
+ (JSC::RegExpObject::createStructure):
+ * runtime/RegExpPrototype.cpp:
+ (JSC::RegExpPrototype::RegExpPrototype):
+ * runtime/RegExpPrototype.h:
+ * runtime/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+ * runtime/StringConstructor.h:
+ * runtime/StringObject.cpp:
+ (JSC::StringObject::StringObject):
+ * runtime/StringObject.h:
+ (JSC::StringObject::createStructure):
+ * runtime/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::create):
+ (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
+ (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
+ * runtime/StringPrototype.cpp:
+ (JSC::StringPrototype::StringPrototype):
+ * runtime/StringPrototype.h:
+ * runtime/Structure.cpp: Copied from JavaScriptCore/runtime/StructureID.cpp.
+ (JSC::Structure::dumpStatistics):
+ (JSC::Structure::Structure):
+ (JSC::Structure::~Structure):
+ (JSC::Structure::startIgnoringLeaks):
+ (JSC::Structure::stopIgnoringLeaks):
+ (JSC::Structure::materializePropertyMap):
+ (JSC::Structure::getEnumerablePropertyNames):
+ (JSC::Structure::clearEnumerationCache):
+ (JSC::Structure::growPropertyStorageCapacity):
+ (JSC::Structure::addPropertyTransitionToExistingStructure):
+ (JSC::Structure::addPropertyTransition):
+ (JSC::Structure::removePropertyTransition):
+ (JSC::Structure::changePrototypeTransition):
+ (JSC::Structure::getterSetterTransition):
+ (JSC::Structure::toDictionaryTransition):
+ (JSC::Structure::fromDictionaryTransition):
+ (JSC::Structure::addPropertyWithoutTransition):
+ (JSC::Structure::removePropertyWithoutTransition):
+ (JSC::Structure::createCachedPrototypeChain):
+ (JSC::Structure::checkConsistency):
+ (JSC::Structure::copyPropertyTable):
+ (JSC::Structure::get):
+ (JSC::Structure::put):
+ (JSC::Structure::remove):
+ (JSC::Structure::insertIntoPropertyMapHashTable):
+ (JSC::Structure::createPropertyMapHashTable):
+ (JSC::Structure::expandPropertyMapHashTable):
+ (JSC::Structure::rehashPropertyMapHashTable):
+ (JSC::Structure::getEnumerablePropertyNamesInternal):
+ * runtime/Structure.h: Copied from JavaScriptCore/runtime/StructureID.h.
+ (JSC::Structure::create):
+ (JSC::Structure::previousID):
+ (JSC::Structure::setCachedPrototypeChain):
+ (JSC::Structure::cachedPrototypeChain):
+ (JSC::Structure::):
+ (JSC::Structure::get):
+ * runtime/StructureChain.cpp: Copied from JavaScriptCore/runtime/StructureIDChain.cpp.
+ (JSC::StructureChain::StructureChain):
+ (JSC::structureChainsAreEqual):
+ * runtime/StructureChain.h: Copied from JavaScriptCore/runtime/StructureIDChain.h.
+ (JSC::StructureChain::create):
+ (JSC::StructureChain::head):
+ * runtime/StructureID.cpp: Removed.
+ * runtime/StructureID.h: Removed.
+ * runtime/StructureIDChain.cpp: Removed.
+ * runtime/StructureIDChain.h: Removed.
+ * runtime/StructureIDTransitionTable.h: Removed.
+ * runtime/StructureTransitionTable.h: Copied from JavaScriptCore/runtime/StructureIDTransitionTable.h.
+
+2008-11-15 Darin Adler <darin@apple.com>
+
+ - fix non-WREC build
+
+ * runtime/RegExp.cpp: Put "using namespace WREC" inside #if ENABLE(WREC).
+
+2008-11-15 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Timothy Hatcher.
+
+ As ThreadingNone doesn't implement threads, isMainThread should return true,
+ not false.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22285
+
+ * wtf/ThreadingNone.cpp:
+ (WTF::isMainThread):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved all WREC-related code into WREC.cpp and put it in a WREC namespace.
+ Removed the WREC prefix from class names.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/Machine.h:
+ (JSC::BytecodeInterpreter::assemblerBuffer):
+ * masm/X86Assembler.h:
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+ * wrec/CharacterClassConstructor.cpp:
+ * wrec/CharacterClassConstructor.h:
+ * wrec/WREC.cpp:
+ (WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
+ (WREC::GeneratePatternCharacterFunctor::generateAtom):
+ (WREC::GeneratePatternCharacterFunctor::backtrack):
+ (WREC::GenerateCharacterClassFunctor::generateAtom):
+ (WREC::GenerateCharacterClassFunctor::backtrack):
+ (WREC::GenerateBackreferenceFunctor::generateAtom):
+ (WREC::GenerateBackreferenceFunctor::backtrack):
+ (WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
+ (WREC::GenerateParenthesesNonGreedyFunctor::backtrack):
+ (WREC::Generator::generateBacktrack1):
+ (WREC::Generator::generateBacktrackBackreference):
+ (WREC::Generator::generateBackreferenceQuantifier):
+ (WREC::Generator::generateNonGreedyQuantifier):
+ (WREC::Generator::generateGreedyQuantifier):
+ (WREC::Generator::generatePatternCharacter):
+ (WREC::Generator::generateCharacterClassInvertedRange):
+ (WREC::Generator::generateCharacterClassInverted):
+ (WREC::Generator::generateCharacterClass):
+ (WREC::Generator::generateParentheses):
+ (WREC::Generator::generateParenthesesNonGreedy):
+ (WREC::Generator::generateParenthesesResetTrampoline):
+ (WREC::Generator::generateAssertionBOL):
+ (WREC::Generator::generateAssertionEOL):
+ (WREC::Generator::generateAssertionWordBoundary):
+ (WREC::Generator::generateBackreference):
+ (WREC::Generator::generateDisjunction):
+ (WREC::Generator::terminateDisjunction):
+ (WREC::Parser::parseGreedyQuantifier):
+ (WREC::Parser::parseQuantifier):
+ (WREC::Parser::parsePatternCharacterQualifier):
+ (WREC::Parser::parseCharacterClassQuantifier):
+ (WREC::Parser::parseBackreferenceQuantifier):
+ (WREC::Parser::parseParentheses):
+ (WREC::Parser::parseCharacterClass):
+ (WREC::Parser::parseOctalEscape):
+ (WREC::Parser::parseEscape):
+ (WREC::Parser::parseTerm):
+ (WREC::Parser::parseDisjunction):
+ (WREC::compileRegExp):
+ * wrec/WREC.h:
+ (WREC::Generator::Generator):
+ (WREC::Parser::Parser):
+ (WREC::Parser::parseAlternative):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Changed another case of "m_jit" to "m_assembler".
+
+ * VM/CTI.cpp:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+ (JSC::WRECGenerator::WRECGenerator):
+ (JSC::WRECParser::WRECParser):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed "jit" to "assembler" and, for brevity, replaced *jit.* with __
+ using a macro.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetVirtualRegister):
+ (JSC::CTI::emitPutCTIArgFromVirtualRegister):
+ (JSC::CTI::emitPutCTIArg):
+ (JSC::CTI::emitGetCTIArg):
+ (JSC::CTI::emitPutCTIArgConstant):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutVirtualRegister):
+ (JSC::CTI::emitInitRegister):
+ (JSC::CTI::emitAllocateNumber):
+ (JSC::CTI::emitNakedCall):
+ (JSC::CTI::emitNakedFastCall):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::linkSlowCaseIfNotJSCell):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::CTI::emitFastArithReTagImmediate):
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ (JSC::CTI::emitFastArithImmToInt):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::emitFastArithIntToImmNoCheck):
+ (JSC::CTI::emitArithIntToImmWithJump):
+ (JSC::CTI::emitTagAsBoolImmediate):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileLinkPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::emitGetVariableObjectRegister):
+ (JSC::CTI::emitPutVariableObjectRegister):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generateBacktrack1):
+ (JSC::WRECGenerator::generateBacktrackBackreference):
+ (JSC::WRECGenerator::generateBackreferenceQuantifier):
+ (JSC::WRECGenerator::generateNonGreedyQuantifier):
+ (JSC::WRECGenerator::generateGreedyQuantifier):
+ (JSC::WRECGenerator::generatePatternCharacter):
+ (JSC::WRECGenerator::generateCharacterClassInvertedRange):
+ (JSC::WRECGenerator::generateCharacterClassInverted):
+ (JSC::WRECGenerator::generateCharacterClass):
+ (JSC::WRECGenerator::generateParentheses):
+ (JSC::WRECGenerator::generateParenthesesNonGreedy):
+ (JSC::WRECGenerator::generateParenthesesResetTrampoline):
+ (JSC::WRECGenerator::generateAssertionBOL):
+ (JSC::WRECGenerator::generateAssertionEOL):
+ (JSC::WRECGenerator::generateAssertionWordBoundary):
+ (JSC::WRECGenerator::generateBackreference):
+ (JSC::WRECGenerator::generateDisjunction):
+ (JSC::WRECGenerator::terminateDisjunction):
+
+2008-11-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove dead method declaration.
+
+ * bytecompiler/CodeGenerator.h:
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed LabelID to Label, Label::isForwardLabel to Label::isForward.
+
+ * VM/LabelID.h:
+ (JSC::Label::Label):
+ (JSC::Label::isForward):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::newLabel):
+ (JSC::BytecodeGenerator::emitLabel):
+ (JSC::BytecodeGenerator::emitJump):
+ (JSC::BytecodeGenerator::emitJumpIfTrue):
+ (JSC::BytecodeGenerator::emitJumpIfFalse):
+ (JSC::BytecodeGenerator::pushFinallyContext):
+ (JSC::BytecodeGenerator::emitComplexJumpScopes):
+ (JSC::BytecodeGenerator::emitJumpScopes):
+ (JSC::BytecodeGenerator::emitNextPropertyName):
+ (JSC::BytecodeGenerator::emitCatch):
+ (JSC::BytecodeGenerator::emitJumpSubroutine):
+ (JSC::prepareJumpTableForImmediateSwitch):
+ (JSC::prepareJumpTableForCharacterSwitch):
+ (JSC::prepareJumpTableForStringSwitch):
+ (JSC::BytecodeGenerator::endSwitch):
+ * bytecompiler/CodeGenerator.h:
+ * bytecompiler/LabelScope.h:
+ (JSC::LabelScope::LabelScope):
+ (JSC::LabelScope::breakTarget):
+ (JSC::LabelScope::continueTarget):
+ * parser/Nodes.cpp:
+ (JSC::LogicalOpNode::emitBytecode):
+ (JSC::ConditionalNode::emitBytecode):
+ (JSC::IfNode::emitBytecode):
+ (JSC::IfElseNode::emitBytecode):
+ (JSC::DoWhileNode::emitBytecode):
+ (JSC::WhileNode::emitBytecode):
+ (JSC::ForNode::emitBytecode):
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::CaseBlockNode::emitBytecodeForBlock):
+ (JSC::TryNode::emitBytecode):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed JITCodeBuffer to AssemblerBuffer and renamed its data members
+ to be more like the rest of our buffer classes, with a size and a
+ capacity.
+
+ Added an assert in the unchecked put case to match the test in the checked
+ put case.
+
+ Changed a C-style cast to a C++-style cast.
+
+ Renamed MAX_INSTRUCTION_SIZE to maxInstructionSize.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileRegExp):
+ * VM/Machine.cpp:
+ (JSC::BytecodeInterpreter::BytecodeInterpreter):
+ * VM/Machine.h:
+ (JSC::BytecodeInterpreter::assemblerBuffer):
+ * masm/X86Assembler.h:
+ (JSC::AssemblerBuffer::AssemblerBuffer):
+ (JSC::AssemblerBuffer::~AssemblerBuffer):
+ (JSC::AssemblerBuffer::ensureSpace):
+ (JSC::AssemblerBuffer::isAligned):
+ (JSC::AssemblerBuffer::putByteUnchecked):
+ (JSC::AssemblerBuffer::putByte):
+ (JSC::AssemblerBuffer::putShortUnchecked):
+ (JSC::AssemblerBuffer::putShort):
+ (JSC::AssemblerBuffer::putIntUnchecked):
+ (JSC::AssemblerBuffer::putInt):
+ (JSC::AssemblerBuffer::data):
+ (JSC::AssemblerBuffer::size):
+ (JSC::AssemblerBuffer::reset):
+ (JSC::AssemblerBuffer::copy):
+ (JSC::AssemblerBuffer::grow):
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::X86Assembler):
+ (JSC::X86Assembler::testl_i32r):
+ (JSC::X86Assembler::movl_mr):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::movl_i32m):
+ (JSC::X86Assembler::emitCall):
+ (JSC::X86Assembler::label):
+ (JSC::X86Assembler::emitUnlinkedJmp):
+ (JSC::X86Assembler::emitUnlinkedJne):
+ (JSC::X86Assembler::emitUnlinkedJe):
+ (JSC::X86Assembler::emitUnlinkedJl):
+ (JSC::X86Assembler::emitUnlinkedJb):
+ (JSC::X86Assembler::emitUnlinkedJle):
+ (JSC::X86Assembler::emitUnlinkedJbe):
+ (JSC::X86Assembler::emitUnlinkedJge):
+ (JSC::X86Assembler::emitUnlinkedJg):
+ (JSC::X86Assembler::emitUnlinkedJa):
+ (JSC::X86Assembler::emitUnlinkedJae):
+ (JSC::X86Assembler::emitUnlinkedJo):
+ (JSC::X86Assembler::emitUnlinkedJp):
+ (JSC::X86Assembler::emitUnlinkedJs):
+ (JSC::X86Assembler::link):
+ (JSC::X86Assembler::emitModRm_rr):
+ (JSC::X86Assembler::emitModRm_rm):
+ (JSC::X86Assembler::emitModRm_opr):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Suggested by Maciej Stachowiak.
+
+ Reverted most "opcode" => "bytecode" renames. We use "bytecode" as a
+ mass noun to refer to a stream of instructions. Each instruction may be
+ an opcode or an operand.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructureIDs):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::derefStructureIDs):
+ (JSC::CodeBlock::refStructureIDs):
+ * VM/CodeBlock.h:
+ * VM/ExceptionHelpers.cpp:
+ (JSC::createNotAnObjectError):
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+ (JSC::Instruction::):
+ * VM/Machine.cpp:
+ (JSC::BytecodeInterpreter::isOpcode):
+ (JSC::BytecodeInterpreter::throwException):
+ (JSC::BytecodeInterpreter::tryCachePutByID):
+ (JSC::BytecodeInterpreter::uncachePutByID):
+ (JSC::BytecodeInterpreter::tryCacheGetByID):
+ (JSC::BytecodeInterpreter::uncacheGetByID):
+ (JSC::BytecodeInterpreter::privateExecute):
+ (JSC::BytecodeInterpreter::tryCTICachePutByID):
+ (JSC::BytecodeInterpreter::tryCTICacheGetByID):
+ * VM/Machine.h:
+ (JSC::BytecodeInterpreter::getOpcode):
+ (JSC::BytecodeInterpreter::getOpcodeID):
+ (JSC::BytecodeInterpreter::isCallBytecode):
+ * VM/Opcode.cpp:
+ (JSC::):
+ (JSC::OpcodeStats::OpcodeStats):
+ (JSC::compareOpcodeIndices):
+ (JSC::compareOpcodePairIndices):
+ (JSC::OpcodeStats::~OpcodeStats):
+ (JSC::OpcodeStats::recordInstruction):
+ (JSC::OpcodeStats::resetLastInstruction):
+ * VM/Opcode.h:
+ (JSC::):
+ (JSC::padOpcodeName):
+ * VM/SamplingTool.cpp:
+ (JSC::ScopeSampleRecord::sample):
+ (JSC::SamplingTool::run):
+ (JSC::compareOpcodeIndicesSampling):
+ (JSC::SamplingTool::dump):
+ * VM/SamplingTool.h:
+ (JSC::ScopeSampleRecord::ScopeSampleRecord):
+ (JSC::SamplingTool::SamplingTool):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::emitLabel):
+ (JSC::BytecodeGenerator::emitOpcode):
+ (JSC::BytecodeGenerator::emitJump):
+ (JSC::BytecodeGenerator::emitJumpIfTrue):
+ (JSC::BytecodeGenerator::emitJumpIfFalse):
+ (JSC::BytecodeGenerator::emitMove):
+ (JSC::BytecodeGenerator::emitUnaryOp):
+ (JSC::BytecodeGenerator::emitPreInc):
+ (JSC::BytecodeGenerator::emitPreDec):
+ (JSC::BytecodeGenerator::emitPostInc):
+ (JSC::BytecodeGenerator::emitPostDec):
+ (JSC::BytecodeGenerator::emitBinaryOp):
+ (JSC::BytecodeGenerator::emitEqualityOp):
+ (JSC::BytecodeGenerator::emitUnexpectedLoad):
+ (JSC::BytecodeGenerator::emitInstanceOf):
+ (JSC::BytecodeGenerator::emitResolve):
+ (JSC::BytecodeGenerator::emitGetScopedVar):
+ (JSC::BytecodeGenerator::emitPutScopedVar):
+ (JSC::BytecodeGenerator::emitResolveBase):
+ (JSC::BytecodeGenerator::emitResolveWithBase):
+ (JSC::BytecodeGenerator::emitResolveFunction):
+ (JSC::BytecodeGenerator::emitGetById):
+ (JSC::BytecodeGenerator::emitPutById):
+ (JSC::BytecodeGenerator::emitPutGetter):
+ (JSC::BytecodeGenerator::emitPutSetter):
+ (JSC::BytecodeGenerator::emitDeleteById):
+ (JSC::BytecodeGenerator::emitGetByVal):
+ (JSC::BytecodeGenerator::emitPutByVal):
+ (JSC::BytecodeGenerator::emitDeleteByVal):
+ (JSC::BytecodeGenerator::emitPutByIndex):
+ (JSC::BytecodeGenerator::emitNewObject):
+ (JSC::BytecodeGenerator::emitNewArray):
+ (JSC::BytecodeGenerator::emitNewFunction):
+ (JSC::BytecodeGenerator::emitNewRegExp):
+ (JSC::BytecodeGenerator::emitNewFunctionExpression):
+ (JSC::BytecodeGenerator::emitCall):
+ (JSC::BytecodeGenerator::emitReturn):
+ (JSC::BytecodeGenerator::emitUnaryNoDstOp):
+ (JSC::BytecodeGenerator::emitConstruct):
+ (JSC::BytecodeGenerator::emitPopScope):
+ (JSC::BytecodeGenerator::emitDebugHook):
+ (JSC::BytecodeGenerator::emitComplexJumpScopes):
+ (JSC::BytecodeGenerator::emitJumpScopes):
+ (JSC::BytecodeGenerator::emitNextPropertyName):
+ (JSC::BytecodeGenerator::emitCatch):
+ (JSC::BytecodeGenerator::emitNewError):
+ (JSC::BytecodeGenerator::emitJumpSubroutine):
+ (JSC::BytecodeGenerator::emitSubroutineReturn):
+ (JSC::BytecodeGenerator::emitPushNewScope):
+ (JSC::BytecodeGenerator::beginSwitch):
+ * bytecompiler/CodeGenerator.h:
+ * jsc.cpp:
+ (runWithScripts):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::emitModRm_opr):
+ (JSC::X86Assembler::emitModRm_opr_Unchecked):
+ (JSC::X86Assembler::emitModRm_opm):
+ (JSC::X86Assembler::emitModRm_opm_Unchecked):
+ (JSC::X86Assembler::emitModRm_opmsib):
+ * parser/Nodes.cpp:
+ (JSC::UnaryOpNode::emitBytecode):
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::ReverseBinaryOpNode::emitBytecode):
+ (JSC::ThrowableBinaryOpNode::emitBytecode):
+ (JSC::emitReadModifyAssignment):
+ (JSC::ScopeNode::ScopeNode):
+ * parser/Nodes.h:
+ (JSC::UnaryPlusNode::):
+ (JSC::NegateNode::):
+ (JSC::BitwiseNotNode::):
+ (JSC::LogicalNotNode::):
+ (JSC::MultNode::):
+ (JSC::DivNode::):
+ (JSC::ModNode::):
+ (JSC::AddNode::):
+ (JSC::SubNode::):
+ (JSC::LeftShiftNode::):
+ (JSC::RightShiftNode::):
+ (JSC::UnsignedRightShiftNode::):
+ (JSC::LessNode::):
+ (JSC::GreaterNode::):
+ (JSC::LessEqNode::):
+ (JSC::GreaterEqNode::):
+ (JSC::InstanceOfNode::):
+ (JSC::InNode::):
+ (JSC::EqualNode::):
+ (JSC::NotEqualNode::):
+ (JSC::StrictEqualNode::):
+ (JSC::NotStrictEqualNode::):
+ (JSC::BitAndNode::):
+ (JSC::BitOrNode::):
+ (JSC::BitXOrNode::):
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::fromDictionaryTransition):
+ * wtf/Platform.h:
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renames:
+
+ CodeGenerator => BytecodeGenerator
+ emitCodeForBlock => emitBytecodeForBlock
+ generatedByteCode => generatedBytecode
+ generateCode => generateBytecode
+
+ * JavaScriptCore.exp:
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::BytecodeGenerator::setDumpsGeneratedCode):
+ (JSC::BytecodeGenerator::generate):
+ (JSC::BytecodeGenerator::addVar):
+ (JSC::BytecodeGenerator::addGlobalVar):
+ (JSC::BytecodeGenerator::allocateConstants):
+ (JSC::BytecodeGenerator::BytecodeGenerator):
+ (JSC::BytecodeGenerator::addParameter):
+ (JSC::BytecodeGenerator::registerFor):
+ (JSC::BytecodeGenerator::constRegisterFor):
+ (JSC::BytecodeGenerator::isLocal):
+ (JSC::BytecodeGenerator::isLocalConstant):
+ (JSC::BytecodeGenerator::newRegister):
+ (JSC::BytecodeGenerator::newTemporary):
+ (JSC::BytecodeGenerator::highestUsedRegister):
+ (JSC::BytecodeGenerator::newLabelScope):
+ (JSC::BytecodeGenerator::newLabel):
+ (JSC::BytecodeGenerator::emitLabel):
+ (JSC::BytecodeGenerator::emitBytecode):
+ (JSC::BytecodeGenerator::retrieveLastBinaryOp):
+ (JSC::BytecodeGenerator::retrieveLastUnaryOp):
+ (JSC::BytecodeGenerator::rewindBinaryOp):
+ (JSC::BytecodeGenerator::rewindUnaryOp):
+ (JSC::BytecodeGenerator::emitJump):
+ (JSC::BytecodeGenerator::emitJumpIfTrue):
+ (JSC::BytecodeGenerator::emitJumpIfFalse):
+ (JSC::BytecodeGenerator::addConstant):
+ (JSC::BytecodeGenerator::addUnexpectedConstant):
+ (JSC::BytecodeGenerator::addRegExp):
+ (JSC::BytecodeGenerator::emitMove):
+ (JSC::BytecodeGenerator::emitUnaryOp):
+ (JSC::BytecodeGenerator::emitPreInc):
+ (JSC::BytecodeGenerator::emitPreDec):
+ (JSC::BytecodeGenerator::emitPostInc):
+ (JSC::BytecodeGenerator::emitPostDec):
+ (JSC::BytecodeGenerator::emitBinaryOp):
+ (JSC::BytecodeGenerator::emitEqualityOp):
+ (JSC::BytecodeGenerator::emitLoad):
+ (JSC::BytecodeGenerator::emitUnexpectedLoad):
+ (JSC::BytecodeGenerator::findScopedProperty):
+ (JSC::BytecodeGenerator::emitInstanceOf):
+ (JSC::BytecodeGenerator::emitResolve):
+ (JSC::BytecodeGenerator::emitGetScopedVar):
+ (JSC::BytecodeGenerator::emitPutScopedVar):
+ (JSC::BytecodeGenerator::emitResolveBase):
+ (JSC::BytecodeGenerator::emitResolveWithBase):
+ (JSC::BytecodeGenerator::emitResolveFunction):
+ (JSC::BytecodeGenerator::emitGetById):
+ (JSC::BytecodeGenerator::emitPutById):
+ (JSC::BytecodeGenerator::emitPutGetter):
+ (JSC::BytecodeGenerator::emitPutSetter):
+ (JSC::BytecodeGenerator::emitDeleteById):
+ (JSC::BytecodeGenerator::emitGetByVal):
+ (JSC::BytecodeGenerator::emitPutByVal):
+ (JSC::BytecodeGenerator::emitDeleteByVal):
+ (JSC::BytecodeGenerator::emitPutByIndex):
+ (JSC::BytecodeGenerator::emitNewObject):
+ (JSC::BytecodeGenerator::emitNewArray):
+ (JSC::BytecodeGenerator::emitNewFunction):
+ (JSC::BytecodeGenerator::emitNewRegExp):
+ (JSC::BytecodeGenerator::emitNewFunctionExpression):
+ (JSC::BytecodeGenerator::emitCall):
+ (JSC::BytecodeGenerator::emitCallEval):
+ (JSC::BytecodeGenerator::emitReturn):
+ (JSC::BytecodeGenerator::emitUnaryNoDstOp):
+ (JSC::BytecodeGenerator::emitConstruct):
+ (JSC::BytecodeGenerator::emitPushScope):
+ (JSC::BytecodeGenerator::emitPopScope):
+ (JSC::BytecodeGenerator::emitDebugHook):
+ (JSC::BytecodeGenerator::pushFinallyContext):
+ (JSC::BytecodeGenerator::popFinallyContext):
+ (JSC::BytecodeGenerator::breakTarget):
+ (JSC::BytecodeGenerator::continueTarget):
+ (JSC::BytecodeGenerator::emitComplexJumpScopes):
+ (JSC::BytecodeGenerator::emitJumpScopes):
+ (JSC::BytecodeGenerator::emitNextPropertyName):
+ (JSC::BytecodeGenerator::emitCatch):
+ (JSC::BytecodeGenerator::emitNewError):
+ (JSC::BytecodeGenerator::emitJumpSubroutine):
+ (JSC::BytecodeGenerator::emitSubroutineReturn):
+ (JSC::BytecodeGenerator::emitPushNewScope):
+ (JSC::BytecodeGenerator::beginSwitch):
+ (JSC::BytecodeGenerator::endSwitch):
+ (JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):
+ * bytecompiler/CodeGenerator.h:
+ * jsc.cpp:
+ (runWithScripts):
+ * parser/Nodes.cpp:
+ (JSC::ThrowableExpressionData::emitThrowError):
+ (JSC::NullNode::emitBytecode):
+ (JSC::BooleanNode::emitBytecode):
+ (JSC::NumberNode::emitBytecode):
+ (JSC::StringNode::emitBytecode):
+ (JSC::RegExpNode::emitBytecode):
+ (JSC::ThisNode::emitBytecode):
+ (JSC::ResolveNode::isPure):
+ (JSC::ResolveNode::emitBytecode):
+ (JSC::ArrayNode::emitBytecode):
+ (JSC::ObjectLiteralNode::emitBytecode):
+ (JSC::PropertyListNode::emitBytecode):
+ (JSC::BracketAccessorNode::emitBytecode):
+ (JSC::DotAccessorNode::emitBytecode):
+ (JSC::ArgumentListNode::emitBytecode):
+ (JSC::NewExprNode::emitBytecode):
+ (JSC::EvalFunctionCallNode::emitBytecode):
+ (JSC::FunctionCallValueNode::emitBytecode):
+ (JSC::FunctionCallResolveNode::emitBytecode):
+ (JSC::FunctionCallBracketNode::emitBytecode):
+ (JSC::FunctionCallDotNode::emitBytecode):
+ (JSC::emitPreIncOrDec):
+ (JSC::emitPostIncOrDec):
+ (JSC::PostfixResolveNode::emitBytecode):
+ (JSC::PostfixBracketNode::emitBytecode):
+ (JSC::PostfixDotNode::emitBytecode):
+ (JSC::PostfixErrorNode::emitBytecode):
+ (JSC::DeleteResolveNode::emitBytecode):
+ (JSC::DeleteBracketNode::emitBytecode):
+ (JSC::DeleteDotNode::emitBytecode):
+ (JSC::DeleteValueNode::emitBytecode):
+ (JSC::VoidNode::emitBytecode):
+ (JSC::TypeOfResolveNode::emitBytecode):
+ (JSC::TypeOfValueNode::emitBytecode):
+ (JSC::PrefixResolveNode::emitBytecode):
+ (JSC::PrefixBracketNode::emitBytecode):
+ (JSC::PrefixDotNode::emitBytecode):
+ (JSC::PrefixErrorNode::emitBytecode):
+ (JSC::UnaryOpNode::emitBytecode):
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::EqualNode::emitBytecode):
+ (JSC::StrictEqualNode::emitBytecode):
+ (JSC::ReverseBinaryOpNode::emitBytecode):
+ (JSC::ThrowableBinaryOpNode::emitBytecode):
+ (JSC::InstanceOfNode::emitBytecode):
+ (JSC::LogicalOpNode::emitBytecode):
+ (JSC::ConditionalNode::emitBytecode):
+ (JSC::emitReadModifyAssignment):
+ (JSC::ReadModifyResolveNode::emitBytecode):
+ (JSC::AssignResolveNode::emitBytecode):
+ (JSC::AssignDotNode::emitBytecode):
+ (JSC::ReadModifyDotNode::emitBytecode):
+ (JSC::AssignErrorNode::emitBytecode):
+ (JSC::AssignBracketNode::emitBytecode):
+ (JSC::ReadModifyBracketNode::emitBytecode):
+ (JSC::CommaNode::emitBytecode):
+ (JSC::ConstDeclNode::emitCodeSingle):
+ (JSC::ConstDeclNode::emitBytecode):
+ (JSC::ConstStatementNode::emitBytecode):
+ (JSC::statementListEmitCode):
+ (JSC::BlockNode::emitBytecode):
+ (JSC::EmptyStatementNode::emitBytecode):
+ (JSC::DebuggerStatementNode::emitBytecode):
+ (JSC::ExprStatementNode::emitBytecode):
+ (JSC::VarStatementNode::emitBytecode):
+ (JSC::IfNode::emitBytecode):
+ (JSC::IfElseNode::emitBytecode):
+ (JSC::DoWhileNode::emitBytecode):
+ (JSC::WhileNode::emitBytecode):
+ (JSC::ForNode::emitBytecode):
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ContinueNode::emitBytecode):
+ (JSC::BreakNode::emitBytecode):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::WithNode::emitBytecode):
+ (JSC::CaseBlockNode::emitBytecodeForBlock):
+ (JSC::SwitchNode::emitBytecode):
+ (JSC::LabelNode::emitBytecode):
+ (JSC::ThrowNode::emitBytecode):
+ (JSC::TryNode::emitBytecode):
+ (JSC::EvalNode::emitBytecode):
+ (JSC::EvalNode::generateBytecode):
+ (JSC::FunctionBodyNode::generateBytecode):
+ (JSC::FunctionBodyNode::emitBytecode):
+ (JSC::ProgramNode::emitBytecode):
+ (JSC::ProgramNode::generateBytecode):
+ (JSC::FuncDeclNode::emitBytecode):
+ (JSC::FuncExprNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::ExpressionNode::):
+ (JSC::BooleanNode::):
+ (JSC::NumberNode::):
+ (JSC::StringNode::):
+ (JSC::ProgramNode::):
+ (JSC::EvalNode::):
+ (JSC::FunctionBodyNode::):
+ * runtime/Arguments.h:
+ (JSC::Arguments::getArgumentsData):
+ (JSC::JSActivation::copyRegisters):
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::mark):
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::JSActivationData::JSActivationData):
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::~JSFunction):
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed all forms of "byte code" "opcode" "op code" "code" "bitcode"
+ etc. to "bytecode".
+
+ * VM/CTI.cpp:
+ (JSC::CTI::printBytecodeOperandTypes):
+ (JSC::CTI::emitAllocateNumber):
+ (JSC::CTI::emitNakedCall):
+ (JSC::CTI::emitNakedFastCall):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNum):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmNums):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::SwitchRecord::SwitchRecord):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructureIDs):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::derefStructureIDs):
+ (JSC::CodeBlock::refStructureIDs):
+ * VM/CodeBlock.h:
+ (JSC::StructureStubInfo::StructureStubInfo):
+ * VM/ExceptionHelpers.cpp:
+ (JSC::createNotAnObjectError):
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+ (JSC::Instruction::):
+ * VM/Machine.cpp:
+ (JSC::BytecodeInterpreter::isBytecode):
+ (JSC::BytecodeInterpreter::throwException):
+ (JSC::BytecodeInterpreter::execute):
+ (JSC::BytecodeInterpreter::tryCachePutByID):
+ (JSC::BytecodeInterpreter::uncachePutByID):
+ (JSC::BytecodeInterpreter::tryCacheGetByID):
+ (JSC::BytecodeInterpreter::uncacheGetByID):
+ (JSC::BytecodeInterpreter::privateExecute):
+ (JSC::BytecodeInterpreter::tryCTICachePutByID):
+ (JSC::BytecodeInterpreter::tryCTICacheGetByID):
+ (JSC::BytecodeInterpreter::cti_op_call_JSFunction):
+ (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall):
+ (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall):
+ * VM/Machine.h:
+ (JSC::BytecodeInterpreter::getBytecode):
+ (JSC::BytecodeInterpreter::getBytecodeID):
+ (JSC::BytecodeInterpreter::isCallBytecode):
+ * VM/Opcode.cpp:
+ (JSC::):
+ (JSC::BytecodeStats::BytecodeStats):
+ (JSC::compareBytecodeIndices):
+ (JSC::compareBytecodePairIndices):
+ (JSC::BytecodeStats::~BytecodeStats):
+ (JSC::BytecodeStats::recordInstruction):
+ (JSC::BytecodeStats::resetLastInstruction):
+ * VM/Opcode.h:
+ (JSC::):
+ (JSC::padBytecodeName):
+ * VM/SamplingTool.cpp:
+ (JSC::ScopeSampleRecord::sample):
+ (JSC::SamplingTool::run):
+ (JSC::compareBytecodeIndicesSampling):
+ (JSC::SamplingTool::dump):
+ * VM/SamplingTool.h:
+ (JSC::ScopeSampleRecord::ScopeSampleRecord):
+ (JSC::SamplingTool::SamplingTool):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate):
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::emitLabel):
+ (JSC::CodeGenerator::emitBytecode):
+ (JSC::CodeGenerator::emitJump):
+ (JSC::CodeGenerator::emitJumpIfTrue):
+ (JSC::CodeGenerator::emitJumpIfFalse):
+ (JSC::CodeGenerator::emitMove):
+ (JSC::CodeGenerator::emitUnaryOp):
+ (JSC::CodeGenerator::emitPreInc):
+ (JSC::CodeGenerator::emitPreDec):
+ (JSC::CodeGenerator::emitPostInc):
+ (JSC::CodeGenerator::emitPostDec):
+ (JSC::CodeGenerator::emitBinaryOp):
+ (JSC::CodeGenerator::emitEqualityOp):
+ (JSC::CodeGenerator::emitUnexpectedLoad):
+ (JSC::CodeGenerator::emitInstanceOf):
+ (JSC::CodeGenerator::emitResolve):
+ (JSC::CodeGenerator::emitGetScopedVar):
+ (JSC::CodeGenerator::emitPutScopedVar):
+ (JSC::CodeGenerator::emitResolveBase):
+ (JSC::CodeGenerator::emitResolveWithBase):
+ (JSC::CodeGenerator::emitResolveFunction):
+ (JSC::CodeGenerator::emitGetById):
+ (JSC::CodeGenerator::emitPutById):
+ (JSC::CodeGenerator::emitPutGetter):
+ (JSC::CodeGenerator::emitPutSetter):
+ (JSC::CodeGenerator::emitDeleteById):
+ (JSC::CodeGenerator::emitGetByVal):
+ (JSC::CodeGenerator::emitPutByVal):
+ (JSC::CodeGenerator::emitDeleteByVal):
+ (JSC::CodeGenerator::emitPutByIndex):
+ (JSC::CodeGenerator::emitNewObject):
+ (JSC::CodeGenerator::emitNewArray):
+ (JSC::CodeGenerator::emitNewFunction):
+ (JSC::CodeGenerator::emitNewRegExp):
+ (JSC::CodeGenerator::emitNewFunctionExpression):
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitReturn):
+ (JSC::CodeGenerator::emitUnaryNoDstOp):
+ (JSC::CodeGenerator::emitConstruct):
+ (JSC::CodeGenerator::emitPopScope):
+ (JSC::CodeGenerator::emitDebugHook):
+ (JSC::CodeGenerator::emitComplexJumpScopes):
+ (JSC::CodeGenerator::emitJumpScopes):
+ (JSC::CodeGenerator::emitNextPropertyName):
+ (JSC::CodeGenerator::emitCatch):
+ (JSC::CodeGenerator::emitNewError):
+ (JSC::CodeGenerator::emitJumpSubroutine):
+ (JSC::CodeGenerator::emitSubroutineReturn):
+ (JSC::CodeGenerator::emitPushNewScope):
+ (JSC::CodeGenerator::beginSwitch):
+ (JSC::CodeGenerator::endSwitch):
+ * bytecompiler/CodeGenerator.h:
+ (JSC::CodeGenerator::emitNode):
+ * jsc.cpp:
+ (runWithScripts):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::emitModRm_opr):
+ (JSC::X86Assembler::emitModRm_opr_Unchecked):
+ (JSC::X86Assembler::emitModRm_opm):
+ (JSC::X86Assembler::emitModRm_opm_Unchecked):
+ (JSC::X86Assembler::emitModRm_opmsib):
+ * parser/Nodes.cpp:
+ (JSC::NullNode::emitBytecode):
+ (JSC::BooleanNode::emitBytecode):
+ (JSC::NumberNode::emitBytecode):
+ (JSC::StringNode::emitBytecode):
+ (JSC::RegExpNode::emitBytecode):
+ (JSC::ThisNode::emitBytecode):
+ (JSC::ResolveNode::emitBytecode):
+ (JSC::ArrayNode::emitBytecode):
+ (JSC::ObjectLiteralNode::emitBytecode):
+ (JSC::PropertyListNode::emitBytecode):
+ (JSC::BracketAccessorNode::emitBytecode):
+ (JSC::DotAccessorNode::emitBytecode):
+ (JSC::ArgumentListNode::emitBytecode):
+ (JSC::NewExprNode::emitBytecode):
+ (JSC::EvalFunctionCallNode::emitBytecode):
+ (JSC::FunctionCallValueNode::emitBytecode):
+ (JSC::FunctionCallResolveNode::emitBytecode):
+ (JSC::FunctionCallBracketNode::emitBytecode):
+ (JSC::FunctionCallDotNode::emitBytecode):
+ (JSC::PostfixResolveNode::emitBytecode):
+ (JSC::PostfixBracketNode::emitBytecode):
+ (JSC::PostfixDotNode::emitBytecode):
+ (JSC::PostfixErrorNode::emitBytecode):
+ (JSC::DeleteResolveNode::emitBytecode):
+ (JSC::DeleteBracketNode::emitBytecode):
+ (JSC::DeleteDotNode::emitBytecode):
+ (JSC::DeleteValueNode::emitBytecode):
+ (JSC::VoidNode::emitBytecode):
+ (JSC::TypeOfResolveNode::emitBytecode):
+ (JSC::TypeOfValueNode::emitBytecode):
+ (JSC::PrefixResolveNode::emitBytecode):
+ (JSC::PrefixBracketNode::emitBytecode):
+ (JSC::PrefixDotNode::emitBytecode):
+ (JSC::PrefixErrorNode::emitBytecode):
+ (JSC::UnaryOpNode::emitBytecode):
+ (JSC::BinaryOpNode::emitBytecode):
+ (JSC::EqualNode::emitBytecode):
+ (JSC::StrictEqualNode::emitBytecode):
+ (JSC::ReverseBinaryOpNode::emitBytecode):
+ (JSC::ThrowableBinaryOpNode::emitBytecode):
+ (JSC::InstanceOfNode::emitBytecode):
+ (JSC::LogicalOpNode::emitBytecode):
+ (JSC::ConditionalNode::emitBytecode):
+ (JSC::emitReadModifyAssignment):
+ (JSC::ReadModifyResolveNode::emitBytecode):
+ (JSC::AssignResolveNode::emitBytecode):
+ (JSC::AssignDotNode::emitBytecode):
+ (JSC::ReadModifyDotNode::emitBytecode):
+ (JSC::AssignErrorNode::emitBytecode):
+ (JSC::AssignBracketNode::emitBytecode):
+ (JSC::ReadModifyBracketNode::emitBytecode):
+ (JSC::CommaNode::emitBytecode):
+ (JSC::ConstDeclNode::emitBytecode):
+ (JSC::ConstStatementNode::emitBytecode):
+ (JSC::BlockNode::emitBytecode):
+ (JSC::EmptyStatementNode::emitBytecode):
+ (JSC::DebuggerStatementNode::emitBytecode):
+ (JSC::ExprStatementNode::emitBytecode):
+ (JSC::VarStatementNode::emitBytecode):
+ (JSC::IfNode::emitBytecode):
+ (JSC::IfElseNode::emitBytecode):
+ (JSC::DoWhileNode::emitBytecode):
+ (JSC::WhileNode::emitBytecode):
+ (JSC::ForNode::emitBytecode):
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ContinueNode::emitBytecode):
+ (JSC::BreakNode::emitBytecode):
+ (JSC::ReturnNode::emitBytecode):
+ (JSC::WithNode::emitBytecode):
+ (JSC::SwitchNode::emitBytecode):
+ (JSC::LabelNode::emitBytecode):
+ (JSC::ThrowNode::emitBytecode):
+ (JSC::TryNode::emitBytecode):
+ (JSC::ScopeNode::ScopeNode):
+ (JSC::EvalNode::emitBytecode):
+ (JSC::FunctionBodyNode::emitBytecode):
+ (JSC::ProgramNode::emitBytecode):
+ (JSC::FuncDeclNode::emitBytecode):
+ (JSC::FuncExprNode::emitBytecode):
+ * parser/Nodes.h:
+ (JSC::UnaryPlusNode::):
+ (JSC::NegateNode::):
+ (JSC::BitwiseNotNode::):
+ (JSC::LogicalNotNode::):
+ (JSC::MultNode::):
+ (JSC::DivNode::):
+ (JSC::ModNode::):
+ (JSC::AddNode::):
+ (JSC::SubNode::):
+ (JSC::LeftShiftNode::):
+ (JSC::RightShiftNode::):
+ (JSC::UnsignedRightShiftNode::):
+ (JSC::LessNode::):
+ (JSC::GreaterNode::):
+ (JSC::LessEqNode::):
+ (JSC::GreaterEqNode::):
+ (JSC::InstanceOfNode::):
+ (JSC::InNode::):
+ (JSC::EqualNode::):
+ (JSC::NotEqualNode::):
+ (JSC::StrictEqualNode::):
+ (JSC::NotStrictEqualNode::):
+ (JSC::BitAndNode::):
+ (JSC::BitOrNode::):
+ (JSC::BitXOrNode::):
+ (JSC::ProgramNode::):
+ (JSC::EvalNode::):
+ (JSC::FunctionBodyNode::):
+ * runtime/JSNotAnObject.h:
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::fromDictionaryTransition):
+ * wtf/Platform.h:
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Renamed Machine to BytecodeInterpreter.
+
+ Nixed the Interpreter class, and changed its two functions to stand-alone
+ functions.
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::freeCTIMachineTrampolines):
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructureIDs):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::derefStructureIDs):
+ (JSC::CodeBlock::refStructureIDs):
+ * VM/ExceptionHelpers.cpp:
+ (JSC::createNotAnObjectError):
+ * VM/Machine.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::BytecodeInterpreter::resolve):
+ (JSC::BytecodeInterpreter::resolveSkip):
+ (JSC::BytecodeInterpreter::resolveGlobal):
+ (JSC::BytecodeInterpreter::resolveBase):
+ (JSC::BytecodeInterpreter::resolveBaseAndProperty):
+ (JSC::BytecodeInterpreter::resolveBaseAndFunc):
+ (JSC::BytecodeInterpreter::slideRegisterWindowForCall):
+ (JSC::BytecodeInterpreter::callEval):
+ (JSC::BytecodeInterpreter::BytecodeInterpreter):
+ (JSC::BytecodeInterpreter::initialize):
+ (JSC::BytecodeInterpreter::~BytecodeInterpreter):
+ (JSC::BytecodeInterpreter::dumpCallFrame):
+ (JSC::BytecodeInterpreter::dumpRegisters):
+ (JSC::BytecodeInterpreter::isOpcode):
+ (JSC::BytecodeInterpreter::unwindCallFrame):
+ (JSC::BytecodeInterpreter::throwException):
+ (JSC::BytecodeInterpreter::execute):
+ (JSC::BytecodeInterpreter::debug):
+ (JSC::BytecodeInterpreter::resetTimeoutCheck):
+ (JSC::BytecodeInterpreter::checkTimeout):
+ (JSC::BytecodeInterpreter::createExceptionScope):
+ (JSC::BytecodeInterpreter::tryCachePutByID):
+ (JSC::BytecodeInterpreter::uncachePutByID):
+ (JSC::BytecodeInterpreter::tryCacheGetByID):
+ (JSC::BytecodeInterpreter::uncacheGetByID):
+ (JSC::BytecodeInterpreter::privateExecute):
+ (JSC::BytecodeInterpreter::retrieveArguments):
+ (JSC::BytecodeInterpreter::retrieveCaller):
+ (JSC::BytecodeInterpreter::retrieveLastCaller):
+ (JSC::BytecodeInterpreter::findFunctionCallFrame):
+ (JSC::BytecodeInterpreter::tryCTICachePutByID):
+ (JSC::BytecodeInterpreter::tryCTICacheGetByID):
+ (JSC::BytecodeInterpreter::cti_op_convert_this):
+ (JSC::BytecodeInterpreter::cti_op_end):
+ (JSC::BytecodeInterpreter::cti_op_add):
+ (JSC::BytecodeInterpreter::cti_op_pre_inc):
+ (JSC::BytecodeInterpreter::cti_timeout_check):
+ (JSC::BytecodeInterpreter::cti_register_file_check):
+ (JSC::BytecodeInterpreter::cti_op_loop_if_less):
+ (JSC::BytecodeInterpreter::cti_op_loop_if_lesseq):
+ (JSC::BytecodeInterpreter::cti_op_new_object):
+ (JSC::BytecodeInterpreter::cti_op_put_by_id):
+ (JSC::BytecodeInterpreter::cti_op_put_by_id_second):
+ (JSC::BytecodeInterpreter::cti_op_put_by_id_generic):
+ (JSC::BytecodeInterpreter::cti_op_put_by_id_fail):
+ (JSC::BytecodeInterpreter::cti_op_get_by_id):
+ (JSC::BytecodeInterpreter::cti_op_get_by_id_second):
+ (JSC::BytecodeInterpreter::cti_op_get_by_id_generic):
+ (JSC::BytecodeInterpreter::cti_op_get_by_id_fail):
+ (JSC::BytecodeInterpreter::cti_op_instanceof):
+ (JSC::BytecodeInterpreter::cti_op_del_by_id):
+ (JSC::BytecodeInterpreter::cti_op_mul):
+ (JSC::BytecodeInterpreter::cti_op_new_func):
+ (JSC::BytecodeInterpreter::cti_op_call_JSFunction):
+ (JSC::BytecodeInterpreter::cti_op_call_arityCheck):
+ (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall):
+ (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall):
+ (JSC::BytecodeInterpreter::cti_op_push_activation):
+ (JSC::BytecodeInterpreter::cti_op_call_NotJSFunction):
+ (JSC::BytecodeInterpreter::cti_op_create_arguments):
+ (JSC::BytecodeInterpreter::cti_op_create_arguments_no_params):
+ (JSC::BytecodeInterpreter::cti_op_tear_off_activation):
+ (JSC::BytecodeInterpreter::cti_op_tear_off_arguments):
+ (JSC::BytecodeInterpreter::cti_op_profile_will_call):
+ (JSC::BytecodeInterpreter::cti_op_profile_did_call):
+ (JSC::BytecodeInterpreter::cti_op_ret_scopeChain):
+ (JSC::BytecodeInterpreter::cti_op_new_array):
+ (JSC::BytecodeInterpreter::cti_op_resolve):
+ (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct):
+ (JSC::BytecodeInterpreter::cti_op_construct_NotJSConstruct):
+ (JSC::BytecodeInterpreter::cti_op_get_by_val):
+ (JSC::BytecodeInterpreter::cti_op_resolve_func):
+ (JSC::BytecodeInterpreter::cti_op_sub):
+ (JSC::BytecodeInterpreter::cti_op_put_by_val):
+ (JSC::BytecodeInterpreter::cti_op_put_by_val_array):
+ (JSC::BytecodeInterpreter::cti_op_lesseq):
+ (JSC::BytecodeInterpreter::cti_op_loop_if_true):
+ (JSC::BytecodeInterpreter::cti_op_negate):
+ (JSC::BytecodeInterpreter::cti_op_resolve_base):
+ (JSC::BytecodeInterpreter::cti_op_resolve_skip):
+ (JSC::BytecodeInterpreter::cti_op_resolve_global):
+ (JSC::BytecodeInterpreter::cti_op_div):
+ (JSC::BytecodeInterpreter::cti_op_pre_dec):
+ (JSC::BytecodeInterpreter::cti_op_jless):
+ (JSC::BytecodeInterpreter::cti_op_not):
+ (JSC::BytecodeInterpreter::cti_op_jtrue):
+ (JSC::BytecodeInterpreter::cti_op_post_inc):
+ (JSC::BytecodeInterpreter::cti_op_eq):
+ (JSC::BytecodeInterpreter::cti_op_lshift):
+ (JSC::BytecodeInterpreter::cti_op_bitand):
+ (JSC::BytecodeInterpreter::cti_op_rshift):
+ (JSC::BytecodeInterpreter::cti_op_bitnot):
+ (JSC::BytecodeInterpreter::cti_op_resolve_with_base):
+ (JSC::BytecodeInterpreter::cti_op_new_func_exp):
+ (JSC::BytecodeInterpreter::cti_op_mod):
+ (JSC::BytecodeInterpreter::cti_op_less):
+ (JSC::BytecodeInterpreter::cti_op_neq):
+ (JSC::BytecodeInterpreter::cti_op_post_dec):
+ (JSC::BytecodeInterpreter::cti_op_urshift):
+ (JSC::BytecodeInterpreter::cti_op_bitxor):
+ (JSC::BytecodeInterpreter::cti_op_new_regexp):
+ (JSC::BytecodeInterpreter::cti_op_bitor):
+ (JSC::BytecodeInterpreter::cti_op_call_eval):
+ (JSC::BytecodeInterpreter::cti_op_throw):
+ (JSC::BytecodeInterpreter::cti_op_get_pnames):
+ (JSC::BytecodeInterpreter::cti_op_next_pname):
+ (JSC::BytecodeInterpreter::cti_op_push_scope):
+ (JSC::BytecodeInterpreter::cti_op_pop_scope):
+ (JSC::BytecodeInterpreter::cti_op_typeof):
+ (JSC::BytecodeInterpreter::cti_op_is_undefined):
+ (JSC::BytecodeInterpreter::cti_op_is_boolean):
+ (JSC::BytecodeInterpreter::cti_op_is_number):
+ (JSC::BytecodeInterpreter::cti_op_is_string):
+ (JSC::BytecodeInterpreter::cti_op_is_object):
+ (JSC::BytecodeInterpreter::cti_op_is_function):
+ (JSC::BytecodeInterpreter::cti_op_stricteq):
+ (JSC::BytecodeInterpreter::cti_op_nstricteq):
+ (JSC::BytecodeInterpreter::cti_op_to_jsnumber):
+ (JSC::BytecodeInterpreter::cti_op_in):
+ (JSC::BytecodeInterpreter::cti_op_push_new_scope):
+ (JSC::BytecodeInterpreter::cti_op_jmp_scopes):
+ (JSC::BytecodeInterpreter::cti_op_put_by_index):
+ (JSC::BytecodeInterpreter::cti_op_switch_imm):
+ (JSC::BytecodeInterpreter::cti_op_switch_char):
+ (JSC::BytecodeInterpreter::cti_op_switch_string):
+ (JSC::BytecodeInterpreter::cti_op_del_by_val):
+ (JSC::BytecodeInterpreter::cti_op_put_getter):
+ (JSC::BytecodeInterpreter::cti_op_put_setter):
+ (JSC::BytecodeInterpreter::cti_op_new_error):
+ (JSC::BytecodeInterpreter::cti_op_debug):
+ (JSC::BytecodeInterpreter::cti_vm_throw):
+ * VM/Machine.h:
+ * VM/Register.h:
+ * VM/SamplingTool.cpp:
+ (JSC::SamplingTool::run):
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::SamplingTool):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate):
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::emitOpcode):
+ * debugger/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate):
+ * jsc.cpp:
+ (runWithScripts):
+ * parser/Nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+ * profiler/ProfileGenerator.cpp:
+ (JSC::ProfileGenerator::addParentForConsoleStart):
+ * runtime/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncPop):
+ (JSC::arrayProtoFuncPush):
+ * runtime/Collector.cpp:
+ (JSC::Heap::collect):
+ * runtime/ExecState.h:
+ (JSC::ExecState::interpreter):
+ * runtime/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ * runtime/Interpreter.cpp:
+ (JSC::Interpreter::evaluate):
+ * runtime/JSCell.h:
+ * runtime/JSFunction.cpp:
+ (JSC::JSFunction::call):
+ (JSC::JSFunction::argumentsGetter):
+ (JSC::JSFunction::callerGetter):
+ (JSC::JSFunction::construct):
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::~JSGlobalData):
+ * runtime/JSGlobalData.h:
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::~JSGlobalObject):
+ (JSC::JSGlobalObject::setTimeoutTime):
+ (JSC::JSGlobalObject::startTimeoutCheck):
+ (JSC::JSGlobalObject::stopTimeoutCheck):
+ (JSC::JSGlobalObject::mark):
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ * runtime/JSString.h:
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::RegExp):
+
+2008-11-15 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - Remove SymbolTable from FunctionBodyNode and move it to CodeBlock
+
+ It's not needed for functions that have never been executed, so no
+ need to waste the memory. Saves ~4M on membuster after 30 pages.
+
+ * VM/CodeBlock.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::retrieveArguments):
+ * parser/Nodes.cpp:
+ (JSC::EvalNode::generateCode):
+ (JSC::FunctionBodyNode::generateCode):
+ * parser/Nodes.h:
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::JSActivationData::JSActivationData):
+
+2008-11-14 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22259: Make all opcodes use eax as their final result register
+ <https://bugs.webkit.org/show_bug.cgi?id=22259>
+
+ Change one case of op_add (and the corresponding slow case) to use eax
+ rather than edx. Also, change the order in which the two results of
+ resolve_func and resolve_base are emitted so that the retrieved value is
+ put last into eax.
+
+ This gives no performance change on SunSpider or the V8 benchmark suite
+ when run in either harness.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+
+2008-11-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Geoff has this wacky notion that emitGetArg and emitPutArg should be related to
+ doing the same thing. Crazy.
+
+ Rename the methods for accessing virtual registers to say 'VirtualRegister' in the
+ name, and those for setting up the arguments for CTI methods to contain 'CTIArg'.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetVirtualRegister):
+ (JSC::CTI::emitGetVirtualRegisters):
+ (JSC::CTI::emitPutCTIArgFromVirtualRegister):
+ (JSC::CTI::emitPutCTIArg):
+ (JSC::CTI::emitGetCTIArg):
+ (JSC::CTI::emitPutCTIArgConstant):
+ (JSC::CTI::emitPutVirtualRegister):
+ (JSC::CTI::compileOpCallSetupArgs):
+ (JSC::CTI::compileOpCallEvalSetupArgs):
+ (JSC::CTI::compileOpConstructSetupArgs):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ * VM/CTI.h:
+
+2008-11-14 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ Fix potential build break by adding StdLibExtras.h
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+
+2008-11-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Generate less code for the slow cases of op_call and op_construct.
+ https://bugs.webkit.org/show_bug.cgi?id=22272
+
+ 1% progression on v8 tests.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitRetrieveArg):
+ (JSC::CTI::emitNakedCall):
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ (JSC::getCallLinkInfoReturnLocation):
+ (JSC::CodeBlock::getCallLinkInfo):
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine):
+ (JSC::Machine::cti_vm_dontLazyLinkCall):
+ (JSC::Machine::cti_vm_lazyLinkCall):
+ * VM/Machine.h:
+
+2008-11-14 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Alder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+ Remove use of static C++ objects that are destroyed at exit time (destructors)
+
+ Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
+ exit-time destructor. Update code that was changed to fix this issue that ran
+ into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
+ in gcc build 5465). Also typdefs for template types needed to be added in some
+ cases so the type could make it through the macro successfully.
+
+ Basically code of the form:
+ static T m;
+ becomes:
+ DEFINE_STATIC_LOCAL(T, m, ());
+
+ Also any code of the form:
+ static T& m = *new T;
+ also becomes:
+ DEFINE_STATIC_LOCAL(T, m, ());
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * wtf/MainThread.cpp:
+ (WTF::mainThreadFunctionQueueMutex):
+ (WTF::functionQueue):
+ * wtf/StdLibExtras.h: Added. Add DEFINE_STATIC_LOCAL macro
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::threadMapMutex):
+ (WTF::threadMap):
+ (WTF::identifierByPthreadHandle):
+
+2008-11-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22269
+ Reduce PropertyMap usage
+
+ From observation of StructureID statistics, it became clear that many
+ StructureID's were not being used as StructureIDs themselves, but rather
+ only being necessary as links in the transition chain. Acknowledging this
+ and that PropertyMaps stored in StructureIDs can be treated as caches, that
+ is that they can be reconstructed on demand, it became clear that we could
+ reduce the memory consumption of StructureIDs by only keeping PropertyMaps
+ for the StructureIDs that need them the most.
+
+ The specific strategy used to reduce the number of StructureIDs with
+ PropertyMaps is to take the previous StructureIDs PropertyMap when initially
+ transitioning (addPropertyTransition) from it and clearing out the pointer
+ in the process. The next time we need to do the same transition, for instance
+ repeated calls to the same constructor, we use the new addPropertyTransitionToExistingStructure
+ first, which allows us not to need the PropertyMap to determine if the property
+ exists already, since a transition to that property would require it not already
+ be present in the StructureID. Should there be no transition, the PropertyMap
+ can be constructed on demand (via materializePropertyMap) to determine if the put is a
+ replace or a transition to a new StructureID.
+
+ Reduces memory use on Membuster head test (30 pages open) by ~15MB.
+
+ * JavaScriptCore.exp:
+ * runtime/JSObject.h:
+ (JSC::JSObject::putDirect): First use addPropertyTransitionToExistingStructure
+ so that we can avoid building the PropertyMap on subsequent similar object
+ creations.
+ * runtime/PropertyMapHashTable.h:
+ (JSC::PropertyMapEntry::PropertyMapEntry): Add version of constructor which takes
+ all values to be used when lazily building the PropertyMap.
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics): Add statistics on the number of StructureIDs
+ with PropertyMaps.
+ (JSC::StructureID::StructureID): Rename m_cachedTransistionOffset to m_offset
+ (JSC::isPowerOf2):
+ (JSC::nextPowerOf2):
+ (JSC::sizeForKeyCount): Returns the expected size of a PropertyMap for a key count.
+ (JSC::StructureID::materializePropertyMap): Builds the PropertyMap out of its previous pointer chain.
+ (JSC::StructureID::addPropertyTransitionToExistingStructure): Only transitions if there is a
+ an existing transition.
+ (JSC::StructureID::addPropertyTransition): Instead of always copying the ProperyMap, try and take
+ it from it previous pointer.
+ (JSC::StructureID::removePropertyTransition): Simplify by calling toDictionaryTransition() to do
+ transition work.
+ (JSC::StructureID::changePrototypeTransition): Build the PropertyMap if necessary before transitioning
+ because once you have transitioned, you will not be able to reconstruct it afterwards as there is no
+ previous pointer, pinning the ProperyMap as well.
+ (JSC::StructureID::getterSetterTransition): Ditto.
+ (JSC::StructureID::toDictionaryTransition): Pin the PropertyMap so that it is not destroyed on further transitions.
+ (JSC::StructureID::fromDictionaryTransition): We can only transition back from a dictionary transition if there
+ are no deleted offsets.
+ (JSC::StructureID::addPropertyWithoutTransition): Build PropertyMap on demands and pin.
+ (JSC::StructureID::removePropertyWithoutTransition): Ditto.
+ (JSC::StructureID::get): Build on demand.
+ (JSC::StructureID::createPropertyMapHashTable): Add version of create that takes a size
+ for on demand building.
+ (JSC::StructureID::expandPropertyMapHashTable):
+ (JSC::StructureID::rehashPropertyMapHashTable):
+ (JSC::StructureID::getEnumerablePropertyNamesInternal): Build PropertyMap on demand.
+ * runtime/StructureID.h:
+ (JSC::StructureID::propertyStorageSize): Account for StructureIDs without PropertyMaps.
+ (JSC::StructureID::isEmpty): Ditto.
+ (JSC::StructureID::materializePropertyMapIfNecessary):
+ (JSC::StructureID::get): Build PropertyMap on demand
+
+2008-11-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Simon Hausmann.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21500>
+
+ JavaScriptCore build with -O3 flag instead of -O2 (gcc).
+ 2.02% speedup on SunSpider (Qt-port on Linux)
+ 1.10% speedup on V8 (Qt-port on Linux)
+ 3.45% speedup on WindScorpion (Qt-port on Linux)
+
+ * JavaScriptCore.pri:
+
+2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>
+
+ Reviewed by Darin Adler.
+
+ Compile fix for RVCT.
+
+ In reality, it is two fixes:
+
+ 1. Remove typename. I believe typename can only be used when the named
+ type depends on the template parameters, which it doesn't in this
+ case, so I think this is more correct.
+ 2. Replace ::iterator scope with specialized typedef. This is to work
+ around a bug in RVCT.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22260
+
+ * wtf/ListHashSet.h:
+ (WTF::::find):
+
+2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>
+
+ Reviewed by Darin Adler.
+
+ Compile fix for WINSCW.
+
+ This fix doesn't protect against implicit conversions from bool to
+ integers, but most likely that will be caught on another platform.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22260
+
+ * wtf/PassRefPtr.h:
+ (WTF::PassRefPtr::operator bool):
+ * wtf/RefPtr.h:
+ (WTF::RefPtr::operator bool):
+
+2008-11-14 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22245: Move wtf/dtoa.h into the WTF namespace
+ <https://bugs.webkit.org/show_bug.cgi?id=22245>
+
+ Move wtf/dtoa.h into the WTF namespace from the JSC namespace. This
+ introduces some ambiguities in name lookups, so I changed all uses of
+ the functions in wtf/dtoa.h to explicitly state the namespace.
+
+ * JavaScriptCore.exp:
+ * parser/Lexer.cpp:
+ (JSC::Lexer::lex):
+ * runtime/InitializeThreading.cpp:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ (JSC::parseInt):
+ * runtime/NumberPrototype.cpp:
+ (JSC::integerPartNoExp):
+ (JSC::numberProtoFuncToExponential):
+ * runtime/UString.cpp:
+ (JSC::concatenate):
+ (JSC::UString::from):
+ (JSC::UString::toDouble):
+ * wtf/dtoa.cpp:
+ * wtf/dtoa.h:
+
+2008-11-14 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 22257: Enable redundant read optimizations for results generated by compileBinaryArithOp()
+ <https://bugs.webkit.org/show_bug.cgi?id=22257>
+
+ This shows no change in performance on either SunSpider or the V8
+ benchmark suite, but it removes an ugly special case and allows for
+ future optimizations to be implemented in a cleaner fashion.
+
+ This patch was essentially given to me by Gavin Barraclough upon my
+ request, but I did regression and performance testing so that he could
+ work on something else.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): Move the final
+ result to eax if it is not already there.
+ (JSC::CTI::compileBinaryArithOp): Remove the killing of the final result
+ register that disables the optimization.
+
+2008-11-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add a Scons-based build system for building
+ the Chromium-Mac build of JavaScriptCore.
+ https://bugs.webkit.org/show_bug.cgi?id=21991
+
+ * JavaScriptCore.scons: Added.
+ * SConstruct: Added.
+
+2008-11-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add PLATFORM(CHROMIUM) to the "we don't use cairo" blacklist
+ until https://bugs.webkit.org/show_bug.cgi?id=22250 is fixed.
+
+ * wtf/Platform.h:
+
+2008-11-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ In r38375 the 'jsc' shell was changed to improve teardown on quit. The
+ main() function in jsc.cpp uses Structured Exception Handling, so Visual
+ C++ emits a warning when destructors are used.
+
+ In order to speculatively fix the Windows build, this patch changes that
+ code to use explicit pointer manipulation and locking rather than smart
+ pointers and RAII.
+
+ * jsc.cpp:
+ (main):
+
+2008-11-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22246: Get arguments for opcodes together to eliminate more redundant memory reads
+ <https://bugs.webkit.org/show_bug.cgi?id=22246>
+
+ It is common for opcodes to read their first operand into eax and their
+ second operand into edx. If the value intended for the second operand is
+ in eax, we should first move eax to the register for the second operand
+ and then read the first operand into eax.
+
+ This is a 0.5% speedup on SunSpider and a 2.0% speedup on the V8
+ benchmark suite when measured using the V8 harness.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArgs):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+
+2008-11-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22238: Avoid unnecessary reads of temporaries when the target machine register is not eax
+ <https://bugs.webkit.org/show_bug.cgi?id=22238>
+
+ Enable the optimization of not reading a value back from memory that we
+ just wrote when the target machine register is not eax. In order to do
+ this, the code generation for op_put_global_var must be changed to
+ read its argument into a register before overwriting eax.
+
+ This is a 0.5% speedup on SunSpider and shows no change on the V8
+ benchmark suite when run in either harness.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::privateCompileMainPass):
+
+2008-11-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Perform teardown in the 'jsc' shell in order to suppress annoying and
+ misleading leak messages. There is still a lone JSC::Node leaking when
+ quit() is called, but hopefully that can be fixed as well.
+
+ * jsc.cpp:
+ (functionQuit):
+ (main):
+
+2008-11-13 Mike Pinkerton <pinkerton@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22087
+ Need correct platform defines for Mac Chromium
+
+ Set the appropriate platform defines for Mac Chromium, which is
+ similar to PLATFORM(MAC), but isn't.
+
+ * wtf/Platform.h:
+
+2008-11-13 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - remove immediate checks from native codegen for known non-immediate cases like "this"
+
+ ~.5% speedup on v8 benchmarks
+
+ In the future we can extend this model to remove all sorts of
+ typechecks based on local type info or type inference.
+
+ I also added an assertion to verify that all slow cases linked as
+ many slow case jumps as the corresponding fast case generated, and
+ fixed the pre-existing cases where this was not true.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::linkSlowCaseIfNotJSCell):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::isKnownNotImmediate):
+
+2008-11-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21943: Avoid needless reads of temporary values in CTI code
+ <https://bugs.webkit.org/show_bug.cgi?id=21943>
+
+ If an opcode needs to load a virtual register and a previous opcode left
+ the contents of that virtual register in a machine register, use the
+ value in the machine register rather than getting it from memory.
+
+ In order to perform this optimization, it is necessary to know the
+ jump tagets in the CodeBlock. For temporaries, the only problematic
+ jump targets are binary logical operators and the ternary conditional
+ operator. However, if this optimization were to be extended to local
+ variable registers as well, other jump targets would need to be
+ included, like switch statement cases and the beginnings of catch
+ blocks.
+
+ This optimization also requires that the fast case and the slow case
+ of an opcode use emitPutResult() on the same register, which was chosen
+ to be eax, as that is the register into which we read the first operand
+ of opcodes. In order to make this the case, we needed to add some mov
+ instructions to the slow cases of some instructions.
+
+ This optimizaton is not applied whenever compileBinaryArithOp() is used
+ to compile an opcode, because different machine registers may be used to
+ store the final result. It seems possible to rewrite the code generation
+ in compileBinaryArithOp() to allow for this optimization.
+
+ This optimization is also not applied when generating slow cases,
+ because some fast cases overwrite the value of eax before jumping to the
+ slow case. In the future, it may be possible to apply this optimization
+ to slow cases as well, but it did not seem to be a speedup when testing
+ an early version of this patch.
+
+ This is a 1.0% speedup on SunSpider and a 6.3% speedup on the V8
+ benchmark suite.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::killLastResultRegister):
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutResult):
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileOpStrictEq):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::isTemporaryRegisterIndex):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitLabel):
+
+2008-11-12 Alp Toker <alp@nuanti.com>
+
+ autotools build system fix-up only. Add FloatQuad.h to the source
+ lists and sort them.
+
+ * GNUmakefile.am:
+
+2008-11-12 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22192
+ +37 failures in fast/profiler
+
+ along with Darin's review comments in
+ https://bugs.webkit.org/show_bug.cgi?id=22174
+ Simplified op_call by nixing its responsibility for moving the value of
+ "this" into the first argument slot
+
+ * VM/Machine.cpp:
+ (JSC::returnToThrowTrampoline):
+ (JSC::throwStackOverflowError):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_call_arityCheck):
+ (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since
+ functions are better than macros.
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitConstruct): Ensure that the function register
+ is preserved if profiling is enabled, since the profiler uses that
+ register.
+
+ * runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation,
+ because I had a hard time understanding what "throwReturnAddress" meant.
+
+2008-11-12 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Roll in r38322, now that test failures have been fixed.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCallSetupArgs):
+ (JSC::CTI::compileOpCallEvalSetupArgs):
+ (JSC::CTI::compileOpConstructSetupArgs):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/Machine.cpp:
+ (JSC::Machine::callEval):
+ (JSC::Machine::dumpCallFrame):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::execute):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_call_arityCheck):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitCallEval):
+ (JSC::CodeGenerator::emitConstruct):
+ * bytecompiler/CodeGenerator.h:
+ * parser/Nodes.cpp:
+ (JSC::EvalFunctionCallNode::emitCode):
+ (JSC::FunctionCallValueNode::emitCode):
+ (JSC::FunctionCallResolveNode::emitCode):
+ (JSC::FunctionCallBracketNode::emitCode):
+ (JSC::FunctionCallDotNode::emitCode):
+ * parser/Nodes.h:
+ (JSC::ScopeNode::neededConstants):
+
+2008-11-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22201
+ Integer conversion in array.length was safe signed values,
+ but the length is unsigned.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+
+2008-11-12 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ Roll out r38322 due to test failures on the bots.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCallSetupArgs):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/Machine.cpp:
+ (JSC::Machine::callEval):
+ (JSC::Machine::dumpCallFrame):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::execute):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::throwStackOverflowPreviousFrame):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_call_arityCheck):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitCallEval):
+ (JSC::CodeGenerator::emitConstruct):
+ * bytecompiler/CodeGenerator.h:
+ * parser/Nodes.cpp:
+ (JSC::EvalFunctionCallNode::emitCode):
+ (JSC::FunctionCallValueNode::emitCode):
+ (JSC::FunctionCallResolveNode::emitCode):
+ (JSC::FunctionCallBracketNode::emitCode):
+ (JSC::FunctionCallDotNode::emitCode):
+ * parser/Nodes.h:
+ (JSC::ScopeNode::neededConstants):
+
+2008-11-11 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22174
+ Simplified op_call by nixing its responsibility for moving the value of
+ "this" into the first argument slot.
+
+ Instead, the caller emits an explicit load or mov instruction, or relies
+ on implicit knowledge that "this" is already in the first argument slot.
+ As a result, two operands to op_call are gone: firstArg and thisVal.
+
+ SunSpider and v8 tests show no change in bytecode or CTI.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCallSetupArgs):
+ (JSC::CTI::compileOpCallEvalSetupArgs):
+ (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions
+ of setting up arguments to op_call, because they're more different than
+ they are the same -- even more so with this patch.
+
+ (JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
+ match op_call anymore.
+
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
+ for changes mentioned above.
+
+ * VM/CTI.h:
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::callEval): Updated for new bytecode format of call / construct.
+
+ (JSC::Machine::dumpCallFrame):
+ (JSC::Machine::dumpRegisters): Simplified these debugging functions,
+ taking advantage of the new call frame layout.
+
+ (JSC::Machine::execute): Fixed up the eval version of execute to be
+ friendlier to calls in the new format.
+
+ (JSC::Machine::privateExecute): Implemented the new call format in
+ bytecode.
+
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
+ call format.
+
+ Fixed a latent bug in stack overflow checking that is now hit because
+ the register layout has changed a bit -- namely: when throwing a stack
+ overflow exception inside an op_call helper, we need to account for the
+ fact that the current call frame is only half-constructed, and use the
+ parent call frame instead.
+
+ * VM/Machine.h:
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitCallEval):
+ (JSC::CodeGenerator::emitConstruct):
+ * bytecompiler/CodeGenerator.h: Updated codegen to match the new call
+ format.
+
+ * parser/Nodes.cpp:
+ (JSC::EvalFunctionCallNode::emitCode):
+ (JSC::FunctionCallValueNode::emitCode):
+ (JSC::FunctionCallResolveNode::emitCode):
+ (JSC::FunctionCallBracketNode::emitCode):
+ (JSC::FunctionCallDotNode::emitCode):
+ * parser/Nodes.h:
+ (JSC::ScopeNode::neededConstants): ditto
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove an unused forwarding header for a file that no longer exists.
+
+ * ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
+
+2008-11-11 Mark Rowe <mrowe@apple.com>
+
+ Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
+ by failure to update all instances of "kjs" to their new locations.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-11-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Rubber-stamped by Adam Roben.
+
+ * wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter):
+ Fix indentation a little more.
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Clean up EvalCodeCache to match our coding style a bit more.
+
+ * VM/EvalCodeCache.h:
+ (JSC::EvalCodeCache::get):
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
+ <https://bugs.webkit.org/show_bug.cgi?id=22179>
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CodeBlock.h:
+ * VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
+ * VM/Machine.cpp:
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove the 'm_' prefix from the fields of the SwitchRecord struct.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h:
+ (JSC::SwitchRecord):
+ (JSC::SwitchRecord::SwitchRecord):
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Make asInteger() a static function so that it has internal linkage.
+
+ * VM/CTI.cpp:
+ (JSC::asInteger):
+
+2008-11-11 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)
+
+ No perf regression combined with the last patch (each seems like a small regression individually)
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate):
+ * parser/Nodes.h:
+ (JSC::SourceElements::releaseContentsIntoVector):
+ * wtf/Vector.h:
+ (WTF::Vector::shrinkToFit):
+
+2008-11-11 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - remove inline capacity from declaration stacks (15M savings on membuster test)
+
+ No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.
+
+ * JavaScriptCore.exp:
+ * parser/Nodes.h:
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ While r38286 removed the need for the m_callFrame member variable of
+ CTI, it should be also be removed.
+
+ * VM/CTI.h:
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Make CTI::asInteger() a non-member function, since it needs no access to
+ any of CTI's member variables.
+
+ * VM/CTI.cpp:
+ (JSC::asInteger):
+ * VM/CTI.h:
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
+ usual convention elsewhere.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Make CTI::getConstant() a member function of CodeBlock instead.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::getConstant):
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Rename CodeBlock::isConstant() to isConstantRegisterIndex().
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::isConstantRegisterIndex):
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp):
+
+2008-11-10 Gavin Barraclough <barraclough@apple.com>
+
+ Build fix for non-CTI builds.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::initialize):
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove the unused labels member variable of CodeBlock.
+
+ * VM/CodeBlock.h:
+ * VM/LabelID.h:
+ (JSC::LabelID::setLocation):
+
+2008-11-10 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
+ Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
+ pointer to the global data directly, since this is available at the point the Machine is constructed).
+ Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::getConstant):
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompileCTIMachineTrampolines):
+ (JSC::CTI::freeCTIMachineTrampolines):
+ * VM/CTI.h:
+ (JSC::CTI::compile):
+ (JSC::CTI::compileGetByIdSelf):
+ (JSC::CTI::compileGetByIdProto):
+ (JSC::CTI::compileGetByIdChain):
+ (JSC::CTI::compilePutByIdReplace):
+ (JSC::CTI::compilePutByIdTransition):
+ (JSC::CTI::compileCTIMachineTrampolines):
+ (JSC::CTI::compilePatchGetArrayLength):
+ * VM/Machine.cpp:
+ (JSC::Machine::initialize):
+ (JSC::Machine::~Machine):
+ (JSC::Machine::execute):
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::tryCTICacheGetByID):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_lazyLinkCall):
+ * VM/Machine.h:
+ * masm/X86Assembler.h:
+ (JSC::JITCodeBuffer::isAligned):
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::align):
+ * runtime/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+
+2008-11-10 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ - Make Vector::clear() release the Vector's memory (1MB savings on membuster)
+ https://bugs.webkit.org/show_bug.cgi?id=22170
+
+ * wtf/Vector.h:
+ (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as
+ well as size, otherwise shrinking capacity to 0 can fail to reset
+ the capacity and thus cause a future crash.
+ (WTF::Vector::~Vector): Shrink size not capacity; we only need
+ to call destructors, the buffer will be freed anyway.
+ (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0).
+ (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where
+ the size is greater than the new capacity, to work with types that have no
+ default constructor.
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Split multiple definitions into separate lines.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileBinaryArithOp):
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
+ <https://bugs.webkit.org/show_bug.cgi?id=22162>
+
+ There is no more need for the cachedValueGetter hack now that we have
+ PropertySlot::setValue(), so we should remove it.
+
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::getOwnPropertySlot):
+
+2008-11-10 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
+ <https://bugs.webkit.org/show_bug.cgi?id=22152>
+
+ With the recent change to adopt asType() style cast functions with
+ assertions instead of static_casts in many places, the assertion for
+ the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
+ failing when using any nontrivial client of the JavaScriptCore API.
+ The cast isn't even necessary to call slot.setCustom(), so it should
+ be removed.
+
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::JSCallbackObject::getOwnPropertySlot):
+
+2008-11-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ A few coding style fixes for AVLTree.
+
+ * wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards.
+ (WTF::AVLTree::Iterator::start_iter): Fixed indentation
+
+ * runtime/JSArray.cpp: Added "using namepace WTF".
+
+2008-11-09 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculatively fix the non-AllInOne build.
+
+ * runtime/NativeErrorConstructor.cpp:
+
+2008-11-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22149
+ remove unused code from the parser
+
+ * AllInOneFile.cpp: Removed nodes2string.cpp.
+ * GNUmakefile.am: Ditto.
+ * JavaScriptCore.exp: Ditto.
+ * JavaScriptCore.pri: Ditto.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
+ * JavaScriptCoreSources.bkl: Ditto.
+
+ * VM/CodeBlock.h: Added include.
+
+ * VM/Machine.cpp: (JSC::Machine::execute): Use the types from
+ DeclarationStacks as DeclarationStacks:: rather than Node:: since
+ "Node" really has little to do with it.
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator): Ditto.
+
+ * jsc.cpp:
+ (Options::Options): Removed prettyPrint option.
+ (runWithScripts): Ditto.
+ (printUsageStatement): Ditto.
+ (parseArguments): Ditto.
+ (jscmain): Ditto.
+
+ * parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
+
+ * parser/Nodes.cpp:
+ (JSC::ThrowableExpressionData::emitThrowError): Use inline functions
+ instead of direct member access for ThrowableExpressionData values.
+ (JSC::BracketAccessorNode::emitCode): Ditto.
+ (JSC::DotAccessorNode::emitCode): Ditto.
+ (JSC::NewExprNode::emitCode): Ditto.
+ (JSC::EvalFunctionCallNode::emitCode): Ditto.
+ (JSC::FunctionCallValueNode::emitCode): Ditto.
+ (JSC::FunctionCallResolveNode::emitCode): Ditto.
+ (JSC::FunctionCallBracketNode::emitCode): Ditto.
+ (JSC::FunctionCallDotNode::emitCode): Ditto.
+ (JSC::PostfixResolveNode::emitCode): Ditto.
+ (JSC::PostfixBracketNode::emitCode): Ditto.
+ (JSC::PostfixDotNode::emitCode): Ditto.
+ (JSC::DeleteResolveNode::emitCode): Ditto.
+ (JSC::DeleteBracketNode::emitCode): Ditto.
+ (JSC::DeleteDotNode::emitCode): Ditto.
+ (JSC::PrefixResolveNode::emitCode): Ditto.
+ (JSC::PrefixBracketNode::emitCode): Ditto.
+ (JSC::PrefixDotNode::emitCode): Ditto.
+ (JSC::ThrowableBinaryOpNode::emitCode): Ditto.
+ (JSC::InstanceOfNode::emitCode): Ditto.
+ (JSC::ReadModifyResolveNode::emitCode): Ditto.
+ (JSC::AssignResolveNode::emitCode): Ditto.
+ (JSC::AssignDotNode::emitCode): Ditto.
+ (JSC::ReadModifyDotNode::emitCode): Ditto.
+ (JSC::AssignBracketNode::emitCode): Ditto.
+ (JSC::ReadModifyBracketNode::emitCode): Ditto.
+ (JSC::statementListEmitCode): Take a const StatementVector instead
+ of a non-const one. Also removed unused statementListPushFIFO.
+ (JSC::ForInNode::emitCode): Inline functions instead of member access.
+ (JSC::ThrowNode::emitCode): Ditto.
+ (JSC::EvalNode::emitCode): Ditto.
+ (JSC::FunctionBodyNode::emitCode): Ditto.
+ (JSC::ProgramNode::emitCode): Ditto.
+
+ * parser/Nodes.h: Removed unused includes and forward declarations.
+ Removed Precedence enum. Made many more members private instead of
+ protected or public. Removed unused NodeStack typedef. Moved the
+ VarStack and FunctionStack typedefs from Node to ScopeNode. Made
+ Node::emitCode pure virtual and changed classes that don't emit
+ any code to inherit from ParserRefCounted rather than Node.
+ Moved isReturnNode from Node to StatementNode. Removed the
+ streamTo, precedence, and needsParensIfLeftmost functions from
+ all classes. Removed the ImmediateNumberNode class and make
+ NumberNode::setValue nonvirtual.
+
+ * parser/nodes2string.cpp: Removed.
+
+2008-11-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig and Maciej Stachowiak.
+ Includes some work done by Chris Brichford.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=14886
+ Stack overflow due to deeply nested parse tree doing repeated string concatentation
+
+ Test: fast/js/large-expressions.html
+
+ 1) Code generation is recursive, so takes stack proportional to the complexity
+ of the source code expression. Fixed by setting an arbitrary recursion limit
+ of 10,000 nodes.
+
+ 2) Destruction of the syntax tree was recursive. Fixed by introducing a
+ non-recursive mechanism for destroying the tree.
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0.
+ (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code
+ to throw a "too deep" exception.
+ * bytecompiler/CodeGenerator.h:
+ (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed
+ the maximum depth.
+
+ * parser/Nodes.cpp:
+ (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors
+ to avoid recursive calls to destructors for nodes inside this one.
+ (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions.
+ Also added releaseNodes functions and calls to releaseAllNodes inside destructors
+ for each class derived from Node that has RefPtr to other nodes.
+ (JSC::NodeReleaser::adopt): Added. Used by the release function.
+ (JSC::NodeReleaser::adoptFunctionBodyNode): Added.
+
+ * parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes
+ that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts
+ of an older solution to the non-recursive destruction problem that works only for
+ lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode
+ to use BinaryOpNode as a base class to avoid some duplicated code.
+
+2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after addition of JSCore parser and bycompiler dirs. Also cleanup
+ the JSCore Bakefile's group names to be consistent.
+
+ * JavaScriptCoreSources.bkl:
+ * jscore.bkl:
+
+2008-11-07 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
+ <https://bugs.webkit.org/show_bug.cgi?id=21801>
+
+ Fix the constant register check in the 'typeof' optimization in
+ CodeGenerator, which was completely broken after r37821.
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp):
+
+2008-11-07 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 22129: Move CTI::isConstant() to CodeBlock
+ <https://bugs.webkit.org/show_bug.cgi?id=22129>
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::isConstant):
+
+2008-11-07 Alp Toker <alp@nuanti.com>
+
+ autotools fix. Always use the configured perl binary (which may be
+ different to the one in $PATH) when generating sources.
+
+ * GNUmakefile.am:
+
+2008-11-07 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
+ build scripts.
+
+ * DerivedSources.make:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCoreSources.bkl:
+
+2008-11-07 Alp Toker <alp@nuanti.com>
+
+ More grammar.cpp -> Grammar.cpp build fixes.
+
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+
+2008-11-07 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the build on case-sensitive file systems. grammar.y was renamed to
+ Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
+ notice this change because of stale files.
+
+ * parser/Lexer.cpp:
+
+2008-11-07 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
+ variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
+ and m_nextConstantIndex respectively. This is to distinguish these from
+ member variables like m_lastConstant, which are actually RefPtrs to
+ Registers.
+
+ * bytecompiler/CodeGenerator.cpp:
+ (JSC::CodeGenerator::addGlobalVar):
+ (JSC::CodeGenerator::allocateConstants):
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::addParameter):
+ (JSC::CodeGenerator::addConstant):
+ * bytecompiler/CodeGenerator.h:
+
+2008-11-06 Gavin Barraclough barraclough@apple.com
+
+ Reviewed by Oliver Hunt.
+
+ Do not make a cti_* call to perform an op_call unless either:
+ (1) The codeblock for the function body has not been generated.
+ (2) The number of arguments passed does not match the callee arity.
+
+ ~1% progression on sunspider --v8
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_call_arityCheck):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/Machine.h:
+ * kjs/nodes.h:
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Move the remaining files in the kjs subdirectory of JavaScriptCore to
+ a new parser subdirectory, and remove the kjs subdirectory entirely.
+
+ * AllInOneFile.cpp:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/CodeBlock.h:
+ * VM/ExceptionHelpers.cpp:
+ * VM/SamplingTool.h:
+ * bytecompiler/CodeGenerator.h:
+ * jsc.pro:
+ * jscore.bkl:
+ * kjs: Removed.
+ * kjs/NodeInfo.h: Removed.
+ * kjs/Parser.cpp: Removed.
+ * kjs/Parser.h: Removed.
+ * kjs/ResultType.h: Removed.
+ * kjs/SourceCode.h: Removed.
+ * kjs/SourceProvider.h: Removed.
+ * kjs/grammar.y: Removed.
+ * kjs/keywords.table: Removed.
+ * kjs/lexer.cpp: Removed.
+ * kjs/lexer.h: Removed.
+ * kjs/nodes.cpp: Removed.
+ * kjs/nodes.h: Removed.
+ * kjs/nodes2string.cpp: Removed.
+ * parser: Added.
+ * parser/Grammar.y: Copied from kjs/grammar.y.
+ * parser/Keywords.table: Copied from kjs/keywords.table.
+ * parser/Lexer.cpp: Copied from kjs/lexer.cpp.
+ * parser/Lexer.h: Copied from kjs/lexer.h.
+ * parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
+ * parser/Nodes.cpp: Copied from kjs/nodes.cpp.
+ * parser/Nodes.h: Copied from kjs/nodes.h.
+ * parser/Parser.cpp: Copied from kjs/Parser.cpp.
+ * parser/Parser.h: Copied from kjs/Parser.h.
+ * parser/ResultType.h: Copied from kjs/ResultType.h.
+ * parser/SourceCode.h: Copied from kjs/SourceCode.h.
+ * parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
+ * parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
+ * pcre/pcre.pri:
+ * pcre/pcre_exec.cpp:
+ * runtime/FunctionConstructor.cpp:
+ * runtime/JSActivation.h:
+ * runtime/JSFunction.h:
+ * runtime/JSGlobalData.cpp:
+ * runtime/JSGlobalObjectFunctions.cpp:
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::toNumber):
+ * runtime/RegExp.cpp:
+
+2008-11-06 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r38196
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the
+ include path.
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Create a new bytecompiler subdirectory of JavaScriptCore and move some
+ relevant files to it.
+
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/CodeGenerator.cpp: Removed.
+ * VM/CodeGenerator.h: Removed.
+ * bytecompiler: Added.
+ * bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
+ * bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
+ * bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
+ * jscore.bkl:
+ * kjs/LabelScope.h: Removed.
+
+2008-11-06 Adam Roben <aroben@apple.com>
+
+ Windows clean build fix after r38155
+
+ Rubberstamped by Cameron Zwarich.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
+ the post-build event for the move of create_hash_table out of kjs/.
+
+2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22107
+
+ Bug uncovered during RVCT port in functions not used. get_lt() and
+ get_gt() takes only one argument - remove second argument where
+ applicable.
+
+ * wtf/AVLTree.h:
+ (JSC::AVLTree::remove): Remove second argument of get_lt/get_gt().
+ (JSC::AVLTree::subst): Ditto.
+
+2008-11-06 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Cameron Zwarich.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22033
+ [GTK] CTI/Linux r38064 crashes; JIT requires executable memory
+
+ Mark pages allocated by the FastMalloc mmap code path executable with
+ PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
+ non-executable memory (like ExecShield on Fedora Linux) when the JIT
+ is enabled.
+
+ This patch does not resolve the issue on debug builds so affected
+ developers may still need to pass --disable-jit to configure.
+
+ * wtf/TCSystemAlloc.cpp:
+ (TryMmap):
+ (TryDevMem):
+ (TCMalloc_SystemRelease):
+
+2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 22099: Make the Qt port build the JSC shell in the correct place
+ <https://bugs.webkit.org/show_bug.cgi?id=22099>
+
+ Adjust include paths and build destination dir for the 'jsc' executable
+ in the Qt build.
+
+ * jsc.pro:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Implemented the block allocation on Symbian through heap allocation.
+
+ Unfortunately there is no way to allocate virtual memory. The Posix
+ layer provides mmap() but no anonymous mapping. So this is a very slow
+ solution but it should work as a start.
+
+ * runtime/Collector.cpp:
+ (JSC::allocateBlock):
+ (JSC::freeBlock):
+
+2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Borrow some math functions from the MSVC port to the build with the
+ RVCT compiler.
+
+ * wtf/MathExtras.h:
+ (isinf):
+ (isnan):
+ (signbit):
+
+2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Include strings.h for strncasecmp().
+ This is needed for compilation inside Symbian and it is also
+ confirmed by the man-page on Linux.
+
+ * runtime/DateMath.cpp:
+
+2008-11-06 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Implemented currentThreadStackBase for Symbian.
+
+ * runtime/Collector.cpp:
+ (JSC::currentThreadStackBase):
+
+2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ RVCT does not support tm_gmtoff field, so disable that code just like
+ for MSVC.
+
+ * runtime/DateMath.h:
+ (JSC::GregorianDateTime::GregorianDateTime):
+ (JSC::GregorianDateTime::operator tm):
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
+ on top of the Posix layer.
+
+ * wtf/Platform.h:
+
+2008-11-06 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Added __SYMBIAN32__ condition for defining PLATFORM(SYMBIAN).
+
+ * wtf/Platform.h:
+
+2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Added WINSCW compiler define for Symbian S60.
+
+ * wtf/Platform.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
+ MINSCW compiler.
+
+ * wtf/Vector.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Define capabilities of the SYMBIAN platform. Some of the system
+ headers are actually dependent on RVCT.
+
+ * wtf/Platform.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Add missing stddef.h header needed for compilation in Symbian.
+
+ * runtime/Collector.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.
+
+ * wtf/Platform.h:
+
+2008-11-06 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the Qt build, adjust include paths after move of jsc.pro.
+
+ * jsc.pro:
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
+ rename it to jsc.cpp to reflect the name of the binary compiled from it.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * jsc.cpp: Copied from kjs/Shell.cpp.
+ * jsc.pro:
+ * jscore.bkl:
+ * kjs/Shell.cpp: Removed.
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move create_hash_table and jsc.pro out of the kjs directory and into the
+ root directory of JavaScriptCore.
+
+ * DerivedSources.make:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * create_hash_table: Copied from kjs/create_hash_table.
+ * jsc.pro: Copied from kjs/jsc.pro.
+ * kjs/create_hash_table: Removed.
+ * kjs/jsc.pro: Removed.
+ * make-generated-sources.sh:
+
+2008-11-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22094
+
+ Fix for bug where the callee incorrectly recieves the caller's lexical
+ global object as this, rather than its own. Implementation closely
+ follows the spec, passing jsNull, checking in the callee and replacing
+ with the global object where necessary.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_call_eval):
+ * runtime/JSCell.h:
+ (JSC::JSValue::toThisObject):
+ * runtime/JSImmediate.cpp:
+ (JSC::JSImmediate::toThisObject):
+ * runtime/JSImmediate.h:
+
+2008-11-05 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix after Operations.cpp move.
+
+ * JavaScriptCoreSources.bkl:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the build for case-sensitive build systems and wxWindows.
+
+ * JavaScriptCoreSources.bkl:
+ * kjs/create_hash_table:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the build for case-sensitive build systems.
+
+ * JavaScriptCoreSources.bkl:
+ * kjs/Shell.cpp:
+ * runtime/Interpreter.cpp:
+ * runtime/JSArray.cpp:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the build for case-sensitive build systems.
+
+ * API/JSBase.cpp:
+ * API/JSObjectRef.cpp:
+ * runtime/CommonIdentifiers.h:
+ * runtime/Identifier.cpp:
+ * runtime/InitializeThreading.cpp:
+ * runtime/InternalFunction.h:
+ * runtime/JSString.h:
+ * runtime/Lookup.h:
+ * runtime/PropertyNameArray.h:
+ * runtime/PropertySlot.h:
+ * runtime/StructureID.cpp:
+ * runtime/StructureID.h:
+ * runtime/UString.cpp:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move more files to the runtime subdirectory of JavaScriptCore.
+
+ * API/APICast.h:
+ * API/JSBase.cpp:
+ * API/JSCallbackObject.cpp:
+ * API/JSClassRef.cpp:
+ * API/JSClassRef.h:
+ * API/JSStringRefCF.cpp:
+ * API/JSValueRef.cpp:
+ * API/OpaqueJSString.cpp:
+ * API/OpaqueJSString.h:
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ * VM/Machine.cpp:
+ * VM/RegisterFile.h:
+ * debugger/Debugger.h:
+ * kjs/SourceProvider.h:
+ * kjs/TypeInfo.h: Removed.
+ * kjs/collector.cpp: Removed.
+ * kjs/collector.h: Removed.
+ * kjs/completion.h: Removed.
+ * kjs/create_hash_table:
+ * kjs/identifier.cpp: Removed.
+ * kjs/identifier.h: Removed.
+ * kjs/interpreter.cpp: Removed.
+ * kjs/interpreter.h: Removed.
+ * kjs/lexer.cpp:
+ * kjs/lexer.h:
+ * kjs/lookup.cpp: Removed.
+ * kjs/lookup.h: Removed.
+ * kjs/nodes.cpp:
+ * kjs/nodes.h:
+ * kjs/operations.cpp: Removed.
+ * kjs/operations.h: Removed.
+ * kjs/protect.h: Removed.
+ * kjs/regexp.cpp: Removed.
+ * kjs/regexp.h: Removed.
+ * kjs/ustring.cpp: Removed.
+ * kjs/ustring.h: Removed.
+ * pcre/pcre_exec.cpp:
+ * profiler/CallIdentifier.h:
+ * profiler/Profile.h:
+ * runtime/ArrayConstructor.cpp:
+ * runtime/ArrayPrototype.cpp:
+ * runtime/ArrayPrototype.h:
+ * runtime/Collector.cpp: Copied from kjs/collector.cpp.
+ * runtime/Collector.h: Copied from kjs/collector.h.
+ * runtime/CollectorHeapIterator.h:
+ * runtime/Completion.h: Copied from kjs/completion.h.
+ * runtime/ErrorPrototype.cpp:
+ * runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
+ * runtime/Identifier.h: Copied from kjs/identifier.h.
+ * runtime/InitializeThreading.cpp:
+ * runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
+ * runtime/Interpreter.h: Copied from kjs/interpreter.h.
+ * runtime/JSCell.h:
+ * runtime/JSGlobalData.cpp:
+ * runtime/JSGlobalData.h:
+ * runtime/JSLock.cpp:
+ * runtime/JSNumberCell.cpp:
+ * runtime/JSNumberCell.h:
+ * runtime/JSObject.cpp:
+ * runtime/JSValue.h:
+ * runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
+ * runtime/Lookup.h: Copied from kjs/lookup.h.
+ * runtime/MathObject.cpp:
+ * runtime/NativeErrorPrototype.cpp:
+ * runtime/NumberPrototype.cpp:
+ * runtime/Operations.cpp: Copied from kjs/operations.cpp.
+ * runtime/Operations.h: Copied from kjs/operations.h.
+ * runtime/PropertyMapHashTable.h:
+ * runtime/Protect.h: Copied from kjs/protect.h.
+ * runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
+ * runtime/RegExp.h: Copied from kjs/regexp.h.
+ * runtime/RegExpConstructor.cpp:
+ * runtime/RegExpObject.h:
+ * runtime/RegExpPrototype.cpp:
+ * runtime/SmallStrings.h:
+ * runtime/StringObjectThatMasqueradesAsUndefined.h:
+ * runtime/StructureID.cpp:
+ * runtime/StructureID.h:
+ * runtime/StructureIDTransitionTable.h:
+ * runtime/SymbolTable.h:
+ * runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
+ * runtime/UString.cpp: Copied from kjs/ustring.cpp.
+ * runtime/UString.h: Copied from kjs/ustring.h.
+ * wrec/CharacterClassConstructor.h:
+ * wrec/WREC.h:
+
+2008-11-05 Geoffrey Garen <ggaren@apple.com>
+
+ Suggested by Darin Adler.
+
+ Removed two copy constructors that the compiler can generate for us
+ automatically.
+
+ * VM/LabelID.h:
+ (JSC::LabelID::setLocation):
+ (JSC::LabelID::offsetFrom):
+ (JSC::LabelID::ref):
+ (JSC::LabelID::refCount):
+ * kjs/LabelScope.h:
+
+2008-11-05 Anders Carlsson <andersca@apple.com>
+
+ Fix Snow Leopard build.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Steve Falkenburg.
+
+ Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
+ their movement in the filesystem.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore.
+
+ * AllInOneFile.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/dtoa.cpp: Removed.
+ * kjs/dtoa.h: Removed.
+ * wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
+ * wtf/dtoa.h: Copied from kjs/dtoa.h.
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move kjs/config.h to the top level of JavaScriptCore.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * config.h: Copied from kjs/config.h.
+ * kjs/config.h: Removed.
+
+2008-11-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ * wtf/ThreadingNone.cpp: Tweak formatting.
+
+2008-11-03 Darin Adler <darin@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22061
+ create script to check for exit-time destructors
+
+ * JavaScriptCore.exp: Changed to export functions rather than
+ a global for the atomically initialized static mutex.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Added a script
+ phase that runs the check-for-exit-time-destructors script.
+
+ * wtf/MainThread.cpp:
+ (WTF::mainThreadFunctionQueueMutex): Changed to leak an object
+ rather than using an exit time destructor.
+ (WTF::functionQueue): Ditto.
+ * wtf/unicode/icu/CollatorICU.cpp:
+ (WTF::cachedCollatorMutex): Ditto.
+
+ * wtf/Threading.h: Changed other platforms to share the Windows
+ approach where the mutex is internal and the functions are exported.
+ * wtf/ThreadingGtk.cpp:
+ (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
+ (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
+ * wtf/ThreadingNone.cpp:
+ (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
+ (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::threadMapMutex): Changed to leak an object rather than using
+ an exit time destructor.
+ (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
+ (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
+ (WTF::threadMap): Changed to leak an object rather than using
+ an exit time destructor.
+ * wtf/ThreadingQt.cpp:
+ (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
+ (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
+ * wtf/ThreadingWin.cpp:
+ (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.
+
+2008-11-04 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
+ the location of JSStaticScopeObject.{cpp,h}.
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Move AllInOneFile.cpp to the top level of JavaScriptCore.
+
+ * AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
+ * GNUmakefile.am:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/AllInOneFile.cpp: Removed.
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Add NodeInfo.h to the JavaScriptCore Xcode project.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-11-03 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Move more files into the runtime subdirectory of JavaScriptCore.
+
+ * API/JSBase.cpp:
+ * API/JSCallbackConstructor.cpp:
+ * API/JSCallbackFunction.cpp:
+ * API/JSClassRef.cpp:
+ * API/OpaqueJSString.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/AllInOneFile.cpp:
+ * kjs/ArgList.cpp: Removed.
+ * kjs/ArgList.h: Removed.
+ * kjs/Arguments.cpp: Removed.
+ * kjs/Arguments.h: Removed.
+ * kjs/BatchedTransitionOptimizer.h: Removed.
+ * kjs/CollectorHeapIterator.h: Removed.
+ * kjs/CommonIdentifiers.cpp: Removed.
+ * kjs/CommonIdentifiers.h: Removed.
+ * kjs/ExecState.cpp: Removed.
+ * kjs/ExecState.h: Removed.
+ * kjs/GetterSetter.cpp: Removed.
+ * kjs/GetterSetter.h: Removed.
+ * kjs/InitializeThreading.cpp: Removed.
+ * kjs/InitializeThreading.h: Removed.
+ * kjs/JSActivation.cpp: Removed.
+ * kjs/JSActivation.h: Removed.
+ * kjs/JSGlobalData.cpp: Removed.
+ * kjs/JSGlobalData.h: Removed.
+ * kjs/JSLock.cpp: Removed.
+ * kjs/JSLock.h: Removed.
+ * kjs/JSStaticScopeObject.cpp: Removed.
+ * kjs/JSStaticScopeObject.h: Removed.
+ * kjs/JSType.h: Removed.
+ * kjs/PropertyNameArray.cpp: Removed.
+ * kjs/PropertyNameArray.h: Removed.
+ * kjs/ScopeChain.cpp: Removed.
+ * kjs/ScopeChain.h: Removed.
+ * kjs/ScopeChainMark.h: Removed.
+ * kjs/SymbolTable.h: Removed.
+ * kjs/Tracing.d: Removed.
+ * kjs/Tracing.h: Removed.
+ * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
+ * runtime/ArgList.h: Copied from kjs/ArgList.h.
+ * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
+ * runtime/Arguments.h: Copied from kjs/Arguments.h.
+ * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
+ * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
+ * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
+ * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
+ * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
+ * runtime/ExecState.h: Copied from kjs/ExecState.h.
+ * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
+ * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
+ * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
+ * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
+ * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
+ * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
+ * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
+ * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
+ * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
+ * runtime/JSLock.h: Copied from kjs/JSLock.h.
+ * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
+ * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
+ * runtime/JSType.h: Copied from kjs/JSType.h.
+ * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
+ * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
+ * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
+ * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
+ * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
+ * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
+ * runtime/Tracing.d: Copied from kjs/Tracing.d.
+ * runtime/Tracing.h: Copied from kjs/Tracing.h.
+
+2008-11-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
+ turning it on does not require a full rebuild.
+
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics):
+ * runtime/StructureID.h:
+
+2008-11-03 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix warning when building on Darwin without JSC_MULTIPLE_THREADS
+ enabled.
+
+ * kjs/InitializeThreading.cpp:
+
+2008-11-02 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
+ <https://bugs.webkit.org/show_bug.cgi?id=22042>
+
+ Rename parameter name to avoid ASSERT.
+
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::ProgramCodeBlock::ProgramCodeBlock):
+ (JSC::EvalCodeBlock::EvalCodeBlock):
+
+2008-11-02 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 22035: Remove the '_' suffix on constructor parameter names for structs
+ <https://bugs.webkit.org/show_bug.cgi?id=22035>
+
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::ProgramCodeBlock::ProgramCodeBlock):
+ (JSC::EvalCodeBlock::EvalCodeBlock):
+ * wrec/WREC.h:
+ (JSC::Quantifier::Quantifier):
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Geoff Garen.
+
+ Rename SourceRange.h to SourceCode.h.
+
+ * API/JSBase.cpp:
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CodeBlock.h:
+ * kjs/SourceCode.h: Copied from kjs/SourceRange.h.
+ * kjs/SourceRange.h: Removed.
+ * kjs/grammar.y:
+ * kjs/lexer.h:
+ * kjs/nodes.cpp:
+ (JSC::ForInNode::ForInNode):
+ * kjs/nodes.h:
+ (JSC::ThrowableExpressionData::setExceptionSourceCode):
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
+ <https://bugs.webkit.org/show_bug.cgi?id=22019>
+
+ The JSC::Interpreter::shouldPrintExceptions() function is not used at
+ all in JavaScriptCore, so it should be moved to WebCore::Console, its
+ only user.
+
+ * JavaScriptCore.exp:
+ * kjs/interpreter.cpp:
+ * kjs/interpreter.h:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Windows build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Remove the call to Interpreter::setShouldPrintExceptions() from the
+ GlobalObject constructor in the shell. The shouldPrintExceptions()
+ information is not used anywhere in JavaScriptCore, only in WebCore.
+
+ * kjs/Shell.cpp:
+ (GlobalObject::GlobalObject):
+
+2008-10-31 Kevin Ollivier <kevino@theolliviers.com>
+
+ wxMSW build fix.
+
+ * wtf/Threading.h:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move more files from the kjs subdirectory of JavaScriptCore to the
+ runtime subdirectory.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/AllInOneFile.cpp:
+ * kjs/RegExpConstructor.cpp: Removed.
+ * kjs/RegExpConstructor.h: Removed.
+ * kjs/RegExpMatchesArray.h: Removed.
+ * kjs/RegExpObject.cpp: Removed.
+ * kjs/RegExpObject.h: Removed.
+ * kjs/RegExpPrototype.cpp: Removed.
+ * kjs/RegExpPrototype.h: Removed.
+ * runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
+ * runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
+ * runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
+ * runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
+ * runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
+ * runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
+ * runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.
+
+2008-10-31 Mark Rowe <mrowe@apple.com>
+
+ Revert an incorrect portion of r38034.
+
+ * profiler/ProfilerServer.mm:
+
+2008-10-31 Mark Rowe <mrowe@apple.com>
+
+ Fix the 64-bit build.
+
+ Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
+ with the common Obj-C idiom self = [super init];
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Change a header guard to match our coding style.
+
+ * kjs/InitializeThreading.h:
+
+2008-10-30 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
+ AST uses way too much memory
+
+ Removed a word from StatementNode by nixing LabelStack and turning it
+ into a compile-time data structure managed by CodeGenerator.
+
+ v8 tests and SunSpider, run by Gavin, report no change.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.order:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/AllInOneFile.cpp:
+ * JavaScriptCoreSources.bkl: I sure hope this builds!
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::newLabelScope):
+ (JSC::CodeGenerator::breakTarget):
+ (JSC::CodeGenerator::continueTarget):
+ * VM/CodeGenerator.h: Nixed the JumpContext system because it depended
+ on a LabelStack in the AST, and it was a little cumbersome on the client
+ side. Replaced with LabelScope, which tracks all break / continue
+ information in the CodeGenerator, just like we track LabelIDs and other
+ stacks of compile-time data.
+
+ * kjs/LabelScope.h: Added.
+ (JSC::LabelScope::):
+ (JSC::LabelScope::LabelScope):
+ (JSC::LabelScope::ref):
+ (JSC::LabelScope::deref):
+ (JSC::LabelScope::refCount):
+ (JSC::LabelScope::breakTarget):
+ (JSC::LabelScope::continueTarget):
+ (JSC::LabelScope::type):
+ (JSC::LabelScope::name):
+ (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything
+ you might want to know about a break-able / continue-able scope.
+
+ * kjs/LabelStack.cpp: Removed.
+ * kjs/LabelStack.h: Removed.
+
+ * kjs/grammar.y: No need to push labels at parse time -- we don't store
+ LabelStacks in the AST anymore.
+
+ * kjs/nodes.cpp:
+ (JSC::DoWhileNode::emitCode):
+ (JSC::WhileNode::emitCode):
+ (JSC::ForNode::emitCode):
+ (JSC::ForInNode::emitCode):
+ (JSC::ContinueNode::emitCode):
+ (JSC::BreakNode::emitCode):
+ (JSC::SwitchNode::emitCode):
+ (JSC::LabelNode::emitCode):
+ * kjs/nodes.h:
+ (JSC::StatementNode::):
+ (JSC::LabelNode::): Use LabelScope where we used to use JumpContext.
+ Simplified a bunch of code. Touched up label-related error messages a
+ bit.
+
+ * kjs/nodes2string.cpp:
+ (JSC::LabelNode::streamTo): Updated for rename.
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22005: Move StructureIDChain into its own file
+ <https://bugs.webkit.org/show_bug.cgi?id=22005>
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * runtime/StructureID.cpp:
+ * runtime/StructureID.h:
+ * runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
+ * runtime/StructureIDChain.h: Copied from runtime/StructureID.h.
+
+2008-10-31 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2008-10-31 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-10-31 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix storage leak seen on buildbot
+
+ Some other cleanup too. The storage leak was caused by the fact
+ that HashTraits<CallIdentifier>::needsDestruction was false, so
+ the call identifier objects didn't get deleted.
+
+ * profiler/CallIdentifier.h:
+
+ Added a default constructor to create empty call identifiers.
+
+ Changed the normal constructor to use const UString&
+ to avoid extra copying and reference count thrash.
+
+ Removed the explicit copy constructor definition, since it's what
+ the compiler will automatically generate. (Rule of thumb: Either
+ you need both a custom copy constructor and a custom assignment
+ operator, or neither.)
+
+ Moved the CallIdentifier hash function out of the WTF namespace;
+ there's no reason to put it there.
+
+ Changed the CallIdentifier hash function to be a struct rather than
+ a specialization of the IntHash struct template. Having it be
+ a specialization made no sense, since CallIdentifier is not an integer,
+ and did no good.
+
+ Removed explicit definition of emptyValueIsZero in the hash traits,
+ since inheriting from GenericHashTraits already makes that false.
+
+ Removed explicit definition of emptyValue, instead relying on the
+ default constructor and GenericHashTraits.
+
+ Removed explicit definition of needsDestruction, because we want it
+ to have its default value: true, not false. This fixes the leak!
+
+ Changed constructDeletedValue and isDeletedValue to use a line number
+ of numeric_limits<unsigned>::max() to indicate a value is deleted.
+ Previously this used empty strings for the empty value and null strings
+ for the deleted value, but it's more efficient to use null for both.
+
+2008-10-31 Timothy Hatcher <timothy@apple.com>
+
+ Emit the WillExecuteStatement debugger hook before the for loop body
+ when the statement node for the body isn't a block. This allows
+ breakpoints on those statements in the Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22004
+
+ Reviewed by Darin Adler.
+
+ * kjs/nodes.cpp:
+ (JSC::ForNode::emitCode): Emit the WillExecuteStatement
+ debugger hook before the statement node if isn't a block.
+ Also emit the WillExecuteStatement debugger hook for the
+ loop as the first op-code.
+ (JSC::ForInNode::emitCode): Ditto.
+
+2008-10-31 Timothy Hatcher <timothy@apple.com>
+
+ Fixes console warnings about not having an autorelease pool.
+ Also fixes the build for Snow Leopard, by including individual
+ Foundation headers instead of Foundation.h.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21995
+
+ Reviewed by Oliver Hunt.
+
+ * profiler/ProfilerServer.mm:
+ (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculative wxWindows build fix.
+
+ * JavaScriptCoreSources.bkl:
+ * jscore.bkl:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Move VM/JSPropertyNameIterator.cpp and VM/JSPropertyNameIterator.h to
+ the runtime directory.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * VM/JSPropertyNameIterator.cpp: Removed.
+ * VM/JSPropertyNameIterator.h: Removed.
+ * runtime/JSPropertyNameIterator.cpp: Copied from VM/JSPropertyNameIterator.cpp.
+ * runtime/JSPropertyNameIterator.h: Copied from VM/JSPropertyNameIterator.h.
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculative wxWindows build fix.
+
+ * jscore.bkl:
+
+2008-10-30 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Jon Homeycutt.
+
+ Explicitly default to building for only the native architecture in debug and release builds.
+
+ * Configurations/DebugRelease.xcconfig:
+
+2008-10-30 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Create a debugger directory in JavaScriptCore and move the relevant
+ files to it.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CodeBlock.cpp:
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ * debugger: Added.
+ * debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
+ * debugger/Debugger.h: Copied from kjs/debugger.h.
+ * debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
+ * debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
+ * kjs/AllInOneFile.cpp:
+ * kjs/DebuggerCallFrame.cpp: Removed.
+ * kjs/DebuggerCallFrame.h: Removed.
+ * kjs/Parser.cpp:
+ * kjs/Parser.h:
+ * kjs/debugger.cpp: Removed.
+ * kjs/debugger.h: Removed.
+ * kjs/interpreter.cpp:
+ * kjs/nodes.cpp:
+ * runtime/FunctionConstructor.cpp:
+ * runtime/JSGlobalObject.cpp:
+
+2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
+
+ gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
+ warnings; add some parentheses to disambiguate things. No functional
+ changes, so no tests.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21973
+ Add parentheses to clean up some gcc warnings
+
+ Reviewed by Dan Bernstein.
+
+ * wtf/ASCIICType.h:
+ (WTF::isASCIIAlphanumeric):
+ (WTF::isASCIIHexDigit):
+
+2008-10-30 Kevin Lindeman <klindeman@apple.com>
+
+ Adds ProfilerServer, which is a distributed notification listener
+ that allows starting and stopping the profiler remotely for use
+ in conjunction with the profiler's DTace probes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21719
+
+ Reviewed by Timothy Hatcher.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Calls startProfilerServerIfNeeded.
+ * profiler/ProfilerServer.h: Added.
+ * profiler/ProfilerServer.mm: Added.
+ (+[ProfilerServer sharedProfileServer]):
+ (-[ProfilerServer init]):
+ (-[ProfilerServer startProfiling]):
+ (-[ProfilerServer stopProfiling]):
+ (JSC::startProfilerServerIfNeeded):
+
+2008-10-30 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix after PropertyMap and StructureID merge.
+
+ * JavaScriptCoreSources.bkl:
+
+2008-10-30 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Change the JavaScriptCore Xcode project to use relative paths for the
+ PCRE source files.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-10-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich and Geoffrey Garen.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21989
+ Merge PropertyMap and StructureID
+
+ - Move PropertyMap code into StructureID in preparation for lazily
+ creating the map on gets.
+ - Make remove with transition explicit by adding removePropertyTransition.
+ - Make the put/remove without transition explicit.
+ - Make cache invalidation part of put/remove without transition.
+
+ 1% speedup on SunSpider; 0.5% speedup on v8 suite.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/AllInOneFile.cpp:
+ * kjs/identifier.h:
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::removeDirect):
+ * runtime/JSObject.h:
+ (JSC::JSObject::putDirect):
+ * runtime/PropertyMap.cpp: Removed.
+ * runtime/PropertyMap.h: Removed.
+ * runtime/PropertyMapHashTable.h: Copied from runtime/PropertyMap.h.
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics):
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+ (JSC::StructureID::getEnumerablePropertyNames):
+ (JSC::StructureID::addPropertyTransition):
+ (JSC::StructureID::removePropertyTransition):
+ (JSC::StructureID::toDictionaryTransition):
+ (JSC::StructureID::changePrototypeTransition):
+ (JSC::StructureID::getterSetterTransition):
+ (JSC::StructureID::addPropertyWithoutTransition):
+ (JSC::StructureID::removePropertyWithoutTransition):
+ (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
+ (JSC::StructureID::checkConsistency):
+ (JSC::StructureID::copyPropertyTable):
+ (JSC::StructureID::get):
+ (JSC::StructureID::put):
+ (JSC::StructureID::remove):
+ (JSC::StructureID::insertIntoPropertyMapHashTable):
+ (JSC::StructureID::expandPropertyMapHashTable):
+ (JSC::StructureID::createPropertyMapHashTable):
+ (JSC::StructureID::rehashPropertyMapHashTable):
+ (JSC::comparePropertyMapEntryIndices):
+ (JSC::StructureID::getEnumerablePropertyNamesInternal):
+ * runtime/StructureID.h:
+ (JSC::StructureID::propertyStorageSize):
+ (JSC::StructureID::isEmpty):
+ (JSC::StructureID::get):
+
+2008-10-30 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
+ <https://bugs.webkit.org/show_bug.cgi?id=21987>
+
+ CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
+ register as ecx, but it should be tempReg1, which is ecx at all of its
+ callsites.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+
+2008-10-30 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 21985: Opcodes should use eax as their destination register whenever possible
+ <https://bugs.webkit.org/show_bug.cgi?id=21985>
+
+ Change more opcodes to use eax as the register for their final result,
+ and change calls to emitPutResult() that pass eax to rely on the default
+ value of eax.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+
+2008-10-30 Alp Toker <alp@nuanti.com>
+
+ Build fix attempt for older gcc on the trunk-mac-intel build bot
+ (error: initializer for scalar variable requires one element).
+
+ Modify the initializer syntax slightly with an additional comma.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_post_dec):
+
+2008-10-30 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21571
+ VoidPtrPair breaks CTI on Linux
+
+ The VoidPtrPair return change made in r37457 does not work on Linux
+ since POD structs aren't passed in registers.
+
+ This patch uses a union to vectorize VoidPtrPair to a uint64_t and
+ matches Darwin/MSVC fixing CTI/WREC on Linux.
+
+ Alexey reports no measurable change in Mac performance with this fix.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_post_dec):
+ * VM/Machine.h:
+ (JSC::):
+
+2008-10-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Initial work to reduce cost of JSNumberCell allocation
+
+ This does the initial work needed to bring more of number
+ allocation into CTI code directly, rather than just falling
+ back onto the slow paths if we can't guarantee that a number
+ cell can be reused.
+
+ Initial implementation only used by op_negate to make sure
+ it all works. In a negate heavy (though not dominated) test
+ it results in a 10% win in the non-reusable cell case.
+
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::emitAllocateNumber):
+ (JSC::CTI::emitNakedFastCall):
+ (JSC::CTI::emitArithIntToImmWithJump):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitUnaryOp):
+ * VM/CodeGenerator.h:
+ (JSC::CodeGenerator::emitToJSNumber):
+ (JSC::CodeGenerator::emitTypeOf):
+ (JSC::CodeGenerator::emitGetPropertyNames):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ * VM/Machine.h:
+ * kjs/ResultType.h:
+ (JSC::ResultType::isReusableNumber):
+ (JSC::ResultType::toInt):
+ * kjs/nodes.cpp:
+ (JSC::UnaryOpNode::emitCode):
+ (JSC::BinaryOpNode::emitCode):
+ (JSC::EqualNode::emitCode):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::negl_r):
+ (JSC::X86Assembler::xorpd_mr):
+ * runtime/JSNumberCell.h:
+ (JSC::JSNumberCell::JSNumberCell):
+
+2008-10-29 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6326563> Crash on launch
+
+ For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
+
+ Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
+ callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
+ the explicit lock/unlock functions, we can avoid this.
+
+ Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
+
+ Reviewed by Darin Adler.
+
+ * wtf/Threading.h:
+ (WTF::lockAtomicallyInitializedStaticMutex):
+ (WTF::unlockAtomicallyInitializedStaticMutex):
+ * wtf/ThreadingWin.cpp:
+ (WTF::lockAtomicallyInitializedStaticMutex):
+ (WTF::unlockAtomicallyInitializedStaticMutex):
+
+2008-10-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Remove direct use of PropertyMap.
+
+ * JavaScriptCore.exp:
+ * runtime/JSObject.cpp:
+ (JSC::JSObject::mark):
+ (JSC::JSObject::put):
+ (JSC::JSObject::deleteProperty):
+ (JSC::JSObject::getPropertyAttributes):
+ (JSC::JSObject::removeDirect):
+ * runtime/JSObject.h:
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::hasCustomProperties):
+ (JSC::JSObject::JSObject):
+ (JSC::JSObject::putDirect):
+ * runtime/PropertyMap.cpp:
+ (JSC::PropertyMap::get):
+ * runtime/PropertyMap.h:
+ (JSC::PropertyMap::isEmpty):
+ (JSC::PropertyMap::get):
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics):
+ * runtime/StructureID.h:
+ (JSC::StructureID::propertyStorageSize):
+ (JSC::StructureID::get):
+ (JSC::StructureID::put):
+ (JSC::StructureID::remove):
+ (JSC::StructureID::isEmpty):
+
+2008-10-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Rename and move the StructureID transition table to its own file.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::addPropertyTransition):
+ * runtime/StructureID.h:
+ (JSC::StructureID::):
+ * runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h.
+ (JSC::StructureIDTransitionTableHash::hash):
+ (JSC::StructureIDTransitionTableHash::equal):
+
+2008-10-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21958
+ Pack bits in StructureID to reduce the size of each StructureID by 2 words.
+
+ * runtime/PropertyMap.h:
+ (JSC::PropertyMap::propertyMapSize):
+ * runtime/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping.
+ (JSC::StructureID::StructureID):
+ * runtime/StructureID.h:
+
+2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after addition of runtime and ImageBuffer changes.
+
+ * JavaScriptCoreSources.bkl:
+ * jscore.bkl:
+
+2008-10-29 Timothy Hatcher <timothy@apple.com>
+
+ Emit the WillExecuteStatement debugger hook before the "else" body
+ when there is no block for the "else" body. This allows breakpoints
+ on those statements in the Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21944
+
+ Reviewed by Maciej Stachowiak.
+
+ * kjs/nodes.cpp:
+ (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement
+ debugger hook before the else node if isn't a block.
+
+2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * JavaScriptCore.exp: Export HashTable::deleteTable().
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ Fix builddir != srcdir builds after kjs -> runtime breakage. Sources
+ may now be generated in both kjs/ and runtime/.
+
+ Also sort the sources list for readability.
+
+ * GNUmakefile.am:
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Build fix attempt after kjs -> runtime rename.
+
+ * GNUmakefile.am:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Remove a duplicate includes directory.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Attempt to fix the Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2008-10-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - export WTF::atomicallyInitializedStaticMutex
+
+ * JavaScriptCore.exp:
+
+2008-10-28 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed CodeBlock dumping to accurately report constant register indices.
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ More Qt build fixes.
+
+ * JavaScriptCore.pri:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the Qt build, hopefully for real this time.
+
+ * JavaScriptCore.pri:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the Qt build.
+
+ * JavaScriptCore.pri:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Create a runtime directory in JavaScriptCore and begin moving files to
+ it. This is the first step towards removing the kjs directory and
+ placing files in more meaningful subdirectories of JavaScriptCore.
+
+ * API/JSBase.cpp:
+ * API/JSCallbackConstructor.cpp:
+ * API/JSCallbackConstructor.h:
+ * API/JSCallbackFunction.cpp:
+ * API/JSClassRef.cpp:
+ * API/JSClassRef.h:
+ * API/JSStringRefCF.cpp:
+ * API/JSValueRef.cpp:
+ * API/OpaqueJSString.cpp:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/AllInOneFile.cpp:
+ * kjs/ArrayConstructor.cpp: Removed.
+ * kjs/ArrayConstructor.h: Removed.
+ * kjs/ArrayPrototype.cpp: Removed.
+ * kjs/ArrayPrototype.h: Removed.
+ * kjs/BooleanConstructor.cpp: Removed.
+ * kjs/BooleanConstructor.h: Removed.
+ * kjs/BooleanObject.cpp: Removed.
+ * kjs/BooleanObject.h: Removed.
+ * kjs/BooleanPrototype.cpp: Removed.
+ * kjs/BooleanPrototype.h: Removed.
+ * kjs/CallData.cpp: Removed.
+ * kjs/CallData.h: Removed.
+ * kjs/ClassInfo.h: Removed.
+ * kjs/ConstructData.cpp: Removed.
+ * kjs/ConstructData.h: Removed.
+ * kjs/DateConstructor.cpp: Removed.
+ * kjs/DateConstructor.h: Removed.
+ * kjs/DateInstance.cpp: Removed.
+ * kjs/DateInstance.h: Removed.
+ * kjs/DateMath.cpp: Removed.
+ * kjs/DateMath.h: Removed.
+ * kjs/DatePrototype.cpp: Removed.
+ * kjs/DatePrototype.h: Removed.
+ * kjs/Error.cpp: Removed.
+ * kjs/Error.h: Removed.
+ * kjs/ErrorConstructor.cpp: Removed.
+ * kjs/ErrorConstructor.h: Removed.
+ * kjs/ErrorInstance.cpp: Removed.
+ * kjs/ErrorInstance.h: Removed.
+ * kjs/ErrorPrototype.cpp: Removed.
+ * kjs/ErrorPrototype.h: Removed.
+ * kjs/FunctionConstructor.cpp: Removed.
+ * kjs/FunctionConstructor.h: Removed.
+ * kjs/FunctionPrototype.cpp: Removed.
+ * kjs/FunctionPrototype.h: Removed.
+ * kjs/GlobalEvalFunction.cpp: Removed.
+ * kjs/GlobalEvalFunction.h: Removed.
+ * kjs/InternalFunction.cpp: Removed.
+ * kjs/InternalFunction.h: Removed.
+ * kjs/JSArray.cpp: Removed.
+ * kjs/JSArray.h: Removed.
+ * kjs/JSCell.cpp: Removed.
+ * kjs/JSCell.h: Removed.
+ * kjs/JSFunction.cpp: Removed.
+ * kjs/JSFunction.h: Removed.
+ * kjs/JSGlobalObject.cpp: Removed.
+ * kjs/JSGlobalObject.h: Removed.
+ * kjs/JSGlobalObjectFunctions.cpp: Removed.
+ * kjs/JSGlobalObjectFunctions.h: Removed.
+ * kjs/JSImmediate.cpp: Removed.
+ * kjs/JSImmediate.h: Removed.
+ * kjs/JSNotAnObject.cpp: Removed.
+ * kjs/JSNotAnObject.h: Removed.
+ * kjs/JSNumberCell.cpp: Removed.
+ * kjs/JSNumberCell.h: Removed.
+ * kjs/JSObject.cpp: Removed.
+ * kjs/JSObject.h: Removed.
+ * kjs/JSString.cpp: Removed.
+ * kjs/JSString.h: Removed.
+ * kjs/JSValue.cpp: Removed.
+ * kjs/JSValue.h: Removed.
+ * kjs/JSVariableObject.cpp: Removed.
+ * kjs/JSVariableObject.h: Removed.
+ * kjs/JSWrapperObject.cpp: Removed.
+ * kjs/JSWrapperObject.h: Removed.
+ * kjs/MathObject.cpp: Removed.
+ * kjs/MathObject.h: Removed.
+ * kjs/NativeErrorConstructor.cpp: Removed.
+ * kjs/NativeErrorConstructor.h: Removed.
+ * kjs/NativeErrorPrototype.cpp: Removed.
+ * kjs/NativeErrorPrototype.h: Removed.
+ * kjs/NumberConstructor.cpp: Removed.
+ * kjs/NumberConstructor.h: Removed.
+ * kjs/NumberObject.cpp: Removed.
+ * kjs/NumberObject.h: Removed.
+ * kjs/NumberPrototype.cpp: Removed.
+ * kjs/NumberPrototype.h: Removed.
+ * kjs/ObjectConstructor.cpp: Removed.
+ * kjs/ObjectConstructor.h: Removed.
+ * kjs/ObjectPrototype.cpp: Removed.
+ * kjs/ObjectPrototype.h: Removed.
+ * kjs/PropertyMap.cpp: Removed.
+ * kjs/PropertyMap.h: Removed.
+ * kjs/PropertySlot.cpp: Removed.
+ * kjs/PropertySlot.h: Removed.
+ * kjs/PrototypeFunction.cpp: Removed.
+ * kjs/PrototypeFunction.h: Removed.
+ * kjs/PutPropertySlot.h: Removed.
+ * kjs/SmallStrings.cpp: Removed.
+ * kjs/SmallStrings.h: Removed.
+ * kjs/StringConstructor.cpp: Removed.
+ * kjs/StringConstructor.h: Removed.
+ * kjs/StringObject.cpp: Removed.
+ * kjs/StringObject.h: Removed.
+ * kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
+ * kjs/StringPrototype.cpp: Removed.
+ * kjs/StringPrototype.h: Removed.
+ * kjs/StructureID.cpp: Removed.
+ * kjs/StructureID.h: Removed.
+ * kjs/completion.h:
+ * kjs/interpreter.h:
+ * runtime: Added.
+ * runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
+ * runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
+ * runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
+ * runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
+ * runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
+ * runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
+ * runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
+ * runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
+ * runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
+ * runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
+ * runtime/CallData.cpp: Copied from kjs/CallData.cpp.
+ * runtime/CallData.h: Copied from kjs/CallData.h.
+ * runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
+ * runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
+ * runtime/ConstructData.h: Copied from kjs/ConstructData.h.
+ * runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
+ * runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
+ * runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
+ * runtime/DateInstance.h: Copied from kjs/DateInstance.h.
+ * runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
+ * runtime/DateMath.h: Copied from kjs/DateMath.h.
+ * runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
+ * runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
+ * runtime/Error.cpp: Copied from kjs/Error.cpp.
+ * runtime/Error.h: Copied from kjs/Error.h.
+ * runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
+ * runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
+ * runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
+ * runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
+ * runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
+ * runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
+ * runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
+ * runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
+ * runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
+ * runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
+ * runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
+ * runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
+ * runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
+ * runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
+ * runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
+ * runtime/JSArray.h: Copied from kjs/JSArray.h.
+ * runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
+ * runtime/JSCell.h: Copied from kjs/JSCell.h.
+ * runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
+ * runtime/JSFunction.h: Copied from kjs/JSFunction.h.
+ * runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
+ * runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
+ * runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
+ * runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
+ * runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
+ * runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
+ * runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
+ * runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
+ * runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
+ * runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
+ * runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
+ * runtime/JSObject.h: Copied from kjs/JSObject.h.
+ * runtime/JSString.cpp: Copied from kjs/JSString.cpp.
+ * runtime/JSString.h: Copied from kjs/JSString.h.
+ * runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
+ * runtime/JSValue.h: Copied from kjs/JSValue.h.
+ * runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
+ * runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
+ * runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
+ * runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
+ * runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
+ * runtime/MathObject.h: Copied from kjs/MathObject.h.
+ * runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
+ * runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
+ * runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
+ * runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
+ * runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
+ * runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
+ * runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
+ * runtime/NumberObject.h: Copied from kjs/NumberObject.h.
+ * runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
+ * runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
+ * runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
+ * runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
+ * runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
+ * runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
+ * runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
+ * runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
+ * runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
+ * runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
+ * runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
+ * runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
+ * runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
+ * runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
+ * runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
+ * runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
+ * runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
+ * runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
+ * runtime/StringObject.h: Copied from kjs/StringObject.h.
+ * runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
+ * runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
+ * runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
+ * runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
+ * runtime/StructureID.h: Copied from kjs/StructureID.h.
+
+2008-10-28 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
+ Sampler reports bogus time in op_enter during 3d-raytrace.js
+
+ Fixed a bug where we would pass the incorrect Instruction* during some
+ parts of CTI codegen.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/SamplingTool.cpp:
+ (JSC::SamplingTool::run):
+ * wtf/Platform.h:
+
+2008-10-28 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ -Removed unused includes.
+ Apparent .4% speedup in Sunspider
+
+ * kjs/JSObject.cpp:
+ * kjs/interpreter.cpp:
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ Include copyright license files in the autotools dist target.
+
+ Change suggested by Mike Hommey.
+
+ * GNUmakefile.am:
+
+2008-10-27 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Stop discarding CodeBlock samples that can't be charged to a specific
+ opcode. Instead, charge the relevant CodeBlock, and provide a footnote
+ explaining the situation.
+
+ This will help us tell which CodeBlocks are hot, even if we can't
+ identify specific lines of code within the CodeBlocks.
+
+ * VM/SamplingTool.cpp:
+ (JSC::ScopeSampleRecord::sample):
+ (JSC::compareScopeSampleRecords):
+ (JSC::SamplingTool::dump):
+
+ * VM/SamplingTool.h:
+ (JSC::ScopeSampleRecord::ScopeSampleRecord):
+ (JSC::ScopeSampleRecord::~ScopeSampleRecord):
+
+2008-10-27 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
+ when sampling the v8 tests.
+
+ * VM/SamplingTool.cpp:
+ (JSC::SamplingTool::run):
+ (JSC::SamplingTool::notifyOfScope):
+ * VM/SamplingTool.h: Since new ScopeNodes can be created after
+ the SamplingTools has begun sampling, reads and writes to / from the
+ map need to be synchronized. Shark says this doesn't measurably increase
+ sampling overhead.
+
+2008-10-25 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): Provide a dummy value to the
+ HostCallRecord in CTI non-sampling builds, to silence compiler warning.
+
+2008-10-25 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to
+ silence compiler warning.
+
+2008-10-25 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig, with Gavin Barraclough's help.
+
+ Fixed Sampling Tool:
+ - Made CodeBlock sampling work with CTI
+ - Improved accuracy by unifying most sampling data into a single
+ 32bit word, which can be written / read atomically.
+ - Split out three different #ifdefs for modularity: OPCODE_SAMPLING;
+ CODEBLOCK_SAMPLING; OPCODE_STATS.
+ - Improved reporting clarity
+ - Refactored for code clarity
+
+ * JavaScriptCore.exp: Exported another symbol.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface
+ for encoding samples. (This required passing the current vPC to a lot
+ more functions, since the unified interface samples the current vPC.)
+ Added hooks for writing the current CodeBlock* on function entry and
+ after a function call, for the sake of the CodeBlock sampler. Removed
+ obsolete hook for clearing the current sample inside op_end. Also removed
+ the custom enum used to differentiate flavors of op_call, since the
+ OpcodeID enum works just as well. (This was important in an earlier
+ version of the patch, but now it's just cleanup.)
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::lineNumberForVPC):
+ * VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC
+ to be robust against vPCs not recorded for exception handling, since
+ the Sampler may ask for an arbitrary vPC.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::execute):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ * VM/Machine.h:
+ (JSC::Machine::setSampler):
+ (JSC::Machine::sampler):
+ (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed
+ Machine to use SamplingTool helper objects to record movement in and
+ out of host code. This makes samples a bit more precise.
+
+ * VM/Opcode.cpp:
+ (JSC::OpcodeStats::~OpcodeStats):
+ * VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding,
+ to accomodate our more verbose opcode names.
+
+ * VM/SamplingTool.cpp:
+ (JSC::ScopeSampleRecord::sample): Only count a sample toward our total
+ if we actually record it. This solves cases where a CodeBlock will
+ claim to have been sampled many times, with reported samples that don't
+ match.
+
+ (JSC::SamplingTool::run): Read the current sample into a Sample helper
+ object, to ensure that the data doesn't change while we're analyzing it,
+ and to help decode the data. Only access the CodeBlock sampling hash
+ table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
+ runs can operate with even less overhead.
+
+ (JSC::SamplingTool::dump): I reorganized this code a lot to print the
+ most important info at the top, print as a table, annotate and document
+ the stuff I didn't understand when I started, etc.
+
+ * VM/SamplingTool.h: New helper classes, described above.
+
+ * kjs/Parser.h:
+ * kjs/Shell.cpp:
+ (runWithScripts):
+ * kjs/nodes.cpp:
+ (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.
+
+ * wtf/Platform.h: Moved sampling #defines here, since our custom is to
+ put ENABLE #defines into Platform.h. Made explicit the fact that
+ CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.
+
+2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ JSC Build fix, not reviewed.
+
+ * VM/CTI.cpp: add missing include stdio.h for debug builds
+
+2008-10-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Get rid of a bonus ASSERT when using a null string as a regexp.
+ Specifically calling: RegularExpression::match() with String::empty()
+ will hit this ASSERT.
+ Chromium hits this, but I don't know of any way to make a layout test.
+
+ * pcre/pcre_exec.cpp:
+ (jsRegExpExecute):
+
+2008-10-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Suggested and rubber-stamped by Geoff Garen.
+
+ Fix a crash when opening Font Picker.
+
+ The change also hopefully fixes this bug, which I could never reproduce:
+ https://bugs.webkit.org/show_bug.cgi?id=20241
+ <rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close
+
+ * API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of
+ dynamic one.
+
+2008-10-24 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove ScopeChainNode::bottom() and inline it into its only caller,
+ ScopeChainnode::globalObject().
+
+ * kjs/JSGlobalObject.h:
+ (JSC::ScopeChainNode::globalObject):
+ * kjs/ScopeChain.h:
+ (JSC::ScopeChain::bottom):
+
+2008-10-24 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21862: Create JSFunction prototype property lazily
+ <https://bugs.webkit.org/show_bug.cgi?id=21862>
+
+ This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
+ benchmark suite, including a 3.8% speedup on Earley-Boyer.
+
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::getOwnPropertySlot):
+ * kjs/nodes.cpp:
+ (JSC::FuncDeclNode::makeFunction):
+ (JSC::FuncExprNode::makeFunction):
+
+2008-10-24 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21475
+
+ Provide support for the Geolocation API
+
+ http://dev.w3.org/geo/api/spec-source.html
+
+ * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0
+
+2008-10-24 Darin Adler <darin@apple.com>
+
+ - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
+
+ * API/APICast.h:
+ * API/JSCallbackConstructor.h:
+ * API/JSCallbackFunction.cpp:
+ * API/JSCallbackFunction.h:
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ * API/JSValueRef.cpp:
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ * VM/CodeGenerator.h:
+ * VM/ExceptionHelpers.cpp:
+ * VM/ExceptionHelpers.h:
+ * VM/JSPropertyNameIterator.cpp:
+ * VM/JSPropertyNameIterator.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * VM/Register.h:
+ * kjs/ArgList.cpp:
+ * kjs/ArgList.h:
+ * kjs/Arguments.cpp:
+ * kjs/Arguments.h:
+ * kjs/ArrayConstructor.cpp:
+ * kjs/ArrayPrototype.cpp:
+ * kjs/BooleanConstructor.cpp:
+ * kjs/BooleanConstructor.h:
+ * kjs/BooleanObject.h:
+ * kjs/BooleanPrototype.cpp:
+ * kjs/CallData.cpp:
+ * kjs/CallData.h:
+ * kjs/ConstructData.cpp:
+ * kjs/ConstructData.h:
+ * kjs/DateConstructor.cpp:
+ * kjs/DateInstance.h:
+ * kjs/DatePrototype.cpp:
+ * kjs/DatePrototype.h:
+ * kjs/DebuggerCallFrame.cpp:
+ * kjs/DebuggerCallFrame.h:
+ * kjs/ErrorConstructor.cpp:
+ * kjs/ErrorPrototype.cpp:
+ * kjs/ExecState.cpp:
+ * kjs/ExecState.h:
+ * kjs/FunctionConstructor.cpp:
+ * kjs/FunctionPrototype.cpp:
+ * kjs/FunctionPrototype.h:
+ * kjs/GetterSetter.cpp:
+ * kjs/GetterSetter.h:
+ * kjs/InternalFunction.h:
+ * kjs/JSActivation.cpp:
+ * kjs/JSActivation.h:
+ * kjs/JSArray.cpp:
+ * kjs/JSArray.h:
+ * kjs/JSCell.cpp:
+ * kjs/JSCell.h:
+ * kjs/JSFunction.cpp:
+ * kjs/JSFunction.h:
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.cpp:
+ * kjs/JSGlobalObject.h:
+ * kjs/JSGlobalObjectFunctions.cpp:
+ * kjs/JSGlobalObjectFunctions.h:
+ * kjs/JSImmediate.cpp:
+ * kjs/JSImmediate.h:
+ * kjs/JSNotAnObject.cpp:
+ * kjs/JSNotAnObject.h:
+ * kjs/JSNumberCell.cpp:
+ * kjs/JSNumberCell.h:
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ * kjs/JSStaticScopeObject.cpp:
+ * kjs/JSStaticScopeObject.h:
+ * kjs/JSString.cpp:
+ * kjs/JSString.h:
+ * kjs/JSValue.h:
+ * kjs/JSVariableObject.h:
+ * kjs/JSWrapperObject.h:
+ * kjs/MathObject.cpp:
+ * kjs/MathObject.h:
+ * kjs/NativeErrorConstructor.cpp:
+ * kjs/NumberConstructor.cpp:
+ * kjs/NumberConstructor.h:
+ * kjs/NumberObject.cpp:
+ * kjs/NumberObject.h:
+ * kjs/NumberPrototype.cpp:
+ * kjs/ObjectConstructor.cpp:
+ * kjs/ObjectPrototype.cpp:
+ * kjs/ObjectPrototype.h:
+ * kjs/PropertyMap.h:
+ * kjs/PropertySlot.cpp:
+ * kjs/PropertySlot.h:
+ * kjs/RegExpConstructor.cpp:
+ * kjs/RegExpConstructor.h:
+ * kjs/RegExpMatchesArray.h:
+ * kjs/RegExpObject.cpp:
+ * kjs/RegExpObject.h:
+ * kjs/RegExpPrototype.cpp:
+ * kjs/Shell.cpp:
+ * kjs/StringConstructor.cpp:
+ * kjs/StringObject.cpp:
+ * kjs/StringObject.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ * kjs/StringPrototype.cpp:
+ * kjs/StructureID.cpp:
+ * kjs/StructureID.h:
+ * kjs/collector.cpp:
+ * kjs/collector.h:
+ * kjs/completion.h:
+ * kjs/grammar.y:
+ * kjs/interpreter.cpp:
+ * kjs/interpreter.h:
+ * kjs/lookup.cpp:
+ * kjs/lookup.h:
+ * kjs/nodes.h:
+ * kjs/operations.cpp:
+ * kjs/operations.h:
+ * kjs/protect.h:
+ * profiler/ProfileGenerator.cpp:
+ * profiler/Profiler.cpp:
+ * profiler/Profiler.h:
+ Use JSValue* instead of JSValuePtr.
+
+2008-10-24 David Kilzer <ddkilzer@apple.com>
+
+ Rolled out r37840.
+
+ * wtf/Platform.h:
+
+2008-10-23 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21475
+
+ Provide support for the Geolocation API
+
+ http://dev.w3.org/geo/api/spec-source.html
+
+ * wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0
+
+2008-10-23 David Kilzer <ddkilzer@apple.com>
+
+ Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21832>
+
+ Reviewed by Sam Weinig.
+
+ * pcre/dftables: Use imported tempfile() from File::Temp instead of
+ 'new File::Temp' to make the script work with Perl 5.10.
+
+2008-10-23 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix hideous pathological case performance when looking up repatch info, bug #21727.
+
+ When repatching JIT code to optimize we look up records providing information about
+ the generated code (also used to track recsources used in linking to be later released).
+ The lookup was being performed using a linear scan of all such records.
+
+ (1) Split up the different types of reptach information. This means we can search them
+ separately, and in some cases should reduce their size.
+ (2) In the case of property accesses, search with a binary chop over the data.
+ (3) In the case of calls, pass a pointer to the repatch info into the relink function.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::unlinkCall):
+ (JSC::CTI::linkCall):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::unlinkCallers):
+ (JSC::CodeBlock::derefStructureIDs):
+ * VM/CodeBlock.h:
+ (JSC::StructureStubInfo::StructureStubInfo):
+ (JSC::CallLinkInfo::CallLinkInfo):
+ (JSC::CallLinkInfo::setUnlinked):
+ (JSC::CallLinkInfo::isLinked):
+ (JSC::getStructureStubInfoReturnLocation):
+ (JSC::binaryChop):
+ (JSC::CodeBlock::addCaller):
+ (JSC::CodeBlock::getStubInfo):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitResolve):
+ (JSC::CodeGenerator::emitGetById):
+ (JSC::CodeGenerator::emitPutById):
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitConstruct):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_vm_lazyLinkCall):
+
+2008-10-23 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21833
+ Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
+
+ * wtf/Platform.h:
+
+2008-10-23 David Kilzer <ddkilzer@apple.com>
+
+ Bug 21831: Fix create_hash_table for Perl 5.10
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21831>
+
+ Reviewed by Sam Weinig.
+
+ * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
+ doesn't try to use @nameEntries.
+
+2008-10-23 Darin Adler <darin@apple.com>
+
+ - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
+ to remove the JSValuePtr class, to fix two problems
+
+ 1) slowness under MSVC, since it doesn't handle a
+ class with a single pointer in it as efficiently
+ as a pointer
+
+ 2) uninitialized pointers in Vector
+
+ * JavaScriptCore.exp: Updated.
+
+ * API/APICast.h:
+ (toRef):
+ * VM/CTI.cpp:
+ (JSC::CTI::asInteger):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::addConstant):
+ * VM/CodeGenerator.h:
+ (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue):
+ (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_vm_throw):
+ Removed calls to payload functions.
+
+ * VM/Register.h:
+ (JSC::Register::Register): Removed overload for JSCell and call
+ to payload function.
+
+ * kjs/JSCell.h: Changed JSCell to derive from JSValue again.
+ Removed JSValuePtr constructor.
+ (JSC::asCell): Changed cast from reinterpret_cast to static_cast.
+
+ * kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.
+
+ * kjs/JSValue.h:
+ (JSC::JSValue::JSValue): Added empty protected inline constructor back.
+ (JSC::JSValue::~JSValue): Same for destructor.
+ Removed == and != operator for JSValuePtr.
+
+ * kjs/PropertySlot.h:
+ (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue*
+ and added a const_cast.
+
+ * kjs/protect.h: Removed overloads and specialization for JSValuePtr.
+
+2008-10-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Really "fix" CTI mode on windows 2k3.
+
+ This adds new methods fastMallocExecutable and fastFreeExecutable
+ to wrap allocation for cti code. This still just makes fastMalloc
+ return executable memory all the time, which will be fixed in a
+ later patch.
+
+ However in windows debug builds all executable allocations will be
+ allocated on separate executable pages, which should resolve any
+ remaining 2k3 issues. Conveniently the 2k3 bot will now also fail
+ if there are any fastFree vs. fastFreeExecutable errors.
+
+ * ChangeLog:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::~CodeBlock):
+ * kjs/regexp.cpp:
+ (JSC::RegExp::~RegExp):
+ * masm/X86Assembler.h:
+ (JSC::JITCodeBuffer::copy):
+ * wtf/FastMalloc.cpp:
+ (WTF::fastMallocExecutable):
+ (WTF::fastFreeExecutable):
+ (WTF::TCMallocStats::fastMallocExecutable):
+ (WTF::TCMallocStats::fastFreeExecutable):
+ * wtf/FastMalloc.h:
+
+2008-10-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21294
+ Bug 21294: Devirtualize getOwnPropertySlot()
+
+ A bit over 3% faster on V8 tests.
+
+ * JavascriptCore.exp: Export leak-related functions..
+
+ * API/JSCallbackConstructor.h:
+ (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot
+ since this class doesn't override getPropertySlot.
+ * API/JSCallbackFunction.h:
+ (JSC::JSCallbackFunction::createStructureID): Ditto.
+
+ * VM/ExceptionHelpers.cpp:
+ (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure
+ that's created just for this class instead of trying to share a single "null
+ prototype" structure.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_create_arguments_no_params): Rename
+ Arguments::ArgumentsNoParameters to Arguments::NoParameters.
+
+ * kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to
+ Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters
+ to Arguments::NoParameters.
+ (JSC::Arguments::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+ (JSC::Arguments::Arguments): Added an assertion that there are no parameters.
+
+ * kjs/DatePrototype.h:
+ (JSC::DatePrototype::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * kjs/FunctionPrototype.h:
+ (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot
+ since this class doesn't override getPropertySlot.
+ * kjs/InternalFunction.h:
+ (JSC::InternalFunction::createStructureID): Ditto.
+
+ * kjs/JSArray.h:
+ (JSC::JSArray::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual
+ version that uses the structure bit to decide whether to call the virtual
+ version.
+
+ * kjs/JSFunction.h:
+ (JSC::JSFunction::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed
+ nullProtoStructureID.
+ * kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.
+
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * kjs/JSNotAnObject.h:
+ (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure
+ that's created just for this class instead of trying to share a single "null
+ prototype" structure.
+ (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function
+ virtual for clarity and made it private since no one should call it if they
+ already have a pointer to this specific type.
+ (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just
+ for this class instead of trying to share a single "null prototype" structure.
+ (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * kjs/JSObject.h:
+ (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot.
+ (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code
+ between getOwnPropertySlot and fastGetOwnPropertySlot.
+ (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the
+ functions that call them. Moved the guts of this function into
+ inlineGetOwnPropertySlot.
+ (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the
+ HasStandardGetOwnPropertySlot bit and if it's set, calls
+ inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot.
+ (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot.
+ (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.
+
+ * kjs/JSWrapperObject.h: Made constructor protected to emphasize that
+ this class is only a base class and never instantiated.
+
+ * kjs/MathObject.h:
+ (JSC::MathObject::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+ * kjs/NumberConstructor.h:
+ (JSC::NumberConstructor::createStructureID): Ditto.
+ * kjs/RegExpConstructor.h:
+ (JSC::RegExpConstructor::createStructureID): Ditto.
+ * kjs/RegExpObject.h:
+ (JSC::RegExpObject::createStructureID): Ditto.
+ * kjs/StringObject.h:
+ (JSC::StringObject::createStructureID): Ditto.
+
+ * kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and
+ hasStandardGetOwnPropertySlot accessor function.
+
+2008-10-22 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
+ <https://bugs.webkit.org/show_bug.cgi?id=21803>
+
+ Fuse op_jfalse with op_eq_null and op_neq_null to make the new opcodes
+ op_jeq_null and op_jneq_null.
+
+ This is a 2.6% speedup on the V8 Raytrace benchmark, and strangely also
+ a 4.7% speedup on the V8 Arguments benchmark, even though it uses
+ neither of the two new opcodes.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitJumpIfTrue):
+ (JSC::CodeGenerator::emitJumpIfFalse):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ * VM/Opcode.h:
+
+2008-10-22 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
+ https://bugs.webkit.org/show_bug.cgi?id=21757
+
+ PLATFORM(CHROMIUM) implies HAVE_ACCESSIBILITY
+
+ * wtf/Platform.h:
+
+2008-10-22 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Correct opcode names in documentation.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-21 Oliver Hunt <oliver@apple.com>
+
+ RS=Maciej Stachowiak.
+
+ Force FastMalloc to make all allocated pages executable in
+ a vague hope this will allow the Win2k3 bot to be able to
+ run tests.
+
+ Filed Bug 21783: Need more granular control over allocation of executable memory
+ to cover a more granular version of this patch.
+
+ * wtf/TCSystemAlloc.cpp:
+ (TryVirtualAlloc):
+
+2008-10-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21769
+ MessagePort should be GC protected if there are messages to be delivered
+
+ * wtf/MessageQueue.h:
+ (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue
+ state, thus likely to cause race conditions.
+
+2008-10-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - convert post-increment to pre-increment in a couple more places for speed
+
+ Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
+ them down a little on my computer.)
+
+ * kjs/nodes.cpp:
+ (JSC::statementListEmitCode): Removed default argument, since we always want
+ to specify this explicitly.
+ (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the
+ same thing as 0.
+ (JSC::ReturnNode::emitCode): Ditto.
+ (JSC::ThrowNode::emitCode): Ditto.
+ (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we
+ don't have to compute the result of function statements.
+
+2008-10-21 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix an include of a non-public header to use "" instead of <>.
+
+ * API/JSProfilerPrivate.cpp:
+
+2008-10-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
+ REGRESSION: 12 JSC tests fail
+
+ The JSGlobalObject was mutating the shared nullProtoStructureID when
+ used in jsc. Instead of using nullProtoStructureID, use a new StructureID.
+
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::JSCallbackObject):
+ * API/JSContextRef.cpp:
+ (JSGlobalContextCreateInGroup):
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObject):
+ * kjs/Shell.cpp:
+ (GlobalObject::GlobalObject):
+ (jscmain):
+
+2008-10-20 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove an untaken branch in CodeGenerator::emitJumpIfFalse(). This
+ function is never called with a backwards target LabelID, and there is
+ even an assertion to this effect at the top of the function body.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitJumpIfFalse):
+
+2008-10-20 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Add opcode documentation for undocumented opcodes.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
+ Don't create intermediate StructureIDs for builtin objects
+
+ Second stage in reduce number of StructureIDs created when initializing the
+ JSGlobalObject.
+
+ - Use putDirectWithoutTransition for the remaining singleton objects to reduce
+ the number of StructureIDs create for about:blank from 132 to 73.
+
+ * kjs/ArrayConstructor.cpp:
+ (JSC::ArrayConstructor::ArrayConstructor):
+ * kjs/BooleanConstructor.cpp:
+ (JSC::BooleanConstructor::BooleanConstructor):
+ * kjs/BooleanPrototype.cpp:
+ (JSC::BooleanPrototype::BooleanPrototype):
+ * kjs/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ * kjs/ErrorConstructor.cpp:
+ (JSC::ErrorConstructor::ErrorConstructor):
+ * kjs/ErrorPrototype.cpp:
+ (JSC::ErrorPrototype::ErrorPrototype):
+ * kjs/FunctionConstructor.cpp:
+ (JSC::FunctionConstructor::FunctionConstructor):
+ * kjs/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::FunctionPrototype):
+ (JSC::FunctionPrototype::addFunctionProperties):
+ * kjs/FunctionPrototype.h:
+ (JSC::FunctionPrototype::createStructureID):
+ * kjs/InternalFunction.cpp:
+ * kjs/InternalFunction.h:
+ (JSC::InternalFunction::InternalFunction):
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ * kjs/JSObject.h:
+ * kjs/MathObject.cpp:
+ (JSC::MathObject::MathObject):
+ * kjs/NumberConstructor.cpp:
+ (JSC::NumberConstructor::NumberConstructor):
+ * kjs/NumberPrototype.cpp:
+ (JSC::NumberPrototype::NumberPrototype):
+ * kjs/ObjectConstructor.cpp:
+ (JSC::ObjectConstructor::ObjectConstructor):
+ * kjs/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::RegExpConstructor):
+ * kjs/RegExpPrototype.cpp:
+ (JSC::RegExpPrototype::RegExpPrototype):
+ * kjs/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+ * kjs/StringPrototype.cpp:
+ (JSC::StringPrototype::StringPrototype):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics):
+ * kjs/StructureID.h:
+ (JSC::StructureID::setPrototypeWithoutTransition):
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Fix autotools dist build target by listing recently added header
+ files only. Not reviewed.
+
+ * GNUmakefile.am:
+
+2008-10-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::tryCacheGetByID): Removed a redundant and sometimes
+ incorrect cast, which started ASSERTing after Darin's last checkin.
+
+2008-10-20 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Re-enable CTI, which I accidentally disabled while checking in fixes
+ to bytecode.
+
+ * wtf/Platform.h:
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ Typo fix in function name: mimimum -> minimum.
+
+ * kjs/DateMath.cpp:
+ (JSC::minimumYearForDST):
+ (JSC::equivalentYearForDST):
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Mark Rowe.
+
+ Use pthread instead of GThread where possible in the GTK+ port. This
+ fixes issues with global initialisation, particularly on GTK+/Win32
+ where a late g_thread_init() will cause hangs.
+
+ * GNUmakefile.am:
+ * wtf/Platform.h:
+ * wtf/Threading.h:
+ * wtf/ThreadingGtk.cpp:
+ * wtf/ThreadingPthreads.cpp:
+
+2008-10-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
+ Emit profiling instrumentation only if the Web Inspector's profiling
+ feature is enabled
+
+ 22.2% speedup on empty function call benchmark.
+ 2.9% speedup on v8 benchmark.
+ 0.7% speedup on SunSpider.
+
+ Lesser but similar speedups in bytecode.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases): Nixed JITed profiler hooks. Profiler
+ hooks now have their own opcodes. Added support for compiling profiler
+ hook opcodes.
+
+ (JSC::CodeBlock::dump): Dump support for the new profiling opcodes.
+
+ * VM/CodeGenerator.h:
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitConstruct): Conditionally emit profiling hooks
+ around call and construct, at the call site. (It's easier to get things
+ right this way, if you have profiled code calling non-profiled code.
+ Also, you get a slightly more accurate profile, since you charge the full
+ cost of the call / construct operation to the callee.)
+
+ Also, fixed a bug where construct would fetch the ".prototype" property
+ from the constructor before evaluating the arguments to the constructor,
+ incorrectly allowing an "invalid constructor" exception to short-circuit
+ argument evaluation. I encountered this bug when trying to make
+ constructor exceptions work with profiling.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::callEval): Removed obsolete profiler hooks.
+
+ (JSC::Machine::throwException): Added a check for an exception thrown
+ within a call instruction. We didn't need this before because the call
+ instruction would check for a valid call before involing the profiler.
+ (JSC::Machine::execute): Added a didExecute hook at the end of top-level
+ function invocation, since op_ret no longer does this for us.
+
+ (JSC::Machine::privateExecute): Removed obsolete profiler hooks. Added
+ profiler opcodes. Changed some ++vPC to vPC[x] notation, since the
+ latter is better for performance, and it makes reasoning about the
+ current opcode in exception handling much simpler.
+
+ (JSC::Machine::cti_op_call_NotJSFunction): Removed obsolete profiler
+ hooks.
+
+ (JSC::Machine::cti_op_create_arguments_no_params): Added missing
+ CTI_STACK_HACK that I noticed when adding CTI_STACK_HACK to the new
+ profiler opcode functions.
+
+ (JSC::Machine::cti_op_profile_will_call):
+ (JSC::Machine::cti_op_profile_did_call): The new profiler opcode
+ functions.
+
+ (JSC::Machine::cti_op_construct_NotJSConstruct): Removed obsolete profiler
+ hooks.
+
+ * VM/Machine.h:
+ (JSC::Machine::isCallOpcode): Helper for exception handling.
+
+ * VM/Opcode.h: Declare new opcodes.
+
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::supportsProfiling): Added virtual interface that
+ allows WebCore to specify whether the target global object has the Web
+ Inspector's profiling feature enabled.
+
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::willExecute):
+ (JSC::Profiler::didExecute):
+ (JSC::Profiler::createCallIdentifier):
+ * profiler/Profiler.h: Added support for invoking the profiler with
+ an arbitrary JSValue*, and not a known object. We didn't need this
+ before because the call instruction would check for a valid call before
+ involing the profiler.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - get CTI working on Windows again
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCTICall): Add an overload for functions that
+ return JSObject*.
+ * VM/CTI.h: Use JSValue* and JSObject* as return types for
+ cti_op functions. Apparently, MSVC doesn't handle returning
+ the JSValuePtr struct in a register. We'll have to look into
+ this more.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstructFast):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_vm_throw):
+ Change these functions to return pointer types, and never
+ JSValuePtr.
+ * VM/Machine.h: Ditto.
+
+2008-10-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed some recent break-age in bytecode mode.
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::printStructureIDs): Fixed up an ASSERT caused by
+ Gavin's last checkin. This is a temporary fix so I can keep on moving.
+ I'll send email about what I think is an underlying problem soon.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): Removed a redundant and sometimes
+ incorrect cast, which started ASSERTing after Darin's last checkin.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ - another similar Windows build fix
+
+ * VM/CTI.cpp: Changed return type to JSObject* instead of JSValuePtr.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ - try to fix Windows build
+
+ * VM/CTI.cpp: Use JSValue* instead of JSValuePtr for ctiTrampoline.
+ * VM/CTI.h: Ditto.
+
+2008-10-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - finish https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_profiler): Use asFunction.
+ (JSC::Machine::cti_vm_lazyLinkCall): Ditto.
+ (JSC::Machine::cti_op_construct_JSConstructFast): Use asObject.
+
+ * kjs/JSCell.h: Re-sort friend classes. Eliminate inheritance from
+ JSValue. Changed cast in asCell from static_cast to reinterpret_cast.
+ Removed JSValue::getNumber(double&) and one of JSValue::getObject
+ overloads.
+
+ * kjs/JSValue.h: Made the private constructor and destructor both
+ non-virtual and also remove the definitions. This class can never
+ be instantiated or derived.
+
+2008-10-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Change JSValuePtr from a typedef into a class. This allows us to support
+ conversion from JSCell* to JSValuePtr even if JSCell isn't derived from
+ JSValue.
+
+ * JavaScriptCore.exp: Updated symbols that involve JSValuePtr, since
+ it's now a distinct type.
+
+ * API/APICast.h:
+ (toRef): Extract the JSValuePtr payload explicitly since we can't just
+ cast any more.
+ * VM/CTI.cpp:
+ (JSC::CTI::asInteger): Ditto.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::addConstant): Get at the payload directly.
+ (JSC::CodeGenerator::emitLoad): Added an overload of JSCell* because
+ otherwise classes derived from JSValue end up calling the bool
+ overload instead of JSValuePtr.
+ * VM/CodeGenerator.h: Ditto. Also update traits to use JSValue*
+ and the payload functions.
+
+ * VM/Register.h: Added a JSCell* overload and use of payload functions.
+
+ * kjs/JSCell.h:
+ (JSC::asCell): Use payload function.
+ (JSC::JSValue::asCell): Use JSValue* instead of JSValuePtr.
+ (JSC::JSValuePtr::JSValuePtr): Added. Constructor that takes JSCell*
+ and creates a JSValuePtr.
+
+ * kjs/JSImmediate.h: Added JSValuePtr class. Also updated makeValue
+ and makeInt to work with JSValue* and the payload function.
+
+ * kjs/JSValue.h: Added == and != operators for JSValuePtr. Put them
+ here because eventually all the JSValue functions should go here
+ except what's needed by JSImmediate. Also fix asValue to use
+ JSValue* instead of JSValuePtr.
+
+ * kjs/PropertySlot.h: Change constructor to take JSValuePtr.
+
+ * kjs/protect.h: Update gcProtect functions to work with JSCell*
+ as well as JSValuePtr. Also updated the ProtectedPtr<JSValuePtr>
+ specialization to work more directly. Also changed all the call
+ sites to use gcProtectNullTolerant.
+
+2008-10-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Remove most uses of JSValue, which will be removed in a future patch.
+
+ * VM/Machine.cpp:
+ (JSC::fastToUInt32): Call toUInt32SlowCase function; no longer a member
+ of JSValue.
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::toInt32): Ditto.
+ (JSC::JSNumberCell::toUInt32): Ditto.
+
+ * kjs/JSValue.cpp:
+ (JSC::toInt32SlowCase): Made a non-member function.
+ (JSC::JSValue::toInt32SlowCase): Changed to call non-member function.
+ (JSC::toUInt32SlowCase): More of the same.
+ (JSC::JSValue::toUInt32SlowCase): Ditto.
+
+ * kjs/JSValue.h: Moved static member function so they are no longer
+ member functions at all.
+
+ * VM/CTI.h: Removed forward declaration of JSValue.
+ * VM/ExceptionHelpers.h: Ditto.
+ * kjs/CallData.h: Ditto.
+ * kjs/ConstructData.h: Ditto.
+ * kjs/JSGlobalObjectFunctions.h: Ditto.
+ * kjs/PropertyMap.h: Ditto.
+ * kjs/StructureID.h: Ditto.
+ * kjs/collector.h: Ditto.
+ * kjs/completion.h: Ditto.
+
+ * kjs/grammar.y:
+ (JSC::makeBitwiseNotNode): Call new non-member toInt32 function.
+ (JSC::makeLeftShiftNode): More of the same.
+ (JSC::makeRightShiftNode): Ditto.
+
+ * kjs/protect.h: Added a specialization for ProtectedPtr<JSValuePtr>
+ so this can be used with JSValuePtr.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Tweak a little more to get closer to where we can make JSValuePtr a class.
+
+ * API/APICast.h:
+ (toJS): Change back to JSValue* here, since we're converting the
+ pointer type.
+ * VM/CTI.cpp:
+ (JSC::CTI::unlinkCall): Call asPointer.
+ * VM/CTI.h: Cast to JSValue* here, since it's a pointer cast.
+ * kjs/DebuggerCallFrame.h:
+ (JSC::DebuggerCallFrame::DebuggerCallFrame): Call noValue.
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Call noValue.
+ * kjs/JSImmediate.cpp:
+ (JSC::JSImmediate::toObject): Remove unneeded const_cast.
+ * kjs/JSWrapperObject.h:
+ (JSC::JSWrapperObject::JSWrapperObject): Call noValue.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - fix non-all-in-one build
+
+ * kjs/completion.h:
+ (JSC::Completion::Completion): Add include of JSValue.h.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix assertions I introduced with my casting changes
+
+ These were showing up as failures in the JavaScriptCore tests.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_instanceof): Remove the bogus asCell casting that
+ was at the top of the function, and instead cast at the point of use.
+ (JSC::Machine::cti_op_construct_NotJSConstruct): Moved the cast to
+ object after checking the construct type.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - fix non-all-in-one build
+
+ * kjs/JSGlobalObjectFunctions.h: Add include of JSImmedate.h (for now).
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - fix build
+
+ * kjs/interpreter.h: Include JSValue.h instead of JSImmediate.h.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ * kjs/interpreter.h: Fix include of JSImmediate.h.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - fix non-all-in-one build
+
+ * kjs/interpreter.h: Add include of JSImmediate.h.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - fix non-all-in-one build
+
+ * kjs/ConstructData.h: Add include of JSImmedate.h (for now).
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - try to fix Windows build
+
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine): Use JSCell* type since MSVC seems to only allow
+ calling ~JSCell directly if it's a JSCell*.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - next step on https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
+ changing JSValuePtr to be a class, and then eventually renaming it
+ to JSValue once that's done.
+
+ * JavaScriptCore.exp: Update entry points, since some now take JSValue*
+ instead of const JSValue*.
+
+ * API/APICast.h:
+ * API/JSCallbackConstructor.h:
+ * API/JSCallbackFunction.cpp:
+ * API/JSCallbackFunction.h:
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ * API/JSValueRef.cpp:
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ * VM/CodeGenerator.h:
+ * VM/ExceptionHelpers.cpp:
+ * VM/ExceptionHelpers.h:
+ * VM/JSPropertyNameIterator.cpp:
+ * VM/JSPropertyNameIterator.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * VM/Register.h:
+ * kjs/ArgList.cpp:
+ * kjs/ArgList.h:
+ * kjs/Arguments.cpp:
+ * kjs/Arguments.h:
+ * kjs/ArrayConstructor.cpp:
+ * kjs/ArrayPrototype.cpp:
+ * kjs/BooleanConstructor.cpp:
+ * kjs/BooleanConstructor.h:
+ * kjs/BooleanObject.h:
+ * kjs/BooleanPrototype.cpp:
+ * kjs/CallData.cpp:
+ * kjs/CallData.h:
+ * kjs/ConstructData.cpp:
+ * kjs/ConstructData.h:
+ * kjs/DateConstructor.cpp:
+ * kjs/DateInstance.h:
+ * kjs/DatePrototype.cpp:
+ * kjs/DebuggerCallFrame.cpp:
+ * kjs/DebuggerCallFrame.h:
+ * kjs/ErrorConstructor.cpp:
+ * kjs/ErrorPrototype.cpp:
+ * kjs/ExecState.cpp:
+ * kjs/ExecState.h:
+ * kjs/FunctionConstructor.cpp:
+ * kjs/FunctionPrototype.cpp:
+ * kjs/GetterSetter.cpp:
+ * kjs/GetterSetter.h:
+ * kjs/InternalFunction.h:
+ * kjs/JSActivation.cpp:
+ * kjs/JSActivation.h:
+ * kjs/JSArray.cpp:
+ * kjs/JSArray.h:
+ * kjs/JSCell.cpp:
+ * kjs/JSCell.h:
+ * kjs/JSFunction.cpp:
+ * kjs/JSFunction.h:
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.cpp:
+ * kjs/JSGlobalObject.h:
+ * kjs/JSGlobalObjectFunctions.cpp:
+ * kjs/JSGlobalObjectFunctions.h:
+ * kjs/JSImmediate.cpp:
+ * kjs/JSImmediate.h:
+ * kjs/JSNotAnObject.cpp:
+ * kjs/JSNotAnObject.h:
+ * kjs/JSNumberCell.cpp:
+ * kjs/JSNumberCell.h:
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ * kjs/JSStaticScopeObject.cpp:
+ * kjs/JSStaticScopeObject.h:
+ * kjs/JSString.cpp:
+ * kjs/JSString.h:
+ * kjs/JSValue.h:
+ * kjs/JSVariableObject.h:
+ * kjs/JSWrapperObject.h:
+ * kjs/MathObject.cpp:
+ * kjs/NativeErrorConstructor.cpp:
+ * kjs/NumberConstructor.cpp:
+ * kjs/NumberConstructor.h:
+ * kjs/NumberObject.cpp:
+ * kjs/NumberObject.h:
+ * kjs/NumberPrototype.cpp:
+ * kjs/ObjectConstructor.cpp:
+ * kjs/ObjectPrototype.cpp:
+ * kjs/ObjectPrototype.h:
+ * kjs/PropertyMap.h:
+ * kjs/PropertySlot.cpp:
+ * kjs/PropertySlot.h:
+ * kjs/RegExpConstructor.cpp:
+ * kjs/RegExpConstructor.h:
+ * kjs/RegExpMatchesArray.h:
+ * kjs/RegExpObject.cpp:
+ * kjs/RegExpObject.h:
+ * kjs/RegExpPrototype.cpp:
+ * kjs/Shell.cpp:
+ * kjs/StringConstructor.cpp:
+ * kjs/StringObject.cpp:
+ * kjs/StringObject.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ * kjs/StringPrototype.cpp:
+ * kjs/StructureID.cpp:
+ * kjs/StructureID.h:
+ * kjs/collector.cpp:
+ * kjs/collector.h:
+ * kjs/completion.h:
+ * kjs/grammar.y:
+ * kjs/interpreter.cpp:
+ * kjs/interpreter.h:
+ * kjs/lookup.cpp:
+ * kjs/lookup.h:
+ * kjs/nodes.h:
+ * kjs/operations.cpp:
+ * kjs/operations.h:
+ * kjs/protect.h:
+ * profiler/ProfileGenerator.cpp:
+ Replace JSValue* with JSValuePtr.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_eval): Removed stray parentheses from my
+ last check-in.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - first step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Remove casts from JSValue* to derived classes, replacing them with
+ calls to inline casting functions. These functions are also a bit
+ better than aidrect cast because they also do a runtime assertion.
+
+ Removed use of 0 as for JSValue*, changing call sites to use a
+ noValue() function instead.
+
+ Move things needed by classes derived from JSValue out of the class,
+ since the classes won't be deriving from JSValue any more soon.
+
+ I did most of these changes by changing JSValue to not be JSValue* any
+ more, then fixing a lot of the compilation problems, then rolling out
+ the JSValue change.
+
+ 1.011x as fast on SunSpider (presumably due to some of the Machine.cpp changes)
+
+ * API/APICast.h: Removed unneeded forward declarations.
+
+ * API/JSCallbackObject.h: Added an asCallbackObject function for casting.
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::JSCallbackObject::asCallbackObject): Added.
+ (JSC::JSCallbackObject::getOwnPropertySlot): Use asObject.
+ (JSC::JSCallbackObject::call): Use noValue.
+ (JSC::JSCallbackObject::staticValueGetter): Use asCallbackObject.
+ (JSC::JSCallbackObject::staticFunctionGetter): Ditto.
+ (JSC::JSCallbackObject::callbackGetter): Ditto.
+
+ * JavaScriptCore.exp: Updated.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Added RegExpMatchesArray.h.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::asInteger): Added. For use casting a JSValue to an integer.
+ (JSC::CTI::emitGetArg): Use asInteger.
+ (JSC::CTI::emitGetPutArg): Ditto.
+ (JSC::CTI::getConstantImmediateNumericArg): Ditto. Also use noValue.
+ (JSC::CTI::emitInitRegister): Use asInteger.
+ (JSC::CTI::getDeTaggedConstantImmediate): Ditto.
+ (JSC::CTI::compileOpCallInitializeCallFrame): Ditto.
+ (JSC::CTI::compileOpCall): Ditto.
+ (JSC::CTI::compileOpStrictEq): Ditto.
+ (JSC::CTI::privateCompileMainPass): Ditto.
+ (JSC::CTI::privateCompileGetByIdProto): Ditto.
+ (JSC::CTI::privateCompileGetByIdChain): Ditto.
+ (JSC::CTI::privateCompilePutByIdTransition): Ditto.
+ * VM/CTI.h: Rewrite the ARG-related macros to use C++ casts instead of
+ C casts and get rid of some extra parentheses. Addd declaration of
+ asInteger.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp): Use asString.
+ (JSC::CodeGenerator::emitLoad): Use noValue.
+ (JSC::CodeGenerator::findScopedProperty): Change globalObject argument
+ to JSObject* instead of JSValue*.
+ (JSC::CodeGenerator::emitResolve): Remove unneeded cast.
+ (JSC::CodeGenerator::emitGetScopedVar): Use asCell.
+ (JSC::CodeGenerator::emitPutScopedVar): Ditto.
+ * VM/CodeGenerator.h: Changed out argument of findScopedProperty.
+ Also change the JSValueMap to use PtrHash explicitly instead of
+ getting it from DefaultHash.
+
+ * VM/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::toPrimitive): Use noValue.
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::next): Ditto.
+
+ * VM/Machine.cpp:
+ (JSC::fastIsNumber): Moved isImmediate check here instead of
+ checking for 0 inside Heap::isNumber. Use asCell and asNumberCell.
+ (JSC::fastToInt32): Ditto.
+ (JSC::fastToUInt32): Ditto.
+ (JSC::jsLess): Use asString.
+ (JSC::jsLessEq): Ditto.
+ (JSC::jsAdd): Ditto.
+ (JSC::jsTypeStringForValue): Use asObject.
+ (JSC::jsIsObjectType): Ditto.
+ (JSC::jsIsFunctionType): Ditto.
+ (JSC::inlineResolveBase): Use noValue.
+ (JSC::Machine::callEval): Use asString. Initialize result to
+ undefined, not 0.
+ (JSC::Machine::Machine): Remove unneeded casts to JSCell*.
+ (JSC::Machine::throwException): Use asObject.
+ (JSC::Machine::debug): Remove explicit calls to the DebuggerCallFrame
+ constructor.
+ (JSC::Machine::checkTimeout): Use noValue.
+ (JSC::cachePrototypeChain): Use asObject.
+ (JSC::Machine::tryCachePutByID): Use asCell.
+ (JSC::Machine::tryCacheGetByID): Use aCell and asObject.
+ (JSC::Machine::privateExecute): Use noValue, asCell, asObject, asString,
+ asArray, asActivation, asFunction. Changed code that creates call frames
+ for host functions to pass 0 for the function pointer -- the call frame
+ needs a JSFunction* and a host function object is not one. This was
+ caught by the assertions in the casting functions. Also remove some
+ unneeded casts in cases where two values are compared.
+ (JSC::Machine::retrieveLastCaller): Use noValue.
+ (JSC::Machine::tryCTICachePutByID): Use asCell.
+ (JSC::Machine::tryCTICacheGetByID): Use aCell and asObject.
+ (JSC::setUpThrowTrampolineReturnAddress): Added this function to restore
+ the PIC-branch-avoidance that was recently lost.
+ (JSC::Machine::cti_op_add): Use asString.
+ (JSC::Machine::cti_op_instanceof): Use asCell and asObject.
+ (JSC::Machine::cti_op_call_JSFunction): Use asFunction.
+ (JSC::Machine::cti_op_call_NotJSFunction): Changed code to pass 0 for
+ the function pointer, since we don't have a JSFunction. Use asObject.
+ (JSC::Machine::cti_op_tear_off_activation): Use asActivation.
+ (JSC::Machine::cti_op_construct_JSConstruct): Use asFunction and asObject.
+ (JSC::Machine::cti_op_construct_NotJSConstruct): use asObject.
+ (JSC::Machine::cti_op_get_by_val): Use asArray and asString.
+ (JSC::Machine::cti_op_resolve_func): Use asPointer; this helps prepare
+ us for a situation where JSValue is not a pointer.
+ (JSC::Machine::cti_op_put_by_val): Use asArray.
+ (JSC::Machine::cti_op_put_by_val_array): Ditto.
+ (JSC::Machine::cti_op_resolve_global): Use asGlobalObject.
+ (JSC::Machine::cti_op_post_inc): Change VM_CHECK_EXCEPTION_2 to
+ VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after
+ that point. Also use asPointer.
+ (JSC::Machine::cti_op_resolve_with_base): Use asPointer.
+ (JSC::Machine::cti_op_post_dec): Change VM_CHECK_EXCEPTION_2 to
+ VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after
+ that point. Also use asPointer.
+ (JSC::Machine::cti_op_call_eval): Use asObject, noValue, and change
+ VM_CHECK_EXCEPTION_ARG to VM_THROW_EXCEPTION_AT_END.
+ (JSC::Machine::cti_op_throw): Change return value to a JSValue*.
+ (JSC::Machine::cti_op_in): Use asObject.
+ (JSC::Machine::cti_op_switch_char): Use asString.
+ (JSC::Machine::cti_op_switch_string): Ditto.
+ (JSC::Machine::cti_op_put_getter): Use asObject.
+ (JSC::Machine::cti_op_put_setter): Ditto.
+ (JSC::Machine::cti_vm_throw): Change return value to a JSValue*.
+ Use noValue.
+ * VM/Machine.h: Change return values of both cti_op_throw and
+ cti_vm_throw to JSValue*.
+
+ * VM/Register.h: Remove nullJSValue, which is the same thing
+ as noValue(). Also removed unneeded definition of JSValue.
+
+ * kjs/ArgList.h: Removed unneeded definition of JSValue.
+
+ * kjs/Arguments.h:
+ (JSC::asArguments): Added.
+
+ * kjs/ArrayPrototype.cpp:
+ (JSC::getProperty): Use noValue.
+ (JSC::arrayProtoFuncToString): Use asArray.
+ (JSC::arrayProtoFuncToLocaleString): Ditto.
+ (JSC::arrayProtoFuncConcat): Ditto.
+ (JSC::arrayProtoFuncPop): Ditto. Also removed unneeded initialization
+ of the result, which is set in both sides of the branch.
+ (JSC::arrayProtoFuncPush): Ditto.
+ (JSC::arrayProtoFuncShift): Removed unneeded initialization
+ of the result, which is set in both sides of the branch.
+ (JSC::arrayProtoFuncSort): Use asArray.
+
+ * kjs/BooleanObject.h:
+ (JSC::asBooleanObject): Added.
+
+ * kjs/BooleanPrototype.cpp:
+ (JSC::booleanProtoFuncToString): Use asBooleanObject.
+ (JSC::booleanProtoFuncValueOf): Ditto.
+
+ * kjs/CallData.cpp:
+ (JSC::call): Use asObject and asFunction.
+ * kjs/ConstructData.cpp:
+ (JSC::construct): Ditto.
+
+ * kjs/DateConstructor.cpp:
+ (JSC::constructDate): Use asDateInstance.
+
+ * kjs/DateInstance.h:
+ (JSC::asDateInstance): Added.
+
+ * kjs/DatePrototype.cpp:
+ (JSC::dateProtoFuncToString): Use asDateInstance.
+ (JSC::dateProtoFuncToUTCString): Ditto.
+ (JSC::dateProtoFuncToDateString): Ditto.
+ (JSC::dateProtoFuncToTimeString): Ditto.
+ (JSC::dateProtoFuncToLocaleString): Ditto.
+ (JSC::dateProtoFuncToLocaleDateString): Ditto.
+ (JSC::dateProtoFuncToLocaleTimeString): Ditto.
+ (JSC::dateProtoFuncValueOf): Ditto.
+ (JSC::dateProtoFuncGetTime): Ditto.
+ (JSC::dateProtoFuncGetFullYear): Ditto.
+ (JSC::dateProtoFuncGetUTCFullYear): Ditto.
+ (JSC::dateProtoFuncToGMTString): Ditto.
+ (JSC::dateProtoFuncGetMonth): Ditto.
+ (JSC::dateProtoFuncGetUTCMonth): Ditto.
+ (JSC::dateProtoFuncGetDate): Ditto.
+ (JSC::dateProtoFuncGetUTCDate): Ditto.
+ (JSC::dateProtoFuncGetDay): Ditto.
+ (JSC::dateProtoFuncGetUTCDay): Ditto.
+ (JSC::dateProtoFuncGetHours): Ditto.
+ (JSC::dateProtoFuncGetUTCHours): Ditto.
+ (JSC::dateProtoFuncGetMinutes): Ditto.
+ (JSC::dateProtoFuncGetUTCMinutes): Ditto.
+ (JSC::dateProtoFuncGetSeconds): Ditto.
+ (JSC::dateProtoFuncGetUTCSeconds): Ditto.
+ (JSC::dateProtoFuncGetMilliSeconds): Ditto.
+ (JSC::dateProtoFuncGetUTCMilliseconds): Ditto.
+ (JSC::dateProtoFuncGetTimezoneOffset): Ditto.
+ (JSC::dateProtoFuncSetTime): Ditto.
+ (JSC::setNewValueFromTimeArgs): Ditto.
+ (JSC::setNewValueFromDateArgs): Ditto.
+ (JSC::dateProtoFuncSetYear): Ditto.
+ (JSC::dateProtoFuncGetYear): Ditto.
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::thisObject): Use asObject.
+ (JSC::DebuggerCallFrame::evaluate): Use noValue.
+ * kjs/DebuggerCallFrame.h: Added a constructor that
+ takes only a callFrame.
+
+ * kjs/ExecState.h:
+ (JSC::ExecState::clearException): Use noValue.
+
+ * kjs/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncToString): Use asFunction.
+ (JSC::functionProtoFuncApply): Use asArguments and asArray.
+
+ * kjs/GetterSetter.cpp:
+ (JSC::GetterSetter::getPrimitiveNumber): Use noValue.
+
+ * kjs/GetterSetter.h:
+ (JSC::asGetterSetter): Added.
+
+ * kjs/InternalFunction.cpp:
+ (JSC::InternalFunction::name): Use asString.
+
+ * kjs/InternalFunction.h:
+ (JSC::asInternalFunction): Added.
+
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::argumentsGetter): Use asActivation.
+
+ * kjs/JSActivation.h:
+ (JSC::asActivation): Added.
+
+ * kjs/JSArray.cpp:
+ (JSC::JSArray::putSlowCase): Use noValue.
+ (JSC::JSArray::deleteProperty): Ditto.
+ (JSC::JSArray::increaseVectorLength): Ditto.
+ (JSC::JSArray::setLength): Ditto.
+ (JSC::JSArray::pop): Ditto.
+ (JSC::JSArray::sort): Ditto.
+ (JSC::JSArray::compactForSorting): Ditto.
+ * kjs/JSArray.h:
+ (JSC::asArray): Added.
+
+ * kjs/JSCell.cpp:
+ (JSC::JSCell::getJSNumber): Use noValue.
+
+ * kjs/JSCell.h:
+ (JSC::asCell): Added.
+ (JSC::JSValue::asCell): Changed to not preserve const.
+ Given the wide use of JSValue* and JSCell*, it's not
+ really useful to use const.
+ (JSC::JSValue::isNumber): Use asValue.
+ (JSC::JSValue::isString): Ditto.
+ (JSC::JSValue::isGetterSetter): Ditto.
+ (JSC::JSValue::isObject): Ditto.
+ (JSC::JSValue::getNumber): Ditto.
+ (JSC::JSValue::getString): Ditto.
+ (JSC::JSValue::getObject): Ditto.
+ (JSC::JSValue::getCallData): Ditto.
+ (JSC::JSValue::getConstructData): Ditto.
+ (JSC::JSValue::getUInt32): Ditto.
+ (JSC::JSValue::getTruncatedInt32): Ditto.
+ (JSC::JSValue::getTruncatedUInt32): Ditto.
+ (JSC::JSValue::mark): Ditto.
+ (JSC::JSValue::marked): Ditto.
+ (JSC::JSValue::toPrimitive): Ditto.
+ (JSC::JSValue::getPrimitiveNumber): Ditto.
+ (JSC::JSValue::toBoolean): Ditto.
+ (JSC::JSValue::toNumber): Ditto.
+ (JSC::JSValue::toString): Ditto.
+ (JSC::JSValue::toObject): Ditto.
+ (JSC::JSValue::toThisObject): Ditto.
+ (JSC::JSValue::needsThisConversion): Ditto.
+ (JSC::JSValue::toThisString): Ditto.
+ (JSC::JSValue::getJSNumber): Ditto.
+
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::argumentsGetter): Use asFunction.
+ (JSC::JSFunction::callerGetter): Ditto.
+ (JSC::JSFunction::lengthGetter): Ditto.
+ (JSC::JSFunction::construct): Use asObject.
+
+ * kjs/JSFunction.h:
+ (JSC::asFunction): Added.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::lastInPrototypeChain): Use asObject.
+
+ * kjs/JSGlobalObject.h:
+ (JSC::asGlobalObject): Added.
+ (JSC::ScopeChainNode::globalObject): Use asGlobalObject.
+
+ * kjs/JSImmediate.h: Added noValue, asPointer, and makeValue
+ functions. Use rawValue, makeValue, and noValue consistently
+ instead of doing reinterpret_cast in various functions.
+
+ * kjs/JSNumberCell.h:
+ (JSC::asNumberCell): Added.
+ (JSC::JSValue::uncheckedGetNumber): Use asValue and asNumberCell.
+ (JSC::JSValue::toJSNumber): Use asValue.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::put): Use asObject and asGetterSetter.
+ (JSC::callDefaultValueFunction): Use noValue.
+ (JSC::JSObject::defineGetter): Use asGetterSetter.
+ (JSC::JSObject::defineSetter): Ditto.
+ (JSC::JSObject::lookupGetter): Ditto. Also use asObject.
+ (JSC::JSObject::lookupSetter): Ditto.
+ (JSC::JSObject::hasInstance): Use asObject.
+ (JSC::JSObject::fillGetterPropertySlot): Use asGetterSetter.
+
+ * kjs/JSObject.h:
+ (JSC::JSObject::getDirect): Use noValue.
+ (JSC::asObject): Added.
+ (JSC::JSValue::isObject): Use asValue.
+ (JSC::JSObject::get): Removed unneeded const_cast.
+ (JSC::JSObject::getPropertySlot): Use asObject.
+ (JSC::JSValue::get): Removed unneeded const_cast.
+ Use asValue, asCell, and asObject.
+ (JSC::JSValue::put): Ditto.
+ (JSC::JSObject::allocatePropertyStorageInline): Fixed spelling
+ of "oldPropertStorage".
+
+ * kjs/JSString.cpp:
+ (JSC::JSString::getOwnPropertySlot): Use asObject.
+
+ * kjs/JSString.h:
+ (JSC::asString): Added.
+ (JSC::JSValue::toThisJSString): Use asValue.
+
+ * kjs/JSValue.h: Make PreferredPrimitiveType a top level enum
+ instead of a member of JSValue. Added an asValue function that
+ returns this. Removed overload of asCell for const. Use asValue
+ instead of getting right at this.
+
+ * kjs/ObjectPrototype.cpp:
+ (JSC::objectProtoFuncIsPrototypeOf): Use asObject.
+ (JSC::objectProtoFuncDefineGetter): Ditto.
+ (JSC::objectProtoFuncDefineSetter): Ditto.
+
+ * kjs/PropertySlot.h:
+ (JSC::PropertySlot::PropertySlot): Take a const JSValue* so the
+ callers don't have to worry about const.
+ (JSC::PropertySlot::clearBase): Use noValue.
+ (JSC::PropertySlot::clearValue): Ditto.
+
+ * kjs/RegExpConstructor.cpp:
+ (JSC::regExpConstructorDollar1): Use asRegExpConstructor.
+ (JSC::regExpConstructorDollar2): Ditto.
+ (JSC::regExpConstructorDollar3): Ditto.
+ (JSC::regExpConstructorDollar4): Ditto.
+ (JSC::regExpConstructorDollar5): Ditto.
+ (JSC::regExpConstructorDollar6): Ditto.
+ (JSC::regExpConstructorDollar7): Ditto.
+ (JSC::regExpConstructorDollar8): Ditto.
+ (JSC::regExpConstructorDollar9): Ditto.
+ (JSC::regExpConstructorInput): Ditto.
+ (JSC::regExpConstructorMultiline): Ditto.
+ (JSC::regExpConstructorLastMatch): Ditto.
+ (JSC::regExpConstructorLastParen): Ditto.
+ (JSC::regExpConstructorLeftContext): Ditto.
+ (JSC::regExpConstructorRightContext): Ditto.
+ (JSC::setRegExpConstructorInput): Ditto.
+ (JSC::setRegExpConstructorMultiline): Ditto.
+ (JSC::constructRegExp): Use asObject.
+
+ * kjs/RegExpConstructor.h:
+ (JSC::asRegExpConstructor): Added.
+
+ * kjs/RegExpObject.cpp:
+ (JSC::regExpObjectGlobal): Use asRegExpObject.
+ (JSC::regExpObjectIgnoreCase): Ditto.
+ (JSC::regExpObjectMultiline): Ditto.
+ (JSC::regExpObjectSource): Ditto.
+ (JSC::regExpObjectLastIndex): Ditto.
+ (JSC::setRegExpObjectLastIndex): Ditto.
+ (JSC::callRegExpObject): Ditto.
+
+ * kjs/RegExpObject.h:
+ (JSC::asRegExpObject): Added.
+
+ * kjs/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncTest): Use asRegExpObject.
+ (JSC::regExpProtoFuncExec): Ditto.
+ (JSC::regExpProtoFuncCompile): Ditto.
+ (JSC::regExpProtoFuncToString): Ditto.
+
+ * kjs/StringObject.h:
+ (JSC::StringObject::internalValue): Use asString.
+ (JSC::asStringObject): Added.
+
+ * kjs/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace): Use asRegExpObject.
+ (JSC::stringProtoFuncToString): Ue asStringObject.
+ (JSC::stringProtoFuncMatch): Use asRegExpObject.
+ (JSC::stringProtoFuncSearch): Ditto.
+ (JSC::stringProtoFuncSplit): Ditto.
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames): Use asObject.
+ (JSC::StructureID::createCachedPrototypeChain): Ditto.
+ (JSC::StructureIDChain::StructureIDChain): Use asCell and asObject.
+
+ * kjs/collector.h:
+ (JSC::Heap::isNumber): Removed null handling. This can only be called
+ on valid cells.
+ (JSC::Heap::cellBlock): Removed overload for const and non-const.
+ Whether the JSCell* is const or not really should have no effect on
+ whether you can modify the collector block it's in.
+
+ * kjs/interpreter.cpp:
+ (JSC::Interpreter::evaluate): Use noValue and noObject.
+
+ * kjs/nodes.cpp:
+ (JSC::FunctionCallResolveNode::emitCode): Use JSObject for the global
+ object rather than JSValue.
+ (JSC::PostfixResolveNode::emitCode): Ditto.
+ (JSC::PrefixResolveNode::emitCode): Ditto.
+ (JSC::ReadModifyResolveNode::emitCode): Ditto.
+ (JSC::AssignResolveNode::emitCode): Ditto.
+
+ * kjs/operations.h:
+ (JSC::equalSlowCaseInline): Use asString, asCell, asNumberCell,
+ (JSC::strictEqualSlowCaseInline): Ditto.
+
+2008-10-18 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21702: Special op_create_activation for the case where there are no named parameters
+ <https://bugs.webkit.org/show_bug.cgi?id=21702>
+
+ This is a 2.5% speedup on the V8 Raytrace benchmark and a 1.1% speedup
+ on the V8 Earley-Boyer benchmark.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_create_arguments_no_params):
+ * VM/Machine.h:
+ * kjs/Arguments.h:
+ (JSC::Arguments::):
+ (JSC::Arguments::Arguments):
+
+2008-10-17 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - in debug builds, alter the stack to avoid blowing out MallocStackLogging
+
+ (In essence, while executing a CTI function we alter the return
+ address to jscGeneratedNativeCode so that a single consistent
+ function is on the stack instead of many random functions without
+ symbols.)
+
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::doSetReturnAddress):
+ (JSC::):
+ (JSC::StackHack::StackHack):
+ (JSC::StackHack::~StackHack):
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_end):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_timeout_check):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_loop_if_less):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_second):
+ (JSC::Machine::cti_op_put_by_id_generic):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_call_profiler):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_lazyLinkCall):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstructFast):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_put_by_val):
+ (JSC::Machine::cti_op_put_by_val_array):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_jless):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_post_dec):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_get_pnames):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_push_scope):
+ (JSC::Machine::cti_op_pop_scope):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_jmp_scopes):
+ (JSC::Machine::cti_op_put_by_index):
+ (JSC::Machine::cti_op_switch_imm):
+ (JSC::Machine::cti_op_switch_char):
+ (JSC::Machine::cti_op_switch_string):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_put_getter):
+ (JSC::Machine::cti_op_put_setter):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_op_debug):
+ (JSC::Machine::cti_vm_throw):
+
+2008-10-17 Gavin Barraclough <barraclough@apple.com>
+
+ Optimize op_call by allowing call sites to be directly linked to callees.
+
+ For the hot path of op_call, CTI now generates a check (initially for an impossible
+ value), and the first time the call is executed we attempt to link the call directly
+ to the callee. We can currently only do so if the arity of the caller and callee
+ match. The (optimized) setup for the call on the hot path is linked directly to
+ the ctiCode for the callee, without indirection.
+
+ Two forms of the slow case of the call are generated, the first will be executed the
+ first time the call is reached. As well as this path attempting to link the call to
+ a callee, it also relinks the slow case to a second slow case, which will not continue
+ to attempt relinking the call. (This policy could be changed in future, but for not
+ this is intended to prevent thrashing).
+
+ If a callee that the caller has been linked to is garbage collected, then the link
+ in the caller's JIt code will be reset back to a value that cannot match - to prevent
+ any false positive matches.
+
+ ~20% progression on deltablue & richards, >12% overall reduction in v8-tests
+ runtime, one or two percent progression on sunspider.
+
+ Reviewed by Oliver Hunt.
+
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::emitNakedCall):
+ (JSC::unreachable):
+ (JSC::CTI::compileOpCallInitializeCallFrame):
+ (JSC::CTI::compileOpCallSetupArgs):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::unlinkCall):
+ (JSC::CTI::linkCall):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::~CodeBlock):
+ (JSC::CodeBlock::unlinkCallers):
+ (JSC::CodeBlock::derefStructureIDs):
+ * VM/CodeBlock.h:
+ (JSC::StructureStubInfo::StructureStubInfo):
+ (JSC::CallLinkInfo::CallLinkInfo):
+ (JSC::CodeBlock::addCaller):
+ (JSC::CodeBlock::removeCaller):
+ (JSC::CodeBlock::getStubInfo):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitConstruct):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_profiler):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_lazyLinkCall):
+ (JSC::Machine::cti_op_construct_JSConstructFast):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ * VM/Machine.h:
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::~JSFunction):
+ * kjs/JSFunction.h:
+ * kjs/nodes.h:
+ (JSC::FunctionBodyNode::):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::getDifferenceBetweenLabels):
+
+2008-10-17 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - remove ASSERT that makes the leaks buildbot cry
+
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
+
+2008-10-17 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich
+
+ - don't bother to do arguments tearoff when it will have no effect
+
+ ~1% on v8 raytrace
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitReturn):
+
+2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Sam Weinig. Landed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21603
+ [GTK] Minor fixes to GOwnPtr
+
+ * wtf/GOwnPtr.cpp:
+ (WTF::GError):
+ (WTF::GList):
+ (WTF::GCond):
+ (WTF::GMutex):
+ (WTF::GPatternSpec):
+ (WTF::GDir):
+ * wtf/GOwnPtr.h:
+ (WTF::freeOwnedGPtr):
+ (WTF::GOwnPtr::~GOwnPtr):
+ (WTF::GOwnPtr::outPtr):
+ (WTF::GOwnPtr::set):
+ (WTF::GOwnPtr::clear):
+ * wtf/Threading.h:
+
+2008-10-17 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up transitions that resize the property storage a fair bit
+
+ ~3% speedup on v8 RayTrace benchmark, ~1% on DeltaBlue
+
+ * VM/CTI.cpp:
+ (JSC::resizePropertyStorage): renamed from transitionObject, and reduced to just resize
+ the object's property storage with one inline call.
+ (JSC::CTI::privateCompilePutByIdTransition): Use a separate function for property storage
+ resize, but still do all the rest of the work in assembly in that case, and pass the known
+ compile-time constants of old and new size rather than structureIDs, saving a bunch of
+ redundant memory access.
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::allocatePropertyStorage): Just call the inline version.
+ * kjs/JSObject.h:
+ (JSC::JSObject::allocatePropertyStorageInline): Inline version of allocatePropertyStorage
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::pushl_i32): Add code to assmeble push of a constant; code originally by Cameron Zwarich.
+
+2008-10-17 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove some C style casts.
+
+ * masm/X86Assembler.h:
+ (JSC::JITCodeBuffer::putIntUnchecked):
+ (JSC::X86Assembler::link):
+ (JSC::X86Assembler::linkAbsoluteAddress):
+ (JSC::X86Assembler::getRelocatedAddress):
+
+2008-10-17 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Remove some C style casts.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ * VM/Machine.cpp:
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::tryCTICacheGetByID):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_fail):
+
+2008-10-17 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - Avoid restoring the caller's 'r' value in op_ret
+ https://bugs.webkit.org/show_bug.cgi?id=21319
+
+ This patch stops writing the call frame at call and return points;
+ instead it does so immediately before any CTI call.
+
+ 0.5% speedup or so on the v8 benchmark
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCTICall):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h:
+
+2008-10-17 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Make WREC require CTI because it won't actually compile otherwise.
+
+ * wtf/Platform.h:
+
+2008-10-16 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
+ - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
+
+ This time there is no performance regression; we can avoid having
+ to use the fastcall calling convention for CTI functions by using
+ varargs to prevent the compiler from moving things around on the
+ stack.
+
+ * Configurations/DebugRelease.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ * VM/Machine.h:
+ * wtf/Platform.h:
+
+2008-10-16 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix for REGRESSION: r37631 causing crashes on buildbot
+ https://bugs.webkit.org/show_bug.cgi?id=21682
+
+ * kjs/collector.cpp:
+ (JSC::Heap::collect): Avoid crashing when a GC occurs while no global objects are live.
+
+2008-10-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
+ Don't create intermediate StructureIDs for builtin objects
+
+ First step in reduce number of StructureIDs created when initializing the
+ JSGlobalObject.
+
+ - In order to avoid creating the intermediate StructureIDs use the new putDirectWithoutTransition
+ and putDirectFunctionWithoutTransition to add properties to JSObjects without transitioning
+ the StructureID. This patch just implements this strategy for ObjectPrototype but alone
+ reduces the number of StructureIDs create for about:blank by 10, from 142 to 132.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::putDirectFunctionWithoutTransition):
+ * kjs/JSObject.h:
+ (JSC::JSObject::putDirectWithoutTransition):
+ * kjs/ObjectPrototype.cpp:
+ (JSC::ObjectPrototype::ObjectPrototype):
+ * kjs/ObjectPrototype.h:
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::addPropertyWithoutTransition):
+ * kjs/StructureID.h:
+
+2008-10-16 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix for: REGRESSION: over 100 StructureIDs leak loading about:blank (result of fix for bug 21633)
+
+ Apparent slight progression (< 0.5%) on v8 benchmarks and SunSpider.
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::~StructureID): Don't deref this object's parent's pointer to
+ itself from the destructor; that doesn't even make sense.
+ (JSC::StructureID::addPropertyTransition): Don't refer the single transition;
+ the rule is that parent StructureIDs are ref'd but child ones are not. Refing
+ the child creates a cycle.
+
+2008-10-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21609
+ Make MessagePorts protect their peers across heaps
+
+ * JavaScriptCore.exp:
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::markCrossHeapDependentObjects):
+ * kjs/JSGlobalObject.h:
+ * kjs/collector.cpp:
+ (JSC::Heap::collect):
+ Before GC sweep phase, a function supplied by global object is now called for all global
+ objects in the heap, making it possible to implement cross-heap dependencies.
+
+2008-10-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21610
+ run-webkit-threads --threaded crashes in StructureID destructor
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+ Protect access to a static (debug-only) HashSet with a lock.
+
+2008-10-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Goeffrey Garen.
+
+ Add function to dump statistics for StructureIDs.
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::dumpStatistics):
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+ * kjs/StructureID.h:
+
+2008-10-15 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21633: Avoid using a HashMap when there is only a single transition
+ <https://bugs.webkit.org/show_bug.cgi?id=21633>
+
+ This is a 0.8% speedup on SunSpider and between a 0.5% and 1.0% speedup
+ on the V8 benchmark suite, depending on which harness we use. It will
+ also slightly reduce the memory footprint of a StructureID.
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+ (JSC::StructureID::addPropertyTransition):
+ * kjs/StructureID.h:
+ (JSC::StructureID::):
+
+2008-10-15 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Geoffrey Garen.
+
+ 1.40% speedup on SunSpider, 1.44% speedup on V8. (Linux)
+
+ No change on Mac.
+
+ * VM/Machine.cpp:
+ (JSC::fastIsNumber): ALWAYS_INLINE modifier added.
+
+2008-10-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
+ Start the debugger without reloading the inspected page
+
+ * JavaScriptCore.exp: New symbols.
+ * JavaScriptCore.xcodeproj/project.pbxproj: New files.
+
+ * VM/CodeBlock.h:
+ (JSC::EvalCodeCache::get): Updated for tweak to parsing API.
+
+ * kjs/CollectorHeapIterator.h: Added. An iterator for the object heap,
+ which we use to find all the live functions and recompile them.
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate): Updated for tweak to parsing API.
+
+ * kjs/FunctionConstructor.cpp:
+ (JSC::constructFunction): Updated for tweak to parsing API.
+
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction): Try to validate our SourceCode in debug
+ builds by ASSERTing that it's syntactically valid. This doesn't catch
+ all SourceCode bugs, but it catches a lot of them.
+
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval): Updated for tweak to parsing API.
+
+ * kjs/Parser.cpp:
+ (JSC::Parser::parse):
+ * kjs/Parser.h:
+ (JSC::Parser::parse): Tweaked the parser to make it possible to parse
+ without an ExecState, and to allow the client to specify a debugger to
+ notify (or not) about the source we parse. This allows the inspector
+ to recompile even though no JavaScript is executing, then notify the
+ debugger about all source code when it's done.
+
+ * kjs/Shell.cpp:
+ (prettyPrintScript): Updated for tweak to parsing API.
+
+ * kjs/SourceRange.h:
+ (JSC::SourceCode::isNull): Added to help with ASSERTs.
+
+ * kjs/collector.cpp:
+ (JSC::Heap::heapAllocate):
+ (JSC::Heap::sweep):
+ (JSC::Heap::primaryHeapBegin):
+ (JSC::Heap::primaryHeapEnd):
+ * kjs/collector.h:
+ (JSC::): Moved a bunch of declarations around to enable compilation of
+ CollectorHeapIterator.
+
+ * kjs/interpreter.cpp:
+ (JSC::Interpreter::checkSyntax):
+ (JSC::Interpreter::evaluate): Updated for tweak to parsing API.
+
+ * kjs/lexer.h:
+ (JSC::Lexer::sourceCode): BUG FIX: Calculate SourceCode ranges relative
+ to the SourceCode range in which we're lexing, otherwise nested functions
+ that are compiled individually get SourceCode ranges that don't reflect
+ their nesting.
+
+ * kjs/nodes.cpp:
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::finishParsing):
+ (JSC::FunctionBodyNode::create):
+ (JSC::FunctionBodyNode::copyParameters):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::setSource):
+ (JSC::FunctionBodyNode::parameterCount): Added some helper functions for
+ copying one FunctionBodyNode's parameters to another. The recompiler uses
+ these when calling "finishParsing".
+
+2008-10-15 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Darin Adler.
+
+ - part of https://bugs.webkit.org/show_bug.cgi?id=20746
+ Fix compilation on Windows CE.
+
+ str(n)icmp, strdup and vsnprintf are not available on Windows CE,
+ they are called _str(n)icmp, etc. instead
+
+ * wtf/StringExtras.h: Added inline function implementations.
+
+2008-10-15 Gabor Loki <loki@inf.u-szeged.hu>
+
+ Reviewed by Cameron Zwarich.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=20912>
+ Use simple uint32_t multiplication on op_mul if both operands are
+ immediate number and they are between zero and 0x7FFF.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-09 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ Make pan scrolling a platform configurable option.
+ https://bugs.webkit.org/show_bug.cgi?id=21515
+
+ * wtf/Platform.h: Add ENABLE_PAN_SCROLLING
+
+2008-10-14 Maciej Stachowiak <mjs@apple.com>
+
+ Rubber stamped by Sam Weinig.
+
+ - revert r37572 and r37581 for now
+
+ Turns out GCC 4.2 is still a (small) regression, we'll have to do
+ more work to turn it on.
+
+ * Configurations/DebugRelease.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_end):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_timeout_check):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_loop_if_less):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_second):
+ (JSC::Machine::cti_op_put_by_id_generic):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_put_by_val):
+ (JSC::Machine::cti_op_put_by_val_array):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_jless):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_post_dec):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_get_pnames):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_push_scope):
+ (JSC::Machine::cti_op_pop_scope):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_jmp_scopes):
+ (JSC::Machine::cti_op_put_by_index):
+ (JSC::Machine::cti_op_switch_imm):
+ (JSC::Machine::cti_op_switch_char):
+ (JSC::Machine::cti_op_switch_string):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_put_getter):
+ (JSC::Machine::cti_op_put_setter):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_op_debug):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitRestoreArgumentReference):
+ (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
+ * wtf/Platform.h:
+
+2008-10-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20256
+ Array.push and other standard methods disappear
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::~JSGlobalData):
+ Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS -
+ these tables reference IdentifierTable, which is always per-GlobalData.
+
+2008-10-14 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL
+
+ This is a small regression for GCC 4.0, but simplifies the code
+ for future improvements and lets us focus on GCC 4.2+ and MSVC.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_end):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_timeout_check):
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_loop_if_less):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_second):
+ (JSC::Machine::cti_op_put_by_id_generic):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_put_by_val):
+ (JSC::Machine::cti_op_put_by_val_array):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_jless):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_post_dec):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_get_pnames):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_push_scope):
+ (JSC::Machine::cti_op_pop_scope):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_jmp_scopes):
+ (JSC::Machine::cti_op_put_by_index):
+ (JSC::Machine::cti_op_switch_imm):
+ (JSC::Machine::cti_op_switch_char):
+ (JSC::Machine::cti_op_switch_string):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_put_getter):
+ (JSC::Machine::cti_op_put_setter):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_op_debug):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitRestoreArgumentReference):
+ (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
+ * wtf/Platform.h:
+
+2008-10-13 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - make Machine::getArgumentsData an Arguments method and inline it
+
+ ~2% on v8 raytrace
+
+ * VM/Machine.cpp:
+ * kjs/Arguments.h:
+ (JSC::Machine::getArgumentsData):
+
+2008-10-13 Alp Toker <alp@nuanti.com>
+
+ Fix autotools dist build target by listing recently added header
+ files only. Not reviewed.
+
+ * GNUmakefile.am:
+
+2008-10-13 Maciej Stachowiak <mjs@apple.com>
+
+ Rubber stamped by Mark Rowe.
+
+ - fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
+ - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
+
+ * Configurations/DebugRelease.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-10-13 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21541: Move RegisterFile growth check to callee
+ <https://bugs.webkit.org/show_bug.cgi?id=21541>
+
+ Move the RegisterFile growth check to the callee in the common case,
+ where some of the information is known statically at JIT time. There is
+ still a check in the caller in the case where the caller provides too
+ few arguments.
+
+ This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
+ the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
+ 1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
+ SunSpider.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompile):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_register_file_check):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/Machine.h:
+ * VM/RegisterFile.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::cmpl_mr):
+ (JSC::X86Assembler::emitUnlinkedJg):
+
+2008-10-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
+ 5 false positive StructureID leaks
+
+ - Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
+ - Add create method to JSGlolalData to be used when the data will be intentionally
+ leaked and ignore all leaks caused the StructureIDs stored in it.
+
+ * JavaScriptCore.exp:
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::createLeaked):
+ * kjs/JSGlobalData.h:
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+ (JSC::StructureID::startIgnoringLeaks):
+ (JSC::StructureID::stopIgnoringLeaks):
+ * kjs/StructureID.h:
+
+2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Darin Adler. Landed by Jan Alonzo.
+
+ WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
+ http://bugs.webkit.org/show_bug.cgi?id=20483
+
+ Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
+ allocated by GLib and start the conversion to use it.
+
+ * GNUmakefile.am:
+ * wtf/GOwnPtr.cpp: Added.
+ (WTF::GError):
+ (WTF::GList):
+ (WTF::GCond):
+ (WTF::GMutex):
+ (WTF::GPatternSpec):
+ (WTF::GDir):
+ * wtf/GOwnPtr.h: Added.
+ (WTF::freeOwnedPtr):
+ (WTF::GOwnPtr::GOwnPtr):
+ (WTF::GOwnPtr::~GOwnPtr):
+ (WTF::GOwnPtr::get):
+ (WTF::GOwnPtr::release):
+ (WTF::GOwnPtr::rawPtr):
+ (WTF::GOwnPtr::set):
+ (WTF::GOwnPtr::clear):
+ (WTF::GOwnPtr::operator*):
+ (WTF::GOwnPtr::operator->):
+ (WTF::GOwnPtr::operator!):
+ (WTF::GOwnPtr::operator UnspecifiedBoolType):
+ (WTF::GOwnPtr::swap):
+ (WTF::swap):
+ (WTF::operator==):
+ (WTF::operator!=):
+ (WTF::getPtr):
+ * wtf/Threading.h:
+ * wtf/ThreadingGtk.cpp:
+ (WTF::Mutex::~Mutex):
+ (WTF::Mutex::lock):
+ (WTF::Mutex::tryLock):
+ (WTF::Mutex::unlock):
+ (WTF::ThreadCondition::~ThreadCondition):
+ (WTF::ThreadCondition::wait):
+ (WTF::ThreadCondition::timedWait):
+ (WTF::ThreadCondition::signal):
+ (WTF::ThreadCondition::broadcast):
+
+2008-10-12 Gabriella Toth <gtoth@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ - part of https://bugs.webkit.org/show_bug.cgi?id=21055
+ Bug 21055: not invoked functions
+
+ * kjs/nodes.cpp: Deleted a function that is not invoked:
+ statementListInitializeVariableAccessStack.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
+ * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21556
+ Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
+
+ * wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
+ * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
+
+2008-10-12 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Make the append method that takes a Vector more strict - it now requires the elements
+ of the vector to be appended same type as the elements of the Vector they're being appended to.
+
+ This would cause problems when dealing with Vectors containing other Vectors.
+
+ * wtf/Vector.h:
+ (WTF::::append):
+
+2008-10-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Clean up RegExpMatchesArray.h to match our coding style.
+
+ * kjs/RegExpMatchesArray.h:
+ (JSC::RegExpMatchesArray::getOwnPropertySlot):
+ (JSC::RegExpMatchesArray::put):
+ (JSC::RegExpMatchesArray::deleteProperty):
+ (JSC::RegExpMatchesArray::getPropertyNames):
+
+2008-10-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 21525: 55 StructureID leaks on Wikitravel's main page
+ <https://bugs.webkit.org/show_bug.cgi?id=21525>
+
+ Bug 21533: Simple JavaScript code leaks StructureIDs
+ <https://bugs.webkit.org/show_bug.cgi?id=21533>
+
+ StructureID::getEnumerablePropertyNames() ends up calling back to itself
+ via JSObject::getPropertyNames(), which causes the PropertyNameArray to
+ be cached twice. This leads to a memory leak in almost every use of
+ JSObject::getPropertyNames() on an object. The fix here is based on a
+ suggestion of Sam Weinig.
+
+ This patch also fixes every StructureID leaks that occurs while running
+ the Mozilla MemBuster test.
+
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArray::PropertyNameArray):
+ (JSC::PropertyNameArray::setCacheable):
+ (JSC::PropertyNameArray::cacheable):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames):
+
+2008-10-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Use fastcall calling convention on GCC > 4.0
+
+ Results in a 2-3% improvement in GCC 4.2 performance, so
+ that it is no longer a regression vs. GCC 4.0
+
+ * VM/CTI.cpp:
+ * VM/Machine.h:
+ * wtf/Platform.h:
+
+2008-10-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ - Add a workaround for a bug in ceil in Darwin libc.
+ - Remove old workarounds for JS math functions that are not needed
+ anymore.
+
+ The math functions are heavily tested by fast/js/math.html.
+
+ * kjs/MathObject.cpp:
+ (JSC::mathProtoFuncAbs): Remove workaround.
+ (JSC::mathProtoFuncCeil): Ditto.
+ (JSC::mathProtoFuncFloor): Ditto.
+ * wtf/MathExtras.h:
+ (wtf_ceil): Add ceil workaround for darwin.
+
+2008-10-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler
+
+ Add Assertions to JSObject constructor.
+
+ * kjs/JSObject.h:
+ (JSC::JSObject::JSObject):
+
+2008-10-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Remove now unused m_getterSetterFlag variable from PropertyMap.
+
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::operator=):
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMap::PropertyMap):
+
+2008-10-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add leaks checking to StructureID.
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::~StructureID):
+
+2008-10-09 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20760
+ Implement support for x86 Linux in CTI
+
+ Prepare to enable CTI/WREC on supported architectures.
+
+ Make it possible to use the CTI_ARGUMENT workaround with GCC as well
+ as MSVC by fixing some preprocessor conditionals.
+
+ Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
+ don't actually enable it except when building with MSVC. GCC on Win32
+ remains untested.
+
+ Adapt inline ASM code to use the global symbol underscore prefix only
+ on Darwin and to call the properly mangled Machine::cti_vm_throw
+ symbol name depending on CTI_ARGUMENT.
+
+ Also avoid global inclusion of the JIT infrastructure headers
+ throughout WebCore and WebKit causing recompilation of about ~1500
+ source files after modification to X86Assembler.h, CTI.h, WREC.h,
+ which are only used deep inside JavaScriptCore.
+
+ * GNUmakefile.am:
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * kjs/regexp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::~RegExp):
+ (JSC::RegExp::match):
+ * kjs/regexp.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitConvertToFastCall):
+ (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
+ (JSC::X86Assembler::emitRestoreArgumentReference):
+
+2008-10-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for bug #21160, x=0;1/(x*-1) == -Infinity
+
+ * ChangeLog:
+ * VM/CTI.cpp:
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::emitUnlinkedJs):
+
+2008-10-09 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
+ <https://bugs.webkit.org/show_bug.cgi?id=21459>
+
+ After r37324, an Arguments object does not mark an associated activation
+ object. This change was made because Arguments no longer directly used
+ the activation object in any way. However, if an activation is torn off,
+ then the backing store of Arguments becomes the register array of the
+ activation object. Arguments directly marks all of the arguments, but
+ the activation object is being collected, which causes its register
+ array to be freed and new memory to be allocated in its place.
+
+ Unfortunately, it does not seem possible to reproduce this issue in a
+ layout test.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::mark):
+ * kjs/Arguments.h:
+ (JSC::Arguments::setActivation):
+ (JSC::Arguments::Arguments):
+ (JSC::JSActivation::copyRegisters):
+
+2008-10-09 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Build fix for MinGW.
+
+ * wtf/AlwaysInline.h:
+
+2008-10-08 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21497: REGRESSION (r37433): Bytecode JSC tests are severely broken
+ <https://bugs.webkit.org/show_bug.cgi?id=21497>
+
+ Fix a typo in r37433 that causes the failure of a large number of JSC
+ tests with the bytecode interpreter enabled.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-08 Mark Rowe <mrowe@apple.com>
+
+ Windows build fix.
+
+ * VM/CTI.cpp:
+ (JSC::): Update type of argument to ctiTrampoline.
+
+2008-10-08 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21403
+ Bug 21403: use new CallFrame class rather than Register* for call frame manipulation
+
+ Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
+ client over to the new name.
+
+ Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
+ as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
+ accessor functions to get at things in the frame.
+
+ Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
+ JSGlobalData* and in other cases eliminating them entirely.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunctionWithCallback):
+ (JSObjectMakeFunction):
+ (JSObjectHasProperty):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectDeleteProperty):
+ * API/OpaqueJSString.cpp:
+ * API/OpaqueJSString.h:
+ * VM/CTI.cpp:
+ (JSC::CTI::getConstant):
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp):
+ (JSC::CodeGenerator::emitLoad):
+ (JSC::CodeGenerator::emitUnexpectedLoad):
+ (JSC::CodeGenerator::emitConstruct):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAddSlowCase):
+ (JSC::jsAdd):
+ (JSC::jsTypeStringForValue):
+ (JSC::Machine::resolve):
+ (JSC::Machine::resolveSkip):
+ (JSC::Machine::resolveGlobal):
+ (JSC::inlineResolveBase):
+ (JSC::Machine::resolveBase):
+ (JSC::Machine::resolveBaseAndProperty):
+ (JSC::Machine::resolveBaseAndFunc):
+ (JSC::Machine::slideRegisterWindowForCall):
+ (JSC::isNotObject):
+ (JSC::Machine::callEval):
+ (JSC::Machine::dumpCallFrame):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::throwException):
+ (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
+ (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
+ (JSC::Machine::execute):
+ (JSC::Machine::debug):
+ (JSC::Machine::createExceptionScope):
+ (JSC::cachePrototypeChain):
+ (JSC::Machine::tryCachePutByID):
+ (JSC::Machine::tryCacheGetByID):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::retrieveCaller):
+ (JSC::Machine::retrieveLastCaller):
+ (JSC::Machine::findFunctionCallFrame):
+ (JSC::Machine::getArgumentsData):
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::getCTIArrayLengthTrampoline):
+ (JSC::Machine::getCTIStringLengthTrampoline):
+ (JSC::Machine::tryCTICacheGetByID):
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_end):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_timeout_check):
+ (JSC::Machine::cti_op_loop_if_less):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_second):
+ (JSC::Machine::cti_op_put_by_id_generic):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_put_by_val):
+ (JSC::Machine::cti_op_put_by_val_array):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_jless):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_post_dec):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_get_pnames):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_push_scope):
+ (JSC::Machine::cti_op_pop_scope):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_jmp_scopes):
+ (JSC::Machine::cti_op_put_by_index):
+ (JSC::Machine::cti_op_switch_imm):
+ (JSC::Machine::cti_op_switch_char):
+ (JSC::Machine::cti_op_switch_string):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_put_getter):
+ (JSC::Machine::cti_op_put_setter):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_op_debug):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * VM/Register.h:
+ * VM/RegisterFile.h:
+ * kjs/Arguments.h:
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::functionName):
+ (JSC::DebuggerCallFrame::type):
+ (JSC::DebuggerCallFrame::thisObject):
+ (JSC::DebuggerCallFrame::evaluate):
+ * kjs/DebuggerCallFrame.h:
+ * kjs/ExecState.cpp:
+ (JSC::CallFrame::thisValue):
+ * kjs/ExecState.h:
+ * kjs/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::JSActivation):
+ (JSC::JSActivation::argumentsGetter):
+ * kjs/JSActivation.h:
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init):
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ * kjs/JSVariableObject.h:
+ * kjs/Parser.cpp:
+ (JSC::Parser::parse):
+ * kjs/RegExpConstructor.cpp:
+ (JSC::constructRegExp):
+ * kjs/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+ * kjs/Shell.cpp:
+ (prettyPrintScript):
+ * kjs/StringPrototype.cpp:
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ * kjs/identifier.cpp:
+ (JSC::Identifier::checkSameIdentifierTable):
+ * kjs/interpreter.cpp:
+ (JSC::Interpreter::checkSyntax):
+ (JSC::Interpreter::evaluate):
+ * kjs/nodes.cpp:
+ (JSC::ThrowableExpressionData::emitThrowError):
+ (JSC::RegExpNode::emitCode):
+ (JSC::ArrayNode::emitCode):
+ (JSC::InstanceOfNode::emitCode):
+ * kjs/nodes.h:
+ * kjs/regexp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::create):
+ * kjs/regexp.h:
+ * profiler/HeavyProfile.h:
+ * profiler/Profile.h:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+
+2008-10-08 Mark Rowe <mrowe@apple.com>
+
+ Typed by Maciej Stachowiak, reviewed by Mark Rowe.
+
+ Fix crash in fast/js/constant-folding.html with CTI disabled.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-08 Timothy Hatcher <timothy@apple.com>
+
+ Roll out r37427 because it causes an infinite recursion loading about:blank.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21476
+
+2008-10-08 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21403
+ Bug 21403: use new CallFrame class rather than Register* for call frame manipulation
+
+ Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
+ client over to the new name.
+
+ Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
+ as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
+ accessor functions to get at things in the frame.
+
+ Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
+ JSGlobalData* and in other cases eliminating them entirely.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunctionWithCallback):
+ (JSObjectMakeFunction):
+ (JSObjectHasProperty):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectDeleteProperty):
+ * API/OpaqueJSString.cpp:
+ * API/OpaqueJSString.h:
+ * VM/CTI.cpp:
+ (JSC::CTI::getConstant):
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+ (JSC::CTI::printOpcodeOperandTypes):
+ (JSC::CTI::CTI):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp):
+ (JSC::CodeGenerator::emitLoad):
+ (JSC::CodeGenerator::emitUnexpectedLoad):
+ (JSC::CodeGenerator::emitConstruct):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::jsLess):
+ (JSC::jsLessEq):
+ (JSC::jsAddSlowCase):
+ (JSC::jsAdd):
+ (JSC::jsTypeStringForValue):
+ (JSC::Machine::resolve):
+ (JSC::Machine::resolveSkip):
+ (JSC::Machine::resolveGlobal):
+ (JSC::inlineResolveBase):
+ (JSC::Machine::resolveBase):
+ (JSC::Machine::resolveBaseAndProperty):
+ (JSC::Machine::resolveBaseAndFunc):
+ (JSC::Machine::slideRegisterWindowForCall):
+ (JSC::isNotObject):
+ (JSC::Machine::callEval):
+ (JSC::Machine::dumpCallFrame):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::throwException):
+ (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
+ (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
+ (JSC::Machine::execute):
+ (JSC::Machine::debug):
+ (JSC::Machine::createExceptionScope):
+ (JSC::cachePrototypeChain):
+ (JSC::Machine::tryCachePutByID):
+ (JSC::Machine::tryCacheGetByID):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::retrieveCaller):
+ (JSC::Machine::retrieveLastCaller):
+ (JSC::Machine::findFunctionCallFrame):
+ (JSC::Machine::getArgumentsData):
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::getCTIArrayLengthTrampoline):
+ (JSC::Machine::getCTIStringLengthTrampoline):
+ (JSC::Machine::tryCTICacheGetByID):
+ (JSC::Machine::cti_op_convert_this):
+ (JSC::Machine::cti_op_end):
+ (JSC::Machine::cti_op_add):
+ (JSC::Machine::cti_op_pre_inc):
+ (JSC::Machine::cti_timeout_check):
+ (JSC::Machine::cti_op_loop_if_less):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ (JSC::Machine::cti_op_new_object):
+ (JSC::Machine::cti_op_put_by_id):
+ (JSC::Machine::cti_op_put_by_id_second):
+ (JSC::Machine::cti_op_put_by_id_generic):
+ (JSC::Machine::cti_op_put_by_id_fail):
+ (JSC::Machine::cti_op_get_by_id):
+ (JSC::Machine::cti_op_get_by_id_second):
+ (JSC::Machine::cti_op_get_by_id_generic):
+ (JSC::Machine::cti_op_get_by_id_fail):
+ (JSC::Machine::cti_op_instanceof):
+ (JSC::Machine::cti_op_del_by_id):
+ (JSC::Machine::cti_op_mul):
+ (JSC::Machine::cti_op_new_func):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ (JSC::Machine::cti_op_new_array):
+ (JSC::Machine::cti_op_resolve):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_get_by_val):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_sub):
+ (JSC::Machine::cti_op_put_by_val):
+ (JSC::Machine::cti_op_put_by_val_array):
+ (JSC::Machine::cti_op_lesseq):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_negate):
+ (JSC::Machine::cti_op_resolve_base):
+ (JSC::Machine::cti_op_resolve_skip):
+ (JSC::Machine::cti_op_resolve_global):
+ (JSC::Machine::cti_op_div):
+ (JSC::Machine::cti_op_pre_dec):
+ (JSC::Machine::cti_op_jless):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_lshift):
+ (JSC::Machine::cti_op_bitand):
+ (JSC::Machine::cti_op_rshift):
+ (JSC::Machine::cti_op_bitnot):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_new_func_exp):
+ (JSC::Machine::cti_op_mod):
+ (JSC::Machine::cti_op_less):
+ (JSC::Machine::cti_op_neq):
+ (JSC::Machine::cti_op_post_dec):
+ (JSC::Machine::cti_op_urshift):
+ (JSC::Machine::cti_op_bitxor):
+ (JSC::Machine::cti_op_new_regexp):
+ (JSC::Machine::cti_op_bitor):
+ (JSC::Machine::cti_op_call_eval):
+ (JSC::Machine::cti_op_throw):
+ (JSC::Machine::cti_op_get_pnames):
+ (JSC::Machine::cti_op_next_pname):
+ (JSC::Machine::cti_op_push_scope):
+ (JSC::Machine::cti_op_pop_scope):
+ (JSC::Machine::cti_op_typeof):
+ (JSC::Machine::cti_op_to_jsnumber):
+ (JSC::Machine::cti_op_in):
+ (JSC::Machine::cti_op_push_new_scope):
+ (JSC::Machine::cti_op_jmp_scopes):
+ (JSC::Machine::cti_op_put_by_index):
+ (JSC::Machine::cti_op_switch_imm):
+ (JSC::Machine::cti_op_switch_char):
+ (JSC::Machine::cti_op_switch_string):
+ (JSC::Machine::cti_op_del_by_val):
+ (JSC::Machine::cti_op_put_getter):
+ (JSC::Machine::cti_op_put_setter):
+ (JSC::Machine::cti_op_new_error):
+ (JSC::Machine::cti_op_debug):
+ (JSC::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * VM/Register.h:
+ * VM/RegisterFile.h:
+ * kjs/Arguments.h:
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::functionName):
+ (JSC::DebuggerCallFrame::type):
+ (JSC::DebuggerCallFrame::thisObject):
+ (JSC::DebuggerCallFrame::evaluate):
+ * kjs/DebuggerCallFrame.h:
+ * kjs/ExecState.cpp:
+ (JSC::CallFrame::thisValue):
+ * kjs/ExecState.h:
+ * kjs/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::JSActivation):
+ (JSC::JSActivation::argumentsGetter):
+ * kjs/JSActivation.h:
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init):
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval):
+ * kjs/JSVariableObject.h:
+ * kjs/Parser.cpp:
+ (JSC::Parser::parse):
+ * kjs/RegExpConstructor.cpp:
+ (JSC::constructRegExp):
+ * kjs/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+ * kjs/Shell.cpp:
+ (prettyPrintScript):
+ * kjs/StringPrototype.cpp:
+ (JSC::stringProtoFuncMatch):
+ (JSC::stringProtoFuncSearch):
+ * kjs/identifier.cpp:
+ (JSC::Identifier::checkSameIdentifierTable):
+ * kjs/interpreter.cpp:
+ (JSC::Interpreter::checkSyntax):
+ (JSC::Interpreter::evaluate):
+ * kjs/nodes.cpp:
+ (JSC::ThrowableExpressionData::emitThrowError):
+ (JSC::RegExpNode::emitCode):
+ (JSC::ArrayNode::emitCode):
+ (JSC::InstanceOfNode::emitCode):
+ * kjs/nodes.h:
+ * kjs/regexp.cpp:
+ (JSC::RegExp::RegExp):
+ (JSC::RegExp::create):
+ * kjs/regexp.h:
+ * profiler/HeavyProfile.h:
+ * profiler/Profile.h:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+
+2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Oliver Hunt.
+
+ Avoid endless loops when compiling without the computed goto
+ optimization.
+
+ NEXT_OPCODE expands to "continue", which will not work inside
+ loops.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-10-08 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Re-landing the following fix with the crashing bug in it fixed (r37405):
+
+ - optimize away multiplication by constant 1.0
+
+ 2.3% speedup on v8 RayTrace benchmark
+
+ Apparently it's not uncommon for JavaScript code to multiply by
+ constant 1.0 in the mistaken belief that this converts integer to
+ floating point and that there is any operational difference.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for
+ case where parameter is already number.
+ (JSC::CTI::privateCompileSlowCases): ditto
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): ditto
+ * kjs/grammar.y:
+ (makeMultNode): Transform as follows:
+ +FOO * BAR ==> FOO * BAR
+ FOO * +BAR ==> FOO * BAR
+ FOO * 1 ==> +FOO
+ 1 * FOO ==> +FOO
+ (makeDivNode): Transform as follows:
+ +FOO / BAR ==> FOO / BAR
+ FOO / +BAR ==> FOO / BAR
+ (makeSubNode): Transform as follows:
+ +FOO - BAR ==> FOO - BAR
+ FOO - +BAR ==> FOO - BAR
+ * kjs/nodes.h:
+ (JSC::ExpressionNode::stripUnaryPlus): Helper for above
+ grammar.y changes
+ (JSC::UnaryPlusNode::stripUnaryPlus): ditto
+
+2008-10-08 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - correctly handle appending -0 to a string, it should stringify as just 0
+
+ * kjs/ustring.cpp:
+ (JSC::concatenate):
+
+2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix WebKit compilation with VC2008SP1
+
+ Apply the TR1 workaround for JavaScriptCore, too.
+
+ * JavaScriptCore.pro:
+
+2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation errors on VS2008 64Bit
+
+ * kjs/collector.cpp:
+ (JSC::currentThreadStackBase):
+
+2008-10-08 André Pönitz <apoenitz@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation with Qt namespaces.
+
+ * wtf/Threading.h:
+
+2008-10-07 Sam Weinig <sam@webkit.org>
+
+ Roll out r37405.
+
+2008-10-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Switch CTI runtime calls to the fastcall calling convention
+
+ Basically this means that we get to store the argument for CTI
+ calls in the ECX register, which saves a register->memory write
+ and subsequent memory->register read.
+
+ This is a 1.7% progression in SunSpider and 2.4% on commandline
+ v8 tests on Windows
+
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ * VM/CTI.h:
+ * VM/Machine.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitRestoreArgumentReference):
+ (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
+ We need this to correctly reload ecx from inside certain property access
+ trampolines.
+ * wtf/Platform.h:
+
+2008-10-07 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - optimize away multiplication by constant 1.0
+
+ 2.3% speedup on v8 RayTrace benchmark
+
+ Apparently it's not uncommon for JavaScript code to multiply by
+ constant 1.0 in the mistaken belief that this converts integer to
+ floating point and that there is any operational difference.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for
+ case where parameter is already number.
+ (JSC::CTI::privateCompileSlowCases): ditto
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): ditto
+ * kjs/grammar.y:
+ (makeMultNode): Transform as follows:
+ +FOO * BAR ==> FOO * BAR
+ FOO * +BAR ==> FOO * BAR
+ FOO * 1 ==> +FOO
+ 1 * FOO ==> +FOO
+ (makeDivNode): Transform as follows:
+ +FOO / BAR ==> FOO / BAR
+ FOO / +BAR ==> FOO / BAR
+ (makeSubNode): Transform as follows:
+ +FOO - BAR ==> FOO - BAR
+ FOO - +BAR ==> FOO - BAR
+ * kjs/nodes.h:
+ (JSC::ExpressionNode::stripUnaryPlus): Helper for above
+ grammar.y changes
+ (JSC::UnaryPlusNode::stripUnaryPlus): ditto
+
+2008-10-07 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - make constant folding code more consistent
+
+ Added a makeSubNode to match add, mult and div; use the makeFooNode functions always,
+ instead of allocating nodes directly in other places in the grammar.
+
+ * kjs/grammar.y:
+
+2008-10-07 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Move hasGetterSetterProperties flag from PropertyMap to StructureID.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::put):
+ (JSC::JSObject::defineGetter):
+ (JSC::JSObject::defineSetter):
+ * kjs/JSObject.h:
+ (JSC::JSObject::hasGetterSetterProperties):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSObject::getOwnPropertySlot):
+ * kjs/PropertyMap.h:
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::addPropertyTransition):
+ (JSC::StructureID::toDictionaryTransition):
+ (JSC::StructureID::changePrototypeTransition):
+ (JSC::StructureID::getterSetterTransition):
+ * kjs/StructureID.h:
+ (JSC::StructureID::hasGetterSetterProperties):
+ (JSC::StructureID::setHasGetterSetterProperties):
+
+2008-10-07 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Roll r37370 back in with bug fixes.
+
+ - PropertyMap::storageSize() should reflect the number of keys + deletedOffsets
+ and has nothing to do with the internal deletedSentinel count anymore.
+
+2008-10-07 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Move callframe initialization into JIT code, again.
+
+ As a part of the restructuring the second result from functions is now
+ returned in edx, allowing the new value of 'r' to be returned via a
+ register, and stored to the stack from JIT code, too.
+
+ 4.5% progression on v8-tests. (3% in their harness)
+
+ * VM/CTI.cpp:
+ (JSC::):
+ (JSC::CTI::emitCall):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/CTI.h:
+ (JSC::CallRecord::CallRecord):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_resolve_func):
+ (JSC::Machine::cti_op_post_inc):
+ (JSC::Machine::cti_op_resolve_with_base):
+ (JSC::Machine::cti_op_post_dec):
+ * VM/Machine.h:
+ * kjs/JSFunction.h:
+ * kjs/ScopeChain.h:
+
+2008-10-07 Mark Rowe <mrowe@apple.com>
+
+ Fix typo in method name.
+
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+
+2008-10-07 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ Roll out r37370.
+
+2008-10-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21415
+ Improve the division between PropertyStorageArray and PropertyMap
+
+ - Rework ProperyMap to store offsets in the value so that they don't
+ change when rehashing. This allows us not to have to keep the
+ PropertyStorageArray in sync and thus not have to pass it in.
+ - Rename PropertyMap::getOffset -> PropertyMap::get since put/remove
+ now also return offsets.
+ - A Vector of deleted offsets is now needed since the storage is out of
+ band.
+
+ 1% win on SunSpider. Wash on V8 suite.
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::transitionWillNeedStorageRealloc):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ Transition logic can be greatly simplified by the fact that
+ the storage capacity is always known, and is correct for the
+ inline case.
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::put): Rename getOffset -> get.
+ (JSC::JSObject::deleteProperty): Ditto.
+ (JSC::JSObject::getPropertyAttributes): Ditto.
+ (JSC::JSObject::removeDirect): Use returned offset to
+ clear the value in the PropertyNameArray.
+ (JSC::JSObject::allocatePropertyStorage): Add assert.
+ * kjs/JSObject.h:
+ (JSC::JSObject::getDirect): Rename getOffset -> get
+ (JSC::JSObject::getDirectLocation): Rename getOffset -> get
+ (JSC::JSObject::putDirect): Use propertyStorageCapacity to determine whether
+ or not to resize. Also, since put now returns an offset (and thus
+ addPropertyTransition does also) setting of the PropertyStorageArray is
+ now done here.
+ (JSC::JSObject::transitionTo):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::checkConsistency): PropertyStorageArray is no longer
+ passed in.
+ (JSC::PropertyMap::operator=): Copy the delete offsets vector.
+ (JSC::PropertyMap::put): Instead of setting the PropertyNameArray
+ explicitly, return the offset where the value should go.
+ (JSC::PropertyMap::remove): Instead of removing from the PropertyNameArray
+ explicitly, return the offset where the value should be removed.
+ (JSC::PropertyMap::get): Switch to using the stored offset, instead
+ of the implicit one.
+ (JSC::PropertyMap::insert):
+ (JSC::PropertyMap::expand): This is never called when m_table is null,
+ so remove that branch and add it as an assertion.
+ (JSC::PropertyMap::createTable): Consistency checks no longer take
+ a PropertyNameArray.
+ (JSC::PropertyMap::rehash): No need to rehash the PropertyNameArray
+ now that it is completely out of band.
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMapEntry::PropertyMapEntry): Store offset into PropertyNameArray.
+ (JSC::PropertyMap::get): Switch to using the stored offset, instead
+ of the implicit one.
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID): Initialize the propertyStorageCapacity to
+ JSObject::inlineStorageCapacity.
+ (JSC::StructureID::growPropertyStorageCapacity): Grow the storage capacity as
+ described below.
+ (JSC::StructureID::addPropertyTransition): Copy the storage capacity.
+ (JSC::StructureID::toDictionaryTransition): Ditto.
+ (JSC::StructureID::changePrototypeTransition): Ditto.
+ (JSC::StructureID::getterSetterTransition): Ditto.
+ * kjs/StructureID.h:
+ (JSC::StructureID::propertyStorageCapacity): Add propertyStorageCapacity
+ which is the current capacity for the JSObjects PropertyStorageArray.
+ It starts at the JSObject::inlineStorageCapacity (currently 2), then
+ when it first needs to be resized moves to the JSObject::nonInlineBaseStorageCapacity
+ (currently 16), and after that doubles each time.
+
+2008-10-06 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21396: Remove the OptionalCalleeActivation call frame slot
+ <https://bugs.webkit.org/show_bug.cgi?id=21396>
+
+ Remove the OptionalCalleeActivation call frame slot. We have to be
+ careful to store the activation object in a register, because objects
+ in the scope chain do not get marked.
+
+ This is a 0.3% speedup on both SunSpider and the V8 benchmark.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::emitReturn):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_push_activation):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/Machine.h:
+ (JSC::Machine::initializeCallFrame):
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::):
+
+2008-10-06 Tony Chang <tony@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Chromium doesn't use pthreads on windows, so make its use conditional.
+
+ Also convert a WORD to a DWORD to avoid a compiler warning. This
+ matches the other methods around it.
+
+ * wtf/ThreadingWin.cpp:
+ (WTF::wtfThreadEntryPoint):
+ (WTF::ThreadCondition::broadcast):
+
+2008-10-06 Mark Mentovai <mark@moxienet.com>
+
+ Reviewed by Tim Hatcher.
+
+ Allow ENABLE_DASHBOARD_SUPPORT and ENABLE_MAC_JAVA_BRIDGE to be
+ disabled on the Mac.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21333
+
+ * wtf/Platform.h:
+
+2008-10-06 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21416
+ Pass 0 for size to VirtualAlloc, as documented by MSDN.
+ Identified by Application Verifier.
+
+ Reviewed by Darin Adler.
+
+ * kjs/collector.cpp:
+ (KJS::freeBlock):
+
+2008-10-06 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcheri and Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21412
+ Bug 21412: Refactor user initiated profile count to be more stable
+ - Export UString::from for use with creating the profile title.
+
+ * JavaScriptCore.exp:
+
+2008-10-06 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed. Build fix.
+
+ - revert toBoolean changes (r37333 and r37335); need to make WebCore work with these
+
+ * API/JSValueRef.cpp:
+ (JSValueToBoolean):
+ * ChangeLog:
+ * JavaScriptCore.exp:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ * kjs/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncSome):
+ * kjs/BooleanConstructor.cpp:
+ (JSC::constructBoolean):
+ (JSC::callBooleanConstructor):
+ * kjs/GetterSetter.h:
+ * kjs/JSCell.h:
+ (JSC::JSValue::toBoolean):
+ * kjs/JSNumberCell.cpp:
+ (JSC::JSNumberCell::toBoolean):
+ * kjs/JSNumberCell.h:
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::toBoolean):
+ * kjs/JSObject.h:
+ * kjs/JSString.cpp:
+ (JSC::JSString::toBoolean):
+ * kjs/JSString.h:
+ * kjs/JSValue.h:
+ * kjs/RegExpConstructor.cpp:
+ (JSC::setRegExpConstructorMultiline):
+ * kjs/RegExpObject.cpp:
+ (JSC::RegExpObject::match):
+ * kjs/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncToString):
+
+2008-10-06 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - optimize op_jtrue, op_loop_if_true and op_not in various ways
+ https://bugs.webkit.org/show_bug.cgi?id=21404
+
+ 1) Make JSValue::toBoolean nonvirtual and completely inline by
+ making use of the StructureID type field.
+
+ 2) Make JSValue::toBoolean not take an ExecState; doesn't need it.
+
+ 3) Make op_not, op_loop_if_true and op_jtrue not read the
+ ExecState (toBoolean doesn't need it any more) and not check
+ exceptions (toBoolean can't throw).
+
+ * API/JSValueRef.cpp:
+ (JSValueToBoolean):
+ * JavaScriptCore.exp:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_loop_if_true):
+ (JSC::Machine::cti_op_not):
+ (JSC::Machine::cti_op_jtrue):
+ * kjs/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncFilter):
+ (JSC::arrayProtoFuncEvery):
+ (JSC::arrayProtoFuncSome):
+ * kjs/BooleanConstructor.cpp:
+ (JSC::constructBoolean):
+ (JSC::callBooleanConstructor):
+ * kjs/GetterSetter.h:
+ * kjs/JSCell.h:
+ (JSC::JSValue::toBoolean):
+ * kjs/JSNumberCell.cpp:
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::toBoolean):
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ (JSC::JSObject::toBoolean):
+ (JSC::JSCell::toBoolean):
+ * kjs/JSString.cpp:
+ * kjs/JSString.h:
+ (JSC::JSString::toBoolean):
+ * kjs/JSValue.h:
+ * kjs/RegExpConstructor.cpp:
+ (JSC::setRegExpConstructorMultiline):
+ * kjs/RegExpObject.cpp:
+ (JSC::RegExpObject::match):
+ * kjs/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncToString):
+
+2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Build fix for MinGW.
+
+ * JavaScriptCore.pri:
+ * kjs/DateMath.cpp:
+ (JSC::highResUpTime):
+
+2008-10-05 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove ScopeNode::containsClosures() now that it is unused.
+
+ * kjs/nodes.h:
+ (JSC::ScopeNode::containsClosures):
+
+2008-10-05 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix releas-only test failures caused by the fix to bug 21375
+
+ * VM/Machine.cpp:
+ (JSC::Machine::unwindCallFrame): Update ExecState while unwinding call frames;
+ it now matters more to have a still-valid ExecState, since dynamicGlobalObject
+ will make use of the ExecState's scope chain.
+ * VM/Machine.h:
+
+2008-10-05 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
+ <https://bugs.webkit.org/show_bug.cgi?id=21364>
+
+ Use information from the parser to detect whether an activation is
+ needed or 'arguments' is used, and emit explicit instructions to tear
+ them off before op_ret. This allows a branch to be removed from op_ret
+ and simplifies some other code. This does cause a small change in the
+ behaviour of 'f.arguments'; it is no longer live when 'arguments' is not
+ mentioned in the lexical scope of the function.
+
+ It should now be easy to remove the OptionaCalleeActivation slot in the
+ call frame, but this will be done in a later patch.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitReturn):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_tear_off_activation):
+ (JSC::Machine::cti_op_tear_off_arguments):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::mark):
+ * kjs/Arguments.h:
+ (JSC::Arguments::isTornOff):
+ (JSC::Arguments::Arguments):
+ (JSC::Arguments::copyRegisters):
+ (JSC::JSActivation::copyRegisters):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::argumentsGetter):
+ * kjs/JSActivation.h:
+
+2008-10-05 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fixed "REGRESSION (r37297): fast/js/deep-recursion-test takes too long and times out"
+ https://bugs.webkit.org/show_bug.cgi?id=21375
+
+ The problem is that dynamicGlobalObject had become O(N) in number
+ of call frames, but unwinding the stack for an exception called it
+ for every call frame, resulting in O(N^2) behavior for an
+ exception thrown from inside deep recursion.
+
+ Instead of doing it that way, stash the dynamic global object in JSGlobalData.
+
+ * JavaScriptCore.exp:
+ * VM/Machine.cpp:
+ (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Helper class to temporarily
+ store and later restore a dynamicGlobalObject in JSGlobalData.
+ (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
+ (JSC::Machine::execute): In each version, establish a DynamicGlobalObjectScope.
+ For ProgramNode, always establish set new dynamicGlobalObject, for FunctionBody and Eval,
+ only if none is currently set.
+ * VM/Machine.h:
+ * kjs/ExecState.h:
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Ininitalize new dynamicGlobalObject field to 0.
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.h:
+ (JSC::ExecState::dynamicGlobalObject): Moved here from ExecState for benefit of inlining.
+ Return lexical global object if this is a globalExec(), otherwise look in JSGlobalData
+ for the one stashed there.
+
+2008-10-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Avoid an extra lookup when transitioning to an existing StructureID
+ by caching the offset of property that caused the transition.
+
+ 1% win on V8 suite. Wash on SunSpider.
+
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::put):
+ * kjs/PropertyMap.h:
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::addPropertyTransition):
+ * kjs/StructureID.h:
+ (JSC::StructureID::setCachedTransistionOffset):
+ (JSC::StructureID::cachedTransistionOffset):
+
+2008-10-05 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
+ <https://bugs.webkit.org/show_bug.cgi?id=21364>
+
+ This patch does not yet remove the branch, but it does a bit of refactoring
+ so that a CodeGenerator now knows whether the associated CodeBlock will need
+ a full scope before doing any code generation. This makes it possible to emit
+ explicit tear-off instructions before every op_ret.
+
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate):
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::emitPushScope):
+ (JSC::CodeGenerator::emitPushNewScope):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::needsActivation):
+
+2008-10-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for bug #21387 - using SamplingTool with CTI.
+
+ (1) A repatch offset offset changes due to an additional instruction to update SamplingTool state.
+ (2) Fix an incusion order problem due to ExecState changes.
+ (3) Change to a MACHINE_SAMPLING macro, use of exec should now be accessing global data.
+
+ * VM/CTI.h:
+ (JSC::CTI::execute):
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::privateExecuteReturned):
+ * kjs/Shell.cpp:
+
+2008-10-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-10-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=21320
+ leaks of PropertyNameArrayData seen on buildbot
+
+ - Fix RefPtr cycle by making PropertyNameArrayData's pointer back
+ to the StructureID a weak pointer.
+
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArrayData::setCachedStructureID):
+ (JSC::PropertyNameArrayData::cachedStructureID):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames):
+ (JSC::StructureID::clearEnumerationCache):
+ (JSC::StructureID::~StructureID):
+
+2008-10-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21295
+ Bug 21295: Replace ExecState with a call frame Register pointer
+
+ 10% faster on Richards; other v8 benchmarks faster too.
+ A wash on SunSpider.
+
+ This does the minimum necessary to get the speedup. Next step in
+ cleaning this up is to replace ExecState with a CallFrame class,
+ and be more judicious about when to pass a call frame and when
+ to pass a global data pointer, global object pointer, or perhaps
+ something else entirely.
+
+ * VM/CTI.cpp: Remove the debug-only check of the exception in
+ ctiVMThrowTrampoline -- already checked in the code the trampoline
+ jumps to, so not all that useful. Removed the exec argument from
+ ctiTrampoline. Removed emitDebugExceptionCheck -- no longer needed.
+ (JSC::CTI::emitCall): Removed code to set ExecState::m_callFrame.
+ (JSC::CTI::privateCompileMainPass): Removed code in catch to extract
+ the exception from ExecState::m_exception; instead, the code that
+ jumps into catch will make sure the exception is already in eax.
+ * VM/CTI.h: Removed exec from the ctiTrampoline. Also removed the
+ non-helpful "volatile". Temporarily left ARG_exec in as a synonym
+ for ARG_r; I'll change that on a future cleanup pass when introducing
+ more use of the CallFrame type.
+ (JSC::CTI::execute): Removed the ExecState* argument.
+
+ * VM/ExceptionHelpers.cpp:
+ (JSC::InterruptedExecutionError::InterruptedExecutionError): Take
+ JSGlobalData* instead of ExecState*.
+ (JSC::createInterruptedExecutionException): Ditto.
+ * VM/ExceptionHelpers.h: Ditto. Also removed an unneeded include.
+
+ * VM/Machine.cpp:
+ (JSC::slideRegisterWindowForCall): Removed the exec and
+ exceptionValue arguments. Changed to return 0 when there's a stack
+ overflow rather than using a separate exception argument to cut
+ down on memory accesses in the calling convention.
+ (JSC::Machine::unwindCallFrame): Removed the exec argument when
+ constructing a DebuggerCallFrame. Also removed code to set
+ ExecState::m_callFrame.
+ (JSC::Machine::throwException): Removed the exec argument when
+ construction a DebuggerCallFrame.
+ (JSC::Machine::execute): Updated to use the register instead of
+ ExecState and also removed various uses of ExecState.
+ (JSC::Machine::debug):
+ (JSC::Machine::privateExecute): Put globalData into a local
+ variable so it can be used throughout the interpreter. Changed
+ the VM_CHECK_EXCEPTION to get the exception in globalData instead
+ of through ExecState.
+ (JSC::Machine::retrieveLastCaller): Turn exec into a registers
+ pointer by calling registers() instead of by getting m_callFrame.
+ (JSC::Machine::callFrame): Ditto.
+ Tweaked exception macros. Made new versions for when you know
+ you have an exception. Get at global exception with ARG_globalData.
+ Got rid of the need to pass in the return value type.
+ (JSC::Machine::cti_op_add): Update to use new version of exception
+ macros.
+ (JSC::Machine::cti_op_pre_inc): Ditto.
+ (JSC::Machine::cti_timeout_check): Ditto.
+ (JSC::Machine::cti_op_instanceof): Ditto.
+ (JSC::Machine::cti_op_new_func): Ditto.
+ (JSC::Machine::cti_op_call_JSFunction): Optimized by using the
+ ARG values directly instead of through local variables -- this gets
+ rid of code that just shuffles things around in the stack frame.
+ Also get rid of ExecState and update for the new way exceptions are
+ handled in slideRegisterWindowForCall.
+ (JSC::Machine::cti_vm_compile): Update to make exec out of r since
+ they are both the same thing now.
+ (JSC::Machine::cti_op_call_NotJSFunction): Ditto.
+ (JSC::Machine::cti_op_init_arguments): Ditto.
+ (JSC::Machine::cti_op_resolve): Ditto.
+ (JSC::Machine::cti_op_construct_JSConstruct): Ditto.
+ (JSC::Machine::cti_op_construct_NotJSConstruct): Ditto.
+ (JSC::Machine::cti_op_resolve_func): Ditto.
+ (JSC::Machine::cti_op_put_by_val): Ditto.
+ (JSC::Machine::cti_op_put_by_val_array): Ditto.
+ (JSC::Machine::cti_op_resolve_skip): Ditto.
+ (JSC::Machine::cti_op_resolve_global): Ditto.
+ (JSC::Machine::cti_op_post_inc): Ditto.
+ (JSC::Machine::cti_op_resolve_with_base): Ditto.
+ (JSC::Machine::cti_op_post_dec): Ditto.
+ (JSC::Machine::cti_op_call_eval): Ditto.
+ (JSC::Machine::cti_op_throw): Ditto. Also rearranged to return
+ the exception value as the return value so it can be used by
+ op_catch.
+ (JSC::Machine::cti_op_push_scope): Ditto.
+ (JSC::Machine::cti_op_in): Ditto.
+ (JSC::Machine::cti_op_del_by_val): Ditto.
+ (JSC::Machine::cti_vm_throw): Ditto. Also rearranged to return
+ the exception value as the return value so it can be used by
+ op_catch.
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::functionName): Pass globalData.
+ (JSC::DebuggerCallFrame::evaluate): Eliminated code to make a
+ new ExecState.
+ * kjs/DebuggerCallFrame.h: Removed ExecState argument from
+ constructor.
+
+ * kjs/ExecState.h: Eliminated all data members and made ExecState
+ inherit privately from Register instead. Also added a typedef to
+ the future name for this class, which is CallFrame. It's just a
+ Register* that knows it's a pointer at a call frame. The new class
+ can't be constructed or copied. Changed all functions to use
+ the this pointer instead of m_callFrame. Changed exception-related
+ functions to access an exception in JSGlobalData. Removed functions
+ used by CTI to pass the return address to the throw machinery --
+ this is now done directly with a global in the global data.
+
+ * kjs/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncToString): Pass globalData instead of exec.
+
+ * kjs/InternalFunction.cpp:
+ (JSC::InternalFunction::name): Take globalData instead of exec.
+ * kjs/InternalFunction.h: Ditto.
+
+ * kjs/JSGlobalData.cpp: Initialize the new exception global to 0.
+ * kjs/JSGlobalData.h: Declare two new globals. One for the current
+ exception and another for the return address used by CTI to
+ implement the throw operation.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init): Removed code to set up globalExec,
+ which is now the same thing as globalCallFrame.
+ (JSC::JSGlobalObject::reset): Get globalExec from our globalExec
+ function so we don't have to repeat the logic twice.
+ (JSC::JSGlobalObject::mark): Removed code to mark the exception;
+ the exception is now stored in JSGlobalData and marked there.
+ (JSC::JSGlobalObject::globalExec): Return a pointer to the end
+ of the global call frame.
+ * kjs/JSGlobalObject.h: Removed the globalExec data member.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::putDirectFunction): Pass globalData instead of exec.
+
+ * kjs/collector.cpp:
+ (JSC::Heap::collect): Mark the global exception.
+
+ * profiler/ProfileGenerator.cpp:
+ (JSC::ProfileGenerator::addParentForConsoleStart): Pass globalData
+ instead of exec to createCallIdentifier.
+
+ * profiler/Profiler.cpp:
+ (JSC::Profiler::willExecute): Pass globalData instead of exec to
+ createCallIdentifier.
+ (JSC::Profiler::didExecute): Ditto.
+ (JSC::Profiler::createCallIdentifier): Take globalData instead of
+ exec.
+ (JSC::createCallIdentifierFromFunctionImp): Ditto.
+ * profiler/Profiler.h: Change interface to take a JSGlobalData
+ instead of an ExecState.
+
+2008-10-04 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 21369: Add opcode documentation for all undocumented opcodes
+ <https://bugs.webkit.org/show_bug.cgi?id=21369>
+
+ This patch adds opcode documentation for all undocumented opcodes, and
+ it also renames op_init_arguments to op_create_arguments.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_create_arguments):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+
+2008-10-03 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - "this" object in methods called on primitives should be wrapper object
+ https://bugs.webkit.org/show_bug.cgi?id=21362
+
+ I changed things so that functions which use "this" do a fast
+ version of toThisObject conversion if needed. Currently we miss
+ the conversion entirely, at least for primitive types. Using
+ TypeInfo and the primitive check, I made the fast case bail out
+ pretty fast.
+
+ This is inexplicably an 1.007x SunSpider speedup (and a wash on V8 benchmarks).
+
+ Also renamed some opcodes for clarity:
+
+ init ==> enter
+ init_activation ==> enter_with_activation
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate):
+ (JSC::CodeGenerator::CodeGenerator):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_convert_this):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::JSActivation):
+ * kjs/JSActivation.h:
+ (JSC::JSActivation::createStructureID):
+ * kjs/JSCell.h:
+ (JSC::JSValue::needsThisConversion):
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * kjs/JSGlobalData.h:
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::createStructureID):
+ * kjs/JSStaticScopeObject.h:
+ (JSC::JSStaticScopeObject::JSStaticScopeObject):
+ (JSC::JSStaticScopeObject::createStructureID):
+ * kjs/JSString.h:
+ (JSC::JSString::createStructureID):
+ * kjs/JSValue.h:
+ * kjs/TypeInfo.h:
+ (JSC::TypeInfo::needsThisConversion):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::usesThis):
+
+2008-10-03 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
+ <https://bugs.webkit.org/show_bug.cgi?id=21356>
+
+ The RegisterFile decreases in size (measured in terms of numbers of
+ Registers) as the size of a Register increases. This causes
+
+ js1_5/Regress/regress-159334.js
+
+ to fail in 64-bit debug builds. This fix makes the RegisterFile on all
+ platforms the same size that it is in 32-bit Release builds.
+
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+
+2008-10-03 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - Some code cleanup to how we handle code features.
+
+ 1) Rename FeatureInfo typedef to CodeFeatures.
+ 2) Rename NodeFeatureInfo template to NodeInfo.
+ 3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
+ 4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
+ of ClosureFeature.
+ 5) Make setUsersArguments() not take an argument since it only goes one way.
+
+ * JavaScriptCore.exp:
+ * VM/CodeBlock.h:
+ (JSC::CodeBlock::CodeBlock):
+ * kjs/NodeInfo.h:
+ * kjs/Parser.cpp:
+ (JSC::Parser::didFinishParsing):
+ * kjs/Parser.h:
+ (JSC::Parser::parse):
+ * kjs/grammar.y:
+ * kjs/nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+ (JSC::ProgramNode::ProgramNode):
+ (JSC::ProgramNode::create):
+ (JSC::EvalNode::EvalNode):
+ (JSC::EvalNode::create):
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::create):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::usesEval):
+ (JSC::ScopeNode::containsClosures):
+ (JSC::ScopeNode::usesArguments):
+ (JSC::ScopeNode::setUsesArguments):
+
+2008-10-03 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
+ <https://bugs.webkit.org/show_bug.cgi?id=21343>
+
+ A fix was landed for this issue in r37253, and the ChangeLog assumes
+ that it is a compiler bug, but it turns out that it is a subtle issue
+ with mixing signed and unsigned 32-bit values in a 64-bit environment.
+ In order to properly fix this bug, we should convert our signed offsets
+ into the register file to use ptrdiff_t.
+
+ This may not be the only instance of this issue, but I will land this
+ fix first and look for more later.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::getArgumentsData):
+ * VM/Machine.h:
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::getOwnPropertySlot):
+ * kjs/Arguments.h:
+ (JSC::Arguments::init):
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ * VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.
+
+ * kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added
+ declarations of JSGlobalData overloads of jsNumberCell.
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ - try to fix Windows build
+
+ * kjs/ScopeChain.h: Add forward declaration of JSGlobalData.
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
+ Turn ExecState into a call frame pointer.
+
+ Remove m_globalObject and m_globalData from ExecState.
+
+ SunSpider says this is a wash (slightly faster but not statistically
+ significant); which is good enough since it's a preparation step and
+ not supposed to be a spedup.
+
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::JSCallbackFunction):
+ * kjs/ArrayConstructor.cpp:
+ (JSC::ArrayConstructor::ArrayConstructor):
+ * kjs/BooleanConstructor.cpp:
+ (JSC::BooleanConstructor::BooleanConstructor):
+ * kjs/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ * kjs/ErrorConstructor.cpp:
+ (JSC::ErrorConstructor::ErrorConstructor):
+ * kjs/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::FunctionPrototype):
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
+ * kjs/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ * kjs/NumberConstructor.cpp:
+ (JSC::NumberConstructor::NumberConstructor):
+ * kjs/ObjectConstructor.cpp:
+ (JSC::ObjectConstructor::ObjectConstructor):
+ * kjs/PrototypeFunction.cpp:
+ (JSC::PrototypeFunction::PrototypeFunction):
+ * kjs/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::RegExpConstructor):
+ * kjs/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+ Pass JSGlobalData* instead of ExecState* to the InternalFunction
+ constructor.
+
+ * API/OpaqueJSString.cpp: Added now-needed include.
+
+ * JavaScriptCore.exp: Updated.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData
+ instead of ARGS_exec.
+
+ * VM/CTI.h: Added a new argument to the CTI, the global data pointer.
+ While it's possible to get to the global data pointer using the
+ ExecState pointer, it's slow enough that it's better to just keep
+ it around in the CTI arguments.
+
+ * VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::execute): Pass fewer arguments when constructing
+ ExecState, and pass the global data pointer when invoking CTI.
+ (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global
+ object, which is in the scope chain of the first call frame.
+ (JSC::Machine::cti_op_add): Use globalData instead of exec when
+ possible, to keep fast cases fast, since it's now more expensive to
+ get to it through the exec pointer.
+ (JSC::Machine::cti_timeout_check): Ditto.
+ (JSC::Machine::cti_op_put_by_id_second): Ditto.
+ (JSC::Machine::cti_op_get_by_id_second): Ditto.
+ (JSC::Machine::cti_op_mul): Ditto.
+ (JSC::Machine::cti_vm_compile): Ditto.
+ (JSC::Machine::cti_op_get_by_val): Ditto.
+ (JSC::Machine::cti_op_sub): Ditto.
+ (JSC::Machine::cti_op_put_by_val): Ditto.
+ (JSC::Machine::cti_op_put_by_val_array): Ditto.
+ (JSC::Machine::cti_op_negate): Ditto.
+ (JSC::Machine::cti_op_div): Ditto.
+ (JSC::Machine::cti_op_pre_dec): Ditto.
+ (JSC::Machine::cti_op_post_inc): Ditto.
+ (JSC::Machine::cti_op_lshift): Ditto.
+ (JSC::Machine::cti_op_bitand): Ditto.
+ (JSC::Machine::cti_op_rshift): Ditto.
+ (JSC::Machine::cti_op_bitnot): Ditto.
+ (JSC::Machine::cti_op_mod): Ditto.
+ (JSC::Machine::cti_op_post_dec): Ditto.
+ (JSC::Machine::cti_op_urshift): Ditto.
+ (JSC::Machine::cti_op_bitxor): Ditto.
+ (JSC::Machine::cti_op_bitor): Ditto.
+ (JSC::Machine::cti_op_call_eval): Ditto.
+ (JSC::Machine::cti_op_throw): Ditto.
+ (JSC::Machine::cti_op_is_string): Ditto.
+ (JSC::Machine::cti_op_debug): Ditto.
+ (JSC::Machine::cti_vm_throw): Ditto.
+
+ * VM/Machine.h: Added firstCallFrame.
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when
+ constructing ExecState.
+
+ * kjs/ExecState.cpp: Deleted contents. Later we'll remove the
+ file altogether.
+
+ * kjs/ExecState.h: Removed m_globalObject and m_globalData.
+ Moved CodeType into another header.
+ (JSC::ExecState::ExecState): Take only a single argument, a
+ call frame pointer.
+ (JSC::ExecState::dynamicGlobalObject): Get the object from
+ the first call frame since it's no longer stored.
+ (JSC::ExecState::globalData): Get the global data from the
+ scope chain, since we no longer store a pointer to it here.
+ (JSC::ExecState::identifierTable): Ditto.
+ (JSC::ExecState::propertyNames): Ditto.
+ (JSC::ExecState::emptyList): Ditto.
+ (JSC::ExecState::lexer): Ditto.
+ (JSC::ExecState::parser): Ditto.
+ (JSC::ExecState::machine): Ditto.
+ (JSC::ExecState::arrayTable): Ditto.
+ (JSC::ExecState::dateTable): Ditto.
+ (JSC::ExecState::mathTable): Ditto.
+ (JSC::ExecState::numberTable): Ditto.
+ (JSC::ExecState::regExpTable): Ditto.
+ (JSC::ExecState::regExpConstructorTable): Ditto.
+ (JSC::ExecState::stringTable): Ditto.
+ (JSC::ExecState::heap): Ditto.
+
+ * kjs/FunctionConstructor.cpp:
+ (JSC::FunctionConstructor::FunctionConstructor): Pass
+ JSGlobalData* instead of ExecState* to the InternalFunction
+ constructor.
+ (JSC::constructFunction): Pass the global data pointer when
+ constructing a new scope chain.
+
+ * kjs/InternalFunction.cpp:
+ (JSC::InternalFunction::InternalFunction): Take a JSGlobalData*
+ instead of an ExecState*. Later we can change more places to
+ work this way -- it's more efficient to take the type you need
+ since the caller might already have it.
+ * kjs/InternalFunction.h: Ditto.
+
+ * kjs/JSCell.h:
+ (JSC::JSCell::operator new): Added an overload that takes a
+ JSGlobalData* so you can construct without an ExecState*.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init): Moved creation of the global scope
+ chain in here, since it now requires a pointer to the global data.
+ Moved the initialization of the call frame in here since it requires
+ the global scope chain node. Removed the extra argument to ExecState
+ when creating the global ExecState*.
+ * kjs/JSGlobalObject.h: Removed initialization of globalScopeChain
+ and the call frame from the JSGlobalObjectData constructor. Added
+ a thisValue argument to the init function.
+
+ * kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take
+ JSGlobalData* rather than ExecState*.
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::operator new): Added a version that takes
+ JSGlobalData*.
+ (JSC::JSNumberCell::JSNumberCell): Ditto.
+ (JSC::jsNumber): Ditto.
+ * kjs/JSString.cpp:
+ (JSC::jsString): Ditto.
+ (JSC::jsSubstring): Ditto.
+ (JSC::jsOwnedString): Ditto.
+ * kjs/JSString.h:
+ (JSC::JSString::JSString): Changed to take JSGlobalData*.
+ (JSC::jsEmptyString): Added a version that takes JSGlobalData*.
+ (JSC::jsSingleCharacterString): Ditto.
+ (JSC::jsSingleCharacterSubstring): Ditto.
+ (JSC::jsNontrivialString): Ditto.
+ (JSC::JSString::getIndex): Ditto.
+ (JSC::jsString): Ditto.
+ (JSC::jsSubstring): Ditto.
+ (JSC::jsOwnedString): Ditto.
+
+ * kjs/ScopeChain.h: Added a globalData pointer to each node.
+ (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData
+ pointer.
+ (JSC::ScopeChainNode::push): Set the global data pointer in the
+ new node.
+ (JSC::ScopeChain::ScopeChain): Take a globalData argument.
+
+ * kjs/SmallStrings.cpp:
+ (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of
+ ExecState*.
+ (JSC::SmallStrings::createSingleCharacterString): Ditto.
+ * kjs/SmallStrings.h:
+ (JSC::SmallStrings::emptyString): Ditto.
+ (JSC::SmallStrings::singleCharacterString): Ditto.
+
+2008-10-03 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
+ <https://bugs.webkit.org/show_bug.cgi?id=21343>
+
+ Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
+ llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
+ on SunSpider in 32-bit, although that might be entirely random.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::getOwnPropertySlot):
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ Rubber stamped by Alexey Proskuryakov.
+
+ * kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change
+ this tool to use public JavaScriptCore API instead.
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ Suggested by Alexey Proskuryakov.
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because
+ it's too late to ref the JSGlobalData object once it's already being
+ destroyed. In practice this is not a problem because WebCore's JSGlobalData
+ is never destroyed and JSGlobalContextRelease takes care of calling
+ heap.destroy() in advance.
+
+2008-10-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.
+
+ 5.6% win on SunSpider on windows.
+
+ * VM/CTI.cpp:
+ (JSC::isSSE2Present):
+ (JSC::CTI::compileBinaryArithOp):
+ (JSC::CTI::compileBinaryArithOpSlowCase):
+
+2008-10-03 Maciej Stachowiak <mjs@apple.com>
+
+ Rubber stamped by Cameron Zwarich.
+
+ - fix mistaken change of | to || which caused a big perf regression on EarleyBoyer
+
+ * kjs/grammar.y:
+
+2008-10-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21321
+ Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
+
+ 1.019x as fast on SunSpider.
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript): Use heap. instead of heap-> to work with the heap.
+ (JSCheckScriptSyntax): Ditto.
+ (JSGarbageCollect): Ditto.
+ (JSReportExtraMemoryCost): Ditto.
+ * API/JSContextRef.cpp:
+ (JSGlobalContextRetain): Ditto.
+ (JSGlobalContextRelease): Destroy the heap with the destroy function instead
+ of the delete operator.
+ (JSContextGetGlobalObject): Use heap. instead of heap-> to work with the heap.
+ * API/JSObjectRef.cpp:
+ (JSObjectMake): Use heap. instead of heap-> to work with the heap.
+ (JSObjectMakeFunctionWithCallback): Ditto.
+ (JSObjectMakeConstructor): Ditto.
+ (JSObjectMakeFunction): Ditto.
+ (JSObjectMakeArray): Ditto.
+ (JSObjectMakeDate): Ditto.
+ (JSObjectMakeError): Ditto.
+ (JSObjectMakeRegExp): Ditto.
+ (JSObjectHasProperty): Ditto.
+ (JSObjectGetProperty): Ditto.
+ (JSObjectSetProperty): Ditto.
+ (JSObjectGetPropertyAtIndex): Ditto.
+ (JSObjectSetPropertyAtIndex): Ditto.
+ (JSObjectDeleteProperty): Ditto.
+ (JSObjectCallAsFunction): Ditto.
+ (JSObjectCallAsConstructor): Ditto.
+ (JSObjectCopyPropertyNames): Ditto.
+ (JSPropertyNameAccumulatorAddName): Ditto.
+ * API/JSValueRef.cpp:
+ (JSValueIsEqual): Ditto.
+ (JSValueIsInstanceOfConstructor): Ditto.
+ (JSValueMakeNumber): Ditto.
+ (JSValueMakeString): Ditto.
+ (JSValueToNumber): Ditto.
+ (JSValueToStringCopy): Ditto.
+ (JSValueToObject): Ditto.
+ (JSValueProtect): Ditto.
+ (JSValueUnprotect): Ditto.
+
+ * kjs/ExecState.h:
+ (JSC::ExecState::heap): Update to use the & operator.
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Update to initialize a heap member
+ instead of calling new to make a heap.
+ (JSC::JSGlobalData::~JSGlobalData): Destroy the heap with the destroy
+ function instead of the delete operator.
+ * kjs/JSGlobalData.h: Change from Heap* to a Heap.
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::mark): Use the & operator here.
+ (JSC::JSGlobalObject::operator new): Use heap. instead of heap-> to work
+ with the heap.
+
+2008-10-02 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21317: Replace RegisterFile size and capacity information with Register pointers
+ <https://bugs.webkit.org/show_bug.cgi?id=21317>
+
+ This is a 2.3% speedup on the V8 DeltaBlue benchmark, a 3.3% speedup on
+ the V8 Raytrace benchmark, and a 1.0% speedup on SunSpider.
+
+ * VM/Machine.cpp:
+ (JSC::slideRegisterWindowForCall):
+ (JSC::Machine::callEval):
+ (JSC::Machine::execute):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/RegisterFile.cpp:
+ (JSC::RegisterFile::~RegisterFile):
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::RegisterFile):
+ (JSC::RegisterFile::start):
+ (JSC::RegisterFile::end):
+ (JSC::RegisterFile::size):
+ (JSC::RegisterFile::shrink):
+ (JSC::RegisterFile::grow):
+ (JSC::RegisterFile::lastGlobal):
+ (JSC::RegisterFile::markGlobals):
+ (JSC::RegisterFile::markCallFrames):
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::copyGlobalsTo):
+
+2008-10-02 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Darin Adler.
+
+ Change bitwise operations introduced in r37166 to boolean operations. We
+ only use bitwise operations over boolean operations for increasing
+ performance in extremely hot code, but that does not apply to anything
+ in the parser.
+
+ * kjs/grammar.y:
+
+2008-10-02 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for bug #21232 - should reset m_isPendingDash on flush,
+ and should allow '\-' as beginning or end of a range (though
+ not to specifiy a range itself).
+
+ * ChangeLog:
+ * wrec/CharacterClassConstructor.cpp:
+ (JSC::CharacterClassConstructor::put):
+ (JSC::CharacterClassConstructor::flush):
+ * wrec/CharacterClassConstructor.h:
+ (JSC::CharacterClassConstructor::flushBeforeEscapedHyphen):
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generateDisjunction):
+ (JSC::WRECParser::parseCharacterClass):
+ (JSC::WRECParser::parseDisjunction):
+ * wrec/WREC.h:
+
+2008-10-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - remove the "static" from declarations in a header file, since we
+ don't want them to have internal linkage
+
+ * VM/Machine.h: Remove the static keyword from the constant and the
+ three inline functions that Geoff just moved here.
+
+2008-10-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21283.
+ Profiler Crashes When Started
+
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ (JSC::makeHostCallFramePointer):
+ (JSC::isHostCallFrame):
+ (JSC::stripHostCallFrameBit): Moved some things to the header so
+ JSGlobalObject could use them.
+
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Call the
+ new makeHostCallFramePointer API, since 0 no longer indicates a host
+ call frame.
+
+2008-10-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21304
+ Stop using a static wrapper map for WebCore JS bindings
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ (JSC::JSGlobalData::~JSGlobalData):
+ (JSC::JSGlobalData::ClientData::~ClientData):
+ * kjs/JSGlobalData.h:
+ Added a client data member to JSGlobalData. WebCore will use it to store bindings-related
+ global data.
+
+ * JavaScriptCore.exp: Export virtual ClientData destructor.
+
+2008-10-02 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * kjs/Error.h:
+
+2008-10-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler and Cameron Zwarich.
+
+ Preliminary step toward dynamic recompilation: Standardized and
+ simplified the parsing interface.
+
+ The main goal in this patch is to make it easy to ask for a duplicate
+ compilation, and get back a duplicate result -- same source URL, same
+ debugger / profiler ID, same toString behavior, etc.
+
+ The basic unit of compilation and evaluation is now SourceCode, which
+ encompasses a SourceProvider, a range in that provider, and a starting
+ line number.
+
+ A SourceProvider now encompasses a source URL, and *is* a source ID,
+ since a pointer is a unique identifier.
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax): Provide a SourceCode to the Interpreter, since
+ other APIs are no longer supported.
+
+ * VM/CodeBlock.h:
+ (JSC::EvalCodeCache::get): Provide a SourceCode to the Interpreter, since
+ other APIs are no longer supported.
+ (JSC::CodeBlock::CodeBlock): ASSERT something that used to be ASSERTed
+ by our caller -- this is a better bottleneck.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator): Updated for the fact that
+ FunctionBodyNode's parameters are no longer a WTF::Vector.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::Arguments): ditto
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate): Provide a SourceCode to the Parser,
+ since other APIs are no longer supported.
+
+ * kjs/FunctionConstructor.cpp:
+ (JSC::constructFunction): Provide a SourceCode to the Parser, since
+ other APIs are no longer supported. Adopt FunctionBodyNode's new
+ "finishParsing" API.
+
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::lengthGetter):
+ (JSC::JSFunction::getParameterName): Updated for the fact that
+ FunctionBodyNode's parameters are no longer a wtf::Vector.
+
+ * kjs/JSFunction.h: Nixed some cruft.
+
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncEval): Provide a SourceCode to the Parser, since
+ other APIs are no longer supported.
+
+ * kjs/Parser.cpp:
+ (JSC::Parser::parse): Require a SourceCode argument, instead of a bunch
+ of broken out parameters. Stop tracking sourceId as an integer, since we
+ use the SourceProvider pointer for this now. Don't clamp the
+ startingLineNumber, since SourceCode does that now.
+
+ * kjs/Parser.h:
+ (JSC::Parser::parse): Standardized the parsing interface to require a
+ SourceCode.
+
+ * kjs/Shell.cpp:
+ (functionRun):
+ (functionLoad):
+ (prettyPrintScript):
+ (runWithScripts):
+ (runInteractive): Provide a SourceCode to the Interpreter, since
+ other APIs are no longer supported.
+
+ * kjs/SourceProvider.h:
+ (JSC::SourceProvider::SourceProvider):
+ (JSC::SourceProvider::url):
+ (JSC::SourceProvider::asId):
+ (JSC::UStringSourceProvider::create):
+ (JSC::UStringSourceProvider::UStringSourceProvider): Added new
+ responsibilities described above.
+
+ * kjs/SourceRange.h:
+ (JSC::SourceCode::SourceCode):
+ (JSC::SourceCode::toString):
+ (JSC::SourceCode::provider):
+ (JSC::SourceCode::firstLine):
+ (JSC::SourceCode::data):
+ (JSC::SourceCode::length): Added new responsibilities described above.
+ Renamed SourceRange to SourceCode, based on review feedback. Added
+ a makeSource function for convenience.
+
+ * kjs/debugger.h: Provide a SourceCode to the client, since other APIs
+ are no longer supported.
+
+ * kjs/grammar.y: Provide startingLineNumber when creating a SourceCode.
+
+ * kjs/debugger.h: Treat sourceId as intptr_t to avoid loss of precision
+ on 64bit platforms.
+
+ * kjs/interpreter.cpp:
+ (JSC::Interpreter::checkSyntax):
+ (JSC::Interpreter::evaluate):
+ * kjs/interpreter.h: Require a SourceCode instead of broken out arguments.
+
+ * kjs/lexer.cpp:
+ (JSC::Lexer::setCode):
+ * kjs/lexer.h:
+ (JSC::Lexer::sourceRange): Fold together the SourceProvider and line number
+ into a SourceCode. Fixed a bug where the Lexer would accidentally keep
+ alive the last SourceProvider forever.
+
+ * kjs/nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+ (JSC::ProgramNode::ProgramNode):
+ (JSC::ProgramNode::create):
+ (JSC::EvalNode::EvalNode):
+ (JSC::EvalNode::generateCode):
+ (JSC::EvalNode::create):
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::finishParsing):
+ (JSC::FunctionBodyNode::create):
+ (JSC::FunctionBodyNode::generateCode):
+ (JSC::ProgramNode::generateCode):
+ (JSC::FunctionBodyNode::paramString):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::):
+ (JSC::ScopeNode::sourceId):
+ (JSC::FunctionBodyNode::):
+ (JSC::FunctionBodyNode::parameterCount):
+ (JSC::FuncExprNode::):
+ (JSC::FuncDeclNode::): Store a SourceCode in all ScopeNodes, since
+ SourceCode is now responsible for tracking URL, ID, etc. Streamlined
+ some ad hoc FunctionBodyNode fixups into a "finishParsing" function, to
+ help make clear what you need to do in order to finish parsing a
+ FunctionBodyNode.
+
+ * wtf/Vector.h:
+ (WTF::::releaseBuffer): Don't ASSERT that releaseBuffer() is only called
+ when buffer is not 0, since FunctionBodyNode is more than happy
+ to get back a 0 buffer, and other functions like RefPtr::release() allow
+ for 0, too.
+
+2008-10-01 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21289: REGRESSION (r37160): Inspector crashes on load
+ <https://bugs.webkit.org/show_bug.cgi?id=21289>
+
+ The code in Arguments::mark() in r37160 was wrong. It marks indices in
+ d->registers, but that makes no sense (they are local variables, not
+ arguments). It should mark those indices in d->registerArray instead.
+
+ This patch also changes Arguments::copyRegisters() to use d->numParameters
+ instead of recomputing it.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::mark):
+ * kjs/Arguments.h:
+ (JSC::Arguments::copyRegisters):
+
+2008-09-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21214
+ work on getting rid of ExecState
+
+ Eliminate some unneeded uses of dynamicGlobalObject.
+
+ * API/JSClassRef.cpp:
+ (OpaqueJSClass::contextData): Changed to use a map in the global data instead
+ of on the global object. Also fixed to use only a single hash table lookup.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeConstructor): Use lexicalGlobalObject rather than dynamicGlobalObject
+ to get the object prototype.
+
+ * kjs/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncToString): Use arrayVisitedElements set in global data rather
+ than in the global object.
+ (JSC::arrayProtoFuncToLocaleString): Ditto.
+ (JSC::arrayProtoFuncJoin): Ditto.
+
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData): Don't initialize opaqueJSClassData, since
+ it's no longer a pointer.
+ (JSC::JSGlobalData::~JSGlobalData): We still need to delete all the values, but
+ we don't need to delete the map since it's no longer a pointer.
+
+ * kjs/JSGlobalData.h: Made opaqueJSClassData a map instead of a pointer to a map.
+ Also added arrayVisitedElements.
+
+ * kjs/JSGlobalObject.h: Removed arrayVisitedElements.
+
+ * kjs/Shell.cpp:
+ (functionRun): Use lexicalGlobalObject instead of dynamicGlobalObject.
+ (functionLoad): Ditto.
+
+2008-10-01 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculative Windows build fix.
+
+ * kjs/grammar.y:
+
+2008-10-01 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 21123: using "arguments" in a function should not force creation of an activation object
+ <https://bugs.webkit.org/show_bug.cgi?id=21123>
+
+ Make the 'arguments' object not require a JSActivation. We store the
+ 'arguments' object in the OptionalCalleeArguments call frame slot. We
+ need to be able to get the original 'arguments' object to tear it off
+ when returning from a function, but 'arguments' may be assigned to in a
+ number of ways.
+
+ Therefore, we use the OptionalCalleeArguments slot when we want to get
+ the original activation or we know that 'arguments' was not assigned a
+ different value. When 'arguments' may have been assigned a new value,
+ we use a new local variable that is initialized with 'arguments'. Since
+ a function parameter named 'arguments' may overwrite the value of
+ 'arguments', we also need to be careful to look up 'arguments' in the
+ symbol table, so we get the parameter named 'arguments' instead of the
+ local variable that we have added for holding the 'arguments' object.
+
+ This is a 19.1% win on the V8 Raytrace benchmark using the SunSpider
+ harness, and a 20.7% win using the V8 harness. This amounts to a 6.5%
+ total speedup on the V8 benchmark suite using the V8 harness.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ * VM/Machine.cpp:
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::cti_op_init_arguments):
+ (JSC::Machine::cti_op_ret_activation_arguments):
+ * VM/Machine.h:
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::):
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::mark):
+ (JSC::Arguments::fillArgList):
+ (JSC::Arguments::getOwnPropertySlot):
+ (JSC::Arguments::put):
+ * kjs/Arguments.h:
+ (JSC::Arguments::setRegisters):
+ (JSC::Arguments::init):
+ (JSC::Arguments::Arguments):
+ (JSC::Arguments::copyRegisters):
+ (JSC::JSActivation::copyRegisters):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::argumentsGetter):
+ * kjs/JSActivation.h:
+ (JSC::JSActivation::JSActivationData::JSActivationData):
+ * kjs/grammar.y:
+ * kjs/nodes.h:
+ (JSC::ScopeNode::setUsesArguments):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::orl_mr):
+
+2008-10-01 Kevin McCullough <kmccullough@apple.com>
+
+ Rubberstamped by Geoff Garen.
+
+ Remove BreakpointCheckStatement because it's not used anymore.
+ No effect on sunspider or the jsc tests.
+
+ * kjs/nodes.cpp:
+ * kjs/nodes.h:
+
+2008-09-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Improve performance of CTI on windows.
+
+ Currently on platforms where the compiler doesn't allow us to safely
+ index relative to the address of a parameter we need to actually
+ provide a pointer to CTI runtime call arguments. This patch improves
+ performance in this case by making the CTI logic for restoring this
+ parameter much less conservative by only resetting it before we actually
+ make a call, rather than between each and every SF bytecode we generate
+ code for.
+
+ This results in a 3.6% progression on the v8 benchmark when compiled with MSVC.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCall):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ * VM/CTI.h:
+ * masm/X86Assembler.h:
+ * wtf/Platform.h:
+
+2008-09-30 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - track uses of "this", "with" and "catch" in the parser
+
+ Knowing this up front will be useful for future optimizations.
+
+ Perf and correctness remain the same.
+
+ * kjs/NodeInfo.h:
+ * kjs/grammar.y:
+
+2008-09-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Add WebKitAvailability macros for JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError,
+ and JSObjectMakeRegExp
+
+ * API/JSObjectRef.h:
+
+2008-09-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21214
+ work on getting rid of ExecState
+
+ Replaced the m_prev field of ExecState with a bit in the
+ call frame pointer to indicate "host" call frames.
+
+ * VM/Machine.cpp:
+ (JSC::makeHostCallFramePointer): Added. Sets low bit.
+ (JSC::isHostCallFrame): Added. Checks low bit.
+ (JSC::stripHostCallFrameBit): Added. Clears low bit.
+ (JSC::Machine::unwindCallFrame): Replaced null check that was
+ formerly used to detect host call frames with an isHostCallFrame check.
+ (JSC::Machine::execute): Pass in a host call frame pointer rather than
+ always passing 0 when starting execution from the host. This allows us
+ to follow the entire call frame pointer chain when desired, or to stop
+ at the host calls when that's desired.
+ (JSC::Machine::privateExecute): Replaced null check that was
+ formerly used to detect host call frames with an isHostCallFrame check.
+ (JSC::Machine::retrieveCaller): Ditto.
+ (JSC::Machine::retrieveLastCaller): Ditto.
+ (JSC::Machine::callFrame): Removed the code to walk up m_prev pointers
+ and replaced it with code that uses the caller pointer and uses the
+ stripHostCallFrameBit function.
+
+ * kjs/ExecState.cpp: Removed m_prev.
+ * kjs/ExecState.h: Ditto.
+
+2008-09-30 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Move all detection of 'arguments' in a lexical scope to the parser, in
+ preparation for fixing
+
+ Bug 21123: using "arguments" in a function should not force creation of an activation object
+ <https://bugs.webkit.org/show_bug.cgi?id=21123>
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ * kjs/NodeInfo.h:
+ * kjs/grammar.y:
+
+2008-09-30 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ * kjs/Shell.cpp:
+ (runWithScripts): Fixed indentation.
+
+2008-09-30 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Build fix. Move InternalFunction::classInfo implementation into the .cpp
+ file to prevent the vtable for InternalFunction being generated as a weak symbol.
+ Has no effect on SunSpider.
+
+ * kjs/InternalFunction.cpp:
+ (JSC::InternalFunction::classInfo):
+ * kjs/InternalFunction.h:
+
+2008-09-29 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - optimize appending a number to a string
+ https://bugs.webkit.org/show_bug.cgi?id=21203
+
+ It's pretty common in real-world code (and on some of the v8
+ benchmarks) to append a number to a string, so I made this one of
+ the fast cases, and also added support to UString to do it
+ directly without allocating a temporary UString.
+
+ ~1% speedup on v8 benchmark.
+
+ * VM/Machine.cpp:
+ (JSC::jsAddSlowCase): Make this NEVER_INLINE because somehow otherwise
+ the change is a regression.
+ (JSC::jsAdd): Handle number + string special case.
+ (JSC::Machine::cti_op_add): Integrate much of the logic of jsAdd to
+ avoid exception check in the str + str, num + num and str + num cases.
+ * kjs/ustring.cpp:
+ (JSC::expandedSize): Make this a non-member function, since it needs to be
+ called in non-member functions but not outside this file.
+ (JSC::expandCapacity): Ditto.
+ (JSC::UString::expandCapacity): Call the non-member version.
+ (JSC::createRep): Helper to make a rep from a char*.
+ (JSC::UString::UString): Use above helper.
+ (JSC::concatenate): Guts of concatenating constructor for cases where first
+ item is a UString::Rep, and second is a UChar* and length, or a char*.
+ (JSC::UString::append): Implement for cases where first item is a UString::Rep,
+ and second is an int or double. Sadly duplicates logic of UString::from(int)
+ and UString::from(double).
+ * kjs/ustring.h:
+
+2008-09-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21214
+ work on getting rid of ExecState
+
+ * JavaScriptCore.exp: Updated since JSGlobalObject::init
+ no longer takes a parameter.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::execute): Removed m_registerFile argument
+ for ExecState constructors.
+
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue
+ argument for ExecState constructor.
+
+ * kjs/ExecState.cpp:
+ (JSC::ExecState::ExecState): Removed globalThisValue and
+ registerFile arguments to constructors.
+
+ * kjs/ExecState.h: Removed m_globalThisValue and
+ m_registerFile data members.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init): Removed globalThisValue
+ argument for ExecState constructor.
+
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter
+ for the init function.
+
+2008-09-29 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber-stamped by Cameron Zwarich.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21225
+ Machine::retrieveLastCaller should check for a NULL codeBlock
+
+ In order to crash, you would need to call retrieveCaller in a situation
+ where you had two host call frames in a row in the register file. I
+ don't know how to make that happen, or if it's even possible, so I don't
+ have a test case -- but better safe than sorry!
+
+ * VM/Machine.cpp:
+ (JSC::Machine::retrieveLastCaller):
+
+2008-09-29 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Store the callee ScopeChain, not the caller ScopeChain, in the call frame
+ header. Nix the "scopeChain" local variable and ExecState::m_scopeChain, and
+ access the callee ScopeChain through the call frame header instead.
+
+ Profit: call + return are simpler, because they don't have to update the
+ "scopeChain" local variable, or ExecState::m_scopeChain.
+
+ Because CTI keeps "r" in a register, reading the callee ScopeChain relative
+ to "r" can be very fast, in any cases we care to optimize.
+
+ 0% speedup on empty function call benchmark. (5.5% speedup in bytecode.)
+ 0% speedup on SunSpider. (7.5% speedup on controlflow-recursive.)
+ 2% speedup on SunSpider --v8.
+ 2% speedup on v8 benchmark.
+
+ * VM/CTI.cpp: Changed scope chain access to read the scope chain from
+ the call frame header. Sped up op_ret by changing it not to fuss with
+ the "scopeChain" local variable or ExecState::m_scopeChain.
+
+ * VM/CTI.h: Updated CTI trampolines not to take a ScopeChainNode*
+ argument, since that's stored in the call frame header now.
+
+ * VM/Machine.cpp: Access "scopeChain" and "codeBlock" through new helper
+ functions that read from the call frame header. Updated functions operating
+ on ExecState::m_callFrame to account for / take advantage of the fact that
+ Exec:m_callFrame is now never NULL.
+
+ Fixed a bug in op_construct, where it would use the caller's default
+ object prototype, rather than the callee's, when constructing a new object.
+
+ * VM/Machine.h: Made some helper functions available. Removed
+ ScopeChainNode* arguments to a lot of functions, since the ScopeChainNode*
+ is now stored in the call frame header.
+
+ * VM/RegisterFile.h: Renamed "CallerScopeChain" to "ScopeChain", since
+ that's what it is now.
+
+ * kjs/DebuggerCallFrame.cpp: Updated for change to ExecState signature.
+
+ * kjs/ExecState.cpp:
+ * kjs/ExecState.h: Nixed ExecState::m_callFrame, along with the unused
+ isGlobalObject function.
+
+ * kjs/JSGlobalObject.cpp:
+ * kjs/JSGlobalObject.h: Gave the global object a fake call frame in
+ which to store the global scope chain, since our code now assumes that
+ it can always read the scope chain out of the ExecState's call frame.
+
+2008-09-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Sam Weinig.
+
+ Remove the isActivationObject() virtual method on JSObject and use
+ StructureID information instead. This should be slightly faster, but
+ isActivationObject() is only used in assertions and unwinding the stack
+ for exceptions.
+
+ * VM/Machine.cpp:
+ (JSC::depth):
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_ret_activation):
+ * kjs/JSActivation.cpp:
+ * kjs/JSActivation.h:
+ * kjs/JSObject.h:
+
+2008-09-29 Peter Gal <galpeter@inf.u-szeged.hu>
+
+ Reviewed and tweaked by Darin Adler.
+
+ Fix build for non-all-in-one platforms.
+
+ * kjs/StringPrototype.cpp: Added missing ASCIICType.h include.
+
+2008-09-29 Bradley T. Hughes <bradley.hughes@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix compilation with icpc
+
+ * wtf/HashSet.h:
+ (WTF::::find):
+ (WTF::::contains):
+
+2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Changed copyright from Trolltech ASA to Nokia.
+
+ Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
+
+
+ * wtf/qt/MainThreadQt.cpp:
+
+2008-09-29 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Lars Knoll.
+
+ Don't accidentially install libJavaScriptCore.a for the build inside
+ Qt.
+
+ * JavaScriptCore.pro:
+
+2008-09-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21200: Allow direct access to 'arguments' without using op_resolve
+ <https://bugs.webkit.org/show_bug.cgi?id=21200>
+
+ Allow fast access to the 'arguments' object by adding an extra slot to
+ the callframe to store it.
+
+ This is a 3.0% speedup on the V8 Raytrace benchmark.
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::registerFor):
+ * VM/CodeGenerator.h:
+ (JSC::CodeGenerator::registerFor):
+ * VM/Machine.cpp:
+ (JSC::Machine::initializeCallFrame):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_create_arguments):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::mark):
+ (JSC::JSActivation::argumentsGetter):
+ * kjs/JSActivation.h:
+ (JSC::JSActivation::JSActivationData::JSActivationData):
+ * kjs/NodeInfo.h:
+ * kjs/Parser.cpp:
+ (JSC::Parser::didFinishParsing):
+ * kjs/Parser.h:
+ (JSC::Parser::parse):
+ * kjs/grammar.y:
+ * kjs/nodes.cpp:
+ (JSC::ScopeNode::ScopeNode):
+ (JSC::ProgramNode::ProgramNode):
+ (JSC::ProgramNode::create):
+ (JSC::EvalNode::EvalNode):
+ (JSC::EvalNode::create):
+ (JSC::FunctionBodyNode::FunctionBodyNode):
+ (JSC::FunctionBodyNode::create):
+ * kjs/nodes.h:
+ (JSC::ScopeNode::usesArguments):
+
+2008-09-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add an ASCII fast-path to toLowerCase and toUpperCase.
+
+ The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
+ to the less common non-ASCII case.
+
+ This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
+ to the non-locale variants of the functions. toLocaleLowerCase and toLocaleUpperCase now use the non-locale
+ variants of the functions directly.
+
+ * kjs/StringPrototype.cpp:
+ (JSC::stringProtoFuncToLowerCase):
+ (JSC::stringProtoFuncToUpperCase):
+
+2008-09-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Speed up parseInt and parseFloat.
+
+ Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
+ and use that instead. This is a 7% win on a parseInt/parseFloat micro-benchmark.
+
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::parseInt):
+ (JSC::parseFloat):
+
+2008-09-28 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ In Qt's initializeThreading re-use an existing thread identifier for the main
+ thread if it exists.
+
+ currentThread() implicitly creates new identifiers and it could be that
+ it is called before initializeThreading().
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::initializeThreading):
+
+2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
+
+ Added Machine::retrieveCaller to the export list.
+
+ Reviewed by Kevin McCullough and Tim Hatcher.
+
+ * JavaScriptCore.exp: Added Machine::retrieveCaller.
+
+2008-09-27 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * VM/CTI.cpp:
+ (JSC::):
+
+2008-09-27 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21175
+
+ Store the callee CodeBlock, not the caller CodeBlock, in the call frame
+ header. Nix the "codeBlock" local variable, and access the callee
+ CodeBlock through the call frame header instead.
+
+ Profit: call + return are simpler, because they don't have to update the
+ "codeBlock" local variable.
+
+ Because CTI keeps "r" in a register, reading the callee CodeBlock relative
+ to "r" can be very fast, in any cases we care to optimize. Presently,
+ no such cases seem important.
+
+ Also, stop writing "dst" to the call frame header. CTI doesn't use it.
+
+ 21.6% speedup on empty function call benchmark.
+ 3.8% speedup on SunSpider --v8.
+ 2.1% speedup on v8 benchmark.
+ 0.7% speedup on SunSpider (6% speedup on controlflow-recursive).
+
+ Small regression in bytecode, because currently every op_ret reads the
+ callee CodeBlock to check needsFullScopeChain, and bytecode does not
+ keep "r" in a register. On-balance, this is probably OK, since CTI is
+ our high-performance execution model. Also, this should go away once
+ we make needsFullScopeChain statically determinable at parse time.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall): The speedup!
+ (JSC::CTI::privateCompileSlowCases): ditto
+
+ * VM/CTI.h:
+ (JSC::): Fixed up magic trampoline constants to account for the nixed
+ "codeBlock" argument.
+ (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock"
+ argument, since codeBlock is now stored in the call frame header.
+
+ * VM/Machine.cpp: Read the callee CodeBlock from the register file. Use
+ a NULL CallerRegisters in the call frame header to signal a built-in
+ caller, since CodeBlock is now never NULL.
+
+ * VM/Machine.h: Made some stand-alone functions Machine member functions
+ so they could call the private codeBlock() accessor in the Register
+ class, of which Machine is a friend. Renamed "CallerCodeBlock" to
+ "CodeBlock", since it's no longer the caller's CodeBlock.
+
+ * VM/RegisterFile.h: Marked some methods const to accommodate a
+ const RegisterFile* being passed around in Machine.cpp.
+
+2008-09-26 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix. Not reviewed.
+
+ Narrow-down the target of the JavaScriptCore .lut.h generator so
+ it won't try to create the WebCore .lut.hs.
+
+ * GNUmakefile.am:
+
+2008-09-26 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
+
+ * Configurations/JavaScriptCore.xcconfig:
+
+2008-09-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Anders Carlson.
+
+ Change the name 'sc' to 'scopeChainNode' in a few places.
+
+ * kjs/nodes.cpp:
+ (JSC::EvalNode::generateCode):
+ (JSC::FunctionBodyNode::generateCode):
+ (JSC::ProgramNode::generateCode):
+
+2008-09-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
+ Speedup static property get/put
+
+ Convert getting/setting static property values to use static functions
+ instead of storing an integer and switching in getValueProperty/putValueProperty.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::deleteProperty):
+ (JSC::JSObject::getPropertyAttributes):
+ * kjs/MathObject.cpp:
+ (JSC::MathObject::getOwnPropertySlot):
+ * kjs/NumberConstructor.cpp:
+ (JSC::numberConstructorNaNValue):
+ (JSC::numberConstructorNegInfinity):
+ (JSC::numberConstructorPosInfinity):
+ (JSC::numberConstructorMaxValue):
+ (JSC::numberConstructorMinValue):
+ * kjs/PropertySlot.h:
+ (JSC::PropertySlot::):
+ * kjs/RegExpConstructor.cpp:
+ (JSC::regExpConstructorDollar1):
+ (JSC::regExpConstructorDollar2):
+ (JSC::regExpConstructorDollar3):
+ (JSC::regExpConstructorDollar4):
+ (JSC::regExpConstructorDollar5):
+ (JSC::regExpConstructorDollar6):
+ (JSC::regExpConstructorDollar7):
+ (JSC::regExpConstructorDollar8):
+ (JSC::regExpConstructorDollar9):
+ (JSC::regExpConstructorInput):
+ (JSC::regExpConstructorMultiline):
+ (JSC::regExpConstructorLastMatch):
+ (JSC::regExpConstructorLastParen):
+ (JSC::regExpConstructorLeftContext):
+ (JSC::regExpConstructorRightContext):
+ (JSC::setRegExpConstructorInput):
+ (JSC::setRegExpConstructorMultiline):
+ (JSC::RegExpConstructor::setInput):
+ (JSC::RegExpConstructor::setMultiline):
+ (JSC::RegExpConstructor::multiline):
+ * kjs/RegExpConstructor.h:
+ * kjs/RegExpObject.cpp:
+ (JSC::regExpObjectGlobal):
+ (JSC::regExpObjectIgnoreCase):
+ (JSC::regExpObjectMultiline):
+ (JSC::regExpObjectSource):
+ (JSC::regExpObjectLastIndex):
+ (JSC::setRegExpObjectLastIndex):
+ * kjs/RegExpObject.h:
+ (JSC::RegExpObject::setLastIndex):
+ (JSC::RegExpObject::lastIndex):
+ (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames):
+ * kjs/create_hash_table:
+ * kjs/lexer.cpp:
+ (JSC::Lexer::lex):
+ * kjs/lookup.cpp:
+ (JSC::HashTable::createTable):
+ (JSC::HashTable::deleteTable):
+ (JSC::setUpStaticFunctionSlot):
+ * kjs/lookup.h:
+ (JSC::HashEntry::initialize):
+ (JSC::HashEntry::setKey):
+ (JSC::HashEntry::key):
+ (JSC::HashEntry::attributes):
+ (JSC::HashEntry::function):
+ (JSC::HashEntry::functionLength):
+ (JSC::HashEntry::propertyGetter):
+ (JSC::HashEntry::propertyPutter):
+ (JSC::HashEntry::lexerValue):
+ (JSC::HashEntry::):
+ (JSC::HashTable::entry):
+ (JSC::getStaticPropertySlot):
+ (JSC::getStaticValueSlot):
+ (JSC::lookupPut):
+
+2008-09-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak & Oliver Hunt.
+
+ Add support for reusing temporary JSNumberCells. This change is based on the observation
+ that if the result of certain operations is a JSNumberCell and is consumed by a subsequent
+ operation that would produce a JSNumberCell, we can reuse the object rather than allocating
+ a fresh one. E.g. given the expression ((a * b) * c), we can statically determine that
+ (a * b) will have a numeric result (or else it will have thrown an exception), so the result
+ will either be a JSNumberCell or a JSImmediate.
+
+ This patch changes three areas of JSC:
+ * The AST now tracks type information about the result of each node.
+ * This information is consumed in bytecode compilation, and certain bytecode operations
+ now carry the statically determined type information about their operands.
+ * CTI uses the information in a number of fashions:
+ * Where an operand to certain arithmetic operations is reusable, it will plant code
+ to try to perform the operation in JIT code & reuse the cell, where appropriate.
+ * Where it can be statically determined that an operand can only be numeric (typically
+ the result of another arithmetic operation) the code will not redundantly check that
+ the JSCell is a JSNumberCell.
+ * Where either of the operands to an add are non-numeric do not plant an optimized
+ arithmetic code path, just call straight out to the C function.
+
+ +6% Sunspider (10% progression on 3D, 16% progression on math, 60% progression on access-nbody),
+ +1% v8-tests (improvements in raytrace & crypto)
+
+ * VM/CTI.cpp: Add optimized code generation with reuse of temporary JSNumberCells.
+ * VM/CTI.h:
+ * kjs/JSNumberCell.h:
+ * masm/X86Assembler.h:
+
+ * VM/CodeBlock.cpp: Add type information to specific bytecodes.
+ * VM/CodeGenerator.cpp:
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+
+ * kjs/nodes.cpp: Track static type information for nodes.
+ * kjs/nodes.h:
+ * kjs/ResultDescriptor.h: (Added)
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-09-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by George Staikos, Maciej Stachowiak.
+
+ Add utility functions needed for upcoming WML code.
+
+ * wtf/ASCIICType.h:
+ (WTF::isASCIIPrintable):
+
+2008-09-26 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Reverted the part of r36614 that used static data because static data
+ is not thread-safe.
+
+2008-09-26 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Removed dynamic check for whether the callee needs an activation object.
+ Replaced with callee code to create the activation object.
+
+ 0.5% speedup on SunSpider.
+ No change on v8 benchmark. (Might be a speedup, but it's in range of the
+ variance.)
+
+ 0.7% speedup on v8 benchmark in bytecode.
+ 1.3% speedup on empty call benchmark in bytecode.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass): Added support for op_init_activation,
+ the new opcode that specifies that the callee's initialization should
+ create an activation object.
+ (JSC::CTI::privateCompile): Removed previous code that did a similar
+ thing in an ad-hoc way.
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Added a case for dumping op_init_activation.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::generate): Added fixup code to change op_init to
+ op_init_activation if necessary. (With a better parser, we would know
+ which to use from the beginning.)
+
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+ (WTF::): Faster traits for the instruction vector. An earlier version
+ of this patch relied on inserting at the beginning of the vector, and
+ depended on this change for speed.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::execute): Removed clients of setScopeChain, the old
+ abstraction for dynamically checking for whether an activation object
+ needed to be created.
+ (JSC::Machine::privateExecute): ditto
+
+ (JSC::Machine::cti_op_push_activation): Renamed this function from
+ cti_vm_updateScopeChain, and made it faster by removing the call to
+ setScopeChain.
+ * VM/Machine.h:
+
+ * VM/Opcode.h: Declared op_init_activation.
+
+2008-09-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Move most of the return code back into the callee, now that the callee
+ doesn't have to calculate anything dynamically.
+
+ 11.5% speedup on empty function call benchmark.
+
+ SunSpider says 0.3% faster. SunSpider --v8 says no change.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+
+2008-09-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove staticFunctionGetter. There is only one remaining user of
+ staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
+
+ * JavaScriptCore.exp:
+ * kjs/lookup.cpp:
+ * kjs/lookup.h:
+
+2008-09-24 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - inline JIT fast case of op_neq
+ - remove extra level of function call indirection from slow cases of eq and neq
+
+ 1% speedup on Richards
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_eq):
+ (JSC::Machine::cti_op_neq):
+ * kjs/operations.cpp:
+ (JSC::equal):
+ (JSC::equalSlowCase):
+ * kjs/operations.h:
+ (JSC::equalSlowCaseInline):
+
+2008-09-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
+ <rdar://problem/6243534>
+ Crash below Function.apply when using a runtime array as the argument list
+
+ Test: plugins/bindings-array-apply-crash.html
+
+ * kjs/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply): Revert to the slow case if the object inherits from
+ JSArray (via ClassInfo) but is not a JSArray.
+
+2008-09-24 Kevin McCullough <kmccullough@apple.com>
+
+ Style change.
+
+ * kjs/nodes.cpp:
+ (JSC::statementListEmitCode):
+
+2008-09-24 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff.
+
+ Bug 21031: Breakpoints in the condition of loops only breaks the first
+ time
+ - Now when setting breakpoints in the condition of a loop (for, while,
+ for in, and do while) will successfully break each time throught the
+ loop.
+ - For 'for' loops we need a little more complicated behavior that cannot
+ be accomplished without some more significant changes:
+ https://bugs.webkit.org/show_bug.cgi?id=21073
+
+ * kjs/nodes.cpp:
+ (JSC::statementListEmitCode): We don't want to blindly emit a debug hook
+ at the first line of loops, instead let the loop emit the debug hooks.
+ (JSC::DoWhileNode::emitCode):
+ (JSC::WhileNode::emitCode):
+ (JSC::ForNode::emitCode):
+ (JSC::ForInNode::emitCode):
+ * kjs/nodes.h:
+ (JSC::StatementNode::):
+ (JSC::DoWhileNode::):
+ (JSC::WhileNode::):
+ (JSC::ForInNode::):
+
+2008-09-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed <rdar://problem/5605532> Need a SPI for telling JS the size of
+ the objects it retains
+
+ * API/tests/testapi.c: Test the new SPI a little.
+
+ * API/JSSPI.cpp: Add the new SPI.
+ * API/JSSPI.h: Add the new SPI.
+ * JavaScriptCore.exp: Add the new SPI.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Add the new SPI.
+
+2008-09-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * API/JSBase.h: Filled in some missing function names.
+
+2008-09-24 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21057
+ Crash in RegisterID::deref() running fast/canvas/canvas-putImageData.html
+
+ * VM/CodeGenerator.h: Changed declaration order to ensure the
+ m_lastConstant, which is a RefPtr that points into m_calleeRegisters,
+ has its destructor called before the destructor for m_calleeRegisters.
+
+2008-09-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21047
+ speed up ret_activation with inlining
+
+ About 1% on v8-raytrace.
+
+ * JavaScriptCore.exp: Removed JSVariableObject::setRegisters.
+
+ * kjs/JSActivation.cpp: Moved copyRegisters to the header to make it inline.
+ * kjs/JSActivation.h:
+ (JSC::JSActivation::copyRegisters): Moved here. Also removed the registerArraySize
+ argument to setRegisters, since the object doesn't need to store the number of
+ registers.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset): Removed unnecessary clearing left over from when we
+ used this on objects that weren't brand new. These days, this function is really
+ just part of the constructor.
+
+ * kjs/JSGlobalObject.h: Added registerArraySize to JSGlobalObjectData, since
+ JSVariableObjectData no longer needs it. Added a setRegisters override here
+ that handles storing the size.
+
+ * kjs/JSStaticScopeObject.h: Removed code to set registerArraySize, since it
+ no longer exists.
+
+ * kjs/JSVariableObject.cpp: Moved copyRegisterArray and setRegisters to the
+ header to make them inline.
+ * kjs/JSVariableObject.h: Removed registerArraySize from JSVariableObjectData,
+ since it was only used for the global object.
+ (JSC::JSVariableObject::copyRegisterArray): Moved here ot make it inline.
+ (JSC::JSVariableObject::setRegisters): Moved here to make it inline. Also
+ removed the code to set registerArraySize and changed an if statement into
+ an assert to save an unnnecessary branch.
+
+2008-09-24 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - inline PropertyMap::getOffset to speed up polymorphic lookups
+
+ ~1.5% speedup on v8 benchmark
+ no effect on SunSpider
+
+ * JavaScriptCore.exp:
+ * kjs/PropertyMap.cpp:
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMap::getOffset):
+
+2008-09-24 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20992
+ Build fails on GTK+ Mac OS
+
+ * wtf/ThreadingGtk.cpp: Remove platform ifdef as suggested by
+ Richard Hult.
+ (WTF::initializeThreading):
+
+2008-09-23 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 19968: Slow Script at www.huffingtonpost.com
+ <https://bugs.webkit.org/show_bug.cgi?id=19968>
+
+ Finally found the cause of this accursed issue. It is triggered
+ by synchronous creation of a new global object from JS. The new
+ global object resets the timer state in this execution group's
+ Machine, taking timerCheckCount to 0. Then when JS returns the
+ timerCheckCount is decremented making it non-zero. The next time
+ we execute JS we will start the timeout counter, however the non-zero
+ timeoutCheckCount means we don't reset the timer information. This
+ means that the timeout check is now checking the cumulative time
+ since the creation of the global object rather than the time since
+ JS was last entered. At this point the slow script dialog is guaranteed
+ to eventually be displayed incorrectly unless a page is loaded
+ asynchronously (which will reset everything into a sane state).
+
+ The fix for this is rather trivial -- the JSGlobalObject constructor
+ should not be resetting the machine timer state.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine):
+ Now that we can't rely on the GlobalObject initialising the timeout
+ state, we do it in the Machine constructor.
+
+ * VM/Machine.h:
+ (JSC::Machine::stopTimeoutCheck):
+ Add assertions to guard against this happening.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init):
+ Don't reset the timeout state.
+
+2008-09-23 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21038 | <rdar://problem/6240812>
+ Uncaught exceptions in regex replace callbacks crash webkit
+
+ This was a combination of two problems:
+
+ (1) the replace function would continue execution after an exception
+ had been thrown.
+
+ (2) In some cases, the Machine would return 0 in the case of an exception,
+ despite the fact that a few clients dereference the Machine's return
+ value without first checking for an exception.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::execute):
+
+ ^ Return jsNull() instead of 0 in the case of an exception, since some
+ clients depend on using our return value.
+
+ ^ ASSERT that execution does not continue after an exception has been
+ thrown, to help catch problems like this in the future.
+
+ * kjs/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplace):
+
+ ^ Stop execution if an exception has been thrown.
+
+2008-09-23 Geoffrey Garen <ggaren@apple.com>
+
+ Try to fix the windows build.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+
+2008-09-23 Alp Toker <alp@nuanti.com>
+
+ Build fix.
+
+ * VM/CTI.h:
+
+2008-09-23 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * wtf/Platform.h: Removed duplicate #if.
+
+2008-09-23 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Changed the layout of the call frame from
+
+ { header, parameters, locals | constants, temporaries }
+
+ to
+
+ { parameters, header | locals, constants, temporaries }
+
+ This simplifies function entry+exit, and enables a number of future
+ optimizations.
+
+ 13.5% speedup on empty call benchmark for bytecode; 23.6% speedup on
+ empty call benchmark for CTI.
+
+ SunSpider says no change. SunSpider --v8 says 1% faster.
+
+ * VM/CTI.cpp:
+
+ Added a bit of abstraction for calculating whether a register is a
+ constant, since this patch changes that calculation:
+ (JSC::CTI::isConstant):
+ (JSC::CTI::getConstant):
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::getConstantImmediateNumericArg):
+
+ Updated for changes to callframe header location:
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::printOpcodeOperandTypes):
+
+ Renamed to spite Oliver:
+ (JSC::CTI::emitInitRegister):
+
+ Added an abstraction for emitting a call through a register, so that
+ calls through registers generate exception info, too:
+ (JSC::CTI::emitCall):
+
+ Updated to match the new callframe header layout, and to support calls
+ through registers, which have no destination address:
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+
+ * VM/CTI.h:
+
+ More of the above:
+ (JSC::CallRecord::CallRecord):
+
+ * VM/CodeBlock.cpp:
+
+ Updated for new register layout:
+ (JSC::registerName):
+ (JSC::CodeBlock::dump):
+
+ * VM/CodeBlock.h:
+
+ Updated CodeBlock to track slightly different information about the
+ register frame, and tweaked the style of an ASSERT_NOT_REACHED.
+ (JSC::CodeBlock::CodeBlock):
+ (JSC::CodeBlock::getStubInfo):
+
+ * VM/CodeGenerator.cpp:
+
+ Added some abstraction around constant register allocation, since this
+ patch changes it, changed codegen to account for the new callframe
+ layout, and added abstraction around register fetching code
+ that used to assume that all local registers lived at negative indices,
+ since vars now live at positive indices:
+ (JSC::CodeGenerator::generate):
+ (JSC::CodeGenerator::addVar):
+ (JSC::CodeGenerator::addGlobalVar):
+ (JSC::CodeGenerator::allocateConstants):
+ (JSC::CodeGenerator::CodeGenerator):
+ (JSC::CodeGenerator::addParameter):
+ (JSC::CodeGenerator::registerFor):
+ (JSC::CodeGenerator::constRegisterFor):
+ (JSC::CodeGenerator::newRegister):
+ (JSC::CodeGenerator::newTemporary):
+ (JSC::CodeGenerator::highestUsedRegister):
+ (JSC::CodeGenerator::addConstant):
+
+ ASSERT that our caller referenced the registers it passed to us.
+ Otherwise, we might overwrite them with parameters:
+ (JSC::CodeGenerator::emitCall):
+ (JSC::CodeGenerator::emitConstruct):
+
+ * VM/CodeGenerator.h:
+
+ Added some abstraction for getting a RegisterID for a given index,
+ since the rules are a little weird:
+ (JSC::CodeGenerator::registerFor):
+
+ * VM/Machine.cpp:
+
+ Utility function to transform a machine return PC to a virtual machine
+ return VPC, for the sake of stack unwinding, since both PCs are stored
+ in the same location now:
+ (JSC::vPCForPC):
+
+ Tweaked to account for new call frame:
+ (JSC::Machine::initializeCallFrame):
+
+ Tweaked to account for registerOffset supplied by caller:
+ (JSC::slideRegisterWindowForCall):
+
+ Tweaked to account for new register layout:
+ (JSC::scopeChainForCall):
+ (JSC::Machine::callEval):
+ (JSC::Machine::dumpRegisters):
+ (JSC::Machine::unwindCallFrame):
+ (JSC::Machine::execute):
+
+ Changed op_call and op_construct to implement the new calling convention:
+ (JSC::Machine::privateExecute):
+
+ Tweaked to account for the new register layout:
+ (JSC::Machine::retrieveArguments):
+ (JSC::Machine::retrieveCaller):
+ (JSC::Machine::retrieveLastCaller):
+ (JSC::Machine::callFrame):
+ (JSC::Machine::getArgumentsData):
+
+ Changed CTI call helpers to implement the new calling convention:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+ (JSC::Machine::cti_op_ret_activation):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+ (JSC::Machine::cti_op_call_eval):
+
+ * VM/Machine.h:
+
+ * VM/Opcode.h:
+
+ Renamed op_initialise_locals to op_init, because this opcode
+ doesn't initialize all locals, and it doesn't initialize only locals.
+ Also, to spite Oliver.
+
+ * VM/RegisterFile.h:
+
+ New call frame enumeration values:
+ (JSC::RegisterFile::):
+
+ Simplified the calculation of whether a RegisterID is a temporary,
+ since we can no longer assume that all positive non-constant registers
+ are temporaries:
+ * VM/RegisterID.h:
+ (JSC::RegisterID::RegisterID):
+ (JSC::RegisterID::setTemporary):
+ (JSC::RegisterID::isTemporary):
+
+ Renamed firstArgumentIndex to firstParameterIndex because the assumption
+ that this variable pertained to the actual arguments supplied by the
+ caller caused me to write some buggy code:
+ * kjs/Arguments.cpp:
+ (JSC::ArgumentsData::ArgumentsData):
+ (JSC::Arguments::Arguments):
+ (JSC::Arguments::fillArgList):
+ (JSC::Arguments::getOwnPropertySlot):
+ (JSC::Arguments::put):
+
+ Updated for new call frame layout:
+ * kjs/DebuggerCallFrame.cpp:
+ (JSC::DebuggerCallFrame::functionName):
+ (JSC::DebuggerCallFrame::type):
+ * kjs/DebuggerCallFrame.h:
+
+ Changed the activation object to account for the fact that a call frame
+ header now sits between parameters and local variables. This change
+ requires all variable objects to do their own marking, since they
+ now use their register storage differently:
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::mark):
+ (JSC::JSActivation::copyRegisters):
+ (JSC::JSActivation::createArgumentsObject):
+ * kjs/JSActivation.h:
+
+ Updated global object to use the new interfaces required by the change
+ to JSActivation above:
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ (JSC::JSGlobalObject::mark):
+ (JSC::JSGlobalObject::copyGlobalsFrom):
+ (JSC::JSGlobalObject::copyGlobalsTo):
+ * kjs/JSGlobalObject.h:
+ (JSC::JSGlobalObject::addStaticGlobals):
+
+ Updated static scope object to use the new interfaces required by the
+ change to JSActivation above:
+ * kjs/JSStaticScopeObject.cpp:
+ (JSC::JSStaticScopeObject::mark):
+ (JSC::JSStaticScopeObject::~JSStaticScopeObject):
+ * kjs/JSStaticScopeObject.h:
+ (JSC::JSStaticScopeObject::JSStaticScopeObject):
+ (JSC::JSStaticScopeObject::d):
+
+ Updated variable object to use the new interfaces required by the
+ change to JSActivation above:
+ * kjs/JSVariableObject.cpp:
+ (JSC::JSVariableObject::copyRegisterArray):
+ (JSC::JSVariableObject::setRegisters):
+ * kjs/JSVariableObject.h:
+
+ Changed the bit twiddling in symbol table not to assume that all indices
+ are negative, since they can be positive now:
+ * kjs/SymbolTable.h:
+ (JSC::SymbolTableEntry::SymbolTableEntry):
+ (JSC::SymbolTableEntry::isNull):
+ (JSC::SymbolTableEntry::getIndex):
+ (JSC::SymbolTableEntry::getAttributes):
+ (JSC::SymbolTableEntry::setAttributes):
+ (JSC::SymbolTableEntry::isReadOnly):
+ (JSC::SymbolTableEntry::pack):
+ (JSC::SymbolTableEntry::isValidIndex):
+
+ Changed call and construct nodes to ref their functions and/or bases,
+ so that emitCall/emitConstruct doesn't overwrite them with parameters.
+ Also, updated for rename to registerFor:
+ * kjs/nodes.cpp:
+ (JSC::ResolveNode::emitCode):
+ (JSC::NewExprNode::emitCode):
+ (JSC::EvalFunctionCallNode::emitCode):
+ (JSC::FunctionCallValueNode::emitCode):
+ (JSC::FunctionCallResolveNode::emitCode):
+ (JSC::FunctionCallBracketNode::emitCode):
+ (JSC::FunctionCallDotNode::emitCode):
+ (JSC::PostfixResolveNode::emitCode):
+ (JSC::DeleteResolveNode::emitCode):
+ (JSC::TypeOfResolveNode::emitCode):
+ (JSC::PrefixResolveNode::emitCode):
+ (JSC::ReadModifyResolveNode::emitCode):
+ (JSC::AssignResolveNode::emitCode):
+ (JSC::ConstDeclNode::emitCodeSingle):
+ (JSC::ForInNode::emitCode):
+
+ Added abstraction for getting exception info out of a call through a
+ register:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitCall):
+
+ Removed duplicate #if:
+ * wtf/Platform.h:
+
+2008-09-23 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Darin.
+
+ Bug 21030: The JS debugger breaks on the do of a do-while not the while
+ (where the conditional statement is)
+ https://bugs.webkit.org/show_bug.cgi?id=21030
+ Now the statementListEmitCode detects if a do-while node is being
+ emited and emits the debug hook on the last line instead of the first.
+
+ This change had no effect on sunspider.
+
+ * kjs/nodes.cpp:
+ (JSC::statementListEmitCode):
+ * kjs/nodes.h:
+ (JSC::StatementNode::isDoWhile):
+ (JSC::DoWhileNode::isDoWhile):
+
+2008-09-23 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - inline the fast case of instanceof
+ https://bugs.webkit.org/show_bug.cgi?id=20818
+
+ ~2% speedup on EarleyBoyer test.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_instanceof):
+
+2008-09-23 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - add forgotten slow case logic for !==
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileSlowCases):
+
+2008-09-23 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - inline the fast cases of !==, same as for ===
+
+ 2.9% speedup on EarleyBoyer benchmark
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpStrictEq): Factored stricteq codegen into this function,
+ and parameterized so it can do the reverse version as well.
+ (JSC::CTI::privateCompileMainPass): Use the above for stricteq and nstricteq.
+ * VM/CTI.h:
+ (JSC::CTI::): Declare above stuff.
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_nstricteq): Removed fast cases, now handled inline.
+
+2008-09-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20989: Aguments constructor should put 'callee' and 'length' properties in a more efficient way
+ <https://bugs.webkit.org/show_bug.cgi?id=20989>
+
+ Make special cases for the 'callee' and 'length' properties in the
+ Arguments object.
+
+ This is somewhere between a 7.8% speedup and a 10% speedup on the V8
+ Raytrace benchmark, depending on whether it is run alone or with the
+ other V8 benchmarks.
+
+ * kjs/Arguments.cpp:
+ (JSC::ArgumentsData::ArgumentsData):
+ (JSC::Arguments::Arguments):
+ (JSC::Arguments::mark):
+ (JSC::Arguments::getOwnPropertySlot):
+ (JSC::Arguments::put):
+ (JSC::Arguments::deleteProperty):
+
+2008-09-23 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin.
+
+ - speed up instanceof some more
+ https://bugs.webkit.org/show_bug.cgi?id=20818
+
+ ~2% speedup on EarleyBoyer
+
+ The idea here is to record in the StructureID whether the class
+ needs a special hasInstance or if it can use the normal logic from
+ JSObject.
+
+ Based on this I inlined the real work directly into
+ cti_op_instanceof and put the fastest checks up front and the
+ error handling at the end (so it should be fairly straightforward
+ to split off the beginning to be inlined if desired).
+
+ I only did this for CTI, not the bytecode interpreter.
+
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::createStructureID):
+ * ChangeLog:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_instanceof):
+ * kjs/JSImmediate.h:
+ (JSC::JSImmediate::isAnyImmediate):
+ * kjs/TypeInfo.h:
+ (JSC::TypeInfo::overridesHasInstance):
+ (JSC::TypeInfo::flags):
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21019
+ make FunctionBodyNode::ref/deref fast
+
+ Speeds up v8-raytrace by 7.2%.
+
+ * kjs/nodes.cpp:
+ (JSC::FunctionBodyNode::FunctionBodyNode): Initialize m_refCount to 0.
+ * kjs/nodes.h:
+ (JSC::FunctionBodyNode::ref): Call base class ref once, and thereafter use
+ m_refCount.
+ (JSC::FunctionBodyNode::deref): Ditto, but the deref side.
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ Pointed out by Sam Weinig.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::fillArgList): Fix bad copy and paste. Oops!
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20983
+ ArgumentsData should have some room to allocate some extra arguments inline
+
+ Speeds up v8-raytrace by 5%.
+
+ * kjs/Arguments.cpp:
+ (JSC::ArgumentsData::ArgumentsData): Use a fixed buffer if there are 4 or fewer
+ extra arguments.
+ (JSC::Arguments::Arguments): Use a fixed buffer if there are 4 or fewer
+ extra arguments.
+ (JSC::Arguments::~Arguments): Delete the buffer if necessary.
+ (JSC::Arguments::mark): Update since extraArguments are now Register.
+ (JSC::Arguments::fillArgList): Added special case for the only case that's
+ actually used in the practice, when there are no parameters. There are some
+ other special cases in there too, but that's the only one that matters.
+ (JSC::Arguments::getOwnPropertySlot): Updated to use setValueSlot since there's
+ no operation to get you at the JSValue* inside a Register as a "slot".
+
+2008-09-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21014
+ Speed up for..in by using StructureID to avoid calls to hasProperty
+
+ Speeds up fasta by 8%.
+
+ * VM/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::invalidate):
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::next):
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArrayData::begin):
+ (JSC::PropertyNameArrayData::end):
+ (JSC::PropertyNameArrayData::setCachedStructureID):
+ (JSC::PropertyNameArrayData::cachedStructureID):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames):
+ (JSC::structureIDChainsAreEqual):
+ * kjs/StructureID.h:
+
+2008-09-22 Kelvin Sherlock <ksherlock@gmail.com>
+
+ Updated and tweaked by Sam Weinig.
+
+ Reviewed by Geoffrey Garen.
+
+ Bug 20020: Proposed enhancement to JavaScriptCore API
+ <https://bugs.webkit.org/show_bug.cgi?id=20020>
+
+ Add JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError, and JSObjectMakeRegExp
+ functions to create JavaScript Array, Date, Error, and RegExp objects, respectively.
+
+ * API/JSObjectRef.cpp: The functions
+ * API/JSObjectRef.h: Function prototype and documentation
+ * JavaScriptCore.exp: Added functions to exported function list
+ * API/tests/testapi.c: Added basic functionality tests.
+
+ * kjs/DateConstructor.cpp:
+ Replaced static JSObject* constructDate(ExecState* exec, JSObject*, const ArgList& args)
+ with JSObject* constructDate(ExecState* exec, const ArgList& args).
+ Added static JSObject* constructWithDateConstructor(ExecState* exec, JSObject*, const ArgList& args) function
+
+ * kjs/DateConstructor.h:
+ added prototype for JSObject* constructDate(ExecState* exec, const ArgList& args)
+
+ * kjs/ErrorConstructor.cpp:
+ removed static qualifier from ErrorInstance* constructError(ExecState* exec, const ArgList& args)
+
+ * kjs/ErrorConstructor.h:
+ added prototype for ErrorInstance* constructError(ExecState* exec, const ArgList& args)
+
+ * kjs/RegExpConstructor.cpp:
+ removed static qualifier from JSObject* constructRegExp(ExecState* exec, const ArgList& args)
+
+ * kjs/RegExpConstructor.h:
+ added prototype for JSObject* constructRegExp(ExecState* exec, const ArgList& args)
+
+2008-09-22 Matt Lilek <webkit@mattlilek.com>
+
+ Not reviewed, Windows build fix.
+
+ * kjs/Arguments.cpp:
+ * kjs/FunctionPrototype.cpp:
+
+2008-09-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=20982
+ Speed up the apply method of functions by special-casing array and 'arguments' objects
+
+ 1% speedup on v8-raytrace.
+
+ Test: fast/js/function-apply.html
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::fillArgList):
+ * kjs/Arguments.h:
+ * kjs/FunctionPrototype.cpp:
+ (JSC::functionProtoFuncApply):
+ * kjs/JSArray.cpp:
+ (JSC::JSArray::fillArgList):
+ * kjs/JSArray.h:
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20993
+ Array.push/pop need optimized cases for JSArray
+
+ 3% or so speedup on DeltaBlue benchmark.
+
+ * kjs/ArrayPrototype.cpp:
+ (JSC::arrayProtoFuncPop): Call JSArray::pop when appropriate.
+ (JSC::arrayProtoFuncPush): Call JSArray::push when appropriate.
+
+ * kjs/JSArray.cpp:
+ (JSC::JSArray::putSlowCase): Set m_fastAccessCutoff when appropriate, getting
+ us into the fast code path.
+ (JSC::JSArray::pop): Added.
+ (JSC::JSArray::push): Added.
+ * kjs/JSArray.h: Added push and pop.
+
+ * kjs/operations.cpp:
+ (JSC::throwOutOfMemoryError): Don't inline this. Helps us avoid PIC branches.
+
+2008-09-22 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
+
+ Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
+
+ 2.2% speedup on EarleyBoyer benchmark.
+
+ * API/JSCallbackConstructor.cpp:
+ * API/JSCallbackConstructor.h:
+ (JSC::JSCallbackConstructor::createStructureID):
+ * API/JSCallbackFunction.cpp:
+ * API/JSCallbackFunction.h:
+ (JSC::JSCallbackFunction::createStructureID):
+ * API/JSCallbackObject.h:
+ (JSC::JSCallbackObject::createStructureID):
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::hasInstance):
+ * API/JSValueRef.cpp:
+ (JSValueIsInstanceOfConstructor):
+ * JavaScriptCore.exp:
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_instanceof):
+ * kjs/InternalFunction.cpp:
+ * kjs/InternalFunction.h:
+ (JSC::InternalFunction::createStructureID):
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ * kjs/TypeInfo.h:
+ (JSC::TypeInfo::implementsHasInstance):
+
+2008-09-22 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Based on initial work by Darin Adler.
+
+ - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
+ - use this to JIT inline code for eq_null and neq_null
+ https://bugs.webkit.org/show_bug.cgi?id=20823
+
+ 0.5% speedup on SunSpider
+ ~4% speedup on Richards benchmark
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/Machine.cpp:
+ (JSC::jsTypeStringForValue):
+ (JSC::jsIsObjectType):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_is_undefined):
+ * VM/Machine.h:
+ * kjs/JSCell.h:
+ * kjs/JSValue.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::create):
+ (JSC::StringObjectThatMasqueradesAsUndefined::createStructureID):
+ * kjs/StructureID.h:
+ (JSC::StructureID::mutableTypeInfo):
+ * kjs/TypeInfo.h:
+ (JSC::TypeInfo::TypeInfo):
+ (JSC::TypeInfo::masqueradesAsUndefined):
+ * kjs/operations.cpp:
+ (JSC::equal):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::setne_r):
+ (JSC::X86Assembler::setnz_r):
+ (JSC::X86Assembler::testl_i32m):
+
+2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Initialize QCoreApplication in kjs binary/Shell.cpp
+
+ This allows us to use QCoreApplication::instance() to
+ get the main thread in ThreadingQt.cpp
+
+ * kjs/Shell.cpp:
+ (main):
+ * wtf/ThreadingQt.cpp:
+ (WTF::initializeThreading):
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ - blind attempt to fix non-all-in-one builds
+
+ * kjs/JSGlobalObject.cpp: Added includes of Arguments.h and RegExpObject.h.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ - fix debug build
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::addPropertyTransition): Use typeInfo().type() instead of m_type.
+ (JSC::StructureID::createCachedPrototypeChain): Ditto.
+
+2008-09-21 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
+ https://bugs.webkit.org/show_bug.cgi?id=20981
+
+ * JavaScriptCore.exp:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ * VM/Machine.cpp:
+ (JSC::jsIsObjectType):
+ (JSC::Machine::Machine):
+ * kjs/AllInOneFile.cpp:
+ * kjs/JSCell.h:
+ (JSC::JSCell::isObject):
+ (JSC::JSCell::isString):
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::reset):
+ * kjs/JSGlobalObject.h:
+ (JSC::StructureID::prototypeForLookup):
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::createStructureID):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::createInheritorID):
+ * kjs/JSObject.h:
+ (JSC::JSObject::createStructureID):
+ * kjs/JSString.h:
+ (JSC::JSString::createStructureID):
+ * kjs/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ * kjs/RegExpConstructor.cpp:
+ * kjs/RegExpMatchesArray.h: Added.
+ (JSC::RegExpMatchesArray::getOwnPropertySlot):
+ (JSC::RegExpMatchesArray::put):
+ (JSC::RegExpMatchesArray::deleteProperty):
+ (JSC::RegExpMatchesArray::getPropertyNames):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::addPropertyTransition):
+ (JSC::StructureID::toDictionaryTransition):
+ (JSC::StructureID::changePrototypeTransition):
+ (JSC::StructureID::getterSetterTransition):
+ * kjs/StructureID.h:
+ (JSC::StructureID::create):
+ (JSC::StructureID::typeInfo):
+ * kjs/TypeInfo.h: Added.
+ (JSC::TypeInfo::TypeInfo):
+ (JSC::TypeInfo::type):
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix crash logging into Gmail due to recent Arguments change
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::Arguments): Fix window where mark() function could
+ see d->extraArguments with uninitialized contents.
+ (JSC::Arguments::mark): Check d->extraArguments for 0 to handle two
+ cases: 1) Inside the constructor before it's initialized.
+ 2) numArguments <= numParameters.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ - fix loose end from the "duplicate constant values" patch
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitLoad): Add a special case for values the
+ hash table can't handle.
+
+2008-09-21 Mark Rowe <mrowe@apple.com>
+
+ Fix the non-AllInOneFile build.
+
+ * kjs/Arguments.cpp: Add missing #include.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich and Mark Rowe.
+
+ - fix test failure caused by my recent IndexToNameMap patch
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::deleteProperty): Added the accidentally-omitted
+ check of the boolean result from toArrayIndex.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20975
+ inline immediate-number case of ==
+
+ * VM/CTI.h: Renamed emitJumpSlowCaseIfNotImm to
+ emitJumpSlowCaseIfNotImmNum, since the old name was incorrect.
+
+ * VM/CTI.cpp: Updated for new name.
+ (JSC::CTI::privateCompileMainPass): Added op_eq.
+ (JSC::CTI::privateCompileSlowCases): Added op_eq.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_eq): Removed fast case, since it's now
+ compiled.
+
+2008-09-21 Peter Gal <galpter@inf.u-szeged.hu>
+
+ Reviewed by Tim Hatcher and Eric Seidel.
+
+ Fix the QT/Linux JavaScriptCore segmentation fault.
+ https://bugs.webkit.org/show_bug.cgi?id=20914
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::initializeThreading): Use currentThread() if
+ platform is not a MAC (like in pre 36541 revisions)
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * kjs/debugger.h: Removed some unneeded includes and declarations.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20972
+ speed up Arguments further by eliminating the IndexToNameMap
+
+ No change on SunSpider. 1.29x as fast on V8 Raytrace.
+
+ * kjs/Arguments.cpp: Moved ArgumentsData in here. Eliminated the
+ indexToNameMap and hadDeletes data members. Changed extraArguments into
+ an OwnArrayPtr and added deletedArguments, another OwnArrayPtr.
+ Replaced numExtraArguments with numParameters, since that's what's
+ used more directly in hot code paths.
+ (JSC::Arguments::Arguments): Pass in argument count instead of ArgList.
+ Initialize ArgumentsData the new way.
+ (JSC::Arguments::mark): Updated.
+ (JSC::Arguments::getOwnPropertySlot): Overload for the integer form so
+ we don't have to convert integers to identifiers just to get an argument.
+ Integrated the deleted case with the fast case.
+ (JSC::Arguments::put): Ditto.
+ (JSC::Arguments::deleteProperty): Ditto.
+
+ * kjs/Arguments.h: Minimized includes. Made everything private. Added
+ overloads for the integral property name case. Eliminated mappedIndexSetter.
+ Moved ArgumentsData into the .cpp file.
+
+ * kjs/IndexToNameMap.cpp: Emptied out and prepared for deletion.
+ * kjs/IndexToNameMap.h: Ditto.
+
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::createArgumentsObject): Elminated ArgList.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/AllInOneFile.cpp:
+ Removed IndexToNameMap.
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitLoad): One more tweak: Wrote this in a slightly
+ clearer style.
+
+2008-09-21 Judit Jasz <jasy@inf.u-szeged.hu>
+
+ Reviewed and tweaked by Darin Adler.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20645
+ Elminate duplicate constant values in CodeBlocks.
+
+ Seems to be a wash on SunSpider.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitLoad): Use m_numberMap and m_stringMap to guarantee
+ we emit the same JSValue* for identical numbers and strings.
+ * VM/CodeGenerator.h: Added overload of emitLoad for const Identifier&.
+ Add NumberMap and IdentifierStringMap types and m_numberMap and m_stringMap.
+ * kjs/nodes.cpp:
+ (JSC::StringNode::emitCode): Call the new emitLoad and let it do the
+ JSString creation.
+
+2008-09-21 Paul Pedriana <webkit@pedriana.com>
+
+ Reviewed and tweaked by Darin Adler.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=16925
+ Fixed lack of Vector buffer alignment for both GCC and MSVC.
+ Since there's no portable way to do this, for now we don't support
+ other compilers.
+
+ * wtf/Vector.h: Added WTF_ALIGH_ON, WTF_ALIGNED, AlignedBufferChar, and AlignedBuffer.
+ Use AlignedBuffer insteadof an array of char in VectorBuffer.
+
+2008-09-21 Gabor Loki <loki@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=19408
+ Add lightweight constant folding to the parser for *, /, + (only for numbers), <<, >>, ~ operators.
+
+ 1.008x as fast on SunSpider.
+
+ * kjs/grammar.y:
+ (makeNegateNode): Fold if expression is a number > 0.
+ (makeBitwiseNotNode): Fold if expression is a number.
+ (makeMultNode): Fold if expressions are both numbers.
+ (makeDivNode): Fold if expressions are both numbers.
+ (makeAddNode): Fold if expressions are both numbers.
+ (makeLeftShiftNode): Fold if expressions are both numbers.
+ (makeRightShiftNode): Fold if expressions are both numbers.
+
+2008-09-21 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver.
+
+ - speed up === operator by generating inline machine code for the fast paths
+ https://bugs.webkit.org/show_bug.cgi?id=20820
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumber):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumbers):
+ (JSC::CTI::emitJumpSlowCaseIfNotImmediates):
+ (JSC::CTI::emitTagAsBoolImmediate):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_stricteq):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::sete_r):
+ (JSC::X86Assembler::setz_r):
+ (JSC::X86Assembler::movzbl_rr):
+ (JSC::X86Assembler::emitUnlinkedJnz):
+
+2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Free memory allocated for extra arguments in the destructor of the
+ Arguments object.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::~Arguments):
+ * kjs/Arguments.h:
+
+2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20815: 'arguments' object creation is non-optimal
+ <https://bugs.webkit.org/show_bug.cgi?id=20815>
+
+ Fix our inefficient way of creating the arguments object by only
+ creating named properties for each of the arguments after a use of the
+ 'delete' statement. This patch also speeds up access to the 'arguments'
+ object slightly, but it still does not use the array fast path for
+ indexed access that exists for many opcodes.
+
+ This is about a 20% improvement on the V8 Raytrace benchmark, and a 1.5%
+ improvement on the Earley-Boyer benchmark, which gives a 4% improvement
+ overall.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::Arguments):
+ (JSC::Arguments::mark):
+ (JSC::Arguments::getOwnPropertySlot):
+ (JSC::Arguments::put):
+ (JSC::Arguments::deleteProperty):
+ * kjs/Arguments.h:
+ (JSC::Arguments::ArgumentsData::ArgumentsData):
+ * kjs/IndexToNameMap.h:
+ (JSC::IndexToNameMap::size):
+ * kjs/JSActivation.cpp:
+ (JSC::JSActivation::createArgumentsObject):
+ * kjs/JSActivation.h:
+ (JSC::JSActivation::uncheckedSymbolTableGet):
+ (JSC::JSActivation::uncheckedSymbolTableGetValue):
+ (JSC::JSActivation::uncheckedSymbolTablePut):
+ * kjs/JSFunction.h:
+ (JSC::JSFunction::numParameters):
+
+2008-09-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix crash seen on buildbot
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::mark): Add back mark of arrayPrototype,
+ deleted by accident in my recent check-in.
+
+2008-09-20 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed, build fix.
+
+ - speculative fix for non-AllInOne builds
+
+ * kjs/operations.h:
+
+2008-09-20 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - assorted optimizations to === and !== operators
+ (work towards <https://bugs.webkit.org/show_bug.cgi?id=20820>)
+
+ 2.5% speedup on earley-boyer test
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_stricteq): Use inline version of
+ strictEqualSlowCase; remove unneeded exception check.
+ (JSC::Machine::cti_op_nstricteq): ditto
+ * kjs/operations.cpp:
+ (JSC::strictEqual): Use strictEqualSlowCaseInline
+ (JSC::strictEqualSlowCase): ditto
+ * kjs/operations.h:
+ (JSC::strictEqualSlowCaseInline): Version of strictEqualSlowCase that can be inlined,
+ since the extra function call indirection is a lose for CTI.
+
+2008-09-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - finish https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ This also includes some optimizations that make the change an overall
+ small speedup. Without those it was a bit of a slowdown.
+
+ * API/JSCallbackConstructor.cpp:
+ (JSC::JSCallbackConstructor::JSCallbackConstructor): Take a structure.
+ * API/JSCallbackConstructor.h: Ditto.
+ * API/JSCallbackFunction.cpp:
+ (JSC::JSCallbackFunction::JSCallbackFunction): Pass a structure.
+ * API/JSCallbackObject.h: Take a structure.
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::JSCallbackObject::JSCallbackObject): Ditto.
+
+ * API/JSClassRef.cpp:
+ (OpaqueJSClass::prototype): Pass in a structure. Call setPrototype
+ if there's a custom prototype involved.
+ * API/JSObjectRef.cpp:
+ (JSObjectMake): Ditto.
+ (JSObjectMakeConstructor): Pass in a structure.
+
+ * JavaScriptCore.exp: Updated.
+
+ * VM/Machine.cpp:
+ (JSC::jsLess): Added a special case for when both arguments are strings.
+ This avoids converting both strings to with UString::toDouble.
+ (JSC::jsLessEq): Ditto.
+ (JSC::Machine::privateExecute): Pass in a structure.
+ (JSC::Machine::cti_op_construct_JSConstruct): Ditto.
+ (JSC::Machine::cti_op_new_regexp): Ditto.
+ (JSC::Machine::cti_op_is_string): Ditto.
+ * VM/Machine.h: Made isJSString public so it can be used in the CTI.
+
+ * kjs/Arguments.cpp:
+ (JSC::Arguments::Arguments): Pass in a structure.
+
+ * kjs/JSCell.h: Mark constructor explicit.
+
+ * kjs/JSGlobalObject.cpp:
+ (JSC::markIfNeeded): Added an overload for marking structures.
+ (JSC::JSGlobalObject::reset): Eliminate code to set data members to
+ zero. We now do that in the constructor, and we no longer use this
+ anywhere except in the constructor. Added code to create structures.
+ Pass structures rather than prototypes when creating objects.
+ (JSC::JSGlobalObject::mark): Mark the structures.
+
+ * kjs/JSGlobalObject.h: Removed unneeded class declarations.
+ Added initializers for raw pointers in JSGlobalObjectData so
+ everything starts with a 0. Added structure data and accessor
+ functions.
+
+ * kjs/JSImmediate.cpp:
+ (JSC::JSImmediate::nonInlineNaN): Added.
+ * kjs/JSImmediate.h:
+ (JSC::JSImmediate::toDouble): Rewrote to avoid PIC branches.
+
+ * kjs/JSNumberCell.cpp:
+ (JSC::jsNumberCell): Made non-inline to avoid PIC branches
+ in functions that call this one.
+ (JSC::jsNaN): Ditto.
+ * kjs/JSNumberCell.h: Ditto.
+
+ * kjs/JSObject.h: Removed constructor that takes a prototype.
+ All callers now pass structures.
+
+ * kjs/ArrayConstructor.cpp:
+ (JSC::ArrayConstructor::ArrayConstructor):
+ (JSC::constructArrayWithSizeQuirk):
+ * kjs/ArrayConstructor.h:
+ * kjs/ArrayPrototype.cpp:
+ (JSC::ArrayPrototype::ArrayPrototype):
+ * kjs/ArrayPrototype.h:
+ * kjs/BooleanConstructor.cpp:
+ (JSC::BooleanConstructor::BooleanConstructor):
+ (JSC::constructBoolean):
+ (JSC::constructBooleanFromImmediateBoolean):
+ * kjs/BooleanConstructor.h:
+ * kjs/BooleanObject.cpp:
+ (JSC::BooleanObject::BooleanObject):
+ * kjs/BooleanObject.h:
+ * kjs/BooleanPrototype.cpp:
+ (JSC::BooleanPrototype::BooleanPrototype):
+ * kjs/BooleanPrototype.h:
+ * kjs/DateConstructor.cpp:
+ (JSC::DateConstructor::DateConstructor):
+ (JSC::constructDate):
+ * kjs/DateConstructor.h:
+ * kjs/DateInstance.cpp:
+ (JSC::DateInstance::DateInstance):
+ * kjs/DateInstance.h:
+ * kjs/DatePrototype.cpp:
+ (JSC::DatePrototype::DatePrototype):
+ * kjs/DatePrototype.h:
+ * kjs/ErrorConstructor.cpp:
+ (JSC::ErrorConstructor::ErrorConstructor):
+ (JSC::constructError):
+ * kjs/ErrorConstructor.h:
+ * kjs/ErrorInstance.cpp:
+ (JSC::ErrorInstance::ErrorInstance):
+ * kjs/ErrorInstance.h:
+ * kjs/ErrorPrototype.cpp:
+ (JSC::ErrorPrototype::ErrorPrototype):
+ * kjs/ErrorPrototype.h:
+ * kjs/FunctionConstructor.cpp:
+ (JSC::FunctionConstructor::FunctionConstructor):
+ * kjs/FunctionConstructor.h:
+ * kjs/FunctionPrototype.cpp:
+ (JSC::FunctionPrototype::FunctionPrototype):
+ (JSC::FunctionPrototype::addFunctionProperties):
+ * kjs/FunctionPrototype.h:
+ * kjs/GlobalEvalFunction.cpp:
+ (JSC::GlobalEvalFunction::GlobalEvalFunction):
+ * kjs/GlobalEvalFunction.h:
+ * kjs/InternalFunction.cpp:
+ (JSC::InternalFunction::InternalFunction):
+ * kjs/InternalFunction.h:
+ (JSC::InternalFunction::InternalFunction):
+ * kjs/JSArray.cpp:
+ (JSC::JSArray::JSArray):
+ (JSC::constructEmptyArray):
+ (JSC::constructArray):
+ * kjs/JSArray.h:
+ * kjs/JSFunction.cpp:
+ (JSC::JSFunction::JSFunction):
+ (JSC::JSFunction::construct):
+ * kjs/JSObject.cpp:
+ (JSC::constructEmptyObject):
+ * kjs/JSString.cpp:
+ (JSC::StringObject::create):
+ * kjs/JSWrapperObject.h:
+ * kjs/MathObject.cpp:
+ (JSC::MathObject::MathObject):
+ * kjs/MathObject.h:
+ * kjs/NativeErrorConstructor.cpp:
+ (JSC::NativeErrorConstructor::NativeErrorConstructor):
+ (JSC::NativeErrorConstructor::construct):
+ * kjs/NativeErrorConstructor.h:
+ * kjs/NativeErrorPrototype.cpp:
+ (JSC::NativeErrorPrototype::NativeErrorPrototype):
+ * kjs/NativeErrorPrototype.h:
+ * kjs/NumberConstructor.cpp:
+ (JSC::NumberConstructor::NumberConstructor):
+ (JSC::constructWithNumberConstructor):
+ * kjs/NumberConstructor.h:
+ * kjs/NumberObject.cpp:
+ (JSC::NumberObject::NumberObject):
+ (JSC::constructNumber):
+ (JSC::constructNumberFromImmediateNumber):
+ * kjs/NumberObject.h:
+ * kjs/NumberPrototype.cpp:
+ (JSC::NumberPrototype::NumberPrototype):
+ * kjs/NumberPrototype.h:
+ * kjs/ObjectConstructor.cpp:
+ (JSC::ObjectConstructor::ObjectConstructor):
+ (JSC::constructObject):
+ * kjs/ObjectConstructor.h:
+ * kjs/ObjectPrototype.cpp:
+ (JSC::ObjectPrototype::ObjectPrototype):
+ * kjs/ObjectPrototype.h:
+ * kjs/PrototypeFunction.cpp:
+ (JSC::PrototypeFunction::PrototypeFunction):
+ * kjs/PrototypeFunction.h:
+ * kjs/RegExpConstructor.cpp:
+ (JSC::RegExpConstructor::RegExpConstructor):
+ (JSC::RegExpMatchesArray::RegExpMatchesArray):
+ (JSC::constructRegExp):
+ * kjs/RegExpConstructor.h:
+ * kjs/RegExpObject.cpp:
+ (JSC::RegExpObject::RegExpObject):
+ * kjs/RegExpObject.h:
+ * kjs/RegExpPrototype.cpp:
+ (JSC::RegExpPrototype::RegExpPrototype):
+ * kjs/RegExpPrototype.h:
+ * kjs/Shell.cpp:
+ (GlobalObject::GlobalObject):
+ * kjs/StringConstructor.cpp:
+ (JSC::StringConstructor::StringConstructor):
+ (JSC::constructWithStringConstructor):
+ * kjs/StringConstructor.h:
+ * kjs/StringObject.cpp:
+ (JSC::StringObject::StringObject):
+ * kjs/StringObject.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
+ * kjs/StringPrototype.cpp:
+ (JSC::StringPrototype::StringPrototype):
+ * kjs/StringPrototype.h:
+ Take and pass structures.
+
+2008-09-19 Alp Toker <alp@nuanti.com>
+
+ Build fix for the 'gold' linker and recent binutils. New behaviour
+ requires that we link to used libraries explicitly.
+
+ * GNUmakefile.am:
+
+2008-09-19 Sam Weinig <sam@webkit.org>
+
+ Roll r36694 back in. It did not cause the crash.
+
+ * JavaScriptCore.exp:
+ * VM/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::invalidate):
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::create):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::getPropertyNames):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::getEnumerablePropertyNames):
+ * kjs/PropertyMap.h:
+ * kjs/PropertyNameArray.cpp:
+ (JSC::PropertyNameArray::add):
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArrayData::create):
+ (JSC::PropertyNameArrayData::propertyNameVector):
+ (JSC::PropertyNameArrayData::setCachedPrototypeChain):
+ (JSC::PropertyNameArrayData::cachedPrototypeChain):
+ (JSC::PropertyNameArrayData::begin):
+ (JSC::PropertyNameArrayData::end):
+ (JSC::PropertyNameArrayData::PropertyNameArrayData):
+ (JSC::PropertyNameArray::PropertyNameArray):
+ (JSC::PropertyNameArray::addKnownUnique):
+ (JSC::PropertyNameArray::size):
+ (JSC::PropertyNameArray::operator[]):
+ (JSC::PropertyNameArray::begin):
+ (JSC::PropertyNameArray::end):
+ (JSC::PropertyNameArray::setData):
+ (JSC::PropertyNameArray::data):
+ (JSC::PropertyNameArray::releaseData):
+ * kjs/StructureID.cpp:
+ (JSC::structureIDChainsAreEqual):
+ (JSC::StructureID::getEnumerablePropertyNames):
+ (JSC::StructureID::clearEnumerationCache):
+ (JSC::StructureID::createCachedPrototypeChain):
+ * kjs/StructureID.h:
+
+2008-09-19 Sam Weinig <sam@webkit.org>
+
+ Roll out r36694.
+
+ * JavaScriptCore.exp:
+ * VM/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::invalidate):
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::create):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::getPropertyNames):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::getEnumerablePropertyNames):
+ * kjs/PropertyMap.h:
+ * kjs/PropertyNameArray.cpp:
+ (JSC::PropertyNameArray::add):
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArray::PropertyNameArray):
+ (JSC::PropertyNameArray::addKnownUnique):
+ (JSC::PropertyNameArray::begin):
+ (JSC::PropertyNameArray::end):
+ (JSC::PropertyNameArray::size):
+ (JSC::PropertyNameArray::operator[]):
+ (JSC::PropertyNameArray::releaseIdentifiers):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::getEnumerablePropertyNames):
+ * kjs/StructureID.h:
+ (JSC::StructureID::clearEnumerationCache):
+
+2008-09-19 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Improve peformance of local variable initialisation.
+
+ Pull local and constant initialisation out of slideRegisterWindowForCall
+ and into its own opcode. This allows the JIT to generate the initialisation
+ code for a function directly into the instruction stream and so avoids a few
+ branches on function entry.
+
+ Results a 1% progression in SunSpider, particularly in a number of the bitop
+ tests where the called functions are very fast.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitInitialiseRegister):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::CodeGenerator):
+ * VM/Machine.cpp:
+ (JSC::slideRegisterWindowForCall):
+ (JSC::Machine::privateExecute):
+ * VM/Opcode.h:
+
+2008-09-19 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=20928
+ Speed up JS property enumeration by caching entire PropertyNameArray
+
+ 1.3% speedup on Sunspider, 30% on string-fasta.
+
+ * JavaScriptCore.exp:
+ * VM/JSPropertyNameIterator.cpp:
+ (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::invalidate):
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
+ (JSC::JSPropertyNameIterator::create):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::getPropertyNames):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::getEnumerablePropertyNames):
+ * kjs/PropertyMap.h:
+ * kjs/PropertyNameArray.cpp:
+ (JSC::PropertyNameArray::add):
+ * kjs/PropertyNameArray.h:
+ (JSC::PropertyNameArrayData::create):
+ (JSC::PropertyNameArrayData::propertyNameVector):
+ (JSC::PropertyNameArrayData::setCachedPrototypeChain):
+ (JSC::PropertyNameArrayData::cachedPrototypeChain):
+ (JSC::PropertyNameArrayData::begin):
+ (JSC::PropertyNameArrayData::end):
+ (JSC::PropertyNameArrayData::PropertyNameArrayData):
+ (JSC::PropertyNameArray::PropertyNameArray):
+ (JSC::PropertyNameArray::addKnownUnique):
+ (JSC::PropertyNameArray::size):
+ (JSC::PropertyNameArray::operator[]):
+ (JSC::PropertyNameArray::begin):
+ (JSC::PropertyNameArray::end):
+ (JSC::PropertyNameArray::setData):
+ (JSC::PropertyNameArray::data):
+ (JSC::PropertyNameArray::releaseData):
+ * kjs/ScopeChain.cpp:
+ (JSC::ScopeChainNode::print):
+ * kjs/StructureID.cpp:
+ (JSC::structureIDChainsAreEqual):
+ (JSC::StructureID::getEnumerablePropertyNames):
+ (JSC::StructureID::clearEnumerationCache):
+ (JSC::StructureID::createCachedPrototypeChain):
+ * kjs/StructureID.h:
+
+2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix a mismatched new[]/delete in JSObject::allocatePropertyStorage
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::allocatePropertyStorage): Spotted by valgrind.
+
+2008-09-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ * JavaScriptCore.exp: Exported constructEmptyObject for use in WebCore.
+
+ * kjs/JSGlobalObject.h: Changed the protected constructor to take a
+ structure instead of a prototype.
+
+ * kjs/JSVariableObject.h: Removed constructor that takes a prototype.
+
+2008-09-19 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Use the template hoisting technique on the RefCounted class. This reduces the code bloat due to
+ non-template methods' code been copied for each instance of the template.
+ The patch splits RefCounted between a base class that holds non-template methods and attributes
+ and the template RefCounted class that keeps the same functionnality.
+
+ On my Linux with gcc 4.3 for the Gtk port, this is:
+ - a ~600KB save on libwebkit.so in release.
+ - a ~1.6MB save on libwebkit.so in debug.
+
+ It is a wash on Sunspider and a small win on Dromaeo (not sure it is relevant).
+ On the whole, it should be a small win as we reduce the compiled code size and the only
+ new function call should be inlined by the compiler.
+
+ * wtf/RefCounted.h:
+ (WTF::RefCountedBase::ref): Copied from RefCounted.
+ (WTF::RefCountedBase::hasOneRef): Ditto.
+ (WTF::RefCountedBase::refCount): Ditto.
+ (WTF::RefCountedBase::RefCountedBase): Ditto.
+ (WTF::RefCountedBase::~RefCountedBase): Ditto.
+ (WTF::RefCountedBase::derefBase): Tweaked from the RefCounted version to remove
+ template section.
+ (WTF::RefCounted::RefCounted):
+ (WTF::RefCounted::deref): Small wrapper around RefCountedBase::derefBase().
+ (WTF::RefCounted::~RefCounted): Keep private destructor.
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ * kjs/lookup.h: Removed things here that were used only in WebCore:
+ cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE,
+ and JSC_IMPLEMENT_PROTOTYPE.
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20927
+ simplify/streamline the code to turn strings into identifiers while parsing
+
+ * kjs/grammar.y: Get rid of string from the union, and use ident for STRING as
+ well as for IDENT.
+
+ * kjs/lexer.cpp:
+ (JSC::Lexer::lex): Use makeIdentifier instead of makeUString for String.
+ * kjs/lexer.h: Remove makeUString.
+
+ * kjs/nodes.h: Changed StringNode to hold an Identifier instead of UString.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::keyForCharacterSwitch): Updated since StringNode now holds an Identifier.
+ (JSC::prepareJumpTableForStringSwitch): Ditto.
+ * kjs/nodes.cpp:
+ (JSC::StringNode::emitCode): Ditto. The comment from here is now in the lexer.
+ (JSC::processClauseList): Ditto.
+ * kjs/nodes2string.cpp:
+ (JSC::StringNode::streamTo): Ditto.
+
+2008-09-18 Sam Weinig <sam@webkit.org>
+
+ Fix style.
+
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+
+2008-09-18 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20911: REGRESSION(r36480?): Reproducible assertion failure below derefStructureIDs 64-bit JavaScriptCore
+ <https://bugs.webkit.org/show_bug.cgi?id=20911>
+
+ The problem was simply caused by the int constructor for Instruction
+ failing to initialise the full struct in 64bit builds.
+
+ * VM/Instruction.h:
+ (JSC::Instruction::Instruction):
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ - fix release build
+
+ * wtf/RefCountedLeakCounter.cpp: Removed stray "static".
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * kjs/JSGlobalObject.h: Tiny style guideline tweak.
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20925
+ LEAK messages appear every time I quit
+
+ * JavaScriptCore.exp: Updated, and also added an export
+ needed for future WebCore use of JSC::StructureID.
+
+ * wtf/RefCountedLeakCounter.cpp:
+ (WTF::RefCountedLeakCounter::suppressMessages): Added.
+ (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added.
+ (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit.
+ (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to
+ log the reason there was no leak checking done.
+ (WTF::RefCountedLeakCounter::increment): Tweaked a bit.
+ (WTF::RefCountedLeakCounter::decrement): Ditto.
+
+ * wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two
+ new functions, suppressMessages and cancelMessageSuppression. Also
+ added m_ prefixes to the data member names.
+
+2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20437
+
+ Add a proper #define to define which XML Parser implementation to use. Client
+ code can use #if USE(QXMLSTREAM) to decide if the Qt XML StreamReader
+ implementation is going to be used.
+
+ * wtf/Platform.h:
+
+2008-09-18 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Make a Unicode non-breaking space count as a whitespace character in
+ PCRE. This change was already made in WREC, and it fixes one of the
+ Mozilla JS tests. Since it is now fixed in PCRE as well, we can check
+ in a new set of expected test results.
+
+ * pcre/pcre_internal.h:
+ (isSpaceChar):
+ * tests/mozilla/expected.html:
+
+2008-09-18 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Mark Rowe and Maciej Stachowiak.
+
+ add an option use arch to specify which architecture to run.
+
+ * tests/mozilla/jsDriver.pl:
+
+2008-09-17 Oliver Hunt <oliver@apple.com>
+
+ Correctly restore argument reference prior to SFX runtime calls.
+
+ Reviewed by Steve Falkenburg.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+
+2008-09-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20876: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
+ <https://bugs.webkit.org/show_bug.cgi?id=20876>
+
+ r36417 and r36427 caused an get_by_id opcode to be emitted before the
+ instanceof and construct opcodes, in order to enable inline caching of
+ the prototype property. Unfortunately, this regressed some tests dealing
+ with exceptions thrown by 'instanceof' and the 'new' operator. We fix
+ these problems by detecting whether an "is not an object" exception is
+ thrown before op_instanceof or op_construct, and emit the proper
+ exception in those cases.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitConstruct):
+ * VM/CodeGenerator.h:
+ * VM/ExceptionHelpers.cpp:
+ (JSC::createInvalidParamError):
+ (JSC::createNotAConstructorError):
+ (JSC::createNotAnObjectError):
+ * VM/ExceptionHelpers.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::getOpcode):
+ (JSC::Machine::privateExecute):
+ * VM/Machine.h:
+ * kjs/nodes.cpp:
+ (JSC::NewExprNode::emitCode):
+ (JSC::InstanceOfNode::emitCode):
+
+2008-09-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ JIT generation cti_op_construct_verify.
+
+ Quarter to half percent progression on v8-tests.
+ Roughly not change on SunSpider (possible minor progression).
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+
+2008-09-15 Steve Falkenburg <sfalken@apple.com>
+
+ Improve timer accuracy for JavaScript Date object on Windows.
+
+ Use a combination of ftime and QueryPerformanceCounter.
+ ftime returns the information we want, but doesn't have sufficient resolution.
+ QueryPerformanceCounter has high resolution, but is only usable to measure time intervals.
+ To combine them, we call ftime and QueryPerformanceCounter initially. Later calls will use
+ QueryPerformanceCounter by itself, adding the delta to the saved ftime. We re-sync to
+ correct for drift if the low-res and high-res elapsed time between calls differs by more
+ than twice the low-resolution timer resolution.
+
+ QueryPerformanceCounter may be inaccurate due to a problems with:
+ - some PCI bridge chipsets (http://support.microsoft.com/kb/274323)
+ - BIOS bugs (http://support.microsoft.com/kb/895980/)
+ - BIOS/HAL bugs on multiprocessor/multicore systems (http://msdn.microsoft.com/en-us/library/ms644904.aspx)
+
+ Reviewed by Darin Adler.
+
+ * kjs/DateMath.cpp:
+ (JSC::highResUpTime):
+ (JSC::lowResUTCTime):
+ (JSC::qpcAvailable):
+ (JSC::getCurrentUTCTimeWithMicroseconds):
+
+2008-09-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Implement JIT generation of CallFrame initialization, for op_call.
+
+ 1% sunspider 2.5% v8-tests.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_op_call_NotJSFunction):
+
+2008-09-17 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Optimizations for op_call in CTI. Move check for (ctiCode == 0) into JIT code,
+ move copying of scopeChain for CodeBlocks that needFullScopeChain into head of
+ functions, instead of checking prior to making the call.
+
+ 3% on v8-tests (4% on richards, 6% in delta-blue)
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ * VM/Machine.cpp:
+ (JSC::Machine::execute):
+ (JSC::Machine::cti_op_call_JSFunction):
+ (JSC::Machine::cti_vm_compile):
+ (JSC::Machine::cti_vm_updateScopeChain):
+ (JSC::Machine::cti_op_construct_JSConstruct):
+ * VM/Machine.h:
+
+2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Fix the QtWebKit/Mac build
+
+ * wtf/ThreadingQt.cpp:
+ (WTF::initializeThreading): use QCoreApplication to get the main thread
+
+2008-09-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20857: REGRESSION (r36427): ASSERTION FAILED: m_refCount >= 0 in RegisterID::deref()
+ <https://bugs.webkit.org/show_bug.cgi?id=20857>
+
+ Fix a problem stemming from the slightly unsafe behaviour of the
+ CodeGenerator::finalDestination() method by putting the "func" argument
+ of the emitConstruct() method in a RefPtr in its caller. Also, add an
+ assertion guaranteeing that this is always the case.
+
+ CodeGenerator::finalDestination() is still incorrect and can cause
+ problems with a different allocator; see bug 20340 for more details.
+
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitConstruct):
+ * kjs/nodes.cpp:
+ (JSC::NewExprNode::emitCode):
+
+2008-09-16 Alice Liu <alice.liu@apple.com>
+
+ build fix.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+
+2008-09-16 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ CTI code generation for op_ret. The majority of the work
+ (updating variables on the stack & on exec) can be performed
+ directly in generated code.
+
+ We still need to check, & to call out to C-code to handle
+ activation records, profiling, and full scope chains.
+
+ +1.5% Sunspider, +5/6% v8 tests.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_ret_activation):
+ (JSC::Machine::cti_op_ret_profiler):
+ (JSC::Machine::cti_op_ret_scopeChain):
+ * VM/Machine.h:
+
+2008-09-16 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Fix the Windows build.
+
+ Add some extra parentheses to stop MSVC from complaining so much.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ * kjs/operations.cpp:
+ (JSC::strictEqual):
+
+2008-09-15 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up the === and !== operators by choosing the fast cases better
+
+ No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_stricteq):
+ (JSC::Machine::cti_op_nstricteq):
+ * kjs/JSImmediate.h:
+ (JSC::JSImmediate::areBothImmediate):
+ * kjs/operations.cpp:
+ (JSC::strictEqual):
+ (JSC::strictEqualSlowCase):
+ * kjs/operations.h:
+
+2008-09-15 Oliver Hunt <oliver@apple.com>
+
+ RS=Sam Weinig.
+
+ Coding style cleanup.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+
+2008-09-15 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 20874: op_resolve does not do any form of caching
+ <https://bugs.webkit.org/show_bug.cgi?id=20874>
+
+ This patch adds an op_resolve_global opcode to handle (and cache)
+ property lookup we can statically determine must occur on the global
+ object (if at all).
+
+ 3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
+ 10% in math-partial-sums
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::findScopedProperty):
+ (JSC::CodeGenerator::emitResolve):
+ * VM/Machine.cpp:
+ (JSC::resolveGlobal):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_resolve_global):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+
+2008-09-15 Sam Weinig <sam@webkit.org>
+
+ Roll out r36462. It broke document.all.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine):
+ (JSC::Machine::cti_op_eq_null):
+ (JSC::Machine::cti_op_neq_null):
+ * VM/Machine.h:
+ (JSC::Machine::isJSString):
+ * kjs/JSCell.h:
+ * kjs/JSWrapperObject.h:
+ * kjs/StringObject.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+
+2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
+ <https://bugs.webkit.org/show_bug.cgi?id=20863>
+
+ r36427 changed the number of arguments to op_construct without changing
+ the argument index for the vPC in the call to initializeCallFrame() in
+ the CTI case. This caused a JSC test failure. Correcting the argument
+ index fixes the test failure.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_construct_JSConstruct):
+
+2008-09-15 Mark Rowe <mrowe@apple.com>
+
+ Fix GCC 4.2 build.
+
+ * VM/CTI.h:
+
+2008-09-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fixed a typo in op_get_by_id_chain that caused it to miss every time
+ in the interpreter.
+
+ Also, a little cleanup.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): Set up baseObject before entering the
+ loop, so we compare against the right values.
+
+2008-09-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Removed the CalledAsConstructor flag from the call frame header. Now,
+ we use an explicit opcode at the call site to fix up constructor results.
+
+ SunSpider says 0.4% faster.
+
+ cti_op_construct_verify is an out-of-line function call for now, but we
+ can fix that once StructureID holds type information like isObject.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
+
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+
+ * VM/CodeGenerator.cpp: Codegen for the new opcode. Also...
+ (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value.
+ (JSC::CodeGenerator::emitConstruct): ... ditto.
+
+ * VM/Machine.cpp: No more CalledAsConstructor
+ (JSC::Machine::privateExecute): Implementation for the new opcode.
+ (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were
+ called as a constructor.
+ (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
+ * VM/Machine.h:
+
+ * VM/Opcode.h: Declare new opcode.
+
+ * VM/RegisterFile.h:
+ (JSC::RegisterFile::): No more CalledAsConstructor
+
+2008-09-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
+ StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
+ masquerading may be handled differently (through the StructureIDs - see bug
+ #20823).
+
+ >1% on v8-tests.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitJumpSlowCaseIfIsJSCell):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine):
+ (JSC::Machine::cti_op_eq_null):
+ (JSC::Machine::cti_op_neq_null):
+ * VM/Machine.h:
+ (JSC::Machine::doesMasqueradesAsUndefined):
+ * kjs/JSWrapperObject.h:
+ (JSC::JSWrapperObject::):
+ (JSC::JSWrapperObject::JSWrapperObject):
+ * kjs/StringObject.h:
+ (JSC::StringObject::StringObject):
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
+
+2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Oliver Hunt.
+
+ r36427 broke CodeBlock::dump() by changing the number of arguments to
+ op_construct without changing the code that prints it. This patch fixes
+ it by printing the additional argument.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+
+2008-09-15 Adam Roben <aroben@apple.com>
+
+ Build fix
+
+ * kjs/StructureID.cpp: Removed a stray semicolon.
+
+2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix a crash in fast/js/exception-expression-offset.html caused by not
+ updating all mentions of the length of op_construct in r36427.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_construct_NotJSConstruct):
+
+2008-09-15 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix layout test failure introduced by fix for 20849
+
+ (The failing test was fast/js/delete-then-put.html)
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::removeDirect): Clear enumeration cache
+ in the dictionary case.
+ * kjs/JSObject.h:
+ (JSC::JSObject::putDirect): Ditto.
+ * kjs/StructureID.h:
+ (JSC::StructureID::clearEnumerationCache): Inline to handle the
+ clear.
+
+2008-09-15 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - fix JSC test failures introduced by fix for 20849
+
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
+
+2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
+ <https://bugs.webkit.org/show_bug.cgi?id=20851>
+
+ r36410 introduced an optimization for parseInt() that is incorrect when
+ its argument is larger than the range of a 32-bit integer. If the
+ argument is a number that is not an immediate integer, then the correct
+ behaviour is to return the floor of its value, unless it is an infinite
+ value, in which case the correct behaviour is to return 0.
+
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt):
+
+2008-09-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
+ Cache property names for getEnumerablePropertyNames in the StructureID.
+
+ ~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
+ on the v8 test suite.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::getPropertyNames):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::getEnumerablePropertyNames):
+ * kjs/PropertyMap.h:
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::getEnumerablePropertyNames):
+ * kjs/StructureID.h:
+
+2008-09-14 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up JS construction by extracting "prototype" lookup so PIC applies.
+
+ ~0.5% speedup on SunSpider
+ Speeds up some of the V8 tests as well, most notably earley-boyer.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileOpCall): Account for extra arg for prototype.
+ (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): Expect prototype arg in op_construct.
+ (JSC::Machine::cti_op_construct_JSConstruct): ditto
+ (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
+
+2008-09-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Add a protected destructor for RefCounted.
+
+ It is wrong to call its destructor directly, because (1) this should be taken care of by
+ deref(), and (2) many classes that use RefCounted have non-virtual destructors.
+
+ No change in behavior.
+
+ * wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
+
+2008-09-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Accelerated property accesses.
+
+ Inline more of the array access code into the JIT code for get/put_by_val.
+ Accelerate get/put_by_id by speculatively inlining a disable direct access
+ into the hot path of the code, and repatch this with the correct StructureID
+ and property map offset once these are known. In the case of accesses to the
+ prototype and reading the array-length a trampoline is genertaed, and the
+ branch to the slow-case is relinked to jump to this.
+
+ By repatching, we mean rewriting the x86 instruction stream. Instructions are
+ only modified in a simple fasion - altering immediate operands, memory access
+ deisplacements, and branch offsets.
+
+ For regular get_by_id/put_by_id accesses to an object, a StructureID in an
+ instruction's immediate operant is updateded, and a memory access operation's
+ displacement is updated to access the correct field on the object. In the case
+ of more complex accesses (array length and get_by_id_prototype) the offset on
+ the branch to slow-case is updated, to now jump to a trampoline.
+
+ +2.8% sunspider, +13% v8-tests
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCall):
+ (JSC::CTI::emitJumpSlowCaseIfNotJSCell):
+ (JSC::CTI::CTI):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ (JSC::CTI::privateCompileArrayLengthTrampoline):
+ (JSC::CTI::privateCompileStringLengthTrampoline):
+ (JSC::CTI::patchGetByIdSelf):
+ (JSC::CTI::patchPutByIdReplace):
+ (JSC::CTI::privateCompilePatchGetArrayLength):
+ (JSC::CTI::privateCompilePatchGetStringLength):
+ * VM/CTI.h:
+ (JSC::CTI::compileGetByIdSelf):
+ (JSC::CTI::compileGetByIdProto):
+ (JSC::CTI::compileGetByIdChain):
+ (JSC::CTI::compilePutByIdReplace):
+ (JSC::CTI::compilePutByIdTransition):
+ (JSC::CTI::compileArrayLengthTrampoline):
+ (JSC::CTI::compileStringLengthTrampoline):
+ (JSC::CTI::compilePatchGetArrayLength):
+ (JSC::CTI::compilePatchGetStringLength):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::~CodeBlock):
+ * VM/CodeBlock.h:
+ (JSC::StructureStubInfo::StructureStubInfo):
+ (JSC::CodeBlock::getStubInfo):
+ * VM/Machine.cpp:
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::tryCTICacheGetByID):
+ (JSC::Machine::cti_op_put_by_val_array):
+ * VM/Machine.h:
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::cmpl_i8m):
+ (JSC::X86Assembler::emitUnlinkedJa):
+ (JSC::X86Assembler::getRelocatedAddress):
+ (JSC::X86Assembler::getDifferenceBetweenLabels):
+ (JSC::X86Assembler::emitModRm_opmsib):
+
+2008-09-14 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - split the "prototype" lookup for hasInstance into opcode stream so it can be cached
+
+ ~5% speedup on v8 earley-boyer test
+
+ * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
+ * API/JSCallbackObjectFunctions.h:
+ (JSC::::hasInstance): Ditto.
+ * API/JSValueRef.cpp:
+ (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass): Pass along prototype.
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump): Print third arg.
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
+ is a third argument.
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute): Pass along the prototype.
+ (JSC::Machine::cti_op_instanceof): ditto
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
+ * kjs/JSObject.h:
+ * kjs/nodes.cpp:
+ (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
+ property and pass that register to instanceof.
+ * kjs/nodes.h:
+
+2008-09-14 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove unnecessary virtual function call from cti_op_call_JSFunction -
+ ~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
+
+ * VM/Machine.cpp:
+ (JSC::Machine::cti_op_call_JSFunction):
+
+2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20827: the 'typeof' operator is slow
+ <https://bugs.webkit.org/show_bug.cgi?id=20827>
+
+ Optimize the 'typeof' operator when its result is compared to a constant
+ string.
+
+ This is a 5.5% speedup on the V8 Earley-Boyer test.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitEqualityOp):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::jsIsObjectType):
+ (JSC::jsIsFunctionType):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_is_undefined):
+ (JSC::Machine::cti_op_is_boolean):
+ (JSC::Machine::cti_op_is_number):
+ (JSC::Machine::cti_op_is_string):
+ (JSC::Machine::cti_op_is_object):
+ (JSC::Machine::cti_op_is_function):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+ * kjs/nodes.cpp:
+ (JSC::BinaryOpNode::emitCode):
+ (JSC::EqualNode::emitCode):
+ (JSC::StrictEqualNode::emitCode):
+ * kjs/nodes.h:
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
+ Speed up parseInt for numbers
+
+ Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
+ No change on the v8 suite.
+
+ * kjs/JSGlobalObjectFunctions.cpp:
+ (JSC::globalFuncParseInt): Don't convert numbers to strings just to
+ convert them back to numbers.
+
+2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20816: op_lesseq should be optimized
+ <https://bugs.webkit.org/show_bug.cgi?id=20816>
+
+ Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.
+
+ This is a 9.4% speedup on the V8 Crypto benchmark.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitJumpIfTrue):
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_loop_if_lesseq):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Cleanup Sampling code.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitCall):
+ (JSC::CTI::privateCompileMainPass):
+ * VM/CTI.h:
+ (JSC::CTI::execute):
+ * VM/SamplingTool.cpp:
+ (JSC::):
+ (JSC::SamplingTool::run):
+ (JSC::SamplingTool::dump):
+ * VM/SamplingTool.h:
+ (JSC::SamplingTool::callingHostFunction):
+
+2008-09-13 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 20821: Cache property transitions to speed up object initialization
+ https://bugs.webkit.org/show_bug.cgi?id=20821
+
+ Implement a transition cache to improve the performance of new properties
+ being added to objects. This is extremely beneficial in constructors and
+ shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
+ overall)
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::):
+ (JSC::transitionWillNeedStorageRealloc):
+ (JSC::CTI::privateCompilePutByIdTransition):
+ * VM/CTI.h:
+ (JSC::CTI::compilePutByIdTransition):
+ * VM/CodeBlock.cpp:
+ (JSC::printPutByIdOp):
+ (JSC::CodeBlock::printStructureIDs):
+ (JSC::CodeBlock::dump):
+ (JSC::CodeBlock::derefStructureIDs):
+ (JSC::CodeBlock::refStructureIDs):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::emitPutById):
+ * VM/Machine.cpp:
+ (JSC::cachePrototypeChain):
+ (JSC::Machine::tryCachePutByID):
+ (JSC::Machine::tryCacheGetByID):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::tryCTICacheGetByID):
+ * VM/Machine.h:
+ * VM/Opcode.h:
+ * kjs/JSObject.h:
+ (JSC::JSObject::putDirect):
+ (JSC::JSObject::transitionTo):
+ * kjs/PutPropertySlot.h:
+ (JSC::PutPropertySlot::PutPropertySlot):
+ (JSC::PutPropertySlot::wasTransition):
+ (JSC::PutPropertySlot::setWasTransition):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::transitionTo):
+ (JSC::StructureIDChain::StructureIDChain):
+ * kjs/StructureID.h:
+ (JSC::StructureID::previousID):
+ (JSC::StructureID::setCachedPrototypeChain):
+ (JSC::StructureID::cachedPrototypeChain):
+ (JSC::StructureID::propertyMap):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::addl_i8m):
+ (JSC::X86Assembler::subl_i8m):
+
+2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20819: JSValue::isObject() is slow
+ <https://bugs.webkit.org/show_bug.cgi?id=20819>
+
+ Optimize JSCell::isObject() and JSCell::isString() by making them
+ non-virtual calls that rely on the StructureID type information.
+
+ This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
+ benchmark suite.
+
+ * JavaScriptCore.exp:
+ * kjs/JSCell.cpp:
+ * kjs/JSCell.h:
+ (JSC::JSCell::isObject):
+ (JSC::JSCell::isString):
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ * kjs/JSString.cpp:
+ * kjs/JSString.h:
+ (JSC::JSString::JSString):
+ * kjs/StructureID.h:
+ (JSC::StructureID::type):
+
+2008-09-11 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
+ crash on CNN and on Dromaeo.
+ Fix Missing close tag in vcproj.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+
+2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Not reviewed.
+
+ Correct an SVN problem with the last commit and actually add the new
+ files.
+
+ * wrec/CharacterClassConstructor.cpp: Added.
+ (JSC::):
+ (JSC::getCharacterClassNewline):
+ (JSC::getCharacterClassDigits):
+ (JSC::getCharacterClassSpaces):
+ (JSC::getCharacterClassWordchar):
+ (JSC::getCharacterClassNondigits):
+ (JSC::getCharacterClassNonspaces):
+ (JSC::getCharacterClassNonwordchar):
+ (JSC::CharacterClassConstructor::addSorted):
+ (JSC::CharacterClassConstructor::addSortedRange):
+ (JSC::CharacterClassConstructor::put):
+ (JSC::CharacterClassConstructor::flush):
+ (JSC::CharacterClassConstructor::append):
+ * wrec/CharacterClassConstructor.h: Added.
+ (JSC::CharacterClassConstructor::CharacterClassConstructor):
+ (JSC::CharacterClassConstructor::isUpsideDown):
+ (JSC::CharacterClassConstructor::charClass):
+
+2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20788: Split CharacterClassConstructor into its own file
+ <https://bugs.webkit.org/show_bug.cgi?id=20788>
+
+ Split CharacterClassConstructor into its own file and clean up some
+ style issues.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * wrec/CharacterClassConstructor.cpp: Added.
+ (JSC::):
+ (JSC::getCharacterClassNewline):
+ (JSC::getCharacterClassDigits):
+ (JSC::getCharacterClassSpaces):
+ (JSC::getCharacterClassWordchar):
+ (JSC::getCharacterClassNondigits):
+ (JSC::getCharacterClassNonspaces):
+ (JSC::getCharacterClassNonwordchar):
+ (JSC::CharacterClassConstructor::addSorted):
+ (JSC::CharacterClassConstructor::addSortedRange):
+ (JSC::CharacterClassConstructor::put):
+ (JSC::CharacterClassConstructor::flush):
+ (JSC::CharacterClassConstructor::append):
+ * wrec/CharacterClassConstructor.h: Added.
+ (JSC::CharacterClassConstructor::CharacterClassConstructor):
+ (JSC::CharacterClassConstructor::isUpsideDown):
+ (JSC::CharacterClassConstructor::charClass):
+ * wrec/WREC.cpp:
+ (JSC::WRECParser::parseCharacterClass):
+
+2008-09-10 Simon Hausmann <hausmann@webkit.org>
+
+ Not reviewed but trivial one-liner for yet unused macro.
+
+ Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.
+
+ (part of https://bugs.webkit.org/show_bug.cgi?id=20746)
+
+ * wtf/Platform.h:
+
+2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Fix a typo by renaming the overloaded orl_rr that takes an immediate to
+ orl_i32r.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::orl_i32r):
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generatePatternCharacter):
+ (JSC::WRECGenerator::generateCharacterClassInverted):
+
+2008-09-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Add inline property storage for JSObject.
+
+ 1.2% progression on Sunspider. .5% progression on the v8 test suite.
+
+ * JavaScriptCore.exp:
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::mark): There is no reason to check storageSize now that
+ we start from 0.
+ (JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
+ * kjs/JSObject.h:
+ (JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr
+ now so there is no reason to .get()
+ (JSC::JSObject::usingInlineStorage):
+ (JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the
+ inline storage.
+ (JSC::JSObject::~JSObject): Free the heap storage if not using the inline
+ storage.
+ (JSC::JSObject::putDirect): Switch to the heap storage only when we know
+ we know that we are about to add a property that will overflow the inline
+ storage.
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is
+ now handled by JSObject.
+ (JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMap::storageSize): Rename from markingCount.
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::addPropertyTransition): Don't resize the property storage
+ if we are using inline storage.
+ * kjs/StructureID.h:
+
+2008-09-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Inline immediate number version of op_mul.
+
+ Renamed mull_rr to imull_rr as that's what it's
+ actually doing, and added imull_i32r for the constant
+ case immediate multiply.
+
+ 1.1% improvement to SunSpider.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::):
+ (JSC::X86Assembler::imull_rr):
+ (JSC::X86Assembler::imull_i32r):
+
+2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Not reviewed.
+
+ Mac build fix.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-09-09 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add optimised access to known properties on the global object.
+
+ Improve cross scope access to the global object by emitting
+ code to access it directly rather than by walking the scope chain.
+
+ This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::emitGetVariableObjectRegister):
+ (JSC::CTI::emitPutVariableObjectRegister):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (JSC::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (JSC::CodeGenerator::findScopedProperty):
+ (JSC::CodeGenerator::emitResolve):
+ (JSC::CodeGenerator::emitGetScopedVar):
+ (JSC::CodeGenerator::emitPutScopedVar):
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (JSC::Machine::privateExecute):
+ * VM/Opcode.h:
+ * kjs/nodes.cpp:
+ (JSC::FunctionCallResolveNode::emitCode):
+ (JSC::PostfixResolveNode::emitCode):
+ (JSC::PrefixResolveNode::emitCode):
+ (JSC::ReadModifyResolveNode::emitCode):
+ (JSC::AssignResolveNode::emitCode):
+
+2008-09-10 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Oliver.
+
+ - enable polymorphic inline caching of properties of primitives
+
+ 1.012x speedup on SunSpider.
+
+ We create special structure IDs for JSString and
+ JSNumberCell. Unlike normal structure IDs, these cannot hold the
+ true prototype. Due to JS autoboxing semantics, the prototype used
+ when looking up string or number properties depends on the lexical
+ global object of the call site, not the creation site. Thus we
+ enable StructureIDs to handle this quirk for primitives.
+
+ Everything else should be straightforward.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ * VM/CTI.h:
+ (JSC::CTI::compileGetByIdProto):
+ (JSC::CTI::compileGetByIdChain):
+ * VM/JSPropertyNameIterator.h:
+ (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
+ * VM/Machine.cpp:
+ (JSC::Machine::Machine):
+ (JSC::cachePrototypeChain):
+ (JSC::Machine::tryCachePutByID):
+ (JSC::Machine::tryCacheGetByID):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::tryCTICachePutByID):
+ (JSC::Machine::tryCTICacheGetByID):
+ * kjs/GetterSetter.h:
+ (JSC::GetterSetter::GetterSetter):
+ * kjs/JSCell.h:
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.h:
+ (JSC::StructureID::prototypeForLookup):
+ * kjs/JSNumberCell.h:
+ (JSC::JSNumberCell::JSNumberCell):
+ (JSC::jsNumberCell):
+ * kjs/JSObject.h:
+ (JSC::JSObject::prototype):
+ * kjs/JSString.cpp:
+ (JSC::jsString):
+ (JSC::jsSubstring):
+ (JSC::jsOwnedString):
+ * kjs/JSString.h:
+ (JSC::JSString::JSString):
+ (JSC::JSString::):
+ (JSC::jsSingleCharacterString):
+ (JSC::jsSingleCharacterSubstring):
+ (JSC::jsNontrivialString):
+ * kjs/SmallStrings.cpp:
+ (JSC::SmallStrings::createEmptyString):
+ (JSC::SmallStrings::createSingleCharacterString):
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::StructureID):
+ (JSC::StructureID::addPropertyTransition):
+ (JSC::StructureID::getterSetterTransition):
+ (JSC::StructureIDChain::StructureIDChain):
+ * kjs/StructureID.h:
+ (JSC::StructureID::create):
+ (JSC::StructureID::storedPrototype):
+
+2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20746
+
+ Added WINCE platform macro.
+
+ * wtf/Platform.h:
+
+2008-09-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Remove unnecessary override of getOffset.
+
+ Sunspider reports this as a .6% progression.
+
+ * JavaScriptCore.exp:
+ * kjs/JSObject.h:
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::getOwnPropertySlotForWrite):
+ (JSC::JSObject::putDirect):
+ * kjs/PropertyMap.cpp:
+ * kjs/PropertyMap.h:
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20759: Remove MacroAssembler
+ <https://bugs.webkit.org/show_bug.cgi?id=20759>
+
+ Remove MacroAssembler and move its functionality to X86Assembler.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::emitPutArg):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutResult):
+ (JSC::CTI::emitDebugExceptionCheck):
+ (JSC::CTI::emitJumpSlowCaseIfNotImm):
+ (JSC::CTI::emitJumpSlowCaseIfNotImms):
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithReTagImmediate):
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ (JSC::CTI::emitFastArithImmToInt):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::emitFastArithIntToImmNoCheck):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateArrayLengthTrampoline):
+ (JSC::CTI::privateStringLengthTrampoline):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ (JSC::CallRecord::CallRecord):
+ (JSC::JmpTable::JmpTable):
+ (JSC::SlowCaseEntry::SlowCaseEntry):
+ (JSC::CTI::JSRInfo::JSRInfo):
+ * masm/MacroAssembler.h: Removed.
+ * masm/MacroAssemblerWin.cpp: Removed.
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::emitConvertToFastCall):
+ (JSC::X86Assembler::emitRestoreArgumentReference):
+ * wrec/WREC.h:
+ (JSC::WRECGenerator::WRECGenerator):
+ (JSC::WRECParser::WRECParser):
+
+2008-09-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Don't waste the first item in the PropertyStorage.
+
+ - Fix typo (makingCount -> markingCount)
+ - Remove undefined method declaration.
+
+ No change on Sunspider.
+
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::mark):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::put):
+ (JSC::PropertyMap::remove):
+ (JSC::PropertyMap::getOffset):
+ (JSC::PropertyMap::insert):
+ (JSC::PropertyMap::rehash):
+ (JSC::PropertyMap::resizePropertyStorage):
+ (JSC::PropertyMap::checkConsistency):
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMap::markingCount): Fix typo.
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Not reviewed.
+
+ Speculative Windows build fix.
+
+ * masm/MacroAssemblerWin.cpp:
+ (JSC::MacroAssembler::emitConvertToFastCall):
+ (JSC::MacroAssembler::emitRestoreArgumentReference):
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20755: Create an X86 namespace for register names and other things
+ <https://bugs.webkit.org/show_bug.cgi?id=20755>
+
+ Create an X86 namespace to put X86 register names. Perhaps I will move
+ opcode names here later as well.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::emitPutArg):
+ (JSC::CTI::emitPutArgConstant):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutResult):
+ (JSC::CTI::emitDebugExceptionCheck):
+ (JSC::CTI::emitJumpSlowCaseIfNotImms):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateArrayLengthTrampoline):
+ (JSC::CTI::privateStringLengthTrampoline):
+ (JSC::CTI::compileRegExp):
+ * VM/CTI.h:
+ * masm/X86Assembler.h:
+ (JSC::X86::):
+ (JSC::X86Assembler::emitModRm_rm):
+ (JSC::X86Assembler::emitModRm_rm_Unchecked):
+ (JSC::X86Assembler::emitModRm_rmsib):
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generateNonGreedyQuantifier):
+ (JSC::WRECGenerator::generateGreedyQuantifier):
+ (JSC::WRECGenerator::generateParentheses):
+ (JSC::WRECGenerator::generateBackreference):
+ (JSC::WRECGenerator::gernerateDisjunction):
+ * wrec/WREC.h:
+
+2008-09-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Remove unnecessary friend declaration.
+
+ * kjs/PropertyMap.h:
+
+2008-09-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Replace uses of PropertyMap::get and PropertyMap::getLocation with
+ PropertyMap::getOffset.
+
+ Sunspider reports this as a .6% improvement.
+
+ * JavaScriptCore.exp:
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::put):
+ (JSC::JSObject::deleteProperty):
+ (JSC::JSObject::getPropertyAttributes):
+ * kjs/JSObject.h:
+ (JSC::JSObject::getDirect):
+ (JSC::JSObject::getDirectLocation):
+ (JSC::JSObject::locationForOffset):
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMap::remove):
+ (JSC::PropertyMap::getOffset):
+ * kjs/PropertyMap.h:
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Sam Weinig.
+
+ Bug 20754: Remove emit prefix from assembler opcode methods
+ <https://bugs.webkit.org/show_bug.cgi?id=20754>
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitGetArg):
+ (JSC::CTI::emitGetPutArg):
+ (JSC::CTI::emitPutArg):
+ (JSC::CTI::emitPutArgConstant):
+ (JSC::CTI::emitPutCTIParam):
+ (JSC::CTI::emitGetCTIParam):
+ (JSC::CTI::emitPutToCallFrameHeader):
+ (JSC::CTI::emitGetFromCallFrameHeader):
+ (JSC::CTI::emitPutResult):
+ (JSC::CTI::emitDebugExceptionCheck):
+ (JSC::CTI::emitCall):
+ (JSC::CTI::emitJumpSlowCaseIfNotImm):
+ (JSC::CTI::emitJumpSlowCaseIfNotImms):
+ (JSC::CTI::emitFastArithDeTagImmediate):
+ (JSC::CTI::emitFastArithReTagImmediate):
+ (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
+ (JSC::CTI::emitFastArithImmToInt):
+ (JSC::CTI::emitFastArithIntToImmOrSlowCase):
+ (JSC::CTI::emitFastArithIntToImmNoCheck):
+ (JSC::CTI::compileOpCall):
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ (JSC::CTI::privateCompile):
+ (JSC::CTI::privateCompileGetByIdSelf):
+ (JSC::CTI::privateCompileGetByIdProto):
+ (JSC::CTI::privateCompileGetByIdChain):
+ (JSC::CTI::privateCompilePutByIdReplace):
+ (JSC::CTI::privateArrayLengthTrampoline):
+ (JSC::CTI::privateStringLengthTrampoline):
+ (JSC::CTI::compileRegExp):
+ * masm/MacroAssemblerWin.cpp:
+ (JSC::MacroAssembler::emitConvertToFastCall):
+ (JSC::MacroAssembler::emitRestoreArgumentReference):
+ * masm/X86Assembler.h:
+ (JSC::X86Assembler::pushl_r):
+ (JSC::X86Assembler::pushl_m):
+ (JSC::X86Assembler::popl_r):
+ (JSC::X86Assembler::popl_m):
+ (JSC::X86Assembler::movl_rr):
+ (JSC::X86Assembler::addl_rr):
+ (JSC::X86Assembler::addl_i8r):
+ (JSC::X86Assembler::addl_i32r):
+ (JSC::X86Assembler::addl_mr):
+ (JSC::X86Assembler::andl_rr):
+ (JSC::X86Assembler::andl_i32r):
+ (JSC::X86Assembler::cmpl_i8r):
+ (JSC::X86Assembler::cmpl_rr):
+ (JSC::X86Assembler::cmpl_rm):
+ (JSC::X86Assembler::cmpl_i32r):
+ (JSC::X86Assembler::cmpl_i32m):
+ (JSC::X86Assembler::cmpw_rm):
+ (JSC::X86Assembler::orl_rr):
+ (JSC::X86Assembler::subl_rr):
+ (JSC::X86Assembler::subl_i8r):
+ (JSC::X86Assembler::subl_i32r):
+ (JSC::X86Assembler::subl_mr):
+ (JSC::X86Assembler::testl_i32r):
+ (JSC::X86Assembler::testl_rr):
+ (JSC::X86Assembler::xorl_i8r):
+ (JSC::X86Assembler::xorl_rr):
+ (JSC::X86Assembler::sarl_i8r):
+ (JSC::X86Assembler::sarl_CLr):
+ (JSC::X86Assembler::shl_i8r):
+ (JSC::X86Assembler::shll_CLr):
+ (JSC::X86Assembler::mull_rr):
+ (JSC::X86Assembler::idivl_r):
+ (JSC::X86Assembler::cdq):
+ (JSC::X86Assembler::movl_mr):
+ (JSC::X86Assembler::movzwl_mr):
+ (JSC::X86Assembler::movl_rm):
+ (JSC::X86Assembler::movl_i32r):
+ (JSC::X86Assembler::movl_i32m):
+ (JSC::X86Assembler::leal_mr):
+ (JSC::X86Assembler::ret):
+ (JSC::X86Assembler::jmp_r):
+ (JSC::X86Assembler::jmp_m):
+ (JSC::X86Assembler::call_r):
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generateBacktrack1):
+ (JSC::WRECGenerator::generateBacktrackBackreference):
+ (JSC::WRECGenerator::generateBackreferenceQuantifier):
+ (JSC::WRECGenerator::generateNonGreedyQuantifier):
+ (JSC::WRECGenerator::generateGreedyQuantifier):
+ (JSC::WRECGenerator::generatePatternCharacter):
+ (JSC::WRECGenerator::generateCharacterClassInvertedRange):
+ (JSC::WRECGenerator::generateCharacterClassInverted):
+ (JSC::WRECGenerator::generateCharacterClass):
+ (JSC::WRECGenerator::generateParentheses):
+ (JSC::WRECGenerator::gererateParenthesesResetTrampoline):
+ (JSC::WRECGenerator::generateAssertionBOL):
+ (JSC::WRECGenerator::generateAssertionEOL):
+ (JSC::WRECGenerator::generateAssertionWordBoundary):
+ (JSC::WRECGenerator::generateBackreference):
+ (JSC::WRECGenerator::gernerateDisjunction):
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Clean up the WREC code some more.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::compileRegExp):
+ * wrec/WREC.cpp:
+ (JSC::getCharacterClassNewline):
+ (JSC::getCharacterClassDigits):
+ (JSC::getCharacterClassSpaces):
+ (JSC::getCharacterClassWordchar):
+ (JSC::getCharacterClassNondigits):
+ (JSC::getCharacterClassNonspaces):
+ (JSC::getCharacterClassNonwordchar):
+ (JSC::WRECGenerator::generateBacktrack1):
+ (JSC::WRECGenerator::generateBacktrackBackreference):
+ (JSC::WRECGenerator::generateBackreferenceQuantifier):
+ (JSC::WRECGenerator::generateNonGreedyQuantifier):
+ (JSC::WRECGenerator::generateGreedyQuantifier):
+ (JSC::WRECGenerator::generatePatternCharacter):
+ (JSC::WRECGenerator::generateCharacterClassInvertedRange):
+ (JSC::WRECGenerator::generateCharacterClassInverted):
+ (JSC::WRECGenerator::generateCharacterClass):
+ (JSC::WRECGenerator::generateParentheses):
+ (JSC::WRECGenerator::gererateParenthesesResetTrampoline):
+ (JSC::WRECGenerator::generateAssertionBOL):
+ (JSC::WRECGenerator::generateAssertionEOL):
+ (JSC::WRECGenerator::generateAssertionWordBoundary):
+ (JSC::WRECGenerator::generateBackreference):
+ (JSC::WRECGenerator::gernerateDisjunction):
+ (JSC::WRECParser::parseCharacterClass):
+ (JSC::WRECParser::parseEscape):
+ (JSC::WRECParser::parseTerm):
+ * wrec/WREC.h:
+
+2008-09-09 Mark Rowe <mrowe@apple.com>
+
+ Build fix, rubber-stamped by Anders Carlsson.
+
+ Silence spurious build warnings about missing format attributes on functions in Assertions.cpp.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-09-09 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Fix builds using the "debug" variant.
+
+ This reverts r36130 and tweaks Identifier to export the same symbols for Debug
+ and Release configurations.
+
+ * Configurations/JavaScriptCore.xcconfig:
+ * DerivedSources.make:
+ * JavaScriptCore.Debug.exp: Removed.
+ * JavaScriptCore.base.exp: Removed.
+ * JavaScriptCore.exp: Added.
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/identifier.cpp:
+ (JSC::Identifier::addSlowCase): #ifdef the call to checkSameIdentifierTable so that
+ there is no overhead in Release builds.
+ (JSC::Identifier::checkSameIdentifierTable): Add empty functions for Release builds.
+ * kjs/identifier.h:
+ (JSC::Identifier::add): #ifdef the calls to checkSameIdentifierTable so that there is
+ no overhead in Release builds, and remove the inline definitions of checkSameIdentifierTable.
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Clean up WREC a bit to bring it closer to our coding style guidelines.
+
+ * wrec/WREC.cpp:
+ (JSC::):
+ (JSC::getCharacterClass_newline):
+ (JSC::getCharacterClass_d):
+ (JSC::getCharacterClass_s):
+ (JSC::getCharacterClass_w):
+ (JSC::getCharacterClass_D):
+ (JSC::getCharacterClass_S):
+ (JSC::getCharacterClass_W):
+ (JSC::CharacterClassConstructor::append):
+ (JSC::WRECGenerator::generateNonGreedyQuantifier):
+ (JSC::WRECGenerator::generateGreedyQuantifier):
+ (JSC::WRECGenerator::generateCharacterClassInverted):
+ (JSC::WRECParser::parseQuantifier):
+ (JSC::WRECParser::parsePatternCharacterQualifier):
+ (JSC::WRECParser::parseCharacterClassQuantifier):
+ (JSC::WRECParser::parseBackreferenceQuantifier):
+ * wrec/WREC.h:
+ (JSC::Quantifier::):
+ (JSC::Quantifier::Quantifier):
+
+2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Try MIME charset names before trying IANA names
+ ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
+
+ * wtf/StringExtras.h: (strcasecmp): Added.
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Mark Rowe.
+
+ Bug 20719: REGRESSION (r36135-36244): Hangs, then crashes after several seconds
+ <https://bugs.webkit.org/show_bug.cgi?id=20719>
+ <rdar://problem/6205787>
+
+ Fix a typo in the case-insensitive matching of character patterns.
+
+ * wrec/WREC.cpp:
+ (JSC::WRECGenerator::generatePatternCharacter):
+
+2008-09-09 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - allow polymorphic inline cache to handle Math object functions and possibly other similar things
+
+ 1.012x speedup on SunSpider.
+
+ * kjs/MathObject.cpp:
+ (JSC::MathObject::getOwnPropertySlot):
+ * kjs/lookup.cpp:
+ (JSC::setUpStaticFunctionSlot):
+ * kjs/lookup.h:
+ (JSC::getStaticPropertySlot):
+
+2008-09-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak and Oliver Hunt.
+
+ Split storage of properties out of the PropertyMap and into the JSObject
+ to allow sharing PropertyMap on the StructureID. In order to get this
+ function correctly, the StructureID's transition mappings were changed to
+ transition based on property name and attribute pairs, instead of just
+ property name.
+
+ - Removes the single property optimization now that the PropertyMap is shared.
+ This will be replaced by in-lining some values on the JSObject.
+
+ This is a wash on Sunspider and a 6.7% win on the v8 test suite.
+
+ * JavaScriptCore.base.exp:
+ * VM/CTI.cpp:
+ (JSC::CTI::privateCompileGetByIdSelf): Get the storage directly off the JSObject.
+ (JSC::CTI::privateCompileGetByIdProto): Ditto.
+ (JSC::CTI::privateCompileGetByIdChain): Ditto.
+ (JSC::CTI::privateCompilePutByIdReplace): Ditto.
+ * kjs/JSObject.cpp:
+ (JSC::JSObject::mark): Mark the PropertyStorage.
+ (JSC::JSObject::put): Update to get the propertyMap of the StructureID.
+ (JSC::JSObject::deleteProperty): Ditto.
+ (JSC::JSObject::defineGetter): Return early if the property is already a getter/setter.
+ (JSC::JSObject::defineSetter): Ditto.
+ (JSC::JSObject::getPropertyAttributes): Update to get the propertyMap of the StructureID
+ (JSC::JSObject::getPropertyNames): Ditto.
+ (JSC::JSObject::removeDirect): Ditto.
+ * kjs/JSObject.h: Remove PropertyMap and add PropertyStorage.
+ (JSC::JSObject::propertyStorage): return the PropertyStorage.
+ (JSC::JSObject::getDirect): Update to get the propertyMap of the StructureID.
+ (JSC::JSObject::getDirectLocation): Ditto.
+ (JSC::JSObject::offsetForLocation): Compute location directly.
+ (JSC::JSObject::hasCustomProperties): Update to get the propertyMap of the StructureID.
+ (JSC::JSObject::hasGetterSetterProperties): Ditto.
+ (JSC::JSObject::getDirectOffset): Get by indexing into PropertyStorage.
+ (JSC::JSObject::putDirectOffset): Put by indexing into PropertyStorage.
+ (JSC::JSObject::getOwnPropertySlotForWrite): Update to get the propertyMap of the StructureID.
+ (JSC::JSObject::getOwnPropertySlot): Ditto.
+ (JSC::JSObject::putDirect): Move putting into the StructureID unless the property already exists.
+ * kjs/PropertyMap.cpp: Use the propertyStorage as the storage for the JSValues.
+ (JSC::PropertyMap::checkConsistency):
+ (JSC::PropertyMap::operator=):
+ (JSC::PropertyMap::~PropertyMap):
+ (JSC::PropertyMap::get):
+ (JSC::PropertyMap::getLocation):
+ (JSC::PropertyMap::put):
+ (JSC::PropertyMap::getOffset):
+ (JSC::PropertyMap::insert):
+ (JSC::PropertyMap::expand):
+ (JSC::PropertyMap::rehash):
+ (JSC::PropertyMap::createTable):
+ (JSC::PropertyMap::resizePropertyStorage): Resize the storage to match the size of the map
+ (JSC::PropertyMap::remove):
+ (JSC::PropertyMap::getEnumerablePropertyNames):
+ * kjs/PropertyMap.h:
+ (JSC::PropertyMapEntry::PropertyMapEntry):
+ (JSC::PropertyMap::isEmpty):
+ (JSC::PropertyMap::size):
+ (JSC::PropertyMap::makingCount):
+ (JSC::PropertyMap::PropertyMap):
+
+ * kjs/StructureID.cpp:
+ (JSC::StructureID::addPropertyTransition): Transitions now are based off the property name
+ and attributes.
+ (JSC::StructureID::toDictionaryTransition): Copy the map.
+ (JSC::StructureID::changePrototypeTransition): Copy the map.
+ (JSC::StructureID::getterSetterTransition): Copy the map.
+ (JSC::StructureID::~StructureID):
+ * kjs/StructureID.h:
+ (JSC::TransitionTableHash::hash): Custom hash for transition map.
+ (JSC::TransitionTableHash::equal): Ditto.
+ (JSC::TransitionTableHashTraits::emptyValue): Custom traits for transition map
+ (JSC::TransitionTableHashTraits::constructDeletedValue): Ditto.
+ (JSC::TransitionTableHashTraits::isDeletedValue): Ditto.
+ (JSC::StructureID::propertyMap): Added.
+
+2008-09-08 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 20694: Slow Script error pops up when running Dromaeo tests
+
+ Correct error in timeout logic where execution tick count would
+ be reset to incorrect value due to incorrect offset and indirection.
+ Codegen for the slow script dialog was factored out into a separate
+ method (emitSlowScriptCheck) rather than having multiple copies of
+ the same code. Also added calls to generate slow script checks
+ for loop_if_less and loop_if_true opcodes.
+
+ * VM/CTI.cpp:
+ (JSC::CTI::emitSlowScriptCheck):
+ (JSC::CTI::privateCompileMainPass):
+ (JSC::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+
+2008-09-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove references to the removed WRECompiler class.
+
+ * VM/Machine.h:
+ * wrec/WREC.h:
+
+2008-09-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Mark Rowe.
+
+ Fix the build with CTI enabled but WREC disabled.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+
+2008-09-08 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * kjs/nodes.h:
+ (JSC::StatementNode::):
+ (JSC::BlockNode::):
+
+2008-09-08 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff.
+
+ <rdar://problem/6134407> Breakpoints in for loops, while loops or
+ conditions without curly braces don't break. (19306)
+ -Statement Lists already emit debug hooks but conditionals without
+ brackets are not lists.
+
+ * kjs/nodes.cpp:
+ (KJS::IfNode::emitCode):
+ (KJS::IfElseNode::emitCode):
+ (KJS::DoWhileNode::emitCode):
+ (KJS::WhileNode::emitCode):
+ (KJS::ForNode::emitCode):
+ (KJS::ForInNode::emitCode):
+ * kjs/nodes.h:
+ (KJS::StatementNode::):
+ (KJS::BlockNode::):
+
+2008-09-08 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - Cache the code generated for eval to speed up SunSpider and web sites
+ https://bugs.webkit.org/show_bug.cgi?id=20718
+
+ 1.052x on SunSpider
+ 2.29x on date-format-tofte
+
+ Lots of real sites seem to get many hits on this cache as well,
+ including GMail, Google Spreadsheets, Slate and Digg (the last of
+ these gets over 100 hits on initial page load).
+
+ * VM/CodeBlock.h:
+ (JSC::EvalCodeCache::get):
+ * VM/Machine.cpp:
+ (JSC::Machine::callEval):
+ (JSC::Machine::privateExecute):
+ (JSC::Machine::cti_op_call_eval):
+ * VM/Machine.h:
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20711: Change KJS prefix on preprocessor macros to JSC
+ <https://bugs.webkit.org/show_bug.cgi?id=20711>
+
+ * kjs/CommonIdentifiers.cpp:
+ (JSC::CommonIdentifiers::CommonIdentifiers):
+ * kjs/CommonIdentifiers.h:
+ * kjs/PropertySlot.h:
+ (JSC::PropertySlot::getValue):
+ (JSC::PropertySlot::putValue):
+ (JSC::PropertySlot::setValueSlot):
+ (JSC::PropertySlot::setValue):
+ (JSC::PropertySlot::setRegisterSlot):
+ * kjs/lookup.h:
+ * kjs/nodes.cpp:
+ * kjs/nodes.h:
+ (JSC::Node::):
+ (JSC::ExpressionNode::):
+ (JSC::StatementNode::):
+ (JSC::NullNode::):
+ (JSC::BooleanNode::):
+ (JSC::NumberNode::):
+ (JSC::ImmediateNumberNode::):
+ (JSC::StringNode::):
+ (JSC::RegExpNode::):
+ (JSC::ThisNode::):
+ (JSC::ResolveNode::):
+ (JSC::ElementNode::):
+ (JSC::ArrayNode::):
+ (JSC::PropertyNode::):
+ (JSC::PropertyListNode::):
+ (JSC::ObjectLiteralNode::):
+ (JSC::BracketAccessorNode::):
+ (JSC::DotAccessorNode::):
+ (JSC::ArgumentListNode::):
+ (JSC::ArgumentsNode::):
+ (JSC::NewExprNode::):
+ (JSC::EvalFunctionCallNode::):
+ (JSC::FunctionCallValueNode::):
+ (JSC::FunctionCallResolveNode::):
+ (JSC::FunctionCallBracketNode::):
+ (JSC::FunctionCallDotNode::):
+ (JSC::PrePostResolveNode::):
+ (JSC::PostfixResolveNode::):
+ (JSC::PostfixBracketNode::):
+ (JSC::PostfixDotNode::):
+ (JSC::PostfixErrorNode::):
+ (JSC::DeleteResolveNode::):
+ (JSC::DeleteBracketNode::):
+ (JSC::DeleteDotNode::):
+ (JSC::DeleteValueNode::):
+ (JSC::VoidNode::):
+ (JSC::TypeOfResolveNode::):
+ (JSC::TypeOfValueNode::):
+ (JSC::PrefixResolveNode::):
+ (JSC::PrefixBracketNode::):
+ (JSC::PrefixDotNode::):
+ (JSC::PrefixErrorNode::):
+ (JSC::UnaryPlusNode::):
+ (JSC::NegateNode::):
+ (JSC::BitwiseNotNode::):
+ (JSC::LogicalNotNode::):
+ (JSC::MultNode::):
+ (JSC::DivNode::):
+ (JSC::ModNode::):
+ (JSC::AddNode::):
+ (JSC::SubNode::):
+ (JSC::LeftShiftNode::):
+ (JSC::RightShiftNode::):
+ (JSC::UnsignedRightShiftNode::):
+ (JSC::LessNode::):
+ (JSC::GreaterNode::):
+ (JSC::LessEqNode::):
+ (JSC::GreaterEqNode::):
+ (JSC::ThrowableBinaryOpNode::):
+ (JSC::InstanceOfNode::):
+ (JSC::InNode::):
+ (JSC::EqualNode::):
+ (JSC::NotEqualNode::):
+ (JSC::StrictEqualNode::):
+ (JSC::NotStrictEqualNode::):
+ (JSC::BitAndNode::):
+ (JSC::BitOrNode::):
+ (JSC::BitXOrNode::):
+ (JSC::LogicalOpNode::):
+ (JSC::ConditionalNode::):
+ (JSC::ReadModifyResolveNode::):
+ (JSC::AssignResolveNode::):
+ (JSC::ReadModifyBracketNode::):
+ (JSC::AssignBracketNode::):
+ (JSC::AssignDotNode::):
+ (JSC::ReadModifyDotNode::):
+ (JSC::AssignErrorNode::):
+ (JSC::CommaNode::):
+ (JSC::VarDeclCommaNode::):
+ (JSC::ConstDeclNode::):
+ (JSC::ConstStatementNode::):
+ (JSC::EmptyStatementNode::):
+ (JSC::DebuggerStatementNode::):
+ (JSC::ExprStatementNode::):
+ (JSC::VarStatementNode::):
+ (JSC::IfNode::):
+ (JSC::IfElseNode::):
+ (JSC::DoWhileNode::):
+ (JSC::WhileNode::):
+ (JSC::ForNode::):
+ (JSC::ContinueNode::):
+ (JSC::BreakNode::):
+ (JSC::ReturnNode::):
+ (JSC::WithNode::):
+ (JSC::LabelNode::):
+ (JSC::ThrowNode::):
+ (JSC::TryNode::):
+ (JSC::ParameterNode::):
+ (JSC::ScopeNode::):
+ (JSC::ProgramNode::):
+ (JSC::EvalNode::):
+ (JSC::FunctionBodyNode::):
+ (JSC::FuncExprNode::):
+ (JSC::FuncDeclNode::):
+ (JSC::CaseClauseNode::):
+ (JSC::ClauseListNode::):
+ (JSC::CaseBlockNode::):
+ (JSC::SwitchNode::):
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20704: Replace the KJS namespace
+ <https://bugs.webkit.org/show_bug.cgi?id=20704>
+
+ Rename the KJS namespace to JSC. There are still some uses of KJS in
+ preprocessor macros and comments, but these will also be changed some
+ time in the near future.
+
+ * API/APICast.h:
+ (toJS):
+ (toRef):
+ (toGlobalRef):
+ * API/JSBase.cpp:
+ * API/JSCallbackConstructor.cpp:
+ * API/JSCallbackConstructor.h:
+ * API/JSCallbackFunction.cpp:
+ * API/JSCallbackFunction.h:
+ * API/JSCallbackObject.cpp:
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ * API/JSClassRef.cpp:
+ (OpaqueJSClass::staticValues):
+ (OpaqueJSClass::staticFunctions):
+ * API/JSClassRef.h:
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ * API/JSProfilerPrivate.cpp:
+ * API/JSStringRef.cpp:
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ * API/OpaqueJSString.cpp:
+ * API/OpaqueJSString.h:
+ * JavaScriptCore.Debug.exp:
+ * JavaScriptCore.base.exp:
+ * VM/CTI.cpp:
+ (JSC::):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ * VM/CodeGenerator.h:
+ * VM/ExceptionHelpers.cpp:
+ * VM/ExceptionHelpers.h:
+ * VM/Instruction.h:
+ * VM/JSPropertyNameIterator.cpp:
+ * VM/JSPropertyNameIterator.h:
+ * VM/LabelID.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * VM/Opcode.cpp:
+ * VM/Opcode.h:
+ * VM/Register.h:
+ (WTF::):
+ * VM/RegisterFile.cpp:
+ * VM/RegisterFile.h:
+ * VM/RegisterID.h:
+ (WTF::):
+ * VM/SamplingTool.cpp:
+ * VM/SamplingTool.h:
+ * VM/SegmentedVector.h:
+ * kjs/ArgList.cpp:
+ * kjs/ArgList.h:
+ * kjs/Arguments.cpp:
+ * kjs/Arguments.h:
+ * kjs/ArrayConstructor.cpp:
+ * kjs/ArrayConstructor.h:
+ * kjs/ArrayPrototype.cpp:
+ * kjs/ArrayPrototype.h:
+ * kjs/BatchedTransitionOptimizer.h:
+ * kjs/BooleanConstructor.cpp:
+ * kjs/BooleanConstructor.h:
+ * kjs/BooleanObject.cpp:
+ * kjs/BooleanObject.h:
+ * kjs/BooleanPrototype.cpp:
+ * kjs/BooleanPrototype.h:
+ * kjs/CallData.cpp:
+ * kjs/CallData.h:
+ * kjs/ClassInfo.h:
+ * kjs/CommonIdentifiers.cpp:
+ * kjs/CommonIdentifiers.h:
+ * kjs/ConstructData.cpp:
+ * kjs/ConstructData.h:
+ * kjs/DateConstructor.cpp:
+ * kjs/DateConstructor.h:
+ * kjs/DateInstance.cpp:
+ (JSC::DateInstance::msToGregorianDateTime):
+ * kjs/DateInstance.h:
+ * kjs/DateMath.cpp:
+ * kjs/DateMath.h:
+ * kjs/DatePrototype.cpp:
+ * kjs/DatePrototype.h:
+ * kjs/DebuggerCallFrame.cpp:
+ * kjs/DebuggerCallFrame.h:
+ * kjs/Error.cpp:
+ * kjs/Error.h:
+ * kjs/ErrorConstructor.cpp:
+ * kjs/ErrorConstructor.h:
+ * kjs/ErrorInstance.cpp:
+ * kjs/ErrorInstance.h:
+ * kjs/ErrorPrototype.cpp:
+ * kjs/ErrorPrototype.h:
+ * kjs/ExecState.cpp:
+ * kjs/ExecState.h:
+ * kjs/FunctionConstructor.cpp:
+ * kjs/FunctionConstructor.h:
+ * kjs/FunctionPrototype.cpp:
+ * kjs/FunctionPrototype.h:
+ * kjs/GetterSetter.cpp:
+ * kjs/GetterSetter.h:
+ * kjs/GlobalEvalFunction.cpp:
+ * kjs/GlobalEvalFunction.h:
+ * kjs/IndexToNameMap.cpp:
+ * kjs/IndexToNameMap.h:
+ * kjs/InitializeThreading.cpp:
+ * kjs/InitializeThreading.h:
+ * kjs/InternalFunction.cpp:
+ * kjs/InternalFunction.h:
+ (JSC::InternalFunction::InternalFunction):
+ * kjs/JSActivation.cpp:
+ * kjs/JSActivation.h:
+ * kjs/JSArray.cpp:
+ * kjs/JSArray.h:
+ * kjs/JSCell.cpp:
+ * kjs/JSCell.h:
+ * kjs/JSFunction.cpp:
+ * kjs/JSFunction.h:
+ (JSC::JSFunction::JSFunction):
+ * kjs/JSGlobalData.cpp:
+ (JSC::JSGlobalData::JSGlobalData):
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.cpp:
+ * kjs/JSGlobalObject.h:
+ * kjs/JSGlobalObjectFunctions.cpp:
+ * kjs/JSGlobalObjectFunctions.h:
+ * kjs/JSImmediate.cpp:
+ * kjs/JSImmediate.h:
+ * kjs/JSLock.cpp:
+ * kjs/JSLock.h:
+ * kjs/JSNotAnObject.cpp:
+ * kjs/JSNotAnObject.h:
+ * kjs/JSNumberCell.cpp:
+ * kjs/JSNumberCell.h:
+ * kjs/JSObject.cpp:
+ * kjs/JSObject.h:
+ * kjs/JSStaticScopeObject.cpp:
+ * kjs/JSStaticScopeObject.h:
+ * kjs/JSString.cpp:
+ * kjs/JSString.h:
+ * kjs/JSType.h:
+ * kjs/JSValue.cpp:
+ * kjs/JSValue.h:
+ * kjs/JSVariableObject.cpp:
+ * kjs/JSVariableObject.h:
+ * kjs/JSWrapperObject.cpp:
+ * kjs/JSWrapperObject.h:
+ * kjs/LabelStack.cpp:
+ * kjs/LabelStack.h:
+ * kjs/MathObject.cpp:
+ * kjs/MathObject.h:
+ * kjs/NativeErrorConstructor.cpp:
+ * kjs/NativeErrorConstructor.h:
+ * kjs/NativeErrorPrototype.cpp:
+ * kjs/NativeErrorPrototype.h:
+ * kjs/NodeInfo.h:
+ * kjs/NumberConstructor.cpp:
+ * kjs/NumberConstructor.h:
+ * kjs/NumberObject.cpp:
+ * kjs/NumberObject.h:
+ * kjs/NumberPrototype.cpp:
+ * kjs/NumberPrototype.h:
+ * kjs/ObjectConstructor.cpp:
+ * kjs/ObjectConstructor.h:
+ * kjs/ObjectPrototype.cpp:
+ * kjs/ObjectPrototype.h:
+ * kjs/Parser.cpp:
+ * kjs/Parser.h:
+ * kjs/PropertyMap.cpp:
+ (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
+ * kjs/PropertyMap.h:
+ * kjs/PropertyNameArray.cpp:
+ * kjs/PropertyNameArray.h:
+ * kjs/PropertySlot.cpp:
+ * kjs/PropertySlot.h:
+ * kjs/PrototypeFunction.cpp:
+ * kjs/PrototypeFunction.h:
+ * kjs/PutPropertySlot.h:
+ * kjs/RegExpConstructor.cpp:
+ * kjs/RegExpConstructor.h:
+ * kjs/RegExpObject.cpp:
+ * kjs/RegExpObject.h:
+ * kjs/RegExpPrototype.cpp:
+ * kjs/RegExpPrototype.h:
+ * kjs/ScopeChain.cpp:
+ * kjs/ScopeChain.h:
+ * kjs/ScopeChainMark.h:
+ * kjs/Shell.cpp:
+ (jscmain):
+ * kjs/SmallStrings.cpp:
+ * kjs/SmallStrings.h:
+ * kjs/SourceProvider.h:
+ * kjs/SourceRange.h:
+ * kjs/StringConstructor.cpp:
+ * kjs/StringConstructor.h:
+ * kjs/StringObject.cpp:
+ * kjs/StringObject.h:
+ * kjs/StringObjectThatMasqueradesAsUndefined.h:
+ * kjs/StringPrototype.cpp:
+ * kjs/StringPrototype.h:
+ * kjs/StructureID.cpp:
+ * kjs/StructureID.h:
+ * kjs/SymbolTable.h:
+ * kjs/collector.cpp:
+ * kjs/collector.h:
+ * kjs/completion.h:
+ * kjs/create_hash_table:
+ * kjs/debugger.cpp:
+ * kjs/debugger.h:
+ * kjs/dtoa.cpp:
+ * kjs/dtoa.h:
+ * kjs/grammar.y:
+ * kjs/identifier.cpp:
+ * kjs/identifier.h:
+ (JSC::Identifier::equal):
+ * kjs/interpreter.cpp:
+ * kjs/interpreter.h:
+ * kjs/lexer.cpp:
+ (JSC::Lexer::Lexer):
+ (JSC::Lexer::clear):
+ (JSC::Lexer::makeIdentifier):
+ * kjs/lexer.h:
+ * kjs/lookup.cpp:
+ * kjs/lookup.h:
+ * kjs/nodes.cpp:
+ * kjs/nodes.h:
+ * kjs/nodes2string.cpp:
+ * kjs/operations.cpp:
+ * kjs/operations.h:
+ * kjs/protect.h:
+ * kjs/regexp.cpp:
+ * kjs/regexp.h:
+ * kjs/ustring.cpp:
+ * kjs/ustring.h:
+ (JSC::operator!=):
+ (JSC::IdentifierRepHash::hash):
+ (WTF::):
+ * masm/MacroAssembler.h:
+ * masm/MacroAssemblerWin.cpp:
+ * masm/X86Assembler.h:
+ * pcre/pcre_exec.cpp:
+ * profiler/CallIdentifier.h:
+ (WTF::):
+ * profiler/HeavyProfile.cpp:
+ * profiler/HeavyProfile.h:
+ * profiler/Profile.cpp:
+ * profiler/Profile.h:
+ * profiler/ProfileGenerator.cpp:
+ * profiler/ProfileGenerator.h:
+ * profiler/ProfileNode.cpp:
+ * profiler/ProfileNode.h:
+ * profiler/Profiler.cpp:
+ * profiler/Profiler.h:
+ * profiler/TreeProfile.cpp:
+ * profiler/TreeProfile.h:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+ * wtf/AVLTree.h:
+
+2008-09-07 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - rename IA32MacroAssembler class to X86Assembler
+
+ We otherwise call the platform X86, and also, I don't see any macros.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * masm/IA32MacroAsm.h: Removed.
+ * masm/MacroAssembler.h:
+ (KJS::MacroAssembler::MacroAssembler):
+ * masm/MacroAssemblerWin.cpp:
+ (KJS::MacroAssembler::emitRestoreArgumentReference):
+ * masm/X86Assembler.h: Copied from masm/IA32MacroAsm.h.
+ (KJS::X86Assembler::X86Assembler):
+ * wrec/WREC.cpp:
+ (KJS::WRECGenerator::generateNonGreedyQuantifier):
+ (KJS::WRECGenerator::generateGreedyQuantifier):
+ (KJS::WRECGenerator::generateParentheses):
+ (KJS::WRECGenerator::generateBackreference):
+ (KJS::WRECGenerator::gernerateDisjunction):
+ * wrec/WREC.h:
+
+2008-09-07 Cameron Zwarich <cwzwarich@webkit.org>
+
+ Not reviewed.
+
+ Visual C++ seems to have some odd casting rules, so just convert the
+ offending cast back to a C-style cast for now.
+
+ * kjs/collector.cpp:
+ (KJS::otherThreadStackPointer):
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Mark Rowe.
+
+ Attempt to fix the Windows build by using a const_cast to cast regs.Esp
+ to a uintptr_t instead of a reinterpret_cast.
+
+ * kjs/collector.cpp:
+ (KJS::otherThreadStackPointer):
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Sam Weinig.
+
+ Remove C-style casts from kjs/collector.cpp.
+
+ * kjs/collector.cpp:
+ (KJS::Heap::heapAllocate):
+ (KJS::currentThreadStackBase):
+ (KJS::Heap::markConservatively):
+ (KJS::otherThreadStackPointer):
+ (KJS::Heap::markOtherThreadConservatively):
+ (KJS::Heap::sweep):
+
+2008-09-07 Mark Rowe <mrowe@apple.com>
+
+ Build fix for the debug variant.
+
+ * DerivedSources.make: Also use the .Debug.exp exports file when building the debug variant.
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Timothy Hatcher.
+
+ Remove C-style casts from the CTI code.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitGetArg):
+ (KJS::CTI::emitGetPutArg):
+ (KJS::ctiRepatchCallByReturnAddress):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompileMainPass):
+ (KJS::CTI::privateCompileGetByIdSelf):
+ (KJS::CTI::privateCompileGetByIdProto):
+ (KJS::CTI::privateCompileGetByIdChain):
+ (KJS::CTI::privateCompilePutByIdReplace):
+ (KJS::CTI::privateArrayLengthTrampoline):
+ (KJS::CTI::privateStringLengthTrampoline):
+
+=== End merge of squirrelfish-extreme ===
+
+2008-09-06 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig. Adapted somewhat by Maciej Stachowiak.
+
+ - refactor WREC to share more of the JIT infrastructure with CTI
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitGetArg):
+ (KJS::CTI::emitGetPutArg):
+ (KJS::CTI::emitPutArg):
+ (KJS::CTI::emitPutArgConstant):
+ (KJS::CTI::emitPutCTIParam):
+ (KJS::CTI::emitGetCTIParam):
+ (KJS::CTI::emitPutToCallFrameHeader):
+ (KJS::CTI::emitGetFromCallFrameHeader):
+ (KJS::CTI::emitPutResult):
+ (KJS::CTI::emitDebugExceptionCheck):
+ (KJS::CTI::emitJumpSlowCaseIfNotImm):
+ (KJS::CTI::emitJumpSlowCaseIfNotImms):
+ (KJS::CTI::emitFastArithDeTagImmediate):
+ (KJS::CTI::emitFastArithReTagImmediate):
+ (KJS::CTI::emitFastArithPotentiallyReTagImmediate):
+ (KJS::CTI::emitFastArithImmToInt):
+ (KJS::CTI::emitFastArithIntToImmOrSlowCase):
+ (KJS::CTI::emitFastArithIntToImmNoCheck):
+ (KJS::CTI::CTI):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompileMainPass):
+ (KJS::CTI::privateCompileSlowCases):
+ (KJS::CTI::privateCompile):
+ (KJS::CTI::privateCompileGetByIdSelf):
+ (KJS::CTI::privateCompileGetByIdProto):
+ (KJS::CTI::privateCompileGetByIdChain):
+ (KJS::CTI::privateCompilePutByIdReplace):
+ (KJS::CTI::privateArrayLengthTrampoline):
+ (KJS::CTI::privateStringLengthTrampoline):
+ (KJS::CTI::compileRegExp):
+ * VM/CTI.h:
+ (KJS::CallRecord::CallRecord):
+ (KJS::JmpTable::JmpTable):
+ (KJS::SlowCaseEntry::SlowCaseEntry):
+ (KJS::CTI::JSRInfo::JSRInfo):
+ * kjs/regexp.cpp:
+ (KJS::RegExp::RegExp):
+ * wrec/WREC.cpp:
+ (KJS::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
+ (KJS::GeneratePatternCharacterFunctor::generateAtom):
+ (KJS::GeneratePatternCharacterFunctor::backtrack):
+ (KJS::GenerateCharacterClassFunctor::generateAtom):
+ (KJS::GenerateCharacterClassFunctor::backtrack):
+ (KJS::GenerateBackreferenceFunctor::generateAtom):
+ (KJS::GenerateBackreferenceFunctor::backtrack):
+ (KJS::GenerateParenthesesNonGreedyFunctor::generateAtom):
+ (KJS::GenerateParenthesesNonGreedyFunctor::backtrack):
+ (KJS::WRECGenerate::generateBacktrack1):
+ (KJS::WRECGenerate::generateBacktrackBackreference):
+ (KJS::WRECGenerate::generateBackreferenceQuantifier):
+ (KJS::WRECGenerate::generateNonGreedyQuantifier):
+ (KJS::WRECGenerate::generateGreedyQuantifier):
+ (KJS::WRECGenerate::generatePatternCharacter):
+ (KJS::WRECGenerate::generateCharacterClassInvertedRange):
+ (KJS::WRECGenerate::generateCharacterClassInverted):
+ (KJS::WRECGenerate::generateCharacterClass):
+ (KJS::WRECGenerate::generateParentheses):
+ (KJS::WRECGenerate::generateParenthesesNonGreedy):
+ (KJS::WRECGenerate::gererateParenthesesResetTrampoline):
+ (KJS::WRECGenerate::generateAssertionBOL):
+ (KJS::WRECGenerate::generateAssertionEOL):
+ (KJS::WRECGenerate::generateAssertionWordBoundary):
+ (KJS::WRECGenerate::generateBackreference):
+ (KJS::WRECGenerate::gernerateDisjunction):
+ (KJS::WRECGenerate::terminateDisjunction):
+ (KJS::WRECParser::parseGreedyQuantifier):
+ (KJS::WRECParser::parseQuantifier):
+ (KJS::WRECParser::parsePatternCharacterQualifier):
+ (KJS::WRECParser::parseCharacterClassQuantifier):
+ (KJS::WRECParser::parseBackreferenceQuantifier):
+ (KJS::WRECParser::parseParentheses):
+ (KJS::WRECParser::parseCharacterClass):
+ (KJS::WRECParser::parseOctalEscape):
+ (KJS::WRECParser::parseEscape):
+ (KJS::WRECParser::parseTerm):
+ (KJS::WRECParser::parseDisjunction):
+ * wrec/WREC.h:
+ (KJS::WRECGenerate::WRECGenerate):
+ (KJS::WRECParser::):
+ (KJS::WRECParser::WRECParser):
+ (KJS::WRECParser::parseAlternative):
+ (KJS::WRECParser::isEndOfPattern):
+
+2008-09-06 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix the sampler build.
+
+ * VM/SamplingTool.h:
+
+2008-09-06 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Jump through the necessary hoops required to make MSVC cooperate with SFX
+
+ We now explicitly declare the calling convention on all cti_op_* cfunctions,
+ and return int instead of bool where appropriate (despite the cdecl calling
+ convention seems to state MSVC generates code that returns the result value
+ through ecx). SFX behaves slightly differently under MSVC, specifically it
+ stores the base argument address for the cti_op_* functions in the first
+ argument, and then does the required stack manipulation through that pointer.
+ This is necessary as MSVC's optimisations assume they have complete control
+ of the stack, and periodically elide our stack manipulations, or move
+ values in unexpected ways. MSVC also frequently produces tail calls which may
+ clobber the first argument, so the MSVC path is slightly less efficient due
+ to the need to restore it.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ (KJS::):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompileMainPass):
+ (KJS::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * masm/MacroAssembler.h:
+ (KJS::MacroAssembler::emitConvertToFastCall):
+ * masm/MacroAssemblerIA32GCC.cpp: Removed.
+ For performance reasons we need these no-op functions to be inlined.
+
+ * masm/MacroAssemblerWin.cpp:
+ (KJS::MacroAssembler::emitRestoreArgumentReference):
+ * wtf/Platform.h:
+
+2008-09-05 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Maciej Stachowiak, or maybe the other way around.
+
+ Added the ability to coalesce JITCode buffer grow operations by first
+ growing the buffer and then executing unchecked puts to it.
+
+ About a 2% speedup on date-format-tofte.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::compileOpCall):
+ * masm/IA32MacroAsm.h:
+ (KJS::JITCodeBuffer::ensureSpace):
+ (KJS::JITCodeBuffer::putByteUnchecked):
+ (KJS::JITCodeBuffer::putByte):
+ (KJS::JITCodeBuffer::putShortUnchecked):
+ (KJS::JITCodeBuffer::putShort):
+ (KJS::JITCodeBuffer::putIntUnchecked):
+ (KJS::JITCodeBuffer::putInt):
+ (KJS::IA32MacroAssembler::emitTestl_i32r):
+ (KJS::IA32MacroAssembler::emitMovl_mr):
+ (KJS::IA32MacroAssembler::emitMovl_rm):
+ (KJS::IA32MacroAssembler::emitMovl_i32m):
+ (KJS::IA32MacroAssembler::emitUnlinkedJe):
+ (KJS::IA32MacroAssembler::emitModRm_rr):
+ (KJS::IA32MacroAssembler::emitModRm_rr_Unchecked):
+ (KJS::IA32MacroAssembler::emitModRm_rm_Unchecked):
+ (KJS::IA32MacroAssembler::emitModRm_rm):
+ (KJS::IA32MacroAssembler::emitModRm_opr):
+ (KJS::IA32MacroAssembler::emitModRm_opr_Unchecked):
+ (KJS::IA32MacroAssembler::emitModRm_opm_Unchecked):
+
+2008-09-05 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Disable WREC and CTI on platforms that we have not yet had a chance to test with.
+
+ * wtf/Platform.h:
+
+2008-09-05 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Use jo instead of a mask compare when fetching array.length and
+ string.length. 4% speedup on array.length / string.length torture
+ test.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateArrayLengthTrampoline):
+ (KJS::CTI::privateStringLengthTrampoline):
+
+2008-09-05 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Removed a CTI compilation pass by recording labels during bytecode
+ generation. This is more to reduce complexity than it is to improve
+ performance.
+
+ SunSpider reports no change.
+
+ CodeBlock now keeps a "labels" set, which holds the offsets of all the
+ instructions that can be jumped to.
+
+ * VM/CTI.cpp: Nixed a pass.
+
+ * VM/CodeBlock.h: Added a "labels" set.
+
+ * VM/LabelID.h: No need for a special LableID for holding jump
+ destinations, since the CodeBlock now knows all jump destinations.
+
+ * wtf/HashTraits.h: New hash traits to accomodate putting offset 0 in
+ the set.
+
+ * kjs/nodes.cpp:
+ (KJS::TryNode::emitCode): Emit a dummy label to record sret targets.
+
+2008-09-05 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt and Gavin Barraclough.
+
+ Move the JITCodeBuffer onto Machine and remove the static variables.
+
+ * VM/CTI.cpp: Initialize m_jit with the Machine's code buffer.
+ * VM/Machine.cpp:
+ (KJS::Machine::Machine): Allocate a JITCodeBuffer.
+ * VM/Machine.h:
+ * kjs/RegExpConstructor.cpp:
+ (KJS::constructRegExp): Pass the ExecState through.
+ * kjs/RegExpPrototype.cpp:
+ (KJS::regExpProtoFuncCompile): Ditto.
+ * kjs/StringPrototype.cpp:
+ (KJS::stringProtoFuncMatch): Ditto.
+ (KJS::stringProtoFuncSearch): Ditto.
+ * kjs/nodes.cpp:
+ (KJS::RegExpNode::emitCode): Compile the pattern at code generation time
+ so that we have access to an ExecState.
+ * kjs/nodes.h:
+ (KJS::RegExpNode::):
+ * kjs/nodes2string.cpp:
+ * kjs/regexp.cpp:
+ (KJS::RegExp::RegExp): Pass the ExecState through.
+ (KJS::RegExp::create): Ditto.
+ * kjs/regexp.h:
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::IA32MacroAssembler): Reset the JITCodeBuffer when we are
+ constructed.
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::compile): Retrieve the JITCodeBuffer from the Machine.
+ * wrec/WREC.h:
+
+2008-09-05 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt and Gavin Barraclough.
+
+ Fix the build when CTI is disabled.
+
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::~CodeBlock):
+ * VM/CodeGenerator.cpp:
+ (KJS::prepareJumpTableForStringSwitch):
+ * VM/Machine.cpp:
+ (KJS::Machine::Machine):
+ (KJS::Machine::~Machine):
+
+2008-09-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix some windows abi issues.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompileMainPass):
+ (KJS::CTI::privateCompileSlowCases):
+ * VM/CTI.h:
+ (KJS::CallRecord::CallRecord):
+ (KJS::):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_post_inc):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_post_dec):
+ * VM/Machine.h:
+
+2008-09-05 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix ecma/FunctionObjects/15.3.5.3.js after I broke it in r93.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_call_NotJSFunction): Restore m_callFrame to the correct value after making the native call.
+ (KJS::Machine::cti_op_construct_NotJSConstruct): Ditto.
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix fast/dom/Window/console-functions.html.
+
+ The call frame on the ExecState was not being updated on calls into native functions. This meant that functions
+ such as console.log would use the line number of the last JS function on the call stack.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_call_NotJSFunction): Update the ExecState's call frame before making a native function call,
+ and restore it when the function is done.
+ (KJS::Machine::cti_op_construct_NotJSConstruct): Ditto.
+
+2008-09-05 Oliver Hunt <oliver@apple.com>
+
+ Start bringing up SFX on windows.
+
+ Reviewed by Mark Rowe and Sam Weinig
+
+ Start doing the work to bring up SFX on windows. Initially
+ just working on WREC, as it does not make any calls so reduces
+ the amount of code that needs to be corrected.
+
+ Start abstracting the CTI JIT codegen engine.
+
+ * ChangeLog:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ * masm/IA32MacroAsm.h:
+ * masm/MacroAssembler.h: Added.
+ (KJS::MacroAssembler::MacroAssembler):
+ * masm/MacroAssemblerIA32GCC.cpp: Added.
+ (KJS::MacroAssembler::emitConvertToFastCall):
+ * masm/MacroAssemblerWin.cpp: Added.
+ (KJS::MacroAssembler::emitConvertToFastCall):
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseGreedyQuantifier):
+ (KJS::WRECompiler::parseCharacterClass):
+ (KJS::WRECompiler::parseEscape):
+ (KJS::WRECompiler::compilePattern):
+ * wrec/WREC.h:
+
+2008-09-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Support for slow scripts (timeout checking).
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompileMainPass):
+ (KJS::CTI::privateCompile):
+ * VM/Machine.cpp:
+ (KJS::slideRegisterWindowForCall):
+ (KJS::Machine::cti_timeout_check):
+ (KJS::Machine::cti_vm_throw):
+
+2008-09-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Third round of style cleanup.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/CodeBlock.h:
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * kjs/ExecState.h:
+
+2008-09-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Jon Honeycutt.
+
+ Second round of style cleanup.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * wrec/WREC.h:
+
+2008-09-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ First round of style cleanup.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * masm/IA32MacroAsm.h:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+
+2008-09-04 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Merged http://trac.webkit.org/changeset/36081 to work with CTI.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::tryCtiCacheGetByID):
+
+2008-09-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Enable profiling in CTI.
+
+ * VM/CTI.h:
+ (KJS::):
+ (KJS::CTI::execute):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_call_JSFunction):
+ (KJS::Machine::cti_op_call_NotJSFunction):
+ (KJS::Machine::cti_op_ret):
+ (KJS::Machine::cti_op_construct_JSConstruct):
+ (KJS::Machine::cti_op_construct_NotJSConstruct):
+
+2008-09-04 Victor Hernandez <vhernandez@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Fixed an #if to support using WREC without CTI.
+
+ * kjs/regexp.cpp:
+ (KJS::RegExp::match):
+
+2008-09-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ The array/string length trampolines are owned by the Machine, not the codeblock that compiled them.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateArrayLengthTrampoline):
+ (KJS::CTI::privateStringLengthTrampoline):
+ * VM/Machine.cpp:
+ (KJS::Machine::~Machine):
+ * VM/Machine.h:
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Gavin Barraclough and Sam Weinig.
+
+ Fix a crash on launch of jsc when GuardMalloc is enabled.
+
+ * kjs/ScopeChain.h:
+ (KJS::ScopeChain::ScopeChain): Initialize m_node to 0 when we have no valid scope chain.
+ (KJS::ScopeChain::~ScopeChain): Null-check m_node before calling deref.
+
+2008-09-03 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Fix inspector and fast array access so that it bounds
+ checks correctly.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main):
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::):
+ (KJS::IA32MacroAssembler::emitUnlinkedJb):
+ (KJS::IA32MacroAssembler::emitUnlinkedJbe):
+
+2008-09-03 Mark Rowe <mrowe@apple.com>
+
+ Move the assertion after the InitializeAndReturn block, as
+ that is used even when CTI is enabled.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+
+2008-09-03 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Replace calls to exit with ASSERT_WITH_MESSAGE or ASSERT_NOT_REACHED.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ (KJS::Machine::cti_vm_throw):
+
+2008-09-03 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Tweak JavaScriptCore to compile on non-x86 platforms. This is achieved
+ by wrapping more code with ENABLE(CTI), ENABLE(WREC), and PLATFORM(X86)
+ #if's.
+
+ * VM/CTI.cpp:
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::printStructureIDs): Use %td as the format specifier for
+ printing a ptrdiff_t.
+ * VM/Machine.cpp:
+ * VM/Machine.h:
+ * kjs/regexp.cpp:
+ (KJS::RegExp::RegExp):
+ (KJS::RegExp::~RegExp):
+ (KJS::RegExp::match):
+ * kjs/regexp.h:
+ * masm/IA32MacroAsm.h:
+ * wrec/WREC.cpp:
+ * wrec/WREC.h:
+ * wtf/Platform.h: Only enable CTI and WREC on x86. Add an extra define to
+ track whether any MASM-using features are enabled.
+
+2008-09-03 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Copy Geoff's array/string length optimization for CTI.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateArrayLengthTrampoline):
+ (KJS::CTI::privateStringLengthTrampoline):
+ * VM/CTI.h:
+ (KJS::CTI::compileArrayLengthTrampoline):
+ (KJS::CTI::compileStringLengthTrampoline):
+ * VM/Machine.cpp:
+ (KJS::Machine::Machine):
+ (KJS::Machine::getCtiArrayLengthTrampoline):
+ (KJS::Machine::getCtiStringLengthTrampoline):
+ (KJS::Machine::tryCtiCacheGetByID):
+ (KJS::Machine::cti_op_get_by_id_second):
+ * VM/Machine.h:
+ * kjs/JSString.h:
+ * kjs/ustring.h:
+
+2008-09-03 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Implement fast array accesses in CTI - 2-3% progression on sunspider.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitFastArithIntToImmNoCheck):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ * VM/CTI.h:
+ * kjs/JSArray.h:
+
+2008-09-02 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Enable fast property access support in CTI.
+
+ * VM/CTI.cpp:
+ (KJS::ctiSetReturnAddress):
+ (KJS::ctiRepatchCallByReturnAddress):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ (KJS::CTI::privateCompileGetByIdSelf):
+ (KJS::CTI::privateCompileGetByIdProto):
+ (KJS::CTI::privateCompileGetByIdChain):
+ (KJS::CTI::privateCompilePutByIdReplace):
+ * VM/CTI.h:
+ (KJS::CTI::compileGetByIdSelf):
+ (KJS::CTI::compileGetByIdProto):
+ (KJS::CTI::compileGetByIdChain):
+ (KJS::CTI::compilePutByIdReplace):
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::~CodeBlock):
+ * VM/CodeBlock.h:
+ * VM/Machine.cpp:
+ (KJS::doSetReturnAddressVmThrowTrampoline):
+ (KJS::Machine::tryCtiCachePutByID):
+ (KJS::Machine::tryCtiCacheGetByID):
+ (KJS::Machine::cti_op_put_by_id):
+ (KJS::Machine::cti_op_put_by_id_second):
+ (KJS::Machine::cti_op_put_by_id_generic):
+ (KJS::Machine::cti_op_put_by_id_fail):
+ (KJS::Machine::cti_op_get_by_id):
+ (KJS::Machine::cti_op_get_by_id_second):
+ (KJS::Machine::cti_op_get_by_id_generic):
+ (KJS::Machine::cti_op_get_by_id_fail):
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * kjs/JSCell.h:
+ * kjs/JSObject.h:
+ * kjs/PropertyMap.h:
+ * kjs/StructureID.cpp:
+ (KJS::StructureIDChain::StructureIDChain):
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::emitCmpl_i32m):
+ (KJS::IA32MacroAssembler::emitMovl_mr):
+ (KJS::IA32MacroAssembler::emitMovl_rm):
+
+2008-09-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ A backslash (\) at the of a RegEx should produce an error.
+ Fixes fast/regex/test1.html.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseEscape):
+
+2008-09-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Link jumps for the slow case of op_loop_if_less. Fixes acid3.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Switch WREC on by default.
+
+ * wtf/Platform.h:
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix two failures in fast/regex/test1.html
+ - \- in a character class should be treated as a literal -
+ - A missing max quantifier needs to be treated differently than
+ a null max quantifier.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::generateNonGreedyQuantifier):
+ (KJS::WRECompiler::generateGreedyQuantifier):
+ (KJS::WRECompiler::parseCharacterClass):
+ * wrec/WREC.h:
+ (KJS::Quantifier::Quantifier):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix crash in fast/js/kde/evil-n.html
+
+ * kjs/regexp.cpp: Always pass a non-null offset vector to the wrec function.
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ Add pattern length limit fixing one test in fast/js.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::compile):
+ * wrec/WREC.h:
+ (KJS::WRECompiler::):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ Make octal escape parsing/back-reference parsing more closely match
+ prior behavior fixing one test in fast/js.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseCharacterClass): 8 and 9 should be IdentityEscaped
+ (KJS::WRECompiler::parseEscape):
+ * wrec/WREC.h:
+ (KJS::WRECompiler::peekDigit):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ Fix one mozilla test.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::generateCharacterClassInverted): Fix incorrect not
+ ascii upper check.
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ Parse octal escapes in character classes fixing one mozilla test.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseCharacterClass):
+ (KJS::WRECompiler::parseOctalEscape):
+ * wrec/WREC.h:
+ (KJS::WRECompiler::consumeOctal):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fixes two mozilla tests with WREC enabled.
+
+ * wrec/WREC.cpp:
+ (KJS::CharacterClassConstructor::append): Keep the character class sorted
+ when appending another character class.
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Mark Rowe.
+
+ Fixes two mozilla tests with WREC enabled.
+
+ * wrec/WREC.cpp:
+ (KJS::CharacterClassConstructor::addSortedRange): Insert the range at the correct position
+ instead of appending it to the end.
+
+2008-09-01 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Move cross-compilation unit call into NEVER_INLINE function.
+
+ * VM/Machine.cpp:
+ (KJS::doSetReturnAddressVmThrowTrampoline):
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Fix one test in fast/js.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_construct_NotJSConstruct): Throw a createNotAConstructorError,
+ instead of a createNotAFunctionError.
+
+2008-08-31 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Zero-cost exception handling. This patch takes the exception checking
+ back of the hot path. When an exception occurs in a Machine::cti*
+ method, the return address to JIT code is recorded, and is then
+ overwritten with a pointer to a trampoline routine. When the method
+ returns the trampoline will cause the cti_vm_throw method to be invoked.
+
+ cti_vm_throw uses the return address preserved above, to discover the
+ vPC of the bytecode that raised the exception (using a map build during
+ translation). From the VPC of the faulting bytecode the vPC of a catch
+ routine may be discovered (unwinding the stack where necesary), and then
+ a bytecode address for the catch routine is looked up. Final cti_vm_throw
+ overwrites its return address to JIT code again, to trampoline directly
+ to the catch routine.
+
+ cti_op_throw is handled in a similar fashion.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitPutCTIParam):
+ (KJS::CTI::emitPutToCallFrameHeader):
+ (KJS::CTI::emitGetFromCallFrameHeader):
+ (KJS::ctiSetReturnAddressForArgs):
+ (KJS::CTI::emitDebugExceptionCheck):
+ (KJS::CTI::printOpcodeOperandTypes):
+ (KJS::CTI::emitCall):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::CallRecord::CallRecord):
+ (KJS::):
+ (KJS::CTI::execute):
+ * VM/CodeBlock.h:
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ (KJS::Machine::cti_op_instanceof):
+ (KJS::Machine::cti_op_call_NotJSFunction):
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_op_in):
+ (KJS::Machine::cti_vm_throw):
+ * VM/RegisterFile.h:
+ (KJS::RegisterFile::):
+ * kjs/ExecState.h:
+ (KJS::ExecState::setCtiReturnAddress):
+ (KJS::ExecState::ctiReturnAddress):
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::):
+ (KJS::IA32MacroAssembler::emitPushl_m):
+ (KJS::IA32MacroAssembler::emitPopl_m):
+ (KJS::IA32MacroAssembler::getRelocatedAddress):
+
+2008-08-31 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fall back to PCRE for any regexp containing parentheses until we correctly backtrack within them.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseParentheses):
+ * wrec/WREC.h:
+ (KJS::WRECompiler::):
+
+2008-08-31 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix several issues within ecma_3/RegExp/perlstress-001.js with WREC enabled.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::generateNonGreedyQuantifier): Compare with the maximum quantifier count rather than the minimum.
+ (KJS::WRECompiler::generateAssertionEOL): Do a register-to-register comparison rather than immediate-to-register.
+ (KJS::WRECompiler::parseCharacterClass): Pass through the correct inversion flag.
+
+2008-08-30 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Re-fix the six remaining failures in the Mozilla JavaScript tests in a manner that does not kill performance.
+ This shows up as a 0.6% progression on SunSpider on my machine.
+
+ Grow the JITCodeBuffer's underlying buffer when we run out of space rather than just bailing out.
+
+ * VM/CodeBlock.h:
+ (KJS::CodeBlock::~CodeBlock): Switch to using fastFree now that JITCodeBuffer::copy uses fastMalloc.
+ * kjs/regexp.cpp: Ditto.
+ * masm/IA32MacroAsm.h:
+ (KJS::JITCodeBuffer::growBuffer):
+ (KJS::JITCodeBuffer::JITCodeBuffer):
+ (KJS::JITCodeBuffer::~JITCodeBuffer):
+ (KJS::JITCodeBuffer::putByte):
+ (KJS::JITCodeBuffer::putShort):
+ (KJS::JITCodeBuffer::putInt):
+ (KJS::JITCodeBuffer::reset):
+ (KJS::JITCodeBuffer::copy):
+
+2008-08-29 Oliver Hunt <oliver@apple.com>
+
+ RS=Maciej
+
+ Roll out previous patch as it causes a 5% performance regression
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp:
+ (KJS::getJCB):
+ (KJS::CTI::privateCompile):
+ * VM/CodeBlock.h:
+ (KJS::CodeBlock::~CodeBlock):
+ * masm/IA32MacroAsm.h:
+ (KJS::JITCodeBuffer::JITCodeBuffer):
+ (KJS::JITCodeBuffer::putByte):
+ (KJS::JITCodeBuffer::putShort):
+ (KJS::JITCodeBuffer::putInt):
+ (KJS::JITCodeBuffer::getEIP):
+ (KJS::JITCodeBuffer::start):
+ (KJS::JITCodeBuffer::getOffset):
+ (KJS::JITCodeBuffer::reset):
+ (KJS::JITCodeBuffer::copy):
+ (KJS::IA32MacroAssembler::emitModRm_rr):
+ (KJS::IA32MacroAssembler::emitModRm_rm):
+ (KJS::IA32MacroAssembler::emitModRm_rmsib):
+ (KJS::IA32MacroAssembler::IA32MacroAssembler):
+ (KJS::IA32MacroAssembler::emitInt3):
+ (KJS::IA32MacroAssembler::emitPushl_r):
+ (KJS::IA32MacroAssembler::emitPopl_r):
+ (KJS::IA32MacroAssembler::emitMovl_rr):
+ (KJS::IA32MacroAssembler::emitAddl_rr):
+ (KJS::IA32MacroAssembler::emitAddl_i8r):
+ (KJS::IA32MacroAssembler::emitAddl_i32r):
+ (KJS::IA32MacroAssembler::emitAddl_mr):
+ (KJS::IA32MacroAssembler::emitAndl_rr):
+ (KJS::IA32MacroAssembler::emitAndl_i32r):
+ (KJS::IA32MacroAssembler::emitCmpl_i8r):
+ (KJS::IA32MacroAssembler::emitCmpl_rr):
+ (KJS::IA32MacroAssembler::emitCmpl_rm):
+ (KJS::IA32MacroAssembler::emitCmpl_i32r):
+ (KJS::IA32MacroAssembler::emitCmpl_i32m):
+ (KJS::IA32MacroAssembler::emitCmpw_rm):
+ (KJS::IA32MacroAssembler::emitOrl_rr):
+ (KJS::IA32MacroAssembler::emitOrl_i8r):
+ (KJS::IA32MacroAssembler::emitSubl_rr):
+ (KJS::IA32MacroAssembler::emitSubl_i8r):
+ (KJS::IA32MacroAssembler::emitSubl_i32r):
+ (KJS::IA32MacroAssembler::emitSubl_mr):
+ (KJS::IA32MacroAssembler::emitTestl_i32r):
+ (KJS::IA32MacroAssembler::emitTestl_rr):
+ (KJS::IA32MacroAssembler::emitXorl_i8r):
+ (KJS::IA32MacroAssembler::emitXorl_rr):
+ (KJS::IA32MacroAssembler::emitSarl_i8r):
+ (KJS::IA32MacroAssembler::emitSarl_CLr):
+ (KJS::IA32MacroAssembler::emitShl_i8r):
+ (KJS::IA32MacroAssembler::emitShll_CLr):
+ (KJS::IA32MacroAssembler::emitMull_rr):
+ (KJS::IA32MacroAssembler::emitIdivl_r):
+ (KJS::IA32MacroAssembler::emitCdq):
+ (KJS::IA32MacroAssembler::emitMovl_mr):
+ (KJS::IA32MacroAssembler::emitMovzwl_mr):
+ (KJS::IA32MacroAssembler::emitMovl_rm):
+ (KJS::IA32MacroAssembler::emitMovl_i32r):
+ (KJS::IA32MacroAssembler::emitMovl_i32m):
+ (KJS::IA32MacroAssembler::emitLeal_mr):
+ (KJS::IA32MacroAssembler::emitRet):
+ (KJS::IA32MacroAssembler::emitJmpN_r):
+ (KJS::IA32MacroAssembler::emitJmpN_m):
+ (KJS::IA32MacroAssembler::emitCall):
+ (KJS::IA32MacroAssembler::label):
+ (KJS::IA32MacroAssembler::emitUnlinkedJmp):
+ (KJS::IA32MacroAssembler::emitUnlinkedJne):
+ (KJS::IA32MacroAssembler::emitUnlinkedJe):
+ (KJS::IA32MacroAssembler::emitUnlinkedJl):
+ (KJS::IA32MacroAssembler::emitUnlinkedJle):
+ (KJS::IA32MacroAssembler::emitUnlinkedJge):
+ (KJS::IA32MacroAssembler::emitUnlinkedJae):
+ (KJS::IA32MacroAssembler::emitUnlinkedJo):
+ (KJS::IA32MacroAssembler::link):
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::compilePattern):
+ (KJS::WRECompiler::compile):
+ * wrec/WREC.h:
+
+2008-08-29 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Have JITCodeBuffer manage a Vector containing the generated code so that it can grow
+ as needed when generating code for a large function. This fixes all six remaining failures
+ in Mozilla tests in both debug and release builds.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile):
+ * VM/CodeBlock.h:
+ (KJS::CodeBlock::~CodeBlock):
+ * masm/IA32MacroAsm.h:
+ (KJS::JITCodeBuffer::putByte):
+ (KJS::JITCodeBuffer::putShort):
+ (KJS::JITCodeBuffer::putInt):
+ (KJS::JITCodeBuffer::getEIP):
+ (KJS::JITCodeBuffer::start):
+ (KJS::JITCodeBuffer::getOffset):
+ (KJS::JITCodeBuffer::getCode):
+ (KJS::IA32MacroAssembler::emitModRm_rr):
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::compilePattern):
+ * wrec/WREC.h:
+
+2008-08-29 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Implement parsing of octal escapes in regular expressions. This fixes three Mozilla tests.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::parseOctalEscape):
+ (KJS::WRECompiler::parseEscape): Parse the escape sequence as an octal escape if it has a leading zero.
+ Add a FIXME about treating invalid backreferences as octal escapes in the future.
+ * wrec/WREC.h:
+ (KJS::WRECompiler::consumeNumber): Multiply by 10 rather than 0 so that we handle numbers with more than
+ one digit.
+ * wtf/ASCIICType.h:
+ (WTF::isASCIIOctalDigit):
+
+2008-08-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Pass vPC to instanceof method. Fixes 2 mozilla tests in debug.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_instanceof):
+
+2008-08-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Pass vPCs to resolve methods for correct exception creation. Fixes
+ 17 mozilla tests in debug.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_resolve_with_base):
+
+2008-08-29 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remembering to actually throw the exception passed to op throw helps.
+ Regressions 19 -> 6.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_vm_throw):
+
+2008-08-29 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Support for exception unwinding the stack.
+
+ Once upon a time, Sam asked me for a bettr ChangeLog entry. The return address
+ is now preserved on entry to a JIT code function (if we preserve lazily we need
+ restore the native return address during exception stack unwind). This takes
+ the number of regressions down from ~150 to 19.
+
+ * VM/CTI.cpp:
+ (KJS::getJCB):
+ (KJS::CTI::emitExceptionCheck):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::):
+ * VM/Machine.cpp:
+ (KJS::Machine::throwException):
+ (KJS::Machine::cti_op_call_JSFunction):
+ (KJS::Machine::cti_op_call_NotJSFunction):
+ (KJS::Machine::cti_op_construct_JSConstruct):
+ (KJS::Machine::cti_op_construct_NotJSConstruct):
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_vm_throw):
+
+2008-08-29 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix js1_2/regexp/word_boundary.js and four other Mozilla tests with WREC enabled.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::generateCharacterClassInvertedRange): If none of the exact matches
+ succeeded, jump to failure.
+ (KJS::WRECompiler::compilePattern): Restore and increment the current position stored
+ on the stack to ensure that it will be reset to the correct position after a failed
+ match has consumed input.
+
+2008-08-29 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix a hang in ecma_3/RegExp/15.10.2-1.js with WREC enabled.
+ A backreference with a quantifier would get stuck in an infinite
+ loop if the captured range was empty.
+
+ * wrec/WREC.cpp:
+ (KJS::WRECompiler::generateBackreferenceQuantifier): If the captured range
+ was empty, do not attempt to match the backreference.
+ (KJS::WRECompiler::parseBackreferenceQuantifier):
+ * wrec/WREC.h:
+ (KJS::Quantifier::):
+
+2008-08-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Implement op_debug.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::debug):
+ (KJS::Machine::privateExecute):
+ (KJS::Machine::cti_op_debug):
+ * VM/Machine.h:
+
+2008-08-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Implement op_switch_string fixing 1 mozilla test and one test in fast/js.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::SwitchRecord::):
+ (KJS::SwitchRecord::SwitchRecord):
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::dump):
+ * VM/CodeBlock.h:
+ (KJS::ExpressionRangeInfo::):
+ (KJS::StringJumpTable::offsetForValue):
+ (KJS::StringJumpTable::ctiForValue):
+ (KJS::SimpleJumpTable::add):
+ (KJS::SimpleJumpTable::ctiForValue):
+ * VM/CodeGenerator.cpp:
+ (KJS::prepareJumpTableForStringSwitch):
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ (KJS::Machine::cti_op_switch_string):
+ * VM/Machine.h:
+
+2008-08-28 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Do not recurse on the machine stack when executing op_call.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitGetPutArg):
+ (KJS::CTI::emitPutArg):
+ (KJS::CTI::emitPutArgConstant):
+ (KJS::CTI::compileOpCall):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::):
+ (KJS::CTI::compile):
+ (KJS::CTI::execute):
+ (KJS::CTI::):
+ * VM/Machine.cpp:
+ (KJS::Machine::Machine):
+ (KJS::Machine::execute):
+ (KJS::Machine::cti_op_call_JSFunction):
+ (KJS::Machine::cti_op_call_NotJSFunction):
+ (KJS::Machine::cti_op_ret):
+ (KJS::Machine::cti_op_construct_JSConstruct):
+ (KJS::Machine::cti_op_construct_NotJSConstruct):
+ (KJS::Machine::cti_op_call_eval):
+ * VM/Machine.h:
+ * VM/Register.h:
+ (KJS::Register::Register):
+ * VM/RegisterFile.h:
+ (KJS::RegisterFile::):
+ * kjs/InternalFunction.h:
+ (KJS::InternalFunction::InternalFunction):
+ * kjs/JSFunction.h:
+ (KJS::JSFunction::JSFunction):
+ * kjs/ScopeChain.h:
+ (KJS::ScopeChain::ScopeChain):
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::):
+ (KJS::IA32MacroAssembler::emitModRm_opm):
+ (KJS::IA32MacroAssembler::emitCmpl_i32m):
+ (KJS::IA32MacroAssembler::emitCallN_r):
+
+2008-08-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Exit instead of crashing in ctiUnsupported and ctiTimedOut.
+
+ * VM/Machine.cpp:
+ (KJS::ctiUnsupported):
+ (KJS::ctiTimedOut):
+
+2008-08-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Implement codegen for op_jsr and op_sret.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::CTI::JSRInfo::JSRInfo):
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::emitJmpN_m):
+ (KJS::IA32MacroAssembler::linkAbsoluteAddress):
+
+2008-08-28 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Initial support for exceptions (throw / catch must occur in same CodeBlock).
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitExceptionCheck):
+ (KJS::CTI::emitCall):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::nativeExceptionCodeForHandlerVPC):
+ * VM/CodeBlock.h:
+ * VM/CodeGenerator.cpp:
+ (KJS::CodeGenerator::emitCatch):
+ * VM/Machine.cpp:
+ (KJS::Machine::throwException):
+ (KJS::Machine::privateExecute):
+ (KJS::ctiUnsupported):
+ (KJS::ctiTimedOut):
+ (KJS::Machine::cti_op_add):
+ (KJS::Machine::cti_op_pre_inc):
+ (KJS::Machine::cti_timeout_check):
+ (KJS::Machine::cti_op_loop_if_less):
+ (KJS::Machine::cti_op_put_by_id):
+ (KJS::Machine::cti_op_get_by_id):
+ (KJS::Machine::cti_op_instanceof):
+ (KJS::Machine::cti_op_del_by_id):
+ (KJS::Machine::cti_op_mul):
+ (KJS::Machine::cti_op_call):
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_construct):
+ (KJS::Machine::cti_op_get_by_val):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_sub):
+ (KJS::Machine::cti_op_put_by_val):
+ (KJS::Machine::cti_op_lesseq):
+ (KJS::Machine::cti_op_loop_if_true):
+ (KJS::Machine::cti_op_negate):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_div):
+ (KJS::Machine::cti_op_pre_dec):
+ (KJS::Machine::cti_op_jless):
+ (KJS::Machine::cti_op_not):
+ (KJS::Machine::cti_op_jtrue):
+ (KJS::Machine::cti_op_post_inc):
+ (KJS::Machine::cti_op_eq):
+ (KJS::Machine::cti_op_lshift):
+ (KJS::Machine::cti_op_bitand):
+ (KJS::Machine::cti_op_rshift):
+ (KJS::Machine::cti_op_bitnot):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_mod):
+ (KJS::Machine::cti_op_less):
+ (KJS::Machine::cti_op_neq):
+ (KJS::Machine::cti_op_post_dec):
+ (KJS::Machine::cti_op_urshift):
+ (KJS::Machine::cti_op_bitxor):
+ (KJS::Machine::cti_op_bitor):
+ (KJS::Machine::cti_op_call_eval):
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_op_push_scope):
+ (KJS::Machine::cti_op_stricteq):
+ (KJS::Machine::cti_op_nstricteq):
+ (KJS::Machine::cti_op_to_jsnumber):
+ (KJS::Machine::cti_op_in):
+ (KJS::Machine::cti_op_del_by_val):
+ (KJS::Machine::cti_vm_throw):
+ * VM/Machine.h:
+ * kjs/ExecState.h:
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::emitCmpl_i32m):
+
+2008-08-28 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Print debugging info to stderr so that run-webkit-tests can capture it.
+ This makes it easy to check whether test failures are due to unimplemented
+ op codes, missing support for exceptions, etc.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::printOpcodeOperandTypes):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ (KJS::CTI::privateCompile):
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ (KJS::ctiException):
+ (KJS::ctiUnsupported):
+ (KJS::Machine::cti_op_call):
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_construct):
+ (KJS::Machine::cti_op_get_by_val):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_call_eval):
+
+2008-08-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Gavin Barraclough and Maciej Stachowiak.
+
+ Fix fast/js/bitwise-and-on-undefined.html.
+
+ A temporary value in the slow path of op_bitand was being stored in edx, but was
+ being clobbered by emitGetPutArg before we used it. To fix this, emitGetPutArg
+ now takes a third argument that specifies the scratch register to use when loading
+ from memory. This allows us to avoid clobbering the temporary in op_bitand.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitGetPutArg):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ * VM/CTI.h:
+
+2008-08-27 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Switch CTI on by default.
+
+ * wtf/Platform.h:
+
+2008-08-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix the build of the full WebKit stack.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Mark two new headers as private so they can be pulled in from WebCore.
+ * VM/CTI.h: Fix build issues that show up when compiled with GCC 4.2 as part of WebCore.
+ * wrec/WREC.h: Ditto.
+
+2008-08-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implement op_new_error. Does not fix any tests as it is always followed by the unimplemented op_throw.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_new_error):
+ * VM/Machine.h:
+
+2008-08-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Implement op_put_getter and op_put_setter.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_put_getter):
+ (KJS::Machine::cti_op_put_setter):
+ * VM/Machine.h:
+
+2008-08-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Implement op_del_by_val fixing 3 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_del_by_val):
+ * VM/Machine.h:
+
+2008-08-27 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Quick & dirty fix to get SamplingTool sampling op_call.
+
+ * VM/SamplingTool.h:
+ (KJS::SamplingTool::callingHostFunction):
+
+2008-08-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Fix op_put_by_index.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main): Use emitPutArgConstant instead of emitGetPutArg
+ for the property value.
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_put_by_index): Get the property value from the correct argument.
+
+2008-08-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Implement op_switch_imm in the CTI fixing 13 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_switch_imm):
+ * VM/Machine.h:
+
+2008-08-27 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Implement op_switch_char in CTI.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitCall):
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ (KJS::CallRecord::CallRecord):
+ (KJS::SwitchRecord::SwitchRecord):
+ * VM/CodeBlock.h:
+ (KJS::SimpleJumpTable::SimpleJumpTable::ctiForValue):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_switch_char):
+ * VM/Machine.h:
+ * masm/IA32MacroAsm.h:
+ (KJS::IA32MacroAssembler::):
+ (KJS::IA32MacroAssembler::emitJmpN_r):
+ (KJS::IA32MacroAssembler::getRelocatedAddress):
+ * wtf/Platform.h:
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Implement op_put_by_index to fix 1 mozilla test.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_put_by_index):
+ * VM/Machine.h:
+
+2008-08-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ More fixes from Geoff's review.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::emitGetArg):
+ (KJS::CTI::emitGetPutArg):
+ (KJS::CTI::emitPutArg):
+ (KJS::CTI::emitPutArgConstant):
+ (KJS::CTI::getConstantImmediateNumericArg):
+ (KJS::CTI::emitGetCTIParam):
+ (KJS::CTI::emitPutResult):
+ (KJS::CTI::emitCall):
+ (KJS::CTI::emitJumpSlowCaseIfNotImm):
+ (KJS::CTI::emitJumpSlowCaseIfNotImms):
+ (KJS::CTI::getDeTaggedConstantImmediate):
+ (KJS::CTI::emitFastArithDeTagImmediate):
+ (KJS::CTI::emitFastArithReTagImmediate):
+ (KJS::CTI::emitFastArithPotentiallyReTagImmediate):
+ (KJS::CTI::emitFastArithImmToInt):
+ (KJS::CTI::emitFastArithIntToImmOrSlowCase):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Implement op_jmp_scopes to fix 2 Mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_push_new_scope): Update ExecState::m_scopeChain after calling ARG_setScopeChain.
+ (KJS::Machine::cti_op_jmp_scopes):
+ * VM/Machine.h:
+
+2008-08-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ WebKit Regular Expression Compiler. (set ENABLE_WREC = 1 in Platform.h).
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/regexp.cpp:
+ * kjs/regexp.h:
+ * wrec: Added.
+ * wrec/WREC.cpp: Added.
+ * wrec/WREC.h: Added.
+ * wtf/Platform.h:
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Remove bogus assertion.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_del_by_id):
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implement op_push_new_scope and stub out op_catch. This fixes 11 Mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_push_new_scope):
+ (KJS::Machine::cti_op_catch):
+ * VM/Machine.h:
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Clean up op_resolve_base so that it shares its implementation with the bytecode interpreter.
+
+ * VM/Machine.cpp:
+ (KJS::inlineResolveBase):
+ (KJS::resolveBase):
+
+2008-08-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add codegen support for op_instanceof, fixing 15 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_instanceof):
+ (KJS::Machine::cti_op_del_by_id):
+ * VM/Machine.h:
+ * wtf/Platform.h:
+
+2008-08-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fixes for initial review comments.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::ctiCompileGetArg):
+ (KJS::CTI::ctiCompileGetPutArg):
+ (KJS::CTI::ctiCompilePutResult):
+ (KJS::CTI::ctiCompileCall):
+ (KJS::CTI::CTI):
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::printOpcodeOperandTypes):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h:
+ * VM/Register.h:
+ * kjs/JSValue.h:
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Fix up exception checking code.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_call):
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_construct):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_call_eval):
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix slowcase for op_post_inc and op_post_dec fixing 2 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implement op_in, fixing 8 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_in):
+ * VM/Machine.h:
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Don't hardcode the size of a Register for op_new_array. Fixes a crash
+ seen during the Mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main):
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Add support for op_push_scope and op_pop_scope, fixing 20 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/CTI.h:
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_push_scope):
+ (KJS::Machine::cti_op_pop_scope):
+ * VM/Machine.h:
+
+2008-08-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add codegen support for op_del_by_id, fixing 49 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+ * VM/Machine.cpp:
+ (KJS::Machine::cti_op_del_by_id):
+ * VM/Machine.h:
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough and Geoff Garen.
+
+ Don't hardcode the size of a Register for op_get_scoped_var and op_put_scoped_var
+ fixing 513 mozilla tests in debug build.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass2_Main):
+
+2008-08-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Added code generator support for op_loop, fixing around 60 mozilla tests.
+
+ * VM/CTI.cpp:
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::privateCompile_pass2_Main):
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Set -fomit-frame-pointer in the correct location.
+
+ * Configurations/JavaScriptCore.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-08-26 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Inital cut of CTI, Geoff's review fixes to follow.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/CTI.cpp: Added.
+ (KJS::getJCB):
+ (KJS::CTI::ctiCompileGetArg):
+ (KJS::CTI::ctiCompileGetPutArg):
+ (KJS::CTI::ctiCompilePutArg):
+ (KJS::CTI::ctiCompilePutArgImm):
+ (KJS::CTI::ctiImmediateNumericArg):
+ (KJS::CTI::ctiCompileGetCTIParam):
+ (KJS::CTI::ctiCompilePutResult):
+ (KJS::CTI::ctiCompileCall):
+ (KJS::CTI::slowCaseIfNotImm):
+ (KJS::CTI::slowCaseIfNotImms):
+ (KJS::CTI::ctiFastArithDeTagConstImmediate):
+ (KJS::CTI::ctiFastArithDeTagImmediate):
+ (KJS::CTI::ctiFastArithReTagImmediate):
+ (KJS::CTI::ctiFastArithPotentiallyReTagImmediate):
+ (KJS::CTI::ctiFastArithImmToInt):
+ (KJS::CTI::ctiFastArithIntToImmOrSlowCase):
+ (KJS::CTI::CTI):
+ (KJS::CTI::privateCompile_pass1_Scan):
+ (KJS::CTI::ctiCompileAdd):
+ (KJS::CTI::ctiCompileAddImm):
+ (KJS::CTI::ctiCompileAddImmNotInt):
+ (KJS::CTI::TEMP_HACK_PRINT_TYPES):
+ (KJS::CTI::privateCompile_pass2_Main):
+ (KJS::CTI::privateCompile_pass3_Link):
+ (KJS::CTI::privateCompile_pass4_SlowCases):
+ (KJS::CTI::privateCompile):
+ * VM/CTI.h: Added.
+ (KJS::CTI2Result::CTI2Result):
+ (KJS::CallRecord::CallRecord):
+ (KJS::JmpTable::JmpTable):
+ (KJS::SlowCaseEntry::SlowCaseEntry):
+ (KJS::CTI::compile):
+ (KJS::CTI::LabelInfo::LabelInfo):
+ * VM/CodeBlock.h:
+ (KJS::CodeBlock::CodeBlock):
+ (KJS::CodeBlock::~CodeBlock):
+ * VM/Machine.cpp:
+ (KJS::Machine::execute):
+ (KJS::Machine::privateExecute):
+ (KJS::ctiException):
+ (KJS::ctiUnsupported):
+ (KJS::ctiTimedOut):
+ (KJS::Machine::cti_op_end):
+ (KJS::Machine::cti_op_add):
+ (KJS::Machine::cti_op_pre_inc):
+ (KJS::Machine::cti_timeout_check):
+ (KJS::Machine::cti_op_loop_if_less):
+ (KJS::Machine::cti_op_new_object):
+ (KJS::Machine::cti_op_put_by_id):
+ (KJS::Machine::cti_op_get_by_id):
+ (KJS::Machine::cti_op_mul):
+ (KJS::Machine::cti_op_new_func):
+ (KJS::Machine::cti_op_call):
+ (KJS::Machine::cti_op_ret):
+ (KJS::Machine::cti_op_new_array):
+ (KJS::Machine::cti_op_resolve):
+ (KJS::Machine::cti_op_construct):
+ (KJS::Machine::cti_op_get_by_val):
+ (KJS::Machine::cti_op_resolve_func):
+ (KJS::Machine::cti_op_sub):
+ (KJS::Machine::cti_op_put_by_val):
+ (KJS::Machine::cti_op_lesseq):
+ (KJS::Machine::cti_op_loop_if_true):
+ (KJS::Machine::cti_op_negate):
+ (KJS::Machine::cti_op_resolve_base):
+ (KJS::Machine::cti_op_resolve_skip):
+ (KJS::Machine::cti_op_div):
+ (KJS::Machine::cti_op_pre_dec):
+ (KJS::Machine::cti_op_jless):
+ (KJS::Machine::cti_op_not):
+ (KJS::Machine::cti_op_jtrue):
+ (KJS::Machine::cti_op_post_inc):
+ (KJS::Machine::cti_op_eq):
+ (KJS::Machine::cti_op_lshift):
+ (KJS::Machine::cti_op_bitand):
+ (KJS::Machine::cti_op_rshift):
+ (KJS::Machine::cti_op_bitnot):
+ (KJS::Machine::cti_op_resolve_with_base):
+ (KJS::Machine::cti_op_new_func_exp):
+ (KJS::Machine::cti_op_mod):
+ (KJS::Machine::cti_op_less):
+ (KJS::Machine::cti_op_neq):
+ (KJS::Machine::cti_op_post_dec):
+ (KJS::Machine::cti_op_urshift):
+ (KJS::Machine::cti_op_bitxor):
+ (KJS::Machine::cti_op_new_regexp):
+ (KJS::Machine::cti_op_bitor):
+ (KJS::Machine::cti_op_call_eval):
+ (KJS::Machine::cti_op_throw):
+ (KJS::Machine::cti_op_get_pnames):
+ (KJS::Machine::cti_op_next_pname):
+ (KJS::Machine::cti_op_typeof):
+ (KJS::Machine::cti_op_stricteq):
+ (KJS::Machine::cti_op_nstricteq):
+ (KJS::Machine::cti_op_to_jsnumber):
+ * VM/Machine.h:
+ * VM/Register.h:
+ (KJS::Register::jsValue):
+ (KJS::Register::getJSValue):
+ (KJS::Register::codeBlock):
+ (KJS::Register::scopeChain):
+ (KJS::Register::i):
+ (KJS::Register::r):
+ (KJS::Register::vPC):
+ (KJS::Register::jsPropertyNameIterator):
+ * VM/SamplingTool.cpp:
+ (KJS::):
+ (KJS::SamplingTool::run):
+ (KJS::SamplingTool::dump):
+ * VM/SamplingTool.h:
+ * kjs/JSImmediate.h:
+ (KJS::JSImmediate::zeroImmediate):
+ (KJS::JSImmediate::oneImmediate):
+ * kjs/JSValue.h:
+ * kjs/JSVariableObject.h:
+ (KJS::JSVariableObject::JSVariableObjectData::offsetOf_registers):
+ (KJS::JSVariableObject::offsetOf_d):
+ (KJS::JSVariableObject::offsetOf_Data_registers):
+ * masm: Added.
+ * masm/IA32MacroAsm.h: Added.
+ (KJS::JITCodeBuffer::JITCodeBuffer):
+ (KJS::JITCodeBuffer::putByte):
+ (KJS::JITCodeBuffer::putShort):
+ (KJS::JITCodeBuffer::putInt):
+ (KJS::JITCodeBuffer::getEIP):
+ (KJS::JITCodeBuffer::start):
+ (KJS::JITCodeBuffer::getOffset):
+ (KJS::JITCodeBuffer::reset):
+ (KJS::JITCodeBuffer::copy):
+ (KJS::IA32MacroAssembler::):
+ (KJS::IA32MacroAssembler::emitModRm_rr):
+ (KJS::IA32MacroAssembler::emitModRm_rm):
+ (KJS::IA32MacroAssembler::emitModRm_rmsib):
+ (KJS::IA32MacroAssembler::emitModRm_opr):
+ (KJS::IA32MacroAssembler::emitModRm_opm):
+ (KJS::IA32MacroAssembler::IA32MacroAssembler):
+ (KJS::IA32MacroAssembler::emitInt3):
+ (KJS::IA32MacroAssembler::emitPushl_r):
+ (KJS::IA32MacroAssembler::emitPopl_r):
+ (KJS::IA32MacroAssembler::emitMovl_rr):
+ (KJS::IA32MacroAssembler::emitAddl_rr):
+ (KJS::IA32MacroAssembler::emitAddl_i8r):
+ (KJS::IA32MacroAssembler::emitAddl_i32r):
+ (KJS::IA32MacroAssembler::emitAddl_mr):
+ (KJS::IA32MacroAssembler::emitAndl_rr):
+ (KJS::IA32MacroAssembler::emitAndl_i32r):
+ (KJS::IA32MacroAssembler::emitCmpl_i8r):
+ (KJS::IA32MacroAssembler::emitCmpl_rr):
+ (KJS::IA32MacroAssembler::emitCmpl_rm):
+ (KJS::IA32MacroAssembler::emitCmpl_i32r):
+ (KJS::IA32MacroAssembler::emitCmpw_rm):
+ (KJS::IA32MacroAssembler::emitOrl_rr):
+ (KJS::IA32MacroAssembler::emitOrl_i8r):
+ (KJS::IA32MacroAssembler::emitSubl_rr):
+ (KJS::IA32MacroAssembler::emitSubl_i8r):
+ (KJS::IA32MacroAssembler::emitSubl_i32r):
+ (KJS::IA32MacroAssembler::emitSubl_mr):
+ (KJS::IA32MacroAssembler::emitTestl_i32r):
+ (KJS::IA32MacroAssembler::emitTestl_rr):
+ (KJS::IA32MacroAssembler::emitXorl_i8r):
+ (KJS::IA32MacroAssembler::emitXorl_rr):
+ (KJS::IA32MacroAssembler::emitSarl_i8r):
+ (KJS::IA32MacroAssembler::emitSarl_CLr):
+ (KJS::IA32MacroAssembler::emitShl_i8r):
+ (KJS::IA32MacroAssembler::emitShll_CLr):
+ (KJS::IA32MacroAssembler::emitMull_rr):
+ (KJS::IA32MacroAssembler::emitIdivl_r):
+ (KJS::IA32MacroAssembler::emitCdq):
+ (KJS::IA32MacroAssembler::emitMovl_mr):
+ (KJS::IA32MacroAssembler::emitMovzwl_mr):
+ (KJS::IA32MacroAssembler::emitMovl_rm):
+ (KJS::IA32MacroAssembler::emitMovl_i32r):
+ (KJS::IA32MacroAssembler::emitMovl_i32m):
+ (KJS::IA32MacroAssembler::emitLeal_mr):
+ (KJS::IA32MacroAssembler::emitRet):
+ (KJS::IA32MacroAssembler::JmpSrc::JmpSrc):
+ (KJS::IA32MacroAssembler::JmpDst::JmpDst):
+ (KJS::IA32MacroAssembler::emitCall):
+ (KJS::IA32MacroAssembler::label):
+ (KJS::IA32MacroAssembler::emitUnlinkedJmp):
+ (KJS::IA32MacroAssembler::emitUnlinkedJne):
+ (KJS::IA32MacroAssembler::emitUnlinkedJe):
+ (KJS::IA32MacroAssembler::emitUnlinkedJl):
+ (KJS::IA32MacroAssembler::emitUnlinkedJle):
+ (KJS::IA32MacroAssembler::emitUnlinkedJge):
+ (KJS::IA32MacroAssembler::emitUnlinkedJae):
+ (KJS::IA32MacroAssembler::emitUnlinkedJo):
+ (KJS::IA32MacroAssembler::emitPredictionNotTaken):
+ (KJS::IA32MacroAssembler::link):
+ (KJS::IA32MacroAssembler::copy):
+ * wtf/Platform.h:
+
+2008-08-26 Oliver Hunt <oliver@apple.com>
+
+ RS=Maciej.
+
+ Enabled -fomit-frame-pointer on Release and Production builds, add additional Profiling build config for shark, etc.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+=== Start merge of squirrelfish-extreme ===
+
+2008-09-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix the Mac Debug build by adding symbols that are exported only in a
+ Debug configuration.
+
+ * Configurations/JavaScriptCore.xcconfig:
+ * DerivedSources.make:
+ * JavaScriptCore.Debug.exp: Added.
+ * JavaScriptCore.base.exp: Copied from JavaScriptCore.exp.
+ * JavaScriptCore.exp: Removed.
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-09-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20681
+ JSPropertyNameIterator functions need to be inlined
+
+ 1.007x as fast on SunSpider overall
+ 1.081x as fast on SunSpider math-cordic
+
+ * VM/JSPropertyNameIterator.cpp: Moved functions out of here.
+ * VM/JSPropertyNameIterator.h:
+ (KJS::JSPropertyNameIterator::JSPropertyNameIterator): Moved
+ this into the header and marked it inline.
+ (KJS::JSPropertyNameIterator::create): Ditto.
+ (KJS::JSPropertyNameIterator::next): Ditto.
+
+2008-09-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20673
+ single-character strings are churning in the Identifier table
+
+ 1.007x as fast on SunSpider overall
+ 1.167x as fast on SunSpider string-fasta
+
+ * JavaScriptCore.exp: Updated.
+ * kjs/SmallStrings.cpp:
+ (KJS::SmallStrings::singleCharacterStringRep): Added.
+ * kjs/SmallStrings.h: Added singleCharacterStringRep for clients that
+ need just a UString, not a JSString.
+ * kjs/identifier.cpp:
+ (KJS::Identifier::add): Added special cases for single character strings
+ so that the UString::Rep that ends up in the identifier table is the one
+ from the single-character string optimization; otherwise we end up having
+ to look it up in the identifier table over and over again.
+ (KJS::Identifier::addSlowCase): Ditto.
+ (KJS::Identifier::checkSameIdentifierTable): Made this function an empty
+ inline in release builds so that callers don't have to put #ifndef NDEBUG
+ at each call site.
+ * kjs/identifier.h:
+ (KJS::Identifier::add): Removed #ifndef NDEBUG around the calls to
+ checkSameIdentifierTable.
+ (KJS::Identifier::checkSameIdentifierTable): Added. Empty inline version
+ for NDEBUG builds.
+
+2008-09-05 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * kjs/JSObject.h: Move the inline virtual destructor after a non-inline
+ virtual function so that the symbol for the vtable is not marked as a
+ weakly exported symbol.
+
+2008-09-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20671
+ JavaScriptCore string manipulation spends too much time in memcpy
+
+ 1.011x as fast on SunSpider overall
+ 1.028x as fast on SunSpider string tests
+
+ For small strings, use a loop rather than calling memcpy. The loop can
+ be faster because there's no function call overhead, and because it can
+ assume the pointers are aligned instead of checking that. Currently the
+ threshold is set at 20 characters, based on some testing on one particular
+ computer. Later we can tune this for various platforms by setting
+ USTRING_COPY_CHARS_INLINE_CUTOFF appropriately, but it does no great harm
+ if not perfectly tuned.
+
+ * kjs/ustring.cpp:
+ (KJS::overflowIndicator): Removed bogus const.
+ (KJS::maxUChars): Ditto.
+ (KJS::copyChars): Added.
+ (KJS::UString::Rep::createCopying): Call copyChars instead of memcpy.
+ Also eliminated need for const_cast.
+ (KJS::UString::expandPreCapacity): Ditto.
+ (KJS::concatenate): Ditto.
+ (KJS::UString::spliceSubstringsWithSeparators): Ditto.
+ (KJS::UString::append): Ditto.
+
+2008-09-05 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Sam and Alexey.
+
+ Make the profiler work with a null exec state. This will allow other
+ applications start the profiler to get DTrace probes going without
+ needing a WebView.
+
+ * ChangeLog:
+ * profiler/ProfileGenerator.cpp:
+ (KJS::ProfileGenerator::ProfileGenerator):
+ (KJS::ProfileGenerator::willExecute):
+ (KJS::ProfileGenerator::didExecute):
+ * profiler/Profiler.cpp:
+ (KJS::Profiler::startProfiling):
+ (KJS::Profiler::stopProfiling):
+ (KJS::dispatchFunctionToProfiles):
+
+2008-09-04 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Fixed an off-by-one error that would cause the StructureIDChain to
+ be one object too short.
+
+ Can't construct a test case because other factors make this not crash
+ (yet!).
+
+ * kjs/StructureID.cpp:
+ (KJS::StructureIDChain::StructureIDChain):
+
+2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes.
+
+ * JavaScriptCoreSources.bkl:
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
+ Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
+
+ * Configurations/JavaScriptCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
+ * wtf/Platform.h: Set ENABLE_DASHBOARD_SUPPORT for PLATFORM(MAC).
+
+2008-09-04 Adele Peterson <adele@apple.com>
+
+ Build fix.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.vcproj/jsc/jsc.vcproj:
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Mac build fix.
+
+ * kjs/config.h: Only check the value of HAVE_CONFIG_H if it is defined.
+
+2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Eric Seidel.
+
+ http://bugs.webkit.org/show_bug.cgi?id=20380
+ [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
+
+ * kjs/config.h: Include the configuration header generated by
+ autotools if available.
+
+2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix the QtWebKit build to match changes in r36016
+
+ * JavaScriptCore.pri:
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Fix the 64-bit build.
+
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::printStructureID): Store the instruction offset into an unsigned local
+ to avoid a warning related to format specifiers.
+ (KJS::CodeBlock::printStructureIDs): Ditto.
+
+2008-09-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Correct the spelling of 'entryIndices'.
+
+ * kjs/PropertyMap.cpp:
+ (KJS::PropertyMap::get):
+ (KJS::PropertyMap::getLocation):
+ (KJS::PropertyMap::put):
+ (KJS::PropertyMap::insert):
+ (KJS::PropertyMap::remove):
+ (KJS::PropertyMap::checkConsistency):
+ * kjs/PropertyMap.h:
+ (KJS::PropertyMapHashTable::entries):
+ (KJS::PropertyMap::getOffset):
+ (KJS::PropertyMap::putOffset):
+ (KJS::PropertyMap::offsetForTableLocation):
+
+2008-09-03 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed <rdar://problem/6193925> REGRESSION: Crash occurs at
+ KJS::Machine::privateExecute() when attempting to load my Mobile Gallery
+ (http://www.me.com/gallery/#home)
+
+ also
+
+ https://bugs.webkit.org/show_bug.cgi?id=20633 Crash in privateExecute
+ @ cs.byu.edu
+
+ The underlying problem was that we would cache prototype properties
+ even if the prototype was a dictionary.
+
+ The fix is to transition a prototype back from dictionary to normal
+ status when an opcode caches access to it. (This is better than just
+ refusing to cache, since a heavily accessed prototype is almost
+ certainly not a true dictionary.)
+
+ * VM/Machine.cpp:
+ (KJS::Machine::tryCacheGetByID):
+ * kjs/JSObject.h:
+
+2008-09-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam.
+
+ Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
+
+ * Configurations/JavaScriptCore.xcconfig: add missing ENABLE_*
+ * wtf/ASCIICType.h: include <wtf/Assertions.h> since it depends on it.
+ * wtf/Platform.h:
+
+2008-09-03 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ Remove the rest of the "zombie" code from the profiler.
+ - There is no longer a need for the ProfilerClient callback mechanism.
+
+ * API/JSProfilerPrivate.cpp:
+ (JSStartProfiling):
+ * JavaScriptCore.exp:
+ * profiler/HeavyProfile.h:
+ * profiler/ProfileGenerator.cpp:
+ (KJS::ProfileGenerator::create):
+ (KJS::ProfileGenerator::ProfileGenerator):
+ * profiler/ProfileGenerator.h:
+ (KJS::ProfileGenerator::profileGroup):
+ * profiler/Profiler.cpp:
+ (KJS::Profiler::startProfiling):
+ (KJS::Profiler::stopProfiling): Immediately return the profile when
+ stopped instead of using a callback.
+ * profiler/Profiler.h:
+ * profiler/TreeProfile.h:
+
+2008-09-03 Adele Peterson <adele@apple.com>
+
+ Build fix.
+
+ * wtf/win/MainThreadWin.cpp:
+
+2008-09-02 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Darin and Tim.
+
+ Remove most of the "zombie" mode from the profiler. Next we will need
+ to remove the client callback mechanism in profiles.
+
+ - This simplifies the code, leverages the recent changes I've made in
+ getting line numbers from SquirrelFish, and is a slight speed
+ improvement on SunSpider.
+ - Also the "zombie" mode was a constant source of odd edge cases and
+ obscure bugs so it's good to remove since all of its issues may not have
+ been found.
+
+ * API/JSProfilerPrivate.cpp: No need to call didFinishAllExecution() any
+ more.
+ (JSEndProfiling):
+ * JavaScriptCore.exp: Export the new signature of retrieveLastCaller()
+ * VM/Machine.cpp:
+ (KJS::Machine::execute): No need to call didFinishAllExecution() any
+ more.
+ (KJS::Machine::retrieveCaller): Now operates on InternalFunctions now
+ since the RegisterFile is no longer guaranteeded to store only
+ JSFunctions
+ (KJS::Machine::retrieveLastCaller): Now also retrieve the function's
+ name
+ (KJS::Machine::callFrame): A result of changing retrieveCaller()
+ * VM/Machine.h:
+ * VM/Register.h:
+ * kjs/JSGlobalObject.cpp:
+ (KJS::JSGlobalObject::~JSGlobalObject):
+ * kjs/nodes.h:
+ * profiler/ProfileGenerator.cpp:
+ (KJS::ProfileGenerator::create): Now pass the original exec and get the
+ global exec and client when necessary. We need the original exec so we
+ can have the stack frame where profiling started.
+ (KJS::ProfileGenerator::ProfileGenerator): ditto.
+ (KJS::ProfileGenerator::addParentForConsoleStart): This is where the
+ parent to star of the profile is added, if there is one.
+ (KJS::ProfileGenerator::willExecute): Remove uglyness!
+ (KJS::ProfileGenerator::didExecute): Ditto!
+ (KJS::ProfileGenerator::stopProfiling):
+ (KJS::ProfileGenerator::removeProfileStart): Use a better way to find
+ and remove the function we are looking for.
+ (KJS::ProfileGenerator::removeProfileEnd): Ditto.
+ * profiler/ProfileGenerator.h:
+ (KJS::ProfileGenerator::client):
+ * profiler/ProfileNode.cpp:
+ (KJS::ProfileNode::removeChild): Add a better way to remove a child from
+ a ProfileNode.
+ (KJS::ProfileNode::stopProfiling):
+ (KJS::ProfileNode::debugPrintData): Modified a debug-only diagnostic
+ function to be sane.
+ * profiler/ProfileNode.h:
+ * profiler/Profiler.cpp: Change to pass the original exec state.
+ (KJS::Profiler::startProfiling):
+ (KJS::Profiler::stopProfiling):
+ (KJS::Profiler::willExecute):
+ (KJS::Profiler::didExecute):
+ (KJS::Profiler::createCallIdentifier):
+ * profiler/Profiler.h:
+
+2008-09-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Implement callOnMainThreadAndWait().
+
+ This will be useful when a background thread needs to perform UI calls synchronously
+ (e.g. an openDatabase() call cannot return until the user answers to a confirmation dialog).
+
+ * wtf/MainThread.cpp:
+ (WTF::FunctionWithContext::FunctionWithContext): Added a ThreadCondition member. When
+ non-zero, the condition is signalled after the function is called.
+ (WTF::mainThreadFunctionQueueMutex): Renamed from functionQueueMutex, sinc this is no longer
+ static. Changed to be initialized from initializeThreading() to avoid lock contention.
+ (WTF::initializeMainThread): On non-Windows platforms, just call mainThreadFunctionQueueMutex.
+ (WTF::dispatchFunctionsFromMainThread): Signal synchronous calls when done.
+ (WTF::callOnMainThread): Updated for functionQueueMutex rename.
+ (WTF::callOnMainThreadAndWait): Added.
+
+ * wtf/MainThread.h: Added callOnMainThreadAndWait(); initializeMainThread() now exists on
+ all platforms.
+
+ * wtf/win/MainThreadWin.cpp: (WTF::initializeMainThread): Added a callOnMainThreadAndWait()
+ call to initialize function queue mutex.
+
+ * wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
+ * wtf/ThreadingPthreads.cpp: (WTF::initializeThreading):
+ * wtf/ThreadingQt.cpp: (WTF::initializeThreading):
+ Only initialize mainThreadIdentifier on non-Darwin platforms. It was not guaranteed to be
+ accurate on Darwin.
+
+2008-09-03 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Use isUndefinedOrNull() instead of separate checks for each in op_eq_null
+ and op_neq_null.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+
+2008-09-02 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ Bug 20296: OpcodeStats doesn't build on platforms which don't have mergesort().
+ <https://bugs.webkit.org/show_bug.cgi?id=20296>
+
+ * VM/Opcode.cpp:
+ (KJS::OpcodeStats::~OpcodeStats): mergesort() replaced with qsort()
+
+2008-09-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fast path for array.length and string.length.
+
+ SunSpider says 0.5% faster.
+
+2008-09-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Added optimized paths for comparing to null.
+
+ SunSpider says 0.5% faster.
+
+2008-09-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Changed jsDriver.pl to dump the exact text you would need in order to
+ reproduce a test result. This enables a fast workflow where you copy
+ and paste a test failure in the terminal.
+
+ * tests/mozilla/jsDriver.pl:
+
+2008-09-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implemented the rest of Darin's review comments for the 09-01 inline
+ caching patch.
+
+ SunSpider says 0.5% faster, but that seems like noise.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Put PutPropertySlot into
+ its own file, and added BatchedTransitionOptimizer.
+
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::~CodeBlock): Use array indexing instead of a pointer
+ iterator.
+
+ * VM/CodeGenerator.cpp:
+ (KJS::CodeGenerator::CodeGenerator): Used BatchedTransitionOptimizer to
+ make batched put and remove for declared variables fast, without forever
+ pessimizing the global object. Removed the old getDirect/removeDirect hack
+ that tried to do the same in a more limited way.
+
+ * VM/CodeGenerator.h: Moved IdentifierRepHash to the KJS namespace since
+ it doesn't specialize anything in WTF.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::Machine): Nixed the DummyConstruct tag because it was
+ confusingly named.
+
+ (KJS::Machine::execute): Used BatchedTransitionOptimizer, as above. Fixed
+ up some comments.
+
+ (KJS::cachePrototypeChain): Cast to JSObject*, since it's more specific.
+
+ (KJS::Machine::tryCachePutByID): Use isNull() instead of comparing to
+ jsNull(), since isNull() leaves more options open for the future.
+ (KJS::Machine::tryCacheGetByID): ditto
+ (KJS::Machine::privateExecute): ditto
+
+ * VM/SamplingTool.cpp:
+ (KJS::SamplingTool::dump): Use C++-style cast, to match our style
+ guidelines.
+
+ * kjs/BatchedTransitionOptimizer.h: Added. New class that allows host
+ code to add a batch of properties to an object in an efficient way.
+
+ * kjs/JSActivation.cpp: Use isNull(), as above.
+
+ * kjs/JSArray.cpp: Get rid of DummyConstruct tag, as above.
+ * kjs/JSArray.h:
+
+ * kjs/JSGlobalData.cpp: Nixed two unused StructureIDs.
+ * kjs/JSGlobalData.h:
+
+ * kjs/JSImmediate.cpp: Use isNull(), as above.
+
+ * kjs/JSObject.cpp:
+ (KJS::JSObject::mark): Moved mark tracing code elsewhere, to make this
+ function more readable.
+
+ (KJS::JSObject::put): Use isNull(), as above.
+
+ (KJS::JSObject::createInheritorID): Return a raw pointer, since the
+ object is owned by a data member, not necessarily the caller.
+ * kjs/JSObject.h:
+
+ * kjs/JSString.cpp: Use isNull(), as above.
+
+ * kjs/PropertyMap.h: Updated to use PropertySlot::invalidOffset.
+
+ * kjs/PropertySlot.h: Changed KJS_INVALID_OFFSET to WTF::notFound
+ because C macros are so 80's.
+
+ * kjs/PutPropertySlot.h: Added. Split out of PropertySlot.h. Also renamed
+ PutPropertySlot::SlotType to PutPropertySlot::Type, and slotBase to base,
+ since "slot" was redundant.
+
+ * kjs/StructureID.cpp: Added a new transition *away* from dictionary
+ status, to support BatchedTransitionOptimizer.
+
+ (KJS::StructureIDChain::StructureIDChain): No need to store m_size as
+ a data member, so keep it in a local, which might be faster.
+ * kjs/StructureID.h:
+
+ * kjs/SymbolTable.h: Moved IdentifierRepHash to KJS namespace, as above.
+ * kjs/ustring.h:
+
+2008-09-02 Adam Roben <aroben@apple.com>
+
+ Windows build fixes
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add
+ StructureID.{cpp,h} to the project. Also let VS reorder this file.
+ * VM/CodeBlock.cpp: Include StringExtras so that snprintf will be
+ defined on Windows.
+
+2008-09-01 Sam Weinig <sam@webkit.org>
+
+ Fix release build.
+
+ * JavaScriptCore.exp:
+
+2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Gtk buildfix
+
+ * GNUmakefile.am:
+ * kjs/PropertyMap.cpp: rename Identifier.h to identifier.h
+ * kjs/StructureID.cpp: include JSObject.h
+
+2008-09-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ First cut at inline caching for access to vanilla JavaScript properties.
+
+ SunSpider says 4% faster. Tests heavy on dictionary-like access have
+ regressed a bit -- we have a lot of room to improve in this area,
+ but this patch is over-ripe as-is.
+
+ JSCells now have a StructureID that uniquely identifies their layout,
+ and holds their prototype.
+
+ JSValue::put takes a PropertySlot& argument, so it can fill in details
+ about where it put a value, for the sake of caching.
+
+ * VM/CodeGenerator.cpp:
+ (KJS::CodeGenerator::CodeGenerator): Avoid calling removeDirect if we
+ can, since it disables inline caching in the global object. This can
+ probably improve in the future.
+
+ * kjs/JSGlobalObject.cpp: Nixed reset(), since it complicates caching, and
+ wasn't really necessary.
+
+ * kjs/JSObject.cpp: Tweaked getter / setter behavior not to rely on the
+ IsGetterSetter flag, since the flag was buggy. This is necessary in order
+ to avoid accidentally accessing a getter / setter as a normal property.
+
+ Also changed getter / setter creation to honor ReadOnly, matching Mozilla.
+
+ * kjs/PropertyMap.cpp: Nixed clear(), since it complicates caching and
+ isn't necessary.
+
+ * kjs/Shell.cpp: Moved SamplingTool dumping outside the loop. This allows
+ you to aggregate sampling of multiple files (or the same file repeatedly),
+ which helped me track down regressions.
+
+ * kjs/ustring.h: Moved IdentifierRepHash here to share it.
+
+2008-09-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Eagerly allocate the Math object's numeric constants. This avoids
+ constantly reallocating them in loops, and also ensures that the Math
+ object will not use the single property optimization, which makes
+ properties ineligible for caching.
+
+ SunSpider reports a small speedup, in combination with inline caching.
+
+ * kjs/MathObject.cpp:
+ (KJS::MathObject::MathObject):
+ (KJS::MathObject::getOwnPropertySlot):
+ * kjs/MathObject.h:
+
+2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix, not reviewed.
+
+ * GNUmakefile.am: Add SmallStrings.cpp in both release and debug builds
+
+2008-08-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20577: REGRESSION (r36006): Gmail is broken
+ <https://bugs.webkit.org/show_bug.cgi?id=20577>
+
+ r36006 changed stringProtoFuncSubstr() so that it is uses the more
+ efficient jsSubstring(), rather than using UString::substr() and then
+ calling jsString(). However, the change did not account for the case
+ where the start and the length of the substring extend beyond the length
+ of the original string. This patch corrects that.
+
+ * kjs/StringPrototype.cpp:
+ (KJS::stringProtoFuncSubstr):
+
+2008-08-31 Simon Hausmann <hausmann@wekit.org>
+
+ Unreviewed build fix (with gcc 4.3)
+
+ * kjs/ustring.h: Properly forward declare operator== for UString and
+ the the concatenate functions inside the KJS namespace.
+
+2008-08-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20333
+ improve JavaScript speed when handling single-character strings
+
+ 1.035x as fast on SunSpider overall.
+ 1.127x as fast on SunSpider string tests.
+ 1.910x as fast on SunSpider string-base64 test.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunction): Removed unneeded explicit construction of UString.
+
+ * GNUmakefile.am: Added SmallStrings.h and SmallStrings.cpp.
+ * JavaScriptCore.pri: Ditto.
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ Ditto.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
+ * JavaScriptCoreSources.bkl: Ditto.
+
+ * JavaScriptCore.exp: Updated.
+
+ * VM/Machine.cpp:
+ (KJS::jsAddSlowCase): Changed to use a code path that doesn't involve
+ a UString constructor. This avoids an extra jump caused by the "in charge"
+ vs. "not in charge" constructors.
+ (KJS::jsAdd): Ditto.
+ (KJS::jsTypeStringForValue): Adopted jsNontrivialString.
+
+ * kjs/ArrayPrototype.cpp:
+ (KJS::arrayProtoFuncToString): Adopted jsEmptyString.
+ (KJS::arrayProtoFuncToLocaleString): Ditto.
+ (KJS::arrayProtoFuncJoin): Ditto.
+ * kjs/BooleanPrototype.cpp:
+ (KJS::booleanProtoFuncToString): Adopted jsNontrivialString.
+ * kjs/DateConstructor.cpp:
+ (KJS::callDate): Ditto.
+ * kjs/DatePrototype.cpp:
+ (KJS::formatLocaleDate): Adopted jsEmptyString and jsNontrivialString.
+ (KJS::dateProtoFuncToString): Ditto.
+ (KJS::dateProtoFuncToUTCString): Ditto.
+ (KJS::dateProtoFuncToDateString): Ditto.
+ (KJS::dateProtoFuncToTimeString): Ditto.
+ (KJS::dateProtoFuncToLocaleString): Ditto.
+ (KJS::dateProtoFuncToLocaleDateString): Ditto.
+ (KJS::dateProtoFuncToLocaleTimeString): Ditto.
+ (KJS::dateProtoFuncToGMTString): Ditto.
+
+ * kjs/ErrorPrototype.cpp:
+ (KJS::ErrorPrototype::ErrorPrototype): Ditto.
+ (KJS::errorProtoFuncToString): Ditto.
+
+ * kjs/JSGlobalData.h: Added SmallStrings.
+
+ * kjs/JSString.cpp:
+ (KJS::jsString): Eliminated the overload that takes a const char*.
+ Added code to use SmallStrings to get strings of small sizes rather
+ than creating a new JSString every time.
+ (KJS::jsSubstring): Added. Used when creating a string from a substring
+ to avoid creating a JSString in cases where the substring will end up
+ empty or as one character.
+ (KJS::jsOwnedString): Added the same code as in jsString.
+
+ * kjs/JSString.h: Added new functions jsEmptyString, jsSingleCharacterString,
+ jsSingleCharacterSubstring, jsSubstring, and jsNontrivialString for various
+ cases where we want to create JSString, and want special handling for small
+ strings.
+ (KJS::JSString::JSString): Added an overload that takes a PassRefPtr of
+ a UString::Rep so you don't have to construct a UString; PassRefPtr can be
+ more efficient.
+ (KJS::jsEmptyString): Added.
+ (KJS::jsSingleCharacterString): Added.
+ (KJS::jsSingleCharacterSubstring): Added.
+ (KJS::jsNontrivialString): Added.
+ (KJS::JSString::getIndex): Adopted jsSingleCharacterSubstring.
+ (KJS::JSString::getStringPropertySlot): Ditto.
+
+ * kjs/NumberPrototype.cpp:
+ (KJS::numberProtoFuncToFixed): Adopted jsNontrivialString.
+ (KJS::numberProtoFuncToExponential): Ditto.
+ (KJS::numberProtoFuncToPrecision): Ditto.
+
+ * kjs/ObjectPrototype.cpp:
+ (KJS::objectProtoFuncToLocaleString): Adopted toThisJSString.
+ (KJS::objectProtoFuncToString): Adopted jsNontrivialString.
+
+ * kjs/RegExpConstructor.cpp: Separated the lastInput value that's used
+ with the lastOvector to return matches from the input value that can be
+ changed via JavaScript. They will be equal in many cases, but not all.
+ (KJS::RegExpConstructor::performMatch): Set input.
+ (KJS::RegExpMatchesArray::RegExpMatchesArray): Ditto.
+ (KJS::RegExpMatchesArray::fillArrayInstance): Adopted jsSubstring. Also,
+ use input rather than lastInput in the appropriate place.
+ (KJS::RegExpConstructor::getBackref): Adopted jsSubstring and jsEmptyString.
+ Added code to handle the case where there is no backref -- before this
+ depended on range checking in UString::substr which is not present in
+ jsSubstring.
+ (KJS::RegExpConstructor::getLastParen): Ditto.
+ (KJS::RegExpConstructor::getLeftContext): Ditto.
+ (KJS::RegExpConstructor::getRightContext): Ditto.
+ (KJS::RegExpConstructor::getValueProperty): Use input rather than lastInput.
+ Also adopt jsEmptyString.
+ (KJS::RegExpConstructor::putValueProperty): Ditto.
+ (KJS::RegExpConstructor::input): Ditto.
+
+ * kjs/RegExpPrototype.cpp:
+ (KJS::regExpProtoFuncToString): Adopt jsNonTrivialString. Also changed to
+ use UString::append to append single characters rather than using += and
+ a C-style string.
+
+ * kjs/SmallStrings.cpp: Added.
+ (KJS::SmallStringsStorage::SmallStringsStorage): Construct the
+ buffer and UString::Rep for all 256 single-character strings for
+ the U+0000 through U+00FF. This covers all the values used in
+ the base64 test as well as most values seen elsewhere on the web
+ as well. It's possible that later we might fix this to only work
+ for U+0000 through U+007F but the others are used quite a bit in
+ the current version of the base64 test.
+ (KJS::SmallStringsStorage::~SmallStringsStorage): Free memory.
+ (KJS::SmallStrings::SmallStrings): Create a set of small strings,
+ initially not created; created later when they are used.
+ (KJS::SmallStrings::~SmallStrings): Deallocate. Not left compiler
+ generated because the SmallStringsStorage class's destructor needs
+ to be visible.
+ (KJS::SmallStrings::mark): Mark all the strings.
+ (KJS::SmallStrings::createEmptyString): Create a cell for the
+ empty string. Called only the first time.
+ (KJS::SmallStrings::createSingleCharacterString): Create a cell
+ for one of the single-character strings. Called only the first time.
+ * kjs/SmallStrings.h: Added.
+
+ * kjs/StringConstructor.cpp:
+ (KJS::stringFromCharCodeSlowCase): Factored out of strinFromCharCode.
+ Only used for cases where the caller does not pass exactly one argument.
+ (KJS::stringFromCharCode): Adopted jsSingleCharacterString.
+ (KJS::callStringConstructor): Adopted jsEmptyString.
+
+ * kjs/StringObject.cpp:
+ (KJS::StringObject::StringObject): Adopted jsEmptyString.
+
+ * kjs/StringPrototype.cpp:
+ (KJS::stringProtoFuncReplace): Adopted jsSubstring.
+ (KJS::stringProtoFuncCharAt): Adopted jsEmptyString and
+ jsSingleCharacterSubstring and also added a special case when the
+ index is an immediate number to avoid conversion to and from floating
+ point, since that's the common case.
+ (KJS::stringProtoFuncCharCodeAt): Ditto.
+ (KJS::stringProtoFuncMatch): Adopted jsSubstring and jsEmptyString.
+ (KJS::stringProtoFuncSlice): Adopted jsSubstring and
+ jsSingleCharacterSubstring. Also got rid of some unneeded locals and
+ removed unneeded code to set the length property of the array, since it
+ is automatically updated as values are added to the array.
+ (KJS::stringProtoFuncSplit): Adopted jsEmptyString.
+ (KJS::stringProtoFuncSubstr): Adopted jsSubstring.
+ (KJS::stringProtoFuncSubstring): Ditto.
+
+ * kjs/collector.cpp:
+ (KJS::Heap::collect): Added a call to mark SmallStrings.
+
+ * kjs/ustring.cpp:
+ (KJS::UString::expandedSize): Made this a static member function since
+ it doesn't need to look at any data members.
+ (KJS::UString::expandCapacity): Use a non-inline function, makeNull, to
+ set the rep to null in failure cases. This avoids adding a PIC branch for
+ the normal case when there is no failure.
+ (KJS::UString::expandPreCapacity): Ditto.
+ (KJS::UString::UString): Ditto.
+ (KJS::concatenate): Refactored the concatenation constructor into this
+ separate function. Calling the concatenation constructor was leading to
+ an extra branch because of the in-charge vs. not-in-charge versions not
+ both being inlined, and this was showing up as nearly 1% on Shark. Also
+ added a special case for when the second string is a single character,
+ since it's a common idiom to build up a string that way and we can do
+ things much more quickly, without involving memcpy for example. Also
+ adopted the non-inline function, nullRep, for the same reason given for
+ makeNull above.
+ (KJS::UString::append): Adopted makeNull for failure cases.
+ (KJS::UString::operator=): Ditto.
+ (KJS::UString::toDouble): Added a special case for converting single
+ character strings to numbers. We're doing this a ton of times while
+ running the base64 test.
+ (KJS::operator==): Added special cases so we can compare single-character
+ strings without calling memcmp. Later we might want to special case other
+ short lengths similarly.
+ (KJS::UString::makeNull): Added.
+ (KJS::UString::nullRep): Added.
+ * kjs/ustring.h: Added declarations for the nullRep and makeNull. Changed
+ expandedSize to be a static member function. Added a declaration of the
+ concatenate function. Removed the concatenation constructor. Rewrote
+ operator+ to use the concatenate function.
+
+2008-08-29 Anders Carlsson <andersca@apple.com>
+
+ Build fix.
+
+ * VM/Machine.cpp:
+ (KJS::getCPUTime):
+
+2008-08-29 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6174667>
+ When a machine is under heavy load, the Slow Script dialog often comes up many times and just gets in the way
+
+ Instead of using clock time, use the CPU time spent executing the current thread when
+ determining if the script has been running for too long.
+
+ * VM/Machine.cpp:
+ (KJS::getCPUTime):
+ (KJS::Machine::checkTimeout):
+
+2008-08-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Sam Weinig.
+
+ Change 'term' to 'expr' in variable names to standardize terminology.
+
+ * kjs/nodes.cpp:
+ (KJS::BinaryOpNode::emitCode):
+ (KJS::ReverseBinaryOpNode::emitCode):
+ (KJS::ThrowableBinaryOpNode::emitCode):
+ * kjs/nodes.h:
+ (KJS::BinaryOpNode::BinaryOpNode):
+ (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode):
+ (KJS::MultNode::):
+ (KJS::DivNode::):
+ (KJS::ModNode::):
+ (KJS::AddNode::):
+ (KJS::SubNode::):
+ (KJS::LeftShiftNode::):
+ (KJS::RightShiftNode::):
+ (KJS::UnsignedRightShiftNode::):
+ (KJS::LessNode::):
+ (KJS::GreaterNode::):
+ (KJS::LessEqNode::):
+ (KJS::GreaterEqNode::):
+ (KJS::ThrowableBinaryOpNode::):
+ (KJS::InstanceOfNode::):
+ (KJS::InNode::):
+ (KJS::EqualNode::):
+ (KJS::NotEqualNode::):
+ (KJS::StrictEqualNode::):
+ (KJS::NotStrictEqualNode::):
+ (KJS::BitAndNode::):
+ (KJS::BitOrNode::):
+ (KJS::BitXOrNode::):
+ * kjs/nodes2string.cpp:
+ (KJS::MultNode::streamTo):
+ (KJS::DivNode::streamTo):
+ (KJS::ModNode::streamTo):
+ (KJS::AddNode::streamTo):
+ (KJS::SubNode::streamTo):
+ (KJS::LeftShiftNode::streamTo):
+ (KJS::RightShiftNode::streamTo):
+ (KJS::UnsignedRightShiftNode::streamTo):
+ (KJS::LessNode::streamTo):
+ (KJS::GreaterNode::streamTo):
+ (KJS::LessEqNode::streamTo):
+ (KJS::GreaterEqNode::streamTo):
+ (KJS::InstanceOfNode::streamTo):
+ (KJS::InNode::streamTo):
+ (KJS::EqualNode::streamTo):
+ (KJS::NotEqualNode::streamTo):
+ (KJS::StrictEqualNode::streamTo):
+ (KJS::NotStrictEqualNode::streamTo):
+ (KJS::BitAndNode::streamTo):
+ (KJS::BitXOrNode::streamTo):
+ (KJS::BitOrNode::streamTo):
+
+2008-08-28 Alp Toker <alp@nuanti.com>
+
+ GTK+ dist/build fix. List newly added header files.
+
+ * GNUmakefile.am:
+
+2008-08-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Change to throw a ReferenceError at runtime instead of a ParseError
+ at parse time, when the left hand side expression of a for-in statement
+ is not an lvalue.
+
+ * kjs/grammar.y:
+ * kjs/nodes.cpp:
+ (KJS::ForInNode::emitCode):
+
+2008-08-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Not reviewed, build fix (at least for OpenBSD, posssibly more).
+
+ https://bugs.webkit.org/show_bug.cgi?id=20545
+ missing #include <unistd.h> in JavaScriptCore/VM/SamplingTool.cpp
+
+ * VM/SamplingTool.cpp: add the missing include.
+
+2008-08-26 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff and Cameron.
+
+ <rdar://problem/6174603> Hitting assertion in Register::codeBlock when
+ loading facebook (20516).
+
+ - This was a result of my line numbers change. After a host function is
+ called the stack does not get reset correctly.
+ - Oddly this also appears to be a slight speedup on SunSpider.
+
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+
+2008-08-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff and Tim.
+
+ Export new API methods.
+
+ * JavaScriptCore.exp:
+
+2008-08-25 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff, Tim and Mark.
+
+ <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
+ in the console said what file and line number they came from
+ - Lay the foundation for getting line numbers and other data from the
+ JavaScript engine. With the cleanup in kjs/ExecState this is actually
+ a slight performance improvement.
+
+ * JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * VM/Machine.cpp: Now Host and JS functions set a call frame on the
+ exec state, so this and the profiler code were pulled out of the
+ branches.
+ (KJS::Machine::privateExecute):
+ (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID
+ and sourceURL for the previously called function.
+ * VM/Machine.h:
+ * kjs/ExecState.cpp: Remove references to JSFunction since it's not used
+ anywhere.
+ * kjs/ExecState.h:
+
+2008-08-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
+ contexts in the current context's group.
+
+ This is only really necessary when the last reference is released, but there is no way to
+ determine that, and no harm in collecting slightly more often.
+
+ * API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not
+ being destroyed.
+
+2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
+ <https://bugs.webkit.org/show_bug.cgi?id=20093>
+
+ Clear exceptions after evaluating any code in the JSC shell. We do not
+ report exceptions that are caused by calling toString on the final
+ valued, but at least we avoid incorrect behaviour.
+
+ Also, print any exceptions that occurred while evaluating code at the
+ interactive prompt, not just while evaluating code from a file.
+
+ * kjs/Shell.cpp:
+ (runWithScripts):
+ (runInteractive):
+
+2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver.
+
+ Remove an unnecessary RefPtr to a RegisterID.
+
+ * kjs/nodes.cpp:
+ (KJS::DeleteBracketNode::emitCode):
+
+2008-08-24 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Use the correct version number for when JSGlobalContextCreate was introduced.
+
+ * API/JSContextRef.h:
+
+2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Mark Rowe.
+
+ Remove modelines.
+
+ * API/APICast.h:
+ * API/JSBase.cpp:
+ * API/JSCallbackConstructor.cpp:
+ * API/JSCallbackConstructor.h:
+ * API/JSCallbackFunction.cpp:
+ * API/JSCallbackFunction.h:
+ * API/JSCallbackObject.cpp:
+ * API/JSCallbackObject.h:
+ * API/JSCallbackObjectFunctions.h:
+ * API/JSClassRef.cpp:
+ * API/JSContextRef.cpp:
+ * API/JSObjectRef.cpp:
+ * API/JSProfilerPrivate.cpp:
+ * API/JSStringRef.cpp:
+ * API/JSStringRefBSTR.cpp:
+ * API/JSStringRefCF.cpp:
+ * API/JSValueRef.cpp:
+ * API/tests/JSNode.c:
+ * API/tests/JSNode.h:
+ * API/tests/JSNodeList.c:
+ * API/tests/JSNodeList.h:
+ * API/tests/Node.c:
+ * API/tests/Node.h:
+ * API/tests/NodeList.c:
+ * API/tests/NodeList.h:
+ * API/tests/minidom.c:
+ * API/tests/minidom.js:
+ * API/tests/testapi.c:
+ * API/tests/testapi.js:
+ * JavaScriptCore.pro:
+ * kjs/FunctionConstructor.h:
+ * kjs/FunctionPrototype.h:
+ * kjs/JSArray.h:
+ * kjs/JSString.h:
+ * kjs/JSWrapperObject.cpp:
+ * kjs/NumberConstructor.h:
+ * kjs/NumberObject.h:
+ * kjs/NumberPrototype.h:
+ * kjs/lexer.h:
+ * kjs/lookup.h:
+ * wtf/Assertions.cpp:
+ * wtf/Assertions.h:
+ * wtf/HashCountedSet.h:
+ * wtf/HashFunctions.h:
+ * wtf/HashIterators.h:
+ * wtf/HashMap.h:
+ * wtf/HashSet.h:
+ * wtf/HashTable.h:
+ * wtf/HashTraits.h:
+ * wtf/ListHashSet.h:
+ * wtf/ListRefPtr.h:
+ * wtf/Noncopyable.h:
+ * wtf/OwnArrayPtr.h:
+ * wtf/OwnPtr.h:
+ * wtf/PassRefPtr.h:
+ * wtf/Platform.h:
+ * wtf/RefPtr.h:
+ * wtf/RefPtrHashMap.h:
+ * wtf/RetainPtr.h:
+ * wtf/UnusedParam.h:
+ * wtf/Vector.h:
+ * wtf/VectorTraits.h:
+ * wtf/unicode/Unicode.h:
+ * wtf/unicode/icu/UnicodeIcu.h:
+
+2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver.
+
+ Some cleanup to match our coding style.
+
+ * VM/CodeGenerator.h:
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ * kjs/ExecState.cpp:
+ * kjs/ExecState.h:
+ * kjs/completion.h:
+ * kjs/identifier.cpp:
+ (KJS::Identifier::equal):
+ (KJS::CStringTranslator::hash):
+ (KJS::CStringTranslator::equal):
+ (KJS::CStringTranslator::translate):
+ (KJS::UCharBufferTranslator::equal):
+ (KJS::UCharBufferTranslator::translate):
+ (KJS::Identifier::remove):
+ * kjs/operations.h:
+
+2008-08-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Windows build fix.
+
+ * API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
+
+2008-08-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
+
+ * kjs/JSGlobalData.cpp:
+ (KJS::JSGlobalData::~JSGlobalData):
+ (KJS::JSGlobalData::JSGlobalData): Re-add shared instance.
+ (KJS::JSGlobalData::sharedInstanceExists): Ditto.
+ (KJS::JSGlobalData::sharedInstance): Ditto.
+ (KJS::JSGlobalData::sharedInstanceInternal): Ditto.
+
+ * API/JSContextRef.h: Deprecated JSGlobalContextCreate(). Added a very conservative
+ description of its threading model (nothing is allowed).
+
+ * API/JSContextRef.cpp:
+ (JSGlobalContextCreate): Use shared JSGlobalData.
+ (JSGlobalContextCreateInGroup): Support passing NULL group to request a unique one.
+ (JSGlobalContextRetain): Added back locking.
+ (JSGlobalContextRelease): Ditto.
+ (JSContextGetGlobalObject): Ditto.
+
+ * API/tests/minidom.c: (main):
+ * API/tests/testapi.c: (main):
+ Switched to JSGlobalContextCreateInGroup() to avoid deprecation warnings.
+
+ * JavaScriptCore.exp: Re-added JSLock methods. Added JSGlobalContextCreateInGroup (d'oh!).
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax):
+ (JSGarbageCollect):
+ * API/JSCallbackConstructor.cpp:
+ (KJS::constructJSCallback):
+ * API/JSCallbackFunction.cpp:
+ (KJS::JSCallbackFunction::call):
+ * API/JSCallbackObjectFunctions.h:
+ (KJS::::init):
+ (KJS::::getOwnPropertySlot):
+ (KJS::::put):
+ (KJS::::deleteProperty):
+ (KJS::::construct):
+ (KJS::::hasInstance):
+ (KJS::::call):
+ (KJS::::getPropertyNames):
+ (KJS::::toNumber):
+ (KJS::::toString):
+ (KJS::::staticValueGetter):
+ (KJS::::callbackGetter):
+ * API/JSObjectRef.cpp:
+ (JSObjectMake):
+ (JSObjectMakeFunctionWithCallback):
+ (JSObjectMakeConstructor):
+ (JSObjectMakeFunction):
+ (JSObjectHasProperty):
+ (JSObjectGetProperty):
+ (JSObjectSetProperty):
+ (JSObjectGetPropertyAtIndex):
+ (JSObjectSetPropertyAtIndex):
+ (JSObjectDeleteProperty):
+ (JSObjectCallAsFunction):
+ (JSObjectCallAsConstructor):
+ (JSObjectCopyPropertyNames):
+ (JSPropertyNameArrayRelease):
+ (JSPropertyNameAccumulatorAddName):
+ * API/JSValueRef.cpp:
+ (JSValueIsEqual):
+ (JSValueIsInstanceOfConstructor):
+ (JSValueMakeNumber):
+ (JSValueMakeString):
+ (JSValueToNumber):
+ (JSValueToStringCopy):
+ (JSValueToObject):
+ (JSValueProtect):
+ (JSValueUnprotect):
+ * ForwardingHeaders/JavaScriptCore/JSLock.h: Added.
+ * GNUmakefile.am:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ * kjs/AllInOneFile.cpp:
+ * kjs/JSGlobalData.h:
+ * kjs/JSGlobalObject.cpp:
+ (KJS::JSGlobalObject::~JSGlobalObject):
+ (KJS::JSGlobalObject::init):
+ * kjs/JSLock.cpp: Added.
+ (KJS::createJSLockCount):
+ (KJS::JSLock::lockCount):
+ (KJS::setLockCount):
+ (KJS::JSLock::JSLock):
+ (KJS::JSLock::lock):
+ (KJS::JSLock::unlock):
+ (KJS::JSLock::currentThreadIsHoldingLock):
+ (KJS::JSLock::DropAllLocks::DropAllLocks):
+ (KJS::JSLock::DropAllLocks::~DropAllLocks):
+ * kjs/JSLock.h: Added.
+ (KJS::JSLock::JSLock):
+ (KJS::JSLock::~JSLock):
+ * kjs/Shell.cpp:
+ (functionGC):
+ (jscmain):
+ * kjs/collector.cpp:
+ (KJS::Heap::~Heap):
+ (KJS::Heap::heapAllocate):
+ (KJS::Heap::setGCProtectNeedsLocking):
+ (KJS::Heap::protect):
+ (KJS::Heap::unprotect):
+ (KJS::Heap::collect):
+ * kjs/identifier.cpp:
+ * kjs/interpreter.cpp:
+ (KJS::Interpreter::checkSyntax):
+ (KJS::Interpreter::evaluate):
+ Re-added implicit locking.
+
+2008-08-19 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim and Mark.
+
+ Implement DTrace hooks for dashcode and instruments.
+
+ * API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be
+ turned on from a client. The DTrace probes were added within the
+ profiler mechanism for performance reasons so the profiler must be
+ started to enable tracing.
+ (JSStartProfiling):
+ (JSEndProfiling):
+ * API/JSProfilerPrivate.h: Added. Ditto.
+ * JavaScriptCore.exp: Exposing the start/stop methods to clients.
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * kjs/Tracing.d: Define the DTrace probes.
+ * kjs/Tracing.h: Ditto.
+ * profiler/ProfileGenerator.cpp: Implement the DTrace probes in the
+ profiler.
+ (KJS::ProfileGenerator::willExecute):
+ (KJS::ProfileGenerator::didExecute):
+
+2008-08-19 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * kjs/operations.cpp:
+ (KJS::equal):
+
+2008-08-18 Timothy Hatcher <timothy@apple.com>
+
+ Fix an assertion when generating a heavy profile because the
+ empty value and deleted value of CallIdentifier where equal.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20439
+
+ Reviewed by Dan Bernstein.
+
+ * profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier
+ use empty strings for URL and function name.
+
+2008-08-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff.
+
+ - eliminate JSValue::type()
+
+ This will make it slightly easier to change the JSImmediate design without
+ having to touch so many call sites.
+
+ SunSpider says this change is a wash (looked like a slight speedup, but not
+ statistically significant).
+
+ * API/JSStringRef.cpp: Removed include of JSType.h.
+ * API/JSValueRef.cpp: Removed include of JSType.h.
+ (JSValueGetType): Replaced use of JSValue::type() with
+ JSValue::is functions.
+
+ * JavaScriptCore.exp: Updated.
+
+ * VM/JSPropertyNameIterator.cpp: Removed type() implementation.
+ (KJS::JSPropertyNameIterator::toPrimitive): Changed to take
+ PreferredPrimitiveType argument instead of JSType.
+ * VM/JSPropertyNameIterator.h: Ditto.
+
+ * VM/Machine.cpp:
+ (KJS::fastIsNumber): Updated for name change.
+ (KJS::fastToInt32): Ditto.
+ (KJS::fastToUInt32): Ditto.
+ (KJS::jsAddSlowCase): Updated toPrimitive caller for change from
+ JSType to PreferredPrimitiveType.
+ (KJS::jsAdd): Replaced calls to JSValue::type() with calls to
+ JSValue::isString().
+ (KJS::jsTypeStringForValue): Replaced calls to JSValue::type()
+ with multiple calls to JSValue::is -- we could make this a
+ virtual function instead if we want to have faster performance.
+ (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32
+ to JSImmediate::getTruncatedUInt32 for consistency with other functions.
+ Changed two calls of JSValue::type() to JSValue::isString().
+
+ * kjs/GetterSetter.cpp:
+ (KJS::GetterSetter::toPrimitive): Changed to take
+ PreferredPrimitiveType argument instead of JSType.
+ (KJS::GetterSetter::isGetterSetter): Added.
+ * kjs/GetterSetter.h:
+
+ * kjs/JSCell.cpp:
+ (KJS::JSCell::isString): Added.
+ (KJS::JSCell::isGetterSetter): Added.
+ (KJS::JSCell::isObject): Added.
+
+ * kjs/JSCell.h: Eliminated type function. Added isGetterSetter.
+ Made isString and isObject virtual. Changed toPrimitive to take
+ PreferredPrimitiveType argument instead of JSType.
+ (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance.
+ (KJS::JSValue::isGetterSetter): Added.
+ (KJS::JSValue::toPrimitive): Changed to take
+ PreferredPrimitiveType argument instead of JSType.
+
+ * kjs/JSImmediate.h: Removed JSValue::type() and replaced
+ JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32.
+ (KJS::JSImmediate::isEitherImmediate): Added.
+
+ * kjs/JSNotAnObject.cpp:
+ (KJS::JSNotAnObject::toPrimitive): Changed to take
+ PreferredPrimitiveType argument instead of JSType.
+ * kjs/JSNotAnObject.h: Ditto.
+ * kjs/JSNumberCell.cpp:
+ (KJS::JSNumberCell::toPrimitive): Ditto.
+ * kjs/JSNumberCell.h:
+ (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no
+ other "slow" version of this once you have a JSNumberCell, so there's
+ no need for "fast" in the name. It's a feature that this hides the
+ base class toInt32, which does the same job less efficiently (and has
+ an additional ExecState argument).
+ (KJS::JSNumberCell::toUInt32): Ditto.
+
+ * kjs/JSObject.cpp:
+ (KJS::callDefaultValueFunction): Use isGetterSetter instead of type.
+ (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType.
+ (KJS::JSObject::defaultValue): Ditto.
+ (KJS::JSObject::defineGetter): Use isGetterSetter.
+ (KJS::JSObject::defineSetter): Ditto.
+ (KJS::JSObject::lookupGetter): Ditto.
+ (KJS::JSObject::lookupSetter): Ditto.
+ (KJS::JSObject::toNumber): Use PreferredPrimitiveType.
+ (KJS::JSObject::toString): Ditto.
+ (KJS::JSObject::isObject): Added.
+
+ * kjs/JSObject.h:
+ (KJS::JSObject::inherits): Call the isObject from JSCell; it's now
+ hidden by our override of isObject.
+ (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter
+ instead of type.
+ (KJS::JSObject::getOwnPropertySlot): Ditto.
+ (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
+
+ * kjs/JSString.cpp:
+ (KJS::JSString::toPrimitive): Use PreferredPrimitiveType.
+ (KJS::JSString::isString): Added.
+ * kjs/JSString.h: Ditto.
+
+ * kjs/JSValue.h: Removed type(), added isGetterSetter(). Added
+ PreferredPrimitiveType enum and used it as the argument for the
+ toPrimitive function.
+ (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
+
+ * kjs/collector.cpp:
+ (KJS::typeName): Changed to use JSCell::is functions instead of
+ calling JSCell::type.
+
+ * kjs/collector.h:
+ (KJS::Heap::isNumber): Renamed from fastIsNumber.
+
+ * kjs/nodes.h: Added now-needed include of JSType, since the type
+ is used here to record types of values in the tree.
+
+ * kjs/operations.cpp:
+ (KJS::equal): Rewrote to no longer depend on type().
+ (KJS::strictEqual): Ditto.
+
+2008-08-18 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ If there are no nodes in a profile all the time should be attributed to
+ (idle)
+
+ * profiler/Profile.cpp: If ther are no nodes make sure we still process
+ the head.
+ (KJS::Profile::forEach):
+ * profiler/ProfileGenerator.cpp: Remove some useless code.
+ (KJS::ProfileGenerator::stopProfiling):
+
+2008-08-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej.
+
+ Make JSGlobalContextRetain/Release actually work.
+
+ * API/JSContextRef.cpp:
+ (JSGlobalContextRetain):
+ (JSGlobalContextRelease):
+ Ref/deref global data to give checking for globalData.refCount() some sense.
+
+ * API/tests/testapi.c: (main): Added a test for this bug.
+
+ * kjs/JSGlobalData.cpp:
+ (KJS::JSGlobalData::~JSGlobalData):
+ While checking for memory leaks, found that JSGlobalData::emptyList has changed to
+ a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.
+
+2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej.
+
+ Change the counting of constants so that preincrement and predecrement of
+ const local variables are considered unexpected loads.
+
+ * kjs/nodes.cpp:
+ (KJS::PrefixResolveNode::emitCode):
+ * kjs/nodes.h:
+ (KJS::ScopeNode::neededConstants):
+
+2008-08-17 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ <rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
+ <https://bugs.webkit.org/show_bug.cgi?id=20386>
+
+ This crash was caused by "depth()" incorrectly determining the scope depth
+ of a 0 depth function without a full scope chain. Because such a function
+ would not have an activation the depth function would return the scope depth
+ of the parent frame, thus triggering an incorrect unwind. Any subsequent
+ look up that walked the scope chain would result in incorrect behaviour,
+ leading to a crash or incorrect variable resolution. This can only actually
+ happen in try...finally statements as that's the only path that can result in
+ the need to unwind the scope chain, but not force the function to need a
+ full scope chain.
+
+ The fix is simply to check for this case before attempting to walk the scope chain.
+
+ * VM/Machine.cpp:
+ (KJS::depth):
+ (KJS::Machine::throwException):
+
+2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej.
+
+ Bug 20419: Remove op_jless
+ <https://bugs.webkit.org/show_bug.cgi?id=20419>
+
+ Remove op_jless, which is rarely used now that we have op_loop_if_less.
+
+ * VM/CodeBlock.cpp:
+ (KJS::CodeBlock::dump):
+ * VM/CodeGenerator.cpp:
+ (KJS::CodeGenerator::emitJumpIfTrue):
+ * VM/Machine.cpp:
+ (KJS::Machine::privateExecute):
+ * VM/Opcode.h:
+
+2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Dan Bernstein.
+
+ Fix a typo in r35807 that is also causing build failures for
+ non-AllInOne builds.
+
+ * kjs/NumberConstructor.cpp:
+
+2008-08-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Made room for a free word in JSCell.
+
+ SunSpider says no change.
+
+ I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
+ store auxiliary data in a secondary structure.
+
+ I changed InternalFunction to store the function's name in the property
+ map.
+
+ I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
+ JSDOMWindowBaseData could inherit from it safely. (It's a strange design
+ for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
+ but that's really our only option, given the size constraint.)
+
+ I also added a bunch of compile-time ASSERTs, and removed lots of comments
+ in JSObject.h because they were often out of date, and they got in the
+ way of reading what was actually going on.
+
+ Also renamed JSArray::getLength to JSArray::length, to match our style
+ guidelines.
+
+2008-08-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Sped up property access for array.length and string.length by adding a
+ mechanism for returning a temporary value directly instead of returning
+ a pointer to a function that retrieves the value.
+
+ Also removed some unused cruft from PropertySlot.
+
+ SunSpider says 0.5% - 1.2% faster.
+
+ NOTE: This optimization is not a good idea in general, because it's
+ actually a pessimization in the case of resolve for assignment,
+ and it may get in the way of other optimizations in the future.
+
+2008-08-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Disable dead code stripping in debug builds.
+
+ * Configurations/Base.xcconfig:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+
+2008-08-15 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
+
+ * wtf/FastMalloc.cpp:
+ (WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
+ a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
+ (WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
+ be used when calculating local addresses.
+ (WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
+
+2008-08-15 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Geoff Garen.
+
+ <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
+
+ * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
+ between the Debug configuration and debug Production variant.
+ * JavaScriptCore.xcodeproj/project.pbxproj: Enable the debug variant.
+
+2008-08-15 Mark Rowe <mrowe@apple.com>
+
+ Fix the 64-bit build.
+
+ Add extra cast to avoid warnings about loss of precision when casting from
+ JSValue* to an integer type.
+
+ * kjs/JSImmediate.h:
+ (KJS::JSImmediate::intValue):
+ (KJS::JSImmediate::uintValue):
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Still fixing Windows build.
+
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString
+ to yet another place.
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Trying to fix non-Apple builds.
+
+ * ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
+
+2008-08-15 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
+ JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
+ JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
+ but instead holds an immediate value encoded within the pointer. This patch changes the
+ encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
+ a 31 bit value to be stored. All other immediates are tagged with the value 10, and
+ distinguished by a secondary tag.
+
+ Roughly +2% on SunSpider.
+
+ * kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
+ descption of new layout.
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ More build fixes.
+
+ * API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
+ * API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
+ * JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
+
+ * kjs/identifier.cpp:
+ (KJS::Identifier::checkSameIdentifierTable):
+ * kjs/identifier.h:
+ (KJS::Identifier::add):
+ Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be
+ non-inline in release builds, too.
+
+ * JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ JSStringRef is created context-free, but can get linked to one via an identifier table,
+ breaking an implicit API contract.
+
+ Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
+
+ * API/APICast.h: Removed toRef/toJS conversions for JSStringRef, as this is no longer a
+ simple typecast.
+
+ * kjs/identifier.cpp:
+ (KJS::Identifier::checkSameIdentifierTable):
+ * kjs/identifier.h:
+ (KJS::Identifier::add):
+ (KJS::UString::checkSameIdentifierTable):
+ Added assertions to verify that an identifier is not being added to a different JSGlobalData.
+
+ * API/JSObjectRef.cpp:
+ (OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray): Changed OpaqueJSPropertyNameArray to
+ hold JSStringRefs. This is necessary to avoid having to construct (and leak) a new instance
+ in JSPropertyNameArrayGetNameAtIndex(), now that making a JSStringRef is not just a typecast.
+
+ * API/OpaqueJSString.cpp: Added.
+ (OpaqueJSString::create):
+ (OpaqueJSString::ustring):
+ (OpaqueJSString::identifier):
+ * API/OpaqueJSString.h: Added.
+ (OpaqueJSString::create):
+ (OpaqueJSString::characters):
+ (OpaqueJSString::length):
+ (OpaqueJSString::OpaqueJSString):
+ (OpaqueJSString::~OpaqueJSString):
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax):
+ * API/JSCallbackObjectFunctions.h:
+ (KJS::::getOwnPropertySlot):
+ (KJS::::put):
+ (KJS::::deleteProperty):
+ (KJS::::staticValueGetter):
+ (KJS::::callbackGetter):
+ * API/JSStringRef.cpp:
+ (JSStringCreateWithCharacters):
+ (JSStringCreateWithUTF8CString):
+ (JSStringRetain):
+ (JSStringRelease):
+ (JSStringGetLength):
+ (JSStringGetCharactersPtr):
+ (JSStringGetMaximumUTF8CStringSize):
+ (JSStringGetUTF8CString):
+ (JSStringIsEqual):
+ * API/JSStringRefCF.cpp:
+ (JSStringCreateWithCFString):
+ (JSStringCopyCFString):
+ * API/JSValueRef.cpp:
+ (JSValueMakeString):
+ (JSValueToStringCopy):
+ Updated to use OpaqueJSString.
+
+ * GNUmakefile.am:
+ * JavaScriptCore.exp:
+ * JavaScriptCore.pri:
+ * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ * JavaScriptCoreSources.bkl:
+ Added OpaqueJSString.
+
+2008-08-14 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/6115819> Notify of profile in console
+ - Profiles now have a unique ID so that they can be linked to the
+ console message that announces that a profile completed.
+
+ * profiler/HeavyProfile.cpp:
+ (KJS::HeavyProfile::HeavyProfile):
+ * profiler/Profile.cpp:
+ (KJS::Profile::create):
+ (KJS::Profile::Profile):
+ * profiler/Profile.h:
+ (KJS::Profile::uid):
+ * profiler/ProfileGenerator.cpp:
+ (KJS::ProfileGenerator::create):
+ (KJS::ProfileGenerator::ProfileGenerator):
+ * profiler/ProfileGenerator.h:
+ * profiler/Profiler.cpp:
+ (KJS::Profiler::startProfiling):
+ * profiler/TreeProfile.cpp:
+ (KJS::TreeProfile::create):
+ (KJS::TreeProfile::TreeProfile):
+ * profiler/TreeProfile.h:
+
+2008-08-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
+ fillGetterProperty, which references a global function pointer,
+ out-of-line.
+
+ .2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
+ custom property access benchmark for objects with one property.
+
+ * kjs/JSObject.cpp:
+ (KJS::JSObject::fillGetterPropertySlot):
+
+2008-08-13 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20349
+ WTF::initializeThreading() fails if threading is already initialized
+
+ Fix threading initialization logic to support cases where
+ g_thread_init() has already been called elsewhere.
+
+ Resolves database-related crashers reported in several applications.
+
+ * wtf/ThreadingGtk.cpp:
+ (WTF::initializeThreading):
+
+2008-08-13 Brad Hughes <bhughes@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
+
+ The latest upgrade of the intel compiler allows us to compile all of
+ Qt with optimizations enabled (yay!).
+
+ * JavaScriptCore.pro:
+
+2008-08-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Add peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )
+
+ This is a very slight win in sunspider, and a fairly substantial win
+ in hot code that does if(!...), etc.
+
+ * VM/CodeGenerator.cpp:
+ (KJS::CodeGenerator::retrieveLastUnaryOp):
+ (KJS::CodeGenerator::rewindBinaryOp):
+ (KJS::CodeGenerator::rewindUnaryOp):
+ (KJS::CodeGenerator::emitJumpIfFalse):
+ * VM/CodeGenerator.h:
+
+2008-08-12 Dan Bernstein <mitz@apple.com>
+
+ - JavaScriptCore part of <rdar://problem/6121636>
+ Make fast*alloc() abort() on failure and add "try" variants that
+ return NULL on failure.
+
+ Reviewed by Darin Adler.
+
+ * JavaScriptCore.exp: Exported tryFastCalloc().
+ * VM/RegisterFile.h:
+ (KJS::RegisterFile::RegisterFile): Removed an ASSERT().
+ * kjs/JSArray.cpp:
+ (KJS::JSArray::putSlowCase): Changed to use tryFastRealloc().
+ (KJS::JSArray::increaseVectorLength): Ditto.
+ * kjs/ustring.cpp:
+ (KJS::allocChars): Changed to use tryFastMalloc().
+ (KJS::reallocChars): Changed to use tryFastRealloc().
+ * wtf/FastMalloc.cpp:
+ (WTF::fastZeroedMalloc): Removed null checking of fastMalloc()'s result
+ and removed extra call to InvokeNewHook().
+ (WTF::tryFastZeroedMalloc): Added. Uses tryFastMalloc().
+ (WTF::tryFastMalloc): Renamed fastMalloc() to this.
+ (WTF::fastMalloc): Added. This version abort()s if allocation fails.
+ (WTF::tryFastCalloc): Renamed fastCalloc() to this.
+ (WTF::fastCalloc): Added. This version abort()s if allocation fails.
+ (WTF::tryFastRealloc): Renamed fastRealloc() to this.
+ (WTF::fastRealloc): Added. This version abort()s if allocation fails.
+ (WTF::do_malloc): Made this a function template. When the abortOnFailure
+ template parameter is set, the function abort()s on failure to allocate.
+ Otherwise, it sets errno to ENOMEM and returns zero.
+ (WTF::TCMallocStats::fastMalloc): Defined to abort() on failure.
+ (WTF::TCMallocStats::tryFastMalloc): Added. Does not abort() on
+ failure.
+ (WTF::TCMallocStats::fastCalloc): Defined to abort() on failure.
+ (WTF::TCMallocStats::tryFastCalloc): Added. Does not abort() on
+ failure.
+ (WTF::TCMallocStats::fastRealloc): Defined to abort() on failure.
+ (WTF::TCMallocStats::tryFastRealloc): Added. Does not abort() on
+ failure.
+ * wtf/FastMalloc.h: Declared the "try" variants.
+
+2008-08-11 Adam Roben <aroben@apple.com>
+
+ Move WTF::notFound into its own header so that it can be used
+ independently of Vector
+
+ Rubberstamped by Darin Adler.
+
+ * JavaScriptCore.vcproj/WTF/WTF.vcproj:
+ * JavaScriptCore.xcodeproj/project.pbxproj:
+ Added NotFound.h to the project.
+ * wtf/NotFound.h: Added. Moved the notFound constant here...
+ * wtf/Vector.h: ...from here.
+
+2008-08-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit
+
+ * API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
+
+ * kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while
+ sweeping the heap.
+
+== Rolled over to ChangeLog-2008-08-10 ==
diff --git a/src/3rdparty/webkit/JavaScriptCore/DerivedSources.make b/src/3rdparty/webkit/JavaScriptCore/DerivedSources.make
index 4b33682..9eaccab 100644
--- a/src/3rdparty/webkit/JavaScriptCore/DerivedSources.make
+++ b/src/3rdparty/webkit/JavaScriptCore/DerivedSources.make
@@ -40,6 +40,7 @@ all : \
chartables.c \
DatePrototype.lut.h \
Grammar.cpp \
+ JSONObject.lut.h \
Lexer.lut.h \
MathObject.lut.h \
NumberConstructor.lut.h \
diff --git a/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.order b/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.order
index bb56e98..3ae3ec6 100644
--- a/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.order
+++ b/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.order
@@ -186,7 +186,7 @@ __Z10jscyyparsePv
__ZN3JSC5Lexer3lexEPvS1_
__ZN3JSC10Identifier3addEPNS_12JSGlobalDataEPKti
__ZN3WTF7HashSetIPN3JSC7UString3RepENS_7StrHashIS4_EENS_10HashTraitsIS4_EEE3addINS1_11UCharBufferENS1_21UCharBufferTranslatorEE
-__ZN3JSC15SegmentedVectorINS_10IdentifierELm64EE6appendIS1_EEvRKT_
+__ZN3WTF15SegmentedVectorINS_10IdentifierELm64EE6appendIS1_EEvRKT_
__ZNK3JSC9HashTable11createTableEPNS_12JSGlobalDataE
__ZN3JSC20ParserArenaDeletablenwEmPNS_12JSGlobalDataE
__ZN3WTF6VectorIPN3JSC20ParserArenaDeletableELm0EE15reserveCapacityEm
diff --git a/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.pri b/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.pri
index a7da71c..dbc467d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.pri
+++ b/src/3rdparty/webkit/JavaScriptCore/JavaScriptCore.pri
@@ -76,6 +76,7 @@ include(pcre/pcre.pri)
LUT_FILES += \
runtime/DatePrototype.cpp \
+ runtime/JSONObject.cpp \
runtime/NumberConstructor.cpp \
runtime/StringPrototype.cpp \
runtime/ArrayPrototype.cpp \
@@ -117,6 +118,7 @@ SOURCES += \
runtime/JSVariableObject.cpp \
runtime/JSActivation.cpp \
runtime/JSNotAnObject.cpp \
+ runtime/JSONObject.cpp \
runtime/LiteralParser.cpp \
runtime/TimeoutChecker.cpp \
bytecode/CodeBlock.cpp \
@@ -159,8 +161,8 @@ SOURCES += \
runtime/ConstructData.cpp \
wtf/CurrentTime.cpp \
runtime/DateConstructor.cpp \
+ runtime/DateConversion.cpp \
runtime/DateInstance.cpp \
- runtime/DateMath.cpp \
runtime/DatePrototype.cpp \
debugger/Debugger.cpp \
debugger/DebuggerCallFrame.cpp \
@@ -225,6 +227,7 @@ SOURCES += \
profiler/ProfileNode.cpp \
profiler/Profiler.cpp \
profiler/TreeProfile.cpp \
+ wtf/DateMath.cpp \
wtf/FastMalloc.cpp \
wtf/Threading.cpp \
wtf/qt/MainThreadQt.cpp
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/ARMv7Assembler.h b/src/3rdparty/webkit/JavaScriptCore/assembler/ARMv7Assembler.h
new file mode 100644
index 0000000..9745d6d
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/ARMv7Assembler.h
@@ -0,0 +1,1758 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef ARMAssembler_h
+#define ARMAssembler_h
+
+#include <wtf/Platform.h>
+
+#if ENABLE(ASSEMBLER) && PLATFORM_ARM_ARCH(7)
+
+#include "AssemblerBuffer.h"
+#include <wtf/Assertions.h>
+#include <wtf/Vector.h>
+#include <stdint.h>
+
+namespace JSC {
+
+namespace ARM {
+ typedef enum {
+ r0,
+ r1,
+ r2,
+ r3,
+ r4,
+ r5,
+ r6,
+ r7, wr = r7, // thumb work register
+ r8,
+ r9, sb = r9, // static base
+ r10, sl = r10, // stack limit
+ r11, fp = r11, // frame pointer
+ r12, ip = r12,
+ r13, sp = r13,
+ r14, lr = r14,
+ r15, pc = r15,
+ } RegisterID;
+
+ // s0 == d0 == q0
+ // s4 == d2 == q1
+ // etc
+ typedef enum {
+ s0 = 0,
+ s1 = 1,
+ s2 = 2,
+ s3 = 3,
+ s4 = 4,
+ s5 = 5,
+ s6 = 6,
+ s7 = 7,
+ s8 = 8,
+ s9 = 9,
+ s10 = 10,
+ s11 = 11,
+ s12 = 12,
+ s13 = 13,
+ s14 = 14,
+ s15 = 15,
+ s16 = 16,
+ s17 = 17,
+ s18 = 18,
+ s19 = 19,
+ s20 = 20,
+ s21 = 21,
+ s22 = 22,
+ s23 = 23,
+ s24 = 24,
+ s25 = 25,
+ s26 = 26,
+ s27 = 27,
+ s28 = 28,
+ s29 = 29,
+ s30 = 30,
+ s31 = 31,
+ d0 = 0 << 1,
+ d1 = 1 << 1,
+ d2 = 2 << 1,
+ d3 = 3 << 1,
+ d4 = 4 << 1,
+ d5 = 5 << 1,
+ d6 = 6 << 1,
+ d7 = 7 << 1,
+ d8 = 8 << 1,
+ d9 = 9 << 1,
+ d10 = 10 << 1,
+ d11 = 11 << 1,
+ d12 = 12 << 1,
+ d13 = 13 << 1,
+ d14 = 14 << 1,
+ d15 = 15 << 1,
+ d16 = 16 << 1,
+ d17 = 17 << 1,
+ d18 = 18 << 1,
+ d19 = 19 << 1,
+ d20 = 20 << 1,
+ d21 = 21 << 1,
+ d22 = 22 << 1,
+ d23 = 23 << 1,
+ d24 = 24 << 1,
+ d25 = 25 << 1,
+ d26 = 26 << 1,
+ d27 = 27 << 1,
+ d28 = 28 << 1,
+ d29 = 29 << 1,
+ d30 = 30 << 1,
+ d31 = 31 << 1,
+ q0 = 0 << 2,
+ q1 = 1 << 2,
+ q2 = 2 << 2,
+ q3 = 3 << 2,
+ q4 = 4 << 2,
+ q5 = 5 << 2,
+ q6 = 6 << 2,
+ q7 = 7 << 2,
+ q8 = 8 << 2,
+ q9 = 9 << 2,
+ q10 = 10 << 2,
+ q11 = 11 << 2,
+ q12 = 12 << 2,
+ q13 = 13 << 2,
+ q14 = 14 << 2,
+ q15 = 15 << 2,
+ q16 = 16 << 2,
+ q17 = 17 << 2,
+ q18 = 18 << 2,
+ q19 = 19 << 2,
+ q20 = 20 << 2,
+ q21 = 21 << 2,
+ q22 = 22 << 2,
+ q23 = 23 << 2,
+ q24 = 24 << 2,
+ q25 = 25 << 2,
+ q26 = 26 << 2,
+ q27 = 27 << 2,
+ q28 = 28 << 2,
+ q29 = 29 << 2,
+ q30 = 30 << 2,
+ q31 = 31 << 2,
+ } FPRegisterID;
+}
+
+class ARMv7Assembler;
+class ARMThumbImmediate {
+ friend class ARMv7Assembler;
+
+ typedef uint8_t ThumbImmediateType;
+ static const ThumbImmediateType TypeInvalid = 0;
+ static const ThumbImmediateType TypeEncoded = 1;
+ static const ThumbImmediateType TypeUInt16 = 2;
+
+ typedef union {
+ int16_t asInt;
+ struct {
+ unsigned imm8 : 8;
+ unsigned imm3 : 3;
+ unsigned i : 1;
+ unsigned imm4 : 4;
+ };
+ // If this is an encoded immediate, then it may describe a shift, or a pattern.
+ struct {
+ unsigned shiftValue7 : 7;
+ unsigned shiftAmount : 5;
+ };
+ struct {
+ unsigned immediate : 8;
+ unsigned pattern : 4;
+ };
+ } ThumbImmediateValue;
+
+ // byte0 contains least significant bit; not using an array to make client code endian agnostic.
+ typedef union {
+ int32_t asInt;
+ struct {
+ uint8_t byte0;
+ uint8_t byte1;
+ uint8_t byte2;
+ uint8_t byte3;
+ };
+ } PatternBytes;
+
+ ALWAYS_INLINE static int32_t countLeadingZerosPartial(uint32_t& value, int32_t& zeros, const int N)
+ {
+ if (value & ~((1<<N)-1)) /* check for any of the top N bits (of 2N bits) are set */ \
+ value >>= N; /* if any were set, lose the bottom N */ \
+ else /* if none of the top N bits are set, */ \
+ zeros += N; /* then we have identified N leading zeros */
+ }
+
+ static int32_t countLeadingZeros(uint32_t value)
+ {
+ if (!value)
+ return 32;
+
+ int32_t zeros = 0;
+ countLeadingZerosPartial(value, zeros, 16);
+ countLeadingZerosPartial(value, zeros, 8);
+ countLeadingZerosPartial(value, zeros, 4);
+ countLeadingZerosPartial(value, zeros, 2);
+ countLeadingZerosPartial(value, zeros, 1);
+ return zeros;
+ }
+
+ ARMThumbImmediate()
+ : m_type(TypeInvalid)
+ {
+ m_value.asInt = 0;
+ }
+
+ ARMThumbImmediate(ThumbImmediateType type, ThumbImmediateValue value)
+ : m_type(type)
+ , m_value(value)
+ {
+ }
+
+ ARMThumbImmediate(ThumbImmediateType type, uint16_t value)
+ : m_type(TypeUInt16)
+ {
+ m_value.asInt = value;
+ }
+
+public:
+ static ARMThumbImmediate makeEncodedImm(uint32_t value)
+ {
+ ThumbImmediateValue encoding;
+ encoding.asInt = 0;
+
+ // okay, these are easy.
+ if (value < 256) {
+ encoding.immediate = value;
+ encoding.pattern = 0;
+ return ARMThumbImmediate(TypeEncoded, encoding);
+ }
+
+ int32_t leadingZeros = countLeadingZeros(value);
+ // if there were 24 or more leading zeros, then we'd have hit the (value < 256) case.
+ ASSERT(leadingZeros < 24);
+
+ // Given a number with bit fields Z:B:C, where count(Z)+count(B)+count(C) == 32,
+ // Z are the bits known zero, B is the 8-bit immediate, C are the bits to check for
+ // zero. count(B) == 8, so the count of bits to be checked is 24 - count(Z).
+ int32_t rightShiftAmount = 24 - leadingZeros;
+ if (value == ((value >> rightShiftAmount) << rightShiftAmount)) {
+ // Shift the value down to the low byte position. The assign to
+ // shiftValue7 drops the implicit top bit.
+ encoding.shiftValue7 = value >> rightShiftAmount;
+ // The endoded shift amount is the magnitude of a right rotate.
+ encoding.shiftAmount = 8 + leadingZeros;
+ return ARMThumbImmediate(TypeEncoded, encoding);
+ }
+
+ PatternBytes bytes;
+ bytes.asInt = value;
+
+ if ((bytes.byte0 == bytes.byte1) && (bytes.byte0 == bytes.byte2) && (bytes.byte0 == bytes.byte3)) {
+ encoding.immediate = bytes.byte0;
+ encoding.pattern = 3;
+ return ARMThumbImmediate(TypeEncoded, encoding);
+ }
+
+ if ((bytes.byte0 == bytes.byte2) && !(bytes.byte1 | bytes.byte3)) {
+ encoding.immediate = bytes.byte0;
+ encoding.pattern = 1;
+ return ARMThumbImmediate(TypeEncoded, encoding);
+ }
+
+ if ((bytes.byte1 == bytes.byte3) && !(bytes.byte0 | bytes.byte2)) {
+ encoding.immediate = bytes.byte0;
+ encoding.pattern = 2;
+ return ARMThumbImmediate(TypeEncoded, encoding);
+ }
+
+ return ARMThumbImmediate();
+ }
+
+ static ARMThumbImmediate makeUInt12(int32_t value)
+ {
+ return (!(value & 0xfffff000))
+ ? ARMThumbImmediate(TypeUInt16, (uint16_t)value)
+ : ARMThumbImmediate();
+ }
+
+ static ARMThumbImmediate makeUInt12OrEncodedImm(int32_t value)
+ {
+ // If this is not a 12-bit unsigned it, try making an encoded immediate.
+ return (!(value & 0xfffff000))
+ ? ARMThumbImmediate(TypeUInt16, (uint16_t)value)
+ : makeEncodedImm(value);
+ }
+
+ // The 'make' methods, above, return a !isValid() value if the argument
+ // cannot be represented as the requested type. This methods is called
+ // 'get' since the argument can always be represented.
+ static ARMThumbImmediate makeUInt16(uint16_t value)
+ {
+ return ARMThumbImmediate(TypeUInt16, value);
+ }
+
+ bool isValid()
+ {
+ return m_type != TypeInvalid;
+ }
+
+ // These methods rely on the format of encoded byte values.
+ bool isUInt3() { return !(m_value.asInt & 0xfff8); }
+ bool isUInt4() { return !(m_value.asInt & 0xfff0); }
+ bool isUInt5() { return !(m_value.asInt & 0xffe0); }
+ bool isUInt6() { return !(m_value.asInt & 0xffc0); }
+ bool isUInt7() { return !(m_value.asInt & 0xff80); }
+ bool isUInt8() { return !(m_value.asInt & 0xff00); }
+ bool isUInt9() { return (m_type == TypeUInt16) && !(m_value.asInt & 0xfe00); }
+ bool isUInt10() { return (m_type == TypeUInt16) && !(m_value.asInt & 0xfc00); }
+ bool isUInt12() { return (m_type == TypeUInt16) && !(m_value.asInt & 0xf000); }
+ bool isUInt16() { return m_type == TypeUInt16; }
+ uint8_t getUInt3() { ASSERT(isUInt3()); return m_value.asInt; }
+ uint8_t getUInt4() { ASSERT(isUInt4()); return m_value.asInt; }
+ uint8_t getUInt5() { ASSERT(isUInt5()); return m_value.asInt; }
+ uint8_t getUInt6() { ASSERT(isUInt6()); return m_value.asInt; }
+ uint8_t getUInt7() { ASSERT(isUInt7()); return m_value.asInt; }
+ uint8_t getUInt8() { ASSERT(isUInt8()); return m_value.asInt; }
+ uint8_t getUInt9() { ASSERT(isUInt9()); return m_value.asInt; }
+ uint8_t getUInt10() { ASSERT(isUInt10()); return m_value.asInt; }
+ uint16_t getUInt12() { ASSERT(isUInt12()); return m_value.asInt; }
+ uint16_t getUInt16() { ASSERT(isUInt16()); return m_value.asInt; }
+
+ bool isEncodedImm() { return m_type == TypeEncoded; }
+
+private:
+ ThumbImmediateType m_type;
+ ThumbImmediateValue m_value;
+};
+
+
+typedef enum {
+ SRType_LSL,
+ SRType_LSR,
+ SRType_ASR,
+ SRType_ROR,
+
+ SRType_RRX = SRType_ROR
+} ARMShiftType;
+
+class ARMv7Assembler;
+class ShiftTypeAndAmount {
+ friend class ARMv7Assembler;
+
+public:
+ ShiftTypeAndAmount()
+ {
+ m_u.type = (ARMShiftType)0;
+ m_u.amount = 0;
+ }
+
+ ShiftTypeAndAmount(ARMShiftType type, unsigned amount)
+ {
+ m_u.type = type;
+ m_u.amount = amount & 31;
+ }
+
+ unsigned lo4() { return m_u.lo4; }
+ unsigned hi4() { return m_u.hi4; }
+
+private:
+ union {
+ struct {
+ unsigned lo4 : 4;
+ unsigned hi4 : 4;
+ };
+ struct {
+ unsigned type : 2;
+ unsigned amount : 5;
+ };
+ } m_u;
+};
+
+
+/*
+Some features of the Thumb instruction set are deprecated in ARMv7. Deprecated features affecting
+instructions supported by ARMv7-M are as follows:
+• use of the PC as <Rd> or <Rm> in a 16-bit ADD (SP plus register) instruction
+• use of the SP as <Rm> in a 16-bit ADD (SP plus register) instruction
+• use of the SP as <Rm> in a 16-bit CMP (register) instruction
+• use of MOV (register) instructions in which <Rd> is the SP or PC and <Rm> is also the SP or PC.
+• use of <Rn> as the lowest-numbered register in the register list of a 16-bit STM instruction with base
+register writeback
+*/
+
+class ARMv7Assembler {
+public:
+ typedef ARM::RegisterID RegisterID;
+ typedef ARM::FPRegisterID FPRegisterID;
+
+ // (HS, LO, HI, LS) -> (AE, B, A, BE)
+ // (VS, VC) -> (O, NO)
+ typedef enum {
+ ConditionEQ,
+ ConditionNE,
+ ConditionHS,
+ ConditionLO,
+ ConditionMI,
+ ConditionPL,
+ ConditionVS,
+ ConditionVC,
+ ConditionHI,
+ ConditionLS,
+ ConditionGE,
+ ConditionLT,
+ ConditionGT,
+ ConditionLE,
+ ConditionAL,
+
+ ConditionCS = ConditionHS,
+ ConditionCC = ConditionLO,
+ } Condition;
+
+ class JmpSrc {
+ friend class ARMv7Assembler;
+ friend class ARMInstructionFormatter;
+ public:
+ JmpSrc()
+ : m_offset(-1)
+ {
+ }
+
+ private:
+ JmpSrc(int offset)
+ : m_offset(offset)
+ {
+ }
+
+ int m_offset;
+ };
+
+ class JmpDst {
+ friend class ARMv7Assembler;
+ friend class ARMInstructionFormatter;
+ public:
+ JmpDst()
+ : m_offset(-1)
+ , m_used(false)
+ {
+ }
+
+ bool isUsed() const { return m_used; }
+ void used() { m_used = true; }
+ private:
+ JmpDst(int offset)
+ : m_offset(offset)
+ , m_used(false)
+ {
+ ASSERT(m_offset == offset);
+ }
+
+ int m_offset : 31;
+ int m_used : 1;
+ };
+
+private:
+
+ // ARMv7, Appx-A.6.3
+ bool BadReg(RegisterID reg)
+ {
+ return (reg == ARM::sp) || (reg == ARM::pc);
+ }
+
+ bool isSingleRegister(FPRegisterID reg)
+ {
+ // Check that the high bit isn't set (q16+), and that the low bit isn't (s1, s3, etc).
+ return !(reg & ~31);
+ }
+
+ bool isDoubleRegister(FPRegisterID reg)
+ {
+ // Check that the high bit isn't set (q16+), and that the low bit isn't (s1, s3, etc).
+ return !(reg & ~(31 << 1));
+ }
+
+ bool isQuadRegister(FPRegisterID reg)
+ {
+ return !(reg & ~(31 << 2));
+ }
+
+ uint32_t singleRegisterNum(FPRegisterID reg)
+ {
+ ASSERT(isSingleRegister(reg));
+ return reg;
+ }
+
+ uint32_t doubleRegisterNum(FPRegisterID reg)
+ {
+ ASSERT(isDoubleRegister(reg));
+ return reg >> 1;
+ }
+
+ uint32_t quadRegisterNum(FPRegisterID reg)
+ {
+ ASSERT(isQuadRegister(reg));
+ return reg >> 2;
+ }
+
+ uint32_t singleRegisterMask(FPRegisterID rd, int highBitsShift, int lowBitShift)
+ {
+ uint32_t rdNum = singleRegisterNum(rd);
+ uint32_t rdMask = (rdNum >> 1) << highBitsShift;
+ if (rdNum & 1)
+ rdMask |= 1 << lowBitShift;
+ return rdMask;
+ }
+
+ uint32_t doubleRegisterMask(FPRegisterID rd, int highBitShift, int lowBitsShift)
+ {
+ uint32_t rdNum = doubleRegisterNum(rd);
+ uint32_t rdMask = (rdNum & 0xf) << lowBitsShift;
+ if (rdNum & 16)
+ rdMask |= 1 << highBitShift;
+ return rdMask;
+ }
+
+ typedef enum {
+ OP_ADD_reg_T1 = 0x1800,
+ OP_ADD_S_reg_T1 = 0x1800,
+ OP_SUB_reg_T1 = 0x1A00,
+ OP_SUB_S_reg_T1 = 0x1A00,
+ OP_ADD_imm_T1 = 0x1C00,
+ OP_ADD_S_imm_T1 = 0x1C00,
+ OP_SUB_imm_T1 = 0x1E00,
+ OP_SUB_S_imm_T1 = 0x1E00,
+ OP_MOV_imm_T1 = 0x2000,
+ OP_CMP_imm_T1 = 0x2800,
+ OP_ADD_imm_T2 = 0x3000,
+ OP_ADD_S_imm_T2 = 0x3000,
+ OP_SUB_imm_T2 = 0x3800,
+ OP_SUB_S_imm_T2 = 0x3800,
+ OP_AND_reg_T1 = 0x4000,
+ OP_EOR_reg_T1 = 0x4040,
+ OP_TST_reg_T1 = 0x4200,
+ OP_CMP_reg_T1 = 0x4280,
+ OP_ORR_reg_T1 = 0x4300,
+ OP_MVN_reg_T1 = 0x43C0,
+ OP_ADD_reg_T2 = 0x4400,
+ OP_MOV_reg_T1 = 0x4600,
+ OP_BLX = 0x4700,
+ OP_BX = 0x4700,
+ OP_LDRH_reg_T1 = 0x5A00,
+ OP_STR_reg_T1 = 0x5000,
+ OP_LDR_reg_T1 = 0x5800,
+ OP_STR_imm_T1 = 0x6000,
+ OP_LDR_imm_T1 = 0x6800,
+ OP_LDRH_imm_T1 = 0x8800,
+ OP_STR_imm_T2 = 0x9000,
+ OP_LDR_imm_T2 = 0x9800,
+ OP_ADD_SP_imm_T1 = 0xA800,
+ OP_ADD_SP_imm_T2 = 0xB000,
+ OP_SUB_SP_imm_T1 = 0xB080,
+ OP_BKPT = 0xBE00,
+ OP_IT = 0xBF00,
+ } OpcodeID;
+
+ typedef enum {
+ OP_AND_reg_T2 = 0xEA00,
+ OP_TST_reg_T2 = 0xEA10,
+ OP_ORR_reg_T2 = 0xEA40,
+ OP_ASR_imm_T1 = 0xEA4F,
+ OP_LSL_imm_T1 = 0xEA4F,
+ OP_LSR_imm_T1 = 0xEA4F,
+ OP_ROR_imm_T1 = 0xEA4F,
+ OP_MVN_reg_T2 = 0xEA6F,
+ OP_EOR_reg_T2 = 0xEA80,
+ OP_ADD_reg_T3 = 0xEB00,
+ OP_ADD_S_reg_T3 = 0xEB10,
+ OP_SUB_reg_T2 = 0xEBA0,
+ OP_SUB_S_reg_T2 = 0xEBB0,
+ OP_CMP_reg_T2 = 0xEBB0,
+ OP_B_T4a = 0xF000,
+ OP_AND_imm_T1 = 0xF000,
+ OP_TST_imm = 0xF010,
+ OP_ORR_imm_T1 = 0xF040,
+ OP_MOV_imm_T2 = 0xF040,
+ OP_MVN_imm = 0xF060,
+ OP_EOR_imm_T1 = 0xF080,
+ OP_ADD_imm_T3 = 0xF100,
+ OP_ADD_S_imm_T3 = 0xF110,
+ OP_CMN_imm = 0xF110,
+ OP_SUB_imm_T3 = 0xF1A0,
+ OP_SUB_S_imm_T3 = 0xF1B0,
+ OP_CMP_imm_T2 = 0xF1B0,
+ OP_ADD_imm_T4 = 0xF200,
+ OP_MOV_imm_T3 = 0xF240,
+ OP_SUB_imm_T4 = 0xF2A0,
+ OP_MOVT = 0xF2C0,
+ OP_LDRH_reg_T2 = 0xF830,
+ OP_LDRH_imm_T3 = 0xF830,
+ OP_STR_imm_T4 = 0xF840,
+ OP_STR_reg_T2 = 0xF840,
+ OP_LDR_imm_T4 = 0xF850,
+ OP_LDR_reg_T2 = 0xF850,
+ OP_LDRH_imm_T2 = 0xF8B0,
+ OP_STR_imm_T3 = 0xF8C0,
+ OP_LDR_imm_T3 = 0xF8D0,
+ OP_LSL_reg_T2 = 0xFA00,
+ OP_LSR_reg_T2 = 0xFA20,
+ OP_ASR_reg_T2 = 0xFA40,
+ OP_ROR_reg_T2 = 0xFA60,
+ OP_SMULL_T1 = 0xFB80,
+ } OpcodeID1;
+
+ typedef enum {
+ OP_B_T4b = 0x9000,
+ } OpcodeID2;
+
+ struct FourFours {
+ FourFours(unsigned f3, unsigned f2, unsigned f1, unsigned f0)
+ {
+ m_u.f0 = f0;
+ m_u.f1 = f1;
+ m_u.f2 = f2;
+ m_u.f3 = f3;
+ }
+
+ union {
+ unsigned value;
+ struct {
+ unsigned f0 : 4;
+ unsigned f1 : 4;
+ unsigned f2 : 4;
+ unsigned f3 : 4;
+ };
+ } m_u;
+ };
+
+ class ARMInstructionFormatter;
+
+ // false means else!
+ bool ifThenElseConditionBit(Condition condition, bool isIf)
+ {
+ return isIf ? (condition & 1) : !(condition & 1);
+ }
+ uint8_t ifThenElse(Condition condition, bool inst2if, bool inst3if, bool inst4if)
+ {
+ int mask = (ifThenElseConditionBit(condition, inst2if) << 3)
+ | (ifThenElseConditionBit(condition, inst3if) << 2)
+ | (ifThenElseConditionBit(condition, inst4if) << 1)
+ | 1;
+ ASSERT((condition != ConditionAL) || (mask & (mask - 1)));
+ return (condition << 4) | mask;
+ }
+ uint8_t ifThenElse(Condition condition, bool inst2if, bool inst3if)
+ {
+ int mask = (ifThenElseConditionBit(condition, inst2if) << 3)
+ | (ifThenElseConditionBit(condition, inst3if) << 2)
+ | 2;
+ ASSERT((condition != ConditionAL) || (mask & (mask - 1)));
+ return (condition << 4) | mask;
+ }
+ uint8_t ifThenElse(Condition condition, bool inst2if)
+ {
+ int mask = (ifThenElseConditionBit(condition, inst2if) << 3)
+ | 4;
+ ASSERT((condition != ConditionAL) || (mask & (mask - 1)));
+ return (condition << 4) | mask;
+ }
+
+ uint8_t ifThenElse(Condition condition)
+ {
+ int mask = 8;
+ ASSERT((condition != ConditionAL) || (mask & (mask - 1)));
+ return (condition << 4) | mask;
+ }
+
+public:
+
+ void add(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ // Rd can only be SP if Rn is also SP.
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isValid());
+
+ if (rn == ARM::sp) {
+ if (!(rd & 8) && imm.isUInt10()) {
+ m_formatter.oneWordOp5Reg3Imm8(OP_ADD_SP_imm_T1, rd, imm.getUInt10() >> 2);
+ return;
+ } else if ((rd == ARM::sp) && imm.isUInt9()) {
+ m_formatter.oneWordOp9Imm7(OP_ADD_SP_imm_T2, imm.getUInt9() >> 2);
+ return;
+ }
+ } else if (!((rd | rn) & 8)) {
+ if (imm.isUInt3()) {
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_ADD_imm_T1, (RegisterID)imm.getUInt3(), rn, rd);
+ return;
+ } else if ((rd == rn) && imm.isUInt8()) {
+ m_formatter.oneWordOp5Reg3Imm8(OP_ADD_imm_T2, rd, imm.getUInt8());
+ return;
+ }
+ }
+
+ if (imm.isEncodedImm())
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_ADD_imm_T3, rn, rd, imm);
+ else {
+ ASSERT(imm.isUInt12());
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_ADD_imm_T4, rn, rd, imm);
+ }
+ }
+
+ void add(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_ADD_reg_T3, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ // NOTE: In an IT block, add doesn't modify the flags register.
+ void add(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if (rd == rn)
+ m_formatter.oneWordOp8RegReg143(OP_ADD_reg_T2, rm, rd);
+ else if (rd == rm)
+ m_formatter.oneWordOp8RegReg143(OP_ADD_reg_T2, rn, rd);
+ else if (!((rd | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_ADD_reg_T1, rm, rn, rd);
+ else
+ add(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ // Not allowed in an IT (if then) block.
+ void add_S(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ // Rd can only be SP if Rn is also SP.
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isEncodedImm());
+
+ if (!((rd | rn) & 8)) {
+ if (imm.isUInt3()) {
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_ADD_S_imm_T1, (RegisterID)imm.getUInt3(), rn, rd);
+ return;
+ } else if ((rd == rn) && imm.isUInt8()) {
+ m_formatter.oneWordOp5Reg3Imm8(OP_ADD_S_imm_T2, rd, imm.getUInt8());
+ return;
+ }
+ }
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_ADD_S_imm_T3, rn, rd, imm);
+ }
+
+ // Not allowed in an IT (if then) block?
+ void add_S(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_ADD_S_reg_T3, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ // Not allowed in an IT (if then) block.
+ void add_S(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if (!((rd | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_ADD_S_reg_T1, rm, rn, rd);
+ else
+ add_S(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ void ARM_and(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(imm.isEncodedImm());
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_AND_imm_T1, rn, rd, imm);
+ }
+
+ void ARM_and(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_AND_reg_T2, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void ARM_and(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if ((rd == rn) && !((rd | rm) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_AND_reg_T1, rm, rd);
+ else if ((rd == rm) && !((rd | rn) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_AND_reg_T1, rn, rd);
+ else
+ ARM_and(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ void asr(RegisterID rd, RegisterID rm, int32_t shiftAmount)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rm));
+ ShiftTypeAndAmount shift(SRType_ASR, shiftAmount);
+ m_formatter.twoWordOp16FourFours(OP_ASR_imm_T1, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void asr(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_ASR_reg_T2, rn, FourFours(0xf, rd, 0, rm));
+ }
+
+ // Only allowed in IT (if then) block if last instruction.
+ JmpSrc b()
+ {
+ m_formatter.twoWordOp16Op16(OP_B_T4a, OP_B_T4b);
+ return JmpSrc(m_formatter.size());
+ }
+
+ // Only allowed in IT (if then) block if last instruction.
+ JmpSrc blx(RegisterID rm)
+ {
+ ASSERT(rm != ARM::pc);
+ m_formatter.oneWordOp8RegReg143(OP_BLX, rm, (RegisterID)8);
+ return JmpSrc(m_formatter.size());
+ }
+
+ // Only allowed in IT (if then) block if last instruction.
+ JmpSrc bx(RegisterID rm)
+ {
+ m_formatter.oneWordOp8RegReg143(OP_BX, rm, (RegisterID)0);
+ return JmpSrc(m_formatter.size());
+ }
+
+ void bkpt(uint8_t imm=0)
+ {
+ m_formatter.oneWordOp8Imm8(OP_BKPT, imm);
+ }
+
+ void cmn(RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isEncodedImm());
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_CMN_imm, rn, (RegisterID)0xf, imm);
+ }
+
+ void cmp(RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isEncodedImm());
+
+ if (!(rn & 8) && imm.isUInt8())
+ m_formatter.oneWordOp5Reg3Imm8(OP_CMP_imm_T1, rn, imm.getUInt8());
+ else
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_CMP_imm_T2, rn, (RegisterID)0xf, imm);
+ }
+
+ void cmp(RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_CMP_reg_T2, rn, FourFours(shift.hi4(), 0xf, shift.lo4(), rm));
+ }
+
+ void cmp(RegisterID rn, RegisterID rm)
+ {
+ if ((rn | rm) & 8)
+ cmp(rn, rm, ShiftTypeAndAmount());
+ else
+ m_formatter.oneWordOp10Reg3Reg3(OP_CMP_reg_T1, rm, rn);
+ }
+
+ // xor is not spelled with an 'e'. :-(
+ void eor(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(imm.isEncodedImm());
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_EOR_imm_T1, rn, rd, imm);
+ }
+
+ // xor is not spelled with an 'e'. :-(
+ void eor(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_EOR_reg_T2, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ // xor is not spelled with an 'e'. :-(
+ void eor(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if ((rd == rn) && !((rd | rm) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_EOR_reg_T1, rm, rd);
+ else if ((rd == rm) && !((rd | rn) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_EOR_reg_T1, rn, rd);
+ else
+ eor(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ void it(Condition cond)
+ {
+ m_formatter.oneWordOp8Imm8(OP_IT, ifThenElse(cond));
+ }
+
+ void it(Condition cond, bool inst2if)
+ {
+ m_formatter.oneWordOp8Imm8(OP_IT, ifThenElse(cond, inst2if));
+ }
+
+ void it(Condition cond, bool inst2if, bool inst3if)
+ {
+ m_formatter.oneWordOp8Imm8(OP_IT, ifThenElse(cond, inst2if, inst3if));
+ }
+
+ void it(Condition cond, bool inst2if, bool inst3if, bool inst4if)
+ {
+ m_formatter.oneWordOp8Imm8(OP_IT, ifThenElse(cond, inst2if, inst3if, inst4if));
+ }
+
+ // rt == ARM::pc only allowed if last instruction in IT (if then) block.
+ void ldr(RegisterID rt, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(rn != ARM::pc); // LDR (literal)
+ ASSERT(imm.isUInt12());
+
+ if (!((rt | rn) & 8) && imm.isUInt7())
+ m_formatter.oneWordOp5Imm5Reg3Reg3(OP_LDR_imm_T1, imm.getUInt7() >> 2, rn, rt);
+ else if ((rn == ARM::sp) && !(rt & 8) && imm.isUInt10())
+ m_formatter.oneWordOp5Reg3Imm8(OP_LDR_imm_T2, rt, imm.getUInt10() >> 2);
+ else
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_LDR_imm_T3, rn, rt, imm.getUInt12());
+ }
+
+ // If index is set, this is a regular offset or a pre-indexed load;
+ // if index is not set then is is a post-index load.
+ //
+ // If wback is set rn is updated - this is a pre or post index load,
+ // if wback is not set this is a regular offset memory access.
+ //
+ // (-255 <= offset <= 255)
+ // _reg = REG[rn]
+ // _tmp = _reg + offset
+ // MEM[index ? _tmp : _reg] = REG[rt]
+ // if (wback) REG[rn] = _tmp
+ void ldr(RegisterID rt, RegisterID rn, int offset, bool index, bool wback)
+ {
+ ASSERT(rt != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(index || wback);
+ ASSERT(!wback | (rt != rn));
+
+ bool add = true;
+ if (offset < 0) {
+ add = false;
+ offset = -offset;
+ }
+ ASSERT((offset & ~0xff) == 0);
+
+ offset |= (wback << 8);
+ offset |= (add << 9);
+ offset |= (index << 10);
+ offset |= (1 << 11);
+
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_LDR_imm_T4, rn, rt, offset);
+ }
+
+ // rt == ARM::pc only allowed if last instruction in IT (if then) block.
+ void ldr(RegisterID rt, RegisterID rn, RegisterID rm, unsigned shift=0)
+ {
+ ASSERT(rn != ARM::pc); // LDR (literal)
+ ASSERT(!BadReg(rm));
+ ASSERT(shift <= 3);
+
+ if (!shift && !((rt | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_LDR_reg_T1, rm, rn, rt);
+ else
+ m_formatter.twoWordOp12Reg4FourFours(OP_LDR_reg_T2, rn, FourFours(rt, 0, shift, rm));
+ }
+
+ // rt == ARM::pc only allowed if last instruction in IT (if then) block.
+ void ldrh(RegisterID rt, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(rn != ARM::pc); // LDR (literal)
+ ASSERT(imm.isUInt12());
+
+ if (!((rt | rn) & 8) && imm.isUInt6())
+ m_formatter.oneWordOp5Imm5Reg3Reg3(OP_LDRH_imm_T1, imm.getUInt6() >> 2, rn, rt);
+ else
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_LDRH_imm_T2, rn, rt, imm.getUInt12());
+ }
+
+ // If index is set, this is a regular offset or a pre-indexed load;
+ // if index is not set then is is a post-index load.
+ //
+ // If wback is set rn is updated - this is a pre or post index load,
+ // if wback is not set this is a regular offset memory access.
+ //
+ // (-255 <= offset <= 255)
+ // _reg = REG[rn]
+ // _tmp = _reg + offset
+ // MEM[index ? _tmp : _reg] = REG[rt]
+ // if (wback) REG[rn] = _tmp
+ void ldrh(RegisterID rt, RegisterID rn, int offset, bool index, bool wback)
+ {
+ ASSERT(rt != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(index || wback);
+ ASSERT(!wback | (rt != rn));
+
+ bool add = true;
+ if (offset < 0) {
+ add = false;
+ offset = -offset;
+ }
+ ASSERT((offset & ~0xff) == 0);
+
+ offset |= (wback << 8);
+ offset |= (add << 9);
+ offset |= (index << 10);
+ offset |= (1 << 11);
+
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_LDRH_imm_T3, rn, rt, offset);
+ }
+
+ void ldrh(RegisterID rt, RegisterID rn, RegisterID rm, unsigned shift=0)
+ {
+ ASSERT(!BadReg(rt)); // Memory hint
+ ASSERT(rn != ARM::pc); // LDRH (literal)
+ ASSERT(!BadReg(rm));
+ ASSERT(shift <= 3);
+
+ if (!shift && !((rt | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_LDRH_reg_T1, rm, rn, rt);
+ else
+ m_formatter.twoWordOp12Reg4FourFours(OP_LDRH_reg_T2, rn, FourFours(rt, 0, shift, rm));
+ }
+
+ void lsl(RegisterID rd, RegisterID rm, int32_t shiftAmount)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rm));
+ ShiftTypeAndAmount shift(SRType_LSL, shiftAmount);
+ m_formatter.twoWordOp16FourFours(OP_LSL_imm_T1, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void lsl(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_LSL_reg_T2, rn, FourFours(0xf, rd, 0, rm));
+ }
+
+ void lsr(RegisterID rd, RegisterID rm, int32_t shiftAmount)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rm));
+ ShiftTypeAndAmount shift(SRType_LSR, shiftAmount);
+ m_formatter.twoWordOp16FourFours(OP_LSR_imm_T1, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void lsr(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_LSR_reg_T2, rn, FourFours(0xf, rd, 0, rm));
+ }
+
+ void movT3(RegisterID rd, ARMThumbImmediate imm)
+ {
+ ASSERT(imm.isValid());
+ ASSERT(!imm.isEncodedImm());
+ ASSERT(!BadReg(rd));
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_MOV_imm_T3, imm.m_value.imm4, rd, imm);
+ }
+
+ void mov(RegisterID rd, ARMThumbImmediate imm)
+ {
+ ASSERT(imm.isValid());
+ ASSERT(!BadReg(rd));
+
+ if ((rd < 8) && imm.isUInt8())
+ m_formatter.oneWordOp5Reg3Imm8(OP_MOV_imm_T1, rd, imm.getUInt8());
+ else if (imm.isEncodedImm())
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_MOV_imm_T2, 0xf, rd, imm);
+ else
+ movT3(rd, imm);
+ }
+
+ void mov(RegisterID rd, RegisterID rm)
+ {
+ m_formatter.oneWordOp8RegReg143(OP_MOV_reg_T1, rm, rd);
+ }
+
+ void movt(RegisterID rd, ARMThumbImmediate imm)
+ {
+ ASSERT(imm.isUInt16());
+ ASSERT(!BadReg(rd));
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_MOVT, imm.m_value.imm4, rd, imm);
+ }
+
+ void mvn(RegisterID rd, ARMThumbImmediate imm)
+ {
+ ASSERT(imm.isEncodedImm());
+ ASSERT(!BadReg(rd));
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_MVN_imm, 0xf, rd, imm);
+ }
+
+ void mvn(RegisterID rd, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp16FourFours(OP_MVN_reg_T2, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void mvn(RegisterID rd, RegisterID rm)
+ {
+ if (!((rd | rm) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_MVN_reg_T1, rm, rd);
+ else
+ mvn(rd, rm, ShiftTypeAndAmount());
+ }
+
+ void orr(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(imm.isEncodedImm());
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_ORR_imm_T1, rn, rd, imm);
+ }
+
+ void orr(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_ORR_reg_T2, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void orr(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if ((rd == rn) && !((rd | rm) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_ORR_reg_T1, rm, rd);
+ else if ((rd == rm) && !((rd | rn) & 8))
+ m_formatter.oneWordOp10Reg3Reg3(OP_ORR_reg_T1, rn, rd);
+ else
+ orr(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ void ror(RegisterID rd, RegisterID rm, int32_t shiftAmount)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rm));
+ ShiftTypeAndAmount shift(SRType_ROR, shiftAmount);
+ m_formatter.twoWordOp16FourFours(OP_ROR_imm_T1, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ void ror(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ ASSERT(!BadReg(rd));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_ROR_reg_T2, rn, FourFours(0xf, rd, 0, rm));
+ }
+
+ void smull(RegisterID rdLo, RegisterID rdHi, RegisterID rn, RegisterID rm)
+ {
+ ASSERT(!BadReg(rdLo));
+ ASSERT(!BadReg(rdHi));
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ ASSERT(rdLo != rdHi);
+ m_formatter.twoWordOp12Reg4FourFours(OP_SMULL_T1, rn, FourFours(rdLo, rdHi, 0, rm));
+ }
+
+ // rt == ARM::pc only allowed if last instruction in IT (if then) block.
+ void str(RegisterID rt, RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(rt != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isUInt12());
+
+ if (!((rt | rn) & 8) && imm.isUInt7())
+ m_formatter.oneWordOp5Imm5Reg3Reg3(OP_STR_imm_T1, imm.getUInt7() >> 2, rn, rt);
+ else if ((rn == ARM::sp) && !(rt & 8) && imm.isUInt10())
+ m_formatter.oneWordOp5Reg3Imm8(OP_STR_imm_T2, rt, imm.getUInt10() >> 2);
+ else
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_STR_imm_T3, rn, rt, imm.getUInt12());
+ }
+
+ // If index is set, this is a regular offset or a pre-indexed store;
+ // if index is not set then is is a post-index store.
+ //
+ // If wback is set rn is updated - this is a pre or post index store,
+ // if wback is not set this is a regular offset memory access.
+ //
+ // (-255 <= offset <= 255)
+ // _reg = REG[rn]
+ // _tmp = _reg + offset
+ // MEM[index ? _tmp : _reg] = REG[rt]
+ // if (wback) REG[rn] = _tmp
+ void str(RegisterID rt, RegisterID rn, int offset, bool index, bool wback)
+ {
+ ASSERT(rt != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(index || wback);
+ ASSERT(!wback | (rt != rn));
+
+ bool add = true;
+ if (offset < 0) {
+ add = false;
+ offset = -offset;
+ }
+ ASSERT((offset & ~0xff) == 0);
+
+ offset |= (wback << 8);
+ offset |= (add << 9);
+ offset |= (index << 10);
+ offset |= (1 << 11);
+
+ m_formatter.twoWordOp12Reg4Reg4Imm12(OP_STR_imm_T4, rn, rt, offset);
+ }
+
+ // rt == ARM::pc only allowed if last instruction in IT (if then) block.
+ void str(RegisterID rt, RegisterID rn, RegisterID rm, unsigned shift=0)
+ {
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ ASSERT(shift <= 3);
+
+ if (!shift && !((rt | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_STR_reg_T1, rm, rn, rt);
+ else
+ m_formatter.twoWordOp12Reg4FourFours(OP_STR_reg_T2, rn, FourFours(rt, 0, shift, rm));
+ }
+
+ void sub(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ // Rd can only be SP if Rn is also SP.
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isValid());
+
+ if ((rn == ARM::sp) && (rd == ARM::sp) && imm.isUInt9()) {
+ m_formatter.oneWordOp9Imm7(OP_SUB_SP_imm_T1, imm.getUInt9() >> 2);
+ return;
+ } else if (!((rd | rn) & 8)) {
+ if (imm.isUInt3()) {
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_SUB_imm_T1, (RegisterID)imm.getUInt3(), rn, rd);
+ return;
+ } else if ((rd == rn) && imm.isUInt8()) {
+ m_formatter.oneWordOp5Reg3Imm8(OP_SUB_imm_T2, rd, imm.getUInt8());
+ return;
+ }
+ }
+
+ if (imm.isEncodedImm())
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_SUB_imm_T3, rn, rd, imm);
+ else {
+ ASSERT(imm.isUInt12());
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_SUB_imm_T4, rn, rd, imm);
+ }
+ }
+
+ void sub(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_SUB_reg_T2, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ // NOTE: In an IT block, add doesn't modify the flags register.
+ void sub(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if (!((rd | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_SUB_reg_T1, rm, rn, rd);
+ else
+ sub(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ // Not allowed in an IT (if then) block.
+ void sub_S(RegisterID rd, RegisterID rn, ARMThumbImmediate imm)
+ {
+ // Rd can only be SP if Rn is also SP.
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(imm.isValid());
+
+ if ((rn == ARM::sp) && (rd == ARM::sp) && imm.isUInt9()) {
+ m_formatter.oneWordOp9Imm7(OP_SUB_SP_imm_T1, imm.getUInt9() >> 2);
+ return;
+ } else if (!((rd | rn) & 8)) {
+ if (imm.isUInt3()) {
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_SUB_S_imm_T1, (RegisterID)imm.getUInt3(), rn, rd);
+ return;
+ } else if ((rd == rn) && imm.isUInt8()) {
+ m_formatter.oneWordOp5Reg3Imm8(OP_SUB_S_imm_T2, rd, imm.getUInt8());
+ return;
+ }
+ }
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_SUB_S_imm_T3, rn, rd, imm);
+ }
+
+ // Not allowed in an IT (if then) block?
+ void sub_S(RegisterID rd, RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT((rd != ARM::sp) || (rn == ARM::sp));
+ ASSERT(rd != ARM::pc);
+ ASSERT(rn != ARM::pc);
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_SUB_S_reg_T2, rn, FourFours(shift.hi4(), rd, shift.lo4(), rm));
+ }
+
+ // Not allowed in an IT (if then) block.
+ void sub_S(RegisterID rd, RegisterID rn, RegisterID rm)
+ {
+ if (!((rd | rn | rm) & 8))
+ m_formatter.oneWordOp7Reg3Reg3Reg3(OP_SUB_S_reg_T1, rm, rn, rd);
+ else
+ sub_S(rd, rn, rm, ShiftTypeAndAmount());
+ }
+
+ void tst(RegisterID rn, ARMThumbImmediate imm)
+ {
+ ASSERT(!BadReg(rn));
+ ASSERT(imm.isEncodedImm());
+
+ m_formatter.twoWordOp5i6Imm4Reg4EncodedImm(OP_TST_imm, rn, (RegisterID)0xf, imm);
+ }
+
+ void tst(RegisterID rn, RegisterID rm, ShiftTypeAndAmount shift)
+ {
+ ASSERT(!BadReg(rn));
+ ASSERT(!BadReg(rm));
+ m_formatter.twoWordOp12Reg4FourFours(OP_TST_reg_T2, rn, FourFours(shift.hi4(), 0xf, shift.lo4(), rm));
+ }
+
+ void tst(RegisterID rn, RegisterID rm)
+ {
+ if ((rn | rm) & 8)
+ tst(rn, rm, ShiftTypeAndAmount());
+ else
+ m_formatter.oneWordOp10Reg3Reg3(OP_TST_reg_T1, rm, rn);
+ }
+
+ void vadd_F64(FPRegisterID rd, FPRegisterID rn, FPRegisterID rm)
+ {
+ m_formatter.vfpOp(0x0b00ee30 | doubleRegisterMask(rd, 6, 28) | doubleRegisterMask(rn, 23, 0) | doubleRegisterMask(rm, 21, 16));
+ }
+
+ void vcmp_F64(FPRegisterID rd, FPRegisterID rm)
+ {
+ m_formatter.vfpOp(0x0bc0eeb4 | doubleRegisterMask(rd, 6, 28) | doubleRegisterMask(rm, 21, 16));
+ }
+
+ void vcvt_F64_S32(FPRegisterID fd, FPRegisterID sm)
+ {
+ m_formatter.vfpOp(0x0bc0eeb8 | doubleRegisterMask(fd, 6, 28) | singleRegisterMask(sm, 16, 21));
+ }
+
+ void vcvt_S32_F64(FPRegisterID sd, FPRegisterID fm)
+ {
+ m_formatter.vfpOp(0x0bc0eebd | singleRegisterMask(sd, 28, 6) | doubleRegisterMask(fm, 21, 16));
+ }
+
+ void vldr(FPRegisterID rd, RegisterID rn, int32_t imm)
+ {
+ vmem(rd, rn, imm, true);
+ }
+
+ void vmov(RegisterID rd, FPRegisterID sn)
+ {
+ m_formatter.vfpOp(0x0a10ee10 | (rd << 28) | singleRegisterMask(sn, 0, 23));
+ }
+
+ void vmov(FPRegisterID sn, RegisterID rd)
+ {
+ m_formatter.vfpOp(0x0a10ee00 | (rd << 28) | singleRegisterMask(sn, 0, 23));
+ }
+
+ // move FPSCR flags to APSR.
+ void vmrs_APSR_nzcv_FPSCR()
+ {
+ m_formatter.vfpOp(0xfa10eef1);
+ }
+
+ void vmul_F64(FPRegisterID rd, FPRegisterID rn, FPRegisterID rm)
+ {
+ m_formatter.vfpOp(0x0b00ee20 | doubleRegisterMask(rd, 6, 28) | doubleRegisterMask(rn, 23, 0) | doubleRegisterMask(rm, 21, 16));
+ }
+
+ void vstr(FPRegisterID rd, RegisterID rn, int32_t imm)
+ {
+ vmem(rd, rn, imm, false);
+ }
+
+ void vsub_F64(FPRegisterID rd, FPRegisterID rn, FPRegisterID rm)
+ {
+ m_formatter.vfpOp(0x0b40ee30 | doubleRegisterMask(rd, 6, 28) | doubleRegisterMask(rn, 23, 0) | doubleRegisterMask(rm, 21, 16));
+ }
+
+
+ JmpDst label()
+ {
+ return JmpDst(m_formatter.size());
+ }
+
+ JmpDst align(int alignment)
+ {
+ while (!m_formatter.isAligned(alignment))
+ bkpt();
+
+ return label();
+ }
+
+ static void* getRelocatedAddress(void* code, JmpSrc jump)
+ {
+ ASSERT(jump.m_offset != -1);
+
+ return reinterpret_cast<void*>(reinterpret_cast<ptrdiff_t>(code) + jump.m_offset);
+ }
+
+ static void* getRelocatedAddress(void* code, JmpDst destination)
+ {
+ ASSERT(destination.m_offset != -1);
+
+ return reinterpret_cast<void*>(reinterpret_cast<ptrdiff_t>(code) + destination.m_offset);
+ }
+
+ static int getDifferenceBetweenLabels(JmpDst src, JmpDst dst)
+ {
+ return dst.m_offset - src.m_offset;
+ }
+
+ static int getDifferenceBetweenLabels(JmpDst src, JmpSrc dst)
+ {
+ return dst.m_offset - src.m_offset;
+ }
+
+ static int getDifferenceBetweenLabels(JmpSrc src, JmpDst dst)
+ {
+ return dst.m_offset - src.m_offset;
+ }
+
+ // Assembler admin methods:
+
+ size_t size() const
+ {
+ return m_formatter.size();
+ }
+
+ void* executableCopy(ExecutablePool* allocator)
+ {
+ void* copy = m_formatter.executableCopy(allocator);
+ ASSERT(copy);
+ return copy;
+ }
+
+ static unsigned getCallReturnOffset(JmpSrc call)
+ {
+ ASSERT(call.m_offset >= 0);
+ return call.m_offset;
+ }
+
+ // Linking & patching:
+ //
+ // 'link' and 'patch' methods are for use on unprotected code - such as the code
+ // within the AssemblerBuffer, and code being patched by the patch buffer. Once
+ // code has been finalized it is (platform support permitting) within a non-
+ // writable region of memory; to modify the code in an execute-only execuable
+ // pool the 'repatch' and 'relink' methods should be used.
+
+ void linkJump(JmpSrc from, JmpDst to)
+ {
+ ASSERT(to.m_offset != -1);
+ ASSERT(from.m_offset != -1);
+
+ uint16_t* location = reinterpret_cast<uint16_t*>(reinterpret_cast<intptr_t>(m_formatter.data()) + from.m_offset);
+ intptr_t relative = to.m_offset - from.m_offset;
+
+ linkWithOffset(location, relative);
+ }
+
+ static void linkJump(void* code, JmpSrc from, void* to)
+ {
+ ASSERT(from.m_offset != -1);
+
+ uint16_t* location = reinterpret_cast<uint16_t*>(reinterpret_cast<intptr_t>(code) + from.m_offset);
+ intptr_t relative = reinterpret_cast<intptr_t>(to) - reinterpret_cast<intptr_t>(location);
+
+ linkWithOffset(location, relative);
+ }
+
+ // bah, this mathod should really be static, since it is used by the LinkBuffer.
+ // return a bool saying whether the link was successful?
+ static void linkCall(void* code, JmpSrc from, void* to)
+ {
+ ASSERT(!(reinterpret_cast<intptr_t>(code) & 1));
+ ASSERT(from.m_offset != -1);
+ ASSERT(reinterpret_cast<intptr_t>(to) & 1);
+
+ patchPointer(reinterpret_cast<uint16_t*>(reinterpret_cast<intptr_t>(code) + from.m_offset) - 1, to);
+ }
+
+ static void patchPointer(void* code, JmpDst where, void* value)
+ {
+ patchPointer(reinterpret_cast<char*>(code) + where.m_offset, value);
+ }
+
+ static void relinkJump(void* from, void* to)
+ {
+ ExecutableAllocator::MakeWritable unprotect(reinterpret_cast<uint16_t*>(from) - 2, 2 * sizeof(uint16_t));
+
+ ASSERT(!(reinterpret_cast<intptr_t>(from) & 1));
+ ASSERT(!(reinterpret_cast<intptr_t>(to) & 1));
+
+ intptr_t relative = reinterpret_cast<intptr_t>(to) - reinterpret_cast<intptr_t>(from);
+ linkWithOffset(reinterpret_cast<uint16_t*>(from), relative);
+ }
+
+ static void relinkCall(void* from, void* to)
+ {
+ ExecutableAllocator::MakeWritable unprotect(reinterpret_cast<uint16_t*>(from) - 5, 4 * sizeof(uint16_t));
+
+ ASSERT(!(reinterpret_cast<intptr_t>(from) & 1));
+ ASSERT(reinterpret_cast<intptr_t>(to) & 1);
+
+ patchPointer(reinterpret_cast<uint16_t*>(from) - 1, to);
+ }
+
+ static void repatchInt32(void* where, int32_t value)
+ {
+ ExecutableAllocator::MakeWritable unprotect(reinterpret_cast<uint16_t*>(where) - 4, 4 * sizeof(uint16_t));
+
+ ASSERT(!(reinterpret_cast<intptr_t>(where) & 1));
+
+ patchInt32(where, value);
+ }
+
+ static void repatchPointer(void* where, void* value)
+ {
+ ExecutableAllocator::MakeWritable unprotect(reinterpret_cast<uint16_t*>(where) - 4, 4 * sizeof(uint16_t));
+
+ ASSERT(!(reinterpret_cast<intptr_t>(where) & 1));
+
+ patchPointer(where, value);
+ }
+
+ static void repatchLoadPtrToLEA(void* where)
+ {
+ ASSERT(!(reinterpret_cast<intptr_t>(where) & 1));
+
+ uint16_t* loadOp = reinterpret_cast<uint16_t*>(where) + 4;
+ ASSERT((*loadOp & 0xfff0) == OP_LDR_reg_T2);
+
+ ExecutableAllocator::MakeWritable unprotect(loadOp, sizeof(uint16_t));
+ *loadOp = OP_ADD_reg_T3 | (*loadOp & 0xf);
+ }
+
+private:
+
+ // Arm vfp addresses can be offset by a 9-bit ones-comp immediate, left shifted by 2.
+ // (i.e. +/-(0..255) 32-bit words)
+ void vmem(FPRegisterID rd, RegisterID rn, int32_t imm, bool isLoad)
+ {
+ bool up;
+ uint32_t offset;
+ if (imm < 0) {
+ offset = -imm;
+ up = false;
+ } else {
+ offset = imm;
+ up = true;
+ }
+
+ // offset is effectively leftshifted by 2 already (the bottom two bits are zero, and not
+ // reperesented in the instruction. Left shift by 14, to mov it into position 0x00AA0000.
+ ASSERT((offset & ~(0xff << 2)) == 0);
+ offset <<= 14;
+
+ m_formatter.vfpOp(0x0b00ed00 | offset | (up << 7) | (isLoad << 4) | doubleRegisterMask(rd, 6, 28) | rn);
+ }
+
+ static void patchInt32(void* code, uint32_t value)
+ {
+ uint16_t* location = reinterpret_cast<uint16_t*>(code);
+
+ ExecutableAllocator::MakeWritable unprotect(location - 4, 4 * sizeof(uint16_t));
+
+ uint16_t lo16 = value;
+ uint16_t hi16 = value >> 16;
+
+ spliceHi5(location - 4, lo16);
+ spliceLo11(location - 3, lo16);
+ spliceHi5(location - 2, hi16);
+ spliceLo11(location - 1, hi16);
+ }
+
+ static void patchPointer(void* code, void* value)
+ {
+ patchInt32(code, reinterpret_cast<uint32_t>(value));
+ }
+
+ // Linking & patching:
+ // This method assumes that the JmpSrc being linked is a T4 b instruction.
+ static void linkWithOffset(uint16_t* instruction, intptr_t relative)
+ {
+ // Currently branches > 16m = mostly deathy.
+ if (((relative << 7) >> 7) != relative) {
+ // FIXME: This CRASH means we cannot turn the JIT on by default on arm-v7.
+ fprintf(stderr, "Error: Cannot link T4b.\n");
+ CRASH();
+ }
+
+ // ARM encoding for the top two bits below the sign bit is 'peculiar'.
+ if (relative >= 0)
+ relative ^= 0xC00000;
+
+ // All branch offsets should be an even distance.
+ ASSERT(!(relative & 1));
+
+ int word1 = ((relative & 0x1000000) >> 14) | ((relative & 0x3ff000) >> 12);
+ int word2 = ((relative & 0x800000) >> 10) | ((relative & 0x400000) >> 11) | ((relative & 0xffe) >> 1);
+
+ instruction[-2] = OP_B_T4a | word1;
+ instruction[-1] = OP_B_T4b | word2;
+ }
+
+ // These functions can be used to splice 16-bit immediates back into previously generated instructions.
+ static void spliceHi5(uint16_t* where, uint16_t what)
+ {
+ uint16_t pattern = (what >> 12) | ((what & 0x0800) >> 1);
+ *where = (*where & 0xFBF0) | pattern;
+ }
+ static void spliceLo11(uint16_t* where, uint16_t what)
+ {
+ uint16_t pattern = ((what & 0x0700) << 4) | (what & 0x00FF);
+ *where = (*where & 0x8F00) | pattern;
+ }
+
+ class ARMInstructionFormatter {
+ public:
+ void oneWordOp5Reg3Imm8(OpcodeID op, RegisterID rd, uint8_t imm)
+ {
+ m_buffer.putShort(op | (rd << 8) | imm);
+ }
+
+ void oneWordOp5Imm5Reg3Reg3(OpcodeID op, uint8_t imm, RegisterID reg1, RegisterID reg2)
+ {
+ m_buffer.putShort(op | (imm << 6) | (reg1 << 3) | reg2);
+ }
+
+ void oneWordOp7Reg3Reg3Reg3(OpcodeID op, RegisterID reg1, RegisterID reg2, RegisterID reg3)
+ {
+ m_buffer.putShort(op | (reg1 << 6) | (reg2 << 3) | reg3);
+ }
+
+ void oneWordOp8Imm8(OpcodeID op, uint8_t imm)
+ {
+ m_buffer.putShort(op | imm);
+ }
+
+ void oneWordOp8RegReg143(OpcodeID op, RegisterID reg1, RegisterID reg2)
+ {
+ m_buffer.putShort(op | ((reg2 & 8) << 4) | (reg1 << 3) | (reg2 & 7));
+ }
+ void oneWordOp9Imm7(OpcodeID op, uint8_t imm)
+ {
+ m_buffer.putShort(op | imm);
+ }
+
+ void oneWordOp10Reg3Reg3(OpcodeID op, RegisterID reg1, RegisterID reg2)
+ {
+ m_buffer.putShort(op | (reg1 << 3) | reg2);
+ }
+
+ void twoWordOp12Reg4FourFours(OpcodeID1 op, RegisterID reg, FourFours ff)
+ {
+ m_buffer.putShort(op | reg);
+ m_buffer.putShort(ff.m_u.value);
+ }
+
+ void twoWordOp16FourFours(OpcodeID1 op, FourFours ff)
+ {
+ m_buffer.putShort(op);
+ m_buffer.putShort(ff.m_u.value);
+ }
+
+ void twoWordOp16Op16(OpcodeID1 op1, OpcodeID2 op2)
+ {
+ m_buffer.putShort(op1);
+ m_buffer.putShort(op2);
+ }
+
+ void twoWordOp5i6Imm4Reg4EncodedImm(OpcodeID1 op, int imm4, RegisterID rd, ARMThumbImmediate imm)
+ {
+ m_buffer.putShort(op | (imm.m_value.i << 10) | imm4);
+ m_buffer.putShort((imm.m_value.imm3 << 12) | (rd << 8) | imm.m_value.imm8);
+ }
+
+ void twoWordOp12Reg4Reg4Imm12(OpcodeID1 op, RegisterID reg1, RegisterID reg2, uint16_t imm)
+ {
+ m_buffer.putShort(op | reg1);
+ m_buffer.putShort((reg2 << 12) | imm);
+ }
+
+ void vfpOp(int32_t op)
+ {
+ m_buffer.putInt(op);
+ }
+
+
+ // Administrative methods:
+
+ size_t size() const { return m_buffer.size(); }
+ bool isAligned(int alignment) const { return m_buffer.isAligned(alignment); }
+ void* data() const { return m_buffer.data(); }
+ void* executableCopy(ExecutablePool* allocator) { return m_buffer.executableCopy(allocator); }
+
+ private:
+ AssemblerBuffer m_buffer;
+ } m_formatter;
+};
+
+} // namespace JSC
+
+#endif // ENABLE(ASSEMBLER) && PLATFORM_ARM_ARCH(7)
+
+#endif // ARMAssembler_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/AbstractMacroAssembler.h b/src/3rdparty/webkit/JavaScriptCore/assembler/AbstractMacroAssembler.h
index 5def60f..cf94677 100644
--- a/src/3rdparty/webkit/JavaScriptCore/assembler/AbstractMacroAssembler.h
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/AbstractMacroAssembler.h
@@ -29,6 +29,7 @@
#include <wtf/Platform.h>
#include <MacroAssemblerCodeRef.h>
+#include <CodeLocation.h>
#include <wtf/Noncopyable.h>
#include <wtf/UnusedParam.h>
@@ -48,15 +49,8 @@ public:
typedef MacroAssemblerCodeRef CodeRef;
class Jump;
- class PatchBuffer;
- class CodeLocationInstruction;
- class CodeLocationLabel;
- class CodeLocationJump;
- class CodeLocationCall;
- class CodeLocationNearCall;
- class CodeLocationDataLabel32;
- class CodeLocationDataLabelPtr;
- class ProcessorReturnAddress;
+ class LinkBuffer;
+ class RepatchBuffer;
typedef typename AssemblerType::RegisterID RegisterID;
typedef typename AssemblerType::FPRegisterID FPRegisterID;
@@ -181,17 +175,32 @@ public:
struct Imm32 {
explicit Imm32(int32_t value)
: m_value(value)
+#if PLATFORM_ARM_ARCH(7)
+ , m_isPointer(false)
+#endif
{
}
#if !PLATFORM(X86_64)
explicit Imm32(ImmPtr ptr)
: m_value(ptr.asIntptr())
+#if PLATFORM_ARM_ARCH(7)
+ , m_isPointer(true)
+#endif
{
}
#endif
int32_t m_value;
+#if PLATFORM_ARM_ARCH(7)
+ // We rely on being able to regenerate code to recover exception handling
+ // information. Since ARMv7 supports 16-bit immediates there is a danger
+ // that if pointer values change the layout of the generated code will change.
+ // To avoid this problem, always generate pointers (and thus Imm32s constructed
+ // from ImmPtrs) with a code sequence that is able to represent any pointer
+ // value - don't use a more compact form in these cases.
+ bool m_isPointer;
+#endif
};
@@ -212,7 +221,7 @@ public:
friend class AbstractMacroAssembler;
friend class Jump;
friend class MacroAssemblerCodeRef;
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
Label()
@@ -237,7 +246,7 @@ public:
class DataLabelPtr {
template<class TemplateAssemblerType>
friend class AbstractMacroAssembler;
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
DataLabelPtr()
{
@@ -259,7 +268,7 @@ public:
class DataLabel32 {
template<class TemplateAssemblerType>
friend class AbstractMacroAssembler;
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
DataLabel32()
{
@@ -283,7 +292,7 @@ public:
class Call {
template<class TemplateAssemblerType>
friend class AbstractMacroAssembler;
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
enum Flags {
None = 0x0,
@@ -328,7 +337,7 @@ public:
template<class TemplateAssemblerType>
friend class AbstractMacroAssembler;
friend class Call;
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
Jump()
{
@@ -358,7 +367,7 @@ public:
// A JumpList is a set of Jump objects.
// All jumps in the set will be linked to the same destination.
class JumpList {
- friend class PatchBuffer;
+ friend class LinkBuffer;
public:
void link(AbstractMacroAssembler<AssemblerType>* masm)
@@ -397,343 +406,14 @@ public:
};
- // Section 3: MacroAssembler JIT instruction stream handles.
- //
- // The MacroAssembler supported facilities to modify a JIT generated
- // instruction stream after it has been generated (relinking calls and
- // jumps, and repatching data values). The following types are used
- // to store handles into the underlying instruction stream, the type
- // providing semantic information as to what it is that is in the
- // instruction stream at this point, and thus what operations may be
- // performed on it.
-
-
- // CodeLocationCommon:
- //
- // Base type for other CodeLocation* types. A postion in the JIT genertaed
- // instruction stream, without any semantic information.
- class CodeLocationCommon {
- public:
- CodeLocationCommon()
- {
- }
-
- // In order to avoid the need to store multiple handles into the
- // instructions stream, where the code generation is deterministic
- // and the labels will always be a fixed distance apart, these
- // methods may be used to recover a handle that has nopw been
- // retained, based on a known fixed relative offset from one that has.
- CodeLocationInstruction instructionAtOffset(int offset);
- CodeLocationLabel labelAtOffset(int offset);
- CodeLocationJump jumpAtOffset(int offset);
- CodeLocationCall callAtOffset(int offset);
- CodeLocationNearCall nearCallAtOffset(int offset);
- CodeLocationDataLabelPtr dataLabelPtrAtOffset(int offset);
- CodeLocationDataLabel32 dataLabel32AtOffset(int offset);
-
- protected:
- explicit CodeLocationCommon(CodePtr location)
- : m_location(location)
- {
- }
-
- void* dataLocation() { return m_location.dataLocation(); }
- void* executableAddress() { return m_location.executableAddress(); }
-
- void reset()
- {
- m_location = CodePtr();
- }
-
- private:
- CodePtr m_location;
- };
-
- // CodeLocationInstruction:
- //
- // An arbitrary instruction in the JIT code.
- class CodeLocationInstruction : public CodeLocationCommon {
- friend class CodeLocationCommon;
- public:
- CodeLocationInstruction()
- {
- }
-
- void repatchLoadPtrToLEA()
- {
- AssemblerType::repatchLoadPtrToLEA(this->dataLocation());
- }
-
- private:
- explicit CodeLocationInstruction(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // CodeLocationLabel:
- //
- // A point in the JIT code maked with a label.
- class CodeLocationLabel : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class CodeLocationJump;
- friend class CodeLocationCall;
- friend class CodeLocationNearCall;
- friend class PatchBuffer;
- friend class ProcessorReturnAddress;
-
- public:
- CodeLocationLabel()
- {
- }
-
- void* addressForSwitch() { return this->executableAddress(); }
- void* addressForExceptionHandler() { return this->executableAddress(); }
- void* addressForJSR() { return this->executableAddress(); }
-
- bool operator!()
- {
- return !this->executableAddress();
- }
-
- void reset()
- {
- CodeLocationCommon::reset();
- }
-
- private:
- explicit CodeLocationLabel(CodePtr location)
- : CodeLocationCommon(location)
- {
- }
-
- explicit CodeLocationLabel(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
-
- void* getJumpDestination() { return this->executableAddress(); }
- };
-
- // CodeLocationJump:
- //
- // A point in the JIT code at which there is a jump instruction.
- class CodeLocationJump : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class PatchBuffer;
- public:
- CodeLocationJump()
- {
- }
-
- void relink(CodeLocationLabel destination)
- {
- AssemblerType::relinkJump(this->dataLocation(), destination.executableAddress());
- }
-
- private:
- explicit CodeLocationJump(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // CodeLocationCall:
- //
- // A point in the JIT code at which there is a call instruction.
- class CodeLocationCall : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class PatchBuffer;
- friend class ProcessorReturnAddress;
- public:
- CodeLocationCall()
- {
- }
-
- void relink(CodeLocationLabel destination)
- {
-#if PLATFORM(X86_64)
- CodeLocationCommon::dataLabelPtrAtOffset(-REPTACH_OFFSET_CALL_R11).repatch(destination.executableAddress());
-#else
- AssemblerType::relinkCall(this->dataLocation(), destination.executableAddress());
-#endif
- }
-
- void relink(FunctionPtr destination)
- {
-#if PLATFORM(X86_64)
- CodeLocationCommon::dataLabelPtrAtOffset(-REPTACH_OFFSET_CALL_R11).repatch(destination.executableAddress());
-#else
- AssemblerType::relinkCall(this->dataLocation(), destination.executableAddress());
-#endif
- }
-
- // This methods returns the value that will be set as the return address
- // within a function that has been called from this call instruction.
- void* calleeReturnAddressValue()
- {
- return this->executableAddress();
- }
-
- private:
- explicit CodeLocationCall(CodePtr location)
- : CodeLocationCommon(location)
- {
- }
-
- explicit CodeLocationCall(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // CodeLocationNearCall:
- //
- // A point in the JIT code at which there is a call instruction with near linkage.
- class CodeLocationNearCall : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class PatchBuffer;
- friend class ProcessorReturnAddress;
- public:
- CodeLocationNearCall()
- {
- }
-
- void relink(CodePtr destination)
- {
- AssemblerType::relinkCall(this->dataLocation(), destination.executableAddress());
- }
-
- void relink(CodeLocationLabel destination)
- {
- AssemblerType::relinkCall(this->dataLocation(), destination.executableAddress());
- }
-
- void relink(FunctionPtr destination)
- {
- AssemblerType::relinkCall(this->dataLocation(), destination.executableAddress());
- }
-
- // This methods returns the value that will be set as the return address
- // within a function that has been called from this call instruction.
- void* calleeReturnAddressValue()
- {
- return this->executableAddress();
- }
-
- private:
- explicit CodeLocationNearCall(CodePtr location)
- : CodeLocationCommon(location)
- {
- }
-
- explicit CodeLocationNearCall(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // CodeLocationDataLabel32:
- //
- // A point in the JIT code at which there is an int32_t immediate that may be repatched.
- class CodeLocationDataLabel32 : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class PatchBuffer;
- public:
- CodeLocationDataLabel32()
- {
- }
-
- void repatch(int32_t value)
- {
- AssemblerType::repatchInt32(this->dataLocation(), value);
- }
-
- private:
- explicit CodeLocationDataLabel32(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // CodeLocationDataLabelPtr:
- //
- // A point in the JIT code at which there is a void* immediate that may be repatched.
- class CodeLocationDataLabelPtr : public CodeLocationCommon {
- friend class CodeLocationCommon;
- friend class PatchBuffer;
- public:
- CodeLocationDataLabelPtr()
- {
- }
-
- void repatch(void* value)
- {
- AssemblerType::repatchPointer(this->dataLocation(), value);
- }
-
- private:
- explicit CodeLocationDataLabelPtr(void* location)
- : CodeLocationCommon(CodePtr(location))
- {
- }
- };
-
- // ProcessorReturnAddress:
- //
- // This class can be used to relink a call identified by its return address.
- class ProcessorReturnAddress {
- friend class CodeLocationCall;
- friend class CodeLocationNearCall;
- public:
- ProcessorReturnAddress(void* location)
- : m_location(location)
- {
- }
-
- void relinkCallerToTrampoline(CodeLocationLabel label)
- {
- CodeLocationCall(CodePtr(m_location)).relink(label);
- }
-
- void relinkCallerToTrampoline(CodePtr newCalleeFunction)
- {
- relinkCallerToTrampoline(CodeLocationLabel(newCalleeFunction));
- }
-
- void relinkCallerToFunction(FunctionPtr function)
- {
- CodeLocationCall(CodePtr(m_location)).relink(function);
- }
-
- void relinkNearCallerToTrampoline(CodeLocationLabel label)
- {
- CodeLocationNearCall(CodePtr(m_location)).relink(label);
- }
-
- void relinkNearCallerToTrampoline(CodePtr newCalleeFunction)
- {
- relinkNearCallerToTrampoline(CodeLocationLabel(newCalleeFunction));
- }
-
- void* addressForLookup()
- {
- return m_location.value();
- }
-
- private:
- ReturnAddressPtr m_location;
- };
-
-
- // Section 4: PatchBuffer - utility to finalize code generation.
+ // Section 3: LinkBuffer - utility to finalize code generation.
static CodePtr trampolineAt(CodeRef ref, Label label)
{
return CodePtr(AssemblerType::getRelocatedAddress(ref.m_code.dataLocation(), label.m_label));
}
- // PatchBuffer:
+ // LinkBuffer:
//
// This class assists in linking code generated by the macro assembler, once code generation
// has been completed, and the code has been copied to is final location in memory. At this
@@ -750,12 +430,12 @@ public:
// FIXME: distinguish between Calls & Jumps (make a specific call to obtain the return
// address of calls, as opposed to a point that can be used to later relink a Jump -
// possibly wrap the later up in an object that can do just that).
- class PatchBuffer : public Noncopyable {
+ class LinkBuffer : public Noncopyable {
public:
// Note: Initialization sequence is significant, since executablePool is a PassRefPtr.
// First, executablePool is copied into m_executablePool, then the initialization of
// m_code uses m_executablePool, *not* executablePool, since this is no longer valid.
- PatchBuffer(AbstractMacroAssembler<AssemblerType>* masm, PassRefPtr<ExecutablePool> executablePool)
+ LinkBuffer(AbstractMacroAssembler<AssemblerType>* masm, PassRefPtr<ExecutablePool> executablePool)
: m_executablePool(executablePool)
, m_code(masm->m_assembler.executableCopy(m_executablePool.get()))
, m_size(masm->m_assembler.size())
@@ -765,7 +445,7 @@ public:
{
}
- ~PatchBuffer()
+ ~LinkBuffer()
{
ASSERT(m_completed);
}
@@ -786,13 +466,13 @@ public:
void link(Jump jump, CodeLocationLabel label)
{
- AssemblerType::linkJump(code(), jump.m_jmp, label.executableAddress());
+ AssemblerType::linkJump(code(), jump.m_jmp, label.dataLocation());
}
void link(JumpList list, CodeLocationLabel label)
{
for (unsigned i = 0; i < list.m_jumps.size(); ++i)
- AssemblerType::linkJump(code(), list.m_jumps[i].m_jmp, label.executableAddress());
+ AssemblerType::linkJump(code(), list.m_jumps[i].m_jmp, label.dataLocation());
}
void patch(DataLabelPtr label, void* value)
@@ -802,7 +482,7 @@ public:
void patch(DataLabelPtr label, CodeLocationLabel value)
{
- AssemblerType::patchPointer(code(), label.m_label, value.getJumpDestination());
+ AssemblerType::patchPointer(code(), label.m_label, value.executableAddress());
}
// These methods are used to obtain handles to allow the code to be relinked / repatched later.
@@ -886,8 +566,93 @@ public:
#endif
};
+ class RepatchBuffer {
+ public:
+ RepatchBuffer()
+ {
+ }
+
+ void relink(CodeLocationJump jump, CodeLocationLabel destination)
+ {
+ AssemblerType::relinkJump(jump.dataLocation(), destination.dataLocation());
+ }
+
+ void relink(CodeLocationCall call, CodeLocationLabel destination)
+ {
+#if PLATFORM(X86_64)
+ repatch(call.dataLabelPtrAtOffset(-REPTACH_OFFSET_CALL_R11), destination.executableAddress());
+#else
+ AssemblerType::relinkCall(call.dataLocation(), destination.executableAddress());
+#endif
+ }
+
+ void relink(CodeLocationCall call, FunctionPtr destination)
+ {
+#if PLATFORM(X86_64)
+ repatch(call.dataLabelPtrAtOffset(-REPTACH_OFFSET_CALL_R11), destination.executableAddress());
+#else
+ AssemblerType::relinkCall(call.dataLocation(), destination.executableAddress());
+#endif
+ }
+
+ void relink(CodeLocationNearCall nearCall, CodePtr destination)
+ {
+ AssemblerType::relinkCall(nearCall.dataLocation(), destination.executableAddress());
+ }
+
+ void relink(CodeLocationNearCall nearCall, CodeLocationLabel destination)
+ {
+ AssemblerType::relinkCall(nearCall.dataLocation(), destination.executableAddress());
+ }
+
+ void relink(CodeLocationNearCall nearCall, FunctionPtr destination)
+ {
+ AssemblerType::relinkCall(nearCall.dataLocation(), destination.executableAddress());
+ }
+
+ void repatch(CodeLocationDataLabel32 dataLabel32, int32_t value)
+ {
+ AssemblerType::repatchInt32(dataLabel32.dataLocation(), value);
+ }
+
+ void repatch(CodeLocationDataLabelPtr dataLabelPtr, void* value)
+ {
+ AssemblerType::repatchPointer(dataLabelPtr.dataLocation(), value);
+ }
+
+ void relinkCallerToTrampoline(ReturnAddressPtr returnAddress, CodeLocationLabel label)
+ {
+ relink(CodeLocationCall(CodePtr(returnAddress)), label);
+ }
+
+ void relinkCallerToTrampoline(ReturnAddressPtr returnAddress, CodePtr newCalleeFunction)
+ {
+ relinkCallerToTrampoline(returnAddress, CodeLocationLabel(newCalleeFunction));
+ }
+
+ void relinkCallerToFunction(ReturnAddressPtr returnAddress, FunctionPtr function)
+ {
+ relink(CodeLocationCall(CodePtr(returnAddress)), function);
+ }
+
+ void relinkNearCallerToTrampoline(ReturnAddressPtr returnAddress, CodeLocationLabel label)
+ {
+ relink(CodeLocationNearCall(CodePtr(returnAddress)), label);
+ }
+
+ void relinkNearCallerToTrampoline(ReturnAddressPtr returnAddress, CodePtr newCalleeFunction)
+ {
+ relinkNearCallerToTrampoline(returnAddress, CodeLocationLabel(newCalleeFunction));
+ }
+
+ void repatchLoadPtrToLEA(CodeLocationInstruction instruction)
+ {
+ AssemblerType::repatchLoadPtrToLEA(instruction.dataLocation());
+ }
+ };
+
- // Section 5: Misc admin methods
+ // Section 4: Misc admin methods
size_t size()
{
@@ -949,49 +714,6 @@ protected:
AssemblerType m_assembler;
};
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationInstruction AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::instructionAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationInstruction(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationLabel AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::labelAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationLabel(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationJump AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::jumpAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationJump(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationCall AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::callAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationCall(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationNearCall AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::nearCallAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationNearCall(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationDataLabelPtr AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::dataLabelPtrAtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationDataLabelPtr(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
-template <class AssemblerType>
-typename AbstractMacroAssembler<AssemblerType>::CodeLocationDataLabel32 AbstractMacroAssembler<AssemblerType>::CodeLocationCommon::dataLabel32AtOffset(int offset)
-{
- return typename AbstractMacroAssembler::CodeLocationDataLabel32(reinterpret_cast<char*>(dataLocation()) + offset);
-}
-
} // namespace JSC
#endif // ENABLE(ASSEMBLER)
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/CodeLocation.h b/src/3rdparty/webkit/JavaScriptCore/assembler/CodeLocation.h
new file mode 100644
index 0000000..b910b6f
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/CodeLocation.h
@@ -0,0 +1,186 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef CodeLocation_h
+#define CodeLocation_h
+
+#include <wtf/Platform.h>
+
+#include <MacroAssemblerCodeRef.h>
+
+#if ENABLE(ASSEMBLER)
+
+namespace JSC {
+
+class CodeLocationInstruction;
+class CodeLocationLabel;
+class CodeLocationJump;
+class CodeLocationCall;
+class CodeLocationNearCall;
+class CodeLocationDataLabel32;
+class CodeLocationDataLabelPtr;
+
+// The CodeLocation* types are all pretty much do-nothing wrappers around
+// CodePtr (or MacroAssemblerCodePtr, to give it its full name). These
+// classes only exist to provide type-safety when linking and patching code.
+//
+// The one new piece of functionallity introduced by these classes is the
+// ability to create (or put another way, to re-discover) another CodeLocation
+// at an offset from one you already know. When patching code to optimize it
+// we often want to patch a number of instructions that are short, fixed
+// offsets apart. To reduce memory overhead we will only retain a pointer to
+// one of the instructions, and we will use the *AtOffset methods provided by
+// CodeLocationCommon to find the other points in the code to modify.
+class CodeLocationCommon : public MacroAssemblerCodePtr {
+public:
+ CodeLocationInstruction instructionAtOffset(int offset);
+ CodeLocationLabel labelAtOffset(int offset);
+ CodeLocationJump jumpAtOffset(int offset);
+ CodeLocationCall callAtOffset(int offset);
+ CodeLocationNearCall nearCallAtOffset(int offset);
+ CodeLocationDataLabelPtr dataLabelPtrAtOffset(int offset);
+ CodeLocationDataLabel32 dataLabel32AtOffset(int offset);
+
+protected:
+ CodeLocationCommon()
+ {
+ }
+
+ CodeLocationCommon(MacroAssemblerCodePtr location)
+ : MacroAssemblerCodePtr(location)
+ {
+ }
+};
+
+class CodeLocationInstruction : public CodeLocationCommon {
+public:
+ CodeLocationInstruction() {}
+ explicit CodeLocationInstruction(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationInstruction(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationLabel : public CodeLocationCommon {
+public:
+ CodeLocationLabel() {}
+ explicit CodeLocationLabel(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationLabel(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationJump : public CodeLocationCommon {
+public:
+ CodeLocationJump() {}
+ explicit CodeLocationJump(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationJump(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationCall : public CodeLocationCommon {
+public:
+ CodeLocationCall() {}
+ explicit CodeLocationCall(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationCall(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationNearCall : public CodeLocationCommon {
+public:
+ CodeLocationNearCall() {}
+ explicit CodeLocationNearCall(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationNearCall(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationDataLabel32 : public CodeLocationCommon {
+public:
+ CodeLocationDataLabel32() {}
+ explicit CodeLocationDataLabel32(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationDataLabel32(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+class CodeLocationDataLabelPtr : public CodeLocationCommon {
+public:
+ CodeLocationDataLabelPtr() {}
+ explicit CodeLocationDataLabelPtr(MacroAssemblerCodePtr location)
+ : CodeLocationCommon(location) {}
+ explicit CodeLocationDataLabelPtr(void* location)
+ : CodeLocationCommon(MacroAssemblerCodePtr(location)) {}
+};
+
+inline CodeLocationInstruction CodeLocationCommon::instructionAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationInstruction(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationLabel CodeLocationCommon::labelAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationLabel(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationJump CodeLocationCommon::jumpAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationJump(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationCall CodeLocationCommon::callAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationCall(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationNearCall CodeLocationCommon::nearCallAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationNearCall(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationDataLabelPtr CodeLocationCommon::dataLabelPtrAtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationDataLabelPtr(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+inline CodeLocationDataLabel32 CodeLocationCommon::dataLabel32AtOffset(int offset)
+{
+ ASSERT_VALID_CODE_OFFSET(offset);
+ return CodeLocationDataLabel32(reinterpret_cast<char*>(dataLocation()) + offset);
+}
+
+} // namespace JSC
+
+#endif // ENABLE(ASSEMBLER)
+
+#endif // CodeLocation_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssembler.h b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssembler.h
index f341267..43d27e7 100644
--- a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssembler.h
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssembler.h
@@ -30,7 +30,11 @@
#if ENABLE(ASSEMBLER)
-#if PLATFORM(X86)
+#if PLATFORM_ARM_ARCH(7)
+#include "MacroAssemblerARMv7.h"
+namespace JSC { typedef MacroAssemblerARMv7 MacroAssemblerBase; };
+
+#elif PLATFORM(X86)
#include "MacroAssemblerX86.h"
namespace JSC { typedef MacroAssemblerX86 MacroAssemblerBase; };
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerARMv7.h b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerARMv7.h
new file mode 100644
index 0000000..bd83c60
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerARMv7.h
@@ -0,0 +1,1063 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef MacroAssemblerARMv7_h
+#define MacroAssemblerARMv7_h
+
+#include <wtf/Platform.h>
+
+#if ENABLE(ASSEMBLER)
+
+#include "ARMv7Assembler.h"
+#include "AbstractMacroAssembler.h"
+
+namespace JSC {
+
+class MacroAssemblerARMv7 : public AbstractMacroAssembler<ARMv7Assembler> {
+ // FIXME: switch dataTempRegister & addressTempRegister, or possibly use r7?
+ // - dTR is likely used more than aTR, and we'll get better instruction
+ // encoding if it's in the low 8 registers.
+ static const ARM::RegisterID dataTempRegister = ARM::ip;
+ static const RegisterID addressTempRegister = ARM::r3;
+ static const FPRegisterID fpTempRegister = ARM::d7;
+
+ struct ArmAddress {
+ enum AddressType {
+ HasOffset,
+ HasIndex,
+ } type;
+ RegisterID base;
+ union {
+ int32_t offset;
+ struct {
+ RegisterID index;
+ Scale scale;
+ };
+ } u;
+
+ explicit ArmAddress(RegisterID base, int32_t offset = 0)
+ : type(HasOffset)
+ , base(base)
+ {
+ u.offset = offset;
+ }
+
+ explicit ArmAddress(RegisterID base, RegisterID index, Scale scale = TimesOne)
+ : type(HasIndex)
+ , base(base)
+ {
+ u.index = index;
+ u.scale = scale;
+ }
+ };
+
+public:
+
+ static const Scale ScalePtr = TimesFour;
+
+ enum Condition {
+ Equal = ARMv7Assembler::ConditionEQ,
+ NotEqual = ARMv7Assembler::ConditionNE,
+ Above = ARMv7Assembler::ConditionHI,
+ AboveOrEqual = ARMv7Assembler::ConditionHS,
+ Below = ARMv7Assembler::ConditionLO,
+ BelowOrEqual = ARMv7Assembler::ConditionLS,
+ GreaterThan = ARMv7Assembler::ConditionGT,
+ GreaterThanOrEqual = ARMv7Assembler::ConditionGE,
+ LessThan = ARMv7Assembler::ConditionLT,
+ LessThanOrEqual = ARMv7Assembler::ConditionLE,
+ Overflow = ARMv7Assembler::ConditionVS,
+ Signed = ARMv7Assembler::ConditionMI,
+ Zero = ARMv7Assembler::ConditionEQ,
+ NonZero = ARMv7Assembler::ConditionNE
+ };
+
+ enum DoubleCondition {
+ DoubleEqual = ARMv7Assembler::ConditionEQ,
+ DoubleGreaterThan = ARMv7Assembler::ConditionGT,
+ DoubleGreaterThanOrEqual = ARMv7Assembler::ConditionGE,
+ DoubleLessThan = ARMv7Assembler::ConditionLO,
+ DoubleLessThanOrEqual = ARMv7Assembler::ConditionLS,
+ };
+
+ static const RegisterID stackPointerRegister = ARM::sp;
+ static const RegisterID linkRegister = ARM::lr;
+
+ // Integer arithmetic operations:
+ //
+ // Operations are typically two operand - operation(source, srcDst)
+ // For many operations the source may be an Imm32, the srcDst operand
+ // may often be a memory location (explictly described using an Address
+ // object).
+
+ void add32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.add(dest, dest, src);
+ }
+
+ void add32(Imm32 imm, RegisterID dest)
+ {
+ add32(imm, dest, dest);
+ }
+
+ void add32(Imm32 imm, RegisterID src, RegisterID dest)
+ {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.add(dest, src, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.add(dest, src, dataTempRegister);
+ }
+ }
+
+ void add32(Imm32 imm, Address address)
+ {
+ load32(address, dataTempRegister);
+
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.add(dataTempRegister, dataTempRegister, armImm);
+ else {
+ // Hrrrm, since dataTempRegister holds the data loaded,
+ // use addressTempRegister to hold the immediate.
+ move(imm, addressTempRegister);
+ m_assembler.add(dataTempRegister, dataTempRegister, addressTempRegister);
+ }
+
+ store32(dataTempRegister, address);
+ }
+
+ void add32(Address src, RegisterID dest)
+ {
+ load32(src, dataTempRegister);
+ add32(dataTempRegister, dest);
+ }
+
+ void add32(Imm32 imm, AbsoluteAddress address)
+ {
+ load32(address.m_ptr, dataTempRegister);
+
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.add(dataTempRegister, dataTempRegister, armImm);
+ else {
+ // Hrrrm, since dataTempRegister holds the data loaded,
+ // use addressTempRegister to hold the immediate.
+ move(imm, addressTempRegister);
+ m_assembler.add(dataTempRegister, dataTempRegister, addressTempRegister);
+ }
+
+ store32(dataTempRegister, address.m_ptr);
+ }
+
+ void and32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.ARM_and(dest, dest, src);
+ }
+
+ void and32(Imm32 imm, RegisterID dest)
+ {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.ARM_and(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.ARM_and(dest, dest, dataTempRegister);
+ }
+ }
+
+ void lshift32(Imm32 imm, RegisterID dest)
+ {
+ m_assembler.lsl(dest, dest, imm.m_value);
+ }
+
+ void lshift32(RegisterID shift_amount, RegisterID dest)
+ {
+ m_assembler.lsl(dest, dest, shift_amount);
+ }
+
+ void mul32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.smull(dest, dataTempRegister, dest, src);
+ }
+
+ void mul32(Imm32 imm, RegisterID src, RegisterID dest)
+ {
+ move(imm, dataTempRegister);
+ m_assembler.smull(dest, dataTempRegister, src, dataTempRegister);
+ }
+
+ void not32(RegisterID srcDest)
+ {
+ m_assembler.mvn(srcDest, srcDest);
+ }
+
+ void or32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.orr(dest, dest, src);
+ }
+
+ void or32(Imm32 imm, RegisterID dest)
+ {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.orr(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.orr(dest, dest, dataTempRegister);
+ }
+ }
+
+ void rshift32(RegisterID shift_amount, RegisterID dest)
+ {
+ m_assembler.asr(dest, dest, shift_amount);
+ }
+
+ void rshift32(Imm32 imm, RegisterID dest)
+ {
+ m_assembler.asr(dest, dest, imm.m_value);
+ }
+
+ void sub32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.sub(dest, dest, src);
+ }
+
+ void sub32(Imm32 imm, RegisterID dest)
+ {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.sub(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.sub(dest, dest, dataTempRegister);
+ }
+ }
+
+ void sub32(Imm32 imm, Address address)
+ {
+ load32(address, dataTempRegister);
+
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.sub(dataTempRegister, dataTempRegister, armImm);
+ else {
+ // Hrrrm, since dataTempRegister holds the data loaded,
+ // use addressTempRegister to hold the immediate.
+ move(imm, addressTempRegister);
+ m_assembler.sub(dataTempRegister, dataTempRegister, addressTempRegister);
+ }
+
+ store32(dataTempRegister, address);
+ }
+
+ void sub32(Address src, RegisterID dest)
+ {
+ load32(src, dataTempRegister);
+ sub32(dataTempRegister, dest);
+ }
+
+ void sub32(Imm32 imm, AbsoluteAddress address)
+ {
+ load32(address.m_ptr, dataTempRegister);
+
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12OrEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.sub(dataTempRegister, dataTempRegister, armImm);
+ else {
+ // Hrrrm, since dataTempRegister holds the data loaded,
+ // use addressTempRegister to hold the immediate.
+ move(imm, addressTempRegister);
+ m_assembler.sub(dataTempRegister, dataTempRegister, addressTempRegister);
+ }
+
+ store32(dataTempRegister, address.m_ptr);
+ }
+
+ void xor32(RegisterID src, RegisterID dest)
+ {
+ m_assembler.eor(dest, dest, src);
+ }
+
+ void xor32(Imm32 imm, RegisterID dest)
+ {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.eor(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.eor(dest, dest, dataTempRegister);
+ }
+ }
+
+
+ // Memory access operations:
+ //
+ // Loads are of the form load(address, destination) and stores of the form
+ // store(source, address). The source for a store may be an Imm32. Address
+ // operand objects to loads and store will be implicitly constructed if a
+ // register is passed.
+
+private:
+ void load32(ArmAddress address, RegisterID dest)
+ {
+ if (address.type == ArmAddress::HasIndex)
+ m_assembler.ldr(dest, address.base, address.u.index, address.u.scale);
+ else if (address.u.offset >= 0) {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12(address.u.offset);
+ ASSERT(armImm.isValid());
+ m_assembler.ldr(dest, address.base, armImm);
+ } else {
+ ASSERT(address.u.offset >= -255);
+ m_assembler.ldr(dest, address.base, address.u.offset, true, false);
+ }
+ }
+
+ void load16(ArmAddress address, RegisterID dest)
+ {
+ if (address.type == ArmAddress::HasIndex)
+ m_assembler.ldrh(dest, address.base, address.u.index, address.u.scale);
+ else if (address.u.offset >= 0) {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12(address.u.offset);
+ ASSERT(armImm.isValid());
+ m_assembler.ldrh(dest, address.base, armImm);
+ } else {
+ ASSERT(address.u.offset >= -255);
+ m_assembler.ldrh(dest, address.base, address.u.offset, true, false);
+ }
+ }
+
+ void store32(RegisterID src, ArmAddress address)
+ {
+ if (address.type == ArmAddress::HasIndex)
+ m_assembler.str(src, address.base, address.u.index, address.u.scale);
+ else if (address.u.offset >= 0) {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeUInt12(address.u.offset);
+ ASSERT(armImm.isValid());
+ m_assembler.str(src, address.base, armImm);
+ } else {
+ ASSERT(address.u.offset >= -255);
+ m_assembler.str(src, address.base, address.u.offset, true, false);
+ }
+ }
+
+public:
+ void load32(ImplicitAddress address, RegisterID dest)
+ {
+ load32(setupArmAddress(address), dest);
+ }
+
+ void load32(BaseIndex address, RegisterID dest)
+ {
+ load32(setupArmAddress(address), dest);
+ }
+
+ void load32(void* address, RegisterID dest)
+ {
+ move(ImmPtr(address), addressTempRegister);
+ m_assembler.ldr(dest, addressTempRegister, ARMThumbImmediate::makeUInt16(0));
+ }
+
+ DataLabel32 load32WithAddressOffsetPatch(Address address, RegisterID dest)
+ {
+ DataLabel32 label = moveWithPatch(Imm32(address.offset), dataTempRegister);
+ load32(ArmAddress(address.base, dataTempRegister), dest);
+ return label;
+ }
+
+ Label loadPtrWithPatchToLEA(Address address, RegisterID dest)
+ {
+ Label label(this);
+ moveFixedWidthEncoding(Imm32(address.offset), dataTempRegister);
+ load32(ArmAddress(address.base, dataTempRegister), dest);
+ return label;
+ }
+
+ void load16(BaseIndex address, RegisterID dest)
+ {
+ m_assembler.ldrh(dest, makeBaseIndexBase(address), address.index, address.scale);
+ }
+
+ DataLabel32 store32WithAddressOffsetPatch(RegisterID src, Address address)
+ {
+ DataLabel32 label = moveWithPatch(Imm32(address.offset), dataTempRegister);
+ store32(src, ArmAddress(address.base, dataTempRegister));
+ return label;
+ }
+
+ void store32(RegisterID src, ImplicitAddress address)
+ {
+ store32(src, setupArmAddress(address));
+ }
+
+ void store32(RegisterID src, BaseIndex address)
+ {
+ store32(src, setupArmAddress(address));
+ }
+
+ void store32(Imm32 imm, ImplicitAddress address)
+ {
+ move(imm, dataTempRegister);
+ store32(dataTempRegister, setupArmAddress(address));
+ }
+
+ void store32(RegisterID src, void* address)
+ {
+ move(ImmPtr(address), addressTempRegister);
+ m_assembler.str(src, addressTempRegister, ARMThumbImmediate::makeUInt16(0));
+ }
+
+ void store32(Imm32 imm, void* address)
+ {
+ move(imm, dataTempRegister);
+ store32(dataTempRegister, address);
+ }
+
+
+ // Floating-point operations:
+
+ bool supportsFloatingPoint() const { return true; }
+ // On x86(_64) the MacroAssembler provides an interface to truncate a double to an integer.
+ // If a value is not representable as an integer, and possibly for some values that are,
+ // (on x86 INT_MIN, since this is indistinguishable from results for out-of-range/NaN input)
+ // a branch will be taken. It is not clear whether this interface will be well suited to
+ // other platforms. On ARMv7 the hardware truncation operation produces multiple possible
+ // failure values (saturates to INT_MIN & INT_MAX, NaN reulsts in a value of 0). This is a
+ // temporary solution while we work out what this interface should be. Either we need to
+ // decide to make this interface work on all platforms, rework the interface to make it more
+ // generic, or decide that the MacroAssembler cannot practically be used to abstracted these
+ // operations, and make clients go directly to the m_assembler to plant truncation instructions.
+ // In short, FIXME:.
+ bool supportsFloatingPointTruncate() const { return false; }
+
+ void loadDouble(ImplicitAddress address, FPRegisterID dest)
+ {
+ RegisterID base = address.base;
+ int32_t offset = address.offset;
+
+ // Arm vfp addresses can be offset by a 9-bit ones-comp immediate, left shifted by 2.
+ if ((offset & 3) || (offset > (255 * 4)) || (offset < -(255 * 4))) {
+ add32(Imm32(offset), base, addressTempRegister);
+ base = addressTempRegister;
+ offset = 0;
+ }
+
+ m_assembler.vldr(dest, base, offset);
+ }
+
+ void storeDouble(FPRegisterID src, ImplicitAddress address)
+ {
+ RegisterID base = address.base;
+ int32_t offset = address.offset;
+
+ // Arm vfp addresses can be offset by a 9-bit ones-comp immediate, left shifted by 2.
+ if ((offset & 3) || (offset > (255 * 4)) || (offset < -(255 * 4))) {
+ add32(Imm32(offset), base, addressTempRegister);
+ base = addressTempRegister;
+ offset = 0;
+ }
+
+ m_assembler.vstr(src, base, offset);
+ }
+
+ void addDouble(FPRegisterID src, FPRegisterID dest)
+ {
+ m_assembler.vadd_F64(dest, dest, src);
+ }
+
+ void addDouble(Address src, FPRegisterID dest)
+ {
+ loadDouble(src, fpTempRegister);
+ addDouble(fpTempRegister, dest);
+ }
+
+ void subDouble(FPRegisterID src, FPRegisterID dest)
+ {
+ m_assembler.vsub_F64(dest, dest, src);
+ }
+
+ void subDouble(Address src, FPRegisterID dest)
+ {
+ loadDouble(src, fpTempRegister);
+ subDouble(fpTempRegister, dest);
+ }
+
+ void mulDouble(FPRegisterID src, FPRegisterID dest)
+ {
+ m_assembler.vmul_F64(dest, dest, src);
+ }
+
+ void mulDouble(Address src, FPRegisterID dest)
+ {
+ loadDouble(src, fpTempRegister);
+ mulDouble(fpTempRegister, dest);
+ }
+
+ void convertInt32ToDouble(RegisterID src, FPRegisterID dest)
+ {
+ m_assembler.vmov(fpTempRegister, src);
+ m_assembler.vcvt_F64_S32(dest, fpTempRegister);
+ }
+
+ Jump branchDouble(DoubleCondition cond, FPRegisterID left, FPRegisterID right)
+ {
+ m_assembler.vcmp_F64(left, right);
+ m_assembler.vmrs_APSR_nzcv_FPSCR();
+ return makeBranch(cond);
+ }
+
+ Jump branchTruncateDoubleToInt32(FPRegisterID, RegisterID)
+ {
+ ASSERT_NOT_REACHED();
+ }
+
+
+ // Stack manipulation operations:
+ //
+ // The ABI is assumed to provide a stack abstraction to memory,
+ // containing machine word sized units of data. Push and pop
+ // operations add and remove a single register sized unit of data
+ // to or from the stack. Peek and poke operations read or write
+ // values on the stack, without moving the current stack position.
+
+ void pop(RegisterID dest)
+ {
+ // store postindexed with writeback
+ m_assembler.ldr(dest, ARM::sp, sizeof(void*), false, true);
+ }
+
+ void push(RegisterID src)
+ {
+ // store preindexed with writeback
+ m_assembler.str(src, ARM::sp, -sizeof(void*), true, true);
+ }
+
+ void push(Address address)
+ {
+ load32(address, dataTempRegister);
+ push(dataTempRegister);
+ }
+
+ void push(Imm32 imm)
+ {
+ move(imm, dataTempRegister);
+ push(dataTempRegister);
+ }
+
+ // Register move operations:
+ //
+ // Move values in registers.
+
+ void move(Imm32 imm, RegisterID dest)
+ {
+ uint32_t value = imm.m_value;
+
+ if (imm.m_isPointer)
+ moveFixedWidthEncoding(imm, dest);
+ else {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(value);
+
+ if (armImm.isValid())
+ m_assembler.mov(dest, armImm);
+ else if ((armImm = ARMThumbImmediate::makeEncodedImm(~value)).isValid())
+ m_assembler.mvn(dest, armImm);
+ else {
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(value));
+ if (value & 0xffff0000)
+ m_assembler.movt(dest, ARMThumbImmediate::makeUInt16(value >> 16));
+ }
+ }
+ }
+
+ void move(RegisterID src, RegisterID dest)
+ {
+ m_assembler.mov(dest, src);
+ }
+
+ void move(ImmPtr imm, RegisterID dest)
+ {
+ move(Imm32(imm), dest);
+ }
+
+ void swap(RegisterID reg1, RegisterID reg2)
+ {
+ move(reg1, dataTempRegister);
+ move(reg2, reg1);
+ move(dataTempRegister, reg2);
+ }
+
+ void signExtend32ToPtr(RegisterID src, RegisterID dest)
+ {
+ if (src != dest)
+ move(src, dest);
+ }
+
+ void zeroExtend32ToPtr(RegisterID src, RegisterID dest)
+ {
+ if (src != dest)
+ move(src, dest);
+ }
+
+
+ // Forwards / external control flow operations:
+ //
+ // This set of jump and conditional branch operations return a Jump
+ // object which may linked at a later point, allow forwards jump,
+ // or jumps that will require external linkage (after the code has been
+ // relocated).
+ //
+ // For branches, signed <, >, <= and >= are denoted as l, g, le, and ge
+ // respecitvely, for unsigned comparisons the names b, a, be, and ae are
+ // used (representing the names 'below' and 'above').
+ //
+ // Operands to the comparision are provided in the expected order, e.g.
+ // jle32(reg1, Imm32(5)) will branch if the value held in reg1, when
+ // treated as a signed 32bit value, is less than or equal to 5.
+ //
+ // jz and jnz test whether the first operand is equal to zero, and take
+ // an optional second operand of a mask under which to perform the test.
+private:
+
+ // Should we be using TEQ for equal/not-equal?
+ void compare32(RegisterID left, Imm32 right)
+ {
+ int32_t imm = right.m_value;
+ if (!imm)
+ m_assembler.tst(left, left);
+ else {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm);
+ if (armImm.isValid())
+ m_assembler.cmp(left, armImm);
+ if ((armImm = ARMThumbImmediate::makeEncodedImm(-imm)).isValid())
+ m_assembler.cmn(left, armImm);
+ else {
+ move(Imm32(imm), dataTempRegister);
+ m_assembler.cmp(left, dataTempRegister);
+ }
+ }
+ }
+
+ void test32(RegisterID reg, Imm32 mask)
+ {
+ int32_t imm = mask.m_value;
+
+ if (imm == -1)
+ m_assembler.tst(reg, reg);
+ else {
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm);
+ if (armImm.isValid())
+ m_assembler.tst(reg, armImm);
+ else {
+ move(mask, dataTempRegister);
+ m_assembler.tst(reg, dataTempRegister);
+ }
+ }
+ }
+
+public:
+ Jump branch32(Condition cond, RegisterID left, RegisterID right)
+ {
+ m_assembler.cmp(left, right);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branch32(Condition cond, RegisterID left, Imm32 right)
+ {
+ compare32(left, right);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branch32(Condition cond, RegisterID left, Address right)
+ {
+ load32(right, dataTempRegister);
+ return branch32(cond, left, dataTempRegister);
+ }
+
+ Jump branch32(Condition cond, Address left, RegisterID right)
+ {
+ load32(left, dataTempRegister);
+ return branch32(cond, dataTempRegister, right);
+ }
+
+ Jump branch32(Condition cond, Address left, Imm32 right)
+ {
+ // use addressTempRegister incase the branch32 we call uses dataTempRegister. :-/
+ load32(left, addressTempRegister);
+ return branch32(cond, addressTempRegister, right);
+ }
+
+ Jump branch32(Condition cond, BaseIndex left, Imm32 right)
+ {
+ // use addressTempRegister incase the branch32 we call uses dataTempRegister. :-/
+ load32(left, addressTempRegister);
+ return branch32(cond, addressTempRegister, right);
+ }
+
+ Jump branch32(Condition cond, AbsoluteAddress left, RegisterID right)
+ {
+ load32(left.m_ptr, dataTempRegister);
+ return branch32(cond, dataTempRegister, right);
+ }
+
+ Jump branch32(Condition cond, AbsoluteAddress left, Imm32 right)
+ {
+ // use addressTempRegister incase the branch32 we call uses dataTempRegister. :-/
+ load32(left.m_ptr, addressTempRegister);
+ return branch32(cond, addressTempRegister, right);
+ }
+
+ Jump branch16(Condition cond, BaseIndex left, RegisterID right)
+ {
+ load16(left, dataTempRegister);
+ m_assembler.lsl(addressTempRegister, right, 16);
+ m_assembler.lsl(dataTempRegister, dataTempRegister, 16);
+ return branch32(cond, dataTempRegister, addressTempRegister);
+ }
+
+ Jump branch16(Condition cond, BaseIndex left, Imm32 right)
+ {
+ // use addressTempRegister incase the branch32 we call uses dataTempRegister. :-/
+ load16(left, addressTempRegister);
+ m_assembler.lsl(addressTempRegister, addressTempRegister, 16);
+ return branch32(cond, addressTempRegister, Imm32(right.m_value << 16));
+ }
+
+ Jump branchTest32(Condition cond, RegisterID reg, RegisterID mask)
+ {
+ ASSERT((cond == Zero) || (cond == NonZero));
+ m_assembler.tst(reg, mask);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branchTest32(Condition cond, RegisterID reg, Imm32 mask = Imm32(-1))
+ {
+ ASSERT((cond == Zero) || (cond == NonZero));
+ test32(reg, mask);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branchTest32(Condition cond, Address address, Imm32 mask = Imm32(-1))
+ {
+ ASSERT((cond == Zero) || (cond == NonZero));
+ // use addressTempRegister incase the branchTest32 we call uses dataTempRegister. :-/
+ load32(address, addressTempRegister);
+ return branchTest32(cond, addressTempRegister, mask);
+ }
+
+ Jump branchTest32(Condition cond, BaseIndex address, Imm32 mask = Imm32(-1))
+ {
+ ASSERT((cond == Zero) || (cond == NonZero));
+ // use addressTempRegister incase the branchTest32 we call uses dataTempRegister. :-/
+ load32(address, addressTempRegister);
+ return branchTest32(cond, addressTempRegister, mask);
+ }
+
+ Jump jump()
+ {
+ return Jump(makeJump());
+ }
+
+ void jump(RegisterID target)
+ {
+ m_assembler.bx(target);
+ }
+
+ // Address is a memory location containing the address to jump to
+ void jump(Address address)
+ {
+ load32(address, dataTempRegister);
+ m_assembler.bx(dataTempRegister);
+ }
+
+
+ // Arithmetic control flow operations:
+ //
+ // This set of conditional branch operations branch based
+ // on the result of an arithmetic operation. The operation
+ // is performed as normal, storing the result.
+ //
+ // * jz operations branch if the result is zero.
+ // * jo operations branch if the (signed) arithmetic
+ // operation caused an overflow to occur.
+
+ Jump branchAdd32(Condition cond, RegisterID src, RegisterID dest)
+ {
+ ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+ m_assembler.add_S(dest, dest, src);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branchAdd32(Condition cond, Imm32 imm, RegisterID dest)
+ {
+ ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.add_S(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.add_S(dest, dest, dataTempRegister);
+ }
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branchMul32(Condition cond, RegisterID src, RegisterID dest)
+ {
+ ASSERT(cond == Overflow);
+ m_assembler.smull(dest, dataTempRegister, dest, src);
+ m_assembler.asr(addressTempRegister, dest, 31);
+ return branch32(NotEqual, addressTempRegister, dataTempRegister);
+ }
+
+ Jump branchMul32(Condition cond, Imm32 imm, RegisterID src, RegisterID dest)
+ {
+ ASSERT(cond == Overflow);
+ move(imm, dataTempRegister);
+ m_assembler.smull(dest, dataTempRegister, src, dataTempRegister);
+ m_assembler.asr(addressTempRegister, dest, 31);
+ return branch32(NotEqual, addressTempRegister, dataTempRegister);
+ }
+
+ Jump branchSub32(Condition cond, RegisterID src, RegisterID dest)
+ {
+ ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+ m_assembler.sub_S(dest, dest, src);
+ return Jump(makeBranch(cond));
+ }
+
+ Jump branchSub32(Condition cond, Imm32 imm, RegisterID dest)
+ {
+ ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+ ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
+ if (armImm.isValid())
+ m_assembler.sub_S(dest, dest, armImm);
+ else {
+ move(imm, dataTempRegister);
+ m_assembler.sub_S(dest, dest, dataTempRegister);
+ }
+ return Jump(makeBranch(cond));
+ }
+
+
+ // Miscellaneous operations:
+
+ void breakpoint()
+ {
+ m_assembler.bkpt();
+ }
+
+ Call nearCall()
+ {
+ moveFixedWidthEncoding(Imm32(0), dataTempRegister);
+ return Call(m_assembler.blx(dataTempRegister), Call::LinkableNear);
+ }
+
+ Call call()
+ {
+ moveFixedWidthEncoding(Imm32(0), dataTempRegister);
+ return Call(m_assembler.blx(dataTempRegister), Call::Linkable);
+ }
+
+ Call call(RegisterID target)
+ {
+ return Call(m_assembler.blx(target), Call::None);
+ }
+
+ Call call(Address address)
+ {
+ load32(address, dataTempRegister);
+ return Call(m_assembler.blx(dataTempRegister), Call::None);
+ }
+
+ void ret()
+ {
+ m_assembler.bx(linkRegister);
+ }
+
+ void set32(Condition cond, RegisterID left, RegisterID right, RegisterID dest)
+ {
+ m_assembler.cmp(left, right);
+ m_assembler.it(armV7Condition(cond), false);
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(1));
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(0));
+ }
+
+ void set32(Condition cond, RegisterID left, Imm32 right, RegisterID dest)
+ {
+ compare32(left, right);
+ m_assembler.it(armV7Condition(cond), false);
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(1));
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(0));
+ }
+
+ // FIXME:
+ // The mask should be optional... paerhaps the argument order should be
+ // dest-src, operations always have a dest? ... possibly not true, considering
+ // asm ops like test, or pseudo ops like pop().
+ void setTest32(Condition cond, Address address, Imm32 mask, RegisterID dest)
+ {
+ load32(address, dataTempRegister);
+ test32(dataTempRegister, mask);
+ m_assembler.it(armV7Condition(cond), false);
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(1));
+ m_assembler.mov(dest, ARMThumbImmediate::makeUInt16(0));
+ }
+
+
+ DataLabel32 moveWithPatch(Imm32 imm, RegisterID dst)
+ {
+ moveFixedWidthEncoding(imm, dst);
+ return DataLabel32(this);
+ }
+
+ DataLabelPtr moveWithPatch(ImmPtr imm, RegisterID dst)
+ {
+ moveFixedWidthEncoding(Imm32(imm), dst);
+ return DataLabelPtr(this);
+ }
+
+ Jump branchPtrWithPatch(Condition cond, RegisterID left, DataLabelPtr& dataLabel, ImmPtr initialRightValue = ImmPtr(0))
+ {
+ dataLabel = moveWithPatch(initialRightValue, dataTempRegister);
+ return branch32(cond, left, dataTempRegister);
+ }
+
+ Jump branchPtrWithPatch(Condition cond, Address left, DataLabelPtr& dataLabel, ImmPtr initialRightValue = ImmPtr(0))
+ {
+ load32(left, addressTempRegister);
+ dataLabel = moveWithPatch(initialRightValue, dataTempRegister);
+ return branch32(cond, addressTempRegister, dataTempRegister);
+ }
+
+ DataLabelPtr storePtrWithPatch(ImmPtr initialValue, ImplicitAddress address)
+ {
+ DataLabelPtr label = moveWithPatch(initialValue, dataTempRegister);
+ store32(dataTempRegister, address);
+ return label;
+ }
+ DataLabelPtr storePtrWithPatch(ImplicitAddress address) { return storePtrWithPatch(ImmPtr(0), address); }
+
+
+ Call tailRecursiveCall()
+ {
+ // Like a normal call, but don't link.
+ moveFixedWidthEncoding(Imm32(0), dataTempRegister);
+ return Call(m_assembler.bx(dataTempRegister), Call::Linkable);
+ }
+
+ Call makeTailRecursiveCall(Jump oldJump)
+ {
+ oldJump.link(this);
+ return tailRecursiveCall();
+ }
+
+
+protected:
+ ARMv7Assembler::JmpSrc makeJump()
+ {
+ return m_assembler.b();
+ }
+
+ ARMv7Assembler::JmpSrc makeBranch(ARMv7Assembler::Condition cond)
+ {
+ m_assembler.it(cond);
+ return m_assembler.b();
+ }
+ ARMv7Assembler::JmpSrc makeBranch(Condition cond) { return makeBranch(armV7Condition(cond)); }
+ ARMv7Assembler::JmpSrc makeBranch(DoubleCondition cond) { return makeBranch(armV7Condition(cond)); }
+
+ ArmAddress setupArmAddress(BaseIndex address)
+ {
+ if (address.offset) {
+ ARMThumbImmediate imm = ARMThumbImmediate::makeUInt12OrEncodedImm(address.offset);
+ if (imm.isValid())
+ m_assembler.add(addressTempRegister, address.base, imm);
+ else {
+ move(Imm32(address.offset), addressTempRegister);
+ m_assembler.add(addressTempRegister, addressTempRegister, address.base);
+ }
+
+ return ArmAddress(addressTempRegister, address.index, address.scale);
+ } else
+ return ArmAddress(address.base, address.index, address.scale);
+ }
+
+ ArmAddress setupArmAddress(Address address)
+ {
+ if ((address.offset >= -0xff) && (address.offset <= 0xfff))
+ return ArmAddress(address.base, address.offset);
+
+ move(Imm32(address.offset), addressTempRegister);
+ return ArmAddress(address.base, addressTempRegister);
+ }
+
+ ArmAddress setupArmAddress(ImplicitAddress address)
+ {
+ if ((address.offset >= -0xff) && (address.offset <= 0xfff))
+ return ArmAddress(address.base, address.offset);
+
+ move(Imm32(address.offset), addressTempRegister);
+ return ArmAddress(address.base, addressTempRegister);
+ }
+
+ RegisterID makeBaseIndexBase(BaseIndex address)
+ {
+ if (!address.offset)
+ return address.base;
+
+ ARMThumbImmediate imm = ARMThumbImmediate::makeUInt12OrEncodedImm(address.offset);
+ if (imm.isValid())
+ m_assembler.add(addressTempRegister, address.base, imm);
+ else {
+ move(Imm32(address.offset), addressTempRegister);
+ m_assembler.add(addressTempRegister, addressTempRegister, address.base);
+ }
+
+ return addressTempRegister;
+ }
+
+ DataLabel32 moveFixedWidthEncoding(Imm32 imm, RegisterID dst)
+ {
+ uint32_t value = imm.m_value;
+ m_assembler.movT3(dst, ARMThumbImmediate::makeUInt16(value & 0xffff));
+ m_assembler.movt(dst, ARMThumbImmediate::makeUInt16(value >> 16));
+ }
+
+ ARMv7Assembler::Condition armV7Condition(Condition cond)
+ {
+ return static_cast<ARMv7Assembler::Condition>(cond);
+ }
+
+ ARMv7Assembler::Condition armV7Condition(DoubleCondition cond)
+ {
+ return static_cast<ARMv7Assembler::Condition>(cond);
+ }
+};
+
+} // namespace JSC
+
+#endif // ENABLE(ASSEMBLER)
+
+#endif // MacroAssemblerARMv7_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerCodeRef.h b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
index 0603060..50fca5b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
@@ -35,6 +35,25 @@
#if ENABLE(ASSEMBLER)
+// ASSERT_VALID_CODE_POINTER checks that ptr is a non-null pointer, and that it is a valid
+// instruction address on the platform (for example, check any alignment requirements).
+#if PLATFORM_ARM_ARCH(7)
+// ARM/thumb instructions must be 16-bit aligned, but all code pointers to be loaded
+// into the processor are decorated with the bottom bit set, indicating that this is
+// thumb code (as oposed to 32-bit traditional ARM). The first test checks for both
+// decorated and undectorated null, and the second test ensures that the pointer is
+// decorated.
+#define ASSERT_VALID_CODE_POINTER(ptr) \
+ ASSERT(reinterpret_cast<intptr_t>(ptr) & ~1); \
+ ASSERT(reinterpret_cast<intptr_t>(ptr) & 1)
+#define ASSERT_VALID_CODE_OFFSET(offset) \
+ ASSERT(!(offset & 1)) // Must be multiple of 2.
+#else
+#define ASSERT_VALID_CODE_POINTER(ptr) \
+ ASSERT(ptr)
+#define ASSERT_VALID_CODE_OFFSET(offset) // Anything goes!
+#endif
+
namespace JSC {
// FunctionPtr:
@@ -52,7 +71,7 @@ public:
explicit FunctionPtr(FunctionType* value)
: m_value(reinterpret_cast<void*>(value))
{
- ASSERT(m_value);
+ ASSERT_VALID_CODE_POINTER(m_value);
}
void* value() const { return m_value; }
@@ -79,7 +98,13 @@ public:
explicit ReturnAddressPtr(void* value)
: m_value(value)
{
- ASSERT(m_value);
+ ASSERT_VALID_CODE_POINTER(m_value);
+ }
+
+ explicit ReturnAddressPtr(FunctionPtr function)
+ : m_value(function.value())
+ {
+ ASSERT_VALID_CODE_POINTER(m_value);
}
void* value() const { return m_value; }
@@ -99,19 +124,34 @@ public:
}
explicit MacroAssemblerCodePtr(void* value)
+#if PLATFORM_ARM_ARCH(7)
+ // Decorate the pointer as a thumb code pointer.
+ : m_value(reinterpret_cast<char*>(value) + 1)
+#else
: m_value(value)
+#endif
{
- ASSERT(m_value);
+ ASSERT_VALID_CODE_POINTER(m_value);
}
explicit MacroAssemblerCodePtr(ReturnAddressPtr ra)
: m_value(ra.value())
{
- ASSERT(m_value);
+ ASSERT_VALID_CODE_POINTER(m_value);
}
void* executableAddress() const { return m_value; }
- void* dataLocation() const { ASSERT(m_value); return m_value; }
+#if PLATFORM_ARM_ARCH(7)
+ // To use this pointer as a data address remove the decoration.
+ void* dataLocation() const { ASSERT_VALID_CODE_POINTER(m_value); return reinterpret_cast<char*>(m_value) - 1; }
+#else
+ void* dataLocation() const { ASSERT_VALID_CODE_POINTER(m_value); return m_value; }
+#endif
+
+ bool operator!()
+ {
+ return !m_value;
+ }
private:
void* m_value;
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86.h b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86.h
index 801bf61..aaf98fd 100644
--- a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86.h
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86.h
@@ -151,7 +151,16 @@ public:
return DataLabelPtr(this);
}
+ Label loadPtrWithPatchToLEA(Address address, RegisterID dest)
+ {
+ Label label(this);
+ load32(address, dest);
+ return label;
+ }
+
bool supportsFloatingPoint() const { return m_isSSE2Present; }
+ // See comment on MacroAssemblerARMv7::supportsFloatingPointTruncate()
+ bool supportsFloatingPointTruncate() const { return m_isSSE2Present; }
private:
const bool m_isSSE2Present;
diff --git a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86_64.h b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86_64.h
index 4da7fe6..ffdca7c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86_64.h
+++ b/src/3rdparty/webkit/JavaScriptCore/assembler/MacroAssemblerX86_64.h
@@ -436,7 +436,16 @@ public:
return label;
}
+ Label loadPtrWithPatchToLEA(Address address, RegisterID dest)
+ {
+ Label label(this);
+ loadPtr(address, dest);
+ return label;
+ }
+
bool supportsFloatingPoint() const { return true; }
+ // See comment on MacroAssemblerARMv7::supportsFloatingPointTruncate()
+ bool supportsFloatingPointTruncate() const { return true; }
};
} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.cpp b/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.cpp
index d2b122a..d777f73 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.cpp
@@ -1265,6 +1265,28 @@ void CodeBlock::dumpStatistics()
#endif
}
+CodeBlock::CodeBlock(ScopeNode* ownerNode)
+ : m_numCalleeRegisters(0)
+ , m_numConstants(0)
+ , m_numVars(0)
+ , m_numParameters(0)
+ , m_ownerNode(ownerNode)
+ , m_globalData(0)
+#ifndef NDEBUG
+ , m_instructionCount(0)
+#endif
+ , m_needsFullScopeChain(false)
+ , m_usesEval(false)
+ , m_isNumericCompareFunction(false)
+ , m_codeType(NativeCode)
+ , m_source(0)
+ , m_sourceOffset(0)
+ , m_exceptionInfo(0)
+{
+#if DUMP_CODE_BLOCK_STATISTICS
+ liveCodeBlockSet.add(this);
+#endif
+}
CodeBlock::CodeBlock(ScopeNode* ownerNode, CodeType codeType, PassRefPtr<SourceProvider> sourceProvider, unsigned sourceOffset)
: m_numCalleeRegisters(0)
@@ -1342,6 +1364,7 @@ void CodeBlock::unlinkCallers()
void CodeBlock::derefStructures(Instruction* vPC) const
{
+ ASSERT(m_codeType != NativeCode);
Interpreter* interpreter = m_globalData->interpreter;
if (vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_self)) {
@@ -1387,6 +1410,7 @@ void CodeBlock::derefStructures(Instruction* vPC) const
void CodeBlock::refStructures(Instruction* vPC) const
{
+ ASSERT(m_codeType != NativeCode);
Interpreter* interpreter = m_globalData->interpreter;
if (vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_self)) {
@@ -1441,6 +1465,7 @@ void CodeBlock::mark()
void CodeBlock::reparseForExceptionInfoIfNecessary(CallFrame* callFrame)
{
+ ASSERT(m_codeType != NativeCode);
if (m_exceptionInfo)
return;
@@ -1511,6 +1536,7 @@ void CodeBlock::reparseForExceptionInfoIfNecessary(CallFrame* callFrame)
HandlerInfo* CodeBlock::handlerForBytecodeOffset(unsigned bytecodeOffset)
{
+ ASSERT(m_codeType != NativeCode);
ASSERT(bytecodeOffset < m_instructionCount);
if (!m_rareData)
@@ -1529,6 +1555,7 @@ HandlerInfo* CodeBlock::handlerForBytecodeOffset(unsigned bytecodeOffset)
int CodeBlock::lineNumberForBytecodeOffset(CallFrame* callFrame, unsigned bytecodeOffset)
{
+ ASSERT(m_codeType != NativeCode);
ASSERT(bytecodeOffset < m_instructionCount);
reparseForExceptionInfoIfNecessary(callFrame);
@@ -1554,6 +1581,7 @@ int CodeBlock::lineNumberForBytecodeOffset(CallFrame* callFrame, unsigned byteco
int CodeBlock::expressionRangeForBytecodeOffset(CallFrame* callFrame, unsigned bytecodeOffset, int& divot, int& startOffset, int& endOffset)
{
+ ASSERT(m_codeType != NativeCode);
ASSERT(bytecodeOffset < m_instructionCount);
reparseForExceptionInfoIfNecessary(callFrame);
@@ -1593,6 +1621,7 @@ int CodeBlock::expressionRangeForBytecodeOffset(CallFrame* callFrame, unsigned b
bool CodeBlock::getByIdExceptionInfoForBytecodeOffset(CallFrame* callFrame, unsigned bytecodeOffset, OpcodeID& opcodeID)
{
+ ASSERT(m_codeType != NativeCode);
ASSERT(bytecodeOffset < m_instructionCount);
reparseForExceptionInfoIfNecessary(callFrame);
@@ -1621,6 +1650,7 @@ bool CodeBlock::getByIdExceptionInfoForBytecodeOffset(CallFrame* callFrame, unsi
#if ENABLE(JIT)
bool CodeBlock::functionRegisterForBytecodeOffset(unsigned bytecodeOffset, int& functionRegisterIndex)
{
+ ASSERT(m_codeType != NativeCode);
ASSERT(bytecodeOffset < m_instructionCount);
if (!m_rareData || !m_rareData->m_functionRegisterInfos.size())
@@ -1647,6 +1677,7 @@ bool CodeBlock::functionRegisterForBytecodeOffset(unsigned bytecodeOffset, int&
#if !ENABLE(JIT)
bool CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset(unsigned bytecodeOffset)
{
+ ASSERT(m_codeType != NativeCode);
if (m_globalResolveInstructions.isEmpty())
return false;
@@ -1667,6 +1698,7 @@ bool CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset(unsigned bytecodeOff
#else
bool CodeBlock::hasGlobalResolveInfoAtBytecodeOffset(unsigned bytecodeOffset)
{
+ ASSERT(m_codeType != NativeCode);
if (m_globalResolveInfos.isEmpty())
return false;
@@ -1689,6 +1721,7 @@ bool CodeBlock::hasGlobalResolveInfoAtBytecodeOffset(unsigned bytecodeOffset)
#if ENABLE(JIT)
void CodeBlock::setJITCode(JITCode jitCode)
{
+ ASSERT(m_codeType != NativeCode);
ownerNode()->setJITCode(jitCode);
#if !ENABLE(OPCODE_SAMPLING)
if (!BytecodeGenerator::dumpsGeneratedCode())
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.h b/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.h
index ac29c6c..afd32f0 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.h
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecode/CodeBlock.h
@@ -38,6 +38,7 @@
#include "Nodes.h"
#include "RegExp.h"
#include "UString.h"
+#include <wtf/FastAllocBase.h>
#include <wtf/RefPtr.h>
#include <wtf/Vector.h>
@@ -49,7 +50,7 @@ namespace JSC {
class ExecState;
- enum CodeType { GlobalCode, EvalCode, FunctionCode };
+ enum CodeType { GlobalCode, EvalCode, FunctionCode, NativeCode };
static ALWAYS_INLINE int missingThisObjectMarker() { return std::numeric_limits<int>::max(); }
@@ -59,7 +60,7 @@ namespace JSC {
uint32_t target;
uint32_t scopeDepth;
#if ENABLE(JIT)
- MacroAssembler::CodeLocationLabel nativeCode;
+ CodeLocationLabel nativeCode;
#endif
};
@@ -95,10 +96,9 @@ namespace JSC {
}
unsigned bytecodeIndex;
- MacroAssembler::CodeLocationNearCall callReturnLocation;
- MacroAssembler::CodeLocationDataLabelPtr hotPathBegin;
- MacroAssembler::CodeLocationNearCall hotPathOther;
- MacroAssembler::CodeLocationLabel coldPathOther;
+ CodeLocationNearCall callReturnLocation;
+ CodeLocationDataLabelPtr hotPathBegin;
+ CodeLocationNearCall hotPathOther;
CodeBlock* callee;
unsigned position;
@@ -112,8 +112,8 @@ namespace JSC {
{
}
- MacroAssembler::CodeLocationCall callReturnLocation;
- MacroAssembler::CodeLocationDataLabelPtr structureLabel;
+ CodeLocationCall callReturnLocation;
+ CodeLocationDataLabelPtr structureLabel;
Structure* cachedStructure;
};
@@ -160,17 +160,17 @@ namespace JSC {
inline void* getStructureStubInfoReturnLocation(StructureStubInfo* structureStubInfo)
{
- return structureStubInfo->callReturnLocation.calleeReturnAddressValue();
+ return structureStubInfo->callReturnLocation.executableAddress();
}
inline void* getCallLinkInfoReturnLocation(CallLinkInfo* callLinkInfo)
{
- return callLinkInfo->callReturnLocation.calleeReturnAddressValue();
+ return callLinkInfo->callReturnLocation.executableAddress();
}
inline void* getMethodCallLinkInfoReturnLocation(MethodCallLinkInfo* methodCallLinkInfo)
{
- return methodCallLinkInfo->callReturnLocation.calleeReturnAddressValue();
+ return methodCallLinkInfo->callReturnLocation.executableAddress();
}
inline unsigned getCallReturnOffset(CallReturnOffsetToBytecodeIndex* pc)
@@ -215,9 +215,10 @@ namespace JSC {
}
#endif
- class CodeBlock {
+ class CodeBlock : public WTF::FastAllocBase {
friend class JIT;
public:
+ CodeBlock(ScopeNode* ownerNode);
CodeBlock(ScopeNode* ownerNode, CodeType, PassRefPtr<SourceProvider>, unsigned sourceOffset);
~CodeBlock();
@@ -287,25 +288,25 @@ namespace JSC {
m_linkedCallerList.shrink(lastPos);
}
- StructureStubInfo& getStubInfo(void* returnAddress)
+ StructureStubInfo& getStubInfo(ReturnAddressPtr returnAddress)
{
- return *(binaryChop<StructureStubInfo, void*, getStructureStubInfoReturnLocation>(m_structureStubInfos.begin(), m_structureStubInfos.size(), returnAddress));
+ return *(binaryChop<StructureStubInfo, void*, getStructureStubInfoReturnLocation>(m_structureStubInfos.begin(), m_structureStubInfos.size(), returnAddress.value()));
}
- CallLinkInfo& getCallLinkInfo(void* returnAddress)
+ CallLinkInfo& getCallLinkInfo(ReturnAddressPtr returnAddress)
{
- return *(binaryChop<CallLinkInfo, void*, getCallLinkInfoReturnLocation>(m_callLinkInfos.begin(), m_callLinkInfos.size(), returnAddress));
+ return *(binaryChop<CallLinkInfo, void*, getCallLinkInfoReturnLocation>(m_callLinkInfos.begin(), m_callLinkInfos.size(), returnAddress.value()));
}
- MethodCallLinkInfo& getMethodCallLinkInfo(void* returnAddress)
+ MethodCallLinkInfo& getMethodCallLinkInfo(ReturnAddressPtr returnAddress)
{
- return *(binaryChop<MethodCallLinkInfo, void*, getMethodCallLinkInfoReturnLocation>(m_methodCallLinkInfos.begin(), m_methodCallLinkInfos.size(), returnAddress));
+ return *(binaryChop<MethodCallLinkInfo, void*, getMethodCallLinkInfoReturnLocation>(m_methodCallLinkInfos.begin(), m_methodCallLinkInfos.size(), returnAddress.value()));
}
- unsigned getBytecodeIndex(CallFrame* callFrame, void* nativePC)
+ unsigned getBytecodeIndex(CallFrame* callFrame, ReturnAddressPtr returnAddress)
{
reparseForExceptionInfoIfNecessary(callFrame);
- return binaryChop<CallReturnOffsetToBytecodeIndex, unsigned, getCallReturnOffset>(m_exceptionInfo->m_callReturnIndexVector.begin(), m_exceptionInfo->m_callReturnIndexVector.size(), ownerNode()->generatedJITCode().offsetOf(nativePC))->bytecodeIndex;
+ return binaryChop<CallReturnOffsetToBytecodeIndex, unsigned, getCallReturnOffset>(m_exceptionInfo->m_callReturnIndexVector.begin(), m_exceptionInfo->m_callReturnIndexVector.size(), ownerNode()->generatedJITCode().offsetOf(returnAddress.value()))->bytecodeIndex;
}
bool functionRegisterForBytecodeOffset(unsigned bytecodeOffset, int& functionRegisterIndex);
@@ -340,8 +341,8 @@ namespace JSC {
CodeType codeType() const { return m_codeType; }
- SourceProvider* source() const { return m_source.get(); }
- unsigned sourceOffset() const { return m_sourceOffset; }
+ SourceProvider* source() const { ASSERT(m_codeType != NativeCode); return m_source.get(); }
+ unsigned sourceOffset() const { ASSERT(m_codeType != NativeCode); return m_sourceOffset; }
size_t numberOfJumpTargets() const { return m_jumpTargets.size(); }
void addJumpTarget(unsigned jumpTarget) { m_jumpTargets.append(jumpTarget); }
@@ -433,7 +434,7 @@ namespace JSC {
SymbolTable& symbolTable() { return m_symbolTable; }
- EvalCodeCache& evalCodeCache() { createRareDataIfNecessary(); return m_rareData->m_evalCodeCache; }
+ EvalCodeCache& evalCodeCache() { ASSERT(m_codeType != NativeCode); createRareDataIfNecessary(); return m_rareData->m_evalCodeCache; }
void shrinkToFit();
@@ -457,6 +458,7 @@ namespace JSC {
void createRareDataIfNecessary()
{
+ ASSERT(m_codeType != NativeCode);
if (!m_rareData)
m_rareData.set(new RareData);
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecode/Instruction.h b/src/3rdparty/webkit/JavaScriptCore/bytecode/Instruction.h
index 24ba490..eeeac6f 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecode/Instruction.h
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecode/Instruction.h
@@ -38,12 +38,12 @@
namespace JSC {
- // *Sigh*, If the JIT is enabled we need to track the stubRountine (of type MacroAssembler::CodeLocationLabel),
+ // *Sigh*, If the JIT is enabled we need to track the stubRountine (of type CodeLocationLabel),
// If the JIT is not in use we don't actually need the variable (that said, if the JIT is not in use we don't
// curently actually use PolymorphicAccessStructureLists, which we should). Anyway, this seems like the best
// solution for now - will need to something smarter if/when we actually want mixed-mode operation.
#if ENABLE(JIT)
- typedef MacroAssembler::CodeLocationLabel PolymorphicAccessStructureListStubRoutineType;
+ typedef CodeLocationLabel PolymorphicAccessStructureListStubRoutineType;
#else
typedef void* PolymorphicAccessStructureListStubRoutineType;
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecode/JumpTable.h b/src/3rdparty/webkit/JavaScriptCore/bytecode/JumpTable.h
index eee773c..b4f8e44 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecode/JumpTable.h
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecode/JumpTable.h
@@ -40,7 +40,7 @@ namespace JSC {
struct OffsetLocation {
int32_t branchOffset;
#if ENABLE(JIT)
- MacroAssembler::CodeLocationLabel ctiOffset;
+ CodeLocationLabel ctiOffset;
#endif
};
@@ -48,7 +48,7 @@ namespace JSC {
typedef HashMap<RefPtr<UString::Rep>, OffsetLocation> StringOffsetTable;
StringOffsetTable offsetTable;
#if ENABLE(JIT)
- MacroAssembler::CodeLocationLabel ctiDefault; // FIXME: it should not be necessary to store this.
+ CodeLocationLabel ctiDefault; // FIXME: it should not be necessary to store this.
#endif
inline int32_t offsetForValue(UString::Rep* value, int32_t defaultOffset)
@@ -61,7 +61,7 @@ namespace JSC {
}
#if ENABLE(JIT)
- inline MacroAssembler::CodeLocationLabel ctiForValue(UString::Rep* value)
+ inline CodeLocationLabel ctiForValue(UString::Rep* value)
{
StringOffsetTable::const_iterator end = offsetTable.end();
StringOffsetTable::const_iterator loc = offsetTable.find(value);
@@ -77,8 +77,8 @@ namespace JSC {
Vector<int32_t> branchOffsets;
int32_t min;
#if ENABLE(JIT)
- Vector<MacroAssembler::CodeLocationLabel> ctiOffsets;
- MacroAssembler::CodeLocationLabel ctiDefault;
+ Vector<CodeLocationLabel> ctiOffsets;
+ CodeLocationLabel ctiDefault;
#endif
int32_t offsetForValue(int32_t value, int32_t defaultOffset);
@@ -89,7 +89,7 @@ namespace JSC {
}
#if ENABLE(JIT)
- inline MacroAssembler::CodeLocationLabel ctiForValue(int32_t value)
+ inline CodeLocationLabel ctiForValue(int32_t value)
{
if (value >= min && static_cast<uint32_t>(value - min) < ctiOffsets.size())
return ctiOffsets[value - min];
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecode/StructureStubInfo.h b/src/3rdparty/webkit/JavaScriptCore/bytecode/StructureStubInfo.h
index 24fcb7d..95dd266 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecode/StructureStubInfo.h
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecode/StructureStubInfo.h
@@ -144,9 +144,9 @@ namespace JSC {
} putByIdReplace;
} u;
- MacroAssembler::CodeLocationLabel stubRoutine;
- MacroAssembler::CodeLocationCall callReturnLocation;
- MacroAssembler::CodeLocationLabel hotPathBegin;
+ CodeLocationLabel stubRoutine;
+ CodeLocationCall callReturnLocation;
+ CodeLocationLabel hotPathBegin;
};
} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp b/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
index 21a3016..7feb3c8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
@@ -1815,7 +1815,7 @@ RegisterID* BytecodeGenerator::emitNextPropertyName(RegisterID* dst, RegisterID*
RegisterID* BytecodeGenerator::emitCatch(RegisterID* targetRegister, Label* start, Label* end)
{
#if ENABLE(JIT)
- HandlerInfo info = { start->offsetFrom(0), end->offsetFrom(0), instructions().size(), m_dynamicScopeDepth + m_baseScopeDepth, MacroAssembler::CodeLocationLabel() };
+ HandlerInfo info = { start->offsetFrom(0), end->offsetFrom(0), instructions().size(), m_dynamicScopeDepth + m_baseScopeDepth, CodeLocationLabel() };
#else
HandlerInfo info = { start->offsetFrom(0), end->offsetFrom(0), instructions().size(), m_dynamicScopeDepth + m_baseScopeDepth };
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.h b/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.h
index 6813d69..d29a24d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.h
+++ b/src/3rdparty/webkit/JavaScriptCore/bytecompiler/BytecodeGenerator.h
@@ -37,11 +37,12 @@
#include "LabelScope.h"
#include "Interpreter.h"
#include "RegisterID.h"
-#include "SegmentedVector.h"
#include "SymbolTable.h"
#include "Debugger.h"
#include "Nodes.h"
+#include <wtf/FastAllocBase.h>
#include <wtf/PassRefPtr.h>
+#include <wtf/SegmentedVector.h>
#include <wtf/Vector.h>
namespace JSC {
@@ -60,7 +61,7 @@ namespace JSC {
FinallyContext finallyContext;
};
- class BytecodeGenerator {
+ class BytecodeGenerator : public WTF::FastAllocBase {
public:
typedef DeclarationStacks::VarStack VarStack;
typedef DeclarationStacks::FunctionStack FunctionStack;
@@ -449,11 +450,11 @@ namespace JSC {
RegisterID m_thisRegister;
RegisterID m_argumentsRegister;
int m_activationRegisterIndex;
- SegmentedVector<RegisterID, 32> m_calleeRegisters;
- SegmentedVector<RegisterID, 32> m_parameters;
- SegmentedVector<RegisterID, 32> m_globals;
- SegmentedVector<Label, 32> m_labels;
- SegmentedVector<LabelScope, 8> m_labelScopes;
+ WTF::SegmentedVector<RegisterID, 32> m_calleeRegisters;
+ WTF::SegmentedVector<RegisterID, 32> m_parameters;
+ WTF::SegmentedVector<RegisterID, 32> m_globals;
+ WTF::SegmentedVector<Label, 32> m_labels;
+ WTF::SegmentedVector<LabelScope, 8> m_labelScopes;
RefPtr<RegisterID> m_lastConstant;
int m_finallyDepth;
int m_dynamicScopeDepth;
diff --git a/src/3rdparty/webkit/JavaScriptCore/config.h b/src/3rdparty/webkit/JavaScriptCore/config.h
index cecae47..6681761 100644
--- a/src/3rdparty/webkit/JavaScriptCore/config.h
+++ b/src/3rdparty/webkit/JavaScriptCore/config.h
@@ -42,7 +42,7 @@
#define max max
#define min min
-#if !COMPILER(MSVC7) && !PLATFORM(WIN_CE)
+#if !COMPILER(MSVC7) && !PLATFORM(WINCE)
// We need to define this before the first #include of stdlib.h or it won't contain rand_s.
#ifndef _CRT_RAND_S
#define _CRT_RAND_S
diff --git a/src/3rdparty/webkit/JavaScriptCore/generated/DatePrototype.lut.h b/src/3rdparty/webkit/JavaScriptCore/generated/DatePrototype.lut.h
index d83e680..1f43d4d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/generated/DatePrototype.lut.h
+++ b/src/3rdparty/webkit/JavaScriptCore/generated/DatePrototype.lut.h
@@ -4,8 +4,9 @@
namespace JSC {
-static const struct HashTableValue dateTableValues[45] = {
+static const struct HashTableValue dateTableValues[47] = {
{ "toString", DontEnum|Function, (intptr_t)dateProtoFuncToString, (intptr_t)0 },
+ { "toISOString", DontEnum|Function, (intptr_t)dateProtoFuncToISOString, (intptr_t)0 },
{ "toUTCString", DontEnum|Function, (intptr_t)dateProtoFuncToUTCString, (intptr_t)0 },
{ "toDateString", DontEnum|Function, (intptr_t)dateProtoFuncToDateString, (intptr_t)0 },
{ "toTimeString", DontEnum|Function, (intptr_t)dateProtoFuncToTimeString, (intptr_t)0 },
@@ -49,6 +50,7 @@ static const struct HashTableValue dateTableValues[45] = {
{ "setUTCFullYear", DontEnum|Function, (intptr_t)dateProtoFuncSetUTCFullYear, (intptr_t)3 },
{ "setYear", DontEnum|Function, (intptr_t)dateProtoFuncSetYear, (intptr_t)1 },
{ "getYear", DontEnum|Function, (intptr_t)dateProtoFuncGetYear, (intptr_t)0 },
+ { "toJSON", DontEnum|Function, (intptr_t)dateProtoFuncToJSON, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
diff --git a/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.cpp b/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.cpp
index bc5ebe4..8e80eca 100644
--- a/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.cpp
@@ -1,23 +1,24 @@
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton implementation for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -28,7 +29,7 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
@@ -46,7 +47,7 @@
#define YYBISON 1
/* Bison version. */
-#define YYBISON_VERSION "2.4.1"
+#define YYBISON_VERSION "2.3"
/* Skeleton name. */
#define YYSKELETON_NAME "yacc.c"
@@ -54,28 +55,159 @@
/* Pure parsers. */
#define YYPURE 1
-/* Push parsers. */
-#define YYPUSH 0
-
-/* Pull parsers. */
-#define YYPULL 1
-
/* Using locations. */
#define YYLSP_NEEDED 1
/* Substitute the variable and function names. */
-#define yyparse jscyyparse
-#define yylex jscyylex
-#define yyerror jscyyerror
-#define yylval jscyylval
-#define yychar jscyychar
-#define yydebug jscyydebug
-#define yynerrs jscyynerrs
-#define yylloc jscyylloc
+#define yyparse jscyyparse
+#define yylex jscyylex
+#define yyerror jscyyerror
+#define yylval jscyylval
+#define yychar jscyychar
+#define yydebug jscyydebug
+#define yynerrs jscyynerrs
+#define yylloc jscyylloc
+
+/* Tokens. */
+#ifndef YYTOKENTYPE
+# define YYTOKENTYPE
+ /* Put the tokens into the symbol table, so that GDB and other debuggers
+ know about them. */
+ enum yytokentype {
+ NULLTOKEN = 258,
+ TRUETOKEN = 259,
+ FALSETOKEN = 260,
+ BREAK = 261,
+ CASE = 262,
+ DEFAULT = 263,
+ FOR = 264,
+ NEW = 265,
+ VAR = 266,
+ CONSTTOKEN = 267,
+ CONTINUE = 268,
+ FUNCTION = 269,
+ RETURN = 270,
+ VOIDTOKEN = 271,
+ DELETETOKEN = 272,
+ IF = 273,
+ THISTOKEN = 274,
+ DO = 275,
+ WHILE = 276,
+ INTOKEN = 277,
+ INSTANCEOF = 278,
+ TYPEOF = 279,
+ SWITCH = 280,
+ WITH = 281,
+ RESERVED = 282,
+ THROW = 283,
+ TRY = 284,
+ CATCH = 285,
+ FINALLY = 286,
+ DEBUGGER = 287,
+ IF_WITHOUT_ELSE = 288,
+ ELSE = 289,
+ EQEQ = 290,
+ NE = 291,
+ STREQ = 292,
+ STRNEQ = 293,
+ LE = 294,
+ GE = 295,
+ OR = 296,
+ AND = 297,
+ PLUSPLUS = 298,
+ MINUSMINUS = 299,
+ LSHIFT = 300,
+ RSHIFT = 301,
+ URSHIFT = 302,
+ PLUSEQUAL = 303,
+ MINUSEQUAL = 304,
+ MULTEQUAL = 305,
+ DIVEQUAL = 306,
+ LSHIFTEQUAL = 307,
+ RSHIFTEQUAL = 308,
+ URSHIFTEQUAL = 309,
+ ANDEQUAL = 310,
+ MODEQUAL = 311,
+ XOREQUAL = 312,
+ OREQUAL = 313,
+ OPENBRACE = 314,
+ CLOSEBRACE = 315,
+ NUMBER = 316,
+ IDENT = 317,
+ STRING = 318,
+ AUTOPLUSPLUS = 319,
+ AUTOMINUSMINUS = 320
+ };
+#endif
+/* Tokens. */
+#define NULLTOKEN 258
+#define TRUETOKEN 259
+#define FALSETOKEN 260
+#define BREAK 261
+#define CASE 262
+#define DEFAULT 263
+#define FOR 264
+#define NEW 265
+#define VAR 266
+#define CONSTTOKEN 267
+#define CONTINUE 268
+#define FUNCTION 269
+#define RETURN 270
+#define VOIDTOKEN 271
+#define DELETETOKEN 272
+#define IF 273
+#define THISTOKEN 274
+#define DO 275
+#define WHILE 276
+#define INTOKEN 277
+#define INSTANCEOF 278
+#define TYPEOF 279
+#define SWITCH 280
+#define WITH 281
+#define RESERVED 282
+#define THROW 283
+#define TRY 284
+#define CATCH 285
+#define FINALLY 286
+#define DEBUGGER 287
+#define IF_WITHOUT_ELSE 288
+#define ELSE 289
+#define EQEQ 290
+#define NE 291
+#define STREQ 292
+#define STRNEQ 293
+#define LE 294
+#define GE 295
+#define OR 296
+#define AND 297
+#define PLUSPLUS 298
+#define MINUSMINUS 299
+#define LSHIFT 300
+#define RSHIFT 301
+#define URSHIFT 302
+#define PLUSEQUAL 303
+#define MINUSEQUAL 304
+#define MULTEQUAL 305
+#define DIVEQUAL 306
+#define LSHIFTEQUAL 307
+#define RSHIFTEQUAL 308
+#define URSHIFTEQUAL 309
+#define ANDEQUAL 310
+#define MODEQUAL 311
+#define XOREQUAL 312
+#define OREQUAL 313
+#define OPENBRACE 314
+#define CLOSEBRACE 315
+#define NUMBER 316
+#define IDENT 317
+#define STRING 318
+#define AUTOPLUSPLUS 319
+#define AUTOMINUSMINUS 320
+
-/* Copy the first part of user declarations. */
-/* Line 189 of yacc.c */
+
+/* Copy the first part of user declarations. */
#line 3 "../parser/Grammar.y"
@@ -157,7 +289,7 @@ static ExpressionNode* makeSubNode(void*, ExpressionNode*, ExpressionNode*, bool
static ExpressionNode* makeLeftShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static ExpressionNode* makeRightShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static StatementNode* makeVarStatementNode(void*, ExpressionNode*);
-static ExpressionNode* combineVarInitializers(void*, ExpressionNode* list, AssignResolveNode* init);
+static ExpressionNode* combineCommaNodes(void*, ExpressionNode* list, ExpressionNode* init);
#if COMPILER(MSVC)
@@ -231,9 +363,6 @@ static inline void appendToVarDeclarationList(void* globalPtr, ParserArenaData<D
-/* Line 189 of yacc.c */
-#line 236 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
-
/* Enabling traces. */
#ifndef YYDEBUG
# define YYDEBUG 0
@@ -252,88 +381,10 @@ static inline void appendToVarDeclarationList(void* globalPtr, ParserArenaData<D
# define YYTOKEN_TABLE 0
#endif
-
-/* Tokens. */
-#ifndef YYTOKENTYPE
-# define YYTOKENTYPE
- /* Put the tokens into the symbol table, so that GDB and other debuggers
- know about them. */
- enum yytokentype {
- NULLTOKEN = 258,
- TRUETOKEN = 259,
- FALSETOKEN = 260,
- BREAK = 261,
- CASE = 262,
- DEFAULT = 263,
- FOR = 264,
- NEW = 265,
- VAR = 266,
- CONSTTOKEN = 267,
- CONTINUE = 268,
- FUNCTION = 269,
- RETURN = 270,
- VOIDTOKEN = 271,
- DELETETOKEN = 272,
- IF = 273,
- THISTOKEN = 274,
- DO = 275,
- WHILE = 276,
- INTOKEN = 277,
- INSTANCEOF = 278,
- TYPEOF = 279,
- SWITCH = 280,
- WITH = 281,
- RESERVED = 282,
- THROW = 283,
- TRY = 284,
- CATCH = 285,
- FINALLY = 286,
- DEBUGGER = 287,
- IF_WITHOUT_ELSE = 288,
- ELSE = 289,
- EQEQ = 290,
- NE = 291,
- STREQ = 292,
- STRNEQ = 293,
- LE = 294,
- GE = 295,
- OR = 296,
- AND = 297,
- PLUSPLUS = 298,
- MINUSMINUS = 299,
- LSHIFT = 300,
- RSHIFT = 301,
- URSHIFT = 302,
- PLUSEQUAL = 303,
- MINUSEQUAL = 304,
- MULTEQUAL = 305,
- DIVEQUAL = 306,
- LSHIFTEQUAL = 307,
- RSHIFTEQUAL = 308,
- URSHIFTEQUAL = 309,
- ANDEQUAL = 310,
- MODEQUAL = 311,
- XOREQUAL = 312,
- OREQUAL = 313,
- OPENBRACE = 314,
- CLOSEBRACE = 315,
- NUMBER = 316,
- IDENT = 317,
- STRING = 318,
- AUTOPLUSPLUS = 319,
- AUTOMINUSMINUS = 320
- };
-#endif
-
-
-
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 214 of yacc.c */
#line 157 "../parser/Grammar.y"
-
+{
int intValue;
double doubleValue;
Identifier* ident;
@@ -363,15 +414,13 @@ typedef union YYSTYPE
ParameterListInfo parameterList;
Operator op;
-
-
-
-/* Line 214 of yacc.c */
-#line 371 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 187 of yacc.c. */
+#line 420 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
#if ! defined YYLTYPE && ! defined YYLTYPE_IS_DECLARED
@@ -391,8 +440,8 @@ typedef struct YYLTYPE
/* Copy the second part of user declarations. */
-/* Line 264 of yacc.c */
-#line 396 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
+/* Line 216 of yacc.c. */
+#line 445 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
#ifdef short
# undef short
@@ -467,14 +516,14 @@ typedef short int yytype_int16;
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static int
-YYID (int yyi)
+YYID (int i)
#else
static int
-YYID (yyi)
- int yyi;
+YYID (i)
+ int i;
#endif
{
- return yyi;
+ return i;
}
#endif
@@ -556,9 +605,9 @@ void free (void *); /* INFRINGES ON USER NAME SPACE */
/* A type that is properly aligned for any stack member. */
union yyalloc
{
- yytype_int16 yyss_alloc;
- YYSTYPE yyvs_alloc;
- YYLTYPE yyls_alloc;
+ yytype_int16 yyss;
+ YYSTYPE yyvs;
+ YYLTYPE yyls;
};
/* The size of the maximum gap between one aligned stack and the next. */
@@ -593,12 +642,12 @@ union yyalloc
elements in the stack, and YYPTR gives the new location of the
stack. Advance YYPTR to a properly aligned location for the next
stack. */
-# define YYSTACK_RELOCATE(Stack_alloc, Stack) \
+# define YYSTACK_RELOCATE(Stack) \
do \
{ \
YYSIZE_T yynewbytes; \
- YYCOPY (&yyptr->Stack_alloc, Stack, yysize); \
- Stack = &yyptr->Stack_alloc; \
+ YYCOPY (&yyptr->Stack, Stack, yysize); \
+ Stack = &yyptr->Stack; \
yynewbytes = yystacksize * sizeof (*Stack) + YYSTACK_GAP_MAXIMUM; \
yyptr += yynewbytes / sizeof (*yyptr); \
} \
@@ -2312,20 +2361,17 @@ yy_symbol_print (yyoutput, yytype, yyvaluep, yylocationp)
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static void
-yy_stack_print (yytype_int16 *yybottom, yytype_int16 *yytop)
+yy_stack_print (yytype_int16 *bottom, yytype_int16 *top)
#else
static void
-yy_stack_print (yybottom, yytop)
- yytype_int16 *yybottom;
- yytype_int16 *yytop;
+yy_stack_print (bottom, top)
+ yytype_int16 *bottom;
+ yytype_int16 *top;
#endif
{
YYFPRINTF (stderr, "Stack now");
- for (; yybottom <= yytop; yybottom++)
- {
- int yybot = *yybottom;
- YYFPRINTF (stderr, " %d", yybot);
- }
+ for (; bottom <= top; ++bottom)
+ YYFPRINTF (stderr, " %d", *bottom);
YYFPRINTF (stderr, "\n");
}
@@ -2360,11 +2406,11 @@ yy_reduce_print (yyvsp, yylsp, yyrule)
/* The symbols being reduced. */
for (yyi = 0; yyi < yynrhs; yyi++)
{
- YYFPRINTF (stderr, " $%d = ", yyi + 1);
+ fprintf (stderr, " $%d = ", yyi + 1);
yy_symbol_print (stderr, yyrhs[yyprhs[yyrule] + yyi],
&(yyvsp[(yyi + 1) - (yynrhs)])
, &(yylsp[(yyi + 1) - (yynrhs)]) );
- YYFPRINTF (stderr, "\n");
+ fprintf (stderr, "\n");
}
}
@@ -2646,8 +2692,10 @@ yydestruct (yymsg, yytype, yyvaluep, yylocationp)
break;
}
}
+
/* Prevent warnings from -Wmissing-prototypes. */
+
#ifdef YYPARSE_PARAM
#if defined __STDC__ || defined __cplusplus
int yyparse (void *YYPARSE_PARAM);
@@ -2666,9 +2714,10 @@ int yyparse ();
-/*-------------------------.
-| yyparse or yypush_parse. |
-`-------------------------*/
+
+/*----------.
+| yyparse. |
+`----------*/
#ifdef YYPARSE_PARAM
#if (defined __STDC__ || defined __C99__FUNC__ \
@@ -2692,97 +2741,88 @@ yyparse ()
#endif
#endif
{
-/* The lookahead symbol. */
+ /* The look-ahead symbol. */
int yychar;
-/* The semantic value of the lookahead symbol. */
+/* The semantic value of the look-ahead symbol. */
YYSTYPE yylval;
-/* Location data for the lookahead symbol. */
+/* Number of syntax errors so far. */
+int yynerrs;
+/* Location data for the look-ahead symbol. */
YYLTYPE yylloc;
- /* Number of syntax errors so far. */
- int yynerrs;
-
- int yystate;
- /* Number of tokens to shift before error messages enabled. */
- int yyerrstatus;
+ int yystate;
+ int yyn;
+ int yyresult;
+ /* Number of tokens to shift before error messages enabled. */
+ int yyerrstatus;
+ /* Look-ahead token as an internal (translated) token number. */
+ int yytoken = 0;
+#if YYERROR_VERBOSE
+ /* Buffer for error messages, and its allocated size. */
+ char yymsgbuf[128];
+ char *yymsg = yymsgbuf;
+ YYSIZE_T yymsg_alloc = sizeof yymsgbuf;
+#endif
- /* The stacks and their tools:
- `yyss': related to states.
- `yyvs': related to semantic values.
- `yyls': related to locations.
+ /* Three stacks and their tools:
+ `yyss': related to states,
+ `yyvs': related to semantic values,
+ `yyls': related to locations.
- Refer to the stacks thru separate pointers, to allow yyoverflow
- to reallocate them elsewhere. */
+ Refer to the stacks thru separate pointers, to allow yyoverflow
+ to reallocate them elsewhere. */
- /* The state stack. */
- yytype_int16 yyssa[YYINITDEPTH];
- yytype_int16 *yyss;
- yytype_int16 *yyssp;
+ /* The state stack. */
+ yytype_int16 yyssa[YYINITDEPTH];
+ yytype_int16 *yyss = yyssa;
+ yytype_int16 *yyssp;
- /* The semantic value stack. */
- YYSTYPE yyvsa[YYINITDEPTH];
- YYSTYPE *yyvs;
- YYSTYPE *yyvsp;
+ /* The semantic value stack. */
+ YYSTYPE yyvsa[YYINITDEPTH];
+ YYSTYPE *yyvs = yyvsa;
+ YYSTYPE *yyvsp;
- /* The location stack. */
- YYLTYPE yylsa[YYINITDEPTH];
- YYLTYPE *yyls;
- YYLTYPE *yylsp;
+ /* The location stack. */
+ YYLTYPE yylsa[YYINITDEPTH];
+ YYLTYPE *yyls = yylsa;
+ YYLTYPE *yylsp;
+ /* The locations where the error started and ended. */
+ YYLTYPE yyerror_range[2];
- /* The locations where the error started and ended. */
- YYLTYPE yyerror_range[2];
+#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N), yylsp -= (N))
- YYSIZE_T yystacksize;
+ YYSIZE_T yystacksize = YYINITDEPTH;
- int yyn;
- int yyresult;
- /* Lookahead token as an internal (translated) token number. */
- int yytoken;
/* The variables used to return semantic value and location from the
action routines. */
YYSTYPE yyval;
YYLTYPE yyloc;
-#if YYERROR_VERBOSE
- /* Buffer for error messages, and its allocated size. */
- char yymsgbuf[128];
- char *yymsg = yymsgbuf;
- YYSIZE_T yymsg_alloc = sizeof yymsgbuf;
-#endif
-
-#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N), yylsp -= (N))
-
/* The number of symbols on the RHS of the reduced rule.
Keep to zero when no symbol should be popped. */
int yylen = 0;
- yytoken = 0;
- yyss = yyssa;
- yyvs = yyvsa;
- yyls = yylsa;
- yystacksize = YYINITDEPTH;
-
YYDPRINTF ((stderr, "Starting parse\n"));
yystate = 0;
yyerrstatus = 0;
yynerrs = 0;
- yychar = YYEMPTY; /* Cause a token to be read. */
+ yychar = YYEMPTY; /* Cause a token to be read. */
/* Initialize stack pointers.
Waste one element of value and location stack
so that they stay on the same level as the state stack.
The wasted elements are never initialized. */
+
yyssp = yyss;
yyvsp = yyvs;
yylsp = yyls;
-
#if YYLTYPE_IS_TRIVIAL
/* Initialize the default location before parsing starts. */
yylloc.first_line = yylloc.last_line = 1;
- yylloc.first_column = yylloc.last_column = 1;
+ yylloc.first_column = yylloc.last_column = 0;
#endif
goto yysetstate;
@@ -2821,7 +2861,6 @@ YYLTYPE yylloc;
&yyvs1, yysize * sizeof (*yyvsp),
&yyls1, yysize * sizeof (*yylsp),
&yystacksize);
-
yyls = yyls1;
yyss = yyss1;
yyvs = yyvs1;
@@ -2843,9 +2882,9 @@ YYLTYPE yylloc;
(union yyalloc *) YYSTACK_ALLOC (YYSTACK_BYTES (yystacksize));
if (! yyptr)
goto yyexhaustedlab;
- YYSTACK_RELOCATE (yyss_alloc, yyss);
- YYSTACK_RELOCATE (yyvs_alloc, yyvs);
- YYSTACK_RELOCATE (yyls_alloc, yyls);
+ YYSTACK_RELOCATE (yyss);
+ YYSTACK_RELOCATE (yyvs);
+ YYSTACK_RELOCATE (yyls);
# undef YYSTACK_RELOCATE
if (yyss1 != yyssa)
YYSTACK_FREE (yyss1);
@@ -2866,9 +2905,6 @@ YYLTYPE yylloc;
YYDPRINTF ((stderr, "Entering state %d\n", yystate));
- if (yystate == YYFINAL)
- YYACCEPT;
-
goto yybackup;
/*-----------.
@@ -2877,16 +2913,16 @@ YYLTYPE yylloc;
yybackup:
/* Do appropriate processing given the current state. Read a
- lookahead token if we need one and don't already have one. */
+ look-ahead token if we need one and don't already have one. */
- /* First try to decide what to do without reference to lookahead token. */
+ /* First try to decide what to do without reference to look-ahead token. */
yyn = yypact[yystate];
if (yyn == YYPACT_NINF)
goto yydefault;
- /* Not known => get a lookahead token if don't already have one. */
+ /* Not known => get a look-ahead token if don't already have one. */
- /* YYCHAR is either YYEMPTY or YYEOF or a valid lookahead symbol. */
+ /* YYCHAR is either YYEMPTY or YYEOF or a valid look-ahead symbol. */
if (yychar == YYEMPTY)
{
YYDPRINTF ((stderr, "Reading a token: "));
@@ -2918,16 +2954,20 @@ yybackup:
goto yyreduce;
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
/* Count tokens shifted since error; after three, turn off error
status. */
if (yyerrstatus)
yyerrstatus--;
- /* Shift the lookahead token. */
+ /* Shift the look-ahead token. */
YY_SYMBOL_PRINT ("Shifting", yytoken, &yylval, &yylloc);
- /* Discard the shifted token. */
- yychar = YYEMPTY;
+ /* Discard the shifted token unless it is eof. */
+ if (yychar != YYEOF)
+ yychar = YYEMPTY;
yystate = yyn;
*++yyvsp = yylval;
@@ -2968,43 +3008,31 @@ yyreduce:
switch (yyn)
{
case 2:
-
-/* Line 1455 of yacc.c */
#line 290 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NullNode(GLOBAL_DATA), 0, 1); ;}
break;
case 3:
-
-/* Line 1455 of yacc.c */
#line 291 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BooleanNode(GLOBAL_DATA, true), 0, 1); ;}
break;
case 4:
-
-/* Line 1455 of yacc.c */
#line 292 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BooleanNode(GLOBAL_DATA, false), 0, 1); ;}
break;
case 5:
-
-/* Line 1455 of yacc.c */
#line 293 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeNumberNode(GLOBAL_DATA, (yyvsp[(1) - (1)].doubleValue)), 0, 1); ;}
break;
case 6:
-
-/* Line 1455 of yacc.c */
#line 294 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StringNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident)), 0, 1); ;}
break;
case 7:
-
-/* Line 1455 of yacc.c */
#line 295 "../parser/Grammar.y"
{
Lexer& l = *LEXER;
@@ -3018,8 +3046,6 @@ yyreduce:
break;
case 8:
-
-/* Line 1455 of yacc.c */
#line 304 "../parser/Grammar.y"
{
Lexer& l = *LEXER;
@@ -3033,36 +3059,26 @@ yyreduce:
break;
case 9:
-
-/* Line 1455 of yacc.c */
#line 316 "../parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 10:
-
-/* Line 1455 of yacc.c */
#line 317 "../parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 11:
-
-/* Line 1455 of yacc.c */
#line 318 "../parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, Identifier(GLOBAL_DATA, UString::from((yyvsp[(1) - (3)].doubleValue))), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 12:
-
-/* Line 1455 of yacc.c */
#line 319 "../parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(makeGetterOrSetterPropertyNode(globalPtr, *(yyvsp[(1) - (7)].ident), *(yyvsp[(2) - (7)].ident), 0, (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); if (!(yyval.propertyNode).m_node) YYABORT; ;}
break;
case 13:
-
-/* Line 1455 of yacc.c */
#line 321 "../parser/Grammar.y"
{
(yyval.propertyNode) = createNodeInfo<PropertyNode*>(makeGetterOrSetterPropertyNode(globalPtr, *(yyvsp[(1) - (8)].ident), *(yyvsp[(2) - (8)].ident), (yyvsp[(4) - (8)].parameterList).m_node.head, (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line)), (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -3075,8 +3091,6 @@ yyreduce:
break;
case 14:
-
-/* Line 1455 of yacc.c */
#line 332 "../parser/Grammar.y"
{ (yyval.propertyList).m_node.head = new (GLOBAL_DATA) PropertyListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].propertyNode).m_node);
(yyval.propertyList).m_node.tail = (yyval.propertyList).m_node.head;
@@ -3085,8 +3099,6 @@ yyreduce:
break;
case 15:
-
-/* Line 1455 of yacc.c */
#line 336 "../parser/Grammar.y"
{ (yyval.propertyList).m_node.head = (yyvsp[(1) - (3)].propertyList).m_node.head;
(yyval.propertyList).m_node.tail = new (GLOBAL_DATA) PropertyListNode(GLOBAL_DATA, (yyvsp[(3) - (3)].propertyNode).m_node, (yyvsp[(1) - (3)].propertyList).m_node.tail);
@@ -3095,71 +3107,51 @@ yyreduce:
break;
case 17:
-
-/* Line 1455 of yacc.c */
#line 344 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA), 0, 0); ;}
break;
case 18:
-
-/* Line 1455 of yacc.c */
#line 345 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA, (yyvsp[(2) - (3)].propertyList).m_node.head), (yyvsp[(2) - (3)].propertyList).m_features, (yyvsp[(2) - (3)].propertyList).m_numConstants); ;}
break;
case 19:
-
-/* Line 1455 of yacc.c */
#line 347 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA, (yyvsp[(2) - (4)].propertyList).m_node.head), (yyvsp[(2) - (4)].propertyList).m_features, (yyvsp[(2) - (4)].propertyList).m_numConstants); ;}
break;
case 20:
-
-/* Line 1455 of yacc.c */
#line 351 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ThisNode(GLOBAL_DATA), ThisFeature, 0); ;}
break;
case 23:
-
-/* Line 1455 of yacc.c */
#line 354 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident), (yylsp[(1) - (1)]).first_column), (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0, 0); ;}
break;
case 24:
-
-/* Line 1455 of yacc.c */
#line 355 "../parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (3)].expressionNode); ;}
break;
case 25:
-
-/* Line 1455 of yacc.c */
#line 359 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(2) - (3)].intValue)), 0, (yyvsp[(2) - (3)].intValue) ? 1 : 0); ;}
break;
case 26:
-
-/* Line 1455 of yacc.c */
#line 360 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(2) - (3)].elementList).m_node.head), (yyvsp[(2) - (3)].elementList).m_features, (yyvsp[(2) - (3)].elementList).m_numConstants); ;}
break;
case 27:
-
-/* Line 1455 of yacc.c */
#line 361 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(4) - (5)].intValue), (yyvsp[(2) - (5)].elementList).m_node.head), (yyvsp[(2) - (5)].elementList).m_features, (yyvsp[(4) - (5)].intValue) ? (yyvsp[(2) - (5)].elementList).m_numConstants + 1 : (yyvsp[(2) - (5)].elementList).m_numConstants); ;}
break;
case 28:
-
-/* Line 1455 of yacc.c */
#line 365 "../parser/Grammar.y"
{ (yyval.elementList).m_node.head = new (GLOBAL_DATA) ElementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].intValue), (yyvsp[(2) - (2)].expressionNode).m_node);
(yyval.elementList).m_node.tail = (yyval.elementList).m_node.head;
@@ -3168,8 +3160,6 @@ yyreduce:
break;
case 29:
-
-/* Line 1455 of yacc.c */
#line 370 "../parser/Grammar.y"
{ (yyval.elementList).m_node.head = (yyvsp[(1) - (4)].elementList).m_node.head;
(yyval.elementList).m_node.tail = new (GLOBAL_DATA) ElementNode(GLOBAL_DATA, (yyvsp[(1) - (4)].elementList).m_node.tail, (yyvsp[(3) - (4)].intValue), (yyvsp[(4) - (4)].expressionNode).m_node);
@@ -3178,36 +3168,26 @@ yyreduce:
break;
case 30:
-
-/* Line 1455 of yacc.c */
#line 377 "../parser/Grammar.y"
{ (yyval.intValue) = 0; ;}
break;
case 32:
-
-/* Line 1455 of yacc.c */
#line 382 "../parser/Grammar.y"
{ (yyval.intValue) = 1; ;}
break;
case 33:
-
-/* Line 1455 of yacc.c */
#line 383 "../parser/Grammar.y"
{ (yyval.intValue) = (yyvsp[(1) - (2)].intValue) + 1; ;}
break;
case 35:
-
-/* Line 1455 of yacc.c */
#line 388 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>((yyvsp[(1) - (1)].funcExprNode).m_node, (yyvsp[(1) - (1)].funcExprNode).m_features, (yyvsp[(1) - (1)].funcExprNode).m_numConstants); ;}
break;
case 36:
-
-/* Line 1455 of yacc.c */
#line 389 "../parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3216,8 +3196,6 @@ yyreduce:
break;
case 37:
-
-/* Line 1455 of yacc.c */
#line 393 "../parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3226,8 +3204,6 @@ yyreduce:
break;
case 38:
-
-/* Line 1455 of yacc.c */
#line 397 "../parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].argumentsNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3236,8 +3212,6 @@ yyreduce:
break;
case 40:
-
-/* Line 1455 of yacc.c */
#line 405 "../parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3246,8 +3220,6 @@ yyreduce:
break;
case 41:
-
-/* Line 1455 of yacc.c */
#line 409 "../parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3256,8 +3228,6 @@ yyreduce:
break;
case 42:
-
-/* Line 1455 of yacc.c */
#line 413 "../parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].argumentsNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3266,8 +3236,6 @@ yyreduce:
break;
case 44:
-
-/* Line 1455 of yacc.c */
#line 421 "../parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column);
@@ -3276,8 +3244,6 @@ yyreduce:
break;
case 46:
-
-/* Line 1455 of yacc.c */
#line 429 "../parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column);
@@ -3286,22 +3252,16 @@ yyreduce:
break;
case 47:
-
-/* Line 1455 of yacc.c */
#line 436 "../parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 48:
-
-/* Line 1455 of yacc.c */
#line 437 "../parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 49:
-
-/* Line 1455 of yacc.c */
#line 438 "../parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3310,8 +3270,6 @@ yyreduce:
break;
case 50:
-
-/* Line 1455 of yacc.c */
#line 442 "../parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3319,22 +3277,16 @@ yyreduce:
break;
case 51:
-
-/* Line 1455 of yacc.c */
#line 448 "../parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 52:
-
-/* Line 1455 of yacc.c */
#line 449 "../parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 53:
-
-/* Line 1455 of yacc.c */
#line 450 "../parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3343,8 +3295,6 @@ yyreduce:
break;
case 54:
-
-/* Line 1455 of yacc.c */
#line 454 "../parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3353,22 +3303,16 @@ yyreduce:
break;
case 55:
-
-/* Line 1455 of yacc.c */
#line 461 "../parser/Grammar.y"
{ (yyval.argumentsNode) = createNodeInfo<ArgumentsNode*>(new (GLOBAL_DATA) ArgumentsNode(GLOBAL_DATA), 0, 0); ;}
break;
case 56:
-
-/* Line 1455 of yacc.c */
#line 462 "../parser/Grammar.y"
{ (yyval.argumentsNode) = createNodeInfo<ArgumentsNode*>(new (GLOBAL_DATA) ArgumentsNode(GLOBAL_DATA, (yyvsp[(2) - (3)].argumentList).m_node.head), (yyvsp[(2) - (3)].argumentList).m_features, (yyvsp[(2) - (3)].argumentList).m_numConstants); ;}
break;
case 57:
-
-/* Line 1455 of yacc.c */
#line 466 "../parser/Grammar.y"
{ (yyval.argumentList).m_node.head = new (GLOBAL_DATA) ArgumentListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].expressionNode).m_node);
(yyval.argumentList).m_node.tail = (yyval.argumentList).m_node.head;
@@ -3377,8 +3321,6 @@ yyreduce:
break;
case 58:
-
-/* Line 1455 of yacc.c */
#line 470 "../parser/Grammar.y"
{ (yyval.argumentList).m_node.head = (yyvsp[(1) - (3)].argumentList).m_node.head;
(yyval.argumentList).m_node.tail = new (GLOBAL_DATA) ArgumentListNode(GLOBAL_DATA, (yyvsp[(1) - (3)].argumentList).m_node.tail, (yyvsp[(3) - (3)].expressionNode).m_node);
@@ -3387,253 +3329,181 @@ yyreduce:
break;
case 64:
-
-/* Line 1455 of yacc.c */
#line 488 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 65:
-
-/* Line 1455 of yacc.c */
#line 489 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 67:
-
-/* Line 1455 of yacc.c */
#line 494 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 68:
-
-/* Line 1455 of yacc.c */
#line 495 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 69:
-
-/* Line 1455 of yacc.c */
#line 499 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDeleteNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 70:
-
-/* Line 1455 of yacc.c */
#line 500 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) VoidNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants + 1); ;}
break;
case 71:
-
-/* Line 1455 of yacc.c */
#line 501 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeTypeOfNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 72:
-
-/* Line 1455 of yacc.c */
#line 502 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 73:
-
-/* Line 1455 of yacc.c */
#line 503 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 74:
-
-/* Line 1455 of yacc.c */
#line 504 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 75:
-
-/* Line 1455 of yacc.c */
#line 505 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 76:
-
-/* Line 1455 of yacc.c */
#line 506 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnaryPlusNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 77:
-
-/* Line 1455 of yacc.c */
#line 507 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeNegateNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 78:
-
-/* Line 1455 of yacc.c */
#line 508 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeBitwiseNotNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 79:
-
-/* Line 1455 of yacc.c */
#line 509 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalNotNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 85:
-
-/* Line 1455 of yacc.c */
#line 523 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeMultNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 86:
-
-/* Line 1455 of yacc.c */
#line 524 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDivNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 87:
-
-/* Line 1455 of yacc.c */
#line 525 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ModNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 89:
-
-/* Line 1455 of yacc.c */
#line 531 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeMultNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 90:
-
-/* Line 1455 of yacc.c */
#line 533 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDivNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 91:
-
-/* Line 1455 of yacc.c */
#line 535 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ModNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 93:
-
-/* Line 1455 of yacc.c */
#line 540 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAddNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 94:
-
-/* Line 1455 of yacc.c */
#line 541 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeSubNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 96:
-
-/* Line 1455 of yacc.c */
#line 547 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAddNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 97:
-
-/* Line 1455 of yacc.c */
#line 549 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeSubNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 99:
-
-/* Line 1455 of yacc.c */
#line 554 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeLeftShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 100:
-
-/* Line 1455 of yacc.c */
#line 555 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 101:
-
-/* Line 1455 of yacc.c */
#line 556 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnsignedRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 103:
-
-/* Line 1455 of yacc.c */
#line 561 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeLeftShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 104:
-
-/* Line 1455 of yacc.c */
#line 562 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 105:
-
-/* Line 1455 of yacc.c */
#line 563 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnsignedRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 107:
-
-/* Line 1455 of yacc.c */
#line 568 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 108:
-
-/* Line 1455 of yacc.c */
#line 569 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 109:
-
-/* Line 1455 of yacc.c */
#line 570 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 110:
-
-/* Line 1455 of yacc.c */
#line 571 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 111:
-
-/* Line 1455 of yacc.c */
#line 572 "../parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3641,8 +3511,6 @@ yyreduce:
break;
case 112:
-
-/* Line 1455 of yacc.c */
#line 575 "../parser/Grammar.y"
{ InNode* node = new (GLOBAL_DATA) InNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3650,36 +3518,26 @@ yyreduce:
break;
case 114:
-
-/* Line 1455 of yacc.c */
#line 582 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 115:
-
-/* Line 1455 of yacc.c */
#line 583 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 116:
-
-/* Line 1455 of yacc.c */
#line 584 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 117:
-
-/* Line 1455 of yacc.c */
#line 585 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 118:
-
-/* Line 1455 of yacc.c */
#line 587 "../parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3687,36 +3545,26 @@ yyreduce:
break;
case 120:
-
-/* Line 1455 of yacc.c */
#line 594 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 121:
-
-/* Line 1455 of yacc.c */
#line 595 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 122:
-
-/* Line 1455 of yacc.c */
#line 596 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 123:
-
-/* Line 1455 of yacc.c */
#line 597 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 124:
-
-/* Line 1455 of yacc.c */
#line 599 "../parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3724,8 +3572,6 @@ yyreduce:
break;
case 125:
-
-/* Line 1455 of yacc.c */
#line 603 "../parser/Grammar.y"
{ InNode* node = new (GLOBAL_DATA) InNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3733,218 +3579,156 @@ yyreduce:
break;
case 127:
-
-/* Line 1455 of yacc.c */
#line 610 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 128:
-
-/* Line 1455 of yacc.c */
#line 611 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 129:
-
-/* Line 1455 of yacc.c */
#line 612 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 130:
-
-/* Line 1455 of yacc.c */
#line 613 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 132:
-
-/* Line 1455 of yacc.c */
#line 619 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 133:
-
-/* Line 1455 of yacc.c */
#line 621 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 134:
-
-/* Line 1455 of yacc.c */
#line 623 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 135:
-
-/* Line 1455 of yacc.c */
#line 625 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 137:
-
-/* Line 1455 of yacc.c */
#line 631 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 138:
-
-/* Line 1455 of yacc.c */
#line 632 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 139:
-
-/* Line 1455 of yacc.c */
#line 634 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 140:
-
-/* Line 1455 of yacc.c */
#line 636 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 142:
-
-/* Line 1455 of yacc.c */
#line 641 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 144:
-
-/* Line 1455 of yacc.c */
#line 647 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 146:
-
-/* Line 1455 of yacc.c */
#line 652 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 148:
-
-/* Line 1455 of yacc.c */
#line 657 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 150:
-
-/* Line 1455 of yacc.c */
#line 663 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 152:
-
-/* Line 1455 of yacc.c */
#line 669 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 154:
-
-/* Line 1455 of yacc.c */
#line 674 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 156:
-
-/* Line 1455 of yacc.c */
#line 680 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 158:
-
-/* Line 1455 of yacc.c */
#line 686 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 160:
-
-/* Line 1455 of yacc.c */
#line 691 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 162:
-
-/* Line 1455 of yacc.c */
#line 697 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 164:
-
-/* Line 1455 of yacc.c */
#line 703 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 166:
-
-/* Line 1455 of yacc.c */
#line 708 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 168:
-
-/* Line 1455 of yacc.c */
#line 714 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 170:
-
-/* Line 1455 of yacc.c */
#line 719 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 172:
-
-/* Line 1455 of yacc.c */
#line 725 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 174:
-
-/* Line 1455 of yacc.c */
#line 731 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 176:
-
-/* Line 1455 of yacc.c */
#line 737 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 178:
-
-/* Line 1455 of yacc.c */
#line 743 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3952,8 +3736,6 @@ yyreduce:
break;
case 180:
-
-/* Line 1455 of yacc.c */
#line 751 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3961,8 +3743,6 @@ yyreduce:
break;
case 182:
-
-/* Line 1455 of yacc.c */
#line 759 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3970,137 +3750,99 @@ yyreduce:
break;
case 183:
-
-/* Line 1455 of yacc.c */
#line 765 "../parser/Grammar.y"
{ (yyval.op) = OpEqual; ;}
break;
case 184:
-
-/* Line 1455 of yacc.c */
#line 766 "../parser/Grammar.y"
{ (yyval.op) = OpPlusEq; ;}
break;
case 185:
-
-/* Line 1455 of yacc.c */
#line 767 "../parser/Grammar.y"
{ (yyval.op) = OpMinusEq; ;}
break;
case 186:
-
-/* Line 1455 of yacc.c */
#line 768 "../parser/Grammar.y"
{ (yyval.op) = OpMultEq; ;}
break;
case 187:
-
-/* Line 1455 of yacc.c */
#line 769 "../parser/Grammar.y"
{ (yyval.op) = OpDivEq; ;}
break;
case 188:
-
-/* Line 1455 of yacc.c */
#line 770 "../parser/Grammar.y"
{ (yyval.op) = OpLShift; ;}
break;
case 189:
-
-/* Line 1455 of yacc.c */
#line 771 "../parser/Grammar.y"
{ (yyval.op) = OpRShift; ;}
break;
case 190:
-
-/* Line 1455 of yacc.c */
#line 772 "../parser/Grammar.y"
{ (yyval.op) = OpURShift; ;}
break;
case 191:
-
-/* Line 1455 of yacc.c */
#line 773 "../parser/Grammar.y"
{ (yyval.op) = OpAndEq; ;}
break;
case 192:
-
-/* Line 1455 of yacc.c */
#line 774 "../parser/Grammar.y"
{ (yyval.op) = OpXOrEq; ;}
break;
case 193:
-
-/* Line 1455 of yacc.c */
#line 775 "../parser/Grammar.y"
{ (yyval.op) = OpOrEq; ;}
break;
case 194:
-
-/* Line 1455 of yacc.c */
#line 776 "../parser/Grammar.y"
{ (yyval.op) = OpModEq; ;}
break;
case 196:
-
-/* Line 1455 of yacc.c */
#line 781 "../parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 198:
-
-/* Line 1455 of yacc.c */
#line 786 "../parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 200:
-
-/* Line 1455 of yacc.c */
#line 791 "../parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 218:
-
-/* Line 1455 of yacc.c */
#line 815 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) BlockNode(GLOBAL_DATA, 0), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 219:
-
-/* Line 1455 of yacc.c */
#line 817 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) BlockNode(GLOBAL_DATA, (yyvsp[(2) - (3)].sourceElements).m_node), (yyvsp[(2) - (3)].sourceElements).m_varDeclarations, (yyvsp[(2) - (3)].sourceElements).m_funcDeclarations, (yyvsp[(2) - (3)].sourceElements).m_features, (yyvsp[(2) - (3)].sourceElements).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 220:
-
-/* Line 1455 of yacc.c */
#line 822 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(makeVarStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].varDeclList).m_node), (yyvsp[(2) - (3)].varDeclList).m_varDeclarations, (yyvsp[(2) - (3)].varDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].varDeclList).m_features, (yyvsp[(2) - (3)].varDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 221:
-
-/* Line 1455 of yacc.c */
#line 824 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(makeVarStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].varDeclList).m_node), (yyvsp[(2) - (3)].varDeclList).m_varDeclarations, (yyvsp[(2) - (3)].varDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].varDeclList).m_features, (yyvsp[(2) - (3)].varDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(2) - (3)]));
@@ -4108,8 +3850,6 @@ yyreduce:
break;
case 222:
-
-/* Line 1455 of yacc.c */
#line 830 "../parser/Grammar.y"
{ (yyval.varDeclList).m_node = 0;
(yyval.varDeclList).m_varDeclarations = new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::VarStack>;
@@ -4121,8 +3861,6 @@ yyreduce:
break;
case 223:
-
-/* Line 1455 of yacc.c */
#line 837 "../parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node, (yyvsp[(2) - (2)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column);
@@ -4136,8 +3874,6 @@ yyreduce:
break;
case 224:
-
-/* Line 1455 of yacc.c */
#line 847 "../parser/Grammar.y"
{ (yyval.varDeclList).m_node = (yyvsp[(1) - (3)].varDeclList).m_node;
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (3)].varDeclList).m_varDeclarations;
@@ -4149,12 +3885,10 @@ yyreduce:
break;
case 225:
-
-/* Line 1455 of yacc.c */
#line 855 "../parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(3) - (4)].ident), (yyvsp[(4) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(3) - (4)]).first_column, (yylsp[(4) - (4)]).first_column + 1, (yylsp[(4) - (4)]).last_column);
- (yyval.varDeclList).m_node = combineVarInitializers(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
+ (yyval.varDeclList).m_node = combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (4)].varDeclList).m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, (yyval.varDeclList).m_varDeclarations, *(yyvsp[(3) - (4)].ident), DeclarationStacks::HasInitializer);
(yyval.varDeclList).m_funcDeclarations = 0;
@@ -4164,8 +3898,6 @@ yyreduce:
break;
case 226:
-
-/* Line 1455 of yacc.c */
#line 867 "../parser/Grammar.y"
{ (yyval.varDeclList).m_node = 0;
(yyval.varDeclList).m_varDeclarations = new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::VarStack>;
@@ -4177,8 +3909,6 @@ yyreduce:
break;
case 227:
-
-/* Line 1455 of yacc.c */
#line 874 "../parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node, (yyvsp[(2) - (2)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column);
@@ -4192,8 +3922,6 @@ yyreduce:
break;
case 228:
-
-/* Line 1455 of yacc.c */
#line 884 "../parser/Grammar.y"
{ (yyval.varDeclList).m_node = (yyvsp[(1) - (3)].varDeclList).m_node;
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (3)].varDeclList).m_varDeclarations;
@@ -4205,12 +3933,10 @@ yyreduce:
break;
case 229:
-
-/* Line 1455 of yacc.c */
#line 892 "../parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(3) - (4)].ident), (yyvsp[(4) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(3) - (4)]).first_column, (yylsp[(4) - (4)]).first_column + 1, (yylsp[(4) - (4)]).last_column);
- (yyval.varDeclList).m_node = combineVarInitializers(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
+ (yyval.varDeclList).m_node = combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (4)].varDeclList).m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, (yyval.varDeclList).m_varDeclarations, *(yyvsp[(3) - (4)].ident), DeclarationStacks::HasInitializer);
(yyval.varDeclList).m_funcDeclarations = 0;
@@ -4220,24 +3946,18 @@ yyreduce:
break;
case 230:
-
-/* Line 1455 of yacc.c */
#line 904 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ConstStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].constDeclList).m_node.head), (yyvsp[(2) - (3)].constDeclList).m_varDeclarations, (yyvsp[(2) - (3)].constDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].constDeclList).m_features, (yyvsp[(2) - (3)].constDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 231:
-
-/* Line 1455 of yacc.c */
#line 907 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ConstStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].constDeclList).m_node.head), (yyvsp[(2) - (3)].constDeclList).m_varDeclarations, (yyvsp[(2) - (3)].constDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].constDeclList).m_features, (yyvsp[(2) - (3)].constDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(2) - (3)])); AUTO_SEMICOLON; ;}
break;
case 232:
-
-/* Line 1455 of yacc.c */
#line 912 "../parser/Grammar.y"
{ (yyval.constDeclList).m_node.head = (yyvsp[(1) - (1)].constDeclNode).m_node;
(yyval.constDeclList).m_node.tail = (yyval.constDeclList).m_node.head;
@@ -4250,8 +3970,6 @@ yyreduce:
break;
case 233:
-
-/* Line 1455 of yacc.c */
#line 921 "../parser/Grammar.y"
{ (yyval.constDeclList).m_node.head = (yyvsp[(1) - (3)].constDeclList).m_node.head;
(yyvsp[(1) - (3)].constDeclList).m_node.tail->m_next = (yyvsp[(3) - (3)].constDeclNode).m_node;
@@ -4264,67 +3982,49 @@ yyreduce:
break;
case 234:
-
-/* Line 1455 of yacc.c */
#line 932 "../parser/Grammar.y"
{ (yyval.constDeclNode) = createNodeInfo<ConstDeclNode*>(new (GLOBAL_DATA) ConstDeclNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident), 0), (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0, 0); ;}
break;
case 235:
-
-/* Line 1455 of yacc.c */
#line 933 "../parser/Grammar.y"
{ (yyval.constDeclNode) = createNodeInfo<ConstDeclNode*>(new (GLOBAL_DATA) ConstDeclNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node), ((*(yyvsp[(1) - (2)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 236:
-
-/* Line 1455 of yacc.c */
#line 937 "../parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (2)].expressionNode); ;}
break;
case 237:
-
-/* Line 1455 of yacc.c */
#line 941 "../parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (2)].expressionNode); ;}
break;
case 238:
-
-/* Line 1455 of yacc.c */
#line 945 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) EmptyStatementNode(GLOBAL_DATA), 0, 0, 0, 0); ;}
break;
case 239:
-
-/* Line 1455 of yacc.c */
#line 949 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ExprStatementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node), 0, 0, (yyvsp[(1) - (2)].expressionNode).m_features, (yyvsp[(1) - (2)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 240:
-
-/* Line 1455 of yacc.c */
#line 951 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ExprStatementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node), 0, 0, (yyvsp[(1) - (2)].expressionNode).m_features, (yyvsp[(1) - (2)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(1) - (2)])); AUTO_SEMICOLON; ;}
break;
case 241:
-
-/* Line 1455 of yacc.c */
#line 957 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) IfNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node), (yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (5)]), (yylsp[(4) - (5)])); ;}
break;
case 242:
-
-/* Line 1455 of yacc.c */
#line 960 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) IfElseNode(GLOBAL_DATA, (yyvsp[(3) - (7)].expressionNode).m_node, (yyvsp[(5) - (7)].statementNode).m_node, (yyvsp[(7) - (7)].statementNode).m_node),
mergeDeclarationLists((yyvsp[(5) - (7)].statementNode).m_varDeclarations, (yyvsp[(7) - (7)].statementNode).m_varDeclarations),
@@ -4335,32 +4035,24 @@ yyreduce:
break;
case 243:
-
-/* Line 1455 of yacc.c */
#line 969 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DoWhileNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node), (yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(2) - (7)].statementNode).m_funcDeclarations, (yyvsp[(2) - (7)].statementNode).m_features | (yyvsp[(5) - (7)].expressionNode).m_features, (yyvsp[(2) - (7)].statementNode).m_numConstants + (yyvsp[(5) - (7)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (7)]), (yylsp[(3) - (7)])); ;}
break;
case 244:
-
-/* Line 1455 of yacc.c */
#line 971 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DoWhileNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node), (yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(2) - (7)].statementNode).m_funcDeclarations, (yyvsp[(2) - (7)].statementNode).m_features | (yyvsp[(5) - (7)].expressionNode).m_features, (yyvsp[(2) - (7)].statementNode).m_numConstants + (yyvsp[(5) - (7)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (7)]), (yylsp[(3) - (7)])); ;}
break;
case 245:
-
-/* Line 1455 of yacc.c */
#line 973 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) WhileNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node), (yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (5)]), (yylsp[(4) - (5)])); ;}
break;
case 246:
-
-/* Line 1455 of yacc.c */
#line 976 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ForNode(GLOBAL_DATA, (yyvsp[(3) - (9)].expressionNode).m_node, (yyvsp[(5) - (9)].expressionNode).m_node, (yyvsp[(7) - (9)].expressionNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node, false), (yyvsp[(9) - (9)].statementNode).m_varDeclarations, (yyvsp[(9) - (9)].statementNode).m_funcDeclarations,
(yyvsp[(3) - (9)].expressionNode).m_features | (yyvsp[(5) - (9)].expressionNode).m_features | (yyvsp[(7) - (9)].expressionNode).m_features | (yyvsp[(9) - (9)].statementNode).m_features,
@@ -4370,8 +4062,6 @@ yyreduce:
break;
case 247:
-
-/* Line 1455 of yacc.c */
#line 982 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ForNode(GLOBAL_DATA, (yyvsp[(4) - (10)].varDeclList).m_node, (yyvsp[(6) - (10)].expressionNode).m_node, (yyvsp[(8) - (10)].expressionNode).m_node, (yyvsp[(10) - (10)].statementNode).m_node, true),
mergeDeclarationLists((yyvsp[(4) - (10)].varDeclList).m_varDeclarations, (yyvsp[(10) - (10)].statementNode).m_varDeclarations),
@@ -4382,8 +4072,6 @@ yyreduce:
break;
case 248:
-
-/* Line 1455 of yacc.c */
#line 989 "../parser/Grammar.y"
{
ForInNode* node = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, (yyvsp[(3) - (7)].expressionNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node, (yyvsp[(7) - (7)].statementNode).m_node);
@@ -4396,8 +4084,6 @@ yyreduce:
break;
case 249:
-
-/* Line 1455 of yacc.c */
#line 998 "../parser/Grammar.y"
{ ForInNode *forIn = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, *(yyvsp[(4) - (8)].ident), 0, (yyvsp[(6) - (8)].expressionNode).m_node, (yyvsp[(8) - (8)].statementNode).m_node, (yylsp[(5) - (8)]).first_column, (yylsp[(5) - (8)]).first_column - (yylsp[(4) - (8)]).first_column, (yylsp[(6) - (8)]).last_column - (yylsp[(5) - (8)]).first_column);
SET_EXCEPTION_LOCATION(forIn, (yylsp[(4) - (8)]).first_column, (yylsp[(5) - (8)]).first_column + 1, (yylsp[(6) - (8)]).last_column);
@@ -4407,8 +4093,6 @@ yyreduce:
break;
case 250:
-
-/* Line 1455 of yacc.c */
#line 1004 "../parser/Grammar.y"
{ ForInNode *forIn = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, *(yyvsp[(4) - (9)].ident), (yyvsp[(5) - (9)].expressionNode).m_node, (yyvsp[(7) - (9)].expressionNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node, (yylsp[(5) - (9)]).first_column, (yylsp[(5) - (9)]).first_column - (yylsp[(4) - (9)]).first_column, (yylsp[(5) - (9)]).last_column - (yylsp[(5) - (9)]).first_column);
SET_EXCEPTION_LOCATION(forIn, (yylsp[(4) - (9)]).first_column, (yylsp[(6) - (9)]).first_column + 1, (yylsp[(7) - (9)]).last_column);
@@ -4420,22 +4104,16 @@ yyreduce:
break;
case 251:
-
-/* Line 1455 of yacc.c */
#line 1014 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(0, 0, 0); ;}
break;
case 253:
-
-/* Line 1455 of yacc.c */
#line 1019 "../parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(0, 0, 0); ;}
break;
case 255:
-
-/* Line 1455 of yacc.c */
#line 1024 "../parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4444,8 +4122,6 @@ yyreduce:
break;
case 256:
-
-/* Line 1455 of yacc.c */
#line 1028 "../parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4454,8 +4130,6 @@ yyreduce:
break;
case 257:
-
-/* Line 1455 of yacc.c */
#line 1032 "../parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4464,8 +4138,6 @@ yyreduce:
break;
case 258:
-
-/* Line 1455 of yacc.c */
#line 1036 "../parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4474,8 +4146,6 @@ yyreduce:
break;
case 259:
-
-/* Line 1455 of yacc.c */
#line 1043 "../parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4483,8 +4153,6 @@ yyreduce:
break;
case 260:
-
-/* Line 1455 of yacc.c */
#line 1046 "../parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4492,8 +4160,6 @@ yyreduce:
break;
case 261:
-
-/* Line 1455 of yacc.c */
#line 1049 "../parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4501,8 +4167,6 @@ yyreduce:
break;
case 262:
-
-/* Line 1455 of yacc.c */
#line 1052 "../parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4510,8 +4174,6 @@ yyreduce:
break;
case 263:
-
-/* Line 1455 of yacc.c */
#line 1058 "../parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, 0);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4519,8 +4181,6 @@ yyreduce:
break;
case 264:
-
-/* Line 1455 of yacc.c */
#line 1061 "../parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, 0);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4528,8 +4188,6 @@ yyreduce:
break;
case 265:
-
-/* Line 1455 of yacc.c */
#line 1064 "../parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4537,8 +4195,6 @@ yyreduce:
break;
case 266:
-
-/* Line 1455 of yacc.c */
#line 1067 "../parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4546,8 +4202,6 @@ yyreduce:
break;
case 267:
-
-/* Line 1455 of yacc.c */
#line 1073 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) WithNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node, (yylsp[(3) - (5)]).last_column, (yylsp[(3) - (5)]).last_column - (yylsp[(3) - (5)]).first_column),
(yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features | WithFeature, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
@@ -4555,8 +4209,6 @@ yyreduce:
break;
case 268:
-
-/* Line 1455 of yacc.c */
#line 1079 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) SwitchNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].caseBlockNode).m_node), (yyvsp[(5) - (5)].caseBlockNode).m_varDeclarations, (yyvsp[(5) - (5)].caseBlockNode).m_funcDeclarations,
(yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].caseBlockNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].caseBlockNode).m_numConstants);
@@ -4564,15 +4216,11 @@ yyreduce:
break;
case 269:
-
-/* Line 1455 of yacc.c */
#line 1085 "../parser/Grammar.y"
{ (yyval.caseBlockNode) = createNodeDeclarationInfo<CaseBlockNode*>(new (GLOBAL_DATA) CaseBlockNode(GLOBAL_DATA, (yyvsp[(2) - (3)].clauseList).m_node.head, 0, 0), (yyvsp[(2) - (3)].clauseList).m_varDeclarations, (yyvsp[(2) - (3)].clauseList).m_funcDeclarations, (yyvsp[(2) - (3)].clauseList).m_features, (yyvsp[(2) - (3)].clauseList).m_numConstants); ;}
break;
case 270:
-
-/* Line 1455 of yacc.c */
#line 1087 "../parser/Grammar.y"
{ (yyval.caseBlockNode) = createNodeDeclarationInfo<CaseBlockNode*>(new (GLOBAL_DATA) CaseBlockNode(GLOBAL_DATA, (yyvsp[(2) - (5)].clauseList).m_node.head, (yyvsp[(3) - (5)].caseClauseNode).m_node, (yyvsp[(4) - (5)].clauseList).m_node.head),
mergeDeclarationLists(mergeDeclarationLists((yyvsp[(2) - (5)].clauseList).m_varDeclarations, (yyvsp[(3) - (5)].caseClauseNode).m_varDeclarations), (yyvsp[(4) - (5)].clauseList).m_varDeclarations),
@@ -4582,15 +4230,11 @@ yyreduce:
break;
case 271:
-
-/* Line 1455 of yacc.c */
#line 1095 "../parser/Grammar.y"
{ (yyval.clauseList).m_node.head = 0; (yyval.clauseList).m_node.tail = 0; (yyval.clauseList).m_varDeclarations = 0; (yyval.clauseList).m_funcDeclarations = 0; (yyval.clauseList).m_features = 0; (yyval.clauseList).m_numConstants = 0; ;}
break;
case 273:
-
-/* Line 1455 of yacc.c */
#line 1100 "../parser/Grammar.y"
{ (yyval.clauseList).m_node.head = new (GLOBAL_DATA) ClauseListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].caseClauseNode).m_node);
(yyval.clauseList).m_node.tail = (yyval.clauseList).m_node.head;
@@ -4601,8 +4245,6 @@ yyreduce:
break;
case 274:
-
-/* Line 1455 of yacc.c */
#line 1106 "../parser/Grammar.y"
{ (yyval.clauseList).m_node.head = (yyvsp[(1) - (2)].clauseList).m_node.head;
(yyval.clauseList).m_node.tail = new (GLOBAL_DATA) ClauseListNode(GLOBAL_DATA, (yyvsp[(1) - (2)].clauseList).m_node.tail, (yyvsp[(2) - (2)].caseClauseNode).m_node);
@@ -4614,36 +4256,26 @@ yyreduce:
break;
case 275:
-
-/* Line 1455 of yacc.c */
#line 1116 "../parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node), 0, 0, (yyvsp[(2) - (3)].expressionNode).m_features, (yyvsp[(2) - (3)].expressionNode).m_numConstants); ;}
break;
case 276:
-
-/* Line 1455 of yacc.c */
#line 1117 "../parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, (yyvsp[(2) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].sourceElements).m_node), (yyvsp[(4) - (4)].sourceElements).m_varDeclarations, (yyvsp[(4) - (4)].sourceElements).m_funcDeclarations, (yyvsp[(2) - (4)].expressionNode).m_features | (yyvsp[(4) - (4)].sourceElements).m_features, (yyvsp[(2) - (4)].expressionNode).m_numConstants + (yyvsp[(4) - (4)].sourceElements).m_numConstants); ;}
break;
case 277:
-
-/* Line 1455 of yacc.c */
#line 1121 "../parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, 0), 0, 0, 0, 0); ;}
break;
case 278:
-
-/* Line 1455 of yacc.c */
#line 1122 "../parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, 0, (yyvsp[(3) - (3)].sourceElements).m_node), (yyvsp[(3) - (3)].sourceElements).m_varDeclarations, (yyvsp[(3) - (3)].sourceElements).m_funcDeclarations, (yyvsp[(3) - (3)].sourceElements).m_features, (yyvsp[(3) - (3)].sourceElements).m_numConstants); ;}
break;
case 279:
-
-/* Line 1455 of yacc.c */
#line 1126 "../parser/Grammar.y"
{ LabelNode* node = new (GLOBAL_DATA) LabelNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].statementNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4651,8 +4283,6 @@ yyreduce:
break;
case 280:
-
-/* Line 1455 of yacc.c */
#line 1132 "../parser/Grammar.y"
{ ThrowNode* node = new (GLOBAL_DATA) ThrowNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4661,8 +4291,6 @@ yyreduce:
break;
case 281:
-
-/* Line 1455 of yacc.c */
#line 1136 "../parser/Grammar.y"
{ ThrowNode* node = new (GLOBAL_DATA) ThrowNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4671,8 +4299,6 @@ yyreduce:
break;
case 282:
-
-/* Line 1455 of yacc.c */
#line 1143 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (4)].statementNode).m_node, GLOBAL_DATA->propertyNames->nullIdentifier, false, 0, (yyvsp[(4) - (4)].statementNode).m_node),
mergeDeclarationLists((yyvsp[(2) - (4)].statementNode).m_varDeclarations, (yyvsp[(4) - (4)].statementNode).m_varDeclarations),
@@ -4683,8 +4309,6 @@ yyreduce:
break;
case 283:
-
-/* Line 1455 of yacc.c */
#line 1149 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, *(yyvsp[(5) - (7)].ident), ((yyvsp[(7) - (7)].statementNode).m_features & EvalFeature) != 0, (yyvsp[(7) - (7)].statementNode).m_node, 0),
mergeDeclarationLists((yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(7) - (7)].statementNode).m_varDeclarations),
@@ -4695,8 +4319,6 @@ yyreduce:
break;
case 284:
-
-/* Line 1455 of yacc.c */
#line 1156 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (9)].statementNode).m_node, *(yyvsp[(5) - (9)].ident), ((yyvsp[(7) - (9)].statementNode).m_features & EvalFeature) != 0, (yyvsp[(7) - (9)].statementNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node),
mergeDeclarationLists(mergeDeclarationLists((yyvsp[(2) - (9)].statementNode).m_varDeclarations, (yyvsp[(7) - (9)].statementNode).m_varDeclarations), (yyvsp[(9) - (9)].statementNode).m_varDeclarations),
@@ -4707,31 +4329,23 @@ yyreduce:
break;
case 285:
-
-/* Line 1455 of yacc.c */
#line 1165 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DebuggerStatementNode(GLOBAL_DATA), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 286:
-
-/* Line 1455 of yacc.c */
#line 1167 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DebuggerStatementNode(GLOBAL_DATA), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(1) - (2)])); AUTO_SEMICOLON; ;}
break;
case 287:
-
-/* Line 1455 of yacc.c */
#line 1172 "../parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new FuncDeclNode(GLOBAL_DATA, *(yyvsp[(2) - (7)].ident), (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), 0, new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::FunctionStack>, ((*(yyvsp[(2) - (7)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); (yyval.statementNode).m_funcDeclarations->data.append(static_cast<FuncDeclNode*>((yyval.statementNode).m_node)); ;}
break;
case 288:
-
-/* Line 1455 of yacc.c */
#line 1174 "../parser/Grammar.y"
{
(yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new FuncDeclNode(GLOBAL_DATA, *(yyvsp[(2) - (8)].ident), (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line), (yyvsp[(4) - (8)].parameterList).m_node.head), 0, new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::FunctionStack>, ((*(yyvsp[(2) - (8)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -4743,15 +4357,11 @@ yyreduce:
break;
case 289:
-
-/* Line 1455 of yacc.c */
#line 1184 "../parser/Grammar.y"
{ (yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, GLOBAL_DATA->propertyNames->nullIdentifier, (yyvsp[(5) - (6)].functionBodyNode), LEXER->sourceCode((yyvsp[(4) - (6)].intValue), (yyvsp[(6) - (6)].intValue), (yylsp[(4) - (6)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(5) - (6)].functionBodyNode), (yylsp[(4) - (6)]), (yylsp[(6) - (6)])); ;}
break;
case 290:
-
-/* Line 1455 of yacc.c */
#line 1186 "../parser/Grammar.y"
{
(yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, GLOBAL_DATA->propertyNames->nullIdentifier, (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line), (yyvsp[(3) - (7)].parameterList).m_node.head), (yyvsp[(3) - (7)].parameterList).m_features | ClosureFeature, 0);
@@ -4762,15 +4372,11 @@ yyreduce:
break;
case 291:
-
-/* Line 1455 of yacc.c */
#line 1192 "../parser/Grammar.y"
{ (yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, *(yyvsp[(2) - (7)].ident), (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); ;}
break;
case 292:
-
-/* Line 1455 of yacc.c */
#line 1194 "../parser/Grammar.y"
{
(yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, *(yyvsp[(2) - (8)].ident), (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line), (yyvsp[(4) - (8)].parameterList).m_node.head), (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -4781,8 +4387,6 @@ yyreduce:
break;
case 293:
-
-/* Line 1455 of yacc.c */
#line 1203 "../parser/Grammar.y"
{ (yyval.parameterList).m_node.head = new (GLOBAL_DATA) ParameterNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident));
(yyval.parameterList).m_features = (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0;
@@ -4790,8 +4394,6 @@ yyreduce:
break;
case 294:
-
-/* Line 1455 of yacc.c */
#line 1206 "../parser/Grammar.y"
{ (yyval.parameterList).m_node.head = (yyvsp[(1) - (3)].parameterList).m_node.head;
(yyval.parameterList).m_features = (yyvsp[(1) - (3)].parameterList).m_features | ((*(yyvsp[(3) - (3)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0);
@@ -4799,37 +4401,27 @@ yyreduce:
break;
case 295:
-
-/* Line 1455 of yacc.c */
#line 1212 "../parser/Grammar.y"
{ (yyval.functionBodyNode) = FunctionBodyNode::create(GLOBAL_DATA); ;}
break;
case 296:
-
-/* Line 1455 of yacc.c */
#line 1213 "../parser/Grammar.y"
{ (yyval.functionBodyNode) = FunctionBodyNode::create(GLOBAL_DATA); ;}
break;
case 297:
-
-/* Line 1455 of yacc.c */
#line 1217 "../parser/Grammar.y"
{ GLOBAL_DATA->parser->didFinishParsing(new (GLOBAL_DATA) SourceElements(GLOBAL_DATA), 0, 0, NoFeatures, (yylsp[(0) - (0)]).last_line, 0); ;}
break;
case 298:
-
-/* Line 1455 of yacc.c */
#line 1218 "../parser/Grammar.y"
{ GLOBAL_DATA->parser->didFinishParsing((yyvsp[(1) - (1)].sourceElements).m_node, (yyvsp[(1) - (1)].sourceElements).m_varDeclarations, (yyvsp[(1) - (1)].sourceElements).m_funcDeclarations, (yyvsp[(1) - (1)].sourceElements).m_features,
(yylsp[(1) - (1)]).last_line, (yyvsp[(1) - (1)].sourceElements).m_numConstants); ;}
break;
case 299:
-
-/* Line 1455 of yacc.c */
#line 1223 "../parser/Grammar.y"
{ (yyval.sourceElements).m_node = new (GLOBAL_DATA) SourceElements(GLOBAL_DATA);
(yyval.sourceElements).m_node->append((yyvsp[(1) - (1)].statementNode).m_node);
@@ -4841,8 +4433,6 @@ yyreduce:
break;
case 300:
-
-/* Line 1455 of yacc.c */
#line 1230 "../parser/Grammar.y"
{ (yyval.sourceElements).m_node->append((yyvsp[(2) - (2)].statementNode).m_node);
(yyval.sourceElements).m_varDeclarations = mergeDeclarationLists((yyvsp[(1) - (2)].sourceElements).m_varDeclarations, (yyvsp[(2) - (2)].statementNode).m_varDeclarations);
@@ -4853,261 +4443,188 @@ yyreduce:
break;
case 304:
-
-/* Line 1455 of yacc.c */
#line 1244 "../parser/Grammar.y"
{ ;}
break;
case 305:
-
-/* Line 1455 of yacc.c */
#line 1245 "../parser/Grammar.y"
{ ;}
break;
case 306:
-
-/* Line 1455 of yacc.c */
#line 1246 "../parser/Grammar.y"
{ Lexer& l = *LEXER; if (!l.scanRegExp()) YYABORT; ;}
break;
case 307:
-
-/* Line 1455 of yacc.c */
#line 1247 "../parser/Grammar.y"
{ Lexer& l = *LEXER; if (!l.scanRegExp()) YYABORT; ;}
break;
case 308:
-
-/* Line 1455 of yacc.c */
#line 1251 "../parser/Grammar.y"
{ ;}
break;
case 309:
-
-/* Line 1455 of yacc.c */
#line 1252 "../parser/Grammar.y"
{ ;}
break;
case 310:
-
-/* Line 1455 of yacc.c */
#line 1253 "../parser/Grammar.y"
{ ;}
break;
case 311:
-
-/* Line 1455 of yacc.c */
#line 1254 "../parser/Grammar.y"
{ if (*(yyvsp[(1) - (7)].ident) != "get" && *(yyvsp[(1) - (7)].ident) != "set") YYABORT; ;}
break;
case 312:
-
-/* Line 1455 of yacc.c */
#line 1255 "../parser/Grammar.y"
{ if (*(yyvsp[(1) - (8)].ident) != "get" && *(yyvsp[(1) - (8)].ident) != "set") YYABORT; ;}
break;
case 316:
-
-/* Line 1455 of yacc.c */
#line 1265 "../parser/Grammar.y"
{ ;}
break;
case 317:
-
-/* Line 1455 of yacc.c */
#line 1266 "../parser/Grammar.y"
{ ;}
break;
case 318:
-
-/* Line 1455 of yacc.c */
#line 1268 "../parser/Grammar.y"
{ ;}
break;
case 322:
-
-/* Line 1455 of yacc.c */
#line 1275 "../parser/Grammar.y"
{ ;}
break;
case 517:
-
-/* Line 1455 of yacc.c */
#line 1643 "../parser/Grammar.y"
{ ;}
break;
case 518:
-
-/* Line 1455 of yacc.c */
#line 1644 "../parser/Grammar.y"
{ ;}
break;
case 520:
-
-/* Line 1455 of yacc.c */
#line 1649 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 521:
-
-/* Line 1455 of yacc.c */
#line 1653 "../parser/Grammar.y"
{ ;}
break;
case 522:
-
-/* Line 1455 of yacc.c */
#line 1654 "../parser/Grammar.y"
{ ;}
break;
case 525:
-
-/* Line 1455 of yacc.c */
#line 1660 "../parser/Grammar.y"
{ ;}
break;
case 526:
-
-/* Line 1455 of yacc.c */
#line 1661 "../parser/Grammar.y"
{ ;}
break;
case 530:
-
-/* Line 1455 of yacc.c */
#line 1668 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 533:
-
-/* Line 1455 of yacc.c */
#line 1677 "../parser/Grammar.y"
{ ;}
break;
case 534:
-
-/* Line 1455 of yacc.c */
#line 1678 "../parser/Grammar.y"
{ ;}
break;
case 539:
-
-/* Line 1455 of yacc.c */
#line 1695 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 555:
-
-/* Line 1455 of yacc.c */
#line 1726 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 557:
-
-/* Line 1455 of yacc.c */
#line 1728 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 559:
-
-/* Line 1455 of yacc.c */
#line 1733 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 561:
-
-/* Line 1455 of yacc.c */
#line 1735 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 563:
-
-/* Line 1455 of yacc.c */
#line 1740 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 565:
-
-/* Line 1455 of yacc.c */
#line 1742 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 568:
-
-/* Line 1455 of yacc.c */
#line 1754 "../parser/Grammar.y"
{ ;}
break;
case 569:
-
-/* Line 1455 of yacc.c */
#line 1755 "../parser/Grammar.y"
{ ;}
break;
case 578:
-
-/* Line 1455 of yacc.c */
#line 1779 "../parser/Grammar.y"
{ ;}
break;
case 580:
-
-/* Line 1455 of yacc.c */
#line 1784 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 585:
-
-/* Line 1455 of yacc.c */
#line 1795 "../parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 592:
-
-/* Line 1455 of yacc.c */
#line 1811 "../parser/Grammar.y"
{ ;}
break;
-
-/* Line 1455 of yacc.c */
-#line 5111 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
+/* Line 1267 of yacc.c. */
+#line 4628 "JavaScriptCore/tmp/../generated/Grammar.tab.c"
default: break;
}
YY_SYMBOL_PRINT ("-> $$ =", yyr1[yyn], &yyval, &yyloc);
@@ -5183,7 +4700,7 @@ yyerrlab:
if (yyerrstatus == 3)
{
- /* If just tried and failed to reuse lookahead token after an
+ /* If just tried and failed to reuse look-ahead token after an
error, discard it. */
if (yychar <= YYEOF)
@@ -5200,7 +4717,7 @@ yyerrlab:
}
}
- /* Else will try to reuse lookahead token after shifting the error
+ /* Else will try to reuse look-ahead token after shifting the error
token. */
goto yyerrlab1;
@@ -5258,11 +4775,14 @@ yyerrlab1:
YY_STACK_PRINT (yyss, yyssp);
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
*++yyvsp = yylval;
yyerror_range[1] = yylloc;
/* Using YYLLOC is tempting, but would change the location of
- the lookahead. YYLOC is available though. */
+ the look-ahead. YYLOC is available though. */
YYLLOC_DEFAULT (yyloc, (yyerror_range - 1), 2);
*++yylsp = yyloc;
@@ -5287,7 +4807,7 @@ yyabortlab:
yyresult = 1;
goto yyreturn;
-#if !defined(yyoverflow) || YYERROR_VERBOSE
+#ifndef yyoverflow
/*-------------------------------------------------.
| yyexhaustedlab -- memory exhaustion comes here. |
`-------------------------------------------------*/
@@ -5298,7 +4818,7 @@ yyexhaustedlab:
#endif
yyreturn:
- if (yychar != YYEMPTY)
+ if (yychar != YYEOF && yychar != YYEMPTY)
yydestruct ("Cleanup: discarding lookahead",
yytoken, &yylval, &yylloc);
/* Do not reclaim the symbols of the rule which action triggered
@@ -5324,8 +4844,6 @@ yyreturn:
}
-
-/* Line 1675 of yacc.c */
#line 1827 "../parser/Grammar.y"
@@ -5574,10 +5092,14 @@ static bool allowAutomaticSemicolon(Lexer& lexer, int yychar)
return yychar == CLOSEBRACE || yychar == 0 || lexer.prevTerminator();
}
-static ExpressionNode* combineVarInitializers(void* globalPtr, ExpressionNode* list, AssignResolveNode* init)
+static ExpressionNode* combineCommaNodes(void* globalPtr, ExpressionNode* list, ExpressionNode* init)
{
if (!list)
return init;
+ if (list->isCommaNode()) {
+ static_cast<CommaNode*>(list)->append(init);
+ return list;
+ }
return new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, list, init);
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.h b/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.h
index c7d3837..ebd30c8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.h
+++ b/src/3rdparty/webkit/JavaScriptCore/generated/Grammar.h
@@ -1,23 +1,24 @@
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton interface for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -28,11 +29,10 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
-
/* Tokens. */
#ifndef YYTOKENTYPE
# define YYTOKENTYPE
@@ -104,16 +104,78 @@
AUTOMINUSMINUS = 320
};
#endif
+/* Tokens. */
+#define NULLTOKEN 258
+#define TRUETOKEN 259
+#define FALSETOKEN 260
+#define BREAK 261
+#define CASE 262
+#define DEFAULT 263
+#define FOR 264
+#define NEW 265
+#define VAR 266
+#define CONSTTOKEN 267
+#define CONTINUE 268
+#define FUNCTION 269
+#define RETURN 270
+#define VOIDTOKEN 271
+#define DELETETOKEN 272
+#define IF 273
+#define THISTOKEN 274
+#define DO 275
+#define WHILE 276
+#define INTOKEN 277
+#define INSTANCEOF 278
+#define TYPEOF 279
+#define SWITCH 280
+#define WITH 281
+#define RESERVED 282
+#define THROW 283
+#define TRY 284
+#define CATCH 285
+#define FINALLY 286
+#define DEBUGGER 287
+#define IF_WITHOUT_ELSE 288
+#define ELSE 289
+#define EQEQ 290
+#define NE 291
+#define STREQ 292
+#define STRNEQ 293
+#define LE 294
+#define GE 295
+#define OR 296
+#define AND 297
+#define PLUSPLUS 298
+#define MINUSMINUS 299
+#define LSHIFT 300
+#define RSHIFT 301
+#define URSHIFT 302
+#define PLUSEQUAL 303
+#define MINUSEQUAL 304
+#define MULTEQUAL 305
+#define DIVEQUAL 306
+#define LSHIFTEQUAL 307
+#define RSHIFTEQUAL 308
+#define URSHIFTEQUAL 309
+#define ANDEQUAL 310
+#define MODEQUAL 311
+#define XOREQUAL 312
+#define OREQUAL 313
+#define OPENBRACE 314
+#define CLOSEBRACE 315
+#define NUMBER 316
+#define IDENT 317
+#define STRING 318
+#define AUTOPLUSPLUS 319
+#define AUTOMINUSMINUS 320
+
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 1676 of yacc.c */
#line 157 "../parser/Grammar.y"
-
+{
int intValue;
double doubleValue;
Identifier* ident;
@@ -143,15 +205,13 @@ typedef union YYSTYPE
ParameterListInfo parameterList;
Operator op;
-
-
-
-/* Line 1676 of yacc.c */
-#line 151 "JavaScriptCore/tmp/../generated/Grammar.tab.h"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 1489 of yacc.c. */
+#line 211 "JavaScriptCore/tmp/../generated/Grammar.tab.h"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
@@ -170,4 +230,3 @@ typedef struct YYLTYPE
#endif
-
diff --git a/src/3rdparty/webkit/JavaScriptCore/generated/JSONObject.lut.h b/src/3rdparty/webkit/JavaScriptCore/generated/JSONObject.lut.h
new file mode 100644
index 0000000..2b7e836
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/generated/JSONObject.lut.h
@@ -0,0 +1,15 @@
+// Automatically generated from ../runtime/JSONObject.cpp using JavaScriptCore/create_hash_table. DO NOT EDIT!
+
+#include "Lookup.h"
+
+namespace JSC {
+
+static const struct HashTableValue jsonTableValues[3] = {
+ { "parse", DontEnum|Function, (intptr_t)JSONProtoFuncParse, (intptr_t)1 },
+ { "stringify", DontEnum|Function, (intptr_t)JSONProtoFuncStringify, (intptr_t)1 },
+ { 0, 0, 0, 0 }
+};
+
+extern const struct HashTable jsonTable =
+ { 4, 3, jsonTableValues, 0 };
+} // namespace
diff --git a/src/3rdparty/webkit/JavaScriptCore/interpreter/CallFrame.h b/src/3rdparty/webkit/JavaScriptCore/interpreter/CallFrame.h
index a61e143..0b0e5fe 100644
--- a/src/3rdparty/webkit/JavaScriptCore/interpreter/CallFrame.h
+++ b/src/3rdparty/webkit/JavaScriptCore/interpreter/CallFrame.h
@@ -89,6 +89,7 @@ namespace JSC {
#endif
static const HashTable* arrayTable(CallFrame* callFrame) { return callFrame->globalData().arrayTable; }
static const HashTable* dateTable(CallFrame* callFrame) { return callFrame->globalData().dateTable; }
+ static const HashTable* jsonTable(CallFrame* callFrame) { return callFrame->globalData().jsonTable; }
static const HashTable* mathTable(CallFrame* callFrame) { return callFrame->globalData().mathTable; }
static const HashTable* numberTable(CallFrame* callFrame) { return callFrame->globalData().numberTable; }
static const HashTable* regExpTable(CallFrame* callFrame) { return callFrame->globalData().regExpTable; }
diff --git a/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.cpp b/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.cpp
index d980962..7b1e547 100644
--- a/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.cpp
@@ -76,7 +76,7 @@ namespace JSC {
static ALWAYS_INLINE unsigned bytecodeOffsetForPC(CallFrame* callFrame, CodeBlock* codeBlock, void* pc)
{
#if ENABLE(JIT)
- return codeBlock->getBytecodeIndex(callFrame, pc);
+ return codeBlock->getBytecodeIndex(callFrame, ReturnAddressPtr(pc));
#else
UNUSED_PARAM(callFrame);
return static_cast<Instruction*>(pc) - codeBlock->instructions().begin();
@@ -350,7 +350,7 @@ NEVER_INLINE JSValue Interpreter::callEval(CallFrame* callFrame, RegisterFile* r
UString programSource = asString(program)->value();
- LiteralParser preparser(callFrame, programSource);
+ LiteralParser preparser(callFrame, programSource, LiteralParser::NonStrictJSON);
if (JSValue parsedObject = preparser.tryLiteralParse())
return parsedObject;
@@ -970,12 +970,18 @@ NEVER_INLINE void Interpreter::tryCachePutByID(CallFrame* callFrame, CodeBlock*
return;
}
+ StructureChain* protoChain = structure->prototypeChain(callFrame);
+ if (!protoChain->isCacheable()) {
+ vPC[0] = getOpcode(op_put_by_id_generic);
+ return;
+ }
+
// Structure transition, cache transition info
if (slot.type() == PutPropertySlot::NewProperty) {
vPC[0] = getOpcode(op_put_by_id_transition);
vPC[4] = structure->previousID();
vPC[5] = structure;
- vPC[6] = structure->prototypeChain(callFrame);
+ vPC[6] = protoChain;
vPC[7] = slot.cachedOffset();
codeBlock->refStructures(vPC);
return;
@@ -1077,9 +1083,15 @@ NEVER_INLINE void Interpreter::tryCacheGetByID(CallFrame* callFrame, CodeBlock*
return;
}
+ StructureChain* protoChain = structure->prototypeChain(callFrame);
+ if (!protoChain->isCacheable()) {
+ vPC[0] = getOpcode(op_get_by_id_generic);
+ return;
+ }
+
vPC[0] = getOpcode(op_get_by_id_chain);
vPC[4] = structure;
- vPC[5] = structure->prototypeChain(callFrame);
+ vPC[5] = protoChain;
vPC[6] = count;
vPC[7] = slot.cachedOffset();
codeBlock->refStructures(vPC);
diff --git a/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.h b/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.h
index 7cab254..702c89c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.h
+++ b/src/3rdparty/webkit/JavaScriptCore/interpreter/Interpreter.h
@@ -66,7 +66,7 @@ namespace JSC {
enum { MaxMainThreadReentryDepth = 256, MaxSecondaryThreadReentryDepth = 32 };
- class Interpreter : public WTF::FastAllocBase {
+ class Interpreter : public FastAllocBase {
friend class JIT;
friend class CachedCall;
public:
diff --git a/src/3rdparty/webkit/JavaScriptCore/interpreter/Register.h b/src/3rdparty/webkit/JavaScriptCore/interpreter/Register.h
index cceac74..31f0c8b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/interpreter/Register.h
+++ b/src/3rdparty/webkit/JavaScriptCore/interpreter/Register.h
@@ -31,6 +31,7 @@
#include "JSValue.h"
#include <wtf/Assertions.h>
+#include <wtf/FastAllocBase.h>
#include <wtf/VectorTraits.h>
namespace JSC {
@@ -47,7 +48,7 @@ namespace JSC {
typedef ExecState CallFrame;
- class Register {
+ class Register : public WTF::FastAllocBase {
public:
Register();
Register(JSValue);
diff --git a/src/3rdparty/webkit/JavaScriptCore/interpreter/RegisterFile.h b/src/3rdparty/webkit/JavaScriptCore/interpreter/RegisterFile.h
index 933efb9..3a6e63b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/interpreter/RegisterFile.h
+++ b/src/3rdparty/webkit/JavaScriptCore/interpreter/RegisterFile.h
@@ -176,23 +176,31 @@ namespace JSC {
#if HAVE(MMAP)
m_buffer = static_cast<Register*>(mmap(0, bufferLength, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, VM_TAG_FOR_REGISTERFILE_MEMORY, 0));
if (m_buffer == MAP_FAILED) {
+#if PLATFORM(WINCE)
+ fprintf(stderr, "Could not allocate register file: %d\n", GetLastError());
+#else
fprintf(stderr, "Could not allocate register file: %d\n", errno);
+#endif
CRASH();
}
#elif HAVE(VIRTUALALLOC)
m_buffer = static_cast<Register*>(VirtualAlloc(0, roundUpAllocationSize(bufferLength, commitSize), MEM_RESERVE, PAGE_READWRITE));
if (!m_buffer) {
- #if !PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
+ fprintf(stderr, "Could not allocate register file: %d\n", GetLastError());
+#else
fprintf(stderr, "Could not allocate register file: %d\n", errno);
- #endif
+#endif
CRASH();
}
size_t committedSize = roundUpAllocationSize(maxGlobals * sizeof(Register), commitSize);
void* commitCheck = VirtualAlloc(m_buffer, committedSize, MEM_COMMIT, PAGE_READWRITE);
if (commitCheck != m_buffer) {
- #if !PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
+ fprintf(stderr, "Could not allocate register file: %d\n", GetLastError());
+#else
fprintf(stderr, "Could not allocate register file: %d\n", errno);
- #endif
+#endif
CRASH();
}
m_commitEnd = reinterpret_cast<Register*>(reinterpret_cast<char*>(m_buffer) + committedSize);
@@ -226,7 +234,9 @@ namespace JSC {
if (newEnd > m_commitEnd) {
size_t size = roundUpAllocationSize(reinterpret_cast<char*>(newEnd) - reinterpret_cast<char*>(m_commitEnd), commitSize);
if (!VirtualAlloc(m_commitEnd, size, MEM_COMMIT, PAGE_READWRITE)) {
-#if !PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
+ fprintf(stderr, "Could not allocate register file: %d\n", GetLastError());
+#else
fprintf(stderr, "Could not allocate register file: %d\n", errno);
#endif
CRASH();
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/ExecutableAllocator.h b/src/3rdparty/webkit/JavaScriptCore/jit/ExecutableAllocator.h
index 18261f8..0de4f79 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/ExecutableAllocator.h
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/ExecutableAllocator.h
@@ -26,12 +26,17 @@
#ifndef ExecutableAllocator_h
#define ExecutableAllocator_h
+#include <limits>
#include <wtf/Assertions.h>
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
+#include <wtf/UnusedParam.h>
#include <wtf/Vector.h>
-#include <limits>
+#if PLATFORM(IPHONE)
+#include <libkern/OSCacheControl.h>
+#include <sys/mman.h>
+#endif
#define JIT_ALLOCATOR_PAGE_SIZE (ExecutableAllocator::pageSize)
#define JIT_ALLOCATOR_LARGE_ALLOC_SIZE (ExecutableAllocator::pageSize * 4)
@@ -151,10 +156,20 @@ public:
return pool.release();
}
-#if ENABLE(ASSEMBLER_WX_EXCLUSIVE)
- static void makeWritable(void* start, size_t size) { reprotectRegion(start, size, Writable); }
- static void makeExecutable(void* start, size_t size) { reprotectRegion(start, size, Executable); }
+#if ENABLE(ASSEMBLER_WX_EXCLUSIVE) || !(PLATFORM(X86) || PLATFORM(X86_64))
+ static void makeWritable(void* start, size_t size)
+ {
+ reprotectRegion(start, size, Writable);
+ }
+
+ static void makeExecutable(void* start, size_t size)
+ {
+ reprotectRegion(start, size, Executable);
+ cacheFlush(start, size);
+ }
+ // If ASSEMBLER_WX_EXCLUSIVE protection is turned on, or on non-x86 platforms,
+ // we need to track start & size so we can makeExecutable/cacheFlush at the end.
class MakeWritable {
public:
MakeWritable(void* start, size_t size)
@@ -176,13 +191,32 @@ public:
#else
static void makeWritable(void*, size_t) {}
static void makeExecutable(void*, size_t) {}
+
+ // On x86, without ASSEMBLER_WX_EXCLUSIVE, there is nothing to do here.
class MakeWritable { public: MakeWritable(void*, size_t) {} };
#endif
private:
+#if ENABLE(ASSEMBLER_WX_EXCLUSIVE) || !(PLATFORM(X86) || PLATFORM(X86_64))
#if ENABLE(ASSEMBLER_WX_EXCLUSIVE)
static void reprotectRegion(void*, size_t, ProtectionSeting);
+#else
+ static void reprotectRegion(void*, size_t, ProtectionSeting) {}
+#endif
+
+ static void cacheFlush(void* code, size_t size)
+ {
+#if PLATFORM(X86) || PLATFORM(X86_64)
+ UNUSED_PARAM(code);
+ UNUSED_PARAM(size);
+#elif PLATFORM_ARM_ARCH(7) && PLATFORM(IPHONE)
+ sys_dcache_flush(code, size);
+ sys_icache_invalidate(code, size);
+#else
+#error "ExecutableAllocator::cacheFlush not implemented on this platform."
+#endif
+ }
#endif
RefPtr<ExecutablePool> m_smallAllocationPool;
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JIT.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JIT.cpp
index 7f2656c..02cb09b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JIT.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JIT.cpp
@@ -1,4 +1,3 @@
-
/*
* Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
*
@@ -46,19 +45,22 @@ using namespace std;
namespace JSC {
-void ctiPatchNearCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, MacroAssemblerCodePtr newCalleeFunction)
+void ctiPatchNearCallByReturnAddress(ReturnAddressPtr returnAddress, MacroAssemblerCodePtr newCalleeFunction)
{
- returnAddress.relinkNearCallerToTrampoline(newCalleeFunction);
+ MacroAssembler::RepatchBuffer repatchBuffer;
+ repatchBuffer.relinkNearCallerToTrampoline(returnAddress, newCalleeFunction);
}
-void ctiPatchCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, MacroAssemblerCodePtr newCalleeFunction)
+void ctiPatchCallByReturnAddress(ReturnAddressPtr returnAddress, MacroAssemblerCodePtr newCalleeFunction)
{
- returnAddress.relinkCallerToTrampoline(newCalleeFunction);
+ MacroAssembler::RepatchBuffer repatchBuffer;
+ repatchBuffer.relinkCallerToTrampoline(returnAddress, newCalleeFunction);
}
-void ctiPatchCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, FunctionPtr newCalleeFunction)
+void ctiPatchCallByReturnAddress(ReturnAddressPtr returnAddress, FunctionPtr newCalleeFunction)
{
- returnAddress.relinkCallerToFunction(newCalleeFunction);
+ MacroAssembler::RepatchBuffer repatchBuffer;
+ repatchBuffer.relinkCallerToFunction(returnAddress, newCalleeFunction);
}
JIT::JIT(JSGlobalData* globalData, CodeBlock* codeBlock)
@@ -68,6 +70,7 @@ JIT::JIT(JSGlobalData* globalData, CodeBlock* codeBlock)
, m_labels(codeBlock ? codeBlock->instructions().size() : 0)
, m_propertyAccessCompilationInfo(codeBlock ? codeBlock->numberOfStructureStubInfos() : 0)
, m_callStructureStubCompilationInfo(codeBlock ? codeBlock->numberOfCallLinkInfos() : 0)
+ , m_bytecodeIndex((unsigned)-1)
, m_lastResultBytecodeRegister(std::numeric_limits<int>::max())
, m_jumpTargetsPosition(0)
{
@@ -403,10 +406,10 @@ void JIT::privateCompile()
// In the case of a fast linked call, we do not set this up in the caller.
emitPutImmediateToCallFrameHeader(m_codeBlock, RegisterFile::CodeBlock);
- peek(regT0, FIELD_OFFSET(JITStackFrame, registerFile) / sizeof (void*));
+ peek(regT0, OBJECT_OFFSETOF(JITStackFrame, registerFile) / sizeof (void*));
addPtr(Imm32(m_codeBlock->m_numCalleeRegisters * sizeof(Register)), callFrameRegister, regT1);
- slowRegisterFileCheck = branchPtr(Above, regT1, Address(regT0, FIELD_OFFSET(RegisterFile, m_end)));
+ slowRegisterFileCheck = branchPtr(Above, regT1, Address(regT0, OBJECT_OFFSETOF(RegisterFile, m_end)));
afterRegisterFileCheck = label();
}
@@ -426,7 +429,7 @@ void JIT::privateCompile()
ASSERT(m_jmpTable.isEmpty());
- PatchBuffer patchBuffer(this, m_globalData->executableAllocator.poolForSize(m_assembler.size()));
+ LinkBuffer patchBuffer(this, m_globalData->executableAllocator.poolForSize(m_assembler.size()));
// Translate vPC offsets into addresses in JIT generated code, for switch tables.
for (unsigned i = 0; i < m_switches.size(); ++i) {
@@ -474,7 +477,7 @@ void JIT::privateCompile()
// Link absolute addresses for jsr
for (Vector<JSRInfo>::iterator iter = m_jsrSites.begin(); iter != m_jsrSites.end(); ++iter)
- patchBuffer.patch(iter->storeLocation, patchBuffer.locationOf(iter->target).addressForJSR());
+ patchBuffer.patch(iter->storeLocation, patchBuffer.locationOf(iter->target).executableAddress());
#if ENABLE(JIT_OPTIMIZE_PROPERTY_ACCESS)
for (unsigned i = 0; i < m_codeBlock->numberOfStructureStubInfos(); ++i) {
@@ -489,7 +492,6 @@ void JIT::privateCompile()
info.callReturnLocation = patchBuffer.locationOfNearCall(m_callStructureStubCompilationInfo[i].callReturnLocation);
info.hotPathBegin = patchBuffer.locationOf(m_callStructureStubCompilationInfo[i].hotPathBegin);
info.hotPathOther = patchBuffer.locationOfNearCall(m_callStructureStubCompilationInfo[i].hotPathOther);
- info.coldPathOther = patchBuffer.locationOf(m_callStructureStubCompilationInfo[i].coldPathOther);
}
#endif
unsigned methodCallCount = m_methodCallCompilationInfo.size();
@@ -514,8 +516,8 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
Jump array_failureCases2 = branchPtr(NotEqual, Address(regT0), ImmPtr(m_globalData->jsArrayVPtr));
// Checks out okay! - get the length from the storage
- loadPtr(Address(regT0, FIELD_OFFSET(JSArray, m_storage)), regT0);
- load32(Address(regT0, FIELD_OFFSET(ArrayStorage, m_length)), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSArray, m_storage)), regT0);
+ load32(Address(regT0, OBJECT_OFFSETOF(ArrayStorage, m_length)), regT0);
Jump array_failureCases3 = branch32(Above, regT0, Imm32(JSImmediate::maxImmediateInt));
@@ -532,8 +534,8 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
Jump string_failureCases2 = branchPtr(NotEqual, Address(regT0), ImmPtr(m_globalData->jsStringVPtr));
// Checks out okay! - get the length from the Ustring.
- loadPtr(Address(regT0, FIELD_OFFSET(JSString, m_value) + FIELD_OFFSET(UString, m_rep)), regT0);
- load32(Address(regT0, FIELD_OFFSET(UString::Rep, len)), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSString, m_value) + OBJECT_OFFSETOF(UString, m_rep)), regT0);
+ load32(Address(regT0, OBJECT_OFFSETOF(UString::Rep, len)), regT0);
Jump string_failureCases3 = branch32(Above, regT0, Imm32(JSImmediate::maxImmediateInt));
@@ -544,16 +546,14 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
#endif
// (3) Trampolines for the slow cases of op_call / op_call_eval / op_construct.
-
+ COMPILE_ASSERT(sizeof(CodeType) == 4, CodeTypeEnumMustBe32Bit);
+
Label virtualCallPreLinkBegin = align();
// Load the callee CodeBlock* into eax
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_body)), regT3);
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_code)), regT0);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_body)), regT3);
+ loadPtr(Address(regT3, OBJECT_OFFSETOF(FunctionBodyNode, m_code)), regT0);
Jump hasCodeBlock1 = branchTestPtr(NonZero, regT0);
- // If m_code is null and m_jitCode is not, then we have a native function, so arity is irrelevant
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_jitCode)), regT0);
- Jump isNativeFunc1 = branchTestPtr(NonZero, regT0);
preverveReturnAddressAfterCall(regT3);
restoreArgumentReference();
Call callJSFunction1 = call();
@@ -562,8 +562,10 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
restoreReturnAddressBeforeReturn(regT3);
hasCodeBlock1.link(this);
+ Jump isNativeFunc1 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_codeType)), Imm32(NativeCode));
+
// Check argCount matches callee arity.
- Jump arityCheckOkay1 = branch32(Equal, Address(regT0, FIELD_OFFSET(CodeBlock, m_numParameters)), regT1);
+ Jump arityCheckOkay1 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_numParameters)), regT1);
preverveReturnAddressAfterCall(regT3);
emitPutJITStubArg(regT3, 2);
emitPutJITStubArg(regT0, 4);
@@ -590,12 +592,9 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
Label virtualCallLinkBegin = align();
// Load the callee CodeBlock* into eax
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_body)), regT3);
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_code)), regT0);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_body)), regT3);
+ loadPtr(Address(regT3, OBJECT_OFFSETOF(FunctionBodyNode, m_code)), regT0);
Jump hasCodeBlock2 = branchTestPtr(NonZero, regT0);
- // If m_code is null and m_jitCode is not, then we have a native function, so arity is irrelevant
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_jitCode)), regT0);
- Jump isNativeFunc2 = branchTestPtr(NonZero, regT0);
preverveReturnAddressAfterCall(regT3);
restoreArgumentReference();
Call callJSFunction2 = call();
@@ -604,8 +603,10 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
restoreReturnAddressBeforeReturn(regT3);
hasCodeBlock2.link(this);
+ Jump isNativeFunc2 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_codeType)), Imm32(NativeCode));
+
// Check argCount matches callee arity.
- Jump arityCheckOkay2 = branch32(Equal, Address(regT0, FIELD_OFFSET(CodeBlock, m_numParameters)), regT1);
+ Jump arityCheckOkay2 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_numParameters)), regT1);
preverveReturnAddressAfterCall(regT3);
emitPutJITStubArg(regT3, 2);
emitPutJITStubArg(regT0, 4);
@@ -631,23 +632,22 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
Label virtualCallBegin = align();
// Load the callee CodeBlock* into eax
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_body)), regT3);
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_code)), regT0);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_body)), regT3);
+ loadPtr(Address(regT3, OBJECT_OFFSETOF(FunctionBodyNode, m_code)), regT0);
Jump hasCodeBlock3 = branchTestPtr(NonZero, regT0);
- // If m_code is null and m_jitCode is not, then we have a native function, so arity is irrelevant
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_jitCode)), regT0);
- Jump isNativeFunc3 = branchTestPtr(NonZero, regT0);
preverveReturnAddressAfterCall(regT3);
restoreArgumentReference();
Call callJSFunction3 = call();
emitGetJITStubArg(1, regT2);
emitGetJITStubArg(3, regT1);
restoreReturnAddressBeforeReturn(regT3);
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_body)), regT3); // reload the function body nody, so we can reload the code pointer.
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_body)), regT3); // reload the function body nody, so we can reload the code pointer.
hasCodeBlock3.link(this);
+
+ Jump isNativeFunc3 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_codeType)), Imm32(NativeCode));
// Check argCount matches callee arity.
- Jump arityCheckOkay3 = branch32(Equal, Address(regT0, FIELD_OFFSET(CodeBlock, m_numParameters)), regT1);
+ Jump arityCheckOkay3 = branch32(Equal, Address(regT0, OBJECT_OFFSETOF(CodeBlock, m_numParameters)), regT1);
preverveReturnAddressAfterCall(regT3);
emitPutJITStubArg(regT3, 2);
emitPutJITStubArg(regT0, 4);
@@ -657,12 +657,13 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
emitGetJITStubArg(1, regT2);
emitGetJITStubArg(3, regT1);
restoreReturnAddressBeforeReturn(regT3);
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_body)), regT3); // reload the function body nody, so we can reload the code pointer.
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_body)), regT3); // reload the function body nody, so we can reload the code pointer.
arityCheckOkay3.link(this);
- // load ctiCode from the new codeBlock.
- loadPtr(Address(regT3, FIELD_OFFSET(FunctionBodyNode, m_jitCode)), regT0);
isNativeFunc3.link(this);
+ // load ctiCode from the new codeBlock.
+ loadPtr(Address(regT3, OBJECT_OFFSETOF(FunctionBodyNode, m_jitCode)), regT0);
+
compileOpCallInitializeCallFrame();
jump(regT0);
@@ -689,7 +690,7 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
subPtr(Imm32(1), X86::ecx); // Don't include 'this' in argcount
// Push argcount
- storePtr(X86::ecx, Address(stackPointerRegister, FIELD_OFFSET(ArgList, m_argCount)));
+ storePtr(X86::ecx, Address(stackPointerRegister, OBJECT_OFFSETOF(ArgList, m_argCount)));
// Calculate the start of the callframe header, and store in edx
addPtr(Imm32(-RegisterFile::CallFrameHeaderSize * (int32_t)sizeof(Register)), callFrameRegister, X86::edx);
@@ -699,7 +700,7 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
subPtr(X86::ecx, X86::edx);
// push pointer to arguments
- storePtr(X86::edx, Address(stackPointerRegister, FIELD_OFFSET(ArgList, m_args)));
+ storePtr(X86::edx, Address(stackPointerRegister, OBJECT_OFFSETOF(ArgList, m_args)));
// ArgList is passed by reference so is stackPointerRegister
move(stackPointerRegister, X86::ecx);
@@ -711,10 +712,10 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
move(callFrameRegister, X86::edi);
- call(Address(X86::esi, FIELD_OFFSET(JSFunction, m_data)));
+ call(Address(X86::esi, OBJECT_OFFSETOF(JSFunction, m_data)));
addPtr(Imm32(sizeof(ArgList)), stackPointerRegister);
-#else
+#elif PLATFORM(X86)
emitGetFromCallFrameHeader32(RegisterFile::ArgumentCount, regT0);
/* We have two structs that we use to describe the stackframe we set up for our
@@ -760,7 +761,7 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
subPtr(Imm32(1), regT0); // Don't include 'this' in argcount
// push argcount
- storePtr(regT0, Address(stackPointerRegister, FIELD_OFFSET(NativeCallFrameStructure, args) + FIELD_OFFSET(ArgList, m_argCount)));
+ storePtr(regT0, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, args) + OBJECT_OFFSETOF(ArgList, m_argCount)));
// Calculate the start of the callframe header, and store in regT1
addPtr(Imm32(-RegisterFile::CallFrameHeaderSize * (int)sizeof(Register)), callFrameRegister, regT1);
@@ -768,28 +769,28 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
// Calculate start of arguments as callframe header - sizeof(Register) * argcount (regT0)
mul32(Imm32(sizeof(Register)), regT0, regT0);
subPtr(regT0, regT1);
- storePtr(regT1, Address(stackPointerRegister, FIELD_OFFSET(NativeCallFrameStructure, args) + FIELD_OFFSET(ArgList, m_args)));
+ storePtr(regT1, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, args) + OBJECT_OFFSETOF(ArgList, m_args)));
// ArgList is passed by reference so is stackPointerRegister + 4 * sizeof(Register)
- addPtr(Imm32(FIELD_OFFSET(NativeCallFrameStructure, args)), stackPointerRegister, regT0);
- storePtr(regT0, Address(stackPointerRegister, FIELD_OFFSET(NativeCallFrameStructure, argPointer)));
+ addPtr(Imm32(OBJECT_OFFSETOF(NativeCallFrameStructure, args)), stackPointerRegister, regT0);
+ storePtr(regT0, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, argPointer)));
// regT1 currently points to the first argument, regT1 - sizeof(Register) points to 'this'
loadPtr(Address(regT1, -(int)sizeof(Register)), regT1);
- storePtr(regT1, Address(stackPointerRegister, FIELD_OFFSET(NativeCallFrameStructure, thisValue)));
+ storePtr(regT1, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, thisValue)));
#if COMPILER(MSVC) || PLATFORM(LINUX)
// ArgList is passed by reference so is stackPointerRegister + 4 * sizeof(Register)
- addPtr(Imm32(FIELD_OFFSET(NativeCallFrameStructure, result)), stackPointerRegister, X86::ecx);
+ addPtr(Imm32(OBJECT_OFFSETOF(NativeCallFrameStructure, result)), stackPointerRegister, X86::ecx);
// Plant callee
emitGetFromCallFrameHeaderPtr(RegisterFile::Callee, X86::eax);
- storePtr(X86::eax, Address(stackPointerRegister, FIELD_OFFSET(NativeCallFrameStructure, callee)));
+ storePtr(X86::eax, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, callee)));
// Plant callframe
move(callFrameRegister, X86::edx);
- call(Address(X86::eax, FIELD_OFFSET(JSFunction, m_data)));
+ call(Address(X86::eax, OBJECT_OFFSETOF(JSFunction, m_data)));
// JSValue is a non-POD type
loadPtr(Address(X86::eax), X86::eax);
@@ -799,13 +800,17 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
// Plant callframe
move(callFrameRegister, X86::ecx);
- call(Address(X86::edx, FIELD_OFFSET(JSFunction, m_data)));
+ call(Address(X86::edx, OBJECT_OFFSETOF(JSFunction, m_data)));
#endif
// We've put a few temporaries on the stack in addition to the actual arguments
// so pull them off now
addPtr(Imm32(NativeCallFrameSize - sizeof(NativeFunctionCalleeSignature)), stackPointerRegister);
+#elif ENABLE(JIT_OPTIMIZE_NATIVE_CALL)
+#error "JIT_OPTIMIZE_NATIVE_CALL not yet supported on this platform."
+#else
+ breakpoint();
#endif
// Check for an exception
@@ -830,7 +835,7 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
storePtr(regT1, regT2);
move(ImmPtr(reinterpret_cast<void*>(ctiVMThrowTrampoline)), regT2);
emitGetFromCallFrameHeaderPtr(RegisterFile::CallerFrame, callFrameRegister);
- poke(callFrameRegister, offsetof(struct JITStackFrame, callFrame) / sizeof (void*));
+ poke(callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*));
restoreReturnAddressBeforeReturn(regT2);
ret();
@@ -845,7 +850,7 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
#endif
// All trampolines constructed! copy the code, link up calls, and set the pointers on the Machine object.
- PatchBuffer patchBuffer(this, m_globalData->executableAllocator.poolForSize(m_assembler.size()));
+ LinkBuffer patchBuffer(this, m_globalData->executableAllocator.poolForSize(m_assembler.size()));
#if ENABLE(JIT_OPTIMIZE_PROPERTY_ACCESS)
patchBuffer.link(array_failureCases1Call, FunctionPtr(JITStubs::cti_op_get_by_id_array_fail));
@@ -882,15 +887,15 @@ void JIT::privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executable
void JIT::emitGetVariableObjectRegister(RegisterID variableObject, int index, RegisterID dst)
{
- loadPtr(Address(variableObject, FIELD_OFFSET(JSVariableObject, d)), dst);
- loadPtr(Address(dst, FIELD_OFFSET(JSVariableObject::JSVariableObjectData, registers)), dst);
+ loadPtr(Address(variableObject, OBJECT_OFFSETOF(JSVariableObject, d)), dst);
+ loadPtr(Address(dst, OBJECT_OFFSETOF(JSVariableObject::JSVariableObjectData, registers)), dst);
loadPtr(Address(dst, index * sizeof(Register)), dst);
}
void JIT::emitPutVariableObjectRegister(RegisterID src, RegisterID variableObject, int index)
{
- loadPtr(Address(variableObject, FIELD_OFFSET(JSVariableObject, d)), variableObject);
- loadPtr(Address(variableObject, FIELD_OFFSET(JSVariableObject::JSVariableObjectData, registers)), variableObject);
+ loadPtr(Address(variableObject, OBJECT_OFFSETOF(JSVariableObject, d)), variableObject);
+ loadPtr(Address(variableObject, OBJECT_OFFSETOF(JSVariableObject::JSVariableObjectData, registers)), variableObject);
storePtr(src, Address(variableObject, index * sizeof(Register)));
}
@@ -899,25 +904,29 @@ void JIT::unlinkCall(CallLinkInfo* callLinkInfo)
// When the JSFunction is deleted the pointer embedded in the instruction stream will no longer be valid
// (and, if a new JSFunction happened to be constructed at the same location, we could get a false positive
// match). Reset the check so it no longer matches.
- callLinkInfo->hotPathBegin.repatch(JSValue::encode(JSValue()));
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.repatch(callLinkInfo->hotPathBegin, JSValue::encode(JSValue()));
}
-void JIT::linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode& code, CallLinkInfo* callLinkInfo, int callerArgCount)
+void JIT::linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode& code, CallLinkInfo* callLinkInfo, int callerArgCount, JSGlobalData* globalData)
{
+ ASSERT(calleeCodeBlock);
+ RepatchBuffer repatchBuffer;
+
// Currently we only link calls with the exact number of arguments.
// If this is a native call calleeCodeBlock is null so the number of parameters is unimportant
- if (!calleeCodeBlock || callerArgCount == calleeCodeBlock->m_numParameters) {
+ if (callerArgCount == calleeCodeBlock->m_numParameters || calleeCodeBlock->codeType() == NativeCode) {
ASSERT(!callLinkInfo->isLinked());
if (calleeCodeBlock)
calleeCodeBlock->addCaller(callLinkInfo);
- callLinkInfo->hotPathBegin.repatch(callee);
- callLinkInfo->hotPathOther.relink(code.addressForCall());
+ repatchBuffer.repatch(callLinkInfo->hotPathBegin, callee);
+ repatchBuffer.relink(callLinkInfo->hotPathOther, code.addressForCall());
}
- // patch the instruction that jumps out to the cold path, so that we only try to link once.
- callLinkInfo->hotPathBegin.jumpAtOffset(patchOffsetOpCallCompareToJump).relink(callLinkInfo->coldPathOther);
+ // patch the call so we do not continue to try to link.
+ repatchBuffer.relink(callLinkInfo->callReturnLocation, globalData->jitStubs.ctiVirtualCall());
}
} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JIT.h b/src/3rdparty/webkit/JavaScriptCore/jit/JIT.h
index c9e5355..db3f38a 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JIT.h
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JIT.h
@@ -28,6 +28,11 @@
#include <wtf/Platform.h>
+// OBJECT_OFFSETOF: Like the C++ offsetof macro, but you can use it with classes.
+// The magic number 0x4000 is insignificant. We use it to avoid using NULL, since
+// NULL can cause compiler problems, especially in cases of multiple inheritance.
+#define OBJECT_OFFSETOF(class, field) (reinterpret_cast<ptrdiff_t>(&(reinterpret_cast<class*>(0x4000)->field)) - 0x4000)
+
#if ENABLE(JIT)
// We've run into some problems where changing the size of the class JIT leads to
@@ -153,7 +158,6 @@ namespace JSC {
MacroAssembler::DataLabelPtr hotPathBegin;
MacroAssembler::Call hotPathOther;
MacroAssembler::Call callReturnLocation;
- MacroAssembler::Label coldPathOther;
};
struct MethodCallCompilationInfo {
@@ -167,9 +171,9 @@ namespace JSC {
};
// Near calls can only be patched to other JIT code, regular calls can be patched to JIT code or relinked to stub functions.
- void ctiPatchNearCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, MacroAssemblerCodePtr newCalleeFunction);
- void ctiPatchCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, MacroAssemblerCodePtr newCalleeFunction);
- void ctiPatchCallByReturnAddress(MacroAssembler::ProcessorReturnAddress returnAddress, FunctionPtr newCalleeFunction);
+ void ctiPatchNearCallByReturnAddress(ReturnAddressPtr returnAddress, MacroAssemblerCodePtr newCalleeFunction);
+ void ctiPatchCallByReturnAddress(ReturnAddressPtr returnAddress, MacroAssemblerCodePtr newCalleeFunction);
+ void ctiPatchCallByReturnAddress(ReturnAddressPtr returnAddress, FunctionPtr newCalleeFunction);
class JIT : private MacroAssembler {
friend class JITStubCall;
@@ -228,6 +232,22 @@ namespace JSC {
static const FPRegisterID fpRegT0 = X86::xmm0;
static const FPRegisterID fpRegT1 = X86::xmm1;
static const FPRegisterID fpRegT2 = X86::xmm2;
+#elif PLATFORM_ARM_ARCH(7)
+ static const RegisterID returnValueRegister = ARM::r0;
+ static const RegisterID cachedResultRegister = ARM::r0;
+ static const RegisterID firstArgumentRegister = ARM::r0;
+
+ static const RegisterID regT0 = ARM::r0;
+ static const RegisterID regT1 = ARM::r1;
+ static const RegisterID regT2 = ARM::r2;
+ static const RegisterID regT3 = ARM::r4;
+
+ static const RegisterID callFrameRegister = ARM::r5;
+ static const RegisterID timeoutCheckRegister = ARM::r6;
+
+ static const FPRegisterID fpRegT0 = ARM::d0;
+ static const FPRegisterID fpRegT1 = ARM::d1;
+ static const FPRegisterID fpRegT2 = ARM::d2;
#else
#error "JIT not supported on this platform."
#endif
@@ -260,7 +280,7 @@ namespace JSC {
static const int patchOffsetMethodCheckProtoObj = 20;
static const int patchOffsetMethodCheckProtoStruct = 30;
static const int patchOffsetMethodCheckPutFunction = 50;
-#else
+#elif PLATFORM(X86)
// These architecture specific value are used to enable patching - see comment on op_put_by_id.
static const int patchOffsetPutByIdStructure = 7;
static const int patchOffsetPutByIdExternalLoad = 13;
@@ -287,6 +307,29 @@ namespace JSC {
static const int patchOffsetMethodCheckProtoObj = 11;
static const int patchOffsetMethodCheckProtoStruct = 18;
static const int patchOffsetMethodCheckPutFunction = 29;
+#elif PLATFORM_ARM_ARCH(7)
+ // These architecture specific value are used to enable patching - see comment on op_put_by_id.
+ static const int patchOffsetPutByIdStructure = 10;
+ static const int patchOffsetPutByIdExternalLoad = 20;
+ static const int patchLengthPutByIdExternalLoad = 12;
+ static const int patchOffsetPutByIdPropertyMapOffset = 40;
+ // These architecture specific value are used to enable patching - see comment on op_get_by_id.
+ static const int patchOffsetGetByIdStructure = 10;
+ static const int patchOffsetGetByIdBranchToSlowCase = 20;
+ static const int patchOffsetGetByIdExternalLoad = 20;
+ static const int patchLengthGetByIdExternalLoad = 12;
+ static const int patchOffsetGetByIdPropertyMapOffset = 40;
+ static const int patchOffsetGetByIdPutResult = 44;
+#if ENABLE(OPCODE_SAMPLING)
+ static const int patchOffsetGetByIdSlowCaseCall = 0; // FIMXE
+#else
+ static const int patchOffsetGetByIdSlowCaseCall = 28;
+#endif
+ static const int patchOffsetOpCallCompareToJump = 10;
+
+ static const int patchOffsetMethodCheckProtoObj = 18;
+ static const int patchOffsetMethodCheckProtoStruct = 28;
+ static const int patchOffsetMethodCheckPutFunction = 46;
#endif
public:
@@ -296,7 +339,7 @@ namespace JSC {
jit.privateCompile();
}
- static void compileGetByIdProto(JSGlobalData* globalData, CallFrame* callFrame, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* structure, Structure* prototypeStructure, size_t cachedOffset, ProcessorReturnAddress returnAddress)
+ static void compileGetByIdProto(JSGlobalData* globalData, CallFrame* callFrame, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* structure, Structure* prototypeStructure, size_t cachedOffset, ReturnAddressPtr returnAddress)
{
JIT jit(globalData, codeBlock);
jit.privateCompileGetByIdProto(stubInfo, structure, prototypeStructure, cachedOffset, returnAddress, callFrame);
@@ -318,13 +361,13 @@ namespace JSC {
jit.privateCompileGetByIdChainList(stubInfo, prototypeStructureList, currentIndex, structure, chain, count, cachedOffset, callFrame);
}
- static void compileGetByIdChain(JSGlobalData* globalData, CallFrame* callFrame, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* structure, StructureChain* chain, size_t count, size_t cachedOffset, ProcessorReturnAddress returnAddress)
+ static void compileGetByIdChain(JSGlobalData* globalData, CallFrame* callFrame, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* structure, StructureChain* chain, size_t count, size_t cachedOffset, ReturnAddressPtr returnAddress)
{
JIT jit(globalData, codeBlock);
jit.privateCompileGetByIdChain(stubInfo, structure, chain, count, cachedOffset, returnAddress, callFrame);
}
- static void compilePutByIdTransition(JSGlobalData* globalData, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* oldStructure, Structure* newStructure, size_t cachedOffset, StructureChain* chain, ProcessorReturnAddress returnAddress)
+ static void compilePutByIdTransition(JSGlobalData* globalData, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* oldStructure, Structure* newStructure, size_t cachedOffset, StructureChain* chain, ReturnAddressPtr returnAddress)
{
JIT jit(globalData, codeBlock);
jit.privateCompilePutByIdTransition(stubInfo, oldStructure, newStructure, cachedOffset, chain, returnAddress);
@@ -336,17 +379,17 @@ namespace JSC {
jit.privateCompileCTIMachineTrampolines(executablePool, globalData, ctiArrayLengthTrampoline, ctiStringLengthTrampoline, ctiVirtualCallPreLink, ctiVirtualCallLink, ctiVirtualCall, ctiNativeCallThunk);
}
- static void patchGetByIdSelf(StructureStubInfo*, Structure*, size_t cachedOffset, ProcessorReturnAddress returnAddress);
- static void patchPutByIdReplace(StructureStubInfo*, Structure*, size_t cachedOffset, ProcessorReturnAddress returnAddress);
+ static void patchGetByIdSelf(StructureStubInfo*, Structure*, size_t cachedOffset, ReturnAddressPtr returnAddress);
+ static void patchPutByIdReplace(StructureStubInfo*, Structure*, size_t cachedOffset, ReturnAddressPtr returnAddress);
static void patchMethodCallProto(MethodCallLinkInfo&, JSFunction*, Structure*, JSObject*);
- static void compilePatchGetArrayLength(JSGlobalData* globalData, CodeBlock* codeBlock, ProcessorReturnAddress returnAddress)
+ static void compilePatchGetArrayLength(JSGlobalData* globalData, CodeBlock* codeBlock, ReturnAddressPtr returnAddress)
{
JIT jit(globalData, codeBlock);
return jit.privateCompilePatchGetArrayLength(returnAddress);
}
- static void linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode&, CallLinkInfo*, int callerArgCount);
+ static void linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode&, CallLinkInfo*, int callerArgCount, JSGlobalData*);
static void unlinkCall(CallLinkInfo*);
private:
@@ -367,15 +410,15 @@ namespace JSC {
void privateCompileLinkPass();
void privateCompileSlowCases();
void privateCompile();
- void privateCompileGetByIdProto(StructureStubInfo*, Structure*, Structure* prototypeStructure, size_t cachedOffset, ProcessorReturnAddress returnAddress, CallFrame* callFrame);
+ void privateCompileGetByIdProto(StructureStubInfo*, Structure*, Structure* prototypeStructure, size_t cachedOffset, ReturnAddressPtr returnAddress, CallFrame* callFrame);
void privateCompileGetByIdSelfList(StructureStubInfo*, PolymorphicAccessStructureList*, int, Structure*, size_t cachedOffset);
void privateCompileGetByIdProtoList(StructureStubInfo*, PolymorphicAccessStructureList*, int, Structure*, Structure* prototypeStructure, size_t cachedOffset, CallFrame* callFrame);
void privateCompileGetByIdChainList(StructureStubInfo*, PolymorphicAccessStructureList*, int, Structure*, StructureChain* chain, size_t count, size_t cachedOffset, CallFrame* callFrame);
- void privateCompileGetByIdChain(StructureStubInfo*, Structure*, StructureChain*, size_t count, size_t cachedOffset, ProcessorReturnAddress returnAddress, CallFrame* callFrame);
- void privateCompilePutByIdTransition(StructureStubInfo*, Structure*, Structure*, size_t cachedOffset, StructureChain*, ProcessorReturnAddress returnAddress);
+ void privateCompileGetByIdChain(StructureStubInfo*, Structure*, StructureChain*, size_t count, size_t cachedOffset, ReturnAddressPtr returnAddress, CallFrame* callFrame);
+ void privateCompilePutByIdTransition(StructureStubInfo*, Structure*, Structure*, size_t cachedOffset, StructureChain*, ReturnAddressPtr returnAddress);
void privateCompileCTIMachineTrampolines(RefPtr<ExecutablePool>* executablePool, JSGlobalData* data, CodePtr* ctiArrayLengthTrampoline, CodePtr* ctiStringLengthTrampoline, CodePtr* ctiVirtualCallPreLink, CodePtr* ctiVirtualCallLink, CodePtr* ctiVirtualCall, CodePtr* ctiNativeCallThunk);
- void privateCompilePatchGetArrayLength(ProcessorReturnAddress returnAddress);
+ void privateCompilePatchGetArrayLength(ReturnAddressPtr returnAddress);
void addSlowCase(Jump);
void addJump(Jump, int);
@@ -397,7 +440,7 @@ namespace JSC {
void compileOpStrictEq(Instruction* instruction, CompileOpStrictEqType type);
void compileGetDirectOffset(RegisterID base, RegisterID result, Structure* structure, size_t cachedOffset);
- void compileGetDirectOffset(JSObject* base, RegisterID result, size_t cachedOffset);
+ void compileGetDirectOffset(JSObject* base, RegisterID temp, RegisterID result, size_t cachedOffset);
void compilePutDirectOffset(RegisterID base, RegisterID value, Structure* structure, size_t cachedOffset);
// Arithmetic Ops
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITArithmetic.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JITArithmetic.cpp
index 2ceb935..15808e2 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITArithmetic.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITArithmetic.cpp
@@ -116,18 +116,19 @@ void JIT::emit_op_rshift(Instruction* currentInstruction)
#endif
} else {
emitGetVirtualRegisters(op1, regT0, op2, regT2);
- if (supportsFloatingPoint()) {
+ if (supportsFloatingPointTruncate()) {
Jump lhsIsInt = emitJumpIfImmediateInteger(regT0);
#if USE(ALTERNATE_JSIMMEDIATE)
// supportsFloatingPoint() && USE(ALTERNATE_JSIMMEDIATE) => 3 SlowCases
addSlowCase(emitJumpIfNotImmediateNumber(regT0));
+ addPtr(tagTypeNumberRegister, regT0);
movePtrToDouble(regT0, fpRegT0);
addSlowCase(branchTruncateDoubleToInt32(fpRegT0, regT0));
#else
// supportsFloatingPoint() && !USE(ALTERNATE_JSIMMEDIATE) => 5 SlowCases (of which 1 IfNotJSCell)
emitJumpSlowCaseIfNotJSCell(regT0, op1);
addSlowCase(checkStructure(regT0, m_globalData->numberStructure.get()));
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
addSlowCase(branchTruncateDoubleToInt32(fpRegT0, regT0));
addSlowCase(branchAdd32(Overflow, regT0, regT0));
#endif
@@ -171,7 +172,7 @@ void JIT::emitSlow_op_rshift(Instruction* currentInstruction, Vector<SlowCaseEnt
stubCall.addArgument(regT0);
stubCall.addArgument(op2, regT2);
} else {
- if (supportsFloatingPoint()) {
+ if (supportsFloatingPointTruncate()) {
#if USE(ALTERNATE_JSIMMEDIATE)
linkSlowCase(iter);
linkSlowCase(iter);
@@ -262,7 +263,7 @@ void JIT::emitSlow_op_jnless(Instruction* currentInstruction, Vector<SlowCaseEnt
fail1 = emitJumpIfNotJSCell(regT0);
Jump fail2 = checkStructure(regT0, m_globalData->numberStructure.get());
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
#endif
int32_t op2imm = getConstantOperand(op2).getInt32Fast();;
@@ -303,7 +304,7 @@ void JIT::emitSlow_op_jnless(Instruction* currentInstruction, Vector<SlowCaseEnt
fail1 = emitJumpIfNotJSCell(regT1);
Jump fail2 = checkStructure(regT1, m_globalData->numberStructure.get());
- loadDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT1);
+ loadDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT1);
#endif
int32_t op1imm = getConstantOperand(op1).getInt32Fast();;
@@ -353,8 +354,8 @@ void JIT::emitSlow_op_jnless(Instruction* currentInstruction, Vector<SlowCaseEnt
Jump fail3 = checkStructure(regT0, m_globalData->numberStructure.get());
Jump fail4 = checkStructure(regT1, m_globalData->numberStructure.get());
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
- loadDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT1);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT1);
#endif
emitJumpSlowToHot(branchDouble(DoubleLessThanOrEqual, fpRegT1, fpRegT0), target + 3);
@@ -447,7 +448,7 @@ void JIT::emitSlow_op_jnlesseq(Instruction* currentInstruction, Vector<SlowCaseE
fail1 = emitJumpIfNotJSCell(regT0);
Jump fail2 = checkStructure(regT0, m_globalData->numberStructure.get());
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
#endif
int32_t op2imm = getConstantOperand(op2).getInt32Fast();;
@@ -488,7 +489,7 @@ void JIT::emitSlow_op_jnlesseq(Instruction* currentInstruction, Vector<SlowCaseE
fail1 = emitJumpIfNotJSCell(regT1);
Jump fail2 = checkStructure(regT1, m_globalData->numberStructure.get());
- loadDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT1);
+ loadDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT1);
#endif
int32_t op1imm = getConstantOperand(op1).getInt32Fast();;
@@ -538,8 +539,8 @@ void JIT::emitSlow_op_jnlesseq(Instruction* currentInstruction, Vector<SlowCaseE
Jump fail3 = checkStructure(regT0, m_globalData->numberStructure.get());
Jump fail4 = checkStructure(regT1, m_globalData->numberStructure.get());
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
- loadDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT1);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT1);
#endif
emitJumpSlowToHot(branchDouble(DoubleLessThan, fpRegT1, fpRegT0), target + 3);
@@ -1105,7 +1106,7 @@ void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, u
}
// (1a) if we get here, src1 is also a number cell
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
Jump loadedDouble = jump();
// (1b) if we get here, src1 is an immediate
op1imm.link(this);
@@ -1114,16 +1115,16 @@ void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, u
// (1c)
loadedDouble.link(this);
if (opcodeID == op_add)
- addDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ addDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
else if (opcodeID == op_sub)
- subDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ subDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
else {
ASSERT(opcodeID == op_mul);
- mulDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ mulDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
}
// Store the result to the JSNumberCell and jump.
- storeDouble(fpRegT0, Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)));
+ storeDouble(fpRegT0, Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)));
move(regT1, regT0);
emitPutVirtualRegister(dst);
wasJSNumberCell2 = jump();
@@ -1151,7 +1152,7 @@ void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, u
}
// (1a) if we get here, src2 is also a number cell
- loadDouble(Address(regT1, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT1);
+ loadDouble(Address(regT1, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT1);
Jump loadedDouble = jump();
// (1b) if we get here, src2 is an immediate
op2imm.link(this);
@@ -1159,7 +1160,7 @@ void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, u
convertInt32ToDouble(regT1, fpRegT1);
// (1c)
loadedDouble.link(this);
- loadDouble(Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)), fpRegT0);
+ loadDouble(Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)), fpRegT0);
if (opcodeID == op_add)
addDouble(fpRegT1, fpRegT0);
else if (opcodeID == op_sub)
@@ -1168,11 +1169,11 @@ void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, u
ASSERT(opcodeID == op_mul);
mulDouble(fpRegT1, fpRegT0);
}
- storeDouble(fpRegT0, Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)));
+ storeDouble(fpRegT0, Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)));
emitPutVirtualRegister(dst);
// Store the result to the JSNumberCell and jump.
- storeDouble(fpRegT0, Address(regT0, FIELD_OFFSET(JSNumberCell, m_value)));
+ storeDouble(fpRegT0, Address(regT0, OBJECT_OFFSETOF(JSNumberCell, m_value)));
emitPutVirtualRegister(dst);
wasJSNumberCell1 = jump();
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITCall.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JITCall.cpp
index cf852be..abdb5ed 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITCall.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITCall.cpp
@@ -49,7 +49,7 @@ void JIT::compileOpCallInitializeCallFrame()
{
store32(regT1, Address(callFrameRegister, RegisterFile::ArgumentCount * static_cast<int>(sizeof(Register))));
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_data) + FIELD_OFFSET(ScopeChain, m_node)), regT1); // newScopeChain
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_data) + OBJECT_OFFSETOF(ScopeChain, m_node)), regT1); // newScopeChain
storePtr(ImmPtr(JSValue::encode(JSValue())), Address(callFrameRegister, RegisterFile::OptionalCalleeArguments * static_cast<int>(sizeof(Register))));
storePtr(regT2, Address(callFrameRegister, RegisterFile::Callee * static_cast<int>(sizeof(Register))));
@@ -242,7 +242,7 @@ void JIT::compileOpCall(OpcodeID opcodeID, Instruction* instruction, unsigned ca
// Note that this omits to set up RegisterFile::CodeBlock, which is set in the callee
storePtr(ImmPtr(JSValue::encode(JSValue())), Address(callFrameRegister, (registerOffset + RegisterFile::OptionalCalleeArguments) * static_cast<int>(sizeof(Register))));
storePtr(regT2, Address(callFrameRegister, (registerOffset + RegisterFile::Callee) * static_cast<int>(sizeof(Register))));
- loadPtr(Address(regT2, FIELD_OFFSET(JSFunction, m_data) + FIELD_OFFSET(ScopeChain, m_node)), regT1); // newScopeChain
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSFunction, m_data) + OBJECT_OFFSETOF(ScopeChain, m_node)), regT1); // newScopeChain
store32(Imm32(argCount), Address(callFrameRegister, (registerOffset + RegisterFile::ArgumentCount) * static_cast<int>(sizeof(Register))));
storePtr(callFrameRegister, Address(callFrameRegister, (registerOffset + RegisterFile::CallerFrame) * static_cast<int>(sizeof(Register))));
storePtr(regT1, Address(callFrameRegister, (registerOffset + RegisterFile::ScopeChain) * static_cast<int>(sizeof(Register))));
@@ -285,60 +285,32 @@ void JIT::compileOpCallSlowCase(Instruction* instruction, Vector<SlowCaseEntry>:
emitGetVirtualRegister(callee, regT2);
}
- move(Imm32(argCount), regT1);
-
// Speculatively roll the callframe, assuming argCount will match the arity.
storePtr(callFrameRegister, Address(callFrameRegister, (RegisterFile::CallerFrame + registerOffset) * static_cast<int>(sizeof(Register))));
addPtr(Imm32(registerOffset * static_cast<int>(sizeof(Register))), callFrameRegister);
+ move(Imm32(argCount), regT1);
- m_callStructureStubCompilationInfo[callLinkInfoIndex].callReturnLocation =
- emitNakedCall(m_globalData->jitStubs.ctiVirtualCallPreLink());
+ m_callStructureStubCompilationInfo[callLinkInfoIndex].callReturnLocation = emitNakedCall(m_globalData->jitStubs.ctiVirtualCallPreLink());
- Jump storeResultForFirstRun = jump();
+ // Put the return value in dst.
+ emitPutVirtualRegister(dst);
+ sampleCodeBlock(m_codeBlock);
- // This is the address for the cold path *after* the first run (which tries to link the call).
- m_callStructureStubCompilationInfo[callLinkInfoIndex].coldPathOther = MacroAssembler::Label(this);
+ // If not, we need an extra case in the if below!
+ ASSERT(OPCODE_LENGTH(op_call) == OPCODE_LENGTH(op_call_eval));
- // The arguments have been set up on the hot path for op_call_eval
- if (opcodeID == op_call)
- compileOpCallSetupArgs(instruction);
- else if (opcodeID == op_construct)
- compileOpConstructSetupArgs(instruction);
-
- // Check for JSFunctions.
- Jump isNotObject = emitJumpIfNotJSCell(regT2);
- Jump isJSFunction = branchPtr(Equal, Address(regT2), ImmPtr(m_globalData->jsFunctionVPtr));
+ // Done! - return back to the hot path.
+ if (opcodeID == op_construct)
+ emitJumpSlowToHot(jump(), OPCODE_LENGTH(op_construct));
+ else
+ emitJumpSlowToHot(jump(), OPCODE_LENGTH(op_call));
// This handles host functions
- isNotObject.link(this);
callLinkFailNotObject.link(this);
callLinkFailNotJSFunction.link(this);
- JITStubCall stubCall(this, opcodeID == op_construct ? JITStubs::cti_op_construct_NotJSConstruct : JITStubs::cti_op_call_NotJSFunction);
- stubCall.call();
- Jump wasNotJSFunction = jump();
-
- // Next, handle JSFunctions...
- isJSFunction.link(this);
+ JITStubCall(this, opcodeID == op_construct ? JITStubs::cti_op_construct_NotJSConstruct : JITStubs::cti_op_call_NotJSFunction).call();
- // First, in the case of a construct, allocate the new object.
- if (opcodeID == op_construct) {
- JITStubCall stubCall(this, JITStubs::cti_op_construct_JSConstruct);
- stubCall.call(registerOffset - RegisterFile::CallFrameHeaderSize - argCount);
- emitGetVirtualRegister(callee, regT2);
- }
-
- // Speculatively roll the callframe, assuming argCount will match the arity.
- storePtr(callFrameRegister, Address(callFrameRegister, (RegisterFile::CallerFrame + registerOffset) * static_cast<int>(sizeof(Register))));
- addPtr(Imm32(registerOffset * static_cast<int>(sizeof(Register))), callFrameRegister);
- move(Imm32(argCount), regT1);
-
- emitNakedCall(m_globalData->jitStubs.ctiVirtualCall());
-
- // Put the return value in dst. In the interpreter, op_ret does this.
- wasNotJSFunction.link(this);
- storeResultForFirstRun.link(this);
emitPutVirtualRegister(dst);
-
sampleCodeBlock(m_codeBlock);
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITInlineMethods.h b/src/3rdparty/webkit/JavaScriptCore/jit/JITInlineMethods.h
index d5de291..deca0d1 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITInlineMethods.h
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITInlineMethods.h
@@ -30,15 +30,6 @@
#if ENABLE(JIT)
-#if PLATFORM(WIN)
-#undef FIELD_OFFSET // Fix conflict with winnt.h.
-#endif
-
-// FIELD_OFFSET: Like the C++ offsetof macro, but you can use it with classes.
-// The magic number 0x4000 is insignificant. We use it to avoid using NULL, since
-// NULL can cause compiler problems, especially in cases of multiple inheritance.
-#define FIELD_OFFSET(class, field) (reinterpret_cast<ptrdiff_t>(&(reinterpret_cast<class*>(0x4000)->field)) - 0x4000)
-
namespace JSC {
ALWAYS_INLINE void JIT::killLastResultRegister()
@@ -186,6 +177,8 @@ ALWAYS_INLINE JIT::Call JIT::emitNakedCall(CodePtr function)
return nakedCall;
}
+#if PLATFORM(X86) || PLATFORM(X86_64)
+
ALWAYS_INLINE void JIT::preverveReturnAddressAfterCall(RegisterID reg)
{
pop(reg);
@@ -201,31 +194,52 @@ ALWAYS_INLINE void JIT::restoreReturnAddressBeforeReturn(Address address)
push(address);
}
+#elif PLATFORM_ARM_ARCH(7)
+
+ALWAYS_INLINE void JIT::preverveReturnAddressAfterCall(RegisterID reg)
+{
+ move(linkRegister, reg);
+}
+
+ALWAYS_INLINE void JIT::restoreReturnAddressBeforeReturn(RegisterID reg)
+{
+ move(reg, linkRegister);
+}
+
+ALWAYS_INLINE void JIT::restoreReturnAddressBeforeReturn(Address address)
+{
+ loadPtr(address, linkRegister);
+}
+
+#endif
+
#if USE(JIT_STUB_ARGUMENT_VA_LIST)
ALWAYS_INLINE void JIT::restoreArgumentReference()
{
- poke(callFrameRegister, offsetof(struct JITStackFrame, callFrame) / sizeof (void*));
+ poke(callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*));
}
ALWAYS_INLINE void JIT::restoreArgumentReferenceForTrampoline() {}
#else
ALWAYS_INLINE void JIT::restoreArgumentReference()
{
move(stackPointerRegister, firstArgumentRegister);
- poke(callFrameRegister, offsetof(struct JITStackFrame, callFrame) / sizeof (void*));
+ poke(callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*));
}
ALWAYS_INLINE void JIT::restoreArgumentReferenceForTrampoline()
{
- // In the trampoline on x86-64, the first argument register is not overwritten.
-#if !PLATFORM(X86_64)
+#if PLATFORM(X86)
+ // Within a trampoline the return address will be on the stack at this point.
+ addPtr(Imm32(sizeof(void*)), stackPointerRegister, firstArgumentRegister);
+#elif PLATFORM_ARM_ARCH(7)
move(stackPointerRegister, firstArgumentRegister);
- addPtr(Imm32(sizeof(void*)), firstArgumentRegister);
#endif
+ // In the trampoline on x86-64, the first argument register is not overwritten.
}
#endif
ALWAYS_INLINE JIT::Jump JIT::checkStructure(RegisterID reg, Structure* structure)
{
- return branchPtr(NotEqual, Address(reg, FIELD_OFFSET(JSCell, m_structure)), ImmPtr(structure));
+ return branchPtr(NotEqual, Address(reg, OBJECT_OFFSETOF(JSCell, m_structure)), ImmPtr(structure));
}
ALWAYS_INLINE JIT::Jump JIT::emitJumpIfJSCell(RegisterID reg)
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITOpcodes.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JITOpcodes.cpp
index 1737551..dbcb34d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITOpcodes.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITOpcodes.cpp
@@ -159,18 +159,18 @@ void JIT::emit_op_instanceof(Instruction* currentInstruction)
emitJumpSlowCaseIfNotJSCell(regT1);
// Check that baseVal is an object, that it 'ImplementsHasInstance' but that it does not 'OverridesHasInstance'.
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT0);
- addSlowCase(branch32(NotEqual, Address(regT0, FIELD_OFFSET(Structure, m_typeInfo.m_type)), Imm32(ObjectType)));
- addSlowCase(branchTest32(Zero, Address(regT0, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(ImplementsDefaultHasInstance)));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT0);
+ addSlowCase(branch32(NotEqual, Address(regT0, OBJECT_OFFSETOF(Structure, m_typeInfo.m_type)), Imm32(ObjectType)));
+ addSlowCase(branchTest32(Zero, Address(regT0, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(ImplementsDefaultHasInstance)));
// If value is not an Object, return false.
Jump valueIsImmediate = emitJumpIfNotJSCell(regT2);
- loadPtr(Address(regT2, FIELD_OFFSET(JSCell, m_structure)), regT0);
- Jump valueIsNotObject = branch32(NotEqual, Address(regT0, FIELD_OFFSET(Structure, m_typeInfo.m_type)), Imm32(ObjectType));
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSCell, m_structure)), regT0);
+ Jump valueIsNotObject = branch32(NotEqual, Address(regT0, OBJECT_OFFSETOF(Structure, m_typeInfo.m_type)), Imm32(ObjectType));
// Check proto is object.
- loadPtr(Address(regT1, FIELD_OFFSET(JSCell, m_structure)), regT0);
- addSlowCase(branch32(NotEqual, Address(regT0, FIELD_OFFSET(Structure, m_typeInfo.m_type)), Imm32(ObjectType)));
+ loadPtr(Address(regT1, OBJECT_OFFSETOF(JSCell, m_structure)), regT0);
+ addSlowCase(branch32(NotEqual, Address(regT0, OBJECT_OFFSETOF(Structure, m_typeInfo.m_type)), Imm32(ObjectType)));
// Optimistically load the result true, and start looping.
// Initially, regT1 still contains proto and regT2 still contains value.
@@ -180,8 +180,8 @@ void JIT::emit_op_instanceof(Instruction* currentInstruction)
// Load the prototype of the object in regT2. If this is equal to regT1 - WIN!
// Otherwise, check if we've hit null - if we have then drop out of the loop, if not go again.
- loadPtr(Address(regT2, FIELD_OFFSET(JSCell, m_structure)), regT2);
- loadPtr(Address(regT2, FIELD_OFFSET(Structure, m_prototype)), regT2);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(Structure, m_prototype)), regT2);
Jump isInstance = branchPtr(Equal, regT2, regT1);
branchPtr(NotEqual, regT2, ImmPtr(JSValue::encode(jsNull())), loop);
@@ -251,9 +251,9 @@ void JIT::emit_op_get_scoped_var(Instruction* currentInstruction)
emitGetFromCallFrameHeaderPtr(RegisterFile::ScopeChain, regT0);
while (skip--)
- loadPtr(Address(regT0, FIELD_OFFSET(ScopeChainNode, next)), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(ScopeChainNode, next)), regT0);
- loadPtr(Address(regT0, FIELD_OFFSET(ScopeChainNode, object)), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(ScopeChainNode, object)), regT0);
emitGetVariableObjectRegister(regT0, currentInstruction[2].u.operand, regT0);
emitPutVirtualRegister(currentInstruction[1].u.operand);
}
@@ -265,9 +265,9 @@ void JIT::emit_op_put_scoped_var(Instruction* currentInstruction)
emitGetFromCallFrameHeaderPtr(RegisterFile::ScopeChain, regT1);
emitGetVirtualRegister(currentInstruction[3].u.operand, regT0);
while (skip--)
- loadPtr(Address(regT1, FIELD_OFFSET(ScopeChainNode, next)), regT1);
+ loadPtr(Address(regT1, OBJECT_OFFSETOF(ScopeChainNode, next)), regT1);
- loadPtr(Address(regT1, FIELD_OFFSET(ScopeChainNode, object)), regT1);
+ loadPtr(Address(regT1, OBJECT_OFFSETOF(ScopeChainNode, object)), regT1);
emitPutVariableObjectRegister(regT0, regT1, currentInstruction[1].u.operand);
}
@@ -327,8 +327,8 @@ void JIT::emit_op_construct_verify(Instruction* currentInstruction)
emitGetVirtualRegister(currentInstruction[1].u.operand, regT0);
emitJumpSlowCaseIfNotJSCell(regT0);
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- addSlowCase(branch32(NotEqual, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo) + FIELD_OFFSET(TypeInfo, m_type)), Imm32(ObjectType)));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ addSlowCase(branch32(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo) + OBJECT_OFFSETOF(TypeInfo, m_type)), Imm32(ObjectType)));
}
@@ -407,11 +407,11 @@ void JIT::emit_op_resolve_global(Instruction* currentInstruction)
// Check Structure of global object
move(ImmPtr(globalObject), regT0);
loadPtr(structureAddress, regT1);
- Jump noMatch = branchPtr(NotEqual, regT1, Address(regT0, FIELD_OFFSET(JSCell, m_structure))); // Structures don't match
+ Jump noMatch = branchPtr(NotEqual, regT1, Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure))); // Structures don't match
// Load cached property
// Assume that the global object always uses external storage.
- loadPtr(Address(regT0, FIELD_OFFSET(JSGlobalObject, m_externalStorage)), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSGlobalObject, m_externalStorage)), regT0);
load32(offsetAddr, regT1);
loadPtr(BaseIndex(regT0, regT1, ScalePtr), regT0);
emitPutVirtualRegister(currentInstruction[1].u.operand);
@@ -459,8 +459,8 @@ void JIT::emit_op_jeq_null(Instruction* currentInstruction)
Jump isImmediate = emitJumpIfNotJSCell(regT0);
// First, handle JSCell cases - check MasqueradesAsUndefined bit on the structure.
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- addJump(branchTest32(NonZero, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined)), target + 2);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ addJump(branchTest32(NonZero, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined)), target + 2);
Jump wasNotImmediate = jump();
// Now handle the immediate cases - undefined & null
@@ -480,8 +480,8 @@ void JIT::emit_op_jneq_null(Instruction* currentInstruction)
Jump isImmediate = emitJumpIfNotJSCell(regT0);
// First, handle JSCell cases - check MasqueradesAsUndefined bit on the structure.
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- addJump(branchTest32(Zero, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined)), target + 2);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ addJump(branchTest32(Zero, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined)), target + 2);
Jump wasNotImmediate = jump();
// Now handle the immediate cases - undefined & null
@@ -670,8 +670,8 @@ void JIT::emit_op_to_jsnumber(Instruction* currentInstruction)
Jump wasImmediate = emitJumpIfImmediateInteger(regT0);
emitJumpSlowCaseIfNotJSCell(regT0, srcVReg);
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- addSlowCase(branch32(NotEqual, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo.m_type)), Imm32(NumberType)));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ addSlowCase(branch32(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_type)), Imm32(NumberType)));
wasImmediate.link(this);
@@ -689,7 +689,7 @@ void JIT::emit_op_push_new_scope(Instruction* currentInstruction)
void JIT::emit_op_catch(Instruction* currentInstruction)
{
killLastResultRegister(); // FIXME: Implicitly treat op_catch as a labeled statement, and remove this line of code.
- peek(callFrameRegister, offsetof(struct JITStackFrame, callFrame) / sizeof (void*));
+ peek(callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*));
emitPutVirtualRegister(currentInstruction[1].u.operand);
}
@@ -781,8 +781,8 @@ void JIT::emit_op_eq_null(Instruction* currentInstruction)
emitGetVirtualRegister(src1, regT0);
Jump isImmediate = emitJumpIfNotJSCell(regT0);
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- setTest32(NonZero, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ setTest32(NonZero, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined), regT0);
Jump wasNotImmediate = jump();
@@ -806,8 +806,8 @@ void JIT::emit_op_neq_null(Instruction* currentInstruction)
emitGetVirtualRegister(src1, regT0);
Jump isImmediate = emitJumpIfNotJSCell(regT0);
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
- setTest32(Zero, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined), regT0);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ setTest32(Zero, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(MasqueradesAsUndefined), regT0);
Jump wasNotImmediate = jump();
@@ -866,14 +866,14 @@ void JIT::emit_op_convert_this(Instruction* currentInstruction)
emitGetVirtualRegister(currentInstruction[1].u.operand, regT0);
emitJumpSlowCaseIfNotJSCell(regT0);
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT1);
- addSlowCase(branchTest32(NonZero, Address(regT1, FIELD_OFFSET(Structure, m_typeInfo.m_flags)), Imm32(NeedsThisConversion)));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT1);
+ addSlowCase(branchTest32(NonZero, Address(regT1, OBJECT_OFFSETOF(Structure, m_typeInfo.m_flags)), Imm32(NeedsThisConversion)));
}
void JIT::emit_op_profile_will_call(Instruction* currentInstruction)
{
- peek(regT1, FIELD_OFFSET(JITStackFrame, enabledProfilerReference) / sizeof (void*));
+ peek(regT1, OBJECT_OFFSETOF(JITStackFrame, enabledProfilerReference) / sizeof (void*));
Jump noProfiler = branchTestPtr(Zero, Address(regT1));
JITStubCall stubCall(this, JITStubs::cti_op_profile_will_call);
@@ -885,7 +885,7 @@ void JIT::emit_op_profile_will_call(Instruction* currentInstruction)
void JIT::emit_op_profile_did_call(Instruction* currentInstruction)
{
- peek(regT1, FIELD_OFFSET(JITStackFrame, enabledProfilerReference) / sizeof (void*));
+ peek(regT1, OBJECT_OFFSETOF(JITStackFrame, enabledProfilerReference) / sizeof (void*));
Jump noProfiler = branchTestPtr(Zero, Address(regT1));
JITStubCall stubCall(this, JITStubs::cti_op_profile_did_call);
@@ -943,10 +943,10 @@ void JIT::emitSlow_op_get_by_val(Instruction* currentInstruction, Vector<SlowCas
// This is slow void JIT::emitSlow_that handles accesses to arrays above the fast cut-off.
// First, check if this is an access to the vector
linkSlowCase(iter);
- branch32(AboveOrEqual, regT1, Address(regT2, FIELD_OFFSET(ArrayStorage, m_vectorLength)), beginGetByValSlow);
+ branch32(AboveOrEqual, regT1, Address(regT2, OBJECT_OFFSETOF(ArrayStorage, m_vectorLength)), beginGetByValSlow);
// okay, missed the fast region, but it is still in the vector. Get the value.
- loadPtr(BaseIndex(regT2, regT1, ScalePtr, FIELD_OFFSET(ArrayStorage, m_vector[0])), regT2);
+ loadPtr(BaseIndex(regT2, regT1, ScalePtr, OBJECT_OFFSETOF(ArrayStorage, m_vector[0])), regT2);
// Check whether the value loaded is zero; if so we need to return undefined.
branchTestPtr(Zero, regT2, beginGetByValSlow);
move(regT2, regT0);
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITPropertyAccess.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JITPropertyAccess.cpp
index 29b9cab..ed8f48f 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITPropertyAccess.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITPropertyAccess.cpp
@@ -64,11 +64,11 @@ void JIT::emit_op_get_by_val(Instruction* currentInstruction)
addSlowCase(branchPtr(NotEqual, Address(regT0), ImmPtr(m_globalData->jsArrayVPtr)));
// This is an array; get the m_storage pointer into ecx, then check if the index is below the fast cutoff
- loadPtr(Address(regT0, FIELD_OFFSET(JSArray, m_storage)), regT2);
- addSlowCase(branch32(AboveOrEqual, regT1, Address(regT0, FIELD_OFFSET(JSArray, m_fastAccessCutoff))));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSArray, m_storage)), regT2);
+ addSlowCase(branch32(AboveOrEqual, regT1, Address(regT0, OBJECT_OFFSETOF(JSArray, m_fastAccessCutoff))));
// Get the value from the vector
- loadPtr(BaseIndex(regT2, regT1, ScalePtr, FIELD_OFFSET(ArrayStorage, m_vector[0])), regT0);
+ loadPtr(BaseIndex(regT2, regT1, ScalePtr, OBJECT_OFFSETOF(ArrayStorage, m_vector[0])), regT0);
emitPutVirtualRegister(currentInstruction[1].u.operand);
}
@@ -86,19 +86,19 @@ void JIT::emit_op_put_by_val(Instruction* currentInstruction)
addSlowCase(branchPtr(NotEqual, Address(regT0), ImmPtr(m_globalData->jsArrayVPtr)));
// This is an array; get the m_storage pointer into ecx, then check if the index is below the fast cutoff
- loadPtr(Address(regT0, FIELD_OFFSET(JSArray, m_storage)), regT2);
- Jump inFastVector = branch32(Below, regT1, Address(regT0, FIELD_OFFSET(JSArray, m_fastAccessCutoff)));
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSArray, m_storage)), regT2);
+ Jump inFastVector = branch32(Below, regT1, Address(regT0, OBJECT_OFFSETOF(JSArray, m_fastAccessCutoff)));
// No; oh well, check if the access if within the vector - if so, we may still be okay.
- addSlowCase(branch32(AboveOrEqual, regT1, Address(regT2, FIELD_OFFSET(ArrayStorage, m_vectorLength))));
+ addSlowCase(branch32(AboveOrEqual, regT1, Address(regT2, OBJECT_OFFSETOF(ArrayStorage, m_vectorLength))));
// This is a write to the slow part of the vector; first, we have to check if this would be the first write to this location.
// FIXME: should be able to handle initial write to array; increment the the number of items in the array, and potentially update fast access cutoff.
- addSlowCase(branchTestPtr(Zero, BaseIndex(regT2, regT1, ScalePtr, FIELD_OFFSET(ArrayStorage, m_vector[0]))));
+ addSlowCase(branchTestPtr(Zero, BaseIndex(regT2, regT1, ScalePtr, OBJECT_OFFSETOF(ArrayStorage, m_vector[0]))));
// All good - put the value into the array.
inFastVector.link(this);
emitGetVirtualRegister(currentInstruction[3].u.operand, regT0);
- storePtr(regT0, BaseIndex(regT2, regT1, ScalePtr, FIELD_OFFSET(ArrayStorage, m_vector[0])));
+ storePtr(regT0, BaseIndex(regT2, regT1, ScalePtr, OBJECT_OFFSETOF(ArrayStorage, m_vector[0])));
}
void JIT::emit_op_put_by_index(Instruction* currentInstruction)
@@ -212,9 +212,9 @@ void JIT::emit_op_method_check(Instruction* currentInstruction)
m_methodCallCompilationInfo.append(MethodCallCompilationInfo(m_propertyAccessInstructionIndex));
MethodCallCompilationInfo& info = m_methodCallCompilationInfo.last();
Jump notCell = emitJumpIfNotJSCell(regT0);
- Jump structureCheck = branchPtrWithPatch(NotEqual, Address(regT0, FIELD_OFFSET(JSCell, m_structure)), info.structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
+ Jump structureCheck = branchPtrWithPatch(NotEqual, Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), info.structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
DataLabelPtr protoStructureToCompare, protoObj = moveWithPatch(ImmPtr(0), regT1);
- Jump protoStructureCheck = branchPtrWithPatch(NotEqual, Address(regT1, FIELD_OFFSET(JSCell, m_structure)), protoStructureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
+ Jump protoStructureCheck = branchPtrWithPatch(NotEqual, Address(regT1, OBJECT_OFFSETOF(JSCell, m_structure)), protoStructureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
// This will be relinked to load the function without doing a load.
DataLabelPtr putFunction = moveWithPatch(ImmPtr(0), regT0);
@@ -285,13 +285,12 @@ void JIT::compileGetByIdHotPath(int, int baseVReg, Identifier*, unsigned propert
m_propertyAccessCompilationInfo[propertyAccessInstructionIndex].hotPathBegin = hotPathBegin;
DataLabelPtr structureToCompare;
- Jump structureCheck = branchPtrWithPatch(NotEqual, Address(regT0, FIELD_OFFSET(JSCell, m_structure)), structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
+ Jump structureCheck = branchPtrWithPatch(NotEqual, Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure)));
addSlowCase(structureCheck);
ASSERT(differenceBetween(hotPathBegin, structureToCompare) == patchOffsetGetByIdStructure);
ASSERT(differenceBetween(hotPathBegin, structureCheck) == patchOffsetGetByIdBranchToSlowCase);
- Label externalLoad(this);
- loadPtr(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
+ Label externalLoad = loadPtrWithPatchToLEA(Address(regT0, OBJECT_OFFSETOF(JSObject, m_externalStorage)), regT0);
Label externalLoadComplete(this);
ASSERT(differenceBetween(hotPathBegin, externalLoad) == patchOffsetGetByIdExternalLoad);
ASSERT(differenceBetween(externalLoad, externalLoadComplete) == patchLengthGetByIdExternalLoad);
@@ -358,12 +357,11 @@ void JIT::emit_op_put_by_id(Instruction* currentInstruction)
// It is important that the following instruction plants a 32bit immediate, in order that it can be patched over.
DataLabelPtr structureToCompare;
- addSlowCase(branchPtrWithPatch(NotEqual, Address(regT0, FIELD_OFFSET(JSCell, m_structure)), structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure))));
+ addSlowCase(branchPtrWithPatch(NotEqual, Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), structureToCompare, ImmPtr(reinterpret_cast<void*>(patchGetByIdDefaultStructure))));
ASSERT(differenceBetween(hotPathBegin, structureToCompare) == patchOffsetPutByIdStructure);
// Plant a load from a bogus ofset in the object's property map; we will patch this later, if it is to be used.
- Label externalLoad(this);
- loadPtr(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
+ Label externalLoad = loadPtrWithPatchToLEA(Address(regT0, OBJECT_OFFSETOF(JSObject, m_externalStorage)), regT0);
Label externalLoadComplete(this);
ASSERT(differenceBetween(hotPathBegin, externalLoad) == patchOffsetPutByIdExternalLoad);
ASSERT(differenceBetween(externalLoad, externalLoadComplete) == patchLengthPutByIdExternalLoad);
@@ -398,9 +396,9 @@ void JIT::compilePutDirectOffset(RegisterID base, RegisterID value, Structure* s
{
int offset = cachedOffset * sizeof(JSValue);
if (structure->isUsingInlineStorage())
- offset += FIELD_OFFSET(JSObject, m_inlineStorage);
+ offset += OBJECT_OFFSETOF(JSObject, m_inlineStorage);
else
- loadPtr(Address(base, FIELD_OFFSET(JSObject, m_externalStorage)), base);
+ loadPtr(Address(base, OBJECT_OFFSETOF(JSObject, m_externalStorage)), base);
storePtr(value, Address(base, offset));
}
@@ -409,34 +407,37 @@ void JIT::compileGetDirectOffset(RegisterID base, RegisterID result, Structure*
{
int offset = cachedOffset * sizeof(JSValue);
if (structure->isUsingInlineStorage())
- offset += FIELD_OFFSET(JSObject, m_inlineStorage);
+ offset += OBJECT_OFFSETOF(JSObject, m_inlineStorage);
else
- loadPtr(Address(base, FIELD_OFFSET(JSObject, m_externalStorage)), base);
+ loadPtr(Address(base, OBJECT_OFFSETOF(JSObject, m_externalStorage)), base);
loadPtr(Address(base, offset), result);
}
-void JIT::compileGetDirectOffset(JSObject* base, RegisterID result, size_t cachedOffset)
+void JIT::compileGetDirectOffset(JSObject* base, RegisterID temp, RegisterID result, size_t cachedOffset)
{
if (base->isUsingInlineStorage())
loadPtr(static_cast<void*>(&base->m_inlineStorage[cachedOffset]), result);
- else
- loadPtr(static_cast<void*>(&base->m_externalStorage[cachedOffset]), result);
+ else {
+ PropertyStorage* protoPropertyStorage = &base->m_externalStorage;
+ loadPtr(static_cast<void*>(protoPropertyStorage), temp);
+ loadPtr(Address(temp, cachedOffset * sizeof(JSValue)), result);
+ }
}
-void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure* oldStructure, Structure* newStructure, size_t cachedOffset, StructureChain* chain, ProcessorReturnAddress returnAddress)
+void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure* oldStructure, Structure* newStructure, size_t cachedOffset, StructureChain* chain, ReturnAddressPtr returnAddress)
{
JumpList failureCases;
// Check eax is an object of the right Structure.
failureCases.append(emitJumpIfNotJSCell(regT0));
- failureCases.append(branchPtr(NotEqual, Address(regT0, FIELD_OFFSET(JSCell, m_structure)), ImmPtr(oldStructure)));
+ failureCases.append(branchPtr(NotEqual, Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), ImmPtr(oldStructure)));
JumpList successCases;
// ecx = baseObject
- loadPtr(Address(regT0, FIELD_OFFSET(JSCell, m_structure)), regT2);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
// proto(ecx) = baseObject->structure()->prototype()
- failureCases.append(branch32(NotEqual, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo) + FIELD_OFFSET(TypeInfo, m_type)), Imm32(ObjectType)));
+ failureCases.append(branch32(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo) + OBJECT_OFFSETOF(TypeInfo, m_type)), Imm32(ObjectType)));
- loadPtr(Address(regT2, FIELD_OFFSET(Structure, m_prototype)), regT2);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(Structure, m_prototype)), regT2);
// ecx = baseObject->m_structure
for (RefPtr<Structure>* it = chain->head(); *it; ++it) {
@@ -444,11 +445,11 @@ void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure
successCases.append(branchPtr(Equal, regT2, ImmPtr(JSValue::encode(jsNull()))));
// Check the structure id
- failureCases.append(branchPtr(NotEqual, Address(regT2, FIELD_OFFSET(JSCell, m_structure)), ImmPtr(it->get())));
+ failureCases.append(branchPtr(NotEqual, Address(regT2, OBJECT_OFFSETOF(JSCell, m_structure)), ImmPtr(it->get())));
- loadPtr(Address(regT2, FIELD_OFFSET(JSCell, m_structure)), regT2);
- failureCases.append(branch32(NotEqual, Address(regT2, FIELD_OFFSET(Structure, m_typeInfo) + FIELD_OFFSET(TypeInfo, m_type)), Imm32(ObjectType)));
- loadPtr(Address(regT2, FIELD_OFFSET(Structure, m_prototype)), regT2);
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(JSCell, m_structure)), regT2);
+ failureCases.append(branch32(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo) + OBJECT_OFFSETOF(TypeInfo, m_type)), Imm32(ObjectType)));
+ loadPtr(Address(regT2, OBJECT_OFFSETOF(Structure, m_prototype)), regT2);
}
successCases.link(this);
@@ -477,7 +478,7 @@ void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure
// codeblock should ensure oldStructure->m_refCount > 0
sub32(Imm32(1), AbsoluteAddress(oldStructure->addressOfCount()));
add32(Imm32(1), AbsoluteAddress(newStructure->addressOfCount()));
- storePtr(ImmPtr(newStructure), Address(regT0, FIELD_OFFSET(JSCell, m_structure)));
+ storePtr(ImmPtr(newStructure), Address(regT0, OBJECT_OFFSETOF(JSCell, m_structure)));
// write the value
compilePutDirectOffset(regT0, regT1, newStructure, cachedOffset);
@@ -489,7 +490,7 @@ void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure
restoreArgumentReferenceForTrampoline();
Call failureCall = tailRecursiveCall();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
patchBuffer.link(failureCall, FunctionPtr(JITStubs::cti_op_put_by_id_fail));
@@ -500,77 +501,81 @@ void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure
CodeLocationLabel entryLabel = patchBuffer.finalizeCodeAddendum();
stubInfo->stubRoutine = entryLabel;
- returnAddress.relinkCallerToTrampoline(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relinkCallerToTrampoline(returnAddress, entryLabel);
}
-void JIT::patchGetByIdSelf(StructureStubInfo* stubInfo, Structure* structure, size_t cachedOffset, ProcessorReturnAddress returnAddress)
+void JIT::patchGetByIdSelf(StructureStubInfo* stubInfo, Structure* structure, size_t cachedOffset, ReturnAddressPtr returnAddress)
{
+ RepatchBuffer repatchBuffer;
+
// We don't want to patch more than once - in future go to cti_op_get_by_id_generic.
// Should probably go to JITStubs::cti_op_get_by_id_fail, but that doesn't do anything interesting right now.
- returnAddress.relinkCallerToFunction(FunctionPtr(JITStubs::cti_op_get_by_id_self_fail));
+ repatchBuffer.relinkCallerToFunction(returnAddress, FunctionPtr(JITStubs::cti_op_get_by_id_self_fail));
int offset = sizeof(JSValue) * cachedOffset;
// If we're patching to use inline storage, convert the initial load to a lea; this avoids the extra load
// and makes the subsequent load's offset automatically correct
if (structure->isUsingInlineStorage())
- stubInfo->hotPathBegin.instructionAtOffset(patchOffsetGetByIdExternalLoad).repatchLoadPtrToLEA();
+ repatchBuffer.repatchLoadPtrToLEA(stubInfo->hotPathBegin.instructionAtOffset(patchOffsetGetByIdExternalLoad));
// Patch the offset into the propoerty map to load from, then patch the Structure to look for.
- stubInfo->hotPathBegin.dataLabelPtrAtOffset(patchOffsetGetByIdStructure).repatch(structure);
- stubInfo->hotPathBegin.dataLabel32AtOffset(patchOffsetGetByIdPropertyMapOffset).repatch(offset);
+ repatchBuffer.repatch(stubInfo->hotPathBegin.dataLabelPtrAtOffset(patchOffsetGetByIdStructure), structure);
+ repatchBuffer.repatch(stubInfo->hotPathBegin.dataLabel32AtOffset(patchOffsetGetByIdPropertyMapOffset), offset);
}
void JIT::patchMethodCallProto(MethodCallLinkInfo& methodCallLinkInfo, JSFunction* callee, Structure* structure, JSObject* proto)
{
+ RepatchBuffer repatchBuffer;
+
ASSERT(!methodCallLinkInfo.cachedStructure);
methodCallLinkInfo.cachedStructure = structure;
structure->ref();
- methodCallLinkInfo.structureLabel.repatch(structure);
- methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckProtoObj).repatch(proto);
- methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckProtoStruct).repatch(proto->structure());
- methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckPutFunction).repatch(callee);
+ repatchBuffer.repatch(methodCallLinkInfo.structureLabel, structure);
+ repatchBuffer.repatch(methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckProtoObj), proto);
+ repatchBuffer.repatch(methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckProtoStruct), proto->structure());
+ repatchBuffer.repatch(methodCallLinkInfo.structureLabel.dataLabelPtrAtOffset(patchOffsetMethodCheckPutFunction), callee);
}
-void JIT::patchPutByIdReplace(StructureStubInfo* stubInfo, Structure* structure, size_t cachedOffset, ProcessorReturnAddress returnAddress)
+void JIT::patchPutByIdReplace(StructureStubInfo* stubInfo, Structure* structure, size_t cachedOffset, ReturnAddressPtr returnAddress)
{
+ RepatchBuffer repatchBuffer;
+
// We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
// Should probably go to JITStubs::cti_op_put_by_id_fail, but that doesn't do anything interesting right now.
- returnAddress.relinkCallerToFunction(FunctionPtr(JITStubs::cti_op_put_by_id_generic));
+ repatchBuffer.relinkCallerToFunction(returnAddress, FunctionPtr(JITStubs::cti_op_put_by_id_generic));
int offset = sizeof(JSValue) * cachedOffset;
// If we're patching to use inline storage, convert the initial load to a lea; this avoids the extra load
// and makes the subsequent load's offset automatically correct
if (structure->isUsingInlineStorage())
- stubInfo->hotPathBegin.instructionAtOffset(patchOffsetPutByIdExternalLoad).repatchLoadPtrToLEA();
+ repatchBuffer.repatchLoadPtrToLEA(stubInfo->hotPathBegin.instructionAtOffset(patchOffsetPutByIdExternalLoad));
// Patch the offset into the propoerty map to load from, then patch the Structure to look for.
- stubInfo->hotPathBegin.dataLabelPtrAtOffset(patchOffsetPutByIdStructure).repatch(structure);
- stubInfo->hotPathBegin.dataLabel32AtOffset(patchOffsetPutByIdPropertyMapOffset).repatch(offset);
+ repatchBuffer.repatch(stubInfo->hotPathBegin.dataLabelPtrAtOffset(patchOffsetPutByIdStructure), structure);
+ repatchBuffer.repatch(stubInfo->hotPathBegin.dataLabel32AtOffset(patchOffsetPutByIdPropertyMapOffset), offset);
}
-void JIT::privateCompilePatchGetArrayLength(ProcessorReturnAddress returnAddress)
+void JIT::privateCompilePatchGetArrayLength(ReturnAddressPtr returnAddress)
{
- StructureStubInfo* stubInfo = &m_codeBlock->getStubInfo(returnAddress.addressForLookup());
-
- // We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
- returnAddress.relinkCallerToFunction(FunctionPtr(JITStubs::cti_op_get_by_id_array_fail));
+ StructureStubInfo* stubInfo = &m_codeBlock->getStubInfo(returnAddress);
// Check eax is an array
Jump failureCases1 = branchPtr(NotEqual, Address(regT0), ImmPtr(m_globalData->jsArrayVPtr));
// Checks out okay! - get the length from the storage
- loadPtr(Address(regT0, FIELD_OFFSET(JSArray, m_storage)), regT2);
- load32(Address(regT2, FIELD_OFFSET(ArrayStorage, m_length)), regT2);
+ loadPtr(Address(regT0, OBJECT_OFFSETOF(JSArray, m_storage)), regT2);
+ load32(Address(regT2, OBJECT_OFFSETOF(ArrayStorage, m_length)), regT2);
Jump failureCases2 = branch32(Above, regT2, Imm32(JSImmediate::maxImmediateInt));
emitFastArithIntToImmNoCheck(regT2, regT0);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
CodeLocationLabel slowCaseBegin = stubInfo->callReturnLocation.labelAtOffset(-patchOffsetGetByIdSlowCaseCall);
@@ -586,14 +591,15 @@ void JIT::privateCompilePatchGetArrayLength(ProcessorReturnAddress returnAddress
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
-}
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
-void JIT::privateCompileGetByIdProto(StructureStubInfo* stubInfo, Structure* structure, Structure* prototypeStructure, size_t cachedOffset, ProcessorReturnAddress returnAddress, CallFrame* callFrame)
-{
// We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
- returnAddress.relinkCallerToFunction(FunctionPtr(JITStubs::cti_op_get_by_id_proto_list));
+ repatchBuffer.relinkCallerToFunction(returnAddress, FunctionPtr(JITStubs::cti_op_get_by_id_array_fail));
+}
+void JIT::privateCompileGetByIdProto(StructureStubInfo* stubInfo, Structure* structure, Structure* prototypeStructure, size_t cachedOffset, ReturnAddressPtr returnAddress, CallFrame* callFrame)
+{
// The prototype object definitely exists (if this stub exists the CodeBlock is referencing a Structure that is
// referencing the prototype object - let's speculatively load it's table nice and early!)
JSObject* protoObject = asObject(structure->prototypeForLookup(callFrame));
@@ -611,11 +617,11 @@ void JIT::privateCompileGetByIdProto(StructureStubInfo* stubInfo, Structure* str
#endif
// Checks out okay! - getDirectOffset
- compileGetDirectOffset(protoObject, regT0, cachedOffset);
+ compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
CodeLocationLabel slowCaseBegin = stubInfo->callReturnLocation.labelAtOffset(-patchOffsetGetByIdSlowCaseCall);
@@ -631,7 +637,11 @@ void JIT::privateCompileGetByIdProto(StructureStubInfo* stubInfo, Structure* str
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
+
+ // We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
+ repatchBuffer.relinkCallerToFunction(returnAddress, FunctionPtr(JITStubs::cti_op_get_by_id_proto_list));
}
void JIT::privateCompileGetByIdSelfList(StructureStubInfo* stubInfo, PolymorphicAccessStructureList* polymorphicStructures, int currentIndex, Structure* structure, size_t cachedOffset)
@@ -640,7 +650,7 @@ void JIT::privateCompileGetByIdSelfList(StructureStubInfo* stubInfo, Polymorphic
compileGetDirectOffset(regT0, regT0, structure, cachedOffset);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
CodeLocationLabel lastProtoBegin = polymorphicStructures->list[currentIndex - 1].stubRoutine;
@@ -659,7 +669,8 @@ void JIT::privateCompileGetByIdSelfList(StructureStubInfo* stubInfo, Polymorphic
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
}
void JIT::privateCompileGetByIdProtoList(StructureStubInfo* stubInfo, PolymorphicAccessStructureList* prototypeStructures, int currentIndex, Structure* structure, Structure* prototypeStructure, size_t cachedOffset, CallFrame* callFrame)
@@ -681,11 +692,11 @@ void JIT::privateCompileGetByIdProtoList(StructureStubInfo* stubInfo, Polymorphi
#endif
// Checks out okay! - getDirectOffset
- compileGetDirectOffset(protoObject, regT0, cachedOffset);
+ compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
CodeLocationLabel lastProtoBegin = prototypeStructures->list[currentIndex - 1].stubRoutine;
@@ -703,7 +714,8 @@ void JIT::privateCompileGetByIdProtoList(StructureStubInfo* stubInfo, Polymorphi
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
}
void JIT::privateCompileGetByIdChainList(StructureStubInfo* stubInfo, PolymorphicAccessStructureList* prototypeStructures, int currentIndex, Structure* structure, StructureChain* chain, size_t count, size_t cachedOffset, CallFrame* callFrame)
@@ -734,10 +746,10 @@ void JIT::privateCompileGetByIdChainList(StructureStubInfo* stubInfo, Polymorphi
}
ASSERT(protoObject);
- compileGetDirectOffset(protoObject, regT0, cachedOffset);
+ compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
CodeLocationLabel lastProtoBegin = prototypeStructures->list[currentIndex - 1].stubRoutine;
@@ -756,14 +768,12 @@ void JIT::privateCompileGetByIdChainList(StructureStubInfo* stubInfo, Polymorphi
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
}
-void JIT::privateCompileGetByIdChain(StructureStubInfo* stubInfo, Structure* structure, StructureChain* chain, size_t count, size_t cachedOffset, ProcessorReturnAddress returnAddress, CallFrame* callFrame)
+void JIT::privateCompileGetByIdChain(StructureStubInfo* stubInfo, Structure* structure, StructureChain* chain, size_t count, size_t cachedOffset, ReturnAddressPtr returnAddress, CallFrame* callFrame)
{
- // We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
- returnAddress.relinkCallerToFunction(FunctionPtr(JITStubs::cti_op_get_by_id_proto_list));
-
ASSERT(count);
JumpList bucketsOfFail;
@@ -789,10 +799,10 @@ void JIT::privateCompileGetByIdChain(StructureStubInfo* stubInfo, Structure* str
}
ASSERT(protoObject);
- compileGetDirectOffset(protoObject, regT0, cachedOffset);
+ compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
Jump success = jump();
- PatchBuffer patchBuffer(this, m_codeBlock->executablePool());
+ LinkBuffer patchBuffer(this, m_codeBlock->executablePool());
// Use the patch information to link the failure cases back to the original slow case routine.
patchBuffer.link(bucketsOfFail, stubInfo->callReturnLocation.labelAtOffset(-patchOffsetGetByIdSlowCaseCall));
@@ -806,7 +816,11 @@ void JIT::privateCompileGetByIdChain(StructureStubInfo* stubInfo, Structure* str
// Finally patch the jump to slow case back in the hot path to jump here instead.
CodeLocationJump jumpLocation = stubInfo->hotPathBegin.jumpAtOffset(patchOffsetGetByIdBranchToSlowCase);
- jumpLocation.relink(entryLabel);
+ RepatchBuffer repatchBuffer;
+ repatchBuffer.relink(jumpLocation, entryLabel);
+
+ // We don't want to patch more than once - in future go to cti_op_put_by_id_generic.
+ repatchBuffer.relinkCallerToFunction(returnAddress, FunctionPtr(JITStubs::cti_op_get_by_id_proto_list));
}
/* ------------------------------ END: !ENABLE / ENABLE(JIT_OPTIMIZE_PROPERTY_ACCESS) ------------------------------ */
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubCall.h b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubCall.h
index 6c9ccc1..bc07178 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubCall.h
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubCall.h
@@ -107,10 +107,9 @@ namespace JSC {
JIT::Call call()
{
- ASSERT(m_jit->m_bytecodeIndex != (unsigned)-1); // This method should only be called during hot/cold path generation, so that m_bytecodeIndex is set.
-
#if ENABLE(OPCODE_SAMPLING)
- m_jit->sampleInstruction(m_jit->m_codeBlock->instructions().begin() + m_jit->m_bytecodeIndex, true);
+ if (m_jit->m_bytecodeIndex != (unsigned)-1)
+ m_jit->sampleInstruction(m_jit->m_codeBlock->instructions().begin() + m_jit->m_bytecodeIndex, true);
#endif
m_jit->restoreArgumentReference();
@@ -118,7 +117,8 @@ namespace JSC {
m_jit->m_calls.append(CallRecord(call, m_jit->m_bytecodeIndex, m_stub));
#if ENABLE(OPCODE_SAMPLING)
- m_jit->sampleInstruction(m_jit->m_codeBlock->instructions().begin() + m_jit->m_bytecodeIndex, false);
+ if (m_jit->m_bytecodeIndex != (unsigned)-1)
+ m_jit->sampleInstruction(m_jit->m_codeBlock->instructions().begin() + m_jit->m_bytecodeIndex, false);
#endif
m_jit->killLastResultRegister();
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.cpp b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.cpp
index 41ebd20..02bf7c0 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.cpp
@@ -77,7 +77,7 @@ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x38, JITStackFrame_
COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x30, JITStackFrame_code_offset_matches_ctiTrampoline);
COMPILE_ASSERT(offsetof(struct JITStackFrame, savedEBX) == 0x1c, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
-asm(
+asm volatile (
".globl " SYMBOL_STRING(ctiTrampoline) "\n"
SYMBOL_STRING(ctiTrampoline) ":" "\n"
"pushl %ebp" "\n"
@@ -97,13 +97,22 @@ SYMBOL_STRING(ctiTrampoline) ":" "\n"
"ret" "\n"
);
-asm(
+asm volatile (
".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
#if !USE(JIT_STUB_ARGUMENT_VA_LIST)
"movl %esp, %ecx" "\n"
#endif
"call " SYMBOL_STRING(cti_vm_throw) "\n"
+ "addl $0x1c, %esp" "\n"
+ "popl %ebx" "\n"
+ "popl %edi" "\n"
+ "popl %esi" "\n"
+ "popl %ebp" "\n"
+ "ret" "\n"
+);
+
+asm volatile (
".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
"addl $0x1c, %esp" "\n"
@@ -126,7 +135,7 @@ COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x90, JITStackFrame_
COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x80, JITStackFrame_code_offset_matches_ctiTrampoline);
COMPILE_ASSERT(offsetof(struct JITStackFrame, savedRBX) == 0x48, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
-asm(
+asm volatile (
".globl " SYMBOL_STRING(ctiTrampoline) "\n"
SYMBOL_STRING(ctiTrampoline) ":" "\n"
"pushq %rbp" "\n"
@@ -152,11 +161,22 @@ SYMBOL_STRING(ctiTrampoline) ":" "\n"
"ret" "\n"
);
-asm(
+asm volatile (
".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
"movq %rsp, %rdi" "\n"
"call " SYMBOL_STRING(cti_vm_throw) "\n"
+ "addq $0x48, %rsp" "\n"
+ "popq %rbx" "\n"
+ "popq %r15" "\n"
+ "popq %r14" "\n"
+ "popq %r13" "\n"
+ "popq %r12" "\n"
+ "popq %rbp" "\n"
+ "ret" "\n"
+);
+
+asm volatile (
".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
"addq $0x48, %rsp" "\n"
@@ -169,6 +189,70 @@ SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
"ret" "\n"
);
+#elif COMPILER(GCC) && PLATFORM_ARM_ARCH(7)
+
+#if USE(JIT_STUB_ARGUMENT_VA_LIST)
+#error "JIT_STUB_ARGUMENT_VA_LIST not supported on ARMv7."
+#endif
+
+asm volatile (
+".text" "\n"
+".align 2" "\n"
+".globl " SYMBOL_STRING(ctiTrampoline) "\n"
+".thumb" "\n"
+".thumb_func " SYMBOL_STRING(ctiTrampoline) "\n"
+SYMBOL_STRING(ctiTrampoline) ":" "\n"
+ "sub sp, sp, #0x3c" "\n"
+ "str lr, [sp, #0x20]" "\n"
+ "str r4, [sp, #0x24]" "\n"
+ "str r5, [sp, #0x28]" "\n"
+ "str r6, [sp, #0x2c]" "\n"
+ "str r1, [sp, #0x30]" "\n"
+ "str r2, [sp, #0x34]" "\n"
+ "str r3, [sp, #0x38]" "\n"
+ "cpy r5, r2" "\n"
+ "mov r6, #512" "\n"
+ "blx r0" "\n"
+ "ldr r6, [sp, #0x2c]" "\n"
+ "ldr r5, [sp, #0x28]" "\n"
+ "ldr r4, [sp, #0x24]" "\n"
+ "ldr lr, [sp, #0x20]" "\n"
+ "add sp, sp, #0x3c" "\n"
+ "bx lr" "\n"
+);
+
+asm volatile (
+".text" "\n"
+".align 2" "\n"
+".globl " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+".thumb" "\n"
+".thumb_func " SYMBOL_STRING(ctiVMThrowTrampoline) "\n"
+SYMBOL_STRING(ctiVMThrowTrampoline) ":" "\n"
+ "cpy r0, sp" "\n"
+ "bl " SYMBOL_STRING(cti_vm_throw) "\n"
+ "ldr r6, [sp, #0x2c]" "\n"
+ "ldr r5, [sp, #0x28]" "\n"
+ "ldr r4, [sp, #0x24]" "\n"
+ "ldr lr, [sp, #0x20]" "\n"
+ "add sp, sp, #0x3c" "\n"
+ "bx lr" "\n"
+);
+
+asm volatile (
+".text" "\n"
+".align 2" "\n"
+".globl " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+".thumb" "\n"
+".thumb_func " SYMBOL_STRING(ctiOpThrowNotCaught) "\n"
+SYMBOL_STRING(ctiOpThrowNotCaught) ":" "\n"
+ "ldr r6, [sp, #0x2c]" "\n"
+ "ldr r5, [sp, #0x28]" "\n"
+ "ldr r4, [sp, #0x24]" "\n"
+ "ldr lr, [sp, #0x20]" "\n"
+ "add sp, sp, #0x3c" "\n"
+ "bx lr" "\n"
+);
+
#elif COMPILER(MSVC)
#if USE(JIT_STUB_ARGUMENT_VA_LIST)
@@ -218,18 +302,18 @@ extern "C" {
ret;
}
}
-
- __declspec(naked) void ctiOpThrowNotCaught()
- {
- __asm {
- add esp, 0x1c;
- pop ebx;
- pop edi;
- pop esi;
- pop ebp;
- ret;
- }
- }
+
+ __declspec(naked) void ctiOpThrowNotCaught()
+ {
+ __asm {
+ add esp, 0x1c;
+ pop ebx;
+ pop edi;
+ pop esi;
+ pop ebp;
+ ret;
+ }
+ }
}
#endif
@@ -243,11 +327,29 @@ extern "C" {
JITThunks::JITThunks(JSGlobalData* globalData)
{
JIT::compileCTIMachineTrampolines(globalData, &m_executablePool, &m_ctiArrayLengthTrampoline, &m_ctiStringLengthTrampoline, &m_ctiVirtualCallPreLink, &m_ctiVirtualCallLink, &m_ctiVirtualCall, &m_ctiNativeCallThunk);
+
+#if PLATFORM_ARM_ARCH(7)
+ // Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it contains non POD types),
+ // and the OBJECT_OFFSETOF macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT
+ // macros.
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, preservedReturnAddress) == 0x20);
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, preservedR4) == 0x24);
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, preservedR5) == 0x28);
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, preservedR6) == 0x2c);
+
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, registerFile) == 0x30);
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, callFrame) == 0x34);
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, exception) == 0x38);
+ // The fifth argument is the first item already on the stack.
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, enabledProfilerReference) == 0x3c);
+
+ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, thunkReturnAddress) == 0x1C);
+#endif
}
#if ENABLE(JIT_OPTIMIZE_PROPERTY_ACCESS)
-NEVER_INLINE void JITThunks::tryCachePutByID(CallFrame* callFrame, CodeBlock* codeBlock, void* returnAddress, JSValue baseValue, const PutPropertySlot& slot)
+NEVER_INLINE void JITThunks::tryCachePutByID(CallFrame* callFrame, CodeBlock* codeBlock, ReturnAddressPtr returnAddress, JSValue baseValue, const PutPropertySlot& slot)
{
// The interpreter checks for recursion here; I do not believe this can occur in CTI.
@@ -281,6 +383,10 @@ NEVER_INLINE void JITThunks::tryCachePutByID(CallFrame* callFrame, CodeBlock* co
// Structure transition, cache transition info
if (slot.type() == PutPropertySlot::NewProperty) {
StructureChain* prototypeChain = structure->prototypeChain(callFrame);
+ if (!prototypeChain->isCacheable()) {
+ ctiPatchCallByReturnAddress(returnAddress, FunctionPtr(JITStubs::cti_op_put_by_id_generic));
+ return;
+ }
stubInfo->initPutByIdTransition(structure->previousID(), structure, prototypeChain);
JIT::compilePutByIdTransition(callFrame->scopeChain()->globalData, codeBlock, stubInfo, structure->previousID(), structure, slot.cachedOffset(), prototypeChain, returnAddress);
return;
@@ -291,7 +397,7 @@ NEVER_INLINE void JITThunks::tryCachePutByID(CallFrame* callFrame, CodeBlock* co
JIT::patchPutByIdReplace(stubInfo, structure, slot.cachedOffset(), returnAddress);
}
-NEVER_INLINE void JITThunks::tryCacheGetByID(CallFrame* callFrame, CodeBlock* codeBlock, void* returnAddress, JSValue baseValue, const Identifier& propertyName, const PropertySlot& slot)
+NEVER_INLINE void JITThunks::tryCacheGetByID(CallFrame* callFrame, CodeBlock* codeBlock, ReturnAddressPtr returnAddress, JSValue baseValue, const Identifier& propertyName, const PropertySlot& slot)
{
// FIXME: Write a test that proves we need to check for recursion here just
// like the interpreter does, then add a check for recursion.
@@ -368,6 +474,10 @@ NEVER_INLINE void JITThunks::tryCacheGetByID(CallFrame* callFrame, CodeBlock* co
}
StructureChain* prototypeChain = structure->prototypeChain(callFrame);
+ if (!prototypeChain->isCacheable()) {
+ ctiPatchCallByReturnAddress(returnAddress, FunctionPtr(JITStubs::cti_op_get_by_id_generic));
+ return;
+ }
stubInfo->initGetByIdChain(structure, prototypeChain);
JIT::compileGetByIdChain(callFrame->scopeChain()->globalData, callFrame, codeBlock, stubInfo, structure, prototypeChain, count, slot.cachedOffset(), returnAddress);
}
@@ -398,7 +508,7 @@ struct StackHack {
: stackFrame(stackFrame)
, savedReturnAddress(*stackFrame.returnAddressSlot())
{
- *stackFrame.returnAddressSlot() = reinterpret_cast<void*>(jscGeneratedNativeCode);
+ *stackFrame.returnAddressSlot() = ReturnAddressPtr(FunctionPtr(jscGeneratedNativeCode));
}
ALWAYS_INLINE ~StackHack()
@@ -407,17 +517,17 @@ struct StackHack {
}
JITStackFrame& stackFrame;
- void* savedReturnAddress;
+ ReturnAddressPtr savedReturnAddress;
};
#define STUB_INIT_STACK_FRAME(stackFrame) SETUP_VA_LISTL_ARGS; JITStackFrame& stackFrame = *reinterpret_cast<JITStackFrame*>(STUB_ARGS); StackHack stackHack(stackFrame)
-#define STUB_SET_RETURN_ADDRESS(returnAddress) stackHack.savedReturnAddress = returnAddress
+#define STUB_SET_RETURN_ADDRESS(returnAddress) stackHack.savedReturnAddress = ReturnAddressPtr(returnAddress)
#define STUB_RETURN_ADDRESS stackHack.savedReturnAddress
#else
#define STUB_INIT_STACK_FRAME(stackFrame) SETUP_VA_LISTL_ARGS; JITStackFrame& stackFrame = *reinterpret_cast<JITStackFrame*>(STUB_ARGS)
-#define STUB_SET_RETURN_ADDRESS(returnAddress) *stackFrame.returnAddressSlot() = returnAddress
+#define STUB_SET_RETURN_ADDRESS(returnAddress) *stackFrame.returnAddressSlot() = ReturnAddressPtr(returnAddress)
#define STUB_RETURN_ADDRESS *stackFrame.returnAddressSlot()
#endif
@@ -426,14 +536,14 @@ struct StackHack {
// to get the address of the ctiVMThrowTrampoline function. It's also
// good to keep the code size down by leaving as much of the exception
// handling code out of line as possible.
-static NEVER_INLINE void returnToThrowTrampoline(JSGlobalData* globalData, void* exceptionLocation, void*& returnAddressSlot)
+static NEVER_INLINE void returnToThrowTrampoline(JSGlobalData* globalData, ReturnAddressPtr exceptionLocation, ReturnAddressPtr& returnAddressSlot)
{
ASSERT(globalData->exception);
globalData->exceptionLocation = exceptionLocation;
- returnAddressSlot = reinterpret_cast<void*>(ctiVMThrowTrampoline);
+ returnAddressSlot = ReturnAddressPtr(FunctionPtr(ctiVMThrowTrampoline));
}
-static NEVER_INLINE void throwStackOverflowError(CallFrame* callFrame, JSGlobalData* globalData, void* exceptionLocation, void*& returnAddressSlot)
+static NEVER_INLINE void throwStackOverflowError(CallFrame* callFrame, JSGlobalData* globalData, ReturnAddressPtr exceptionLocation, ReturnAddressPtr& returnAddressSlot)
{
globalData->exception = createStackOverflowError(callFrame);
returnToThrowTrampoline(globalData, exceptionLocation, returnAddressSlot);
@@ -467,7 +577,29 @@ static NEVER_INLINE void throwStackOverflowError(CallFrame* callFrame, JSGlobalD
namespace JITStubs {
+#if PLATFORM_ARM_ARCH(7)
+
+#define DEFINE_STUB_FUNCTION(rtype, op) \
+ extern "C" { \
+ rtype JITStubThunked_##op(STUB_ARGS_DECLARATION); \
+ }; \
+ asm volatile ( \
+ ".text" "\n" \
+ ".align 2" "\n" \
+ ".globl " SYMBOL_STRING(cti_##op) "\n" \
+ ".thumb" "\n" \
+ ".thumb_func " SYMBOL_STRING(cti_##op) "\n" \
+ SYMBOL_STRING(cti_##op) ":" "\n" \
+ "str lr, [sp, #0x1c]" "\n" \
+ "bl " SYMBOL_STRING(JITStubThunked_##op) "\n" \
+ "ldr lr, [sp, #0x1c]" "\n" \
+ "bx lr" "\n" \
+ ); \
+ rtype JITStubThunked_##op(STUB_ARGS_DECLARATION) \
+
+#else
#define DEFINE_STUB_FUNCTION(rtype, op) rtype JIT_STUB cti_##op(STUB_ARGS_DECLARATION)
+#endif
DEFINE_STUB_FUNCTION(JSObject*, op_convert_this)
{
@@ -573,7 +705,7 @@ DEFINE_STUB_FUNCTION(void, register_file_check)
// moved the call frame forward.
CallFrame* oldCallFrame = stackFrame.callFrame->callerFrame();
stackFrame.callFrame = oldCallFrame;
- throwStackOverflowError(oldCallFrame, stackFrame.globalData, oldCallFrame->returnPC(), STUB_RETURN_ADDRESS);
+ throwStackOverflowError(oldCallFrame, stackFrame.globalData, ReturnAddressPtr(oldCallFrame->returnPC()), STUB_RETURN_ADDRESS);
}
DEFINE_STUB_FUNCTION(int, op_loop_if_less)
@@ -832,7 +964,7 @@ DEFINE_STUB_FUNCTION(EncodedJSValue, op_get_by_id_self_fail)
if (stubInfo->opcodeID == op_get_by_id_self) {
ASSERT(!stubInfo->stubRoutine);
- polymorphicStructureList = new PolymorphicAccessStructureList(MacroAssembler::CodeLocationLabel(), stubInfo->u.getByIdSelf.baseObjectStructure);
+ polymorphicStructureList = new PolymorphicAccessStructureList(CodeLocationLabel(), stubInfo->u.getByIdSelf.baseObjectStructure);
stubInfo->initGetByIdSelfList(polymorphicStructureList, 2);
} else {
polymorphicStructureList = stubInfo->u.getByIdSelfList.structureList;
@@ -858,12 +990,12 @@ static PolymorphicAccessStructureList* getPolymorphicAccessStructureListSlot(Str
switch (stubInfo->opcodeID) {
case op_get_by_id_proto:
prototypeStructureList = new PolymorphicAccessStructureList(stubInfo->stubRoutine, stubInfo->u.getByIdProto.baseObjectStructure, stubInfo->u.getByIdProto.prototypeStructure);
- stubInfo->stubRoutine.reset();
+ stubInfo->stubRoutine = CodeLocationLabel();
stubInfo->initGetByIdProtoList(prototypeStructureList, 2);
break;
case op_get_by_id_chain:
prototypeStructureList = new PolymorphicAccessStructureList(stubInfo->stubRoutine, stubInfo->u.getByIdChain.baseObjectStructure, stubInfo->u.getByIdChain.chain);
- stubInfo->stubRoutine.reset();
+ stubInfo->stubRoutine = CodeLocationLabel();
stubInfo->initGetByIdProtoList(prototypeStructureList, 2);
break;
case op_get_by_id_proto_list:
@@ -919,9 +1051,15 @@ DEFINE_STUB_FUNCTION(EncodedJSValue, op_get_by_id_proto_list)
if (listIndex == (POLYMORPHIC_LIST_CACHE_SIZE - 1))
ctiPatchCallByReturnAddress(STUB_RETURN_ADDRESS, FunctionPtr(cti_op_get_by_id_proto_list_full));
} else if (size_t count = countPrototypeChainEntriesAndCheckForProxies(callFrame, baseValue, slot)) {
+ StructureChain* protoChain = structure->prototypeChain(callFrame);
+ if (!protoChain->isCacheable()) {
+ ctiPatchCallByReturnAddress(STUB_RETURN_ADDRESS, FunctionPtr(cti_op_get_by_id_proto_fail));
+ return JSValue::encode(result);
+ }
+
int listIndex;
PolymorphicAccessStructureList* prototypeStructureList = getPolymorphicAccessStructureListSlot(stubInfo, listIndex);
- JIT::compileGetByIdChainList(callFrame->scopeChain()->globalData, callFrame, codeBlock, stubInfo, prototypeStructureList, listIndex, structure, structure->prototypeChain(callFrame), count, slot.cachedOffset());
+ JIT::compileGetByIdChainList(callFrame->scopeChain()->globalData, callFrame, codeBlock, stubInfo, prototypeStructureList, listIndex, structure, protoChain, count, slot.cachedOffset());
if (listIndex == (POLYMORPHIC_LIST_CACHE_SIZE - 1))
ctiPatchCallByReturnAddress(STUB_RETURN_ADDRESS, FunctionPtr(cti_op_get_by_id_proto_list_full));
@@ -1072,6 +1210,7 @@ DEFINE_STUB_FUNCTION(void*, op_call_JSFunction)
#endif
JSFunction* function = asFunction(stackFrame.args[0].jsValue());
+ ASSERT(!function->isHostFunction());
FunctionBodyNode* body = function->body();
ScopeChainNode* callDataScopeChain = function->scope().node();
body->jitCode(callDataScopeChain);
@@ -1085,6 +1224,7 @@ DEFINE_STUB_FUNCTION(VoidPtrPair, op_call_arityCheck)
CallFrame* callFrame = stackFrame.callFrame;
CodeBlock* newCodeBlock = stackFrame.args[3].codeBlock();
+ ASSERT(newCodeBlock->codeType() != NativeCode);
int argCount = stackFrame.args[2].int32();
ASSERT(argCount != newCodeBlock->m_numParameters);
@@ -1146,9 +1286,11 @@ DEFINE_STUB_FUNCTION(void*, vm_lazyLinkCall)
CodeBlock* codeBlock = 0;
if (!callee->isHostFunction())
codeBlock = &callee->body()->bytecode(callee->scope().node());
+ else
+ codeBlock = &callee->body()->generatedBytecode();
CallLinkInfo* callLinkInfo = &stackFrame.callFrame->callerFrame()->codeBlock()->getCallLinkInfo(stackFrame.args[1].returnAddress());
- JIT::linkCall(callee, codeBlock, jitCode, callLinkInfo, stackFrame.args[2].int32());
+ JIT::linkCall(callee, codeBlock, jitCode, callLinkInfo, stackFrame.args[2].int32(), stackFrame.globalData);
return jitCode.addressForCall().executableAddress();
}
@@ -1179,7 +1321,7 @@ DEFINE_STUB_FUNCTION(EncodedJSValue, op_call_NotJSFunction)
CallFrame* previousCallFrame = stackFrame.callFrame;
CallFrame* callFrame = CallFrame::create(previousCallFrame->registers() + registerOffset);
- callFrame->init(0, static_cast<Instruction*>(STUB_RETURN_ADDRESS), previousCallFrame->scopeChain(), previousCallFrame, 0, argCount, 0);
+ callFrame->init(0, static_cast<Instruction*>((STUB_RETURN_ADDRESS).value()), previousCallFrame->scopeChain(), previousCallFrame, 0, argCount, 0);
stackFrame.callFrame = callFrame;
Register* argv = stackFrame.callFrame->registers() - RegisterFile::CallFrameHeaderSize - argCount;
@@ -2234,7 +2376,7 @@ DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)
}
stackFrame.callFrame = callFrame;
- void* catchRoutine = handler->nativeCode.addressForExceptionHandler();
+ void* catchRoutine = handler->nativeCode.executableAddress();
ASSERT(catchRoutine);
STUB_SET_RETURN_ADDRESS(catchRoutine);
return JSValue::encode(exceptionValue);
@@ -2442,14 +2584,14 @@ DEFINE_STUB_FUNCTION(void*, op_switch_imm)
CodeBlock* codeBlock = callFrame->codeBlock();
if (scrutinee.isInt32Fast())
- return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(scrutinee.getInt32Fast()).addressForSwitch();
+ return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(scrutinee.getInt32Fast()).executableAddress();
else {
double value;
int32_t intValue;
if (scrutinee.getNumber(value) && ((intValue = static_cast<int32_t>(value)) == value))
- return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(intValue).addressForSwitch();
+ return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(intValue).executableAddress();
else
- return codeBlock->immediateSwitchJumpTable(tableIndex).ctiDefault.addressForSwitch();
+ return codeBlock->immediateSwitchJumpTable(tableIndex).ctiDefault.executableAddress();
}
}
@@ -2462,12 +2604,12 @@ DEFINE_STUB_FUNCTION(void*, op_switch_char)
CallFrame* callFrame = stackFrame.callFrame;
CodeBlock* codeBlock = callFrame->codeBlock();
- void* result = codeBlock->characterSwitchJumpTable(tableIndex).ctiDefault.addressForSwitch();
+ void* result = codeBlock->characterSwitchJumpTable(tableIndex).ctiDefault.executableAddress();
if (scrutinee.isString()) {
UString::Rep* value = asString(scrutinee)->value().rep();
if (value->size() == 1)
- result = codeBlock->characterSwitchJumpTable(tableIndex).ctiForValue(value->data()[0]).addressForSwitch();
+ result = codeBlock->characterSwitchJumpTable(tableIndex).ctiForValue(value->data()[0]).executableAddress();
}
return result;
@@ -2482,11 +2624,11 @@ DEFINE_STUB_FUNCTION(void*, op_switch_string)
CallFrame* callFrame = stackFrame.callFrame;
CodeBlock* codeBlock = callFrame->codeBlock();
- void* result = codeBlock->stringSwitchJumpTable(tableIndex).ctiDefault.addressForSwitch();
+ void* result = codeBlock->stringSwitchJumpTable(tableIndex).ctiDefault.executableAddress();
if (scrutinee.isString()) {
UString::Rep* value = asString(scrutinee)->value().rep();
- result = codeBlock->stringSwitchJumpTable(tableIndex).ctiForValue(value).addressForSwitch();
+ result = codeBlock->stringSwitchJumpTable(tableIndex).ctiForValue(value).executableAddress();
}
return result;
@@ -2590,7 +2732,7 @@ DEFINE_STUB_FUNCTION(EncodedJSValue, vm_throw)
}
stackFrame.callFrame = callFrame;
- void* catchRoutine = handler->nativeCode.addressForExceptionHandler();
+ void* catchRoutine = handler->nativeCode.executableAddress();
ASSERT(catchRoutine);
STUB_SET_RETURN_ADDRESS(catchRoutine);
return JSValue::encode(exceptionValue);
diff --git a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.h b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.h
index 48e5369..0493189 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.h
+++ b/src/3rdparty/webkit/JavaScriptCore/jit/JITStubs.h
@@ -68,7 +68,7 @@ namespace JSC {
FuncExprNode* funcExprNode() { return static_cast<FuncExprNode*>(asPointer); }
RegExp* regExp() { return static_cast<RegExp*>(asPointer); }
JSPropertyNameIterator* propertyNameIterator() { return static_cast<JSPropertyNameIterator*>(asPointer); }
- void* returnAddress() { return asPointer; }
+ ReturnAddressPtr returnAddress() { return ReturnAddressPtr(asPointer); }
};
#if PLATFORM(X86_64)
@@ -92,7 +92,7 @@ namespace JSC {
JSGlobalData* globalData;
// When JIT code makes a call, it pushes its return address just below the rest of the stack.
- void** returnAddressSlot() { return reinterpret_cast<void**>(this) - 1; }
+ ReturnAddressPtr* returnAddressSlot() { return reinterpret_cast<ReturnAddressPtr*>(this) - 1; }
};
#elif PLATFORM(X86)
struct JITStackFrame {
@@ -113,7 +113,30 @@ namespace JSC {
JSGlobalData* globalData;
// When JIT code makes a call, it pushes its return address just below the rest of the stack.
- void** returnAddressSlot() { return reinterpret_cast<void**>(this) - 1; }
+ ReturnAddressPtr* returnAddressSlot() { return reinterpret_cast<ReturnAddressPtr*>(this) - 1; }
+ };
+#elif PLATFORM_ARM_ARCH(7)
+ struct JITStackFrame {
+ JITStubArg padding; // Unused
+ JITStubArg args[6];
+
+ ReturnAddressPtr thunkReturnAddress;
+
+ void* preservedReturnAddress;
+ void* preservedR4;
+ void* preservedR5;
+ void* preservedR6;
+
+ // These arguments passed in r1..r3 (r0 contained the entry code pointed, which is not preserved)
+ RegisterFile* registerFile;
+ CallFrame* callFrame;
+ JSValue* exception;
+
+ // These arguments passed on the stack.
+ Profiler** enabledProfilerReference;
+ JSGlobalData* globalData;
+
+ ReturnAddressPtr* returnAddressSlot() { return &thunkReturnAddress; }
};
#else
#error "JITStackFrame not defined for this platform."
@@ -172,8 +195,8 @@ namespace JSC {
public:
JITThunks(JSGlobalData*);
- static void tryCacheGetByID(CallFrame*, CodeBlock*, void* returnAddress, JSValue baseValue, const Identifier& propertyName, const PropertySlot&);
- static void tryCachePutByID(CallFrame*, CodeBlock*, void* returnAddress, JSValue baseValue, const PutPropertySlot&);
+ static void tryCacheGetByID(CallFrame*, CodeBlock*, ReturnAddressPtr returnAddress, JSValue baseValue, const Identifier& propertyName, const PropertySlot&);
+ static void tryCachePutByID(CallFrame*, CodeBlock*, ReturnAddressPtr returnAddress, JSValue baseValue, const PutPropertySlot&);
MacroAssemblerCodePtr ctiArrayLengthTrampoline() { return m_ctiArrayLengthTrampoline; }
MacroAssemblerCodePtr ctiStringLengthTrampoline() { return m_ctiStringLengthTrampoline; }
diff --git a/src/3rdparty/webkit/JavaScriptCore/jsc.cpp b/src/3rdparty/webkit/JavaScriptCore/jsc.cpp
index 21a8c18..20d6694 100644
--- a/src/3rdparty/webkit/JavaScriptCore/jsc.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/jsc.cpp
@@ -52,7 +52,7 @@
#include <signal.h>
#endif
-#if COMPILER(MSVC) && !PLATFORM(WIN_CE)
+#if COMPILER(MSVC) && !PLATFORM(WINCE)
#include <crtdbg.h>
#include <windows.h>
#include <mmsystem.h>
@@ -75,6 +75,7 @@ static JSValue JSC_HOST_CALL functionGC(ExecState*, JSObject*, JSValue, const Ar
static JSValue JSC_HOST_CALL functionVersion(ExecState*, JSObject*, JSValue, const ArgList&);
static JSValue JSC_HOST_CALL functionRun(ExecState*, JSObject*, JSValue, const ArgList&);
static JSValue JSC_HOST_CALL functionLoad(ExecState*, JSObject*, JSValue, const ArgList&);
+static JSValue JSC_HOST_CALL functionCheckSyntax(ExecState*, JSObject*, JSValue, const ArgList&);
static JSValue JSC_HOST_CALL functionReadline(ExecState*, JSObject*, JSValue, const ArgList&);
static NO_RETURN JSValue JSC_HOST_CALL functionQuit(ExecState*, JSObject*, JSValue, const ArgList&);
@@ -184,6 +185,7 @@ GlobalObject::GlobalObject(const Vector<UString>& arguments)
putDirectFunction(globalExec(), new (globalExec()) NativeFunctionWrapper(globalExec(), prototypeFunctionStructure(), 1, Identifier(globalExec(), "version"), functionVersion));
putDirectFunction(globalExec(), new (globalExec()) NativeFunctionWrapper(globalExec(), prototypeFunctionStructure(), 1, Identifier(globalExec(), "run"), functionRun));
putDirectFunction(globalExec(), new (globalExec()) NativeFunctionWrapper(globalExec(), prototypeFunctionStructure(), 1, Identifier(globalExec(), "load"), functionLoad));
+ putDirectFunction(globalExec(), new (globalExec()) NativeFunctionWrapper(globalExec(), prototypeFunctionStructure(), 1, Identifier(globalExec(), "checkSyntax"), functionCheckSyntax));
putDirectFunction(globalExec(), new (globalExec()) NativeFunctionWrapper(globalExec(), prototypeFunctionStructure(), 0, Identifier(globalExec(), "readline"), functionReadline));
#if ENABLE(SAMPLING_FLAGS)
@@ -264,6 +266,22 @@ JSValue JSC_HOST_CALL functionLoad(ExecState* exec, JSObject* o, JSValue v, cons
return result.value();
}
+JSValue JSC_HOST_CALL functionCheckSyntax(ExecState* exec, JSObject* o, JSValue v, const ArgList& args)
+{
+ UNUSED_PARAM(o);
+ UNUSED_PARAM(v);
+ UString fileName = args.at(0).toString(exec);
+ Vector<char> script;
+ if (!fillBufferWithContentsOfFile(fileName, script))
+ return throwError(exec, GeneralError, "Could not open file.");
+
+ JSGlobalObject* globalObject = exec->lexicalGlobalObject();
+ Completion result = checkSyntax(globalObject->globalExec(), makeSource(script.data(), fileName));
+ if (result.complType() == Throw)
+ exec->setException(result.value());
+ return result.value();
+}
+
#if ENABLE(SAMPLING_FLAGS)
JSValue JSC_HOST_CALL functionSetSamplingFlags(ExecState* exec, JSObject*, JSValue, const ArgList& args)
{
@@ -332,7 +350,7 @@ int main(int argc, char** argv)
_CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_FILE);
#endif
-#if COMPILER(MSVC) && !PLATFORM(WIN_CE)
+#if COMPILER(MSVC) && !PLATFORM(WINCE)
timeBeginPeriod(1);
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/parser/Grammar.y b/src/3rdparty/webkit/JavaScriptCore/parser/Grammar.y
index 52dddde..c5ca425 100644
--- a/src/3rdparty/webkit/JavaScriptCore/parser/Grammar.y
+++ b/src/3rdparty/webkit/JavaScriptCore/parser/Grammar.y
@@ -80,7 +80,7 @@ static ExpressionNode* makeSubNode(void*, ExpressionNode*, ExpressionNode*, bool
static ExpressionNode* makeLeftShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static ExpressionNode* makeRightShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static StatementNode* makeVarStatementNode(void*, ExpressionNode*);
-static ExpressionNode* combineVarInitializers(void*, ExpressionNode* list, AssignResolveNode* init);
+static ExpressionNode* combineCommaNodes(void*, ExpressionNode* list, ExpressionNode* init);
#if COMPILER(MSVC)
@@ -778,17 +778,17 @@ AssignmentOperator:
Expr:
AssignmentExpr
- | Expr ',' AssignmentExpr { $$ = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
+ | Expr ',' AssignmentExpr { $$ = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
;
ExprNoIn:
AssignmentExprNoIn
- | ExprNoIn ',' AssignmentExprNoIn { $$ = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
+ | ExprNoIn ',' AssignmentExprNoIn { $$ = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
;
ExprNoBF:
AssignmentExprNoBF
- | ExprNoBF ',' AssignmentExpr { $$ = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
+ | ExprNoBF ',' AssignmentExpr { $$ = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, $1.m_node, $3.m_node), $1.m_features | $3.m_features, $1.m_numConstants + $3.m_numConstants); }
;
Statement:
@@ -854,7 +854,7 @@ VariableDeclarationList:
| VariableDeclarationList ',' IDENT Initializer
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *$3, $4.m_node, $4.m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, @3.first_column, @4.first_column + 1, @4.last_column);
- $$.m_node = combineVarInitializers(GLOBAL_DATA, $1.m_node, node);
+ $$.m_node = combineCommaNodes(GLOBAL_DATA, $1.m_node, node);
$$.m_varDeclarations = $1.m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, $$.m_varDeclarations, *$3, DeclarationStacks::HasInitializer);
$$.m_funcDeclarations = 0;
@@ -891,7 +891,7 @@ VariableDeclarationListNoIn:
| VariableDeclarationListNoIn ',' IDENT InitializerNoIn
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *$3, $4.m_node, $4.m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, @3.first_column, @4.first_column + 1, @4.last_column);
- $$.m_node = combineVarInitializers(GLOBAL_DATA, $1.m_node, node);
+ $$.m_node = combineCommaNodes(GLOBAL_DATA, $1.m_node, node);
$$.m_varDeclarations = $1.m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, $$.m_varDeclarations, *$3, DeclarationStacks::HasInitializer);
$$.m_funcDeclarations = 0;
@@ -2071,10 +2071,14 @@ static bool allowAutomaticSemicolon(Lexer& lexer, int yychar)
return yychar == CLOSEBRACE || yychar == 0 || lexer.prevTerminator();
}
-static ExpressionNode* combineVarInitializers(void* globalPtr, ExpressionNode* list, AssignResolveNode* init)
+static ExpressionNode* combineCommaNodes(void* globalPtr, ExpressionNode* list, ExpressionNode* init)
{
if (!list)
return init;
+ if (list->isCommaNode()) {
+ static_cast<CommaNode*>(list)->append(init);
+ return list;
+ }
return new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, list, init);
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/parser/Lexer.h b/src/3rdparty/webkit/JavaScriptCore/parser/Lexer.h
index 9c22a9c..0e1b618 100644
--- a/src/3rdparty/webkit/JavaScriptCore/parser/Lexer.h
+++ b/src/3rdparty/webkit/JavaScriptCore/parser/Lexer.h
@@ -23,9 +23,9 @@
#define Lexer_h
#include "Lookup.h"
-#include "SegmentedVector.h"
#include "SourceCode.h"
#include <wtf/ASCIICType.h>
+#include <wtf/SegmentedVector.h>
#include <wtf/Vector.h>
#include <wtf/unicode/Unicode.h>
@@ -108,7 +108,7 @@ namespace JSC {
int m_next2;
int m_next3;
- SegmentedVector<JSC::Identifier, initialIdentifierTableCapacity> m_identifiers;
+ WTF::SegmentedVector<JSC::Identifier, initialIdentifierTableCapacity> m_identifiers;
JSGlobalData* m_globalData;
diff --git a/src/3rdparty/webkit/JavaScriptCore/parser/NodeConstructors.h b/src/3rdparty/webkit/JavaScriptCore/parser/NodeConstructors.h
index ea1579b..d17da69 100644
--- a/src/3rdparty/webkit/JavaScriptCore/parser/NodeConstructors.h
+++ b/src/3rdparty/webkit/JavaScriptCore/parser/NodeConstructors.h
@@ -659,9 +659,9 @@ namespace JSC {
inline CommaNode::CommaNode(JSGlobalData* globalData, ExpressionNode* expr1, ExpressionNode* expr2)
: ExpressionNode(globalData)
- , m_expr1(expr1)
- , m_expr2(expr2)
{
+ m_expressions.append(expr1);
+ m_expressions.append(expr2);
}
inline ConstStatementNode::ConstStatementNode(JSGlobalData* globalData, ConstDeclNode* next)
diff --git a/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.cpp b/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.cpp
index 4ddf13a..ba6e1e0 100644
--- a/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.cpp
@@ -1186,8 +1186,10 @@ RegisterID* ReadModifyBracketNode::emitBytecode(BytecodeGenerator& generator, Re
RegisterID* CommaNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
{
- generator.emitNode(generator.ignoredResult(), m_expr1);
- return generator.emitNode(dst, m_expr2);
+ ASSERT(m_expressions.size() > 1);
+ for (size_t i = 0; i < m_expressions.size() - 1; i++)
+ generator.emitNode(generator.ignoredResult(), m_expressions[i]);
+ return generator.emitNode(dst, m_expressions.last());
}
// ------------------------------ ConstDeclNode ------------------------------------
@@ -1889,8 +1891,8 @@ void ProgramNode::generateBytecode(ScopeChainNode* scopeChainNode)
m_code.set(new ProgramCodeBlock(this, GlobalCode, globalObject, source().provider()));
- BytecodeGenerator generator(this, globalObject->debugger(), scopeChain, &globalObject->symbolTable(), m_code.get());
- generator.generate();
+ OwnPtr<BytecodeGenerator> generator(new BytecodeGenerator(this, globalObject->debugger(), scopeChain, &globalObject->symbolTable(), m_code.get()));
+ generator->generate();
destroyData();
}
@@ -1944,8 +1946,8 @@ void EvalNode::generateBytecode(ScopeChainNode* scopeChainNode)
m_code.set(new EvalCodeBlock(this, globalObject, source().provider(), scopeChain.localDepth()));
- BytecodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get());
- generator.generate();
+ OwnPtr<BytecodeGenerator> generator(new BytecodeGenerator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get()));
+ generator->generate();
// Eval code needs to hang on to its declaration stacks to keep declaration info alive until Interpreter::execute time,
// so the entire ScopeNodeData cannot be destoyed.
@@ -1961,9 +1963,9 @@ EvalCodeBlock& EvalNode::bytecodeForExceptionInfoReparse(ScopeChainNode* scopeCh
m_code.set(new EvalCodeBlock(this, globalObject, source().provider(), scopeChain.localDepth()));
- BytecodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get());
- generator.setRegeneratingForExceptionInfo(codeBlockBeingRegeneratedFrom);
- generator.generate();
+ OwnPtr<BytecodeGenerator> generator(new BytecodeGenerator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get()));
+ generator->setRegeneratingForExceptionInfo(codeBlockBeingRegeneratedFrom);
+ generator->generate();
return *m_code;
}
@@ -2037,11 +2039,17 @@ PassRefPtr<FunctionBodyNode> FunctionBodyNode::createNativeThunk(JSGlobalData* g
{
RefPtr<FunctionBodyNode> body = new FunctionBodyNode(globalData);
globalData->parser->arena().reset();
+ body->m_code.set(new CodeBlock(body.get()));
body->m_jitCode = JITCode(JITCode::HostFunction(globalData->jitStubs.ctiNativeCallThunk()));
return body.release();
}
#endif
+bool FunctionBodyNode::isHostFunction() const
+{
+ return m_code && m_code->codeType() == NativeCode;
+}
+
FunctionBodyNode* FunctionBodyNode::create(JSGlobalData* globalData)
{
return new FunctionBodyNode(globalData);
@@ -2071,8 +2079,8 @@ void FunctionBodyNode::generateBytecode(ScopeChainNode* scopeChainNode)
m_code.set(new CodeBlock(this, FunctionCode, source().provider(), source().startOffset()));
- BytecodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get());
- generator.generate();
+ OwnPtr<BytecodeGenerator> generator(new BytecodeGenerator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get()));
+ generator->generate();
destroyData();
}
@@ -2097,9 +2105,9 @@ CodeBlock& FunctionBodyNode::bytecodeForExceptionInfoReparse(ScopeChainNode* sco
m_code.set(new CodeBlock(this, FunctionCode, source().provider(), source().startOffset()));
- BytecodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get());
- generator.setRegeneratingForExceptionInfo(codeBlockBeingRegeneratedFrom);
- generator.generate();
+ OwnPtr<BytecodeGenerator> generator(new BytecodeGenerator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable(), m_code.get()));
+ generator->setRegeneratingForExceptionInfo(codeBlockBeingRegeneratedFrom);
+ generator->generate();
return *m_code;
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.h b/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.h
index cda1ee4..a9f88b7 100644
--- a/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.h
+++ b/src/3rdparty/webkit/JavaScriptCore/parser/Nodes.h
@@ -169,7 +169,8 @@ namespace JSC {
virtual bool isResolveNode() const { return false; }
virtual bool isBracketAccessorNode() const { return false; }
virtual bool isDotAccessorNode() const { return false; }
- virtual bool isFuncExprNode() const { return false; }
+ virtual bool isFuncExprNode() const { return false; }
+ virtual bool isCommaNode() const { return false; }
virtual bool isSimpleArray() const { return false; }
virtual bool isAdd() const { return false; }
@@ -1087,16 +1088,20 @@ namespace JSC {
Operator m_operator;
ExpressionNode* m_right;
};
+
+ typedef Vector<ExpressionNode*, 8> ExpressionVector;
class CommaNode : public ExpressionNode {
public:
CommaNode(JSGlobalData*, ExpressionNode* expr1, ExpressionNode* expr2);
+ void append(ExpressionNode* expr) { m_expressions.append(expr); }
+
private:
+ virtual bool isCommaNode() const { return true; }
virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0);
- ExpressionNode* m_expr1;
- ExpressionNode* m_expr2;
+ ExpressionVector m_expressions;
};
class ConstDeclNode : public ExpressionNode {
@@ -1554,14 +1559,7 @@ namespace JSC {
return m_code;
}
- bool isHostFunction() const
- {
-#if ENABLE(JIT)
- return !!m_jitCode && !m_code;
-#else
- return true;
-#endif
- }
+ bool isHostFunction() const;
virtual void mark();
diff --git a/src/3rdparty/webkit/JavaScriptCore/pcre/pcre_exec.cpp b/src/3rdparty/webkit/JavaScriptCore/pcre/pcre_exec.cpp
index 80a092a..af770f3 100644
--- a/src/3rdparty/webkit/JavaScriptCore/pcre/pcre_exec.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/pcre/pcre_exec.cpp
@@ -50,7 +50,7 @@ the JavaScript specification. There are also some supporting functions. */
#include <wtf/Vector.h>
#if REGEXP_HISTOGRAM
-#include <parser/DateMath.h>
+#include <wtf/DateMath.h>
#include <runtime/UString.h>
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/profiler/CallIdentifier.h b/src/3rdparty/webkit/JavaScriptCore/profiler/CallIdentifier.h
index c2c25d5..ba48c55 100644
--- a/src/3rdparty/webkit/JavaScriptCore/profiler/CallIdentifier.h
+++ b/src/3rdparty/webkit/JavaScriptCore/profiler/CallIdentifier.h
@@ -28,10 +28,11 @@
#define CallIdentifier_h
#include <runtime/UString.h>
+#include "FastAllocBase.h"
namespace JSC {
- struct CallIdentifier {
+ struct CallIdentifier : public FastAllocBase {
UString m_name;
UString m_url;
unsigned m_lineNumber;
diff --git a/src/3rdparty/webkit/JavaScriptCore/profiler/ProfileNode.cpp b/src/3rdparty/webkit/JavaScriptCore/profiler/ProfileNode.cpp
index bf0bbcb..19050aa 100644
--- a/src/3rdparty/webkit/JavaScriptCore/profiler/ProfileNode.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/profiler/ProfileNode.cpp
@@ -29,9 +29,9 @@
#include "config.h"
#include "ProfileNode.h"
-#include "DateMath.h"
#include "Profiler.h"
#include <stdio.h>
+#include <wtf/DateMath.h>
#if PLATFORM(WIN_OS)
#include <windows.h>
@@ -49,7 +49,7 @@ static double getCount()
QueryPerformanceCounter(&counter);
return static_cast<double>(counter.QuadPart) / frequency.QuadPart;
#else
- return getCurrentUTCTimeWithMicroseconds();
+ return WTF::getCurrentUTCTimeWithMicroseconds();
#endif
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/profiler/ProfilerServer.mm b/src/3rdparty/webkit/JavaScriptCore/profiler/ProfilerServer.mm
index ef16f4c..a3944de 100644
--- a/src/3rdparty/webkit/JavaScriptCore/profiler/ProfilerServer.mm
+++ b/src/3rdparty/webkit/JavaScriptCore/profiler/ProfilerServer.mm
@@ -28,9 +28,12 @@
#import "JSProfilerPrivate.h"
#import "JSRetainPtr.h"
-
#import <Foundation/Foundation.h>
+#if PLATFORM(IPHONE_SIMULATOR)
+#import <Foundation/NSDistributedNotificationCenter.h>
+#endif
+
@interface ProfilerServer : NSObject {
@private
NSString *_serverName;
@@ -62,16 +65,22 @@
if ([defaults boolForKey:@"EnableJSProfiling"])
[self startProfiling];
+#if !PLATFORM(IPHONE) || PLATFORM(IPHONE_SIMULATOR)
+ // FIXME: <rdar://problem/6546135>
// The catch-all notifications
[[NSDistributedNotificationCenter defaultCenter] addObserver:self selector:@selector(startProfiling) name:@"ProfilerServerStartNotification" object:nil];
[[NSDistributedNotificationCenter defaultCenter] addObserver:self selector:@selector(stopProfiling) name:@"ProfilerServerStopNotification" object:nil];
+#endif
// The specific notifications
NSProcessInfo *processInfo = [NSProcessInfo processInfo];
_serverName = [[NSString alloc] initWithFormat:@"ProfilerServer-%d", [processInfo processIdentifier]];
+#if !PLATFORM(IPHONE) || PLATFORM(IPHONE_SIMULATOR)
+ // FIXME: <rdar://problem/6546135>
[[NSDistributedNotificationCenter defaultCenter] addObserver:self selector:@selector(startProfiling) name:[_serverName stringByAppendingString:@"-Start"] object:nil];
[[NSDistributedNotificationCenter defaultCenter] addObserver:self selector:@selector(stopProfiling) name:[_serverName stringByAppendingString:@"-Stop"] object:nil];
+#endif
[pool drain];
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/ArgList.h b/src/3rdparty/webkit/JavaScriptCore/runtime/ArgList.h
index 8e85d7f..4d571fc 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/ArgList.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/ArgList.h
@@ -44,7 +44,8 @@ namespace JSC {
// Constructor for a read-write list, to which you may append values.
// FIXME: Remove all clients of this API, then remove this API.
MarkedArgumentBuffer()
- : m_markSet(0)
+ : m_isUsingInlineBuffer(true)
+ , m_markSet(0)
#ifndef NDEBUG
, m_isReadOnly(false)
#endif
@@ -57,6 +58,7 @@ namespace JSC {
MarkedArgumentBuffer(Register* buffer, size_t size)
: m_buffer(buffer)
, m_size(size)
+ , m_isUsingInlineBuffer(true)
, m_markSet(0)
#ifndef NDEBUG
, m_isReadOnly(true)
@@ -103,7 +105,7 @@ namespace JSC {
{
ASSERT(!m_isReadOnly);
- if (m_size < inlineCapacity) {
+ if (m_isUsingInlineBuffer && m_size < inlineCapacity) {
m_vector.uncheckedAppend(v);
++m_size;
} else {
@@ -111,9 +113,23 @@ namespace JSC {
// the performance of the fast "just append to inline buffer" case.
slowAppend(v);
++m_size;
+ m_isUsingInlineBuffer = false;
}
}
+ void removeLast()
+ {
+ ASSERT(m_size);
+ m_size--;
+ m_vector.removeLast();
+ }
+
+ JSValue last()
+ {
+ ASSERT(m_size);
+ return m_buffer[m_size - 1].jsValue();
+ }
+
iterator begin() { return m_buffer; }
iterator end() { return m_buffer + m_size; }
@@ -127,6 +143,7 @@ namespace JSC {
Register* m_buffer;
size_t m_size;
+ bool m_isUsingInlineBuffer;
VectorType m_vector;
ListSet* m_markSet;
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/Collector.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/Collector.cpp
index 1e5eab3..0ff97b8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/Collector.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/Collector.cpp
@@ -1,7 +1,6 @@
/*
* Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
* Copyright (C) 2007 Eric Seidel <eric@webkit.org>
- * Copyright (C) 2008 Torch Mobile, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -28,6 +27,7 @@
#include "Interpreter.h"
#include "JSGlobalObject.h"
#include "JSLock.h"
+#include "JSONObject.h"
#include "JSString.h"
#include "JSValue.h"
#include "Nodes.h"
@@ -409,54 +409,68 @@ void* Heap::allocateNumber(size_t s)
return heapAllocate<NumberHeap>(s);
}
-#if PLATFORM(WIN_CE)
-// Return the number of bytes that are writable starting at p.
-// The pointer p is assumed to be page aligned.
-static inline DWORD numberOfWritableBytes(void* p)
-{
- MEMORY_BASIC_INFORMATION buf;
- DWORD result = VirtualQuery(p, &buf, sizeof(buf));
- ASSERT(result == sizeof(buf));
- DWORD protect = (buf.Protect & ~(PAGE_GUARD | PAGE_NOCACHE));
-
- // check if the page is writable
- if (protect != PAGE_READWRITE && protect != PAGE_WRITECOPY &&
- protect != PAGE_EXECUTE_READWRITE && protect != PAGE_EXECUTE_WRITECOPY)
- return 0;
-
- if (buf.State != MEM_COMMIT)
- return 0;
+#if PLATFORM(WINCE)
+void* g_stackBase = 0;
- return buf.RegionSize;
-}
-
-static DWORD systemPageSize()
- {
- SYSTEM_INFO sysInfo;
- GetSystemInfo(&sysInfo);
- return sysInfo.dwPageSize;
+inline bool isPageWritable(void* page)
+{
+ MEMORY_BASIC_INFORMATION memoryInformation;
+ DWORD result = VirtualQuery(page, &memoryInformation, sizeof(memoryInformation));
+
+ // return false on error, including ptr outside memory
+ if (result != sizeof(memoryInformation))
+ return false;
+
+ DWORD protect = memoryInformation.Protect & ~(PAGE_GUARD | PAGE_NOCACHE);
+ return protect == PAGE_READWRITE
+ || protect == PAGE_WRITECOPY
+ || protect == PAGE_EXECUTE_READWRITE
+ || protect == PAGE_EXECUTE_WRITECOPY;
}
-static inline void* currentThreadStackBaseWinCE()
+static void* getStackBase(void* previousFrame)
{
- static DWORD pageSize = systemPageSize();
- int dummy;
- void* sp = &dummy;
- char* alignedStackPtr = reinterpret_cast<char*>((DWORD)sp & ~(pageSize - 1));
- DWORD size = 0;
- while (size = numberOfWritableBytes(alignedStackPtr))
- alignedStackPtr += size;
- return alignedStackPtr;
+ // find the address of this stack frame by taking the address of a local variable
+ bool isGrowingDownward;
+ void* thisFrame = (void*)(&isGrowingDownward);
+
+ isGrowingDownward = previousFrame < &thisFrame;
+ static DWORD pageSize = 0;
+ if (!pageSize) {
+ SYSTEM_INFO systemInfo;
+ GetSystemInfo(&systemInfo);
+ pageSize = systemInfo.dwPageSize;
+ }
+
+ // scan all of memory starting from this frame, and return the last writeable page found
+ register char* currentPage = (char*)((DWORD)thisFrame & ~(pageSize - 1));
+ if (isGrowingDownward) {
+ while (currentPage > 0) {
+ // check for underflow
+ if (currentPage >= (char*)pageSize)
+ currentPage -= pageSize;
+ else
+ currentPage = 0;
+ if (!isPageWritable(currentPage))
+ return currentPage + pageSize;
+ }
+ return 0;
+ } else {
+ while (true) {
+ // guaranteed to complete because isPageWritable returns false at end of memory
+ currentPage += pageSize;
+ if (!isPageWritable(currentPage))
+ return currentPage;
+ }
+ }
}
-#endif // PLATFORM(WIN_CE)
+#endif
static inline void* currentThreadStackBase()
{
#if PLATFORM(DARWIN)
pthread_t thread = pthread_self();
return pthread_get_stackaddr_np(thread);
-#elif PLATFORM(WIN_CE)
- return currentThreadStackBaseWinCE();
#elif PLATFORM(WIN_OS) && PLATFORM(X86) && COMPILER(MSVC)
// offset 0x18 from the FS segment register gives a pointer to
// the thread information block for the current thread
@@ -560,6 +574,13 @@ static inline void* currentThreadStackBase()
}
return static_cast<char*>(stackBase) + stackSize;
#endif
+#elif PLATFORM(WINCE)
+ if (g_stackBase)
+ return g_stackBase;
+ else {
+ int dummy;
+ return getStackBase(&dummy);
+ }
#else
#error Need a way to get the stack base on this platform
#endif
@@ -1094,6 +1115,8 @@ bool Heap::collect()
m_globalData->smallStrings.mark();
if (m_globalData->scopeNodeBeingReparsed)
m_globalData->scopeNodeBeingReparsed->mark();
+ if (m_globalData->firstStringifierToMark)
+ JSONObject::markStringifiers(m_globalData->firstStringifierToMark);
JAVASCRIPTCORE_GC_MARKED();
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.cpp
index fe0a830..3837817 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.cpp
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2003, 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2003, 2007, 2009 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -23,12 +23,13 @@
namespace JSC {
-const char* const nullCString = 0;
+static const char* const nullCString = 0;
#define INITIALIZE_PROPERTY_NAME(name) , name(globalData, #name)
CommonIdentifiers::CommonIdentifiers(JSGlobalData* globalData)
: nullIdentifier(globalData, nullCString)
+ , emptyIdentifier(globalData, "")
, underscoreProto(globalData, "__proto__")
, thisIdentifier(globalData, "this")
JSC_COMMON_IDENTIFIERS_EACH_PROPERTY_NAME(INITIALIZE_PROPERTY_NAME)
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.h b/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.h
index d4c5d52..408d819 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/CommonIdentifiers.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2003,2007 Apple Computer, Inc
+ * Copyright (C) 2003, 2007, 2009 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -59,6 +59,8 @@
macro(test) \
macro(toExponential) \
macro(toFixed) \
+ macro(toISOString) \
+ macro(toJSON) \
macro(toLocaleString) \
macro(toPrecision) \
macro(toString) \
@@ -75,6 +77,7 @@ namespace JSC {
public:
const Identifier nullIdentifier;
+ const Identifier emptyIdentifier;
const Identifier underscoreProto;
const Identifier thisIdentifier;
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateConstructor.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConstructor.cpp
index 54362d0..6d7d934 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DateConstructor.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConstructor.cpp
@@ -22,8 +22,8 @@
#include "config.h"
#include "DateConstructor.h"
+#include "DateConversion.h"
#include "DateInstance.h"
-#include "DateMath.h"
#include "DatePrototype.h"
#include "JSFunction.h"
#include "JSGlobalObject.h"
@@ -32,8 +32,13 @@
#include "PrototypeFunction.h"
#include <math.h>
#include <time.h>
+#include <wtf/DateMath.h>
#include <wtf/MathExtras.h>
+#if PLATFORM(WINCE) && !PLATFORM(QT)
+extern "C" time_t time(time_t* timer); //provided by libce
+#endif
+
#if HAVE(SYS_TIME_H)
#include <sys/time.h>
#endif
@@ -42,6 +47,8 @@
#include <sys/timeb.h>
#endif
+using namespace WTF;
+
namespace JSC {
// TODO: MakeTime (15.9.11.1) etc. ?
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.cpp
new file mode 100644
index 0000000..a725478
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.cpp
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
+ * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * The Original Code is Mozilla Communicator client code, released
+ * March 31, 1998.
+ *
+ * The Initial Developer of the Original Code is
+ * Netscape Communications Corporation.
+ * Portions created by the Initial Developer are Copyright (C) 1998
+ * the Initial Developer. All Rights Reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ * Alternatively, the contents of this file may be used under the terms
+ * of either the Mozilla Public License Version 1.1, found at
+ * http://www.mozilla.org/MPL/ (the "MPL") or the GNU General Public
+ * License Version 2.0, found at http://www.fsf.org/copyleft/gpl.html
+ * (the "GPL"), in which case the provisions of the MPL or the GPL are
+ * applicable instead of those above. If you wish to allow use of your
+ * version of this file only under the terms of one of those two
+ * licenses (the MPL or the GPL) and not to allow others to use your
+ * version of this file under the LGPL, indicate your decision by
+ * deletingthe provisions above and replace them with the notice and
+ * other provisions required by the MPL or the GPL, as the case may be.
+ * If you do not delete the provisions above, a recipient may use your
+ * version of this file under any of the LGPL, the MPL or the GPL.
+ */
+
+#include "config.h"
+#include "DateConversion.h"
+
+#include "UString.h"
+#include <wtf/DateMath.h>
+#include <wtf/StringExtras.h>
+
+using namespace WTF;
+
+namespace JSC {
+
+double parseDate(const UString &date)
+{
+ return parseDateFromNullTerminatedCharacters(date.UTF8String().c_str());
+}
+
+UString formatDate(const GregorianDateTime &t)
+{
+ char buffer[100];
+ snprintf(buffer, sizeof(buffer), "%s %s %02d %04d",
+ weekdayName[(t.weekDay + 6) % 7],
+ monthName[t.month], t.monthDay, t.year + 1900);
+ return buffer;
+}
+
+UString formatDateUTCVariant(const GregorianDateTime &t)
+{
+ char buffer[100];
+ snprintf(buffer, sizeof(buffer), "%s, %02d %s %04d",
+ weekdayName[(t.weekDay + 6) % 7],
+ t.monthDay, monthName[t.month], t.year + 1900);
+ return buffer;
+}
+
+UString formatTime(const GregorianDateTime &t, bool utc)
+{
+ char buffer[100];
+ if (utc) {
+ snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT", t.hour, t.minute, t.second);
+ } else {
+ int offset = abs(gmtoffset(t));
+ char timeZoneName[70];
+ struct tm gtm = t;
+ strftime(timeZoneName, sizeof(timeZoneName), "%Z", &gtm);
+
+ if (timeZoneName[0]) {
+ snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT%c%02d%02d (%s)",
+ t.hour, t.minute, t.second,
+ gmtoffset(t) < 0 ? '-' : '+', offset / (60*60), (offset / 60) % 60, timeZoneName);
+ } else {
+ snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT%c%02d%02d",
+ t.hour, t.minute, t.second,
+ gmtoffset(t) < 0 ? '-' : '+', offset / (60*60), (offset / 60) % 60);
+ }
+ }
+ return UString(buffer);
+}
+
+} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.h b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.h
new file mode 100644
index 0000000..0d12815
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DateConversion.h
@@ -0,0 +1,60 @@
+/*
+ * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
+ * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * The Original Code is Mozilla Communicator client code, released
+ * March 31, 1998.
+ *
+ * The Initial Developer of the Original Code is
+ * Netscape Communications Corporation.
+ * Portions created by the Initial Developer are Copyright (C) 1998
+ * the Initial Developer. All Rights Reserved.
+ *
+ * Contributor(s):
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either of the GNU General Public License Version 2 or later (the "GPL"),
+ * or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
+ * in which case the provisions of the GPL or the LGPL are applicable instead
+ * of those above. If you wish to allow use of your version of this file only
+ * under the terms of either the GPL or the LGPL, and not to allow others to
+ * use your version of this file under the terms of the MPL, indicate your
+ * decision by deleting the provisions above and replace them with the notice
+ * and other provisions required by the GPL or the LGPL. If you do not delete
+ * the provisions above, a recipient may use your version of this file under
+ * the terms of any one of the MPL, the GPL or the LGPL.
+ *
+ */
+
+#ifndef DateConversion_h
+#define DateConversion_h
+
+namespace WTF {
+ struct GregorianDateTime;
+}
+
+namespace JSC {
+
+class UString;
+
+double parseDate(const UString&);
+UString formatDate(const WTF::GregorianDateTime&);
+UString formatDateUTCVariant(const WTF::GregorianDateTime&);
+UString formatTime(const WTF::GregorianDateTime&, bool inputIsUTC);
+
+} // namespace JSC
+
+#endif // DateConversion_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.cpp
index 8806dec..62791ae 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.cpp
@@ -22,10 +22,12 @@
#include "config.h"
#include "DateInstance.h"
-#include "DateMath.h"
#include <math.h>
+#include <wtf/DateMath.h>
#include <wtf/MathExtras.h>
+using namespace WTF;
+
namespace JSC {
struct DateInstance::Cache {
@@ -58,13 +60,13 @@ void DateInstance::msToGregorianDateTime(double milli, bool outputIsUTC, Gregori
if (outputIsUTC) {
if (m_cache->m_gregorianDateTimeUTCCachedForMS != milli) {
- JSC::msToGregorianDateTime(milli, true, m_cache->m_cachedGregorianDateTimeUTC);
+ WTF::msToGregorianDateTime(milli, true, m_cache->m_cachedGregorianDateTimeUTC);
m_cache->m_gregorianDateTimeUTCCachedForMS = milli;
}
t.copyFrom(m_cache->m_cachedGregorianDateTimeUTC);
} else {
if (m_cache->m_gregorianDateTimeCachedForMS != milli) {
- JSC::msToGregorianDateTime(milli, false, m_cache->m_cachedGregorianDateTime);
+ WTF::msToGregorianDateTime(milli, false, m_cache->m_cachedGregorianDateTime);
m_cache->m_gregorianDateTimeCachedForMS = milli;
}
t.copyFrom(m_cache->m_cachedGregorianDateTime);
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.h b/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.h
index 0ecd1db..3b73521 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DateInstance.h
@@ -23,9 +23,11 @@
#include "JSWrapperObject.h"
-namespace JSC {
-
+namespace WTF {
struct GregorianDateTime;
+}
+
+namespace JSC {
class DateInstance : public JSWrapperObject {
public:
@@ -34,14 +36,14 @@ namespace JSC {
double internalNumber() const { return internalValue().uncheckedGetNumber(); }
- bool getTime(GregorianDateTime&, int& offset) const;
- bool getUTCTime(GregorianDateTime&) const;
+ bool getTime(WTF::GregorianDateTime&, int& offset) const;
+ bool getUTCTime(WTF::GregorianDateTime&) const;
bool getTime(double& milliseconds, int& offset) const;
bool getUTCTime(double& milliseconds) const;
static const ClassInfo info;
- void msToGregorianDateTime(double, bool outputIsUTC, GregorianDateTime&) const;
+ void msToGregorianDateTime(double, bool outputIsUTC, WTF::GregorianDateTime&) const;
private:
virtual const ClassInfo* classInfo() const { return &info; }
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DatePrototype.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/DatePrototype.cpp
index ff3fb19..e2482f4 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DatePrototype.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/DatePrototype.cpp
@@ -1,6 +1,7 @@
/*
* Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
* Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
+ * Copyright (C) 2008, 2009 Torch Mobile, Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -22,7 +23,7 @@
#include "config.h"
#include "DatePrototype.h"
-#include "DateMath.h"
+#include "DateConversion.h"
#include "Error.h"
#include "JSString.h"
#include "ObjectPrototype.h"
@@ -38,6 +39,7 @@
#include <math.h>
#include <time.h>
#include <wtf/Assertions.h>
+#include <wtf/DateMath.h>
#include <wtf/MathExtras.h>
#include <wtf/StringExtras.h>
#include <wtf/UnusedParam.h>
@@ -58,6 +60,10 @@
#include <CoreFoundation/CoreFoundation.h>
#endif
+#if PLATFORM(WINCE) && !PLATFORM(QT)
+extern "C" size_t strftime(char * const s, const size_t maxsize, const char * const format, const struct tm * const t); //provided by libce
+#endif
+
using namespace WTF;
namespace JSC {
@@ -107,6 +113,9 @@ static JSValue JSC_HOST_CALL dateProtoFuncToLocaleTimeString(ExecState*, JSObjec
static JSValue JSC_HOST_CALL dateProtoFuncToString(ExecState*, JSObject*, JSValue, const ArgList&);
static JSValue JSC_HOST_CALL dateProtoFuncToTimeString(ExecState*, JSObject*, JSValue, const ArgList&);
static JSValue JSC_HOST_CALL dateProtoFuncToUTCString(ExecState*, JSObject*, JSValue, const ArgList&);
+static JSValue JSC_HOST_CALL dateProtoFuncToISOString(ExecState*, JSObject*, JSValue, const ArgList&);
+
+static JSValue JSC_HOST_CALL dateProtoFuncToJSON(ExecState*, JSObject*, JSValue, const ArgList&);
}
@@ -189,6 +198,9 @@ static JSCell* formatLocaleDate(ExecState* exec, const GregorianDateTime& gdt, L
{
#if HAVE(LANGINFO_H)
static const nl_item formats[] = { D_T_FMT, D_FMT, T_FMT };
+#elif PLATFORM(WINCE) && !PLATFORM(QT)
+ // strftime() we are using does not support #
+ static const char* const formatStrings[] = { "%c", "%x", "%X" };
#else
static const char* const formatStrings[] = { "%#c", "%#x", "%X" };
#endif
@@ -333,6 +345,7 @@ const ClassInfo DatePrototype::info = {"Date", &DateInstance::info, 0, ExecState
/* Source for DatePrototype.lut.h
@begin dateTable
toString dateProtoFuncToString DontEnum|Function 0
+ toISOString dateProtoFuncToISOString DontEnum|Function 0
toUTCString dateProtoFuncToUTCString DontEnum|Function 0
toDateString dateProtoFuncToDateString DontEnum|Function 0
toTimeString dateProtoFuncToTimeString DontEnum|Function 0
@@ -376,6 +389,7 @@ const ClassInfo DatePrototype::info = {"Date", &DateInstance::info, 0, ExecState
setUTCFullYear dateProtoFuncSetUTCFullYear DontEnum|Function 3
setYear dateProtoFuncSetYear DontEnum|Function 1
getYear dateProtoFuncGetYear DontEnum|Function 0
+ toJSON dateProtoFuncToJSON DontEnum|Function 0
@end
*/
@@ -429,6 +443,28 @@ JSValue JSC_HOST_CALL dateProtoFuncToUTCString(ExecState* exec, JSObject*, JSVal
return jsNontrivialString(exec, formatDateUTCVariant(t) + " " + formatTime(t, utc));
}
+JSValue JSC_HOST_CALL dateProtoFuncToISOString(ExecState* exec, JSObject*, JSValue thisValue, const ArgList&)
+{
+ if (!thisValue.isObject(&DateInstance::info))
+ return throwError(exec, TypeError);
+
+ const bool utc = true;
+
+ DateInstance* thisDateObj = asDateInstance(thisValue);
+ double milli = thisDateObj->internalNumber();
+ if (!isfinite(milli))
+ return jsNontrivialString(exec, "Invalid Date");
+
+ GregorianDateTime t;
+ thisDateObj->msToGregorianDateTime(milli, utc, t);
+ // Maximum amount of space we need in buffer: 6 (max. digits in year) + 2 * 5 (2 characters each for month, day, hour, minute, second)
+ // 6 for formatting and one for null termination = 23. We add one extra character to allow us to force null termination.
+ char buffer[24];
+ snprintf(buffer, sizeof(buffer) - 1, "%04d-%02d-%02dT%02d:%02d:%02dZ", 1900 + t.year, t.month + 1, t.monthDay, t.hour, t.minute, t.second);
+ buffer[sizeof(buffer) - 1] = 0;
+ return jsNontrivialString(exec, buffer);
+}
+
JSValue JSC_HOST_CALL dateProtoFuncToDateString(ExecState* exec, JSObject*, JSValue thisValue, const ArgList&)
{
if (!thisValue.isObject(&DateInstance::info))
@@ -1043,4 +1079,27 @@ JSValue JSC_HOST_CALL dateProtoFuncGetYear(ExecState* exec, JSObject*, JSValue t
return jsNumber(exec, t.year);
}
+JSValue JSC_HOST_CALL dateProtoFuncToJSON(ExecState* exec, JSObject*, JSValue thisValue, const ArgList&)
+{
+ JSObject* object = thisValue.toThisObject(exec);
+ if (exec->hadException())
+ return jsNull();
+
+ JSValue toISOValue = object->get(exec, exec->globalData().propertyNames->toISOString);
+ if (exec->hadException())
+ return jsNull();
+
+ CallData callData;
+ CallType callType = toISOValue.getCallData(callData);
+ if (callType == CallTypeNone)
+ return throwError(exec, TypeError, "toISOString is not a function");
+
+ JSValue result = call(exec, asObject(toISOValue), callType, callData, object, exec->emptyList());
+ if (exec->hadException())
+ return jsNull();
+ if (result.isObject())
+ return throwError(exec, TypeError, "toISOString did not return a primitive value");
+ return result;
+}
+
} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/InitializeThreading.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/InitializeThreading.cpp
index cda9fb1..a0620e7 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/InitializeThreading.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/InitializeThreading.cpp
@@ -31,11 +31,11 @@
#include "JSImmediate.h"
#include "Collector.h"
-#include "DateMath.h"
#include "dtoa.h"
#include "Identifier.h"
#include "JSGlobalObject.h"
#include "UString.h"
+#include <wtf/DateMath.h>
#include <wtf/Threading.h>
using namespace WTF;
@@ -52,7 +52,7 @@ static void initializeThreadingOnce()
initializeUString();
#if ENABLE(JSC_MULTIPLE_THREADS)
s_dtoaP5Mutex = new Mutex;
- initDateMath();
+ WTF::initializeDates();
#endif
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSFunction.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSFunction.cpp
index f456451..b79074f 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSFunction.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSFunction.cpp
@@ -48,7 +48,7 @@ const ClassInfo JSFunction::info = { "Function", &InternalFunction::info, 0, 0 }
JSFunction::JSFunction(ExecState* exec, PassRefPtr<Structure> structure, int length, const Identifier& name, NativeFunction func)
: Base(&exec->globalData(), structure, name)
#if ENABLE(JIT)
- , m_body(exec->globalData().nativeFunctionThunk())
+ , m_body(FunctionBodyNode::createNativeThunk(&exec->globalData()))
#else
, m_body(0)
#endif
@@ -76,22 +76,19 @@ JSFunction::~JSFunction()
// JIT code for other functions may have had calls linked directly to the code for this function; these links
// are based on a check for the this pointer value for this JSFunction - which will no longer be valid once
// this memory is freed and may be reused (potentially for another, different JSFunction).
- if (!isHostFunction()) {
- if (m_body && m_body->isGenerated())
- m_body->generatedBytecode().unlinkCallers();
- scopeChain().~ScopeChain();
- }
-
+ if (m_body && m_body->isGenerated())
+ m_body->generatedBytecode().unlinkCallers();
#endif
+ if (!isHostFunction())
+ scopeChain().~ScopeChain();
}
void JSFunction::mark()
{
Base::mark();
- if (!isHostFunction()) {
- m_body->mark();
+ m_body->mark();
+ if (!isHostFunction())
scopeChain().mark();
- }
}
CallType JSFunction::getCallData(CallData& callData)
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.cpp
index 1594848..d5c4ee4 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.cpp
@@ -60,6 +60,7 @@ using namespace WTF;
namespace JSC {
extern const HashTable arrayTable;
+extern const HashTable jsonTable;
extern const HashTable dateTable;
extern const HashTable mathTable;
extern const HashTable numberTable;
@@ -105,6 +106,7 @@ JSGlobalData::JSGlobalData(bool isShared, const VPtrSet& vptrSet)
, clientData(0)
, arrayTable(fastNew<HashTable>(JSC::arrayTable))
, dateTable(fastNew<HashTable>(JSC::dateTable))
+ , jsonTable(fastNew<HashTable>(JSC::jsonTable))
, mathTable(fastNew<HashTable>(JSC::mathTable))
, numberTable(fastNew<HashTable>(JSC::numberTable))
, regExpTable(fastNew<HashTable>(JSC::regExpTable))
@@ -137,6 +139,7 @@ JSGlobalData::JSGlobalData(bool isShared, const VPtrSet& vptrSet)
, head(0)
, dynamicGlobalObject(0)
, scopeNodeBeingReparsed(0)
+ , firstStringifierToMark(0)
{
#if PLATFORM(MAC)
startProfilerServerIfNeeded();
@@ -155,17 +158,16 @@ JSGlobalData::~JSGlobalData()
arrayTable->deleteTable();
dateTable->deleteTable();
+ jsonTable->deleteTable();
mathTable->deleteTable();
numberTable->deleteTable();
regExpTable->deleteTable();
regExpConstructorTable->deleteTable();
stringTable->deleteTable();
-#if ENABLE(JIT)
- lazyNativeFunctionThunk.clear();
-#endif
fastDelete(const_cast<HashTable*>(arrayTable));
fastDelete(const_cast<HashTable*>(dateTable));
+ fastDelete(const_cast<HashTable*>(jsonTable));
fastDelete(const_cast<HashTable*>(mathTable));
fastDelete(const_cast<HashTable*>(numberTable));
fastDelete(const_cast<HashTable*>(regExpTable));
@@ -222,15 +224,6 @@ JSGlobalData*& JSGlobalData::sharedInstanceInternal()
return sharedInstance;
}
-#if ENABLE(JIT)
-
-void JSGlobalData::createNativeThunk()
-{
- lazyNativeFunctionThunk = FunctionBodyNode::createNativeThunk(this);
-}
-
-#endif
-
// FIXME: We can also detect forms like v1 < v2 ? -1 : 0, reverse comparison, etc.
const Vector<Instruction>& JSGlobalData::numericCompareFunction(ExecState* exec)
{
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.h b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.h
index e53746b..96a3c2c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalData.h
@@ -54,8 +54,10 @@ namespace JSC {
class Lexer;
class Parser;
class ScopeNode;
+ class Stringifier;
class Structure;
class UString;
+
struct HashTable;
struct VPtrSet;
@@ -82,6 +84,7 @@ namespace JSC {
const HashTable* arrayTable;
const HashTable* dateTable;
+ const HashTable* jsonTable;
const HashTable* mathTable;
const HashTable* numberTable;
const HashTable* regExpTable;
@@ -117,20 +120,13 @@ namespace JSC {
Interpreter* interpreter;
#if ENABLE(JIT)
JITThunks jitStubs;
- FunctionBodyNode* nativeFunctionThunk()
- {
- if (!lazyNativeFunctionThunk)
- createNativeThunk();
- return lazyNativeFunctionThunk.get();
- }
- RefPtr<FunctionBodyNode> lazyNativeFunctionThunk;
#endif
TimeoutChecker timeoutChecker;
Heap heap;
JSValue exception;
#if ENABLE(JIT)
- void* exceptionLocation;
+ ReturnAddressPtr exceptionLocation;
#endif
const Vector<Instruction>& numericCompareFunction(ExecState*);
@@ -145,6 +141,7 @@ namespace JSC {
HashSet<JSObject*> arrayVisitedElements;
ScopeNode* scopeNodeBeingReparsed;
+ Stringifier* firstStringifierToMark;
private:
JSGlobalData(bool isShared, const VPtrSet&);
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.cpp
index 1e9f670..c56b84b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.cpp
@@ -50,6 +50,7 @@
#include "JSFunction.h"
#include "JSGlobalObjectFunctions.h"
#include "JSLock.h"
+#include "JSONObject.h"
#include "Interpreter.h"
#include "MathObject.h"
#include "NativeErrorConstructor.h"
@@ -318,7 +319,8 @@ void JSGlobalObject::reset(JSValue prototype)
GlobalPropertyInfo(Identifier(exec, "Math"), new (exec) MathObject(exec, MathObject::createStructure(d()->objectPrototype)), DontEnum | DontDelete),
GlobalPropertyInfo(Identifier(exec, "NaN"), jsNaN(exec), DontEnum | DontDelete),
GlobalPropertyInfo(Identifier(exec, "Infinity"), jsNumber(exec, Inf), DontEnum | DontDelete),
- GlobalPropertyInfo(Identifier(exec, "undefined"), jsUndefined(), DontEnum | DontDelete)
+ GlobalPropertyInfo(Identifier(exec, "undefined"), jsUndefined(), DontEnum | DontDelete),
+ GlobalPropertyInfo(Identifier(exec, "JSON"), new (exec) JSONObject(JSONObject::createStructure(d()->objectPrototype)), DontEnum | DontDelete)
};
addStaticGlobals(staticGlobals, sizeof(staticGlobals) / sizeof(GlobalPropertyInfo));
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.h b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.h
index da9a819..983274b 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObject.h
@@ -169,7 +169,7 @@ namespace JSC {
virtual void mark();
virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
- virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&, bool& slotIsWriteable);
+ virtual bool hasOwnPropertyForWrite(ExecState*, const Identifier&);
virtual void put(ExecState*, const Identifier&, JSValue, PutPropertySlot&);
virtual void putWithAttributes(ExecState*, const Identifier& propertyName, JSValue value, unsigned attributes);
@@ -325,10 +325,12 @@ namespace JSC {
return symbolTableGet(propertyName, slot);
}
- inline bool JSGlobalObject::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot, bool& slotIsWriteable)
+ inline bool JSGlobalObject::hasOwnPropertyForWrite(ExecState* exec, const Identifier& propertyName)
{
- if (JSVariableObject::getOwnPropertySlotForWrite(exec, propertyName, slot, slotIsWriteable))
+ PropertySlot slot;
+ if (JSVariableObject::getOwnPropertySlot(exec, propertyName, slot))
return true;
+ bool slotIsWriteable;
return symbolTableGet(propertyName, slot, slotIsWriteable);
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
index b013957..85f92f2 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
@@ -282,7 +282,7 @@ JSValue JSC_HOST_CALL globalFuncEval(ExecState* exec, JSObject* function, JSValu
UString s = x.toString(exec);
- LiteralParser preparser(exec, s);
+ LiteralParser preparser(exec, s, LiteralParser::NonStrictJSON);
if (JSValue parsedObject = preparser.tryLiteralParse())
return parsedObject;
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.cpp
new file mode 100644
index 0000000..4a89c55
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.cpp
@@ -0,0 +1,766 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSONObject.h"
+
+#include "BooleanObject.h"
+#include "Error.h"
+#include "ExceptionHelpers.h"
+#include "JSArray.h"
+#include "LiteralParser.h"
+#include "PropertyNameArray.h"
+#include <wtf/MathExtras.h>
+
+namespace JSC {
+
+ASSERT_CLASS_FITS_IN_CELL(JSONObject);
+
+static JSValue JSC_HOST_CALL JSONProtoFuncParse(ExecState*, JSObject*, JSValue, const ArgList&);
+static JSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState*, JSObject*, JSValue, const ArgList&);
+
+}
+
+#include "JSONObject.lut.h"
+
+namespace JSC {
+
+// PropertyNameForFunctionCall objects must be on the stack, since the JSValue that they create is not marked.
+class PropertyNameForFunctionCall {
+public:
+ PropertyNameForFunctionCall(const Identifier&);
+ PropertyNameForFunctionCall(unsigned);
+
+ JSValue value(ExecState*) const;
+
+private:
+ const Identifier* m_identifier;
+ unsigned m_number;
+ mutable JSValue m_value;
+};
+
+class Stringifier : Noncopyable {
+public:
+ Stringifier(ExecState*, JSValue replacer, JSValue space);
+ ~Stringifier();
+ JSValue stringify(JSValue);
+
+ void mark();
+
+private:
+ typedef UString StringBuilder;
+
+ class Holder {
+ public:
+ Holder(JSObject*);
+
+ JSObject* object() const { return m_object; }
+
+ bool appendNextProperty(Stringifier&, StringBuilder&);
+
+ private:
+ JSObject* const m_object;
+ const bool m_isArray;
+ bool m_isJSArray;
+ unsigned m_index;
+ unsigned m_size;
+ RefPtr<PropertyNameArrayData> m_propertyNames;
+ };
+
+ friend class Holder;
+
+ static void appendQuotedString(StringBuilder&, const UString&);
+
+ JSValue toJSON(JSValue, const PropertyNameForFunctionCall&);
+
+ enum StringifyResult { StringifyFailed, StringifySucceeded, StringifyFailedDueToUndefinedValue };
+ StringifyResult appendStringifiedValue(StringBuilder&, JSValue, JSObject* holder, const PropertyNameForFunctionCall&);
+
+ bool willIndent() const;
+ void indent();
+ void unindent();
+ void startNewLine(StringBuilder&) const;
+
+ Stringifier* const m_nextStringifierToMark;
+ ExecState* const m_exec;
+ const JSValue m_replacer;
+ bool m_usingArrayReplacer;
+ PropertyNameArray m_arrayReplacerPropertyNames;
+ CallType m_replacerCallType;
+ CallData m_replacerCallData;
+ const UString m_gap;
+
+ HashSet<JSObject*> m_holderCycleDetector;
+ Vector<Holder, 16> m_holderStack;
+ UString m_repeatedGap;
+ UString m_indent;
+};
+
+// ------------------------------ helper functions --------------------------------
+
+static inline JSValue unwrapBoxedPrimitive(JSValue value)
+{
+ if (!value.isObject())
+ return value;
+ if (!asObject(value)->inherits(&NumberObject::info) && !asObject(value)->inherits(&StringObject::info) && !asObject(value)->inherits(&BooleanObject::info))
+ return value;
+ return static_cast<JSWrapperObject*>(asObject(value))->internalValue();
+}
+
+static inline UString gap(JSValue space)
+{
+ space = unwrapBoxedPrimitive(space);
+
+ // If the space value is a number, create a gap string with that number of spaces.
+ double spaceCount;
+ if (space.getNumber(spaceCount)) {
+ const int maxSpaceCount = 100;
+ int count;
+ if (spaceCount > maxSpaceCount)
+ count = maxSpaceCount;
+ else if (!(spaceCount > 0))
+ count = 0;
+ else
+ count = static_cast<int>(spaceCount);
+ UChar spaces[maxSpaceCount];
+ for (int i = 0; i < count; ++i)
+ spaces[i] = ' ';
+ return UString(spaces, count);
+ }
+
+ // If the space value is a string, use it as the gap string, otherwise use no gap string.
+ return space.getString();
+}
+
+// ------------------------------ PropertyNameForFunctionCall --------------------------------
+
+inline PropertyNameForFunctionCall::PropertyNameForFunctionCall(const Identifier& identifier)
+ : m_identifier(&identifier)
+{
+}
+
+inline PropertyNameForFunctionCall::PropertyNameForFunctionCall(unsigned number)
+ : m_identifier(0)
+ , m_number(number)
+{
+}
+
+JSValue PropertyNameForFunctionCall::value(ExecState* exec) const
+{
+ if (!m_value) {
+ if (m_identifier)
+ m_value = jsString(exec, m_identifier->ustring());
+ else
+ m_value = jsNumber(exec, m_number);
+ }
+ return m_value;
+}
+
+// ------------------------------ Stringifier --------------------------------
+
+Stringifier::Stringifier(ExecState* exec, JSValue replacer, JSValue space)
+ : m_nextStringifierToMark(exec->globalData().firstStringifierToMark)
+ , m_exec(exec)
+ , m_replacer(replacer)
+ , m_usingArrayReplacer(false)
+ , m_arrayReplacerPropertyNames(exec)
+ , m_replacerCallType(CallTypeNone)
+ , m_gap(gap(space))
+{
+ exec->globalData().firstStringifierToMark = this;
+
+ if (!m_replacer.isObject())
+ return;
+
+ if (asObject(m_replacer)->inherits(&JSArray::info)) {
+ m_usingArrayReplacer = true;
+ JSObject* array = asObject(m_replacer);
+ unsigned length = array->get(exec, exec->globalData().propertyNames->length).toUInt32(exec);
+ for (unsigned i = 0; i < length; ++i) {
+ JSValue name = array->get(exec, i);
+ if (exec->hadException())
+ break;
+ UString propertyName;
+ if (!name.getString(propertyName))
+ continue;
+ if (exec->hadException())
+ return;
+ m_arrayReplacerPropertyNames.add(Identifier(exec, propertyName));
+ }
+ return;
+ }
+
+ m_replacerCallType = asObject(m_replacer)->getCallData(m_replacerCallData);
+}
+
+Stringifier::~Stringifier()
+{
+ ASSERT(m_exec->globalData().firstStringifierToMark == this);
+ m_exec->globalData().firstStringifierToMark = m_nextStringifierToMark;
+}
+
+void Stringifier::mark()
+{
+ for (Stringifier* stringifier = this; stringifier; stringifier = stringifier->m_nextStringifierToMark) {
+ size_t size = m_holderStack.size();
+ for (size_t i = 0; i < size; ++i) {
+ JSObject* object = m_holderStack[i].object();
+ if (!object->marked())
+ object->mark();
+ }
+ }
+}
+
+JSValue Stringifier::stringify(JSValue value)
+{
+ JSObject* object = constructEmptyObject(m_exec);
+ if (m_exec->hadException())
+ return jsNull();
+
+ PropertyNameForFunctionCall emptyPropertyName(m_exec->globalData().propertyNames->emptyIdentifier);
+ object->putDirect(m_exec->globalData().propertyNames->emptyIdentifier, value);
+
+ StringBuilder result;
+ if (appendStringifiedValue(result, value, object, emptyPropertyName) != StringifySucceeded)
+ return jsUndefined();
+ if (m_exec->hadException())
+ return jsNull();
+
+ return jsString(m_exec, result);
+}
+
+void Stringifier::appendQuotedString(StringBuilder& builder, const UString& value)
+{
+ int length = value.size();
+
+ // String length plus 2 for quote marks plus 8 so we can accomodate a few escaped characters.
+ builder.reserveCapacity(builder.size() + length + 2 + 8);
+
+ builder.append('"');
+
+ const UChar* data = value.data();
+ for (int i = 0; i < length; ++i) {
+ int start = i;
+ while (i < length && (data[i] > 0x1F && data[i] != '"' && data[i] != '\\'))
+ ++i;
+ builder.append(data + start, i - start);
+ if (i >= length)
+ break;
+ switch (data[i]) {
+ case '\t':
+ builder.append('\\');
+ builder.append('t');
+ break;
+ case '\r':
+ builder.append('\\');
+ builder.append('r');
+ break;
+ case '\n':
+ builder.append('\\');
+ builder.append('n');
+ break;
+ case '\f':
+ builder.append('\\');
+ builder.append('f');
+ break;
+ case '\b':
+ builder.append('\\');
+ builder.append('b');
+ break;
+ case '"':
+ builder.append('\\');
+ builder.append('"');
+ break;
+ case '\\':
+ builder.append('\\');
+ builder.append('\\');
+ break;
+ default:
+ static const char hexDigits[] = "0123456789abcdef";
+ UChar ch = data[i];
+ UChar hex[] = { '\\', 'u', hexDigits[(ch >> 12) & 0xF], hexDigits[(ch >> 8) & 0xF], hexDigits[(ch >> 4) & 0xF], hexDigits[ch & 0xF] };
+ builder.append(hex, sizeof(hex) / sizeof(UChar));
+ break;
+ }
+ }
+
+ builder.append('"');
+}
+
+inline JSValue Stringifier::toJSON(JSValue value, const PropertyNameForFunctionCall& propertyName)
+{
+ ASSERT(!m_exec->hadException());
+ if (!value.isObject() || !asObject(value)->hasProperty(m_exec, m_exec->globalData().propertyNames->toJSON))
+ return value;
+
+ JSValue toJSONFunction = asObject(value)->get(m_exec, m_exec->globalData().propertyNames->toJSON);
+ if (m_exec->hadException())
+ return jsNull();
+
+ if (!toJSONFunction.isObject())
+ return value;
+
+ JSObject* object = asObject(toJSONFunction);
+ CallData callData;
+ CallType callType = object->getCallData(callData);
+ if (callType == CallTypeNone)
+ return value;
+
+ JSValue list[] = { propertyName.value(m_exec) };
+ ArgList args(list, sizeof(list) / sizeof(JSValue));
+ return call(m_exec, object, callType, callData, value, args);
+}
+
+Stringifier::StringifyResult Stringifier::appendStringifiedValue(StringBuilder& builder, JSValue value, JSObject* holder, const PropertyNameForFunctionCall& propertyName)
+{
+ // Call the toJSON function.
+ value = toJSON(value, propertyName);
+ if (m_exec->hadException())
+ return StringifyFailed;
+ if (value.isUndefined() && !holder->inherits(&JSArray::info))
+ return StringifyFailedDueToUndefinedValue;
+
+ // Call the replacer function.
+ if (m_replacerCallType != CallTypeNone) {
+ JSValue list[] = { propertyName.value(m_exec), value };
+ ArgList args(list, sizeof(list) / sizeof(JSValue));
+ value = call(m_exec, m_replacer, m_replacerCallType, m_replacerCallData, holder, args);
+ if (m_exec->hadException())
+ return StringifyFailed;
+ }
+
+ if (value.isNull()) {
+ builder.append("null");
+ return StringifySucceeded;
+ }
+
+ value = unwrapBoxedPrimitive(value);
+
+ if (value.isBoolean()) {
+ builder.append(value.getBoolean() ? "true" : "false");
+ return StringifySucceeded;
+ }
+
+ UString stringValue;
+ if (value.getString(stringValue)) {
+ appendQuotedString(builder, stringValue);
+ return StringifySucceeded;
+ }
+
+ double numericValue;
+ if (value.getNumber(numericValue)) {
+ if (!isfinite(numericValue))
+ builder.append("null");
+ else
+ builder.append(UString::from(numericValue));
+ return StringifySucceeded;
+ }
+
+ if (!value.isObject())
+ return StringifyFailed;
+
+ JSObject* object = asObject(value);
+
+ // Handle cycle detection, and put the holder on the stack.
+ if (!m_holderCycleDetector.add(object).second) {
+ throwError(m_exec, TypeError);
+ return StringifyFailed;
+ }
+ bool holderStackWasEmpty = m_holderStack.isEmpty();
+ m_holderStack.append(object);
+ if (!holderStackWasEmpty)
+ return StringifySucceeded;
+
+ // If this is the outermost call, then loop to handle everything on the holder stack.
+ TimeoutChecker localTimeoutChecker(m_exec->globalData().timeoutChecker);
+ localTimeoutChecker.reset();
+ unsigned tickCount = localTimeoutChecker.ticksUntilNextCheck();
+ do {
+ while (m_holderStack.last().appendNextProperty(*this, builder)) {
+ if (m_exec->hadException())
+ return StringifyFailed;
+ if (!--tickCount) {
+ if (localTimeoutChecker.didTimeOut(m_exec)) {
+ m_exec->setException(createInterruptedExecutionException(&m_exec->globalData()));
+ return StringifyFailed;
+ }
+ tickCount = localTimeoutChecker.ticksUntilNextCheck();
+ }
+ }
+ m_holderCycleDetector.remove(m_holderStack.last().object());
+ m_holderStack.removeLast();
+ } while (!m_holderStack.isEmpty());
+ return StringifySucceeded;
+}
+
+inline bool Stringifier::willIndent() const
+{
+ return !m_gap.isEmpty();
+}
+
+inline void Stringifier::indent()
+{
+ // Use a single shared string, m_repeatedGap, so we don't keep allocating new ones as we indent and unindent.
+ int newSize = m_indent.size() + m_gap.size();
+ if (newSize > m_repeatedGap.size())
+ m_repeatedGap.append(m_gap);
+ ASSERT(newSize <= m_repeatedGap.size());
+ m_indent = m_repeatedGap.substr(0, newSize);
+}
+
+inline void Stringifier::unindent()
+{
+ ASSERT(m_indent.size() >= m_gap.size());
+ m_indent = m_repeatedGap.substr(0, m_indent.size() - m_gap.size());
+}
+
+inline void Stringifier::startNewLine(StringBuilder& builder) const
+{
+ if (m_gap.isEmpty())
+ return;
+ builder.append('\n');
+ builder.append(m_indent);
+}
+
+inline Stringifier::Holder::Holder(JSObject* object)
+ : m_object(object)
+ , m_isArray(object->inherits(&JSArray::info))
+ , m_index(0)
+{
+}
+
+bool Stringifier::Holder::appendNextProperty(Stringifier& stringifier, StringBuilder& builder)
+{
+ ASSERT(m_index <= m_size);
+
+ ExecState* exec = stringifier.m_exec;
+
+ // First time through, initialize.
+ if (!m_index) {
+ if (m_isArray) {
+ m_isJSArray = isJSArray(&exec->globalData(), m_object);
+ m_size = m_object->get(exec, exec->globalData().propertyNames->length).toUInt32(exec);
+ builder.append('[');
+ } else {
+ if (stringifier.m_usingArrayReplacer)
+ m_propertyNames = stringifier.m_arrayReplacerPropertyNames.data();
+ else {
+ PropertyNameArray objectPropertyNames(exec);
+ m_object->getPropertyNames(exec, objectPropertyNames);
+ m_propertyNames = objectPropertyNames.releaseData();
+ }
+ m_size = m_propertyNames->propertyNameVector().size();
+ builder.append('{');
+ }
+ stringifier.indent();
+ }
+
+ // Last time through, finish up and return false.
+ if (m_index == m_size) {
+ stringifier.unindent();
+ if (m_size && builder[builder.size() - 1] != '{')
+ stringifier.startNewLine(builder);
+ builder.append(m_isArray ? ']' : '}');
+ return false;
+ }
+
+ // Handle a single element of the array or object.
+ unsigned index = m_index++;
+ unsigned rollBackPoint = 0;
+ StringifyResult stringifyResult;
+ if (m_isArray) {
+ // Get the value.
+ JSValue value;
+ if (m_isJSArray && asArray(m_object)->canGetIndex(index))
+ value = asArray(m_object)->getIndex(index);
+ else {
+ PropertySlot slot(m_object);
+ if (!m_object->getOwnPropertySlot(exec, index, slot))
+ slot.setUndefined();
+ if (exec->hadException())
+ return false;
+ value = slot.getValue(exec, index);
+ }
+
+ // Append the separator string.
+ if (index)
+ builder.append(',');
+ stringifier.startNewLine(builder);
+
+ // Append the stringified value.
+ stringifyResult = stringifier.appendStringifiedValue(builder, value, m_object, index);
+ } else {
+ // Get the value.
+ PropertySlot slot(m_object);
+ Identifier& propertyName = m_propertyNames->propertyNameVector()[index];
+ if (!m_object->getOwnPropertySlot(exec, propertyName, slot))
+ return true;
+ JSValue value = slot.getValue(exec, propertyName);
+ if (exec->hadException())
+ return false;
+
+ rollBackPoint = builder.size();
+
+ // Append the separator string.
+ if (builder[rollBackPoint - 1] != '{')
+ builder.append(',');
+ stringifier.startNewLine(builder);
+
+ // Append the property name.
+ appendQuotedString(builder, propertyName.ustring());
+ builder.append(':');
+ if (stringifier.willIndent())
+ builder.append(' ');
+
+ // Append the stringified value.
+ stringifyResult = stringifier.appendStringifiedValue(builder, value, m_object, propertyName);
+ }
+
+ // From this point on, no access to the this pointer or to any members, because the
+ // Holder object may have moved if the call to stringify pushed a new Holder onto
+ // m_holderStack.
+
+ switch (stringifyResult) {
+ case StringifyFailed:
+ builder.append("null");
+ break;
+ case StringifySucceeded:
+ break;
+ case StringifyFailedDueToUndefinedValue:
+ // This only occurs when get an undefined value for an object property.
+ // In this case we don't want the separator and property name that we
+ // already appended, so roll back.
+ builder = builder.substr(0, rollBackPoint);
+ break;
+ }
+
+ return true;
+}
+
+// ------------------------------ JSONObject --------------------------------
+
+const ClassInfo JSONObject::info = { "JSON", 0, 0, ExecState::jsonTable };
+
+/* Source for JSONObject.lut.h
+@begin jsonTable
+ parse JSONProtoFuncParse DontEnum|Function 1
+ stringify JSONProtoFuncStringify DontEnum|Function 1
+@end
+*/
+
+// ECMA 15.8
+
+bool JSONObject::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ const HashEntry* entry = ExecState::jsonTable(exec)->entry(exec, propertyName);
+ if (!entry)
+ return JSObject::getOwnPropertySlot(exec, propertyName, slot);
+
+ ASSERT(entry->attributes() & Function);
+ setUpStaticFunctionSlot(exec, entry, this, propertyName, slot);
+ return true;
+}
+
+void JSONObject::markStringifiers(Stringifier* stringifier)
+{
+ stringifier->mark();
+}
+
+class Walker {
+public:
+ Walker(ExecState* exec, JSObject* function, CallType callType, CallData callData)
+ : m_exec(exec)
+ , m_function(function)
+ , m_callType(callType)
+ , m_callData(callData)
+ {
+ }
+ JSValue walk(JSValue unfiltered);
+private:
+ JSValue callReviver(JSValue property, JSValue unfiltered)
+ {
+ JSValue args[] = { property, unfiltered };
+ ArgList argList(args, 2);
+ return call(m_exec, m_function, m_callType, m_callData, jsNull(), argList);
+ }
+
+ friend class Holder;
+
+ ExecState* m_exec;
+ JSObject* m_function;
+ CallType m_callType;
+ CallData m_callData;
+};
+
+enum WalkerState { StateUnknown, ArrayStartState, ArrayStartVisitMember, ArrayEndVisitMember,
+ ObjectStartState, ObjectStartVisitMember, ObjectEndVisitMember };
+NEVER_INLINE JSValue Walker::walk(JSValue unfiltered)
+{
+ Vector<PropertyNameArray, 16> propertyStack;
+ Vector<uint32_t, 16> indexStack;
+ Vector<JSObject*, 16> objectStack;
+ Vector<JSArray*, 16> arrayStack;
+
+ Vector<WalkerState, 16> stateStack;
+ WalkerState state = StateUnknown;
+ JSValue inValue = unfiltered;
+ JSValue outValue = jsNull();
+ while (1) {
+ switch (state) {
+ arrayStartState:
+ case ArrayStartState: {
+ ASSERT(inValue.isObject());
+ ASSERT(isJSArray(&m_exec->globalData(), asObject(inValue)));
+ JSArray* array = asArray(inValue);
+ arrayStack.append(array);
+ indexStack.append(0);
+ // fallthrough
+ }
+ arrayStartVisitMember:
+ case ArrayStartVisitMember: {
+ JSArray* array = arrayStack.last();
+ uint32_t index = indexStack.last();
+ if (index == array->length()) {
+ outValue = array;
+ arrayStack.removeLast();
+ indexStack.removeLast();
+ break;
+ }
+ inValue = array->getIndex(index);
+ if (inValue.isObject()) {
+ stateStack.append(ArrayEndVisitMember);
+ goto stateUnknown;
+ } else
+ outValue = inValue;
+ // fallthrough
+ }
+ case ArrayEndVisitMember: {
+ JSArray* array = arrayStack.last();
+ array->setIndex(indexStack.last(), callReviver(jsString(m_exec, UString::from(indexStack.last())), outValue));
+ if (m_exec->hadException())
+ return jsNull();
+ indexStack.last()++;
+ goto arrayStartVisitMember;
+ }
+ objectStartState:
+ case ObjectStartState: {
+ ASSERT(inValue.isObject());
+ ASSERT(!isJSArray(&m_exec->globalData(), asObject(inValue)));
+ JSObject* object = asObject(inValue);
+ objectStack.append(object);
+ indexStack.append(0);
+ propertyStack.append(PropertyNameArray(m_exec));
+ object->getPropertyNames(m_exec, propertyStack.last());
+ // fallthrough
+ }
+ objectStartVisitMember:
+ case ObjectStartVisitMember: {
+ JSObject* object = objectStack.last();
+ uint32_t index = indexStack.last();
+ PropertyNameArray& properties = propertyStack.last();
+ if (index == properties.size()) {
+ outValue = object;
+ objectStack.removeLast();
+ indexStack.removeLast();
+ propertyStack.removeLast();
+ break;
+ }
+ PropertySlot slot;
+ object->getOwnPropertySlot(m_exec, properties[index], slot);
+ inValue = slot.getValue(m_exec, properties[index]);
+ ASSERT(!m_exec->hadException());
+ if (inValue.isObject()) {
+ stateStack.append(ObjectEndVisitMember);
+ goto stateUnknown;
+ } else
+ outValue = inValue;
+ // fallthrough
+ }
+ case ObjectEndVisitMember: {
+ JSObject* object = objectStack.last();
+ Identifier prop = propertyStack.last()[indexStack.last()];
+ PutPropertySlot slot;
+ object->put(m_exec, prop, callReviver(jsString(m_exec, prop.ustring()), outValue), slot);
+ if (m_exec->hadException())
+ return jsNull();
+ indexStack.last()++;
+ goto objectStartVisitMember;
+ }
+ stateUnknown:
+ case StateUnknown:
+ if (!inValue.isObject()) {
+ outValue = inValue;
+ break;
+ }
+ if (isJSArray(&m_exec->globalData(), asObject(inValue)))
+ goto arrayStartState;
+ goto objectStartState;
+ }
+ if (stateStack.isEmpty())
+ break;
+ state = stateStack.last();
+ stateStack.removeLast();
+ }
+ return callReviver(jsEmptyString(m_exec), outValue);
+}
+
+// ECMA-262 v5 15.12.2
+JSValue JSC_HOST_CALL JSONProtoFuncParse(ExecState* exec, JSObject*, JSValue, const ArgList& args)
+{
+ if (args.isEmpty())
+ return throwError(exec, GeneralError, "JSON.parse requires at least one parameter");
+ JSValue value = args.at(0);
+ UString source = value.toString(exec);
+ if (exec->hadException())
+ return jsNull();
+
+ LiteralParser jsonParser(exec, source, LiteralParser::StrictJSON);
+ JSValue unfiltered = jsonParser.tryLiteralParse();
+ if (!unfiltered)
+ return throwError(exec, SyntaxError, "Unable to parse JSON string");
+
+ if (args.size() < 2)
+ return unfiltered;
+
+ JSValue function = args.at(1);
+ CallData callData;
+ CallType callType = function.getCallData(callData);
+ if (callType == CallTypeNone)
+ return unfiltered;
+ return Walker(exec, asObject(function), callType, callData).walk(unfiltered);
+}
+
+// ECMA-262 v5 15.12.3
+JSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState* exec, JSObject*, JSValue, const ArgList& args)
+{
+ if (args.isEmpty())
+ return throwError(exec, GeneralError, "No input to stringify");
+ JSValue value = args.at(0);
+ JSValue replacer = args.at(1);
+ JSValue space = args.at(2);
+ return Stringifier(exec, replacer, space).stringify(value);
+}
+
+} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.h b/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.h
new file mode 100644
index 0000000..8d5364a
--- /dev/null
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSONObject.h
@@ -0,0 +1,58 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef JSONObject_h
+#define JSONObject_h
+
+#include "JSObject.h"
+
+namespace JSC {
+
+ class Stringifier;
+
+ class JSONObject : public JSObject {
+ public:
+ JSONObject(PassRefPtr<Structure> structure)
+ : JSObject(structure)
+ {
+ }
+
+ static PassRefPtr<Structure> createStructure(JSValue prototype)
+ {
+ return Structure::create(prototype, TypeInfo(ObjectType));
+ }
+
+ static void markStringifiers(Stringifier*);
+
+ private:
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+
+ virtual const ClassInfo* classInfo() const { return &info; }
+ static const ClassInfo info;
+ };
+
+} // namespace JSC
+
+#endif // JSONObject_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSObject.h b/src/3rdparty/webkit/JavaScriptCore/runtime/JSObject.h
index 54805f2..db47ac7 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSObject.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSObject.h
@@ -203,9 +203,6 @@ namespace JSC {
return Structure::create(prototype, TypeInfo(ObjectType, HasStandardGetOwnPropertySlot));
}
- protected:
- bool getOwnPropertySlotForWrite(ExecState*, const Identifier&, PropertySlot&, bool& slotIsWriteable);
-
private:
ConstPropertyStorage propertyStorage() const { return (isUsingInlineStorage() ? m_inlineStorage : m_externalStorage); }
PropertyStorage propertyStorage() { return (isUsingInlineStorage() ? m_inlineStorage : m_externalStorage); }
@@ -328,30 +325,6 @@ ALWAYS_INLINE bool JSObject::inlineGetOwnPropertySlot(ExecState* exec, const Ide
return false;
}
-ALWAYS_INLINE bool JSObject::getOwnPropertySlotForWrite(ExecState* exec, const Identifier& propertyName, PropertySlot& slot, bool& slotIsWriteable)
-{
- unsigned attributes;
- if (JSValue* location = getDirectLocation(propertyName, attributes)) {
- if (m_structure->hasGetterSetterProperties() && location[0].isGetterSetter()) {
- slotIsWriteable = false;
- fillGetterPropertySlot(slot, location);
- } else {
- slotIsWriteable = !(attributes & ReadOnly);
- slot.setValueSlot(this, location, offsetForLocation(location));
- }
- return true;
- }
-
- // non-standard Netscape extension
- if (propertyName == exec->propertyNames().underscoreProto) {
- slot.setValue(prototype());
- slotIsWriteable = false;
- return true;
- }
-
- return false;
-}
-
// It may seem crazy to inline a function this large, especially a virtual function,
// but it makes a big difference to property lookup that derived classes can inline their
// base class call to this.
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.cpp
index 0253fdd..85907c8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.cpp
@@ -76,9 +76,4 @@ inline bool JSStaticScopeObject::getOwnPropertySlot(ExecState*, const Identifier
return symbolTableGet(propertyName, slot);
}
-inline bool JSStaticScopeObject::getOwnPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot& slot, bool& slotIsWriteable)
-{
- return symbolTableGet(propertyName, slot, slotIsWriteable);
-}
-
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.h b/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.h
index 7e7ce65..2caf540 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/JSStaticScopeObject.h
@@ -54,7 +54,6 @@ namespace JSC{
bool isDynamicScope() const;
virtual JSObject* toThisObject(ExecState*) const;
virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
- virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&, bool& slotIsWriteable);
virtual void put(ExecState*, const Identifier&, JSValue, PutPropertySlot&);
void putWithAttributes(ExecState*, const Identifier&, JSValue, unsigned attributes);
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.cpp
index 10f9a13..3f3fab9 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.cpp
@@ -28,31 +28,12 @@
#include "JSArray.h"
#include "JSString.h"
+#include "Lexer.h"
#include <wtf/ASCIICType.h>
+#include <wtf/dtoa.h>
namespace JSC {
-class LiteralParser::StackGuard {
-public:
- StackGuard(LiteralParser* parser)
- : m_parser(parser)
- {
- m_parser->m_depth++;
- }
- ~StackGuard()
- {
- m_parser->m_depth--;
- }
- bool isSafe() { return m_parser->m_depth < 10; }
-private:
- LiteralParser* m_parser;
-};
-
-static bool isSafeStringCharacter(UChar c)
-{
- return (c >= ' ' && c <= 0xff && c != '\\') || c == '\t';
-}
-
LiteralParser::TokenType LiteralParser::Lexer::lex(LiteralParserToken& token)
{
while (m_ptr < m_end && isASCIISpace(*m_ptr))
@@ -100,8 +81,33 @@ LiteralParser::TokenType LiteralParser::Lexer::lex(LiteralParserToken& token)
token.end = ++m_ptr;
return TokColon;
case '"':
- return lexString(token);
-
+ if (m_mode == StrictJSON)
+ return lexString<StrictJSON>(token);
+ return lexString<NonStrictJSON>(token);
+ case 't':
+ if (m_end - m_ptr >= 4 && m_ptr[1] == 'r' && m_ptr[2] == 'u' && m_ptr[3] == 'e') {
+ m_ptr += 4;
+ token.type = TokTrue;
+ token.end = m_ptr;
+ return TokTrue;
+ }
+ break;
+ case 'f':
+ if (m_end - m_ptr >= 5 && m_ptr[1] == 'a' && m_ptr[2] == 'l' && m_ptr[3] == 's' && m_ptr[4] == 'e') {
+ m_ptr += 5;
+ token.type = TokFalse;
+ token.end = m_ptr;
+ return TokFalse;
+ }
+ break;
+ case 'n':
+ if (m_end - m_ptr >= 4 && m_ptr[1] == 'u' && m_ptr[2] == 'l' && m_ptr[3] == 'l') {
+ m_ptr += 4;
+ token.type = TokNull;
+ token.end = m_ptr;
+ return TokNull;
+ }
+ break;
case '-':
case '0':
case '1':
@@ -118,16 +124,80 @@ LiteralParser::TokenType LiteralParser::Lexer::lex(LiteralParserToken& token)
return TokError;
}
-LiteralParser::TokenType LiteralParser::Lexer::lexString(LiteralParserToken& token)
+static inline bool isSafeStringCharacter(UChar c)
+{
+ return (c >= ' ' && c <= 0xff && c != '\\' && c != '"') || c == '\t';
+}
+
+template <LiteralParser::ParserMode mode> LiteralParser::TokenType LiteralParser::Lexer::lexString(LiteralParserToken& token)
{
++m_ptr;
- while (m_ptr < m_end && isSafeStringCharacter(*m_ptr) && *m_ptr != '"')
- ++m_ptr;
- if (m_ptr >= m_end || *m_ptr != '"') {
- token.type = TokError;
- token.end = ++m_ptr;
+ const UChar* runStart;
+ token.stringToken = UString();
+ do {
+ runStart = m_ptr;
+ while (m_ptr < m_end && isSafeStringCharacter(*m_ptr))
+ ++m_ptr;
+ if (runStart < m_ptr)
+ token.stringToken.append(runStart, m_ptr - runStart);
+ if ((mode == StrictJSON) && m_ptr < m_end && *m_ptr == '\\') {
+ ++m_ptr;
+ if (m_ptr >= m_end)
+ return TokError;
+ switch (*m_ptr) {
+ case '"':
+ token.stringToken.append('"');
+ m_ptr++;
+ break;
+ case '\\':
+ token.stringToken.append('\\');
+ m_ptr++;
+ break;
+ case '/':
+ token.stringToken.append('/');
+ m_ptr++;
+ break;
+ case 'b':
+ token.stringToken.append('\b');
+ m_ptr++;
+ break;
+ case 'f':
+ token.stringToken.append('\f');
+ m_ptr++;
+ break;
+ case 'n':
+ token.stringToken.append('\n');
+ m_ptr++;
+ break;
+ case 'r':
+ token.stringToken.append('\r');
+ m_ptr++;
+ break;
+ case 't':
+ token.stringToken.append('\t');
+ m_ptr++;
+ break;
+
+ case 'u':
+ if ((m_end - m_ptr) < 5) // uNNNN == 5 characters
+ return TokError;
+ for (int i = 1; i < 5; i++) {
+ if (!isASCIIHexDigit(m_ptr[i]))
+ return TokError;
+ }
+ token.stringToken.append(JSC::Lexer::convertUnicode(m_ptr[1], m_ptr[2], m_ptr[3], m_ptr[4]));
+ m_ptr += 5;
+ break;
+
+ default:
+ return TokError;
+ }
+ }
+ } while ((mode == StrictJSON) && m_ptr != runStart && (m_ptr < m_end) && *m_ptr != '"');
+
+ if (m_ptr >= m_end || *m_ptr != '"')
return TokError;
- }
+
token.type = TokString;
token.end = ++m_ptr;
return TokString;
@@ -167,7 +237,7 @@ LiteralParser::TokenType LiteralParser::Lexer::lexNumber(LiteralParserToken& tok
if (m_ptr < m_end && *m_ptr == '.') {
++m_ptr;
// [0-9]+
- if (m_ptr >= m_end && !isASCIIDigit(*m_ptr))
+ if (m_ptr >= m_end || !isASCIIDigit(*m_ptr))
return TokError;
++m_ptr;
@@ -184,7 +254,7 @@ LiteralParser::TokenType LiteralParser::Lexer::lexNumber(LiteralParserToken& tok
++m_ptr;
// [0-9]+
- if (m_ptr >= m_end && !isASCIIDigit(*m_ptr))
+ if (m_ptr >= m_end || !isASCIIDigit(*m_ptr))
return TokError;
++m_ptr;
@@ -194,113 +264,186 @@ LiteralParser::TokenType LiteralParser::Lexer::lexNumber(LiteralParserToken& tok
token.type = TokNumber;
token.end = m_ptr;
+ Vector<char, 64> buffer(token.end - token.start + 1);
+ int i;
+ for (i = 0; i < token.end - token.start; i++) {
+ ASSERT(static_cast<char>(token.start[i]) == token.start[i]);
+ buffer[i] = static_cast<char>(token.start[i]);
+ }
+ buffer[i] = 0;
+ char* end;
+ token.numberToken = WTF::strtod(buffer.data(), &end);
+ ASSERT(buffer.data() + (token.end - token.start) == end);
return TokNumber;
}
-JSValue LiteralParser::parseStatement()
+JSValue LiteralParser::parse(ParserState initialState)
{
- StackGuard guard(this);
- if (!guard.isSafe())
- return abortParse();
+ ParserState state = initialState;
+ MarkedArgumentBuffer objectStack;
+ JSValue lastValue;
+ Vector<ParserState, 16> stateStack;
+ Vector<Identifier, 16> identifierStack;
+ while (1) {
+ switch(state) {
+ startParseArray:
+ case StartParseArray: {
+ JSArray* array = constructEmptyArray(m_exec);
+ objectStack.append(array);
+ // fallthrough
+ }
+ doParseArrayStartExpression:
+ case DoParseArrayStartExpression: {
+ if (m_lexer.next() == TokRBracket) {
+ m_lexer.next();
+ lastValue = objectStack.last();
+ objectStack.removeLast();
+ break;
+ }
- switch (m_lexer.currentToken().type) {
- case TokLBracket:
- case TokNumber:
- case TokString:
- return parseExpression();
- case TokLParen: {
- m_lexer.next();
- JSValue result = parseExpression();
- if (m_aborted || m_lexer.currentToken().type != TokRParen)
- return abortParse();
- m_lexer.next();
- return result;
- }
- default:
- return abortParse();
- }
-}
+ stateStack.append(DoParseArrayEndExpression);
+ goto startParseExpression;
+ }
+ case DoParseArrayEndExpression: {
+ asArray(objectStack.last())->push(m_exec, lastValue);
+
+ if (m_lexer.currentToken().type == TokComma)
+ goto doParseArrayStartExpression;
-JSValue LiteralParser::parseExpression()
-{
- StackGuard guard(this);
- if (!guard.isSafe())
- return abortParse();
- switch (m_lexer.currentToken().type) {
- case TokLBracket:
- return parseArray();
- case TokLBrace:
- return parseObject();
- case TokString: {
- Lexer::LiteralParserToken stringToken = m_lexer.currentToken();
- m_lexer.next();
- return jsString(m_exec, UString(stringToken.start + 1, stringToken.end - stringToken.start - 2));
- }
- case TokNumber: {
- Lexer::LiteralParserToken numberToken = m_lexer.currentToken();
- m_lexer.next();
- return jsNumber(m_exec, UString(numberToken.start, numberToken.end - numberToken.start).toDouble());
- }
- default:
- return JSValue();
- }
-}
+ if (m_lexer.currentToken().type != TokRBracket)
+ return JSValue();
+
+ m_lexer.next();
+ lastValue = objectStack.last();
+ objectStack.removeLast();
+ break;
+ }
+ startParseObject:
+ case StartParseObject: {
+ JSObject* object = constructEmptyObject(m_exec);
+ objectStack.append(object);
-JSValue LiteralParser::parseArray()
-{
- StackGuard guard(this);
- if (!guard.isSafe())
- return abortParse();
- JSArray* array = constructEmptyArray(m_exec);
- while (true) {
- m_lexer.next();
- JSValue value = parseExpression();
- if (m_aborted)
- return JSValue();
- if (!value)
- break;
- array->push(m_exec, value);
+ TokenType type = m_lexer.next();
+ if (type == TokString) {
+ Lexer::LiteralParserToken identifierToken = m_lexer.currentToken();
- if (m_lexer.currentToken().type != TokComma)
- break;
- }
- if (m_lexer.currentToken().type != TokRBracket)
- return abortParse();
+ // Check for colon
+ if (m_lexer.next() != TokColon)
+ return JSValue();
+
+ m_lexer.next();
+ identifierStack.append(Identifier(m_exec, identifierToken.stringToken));
+ stateStack.append(DoParseObjectEndExpression);
+ goto startParseExpression;
+ } else if (type != TokRBrace)
+ return JSValue();
+ m_lexer.next();
+ lastValue = objectStack.last();
+ objectStack.removeLast();
+ break;
+ }
+ doParseObjectStartExpression:
+ case DoParseObjectStartExpression: {
+ TokenType type = m_lexer.next();
+ if (type != TokString)
+ return JSValue();
+ Lexer::LiteralParserToken identifierToken = m_lexer.currentToken();
- m_lexer.next();
- return array;
-}
+ // Check for colon
+ if (m_lexer.next() != TokColon)
+ return JSValue();
-JSValue LiteralParser::parseObject()
-{
- StackGuard guard(this);
- if (!guard.isSafe())
- return abortParse();
- JSObject* object = constructEmptyObject(m_exec);
-
- while (m_lexer.next() == TokString) {
- Lexer::LiteralParserToken identifierToken = m_lexer.currentToken();
-
- // Check for colon
- if (m_lexer.next() != TokColon)
- return abortParse();
- m_lexer.next();
-
- JSValue value = parseExpression();
- if (!value || m_aborted)
- return abortParse();
-
- Identifier ident(m_exec, identifierToken.start + 1, identifierToken.end - identifierToken.start - 2);
- object->putDirect(ident, value);
-
- if (m_lexer.currentToken().type != TokComma)
- break;
+ m_lexer.next();
+ identifierStack.append(Identifier(m_exec, identifierToken.stringToken));
+ stateStack.append(DoParseObjectEndExpression);
+ goto startParseExpression;
+ }
+ case DoParseObjectEndExpression:
+ {
+ asObject(objectStack.last())->putDirect(identifierStack.last(), lastValue);
+ identifierStack.removeLast();
+ if (m_lexer.currentToken().type == TokComma)
+ goto doParseObjectStartExpression;
+ if (m_lexer.currentToken().type != TokRBrace)
+ return JSValue();
+ m_lexer.next();
+ lastValue = objectStack.last();
+ objectStack.removeLast();
+ break;
+ }
+ startParseExpression:
+ case StartParseExpression: {
+ switch (m_lexer.currentToken().type) {
+ case TokLBracket:
+ goto startParseArray;
+ case TokLBrace:
+ goto startParseObject;
+ case TokString: {
+ Lexer::LiteralParserToken stringToken = m_lexer.currentToken();
+ m_lexer.next();
+ lastValue = jsString(m_exec, stringToken.stringToken);
+ break;
+ }
+ case TokNumber: {
+ Lexer::LiteralParserToken numberToken = m_lexer.currentToken();
+ m_lexer.next();
+ lastValue = jsNumber(m_exec, numberToken.numberToken);
+ break;
+ }
+ case TokNull:
+ m_lexer.next();
+ lastValue = jsNull();
+ break;
+
+ case TokTrue:
+ m_lexer.next();
+ lastValue = jsBoolean(true);
+ break;
+
+ case TokFalse:
+ m_lexer.next();
+ lastValue = jsBoolean(false);
+ break;
+
+ default:
+ // Error
+ return JSValue();
+ }
+ break;
+ }
+ case StartParseStatement: {
+ switch (m_lexer.currentToken().type) {
+ case TokLBracket:
+ case TokNumber:
+ case TokString:
+ goto startParseExpression;
+
+ case TokLParen: {
+ m_lexer.next();
+ stateStack.append(StartParseStatementEndStatement);
+ goto startParseExpression;
+ }
+ default:
+ return JSValue();
+ }
+ }
+ case StartParseStatementEndStatement: {
+ ASSERT(stateStack.isEmpty());
+ if (m_lexer.currentToken().type != TokRParen)
+ return JSValue();
+ if (m_lexer.next() == TokEnd)
+ return lastValue;
+ return JSValue();
+ }
+ default:
+ ASSERT_NOT_REACHED();
+ }
+ if (stateStack.isEmpty())
+ return lastValue;
+ state = stateStack.last();
+ stateStack.removeLast();
+ continue;
}
-
- if (m_lexer.currentToken().type != TokRBrace)
- return abortParse();
- m_lexer.next();
- return object;
}
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.h b/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.h
index a72e3d0..bceee7c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/LiteralParser.h
@@ -34,27 +34,31 @@ namespace JSC {
class LiteralParser {
public:
- LiteralParser(ExecState* exec, const UString& s)
+ typedef enum { StrictJSON, NonStrictJSON } ParserMode;
+ LiteralParser(ExecState* exec, const UString& s, ParserMode mode)
: m_exec(exec)
- , m_lexer(s)
- , m_depth(0)
- , m_aborted(false)
+ , m_lexer(s, mode)
+ , m_mode(mode)
{
}
JSValue tryLiteralParse()
{
m_lexer.next();
- JSValue result = parseStatement();
- if (m_aborted || m_lexer.currentToken().type != TokEnd)
+ JSValue result = parse(m_mode == StrictJSON ? StartParseExpression : StartParseStatement);
+ if (m_lexer.currentToken().type != TokEnd)
return JSValue();
return result;
}
private:
-
+ enum ParserState { StartParseObject, StartParseArray, StartParseExpression,
+ StartParseStatement, StartParseStatementEndStatement,
+ DoParseObjectStartExpression, DoParseObjectEndExpression,
+ DoParseArrayStartExpression, DoParseArrayEndExpression };
enum TokenType { TokLBracket, TokRBracket, TokLBrace, TokRBrace,
TokString, TokIdentifier, TokNumber, TokColon,
- TokLParen, TokRParen, TokComma, TokEnd, TokError };
+ TokLParen, TokRParen, TokComma, TokTrue, TokFalse,
+ TokNull, TokEnd, TokError };
class Lexer {
public:
@@ -62,9 +66,12 @@ namespace JSC {
TokenType type;
const UChar* start;
const UChar* end;
+ UString stringToken;
+ double numberToken;
};
- Lexer(const UString& s)
+ Lexer(const UString& s, ParserMode mode)
: m_string(s)
+ , m_mode(mode)
, m_ptr(s.data())
, m_end(s.data() + s.size())
{
@@ -82,30 +89,21 @@ namespace JSC {
private:
TokenType lex(LiteralParserToken&);
- TokenType lexString(LiteralParserToken&);
+ template <ParserMode parserMode> TokenType lexString(LiteralParserToken&);
TokenType lexNumber(LiteralParserToken&);
LiteralParserToken m_currentToken;
UString m_string;
+ ParserMode m_mode;
const UChar* m_ptr;
const UChar* m_end;
};
class StackGuard;
- JSValue parseStatement();
- JSValue parseExpression();
- JSValue parseArray();
- JSValue parseObject();
-
- JSValue abortParse()
- {
- m_aborted = true;
- return JSValue();
- }
+ JSValue parse(ParserState);
ExecState* m_exec;
LiteralParser::Lexer m_lexer;
- int m_depth;
- bool m_aborted;
+ ParserMode m_mode;
};
}
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/PropertySlot.h b/src/3rdparty/webkit/JavaScriptCore/runtime/PropertySlot.h
index 7af60ce..da0d152 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/PropertySlot.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/PropertySlot.h
@@ -79,16 +79,6 @@ namespace JSC {
return m_offset;
}
- void putValue(JSValue value)
- {
- if (m_getValue == JSC_VALUE_SLOT_MARKER) {
- *m_data.valueSlot = value;
- return;
- }
- ASSERT(m_getValue == JSC_REGISTER_SLOT_MARKER);
- *m_data.registerSlot = JSValue(value);
- }
-
void setValueSlot(JSValue* valueSlot)
{
ASSERT(valueSlot);
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/ScopeChain.h b/src/3rdparty/webkit/JavaScriptCore/runtime/ScopeChain.h
index 6f1560a..17aff24 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/ScopeChain.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/ScopeChain.h
@@ -21,7 +21,7 @@
#ifndef ScopeChain_h
#define ScopeChain_h
-#include <wtf/Assertions.h>
+#include "FastAllocBase.h"
namespace JSC {
@@ -30,7 +30,7 @@ namespace JSC {
class JSObject;
class ScopeChainIterator;
- class ScopeChainNode {
+ class ScopeChainNode : public FastAllocBase {
public:
ScopeChainNode(ScopeChainNode* next, JSObject* object, JSGlobalData* globalData, JSObject* globalThis)
: next(next)
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/Structure.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/Structure.cpp
index 3597a5c..5dfd919 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/Structure.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/Structure.cpp
@@ -306,8 +306,11 @@ void Structure::getEnumerablePropertyNames(ExecState* exec, PropertyNameArray& p
}
if (shouldCache) {
+ StructureChain* protoChain = prototypeChain(exec);
m_cachedPropertyNameArrayData = propertyNames.data();
- m_cachedPropertyNameArrayData->setCachedPrototypeChain(prototypeChain(exec));
+ if (!protoChain->isCacheable())
+ return;
+ m_cachedPropertyNameArrayData->setCachedPrototypeChain(protoChain);
m_cachedPropertyNameArrayData->setCachedStructure(this);
}
}
@@ -407,6 +410,7 @@ PassRefPtr<Structure> Structure::addPropertyTransition(Structure* structure, con
if (structure->transitionCount() > s_maxTransitionLength) {
RefPtr<Structure> transition = toDictionaryTransition(structure);
+ ASSERT(structure != transition);
offset = transition->put(propertyName, attributes, specificValue);
if (transition->propertyStorageSize() > transition->propertyStorageCapacity())
transition->growPropertyStorageCapacity();
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.cpp
index 085876c..85049b1 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.cpp
@@ -46,4 +46,15 @@ StructureChain::StructureChain(Structure* head)
m_vector[i] = 0;
}
+bool StructureChain::isCacheable() const
+{
+ uint32_t i = 0;
+
+ while (m_vector[i]) {
+ if (m_vector[i++]->isDictionary())
+ return false;
+ }
+ return true;
+}
+
} // namespace JSC
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.h b/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.h
index 795e649..c48749d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/StructureChain.h
@@ -39,6 +39,7 @@ namespace JSC {
public:
static PassRefPtr<StructureChain> create(Structure* head) { return adoptRef(new StructureChain(head)); }
RefPtr<Structure>* head() { return m_vector.get(); }
+ bool isCacheable() const;
private:
StructureChain(Structure* head);
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/UString.cpp b/src/3rdparty/webkit/JavaScriptCore/runtime/UString.cpp
index 0eb46da..118751e 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/UString.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/UString.cpp
@@ -63,7 +63,7 @@ extern const double NaN;
extern const double Inf;
// This number must be at least 2 to avoid sharing empty, null as well as 1 character strings from SmallStrings.
-static const int minLengthToShare = 30;
+static const int minLengthToShare = 10;
static inline size_t overflowIndicator() { return std::numeric_limits<size_t>::max(); }
static inline size_t maxUChars() { return std::numeric_limits<size_t>::max() / sizeof(UChar); }
@@ -243,6 +243,15 @@ PassRefPtr<UString::Rep> UString::Rep::create(UChar* string, int length, PassRef
return rep;
}
+UString::SharedUChar* UString::Rep::sharedBuffer()
+{
+ UString::BaseString* base = baseString();
+ if (len < minLengthToShare)
+ return 0;
+
+ return base->sharedBuffer();
+}
+
void UString::Rep::destroy()
{
checkConsistency();
@@ -385,10 +394,6 @@ void UString::Rep::checkConsistency() const
UString::SharedUChar* UString::BaseString::sharedBuffer()
{
-
- if (len < minLengthToShare)
- return 0;
-
if (!m_sharedBuffer)
setSharedBuffer(SharedUChar::create(new OwnFastMallocPtr<UChar>(buf)));
return m_sharedBuffer;
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/UString.h b/src/3rdparty/webkit/JavaScriptCore/runtime/UString.h
index 6852d91..d01b75d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/UString.h
+++ b/src/3rdparty/webkit/JavaScriptCore/runtime/UString.h
@@ -107,6 +107,7 @@ namespace JSC {
// Uses SharedUChar to have joint ownership over the UChar*.
static PassRefPtr<Rep> create(UChar*, int, PassRefPtr<SharedUChar>);
+ SharedUChar* sharedBuffer();
void destroy();
bool baseIsSelf() const { return m_identifierTableAndFlags.isFlagSet(BaseStringFlag); }
@@ -192,7 +193,6 @@ namespace JSC {
struct BaseString : public Rep {
bool isShared() { return rc != 1 || isBufferReadOnly(); }
void setSharedBuffer(PassRefPtr<SharedUChar>);
- SharedUChar* sharedBuffer();
bool isBufferReadOnly()
{
@@ -224,6 +224,7 @@ namespace JSC {
checkConsistency();
}
+ SharedUChar* sharedBuffer();
bool slowIsBufferReadOnly();
friend struct Rep;
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.cpp
index 6e04fe1..098186e 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.cpp
@@ -34,7 +34,7 @@
#include <CoreFoundation/CFString.h>
#endif
-#if COMPILER(MSVC) && !PLATFORM(WIN_CE)
+#if COMPILER(MSVC) && !PLATFORM(WINCE)
#ifndef WINVER
#define WINVER 0x0500
#endif
@@ -54,7 +54,7 @@ static void vprintf_stderr_common(const char* format, va_list args)
if (strstr(format, "%@")) {
CFStringRef cfFormat = CFStringCreateWithCString(NULL, format, kCFStringEncodingUTF8);
CFStringRef str = CFStringCreateWithFormatAndArguments(NULL, NULL, cfFormat, args);
-
+
int length = CFStringGetMaximumSizeForEncoding(CFStringGetLength(str), kCFStringEncodingUTF8);
char* buffer = (char*)malloc(length + 1);
@@ -66,7 +66,7 @@ static void vprintf_stderr_common(const char* format, va_list args)
CFRelease(str);
CFRelease(cfFormat);
} else
-#elif COMPILER(MSVC) && !PLATFORM(WIN_CE)
+#elif COMPILER(MSVC) && !PLATFORM(WINCE)
if (IsDebuggerPresent()) {
size_t size = 1024;
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.h
index 9643517..ad66d06 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Assertions.h
@@ -128,7 +128,7 @@ void WTFLogVerbose(const char* file, int line, const char* function, WTFLogChann
/* ASSERT, ASSERT_WITH_MESSAGE, ASSERT_NOT_REACHED */
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE) && !PLATFORM(TORCHMOBILE)
/* FIXME: We include this here only to avoid a conflict with the ASSERT macro. */
#include <windows.h>
#undef min
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/CurrentTime.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/CurrentTime.cpp
index 7ce9d65..73c2c5c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/CurrentTime.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/CurrentTime.cpp
@@ -43,7 +43,7 @@
#if HAVE(SYS_TIMEB_H)
#include <sys/timeb.h>
#endif
-#if !PLATFORM(WIN_CE)
+#if !PLATFORM(WINCE)
#include <sys/types.h>
#endif
#include <time.h>
@@ -111,7 +111,7 @@ static double highResUpTime()
static double lowResUTCTime()
{
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
SYSTEMTIME systemTime;
GetSystemTime(&systemTime);
struct tm tmtime;
@@ -124,11 +124,11 @@ static double lowResUTCTime()
tmtime.tm_sec = systemTime.wSecond;
time_t timet = mktime(&tmtime);
return timet * msPerSecond + systemTime.wMilliseconds;
-#else // PLATFORM(WIN_CE)
+#else
struct _timeb timebuffer;
_ftime(&timebuffer);
return timebuffer.time * msPerSecond + timebuffer.millitm;
-#endif // PLATFORM(WIN_CE)
+#endif
}
static bool qpcAvailable()
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.cpp
index 2f8c88c..47c9d44 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.cpp
@@ -1,7 +1,8 @@
/*
* Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
* Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
- *
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
* The Original Code is Mozilla Communicator client code, released
* March 31, 1998.
*
@@ -42,15 +43,18 @@
#include "config.h"
#include "DateMath.h"
-#include "JSNumberCell.h"
-#include <math.h>
+#include "Assertions.h"
+#include "ASCIICType.h"
+#include "CurrentTime.h"
+#include "MathExtras.h"
+#include "StringExtras.h"
+
+#include <algorithm>
+#include <limits.h>
+#include <limits>
#include <stdint.h>
#include <time.h>
-#include <wtf/ASCIICType.h>
-#include <wtf/Assertions.h>
-#include <wtf/CurrentTime.h>
-#include <wtf/MathExtras.h>
-#include <wtf/StringExtras.h>
+
#if HAVE(ERRNO_H)
#include <errno.h>
@@ -68,9 +72,9 @@
#include <sys/timeb.h>
#endif
-using namespace WTF;
+#define NaN std::numeric_limits<double>::quiet_NaN()
-namespace JSC {
+namespace WTF {
/* Constants */
@@ -296,7 +300,7 @@ double getCurrentUTCTimeWithMicroseconds()
void getLocalTime(const time_t* localTime, struct tm* localTM)
{
-#if COMPILER(MSVC7) || COMPILER(MINGW) || PLATFORM(WIN_CE)
+#if COMPILER(MSVC7) || COMPILER(MINGW) || PLATFORM(WINCE)
*localTM = *localtime(localTime);
#elif COMPILER(MSVC)
localtime_s(localTM, localTime);
@@ -357,13 +361,29 @@ int equivalentYearForDST(int year)
static int32_t calculateUTCOffset()
{
+ time_t localTime = time(0);
tm localt;
- memset(&localt, 0, sizeof(localt));
-
- // get the difference between this time zone and UTC on Jan 01, 2000 12:00:00 AM
+ getLocalTime(&localTime, &localt);
+
+ // Get the difference between this time zone and UTC on the 1st of January of this year.
+ localt.tm_sec = 0;
+ localt.tm_min = 0;
+ localt.tm_hour = 0;
localt.tm_mday = 1;
- localt.tm_year = 100;
- time_t utcOffset = 946684800 - mktime(&localt);
+ localt.tm_mon = 0;
+ // Not setting localt.tm_year!
+ localt.tm_wday = 0;
+ localt.tm_yday = 0;
+ localt.tm_isdst = 0;
+#if PLATFORM(WIN_OS) || PLATFORM(SOLARIS) || COMPILER(RVCT)
+ // Using a canned date of 01/01/2009 on platforms with weaker date-handling foo.
+ localt.tm_year = 109;
+ time_t utcOffset = 1230768000 - mktime(&localt);
+#else
+ localt.tm_zone = 0;
+ localt.tm_gmtoff = 0;
+ time_t utcOffset = timegm(&localt) - mktime(&localt);
+#endif
return static_cast<int32_t>(utcOffset * 1000);
}
@@ -496,7 +516,7 @@ void msToGregorianDateTime(double ms, bool outputIsUTC, GregorianDateTime& tm)
tm.timeZone = NULL;
}
-void initDateMath()
+void initializeDates()
{
#ifndef NDEBUG
static bool alreadyInitialized;
@@ -592,7 +612,7 @@ static bool parseLong(const char* string, char** stopPosition, int base, long* r
return true;
}
-double parseDate(const UString &date)
+double parseDateFromNullTerminatedCharacters(const char* dateString)
{
// This parses a date in the form:
// Tuesday, 09-Nov-99 23:12:40 GMT
@@ -607,9 +627,6 @@ double parseDate(const UString &date)
// [Wednesday] January 09 23:12:40 GMT 1999
//
// We ignore the weekday.
-
- CString dateCString = date.UTF8String();
- const char *dateString = dateCString.c_str();
// Skip leading space
skipSpacesAndComments(dateString);
@@ -715,7 +732,7 @@ double parseDate(const UString &date)
if (!parseLong(dateString, &newPosStr, 10, &year))
return NaN;
}
-
+
// Don't fail if the time is missing.
long hour = 0;
long minute = 0;
@@ -772,7 +789,7 @@ double parseDate(const UString &date)
if (!parseLong(dateString, &newPosStr, 10, &second))
return NaN;
dateString = newPosStr;
-
+
if (second < 0 || second > 59)
return NaN;
}
@@ -848,9 +865,9 @@ double parseDate(const UString &date)
return NaN;
dateString = newPosStr;
}
-
+
skipSpacesAndComments(dateString);
-
+
// Trailing garbage
if (*dateString)
return NaN;
@@ -890,46 +907,5 @@ double timeClip(double t)
return trunc(t);
}
-UString formatDate(const GregorianDateTime &t)
-{
- char buffer[100];
- snprintf(buffer, sizeof(buffer), "%s %s %02d %04d",
- weekdayName[(t.weekDay + 6) % 7],
- monthName[t.month], t.monthDay, t.year + 1900);
- return buffer;
-}
-
-UString formatDateUTCVariant(const GregorianDateTime &t)
-{
- char buffer[100];
- snprintf(buffer, sizeof(buffer), "%s, %02d %s %04d",
- weekdayName[(t.weekDay + 6) % 7],
- t.monthDay, monthName[t.month], t.year + 1900);
- return buffer;
-}
-
-UString formatTime(const GregorianDateTime &t, bool utc)
-{
- char buffer[100];
- if (utc) {
- snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT", t.hour, t.minute, t.second);
- } else {
- int offset = abs(gmtoffset(t));
- char timeZoneName[70];
- struct tm gtm = t;
- strftime(timeZoneName, sizeof(timeZoneName), "%Z", &gtm);
-
- if (timeZoneName[0]) {
- snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT%c%02d%02d (%s)",
- t.hour, t.minute, t.second,
- gmtoffset(t) < 0 ? '-' : '+', offset / (60*60), (offset / 60) % 60, timeZoneName);
- } else {
- snprintf(buffer, sizeof(buffer), "%02d:%02d:%02d GMT%c%02d%02d",
- t.hour, t.minute, t.second,
- gmtoffset(t) < 0 ? '-' : '+', offset / (60*60), (offset / 60) % 60);
- }
- }
- return UString(buffer);
-}
-} // namespace JSC
+} // namespace WTF
diff --git a/src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.h b/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.h
index 8a15c80..8690a49 100644
--- a/src/3rdparty/webkit/JavaScriptCore/runtime/DateMath.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.h
@@ -1,6 +1,7 @@
/*
* Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
* Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2009 Google Inc. All rights reserved.
*
* Version: MPL 1.1/GPL 2.0/LGPL 2.1
*
@@ -45,12 +46,11 @@
#include <string.h>
#include <wtf/Noncopyable.h>
-namespace JSC {
+namespace WTF {
-class UString;
struct GregorianDateTime;
-void initDateMath();
+void initializeDates();
void msToGregorianDateTime(double, bool outputIsUTC, GregorianDateTime&);
double gregorianDateTimeToMS(const GregorianDateTime&, double, bool inputIsUTC);
double getUTCOffset();
@@ -60,12 +60,8 @@ double getCurrentUTCTimeWithMicroseconds();
void getLocalTime(const time_t*, tm*);
// Not really math related, but this is currently the only shared place to put these.
-double parseDate(const UString&);
+double parseDateFromNullTerminatedCharacters(const char*);
double timeClip(double);
-UString formatDate(const GregorianDateTime&);
-UString formatDateUTCVariant(const GregorianDateTime&);
-UString formatTime(const GregorianDateTime&, bool inputIsUTC);
-
const char * const weekdayName[7] = { "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun" };
const char * const monthName[12] = { "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec" };
@@ -186,6 +182,6 @@ static inline int gmtoffset(const GregorianDateTime& t)
return t.utcOffset;
}
-} // namespace JSC
+} // namespace WTF
#endif // DateMath_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Deque.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Deque.h
index c371d38..3c3d378 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Deque.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Deque.h
@@ -44,7 +44,7 @@ namespace WTF {
template<typename T> class DequeConstReverseIterator;
template<typename T>
- class Deque {
+ class Deque : public FastAllocBase {
public:
typedef DequeIterator<T> iterator;
typedef DequeConstIterator<T> const_iterator;
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/FastAllocBase.h b/src/3rdparty/webkit/JavaScriptCore/wtf/FastAllocBase.h
index 71e6bfa..1c81856 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/FastAllocBase.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/FastAllocBase.h
@@ -397,4 +397,7 @@ namespace WTF {
} // namespace WTF
+// Using WTF::FastAllocBase to avoid using FastAllocBase's explicit qualification by WTF::.
+using WTF::FastAllocBase;
+
#endif // FastAllocBase_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/FastMalloc.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/FastMalloc.cpp
index f114160..c65ba85 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/FastMalloc.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/FastMalloc.cpp
@@ -4089,7 +4089,7 @@ extern "C" {
malloc_introspection_t jscore_fastmalloc_introspection = { &FastMallocZone::enumerate, &FastMallocZone::goodSize, &FastMallocZone::check, &FastMallocZone::print,
&FastMallocZone::log, &FastMallocZone::forceLock, &FastMallocZone::forceUnlock, &FastMallocZone::statistics
-#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
+#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !PLATFORM(IPHONE)
, 0 // zone_locked will not be called on the zone unless it advertises itself as version five or higher.
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/HashCountedSet.h b/src/3rdparty/webkit/JavaScriptCore/wtf/HashCountedSet.h
index 6fc0234..1a422d8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/HashCountedSet.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/HashCountedSet.h
@@ -22,13 +22,14 @@
#define WTF_HashCountedSet_h
#include "Assertions.h"
+#include "FastAllocBase.h"
#include "HashMap.h"
#include "Vector.h"
namespace WTF {
template<typename Value, typename HashFunctions = typename DefaultHash<Value>::Hash,
- typename Traits = HashTraits<Value> > class HashCountedSet {
+ typename Traits = HashTraits<Value> > class HashCountedSet : public FastAllocBase {
private:
typedef HashMap<Value, unsigned, HashFunctions, Traits> ImplType;
public:
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/HashMap.h b/src/3rdparty/webkit/JavaScriptCore/wtf/HashMap.h
index c5b75ff..3de5ee6 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/HashMap.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/HashMap.h
@@ -29,7 +29,7 @@ namespace WTF {
template<typename KeyArg, typename MappedArg, typename HashArg = typename DefaultHash<KeyArg>::Hash,
typename KeyTraitsArg = HashTraits<KeyArg>, typename MappedTraitsArg = HashTraits<MappedArg> >
- class HashMap {
+ class HashMap : public FastAllocBase {
private:
typedef KeyTraitsArg KeyTraits;
typedef MappedTraitsArg MappedTraits;
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/HashSet.h b/src/3rdparty/webkit/JavaScriptCore/wtf/HashSet.h
index da99f2c..d664c67 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/HashSet.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/HashSet.h
@@ -21,6 +21,7 @@
#ifndef WTF_HashSet_h
#define WTF_HashSet_h
+#include "FastAllocBase.h"
#include "HashTable.h"
namespace WTF {
@@ -32,7 +33,7 @@ namespace WTF {
template<typename T> struct IdentityExtractor;
template<typename ValueArg, typename HashArg = typename DefaultHash<ValueArg>::Hash,
- typename TraitsArg = HashTraits<ValueArg> > class HashSet {
+ typename TraitsArg = HashTraits<ValueArg> > class HashSet : public FastAllocBase {
private:
typedef HashArg HashFunctions;
typedef TraitsArg ValueTraits;
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h b/src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h
index 76488b4..324300d 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h
@@ -39,10 +39,8 @@
#endif
#if COMPILER(MSVC)
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
#include <stdlib.h>
-#else
-#include <xmath.h>
#endif
#include <limits>
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/MessageQueue.h b/src/3rdparty/webkit/JavaScriptCore/wtf/MessageQueue.h
index 9549f37..7721dba 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/MessageQueue.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/MessageQueue.h
@@ -47,9 +47,10 @@ namespace WTF {
template<typename DataType>
class MessageQueue : Noncopyable {
public:
- MessageQueue() : m_killed(false) {}
+ MessageQueue() : m_killed(false) { }
void append(const DataType&);
+ bool appendAndCheckEmpty(const DataType&);
void prepend(const DataType&);
bool waitForMessage(DataType&);
template<typename Predicate>
@@ -81,6 +82,17 @@ namespace WTF {
m_condition.signal();
}
+ // Returns true if the queue was empty before the item was added.
+ template<typename DataType>
+ inline bool MessageQueue<DataType>::appendAndCheckEmpty(const DataType& message)
+ {
+ MutexLocker lock(m_mutex);
+ bool wasEmpty = m_queue.isEmpty();
+ m_queue.append(message);
+ m_condition.signal();
+ return wasEmpty;
+ }
+
template<typename DataType>
inline void MessageQueue<DataType>::prepend(const DataType& message)
{
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h
index b08e08c..c82d1f7 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h
@@ -46,6 +46,7 @@
#elif !defined(MAC_OS_X_VERSION_10_6) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_6
#define BUILDING_ON_LEOPARD 1
#endif
+#include <TargetConditionals.h>
#endif
/* PLATFORM(WIN_OS) */
@@ -55,12 +56,12 @@
#define WTF_PLATFORM_WIN_OS 1
#endif
-/* PLATFORM(WIN_CE) */
+/* PLATFORM(WINCE) */
/* Operating system level dependencies for Windows CE that should be used */
/* regardless of operating environment */
/* Note that for this platform PLATFORM(WIN_OS) is also defined. */
#if defined(_WIN32_WCE)
-#define WTF_PLATFORM_WIN_CE 1
+#define WTF_PLATFORM_WINCE 1
#include <ce_time.h>
#endif
@@ -150,11 +151,30 @@
#define WTF_PLATFORM_WIN 1
#endif
+/* PLATFORM(IPHONE) */
+#if (defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
+#define WTF_PLATFORM_IPHONE 1
+#endif
+
+/* PLATFORM(IPHONE_SIMULATOR) */
+#if defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
+#define WTF_PLATFORM_IPHONE 1
+#define WTF_PLATFORM_IPHONE_SIMULATOR 1
+#else
+#define WTF_PLATFORM_IPHONE_SIMULATOR 0
+#endif
+
+#if !defined(WTF_PLATFORM_IPHONE)
+#define WTF_PLATFORM_IPHONE 0
+#endif
+
/* Graphics engines */
/* PLATFORM(CG) and PLATFORM(CI) */
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(IPHONE)
#define WTF_PLATFORM_CG 1
+#endif
+#if PLATFORM(MAC) && !PLATFORM(IPHONE)
#define WTF_PLATFORM_CI 1
#endif
@@ -208,7 +228,29 @@
#if !defined(__ARM_EABI__)
#define WTF_PLATFORM_FORCE_PACK 1
#endif
+#define ARM_ARCH_VERSION 3
+#if defined(__ARM_ARCH_4__) || defined(__ARM_ARCH_4T__)
+#undef ARM_ARCH_VERSION
+#define ARM_ARCH_VERSION 4
+#endif
+#if defined(__ARM_ARCH_5__) || defined(__ARM_ARCH_5T__) \
+ || defined(__ARM_ARCH_5E__) || defined(__ARM_ARCH_5TE__) \
+ || defined(__ARM_ARCH_5TEJ__)
+#undef ARM_ARCH_VERSION
+#define ARM_ARCH_VERSION 5
#endif
+#if defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) \
+ || defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6Z__) \
+ || defined(__ARM_ARCH_6ZK__)
+#undef ARM_ARCH_VERSION
+#define ARM_ARCH_VERSION 6
+#endif
+#if defined(__ARM_ARCH_7A__)
+#undef ARM_ARCH_VERSION
+#define ARM_ARCH_VERSION 7
+#endif
+#endif /* ARM */
+#define PLATFORM_ARM_ARCH(N) (PLATFORM(ARM) && ARM_ARCH_VERSION >= N)
/* PLATFORM(X86) */
#if defined(__i386__) \
@@ -236,12 +278,12 @@
#define WTF_PLATFORM_BIG_ENDIAN 1
#endif
-/* PLATFORM(WIN_CE) && PLATFORM(QT)
+/* PLATFORM(WINCE) && PLATFORM(QT)
We can not determine the endianess at compile time. For
Qt for Windows CE the endianess is specified in the
device specific makespec
*/
-#if PLATFORM(WIN_CE) && PLATFORM(QT)
+#if PLATFORM(WINCE) && PLATFORM(QT)
# include <QtGlobal>
# undef WTF_PLATFORM_BIG_ENDIAN
# undef WTF_PLATFORM_MIDDLE_ENDIAN
@@ -293,7 +335,7 @@
#define WTF_COMPILER_WINSCW 1
#endif
-#if (PLATFORM(MAC) || PLATFORM(WIN)) && !defined(ENABLE_JSC_MULTIPLE_THREADS)
+#if (PLATFORM(IPHONE) || PLATFORM(MAC) || PLATFORM(WIN)) && !defined(ENABLE_JSC_MULTIPLE_THREADS)
#define ENABLE_JSC_MULTIPLE_THREADS 1
#endif
@@ -308,7 +350,7 @@
#define WTF_USE_ICU_UNICODE 1
#endif
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) && !PLATFORM(IPHONE)
#define WTF_PLATFORM_CF 1
#define WTF_USE_PTHREADS 1
#if !defined(ENABLE_MAC_JAVA_BRIDGE)
@@ -326,6 +368,18 @@
#define WTF_USE_PTHREADS 1
#endif
+#if PLATFORM(IPHONE)
+#define WTF_PLATFORM_CF 1
+#define WTF_USE_PTHREADS 1
+#define ENABLE_FTPDIR 1
+#define ENABLE_MAC_JAVA_BRIDGE 0
+#define ENABLE_ICONDATABASE 0
+#define ENABLE_GEOLOCATION 1
+#define ENABLE_NETSCAPE_PLUGIN_API 0
+#define HAVE_READLINE 1
+#define ENABLE_REPAINT_THROTTLING 1
+#endif
+
#if PLATFORM(WIN)
#define WTF_USE_WININET 1
#endif
@@ -343,7 +397,7 @@
#endif
#if !defined(HAVE_ACCESSIBILITY)
-#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(CHROMIUM)
+#if PLATFORM(IPHONE) || PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(CHROMIUM)
#define HAVE_ACCESSIBILITY 1
#endif
#endif /* !defined(HAVE_ACCESSIBILITY) */
@@ -360,15 +414,19 @@
#define HAVE_SYS_TIME_H 1
#define HAVE_SYS_TIMEB_H 1
-#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
+#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !PLATFORM(IPHONE)
#define HAVE_MADV_FREE_REUSE 1
#define HAVE_MADV_FREE 1
#endif
+#if PLATFORM(IPHONE)
+#define HAVE_MADV_FREE 1
+#endif
+
#elif PLATFORM(WIN_OS)
#define HAVE_FLOAT_H 1
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
#define HAVE_ERRNO_H 0
#else
#define HAVE_SYS_TIMEB_H 1
@@ -481,29 +539,38 @@
#elif PLATFORM(X86) && PLATFORM(MAC)
#define ENABLE_JIT 1
#define WTF_USE_JIT_STUB_ARGUMENT_VA_LIST 1
+#elif PLATFORM_ARM_ARCH(7) && PLATFORM(IPHONE)
+ /* Under development, temporarily disabled until 16Mb link range limit in assembler is fixed. */
+ #define ENABLE_JIT 0
+ #define ENABLE_JIT_OPTIMIZE_NATIVE_CALL 0
/* The JIT is tested & working on x86 Windows */
#elif PLATFORM(X86) && PLATFORM(WIN)
#define ENABLE_JIT 1
#endif
- #define ENABLE_JIT_OPTIMIZE_CALL 1
- #define ENABLE_JIT_OPTIMIZE_NATIVE_CALL 1
- #define ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS 1
- #define ENABLE_JIT_OPTIMIZE_ARITHMETIC 1
- #define ENABLE_JIT_OPTIMIZE_METHOD_CALLS 1
#endif
-#if PLATFORM(X86_64)
- #define JSC_HOST_CALL
-#elif COMPILER(MSVC)
- #define JSC_HOST_CALL __fastcall
-#elif COMPILER(GCC) && PLATFORM(X86)
- #define JSC_HOST_CALL __attribute__ ((fastcall))
+#ifndef ENABLE_JIT_OPTIMIZE_CALL
+#define ENABLE_JIT_OPTIMIZE_CALL 1
+#endif
+#ifndef ENABLE_JIT_OPTIMIZE_NATIVE_CALL
+#define ENABLE_JIT_OPTIMIZE_NATIVE_CALL 1
+#endif
+#ifndef ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
+#define ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS 1
+#endif
+#ifndef ENABLE_JIT_OPTIMIZE_ARITHMETIC
+#define ENABLE_JIT_OPTIMIZE_ARITHMETIC 1
+#endif
+#ifndef ENABLE_JIT_OPTIMIZE_METHOD_CALLS
+#define ENABLE_JIT_OPTIMIZE_METHOD_CALLS 1
+#endif
+
+#if PLATFORM(X86) && COMPILER(MSVC)
+#define JSC_HOST_CALL __fastcall
+#elif PLATFORM(X86) && COMPILER(GCC)
+#define JSC_HOST_CALL __attribute__ ((fastcall))
#else
- #if ENABLE(JIT)
- #error Need to support register calling convention in this compiler
- #else
- #define JSC_HOST_CALL
- #endif
+#define JSC_HOST_CALL
#endif
#if COMPILER(GCC) && !ENABLE(JIT)
@@ -520,6 +587,8 @@
/* YARR supports x86 & x86-64, and has been tested on Mac and Windows. */
#if (!defined(ENABLE_YARR_JIT) && PLATFORM(X86) && PLATFORM(MAC)) \
|| (!defined(ENABLE_YARR_JIT) && PLATFORM(X86_64) && PLATFORM(MAC)) \
+ /* Under development, temporarily disabled until 16Mb link range limit in assembler is fixed. */ \
+ || (!defined(ENABLE_YARR_JIT) && PLATFORM_ARM_ARCH(7) && PLATFORM(IPHONE) && 0) \
|| (!defined(ENABLE_YARR_JIT) && PLATFORM(X86) && PLATFORM(WIN))
#define ENABLE_YARR 1
#define ENABLE_YARR_JIT 1
@@ -534,7 +603,11 @@
#endif
/* Setting this flag prevents the assembler from using RWX memory; this may improve
security but currectly comes at a significant performance cost. */
+#if PLATFORM_ARM_ARCH(7) && PLATFORM(IPHONE)
+#define ENABLE_ASSEMBLER_WX_EXCLUSIVE 1
+#else
#define ENABLE_ASSEMBLER_WX_EXCLUSIVE 0
+#endif
#if !defined(ENABLE_PAN_SCROLLING) && PLATFORM(WIN_OS)
#define ENABLE_PAN_SCROLLING 1
@@ -555,4 +628,15 @@
#define WTF_USE_FONT_FAST_PATH 1
#endif
+/* Accelerated compositing */
+#if PLATFORM(MAC)
+#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
+#define WTF_USE_ACCELERATED_COMPOSITING 1
+#endif
+#endif
+
+#if PLATFORM(IPHONE)
+#define WTF_USE_ACCELERATED_COMPOSITING 1
+#endif
+
#endif /* WTF_Platform_h */
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/RandomNumberSeed.h b/src/3rdparty/webkit/JavaScriptCore/wtf/RandomNumberSeed.h
index 161377f..32291dd 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/RandomNumberSeed.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/RandomNumberSeed.h
@@ -38,7 +38,7 @@
#include <unistd.h>
#endif
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
#include <ce_time.h>
#endif
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/RefPtr.h b/src/3rdparty/webkit/JavaScriptCore/wtf/RefPtr.h
index 929e745..74cd0ea 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/RefPtr.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/RefPtr.h
@@ -23,6 +23,7 @@
#include <algorithm>
#include "AlwaysInline.h"
+#include "FastAllocBase.h"
namespace WTF {
@@ -32,7 +33,7 @@ namespace WTF {
enum HashTableDeletedValueType { HashTableDeletedValue };
- template <typename T> class RefPtr {
+ template <typename T> class RefPtr : public FastAllocBase {
public:
RefPtr() : m_ptr(0) { }
RefPtr(T* ptr) : m_ptr(ptr) { if (ptr) ptr->ref(); }
diff --git a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/SegmentedVector.h b/src/3rdparty/webkit/JavaScriptCore/wtf/SegmentedVector.h
index bbab04f..065c19c 100644
--- a/src/3rdparty/webkit/JavaScriptCore/bytecompiler/SegmentedVector.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/SegmentedVector.h
@@ -31,13 +31,79 @@
#include <wtf/Vector.h>
-namespace JSC {
+namespace WTF {
+
+ // An iterator for SegmentedVector. It supports only the pre ++ operator
+ template <typename T, size_t SegmentSize> class SegmentedVector;
+ template <typename T, size_t SegmentSize> class SegmentedVectorIterator {
+ private:
+ friend class SegmentedVector<T, SegmentSize>;
+ public:
+ typedef SegmentedVectorIterator<T, SegmentSize> Iterator;
+
+ ~SegmentedVectorIterator() { }
+
+ T& operator*() const { return m_vector.m_segments.at(m_segment)->at(m_index); }
+ T* operator->() const { return &m_vector.m_segments.at(m_segment)->at(m_index); }
+
+ // Only prefix ++ operator supported
+ Iterator& operator++()
+ {
+ ASSERT(m_index != SegmentSize);
+ ++m_index;
+ if (m_index >= m_vector.m_segments.at(m_segment)->size()) {
+ if (m_segment + 1 < m_vector.m_segments.size()) {
+ ASSERT(m_vector.m_segments.at(m_segment)->size() > 0);
+ ++m_segment;
+ m_index = 0;
+ } else {
+ // Points to the "end" symbol
+ m_segment = 0;
+ m_index = SegmentSize;
+ }
+ }
+ return *this;
+ }
+
+ bool operator==(const Iterator& other) const
+ {
+ return (m_index == other.m_index && m_segment = other.m_segment && &m_vector == &other.m_vector);
+ }
+
+ bool operator!=(const Iterator& other) const
+ {
+ return (m_index != other.m_index || m_segment != other.m_segment || &m_vector != &other.m_vector);
+ }
+
+ SegmentedVectorIterator& operator=(const SegmentedVectorIterator<T, SegmentSize>& other)
+ {
+ m_vector = other.m_vector;
+ m_segment = other.m_segment;
+ m_index = other.m_index;
+ return *this;
+ }
+
+ private:
+ SegmentedVectorIterator(SegmentedVector<T, SegmentSize>& vector, size_t segment, size_t index)
+ : m_vector(vector)
+ , m_segment(segment)
+ , m_index(index)
+ {
+ }
+
+ SegmentedVector<T, SegmentSize>& m_vector;
+ size_t m_segment;
+ size_t m_index;
+ };
// SegmentedVector is just like Vector, but it doesn't move the values
// stored in its buffer when it grows. Therefore, it is safe to keep
// pointers into a SegmentedVector.
template <typename T, size_t SegmentSize> class SegmentedVector {
+ friend class SegmentedVectorIterator<T, SegmentSize>;
public:
+ typedef SegmentedVectorIterator<T, SegmentSize> Iterator;
+
SegmentedVector()
: m_size(0)
{
@@ -82,6 +148,12 @@ namespace JSC {
segmentFor(m_size - 1)->uncheckedAppend(value);
}
+ T& alloc()
+ {
+ append<T>(T());
+ return last();
+ }
+
void removeLast()
{
if (m_size <= SegmentSize)
@@ -106,9 +178,19 @@ namespace JSC {
m_size = 0;
}
+ Iterator begin()
+ {
+ return Iterator(*this, 0, m_size ? 0 : SegmentSize);
+ }
+
+ Iterator end()
+ {
+ return Iterator(*this, 0, SegmentSize);
+ }
+
private:
typedef Vector<T, SegmentSize> Segment;
-
+
void deleteAllSegments()
{
// Skip the first segment, because it's our inline segment, which was
@@ -116,22 +198,22 @@ namespace JSC {
for (size_t i = 1; i < m_segments.size(); i++)
delete m_segments[i];
}
-
+
bool segmentExistsFor(size_t index)
{
return index / SegmentSize < m_segments.size();
}
-
+
Segment* segmentFor(size_t index)
{
return m_segments[index / SegmentSize];
}
-
+
size_t subscriptFor(size_t index)
{
return index % SegmentSize;
}
-
+
void ensureSegmentsFor(size_t size)
{
size_t segmentCount = m_size / SegmentSize;
@@ -147,7 +229,7 @@ namespace JSC {
size_t end = neededSegmentCount - 1;
for (size_t i = segmentCount - 1; i < end; ++i)
ensureSegment(i, SegmentSize);
-
+
// Grow segment N to accomodate the remainder.
ensureSegment(end, subscriptFor(size - 1) + 1);
}
@@ -165,6 +247,6 @@ namespace JSC {
Vector<Segment*, 32> m_segments;
};
-} // namespace JSC
+} // namespace WTF
#endif // SegmentedVector_h
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/StringExtras.h b/src/3rdparty/webkit/JavaScriptCore/wtf/StringExtras.h
index 926fd61..1c23390 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/StringExtras.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/StringExtras.h
@@ -45,7 +45,7 @@ inline int snprintf(char* buffer, size_t count, const char* format, ...)
return result;
}
-#if COMPILER(MSVC7) || PLATFORM(WIN_CE)
+#if COMPILER(MSVC7) || PLATFORM(WINCE)
inline int vsnprintf(char* buffer, size_t count, const char* format, va_list args)
{
@@ -54,7 +54,7 @@ inline int vsnprintf(char* buffer, size_t count, const char* format, va_list arg
#endif
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
inline int strnicmp(const char* string1, const char* string2, size_t count)
{
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Threading.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Threading.h
index 02fa3a4..b12f41f 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Threading.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Threading.h
@@ -59,7 +59,7 @@
#ifndef Threading_h
#define Threading_h
-#if PLATFORM(WIN_CE)
+#if PLATFORM(WINCE)
#include <windows.h>
#endif
@@ -67,7 +67,7 @@
#include <wtf/Locker.h>
#include <wtf/Noncopyable.h>
-#if PLATFORM(WIN_OS) && !PLATFORM(WIN_CE)
+#if PLATFORM(WIN_OS) && !PLATFORM(WINCE)
#include <windows.h>
#elif PLATFORM(DARWIN)
#include <libkern/OSAtomic.h>
@@ -126,18 +126,22 @@ void detachThread(ThreadIdentifier);
#if USE(PTHREADS)
typedef pthread_mutex_t PlatformMutex;
+typedef pthread_rwlock_t PlatformReadWriteLock;
typedef pthread_cond_t PlatformCondition;
#elif PLATFORM(GTK)
typedef GOwnPtr<GMutex> PlatformMutex;
+typedef void* PlatformReadWriteLock; // FIXME: Implement.
typedef GOwnPtr<GCond> PlatformCondition;
#elif PLATFORM(QT)
typedef QT_PREPEND_NAMESPACE(QMutex)* PlatformMutex;
+typedef void* PlatformReadWriteLock; // FIXME: Implement.
typedef QT_PREPEND_NAMESPACE(QWaitCondition)* PlatformCondition;
#elif PLATFORM(WIN_OS)
struct PlatformMutex {
CRITICAL_SECTION m_internalMutex;
size_t m_recursionCount;
};
+typedef void* PlatformReadWriteLock; // FIXME: Implement.
struct PlatformCondition {
size_t m_waitersGone;
size_t m_waitersBlocked;
@@ -151,6 +155,7 @@ struct PlatformCondition {
};
#else
typedef void* PlatformMutex;
+typedef void* PlatformReadWriteLock;
typedef void* PlatformCondition;
#endif
@@ -171,6 +176,23 @@ private:
typedef Locker<Mutex> MutexLocker;
+class ReadWriteLock : Noncopyable {
+public:
+ ReadWriteLock();
+ ~ReadWriteLock();
+
+ void readLock();
+ bool tryReadLock();
+
+ void writeLock();
+ bool tryWriteLock();
+
+ void unlock();
+
+private:
+ PlatformReadWriteLock m_readWriteLock;
+};
+
class ThreadCondition : Noncopyable {
public:
ThreadCondition();
@@ -190,7 +212,7 @@ private:
#if PLATFORM(WIN_OS)
#define WTF_USE_LOCKFREE_THREADSAFESHARED 1
-#if COMPILER(MINGW) || COMPILER(MSVC7) || PLATFORM(WIN_CE)
+#if COMPILER(MINGW) || COMPILER(MSVC7) || PLATFORM(WINCE)
inline void atomicIncrement(int* addend) { InterlockedIncrement(reinterpret_cast<long*>(addend)); }
inline int atomicDecrement(int* addend) { return InterlockedDecrement(reinterpret_cast<long*>(addend)); }
#else
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingNone.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingNone.cpp
index e713102..46f23d2 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingNone.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingNone.cpp
@@ -48,8 +48,8 @@ void Mutex::unlock() { }
ThreadCondition::ThreadCondition() { }
ThreadCondition::~ThreadCondition() { }
-void ThreadCondition::wait(Mutex& mutex) { }
-bool ThreadCondition::timedWait(Mutex& mutex, double absoluteTime) { return false; }
+void ThreadCondition::wait(Mutex&) { }
+bool ThreadCondition::timedWait(Mutex&, double) { return false; }
void ThreadCondition::signal() { }
void ThreadCondition::broadcast() { }
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingPthreads.cpp b/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingPthreads.cpp
index 3f5cbf5..d0e6df8 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingPthreads.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/ThreadingPthreads.cpp
@@ -183,7 +183,7 @@ ThreadIdentifier createThreadInternal(ThreadFunction entryPoint, void* data, con
void setThreadNameInternal(const char* threadName)
{
-#if PLATFORM(DARWIN) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
+#if PLATFORM(DARWIN) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !PLATFORM(IPHONE)
pthread_setname_np(threadName);
#else
UNUSED_PARAM(threadName);
@@ -267,6 +267,61 @@ void Mutex::unlock()
ASSERT_UNUSED(result, !result);
}
+
+ReadWriteLock::ReadWriteLock()
+{
+ pthread_rwlock_init(&m_readWriteLock, NULL);
+}
+
+ReadWriteLock::~ReadWriteLock()
+{
+ pthread_rwlock_destroy(&m_readWriteLock);
+}
+
+void ReadWriteLock::readLock()
+{
+ int result = pthread_rwlock_rdlock(&m_readWriteLock);
+ ASSERT_UNUSED(result, !result);
+}
+
+bool ReadWriteLock::tryReadLock()
+{
+ int result = pthread_rwlock_tryrdlock(&m_readWriteLock);
+
+ if (result == 0)
+ return true;
+ if (result == EBUSY || result == EAGAIN)
+ return false;
+
+ ASSERT_NOT_REACHED();
+ return false;
+}
+
+void ReadWriteLock::writeLock()
+{
+ int result = pthread_rwlock_wrlock(&m_readWriteLock);
+ ASSERT_UNUSED(result, !result);
+}
+
+bool ReadWriteLock::tryWriteLock()
+{
+ int result = pthread_rwlock_trywrlock(&m_readWriteLock);
+
+ if (result == 0)
+ return true;
+ if (result == EBUSY || result == EAGAIN)
+ return false;
+
+ ASSERT_NOT_REACHED();
+ return false;
+}
+
+void ReadWriteLock::unlock()
+{
+ int result = pthread_rwlock_unlock(&m_readWriteLock);
+ ASSERT_UNUSED(result, !result);
+}
+
ThreadCondition::ThreadCondition()
{
pthread_cond_init(&m_condition, NULL);
diff --git a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h
index dcfeb29..c378fd0 100644
--- a/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h
+++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Vector.h
@@ -21,16 +21,17 @@
#ifndef WTF_Vector_h
#define WTF_Vector_h
-#include "Assertions.h"
-#include "FastMalloc.h"
+#include "FastAllocBase.h"
#include "Noncopyable.h"
#include "NotFound.h"
#include "VectorTraits.h"
#include <limits>
-#include <stdlib.h>
-#include <string.h>
#include <utility>
+#if PLATFORM(QT)
+#include <QDataStream>
+#endif
+
namespace WTF {
using std::min;
@@ -433,7 +434,7 @@ namespace WTF {
};
template<typename T, size_t inlineCapacity = 0>
- class Vector {
+ class Vector : public FastAllocBase {
private:
typedef VectorBuffer<T, inlineCapacity> Buffer;
typedef VectorTypeOperations<T> TypeOperations;
@@ -566,6 +567,32 @@ namespace WTF {
Buffer m_buffer;
};
+#if PLATFORM(QT)
+ template<typename T>
+ QDataStream& operator<<(QDataStream& stream, const Vector<T>& data)
+ {
+ stream << qint64(data.size());
+ foreach (const T& i, data)
+ stream << i;
+ return stream;
+ }
+
+ template<typename T>
+ QDataStream& operator>>(QDataStream& stream, Vector<T>& data)
+ {
+ data.clear();
+ qint64 count;
+ T item;
+ stream >> count;
+ data.reserveCapacity(count);
+ for (qint64 i = 0; i < count; ++i) {
+ stream >> item;
+ data.append(item);
+ }
+ return stream;
+ }
+#endif
+
template<typename T, size_t inlineCapacity>
Vector<T, inlineCapacity>::Vector(const Vector& other)
: m_size(other.size())
diff --git a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp
index a64dd8d..29a9d18 100644
--- a/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp
+++ b/src/3rdparty/webkit/JavaScriptCore/yarr/RegexJIT.cpp
@@ -43,6 +43,17 @@ namespace JSC { namespace Yarr {
class RegexGenerator : private MacroAssembler {
friend void jitCompileRegex(JSGlobalData* globalData, RegexCodeBlock& jitObject, const UString& pattern, unsigned& numSubpatterns, const char*& error, bool ignoreCase, bool multiline);
+#if PLATFORM_ARM_ARCH(7)
+ static const RegisterID input = ARM::r0;
+ static const RegisterID index = ARM::r1;
+ static const RegisterID length = ARM::r2;
+
+ static const RegisterID output = ARM::r4;
+ static const RegisterID regT0 = ARM::r5;
+ static const RegisterID regT1 = ARM::r6;
+
+ static const RegisterID returnRegister = ARM::r0;
+#endif
#if PLATFORM(X86)
static const RegisterID input = X86::eax;
static const RegisterID index = X86::edx;
@@ -1278,34 +1289,47 @@ class RegexGenerator : private MacroAssembler {
void generateEnter()
{
- // On x86 edi & esi are callee preserved registers.
+#if PLATFORM(X86_64)
+ push(X86::ebp);
+ move(stackPointerRegister, X86::ebp);
+#elif PLATFORM(X86)
push(X86::ebp);
move(stackPointerRegister, X86::ebp);
-#if PLATFORM(X86)
// TODO: do we need spill registers to fill the output pointer if there are no sub captures?
push(X86::ebx);
push(X86::edi);
push(X86::esi);
// load output into edi (2 = saved ebp + return address).
-#if COMPILER(MSVC)
+ #if COMPILER(MSVC)
loadPtr(Address(X86::ebp, 2 * sizeof(void*)), input);
loadPtr(Address(X86::ebp, 3 * sizeof(void*)), index);
loadPtr(Address(X86::ebp, 4 * sizeof(void*)), length);
loadPtr(Address(X86::ebp, 5 * sizeof(void*)), output);
-#else
+ #else
loadPtr(Address(X86::ebp, 2 * sizeof(void*)), output);
-#endif
+ #endif
+#elif PLATFORM_ARM_ARCH(7)
+ push(ARM::r4);
+ push(ARM::r5);
+ push(ARM::r6);
+ move(ARM::r3, output);
#endif
}
void generateReturn()
{
-#if PLATFORM(X86)
+#if PLATFORM(X86_64)
+ pop(X86::ebp);
+#elif PLATFORM(X86)
pop(X86::esi);
pop(X86::edi);
pop(X86::ebx);
-#endif
pop(X86::ebp);
+#elif PLATFORM_ARM_ARCH(7)
+ pop(ARM::r6);
+ pop(ARM::r5);
+ pop(ARM::r4);
+#endif
ret();
}
@@ -1334,7 +1358,7 @@ public:
{
generate();
- PatchBuffer patchBuffer(this, globalData->executableAllocator.poolForSize(size()));
+ LinkBuffer patchBuffer(this, globalData->executableAllocator.poolForSize(size()));
for (unsigned i = 0; i < m_backtrackRecords.size(); ++i)
patchBuffer.patch(m_backtrackRecords[i].dataLabel, patchBuffer.locationOf(m_backtrackRecords[i].backtrackLocation));
diff --git a/src/3rdparty/webkit/VERSION b/src/3rdparty/webkit/VERSION
index f3e81c1..730c023 100644
--- a/src/3rdparty/webkit/VERSION
+++ b/src/3rdparty/webkit/VERSION
@@ -4,8 +4,8 @@ This is a snapshot of the Qt port of WebKit from
The commit imported was from the
- origin/qtwebkit-4.6-staging branch/tag
+ qtwebkit-4.6-snapshot-29062009 branch/tag
and has the sha1 checksum
- 751940f0f1fb2599250632d7f0a3ead3930466af
+ 22aadba1b4356ad7d8e9446b95baccb6b2c037b0
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog b/src/3rdparty/webkit/WebCore/ChangeLog
index 14190f6..8991528 100644
--- a/src/3rdparty/webkit/WebCore/ChangeLog
+++ b/src/3rdparty/webkit/WebCore/ChangeLog
@@ -1,95362 +1,5879 @@
-2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+2009-06-26 John Sullivan <sullivan@apple.com>
- Reviewed by Simon Hausmann.
-
- Fix the build of PluginView on Qt with 64-bit where we disable plugins
- at compile time.
-
- Use the FooNone.cpp files at compile-time.
-
- * plugins/PluginPackageNone.cpp:
- * plugins/mac/PluginPackageMac.cpp:
- * plugins/mac/PluginViewMac.cpp:
-
-2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows
-
- This define was brought in after refactoring some code from
- PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.
-
- * WebCore.pro:
-
-2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
-
- * WebCore.pro:
-
-2009-06-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- [Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
- https://bugs.webkit.org/show_bug.cgi?id=26244
-
- * WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if
- NETSCAPE_PLUGIN_API is turned on
- * plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
- * plugins/PluginViewNone.cpp: Match guards with PluginView.h
-
-2009-06-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES
- when the selection is inside a text field.
-
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::isAll): Return false if the selection is in
- a shadow tree.
-
-2009-06-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=26106
- [GTK] Crashes when you keep a combo open during a page transition, then close it
-
- Hide the combo popup and disconnect from its signals during
- PopupMenu destruction to handle this exceptional case with no
- crash.
-
- * platform/gtk/PopupMenuGtk.cpp:
- (WebCore::PopupMenu::~PopupMenu):
- (WebCore::PopupMenu::menuUnmapped):
-
-2009-06-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6930540>
- REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
-
- Test: fast/css/font-family-builtins.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::identifierForFamily): Fix typo. Fantasy family should be
- -webkit-fantasy not, -webkit-serif.
-
-2009-06-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Brady Eidson.
-
- Fix for <rdar://problem/6936235>
- Need to support StorageEvent.storageArea to meet the Web Storage spec
-
- * storage/LocalStorageArea.cpp:
- (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for
- the frame being dispatched to.
- * storage/SessionStorageArea.cpp:
- (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
-
- * storage/StorageEvent.cpp:
- (WebCore::StorageEvent::StorageEvent):
- (WebCore::StorageEvent::initStorageEvent):
- * storage/StorageEvent.h:
- (WebCore::StorageEvent::create):
- (WebCore::StorageEvent::storageArea):
- * storage/StorageEvent.idl:
- Add storageArea member.
-
-2009-06-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Anders Carlsson.
-
- Fix WMLInputElement initialization code. Don't call initialize() on attach(), let
- WMLCardElement handle initialization once, after the document has been parsed.
-
- To keep layout tests working introduce a new function in Document.idl: initializeWMLPageState().
- WMLTestCase.js (the wml/ layout test framework) will use it to simulate a regular WML document,
- whose variable state gets initialized on WMLDocument::finishedParsing(). Force initialization
- of the WML variable state, right after the dynamically created elements have been inserted into the tree.
-
- * dom/Document.cpp:
- (WebCore::Document::initializeWMLPageState):
- * dom/Document.h:
- * dom/Document.idl:
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing):
- (WebCore::WMLDocument::initialize):
- * wml/WMLDocument.h:
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::initialize):
- * wml/WMLInputElement.h:
-
-2009-06-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Add ononline and onoffline attributes for the <body> element.
-
- * html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr
- and onofflineAttr to window event listeners.
-
-2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Add missing includes of config.h
-
- * platform/qt/QWebPopup.cpp:
- * platform/text/qt/TextBreakIteratorQt.cpp:
-
-2009-06-05 Fumitoshi Ukai <ukai@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=26215
- Try to fix the Chromium build.
-
- * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
- (WebCore::fillBMPGlyphs):
- (WebCore::fillNonBMPGlyphs):
-
-2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
-
- Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
-
- <https://bugs.webkit.org/show_bug.cgi?id=26160>
-
- Reviewed by Alexey Proskuryakov.
-
- Use /bin/ln instead of ln for cases where this command is used with -h option.
- As this option is not supported by GNU fileutils, this change helps users
- who have GNU fileutils in their PATH.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-06-03 Ben Murdoch <benm@google.com>
-
- <https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
-
- Reviewed by Alexey Proskuryakov.
-
- Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
-
- Test: storage/hash-change-with-xhr.html
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::stopLoading):
- * loader/DocumentLoader.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::stopAllLoaders):
- * loader/FrameLoader.h:
- * loader/FrameLoaderTypes.h:
- (WebCore::):
- * page/Page.cpp:
- (WebCore::Page::goToItem):
- * WebCore.base.exp:
-
-2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Make sure the correct config.h is included when shadowbuilding
-
- * WebCore.pro:
-
-2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix Qt build after r44452
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
- (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
-
-2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Remove some dead code (MenuEventProxy)
-
- * WebCore.pro:
- * platform/ContextMenu.h:
- * platform/qt/ContextMenuQt.cpp:
- * platform/qt/MenuEventProxy.h: Removed.
-
-2009-06-05 Xan Lopez <xlopez@igalia.com>
-
- More build fixes.
-
- * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
- (WebCore::GlyphPage::fill):
-
-2009-06-05 Xan Lopez <xlopez@igalia.com>
-
- Fix the GTK+ build.
-
- * GNUmakefile.am:
- * platform/graphics/gtk/FontCacheGtk.cpp:
- (WebCore::FontCache::getFontDataForCharacters):
- * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
- (WebCore::GlyphPage::fill):
-
-2009-06-05 Antti Koivisto <antti@apple.com>
-
- Try to fix Windows (and possibly other platforms) build.
-
- Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
- for now since PluginStream used on some platforms expects them and calculations differ from plain
- Last-modified header value.
-
- Also include <wtf/MathExtras.h> to get isfinite().
-
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::adopt):
- (WebCore::ResourceResponseBase::copyData):
- (WebCore::ResourceResponseBase::setLastModifiedDate):
- (WebCore::ResourceResponseBase::lastModifiedDate):
- * platform/network/ResourceResponseBase.h:
- * platform/network/cf/ResourceResponseCFNet.cpp:
- (WebCore::ResourceResponse::platformLazyInit):
-
-2009-06-03 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=13128
- Safari not obeying cache header
-
- Implement RFC 2616 cache expiration calculations in WebKit instead of
- relying on the networking layer.
-
- * ForwardingHeaders/runtime/DateMath.h: Added.
- * WebCore.base.exp:
- * loader/Cache.cpp:
- (WebCore::Cache::revalidationSucceeded):
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::CachedResource):
- (WebCore::CachedResource::isExpired):
- (WebCore::CachedResource::currentAge):
- (WebCore::CachedResource::freshnessLifetime):
- (WebCore::CachedResource::setResponse):
- (WebCore::CachedResource::updateResponseAfterRevalidation):
- (WebCore::CachedResource::mustRevalidate):
- * loader/CachedResource.h:
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::ResourceResponseBase):
- (WebCore::ResourceResponseBase::adopt):
- (WebCore::ResourceResponseBase::copyData):
- (WebCore::ResourceResponseBase::setHTTPHeaderField):
- (WebCore::ResourceResponseBase::parseCacheControlDirectives):
- (WebCore::ResourceResponseBase::cacheControlContainsNoCache):
- (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
- (WebCore::ResourceResponseBase::cacheControlMaxAge):
- (WebCore::parseDateValueInHeader):
- (WebCore::ResourceResponseBase::date):
- (WebCore::ResourceResponseBase::age):
- (WebCore::ResourceResponseBase::expires):
- (WebCore::ResourceResponseBase::lastModified):
- (WebCore::ResourceResponseBase::isAttachment):
- (WebCore::ResourceResponseBase::compare):
- * platform/network/ResourceResponseBase.h:
- * platform/network/cf/ResourceResponseCFNet.cpp:
- (WebCore::ResourceResponse::platformLazyInit):
- * platform/network/mac/ResourceResponseMac.mm:
- (WebCore::ResourceResponse::platformLazyInit):
-
-2009-06-04 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 26201: Remove superfluous 'if' statements in RenderTable::addChild
- https://bugs.webkit.org/show_bug.cgi?id=26201
-
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild): remove superfluous 'if' statements
-
-
-2009-06-04 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 26202: add macros for primitive values to simplify CSSStyleSelector::applyProperty
- https://bugs.webkit.org/show_bug.cgi?id=26202
-
- * css/CSSStyleSelector.cpp: add HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE[_WITH_VALUE] macros
- (WebCore::CSSStyleSelector::applyProperty): use new macros
-
-2009-06-04 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel
-
- Bug 26203: Move parsing of 'attr(X)' values to own method
- https://bugs.webkit.org/show_bug.cgi?id=26203
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseAttr): new method
- (WebCore::CSSParser::parseContent): use new parseAttr method
- * css/CSSParser.h:
- (WebCore::CSSParser::parseAttr): new method
-
-2009-06-04 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 26205: RenderTableSection::addChild : correct comment
- https://bugs.webkit.org/show_bug.cgi?id=26205
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addChild): correct comment
-
-2009-06-04 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 26204: RenderBlock : simplify handleSpecialChild, comment correction
- https://bugs.webkit.org/show_bug.cgi?id=26204
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::handleSpecialChild): simplify usage
- (WebCore::RenderBlock::handlePositionedChild): simplify usage
- (WebCore::RenderBlock::handleFloatingChild): simplify usage
- (WebCore::RenderBlock::handleRunInChild): simplify usage
- (WebCore::RenderBlock::layoutBlock): correct comment
- (WebCore::RenderBlock::layoutBlockChildren): simplify loop, change call to handleSpecialChild
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::handleSpecialChild): change signature
- (WebCore::RenderBlock::handlePositionedChild): change signature
- (WebCore::RenderBlock::handleFloatingChild): change signature
- (WebCore::RenderBlock::handleRunInChild): change signature
-
-2009-06-04 Dan Bernstein <mitz@apple.com>
-
- - retry to fix the Tiger build
-
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::initFontData):
-
-2009-06-04 Dan Bernstein <mitz@apple.com>
-
- - try to fix the Tiger build
-
- * platform/graphics/SimpleFontData.h:
-
-2009-06-04 Dan Bernstein <mitz@apple.com>
-
- - try to fix the Leopard and Tiger builds
-
- * platform/graphics/SimpleFontData.h:
-
-2009-06-04 Dan Bernstein <mitz@apple.com>
-
- - try to fix the Windows build
-
- * platform/graphics/win/UniscribeController.cpp:
- (WebCore::UniscribeController::shapeAndPlaceItem):
-
-2009-06-04 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - make SimpleFontData's data members private
- - rename SimpleFontData's m_font member to m_platformData
-
- * platform/graphics/Font.h:
- (WebCore::Font::spaceWidth):
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData):
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::platformData):
- (WebCore::SimpleFontData::spaceWidth):
- (WebCore::SimpleFontData::adjustedSpaceWidth):
- (WebCore::SimpleFontData::syntheticBoldOffset):
- (WebCore::SimpleFontData::spaceGlyph):
- (WebCore::SimpleFontData::getNSFont):
- (WebCore::SimpleFontData::getQtFont):
- (WebCore::SimpleFontData::getWxFont):
- * platform/graphics/WidthIterator.cpp:
- (WebCore::WidthIterator::advance):
- * platform/graphics/cairo/FontCairo.cpp:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/graphics/gtk/FontGtk.cpp:
- (WebCore::setPangoAttributes):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- (WebCore::SimpleFontData::setFont):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- (WebCore::SimpleFontData::setFont):
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::adjustGlyphsAndAdvances):
- * platform/graphics/mac/FontMac.mm:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/mac/FontMacATSUI.mm:
- (WebCore::initializeATSUStyle):
- (WebCore::overrideLayoutOperation):
- (WebCore::ATSULayoutParameters::initialize):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::initFontData):
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformCharWidthInit):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- (WebCore::SimpleFontData::checkShapesArabic):
- (WebCore::SimpleFontData::getCTFont):
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::drawGDIGlyphs):
- (WebCore::Font::drawGlyphs):
- * platform/graphics/win/SimpleFontDataCGWin.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformCharWidthInit):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformDestroy):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- (WebCore::SimpleFontData::setFont):
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::initGDIFont):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::widthForGDIGlyph):
- (WebCore::SimpleFontData::scriptFontProperties):
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
-
-2009-06-04 Paul Godavari <paul@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Initialize the width of PopupMenuListBox properly for Mac Chromium.
-
- Added a test that works only with this patch applied. The test is
- a manual one, since the hit testing infrastructure in the layout
- tests sends keyboard and mouse events to the main window and not
- the cocoa control that implements the popup up, which means we can't
- select items from the popup up.
-
- https://bugs.webkit.org/show_bug.cgi?id=25904
-
-
- * manual-tests/select-narrow-width.html: Added.
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::PopupListBox):
- (WebCore::PopupContainer::showExternal):
-
-2009-06-04 Brent Fulgham <bfulgham@webkit.org>
-
- Unreviewed Windows build correction.
-
- * WebCore.vcproj/WebCore.vcproj: Add missing 'ReplaceNodeWithSpanCommand.cpp'
- and 'ReplaceNodeWithSpanCommand.h'
-
-2009-02-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Make sure execCommand("bold") on <b style="text-decoration: underline">test</b>
- only removes the bold and not the underline.
- https://bugs.webkit.org/show_bug.cgi?id=23496
-
- Test: editing/execCommand/convert-style-elements-to-spans.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSStyleDeclaration.h:
- (WebCore::CSSStyleDeclaration::isEmpty):
- * dom/NamedAttrMap.h:
- (WebCore::NamedAttrMap::isEmpty):
- * editing/ApplyStyleCommand.cpp:
- (WebCore::isUnstyledStyleSpan):
- (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
- (WebCore::ApplyStyleCommand::applyBlockStyle):
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle):
- (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
- (WebCore::ApplyStyleCommand::removeCSSStyle):
- (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
- (WebCore::ApplyStyleCommand::removeInlineStyle):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- * editing/ApplyStyleCommand.h:
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::replaceNodeWithSpanPreservingChildrenAndAttributes):
- * editing/CompositeEditCommand.h:
- * editing/RemoveNodePreservingChildrenCommand.cpp:
- (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
- * editing/ReplaceNodeWithSpanCommand.cpp: Added.
- (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
- (WebCore::swapInNodePreservingAttributesAndChildren):
- (WebCore::ReplaceNodeWithSpanCommand::doApply):
- (WebCore::ReplaceNodeWithSpanCommand::doUnapply):
- * editing/ReplaceNodeWithSpanCommand.h: Added.
- (WebCore::ReplaceNodeWithSpanCommand::create):
-
-2009-06-04 Brent Fulgham <bfulgham@webkit.org>
-
- Unreviewed build fix for Windows Cairo target.
-
- Add missing post-build command to copy history/cf contents
- to output directory.
-
- * WebCore.vcproj/WebCore.vcproj: Update Debug_Cairo and Release_Cairo
- target post-build steps with copy commands.
-
-2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6854695> Movie controller thumb fails to scale with full page zoom
-
- Account for zoom level when drawing media controller thumb on Windows.
-
- * rendering/RenderMediaControls.cpp:
- (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
-
-2009-06-04 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig.
-
- Move DOM window focus/blur out of SelectionController and into FocusController. Make sure it
- fires on the focused frame when the page activation state changes also. This is covered by an existing
- layout test (albeit badly). I have modified the test to be correct.
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setFocused):
- * page/FocusController.cpp:
- (WebCore::FocusController::setFocusedFrame):
- (WebCore::FocusController::setActive):
-
-2009-06-04 Albert J. Wong <ajwong@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=26148
- Adding in empty files to stage the extract of RenderThemeChromiumSkia
- from RenderThemeChromiumLinux and RenderThemeChromiumWindows.
-
- * rendering/RenderThemeChromiumSkia.cpp: Added.
- * rendering/RenderThemeChromiumSkia.h: Added.
-
-2009-06-04 Andrei Popescu <andreip@google.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25562
- Potential crash after ApplicationCacheStorage::storeNewestCache() fails
-
- Fix the crash by checking the return value of cacheStorage().storeNewestCache(this)
- in WebCore::ApplicationCacheGroup::checkIfLoadIsComplete. If storeNewestCache failed,
- we run the cache failure steps:
-
- 1. Fire the error events to all pending master entries, as well any other cache hosts
- currently associated with a cache in this group.
- 2. Disassociate the pending master entries from the failed new cache.
- 3. Reinstate the old "newest cache", if there was one.
-
- We also introduce two other changes:
-
- 1. a mechanism to rollback storageID changes to the in-memory resource
- objects when the storing of an ApplicationCache object fails.
-
- 2. defer removing the pending master entries from the list of pending master entries
- until the entire load is complete. This matches the HTML 5 spec better. To track
- if the load is complete we now introduce a counter for those pending master entries
- that haven't yet finshed downloading.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): initializes the new counter to 0
- (WebCore::ApplicationCacheGroup::selectCache): increments the counter when a new pending
- master entry is added.
- (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): decrements the counter
- instead of removing the pending master entry.
- (WebCore::ApplicationCacheGroup::failedLoadingMainResource): decrements the counter
- instead of removing the pending master entry.
- (WebCore::ApplicationCacheGroup::setNewestCache): removes an assertion that no longer
- holds true. In particular, the newest cache is not necessarily new anymore. We can
- set an old cache as the new cache. This can happen if we failed to store a newly
- downloaded cache to the database and we are now reinstating the former newest cache.
- (WebCore::ApplicationCacheGroup::manifestNotFound): resets the counter to 0.
- (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): check if the loading is complete
- based on the counter instead of the list of pending master entries. Empty the list of
- master entries if the load is complete.
- * loader/appcache/ApplicationCacheGroup.h: add the new counter.
- * loader/appcache/ApplicationCacheStorage.cpp: introduce the journaling mechanism for
- in-memory resource objects.
- (WebCore::ResourceStorageIDJournal::~ResourceStorageIDJournal):
- (WebCore::ResourceStorageIDJournal::add):
- (WebCore::ResourceStorageIDJournal::commit):
- (WebCore::ResourceStorageIDJournal::Record::Record):
- (WebCore::ResourceStorageIDJournal::Record::restore):
- (WebCore::ApplicationCacheStorage::store): log the changes to the in-memory resource
- objects.
- (WebCore::ApplicationCacheStorage::storeNewestCache): create the journal object.
- * loader/appcache/ApplicationCacheStorage.h: modify the signature of
- bool store(ApplicationCache*) to add a pointer to the logger object used to
- trace the changes to the storageID of the resource objects.
-
-2009-06-04 Jeremy Orlow <jorlow@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=26154
- Allow underscores in the hostnames we parse out of databaseIdentifiers.
- This code is used for HTML 5 database support.
-
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
-
-2009-06-04 Mihnea Ovidenie <mihnea@adobe.com>
-
- Reviewed by Darin Adler.
-
- Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
- https://bugs.webkit.org/show_bug.cgi?id=26084
-
- When painting multiple images, make sure that at least one image is valid before pushing a transparency layer.
-
- Added a manual test.
-
- * manual-tests/mask-composite-missing-images.html: Added.
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::paintMaskImages):
-
-2009-06-04 Jeremy Orlow <jorlow@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=26180
- Add a fast path for SecurityOrigin::equal. If "other == this" (where
- other is the other security origin), then we really don't need to do
- all the other (expensive) comparisons. We know it's equal.
-
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::equal):
-
-2009-06-03 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig.
-
- Improvements in how selection behaves with focus/activation and a reversion back to using isActive
- in the scrollbar theme code to remove a Chromium ifdef.
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::SelectionController):
- Make the controller set its focused state correctly upon initial creation.
-
- (WebCore::SelectionController::setSelection):
- Make selection willing to shift the focus node if the selection is focused even if the
- selection is not active. Whether or not the Page is active is irrelevant to focus changes.
-
- (WebCore::SelectionController::setFocused):
- * editing/SelectionController.h:
- (WebCore::SelectionController::isFocused):
- Add a new isFocused() method so that code can check if the Selection is focused without caring
- about the active state.
-
- * page/Frame.cpp:
- (WebCore::Frame::setFocusedNodeIfNeeded):
- Allow focus shifts even when the selection is not active.
-
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::paint):
- Revert Dan's change to directly talk to AppKit for checking active state. Now that the WebCore isActive
- method works, ditch the Chromium-specific #ifdef and go back to the original code.
-
-2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Darin Adler.
-
- Test: media/before-load-member-access.html
-
- https://bugs.webkit.org/show_bug.cgi?id=26081
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::played): Ensure that if m_playedTimeRanges,
- is not initialized we return a valid range, and don't attempt to use it.
-
-2009-06-03 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Implement a way to invalidate the FontCache used by the Qt port.
-
- * platform/graphics/qt/FontCacheQt.cpp:
- (WebCore::FontCache::invalidate):
-
-2009-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- https://bugs.webkit.org/show_bug.cgi?id=26015
-
- [Qt] Single-threaded QtWebKit configuration
-
- Turn off Database, DOM storage, icon database and Web Workers support
- when ENABLE_SINGLE_THREADED is turned on.
-
- Set SQLITE_THREADSAFE to false to turn off SQLite mutexes
- when ENABLE_SINGLE_THREADED is turned on.
-
- * WebCore.pro:
-
-2009-06-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - add some assertions that Font methods are used on the main thread
-
- * platform/graphics/Font.cpp:
- (WebCore::Font::setShouldUseSmoothing):
- * platform/graphics/Font.h:
- (WebCore::Font::primaryFont):
- * platform/graphics/FontFastPath.cpp:
- (WebCore::Font::glyphDataForCharacter):
-
-2009-06-03 Dan Bernstein <mitz@apple.com>
-
- - Windows build fix
-
- Rolled out apparently-accidental changes to config.h from r44398. These
- were not part of the patch as reviewed.
-
- * config.h:
-
-2009-06-03 Dmitry Titov <dimich@chromium.org>
-
- Not reviewed, Chromium build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=26177
- Reverting 'private' to 'protected' on 2 classes.
- Chromium glue layer (not yet in Webkit tree) relies on ability to derive
- Chromium-specific platform classes and access the data members.
- See bug for more details.
-
- * platform/PlatformMouseEvent.h:
- * platform/PlatformWheelEvent.h:
-
-2009-06-03 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser <simonfr@apple.com>.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=26162
-
- This corrects an error when destroying an animation
- or transition where endAnimation was never getting
- called and therefore the hardware animation was never
- getting removed.
-
- This includes a manual-test since it's really impossible
- to make a meaningful automatic test for an animation
- bug like this.
-
- This has no effect unless accelerated compositing is
- enabled.
-
- * manual-tests/interrupted-compound-transform.html: Added.
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::~ImplicitAnimation):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::~KeyframeAnimation):
-
-2009-06-03 Adam Langley <agl@google.com>
-
- Reviewed by Eric Seidel.
-
- Make the scrollbar thumb size twice the width for Chromium Linux. This
- matches Firefox on Linux.
-
- This will need layout test pixel results to be rebaselined in the
- Chromium tree.
-
- http://code.google.com/p/chromium/issues/detail?id=12602
- https://bugs.webkit.org/show_bug.cgi?id=26176
-
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- * platform/chromium/ScrollbarThemeChromiumLinux.h:
-
-2009-06-03 Adam Langley <agl@google.com>
-
- Reviewed by Eric Seidel.
-
- Change Chromium scrollbar theme code to use different classes on
- Windows and Linux rather than suppling symbols. The ScrollbarTheme
- class is already using virtual dispatch, so there's no reason not to.
-
- This should not affect any layout tests.
-
- https://bugs.webkit.org/show_bug.cgi?id=26174
-
- * platform/chromium/ScrollbarThemeChromium.cpp:
- * platform/chromium/ScrollbarThemeChromium.h:
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
- (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
- (WebCore::ScrollbarThemeChromiumLinux::paintButton):
- (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
- * platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
- * platform/chromium/ScrollbarThemeChromiumWin.cpp:
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
- (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
- (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
- (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
- (WebCore::ScrollbarThemeChromiumWin::paintButton):
- (WebCore::ScrollbarThemeChromiumWin::paintThumb):
- (WebCore::ScrollbarThemeChromiumWin::getThemeState):
- (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
- (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
- (WebCore::ScrollbarThemeChromiumWin::buttonSize):
- * platform/chromium/ScrollbarThemeChromiumWin.h: Added.
-
-2009-06-03 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Enabling debugger requires that Scripts panel is already attached to the
- render tree. The reason is that recompile events result in script sources
- being added into the source frames. Prior to the global options introduced,
- debugger was enabled from the Scripts panel, so that it was guaranteed to
- exist. The InspectorController::enableDebugger API calls with no inspector
- frontend showing were failing though.
-
- https://bugs.webkit.org/show_bug.cgi?id=26145
-
- * WebCore.base.exp:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::scriptObjectReady):
- (WebCore::InspectorController::enableDebuggerFromFrontend):
- (WebCore::InspectorController::enableDebugger):
- * inspector/InspectorController.h:
- * inspector/InspectorController.idl:
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::attachDebuggerWhenShown):
- * inspector/InspectorFrontend.h:
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.show):
- (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
- * inspector/front-end/inspector.js:
- (WebInspector.attachDebuggerWhenShown):
-
-2009-06-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - fix a regression from the previous patch
-
- * platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.
-
-2009-06-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - eliminate WebCoreTextRenderer
-
- * WebCore.base.exp: Updated.
- * WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
- and promoted WebFontCache.h to private.
- * platform/graphics/Font.cpp:
- (WebCore::Font::setShouldUseSmoothing): Added this static setter for
- a new file-static boolean.
- (WebCore::Font::shouldUseSmoothing): Added this static getter.
- * platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
- shouldUseSmoothing().
- * platform/graphics/mac/FontMac.mm:
- (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of
- WebCoreShouldUseFontSmoothing().
- * platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
- * platform/mac/WebCoreTextRenderer.h: Removed.
- * platform/mac/WebCoreTextRenderer.mm: Removed.
-
-2009-06-03 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- v8's ScriptController::evaluate should protect the Frame like the jsc version.
- https://bugs.webkit.org/show_bug.cgi?id=26172
-
- This change is simply copying protections done for Frame in the method
- WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.
-
- * bindings/v8/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
-
-2009-06-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix <rdar://problem/6841120> Use CTFontManager notifications instead
- of ATS notifications
-
- * platform/graphics/FontCache.h: Made it an error to destroy a
- FontCache instance.
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added
- this notification callback for the
- kCTFontManagerRegisteredFontsChangedNotification, which calls
- invalidate().
- (WebCore::FontCache::platformInit): Register for
- kCTFontManagerRegisteredFontsChangedNotification.
-
-2009-06-03 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.
-
- https://bugs.webkit.org/show_bug.cgi?id=26161
-
- * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
- (WebCore::drawTextWithSpacing):
-
-2009-06-03 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Reorder ResourcesPanel components initialization to unfreeze resource list scroller.
-
- https://bugs.webkit.org/show_bug.cgi?id=26159
-
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel):
-
-2009-06-03 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- - Fix for crash (preceded by assertion) in InspectorController::didCommitLoad
- when reloading or navigating with the Inspector open.
- - Fix for Inspector's Elements panel being empty when Inspector first appears.
-
- https://bugs.webkit.org/show_bug.cgi?id=26134
- https://bugs.webkit.org/show_bug.cgi?id=26135
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::scriptObjectReady):
- (WebCore::InspectorController::didLoadResourceFromMemoryCache):
- (WebCore::InspectorController::identifierForInitialRequest):
- (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
- * inspector/InspectorController.h:
-
-2009-06-03 Adam Roben <aroben@apple.com>
-
- Windows build fix after r44379
-
- * svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the
- other #includes to fix a compiler warning on Windows.
-
-2009-06-02 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Add workaround for crash in Linux Flash Player when hosted by
- another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
- issue (FP-2140).
-
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::setNPWindowIfNeeded):
-
-2009-06-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Refactor the Qt plugin code to use NPP_SetWindow correctly,
- to make resizing of plugins work.
-
- Attention was paid to make sure that the windowed plugins scroll
- synchronized with the page view. A manual test has been added.
-
- * manual-tests/qt/plugin-iframe.html: Added.
- * plugins/PluginView.cpp:
- (WebCore::PluginView::setFrameRect):
- (WebCore::PluginView::frameRectsChanged):
- * plugins/PluginView.h:
- * plugins/qt/PluginContainerQt.cpp:
- (PluginContainerQt::PluginContainerQt):
- * plugins/qt/PluginContainerQt.h:
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::load):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::paint):
- (WebCore::PluginView::setParent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::setNPWindowIfNeeded):
- (WebCore::PluginView::handlePostReadFile):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::invalidateRect):
- (WebCore::PluginView::init):
-
-2009-06-02 Darin Adler <darin@apple.com>
-
- Reviewed by David Hyatt.
-
- Bug 26112: viewless WebKit -- make events work
- https://bugs.webkit.org/show_bug.cgi?id=26112
-
- The main fix here is to make mouse and wheel event coordinates in the coordinate
- system of the top level NSView rather than the NSWindow when in the viewless mode.
- This is the design Hyatt chose, but the event part of it wasn't done yet.
-
- Also fix FrameView to do normal reference counting instead of a strange model with
- an explicit deref near creation time.
-
- * WebCore.base.exp: Updated.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file
- to reduce conditionals in the header.
- (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
-
- * page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types.
- Made currentNSEvent a static member function. Added sendContextMenuEvent and
- eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent
- can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and
- eventLoopHandleMouseDragged unconditional.
-
- * page/Frame.cpp:
- (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership.
- (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove
- the explicit deref.
-
- * page/Frame.h: Changed setView to take a PassRefPtr.
-
- * page/FrameTree.cpp: Added newly-needed include.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed
- the initialization of m_refCount and call to show from the reamining one.
- (WebCore::FrameView::create): Added two create functions that do what the two
- constructors did before, except that they return a PassRefPtr to make sure the
- reference counting is handled correctly.
- (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented
- its own reference counting.
-
- * page/FrameView.h: Inherit from RefCounted for reference counting. Made the
- constructor private and added create functions. Got rid of the hand-implemented
- reference counting in this class.
-
- * page/mac/EventHandlerMac.mm:
- (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to
- make it more clear how it relates to currentNSEvent.
- (WebCore::EventHandler::currentNSEvent): Updated.
- (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the
- current event in a foolproof way.
- (WebCore::CurrentEventScope::~CurrentEventScope): Ditto.
- (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform
- window in when constructing the PlatformWheelEvent.
- (WebCore::EventHandler::keyEvent): Use CurrentEventScope.
- (WebCore::lastEventIsMouseUp): Use currentNSEvent.
- (WebCore::EventHandler::passMouseDownEventToWidget): Ditto.
- (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
- (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto.
- (WebCore::EventHandler::passSubframeEventToSubframe): Use
- currentPlatformMouseEvent to get a mouse event that has the appropriate
- platform window passed to create it.
- (WebCore::EventHandler::passWheelEventToWidget): Ditto.
- (WebCore::EventHandler::mouseDown): Ditto.
- (WebCore::EventHandler::mouseDragged): Ditto.
- (WebCore::EventHandler::mouseUp): Ditto.
- (WebCore::EventHandler::mouseMoved): Ditto.
- (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the
- platform window that's now needed to create a PlatformMouseEvent.
- (WebCore::EventHandler::sendContextMenuEvent): Added.
- (WebCore::EventHandler::eventMayStartDrag): Added.
-
- * platform/HostWindow.h: Removed unneeded includes and constructor definition.
-
- * platform/PlatformMouseEvent.h: Sorted things in alphabetical order.
- Changed Mac constructor to take a windowView as well as the event. This is
- needed in viewless mode, since the "window" is actually an NSView, so the
- event has to know which view to compute the coordinates with. Made the
- same change to pointForEvent.
- * platform/PlatformWheelEvent.h: Ditto.
-
- * platform/mac/PlatformMouseEventMac.mm:
- (WebCore::pointForEvent): Convert point from window coordinates to view
- coordinates if a windowView is passed in. This is used in viewless mode.
- (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
- * platform/mac/WheelEventMac.mm:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.
-
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertFromContainingWindow): Fixed case where there
- is no platform widget and no parent. Before it would yield unpredictable
- results because of dispatching to a nil object and returning a structure.
- Now it returns the point without changing coordinates at all, which is what
- we need for this case in viewless mode.
-
- * rendering/RenderApplet.cpp: Removed unneeded includes.
- (WebCore::RenderApplet::intrinsicSize): Use widget function.
- (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.
-
- * rendering/RenderApplet.h: Make more things private. Get rid of unneeded
- explicit destructor.
-
- * rendering/RenderFrame.cpp: Removed unneeded includes.
- (WebCore::RenderFrame::edgeInfo): Updated to use node function so header
- doesn't have to define element function.
- (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget
- function.
-
- * rendering/RenderFrame.h: Removed unneeded includes. Made some things
- private. Got rid of element function.
-
- * rendering/RenderPart.cpp: Removed unneeded includes.
- (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function.
- (WebCore::RenderPart::setWidget): Changed to use widget function.
- (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget.
- This is now only called by the clearWidget function.
-
- * rendering/RenderPart.h: Removed unneeded forward declarations.
- Made more functions private. Updated deleteWidget to take widget argument.
-
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::~RenderPartObject): use frameView function
- instead of getting at m_view directly.
- (WebCore::RenderPartObject::updateWidget): Ditto.
- (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget.
- (WebCore::RenderPartObject::viewCleared): Ditto.
-
- * rendering/RenderPartObject.h: Made some functions private.
-
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with
- construction syntax instead of assignment.
- (WebCore::RenderWidget::destroy): Updated for name change of m_view
- to m_frameView.
- (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete
- the widget.
- (WebCore::RenderWidget::setWidget): Use clearWidget.
- (WebCore::RenderWidget::paint): Updated for name change of m_view
- to m_frameView.
- (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.
-
- * rendering/RenderWidget.h: Made many functions protected, others
- private and made all data members private.
-
- * svg/animation/SMILTime.h: Removed unhelpful max and min functions. These
- just do what std::max and std::min will already do automatically for this
- type, so they are not helpful.
-
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types
- that initialize to zero without anything explicit.
- (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are
- no longer stored.
- (WebCore::SVGImage::setContainerSize): Ditto.
- (WebCore::SVGImage::usesContainerSize): Ditto.
- (WebCore::SVGImage::size): Ditto.
- (WebCore::SVGImage::hasRelativeWidth): Ditto.
- (WebCore::SVGImage::hasRelativeHeight): Ditto.
- (WebCore::SVGImage::draw): Ditto.
- (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
- (WebCore::SVGImage::dataChanged): Ditto.
-
- * svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data
- members m_document, m_frame, m_frameView, and m_minSize.
-
-2009-06-02 Adam Langley <agl@google.com>
-
- Reviewed by Eric Seidel.
-
- The previous code was assuming that we'll be painting buttons on the scrollbar
- which isn't true on Linux. To reproduce, resize a page with scrollbars until
- they are less than two widths high.
-
- This will need pixel test baselines to be updated in the Chromium tree.
-
- * platform/chromium/ScrollbarThemeChromium.cpp: move this function...
- * platform/chromium/ScrollbarThemeChromiumWin.cpp:
- (WebCore::ScrollbarThemeChromium::trackRect): ... to here
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which
- doesn't remove the track when the scrollbar is less than two widths
- high.
-
-2009-06-02 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
-
- * Configurations/Base.xcconfig:
-
-2009-06-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Insert*List on an stand-alone image in a content editable region ASSERTS
- ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
- https://bugs.webkit.org/show_bug.cgi?id=19066
-
- Attempt to fix this by noticing that we inserted the list inside
- the selection which includes the image, and re-adjust the selection
- to not include the list before trying to move the image into
- the list item.
-
- Test: editing/execCommand/list-wrapping-image-crash.html
-
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::doApply):
-
-2009-06-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Rename PositionIterator members in hope of further clarity
- https://bugs.webkit.org/show_bug.cgi?id=24854
-
- Rename m_parent to m_anchorNode (since although it's always the parent
- of the previous m_child member, it is not always the parent of the effective position)
- Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
- directly following the position. This member is often NULL, but is always
- a child of m_parent, now m_anchorNode if set.
- Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)
-
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::operator Position):
- (WebCore::PositionIterator::increment):
- (WebCore::PositionIterator::decrement):
- (WebCore::PositionIterator::atStart):
- (WebCore::PositionIterator::atEnd):
- (WebCore::PositionIterator::atStartOfNode):
- (WebCore::PositionIterator::atEndOfNode):
- (WebCore::PositionIterator::isCandidate):
- * dom/PositionIterator.h:
- (WebCore::PositionIterator::PositionIterator):
- (WebCore::PositionIterator::node):
- (WebCore::PositionIterator::offsetInLeafNode):
-
-2009-06-02 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 17167: Failures in fast/dom/Node/initial-values.html
-
- This partly solve a compatibility issue with other browsers. It will also
- make us more consistent while handling XHTML element.
-
- The issue is that when we create an XHTML element inside an HTML document
- (as it is the case when calling createElementNS), we default to the HTML
- behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
- element, our fix is to check whether it has a prefix and then default
- to XML behaviour for nodeName.
-
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::nodeName): Add a prefix check before
- returning the uppercase tagName (HTML behaviour).
-
-2009-06-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Add a compareBoundaryPoints which takes RangeBoundaryPoints
- https://bugs.webkit.org/show_bug.cgi?id=25500
-
- I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
- This patch is almost entirely minus lines.
-
- No functional changes, thus no tests.
-
- * dom/Range.cpp:
- (WebCore::Range::setStart):
- (WebCore::Range::setEnd):
- (WebCore::Range::compareBoundaryPoints):
- (WebCore::Range::boundaryPointsValid):
- * dom/Range.h:
-
-2009-06-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
- https://bugs.webkit.org/show_bug.cgi?id=25500
-
- Darin indicated the Range should deal only with primitive DOM node/offset
- pairs, and that Position (which is a more robust editing construct) should have
- its own comparison functions and that Range.h should not mention Position at all.
-
- Turns out that Position already has a comparePositions() function (which knows
- how to additionally handled positions in shadow trees). So I've just changed
- all callers of compareBoundaryPoints(Position, Position) to use the existing
- comparePositions() function. I've also added a comparePositions which takes
- VisiblePositions for convenience.
-
- * dom/Range.cpp:
- * dom/Range.h:
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::updateStartEnd):
- (WebCore::ApplyStyleCommand::applyBlockStyle):
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::applyInlineStyle):
- (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
- (WebCore::ApplyStyleCommand::removeInlineStyle):
- (WebCore::ApplyStyleCommand::nodeFullySelected):
- (WebCore::ApplyStyleCommand::nodeFullyUnselected):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::deleteInsignificantText):
- (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
- (WebCore::CompositeEditCommand::moveParagraphs):
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::initializeStartEnd):
- (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- (WebCore::DeleteSelectionCommand::mergeParagraphs):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::nodeWillBeRemoved):
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::toNormalizedRange):
- * editing/htmlediting.cpp:
- (WebCore::comparePositions):
- * editing/htmlediting.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEventSingleClick):
-
-2009-06-02 Albert J. Wong <ajwong@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=26122
- Upstream v8_utility.h functions into V8Utilities.h. This patch has
- some transitional code to make upstreaming easier. This code will
- be deleted in a few days.
-
- * bindings/v8/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
- * bindings/v8/V8Utilities.h:
- (WebCore::AllowAllocation::AllowAllocation): Function added.
- (WebCore::AllowAllocation::~AllowAllocation): Function added.
- (WebCore::SafeAllocation::NewInstance): Function added.
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- NewInstance -> newInstance.
- (WebCore::WorkerContextExecutionProxy::toV8): NewInstance ->
- newInstance.
-
-2009-06-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix <rdar://problem/6940747> Search field’s focus ring is outset
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused
- search field outline offset to -2.
-
-2009-06-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Add list of unimplemented event handlers to DOMWindow.
-
- * page/DOMWindow.idl:
-
-2009-06-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=26133
- Adapt and import py-dom-xpath tests
-
- Tests: fast/xpath/py-dom-xpath/abbreviations.html
- fast/xpath/py-dom-xpath/axes.html
- fast/xpath/py-dom-xpath/data.html
- fast/xpath/py-dom-xpath/expressions.html
- fast/xpath/py-dom-xpath/functions.html
- fast/xpath/py-dom-xpath/nodetests.html
- fast/xpath/py-dom-xpath/paths.html
- fast/xpath/py-dom-xpath/predicates.html
-
- Fix bugs found with this test suite:
- - name and local-name were incorrect for processing instructions (XPath expanded-name
- doesn't match DOM exactly);
- - name, local-name and namespace functions should crash on attribute nodes;
- - attemps to make node sets from other types were not detected as errors.
-
- No performance impact.
-
- * xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation.
- An error won't stop evaluation, but an exception will be raised afterwards. We could also
- detect conversion errors at compile time, but not if we're going to support XPath variables
- (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own
- XSLT one day).
-
- * xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type
- conversion exception occurred during evaluation, and raise an excpetion if it did.
-
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::expandedNameLocalPart):
- (WebCore::XPath::expandedName):
- XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name,
- which doesn't match anything available via DOM exactly. Calculate the expanded name properly.
- (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an
- attribute node, because it released what was possibly the only reference to attribute node
- before using it. Changed the function to avoid such situation.
- (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart()
- to work properly with processing instruction nodes.
- (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()).
- (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set
- (by using toNodeSet unconditionally, which will raise an error, and return an empty set).
-
- * xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression
- evaluation result is not a node-set.
-
- * xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually
- always a node-set (this is not so for FilterExpr production in the spec, but is for us,
- because we don't naively map BNF productions to classes).
-
- * xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side
- is not a node-set.
-
- * xml/XPathStep.cpp: Removed an unnecesary include.
-
- * xml/XPathValue.cpp:
- (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails.
- (WebCore::XPath::Value::modifiableNodeSet): Ditto.
- (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production
- (in particular, those using exponential notation).
-
-2009-06-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Brady Eidson.
-
- Part of https://bugs.webkit.org/show_bug.cgi?id=26100
- Add missing event handler properties to the DOMWindow
-
- Added oncontextmenu, oninput, and onmessage event handlers to
- the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
- and onsuspend event handlers were implemented but not added to
- DOMWindow.idl.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::oninput):
- (WebCore::DOMWindow::setOninput):
- (WebCore::DOMWindow::onmessage):
- (WebCore::DOMWindow::setOnmessage):
- (WebCore::DOMWindow::oncontextmenu):
- (WebCore::DOMWindow::setOncontextmenu):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-06-01 Jeremy Orlow <jorlow@chromium.org>
-
- Reviewed by Darin Adler. Landed by Adam Barth.
-
- https://bugs.webkit.org/show_bug.cgi?id=26123
-
- Remove a redundant checkEncodedString call when constructing a
- KURL object from a string.
-
- * platform/KURL.cpp:
- (WebCore::KURL::KURL):
-
-2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
- Bad Dimitri.
-
- * platform/KeyboardCodes.h: Repositioned the guard to avoid nested
- WebCore namespace declarations.
-
-2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- * platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h
- with a stern FIXME.
- * platform/chromium/KeyboardCodes.h: Removed.
-
-2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric Seidel.
-
- Fix assertion error in --filters enabled debug builds.
- Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.
-
- * svg/graphics/filters/SVGFilterBuilder.cpp:
- (WebCore::SVGFilterBuilder::SVGFilterBuilder):
- (WebCore::SVGFilterBuilder::add):
- (WebCore::SVGFilterBuilder::getEffectById):
- * svg/graphics/filters/SVGFilterBuilder.h:
-
-2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric Seidel.
-
- Fix --filters enabled build on Mac.
- Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
- Kill several warnings, to make build pass.
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::paint):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::paint):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::paint):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::finishRenderSVGContent):
- * rendering/SVGRenderSupport.h:
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
- * svg/SVGFEGaussianBlurElement.cpp:
- (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
- * svg/graphics/filters/SVGFEFlood.cpp:
- (WebCore::FEFlood::FEFlood):
-
-2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- Fix Chromium build by adding an #ifdef, restoring the code path to that
- before http://trac.webkit.org/changeset/44287.
-
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.
-
-2009-06-01 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Remove last pieces of the old SVG filter system. They are not
- usable with our current filter system. The new filter effects
- will replace the functionality step by step.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * svg/graphics/cairo: Removed.
- * svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
- * svg/graphics/cg: Removed.
- * svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
- * svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
- * svg/graphics/filters/SVGFilterEffect.cpp: Removed.
- * svg/graphics/filters/SVGFilterEffect.h: Removed.
- * svg/graphics/filters/cg: Removed.
- * svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
- * svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
- * svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
- * svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
- * svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
- * svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
- * svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
- * svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
- * svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
- * svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
- * svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
- * svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
- * svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
- * svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
- * svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
- * svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
- * svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
- * svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
- * svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
- * svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
- * svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
- * svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
- * svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
- * svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
- * svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
- * svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
- * svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
- * svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
- * svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
- * svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
- * svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
- * svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
- * svg/graphics/mac: Removed.
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
- * svg/graphics/qt: Removed.
- * svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
- * svg/graphics/skia: Removed.
- * svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.
-
-2009-06-01 Dmitry Titov <dimich@chromium.org>
-
- Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
- This adds a comment suggested during review.
-
- * platform/ThreadGlobalData.cpp:
- (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.
-
-2009-06-01 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25973
- Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
- Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
- for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
- the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
- the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
- in establishIdentifierForPthreadHandle() since the id is already in the map.
-
- The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
- on OSX Chromium and will stop failing after this change.
-
- * platform/ThreadGlobalData.h:
- * platform/ThreadGlobalData.cpp:
- (WebCore::ThreadGlobalData::~ThreadGlobalData):
- Store the result of "isMainThread()" in a member variable during construction of thread-specific data
- to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.
-
-2009-06-01 David Levin <levin@chromium.org>
-
- Reviewed by Darin Alder and Maciej Stachowiak.
-
- Bug 26057: StringImpl should share buffers with UString.
- https://bugs.webkit.org/show_bug.cgi?id=26057
-
- This change results in the following performance improvements:
- On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
- the time went from 78ms to 40ms for append (other times remained constant).
-
- On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
- the time went from 3900ms to 2600ms.
-
- For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
- Other tests in dom seemed to be faster across several runs but within the
- margin of error (except DOM Attributes which was slightly ~1.5% worse).
-
- Existing tests cover this code and there is no new functionality
- that is exposed to test.
-
- * platform/text/AtomicString.cpp:
- (WebCore::AtomicString::add):
- * platform/text/String.cpp:
- (WebCore::String::String):
- (WebCore::String::operator UString):
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::StringImpl):
- (WebCore::StringImpl::~StringImpl):
- (WebCore::StringImpl::create): Consumes a shared buffer.
- (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString.
- (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
- * platform/text/StringImpl.h:
- (WebCore::StringImpl::hasTerminatingNullCharacter):
- (WebCore::StringImpl::inTable):
- (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags
- to avoid growing StringImpl in size.
-
-2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- V8 bindings follow-up to to DOMWindow-related cleanup:
- http://trac.webkit.org/changeset/44215
-
- * bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated
- its body to destructor.
- * bindings/v8/ScriptController.h: Removed disconnectFrame() decl.
-
-2009-05-28 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- - Add panel enabler to the resources panel.
- - Add session / always options into the panel enabler.
- - Make enabled status for three panels sticky (globally).
- - Persist enabled status using InspectorController::Settings
- - Make InspectorController produce no network-related overhead when
- resources panel is not enabled.
-
- https://bugs.webkit.org/show_bug.cgi?id=26046
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::populateScriptObjects):
- (WebCore::InspectorController::identifierForInitialRequest):
- (WebCore::InspectorController::willSendRequest):
- (WebCore::InspectorController::didReceiveResponse):
- (WebCore::InspectorController::didReceiveContentLength):
- (WebCore::InspectorController::didFinishLoading):
- (WebCore::InspectorController::didFailLoading):
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- (WebCore::InspectorController::scriptImported):
- (WebCore::InspectorController::enableResourceTracking):
- (WebCore::InspectorController::disableResourceTracking):
- (WebCore::InspectorController::startUserInitiatedProfiling):
- (WebCore::InspectorController::enableProfiler):
- (WebCore::InspectorController::disableProfiler):
- (WebCore::InspectorController::enableDebugger):
- (WebCore::InspectorController::disableDebugger):
- * inspector/InspectorController.h:
- (WebCore::InspectorController::Setting::Setting):
- (WebCore::InspectorController::resourceTrackingEnabled):
- * inspector/InspectorController.idl:
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::resourceTrackingWasEnabled):
- (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
- * inspector/InspectorFrontend.h:
- * inspector/front-end/PanelEnablerView.js:
- (WebInspector.PanelEnablerView.enableOption):
- (WebInspector.PanelEnablerView):
- (WebInspector.PanelEnablerView.prototype._windowResized):
- (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
- * inspector/front-end/ProfilesPanel.js:
- (WebInspector.ProfilesPanel.prototype._enableProfiling):
- (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel):
- (WebInspector.ResourcesPanel.prototype.get statusBarItems):
- (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
- (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled):
- (WebInspector.ResourcesPanel.prototype.reset):
- (WebInspector.ResourcesPanel.prototype._updateSidebarWidth):
- (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
- (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype._enableDebugging):
- (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- * inspector/front-end/inspector.css:
- * inspector/front-end/inspector.js:
- (WebInspector.resourceTrackingWasEnabled):
- (WebInspector.resourceTrackingWasDisabled):
-
-2009-06-01 Drew Wilson <atwilson@google.com>
-
- Reviewed by Darin Adler. Landed (and tweaked) by Adam Barth.
-
- https://bugs.webkit.org/show_bug.cgi?id=25902
-
- Added WorkerContext.close()
-
- Test: fast/workers/worker-close.html
-
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::close):
- * workers/WorkerContext.h:
- * workers/WorkerContext.idl:
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
-
-2009-06-01 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=12471
- XPathResult not invalidated for documents retrieved via XMLHttpRequest
-
- Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.
-
- Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
- reliable and much faster.
-
- * xml/XPathExpression.cpp:
- (WebCore::XPathExpression::evaluate):
- * xml/XPathResult.cpp:
- (WebCore::XPathResult::XPathResult):
- (WebCore::XPathResult::~XPathResult):
- (WebCore::XPathResult::invalidIteratorState):
- (WebCore::XPathResult::iterateNext):
- * xml/XPathResult.h:
- (WebCore::XPathResult::create):
-
-2009-06-01 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Adler. Landed by Adam Barth.
-
- https://bugs.webkit.org/show_bug.cgi?id=25750
-
- Test: fast/transforms/bounding-rect-zoom.html
-
- Make getClientRects and getBoundingClientRect account for ther zoom
- factor.
-
- * dom/Element.cpp:
- (WebCore::adjustFloatPointForAbsoluteZoom):
- (WebCore::adjustFloatQuadForAbsoluteZoom):
- (WebCore::adjustIntRectForAbsoluteZoom):
- (WebCore::Element::getClientRects):
- (WebCore::Element::getBoundingClientRect):
-
-2009-06-01 Tony Chang <tony@chromium.org>
-
- Reviewed by Dimitri Glazkov. Landed by Adam Barth.
-
- https://bugs.webkit.org/show_bug.cgi?id=26026
-
- Fix an infinite loop when using the keyboard in Chromium select
- popups.
-
- Not testable since it involves sending a keyboard event to
- the popup, which is not possible (eventSender sends the key
- events through webview, we want to go through the webwidget).
-
- * platform/chromium/PopupMenuChromium.cpp:
-
-2009-06-01 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov. Landed by Adam Barth.
-
- If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
- has finished loading compeltely or the user has manually scrolled. Refreshing an anchor url after
- scrolling to a new location on the page will still result in jumping to the new location.
-
- https://bugs.webkit.org/show_bug.cgi?id=26034
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor.
- (WebCore::FrameLoader::completed): Release anchor lock.
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView): Ensure anchor lock starts unset.
- (WebCore::FrameView::reset): Ensure anchor lock starts unset.
- (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout.
- (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins.
- (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls.
- (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
- * page/FrameView.h:
- (WebCore::FrameView::lockedToAnchor): Added.
- (WebCore::FrameView::setLockedToAnchor): Added.
-
-2009-05-31 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- A short clean-up. FilterBuilder is SVG specific. Move it
- to svg/graphics/filters and rename it to SVGFilterBuilder.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * svg/FilterBuilder.cpp: Removed.
- * svg/FilterBuilder.h: Removed.
- * svg/SVGFilterElement.cpp:
- * svg/SVGFilterPrimitiveStandardAttributes.h:
- * svg/graphics/SVGResourceFilter.cpp:
- (WebCore::SVGResourceFilter::SVGResourceFilter):
- * svg/graphics/SVGResourceFilter.h:
- (WebCore::SVGResourceFilter::builder):
- * svg/graphics/filters/SVGFilterBuilder.cpp: Added.
- (WebCore::SVGFilterBuilder::SVGFilterBuilder):
- (WebCore::SVGFilterBuilder::add):
- (WebCore::SVGFilterBuilder::getEffectById):
- (WebCore::SVGFilterBuilder::clearEffects):
- * svg/graphics/filters/SVGFilterBuilder.h: Added.
- (WebCore::SVGFilterBuilder::lastEffect):
-
-2009-05-31 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=13233
- Need to implement an optimizing XPath evaluator
-
- Avoid sorting results of hierarchical paths that are naturally sorted. On a flat data structure
- with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
- to 33 ms.
-
- * xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint,
- which is useful for optimization.
- (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one.
- (WebCore::XPath::NodeSet::operator=): Ditto.
- (WebCore::XPath::NodeSet::swap): Ditto.
- (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort()
- was never called.
- (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is
- maintained by callers.
- (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree.
- Currently, the only way for a set to gain this flag is to be produced from a single element
- set with a hierarchical location path.
-
- * xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid
- maintaining a set of unique nodes, and to avoid sorting the result.
-
-2009-05-31 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=13233
- Need to implement an optimizing XPath evaluator
-
- This patch adds some infrastructure and simple optimizations. Namely,
- - we now avoid building a full NodeSet just to evaluate a predicate in some cases;
- - "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;
-
- * xml/XPathExpressionNode.cpp:
- (WebCore::XPath::Expression::Expression):
- * xml/XPathExpressionNode.h:
- (WebCore::XPath::Expression::addSubExpression):
- (WebCore::XPath::Expression::isContextNodeSensitive):
- (WebCore::XPath::Expression::isContextPositionSensitive):
- (WebCore::XPath::Expression::isContextSizeSensitive):
- (WebCore::XPath::Expression::setIsContextNodeSensitive):
- (WebCore::XPath::Expression::setIsContextPositionSensitive):
- (WebCore::XPath::Expression::setIsContextSizeSensitive):
- XPath expression now knows its result type, and whether evaluation depends on context.
-
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::FunLast::resultType):
- (WebCore::XPath::FunLast::FunLast):
- (WebCore::XPath::FunPosition::resultType):
- (WebCore::XPath::FunPosition::FunPosition):
- (WebCore::XPath::FunCount::resultType):
- (WebCore::XPath::FunId::resultType):
- (WebCore::XPath::FunLocalName::resultType):
- (WebCore::XPath::FunLocalName::FunLocalName):
- (WebCore::XPath::FunNamespaceURI::resultType):
- (WebCore::XPath::FunNamespaceURI::FunNamespaceURI):
- (WebCore::XPath::FunName::resultType):
- (WebCore::XPath::FunName::FunName):
- (WebCore::XPath::FunString::resultType):
- (WebCore::XPath::FunString::FunString):
- (WebCore::XPath::FunConcat::resultType):
- (WebCore::XPath::FunStartsWith::resultType):
- (WebCore::XPath::FunContains::resultType):
- (WebCore::XPath::FunSubstringBefore::resultType):
- (WebCore::XPath::FunSubstringAfter::resultType):
- (WebCore::XPath::FunSubstring::resultType):
- (WebCore::XPath::FunStringLength::resultType):
- (WebCore::XPath::FunStringLength::FunStringLength):
- (WebCore::XPath::FunNormalizeSpace::resultType):
- (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace):
- (WebCore::XPath::FunTranslate::resultType):
- (WebCore::XPath::FunBoolean::resultType):
- (WebCore::XPath::FunNot::resultType):
- (WebCore::XPath::FunTrue::resultType):
- (WebCore::XPath::FunFalse::resultType):
- (WebCore::XPath::FunLang::resultType):
- (WebCore::XPath::FunLang::FunLang):
- (WebCore::XPath::FunNumber::resultType):
- (WebCore::XPath::FunNumber::FunNumber):
- (WebCore::XPath::FunSum::resultType):
- (WebCore::XPath::FunFloor::resultType):
- (WebCore::XPath::FunCeiling::resultType):
- (WebCore::XPath::FunRound::resultType):
- (WebCore::XPath::Function::setArguments):
- Set optimization details for the expression. Normally, a function does not introduce context
- node set dependency, but some use context node as default argument, or otherwise use the context.
-
- * xml/XPathFunctions.h: Tweaked style.
-
- * xml/XPathPath.cpp:
- (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is.
- (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive,
- and only if the path relative.
- (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations.
- (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
- (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
-
- * xml/XPathPath.h:
- (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression
- (useful filters return NodeSets, of course).
- (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set
- insensitive.
- (WebCore::XPath::LocationPath::resultType): A path's result is always a node set.
- (WebCore::XPath::Path::resultType): Ditto.
-
- * xml/XPathPredicate.h:
- (WebCore::XPath::Number::resultType): Return a proper result type.
- (WebCore::XPath::StringExpression::resultType): Ditto.
- (WebCore::XPath::Negative::resultType): Ditto.
- (WebCore::XPath::NumericOp::resultType): Ditto.
- (WebCore::XPath::EqTestOp::resultType): Ditto.
- (WebCore::XPath::LogicalOp::resultType): Ditto.
- (WebCore::XPath::Union::resultType): Ditto.
- (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position
- sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5].
- (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
-
- * xml/XPathStep.h:
- (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously
- borrowed from XPath 2.0 to express some optimizations.
- (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and
- filtering it with predicates, we now try to apply predicates while enumerating an axis.
- (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
-
- * xml/XPathStep.cpp:
- (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still
- possible to copy NodeTests.
- (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible.
- (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "//".
- (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only
- possible if there are no context sensitive predicates for "//".
- (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate.
- (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring
- merged predicates.
- (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position.
- (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code
- path.
-
- * xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable
- references are not used with XPathEvaluator, so we'll only need them if we decide to
- reimplement XSLT. The type of variable reference is not known at compile time.
-
-2009-05-31 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Dan Bernstein.
-
- Remove unused JSEventTargetBase.h
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSEventTargetBase.h: Removed.
-
-2009-05-31 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Part of https://bugs.webkit.org/show_bug.cgi?id=26100
- Add missing event handler properties to the DOMWindow
-
- Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
- onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
- onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
- onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
- ondragend, ondragenter, ondragleave, ondragover, ondragstart and
- ondrop event handlers to the DOMWindow.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::ondrag):
- (WebCore::DOMWindow::setOndrag):
- (WebCore::DOMWindow::ondragend):
- (WebCore::DOMWindow::setOndragend):
- (WebCore::DOMWindow::ondragenter):
- (WebCore::DOMWindow::setOndragenter):
- (WebCore::DOMWindow::ondragleave):
- (WebCore::DOMWindow::setOndragleave):
- (WebCore::DOMWindow::ondragover):
- (WebCore::DOMWindow::setOndragover):
- (WebCore::DOMWindow::ondragstart):
- (WebCore::DOMWindow::setOndragstart):
- (WebCore::DOMWindow::ondrop):
- (WebCore::DOMWindow::setOndrop):
- (WebCore::DOMWindow::oncanplay):
- (WebCore::DOMWindow::setOncanplay):
- (WebCore::DOMWindow::oncanplaythrough):
- (WebCore::DOMWindow::setOncanplaythrough):
- (WebCore::DOMWindow::ondurationchange):
- (WebCore::DOMWindow::setOndurationchange):
- (WebCore::DOMWindow::onemptied):
- (WebCore::DOMWindow::setOnemptied):
- (WebCore::DOMWindow::onended):
- (WebCore::DOMWindow::setOnended):
- (WebCore::DOMWindow::onloadeddata):
- (WebCore::DOMWindow::setOnloadeddata):
- (WebCore::DOMWindow::onloadedmetadata):
- (WebCore::DOMWindow::setOnloadedmetadata):
- (WebCore::DOMWindow::onpause):
- (WebCore::DOMWindow::setOnpause):
- (WebCore::DOMWindow::onplay):
- (WebCore::DOMWindow::setOnplay):
- (WebCore::DOMWindow::onplaying):
- (WebCore::DOMWindow::setOnplaying):
- (WebCore::DOMWindow::onratechange):
- (WebCore::DOMWindow::setOnratechange):
- (WebCore::DOMWindow::onseeked):
- (WebCore::DOMWindow::setOnseeked):
- (WebCore::DOMWindow::onseeking):
- (WebCore::DOMWindow::setOnseeking):
- (WebCore::DOMWindow::ontimeupdate):
- (WebCore::DOMWindow::setOntimeupdate):
- (WebCore::DOMWindow::onvolumechange):
- (WebCore::DOMWindow::setOnvolumechange):
- (WebCore::DOMWindow::onwaiting):
- (WebCore::DOMWindow::setOnwaiting):
- (WebCore::DOMWindow::onloadstart):
- (WebCore::DOMWindow::setOnloadstart):
- (WebCore::DOMWindow::onprogress):
- (WebCore::DOMWindow::setOnprogress):
- (WebCore::DOMWindow::onstalled):
- (WebCore::DOMWindow::setOnstalled):
- (WebCore::DOMWindow::onsuspend):
- (WebCore::DOMWindow::setOnsuspend):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-05-31 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Part of https://bugs.webkit.org/show_bug.cgi?id=26100
- Add missing event handler properties to the DOMWindow
-
- Add missing onstorage event handler to the DOMWindow.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::onstorage):
- (WebCore::DOMWindow::setOnstorage):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-05-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
- Update online/offline events to match the current spec.
- - Also adds window.ononline and window.onoffline event handler
- properties.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::onoffline):
- (WebCore::DOMWindow::setOnoffline):
- (WebCore::DOMWindow::ononline):
- (WebCore::DOMWindow::setOnonline):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
- * page/Page.cpp:
- (WebCore::networkStateChanged):
-
-2009-05-31 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
- and replace it by a platform independent code. Calculation of subRegions
- is missing but needed for a first filter effect.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/filters/Filter.h:
- (WebCore::Filter::~Filter):
- (WebCore::Filter::setSourceImage):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- (WebCore::SVGRenderBase::finishRenderSVGContent):
- * svg/FilterBuilder.h:
- (WebCore::FilterBuilder::lastEffect):
- * svg/SVGFEBlendElement.cpp:
- (WebCore::SVGFEBlendElement::SVGFEBlendElement):
- (WebCore::SVGFEBlendElement::build):
- * svg/SVGFEBlendElement.h:
- * svg/SVGFEColorMatrixElement.cpp:
- (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
- (WebCore::SVGFEColorMatrixElement::build):
- * svg/SVGFEColorMatrixElement.h:
- * svg/SVGFEComponentTransferElement.cpp:
- (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
- (WebCore::SVGFEComponentTransferElement::build):
- * svg/SVGFEComponentTransferElement.h:
- * svg/SVGFECompositeElement.cpp:
- (WebCore::SVGFECompositeElement::SVGFECompositeElement):
- (WebCore::SVGFECompositeElement::build):
- * svg/SVGFECompositeElement.h:
- * svg/SVGFEDiffuseLightingElement.cpp:
- (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
- (WebCore::SVGFEDiffuseLightingElement::build):
- * svg/SVGFEDiffuseLightingElement.h:
- * svg/SVGFEDisplacementMapElement.cpp:
- (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
- (WebCore::SVGFEDisplacementMapElement::build):
- * svg/SVGFEDisplacementMapElement.h:
- * svg/SVGFEFloodElement.cpp:
- (WebCore::SVGFEFloodElement::SVGFEFloodElement):
- (WebCore::SVGFEFloodElement::build):
- * svg/SVGFEFloodElement.h:
- * svg/SVGFEGaussianBlurElement.cpp:
- (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
- (WebCore::SVGFEGaussianBlurElement::build):
- * svg/SVGFEGaussianBlurElement.h:
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::SVGFEImageElement):
- (WebCore::SVGFEImageElement::notifyFinished):
- (WebCore::SVGFEImageElement::build):
- * svg/SVGFEImageElement.h:
- * svg/SVGFEMergeElement.cpp:
- (WebCore::SVGFEMergeElement::SVGFEMergeElement):
- (WebCore::SVGFEMergeElement::build):
- * svg/SVGFEMergeElement.h:
- * svg/SVGFEOffsetElement.cpp:
- (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
- (WebCore::SVGFEOffsetElement::build):
- * svg/SVGFEOffsetElement.h:
- * svg/SVGFESpecularLightingElement.cpp:
- (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
- (WebCore::SVGFESpecularLightingElement::build):
- * svg/SVGFESpecularLightingElement.h:
- * svg/SVGFETileElement.cpp:
- (WebCore::SVGFETileElement::SVGFETileElement):
- (WebCore::SVGFETileElement::build):
- * svg/SVGFETileElement.h:
- * svg/SVGFETurbulenceElement.cpp:
- (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
- (WebCore::SVGFETurbulenceElement::build):
- * svg/SVGFETurbulenceElement.h:
- * svg/SVGFilterElement.cpp:
- (WebCore::SVGFilterElement::canvasResource):
- * svg/SVGFilterPrimitiveStandardAttributes.cpp:
- (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- * svg/SVGFilterPrimitiveStandardAttributes.h:
- (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
- * svg/graphics/SVGResourceFilter.cpp:
- (WebCore::SVGResourceFilter::SVGResourceFilter):
- (WebCore::SVGResourceFilter::addFilterEffect):
- (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
- (WebCore::SVGResourceFilter::prepareFilter):
- (WebCore::SVGResourceFilter::applyFilter):
- (WebCore::SVGResourceFilter::externalRepresentation):
- * svg/graphics/SVGResourceFilter.h:
- (WebCore::SVGResourceFilter::filterBoundingBox):
- (WebCore::SVGResourceFilter::setFilterBoundingBox):
- (WebCore::SVGResourceFilter::itemBoundingBox):
- (WebCore::SVGResourceFilter::setItemBoundingBox):
- (WebCore::SVGResourceFilter::builder):
-
-2009-05-31 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
- This change helps creating test cases, once filters are activated.
-
- * svg/SVGFEFloodElement.cpp:
- (WebCore::SVGFEFloodElement::SVGFEFloodElement):
- (WebCore::SVGFEFloodElement::parseMappedAttribute):
- (WebCore::SVGFEFloodElement::build):
- * svg/SVGFEFloodElement.h:
- * svg/SVGFEFloodElement.idl:
- * svg/graphics/filters/SVGFEFlood.cpp:
- (WebCore::FEFlood::FEFlood):
- (WebCore::FEFlood::create):
- * svg/graphics/filters/SVGFEFlood.h:
-
-2009-05-31 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- Replace all occurrences of SVGResourceFilter by Filter. This is the last
- step for a SVG independent filter system. Every other part of WebCore can
- use the filter system by creating a new Filter object.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/filters/FEBlend.cpp:
- (WebCore::FEBlend::apply):
- * platform/graphics/filters/FEBlend.h:
- * platform/graphics/filters/FEColorMatrix.cpp:
- (WebCore::FEColorMatrix::apply):
- * platform/graphics/filters/FEColorMatrix.h:
- * platform/graphics/filters/FEComponentTransfer.cpp:
- (WebCore::FEComponentTransfer::apply):
- * platform/graphics/filters/FEComponentTransfer.h:
- * platform/graphics/filters/FEComposite.cpp:
- (WebCore::FEComposite::apply):
- * platform/graphics/filters/FEComposite.h:
- * platform/graphics/filters/Filter.h: Added.
- (WebCore::Filter::setSourceImage):
- (WebCore::Filter::sourceImage):
- * platform/graphics/filters/FilterEffect.h:
- * platform/graphics/filters/SourceAlpha.cpp:
- (WebCore::SourceAlpha::apply):
- * platform/graphics/filters/SourceAlpha.h:
- * platform/graphics/filters/SourceGraphic.cpp:
- (WebCore::SourceGraphic::apply):
- * platform/graphics/filters/SourceGraphic.h:
- * svg/Filter.cpp: Removed.
- * svg/Filter.h: Removed.
- * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
- (WebCore::FEConvolveMatrix::apply):
- * svg/graphics/filters/SVGFEConvolveMatrix.h:
- * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- (WebCore::FEDiffuseLighting::apply):
- * svg/graphics/filters/SVGFEDiffuseLighting.h:
- * svg/graphics/filters/SVGFEDisplacementMap.cpp:
- (WebCore::FEDisplacementMap::apply):
- * svg/graphics/filters/SVGFEDisplacementMap.h:
- * svg/graphics/filters/SVGFEFlood.cpp:
- (WebCore::FEFlood::apply):
- * svg/graphics/filters/SVGFEFlood.h:
- * svg/graphics/filters/SVGFEGaussianBlur.cpp:
- (WebCore::FEGaussianBlur::apply):
- * svg/graphics/filters/SVGFEGaussianBlur.h:
- * svg/graphics/filters/SVGFEImage.cpp:
- (WebCore::FEImage::apply):
- * svg/graphics/filters/SVGFEImage.h:
- * svg/graphics/filters/SVGFEMerge.cpp:
- (WebCore::FEMerge::apply):
- * svg/graphics/filters/SVGFEMerge.h:
- * svg/graphics/filters/SVGFEMorphology.cpp:
- (WebCore::FEMorphology::apply):
- * svg/graphics/filters/SVGFEMorphology.h:
- * svg/graphics/filters/SVGFEOffset.cpp:
- (WebCore::FEOffset::apply):
- * svg/graphics/filters/SVGFEOffset.h:
- * svg/graphics/filters/SVGFESpecularLighting.cpp:
- (WebCore::FESpecularLighting::apply):
- * svg/graphics/filters/SVGFESpecularLighting.h:
- * svg/graphics/filters/SVGFETile.cpp:
- (WebCore::FETile::apply):
- * svg/graphics/filters/SVGFETile.h:
- * svg/graphics/filters/SVGFETurbulence.cpp:
- (WebCore::FETurbulence::apply):
- * svg/graphics/filters/SVGFETurbulence.h:
- * svg/graphics/filters/SVGFilter.cpp: Added.
- (WebCore::SVGFilter::SVGFilter):
- (WebCore::SVGFilter::calculateEffectSubRegion):
- (WebCore::SVGFilter::create):
- * svg/graphics/filters/SVGFilter.h: Added.
-
-2009-05-30 Kevin Ollivier <kevino@theolliviers.com>
-
- Build fix for platforms without plugins support.
-
- * plugins/PluginViewNone.cpp:
- (WebCore::PluginView::userAgentStatic):
- (WebCore::PluginView::getValueStatic):
-
-2009-05-30 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979
-
- Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
- Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
-
-2009-05-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
- Make storage events match the current spec.
- - Storage event listeners are added to the window.
- - Storage events are dispatched to the window.
-
- Updated existing tests.
-
- * dom/Document.cpp:
- (WebCore::Document::dispatchWindowEvent):
- * dom/Document.h:
- * dom/Node.cpp:
- * dom/Node.h:
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * storage/LocalStorageArea.cpp:
- (WebCore::LocalStorageArea::dispatchStorageEvent):
- * storage/SessionStorageArea.cpp:
- (WebCore::SessionStorageArea::dispatchStorageEvent):
-
-2009-05-30 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element
-
- Test: fast/forms/focus-control-to-page.html
-
- * dom/SelectElement.h: Made destructor protected. Tweaked a bit.
-
- * html/HTMLSelectElement.cpp: Removed unneeded includes.
- (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the
- result of optionToListIndex.
- (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the
- unused attribute, m_minwidth.
- (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix.
- Call through to the base class defaultEventHandler if the event hasn't
- been handled yet.
-
- * html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions
- private. Removed unused minWidth function and m_minwidth data member.
-
-2009-05-30 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Holger Freyther.
-
- The two KeyboardCodes.h files are basically identical and the
- qt one is properly #ifdef-ed for different win32 systems. Share
- them between Qt and Gtk implementations.
-
- * GNUmakefile.am:
- * platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
- * platform/gtk/KeyboardCodes.h: Removed.
- * platform/qt/KeyboardCodes.h: Removed.
-
-2009-05-30 Jeremy Orlow <jorlow@chromium.org>
-
- Reviewed by Sam Weinig.
-
- LocalStorage and SessionStorage's implicit setters do not correctly
- handle null. The custom JS bindings should convert to strings
- unconditionally and not try to handle null specially.
- https://bugs.webkit.org/show_bug.cgi?id=25970
-
- Tests: storage/domstorage/localstorage/string-conversion.html
- storage/domstorage/sessionstorage/string-conversion.html
-
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::customPut):
-
-2009-05-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll
- bars in key window draw as inactive if the WebView is not active
-
- Test: platform/mac/scrollbars/key-window-not-first-responder.html
-
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead
- of the WebView's first responder state to switch between active and
- inactive state.
-
-2009-05-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=18445
- <rdar://problem/5931174> Assertion failure in CSSGradientValue::image
- with -webkit-gradient as body's background
-
- Test: fast/backgrounds/body-generated-image-propagated-to-root.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this
- is the root element painting a background layer propagated from the
- body, and if it is, use the body's renderer as the client to
- StyleImage::image().
-
-2009-05-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix for AXObjectCache.
-
- For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
- that into the #ifdef.
-
- * accessibility/AXObjectCache.cpp:
-
-2009-05-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072
-
- Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
- the same functionality HTMLSelectElement has. The WML specific features will follow soon.
-
- Add simple testcase covering <select> element rendering: fast/wml/select.wml
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::optionIndex):
- (WebCore::isOptionElement):
- * dom/OptionElement.h:
- * dom/OptionGroupElement.cpp:
- (WebCore::isOptionGroupElement):
- * dom/OptionGroupElement.h:
- * dom/SelectElement.cpp:
- (WebCore::SelectElement::accessKeySetSelectedIndex):
- (WebCore::toSelectElement):
- * dom/SelectElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::index):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::paintItemForeground):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::itemIsEnabled):
- (WebCore::RenderMenuList::itemIsLabel):
- * wml/WMLFormControlElement.cpp:
- (WebCore::WMLFormControlElement::attach):
- (WebCore::WMLFormControlElement::recalcStyle):
- * wml/WMLFormControlElement.h:
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::attach):
- * wml/WMLOptGroupElement.cpp:
- (WebCore::WMLOptGroupElement::insertBefore):
- (WebCore::WMLOptGroupElement::replaceChild):
- (WebCore::WMLOptGroupElement::removeChild):
- (WebCore::WMLOptGroupElement::appendChild):
- (WebCore::WMLOptGroupElement::removeChildren):
- (WebCore::ownerSelectElement):
- (WebCore::WMLOptGroupElement::accessKeyAction):
- (WebCore::WMLOptGroupElement::childrenChanged):
- (WebCore::WMLOptGroupElement::parseMappedAttribute):
- (WebCore::WMLOptGroupElement::attach):
- (WebCore::WMLOptGroupElement::detach):
- (WebCore::WMLOptGroupElement::recalcSelectOptions):
- * wml/WMLOptionElement.cpp:
- (WebCore::ownerSelectElement):
- (WebCore::WMLOptionElement::accessKeyAction):
- (WebCore::WMLOptionElement::childrenChanged):
- (WebCore::WMLOptionElement::parseMappedAttribute):
- (WebCore::WMLOptionElement::attach):
- (WebCore::WMLOptionElement::detach):
- (WebCore::WMLOptionElement::insertedIntoDocument):
- * wml/WMLSelectElement.cpp: Added.
- (WebCore::WMLSelectElement::WMLSelectElement):
- (WebCore::WMLSelectElement::~WMLSelectElement):
- (WebCore::WMLSelectElement::formControlType):
- (WebCore::WMLSelectElement::isKeyboardFocusable):
- (WebCore::WMLSelectElement::isMouseFocusable):
- (WebCore::WMLSelectElement::selectAll):
- (WebCore::WMLSelectElement::recalcStyle):
- (WebCore::WMLSelectElement::dispatchFocusEvent):
- (WebCore::WMLSelectElement::dispatchBlurEvent):
- (WebCore::WMLSelectElement::selectedIndex):
- (WebCore::WMLSelectElement::setSelectedIndex):
- (WebCore::WMLSelectElement::saveFormControlState):
- (WebCore::WMLSelectElement::restoreFormControlState):
- (WebCore::WMLSelectElement::childrenChanged):
- (WebCore::WMLSelectElement::parseMappedAttribute):
- (WebCore::WMLSelectElement::createRenderer):
- (WebCore::WMLSelectElement::appendFormData):
- (WebCore::WMLSelectElement::optionToListIndex):
- (WebCore::WMLSelectElement::listToOptionIndex):
- (WebCore::WMLSelectElement::reset):
- (WebCore::WMLSelectElement::defaultEventHandler):
- (WebCore::WMLSelectElement::accessKeyAction):
- (WebCore::WMLSelectElement::setActiveSelectionAnchorIndex):
- (WebCore::WMLSelectElement::setActiveSelectionEndIndex):
- (WebCore::WMLSelectElement::updateListBoxSelection):
- (WebCore::WMLSelectElement::listBoxOnChange):
- (WebCore::WMLSelectElement::menuListOnChange):
- (WebCore::WMLSelectElement::activeSelectionStartListIndex):
- (WebCore::WMLSelectElement::activeSelectionEndListIndex):
- (WebCore::WMLSelectElement::accessKeySetSelectedIndex):
- (WebCore::WMLSelectElement::setRecalcListItems):
- (WebCore::WMLSelectElement::scrollToSelection):
- (WebCore::WMLSelectElement::insertedIntoTree):
- * wml/WMLSelectElement.h: Added.
- (WebCore::WMLSelectElement::canSelectAll):
- (WebCore::WMLSelectElement::canStartSelection):
- (WebCore::WMLSelectElement::size):
- (WebCore::WMLSelectElement::multiple):
- (WebCore::WMLSelectElement::listItems):
- * wml/WMLTagNames.in:
-
-2009-05-29 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY (build fix for windows).
-
- http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
- that it was trying to replace. Resulting in this variable being defined twice (and
- the second time incorrectly).
-
- * platform/win/Language.cpp:
- (WebCore::localeInfo):
-
-2009-05-29 Takeshi Yoshino <tyoshino@google.com>
-
- Reviewed by Darin Alder.
-
- https://bugs.webkit.org/show_bug.cgi?id=26018
-
- Fix behavior of the Element View of the Web Inspector for double
- clicking the element outline tree.
-
- Double clicking the element outline tree should
- 1) on attribute: enter attribute editing mode
- 2) on text: enter text editing mode
- 3) otherwise: change root node to the parent element of double clicked
- element.
-
- Now, 3) is broken. For example, clicking <html> clears the element
- outline view.
-
- rootDOMNode should be updated to this.representedObject.parentNode, not
- this.parent.representedObject which is parent inside the element
- outline tree itself.
-
- * inspector/front-end/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeElement.prototype.ondblclick):
-
-2009-05-29 David Moore <davemoore@google.com>
-
- Reviewed by Darin Alder.
-
- https://bugs.webkit.org/show_bug.cgi?id=26001
- Change many of the uses of String::adopt() to String::createUninitialized().
- This allows those strings to use an inlined buffer for their characters.
-
- * dom/StyleElement.cpp:
- Loop over nodes to precompute length of string and then
- write the characters into the allocated inline buffer
- (WebCore::StyleElement::process):
- * dom/Text.cpp:
- Loop over nodes to precompute length of string and then
- write the characters into the allocated inline buffer
- (WebCore::Text::wholeText):
- (WebCore::Text::rendererIsNeeded):
- (WebCore::Text::createRenderer):
- (WebCore::Text::createWithLengthLimit):
- (WebCore::Text::formatForDebugger):
- * platform/text/String.cpp:
- (WebCore::String::append):
- (WebCore::String::insert):
- (WebCore::String::truncate):
- (WebCore::String::remove):
- * platform/text/StringBuilder.cpp:
- (WebCore::StringBuilder::toString):
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::lower):
- (WebCore::StringImpl::upper):
- (WebCore::StringImpl::secure):
- (WebCore::StringImpl::foldCase):
- (WebCore::StringImpl::replace):
- * platform/text/TextCodecLatin1.cpp:
- (WebCore::TextCodecLatin1::decode):
- * platform/text/TextCodecUserDefined.cpp:
- (WebCore::TextCodecUserDefined::decode):
- * platform/win/Language.cpp:
- (WebCore::localeInfo):
-
-2009-05-29 Takeshi Yoshino <tyoshino@google.com>
-
- Reviewed by Darin Alder.
-
- Bug 25911: Apply href in base elements to anchors shown on the source viewer
- https://bugs.webkit.org/show_bug.cgi?id=25911
-
- In rendering HTML sources, parse base elements to apply the base URI to
- anchors shown on the source viewer.
-
- This issue was originally reported to the Chromium issue tracker.
- http://code.google.com/p/chromium/issues/detail?id=2418
-
- Test: fast/frames/viewsource-link-on-href-value.html
-
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::addViewSourceToken):
-
-2009-05-29 Rob Buis <rwlbuis@gmail.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22429
- document.styleSheets collection ignores media=presentation
-
- Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.
-
- Test: fast/css/sheet-collection-link.html
-
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::process):
-
-2009-05-29 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=26069
- Fix a crash in custom V8 bindings code for XMLHttpRequest.
-
- Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
-
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-29 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
- https://bugs.webkit.org/show_bug.cgi?id=26074
-
- The constructor for SQLStatement already does a copy for this string.
-
- * storage/SQLTransaction.cpp:
- (WebCore::SQLTransaction::executeSQL):
-
-2009-05-29 Darin Adler <darin@apple.com>
-
- Fix build; the new Cairo code compiled on Windows only.
-
- * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
- and syntheticOblique functions as in the Windows version to make it
- easier to use this cross-platform. Later we can make data members
- private as in the Windows version.
- * platform/graphics/mac/FontPlatformData.h: Ditto.
-
-2009-05-29 Alexander Macdonald <alexmac@adobe.com>
-
- Reviewed by Darin Adler.
-
- Added support for synthetic bold/oblique font rendering
- on platforms that use cairo.
-
- * platform/graphics/SimpleFontData.h:
- * platform/graphics/cairo/FontCairo.cpp:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformInit):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformInit):
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- (WebCore::SimpleFontData::platformInit):
-
-2009-05-29 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
- https://bugs.webkit.org/show_bug.cgi?id=26024
-
- AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
- Consolidated postNotification and postNotificationToElement into one method.
-
- * accessibility/AXObjectCache.cpp:
- (WebCore::AXObjectCache::AXObjectCache):
- (WebCore::AXObjectCache::notificationPostTimerFired):
- (WebCore::AXObjectCache::postNotification):
- (WebCore::AXObjectCache::selectedChildrenChanged):
- * accessibility/AXObjectCache.h:
- (WebCore::AXObjectCache::postNotification):
- (WebCore::AXObjectCache::postPlatformNotification):
- * accessibility/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- * accessibility/chromium/AXObjectCacheChromium.cpp:
- (WebCore::AXObjectCache::postPlatformNotification):
- * accessibility/gtk/AXObjectCacheAtk.cpp:
- (WebCore::AXObjectCache::postPlatformNotification):
- * accessibility/mac/AXObjectCacheMac.mm:
- (WebCore::AXObjectCache::postPlatformNotification):
- * accessibility/win/AXObjectCacheWin.cpp:
- (WebCore::AXObjectCache::postPlatformNotification):
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
- * editing/Editor.cpp:
- (WebCore::Editor::respondToChangedContents):
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- * page/FrameView.cpp:
- (WebCore::FrameView::layout):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setInnerTextValue):
-
-2009-05-29 Brent Fulgham <bfulgham@webkit.org>
-
- Reviewed by Adam Roben.
-
- Build fix for Windows Cairo target.
- https://bugs.webkit.org/show_bug.cgi?id=25972
-
- Compiler mistakenly selects SMILTime min/max instead of STL version,
- resulting in a build error. This change makes the meaning of the
- min/max explicit and avoids the problem.
-
- * html/TimeRanges.h:
- (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
-
-2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Jan Alonzo.
-
- Make SoupMessage a member of ResourceRequest, instead of creating
- it in startHttp. Implement updating of ResourceRequest from
- SoupMessage, and vice versa.
-
- * GNUmakefile.am:
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::~ResourceHandle):
- (WebCore::gotHeadersCallback):
- (WebCore::ResourceHandle::startHttp):
- * platform/network/soup/ResourceRequest.h:
- (WebCore::ResourceRequest::ResourceRequest):
- (WebCore::ResourceRequest::~ResourceRequest):
- * platform/network/soup/ResourceRequestSoup.cpp: Added.
- (WTF::SoupURI):
- (WebCore::ResourceRequest::soupMessage):
- (WebCore::ResourceRequest::ResourceRequest):
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
-
-2009-05-28 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=26068
- V8: Remove the remaining b8::Locker usage in worker code.
- This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
- since the patches for enabling timers and that bug have "crossed in the queue".
- Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
-
- * bindings/v8/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
-
-2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Xan Lopez.
-
- Simplify the Accept-Encoding header we are sending out, for it
- seems some servers do not enjoy parsing the full, explicit
- version.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startHttp):
-
-2009-05-28 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Added a new build flag --filters. This replaces the old --svg-filters and enables
- other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
- This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
- doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
- Filters are not working yet. This patch is just a preperation. Filters are deactivated by
- default.
-
- * Configurations/FeatureDefines.xcconfig:
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * bindings/objc/DOM.mm:
- (WebCore::createElementClassMap):
- * dom/DOMImplementation.cpp:
- (WebCore::isSVG10Feature):
- (WebCore::isSVG11Feature):
- * page/DOMWindow.idl:
- * platform/graphics/filters/FEBlend.cpp:
- * platform/graphics/filters/FEBlend.h:
- * platform/graphics/filters/FEColorMatrix.cpp:
- * platform/graphics/filters/FEColorMatrix.h:
- * platform/graphics/filters/FEComponentTransfer.cpp:
- * platform/graphics/filters/FEComponentTransfer.h:
- * platform/graphics/filters/FEComposite.cpp:
- * platform/graphics/filters/FEComposite.h:
- * platform/graphics/filters/FilterEffect.cpp:
- * platform/graphics/filters/FilterEffect.h:
- * platform/graphics/filters/SourceAlpha.cpp:
- * platform/graphics/filters/SourceAlpha.h:
- * platform/graphics/filters/SourceGraphic.cpp:
- * platform/graphics/filters/SourceGraphic.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::selfWillPaint):
- * rendering/RenderSVGModelObject.cpp:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::selfWillPaint):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- (WebCore::SVGRenderBase::finishRenderSVGContent):
- (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- * svg/Filter.cpp:
- * svg/Filter.h:
- * svg/FilterBuilder.cpp:
- * svg/FilterBuilder.h:
- * svg/SVGComponentTransferFunctionElement.cpp:
- * svg/SVGComponentTransferFunctionElement.h:
- * svg/SVGComponentTransferFunctionElement.idl:
- * svg/SVGFEBlendElement.cpp:
- * svg/SVGFEBlendElement.h:
- * svg/SVGFEBlendElement.idl:
- * svg/SVGFEColorMatrixElement.cpp:
- * svg/SVGFEColorMatrixElement.h:
- * svg/SVGFEColorMatrixElement.idl:
- * svg/SVGFEComponentTransferElement.cpp:
- * svg/SVGFEComponentTransferElement.h:
- * svg/SVGFEComponentTransferElement.idl:
- * svg/SVGFECompositeElement.cpp:
- * svg/SVGFECompositeElement.h:
- * svg/SVGFECompositeElement.idl:
- * svg/SVGFEDiffuseLightingElement.cpp:
- * svg/SVGFEDiffuseLightingElement.h:
- * svg/SVGFEDiffuseLightingElement.idl:
- * svg/SVGFEDisplacementMapElement.cpp:
- * svg/SVGFEDisplacementMapElement.h:
- * svg/SVGFEDisplacementMapElement.idl:
- * svg/SVGFEDistantLightElement.cpp:
- * svg/SVGFEDistantLightElement.h:
- * svg/SVGFEDistantLightElement.idl:
- * svg/SVGFEFloodElement.cpp:
- * svg/SVGFEFloodElement.h:
- * svg/SVGFEFloodElement.idl:
- * svg/SVGFEFuncAElement.cpp:
- * svg/SVGFEFuncAElement.h:
- * svg/SVGFEFuncAElement.idl:
- * svg/SVGFEFuncBElement.cpp:
- * svg/SVGFEFuncBElement.h:
- * svg/SVGFEFuncBElement.idl:
- * svg/SVGFEFuncGElement.cpp:
- * svg/SVGFEFuncGElement.h:
- * svg/SVGFEFuncGElement.idl:
- * svg/SVGFEFuncRElement.cpp:
- * svg/SVGFEFuncRElement.h:
- * svg/SVGFEFuncRElement.idl:
- * svg/SVGFEGaussianBlurElement.cpp:
- * svg/SVGFEGaussianBlurElement.h:
- * svg/SVGFEGaussianBlurElement.idl:
- * svg/SVGFEImageElement.cpp:
- * svg/SVGFEImageElement.h:
- * svg/SVGFEImageElement.idl:
- * svg/SVGFELightElement.cpp:
- * svg/SVGFELightElement.h:
- * svg/SVGFEMergeElement.cpp:
- * svg/SVGFEMergeElement.h:
- * svg/SVGFEMergeElement.idl:
- * svg/SVGFEMergeNodeElement.cpp:
- * svg/SVGFEMergeNodeElement.h:
- * svg/SVGFEMergeNodeElement.idl:
- * svg/SVGFEOffsetElement.cpp:
- * svg/SVGFEOffsetElement.h:
- * svg/SVGFEOffsetElement.idl:
- * svg/SVGFEPointLightElement.cpp:
- * svg/SVGFEPointLightElement.h:
- * svg/SVGFEPointLightElement.idl:
- * svg/SVGFESpecularLightingElement.cpp:
- * svg/SVGFESpecularLightingElement.h:
- * svg/SVGFESpecularLightingElement.idl:
- * svg/SVGFESpotLightElement.cpp:
- * svg/SVGFESpotLightElement.h:
- * svg/SVGFESpotLightElement.idl:
- * svg/SVGFETileElement.cpp:
- * svg/SVGFETileElement.h:
- * svg/SVGFETileElement.idl:
- * svg/SVGFETurbulenceElement.cpp:
- * svg/SVGFETurbulenceElement.h:
- * svg/SVGFETurbulenceElement.idl:
- * svg/SVGFilterElement.cpp:
- * svg/SVGFilterElement.h:
- * svg/SVGFilterElement.idl:
- * svg/SVGFilterPrimitiveStandardAttributes.cpp:
- * svg/SVGFilterPrimitiveStandardAttributes.h:
- * svg/graphics/SVGResourceFilter.cpp:
- * svg/graphics/SVGResourceFilter.h:
- * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
- * svg/graphics/cg/SVGResourceFilterCg.cpp:
- * svg/graphics/cg/SVGResourceFilterCg.mm:
- * svg/graphics/filters/SVGDistantLightSource.h:
- * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
- * svg/graphics/filters/SVGFEConvolveMatrix.h:
- * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- * svg/graphics/filters/SVGFEDiffuseLighting.h:
- * svg/graphics/filters/SVGFEDisplacementMap.cpp:
- * svg/graphics/filters/SVGFEDisplacementMap.h:
- * svg/graphics/filters/SVGFEFlood.cpp:
- * svg/graphics/filters/SVGFEFlood.h:
- * svg/graphics/filters/SVGFEGaussianBlur.cpp:
- * svg/graphics/filters/SVGFEGaussianBlur.h:
- * svg/graphics/filters/SVGFEImage.cpp:
- * svg/graphics/filters/SVGFEImage.h:
- * svg/graphics/filters/SVGFEMerge.cpp:
- * svg/graphics/filters/SVGFEMerge.h:
- * svg/graphics/filters/SVGFEMorphology.cpp:
- * svg/graphics/filters/SVGFEMorphology.h:
- * svg/graphics/filters/SVGFEOffset.cpp:
- * svg/graphics/filters/SVGFEOffset.h:
- * svg/graphics/filters/SVGFESpecularLighting.cpp:
- * svg/graphics/filters/SVGFESpecularLighting.h:
- * svg/graphics/filters/SVGFETile.cpp:
- * svg/graphics/filters/SVGFETile.h:
- * svg/graphics/filters/SVGFETurbulence.cpp:
- * svg/graphics/filters/SVGFETurbulence.h:
- * svg/graphics/filters/SVGFilterEffect.cpp:
- * svg/graphics/filters/SVGFilterEffect.h:
- * svg/graphics/filters/SVGLightSource.cpp:
- * svg/graphics/filters/SVGLightSource.h:
- * svg/graphics/filters/SVGPointLightSource.h:
- * svg/graphics/filters/SVGSpotLightSource.h:
- * svg/graphics/filters/cg/SVGFEHelpersCg.h:
- * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
- * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
- * svg/graphics/filters/cg/WKArithmeticFilter.h:
- * svg/graphics/filters/cg/WKArithmeticFilter.m:
- * svg/graphics/filters/cg/WKComponentMergeFilter.h:
- * svg/graphics/filters/cg/WKComponentMergeFilter.m:
- * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
- * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
- * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
- * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
- * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
- * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
- * svg/graphics/filters/cg/WKDistantLightFilter.h:
- * svg/graphics/filters/cg/WKDistantLightFilter.m:
- * svg/graphics/filters/cg/WKGammaTransferFilter.h:
- * svg/graphics/filters/cg/WKGammaTransferFilter.m:
- * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
- * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
- * svg/graphics/filters/cg/WKLinearTransferFilter.h:
- * svg/graphics/filters/cg/WKLinearTransferFilter.m:
- * svg/graphics/filters/cg/WKNormalMapFilter.h:
- * svg/graphics/filters/cg/WKNormalMapFilter.m:
- * svg/graphics/filters/cg/WKPointLightFilter.h:
- * svg/graphics/filters/cg/WKPointLightFilter.m:
- * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
- * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
- * svg/graphics/filters/cg/WKSpotLightFilter.h:
- * svg/graphics/filters/cg/WKSpotLightFilter.m:
- * svg/graphics/filters/cg/WKTableTransferFilter.h:
- * svg/graphics/filters/cg/WKTableTransferFilter.m:
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
- * svg/graphics/qt/SVGResourceFilterQt.cpp:
- * svg/graphics/skia/SVGResourceFilterSkia.cpp:
- * svg/svgtags.in:
-
-2009-05-28 Brett Wilson <brettw@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=26067
-
- Add casts for scale function to make more explicit what is happening
- and fix a compiler warning.
-
- * platform/graphics/IntSize.h:
- (WebCore::IntSize::scale):
-
-2009-05-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
- are not cleared on navigation it is no longer necessary.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
- (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::showModalDialog):
-
-2009-05-19 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Jan Alonzo and Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25415
- [GTK][ATK] Please implement support for get_text_at_offset
-
- Implement atk_text_get_text_{at,after,before}_offset.
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by Darin Adler.
-
- Remove unnecessary destructor from InputElementData/OptionElementData.
-
- * dom/InputElement.cpp:
- * dom/InputElement.h:
- * dom/OptionElement.cpp:
- * dom/OptionElement.h:
-
-2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
-
- Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
- in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
-
- A follow-up patch can now easily add WMLSelectElement.
-
- * dom/OptionElement.h:
- * dom/SelectElement.cpp:
- (WebCore::SelectElement::selectAll):
- (WebCore::SelectElement::saveLastSelection):
- (WebCore::isOptionElement):
- (WebCore::isOptionGroupElement):
- (WebCore::SelectElement::nextSelectableListIndex):
- (WebCore::SelectElement::previousSelectableListIndex):
- (WebCore::SelectElement::setActiveSelectionAnchorIndex):
- (WebCore::SelectElement::setActiveSelectionEndIndex):
- (WebCore::SelectElement::updateListBoxSelection):
- (WebCore::SelectElement::listBoxOnChange):
- (WebCore::SelectElement::menuListOnChange):
- (WebCore::SelectElement::scrollToSelection):
- (WebCore::SelectElement::recalcStyle):
- (WebCore::SelectElement::setRecalcListItems):
- (WebCore::SelectElement::recalcListItems):
- (WebCore::SelectElement::selectedIndex):
- (WebCore::SelectElement::setSelectedIndex):
- (WebCore::SelectElement::optionToListIndex):
- (WebCore::SelectElement::listToOptionIndex):
- (WebCore::SelectElement::dispatchFocusEvent):
- (WebCore::SelectElement::dispatchBlurEvent):
- (WebCore::SelectElement::deselectItems):
- (WebCore::SelectElement::saveFormControlState):
- (WebCore::SelectElement::restoreFormControlState):
- (WebCore::SelectElement::parseMultipleAttribute):
- (WebCore::SelectElement::appendFormData):
- (WebCore::SelectElement::reset):
- (WebCore::SelectElement::menuListDefaultEventHandler):
- (WebCore::SelectElement::listBoxDefaultEventHandler):
- (WebCore::SelectElement::defaultEventHandler):
- (WebCore::SelectElement::lastSelectedListIndex):
- (WebCore::stripLeadingWhiteSpace):
- (WebCore::SelectElement::typeAheadFind):
- (WebCore::SelectElement::insertedIntoTree):
- (WebCore::SelectElementData::SelectElementData):
- (WebCore::SelectElementData::checkListItems):
- (WebCore::SelectElementData::listItems):
- * dom/SelectElement.h:
- (WebCore::SelectElementData::multiple):
- (WebCore::SelectElementData::setMultiple):
- (WebCore::SelectElementData::size):
- (WebCore::SelectElementData::setSize):
- (WebCore::SelectElementData::usesMenuList):
- (WebCore::SelectElementData::lastOnChangeIndex):
- (WebCore::SelectElementData::setLastOnChangeIndex):
- (WebCore::SelectElementData::lastOnChangeSelection):
- (WebCore::SelectElementData::activeSelectionState):
- (WebCore::SelectElementData::setActiveSelectionState):
- (WebCore::SelectElementData::activeSelectionAnchorIndex):
- (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
- (WebCore::SelectElementData::activeSelectionEndIndex):
- (WebCore::SelectElementData::setActiveSelectionEndIndex):
- (WebCore::SelectElementData::cachedStateForActiveSelection):
- (WebCore::SelectElementData::shouldRecalcListItems):
- (WebCore::SelectElementData::setShouldRecalcListItems):
- (WebCore::SelectElementData::rawListItems):
- (WebCore::SelectElementData::repeatingChar):
- (WebCore::SelectElementData::setRepeatingChar):
- (WebCore::SelectElementData::lastCharTime):
- (WebCore::SelectElementData::setLastCharTime):
- (WebCore::SelectElementData::typedString):
- (WebCore::SelectElementData::setTypedString):
- * html/HTMLOptionElement.h:
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::HTMLSelectElement):
- (WebCore::HTMLSelectElement::recalcStyle):
- (WebCore::HTMLSelectElement::formControlType):
- (WebCore::HTMLSelectElement::selectedIndex):
- (WebCore::HTMLSelectElement::deselectItems):
- (WebCore::HTMLSelectElement::setSelectedIndex):
- (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
- (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
- (WebCore::HTMLSelectElement::saveFormControlState):
- (WebCore::HTMLSelectElement::restoreFormControlState):
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- (WebCore::HTMLSelectElement::canSelectAll):
- (WebCore::HTMLSelectElement::selectAll):
- (WebCore::HTMLSelectElement::createRenderer):
- (WebCore::HTMLSelectElement::appendFormData):
- (WebCore::HTMLSelectElement::optionToListIndex):
- (WebCore::HTMLSelectElement::listToOptionIndex):
- (WebCore::HTMLSelectElement::recalcListItems):
- (WebCore::HTMLSelectElement::setRecalcListItems):
- (WebCore::HTMLSelectElement::reset):
- (WebCore::HTMLSelectElement::dispatchFocusEvent):
- (WebCore::HTMLSelectElement::dispatchBlurEvent):
- (WebCore::HTMLSelectElement::defaultEventHandler):
- (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
- (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
- (WebCore::HTMLSelectElement::updateListBoxSelection):
- (WebCore::HTMLSelectElement::menuListOnChange):
- (WebCore::HTMLSelectElement::listBoxOnChange):
- (WebCore::HTMLSelectElement::saveLastSelection):
- (WebCore::HTMLSelectElement::setOption):
- (WebCore::HTMLSelectElement::scrollToSelection):
- (WebCore::HTMLSelectElement::insertedIntoTree):
- * html/HTMLSelectElement.h:
- (WebCore::HTMLSelectElement::size):
- (WebCore::HTMLSelectElement::multiple):
- (WebCore::HTMLSelectElement::listItems):
- * wml/WMLOptionElement.cpp:
- (WebCore::WMLOptionElement::text):
- * wml/WMLOptionElement.h:
-
-
- * dom/OptionElement.h:
- * dom/SelectElement.cpp:
- (WebCore::SelectElement::selectAll):
- (WebCore::SelectElement::saveLastSelection):
- (WebCore::isOptionElement):
- (WebCore::isOptionGroupElement):
- (WebCore::SelectElement::nextSelectableListIndex):
- (WebCore::SelectElement::previousSelectableListIndex):
- (WebCore::SelectElement::setActiveSelectionAnchorIndex):
- (WebCore::SelectElement::setActiveSelectionEndIndex):
- (WebCore::SelectElement::updateListBoxSelection):
- (WebCore::SelectElement::listBoxOnChange):
- (WebCore::SelectElement::menuListOnChange):
- (WebCore::SelectElement::scrollToSelection):
- (WebCore::SelectElement::recalcStyle):
- (WebCore::SelectElement::setRecalcListItems):
- (WebCore::SelectElement::recalcListItems):
- (WebCore::SelectElement::selectedIndex):
- (WebCore::SelectElement::setSelectedIndex):
- (WebCore::SelectElement::optionToListIndex):
- (WebCore::SelectElement::listToOptionIndex):
- (WebCore::SelectElement::dispatchFocusEvent):
- (WebCore::SelectElement::dispatchBlurEvent):
- (WebCore::SelectElement::deselectItems):
- (WebCore::SelectElement::saveFormControlState):
- (WebCore::SelectElement::restoreFormControlState):
- (WebCore::SelectElement::parseMultipleAttribute):
- (WebCore::SelectElement::appendFormData):
- (WebCore::SelectElement::reset):
- (WebCore::SelectElement::menuListDefaultEventHandler):
- (WebCore::SelectElement::listBoxDefaultEventHandler):
- (WebCore::SelectElement::defaultEventHandler):
- (WebCore::SelectElement::lastSelectedListIndex):
- (WebCore::stripLeadingWhiteSpace):
- (WebCore::SelectElement::typeAheadFind):
- (WebCore::SelectElement::insertedIntoTree):
- (WebCore::SelectElementData::SelectElementData):
- (WebCore::SelectElementData::~SelectElementData):
- (WebCore::SelectElementData::checkListItems):
- (WebCore::SelectElementData::listItems):
- * dom/SelectElement.h:
- (WebCore::SelectElementData::multiple):
- (WebCore::SelectElementData::setMultiple):
- (WebCore::SelectElementData::size):
- (WebCore::SelectElementData::setSize):
- (WebCore::SelectElementData::usesMenuList):
- (WebCore::SelectElementData::lastOnChangeIndex):
- (WebCore::SelectElementData::setLastOnChangeIndex):
- (WebCore::SelectElementData::lastOnChangeSelection):
- (WebCore::SelectElementData::activeSelectionState):
- (WebCore::SelectElementData::setActiveSelectionState):
- (WebCore::SelectElementData::activeSelectionAnchorIndex):
- (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
- (WebCore::SelectElementData::activeSelectionEndIndex):
- (WebCore::SelectElementData::setActiveSelectionEndIndex):
- (WebCore::SelectElementData::cachedStateForActiveSelection):
- (WebCore::SelectElementData::shouldRecalcListItems):
- (WebCore::SelectElementData::setShouldRecalcListItems):
- (WebCore::SelectElementData::rawListItems):
- (WebCore::SelectElementData::repeatingChar):
- (WebCore::SelectElementData::setRepeatingChar):
- (WebCore::SelectElementData::lastCharTime):
- (WebCore::SelectElementData::setLastCharTime):
- (WebCore::SelectElementData::typedString):
- (WebCore::SelectElementData::setTypedString):
- * html/HTMLOptionElement.h:
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::HTMLSelectElement):
- (WebCore::HTMLSelectElement::recalcStyle):
- (WebCore::HTMLSelectElement::formControlType):
- (WebCore::HTMLSelectElement::selectedIndex):
- (WebCore::HTMLSelectElement::deselectItems):
- (WebCore::HTMLSelectElement::setSelectedIndex):
- (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
- (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
- (WebCore::HTMLSelectElement::saveFormControlState):
- (WebCore::HTMLSelectElement::restoreFormControlState):
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- (WebCore::HTMLSelectElement::canSelectAll):
- (WebCore::HTMLSelectElement::selectAll):
- (WebCore::HTMLSelectElement::createRenderer):
- (WebCore::HTMLSelectElement::appendFormData):
- (WebCore::HTMLSelectElement::optionToListIndex):
- (WebCore::HTMLSelectElement::listToOptionIndex):
- (WebCore::HTMLSelectElement::recalcListItems):
- (WebCore::HTMLSelectElement::setRecalcListItems):
- (WebCore::HTMLSelectElement::reset):
- (WebCore::HTMLSelectElement::dispatchFocusEvent):
- (WebCore::HTMLSelectElement::dispatchBlurEvent):
- (WebCore::HTMLSelectElement::defaultEventHandler):
- (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
- (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
- (WebCore::HTMLSelectElement::updateListBoxSelection):
- (WebCore::HTMLSelectElement::menuListOnChange):
- (WebCore::HTMLSelectElement::listBoxOnChange):
- (WebCore::HTMLSelectElement::saveLastSelection):
- (WebCore::HTMLSelectElement::setOption):
- (WebCore::HTMLSelectElement::scrollToSelection):
- (WebCore::HTMLSelectElement::insertedIntoTree):
- * html/HTMLSelectElement.h:
- (WebCore::HTMLSelectElement::size):
- (WebCore::HTMLSelectElement::multiple):
- (WebCore::HTMLSelectElement::listItems):
- * wml/WMLOptionElement.cpp:
- (WebCore::WMLOptionElement::text):
- * wml/WMLOptionElement.h:
-
-2009-05-28 Adam Roben <aroben@apple.com>
-
- Don't try to use the new combobox parts on Vista in Classic mode
-
- Fixes:
- <rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
- theme: drop down lists in Preferences get a line/square
- <rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
- down lists are black with a circle on many sites
-
- Reviewed by Steve Falkenburg.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
- parts when we have a theme (i.e., when we're not in Classic mode).
- When we don't have a theme, fall back to the pre-r42289 code.
-
-2009-05-27 Peter Kasting <pkasting@google.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25659
- Avoid calling frameCount() unnecessarily (which could lead to extra
- GIF decoding).
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
-
-2009-05-28 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=8736
-
- Tests: fast/borders/border-radius-constraints.html
- fast/borders/border-radius-split-inline.html
-
- When the sum of the corner radii on a side exceed the length of the side,
- reduce the radii according to CSS 3 rules.
-
- Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
- the constraints. Use that for painting borders, box-shadow, clipping replaced
- elements
-
- * platform/graphics/IntSize.h:
- (WebCore::IntSize::scale):
- Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
-
- * platform/graphics/Path.cpp:
- Make the QUARTER const static.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::pushContentsClip):
- Use getBorderRadiiForRect to fetch border radii.
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- Use getBorderRadiiForRect to fetch border radii.
-
- (WebCore::RenderBoxModelObject::paintBorder):
- Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
- borders for split inlines, which used to apply the radii for each segment,
- and no longer does.
-
- (WebCore::RenderBoxModelObject::paintBoxShadow):
- Use getBorderRadiiForRect to fetch border radii.
-
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::paint):
- Use getBorderRadiiForRect to fetch border radii for clipping.
-
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint):
- Use getBorderRadiiForRect to fetch border radii for clipping.
-
- * rendering/style/RenderStyle.h:
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::getBorderRadiiForRect):
- New bottleneck method to fetch corner radiil given a rect, applying the constraint
- rules.
-
-2009-05-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=26005
- Optimization for XPath //* does not preserve context size
-
- Test: fast/xpath/position.html
-
- Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
- get a performance progression on my tests.
-
- * xml/XPathPath.h: Removed broken optimizeStepPair().
-
- * xml/XPathPath.cpp:
- (WebCore::XPath::LocationPath::evaluate): Style fix.
- (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
- (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
- (WebCore::XPath::Path::Path): Style fix.
-
- * xml/XPathStep.cpp:
- (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
- (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
- (and might never be).
- (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
-
- * xml/XPathStep.h:
- (WebCore::XPath::Step::NodeTest::data):
- (WebCore::XPath::Step::NodeTest::namespaceURI):
- Made these data members AtomicString to avoid repeated conversions. This is the biggest
- performance win here.
-
- * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
-
-2009-05-28 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- When creating a linear or radial gradient with a single stop
- at offset 1.0, the Skia layer was allocating 3 stops, but only
- filling 2, leaving one uninitialized. Only 2 stops are necessary
- in this case, at offsets (0.0, 1.0).
-
- http://bugs.webkit.org/show_bug.cgi?id=26063
-
- Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
- LayoutTests/svg/custom/gradient-stop-corner-cases.svg
- LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
-
- * platform/graphics/skia/GradientSkia.cpp:
- (WebCore::totalStopsNeeded):
-
-2009-05-28 Yury Semikhatsky <yurys@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=26041
- Allow adding resource source to WebInspector.SourceFrame asynchronously.
-
- Provide common implementation for InspectorController::addResourceSourceToFrame and
- InspectorController::addSourceToFrame methods.
-
- * bindings/js/JSInspectorControllerCustom.cpp:
- * bindings/v8/custom/V8InspectorControllerCustom.cpp:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::addResourceSourceToFrame):
- * inspector/InspectorController.h:
- * inspector/InspectorController.idl:
- * inspector/front-end/SourceFrame.js:
- (WebInspector.SourceFrame.prototype.revealLine):
- (WebInspector.SourceFrame.prototype.highlightLine):
- (WebInspector.SourceFrame.prototype._loaded):
- (WebInspector.SourceFrame.prototype._isContentLoaded):
- * inspector/front-end/SourceView.js:
- (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
- (WebInspector.SourceView.prototype._contentLoaded):
-
-2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- After r44177 we had a problem when increasing the size
- of the window the scrollbars stayed and were not hidden.
- This was due WebCore giving up on the Scrollbar as it became
- unnecessary but the GtkAdjustment remained unchanged.
- So from the point of view of the GtkScrolledWindow scrolling
- was still necessary and the GtkScrollbar kept being displayed.
-
- Solve the issue by resetting the GtkAdjustment in the
- destructor of ScrollbarGtk.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::~ScrollbarGtk):
-
-2009-05-28 Adam Barth <abarth@webkit.org>
-
- Reviewed by Darin Adler.
-
- Clean up window.open()'s use of lexical and dynamic scope.
-
- (Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
- for DOMWindow::allowPopUp.)
-
- Test: http/tests/security/frameNavigation/context-for-window-open.html
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::toDynamicFrame):
- (WebCore::processingUserGesture):
- (WebCore::completeURL):
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::createWindow):
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
- (WebCore::createWindow):
-
-2009-05-27 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=26056
- XPath string() function can be very slow
-
- * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
-
-2009-05-27 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
- and initially not visible
-
- Test: fast/forms/isindex-placeholder.html
-
- * css/html4.css: Added a default style for <isindex> placeholder text.
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
- the new protected function updatePlaceholderVisibility().
- * html/HTMLInputElement.h:
- (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
- protected function to allow HTMLIsIndexElement::parseMappedAttribute()
- to invoke InputElement::updatePlaceholderVisibility().
- * html/HTMLIsIndexElement.cpp:
- (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
- updatePlaceholderVisibility() when parsing the placeholder attribute.
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
- is no placeholder pseudo-element style, use the normal style.
-
-2009-05-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- More cleanup of DOMWindow related functions.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
- * bindings/js/JSDOMWindowBase.h:
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::showModalDialog): Update Comment.
-
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSDOMWindowShell.h:
- Remove JSDOMWindowShell::clear(). It was unused.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::clearWindowShell):
-
-2009-05-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Miscellaneous cleanup of DOMWindow related functions.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
- checking for null frames if the build does not support profiling.
- (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
- clearHelperObjectProperties(). It is clearer.
- * bindings/js/JSDOMWindowBase.h:
- Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
- function, and the empty destructor.
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSDOMWindowShell.h:
- Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
- is a no-op.
- * page/Frame.cpp:
- (WebCore::Frame::~Frame):
- (WebCore::Frame::pageDestroyed):
- Remove calls to JSDOMWindowShell::disconnectFrame() which only called
- JSDOMWindowBase::disconnectFrame(), which is a no-op.
-
-2009-05-27 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25974
- Remove extra qualifiers from the ScheduledAction decl.
-
- * bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
-
-2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed make distcheck fix. One more missing file.
-
- * GNUmakefile.am:
-
-2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Fixed trunk build on Linux after r44126.
-
- * WebCore.pro:
-
-2009-05-27 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
-
-2009-05-27 David Levin <levin@chromium.org>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
- https://bugs.webkit.org/show_bug.cgi?id=26029
-
- No functional changes, so no tests.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::canLoad):
- * loader/FrameLoader.h:
-
-2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed build fix.
-
- Remove file that does not exist from the build.
-
- * GNUmakefile.am:
-
-2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
-
- * dom/InputElement.h:
- * dom/OptionGroupElement.h:
-
-2009-05-27 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=17725
- XPath should be case insensitive for HTML
-
- Test: fast/xpath/node-name-case-sensitivity.html
-
- * xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
- for HTML elements in HTML documents.
-
-2009-05-27 John Sullivan <sullivan@apple.com>
-
- fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
- bookmarks (at least) over Top Sites (at least)
-
- Reviewed by Kevin Decker
-
- * page/DragController.cpp:
- (WebCore::DragController::dragExited):
- nil check m_documentUnderMouse and take the "local file" case if it's nil
-
-2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Gustavo Noronha.
-
- When building on window, consider Windows specific files.
-
- * GNUmakefile.am:
-
-2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
-
- InputElementData is too heavy, save storing two pointers by passing them
- directly to the static helper functions (the only place which needs them).
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::dispatchFocusEvent):
- (WebCore::InputElement::dispatchBlurEvent):
- (WebCore::InputElement::updatePlaceholderVisibility):
- (WebCore::InputElement::updateFocusAppearance):
- (WebCore::InputElement::updateSelectionRange):
- (WebCore::InputElement::aboutToUnload):
- (WebCore::InputElement::setValueFromRenderer):
- (WebCore::InputElement::constrainValue):
- (WebCore::InputElement::handleBeforeTextInsertedEvent):
- (WebCore::InputElement::parseSizeAttribute):
- (WebCore::InputElement::parseMaxLengthAttribute):
- (WebCore::InputElement::updateValueIfNeeded):
- (WebCore::InputElement::notifyFormStateChanged):
- (WebCore::InputElementData::InputElementData):
- * dom/InputElement.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::HTMLInputElement):
- (WebCore::HTMLInputElement::updateFocusAppearance):
- (WebCore::HTMLInputElement::aboutToUnload):
- (WebCore::HTMLInputElement::dispatchFocusEvent):
- (WebCore::HTMLInputElement::dispatchBlurEvent):
- (WebCore::HTMLInputElement::setInputType):
- (WebCore::HTMLInputElement::setSelectionRange):
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::setValue):
- (WebCore::HTMLInputElement::setValueFromRenderer):
- (WebCore::HTMLInputElement::setFileListFromRenderer):
- (WebCore::HTMLInputElement::defaultEventHandler):
- (WebCore::HTMLInputElement::constrainValue):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::WMLInputElement):
- (WebCore::WMLInputElement::dispatchFocusEvent):
- (WebCore::WMLInputElement::dispatchBlurEvent):
- (WebCore::WMLInputElement::updateFocusAppearance):
- (WebCore::WMLInputElement::aboutToUnload):
- (WebCore::WMLInputElement::setValue):
- (WebCore::WMLInputElement::setValueFromRenderer):
- (WebCore::WMLInputElement::parseMappedAttribute):
- (WebCore::WMLInputElement::defaultEventHandler):
- (WebCore::WMLInputElement::constrainValue):
-
-2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
-
- OptionElementData saves an Element pointer, which is unnessary.
- Just pass it to the static function calls directly.
-
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::setSelectedState):
- (WebCore::OptionElement::collectOptionText):
- (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
- (WebCore::OptionElement::collectOptionValue):
- (WebCore::OptionElementData::OptionElementData):
- * dom/OptionElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::HTMLOptionElement):
- (WebCore::HTMLOptionElement::text):
- (WebCore::HTMLOptionElement::value):
- (WebCore::HTMLOptionElement::setSelected):
- (WebCore::HTMLOptionElement::setSelectedState):
- (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
- * wml/WMLOptionElement.cpp:
- (WebCore::WMLOptionElement::WMLOptionElement):
- (WebCore::WMLOptionElement::setSelectedState):
- (WebCore::WMLOptionElement::value):
- (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
-
-2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Maciej Stachowiak.
-
- When building with MinGW, don't use the __declspec(dl{import,export})
- decorations and rely on the linker to use its nifty auto-import feature.
- It is extremely hard to get the decorations right with MinGW in general
- and impossible in WebKit, where the resulting shared library is linking
- together some static libraries.
-
- * config.h:
-
-2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- https://bugs.webkit.org/show_bug.cgi?id=25613
-
- Add a WebCore::Widget that can embed GtkWidget with and
- without a GdkWindow. This can be used to embed any GtkWidget.
-
- Some bits are directly copied from the Scrollbar implementation
- but can not be easily shared here.
-
- * GNUmakefile.am:
- * platform/gtk/GtkPluginWidget.cpp: Added.
- (WebCore::GtkPluginWidget::GtkPluginWidget):
- (WebCore::GtkPluginWidget::invalidateRect):
- (WebCore::GtkPluginWidget::frameRectsChanged):
- (WebCore::GtkPluginWidget::paint):
- * platform/gtk/GtkPluginWidget.h: Added.
-
-2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25613.
-
- Implement Widget::setIsSelected for Gtk+ by searching
- for a property of the name "webkit-widget-is-selected" and if
- such property exists we are going to set it. We expect
- the property to take a boolean.
-
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::setIsSelected):
-
-2009-05-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Brady Eidson.
-
- Fix for <rdar://problem/6916371>
- iWeb 'Announce' button does nothing after publishing to MobileMe
-
- Add ability to force content sniffing for all urls (including file: urls)
-
- * WebCore.base.exp:
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::shouldContentSniffURL):
- (WebCore::ResourceHandle::forceContentSniffing):
- * platform/network/ResourceHandle.h:
-
-2009-05-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=25996
-
- [Qt] Dead-code stripping for unix
-
- * WebCore.pro: Turn on GCC dead-code stripping flags for Unix
-
-2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=25646
-
- [GTK] Send onscroll events for the main FrameView
-
- WebKit/GTK+ is currently not sending any onscroll
- events for a frame with external adjustments. This is
- due the fact that the value-changed signal of the GtkAdjustment
- is handled by WebCore::ScrollView directly and is not going through
- the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
- WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
- path.
-
- Fix the above problem by wrapping the GtkAdjustment we get
- assigned from GTK+ in a ScrollbarGtk that will not have any
- visual appearance. Remove code from ScrollView that knows
- about adjustments and create a special case for
- WebCore::ScrollView::createScrollbar that will create such
- a special WebCore::ScrollbarGtk.
-
- * platform/ScrollView.cpp: Remove adjustment code
- (WebCore::ScrollView::setHasHorizontalScrollbar):
- (WebCore::ScrollView::setHasVerticalScrollbar):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::wheelEvent):
- * platform/ScrollView.h: Remove adjustment code
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformDestroy):
- (WebCore::ScrollView::createScrollbar):
- (WebCore::ScrollView::setGtkAdjustments):
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::createScrollbar): Special case.
- (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment
- (ScrollbarGtk::~ScrollbarGtk): Disconnect signal
- (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
- * platform/gtk/ScrollbarGtk.h:
-
-2009-05-26 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
- <https://bugs.webkit.org/show_bug.cgi?id=26035>
- <rdar://problem/6924087>
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
- is JPEG, there is no image type, or m_decoder is null.
-
-2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix for the JPEGImageDecoder.
-
- Revision 44167 removed stdio.h from the included headers and
- this will lead to an error that FILE is not known inside the
- jpeglib.h Put back the stdio.h include.
-
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
-
-2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by Maciej Stachowiak.
-
- Fix the crash issue while running layout tests after enalbed XHTMLMP
- https://bugs.webkit.org/show_bug.cgi?id=26017
-
- * dom/Document.cpp:
- (WebCore::Document::isXHTMLMPDocument):
-
-2009-05-26 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6901751>
- REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
-
- Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
- the improved selection drawing on Tiger.
-
- * WebCore.Tiger.exp:
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::clip):
- (WebCore::GraphicsContext::clipOut):
- (WebCore::GraphicsContext::clipOutEllipseInRect):
- (WebCore::GraphicsContext::clipPath):
- (WebCore::GraphicsContext::addInnerRoundedRectClip):
- (WebCore::GraphicsContext::strokeRect):
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::fillSelectionGaps):
-
-2009-05-26 Peter Kasting <pkasting@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25709 part two
- Mostly cosmetic changes, mainly to get image decoders for Cairo build to
- comply with WebKit style guidelines:
- * Fix header guard names
- * Fix initializer list wrapping
- * Fix class/function "{" wrapping
- * Fix wrapping of long boolean expressions
- * Fix whitespace around operators
- * Eliminate whitespace on otherwise-blank lines
- * No {} on single-line conditional arms
- * Use 0 instead of NULL
- * Don't #include "config.h" in headers
-
- Also a few non-cosmetic changes:
- * Remove unneeded #ifdef protecting the contents of these files. The
- platforms listed don't match who uses these files anymore (even
- without considering Skia), and platforms which don't use them at all
- (like CG) aren't harmed by the files, since they don't have
- equivalently-named classes. It's simpler to just ditch these.
- * Convert a use of Vector<>& into SharedBuffer*, since that's how the
- data is really stored anyway.
- * Use size() instead of m_size, for consistency with Skia code, and
- future-proofing (if a particular decoder wants to specialize this).
- * Move an ASSERT that was slightly more aggressive than necessary.
- * Change variable names/types for clarity/accuracy and to match Skia.
- * Remove unnecessary macro magic to work around a problem which no
- longer exists in the third-party JPEG headers.
- * Stop silencing a portability warning about setjmp (the vcproj/vsprops
- are the right place for this)
- * In Skia code, don't explicitly check |m_failed| before calling
- isSizeAvailable(), which itself checks |m_failed|.
-
- * platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
- (WebCore::RGBA32Buffer::):
- (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
- (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- * platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
- * platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
- * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
- (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
- (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
- (WebCore::GIFImageDecoderPrivate::getColorMap):
- (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
- (WebCore::GIFImageDecoder::frameCount): Add comment.
- (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
- (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
- (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
- (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
- (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
- (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
- * platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
- * platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
- (GIFImageReader::read):
- * platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
- * platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
- * platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
- (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
- * platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
- * platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
- (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
- (WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
- (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
- (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
- (WebCore::PNGImageDecoder::rowAvailable):
- * platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
- * platform/image-decoders/skia/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
- (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
- * platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
- * platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
- (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- * platform/image-decoders/skia/JPEGImageDecoder.cpp:
- (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
- (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
- * platform/image-decoders/skia/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
- (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
- (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
- (WebCore::rowAvailable):
- * platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
- * platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
- * platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
-
-2009-05-26 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25944
- Remove the uses of V8 Locker in worker execution code. No additional test is needed.
- The normal WebKit layout tests should cover it. However, layout tests that start
- multiple workers will fail to pass due to test shell limitation in Chromium. To cover
- this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
-
- * bindings/v8/V8WorkerContextEventListener.cpp:
- (WebCore::V8WorkerContextEventListener::handleEvent):
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::dispose):
- (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- (WebCore::WorkerContextExecutionProxy::evaluate):
- (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
- (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
-
-2009-05-26 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25974
- Enable timers in Chromuim workers.
-
- * bindings/v8/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
- * bindings/v8/ScheduledAction.h:
- (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
- * bindings/v8/custom/V8WorkerContextCustom.cpp:
- (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
- Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
-
-2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=23649
- Update V8 bindings to match SQLTransactionErrorCallback change.
-
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
-
-2009-05-26 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Move FilterEffect to platform/graphics/filters. First step to get an
- SVG independent filter system.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/filters/FilterEffect.cpp: Added.
- (WebCore::FilterEffect::FilterEffect):
- (WebCore::FilterEffect::~FilterEffect):
- (WebCore::FilterEffect::externalRepresentation):
- * platform/graphics/filters/FilterEffect.h: Added.
- (WebCore::FilterEffect::xBoundingBoxMode):
- (WebCore::FilterEffect::setXBoundingBoxMode):
- (WebCore::FilterEffect::yBoundingBoxMode):
- (WebCore::FilterEffect::setYBoundingBoxMode):
- (WebCore::FilterEffect::widthBoundingBoxMode):
- (WebCore::FilterEffect::setWidthBoundingBoxMode):
- (WebCore::FilterEffect::heightBoundingBoxMode):
- (WebCore::FilterEffect::setHeightBoundingBoxMode):
- (WebCore::FilterEffect::subRegion):
- (WebCore::FilterEffect::setSubRegion):
- (WebCore::FilterEffect::resultImage):
- (WebCore::FilterEffect::setEffectBuffer):
- * svg/FilterEffect.cpp: Removed.
- * svg/FilterEffect.h: Removed.
-
-2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=23649
- Update SQLTransactionErrorCallback to not return a value per changes in
- HTML5 spec.
-
- Test: storage/transaction-error-callback.html
-
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.h:
- * storage/SQLTransaction.cpp:
- (WebCore::SQLTransaction::SQLTransaction):
- (WebCore::SQLTransaction::postflightAndCommit):
- (WebCore::SQLTransaction::handleTransactionError):
- (WebCore::SQLTransaction::deliverTransactionErrorCallback):
- (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- * storage/SQLTransaction.h:
- * storage/SQLTransactionErrorCallback.h:
-
-2009-05-26 David Hyatt <hyatt@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
-
- Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
- continue to show scrollbars.
-
- Added two tests in fast/dynamic.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2009-05-26 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 25801: change AccessibilityAria -> AccessibilityARIA
- https://bugs.webkit.org/show_bug.cgi?id=25801
-
- * GNUmakefile.am:
- * WebCore.order:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * accessibility/AXObjectCache.cpp:
- (WebCore::AXObjectCache::getOrCreate):
- * accessibility/AccessibilityARIAGrid.cpp: Copied from WebCore/accessibility/AccessibilityAriaGrid.cpp.
- (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
- (WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
- (WebCore::AccessibilityARIAGrid::create):
- (WebCore::AccessibilityARIAGrid::addChild):
- (WebCore::AccessibilityARIAGrid::addChildren):
- (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
- * accessibility/AccessibilityARIAGrid.h: Copied from WebCore/accessibility/AccessibilityAriaGrid.h.
- * accessibility/AccessibilityARIAGridCell.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridCell.cpp.
- (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
- (WebCore::AccessibilityARIAGridCell::~AccessibilityARIAGridCell):
- (WebCore::AccessibilityARIAGridCell::create):
- (WebCore::AccessibilityARIAGridCell::parentTable):
- (WebCore::AccessibilityARIAGridCell::rowIndexRange):
- (WebCore::AccessibilityARIAGridCell::columnIndexRange):
- * accessibility/AccessibilityARIAGridCell.h: Copied from WebCore/accessibility/AccessibilityAriaGridCell.h.
- * accessibility/AccessibilityARIAGridRow.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridRow.cpp.
- (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow):
- (WebCore::AccessibilityARIAGridRow::~AccessibilityARIAGridRow):
- (WebCore::AccessibilityARIAGridRow::create):
- (WebCore::AccessibilityARIAGridRow::parentTable):
- (WebCore::AccessibilityARIAGridRow::headerObject):
- * accessibility/AccessibilityARIAGridRow.h: Copied from WebCore/accessibility/AccessibilityAriaGridRow.h.
- * accessibility/AccessibilityAriaGrid.cpp: Removed.
- * accessibility/AccessibilityAriaGrid.h: Removed.
- * accessibility/AccessibilityAriaGridCell.cpp: Removed.
- * accessibility/AccessibilityAriaGridCell.h: Removed.
- * accessibility/AccessibilityAriaGridRow.cpp: Removed.
- * accessibility/AccessibilityAriaGridRow.h: Removed.
-
-2009-05-26 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=26012
-
- Fix the Skia path to normalize the given source rect when
- drawing patterns, so it accepts negative width/height (as CG does).
- Fixes Chromium bug http://www.crbug.com/6167.
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::Image::drawPattern):
-
-2009-05-26 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Serialize calls to WebInspector. This is the first step where method
- calls are being serialized to arrays (not yet JSON stringified ones) and
- are being dispatched on the client. This change also allows client to override
- InspectorFrontend, so that the serialized calls can be made on a given object
- instead of in-process WebInspector global. This will be the main control flow
- when InspectorController is decoupled from the in-process frontend.
-
- https://bugs.webkit.org/show_bug.cgi?id=26010
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::scriptObjectReady):
- (WebCore::InspectorController::overrideFrontendObject):
- (WebCore::InspectorController::show):
- (WebCore::InspectorController::populateScriptObjects):
- * inspector/InspectorController.h:
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::addMessageToConsole):
- (WebCore::InspectorFrontend::addResource):
- (WebCore::InspectorFrontend::updateResource):
- (WebCore::InspectorFrontend::removeResource):
- (WebCore::InspectorFrontend::updateFocusedNode):
- (WebCore::InspectorFrontend::setAttachedWindow):
- (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
- (WebCore::InspectorFrontend::showPanel):
- (WebCore::InspectorFrontend::populateInterface):
- (WebCore::InspectorFrontend::reset):
- (WebCore::InspectorFrontend::debuggerWasEnabled):
- (WebCore::InspectorFrontend::debuggerWasDisabled):
- (WebCore::InspectorFrontend::profilerWasEnabled):
- (WebCore::InspectorFrontend::profilerWasDisabled):
- (WebCore::InspectorFrontend::parsedScriptSource):
- (WebCore::InspectorFrontend::failedToParseScriptSource):
- (WebCore::InspectorFrontend::addProfile):
- (WebCore::InspectorFrontend::setRecordingProfile):
- (WebCore::InspectorFrontend::pausedScript):
- (WebCore::InspectorFrontend::resumedScript):
- (WebCore::InspectorFrontend::addDatabase):
- (WebCore::InspectorFrontend::addDOMStorage):
- (WebCore::InspectorFrontend::newFunctionCall):
- (WebCore::InspectorFrontend::callSimpleFunction):
- * inspector/InspectorFrontend.h:
- * inspector/front-end/inspector.js:
- (WebInspector.dispatch):
-
-2009-05-25 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
-
- * dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
- * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
- Adjust empty namespace before QNameComponentsTranslator black magic, not after.
-
-2009-05-25 David Levin <levin@chromium.org>
-
- Reviewed by Maciej Stachowiak and Oliver Hunt.
-
- Added forwarding headers.
-
- * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
- * ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
-
-2009-05-25 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- - WebCore side of <rdar://problem/6914001>.
-
- Add a new m_allowPopupsFromPlugin flag.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::ScriptController):
- (WebCore::ScriptController::processingUserGesture):
- * bindings/js/ScriptController.h:
- (WebCore::ScriptController::setAllowPopupsFromPlugin):
- (WebCore::ScriptController::allowPopupsFromPlugin):
-
-2009-05-25 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=26006
-
- Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
- window.location. The correct use appears to be as follows:
-
- 1) Use dynamicGlobalObject to find the user gesture.
- 2) Use dynamicGlobalObject to complete URLs.
- 3) Use lexicalGlobalObject to find the referrer.
- 4) Use lexicalGlobalObject for the frame navigation checks.
- 5) Use lexicalGlobalObject for the XSS checks.
-
- Tests: http/tests/security/frameNavigation/context-for-location-assign.html
- http/tests/security/frameNavigation/context-for-location-href.html
- http/tests/security/frameNavigation/context-for-location.html
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::shouldAllowNavigation):
- (WebCore::toLexicalFrame):
- (WebCore::processingUserGesture):
- (WebCore::completeURL):
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::navigateIfAllowed):
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::reload):
- (WebCore::JSLocation::assign):
- (WebCore::JSLocation::toString):
- (WebCore::JSLocationPrototype::customPut):
- * bindings/v8/V8Utilities.cpp:
- (WebCore::processingUserGesture):
- (WebCore::shouldAllowNavigation):
- (WebCore::completeURL):
- (WebCore::navigateIfAllowed):
- * bindings/v8/V8Utilities.h:
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetLocation):
- * bindings/v8/custom/V8LocationCustom.cpp:
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Maciej Stachowiak.
-
- With Windows compilers older then MSVC 2005, the functions
- gmtime_s and localtime_s don't exist. The gmtime and localtime are
- on Windows always thread safe. So use them in the cases where
- gmtime_s and localtime_s are not present.
-
- * loader/FTPDirectoryDocument.cpp:
- * loader/FTPDirectoryParser.cpp:
-
-2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- Follow up on r44120. PluginPackageMac.cpp is used
- by Qt on Mac and contained a copy of the m_browserFunc
- assignments and ::equal, ::hash and ::compareFileVersion.
- Change it to use the ones from PluginPackage.cpp as well.
-
- * plugins/mac/PluginPackageMac.cpp:
- (WebCore::PluginPackage::load):
-
-2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- https://bugs.webkit.org/show_bug.cgi?id=25612
-
- Support conditionals in the tag factories, by placing
- feature #ifdefs around the individual factory functions
- and the registration.
-
- Made the Audio and Video elements conditional in the tag factories
-
- * html/HTMLTagNames.in:
- * dom/make_names.pl:
-
-2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Gtk build when video is disabled.
-
- * GNUmakefile.am: Always generate and compile the IDL files for the media
- elements. They contain proper feature #ifdefs.
-
-2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build when video is disabled.
-
- * WebCore.pro: Always generate the IDL files for the media elements. They
- contain proper ENABLE(VIDEO) #ifdefs.
-
-2009-05-25 Adam Barth <abarth@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=26004
-
- The origin for postMessage should follow lexical scope, not dynamic
- scope. Yes, this is a super-obscure corner case.
-
- Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::postMessage):
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-24 Darin Fisher <darin@chromium.org>
-
- Reviewed by Mark Rowe.
-
- Fix build bustage related to PassOwnPtr changes.
-
- https://bugs.webkit.org/show_bug.cgi?id=25999
-
- * platform/graphics/chromium/TransparencyWin.cpp:
-
-2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25988
-
- Minor cleanup in PluginPackage::hash. Let the compiler
- figure out the size of the array. Do not have it in the
- definition and specially not the in the call to
- StringImpl::hash.
-
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::hash):
-
-2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25988
-
- Move ::hash, ::equal and ::compareFileVersion from
- the duplicated copies in PluginPackageQt.cpp and
- PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
- this for the PluginPackageWin version. Use the new style
- ENABLE() for this feature/policy and enable it in the Gtk+
- and Qt buildsystem.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::hash):
- (WebCore::PluginPackage::equal):
- (WebCore::PluginPackage::compareFileVersion):
- * plugins/gtk/PluginPackageGtk.cpp:
- * plugins/qt/PluginPackageQt.cpp:
-
-2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25988
-
- So far the initialization of the browserfuncs struct
- is done in PluginPackageQt, PluginPackageGtk and
- PluginPackageWin there is no need for this duplication.
-
- The PluginPackageWin version got copied to PluginPackage
-
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::initializeBrowserFuncs):
- * plugins/PluginPackage.h:
- * plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::load):
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::load):
- * plugins/win/PluginPackageWin.cpp:
- (WebCore::PluginPackage::load):
-
-2009-05-24 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- Added standard input for filter system.
-
- No testcases were added. Filter system is still off.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/filters/SourceAlpha.cpp: Added.
- (WebCore::SourceAlpha::create):
- (WebCore::SourceAlpha::effectName):
- (WebCore::SourceAlpha::apply):
- (WebCore::SourceAlpha::dump):
- * platform/graphics/filters/SourceAlpha.h: Added.
- (WebCore::SourceAlpha::SourceAlpha):
- * platform/graphics/filters/SourceGraphic.cpp: Added.
- (WebCore::SourceGraphic::create):
- (WebCore::SourceGraphic::effectName):
- (WebCore::SourceGraphic::apply):
- (WebCore::SourceGraphic::dump):
- * platform/graphics/filters/SourceGraphic.h: Added.
- (WebCore::SourceGraphic::SourceGraphic):
- * svg/FilterBuilder.cpp: Added.
- (WebCore::FilterBuilder::FilterBuilder):
- (WebCore::FilterBuilder::add):
- (WebCore::FilterBuilder::getEffectById):
- (WebCore::FilterBuilder::clearEffects):
- * svg/FilterBuilder.h:
-
-2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25612
-
- Add support conditionals in the JSC bindings generator code for attributes,
- by placing feature #ifdefs around the setters/getters.
-
- Made the audio and video element specific DOM attributes conditional
- in the generated code, by moving the #ifdefs from the IDL files into
- the generated code. This allows for re-using the same generated code
- with or without ENABLE(VIDEO).
-
- * page/DOMWindow.idl:
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
-
- * platform/text/qt/TextCodecQt.cpp:
- (WebCore::newTextCodecQt):
-
-2009-05-23 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - clean up ColorMac a little
-
- * platform/graphics/mac/ColorMac.h: Whitespace change.
- * platform/graphics/mac/ColorMac.mm: Removed redundant #import
- statements and sorted the remaining ones.
- (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
- with a single call and removed redundant casts to int.
- (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
- In one case, this avoids an intermediate conversion to float before
- conversion to double on 64-bit.
- (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
- with a single call.
- (WebCore::focusRingColor):
- (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
-
-2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
- https://bugs.webkit.org/show_bug.cgi?id=25900
-
- Use ATK_ROLE_TEXT for ListMarkerRole.
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- (atkRole):
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Reformat WebCore::requiresContextForWordBoundary()
-
- * platform/text/TextBoundaries.h:
- (WebCore::requiresContextForWordBoundary):
-
-2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::shouldContentSniffURL):
-
-2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
-
- After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
- RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
- This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
-
- WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
- HTMLSelectElement/WMLSelectElement.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * accessibility/AccessibilityListBox.cpp:
- (WebCore::AccessibilityListBox::addChildren):
- (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- * accessibility/AccessibilityListBoxOption.cpp:
- (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
- * accessibility/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::actionElement):
- * dom/Element.h:
- (WebCore::Element::isFormControlElement):
- (WebCore::Element::dispatchFormControlChangeEvent):
- * dom/SelectElement.cpp: Added.
- (WebCore::toSelectElement):
- * dom/SelectElement.h: Added.
- (WebCore::SelectElement::~SelectElement):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
- * html/HTMLFormControlElement.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setChecked):
- (WebCore::HTMLInputElement::defaultEventHandler):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::index):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::selectedIndex):
- (WebCore::HTMLSelectElement::lastSelectedListIndex):
- (WebCore::HTMLSelectElement::deselectItems):
- (WebCore::HTMLSelectElement::setSelectedIndex):
- (WebCore::HTMLSelectElement::length):
- (WebCore::HTMLSelectElement::remove):
- (WebCore::HTMLSelectElement::value):
- (WebCore::HTMLSelectElement::setValue):
- (WebCore::HTMLSelectElement::saveFormControlState):
- (WebCore::HTMLSelectElement::restoreFormControlState):
- (WebCore::HTMLSelectElement::selectAll):
- (WebCore::HTMLSelectElement::appendFormData):
- (WebCore::HTMLSelectElement::optionToListIndex):
- (WebCore::HTMLSelectElement::listToOptionIndex):
- (WebCore::HTMLSelectElement::recalcListItems):
- (WebCore::HTMLSelectElement::reset):
- (WebCore::HTMLSelectElement::dispatchFocusEvent):
- (WebCore::HTMLSelectElement::dispatchBlurEvent):
- (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
- (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
- (WebCore::HTMLSelectElement::updateListBoxSelection):
- (WebCore::HTMLSelectElement::menuListOnChange):
- (WebCore::HTMLSelectElement::listBoxOnChange):
- (WebCore::HTMLSelectElement::saveLastSelection):
- (WebCore::HTMLSelectElement::typeAheadFind):
- (WebCore::HTMLSelectElement::nextSelectableListIndex):
- (WebCore::HTMLSelectElement::previousSelectableListIndex):
- (WebCore::HTMLSelectElement::setLength):
- (WebCore::HTMLSelectElement::checkListItems):
- * html/HTMLSelectElement.h:
- (WebCore::HTMLSelectElement::size):
- (WebCore::HTMLSelectElement::multiple):
- (WebCore::HTMLSelectElement::listItems):
- (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::shouldContentSniffURL):
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::valueChanged):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::RenderListBox):
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::scrollToRevealSelection):
- (WebCore::RenderListBox::size):
- (WebCore::RenderListBox::numItems):
- (WebCore::RenderListBox::paintItemForeground):
- (WebCore::RenderListBox::paintItemBackground):
- (WebCore::RenderListBox::panScroll):
- (WebCore::RenderListBox::autoscroll):
- (WebCore::RenderListBox::stopAutoscroll):
- (WebCore::RenderListBox::valueChanged):
- (WebCore::RenderListBox::nodeAtPoint):
- * rendering/RenderListBox.h:
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::RenderMenuList):
- (WebCore::RenderMenuList::updateOptionsWidth):
- (WebCore::RenderMenuList::updateFromElement):
- (WebCore::RenderMenuList::setTextFromOption):
- (WebCore::RenderMenuList::showPopup):
- (WebCore::RenderMenuList::valueChanged):
- (WebCore::RenderMenuList::itemText):
- (WebCore::RenderMenuList::itemIsEnabled):
- (WebCore::RenderMenuList::itemStyle):
- (WebCore::RenderMenuList::itemBackgroundColor):
- (WebCore::RenderMenuList::listSize):
- (WebCore::RenderMenuList::selectedIndex):
- (WebCore::RenderMenuList::itemIsSeparator):
- (WebCore::RenderMenuList::itemIsLabel):
- (WebCore::RenderMenuList::itemIsSelected):
- (WebCore::RenderMenuList::setTextFromItem):
- * rendering/RenderMenuList.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::setValueForPosition):
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Fix Gtk/Qt builds for PassOwnPtr
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
- instead of an std::auto_ptr<ImageBuffer> to store the result of
- ImageBuffer::create() now that it returns a
- PassOwnPtr<ImageBuffer>.
- * platform/graphics/qt/PathQt.cpp:
- (WebCore::Path::strokeContains): Ditto.
- (WebCore::Path::strokeBoundingRect): Ditto.
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
-
- <https://bugs.webkit.org/show_bug.cgi?id=25495>
-
- Reviewed by Oliver Hunt.
-
- No test cases added since there is no change in behavior.
-
- * WebCore.base.exp: Updated export for
- HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
- * dom/Node.cpp:
- (WebCore::Node::childNodes): Use NodeListsNodeData::create()
- instead of new NodeListsNodeData.
- (WebCore::Node::registerDynamicNodeList): Ditto.
- (WebCore::Node::getElementsByTagNameNS): Ditto.
- (WebCore::Node::getElementsByName): Ditto.
- (WebCore::Node::getElementsByClassName): Ditto.
- * dom/NodeRareData.h:
- (WebCore::NodeListsNodeData::create): Added. Implements
- create() pattern popularized by RefCounted classes.
- (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
- private constructor.
- (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
- instead of an auto_ptr<>.
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::setRedirectURLs): Ditto.
- * history/HistoryItem.h:
- (WebCore::HistoryItem::setRedirectURLs): Ditto.
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
- OwnPtr<> instead of auto_ptr<> for stack variable.
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
- assignment operator now that ImageBuffer::create() returns a
- PassOwnPtr<>.
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
- PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- * page/ChromeClient.h:
- (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
- * platform/graphics/GeneratedImage.cpp:
- (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
- auto_ptr<> for stack variable.
- * platform/graphics/ImageBuffer.h:
- (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
- auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack
- variable.
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
- auto_ptr<> for stack variable.
- * platform/text/TextCodec.h:
- (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
- auto_ptr<>.
- * platform/text/TextCodecICU.cpp:
- (WebCore::newTextCodecICU): Ditto.
- * platform/text/TextCodecLatin1.cpp:
- (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
- * platform/text/TextCodecUTF16.cpp:
- (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
- (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
- * platform/text/TextCodecUserDefined.cpp:
- (WebCore::newStreamingTextDecoderUserDefined): Ditto.
- * platform/text/TextEncodingRegistry.cpp:
- (WebCore::newTextCodec): Ditto.
- * platform/text/TextEncodingRegistry.h:
- (WebCore::newTextCodec): Ditto.
- * platform/text/mac/TextCodecMac.cpp:
- (WebCore::newTextCodecMac): Ditto.
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
- OwnPtr<> instead of auto_ptr<> for stack variable.
- * svg/SVGMaskElement.cpp:
- (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return
- OwnPtr<> instead of auto_ptr<>.
- * svg/SVGMaskElement.h:
- (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
- instead of auto_ptr<>.
- * svg/SVGPatternElement.cpp:
- (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
- of auto_ptr<> for stack variable.
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
- assignment operator now that ImageBuffer::create() returns a
- PassOwnPtr<>.
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
- instead of auto_ptr<> for stack variable.
- * svg/graphics/SVGPaintServerPattern.cpp:
- (WebCore::SVGPaintServerPattern::setTile): Updated to take a
- PassOwnPtr<> instead of an auto_ptr<>.
- (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
- auto_ptr<> for stack variable.
- * svg/graphics/SVGPaintServerPattern.h:
- (WebCore::SVGPaintServerPattern::setTile): Updated to take a
- PassOwnPtr<> instead of an auto_ptr<>.
- * svg/graphics/SVGResourceMasker.cpp:
- (WebCore::SVGResourceMasker::applyMask): Updated to use
- assignment operator now that SVGMaskElement::drawMaskerContent()
- returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for
- stack variable.
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
-
- <https://bugs.webkit.org/show_bug.cgi?id=25495>
-
- Reviewed by Oliver Hunt.
-
- * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
- PassOwnPtr.h.
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Fix Mac builds by backing out r44093
-
- * bindings/js/JSCustomPositionCallback.cpp:
- * bindings/js/JSCustomPositionCallback.h:
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- * bindings/js/JSCustomPositionErrorCallback.h:
- * bindings/js/JSGeolocationCustom.cpp:
- * page/Geolocation.cpp:
- * page/Geolocation.idl:
- * page/Geoposition.cpp:
- * page/Geoposition.h:
- * page/Geoposition.idl:
- * page/Navigator.cpp:
- (WebCore::Navigator::disconnectFrame):
- (WebCore::Navigator::geolocation):
- * page/PositionError.idl:
- * platform/GeolocationService.cpp:
- (WebCore::GeolocationService::create):
-
-2009-05-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Eric Seidel.
-
- Add GEOLOCATION guards around Geolocation API code
- https://bugs.webkit.org/show_bug.cgi?id=25756
-
- * bindings/js/JSCustomPositionCallback.cpp:
- * bindings/js/JSCustomPositionCallback.h:
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- * bindings/js/JSCustomPositionErrorCallback.h:
- * bindings/js/JSGeolocationCustom.cpp:
- * page/Geolocation.cpp:
- * page/Geolocation.idl:
- * page/Geoposition.cpp:
- * page/Geoposition.h:
- * page/Geoposition.idl:
- * page/Navigator.cpp:
- (WebCore::Navigator::disconnectFrame):
- (WebCore::Navigator::geolocation):
- * page/PositionError.idl:
- * platform/GeolocationService.cpp:
-
-2009-05-23 David Kilzer <ddkilzer@apple.com>
-
- Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
-
- In r42377, startUpdateRenderingDispatcher() was renamed to
- startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
- dropped. This change restores it.
-
- * WebCore.order:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
- (WebCore::AnimationControllerPrivate::addEventToDispatch):
- (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- * page/animation/AnimationControllerPrivate.h:
-
-2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build-fix for Qt. Disable SVG Filters.
-
- SVG Filters can not be built right now and Qt should not have
- them enabled anyway as they do not carry out any filtering.
-
- * WebCore.pro:
-
-2009-05-23 Dirk Schulze <krit@webkit.org>
-
- Unreviewed build-fix for gtk. Remove source input files
- for SVG filter system from the build for the moment and
- add them later again.
-
- * GNUmakefile.am:
-
-2009-05-23 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Eric Seidel.
-
- WebKit needs cross-platform filter system
- [https://bugs.webkit.org/show_bug.cgi?id=19991]
-
- Preparing Filter primitves for the new filter system.
-
- No testcases were added. SVG filters are off by default.
-
- * GNUmakefile.am:
- * platform/graphics/filters/FEBlend.cpp:
- (WebCore::FEBlend::apply):
- * platform/graphics/filters/FEBlend.h:
- * platform/graphics/filters/FEColorMatrix.cpp:
- (WebCore::FEColorMatrix::apply):
- * platform/graphics/filters/FEColorMatrix.h:
- * platform/graphics/filters/FEComponentTransfer.cpp:
- (WebCore::FEComponentTransfer::apply):
- * platform/graphics/filters/FEComponentTransfer.h:
- * platform/graphics/filters/FEComposite.cpp:
- (WebCore::FEComposite::apply):
- * platform/graphics/filters/FEComposite.h:
- * svg/Filter.h:
- * svg/FilterBuilder.h:
- (WebCore::FilterBuilder::lastFilter):
- * svg/FilterEffect.cpp:
- (WebCore::FilterEffect::FilterEffect):
- * svg/FilterEffect.h:
- (WebCore::FilterEffect::xBoundingBoxMode):
- (WebCore::FilterEffect::setXBoundingBoxMode):
- (WebCore::FilterEffect::yBoundingBoxMode):
- (WebCore::FilterEffect::setYBoundingBoxMode):
- (WebCore::FilterEffect::widthBoundingBoxMode):
- (WebCore::FilterEffect::setWidthBoundingBoxMode):
- (WebCore::FilterEffect::heightBoundingBoxMode):
- (WebCore::FilterEffect::setHeightBoundingBoxMode):
- (WebCore::FilterEffect::subRegion):
- (WebCore::FilterEffect::setSubRegion):
- (WebCore::FilterEffect::resultImage):
- (WebCore::FilterEffect::setEffectBuffer):
- * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
- (WebCore::FEConvolveMatrix::apply):
- * svg/graphics/filters/SVGFEConvolveMatrix.h:
- * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- (WebCore::FEDiffuseLighting::apply):
- * svg/graphics/filters/SVGFEDiffuseLighting.h:
- * svg/graphics/filters/SVGFEDisplacementMap.cpp:
- (WebCore::FEDisplacementMap::apply):
- * svg/graphics/filters/SVGFEDisplacementMap.h:
- * svg/graphics/filters/SVGFEFlood.cpp:
- (WebCore::FEFlood::apply):
- * svg/graphics/filters/SVGFEFlood.h:
- * svg/graphics/filters/SVGFEGaussianBlur.cpp:
- (WebCore::FEGaussianBlur::apply):
- * svg/graphics/filters/SVGFEGaussianBlur.h:
- * svg/graphics/filters/SVGFEImage.cpp:
- (WebCore::FEImage::apply):
- * svg/graphics/filters/SVGFEImage.h:
- * svg/graphics/filters/SVGFEMerge.cpp:
- (WebCore::FEMerge::apply):
- * svg/graphics/filters/SVGFEMerge.h:
- * svg/graphics/filters/SVGFEMorphology.cpp:
- (WebCore::FEMorphology::apply):
- * svg/graphics/filters/SVGFEMorphology.h:
- * svg/graphics/filters/SVGFEOffset.cpp:
- (WebCore::FEOffset::apply):
- * svg/graphics/filters/SVGFEOffset.h:
- * svg/graphics/filters/SVGFESpecularLighting.cpp:
- (WebCore::FESpecularLighting::apply):
- * svg/graphics/filters/SVGFESpecularLighting.h:
- * svg/graphics/filters/SVGFETile.cpp:
- (WebCore::FETile::apply):
- * svg/graphics/filters/SVGFETile.h:
- * svg/graphics/filters/SVGFETurbulence.cpp:
- (WebCore::FETurbulence::apply):
- * svg/graphics/filters/SVGFETurbulence.h:
-
-2009-05-22 Dirk Schulze <krit@webkit.org>
-
- Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::Image::drawPattern):
-
-2009-05-22 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- Added the use of tileRect() for a correct drawing of
- border-images.
-
- Testcases for border-image are in fast/borders like
- border-image-01.html and will be activated for cairo, once
- gtk supports pixel tests.
-
- https://bugs.webkit.org/show_bug.cgi?id=19652
- [CAIRO] wrong drawing of border-image
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::Image::drawPattern):
-
-2009-05-22 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25684
-
- Ask the Scrollbar for the orientation.
-
- Use Scrollbar::orientation to figure out the
- direction of scrolling.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::valueChanged):
-
-2009-05-22 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6916082> Incorrect handling of % as CSS value.
-
- Test: fast/css/percent-character-as-value.html
-
- * css/CSSGrammar.y: Make a stray % character reliably cause
- CSS parsing to succeed, but the CSS value to be ignored because
- of incorrect type. A type of 0 has this effect.
-
-2009-05-22 Brent Fulgham <bfulgham@webkit.org>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25971
- Correct a handful of build errors in the Windows Cairo variant
- due to missing VIDEO support.
-
- * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
- the Cairo-based Windows target.
- * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
- for non-VIDEO builds.
-
-2009-05-22 David Kilzer <ddkilzer@apple.com>
-
- One <limits> is enough
-
- * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
-
-2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
-
- <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
- plug-in
-
- Reviewed by Steve Falkenburg.
-
- * plugins/win/PluginPackageWin.cpp:
- (WebCore::PluginPackage::determineQuirks):
- Look for the VLC plug-in's new name.
-
-2009-05-22 Adam Barth <abarth@webkit.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25966
-
- Remove redudant member from Chromium's ResourceRequest. We already
- have this data in the cross-platform ResourceRequestBase. Also, rename
- ChromiumBridge parameter to be consistant with the new name for this
- piece of data.
-
- * platform/chromium/ChromiumBridge.h:
- * platform/network/chromium/ResourceRequest.h:
-
-2009-05-22 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Only account for overhang for multi-character strings.
-
- https://bugs.webkit.org/show_bug.cgi?id=25961
-
- * platform/wx/wxcode/win/fontprops.cpp:
- (GetTextExtent):
-
-2009-05-22 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Switch to CURL cookies so we can benefit from API updates.
-
- * platform/wx/TemporaryLinkStubs.cpp:
- * webcore-wx.bkl:
-
-2009-05-22 Peter Kasting <pkasting@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25709 part one
- Indent contents of namespaces in header files, to comply with the
- style guide. No functional change.
-
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::RGBA32Buffer::):
- (WebCore::RGBA32Buffer::RGBA32Buffer):
- (WebCore::RGBA32Buffer::clear):
- (WebCore::RGBA32Buffer::bytes):
- (WebCore::RGBA32Buffer::rect):
- (WebCore::RGBA32Buffer::height):
- (WebCore::RGBA32Buffer::status):
- (WebCore::RGBA32Buffer::duration):
- (WebCore::RGBA32Buffer::disposalMethod):
- (WebCore::RGBA32Buffer::hasAlpha):
- (WebCore::RGBA32Buffer::setRect):
- (WebCore::RGBA32Buffer::ensureHeight):
- (WebCore::RGBA32Buffer::setStatus):
- (WebCore::RGBA32Buffer::setDuration):
- (WebCore::RGBA32Buffer::setDisposalMethod):
- (WebCore::RGBA32Buffer::setHasAlpha):
- (WebCore::RGBA32Buffer::setRGBA):
- (WebCore::ImageDecoder::m_failed):
- (WebCore::ImageDecoder::~ImageDecoder):
- (WebCore::ImageDecoder::setData):
- (WebCore::ImageDecoder::size):
- (WebCore::ImageDecoder::frameCount):
- (WebCore::ImageDecoder::repetitionCount):
- (WebCore::ImageDecoder::supportsAlpha):
- (WebCore::ImageDecoder::failed):
- (WebCore::ImageDecoder::setFailed):
- (WebCore::ImageDecoder::clearFrameBufferCache):
- * platform/image-decoders/bmp/BMPImageDecoder.h:
- (WebCore::BMPImageDecoder::filenameExtension):
- * platform/image-decoders/gif/GIFImageDecoder.h:
- (WebCore::GIFImageDecoder::filenameExtension):
- (WebCore::GIFImageDecoder::frameDurationAtIndex):
- (WebCore::GIFImageDecoder::):
- * platform/image-decoders/ico/ICOImageDecoder.h:
- (WebCore::ICOImageDecoder::filenameExtension):
- * platform/image-decoders/jpeg/JPEGImageDecoder.h:
- (WebCore::JPEGImageDecoder::filenameExtension):
- (WebCore::JPEGImageDecoder::supportsAlpha):
- (WebCore::JPEGImageDecoder::reader):
- (WebCore::JPEGImageDecoder::setSize):
- * platform/image-decoders/png/PNGImageDecoder.h:
- (WebCore::PNGImageDecoder::filenameExtension):
- (WebCore::PNGImageDecoder::reader):
- (WebCore::PNGImageDecoder::decodingFailed):
- * platform/image-decoders/xbm/XBMImageDecoder.h:
- (WebCore::XBMImageDecoder::filenameExtension):
-
-2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=15914
- [GTK] Implement Unicode functionality using GLib
-
- Minor changes that allow building a hybrid version of WebKit
- that has WTF Unicode backend based on GLib functions while
- text codecs and TextBreakIterator remain based on ICU.
-
- Fixed some includes that were assuming a WTF ICU backend and
- introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
- macro.
-
- * platform/ThreadGlobalData.cpp:
- (WebCore::ThreadGlobalData::ThreadGlobalData):
- (WebCore::ThreadGlobalData::~ThreadGlobalData):
- * platform/ThreadGlobalData.h:
- * platform/text/TextBoundariesICU.cpp:
- * platform/text/TextCodecICU.h:
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::encode):
- * platform/text/TextEncodingRegistry.cpp:
- (WebCore::buildBaseTextCodecMaps):
- (WebCore::extendTextCodecMaps):
-
-2009-05-22 Adam Barth <abarth@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25955
-
- Remove the policyBaseURL parameter from setCookie. This parameter is
- redundant with the document parameter.
-
- * WebCore.base.exp:
- * WebCore.order:
- * dom/Document.cpp:
- (WebCore::Document::setCookie):
- * platform/CookieJar.h:
- * platform/mac/CookieJar.mm:
- (WebCore::setCookies):
- * platform/network/chromium/CookieJarChromium.cpp:
- (WebCore::setCookies):
- * platform/network/curl/CookieJarCurl.cpp:
- (WebCore::setCookies):
- * platform/network/soup/CookieJarSoup.cpp:
- (WebCore::setCookies):
- * platform/network/win/CookieJarCFNetWin.cpp:
- (WebCore::setCookies):
- * platform/network/win/CookieJarWin.cpp:
- (WebCore::setCookies):
- * platform/qt/CookieJarQt.cpp:
- (WebCore::setCookies):
-
-2009-05-22 Adam Barth <abarth@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25955
-
- Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
- previous names were confusing and inaccurate.
-
- * WebCore.order:
- * dom/Document.cpp:
- (WebCore::Document::setCookie):
- * dom/Document.h:
- (WebCore::Document::firstPartyForCookies):
- (WebCore::Document::setFirstPartyForCookies):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::begin):
- (WebCore::FrameLoader::updateFirstPartyForCookies):
- (WebCore::FrameLoader::setFirstPartyForCookies):
- (WebCore::FrameLoader::open):
- (WebCore::FrameLoader::addExtraFieldsToRequest):
- (WebCore::FrameLoader::loadResourceSynchronously):
- * loader/FrameLoader.h:
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::willSendRequest):
- (WebCore::ResourceRequestBase::adopt):
- (WebCore::ResourceRequestBase::copyData):
- (WebCore::ResourceRequestBase::firstPartyForCookies):
- (WebCore::ResourceRequestBase::setFirstPartyForCookies):
- (WebCore::equalIgnoringHeaderFields):
- * platform/network/ResourceRequestBase.h:
- * platform/network/cf/ResourceRequestCFNet.cpp:
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- * platform/network/chromium/CookieJarChromium.cpp:
- (WebCore::setCookies):
- * platform/network/mac/ResourceRequestMac.mm:
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::firstPartyForCookies):
- (WebCore::ResourceRequestBase::setFirstPartyForCookies):
- * platform/network/chromium/CookieJarChromium.cpp:
- (WebCore::setCookies):
- * platform/network/curl/CookieJarCurl.cpp:
- (WebCore::setCookies):
- * platform/network/soup/CookieJarSoup.cpp:
- (WebCore::setCookies):
- * platform/network/win/CookieJarCFNetWin.cpp:
- (WebCore::setCookies):
- * platform/network/win/CookieJarWin.cpp:
- (WebCore::setCookies):
- * platform/qt/CookieJarQt.cpp:
- (WebCore::setCookies):
-
-2009-05-22 Pavel Feldman <pfeldman@chromium.org>
-
- Fix the call to editingCancelled to be this._editingCancelled, since
- editingCancelled doesn't exist and throws an exception.
-
- <https://bugs.webkit.org/show_bug.cgi?id=24881>
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
-
-2009-05-22 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25928
- Several errors detected by cppcheck
-
- Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
- should take a look at other reports.
-
- * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
- are billions of those.
-
-2009-05-22 Shinichiro Hamaji <hamaji@google.com>
-
- Reviewed by Oliver Hunt.
-
- Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
- This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
-
- https://bugs.webkit.org/show_bug.cgi?id=25956
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::drawRect):
- (WebCore::GraphicsContext::drawLine):
- (WebCore::GraphicsContext::strokeArc):
- (WebCore::GraphicsContext::drawConvexPolygon):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::fillRoundedRect):
- (WebCore::GraphicsContext::strokeRect):
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::drawConvexPolygon):
- (WebCore::GraphicsContext::drawEllipse):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::strokeRect):
-
-2009-05-22 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- Revert the whole thing, since we can't figure out a way to make it
- work in all platforms.
-
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::pathForDecoration):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
-
-2009-05-22 Xan Lopez <xlopez@igalia.com>
-
- Try to fix Windows build.
-
- Apparently it can't tell if '1.0f' is float or double, so cast to
- float.
-
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::pathForDecoration):
-
-2009-05-22 Xan Lopez <xlopez@igalia.com>
-
- Try to fix breakage from the previous patch.
-
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::pathForDecoration):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
-
-2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=25805
- In debug build, mingw win32 build has problems with powf
-
- Change C-style calls to powf and sqrtf to C++-style calls to
- overloaded pow and sqrt. This solves also a problem with mingw
- compiler during the debug build.
-
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::pathForDecoration):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
-
-2009-05-21 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6913680> Update image caching options.
- Disable extra ImageIO cache because we already handle caching decoded image data.
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::imageSourceOptions):
-
-2009-05-21 Albert J. Wong <ajwong@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Bug 25903: Create a default UI theme for media controls in Chromium.
- https://bugs.webkit.org/show_bug.cgi?id=25903
-
- Implement a default UI for chromium. Add a style sheet for Chromium
- media controls with good defaults and implemented basic draw functions
- for play/pause & mute buttons.
-
- * css/mediaControlsChromium.css: Added.
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
- our custom media controls style sheet.
- (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
- buttons respecting chromium media controls color scheme.
- (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
- specific to play/pause button.
- (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
- specific to mute button.
- * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
- our custom media controls style sheet.
- (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
- buttons respecting chromium media controls color scheme.
- (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
- specific to play/pause button.
- (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
- to mute button.
- (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
- header changes.
- * rendering/RenderThemeChromiumWin.h:
-
-2009-05-21 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- When stripping the query from a file:// URL, do not leave a trailing question mark.
-
- https://bugs.webkit.org/show_bug.cgi?id=25940
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::initializeHandle):
-
-2009-05-21 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Notify ImageObserver::didDraw to help the cache purge alive resources.
-
- https://bugs.webkit.org/show_bug.cgi?id=25942
-
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
- (WebCore::BitmapImage::drawPattern):
-
-2009-05-21 Evan Martin <evan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Flesh out font fallback for Chromium's Skia port.
- getLastResortFallbackFont should fall back on well-known fonts.
- https://bugs.webkit.org/show_bug.cgi?id=25860
-
- * platform/graphics/chromium/FontCacheLinux.cpp:
- (WebCore::FontCache::getLastResortFallbackFont): try known font names.
-
-2009-05-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - speculative fix for <rdar://problem/6890716> crash at
- FontCache::purgeInactiveFontData + 199
-
- * platform/graphics/FontCache.cpp:
- (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
- can cause releaseFontData() to be called, which modifies
- gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
- while iterating over gInactiveFontData and delete them afterwards.
-
-2009-05-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
- Incorrect URL returned to the DOM while the user drags a file
-
- * page/DragController.cpp:
- (WebCore::DragController::dragExited):
- (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
- since that only looks at the text of the document's URL. Do base our
- decision on the securityOrigin(), which knows more about the document's
- actual origin.
-
-2009-05-21 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Mark Rowe.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=25947
- Assertion failure in FrameLoader::transitionToCommitted on launch in
- Safari with r43985
+ Added Speech submenu to context menu on Mac when there's a non-editable selection
+ (it was already present when there's an editable selection).
+ Also added support for disabling "Stop Speaking" when there is no speaking to stop.
- Rolled out r43979.
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedNonImageMimeTypes):
- (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
-
-2009-05-21 Sam Weinig <sam@webkit.org>
-
- Reviewed by Brady Eidson and Mark Rowe.
-
- Fix for <rdar://problem/6901522>
- REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
-
- If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
- the MIME type to be text/html.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
-
-2009-05-21 Kevin Ollivier <kevino@theolliviers.com>
-
- Blind windows fix after last commit.
-
- * platform/Logging.cpp:
- (WebCore::getChannelFromName):
-
-2009-05-21 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Use an environment variable to control which logs are on and off.
- Also, make a generic function for translating channel name to its log.
-
- https://bugs.webkit.org/show_bug.cgi?id=25936
-
- * platform/Logging.cpp:
- (WebCore::getChannelFromName):
- * platform/Logging.h:
- * platform/wx/LoggingWx.cpp:
- (WebCore::InitializeLoggingChannelsIfNecessary):
-
-2009-05-21 David Levin <levin@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
- https://bugs.webkit.org/show_bug.cgi?id=25946
-
- A very simple implementation to keep it working. A bug has been filed in the chromium db
- (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
- complete.
-
- * platform/chromium/MimeTypeRegistryChromium.cpp:
- (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
-
-2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>
-
- Reviewed by Justin Garcia.
-
- Add automatic spell correction support in WebKit
-
- https://bugs.webkit.org/show_bug.cgi?id=24953
+ Reviewed by Tim Hatcher.
- * editing/Editor.cpp:
- (WebCore::findFirstMisspellingInRange):
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- (WebCore::markAllMisspellingsInRange):
- (WebCore::markMisspellingsOrBadGrammar):
- (WebCore::Editor::markMisspellings):
- (WebCore::Editor::markBadGrammar):
- (WebCore::Editor::markMisspellingsAndBadGrammar):
- * editing/Editor.h:
* loader/EmptyClients.h:
- (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- * page/EditorClient.h:
-
-2009-05-21 Christian Dywan <christian@twotoasts.de>
-
- Reviewed by Darin Adler.
-
- Text files which have sub MIME types are treated as not displayable
- http://bugs.webkit.org/show_bug.cgi?id=24903
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedNonImageMimeTypes):
- (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
- MIME type beginning with "text/" as supported and remove all "text/"
- types from the list.
-
-2009-05-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=25890
- Implement Network logging channel on Mac
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::~ResourceHandle):
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::cancel):
- (WebCore::ResourceHandle::setDefersLoading):
- (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
- (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
- (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
- (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
- (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
- (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
- (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
- (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
- Added logging for async requests (as these are most interesting).
-
-2009-05-21 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by David Kilzer.
-
- <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
-
- Add a static table to map from some common file extensions to their MIME types so it
- is possible to detect support even when the platform mapping is incomplete. Use the
- table to lookup types not found by UTI on the OSX, and when looking for a media engine
- with a generic or missing type.
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
- (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
- MIME type in the static mapping table if the platform specific getMIMETypeForExtension
- doesn't find a match.
- * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
- "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
- to MIME type if UTI fails.
-
-2009-05-21 Eric Seidel <eric@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Clean up DragController
- https://bugs.webkit.org/show_bug.cgi?id=25926
-
- I renamed m_document to m_documentUnderMouse to better document what it does
- I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
- long enough.
-
- I also saw copy/paste code involving clearing the selection when moving out of
- one document and into another. I moved that code into a function called
- mouseMovedIntoDocument.
-
- I also got rid of a couple needless null-checks after confirming via source
- inspection they were not ever possible.
- In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
- I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
- It's also not possible to return a document from documentAtPoint that is not
- in a frame (as such a document would not be rendered).
-
- No functional changes, thus no tests.
-
- * page/DragController.cpp:
- (WebCore::DragController::DragController):
- (WebCore::DragController::dragIsMove):
- (WebCore::DragController::dragExited):
- (WebCore::DragController::performDrag):
- (WebCore::DragController::mouseMovedIntoDocument):
- (WebCore::DragController::dragEnteredOrUpdated):
- (WebCore::DragController::tryDocumentDrag):
- (WebCore::DragController::operationForLoad):
- (WebCore::DragController::concludeEditDrag):
- (WebCore::DragController::canProcessDrag):
- (WebCore::DragController::tryDHTMLDrag):
- (WebCore::DragController::placeDragCaret):
- * page/DragController.h:
- (WebCore::DragController::documentUnderMouse):
-
-2009-05-21 Eric Seidel <eric@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Rename DragController::dragOperation() to sourceDragOperation() for clarity
- Remove unused setDragOperation()
-
- There are two times DragOperation is used. The source specifies
- what drag operations it supports (in a mask) and the destination
- picks a subset of those as DragOperations it supports if a drop were
- to occur. I was confused when I first saw this accessor as to which
- it meant. It turns out that this is only used when WebKit starts a
- drag, and we keep it around so that we can provide this information
- to other Mac OS X applications when they ask. I've renamed the method
- for clarity so the next person in this code will be less confused.
-
- No functional changes, thus no tests.
-
- * page/DragController.h:
- (WebCore::DragController::sourceDragOperation):
-
-2009-05-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
- crash painting the selection on registration page of car2go.com
-
- A bug in old versions of Core Graphics causes memory corruption to occur
- when clipping under certain conditions. Make the clipping functions
- fail silently under those conditions.
-
- Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
-
- * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
- on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
- (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
- (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
- (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
- of CGContextClip, CGContextEOClip and CGContextClipToRect.
- (WebCore::GraphicsContext::strokePath): Ditto.
- (WebCore::GraphicsContext::fillRect): Ditto.
- (WebCore::GraphicsContext::clip): Ditto.
- (WebCore::GraphicsContext::clipOut): Ditto.
- (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
- (WebCore::GraphicsContext::clipPath): Ditto.
- (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
- (WebCore::GraphicsContext::strokeRect): Ditto.
- * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
- * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
-
-2009-05-21 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25910
- WebkitGTK r43960 cannot compile
-
- Do not include local copy of guriescape header, which was
- removed. We now use the copy in glib.
-
- * platform/gtk/FileSystemGtk.cpp:
-
-2009-05-20 Adam Barth <abarth@webkit.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25706
-
- It turns out the CurrentContext wasn't currect either because it gave
- us the frame for the write() function itself. We actually want the
- *calling* context.
-
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- [GTK] Implement Image::loadPlatformResource.
-
- Install the four resources we are using. For the icons
- where an icon name is specified by freedeskop.org try to
- map the WebCore name to that name and fallback to the
- internal icon. For everything else use the internal icon
- name. Remove the temporary link stub as this is not
- required any more.
-
- * GNUmakefile.am: Install the png files, set DATA_DIR again
- * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
- * platform/graphics/gtk/ImageGtk.cpp:
- (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
- (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
- (WebCore::loadResourceIntoSharedBuffer):
- (WebCore::Image::loadPlatformResource): Implement
- * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
-
-2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=19357
-
- [GTK] The Gtk+ port wants to have a themable
- urlIcon too.
-
- * loader/icon/IconDatabase.cpp:
-
-2009-05-20 Stephanie Lewis <slewis@apple.com>
-
- Update the order files. <rdar://problem/6881750> Generate new order files.
-
- * WebCore.order:
-
-2009-05-20 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Fix some assertion failures in plug-in tests on the Windows debug build bot.
-
- * plugins/PluginStream.cpp:
- (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
- * plugins/PluginView.cpp:
- (WebCore::scriptStringIfJavaScriptURL): Ditto.
-
-2009-05-20 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- More protocolInHTTPFamily() cleanup.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::send):
-
-2009-05-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix for <rdar://problem/6905475>
- Office 2008: Entourage: Crash when you switch to "My Day" view
-
- The host function callback callObjCFallbackObject was not annotated
- with JSC_HOST_CALL which meant that when it was called by the JIT, which
- expects the JSC_HOST_CALL calling convention, the arguments are not in the
- expected places.
-
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
- annotation on callObjCFallbackObject.
-
-2009-05-20 David Levin <levin@chromium.org>
-
- Not Reviewed, build fix.
-
- Need to disable this assert while the chormium code is fixed for it.
-
- * platform/KURLGoogle.cpp:
- (WebCore::KURL::protocolIs):
-
-2009-05-20 David Levin <levin@chromium.org>
-
- Not Reviewed, build fix.
-
- Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
- http://trac.webkit.org/changeset/43929. Fix assert placement.
-
- * platform/KURLGoogle.cpp:
- (WebCore::KURL::protocolIs):
- (WebCore::protocolIs):
-
-2009-05-20 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Upstream V8 bindings for V8DomWindow.
- https://bugs.webkit.org/show_bug.cgi?id=25869
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
- (WebCore::isAscii): Moved from v8_custom.cpp.
- (WebCore::convertBase64): Moved from v8_custom.cpp.
- (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
- (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
- (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
- (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
- (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
- (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
-
-2009-05-21 Christian Dywan <christian@twotoasts.de>
-
- Reviewed by Jan Alonzo.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::parseDataUrl): Always use Glib Base64 decoding.
-
-2009-05-21 Christian Dywan <christian@twotoasts.de>
-
- Rubberstamped by Gustavo Noronha.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
-
-2009-05-20 Christian Dywan <christian@twotoasts.de>
-
- Reviewed by Gustavo Noronha.
-
- * GNUmakefile.am:
- * platform/gtk/guriescape.c:
- * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
- g_uri_unescape_string now that we require Glib 2.16.
-
-2009-05-20 David Levin <levin@chromium.org>
-
- Not Reviewed, build fix.
-
- Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
- http://trac.webkit.org/changeset/43929.
-
- * platform/KURLGoogle.cpp:
- (WebCore::protocolIsJavaScript):
- (WebCore::protocolIs):
-
-2009-05-20 Brady Eidson <beidson@apple.com>
-
- Rubberstamped by Sam Weinig
-
- At all call sites that check if a KURL has either the http or https protocol,
- use the KURL::protocolInHTTPFamily() accessor, instead.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::iconURL):
- (WebCore::FrameLoader::didOpenURL):
- (WebCore::FrameLoader::open):
-
- * loader/appcache/ApplicationCache.cpp:
- (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
-
- * loader/loader.cpp:
- (WebCore::Loader::load):
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::send):
-
-2009-05-20 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
-
- KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
- "javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
- invalid, you can no longer ask it a question such as "is your protocol javascript?"
- Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
- navigate to them.
-
- URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
- being a high profile example) and actually represent valid javascript.
-
- Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
- as it functions on a String which doesn't have to pass KURLs parsing rules.
-
- Test: fast/loader/javascript-url-hierarchical-execution.html
-
- * bindings/js/JSAttrCustom.cpp:
- (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation): Ditto.
- (WebCore::createWindow): Ditto.
- (WebCore::JSDOMWindow::open): Ditto.
- * bindings/js/JSElementCustom.cpp:
- (WebCore::allowSettingSrcToJavascriptURL): Ditto.
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- (WebCore::allowSettingJavascriptURL): Ditto.
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::navigateIfAllowed): Ditto.
- (WebCore::JSLocation::reload): Ditto.
- * editing/markup.cpp:
- (WebCore::appendQuotedURLAttributeValue): Ditto.
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::requestFrame): Ditto.
- (WebCore::FrameLoader::submitForm): Ditto.
- (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
-
- * platform/KURL.cpp:
- (WebCore::KURL::init): Use protocolIsJavaScript().
- (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
- Such checks should go through protocolIsJavaScript() instead.
- (WebCore::encodeRelativeString): Use protocolIsJavaScript().
- (WebCore::protocolIsJavaScript):
- * platform/KURL.h:
-
-2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=24510
-
- Fix a bug where the browserfuncs were not properly assigned,
- make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
-
- Test: plugins/netscape-invoke-browserfuncs.html
-
- * plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::load): Fix assignment
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::load): Fix assignment
-
-2009-05-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Timothy Hatcher.
-
- Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
- and only exist on RenderText.
-
- * dom/Range.cpp:
- (WebCore::Range::textRects):
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
- of absoluteQuadsForRange since no range is being specifiec.
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderText.h:
-
-2009-05-20 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- Implement AtkObject::focus-event and
- AtkObject::state-changed:focused signal emission.
-
- Adds a new handleFocusedUIElementChangedWithRenderers, only in the
- GTK port, called at the same point than
- handleFocusedUIElementChanged but with two parameters, the old and
- the newly focused RenderObjects. We need this, since the ATK
- signals require us to pass the objects involved in the focus
- change as arguments.
-
- * accessibility/AXObjectCache.h:
- * accessibility/gtk/AXObjectCacheAtk.cpp:
- (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
-
-2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25834
-
- Make ChromeClient a interface again
-
- With recent additions to ChromeClient.h empty defaults were
- added. This is bad for porters as these changes go unnoticed
- and at runtime no notImplemented warning is logged and grepping
- for notImplemented will not show anything. Change this Client
- to be like the other Clients again and always have pure virtuals
- (but for stuff inside #ifdef PLATFORM(MAC)).
-
- Update the various WebKit/* implementations to compile again.
-
- * loader/EmptyClients.h: Add empty defaults
- (WebCore::EmptyChromeClient::setCursor):
- (WebCore::EmptyChromeClient::scrollRectIntoView):
- (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
- * page/ChromeClient.h: Make methods pure virtual
-
-2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Fix a bug where a non visible plugin would show it self in a
- sibling frame. The problem was due to our clipping. In Qt,
- if setMask is set with an empty QRegion, no clipping will
- be performed, so in that case we hide the PluginContainer
-
- Added manual test.
-
- * plugins/qt/PluginContainerQt.cpp:
- (PluginContainerQt::adjustGeometry):
- * manual-tests/qt/plugin-sibling-frame-include.html
- * manual-tests/qt/plugin-sibling-frame.html
-
-2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Do not call the parent implementation (Widget::) in show() and hide()
- of the PluginViewQt, as it always changes the visible state of the
- platformWidget (equal to the platformPluginWidget in the Qt port),
- thus ignoring the isParentVisible() test.
-
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
-
-2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=23452
- Change the implementation of HTMLNoScriptElement to avoid the pain of
- adding virtual function for XHTMLMP support
-
- Includes changes suggested by Simon Fraser.
-
- * dom/Node.cpp:
- (WebCore::Node::styleForRenderer):
- * dom/Node.h:
- * html/HTMLNoScriptElement.cpp:
- * html/HTMLNoScriptElement.h:
-
-2009-05-20 Kevin Ollivier <kevino@theolliviers.com>
-
- CURL backend build fix. Make sure URL is always set.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::downloadTimerCallback):
-
-2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
-
- Reviewed by George Staikos.
-
- Fix Qt WebKit build break in Mac OS.
-
- * platform/FileSystem.h:
-
-2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Rubber-stamped by Eric Seidel.
-
- Enable code that was commented out waiting for a way to get a
- GdkPixbuf from an image, effectively enabling copying images to
- the clipboard.
-
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::writeImage):
-
-2009-05-20 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=25414
- [GTK] ROLE_PANEL should not be used for paragraphs and list items.
-
- Implement Atk list item role for list items.
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- (webkit_accessible_get_role):
-
-2009-05-20 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=25414
- [GTK] ROLE_PANEL should not be used for paragraphs and list items.
-
- Implement Atk paragraph role for paragraph elements.
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- (webkit_accessible_get_role):
-
-2009-05-20 Eric Seidel <eric@webkit.org>
-
- Fix bug URL in ChangeLogs in r43903.
- https://bugs.webkit.org/show_bug.cgi?id=25742
-
-2009-05-20 Takeshi Yoshino <tyoshino@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
- https://bugs.webkit.org/show_bug.cgi?id=25742
-
- Fix RenderThemeChromiumWin::paintTextFieldInternal().
-
- We shouldn't paint the content area of text fields when o->style() has
- background image or transparent background color. paintTextFieldInternal() is
- used for painting inner area of HTML option elements by Chromium.
-
- When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
- the background image rendered by RenderBoxModelObject. So, we should set
- fillContentArea = false in such case.
-
- Besides, when background-color:transparent is specified for CSS property,
- o->style().backgroundColor returns black color with alpha channel == 0. But
- since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
- recognize alpha channel, it fills the rect with black. I made workaround to set
- fillContentArea = false when alpha channel == 0 to avoid this.
-
- And more, I'd like to fallback the color passed to ChromiumBridge to white when
- o->style()->backgroundColor() is invalid.
-
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
-
-2009-05-20 Shinichiro Hamaji <hamaji@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25417
- Map CompositeCopy to Skia's kSrc_Mode composite operation.
-
- Test: fast/canvas/canvas-composite-alpha.html
-
- * platform/graphics/skia/SkiaUtils.cpp:
- (WebCore::):
-
-2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Rubber-stamped by Xan Lopez.
-
- Remove misplaced extern "C"
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [GTK] Expose password field with role of PASSWORD_TEXT
- https://bugs.webkit.org/show_bug.cgi?id=25682
-
- Check if input type is a password field and return
- ATK_ROLE_PASSWORD_TEXT if it is.
-
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
- <https://bugs.webkit.org/show_bug.cgi?id=25845>
-
- * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
-
-2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- BUG 25843: [Qt] Remove qt-port build flag
- <https://bugs.webkit.org/show_bug.cgi?id=25843>
-
- * bridge/testbindings.pro:
-
-2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=25824
-
- [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
- and WORKERS under the appropriate build section
-
- * WebCore.pro:
-
-2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Unreviewed Qt build fix, after r43892.
-
- * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
-
-2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=25856
- [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
-
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::Image::drawPattern):
- (WebCore::BitmapImage::draw):
-
-2009-05-20 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY, layout tests fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=23727
- This reverts commit r43888.
-
- Once that change was checked in many of the fast/flexbox0*.html
- tests (and others) started failing.
-
- * WebCore.pro:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSPropertyNames.in:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSValueKeywords.in:
- * rendering/RenderMarquee.cpp:
- (WebCore::RenderMarquee::updateMarqueePosition):
- (WebCore::RenderMarquee::timerFired):
-
-2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by George Staikos.
-
- Add XHTMLMP support to Webkit
- Update the configure files for building XHTMLMP-enabled WebKit on different platform
- https://bugs.webkit.org/show_bug.cgi?id=23452
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
-
-2009-05-19 Antti Koivisto <antti@apple.com>
-
- I can't figure out how to make this not timing dependent, making it manual test instead.
-
- * manual-tests/preload-scanner-entities.html: Added.
-
-2009-05-19 Brady Eidson <beidson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
-
- This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
- in QuickLooks (rdar://problem/6619630).
-
- We need to respect the DocumentLoader's request cache policy when deciding the cache policy
- for subresources, but the check (originally removed in r39304 and added back in in the same
- place in r41424) needs to be tweaked and relocated a bit.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking
- the DocumentLoader's request to a more appropriate place. Add code to handle the recently
- added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
- cleaner in the future.
- * loader/FrameLoader.h:
-
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
-
-2009-05-19 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
- https://bugs.webkit.org/show_bug.cgi?id=25872
-
- When setting the aria-labeledby text it should stay within the element identified by the id
- when searching through the sibling list.
-
- This also removes an outdated assert in getDocumentLinks. Its possible for the document to
- think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
-
- Test: accessibility/aria-labelledby-stay-within.html
-
- * accessibility/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
- (WebCore::AccessibilityRenderObject::getDocumentLinks):
-
-2009-05-19 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler).
-
- <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
-
- Push characters back in correct order when entity parsing fails after 3 characters.
-
- Test: fast/tokenizer/preload-scanner-entities.html
-
- * html/PreloadScanner.cpp:
- (WebCore::PreloadScanner::consumeEntity):
-
-2009-05-19 Paul Godavari <paul@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Fix a crash in Mac Chromium when displaying an HTML select element
- with no items.
- https://bugs.webkit.org/show_bug.cgi?id=25874
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupContainer::showExternal):
-
-2009-05-19 Nate Chapin <japhet@google.com>
-
- Reviewed by Darin Fisher.
-
- Upstream V8 bindings for CanvasRenderingContext2D.
- https://bugs.webkit.org/show_bug.cgi?id=25858
-
- * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
-
-2009-05-19 Jessie Berlin <jberlin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Windows Build Fix.
-
- * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
-
-2009-05-19 Timothy Hatcher <timothy@apple.com>
-
- <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
- loaded because willSendRequest doesn't happen immediately
-
- Reviewed by Antti Koivisto.
-
- * WebCore.base.exp: Export Loader::servePendingRequests().
-
-2009-05-19 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Bug 25859: Need to upstream ScriptController.* for v8.
- https://bugs.webkit.org/show_bug.cgi?id=25859
-
- Fixing the header file (which I accidentally made identical to the cpp file).
-
- * bindings/v8/ScriptController.h:
-
-2009-05-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler and Brady Eidson.
-
- <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
-
- The problem was that Document::removeAllEventListeners() was called for a wrong document
- when a CachedFrame was destroyed.
-
- Cannot be tested automatically, because DRT doesn't have a b/f cache.
-
- * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
- unrelated window even if document's m_frame pointer is stale.
-
- * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
-
-2009-05-19 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
-
- https://bugs.webkit.org/show_bug.cgi?id=25419
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::addToConsole):
- * inspector/ConsoleMessage.h:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::~InspectorController):
- (WebCore::InspectorController::inspect):
- (WebCore::InspectorController::focusNode):
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::addConsoleMessage):
- (WebCore::InspectorController::setAttachedWindow):
- (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
- (WebCore::InspectorController::scriptObjectReady):
- (WebCore::InspectorController::showPanel):
- (WebCore::InspectorController::close):
- (WebCore::InspectorController::populateScriptObjects):
- (WebCore::InspectorController::resetScriptObjects):
- (WebCore::InspectorController::pruneResources):
- (WebCore::InspectorController::didCommitLoad):
- (WebCore::InspectorController::didLoadResourceFromMemoryCache):
- (WebCore::InspectorController::identifierForInitialRequest):
- (WebCore::InspectorController::willSendRequest):
- (WebCore::InspectorController::didReceiveResponse):
- (WebCore::InspectorController::didReceiveContentLength):
- (WebCore::InspectorController::didFinishLoading):
- (WebCore::InspectorController::didFailLoading):
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- (WebCore::InspectorController::scriptImported):
- (WebCore::InspectorController::didOpenDatabase):
- (WebCore::InspectorController::didUseDOMStorage):
- (WebCore::InspectorController::addScriptProfile):
- (WebCore::InspectorController::toggleRecordButton):
- (WebCore::InspectorController::enableProfiler):
- (WebCore::InspectorController::disableProfiler):
- (WebCore::InspectorController::enableDebugger):
- (WebCore::InspectorController::disableDebugger):
- (WebCore::InspectorController::didParseSource):
- (WebCore::InspectorController::failedToParseSource):
- (WebCore::InspectorController::didPause):
- (WebCore::InspectorController::didContinue):
- * inspector/InspectorController.h:
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::bind):
- * inspector/InspectorDOMStorageResource.h:
- * inspector/InspectorDatabaseResource.cpp:
- (WebCore::InspectorDatabaseResource::bind):
- * inspector/InspectorDatabaseResource.h:
- * inspector/InspectorFrontend.cpp: Added.
- (WebCore::callSimpleFunction):
- (WebCore::InspectorFrontend::InspectorFrontend):
- (WebCore::InspectorFrontend::~InspectorFrontend):
- (WebCore::InspectorFrontend::newJSONObject):
- (WebCore::InspectorFrontend::addMessageToConsole):
- (WebCore::InspectorFrontend::addResource):
- (WebCore::InspectorFrontend::updateResource):
- (WebCore::InspectorFrontend::removeResource):
- (WebCore::InspectorFrontend::updateFocusedNode):
- (WebCore::InspectorFrontend::setAttachedWindow):
- (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
- (WebCore::InspectorFrontend::showPanel):
- (WebCore::InspectorFrontend::populateInterface):
- (WebCore::InspectorFrontend::reset):
- (WebCore::InspectorFrontend::debuggerWasEnabled):
- (WebCore::InspectorFrontend::debuggerWasDisabled):
- (WebCore::InspectorFrontend::profilerWasEnabled):
- (WebCore::InspectorFrontend::profilerWasDisabled):
- (WebCore::InspectorFrontend::parsedScriptSource):
- (WebCore::InspectorFrontend::failedToParseScriptSource):
- (WebCore::InspectorFrontend::addProfile):
- (WebCore::InspectorFrontend::setRecordingProfile):
- (WebCore::InspectorFrontend::pausedScript):
- (WebCore::InspectorFrontend::resumedScript):
- (WebCore::InspectorFrontend::addDatabase):
- (WebCore::InspectorFrontend::addDOMStorage):
- * inspector/InspectorFrontend.h: Added.
- * inspector/InspectorResource.cpp:
- (WebCore::InspectorResource::createScriptObject):
- (WebCore::InspectorResource::updateScriptObject):
- (WebCore::InspectorResource::releaseScriptObject):
- * inspector/InspectorResource.h:
-
-2009-05-19 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
-
- https://bugs.webkit.org/show_bug.cgi?id=25419
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::addToConsole):
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::bind):
- * inspector/InspectorDatabaseResource.cpp:
- (WebCore::InspectorDatabaseResource::bind):
- * inspector/InspectorResource.cpp:
- (WebCore::populateHeadersObject):
- (WebCore::InspectorResource::createScriptObject):
- (WebCore::InspectorResource::updateScriptObject):
- * inspector/JSONObject.cpp: Added.
- (WebCore::JSONObject::JSONObject):
- (WebCore::JSONObject::set):
- (WebCore::JSONObject::scriptObject):
- (WebCore::JSONObject::createNew):
- * inspector/JSONObject.h: Added.
-
-2009-05-19 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
-
- https://bugs.webkit.org/show_bug.cgi?id=25419
-
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::addToConsole):
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::didReceiveResponse):
- (WebCore::InspectorController::didReceiveContentLength):
- (WebCore::InspectorController::didFinishLoading):
- (WebCore::InspectorController::didFailLoading):
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- (WebCore::InspectorController::scriptImported):
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
- (WebCore::InspectorDOMStorageResource::bind):
- (WebCore::InspectorDOMStorageResource::unbind):
- * inspector/InspectorDOMStorageResource.h:
- * inspector/InspectorDatabaseResource.cpp:
- (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
- (WebCore::InspectorDatabaseResource::bind):
- (WebCore::InspectorDatabaseResource::unbind):
- * inspector/InspectorDatabaseResource.h:
- * inspector/InspectorResource.cpp:
- (WebCore::InspectorResource::InspectorResource):
- (WebCore::populateHeadersObject):
- (WebCore::InspectorResource::createScriptObject):
- (WebCore::InspectorResource::updateScriptObject):
- (WebCore::InspectorResource::releaseScriptObject):
- * inspector/InspectorResource.h:
- * inspector/front-end/Console.js:
- (WebInspector.ConsoleMessage):
- * inspector/front-end/inspector.js:
- (WebInspector.addResource):
- (WebInspector.updateResource):
- (WebInspector.removeResource):
- (WebInspector.addDatabase):
- (WebInspector.addDOMStorage):
- (WebInspector.reset):
- (WebInspector.addMessageToConsole):
-
-2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Ariya Hidayat.
-
- The Qt port has code that disables scrolling optimizations
- when the root contains native windows, such as windowed plugins.
-
- This code broke when detaching iframes containing windowed
- plugins.
-
- Each ScrollView now knows how many native windows it and its
- children contain, and when it is detached, that number is
- substracted from its old parents.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents):
- (WebCore::ScrollView::setParent):
- * platform/ScrollView.h:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
- (WebCore::ScrollView::platformAddChild):
- (WebCore::ScrollView::platformRemoveChild):
-
-2009-05-18 David Kilzer <ddkilzer@apple.com>
-
- Tiger build fix for r43850
-
- * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
- when building on Tiger.
-
-2009-05-18 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- ClipboardMac cleanup
- https://bugs.webkit.org/show_bug.cgi?id=25847
-
- I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
-
- No functional changes, so no tests.
-
- * platform/mac/ClipboardMac.mm:
- (WebCore::ClipboardMac::clearData):
- (WebCore::absoluteURLsFromPasteboardFilenames):
- Broke out logic for filenames into its own function to make the caller more readable.
- (WebCore::absoluteURLsFromPasteboard):
- Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
- so that we can use -[NSArray componentsJoinedByString] in the caller (which is
- cleaner than the manual "\n" addition before).
- This also access to the full list of file urls for future callers.
- (WebCore::ClipboardMac::getData):
- unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
- explicit check for "URL", before it was a check for != "text/uri-list" which
- was much more confusing in my opinion. text/uri-list and URL are the only
- two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
- (WebCore::ClipboardMac::types):
- I removed an extra if (!types) check, right before [types count]. In Obj-C
- messaging nil will return 0 (size of a pointer), so it's safe to message nil
- here and expect it to return 0.
-
-2009-05-18 David Levin <levin@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Bug 25859: Need to upstream ScriptController.* for v8.
- https://bugs.webkit.org/show_bug.cgi?id=25859
-
- * bindings/v8/ScriptController.cpp: Added.
- * bindings/v8/ScriptController.h: Added.
-
-2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by George Staikos.
-
- Change ScriptElement to support XHTMLMP in a better way
- https://bugs.webkit.org/show_bug.cgi?id=23452
-
- * dom/ScriptElement.h:
- * html/HTMLScriptElement.h:
- * svg/SVGScriptElement.h:
- (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
-
-2009-05-18 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix, finish up changes after the accessibility dir split.
-
- * webcore-base.bkl:
-
-2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by George Staikos (and others).
-
- Add XHTMLMP support to Webkit
- https://bugs.webkit.org/show_bug.cgi?id=23452
- XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
- functionality. Most of the functionalities have already been implemented by Webkit.
-
- The changes include:
- 1) Adding <noscript> support
- 2) Document conformance validation
- 3) User Agent conformance validation
-
- refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
-
- Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
- fast/xhtmlmp/check-rootelement.xhtml
- fast/xhtmlmp/noscript-in-multiscripts.xhtml
- fast/xhtmlmp/noscript-nested.xhtml
- fast/xhtmlmp/noscript.xhtml
-
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::isXHTMLMPDocument):
- * dom/Document.h:
- (WebCore::Document::shouldProcessNoscriptElement):
- (WebCore::Document::setShouldProcessNoscriptElement):
- * dom/Node.cpp:
- (WebCore::Node::createRendererIfNeeded):
- * dom/Node.h:
- * dom/XMLTokenizer.h:
- (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
- (WebCore::XMLTokenizer::isXHTMLMPDocument):
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::XMLTokenizer):
- (WebCore::XMLTokenizer::startElementNs):
- (WebCore::XMLTokenizer::endElementNs):
- (WebCore::XMLTokenizer::endDocument):
- (WebCore::XMLTokenizer::internalSubset):
- (WebCore::getEntityHandler):
- (WebCore::externalSubsetHandler):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::XMLTokenizer):
- (WebCore::XMLTokenizer::parse):
- (WebCore::XMLTokenizer::parseStartElement):
- (WebCore::XMLTokenizer::parseEndElement):
- (WebCore::):
- * dom/make_names.pl:
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::rendererIsNeeded):
- * html/HTMLNoScriptElement.cpp: Added.
- (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
- (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
- (WebCore::HTMLNoScriptElement::checkDTD):
- (WebCore::HTMLNoScriptElement::attach):
- (WebCore::HTMLNoScriptElement::recalcStyle):
- (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
- (WebCore::HTMLNoScriptElement::styleForRenderer):
- * html/HTMLNoScriptElement.h: Added.
- (WebCore::HTMLNoScriptElement::rendererIsNeeded):
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::getNode):
- (WebCore::HTMLParser::isInline):
- * html/HTMLTagNames.in:
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::scriptHandler):
- (WebCore::HTMLTokenizer::notifyFinished):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::addExtraFieldsToRequest):
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedNonImageMimeTypes):
-
-2009-05-18 Mark Rowe <mrowe@apple.com>
-
- Fix the build.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Rubber-stamped by Gustavo Noronha.
-
- Fixed build for the Qt port by adding the WebCore/accessibility
- directory to the includepath.
-
- * WebCore.pro:
-
-2009-05-18 Chris Fleizach <cfleizach@apple.com>
-
- Bug 25776: accessibility should have its own folder in WebCore project
- https://bugs.webkit.org/show_bug.cgi?id=25776
-
- Speculative fix for windows build failure.
-
- * WebCore.vcproj/WebCoreCommon.vsprops:
-
-2009-05-18 David Kilzer <ddkilzer@apple.com>
-
- Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
-
- <https://bugs.webkit.org/show_bug.cgi?id=20652>
-
- Reviewed by Darin Adler.
-
- Test: http/tests/misc/favicon-as-image.html
-
- * inspector/front-end/inspector.js: Added
- image/vnd.microsoft.icon to WebInspector.MIMETypes.
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedImageMIMETypes): Added
- image/vnd.microsoft.icon to list of supported image and image
- resource MIME types.
-
-2009-05-18 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 25776: accessibility should have its own folder in WebCore project
- https://bugs.webkit.org/show_bug.cgi?id=25776
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * accessibility: Added.
- * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
- * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
- * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
- * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
- * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
- * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
- * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
- * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
- * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
- * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
- * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
- * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
- * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
- * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
- * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
- * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
- * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
- * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
- * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
- * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
- * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
- * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
- * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
- * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
- * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
- * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
- * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
- * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
- * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
- * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
- * accessibility/chromium: Added.
- * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
- * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
- * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
- * accessibility/gtk: Added.
- * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
- * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
- * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
- * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
- * accessibility/mac: Added.
- * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
- * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
- * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
- * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
- * accessibility/qt: Added.
- * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
- * accessibility/win: Added.
- * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
- * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
- * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
- * accessibility/wx: Added.
- * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
- * page/AXObjectCache.cpp: Removed.
- * page/AXObjectCache.h: Removed.
- * page/AccessibilityAriaGrid.cpp: Removed.
- * page/AccessibilityAriaGrid.h: Removed.
- * page/AccessibilityAriaGridCell.cpp: Removed.
- * page/AccessibilityAriaGridCell.h: Removed.
- * page/AccessibilityAriaGridRow.cpp: Removed.
- * page/AccessibilityAriaGridRow.h: Removed.
- * page/AccessibilityImageMapLink.cpp: Removed.
- * page/AccessibilityImageMapLink.h: Removed.
- * page/AccessibilityList.cpp: Removed.
- * page/AccessibilityList.h: Removed.
- * page/AccessibilityListBox.cpp: Removed.
- * page/AccessibilityListBox.h: Removed.
- * page/AccessibilityListBoxOption.cpp: Removed.
- * page/AccessibilityListBoxOption.h: Removed.
- * page/AccessibilityObject.cpp: Removed.
- * page/AccessibilityObject.h: Removed.
- * page/AccessibilityRenderObject.cpp: Removed.
- * page/AccessibilityRenderObject.h: Removed.
- * page/AccessibilityTable.cpp: Removed.
- * page/AccessibilityTable.h: Removed.
- * page/AccessibilityTableCell.cpp: Removed.
- * page/AccessibilityTableCell.h: Removed.
- * page/AccessibilityTableColumn.cpp: Removed.
- * page/AccessibilityTableColumn.h: Removed.
- * page/AccessibilityTableHeaderContainer.cpp: Removed.
- * page/AccessibilityTableHeaderContainer.h: Removed.
- * page/AccessibilityTableRow.cpp: Removed.
- * page/AccessibilityTableRow.h: Removed.
- * page/chromium/AXObjectCacheChromium.cpp: Removed.
- * page/chromium/AccessibilityObjectChromium.cpp: Removed.
- * page/chromium/AccessibilityObjectWrapper.h: Removed.
- * page/gtk/AXObjectCacheAtk.cpp: Removed.
- * page/gtk/AccessibilityObjectAtk.cpp: Removed.
- * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
- * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
- * page/mac/AXObjectCacheMac.mm: Removed.
- * page/mac/AccessibilityObjectMac.mm: Removed.
- * page/mac/AccessibilityObjectWrapper.h: Removed.
- * page/mac/AccessibilityObjectWrapper.mm: Removed.
- * page/qt/AccessibilityObjectQt.cpp: Removed.
- * page/win/AXObjectCacheWin.cpp: Removed.
- * page/win/AccessibilityObjectWin.cpp: Removed.
- * page/win/AccessibilityObjectWrapperWin.h: Removed.
- * page/wx/AccessibilityObjectWx.cpp: Removed.
-
-2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=25854
- [GTK] Should tell servers we only support identity as content encoding
-
- Let servers know we only support identity as content
- encoding. We will implement this in libsoup.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startHttp):
-
-2009-05-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
- CAPTCHA failure.
-
- The problem was that after loading and displaying a CAPTCHA image, it was loaded from
- the server again due to preloading. So, the server expected the last loaded (invisible)
- CAPTCHA text to be typed and posted back.
-
- I don't know how to make tests for preloading.
-
- * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
- to preload after loading for real - and if cache policy is CachePolicyReload, that actually
- results in another load from network layer.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
- to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
-
-2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
-
- https://bugs.webkit.org/show_bug.cgi?id=24551
-
- [Qt] Reuse FontPlatformData for the same FontDescription.
- This effectively prevents growing heap usage for loading every web page.
-
- * platform/graphics/qt/FontCacheQt.cpp:
- (WebCore::qHash): Necessary for FontPlatformDataCache.
- (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
- it exists, otherwise create a new one and insert it in the cache.
-
-2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
-
- Reviewed by Ariya Hidayat.
-
- https://bugs.webkit.org/show_bug.cgi?id=24551
-
- [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
- When creating a new instance of SimpleFontData, put it in the font list
- so that it can deleted later on.
-
- * platform/graphics/qt/FontFallbackListQt.cpp:
- (WebCore::FontFallbackList::invalidate):
- (WebCore::FontFallbackList::releaseFontData):
- (WebCore::FontFallbackList::fontDataAt):
-
-2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [Gtk] Various autotools build refactoring and fixes
- https://bugs.webkit.org/show_bug.cgi?id=25286
-
- Style fixes
-
- * GNUmakefile.am:
-
-2009-05-17 George Staikos <george.staikos@torchmobile.com>
-
- Not reviewed - build fix.
-
- Fix typo: constr -> const.
-
- * wml/WMLInputElement.h:
- (WebCore::WMLInputElement::setPlaceholder):
-
-2009-05-17 Darin Adler <darin@apple.com>
-
- Fix done by Simon Fraser (reviewed by me).
-
- <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
- transitions has bad layout and overlapping garbled text when printing
-
- * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
-
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
-
-2009-05-17 Darin Adler <darin@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
- also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
-
- * manual-tests/select-option-in-onload.html: Added.
-
-2009-05-17 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- Rename local variables for readability.
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintBorder):
-
-2009-05-17 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 25840: fix some warnings seen on the GTK bot
- https://bugs.webkit.org/show_bug.cgi?id=25840
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
- This is really just to quiet warnings. I think this code is unreachable.
- Someone could put ASSERT_NOT_REACHED() in here too at some point.
-
- * plugins/PluginStream.cpp:
- (WebCore::PluginStream::startStream): Use proper printf format for int
- here, %d, not %lu. This could cause a real problem when compiled 64-bit,
- so it's good to fix.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
- really just to quiet the warning, but still seems like a good idea.
-
-2009-05-17 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25769: Fix accessibility warnings on GTK
- https://bugs.webkit.org/show_bug.cgi?id=25769
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
- (WebCore::AccessibilityTable::rowCount): Ditto.
- * page/AccessibilityTable.h: Ditto.
-
-2009-05-17 Kai Brüning <kai@granus.net>
-
- Reviewed by Darin Adler.
-
- bug 25822: DOM normalize does not remove empty text node between element nodes
- https://bugs.webkit.org/show_bug.cgi?id=25822
-
- Test: fast/dom/Node/normalize.html
-
- * dom/Node.cpp:
- (WebCore::Node::normalize): Changed to remove any empty text nodes.
-
-2009-05-16 Dave Moore <davemoore@google.com>
-
- Reviewed by Darin Adler.
-
- Allow Strings to be created with one malloc node with no copying
- https://bugs.webkit.org/show_bug.cgi?id=25779
-
- Add new methods to String and StringImpl, refactoring existing
- methods in StringImpl to use new createUninitialized() method.
-
- * platform/text/PlatformString.h:
- (WebCore::String::createUninitialized):
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::createUninitialized):
- (WebCore::StringImpl::create):
- * platform/text/StringImpl.h:
-
-2009-05-16 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
- dramatically improve animated GIF decoding performance
-
- Recent versions of ImageIO discard previously decoded image frames if the client
- application no longer holds references to them, so there's no need to throw away
- the decoder unless we're explicitly asked to destroy all of the frames.
-
- This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
- from over 90% to below 3%.
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::clear):
-
-2009-05-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- - fix <rdar://problem/6873305> Two distinct characters are not displayed
- correctly with 2 of the font selections from the stickies widget
-
- Test: platform/mac/editing/pasteboard/text-precomposed.html
-
- Ensure that "text/plain" data retrieved from the clipboard is always
- precomposed. This makes Clipboard::getData() and
- Pasteboard::documentFragment() consistent with Pasteboard::plainText()
- and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
-
- * platform/mac/ClipboardMac.mm:
- (WebCore::ClipboardMac::getData):
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::documentFragment):
-
-2009-05-16 Mark Rowe <mrowe@apple.com>
-
- Build fix.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::valueForFamily): Declare valueForFamily as static.
-
-2009-05-15 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
- only the generic font, if any generic font is in the family list
-
- Test: fast/css/getComputedStyle/computed-style-font-family.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
- (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
- (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
- property as specified in the CSS standard. Fixed clip to return "auto" when there is no
- clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
- internal linkage since there was no reason for them to have external linkage.
-
-2009-05-15 Adam Barth <abarth@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=25741
-
- Append instead of throwing when insertItemBefore gets an out-of-bound
- index.
-
- Test: svg/dom/svglist-insertItemBefore-appends.html
-
- * svg/SVGList.h:
- (WebCore::SVGList::insertItemBefore):
-
-2009-05-15 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=25829
-
- Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
-
- Test: fast/backgrounds/background-clip-text.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
-
-2009-05-15 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
- arrows, I can't navigate caret between To Do items in a Note message
-
- Test: editing/selection/move-by-line-004.html
-
- * editing/visible_units.cpp:
- (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
- function.
- (WebCore::previousLinePosition): When advancing to the next candidate
- node, stop when leaving the closest ancestor of the original node that
- is not an inline. The code, incorrectly, was trying to exit the closest
- ancestor of that type which was editable, and therefore missing other
- blocks in the same editable root.
- (WebCore::nextLinePosition): Ditto.
-
-2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
-
- Reviewed by Jan Alonzo.
-
- Converting filename to uri by concatenating strings is broken
- on Windows. So, don't do it for that platform.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startGio):
-
-2009-05-15 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
- https://bugs.webkit.org/show_bug.cgi?id=25739
-
- * bindings/v8/V8Collection.cpp: Added.
- (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
- * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
- * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
- * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
- (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp.
- (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
-
-2009-05-15 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
-
- Reviewed by Darin Adler and Timothy Hatcher.
-
- * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
- WebCore.base.exp into the group, and added 10 other *.exp files
- in WebCore.
-
-2009-05-15 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25826
- Change type to only have custom getter in JCS.
-
- * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
-
-2009-05-15 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Kilzer.
-
- Add a settings entry to en/disable web font support
- https://bugs.webkit.org/show_bug.cgi?id=25239
-
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::addFontFaceRule):
-
-2009-05-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Steve Falkenburg.
-
- Remove dead youtube site specific hack that was commented out.
-
- * bindings/js/JSNavigatorCustom.cpp:
- * page/Navigator.idl:
-
-2009-05-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Beth Dakin.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
- <rdar://problem/6884742>
- REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
-
- Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
-
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::needsGmailQuirk):
- (WebCore::JSHTMLInputElement::type):
- * html/HTMLInputElement.idl:
-
-2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25810
- Upstream V8 DOM Wrapper map declarations.
-
- No behavior change, so no tests.
-
- * bindings/v8/V8DOMMap.h:
- (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
- (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
- (WebCore::WeakReferenceMap::get): Added.
- (WebCore::WeakReferenceMap::set): Added.
- (WebCore::WeakReferenceMap::forget): Added.
- (WebCore::WeakReferenceMap::contains): Added.
- (WebCore::WeakReferenceMap::impl): Added.
- (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
-
-2009-05-15 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=25773
-
- Rename GraphicsLayer::graphicsContextsFlipped() to
- GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
-
- Clean up code around the GraphicsLayer "contents" layer that makes use of this
- flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
- which can then always do the flipping if necessary.
-
- Only affects ACCELERATED_COMPOSITING builds.
-
- * platform/graphics/GraphicsLayer.h:
- (WebCore::GraphicsLayer::):
- * platform/graphics/mac/GraphicsLayerCA.h:
- (WebCore::GraphicsLayerCA::contentsLayer):
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
- (WebCore::GraphicsLayerCA::setBackgroundColor):
- (WebCore::GraphicsLayerCA::clearBackgroundColor):
- (WebCore::GraphicsLayerCA::setContentsToImage):
- (WebCore::GraphicsLayerCA::clearContents):
- (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- (WebCore::GraphicsLayerCA::setContentsLayer):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
-
-2009-05-15 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25765
-
- Avoid calling setNeedsStyleRecalc() when we are
- putting an animated page in the cache. This avoids
- the assert and subsequent problems with a dirty
- page going into the cache.
-
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::endAnimation):
-
-2009-05-15 Francisco Tolmasky <francisco@280north.com>
-
- BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
- <https://bugs.webkit.org/show_bug.cgi?id=25467>
-
- Reviewed by Adam Roben.
-
- * inspector/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
- * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
- (WebInspector.CallStackSidebarPane.prototype.update):
-
-2009-05-15 Alexey Proskuryakov <ap@webkit.org>
-
- Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::start):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::start):
- Check strings with isEmpty(), not relying on any implicit conversions.
-
-2009-05-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
-
- <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
- username and password (Lightwave 9.6 for Mac from Newtek site)
-
- CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
- for other protocols (including FTP) should be included as part of the URL.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::start):
- (WebCore::WebCoreSynchronousLoader::load):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::start):
- (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
- Put credentials in URL for non-HTTP requests.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
- Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
- headers to be received, so they cannot work with other protocols.
-
-2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Holger Freyther.
-
- [Qt] In the image decoder, remove the raw image data represented as QImage
- once the image is converted to QPixmap and inserted in the pixmap cache.
- This effectively reduces the heap usage when running on graphics system
- other than raster (i.e the case where QImage != QPixmap).
-
- * platform/graphics/qt/ImageDecoderQt.cpp:
- (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
- * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
-
-2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Holger Freyther.
-
- [Qt] Refactor alpha channel detection the image decoder.
- Sets the boolean flag as soon as the image is being read.
-
- * platform/graphics/qt/ImageDecoderQt.cpp:
- (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
- (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
- (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
- (WebCore::ImageDecoderQt::reset): Resetted the flag.
- * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
-
-2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Darin Adler.
-
- Finish support for disabling the JavaScript Debugger and Profiler
- at compile time in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=24917
-
- * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
- * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
- * inspector/JavaScriptCallFrame.cpp: Ditto.
- * inspector/JavaScriptCallFrame.h: Ditto.
- * inspector/JavaScriptCallFrame.idl: Ditto.
- * inspector/JavaScriptDebugListener.h: Ditto.
- * inspector/JavaScriptDebugServer.cpp: Ditto.
- * inspector/JavaScriptDebugServer.h: Ditto.
- * inspector/JavaScriptProfile.cpp: Ditto.
- * inspector/JavaScriptProfile.h: Ditto.
- * inspector/JavaScriptProfileNode.cpp: Ditto.
- * inspector/JavaScriptProfileNode.h: Ditto.
- * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
- * page/Console.h: Ditto.
- * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
-
-2009-05-15 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Dimitri Glazkov
-
- http://bugs.webkit.org/show_bug.cgi?id=25464
-
- Improve the font fallback for characters belonging to 'common' scripts
- in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
- marks in North Indian scripts) and currency signs (e.g. Thai Baht)
- rendered correctly in Chromium on Win.
-
- Tests: fast/text/international/danda-space.html
- fast/text/international/thai-baht-space.html
-
- * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
- (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
- (WebCore::FontMap::getScript):
- (WebCore::getFallbackFamily):
-
-2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=25731
- [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
- appropriate build section
-
- * WebCore.pro:
-
-2009-05-14 Evan Martin <evan@chromium.org>
-
- Reviewed by Eric Seidel and Darin Fisher.
-
- Fix a font-related leak in Chromium's Skia backend found by Valgrind.
- https://bugs.webkit.org/show_bug.cgi?id=25760
-
- * platform/graphics/chromium/FontCacheLinux.cpp:
- (WebCore::FontCache::getFontDataForCharacters):
- Use caches instead of "new" on every call.
-
-2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Initialize m_spreadMethod in the second constructor too. Not sure if
- a test case can be written, so no test case.
- https://bugs.webkit.org/show_bug.cgi?id=25814
-
- No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
- this case, since several other SVG tests already should be calling
- spreadMethod().
-
- * platform/graphics/Gradient.cpp:
- (WebCore::Gradient::Gradient):
-
-2009-05-14 Simon Fraser <simon.fraser@apple.com>
-
- No review.
-
- Fix Windows build after renaming MediaControlElements to MediaControlElementType.
-
- * rendering/RenderMediaControls.cpp:
- (WebCore::RenderMediaControls::paintMediaControlsPart):
- * rendering/RenderMediaControls.h:
-
-2009-05-14 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6739671> Movie controller’s play button does not change into a pause
- button
-
- Fix a controls repaint issue when the playing state of a video changes by
- educating the MediaControlInputElements about the state they are currently
- displaying, and making them repaint when that state changes. This applies
- to the play/pause and mute/unmute buttons, which both have two states.
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlInputElement::MediaControlInputElement):
- (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
- (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
- (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
- Pass in and initialize the MediaControlElementType.
-
- (WebCore::MediaControlInputElement::update):
- Update the display type too
-
- (WebCore::MediaControlInputElement::setDisplayType):
- (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
- (WebCore::MediaControlMuteButtonElement::updateDisplayType):
- Choose muted vs. unmuted display.
-
- (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
- (WebCore::MediaControlPlayButtonElement::updateDisplayType):
- Choose play vs. paused display.
-
- * rendering/MediaControlElements.h:
- Renamed the MediaControlElements enum to MediaControlElementType.
- (WebCore::MediaControlInputElement::updateDisplayType):
- Add a MediaControlElementType member variable with a setter to allow
- the element to know what type it is displaying.
-
-2009-05-14 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25197
-
- Add support for aspect-ratio and orientation
- media queries.
-
- Tests: fast/media/mq-aspect-ratio.html
- fast/media/mq-orientation.html
-
- * css/MediaFeatureNames.h:
- * css/MediaQueryEvaluator.cpp:
- (WebCore::orientationMediaFeatureEval):
- (WebCore::aspect_ratioMediaFeatureEval):
- (WebCore::min_aspect_ratioMediaFeatureEval):
- (WebCore::max_aspect_ratioMediaFeatureEval):
- * css/MediaQueryExp.h:
- (WebCore::MediaQueryExp::isViewportDependent):
-
-2009-05-14 Kevin McCullough <kmccullough@apple.com>
-
- - Resubmitting previous patch, correctly this time.
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::splitTreeToNode):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::outdentParagraph):
-
-2009-05-14 Kevin McCullough <kmccullough@apple.com>
-
- - Rolling out to fix a bug and the build
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::splitTreeToNode):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::outdentParagraph):
-
-2009-05-14 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6510362> In some situations message content is messed up
- when indentation is decreased
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
- here served to do nothing because this function will return if the
- second argument is the parent of the first. Not only does this now work
- as intended, but is necessary for the rest of this fix.
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we
- are the last node in a <blockquote>, and can therefore remove the
- <blockquote> we need the endOfEnclosingBlock to extend to the end of
- the <blockquote> not just the next block, which could be a <div>, for
- example.
- - Also If a <blockquote> is removed, but it's the child of another
- <blockquote> then its children are now children of the top <blockquote>.
- In this case we want to split the parent <blockquote> because the next
- paragraph assumes that it is the first node in its <blockquote> and if
- that is not true, various bugs arise.
-
-2009-05-14 Brady Eidson <beidson@apple.com>
-
- Build fix.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::setDefaultMIMEType):
-
-2009-05-14 Brady Eidson <beidson@apple.com>
-
- Reviewed by Adam Roben.
-
- Fix http/tests/xmlhttprequest/cache-override.html on Windows
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
- (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
- (WebCore::WebCoreSynchronousLoader::load): Ditto.
-
-2009-05-14 Paul Godavari <paul@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Bug: Mac Chromium popup menus are not positioned correctly
- on scrolled pages:
- https://bugs.webkit.org/show_bug.cgi?id=25772
-
- Fix Mac Chromium popup menu placement by taking into
- account any scrolling in the current window. This mirrors
- the positioning done in PopupContainer::show(), which is
- used on Chromium Windows and linux.
-
- Also fixed indenting for this method.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupContainer::showExternal):
-
-2009-05-14 Drew Wilson <atwilson@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25774
- Upstream V8MessagePortCustom.cpp from the chromium repository.
-
- * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
- (WebCore::ACCESSOR_GETTER):
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-14 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=25777
-
- StyleGeneratedImage::imageSize() needs to take zooming into account for
- fixed-size images (i.e. canvas) so that canvas-as-image-background
- renders correctly with zooming.
-
- Test: fast/canvas/canvas-bg-zoom.html
-
- * rendering/style/StyleGeneratedImage.cpp:
- (WebCore::StyleGeneratedImage::imageSize):
-
-2009-05-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Patch originally by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25796
- <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
-
- Test: http/tests/security/credentials-in-referer.html
-
- * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
- SubresourceLoader::create() anyway.
-
-2009-05-14 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25797: Pages with image maps are not properly read with Voiceover
- https://bugs.webkit.org/show_bug.cgi?id=25797
-
- * page/AccessibilityImageMapLink.h:
- (WebCore::AccessibilityImageMapLink::isEnabled):
-
-2009-05-14 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
-
- Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::shouldContentSniff):
- * platform/network/ResourceHandle.h:
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::createCFURLResponseWithDefaultMIMEType):
- (WebCore::didReceiveResponse):
-
-2009-05-14 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25791
- Bug 25791: HTMLMediaElement: implement 'startTime' attribute
-
- Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
- value that only the media engine can know, so we just need to add the attribute
- to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
- the engine can make it available.
-
- Test: media/media-startTime.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::startTime): New.
- * html/HTMLMediaElement.h:
- * html/HTMLMediaElement.idl:
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::startTime): New.
- * platform/graphics/MediaPlayer.h:
-
- * platform/graphics/MediaPlayerPrivate.h:
- (WebCore::MediaPlayerPrivateInterface::startTime): New.
-
-2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Ariya Hidayat.
-
- Only create a QWidget wrapper for the plugin in the case it is not
- in the Qt window mapper, and thus receiving events from the Qt
- event system. Native Qt based plugins running in process, will
- already be in the window mapper, and thus creating a wrapper,
- stops them from getting events from Qt, as they are redirected
- to the wrapper.
-
- * plugins/qt/PluginContainerQt.cpp:
- (PluginContainerQt::on_clientIsEmbedded):
-
-2009-05-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25784
- Leaks seen on HTTP tests
-
- We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
- disabling content sniffing, matching the normal code path.
- (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
- and m_pass before overwriting.
- (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
-
-2009-05-14 Yury Semikhatsky <yurys@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25418
- Remove new lines from event handler wrapper to make line numbers
- in the wrapped script conside with the lines in the original script.
-
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::getListenerFunction):
- (WebCore::V8LazyEventListener::getWrappedListenerFunction):
-
-2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove a JSC-specific include that is already added by including
- ScriptController.
-
- No change in behavior, so no tests.
-
- * dom/Document.cpp: Removed JSDOMBinding include.
-
-2009-05-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Brady Eidson.
-
- <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
-
- Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
- CFString function was used, so a user-friendly name was stored in encoding fallback array.
-
- * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
- * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
-
-2009-05-14 Ben Murdoch <benm@google.com>
-
- Reviewed by Darin Adler.
-
- Add more ENABLE_DATABASE guards.
- https://bugs.webkit.org/show_bug.cgi?id=25616
-
- See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
-
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
- * bindings/v8/custom/V8CustomSQLStatementCallback.h:
- * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
- * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
- * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
- * bindings/v8/custom/V8DatabaseCustom.cpp:
- * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- * bindings/v8/custom/V8SQLTransactionCustom.cpp:
- * storage/Database.cpp:
- * storage/DatabaseDetails.h:
- * storage/OriginUsageRecord.cpp:
- * storage/OriginUsageRecord.h:
- * storage/SQLError.h:
- * storage/SQLError.idl:
- * storage/SQLResultSet.cpp:
- * storage/SQLResultSet.h:
- * storage/SQLResultSet.idl:
- * storage/SQLResultSetRowList.cpp:
- * storage/SQLResultSetRowList.h:
- * storage/SQLResultSetRowList.idl:
- * storage/SQLStatementCallback.h:
- * storage/SQLStatementErrorCallback.h:
- * storage/SQLTransactionCallback.h:
- * storage/SQLTransactionErrorCallback.h:
-
-2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25787
-
- Gtk was the last platform to not unregister plugins when
- the plugin is stopped. Catch up with r43550.
-
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::stop):
-
-2009-05-14 Adam Roben <aroben@apple.com>
-
- Make WebCore.vcproj's pre-build event work again
-
- * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
- pre-build event that was accidentally left in when the pre-build event
- was moved to WebCoreCommon.vsprops.
-
-2009-05-14 Darin Adler <darin@apple.com>
-
- * manual-tests/right-click-crash.html: Added.
-
-2009-05-14 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Darin Adler.
-
- <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
-
- The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
- Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
- if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
-
- * Configurations/Base.xcconfig:
-
-2009-05-13 Anders Carlsson <andersca@apple.com>
-
- Fix build.
-
- * WebCore.NPAPI.exp:
-
-2009-05-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix invalid memory write seen in HTMLCanvasElement by Valgrind
- https://bugs.webkit.org/show_bug.cgi?id=25759
-
- I can't think of any way to catch this with a layout test, so no test.
-
- * css/CSSCanvasValue.cpp:
- (WebCore::CSSCanvasValue::canvasDestroyed):
- * css/CSSCanvasValue.h:
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
- * html/HTMLCanvasElement.h:
-
-2009-05-13 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - fix <rdar://problem/5483015> Replies in Mail are drawn first without
- the user style sheet and then redrawn with the style sheet
-
- Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
-
- * page/mac/FrameMac.mm:
- (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
- base64-encoded UTF-8 data, just decode the style sheet here an apply
- it synchronously instead of invoking an asynchronous loader.
-
-2009-05-13 Chris Fleizach <cfleizach@apple.com>
-
- Bug 25755: Implement ARIA grid role
- https://bugs.webkit.org/show_bug.cgi?id=25755
-
- Fix build bustage from last checkin.
-
- * page/AccessibilityAriaGrid.cpp:
- (WebCore::AccessibilityAriaGrid::addChild):
-
-2009-05-13 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25755: Implement ARIA grid role
- https://bugs.webkit.org/show_bug.cgi?id=25755
-
- Test: accessibility/aria-tables.html
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * page/AXObjectCache.cpp:
- (WebCore::AXObjectCache::nodeIsAriaType):
- (WebCore::AXObjectCache::getOrCreate):
- * page/AXObjectCache.h:
- * page/AccessibilityAriaGrid.cpp: Added.
- (WebCore::AccessibilityAriaGrid::AccessibilityAriaGrid):
- (WebCore::AccessibilityAriaGrid::~AccessibilityAriaGrid):
- (WebCore::AccessibilityAriaGrid::create):
- (WebCore::AccessibilityAriaGrid::addChild):
- (WebCore::AccessibilityAriaGrid::addChildren):
- (WebCore::AccessibilityAriaGrid::cellForColumnAndRow):
- * page/AccessibilityAriaGrid.h: Added.
- (WebCore::AccessibilityAriaGrid::isAriaTable):
- * page/AccessibilityAriaGridCell.cpp: Added.
- (WebCore::AccessibilityAriaGridCell::AccessibilityAriaGridCell):
- (WebCore::AccessibilityAriaGridCell::~AccessibilityAriaGridCell):
- (WebCore::AccessibilityAriaGridCell::create):
- (WebCore::AccessibilityAriaGridCell::parentTable):
- (WebCore::AccessibilityAriaGridCell::rowIndexRange):
- (WebCore::AccessibilityAriaGridCell::columnIndexRange):
- * page/AccessibilityAriaGridCell.h: Added.
- * page/AccessibilityAriaGridRow.cpp: Added.
- (WebCore::AccessibilityAriaGridRow::AccessibilityAriaGridRow):
- (WebCore::AccessibilityAriaGridRow::~AccessibilityAriaGridRow):
- (WebCore::AccessibilityAriaGridRow::create):
- (WebCore::AccessibilityAriaGridRow::parentTable):
- (WebCore::AccessibilityAriaGridRow::headerObject):
- * page/AccessibilityAriaGridRow.h: Added.
- * page/AccessibilityList.cpp:
- (WebCore::AccessibilityList::accessibilityIsIgnored):
- * page/AccessibilityList.h:
- * page/AccessibilityObject.h:
- (WebCore::):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::RoleEntry::):
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::AccessibilityTable):
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- * page/AccessibilityTable.h:
- (WebCore::AccessibilityTable::isAriaTable):
- * page/AccessibilityTableCell.cpp:
- (WebCore::AccessibilityTableCell::parentTable):
- (WebCore::AccessibilityTableCell::isTableCell):
- (WebCore::AccessibilityTableCell::titleUIElement):
- * page/AccessibilityTableCell.h:
- * page/AccessibilityTableColumn.cpp:
- (WebCore::AccessibilityTableColumn::setParentTable):
- (WebCore::AccessibilityTableColumn::headerObject):
- * page/AccessibilityTableRow.cpp:
- (WebCore::AccessibilityTableRow::isTableRow):
- (WebCore::AccessibilityTableRow::parentTable):
- * page/AccessibilityTableRow.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (RoleEntry::):
-
-2009-05-13 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Bug 25763: Need to move v8 custom binding to the custom directory.
- https://bugs.webkit.org/show_bug.cgi?id=25763
-
- No test due to no change in behavior.
-
- * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
-
-2009-05-13 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
- https://bugs.webkit.org/show_bug.cgi?id=25758
-
- * bindings/v8/custom/V8ElementCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
-
-2009-05-13 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- Fix a number of bugs relating to RTL and text-overflow:ellipsis.
- Also refactor the relevant code to make it a little clearer.
-
- This CL fixes 3 fundamental issues:
- - Corrects behavior if the truncated InlineTextBox's directionality is
- different from the overall flow direction - bug 25135.
- - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
- - Full truncation on InlineBoxes in RTL flow - bug 24186
- - Add tests for the above + reorder/cleanup tests for easier
- interpretation of outcome.
-
- The code for placing ellipsis has been refactored to use
- left/right notation rather than a single variable whose meaning
- could differ based on flow directionality.
-
- To support differing inline directionality vs flow directionality,
- different variables are now used in InlineTextBox::placeEllipsisBox to
- track the two.
-
- The drawing mode for underlines in standards mode now correctly handles
- RTL truncation and relevant test where added.
-
- https://bugs.webkit.org/show_bug.cgi?id=24186
- https://bugs.webkit.org/show_bug.cgi?id=25135
- https://bugs.webkit.org/show_bug.cgi?id=24206
-
- Tests: fast/css/text-overflow-ellipsis-bidi.html
- fast/css/text-overflow-ellipsis-strict.html
-
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::placeEllipsisBox):
- * rendering/InlineBox.h:
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::paintTextDecorations):
- (WebCore::InlineFlowBox::placeEllipsisBox):
- * rendering/InlineFlowBox.h:
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::placeEllipsisBox):
- (WebCore::InlineTextBox::paint):
- * rendering/InlineTextBox.h:
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::placeEllipsis):
- (WebCore::RootInlineBox::placeEllipsisBox):
- * rendering/RootInlineBox.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::checkLinesForTextOverflow):
-
-2009-05-13 Dmitry Titov <dimich@chromium.org>
-
- Rubber-stamped by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25746
- Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::matchFunc):
- (WebCore::openFunc):
- (WebCore::createStringParser):
- (WebCore::createMemoryParser):
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open):
- * platform/sql/SQLiteDatabase.cpp:
- (WebCore::SQLiteDatabase::SQLiteDatabase):
- (WebCore::SQLiteDatabase::close):
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::DatabaseThread):
- (WebCore::DatabaseThread::start):
- (WebCore::DatabaseThread::databaseThread):
- * storage/LocalStorageThread.cpp:
- (WebCore::LocalStorageThread::LocalStorageThread):
- (WebCore::LocalStorageThread::start):
- (WebCore::LocalStorageThread::localStorageThread):
- (WebCore::LocalStorageThread::scheduleImport):
- (WebCore::LocalStorageThread::scheduleSync):
- (WebCore::LocalStorageThread::terminate):
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::start):
-
-2009-05-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Beth Dakin.
-
- Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus
+ (WebCore::EmptyContextMenuClient::isSpeaking):
+ implemented this new virtual function to return false
- Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
- (which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
- content.
-
- Added fast/overflow/border-radius-clipping.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::pushContentsClip):
-
-2009-05-13 Darin Adler <darin@apple.com>
-
- Revert the parser arena change. It was a slowdown, not a speedup.
- Better luck next time (I'll break it up into pieces).
-
-2009-05-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Beth Dakin and Darin Adler.
-
- Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
+ * page/ContextMenuClient.h:
+ declared this new pure virtual function
- Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
- to a non-self-painting layer (and vice versa).
-
- Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
- repaint properly on opacity changes, etc.
-
- Added fast/repaint/opacity-change-on-overflow-float.html.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleWillChange):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::styleWillChange):
- (WebCore::RenderBoxModelObject::styleDidChange):
- * rendering/RenderBoxModelObject.h:
-
-2009-05-13 Dimitri Glazkov <dglazkov@chromium.org>
-
- Not reviewed, build fix.
-
- Move an include, needed by Debugger under the corresponding guard.
-
- * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
- guard.
-
-2009-05-13 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
- https://bugs.webkit.org/show_bug.cgi?id=25394
-
- Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html
-
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::create):
- Add another check to subresource loader to avoid doing any loads in frames
- when the loaders are being stopped.
-
-2009-05-13 Stephan Haller <nomad@froevel.de>
-
- Reviewed by Gustavo Noronha.
-
- Wrong handling of file upload if no file selected
- https://bugs.webkit.org/show_bug.cgi?id=25649
-
- Fixed returned path if path is empty
-
- * WebCore/platform/gtk/FileSystemGtk.cpp:
-
-2009-05-13 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white
- when loading
-
- Tests: fast/frames/content-opacity-1.html
- fast/frames/content-opacity-2.html
-
- * page/FrameView.cpp:
- (WebCore::FrameView::reset): Reset m_contentIsOpaque to false.
- (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content
- is not known to be opaque.
- (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque
- and enables or disables fast repaints accordingly.
- * page/FrameView.h:
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the
- document()->haveStylesheetsLoaded() condition in determining whether the
- root is opaque. This is what was causing the bug, as iframes were
- considered to be opaque, and thus painted an opaque white background,
- whenever they were pending a style sheet load.
- Changed to call FrameView::setContentIsOpaqe() instead of
- setUseSlowRepaints(), which allows the frame to go back to fast repaints
- if the content becomes opaque.
- Corrected the check for background color opacity: any alpha value other
- than 255--not just zero--is not opaque.
-
-2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Sam Weinig.
-
- [Qt] Fix "lighther" composition mode.
- QPainter::CompositionMode_Plus is the right match.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::toQtCompositionMode):
-
-2009-05-13 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 25674: syntax tree nodes should use arena allocation
- https://bugs.webkit.org/show_bug.cgi?id=25674
-
- * bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
- We don't want the entire DOM binding to depend on that file.
-
- * bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
- Before we inherited this automatically because JDDOMBinding.h
- included JSFunction.h, but that was excessive.
- * bindings/js/JSDOMWindowCustom.cpp: Ditto.
- * bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
- * bindings/js/JSImageConstructor.cpp: Ditto.
- * bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
- * bindings/js/JSMessageChannelConstructor.cpp: Ditto.
- * bindings/js/JSOptionConstructor.cpp: Ditto.
- * bindings/js/JSWorkerConstructor.cpp: Ditto.
- * bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
- * bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
- * inspector/InspectorController.cpp: Ditto.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
- Moved mose of this function into the base class in JavaScriptCore,
- so the details of compilation don't have to be exposed.
-
-2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6879145>
- Generate a contextual menu item allowing autocorrections to
- easily be changed back. Refrain from re-correcting items
- that have already been autocorrected once.
-
- * dom/DocumentMarker.h:
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- (WebCore::Editor::changeBackToReplacedString):
- * editing/Editor.h:
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::contextMenuItemSelected):
- * page/mac/WebCoreViewFactory.h:
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
+ insert Speech item (after a separator) on Mac when there's selected non-editable text
(WebCore::ContextMenu::checkOrEnableIfNeeded):
- * platform/ContextMenuItem.h:
- * platform/LocalizedStrings.h:
- * platform/mac/LocalizedStringsMac.mm:
- (WebCore::contextMenuItemTagChangeBack):
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::replacedString):
- * rendering/HitTestResult.h:
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::computeRectForReplacementMarker):
- (WebCore::InlineTextBox::paintDocumentMarkers):
- * rendering/InlineTextBox.h:
-
-2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Rubber Stamped by Oliver Hunt.
-
- [GTK] Fix Gtk+/X11 build on OSX
-
- Including the CoreFoundation header here and X11 headers
- later will result in different definitions of Boolean. The
- CoreFoundation include does not seem to be necessary here
- and my mac build was successfull without it. I will remove
- it for now. If the build bots disagree this will be replaced
- by a #if PLATFORM(CF).
-
- * platform/FileSystem.h:
-
-2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Rubber Stamped by Gustavo Noronha.
-
- [GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
-
- When building Gtk+ on OSX we ended up declaring
- setNPWindowIfNeeded twice. Fix that by moving
- the #if PLATFORM(GTK) up and using elif instead of
- else.
-
- * plugins/PluginView.h:
-
-2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- https://bugs.webkit.org/show_bug.cgi?id=25685
- [GTK] Middle click paste form the pasteboard
-
- The kit wants to paste from at least two different
- clipboards. By introducing getCurrentTarget to the
- PasteboardHelper interface we can make this decision
- in the kit.
- Use the new method in PasteboardGtk to get the right
- GdkClipboard for the paste operation.
-
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::documentFragment):
- (WebCore::Pasteboard::plainText):
- * platform/gtk/PasteboardHelper.h:
-
-2009-05-13 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
- <rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
-
- QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
- on Tiger or Leopard.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
- when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
- (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute
- when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
-
-2009-05-12 Roland Steiner <rolandsteiner@google.com>
-
- Reviewed by Eric Seidel.
-
- Bug 25738: Skia: CSS border style not cleared for SVG object
- https://bugs.webkit.org/show_bug.cgi?id=25738
-
- If no dashing is set, this change reverts to solid stroke
- (previously the code bailed and left the old setting, whatever it was)
-
- Test case listed in above bug entry.
- (Additional complications due to each platform rendering dotted lines differently -
- c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::setLineDash):
-
-2009-05-11 Erik Arvidsson <arv@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Bug 21903: Adds DOM bindings for the placeholder property of the
- HTMLInputElement.
- https://bugs.webkit.org/show_bug.cgi?id=21903
-
- Test: fast/forms/placeholder-dom-property.html
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::updatePlaceholderVisibility):
- * dom/InputElement.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::placeholder):
- (WebCore::HTMLInputElement::setPlaceholder):
- * html/HTMLInputElement.h:
- * html/HTMLInputElement.idl:
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- * wml/WMLInputElement.h:
- (WebCore::WMLInputElement::placeholder):
- (WebCore::WMLInputElement::setPlaceholder):
-
-2009-05-12 Adam Barth <abarth@webkit.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25706
-
- Change V8 bindings to match JSC bindings with respect to using
- the lexical or dynamic global object.
-
- Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
-
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-03-19 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
-
- SVGList::insertItemBefore would not perform a bounds check on the
- index it was provided, potentially leading to a buffer overflow.
-
- Test: svg/dom/svglist-exception-on-out-bounds-error.html
-
- * svg/SVGList.h:
- (WebCore::SVGList::insertItemBefore):
-
-2009-05-12 Paul Godavari <paul@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Bug 25708: Cannot choose menu items in popups with many entries in Chromium
- https://bugs.webkit.org/show_bug.cgi?id=25708
-
- This change sets the window size for popups on Mac to include all items
- in the menu. This is required for hit testing on Mac, where we use native
- controls to manage the popups and don't want to artificially limit the
- valid hit testing region to a limited scroll window.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::layout):
-
-2009-05-12 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Fixes to build with latest skia: SkTypeface::Create() is now
- SkTypeface::CreateFromName(); computeBounds() has been reworked
- as getBounds(). The changes are placed behind an #ifdef for now,
- so that we can roll back the skia version in Chromium if necessary
- without having to roll back this change.
-
- https://bugs.webkit.org/show_bug.cgi?id=25705
-
- * platform/graphics/chromium/FontCacheLinux.cpp:
- (WebCore::FontCache::createFontPlatformData):
- * platform/graphics/skia/PathSkia.cpp:
- (WebCore::Path::boundingRect):
- (WebCore::boundingBoxForCurrentStroke):
- * platform/graphics/skia/SkiaUtils.cpp:
- (WebCore::SkPathContainsPoint):
-
-2009-05-12 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25732
- Update V8ElementCustom.cpp to match the current API of V8Proxy.
-
- (WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
-
-2009-05-12 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25694
- HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
- to the document NULL ptr
-
- Test: fast/parser/implicit-head-in-fragment-crash.html
-
- * html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly
- create <head> when parsing a fragment.
-
-2009-05-12 Soren Gjesse <sgjesse@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25687
- Missing check for valid function in V8 bindings for toString function for event listeners.
-
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
-
-2009-05-11 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
- Not doing that can cause assersion failure.
- https://bugs.webkit.org/show_bug.cgi?id=25702
-
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::stop):
-
-2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Bug 25714: [Qt] Decouple HTML5 Database support from the
- SQLite/generic database support in the Qt port
-
- <https://bugs.webkit.org/show_bug.cgi?id=25714>
-
- * WebCore.pro:
-
-2009-05-11 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25713: AX: Control Elements not identified in HTML content
- https://bugs.webkit.org/show_bug.cgi?id=25713
-
- Test: accessibility/onclick-handlers.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
-
-2009-05-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6276843> REGRESSION: TextIterator generates
- an extra newline for ranges that start outside of body
-
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- Check startPos for null, not just currPos.
-
-2009-05-11 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
- https://bugs.webkit.org/show_bug.cgi?id=25700
-
- Keyboard selection movement handlers need to also watch for the Cmd key when Accessibility is enabled.
- Note: This code is only used when accessibility is enabled.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleKeyboardSelectionMovement):
-
-2009-05-11 David Kilzer <ddkilzer@apple.com>
-
- Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
-
- <https://bugs.webkit.org/show_bug.cgi?id=25087>
-
- Reviewed by Timothy Hatcher.
-
- Change tests for ENABLE macros to check for both existence and
- value:
-
- - Negative: #if !defined(ENABLE_FOO) || !ENABLE_FOO
- - Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
-
- * css/CSSCharsetRule.idl:
- * css/CSSPrimitiveValue.idl:
- * css/RGBColor.idl:
- * dom/Attr.idl:
- * dom/DOMCoreException.idl:
- * dom/DOMImplementation.idl:
- * dom/Document.idl:
- * dom/Element.idl:
- * dom/Event.idl:
- * dom/EventException.idl:
- * dom/KeyboardEvent.idl:
- * dom/MessagePort.idl:
- * dom/MouseEvent.idl:
- * dom/Node.idl:
- * dom/ProcessingInstruction.idl:
- * dom/Range.idl:
- * dom/RangeException.idl:
- * dom/WheelEvent.idl:
- * html/CanvasPixelArray.idl:
- * html/HTMLAnchorElement.idl:
- * html/HTMLAppletElement.idl:
- * html/HTMLAreaElement.idl:
- * html/HTMLBaseFontElement.idl:
- * html/HTMLCanvasElement.idl:
- * html/HTMLDocument.idl:
- * html/HTMLElement.idl:
- * html/HTMLEmbedElement.idl:
- * html/HTMLFrameElement.idl:
- * html/HTMLIFrameElement.idl:
- * html/HTMLImageElement.idl:
- * html/HTMLInputElement.idl:
- * html/HTMLLinkElement.idl:
- * html/HTMLObjectElement.idl:
- * html/HTMLOptionElement.idl:
- * html/HTMLOptionsCollection.idl:
- * html/HTMLSelectElement.idl:
- * html/HTMLStyleElement.idl:
- * html/ImageData.idl:
- * inspector/InspectorController.idl:
- * loader/appcache/DOMApplicationCache.idl:
- * page/Console.idl:
- * page/Coordinates.idl:
- * page/DOMSelection.idl:
- * page/DOMWindow.idl:
- * page/Geoposition.idl:
- * page/History.idl:
- * page/Location.idl:
- * page/Navigator.idl:
- * svg/SVGElementInstance.idl:
- * svg/SVGException.idl:
- * workers/WorkerContext.idl:
- * xml/XMLHttpRequestException.idl:
- * xml/XPathException.idl:
-
-2009-05-11 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Darin Adler.
-
- Bug 24538: class/struct mixup in forward declarations
- https://bugs.webkit.org/show_bug.cgi?id=24538
-
- * inspector/InspectorResource.h:
- * loader/CachedFont.h:
- * loader/appcache/ApplicationCache.h:
- * rendering/RenderBlock.h:
- * rendering/RootInlineBox.h:
- * rendering/SVGInlineTextBox.h:
- * svg/SVGGlyphElement.h:
- * svg/SVGHKernElement.h:
-
-2009-05-11 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Darin Adler.
-
- Bug 24539: Unresolved CSSMutableStyleDeclaration
- https://bugs.webkit.org/show_bug.cgi?id=24539
-
- The Symbian tools can't compile and link this without this include.
- It's not clear why this is different from other toolsets or why it affects
- only this header file, but adding the include for now.
-
- * editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
-
-2009-05-11 Alice Liu <alice.liu@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=25701
- REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
-
- Test: fast/forms/search-styled.html
-
- * css/themeWin.css:
- Remove the overriding of -webkit-appearance for searchfields. This will cause background
- images to not be honored when styling searchfields
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::adjustSearchFieldStyle):
- * rendering/RenderThemeWin.h:
- Re-instate final adjustments to searchfield styling that were removed in r42020
-
-2009-05-11 Brady Eidson <beidson@apple.com>
-
- Fix Windows build
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::createCFURLResponseWithDefaultMIMEType):
-
-2009-05-11 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25626
- Update V8ElementCustom.cpp to match the current API of Node.
-
- * bindings/v8/custom/V8ElementCustom.cpp:
- (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
- (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
-
-2009-05-11 Brady Eidson <beidson@apple.com>
-
- Fix Windows build
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::createCFURLResponseWithDefaultMIMEType):
- (WebCore::WebCoreSynchronousLoader::load):
-
-2009-05-11 Brady Eidson <beidson@apple.com>
-
- Fix Windows build
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::createCFURLResponseWithDefaultMIMEType):
-
-2009-05-11 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- V8CustomBinding.cpp is missing a header file
-
- https://bugs.webkit.org/show_bug.cgi?id=25644
-
- * bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
-
-2009-05-11 Aaron Boodman <aa@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25634
- Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().
-
- Also, change instances of ScriptController::retrieveActiveFrame() to
- V8::retrieveFrameForEnteredContext() for consistency.
-
-
- See http://codereview.chromium.org/113085 for the corresponding Chromium change.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetLocation):
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8LocationCustom.cpp:
- (WebCore::navigateIfAllowed):
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-05-11 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.
-
- First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
- Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::defaultMIMEType): "application/octet-stream"
- * platform/MIMETypeRegistry.h:
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which
- might override it to false.
- (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
- * platform/network/ResourceHandle.h:
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead
- of null.
- (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type.
- (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same
- sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the
- same sniffing policy as asynchronous loads.
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if
- it hasn't been set up yet.
- (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by
- the new mechanism.
-
-2009-05-11 David Kilzer <ddkilzer@apple.com>
-
- Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"
-
- This was added in r39816 to disable dynamic entries. They are
- still disabled after fixing the typo since this feature define
- is never set anywhere.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- * loader/appcache/DOMApplicationCache.idl:
-
-2009-05-11 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov and Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25348
- Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
-
- Most of the change is in WTF.
- Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
- method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
- is now a class rather then an integer.
- Also, there is no need to initialize threadID in constructors to 0 now.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
- since now ThreadIdentifier needs construction and we avoid having global initializers.
- (WebCore::matchFunc): use the new accessor function.
- (WebCore::openFunc): ditto.
- (WebCore::createStringParser): ditto.
- (WebCore::createMemoryParser): ditto.
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open):
- * platform/sql/SQLiteDatabase.cpp:
- (WebCore::SQLiteDatabase::SQLiteDatabase):
- (WebCore::SQLiteDatabase::close):
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::start):
- (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
- * storage/LocalStorageThread.cpp:
- (WebCore::LocalStorageThread::start):
- (WebCore::LocalStorageThread::scheduleImport):
- (WebCore::LocalStorageThread::scheduleSync):
- (WebCore::LocalStorageThread::terminate):
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::start):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::start):
-
-2009-05-11 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- Remove unused header that declared one function which was never defined anywhere.
-
- * WebCore.vcproj/WebCore.vcproj:
- * platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means
- platform/network/cf/ResourceResponse.h)
- * platform/network/cf/ResourceResponseCFNet.h: Removed.
-
-2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25213
- Fix assert during Inspector destruction.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::inspectedPageDestroyed): Moved closing
- inspector above removing InspectorController object to fix JS errors,
- added clearing inspector page ptr.
-
-2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Holger Freyther.
-
- [Qt] Make sure that public APIs are properly exported on all Qt platforms
- https://bugs.webkit.org/show_bug.cgi?id=25601
-
- * WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win
-
-2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24284
-
- * WebCore.pro: duplicated values removed from INCLUDEPATH
-
-2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Eric Seidel.
-
- Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
- https://bugs.webkit.org/show_bug.cgi?id=24688
-
- * WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
- * platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
-
-2009-05-10 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix a crash when deactivating a document that had adopted a <form>
- element
-
- Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the
- logic here: <form> elements should be registered for document activation
- callbacks if and only if autocomplete is off.
-
-2009-05-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
- to view protected MobileMe video
-
- Add a temporary workaround.
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when
- starting a request, so we need to store this data for later use.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks.
- (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
-
-2009-05-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
-
- * platform/network/cf/AuthenticationCF.cpp:
- * platform/network/cf/AuthenticationCF.h:
- (WebCore::WebCoreCredentialStorage::set):
- (WebCore::WebCoreCredentialStorage::get):
- * platform/network/cf/ResourceHandleCFNet.cpp:
- Move WebCore credential storage to AuthenticationCF, so that WebKit could use it (macthing
- an earlier Mac change).
-
-2009-05-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
- called at a wrong time.
-
- No test, because we are waiting for a newer version of system frameworks to test the attribute.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequest.idl:
- Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
-
-2009-05-10 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Kilzer.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=25602
- REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
- on ToT
-
- Test: fast/layers/self-painting-outline.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
- if it is a self-painting layer.
-
-2009-05-09 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen and Mark Rowe.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=25666
- Assertion failure in Node::setDocument()
- (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
-
- Test: fast/dom/HTMLFormElement/adopt-assertion.html
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
- this method are required to call the base class implementation. Do it.
- (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
-
-2009-03-29 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Maciej Stachowiak.
-
- WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
- make sure CURL does not create empty ResourceError() objects.
-
- https://bugs.webkit.org/show_bug.cgi?id=24927
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::downloadTimerCallback):
-
-2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
-
- Build fix, adding missing files to make dist.
-
- * GNUmakefile.am:
-
-2009-05-08 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=25656
-
- Reduce the inline capacity of CSSParserValueList's m_values
- vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.
-
- * css/CSSParserValues.h:
-
-2009-05-08 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.
+ enable Stop Speaking item only if the context menu client returns true for isSpeaking()
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-05-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6864786> REGRESSION: Crash below
- ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in
- Bugzilla
-
- Test: editing/style/apply-through-end-of-document.html
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null
- check for the case of a range extending through the end of the document,
- in which pastEndNode is 0.
-
-2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
- marked as misspelled even though contraction is a word
- Make sure spelling underline does not persist on words like
- <doesn't>.
-
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::typingAddedToOpenCommand):
-
-2009-05-08 Kevin Watters <kevinwatters@gmail.com>
+2009-06-28 Dan Bernstein <mitz@apple.com>
- Reviewed by Kevin Ollivier.
-
- Make sure the path's refdata isn't deleted before we're done with the object.
-
- https://bugs.webkit.org/show_bug.cgi?id=25652
-
- * platform/graphics/wx/PathWx.cpp:
- (WebCore::Path::~Path):
- (WebCore::Path::Path):
- (WebCore::Path::translate):
-
-2009-05-08 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Darin Adler.
-
- Fix for memory leak on Mac.
-
- https://bugs.webkit.org/show_bug.cgi?id=25650
-
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
-
-2009-05-08 Beth Dakin <bdakin@apple.com>
+ Reviewed by Simon Fraser.
- Reviewed by Dan Bernstein.
+ - fix https://bugs.webkit.org/show_bug.cgi?id=26783
+ <rdar://problem/7014543> REGRESSION (r45296): Subfolders not displayed
+ in MobileMe iDisk Web App
- <rdar://problem/6857446> REGRESSION (r37591): Cannot print or
- preview from maps.yandex.ru
+ Test: added a case to fast/dom/Element/scrollWidth.html
- We need to fall into the stretchesToViewHeight() quirk when we are
- printing and we are the root and the root has percentage height OR
- when we are the body and the root has percentage height. Otherwise
- we have a height of 0 and can run into painting troubles.
+ Ensure that scroll{Width, Height} is greater or equal to
+ client{Width, Height}.
* rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcHeight):
-
-2009-05-08 Douglas Davidson <ddavidso@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixes for <rdar://problem/6852771>.
- Prevent text checking replacement immediately after an apostrophe
- and automatic link addition except immediately after typing.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
-
-2009-05-08 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25627
- Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
-
- Update for HTML5 spec change to fire 'error' events on <source> element
- when there is a failure while processing/loading a <source>.
-
- Test: media/video-source-error.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::enqueueEvent): Remove white-space.
- (WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead
- of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on
- all <source> element.
- (WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in
- loadResource() as we need to report errors differently depending on the type of failure. Use
- KURL instead of String.
- (WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild.
- Fail silently when there are no more <source> canditates because that is what spec mandates.
- Keep url as KURL instead of converting to String.
- (WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now
- assume the safety check now done before this function. Takes KURL instead of String.
- (WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs
- failure if not.
- (WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
- (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on
- the media and all source elements.
- (WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the
- the failure happened while processing one. Only call nonSupported() when the failure happened
- while processing media element 'src' attribute.
- (WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild.
- Deal with selectNextSourceChild returning a KURL instead of a String.
- (WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional
- param to control whether or not errors are fired on a source element when it will not be used.
- Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a
- String.
- (WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as
- a KURL instead of a String.
- * html/HTMLMediaElement.h:
- (WebCore::HTMLMediaElement::):
-
- * html/HTMLSourceElement.cpp:
- (WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables.
- (WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error
- event ASAP.
- (WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event.
- (WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been
- cancelled.
- * html/HTMLSourceElement.h:
-
- * html/MediaError.h:
- (WebCore::MediaError::): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
- * html/MediaError.idl: Ditto
-
-2009-05-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - fix <rdar://problem/6859955> Undoing typed text after selecting all
- leaves non-text areas highlighted
-
- Test: fast/repaint/selection-clear.html
-
- When RenderView::clearSelection() is called from
- SelectionController::nodeWillBeRemoved(), selected renderers may already
- be marked for layout, which means that they can no longer compute
- their selection repaint info. Instead, an empty IntRect (or GapRects) is
- returned, leading to incomplete repaint.
-
- The fix is not to rely on individual renderers when clearing the
- selection, but instead, cache the bounding rectangle of the selected
- blocks' GapRects when setting the selection, and invalidate that
- entire rectangle when clearing it.
-
- * rendering/RenderView.cpp:
- (WebCore::RenderView::setSelection): Added a parameter saying whether
- the repainting of selected blocks should include both
- previously-selected areas and newly-selected areas or only
- newly-selected areas. The default is both. Also compute
- m_cachedSelectionBounds to be the bounding rectangle of the
- new selection's BlockSelectionInfos' GapRects.
- (WebCore::RenderView::clearSelection): Repaint m_cachedSelectionBounds,
- and tell setSelection() that it should not paint areas that were in
- the old selection's BlockSelectionInfos' GapRects.
- * rendering/RenderView.h:
- (WebCore::RenderView::):
-
-2009-05-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- <rdar://problem/6868773> NPN_GetAuthenticationInfo does not work with non-permanent credentials
-
- * WebCore.base.exp:
- * platform/network/mac/AuthenticationMac.h:
- (WebCore::WebCoreCredentialStorage::set):
- (WebCore::WebCoreCredentialStorage::get):
- * platform/network/mac/AuthenticationMac.mm:
- * platform/network/mac/ResourceHandleMac.mm:
- Moved WebCoreCredentialStorage to AuthenticationMac, so that it could be used from WebKit.
-
-2009-05-08 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix the Qt build, add missing JSC_HOST_CALL macros to the runtime
- call methods.
-
- * bridge/qt/qt_runtime.h:
-
-2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Add missing strings to localizedStrings.js
- https://bugs.webkit.org/show_bug.cgi?id=25635
-
- Add the strings "Delete", "Key", "Refresh" and "Value".
-
- * English.lproj/localizedStrings.js:
-
-2009-05-08 Robert Hogan <robert@roberthogan.net>
-
- Reviewed, tweaked and landed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24992
- [Qt] crash at http://browserspy.dk/browser.php
-
- This cannot be easily tested in DRT, because it relies on interaction with QApplication,
- but the added assertions guard against re-introducing this issue.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Don't make client calls
- while the frame is being constructed, because the intermediate state without a document
- is something we don't want to expose.
-
- * page/Frame.cpp:
- (WebCore::Frame::setJSStatusBarText): Assert that the frame has a document, which is an
- approximation of it being in a consistent state for client calls.
- (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
-2009-05-07 Mark Rowe <mrowe@apple.com>
+2009-06-27 Simon Fraser <simon.fraser@apple.com>
- Rubber-stamped by Oliver Hunt.
+ Reviewed by Eric Seidel.
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
- Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
+ https://bugs.webkit.org/show_bug.cgi?id=26780
- Roll out r43366 as it removed symbols that Safari 4 Beta uses.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::matchFunc):
- (WebCore::openFunc):
- (WebCore::createStringParser):
- (WebCore::createMemoryParser):
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open):
- * platform/sql/SQLiteDatabase.cpp:
- (WebCore::SQLiteDatabase::SQLiteDatabase):
- (WebCore::SQLiteDatabase::close):
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::DatabaseThread):
- (WebCore::DatabaseThread::start):
- (WebCore::DatabaseThread::databaseThread):
- * storage/LocalStorageThread.cpp:
- (WebCore::LocalStorageThread::LocalStorageThread):
- (WebCore::LocalStorageThread::start):
- (WebCore::LocalStorageThread::localStorageThread):
- (WebCore::LocalStorageThread::scheduleImport):
- (WebCore::LocalStorageThread::scheduleSync):
- (WebCore::LocalStorageThread::terminate):
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::start):
-
-2009-05-08 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- Unify scrolling code via adjustments and keys. Use the WebCore
- defined constants, since that's what people are most used to at
- this point.
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformHandleHorizontalAdjustment):
- (WebCore::ScrollView::platformHandleVerticalAdjustment):
-
-2009-05-07 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY.
- Suggested by Oliver Hunt.
-
- Rolling back http://trac.webkit.org/changeset/43385
- because we have to use mac artwork for the underline on OSX.
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- * platform/graphics/mac/GraphicsContextMac.mm:
- (WebCore::createPatternColor):
- (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- (WebCore::setCGStrokeColor):
- (WebCore::spellingPatternColor):
- (WebCore::grammarPatternColor):
- (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
-
-2009-05-07 John Grabowski <jrg@chromium.org>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25573
- Unify use of CG-common routine for drawLineForMisspellingOrBadGrammar.
- Cleanup for WebKit, but required for Chromium happiness.
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::spellingPatternColor):
- (WebCore::grammarPatternColor):
- (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- * platform/graphics/mac/GraphicsContextMac.mm:
- * platform/graphics/win/GraphicsContextCGWin.cpp:
-
-2009-05-07 Darin Adler <darin@apple.com>
-
- Reviewed by Simon Fraser.
-
- Bug 25575: Registered mutation event listener crashes HTMLMediaElement
- https://bugs.webkit.org/show_bug.cgi?id=25575
-
- Test: fast/media/video-controls-with-mutation-event-handler.html
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createTimeline): Call setAttribute here.
-
-2009-05-07 Simon Fraser <simon.fraser@apple.com>
-
- Rubber Stamped by Dave Hyatt
+ Do not make compositing layers for non-self-painting RenderLayers,
+ since these exist only to push a clip onto the clipping stack. If such
+ a layer gets compositied for some other reason, it should not paint.
- Shuffle the data members to minimize padding.
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::RenderTableSection):
- * rendering/RenderTableSection.h:
-
-2009-05-07 Simon Fraser <simon.fraser@apple.com>
+ Also ensure that we update composited layer positions correctly
+ inside overflow:scroll layers. We can't assume that the contents
+ are child layers, so we have to go up to the compositing ancestor,
+ and tell it to update all its child layer positions as we do
+ after layout.
- Rubber Stamped by Dave Hyatt
-
- Shuffle the data members to make Events 8 bytes smaller in 64-bit.
-
- * dom/Event.cpp:
- (WebCore::Event::Event):
- * dom/Event.h:
-
-2009-05-07 Eric Seidel <eric@webkit.org>
-
- Reviewed by Beth Dakin.
-
- Fix regression caused by r41469, add test case to prevent it from
- happening again.
- https://bugs.webkit.org/show_bug.cgi?id=25252
-
- hasLayer() was true during removeOnlyThisLayer()/
- updateLayerPositions()
- which caused updateLayerPosition()'s walk up the render tree to
- include offsets from the layer we were about to remove.
-
- I'm not 100% convinced that this wasn't a bug in
- updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
- because the layer in question is not the containing block for the
- block which gets laid out wrong. But this restores the previous
- behavior and adds a test. So the next time someone is in here re-
- factoring, they will at least know if they break something.
-
- Test: fast/layers/remove-only-this-layer-update.html
+ Tests: compositing/layers-inside-overflow-scroll.html
+ compositing/self-painting-layers.html
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::destroyLayer):
* rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::removeOnlyThisLayer):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::destroy):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy):
-
-2009-05-07 Dmitry Titov <dimich@chromium.org>
-
- Attempt to fix GTK build.
-
- * platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.
-
-2009-05-07 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Improve native call performance
-
- Add calling convention declarations where necessary, and update bindings
- script to generate them as well.
-
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::callHTMLCollection):
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::callNodeList):
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::callPlugin):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/runtime_method.cpp:
- (JSC::callRuntimeMethod):
- * bridge/runtime_object.cpp:
- (JSC::callRuntimeObject):
-
-2009-05-07 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Dave Hyatt.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
-
- Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
-
- Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
- gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
-
- The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
- This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
- To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
- methods are renamed to clarify where they belong to. All renames are listed here:
-
- From FormControlElement:
- - isEnabled() -> isEnabledFormControl()
- - isReadOnly() -> isReadOnlyFormControl()
- - isTextControl() -> isTextFormControl()
- - valueMatchesRenderer() -> formControlValueMatchesRenderer()
- - setValueMatchesRenderer() -> setFormControlValueMatchesRenderer()
- - name() -> formControlName()
- - type() -> formControlType()
-
- From FormControlElementWithState:
- - saveState() -> saveFormControlState()
- - restoreState() -> restoreFormControlState()
-
- A lot of Element -> FormControlElement(WithState) casting is gone again, so it's not only a memory, but also a performance progression.
-
- No testcases affected, no new tests needed.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::canShareStyleWithElement):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * dom/Document.cpp:
- (WebCore::Document::formElementsState):
- * dom/Document.h:
- (WebCore::Document::registerFormElementWithState):
- (WebCore::Document::unregisterFormElementWithState):
- * dom/Element.h:
- (WebCore::Element::isFormControlElement):
- (WebCore::Element::isEnabledFormControl):
- (WebCore::Element::isReadOnlyFormControl):
- (WebCore::Element::isTextFormControl):
- (WebCore::Element::formControlValueMatchesRenderer):
- (WebCore::Element::setFormControlValueMatchesRenderer):
- (WebCore::Element::formControlName):
- (WebCore::Element::formControlType):
- (WebCore::Element::saveFormControlState):
- (WebCore::Element::restoreFormControlState):
- * dom/FormControlElement.cpp: Removed.
- * dom/FormControlElement.h: Removed.
- * dom/FormControlElementWithState.cpp: Removed.
- * dom/FormControlElementWithState.h: Removed.
- * dom/InputElement.cpp:
- (WebCore::InputElement::setValueFromRenderer):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::formControlType):
- * html/HTMLButtonElement.h:
- * html/HTMLFieldSetElement.cpp:
- (WebCore::HTMLFieldSetElement::formControlType):
- * html/HTMLFieldSetElement.h:
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::attach):
- (WebCore::HTMLFormControlElement::formControlName):
- (WebCore::HTMLFormControlElement::willValidate):
- (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
- (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
- (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- * html/HTMLFormControlElement.h:
- (WebCore::HTMLFormControlElement::isTextFormControl):
- (WebCore::HTMLFormControlElement::isEnabledFormControl):
- (WebCore::HTMLFormControlElement::formControlValueMatchesRenderer):
- (WebCore::HTMLFormControlElement::setFormControlValueMatchesRenderer):
- (WebCore::HTMLFormControlElement::isReadOnlyFormControl):
- (WebCore::HTMLFormControlElement::type):
- (WebCore::HTMLFormControlElement::name):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::formControlName):
- (WebCore::HTMLInputElement::formControlType):
- (WebCore::HTMLInputElement::saveFormControlState):
- (WebCore::HTMLInputElement::restoreFormControlState):
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::detach):
- (WebCore::HTMLInputElement::setValue):
- (WebCore::HTMLInputElement::setFileListFromRenderer):
- * html/HTMLInputElement.h:
- (WebCore::HTMLInputElement::readOnly):
- (WebCore::HTMLInputElement::isTextFormControl):
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::formControlType):
- * html/HTMLKeygenElement.h:
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::formControlType):
- * html/HTMLLegendElement.h:
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::formControlType):
- * html/HTMLOptGroupElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::formControlType):
- * html/HTMLOptionElement.h:
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::formControlType):
- (WebCore::HTMLSelectElement::saveFormControlState):
- (WebCore::HTMLSelectElement::restoreFormControlState):
- * html/HTMLSelectElement.h:
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
- (WebCore::HTMLTextAreaElement::formControlType):
- (WebCore::HTMLTextAreaElement::saveFormControlState):
- (WebCore::HTMLTextAreaElement::restoreFormControlState):
- (WebCore::HTMLTextAreaElement::updateValue):
- (WebCore::HTMLTextAreaElement::setValue):
- * html/HTMLTextAreaElement.h:
- (WebCore::HTMLTextAreaElement::readOnly):
- (WebCore::HTMLTextAreaElement::isTextFormControl):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isEnabled):
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- * page/DragController.cpp:
- (WebCore::DragController::concludeEditDrag):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::itemIsEnabled):
- * rendering/RenderTextControl.cpp:
- (WebCore::updateUserModifyProperty):
- (WebCore::RenderTextControl::setInnerTextValue):
- * rendering/RenderTextControl.h:
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::isEnabled):
- (WebCore::RenderTheme::isReadOnlyControl):
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustMenuListStyle):
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::adjustMenuListStyle):
- * wml/WMLFormControlElement.cpp:
- * wml/WMLFormControlElement.h:
- (WebCore::WMLFormControlElement::isReadOnlyFormControl):
- (WebCore::WMLFormControlElement::isTextFormControl):
- (WebCore::WMLFormControlElement::formControlValueMatchesRenderer):
- (WebCore::WMLFormControlElement::setFormControlValueMatchesRenderer):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::WMLInputElement):
- (WebCore::WMLInputElement::isKeyboardFocusable):
- (WebCore::WMLInputElement::isMouseFocusable):
- (WebCore::WMLInputElement::dispatchBlurEvent):
- (WebCore::WMLInputElement::formControlType):
- (WebCore::WMLInputElement::formControlName):
- (WebCore::WMLInputElement::setValue):
- (WebCore::WMLInputElement::saveFormControlState):
- (WebCore::WMLInputElement::restoreFormControlState):
- (WebCore::WMLInputElement::parseMappedAttribute):
- (WebCore::WMLInputElement::detach):
- (WebCore::WMLInputElement::appendFormData):
- (WebCore::WMLInputElement::init):
- * wml/WMLInputElement.h:
- (WebCore::WMLInputElement::isTextFormControl):
- * wml/WMLOptGroupElement.cpp:
- (WebCore::WMLOptGroupElement::formControlType):
- * wml/WMLOptGroupElement.h:
- * wml/WMLOptionElement.cpp:
- (WebCore::WMLOptionElement::formControlType):
- * wml/WMLOptionElement.h:
-
-2009-05-07 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov and Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25348
- Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
-
- Most of the change is in WTF.
- Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
- method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
- is now a class rather then an integer.
- Also, there is no need to initialize threadID in constructors to 0 now.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
- since now ThreadIdentifier needs construction and we avoid having global initializers.
- (WebCore::matchFunc): use the new accessor function.
- (WebCore::openFunc): ditto.
- (WebCore::createStringParser): ditto.
- (WebCore::createMemoryParser): ditto.
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open):
- * platform/sql/SQLiteDatabase.cpp:
- (WebCore::SQLiteDatabase::SQLiteDatabase):
- (WebCore::SQLiteDatabase::close):
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::start):
- (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
- * storage/LocalStorageThread.cpp:
- (WebCore::LocalStorageThread::start):
- (WebCore::LocalStorageThread::scheduleImport):
- (WebCore::LocalStorageThread::scheduleSync):
- (WebCore::LocalStorageThread::terminate):
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::start):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::start):
-
-2009-05-07 Simon Fraser <simon.fraser@apple.com>
-
- Rubber Stamped by Dave Hyatt
-
- Shuffle the data members to minimize padding.
-
- * dom/ClassNames.h:
-
-2009-05-07 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
- https://bugs.webkit.org/show_bug.cgi?id=25605
-
- Shrink GlyphPage by splitting the array of GlyphData, which has lots
- of padding, into separate Glyph and SimpleFontData* arrays.
-
- * platform/graphics/Font.h:
- glyphDataForCharacter has to return a GlyphData by value now.
-
- * platform/graphics/FontFastPath.cpp:
- (WebCore::Font::glyphDataForCharacter):
- Return GlyphData by value.
-
- * platform/graphics/GlyphPageTreeNode.cpp:
- (WebCore::GlyphPageTreeNode::initializePage):
- Better encapsulation of GlyphPage, using the new methods.
-
- * platform/graphics/Font.h:
- * platform/graphics/FontFastPath.cpp:
- (WebCore::Font::glyphDataForCharacter):
- * platform/graphics/GlyphPageTreeNode.cpp:
- (WebCore::GlyphPageTreeNode::initializePage):
- * platform/graphics/GlyphPageTreeNode.h:
- (WebCore::GlyphData::GlyphData):
- (WebCore::GlyphPage::indexForCharacter):
- (WebCore::GlyphPage::glyphDataForCharacter):
- (WebCore::GlyphPage::glyphDataForIndex):
- (WebCore::GlyphPage::glyphAt):
- (WebCore::GlyphPage::fontDataForCharacter):
- (WebCore::GlyphPage::setGlyphDataForCharacter):
- (WebCore::GlyphPage::setGlyphDataForIndex):
- (WebCore::GlyphPage::copyFrom):
- (WebCore::GlyphPage::clear):
-
-2009-05-07 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25625
- Implement Image/Option constructors in V8 bindings.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
- * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
- * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.
-
-2009-05-07 Brady Eidson <beidson@apple.com>
-
- I hate myself for doing this, but need to fix that ChangeLog entry.
-
- * ChangeLog:
-
-2009-05-07 Brady Eidson <beidson@apple.com>
-
- Rubberstamped by Darin Adler
-
- * html/HTMLParser.cpp: Use the correct style of BUILDING_ON_* for WebCore.
- * html/HTMLParser.h: Ditto
-
-2009-05-07 David Hyatt <hyatt@apple.com>
-
- Restore intrinsic margins to all form controls on Mac and Windows. Some of this regressed in 43007
- when textareas were given explicit margins. Some of it had already regressed earlier whenever intrinsic
- margins were turned off in themeWin.css.
-
- Reviewed by Beth Dakin.
-
- * css/html4.css:
- * css/themeWin.css:
-
-2009-05-07 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler and Alexey Proskuryakov.
-
- <rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
-
- * dom/Document.cpp:
- (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
- (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
- (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
- * html/HTMLParser.h:
- (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
-
-2009-05-07 Antony Sargent <asargent@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Fix a memory leak in V8EventListenerList::remove.
-
- https://bugs.webkit.org/show_bug.cgi?id=25618
-
- No new functionality so no new tests.
-
- * bindings/v8/V8EventListenerList.cpp:
- (WebCore::V8EventListenerList::remove):
-
-2009-05-07 Darin Fisher <darin@chromium.org>
-
- Fix Chromium build bustage.
-
- * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing
- HTMLCollection.h include.
-
-2009-05-07 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
- https://bugs.webkit.org/show_bug.cgi?id=25598
-
- Test: accessibility/radio-button-title-label.html
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::exposesTitleUIElement):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
- (WebCore::AccessibilityRenderObject::titleUIElement):
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- * page/AccessibilityRenderObject.h:
-
-2009-05-07 Darin Fisher <darin@chromium.org>
-
- Fix Chromium build bustage.
-
- * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- (WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"
-
-2009-05-07 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25610
- [GTK] text.caretOffset is reportedly always 0
-
- Use the right function to get the caret offset in an
- element. selectionStart() would only work for text
- controls (there's even an ASSERT when calculating the selected
- text range). Instead just get the selection and get the offset of
- the start position.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Fix support for antialiased CSS border-radius
-
- WebKit implements border-radius by drawing a double-size border,
- and then letting the clip constrain the border to the right width
- and position. This requires support for antialiased clipping, as
- well as painting, to get a nice smooth border.
-
- Qt only does antialiased clipping if the anti-alias flag is set
- at the time of clipping, so we have to enable this in the method
- addInnerRoundedRectClip(), as well as when we draw the border.
-
- Currently the raster-engine is the only Qt paint engine to support
- anti-aliased clipping, but the OpenGL and Mac paint engines could
- potentially support this in the future.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::strokeArc):
- (WebCore::GraphicsContext::addInnerRoundedRectClip):
-
-2009-05-07 Adam Langley <agl@google.com>
-
- Reviewed by Eric Seidel.
-
- Render empty optgroup elements.
-
- https://bugs.webkit.org/show_bug.cgi?id=24900
-
- Currently, optgroup elements which are empty are not rendered. The
- HTML specification gives no guidance on this situation.
-
- However, the test for being empty is that they have no children, thus
- this will not render:
- <optgroup label="test"></optgroup>
- while this /will/ render (because of the text node child):
- <optgroup label="test"> </optgroup>
-
- This patch will cause both cases to render which matches IE's and
- Firefox's behaviour.
-
- The difference only appears when opening the select element and does
- not appear in the render tree. Thus, a manual layout-test is required.
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::recalcListItems):
- * manual-tests/optgroup-empty-and-nested.html: Added.
+ (WebCore::RenderLayer::scrollToOffset):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::needsToBeComposited):
-2009-05-06 Julie Parent <jparent@google.com>
+2009-06-28 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Reviewed by Eric Seidel.
- Bug 25608: Unused m_frame in ChromiumClipboard.
- https://bugs.webkit.org/show_bug.cgi?id=25608
-
- * platform/chromium/ClipboardChromium.h:
-
- No tests added as this is only removing dead code, no functional changes.
-
-2009-05-06 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser and Justin Garcia.
-
- - fix another part of <rdar://problem/6703873> Triple-click quoted line
- and type Return creates an extra quoted blank line
-
- Test: editing/inserting/6703873-2.html
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for
- determining the first node that should go into the new blockquote
- given the split position: if it is at the end of a container, use the
- next node after the container. Otherwise, use the child at the
- position's offset.
-
-2009-05-06 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix, fixes for wx trunk builds.
-
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
- * platform/wx/RenderThemeWx.cpp:
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
-
-2009-05-06 Albert J. Wong <ajwong@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25597
- Fix API drift compile errors that occurred while this was ifdef-ed out.
- The two big issues were that RenderObject::element() became
- RenderObject::node() and some of the wk* drawing functions had
- an extra theme parameter added to the argument list.
-
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
- (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
- (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
- (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton):
- (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton):
- (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
- (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
-
-2009-05-06 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25385
- Upstream changes to V8 bindings for supporting nested workers.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::ToV8Object):
- (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
- * bindings/v8/custom/V8WorkerCustom.cpp:
- (WebCore::getEventListener):
- (WebCore::ACCESSOR_SETTER WorkerOnmessage):
- (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
-
-2009-05-06 Dave Moore <davemoore@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25513
- The V8 bindings convert every javascript property to its associated css style
- name. It then calls functions that convert that name to an id. This makes
- getting or setting css styles on elements slow.
-
- The patch fixes this by caching the results of the transformation, mapping a
- javascript property name to its css property id. It then calls the already
- public webkit methods that take the id in place of the string property names.
-
- * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
-
-2009-05-06 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25591
- Upstream V8HTMLFormElement from the Chromium repository.
-
- * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository
- (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor();
- (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
-
-2009-05-06 Albert J. Wong <ajwong@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25595
- Upstream V8CanvasPixelArrayCustom from chromium port tree.
-
- * bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
+ PurgeableBuffer #defines leave out functions on gtk MacOSX 10.4 build
+ https://bugs.webkit.org/show_bug.cgi?id=23057
-2009-05-06 Simon Fraser <simon.fraser@apple.com>
+ Define these functions for Gtk as well.
- Rubber-stampted by Eric Seidel
-
- Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
- Only affects ACCELERATED_COMPOSITING builds.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::adjustStyleDifference):
-
-2009-05-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- <rdar://problem/6862550> Reduce size of RenderText in 64-bit
-
- Rearrange data members of RenderText so that an int comes
- first, to minimize padding.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
- * rendering/RenderText.h:
-
-2009-05-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- <rdar://problem/6862823> Reduce size of RenderStyle in 64-bit
-
- Rearrange data members of RenderStyle to minimize padding
- when building for 64-bit.
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::RenderStyle):
- * rendering/style/RenderStyle.h:
- (WebCore::):
+ * platform/PurgeableBuffer.h:
-2009-05-06 Darin Fisher <darin@chromium.org>
+2009-06-28 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
- https://bugs.webkit.org/show_bug.cgi?id=25596
-
- Fixes Chromium build bustage caused by r43317 (making
- RefCountedBase::m_refCount private)
-
- * page/chromium/AccessibilityObjectWrapper.h:
- (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
-
-2009-05-06 Hin-Chung Lam <hclam@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25593
-
- Refactor for MediaPlayerPrivate for Chromium port. Remove
- the implementation of MediaPlayerPrivateInferface from it.
-
- * platform\graphics\chromium\MediaPlayerPrivateChromium.h:
-
-2009-05-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt, Dan Bernstein
-
- <rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit
-
- Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.
-
- * platform/graphics/FontFallbackList.cpp:
- (WebCore::FontFallbackList::FontFallbackList):
- * platform/graphics/FontFallbackList.h:
+ Update CodeGeneratorV8.pm to match the new api for V8Proxy.
-2009-05-06 Simon Fraser <simon.fraser@apple.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26765
- Reviewed by Darin Adler, Dan Bernstein
+ * bindings/scripts/CodeGeneratorV8.pm: Match the current version of V8Proxy.
- <rdar://problem/6860068> Reduce size of InlineBox in 64-bit
-
- Re-order the data members of InlineBox to save 8 bytes when building 64-bit.
-
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
-
-2009-05-06 David Levin <levin@chromium.org>
+2009-06-28 Nicolas Sylvain <nsylvain@chromium.org>
Reviewed by Dimitri Glazkov.
- https://bugs.webkit.org/show_bug.cgi?id=25588
- Adding the custom v8 bindings Document.location.
-
- * bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
+ If loading a font fails because of the sandbox, we ask the browser process to
+ try to load it by calling ensureFontLoaded. If it still fails after
+ ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
-2009-05-06 Kevin McCullough <kmccullough@apple.com>
+ This case happens once in a while during browser shutdown. The browser will
+ queue a message to the renderer to shutdown, and will then stop answering sync
+ messages from the renderer. If the renderer is still loading a page during this
+ time, it might try to call the browser process to ask to load a font. The
+ browser process will ignore the request, and the font will fail to load, even
+ after the second try.
- -Clarified a comment
+ This is unfortunate, but there is no real risk here, since the renderer will be
+ going away as soon as it processes another message.
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
+ This can't be layout tested as it depends on the sandbox.
-2009-05-06 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26743
- Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.
-
- * wml/WMLAElement.cpp:
- * wml/WMLAccessElement.cpp:
- * wml/WMLBRElement.cpp:
- * wml/WMLCardElement.cpp:
- * wml/WMLDoElement.cpp:
- * wml/WMLElement.cpp:
- * wml/WMLFieldSetElement.cpp:
- * wml/WMLGoElement.cpp:
- * wml/WMLImageElement.cpp:
- * wml/WMLInputElement.cpp:
- * wml/WMLMetaElement.cpp:
- * wml/WMLOnEventElement.cpp:
- * wml/WMLOptGroupElement.cpp:
- * wml/WMLOptionElement.cpp:
- * wml/WMLPElement.cpp:
- * wml/WMLPostfieldElement.cpp:
- * wml/WMLSetvarElement.cpp:
- * wml/WMLTableElement.cpp:
- * wml/WMLTemplateElement.cpp:
- * wml/WMLTimerElement.cpp:
-
-2009-05-06 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25526
- [Gtk] Additional support is needed for caret browsing
-
- Emit AtkText::text-selection-changed when the selection changes
- and the current selection is of Range (ie, the start and end
- positions are different) type. This seems to match what Gecko
- does.
-
- * editing/gtk/SelectionControllerGtk.cpp:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
-
-2009-05-05 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=25526
- [Gtk] Additional support is needed for caret browsing
-
- Emit AtkText::text-caret-moved when selection changes.
-
- * GNUmakefile.am:
- * editing/SelectionController.h:
- * editing/gtk/SelectionController.cpp: Added.
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
-
-2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- Use mozilla cursors for the previously not implemented
- cursors. The manual-tests/cursor.html is looking complete
- now.
-
- * platform/gtk/CursorGtk.cpp:
- (WebCore::cellCursor):
- (WebCore::noDropCursor):
- (WebCore::progressCursor):
- (WebCore::noneCursor):
- (WebCore::notAllowedCursor):
- (WebCore::grabCursor):
- (WebCore::grabbingCursor):
- * platform/gtk/CursorGtk.h:
-
-2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- Properly indent the header file.
-
- * platform/gtk/CursorGtk.h:
-
-2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- Use the mozilla copyright header. Use MPL1.1/GPL2.0
- and LGPL2.1 as the license compared to LGPL2.0.
-
- * platform/gtk/CursorGtk.h:
-
-2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Gustavo Noronha.
-
- Move PluginView::invalidateRegion from the
- TemporaryLinkStubs to PluginViewGtk.cpp and implement
- it with a call to Widget::invalidate() just like
- mac is doing. Optimisations would have to be window
- system specific.
-
- * platform/gtk/TemporaryLinkStubs.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::invalidateRegion):
-
-2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Holger Freyther.
-
- Misc fixes to InspectorClientGtk.
-
- * GNUmakefile.am: Add localizedStrings.js to webinspector_DATA.
- This prevents copious amounts "Localized string not found" errors
- in the console
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- Fix the Qt build on Windows.
-
- * platform/graphics/GraphicsContext.h:
- (WebCore::GraphicsContext::shouldIncludeChildWindows): Implemented dummy accessor.
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Tweak WebCore.pro for being able to override the generated sources dir for the
- generated_files target.
-
- * WebCore.pro:
-
-2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Fix the Qt/Windows build, use iface instead of interface to avoid conflict
- with VS2005 headers.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
-
-2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- We need to include StringExtras.h on Windows CE to access the strdup function.
-
- * plugins/PluginStream.cpp:
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
-2009-05-06 Soren Gjesse <sgjesse@chromium.org>
+2009-06-28 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel.
- Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=25544
-
- In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
- function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
- use the source of an event handler to create new functions this wrapper code causes compatibility problems.
-
- Create a specific toString function for these handlers which will return a function source compatible with the
- source returned by the JSC bindings and other browsers.
-
- Test: fast/events/event-function-toString.html
-
- * bindings/v8/ScriptEventListener.cpp:
- (WebCore::createAttributeEventListener):
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::V8LazyEventListener):
- (WebCore::V8LazyEventListener::getListenerFunction):
- (WebCore::V8LazyEventListenerToString):
- (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- * bindings/v8/V8LazyEventListener.h:
- (WebCore::V8LazyEventListener::create):
-
-2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Build QtWebKit as a framework on Mac
-
- This implies both debug and release build by default, unless
- one of the --debug or --release config options are passed to
- the build-webkit script.
-
- Frameworks can be disabled by passing CONFIG+=webkit_no_framework
- to the build-webkit script.
-
- To be able to build both debug and release targets in parallel
- we have to use separate output directories for the generated
- sources, which is not optimal, but required to avoid race conditions.
-
- An optimization would be to only require this spit-up on Mac.
-
- * WebCore.pro:
-
-2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+ https://bugs.webkit.org/show_bug.cgi?id=15457
- Reviewed by Simon Hausmann.
-
- [Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
-
- A couple of the generators left the bison output file in the source
- tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
- work well when building release and debug configurations in parallel.
-
- * WebCore.pro:
-
-2009-05-06 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Justin Garcia.
-
- - fix an assertion failure in RemoveNodeCommand() when deleting a <br>
- between a block and a mail blockquote
-
- Test: editing/deleting/removeNodeCommand-assert.html
-
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block
- to prune() instead of passing m_upstreamStart.node(), because the latter
- may have been removed already.
+ Test: plugins/netscape-plugin-map-data-to-src.html
-2009-05-05 Eric Seidel <eric@webkit.org>
+ Fix problems with Real or WMP plugins not displaying because "data" was set
+ on the OBJECT tag instead of "src". This is based on what Firefox does, see
+ http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#3045
- No review, roll out only.
-
- Roll out r23072 since it broke layout tests
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
-
-2009-05-05 Ben Murdoch <benm@google.com>
-
- Reviewed by Eric Seidel.
-
- Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
- https://bugs.webkit.org/show_bug.cgi?id=24776
-
- No functional changes, thus no tests.
-
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- * bindings/js/JSCustomSQLStatementCallback.h:
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- * bindings/js/JSCustomSQLStatementErrorCallback.h:
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- * bindings/js/JSCustomSQLTransactionCallback.h:
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- * bindings/js/JSCustomSQLTransactionErrorCallback.h:
- * bindings/js/JSDatabaseCustom.cpp:
- * bindings/js/JSSQLTransactionCustom.cpp:
- * loader/EmptyClients.h:
- * page/ChromeClient.h:
- * storage/ChangeVersionWrapper.cpp:
- * storage/ChangeVersionWrapper.h:
- * storage/Database.cpp:
- (WebCore::Database::databaseInfoTableName):
- * storage/Database.h:
- * storage/Database.idl:
- * storage/DatabaseTask.cpp:
- * storage/DatabaseTask.h:
- * storage/DatabaseThread.cpp:
- * storage/DatabaseThread.h:
- * storage/DatabaseTracker.cpp:
- * storage/DatabaseTracker.h:
- * storage/DatabaseTrackerClient.h:
- * storage/OriginQuotaManager.cpp:
- * storage/OriginQuotaManager.h:
- * storage/SQLStatement.cpp:
- * storage/SQLStatement.h:
- * storage/SQLTransaction.cpp:
- * storage/SQLTransaction.h:
- * storage/SQLTransaction.idl:
-
-2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add some documentation to InlineBox::x(),y().
- https://bugs.webkit.org/show_bug.cgi?id=25378
-
- * rendering/InlineBox.h:
+ * rendering/RenderPartObject.cpp:
+ (WebCore::mapDataParamToSrc):
+ (WebCore::RenderPartObject::updateWidget):
-2009-05-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+2009-06-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
- Reviewed by Eric Seidel.
+ Reviewed by Jan Alonzo.
- Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
- https://bugs.webkit.org/show_bug.cgi?id=24693
+ [Qt] Build fix after r45290
+ https://bugs.webkit.org/show_bug.cgi?id=26769
* WebCore.pro:
-2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
-
- Reviewed by Eric Seidel.
-
- Anonymous blocks should not be exposed in accessibility tree.
- Part of https://bugs.webkit.org/show_bug.cgi?id=23072
-
- Tests: accessibility/ignore-anonymous-block.html
- platform/win/accessibility/document-role.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return
- true for Anonymous blocks. Matching Firefox 2.0.0.14
-
-2009-05-05 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- http://bugs.webkit.org/show_bug.cgi?id=25487
-
- For euc-kr and other 8bit Korean encodings
- (similar to euc-kr/windows-949), make document.charset return
- EUC-KR instead of windows-949. The latter is not recognized by
- Korean web servers.
-
- Add domName method to TextEncoding to deal with cases where
- our internal encoding name does not match what's widely recognized
- by web servers. Currently, the only case is 'windows-949' (internal
- name) vs 'EUC-KR'.
-
- Test: fast/encoding/euckr-name.html
-
- * dom/Document.cpp:
- (WebCore::Document::encoding): Call TextEncoding.domName() instead
- of TextEncoding.name().
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::domName): For the canonical name 'windows-949',
- return 'EUC-KR'. Otherwise, just return the canonical name.
- * platform/text/TextEncoding.h:
-
-2009-05-05 Adam Langley <agl@google.com>
-
- Reviewed by Darin Adler.
-
- Rendering fix for <select> elements.
- https://bugs.webkit.org/show_bug.cgi?id=25558
-
- When switching a <select> element from display:none to default
- display, we would fail to invalidate the parent's pref widths in some
- situations:
-
- When attaching the element, RenderMenuList::updateOptionsWidth would
- call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
- set. This would mark the pref widths as dirty, but not for any parent
- objects.
-
- When RenderObjectChildList::appendChildNode later calls
- setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
- nothing would be done because the pref widths were already dirty for.
- the RenderMenuList.
-
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::updateOptionsWidth):
-
-2009-05-05 Antony Sargent <asargent@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Switch V8EventListenerList to use HashTable<T>.
- https://bugs.webkit.org/show_bug.cgi?id=25496
-
- This avoids some tricky issues with event listener removal in the
- current implementation and has slightly better performance.
-
- No new functionality so no new tests.
-
- * bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
- * bindings/v8/V8EventListenerList.h:
- (WebCore::V8EventListenerList::size):
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
-
-2009-05-05 Darin Fisher <darin@chromium.org>
-
- Fixing build bustage.
-
- Add some missing includes to fix the Chromium build.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
-
-2009-05-05 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25570
-
- history.{back,forward,go} should always be dispatched asynchronously,
- even when the history navigation would just result in scrolling the
- page. This matches the behavior of other browsers like IE and FF.
-
- Test: fast/history/back-forward-is-asynchronous.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::scheduleHistoryNavigation):
-
-2009-05-05 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
- https://bugs.webkit.org/show_bug.cgi?id=25532
- https://bugs.webkit.org/show_bug.cgi?id=25568
-
- Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
- which was causing transformed SVG text when filled/stroked with a
- pattern using patternUnits=objectBoundingBox to draw incorrectly.
-
- I fixed the incorrect drawing (by removing the broken code) and added
- two test cases to test the fix:
- * svg/transforms/text-with-pattern-inside-transformed-html.xhtml
- * svg/transforms/text-with-pattern-with-svg-transform.svg
-
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::mapLocalToContainer):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::mapLocalToContainer):
- * svg/graphics/SVGPaintServerPattern.cpp:
- (WebCore::SVGPaintServerPattern::setup):
-
-2009-05-05 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25554
-
- Support HTML5 text control input types: email, number, tel, url
-
- Test: fast/html/text-field-input-types.html
-
- * bindings/objc/DOMHTML.mm:
- (-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
- * html/HTMLInputElement.cpp: Use the new types where appropriate.
- (WebCore::HTMLInputElement::setInputType):
- (WebCore::HTMLInputElement::type):
- (WebCore::HTMLInputElement::saveState):
- (WebCore::HTMLInputElement::restoreState):
- (WebCore::HTMLInputElement::accessKeyAction):
- (WebCore::HTMLInputElement::rendererIsNeeded):
- (WebCore::HTMLInputElement::createRenderer):
- (WebCore::HTMLInputElement::appendFormData):
- (WebCore::HTMLInputElement::valueWithDefault):
- (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
- (WebCore::HTMLInputElement::defaultEventHandler):
- * html/HTMLInputElement.h: Ditto.
- (WebCore::HTMLInputElement::):
- (WebCore::HTMLInputElement::isTextField):
-
-2009-04-01 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Mouse wheel scrolling and keyboard shortcut support for wx.
-
- https://bugs.webkit.org/show_bug.cgi?id=24797
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::wheelEvent):
- * platform/wx/KeyboardEventWx.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetScrollPosition):
-
-2009-05-05 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix for Windows, add missing include.
-
- https://bugs.webkit.org/show_bug.cgi?id=24798
-
- * platform/wx/wxcode/win/non-kerned-drawing.cpp:
-
-2009-05-05 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
- https://bugs.webkit.org/show_bug.cgi?id=25574
-
- Enable accessibility hit-testing for image map links.
- Allow image map links to return AXURLs and AXAccessKey information.
-
- Test: platform/mac/accessibility/imagemap-hittest.html
-
- * page/AccessibilityImageMapLink.cpp:
- (WebCore::AccessibilityImageMapLink::url):
- * page/AccessibilityImageMapLink.h:
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::minValueForRange):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
- (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
- (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- * page/AccessibilityRenderObject.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
-
-2009-05-05 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6552129> Select a quote line and paste elsewhere, you
- get that line and an extra quoted blank line
- <rdar://problem/6609308> Triple-click a quoted header line, copy, paste
- onto an empty line makes an extra quoted line
-
- - When pasting a blockquote with a newline, make sure we put the newline
- outside of the blockquote so that it is not quoted.
-
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
-
-2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- Call moz_gtk_shutdown on RenderThemeGtk destruction.
-
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::~RenderThemeGtk):
- * platform/gtk/RenderThemeGtk.h:
-
-2009-05-05 Darin Adler <darin@apple.com>
-
- Reviewed by Steve Falkenburg.
-
- <rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"
-
- * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
-
-2009-05-05 Peter Kasting <pkasting@google.com>
-
- Reviewed by Brady Eidson.
-
- Safety-check m_documentLoader before dereferencing. While it seems
- unlikely this could fail (as Safari 3 shipped without this),
- technically almost any call can change or reset m_documentLoader.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::receivedFirstData):
-
-2009-05-05 Dan Bernstein <mitz@apple.com>
-
- - Tiger build fix
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::toCSSIdentifier):
-
-2009-05-05 Peter Kasting <pkasting@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25303
- No need to ref the internal buffer inside the Skia ImageDecoder.
-
- * platform/image-decoders/skia/ImageDecoder.h:
- (WebCore::RGBA32Buffer::RGBA32Buffer):
- (WebCore::RGBA32Buffer::operator=):
- (WebCore::RGBA32Buffer::clear):
- (WebCore::RGBA32Buffer::copyBitmapData):
- (WebCore::RGBA32Buffer::bitmap):
- (WebCore::RGBA32Buffer::setSize):
- (WebCore::RGBA32Buffer::width):
- (WebCore::RGBA32Buffer::height):
- (WebCore::RGBA32Buffer::hasAlpha):
- (WebCore::RGBA32Buffer::setStatus):
- (WebCore::RGBA32Buffer::setHasAlpha):
- (WebCore::RGBA32Buffer::setRGBA):
-
-2009-05-05 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=24192
- <rdar://problem/5760774> Replying to a Mail message that contains
- fixed width text can change the size of the text
-
- Covered by existing tests: editing/pasteboard/5027857.html
- editing/pasteboard/paste-pre-002.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
- Added. If the font-size is keyword-based, returns the keyword value
- instead of the pixel size.
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If
- font-family is a generic family, return the generic family instead of
- the the internal string -webkit-[serif|sans-serif|cursive|fantasy
- |monospace].
- (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
- For the font-size property, prefer a keyword value over a pixel size.
- * css/CSSComputedStyleDeclaration.h:
- * editing/ApplyStyleCommand.cpp:
- (WebCore::StyleChange::currentlyHasStyle): For the font-size property,
- call getFontSizeCSSValuePreferringKeyword().
- * platform/graphics/FontDescription.h:
- (WebCore::FontDescription::keywordSize): Changed the return type to
- unsigned.
- (WebCore::FontDescription::setKeywordSize): Changed the parameter type
- to unsigned.
- (WebCore::FontDescription::m_keywordSize): Changed the type of this
- 4-bit field to unsigned, because it takes values as high as 8.
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Fix http/tests/misc/DOMContentLoaded-event.html
-
- The native call performance improvement removed a few places where we
- unintentionally performed a toThisObject conversion. This patch updates
- the bindings codegen to not rely on this bug.
-
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez and Gustavo Noronha.
-
- Implement WebCore::directoryName for Gtk+.
-
- * platform/gtk/FileSystemGtk.cpp:
- (WebCore::directoryName):
-
-2009-05-05 Eric Seidel <eric@webkit.org>
-
- Reviewed by Adam Roben.
-
- Fix mappedAttributes() access without NULL check
- https://bugs.webkit.org/show_bug.cgi?id=25553
-
- SVGStyledElement::getPresentationAttribute was using mappedAttributes()
- without checking for NULL.
-
- HTMLInputElement::setInputType also doesn't NULL check, but I was not
- able to get it to crash with a test case so I just added an ASSERT.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setInputType):
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::getPresentationAttribute):
-
-2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Xan Lopez.
-
- Implement WebCore::imageTitle for Gtk+.
-
- * platform/gtk/LocalizedStringsGtk.cpp:
- (WebCore::imageTitle):
-
-2009-05-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Bug 25559: Improve native function call performance
- <https://bugs.webkit.org/show_bug.cgi?id=25559>
-
- Add forwarding header necessary for compilation, and fix debugger
- to correctly account for change in JSFunction behaviour.
-
- * ForwardingHeaders/jit/JITCode.h: Added.
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
-
-2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- Make convertValueToQVariant more robust against null JSValues.
-
- Don't require the caller to do the null check.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertValueToQVariant):
-
-2009-05-05 Eric Seidel <eric@webkit.org>
-
- No review, just a revert.
-
- Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.
-
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::mapLocalToContainer):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::mapLocalToContainer):
-
-2009-05-04 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dave Hyatt.
-
- <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
-
- The problem was caused by missing <head> element - we used to create it when moving a
- misplaced <style> element, but we now handle those in place. Other browsers always create
- a <head> element.
-
- There is no guarantee that a <head> element always exists - first, it can be removed with
- removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
- for manually created ones (e.g. ImageDocument).
-
- Test: fast/parser/head-element-for-yahoo-player.html
-
- * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
- A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
- code is removed completely.
-
- * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
- elements as children of <html>. This isn't directly related to this bug, but it was easier
- to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
- Create a <head> it a <body> is created implicitly to contain some other element.
- (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
- explicitly present in source.
- (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
-
-2009-05-04 Jakub Wieczorek <faw217@gmail.com>
-
- Reviewed by Simon Hausmann.
-
- As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
- returns the application/octet-stream mimetype when it can't associate
- extension with any mimetype, it can happen that the application/octet-stream
- mimetype will hit the list of supported image formats. For instance,
- it is possible when QImageReader or QImageWriter support an extension
- that is not in the extensions map.
-
- Make sure that this mimetype is not treated as displayable image type.
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedImageMIMETypes):
- (WebCore::initializeSupportedImageMIMETypesForEncoding):
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- ASSERT(useTransforms) in SVG mapLocalToContainer implementations
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::mapLocalToContainer):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::mapLocalToContainer):
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Remove m_absoluteBounds hack from RenderSVGText
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)
-
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::layout):
- * rendering/RenderSVGText.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Remove the vestigial calculateLocalTransform()
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- RenderSVGContainer is now the only render which needs this
- function, but it no longer returns the unused bool.
-
- calculateLocalTransform() previously was called by the DOM before
- transform updates were part of layout().
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::layout):
- * rendering/RenderForeignObject.h:
- (WebCore::RenderForeignObject::localTransform):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::layout):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::calculateLocalTransform):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::layout):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::layout):
- * rendering/RenderSVGText.h:
- * rendering/RenderSVGTransformableContainer.cpp:
- (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- * rendering/RenderSVGTransformableContainer.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Move more code into SVGRenderBase
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
- are now all shared via SVGRenderBase.
-
- RenderForeignObject should also be sharing this code, but I've left it
- alone for now, as changing that would likely cause test changes.
-
- No test changes. It's possible that transformed <svg:image> elements will
- now show up with better metrics in the inspector.
-
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGImage::computeRectForRepaint):
- (WebCore::RenderSVGImage::mapLocalToContainer):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGModelObject::computeRectForRepaint):
- (WebCore::RenderSVGModelObject::mapLocalToContainer):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGText::computeRectForRepaint):
- (WebCore::RenderSVGText::mapLocalToContainer):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::clippedOverflowRectForRepaint):
- (WebCore::SVGRenderBase::computeRectForRepaint):
- (WebCore::SVGRenderBase::mapLocalToContainer):
- * rendering/SVGRenderSupport.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Add SVGRenderBase to share logic between SVG renderers
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- I've added an SVGRenderBase base class which is shared by
- all of the SVG renders now. This patch is just moving code
- there are no functional changes in this patch.
-
- Currently I've left these functions in SVGRenderSupport.h
- In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*
-
- clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.
-
- * rendering/RenderSVGBlock.h:
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGRoot.h:
- * rendering/SVGRenderSupport.cpp:
- (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- (WebCore::SVGRenderBase::finishRenderSVGContent):
- (WebCore::clampImageBufferSizeToViewport):
- (WebCore::SVGRenderBase::computeContainerBoundingBox):
- (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- * rendering/SVGRenderSupport.h:
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
- (WebCore::SVGRootInlineBox::paint):
- * svg/SVGMaskElement.cpp:
- (WebCore::SVGMaskElement::drawMaskerContent):
- * svg/SVGPatternElement.cpp:
- (WebCore::SVGPatternElement::buildPattern):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::createMaskAndSwapContextForTextGradient):
- (WebCore::clipToTextMask):
-
-2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
-
- Unreviewed SVG build fix.
-
- Include MappedAttribute.h after r43187.
-
- * svg/SVGComponentTransferFunctionElement.cpp:
- * svg/SVGFEBlendElement.cpp:
- * svg/SVGFEColorMatrixElement.cpp:
- * svg/SVGFEComponentTransferElement.cpp:
- * svg/SVGFECompositeElement.cpp:
- * svg/SVGFEDiffuseLightingElement.cpp:
- * svg/SVGFEDisplacementMapElement.cpp:
- * svg/SVGFEGaussianBlurElement.cpp:
- * svg/SVGFEImageElement.cpp:
- * svg/SVGFELightElement.cpp:
- * svg/SVGFEMergeNodeElement.cpp:
- * svg/SVGFEOffsetElement.cpp:
- * svg/SVGFESpecularLightingElement.cpp:
- * svg/SVGFETileElement.cpp:
- * svg/SVGFETurbulenceElement.cpp:
- * svg/SVGFilterElement.cpp:
- * svg/SVGFilterPrimitiveStandardAttributes.cpp:
-
-2009-05-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by Sam 'The Belly' Weinig
-
- <rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only
-
- In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
- themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.
-
- The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
- the canLoad() check if a codebase was actually set on the applet tag.
-
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
-
-2009-05-04 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * html/HTMLCollection.h:
- * html/HTMLFormElement.h:
- Declare CollectionCache as a struct, not a class, to match its
- definition.
-
-2009-05-04 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin, Oliver Hunt.
-
- Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
- https://bugs.webkit.org/show_bug.cgi?id=25557
-
- Test: accessibility/canvas.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- (WebCore::AccessibilityRenderObject::roleValue):
-
-2009-05-04 Brady Eidson <beidson@apple.com>
-
- Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.
-
- * ChangeLog
-
-2009-05-04 Kai Brüning <kai@granus.net>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24883
- 24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
-
- Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
-
- Test: fast/innerHTML/innerHTML-nbsp.xhtml
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::parseXMLDocumentFragment):
-
-2009-05-04 Darin Adler <darin@apple.com>
-
- Reviewed by Eric Seidel.
-
- Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
- and NamedMappedAttrMap.h include of MappedAttribute.h
- https://bugs.webkit.org/show_bug.cgi?id=24924
-
- Make compiles faster, and debugging info smaller.
+2009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com>
- * GNUmakefile.am: Added new source files.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::toJS): Updated for new collection type names.
-
- * dom/Document.cpp:
- (WebCore::Document::createAttribute): Added. No longer inline.
- (WebCore::Document::images): Updated for new collection type names.
- (WebCore::Document::applets): Ditto.
- (WebCore::Document::embeds): Ditto.
- (WebCore::Document::plugins): Ditto.
- (WebCore::Document::objects): Ditto.
- (WebCore::Document::scripts): Ditto.
- (WebCore::Document::links): Ditto.
- (WebCore::Document::forms): Ditto.
- (WebCore::Document::anchors): Ditto.
- (WebCore::Document::all): Ditto.
- (WebCore::Document::windowNamedItems): Ditto.
- (WebCore::Document::documentNamedItems): Ditto.
- (WebCore::Document::nameCollectionInfo): Ditto.
-
- * dom/Document.h: Changed around includes and forward declarations.
- Updated for changes to collection types.
-
- * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
-
- * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
- Contains the class that used to be HTMLCollection::CollectionInfo.
- * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
- Ditto.
-
- * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
- Has the enum that used to be HTMLCollection::Type.
-
- * html/HTMLCollection.cpp:
- (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
- (WebCore::HTMLCollection::create): Ditto.
- (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
- (WebCore::HTMLCollection::itemAfter): Ditto.
- * html/HTMLCollection.h: Ditto.
-
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::children): Updated for new collection type names.
- * html/HTMLFormCollection.cpp:
- (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
- (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
- * html/HTMLFormCollection.h: Ditto.
- * html/HTMLFormElement.h: Ditto.
- * html/HTMLMapElement.cpp:
- (WebCore::HTMLMapElement::areas): Ditto.
- * html/HTMLNameCollection.cpp:
- (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
- * html/HTMLNameCollection.h:
- (WebCore::HTMLNameCollection::create): Ditto.
- * html/HTMLSelectElement.h:
- (WebCore::HTMLSelectElement::collectionInfo): Ditto.
- * html/HTMLTableElement.cpp:
- (WebCore::HTMLTableElement::tBodies):Ditto.
- * html/HTMLTableRowElement.cpp:
- (WebCore::HTMLTableRowElement::cells):Ditto.
- * html/HTMLTableRowsCollection.cpp:
- (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
- * html/HTMLTableSectionElement.cpp:
- (WebCore::HTMLTableSectionElement::rows): Ditto.
-
- * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
- * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
- * css/CSSStyleSelector.cpp: Ditto.
- * dom/Element.cpp: Ditto.
- * dom/InputElement.cpp: Ditto.
- * dom/NamedAttrMap.cpp: Ditto.
- * dom/NamedMappedAttrMap.cpp: Ditto.
- * dom/Node.cpp: Ditto.
- * dom/StyledElement.cpp: Ditto.
- * dom/StyledElement.h: Ditto.
- * editing/ApplyStyleCommand.cpp: Ditto.
- * editing/DeleteSelectionCommand.cpp: Ditto.
- * editing/Editor.cpp: Ditto.
- * editing/EditorCommand.cpp: Ditto.
- * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
- * editing/ReplaceSelectionCommand.cpp: Ditto.
- * editing/markup.cpp: Ditto.
- * html/CanvasRenderingContext2D.cpp: Ditto.
- * html/HTMLAnchorElement.cpp: Ditto.
- * html/HTMLAppletElement.cpp: Ditto.
- * html/HTMLAreaElement.cpp: Ditto.
- * html/HTMLBRElement.cpp: Ditto.
- * html/HTMLBaseElement.cpp: Ditto.
- * html/HTMLBodyElement.cpp: Ditto.
- * html/HTMLButtonElement.cpp: Ditto.
- * html/HTMLCanvasElement.cpp: Ditto.
- * html/HTMLDivElement.cpp: Ditto.
- * html/HTMLEmbedElement.cpp: Ditto.
- * html/HTMLFontElement.cpp: Ditto.
- * html/HTMLFormControlElement.cpp: Ditto.
- * html/HTMLFormElement.cpp: Ditto.
- * html/HTMLFrameElement.cpp: Ditto.
- * html/HTMLFrameElementBase.cpp: Ditto.
- * html/HTMLFrameSetElement.cpp: Ditto.
- * html/HTMLHRElement.cpp: Ditto.
- * html/HTMLIFrameElement.cpp: Ditto.
- * html/HTMLImageElement.cpp: Ditto.
- * html/HTMLInputElement.cpp: Ditto.
- * html/HTMLIsIndexElement.cpp: Ditto.
- * html/HTMLKeygenElement.cpp: Ditto.
- * html/HTMLLIElement.cpp: Ditto.
- * html/HTMLLinkElement.cpp: Ditto.
- * html/HTMLMarqueeElement.cpp: Ditto.
- * html/HTMLMetaElement.cpp: Ditto.
- * html/HTMLOListElement.cpp: Ditto.
- * html/HTMLObjectElement.cpp: Ditto.
- * html/HTMLOptionElement.cpp: Ditto.
- * html/HTMLParagraphElement.cpp: Ditto.
- * html/HTMLParamElement.cpp: Ditto.
- * html/HTMLPlugInElement.cpp: Ditto.
- * html/HTMLPreElement.cpp: Ditto.
- * html/HTMLScriptElement.cpp: Ditto.
- * html/HTMLSelectElement.cpp: Ditto.
- * html/HTMLStyleElement.cpp: Ditto.
- * html/HTMLTableCaptionElement.cpp: Ditto.
- * html/HTMLTableCellElement.cpp: Ditto.
- * html/HTMLTableColElement.cpp: Ditto.
- * html/HTMLTablePartElement.cpp: Ditto.
- * html/HTMLTextAreaElement.cpp: Ditto.
- * html/HTMLTokenizer.cpp: Ditto.
- * html/HTMLUListElement.cpp: Ditto.
- * html/HTMLVideoElement.cpp: Ditto.
- * html/HTMLViewSourceDocument.cpp: Ditto.
- * loader/ImageDocument.cpp: Ditto.
- * page/Frame.cpp: Ditto.
- * rendering/RenderTreeAsText.cpp: Ditto.
- * svg/SVGAElement.cpp: Ditto.
- * svg/SVGAnimateMotionElement.cpp: Ditto.
- * svg/SVGAnimateTransformElement.cpp: Ditto.
- * svg/SVGAnimationElement.cpp: Ditto.
- * svg/SVGCircleElement.cpp: Ditto.
- * svg/SVGClipPathElement.cpp: Ditto.
- * svg/SVGCursorElement.cpp: Ditto.
- * svg/SVGElement.cpp: Ditto.
- * svg/SVGEllipseElement.cpp: Ditto.
- * svg/SVGExternalResourcesRequired.cpp: Ditto.
- * svg/SVGFitToViewBox.cpp: Ditto.
- * svg/SVGFontFaceElement.cpp: Ditto.
- * svg/SVGFontFaceUriElement.cpp: Ditto.
- * svg/SVGForeignObjectElement.cpp: Ditto.
- * svg/SVGGlyphElement.cpp: Ditto.
- * svg/SVGGradientElement.cpp: Ditto.
- * svg/SVGImageElement.cpp: Ditto.
- * svg/SVGLangSpace.cpp: Ditto.
- * svg/SVGLineElement.cpp: Ditto.
- * svg/SVGLinearGradientElement.cpp: Ditto.
- * svg/SVGMarkerElement.cpp: Ditto.
- * svg/SVGMaskElement.cpp: Ditto.
- * svg/SVGPathElement.cpp: Ditto.
- * svg/SVGPatternElement.cpp: Ditto.
- * svg/SVGPolyElement.cpp: Ditto.
- * svg/SVGRadialGradientElement.cpp: Ditto.
- * svg/SVGRectElement.cpp: Ditto.
- * svg/SVGSVGElement.cpp: Ditto.
- * svg/SVGScriptElement.cpp: Ditto.
- * svg/SVGStopElement.cpp: Ditto.
- * svg/SVGStyleElement.cpp: Ditto.
- * svg/SVGStyledElement.cpp: Ditto.
- * svg/SVGStyledTransformableElement.cpp: Ditto.
- * svg/SVGTests.cpp: Ditto.
- * svg/SVGTextContentElement.cpp: Ditto.
- * svg/SVGTextElement.cpp: Ditto.
- * svg/SVGTextPathElement.cpp: Ditto.
- * svg/SVGTextPositioningElement.cpp: Ditto.
- * svg/SVGURIReference.cpp: Ditto.
- * svg/SVGUseElement.cpp: Ditto.
- * svg/SVGViewElement.cpp: Ditto.
- * svg/animation/SVGSMILElement.cpp: Ditto.
- * xml/XPathStep.cpp: Ditto.
-
-2009-05-04 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
- https://bugs.webkit.org/show_bug.cgi?id=25520
-
- * inspector/front-end/inspector.js:
- (WebInspector.loaded):
-
-2009-05-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window
-
- DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
- particularly sticky behavior.
-
- If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
- prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
- from the WebArchive.
-
- In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
- loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.
-
- When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
- ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
- WebResource is returned, and the client thinks the subresource doesn't exist even though it does.
-
- This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the
- ArchiveResource.
-
-2009-05-04 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=25545
- Bug 25545: HTMLMediaElement: display anamorphic video correctly
-
- Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
- and displayed correctly.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't
- filled beyond capacity.
-
-2009-05-03 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
- Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load
-
- Only the first plug-in in a PluginDocument can use the main resource data. For all
- subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
- out for the real Flash plug-in, we need to load the resource data in the same manner
- as for other embedded plug-ins.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadPlugin):
-
-2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
-
- Rubber-stamped by Ariya Hidayat.
-
- Update the qrc file for the Web Inspector in the Qt build
- with missing files.
-
- * inspector/front-end/WebKit.qrc:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderSVGInline.cpp:
- (WebCore::RenderSVGInline::absoluteRects):
- (WebCore::RenderSVGInline::absoluteQuads):
- * rendering/RenderSVGInline.h:
- * rendering/RenderSVGTSpan.cpp:
- * rendering/RenderSVGTSpan.h:
- * rendering/RenderSVGTextPath.cpp:
- * rendering/RenderSVGTextPath.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Move RenderSVGText off of localToAbsolute()
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Remove broken absoluteTransform() code from RenderSVGInlineText
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- This improved SVG text focus rings.
- This also improved SVG.getScreenCTM() results.
-
- SVGSVGElement::getScreenCTM was passing "true" for the second argument in
- localToAbsolute, which is "fixed" it meant to pass "true" for the
- third argument (useTransforms). That change alone caused no layout test changes, however
- before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
-
- mapLocalToContainer implementations really should be shared,
- but I'll do that in a later patch.
-
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::styleDidChange):
- (WebCore::RenderSVGInlineText::absoluteQuads):
- (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::mapLocalToContainer):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::mapLocalToContainer):
- * rendering/RenderSVGText.h:
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::getScreenCTM):
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Remove dead code from RenderPath
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderPath.cpp:
- * rendering/RenderPath.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Share layout code between RenderSVGViewportContainer and RenderSVGContainer
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::calcViewport):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::applyViewportClip):
- * rendering/RenderSVGViewportContainer.h:
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Remove redundant disableLayoutState() calls
- https://bugs.webkit.org/show_bug.cgi?id=25532
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::layout):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::layout):
-
-2009-05-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Simplify RenderForeignObject::paint and fix a repaint bug.
- Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
- https://bugs.webkit.org/show_bug.cgi?id=16939
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::paint):
-
-2009-05-03 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Test: editing/spelling/spellcheck-attribute.html
-
- Bug 14552: Add a way to disable spell checking for specific element
- https://bugs.webkit.org/show_bug.cgi?id=14552
-
- For compatibility with Firefox, this code ascends the DOM tree when an element does
- not have its "spellcheck" attribute.
-
- * editing/Editor.cpp:
- (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
- attribute of an element before calling a spell checker or a grammar checker.
- * html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
-
-2009-05-03 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back in one last time (I hope).
-
-2009-05-03 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back out. It still breaks windows.
-
-2009-05-03 Sam Weinig <sam@webkit.org>
-
- Roll JSC API number marshaling back in.
-
-2009-05-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - another fix for <rdar://problem/6617298> Typing delete on an unquoted
- blank line unquotes the preceding, quoted blank line
-
- Test: editing/deleting/type-delete-after-quote-2.html
-
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize
- m_startsAtEmptyLine.
- (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the
- selection starts at an empty line, do not prevent the merging of blocks.
- This is what allows the text after the line break to be merged into the
- block containing the line break. Also set m_startsAtEmptyLine to true.
- (WebCore::DeleteSelectionCommand::mergeParagraphs): If
- m_startsAtEmptyLine is true, create a placeholder BR to serve as the
- merge destination.
- * editing/DeleteSelectionCommand.h:
-
-2009-05-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Simplified null-ish JSValues.
-
- Replaced calls to noValue() with calls to JSValue() (which is what
- noValue() returned). Removed noValue().
-
- Removed "JSValue()" initialiazers, since default construction happens...
- by default.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::setDOMException):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::handleEvent):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/ScriptValue.h:
- (WebCore::ScriptValue::ScriptValue):
- (WebCore::ScriptValue::hasNoValue):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::invokeMethod):
- * bridge/jni/jni_runtime.cpp:
- (JavaField::dispatchValueFromInstance):
- (JavaField::dispatchSetValueToInstance):
- * bridge/runtime.h:
- (JSC::Bindings::Instance::invokeConstruct):
-
-2009-05-02 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)
-
- Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::suspendPostAttachCallbacks):
- (WebCore::ContainerNode::resumePostAttachCallbacks):
- (WebCore::ContainerNode::attach):
- * dom/Element.cpp:
- (WebCore::Element::attach):
- * loader/loader.cpp:
- (WebCore::Loader::Loader):
- (WebCore::Loader::servePendingRequests):
- (WebCore::Loader::suspendPendingRequests):
- (WebCore::Loader::resumePendingRequests):
- (WebCore::Loader::Host::servePendingRequests):
- * loader/loader.h:
- (WebCore::Loader::isSuspendingPendingRequests):
-
-2009-05-02 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
- https://bugs.webkit.org/show_bug.cgi?id=25352
- rdar://problem/6823239
-
- Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
-
- * platform/network/HTTPParsers.cpp:
- (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.
-
-2009-05-02 Darin Adler <darin@apple.com>
-
- Reviewed by Brady Eidson.
-
- Bug 25491: WebFrame leak when a subframe removes itself
- https://bugs.webkit.org/show_bug.cgi?id=25491
- rdar://problem/6833859
-
- Test: fast/loading/subframe-removes-itself.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true,
- treat load as complete, even if isLoadingInAPISense is still returning true.
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Roll out JavaScriptCore API number marshaling.
-
- * bindings/js/ScriptValue.cpp:
- (WebCore::ScriptValue::isEqual):
- * inspector/JavaScriptProfile.cpp:
- (WebCore::getHeadCallback):
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::getChildren):
- (WebCore::getParent):
- (WebCore::getHead):
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Fix build.
-
- * workers/WorkerContext.idl:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Cleanup workers code a bit.
-
- * bindings/js/JSWorkerContextBase.cpp:
- (WebCore::toJS):
- * bindings/js/JSWorkerContextBase.h:
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::customGetOwnPropertySlot):
- * workers/WorkerContext.h:
- (WebCore::WorkerContext::toWorkerContext):
- (WebCore::WorkerContext::self):
- (WebCore::WorkerContext::setOnmessage):
- (WebCore::WorkerContext::onmessage):
- * workers/WorkerContext.idl:
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- A little clean up.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createJavaAppletWidget):
-
-2009-05-01 Sam Weinig <sam@webkit.org>
-
- Fix the build.
-
- * bindings/js/ScriptValue.cpp:
- (WebCore::ScriptValue::isEqual):
- * inspector/JavaScriptProfile.cpp:
- (WebCore::getHeadCallback):
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::getChildren):
- (WebCore::getParent):
- (WebCore::getHead):
-
-2009-05-01 Brady Eidson <beidson@apple.com>
-
- Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig
-
- Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail
-
- * bindings/objc/DOMHTML.mm:
- (-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
-
-2009-05-01 Geoffrey Garen <ggaren@apple.com>
-
- Rubber Stamped by Sam Weinig.
-
- Renamed JSValuePtr => JSValue.
-
- * bindings/js/JSAttrCustom.cpp:
- (WebCore::JSAttr::setValue):
- * bindings/js/JSCDATASectionCustom.cpp:
- (WebCore::toJSNewlyCreated):
- * bindings/js/JSCSSRuleCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter):
- (WebCore::JSCSSStyleDeclaration::customPut):
- * bindings/js/JSCSSValueCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::toJS):
- (WebCore::toHTMLCanvasStyle):
- (WebCore::JSCanvasRenderingContext2D::strokeStyle):
- (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
- (WebCore::JSCanvasRenderingContext2D::fillStyle):
- (WebCore::JSCanvasRenderingContext2D::setFillStyle):
- (WebCore::JSCanvasRenderingContext2D::setFillColor):
- (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
- (WebCore::JSCanvasRenderingContext2D::strokeRect):
- (WebCore::JSCanvasRenderingContext2D::drawImage):
- (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
- (WebCore::JSCanvasRenderingContext2D::setShadow):
- (WebCore::JSCanvasRenderingContext2D::createPattern):
- (WebCore::JSCanvasRenderingContext2D::putImageData):
- (WebCore::JSCanvasRenderingContext2D::fillText):
- (WebCore::JSCanvasRenderingContext2D::strokeText):
- * bindings/js/JSClipboardCustom.cpp:
- (WebCore::JSClipboard::types):
- (WebCore::JSClipboard::clearData):
- (WebCore::JSClipboard::getData):
- (WebCore::JSClipboard::setData):
- (WebCore::JSClipboard::setDragImage):
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::profiles):
- * bindings/js/JSCoordinatesCustom.cpp:
- (WebCore::JSCoordinates::altitude):
- (WebCore::JSCoordinates::altitudeAccuracy):
- (WebCore::JSCoordinates::heading):
- (WebCore::JSCoordinates::speed):
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- (WebCore::toVoidCallback):
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::create):
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSCustomXPathNSResolver.h:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::hasItem):
- (WebCore::JSDOMApplicationCache::add):
- (WebCore::JSDOMApplicationCache::remove):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::jsStringOrNull):
- (WebCore::jsOwnedStringOrNull):
- (WebCore::jsStringOrUndefined):
- (WebCore::jsStringOrFalse):
- (WebCore::valueToStringWithNullCheck):
- (WebCore::valueToStringWithUndefinedOrNullCheck):
- (WebCore::reportException):
- (WebCore::reportCurrentException):
- (WebCore::setDOMException):
- (WebCore::objectToStringFunctionGetter):
- * bindings/js/JSDOMBinding.h:
- (WebCore::getDOMObjectWrapper):
- (WebCore::getDOMNodeWrapper):
- (WebCore::toJS):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMStringListCustom.cpp:
- (WebCore::JSDOMStringList::getByIndex):
- (WebCore::JSDOMStringList::item):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::childFrameGetter):
- (WebCore::JSDOMWindowBase::indexGetter):
- (WebCore::JSDOMWindowBase::namedItemGetter):
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- (WebCore::JSDOMWindowBase::put):
- (WebCore::JSDOMWindowBase::setReturnValueSlot):
- (WebCore::toJS):
- (WebCore::toJSDOMWindow):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::lookupGetter):
- (WebCore::JSDOMWindow::lookupSetter):
- (WebCore::JSDOMWindow::history):
- (WebCore::JSDOMWindow::location):
- (WebCore::JSDOMWindow::setLocation):
- (WebCore::JSDOMWindow::crypto):
- (WebCore::JSDOMWindow::event):
- (WebCore::JSDOMWindow::image):
- (WebCore::JSDOMWindow::option):
- (WebCore::JSDOMWindow::audio):
- (WebCore::JSDOMWindow::webKitPoint):
- (WebCore::JSDOMWindow::webKitCSSMatrix):
- (WebCore::JSDOMWindow::xmlHttpRequest):
- (WebCore::JSDOMWindow::xsltProcessor):
- (WebCore::JSDOMWindow::messageChannel):
- (WebCore::JSDOMWindow::worker):
- (WebCore::createWindow):
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- (WebCore::JSDOMWindow::postMessage):
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::setInterval):
- (WebCore::JSDOMWindow::atob):
- (WebCore::JSDOMWindow::btoa):
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- (WebCore::toDOMWindow):
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::nonCachingStaticFunctionGetter):
- (WebCore::JSDOMWindow::customPut):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::put):
- (WebCore::JSDOMWindowShell::putWithAttributes):
- (WebCore::JSDOMWindowShell::lookupGetter):
- (WebCore::JSDOMWindowShell::lookupSetter):
- (WebCore::toJS):
- * bindings/js/JSDOMWindowShell.h:
- (WebCore::JSDOMWindowShell::createStructure):
- * bindings/js/JSDatabaseCustom.cpp:
- (WebCore::JSDatabase::changeVersion):
- (WebCore::JSDatabase::transaction):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::location):
- (WebCore::JSDocument::setLocation):
- (WebCore::toJS):
- * bindings/js/JSElementCustom.cpp:
- (WebCore::JSElement::setAttribute):
- (WebCore::JSElement::setAttributeNode):
- (WebCore::JSElement::setAttributeNS):
- (WebCore::JSElement::setAttributeNodeNS):
- (WebCore::toJSNewlyCreated):
- * bindings/js/JSEventCustom.cpp:
- (WebCore::JSEvent::clipboardData):
- (WebCore::toJS):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::handleEvent):
- * bindings/js/JSEventTarget.cpp:
- (WebCore::toJS):
- (WebCore::toEventTarget):
- * bindings/js/JSEventTarget.h:
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::createPositionOptions):
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::createStructure):
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- (WebCore::JSHTMLAppletElement::customPut):
- (WebCore::JSHTMLAppletElement::nameGetter):
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::getNamedItems):
- (WebCore::callHTMLCollection):
- (WebCore::JSHTMLCollection::nameGetter):
- (WebCore::JSHTMLCollection::item):
- (WebCore::JSHTMLCollection::namedItem):
- (WebCore::toJS):
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::JSHTMLDocument::nameGetter):
- (WebCore::JSHTMLDocument::all):
- (WebCore::JSHTMLDocument::setAll):
- (WebCore::JSHTMLDocument::open):
- (WebCore::JSHTMLDocument::write):
- (WebCore::JSHTMLDocument::writeln):
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- (WebCore::JSHTMLEmbedElement::customPut):
- (WebCore::JSHTMLEmbedElement::nameGetter):
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::nameGetter):
- (WebCore::JSHTMLFormElement::submit):
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- (WebCore::JSHTMLFrameElement::setSrc):
- (WebCore::JSHTMLFrameElement::setLocation):
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- (WebCore::JSHTMLFrameSetElement::nameGetter):
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- (WebCore::JSHTMLIFrameElement::setSrc):
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::selectionStart):
- (WebCore::JSHTMLInputElement::setSelectionStart):
- (WebCore::JSHTMLInputElement::selectionEnd):
- (WebCore::JSHTMLInputElement::setSelectionEnd):
- (WebCore::JSHTMLInputElement::setSelectionRange):
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- (WebCore::JSHTMLObjectElement::customPut):
- (WebCore::JSHTMLObjectElement::nameGetter):
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- (WebCore::JSHTMLOptionsCollection::length):
- (WebCore::JSHTMLOptionsCollection::setLength):
- (WebCore::JSHTMLOptionsCollection::indexSetter):
- (WebCore::JSHTMLOptionsCollection::add):
- (WebCore::JSHTMLOptionsCollection::remove):
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- (WebCore::JSHTMLSelectElement::remove):
- (WebCore::selectIndexSetter):
- (WebCore::JSHTMLSelectElement::indexSetter):
- * bindings/js/JSHTMLSelectElementCustom.h:
- * bindings/js/JSHistoryCustom.cpp:
- (WebCore::nonCachingStaticBackFunctionGetter):
- (WebCore::nonCachingStaticForwardFunctionGetter):
- (WebCore::nonCachingStaticGoFunctionGetter):
- (WebCore::JSHistory::customPut):
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
- (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- * bindings/js/JSInspectedObjectWrapper.h:
- (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap):
- (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
- * bindings/js/JSInspectorCallbackWrapper.h:
- (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::highlightDOMNode):
- (WebCore::JSInspectorController::addResourceSourceToFrame):
- (WebCore::JSInspectorController::addSourceToFrame):
- (WebCore::JSInspectorController::getResourceDocumentNode):
- (WebCore::JSInspectorController::search):
- (WebCore::JSInspectorController::databaseTableNames):
- (WebCore::JSInspectorController::inspectedWindow):
- (WebCore::JSInspectorController::setting):
- (WebCore::JSInspectorController::setSetting):
- (WebCore::JSInspectorController::wrapCallback):
- (WebCore::JSInspectorController::currentCallFrame):
- (WebCore::JSInspectorController::profiles):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate):
- (WebCore::JSJavaScriptCallFrame::thisObject):
- (WebCore::JSJavaScriptCallFrame::type):
- (WebCore::JSJavaScriptCallFrame::scopeChain):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::nonCachingStaticReplaceFunctionGetter):
- (WebCore::nonCachingStaticReloadFunctionGetter):
- (WebCore::nonCachingStaticAssignFunctionGetter):
- (WebCore::JSLocation::customPut):
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::setProtocol):
- (WebCore::JSLocation::setHost):
- (WebCore::JSLocation::setHostname):
- (WebCore::JSLocation::setPort):
- (WebCore::JSLocation::setPathname):
- (WebCore::JSLocation::setSearch):
- (WebCore::JSLocation::setHash):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::reload):
- (WebCore::JSLocation::assign):
- (WebCore::JSLocation::toString):
- (WebCore::JSLocationPrototype::customPut):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- (WebCore::JSMimeTypeArray::nameGetter):
- * bindings/js/JSNamedNodeMapCustom.cpp:
- (WebCore::JSNamedNodeMap::nameGetter):
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::lengthGetter):
- (WebCore::JSNamedNodesCollection::indexGetter):
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createStructure):
- * bindings/js/JSNavigatorCustom.cpp:
- (WebCore::needsYouTubeQuirk):
- (WebCore::JSNavigator::appVersion):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::insertBefore):
- (WebCore::JSNode::replaceChild):
- (WebCore::JSNode::removeChild):
- (WebCore::JSNode::appendChild):
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- (WebCore::createWrapper):
- (WebCore::toJSNewlyCreated):
- (WebCore::toJS):
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/JSNodeFilterCondition.h:
- (WebCore::JSNodeFilterCondition::create):
- * bindings/js/JSNodeFilterCustom.cpp:
- (WebCore::JSNodeFilter::acceptNode):
- (WebCore::toNodeFilter):
- * bindings/js/JSNodeIteratorCustom.cpp:
- (WebCore::JSNodeIterator::nextNode):
- (WebCore::JSNodeIterator::previousNode):
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::callNodeList):
- (WebCore::JSNodeList::nameGetter):
- * bindings/js/JSPluginArrayCustom.cpp:
- (WebCore::JSPluginArray::nameGetter):
- * bindings/js/JSPluginCustom.cpp:
- (WebCore::JSPlugin::nameGetter):
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::runtimeObjectGetter):
- (WebCore::runtimeObjectPropertyGetter):
- (WebCore::runtimeObjectCustomPut):
- (WebCore::callPlugin):
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::asWrapper):
- (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
- (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
- (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
- (WebCore::JSQuarantinedObjectWrapper::put):
- (WebCore::JSQuarantinedObjectWrapper::construct):
- (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- (WebCore::JSQuarantinedObjectWrapper::call):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::createStructure):
- * bindings/js/JSRGBColor.cpp:
- (WebCore::getJSRGBColor):
- (jsRGBColorRed):
- (jsRGBColorGreen):
- (jsRGBColorBlue):
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::createStructure):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item):
- * bindings/js/JSSQLTransactionCustom.cpp:
- (WebCore::JSSQLTransaction::executeSql):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- (WebCore::toJS):
- * bindings/js/JSSVGLengthCustom.cpp:
- (WebCore::JSSVGLength::value):
- (WebCore::JSSVGLength::convertToSpecifiedUnits):
- * bindings/js/JSSVGMatrixCustom.cpp:
- (WebCore::JSSVGMatrix::inverse):
- (WebCore::JSSVGMatrix::rotateFromVector):
- * bindings/js/JSSVGPathSegCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSSVGPathSegListCustom.cpp:
- (WebCore::JSSVGPathSegList::clear):
- (WebCore::JSSVGPathSegList::initialize):
- (WebCore::JSSVGPathSegList::getItem):
- (WebCore::JSSVGPathSegList::insertItemBefore):
- (WebCore::JSSVGPathSegList::replaceItem):
- (WebCore::JSSVGPathSegList::removeItem):
- (WebCore::JSSVGPathSegList::appendItem):
- * bindings/js/JSSVGPointListCustom.cpp:
- (WebCore::finishGetter):
- (WebCore::finishSetter):
- (WebCore::finishSetterReadOnlyResult):
- (WebCore::JSSVGPointList::clear):
- (WebCore::JSSVGPointList::initialize):
- (WebCore::JSSVGPointList::getItem):
- (WebCore::JSSVGPointList::insertItemBefore):
- (WebCore::JSSVGPointList::replaceItem):
- (WebCore::JSSVGPointList::removeItem):
- (WebCore::JSSVGPointList::appendItem):
- * bindings/js/JSSVGTransformListCustom.cpp:
- (WebCore::finishGetter):
- (WebCore::finishSetter):
- (WebCore::finishSetterReadOnlyResult):
- (WebCore::JSSVGTransformList::clear):
- (WebCore::JSSVGTransformList::initialize):
- (WebCore::JSSVGTransformList::getItem):
- (WebCore::JSSVGTransformList::insertItemBefore):
- (WebCore::JSSVGTransformList::replaceItem):
- (WebCore::JSSVGTransformList::removeItem):
- (WebCore::JSSVGTransformList::appendItem):
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::nameGetter):
- (WebCore::JSStorage::deleteProperty):
- (WebCore::JSStorage::customPut):
- * bindings/js/JSStyleSheetCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSStyleSheetListCustom.cpp:
- (WebCore::JSStyleSheetList::nameGetter):
- * bindings/js/JSTextCustom.cpp:
- (WebCore::toJSNewlyCreated):
- * bindings/js/JSTreeWalkerCustom.cpp:
- (WebCore::JSTreeWalker::parentNode):
- (WebCore::JSTreeWalker::firstChild):
- (WebCore::JSTreeWalker::lastChild):
- (WebCore::JSTreeWalker::nextSibling):
- (WebCore::JSTreeWalker::previousSibling):
- (WebCore::JSTreeWalker::previousNode):
- (WebCore::JSTreeWalker::nextNode):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::self):
- (WebCore::JSWorkerContext::setSelf):
- (WebCore::JSWorkerContext::xmlHttpRequest):
- (WebCore::JSWorkerContext::importScripts):
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- (WebCore::JSWorkerContext::setTimeout):
- (WebCore::JSWorkerContext::setInterval):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::open):
- (WebCore::JSXMLHttpRequest::setRequestHeader):
- (WebCore::JSXMLHttpRequest::send):
- (WebCore::JSXMLHttpRequest::getResponseHeader):
- (WebCore::JSXMLHttpRequest::overrideMimeType):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- (WebCore::JSXMLHttpRequest::responseText):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/js/JSXSLTProcessorCustom.cpp:
- (WebCore::JSXSLTProcessor::importStylesheet):
- (WebCore::JSXSLTProcessor::transformToFragment):
- (WebCore::JSXSLTProcessor::transformToDocument):
- (WebCore::JSXSLTProcessor::setParameter):
- (WebCore::JSXSLTProcessor::getParameter):
- (WebCore::JSXSLTProcessor::removeParameter):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::create):
- (WebCore::ScheduledAction::ScheduledAction):
- (WebCore::ScheduledAction::executeFunctionInContext):
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptCallStack.cpp:
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptCallStack.h:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::jsObjectForPluginElement):
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::appendArgument):
- (WebCore::ScriptFunctionCall::call):
- (WebCore::ScriptFunctionCall::construct):
- * bindings/js/ScriptFunctionCall.h:
- * bindings/js/ScriptObject.cpp:
- (WebCore::ScriptGlobalObject::get):
- * bindings/js/ScriptValue.h:
- (WebCore::ScriptValue::ScriptValue):
- (WebCore::ScriptValue::jsValue):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- (-[WebScriptObject evaluateWebScript:]):
- (-[WebScriptObject valueForKey:]):
- (-[WebScriptObject webScriptValueAtIndex:]):
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- * bindings/objc/WebScriptObjectPrivate.h:
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Evaluate):
- (_NPN_GetProperty):
- (_NPN_HasMethod):
- (_NPN_Construct):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::invokeMethod):
- (JSC::Bindings::CInstance::invokeDefaultMethod):
- (JSC::Bindings::CInstance::invokeConstruct):
- (JSC::Bindings::CInstance::defaultValue):
- (JSC::Bindings::CInstance::stringValue):
- (JSC::Bindings::CInstance::numberValue):
- (JSC::Bindings::CInstance::booleanValue):
- (JSC::Bindings::CInstance::valueOf):
- * bridge/c/c_instance.h:
- * bridge/c/c_runtime.cpp:
- (JSC::Bindings::CField::valueFromInstance):
- (JSC::Bindings::CField::setValueToInstance):
- * bridge/c/c_runtime.h:
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertValueToNPVariant):
- (JSC::Bindings::convertNPVariantToValue):
- * bridge/c/c_utility.h:
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::stringValue):
- (JavaInstance::numberValue):
- (JavaInstance::booleanValue):
- (JavaInstance::invokeMethod):
- (JavaInstance::defaultValue):
- (JavaInstance::valueOf):
- * bridge/jni/jni_instance.h:
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::eval):
- (JavaJSObject::getMember):
- (JavaJSObject::getSlot):
- (JavaJSObject::convertValueToJObject):
- (JavaJSObject::convertJObjectToValue):
- * bridge/jni/jni_objc.mm:
- (JSC::Bindings::dispatchJNICall):
- * bridge/jni/jni_runtime.cpp:
- (JavaArray::convertJObjectToArray):
- (JavaField::dispatchValueFromInstance):
- (JavaField::valueFromInstance):
- (JavaField::dispatchSetValueToInstance):
- (JavaField::setValueToInstance):
- (JavaArray::setValueAt):
- (JavaArray::valueAt):
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- (JSC::Bindings::convertArrayInstanceToJavaArray):
- (JSC::Bindings::convertValueToJValue):
- * bridge/jni/jni_utility.h:
- * bridge/objc/WebScriptObject.h:
- * bridge/objc/objc_class.h:
- * bridge/objc/objc_class.mm:
- (JSC::Bindings::ObjcClass::fallbackObject):
- * bridge/objc/objc_instance.h:
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::invokeMethod):
- (ObjcInstance::invokeDefaultMethod):
- (ObjcInstance::setValueOfUndefinedField):
- (ObjcInstance::getValueOfUndefinedField):
- (ObjcInstance::defaultValue):
- (ObjcInstance::stringValue):
- (ObjcInstance::numberValue):
- (ObjcInstance::booleanValue):
- (ObjcInstance::valueOf):
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::ObjcField::valueFromInstance):
- (JSC::Bindings::convertValueToObjcObject):
- (JSC::Bindings::ObjcField::setValueToInstance):
- (JSC::Bindings::ObjcArray::setValueAt):
- (JSC::Bindings::ObjcArray::valueAt):
- (JSC::Bindings::ObjcFallbackObjectImp::put):
- (JSC::Bindings::callObjCFallbackObject):
- (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertValueToObjcValue):
- (JSC::Bindings::convertNSStringToString):
- (JSC::Bindings::convertObjcValueToValue):
- * bridge/runtime.h:
- (JSC::Bindings::Class::fallbackObject):
- (JSC::Bindings::Instance::setValueOfUndefinedField):
- (JSC::Bindings::Instance::invokeDefaultMethod):
- (JSC::Bindings::Instance::invokeConstruct):
- (JSC::Bindings::Instance::put):
- * bridge/runtime_array.cpp:
- (JSC::RuntimeArray::lengthGetter):
- (JSC::RuntimeArray::indexGetter):
- (JSC::RuntimeArray::put):
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::createStructure):
- * bridge/runtime_method.cpp:
- (JSC::RuntimeMethod::lengthGetter):
- (JSC::callRuntimeMethod):
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createStructure):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::fallbackObjectGetter):
- (JSC::RuntimeObjectImp::fieldGetter):
- (JSC::RuntimeObjectImp::methodGetter):
- (JSC::RuntimeObjectImp::put):
- (JSC::RuntimeObjectImp::defaultValue):
- (JSC::callRuntimeObject):
- (JSC::callRuntimeConstructor):
- * bridge/runtime_object.h:
- (JSC::RuntimeObjectImp::createStructure):
- * inspector/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::evaluate):
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptProfile.cpp:
- (WebCore::toJS):
- * inspector/JavaScriptProfile.h:
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::toJS):
- * inspector/JavaScriptProfileNode.h:
-
-2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25485
- Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
- which broke Chromium build.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to
- provide separate code paths for Qt and non-Qt ports. Also restored original
- order of execution.
-
-2009-05-01 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6839222>
- CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader
-
- After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
- return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
- which is why I've added the ASSERT.
-
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::didCancel):
-
-2009-05-01 Timothy Hatcher <timothy@apple.com>
-
- Disallow the deletion UI for elements that have any overflow clipping.
- Also disallow the UI for the body element it isn't practical to delete,
- and the deletion UI would be clipped.
-
- <rdar://problem/6840161> Deletion UI can be clipped by some
- elements (with overflow: hidden)
-
- Reviewed by Darin Adler.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
-
-2009-05-01 Timothy Hatcher <timothy@apple.com>
-
- Decrease the minimum height for deleteable elements to 16px, and increase the
- minimum width to 48px. This allows deleting shorter items like navigation bars.
-
- <rdar://problem/6840735> Deletion UI does not show up for short
- elements (22px or less)
-
- Reviewed by Adele Peterson.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
-
-2009-05-01 Timothy Hatcher <timothy@apple.com>
-
- Clean up the comments and logic in the code for picking a
- deleteable element for the deletion UI.
-
- Reviewed by Adele Peterson.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
-
-2009-05-01 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Adele Peterson and Darin Adler.
-
- <rdar://problem/4815598> Stuck in double spacing mode after pasting a
- paragraph with padding/margin (or table mode !)
-
- A lot of the issues in this bug were resolved on Mail's side by using
- WebKit to convert to plain text. This is the final issue, that floating
- style stays on copied nodes causing them to float when they are pasted
- which is not what the user intended.
-
- * editing/markup.cpp:
- (WebCore::removeExteriorStyles):
- (WebCore::):
- (WebCore::appendStartMarkup):
- (WebCore::getStartMarkup):
- (WebCore::createMarkup):
-
-2009-05-01 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- This is the only resource-related information that is available in InspectorController
- and is missing in the FrameLoaderClient.
-
- https://bugs.webkit.org/show_bug.cgi?id=25347
-
- * WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
- * dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
- (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- * loader/EmptyClients.h: Added stub implementation.
- (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
- * loader/FrameLoader.cpp: Call initiating dispatches.
- (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
- * loader/FrameLoader.h:
- * loader/FrameLoaderClient.h:
-
-2009-04-30 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
- To Do's in a Mail note (excessive recursion in mouse drag tracking)
-
- Oliver's recent change to dragging seems to have revealed a long-
- time bug in passSubframeEventToSubframe where we did not set
- m_sendingEventToSubview to true before calling
- handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
- that and adds ASSERTions around all of the places where
- m_sendingEventToSubview is set to true and then false to make sure
- we are not trampling its state.
-
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::eventLoopHandleMouseDragged):
- (WebCore::EventHandler::eventLoopHandleMouseUp):
- (WebCore::EventHandler::passSubframeEventToSubframe):
- (WebCore::EventHandler::passWheelEventToWidget):
-
-2009-04-30 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- MediaDocument falls back to plug-in unnecessarily
- https://bugs.webkit.org/show_bug.cgi?id=25504
- <rdar://problem/6844702>
-
- Don't allow harmless media types to cause a MediaDocument to fall
- back to PluginDocument.
-
- Test: media/video-document-types.html
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64,
- odsm, and sdsm to allowed track types.
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::disableUnsupportedTracks): Ditto.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add CHROMIUM guard to unfork Document.cpp
-
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode): Added guard.
-
-2009-04-30 David Kilzer <ddkilzer@apple.com>
-
- Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
-
- Reviewed by Geoff Garen.
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
- * html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
-
-2009-04-30 David Kilzer <ddkilzer@apple.com>
-
- Provide a mechanism to create a quirks delegate for HTMLParser
-
- Reviewed by David Hyatt.
-
- No tests since there is no change in behavior.
-
- HTMLParserQuirks.h defines an abstract base class that may be
- extended as needed. The ChromeClient::createHTMLParserQuirks()
- factory method should be used to return an HTMLParserQuirks
- subclassed object when needed.
-
- * WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
- using ChromeClient::createHTMLParserQuirks().
- (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
- set.
- (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
- m_parserQuirks is set.
- (WebCore::HTMLParser::insertNode): Call
- HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
- and return early if it returns false.
- (WebCore::HTMLParser::popBlock): Call
- HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
- return early if it returns false.
- * html/HTMLParser.h: Added m_parserQuirks.
- * html/HTMLParserQuirks.h: Added.
- (WebCore::HTMLParserQuirks::HTMLParserQuirks):
- (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
- * page/ChromeClient.h:
- (WebCore::ChromeClient::createHTMLParserQuirks): Added.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25492
- Add JSC guards around node wrapper cache calls. These are not used by V8.
-
- Also, remove JSDOMBinding include, which is brought in by ScriptController.
-
- * dom/Document.cpp:
- (WebCore::Document::~Document): Added JSC guard.
- * dom/Node.cpp:
- (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25493
- Remove debugger/profiler custom method stubs, catching V8 bindings up to
- http://trac.webkit.org/changeset/43072.
-
- * bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
-
-2009-04-30 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
-
- Use transform-aware quad methods when computing the boundingBoxRect for
- an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
-
- Test: accessibility/transformed-element.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::boundingBoxRect):
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, Chromium build fix.
-
- Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
-
- * bindings/v8/ScriptObject.cpp:
- (WebCore::ScriptGlobalObject::get): Renamed from getObject.
- (WebCore::ScriptGlobalObject::remove): Added.
- * bindings/v8/ScriptObject.h: Ditto.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25470
- Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
-
- * WebCore.pro: Fix copy-paste error.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25470
- Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
-
- * GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
- * WebCore.pro: Ditto.
-
-2009-04-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Change Position to pre-compute the AnchorType and store it.
- Also store a "legacy editing mode" bit on the Position.
- https://bugs.webkit.org/show_bug.cgi?id=24763
-
- The old Postion(node, offset) constructor creates legacy positions
- but there are new constructors to create explicitly anchored positions
- which the next patch will use.
-
- Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
- only affect legacy positions, we will be able to distinguish
- between [table, 1] and [table, after] in the code correctly!
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Position.cpp:
- (WebCore::Position::Position):
- (WebCore::Position::moveToPosition):
- (WebCore::Position::moveToOffset):
- (WebCore::Position::anchorTypeForLegacyEditingPosition):
- (WebCore::Position::element):
- * dom/Position.h:
- (WebCore::Position::):
- (WebCore::Position::Position):
- (WebCore::Position::anchorType):
- (WebCore::Position::deprecatedEditingOffset):
-
-2009-04-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
- collected even if the WorkerContext is still alive.
-
- Test: fast/workers/worker-context-gc.html
-
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::mark):
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::WorkerContext):
- (WebCore::WorkerContext::completeURL):
- (WebCore::WorkerContext::location):
- * workers/WorkerContext.h:
- (WebCore::WorkerContext::optionalNavigator):
- (WebCore::WorkerContext::optionalLocation):
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25470
- Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
-
- * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
- * WebCore.vcproj/build-generated-files.sh: Ditto.
- * bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
- * bindings/js/JSDOMWindowBase.cpp: Ditto.
- * bindings/js/JSInspectorControllerCustom.cpp: Ditto.
- * inspector/InspectorController.cpp: Moved profiler/debugger methods under
- ENABLE(JAVASCRIPT_DEBUGGER) flag.
- * inspector/InspectorController.h: Ditto.
- * inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
- * page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
-
-2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25275
- This patch snuck in a re-definition of a local.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
-
-2009-04-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix a leak introduced yesterday. Don't allocate a ScheduledAction
- if the toString()ing throws an exception.
-
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::create):
-
-2009-04-30 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25379
- <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
-
- Test: fast/forms/multiple-selected-options-innerHTML.html
-
- This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
- For normal HTML parsing, it is called immediately after an element is inserted, but for
- innerHTML, it is only called after the whole subtree is inserted into a document.
-
- It may make sense to harmonize these cases one day, but for now, I only made the minimal
- changes necessary to fix the bug.
-
- * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
- * html/HTMLSelectElement.h:
- Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
- which one to keep selected themselves, because their logic assumes normal parsing, with
- insertedIntoTree() called after each element is inserted.
-
-2009-04-30 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25342
- Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
-
- Chromium async/out-of-process version of WebInspector is currently not based on
- InspectorController. The reason was that we did not want to interfere with
- the unforking effort, yet wanted to experiment. So we came up with these
- agents concept that basically mimic InspectorController, but separating 'agent'
- nature from the 'transport'. Now that InspectorController is unforked, I am
- planning to bring these concepts into the WebKit land and use what we have in
- Chromium as a proof of concept / experimental playground.
-
- * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
- (WebCore::EmptyChromeClient::addMessageToConsole): ditto
- * page/ChromeClient.h: ditto
- * page/Console.cpp: Used new method signature.
- (WebCore::Console::addMessage): ditto
-
-2009-04-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=25476
- <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
- animation is jittery
-
- Reverted r42987.
-
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw):
-
-2009-04-30 Brady Eidson <beidson@apple.com>
-
- Reviewed by Maciej Stachowiak
-
- <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
- https://bugs.webkit.org/show_bug.cgi?id=21193
-
- Some websites use for attributes in script elements to specify events that the script
- should be run for. One example is greekembassy.org which has the following in their <head>:
-
- <script for=window event=onresize>
- location.reload(false);
- </script>
-
- Since we don't support the full for attribute syntax, we would just blissfully ignore the
- condition and execute the code unconditionally. This caused breakage on multiple real-world
- sites besides greekembassy.org.
-
- https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
- support for the for attribute in scripts. In the meantime it's best to not execute them
- unconditionally.
-
- Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html
-
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
- passed, only return true if there is no for attribute in the script element.
- * dom/ScriptElement.h:
-
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
- * html/HTMLScriptElement.h:
-
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
- attribute getters do for SVGScriptElement)
- * svg/SVGScriptElement.h:
-
-2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again
-
- https://bugs.webkit.org/show_bug.cgi?id=20952
-
- The QtWebKit port made the mistake of exposing a global history. This broke
- with the addition of PageGroup and LinkHash. This needs to be repaired
- for Qt4.5.
-
- Add a function to LinkHash.cpp that is resolving a URL. Use this
- function from within CSSStyleSelector to forward the url to the
- QWebHistoryInterface API.
-
- It is sad that there is a path within visitedLinkHash which is now
- doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
- and using QtWebKit types within WebCore is a layering violation as well.
-
- PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
- Qt4.6 a second version of the QWebHistoryInterface is going to be
- added which will fix things up.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
- * platform/LinkHash.cpp:
- (WebCore::visitedURL):
- (WebCore::visitedLinkHash):
- * platform/LinkHash.h:
-
-2009-04-30 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build.
-
- * platform/graphics/SimpleFontData.cpp: Don't use initCharWidths() for the Qt build.
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit): Instead initialize the average and
- max char widths from QFontMetrics.
-
-2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Unreview build fix after r43037.
-
- Use MarkedArgumentBuffer instead of ArgList.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtConnectionObject::execute):
-
-2009-04-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
- setTimeout should stringify non-string/non-function first arguments
-
- Test: fast/dom/Window/setTimeout-string-argument.html
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::setInterval):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::setTimeout):
- (WebCore::JSWorkerContext::setInterval):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::create):
- * bindings/js/ScheduledAction.h:
-
-2009-04-29 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser.
-
- - WebCore part of <rdar://problem/6609509> Select All and then Delete
- should put Mail editing back into the same state as a new message
-
- Test: editing/deleting/in-visibly-empty-root.html
-
- * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
- * editing/SelectionController.h:
- (WebCore::SelectionController::isAll): Added. Calls through to
- VisibleSelection.
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
- of the root editable element the selection is in, other than a
- placeholder. Returns true iff it did anything.
- (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
- visible position in the root editable element, but it has children other
- than a placeholder, remove those children.
- * editing/TypingCommand.h:
- * editing/VisiblePosition.h:
- Added a StayInEditableContent enum and a FIXME.
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::isAll): Added. Returns whether the
- selection encompasses all visible positions, either in the document or
- in the editable root.
- * editing/VisibleSelection.h:
-
-2009-04-29 Sam Weinig <sam@webkit.org>
-
- Fix style nit.
-
- * editing/visible_units.cpp:
- (WebCore::getLeafBoxesInLogicalOrder):
-
-2009-04-29 David Hyatt <hyatt@apple.com>
-
- Reviewed by Dan Bernstein.
-
- For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
- trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
- assertions.
-
- Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
- and not do it (which is basically what was happening before).
-
- * page/FrameView.cpp:
- (WebCore::FrameView::setContentsSize):
- (WebCore::FrameView::needsLayout):
-
-2009-04-29 Douglas Davidson <ddavidso@apple.com>
-
- Reviewed by Justin Garcia.
-
- <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
-
- Updates to the text checking code to enable text checking even if spellchecking is turned off
- and fix an off-by-one error in selection handling.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- (WebCore::Editor::markMisspellingsAndBadGrammar):
- * editing/Editor.h:
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::markMisspellingsAfterTyping):
-
-2009-04-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- Clean up ArgList to be a trivial type
-
- Start using MarkedArgumentBuffer to create argument lists for function calls
-
- * bindings/js/JSClipboardCustom.cpp:
- (WebCore::JSClipboard::types):
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::profiles):
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::handleEvent):
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::profiles):
- (WebCore::JSInspectorController::search):
- (WebCore::JSInspectorController::databaseTableNames):
- (WebCore::JSInspectorController::setting):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::scopeChain):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::construct):
- (WebCore::JSQuarantinedObjectWrapper::call):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::ScheduledAction):
- (WebCore::ScheduledAction::executeFunctionInContext):
- * bindings/js/ScriptFunctionCall.h:
- * bindings/objc/WebScriptObject.mm:
- (getListFromNSArray):
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- * bridge/NP_jsobject.cpp:
- (getListFromVariantArgs):
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Construct):
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::getListFromJArray):
-
-2009-04-29 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Fix m_offset uses added while I wasn't looking.
-
- * editing/visible_units.cpp:
- (WebCore::logicalStartPositionForLine):
- (WebCore::logicalEndPositionForLine):
-
-2009-04-29 Xiaomei Ji <xji@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=24168
- RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
-
- Test: editing/selection/home-end.html
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
- to logicalEndOfLine() when granularity is LineBoundary.
- (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
- to logicalEndOfLine() when granularity is LineBoundary
- (WebCore::SelectionController::modifyExtendingBackward): Change calling
- startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
- (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
- to logicalStartOfLine() when granularity is LineBoundary.
- * editing/visible_units.cpp:
- (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
- (WebCore::getLogicalStartBoxAndNode): Added.
- (WebCore::getLogicalEndBoxAndNode): Added.
- (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
- (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
- (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
- (WebCore::inSameLogicalLine): Added.
- (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
- * editing/visible_units.h:
-
-2009-04-29 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Make m_offset private and change all callers to use deprecatedEditingOffset().
- https://bugs.webkit.org/show_bug.cgi?id=25472
-
- Per Darin's suggestion, this was just a simple search replace
- of .m_offset with .deprecatedEditingOffset().
-
- There was one change in InsertParagraphSeparatorCommand::doApply to use
- Position::moveToOffset(0) instead of .m_offset = 0;
-
- * dom/Position.cpp:
- (WebCore::Position::rendersInDifferentPosition):
- (WebCore::Position::leadingWhitespacePosition):
- * dom/Position.h:
- (WebCore::Position::deprecatedEditingOffset):
- (WebCore::Position::moveToOffset):
- (WebCore::operator==):
- * dom/PositionIterator.h:
- (WebCore::PositionIterator::PositionIterator):
- * dom/Range.cpp:
- (WebCore::Range::create):
- (WebCore::Range::compareBoundaryPoints):
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
- (WebCore::ApplyStyleCommand::removeInlineStyle):
- (WebCore::ApplyStyleCommand::nodeFullySelected):
- (WebCore::ApplyStyleCommand::nodeFullyUnselected):
- (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
- (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
- (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- (WebCore::ApplyStyleCommand::joinChildTextNodes):
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::insertNodeAt):
- (WebCore::CompositeEditCommand::positionOutsideTabSpan):
- (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
- (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
- (WebCore::CompositeEditCommand::deleteInsignificantText):
- (WebCore::CompositeEditCommand::moveParagraphs):
- (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::updatePositionForNodeRemoval):
- (WebCore::updatePositionForTextRemoval):
- (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- (WebCore::DeleteSelectionCommand::fixupWhitespace):
- * editing/Editor.cpp:
- (WebCore::Editor::setComposition):
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::Editor::getCompositionSelection):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::performTrivialReplace):
- (WebCore::InsertTextCommand::input):
- (WebCore::InsertTextCommand::insertTab):
- * editing/MoveSelectionCommand.cpp:
- (WebCore::MoveSelectionCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::debugRenderer):
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::rangeFromLocationAndLength):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::characterAfter):
- (WebCore::VisiblePosition::debugPosition):
- (WebCore::makeRange):
- (WebCore::setStart):
- (WebCore::setEnd):
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::toNormalizedRange):
- (WebCore::makeSearchRange):
- (WebCore::VisibleSelection::debugPosition):
- (WebCore::VisibleSelection::showTreeForThis):
- * editing/htmlediting.cpp:
- (WebCore::comparePositions):
- (WebCore::rangeCompliantEquivalent):
- * editing/visible_units.cpp:
- (WebCore::previousBoundary):
- (WebCore::nextBoundary):
- (WebCore::startPositionForLine):
- (WebCore::startOfLine):
- (WebCore::endPositionForLine):
- (WebCore::nextLinePosition):
- (WebCore::startOfParagraph):
- (WebCore::endOfParagraph):
- (WebCore::logicalStartPositionForLine):
- (WebCore::logicalEndPositionForLine):
- * page/AccessibilityObject.cpp:
- (WebCore::updateAXLineStartForVisiblePosition):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::anchorOffset):
- (WebCore::DOMSelection::focusOffset):
- (WebCore::DOMSelection::baseOffset):
- (WebCore::DOMSelection::extentOffset):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEventSingleClick):
- * page/Frame.cpp:
- (WebCore::Frame::selectionLayoutChanged):
- * page/mac/AccessibilityObjectWrapper.mm:
- (textMarkerForVisiblePosition):
- (visiblePositionForTextMarker):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::indexForVisiblePosition):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::writeSelection):
-
-2009-04-29 Eric Seidel <eric@webkit.org>
-
- No review, rolling out a patch.
-
- Revert http://trac.webkit.org/changeset/43019
-
- New tests failed because I removed the tabs from them
- when landing (since we avoid tabs in WebKit files).
- I couldn't tell if the new results were correct with
- spaces or not.
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::modifyExtendingForward):
- (WebCore::SelectionController::modifyMovingForward):
- (WebCore::SelectionController::modifyExtendingBackward):
- (WebCore::SelectionController::modifyMovingBackward):
- * editing/visible_units.cpp:
- * editing/visible_units.h:
-
-2009-04-29 David Hyatt <hyatt@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
- when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
- flag on Mac.
-
- FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
- from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::setContentsSize):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::needsLayout):
- (WebCore::FrameView::setNeedsLayout):
- * page/FrameView.h:
-
-2009-04-29 Eric Seidel <eric@webkit.org>
-
- No review, rolling out a patch.
-
- Revert 43020 as it caused accessibility/lists.html to fail
- and no one is around to tell me if it's a progression or not.
-
- * page/AccessibilityObject.h:
- (WebCore::):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::roleValue):
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- * page/mac/AccessibilityObjectWrapper.mm:
- (RoleEntry::):
-
-2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
-
- Reviewed by Jon Honeycutt.
-
- Add a new accessibility role for list items. Part of
- http://bugs.webkit.org/show_id.cgi?id=20013
-
- Tests: platform/win/accessibility/listitem-role.html
-
- * page/AccessibilityObject.h:
- (WebCore::): Add ListItemRole to accessibilityRole enum.
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::roleValue):Return
- listItemRole when rendered object is a list item.
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute): Return
- true for ListItemRole, matching firefox.
- * page/mac/AccessibilityObjectWrapper.mm:
- (RoleEntry::): Map ListItemRole with NSAccessibilityGroupRole in
- MAC.
-
-2009-04-29 Xiaomei Ji <xji@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=24168
- RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
-
- Test: editing/selection/home-end.html
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
- to logicalEndOfLine() when granularity is LineBoundary.
- (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
- to logicalEndOfLine() when granularity is LineBoundary
- (WebCore::SelectionController::modifyExtendingBackward): Change calling
- startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
- (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
- to logicalStartOfLine() when granularity is LineBoundary.
- * editing/visible_units.cpp:
- (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
- (WebCore::getLogicalStartBoxAndNode): Added.
- (WebCore::getLogicalEndBoxAndNode): Added.
- (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
- (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
- (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
- (WebCore::inSameLogicalLine): Added.
- (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
- * editing/visible_units.h:
-
-2009-04-29 Mike Belshe <mike@belshe.com>
-
- Reviewed by Eric Seidel.
-
- Update location while page is loading.
- https://bugs.webkit.org/show_bug.cgi?id=21597
-
- Tested by:
- - fast/dom/location-new-window-no-crash
- - fast/dom/Window/window-open-pending-url
-
- * page/Location.cpp:
-
-2009-04-29 Feng Qian <feng@chromium.org>
-
- Reviewed by Darin Adler.
-
- Add Android port files to WebCore/platform.
- https://bugs.webkit.org/show_bug.cgi?id=23296
-
- * platform/android: Added.
- * platform/android/ClipboardAndroid.cpp: Added.
- * platform/android/ClipboardAndroid.h: Added.
-
-2009-04-29 Feng Qian <feng@chromium.org>
-
- Reviewed by Darin Adler.
-
- Add Android-specific files to the WebCore/page directory.
- https://bugs.webkit.org/show_bug.cgi?id=23295
-
- * page/android: Added.
- * page/android/DragControllerAndroid.cpp: Added.
- * page/android/EventHandlerAndroid.cpp: Added.
- * page/android/InspectorControllerAndroid.cpp: Added.
-
-2009-04-29 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Timothy Hatcher.
+ Reviewed by Jan Alonzo.
- Extract PageGroupLoadDeferrer from Chrome.cpp
+ [GTK] Don't use deprecated GTK+ symbols.
+ https://bugs.webkit.org/show_bug.cgi?id=26583
- * GNUmakefile.am: added PageGroupLoadDeferrer
- * WebCore.pro: ditto
- * WebCore.scons: ditto
- * WebCore.vcproj/WebCore.vcproj: ditto
- * WebCore.xcodeproj/project.pbxproj: ditto
- * WebCoreSources.bkl: ditto
- * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
- * page/PageGroupLoadDeferrer.cpp: Added.
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- * page/PageGroupLoadDeferrer.h: Added.
+ * plugins/gtk/gtk2xtbin.c:
+ (gtk_xtbin_class_init):
+ (gtk_xtbin_new):
+ (gtk_xtbin_destroy):
-2009-04-24 Ojan Vafai <ojan@chromium.org>
+2009-06-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
- Make textarea and text input metrics more closely match IEs.
-
- This involves:
- -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
- -set textarea width to cols*avgCharWidth
- -Make default CSS match IEs
- -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
-
- Those values for textarea and inputs were derived by doing a ton of manual
- testing of IE's width values for various textareas and fonts. On Windows we match
- IE exactly except for a couple fonts of the ~12 tested.
-
- To get the average and max character width of a font, we do the following
- for each platform:
- -Win: TextMetrics expose avgCharWidth and maxCharWidth
- -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
- maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
- -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
- maxCharWidth = max of avgCharWidth and m_ascent
- -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
- If either one is non-positive, then calculate the value using the Linux approach.
-
- Tests: fast/forms/text-control-intrinsic-widths.html
- fast/forms/textarea-metrics.html
- svg/custom/svg-fonts-in-text-controls.html
-
- * css/html4.css:
- * css/themeWin.css:
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData):
- (WebCore::SimpleFontData::initCharWidths):
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::maxCharWidth):
- (WebCore::SimpleFontData::avgCharWidth):
- * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataCGWin.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::initGDIFont):
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::calcPrefWidths):
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
-
-2009-04-29 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- * bindings/objc/DOMCSS.mm:
- (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore
- type and not the binding type.
-
-2009-04-29 John Abd-El-Malek <jam@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Reverted my previous change to add resetChromiumPluginCache().
- https://bugs.webkit.org/show_bug.cgi?id=25318
-
- * plugins/chromium/PluginDataChromium.cpp:
-
-2009-04-29 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
-
- Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
-
- Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
-
-2009-04-29 Alpha Lam <hclam@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25430
-
- Provide style sheet for UI controls of media elements for Chromium port.
-
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
-
-2009-04-29 John Abd-El-Malek <jam@chromium.org>
-
- Reviewed by Darin Adler.
-
- Expose sudden termination to Chromium port.
- https://bugs.webkit.org/show_bug.cgi?id=25457
-
- * platform/SuddenTermination.h:
- * platform/chromium/ChromiumBridge.h:
- * platform/chromium/SuddenTerminationChromium.cpp: Added.
- (WebCore::disableSuddenTermination):
- (WebCore::enableSuddenTermination):
-
-2009-04-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dimitri Glazkov.
-
- Remove unused EventListeners.
-
- * page/DOMWindow.idl:
-
-2009-04-29 Yury Semikhatsky <yurys@chromium.org>
-
- Reveal current execution line once SourceFrame content is loaded.
-
- https://bugs.webkit.org/show_bug.cgi?id=25448
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/SourceFrame.js:
- (WebInspector.SourceFrame.prototype._loaded):
-
-2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Simon Fraser.
-
- [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
- the default values of canvas attributes.
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
-
-2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::findMethodIndex): Removed exec param from at() call.
- (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
-
-2009-04-28 Geoffrey Garen <ggaren@apple.com>
-
- Rubber stamped by Beth Dakin.
-
- Missed one.
-
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-28 Geoffrey Garen <ggaren@apple.com>
-
- Rubber stamped by Beth Dakin.
-
- Removed scaffolding supporting dynamically converting between 32bit and
- 64bit value representations.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::constructAudio):
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::JSCanvasRenderingContext2D::setFillColor):
- (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
- (WebCore::JSCanvasRenderingContext2D::strokeRect):
- (WebCore::JSCanvasRenderingContext2D::drawImage):
- (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
- (WebCore::JSCanvasRenderingContext2D::setShadow):
- (WebCore::JSCanvasRenderingContext2D::createPattern):
- (WebCore::JSCanvasRenderingContext2D::putImageData):
- (WebCore::JSCanvasRenderingContext2D::fillText):
- (WebCore::JSCanvasRenderingContext2D::strokeText):
- * bindings/js/JSClipboardCustom.cpp:
- (WebCore::JSClipboard::clearData):
- (WebCore::JSClipboard::getData):
- (WebCore::JSClipboard::setData):
- (WebCore::JSClipboard::setDragImage):
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::hasItem):
- (WebCore::JSDOMApplicationCache::add):
- (WebCore::JSDOMApplicationCache::remove):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMStringListCustom.cpp:
- (WebCore::JSDOMStringList::item):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- (WebCore::JSDOMWindow::postMessage):
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::setInterval):
- (WebCore::JSDOMWindow::atob):
- (WebCore::JSDOMWindow::btoa):
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- * bindings/js/JSDatabaseCustom.cpp:
- (WebCore::JSDatabase::changeVersion):
- (WebCore::JSDatabase::transaction):
- * bindings/js/JSElementCustom.cpp:
- (WebCore::JSElement::setAttribute):
- (WebCore::JSElement::setAttributeNode):
- (WebCore::JSElement::setAttributeNS):
- (WebCore::JSElement::setAttributeNodeNS):
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::callHTMLCollection):
- (WebCore::JSHTMLCollection::item):
- (WebCore::JSHTMLCollection::namedItem):
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::documentWrite):
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::setSelectionRange):
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- (WebCore::JSHTMLOptionsCollection::add):
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- (WebCore::JSHTMLSelectElement::remove):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::constructImage):
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::highlightDOMNode):
- (WebCore::JSInspectorController::addResourceSourceToFrame):
- (WebCore::JSInspectorController::addSourceToFrame):
- (WebCore::JSInspectorController::getResourceDocumentNode):
- (WebCore::JSInspectorController::search):
- (WebCore::JSInspectorController::databaseTableNames):
- (WebCore::JSInspectorController::setting):
- (WebCore::JSInspectorController::setSetting):
- (WebCore::JSInspectorController::wrapCallback):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::assign):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::insertBefore):
- (WebCore::JSNode::replaceChild):
- (WebCore::JSNode::removeChild):
- (WebCore::JSNode::appendChild):
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- * bindings/js/JSNodeFilterCustom.cpp:
- (WebCore::JSNodeFilter::acceptNode):
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::callNodeList):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::constructHTMLOptionElement):
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::construct):
- (WebCore::JSQuarantinedObjectWrapper::call):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item):
- * bindings/js/JSSQLTransactionCustom.cpp:
- (WebCore::JSSQLTransaction::executeSql):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/js/JSSVGLengthCustom.cpp:
- (WebCore::JSSVGLength::convertToSpecifiedUnits):
- * bindings/js/JSSVGMatrixCustom.cpp:
- (WebCore::JSSVGMatrix::rotateFromVector):
- * bindings/js/JSSVGPathSegListCustom.cpp:
- (WebCore::JSSVGPathSegList::initialize):
- (WebCore::JSSVGPathSegList::getItem):
- (WebCore::JSSVGPathSegList::insertItemBefore):
- (WebCore::JSSVGPathSegList::replaceItem):
- (WebCore::JSSVGPathSegList::removeItem):
- (WebCore::JSSVGPathSegList::appendItem):
- * bindings/js/JSSVGPointListCustom.cpp:
- (WebCore::JSSVGPointList::initialize):
- (WebCore::JSSVGPointList::getItem):
- (WebCore::JSSVGPointList::insertItemBefore):
- (WebCore::JSSVGPointList::replaceItem):
- (WebCore::JSSVGPointList::removeItem):
- (WebCore::JSSVGPointList::appendItem):
- * bindings/js/JSSVGTransformListCustom.cpp:
- (WebCore::JSSVGTransformList::initialize):
- (WebCore::JSSVGTransformList::getItem):
- (WebCore::JSSVGTransformList::insertItemBefore):
- (WebCore::JSSVGTransformList::replaceItem):
- (WebCore::JSSVGTransformList::removeItem):
- (WebCore::JSSVGTransformList::appendItem):
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
- (WebCore::constructWebKitCSSMatrix):
- * bindings/js/JSWebKitPointConstructor.cpp:
- (WebCore::constructWebKitPoint):
- * bindings/js/JSWorkerConstructor.cpp:
- (WebCore::constructWorker):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::importScripts):
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- (WebCore::JSWorkerContext::setTimeout):
- (WebCore::JSWorkerContext::setInterval):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::open):
- (WebCore::JSXMLHttpRequest::setRequestHeader):
- (WebCore::JSXMLHttpRequest::send):
- (WebCore::JSXMLHttpRequest::getResponseHeader):
- (WebCore::JSXMLHttpRequest::overrideMimeType):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/js/JSXSLTProcessorCustom.cpp:
- (WebCore::JSXSLTProcessor::importStylesheet):
- (WebCore::JSXSLTProcessor::transformToFragment):
- (WebCore::JSXSLTProcessor::transformToDocument):
- (WebCore::JSXSLTProcessor::setParameter):
- (WebCore::JSXSLTProcessor::getParameter):
- (WebCore::JSXSLTProcessor::removeParameter):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::create):
- (WebCore::ScheduledAction::ScheduledAction):
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptCallFrame.cpp:
- (WebCore::ScriptCallFrame::ScriptCallFrame):
- * bindings/js/ScriptCallFrame.h:
- * bindings/js/ScriptCallStack.cpp:
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::initialize):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::invokeMethod):
- (JSC::Bindings::CInstance::invokeDefaultMethod):
- (JSC::Bindings::CInstance::invokeConstruct):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::invokeMethod):
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::invokeMethod):
- (ObjcInstance::invokeDefaultMethod):
-
-2009-04-28 David Carson <dacarson@apple.com>
-
- Reviewed by David Hyatt.
-
- Restore alignment to device pixel boundaries.
- https://bugs.webkit.org/show_bug.cgi?id=25458
-
- Adjust the adjusted destination rect to be device pixel aligned.
-
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw):
-
-2009-04-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Move unimplemented captureEvents and releaseEvents from JSDOMWindow
- to DOMWindow.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::captureEvents):
- (WebCore::DOMWindow::releaseEvents):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-04-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25420
- <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
-
- Test: http/tests/xmlhttprequest/detaching-frame-2.html
-
- This was caused by faulty DOMWindow::document(), which could return a new document from
- the window's frame after navigation.
-
- * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
- Removed an obsolete check that allowed access when document was null. Contrary to what a
- comment said, that can happen for a window that is no longer in frame, not to one whose
- document is not constructed yet.
-
- * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
- out if context was not found. This currently happens due to a shortcoming in
- DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
- test will be constructed successfully, but won't be sent, because its context will be
- frameless.
-
- * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
- been replaced yet. Added FIXME comments about how this may be better fixed in the future.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::document):
- (WebCore::constructAudio):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::document):
- (WebCore::constructImage):
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::construct):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::document):
- (WebCore::constructHTMLOptionElement):
- Make matching changes to other constructors that hold a reference to global object.
-
-2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
-
- wxMSW build fix. Switch JSCore build back to static.
-
- * config.h:
-
-2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6834830>
-
- Make sure we cover the two possible values reported by event.total that are playback engine
- specific.
-
- * media/progress-event-total-expected.txt: Match the new test.
- * media/progress-event-total.html: Test the two values.
-
-2009-04-28 Timothy Hatcher <timothy@apple.com>
-
- Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
- collects the individual rects, making sure to only include RenderText.
-
- <rdar://problem/6810061>
-
- Reviewed by Sam Weinig.
-
- * bindings/objc/DOM.mm:
- (-[DOMNode textRects]): Added. Make a Range and call textRects.
- (-[DOMNode lineBoxRects]): Call textRects method.
- (-[DOMRange textRects]): Call Range::textRects.
- (-[DOMRange lineBoxRects]): Call textRects method.
- * bindings/objc/DOMPrivate.h: Add the new methods and a comment
- about lineBoxRects being deprecated.
- * dom/Range.cpp:
- (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
- (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
- nodes instead of the RenderObjects to correctly account for offsets. Also
- only call absoluteRectsForRange on RenderText.
- * dom/Range.h: Renamed addLineBoxRects to textRects.
- * page/Frame.cpp:
- (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
- function very specific for the lineBoxRects API. These functions are still used
- by the InspectorController, and this change improves what the Inspector shows.
- (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
-
-2009-04-28 Timothy Hatcher <timothy@apple.com>
-
- Remove the topLevel boolean argument from absolute{Rects,Quads}.
- This argument was default to true and no one ever passed false.
-
- Reviewed by Sam Weinig.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::absoluteRects):
- (WebCore::RenderBlock::absoluteQuads):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::absoluteRects):
- (WebCore::RenderBox::absoluteQuads):
- * rendering/RenderBox.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::absoluteQuads):
- * rendering/RenderInline.h:
- * rendering/RenderObject.h:
- (WebCore::RenderObject::absoluteRects):
- (WebCore::RenderObject::absoluteQuads):
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::absoluteRects):
- (WebCore::RenderSVGHiddenContainer::absoluteQuads):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::absoluteRects):
- (WebCore::RenderSVGImage::absoluteQuads):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::absoluteRects):
- (WebCore::RenderSVGInlineText::absoluteQuads):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::absoluteRects):
- (WebCore::RenderSVGModelObject::absoluteQuads):
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGTSpan.cpp:
- (WebCore::RenderSVGTSpan::absoluteRects):
- (WebCore::RenderSVGTSpan::absoluteQuads):
- * rendering/RenderSVGTSpan.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
- * rendering/RenderSVGText.h:
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::absoluteQuads):
- * rendering/RenderSVGTextPath.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::absoluteRects):
- * rendering/RenderText.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::absoluteRects):
- (WebCore::RenderView::absoluteQuads):
- * rendering/RenderView.h:
-
-2009-04-28 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
-
- RenderThemeWin doesn't implement the media element controller rendering methods, so media
- controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
- of the code in both places, the logic is in a new class that is called from both.
-
- * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
-
- * rendering/RenderMediaControls.cpp: Added.
- (WebCore::determineState): Translate renderer state to ThemeControlState.
- (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
- (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
- (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
- * rendering/RenderMediaControls.h: Added.
-
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
- called for the media slider.
- (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
- (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
- (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
- (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
- (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
- (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
- (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
- (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
- (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
- (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
- (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
- (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
- (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
- (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
- (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
- * rendering/RenderThemeWin.h:
-
-2009-04-28 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
- images with % height are collapsed when printing
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcHeight): Make sure we don't ignore
- printing here!
-
-2009-04-28 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
-
- Test: editing/deleting/type-delete-after-quote.html
-
- When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
- since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
- with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
- we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
- that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
- from deleting a range they selected.
-
- * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
-
-2009-04-28 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed: fix distcheck build, add missing header to file list.
-
- * GNUmakefile.am:
-
-2009-04-27 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Fix foreignObject transform order
- https://bugs.webkit.org/show_bug.cgi?id=25433
-
- Transforms were being applied in the wrong order.
- When mapping from local to parent, first apply the viewport transform
- then map from the viewport box to the parent box.
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::localToParentTransform):
-
-2009-04-27 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Simplify nodeAtPoint for SVG
- https://bugs.webkit.org/show_bug.cgi?id=25432
-
- Added a new nodeAtFloatPoint method which takes a FloatPoint
- instead of the *super confusing* x/y tx/ty pairs that HTML uses.
- Mostly this is just lots of minus-lines as the new code is *much* simpler.
-
- I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
- for the nodeAtPoint HTML/CSS int x/y version.
-
- Eventually the rest of CSS/HTML render objects will follow suit
- and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
- over was well outside the scope of this change.
-
- SVG hit testing is not actually floating point precise yet, since its still
- passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
- by moving to FloatPoint here, but I didn't try to find one.
-
- This should not cause functional changes for common-case hit testing, thus
- no tests changed, nor should new tests be needed.
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::translationForAttributes):
- (WebCore::RenderForeignObject::paint):
- (WebCore::RenderForeignObject::computeRectForRepaint):
- (WebCore::RenderForeignObject::localToParentTransform):
- (WebCore::RenderForeignObject::layout):
- (WebCore::RenderForeignObject::nodeAtFloatPoint):
- * rendering/RenderForeignObject.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::nodeAtFloatPoint):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::nodeAtFloatPoint):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::nodeAtFloatPoint):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::paint):
- (WebCore::RenderSVGImage::nodeAtFloatPoint):
- * rendering/RenderSVGImage.h:
- (WebCore::RenderSVGImage::localToParentTransform):
- (WebCore::RenderSVGImage::localTransform):
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::nodeAtFloatPoint):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::nodeAtFloatPoint):
- * rendering/RenderSVGText.h:
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
- * rendering/RenderSVGViewportContainer.h:
-
-2009-04-28 Eric Carlson <eric.carlson@apple.com>
-
- - fix the Tiger build
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::cacheMovieScale):
-
-2009-04-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Beth Dakin.
-
- Consolidate ScheduleAction creation into ScheduledAction::create.
- Autogenerate JSWorkerContext.clearTimeout and clearInterval.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::setInterval):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::setTimeout):
- (WebCore::JSWorkerContext::setInterval):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::create):
- (WebCore::ScheduledAction::ScheduledAction):
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScheduledAction.h:
- * workers/WorkerContext.cpp:
- (WebCore::DOMWindow::setTimeout):
- (WebCore::DOMWindow::clearTimeout):
- (WebCore::DOMWindow::setInterval):
- (WebCore::DOMWindow::clearInterval):
- * workers/WorkerContext.h:
- * workers/WorkerContext.idl:
-
-2009-04-28 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
-
- When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
- as creating webarchives, would tickle this bug.
-
- Tests: webarchive/adopt-attribute-styled-body-webarchive.html
- webarchive/adopt-attribute-styled-node-webarchive.html
- webarchive/adopt-inline-styled-node-webarchive.html
-
- * dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument
- calls their parent-class implementation after they've done their own work.
- (WebCore::setWillMoveToNewOwnerDocumentWasCalled):
- (WebCore::setDidMoveToNewOwnerDocumentWasCalled):
- (WebCore::Node::setDocument):
- (WebCore::Node::willMoveToNewOwnerDocument):
- (WebCore::Node::didMoveToNewOwnerDocument):
-
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap
- to update style declarations.
- (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
- * dom/StyledElement.h:
-
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
- * html/HTMLBodyElement.h:
-
-2009-04-28 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
- QTMoviePreferredTransformAttribute
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of
- BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit
- that throw an exception on QTMovieCurrentSizeAttribute but don't support
- QTMoviePreferredTransformAttribute
-
-2009-04-28 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count
- churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment.
- (WebCore::RenderText::setTextInternal): Ditto.
-
-2009-04-27 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Simplify how SVG containers paint
- https://bugs.webkit.org/show_bug.cgi?id=25431
-
- Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
- Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
- RenderSVGText now applies transforms at paint() time instead of during chunk draw time
- this should be much more efficient.
-
- Fixed the order in which RenderSVGViewportContainer applied
- transforms and clips. We now clip to the viewport first and apply
- all transforms at once. Also since the viewport logic is now only
- inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
- we always know we have a viewport. We now use only viewportSize instead of
- viewport() since RenderSVGViewportContainers can't have x/y offsets.
-
- We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
- This allowed us to apply the transform during text paint() instead of at chunk paint
- time. Previously we had to apply the transform during chunk paint time because
- RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
- before telling any of the inlines to draw. Now that we adjust the damage rect correctly
- we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
- but since I still have a bunch of those to fix, I've not tried to write additional tests
- to cover these potential fixes yet.)
-
- SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::repaintRectInLocalCoordinates):
- (WebCore::RenderPath::paint):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
- (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::applyViewportClip):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::layout):
- (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
- (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGImage::computeRectForRepaint):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGModelObject.cpp:
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- (WebCore::RenderSVGRoot::selfWillPaint):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::viewportSize):
- (WebCore::RenderSVGRoot::calcViewport):
- (WebCore::RenderSVGRoot::localToBorderBoxTransform):
- (WebCore::RenderSVGRoot::parentOriginToBorderBox):
- (WebCore::RenderSVGRoot::borderOriginToContentBox):
- (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
- (WebCore::RenderSVGRoot::localToParentTransform):
- (WebCore::RenderSVGRoot::computeRectForRepaint):
- (WebCore::RenderSVGRoot::nodeAtPoint):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGText::computeRectForRepaint):
- (WebCore::RenderSVGText::paint):
- (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- * rendering/RenderSVGText.h:
- (WebCore::RenderSVGText::localToParentTransform):
- (WebCore::RenderSVGText::localTransform):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::applyViewportClip):
- * rendering/RenderSVGViewportContainer.h:
- * rendering/SVGRenderSupport.cpp:
- (WebCore::filterBoundingBoxForRenderer):
- (WebCore::applyTransformToPaintInfo):
- * rendering/SVGRenderSupport.h:
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
- (WebCore::SVGRootInlineBox::paint):
-
-2009-04-28 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
- https://bugs.webkit.org/show_bug.cgi?id=25453
-
- Test: accessibility/placeholder.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::title):
-
-2009-04-28 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
- https://bugs.webkit.org/show_bug.cgi?id=25452
-
- Test: accessibility/ignore-spacer-elements.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
-
-2009-04-28 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
- This removes the need for us to explicitly initialize all of the members, which have a tendency
- to change in meaning and number between versions of libxml2.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::):
- (WebCore::sharedXHTMLEntity):
- (WebCore::getXHTMLEntity):
-
-2009-04-28 Steve Falkenburg <sfalken@apple.com>
-
- Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
-
- Reviewed by Mark Rowe.
-
- * WebCore.vcproj/QTMovieWin.vcproj:
-
-2009-04-28 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
- https://bugs.webkit.org/show_bug.cgi?id=25449
-
- Test: accessibility/img-aria-button-alt-tag.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityDescription):
-
-2009-04-28 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - formatting cleanup
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcHeight): Corrected indentation and added braces
- around a multi-line "else" clause.
-
-2009-04-28 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adam Roben
+ https://bugs.webkit.org/show_bug.cgi?id=26780
- <rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
- https://bugs.webkit.org/show_bug.cgi?id=25094
+ Fix up previous change. When computeCompositingRequirements() determines
+ that the current layer is composited, it needs to inform its parent
+ by setting compositingState.m_subtreeIsCompositing() to true. That didn't
+ always happen after the previous patch. Clarified the logic here.
- Display movies saved with a non-identity matrix at the correct size.
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::CompositingState::CompositingState):
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor.
- (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial
- size and natural size so naturalSize() accounts for non-identity movie matrix.
- (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches
- kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState.
- (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState.
- (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches
- kMovieLoadStateLoaded because we do not try to draw it before that point.
- (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded
- because we need to get the movie's initial size in cacheMovieScale.
- (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.
-
-2009-04-28 Sam Weinig <sam@webkit.org>
+2009-06-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
- Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
- clearInterval can now be autogenerated.
-
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::createScheduledAction):
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::setInterval):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::setTimeout):
- (WebCore::DOMWindow::clearTimeout):
- (WebCore::DOMWindow::setInterval):
- (WebCore::DOMWindow::clearInterval):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-04-28 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Small optimization, don't get the widget's handle twice in one method.
+ https://bugs.webkit.org/show_bug.cgi?id=26780
- https://bugs.webkit.org/show_bug.cgi?id=25446
-
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::setFocus):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- (WebCore::Widget::invalidateRect):
- (WebCore::Widget::paint):
-
-2009-04-28 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- ScrollView copy and paste typo fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25445
-
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetScrollbarModes):
-
-2009-04-28 John Sullivan <sullivan@apple.com>
-
- <rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII
-
- Reviewed by Adam Roben
-
- * loader/ImageDocument.cpp:
- (WebCore::ImageTokenizer::finish):
- decode the filename before processing it as part of the image name that's passed to the client
-
-2009-04-28 Maciej Stachowiak <mjs@apple.com>
-
- Not reviewed, build fix.
-
- - fix initialization order to match declaration order to fix release build
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
-
-2009-04-28 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Justin Garcia.
-
- https://bugs.webkit.org/show_bug.cgi?id=16135
- [GTK] Support caret browsing
-
- Based on a patch by Alp Toker.
-
- Implement basic support for caret browsing, active only when the
- corresponding setting is enabled.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseReleaseEvent):
- * page/FocusController.cpp:
- (WebCore::FocusController::advanceFocus):
- (WebCore::clearSelectionIfNeeded):
- (WebCore::FocusController::setFocusedNode):
- * page/Frame.cpp:
- (WebCore::Frame::setFocusedNodeIfNeeded):
- (WebCore::Frame::setSelectionFromNone):
- (WebCore::Frame::respondToChangedSelection):
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintCaret):
-
-2009-04-27 Eric Roman <eroman@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Fix a compile breakage.
- <https://bugs.webkit.org/show_bug.cgi?id=25384>
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-04-27 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash
-
- QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
- multiplier to scale from natural size to current size when a movie is opened and use that to
- return the correct value from the naturalSize() method.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor.
- (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale.
- (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial
- size and natural size so naturalSize() accounts for non-identity movie matrix.
- (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches
- QTMovieLoadStateLoaded for the first time.
-
-2009-04-27 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
-
- The problem here is that we had a self-painting layer nested inside
- a non-self-painting layer. We ended up ignoring the self-painting
- layer both during painting and hit-testing. This patch corrects
- that.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-04-27 Ada Chan <adachan@apple.com>
-
- If it has been set to allow any HTTPS certificates for this host, set
- kCFStreamSSLAllowsExpiredCertificates to true to allow expired
- certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
- certificate chain validation. (<rdar://problem/6382059>)
-
- Reviewed by John Sullivan.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::makeFinalRequest):
-
-2009-04-27 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Adele Peterson
-
- <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
-
- Fix a 'size changed' notification thrash that caused standalone video elements
- to continually resize after full page zooming, by using the movie's natual size (which is independent
- of zooming), rather than its current size (which is not).
-
- Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
- disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
- QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
- <rdar://problem/6822344>.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::naturalSize):
-
-2009-04-27 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
- load if movie had been previously viewed
-
- Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
- to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.
-
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::rendererIsNeeded):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::rendererIsNeeded):
-
-2009-04-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Move more window event related code into DOMWindow.
-
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
- (WebCore::Document::setWindowAttributeEventListener):
- (WebCore::Document::dispatchWindowEvent):
- (WebCore::Document::dispatchLoadEvent):
- * dom/Document.h:
- * dom/Element.cpp:
- * dom/Element.h:
- * dom/Node.cpp:
- * dom/Node.h:
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
- (WebCore::DOMWindow::postMessageTimerFired):
- (WebCore::DOMWindow::dispatchEvent):
- (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget):
- (WebCore::DOMWindow::dispatchLoadEvent):
- (WebCore::DOMWindow::dispatchUnloadEvent):
- (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
- * page/DOMWindow.h:
- * page/Frame.cpp:
- (WebCore::Frame::shouldClose):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
-
-2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
-
- Implement the editing mechanisms and add context menu items for
- <rdar://problem/6724106> WebViews need to implement text checking
-
- Reviewed by Justin Garcia.
-
- * editing/Editor.cpp:
- * editing/Editor.h:
- * editing/TypingCommand.cpp:
- * loader/EmptyClients.h:
- * page/ContextMenuController.cpp:
- * page/EditorClient.h:
- * page/mac/WebCoreViewFactory.h:
- * platform/ContextMenu.cpp:
- * platform/ContextMenuItem.h:
- * platform/LocalizedStrings.h:
- * platform/mac/LocalizedStringsMac.mm:
-
-2009-04-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower
-
- Be slightly less eager in collecting after page close/navigation by increasing
- the time before collection from 0 seconds to .5 seconds.
-
- 3% speedup on the PLT.
-
- * bindings/js/GCController.cpp:
- (WebCore::GCController::garbageCollectSoon):
-
-2009-04-27 David Kilzer <ddkilzer@apple.com>
-
- Consolidate runtime application checks for Apple Mail and Safari
-
- Reviewed by Mark Rowe and Darin Adler.
-
- * WebCore.base.exp: Added exports.
- * WebCore.xcodeproj/project.pbxproj: Added
- RuntimeApplicationChecks.{h|mm} source files to the project.
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
- Removed local checkedSafari and isSafari variables and switched
- to use applicationIsSafari().
- * platform/mac/RuntimeApplicationChecks.h: Added.
- * platform/mac/RuntimeApplicationChecks.mm: Added.
- (WebCore::applicationIsAppleMail): Runtime application check for
- Apple Mail.
- (WebCore::applicationIsSafari): Runtime application check for
- Safari.
-
-2009-04-27 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25374: AX: No AXValue change sent when text is auto-inserted
- https://bugs.webkit.org/show_bug.cgi?id=25374
-
- First patch caused some regression tests to fail.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setInnerTextValue):
-
-2009-04-16 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Cover more WebCore role -> ATK role conversions.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-18 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Do not call ATK setters in the getters, just return the
- value. Among other things calling the setter will emit the notify
- signal, which is wrong.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-16 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Implement AtkImage interface.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed debug build fix.
-
- * platform/gtk/gtk2drawing.c:
- (moz_gtk_toggle_paint):
-
-2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
+ First part: fix the RenderLayer::hasCompositingDescendant() flag to be set
+ correctly.
- Build fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=25382
- Remove direct reference to CallFrame.h include to pacify Win build.
-
- * bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
- * bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
-
-2009-04-27 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25374: AX: No AXValue change sent when text is auto-inserted
- https://bugs.webkit.org/show_bug.cgi?id=25374
-
- When an input's text value is changed through the DOM, no AXValueChange notification is being sent.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setInnerTextValue):
-
-2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25382
- Move scriptStateFromNode to ScriptState.
-
- * bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
- * bindings/js/JSDOMBinding.h: Ditto.
- * bindings/js/ScriptState.cpp:
- (WebCore::scriptStateFromNode): Added.
- * bindings/js/ScriptState.h: Ditto.
- * bindings/v8/ScriptState.cpp:
- (WebCore::scriptStateFromNode): Added.
- * bindings/v8/ScriptState.h: Ditto.
- * dom/NodeFilter.h: Removed JSDOMBinding header include.
- * dom/NodeIterator.h: Ditto.
- * dom/TreeWalker.h: Ditto.
-
-2009-04-27 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
- https://bugs.webkit.org/show_bug.cgi?id=25428
-
- When marking children as changed in accessibility, we cannot rely on the accessibility parent chain existing.
- Instead, the render chain needs to be consulted.
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::childrenChanged):
-
-2009-04-27 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25399
- <rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
- beneath WebCore::Cache::evict
-
- The crash happened because a cached resource handle was removed from a document's cached
- resources map twice recursively, so a destructor was called for a value in a deleted bucket.
- The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
- CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
- an inconsistent state.
-
- I couldn't fully reconstruct the loading sequence to make a test.
-
- * loader/Cache.cpp:
- (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache
- (it makes no sense to revalidate one that isn't).
- (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource
- from the cache in no way implies that documents no longer use the old version. This fixes the
- crash, and also fixes many cases of resource content being unavailable in Web Inspector.
-
- * loader/CachedResource.h:
- (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache,
- reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never
- being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases,
- switchClientsToRevalidatedResource() results in the same resource being requested again,
- but we were only enforcing CachedResource invariants after calling this function.
- (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
-
- * loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed
- resource is removed, not some other resource that happens to have the same URL (this used to
- fail on LexisNexis search before this patch).
-
- * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED
- with notImplemented(). This method can be legally called via document.write(), and should
- work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it
- doesn't affect site functionality.
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate
- is being revalidated - this may no longer be true, because we now reset this member in
- CachedResource::setInCache().
-
-2009-04-27 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - make BidiContext a RefCounted class, starting with a refcount of 1,
- and share the root BidiContexts.
-
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
- * platform/text/BidiContext.cpp:
- (WebCore::BidiContext::create): Added. For the four "root" contexts,
- returns a reference to a shared static BidiContext.
- * platform/text/BidiContext.h:
- (WebCore::BidiContext::BidiContext):
- * platform/text/BidiResolver.h:
- (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::determineStartPosition): Ditto.
-
-2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Rubber-stamped by Gustavo Noronha.
-
- Build fix for r42893: change GDK_exclaim to GDK_exclam
-
- * platform/chromium/KeyCodeConversionGtk.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
-
-2009-04-27 Fumitoshi Ukai <ukai@google.com>
-
- Reviewed by Xan Lopez.
-
- Fix wrong key code conversion.
-
- Missing conversion for GDK_exlaim ('!').
- Parens are opposite: GDK_parenleft is open paren '('
- and GDK_parenright is close paren ')'.
- https://bugs.webkit.org/show_bug.cgi?id=25367
-
- * platform/chromium/KeyCodeConversionGtk.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
-
-2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Gustavo Noronha.
-
- [Gtk] gtkdrawing update
- https://bugs.webkit.org/show_bug.cgi?id=25408
-
- Update to the 25 Apr 2009 version of gtk2drawing.c and
- gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
-
- * platform/gtk/gtk2drawing.c:
- (setup_widget_prototype):
- (moz_gtk_get_combo_box_entry_arrow):
- (ensure_toolbar_widget):
- (ensure_tree_header_cell_widget):
- (moz_gtk_init):
- (moz_gtk_button_get_inner_border):
- (moz_gtk_toggle_paint):
- (moz_gtk_caret_paint):
- (moz_gtk_entry_paint):
- (moz_gtk_tree_header_cell_paint):
- (moz_gtk_combo_box_paint):
- (moz_gtk_toolbar_separator_paint):
- (moz_gtk_menu_separator_paint):
- (moz_gtk_get_widget_border):
- (moz_gtk_get_tab_scroll_arrow_size):
- (moz_gtk_get_toolbar_separator_width):
- (moz_gtk_get_menu_separator_height):
- (moz_gtk_widget_paint):
- (moz_gtk_shutdown):
- * platform/gtk/gtkdrawing.h:
-
-2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- https://bugs.webkit.org/show_bug.cgi?id=18475
-
- [Qt] Widget painting should follow the layout direction (LTR, RTL)
- of the element style, not the application layout direction.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::applyTheme):
-
-2009-04-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25412
- The Window object should be an EventTarget
-
- Test: fast/dom/Window/dispatchEvent.html
-
- * bindings/js/JSEventTarget.cpp:
- (WebCore::toJS): Add DOMWindow case.
- (WebCore::toEventTarget): Ditto.
-
- * dom/EventTarget.cpp:
- (WebCore::EventTarget::toDOMWindow): Added.
- * dom/EventTarget.h:
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document.
- (WebCore::DOMWindow::dispatchEvent): Added.
- * page/DOMWindow.h:
- (WebCore::DOMWindow::toDOMWindow):
- (WebCore::DOMWindow::refEventTarget):
- (WebCore::DOMWindow::derefEventTarget):
- * page/DOMWindow.idl:
-
-2009-04-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Remove scons-based build system.
-
- * WebCore.scons: Removed.
-
-2009-04-26 Darin Adler <darin@apple.com>
-
- Suggested by Darin Fisher.
-
- Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
- https://bugs.webkit.org/show_bug.cgi?id=25355
- rdar://problem/6823543
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0.
- Not sure if when this case can really arise in practice, but it's good to match the original
- logic more closely.
-
-2009-04-25 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- A width or height of zero for the destination or source rect of an
- image causes a not invertible pattern matrix.
- This crahes newer versions of Cairo and give some graphic gliches in
- Canvas.
- With this patch we check if there is something to draw and return if not.
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::draw):
-
-2009-04-25 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ Do not unconditionally set compositingState.m_subtreeIsCompositing, because
+ that can clobber the value from an earlier sibling. Add some more comments.
- https://bugs.webkit.org/show_bug.cgi?id=25390
+ Remove a final use of Vector iterators.
- Fix point mapping and hit testing through transforms and perspective
- with ENABLE_3D_RENDERING. Previously the code did the more efficient
- move(), rather than getTransformFromContainer(), when the object had
- no transform. However, this skipped the application of perspective
- when the immediate child of the perspective element had no transform
- itself.
-
- Test: transforms/3d/point-mapping/3d-point-mapping-3.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToContainer):
- (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createLocalTransformState):
- Call shouldUseTransformFromContainer() to determine if we need to
- go through the more expensive getTransformFromContainer() code
- path.
-
- * rendering/RenderObject.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::shouldUseTransformFromContainer):
- New method that indicates whether we need use getTransformFromContainer()
- when mapping points through renderers, and hit testing.
-
-2009-04-25 Adele Peterson <adele@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
- https://bugs.webkit.org/show_bug.cgi?id=25396
-
- Test: editing/deleting/delete-br-013.html
-
- * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
- Only preserve an empty paragraph's style when moving paragraphs around if the selection is still
- in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite
- the previous paragraph's style during a delete of an empty paragraph.
-
-2009-04-25 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
- properly display non-linear media
-
- If a media engine claims it can support the MIME type, WebCore now creates a <video>
- element for document mode media files instead of an <embed> element. Because WebCore's
- QuickTime backed media players do not support every kind of media the QuickTime plug-in
- supports, and because it is not always possible to tell what type of media is in a file
- without opening and parsing it, some types of media that used to be displayed properly
- by a plug-in are no longer supported properly. To fix this, if the media engine
- sees that it can not completely support a media file it now informs the media
- document, which replaces the <video> element with an <embed>.
-
- r42301 landed support for OSX. This patch modifies those changes slighly and adds support
- for Windows.
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer.
- (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video>
- element immediately.
- (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed.
- Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
- * loader/MediaDocument.h:
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks.
- (WebCore::MediaPlayerPrivate::rateChanged): Ditto.
- (WebCore::MediaPlayerPrivate::timeChanged): Ditto.
- (WebCore::MediaPlayerPrivate::didEnd): Ditto.
- (WebCore::MediaPlayerPrivate::repaint): Ditto.
- (WebCore::MediaPlayerPrivate::paint): Ditto.
- (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks.
- (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported
- media type(s) or if it fails completely.
- (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the
- media player client we won't play this movie correctly.
- (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks.
- (WebCore::MediaPlayerPrivate::setSize): Ditto.
- (WebCore::MediaPlayerPrivate::setVisible): Ditto.
- (WebCore::MediaPlayerPrivate::paint): Ditto.
- (WebCore::MediaPlayerPrivate::movieEnded): Ditto.
- (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto.
- (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto.
- (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state
- change callback.
- (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled.
- (QTMovieWin::QTMovieWin): Initialize m_disabled.
- (QTMovieWin::disableUnsupportedTracks): Return total number of tracks.
- (QTMovieWin::setDisabled): New, set m_disabled flag.
- * platform/graphics/win/QTMovieWin.h:
-
-2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Xan Lopez.
-
- [GTK] Error reporting
- https://bugs.webkit.org/show_bug.cgi?id=18344
-
- Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
- errors and G_IO_ERROR for gio errors.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::finishedCallback):
- (WebCore::ResourceHandle::startHttp):
- (WebCore::ResourceHandle::start):
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
- (WebCore::ResourceHandle::startGio):
-
-2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Mark Rowe.
-
- Only set the new URL once for the request. Doing it a second time
- after the call to willSendRequest was causing crashes when
- redirected requests got cancelled.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::restartedCallback):
-
-2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Adding ScriptEventListener.cpp.
-
- * WebCoreSources.bkl:
-
-2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=17267
- [GTK] Primary selection/clipboard support
-
- Copy the link location to the primary selection as well as the
- clipboard selection when using the "copy link selection" context
- menu entry.
-
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::writeURL):
- * platform/gtk/PasteboardHelper.h:
-
-2009-04-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25383
- Changing SVG size via JS does not update CSS width/height
-
- Add an ugly hack to fix CSS width/height updates from JS.
-
- We can't easily call setAttribute when width/height changes
- as that would cause infinite recursion (as we'd try to set
- the animation storage from the attributes)
-
- For now, when we get notification that JS changed width/height
- we copy what parseMappedAttribute does and update the CSS values as well.
-
- A better fix for this would be:
- https://bugs.webkit.org/show_bug.cgi?id=25383
-
- * svg/SVGSVGElement.cpp:
- (WebCore::updateCSSForAttribute):
- (WebCore::SVGSVGElement::svgAttributeChanged):
-
-2009-04-24 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- We should not show the deletion UI for blockquotes in mail but they do
- show now that we only check for one visible border.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
-
-2009-04-24 Dan Bernstein <mitz@apple.com>
-
- - address Hyatt's review comments on the last patch
-
- * rendering/RenderLayer.cpp:
- (WebCore::performOverlapTests):
- (WebCore::RenderLayer::paintLayer):
-
-2009-04-24 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=5909
- <rdar://problem/5863349> overlapping element leaves trail when
- scrolling iframe
-
- * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::reset): Initialize m_isOverlapped.
- (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
- (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
- so overlapping is taken into account.
- (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
- enables or disables copy-on-scroll accordingly.
-
- * page/FrameView.h:
- Added setIsOverlapped() and m_isOverlapped.
-
- * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
- an OverlapTestRequestClient can make a request to test if any subsequently-
- painted layers overlap a rect. The test result is delivered to the
- requestClient via setOverlapTestResult().
- (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
- paintLayer(). When done painting, inform any remaining requestClients that
- they are not overlapped.
-
- (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
- pass it down to child and reflection layers. Inform requestClients if this
- layer overlaps their requested rects.
-
- * rendering/RenderLayer.h:
-
- * rendering/RenderObject.h:
- (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
- OverlapTestRequestMap member.
-
- * rendering/RenderReplica.cpp:
- (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
- to paintLayer().
-
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
- with the frame.
- (WebCore::RenderWidget::setOverlapTestResult): Call
- FrameView::setIsOverlapped() with the result of the overlap test.
+ (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
+ Move the normalFlowList() processing outside the test for isStackingContext().
- * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
+2009-06-27 Dan Bernstein <mitz@apple.com>
-2009-04-24 David Hyatt <hyatt@apple.com>
+ Reviewed by Simon Fraser and Antti Koivisto.
- Reviewed by Simon Fraser, Dan Bernstein.
+ - make paintFillLayerExtended() non-virtual and remove its clipY and
+ clipH parameters
- Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
- a ~0.5% slowdown. This patch does the following to get the speed back:
-
- (a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
- then be removed.
- (b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
- member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
- (c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
- been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
+ These parameters were computed and passed along to
+ paintFillLayerExtended in order to vertically constrain the rect fill to
+ the damage rect, because Qt cannot paint tall rectangles (see
+ <http://websvn.kde.org/?view=rev&revision=42721>). Since the damage rect
+ is passed along in the PaintInfo, the extra parameters are redundant,
+ and the intersection can just take place in paintFillLayerExtended().
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::height):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
- (WebCore::InlineBox::isSVG):
- (WebCore::InlineBox::setIsSVG):
- (WebCore::InlineBox::isText):
- (WebCore::InlineBox::setIsText):
- (WebCore::InlineBox::svgBoxHeight):
* rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::paintFillLayers):
+ (WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
- * rendering/InlineTextBox.cpp:
- * rendering/InlineTextBox.h:
- * rendering/ListMarkerBox.cpp: Removed.
- * rendering/ListMarkerBox.h: Removed.
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::createInlineBox):
- * rendering/RenderSVGInline.cpp:
- (WebCore::RenderSVGInline::createFlowBox):
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::createTextBox):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::createRootBox):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::createInlineTextBox):
- * rendering/RootInlineBox.cpp:
- * rendering/RootInlineBox.h:
- * rendering/SVGInlineFlowBox.h:
- (WebCore::SVGInlineFlowBox::svgBoxHeight):
- * rendering/SVGInlineTextBox.h:
- (WebCore::SVGInlineTextBox::svgBoxHeight):
- * rendering/SVGRootInlineBox.h:
- (WebCore::SVGRootInlineBox::svgBoxHeight):
-
-2009-04-24 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25370
- Introduce ScriptEventListener to refactor away direct references to
- JSLazyEventListener in WebCore code.
-
- * GNUmakefile.am: Added ScriptEventListener to project.
- * WebCore.pro: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
- * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
- to ScriptEventListener.
- * bindings/js/JSLazyEventListener.h: Ditto.
- * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
- * bindings/js/ScriptEventListener.cpp: Added.
- * bindings/js/ScriptEventListener.h: Added.
- * bindings/v8/ScriptEventListener.cpp: Added.
- * bindings/v8/ScriptEventListener.h: Added.
- * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
- * html/HTMLBodyElement.cpp: Ditto.
- * html/HTMLButtonElement.cpp: Ditto.
- * html/HTMLElement.cpp: Ditto.
- * html/HTMLFormElement.cpp: Ditto.
- * html/HTMLFrameElementBase.cpp: Ditto.
- * html/HTMLFrameSetElement.cpp: Ditto.
- * html/HTMLImageElement.cpp: Ditto.
- * html/HTMLInputElement.cpp: Ditto.
- * html/HTMLObjectElement.cpp: Ditto.
- * html/HTMLScriptElement.cpp: Ditto.
- * html/HTMLSelectElement.cpp: Ditto.
- * html/HTMLTextAreaElement.cpp: Ditto.
- * svg/SVGElement.cpp: Ditto.
- * svg/SVGSVGElement.cpp: Ditto.
-
-2009-04-24 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
- https://bugs.webkit.org/show_bug.cgi?id=25355
- rdar://problem/6823543
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): Added a null check.
-
-2009-04-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Fix RenderSVGImage to dump with full bounds and style information.
- https://bugs.webkit.org/show_bug.cgi?id=25377
-
- No functional changes, we're just now including more info in render tree dumps.
-
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isSVGImage):
- * rendering/RenderSVGImage.h:
- (WebCore::RenderSVGImage::isSVGImage):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::write):
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::operator<<):
- (WebCore::write):
- * rendering/SVGRenderTreeAsText.h:
-
-2009-04-24 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY (chromium build fix).
-
- Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).
-
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::V8AbstractEventListener):
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- * bindings/v8/V8AbstractEventListener.h:
- * bindings/v8/V8EventListenerList.cpp:
- (WebCore::V8EventListenerList::add):
- (WebCore::V8EventListenerList::remove):
- (WebCore::V8EventListenerList::clear):
- * bindings/v8/V8LazyEventListener.h:
- (WebCore::V8LazyEventListener::virtualisAttribute):
- * bindings/v8/custom/V8CustomEventListener.cpp:
- (WebCore::V8EventListener::V8EventListener):
- * bindings/v8/custom/V8CustomEventListener.h:
- (WebCore::V8EventListener::create):
- (WebCore::V8EventListener::virtualisAttribute):
-
-2009-04-24 Nate Chapin <japhet@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25343
- Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
- ignores blur.
-
- * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
- (WebCore::GraphicsContext::setPlatformShadow): Add check against
- blur before clearing looper.
-
-2009-04-24 Eric Roman <eroman@chromium.org>
-
- Reviewed by Darin Adler.
-
- Initialize TextIterator::m_textLength to 0.
-
- This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).
-
- <https://bugs.webkit.org/show_bug.cgi?id=25335>
-
- Test: editing/selection/doubleclick-whitespace-img-crash.html
-
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::TextIterator):
-
-2009-04-24 Fumitoshi Ukai <ukai@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25329
- Add indexed access method in v8 binding of ClientRectList.
-
- * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
-
-2009-04-24 Fumitoshi Ukai <ukai@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25257
- Use null for unspecified event listener attributes of XMLHttpRequest
- and XMLHttpRequestUpload in v8 binding.
-
- cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
- An event handler attribute, unless otherwise specified, can either
- have the value null or be set to a Function object.
- Initially, an event handler attribute must be set to null.
-
- Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html
-
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
- * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- (WebCore::ACCESSOR_GETTER): Ditto.
-
-2009-04-24 Darin Adler <darin@apple.com>
-
- Reviewed by Adam Roben.
-
- <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::reportException): Added a null check.
-
-2009-04-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=23219
-
- Add support for transtions and animations of background-position, -webkit-background-size,
- -webkit-mask-position and -webkit-mask-size.
-
- Tests: transitions/background-transitions.html
- transitions/mask-transitions.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- Add a blend func for LengthSize.
-
- (WebCore::ensurePropertyMap):
- Add wrappers for the new properties.
-
- (WebCore::addShorthandProperties):
- Add a shorthand property for CSSPropertyBackgroundPosition to map to
- CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
- add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
- CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
- CSSPropertyWebkitMaskPositionY.
-
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::setBackgroundXPosition):
- (WebCore::InheritedFlags::setBackgroundYPosition):
- (WebCore::InheritedFlags::setBackgroundSize):
- (WebCore::InheritedFlags::setMaskXPosition):
- (WebCore::InheritedFlags::setMaskYPosition):
- (WebCore::InheritedFlags::setMaskSize):
- Add setters for the properties that can be animated now.
-
-2009-04-24 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
-
- Test: editing/pasteboard/paste-blockquote-after-blockquote.html
-
- When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
- But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
- blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
- to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
- (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
- * editing/ReplaceSelectionCommand.h:
-
-2009-04-23 Francisco Tolmasky <francisco@280north.com>
-
- BUG 24604: WebKit profiler reports incorrect total times
- <https://bugs.webkit.org/show_bug.cgi?id=24604>
-
- Reviewed by Timothy Hatcher and Kevin McCullough.
-
- Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
- heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
- displays flattened statistics for a particular function that ran during the profile, and each child
- of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
- nodes should show how much of the root nodes values came from it. For example, if you had the following to
- stacks take place during the profile:
-
- A ->calls 1 times-> B ->calls 2 times-> C
- D ->calls 4 times-> C
-
- The tree for the C root node would look like this:
-
- C -> B -> A
- -> D
-
- The number of calls values would look like this:
-
- C (6) -> B (2) -> A(2)
- -> D (4)
-
- What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
- "4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
- particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
- is the reason that we would get things like 40000% previously with recursion.
-
- This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
- can't know exactly how many calls came from where, etc).
-
- * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
- * inspector/JavaScriptProfile.cpp:
- (WebCore::ProfileClass):
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::getParent):
- (WebCore::getHead):
- (WebCore::getCallUID):
- (WebCore::ProfileNodeClass):
- * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
- (WebInspector.BottomUpProfileDataGridTree):
- (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
- (WebInspector.BottomUpProfileDataGridNode):
- (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
- (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
- (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
- (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
- (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- * inspector/front-end/DataGrid.js:
- (WebInspector.DataGrid.prototype.insertChild):
- (WebInspector.DataGrid.prototype.removeChild):
- (WebInspector.DataGrid.prototype.removeChildren):
- (WebInspector.DataGridNode.prototype.set hasChildren):
- (WebInspector.DataGridNode.prototype.get hasChildren):
- * inspector/front-end/ProfileDataGridTree.js: Added.
- (WebInspector.ProfileDataGridNode):
- (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
- (WebInspector.ProfileDataGridNode.prototype.get data):
- (WebInspector.ProfileDataGridNode.prototype.createCell):
- (WebInspector.ProfileDataGridNode.prototype.select):
- (WebInspector.ProfileDataGridNode.prototype.deselect):
- (WebInspector.ProfileDataGridNode.prototype.expand):
- (WebInspector.ProfileDataGridNode.prototype.insertChild):
- (WebInspector.ProfileDataGridNode.prototype.removeChild):
- (WebInspector.ProfileDataGridNode.prototype.removeChildren):
- (WebInspector.ProfileDataGridNode.prototype.findChild):
- (WebInspector.ProfileDataGridNode.prototype.get averageTime):
- (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
- (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
- (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
- (WebInspector.ProfileDataGridNode.prototype._save):
- (WebInspector.ProfileDataGridNode.prototype._restore):
- (WebInspector.ProfileDataGridNode.prototype._merge):
- (WebInspector.ProfileDataGridTree):
- (WebInspector.ProfileDataGridTree.prototype.get expanded):
- (WebInspector.ProfileDataGridTree.prototype.appendChild):
- (WebInspector.ProfileDataGridTree.prototype.insertChild):
- (WebInspector.ProfileDataGridTree.prototype.removeChildren):
- (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
- (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
- (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
- (WebInspector.ProfileDataGridTree.propertyComparator):
- * inspector/front-end/ProfileView.js:
- (WebInspector.ProfileView):
- (WebInspector.ProfileView.prototype.set profile):
- (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
- (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
- (WebInspector.ProfileView.prototype.get currentTree):
- (WebInspector.ProfileView.prototype.set currentTree):
- (WebInspector.ProfileView.prototype.get topDownTree):
- (WebInspector.ProfileView.prototype.get bottomUpTree):
- (WebInspector.ProfileView.prototype.refresh):
- (WebInspector.ProfileView.prototype.refreshVisibleData):
- (WebInspector.ProfileView.prototype.refreshShowAsPercents):
- (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
- (WebInspector.ProfileView.prototype.performSearch):
- (WebInspector.ProfileView.prototype._changeView):
- (WebInspector.ProfileView.prototype._focusClicked):
- (WebInspector.ProfileView.prototype._excludeClicked):
- (WebInspector.ProfileView.prototype._resetClicked):
- (WebInspector.ProfileView.prototype._sortProfile):
- * inspector/front-end/ProfilesPanel.js:
- (WebInspector.ProfilesPanel.prototype.showProfile):
- (WebInspector.ProfilesPanel.prototype.showView):
- (WebInspector.ProfilesPanel.prototype.searchMatchFound):
- * inspector/front-end/TopDownProfileDataGridTree.js: Added.
- (WebInspector.TopDownProfileDataGridNode):
- (WebInspector.TopDownProfileDataGridNode.prototype._populate):
- (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
- (WebInspector.TopDownProfileDataGridTree):
- (WebInspector.TopDownProfileDataGridTree.prototype.focus):
- (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/inspector.css:
- * inspector/front-end/inspector.html:
-
-2009-04-23 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Use static functions (and a couple templates)
- to further reduce the amount of copy/paste code in SVGRenderTreeAsText
-
- No test changes, only code cleanup.
-
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::writeNameValuePair):
- (WebCore::writeNameAndQuotedValue):
- (WebCore::writeIfNotEmpty):
- (WebCore::writeIfNotDefault):
- (WebCore::writeStyle):
- (WebCore::writePositionAndStyle):
- (WebCore::operator<<):
-
-2009-04-23 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- SVGRenderTreeAsText cleanup/code sharing.
-
- No test changes, only code cleanup.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::firstRunOrigin):
- * rendering/RenderText.h:
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::writeStandardPrefix):
- (WebCore::writeChildren):
- (WebCore::write):
- (WebCore::writeRenderResources):
-
-2009-04-23 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- WebCore part of fix for <rdar://problem/6333461> REGRESSION
- (r36864-r36869): Dragging stocks widget scrollbar drags the whole
- widget
-
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::isScrollbar):
- * platform/Widget.h:
- (WebCore::Widget::isScrollbar):
-
-2009-04-23 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Adam Roben.
-
- <rdar://problem/6808109> "Deletion UI" is not available for many
- portions of HTML content
-
- This patch makes the deletion UI show up in some new situations:
- 1) If a block's background color is different from its parent's
- 2) If a block has a background image.
- 3) If a block has a single visible border.
- However the block must now not only be at least a minimum width and
- height, but also exceed a minimum area. In practice this has led to
- much better element selection.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
-
-2009-04-23 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Adding XMLTokenizerScope.cpp to the build.
-
- * WebCoreSources.bkl:
-
-2009-04-23 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
- https://bugs.webkit.org/show_bug.cgi?id=25312
-
- I was unable to reproduce the problem, but I'm pretty sure this will fix it.
-
- * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
-
-2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25313
- Missing scroll bars in GMail.
-
- Test: fast/overflow/overflow-y-scroll.html
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
- scroll mode.
-
-2009-04-23 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Justin Garcia.
-
- - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
- some messages in WebCore::canHaveChildrenForEditing
-
- Test: editing/selection/extend-by-line-anonymous-content-crash.html
-
- * editing/visible_units.cpp:
- (WebCore::previousLinePosition): Null-check node. If p is not an
- editable position, then closestLeafChildForXPos() may have returned a
- non-editable box, and in particular one belonging to anonymous content.
- If node is 0, fall back on RenderObject::positionForPoint, which
- finds the closest position in non-anonymous content.
- (WebCore::nextLinePosition): Ditto.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::createVisiblePosition): Fixed a typo.
-
-2009-04-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
-
- Test: http/tests/history/back-to-post.php
-
- * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
- Apply a new cache policy if it changed after the platform request was first created.
- While at it, also made sure to update timeout.
-
-2009-04-23 Zan Dobersek <zandobersek@gmail.com>
-
- Reviewed by Gustavo Noronha.
-
- When creating a new drawable object, collect system's
- information about the best depth it can provide and use it
- in a new colormap that the new drawable requires.
-
- * platform/graphics/gtk/ImageGtk.cpp:
- (WebCore::BitmapImage::getGdkPixbuf):
-
-2009-04-23 Zan Dobersek <zandobersek@gmail.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=15654
- GdkPixbuf support for ImageCairo
-
- Add support for converting a Cairo surface to a GdkPixbuf.
-
- * platform/graphics/BitmapImage.h:
- * platform/graphics/Image.h:
- (WebCore::Image::getGdkPixbuf):
- * platform/graphics/gtk/ImageGtk.cpp:
- (WebCore::BitmapImage::getGdkPixbuf):
-
-2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Simon Hausmann.
-
- Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.
-
- Basically, what we want is to send wheel events to the plugin *only*
- when it has focus, or else send it to the parent frame.
-
- This is a work around, and basically what we do, is to steal the
- wheel events from the plugin, modify the window ID, and put the
- event back into the Qt event loop.
-
- * plugins/qt/PluginContainerQt.cpp:
- (PluginClientWrapper::PluginClientWrapper):
- (PluginClientWrapper::~PluginClientWrapper):
- (PluginClientWrapper::x11Event):
- (PluginContainerQt::PluginContainerQt):
- (PluginContainerQt::~PluginContainerQt):
- (PluginContainerQt::on_clientClosed):
- (PluginContainerQt::on_clientIsEmbedded):
- (PluginContainerQt::redirectWheelEventsToParent):
- (PluginContainerQt::x11Event):
- (PluginContainerQt::focusInEvent):
- * plugins/qt/PluginContainerQt.h:
-
-2009-04-22 Brady Eidson <beidson@apple.com>
-
- Reviewed by Maciej Stachowiak
-
- <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
-
- For most loads, we were consulting the navigation policy delegate twice. Once from FrameLoader before
- the load started and once from MainResourceLoader in its willSendRequest callback.
-
- In the past we tried removing MainResourceLoader's call altogether. This caused a regression where urls
- that redirect to a url handled by an external application would no longer work in Safari. It probably
- also broke other WebKit apps in subtle ways.
-
- Changing MainResourceLoader to make the check only on redirects fixes both bugs. We now only call the
- policy delegate once for most standard loads, but we do correctly call it a second time for redirects.
-
- Tests: http/tests/misc/policy-delegate-called-twice.html
- http/tests/misc/redirect-to-external-url.html
-
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.
-
-2009-04-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix for <rdar://problem/6800695>
-
- Add a hack to only allow navigating (via a link from a http page)
- to feed: urls (same for feeds: and feedsearch:) that map to http:
- or https: via their nested protocol. This includes both feed://example.com
- and feed:http://example.com.
-
- * loader/FrameLoader.cpp:
- (WebCore::isFeedWithNestedProtocolInHTTPFamily):
- (WebCore::FrameLoader::loadFrameRequest):
-
-2009-04-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Autogenerate the XMLHttpRequest constructor getter/setter for the
- WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
- file.
-
- * DerivedSources.make: Remove JSWorkerContextBase.lut.h
- * WebCore.xcodeproj/project.pbxproj: Ditto.
-
- * bindings/js/JSWorkerContextBase.cpp:
- * bindings/js/JSWorkerContextBase.h: Remove code to support hand written
- code for XMLHttpRequest constructor lookup and shadowing.
-
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes.
- (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of
- cached constructor lookup.
- * workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not
- V8 specific.
-
-2009-04-22 Darin Adler <darin@apple.com>
-
- * page/Navigator.idl: Touch this file to fix build since Geolocation
- configuration was recently turned off.
-
-2009-04-22 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25322
- Can't delete empty paragraph after a block image
-
- Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
- because of some code that avoided problems that would arise from Positions that would go
- bad during deletion.
-
- We have several checks that prevent us from using bad Positions, this one in particular
- was added to avoid bad Positions that result from text removal. So, I removed the check
- and started correctly updating m_downstreamEnd during text removal so that it doesn't go
- bad. m_upstreamStart doesn't need to be updated during text removal, since only text
- after it will ever be removed.
-
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::deleteTextFromNode):
- (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- (WebCore::DeleteSelectionCommand::mergeParagraphs):
-
-2009-04-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
-
- Make mouseUp target the correct frame when the original
- mousedown made the drag non-capturing.
-
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::passSubframeEventToSubframe):
-
-2009-04-22 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
-
- This is the first step of allowing drag events to match the behaviour
- of mouse move events when the default action of the initial mouse down
- is prevented. Remaining issue is that the final mouse up event still
- targets the original root frame.
-
- Test: fast/events/mouse-drag-from-frame-to-other-frame.html
-
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::passSubframeEventToSubframe):
-
-2009-04-22 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Adele Peterson
-
- <rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
- <rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting
-
- When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
- layer backing under some circumstances. However, drawing the view via
- displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
- So when in the media document, we draw via displayRectIgnoringOpacity:.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::paint):
-
-2009-04-22 Timothy Hatcher <timothy@apple.com>
-
- Fix a crash in Mail when forwarding a specific HTML email.
- Caused by the fix for <rdar://problem/6512520> (r42096).
- Unable to create a test case that works outside of Mail.
-
- <rdar://problem/6796069>
-
- Reviewed by Ada Chan.
-
- * editing/markup.cpp:
- (WebCore::createMarkup): Null check pastEnd before trying to
- call Range::compareBoundaryPoints.
-
-2009-04-22 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Darin Adler.
-
- Fix for <rdar://problem/6816957>
- Turn off Geolocation by default
-
- * Configurations/FeatureDefines.xcconfig:
-
-2009-04-22 Eric Seidel <eric@webkit.org>
-
- Rubber-stamped by David Hyatt.
-
- Change RenderSVGImage to dump as RenderSVGImage instead of RenderImage
-
- * rendering/RenderSVGImage.h:
- (WebCore::RenderSVGImage::renderName):
-
-2009-04-21 Timothy Hatcher <timothy@apple.com>
-
- Fix a crash on Gmail when they remove a "before unload" event listener when
- it was never added to the pending map in the first place.
-
- <rdar://problem/6814144>
-
- Reviewed by Darin Adler.
-
- * page/DOMWindow.cpp:
- (WebCore::allowsPendingBeforeUnloadListeners): Renamed from shouldAddPendingBeforeUnloadListener.
- (WebCore::DOMWindow::addEventListener): Call allowsPendingBeforeUnloadListeners now.
- (WebCore::DOMWindow::removeEventListener): Call allowsPendingBeforeUnloadListeners before
- removing the before unload listener.
- (WebCore::DOMWindow::clearAttributeEventListener): Ditto.
-
-2009-04-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-
- Reviewed by Ariya Hidayat.
-
- Made windowed plugins move/resize synchronized with the painting, so
- that windowed plugins are not moved before the rest of the parent
- frame during scrolling.
-
- * plugins/qt/PluginContainerQt.cpp:
- (PluginContainerQt::PluginContainerQt):
- (PluginContainerQt::requestGeometry):
- (PluginContainerQt::adjustGeometry):
- * plugins/qt/PluginContainerQt.h:
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::paint):
-
-2009-04-22 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- Fix various bugs in the X11 Qt plugin focus handling.
-
- Notify the focus controller on activation/deactivation of the plugin and
- set focus on the plugin's element when it receives the window system
- focus.
-
- * WebCore.pro: Added PluginContainerQt to the Qt build.
- * plugins/PluginView.cpp:
- (WebCore::PluginView::focusPluginElement): New helper function, moved from PluginViewWin.
- * plugins/PluginView.h:
- (WebCore::PluginView::parentFrame): Added parent frame accessor.
- * plugins/qt/PluginContainerQt.cpp: Added.
- (PluginContainerQt::PluginContainerQt):
- (PluginContainerQt::focusInEvent): Set the focus controller active on focus in events.
- (PluginContainerQt::focusOutEvent): Deactivate the focus controller when loosing the focus.
- * plugins/qt/PluginContainerQt.h: Added.
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::init): Allocate a PluginContainerQt instead of QX11EmbedContainer.
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::handleMouseEvent): Moved the code to set focus on the plugin element
- to PluginView::focusPluginElement.
-
-2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
-
- Reviewed by Ariya Hidayat.
-
- https://bugs.webkit.org/show_bug.cgi?id=25023
- Delete reply in QNetworkReplyHandler::abort() to avoid leak.
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
- (WebCore::QNetworkReplyHandler::abort):
-
-2009-04-21 Jon Honeycutt <jhoneycutt@apple.com>
-
- Allow the UI delegate to control cursor-setting.
-
- Reviewed by Ada Chan.
-
- * page/Chrome.cpp:
- (WebCore::Chrome::setCursor):
- Pass the call to the client.
-
- * page/Chrome.h:
-
- * page/ChromeClient.h:
- (WebCore::ChromeClient::setCursor):
- Stubbed; returns false.
-
- * platform/Cursor.h:
- Define PlatformCursorHandle for each platform.
-
- * platform/win/WidgetWin.cpp:
- Reordered some includes. Added an include of Page.h.
- (WebCore::Widget::setCursor):
- Fixed a typo in the comment about ignoreNextSetCursor. Get the Page, and
- call its Chrome's setCursor() method with the passed cursor. Fall back
- to SetCursor() if the Page is not available.
-
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::handleMouseEvent):
- Remove an unused variable. Cleaned up some whitespace.
-
-2009-04-21 John Abd-El-Malek <jam@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Add a method to purge the Chromium plugin list cache.
- https://bugs.webkit.org/show_bug.cgi?id=25318
-
- * plugins/chromium/PluginDataChromium.cpp:
- (WebCore::resetChromiumPluginCache):
-
-2009-04-21 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=25164> / <rdar://problem/6786319>.
-
- We need to ensure that XMLTokenizer sets the current DocLoader before calling in to
- any libxml2 methods that may trigger a load. The presence of a DocLoader indicates
- that the load was originated by WebCore's use of libxml2 and that we should enforce
- the same-origin policy on it. XMLTokenizer::initializeParserContext,
- XMLTokenizer::doWrite and XMLTokenizer::doEnd were three methods that were not setting
- the current DocLoader when they should have.
-
- The XMLTokenizerScope class is introduced to simplify the pattern of saving, setting and
- restoring the current DocLoader and libxml2 error handlers. The DocLoader and error handlers
- are saved and set when the scope is allocated, and restored to their previous values when
- the scope is exited.
-
- Test: http/tests/security/xss-DENIED-xml-external-entity.xhtml
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizer.h:
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::matchFunc):
- (WebCore::shouldAllowExternalLoad):
- (WebCore::openFunc):
- (WebCore::XMLTokenizer::doWrite):
- (WebCore::XMLTokenizer::initializeParserContext):
- (WebCore::XMLTokenizer::doEnd):
- (WebCore::xmlDocPtrForString):
- * dom/XMLTokenizerScope.cpp:
- (WebCore::XMLTokenizerScope::XMLTokenizerScope):
- (WebCore::XMLTokenizerScope::~XMLTokenizerScope):
- * dom/XMLTokenizerScope.h:
- * xml/XSLStyleSheet.cpp:
- (WebCore::XSLStyleSheet::parseString):
- * xml/XSLTProcessor.cpp:
-
-2009-04-21 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/5874009>
- Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::portAllowed):
-
-2009-04-21 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=25320
- Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If the enclosing block is the
- root editable element and it contains no visible content, create a new block but don't try and move
- content into it, since there's nothing for moveParagraphs to move.
-
-
-2009-04-21 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
- https://bugs.webkit.org/show_bug.cgi?id=25162
- rdar://problem/6764354
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
- Later we may want to change this default to encompass other versions running on Mac.
-
- * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
- m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
- the bit fields.
-
- * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
- I'm not sure the distinction here is serving us well at the moment. When converting from
- global to local coordinates you want to do IntPoint - IntPoint and have the result be
- another IntPoint, not an IntSize. And so on.
-
- * rendering/RenderBlock.cpp:
- (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
- separate coordinates less.
- (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
- Added separate cases to support the Mac and Windows behavior.
- (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
- computation of pointInContents closer to the place it's used.
-
- * rendering/RenderBlock.h: Updated for the new private member function.
-
-2009-04-17 Timothy Hatcher <timothy@apple.com>
-
- Change pending unload and beforeunload counts to store the listeners
- in a single data structure that can be quickly iterated for dispatch.
-
- <rdar://problem/6383352&6383379&6383940>
-
- Reviewed by Darin Adler.
-
- * WebCore.base.exp: Change what symbols are exported.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading): Remove count updating code
- and move an if inside a block already checking m_frame->document().
- * page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
- * page/Chrome.h: Ditto.
- * page/ChromeClient.h: Ditto.
- * page/DOMWindow.cpp:
- (WebCore::pendingUnloadEventListenerMap): Create a static map.
- (WebCore::pendingBeforeUnloadEventListenerMap): Ditto.
- (WebCore::addPendingEventListener): Add the event listener to the map.
- (WebCore::removePendingEventListener): Remove the event listener from the map.
- (WebCore::removePendingEventListeners): Remove all listeners for the window.
- (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners.
- (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event.
- (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners.
- (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event.
- (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps.
- (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed.
- (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed.
- (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners.
- (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
- * page/DOMWindow.h:
- (WebCore::DOMWindow::frame): Changed to be const.
- * page/EventHandler.cpp:
- (WebCore::EventHandler::EventHandler): Remove count tracking code.
- * page/EventHandler.h: Ditto.
- * page/Page.cpp:
- (WebCore::Page::Page): Ditto.
- * page/Page.h: Ditto.
-
-2009-04-21 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19644
- Text copied with Select All pastes with a indent but shouldn't
- <rdar://problem/6102483>
- Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
-
- To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
- a div that held properties and attributes from the fully selected body. To fix the above issues,
- only do this if if the body has certain properties or attributes. We'll begin adding to this list as
- necessary. For now it's just background colors and images. Tested copy/paste of nytimes, wired,
- arstechnica, and several others.
-
- Massive nesting can still happen, it will just be much less common.
-
- * editing/markup.cpp:
- (WebCore::createMarkup):
-
-2009-04-21 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=25250
- Allow platforms to snap the scroll thumb back to the drag origin
- during a drag. Implement functions for Safari/Win and Chromium/Win
- to do this snapping at distances approximating the native ones.
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::setValue):
- (WebCore::Scrollbar::scroll):
- (WebCore::Scrollbar::moveThumb):
- (WebCore::Scrollbar::setCurrentPos):
- (WebCore::Scrollbar::mouseMoved):
- (WebCore::Scrollbar::mouseDown):
- * platform/Scrollbar.h:
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
- * platform/chromium/ScrollbarThemeChromium.h:
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
- * platform/chromium/ScrollbarThemeChromiumWin.cpp:
- (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
- (WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
- * platform/win/ScrollbarThemeWin.h:
-
-2009-04-21 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::eventParameterName): Remove unreachable code when SVG is
- enabled.
-
-2009-04-21 Kevin Ollivier <kevino@theolliviers.com>
-
- !ENABLE(SVG) build fix.
-
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::eventParameterName):
-
-2009-04-21 Dave Moore <davemoore@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25309
- Better use AtomicStrings when calling from the V8
- bindings into WebCore code.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
-
-2009-04-21 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25304: AX: Safari not identifying a secure text field
- https://bugs.webkit.org/show_bug.cgi?id=25304
-
- Secure text fields need to be able to return AXTitleUIElements.
-
- Test: accessibility/secure-textfield-title-ui.html
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
-
-2009-04-21 Dan Bernstein <mitz@apple.com>
-
- - fix the Tiger build
-
- * page/mac/EventHandlerMac.mm:
- (method_setImplementation):
-
-2009-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25271
-
- Fix the build with disabled DOM storage or disabled database support.
-
- * bindings/js/ScriptObjectQuarantine.cpp:
- * bindings/js/ScriptObjectQuarantine.h:
-
-2009-04-21 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix.
-
- Compile fix for r42633. const qualifier does not work
- on a static method.
-
- * dom/Document.h:
- (WebCore::Document::isSVGDocument):
-
-2009-04-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler and John Sullivan.
-
- - fix <rdar://problem/5914146> Crash at -[NSScrollView scrollWheel:]
-
- -[NSScrollView scrollWheel:] runs a nested event-tracking run loop
- in a mode that allows WebCore timers to fire and NSURLConnection
- callbacks to be dispatched, which can release the NSScrollView and
- cause it to be deallocated (one example is a DOM timer callback that
- removes a subframe from the document). This leads to a crash in
- -scrollView:.
-
- The fix is to replace the implementation of -[NSScrollView scrollWheel:]
- with one that optionally retains the receiver for the duration of the
- call.
-
- * page/mac/EventHandlerMac.mm:
- (WebCore::nsScrollViewScrollWheelShouldRetainSelf): Added.
- (WebCore::setNSScrollViewScrollWheelShouldRetainSelf): Added. Replaces
- the implementation of -[NSScrollView scrollWheel:] with the
- self-retaining one, and sets a static boolean that tells it whether to
- retain the receiver around the call to the original implementation.
- (WebCore::selfRetainingNSScrollViewScrollWheel): Added. If
- setNSScrollViewScrollWheelShouldRetainSelf(true) was called and this
- function is executing on the main thread, it retains the NSScrollView,
- invokes the original -[NSScrollView scrollWheel:], then releases the
- view. Otherwise it just calls through to the original implementation.
- (WebCore::EventHandler::passWheelEventToWidget): Added calls to
- setNSScrollViewScrollWheelShouldRetainSelf() around the call to
- -scrollWheel:.
-
-2009-04-21 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Mark Rowe.
-
- Tiger crash fix: Put VM tags in their own header file, and fixed up the
- #ifdefs so they're not used on Tiger.
-
- * ForwardingHeaders/wtf/VMTags.h: Copied from WebCore/ForwardingHeaders/wtf/HashTraits.h.
-
-2009-04-21 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Implement AtkComponent interface.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
- (core):
-
-2009-04-21 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Only implement AtkAction interface if we actually have an action.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-20 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25290
- REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document
-
- Test: fast/dom/xmlhttprequest-constructor-in-detached-document.html
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSAudioConstructor.h:
- * bindings/js/JSDOMGlobalObject.h:
- (WebCore::getDOMConstructor):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSImageConstructor.h:
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- * bindings/js/JSMessageChannelConstructor.h:
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- * bindings/js/JSOptionConstructor.h:
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- * bindings/js/JSXMLHttpRequestConstructor.h:
- Avoid accessing JSDOMGlobalObject via ScriptExecutionContext, since it may not
- work during frame teardown.
-
-2009-04-20 Geoffrey Garen <ggaren@apple.com>
-
- Rubber stamped by Darin Adler and Sam Weinig.
-
- Renamed "*InlineEventListener*" => "*AttributeEventListener*", and
- "isInline" => "isAttribute".
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSEventListener::handleEvent):
- (WebCore::JSEventListener::virtualisAttribute):
- * bindings/js/JSEventListener.h:
- (WebCore::JSEventListener::create):
- (WebCore::JSEventListener::isAttribute):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::createAttributeEventListener):
- * bindings/js/JSLazyEventListener.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/Element.cpp:
- (WebCore::Element::setWindowAttributeEventListener):
- * dom/Element.h:
- * dom/EventListener.h:
- (WebCore::EventListener::isAttribute):
- (WebCore::EventListener::virtualisAttribute):
- * dom/Node.cpp:
- (WebCore::Node::clearAttributeEventListener):
- (WebCore::Node::setAttributeEventListener):
- (WebCore::Node::getAttributeEventListener):
- (WebCore::Node::onabort):
- (WebCore::Node::setOnabort):
- (WebCore::Node::onblur):
- (WebCore::Node::setOnblur):
- (WebCore::Node::onchange):
- (WebCore::Node::setOnchange):
- (WebCore::Node::onclick):
- (WebCore::Node::setOnclick):
- (WebCore::Node::oncontextmenu):
- (WebCore::Node::setOncontextmenu):
- (WebCore::Node::ondblclick):
- (WebCore::Node::setOndblclick):
- (WebCore::Node::onerror):
- (WebCore::Node::setOnerror):
- (WebCore::Node::onfocus):
- (WebCore::Node::setOnfocus):
- (WebCore::Node::oninput):
- (WebCore::Node::setOninput):
- (WebCore::Node::onkeydown):
- (WebCore::Node::setOnkeydown):
- (WebCore::Node::onkeypress):
- (WebCore::Node::setOnkeypress):
- (WebCore::Node::onkeyup):
- (WebCore::Node::setOnkeyup):
- (WebCore::Node::onload):
- (WebCore::Node::setOnload):
- (WebCore::Node::onmousedown):
- (WebCore::Node::setOnmousedown):
- (WebCore::Node::onmousemove):
- (WebCore::Node::setOnmousemove):
- (WebCore::Node::onmouseout):
- (WebCore::Node::setOnmouseout):
- (WebCore::Node::onmouseover):
- (WebCore::Node::setOnmouseover):
- (WebCore::Node::onmouseup):
- (WebCore::Node::setOnmouseup):
- (WebCore::Node::onmousewheel):
- (WebCore::Node::setOnmousewheel):
- (WebCore::Node::onbeforecut):
- (WebCore::Node::setOnbeforecut):
- (WebCore::Node::oncut):
- (WebCore::Node::setOncut):
- (WebCore::Node::onbeforecopy):
- (WebCore::Node::setOnbeforecopy):
- (WebCore::Node::oncopy):
- (WebCore::Node::setOncopy):
- (WebCore::Node::onbeforepaste):
- (WebCore::Node::setOnbeforepaste):
- (WebCore::Node::onpaste):
- (WebCore::Node::setOnpaste):
- (WebCore::Node::ondragenter):
- (WebCore::Node::setOndragenter):
- (WebCore::Node::ondragover):
- (WebCore::Node::setOndragover):
- (WebCore::Node::ondragleave):
- (WebCore::Node::setOndragleave):
- (WebCore::Node::ondrop):
- (WebCore::Node::setOndrop):
- (WebCore::Node::ondragstart):
- (WebCore::Node::setOndragstart):
- (WebCore::Node::ondrag):
- (WebCore::Node::setOndrag):
- (WebCore::Node::ondragend):
- (WebCore::Node::setOndragend):
- (WebCore::Node::onreset):
- (WebCore::Node::setOnreset):
- (WebCore::Node::onresize):
- (WebCore::Node::setOnresize):
- (WebCore::Node::onscroll):
- (WebCore::Node::setOnscroll):
- (WebCore::Node::onsearch):
- (WebCore::Node::setOnsearch):
- (WebCore::Node::onselect):
- (WebCore::Node::setOnselect):
- (WebCore::Node::onselectstart):
- (WebCore::Node::setOnselectstart):
- (WebCore::Node::onsubmit):
- (WebCore::Node::setOnsubmit):
- (WebCore::Node::onunload):
- (WebCore::Node::setOnunload):
- * dom/Node.h:
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::parseMappedAttribute):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::parseMappedAttribute):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::setAttributeEventListener):
- (WebCore::DOMWindow::clearAttributeEventListener):
- (WebCore::DOMWindow::getAttributeEventListener):
- (WebCore::DOMWindow::onabort):
- (WebCore::DOMWindow::setOnabort):
- (WebCore::DOMWindow::onblur):
- (WebCore::DOMWindow::setOnblur):
- (WebCore::DOMWindow::onchange):
- (WebCore::DOMWindow::setOnchange):
- (WebCore::DOMWindow::onclick):
- (WebCore::DOMWindow::setOnclick):
- (WebCore::DOMWindow::ondblclick):
- (WebCore::DOMWindow::setOndblclick):
- (WebCore::DOMWindow::onerror):
- (WebCore::DOMWindow::setOnerror):
- (WebCore::DOMWindow::onfocus):
- (WebCore::DOMWindow::setOnfocus):
- (WebCore::DOMWindow::onkeydown):
- (WebCore::DOMWindow::setOnkeydown):
- (WebCore::DOMWindow::onkeypress):
- (WebCore::DOMWindow::setOnkeypress):
- (WebCore::DOMWindow::onkeyup):
- (WebCore::DOMWindow::setOnkeyup):
- (WebCore::DOMWindow::onload):
- (WebCore::DOMWindow::setOnload):
- (WebCore::DOMWindow::onmousedown):
- (WebCore::DOMWindow::setOnmousedown):
- (WebCore::DOMWindow::onmousemove):
- (WebCore::DOMWindow::setOnmousemove):
- (WebCore::DOMWindow::onmouseout):
- (WebCore::DOMWindow::setOnmouseout):
- (WebCore::DOMWindow::onmouseover):
- (WebCore::DOMWindow::setOnmouseover):
- (WebCore::DOMWindow::onmouseup):
- (WebCore::DOMWindow::setOnmouseup):
- (WebCore::DOMWindow::onmousewheel):
- (WebCore::DOMWindow::setOnmousewheel):
- (WebCore::DOMWindow::onreset):
- (WebCore::DOMWindow::setOnreset):
- (WebCore::DOMWindow::onresize):
- (WebCore::DOMWindow::setOnresize):
- (WebCore::DOMWindow::onscroll):
- (WebCore::DOMWindow::setOnscroll):
- (WebCore::DOMWindow::onsearch):
- (WebCore::DOMWindow::setOnsearch):
- (WebCore::DOMWindow::onselect):
- (WebCore::DOMWindow::setOnselect):
- (WebCore::DOMWindow::onsubmit):
- (WebCore::DOMWindow::setOnsubmit):
- (WebCore::DOMWindow::onunload):
- (WebCore::DOMWindow::setOnunload):
- (WebCore::DOMWindow::onbeforeunload):
- (WebCore::DOMWindow::setOnbeforeunload):
- (WebCore::DOMWindow::onwebkitanimationstart):
- (WebCore::DOMWindow::setOnwebkitanimationstart):
- (WebCore::DOMWindow::onwebkitanimationiteration):
- (WebCore::DOMWindow::setOnwebkitanimationiteration):
- (WebCore::DOMWindow::onwebkitanimationend):
- (WebCore::DOMWindow::setOnwebkitanimationend):
- (WebCore::DOMWindow::onwebkittransitionend):
- (WebCore::DOMWindow::setOnwebkittransitionend):
- * page/DOMWindow.h:
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::parseMappedAttribute):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::onabort):
- (WebCore::SVGElementInstance::setOnabort):
- (WebCore::SVGElementInstance::onblur):
- (WebCore::SVGElementInstance::setOnblur):
- (WebCore::SVGElementInstance::onchange):
- (WebCore::SVGElementInstance::setOnchange):
- (WebCore::SVGElementInstance::onclick):
- (WebCore::SVGElementInstance::setOnclick):
- (WebCore::SVGElementInstance::oncontextmenu):
- (WebCore::SVGElementInstance::setOncontextmenu):
- (WebCore::SVGElementInstance::ondblclick):
- (WebCore::SVGElementInstance::setOndblclick):
- (WebCore::SVGElementInstance::onerror):
- (WebCore::SVGElementInstance::setOnerror):
- (WebCore::SVGElementInstance::onfocus):
- (WebCore::SVGElementInstance::setOnfocus):
- (WebCore::SVGElementInstance::oninput):
- (WebCore::SVGElementInstance::setOninput):
- (WebCore::SVGElementInstance::onkeydown):
- (WebCore::SVGElementInstance::setOnkeydown):
- (WebCore::SVGElementInstance::onkeypress):
- (WebCore::SVGElementInstance::setOnkeypress):
- (WebCore::SVGElementInstance::onkeyup):
- (WebCore::SVGElementInstance::setOnkeyup):
- (WebCore::SVGElementInstance::onload):
- (WebCore::SVGElementInstance::setOnload):
- (WebCore::SVGElementInstance::onmousedown):
- (WebCore::SVGElementInstance::setOnmousedown):
- (WebCore::SVGElementInstance::onmousemove):
- (WebCore::SVGElementInstance::setOnmousemove):
- (WebCore::SVGElementInstance::onmouseout):
- (WebCore::SVGElementInstance::setOnmouseout):
- (WebCore::SVGElementInstance::onmouseover):
- (WebCore::SVGElementInstance::setOnmouseover):
- (WebCore::SVGElementInstance::onmouseup):
- (WebCore::SVGElementInstance::setOnmouseup):
- (WebCore::SVGElementInstance::onmousewheel):
- (WebCore::SVGElementInstance::setOnmousewheel):
- (WebCore::SVGElementInstance::onbeforecut):
- (WebCore::SVGElementInstance::setOnbeforecut):
- (WebCore::SVGElementInstance::oncut):
- (WebCore::SVGElementInstance::setOncut):
- (WebCore::SVGElementInstance::onbeforecopy):
- (WebCore::SVGElementInstance::setOnbeforecopy):
- (WebCore::SVGElementInstance::oncopy):
- (WebCore::SVGElementInstance::setOncopy):
- (WebCore::SVGElementInstance::onbeforepaste):
- (WebCore::SVGElementInstance::setOnbeforepaste):
- (WebCore::SVGElementInstance::onpaste):
- (WebCore::SVGElementInstance::setOnpaste):
- (WebCore::SVGElementInstance::ondragenter):
- (WebCore::SVGElementInstance::setOndragenter):
- (WebCore::SVGElementInstance::ondragover):
- (WebCore::SVGElementInstance::setOndragover):
- (WebCore::SVGElementInstance::ondragleave):
- (WebCore::SVGElementInstance::setOndragleave):
- (WebCore::SVGElementInstance::ondrop):
- (WebCore::SVGElementInstance::setOndrop):
- (WebCore::SVGElementInstance::ondragstart):
- (WebCore::SVGElementInstance::setOndragstart):
- (WebCore::SVGElementInstance::ondrag):
- (WebCore::SVGElementInstance::setOndrag):
- (WebCore::SVGElementInstance::ondragend):
- (WebCore::SVGElementInstance::setOndragend):
- (WebCore::SVGElementInstance::onreset):
- (WebCore::SVGElementInstance::setOnreset):
- (WebCore::SVGElementInstance::onresize):
- (WebCore::SVGElementInstance::setOnresize):
- (WebCore::SVGElementInstance::onscroll):
- (WebCore::SVGElementInstance::setOnscroll):
- (WebCore::SVGElementInstance::onsearch):
- (WebCore::SVGElementInstance::setOnsearch):
- (WebCore::SVGElementInstance::onselect):
- (WebCore::SVGElementInstance::setOnselect):
- (WebCore::SVGElementInstance::onselectstart):
- (WebCore::SVGElementInstance::setOnselectstart):
- (WebCore::SVGElementInstance::onsubmit):
- (WebCore::SVGElementInstance::setOnsubmit):
- (WebCore::SVGElementInstance::onunload):
- (WebCore::SVGElementInstance::setOnunload):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
-
-2009-04-20 Geoffrey Garen <ggaren@apple.com>
-
- Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
-
- Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
- they broke the Tiger and Windows buildbots.
-
- * css/html4.css:
- * css/themeWin.css:
- * platform/graphics/SimpleFontData.cpp:
- * platform/graphics/SimpleFontData.h:
- * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- * platform/graphics/mac/SimpleFontDataMac.mm:
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- * platform/graphics/win/SimpleFontDataCGWin.cpp:
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- * platform/graphics/win/SimpleFontDataWin.cpp:
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- * rendering/RenderTextControl.cpp:
- * rendering/RenderTextControlMultiLine.cpp:
- * rendering/RenderTextControlSingleLine.cpp:
-
-2009-04-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Adam Roben.
-
- One last loose end, discovered using COLLECT_ON_EVERY_ALLOCATION, for
- https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::mark): Don't ASSERT that an ElementInstance's
- correspondingElement has a JS wrapper. If a GC falls exactly between the
- allocation of the ElementInstance wrapper and the correspondingElement
- wrapper, the correspondingElement won't have a wrapper at the time we
- mark the ElementInstance's wrapper.
-
-2009-04-20 Brady Eidson <beidson@apple.com>
-
- Rubberstamped by Mark Rowe
-
- Clean builds are broken on case-sensitive filesystems. Let's fix, shall we?
-
- * platform/graphics/SimpleFontData.cpp: Remove "String.h" include. Ojan probably intended to include
- "PlatformString.h" which was unnecessary because it is pulled in through other headers. This wasn't a
- build failure on case-insensitive file systems because those systems would find the system <string.h>, averting
- the warning.
-
-2009-04-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Last patch for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Converted "lazy" event listeners to be unprotected, just like all the others.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSEventListener::jsFunction):
- (WebCore::JSEventListener::markJSFunction):
- (WebCore::JSEventListener::handleEvent):
- (WebCore::JSEventListener::virtualIsInline):
- * bindings/js/JSEventListener.h:
- (WebCore::JSEventListener::isInline): Merged JSAbstractEventListener
- into JSEventListener. Now that the only difference between JSEventListener
- and JSLazyEventListener is that JSLazyEventListener compiles lazily,
- there's no need for an abstract base class.
-
- * bindings/js/JSLazyEventListener.cpp: Converted JSLazyEventListener to
- inherit from JSEventListener and match its un-GC-protected behavior.
- (WebCore::JSLazyEventListener::JSLazyEventListener): ditto
- (WebCore::JSLazyEventListener::parseCode): ditto
- (WebCore::createInlineEventListener): When creating a lazy event listener,
- ensure that the related node has a JS wrapper to mark the listener. Since
- the parser makes these listeners, it's possible that no JS reference has
- been made to the node yet.
- * bindings/js/JSLazyEventListener.h: ditto
-
- * dom/EventListener.h:
- (WebCore::EventListener::clearJSFunction): Removed an usused function.
-
-2009-04-20 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=25299
- Don't bound caret to root line box if it is still inside its containing block
-
- Can't yet write tests for behavior of non-standard caret widths.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::localCaretRect):
-
-2009-04-20 Steve Falkenburg <sfalken@apple.com>
-
- Separate JavaScriptCore.dll from WebKit.dll.
- Slight performance improvement or no change on benchmarks.
-
- Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
- and simplifies standalone JavaScriptCore builds.
-
- Reviewed by Oliver Hunt.
-
- * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
-
-2009-04-20 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6722845> In the Cocoa event model, NPWindow's window field should be null
-
- * bridge/npapi.h:
- (_NPCocoaEvent::):
- Add a CGContextRef member to the draw struct. Add an NPCoordinateSpace enum.
-
- * plugins/npfunctions.h:
- Add a prototype for NPN_ConvertPoint.
-
-2009-04-10 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Make textarea and text input metrics more closely match IEs.
- https://bugs.webkit.org/show_bug.cgi?id=15312
-
- This involves:
- -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
- -set textarea width to cols*avgCharWidth
- -Make default CSS match IEs
- -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
-
- Those values for textarea and inputs were derived by doing a ton of manual
- testing of IE's width values for various textareas and fonts.
-
- To get the average and max character width of a font, we do the following
- for each platform:
- -Win: TextMetrics expose avgCharWidth and maxCharWidth
- -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
- maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
- -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
- maxCharWidth = max of avgCharWidth and m_ascent
- -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
- If either one is not there, then calculate the value using the Linux approach.
-
- Linux ports could probably dig into the OS/2 table as well, but I'll leave
- that up to them to implement.
-
- Tests: fast/forms/text-control-intrinsic-widths.html
- fast/forms/textarea-metrics.html
- svg/custom/svg-fonts-in-text-controls.html
-
- * css/html4.css:
- * css/themeWin.css:
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData):
- (WebCore::SimpleFontData::initCharWidths):
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::maxCharWidth):
- (WebCore::SimpleFontData::avgCharWidth):
- * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataCGWin.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformCharWidthInit):
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::initGDIFont):
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformCharWidthInit):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::calcPrefWidths):
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
-
-2009-04-17 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Remove m_absoluteBounds hack from SVG renderers and move outlineBoundsForRepaint into RenderSVGModelObject
- https://bugs.webkit.org/show_bug.cgi?id=25276
-
- This also exposed a buggy paint check in RenderSVGContainer::layout()
- we should repaint if we are self painting OR if our kids changed, not AND.
-
- Writing real outlineBoundsForRepaint required writing a mapLocalToContainer() function
-
- No functional changes, thus no tests.
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::localToParentTransform):
- (WebCore::RenderPath::layout):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::mapLocalToContainer):
- (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::localToParentTransformWithoutCSSParentOffset):
- (WebCore::RenderSVGRoot::localToParentTransform):
- (WebCore::RenderSVGRoot::computeRectForRepaint):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::layout):
-
-2009-04-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- https://bugs.webkit.org/show_bug.cgi?id=25282
-
- outlineBoundsForRepaint() should compute a quad relative to the
- repaintContainer. This fixes the repaint issues originally fixed in
- https://bugs.webkit.org/show_bug.cgi?id=12885 for elements in compositing layers.
- Failure was only apparent when building with ACCELERATED_COMPOSITING enabled.
-
- Tests: compositing/repaint/content-into-overflow.html
- compositing/repaint/overflow-into-content.html
-
* rendering/RenderBox.cpp:
- (WebCore::RenderBox::outlineBoundsForRepaint):
-
-2009-04-20 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Tim Hatcher.
-
- Add licenses for xcconfig files.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
- * Configurations/FeatureDefines.xcconfig:
- * Configurations/Version.xcconfig:
- * Configurations/WebCore.xcconfig:
-
-2009-04-20 Eric Roman <eroman@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25261
- Implement the V8 binding for DOMWindow.event similarly to JSC, by using
- the custom getter boilerplate from the IDL file.
- Also, stub out DOMWindow.crypto which is defined by the idl.
-
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::ACCESSOR_GETTER):
-
-2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Xan Lopez.
-
- https://bugs.webkit.org/show_bug.cgi?id=25243
- Crash when data:// loads are cancelled
-
- Properly handle cancellation of the load for data:// loads. This
- fixes crashing in the followin test:
-
- plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::parseDataUrl):
-
-2009-04-19 Dan Bernstein <mitz@apple.com>
-
- - maybe fix release builds
-
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::notifyFinished):
-
-2009-04-19 Dan Bernstein <mitz@apple.com>
-
- - not fix release builds
-
- * dom/Document.cpp:
- (WebCore::Document::executeScriptSoonTimerFired):
-
-2009-04-19 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link
- does nothing the second time search results are opened
-
- Test: fast/dom/HTMLScriptElement/nested-execution.html
-
- Instead of executing scripts as soon as they finish loading, which may
- happen synchronously during execution of another script, defer their
- execution until the next run loop iteration, using a queue that is
- similar to the HTML5 notion of the "list of scripts that will execute as
- soon as possible", and in my testing was consistent with how Firefox
- behaved.
-
- * dom/Document.cpp:
- (WebCore::Document::Document): Initialize m_executeScriptSoonTimer.
- (WebCore::Document::~Document): deref() script elements in
- m_scriptsToExecuteSoon.
- (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the
- scripts in m_scriptsToExecuteSoon and deref()s them.
- (WebCore::Document::executeScriptSoon): Added. Appends to
- m_scriptsToExecuteSoon and ref()s the script element, which keeps the
- ScriptElementData alive as well.
- * dom/Document.h:
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested.
- (WebCore::ScriptElementData::requestScript): Set m_requested to true, to
- prevent further load requests.
- (WebCore::ScriptElementData::execute): Added. Moved the code from
- notifyFinished() which should not execute synchronously here, to be
- called by the Document on a 0-interval timer.
- (WebCore::ScriptElementData::notifyFinished): Moved the code to
- dispatch events and evaluate the script, which should not execute
- synchronously, out of here.
- (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for
- m_requested instead of m_cachedScript, because the latter is cleared
- before the script is evaluated.
- * dom/ScriptElement.h:
-
-2009-04-19 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Antti Koivisto and Darin Adler.
-
- <rdar://problem/6127705> Excessive memory consumption on image load failure
-
- When we fail to decode an image we clear most of the image data, but not the
- input data itself, which can be backed by a CFData object that itself holds onto
- a few hundred Kbs of memory. This patch merely ensures that this buffer gets
- cleared.
-
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::error):
-
-2009-04-19 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add hooks so sudden termination will not cause loss of icons or local storage.
- rdar://problem/5951701
-
- * loader/icon/IconDatabase.cpp: Marked various constants static to give them
- internal linkage.
- (WebCore::IconDatabase::IconDatabase): Added initial value for m_syncTimer.
- Removed unneeded initial value for m_defaultIconRecord. Changed assertion to
- work cross-platform.
- (WebCore::IconDatabase::wakeSyncThread): Added disableSuddenTermination, so
- we won't terminate until the sync thread has done its thing.
- (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Added disableSuddenTermination,
- so we won't terminate if we have an outstanding sync timer.
- (WebCore::IconDatabase::syncTimerFired): Added enableSuddenTermination, to
- balance the one in scheduleOrDeferSyncTimer.
- (WebCore::IconDatabase::syncThreadMainLoop): Added enableSuddenTermination, to
- balance the one in wakeSyncThread.
- (WebCore::IconDatabase::deleteAllPreparedStatements): Use clear() instead of set(0).
-
- * loader/icon/IconDatabase.h: Use a Timer instead of an OwnPtr<Timer>.
-
- * storage/LocalStorageArea.cpp:
- (WebCore::LocalStorageArea::scheduleFinalSync): Added disableSuddenTermination.
- (WebCore::LocalStorageArea::scheduleItemForSync): Ditto.
- (WebCore::LocalStorageArea::scheduleClear): Ditto.
- (WebCore::LocalStorageArea::syncTimerFired): Added a disableSuddenTermination if
- we schedule a performSync callback for later and an unconditional
- enableSuddenTermination to balance the ones in the schedule calls above.
- (WebCore::LocalStorageArea::sync): Factored out the work of the sync function so it
- can continue to use early return idiom.
- (WebCore::LocalStorageArea::performSync): Added a call to enableSuddenTermination.
-
- * storage/LocalStorageArea.h: Added declaration of the sync function.
-
-2009-04-19 David Kilzer <ddkilzer@apple.com>
-
- Make FEATURE_DEFINES completely dynamic
-
- Reviewed by Darin Adler.
-
- Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
- variables for each feature, making it possible to remove all
- knowledge of FEATURE_DEFINES from build-webkit.
-
- * Configurations/FeatureDefines.xcconfig: Extract a variable
- from FEATURE_DEFINES for each feature setting.
-
-2009-04-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Removed a little more complexity from event handler creation and destruction.
-
- Removed the jsProtectedEventListeners, jsProtectedInlineEventListeners,
- and jsInlineEventListeners maps, and all the code for managing them.
-
- ProtectedEventListeners don't exist anymore, so they're easy to nix.
-
- Inline EventListeners do still exist, but there's no reason to track
- them in a map. The map exists to enable 'removeEventListener' to associate
- a unique JSEventListener with a given JavaScript function. But the
- 'removeEventListener' API only works with non-inline event listeners!
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::createJSInlineEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::clearJSFunctionInline):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::~JSLazyEventListener):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-18 Dan Bernstein <mitz@apple.com>
-
- - try to fix the Windows build
-
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::characterAfter):
-
-2009-04-18 Dan Bernstein <mitz@apple.com>
-
- - revert the previous change, which was to a file that the Windows
- port does not even use
-
- * icu/unicode/utf16.h:
-
-2009-04-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- - try to fix the Windows build
-
- * icu/unicode/utf16.h:
-
-2009-04-18 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=25066
-
- When a <video> element gained a RenderLayer via opacity, reflection etc., the
- layer hierarchy was not correctly updated because RenderMedia skipped a level
- when asked for its children; it skipped m_controlsShadowRoot's renderer, which
- actually has a layer.
-
- Test: fast/layers/video-layer.html
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
- Don't manually call setParent() on the renderer. It will happen later
- as a result of addChild().
-
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createControlsShadowRoot):
- Add m_controlsShadowRoot's renderer as a child.
-
- * rendering/RenderMedia.h:
- (WebCore::RenderMedia::children):
- Now maintain a RenderObjectChildList, m_children, and remove the unneeded
- removeChild() method. Make the two children() methods inline.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::moveLayers):
- Assert if moveLayers() is called with an oldParent that is not the
- layer's actual parent (which would have revealed this bug).
-
-2009-04-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed a layout test failure, caused by my last check-in
- (fast/dom/script-element-gc.html).
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::isObservableThroughDOM):
- * html/HTMLScriptElement.h:
- (WebCore::HTMLScriptElement::haveFiredLoadEvent): Treat script elements
- just like image elements: if a script element is loading, mark its JS
- wrapper, even if the element is not in the document.
-
-2009-04-18 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25170
- Upstream V8WorkerCustom.cpp and V8WorkerContextCustom.cpp for V8 bindings.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- * bindings/v8/WorkerContextExecutionProxy.h:
- * bindings/v8/custom/V8WorkerContextCustom.cpp: Added.
- * bindings/v8/custom/V8WorkerCustom.cpp: Added.
-
-2009-04-18 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/post_bug.cg://bugs.webkit.org/show_bug.cgi?id=25167
- Change createHiddenXHRDependency and removeHiddenXHRDependency so that they can be used by other custom code in V8 bindings.
-
- * bindings/v8/V8Utilities.cpp: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.cpp.
- (WebCore::createHiddenDependency):
- (WebCore::removeHiddenDependency):
- * bindings/v8/V8Utilities.h: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.h.
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-04-18 Drew Wilson <amw@apple.com>
-
- <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
-
- Reviewed by Dan Bernstein.
-
- No test case since there is no change in behavior.
-
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::characterAfter): Now handles surrogate
- pairs correctly and returns a UChar32.
- * editing/VisiblePosition.h:
- (WebCore::VisiblePosition::characterBefore): Now returns a UChar32.
- * editing/visible_units.cpp:
- (WebCore::endOfFirstWordBoundaryContext): Renamed
- firstNonComplexContextLineBreak() to this. Changed it to use the
- generic requiresContextForWordBoundary() instead of
- hasLineBreakingPropertyComplexContext().
- (WebCore::startOfLastWordBoundaryContext): Replaces
- lastNonComplexContextLineBreak(), but returns the offset of
- the character after the last character that does not require
- context for word breaking. Also changed to use
- requiresContextForWordBoundary().
- (WebCore::previousBoundary): Updated for the above changes in
- names and semantics, and changed to use
- requiresContextForWordBoundary().
- (WebCore::nextBoundary): Ditto.
- (WebCore::startWordBoundary): Ditto.
- (WebCore::endWordBoundary): Ditto.
- (WebCore::previousWordPositionBoundary): Ditto.
- (WebCore::nextWordPositionBoundary): Ditto.
- * platform/text/TextBoundaries.h:
- (WebCore::requiresContextForWordBoundary): Added.
- * platform/text/mac/TextBoundaries.mm:
-
-2009-04-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
- REGRESSION (r42569): Profiles cannot be selected in inspector profiler
-
- EventListeners are shared; RegisteredEventListeners are not. Therefore,
- when a node wrapper needs to invalidate the node's JS event listeners,
- it should invalidate its RegisteredEventListeners, not its EventListeners.
- Otherwise, it might invalidate an EventListener shared by another node.
-
- * dom/RegisteredEventListener.h:
- (WebCore::invalidateEventListeners): ditto
-
-2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6781295> video.buffered and video.seekable are not
- the same. video.buffered should return only what is buffered and
- not what is seekable
-
- * WebCore.base.exp: Added wkQTMovieMaxTimeSeekable.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::maxTimeSeekable): Return wkQTMovieMaxTimeSeekable.
-
- * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeSeekable.
- * platform/mac/WebCoreSystemInterface.mm: Ditto.
-
-2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6747241> work around QTKit no longer reaching
- QTMovieLoadStateComplete
-
- * WebCore.base.exp: Export wkQTMovieMaxTimeLoadedChangeNotification.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTMovie): observe QTMovieMaxTimeLoadedChangeNotification.
- (WebCore::MediaPlayerPrivate::updateStates): compare duuration() with maxTimeLoaded() instead of
- using QTMovieLoadStateComplete to determine if a movie are fully loaded.
-
- * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeLoadedChangeNotification.
- * platform/mac/WebCoreSystemInterface.mm: Ditto.
-
-2009-04-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Make WML work again, most regressions test were failing.
-
- * dom/Document.cpp: Be sure to create WML elements in WML namespace. Otherwhise hasTagName() comparisions fail.
- (WebCore::Document::createElement):
- * wml/WMLCardElement.cpp: Add ASSERT(hasTagName(cardTag)) to catch errors like this in future.
- (WebCore::WMLCardElement::WMLCardElement):
- * wml/WMLTagNames.in: Wrap comment in #if 0/#endif blocks, to silence the generation script.
-
-2009-04-17 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=25277
- If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
-
- Also added code to handle a caret wider than one pixel.
-
- Added fast/inline/25277.html and fast/inline/25277-2.html
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset,
- so that a caret between two characters doesn't hang over one character more than the other.
- If there is no wrapping, the caret can leave its containing block, but not its root line box.
-
-2009-04-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Some refactoring of "inline" event listeners.
-
- Renames:
- dispatchEventForType => dispatchEvent
- setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
- removeInlineEventListenerForType => clearInlineEventListener
- setInlineEventListenerForType => setInlineEventListener
- inlineEventListenerForType => getInlineEventListener
-
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::eventParameterName):
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::createInlineEventListener):
- * bindings/js/JSLazyEventListener.h: Added two helper functions for
- creating "inline" event listeners. These replace Document::createEventListener,
- and abstract the creation of JS event listeners for DOM attributes out
- of the DOM. Removed legacy JSProtectedEventListener constructor code for
- adding the event listener's function to a map, since lazy event listeners
- don't have functions at construction time.
-
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
- * dom/Document.h:
- (WebCore::Document::isSVGDocument):
- * dom/Element.cpp:
- (WebCore::Element::setWindowInlineEventListener):
- * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
- mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
- to Element, for simplicity.
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::setValueFromRenderer):
- * dom/Node.cpp:
- (WebCore::Node::dispatchFocusEvent):
- (WebCore::Node::dispatchBlurEvent):
- (WebCore::Node::dispatchEvent):
- (WebCore::Node::clearInlineEventListener):
- (WebCore::Node::setInlineEventListener):
- (WebCore::Node::getInlineEventListener):
- (WebCore::Node::onabort):
- (WebCore::Node::setOnabort):
- (WebCore::Node::etc.):
- * dom/Node.h: Updated for renames.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
-
- Updated these files for renames, and to use the new createInlineEventListener
- helper function:
-
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::parseMappedAttribute):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::parseMappedAttribute):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::onChange):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::prepareSubmit):
- (WebCore::HTMLFormElement::reset):
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::onSearch):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::loadInternal):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- (WebCore::HTMLScriptElement::dispatchErrorEvent):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/DOMWindow.cpp:
- * page/DOMWindow.h:
- (WebCore::DOMWindow::eventListeners):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- (WebCore::EventHandler::sendScrollEvent):
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::valueChanged):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::selectionChanged):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::parseMappedAttribute):
- * svg/SVGElementInstance.cpp:
- * svg/SVGImageLoader.cpp:
- (WebCore::SVGImageLoader::dispatchLoadEvent):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::dispatchErrorEvent):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::defaultEventHandler):
-
-2009-04-17 David Kilzer <ddkilzer@apple.com>
-
- Simplify FEATURE_DEFINES definition
-
- Reviewed by Darin Adler.
-
- This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
- variables to their own FeatureDefines.xcconfig file. It also
- extracts a new ENABLE_GEOLOCATION variable so that
- FEATURE_DEFINES only needs to be defined once.
-
- * Configurations/FeatureDefines.xcconfig: Added.
- * Configurations/WebCore.xcconfig: Removed definition of
- ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include
- of FeatureDefines.xcconfig.
- * WebCore.xcodeproj/project.pbxproj: Added
- FeatureDefines.xcconfig file.
- * bindings/scripts/CodeGeneratorObjC.pm: When creating a list of
- command-line macro definitions, split on one-or-more spaces
- instead of a single space since the FEATURE_DEFINES macro may
- now contain more than one space between macros if some macros
- aren't defined.
-
-2009-04-17 Brady Eidson <beidson@apple.com>
-
- Reviewed by Mark Rowe
-
- <rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::willLoadFromCache):
-
-2009-04-17 Darin Adler <darin@apple.com>
-
- Reviewed by Timothy Hatcher.
-
- Added sudden termination functions that can be called without involving
- the page or client.
-
- * GNUmakefile.am: Added SuddenTermination.h.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.
-
- * platform/SuddenTermination.h: Added.
- * platform/mac/SuddenTermination.mm: Added.
-
-2009-04-17 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Move more code into RenderSVGModelObject
-
- needsLayer() already returns false from RenderSVGModelObject
- lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.
-
- I also added comments to explain how focus rings work (now that I understand)
- I got rid of two more uses of m_absoluteBounds (nearly dead!)
-
- * rendering/RenderPath.cpp:
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
- (WebCore::RenderSVGContainer::addFocusRingRects):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::absoluteRects):
- (WebCore::RenderSVGModelObject::absoluteQuads):
- * rendering/RenderSVGModelObject.h:
-
-2009-04-16 Peter Kasting <pkasting@google.com>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=25238
- Invalidate the hovered scrollbar part when resetting the pressed part,
- since once there is no pressed part we can draw a hovered state.
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::setHoveredPart):
- (WebCore::Scrollbar::setPressedPart):
-
-2009-04-16 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25223
- REGRESSION: Back button after form submission to the same URL fails to navigate.
-
- Test: http/tests/navigation/post-goback-same-url.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): Check if the page we are leaving has
- FormData.
-
-2009-04-17 Nikolas Zimmermann <nikolas.zimmerman@torchmobile.com>
-
- Not reviewed. Fix WML enabled builds.
-
- * rendering/RenderTableRow.cpp: Remove dead code, which is no longer necessary.
- (WebCore::RenderTableRow::addChild):
- * wml/WMLInputElement.cpp: Apply same fix HTMLInputElement received. Covert RenderObject's to RenderTextControl where needed.
- (WebCore::WMLInputElement::defaultEventHandler):
-
-2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24849
-
- Add support for the media element 'played' attribute.
- This involves support of "normalized TimeRanges" as described by
- the spec.
-
- Test: media/video-played.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed
- m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges.
- (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and
- m_playedTimeRanges
- (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges
- (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime
- (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges.
- (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing.
- Set the m_playing flag.
- * html/HTMLMediaElement.h:
-
- * html/TimeRanges.cpp:
- (TimeRanges::add): Merge range(s) if overlap.
- * html/TimeRanges.h: Add various helpers (below).
- (WebCore::TimeRanges::Range::isPointInRange): Added.
- (WebCore::TimeRanges::Range::isOverlappingRange): Ditto.
- (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto.
- (WebCore::TimeRanges::Range::isBeforeRange): Ditto.
-
-2009-04-17 Darin Adler <darin@apple.com>
-
- Reviewed by Antti Koivisto.
-
- Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
- https://bugs.webkit.org/show_bug.cgi?id=25210
-
- * WebCore.base.exp: Export the core and kit function overloads that are used
- in WebKit. Also resorted this file.
-
- * WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix
- a strange problem with the file type.
-
- * bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes
- so we can use and implement the new core and kit functions. Import DOMInternal.h
- first so it can do its public/private magic.
- (-[DOMNode _rootObject]): Changed to use early-return style.
- (kitClass): Added. Tells the wrapper generator what kind of node class to create
- to wrap DOM nodes. This has the code that used to be in the _wrapNode method.
- (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper,
- dpending on whether it's a Node or an SVGElementInstance. This replace methods
- that used to be on both of those classes.
- (-[DOMNode boundingBox]): Changed to use early return, and the core function.
- (-[DOMNode lineBoxRects]): Ditto.
- (-[DOMNode renderedImage]): Ditto.
- (-[DOMRange boundingBox]): Ditto.
- (-[DOMRange lineBoxRects]): Ditto.
- (-[DOMElement image]): Ditto.
- (-[DOMElement _font]): Ditto.
- (-[DOMElement _imageTIFFRepresentation]): Ditto.
- (-[DOMElement _getURLAttribute:]): Ditto.
- (-[DOMElement isFocused]): Ditto.
- (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol,
- not a class in the binding.
- (core): Ditto.
- (-[DOMNodeFilter acceptNode:]): Use core.
-
- * bindings/objc/DOMAbstractView.mm:
- (-[DOMAbstractView document]): Use kit.
- (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer
- in the WebCore namespace, since it's headed for WebKit in the future.
- (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store
- a pointer to the Frame, not the DMWindow.
- (kit): Ditto.
-
- * bindings/objc/DOMCSS.mm:
- (kitClass): Added. Tells the wrapper generator what kind of node class to create
- to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet,
- _wrapCSSRule, and _wrapCSSValue methods.
-
- * bindings/objc/DOMEvents.mm:
- (kitClass): Added. Tells the wrapper generator what kind of node class to create
- to wrap event objects. This has the code that used to be in the _wrapEvent methods.
-
- * bindings/objc/DOMHTML.mm:
- (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core.
- (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto.
- (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
- (-[DOMHTMLInputElement _rectOnScreen]): Ditto.
- (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto.
- (-[DOMHTMLInputElement _selectedRange]): Ditto.
- (-[DOMHTMLInputElement _setAutofilled:]): Ditto.
- (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto.
- (-[DOMHTMLInputElement _isEdited]): Ditto.
- (-[DOMHTMLTextAreaElement _isEdited]): Ditto.
- (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.
-
- * bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason
- to have this header include all the other internal DOM headers. Removed unneeded
- interfaces, including the redeclaration of _init in DOMObject, since it's already
- inherited from WebScriptObject. Moved all the functions out of the WebCore
- namespace since this code is destined for WebKit, which doesn't use a namespace.
- Added kit and core functions for the two classes that live in this header.
-
- * bindings/objc/DOMInternal.mm:
- (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.
-
- * bindings/objc/DOMObject.h: Made the _internal field be private instead of
- protected. This also allows the "#define private public" trick to be used to
- make the field accessible inside the bindings code.
-
- * bindings/objc/DOMObject.mm:
- (-[DOMObject dealloc]): Updated for namespace change.
- (-[DOMObject sheet]): Use core and kit functions.
-
- * bindings/objc/DOMRGBColor.mm:
- (-[DOMRGBColor dealloc]): Updated for namespace change.
- (-[DOMRGBColor red]): Use kit function.
- (-[DOMRGBColor green]): Ditto.
- (-[DOMRGBColor blue]): Ditto.
- (-[DOMRGBColor alpha]): Ditto.
- (core): Added. Replaces the _RGBColor method.
- (kit): Added. Replaces the _wrapRGBColor method.
-
- * bindings/objc/DOMSVGPathSegInternal.mm:
- (kitClass): Added. Replaces the _wrapSVGPathSeg method.
-
- * bindings/objc/DOMUtility.mm:
- (JSC::createDOMWrapper): Use kit function.
- (createDOMWrapper): Ditto.
-
- * bindings/objc/DOMXPath.mm:
- (core): Added. Replaces the _xpathNSResolver method.
- (kit): Added. Replaces the _wrapXPathNSResolver method.
-
- * bindings/objc/ObjCEventListener.mm:
- (WebCore::ObjCEventListener::find): Changed to use early return.
- (WebCore::ObjCEventListener::handleEvent): Use kit function.
-
- * bindings/objc/ObjCNodeFilterCondition.mm:
- (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.
-
- * bindings/objc/WebScriptObject.mm:
- (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
- Updated for namespace change.
-
- * bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license"
- to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName,
- GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature.
- Changed includes to conform to new scheme. Generate core and kit
- functions instead of methods and calls to those functions. Added a new
- attribute, Polymorphic, to indicate classes that have derived subclasses.
- Removed the old ObjCCustomInternalImpl attribute.
-
- * css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions
- will be generated, with kit calling kitClass. This requires less hand-
- written code than the old ObjCCustomInternalImpl.
- * css/CSSValue.idl: Ditto.
- * css/StyleSheet.idl: Ditto.
- * dom/Event.idl: Ditto.
- * dom/Node.idl: Ditto.
- * html/HTMLCollection.idl: Ditto.
- * svg/SVGPathSeg.idl: Ditto.
-
- * editing/TextAffinity.h: Moved kit and core functions out of the
- WebCore namespace since this code is destined for WebKit, which
- doesn't use a namespace
-
- * platform/mac/ClipboardMac.mm:
- (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.
-
- * platform/mac/DragDataMac.mm:
- (WebCore::DragData::asFragment): Use core function.
-
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writeSelection): Use kit function.
-
- * svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl
- function. This can be generated in a standard way now.
- * svg/SVGViewSpec.idl: Ditto.
-
-2009-04-17 Brady Eidson <beidson@apple.com>
-
- Reviewed by Maciej Stachowiak
-
- <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage
-
- If the Page is in private browsing mode when a statement is queued up, flag that
- statement as read-only.
-
- It would be better to set the read-only flag on the database thread when it actually
- executes, but that would either require making Settings access a lock-protected operation
- or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
- If it becomes an issue in practice, we can revisit this later.
-
- Test: storage/private-browsing-readonly.html
-
- * storage/Database.cpp:
- (WebCore::Database::setAuthorizerReadOnly):
- * storage/Database.h:
-
- * storage/DatabaseAuthorizer.cpp: For all action types that would alter the database,
- deny when in read-only mode.
- (WebCore::DatabaseAuthorizer::reset):
- (WebCore::DatabaseAuthorizer::createTable):
- (WebCore::DatabaseAuthorizer::dropTable):
- (WebCore::DatabaseAuthorizer::allowAlterTable):
- (WebCore::DatabaseAuthorizer::createIndex):
- (WebCore::DatabaseAuthorizer::dropIndex):
- (WebCore::DatabaseAuthorizer::createTrigger):
- (WebCore::DatabaseAuthorizer::dropTrigger):
- (WebCore::DatabaseAuthorizer::createVTable):
- (WebCore::DatabaseAuthorizer::dropVTable):
- (WebCore::DatabaseAuthorizer::allowDelete):
- (WebCore::DatabaseAuthorizer::allowInsert):
- (WebCore::DatabaseAuthorizer::allowUpdate):
- (WebCore::DatabaseAuthorizer::setReadOnly):
- * storage/DatabaseAuthorizer.h:
-
- * storage/SQLStatement.cpp:
- (WebCore::SQLStatement::create): Add a m_readOnly flag.
- (WebCore::SQLStatement::SQLStatement): Ditto.
- (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change
- to read-only mode.
- * storage/SQLStatement.h:
-
- * storage/SQLTransaction.cpp:
- (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is
- currently in private browsing mode.
-
-2009-04-17 Eric Seidel <eric@webkit.org>
-
- Reviewed by Antti Koivisto.
-
- Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
- https://bugs.webkit.org/show_bug.cgi?id=25268
-
- Lots of minus lines. Now we're sharing more sane code
- (which will respect -webkit-transforms! and scroll offsets correctly)
-
- Which means this fixes:
- https://bugs.webkit.org/show_bug.cgi?id=20769 and
- https://bugs.webkit.org/show_bug.cgi?id=21968 too!
-
- We're no longer expanding the paint rect "for anti-aliasing", since
- I can't find a case where that's required. If it is, repaintRectInLocalCoordinates()
- should be fixed to handle those cases instead of here.
-
- This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
- as well as improves our focus ring drawing seen in svg/custom/focus-ring
- focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
- Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::repaintRectInLocalCoordinates):
- (WebCore::RenderPath::setPath):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGModelObject::computeRectForRepaint):
- * rendering/RenderSVGModelObject.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::computeRectForRepaint):
- * rendering/RenderSVGRoot.h:
-
-2009-04-17 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
- https://bugs.webkit.org/show_bug.cgi?id=25259
-
- When a node becomes visible or hidden, accessibility needs to be told to update.
-
- Test: accessibility/visible-elements.html
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
-
-2009-04-17 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix, added missing header.
-
- * platform/graphics/wx/TransformationMatrixWx.cpp:
-
-2009-04-17 Simon Hausmann <simon.hausmann@nokia.com>
-
- Unreviewed build fix.
-
- Fix the build with enabled SVG filters
-
- * rendering/RenderSVGModelObject.cpp: Include SVGResourceFilter.h.
-
-2009-04-16 Eric Roman <eroman@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25196
- Add a missing V8DOMMap include.
-
- * bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.
-
-2009-04-16 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25260
- Finish V8 custom bindings for InspectorController.
-
- * bindings/v8/custom/V8InspectorControllerCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL): Added.
-
-2009-04-16 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing
- unnecessary conversions internally when drawing bitmaps.
-
- https://bugs.webkit.org/show_bug.cgi?id=25248
-
- * platform/graphics/ImageSource.h:
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::createFrameAtIndex):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
- (WebCore::BitmapImage::drawPattern):
-
-2009-04-16 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Performing a block style change in an editable root that contains only a br adds a newline
- https://bugs.webkit.org/show_bug.cgi?id=25256
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root
- block that didn't handle a root that contained a placeholder.
-
-2009-04-16 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Fix computeContainerBoundingBox to respect viewport translations
- https://bugs.webkit.org/show_bug.cgi?id=25254
-
- Previously computeContainerBoundingBox was just adding the viewportTranslation.
- Which, although it has a confusing name, only contains the scale and translation
- for the viewBox/preserveAspectRatio adjustment. It does not contain the
- translation for the x/y offset of the viewport.
- localToParentTransform() does contain this offset, so we use that instead
- of the previous hacky code.
-
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGViewportContainer.h:
- * rendering/SVGRenderSupport.cpp:
- (WebCore::computeContainerBoundingBox):
-
-2009-04-16 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Add a localToParentTransform() method which includes the
- full transform between local and parent local coordinates.
- https://bugs.webkit.org/show_bug.cgi?id=25226
-
- Moved m_localTransform up into RenderSVGTransformableContainer
- and added a comment to RenderSVGViewportContainer to make it more
- clear that it does not have a localTransform().
-
- This patch reveals two more failed design decisions:
- 1. Use of RenderBox::absoluteTransform() to mean "absoluteTransform()
- including only my localTransform()" callers are probably using it
- incorrectly anyway and are just masking bugs in the confused code.
- 2. computeContainerBoundingBox does not include viewport translations in
- its computed bounding box, so bounding boxes will be off for parents of
- inner <svg> elements. I'll fix this an updated the results in a separate change.
-
- No functional changes, thus no tests.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::localToParentTransform):
- (WebCore::RenderObject::absoluteTransform):
- * rendering/RenderObject.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::viewportTransform):
- * rendering/RenderSVGHiddenContainer.cpp:
- * rendering/RenderSVGHiddenContainer.h:
- (WebCore::RenderSVGHiddenContainer::absoluteTransform):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::localToParentTransform):
- (WebCore::RenderSVGRoot::absoluteTransform):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGTransformableContainer.cpp:
- (WebCore::RenderSVGTransformableContainer::localToParentTransform):
- (WebCore::RenderSVGTransformableContainer::localTransform):
- * rendering/RenderSVGTransformableContainer.h:
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::localToParentTransform):
- (WebCore::RenderSVGViewportContainer::absoluteTransform):
- * rendering/RenderSVGViewportContainer.h:
- * rendering/SVGRenderSupport.cpp:
- (WebCore::computeContainerBoundingBox):
-
-2009-04-16 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- Fix Chromium's rendering of <option> elements inside of <optgroups>.
-
- https://bugs.webkit.org/show_bug.cgi?id=25244
-
- Test (will included as a manual test by https://bugs.webkit.org/show_bug.cgi?id=24900):
-
- <select>
- <optgroup label="Should be bold">
- <option>Should not be bold</option>
- </optgroup>
- </select>
-
- * css/themeWin.css: adding comments
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::getRowFont): use menuStyle() rather than the item's style
-
-2009-04-16 Eric Roman <eroman@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25218
-
- Make DOMWindow::inlineEventListenerForType not have the "inline"
- keyword. As this method gets used outside of DOMWindow.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::inlineEventListenerForType):
-
-2009-04-16 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Antti Koivisto.
-
- Fix <rdar://problem/6766969>
-
- When deferred repaints are enabled and being reset and there is a active
- timer, stop the timer and do the deferred repaints immediately.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::resetDeferredRepaintDelay):
-
-2009-04-16 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25241
- Remove superfluous NotImplemented.h includes.
-
- * html/CanvasRenderingContext2D.cpp:
- * html/CanvasStyle.cpp:
- * page/AccessibilityRenderObject.cpp:
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- * platform/graphics/GraphicsContext.cpp:
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- * platform/graphics/cairo/PathCairo.cpp:
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- * platform/graphics/gtk/FontGtk.cpp:
- * platform/graphics/gtk/IconGtk.cpp:
- * platform/graphics/qt/IconQt.cpp:
- * platform/graphics/qt/ImageQt.cpp:
- * platform/graphics/qt/ImageSourceQt.cpp:
- * platform/graphics/skia/ImageBufferSkia.cpp:
- * platform/graphics/skia/ImageSkia.cpp:
- * platform/graphics/win/ColorSafari.cpp:
- * platform/graphics/win/FontWin.cpp:
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- * platform/graphics/win/GraphicsContextCairoWin.cpp:
- * platform/graphics/win/SimpleFontDataCairoWin.cpp:
- * platform/graphics/wx/ImageWx.cpp:
- * platform/graphics/wx/TransformationMatrixWx.cpp:
- * platform/gtk/PlatformScreenGtk.cpp:
- * platform/gtk/PopupMenuGtk.cpp:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/gtk/ScrollbarGtk.cpp:
- * platform/network/cf/ResourceHandleCFNet.cpp:
- * platform/posix/FileSystemPOSIX.cpp:
- * platform/qt/DragDataQt.cpp:
- * platform/qt/FileSystemQt.cpp:
- * platform/qt/Localizations.cpp:
- * platform/qt/PopupMenuQt.cpp:
- * platform/win/EditorWin.cpp:
- * platform/win/PasteboardWin.cpp:
- * platform/wx/KeyboardEventWx.cpp:
- * platform/wx/PopupMenuWx.cpp:
- * platform/wx/SharedTimerWx.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- * plugins/mac/PluginPackageMac.cpp:
- * plugins/qt/PluginPackageQt.cpp:
- * plugins/win/PluginViewWin.cpp:
- * rendering/RenderThemeChromiumLinux.cpp:
- * svg/graphics/SVGImage.cpp:
-
-2009-04-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Some cleanup in event handling code.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- * bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener
- and findJSProtectedEventListener because they are now unused.
-
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventListener.h:
- (WebCore::JSEventListener::clearGlobalObject):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::JSLazyEventListener::~JSLazyEventListener):
- (WebCore::JSLazyEventListener::globalObject):
- * bindings/js/JSLazyEventListener.h:
- (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener,
- and merged it with JSLazyEventListener, the only remaining event listener
- that still GC-protects its function and global object.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::ScriptController):
- * bindings/js/ScriptController.h:
- (WebCore::ScriptController::setEventHandlerLineNumber):
- (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno =>
- handlerLineNumber, because anything less would be uncivilized. Removed
- createInlineEventListener because it mostly did irrelevent work, so it
- just got in the way of understanding how event handler creation works.
-
- * dom/Document.cpp:
- (WebCore::Document::createEventListener):
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::startElementNs):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::processToken): Ditto.
-
-2009-04-16 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
- crashes on load due to messy HTML in search form
- -and corresponding-
- <rdar://problem/6210633>
-
- Before this patch, <form>s were allowed to sit inside tables
- without being wrapped by anonymous table parts. There was also a
- concept that such a form could be "demoted" and would not be
- allowed to have any children. This patch has the HTML parser mark
- form elements that have been demoted as such, and then the demoted
- forms are not given renderers. I also removed the code that allowed
- forms to sit in tables without anonymous table sections. So now any
- forms that do manage to get a renderer inside a table will also be
- wrapped with appropriate table parts.
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::HTMLFormElement):
- (WebCore::HTMLFormElement::rendererIsNeeded):
- * html/HTMLFormElement.h:
- (WebCore::HTMLFormElement::setDemoted):
- (WebCore::HTMLFormElement::isDemoted):
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::insertNode):
+ (WebCore::RenderBox::paintRootBoxDecorations):
+ (WebCore::RenderBox::paintBoxDecorations):
+ (WebCore::RenderBox::paintMask):
+ (WebCore::RenderBox::paintMaskImages):
+ (WebCore::RenderBox::paintFillLayers):
+ (WebCore::RenderBox::paintFillLayer):
+ * rendering/RenderBox.h:
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::paintBoxDecorations):
+ (WebCore::RenderFieldset::paintMask):
* rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::addChild):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addChild):
-
-2009-04-16 Xiaomei Ji <xji@chromium.org>
-
- Reviewed by Simon Fraser.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=24527
- caret does not paint the first time you focus on a 0px right padding RTL div
-
- Test: fast/forms/caret-rtl.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect): When calculating x-axis if
- alignment is alignRight, we need to subtract the caretWidth so that the
- caret at IntRect(x, y, caretWidth, height) is inside the block.
-
-2009-04-16 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25228
- SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
-
- Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::localCaretRect):
- (WebCore::SelectionController::absoluteBoundsForLocalRect):
- (WebCore::SelectionController::caretRepaintRect):
- (WebCore::SelectionController::recomputeCaretRect):
- * editing/SelectionController.h:
-
-2009-04-16 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25187
- Bug 25187: <video> may not be rendered upon certain racy conditions
-
- Always create the video renderer when the load state reaches QTMovieLoadStateLoaded and
- the element is visible, not just when the movie has just been opened.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false
- assumption on the state changes order. Create the renderer if none is present,
- when movie is loaded instead.
-
-2009-04-16 Eric Seidel <eric@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code
-
- RenderSVGModelObject has much more interesting code it can share,
- but I'm just trying to get the commits out of my local branch and into
- the repository in any order I can. :) This one was small.
-
- This will be used by the unified RenderSVGModelObject
- clippedOverflowRectForRepaint patch coming soon.
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::clippedOverflowRectForRepaint):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
- * rendering/RenderSVGModelObject.cpp:
- (WebCore::RenderSVGModelObject::filterBoundingBox):
- * rendering/RenderSVGModelObject.h:
-
-2009-04-16 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Eric Seidel and Adam Roben.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Simplified some EventHandler creation code.
-
- Removed a pile of code whose sole purpose was to allow SVG event handlers
- to supply a parameter named "evt" instead of the normal "event", and
- replaced it with a single parameter to JSLazyEventListener's constructor
- specifying the parameter name to use.
-
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSLazyEventListener.h:
- (WebCore::JSLazyEventListener::create):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createInlineEventListener):
- * bindings/js/ScriptController.h:
- * dom/Document.cpp:
- (WebCore::Document::createEventListener):
-
-2009-04-15 Eric Seidel <eric@webkit.org>
-
- Reviewed by David Hyatt.
-
- Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
- in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
- https://bugs.webkit.org/show_bug.cgi?id=25224
-
- objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"
-
- repaintRectInLocalCoordinates() should return the a rect covering all painted content.
- However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
- in this patch. In a future patch, repaintRectInLocalCoordinates will be fixed to return
- a rect covering all painted content. In order to avoid changing several hundred layout test results, I've left
- the behavior as-is for now. The returned rect is used by various repaintRectInLocalCoordinates
- implementations and sometimes adjusted to include all painted content, but not always, and
- the places where the adjustments are made are sometimes wrong. Again, will be fixed in
- an upcoming patch.
-
- This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
- bounding-box relative gradients on SVGFont glyphs to not paint correctly.
- I chose not to try and fix the bug in this patch and instead left a FIXME.
-
- This patch also discovered that at least tspan.getBBox() is broken. This
- along with the foreignObject.getBBox() change will be tested (and fixed) in a
- later patch. https://bugs.webkit.org/show_bug.cgi?id=25225
-
- No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.
-
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch
- (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
- * rendering/RenderForeignObject.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented.
- (WebCore::RenderObject::repaintRectInLocalCoordinates):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::objectBoundingBox):
- (WebCore::RenderPath::repaintRectInLocalCoordinates):
- (WebCore::RenderPath::clippedOverflowRectForRepaint):
- (WebCore::RenderPath::lineHeight):
- (WebCore::RenderPath::baselinePosition):
- (WebCore::RenderPath::paint):
- (WebCore::RenderPath::addFocusRingRects):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
- (WebCore::RenderSVGContainer::objectBoundingBox):
- (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGGradientStop.h:
- (WebCore::RenderSVGGradientStop::objectBoundingBox):
- (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::objectBoundingBox):
- (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::objectBoundingBox):
- (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
- (WebCore::RenderSVGImage::calculateAbsoluteBounds):
- (WebCore::RenderSVGImage::addFocusRingRects):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::objectBoundingBox):
- (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGTSpan.h:
- (WebCore::RenderSVGTSpan::objectBoundingBox):
- (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
- (WebCore::RenderSVGText::objectBoundingBox):
- (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- * rendering/RenderSVGText.h:
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::viewportTransform):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::computeContainerBoundingBox):
- * rendering/SVGRenderSupport.h:
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::operator<<):
- * svg/SVGFont.cpp:
- (WebCore::Font::drawTextUsingSVGFont):
- * svg/SVGLocatable.cpp:
- (WebCore::SVGLocatable::getBBox):
- * svg/SVGPatternElement.cpp:
- (WebCore::SVGPatternElement::buildPattern):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::createMaskAndSwapContextForTextGradient):
- (WebCore::clipToTextMask):
- (WebCore::SVGPaintServerGradient::setup):
- * svg/graphics/SVGPaintServerPattern.cpp:
- (WebCore::SVGPaintServerPattern::setup):
-
-2009-04-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6032139> Table cell widths calculated
- incorrectly on table that uses table-layout:fixed, colspans, and a mix
- of percentage and pixel widths
-
- Test: fast/table/fixed-granular-cols.html
-
- The incorrect widths resulted from incorrect handling of the case where
- the <col> elements are more granular than the table cells.
-
- * rendering/FixedTableLayout.cpp:
- (WebCore::FixedTableLayout::calcWidthArray): When processing <col>
- elements, append effective columns or split existing effective columns
- as needed.
-
-2009-04-16 Alexey Proskuryakov <ap@webkit.org>
-
- <rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential
-
- Rolled out <http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
- authentication challenge are different, after all. Added a FIXME comment about a possible
- future improvement.
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::clearAuthentication):
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- (WebCore::ResourceHandle::receivedCredential):
- (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
- (WebCore::ResourceHandle::receivedCancellation):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
- (WebCore::ResourceHandle::receivedCredential):
- (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
- (WebCore::ResourceHandle::receivedCancellation):
-
-2009-04-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
- a page with breakpoints set
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::clearJSFunctionInline):
- (WebCore::JSEventListener::markJSFunction):
- * bindings/js/JSEventListener.h: Actually clear our function and global
- object pointers when our client instructs us to. (Oops!) Also, mark
- our global object while we still intend to use it.
-
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::mark):
- (WebCore::toJS):
- * bindings/scripts/CodeGeneratorJS.pm:
- * svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure
- that the corresponding element also has a wrapper, to keep its event
- listeners alive.
-
-2009-04-15 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25201
- Add ScriptFunctionCall/ScriptObject for V8.
-
- * bindings/v8/ScriptFunctionCall.cpp: Added.
- * bindings/v8/ScriptFunctionCall.h: Added.
- * bindings/v8/ScriptObject.cpp: Added.
- * bindings/v8/ScriptObject.h: Added.
- * bindings/v8/ScriptObjectQuarantine.cpp: Added.
- * bindings/v8/ScriptObjectQuarantine.h: Added.
- * bindings/v8/ScriptScope.cpp: Added.
- * bindings/v8/ScriptScope.h: Added.
- * bindings/v8/ScriptState.h:
- (WebCore::ScriptState::ScriptState): Added new constructors.
- (WebCore::ScriptState::frame): Added Frame ptr accessor.
- * bindings/v8/ScriptString.h:
- (WebCore::ScriptString::ScriptString): Added default constructor.
- * bindings/v8/ScriptValue.h:
- (WebCore::ScriptValue::isEqual): Added.
-
-2009-04-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.
-
- * GNUmakefile.am:
-
-2009-04-15 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6785760> WebCore should use a maximum of 6 connections per host, not 4
-
- Reviewed by Adam Roben.
-
- * platform/network/ResourceRequestBase.cpp:
- * platform/network/cf/ResourceRequestCFNet.cpp:
- (WebCore::initializeMaximumHTTPConnectionCountPerHost):
-
-2009-04-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Add special casing to bindings generator so that custom functions
- starting with xml or xslt conform to WebKit style guidelines.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::xmlHttpRequest):
- (WebCore::JSDOMWindow::xsltProcessor):
- * bindings/scripts/CodeGenerator.pm:
-
-2009-04-15 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
- https://bugs.webkit.org/show_bug.cgi?id=25221
-
- RenderSVGModelObject is the base rendering class for things which live
- in the SVG rendering tree. Not all SVG renders are RenderSVGModelObjects yet.
-
- More patches coming. This is just adding the class, future patches
- will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.
-
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::RenderPath):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::RenderSVGContainer):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGModelObject.cpp: Added.
- (WebCore::RenderSVGModelObject::RenderSVGModelObject):
- * rendering/RenderSVGModelObject.h: Added.
- (WebCore::RenderSVGModelObject::requiresLayer):
- * rendering/RenderTreeAsText.cpp:
- * rendering/SVGRenderTreeAsText.cpp:
-
-2009-04-15 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Remove more dead code from RenderSVGHiddenContainer.
-
- lineHeight and baselinePosition used to be on RenderSVGContainer
- (of which this is a subclass) because RenderSVGContainer used
- to be a RenderBox and always the renderer for <svg>
- Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
- and RenderSVGViewportContainer (when inside SVG content)
- so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.
-
- * rendering/RenderSVGHiddenContainer.cpp:
- * rendering/RenderSVGHiddenContainer.h:
-
-2009-04-15 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Remove unneeded (broken) code from SVG renderers
- https://bugs.webkit.org/show_bug.cgi?id=25214
-
- Mostly due to my historical confusions about the render tree
- and some methods not being removed after classes were split.
-
- RenderSVGRoot is an RenderBox and should just use all the
- standard RenderBox methods for inspector and repaint rects.
-
- RenderSVGContainer is *not* a RenderBox (any more) and thus
- doesn't need lineHeight or width/height or calcBounds.
-
- RenderSVGViewportContainer had some broken code which tried
- to see if the click was inside the container at all, but it
- was using width/height metrics based off of the containing
- block (from calcWidth) which is wrong (since its real
- width/height are from its containing viewport not containing block).
-
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::RenderSVGContainer):
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGRoot.cpp:
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::layout):
- (WebCore::RenderSVGViewportContainer::nodeAtPoint):
-
-2009-04-15 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser and Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25217
- Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
- Add ASSERT(element) to all these functions since they should never be passed a null element.
-
- * svg/SVGLocatable.cpp:
- (WebCore::isViewportElement):
- (WebCore::SVGLocatable::nearestViewportElement):
- (WebCore::SVGLocatable::farthestViewportElement):
- (WebCore::SVGLocatable::getBBox):
- (WebCore::SVGLocatable::getCTM):
- (WebCore::SVGLocatable::getScreenCTM):
-
-2009-04-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Remove support for the ObjCIvar extended attribute from the Objective-C
- bindings generator. It is not used anymore.
-
- * bindings/scripts/CodeGeneratorObjC.pm:
-
-2009-04-15 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=25204
- Create a fast path for ReplaceSelectionCommand that merges text nodes
-
- During simple pastes, where we're just pasting a text node into a run of text, we would split the current
- text and insert the new node in between. This is slow and we hit this bug:
-
- https://bugs.webkit.org/show_bug.cgi?id=6148
-
- in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
-
- This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
- text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
- (WebCore::ReplaceSelectionCommand::performTrivialReplace):
- * editing/ReplaceSelectionCommand.h:
- * editing/TextIterator.cpp:
-
-2009-04-15 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- Move VDMX parsing into the Chromium Linux port.
-
- https://bugs.webkit.org/show_bug.cgi?id=25116
-
- VDMX tables are optional tables in TrueType fonts which contain the
- exact pixel height of a given font at a given pel size. In order to
- match Windows font metrics we have to use these numbers.
-
- Previously, the parsing was performed in Skia. As part of the merge
- with upstream Skia, an interface for getting table data from a font
- has been added to Skia and we're moving the parsing into WebKit.
-
- This does not change any layout tests.
-
- * platform/graphics/chromium/FontPlatformDataLinux.cpp:
- (WebCore::FontPlatformData::uniqueID):
- * platform/graphics/chromium/FontPlatformDataLinux.h:
- * platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
- * platform/graphics/chromium/FontTrueTypeLinux.h: Added.
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformWidthForGlyph):
-
-2009-04-15 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25180
-
- Restore stroked outlines to PlatformContextSkia::drawRect().
- These were removed inadvertently in r41805, aka
- https://bugs.webkit.org/show_bug.cgi?id=24662.
- SkRect is { left, top, right, bottom }, not { left, top, width, height }.
-
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::drawRect):
-
-2009-04-15 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6777374> Generated content with display: run-in
- causes a crash
-
- Test: fast/runin/generated.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is
- generated, and if so, make the RenderInline anonymous instead of passing
- a 0 node to the RenderInline constructor. If the run-in itself is
- generated, do move :before and :after children from the block into the
- inline, as they will not be regenerated. Changed nested ifs into early
- returns.
-
-2009-04-15 Eric Roman <eroman@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=25192
-
- Expose DOMWindow::removeInlineEventListenerForType and
- DOMWindow::inlineEventListenerForType as public.
-
- * page/DOMWindow.h:
-
-2009-04-14 Eric Roman <eroman@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25198
-
- Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
- in a USE(JSC), since it doesn't compile with V8 bindings.
-
- * dom/RegisteredEventListener.h:
-
-2009-04-15 Eric Roman <eroman@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25194
-
- Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
- use the new name.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
-
-2009-04-14 Alexey Proskuryakov <ap@webkit.org>
-
- Rubber-stamped by Darin Adler.
-
- Don't keep platform objects for authentication challenge in ResourceHandleInternal.
- We already have a copy in AuthenticationChallenge object.
-
- * platform/network/ResourceHandle.cpp:
- (WebCore::ResourceHandle::clearAuthentication):
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- (WebCore::ResourceHandle::receivedCredential):
- (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
- (WebCore::ResourceHandle::receivedCancellation):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
- (WebCore::ResourceHandle::receivedCredential):
- (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
- (WebCore::ResourceHandle::receivedCancellation):
-
-2009-04-14 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Nixed some now-defunct autogeneration code.
-
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-14 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
- file:/// URLs from remote in Safari
-
- Tests: http/tests/security/local-video-poster-from-remote.html
- http/tests/security/local-video-source-from-remote.html
- http/tests/security/local-video-src-from-remote.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine unless loader->canLoad()
- says it is OK.
-
-2009-04-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Part of <rdar://problem/6150868>
- Fix incorrect handling of content that needs to go into the head element
- once the head element has been removed.
-
- Test: fast/parser/head-content-after-head-removal.html
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
- (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
- (WebCore::HTMLParser::createHead): Ditto.
- * html/HTMLParser.h: Make m_head a RefPtr.
-
-2009-04-14 Geoffrey Garen <ggaren@apple.com>
-
- Used svn merge -r42529:42528 to roll out my last patch because it broke
- the build.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
- (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
- * bindings/js/JSDOMGlobalObject.h:
-
-2009-04-14 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Nixed some now-dead code related to protected event listeners.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- * bindings/js/JSDOMGlobalObject.h:
-
-2009-04-14 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Stop using protected event listeners on SVGElementInstance.
-
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::mark): Mark our event listeners, since
- they're not protected anymore.
-
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener): Make unprotected
- event listeners, since we mark them now.
-
- * bindings/scripts/CodeGeneratorJS.pm: Autogenerate event listener
- invalidation for SVGElementInstance.
-
- * svg/SVGElementInstance.h:
- (WebCore::SVGElementInstance::eventListeners): Added an accessor, for
- the sake of autogenerated code.
-
- * svg/SVGElementInstance.idl: Removed the ProtectedEventListener attribute
- from event listener properties. Added a CustomMarkFunction attribute,
- since we need to mark our event listeners.
-
-2009-04-14 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-04-14 Steve Falkenburg <sfalken@apple.com>
-
- Add header guards to WebCore forwarding headers.
-
- Speeds up WebCore debug build on Windows by 12% on my system,
- since Visual Studio appears to not optimize for standard header
- guards in included files.
-
- Rubber stamped by Ada Chan.
-
- * ForwardingHeaders/debugger/Debugger.h:
- * ForwardingHeaders/debugger/DebuggerActivation.h:
- * ForwardingHeaders/debugger/DebuggerCallFrame.h:
- * ForwardingHeaders/interpreter/CallFrame.h:
- * ForwardingHeaders/interpreter/Interpreter.h:
- * ForwardingHeaders/masm/X86Assembler.h:
- * ForwardingHeaders/parser/Parser.h:
- * ForwardingHeaders/parser/SourceCode.h:
- * ForwardingHeaders/parser/SourceProvider.h:
- * ForwardingHeaders/pcre/pcre.h:
- * ForwardingHeaders/profiler/Profile.h:
- * ForwardingHeaders/profiler/ProfileNode.h:
- * ForwardingHeaders/profiler/Profiler.h:
- * ForwardingHeaders/runtime/ArgList.h:
- * ForwardingHeaders/runtime/ArrayPrototype.h:
- * ForwardingHeaders/runtime/BooleanObject.h:
- * ForwardingHeaders/runtime/CallData.h:
- * ForwardingHeaders/runtime/Collector.h:
- * ForwardingHeaders/runtime/CollectorHeapIterator.h:
- * ForwardingHeaders/runtime/Completion.h:
- * ForwardingHeaders/runtime/ConstructData.h:
- * ForwardingHeaders/runtime/DateInstance.h:
- * ForwardingHeaders/runtime/Error.h:
- * ForwardingHeaders/runtime/FunctionConstructor.h:
- * ForwardingHeaders/runtime/FunctionPrototype.h:
- * ForwardingHeaders/runtime/Identifier.h:
- * ForwardingHeaders/runtime/InitializeThreading.h:
- * ForwardingHeaders/runtime/InternalFunction.h:
- * ForwardingHeaders/runtime/JSArray.h:
- * ForwardingHeaders/runtime/JSByteArray.h:
- * ForwardingHeaders/runtime/JSFunction.h:
- * ForwardingHeaders/runtime/JSGlobalData.h:
- * ForwardingHeaders/runtime/JSGlobalObject.h:
- * ForwardingHeaders/runtime/JSLock.h:
- * ForwardingHeaders/runtime/JSNumberCell.h:
- * ForwardingHeaders/runtime/JSObject.h:
- * ForwardingHeaders/runtime/JSString.h:
- * ForwardingHeaders/runtime/JSValue.h:
- * ForwardingHeaders/runtime/Lookup.h:
- * ForwardingHeaders/runtime/ObjectPrototype.h:
- * ForwardingHeaders/runtime/Operations.h:
- * ForwardingHeaders/runtime/PropertyMap.h:
- * ForwardingHeaders/runtime/PropertyNameArray.h:
- * ForwardingHeaders/runtime/Protect.h:
- * ForwardingHeaders/runtime/PrototypeFunction.h:
- * ForwardingHeaders/runtime/StringObject.h:
- * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h:
- * ForwardingHeaders/runtime/StringPrototype.h:
- * ForwardingHeaders/runtime/Structure.h:
- * ForwardingHeaders/runtime/SymbolTable.h:
- * ForwardingHeaders/runtime/UString.h:
- * ForwardingHeaders/wrec/WREC.h:
- * ForwardingHeaders/wtf/ASCIICType.h:
- * ForwardingHeaders/wtf/AlwaysInline.h:
- * ForwardingHeaders/wtf/Assertions.h:
- * ForwardingHeaders/wtf/ByteArray.h:
- * ForwardingHeaders/wtf/CurrentTime.h:
- * ForwardingHeaders/wtf/Deque.h:
- * ForwardingHeaders/wtf/DisallowCType.h:
- * ForwardingHeaders/wtf/FastMalloc.h:
- * ForwardingHeaders/wtf/Forward.h:
- * ForwardingHeaders/wtf/GetPtr.h:
- * ForwardingHeaders/wtf/HashCountedSet.h:
- * ForwardingHeaders/wtf/HashFunctions.h:
- * ForwardingHeaders/wtf/HashMap.h:
- * ForwardingHeaders/wtf/HashSet.h:
- * ForwardingHeaders/wtf/HashTable.h:
- * ForwardingHeaders/wtf/HashTraits.h:
- * ForwardingHeaders/wtf/ListHashSet.h:
- * ForwardingHeaders/wtf/ListRefPtr.h:
- * ForwardingHeaders/wtf/Locker.h:
- * ForwardingHeaders/wtf/MainThread.h:
- * ForwardingHeaders/wtf/MathExtras.h:
- * ForwardingHeaders/wtf/MessageQueue.h:
- * ForwardingHeaders/wtf/Noncopyable.h:
- * ForwardingHeaders/wtf/NotFound.h:
- * ForwardingHeaders/wtf/OwnArrayPtr.h:
- * ForwardingHeaders/wtf/OwnPtr.h:
- * ForwardingHeaders/wtf/PassRefPtr.h:
- * ForwardingHeaders/wtf/Platform.h:
- * ForwardingHeaders/wtf/PtrAndFlags.h:
- * ForwardingHeaders/wtf/RandomNumber.h:
- * ForwardingHeaders/wtf/RefCounted.h:
- * ForwardingHeaders/wtf/RefCountedLeakCounter.h:
- * ForwardingHeaders/wtf/RefPtr.h:
- * ForwardingHeaders/wtf/RetainPtr.h:
- * ForwardingHeaders/wtf/StdLibExtras.h:
- * ForwardingHeaders/wtf/StringExtras.h:
- * ForwardingHeaders/wtf/ThreadSpecific.h:
- * ForwardingHeaders/wtf/Threading.h:
- * ForwardingHeaders/wtf/TypeTraits.h:
- * ForwardingHeaders/wtf/UnusedParam.h:
- * ForwardingHeaders/wtf/Vector.h:
- * ForwardingHeaders/wtf/VectorTraits.h:
- * ForwardingHeaders/wtf/dtoa.h:
- * ForwardingHeaders/wtf/unicode/Collator.h:
- * ForwardingHeaders/wtf/unicode/UTF8.h:
- * ForwardingHeaders/wtf/unicode/Unicode.h:
- * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h:
-
-2009-04-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Adele Peterson.
-
- Use a template function to generalize the way we create non-caching
- JS function getters.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::nonCachingStaticFunctionGetter):
- (WebCore::JSDOMWindow::customGetOwnPropertySlot):
-
-2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=25099
-
- When creating a QNetworkRequest make sure to populate the
- CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
-
- * WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:
- (tst_QWebPage::requestCache):
-
- * platform/network/qt/ResourceRequestQt.cpp:
- (WebCore::ResourceRequest::toNetworkRequest):
-
-2009-04-14 Timothy Hatcher <timothy@apple.com>
-
- Fix a world leak caused by opening the Web Inspector. This was
- a regression caused by the InspectorController becoming refcounted.
-
- <rdar://problem/6782944>
-
- Reviewed by Darin Adler.
-
- * bindings/js/ScriptObject.cpp:
- (WebCore::ScriptGlobalObject::get): Renamed to better match the
- other functions.
- (WebCore::ScriptGlobalObject::remove): Added. Deletes the property.
- * bindings/js/ScriptObject.h:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::~InspectorController): Do less work
- at destruction time since the object lifetime is tied to JS GC.
- Assert that inspectedPageDestroyed cleared everything needed.
- (WebCore::InspectorController::inspectedPageDestroyed): Do most
- of the work that ~InspectorController was doing.
- (WebCore::InspectorController::scriptObjectReady): Renamed getObject.
-
-2009-04-14 Antony Sargent <asargent@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- This is some cleanup motivated by the crash in http://crbug.com/9775 , which
- happens because of calling window.open inside a window.onload handler.
-
- These changes are just part of the fix, along with some asserts to help prevent
- breakage on future changes.
-
- https://bugs.webkit.org/show_bug.cgi?id=25132
-
- * bindings/v8/V8EventListenerList.cpp:
- (WebCore::V8EventListenerList::add):
- (WebCore::V8EventListenerList::remove):
- (WebCore::V8EventListenerList::clear):
- * bindings/v8/V8EventListenerList.h:
- (WebCore::V8EventListenerList::size):
-
-2009-04-14 Evan Martin <evan@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25142
- Fix a race that can occur between flex and the perl script that parses
- its output.
+ (WebCore::RenderTable::paintBoxDecorations):
+ (WebCore::RenderTable::paintMask):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::paintBackgroundsBehindCell):
+ (WebCore::RenderTableCell::paintMask):
- * css/maketokenizer: Consume all input.
+2009-06-27 Ryosuke Niwa <rniwa@google.com>
-2009-04-14 Rohit Rao <rohitrao@google.com>
+ Reviewed by Eric Seidel.
- Reviewed by Dan Bernstein.
+ https://bugs.webkit.org/show_bug.cgi?id=26762
- https://bugs.webkit.org/show_bug.cgi?id=25184
- Do not change the text color for selected text in Mac Chromium.
+ Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
+ https://bugs.webkit.org/show_bug.cgi?id=21712
- * rendering/RenderThemeChromiumMac.h:
- (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
- Now returns false, matching the behavior of Safari on Mac.
+ Added few utility functions to htmlediting.h/cpp
-2009-04-14 Justin Garcia <justin.garcia@apple.com>
+ isVisibilyAdjacent checks whether the first position is visibly next to the second position.
+ i.e. there is no visible node between the first and second positions
- Reviewed by Eric Seidel.
+ canMergeLists checks whether two lists can be merged.
+ It checks the type of list, the editing boundary, and adjacency of the lists.
- https://bugs.webkit.org/show_bug.cgi?id=25172
- Extra partial layout during the first keypress in an empty block
-
- Determining if a placeholder needs to be removed requires the creation of a VisiblePosition
- which was triggering layout before we were finished modifying the DOM for the insert operation.
-
- Find out if we need to remove a placeholder near the start of the operation, and if we do remember
- where it's located. Then, later, remove it along with all of the other DOM operations we perform.
-
- Renamed lineBreakExistsAtPosition to lineBreakExistsAtVisiblePosition and added a lineBreakExistsAtPosition
- that takes in a Position. In InsertTextCommand, we can use the latter, since we normalize manually.
-
- removePlaceholderAt now takes in a Position that it assumes has already been checked for a placeholder.
-
- No test added as this only effects performance.
+ Tests: editing/execCommand/indent-nested-lists-1.html
+ editing/execCommand/indent-nested-lists-2.html
+ editing/execCommand/indent-nested-lists-3.html
+ editing/execCommand/indent-nested-lists-4.html
+ editing/execCommand/indent-nested-lists-5.html
+ editing/execCommand/indent-nested-lists-6.html
+ editing/execCommand/indent-nested-lists-7.html
+ editing/execCommand/outdent-nested-lists-1.html
+ editing/execCommand/outdent-nested-lists-2.html
+ editing/execCommand/outdent-nested-lists-3.html
+ editing/execCommand/outdent-nested-lists-4.html
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::removePlaceholderAt):
- (WebCore::CompositeEditCommand::moveParagraphs):
- (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- * editing/CompositeEditCommand.h:
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
- (WebCore::DeleteSelectionCommand::doApply):
- * editing/FormatBlockCommand.cpp:
- (WebCore::FormatBlockCommand::doApply):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::input):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
+ (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
+ (WebCore::IndentOutdentCommand::indentIntoBlockquote):
+ (WebCore::IndentOutdentCommand::indentRegion):
+ * editing/IndentOutdentCommand.h:
* editing/htmlediting.cpp:
- (WebCore::lineBreakExistsAtVisiblePosition):
- (WebCore::lineBreakExistsAtPosition):
+ (WebCore::enclosingListChild):
+ (WebCore::canMergeLists):
+ (WebCore::isVisibilyAdjacent):
* editing/htmlediting.h:
-2009-04-14 Adam Roben <aroben@apple.com>
-
- Remove support for profile-guided optimization on Windows
-
- Rubber-stamped by Steve Falkenburg.
-
- * WebCore.vcproj/WebCore.vcproj: Removed the Release_PGO
- configuration.
-
-2009-04-14 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25163
- Upstream fix for releasing v8 objects on worker thread termination in Chromium.
-
- * bindings/v8/V8DOMMap.cpp:
- (WebCore::domDataList): Now uses Vector instead of HashMap.
- (WebCore::domDataListMutex):
- (WebCore::ThreadSpecificDOMData::ThreadSpecificDOMData): remove usage of currentThread();
- (WebCore::ThreadSpecificDOMData::~ThreadSpecificDOMData): ditto.
- (WebCore::NonMainThreadSpecificDOMData::~NonMainThreadSpecificDOMData): moved call to removeAllDOMObjectsInCurrentThread() to ~WorkerScriptController.
- (WebCore::handleWeakObjectInOwningThread):
- (WebCore::derefDelayedObjects):
- (WebCore::removeAllDOMObjectsInCurrentThread): not static anymore.
- * bindings/v8/V8DOMMap.h:
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::dispose): removed code that avoided dual-dereference of WorkerContext.
- (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): this ref() is countered in removeAllDOMObjectsInCurrentThread(), when the WorkerContext is removed from the v8 map.
- * bindings/v8/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::~WorkerScriptController):
-
-2009-04-14 Adam Roben <aroben@apple.com>
-
- Fix Bug 25183: Split up WebCore.vcproj's settings into vsprops files
-
- <https://bugs.webkit.org/show_bug.cgi?id=25183>
-
- WebCore.vcproj now uses a set of .vsprops files to store most of its
- settings.
-
- Reviewed by Darin Adler.
-
- * WebCore.vcproj/WebCore.vcproj: Moved settings from here into the new
- .vsprops files.
-
- * WebCore.vcproj/WebCoreCFNetwork.vsprops: Added. Contains settings
- for ports that build against CFNetwork.
- * WebCore.vcproj/WebCoreCG.vsprops: Added. Contains settings for ports
- that build against CoreGraphics.
- * WebCore.vcproj/WebCoreCURL.vsprops: Added. Contains settings for
- ports that build against libcurl.
- * WebCore.vcproj/WebCoreCairo.vsprops: Added. Contains settings for
- ports that build against Cairo.
- * WebCore.vcproj/WebCoreCommon.vsprops: Added. Contains settings
- shared by all ports.
- * WebCore.vcproj/WebCoreMediaQT.vsprops: Added. Contains settings for
- ports that use QTMovieWin to implement the MediaPlayerPrivate
- interface.
- * WebCore.vcproj/WebCorePthreads.vsprops: Added. Contains settings for
- ports that build against pthreads.
-
-2009-04-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- http/tests/xmlhttprequest/basic-auth.html fails on Tiger.
-
- Turns out that NSURLCredentialPersistenceNone doesn't work on Tiger, so we have to use
- session persistence.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Route the credential through
- receivedCredential(), ensuring that the Tiger-specific need to use session credentials
- is honored.
- (WebCore::ResourceHandle::receivedCredential): On Tiger, change PersistenceNone to
- PersistenceForSession, because the former doesn't work.
-
-2009-04-14 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
-
- Test: editing/inserting/6703873.html
-
- * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- If the startNode's original parent is now empty, we can remove it. Its already been cloned and copied with the startNode,
- so we only need to keep it around if it actually holds some original content, otherwise it will look like an extra empty
- container in the document.
-
-2009-04-14 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Add a proper implementation of AtkText::get_text and
- AtkText::get_character_count, which takes into account non
- TextControl text. With this the 'Text' field in Accerciser's
- Interface Viewer is filled correctly.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-14 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Remove some dead code and g_return_if_fail from static functions.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-14 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Also implement text interface for StaticTextRole, which covers
- most of the text in web pages.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-14 Alexey Proskuryakov <ap@webkit.org>
-
- Another Windows build fix.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::WebCoreSynchronousLoader::load):
-
-2009-04-14 Alexey Proskuryakov <ap@webkit.org>
-
- Windows build fix.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::WebCoreSynchronousLoader::willSendRequest):
- (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
-
-2009-04-13 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6698851> Implement XMLHttpRequest withCredentials attribute
-
- * WebCore.xcodeproj/project.pbxproj: Made ThreadableLoader.h private, as enum definitions
- from it are now used in otehr private headers.
-
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequest.idl:
- Added withCredentials attribute. When it is false (default), neither credentials nor cookies
- are sent with cross origin requests, When it is true, those are sent, but the server needs
- to allow handling results via Access-Control-Allow-Credentials header. It was always possible
- to send a cross-site request with credentials via IFRAME or IMG, so this just adds a way to
- read results, as long as the server reports that it's allowed.
- Having the default set to false ensures that requests won't fail unexpectedly because of
- stored credentials and cookies for other resources in the target protection space.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::loadRequestSynchronously): Allow stored credentials for same origin
- requests, and for cross origin ones that have withCredentials attribute set. Such code already
- existed for cookies (but it's simpler, because we could just set a ResourceRequest flag).
- (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
-
- * platform/network/ResourceHandle.h: Added willSendRequest() - just like for other callbacks,
- is is easier to have code in the class. Also, loadResourceSynchronously() now takes a
- StoredCredentials option, matching async case.
-
- * platform/network/ResourceHandleClient.h:
- (WebCore::ResourceHandleClient::receivedCredential): Removed. This method could never be
- called, and no client used it.
- (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): Ditto.
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal): Split username and password out
- of request URL. We want to always get a callback for credentials to manage them in WebCore,
- so network back-end shouldn't see them too early.
-
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::removeCredentials):
- * platform/network/ResourceRequestBase.h:
- Added a removeCredentials() method that removes login and password parts from request URL.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCoreCredentialStorage): Added a simple storage class for per-session credentials.
- (WebCore::ResourceHandle::loadResourceSynchronously): Pass allowStoredCredentials through.
- (WebCore::ResourceHandle::willSendRequest): On a redirect, credentials should be replaced.
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try credentials from the URL
- and per-session credentials. Code was partially moved from Obj-C callback.
- (WebCore::ResourceHandle::receivedCredential): Intercept per-session credentials and store
- them in WebCore storage.
- (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Don't
- store the redirected URL - we only needed credentials, which are now stored separately.
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Removed
- code that was setting credentials from URL. First, the code is now in ResourceHandle, and
- also, it wasn't actually needed in Leopard release before this patch, see <rdar://problem/5298142>.
- (-[WebCoreSynchronousLoader dealloc]): Release credentials. Note that unlike ResourceHandle,
- this class still needs to track URL for checking whether a redirect is allowed. This is
- not a great solution, and we should unify client code to use the same checks in sync and
- async cases.
- (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Just like in
- async case, put credentials aside to ensure that network back-end asks for them.
- (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use credentials
- from URL, or from WebCore storage.
- (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Don't use stored
- credentials when not allowed to.
- (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
- Put credentials aside to ensure that network back-end asks for them.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::WebCoreCredentialStorage::set):
- (WebCore::WebCoreCredentialStorage::get):
- (WebCore::willSendRequest):
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::willSendRequest):
- (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- (WebCore::ResourceHandle::receivedCredential):
- (WebCore::ResourceHandle::loadResourceSynchronously):
- (WebCore::WebCoreSynchronousLoader::willSendRequest):
- (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
- (WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage):
- (WebCore::WebCoreSynchronousLoader::load):
- Same changes as in Mac case.
-
- * platform/network/curl/ResourceHandleCurl.cpp:
- (WebCore::ResourceHandle::loadResourceSynchronously):
- * platform/network/qt/ResourceHandleQt.cpp:
- (WebCore::ResourceHandle::loadResourceSynchronously):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::loadResourceSynchronously):
- Trying not to break the build.
-
- * dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
- * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- Unconditionally allow stored credentials for these, as they only support same origin loads.
-
- * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- WorkerContext.importScripts() can be cross-origin, but sending credentials with it is no worse
- than sending them with <script src=...>, so this is also unconditionally allowed.
-
- * loader/DocumentThreadableLoader.cpp:
- (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Pass through storedCredentials.
- (WebCore::DocumentThreadableLoader::create): Ditto.
- (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Save storedCredentials and
- sameOrigin flags foruse in callbacks.
- (WebCore::DocumentThreadableLoader::willSendRequest): Assert that loaders aren't all confused.
- (WebCore::DocumentThreadableLoader::didSendData): Ditto.
- (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
- (WebCore::DocumentThreadableLoader::didReceiveData): Ditto.
- (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
- (WebCore::DocumentThreadableLoader::didFail): Ditto.
- (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Don't use credential
- storage if that's not allowed by the code that invoked DocumentThreadableLoader.
- (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Simulate a failure
- and cancel the request if we are about to ask the user for credentials for a cross-origin
- request, which is forbidden by CORS (and would have been very confusing if allowed).
- (WebCore::DocumentThreadableLoader::receivedCancellation): Assert that loaders aren't all confused.
-
- * loader/DocumentThreadableLoader.h: Updated for the new flags (storedCredentials and
- sameOrigin) that affect the loader. Eventually, we need to move all CORS logic from XHR here.
-
- * loader/ThreadableLoader.h: (StoredCredentials): Added another flag that affects loader
- behavior. We should combine all of these into a structure, and use it for sync requests, too.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
- * loader/FrameLoader.h:
- * loader/ThreadableLoader.cpp:
- (WebCore::ThreadableLoader::create):
- (WebCore::ThreadableLoader::loadResourceSynchronously):
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
- (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- * loader/WorkerThreadableLoader.h:
- (WebCore::WorkerThreadableLoader::create):
- Pass through storedCredentials.
-
-2009-04-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Remove an outdated comment in ScrollView.h
-
- * platform/ScrollView.h:
-
-2009-04-13 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25177
-
- QTTrack's -media method always return NULL in 64-bit QTKit, so
- MediaPlayerPrivate::disableUnsupportedTracks should use
- QTTrackMediaTypeAttribute to get a track's type.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- Stop using protected event listeners on the window object.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're
- no longer protected.
-
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener): Create unprotected event
- listeners, since we mark them now.
-
- * bindings/js/JSEventListener.h: Made some functions public so
- DOMWindow could call them.
-
- * bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header,
- so it could be shared.
-
- * bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking
- and invalidating code for the DOMWindow.
-
- * dom/RegisteredEventListener.h:
- (WebCore::markEventListeners):
- (WebCore::invalidateEventListeners): Added helper functions.
-
- * page/DOMWindow.idl: Make the window's event listener attributes not
- protected.
-
-2009-04-13 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=25155
-
- OS X standalone media documents should not switch from <video> to <embed> when
- QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
- with a slow network connection or when a movie is not saved fast-start.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's
- loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
-
-2009-04-13 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24453
- REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
- the main document that timer callback makes are not flushed.
-
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded()
- since timers may affect documents other then their own.
-
-2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by David Hyatt.
-
- Check document for nullity to avoid crashing on GTK+, when
- creating the WebView.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::needsLayout):
-
-2009-04-13 Ada Chan <adachan@apple.com>
-
- Forgot to capitalize the "US".
-
- * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
- (WebCore::currentTextBreakLocaleID):
-
-2009-04-13 Ada Chan <adachan@apple.com>
-
- <rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
- Revert back to the old word breaking behavior by using en_US_POSIX locale.
-
- Reviewed by Steve Falkenburg.
-
- * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
- (WebCore::currentTextBreakLocaleID):
-
-2009-04-13 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- * platform/cf/BinaryPropertyList.cpp: Added comment.
- * platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
-
-2009-04-13 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
- https://bugs.webkit.org/show_bug.cgi?id=25158
- rdar://problem/6769693
-
- Test: editing/selection/click-after-nested-block.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint
- can share code.
- (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first
- child box. Changed special case for last child box to propertly handle the various
- types of child box that are not hit test candidates (the same ones already handled
- by the hit test loop below), adding in a loop so we find the last candidate.
-
-2009-04-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
- it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
-
- * WebCore.base.exp:
- * page/FrameView.h:
- (WebCore::FrameView::visibleContentsResized):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::updateScrollbars):
- * platform/ScrollView.h:
-
-2009-04-13 Adam Roben <aroben@apple.com>
-
- Add SharedBuffer::wrapCFData
-
- This is the CF-equivalent of wrapNSData.
-
- Reviewed by Brady Eidson.
-
- * platform/SharedBuffer.h:
- * platform/cf/SharedBufferCF.cpp:
- (WebCore::SharedBuffer::wrapCFData):
-
-2009-04-13 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * page/EventHandler.cpp:
- (WebCore::documentPointForWindowPoint):
-
-2009-04-13 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6740294> Increase the connection count per host
-
- Try to use six connections per host if possible.
-
- * WebCore.base.exp:
- * loader/loader.cpp:
- (WebCore::Loader::Loader):
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm:
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::initMaximumHTTPConnectionCountPerHost):
- * platform/network/ResourceRequestBase.h:
- * platform/network/mac/ResourceRequestMac.mm:
- (WebCore::initMaximumHTTPConnectionCountPerHost):
-
-2009-04-13 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=25153
- Can't place the caret into text field that scrolls the window on focus
-
- We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
- be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
- coordinate) and use that any time we refetch.
-
- * page/EventHandler.cpp:
- (WebCore::documentPointForWindowPoint):
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::prepareMouseEvent):
-
-2009-04-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
- to conform to our style guidelines.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::allowPopUp):
- * page/Settings.h:
- (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Mac build fix: Made another header private.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-04-13 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25121
- Upstream changes to handle error messages from V8 when running worker script.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::reportFatalErrorInV8):
- (WebCore::handleConsoleMessage):
- (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
- (WebCore::WorkerContextExecutionProxy::dispose):
- (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- (WebCore::WorkerContextExecutionProxy::evaluate):
- * bindings/v8/WorkerContextExecutionProxy.h:
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Build fix: Made setInlineEventListenerForType not inline, since Document
- calls it now. Made RegisteredEventListener.h a private header on Mac,
- so WebKit can use it.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::setInlineEventListenerForType):
-
-2009-04-13 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6404439> REGRESSION: Overlapping text and other
- layout issues in View Sample feature of MYOB FIrstEdge v3
-
- * page/Navigator.cpp:
- (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of
- JavaScript files this quirk applies to.
-
-2009-04-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Move open and showModalDialog functions out of JSDOMWindowBase
- and into JSDOMWindow by partially generating them.
-
- This slightly changes the behavior of getting window.showModalDialog
- when the embedding app does not support it to return undefined regardless
- of shadowing. This should not be an issue in a practice, but will be addressed
- when we add a generic way to handle runtime specialization of property
- access.
-
- * DerivedSources.make: Remove JSDOMWindowBase.lut.h
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::):
- (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from
- here to JSDOMWindow::customGetOwnPropertySlot.
- (WebCore::JSDOMWindowBase::put): Remove dead code.
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::createWindow):
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase.
- (WebCore::DOMWindow::allowPopUp): Ditto.
- (WebCore::DOMWindow::canShowModalDialog): Ditto.
- (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2009-04-13 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Moved storage for window event listeners into the window object.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener): Add / remove window event
- listeners to / from the window object.
-
- * dom/Document.cpp:
- (WebCore::Document::removeAllEventListeners):
- (WebCore::Document::clear):
- (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved
- a bunch of code to the DOMWindow class, and left behind a few calls through
- to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
-
- * dom/Document.h: ditto.
-
- * dom/Node.cpp:
- (WebCore::Node::dispatchGenericEvent):
- (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window
- object, not the document.
-
- * dom/Node.h:
- * dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector
- declaration, since it's required in more places now.
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrame::clear): Updated for rename. Also, remove event
- listeners before detaching and clearing the document's window pointer,
- since the the document needs its window pointer in order to tell the window
- to clear its event listeners.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::canCachePageContainingThisFrame):
- (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and
- movement of window event listeners into the window.
-
- * loader/ImageDocument.cpp:
- (WebCore::ImageDocument::createDocumentStructure): Updated for movement
- of window event listeners into the window.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::handleEvent):
- (WebCore::DOMWindow::addEventListener):
- (WebCore::DOMWindow::removeEventListener):
- (WebCore::DOMWindow::removeAllEventListeners):
- (WebCore::DOMWindow::hasEventListener):
- (WebCore::DOMWindow::setInlineEventListenerForType):
- (WebCore::DOMWindow::removeInlineEventListenerForType):
- (WebCore::DOMWindow::inlineEventListenerForType):
- (WebCore::DOMWindow::addPendingFrameUnloadEventCount):
- (WebCore::DOMWindow::removePendingFrameUnloadEventCount):
- (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount):
- (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
- * page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
-
- * page/Frame.cpp:
- (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
-
-2009-04-13 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=25149
-
- The Geolocation timer needs to start after the UA has granted permission.
-
- * bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions>
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used
- later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions>
- where needed.
- (WebCore::Geolocation::GeoNotifier::GeoNotifier):
- (WebCore::Geolocation::GeoNotifier::startTimer):
- (WebCore::Geolocation::getCurrentPosition):
- (WebCore::Geolocation::watchPosition):
- (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows
- (WebCore::Geolocation::startTimer):
- (WebCore::Geolocation::startTimersForOneShots):
- (WebCore::Geolocation::startTimersForWatchers):
- (WebCore::Geolocation::startTimers):
- * page/Geolocation.h:
- (WebCore::Geolocation::GeoNotifier::create):
-
-2009-04-13 Pamela Greene <pam@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Fix Chromium (V8) build by renaming methods to match changes
- in http://trac.webkit.org/changeset/42377.
-
- https://bugs.webkit.org/show_bug.cgi?id=25141
-
- * bindings/v8/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
-
-2009-04-13 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=25136
- CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
-
- Test: fast/frames/frame-unload-crash.html
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
-
-2009-04-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Tim Hatcher.
-
- Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.
-
- * page/DOMWindow.idl:
-
-2009-04-13 Greg Bolsinga <bolsinga@apple.com>
-
- Fix GTK build break.
-
- * platform/gtk/GeolocationServiceGtk.cpp:
- (WebCore::GeolocationServiceGtk::updatePosition):
-
-2009-04-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Darin Adler and Dan Bernstein.
-
- Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
- the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
- Schedule a style recalc if needed when an object comes out of the page cache.
-
- * dom/Document.cpp:
- (WebCore::Document::scheduleStyleRecalc):
- (WebCore::Document::setInPageCache):
-
-2009-04-13 Timothy Hatcher <timothy@apple.com>
-
- Correctly sort (program) scripts in the Scripts panel popup menu.
-
- Reviewed by Ada Chan.
-
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code
- and sort "(program)" options by the sourceID to maintain some order.
- * inspector/front-end/utilities.js:
- (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause
- an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction.
- Just set 'first' and break so the correct result will be returned.
-
-2009-04-13 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24770
-
- Add custom code for Coordinates that returns null when required by the
- Geolocation spec.
-
- http://dev.w3.org/geo/api/spec-source.html#coordinates
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSCoordinatesCustom.cpp: Added.
- (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided.
- (WebCore::JSCoordinates::altitudeAccuracy): Ditto
- (WebCore::JSCoordinates::heading): Ditto
- (WebCore::JSCoordinates::speed): Ditto
- * page/Coordinates.h:
- (WebCore::Coordinates::create): Add 'canProvide' parameters and values
- (WebCore::Coordinates::canProvideAltitude):
- (WebCore::Coordinates::canProvideAltitudeAccuracy):
- (WebCore::Coordinates::canProvideHeading):
- (WebCore::Coordinates::canProvideSpeed):
- (WebCore::Coordinates::Coordinates):
- * page/Coordinates.idl: specify custom getters
- * platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided.
- (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
-
-2009-04-13 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
-
- Test: editing/inserting/5510537.html
-
- * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position
- is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break
- insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level
- so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
-
-2009-04-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix problem when encoding history files with duplicate integer arrays near the end of the file.
- This results in an assertion failure, and if assertions are turned off, corrupted output.
-
- When writing an integer array it's important not to add an object reference to the
- aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
- more importantly, it's possible this instance integer array is a duplicate and won't be
- written out. If so, there's no guarantee there's enough space in the aggregate buffer to
- store the object references (the references will be ignored). In some cases the aggregate
- buffer can then overrun the data being written; normally this is prevented by the fact that
- the data being written will include a copy of the aggregate buffer.
-
- Also removed a bit of unneeded dead code to handle the integer -1.
-
- * platform/cf/BinaryPropertyList.cpp:
- (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded
- m_integerNegativeOneObjectReference, since property lists support only non-negative integers.
- (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for
- m_integerNegativeOneObjectReference.
- (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto.
- (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference):
- Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling
- addAggregateObjectReference.
- (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new
- writeIntegerWithoutAddingAggregateObjectReference function.
- (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new
- writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the
- code to save and restore m_currentAggregateBufferByte, which is no longer needed.
-
-2009-04-13 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed Qt build fix.
-
- * platform/graphics/qt/FontQt.cpp:
- (WebCore::Font::floatWidthForComplexText):
-
-2009-04-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Move the event and crypto attributes and the captureEvents and releaseEvents
- functions out of JSDOMWindowBase by partially generating them.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::currentEvent): Make const.
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::crypto): Not implemented.
- (WebCore::JSDOMWindow::event):
- (WebCore::JSDOMWindow::captureEvents): Not implemented.
- (WebCore::JSDOMWindow::releaseEvents): Ditto.
- * page/DOMWindow.idl:
-
-2009-04-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Move more attributes out of JSDOMWindowBase by
- partially generating them.
-
- - Expose the MessagePort constructor.
-
- * bindings/js/JSDOMGlobalObject.h:
- (WebCore::getDOMConstructor):
- * bindings/js/JSDOMWindowBase.cpp:
- (setJSDOMWindowBaseEvent):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::image):
- (WebCore::JSDOMWindow::option):
- (WebCore::JSDOMWindow::audio):
- (WebCore::JSDOMWindow::webKitPoint):
- (WebCore::JSDOMWindow::webKitCSSMatrix):
- (WebCore::JSDOMWindow::xMLHttpRequest):
- (WebCore::JSDOMWindow::xSLTProcessor):
- (WebCore::JSDOMWindow::messageChannel):
- (WebCore::JSDOMWindow::worker):
- * page/DOMWindow.idl:
-
-2009-04-12 Timothy Hatcher <timothy@apple.com>
-
- A resource's filename is not correct after a redirect in the Inspector.
-
- Reviewed by Dan Bernstein.
-
- * inspector/InspectorResource.cpp:
- (WebCore::InspectorResource::updateScriptObject): Fix a typo in the
- lastPathComponent property name.
-
-2009-04-12 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Test: editing/inserting/6609479-1.html
-
- Follow-up to <rdar://problem/6609479>.
-
- Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
- was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
- at the start of a paragraph.
-
- * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):
-
-2009-04-11 Adele Peterson <adele@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
-
- Test: editing/inserting/6609479.html
-
- Don't break a blockquote if pasting or inserting into a table.
-
- * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
-
-2009-04-11 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6643103> Unscaled values from body.scrollHeight
-
- Test: fast/css/zoom-body-scroll.html
-
- Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
- setters.
-
- * html/HTMLBodyElement.cpp:
- (WebCore::adjustForZoom):
- (WebCore::HTMLBodyElement::scrollLeft):
- (WebCore::HTMLBodyElement::setScrollLeft):
- (WebCore::HTMLBodyElement::scrollTop):
- (WebCore::HTMLBodyElement::setScrollTop):
- (WebCore::HTMLBodyElement::scrollHeight):
- (WebCore::HTMLBodyElement::scrollWidth):
-
-2009-04-10 Timothy Hatcher <timothy@apple.com>
-
- Allow page navigation and reload while stopped at a breakpoint.
-
- <rdar://problem/6781108> Having a breakpoint active prevents page reload
-
- Reviewed by Darin Adler.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::didContinue): Call the resumedScript function.
- * inspector/InspectorController.h: Added didContinue.
- * inspector/JavaScriptDebugListener.h: Ditto.
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
- * inspector/front-end/inspector.js:
- (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
-
-2009-04-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Adele Peterson.
-
- Remove unused include for JSLock.
-
- * page/mac/FrameMac.mm:
-
-2009-04-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Add back the keepAlive timer for after the script execution to
- protect the callers of evaluate, as was part of the original intent
- of timer.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * page/mac/FrameMac.mm:
-
-2009-04-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=25137
-
- If we reload, the animation controller sticks around and has
- a stale animation time. So the needed delay is computed wrong.
- I added a reset of the animation timer on load.
-
- I did not do a test case because this only happens on reload so I
- couldn't make an automated test. I tried using an iframe and using
- reload() but that doesn't tickle the bug.
-
- * dom/Document.cpp:
- (WebCore::Document::implicitOpen):
-
-2009-04-10 Grace Kloba <klobag@gmail.com>
-
- Reviewed by Darin Adler.
-
- Move WORKERS header files inside ENABLE(WORKERS).
- So if WORKERS is not enabled and the generated files are not generated, the build is still working.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- * bindings/js/JSMessageChannelConstructor.cpp:
- * bindings/js/ScheduledAction.cpp:
-
-2009-04-10 Darin Adler <darin@apple.com>
-
- Reviewed by Brady Eidson.
-
- <rdar://problem/6773515> crash in push_heap inside WebCore when printing
-
- The crash was due to manipulating a timer on a different thread than the one it was created on.
- This adds some diagnostics so we'll catch that kind of mistake immediately.
-
- * platform/Timer.cpp:
- (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions.
- (WebCore::TimerBase::start): Assert it's the same thread the timer was created on.
- (WebCore::TimerBase::stop): Ditto.
- (WebCore::TimerBase::isActive): Ditto.
- (WebCore::TimerBase::setNextFireTime): Ditto.
-
- * platform/Timer.h: Added the thread identifier data member.
-
-2009-04-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=25108
-
- If you remove a class with a transition while that transition is running
- the animation timer will continue to fire after the transition is finished.
- This has no visual indication, but it does drain the processor. And in some
- cases it might even cause a glitch in future animations. Unfortunately there
- is no way to test this without putting in printfs.
-
- This happens because the animation logic is never traversed after a transition
- is removed, so we never get a chance to cleanup. So I added cleanup in the logic
- that fires the dispatch of the last style change when the animation finishes.
-
- Test: transitions/remove-transition-style.html
-
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::animate):
- (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- * page/animation/CompositeAnimation.h:
-
-2009-04-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for <rdar://problem/6648858>
- CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241
-
- The Frame (and therefore ScriptController) were being destroyed
- during JavaScript execution causing the JSDOMWindowShell to become
- null.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame
- instead of the keep-alive timer, since a nested event loop used from with-in
- JavaScript execution could cause the timer to fire before returning.
-
-2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>
+2009-06-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
- https://bugs.webkit.org/show_bug.cgi?id=25133
- Fix an error in InspectorController's bindings, clean up a few header
- includes, make empty object construction in ScriptObject less ambiguous.
-
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::setSetting): Send correct argument from
- the bindings.
- * bindings/js/ScriptObject.cpp:
- (WebCore::ScriptObject::createNew): Added.
- * bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
- * inspector/ConsoleMessage.cpp: Remove unused header.
- * inspector/ConsoleMessage.h: Ditto.
- * inspector/InspectorResource.cpp:
- (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
-
-2009-04-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=25134
-
- This both fixes a bug where I was not sending in the right time
- to continue the animation and was not recomputing current time
- when coming out of suspend.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::suspendAnimations):
- (WebCore::AnimationControllerPrivate::resumeAnimations):
-
-2009-04-10 Adam Roben <aroben@apple.com>
-
- Give Windows's <select> popup menus drop shadows
-
- Rubber-stamped by Steve Falkenburg.
-
- No test possible.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
-
-2009-04-10 Timothy Hatcher <timothy@apple.com>
-
- Fix a bug in the Web Inspector where it would show scripts
- from previous pages when toggling the debugger off and back on.
-
- https://bugs.webkit.org/show_bug.cgi?id=25095
- rdar://problem/6769970
-
- Reviewed by John Sullivan.
-
- * bindings/js/ScriptCachedFrameData.cpp:
- (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the
- debugger for the scriptController. This balances the attachDebugger
- that was already in ScriptCachedFrameData::restore.
- (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::clearWindowShell): Clear the debugger from
- the current window before setting the new window.
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate
- source providers for code associated this as the debugger.
-
-2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6646998> Avoid starting QTKitServer if possible
- When possible avoid asking QTKit for the MIME types that require QTKitServer
- when running 64-bit.
-
- * WebCore.base.exp: Added new entry point.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::addFileTypesToCache): Add an NSArray of types to the cache.
- (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache.
- (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does
- not start QTKitServer if it is not already running).
- (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored.
- (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid
- starting QTKitServer if possible.
-
- * platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
- * platform/mac/WebCoreSystemInterface.mm: Ditto.
-
-2009-04-10 Adam Roben <aroben@apple.com>
-
- Turn on window animations for <select> popup menus
-
- We turned these off back when <select> popup menus were partially
- transparent. Now that they're opaque, there's no reason not to
- animate them.
-
- Reviewed by Steve Falkenburg.
-
- No test possible.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the
- window animation.
-
-2009-04-10 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix a regression from r42379 which made zero-width characters affect
- line height
-
- Test: fixes fast/text/wide-zero-width-space.html
-
- * platform/graphics/mac/FontMacATSUI.mm:
- (WebCore::overrideLayoutOperation): Add to the fallback font list set
- here, and only if the glyph is not zero-width...
- (WebCore::ATSULayoutParameters::initialize): ...instead of doing it
- here. This matches WidthIterator's behavior.
-
-2009-04-10 Darin Fisher <darin@chromium.org>
-
- Fixing build bustage caused by warnings being treated as errors.
- 1- A local variable was only be used inside a debug assertion, which
- caused grief for the release build.
- 2- Missing initializer for member 'DocumentMarker::activeMatch'
-
- * dom/Document.cpp:
- (WebCore::Document::addMarker):
- (WebCore::Document::setMarkersActive):
-
-2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>
-
- Reviewed by John Sullivan.
-
- Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
- (TextMatches don't have a concept of active match)
-
- For the ports that use the DocumentMarker as highlighting for FindInPage it is
- useful to have a flag that specifies which marker is active, so it can be drawn
- in a different color.
-
- This allows me to remove the hack to use the SelectionController to highlight
- the active match (in the ChromiumWin port).
-
- * dom/Document.cpp:
- (WebCore::Document::setMarkersActive):
- * dom/Document.h:
- * dom/DocumentMarker.h:
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintTextMatchMarker):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::platformActiveTextSearchHighlightColor):
- (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
- * rendering/RenderTheme.h:
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
- (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
- (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor):
- (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
- * rendering/RenderThemeChromiumWin.h:
-
-2009-04-10 Pamela Greene <pam@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Build fix for Chromium.
- https://bugs.webkit.org/show_bug.cgi?id=12440
-
- * page/chromium/FrameChromium.cpp:
- (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
-
-2009-04-09 David Hyatt <hyatt@apple.com>
-
- Reviewed by Oliver Hunt
-
- Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
- to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
- following DOM events and JavaScript timeouts. Eventually these calls will be removed.
-
- Where the timer will really kick in and be useful is for clients that do style changes from
- Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertBefore):
- (WebCore::ContainerNode::replaceChild):
- (WebCore::ContainerNode::removeChild):
- (WebCore::ContainerNode::appendChild):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::~Document):
- (WebCore::Document::scheduleStyleRecalc):
- (WebCore::Document::unscheduleStyleRecalc):
- (WebCore::Document::styleRecalcTimerFired):
- (WebCore::Document::updateStyleForAllDocuments):
- (WebCore::Document::detach):
- * dom/Document.h:
- * dom/Node.cpp:
- (WebCore::Node::setNeedsStyleRecalc):
- (WebCore::Node::lazyAttach):
-
-2009-04-09 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- <rdar://problem/6586787> JS debugger does not work in 64-bit
-
- Don't truncate the source id in JSCallFrame
-
- * inspector/JavaScriptCallFrame.h:
-
-2009-04-09 Adam Roben <aroben@apple.com>
-
- Start compiling HistoryPropertyList on Windows
-
- Reviewed by Darin Adler.
-
- * WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its
- dependencies to the project. Copy headers from history/cf to
- $WebKitOutputDir.
- * history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that
- this file will compile on Windows.
-
-2009-04-09 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6166612> Text boxes' metrics should be based on
- the actual fonts used in them, not just the primary font
-
- Covered by many existing layout tests
-
- * platform/graphics/Font.cpp:
- (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
- platform supports collecting fallback fonts in its complex font path
- and fallbackFonts is not null, all fallback fonts used for the text run
- will be added to it.
-
- * platform/graphics/Font.h:
- (WebCore::Font::width): Ditto.
-
- * platform/graphics/FontFastPath.cpp:
- (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
- qualifier.
- (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
- parameter, which is passed down to WidthIterator.
-
- * platform/graphics/WidthIterator.cpp:
- (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
- and used it to initialize the m_fallbackFonts member.
- (WebCore::WidthIterator::advance): Track the fonts being used and add
- any fallback fonts to the m_fallbackFonts set. Make sure to only add
- non-small-caps fonts.
-
- * platform/graphics/WidthIterator.h:
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
- implementation that returns false, meaning this platform's
- implementation of floatWidthForComplexText() does not populate the
- fallbackFonts set.
- (WebCore::Font::floatWidthForComplexText): Updated for the new
- prototype.
-
- * platform/graphics/chromium/FontLinux.cpp: Ditto.
-
- * platform/graphics/gtk/FontGtk.cpp: Ditto.
-
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
- parameter and used it to initialize the m_fallbackFonts member.
- (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
- fallback fonts to m_fallbackFonts.
-
- * platform/graphics/mac/CoreTextController.h:
-
- * platform/graphics/mac/FontMac.mm:
- (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
- implementation that returns true, indicating that the Mac
- implementations of floatWidthForComplexText() populate the fallbackFonts
- set.
- * platform/graphics/mac/FontMacATSUI.mm:
- (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
- fallbackFonts parameter and used it to initialize the m_fallbackFonts
- member.
- (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
- m_fallbackFonts.
- (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
- parameter, which is passed down to ATSULayoutParameters.
-
- * platform/graphics/mac/FontMacCoreText.cpp:
- (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
- parameter, which is passed down to CoreTextController.
-
- * platform/graphics/win/FontWin.cpp:
- (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
- implementation that returns true, indicating that the
- UniscribeController-based implementations of floatWidthForComplexText()
- populate the fallbackFonts set.
- (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
- parameter, which is passed down to UniscribeController.
-
- * platform/graphics/win/UniscribeController.cpp:
- (WebCore::UniscribeController::UniscribeController): Added a
- fallbackfonts parameter and used it to initialize m_fallbackFonts.
- (WebCore::UniscribeController::advance): Add fallback fonts to
- m_fallbackFonts.
-
- * platform/graphics/win/UniscribeController.h:
-
- * platform/graphics/wx/FontWx.cpp:
- (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
- implementation that returns false, meaning this platform's
- implementation of floatWidthForComplexText() does not populate the
- fallbackFonts set.
- (WebCore::Font::floatWidthForComplexText): Updated for the new
- prototype.
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
- with multiple fonts, compute a common baseline and line height by
- considering all fonts' ascents and descents (and line spacing, if
- applicable).
-
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
- the set of fallback fonts in a vector.
- (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
- fonts previously stored and removes them from storage.
-
- * rendering/InlineTextBox.h:
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText): Initialized the
- m_knownNotToUseFallbackFonts to false.
- (WebCore::RenderText::styleDidChange): Reset
- m_knownNotToUseFallbackFonts to false if the style difference is such that
- affects layout.
- (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
- which is passed down to Font::width().
- (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
- widthFromCache().
- (WebCore::RenderText::calcPrefWidths): Made this call a private version
- of calcPrefWidths() that takes a fallbackFonts parameter and set the
- m_knownNotToUseFallbackFonts to true if the set comes back empty.
- The private version passes the fallbackFonts set to widthFromCache().
- (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
- false.
- (WebCore::RenderText::createFallbackFontMetricsBox): Added.
- (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
- passed down to calcPrefWidths(), widthFromCache() and Font::width().
- Set m_knownNotToUseFallbackFonts to true when appropriate.
-
- * rendering/RenderText.h:
-
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::constructLine): Added an assertion and a continue
- statement to remove one level of indentation.
- (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
- store the set of fallback fonts in the InlineTextBox.
- (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
- assertion.
-
-2009-04-09 David Hyatt <hyatt@apple.com>
-
- Reviewed by Adam Roben
-
- Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
- explicitly instead.
-
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::updateStyleIfNeededForBindings):
- (WebCore::ScriptController::initJavaJSBindings):
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removeProperty):
- (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
- (WebCore::CSSMutableStyleDeclaration::setProperty):
- (WebCore::CSSMutableStyleDeclaration::setStringProperty):
- (WebCore::CSSMutableStyleDeclaration::setImageProperty):
- (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
- (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
- (WebCore::CSSMutableStyleDeclaration::setCssText):
- (WebCore::CSSMutableStyleDeclaration::merge):
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- * css/CSSMutableStyleDeclaration.h:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
- (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
- * css/CSSVariablesDeclaration.cpp:
- (WebCore::CSSVariablesDeclaration::removeVariable):
- (WebCore::CSSVariablesDeclaration::setVariable):
- (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
- * css/CSSVariablesDeclaration.h:
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertBefore):
- (WebCore::ContainerNode::replaceChild):
- (WebCore::ContainerNode::removeChild):
- (WebCore::ContainerNode::appendChild):
- (WebCore::ContainerNode::detach):
- (WebCore::ContainerNode::setFocus):
- (WebCore::ContainerNode::setActive):
- (WebCore::ContainerNode::setHovered):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::~Document):
- (WebCore::Document::scheduleStyleRecalc):
- (WebCore::Document::unscheduleStyleRecalc):
- (WebCore::Document::recalcStyle):
- (WebCore::Document::updateStyleIfNeeded):
- (WebCore::Document::updateStyleForAllDocuments):
- (WebCore::Document::updateLayout):
- (WebCore::Document::implicitClose):
- (WebCore::Document::prepareMouseEvent):
- (WebCore::Document::setFocusedNode):
- (WebCore::Document::setCSSTarget):
- * dom/Document.h:
- * dom/Element.cpp:
- (WebCore::Element::recalcStyle):
- (WebCore::checkForSiblingStyleChanges):
- * dom/InputElement.cpp:
- (WebCore::InputElement::parseMaxLengthAttribute):
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
- * dom/Node.cpp:
- (WebCore::Node::Node):
- (WebCore::Node::setNeedsStyleRecalc):
- (WebCore::Node::lazyAttach):
- (WebCore::Node::dispatchGenericEvent):
- * dom/Node.h:
- (WebCore::Node::needsStyleRecalc):
- (WebCore::Node::childNeedsStyleRecalc):
- (WebCore::Node::setChildNeedsStyleRecalc):
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::setSelectedState):
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::evaluateScript):
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::attributeChanged):
- (WebCore::StyledElement::classAttributeChanged):
- (WebCore::StyledElement::parseMappedAttribute):
- * dom/Text.cpp:
- (WebCore::Text::recalcStyle):
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::enable):
- * editing/Editor.cpp:
- (WebCore::Editor::setBaseWritingDirection):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::nodeWillBeRemoved):
- (WebCore::SelectionController::layout):
- (WebCore::SelectionController::focusedOrActiveStateChanged):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::parseMappedAttribute):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::setInnerText):
- (WebCore::HTMLElement::isContentEditable):
- (WebCore::HTMLElement::isContentRichlyEditable):
- (WebCore::HTMLElement::contentEditable):
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::updateWidget):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- (WebCore::HTMLFrameSetElement::recalcStyle):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::setChecked):
- (WebCore::HTMLInputElement::setIndeterminate):
- (WebCore::HTMLInputElement::setValue):
- (WebCore::HTMLInputElement::setAutofilled):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::finishParsingChildren):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::updateWidget):
- (WebCore::HTMLObjectElement::finishParsingChildren):
- (WebCore::HTMLObjectElement::childrenChanged):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::recalcStyle):
- (WebCore::HTMLSelectElement::restoreState):
- (WebCore::HTMLSelectElement::setRecalcListItems):
- (WebCore::HTMLSelectElement::reset):
- (WebCore::HTMLSelectElement::typeAheadFind):
- * html/HTMLTableElement.cpp:
- (WebCore::setTableCellsChanged):
- (WebCore::HTMLTableElement::parseMappedAttribute):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::setValue):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::executeScript):
- (WebCore::FrameLoader::gotoAnchor):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::alert):
- (WebCore::DOMWindow::confirm):
- (WebCore::DOMWindow::prompt):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hoverTimerFired):
- * page/FrameView.cpp:
- (WebCore::FrameView::layout):
- (WebCore::FrameView::needsLayout):
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::setNeedsStyleRecalc):
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
- (WebCore::AnimationControllerPrivate::clear):
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher):
- (WebCore::AnimationControllerPrivate::addEventToDispatch):
- (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
- (WebCore::AnimationControllerPrivate::animationTimerFired):
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
- (WebCore::AnimationController::cancelAnimations):
- * page/animation/AnimationControllerPrivate.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::endAnimation):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::updateDragState):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::selectionBounds):
- * svg/SVGAElement.cpp:
- (WebCore::SVGAElement::svgAttributeChanged):
- * svg/SVGAnimationElement.cpp:
- (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- * svg/SVGCursorElement.cpp:
- (WebCore::SVGCursorElement::svgAttributeChanged):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::setNeedsUpdate):
- * svg/SVGForeignObjectElement.cpp:
- (WebCore::addCSSPropertyAndNotifyAttributeMap):
- * svg/SVGStopElement.cpp:
- (WebCore::SVGStopElement::parseMappedAttribute):
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::parseMappedAttribute):
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::svgAttributeChanged):
- (WebCore::SVGUseElement::childrenChanged):
- (WebCore::SVGUseElement::recalcStyle):
- * svg/animation/SMILTimeContainer.cpp:
- (WebCore::SMILTimeContainer::updateAnimations):
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::parseMappedAttribute):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::setValue):
- (WebCore::WMLInputElement::parseMappedAttribute):
- * wml/WMLNoopElement.cpp:
- (WebCore::WMLNoopElement::insertedIntoDocument):
-
-2009-04-09 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Fisher.
-
- When there is a shadow set but it specifies "no shadow", clear the
- shadow shader. This will prevent Chromium from thinking there's a
- shadow and using the Skia codepath rather than Windows.
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::setPlatformShadow):
-
-2009-04-09 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Crash when accessing svg.viewport on a detached SVGSVGElement
- https://bugs.webkit.org/show_bug.cgi?id=25105
-
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as to what behavior we should have in this case, and I doubt anyone cares for now).
-
-2009-04-09 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25084
- Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::dispose):
- (WebCore::WorkerContextExecutionProxy::retrieve):
- (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
- (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
- (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
- * bindings/v8/WorkerContextExecutionProxy.h:
- * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- (WebCore::getEventListener):
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-04-09 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson and Sam Weinig.
-
- Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
-
- Longer term solution is to change the design so Safari doesn't read and write all of history.
- This patch is step one: Do the serializing, which is done on the main thread, much faster.
-
- * WebCore.base.exp: Added new entry points.
- * WebCore.xcodeproj/project.pbxproj: Added new source files.
-
- * history/cf: Added.
-
- * history/cf/HistoryPropertyList.cpp: Added.
- * history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also
- have code for reading here too.
-
- * platform/cf/BinaryPropertyList.cpp: Added.
- * platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.
-
-2009-04-09 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=25122
-
- If deferred repainting is active, we need to ensure that there are no repaints
- pending at the end of layoutIfNeededRecursive, which is called just before
- painting via -viewWillDraw.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::layoutIfNeededRecursive):
-
-2009-04-09 John Grabowski <jrg@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25117
- Fix Mac Chromium form controls.
-
- * rendering/RenderThemeChromiumMac.mm:
- When rendering native controls in Mac Chromium, use a clean NSGraphicsContext.
- Properly save and restore native graphics context.
- (WebCore::RenderThemeChromiumMac::paintCheckbox):
- (WebCore::RenderThemeChromiumMac::paintRadio):
- (WebCore::RenderThemeChromiumMac::paintMenuList):
- (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
- (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
-
-2009-04-09 Drew Wilson <atwilson@google.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25030
- Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
- instead of a real MessagePort for the entangledPort, since it could
- theoretically live in a separate process.
-
- The goal of this refactoring is to remove all assumptions that the object
- representing the entangled port is actually of type MessagePort. All
- operations that were previously directly modifying private MessagePort member
- variables in the entangled port (i.e. entangle(), postMessage()) have been changed
- to invoke functions in the MessagePortProxy interface instead which will allow
- the Chrome bindings to proxy these calls to another process.
-
- No new layout tests, as this is just a refactoring with no bug fixes
- or new functionality.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::mark):
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::clone):
- (WebCore::MessagePort::postMessage):
- (WebCore::MessagePort::deliverMessage):
- (WebCore::MessagePort::startConversation):
- (WebCore::MessagePort::close):
- (WebCore::MessagePort::entangle):
- (WebCore::MessagePort::unentangle):
- * dom/MessagePort.h:
- (WebCore::MessagePort::entangledPort):
- * dom/MessagePortProxy.h: Added.
- (WebCore::MessagePortProxy::~MessagePortProxy):
-
-2009-04-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey "Big Boy" Garen.
-
- Fix for <rdar://problem/5745677> Possible to stop load during an unload event
- Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
-
- Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
- fast/events/stop-load-in-unload-handler-using-window-stop.html
-
- Don't allow calling methods that would stop the new load inside the unload
- event.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::FrameLoader):
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::stopAllLoaders):
- * loader/FrameLoader.h:
-
-2009-04-09 David Kilzer <ddkilzer@apple.com>
-
- Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
-
- Rolled r42345 back in. The build failure was caused by an
- internal script which had not been updated the same way that
- build-webkit was updated.
+ WebInspector: Fix completion when iterating options using Tab.
- * Configurations/WebCore.xcconfig:
- * DerivedSources.make:
- * bindings/objc/DOM.mm:
- (WebCore::createElementClassMap):
- (+[DOMNode _wrapNode:WebCore::]):
- * bindings/objc/DOMCSS.mm:
- (+[DOMCSSValue _wrapCSSValue:WebCore::]):
- * bindings/objc/DOMEvents.mm:
- (+[DOMEvent _wrapEvent:WebCore::]):
- * bindings/objc/DOMInternal.h:
- * bindings/objc/ExceptionHandlers.mm:
- (WebCore::raiseDOMException):
- * html/HTMLEmbedElement.idl:
- * html/HTMLFrameElement.idl:
- * html/HTMLIFrameElement.idl:
- * html/HTMLObjectElement.idl:
-
-2009-04-09 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=25109
-
- Eliminate CompositeAnimationPrivate, which was a needless level
- of abstraction. Remove the methods like addToStyleAvailableWaitList()
- that simply turn around and call the animation controller.
-
- Rename animationControllerPriv() to animationController().
- Rename willNeedService() to timeToNextService().
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::~AnimationBase):
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::timeToNextService):
- (WebCore::AnimationBase::beginAnimationUpdateTime):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::~CompositeAnimation):
- (WebCore::CompositeAnimation::clearRenderer):
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- (WebCore::CompositeAnimation::animate):
- (WebCore::CompositeAnimation::getAnimatedStyle):
- (WebCore::CompositeAnimation::setAnimating):
- (WebCore::CompositeAnimation::timeToNextService):
- (WebCore::CompositeAnimation::getAnimationForProperty):
- (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- (WebCore::CompositeAnimation::suspendAnimations):
- (WebCore::CompositeAnimation::resumeAnimations):
- (WebCore::CompositeAnimation::overrideImplicitAnimations):
- (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
- (WebCore::CompositeAnimation::isAnimatingProperty):
- (WebCore::CompositeAnimation::pauseAnimationAtTime):
- (WebCore::CompositeAnimation::pauseTransitionAtTime):
- (WebCore::CompositeAnimation::numberOfActiveAnimations):
- * page/animation/CompositeAnimation.h:
- (WebCore::CompositeAnimation::animationController):
- (WebCore::CompositeAnimation::isSuspended):
- (WebCore::CompositeAnimation::hasAnimations):
- (WebCore::CompositeAnimation::CompositeAnimation):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- (WebCore::ImplicitAnimation::timeToNextService):
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- (WebCore::KeyframeAnimation::timeToNextService):
- * page/animation/KeyframeAnimation.h:
-
-2009-04-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
- It broke Mac build, and I don't know how to fix it.
-
- * Configurations/WebCore.xcconfig:
- * DerivedSources.make:
- * bindings/objc/DOM.mm:
- (WebCore::createElementClassMap):
- (+[DOMNode _wrapNode:WebCore::]):
- * bindings/objc/DOMCSS.mm:
- (+[DOMCSSValue _wrapCSSValue:WebCore::]):
- * bindings/objc/DOMEvents.mm:
- (+[DOMEvent _wrapEvent:WebCore::]):
- * bindings/objc/DOMInternal.h:
- * bindings/objc/ExceptionHandlers.mm:
- (WebCore::raiseDOMException):
- * html/HTMLEmbedElement.idl:
- * html/HTMLFrameElement.idl:
- * html/HTMLIFrameElement.idl:
- * html/HTMLObjectElement.idl:
-
-2009-04-09 Xan Lopez <xlopez@igalia.com>
-
- Unreviewed build fix.
-
- RenderView::docWidth() was made private by r42334. That commit
- changes its usage for overflowWidth(), so do that here too.
-
- * page/PrintContext.cpp:
- (WebCore::PrintContext::computePageRects):
+ https://bugs.webkit.org/show_bug.cgi?id=26722
-2009-04-09 Xan Lopez <xlopez@igalia.com>
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt.prototype._completionsReady):
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Implement AtkObject::ref_state_set. Still quite a few states not
- implemented.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-09 Xan Lopez <xlopez@igalia.com>
+2009-06-27 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Holger Freyther.
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Move fallback object creation to its own function, as it will be
- used in several places.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
- (fallbackObject):
-
-2009-04-09 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Based on a patch by Alp Toker.
-
- Move AccessibilityObject methods to their file.
-
- * page/gtk/AccessibilityObjectAtk.cpp:
- (WebCore::AccessibilityObject::wrapper):
- (WebCore::AccessibilityObject::setWrapper):
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-09 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
- [GTK] ATK accessibility enhancements
-
- Rework accessibility type generation code, based on Mozilla a11y
- implementation.
-
- Have one base a11y type, and generate derived types that implement
- only the necessary interfaces at runtime, based on the specific
- object we are wrapping. This allows to save a lot of code while
- covering all possible cases.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-04-09 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix document.implementation.createDocument(null, "a:b") not to crash!
- https://bugs.webkit.org/show_bug.cgi?id=25096
-
- Test: fast/dom/DOMImplementation/createDocument-namespace-err.html
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument): check the exception code before using the result
-
-2009-04-08 Adam Roben <aroben@apple.com>
-
- Make <select>s in application chrome documents match the Vista system
- dialog look
+ https://bugs.webkit.org/show_bug.cgi?id=25889
+ [GTK] scrollbar policy for main frame is not implementable
- Reviewed by Dave Hyatt.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::documentIsInApplicationChromeMode): Added this simple helper
- function.
- (WebCore::RenderThemeWin::getThemeData): In application chrome mode,
- the drop down button never uses any look but the "normal" look.
- (WebCore::RenderThemeWin::paintMenuList): In application chrome mode,
- use the "readonly" style to match system dialogs.
-
-2009-04-08 Adam Roben <aroben@apple.com>
-
- Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow
- showing after clicking "Go Back" in phishing alert
-
- RenderButton's m_timer is not stopped when its Document enters the
- page cache. When the WebView was torn down, the timer would fire after
- the Frame's Page had been destroyed, leading to a crash. This patch
- just makes the timer do nothing when it fires. Making the timer not
- fire when in the page cache is covered by bug 25110.
-
- Reviewed by Dave Hyatt.
-
- No test possible.
-
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::timerFired): Do nothing when we're in the page
- cache.
-
-2009-04-09 David Hyatt <hyatt@apple.com>
-
- Reviewed by Adam Roben
-
- Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
- caused the checks to be triggered too early in the loading process of the frame.
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
-
-2009-04-08 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Cameron Zwarich
-
- https://bugs.webkit.org/show_bug.cgi?id=25106
-
- Fix signature of virtual function on AnimationBase so that it matches
- those in the derived classes, by removing unused parameter.
-
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::endAnimation):
-
-2009-04-08 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
-
- Reviewed by Darin Adler and Maciej Stachowiak.
-
- Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
- that SVG DOM Objective-C bindings may be optionally disabled.
-
- * Configurations/WebCore.xcconfig: Added
- ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in
- FEATURE_DEFINES and EXCLUDED_SOURCE_FILE_NAMES. When SVG DOM
- Objective-C bindings are disabled, two generated header files no
- longer exist and none of the generated DOMSVG*.mm files should
- be compiled.
- * DerivedSources.make: All of the WebCore.SVG*.exp files contain
- SVG DOM Objective-C bindings classes, so exclude them unless
- ENABLE_SVG_DOM_OBJC_BINDINGS is set.
- * bindings/objc/DOM.mm: Switched from using ENABLE(SVG) to using
- ENABLE(SVG_DOM_OBJC_BINDINGS).
- (WebCore::createElementClassMap):
- (+[DOMNode _wrapNode:WebCore::]):
- * bindings/objc/DOMCSS.mm: Ditto.
- (+[DOMCSSValue _wrapCSSValue:WebCore::]):
- * bindings/objc/DOMEvents.mm: Ditto.
- (+[DOMEvent _wrapEvent:WebCore::]):
- * bindings/objc/DOMInternal.h: Ditto.
- * bindings/objc/ExceptionHandlers.mm: Added use of
- ENABLE(SVG_DOM_OBJC_BINDINGS).
- (WebCore::raiseDOMException):
- * html/HTMLEmbedElement.idl: Excluded -getSVGDocument method
- in generated Objective-C DOM classes if SVG DOM Objective-C
- bindings are disabled.
- * html/HTMLFrameElement.idl: Ditto.
- * html/HTMLIFrameElement.idl: Ditto.
- * html/HTMLObjectElement.idl: Ditto.
-
-2009-04-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - limit the workaround for <rdar://problem/5781372> to Mac OS X versions
- that need it
-
- * platform/mac/WebFontCache.mm:
- (fixUpWeight): Changed this function to be a no-op post-Leopard.
-
-2009-04-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6771547> Appending to a RenderText causes all its
- lines to be dirtied
-
- Test: fast/repaint/text-append-dirty-lines.html
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::setTextWithOffset): If no text boxes intersected
- with or came after the new text, dirty the last root box, since the new
- text may begin there. Having at least one dirty line prevents the
- incorrect dirtying of all lines later during layoutInlineChildren().
-
-2009-04-08 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=25100
-
- Fixes a Chromium-specific crash in WebCore::ImageBuffer::context that
- occurs when rendering semi-transparent RTL text.
-
- Test: fast/text/complex-text-opacity.html
-
- * platform/graphics/chromium/FontChromiumWin.cpp: Handle RTL when computing text bounds.
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
-
-2009-04-08 David Hyatt <hyatt@apple.com>
-
- Reviewed by Beth Dakin
-
- Fix a porting error in my previous patch. A != was supposed to be an ==.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2009-04-08 David Hyatt <hyatt@apple.com>
-
- Reviewed by Adam Roben and Darin Adler
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, repaints inconsistent for
- fixed positioned elements.
-
- Rewrite the updateScrollers method to be more correct in its results.
-
- Test: fast/block/positioning/fixed-positioning-scrollbar-bug.html
+ Override visibleContentRect to handle GTK+'s case, in which
+ scrollbars or equivalent decoration are painted by the parent
+ widget.
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- (WebCore::Document::implicitClose):
- * page/FrameView.cpp:
- (WebCore::FrameView::createScrollbar):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::adjustPageHeight):
- * page/FrameView.h:
- * page/win/FrameWin.cpp:
- (WebCore::computePageRectsForFrame):
* platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::updateScrollbars):
- * platform/ScrollView.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::layout):
- (WebCore::RenderView::docHeight):
- (WebCore::RenderView::docWidth):
- * rendering/RenderView.h:
-
-2009-04-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
-
- Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
- http/tests/security/XFrameOptions/x-frame-options-deny.html
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
-
- * dom/Document.cpp:
- (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank
- if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse
- the X-FRAME-OPTIONS parameter.
- * loader/FrameLoader.h:
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and
- a X-FRAME-OPTIONS header and its parameter dictate that we should.
-
-2009-04-08 Adam Roben <aroben@apple.com>
-
- Fix http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html on Windows
-
- Reviewed by Sam Weinig.
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::visibleContentRect):
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::loadResourceSynchronously): Mimic the
- ResourceHandleMac code by propagating the CFError's error code for
- kCFErrorDomainCFNetwork errors to the ResourceResponse.
+2009-06-27 Daniel Bates <dbates@intudata.com>
-2009-04-08 Anders Carlsson <andersca@apple.com>
+ Reviewed by Adam Barth.
- Try to fix the PPC build.
+ https://bugs.webkit.org/show_bug.cgi?id=26708
- * plugins/npfunctions.h:
-
-2009-04-08 Darin Adler <darin@apple.com>
+ Fix addresses false negatives with respect to scheme relative paths, iFrame JavaScript URLs,
+ and UTF-7 encoded payloads.
- Reviewed by Sam Weinig.
-
- <rdar://problem/5908616> tokenizer resizer should handle edge cases consistently
+ Tests: http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html
+ http/tests/security/xssAuditor/iframe-javascript-url.html
+ http/tests/security/xssAuditor/script-tag-utf-7-encoded.html
+ http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html
* html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::enlargeBuffer): Handle edge cases the same way as a failed fastMalloc.
- (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto.
-
-2009-04-08 David Hyatt <hyatt@apple.com>
-
- Reviewed by Darin Adler
-
- Make sure that cloneNode works with SVG attributes that require synchronization. This fixes
- issues with <use> element shadow tree cloning where the clones can end up not obtaining the
- correct attribute values.
-
- A subsequent patch of mine will expose this problem and cause it to be covered by existing
- layout tests, so no test is required at this time for this problem.
-
- * dom/Element.cpp:
- (WebCore::Element::cloneElementWithoutChildren):
-
-2009-04-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25093
- REGRESSION: some scripts are showing in the Inspector with only "true"
- as the source.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::didParseSource): Fixed conversion issue.
- (WebCore::InspectorController::failedToParseSource): Ditto.
-
-2009-04-08 Adam Barth <abarth@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24904
-
- Verify the MIME type of stylesheets (in standards mode) by looking
- at the Content-Type header directly. This bypasses any content
- sniffing that might be confusing the issue.
-
- Test: http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html
-
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::canUseSheet):
-
-2009-04-08 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=25041
- <rdar://problem/6697754>
- Bug 25041: HTMLMediaElement: OSX autoplay broken by r41907
-
- OSX media player should set readyState to HAVE_ENOUGH_DATA when the movie's load state
- reaches QTMovieLoadStatePlaythroughOK, not when the entire file has been downloaded,
- so autoplay can begin when it should.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::updateStates): Set readState to
- HAVE_ENOUGH_DATA when QTMovie load state reaches QTMovieLoadStatePlaythroughOK.
- (WebCore::MediaPlayerPrivate::paint): Add braces missed in r42203.
-
-2009-04-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by David Kilzer. Based on a patch by Grace Kloba.
-
- https://bugs.webkit.org/show_bug.cgi?id=24656
- cacheControlContainsNoCache() in ResourceResponseBase.h is wrong
-
+ (WebCore::HTMLTokenizer::scriptHandler): Moved XSSAuditor check to HTMLTokenizer::parseTag.
+ (WebCore::HTMLTokenizer::parseTag):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadSubframe): Modified to inform XSSAuditor of parent frame so
+ as to compare against iFrame javascript URL.
+ * page/XSSAuditor.cpp: Removed method XSSAuditor::isControlCharacter. Instead, exposed method
+ isControlCharacter in ResourceResponseBase.cpp.
+ (WebCore::XSSAuditor::XSSAuditor):
+ (WebCore::XSSAuditor::decodeURL): Modified to decode string using specified encoder.
+ (WebCore::XSSAuditor::findInRequest): Generalized to arbitrary frame so as to prevent execution
+ of iFrame javascript URL.
+ * page/XSSAuditor.h: Added field m_parentFrame.
* platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::parseCacheControlDirectives): Removed misused code for
- parsing directive values, fixing parsing of directives that we care about.
-
+ (WebCore::isControlCharacter):
* platform/network/ResourceResponseBase.h:
- (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Fixed a copy/paste mistake,
- m_cacheControlContainsMustRevalidate was returned instead of m_cacheControlContainsNoCache.
-
-2009-04-08 Adam Roben <aroben@apple.com>
-
- Make text fields match the system look on Vista
-
- Reviewed by Dave Hyatt.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::getThemeData): Use the new-to-Vista
- EP_EDITBORDER_NOSCROLL part for text fields.
-2009-04-07 Alexey Proskuryakov <ap@webkit.org>
+2009-06-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
- https://bugs.webkit.org/show_bug.cgi?id=24957
- REGRESSION: Google calendar widget no longer shows upcoming events
-
- Test: http/tests/xmlhttprequest/authorization-header.html
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from
- the list of forbidden headers.
-
-2009-04-07 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Remove no longer needed debug warning and Windows-specific codepaths
- (as we now use the Safari/Win port's timer there)
-
- https://bugs.webkit.org/show_bug.cgi?id=25070
-
- * platform/wx/SharedTimerWx.cpp:
- (WebCore::setSharedTimerFireTime):
-
-
-2009-04-07 Adam Roben <aroben@apple.com>
-
- Fix many <video> regression tests on Windows
-
- Reviewed by Dave Hyatt.
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::getNaturalSize): Call GetMovieNaturalBoundsRect, which
- returns the movie's natural bounds (duh), rather than GetMovieBox,
- which returns the movie's current displayed size/position.
-
-2009-04-07 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler and Sam Weinig
-
- <rdar://problem/5968249> "Private Browsing" doesn't affect HTML 5 LocalStorage
-
- The expected behavior for persistent storage when private browsing mode is undefined by the spec.
- For now we're going with a "read-only when in private browsing" policy until we can get feedback
- and/or get the behavior specified in the spec.
-
- Note that I purposefully made the change to restrict SessionStorage to read-only, also, with the
- understanding that the spec allows for SessionStorage to persist across relaunches, even though
- our implementation currently doesn't do this.
-
- * dom/DOMCoreException.idl: Add some new ExceptionCodes defined in HTML5, one of which is needed
- for LocalStorage changes (QUOTA_EXCEEDED_ERR)
- * dom/ExceptionCode.cpp:
- * dom/ExceptionCode.h:
-
- * storage/StorageArea.cpp:
- (WebCore::StorageArea::internalSetItem): If private browsing is enabled, throw the QUOTA_EXCEEDED_ERR
- exception as the spec allows.
- (WebCore::StorageArea::internalRemoveItem): If private browsing is enabled, silently fail to remove
- the item.
- (WebCore::StorageArea::internalClear): If private browsing is enabled, silently fail to clear the area.
-
-2009-04-07 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6148255>
-
- Standalone media documents can not always handle everything
- using a <video> element. In these cases switch to an <embed>
- element that uses the QuickTime plugin, in the hope that it
- will have more luck. Typical media types that trigger this
- are streamed media and QTVR.
-
- Equivalent Windows fix to come once reviewed. Note also that
- this area of code needs a cleanup:
- https://bugs.webkit.org/show_bug.cgi?id=25085
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
- * html/HTMLMediaElement.h:
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::mediaElementSawUnsupportedTracks):
- (WebCore::MediaDocument::replaceVideoWithEmbed):
- * loader/MediaDocument.h:
- - removes the <video> element and puts in an <embed>
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayerClient::mediaPlayerSawUnsupportedTracks):
- - new internal method for flagging a problem
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- (WebCore::MediaPlayerPrivate::updateStates):
- - looks for the types of content we don't handle
- (WebCore::MediaPlayerPrivate::rateChanged):
- (WebCore::MediaPlayerPrivate::sizeChanged):
- (WebCore::MediaPlayerPrivate::timeChanged):
- (WebCore::MediaPlayerPrivate::didEnd):
- (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
- (WebCore::MediaPlayerPrivate::sawUnsupportedTracks):
- - inform the MediaClient that we have a potential problem
-
-2009-04-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6767428> Resurrect
- +[WebFontCache fontWithFamily:traits:size:] for clients that call it
- directly
-
- WebFontCache is a class in the WebCore framework and is not WebKit API,
- but apparently (perhaps mistakenly) some clients call this private
- interface.
-
- This change resurrects the interface and gives it reasonable behavior
- (however, note that WebCore will not call the old interface, so hacks that
- override it will have no effect on WebKit clients).
-
- * platform/mac/WebFontCache.h:
- * platform/mac/WebFontCache.mm:
- (+[WebFontCache fontWithFamily:traits:size:]): Added. Call through to
- +fontWithFamily:traits:weight:size:.
-
-2009-04-07 David Hyatt <hyatt@apple.com>
-
- Reviewed by Adam Roben
-
- Fix ScrollView's algorithm that determines whether or not to show scrollbars. There was a bug
- with the method mainly because RenderView will size itself to the viewport's size, making it
- impossible to really know the document's "true" size.
-
- In order to solve this problem ScrollView now has a minimumContentsSize method. This method
- returns the document size excluding the RenderView from the calculation. This width/height
- is now cached on RenderView in m_docWidth/m_docHeight member variables.
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::adjustPageHeight):
- (WebCore::FrameView::minimumContentsSize):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/ScrollView.h:
- (WebCore::ScrollView::minimumContentsSize):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::layout):
- (WebCore::RenderView::calcDocHeight):
- (WebCore::RenderView::calcDocWidth):
- * rendering/RenderView.h:
- (WebCore::RenderView::docWidth):
- (WebCore::RenderView::docHeight):
-
-2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
-
- Build fix, not reviewed.
-
- * WebCore.xcodeproj/project.pbxproj: Made ScriptObject.h private.
-
-2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25063
- Refactor InspectorController to use ScriptObject/State.
-
- * GNUmakefile.am: Added ScriptState.cpp.
- * WebCore.pro: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter.
- (WebCore::ScriptFunctionCall::construct): Ditto.
- * bindings/js/ScriptFunctionCall.h: Ditto.
- * bindings/js/ScriptObject.cpp:
- (WebCore::handleException): Added exception-reporting heloper.
- (WebCore::ScriptObject::set): Changed to use handleException.
- (WebCore::ScriptGlobalObject::set): Ditto,
- * bindings/js/ScriptObject.cpp: Added ScriptGlobalObject.
- (WebCore::ScriptGlobalObject::set): Added.
- (WebCore::ScriptGlobalObject::getObject): Added.
- * bindings/js/ScriptObject.h: Added ScriptGlobalObject decls.
- (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
- * bindings/js/ScriptState.cpp: Added.
- * bindings/js/ScriptState.h: Added scriptStateFromPage decl.
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
- to avoid re-entrancy.
- * inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
- * inspector/InspectorController.h: Ditto.
-
-2009-04-07 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25083
-
- Skia was previously calculating the leading value incorrectly, leading
- us to add fHeight to get the height of a line of text. Now that Skia
- is calculating fLeading correctly, we can remove fHeight.
-
- This doesn't affect any layout tests.
-
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformInit):
-
-2009-04-07 Brian Weinstein <bweinstein@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24851
-
- This fix removes the status code from the status message in a ResourceResponse, which allows a few more tests in http to pass.
-
- * platform/network/cf/ResourceResponseCFNet.cpp:
- (WebCore::ResourceResponse::platformLazyInit):
-
-2009-04-07 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25081
-
- Skia is changing from reporting the XRange to reporting the XMin and
- XMax. Obviously these are equivalent, but other users of the metrics
- need the two numbers to be separate.
-
- This doesn't affect any layout tests.
-
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformInit):
-
-2009-04-07 Adam Roben <aroben@apple.com>
-
- Make the look of <select>s match the system look on Vista
-
- Reviewed by Dave Hyatt.
-
- * rendering/RenderThemeWin.cpp: Added new constants.
- (WebCore::RenderThemeWin::getThemeData): On Vista, use the
- CP_DROPDOWNBUTTONRIGHT part for drop down buttons.
- (WebCore::RenderThemeWin::paintMenuList): On Vista, use the CP_BORDER
- part to draw the border of <select>s.
- (WebCore::RenderThemeWin::paintMenuListButton): On Vista, outset the
- drop down button to make its border coincide with the <select>'s
- border.
-
-2009-04-07 Adam Roben <aroben@apple.com>
-
- Move isRunningOnVistaOrLater to a shared location
-
- Rubber-stamped in advance by Dave Hyatt.
-
- * WebCore.vcproj/WebCore.vcproj: Added SystemInfo.{cpp,h}, and let VS
- have its way with the rest of the file.
- * platform/win/ScrollbarThemeWin.cpp: Moved isRunningOnVistaOrLater
- from here...
- * platform/win/SystemInfo.cpp: Added.
- (WebCore::isRunningOnVistaOrLater): ...to here.
- * platform/win/SystemInfo.h: Added.
-
-2009-04-07 Paul Godavari <paul@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24692
- Enable PopupMenuChromium to handle HTML select popups using native
- cocoa controls on the Mac, all other platforms are unchanged.
-
- We also split out the storage container for the popup menu items
- so that ChromeClientChromium can access them for forwarding to
- the embedding host (Chromium.app or test_shell).
-
- * page/chromium/ChromeClientChromium.h:
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::items):
- (WebCore::PopupContainer::PopupContainer):
- (WebCore::PopupContainer::~PopupContainer):
- (WebCore::PopupContainer::showPopup):
- (WebCore::PopupContainer::showExternal):
- (WebCore::PopupContainer::menuItemHeight):
- (WebCore::popupData):
- (WebCore::PopupListBox::pointToRowIndex):
- (WebCore::PopupListBox::getRowBounds):
- (WebCore::PopupListBox::isSelectableItem):
- (WebCore::PopupListBox::updateFromElement):
- (WebCore::PopupListBox::layout):
- (WebCore::PopupListBox::clear):
- (WebCore::PopupMenu::show):
- * platform/chromium/PopupMenuChromium.h:
- (WebCore::PopupItem::):
- (WebCore::PopupItem::PopupItem):
-
-2009-04-07 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Added some double-checking to event handler marking. Now, when the
- wrapper that's responsible for marking an event handler's JavaScript
- function gets collected, it clears the event handler's JavaScript function
- so we won't dereference it after it's collected.
-
- In theory, we would never dereference a JavaScript event handler after
- its node's wrapper was collected anyway, but it's nice to be safe.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::mark):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::jsFunction):
- (WebCore::JSEventListener::invalidateJSFunction):
- (WebCore::JSEventListener::markJSFunction):
- * bindings/js/JSEventListener.h:
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::mark):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::markEventListeners):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::mark):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::mark):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark):
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/EventListener.h:
- (WebCore::EventListener::invalidateJSFunction):
- (WebCore::EventListener::markJSFunction):
- (WebCore::markIfNotNull):
-
-2009-04-07 David Levin <levin@chromium.org>
-
- Build fix.
-
- r44280 undid the change in r42268 that made CookieJar.h private.
- This redoes the change.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-04-07 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Upstream changes to WorkerContextExecutionProxy for enabling V8 preemption.
- https://bugs.webkit.org/show_bug.cgi?id=25034
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::evaluate):
-
-2009-04-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6764359> Thai word selection misbehaves for the
- last sentence in the document
-
- Test: editing/selection/thai-word-at-document-end.html
-
- * editing/visible_units.cpp:
- - Added a BoundarySearchContextAvailability enum used to indicate
- whether the caller to a boundary search function may be able to provide
- additional text in the search direction and call again.
- - Added a named type for the boundary search function signature. Changed
- the signature to take a context availability parameter and a boolean
- out parameter indicating whether more context is needed to perform
- the search.
- (WebCore::previousBoundary): If the beginning of the range was reached
- but the last search wanted more context, perform the search again, this
- time indicating that there is no earlier text.
- (WebCore::nextBoundary): Similarly, in the other direction.
- (WebCore::startWordBoundary): Check whether more context may be available
- and ask for more context if needed.
- (WebCore::endWordBoundary): Ditto.
- (WebCore::previousWordPositionBoundary): Ditto.
- (WebCore::nextWordPositionBoundary): Ditto.
- (WebCore::startSentenceBoundary): Updated signature.
- (WebCore::endSentenceBoundary): Ditto.
- (WebCore::previousSentencePositionBoundary): Ditto.
- (WebCore::nextSentencePositionBoundary): Ditto.
-
-2009-04-07 Geoffrey Garen <ggaren@apple.com>
-
- Rubber stamped by Sam Weinig.
-
- A little renaming:
-
- function => jsFunction
- listener => jsFunction
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSEventListener::jsFunction):
- (WebCore::JSEventListener::mark):
- (WebCore::JSProtectedEventListener::JSProtectedEventListener):
- (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
- (WebCore::JSProtectedEventListener::jsFunction):
- * bindings/js/JSEventListener.h:
- (WebCore::JSProtectedEventListener::create):
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::jsFunction):
- (WebCore::JSLazyEventListener::parseCode):
- * dom/EventListener.h:
- (WebCore::EventListener::jsFunction):
-
-2009-04-07 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to
- avoid creating multiple representations for the same underlying StorageArea.
- * page/DOMWindow.h:
- (WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
-
-2009-04-07 Darin Adler <darin@apple.com>
-
- Roll out incorrect build fix.
-
- * WebCore.NPAPI.exp: Reverted.
-
-2009-04-07 Darin Adler <darin@apple.com>
-
- Another build fix.
-
- * WebCore.NPAPI.exp: Added new functions.
-
-2009-04-07 Anders Carlsson <andersca@apple.com>
-
- Another build fix.
-
- * plugins/npfunctions.h:
-
-2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Unreviewed build fix. Fix non-Mac builds.
-
- * bridge/npapi.h:
-
-2009-04-07 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=25082
-
- Clean up repaint logic when RenderLayers become and stop being composited.
-
- * rendering/RenderLayer.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::rendererContentChanged):
- (WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
- New compositing-only method that repaints a layer and all its non-composited descendants.
- Takes a repaintContainer for performance; all the repaints necessarily share the same
- repaintContainer.
-
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- Rather than use calculateCompositedBounds() to compute the repaint rect (which gave
- the wrong answer when the composited layer tree was in flux), use the new
- repaintOnCompositingChange() method.
-
- (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
- Call repaintIncludingNonCompositingDescendants(), and if necessary make sure
- that the view/layer drawing synchronization happens.
-
- (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- Do a repaintOnCompositingChange() when a layer is going to be composited. This is
- a good place because we haven't started to change the compositing tree.
-
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- After we've finished updating all the descendant layers, we can do a repaint for
- layers that ceased compositing.
-
-2009-04-07 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=25069
-
- Clean up the accelerated compositing code that determines the format of
- the GraphicsLayer hierarchy, being more explicit about which parts have
- to happen before and after descendant layers have been updated. Also remove
- some unhelpful caching of state.
-
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- Only call updateCompositingLayers() if we know we're not going to be
- doing a layout soon.
-
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::GraphicsLayerCA::setDrawsContent):
- Toggling drawsContent from false to true should do a setNeedsDisplay().
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::styleChanged):
- updateLayerCompositingState() no longer updates the layer geometry, so
- do that here if we're not going to rebuild layers anyway.
- Also, updateLayerCompositingState() no longer does a setContentsNeedDisplay,
- so do that if the style change indicates that a repaint is required.
-
- * rendering/RenderLayerBacking.h:
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::RenderLayerBacking):
- (WebCore::RenderLayerBacking::updateAfterLayout):
- The 'drawing optimizations' logic has been rolled into updateGraphicsLayerConfiguration()
- and updateGraphicsLayerGeometry().
-
- (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- Group that code that decides what GraphicsLayers are needed into this method,
- which deals with clipping layers and 'direct compositing': images that can be
- rendered via the compositor.
-
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- Call setDrawsContent() if updateGraphicsLayerConfiguration() didn't already
- figure it out for image layers.
-
- (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- Remove the m_simpleCompositingLayerStatusDirty cache indicator, since we just
- computed it every time anyway.
-
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- updateGraphicsLayers() was renamed to updateGraphicsLayerConfiguration(),
- which calls clippedByAncestor() etc. itself rather than having everything passed in.
- Repaints are taken care of by styleChanged() and setDrawsContent().
-
- (WebCore::RenderLayerCompositor::calculateCompositedBounds):
- !layer->isComposited() && layer->transform() is a synonym for paintsWithTransform().
-
- (WebCore::RenderLayerCompositor::setCompositingParent):
- No need to call updateGraphicsLayerGeometry() here, because we're going to
- rebuild layers anyway.
-
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- Add comments, and test layerBacking instead of layer->isComposited().
-
-2009-04-07 Anders Carlsson <andersca@apple.com>
-
- Fix build.
-
- * WebCore.base.exp:
-
-2009-04-07 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6667001> NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()
-
- * WebCore.base.exp:
- Add symbols needed by WebKit.
-
- * WebCore.xcodeproj/project.pbxproj:
- Make CookieJar a private header.
-
- * bridge/npapi.h:
- Add function definitions.
-
- * plugins/npfunctions.h:
- Fix the NPN_SetValueForURLProcPtr signature.
-
-2009-04-07 Adam Roben <aroben@apple.com>
-
- Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in
- WebView and Bookmarks view after switching theme or turning on High
- Contrast mode
-
- Reviewed by Dave Hyatt.
-
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::themeChanged): Null out scrollbarTheme
- after closing it so that we'll re-open the theme next time we paint.
-
-2009-04-07 Adam Roben <aroben@apple.com>
-
- Small cleanup/correctness fix in ScrollbarThemeWin
-
- Reviewed by Dave Hyatt.
-
- * platform/win/ScrollbarThemeWin.cpp: Removed the now-unused
- haveTheme boolean.
- (WebCore::checkAndInitScrollbarTheme): Check IsThemeActive() before
- calling OpenThemeData. This seems to be what MSDN recommends.
- (WebCore::ScrollbarThemeWin::themeChanged): Null-check scrollbarTheme
- before closing it, rather than indirectly null-checking it via
- checking haveTheme.
-
-2009-04-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - when -webkit-line-break: after-white-space is specified but the text
- does not auto-wrap, do not shrink the trailing space to fit in the
- available width
-
- Test: fast/text/whitespace/nowrap-line-break-after-white-space.html
-
- - when shrinking such trailing space, do not shrink below zero
-
- Covered by existing tests
-
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-04-07 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Move RangeBoundaryPoint off of Position, per Darin's suggestion
- https://bugs.webkit.org/show_bug.cgi?id=24966
-
- Rename setToChild to setToBeforeChild (since that's what the method does)
-
- * dom/Position.h:
- (WebCore::Position::offsetInContainerNode):
- * dom/Range.cpp:
- (WebCore::Range::insertNode):
- (WebCore::Range::selectNodeContents):
- (WebCore::boundaryNodeWillBeRemoved):
- * dom/Range.h:
- (WebCore::Range::startPosition):
- (WebCore::Range::endPosition):
- * dom/RangeBoundaryPoint.h:
- (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
- (WebCore::RangeBoundaryPoint::container):
- (WebCore::RangeBoundaryPoint::childBefore):
- (WebCore::RangeBoundaryPoint::position):
- (WebCore::RangeBoundaryPoint::offset):
- (WebCore::RangeBoundaryPoint::clear):
- (WebCore::RangeBoundaryPoint::set):
- (WebCore::RangeBoundaryPoint::setOffset):
- (WebCore::RangeBoundaryPoint::setToBeforeChild):
- (WebCore::RangeBoundaryPoint::setToStartOfNode):
- (WebCore::RangeBoundaryPoint::setToEndOfNode):
- (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
- (WebCore::RangeBoundaryPoint::invalidateOffset):
-
-2009-04-07 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Add containerNode(), computeOffsetInContainerNode(),
- computeNodeBeforePosition() and computeNodeAfterPosition().
- https://bugs.webkit.org/show_bug.cgi?id=24763
-
- These functions will replace uses of rangeCompliantPosition()
- in future patches.
-
- No changes in behavior, thus no tests.
-
- * dom/Position.cpp:
- (WebCore::Position::containerNode):
- (WebCore::Position::computeOffsetInContainerNode):
- (WebCore::Position::computeNodeBeforePosition):
- (WebCore::Position::computeNodeAfterPosition):
- (WebCore::Position::anchorType):
- * dom/Position.h:
- (WebCore::Position::):
-
-2009-04-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Bottleneck dispatching mutation events in a new dispatchMutationEvent
- function.
-
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::dispatchModifiedEvent):
- * dom/ContainerNode.cpp:
- (WebCore::dispatchChildInsertionEvents):
- (WebCore::dispatchChildRemovalEvents):
- * dom/Node.cpp:
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- (WebCore::Node::dispatchMutationEvent):
- * dom/Node.h:
-
-2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25059
- Remove references to dominantScript, getGenericFontForScript.
-
- * platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
- to getGenericFontForScript.
- (WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
- * platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::defaultGUIFont): Removed Document* arg.
- (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
- * rendering/RenderThemeChromiumLinux.h: Ditto.
- * rendering/RenderThemeChromiumMac.h: Ditto.
- * rendering/RenderThemeChromiumMac.mm: Ditto.
- (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::defaultGUIFont): Ditto.
- (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
- * rendering/RenderThemeChromiumWin.h: Ditto.
-
-2009-04-06 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
- Unbounded memory growth when churning elements with anonymous event handler functions
-
- The problem was that a protected event listener's scope chain would end
- up with a reference to the Node protecting it, causing a cycle. The
- solution is to stop protecting event listeners and rely on marking instead.
-
- This patch converts most Node event listeners to use marking instead of
- GC protection.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::isObservableThroughDOM):
- (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node
- needs marking, and added a case for marking the node in order to mark its
- event listeners.
-
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::markEventListeners):
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- (WebCore::JSNode::mark): Added code to mark a Node's event listeners when
- marking the Node. Changed code using protected event listeners to use event
- listeners.
-
- * dom/Node.idl: Changed code using protected event listeners to use event
- listeners.
-
-2009-04-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Remove unchecked bool return values for some dispatch event functions.
-
- * dom/Node.cpp:
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- (WebCore::Node::dispatchUIEvent):
- (WebCore::Node::dispatchWebKitAnimationEvent):
- (WebCore::Node::dispatchWebKitTransitionEvent):
- (WebCore::Node::dispatchProgressEvent):
- * dom/Node.h:
-
-2009-04-06 Darin Fisher <darin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25058
- Fix chromium build bustage caused by r42216
-
- * bindings/scripts/CodeGeneratorJS.pm:
- * page/DOMWindow.idl:
-
-2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Rubber-stamped by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=20575
- No localization in WebKitGtk
-
- * platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h,
- since there are not translatable strings.
- * platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header
- that is specific for libraries.
-
-2009-04-06 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24978
- Use custom implementations of a few Node methods so that
- we don't over-aggressively create JS wrappers here.
-
- * bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
- * dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
-
-2009-04-06 Dave Moore <davemoore@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25031
- Make the V8 element collections check for named properties *before*
- checking if there are any elements with the same name. Otherwise
- it is both incorrect and slow.
-
- Test: fast/dom/HTMLSelectElement/length-not-overridden.html
-
- Both of these interceptors were attempting to find an element in the
- collection that had a name or id of the property name before checking
- for a JS property with that name.
- * bindings/v8/V8Collection.h:
- (WebCore::collectionNamedPropertyGetter):
- (WebCore::nodeCollectionNamedPropertyGetter):
-
-2009-04-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=25052
-
- Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
- because we need to call it at the end of rebuildCompositingLayerTree() once
- we've determined which descendant layers are composited, otherwise
- calculateCompositedBounds() can give the wrong answer.
-
- Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
- call that explicitly from styleChanged(), if we know a layer update is not pending,
- and similarly from updateAfterLayout().
-
- Test: compositing/overflow/overflow-positioning.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateAfterLayout):
- (WebCore::RenderLayerBacking::updateGraphicsLayers):
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
-
-2009-04-06 Mike Belshe <mike@belshe.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Add accessors to AtomicString which take String/const char* arguments
- so that we don't accidentally thrash the AtomicString table.
-
- https://bugs.webkit.org/show_bug.cgi?id=24979
-
- * platform/text/AtomicString.h:
-
-2009-04-03 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- Make col and row work in WebCore/manual-tests/cursor.html. The issue
- was spotted in the WebKit inspector.
-
- * platform/gtk/CursorGtk.cpp:
- (WebCore::columnResizeCursor):
- (WebCore::rowResizeCursor):
-
-2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
-
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParentVisible):
-
-2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Add new files to the Qt build.
- Export helper function from the Qt JSC binding, needed in WebKit/qt.
-
- * WebCore.pro: Add new files.
- * bridge/qt/qt_runtime.h: Declare convertQVariantToValue.
-
-2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.
-
- Internally the function name is stored as a WebCore::String and the Qt port wants to use this
- constructor programmatically where the function name is also a WebCore::String.
-
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::ScriptFunctionCall):
- * bindings/js/ScriptFunctionCall.h:
-
-2009-04-06 Mike Belshe <mike@belshe.com>
-
- Reviewed by Eric Seidel.
-
- HTMLCanvasElement crash when ImageBuffer creation fails.
- https://bugs.webkit.org/show_bug.cgi?id=23212
-
- Check for NULL before using the ImageBuffer as we might
- be low on memory and creation may have failed.
-
- Test case creation blocked by:
- https://bugs.webkit.org/show_bug.cgi?id=25055
-
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::createImageBuffer):
-
-2009-04-05 Geoffrey Garen <ggaren@apple.com>
-
- [Originally] Reviewed by Sam Weinig.
-
- Rolled back in r42214 with crashes fixed.
-
- [Removed irrelevant ExecState* parameter from event handler registration code.]
-
- [No change in behavior.]
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-05 Erik L. Bunce <elbunce@xendom.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=25050
-
- Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
-
- * platform/qt/DragDataQt.cpp:
- (WebCore::DragData::asURL):
-
-2009-04-05 Simon Hausmann <hausmann@webkit.org>
-
- Fix the Qt build.
-
- * bridge/qt/qt_runtime.h:
- (JSC::Bindings::QtRuntimeMethod::createPrototype): Take the JSGlobalObject
- as second argument.
-
-2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
-
- Build fixes for wxMac/Tiger.
-
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
- * rendering/break_lines.cpp:
- (WebCore::nextBreakablePosition):
- * webcore-wx.bkl:
-
-2009-04-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Cameron Zwarich
-
- https://bugs.webkit.org/show_bug.cgi?id=24648
-
- Ensure that mapPoint(const IntPoint&) calls the FloatPoint
- version to avoid infinite recursion.
-
- No test because mapPoint(const IntPoint&) isn't ever called
- on Mac, so I can't reproduce.
-
- * platform/graphics/transforms/TransformationMatrix.h:
- (WebCore::TransformationMatrix::mapPoint):
-
-2009-04-04 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place
- the insertion point inside a Thai character
-
- Test: fast/text/international/thai-offsetForPosition-inside-character.html
-
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::offsetForPosition): Changed to use
- cursorMovementIterator instead of characterBreakIterator, allowing this
- function to return a valid cursor position even if it is not at
- a character boundary.
-
-2009-04-04 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix an assertion failure when clicking at the beginning of a
- glyph cluster at the beginning of a text run
-
- Test: fast/text/offsetForPosition-cluster-at-zero.html
-
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::offsetForPosition): Corrected the bound
- check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less
- than -1.
-
-2009-04-03 Brian Weinstein <bweinstein@gmail.com>
-
- Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
- when the names are given.
-
- https://bugs.webkit.org/show_bug.cgi?id=25044
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/StylesSidebarPane.js:
- (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
-
-2009-04-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6330929>
- https://bugs.webkit.org/show_bug.cgi?id=21456
-
- Don't update the document pointer for all inactive windows on navigations.
- This change causes us to differ slightly from Firefox when accessing the
- document from within a closure tied to a navigated context, but as all
- browsers differ on this edge case, I don't foresee compatibility issues.
-
- Test: http/tests/security/cross-frame-access-document-direct.html
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::clearWindowShell):
- (WebCore::ScriptController::initScript):
- (WebCore::ScriptController::updateDocument):
- * bindings/js/ScriptController.h:
-
-2009-04-03 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- Test: transitions/bad-transition-shorthand-crash.html
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.
-
- We were starting transitions with 0 duration and delay, which is
- useless. With accelerated compositing on, this went through a code
- path that tried to use m_toStyle, which never got set because the
- transitions was short circuited before it had a chance to. So I
- both protect against using that null pointer and avoid starting
- the transition in the first place.
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
-
-2009-04-03 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where you could not type any more in the Web Inspector's
- search field after the first match is selected in the Resources panel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23982
- rdar://problem/6592367
-
- Reviewed by Darin Adler.
-
- * inspector/front-end/SourceView.js:
- (WebInspector.SourceView.prototype._jumpToSearchResult): Use the
- window object of the frame to set the selection, not the main window.
-
-2009-04-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
- <rdar://problem/6346030>
- Don't allow overriding the return value of window.location.
-
- Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html
- fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
- fast/dom/Window/Location/location-override-toString-on-proto.html
- fast/dom/Window/Location/location-override-toString-using-defineGetter.html
- fast/dom/Window/Location/location-override-toString-using-with.html
- fast/dom/Window/Location/location-override-toString.html
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
- fast/dom/Window/Location/location-override-valueOf-on-proto.html
- fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
- fast/dom/Window/Location/location-override-valueOf-using-with.html
- fast/dom/Window/Location/location-override-valueOf.html
- fast/dom/Window/Location/window-override-location-using-defineGetter.html
- fast/dom/Window/Location/window-override-window-using-defineGetter.html
- fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
- fast/dom/Window/Location/window-shadow-location-using-string.html
- fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::defineGetter):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::customPut):
- (WebCore::JSLocation::defineGetter):
- (WebCore::JSLocationPrototype::customPut):
- (WebCore::JSLocationPrototype::defineGetter):
- * bindings/scripts/CodeGeneratorJS.pm:
- * page/Location.idl:
-
-2009-04-03 Geoffrey Garen <ggaren@apple.com>
-
- Rolled out r42214 since it seems to have caused crashes on the buildbot.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix for <rdar://problem/6476356>
- https://bugs.webkit.org/show_bug.cgi?id=23148
-
- - Use the window object the Location and History objects are directly associated with
- instead of the lexical global object to pick the object prototype to serve as the
- base of the their respective prototype chains.
- - Re-factor as necessary to allow passing the correct global object to the createPrototype
- functions.
-
- Tests: http/tests/security/cross-frame-access-history-prototype.html
- http/tests/security/cross-frame-access-location-prototype.html
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::getCachedDOMStructure):
- (WebCore::cacheDOMStructure):
- * bindings/js/JSDOMBinding.h:
- (WebCore::getDOMStructure):
- (WebCore::getDOMPrototype):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::history):
- (WebCore::JSDOMWindow::location):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::location):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createPrototype):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::createPrototype):
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
- (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- * bindings/js/JSWebKitPointConstructor.cpp:
- (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- * bindings/js/JSWorkerConstructor.cpp:
- (WebCore::JSWorkerConstructor::JSWorkerConstructor):
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::createPrototype):
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createPrototype):
- * bridge/runtime_object.h:
- (JSC::RuntimeObjectImp::createPrototype):
- * page/DOMWindow.idl:
-
-2009-04-03 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25009
- Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
- (WebCore::WorkerContextExecutionProxy::dispose):
- (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
- (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- * bindings/v8/WorkerContextExecutionProxy.h:
-
-2009-04-03 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Removed irrelevant ExecState* parameter from event handler registration code.
-
- No change in behavior.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-04-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser.
-
- - fix <rdar://problem/6634771> Under full-page zoom, cannot scroll
- MobileMe contact list
-
- Test: fast/css/zoom-in-length-round-trip.html
-
- * dom/Element.cpp:
- (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure
- that the returned value is equal to the original unscaled value.
- (WebCore::adjustForAbsoluteZoom): Ditto.
-
-2009-04-03 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=24941
-
- This fix essentially does a -viewWillDraw call for layout. It adds
- a CFRunLoopObserver which performs layout just before drawing on the
- Mac platform. This makes sure layout is complete before rendering and
- avoids a flash.
+ Bug 26771: Canvas is incorrectly tainted when drawing from a video element that uses <source> elements
- * page/ChromeClient.h:
- (WebCore::ChromeClient::scheduleViewUpdate):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::setCompositingLayersNeedUpdate):
- (WebCore::RenderLayerCompositor::scheduleViewUpdate):
- * rendering/RenderLayerCompositor.h:
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24648
-
- Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.
-
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::mapPoint):
- (WebCore::TransformationMatrix::mapRect):
- (WebCore::TransformationMatrix::mapQuad):
- * platform/graphics/transforms/TransformationMatrix.h:
- (WebCore::TransformationMatrix::mapPoint):
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=25018
-
- Add containsPoint() and containsQuad() methods to FloatQuad.
-
- * platform/graphics/FloatQuad.cpp:
- (WebCore::dot):
- (WebCore::isPointInTriangle):
- (WebCore::FloatQuad::containsPoint):
- (WebCore::FloatQuad::containsQuad):
- * platform/graphics/FloatQuad.h:
-
-2009-04-03 Kevin Decker <kdecker@apple.com>
+ The drawImage(<video>) logic naively assumes that it just needs
+ to check the src attribute of the video element when in fact it
+ needs to look at the url that is being played instead. Failure
+ to do this means that video provided through source elements
+ taints the canvas.
- Reviewed by Darin.
+ Test: media/video-canvas-source.html
- * loader/ProgressTracker.cpp: Included DocumentLoader.h
- (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to
- documents that use WebCore's layout system.
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::checkOrigin):
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ * html/CanvasRenderingContext2D.h:
-2009-04-03 Eric Carlson <eric.carlson@apple.com>
+2009-06-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Simon Fraser.
- https://bugs.webkit.org/show_bug.cgi?id=25029
- <rdar://problem/6336092> REGRESSION: movie does not resize correctly
-
- Test: media/video-size-intrinsic-scale.html
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead
- of QTMovieNaturalSizeAttribute so we return the correct size for movies saved
- with a non-default matrix.
- (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView
- because [QTMovieView setFrame] also resizes the movie itself, and as
- the renderer calls setSize immediately when a movie reports a size change
- (QTMovieSizeDidChangeNotification) we can get into a feedback loop
- observing the size change and resetting the size, and this can cause
- QuickTime to miss correctly setting a movie's size when the media size
- changes after opening (as happens with an rtsp movie once the server sends
- the track sizes). Instead, remember the size passed to paint() and
- resize the view when it changes.
- (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect
- so we return the correct size for movies saved with non-default matrix.
-
-2009-04-03 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
- https://bugs.webkit.org/show_bug.cgi?id=25028
-
- * loader/FrameLoader.h:
- (WebCore::FrameLoader::policyDocumentLoader):
-
-2009-04-02 Michael Nordman <michaeln@google.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Use long long, not int64, when working in webcore (sorry).
- https://bugs.webkit.org/show_bug.cgi?id=25011
-
- No change in functionality, so no tests.
-
- * platform/network/chromium/ResourceResponse.h:
- (WebCore::ResourceResponse::getAppCacheID):
- (WebCore::ResourceResponse::setAppCacheID):
-
-2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- Remove pre-processor checks for GTK+ >= 2.10, since we now require
- at least that version.
-
- * platform/graphics/gtk/FontPlatformDataGtk.cpp:
- (WebCore::FontPlatformData::FontPlatformData):
- * platform/gtk/ContextMenuItemGtk.cpp:
- (WebCore::gtkStockIDFromContextMenuAction):
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/gtk/LocalizedStringsGtk.cpp:
- (WebCore::contextMenuItemTagSelectAll):
- * platform/gtk/MouseEventGtk.cpp:
- (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::writeSelection):
- (WebCore::Pasteboard::documentFragment):
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=25021
+ https://bugs.webkit.org/show_bug.cgi?id=26695
- Fix repainting an element with a reflection and transform after layout.
- Telling the reflection to repaint directly is wrong, because, with
- LayoutState enabled, it only takes the reflection's transform into account,
- not that of the element. We can fix this, and keep the benefits of LayoutState,
- by computing the reflected repaint rect, and repainting that using the original
- renderer.
-
- Test: fast/repaint/reflection-repaint-test.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=23307
-
- When repainting during layout (when LayoutState is enabled), we need
- to apply the transform to the dirty rect, before applying x(), y() and
- the offset storted in the LayoutState.
-
- Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
- since LayoutState is always root-relative.
-
- Test: fast/repaint/transform-layout-repaint.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToContainer):
- (WebCore::RenderBox::computeRectForRepaint):
-
-2009-04-02 Mark Rowe <mrowe@apple.com>
-
- Fix the Mac build after r42191.
-
- * WebCore.base.exp:
-
-2009-04-02 Mark Rowe <mrowe@apple.com>
-
- Fix Windows build after r42190.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::keyEvent): Update to use the new name of the constant.
-
-2009-04-02 Darin Adler <darin@apple.com>
-
- Reviewed by Brady Eidson.
-
- <rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/
-
- Test: http/tests/navigation/onload-navigation-iframe-2.html
-
- * html/HTMLFrameElement.cpp:
- (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
- * html/HTMLFrameElement.h: Ditto.
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
- * html/HTMLFrameElementBase.h: Ditto.
- * html/HTMLFrameOwnerElement.cpp:
- (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
- * html/HTMLFrameOwnerElement.h: Ditto.
- * html/HTMLIFrameElement.cpp:
- (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
- * html/HTMLIFrameElement.h: Ditto.
- * html/HTMLPlugInElement.cpp:
- (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag.
- The original change that introduced this, http://trac.webkit.org/changeset/25410, does
- not make it clear why this check was needed. And it seems it is not needed.
-
-2009-04-02 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Add a way to get a list of focusable nodes.
-
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
- (WebCore::Document::getFocusableNodes):
- * dom/Document.h:
-
-2009-04-02 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6654255> crash due to null FrameView in EventHandler
-
- Lots of code was added to EventHandler that used view() and page() without
- null checking, but both of those can become null due to the frame lifetime.
+ Added the ability to do scrollbar hit testing in EventHandler, changed the
+ signature of a PlatformWheelEvent constructor, and changed scrollbarUnderMouse
+ to scrollbarUnderPoint, and updated all calls to that function.
* page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEventSingleClick):
- (WebCore::EventHandler::eventMayStartDrag):
- (WebCore::EventHandler::handleAutoscroll):
- (WebCore::EventHandler::autoscrollTimerFired):
- (WebCore::EventHandler::setPanScrollCursor):
- (WebCore::EventHandler::allowDHTMLDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
- (WebCore::EventHandler::stopAutoscrollTimer):
- (WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::dispatchDragEvent):
- (WebCore::EventHandler::prepareMouseEvent):
- (WebCore::EventHandler::dispatchMouseEvent):
- (WebCore::EventHandler::handleWheelEvent):
- (WebCore::EventHandler::hoverTimerFired):
- (WebCore::EventHandler::keyEvent):
- (WebCore::EventHandler::dragHysteresisExceeded):
- (WebCore::EventHandler::shouldDragAutoNode):
- (WebCore::EventHandler::handleDrag):
- (WebCore::EventHandler::handleTextInputEvent):
- (WebCore::EventHandler::addPendingFrameUnloadEventCount):
- (WebCore::EventHandler::removePendingFrameUnloadEventCount):
- (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
- (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
- (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
- (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
- Added null checks for view() and page(). Made minor code cleanups.
-
-2009-04-02 David Hyatt <hyatt@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
- still considers it an error for the purposes of firing onerror.
-
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent):
-
-2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=25010
- Refactor InspectorController to replace all JS function invocations with
- ScriptFunctionCall.
-
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
- and JSValuePtr methods.
- (WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
- method.
- * bindings/js/ScriptFunctionCall.h: Decls for above.
- * bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow.
- (WebCore::getQuarantinedScriptObject):
- * bindings/js/ScriptObjectQuarantine.h: Decls for above.
- * inspector/InspectorController.cpp:
- (WebCore::callSimpleFunction): Made into a static.
- (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall.
- (WebCore::InspectorController::toggleRecordButton): Ditto.
- (WebCore::InspectorController::startGroup): Ditto.
- (WebCore::InspectorController::setAttachedWindow): Ditto.
- (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto.
- (WebCore::InspectorController::addScriptProfile): Ditto.
- (WebCore::InspectorController::didParseSource): Ditto.
- (WebCore::InspectorController::failedToParseSource): Ditto.
- (WebCore::InspectorController::didPause): Ditto.
- * inspector/InspectorController.h: Removed callFunction and callSimpleFunction
- decls.
-
-2009-04-02 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Upstream changes to V8WorkerContextEventListener for V8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=25007
-
- * bindings/v8/V8ObjectEventListener.h:
- * bindings/v8/V8WorkerContextEventListener.cpp:
-
-2009-04-02 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Upstream V8WorkerContextObjectEventListener for V8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=25005
-
- * bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
- * bindings/v8/V8WorkerContextObjectEventListener.h: Added.
-
-2009-04-02 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Upstream V8EventListenerList for V8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=25004
-
- * bindings/v8/V8EventListenerList.cpp: Added.
- * bindings/v8/V8EventListenerList.h: Added.
-
-2009-04-02 Michael Nordman <michaeln@google.com>
-
- Reviewed by Darin Fisher.
-
- Chromium's ResourceRequest and ResourceResponse structs need some new data members.
- https://bugs.webkit.org/show_bug.cgi?id=24897
-
- These fields are needed to facilitate Chromium's implementation of the HTML5
- ApplicationCache feature. We need to know what frame (or context) is doing the
- requesting, and from what cache the resulting resource was retrieved.
-
- No change in functionality, so no tests.
-
- * platform/network/chromium/ResourceRequest.h:
- (WebCore::ResourceRequest::ResourceRequest):
- (WebCore::ResourceRequest::appCacheContextID):
- (WebCore::ResourceRequest::setAppCacheContextID):
- * platform/network/chromium/ResourceResponse.h:
- (WebCore::ResourceResponse::ResourceResponse):
- (WebCore::ResourceResponse::getAppCacheID):
- (WebCore::ResourceResponse::setAppCacheID):
-
-2009-04-02 David Hyatt <hyatt@apple.com>
-
- Reviewed by Darin Adler
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.
-
- Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
- else just ignores it and displays the image anyway.
-
- Added http/tests/misc/image-error.html
-
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::notifyFinished):
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::CachedImage):
- * loader/CachedImage.h:
- (WebCore::CachedImage::httpStatusCodeError):
- (WebCore::CachedImage::httpStatusCodeErrorOccurred):
- * loader/CachedResource.h:
- (WebCore::CachedResource::httpStatusCodeError):
- * loader/loader.cpp:
- (WebCore::Loader::Host::didReceiveData):
-
-2009-04-02 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Add XHR constructor in WorkerContext.idl for V8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=24962
-
- * workers/WorkerContext.idl:
-
-2009-04-02 Ben Murdoch <benm@google.com>
-
- Fix Bug 19743: Release build fails on 32-bit Windows
-
- <https://bugs.webkit.org/show_bug.cgi?id=19743>
-
- Combines all the HTML element cpp files into one to help reduce the
- size of WebCore.lib so we can build in release mode on 32bit Windows.
-
- Reviewed by Adam Roben.
-
- * WebCore.vcproj/WebCore.vcproj: Excluded all the separate
- HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp
- to the build.
- * html/HTMLElementsAllInOne.cpp: Added.
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24999
-
- Optimize hit testing with transforms.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToContainer):
- (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- getTransformFromContainer() change to return the matrix by reference.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::update3DTransformedDescendantStatus):
- The method failed to set m_3DTransformedDescendantStatusDirty to false,
- so did the work every time.
-
- (WebCore::RenderLayer::createLocalTransformState):
- Only call the expensive getTransformFromContainer() if there is a transform,
- otherwise we just have a translation.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::getTransformFromContainer):
- * rendering/RenderObject.h:
- Change transformFromContainer() to getTransformFromContainer(), and return
- the matrix by reference to reduce copying.
- New enum values for arguments for readability.
-
- * rendering/TransformState.cpp:
- (WebCore::TransformState::move):
- (WebCore::TransformState::applyTransform):
- (WebCore::HitTestingTransformState::translate):
- New method that adds a translation to the accumulated matrix, optionally
- without flattening. Cheaper than applyTransform().
-
- (WebCore::HitTestingTransformState::applyTransform):
- (WebCore::HitTestingTransformState::flatten):
- (WebCore::HitTestingTransformState::flattenWithTransform):
- Add flattenWithTransform(), which is a helper that allows us to
- avoid doing the inverse() twice.
-
- * rendering/TransformState.h:
- (WebCore::TransformState::):
- (WebCore::TransformState::move):
- (WebCore::HitTestingTransformState::):
- New method on HitTestingTransformState that adds a translation to the
- accumulated matrix, optionally without flattening. Cheaper than applyTransform().
- New enum values for arguments for readability.
-
-2009-04-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24648
-
- Optimize common code paths in TransformationMatrix.
-
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::translate):
- (WebCore::TransformationMatrix::translate3d):
- Optimize to avoid matrix copy.
-
- (WebCore::TransformationMatrix::isInvertible):
- Test for identity and translation matrices before computing
- the determinant.
-
- (WebCore::TransformationMatrix::inverse):
- Optimize for identity matrix and translations.
-
- * platform/graphics/transforms/TransformationMatrix.h:
- (WebCore::TransformationMatrix::isIdentityOrTranslation):
- Utility method.
-
-2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24930
- [Gtk] ISO files content is displayed inside the webview instead of being downloaded
-
- Also sniff content of types declared as text/plain. This is
- justified by the fact that it is common to have Apache HTTP
- servers configured to send text/plain as Content-Type by default.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::gotHeadersCallback):
-
-2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Alexey Proskuryakov.
-
- Protect the handle when notifying the client that the response was
- received also in gotChunkCallback, or we crash in didReceiveData
- when the load is cancelled in didReceiveResponse.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::gotChunkCallback):
-
-2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=25001
- Crash when content type parameters have no value
-
- Handle the case where a Content-Type header parameter has no
- value (i.e. no = character), to work-around a bug in libsoup.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
-
-2009-04-02 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24490
-
- Enable web workers in Qt.
-
- * WebCore.pro:
-
-2009-04-01 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler. Based on work of Julien Chaffraix.
-
- https://bugs.webkit.org/show_bug.cgi?id=22475
- REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore
-
- https://bugs.webkit.org/show_bug.cgi?id=24886
- XHR requests opened when offline never return
-
- Tests: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
- http/tests/xmlhttprequest/state-after-network-error.html
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this
- wasn't an error.
- (WebCore::XMLHttpRequest::abort): Fixed formatting.
- (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange.
- The comment saying that this doesn't match Firefox was added in r33559 without explanation
- or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state
- to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt
- that any code depends on this, so I went with the spec here.
-
-2009-04-01 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=24997
- Race conditions in icon database threading code
-
- m_syncThreadRunning set was mistakenly eliminated in r27717.
- This reintroduces it.
-
- Reviewed by Oliver Hunt.
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open): Set m_syncThreadRunning.
-
-2009-04-01 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6748609> Use ActiveDOMObject to suspend marquees
-
- Make marquees ActiveDOMObjects, get rid of the special suspension code.
-
- * html/HTMLMarqueeElement.cpp:
- (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
- (WebCore::HTMLMarqueeElement::canSuspend):
- (WebCore::HTMLMarqueeElement::suspend):
- (WebCore::HTMLMarqueeElement::resume):
- * html/HTMLMarqueeElement.h:
- * page/Frame.cpp:
- (WebCore::Frame::clearTimers):
- * rendering/RenderLayer.cpp:
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::marquee):
-
-2009-04-01 Dean Jackson <dino@apple.com>
-
- Reviewed by Darin Adler
-
- Make constant values static in previous commit, as suggested
- by Darin.
-
- * rendering/RenderVideo.cpp:
-
-2009-04-01 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=24993
-
- Standalone media should have a smaller instrinsic
- height.
-
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::RenderVideo):
-
-2009-04-01 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 22378: Crash submitting a form when parsing an XHTML document
- https://bugs.webkit.org/show_bug.cgi?id=22378
- rdar://problem/6388377
-
- Tests: fast/loader/submit-form-while-parsing-1.xhtml
- fast/loader/submit-form-while-parsing-2.html
-
- * WebCore.base.exp: Updated.
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children.
- Used uncheckedAppend because we reserveInitialCapacity.
- (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children.
- Added an assertion that this is only used to add items that don't have
- duplicate frame names.
- (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item
- if any, preserving the isTargetItem flag.
- (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName
- for consistency with the other functions here that all call the frame name the
- "target". Also updated for rename of m_subItems to m_children.
- (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem.
- Removed unneeded size check.
- (WebCore::HistoryItem::targetItem): Changed to always return the top item
- if no item has the isTargetItem flag set. The old version would instead return
- 0 in some cases, but return the top item if it had no children.
- (WebCore::HistoryItem::children): Renamed m_subItems to m_children.
- (WebCore::HistoryItem::hasChildren): Ditto.
- (WebCore::HistoryItem::showTreeWithIndent): Ditto.
-
- * history/HistoryItem.h: Name changes.
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of
- attaching "recorded form values" and "form about to be submitted" to the frame
- loader. Parameter work fine for this; there's no need to store state on the
- FrameLoader.
-
- * loader/FormState.cpp:
- (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map.
- (WebCore::FormState::create): Ditto.
- * loader/FormState.h: Update to use a vector that we adopt instead of hash map
- that we copy for auto-fill text field values.
-
- * loader/FrameLoader.cpp:
- (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for
- form submissions and turned the "wasDuringLoad" state into a separate boolean
- instead of using a special redirection type to track it.
- (WebCore::FrameLoader::createWindow): Updated for name and argument change of
- loadFrameRequest.
- (WebCore::FrameLoader::urlSelected): Ditto.
- (WebCore::FrameLoader::submitForm): Removed the "deferred form submission"
- machinery, replacing it with the "scheduled redirection" mechanism, shared
- with other kinds of redirection and navigation. Moved frame targeting here
- so we can schedule the redirection on the right frame. Moved the multiple
- form submission protection here. Moved the code to implement the rule that
- m_navigationDuringLoad was used for here too.
- (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead
- of the locationChangeDuringLoad type to detect location change during a load.
- (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function,
- submitFormAgain.
- (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading
- out of this function into scheduleRedirection, so it can be shared with the
- new scheduleFormSubmission function.
- (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as
- scheduleLocationChange, but with the arguments for a form submission.
- (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the
- duringLoad flag.
- (WebCore::FrameLoader::isLocationChange): Added case for formSubmission
- and removed case for locationChangeDuringLoad.
- (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded
- completeURL call and just use KURL constructor to match the other cases.
- (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up
- the m_navigationDuringLoad, which is no longer needed. The new version of
- this is in the submitForm function and sets the lockHistory boolean.
- (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load
- in here that used to be in scheduleLocationChange.
- (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission
- and removed case for locationChangeDuringLoad.
- (WebCore::FrameLoader::stopRedirectionTimer): Ditto.
- (WebCore::FrameLoader::completed): Removed call to now-obsolete function,
- submitFormAgain.
- (WebCore::FrameLoader::loadFrameRequest): Renamed from
- loadFrameRequestWithFormAndValues. Replaced form element and form values
- argument with a single FormState argument. Changed frame targeting code
- to use the source frame in the case of a form submission to better match
- the actual target frame.
- (WebCore::FrameLoader::loadURL): Don't search for existing frames in the
- form submission case since we already did that in the submitForm function.
- (WebCore::FrameLoader::clientRedirected): Changed to work with the
- m_isExecutingJavaScriptFormAction data member directly instead of taking
- it as a function parameter.
- (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames
- in the form submission case since we already did that in the submitForm
- function.
- (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment
- in here that was misplaced elsewhere in the file.
- (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early
- return idiom.
- (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes.
- (WebCore::FrameLoader::childFramesMatchItem): Ditto.
- (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the
- m_navigationDuringLoad logic; that's now handled by setting lockHistory
- to true in the submitForm function.
- (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
- Use the new setChildItem function so we don't get multiple items for the
- same frame name in the history item tree in the back/forward list.
-
- * loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to
- loadFrameRequest and made it take a form state object instead of the
- form element and form values. Removed the unused functions
- loadEmptyDocumentSynchronously, provisionalDocumentLoader,
- notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the
- submitForm function to take a form state argument. Eliminated the
- clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue
- functions, which are replaced by the form state arguments to submitForm
- and loadFrameRequest. Removed the isJavaScriptFormAction argument from
- the clientRedirected function; instead it looks at a data member directly.
- Eliminated the submitFormAgain and overload of the submitForm function;
- these are now subsumed into the remaining submitForm function and the
- scheduleFormSubmission function. Removed unused and obsolete data
- members m_navigationDuringLoad, m_deferredFormSubmission,
- m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
-
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::contextMenuItemSelected):
- Updated for name and argument change of loadFrameRequest.
-
- * page/Frame.cpp:
- (WebCore::Frame::~Frame): Removed call to the now-unneeded
- clearRecordedFormValues function.
-
-2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, fixing previous commit.
-
- https://bugs.webkit.org/show_bug.cgi?id=24994
- Revert V8DOMMap.cpp change which accidentally snuck into the previous
- commit.
-
- * bindings/v8/V8DOMMap.cpp: Revert change in previous commit.
-
-2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24994
- Fix miscellaneous merge/upstreaming divergencies in Chromium port.
-
- * bindings/v8/V8Collection.h: Added an include.
- * platform/KURLGoogle.cpp:
- (WebCore::KURL::baseAsString): Added to match KURL.cpp.
- * platform/chromium/ClipboardChromium.cpp: Added an include.
-
-2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24989
- Refactor InspectorResource to use ScriptObject/FunctionCall.
-
- * bindings/js/JSInspectorControllerCustom.cpp:
- (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use
- a more appropriate type conversion.
- (WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to
- accommodate for InspectorResource refactoring.
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match
- existing jsNumber call signature.
- * bindings/js/ScriptFunctionCall.h: Declaration for above.
- * bindings/js/ScriptObject.cpp:
- (WebCore::createEmptyObject): Added.
- (WebCore::ScriptObject::ScriptObject):
- (WebCore::ScriptObject::set): Added a bunch of property setters.
- * bindings/js/ScriptObject.h: Declarations for above.
- * inspector/InspectorController.cpp: Moved all InspectorResource-managing code
- to InspectorResource.cpp
- (WebCore::InspectorController::populateScriptObjects): Changed to use
- refactored InspectorResource.
- (WebCore::InspectorController::resetScriptObjects): Ditto.
- (WebCore::InspectorController::pruneResources): Ditto.
- (WebCore::InspectorController::didCommitLoad): Ditto.
- (WebCore::InspectorController::addResource): Ditto.
- (WebCore::InspectorController::removeResource): Ditto.
- (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
- (WebCore::InspectorController::identifierForInitialRequest): Ditto.
- (WebCore::InspectorController::willSendRequest): Ditto.
- (WebCore::InspectorController::didReceiveResponse): Ditto.
- (WebCore::InspectorController::didReceiveContentLength): Ditto.
- (WebCore::InspectorController::didFinishLoading): Ditto.
- (WebCore::InspectorController::didFailLoading): Ditto,
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
- (WebCore::InspectorController::scriptImported): Ditto.
- * inspector/InspectorController.h: Removed InspectorResource-managing code decls
- and tweaked some signatures to use ScriptString and long long for identifier.
- * inspector/InspectorController.idl: Changed to use long long for identifier.
- * inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall.
- (WebCore::InspectorResource::InspectorResource): Ditto.
- (WebCore::InspectorResource::~InspectorResource): Ditto.
- (WebCore::InspectorResource::createCached): Added.
- (WebCore::InspectorResource::updateRequest): Added.
- (WebCore::InspectorResource::updateResponse): Added.
- (WebCore::createHeadersObject): Added.
- (WebCore::InspectorResource::createScriptObject): Added.
- (WebCore::InspectorResource::updateScriptObject): Added.
- (WebCore::InspectorResource::releaseScriptObject): Added.
- (WebCore::InspectorResource::type): Tweaked to use ScriptString.
- (WebCore::InspectorResource::setXMLHttpResponseText): Added.
- (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString.
- (WebCore::InspectorResource::startTiming): Added.
- (WebCore::InspectorResource::markResponseReceivedTime): Added.
- (WebCore::InspectorResource::endTiming): Added.
- (WebCore::InspectorResource::markFailed): Added.
- (WebCore::InspectorResource::addLength): Added.
- * inspector/InspectorResource.h: Added decls for newly refactored-in methods.
- (WebCore::InspectorResource::create): Added.
- (WebCore::InspectorResource::isSameLoader): Added.
- (WebCore::InspectorResource::markMainResource): Added.
- (WebCore::InspectorResource::identifier): Added.
- (WebCore::InspectorResource::requestURL): Added.
- (WebCore::InspectorResource::frame): Added.
- (WebCore::InspectorResource::mimeType): Added.
- (WebCore::InspectorResource::Changes::Changes): Added new class to track
- resource changes.
- (WebCore::InspectorResource::Changes::hasChange): Added.
- (WebCore::InspectorResource::Changes::set): Added.
- (WebCore::InspectorResource::Changes::clear): Added.
- (WebCore::InspectorResource::Changes::setAll): Added.
- (WebCore::InspectorResource::Changes::clearAll): Added.
-
-2009-04-01 Tony Chang <tony@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Ensure the right click doesn't deselect text under it. This was
- happening in the Chromium and GTK+ ports because they don't select
- the text under the cursor on right click.
-
- This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737
-
- https://bugs.webkit.org/show_bug.cgi?id=24946
-
- Test: fast/events/context-no-deselect.html
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseReleaseEvent):
-
-2009-04-01 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24991
-
- Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
- when getting the transform.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::transformFromContainer):
-
-2009-03-31 Darin Adler <darin@apple.com>
-
- Rolled out that last change until I can investigate the regression test failures it seems
- to have caused.
-
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::decrement):
- * dom/PositionIterator.h:
- (WebCore::PositionIterator::PositionIterator):
-
-2009-03-31 Darin Adler <darin@apple.com>
-
- Reviewed by Eric Seidel.
-
- Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
- https://bugs.webkit.org/show_bug.cgi?id=24621
-
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we
- don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward
- iterator, but also should never arise because of the fix below.
- * dom/PositionIterator.h:
- (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when
- the passed-in node has no children. Like the change above, this is consistent with the rest
- of the class, although in the long run I think it's a bit strange to treat a <p> element
- with no children differently than a <p> element with children.
-
-2009-03-31 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24965
- Bug 24965: HTMLMediaElement: network state changes can be missed
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the
- state changes, even when no event needs to be fired.
-
-2009-03-31 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24964
- Bug 24964: HTMLMediaElement: 'waiting' event may fire twice
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state
- drops below HAVE_FUTURE_DATA.
-
-2009-03-31 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24846
- Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute
-
- Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
- the author recommends downloading the entire resource optimistically, so the
- attribute is made available to the media engine to use if it is able.
-
- Test: media/video-dom-autobuffer.html
-
- * html/HTMLAttributeNames.in: Add autobuffer.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::parseMappedAttribute): New.
- (WebCore::HTMLMediaElement::autobuffer): Ditto.
- (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
-
- * html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
-
- * html/HTMLMediaElement.idl: Add autobuffer.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer.
- (WebCore::MediaPlayer::autobuffer): New.
- (WebCore::MediaPlayer::setAutobuffer): Ditto.
- * platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
-
- * platform/graphics/MediaPlayerPrivate.h:
- (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.
-
-2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24550
- Check return value of vasprintf. This should keep gcc 4.3.3
- happy rather than have it complain about attribute warn_unused_result.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::error):
-
-2009-03-31 Dean Jackson <dino@apple.com>
-
- Style guide violation!
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
-
-2009-03-31 Dean Jackson <dino@apple.com>
-
- Fix Tiger build.
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
-
-2009-03-31 Jian Li <jianli@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Upstream V8DOMMap for v8 bindings.
- https://bugs.webkit.org/show_bug.cgi?id=24951
-
- * bindings/v8/V8DOMMap.cpp: Added.
- * bindings/v8/V8DOMMap.h: Added.
-
-2009-03-31 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24955
-
- Spacebar didn't play/pause in standalone MediaDocument
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
-
-2009-03-31 Alpha Lam <hclam@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24901
- Added the following methods to MediaPlayerPrivate for Chromium port.
- void sizeChanged();
- void rateChanged();
- void durationChanged();
-
- The above changes are to reflect changes in MediaPlayer.cpp.
- More details can be found in the original changeset.
- http://trac.webkit.org/changeset/41907
-
- * platform/graphics/chromium/MediaPlayerPrivateChromium.h:
-
-2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24947
-
- Special-case drawing text-shadow on win32, to let GDI draw in cases
- when both fill & shadow color are opaque and the shadow has no blur.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
- (WebCore::Font::drawComplexText):
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::windowsCanHandleDrawTextShadow):
- (WebCore::windowsCanHandleTextDrawing):
- * platform/graphics/skia/SkiaFontWin.h:
-
-2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Darin Fisher.
-
- r42055 removed some functions in FrameLoader used by Chrome,
- this CL backs out some of those changes to unbreak the Chrome build.
-
- https://bugs.webkit.org/show_bug.cgi?id=24949
-
- * WebCore.base.exp:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
-
-2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Darin Adler.
-
- Build fixes for Chromium.
-
- https://bugs.webkit.org/show_bug.cgi?id=24945
-
- * dom/Document.h:
- * platform/chromium/ClipboardChromium.cpp:
- (WebCore::imageToMarkup):
-
-2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build.
-
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::XMLTokenizer): Use NamedNodeMap instead of NamedAttrMap.
-
-2009-03-30 Steve Falkenburg <sfalken@apple.com>
-
- Don't create CFDataRef with a fixed size.
- Fixes synchronous XMLHTTPRequests on Windows.
-
- Reviewed by Ada Chan.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::WebCoreSynchronousLoader::didReceiveData):
-
-2009-03-30 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
- https://bugs.webkit.org/show_bug.cgi?id=24594
- rdar://problem/6682110
-
- Test: fast/loader/reload-policy-delegate.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's
- the policy loader and can use m_policyLoadType rather than letting it get set inside
- checkNavigationPolicy.
-
-2009-03-30 Timothy Hatcher <timothy@apple.com>
-
- <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
- in Finder (painting without up to date layout)
-
- Reviewed by Dan Bernstein.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::paintContents): Add an early return when
- painting is attempted when layout is needed.
-
-2009-03-30 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24938
-
- Sort alphabetically.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
-
-2009-03-30 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24938
-
- Build fixes for building --3d-rendering and --no-svg
-
- * rendering/RenderLayerBacking.cpp:
-
-2009-03-30 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24938
-
- Build fixes when building --no-svg
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
- * css/CSSCursorImageValue.cpp:
- (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Add missing CSS properties
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
- * dom/Node.cpp:
- (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
- * platform/graphics/Font.cpp:
- (WebCore::Font::floatWidth): Handle unused param
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData): Handle unused param
-
-2009-03-30 Darin Adler <darin@apple.com>
-
- Reviewed by Adam Roben.
-
- Bug 24916: REGRESSION: NavigationAction policy dispatch broken
- https://bugs.webkit.org/show_bug.cgi?id=24916
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr
- is not used twice. This also optimizes the case where a frame name is specified,
- but it's the name of the frame being loaded. Also called release in all the final
- uses of FormState.
-
-2009-03-30 Darin Adler <darin@apple.com>
-
- Reviewed by Adam Roben.
-
- Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
- https://bugs.webkit.org/show_bug.cgi?id=24937
-
- Also should fix the Windows COM bindings build.
-
- * bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
- * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
-
- * dom/NamedAttrMap.h: Renamed class from NamedAttrMap to
- NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap
- functions all public and non-virtual. Removed virtualLength.
-
- * dom/NamedNodeMap.h: Replaced file with just an include
- of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap
- files and remove this file.
-
- * bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
- * dom/Attr.h: Ditto.
- * dom/Attribute.h: Ditto.
- * dom/Document.cpp:
- (WebCore::Document::importNode): Ditto.
- * dom/Element.cpp:
- (WebCore::Element::attributes): Ditto.
- (WebCore::Element::setAttributeMap): Ditto.
- (WebCore::Element::createAttributeMap): Ditto.
- (WebCore::Element::insertedIntoDocument): Ditto.
- (WebCore::Element::removedFromDocument): Ditto.
- (WebCore::Element::openTagStartToString): Ditto.
- (WebCore::Element::removeAttributeNode): Ditto.
- (WebCore::Element::getAttributeNode): Ditto.
- (WebCore::Element::getAttributeNodeNS): Ditto.
- (WebCore::Element::hasAttribute): Ditto.
- (WebCore::Element::hasAttributeNS): Ditto.
- (WebCore::Element::normalizeAttributes): Ditto.
- * dom/Element.h: Ditto.
- * dom/NamedAttrMap.cpp:
- (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto.
- (WebCore::NamedNodeMap::~NamedNodeMap): Ditto.
- (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto.
- (WebCore::NamedNodeMap::getNamedItem): Ditto.
- (WebCore::NamedNodeMap::getNamedItemNS): Ditto.
- (WebCore::NamedNodeMap::removeNamedItem): Ditto.
- (WebCore::NamedNodeMap::removeNamedItemNS): Ditto.
- (WebCore::NamedNodeMap::setNamedItem): Ditto.
- (WebCore::NamedNodeMap::item): Ditto.
- (WebCore::NamedNodeMap::getAttributeItem): Ditto.
- (WebCore::NamedNodeMap::clearAttributes): Ditto.
- (WebCore::NamedNodeMap::detachFromElement): Ditto.
- (WebCore::NamedNodeMap::setAttributes): Ditto.
- (WebCore::NamedNodeMap::addAttribute): Ditto.
- (WebCore::NamedNodeMap::removeAttribute): Ditto.
- (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
- * dom/NamedMappedAttrMap.cpp:
- (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
- * dom/NamedMappedAttrMap.h:
- (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
- * dom/Node.cpp:
- (WebCore::Node::dumpStatistics): Ditto.
- (WebCore::Node::isEqualNode): Ditto.
- (WebCore::Node::isDefaultNamespace): Ditto.
- (WebCore::Node::lookupNamespaceURI): Ditto.
- (WebCore::Node::lookupNamespacePrefix): Ditto.
- (WebCore::Node::compareDocumentPosition): Ditto.
- * dom/Node.h: Ditto.
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
- * editing/ApplyStyleCommand.cpp:
- (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto.
- (WebCore::isEmptyFontTag): Ditto.
- (WebCore::areIdenticalElements): Ditto.
- * editing/markup.cpp:
- (WebCore::appendStartMarkup): Ditto.
- (WebCore::completeURLs): Ditto.
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError): Ditto.
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::updateWidget): Ditto.
- * svg/SVGAnimatedProperty.h:
- (WebCore::synchronizeProperty): Ditto.
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::FunLang::evaluate): Ditto.
- * xml/XPathStep.cpp:
- (WebCore::XPath::Step::nodesInAxis): Ditto.
-
-2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24750
- [GTK] requests download instead of displaying page
-
- Use soup facilities to append parameters to the content type, to
- make that more robust;
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
-
-2009-03-30 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig
-
- Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.
-
- * Configurations/Base.xcconfig: Moved Production definition of
- SECTORDER_FLAGS to here from Xcode project file.
- * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
- in Base.xcconfig to the empty string since it is not used for
- Debug and Release configurations.
- * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.
-
-2009-03-30 Adam Roben <aroben@apple.com>
-
- Windows build fix after recent Node.idl changes
-
- * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
- of classes that derive from Node to rebuild.
-
-2009-03-30 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * svg/graphics/SVGImage.cpp: Added a missing #include.
-
-2009-03-30 Mads Ager <ager@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24879
- Add frame accessor to Screen, Console, and BarInfo objects. Add type
- accessor to BarInfo objects.
-
- In the V8 JavaScript bindings, we need access to the frame and
- type for already created Screen, Console, and BarInfo objects in
- order to keep their wrappers alive across GCs.
-
- * page/BarInfo.cpp:
- (WebCore::BarInfo::frame): Added.
- (WebCore::BarInfo::type): Added.
- * page/BarInfo.h:
- * page/Console.cpp:
- (WebCore::Console::frame): Added.
- * page/Console.h:
- * page/Screen.cpp:
- (WebCore::Screen::frame): Added.
- * page/Screen.h:
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Requested by Antti Koivisto.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
- a better comment.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23445: Copying certain hidden text causes a crash
- https://bugs.webkit.org/show_bug.cgi?id=23445
- rdar://problem/6512520
-
- Test: editing/pasteboard/copy-display-none.html
-
- * editing/markup.cpp:
- (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
- the start of the selection past the end of the range entirely. If we try to iterate we'll
- never hit the end of the range and will probably crash iterating the rest of the document.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
- https://bugs.webkit.org/show_bug.cgi?id=24672
- rdar://problem/6574263
-
- I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
- but there is an Apple-internal website I was able to use to reproduce and fix.
-
- * loader/CachedResource.h: Made makePurgeable public.
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
- so we can get its data if it hasn't yet been purged.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Fix build again.
-
- * loader/EmptyClients.h: Fix typo in name of FormState.h.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Try to fix the release build.
-
- * history/CachedPage.cpp: Make include unconditional, not debug-only.
-
-2009-03-29 Greg Bolsinga <bolsinga@apple.com>
-
- Undo that last build fix, since it turned out the file wasn't deleted.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-03-29 Greg Bolsinga <bolsinga@apple.com>
-
- Fix build break by removing references to deleted header files.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Try to fix the Windows build.
-
- * loader/EmptyClients.h: Added include of FormState.h.
- * loader/MainResourceLoader.cpp: Ditto.
-
-2009-03-29 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24926
- Fix Chromium build break.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Another attempt to fix the Qt build.
-
- * WebCore.pro: Added CheckedRadioButtons.cpp.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 24921: remove include of HTMLFormElement.h from Document.h
- https://bugs.webkit.org/show_bug.cgi?id=24921
-
- * GNUmakefile.am: Added CheckedRadioButtons source files.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
-
- * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
- Removed all the code except for CheckedRadioButtons, and moved that out to be
- a namespace-level class instead of a member of HTMLFormElement.
-
- * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
- Removed all the code except for CheckedRadioButtons, and moved that out to be
- a namespace-level class instead of a member of HTMLFormElement.
-
- * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
- Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
- class to use a namespace-level class instead of a member of HTMLFormElement.
-
- * dom/Node.idl: Changed the type of parentElement from Node to Element for
- two reasons. 1) Node was incorrect, since parentElement returns an Element.
- 2) The bindings won't compile any more unless they know parentElement's
- return value is an Element due to include changes.
-
- * html/HTMLFormElement.cpp: Moved definitions of the functions in the
- CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
-
- * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
- class to the new CheckedRadioButtons.h.
-
- * html/HTMLInputElement.cpp:
- (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
- class to use a namespace-level class instead of a member of HTMLFormElement.
-
- * page/Chrome.cpp:
- (WebCore::Chrome::createWindow): Tweaked formatting.
-
- * css/CSSGrammar.y: Added newly-needed include.
- * dom/Range.cpp: Ditto.
- * editing/BreakBlockquoteCommand.cpp: Ditto.
- * editing/CompositeEditCommand.cpp: Ditto.
- * editing/InsertLineBreakCommand.cpp: Ditto.
- * editing/ModifySelectionListLevel.cpp: Ditto.
- * editing/RemoveFormatCommand.cpp: Ditto.
- * editing/TextIterator.cpp: Ditto.
- * editing/VisiblePosition.cpp: Ditto.
- * loader/DocLoader.cpp: Ditto.
- * page/AccessibilityRenderObject.cpp: Ditto.
- * page/Page.cpp: Ditto.
- * rendering/RenderBlock.cpp: Ditto.
- * rendering/RenderLayer.cpp: Ditto.
- * rendering/RenderObject.h: Ditto.
- * storage/LocalStorageArea.cpp: Ditto.
- * storage/SessionStorageArea.cpp: Ditto.
-
-2009-03-29 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6015407> attr parsing should allow only identifiers
-
- Test: fast/css/attr-parsing.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
- identifiers that start with "-".
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
- case works. This has the pleasant side effect of fixing a bug too.
-
-2009-03-29 Alexey Proskuryakov <ap@webkit.org>
-
- <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
-
- Forgot to save the file after applying changes for review comments.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::willSendRequest):
- (WebCore::didReceiveResponse):
- (WebCore::didReceiveData):
- (WebCore::didSendBodyData):
- (WebCore::didFinishLoading):
- (WebCore::didFail):
- (WebCore::willCacheResponse):
- (WebCore::didReceiveChallenge):
- (WebCore::WebCoreSynchronousLoader::willSendRequest):
- (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
- (WebCore::WebCoreSynchronousLoader::didReceiveData):
- (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- (WebCore::WebCoreSynchronousLoader::didFail):
- (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
-
-2009-03-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
-
- Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
- (WebCore::ResourceHandle::loadResourceSynchronously):
- (WebCore::WebCoreSynchronousLoader::willSendRequest):
- (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
- (WebCore::WebCoreSynchronousLoader::didReceiveData):
- (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- (WebCore::WebCoreSynchronousLoader::didFail):
- (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
- (WebCore::WebCoreSynchronousLoader::load):
- Match Mac behavior more closely - we shouldn't rely on underlying library handling of
- synchronous requests.
-
- * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest):
- -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest
- delegate method for a redirect.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
- Match async behavior more closely.
-
-2009-03-28 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 24914: empty-string assertion crash when running storage tests
- https://bugs.webkit.org/show_bug.cgi?id=24914
-
- * storage/Database.cpp:
- (WebCore::Database::performOpenAndVerify): Don't store empty version strings
- in the map, since empty strings are per-thread.
-
-2009-03-28 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24910
- Fixes for Chromium build.
-
- * bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
- * bindings/v8/custom/V8CustomEventListener.h: ditto.
- * dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
-
-2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>
-
- Not reviewed, correcting landing error.
-
- https://bugs.webkit.org/show_bug.cgi?id=24812
- Custom bindings should be in v8/custom, not v8.
-
- * bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
-
-2009-03-28 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24616
- Add V8 custom bindings for DOMWindow.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
-
-2009-03-28 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24812
- Add V8 custom bindings for HTMLDocument.
-
- * bindings/v8/V8HTMLDocumentCustom.cpp: Added.
-
-2009-03-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix two SVG test failures in 64-bit.
-
- getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
- This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
- identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.
-
- The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
- but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
- check for a negative value and lets the implementation treat the arguments purely as unsigned values.
-
- * svg/SVGTextContentElement.cpp:
- (WebCore::SVGTextContentElement::getNumberOfChars):
- (WebCore::SVGTextContentElement::getSubStringLength):
- (WebCore::SVGTextContentElement::getStartPositionOfChar):
- (WebCore::SVGTextContentElement::getEndPositionOfChar):
- (WebCore::SVGTextContentElement::getExtentOfChar):
- (WebCore::SVGTextContentElement::getRotationOfChar):
- (WebCore::SVGTextContentElement::getCharNumAtPosition):
- (WebCore::SVGTextContentElement::selectSubString):
- * svg/SVGTextContentElement.h:
- * svg/SVGTextContentElement.idl:
-
-2009-03-27 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Get mailto code out of FrameLoader.
-
- * html/HTMLFormElement.cpp:
- (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto
- logic so HTMLFormElement::submit isn't full of ugly bits. This includes the
- part of the logic that involves transformeing the URL that was previously
- inside FrameLoader.
- (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and
- also release the data for slightly less refcount churn.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto,
- since HTMLFormElement now properly prepares both the URL and the form data.
-
-2009-03-27 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
-
- * platform/graphics/chromium/FontCustomPlatformData.cpp:
- (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
- (WebCore::createFontCustomPlatformData): Ditto.
- * platform/graphics/opentype/OpenTypeUtilities.cpp:
- (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to
- the size of an EOTPrefix.
- (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in
- the prefix.
- (WebCore::EOTHeader::appendBigEndianString): Changed the static
- appendBigEndianStringToEOTHeader() into this member function.
- (WebCore::EOTHeader::appendPaddingShort): Added.
- (WebCore::getEOTHeader): Changed to use EOTHeader.
- * platform/graphics/opentype/OpenTypeUtilities.h:
- (WebCore::EOTHeader::size):
- (WebCore::EOTHeader::data):
- (WebCore::EOTHeader::prefix):
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
- (WebCore::createFontCustomPlatformData): Ditto.
-
-2009-03-27 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- To prepare for work on a form loading fix, remove some unused functions,
- consolidate some functions, and make many more functions private in
- FrameLoader.
-
- * WebCore.base.exp: Remove some unused entry points, update another.
-
- * dom/Document.cpp:
- (WebCore::Document::detach): Clear m_frame directly instead of using
- clearFramePointer.
- * dom/Document.h: Ditto.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::urlSelected): Consolidate the two functions
- of this name into a single function. Also changed the event argument
- to be PassRefPtr<Event>.
- (WebCore::FrameLoader::submitForm): Changed the event argument to
- be PassRefPtr<Event>.
- (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
- explicitly so we can remove the version of changeLocation that does
- completeURL for us.
- (WebCore::FrameLoader::redirectionTimerFired): Ditto.
- (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
- directly so we don't need a setProvisionalHistoryItem function.
- (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
- m_quickRedirectComing directly so we don't need a isQuickRedirectComing
- function.
- (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
- (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
- event argument to be PassRefPtr<Event>.
- (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
- function here because this is the only caller. If we want to make the
- resulting function smaller we should refactor some other way. Also
- streamlined the user-chosen encoding logic, but did not change what it does.
- (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
- to be PassRefPtr<Event>.
- (WebCore::FrameLoader::loadPostRequest): Ditto.
- (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
- the didNotOpenURL function here, since this was the only caller.
-
- * loader/FrameLoader.h: Removed include of FormState.h and used a forward
- declaration instead. Removed unneeded forward declation of Element.
- Moved many functions into the private section, and removed some other
- unused or uneeded functions.
-
-2009-03-27 Xiaomei Ji <xji@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=24303
- Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.
-
- Test: editing/selection/extend-selection.html
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::directionOfEnclosingBlock): Added
- (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly
- implemented for character and word granularity, all other granularities
- are treated as "forward".
- (WebCore::SelectionController::modifyExtendingForward): Renamed
- modifyExtendingRightForward() to this.
- (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly
- implemented for character and word granularity, all other granularities
- are treated as "backward".
- (WebCore::SelectionController::modifyExtendingBackward): Renamed
- modifyExtendingLeftBackward() to this.
- (WebCore::SelectionController::modify): Change to call either the
- left/right or backward/forward methods depending on the 'dir' argument
- for extends.
- * editing/SelectionController.h:
-
-2009-03-27 John Abd-El-Malek <jam@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24836
- Fix navigator.plugins.refresh(false) in Chromium.
-
- * plugins/chromium/PluginDataChromium.cpp:
- (WebCore::PluginData::refresh):
-
-2009-03-27 Timothy Hatcher <timothy@apple.com>
-
- Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
- virtual to fix the broken layout tests from my last commit.
-
- Reviewed by Mark Rowe.
-
- * dom/Element.cpp:
- (WebCore::Element::scrollLeft):
- (WebCore::Element::scrollTop):
- (WebCore::Element::scrollWidth):
- (WebCore::Element::scrollHeight):
- * dom/Element.h:
- * html/HTMLBodyElement.h:
-
-2009-03-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
- Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
- items after each node is removed, leading to O(N^2) behaviour. By inlining the batch removal in to setLength we can avoid
- this gratuitous recalcuation.
-
-2009-03-27 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Eric Seidel.
-
- We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
- I took crosshair to have a common behavior with firefox.
-
- [GTK] SVG - Crash on setting the cursor icon
- https://bugs.webkit.org/show_bug.cgi?id=24565
-
- * platform/gtk/CursorGtk.cpp:
- (WebCore::Cursor::Cursor):
-
-2009-03-27 Timothy Hatcher <timothy@apple.com>
-
- Remove redundant attributes and functions from IDL files that have the
- same attributes and functions defined in the super class.
-
- Reviewed by Simon Fraser.
-
- * WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
- * bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
- * html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth
- and scrollHeight.
- * html/HTMLElement.idl: Remove blur and focus.
-
-2009-03-27 Adam Roben <aroben@apple.com>
-
- Don't include substitute data URLs in global history redirect chains
-
- <rdar://6690169>
-
- Reviewed by Darin Adler.
-
- This might be testable if:
- - support were added to DRT for providing substitute data on failed
- loads
- - support were added to DRT for dumping redirect chains
-
- I tried doing the above and was still unable to make a test.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::updateHistoryForStandardLoad):
- (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
- Call updateGlobalHistoryRedirectLinks only if the load succeeded
- (i.e., there is no unreachableURL). Previous the FrameLoaderClient
- implementations were unconditionally calling
- updateGlobalHistoryRedirectLinks from within updateGlobalHistory.
-
-2009-03-27 Peter Kasting <pkasting@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24861
- Chromium port did not render decorations for <input type="search">.
- This copies RenderThemeWin.*.
-
- * css/themeChromiumWin.css: Removed.
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
- (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle):
- (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton):
- (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle):
- (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle):
- (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle):
- (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
- * rendering/RenderThemeChromiumLinux.h:
- (WebCore::RenderThemeChromiumLinux::paintSearchField):
- * rendering/RenderThemeChromiumWin.cpp:
+ * page/EventHandler.h:
(WebCore::):
- (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
- (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle):
- (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton):
- (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle):
- (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle):
- (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle):
- (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
- * rendering/RenderThemeChromiumWin.h:
- (WebCore::RenderThemeChromiumWin::paintSearchField):
-
-2009-03-27 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- If an object has a self-painting layer, don't count it as part of a block's visual overflow.
- This fix has only been made for block-level children. The inline-level case is still broken
- (and covered by an existing bug).
-
- Added fast/block/positioning/negative-rel-position.html
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesVertically):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
-
-2009-03-27 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6642221>
- REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed
-
- Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.
-
- I've filed <rdar://problem/6731022> against the Movies widget.
-
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::rendererIsNeeded):
-
-2009-03-25 Timothy Hatcher <timothy@apple.com>
-
- Expose new DOM methods as public Objective-C API.
-
- <rdar://problem/5837350> Expose new DOM classes and methods
- as public API (match the additions to the JavaScript DOM)
-
- Reviewed by Mark Rowe and Darin Adler.
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/objc/DOMHTML.h:
- * bindings/objc/DOMPrivate.h:
- * bindings/objc/PublicDOMInterfaces.h:
-
-2009-03-27 Zack Rusin <zack@kde.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24280
-
- Fix propagation of fill rules when rendering paths in the Qt build.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::toQtFillRule):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
-
-2009-03-27 Zack Rusin <zack@kde.org>
-
- Reviewed by Tor Arne Vestbø.
-
- https://bugs.webkit.org/show_bug.cgi?id=24275
-
- Fix text field theming in the Qt build with the KDE 4 Oxygen
- style by adjusting the size vertically and horizontally to
- set padding on the element equal to the width of the style painted border.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::RenderThemeQt):
- (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
- (WebCore::RenderThemeQt::adjustTextFieldStyle):
- (WebCore::RenderThemeQt::paintTextField):
- * platform/qt/RenderThemeQt.h:
-
-2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24852
- Build fix for GNU mode RVCT compilation
-
- * html/PreloadScanner.cpp:
-
-2009-03-27 Erik L. Bunce <elbunce@xendom.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24868
-
- Make text of the writing direction items more user friendly.
-
- * platform/qt/Localizations.cpp:
- (WebCore::contextMenuItemTagLeftToRight):
- (WebCore::contextMenuItemTagRightToLeft):
-
-2009-03-27 Erik L. Bunce <elbunce@xendom.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24274
-
- Fixed the Qt 4.4 Mac build with netscape plugins enabled.
-
- * plugins/mac/PluginViewMac.cpp:
-
-2009-03-26 Mark Rowe <mrowe@apple.com>
-
- Try and fix the Qt build.
-
- * platform/text/TextEncodingDetectorNone.cpp:
- (WebCore::detectTextEncoding):
-
-2009-03-26 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24874
- 24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it
-
- The 'duration' attribute is NaN when no media is available, so the
- media element should take care when comparing with duration().
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when
- it is NaN.
- (WebCore::HTMLMediaElement::endedPlayback): Ditto.
-
-2009-03-26 Mark Rowe <mrowe@apple.com>
-
- Fix the build.
-
- * platform/text/TextEncodingDetectorICU.cpp:
- * platform/text/TextEncodingDetectorNone.cpp:
-
-2009-03-26 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Cameron Zwarich.
-
- 1. Fix the crash in setHintEncoding
- 2. Fix build failures on Tiger and Qt.
- UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp
- in the patch landed in r42023
- for http://bugs.webkit.org/show_bug.cgi?id=16482
-
- * loader/TextResourceDecoder.h:
- (WebCore::TextResourceDecoder::setHintEncoding):
- * platform/text/TextEncodingDetectorICU.cpp:
- * platform/text/TextEncodingDetectorNone.cpp:
-
-2009-03-26 Simon Fraser <simon.fraser@apple.com>
-
- Build fix when ACCELERATED_COMPOSITING is turned on.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::canUseDirectCompositing):
-
-2009-03-26 Eric Seidel <eric@webkit.org>
-
- No additional review, committing previously reviewed files for build fix only.
-
- Add files I missed when commiting Jungshik's patch in r42022.
- https://bugs.webkit.org/show_bug.cgi?id=16482
-
- * icu/unicode/ucsdet.h: Added.
- * platform/text/TextEncodingDetector.h: Added.
- * platform/text/TextEncodingDetectorICU.cpp: Added.
- (WebCore::detectTextEncoding):
- * platform/text/TextEncodingDetectorNone.cpp: Added.
- (WebCore::detectTextEncoding):
-
-2009-03-26 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Add an encoding detector 'hook' to TextResourceDecoder.
- - add |usesEncodingDetector| to Settings. It's off by default.
- - add a new encoding source type |EncodingFromParent|
- to distinguish cases when the encoding is inherited from
- the parent frame from cases when it's actually auto-detected.
- - add TextEncodingDetector* to platform/text. Currently,
- the only implementation uses ICU. Stub is added for
- ports that do not use ICU and a build on Tiger. Mac OS
- Tiger comes with ICU 3.2 that does not support encoding detector.
- - add ucsdet.h to icu/unicode for ports using ICU.
-
- Layout tests will be added once bug 20534 is fixed and a WebPreference
- can be controlled in test_shell. With UsesEncodingDetector off, there
- is no change to test.
-
- http://bugs.webkit.org/show_bug.cgi?id=16482
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCore/GNUmakefile.am
- * WebCore/WebCore.pro
- * WebCore/WebCore.scons
- * WebCore/WebCoreSources.bkl
- * WebCore.base.exp
- * icu/unicode/ucsdet.h
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::TextResourceDecoder):
- (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame
- (WebCore::TextResourceDecoder::checkForHeadCharset): ditto
- (WebCore::TextResourceDecoder::shouldAutoDetect):
- (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true.
- (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
- * loader/TextResourceDecoder.h:
- (WebCore::TextResourceDecoder::):
- (WebCore::TextResourceDecoder::create):
- (WebCore::TextResourceDecoder::setHintEncoding):
- (WebCore::TextResourceDecoder::source):
- * page/Settings.cpp: add m_usesEncodingDetector
- (WebCore::Settings::Settings):
- (WebCore::Settings::setUsesEncodingDetector):
- * page/Settings.h:
- (WebCore::Settings::usesEncodingDetector):
- * platform/text/TextEncodingDetector.h: Added.
- * platform/text/TextEncodingDetectorICU.cpp: Added.
- (WebCore::detectTextEncoding):
- * platform/text/TextEncodingDetectorNone.cpp: Added.
- (WebCore::detectTextEncoding):
-
-2009-03-26 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Removed code that casts EventListener down to derived classes
- without type checking. A crash could happen if you added event
- listeners with Objective-C and then manipulated the class with
- JavaScript.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::mark): Removed all the casts
- and used the markIfNotNull function and mark functions on
- EventListener instead.
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::mark): Ditto.
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::mark): Ditto.
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::mark): Ditto.
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark): Ditto.
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent): Used function,
- the new name for what used to be called listenerObj.
- (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since
- this doesn't need to be virtual for callers who have a pointer to
- this class, not the base class.
- (WebCore::JSEventListener::function): Renamed from listenerObj.
- (WebCore::JSProtectedEventListener::function): Ditto.
-
- * bindings/js/JSEventListener.h: Removed unneeded forward class
- declarations. Made all virtual functions private since there's no
- need to call any of them on a particular derived class, only on
- EventListener. Explicitly declare JSEventListener::mark as virtual
- since it's now overriding a function in the EventListener base class.
- Made JSProtectedEventListener::m_globalObject protected so the
- JSLazyEventListener derived class can use it directly instead of using
- a virtual function to get the pointer.
-
- * bindings/js/JSLazyEventListener.cpp:
- (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead
- of globalObject since the latter is a virtual function and there's no
- need to pay virtual function overhead.
- (WebCore::JSLazyEventListener::function): Renamed from listenerObj.
-
- * bindings/js/JSLazyEventListener.h: Moved forward declaration of the
- Node class here from JSEventListener.h.
-
- * bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to
- JSEventListener when getting the script object from a listener.
-
- * dom/EventListener.h: Added virtual function and mark functions
- so we can extract the JavaScript function object or mark a JavaScript
- event listener in a type safe manner.
-
-2009-03-26 Peter Kasting <pkasting@google.com>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=24859
- Use CSS file instead of code to adjust search field styling.
-
- * css/themeWin.css:
- * rendering/RenderThemeWin.cpp:
- * rendering/RenderThemeWin.h:
-
-2009-03-26 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Split JSLazyEventListener out into its own separate source file.
- We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
- so leave those in the same file with JSEventListener.
-
- * GNUmakefile.am: Added JSLazyEventListener.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part.
- Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since
- JSAbstractEventListener is not derived from JSCell.
-
- * bindings/js/JSEventListener.h: Removed the JSLazyEventListener part
- and the now-unneeded include of PlatformString.h.
-
- * bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp.
- Kept only the JSLazyEventListener part.
- (WebCore::eventParameterName): Made this have internal linkage by adding "static".
- Also moved the default case out of the switch statement so we will get a warning
- if we omit any cases in the future.
-
- * bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h.
- Kept only the JSLazyEventListener part.
-
- * bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the
- remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
-
-2009-03-26 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Renamed JSUnprotectedEventListener to JSEventListener.
- And related renames.
-
- Soon Geoff will make all JavaScript event listeners use mark instead
- of protect, so there's no need to emphasize "unprotected".
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::mark):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::jsEventListeners):
- (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSEventListener::listenerObj):
- (WebCore::JSEventListener::globalObject):
- (WebCore::JSEventListener::clearGlobalObject):
- (WebCore::JSEventListener::mark):
- * bindings/js/JSEventListener.h:
- (WebCore::JSEventListener::create):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::mark):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::mark):
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::mark):
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark):
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
- All just renaming.
-
-2009-03-26 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Renamed JSEventListener to JSProtectedEventListener.
- And related renames.
-
- Soon Geoff will make all JavaScript event listeners use mark instead
- of protect, and so this class will be be obsolete. We will rename
- JSUnrpotectedEventListener to JSEventListener in the next check-in,
- since that one will remain.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
- (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
- (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSProtectedEventListener::JSProtectedEventListener):
- (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
- (WebCore::JSProtectedEventListener::listenerObj):
- (WebCore::JSProtectedEventListener::globalObject):
- (WebCore::JSProtectedEventListener::clearGlobalObject):
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventListener.h:
- (WebCore::JSProtectedEventListener::create):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
- All just renaming.
-
-2009-03-26 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can
- create runs extending beyond the end
-
- No test because Safari does not use this version of
- createBidiRunsForLine() with the end iterator not pointing to the end
- of the text run.
-
- * platform/text/BidiResolver.h:
- (WebCore::BidiResolver::appendRun): Cap the end of the run at the end
- of the line and set the reachedEndOfLine flag. This mirrors the logic
- in the specialized version of appendRun() in bidi.cpp, which is why the
- problem did not show up in HTML. Also avoid creating empty runs.
-
-2009-03-26 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24864
-
- Change the terminology from "inner content layer" to "direct compositing"
- for cases where we can push an image directly over to the compositing system,
- without having to draw it.
-
- Clean up much of the code which looks at style to determine if this is possible,
- and fix some bugs when backgrounds change dynamically.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::hasBorderOutlineOrShadow):
- (WebCore::hasBoxDecorations):
- (WebCore::hasBoxDecorationsWithBackgroundImage):
- (WebCore::RenderLayerBacking::canBeSimpleContainerCompositingLayer):
- (WebCore::RenderLayerBacking::canUseDirectCompositing):
- (WebCore::RenderLayerBacking::detectDrawingOptimizations):
- (WebCore::RenderLayerBacking::rendererContentChanged):
- (WebCore::RenderLayerBacking::updateImageContents):
- * rendering/RenderLayerBacking.h:
-
-2009-03-26 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23914
-
- Tests: compositing/overflow/ancestor-overflow.html
- compositing/overflow/parent-overflow.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::calculateClipRects):
- * rendering/RenderLayer.h:
- (WebCore::ClipRects::infiniteRect):
- New static method that returns a large rect that is used by the clipping
- logic.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- Use parentClipRects(), rather than calculateRects(), to compute the overflow
- rect that we'll use to create a masking layer for composited clipping.
-
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::clippedByAncestor):
- Use parentClipRects() to see whether there's a layer between us and our
- compositing ancestor which applies clipping.
-
- (WebCore::RenderLayerCompositor::clipsCompositingDescendants):
- A layer which imposes clipping to its children doesn't have to be a stacking
- context; it might be a normal flow layer; in either case, we can rely on the
- hasCompositingDescendant() bit.
-
-2009-03-26 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=24837
- Escape key should dismiss select menu
-
- Reviewed by Adam Roben.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupWndProc):
-
-2009-03-26 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Make sure the script uses LF line endings even on Windows.
-
- https://bugs.webkit.org/show_bug.cgi?id=24805
-
- * WebCore/make-generated-sources.sh: Change svn:eol-style to LF
-
-2009-03-26 Eli Fidler <eli.fidler@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Remove warnings all over the place by making operator precedence
- explicit in cases like x && y || z. No functional change.
-
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::addFontFaceRule):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::parseShadow):
- * dom/Document.cpp:
- (WebCore::Document::shouldScheduleLayout):
- * dom/Node.cpp:
- (WebCore::Node::isBlockFlowOrBlockTable):
- * dom/Node.h:
- (WebCore::Node::document):
- * dom/Position.cpp:
- (WebCore::Position::next):
- (WebCore::Position::upstream):
- (WebCore::Position::downstream):
- (WebCore::Position::getInlineBoxAndOffset):
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::atStart):
- * dom/Range.cpp:
- (WebCore::Range::intersectsNode):
- * editing/Editor.cpp:
- (WebCore::Editor::setBaseWritingDirection):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::advance):
- (WebCore::SimplifiedBackwardsTextIterator::advance):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::canonicalPosition):
- * editing/htmlediting.cpp:
- (WebCore::isMailBlockquote):
- (WebCore::lineBreakExistsAtPosition):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::processFileDateString):
- * loader/ImageLoader.cpp:
- (WebCore::ImageLoader::updateFromElement):
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::checkForHeadCharset):
- * page/AccessibilityObject.cpp:
- (WebCore::updateAXLineStartForVisiblePosition):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::sendContextMenuEvent):
- * page/animation/AnimationBase.cpp:
- (WebCore::PropertyWrapperGetter::equals):
- (WebCore::PropertyWrapperShadow::equals):
- * platform/ContextMenu.cpp:
- (WebCore::ContextMenu::populate):
+ * platform/PlatformWheelEvent.h:
* platform/ScrollView.cpp:
- (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
- * platform/text/Base64.cpp:
- (WebCore::base64Encode):
- * platform/text/BidiResolver.h:
- (WebCore::::raiseExplicitEmbeddingLevel):
- (WebCore::::createBidiRunsForLine):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::placeEllipsisBox):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::addChild):
- (WebCore::RenderBlock::repaintOverhangingFloats):
- (WebCore::RenderBlock::fillInlineSelectionGaps):
- (WebCore::RenderBlock::positionForPoint):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- (WebCore::RenderBlock::hasLineIfEmpty):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::imageChanged):
- (WebCore::RenderBox::localCaretRect):
- (WebCore::RenderBox::positionForPoint):
- (WebCore::RenderBox::shrinkToAvoidFloats):
- * rendering/RenderObject.h:
- (WebCore::objectIsRelayoutBoundary):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::calcPrefWidths):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::determineStartPosition):
- (WebCore::textWidth):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
- * rendering/style/StyleInheritedData.cpp:
- (WebCore::cursorDataEquivalent):
- * rendering/style/StyleRareInheritedData.cpp:
- (WebCore::StyleRareInheritedData::shadowDataEquivalent):
- * rendering/style/StyleRareNonInheritedData.cpp:
- (WebCore::StyleRareNonInheritedData::shadowDataEquivalent):
- (WebCore::StyleRareNonInheritedData::animationDataEquivalent):
- (WebCore::StyleRareNonInheritedData::transitionDataEquivalent):
-
-2009-03-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24804
- [GTK] 401 responses cause rogue content to be loaded
-
- Our soup code handles 401 responses itself, so we should not feed
- the headers and data of those responses to the loader.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::gotHeadersCallback):
- (WebCore::gotChunkCallback):
-
-2009-03-25 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt and Darin Adler.
-
- Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
- during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
-
- The problem was that allocation of the global object would, for just a
- moment, leave the global object's prototype unprotected from GC. This
- bug doesn't apply to non-global DOM objects because their prototypes are
- cached and marked by the global object.
-
- No test case because the crashing condition is hard to deterministically
- produce in a normal build, and in a Windows Release build with
- COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
-
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::setWindow):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::initScript): Protect the global object's
- prototype from GC during construction, since the global object does not
- yet point to it, and therefore won't mark it.
-
-2009-03-25 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=23361
-
- When using hardware compositing, some images can be directly
- rendered by the hardware - no need to draw them into a separate
- context, therefore saving memory.
- Only images with certain style properties can be directly
- composited - basically anything that is not a simple image requires
- the usual rendering path (eg. if the image has borders).
-
- Test: compositing/direct-image-compositing.html
-
- * manual-tests/resources/simple_image.png: Added.
- * manual-tests/simple-image-compositing.html: Added.
- * platform/graphics/Image.h:
- (WebCore::Image::startAnimation):
- - move this to public
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::imageChanged):
- - poke compositing layer if image has changed
- (WebCore::RenderImage::notifyFinished):
- - let the compositing layer know that it can render the image
- * rendering/RenderImage.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::rendererContentChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::canUseInnerContentLayer):
- (WebCore::RenderLayerBacking::detectDrawingOptimizations):
- (WebCore::RenderLayerBacking::rendererContentChanged):
- * rendering/RenderLayerBacking.h:
- - code to hook up direct compositing of images where
- possible
-
-2009-03-25 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
- rename of V8NodeFilter to V8NodeFilterCondition.
-
- * bindings/v8/V8NodeFilterCondition.cpp:
-
-2009-03-25 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24817
-
- When the slider range is zero, avoid a divide by zero, which caused the
- thumb to be positioned off in the weeds, which broke painting.
-
- Test: media/video-empty-source.html
-
- * rendering/RenderSlider.cpp:
- (WebCore::SliderRange::proportionFromValue):
- (WebCore::SliderRange::valueFromProportion):
- (WebCore::sliderPosition):
- (WebCore::RenderSlider::setValueForPosition):
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Remove dead code and style cleanup
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::CanvasStyle):
- Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't
- want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
- * page/FocusController.cpp:
- (WebCore::FocusController::setFocusedNode):
- "node" was checked just above and is already known to be non-null
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::insertOnlyThisLayer):
- We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check
- (WebCore::RenderLayer::resize):
- element is already ASSERTed above, no need to null check it here
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addCell):
- currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Move ASSERT(foo) to before where foo-> is used
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * platform/chromium/PasteboardChromium.cpp:
- (WebCore::Pasteboard::writeImage):
- Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved
- ASSERT(node) to the top of the function it made sense to move the rest of them there too.
- * rendering/SVGRenderSupport.cpp:
- (WebCore::prepareToRenderSVGContent):
- move ASSERT(object) to *before* we use "object" :)
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Make TextTokenizer ASSERT that the buffer was freed
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * loader/TextDocument.cpp:
- (WebCore::TextTokenizer::TextTokenizer):
- (WebCore::TextTokenizer::~TextTokenizer):
- (WebCore::TextTokenizer::finish):
- Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- I don't have a test case where we were taking the wrong path here
- However, adding an ASSERT(lBreak.obj) before this usage caused
- multiple bidi tests to fail, so lBreak.obj can be null here.
-
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::findNextLineBreak):
- lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Style cleanup and dead code removal in dom, editing
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- (WebCore::ContainerNode::getLowerRightCorner):
- (WebCore::ContainerNode::getRect):
- Coverty was (rightly) confused as to what the hell "o" was being used for
- and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines)
- would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- Remove dead code, this block already checked that change == Force
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::removeInlineStyle):
- Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus
- prev will be null, and we don't really explicitly handle it (like we probably should)
- It's OK though, because we end up creating a null position object, which may not have
- been what we intended, but we certainly don't crash.
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- Remove dead code, insertionPosition.node() is already checked to be non-null above.
- * editing/markup.cpp:
- (WebCore::appendStartMarkup):
- removed dead code, annotate is already known to be true at this point in the file
- !annotate was checked above, and break; was called.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- CSS dead code removal and cleanup from Coverty errors
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- Every other place in the code we check settings() for NULL, so I made these places
- check too, even though we should never be resolving style against a document which has
- no frame (which I believe is the only time settings() can be null)
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::styleSheetChanged):
- Removing dead code, "root" can never be null here.
- * css/SVGCSSStyleSelector.cpp:
- (WebCore::colorFromSVGColorCSSValue):
- (WebCore::CSSStyleSelector::applySVGProperty):
- Extra returns in the old macros caused dead code. Removing the old macros and use modern
- ones instead. :)
- Extra null checks to value were not needed. Added an ASSERT at the top of the function
- to make it clear that value will never be NULL.
- Added colorFromSVGColorCSSValue to clean up the code a little.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Font fallback cleanup and added ASSERT for GlyphPageTreeNode
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * css/CSSFontSelector.cpp:
- (WebCore::compareFontFaces):
- Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets
- I can't read the code well enough to tell, so I tried to make the code clearer
- and added an ASSERT.
- * platform/graphics/GlyphPageTreeNode.cpp:
- (WebCore::GlyphPageTreeNode::initializePage):
- Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already
- known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
-
-2009-03-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Coverty inspired fixes in Animations/Transforms
- https://bugs.webkit.org/show_bug.cgi?id=24684
-
- * page/animation/AnimationBase.h:
- Fix animate() signatures to match so that the virtual methods actually override one another. :)
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
- Attempt to fix this method, prevAnimation was never set to anything but NULL,
- as far as I can tell the author originally intended to update it at the end
- of the loop, which is what I changed this code to do.
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
- Make method signature match AnimationBase::animate
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
- Make method signature match AnimationBase::animate
- * page/animation/KeyframeAnimation.h:
- * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
- (WebCore::PerspectiveTransformOperation::blend):
- if (blendToIdentity) already returned above.
- * platform/graphics/transforms/RotateTransformOperation.cpp:
- (WebCore::RotateTransformOperation::blend):
- if (blendToIdentity) already returned above.
-
-2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fix compiler warnings regarding assignments in if statements.
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::createFormData):
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::compare):
-
-2009-03-25 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6472150> repro crash in
- RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using
- menus
-
- Test: fast/inline/continuation-positioned-reparenting.html
-
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::splitFlow): When repurposing the existing
- container as the "pre" block, clear its positioned objects list, because
- positioned descendants may end up in a different block after the split.
-
-2009-03-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24784
-
- Length values in transform operations need to take zoom into account.
-
- Test: fast/transforms/transforms-with-zoom.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::createTransformOperations):
-
-2009-03-25 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
- values. Add support for the new values (while preserving the old values for backwards
- compatibility).
-
- Changed some existing test cases to use the new values.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseFillProperty):
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator EFillBox):
- * css/CSSValueKeywords.in:
-
-2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
-
- Reviewed by Dimitri Glazkov.
-
- Fix complex text opacity on the Chromium Windows port.
- https://bugs.webkit.org/show_bug.cgi?id=24757
-
- Test: fast/text/complex-text-opacity.html
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
- (WebCore::Font::drawGlyphs):
- (WebCore::Font::drawComplexText):
-
-2009-03-25 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
- the border-radius, since the assumption is that any desired rounding will be built into the border-image
- itself.
-
- Note that I do not agree with this change, but I am matching the spec.
-
- Added fast/borders/border-image-border-radius.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintNinePieceImage):
-
-2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24750
- [GTK] requests download instead of displaying page
-
- Fix the Content-Type headers we get from soup, so that we set a
- proper media type on the ResourceResponse.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
-
-2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24600
- [GTK] responses with status code >= 400 should not be given special treatment
-
- Do not special case requests that have HTTP responses >=
- 400. Redirects are handled automatically by libsoup, but the rest
- of the responses should be treated like any other.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::):
- (WebCore::gotHeadersCallback):
- (WebCore::gotChunkCallback):
- (WebCore::finishedCallback):
-
-2009-03-25 Darin Adler <darin@apple.com>
-
- Reviewed by John Sullivan.
-
- Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
- they are being used only for selections, not an entire document.
-
- * WebCore.base.exp: Remove exported function that's not used in WebKit.
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member
- function so it can share private things with other member functions. Added some FIXME
- comments to a branch of code I think is dead. Changed boolean argument into a named
- one. Renamed to match other similar functions.
- (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto.
- (WebCore::LegacyWebArchive::createResource): Ditto.
- (WebCore::LegacyWebArchive::create): Merged the create and init functions.
- (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because
- we should never fail to write (we can fail to read).
- (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static
- member function as above.
- (WebCore::LegacyWebArchive::createFromSelection): Ditto.
- (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than
- iterators. Only include the favicon if the first node is the document since we don't
- want to include the favicon when copying and pasting.
-
- * loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private.
- Made the Mac-specific functions be static member functions. Made other helpers be
- static member functions. Removed the nit function.
-
- * loader/archive/cf/LegacyWebArchiveMac.mm:
- (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated
- comment and made this a static member function.
- (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made
- it so we only type cast in one place.
-
-2009-03-25 Darin Adler <darin@apple.com>
-
- Reviewed by David Hyatt.
-
- Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
- https://bugs.webkit.org/show_bug.cgi?id=24740
- rdar://problem/6679873
-
- Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
- https://bugs.webkit.org/show_bug.cgi?id=12104
-
- Test: media/video-display-none-crash.html
-
- The problem here was that RenderSlider was trying to position its thumb in a way that
- requires it to call updateLayout inside rendering code. The right way to position a
- child renderer is to do layout, so I had to write a layout function. And then fix a few
- other small problems shown by the same test case.
-
- * rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage.
- Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
- prefix for public DOM classes, not elements used as implementation details.
- Made SliderThumbElement function members private and got rid of unneeded default
- argument value for shadowParent.
- (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes.
- (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above.
- (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in
- a way that clamps to the range.
- (WebCore::sliderPosition): Added. Computes the slider position: a double.
- (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit
- initialization of m_initialClickPoint.
- (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead
- of calling setCurrentPosition and valueChanged.
- (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb.
- (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle.
- (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code
- setting the position to relative and setting the left and top. We now handle positioning
- in a custom layout function.
- (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout.
- (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value
- in the element if it's out of range. This clamping used to be done as a side effect of
- setPositionFromValue. Also, this has nothing to do with the renderer, so at some point
- it could be moved into HTMLInputElement. Removed call to setPositionFromValue
- and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be
- a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want
- this to be propagated to the parent -- it's not called during layout.
- (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange
- class. Also don't call setCurrentPosition; instead just call setNeedsLayout.
- (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather
- than the style to find the position; that means this needs to be done after layout is done.
- Also removed unneeded runtime checks and replaced them with assertions, after checking
- all callers to see they already guarantee this.
- (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them
- with assertions, after checking all callers to see they already guarantee this.
- (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't
- crash if called early on a brand new RenderSlider.
-
- * rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode.
- Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
- prefix for public DOM classes, not elements used as implementation details. Made the
- mouseEventIsInThumb function non-virtual. Removed the return value and argument from
- setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle
- argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some
- private member functions.
-
-2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fix ambiguous else cases by adding braces to nested if()s with elses.
-
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::continueAfterContentPolicy):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::updateDragAndDrop):
- * rendering/RenderListMarker.cpp:
- (WebCore::toArmenianUnder10000):
- * rendering/TextControlInnerElements.cpp:
- (WebCore::TextControlInnerTextElement::defaultEventHandler):
-
-2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Move variable into proper platform block to quiet warning.
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
-
-2009-03-24 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- Fix for <rdar://problem/6719375> Deal with QTKit loadstate changes when playing streaming movies
-
- * WebCore/html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setNetworkState): Deal with media engine reviving after having
- network state of NETWORK_NO_SOURCE.
-
- * WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::updateStates): Reset m_readyState at each state change since
- some types of movies currently cause QTKit's load state to bounce around. QTMovieLoadStatePlaythroughOK
- corresponds to HaveFutureData, not HaveEnoughData.
-
-2009-03-24 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24707
- <rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
-
- * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- After breaking out of an empty mail blockquote, we still want continue with the deletion
- so actual content will get deleted, and not just the quote style.
-
-2009-03-24 Darin Adler <darin@apple.com>
-
- Reviewed by Brady Eidson.
-
- <rdar://problem/6624662> REGRESSION (r39904): can't save certain web pages as web archive (ones without favicons!)
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Added a null check.
-
-2009-03-24 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24685
-
- The Skia drawLine function takes subpixel values and attempts to draw
- a line with subpixel precision. This is complex and slow for drawing
- scrollbars which use only vertical and horizontal lines.
-
- This changes the Chromium Linux scrollbar code to use drawIRect.
-
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
- (WebCore::drawVertLine):
- (WebCore::drawHorizLine):
- (WebCore::drawBox):
- (WebCore::ScrollbarThemeChromium::paintTrackPiece):
- (WebCore::ScrollbarThemeChromium::paintThumb):
-
-2009-03-24 David Kilzer <ddkilzer@apple.com>
-
- Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly
-
- <https://bugs.webkit.org/show_bug.cgi?id=23310>
-
- Reviewed by Darin Adler.
-
- Test: fast/frames/iframe-no-src-set-location.html
-
- * dom/Document.cpp:
- (WebCore::Document::completeURL): If m_baseURL is empty or is
- about:blank and we have a parent document, use the parent
- document's URL for the base when completing a new URL.
-
-2009-03-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24659
-
- When hit-testing 3d-transformed layers, it doesn't make sense to project the hitTestRect
- into the coordinate space of the layer, and doing so can result in pathalogical quads
- that break hit testing. In that case, simply use the same bounds as used for painting,
- which are the composited bounds for this layer.
-
- Test: transforms/3d/hit-testing/rotated-hit-test.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24436
-
- When compositing is enabled, painting and hit testing end up using different
- clipping roots, because, for painting, every composited layer is a clipping root,
- but for hit testing only layers with transforms are. To fix this, we use
- temporary clip rects for hit testing, if the page is in compositing mode.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::parentClipRects):
- (WebCore::RenderLayer::calculateRects):
- * rendering/RenderLayer.h:
-
-2009-03-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24782
-
- Fix regression with CSS clip rects with non-length values, by reverting to
- the original code, but passing the zoom multiplier through convertToLength().
-
- Also make stylistic change in createTransformOperations(), renaming 'inStyle'
- to 'style.
-
- Tested by existing tests.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::convertToLength):
- (WebCore::CSSStyleSelector::applyProperty):
- (WebCore::CSSStyleSelector::createTransformOperations):
-
-2009-03-24 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents
- to a border-radius.
-
- This patch makes non-self-painting overflow layers and control clips work with border-radius. RenderLayers
- that should be clipped by overflow ancestors with border-radius are still broken.
-
- Added fast/clip/overflow-border-radius-clip.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::pushContentsClip):
-
-2009-03-24 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents.
-
- This first patch makes overflow:hidden properly clip the foreground contents of overflow:hidden replaced elements. Common
- replaced elements now default to overflow:hidden in the UA stylesheet (this is what the spec specifically recommends be
- done).
-
- Added fast/replaced/border-radius-clip.html
-
- * css/html4.css:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::paint):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint):
-
-2009-03-24 Adele Peterson <adele@apple.com>
-
- RS by Mark Rowe.
-
- Only build these Mail quirks checks in on the Mac.
-
- * dom/Document.cpp: (WebCore::disableRangeMutation):
- * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
-
-2009-03-24 Brent Fulgham <bfulgham@webkit.org>
-
- Build fix, no review.
-
- Remove ResourceLoaderCFNet.cpp from build list for Cairo Releas
- and Debug targets.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-03-24 Eric Carlson <eric.carlson@apple.com>
-
- Fix layout tests broken by r41907.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setReadyState): Don't set "was playing" based on the new ready state
-
-2009-03-24 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24689
- Fix Chromium compilation errors.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
- (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
-
-2009-03-24 Yury Semikhatsky <yurys@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24759
- Add missing methods Element.prototype.removeMatchingStyleClasses and
- Node.prototype.enclosingNodeOrSelfWithNodeNameInArray to SourceFrame content
- iframe. These methods are called by Element.prototype.removeStyleClass and
- Node.prototype.enclosingNodeOrSelfWithNodeName.
-
- * inspector/front-end/SourceFrame.js:
- (WebInspector.SourceFrame.prototype._loaded):
-
-2009-03-24 Mark Mentovai <mark@chromium.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=24653
- WebKit should be buildable without prefix header injection.
- Adds missing #includes and forward declarations as needed.
-
- * editing/SmartReplaceCF.cpp:
- * platform/graphics/mac/ColorMac.mm:
- * platform/graphics/mac/FontCacheMac.mm:
- * platform/graphics/mac/FontCustomPlatformData.h:
- * platform/graphics/mac/FontMac.mm:
- * platform/graphics/mac/FontMacATSUI.mm:
- * platform/graphics/mac/FontPlatformData.h:
- * platform/graphics/mac/FontPlatformDataMac.mm:
- * platform/graphics/mac/GraphicsContextMac.mm:
- * platform/graphics/mac/SimpleFontDataMac.mm:
- * platform/mac/FoundationExtras.h:
- * platform/mac/LocalCurrentGraphicsContext.h:
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm:
- * platform/mac/WebCoreTextRenderer.h:
- * platform/mac/WebCoreTextRenderer.mm:
- * platform/mac/WebFontCache.h:
- * platform/mac/WebFontCache.mm:
- * platform/text/PlatformString.h:
- * platform/text/mac/ShapeArabic.c:
- * platform/text/mac/StringMac.mm:
- * rendering/RenderThemeChromiumMac.h:
-
-2009-03-24 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6107874> by capping the nesting depth of
- "block-level" elements generated by the parser
-
- Test: fast/parser/block-nesting-cap.html
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::HTMLParser):
- (WebCore::HTMLParser::insertNode):
- (WebCore::HTMLParser::pushBlock):
- (WebCore::HTMLParser::popOneBlockCommon):
- (WebCore::HTMLParser::freeBlock):
- * html/HTMLParser.h:
-
-2009-03-23 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=24771
-
- DOMTimeStamps are based upon 1970.
-
- * platform/mac/GeolocationServiceMac.mm:
- (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
-
-2009-03-23 Eric Seidel <eric@webkit.org>
-
- Build fix, no review.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::createVisiblePosition): change .container to .isNotNull()
-
-2009-03-23 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Rename Position::container to m_anchorNode and make it private
- https://bugs.webkit.org/show_bug.cgi?id=24760
-
- More code cleanup for Position.
-
- Change all uses of m_container to node()
- Eventually most uses of node() should change to anchorNode() to designate
- that it's the node the Position is anchored to, but not necessarily the
- container of the position (it could be the before/after neighbor).
-
- Remove any code which sets m_container, and change it to use a new
- Position::moveToPosition function which takes a node and offset.
- It never makes sense to change the node and leave the offset.
-
- * dom/Position.h:
- (WebCore::Position::Position):
- (WebCore::Position::clear):
- (WebCore::Position::anchorNode):
- (WebCore::Position::node):
- (WebCore::Position::moveToPosition):
- (WebCore::Position::moveToOffset):
- (WebCore::Position::isNull):
- (WebCore::Position::isNotNull):
- (WebCore::operator==):
- * dom/Range.cpp:
- (WebCore::Range::create):
- (WebCore::Range::compareBoundaryPoints):
- * dom/RangeBoundaryPoint.h:
- (WebCore::RangeBoundaryPoint::container):
- (WebCore::RangeBoundaryPoint::set):
- (WebCore::RangeBoundaryPoint::setOffset):
- (WebCore::RangeBoundaryPoint::setToChild):
- (WebCore::RangeBoundaryPoint::setToStart):
- (WebCore::RangeBoundaryPoint::setToEnd):
-
-2009-03-17 Eric Seidel <eric@webkit.org>
-
- Reviewed by David Hyatt.
-
- document.write() should be able to make a document strict mode
- https://bugs.webkit.org/show_bug.cgi?id=24336
-
- Remove an implicit write of "<html>" on the first document.write call
- this was added as part of a KDE import http://trac.webkit.org/changeset/798
- with no layout test or explanation. I can't think of any reason why
- an implicit <html> write is necessary (or correct), so I'm removing it and
- adding a test for the correct behavior. The parser will add any necessary
- HTMLHTMLElements during the write() anyway.
-
- Our behavior is now tested by fast/dom/Document/document-write-doctype
- and matches IE, FF fails this new test. Mozilla bug filed:
- https://bugzilla.mozilla.org/show_bug.cgi?id=483908
-
- * dom/Document.cpp:
- (WebCore::Document::write):
-
-2009-03-23 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6140966>
- Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * loader/CrossOriginPreflightResultCache.cpp:
- (WebCore::CrossOriginPreflightResultCache::empty):
- * loader/CrossOriginPreflightResultCache.h:
-
-2009-03-23 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 24726: hit testing doesn't work right when the click is on anonymous content
- https://bugs.webkit.org/show_bug.cgi?id=24726
- rdar://problem/6696992
-
- Test: editing/selection/hit-test-anonymous.html
-
- * rendering/RenderBR.cpp:
- (WebCore::RenderBR::positionForPoint): Call createVisiblePosition instead of
- creating a VisiblePosition directly. It will handle finding non-anonymous
- content nearby if node() is 0.
- * rendering/RenderBlock.cpp:
- (WebCore::positionForPointRespectingEditingBoundaries): Ditto.
- (WebCore::positionForPointWithInlineChildren): Ditto.
- (WebCore::RenderBlock::positionForPoint): Ditto.
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::positionForPoint): Ditto.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::positionForPoint): Ditto.
- (WebCore::RenderObject::createVisiblePosition): Added.
- * rendering/RenderObject.h: Added createVisiblePosition.
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::positionForPoint): Call createVisiblePosition.
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::positionForPoint): Ditto.
- * rendering/RenderText.cpp:
- (WebCore::RenderText::positionForPoint): Ditto.
-
-2009-03-23 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler & Dave Hyatt.
-
- Fix for <rdar://problem/6621310> REGRESSION(35185): Apple Travel HTML emails missing some style after Safari 4 upgrade
-
- Leopard Mail doesn't expect <style> to be in the body. This change reverts back to the old behavior of
- moving <style> to <head> for that version of Mail.
-
- * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
-
-2009-03-23 Adele Peterson <adele@apple.com>
-
- Reviewed by Mark Rowe & Dave Hyatt.
-
- Merge some of the individual Mail quirks into two settings that we can check for future quirks.
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::disableRangeMutation):
- (WebCore::Document::nodeChildrenChanged):
- (WebCore::Document::nodeWillBeRemoved):
- (WebCore::Document::textInserted):
- (WebCore::Document::textRemoved):
- (WebCore::Document::textNodesMerged):
- (WebCore::Document::textNodeSplit):
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setNeedsLeopardMailQuirks):
- (WebCore::Settings::setNeedsTigerMailQuirks):
- * page/Settings.h:
- (WebCore::Settings::needsLeopardMailQuirks):
- (WebCore::Settings::needsTigerMailQuirks):
-
-2009-03-23 Ada Chan <adachan@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=24762
- Support text-indent in <option> elements on windows platform.
-
- Reviewed by Adele Peterson.
-
- * css/themeWin.css:
- * platform/PopupMenuStyle.h: We don't honor font specified on <option> elements right now. Make this
- explicit via windows themed default stylesheet.
- (WebCore::PopupMenuStyle::PopupMenuStyle): Also store text-indent and text-direction.
- (WebCore::PopupMenuStyle::textIndent):
- (WebCore::PopupMenuStyle::textDirection):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::paint): Adjust the text's x-coordinate if text-indent is supported for options and
- text-indent is specified with LTR direction.
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::updateOptionsWidth): Take text-indent into account if theme supports text-indent for options.
- (WebCore::RenderMenuList::itemStyle): Use new PopupMenuStyle constructor on windows.
- (WebCore::RenderMenuList::menuStyle): Ditto.
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::menuStyle): Ditto.
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::popupOptionSupportsTextIndent): Added. Default is false since we are only supporting it in windows for now.
- * rendering/RenderThemeWin.h:
- (WebCore::RenderThemeWin::popupOptionSupportsTextIndent): Returns true for windows.
-
-2009-03-23 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24699
- REGRESSION: Java Applets broken
- <rdar://problem/6707494>
-
- Fix loading Java applets without a codeBase. Only pass the base (up to the
- the last path component) of the baseURL to the plug-in.
-
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::createRenderer):
- * platform/KURL.cpp:
- (WebCore::KURL::baseAsString):
- * platform/KURL.h:
-
-2009-03-23 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- * platform/KURL.h: Removed now-incorrect comments.
- None of the parts include the separator characters any more, now that
- query doesn't include the "?", so the comments explaining which do and do
- not are no-longer helpful.
-
-2009-03-23 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24764
-
- Renamed files V8NodeFilter -> V8NodeFilterCondition to reflect
- class names. Also fixed some headers that got mangled in search/replace
- operations.
-
- No change in behavior, so no test.
-
- * bindings/v8/V8NodeFilter.h: Removed.
- * bindings/v8/V8NodeFilterCondition.cpp: Renamed from WebCore/bindings/v8/V8NodeFilter.cpp.
- * bindings/v8/V8NodeFilterCondition.h: Added.
- * bindings/v8/custom/V8ClipboardCustom.cpp:
- * bindings/v8/custom/V8DocumentCustom.cpp:
- * bindings/v8/custom/V8ElementCustom.cpp:
- * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- * bindings/v8/custom/V8NavigatorCustom.cpp:
-
-2009-03-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=24741
-
- Adds a unique across-browser-sessions identifier to FormData, which may
- be used by ResourceHandle as a secondary cache key to enable cached
- form submissions.
-
- At issue: two otherwise identical form submissions may result in
- completely independent responses, which may each be appropriate to
- store and reuse from cache.
-
- * html/HTMLFormElement.cpp: Added call to FormData::setIdentifier so that
- we only enable cached form submissions for those generated by HTML. This
- way we do not bother with POSTs generated by XMLHttpRequest.
- (WebCore::generateFormDataIdentifier):
- (WebCore::HTMLFormElement::createFormData):
- * platform/network/FormData.cpp: Initialize m_identifier to 0, which means
- the unspecified identifier. So by default there is no identifier and
- nothing changes.
- (WebCore::FormData::FormData):
- * platform/network/FormData.h: Added m_identifier with setter and getter.
- (WebCore::FormData::setIdentifier):
- (WebCore::FormData::identifier):
-
-2009-03-23 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=24733
-
- Fix media controller with full-page zoom. Previously, the media controller
- shadow nodes never saw style changes on the RenderMedia, so did not respond
- to zooming at all. Now, we update the style on the shadow renderers
- whenever RenderMedia gets a style change. Also fix the video thumb in
- the theme to be scaled properly.
-
- Test: media/video-controls-zoomed.html
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlShadowRootElement::updateStyle):
- (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
- (WebCore::MediaTextDisplayElement::updateStyle):
- (WebCore::MediaControlInputElement::MediaControlInputElement):
- (WebCore::MediaControlInputElement::updateStyle):
- * rendering/MediaControlElements.h:
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::styleDidChange):
- * rendering/RenderMedia.h:
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustSliderThumbSize):
-
-2009-03-23 Mike Belshe <mike@belshe.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24739
-
- Rework StringImpl::create methods to try to allocate a single buffer
- rather than allocating both the StringImpl class and a separate data
- buffer.
-
- * platform/text/StringImpl.cpp:
- * platform/text/StringImpl.h:
-
-2009-03-23 Darin Adler <darin@apple.com>
-
- Reviewed by Antti Koivisto.
-
- Based on a patch by Nico Weber <nicolasweber@gmx.de>
-
- Bug 24755: LayoutTests/http/tests/misc/url-in-utf16le.html regression
- https://bugs.webkit.org/show_bug.cgi?id=24755
-
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::isUTF7Encoding): Added. Checks if the current encoding
- is UTF7 without loading extended codecs.
- (WebCore::TextEncoding::encodingForFormSubmission): Use isUTF7Encoding() instead
- of comparing with UTF7Encoding(). Eliminate the explicit check of
- noExtendedTextEncodingNameUsed() because that's now handled by the functions
- that this function calls instead.
-
- * platform/text/TextEncoding.h: Added isUTF7Encoding function.
- Also tweaked formatting a bit.
-
-2009-03-20 Peter Kasting <pkasting@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24720
- RenderThemeChromium should draw something for Slider parts instead of
- dropping them on the floor.
-
- * platform/chromium/ChromiumBridge.h:
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
- (WebCore::RenderThemeChromiumWin::paintSliderTrack):
- (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
- (WebCore::RenderThemeChromiumWin::getThemeData):
- * rendering/RenderThemeChromiumWin.h:
- (WebCore::RenderThemeChromiumWin::paintSliderThumb):
-
-2009-03-23 Glen Murphy <glen@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24657
-
- Fix Skia drawing of highly scaled bitmaps; the conversion to
- IntRect produced visible layout test failures in highly scaled
- coordinate systems.
-
- Test: svg/custom/image-small-width-height.svg
-
- * WebCore\platform\graphics\skia\ImageSkia.cpp:
-
-2009-03-23 David Kilzer <ddkilzer@apple.com>
-
- Provide JavaScript exception information after slow script timeout
-
- Reviewed by Oliver Hunt.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate): Changed to report
- exceptions for the Interrupted completion type as well.
-
-2009-03-23 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24736
-
- Fix three mostly-unrelated problems with full-page zoom:
-
- * dom/Document.cpp:
- (WebCore::Document::elementFromPoint):
- Document::elementFromPoint() needs to take full-page zoom into account.
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
- Take full-page zoom into account when computing offsetX/offsetY.
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- Don't use offsetX/offsetY when hit testing list boxes; offsets were broken
- with full-page zoom, and using pageX/pageY is easier because we don't
- have to worry about the event target, and we already have a point in
- absolute coordinates.
-
- Tests: fast/forms/listbox-hit-test-zoomed.html
- fast/forms/search-zoomed.html
- fast/forms/slider-zoomed.html
-
-2009-03-23 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24753
-
- The rect for CSS 'clip' needs to have zooming applied to it.
-
- Test: fast/css/clip-zooming.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
-
-2009-03-23 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adam Roben.
-
- <rdar://problem/6704282>
- https://bugs.webkit.org/show_bug.cgi?id=24719
- QTMovieWinTimer logic inversion
-
- Fix logic inversion in the Win32 timer used by QTMovieWin that caused it to always
- use SetTimer, even when the intervals was below USER_TIMER_MINIMUM. A side effect of
- this was that a movie timer would sometimes be blocked for significant amounts of time
- because WM_TIMER messages are not processed when the thread's message queue has any
- higher priority messages, and WebCore/Win's timer uses PostMessage for low interval
- timers. Also change SetTimer call to use HWND and custom message instead of
- timer function since the timer already has an HWND for processing PostMessage.
-
- Not possible to make a test for this because it is so timing dependant.
-
- * platform/graphics/win/QTMovieWinTimer.cpp:
- (TimerWindowWndProc):
- (setSharedTimerFireDelay):
-
-2009-03-23 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=24588
-
- Update media element implementation to current HTML5 spec
-
- New tests:
- media/media-constants.html
- media/video-seek-no-src-exception.html
- media/video-source-add-src.html
- media/video-src-invalid-remove.html
- media/video-src-plus-source.html
- media/video-timeupdate-during-playback.html
-
- * dom/EventNames.h: Remove obsolute events, add new ones.
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member vars.
- (WebCore::HTMLMediaElement::attributeChanged): Trigger load() only when we don't
- have a source.
- (WebCore::HTMLMediaElement::removedFromDocument): Deal with state name changes.
- (WebCore::HTMLMediaElement::scheduleProgressEvent): New, create a progress event and
- add it to the event queue to be dispatch when the timer fires.
- (WebCore::HTMLMediaElement::scheduleEvent): New, create a generic event and add
- it to the event queue to be dispatch when the timer fires.
- (WebCore::HTMLMediaElement::enqueueEvent): Add an event to the queue and ticke the
- asynch event timer.
- (WebCore::HTMLMediaElement::asyncEventTimerFired): Dispatch all pending events.
- (WebCore::HTMLMediaElement::loadTimerFired): Either trigger the initial load or
- try to load the next <source> url.
- (WebCore::HTMLMediaElement::load): Minor style change.
- (WebCore::HTMLMediaElement::loadInternal): The first part of the spec load algorithm, cleanup
- the current load (if any) and set up state for a new load.
- (WebCore::HTMLMediaElement::selectMediaResource): Deal with no 'src' or <source>, post 'loadstart'
- event, and initiate load from 'src' if present.
- (WebCore::HTMLMediaElement::loadNextSourceChild): Initiate load from next <source> url, or trigger
- noneSupported() if no more to consider.
- (WebCore::HTMLMediaElement::loadResource): Instantiate a new MediaPlayer and ask it to load a url.
- (WebCore::HTMLMediaElement::startProgressEventTimer): Start the repeating progress event timer.
- (WebCore::HTMLMediaElement::noneSupported): Post error event and set up state when no valid
- media url was found.
- (WebCore::HTMLMediaElement::mediaEngineError): Post error event and set up state when no valid
- media engine failed with a decode error or a network error.
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
- (WebCore::HTMLMediaElement::setNetworkState): Updated for new spec network states.
- (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
- (WebCore::HTMLMediaElement::setReadyState): Updated for new spec ready state.
- (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if the network is not active.
- (WebCore::HTMLMediaElement::seek): Return INVALID_STATE_ERR exception if state is too low or
- if player hasn't been set up yet. This is necessary becase load() is async. Clear the flag
- we use to guard against sending 'ended' more than once.
- (WebCore::HTMLMediaElement::duration): Don't bother calling media engine before it has metadata.
- (WebCore::HTMLMediaElement::setDefaultPlaybackRate): Remove exception param, 0 is no longer an
- invalid rate.
- (WebCore::HTMLMediaElement::setPlaybackRate): Remove exception param, 0 is no longer an
- invalid rate. Cache rate being set so we can use it later if media engine isn't ready now.
- (WebCore::HTMLMediaElement::play): Remove exception param, play() before load() now just
- starts loading asynchronously.
- (WebCore::HTMLMediaElement::playInternal): Remove exception param. Fire 'waiting' or 'playing'
- event depending on current state.
- (WebCore::HTMLMediaElement::pause): Remove exception param, pause() before load() now just
- starts loading asynchronously.
- (WebCore::HTMLMediaElement::pauseInternal): Remove exception param.
- (WebCore::HTMLMediaElement::setVolume): dispatchEventAsync -> scheduleEvent
- (WebCore::HTMLMediaElement::setMuted): dispatchEventAsync -> scheduleEvent
- (WebCore::HTMLMediaElement::togglePlayState): Remove exception param.
- (WebCore::HTMLMediaElement::beginScrubbing): pause() doesn't take an exception param.
- (WebCore::HTMLMediaElement::startPlaybackProgressTimer): New, starts timer that fires 4 times per
- second when the movie is playing to timeupdate so we can post 'timeupdate' events.
- (WebCore::HTMLMediaElement::playbackProgressTimerFired): Timer proc.
- (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Bottleneck around scheduling a 'timeupdate'
- event because we both fire them them when the spec says we should and when the media engine
- says that time has jumped, but we don't want to fire more than one at a given movie time. We also
- use this bottleneck to keep track of the last time one was posted so we won't fire too often
- during playback.
- (WebCore::HTMLMediaElement::canPlay): readyState now tracks whether or not we have metadata.
- (WebCore::HTMLMediaElement::havePotentialSourceChild): New, checks to see if there are a <source>
- element with a 'src' attribute that we have not tried to load yet.
- (WebCore::HTMLMediaElement::nextSourceChild): New, returns the url and content type of the next
- <source> element that we haven't tried to load.
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Schedule 'seeked' event when seeking completes.
- Set a flag when we post the 'ended' event, clear it when time changed and we aren't at the end since
- some media engines call this proc more than once when playback reaches the end and stops, but we
- don't want to post 'ended' more than once.
- (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): New, added so media engine can inform
- when the movie duration changes and we can post 'durationchanged' event.
- (WebCore::HTMLMediaElement::mediaPlayerRateChanged): New, added so media engine can inform when
- the rate changed and we can updated our cached rate. This is useful because we only want to know
- post periodic 'timeupdate' events when the movie is actually playing, and because we want to know
- the actual playback rate when it differs from what we tried to set.
- (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): New, added so media engine can inform when
- a movie's intrinsic size changes and we can inform the renderer.
- (WebCore::HTMLMediaElement::potentiallyPlaying): Renamed from activelyPlaying since the spec now
- uses "actively playing" for this concept. Update logic for new state names and un-comment calls
- to stoppedDueToErrors() and pausedForUserInteraction() since the spec says those condiditons
- are part of the answer.
- (WebCore::HTMLMediaElement::endedPlayback): Update logic for new state names.
- (WebCore::HTMLMediaElement::stoppedDueToErrors): New, spec says this logic should be part of
- the determination of "potentially playing".
- (WebCore::HTMLMediaElement::pausedForUserInteraction): New, placeholder for when (if) user
- agent supports this spec concept.
- (WebCore::HTMLMediaElement::updatePlayState): Stop timer used to fire periodic 'timeupdate'
- events when we pauses the movie. Set the media engine rate before calling play() in case it
- wasn't set up when the rate was changed.
- (WebCore::HTMLMediaElement::stopPeriodicTimers): New, stop the progress event and 'timeupate'
- event timers.
- (WebCore::HTMLMediaElement::userCancelledLoad): New, logic pulled out of documentWillBecomeInactive
- and updated for the current spec.
- (WebCore::HTMLMediaElement::documentWillBecomeInactive): Moved some logic to userCancelledLoad.
- (WebCore::HTMLMediaElement::documentDidBecomeActive): Update comments.
- (WebCore::HTMLMediaElement::initialURL): Update for refactoring of code that determines the
- initial url.
- * html/HTMLMediaElement.h: Change ReadyState and NetworkState enums to match names in the spec,
- update for changes in .cpp.
- (WebCore::HTMLMediaElement::):
-
- * html/HTMLMediaElement.idl: Update ready state and network state constants for spec changes.
- defaultPlaybackRate, playbackRate, play(), and pause() no longer raise exceptions.
-
- * html/HTMLSourceElement.cpp:
- (WebCore::HTMLSourceElement::insertedIntoDocument): Update for network state name changes.
-
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::updatePosterImage): Update for ready state name changes.
-
- * html/MediaError.h:
- (WebCore::MediaError::): add MEDIA_ERR_NONE_SUPPORTED.
-
- * html/MediaError.idl: add MEDIA_ERR_NONE_SUPPORTED.
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler): play() and pause() don't take an exception.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::NullMediaPlayerPrivate::readyState): Update for newtork state name changes.
- (WebCore::MediaPlayer::sizeChanged): New, so engine can report intrinsic size changes.
- (WebCore::MediaPlayer::rateChanged): New, so engine can report rate changes.
- (WebCore::MediaPlayer::durationChanged): New, so engine can report duration changes.
- * platform/graphics/MediaPlayer.h: Update NetworkState and ReadyState enum names to match spec
- states.
- (WebCore::MediaPlayerClient::mediaPlayerDurationChanged): New.
- (WebCore::MediaPlayerClient::mediaPlayerRateChanged): New.
- (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): New.
- (WebCore::MediaPlayer::):
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::load): Ditto.
- (WebCore::MediaPlayerPrivate::updateStates): Ditto.
- (WebCore::MediaPlayerPrivate::loadingFailed): Ditto.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Update for network/ready state name changes.
- Remove endPointTimer, it is no longer necessary. Add m_enabledTrackCount and m_duration.
- (WebCore::MediaPlayerPrivate::metaDataAvailable):
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer or m_endTime. Initialize
- m_enabledTrackCount and m_duration. Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
- (WebCore::MediaPlayerPrivate::pause): Ditto.
- (WebCore::MediaPlayerPrivate::currentTime): No more m_endTime.
- (WebCore::MediaPlayerPrivate::seek): Ditto.
- (WebCore::MediaPlayerPrivate::doSeek): Ditto, plus don't call setRate(0) when the rate is
- already zero.
- (WebCore::MediaPlayerPrivate::setEndTime): No more m_endTime.
- (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes. Return
- different errors depending on what causes a failure. Watch for and report duration changes.
- (WebCore::MediaPlayerPrivate::rateChanged): Report rate changes.
- (WebCore::MediaPlayerPrivate::sizeChanged): Report size changes.
- (WebCore::MediaPlayerPrivate::didEnd): No more endpoint timer.
- (WebCore::MediaPlayerPrivate::setVisible): Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): Don't return number of unsupported
- tracks, store in m_enabledTrackCount so we can use it to help determine causes of failure.
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::load): Ditto.
- (WebCore::MediaPlayerPrivate::duration): Ditto.
- (WebCore::MediaPlayerPrivate::updateStates): Ditto.
- (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer. Update for
- network/ready state name changes.
- (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes. No more
- m_endPointTimer.
- (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
- (WebCore::MediaPlayerPrivate::pause): Ditto.
- (WebCore::MediaPlayerPrivate::setEndTime): Ditto.
- (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes.
- (WebCore::MediaPlayerPrivate::didEnd): No more m_endPointTimer.
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Update for network/ready state
- name changes.
- (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
-
-2009-03-22 Kevin Ollivier <kevino@theolliviers.com>
-
- wxGTK build fix. Add missing header.
-
- * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
-
-2009-03-22 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24665
-
- Image-map code in RenderImage could result in RenderImage::nodeAtPoint()
- setting HitTestResult::innerNode(), but returning false, which violates
- hit testing rules. Use a temporary HitTestResult so that we only fill in
- result when we know we've hit.
-
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::nodeAtPoint):
-
-2009-03-22 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=24743
-
- Fix hit testing regression from r41840. We need to pass the temporary
- HitTestResult when testing sublayers, then only copy to 'result' when
- the layer is known to have been hit.
-
- Test: fast/layers/zindex-hit-test.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24733
-
- Fix hit testing on video controls after full page zoom by fixing wider issue
- with event->pageX(), pageY() with zooming. pageX and pageY are "fixed" to be
- invariant under zooming (for JavaScript), so we keep an actual page point around
- in MouseEvent::absoluteLocation() to avoid the need to factor in zooming everywhere.
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::initCoordinates):
- (WebCore::MouseRelatedEvent::computePageLocation):
- * dom/MouseRelatedEvent.h:
- (WebCore::MouseRelatedEvent::absoluteLocation):
- (WebCore::MouseRelatedEvent::setAbsoluteLocation):
- Member var, and getter and setter for absoluteLocation.
- New method, computePageLocation(), to compute the actual page point,
- and call it when creating and initting mouse-related events.
-
- * dom/Node.cpp:
- (WebCore::Node::dispatchMouseEvent):
- (WebCore::Node::dispatchWheelEvent):
- Keep non-adjusted pageX and pageY around, and call setAbsoluteLocation()
- on the event to replace a potentially rounded point.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler):
- Clean up slider handling code.
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- Add FIXME comment for use of offsetX/offsetY.
-
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::handleContextMenuEvent):
- Use absoluteLocation() when hit testing for context menus.
-
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::userResize):
- Use absoluteLocation() when resizing frames.
-
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::forwardEvent):
- Use absoluteLocation() when hit testing media controls.
-
- * rendering/RenderSlider.cpp:
- (WebCore::HTMLSliderThumbElement::defaultEventHandler):
- (WebCore::RenderSlider::mouseEventIsInThumb):
- Use absoluteLocation() when handling slider events.
-
- (WebCore::RenderSlider::forwardEvent):
- Factor some code out of HTMLInputElement::defaultEventHandler().
-
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::forwardEvent):
- Use absoluteLocation() when hit testing search field buttons, which fixees
- bugs in the search field with zooming.
-
-2009-03-21 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24727
- Add V8XMLHttpRequest*.
-
- * bindings/v8/V8XMLHttpRequestUtilities.cpp: Added.
- * bindings/v8/V8XMLHttpRequestUtilities.h: Added.
- * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Added.
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Added.
- * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Added.
-
-2009-03-21 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24725
- Add V8NodeFilter.
-
- * bindings/v8/V8NodeFilter.cpp: Added.
- * bindings/v8/V8NodeFilter.h: Added.
-
-2009-03-21 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Kevin Decker
-
- - remove some redundant #include statements
-
- * bindings/js/JSDOMWindowBase.cpp:
-
-2009-03-20 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix <rdar://problem/6574185> REGRESSION (3.2.2-TOT): hang in text drawing code
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::drawGDIGlyphs): Changed glyph stroking to fill and stroke each
- glyph as a separate path, instead of all glyphs as a single path. This
- matches what CGContextShowGlyphsWithAdvances() does, and has comparable
- performance.
-
-2009-03-20 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser
-
- Build fix for ENABLE(3D_RENDERING)
-
- * rendering/RenderObject.h:
- (WebCore::makeMatrixRenderable):
-
-2009-03-20 Dave Moore <davemoore@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24705
-
- A bug in the V8 bindings is preventing chromium from setting the href on the
- location object...any attempt throws a security error, not just for javascript
- protocol
-
- * page/Location.idl:
-
-2009-03-20 Craig Schlenter <craig.schlenter@gmail.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24608
-
- Include stdio.h needed for printf on gcc 4.4.0
-
- * platform/KURLGoogle.cpp:
-
-2009-03-20 Mike Belshe <mike@belshe.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24577
-
- Don't let comments at the end of an event handler
- break the event handler.
-
- No change in behavior, so no test.
-
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::getWrappedListenerFunction):
-
-2009-03-20 Norbert Leser <norbert.leser@nokia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24535
-
- Fixes missing line terminator character (;) after macro call.
- It is common practice to add the trailing ";" where macros are substituted
- and not where they are defined with #define.
- This change is consistent with other macro declarations across webkit,
- and it also solves compilation failure with symbian compilers.
-
- No change in behavior, so no test.
-
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSImageConstructor.cpp:
- * bindings/js/JSInspectedObjectWrapper.cpp:
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- * bindings/js/JSNamedNodesCollection.cpp:
- * bindings/js/JSNodeFilterCondition.cpp:
- * bindings/js/JSOptionConstructor.cpp:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- * bindings/js/JSRGBColor.cpp:
- * bindings/js/JSWorkerContextBase.cpp:
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2009-03-20 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov and Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24324
-
- Make the minimum timer configurable for different platforms.
-
- * page/DOMTimer.cpp:
- (WebCore::DOMTimer::DOMTimer):
- (WebCore::DOMTimer::fired):
- * page/DOMTimer.h:
- (WebCore::DOMTimer::minTimerInterval):
- (WebCore::DOMTimer::setMinTimerInterval):
-
-2009-03-20 Dean McNamee <deanm@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22834
-
- Make sure to consistently match new/delete and fastMalloc/fastFree.
-
- * css/CSSSelectorList.cpp:
- (WebCore::CSSSelectorList::adoptSelectorVector):
- (WebCore::CSSSelectorList::deleteSelectors):
-
-2009-03-20 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=23739
- <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::percentHeightDescendants): Added this accessor.
- * rendering/RenderBlock.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::layoutRows): Extended the check for
- children that flex to include other descendants with percent height
- which is relative to the cell.
-
-2009-03-20 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24706
- Remove ScriptExecutionContext::encoding() since Workers do not need it.
- WorkerContext::encoding() is simply removed, while Document::encoding()
- made non-virtual and private. Workers use UTF-8 now except when instructed
- otherwise by http header. Also updated test.
-
- * dom/Document.h: Made encoding() non-virtual and private.
- * dom/ScriptExecutionContext.h: removed encoding().
-
- * workers/Worker.cpp:
- (WebCore::Worker::Worker):
- (WebCore::Worker::notifyFinished):
- * workers/WorkerContext.cpp: removed encoding() implementation.
- (WebCore::WorkerContext::WorkerContext):
- (WebCore::WorkerContext::completeURL):
- * workers/WorkerContext.h: removed encoding()
- (WebCore::WorkerContext::create):
- * workers/WorkerContextProxy.h:
- * workers/WorkerImportScriptsClient.cpp:
- (WebCore::WorkerImportScriptsClient::didReceiveData):
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::startWorkerContext):
- * workers/WorkerMessagingProxy.h:
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThreadStartupData::create):
- (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
- (WebCore::WorkerThread::create):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::workerThread):
- * workers/WorkerThread.h:
- In all these, removed storing encoding and 'inheriting' it from the parent.
- Instead, they are all using UTF-8 now.
-
-2009-03-20 Timothy Hatcher <timothy@apple.com>
-
- Change how threading exceptions are checked so they are reported
- by what round they were added. That way WebKit can decided the
- behavior per-round based on linked-on-or-after checks.
-
- <rdar://problem/6626741&6648478&6635474&6674079>
-
- Reviewed by Darin Adler.
-
- * WebCore.base.exp: Export the new symbols.
- * bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
- * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- * platform/ThreadCheck.h:
- * platform/mac/ThreadCheck.mm:
- (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read.
- (WebCore::setDefaultThreadViolationBehavior): Take a round argument.
- (WebCore::reportThreadViolation): Ditto.
- (WebCoreReportThreadViolation): Ditto.
-
-2009-03-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fixed up an out-of-date comment.
-
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customPut):
-
-2009-03-20 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
- (r35318): A press release at pfizer.com does not display correctly
- - and corresponding -
- <rdar://problem/6680073>
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::invalidateContainerPrefWidths):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::markContainingBlocksForLayout):
-
-2009-03-20 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- maxDeepOffset is confusing and should be removed
- https://bugs.webkit.org/show_bug.cgi?id=24586
-
- Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
- Add first/lastDeepEditingPositionForNode Position creation functions
- and deploy them to places we used to call maxDeepOffset.
-
- Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
- Add a new Position::atFirst/atLastEditingPositionForNode() and use these
- to replace a few more callers for maxDeepOffset()
-
- Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)
-
- "Editing positions" are confusing because they have one
- of two behaviors, depending on if the container node is ignored
- by editing (if editingIgnoresContent(node) returns true) or not.
- Positions referring to nodes ignored by editing are
- neighbor-relative (they are before or after the node) where as
- positions reffering to other nodes are container-relative
- (they are between two child nodes of the container, identified
- by the offset() member). I will be fixing this confusion in
- future patches. These renames hopefully make the current behavior clearer.
-
- * dom/Position.cpp:
- (WebCore::Position::previous):
- (WebCore::Position::next):
- (WebCore::Position::atFirstEditingPositionForNode):
- (WebCore::Position::atLastEditingPositionForNode):
- (WebCore::Position::atStartOfTree):
- (WebCore::Position::atEndOfTree):
- (WebCore::Position::previousCharacterPosition):
- (WebCore::Position::nextCharacterPosition):
- (WebCore::Position::upstream):
- (WebCore::Position::isCandidate):
- (WebCore::firstDeepEditingPositionForNode):
- (WebCore::lastDeepEditingPositionForNode):
- * dom/Position.h:
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::operator Position):
- (WebCore::PositionIterator::increment):
- (WebCore::PositionIterator::decrement):
- (WebCore::PositionIterator::atEnd):
- (WebCore::PositionIterator::atEndOfNode):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::isTableCellEmpty):
- (WebCore::DeleteSelectionCommand::removeNode):
- (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- * editing/Editor.cpp:
- (WebCore::Editor::advanceToNextMisspelling):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::previous):
- (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::left):
- (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::right):
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::selectionFromContentsOfNode):
- (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
- * editing/htmlediting.cpp:
- (WebCore::nextVisuallyDistinctCandidate):
- (WebCore::previousVisuallyDistinctCandidate):
- (WebCore::firstEditablePositionAfterPositionInRoot):
- (WebCore::lastEditablePositionBeforePositionInRoot):
- (WebCore::lastOffsetForEditing):
- (WebCore::isFirstPositionAfterTable):
- (WebCore::isLastPositionBeforeTable):
- (WebCore::positionBeforeNode):
- (WebCore::positionAfterNode):
- (WebCore::enclosingEmptyListItem):
- (WebCore::caretMaxOffset):
- * editing/htmlediting.h:
- * editing/visible_units.cpp:
- (WebCore::renderedAsNonInlineTableOrHR):
- (WebCore::startOfParagraph):
- (WebCore::endOfParagraph):
- (WebCore::startOfEditableContent):
- (WebCore::endOfEditableContent):
- * page/AccessibilityObject.cpp:
- (WebCore::endOfStyleRange):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::visiblePositionRange):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::positionForPoint):
-
-2009-03-20 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24689
- Add (upstream) V8 bindings for Workers. Mostly style cleaning.
-
- * bindings/v8/WorkerContextExecutionProxy.cpp: Added.
- * bindings/v8/WorkerContextExecutionProxy.h: Added.
- * bindings/v8/WorkerScriptController.cpp: Added.
- * bindings/v8/WorkerScriptController.h: Added.
- * bindings/v8/V8Index.h: Added. This is just a wrapper for v8_index.h, like V8Proxy.h
- * bindings/v8/V8Proxy.h: Added domObjectMap() function that wraps GetDOMObjectMap().
- * bindings/v8/V8WorkerContextEventListener.cpp:
- (WebCore::V8WorkerContextEventListener::callListenerFunction): TrackEvent() renamed trackEvent()
-
-2009-03-20 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Fix for LayoutTests/fast/canvas/canvas-text-alignment.html
- on chromium/skia. The problem was that the gradient matrix
- for text was being applied twice. Fixed by reverting some of
- https://bugs.webkit.org/show_bug.cgi?id=23957, so that skiaDrawText
- is no longer responsible for measuring the text and scaling up
- the gradient matrix. Instead, the text bounding box is passed
- in from SVGPaintServerGradient. I didn't make this change for CG,
- since it uses a different method (the gradient is drawn using the
- text as a pre-rendered mask).
- https://bugs.webkit.org/show_bug.cgi?id=24687
-
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::skiaDrawText):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::SVGPaintServerGradient::setup):
-
-2009-03-20 Xan Lopez <xlopez@igalia.com>
-
- Rubber-stamped by Holger Freyther.
-
- There seems to be some rounding error in cairo (or in how we use
- cairo) with some fonts, like DejaVu Sans Mono, which makes cairo
- report a height smaller than ascent + descent, which is wrong and
- confuses WebCore's layout system. Workaround this while we figure
- out what's going on.
-
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformInit):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformInit):
-
-2009-03-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24122
- <rdar://problem/6674179>
- REGRESSION: DOM Range extractContents/deleteContents failures seen on Moxiecode tests
-
- Test: fast/dom/Range/deleted-range-endpoints.html
-
- * dom/Range.cpp: (WebCore::Range::processContents): Set the final range in accordance
- to the specification.
-
-2009-03-19 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)
-
- If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
- that object would never be updated.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::updateWidgets):
- Factor the widget updating code out into this method. Return true if the update set is empty.
-
- (WebCore::FrameView::performPostLayoutTasks):
- Loop over the update set multiple times until all widgets have been updated or until we reach the cap.
-
- * page/FrameView.h:
-
-2009-03-18 Timothy Hatcher <timothy@apple.com>
-
- Make the defered data loading timer honor the Page's scheduled runloop pairs.
- Introduces a new RunLoopTimer class that has an API mimicking Timer but
- allows it to be scheduled with one or more SchedulePairs.
-
- <rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers
-
- Reviewed by Darin Adler.
-
- * WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef.
- (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on
- Mac platforms also schedule with the Page's SchedulePairs.
- (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer().
- (WebCore::MainResourceLoader::setDefersLoading): Ditto.
- * loader/MainResourceLoader.h:
- * platform/cf/RunLoopTimerCF.cpp: Added.
- (WebCore::RunLoopTimerBase::~RunLoopTimerBase):
- (WebCore::timerFired):
- (WebCore::RunLoopTimerBase::start):
- (WebCore::RunLoopTimerBase::schedule):
- (WebCore::RunLoopTimerBase::stop):
- (WebCore::RunLoopTimerBase::isActive):
- * platform/RunLoopTimer.h: Added.
- (WebCore::RunLoopTimerBase::RunLoopTimerBase):
- (WebCore::RunLoopTimerBase::startRepeating):
- (WebCore::RunLoopTimerBase::startOneShot):
- (WebCore::RunLoopTimer::RunLoopTimer):
- (WebCore::RunLoopTimer::fired):
-
-2009-03-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24702
- Upstream miscellaneous bindings changes.
-
- * bindings/v8/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
- * bindings/v8/ScriptCallStack.h: Added an extra include.
-
-2009-03-19 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24686
-
- When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
- we need to compare the computed z-offset with the depth-test z-offset before
- deciding that such a RenderLayer was hit. This fixes an issue, tested by the
- 3d-point-mapping-overlapping.html test, where the child of a transformed element
- is found by hit testing, even when some other element with greater Z overlaps
- them both.
-
- Improved the code by adding a utility method, isHitCandidate(), which computes and tests
- z-depth when necessary.
-
- Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html
- transforms/3d/point-mapping/3d-point-mapping-overlapping.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::isHitCandidate):
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-19 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24456
- Split ColorChromium.cpp into Mac & Windows variants.
- Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
- ultimately need to take a different approach. For now, createCGColor()
- is copied from ColorMac.mm.
-
- No observable change in behavior, so no test.
-
- * platform/graphics/chromium/ColorChromium.cpp:
- (WebCore::focusRingColor):
- * platform/graphics/chromium/ColorChromiumMac.mm: Added.
-
-2009-03-19 Pavel Feldman <pfeldman@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24675
- Unforking frontend: add custom InspectorController methods
- implementation.
-
- * bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.
-
-2009-03-19 Jay Campan <jcampan@google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24625
- Adding an accessor to the currently selected index in the PopupMenuChromium.
- This is required for implementing the deletion of an autocomplete entry in Chromium.
-
+ (WebCore::ScrollView::scrollbarUnderPoint):
+ * platform/ScrollView.h:
* platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupContainer::selectedIndex):
- * platform/chromium/PopupMenuChromium.h:
-
-2009-03-19 Evan Stade <estade@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24526
- Improve windows skia text stroking.
-
- Test: LayoutTests/svg/custom/struct-use-09-b.svg
-
- * platform/graphics/skia/SkiaFontWin.cpp: Close the path representing
- each font glyph polygon, rather than only closing the path once per
- letter. This fixes stroking for letters with multiple polygons, such
- as 'A' or 'D'.
- (WebCore::getPathForGlyph):
- (WebCore::skiaDrawText):
-
-2009-03-19 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.
-
- Removed dead code for distinguishing between Widget and PluginView in the Qt port.
-
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget): Removed incorrect isNPAPI check.
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView): Removed m_isNPAPIPlugin variable.
- * plugins/PluginView.h: Removed setter/getter.
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::init): Removed call to setIsNPAPIPlugin.
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::init): Ditto.
-
-2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
- <https://bugs.webkit.org/show_bug.cgi?id=24596>
- <rdar://problem/6686493>
-
- JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
- JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
- set twice, once to the value that is illegal to access, and then to undefined
- This causes an assertion failure in property access caching code.
-
- The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().
-
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customGetOwnPropertySlot):
-
-2009-03-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=24676
- Simple cross-origin requests shouldn't dispatch upload progress events
-
- Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html
-
- * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment
- explaining the somewhat unexpected behavior of this function.
-
- * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
- * xml/XMLHttpRequestUpload.h:
- Report whether there are any event listeners registered.
-
- * xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag.
- (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto.
- (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto.
- (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be
- non-empty for POST requests.
- (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag.
- (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto.
- (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed.
- (WebCore::XMLHttpRequest::networkError): Ditto.
- (WebCore::XMLHttpRequest::abortError): Ditto.
- (WebCore::XMLHttpRequest::didSendData): Ditto.
-
-2009-03-18 Marc-Antoine Ruel <maruel@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24398
- Fix a crash when loading a svg file in Chromium's test_shell and
- then reloading the page.
-
- * history/BackForwardListChromium.cpp:
- (WebCore::BackForwardList::BackForwardList):
- (WebCore::BackForwardList::close):
-
-2009-03-18 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- Fix for <rdar://problem/6685235>
- <video> element poster cannot be set dynamically if not originally set up in HTML
-
- Allocate the media engine immediately so the plug-in proxy is available for
- scripting right away.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::MediaPlayer):
-
-2009-03-18 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
- Popup menu appears at the wrong location on page at http://
- www.signonsandiego.com/
-
- This was a regression from http://trac.webkit.org/changeset/40769,
- which changed the base class of RenderInline to
- RenderBoxModelObject rather than RenderBox.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::offsetParent): offsetParent should return a
- RenderBoxModelObject rather than just a RenderBox, which is more
- restrictive.
-
-2009-03-18 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6504776>
- CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...
-
- Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.
-
- * loader/NetscapePlugInStreamLoader.cpp:
- (WebCore::NetscapePlugInStreamLoader::didCancel):
-
-2009-03-18 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24664
- Upstreaming v8 collection.h
-
- No change in behavior, so no test.
-
- * bindings/v8/V8Collection.h: Added.
-
-2009-03-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Simon Fraser.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
- REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
- <rdar://problem/6589657>
-
- Match the CSSOM spec for getClientRects and getBoundingClientRect by
- returning a 0x0 rect at the correct top/left position for empty inline
- boxes.
-
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::absoluteQuads):
-
-2009-03-18 David Levin <levin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Match the changes done for windows in the bug
- https://bugs.webkit.org/show_bug.cgi?id=24530.
-
- No change in behavior, so no test.
-
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
-
-2009-03-18 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Holger Freyther.
-
- Added support for SVG's stroked texts to Qt.
-
- [Qt] SVGs stroked text support missing
- https://bugs.webkit.org/show_bug.cgi?id=24262
-
- * platform/graphics/qt/FontQt.cpp:
- (WebCore::Font::drawComplexText):
-
-2009-03-18 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix fast/encoding/char-decoding.html with recent ICU.
-
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
- as newer versions of ICU use GB18030 as the canonical name.
-
-2009-03-17 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24662
- Chromium build fixes.
-
- Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
- the invalid implementation of ScriptCallStack.
-
- No change in behavior, so no test.
-
- * bindings/v8/ScriptCallStack.h:
- (WebCore::ScriptCallStack::state):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::drawRect):
-
-2009-03-17 David Carson <dacarson@apple.com>
-
- Reviewed by David Hyatt.
-
- Add anchor elements to the simple style sheet so that applications that
- are using WebKit just for simple text and links will also take advantage
- of the fast path.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::elementCanUseSimpleDefaultStyle):
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6687005> Need support for new move-left/right selectors.
-
- * editing/EditorCommand.cpp:
- (WebCore::executeMoveToLeftEndOfLine): Added.
- (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added.
- (WebCore::executeMoveToRightEndOfLine): Added.
- (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added.
- Added command entries for the functions above.
-
-2009-03-17 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Adele Peterson.
-
- Put the padding inside scrollbars on textareas.
- https://bugs.webkit.org/show_bug.cgi?id=24370
-
- Put the padding inside the scrollbars on textareas. This is done by moving the
- overflow from the shadowNode to the RenderTextControlMultiline. As a result,
- all of the scroll handing methods that RenderTextControl overrides can be moved
- down into RenderTextControlSingleLine since RenderTextControlMultiline can now
- just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
- no longer need a custom layout method since the shadowNode can now just size
- like a regular DIV.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::styleDidChange):
- (WebCore::RenderTextControl::selection):
- (WebCore::RenderTextControl::calcHeight):
- (WebCore::RenderTextControl::hitInnerTextElement):
- * rendering/RenderTextControl.h:
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- * rendering/RenderTextControlMultiLine.h:
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::autoscroll):
- (WebCore::RenderTextControlSingleLine::scrollWidth):
- (WebCore::RenderTextControlSingleLine::scrollHeight):
- (WebCore::RenderTextControlSingleLine::scrollLeft):
- (WebCore::RenderTextControlSingleLine::scrollTop):
- (WebCore::RenderTextControlSingleLine::setScrollLeft):
- (WebCore::RenderTextControlSingleLine::setScrollTop):
- (WebCore::RenderTextControlSingleLine::scroll):
- * rendering/RenderTextControlSingleLine.h:
- * rendering/TextControlInnerElements.cpp:
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::positionForPoint):
- (WebCore::TextControlInnerTextElement::createRenderer):
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- Reviewed by David Hyatt.
-
- Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
- https://bugs.webkit.org/show_bug.cgi?id=24517
-
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
- determining whether to display the delete button involves style and updateRendering
- also updates style (should probably be named updateStyle, in fact). Not needed to fix
- this bug, but would have prevented the crash that led to this bug in the first place.
-
- * editing/EditCommand.cpp:
- (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
- delete button controllers.
- * editing/Editor.cpp:
- (WebCore::Editor::rangeForPoint): Ditto.
-
- * editing/markup.cpp:
- (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
- doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
- This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
- createMarkup function that's called by innerHTML.
- (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
- function. Added a feature where the accumulator will skip a node. Moved arguments
- that don't change during recursion into an object. This function still is a bit
- inefficient, since it creates a new HashMap at every level as it recurses, but for now
- I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
- for consistency and clarity.
- (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
- Instead of calling disable/enable on the delete button controller's container element,
- pass it in to the markup accumulator as a node to skip.
-
-2009-03-17 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24651
- Skia does not always render text fill/stroke pattern/gradient/color correctly
-
- Changes Skia's font rendering to only render gradient/pattern if current
- color space indicates the gradient/pattern should be used.
- This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .
-
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::strokeColorSpace):
- (WebCore::GraphicsContext::fillColorSpace):
- * platform/graphics/GraphicsContext.h:
- (WebCore::):
- * platform/graphics/GraphicsContextPrivate.h:
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::paintSkiaText):
-
-2009-03-17 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
- <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
-
- Test: editing/inserting/6633727.html
-
- This changes does a few things:
- 1) Renames pos to insertionPosition.
- 2) Eliminates "startNode". It doesn't work well to consider the node separately from the insertionPosition.
- The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
- 3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
- representation of the insertionPosition, so all ancestor nodes are correctly included.
-
- * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
-
-2009-03-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Kevin Ollivier.
-
- https://bugs.webkit.org/show_bug.cgi?id=24115
- Introduce platform independent stubs for plugins.
-
- * plugins/PluginDataNone.cpp: Copied from WebCore/plugins/wx/PluginDataWx.cpp.
- * plugins/PluginPackageNone.cpp: Copied from WebCore/plugins/wx/PluginPackageWx.cpp.
- * plugins/PluginViewNone.cpp: Copied from WebCore/plugins/wx/PluginViewWx.cpp.
- * plugins/wx/PluginDataWx.cpp: Removed.
- * plugins/wx/PluginPackageWx.cpp: Removed.
- * plugins/wx/PluginViewWx.cpp: Removed.
- * webcore-wx.bkl:
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- Earlier version reviewed by Adele Peterson.
-
- Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
- or push an <input type=button> or <button> causes the page to scroll down.
-
- Would be best to add a regression test for Windows eventually; tested that this has
- no effect on the Mac OS X platform.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting.
- Use the code that calls the base class's defaultEventHandler early only in the cases
- where it's needed: keydown and keypress events in text fields. In other cases, do the
- more typical thing and call the default handler only at the end of the function.
- This function already had code to make sure the keypress event for space never gets
- through, but it was running too late since the scrolling code was moved into the
- base class default event handler.
+ (WebCore::PopupListBox::handleMouseDownEvent):
+ (WebCore::PopupListBox::handleMouseMoveEvent):
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-2009-03-17 Simon Fraser <simon.fraser@apple.com>
- Reviewed by Dave Hyatt
+2009-06-26 Simon Fraser <simon.fraser@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=24632
+ Reviewed by Dan Bernstein.
- Fix repaint issues when composited layers come and go (only applies
- when ACCELERATED_COMPOSITING is turned on).
+ <rdar://problem/7011924> Opacity transitions should not trigger hardware compositing mode
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::mustOverlayCompositedLayers):
- (WebCore::RenderLayer::setMustOverlayCompositedLayers):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::RenderLayerBacking):
- * rendering/RenderLayerBacking.h:
+ Don't go into compositing mode just for opacity transitions, but they will be
+ hardware acclerated if we're already compositing.
- Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
- to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
- when setting this flag.
-
* rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- When a RenderLayer flips into or out of compositing mode, compute a repaint
- rect relative to the containerForRepaint, and repaint it.
-
- (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().
-
- (WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
* rendering/RenderLayerCompositor.h:
-
- Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
- and make it a class static method to match requiresCompositingForAnimation(). Both
- now take RenderObjects, rathern than RenderLayers.
-
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::hasTransformRelatedProperty):
- Minor tidyup using convenience methods added in an earlier commit.
-2009-03-17 Simon Fraser <simon.fraser@apple.com>
+2009-06-26 Simon Fraser <simon.fraser@apple.com>
- Reviewed by Darin Adler
+ Rubber-stamped by Dave Levin
- https://bugs.webkit.org/show_bug.cgi?id=24396
-
- * config.h:
- Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some
- comments to make the #ifdefs more readable.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::computedTransform):
- Add a comment to mention that we don't flatten the matrix.
-
- * css/MediaQueryEvaluator.cpp:
- (WebCore::transform_3dMediaFeatureEval):
- Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering
- is supported.
-
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::GraphicsLayerCA::animateTransform):
- No need for the #ifdef here. If we don't support 3d, we will have already flattened
- the matrix.
-
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::makeAffine):
- * platform/graphics/transforms/TransformationMatrix.h:
- New method to convert the matrix to an affine matrix by throwing a way the non-affine
- parts.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::currentTransform):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateLayerTransform):
- If 3d rendering is not supported, convert the matrix to an affine matrix
- which can be rendered, and used for hit testing.
+ Rename ioCompState to compositingState to better match WebCore coding style.
* rendering/RenderLayerCompositor.cpp:
- Change the name of the exported symbol that webkitdirs.pm uses to know if
- 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::transformFromContainer):
- Only take perspective into account if 3d rendering is supported.
-
- * rendering/RenderObject.h:
- (WebCore::makeMatrixRenderable):
- Utility method that flattens a matrix if 3d rendering is not supported.
-
-2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Fix typo after mouse wheel changes.
-
- * platform/wx/MouseWheelEventWx.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- Fix crash seen right away when running run-webkit-tests.
-
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring.
- Also tweaked formatting a bit.
-
-2009-03-17 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
- it doesn't need to zero it out before calling.
-
- * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.
-
-2009-03-17 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adam Roben.
-
- - WebCore part of adding a mechanism for controlling the caching of
- responses through WebFrameLoaderClient
-
- Mac already has such a mechanism, and this adds one for CFNetwork ports.
-
- * WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h
- and ResourceLoaderCFNet.cpp.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an
- implementation that always returns true.
-
- * loader/FrameLoaderClient.h: Declared shouldCacheResponse().
-
- * loader/ResourceLoader.h: Ditto.
-
- * loader/cf/ResourceLoaderCFNet.cpp: Added.
- (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to
- FrameLoaderClient::shouldCacheResponse().
-
- * platform/network/ResourceHandleClient.h:
- (WebCore::ResourceHandleClient::shouldCacheResponse): Added an
- implementation that always returns true.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::willCacheResponse): Added a call to
- ResourceHandleClient::shouldCacheResponse(). If the client returns
- false, return 0, which will prevent CFNetwork from caching the response.
-
-2009-03-17 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=13287
- Cannot change SELECT to a dynamically created option
-
- Tests: fast/forms/add-and-remove-option.html
- fast/forms/add-remove-option-modification-event.html
- fast/forms/add-selected-option.html
- fast/forms/select-cache-desynchronization.html
-
- * dom/ContainerNode.cpp:
- (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when
- dispatching DOMSubtreeModified again, but the version should be incremented for event
- listeners to have an up to date view of the DOM.
- (WebCore::dispatchChildRemovalEvents): Ditto.
-
- * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree):
- Make sure that the select element knows about its new selected option.
-
- * html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(),
- because DOM also needs to be updated for forms that are not in document yet. Similar
- problems exist for node removing, but removedFromTree() is called at a wrong time, so
- those problems cannot be fixed without deeper refactoring.
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it
- doesn't make sense to keep the anchor after programmatically changing the selection, and
- keeping it was causing a failure in fast/forms/listbox-selection.html.
-
- * html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called
- base class versions.
-
-2009-03-17 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes
-
- Reviewed by Darin Adler.
-
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.
-
-2009-03-16 David Hyatt <hyatt@apple.com>
-
- <rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/
-
- Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
- layers that don't paint themselves. This is done by adding a new enclosingSelfPaintingLayer method
- so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
- themselves.
-
- Reviewed by Darin Adler.
-
- Added fast/block/float/overlapping-floats-with-overflow-hidden.html
-
- * WebCore.base.exp:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::addOverhangingFloats):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::enclosingSelfPaintingLayer):
- * rendering/RenderObject.h:
-
-2009-03-17 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24592
- [GTK] Crash in FcPatternHash
-
- Style fixes.
-
- * platform/graphics/gtk/FontPlatformDataGtk.cpp:
- (WebCore::FontPlatformData::operator=):
- * platform/graphics/gtk/FontPlatformDataPango.cpp:
-
-2009-03-17 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24592
- [GTK] Crash in FcPatternHash
-
- Sanitize memory management in pango fonts.
-
- Release memory allocated by FontPlatformDataPango in its own
- destructor instead of doing it from other classes, and add copy
- constructor and '=' operator to be able to track referenced
- objects properly.
-
- * platform/graphics/gtk/FontPlatformDataPango.cpp:
- (WebCore::FontPlatformData::~FontPlatformData):
- (WebCore::FontPlatformData::operator=):
- (WebCore::FontPlatformData::FontPlatformData):
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
-
-2009-03-17 Darin Adler <darin@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
- seen with inspector, which uses adoptNode
- https://bugs.webkit.org/show_bug.cgi?id=24624
- rdar://problem/6422850
-
- Test: fast/dom/HTMLImageElement/image-load-cross-document.html
-
- * dom/Document.cpp:
- (WebCore::Document::Document): Removed m_imageLoadEventTimer.
- (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and
- m_imageLoadEventDispatchingList.
- (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents
- instead of dispatchImageLoadEventsNow.
-
- * dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon,
- dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList,
- m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.
-
- * loader/ImageLoader.cpp:
- (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender
- object used privately as the target of the load event timer.
- (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent
- rather than Document::removeImage.
- (WebCore::ImageLoader::setImage): Use m_element directly, not element().
- (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable
- document instead of doc.
- (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon
- rather than Document::dispatchImageLoadEventSoon.
- (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic
- about when load events can be dispatched so that dispatchLoadEvent only has to
- have the specific part for each derived class. This includes a check that the
- document is attached, which used to be handled by having documents empty out the
- image load event vectors in the detach function.
- (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate
- function on the ImageLoadEventSender, which avoids the need to have that class be
- public in the ImageLoader header.
- (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that
- was previously in the Document constructor.
- (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that
- was previously in Document::dispatchImageLoadEventSoon.
- (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was
- previously in Document::removeImage.
- (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code
- that was previously in Document::dispatchImageLoadEventsNow.
- (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.
-
- * loader/ImageLoader.h: Improved comments. Made the virtual functions private
- or protected rather than public. Added static dispatchPendingLoadEvents function
- for use by Document and private dispatchPendingLoadEvent function for use by
- ImageLoadEventSender. Made setLoadingImage private and eliminated
- setHaveFiredLoadEvent since that can all be done inside the class without any
- member functions.
-
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a
- load event already fired and whether image() is 0. These are now both base class
- responsibilities.
- * svg/SVGImageLoader.cpp:
- (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
- * wml/WMLImageLoader.cpp:
- (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.
-
-2009-03-17 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24623
- Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
- dependencies.
-
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
- * bindings/js/ScriptFunctionCall.h:
- * bindings/js/ScriptObjectQuarantine.cpp:
- (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
- * bindings/js/ScriptObjectQuarantine.h:
- * bindings/js/ScriptValue.cpp:
- (WebCore::ScriptValue::isEqual): Added.
- * bindings/js/ScriptValue.h:
- * inspector/ConsoleMessage.cpp:
- (WebCore::ConsoleMessage::ConsoleMessage):
- (WebCore::ConsoleMessage::addToConsole): Added.
- (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
- * inspector/ConsoleMessage.h:
- (WebCore::ConsoleMessage::incrementCount): Added.
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole.
- (WebCore::InspectorController::populateScriptObjects): Ditto.
- * inspector/InspectorController.h:
-
-2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Mark Rowe.
-
- Get BUILDING_ON_* defines from Platform.h.
-
- https://bugs.webkit.org/show_bug.cgi?id=24630
-
- * WebCorePrefix.h:
-
-2009-03-16 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24592
- [GTK] Crash in FcPatternHash
-
- Sanitize memory management in gtk fonts.
-
- Release memory allocated by FontPlatformDataGtk in its own
- destructor instead of doing it from other classes, and add copy
- constructor and '=' operator to be able to track referenced
- objects properly.
-
- * platform/graphics/gtk/FontPlatformData.h:
- * platform/graphics/gtk/FontPlatformDataGtk.cpp:
- (WebCore::FontPlatformData::operator=):
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::~FontPlatformData):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformDestroy):
-
-2009-03-17 Ariya Hidayat <ariya.hidayat@nokia.com>
-
- Build fix for Qt < 4.5.
-
- As reported by Yael Aharon <yael.aharon@nokia.com>
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::drawLine):
-
-2009-03-17 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=24614
- Access control checks are different in cached and uncached cases
-
- Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html
-
- * loader/CrossOriginAccessControl.cpp:
- (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method
- check for use in both cached and uncached cases. In cached case, an old definition that
- omitted HEAD was still used.
- (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an
- allowed value. This is needed in all call sites. Also changed to compare MIME type, not
- content type.
- (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.
-
- * loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.
-
- * loader/CrossOriginPreflightResultCache.cpp:
- (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
- (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
- Use the new checks for simple method and header.
-
-2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=24638
- [GTK] HTML5 media tags do not work
-
- Add a repaint-requested signal to the video sink, and use it to
- call MediaPlayerPrivate::repaint, so that the video actually
- plays.
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::mediaPlayerPrivateRepaintCallback):
- (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- * platform/graphics/gtk/VideoSinkGStreamer.cpp:
- (webkit_video_sink_idle_func):
- (webkit_video_sink_render):
- (webkit_video_sink_class_init):
-
-2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24638
- [GTK] HTML5 media tags do not work
-
- Work-around the fact that gst_element_query_duration returns true even
- though it is unable to figure out the duration when in stream (push)
- mode.
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::duration):
-
-2009-03-16 Darin Adler <darin@apple.com>
-
- Reviewed by Kevin Decker.
-
- <rdar://problem/6642742> Top Sites malfunction when switching text zoom mode
-
- * page/Frame.cpp:
- (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is
- currently showing a non-HTML view.
-
-2009-03-16 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 24629: moving forward or backward a paragraph fails at edge of document
- https://bugs.webkit.org/show_bug.cgi?id=24629
- rdar://problem/6544413
-
- Test: editing/selection/move-paragraph-document-edges.html
-
- * editing/visible_units.cpp:
- (WebCore::previousParagraphPosition): Use the last result from
- previousLinePosition rather than going all the way back to what was originally
- passed in when we hit exception cases like null or not moving. This correctly
- inherits the behavior of previousLinePosition when we are in a paragraph at the
- edge of a document.
- (WebCore::nextParagraphPosition): Ditto.
-
-2009-03-16 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
- https://bugs.webkit.org/show_bug.cgi?id=24619
-
- * rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
- * rendering/RenderView.h: Ditto.
-
-2009-03-16 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24368
- DOM scroll events should be based off the actual number of wheel
- ticks, not off the number of lines scrolled. This matches IE.
-
- * dom/Node.cpp:
- (WebCore::Node::dispatchWheelEvent):
- * dom/WheelEvent.cpp:
- (WebCore::WheelEvent::WheelEvent):
- * dom/WheelEvent.h:
- (WebCore::WheelEvent::create):
- * platform/PlatformWheelEvent.h:
- (WebCore::PlatformWheelEvent::wheelTicksX):
- (WebCore::PlatformWheelEvent::wheelTicksY):
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/mac/WheelEventMac.mm:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/qt/WheelEventQt.cpp:
- * platform/win/WheelEventWin.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/wx/MouseWheelEventWx.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-16 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Clean up a few issues in the Animation code:
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- Whitespace
-
- (WebCore::AnimationBase::willNeedService):
- Don't round to float, use std::max
-
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::startTimeResponse):
- Fix erroneously copied line to null out m_lastResponseWaiter.
-
-2009-03-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- https://bugs.webkit.org/show_bug.cgi?id=13632
-
- Overflow scrolling needs to account for the bottom/right padding on the object itself as well
- as for bottom/right margins on children.
-
- Existing tests cover this.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
-
-2009-03-16 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix for <rdar://problem/6320555>
- Add an upper limit for setting HTMLSelectElement.length.
-
- Test: fast/forms/select-max-length.html
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setOption):
- (WebCore::HTMLSelectElement::setLength):
-
-2009-03-16 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- <rdar://problem/6686721> Media document crash in 64-bit WebKit
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when
- rendering inline with old versions of QuickTime, so don't look for it when we are in a
- media document.
-
-2009-03-16 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24590
- Refactor InspectorDOMStorageResource to use ScriptFunctionCall.
-
- * bindings/js/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
- * bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
- * bindings/js/ScriptObjectQuarantine.cpp:
- (WebCore::getQuarantinedScriptObject): Added Storage helper.
- * bindings/js/ScriptObjectQuarantine.h: Ditto.
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::populateScriptObjects): Changed to use bind method.
- (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method.
- (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
- * inspector/InspectorController.h: Removed add/remove methods for DOM storage.
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
- (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added.
- (WebCore::InspectorDOMStorageResource::bind): Added.
- (WebCore::InspectorDOMStorageResource::unbind): Added.
- * inspector/InspectorDOMStorageResource.h:
-
-2009-03-16 Mike Belshe <mike@belse.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24580
- Fix query() to match KURL behavior, this time with the code that
- compiles.
-
- * platform/KURLGoogle.cpp:
- (WebCore::KURL::query): Fix copy/paste mistake.
-
-2009-03-16 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21752
- REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it
-
- Test: fast/dom/Window/window-early-properties-xhr.html
-
- For some transitions, the Window object is not replaced, but Document is. When this happened,
- window.document property was updated, but references to Document kept in cached constructors
- were not.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- (WebCore::JSAudioConstructor::document):
- (WebCore::JSAudioConstructor::mark):
- * bindings/js/JSAudioConstructor.h:
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- (WebCore::JSImageConstructor::document):
- (WebCore::JSImageConstructor::mark):
- * bindings/js/JSImageConstructor.h:
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
- (WebCore::JSMessageChannelConstructor::mark):
- * bindings/js/JSMessageChannelConstructor.h:
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- (WebCore::JSOptionConstructor::document):
- (WebCore::JSOptionConstructor::mark):
- * bindings/js/JSOptionConstructor.h:
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
- (WebCore::JSXMLHttpRequestConstructor::mark):
- * bindings/js/JSXMLHttpRequestConstructor.h:
- Changed cached constructors to keep a reference to Window, not Document.
-
-2009-03-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24549
- Impose a limit on Access-Control-Max-Age value
-
- * loader/CrossOriginPreflightResultCache.cpp:
- (WebCore::CrossOriginPreflightResultCacheItem::parse):
-
-2009-03-15 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- <rdar://problem/6668875> Normalize Geolocation results
-
- * platform/mac/GeolocationServiceMac.mm:
- (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
-
-2009-03-15 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- Update ::toString format as suggested by Darin Adler.
-
- * page/Geoposition.cpp:
- (WebCore::Geoposition::toString):
-
-2009-03-15 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
-
- Reviewed by Darin Adler.
-
- Yet another case where we would trigger extended encoding loading needlessly.
-
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::encodingForFormSubmission):
-
-2009-03-15 Simon Fraser <simon.fraser@apple.com>
-
- Build fix: no review.
-
- * rendering/style/ContentData.h:
-
-2009-03-15 David Kilzer <ddkilzer@apple.com>
-
- Bug 24542: Improve ContentData encapsulation
-
- <https://bugs.webkit.org/show_bug.cgi?id=24542>
-
- Reviewed by Simon Fraser.
-
- No tests since there is no change in behavior.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::createObject): Used getter methods
- instead of data members on ContentData class. Used isImage()
- convenience method.
- * rendering/RenderObjectChildList.cpp:
- (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
-
- * rendering/style/ContentData.cpp:
- (WebCore::ContentData::clear): Extracted code into
- deleteContent() method.
- (WebCore::ContentData::dataEquivalent): Added. Extracted code
- from StyleRareNonInheritedData::contentDataEquivalent().
- (WebCore::ContentData::deleteContent): Added. Used by setter
- methods.
- * rendering/style/ContentData.h: Made m_type, m_content and
- m_next private.
- (WebCore::ContentData::isCounter): Added.
- (WebCore::ContentData::isImage): Added.
- (WebCore::ContentData::isNone): Added.
- (WebCore::ContentData::isText): Added.
- (WebCore::ContentData::type): Added.
- (WebCore::ContentData::dataEquivalent): Added.
- (WebCore::ContentData::image): Added.
- (WebCore::ContentData::setImage): Added.
- (WebCore::ContentData::text): Added.
- (WebCore::ContentData::setText): Added.
- (WebCore::ContentData::counter): Added.
- (WebCore::ContentData::setCounter): Added.
- (WebCore::ContentData::next): Added.
- (WebCore::ContentData::setNext): Added.
-
- * rendering/style/CounterContent.h:
- (WebCore::operator!=): Removed.
- (WebCore::operator==): Renamed operator!=() and reversed its
- logic after extracting code from
- StyleRareNonInheritedData::contentDataEquivalent() to create
- ContentData::dataEquivalent().
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::setContent): Used new getters and setters
- on ContentData class. Changed first argument from a StringImpl*
- to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::setContent): Updated declaration.
- * rendering/style/StyleRareNonInheritedData.cpp:
- (WebCore::StyleRareNonInheritedData::contentDataEquivalent):
- Extracted most logic in while() loop into
- ContentData::dataEquivalent().
-
-2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=24602
- [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
-
- Reintroduce the URI into the soup message after having set it in
- the KURL, on redirects, to make sure it is properly encoded. This
- fixes bad request problems when servers give bad URIs on their
- response's Location header.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::restartedCallback):
-
-2009-03-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19737
- No cursor and paste not enabled right clicking text field/area
-
- Test: fast/events/right-click-focus.html
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEventSingleClick):
- (WebCore::EventHandler::handleMousePressEvent):
- Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
-
-2009-03-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23949
- HTMLSelectElement is in inconsistent state when handling mutation events
-
- Test: fast/forms/mutation-event-recalc.html
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertBefore):
- (WebCore::ContainerNode::appendChild):
- Call childrenChanged() before dispatching modification events, not after.
-
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::insertBefore):
- (WebCore::HTMLOptGroupElement::replaceChild):
- (WebCore::HTMLOptGroupElement::removeChild):
- (WebCore::HTMLOptGroupElement::appendChild):
- (WebCore::HTMLOptGroupElement::removeChildren):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::add):
- (WebCore::HTMLSelectElement::remove):
- (WebCore::HTMLSelectElement::insertBefore):
- (WebCore::HTMLSelectElement::replaceChild):
- (WebCore::HTMLSelectElement::removeChild):
- (WebCore::HTMLSelectElement::appendChild):
- (WebCore::HTMLSelectElement::removeChildren):
- Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
- were already dispatched.
-
-2009-03-14 Greg Bolsinga <bolsinga@apple.com>
-
- <rdar://problem/6683465>
-
- Geolocation has to be able to handle NULL Frames.
-
- Reviewed by Mark Rowe
-
-2009-03-14 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- Geoposition::toString was missing the Coordinates after the update.
-
- * page/Geoposition.cpp:
- (WebCore::Geoposition::toString):
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
-2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
+2009-06-26 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- [Gtk] Build fix - pass a Coordinate to Geoposition::create
- https://bugs.webkit.org/show_bug.cgi?id=24603
-
- Gtk build fix per r41650
- https://bugs.webkit.org/show_bug.cgi?id=24506
- Geolocation in Safari differs from the spec, no Coordinates attribute on Position
-
- Pass a Coordinate to Geoposition::create.
-
- * platform/gtk/GeolocationServiceGtk.cpp:
- (WebCore::GeolocationServiceGtk::updatePosition):
-
-2009-03-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24545
- Make cross-site XHR simple request definition match current spec draft
-
- Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html
- http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
-
- * loader/CrossOriginAccessControl.cpp:
- (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language.
- (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those
- that could be sent via form submission.
-
-2009-03-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=15172
- object fallback - empty string for first argument of setAttributeNS does not work like null
-
- https://bugs.webkit.org/show_bug.cgi?id=24548
- createElementNS("", name) should create an element in null namespace
-
- Tests: fast/dom/createElementNS-empty-namespace.html
- fast/dom/setAttributeNS-empty-namespace.html
-
- * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
- Convert empty namespaces to null.
-
-2009-03-13 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- Take advantage of the ability of recent versions of Xcode to easily switch the active
- architecture.
-
- * Configurations/DebugRelease.xcconfig:
-
-2009-03-13 John Abd-El-Malek <jam@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24593
- Added requestorID so we can track the request to its WebView without using frame (which was removed).
-
- * platform/network/chromium/ResourceRequest.h:
- (WebCore::ResourceRequest::ResourceRequest):
- (WebCore::ResourceRequest::requestorID):
- (WebCore::ResourceRequest::setRequestorID):
- (WebCore::ResourceRequest::setTargetType):
- (WebCore::ResourceRequest::policyURL):
- (WebCore::ResourceRequest::setPolicyURL):
- (WebCore::ResourceRequest::requestorPid):
- (WebCore::ResourceRequest::setRequestorPid):
-
-2009-03-13 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24561
- Add custom V8 bindings for HTMLElementCanvas, Location.
-
- * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
- * bindings/v8/custom/V8LocationCustom.cpp: Added.
-
-2009-03-13 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24584
-
- Fix transparent text rendering on Chromium. FontChromiumWin
- was calling beginTransparencyLayer()/endTransparencyLayer(), with
- a TransparencyWin inside to do GDI ClearType rendering over an
- opaque background. TransparencyWin does its special sauce
- in the destructor, but it was being called too late to be used
- correctly in the layer. Put the special sauce into a new function,
- composite(), and call that explicitly instead.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
- * platform/graphics/chromium/TransparencyWin.cpp:
- (WebCore::TransparencyWin::~TransparencyWin):
- (WebCore::TransparencyWin::composite):
- (WebCore::TransparencyWin::init):
- * platform/graphics/chromium/TransparencyWin.h:
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::):
-
-2009-03-13 Mike Belshe <mike@belshe.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24562
- Add custom implementation for getCSSCanvasContext to V8 bindings.
-
- * bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
-
-2009-03-13 Mike Belshe <mike@belse.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24580
- Fix query() to match KURL behavior.
-
- * platform/KURLGoogle.cpp:
- (WebCore::KURL::query): remove extra logic around question mark.
-
-2009-03-13 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
- https://bugs.webkit.org/show_bug.cgi?id=24474
-
- Test: platform/mac-snowleopard/accessibility/table-multi-bodies.html
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::cellForColumnAndRow):
-
-2009-03-13 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24589
- Upstream changes to V8 event listeners (Chromium r11133) in order to
- fix worker functionality break in Chromium.
-
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- (WebCore::V8AbstractEventListener::handleEvent):
- * bindings/v8/V8AbstractEventListener.h:
- * bindings/v8/V8WorkerContextEventListener.cpp:
- (WebCore::V8WorkerContextEventListener::handleEvent):
-
-2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24524
- Introduce ScriptObject and ScriptFunctionCall abstractions.
-
- * GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
- * WebCore.pro: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
- * bindings/js/ScriptFunctionCall.cpp: Added.
- * bindings/js/ScriptFunctionCall.h: Added.
- * bindings/js/ScriptObject.cpp: Added.
- * bindings/js/ScriptObject.h: Added.
- * bindings/js/ScriptObjectQuarantine.cpp: Added.
- * bindings/js/ScriptObjectQuarantine.h: Added.
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind.
- (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind.
- (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
- * inspector/InspectorController.h: Removed addScriptDatabaseResource and
- removeScriptDatabaseResource declarations.
- * inspector/InspectorDatabaseResource.cpp:
- (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
- (WebCore::InspectorDatabaseResource::bind): Added.
- (WebCore::InspectorDatabaseResource::unbind): Added.
- * inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
-
-2009-03-13 Peter Kasting <pkasting@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24467
- Make Skia drawRect() and stroke behavior match CG.
-
- This makes drawRect() ignore the stroke width (like CG does), and
- adds a warning comment about that to the appropriate header.
-
- It also eliminates some hacky code in Skia's stroke preparation,
- which tried to adjust odd-width strokes to fall on pixel boundaries.
- Not only did this not match CG, it wouldn't necessarily work right,
- because there could be other transforms (e.g. full-page zoom) that
- would affect the stroke before it reached the device pixel level.
-
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::drawRect):
- (WebCore::GraphicsContext::fillRect):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::drawRect):
- (PlatformContextSkia::setupPaintForStroking):
-
-2009-03-13 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24583
- Need to change scope of constructor and destructor of V8ObjectEventListener from private
- to protected so that they could be used in its derived class V8WorkerContextEventListener.
-
- * bindings/v8/V8ObjectEventListener.h:
-
-2009-03-13 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24579
- Many V8*Event* files are misplaced.
-
- This code is infrastructure for supporting the bindings and thus should
- be in the bindings/v8 directory.
-
- * bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
- * bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
- * bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
- * bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
- * bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
- * bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
- * bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
- * bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
-
-2009-03-13 Adele Peterson <adele@apple.com>
-
- Reviewed by Justin Garcia.
-
- Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content
-
- Test: editing/pasteboard/5089327.html
-
- Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::handleStyleSpansBeforeInsertion):
- (WebCore::ReplaceSelectionCommand::handleStyleSpans):
-
-2009-03-13 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Simon Fraser.
-
- Update Geolocation perimission dialogs to be asynchronous.
- https://bugs.webkit.org/show_bug.cgi?id=24505
-
- Geolocation now requests permission from the Chrome asynchronously.
- The Chrome is passed the Geolocation object, and the Chrome sets the permission
- on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
- of SecurityOrigins with geolocation permission. This is so that the GeolocationService
- can inform the Chrome of its request, and the Chrome is also free to implement its
- own policy.
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * page/Chrome.cpp:
- (WebCore::Chrome::requestGeolocationPermissionForFrame):
- * page/Chrome.h:
- * page/ChromeClient.h:
- (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
- * page/Geolocation.cpp:
- (WebCore::Geolocation::Geolocation):
- (WebCore::Geolocation::getCurrentPosition):
- (WebCore::Geolocation::watchPosition):
- (WebCore::Geolocation::setIsAllowed):
- (WebCore::Geolocation::displayChallengeIfNecessary):
- (WebCore::Geolocation::geolocationServicePositionChanged):
- * page/Geolocation.h:
- (WebCore::Geolocation::isAllowed):
- (WebCore::Geolocation::setShouldClearCache):
- (WebCore::Geolocation::shouldClearCache):
- (WebCore::Geolocation::):
-
-2009-03-13 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6610666> Revise the Cocoa event model text API
-
- Add a NPCocoaEventTextInput event type. Remove the text input variables.
-
- * bridge/npapi.h:
- (_NPCocoaEvent::):
-
-2009-03-13 Kevin Decker <kdecker@apple.com>
-
- Reviewed by Anders.
-
- <rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed
-
- The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
- over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
- for x-oleobject.
-
- * rendering/RenderPartObject.cpp:
- (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
-
-2009-03-13 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24559
- Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.
-
- * bindings/v8/custom/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::getListenerFunction):
- (WebCore::V8LazyEventListener::getWrappedListenerFunction):
-
-2009-03-13 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24557
- This is to support running multiple workers in a single worker process in chromium.
-
- * bindings/v8/custom/V8WorkerContextEventListener.cpp:
- (WebCore::V8WorkerContextEventListener::handleEvent):
- Add locker to v8 event listener of worker context.
-
-2009-03-13 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=24575
- XHR response is incorrect after a network error.
-
- Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html
- http/tests/xmlhttprequest/cross-site-denied-response-sync.html
- http/tests/xmlhttprequest/cross-site-denied-response.html
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request.
- (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note
- that since internalAbort() can drop GC protection, it is not safe to use the object after
- this call.
- (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and
- return early if it was. This can happen during sync requests, as the loader does not know
- that it was aborted, and just synthesizes all callbacks.
-
-2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=3547
- XMLHttpRequest.statusText returns always "OK"
-
- Covered by existing tests (which now pass on all platforms but Mac).
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up
- to each platform to correctly set the status text or set it to "OK" to retain current
- behavior.
-
-2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24349
- [QT] HTTP status text is never set
-
- Set HTTP status text to the reason phrase attribute of QNetworkReply.
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
- (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
-
-2009-03-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Mark Rowe
-
- <rdar://problem/6622300>: Reproducible crash on
- <http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>
-
- Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
- deleted from under itself. The sheetLoaded() notification can allow scripts
- to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
- which can cause the last ref to the CSSStyleSheet to be released.
-
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::checkLoaded):
-
-2009-03-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Allow make-generated-sources.sh to pass args down to DerivedSources.make
-
- * make-generated-sources.sh:
-
-2009-03-12 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Oliver Hunt.
+ - revert unintentional project changes from r45277
- https://bugs.webkit.org/show_bug.cgi?id=24498
- Fix the Qt port to use the same algorithm for drawing dashed and dotted
- borders as the other ports. This makes the Qt port pixel-for-pixel perfect
- compared to border drawing with Apple's canonical mac port and much closer
- to konqueror and firefox behavior.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::drawLine):
-
-2009-02-26 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Clean up DOMSelection to use some helper functions
- making the code smaller, and less error-prone.
- https://bugs.webkit.org/show_bug.cgi?id=19221
-
- I tried moving DOMSelection off of rangeCompliantEquivalent
- but failed. VisibleSelection holds positions like (table, 1) to mean
- "after the table".
-
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::visibleSelection):
- (WebCore::anchorPosition):
- (WebCore::focusPosition):
- (WebCore::basePosition):
- (WebCore::extentPosition):
- (WebCore::DOMSelection::anchorNode):
- (WebCore::DOMSelection::anchorOffset):
- (WebCore::DOMSelection::focusNode):
- (WebCore::DOMSelection::focusOffset):
- (WebCore::DOMSelection::baseNode):
- (WebCore::DOMSelection::baseOffset):
- (WebCore::DOMSelection::extentNode):
- (WebCore::DOMSelection::extentOffset):
- * page/DOMSelection.h:
-
-2009-03-12 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24563
- Change ResourceRequest to be a struct rather then a class to match other declarations.
-
- * platform/network/chromium/ResourceRequest.h:
-
-2009-03-12 David Levin <levin@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Bug 24530: width100percent-searchfield.html should be fixed for chromium.
- <https://bugs.webkit.org/show_bug.cgi?id=24530>
-
- Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html
-
- * css/themeChromiumWin.css: Added.
- Overrides the changes to start supporting input[type="search"] on Windows (since
- Chromium doesn't do anything special for this).
-
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::supportsFocus):
- (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
- (WebCore::RenderThemeChromiumWin::determineState):
- (WebCore::RenderThemeChromiumWin::getThemeData):
-
-2009-03-12 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=24506
- Geolocation in Safari differs from the spec, no Coordinates attribute on Position
-
- Get up to date.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::createPositionOptions):
- * page/Coordinates.cpp: Added.
- (WebCore::Coordinates::toString):
- * page/Coordinates.h: Added.
- (WebCore::Coordinates::create):
- (WebCore::Coordinates::latitude):
- (WebCore::Coordinates::longitude):
- (WebCore::Coordinates::altitude):
- (WebCore::Coordinates::accuracy):
- (WebCore::Coordinates::altitudeAccuracy):
- (WebCore::Coordinates::heading):
- (WebCore::Coordinates::speed):
- (WebCore::Coordinates::Coordinates):
- * page/Coordinates.idl: Added.
- * page/Geoposition.cpp:
- (WebCore::Geoposition::toString):
- * page/Geoposition.h:
- (WebCore::Geoposition::create):
- (WebCore::Geoposition::coords):
- (WebCore::Geoposition::Geoposition):
- * page/Geoposition.idl:
- * page/PositionOptions.h:
- (WebCore::PositionOptions::create):
- (WebCore::PositionOptions::maximumAge):
- (WebCore::PositionOptions::setMaximumAge):
- (WebCore::PositionOptions::PositionOptions):
- * platform/mac/GeolocationServiceMac.mm:
- (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
-
-2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24496
- Fix console logging of non-string values by coercing the argument to
- a string, for V8 bindings.
-
- Test: fast/js/console-non-string-values.html
-
- * bindings/v8/ScriptValue.cpp: Added toString method.
- (WebCore::ScriptValue::toString):
- * bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes
- and toString declaration.
-
-2009-03-12 Darin Fisher <darin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Eliminate ChromiumBridge::uiResourceProtocol
- https://bugs.webkit.org/show_bug.cgi?id=24558
-
- * platform/chromium/ChromiumBridge.h:
-
-2009-03-12 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Simon Fraser.
-
- Missing breaks in switch statement
- https://bugs.webkit.org/show_bug.cgi?id=24556
-
- * platform/mac/GeolocationServiceMac.mm:
- (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
-
-2009-03-12 Darin Fisher <darin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24554
- Remove some unused functions from ChromiumBridge.
- * platform/chromium/ChromiumBridge.h:
-
-2009-03-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Fisher and Justin Garcia.
-
- Safari crashes during drag and drop in Google presentations
- due to mutation event handlers removing DOM content during insertNode
- https://bugs.webkit.org/show_bug.cgi?id=22634
+2009-06-26 Mark Rowe <mrowe@apple.com>
- Added a bunch of "null" checks to make sure nodes are still
- in the document before we operate on them. This is an
- inelegant solution, but it's the best we have for now.
-
- Test: editing/selection/crash-on-drag-with-mutation-events.html
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::insertNodeAt):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
+ Fix the Windows build.
-2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
+ * WebCore.vcproj/WebCore.vcproj: Remove ColorSafari.cpp as
+ the file was deleted from SVN.
- Reviewed by Adam Treat.
-
- https://bugs.webkit.org/show_bug.cgi?id=24525
- REGRESSION: Inspector window doesn't close when inspected page is
- destroyed. This is a revert of r41158, which became unnecessary when
- InspectorController became ref-counted in r41462.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage
- after calling close().
- (WebCore::InspectorController::stopUserInitiatedProfiling): Remove
- m_inspectedPage check guard around profile logic.
-
-2009-03-12 Peter Kasting <pkasting@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24502
- Make horizontal scrolling on Windows always go the correct direction.
-
- * platform/PlatformWheelEvent.h:
- * platform/win/WheelEventWin.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24496
- Fix console logging of non-string values by coercing the argument to
- a string.
-
- Test: fast/js/console-non-string-values.html
-
- * bindings/js/ScriptValue.cpp: Removed PlatformString include.
- * bindings/js/ScriptValue.h: Added toString method.
- (WebCore::ScriptValue::toString):
- * page/Console.cpp:
- (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use
- ScriptValue::toString.
- (WebCore::Console::addMessage): added extra ScriptState argument to callsite.
- (WebCore::Console::count): Ditto.
-
-2009-03-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Adele Peterson.
-
- https://bugs.webkit.org/show_bug.cgi?id=24508
-
- Fix updating of text field with placeholder text when value is set
- by ensuring that updatePlaceholderVisibility() is called after
- the value has been updated, not before.
-
- Test: fast/forms/placeholder-set-value.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setValue):
-
-2009-03-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24552
-
- Hit testing involving normal flow, self-painting layers (e.g. reflections)
- was broken because it was not null-testing the result of hitTestLayer(),
- so bailing early with a nil hit layer.
-
- Test: fast/layers/normal-flow-hit-test.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Cameron Zwarich.
-
- Removed zero-sized files, left over from improperly applied patch.
-
- * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
- * platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.
-
-2009-03-12 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Do not ignore alpha color in optimization. Hard to believe, but there
- are websites that fill the entire page with a tiled image consisting of
- nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>
-
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 24110: cloneNode should call cloneElement and not the reverse
-
- - Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren.
- Now cloneNode calls one of the 2 previous methods.
-
- - Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.
-
- - Moved cloneNode to the Element private section so that WebCore callers cannot use it.
-
- - Removed Element::cloneNode usage through WebCore.
-
- * dom/Element.cpp:
- (WebCore::Element::cloneNode): Moved to Element's private section and it
- now calls the two next methods.
- (WebCore::Element::cloneElementWithChildren): Added.
- (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement
- to avoid ambiguity.
- * dom/Element.h:
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement
- to call to cloneElementWithoutChildren.
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply): Ditto.
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::indentRegion): Ditto.
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
- * editing/ModifySelectionListLevel.cpp:
- (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
- * editing/SplitElementCommand.cpp:
- (WebCore::SplitElementCommand::doApply): Ditto.
- * editing/markup.cpp:
- (WebCore::createFragmentFromText): Ditto.
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::buildShadowTree): Ditto.
- (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
-
-2009-03-12 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fixed a crash on the 1x1 pixel check for background image in gtk.
- We need to load the image first and need to be sure that the image
- is not null before checking the type.
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-03-12 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24544
- Rename setUrl to setURL
-
- Use proper case for setUrl method, rename it to setURL.
-
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::adopt):
- * platform/network/ResourceResponseBase.h:
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::writeCallback):
- (WebCore::headerCallback):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
- (WebCore::queryInfoCallback):
-
-2009-03-12 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24519
- [GTK] Use two argument KURL ctor in ResourceHandleSoup
-
- Use two argument KURL ctor, the single argument ctor expects its
- input to be the output of a previous KURL::parse call, which is
- not the case here.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
- (WebCore::queryInfoCallback):
-
-2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>
-
- Fix for <rdar://6418681>
- https://bugs.webkit.org/show_bug.cgi?id=22644
-
- Reviewed by Steve Falkenburg.
-
- * plugins/win/PluginPackageWin.cpp:
- (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
- Client plug-in to the blacklist; it requires a Mozilla-based browser.
-
-2009-03-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (build fix).
-
- build fix.
-
- * html/CanvasRenderingContext2D.h:
-
-2009-03-11 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
-
- A number of dashboard widgets rely on canvas failing silently when given invalid
- colors for gradient stops, but both the spec and firefox throw exceptions here.
- So we work around this by creating a dashboard quirk that will only suppress the
- exception in dashboard compatibility mode.
-
- Test: fast/canvas/canvas-gradient-addStop-error.html
-
- * html/CanvasGradient.cpp:
- (WebCore::CanvasGradient::CanvasGradient):
- (WebCore::CanvasGradient::addColorStop):
- * html/CanvasGradient.h:
- (WebCore::CanvasGradient::setDashboardCompatibilityMode):
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
- (WebCore::CanvasRenderingContext2D::createLinearGradient):
- (WebCore::CanvasRenderingContext2D::createRadialGradient):
- * html/CanvasRenderingContext2D.h:
-
-2009-03-11 David Kilzer <ddkilzer@apple.com>
-
- Clarify comments regarding order of FEATURE_DEFINES
-
- Rubber-stamped by Mark Rowe.
-
- * Configurations/WebCore.xcconfig: Added warning about the
- consequences when FEATURE_DEFINES are not kept in sync.
-
-2009-03-11 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24515
- [GTK] soup backend should use GMappedFile instead of mmap directly
-
- Rewrite mmap code used to upload files to use GMappedFile, so that
- it is platform-independent.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startHttp):
-
-2009-03-11 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - WebCore part of fixing <rdar://problem/3919124> Thai text selection
- in Safari is incorrect
-
- Test: platform/mac/editing/selection/word-thai.html
-
- Tested on Mac, but should work on all ICU platforms (or more precisely
- on all platforms that implement
- WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).
-
- * editing/TextIterator.cpp:
- (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
- Added.
- (WebCore::BackwardsCharacterIterator::range): Added.
- (WebCore::BackwardsCharacterIterator::advance): Added.
-
- * editing/TextIterator.h: Added BackwardsCharacterIterator with the
- minimal functionality required for this patch.
- (WebCore::BackwardsCharacterIterator::atEnd): Added.
-
- * editing/visible_units.cpp:
- (WebCore::firstNonComplexContextLineBreak): Added this helper function
- that returns the index of the first character in the string whose
- Unicode line breaking property value is not SA ("Complex Context"), or
- the length of the string if there is no such character.
- (WebCore::lastNonComplexContextLineBreak): Added this helper function
- that returns the index of the last character in the string whose
- Unicode line breaking property value is not SA ("Complex Context"), or
- -1 if there is no such character.
- (WebCore::previousBoundary): Changed the signature of the search
- function to include an offset parameter. Renamed the 'exception' local
- variable to 'ec' and changed its type to ExceptionCode. Extend the
- string forwards until the first character with Unicode line breaking
- property value other than SA. This gives the boundary search function
- enough context in the forward direction. Changed to use a
- BackwardsCharacterIterator for translating the backwards offset into
- a position.
- (WebCore::nextBoundary): Changed the signature of the search
- function to include an offset parameter. Extend the string backwards
- until the first character with Unicode line breaking property value
- other than SA. This gives the boundary search function enough context in
- the backwards direction. Restricted the workaround for <rdar://5192593>
- only to the line break case, because it was causing an extra character
- to be selected following a word that ended with a combining mark.
- (WebCore::startWordBoundary): Added an offset parameter. Check that
- going backwards from the given offset, there is a character with Unicode
- line breaking property value other than SA, and otherwise return 0 to
- request more context.
- (WebCore::endWordBoundary): Similar, but in reverse.
- (WebCore::previousWordPositionBoundary): Similar.
- (WebCore::nextWordPositionBoundary): Similar.
- (WebCore::startSentenceBoundary): Updated for the new search function
- signature.
- (WebCore::endSentenceBoundary): Ditto.
- (WebCore::previousSentencePositionBoundary): Ditto.
- (WebCore::nextSentencePositionBoundary): Ditto.
-
-2009-03-11 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Don't use "::" in thread names because it is ugly!
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
- it clear this is a WebCore-created thread.
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
- * storage/LocalStorageThread.cpp:
- (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
-
-2009-03-11 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Darin Adler.
-
- <rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex
-
- * platform/mac/PlatformScreenMac.mm:
- (WebCore::screenIsMonochrome): Return false.
-
-2009-03-11 Beth Dakin <bdakin@apple.com>
+2009-06-26 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
- Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
- top value on position:relative child not calculated correctly if
- parent has percentage height
- - and corresponding -
- <rdar://problem/6172925>
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::relativePositionOffsetY):
-
-2009-03-11 Jian Li <jianli@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Implement ScriptValue::hasNoValue for V8.
- https://bugs.webkit.org/show_bug.cgi?id=24507
-
- * bindings/v8/ScriptValue.h:
- (WebCore::ScriptValue::hasNoValue):
-
-2009-03-11 David Levin <levin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Bug 24459: Add v8 bindings for event.
- <https://bugs.webkit.org/show_bug.cgi?id=24459>
-
- Adding custom event bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=26766
- * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
- * bindings/v8/custom/V8AbstractEventListener.h: Added.
- * bindings/v8/custom/V8AttrCustom.cpp:
- Fixed messed up copyright header.
- * bindings/v8/custom/V8CustomEventListener.cpp: Added.
- * bindings/v8/custom/V8CustomEventListener.h:
- Replaced forwarding header with the real implementation.
- * bindings/v8/custom/V8ElementCustom.cpp:
- * bindings/v8/custom/V8LazyEventListener.cpp: Added.
- * bindings/v8/custom/V8LazyEventListener.h: Added.
- * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
- * bindings/v8/custom/V8ObjectEventListener.h: Added.
- * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
- * bindings/v8/custom/V8WorkerContextEventListener.h: Added.
-
-2009-03-11 Darin Fisher <darin@chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24521
- Add some missing includes for the non-JSC build.
-
- * platform/text/PlatformString.h: added OwnPtr.h
- * xml/XMLHttpRequest.cpp: added SecurityOrigin.h
-
-2009-03-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24531
-
- Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
- returns a null style if it has a valid renderer, which could happen if a
- CompositeAnimation existed, but wasn't running any animations or transitions.
-
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
-
-2009-03-11 Simon Fraser <simon.fraser@apple.com>
-
- Fix Scons build. Patch from Alexander Guy.
-
- * WebCore.scons:
-
-2009-03-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=23093
-
- When the cancel button in the search field is shown or hidden,
- we need to explicitly setStyle() on the cancel button's renderer,
- to ensure that repaint happens. Changing the style without telling
- the renderer won't work.
-
- Test: fast/repaint/search-field-cancel.html
-
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- * rendering/RenderTextControlSingleLine.h:
-
-2009-03-11 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=15790
- Ligatures aren't accounted for when manipulating VisiblePositions
-
- Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
- Indic ligature which uses a virama sign.
-
- Test: editing/deleting/skip-virama-001.html
-
- * platform/text/TextBreakIteratorICU.cpp:
- (WebCore::cursorMovementIterator):
-
-2009-03-11 Alexey Proskuryakov <ap@webkit.org>
+ Change to use array indexing rather than Vector enumerators; the former
+ are preferred style.
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=24513
- REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)
-
- Fixes existing tests on Tiger.
-
- * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
- Use characterBreakIterator on Tiger (like we used to do).
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::hasNonCompositingContent):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
+ (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
+ (WebCore::RenderLayerCompositor::layerHas3DContent):
-2009-03-11 Alexey Proskuryakov <ap@webkit.org>
+2009-06-26 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
- <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
-
- * platform/network/mac/ResourceRequestMac.mm:
- (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
- in instancesRespondToSelector.
-
-2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Holger Freyther.
-
- [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
- https://bugs.webkit.org/show_bug.cgi?id=2260
-
- Add missing stdio.h include to get the build going
-
- * plugins/gtk/PluginPackageGtk.cpp:
-
-2009-03-10 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Ken Kocienda.
-
- * dom/Range.cpp:
- (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
- would include rects for the divs contents. Set the correct RenderObject to stop at.
-
-2009-03-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
- comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
- there are security concerns with exposing them for cross-origin requests, so it's not clear
- if we want to change anything here.
-
-2009-03-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24503
-
- Fix hit testing of absolutely positioned single line text controls by
- ensuring that we set result.innerNode() correctly. If the hit node is
- a descendant of the inner text element or if it is the <input> itself,
- then we say we hit the innerTextElement.
-
- Rename hitInnerTextBlock() to hitInnerTextElement() to match the
- 'innerTextElement' terminology used elsewhere.
-
- Assert that if renderer()->hitTest() returns false, no-one set
- result.innerNode().
-
- Test: fast/forms/search-abs-pos-cancel-button.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestContents):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::hitInnerTextElement):
- * rendering/RenderTextControl.h:
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
-
-2009-03-10 Antti Koivisto <antti@apple.com>
-
- Reviewed by Mark Rowe.
-
- <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
-
- Another case where we would trigger extended encoding loading needlessly.
-
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::isNonByteBasedEncoding):
-
-2009-03-10 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
- scroll bar appears for long line of text with NOWRAP set
-
- This is a regression from http://trac.webkit.org/changeset/32226
- I talked with Dan about the original change, and we decided that
- the best fix was to remove his small potential-optimization that
- only created a separate line box for whitespace under certain
- circumstances. This new code will always create a separate line
- box.
-
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-03-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for <rdar://problem/6166844>
- https://bugs.webkit.org/show_bug.cgi?id=24495
-
- Use same rule for loading java applets as we do for images.
-
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::createRenderer):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createJavaAppletWidget):
-
-2009-03-10 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by David Kilzer.
-
- Get rid of revealCaret and use revealSelection instead.
-
- * WebCore.base.exp:
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setSelection):
- * page/Frame.cpp:
- (WebCore::Frame::revealSelection):
- * page/Frame.h:
-
-2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Geoff Garen.
-
- Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
- <https://bugs.webkit.org/show_bug.cgi?id=23736>
- <rdar://problem/6560278>
-
- Before replacing the document, FrameLoader::executeIfJavaScriptURL()
- should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeIfJavaScriptURL):
-
-2009-03-10 Darin Adler <darin@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24494: crash when deleting at end of document and merging paragraphs
- https://bugs.webkit.org/show_bug.cgi?id=24494
- rdar://problem/6571537
-
- Test: editing/deleting/merge-at-end-of-document.html
-
- * dom/Range.cpp:
- (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
- use && in assertions since we'd like to know which condition is failing.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
- calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
- function doesn't know which value to return.
-
-2009-03-10 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Eric Seidel. Math checked by Oliver Hunt.
-
- Implement the Cairo version of the checkForSolidColor() method. This halfes the
- time to draw on 1x1 px background images.
- I added two new calls to Color for the pixel manipulation on cairo_surface's.
- They are neede to premultiply/unpremultiply the colors of the surface.
-
- [CAIRO] Introduce single-pixel image optimizations
- https://bugs.webkit.org/show_bug.cgi?id=17284
-
- * platform/graphics/Color.cpp:
- (WebCore::colorFromPremultipliedARGB):
- (WebCore::premultipliedARGBFromColor):
- * platform/graphics/Color.h:
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-03-06 Darin Fisher <darin@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=24437
-
- Add support for registering noAccess URL schemes:
- 1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
- that list upon construction (similar to how isLocal is implemented).
- 2- Make InspectorController call grantUniversalAccess on its Document's
- SecurityOrigin at the time when windowScriptObjectAvailable is called.
-
- This enables content such as the inspector to be loaded from a custom (non-file)
- URL, which is how Chromium loads the inspector. It also allows other URL schemes
- to be treated like data: URLs, which Chromium utilizes for its various HTML-based
- UI panels.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::windowScriptObjectAvailable):
- * loader/FrameLoader.cpp:
- (WebCore::localSchemes):
- (WebCore::noAccessSchemes):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::SecurityOrigin):
- (WebCore::SecurityOrigin::isLocal):
-
-2009-03-10 Xan Lopez <xlopez@igalia.com>
-
- Build fix, no review
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (textMarkerForVisiblePosition):
- (visiblePositionForTextMarker):
-
-2009-03-10 Xan Lopez <xlopez@igalia.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24491
- Rename posOffset to m_offset, get rid of accessor
-
- As suggested in dom/Position.h, this patch gets rid of the
- 'offset()' accessor and renames posOffset to m_offset. I've used
- m_offset instead of offset to follow the style guide lines, since
- Position is still a class and not a structure. If the long term
- plan is still to make it a structure it would be pretty easy to
- just s/m_offset/offset/ globally when that is achieved.
-
- * dom/Position.cpp:
- (WebCore::Position::previous):
- (WebCore::Position::next):
- (WebCore::Position::atStart):
- (WebCore::Position::atEnd):
- (WebCore::Position::renderedOffset):
- (WebCore::Position::isCandidate):
- (WebCore::Position::inRenderedText):
- (WebCore::Position::isRenderedCharacter):
- (WebCore::Position::rendersInDifferentPosition):
- (WebCore::Position::leadingWhitespacePosition):
- (WebCore::Position::debugPosition):
- (WebCore::Position::formatForDebugger):
- * dom/Position.h:
- (WebCore::Position::Position):
- * dom/PositionIterator.h:
- (WebCore::PositionIterator::PositionIterator):
- * dom/Range.cpp:
- * dom/RangeBoundaryPoint.h:
- (WebCore::RangeBoundaryPoint::position):
- (WebCore::RangeBoundaryPoint::set):
- (WebCore::RangeBoundaryPoint::setOffset):
- (WebCore::RangeBoundaryPoint::setToChild):
- (WebCore::RangeBoundaryPoint::setToStart):
- (WebCore::RangeBoundaryPoint::setToEnd):
- (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
- (WebCore::ApplyStyleCommand::removeInlineStyle):
- (WebCore::ApplyStyleCommand::nodeFullySelected):
- (WebCore::ApplyStyleCommand::nodeFullyUnselected):
- (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
- (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
- (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
- (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- (WebCore::ApplyStyleCommand::joinChildTextNodes):
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::insertNodeAt):
- (WebCore::CompositeEditCommand::positionOutsideTabSpan):
- (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
- (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
- (WebCore::CompositeEditCommand::deleteInsignificantText):
- (WebCore::CompositeEditCommand::removePlaceholderAt):
- (WebCore::CompositeEditCommand::moveParagraphs):
- (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::updatePositionForNodeRemoval):
- (WebCore::updatePositionForTextRemoval):
- (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- (WebCore::DeleteSelectionCommand::fixupWhitespace):
- * editing/Editor.cpp:
- (WebCore::Editor::setComposition):
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::Editor::getCompositionSelection):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::performTrivialReplace):
- (WebCore::InsertTextCommand::input):
- (WebCore::InsertTextCommand::insertTab):
- * editing/MoveSelectionCommand.cpp:
- (WebCore::MoveSelectionCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::debugRenderer):
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::rangeFromLocationAndLength):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::characterAfter):
- (WebCore::VisiblePosition::debugPosition):
- (WebCore::makeRange):
- (WebCore::setStart):
- (WebCore::setEnd):
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::toNormalizedRange):
- (WebCore::makeSearchRange):
- (WebCore::VisibleSelection::debugPosition):
- (WebCore::VisibleSelection::showTreeForThis):
- * editing/htmlediting.cpp:
- (WebCore::comparePositions):
- (WebCore::rangeCompliantEquivalent):
- (WebCore::isFirstPositionAfterTable):
- (WebCore::isLastPositionBeforeTable):
- * editing/visible_units.cpp:
- (WebCore::previousBoundary):
- (WebCore::nextBoundary):
- (WebCore::startPositionForLine):
- (WebCore::startOfLine):
- (WebCore::endPositionForLine):
- (WebCore::nextLinePosition):
- (WebCore::startOfParagraph):
- (WebCore::endOfParagraph):
- * page/AccessibilityObject.cpp:
- (WebCore::updateAXLineStartForVisiblePosition):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::anchorOffset):
- (WebCore::DOMSelection::baseOffset):
- (WebCore::DOMSelection::focusOffset):
- (WebCore::DOMSelection::extentOffset):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEventSingleClick):
- * page/Frame.cpp:
- (WebCore::Frame::selectionLayoutChanged):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::indexForVisiblePosition):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::writeSelection):
-
-2009-03-10 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
- https://bugs.webkit.org/show_bug.cgi?id=23564
- rdar://problem/6537238
-
- Test: fast/dom/HTMLElement/innerHTML-selection-crash.html
-
- * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
- call to the one of the two overloads of this function that wasn't calling it. This fixes
- this crash and other possible crashes inside innerHTML.
-
-2009-03-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24285
- Text resource loading checks for BOM twice
-
- This removes TextDecoder class, since its only purpose was to check for BOM, which is
- already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
- BOM checked, but I didn't find any cases where it would significantly change behavior.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Remove TextDecoder.{h,cpp}.
-
- * platform/text/TextDecoder.cpp: Removed.
- * platform/text/TextDecoder.h: Removed.
-
- * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
- TextCodec separately.
-
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
- (WebCore::TextResourceDecoder::setEncoding): Ditto.
- (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
- even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
- BOM again. Made this function return the detected BOM length.
- (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
- a text resource.
- (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
- resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
-
- * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
- Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
- checks for BOM, which was a counter-intuitive feature.
-
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::CachedScript):
- (WebCore::CachedScript::setEncoding):
- (WebCore::CachedScript::encoding):
- (WebCore::CachedScript::script):
- * loader/CachedScript.h:
- * loader/appcache/ManifestParser.cpp:
- (WebCore::parseManifest):
- Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
- A side effect of this is that these resources will now be subject to encoding auto-detection.
-
- * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
- * page/Page.cpp: (WebCore::Page::userStyleSheet):
- Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
- re-usable (for repeated decoding of the same resource).
-
- * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
-
-2009-03-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24488
- An assertion failure when updating an offline application cache after emptying caches
-
- Emptying appcache cannot be performed automatically, so no test.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
- storage, even if the application wasn't updated server side.
-
-2009-03-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- <rdar://problem/6425807> Implement WorkerUtils.importScripts()
- <https://bugs.webkit.org/show_bug.cgi?id=22721>
-
- Implement importScripts, currently uses a series of synchronous loads
- to fetch the scripts, but this is simpler than a synchronous load of
- multiple loads in parallel. In future we'll want to switch to parallel
- loading, but this will do for now.
-
- Test: http/tests/workers/worker-importScripts.html
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::importScripts):
- * bindings/js/ScriptValue.h:
- (WebCore::ScriptValue::hasNoValue):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- (WebCore::WorkerScriptController::setException):
- * bindings/js/WorkerScriptController.h:
- * dom/Document.cpp:
- (WebCore::Document::scriptImported):
- * dom/Document.h:
- * dom/ScriptExecutionContext.h:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::scriptImported):
- * inspector/InspectorController.h:
- * inspector/InspectorResource.cpp:
- (WebCore::InspectorResource::setScriptProperties):
- * inspector/InspectorResource.h:
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::scriptImported):
- (WebCore::WorkerContext::importScripts):
- * workers/WorkerContext.h:
- * workers/WorkerContext.idl:
- * workers/WorkerImportScriptsClient.cpp: Added.
- (WebCore::WorkerImportScriptsClient::didReceiveResponse):
- (WebCore::WorkerImportScriptsClient::didReceiveData):
- (WebCore::WorkerImportScriptsClient::didFinishLoading):
- (WebCore::WorkerImportScriptsClient::didFail):
- (WebCore::WorkerImportScriptsClient::didFailRedirectCheck):
- (WebCore::WorkerImportScriptsClient::didReceiveAuthenticationCancellation):
- * workers/WorkerImportScriptsClient.h: Added.
- (WebCore::WorkerImportScriptsClient::WorkerImportScriptsClient):
- (WebCore::WorkerImportScriptsClient::script):
- (WebCore::WorkerImportScriptsClient::failed):
-
-2009-03-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24462
- Move cross-origin access control code out of XMLHttpRequest
-
- Step 1: move preflight result cache and access control helper functions.
-
- No change in behavior, so no test.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * loader/CrossOriginAccessControl.cpp: Added.
- (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
- (WebCore::isSimpleCrossOriginAccessRequest):
- (WebCore::createAllowedCrossOriginResponseHeadersSet):
- (WebCore::isOnAccessControlResponseHeaderWhitelist):
- (WebCore::passesAccessControlCheck):
- * loader/CrossOriginAccessControl.h: Added.
- * loader/CrossOriginPreflightResultCache.cpp: Added.
- (WebCore::parseAccessControlMaxAge):
- (WebCore::addToAccessControlAllowList):
- (WebCore::parseAccessControlAllowList):
- (WebCore::CrossOriginPreflightResultCacheItem::parse):
- (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
- (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
- (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
- (WebCore::CrossOriginPreflightResultCache::shared):
- (WebCore::CrossOriginPreflightResultCache::appendEntry):
- (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
- * loader/CrossOriginPreflightResultCache.h: Added.
- (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
- (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
- (WebCore::XMLHttpRequest::createRequest):
- (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
- (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
- (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::didReceiveResponse):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- * xml/XMLHttpRequest.h:
-
-2009-03-10 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19797
- Bring the list of forbidden headers in sync with XMLHttpRequest spec draft
-
- Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
- XMLHttpRequest 2 draft.
-
-2009-03-10 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adele Peterson.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=23975
- <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
- scrollbar rect calculation.
-
-2009-03-09 Simon Fraser <simon.fraser@apple.com>
+ - fix <rdar://problem/6961476> REGRESSION (r42043): scrollWidth reported
+ as 1 px
- Reviewed by Dan Bernstein, Oliver Hunt
+ Test: fast/dom/Element/scrollWidth.html
- https://bugs.webkit.org/show_bug.cgi?id=24475
-
- When repainting replaced elements, need to union the selection
- and overflow rects because either may extend outside the other.
-
- Test: fast/repaint/transform-replaced-shadows.html
-
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
-
-2009-03-09 Stephanie Lewis <slewis@apple.com>
-
- Fix build.
-
- * editing/Editor.cpp:
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::markAllMisspellingsAndBadGrammarInRanges):
-
-2009-03-09 Kim Christensen <kimworking@gmail.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24276
- Dropdown / select boxes do not consider the windows task bar in Chromium.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupContainer::showPopup):
-
-2009-03-09 Dan Bernstein <mitz@apple.com>
+ Changed scrollWidth and scrollHeight to use the same logic for
+ visible overflow boxes that is used for clipped overflow boxes. In
+ particular, borders are not included and
+ {leftmost,rightmost,lowest}Position() are used. This logic matches IE8.
- Reviewed by Adele Peterson and Dave Hyatt.
-
- - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
- misaligned edit fields
-
- Test: fast/forms/legend-display-none.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
- property of legend elements to 'block' unless it is 'none'.
- * css/html4.css: Do not force the display property of legend elements to
- 'block' using CSS, because that prevents style rules from setting it to
- 'none'.
-
-2009-03-09 Alpha Lam <hclam@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23024
-
- Fix an incorrect criteria in the if statement that leaves references to
- deleted floating objects in RenderBlock.
-
- Test: fast/block/float/crash-on-absolute-positioning.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
-
-2009-03-09 Mike Belshe <mike@belshe.com>
-
- Reviewed by Eric Seidel.
-
- Unify JSC/V8 idl file.
- https://bugs.webkit.org/show_bug.cgi?id=24424
-
- * page/Location.idl:
-
-2009-03-09 Mike Belshe <mike@belshe.com>
-
- Reviewed by Eric Seidel.
-
- Unify JSC/V8 for History.idl.
-
- * page/History.idl:
-
-2009-03-09 Mike Belshe <mike@belshe.com>
-
- Reviewed by Eric Seidel.
-
- Unify JSC/V8 implementations of DOMWindow.idl.
-
- * page/DOMWindow.idl:
-
-2009-03-09 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24163
-
- Implement mapping of FloatQuads through 3D transforms.
-
- Removed the redundant localToContainerQuad() methods, which can now
- shared code with the old mapLocalToAbsolutePoint(), which was
- renamed to mapLocalToContainer(). This can now convert a point,
- and optionally a FloatQuad, which are carried along in the TransformState.
-
- Optimized TransformState to reduce to simple FloatPoint.move()
- if there are no transforms, and to heap-allocate a transform only if
- necessary to accumulate transforms (when using preserve-3d).
-
- Tested by 3d point mapping tests, and the inspector highlight (which now shows
- the correct quads for 3d-transformed elements).
-
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::projectQuad):
- (WebCore::TransformationMatrix::translateRight):
- (WebCore::TransformationMatrix::translateRight3d):
- * platform/graphics/transforms/TransformationMatrix.h:
* rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToContainer):
- (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- * rendering/RenderBox.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::absoluteToLocal):
- (WebCore::RenderObject::mapLocalToContainer):
- (WebCore::RenderObject::localToContainerQuad):
- * rendering/RenderObject.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::mapLocalToContainer):
- * rendering/RenderTableCell.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::mapLocalToContainer):
- * rendering/RenderView.h:
- * rendering/TransformState.cpp:
- (WebCore::TransformState::move):
- (WebCore::TransformState::applyTransform):
- (WebCore::TransformState::flatten):
- (WebCore::TransformState::mappedPoint):
- (WebCore::TransformState::mappedQuad):
- (WebCore::TransformState::flattenWithTransform):
- (WebCore::HitTestingTransformState::mappedQuad):
- * rendering/TransformState.h:
- (WebCore::TransformState::TransformState):
- (WebCore::TransformState::move):
- (WebCore::TransformState::lastPlanarPoint):
- (WebCore::TransformState::lastPlanarQuad):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::preserves3D):
-
-2009-03-09 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24433
-
- During hit testing with transforms, if a layer has backface-visibility: hidden,
- we need to check for it whether or not the layer has a transform, because it
- might be an ancestor that is transformed.
-
- Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=24353
- Allow to overrule default build options for Qt build.
-
- * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
-
-2009-03-09 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=24463
- WebCore::qstring is detaching and copying twice for every single
- WebCore::TextRun that is processed and drawn. This elevates this method
- to one of the top-ten most expensive methods in all of QtWebKit according
- to profiling. This changes the method so that QString only detaches
- when absolutely necessary.
-
- * platform/graphics/qt/FontQt.cpp:
- (WebCore::qstring):
- (WebCore::fixSpacing):
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- (WebCore::Font::selectionRectForComplexText):
-
-2009-03-08 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
- Frame.h no longer needs to include it. This cuts the size of the symbols
- for a debug build by around 3%.
-
- * dom/Element.cpp:
- (WebCore::Element::scrollIntoView):
- (WebCore::Element::scrollIntoViewIfNeeded):
- * editing/Editor.cpp:
- (WebCore::Editor::insertTextWithoutSendingTextEvent):
- (WebCore::Editor::revealSelectionAfterEditingOperation):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setSelection):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::gotoAnchor):
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::contextMenuItemSelected):
- * page/Frame.cpp:
- (WebCore::Frame::revealSelection):
- (WebCore::Frame::revealCaret):
- * page/Frame.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::getRectToExpose):
- (WebCore::RenderLayer::autoscroll):
- * rendering/RenderLayer.h:
- * rendering/ScrollBehavior.cpp: Added.
- (WebCore::):
- * rendering/ScrollBehavior.h: Added.
- (WebCore::):
- (WebCore::ScrollAlignment::getVisibleBehavior):
- (WebCore::ScrollAlignment::getPartialBehavior):
- (WebCore::ScrollAlignment::getHiddenBehavior):
-
- Add the new files to the build systems:
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
-
- Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
- * dom/Clipboard.cpp:
- * editing/EditorCommand.cpp:
- * editing/InsertLineBreakCommand.cpp:
- * editing/TypingCommand.cpp:
- * html/HTMLFormControlElement.cpp:
- * loader/archive/cf/LegacyWebArchive.cpp:
- * loader/icon/IconLoader.cpp:
- * page/animation/AnimationController.cpp:
- * rendering/RenderSlider.cpp:
- * rendering/RenderTextControl.cpp:
-
-
-2009-03-08 Mark Rowe <mrowe@apple.com>
-
- Reviewed Dan Bernstein.
-
- Push the include of Frame.h out of RenderView.h and down to those files
- that need it. This cuts the size of symbols for RenderFoo object files
- by around 15% in a debug build.
-
- * bindings/objc/DOM.mm:
- * rendering/RenderFileUploadControl.cpp:
- * rendering/RenderInline.cpp:
- * rendering/RenderObject.cpp:
- * rendering/RenderReplaced.cpp:
- * rendering/RenderText.cpp:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::zoomFactor):
- * rendering/RenderView.h:
-
-2009-03-08 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- Remove some unnecessary or redundant includes from files related to the JS bindings.
- This cuts the size of the symbols for a debug build by around 3%.
-
- * bindings/js/JSCustomPositionCallback.cpp:
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- * bindings/js/JSCustomVoidCallback.cpp:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- * bindings/js/JSDocumentCustom.cpp:
- * bindings/js/JSPluginElementFunctions.cpp:
- * bindings/js/JSSVGPODTypeWrapper.h:
-
-2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
- and provisionalHistoryItem() from FrameLoader.
-
- * WebCore.base.exp:
- * WebCore.order:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::frameLoadCompleted):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
-
-2009-03-08 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Implement proper logging for the GTK+ port, inspired by the one in
- Qt. We use the WEBKIT_DEBUG environment variable which was already
- being used to decide whether to setup a logger for soup or not.
-
- * platform/gtk/LoggingGtk.cpp:
- (WebCore::getChannelFromName):
- (WebCore::InitializeLoggingChannelsIfNecessary):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ensureSessionIsInitialized):
-
-2009-03-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - WebCore part of removing build-time and run-time support for legacy
- versions of CFNetwork and Core Graphics
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::fontPlatformData):
- * platform/graphics/win/FontPlatformDataCGWin.cpp:
- (WebCore::FontPlatformData::platformDataInit):
- * platform/network/cf/FormDataStreamCFNet.cpp:
- (WebCore::setHTTPBody):
- (WebCore::httpBodyFromRequest):
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::didSendBodyData):
- (WebCore::shouldUseCredentialStorageCallback):
- (WebCore::ResourceHandle::start):
- * platform/network/win/CookieJarCFNetWin.cpp:
- (WebCore::filterCookies):
-
-2009-03-07 Adele Peterson <adele@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
- No multiple JS property for <input type="file" multiple />
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::multiple):
- (WebCore::HTMLInputElement::setMultiple):
- * html/HTMLInputElement.h:
- * html/HTMLInputElement.idl:
-
-2009-03-07 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24358
- [GTK] Scrollbars not clipped correctly
-
- ScrollView scrollbars in subframes are *not* native, so take that
- into account again.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::getLocationInParentWindow):
- (ScrollbarGtk::frameRectsChanged):
- (ScrollbarGtk::paint):
- * platform/gtk/ScrollbarGtk.h:
-
-2009-03-06 Peter Kasting <pkasting@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24405
- Horizontal scrolling on Windows was reversed from Mac (and intuition).
-
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/win/WheelEventWin.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-06 Peter Kasting <pkasting@google.com>
-
- Reviewed by Sam Weinig.
-
- Convert some C-style casts to static_cast<>()s.
-
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/mac/WheelEventMac.mm:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/win/WheelEventWin.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/wx/MouseWheelEventWx.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-06 Adele Peterson <adele@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)
-
- I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.
-
- * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
- That is no longer true, so we should return the document element for a truly empty document.
-
-2009-03-06 Jay Campan <jcampan@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24306
-
- Adding a flag to ResourceRequestBase to indicate whether or not upload
- progress notifications are needed for a resource. This is useful to
- avoid sending these notifications when there are no consumers
- (especially in the Chromium case where IPC is involved).
-
- * platform/network/ResourceRequestBase.h:
- (WebCore::ResourceRequestBase::reportUploadProgress):
- (WebCore::ResourceRequestBase::setReportUploadProgress):
- (WebCore::ResourceRequestBase::ResourceRequestBase):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
-
-2009-03-06 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24150
- Add virtual ScriptExecutionContext::encoding()
-
- Test: http/tests/workers/text-encoding.html
-
- * dom/Document.cpp:
- (WebCore::Document::encoding):
- * dom/Document.h:
- (WebCore::Document::inputEncoding):
- (WebCore::Document::charset):
- (WebCore::Document::characterSet):
- Add new virtual method and route DOM synonym functions on Document through it.
-
- * dom/ScriptExecutionContext.h:
- * workers/Worker.cpp:
- (WebCore::Worker::Worker):
- (WebCore::Worker::notifyFinished):
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::WorkerContext):
- (WebCore::WorkerContext::encoding):
- (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
- * workers/WorkerContext.h:
- (WebCore::WorkerContext::create):
- * workers/WorkerContextProxy.h:
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::startWorkerContext):
- * workers/WorkerMessagingProxy.h:
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThreadStartupData::create):
- (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
- (WebCore::WorkerThread::create):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::workerThread):
- * workers/WorkerThread.h:
- All of the above route the 'encoding' parameter of parent context to the new
- instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy
- through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.
-
-2009-03-06 Peter Kasting <pkasting@google.com>
-
- Build bustage fix.
-
- * dom/Node.cpp:
- (WebCore::Node::dispatchWheelEvent):
-
-2009-03-06 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.
-
-2009-03-06 Douglas R. Davidson <ddavidso@apple.com>
-
- Reviewed by Justin Garcia.
-
- https://bugs.webkit.org/show_bug.cgi?id=24108
-
- Update spelling and grammar checking to use the new combined text
- checking (with automatic language identification) on Snow Leopard.
- Tested manually in Mail and Safari; automated tests to come later.
-
- * editing/Editor.cpp:
- (WebCore::findFirstMisspellingOrBadGrammarInRange):
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::guessesForMisspelledOrUngrammaticalRange):
- (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
- (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- (WebCore::markAllMisspellingsAndBadGrammarInRanges):
- (WebCore::Editor::markMisspellingsAndBadGrammar):
- * editing/Editor.h:
- * loader/EmptyClients.h:
- (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
- * page/EditorClient.h:
- * page/Frame.cpp:
- (WebCore::Frame::respondToChangedSelection):
- * platform/ContextMenu.cpp:
- (WebCore::ContextMenu::populate):
-
-2009-03-06 Peter Kasting <pkasting@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24407
- Windows scroll amount was too small, and wheel scroll distance
- conversion code was overly complex.
-
- * page/EventHandler.cpp:
- (WebCore::scrollAndAcceptEvent):
- * platform/PlatformWheelEvent.h:
- (WebCore::):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::wheelEvent):
- * platform/Scrollbar.h:
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/mac/WheelEventMac.mm:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/qt/WheelEventQt.cpp:
- * platform/win/WheelEventWin.cpp:
- (WebCore::horizontalScrollChars):
- (WebCore::verticalScrollLines):
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/wx/MouseWheelEventWx.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2009-03-06 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Adam Roben.
-
- Generate valid bindings with HTML5 database support disabled.
-
- * inspector/InspectorController.idl: Added feature guard around
- databaseTableNames definition.
-
-2009-03-04 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24358
- [GTK] Scrollbars not clipped correctly
-
- Do not take into account the case of being a ScrollView scrollbar,
- since those are native in our case.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::frameRectsChanged):
-
-2009-03-04 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24358
- [GTK] Scrollbars not clipped correctly
-
- Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
- specific and it's our only Widget anyway.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::paint):
- * platform/gtk/ScrollbarGtk.h:
- * platform/gtk/WidgetGtk.cpp:
-
-2009-03-04 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24358
- [GTK] Scrollbars not clipped correctly
-
- Use correct clip rectangle and apply coordinate translation needed
- for non-ScrollView scrollbars.
-
- We were ignoring the clip rectangle passed as parameter, which is
- wrong in the case of non coalesced expose events. This, in turn,
- uncovers the fact that we were not applying coordinate translation
- to our position.
-
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::paint):
-
-2009-03-06 Eric Carlson <eric.carlson@apple.com>
-
- Build fix, no review
-
- * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
-
-2009-03-06 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=22790
- Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
- Replace media engine setRect with setSize since they don't use about the
- position anyway.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
- (WebCore::MediaPlayer::setSize): Ditto.
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayer::size): Changed from rect().
-
- * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
-
- * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
- (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
- (WebCore::MediaPlayerPrivate::paint): update comment
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
- (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
- (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
- (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so
- the movie is drawn in the correct location.
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
- * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
-
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
-
-2009-03-06 Darin Adler <darin@apple.com>
-
- Reviewed by Darin Fisher.
-
- Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
- https://bugs.webkit.org/show_bug.cgi?id=24422
- rdar://problem/6402208
-
- Test: fast/dom/location-new-window-no-crash.html
-
- The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
- to add some checks for empty URLs. We could also put the empty URL checks at some
- other bottleneck level and add more assertions over time. I tried adding a few more
- assertions to functions like loadURL and hit them while running the regression tests,
- so it's probably going to be a bit tricky to clean this up throughout the loader.
-
- * loader/FrameLoader.cpp:
- (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
- immutable by making all its members const. Added assertions about the arguments,
- including that the URL is not empty. Initialized one uninitialized member in one of
- the constructors.
- (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
- a no-op if passed an empty URL.
- (WebCore::FrameLoader::scheduleLocationChange): Ditto.
- (WebCore::FrameLoader::scheduleRefresh): Ditto.
-
-2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24423
- Use new soup_message_body_set_accumulate API in soup backend
-
- Disable accumulating chunks for request_body on file uploads,
- using the new soup API.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startHttp):
-
-2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
- the new soup_message_body_set_accumulate API in soup.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::gotHeadersCallback):
- (WebCore::ResourceHandle::startHttp):
-
-2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24051
- Soup backend needs content sniffing capabilities
-
- Perform content sniffing when using soup, so that we have a chance
- of figuring out the Content-Type of the file if it's not sent by
- the server.
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::gotHeadersCallback):
- (WebCore::gotChunkCallback):
-
-2009-03-06 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24342
- Cannot insert a Thai character after a Thai prepend character when using ICU 4.0
-
- This change creates a new break iterator "cursorMovementIterator" for
- moving cursors and use it when moving an input cursor.
- In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
- based on the one of ICU 3.8.
- On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
- just calls the characterBreakIterator() function.
-
- Test: editing/inserting/insert-thai-characters-001.html
-
- * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
- * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
- (WebCore::setUpIteratorWithRules): Ditto.
- (WebCore::cursorMovementIterator): Ditto.
- * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
- (WebCore::cursorMovementIterator): Ditto.
- * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
- (WebCore::RenderText::previousOffset): Ditto.
- (WebCore::RenderText::nextOffset): Ditto.
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
-2009-03-05 Alexey Proskuryakov <ap@webkit.org>
+2009-06-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
- <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
- Characters (a compatibility issue with widgets).
-
- Test: http/tests/xmlhttprequest/broken-xml-encoding.html
-
- Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
- responses.
-
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::TextResourceDecoder):
- (WebCore::TextResourceDecoder::decode):
- (WebCore::TextResourceDecoder::flush):
- * loader/TextResourceDecoder.h:
- (WebCore::TextResourceDecoder::useLenientXMLDecoding):
- Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
- decoding errors. This behavior is now limited to other kinds of XML content.
-
-2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>
-
- Bug 24382: request to add SH4 platform
-
- <https://bugs.webkit.org/show_bug.cgi?id=24382>
-
- Reviewed by David Kilzer.
-
- * platform/text/AtomicString.cpp:
- (WebCore::equal): Aligned memory access on SH4 platform.
-
-2009-03-05 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Simon Fraser.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24215
-
- Gears expects an object tag with display:none to instantiate the plugin,
- so we add a workaround to make this work and fix Gears on WebKit trunk.
-
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::rendererIsNeeded):
-
-2009-03-05 Avi Drissman <avi@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Need to have Chromium Mac match Safari Mac's accesskey handling
- https://bugs.webkit.org/show_bug.cgi?id=24404
-
- * page/chromium/EventHandlerChromium.cpp:
- (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
-
-2009-03-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24412
-
- Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
- but no transform. We need to make localTransformState if we see preserve-3d.
- Also need to call update3DTransformedDescendantStatus() before we test
- m_has3DTransformedDescendant.
-
- Test: transforms/3d/hit-testing/hit-preserves-3d.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-05 Eric Seidel <eric@webkit.org>
-
- Reviewed by David Hyatt.
-
- Changes to RenderLayer destruction to hopefully help catch an elusive crasher
- https://bugs.webkit.org/show_bug.cgi?id=24409
-
- Added a new RenderBoxModelObject::destroyLayer() call which is
- now the only way which RenderLayers should ever be destroyed.
- This ensures that the pointer to the layer is cleared in the
- RenderObject after destruction, allowing us to ASSERT in the
- RenderBoxModelObject destructor.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
- (WebCore::RenderBoxModelObject::destroyLayer):
- (WebCore::RenderBoxModelObject::destroy):
- (WebCore::RenderBoxModelObject::styleDidChange):
- * rendering/RenderBoxModelObject.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::stackingContext):
- (WebCore::RenderLayer::destroy):
- (WebCore::RenderLayer::removeOnlyThisLayer):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::destroy):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy):
-
-2009-03-05 Eric Seidel <eric@webkit.org>
-
- Reviewed by David Hyatt.
-
- Remove old, unused IE 5.5 scrollbar-* CSS properties.
- Sort the unimplemented getComputedStyle properties so it's
- easier to see which ones actually need implementation.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSPropertyNames.in:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
-
-2009-03-05 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
- within the document without changing its position in the DOM. For example, pressing return in (caret marked by ^):
- <div contentEditable="true"><div>^Hello</div></div>
- Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
- for example).
-
- Changes to layout tests demonstrate fix.
-
- * editing/EditCommand.cpp:
- (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or
- not it did work that needs to be applied.
- * editing/Editor.cpp:
- (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
- (WebCore::Editor::unappliedEditing): Ditto.
- (WebCore::Editor::reappliedEditing): Ditto.
- (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to
- EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
- even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position
- in the document.
- * editing/Editor.h:
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
- (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to.
- (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
- adding to the killring and responding to a change in selections if the delete was a no-op.
- (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- * editing/TypingCommand.h:
-
-2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Adam Roben.
-
- Eliminate a ref-counting leak in InspectorController.
-
- * inspector/InspectorController.h: Made constructor private, added static create method.
- * page/Page.cpp:
- (WebCore::Page::Page): Change initializer to use static create method.
-
-2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24355
- Add InspectorController.idl and convert InspectorController.cpp to use
- JSC bindings.
-
- * DerivedSources.make: Added InspectorController.idl
- * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
- * bindings/js/JSInspectorControllerCustom.cpp: Added.
- * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
- * inspector/InspectorController.cpp: Removed hand-rolled bindings.
- * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
- * inspector/InspectorController.idl: Added.
- * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
-
-2009-03-05 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24400
- Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
- media element attributes
-
- Test: media/video-loop.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement):
- (WebCore::HTMLMediaElement::loadInternal):
- (WebCore::HTMLMediaElement::setNetworkState):
- (WebCore::HTMLMediaElement::seek):
- (WebCore::HTMLMediaElement::playInternal):
- (WebCore::HTMLMediaElement::loop):
- (WebCore::HTMLMediaElement::setLoop):
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
- (WebCore::HTMLMediaElement::endedPlayback):
- (WebCore::HTMLMediaElement::updatePlayState):
- * html/HTMLMediaElement.h:
- * html/HTMLMediaElement.idl:
-
-2009-03-05 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached
-
- Reviewed by Ada Chan.
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
-
-2009-03-05 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- https://bugs.webkit.org/show_bug.cgi?id=24248
-
- Make sure painting of overflow controls checks that visibility:visible is set on the block before
- painting. Pixel tests caught this regression.
-
- Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
- to do to their bounds (which had nothing to do with overflow).
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintResizer):
-
-2009-03-05 Yong Li <yong.li@torchmobile.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24386
- A faster implementation of extractMIMETypeFromMediaType.
-
- * platform/network/HTTPParsers.cpp:
- (WebCore::extractMIMETypeFromMediaType):
-
-2009-03-05 Yong Li <yong.li@torchmobile.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=24392
- Do not get the current time for unless we're doing PRELOAD_DEBUG as this
- can be unnecessarily expensive.
-
- * html/PreloadScanner.cpp:
- (WebCore::PreloadScanner::write):
-
-2009-03-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24327
-
- When mapping points and hit testing through transforms, work
- correctly when acclerated animations of transforms are running.
-
- Tested by LayoutTests/animations/animation-hit-test-transform.html,
- which only failed when ACCELERATED_COMPOSITING was turned on.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::currentTransform):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::transformFromContainer):
-
-2009-03-05 Mike Belshe <mike@belshe.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24391
- Frame.cpp uses JSC specific includes
-
- * page/Frame.cpp:
-
-2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24389
- WebKitGTK+ crashes when cancelling plugin loads
-
- Remove bogus calls to the client's didFinishLoading method from
- our ResourceHandle::cancel implementation. Calling
- didFinishLoading here is mostly inoffensive for most loads, but
- causes crashes when plugin loads are cancelled.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::cancel):
-
-2009-03-05 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * WebCore.vcproj/QTMovieWin.vcproj:
-
-2009-03-05 Adam Treat <adam.treat@torchmobile.com>
-
- Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
- ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
- protected by an #if and uses HTMLPlugInElement so it must be included.
-
- * bindings/js/ScriptController.cpp:
-
-2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
-
- GTK Build fix.
-
- * inspector/ConsoleMessage.h: Use proper header.
-
-2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24376
- Split InspectorController.cpp file into separate classes.
-
- * GNUmakefile.am: Modified to include new files.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
- * inspector/ConsoleMessage.cpp: Added.
- * inspector/ConsoleMessage.h: Added.
- * inspector/InspectorController.cpp:
- * inspector/InspectorDOMStorageResource.cpp: Added.
- * inspector/InspectorDOMStorageResource.h: Added.
- * inspector/InspectorDatabaseResource.cpp: Added.
- * inspector/InspectorDatabaseResource.h: Added.
- * inspector/InspectorResource.cpp: Added.
- * inspector/InspectorResource.h: Added.
-
-2009-03-05 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24387
- Remove media element bufferingRate attribute. No test necessary as there
- were none for this attribute.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
- (WebCore::HTMLMediaElement::loadInternal): Ditto.
- (WebCore::HTMLMediaElement::setNetworkState): Ditto.
- (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
- * html/HTMLMediaElement.h: Remove m_bufferingRate.
- * html/HTMLMediaElement.idl: Ditto.
-
-2009-03-05 Xan Lopez <xan@gnome.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=24377
- [GTK] Comply better with coding style guidelines in ResourceHandleSoup
-
- Use C++ booleans, 0 instead of NULL, prefix boolean variables with
- 'is', do not use 'else if' if the previous if had a return, delete
- trailing whitespace, etc.
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
- (WebCore::fillResponseFromMessage):
- (WebCore::restartedCallback):
- (WebCore::finishedCallback):
- (WebCore::parseDataUrl):
- (WebCore::ensureSessionIsInitialized):
- (WebCore::ResourceHandle::startHttp):
- (WebCore::reportUnknownProtocolError):
- (WebCore::ResourceHandle::start):
- (WebCore::cleanupGioOperation):
- (WebCore::closeCallback):
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
- (WebCore::ResourceHandle::startGio):
-
-2009-03-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- https://bugs.webkit.org/show_bug.cgi?id=24328
-
- If an element has backface-visibility: hidden, hit testing should not
- hit the back sides of elements. Test for that by inverting the accumulated
- transform and looking at the z vector.
-
- Tested by transforms/3d/hit-testing/backface-hit-test.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-03-04 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- r41362 mistakenly added functions "RenderThemeWin::" into
- RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
- them to void return types. This patch switches them back to ints.
-
- https://bugs.webkit.org/show_bug.cgi?id=24360
-
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
- (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
- (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
- (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
-
-2009-03-04 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- Chromium Linux: change some metrics to better match Windows after
- r41416. Aesthetically this may be worse, but web-compat is king.
-
- Also, the previous code had an off by one error when drawing
- scrollbars which caused the scrollbar to overflow it's bounds by 1px
- at the right and bottom edges.
-
- https://bugs.webkit.org/show_bug.cgi?id=24369
-
- * rendering/RenderThemeChromiumLinux.cpp:
- (WebCore::):
- (WebCore::RenderThemeChromiumLinux::systemFont):
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromium::paintTrackPiece):
-
-2009-03-04 Eric Seidel <eric@webkit.org>
-
- Reviewed by Adam Roben.
-
- Add an ASSERT to better demonstrate the cause of the crash in
- https://bugs.webkit.org/show_bug.cgi?id=23736
-
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::~DocLoader):
-
-2009-03-04 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
- <https://bugs.webkit.org/show_bug.cgi?id=24337>
-
- Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
- http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
-
- * loader/mac/ResourceLoaderMac.mm:
- (WebCore::ResourceLoader::willCacheResponse):
- An identifier is only asssigned if resource load callbacks are done. So don't send
- willCacheResponse which uses identifier if resource load callbacks aren't being sent.
-
-2009-03-04 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
- <https://bugs.webkit.org/show_bug.cgi?id=24330>
-
- Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
-
- * dom/ExceptionCode.cpp:
- (WebCore::xmlHttpRequestExceptionNames):
- Added missing ABORT_ERR whose absence caused an assert.
-
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
- Add more logic to handle the termination case for sync xhr.
-
-2009-03-04 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=24364
- Add support for HTMLMediaElement canPlayType method. Make
- MediaPlayer::supportsType take a ContentType instead of a
- separate mime type and codecs parameter.
-
- Test: media/video-can-play-type.html
-
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
- (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
- (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
- (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
- * html/HTMLMediaElement.h: Add prototype.
- * html/HTMLMediaElement.idl: Ditto.
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
- (WebCore::MediaPlayer::supportsType): Ditto.
- * platform/graphics/MediaPlayer.h:
-
-2009-03-04 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24359
- Repaint throttling mechanism
-
- Excessive repainting can slow down page loadind. This implements a timer
- based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
- enabled by default.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::checkCompleted):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchDragEvent):
- (WebCore::EventHandler::dispatchMouseEvent):
- (WebCore::EventHandler::keyEvent):
- (WebCore::EventHandler::handleTextInputEvent):
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::reset):
- (WebCore::FrameView::repaintContentRectangle):
- (WebCore::FrameView::beginDeferredRepaints):
- (WebCore::FrameView::endDeferredRepaints):
- (WebCore::FrameView::checkStopDelayingDeferredRepaints):
- (WebCore::FrameView::doDeferredRepaints):
- (WebCore::FrameView::updateDeferredRepaintDelay):
- (WebCore::FrameView::resetDeferredRepaintDelay):
- (WebCore::FrameView::adjustedDeferredRepaintDelay):
- (WebCore::FrameView::deferredRepaintTimerFired):
- (WebCore::FrameView::paintContents):
- * page/FrameView.h:
-
-2009-03-04 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Antti Koivisto.
-
- Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
+ Bug 26725: aria-hidden, aria-disabled, aria-readonly need to be implemented
+ https://bugs.webkit.org/show_bug.cgi?id=26725
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- (WebCore::Document::haveStylesheetsLoaded):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::scriptHandler):
- * loader/Cache.cpp:
- (WebCore::Cache::requestResource):
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::checkNotify):
- * loader/DocLoader.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::FrameLoader):
- (WebCore::FrameLoader::requestFrame):
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::begin):
- (WebCore::FrameLoader::write):
- (WebCore::FrameLoader::endIfNotLoadingMainResource):
- (WebCore::FrameLoader::checkCompleted):
- (WebCore::FrameLoader::requestObject):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
+ Tests: accessibility/aria-disabled.html
+ accessibility/aria-hidden.html
+ accessibility/aria-readonly.html
-2009-03-02 Xan Lopez <xan@gnome.org>
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaIsHidden):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::isEnabled):
+ (WebCore::AccessibilityRenderObject::canSetValueAttribute):
+ * accessibility/AccessibilityRenderObject.h:
+ * html/HTMLAttributeNames.in:
- Reviewed by Mark Rowe.
+2009-06-26 Brett Wilson <brettw@chromium.org>
- https://bugs.webkit.org/show_bug.cgi?id=24287
- [GTK] Move auth dialog feature to WebKit/
+ Reviewed by David Levin.
- Remove WebKitSoupAuthDialog files from build and stop using it.
+ https://bugs.webkit.org/show_bug.cgi?id=26759
- * GNUmakefile.am:
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ensureSessionIsInitialized):
- * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
- * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
+ GIFImageDecoder is broken.
-2009-03-04 Simon Fraser <simon.fraser@apple.com>
+ Make the GIFImageDecoder.repetitionCount function const to match the
+ base class. The mismatched definitions were causing the function to not
+ get called.
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24361
-
- Reinstate code that sets result.innerNode when hitTest() returns true,
- but never filled in the innerNode. Fixes hit testing of generated content.
-
- Test: fast/css-generated-content/hit-test-generated-content.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestContents):
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::repetitionCount):
+ * platform/image-decoders/gif/GIFImageDecoder.h:
-2009-03-04 Adam Barth <abath@webkit.org>
+2009-06-26 Chris Marrin <cmarrin@apple.com>
- Reviewed by Alexey Proskuryakov.
+ Reviewed by Simon Fraser <simon.fraser@apple.com>.
- https://bugs.webkit.org/show_bug.cgi?id=24356
+ Additional fix for https://bugs.webkit.org/show_bug.cgi?id=26651
- Fix WebKit style for allowUniversalAccessFromFileURLs.
+ The flag should always default to true to avoid it getting set
+ to false in a build with accelerated compositing turned off
+ and then disabling accelerated compositing when subsequently
+ running a build with it turned on.
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
* page/Settings.cpp:
(WebCore::Settings::Settings):
- (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
- * page/Settings.h:
- (WebCore::Settings::allowUniversalAccessFromFileURLs):
-
-2009-03-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
-
- I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
- consolidated some of the various decision making pieces of the Cache into the new method
- FrameLoader::cachePolicy().
-
- Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
- is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
- same URL for this image every time and expects it to be reloaded with each new card.
-
- The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
- is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
- condition for returning CachePolicyReload.
-
-2009-03-04 Timothy Hatcher <timothy@apple.com>
-
- * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
- "LOCAL STORAGE" and "SESSION STORAGE".
-
-2009-03-04 Timothy Hatcher <timothy@apple.com>
-
- Fix a regression where the Web Inspector console would not animate
- in or out correctly.
-
- Reviewed by Anders Carlsson.
-
- * inspector/front-end/inspector.css: Move a z-index to a child element
- to get the correct stacking order during the animation.
-
-2009-03-03 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
-
- Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
- the final position against the y position estimate until after the clear has happened. This gets rid
- of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
-
- Reviewed by Dan Bernstein
-
- Added fast/block/float/nested-clearance.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::clearFloatsIfNeeded):
- (WebCore::RenderBlock::estimateVerticalPosition):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::getClearDelta):
- * rendering/RenderBlock.h:
-
-2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
-
- Reviewed by Simon Hausmann.
-
- Improvement to 3d transformations rendering in QtWebKit. QTransform is used
- instead of QMatrix. This allows perspective transformations since QTransform is
- a true 3x3 matrix.
-
- * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
- (WebCore::GraphicsContext::getCTM):
- (WebCore::GraphicsContext::restorePlatformState):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::translate):
- (WebCore::GraphicsContext::rotate):
- (WebCore::GraphicsContext::scale):
- (WebCore::GraphicsContext::concatCTM):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::Image::drawPattern):
- * platform/graphics/qt/PathQt.cpp:
- (WebCore::Path::translate):
- (WebCore::Path::transform):
- * platform/graphics/qt/PatternQt.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * platform/graphics/qt/TransformationMatrixQt.cpp:
- (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
- to QMatrix with one to QTransform.
- * platform/graphics/transforms/TransformationMatrix.h:
- * platform/graphics/qt/FontQt.cpp:
-
-2009-02-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=24151
- Fix Qt/S60 build break
-
- * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
- * platform/qt/FileSystemQt.cpp: Ditto
- (WebCore::unloadModule):
-
-2009-03-03 Mike Belshe <mike@belshe.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=21939
- Uninitialized ExceptionCode in DOMWindow::postMessage
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::postMessage):
-
-2009-03-03 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
-
- Reviewed by Mark Rowe.
-
- The fix is to add INSTALLHDRS_COPY_PHASE = YES and
- INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
- sure various build phase scripts work with the installhdrs build
- phase.
-
- * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
- based on PLATFORM_NAME to work around the missing definition on
- Tiger.
- * Configurations/WebCore.xcconfig: Added
- JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
- the "Generate Derived Sources" script. Added
- INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
-
- * WebCore.xcodeproj/project.pbxproj:
- - Added shell code to prevent running "Check For Global
- Initializers", "Check For Exit Time Destructors" and "Check
- For Weak VTables" scripts during the installhdrs build phase.
- - Made "Generate Derived Sources" work for the installhdrs build
- phase. Also simplified setting of CREATE_HASH_TABLE by using
- JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
-
-2009-03-02 Adam Langley <agl@google.com>
-
- Reviewed by Darin Fisher.
-
- Chromium Linux: Switch to using Skia to render widgets.
-
- In order to sandbox the Chromium renderer on Linux we need to remove
- the X connection. GTK cannot render without an X connection so, for
- now, we render widgets ourselves.
-
- Previously didn't use anti-alias fonts in order to match Windows font
- rendering exactly. This was helpful when bootstrapping our layout
- tests. Now, however, we are ready to enable it.
-
- https://bugs.webkit.org/show_bug.cgi?id=24244
-
- * platform/chromium/ScrollbarThemeChromium.cpp:
- (WebCore::ScrollbarThemeChromium::buttonSize):
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- (WebCore::ScrollbarThemeChromium::scrollbarThickness):
- (WebCore::ScrollbarThemeChromium::paintTrackPiece):
- (WebCore::ScrollbarThemeChromium::paintButton):
- (WebCore::ScrollbarThemeChromium::paintThumb):
- * platform/graphics/chromium/FontPlatformDataLinux.cpp:
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::PlatformContextSkia):
- (PlatformContextSkia::~PlatformContextSkia):
- * platform/graphics/skia/PlatformContextSkia.h:
- * rendering/RenderThemeChromiumGtk.cpp: Removed.
- * rendering/RenderThemeChromiumGtk.h: Removed.
- * rendering/RenderThemeChromiumLinux.cpp: Added.
- * rendering/RenderThemeChromiumLinux.h: Added.
-
-2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24261
- Fix return types.
-
- Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
-
- * bindings/v8/V8Binding.h:
- (WebCore::toInt32): change return type to int
- (WebCore::toFloat): change return type to float.
-
-2009-03-03 Anders Carlsson <andersca@apple.com>
-
- Reviewed by John Sullivan.
-
- https://bugs.webkit.org/show_bug.cgi?id=22884
- <rdar://problem/6449783>
- modified layout test crashes Safari
-
- Null check NPStream before dereferencing it.
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::destroyStream):
-
-2009-03-03 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- Fix for <rdar://problem/6641045>
- Don't call QTKit to get movie properties until movie metadata has been loaded.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
- (WebCore::MediaPlayerPrivate::play): Ditto.
- (WebCore::MediaPlayerPrivate::pause): Ditto.
- (WebCore::MediaPlayerPrivate::duration): Ditto.
- (WebCore::MediaPlayerPrivate::currentTime): Ditto.
- (WebCore::MediaPlayerPrivate::seek): Ditto.
- (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
- (WebCore::MediaPlayerPrivate::paused): Ditto.
- (WebCore::MediaPlayerPrivate::seeking): Ditto.
- (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
- (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
- (WebCore::MediaPlayerPrivate::setVolume): Ditto.
- (WebCore::MediaPlayerPrivate::setRate): Ditto.
- (WebCore::MediaPlayerPrivate::dataRate): Ditto.
- (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
- (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
-
-2009-03-03 Kevin McCullough <kmccullough@apple.com>
-
- - Spelling fix.
-
- * page/Console.cpp:
- (WebCore::Console::profile):
-
-2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=23657
- Remove Database API callback IDLs from the project.
- They were removed in r40633.
-
- * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
-
-2009-03-03 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6639110> console.profile() doesn't work without a title
-
- * page/Console.cpp:
- (WebCore::Console::profile): If there is no title assume this is a user
- initiated profile and give it the next incremented title name.
-
-2009-03-03 Timothy Hatcher <timothy@apple.com>
-
- Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
- the console code and refactored things to have fewer code paths and duplication.
-
- rdar://problem/6367127
- https://bugs.webkit.org/show_bug.cgi?id=24329
-
- Reviewed by Kevin McCullough.
-
- Test: manual-tests/inspector/console-dir.html
-
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
- to fix an ASSERT about using a wrapper from the wrong ExecState.
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
- (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
- When forceObjectFormat is true, the only formatter used is _formatobject.
- (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
- (WebInspector.Console.prototype._formatstring): Ditto.
- (WebInspector.Console.prototype._formatregexp): Ditto.
- (WebInspector.Console.prototype._formatarray): Ditto.
- (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
- (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
- (WebInspector.Console.prototype._formaterror): Remove the inline argument.
- (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
- simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
- (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
- (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
- (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
- (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
- * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
- * inspector/front-end/utilities.js:
- (Object.type): Return "node" for Node objects.
- (Object.describe): Handle the "node" type.
- * page/Console.cpp:
- (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
- (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
- * page/Console.h:
- (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
-
-2009-03-03 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24325
- Crash on replacing document contents during drop.
-
- Makes sure a node is in the document during a move before using it.
-
- Test: fast/events/crash-on-mutate-during-drop.html
-
- * editing/MoveSelectionCommand.cpp:
- (WebCore::MoveSelectionCommand::doApply):
-
-2009-03-03 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23028
- Enable dynamic web font support to Chromium on Windows.
- Files that were omitted by mistake in the latest patch
- that was landed.
-
- * loader/CachedFont.cpp:
- (WebCore::CachedFont::~CachedFont):
- (WebCore::CachedFont::ensureCustomFontData):
- (WebCore::CachedFont::platformDataFromCustomData):
- (WebCore::CachedFont::allClientsRemoved):
- * platform/graphics/chromium/FontCustomPlatformData.cpp:
- (WebCore::EOTStream::EOTStream):
- (WebCore::createFontCustomPlatformData):
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::EOTStream::EOTStream):
- (WebCore::createFontCustomPlatformData):
-
-2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=16826
- [Gtk] Implement WebKitDownload
-
- Make the Soup backend able to handle requests without a frame,
- since we may have such things now that we support downloads.
-
- * platform/network/ResourceHandleInternal.h:
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::start):
-
-2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24331
- Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
-
- * bindings/v8/custom/V8AttrCustom.cpp: Added.
- * bindings/v8/custom/V8CustomBinding.cpp: Added.
- * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
- * bindings/v8/custom/V8ElementCustom.cpp: Added.
- * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
- * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
-
-2009-03-03 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6616664> - Quick looks of various file types is broken
-
- In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
- for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
- overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
- Partially reverted behavior to always set the mainDocumentURL in situations when we would've
- before that patch.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::addExtraFieldsToRequest):
-
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::setMainDocumentURL):
-
-2009-03-03 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24256
-
- Added a WebCoreForceSoftwareAnimation flag.
-
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::forceSoftwareAnimation):
- (WebCore::GraphicsLayerCA::setOpacity):
- (WebCore::GraphicsLayerCA::animateTransform):
- (WebCore::GraphicsLayerCA::animateFloat):
-
-2009-03-02 Chris Marrin <cmarrin@apple.com>
+2009-06-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=24257
-
- Added prototype properties for several classes with constructors that
- were missing them, including the one mentioned in the bug.
+ Followup for the fix for <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
- Test: fast/dom/Window/custom-constructors.html
+ Now that other MIME type correction stuff is in our swizzled method, Tiger needs it too!
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseWebKitCSSMatrix):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
- (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- * bindings/js/JSWebKitCSSMatrixConstructor.h:
- * bindings/js/JSWebKitPointConstructor.cpp:
- (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- * bindings/js/JSWorkerConstructor.cpp:
- (WebCore::JSWorkerConstructor::JSWorkerConstructor):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
+ * platform/network/mac/WebCoreURLResponse.h:
-2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
+2009-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
- https://bugs.webkit.org/show_bug.cgi?id=24321
- Add V8 bindings headers.
-
- * bindings/v8/V8Binding.h: Added.
- * bindings/v8/V8Proxy.h: Added.
- * bindings/v8/custom/V8CustomBinding.h: Added.
- * bindings/v8/custom/V8CustomEventListener.h: Added.
-
-2009-03-03 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23803
- Fix an 'off-by-1' error in ChromiumWin's font fallback.
-
- * platform/graphics/chromium/FontCacheChromiumWin.cpp:
- (WebCore::FontCache::getFontDataForCharacters):
+ https://bugs.webkit.org/show_bug.cgi?id=26732
-2009-03-03 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- http://bugs.webkit.org/show_bug.cgi?id=23028
- Enable dynamic web font support to Chromium on Windows: Part 1
- - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
- from platform/graphics/win because both Windows port and Chromium Windows
- port will use them.
- - Adjust WebCore.vcproj accordingly.
+ For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376,
+ combine LocalStorage and SessionStorage into StorageNamespace. The
+ synching code (for LocalStorage) has already been removed, so these
+ classes are now very similar. All they do is essentially contain a
+ logical grouping of origins that are attached to specific contexts
+ (be it PageGroups for LocalStorage and Page for SessionStorage).
+ * GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
- * platform/graphics/opentype: Added.
- * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
- * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
- * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
- * platform/graphics/win/OpenTypeUtilities.h: Removed.
-
-2009-03-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24312
-
- Take 3D transforms into account when hit testing:
-
- 1. Maintain a bit on each RenderLayer that is set when the layer
- has 3d descendants, so that we know when to fall into the slow
- hit testing path.
-
- 2. Make a ref-counted HitTestingTransformState, which is used to store
- an accumulated transform, and the hit test point, and hitTestRect
- in the plane of the ancestor non-3d ('flattening') layer.
-
- It's ref-counted so we can heap allocate it (to avoid stack bloat),
- and avoid copying when hitTestLayer calls itself after applying the transform.
-
- 3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
- 3D transforms, or to do deep depth-testing when traversing a preserves-3d
- hierarchy. When hit, layers compute a z-offset from the ancestor flattening
- layer, which allows for correct depth testing.
-
- The existing early-return codepath is unaffected when there are no 3d transforms
- and no preserve-3d.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
- (WebCore::RenderLayer::update3DTransformedDescendantStatus):
- (WebCore::RenderLayer::hitTest):
- (WebCore::computeZOffset):
- (WebCore::RenderLayer::createLocalTransformState):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::hitTestContents):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::preserves3D):
- (WebCore::RenderLayer::has3DTransform):
- (WebCore::RenderLayer::setHas3DTransformedDescendant):
- (WebCore::RenderLayer::has3DTransformedDescendant):
- * rendering/RenderLayerBacking.cpp:
- * rendering/TransformState.cpp:
- (WebCore::TransformState::flatten):
- (WebCore::TransformState::mappedPoint):
- (WebCore::HitTestingTransformState::move):
- (WebCore::HitTestingTransformState::applyTransform):
- (WebCore::HitTestingTransformState::flatten):
- (WebCore::HitTestingTransformState::mappedPoint):
- (WebCore::HitTestingTransformState::mappedQuad):
- * rendering/TransformState.h:
- (WebCore::TransformState::TransformState):
- (WebCore::HitTestingTransformState::create):
- (WebCore::HitTestingTransformState::move):
- (WebCore::HitTestingTransformState::HitTestingTransformState):
-
-2009-03-03 Brett Wilson <brettw@chromium.org>
-
- Fix uninitialized memory reads in the Chromium Windows transparency
- code that were identified by Purify,
-
- Reviewed by Darin Fisher.
-
- * platform/graphics/chromium/TransparencyWin.cpp:
- (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
- (WebCore::TransparencyWin::initializeNewContext):
-
-2009-03-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24312
-
- Factor the code that compute a transform relative to the container
- into RenderObject::transformFromContainer().
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToAbsolutePoint):
- (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::transformFromContainer):
- * rendering/RenderObject.h:
-
-2009-03-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24317
-
- Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
- the superclass found a node, otherwise we set the innerNode of the
- HitTestResult, but don't actually report that we found a hit.
-
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::nodeAtPoint):
-
-2009-03-03 Onne Gorter <onne.gorter@avinity.net>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23707
- resizing plugins does not work, because the plugin never gets informed
-
- Make gtk plugins resize correctly, by sending them the setwindow event
- correctly. Also ensure that all plugin eventing is done with correct
- locking/calling. Mostly copied from mac implementation.
-
- manual test: manual-tests/gtk/plugin-resize-scroll.html
-
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::dispatchNPEvent):
- ensure locking/calling for NPEvents
- (WebCore::PluginView::updatePluginWidget):
- if something changed, let setNPWindowIfNeeded handle it
- (WebCore::PluginView::paint):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- ensure calling conventions
- (WebCore::PluginView::setNPWindowRect):
- just pass control to setNPWindowIfNeeded
- (WebCore::PluginView::setNPWindowIfNeeded):
- event the plugin correctly of new window
- (WebCore::PluginView::init):
- init through the new setup
-
-2009-03-03 Mike Belshe <mike@belshe.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24311
- Make IDL returning DOMObject use [V8Custom]
-
- * dom/Document.idl:
- * html/HTMLCanvasElement.idl:
-
-2009-03-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Adele Peterson
-
- https://bugs.webkit.org/show_bug.cgi?id=24313
-
- If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
- HitTestResult, then it had better well return |true|. And m_innerBlock
- could never have been set as the hit node by the superclass, because
- the superclass knows nothing about m_innerBlock.
-
- Test: fast/forms/input-hit-test-border.html
-
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
-
-2009-03-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Enable Geolocation (except on Tiger and Leopard).
-
- * Configurations/WebCore.xcconfig:
-
-2009-03-02 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Adele Peterson.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=24307
- Null out m_highlightedNode on hideHighlight().
- Ran WebCore/manual-tests/inspector/highlight-nodes.html.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::hideHighlight):
-
-2009-03-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for <rdar://problem/6507404> Add Geolocation support.
-
- This is not yet turned on for any Mac platform.
-
* WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
* page/Chrome.cpp:
- (WebCore::Chrome::shouldAllowGeolocationForFrame):
- * page/Chrome.h:
- * page/ChromeClient.h:
- (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
- * page/Geolocation.cpp:
- (WebCore::Geolocation::Geolocation):
- (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
- will not be alive at this point.
- (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
- return a PERMISSION_DENIED if not.
- (WebCore::Geolocation::watchPosition): Ditto.
- (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
- to allow geolocation and cache the result.
- * page/Geolocation.h:
- (WebCore::Geolocation::):
- * platform/GeolocationService.cpp:
- * platform/GeolocationService.h:
- (WebCore::GeolocationService::~GeolocationService):
- (WebCore::GeolocationService::stopUpdating):
- * platform/mac/GeolocationServiceMac.h: Added.
- (WebCore::GeolocationServiceMac::lastPosition):
- (WebCore::GeolocationServiceMac::lastError):
- * platform/mac/GeolocationServiceMac.mm: Added.
- (WebCore::GeolocationService::create):
- (WebCore::GeolocationServiceMac::GeolocationServiceMac):
- (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
- (WebCore::GeolocationServiceMac::startUpdating):
- (WebCore::GeolocationServiceMac::stopUpdating):
- (WebCore::GeolocationServiceMac::suspend):
- (WebCore::GeolocationServiceMac::resume):
- (WebCore::GeolocationServiceMac::positionChanged):
- (WebCore::GeolocationServiceMac::errorOccurred):
- (-[WebCoreCoreLocationObserver initWithCallback:]):
- (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
- (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
-
-2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
-
- Build fixes for wxWidgets Mac trunk build.
-
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
- (GetTextExtent):
- * webcore-wx.bkl:
-
-2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
-
- wxGTK missing header build fix.
-
- * platform/wx/wxcode/gtk/fontprops.cpp:
-
-2009-03-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adam Roben.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21811
- REGRESSION: Windows Build Not Selecting Proper Font
-
- * platform/graphics/win/FontCacheWin.cpp:
- (WebCore::createGDIFont): Added back code to verify that the created
- HFONT has the requested face name.
-
-2009-03-02 Timothy Hatcher <timothy@apple.com>
-
- Fixes a regression caused by splitting the input and output of console commands.
-
- https://bugs.webkit.org/show_bug.cgi?id=24293
-
- Reviewed by Kevin McCullough.
-
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
- normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
-
-2009-03-02 Timothy Hatcher <timothy@apple.com>
-
- Make exception messages and logged Error objects display consistently.
-
- https://bugs.webkit.org/show_bug.cgi?id=18983
-
- Reviewed by Adam Roben.
-
- * English.lproj/localizedStrings.js: Remove a string for line numbers.
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
- boolean to the ConsoleCommandResult constructor and don't pass level.
- (WebInspector.Console.prototype._formatnode): Fix a className typo.
- (WebInspector.Console.prototype._formaterror): Add an error-message
- classed span around the message to show in red and remove the
- console-message-url class from the link so it doesn't float right.
- Instead enclose the link in parentheses and use displayNameForURL
- to shorten the URL in the link.
- (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
- how line numbers are shown since link underlining a string with
- parentheses looks bad.
- (WebInspector.ConsoleCommandResult): Take an exception boolean flag
- instead of a level and get line and URL based on that flag.
- * inspector/front-end/inspector.css: Tweaks to the styles.
-
-2009-03-02 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Adele Peterson.
-
- Bug 24048: extra windows button padding doesn't apply when there's no appearance
- <https://bugs.webkit.org/show_bug.cgi?id=24048>
-
- Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
-
- No tests added as existing tests already cover this behavior.
-
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::setupInnerStyle):
- * rendering/RenderTheme.cpp:
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::buttonInternalPaddingLeft):
- (WebCore::RenderTheme::buttonInternalPaddingRight):
- (WebCore::RenderTheme::buttonInternalPaddingTop):
- * rendering/RenderThemeChromiumGtk.cpp:
- (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
- (WebCore::RenderThemeWin::buttonInternalPaddingRight):
- (WebCore::RenderThemeWin::buttonInternalPaddingTop):
- (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
- * rendering/RenderThemeChromiumGtk.h:
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
- (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
- (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
- (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
- * rendering/RenderThemeChromiumWin.h:
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
- (WebCore::RenderThemeWin::buttonInternalPaddingRight):
- (WebCore::RenderThemeWin::buttonInternalPaddingTop):
- (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
- * rendering/RenderThemeWin.h:
-
-2009-03-02 Adam Treat <adam.treat@torchmobile.com>
-
- Build fix for Qt port. Remove unnecessary assert.
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::putImageData):
-
-2009-03-02 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24227
- Ensure that the checkForSolidColor() optimization is correctly triggered
- for all cases of drawPattern. Currently, the optimization was not triggered
- when the check had not been previously performed via a request for the
- image's NativeImagePtr.
-
- Implement the Qt version of the checkForSolidColor() method. Combined with
- the bug fix this reduces the time it takes to draw a repeating background
- of a 1x1 image from ~50msecs to ~0msecs on my machine.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/BitmapImage.h:
- (WebCore::BitmapImage::mayFillWithSolidColor):
- * platform/graphics/Image.h:
- (WebCore::Image::mayFillWithSolidColor):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-03-02 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed build fix; adding missing files to EXTRA_DIST, so that
- they show up in the tarball.
-
- * GNUmakefile.am:
-
-2009-03-02 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Holger Freyther.
-
- Added putImageData to Qt. Discussed with Ariya Hidayat.
-
- [Qt] lacks putImageData support in Canvas
- https://bugs.webkit.org/show_bug.cgi?id=22186
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::putImageData):
-
-2009-03-02 Timothy Hatcher <timothy@apple.com>
-
- Show exception messages again when evaluating bad expressions in the
- Web Inspector's console.
-
- https://bugs.webkit.org/show_bug.cgi?id=19890
-
- Reviewed by Oliver Hunt.
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
- Fix the order in which the exception is set and cleared now that the
- exception is stored in the shared GlobalData, not per ExecState.
-
-2009-02-28 Timothy Hatcher <timothy@apple.com>
-
- Make input in the Web Inspector console print before any output
- that might be added by the called function.
-
- https://bugs.webkit.org/show_bug.cgi?id=19931
-
- Reviewed by Oliver Hunt.
-
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype._enterKeyPressed): Add the command
- message before evaluating the result. Associate the originating
- command to the result, so if they are adjacent there is no divider.
- (WebInspector.ConsoleCommand): No longer take a result.
- (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
- code removed since it isn't used now.
- (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
- (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
- Call the ConsoleMessage toMessageElement and add a style class.
- * inspector/front-end/inspector.css: Add a new style class for
- adjacent results to hide the divider. Also tweak the position of
- the disclosure triangle for objects to not use the left margin.
-
-2009-03-01 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
- <https://bugs.webkit.org/show_bug.cgi?id=24282>
-
- When fetching an array of elements with a range, attachment views need to be returned
- instead of the actual attachment.
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
-
-2009-03-01 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
- <https://bugs.webkit.org/show_bug.cgi?id=24251>
-
- Make RenderObject::positionForCoordinate non-virtual and
- RenderObject::positionForPoint virtual in preparation for
- removing positionFor* from RenderObject/RenderText.
-
- * page/Frame.cpp:
- (WebCore::Frame::visiblePositionForPoint):
- * rendering/RenderBR.cpp:
- (WebCore::RenderBR::positionForPoint):
- * rendering/RenderBR.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::positionForPoint):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::positionForPoint):
- * rendering/RenderBox.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::positionForPoint):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::positionForCoordinates):
- (WebCore::RenderObject::positionForPoint):
- * rendering/RenderObject.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::positionForPoint):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::positionForPoint):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::positionForPoint):
- * rendering/RenderText.h:
-
-2009-03-01 Larry Ewing <lewing@novell.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24080
- NPN_GetValue casting to the wrong type and writing outside bounds
-
- Make sure to cast the value to the correct type so that only
- memory owned by the value is written to.
-
- * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
- * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
- * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic):
- (PluginView::getValue):
-
-2009-03-01 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24197 and
- https://bugs.webkit.org/show_bug.cgi?id=23512
-
- The Windows version of cgColor() is conditionally compiled using
- !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
- can use the OS X version instead of the Windows version.
-
- Also rename cgColor() -> createCGColor()
-
- No observable change in behavior, so no test.
-
- * platform/graphics/Color.h:
- * platform/graphics/cg/ColorCG.cpp:
- (WebCore::createCGColor):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::setPlatformShadow):
- * platform/graphics/mac/ColorMac.mm:
- (WebCore::createCGColor):
- * platform/graphics/mac/GraphicsContextMac.mm:
- (WebCore::GraphicsContext::drawFocusRing):
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::setLayerBorderColor):
- (WebCore::setLayerBackgroundColor):
- (WebCore::GraphicsLayerCA::setBackgroundColor):
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- (WebCore::GraphicsContext::drawFocusRing):
- * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
- (WebCore::ciColor):
-
-2009-03-01 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24271: XMLHttpRequest needs js bindings for Workers.
- <https://bugs.webkit.org/show_bug.cgi?id=24271>
-
- Tests: http/tests/xmlhttprequest/workers/methods-async.html
- http/tests/xmlhttprequest/workers/methods.html
-
- * bindings/js/JSWorkerContextBase.cpp:
- (WebCore::JSWorkerContextBase::getOwnPropertySlot):
- (jsWorkerContextBaseXMLHttpRequest):
- (setJSWorkerContextBaseXMLHttpRequest):
- Expose XMLHttpRequest to Workers.
-
- * bindings/js/JSWorkerContextBase.h:
-
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- (WebCore::constructXMLHttpRequest):
- (WebCore::JSXMLHttpRequestConstructor::mark):
- Removed the dependencies on Document.
-
- * bindings/js/JSXMLHttpRequestConstructor.h:
- (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
- * dom/EventException.idl:
- * dom/EventListener.idl:
- Change to have the NoStaticTables attribute since they are used from XHR.
-
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::workerContextDidFinishLoading):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
- Fixed identifier to be unsigned long.
-
- * loader/WorkerThreadableLoader.h:
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::workerThread):
- Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
-
- * xml/XMLHttpRequestUpload.cpp:
-
- * xml/XMLHttpRequest.idl:
- * xml/XMLHttpRequestException.idl:
- * xml/XMLHttpRequestProgressEvent.idl:
- * xml/XMLHttpRequestUpload.idl:
- Change to have the NoStaticTables attribute since they are used from XHR.
-
-2009-03-01 Horia Olaru <olaru@adobe.com>
-
- Adding manual debugger test cases for bug.
-
- https://bugs.webkit.org/show_bug.cgi?id=21073
-
- Reviewed by Kevin McCullough.
-
- * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
- * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
- * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
- * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
- * manual-tests/inspector/resources/loop-statements.js: Added.
-
-2009-03-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
-
- Test: fast/events/scroll-during-zoom-change.html
-
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle): Pause scheduled events during style
- reclaculation. Changes to the zoom property result in scroll events
- being generated during style recalc, and those events need to be
- deferred until the render tree is consistent.
- * page/FrameView.cpp:
- (WebCore::FrameView::layout): Changed to account for a case in which the
- post-layout tasks trigger a nested layout, which reactivates the
- post-layout task timer.
-
-2009-03-01 Ross Boucher <rboucher@gmail.com>
-
- Alphabetically sort scripts in the Script's panel file popup menu.
-
- https://bugs.webkit.org/show_bug.cgi?id=23395
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- * inspector/front-end/utilities.js:
- (insertionIndexForObjectInListSortedByFunction):
- (indexOfObjectInListSortedByFunction):
-
-2009-03-01 Yael Aharon <yael.aharon@nokia.com>
-
- Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
- when creating databases, localStorage or sessionStorage. Changing document.domain
- should have no affect on databases, localStorage and sessionStorage in Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=23844
-
- Reviewed by Timothy Hatcher.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::addDOMStorageScriptResource):
- (WebCore::InspectorController::didUseDOMStorage):
- * storage/Database.cpp:
- (WebCore::Database::openDatabase):
-
-2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Avoid leaking errors when reporting GIO errors.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
-
-2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Fixes crash when the GIO backend is given the URI for a directory.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::networkErrorForFile):
-
-2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24261
- Fix V8 custom binding scrubbing error.
-
- Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
- Test: traversal/exception-forwarding.html
- TesT: traversal/stay-within-root.html
-
- * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- * bindings/v8/custom/V8NodeIteratorCustom.cpp:
- (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
- * bindings/v8/custom/V8TreeWalkerCustom.cpp:
- (WebCore::toV8): Ditto.
-
-2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24261
- Fix V8 custom binding scrubbing error.
-
- Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- (WebCore::cssPropertyName): Remove dubious checks, left over from
- incomplete conversion of parameter from pointer to pass-by-ref.
- (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
- (WebCore::NAMED_PROPERTY_SETTER): Ditto.
-
-2009-02-28 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=24263
- [GTK] ref ResourceHandle until we are finished with it
-
- Add a ref to the ResourceHandle in startHttp so we can keep it
- alive untill all callbacks have been executed, and unref it when
- soup tells us it's done with the SoupMessage (in
- finishedCallback). Fixes a number of crashes when calling
- didReceiveData whould crash because of the handle dying.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::finishedCallback):
- (WebCore::ResourceHandle::startHttp):
-
-2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24226
- [SOUP] HTTP status text is never set
-
- Set HTTP status text to SoupMessage reason_phrase.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::fillResponseFromMessage):
-
-2009-02-28 Dan Bernstein <mitz@apple.com>
-
- - fix malformed project file
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-02-28 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=23848
- <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
-
- Test: fast/layers/inline-dirty-z-order-lists.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
- layer's and its stacking context's z-order lists when the layer's
- z-index or visibility change from here...
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
- it will apply to RenderInline too.
-
-2009-02-27 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by David Hyatt.
-
- Don't include TextResourceDecoder.h in Document.h
-
- This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
- when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
-
- * dom/Document.cpp:
- (WebCore::Document::displayStringModifiedByEncoding):
- (WebCore::Document::displayBufferModifiedByEncoding):
- * dom/Document.h:
- * WebCore.base.exp:
-
-2009-02-27 Matt Pennig <pennig@apple.com>
-
- Reviewed by David Hyatt.
-
- Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
- "Fixed elements have 0 as an offsetLeft property"
-
- Code also brings offsetLeft/Top in full conformance with the spec.
- Added two tests, one for fixed-position elements, and one for <html>.
-
- Tests: fast/dom/Element/fixed-position-offset-parent.html
- fast/dom/Element/offsetLeft-offsetTop-html.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::offsetLeft):
- (WebCore::RenderBoxModelObject::offsetTop):
-
-2009-02-27 Dean Jackson <dino@apple.com>
-
- Reviewed by Simon Fraser.
-
- renderer()->hasTransform() returns true for elements
- with perspective, but no transform, so test for transform
- when hit testing. This fixes ASSERT from
- https://bugs.webkit.org/show_bug.cgi?id=24252
-
- Test: transforms/no_transform_hit_testing.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
-
-2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Fisher.
-
- Fix scrubbing error -- a reversed condition.
-
- * bindings/v8/ScriptValue.h:
- (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
-
-2009-02-27 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Add confirmMessageFromWorkerObject to WorkerObjectProxy.
- https://bugs.webkit.org/show_bug.cgi?id=24152
-
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerContextTask::performTask):
- (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
- * workers/WorkerMessagingProxy.h:
- * workers/WorkerObjectProxy.h:
-
-2009-02-27 Anders Carlsson <andersca@apple.com>
-
- Reviewed by David Hyatt.
-
- Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
- because it leads to assertion failures in the Mac port.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/BitmapImage.h:
- (WebCore::BitmapImage::mayFillWithSolidColor):
- * platform/graphics/Image.h:
- (WebCore::Image::mayFillWithSolidColor):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-02-27 Adam Barth <abarth@webkit.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20249
-
- Add a preference to allow universal access from local URLs to mitigate
- some attacks. Some clients still want to allow this access, so we
- expose this as a preference.
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::SecurityOrigin):
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
- * page/Settings.h:
- (WebCore::Settings::allowUniversalAccessFromFileUrls):
-
-2009-02-27 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24229
- If an image has no alpha channel there is no reason to use SourceOver.
-
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::Image::drawPattern):
- (WebCore::BitmapImage::draw):
-
-2009-02-27 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Eric Seidel and Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24227
- Ensure that the checkForSolidColor() optimization is correctly triggered
- for all cases of drawPattern. Currently, the optimization was not triggered
- when the check had not been previously performed via a request for the
- image's NativeImagePtr.
-
- Implement the Qt version of the checkForSolidColor() method. Combined with
- the bug fix this reduces the time it takes to draw a repeating background
- of a 1x1 image from ~50msecs to ~0msecs on my machine.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/BitmapImage.h:
- (WebCore::BitmapImage::mayFillWithSolidColor):
- * platform/graphics/Image.h:
- (WebCore::Image::mayFillWithSolidColor):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::checkForSolidColor):
-
-2009-02-27 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Zack Rusin.
-
- Added support for gradients and pattern on Fonts for Qt.
-
- [Qt] gradients and patterns for FontQt
- https://bugs.webkit.org/show_bug.cgi?id=24243
-
- * platform/graphics/qt/FontQt.cpp:
- (WebCore::Font::drawComplexText):
-
-2009-02-27 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
- https://bugs.webkit.org/show_bug.cgi?id=24113
-
- * workers/WorkerMessagingProxy.cpp:
-
-2009-02-27 Yael Aharon <yael.aharon@nokia.com>
-
- Added a refresh button to storage views.
-
- https://bugs.webkit.org/show_bug.cgi?id=24040
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/DOMStorageItemsView.js:
- (WebInspector.DOMStorageItemsView):
- (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
- (WebInspector.DOMStorageItemsView.prototype.update):
- (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
- * inspector/front-end/DatabaseTableView.js:
- (WebInspector.DatabaseTableView):
- (WebInspector.DatabaseTableView.prototype.get statusBarItems):
- (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
- * inspector/front-end/DatabasesPanel.js:
- (WebInspector.DatabasesPanel):
- (WebInspector.DatabasesPanel.prototype.get statusBarItems):
- (WebInspector.DatabasesPanel.prototype.reset):
- (WebInspector.DatabasesPanel.prototype.showDatabase):
- (WebInspector.DatabasesPanel.prototype.showDOMStorage):
- (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
- * inspector/front-end/inspector.css:
-
-2009-02-27 Yael Aharon <yael.aharon@nokia.com>
-
- Added support for editing/deleting localStorage and sessionStorage items
- directly from Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=23866.
-
- Reviewed by Timothy Hatcher.
-
- * WebCore.vcproj/WebCore.vcproj:
- * inspector/front-end/DOMStorageDataGrid.js: Added.
- (WebInspector.DOMStorageDataGrid):
- (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
- (WebInspector.DOMStorageDataGrid.prototype._startEditing):
- (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
- (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
- (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
- * inspector/front-end/DOMStorageItemsView.js:
- (WebInspector.DOMStorageItemsView):
- (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
- (WebInspector.DOMStorageItemsView.prototype.hide):
- (WebInspector.DOMStorageItemsView.prototype.update):
- (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
- * inspector/front-end/DatabasesPanel.js:
- (WebInspector.DatabasesPanel):
- (WebInspector.DatabasesPanel.prototype.get statusBarItems):
- (WebInspector.DatabasesPanel.prototype.reset):
- (WebInspector.DatabasesPanel.prototype.showDOMStorage):
- (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
- (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/inspector.css:
- * inspector/front-end/inspector.html:
-
-2009-02-26 Brett Wilson <brettw@chromium.org>
-
- Fix Windows transparency for the Chromium port. Implement a helper
- class for handling transparency on Windows. It allows semitransparent
- ClearType and semitransparent form controls by making new layers in the
- background.
-
- It also replaces the "ThemeHelper" which allows better
- scaling and transforms on Windows form controls. In addition to the
- functionality that the ThemeHelper did, but additionally handles the
- antialiasing properly so that the form controls aren't composited on a
- white square.
-
- https://bugs.webkit.org/show_bug.cgi?id=24101
-
- Reviewed by Eric Seidel.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
- (WebCore::Font::drawGlyphs):
- * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
- * platform/graphics/chromium/ThemeHelperChromiumWin.h:
- * platform/graphics/chromium/TransparencyWin.cpp: Added.
- (WebCore::):
- (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
- (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
- (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
- (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
- (WebCore::TransparencyWin::TransparencyWin):
- (WebCore::TransparencyWin::~TransparencyWin):
- (WebCore::TransparencyWin::init):
- (WebCore::TransparencyWin::computeLayerSize):
- (WebCore::TransparencyWin::setupLayer):
- (WebCore::TransparencyWin::setupLayerForNoLayer):
- (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
- (WebCore::TransparencyWin::setupLayerForTextComposite):
- (WebCore::TransparencyWin::setupLayerForWhiteLayer):
- (WebCore::TransparencyWin::setupTransform):
- (WebCore::TransparencyWin::setupTransformForKeepTransform):
- (WebCore::TransparencyWin::setupTransformForUntransform):
- (WebCore::TransparencyWin::setupTransformForScaleTransform):
- (WebCore::TransparencyWin::setTextCompositeColor):
- (WebCore::TransparencyWin::initializeNewContext):
- (WebCore::TransparencyWin::compositeOpaqueComposite):
- (WebCore::TransparencyWin::compositeTextComposite):
- (WebCore::TransparencyWin::makeLayerOpaque):
- * platform/graphics/chromium/TransparencyWin.h: Added.
- (WebCore::TransparencyWin::):
- (WebCore::TransparencyWin::context):
- (WebCore::TransparencyWin::platformContext):
- (WebCore::TransparencyWin::drawRect):
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::endTransparencyLayer):
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::paintSkBitmap):
- * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::Chrome::createWindow):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::localStorage):
+ * page/DOMWindow.h:
+ * page/Page.cpp:
+ (WebCore::Page::sessionStorage):
+ (WebCore::Page::setSessionStorage):
+ * page/Page.h:
+ * page/PageGroup.cpp:
+ (WebCore::PageGroup::localStorage):
+ * page/PageGroup.h:
+ * storage/LocalStorage.cpp: Removed.
+ * storage/LocalStorage.h: Removed.
+ * storage/LocalStorageTask.cpp:
+ * storage/LocalStorageThread.cpp:
+ * storage/SessionStorage.cpp: Removed.
+ * storage/SessionStorage.h: Removed.
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::create):
+ (WebCore::StorageArea::StorageArea):
+ (WebCore::StorageArea::copy):
+ (WebCore::StorageArea::length):
+ (WebCore::StorageArea::key):
+ (WebCore::StorageArea::getItem):
+ (WebCore::StorageArea::setItem):
+ (WebCore::StorageArea::removeItem):
+ (WebCore::StorageArea::clear):
+ (WebCore::StorageArea::contains):
+ (WebCore::StorageArea::importItem):
+ (WebCore::StorageArea::close):
+ (WebCore::StorageArea::dispatchStorageEvent):
+ * storage/StorageArea.h:
(WebCore::):
- (WebCore::RenderThemeChromiumWin::paintButton):
- (WebCore::RenderThemeChromiumWin::paintMenuList):
- (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
+ * storage/StorageAreaSync.cpp:
+ (WebCore::StorageAreaSync::scheduleFinalSync):
+ * storage/StorageNamespace.cpp: Copied from WebCore/storage/LocalStorage.cpp.
+ (WebCore::localStorageNamespaceMap):
+ (WebCore::StorageNamespace::localStorageNamespace):
+ (WebCore::StorageNamespace::sessionStorageNamespace):
+ (WebCore::StorageNamespace::StorageNamespace):
+ (WebCore::StorageNamespace::~StorageNamespace):
+ (WebCore::StorageNamespace::copy):
+ (WebCore::StorageNamespace::storageArea):
+ (WebCore::StorageNamespace::close):
+ * storage/StorageNamespace.h: Copied from WebCore/storage/LocalStorage.h.
-2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
+2009-06-26 Nate Chapin <japhet@chromium.org>
- Reviewed by Eric Seidel.
+ Reviewed by David Levin.
+
+ Upstream V8Proxy. This involved updating a lot of function and variable names to match WebKit style, hence the large size.
- https://bugs.webkit.org/show_bug.cgi?id=24211
- Add ScheduledAction for V8.
+ https://bugs.webkit.org/show_bug.cgi?id=26623
- * bindings/v8/ScheduledAction.cpp: Added.
+ * bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
(WebCore::ScheduledAction::execute):
- * bindings/v8/ScheduledAction.h: Added.
- (WebCore::ScheduledAction::ScheduledAction):
-
-2009-02-27 Zack Rusin <zack@kde.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Qt: be more reasonable about scrolled lines
-
- cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
- match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
- irritating. so lets scroll vertically by the Qt set number of lines * Qt default
- single step scroll
-
- * platform/qt/WheelEventQt.cpp:
-
-2009-02-27 Xan Lopez <xan@gnome.org>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24222
- [GTK] Remove checks for old glib versions
-
- libsoup, which is a hard dependency, needs at least glib 2.15.3,
- so remove all glib checks for versions older than that.
-
- * platform/gtk/ContextMenuGtk.cpp:
- (WebCore::ContextMenu::ContextMenu):
- * platform/gtk/ContextMenuItemGtk.cpp:
- (WebCore::ContextMenuItem::setSubMenu):
- * platform/gtk/PopupMenuGtk.cpp:
- (WebCore::PopupMenu::show):
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::retainPlatformWidget):
- * platform/network/soup/ResourceHandleSoup.cpp:
-
-2009-02-26 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Added support for Gradients and Patterns on filled or stroked Fonts
- in Cairo. I also added support for globalAlpha on FontCairo.
-
- [CAIRO] SVG/Canvas fonts miss gradients/pattern support
- https://bugs.webkit.org/show_bug.cgi?id=18617
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
- * platform/graphics/cairo/FontCairo.cpp:
- (WebCore::Font::drawGlyphs):
-
-2009-02-26 Stephen White <senorblanco@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23957
-
- Fix for SVG gradient and pattern text for Chromium/skia.
- Added accessors for the fill and stroke gradients to
- GraphicsContext. Changed the paintSkiaText function to take a
- GraphicsContext, so we can check for gradients/patterns.
- Changed the skiaDrawText function to set the SkPaint shader
- correctly, and to scale up the gradient shader matrix to
- encompass the entire text string. Also offset each glyph
- separately, rather than transforming the canvas, so that the
- gradient/pattern stays fixed relative to the text origin.
-
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::getFillGradient):
- (WebCore::GraphicsContext::getStrokeGradient):
- (WebCore::GraphicsContext::getFillPattern):
- (WebCore::GraphicsContext::getStrokePattern):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::UniscribeHelper::draw):
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::skiaDrawText):
- (WebCore::paintSkiaText):
- * platform/graphics/skia/SkiaFontWin.h:
-
-2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24208
- Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
-
- * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
+ * bindings/v8/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::isSafeScript):
+ (WebCore::ScriptController::gcProtectJSWrapper):
+ (WebCore::ScriptController::gcUnprotectJSWrapper):
+ (WebCore::ScriptController::processingUserGesture):
+ (WebCore::ScriptController::evaluate):
+ (WebCore::ScriptController::setEventHandlerLineNumber):
+ (WebCore::ScriptController::bindToWindowObject):
+ (WebCore::ScriptController::collectGarbage):
+ (WebCore::ScriptController::haveInterpreter):
+ (WebCore::createScriptObject):
+ (WebCore::ScriptController::createScriptObjectForPluginElement):
+ * bindings/v8/ScriptInstance.cpp:
+ (WebCore::V8ScriptInstance::clear):
+ (WebCore::V8ScriptInstance::set):
+ * bindings/v8/ScriptObject.cpp:
+ (WebCore::ScriptGlobalObject::set):
+ * bindings/v8/ScriptObjectQuarantine.cpp:
+ (WebCore::getQuarantinedScriptObject):
+ * bindings/v8/ScriptScope.cpp:
+ (WebCore::ScriptScope::ScriptScope):
+ * bindings/v8/ScriptValue.h:
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::operator=):
+ (WebCore::ScriptValue::clear):
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::invokeEventHandler):
+ (WebCore::V8AbstractEventListener::handleEvent):
+ (WebCore::V8AbstractEventListener::disposeListenerObject):
+ (WebCore::V8AbstractEventListener::getReceiverObject):
+ * bindings/v8/V8Collection.cpp:
+ (WebCore::toOptionsCollectionSetter):
+ * bindings/v8/V8Collection.h:
+ (WebCore::getV8Object):
+ (WebCore::getNamedPropertyOfCollection):
+ (WebCore::nodeCollectionNamedPropertyGetter):
+ (WebCore::getIndexedPropertyOfCollection):
+ (WebCore::nodeCollectionIndexedPropertyGetter):
+ (WebCore::nodeCollectionIndexedPropertyEnumerator):
+ (WebCore::collectionIndexedPropertyEnumerator):
+ (WebCore::collectionStringOrNullIndexedPropertyGetter):
+ * bindings/v8/V8DOMMap.cpp:
+ (WebCore::weakDOMObjectCallback):
+ (WebCore::DOMData::removeObjectsFromWrapperMap):
+ * bindings/v8/V8Helpers.cpp:
+ (WebCore::wrapNPObject):
+ (WebCore::toV8Context):
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::~V8LazyEventListener):
+ (WebCore::V8LazyEventListener::getListenerFunction):
+ (WebCore::V8LazyEventListener::callListenerFunction):
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction):
+ * bindings/v8/V8NodeFilterCondition.cpp:
+ (WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
+ (WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
+ (WebCore::V8NodeFilterCondition::acceptNode):
+ * bindings/v8/V8ObjectEventListener.cpp:
+ (WebCore::weakObjectEventListenerCallback):
+ (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
+ * bindings/v8/V8Proxy.cpp: Added.
+ * bindings/v8/V8Proxy.h:
+ (WebCore::):
+ (WebCore::GlobalHandleInfo::GlobalHandleInfo):
+ (WebCore::V8Proxy::):
+ (WebCore::V8Proxy::V8Proxy):
+ (WebCore::V8Proxy::frame):
+ (WebCore::V8Proxy::inlineCode):
+ (WebCore::V8Proxy::setInlineCode):
+ (WebCore::V8Proxy::timerCallback):
+ (WebCore::V8Proxy::setTimerCallback):
+ (WebCore::V8Proxy::setEventHandlerLineNumber):
+ (WebCore::V8Proxy::finishedWithEvent):
+ (WebCore::V8Proxy::wrapCPointer):
+ (WebCore::V8Proxy::extractCPointer):
+ (WebCore::V8Proxy::convertDOMWrapperToNative):
+ (WebCore::V8Proxy::convertDOMWrapperToNode):
+ (WebCore::V8Proxy::convertToV8Object):
+ (WebCore::V8Proxy::convertToNativeObject):
+ (WebCore::V8Proxy::convertToNativeEvent):
+ (WebCore::V8Proxy::context):
+ (WebCore::V8Proxy::extractCPointerImpl):
+ (WebCore::V8Proxy::utilityContext):
+ (WebCore::V8Proxy::constructDOMObject):
+ (WebCore::throwError):
+ (WebCore::toV8):
+ * bindings/v8/V8Utilities.h:
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::retrieve):
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
+ (WebCore::WorkerContextExecutionProxy::GetConstructor):
+ (WebCore::WorkerContextExecutionProxy::ToV8Object):
+ (WebCore::WorkerContextExecutionProxy::EventToV8Object):
+ (WebCore::WorkerContextExecutionProxy::toV8):
+ (WebCore::WorkerContextExecutionProxy::forgetV8EventObject):
+ (WebCore::WorkerContextExecutionProxy::evaluate):
+ (WebCore::WorkerContextExecutionProxy::runScript):
+ * bindings/v8/custom/V8AttrCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::NAMED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::INDEXED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
+ (WebCore::toV8):
+ (WebCore::toCanvasStyle):
(WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8DocumentCustom.cpp: Added.
+ * bindings/v8/custom/V8ClientRectListCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8ClipboardCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
+ * bindings/v8/custom/V8CustomBinding.cpp:
+ (WebCore::allowSettingFrameSrcToJavascriptUrl):
(WebCore::ACCESSOR_GETTER):
- * bindings/v8/custom/V8NodeCustom.cpp: Added.
+ (WebCore::INDEXED_ACCESS_CHECK):
+ (WebCore::NAMED_ACCESS_CHECK):
+ (WebCore::V8Custom::GetTargetFrame):
+ * bindings/v8/custom/V8CustomEventListener.cpp:
+ (WebCore::V8EventListener::V8EventListener):
+ (WebCore::V8EventListener::~V8EventListener):
+ (WebCore::V8EventListener::callListenerFunction):
+ * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
+ (WebCore::V8CustomSQLStatementCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
+ (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
+ (WebCore::V8CustomSQLTransactionCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
+ (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/v8/custom/V8CustomVoidCallback.cpp:
+ (WebCore::V8CustomVoidCallback::handleEvent):
+ (WebCore::invokeCallback):
+ * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
+ (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/v8/custom/V8DOMParserConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
-
-2009-02-26 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed build fix for building with GNOME Keyring enabled.
-
- * platform/network/soup/webkit-soup-auth-dialog.c:
- (show_auth_dialog):
-
-2009-02-26 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=16947
- [GTK] Missing HTTP Auth challenge
-
- Add HTTP authentication dialog with optional GNOME Keyring
- storage.
-
- * GNUmakefile.am:
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::currentToplevelCallback):
- (WebCore::ResourceHandle::startHttp):
- (WebCore::ResourceHandle::start):
- * platform/network/soup/webkit-soup-auth-dialog.c: Added.
- (webkit_soup_auth_dialog_class_init):
- (webkit_soup_auth_dialog_init):
- (webkit_soup_auth_dialog_session_feature_init):
- (free_authData):
- (set_password_callback):
- (response_callback):
- (show_auth_dialog):
- (find_password_callback):
- (session_authenticate):
- (attach):
- * platform/network/soup/webkit-soup-auth-dialog.h: Added.
-
-2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
-
- Reviewed by Dave Hyatt.
-
- After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
- svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
- started failing because Ojan's new code was now *correctly* calling through to
- SVG asking for the closest text offset in the last line box, instead of
- just returning the offset at the end of the last line box when clicking below a box.
-
- But! The SVG code was wrong, in that it returned the character offset of the last
- character when you asked for a character offset after the end of the box, instead
- it should return the offset *after* the last character. This patch fixes
- that behavior by reordering the last two clauses in svgCharacterHitsPosition.
-
- The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
- to document what's wrong. I've also cleaned up the code a bit so it's clearer
- what it is doing (which also makes more obvious what's wrong with it).
-
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::positionForCoordinates):
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
- (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
- (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
- (WebCore::SVGInlineTextBox::closestCharacterToPosition):
- (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
-
-2009-02-26 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Minor cleanup of ChromiumBridge:
- Removing unused matchesMIMEType method and s/Javascript/JavaScript/
-
- * platform/chromium/ChromiumBridge.h:
- * platform/chromium/MimeTypeRegistryChromium.cpp:
- (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
-
-2009-02-26 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig
-
- Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
- the line-height below the descent.
-
- Added fast/inline/vertical-align-text-bottom.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::verticalPosition):
-
-2009-02-26 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
- ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
- just to implement this three methods to support SVG Masking now.
-
- Make SVG Masking platform aware
- https://bugs.webkit.org/show_bug.cgi?id=19243
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * svg/graphics/SVGResourceMasker.cpp:
- (WebCore::SVGResourceMasker::applyMask):
- * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
- * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
- * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
- * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
- * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
-
-2009-02-26 Yong Li <yong.li@torchmobile.com>
-
- Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
-
- Test: http/tests/misc/slow-preload-cancel.html
-
- https://bugs.webkit.org/show_bug.cgi?id=24133
- Clear all pending preloads in the DocLoader object when we decide to
- cancel its all requests.
-
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::clearPendingPreloads):
- * loader/DocLoader.h:
- * loader/loader.cpp:
- (WebCore::Loader::cancelRequests):
-
-2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24182
- Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
-
- * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::V8Custom::WindowSetTimeoutImpl):
+ (WebCore::convertBase64):
+ (WebCore::ACCESSOR_SETTER):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
- (WebCore::toV8):
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::createWindow):
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::V8Custom::ClearTimeoutImpl):
+ (WebCore::NAMED_ACCESS_CHECK):
+ (WebCore::INDEXED_ACCESS_CHECK):
+ * bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
- (WebCore::toV8):
+ * bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
-
-2009-02-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23500
- KURL::parse() incorrectly compares its result to original string
-
- * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
-
-2009-02-26 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Kevin McCullough.
-
- Manual test for inspector node highlighting.
-
- * manual-tests/inspector/highlight-nodes.html: Added.
-
-2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=23973
- ScrollView::scrollContents can be invoked during view shutdown. In
- this scenario the FrameView::hostWindow method can return NULL, which
- indicates that the frame/page is being destroyed. This causes a crash
- when we try to dereference a NULL hostWindow pointer. Fix is to add a
- NULL check for this.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents):
-
-2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24003
- Fix a crash caused by unsafe type conversion.
-
- Test: fast/block/positioning/absolute-in-inline-rtl-4.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
-
-2009-02-26 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=24202
- Have drawNodeHighlight clip instead of clearing. This makes it work for
- both Safari and Chromium since Chromium draws the inspector highlighting
- in the same buffer as the page.
-
- * inspector/InspectorController.cpp:
- (WebCore::quadToPath):
- (WebCore::drawOutlinedQuad):
- (WebCore::drawOutlinedQuadWithClip):
- (WebCore::drawHighlightForBox):
-
-2009-02-26 David Hyatt <hyatt@apple.com>
-
- Reviewed by Dan Bernstein & Darin Adler
-
- Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
-
- Added fast/inline/inline-continuation-borders.html
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
-
-2009-02-26 Simon Fraser <simon.fraser@apple.com>
-
- Build fix, no review.
-
- Try to fix the wx build after r41218.
-
- * WebCoreSources.bkl:
-
-2009-02-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19527
- ASSERTION FAILED: containerA && containerB
-
- Test: fast/dom/Range/bug-19527.html
-
- * dom/Range.cpp:
- (WebCore::Range::isPointInRange):
- (WebCore::Range::comparePoint):
- Bring the behavior in line with current Firefox, making it impossible for these methods
- to pass a null container to compareBoundaryPoints().
-
-2009-02-26 Jonathon Jongsma <jonathon@quotidian.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=20358
-
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
- should set the computed size rather than the specified size, otherwise
- the caps just get rendered normal size.
-
-2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=24062
- QNetworkCookieJar expects the url and not the policy url. Sending the
- policy url will cause QNetworkCookieJar to behave incorrectly. One
- example would be a cookie that does not have a path or domain.
- QNetworkCookieJar will use the url it is given to fill in default values.
- This allows setting cookies on the url of the main frame from an iFrame
- when the cookie should be set on the url of the iFrame.
-
- Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
-
- * platform/qt/CookieJarQt.cpp:
- (WebCore::setCookies):
-
-2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>
-
- Reviewed by George Staikos.
-
- make WebKit/Qt compile with SVG disabled
-
- * WebCore.pro:
- * platform/graphics/qt/FontPlatformDataQt.cpp:
-
-2009-02-25 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed build fix. Add WebCore/workers to the list of paths
- searched by the bindings generator perl script.
-
- * GNUmakefile.am:
-
-2009-02-25 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Add canvas to the list of RenderObjects that can mark a page as
- visually not empty.
-
- * rendering/RenderHTMLCanvas.cpp:
- (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
-
-2009-02-25 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Dave Hyatt.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
- as RenderMedia with controls always has a layer.
-
-2009-02-25 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Simon Fraser.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=24130
- <rdar://problem/6618196> Paint very slow when horizontally resizing
-
- Test: fast/gradients/background-clipped.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
- destination rectangle passed to drawTiledImage() with the dirty
- rectangle. This makes it more likely for the destination rect to be
- contained in a single tile rect, which results in a faster code path
- being taken down the road (just drawing a single tile instead of
- tiling).
-
-2009-02-25 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Fix test regressions from positionForCoordinates patch.
- https://bugs.webkit.org/show_bug.cgi?id=24148
-
- * rendering/RenderBlock.cpp:
- (WebCore::positionForPointWithInlineChildren):
- Remove ASSERT that placeholder text codepath is hitting.
-
-2009-02-25 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
- https://bugs.webkit.org/show_bug.cgi?id=24143
-
- When an AX object is marked dirty, do not create AX elements while going up the parent chain.
- Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
- Make sure the AXObjectWrapper's have an object before calling them
- In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
-
- Test: platform/mac-snowleopard/accessibility/table-updating.html
-
- * WebCore.base.exp:
- * page/AXObjectCache.cpp:
- (WebCore::AXObjectCache::~AXObjectCache):
- (WebCore::AXObjectCache::get):
- (WebCore::AXObjectCache::getOrCreate):
- (WebCore::AXObjectCache::removeAXID):
- (WebCore::AXObjectCache::handleActiveDescendantChanged):
- (WebCore::AXObjectCache::handleAriaRoleChanged):
- * page/AXObjectCache.h:
- * page/AccessibilityImageMapLink.cpp:
- (WebCore::AccessibilityImageMapLink::parentObject):
- * page/AccessibilityListBox.cpp:
- (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
- (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- * page/AccessibilityListBoxOption.cpp:
- (WebCore::AccessibilityListBoxOption::elementRect):
- (WebCore::AccessibilityListBoxOption::parentObject):
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::detach):
- (WebCore::AccessibilityObject::parentObjectIfExists):
- (WebCore::replacedNodeNeedsCharacter):
- (WebCore::AccessibilityObject::accessibilityObjectForPosition):
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::firstChild):
- (WebCore::AccessibilityRenderObject::lastChild):
- (WebCore::AccessibilityRenderObject::previousSibling):
- (WebCore::AccessibilityRenderObject::nextSibling):
- (WebCore::AccessibilityRenderObject::parentObjectIfExists):
- (WebCore::AccessibilityRenderObject::parentObject):
- (WebCore::AccessibilityRenderObject::isAttachment):
- (WebCore::AccessibilityRenderObject::headingLevel):
- (WebCore::AccessibilityRenderObject::anchorElement):
- (WebCore::AccessibilityRenderObject::menuForMenuButton):
- (WebCore::AccessibilityRenderObject::menuButtonForMenu):
- (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
- (WebCore::AccessibilityRenderObject::internalLinkElement):
- (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
- (WebCore::AccessibilityRenderObject::titleUIElement):
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
- (WebCore::AccessibilityRenderObject::getDocumentLinks):
- (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- (WebCore::AccessibilityRenderObject::focusedUIElement):
- (WebCore::AccessibilityRenderObject::activeDescendant):
- (WebCore::AccessibilityRenderObject::observableObject):
- (WebCore::AccessibilityRenderObject::childrenChanged):
- (WebCore::AccessibilityRenderObject::addChildren):
- * page/AccessibilityRenderObject.h:
- (WebCore::AccessibilityRenderObject::setRenderObject):
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::addChildren):
- (WebCore::AccessibilityTable::headerContainer):
- (WebCore::AccessibilityTable::cellForColumnAndRow):
- * page/AccessibilityTableCell.cpp:
- (WebCore::AccessibilityTableCell::isTableCell):
- (WebCore::AccessibilityTableCell::titleUIElement):
- * page/AccessibilityTableColumn.cpp:
- (WebCore::AccessibilityTableColumn::headerObjectForSection):
- * page/AccessibilityTableRow.cpp:
- (WebCore::AccessibilityTableRow::isTableRow):
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
- * page/mac/AXObjectCacheMac.mm:
- (WebCore::AXObjectCache::postNotification):
- (WebCore::AXObjectCache::postNotificationToElement):
- * page/mac/AccessibilityObjectWrapper.mm:
- (textMarkerForVisiblePosition):
- (AXLinkElementForNode):
- (nsStringForReplacedNode):
- (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
- (-[AccessibilityObjectWrapper accessibilityActionNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
- (-[AccessibilityObjectWrapper accessibilityHitTest:]):
- (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
- (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
- (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
- (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
- (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
- (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
-
-2009-02-25 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Re-working of <rdar://problem/6487249> repro crash in
- WebCore::CSSParser::parseFillImage copying entire contents of this
- page
- -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
-
- Fixes a bunch of layout test failures I caused!
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::parseContent):
- (WebCore::CSSParser::parseFillImage):
- (WebCore::CSSParser::parseFontFaceSrc):
- (WebCore::CSSParser::parseBorderImage):
-
-2009-02-25 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24174
- Add more V8 custom bindings.
-
- * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
- (WebCore::hasCSSPropertyNamePrefix):
- (WebCore::cssPropertyName):
- (WebCore::NAMED_PROPERTY_GETTER):
- (WebCore::NAMED_PROPERTY_SETTER):
- * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
- (WebCore::INDEXED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8DocumentLocationCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+ * bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8EventCustom.cpp: Added.
(WebCore::ACCESSOR_SETTER):
(WebCore::ACCESSOR_GETTER):
- * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
- (WebCore::NAMED_PROPERTY_DELETER):
- (WebCore::NAMED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8EventCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::ACCESSOR_GETTER):
+ * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+ (WebCore::getNamedItems):
+ (WebCore::getItem):
(WebCore::NAMED_PROPERTY_GETTER):
- * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
- * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::ACCESSOR_GETTER):
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::INDEXED_PROPERTY_GETTER):
(WebCore::NAMED_PROPERTY_GETTER):
- * bindings/v8/custom/V8NodeListCustom.cpp: Added.
- (WebCore::NAMED_PROPERTY_GETTER):
- * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
- (WebCore::NAMED_PROPERTY_GETTER):
-
-2009-02-25 Scott Violet <sky@google.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=24171
- Provides a RenderTheme method for getting the scroll bar size and
- changes RenderListBox to use it. RenderTheme returns a size of regular,
- and Mac's override to return small. Changes ScrollbarThemeChromium to
- use the scrollbarsize of the scrollbar when getting the size
- instead of passing in no-args.
-
- * platform/chromium/ScrollbarThemeChromium.cpp:
- (WebCore::ScrollbarThemeChromium::trackRect):
- (WebCore::ScrollbarThemeChromium::buttonSize):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::createScrollbar):
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::scrollbarControlSizeForPart):
- * rendering/RenderThemeChromiumMac.h:
- (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
- * rendering/RenderThemeMac.h:
- (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
-
-2009-02-25 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/6487249> repro crash in
- WebCore::CSSParser::parseFillImage copying entire contents of this
- page
- -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Null-check m_styleSheet
-
-2009-02-25 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build.
-
- * WebCore.pro:
-
-2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix. Not reviewed.
-
- Add files to the build per r41218.
- Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
-
- * GNUmakefile.am:
- * page/DOMWindow.cpp:
-
-2009-02-25 Zan Dobersek <zandobersek@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24043
- When faced with URLs with unsupported protocol on Gtk port,
- report the error through an idle function and return true, so
- a proper resource handle is created.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::reportUnknownProtocolError):
- (WebCore::ResourceHandle::start):
-
-2009-02-25 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
- Use struct to forward declare ResourceRequest.
-
- * history/HistoryItem.h:
- * inspector/InspectorController.h:
- * loader/DocumentThreadableLoader.h:
- * loader/FrameLoaderClient.h:
- * loader/MainResourceLoader.h:
- * loader/SubresourceLoader.h:
- * loader/SubresourceLoaderClient.h:
- * loader/ThreadableLoader.h:
- * loader/WorkerThreadableLoader.h:
- * platform/CrossThreadCopier.h:
- * platform/network/ResourceHandle.h:
- * platform/network/ResourceHandleClient.h:
- * platform/network/ResourceRequestBase.h:
- * platform/network/cf/ResourceRequestCFNet.h:
- * xml/XMLHttpRequest.h:
-
-2009-02-25 Steve Falkenburg <sfalken@apple.com>
-
- Partial Windows build fix.
-
- * DerivedSources.cpp:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-02-25 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Ported arcTo to Qt. Qt has no native support for arcTo. This changes
- calculate the behavior of arcTo and draws it with lineTo and arc.
-
- [QT] implement Canvas arcTo
- https://bugs.webkit.org/show_bug.cgi?id=23873
-
- * platform/graphics/qt/PathQt.cpp:
- (WebCore::Path::addArcTo):
-
-2009-02-25 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- Remove idl files from Resources, and sort.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-02-25 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=23943
-
- Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
- the window object. Also added WebKitPoint object, which is passed in and out
- of these functions.
-
- Test: fast/dom/Window/webkitConvertPoint.html
-
- * DerivedSources.make:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseWebKitPoint):
- (setJSDOMWindowBaseWebKitPoint):
- * bindings/js/JSWebKitPointConstructor.cpp: Added.
- (WebCore::):
- (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- (WebCore::constructWebKitPoint):
- (WebCore::JSWebKitPointConstructor::getConstructData):
- * bindings/js/JSWebKitPointConstructor.h: Added.
- (WebCore::JSWebKitPointConstructor::classInfo):
- * dom/Node.cpp:
- (WebCore::Node::convertToPage):
- (WebCore::Node::convertFromPage):
- * dom/Node.h:
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
- (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
- * page/WebKitPoint.h: Added.
- (WebCore::WebKitPoint::create):
- (WebCore::WebKitPoint::x):
- (WebCore::WebKitPoint::y):
- (WebCore::WebKitPoint::setX):
- (WebCore::WebKitPoint::setY):
- (WebCore::WebKitPoint::WebKitPoint):
- * page/WebKitPoint.idl: Added.
-
-2009-02-25 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
- https://bugs.webkit.org/show_bug.cgi?id=24145
-
- * platform/CrossThreadCopier.cpp:
- * platform/CrossThreadCopier.h:
-
-2009-02-25 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23688: ThreadableLoader needs a sync implementation for Workers.
- <https://bugs.webkit.org/show_bug.cgi?id=23688>
-
- No observable change in behavior, so no test.
-
- * loader/ThreadableLoader.cpp:
- (WebCore::ThreadableLoader::loadResourceSynchronously):
- * loader/ThreadableLoaderClientWrapper.h:
- (WebCore::ThreadableLoaderClientWrapper::clearClient):
- (WebCore::ThreadableLoaderClientWrapper::done):
- (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
- (WebCore::ThreadableLoaderClientWrapper::didFail):
- (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
- (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
- Expose whether the loader is done (based on what callbacks were done).
-
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
- (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
- Each loader is given its own mode so that only its callbacks get through the run loop.
-
- The xhr spec says that the readystatechange events are synchronous, so in the case of a
- nested sync xhr no readystatechange events should be fired for the outer xhr.
-
- (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
-
- * loader/WorkerThreadableLoader.h:
- (WebCore::WorkerThreadableLoader::create):
- (WebCore::WorkerThreadableLoader::done):
-
- * workers/WorkerRunLoop.cpp:
- (WebCore::WorkerRunLoop::WorkerRunLoop):
- * workers/WorkerRunLoop.h:
- (WebCore::WorkerRunLoop::createUniqueId):
- Simple method to create a uniqueId on demand with respect to the run loop.
-
- * workers/WorkerThread.h:
-
-2009-02-25 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
- <https://bugs.webkit.org/show_bug.cgi?id=24089>
-
- Make threadable loader callbacks to happen during the sync load call.
-
- Changes the behavior of sync xhr for insecure redirects in two ways:
- + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
- + Throws a network exception which is what other browsers do and what the spec
- says to do (http://www.w3.org/TR/XMLHttpRequest/).
-
- * loader/DocumentThreadableLoader.cpp:
- (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
- * loader/DocumentThreadableLoader.h:
- * loader/ThreadableLoader.cpp:
- (WebCore::ThreadableLoader::loadResourceSynchronously):
- * loader/ThreadableLoader.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::loadRequestSynchronously):
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::didFail):
- (WebCore::XMLHttpRequest::didFailRedirectCheck):
- * xml/XMLHttpRequest.h:
-
-2009-02-24 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23368
-
- Added logic to correctly hit test accelerated layers.
-
- Tests: animations/animation-hit-test-transform.html
- animations/animation-hit-test.html
- transitions/transition-hit-test-transform.html
- transitions/transition-hit-test.html
-
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::updateClipRects):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
-
-2009-02-25 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24067
- REGRESSION: Crash in WebCore::Document::initSecurityContext
-
- The crash started to happen when we removed a check for frame->document() being null.
- However, the original document shouldn't be null here, because it is needed to alias
- security origins. So, this patch fixes the crash by correcting security origin behavior.
-
- Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
- This tests for not crashing, and for inheriting the domain from the document being replaced.
- Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
- domain to remove a prefix from.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
- clearing the frame, so that Document::initSecurityContext() could access the old one.
-
-2009-02-25 Jay Campan <jcampan@google.com>
-
- Reviewed by Darin Fisher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24066
-
- Items in drop-downs were not painted correctly. Makes sure the
- PopupListBox invalidates in the coordinates of the window as this is
- FramelessScrollView::invalidateRect paints to.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::invalidateRow):
-
-2009-02-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- https://bugs.webkit.org/show_bug.cgi?id=15081
-
- Make display:none work for applet, emebed and object elements
- by calling rendererIsNeeded() on superclasses.
-
- Tests: fast/replaced/applet-display-none.html
- fast/replaced/embed-display-none.html
- fast/replaced/object-display-none.html
-
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::rendererIsNeeded):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::rendererIsNeeded):
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::rendererIsNeeded):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::rendererIsNeeded):
-
-2009-02-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=24137
-
- Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
- taking perspective and transform-style: preserve-3d into account.
-
- In order to support transform-style: preserve-3d, which keeps elements in a
- 3d space, we have to carry along an accumulated matrix in TransformState.
- We also need to apply the perspective from the parent, if any, with the
- appropriate origin.
-
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::translate):
- (WebCore::TransformationMatrix::translate3d):
- (WebCore::TransformationMatrix::translateRight3d):
- * platform/graphics/transforms/TransformationMatrix.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::mapLocalToAbsolutePoint):
- (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- * rendering/RenderBox.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::perspectiveTransform):
- (WebCore::RenderLayer::perspectiveOrigin):
- * rendering/RenderLayer.h:
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::requiresCompositingLayerForTransform):
- (WebCore::RenderLayerCompositor::layerHas3DContent):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::absoluteToLocal):
- (WebCore::RenderObject::mapLocalToAbsolutePoint):
- (WebCore::RenderObject::mapAbsoluteToLocalPoint):
- * rendering/RenderObject.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
- (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
- * rendering/RenderTableCell.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::mapLocalToAbsolutePoint):
- (WebCore::RenderView::mapAbsoluteToLocalPoint):
- * rendering/RenderView.h:
- * rendering/TransformState.cpp: Added.
- (WebCore::TransformState::move):
- (WebCore::TransformState::applyTransform):
- (WebCore::TransformState::flatten):
- * rendering/TransformState.h: Added.
- (WebCore::TransformState::):
- (WebCore::TransformState::TransformState):
- (WebCore::TransformState::move):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::hasPerspective):
-
-2009-02-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
- Regression (r40837): JavaScript image popup doesn't work
-
- Make the getClientRects and getBoundingClientRect methods return rects
- relative to the viewport.
-
- Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
-
- * dom/Element.cpp:
- (WebCore::Element::getClientRects):
- (WebCore::Element::getBoundingClientRect):
-
-2009-02-24 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- SVG pages don't have a body or an html element!
- Don't return early if there is no body.
-
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::canonicalPosition):
-
-2009-02-23 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
-
- This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
- layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
- reflections or masks).
-
- If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
- The only difference is that the clip has to be pushed and popped when painting the object's children.
-
- The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
- the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
- use the new functions.
-
- Hit testing has also been patched to check the overflow clip rect first before recurring into children.
-
- Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
- yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.
-
- Masks are now treated like normal flow layers (just like reflections).
-
- A couple of test cases have been added to fast/overflow to test the stacking order.
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::nodeAtPoint):
- (WebCore::InlineFlowBox::paint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::repaintOverhangingFloats):
- (WebCore::RenderBlock::paint):
- (WebCore::RenderBlock::paintChildren):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::paintFloats):
- (WebCore::RenderBlock::insertFloatingObject):
- (WebCore::RenderBlock::floatRect):
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- (WebCore::RenderBlock::addOverhangingFloats):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::hitTestContents):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::nodeAtPoint):
- (WebCore::RenderBox::pushContentsClip):
- (WebCore::RenderBox::popContentsClip):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::paintObject):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
- * rendering/RenderBoxModelObject.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::shouldBeNormalFlowOnly):
- (WebCore::RenderLayer::isSelfPaintingLayer):
- * rendering/RenderLayer.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::paint):
- (WebCore::RenderTable::paintObject):
- (WebCore::RenderTable::nodeAtPoint):
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::paint):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::nodeAtPoint):
- (WebCore::RenderTableRow::paint):
- * rendering/RenderTableRow.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::paint):
- (WebCore::RenderTableSection::paintObject):
- (WebCore::RenderTableSection::nodeAtPoint):
- * rendering/RenderTableSection.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::write):
- (WebCore::writeLayers):
-
-2009-02-24 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY (build fix).
-
- Attempted build fix for wx-mac.
-
- * WebCoreSources.bkl:
-
-2009-02-24 David Levin <levin@chromium.org>
-
- Reviewed by NOBODY (build fix).
-
- Attempted build fixes for qt-linux and wx-mac.
-
- * WebCore.pro:
- * webcore-base.bkl:
-
-2009-02-24 Ojan Vafai <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
-
- Reviewed by Sam Weinig.
-
- Fix null pointer error. If the node is the Document, then ownerDocument()
- returns null, document() does not.
-
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::canonicalPosition):
-
-2009-02-24 Jian Li <jianli@chromium.org>
-
- Reviewed by NOBODY (attempted build fixes).
-
- Fix build break for Windows and Linux.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24131
- Fix-up COM/RefCounted dichotomy in Chromium port.
-
- * page/chromium/AccessibilityObjectWrapper.h:
- (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
- explicit setting of recount.
-
-2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24141
- Add clarity to V8 interceptor helper function.
-
- * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
- (WebCore::NAMED_PROPERTY_SETTER): Ditto.
- (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
- (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
-
-2009-02-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Minor numeric cleanup: convert float literals to doubles.
-
- * platform/graphics/transforms/RotateTransformOperation.cpp:
- (WebCore::RotateTransformOperation::blend):
-
-2009-02-24 Mark Mentovai <mark@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24139
- Add missing include.
-
- * bindings/v8/ScriptInstance.h:
-
-2009-02-24 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Move worker related files from dom directory to worker directory under WebCore.
- https://bugs.webkit.org/show_bug.cgi?id=24123
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/MigrateIDLAndScripts:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
- * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
- * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
- * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
- * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
- * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
- * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
- * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
- * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
- * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
- * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
- * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
- * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
- * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
- * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
- * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
- * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
- * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
- * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
- * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
-
-2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
-
- Reviewed by Dave Hyatt.
-
- Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
- around divs inside editable regions.
- https://bugs.webkit.org/show_bug.cgi?id=23605
-
- Fix clicks outside editable regions from focusing the editable region.
- https://bugs.webkit.org/show_bug.cgi?id=23607
-
- Removed editing/selection/contenteditable-click-outside.html as it's
- not as useful as our new tests.
-
- Clean up RenderBlock::positionForCoordinates to remove dead code,
- duplicate code, and generally make it more readable.
-
- Tests: editing/selection/click-in-margins-inside-editable-div.html
- editing/selection/click-in-padding-with-multiple-line-boxes.html
- editing/selection/click-outside-editable-div.html
-
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::canonicalPosition):
- * rendering/RenderBlock.cpp:
- (WebCore::positionForPointRespectingEditingBoundaries):
- (WebCore::positionForPointWithInlineChildren):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::updateFirstLetter):
-
-2009-02-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Related to <rdar://problem/6590295>
- Allow disabling javascript: urls.
-
- * WebCore.base.exp:
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::parseMappedAttribute):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeIfJavaScriptURL):
- * page/Page.cpp:
- (WebCore::Page::Page):
- (WebCore::Page::setJavaScriptURLsAreAllowed):
- (WebCore::Page::javaScriptURLsAreAllowed):
- * page/Page.h:
-
-2009-02-24 Simon Fraser <simon.fraser@apple.com>
-
- Fix build when ACCELERATED_COMPOSITING is turned on
- (overflowList() -> normalFlowList()).
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::hasNonCompositingContent):
- (WebCore::RenderLayerBacking::paintIntoLayer):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::calculateCompositedBounds):
- (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
- (WebCore::RenderLayerCompositor::layerHas3DContent):
-
-2009-02-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=24135
-
- Round the FloatPoint returned by absoluteToLocal(), rather than
- truncating it.
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
-
-2009-02-24 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
- Ordered list item marker misaligned when line height is not 1.2
- -and corresponding <rdar://problem/6602506>
-
- This is a regression from http://trac.webkit.org/changeset/40880
- where createInlineBox was taken off of RenderObject and moved to
- RenderBox. The problem was that the RenderBox version still needs
- to be virtual because there is still an existing implementation in
- RenderListMarker.
-
- * rendering/RenderBox.h:
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::createInlineBox):
- * rendering/RenderListMarker.h:
-
-2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24128
- Upstream more V8 custom bindings: constructors, XSLTProcessor.
-
- * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
+ * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
+ * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
+ * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
-
-2009-02-24 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
- <https://bugs.webkit.org/show_bug.cgi?id=24090>
-
- No observable change in behavior, so no test.
-
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
- Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
-
- (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
-
- * dom/WorkerMessagingProxy.h:
- * loader/ThreadableLoader.cpp:
- (WebCore::ThreadableLoader::create):
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
- Changed these methods to post task using a mode.
-
- * loader/WorkerThreadableLoader.h:
- (WebCore::WorkerThreadableLoader::create):
-
-2009-02-24 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=24091
- <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
-
- Test: http/tests/appcache/access-via-redirect.php
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
- not the original one.
-
-2009-02-24 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
- https://bugs.webkit.org/show_bug.cgi?id=24112
-
- * bindings/js/WorkerScriptController.cpp:
- * dom/WorkerContext.cpp:
-
-2009-02-23 Antti Koivisto <antti@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6613796> Extended text codecs registered on webview creation
-
- Comparing a text encoding with string "GBK" ended up constructing
- TextEncoding("GBK") which in turn initialized all extended
- text codecs.
-
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::decode):
-
-2009-02-23 Sam Weinig <sam@webkit.org>
-
- Fix Qt build.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::valueRealType):
-
-2009-02-23 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
-
- The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
- element created with createElement could have a wrong nodeName (createElement sets the string as the
- localName without checking for a prefix).
-
- The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
- and will always succeed.
- Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
- to ensure that).
-
- Test: fast/dom/cloneNode.html
-
- * dom/Element.cpp:
- (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
- always return an element.
-
- * html/HTMLElement.cpp:
- * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
-
-2009-02-23 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24109
- Upstream V8 Script abstractions, all except ScriptController.
-
- * bindings/v8/ScriptCachedFrameData.h: Added.
- (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
- (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
- (WebCore::ScriptCachedFrameData::restore):
- (WebCore::ScriptCachedFrameData::clear):
- (WebCore::ScriptCachedFrameData::domWindow):
- * bindings/v8/ScriptCallFrame.cpp: Added.
- (WebCore::ScriptCallFrame::ScriptCallFrame):
- (WebCore::ScriptCallFrame::~ScriptCallFrame):
- (WebCore::ScriptCallFrame::argumentAt):
- * bindings/v8/ScriptCallFrame.h: Added.
- (WebCore::ScriptCallFrame::functionName):
- (WebCore::ScriptCallFrame::sourceURL):
- (WebCore::ScriptCallFrame::lineNumber):
- (WebCore::ScriptCallFrame::argumentCount):
- * bindings/v8/ScriptCallStack.cpp: Added.
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::~ScriptCallStack):
- (WebCore::ScriptCallStack::at):
- * bindings/v8/ScriptCallStack.h: Added.
- (WebCore::ScriptCallStack::size):
- * bindings/v8/ScriptInstance.cpp: Added.
- (WebCore::V8ScriptInstance::V8ScriptInstance):
- (WebCore::V8ScriptInstance::~V8ScriptInstance):
- (WebCore::V8ScriptInstance::instance):
- (WebCore::V8ScriptInstance::clear):
- (WebCore::V8ScriptInstance::set):
- * bindings/v8/ScriptInstance.h: Added.
- (WebCore::V8ScriptInstance::create):
- * bindings/v8/ScriptSourceCode.h: Added.
- (WebCore::ScriptSourceCode::ScriptSourceCode):
- (WebCore::ScriptSourceCode::isEmpty):
- (WebCore::ScriptSourceCode::source):
- (WebCore::ScriptSourceCode::url):
- (WebCore::ScriptSourceCode::startLine):
- * bindings/v8/ScriptState.h: Added.
- (WebCore::ScriptState::hadException):
- (WebCore::ScriptState::setException):
- (WebCore::ScriptState::exception):
- * bindings/v8/ScriptString.h: Added.
- (WebCore::ScriptString::ScriptString):
- (WebCore::ScriptString::operator String):
- (WebCore::ScriptString::isNull):
- (WebCore::ScriptString::size):
- (WebCore::ScriptString::operator=):
- (WebCore::ScriptString::operator+=):
- * bindings/v8/ScriptValue.cpp: Added.
- (WebCore::ScriptValue::getString):
- * bindings/v8/ScriptValue.h: Added.
- (WebCore::ScriptValue::ScriptValue):
- (WebCore::ScriptValue::operator=):
- (WebCore::ScriptValue::operator==):
- (WebCore::ScriptValue::operator!=):
- (WebCore::ScriptValue::isNull):
- (WebCore::ScriptValue::isUndefined):
- (WebCore::ScriptValue::clear):
- (WebCore::ScriptValue::~ScriptValue):
- (WebCore::ScriptValue::v8Value):
-
-2009-02-23 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=24106
- The Qt port is crashing on exit because the tear down procedure involves
- the WebCore::InspectorController trying to access the JS execution context
- for a page that is being deleted. This patch amends the inspector so
- that it does not try and access the execution context of the WebCore::Page
- in the midst of deletion.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::inspectedPageDestroyed):
- (WebCore::InspectorController::stopUserInitiatedProfiling):
-
-2009-02-23 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
- <https://bugs.webkit.org/show_bug.cgi?id=24088>
-
- No observable change in behavior, so no test.
-
- * loader/DocumentThreadableLoader.cpp:
- (WebCore::DocumentThreadableLoader::create):
- * loader/ThreadableLoaderClient.h:
- (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
- * loader/ThreadableLoaderClientWrapper.h:
- (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::workerContextDidFailRedirectCheck):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
- * loader/WorkerThreadableLoader.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::didFinishLoading):
- * xml/XMLHttpRequest.h:
-
-2009-02-23 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
- <https://bugs.webkit.org/show_bug.cgi?id=24047>
-
- Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
- using only MessageQueue::waitForMessageFilteredWithTimeout instead
- of three different MessageQueue methods.
-
- No observable change in behavior, so no test.
-
- * dom/WorkerRunLoop.cpp:
- (WebCore::ModePredicate::operator()):
- Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
- (WebCore::WorkerRunLoop::runInMode):
- * dom/WorkerRunLoop.h:
-
-2009-02-23 David Hyatt <hyatt@apple.com>
-
- In preparation for making layers for multicol objects (so that they can properly split child layers
- into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
- of RenderLayer to use the term "normal flow" instead.
-
- Reviewed by Cameron Zwarich
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::~RenderLayer):
- (WebCore::RenderLayer::setHasVisibleContent):
- (WebCore::RenderLayer::enclosingCompositingLayer):
- (WebCore::RenderLayer::addChild):
- (WebCore::RenderLayer::removeChild):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::dirtyNormalFlowList):
- (WebCore::RenderLayer::updateNormalFlowList):
- (WebCore::RenderLayer::collectLayers):
- (WebCore::RenderLayer::updateLayerListsIfNeeded):
- (WebCore::RenderLayer::shouldBeNormalFlowOnly):
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isNormalFlowOnly):
- (WebCore::RenderLayer::normalFlowList):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::writeLayers):
-
-2009-02-23 David Hyatt <hyatt@apple.com>
-
- Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
- after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
- column rules (rather than ending up above the background of the box but behind the column rules).
-
- Reviewed by Eric Seidel
-
- Added fast/multicol/column-rules-stacking.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintColumnRules):
- (WebCore::RenderBlock::paintColumnContents):
- (WebCore::RenderBlock::paintObject):
- * rendering/RenderBlock.h:
-
-2009-02-23 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by David Hyatt.
-
- No testcases have been added or modified since this patch should not result in
- a behavior change for ports that have layout tests enabled.
-
- Currently, the implementation of GraphicsContext::drawLineForText amongst
- the various ports differ in that some of them are honoring the context's
- strokeStyle when drawing a text-decoration and some of them are not.
- For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
- but the Cairo implementation does and has an explicit workaround that
- sets the strokeStyle() temporarily.
-
- This patch fixes so that all ports are consistent by explicitly making sure
- to set the GraphicsContext strokeStyle to SolidStroke whenever
- painting the text-decoration of an InlineFlowBox or InlineTextBox as these
- should always use a solid stroke.
-
- This patch addresses these bugs:
- https://bugs.webkit.org/show_bug.cgi?id=19364
- https://bugs.webkit.org/show_bug.cgi?id=15659
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::paintTextDecorations):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintDecoration):
-
-2009-02-23 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24098
- Bugs in ClipboardChromium
-
- Fixes the following bugs in ClipboardChromium:
- * It's possible for the extension to be empty, resulting in a bad file
- name, for example, 'foo.' or just '.'.
- * We weren't restricting the size of the file to MAX_PATH.
- * We weren't removing characters that are invalid for file system names.
-
- * platform/chromium/ClipboardChromium.cpp:
- (WebCore::writeImageToDataObject):
- * platform/chromium/ClipboardChromium.h:
- * platform/chromium/ClipboardChromiumLinux.cpp: Added.
- (WebCore::ClipboardChromium::validateFileName):
- * platform/chromium/ClipboardChromiumMac.cpp: Added.
- (WebCore::ClipboardChromium::validateFileName):
- * platform/chromium/ClipboardChromiumWin.cpp: Added.
- (WebCore::isInvalidFileCharacter):
- (WebCore::ClipboardChromium::validateFileName):
-
-2009-02-23 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix the Copyright notices in a few files
-
- * platform/qt/RenderThemeQt.h:
-
-2009-02-23 Xan Lopez <xan@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22624
- [SOUP][GTK] Need API to get SoupSession from WebKit.
-
- Allow to retrieve the Soup session and modify the code to take
- into account users changing features on it.
-
- * platform/network/ResourceHandle.h:
- * platform/network/soup/CookieJarSoup.cpp:
- (WebCore::defaultCookieJar):
- (WebCore::setDefaultCookieJar):
- * platform/network/soup/CookieJarSoup.h:
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::createSoupSession):
- (WebCore::ensureSessionIsInitialized):
- (WebCore::ResourceHandle::startHttp):
- (WebCore::ResourceHandle::cancel):
- (WebCore::ResourceHandle::defaultSession):
-
-2009-02-23 Xan Lopez <xan@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22624
- [SOUP][GTK] Need API to get SoupSession from WebKit.
-
- Remove CURL support.
-
- * GNUmakefile.am:
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Test: fast/dom/empty-hash-and-search.html
-
- https://bugs.webkit.org/show_bug.cgi?id=21147
- hash property returns incorrect value for links w/o hash
-
- Make hash() and search() behavior for empty and missing parts match IE and Firefox.
-
- * platform/KURL.cpp:
- (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
- (WebCore::KURL::prettyURL): Append the query with the question mark.
-
- * page/Location.cpp:
- (WebCore::Location::search): Return an empty string if query is empty or missing.
- (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
-
- * dom/WorkerLocation.cpp:
- (WebCore::WorkerLocation::search):
- (WebCore::WorkerLocation::hash):
- Match document.location fixes above.
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::hash):
- (WebCore::HTMLAnchorElement::search):
- Return an empty string for empty and missing parts.
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20184
- SELECT with no name generates invalid query string
-
- Test: fast/forms/select-no-name.html
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Apply review comments for the previous check-in (forgot to save the file, oops).
-
- * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=15707
- Crash when manipulating document from within an iframe onload function
-
- Test: fast/dom/onload-open.html
-
- * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
- the current node, because anything can happen when dispatching events.
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=18970
- Numerically named input fields cause document.forms loop problems
-
- Test: fast/forms/numeric-input-name.html
-
- * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
- latter overrides properties.
-
-2009-02-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=24059
- Tokenizer::write() return value is never used
-
- * dom/Tokenizer.h:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::write):
- * dom/XMLTokenizer.h:
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::write):
- * html/HTMLTokenizer.h:
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::FTPDirectoryTokenizer::write):
- * loader/ImageDocument.cpp:
- (WebCore::ImageTokenizer::write):
- * loader/MediaDocument.cpp:
- (WebCore::MediaTokenizer::write):
- * loader/PluginDocument.cpp:
- (WebCore::PluginTokenizer::write):
- * loader/TextDocument.cpp:
- (WebCore::TextTokenizer::write):
- Made write() return void, not bool.
-
-2009-02-20 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore changes to timeout checking.
-
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBase):
- (WebCore::JSDOMWindowBase::commonJSGlobalData):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::executeFunctionInContext):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- (WebCore::WorkerScriptController::forbidExecution):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- (-[WebScriptObject evaluateWebScript:]):
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Evaluate):
- (_NPN_Construct):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::eval):
-
-2009-02-21 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23786
- [Chromium] line-break characters in a complex text are treated as zero-width spaces
-
- This change prevents the UniscribeHelper class from treating the line-break characters
- as whitespaces.
-
- Tests: fast/text/international/bidi-linebreak-001.html
- fast/text/international/bidi-linebreak-002.html
- fast/text/international/bidi-linebreak-003.html
-
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::UniscribeHelper::adjustSpaceAdvances):
- Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
- the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
- so does when Chromium renders a simple text.
-
-2009-02-20 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
-
- Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
- or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
- unneeded.
-
- It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
- enables us to use some generated QualifiedName.
-
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::constructHTMLOptionElement):
- * dom/Document.cpp:
- (WebCore::Document::setTitle):
- * dom/XMLTokenizer.cpp:
- (WebCore::createXHTMLParserErrorHeader):
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * editing/CompositeEditCommand.cpp:
- (WebCore::createBlockPlaceholderElement):
- * editing/htmlediting.cpp:
- (WebCore::createTabSpanElement):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setLength):
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::FTPDirectoryTokenizer::appendEntry):
- (WebCore::FTPDirectoryTokenizer::createTDForFilename):
- (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
- (WebCore::FTPDirectoryTokenizer::createBasicDocument):
- * loader/ImageDocument.cpp:
- (WebCore::ImageDocument::createDocumentStructure):
- * loader/MediaDocument.cpp:
- (WebCore::MediaTokenizer::createDocumentStructure):
- * loader/PluginDocument.cpp:
- (WebCore::PluginTokenizer::createDocumentStructure):
- * loader/TextDocument.cpp:
- (WebCore::TextTokenizer::write):
- * page/Frame.cpp:
- (WebCore::Frame::selectionComputedStyle):
- (WebCore::Frame::styleForSelectionStart):
- Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
-
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
- * page/DragController.cpp:
- (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
-
-2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24060
- Fix up to accommodate for CanvasPixelArray return.
-
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
- (WebCore::ImageBuffer::putImageData): Ditto.
-
-2009-02-20 Eric Carlson <eric.carlson@apple.com>
-
- Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=24042
- Bug 24042: MediaPlayer should cache plug-in proxy
-
- The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
- MediaPlayer will always have created the private media player object before
- the plug-in is instantiated and calls back with the proxy object. This is not
- true on all platforms because of threading latency, so MediaPlayer should
- cache the plug-in proxy so it can pass it to the media engine at a later time.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
- (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
- (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
- (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
- (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
- (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
- * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
-
-2009-02-20 Eric Carlson <eric.carlson@apple.com>
-
- Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=24063
- Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions.
- Initialize m_internalCall.
- (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
- (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
- (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
- (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
- (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
- (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
- (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
- (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
- (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
- (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
- * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
- add RequireUserGestureRateChangeRestriction.
-
-2009-02-20 Darin Fisher <darin@chromium.org>
-
- Fix build bustage in FileSystemWin.cpp.
-
- Need to return CString() instead of 0 since there are now two CString
- constructors that take a pointer type.
-
- * platform/win/FileSystemWin.cpp:
- (WebCore::openTemporaryFile):
-
-2009-02-20 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23999
- Change license headers to accurately reflect code history.
-
- * platform/ContentType.cpp:
- * platform/ContentType.h:
-
-2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=23999
- Split off MIME type parsing into its own class.
-
- * GNUmakefile.am: Added ContentType sources.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
- * html/HTMLMediaElement.cpp: Changed to use ContentType.
- (WebCore::HTMLMediaElement::selectMediaURL):
- * platform/ContentType.cpp: Added.
- (WebCore::ContentType::ContentType):
- (WebCore::ContentType::parameter):
- (WebCore::ContentType::type):
- * platform/ContentType.h: Added.
- (WebCore::ContentType::raw):
- * platform/MIMETypeRegistry.cpp:
- * platform/MIMETypeRegistry.h:
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::load):
- * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
- * rendering/style/RenderStyleConstants.h: Ditto.
- (WebCore::):
-
-2009-02-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix.
-
- Use CString() instead of 0.
-
- * platform/gtk/FileSystemGtk.cpp:
- (WebCore::openTemporaryFile):
- * platform/qt/FileSystemQt.cpp:
- (WebCore::openTemporaryFile):
-
-2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- When dealing with local files, use a path instead of an URI. GFile
- has problems decoding URIs with percent signs on them.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startGio):
-
-2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Protect the ResourceHandle instance from being destroyed by
- didReceiveData inside the GIO readCallback call, so that
- cancelling caused by scripts is handled correctly.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::readCallback):
-
-2009-02-20 David Kilzer <ddkilzer@apple.com>
-
- Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
-
- Reviewed by Sam Weinig.
-
- * loader/icon/IconDatabaseNone.cpp:
- (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
- (WebCore::IconDatabase::open): Commented out unused parameter.
- (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
- (WebCore::IconDatabase::iconForPageURL): Ditto.
- (WebCore::IconDatabase::iconURLForPageURL): Ditto.
- (WebCore::IconDatabase::defaultIcon): Ditto.
- (WebCore::IconDatabase::retainIconForPageURL): Ditto.
- (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
- (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
- (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
- (WebCore::IconDatabase::setEnabled): Ditto.
- (WebCore::IconDatabase::pageURLMappingCount): Added stub.
- (WebCore::IconDatabase::retainedPageURLCount): Ditto.
- (WebCore::IconDatabase::iconRecordCount): Ditto.
- (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
-
-2009-02-20 David Kilzer <ddkilzer@apple.com>
-
- Add comment to generated code when shadowing a built-in object
-
- Reviewed by Sam Weinig.
-
- * bindings/scripts/CodeGeneratorJS.pm: Added comment to
- generated code output.
-
-2009-02-20 Avi Drissman <avi@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24036
- Keyboard events need disambiguation on the Linux platform too.
-
- * platform/chromium/PlatformKeyboardEventChromium.cpp:
- (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
-
-2009-02-19 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24046
-
- Several improvements to CString:
- 1- Make it possible to initialize a CString from a CStringBuffer
- 2- Make it possible to get a CStringBuffer from a CString
- 3- Change CStringBuffer::data() to return a const pointer to ward off mutation
- 4- Remove unused releaseBuffer() methods.
- 5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
-
- * platform/text/CString.cpp:
- (WebCore::CString::init):
- (WebCore::CString::mutableData):
- (WebCore::CString::newUninitialized):
- (WebCore::CString::copyBufferIfNeeded):
- * platform/text/CString.h:
- (WebCore::CStringBuffer::data):
- (WebCore::CStringBuffer::length):
- (WebCore::CStringBuffer::create):
- (WebCore::CStringBuffer::mutableData):
- (WebCore::CString::CString):
- (WebCore::CString::buffer):
-
-2009-02-19 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24017
- Remove some usage of Document in Worker.
-
- * dom/WorkerContext.h:
- (WebCore::WorkerContext::userAgent):
- * dom/Document.cpp:
- (WebCore::Document::userAgent):
- * dom/Document.h:
- * dom/ScriptExecutionContext.h:
- Added virtual ScriptExecutionContext::userAgent(const KURL&).
- Document implementation uses FrameLoader::userAgent and
- WorkerContext receives the string on creation and stores it in a member.
-
- * dom/Worker.cpp:
- (WebCore::Worker::Worker):
- (WebCore::Worker::notifyFinished):
- * dom/Worker.h:
- (WebCore::Worker::create):
- Instead of Document the Worker constructor now gets a ScriptExecutionContext.
- Start using some methods on SEC (like completeURL() and userAgent()).
- For others, explicitly case to Document and add a FIXME.
- Remove Worker::document() too.
-
-2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
-
- Rubber-stamped by Holger Freyther.
-
- Do not set httpStatus to SOUP_STATUS_OK when serving local files
- to match other ports' behavior, fixing xmlhttprequest test
- regressions.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::queryInfoCallback):
-
-2009-02-19 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
- Do not send loader callbacks during CSS styling
-
- Undo the iChat-specific quirk added in
- <http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
- cache client callbacks during attach() and recalcStyle().
-
- * WebCore.base.exp: Removed
- Settings::setNeedsIChatMemoryCacheCallsQuirk().
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory
- cache client callbacks and remember to enable them afterwards if needed.
- (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory
- cache client callbacks if they were disabled in
- suspendPostAttachCallbacks().
- (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and
- resumePostAttachCallbacks().
- * dom/ContainerNode.h: Made suspendPostAttachCallbacks()
- and resumePostAttachCallbacks() non-static.
- * dom/Document.cpp:
- (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific
- workaround.
- * page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and
- related code.
- (WebCore::Settings::Settings):
- * page/Settings.h:
-
-2009-02-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix.
-
- Build fix after r41092. Make the memoryUsage method
- public. It will be shadowed by cf/mac and for curl/soup/qt
- the implementation from ResourceResponseBase will be used.
-
- * platform/network/ResourceResponseBase.h:
- (WebCore::ResourceResponseBase::memoryUsage):
-
-2009-02-19 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6077775> Should be able to specify
- inactive ::selection color
-
- This patch makes the ::selction pseudo-element work with
- the :window-inactive pseudo type. This was, a user can specify a
- different ::selection style when a window is inactive.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::selectionBackgroundColor):
- (WebCore::RenderObject::selectionForegroundColor):
-
-2009-02-19 Sam Weinig <sam@webkit.org>
-
- Reviewed by Beth Dakin.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=24044
- Update querySelector/querySelectorAll to match the latest spec
-
- Update querySelector and querySelectorAll to match the latest version
- of the Selectors API spec. We now stringify null and undefined to "null"
- and "undefined" respectively instead of to "".
-
- Test: fast/dom/SelectorAPI/undefined-null-stringify.html
-
- * dom/Document.idl:
- * dom/DocumentFragment.idl:
- * dom/Element.idl:
-
-2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=23732
- Rework CachedResource overhead accounting to allow platforms to diverge
- in numbers.
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse
- for its size and to use actual URL size.
- * platform/network/ResourceResponseBase.h:
- (WebCore::ResourceResponseBase::size): Added default size method.
- * platform/network/cf/ResourceResponse.h:
- (WebCore::ResourceResponse::size): Added Win/CF size method
- * platform/network/mac/ResourceResponse.h:
- (WebCore::ResourceResponse::size): Added Mac size method.
-
-2009-02-19 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
-
- - Fix for <rdar://problem/6604968>
-
- On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
- after the call to -[NSView displayRectIgnoringOpacity:inContext:].
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::paint):
-
-2009-02-19 David Hyatt <hyatt@apple.com>
-
- Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
- also consider reflections to be part of their visual overflow. This had already been done for blocks
- and lines, but it wasn't being done yet for replaced elements.
-
- Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
- transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
- layer it pushed until we're done painting the real object (rather than the reflection).
-
- Reviewed by Dan Bernstein
-
- Added fast/reflections/reflection-masks-opacity.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::layout):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::layout):
- (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
- * rendering/RenderReplaced.h:
-
-2009-02-19 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
- <https://bugs.webkit.org/show_bug.cgi?id=23980>
-
- WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.
- * When WorkerRunLoop::runInMode is called, only task for that mode will run.
- * When WorkerRunLoop::run is called (or the default mode is used), then all tasks
- will run regardless of their posted mode.
-
- Here's a demonstration of the api:
-
- RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);
-
- // Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
- // for any tasks that need to be run during this loop.
- nameResolution->setTaskMode("MyCoolMode");
-
- nameResolution->start();
- while (!nameResolution->done()) {
- // Only tasks which are posted for "MyCoolMode" will run.
- workerRunLoop.runInMode(context, "MyCoolMode");
- }
-
- No observable change in behavior, so no test.
-
- * dom/WorkerRunLoop.cpp:
- (WebCore::ModePredicate::ModePredicate):
- (WebCore::ModePredicate::operator()):
- (WebCore::WorkerRunLoop::WorkerRunLoop):
- (WebCore::WorkerRunLoop::~WorkerRunLoop):
- (WebCore::WorkerRunLoop::setSharedTimer):
- (WebCore::WorkerRunLoop::resetSharedTimer):
- (WebCore::WorkerRunLoop::run):
- (WebCore::WorkerRunLoop::runInMode):
- (WebCore::WorkerRunLoop::postTask):
- (WebCore::WorkerRunLoop::postTaskForMode):
- * dom/WorkerRunLoop.h:
- (WebCore::WorkerRunLoop::Task::create):
- (WebCore::WorkerRunLoop::Task::mode):
- (WebCore::WorkerRunLoop::Task::performTask):
- (WebCore::WorkerRunLoop::Task::Task):
-
-2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24034
- Fix up Selection->VisibleSelection change.
-
- * page/chromium/EventHandlerChromium.cpp:
- (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection
- to VisibleSelection.
-
-2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24041
- Correct Skia type conversion issues, fix Chromium Linux build.
-
- * platform/graphics/chromium/FontLinux.cpp:
- (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.
-
-2009-02-19 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20531
- Chromium-part follow-up to the patch landed in r40636
- for bug 20531.
- Remove a static member function alternateFamilyName
- from Chromium's Win/Linux ports of FontCache. In r40636,
- alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
- So, there's no more need for the static member function per
- platform.
-
- * platform/graphics/chromium/FontCacheChromiumWin.cpp:
- * platform/graphics/chromium/FontCacheLinux.cpp:
-
-2009-02-19 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Adele Peterson.
-
- Call documentWillBecomeInactive() from Document::detach to ensure that
- media elements are shut down, because they may be kept alive by references
- from JS past document teardown.
-
- documentWillBecomeInactive() calls renderView()->willMoveOffscreen(), so no
- need to do that in detach() as well.
-
- We no longer need to call documentWillBecomeInactive() from ~Page() (which
- was added for <https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
- supersedes that change.
-
- * dom/Document.cpp:
- (WebCore::Document::detach):
- * page/Page.cpp:
- (WebCore::Page::~Page):
-
-2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24028
- Fix up Skia path changes.
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
- * platform/graphics/skia/PathSkia.cpp:
- (WebCore::boundingBoxForCurrentStroke): Changed call name.
-
-2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Ignore ports on local URLs. This fixes a regression in
- fast/loader/file-URL-with-port-number.html
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startGio):
-
-2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=24011
- KURL's setPort doesn't unset port if 0 is given
-
- Make setPort remove port if 0 is given to it, as promised by the
- comment in KURL's header.
-
- * platform/KURL.cpp:
- (WebCore::KURL::setPort):
-
-2009-02-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Brady Eidson.
-
- - WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
-
- The crash results from re-entry into
- CSSMutableStyleDeclaration::setCssText, which in turn is caused by
- the first style change causing a cached image to load from the memory
- cache, causing load delegate dispatch, and iChat's delegate method
- calling back into WebKit.
-
- The workaround is to use defer delegate callbacks for memory cache. In
- this case, deferring callbacks during image load event dispatch was
- found to be sufficient.
-
- The crash is a regression. See also the discussion in
- <https://bugs.webkit.org/show_bug.cgi?id=22521>.
-
- * WebCore.base.exp: Added
- Settings::setNeedsIChatMemoryCacheCallsQuirk().
- * dom/Document.cpp:
- (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is
- enabled, defer memory cache callbacks during image load event dispatch.
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Initialize
- m_needsIChatMemoryCacheCallsQuirk.
- (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this
- setter.
- * page/Settings.h:
- (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.
-
-2009-02-18 Adam Roben <aroben@apple.com>
-
- Export WebCore::handCursor and Cursor.h
-
- Reviewed by John Sullivan.
-
- * WebCore.base.exp: Added WebCore::handCursor.
- * WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.
-
-2009-02-18 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23992
- REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do
-
- Unable to reduce to a layout test.
-
- * page/Frame.cpp:
- (WebCore::Frame::contentRenderer):
-
-2009-02-18 Evan Stade <estade@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23861
- Stroke font outlines on chromium linux
-
- TEST=LayoutTests/svg/custom/pointer-events-text.svg
-
- * platform/graphics/chromium/FontLinux.cpp:
- (WebCore::Font::drawGlyphs):
-
-2009-02-18 Evan Stade <estade@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23860
- Resync some graphics/skia files with their chromium counterparts
-
- This comes from chromium patches <http://codereview.chromium.org/17633>
- and <http://codereview.chromium.org/17454>
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::clipPath):
- (WebCore::GraphicsContext::fillPath):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::addPath):
- (PlatformContextSkia::currentPath):
- * platform/graphics/skia/PlatformContextSkia.h:
-
-2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
-
- Unreviewed.
-
- Build fix after r41060.
-
- * GNUmakefile.am:
-
-2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=24005
- Add an include to fix Chromium build.
-
- * page/animation/AnimationController.cpp: Add UnusedParam.h include.
-
-2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- Fix symbols.filter location, and add other missing files to the
- autotools build, so that make dist works.
-
- * GNUmakefile.am:
-
-2009-02-18 Zan Dobersek <zandobersek@gmail.com>
-
- Rubber-stamped by Holger Hans Peter Freyther.
-
- Allow POST method for local requests.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startGio):
-
-2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Hans Peter Freyther.
-
- Use KURL in startGio instead of passing a string with the URL, so
- that we can handle removing refs and queries more elegantly. This
- is fixing more regressions that came from the curl->soup switch.
-
- Original work by Zan Dobersek.
-
- * platform/network/ResourceHandle.h:
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::startGio):
-
-2009-02-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp
-
- The implementation is needed to have synchronous loading, e.g. for
- JavaScript interaction. This is fixing various regressions that
- came from the curl->soup switch.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
- (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
- (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
- (WebCore::WebCoreSynchronousLoader::didReceiveData):
- (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- (WebCore::WebCoreSynchronousLoader::didFail):
- (WebCore::WebCoreSynchronousLoader::run):
- (WebCore::ResourceHandle::loadResourceSynchronously):
-
-2009-02-18 Xan Lopez <xan@gnome.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=23989
-
- Based on a patch by Bo Yang <techrazy.yang@gmail.com>
-
- Make the cursor cache global, that's all we really need and
- otherwise we can miss cursor transitions in some situations (see
- the bug for one testcase). Also remove some now useless code.
-
- * platform/Widget.h:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::setCursor):
-
-2009-02-17 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * loader/FrameLoader.cpp:
- (WebCore::toPlugInElement): Don't rely on #if being processed before
- ASSERT.
-
-2009-02-17 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23977: Unnecessary timer related headers in files.
- <https://bugs.webkit.org/show_bug.cgi?id=23977>
-
- No observable change in behavior, so no test.
-
- * dom/Document.cpp:
- * dom/WorkerRunLoop.cpp:
- * dom/WorkerRunLoop.h:
-
-2009-02-17 Peter Abrahamsen <rainhead@gmail.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23958
- <rdar://problem/6587815>
-
- Updated XMLHttpRequest with new header names from the latest Access
- Control draft: http://www.w3.org/TR/access-control/
- - Access-Control-Origin becomes Access-Control-Allow-Origin
- - Access-Control-Credentials becomes Access-Control-Allow-Credentials
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::accessControlCheck):
-
-2009-02-17 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Add missing constructor used for empty values.
-
- * platform/graphics/wx/FontPlatformData.h:
- (WebCore::FontPlatformData::FontPlatformData):
-
-2009-02-17 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Kilzer.
-
- <rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated
-
- Need update after callback.
-
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
-
-2009-02-17 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=23917
- Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
- element.
-
- * DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
-
- * WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
-
- * WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate.
- (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the
- proxy plug-in handles the poster frame.
- (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO.
- (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO.
- (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO
- (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the
- same plug-in for the life of the element.
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player
- network state changes to EMPTY, otherwise we can get out of sync with engine.
- (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO
- (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to
- media player.
- (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player.
- (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate
- <source> element to be used as the initial url for the proxy.
- (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
- * html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate.
- (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
-
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO.
- (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
- * html/HTMLVideoElement.h:
-
- * loader/FrameLoader.cpp:
- (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::MediaPlayer): Remove white space.
- (WebCore::MediaPlayer::setPoster): New, forward call to private player.
- (WebCore::MediaPlayer::deliverNotification): Ditto.
- (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayer::mediaPlayerClient):
-
- * platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
-
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a
- non-element node doesn't need a renderer
- * rendering/RenderPart.h: Ditto.
-
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::RenderPartObject): Ditto.
- (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is
- <video> or <audio>.
- * rendering/RenderPartObject.h:
-
-2009-02-17 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
-
- Don't allow legends to be anything but display:block.
-
- Added fast/forms/inline-ignored-on-legend.html
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * css/html4.css:
- * html/HTMLLegendElement.cpp:
- * html/HTMLLegendElement.h:
- * rendering/RenderLegend.cpp: Removed.
- * rendering/RenderLegend.h: Removed.
- * wml/WMLInsertedLegendElement.cpp:
- * wml/WMLInsertedLegendElement.h:
-
-2009-02-13 Brett Wilson <brettw@dhcp-172-22-71-167.mtv.corp.google.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/attachment.cgi?id=27666
- Fix Chromium build build: forgotten include in RenderObject, sync
- RenderTheme to the recent changes in RenderObject.
-
- * rendering/RenderObject.cpp:
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::updatePressedState):
-
-2009-02-17 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22966
- crash when destroying a webview that opened a page containing <script>
- tags
-
- Fix m_group being set to 0 instead of to m_singlePageGroup when
- GroupName is set to empty
-
- * page/Page.cpp:
- (WebCore::Page::setGroupName):
-
-2009-02-16 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for <rdar://problem/6386623>
-
- I made m_numParsedProperties and m_maxParsedProperties unsigned
- instead of int, and then added an early return from addPropery() if
- m_maxParsedProperties exceeds the max value.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::addProperty):
- (WebCore::CSSParser::rollbackLastProperties):
- (WebCore::CSSParser::clearProperties):
- (WebCore::CSSParser::createFontFaceRule):
- (WebCore::CSSParser::deleteFontFaceOnlyValues):
- * css/CSSParser.h:
-
-2009-02-16 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=16309
- HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
-
- When we originally implemented this command, MSDN documentation said that IE set the
- id attribute of inserted lists to the third argument to execCommand, but IE doesn't
- do this nor do any other browsers.
-
- * editing/EditorCommand.cpp:
- (WebCore::executeInsertOrderedList):
- (WebCore::executeInsertUnorderedList):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::outdentParagraph):
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::insertList):
- (WebCore::InsertListCommand::InsertListCommand):
- (WebCore::InsertListCommand::doApply):
- * editing/InsertListCommand.h:
- (WebCore::InsertListCommand::create):
-
-2009-02-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- - fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
-
- Test: platform/mac/fast/events/pointer-events-dashboard.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty): Do not apply the
- pointer-events property in Dashboard backwards compatibility mode,
- in order to work around misuse of that property by the Stocks widget.
-
-2009-02-16 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=15381
- execCommand justify modifies the contentEditable node
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just
- the body element, but any root editable element.
-
-2009-02-16 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 23979: AX: alt tag not returned for <input type="image">
- https://bugs.webkit.org/show_bug.cgi?id=23979
-
- Test: accessibility/input-image-alt.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityDescription):
-
-2009-02-16 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- The ref data is not properly set unless we use the CreateMatrix function.
-
- https://bugs.webkit.org/show_bug.cgi?id=23978
-
- * platform/graphics/wx/TransformationMatrixWx.cpp:
- (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
-
-2009-02-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
-
- * platform/graphics/FontCache.cpp:
- (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the
- FontPlatformData(float, bool, bool) constructor.
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::FontCache::createFontPlatformData): Changed to pass a valid
- NSFont to the FontPlatformData constructor, instead of implicitly
- passing 0 and then calling setFont().
- * platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter
- of the constructor mandatory.
-
-2009-02-15 David Kilzer <ddkilzer@apple.com>
-
- Move duplicate caretWidth constants to RenderObject.h
-
- Reviewed by Dan Bernstein.
-
- No test since no change in behavior.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localCaretRect): Ditto.
- * rendering/RenderObject.h: Added caretWidth definition.
- * rendering/RenderText.cpp:
- (WebCore::RenderText::localCaretRect): Removed caretWidth.
-
-2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23955
- V8HTMLPlugInCustom returns undefined, which fools interceptors.
-
- * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value.
- (WebCore::NAMED_PROPERTY_SETTER): Ditto.
- (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
- (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
-
-2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23954
- Add V8 custom bindings for CanvasRenderingContext2D.
-
- * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added.
- (WebCore::toV8):
- (WebCore::toCanvasStyle):
(WebCore::ACCESSOR_GETTER):
(WebCore::ACCESSOR_SETTER):
-
-2009-02-13 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler and Dan Bernstein.
-
- <rdar://problem/6583187>
-
- * page/NavigatorBase.cpp:
- Handle PPC64 and X86_64 as well.
-
-2009-02-13 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Fix broken tokenizer regression test that reflected a lifetime bug
- in the document.write optimization. The test failure was trivial to
- reproduce in COLLECT_ON_EVERY_ALLOCATION mode.
-
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::documentWrite): Convert strings to String rather than passing
- the pointer and length to SegmentedString. The optimization is thus
- mostly gone. However, there are two ways to bring it back: 1) Apply
- the patch that makes UString and String share the same buffers.
- 2) Add a UString feature to SegmentedString; simple to do but might
- risk slowing down normal document parsing.
-
-2009-02-13 Adam Treat <adam.treat@torchmobile.com>
-
- Caught by Darin Adler.
-
- No reason to check m_tokenizer twice for 0 in a row.
-
- * dom/Document.cpp:
- (WebCore::Document::write):
-
-2009-02-13 Lyon Chen <lyon.chen@torchmobile.com>
-
- Reviewed by Dave Hyatt.
-
- Take into account y() + height() when calculating getLowerRightCorner.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getLowerRightCorner):
-
-2009-02-13 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Most of this code was in RenderBox, restore the copyright lines.
-
- * rendering/RenderBoxModelObject.cpp:
- * rendering/RenderBoxModelObject.h:
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Get rid of printBoxDecorations, since it is dead code.
-
- Reviewed by Dan Bernstein
-
- * rendering/RenderObject.h:
-
-2009-02-13 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23952
- Add Document::write overload which takes a SegmentedString since this
- is what the tokenizer expects anyway. Modified JSHTMLDocument so it once
- again calls Document::write instead of injecting the string directly into
- the tokenizer. This ensures that all document.write's are funneled through
- one method again, but should still be just as fast for JSHTMLDocumentCustom.
-
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::documentWrite):
- * dom/Document.cpp:
- (WebCore::Document::write):
- * dom/Document.h:
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- Remove updateWidgetPosition on RenderObject. Change RenderView's set of widgets
- to have a tighter type: RenderWidget instead of RenderObject. Devirtualize
- updateWidgetPosition, since all RenderWidgets (except for applets) are now
- RenderParts also.
-
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderPart.cpp:
- * rendering/RenderPart.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::updateWidgetPositions):
- (WebCore::RenderView::addWidget):
- (WebCore::RenderView::removeWidget):
- * rendering/RenderView.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::updateWidgetPosition):
- * rendering/RenderWidget.h:
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- Remove isEditable() on RenderObject. It is dead code.
-
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- Add isTextControl() to RenderObject. Patch call sites thats asked isTextField() || isTextArea() to just use
- isTextControl() instead.
-
- Add a toRenderTextControl converter for doing checked casting to RenderTextControls.
-
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
- * dom/InputElement.cpp:
- (WebCore::InputElement::updateSelectionRange):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::handleReplacedElement):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::selectionStart):
- (WebCore::HTMLInputElement::selectionEnd):
- (WebCore::HTMLInputElement::setSelectionStart):
- (WebCore::HTMLInputElement::setSelectionEnd):
- (WebCore::HTMLInputElement::select):
- (WebCore::HTMLInputElement::defaultEventHandler):
- (WebCore::HTMLInputElement::selection):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::selectionStart):
- (WebCore::HTMLTextAreaElement::selectionEnd):
- (WebCore::HTMLTextAreaElement::setSelectionStart):
- (WebCore::HTMLTextAreaElement::setSelectionEnd):
- (WebCore::HTMLTextAreaElement::select):
- (WebCore::HTMLTextAreaElement::setSelectionRange):
- (WebCore::HTMLTextAreaElement::appendFormData):
- (WebCore::HTMLTextAreaElement::updateValue):
- (WebCore::HTMLTextAreaElement::selection):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isNativeTextControl):
- (WebCore::AccessibilityRenderObject::text):
- (WebCore::AccessibilityRenderObject::selectedText):
- (WebCore::AccessibilityRenderObject::selectedTextRange):
- (WebCore::AccessibilityRenderObject::setSelectedTextRange):
- (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- (WebCore::AccessibilityRenderObject::observableObject):
- * page/Frame.cpp:
- (WebCore::Frame::notifyRendererOfSelectionChange):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isTextControl):
- (WebCore::objectIsRelayoutBoundary):
- * rendering/RenderTextControl.h:
- (WebCore::RenderTextControl::isTextControl):
- (WebCore::toRenderTextControl):
- * rendering/TextControlInnerElements.cpp:
- (WebCore::TextControlInnerTextElement::defaultEventHandler):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::select):
- (WebCore::WMLInputElement::defaultEventHandler):
- (WebCore::WMLInputElement::isConformedToInputMask):
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Get rid of isEdited/setEdited on RenderObject. Devirtualize isEdited/setEdited on RenderTextControl.
- Callers were already asking if the renderer was a text field (or a text area), so it was especially
- pointless to waste a second virtual function call after making one just to determine the object type.
-
- Reviewed by Simon Fraser
-
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler):
- * rendering/RenderObject.h:
- * rendering/RenderTextControl.h:
- (WebCore::RenderTextControl::isEdited):
- (WebCore::RenderTextControl::setEdited):
-
-2009-02-13 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23934
- Skia platform doesn't render text decoration shadows.
-
- Makes Skia render text decoration shadows correctly. We weren't
- preparing the SkPaint correctly and didn't have a couple of checks
- CG has. Additionally makes the fillColor/strokeColor methods
- consistent.
-
- This behavior is covered by existing layout tests (see bug for list).
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::Font::drawGlyphs):
- (WebCore::Font::drawComplexText):
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::drawLineForText):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::effectiveFillColor):
- (PlatformContextSkia::effectiveStrokeColor):
- * platform/graphics/skia/PlatformContextSkia.h:
-
-2009-02-12 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23944
- KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
-
- * platform/KURL.h:
- * platform/KURLGoogle.cpp:
- (WebCore::KURLGooglePrivate::setUtf8):
- (WebCore::KURLGooglePrivate::setAscii):
- (WebCore::KURLGooglePrivate::init):
- (WebCore::KURLGooglePrivate::replaceComponents):
- (WebCore::KURL::KURL):
- * platform/KURLGooglePrivate.h:
-
-2009-02-13 David Hyatt <hyatt@apple.com>
-
- Remove leftmost/rightmost/lowestPosition from RenderObject. They only need to be called on boxes.
-
- Reviewed by Dan Bernstein
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::computeScrollDimensions):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::lowestPosition):
- (WebCore::RenderMedia::rightmostPosition):
- (WebCore::RenderMedia::leftmostPosition):
- * rendering/RenderObject.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::lowestPosition):
- (WebCore::RenderTableSection::rightmostPosition):
- (WebCore::RenderTableSection::leftmostPosition):
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Fix build with ACCELERATED_COMPOSITING turned on.
-
- toRenderBox()->x() asserts for a layer on an inline; use
- m_owningLayer->renderBoxX() instead.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::paintIntoLayer):
-
-2009-02-12 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Speed up document.write a bit.
-
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from
- UString to String and to avoid appending strings. Also added code to handle
- newlines efficiently.
- (WebCore::JSHTMLDocument::write): Changed to use documentWrite.
- (WebCore::JSHTMLDocument::writeln): Ditto.
-
- * dom/Document.cpp:
- (WebCore::Document::prepareToWrite): Added. Refactored the initialization part
- of write into a separate function for use in the JavaScript binding.
- (WebCore::Document::write): Changed to call prepareToWrite.
-
- * dom/Document.h: Added declaration for prepareToWrite.
-
-2009-02-13 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Fixes crash in the Qt port on Windows with comboboxes
-
- The focusWidget in the input context is not reset properly.
- The QApplication::setFocusWidget() wont reset the IC if the reason is
- PopupFocusReason, this is not ideal. For the time being we are going
- to do this from webkit itself.
-
- * platform/qt/QWebPopup.cpp:
- (WebCore::QWebPopup::hidePopup):
-
-2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix, typo while tweaking last patch for commit.
-
- * platform/wx/wxcode/gtk/fontprops.cpp:
- (GetTextExtent):
-
-2009-02-12 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Use Cairo/PANGO to fix text measurements and implement proper
- non-kerned text drawing on wxGTK.
-
- https://bugs.webkit.org/show_bug.cgi?id=17727
-
- * platform/graphics/GlyphBuffer.h:
- * platform/graphics/wx/FontPlatformDataWx.cpp:
- (WebCore::fontWeightToWxFontWeight):
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/wx/wxcode/fontprops.h:
- * platform/wx/wxcode/gtk/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
- (GetTextExtent):
- * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
- (WebCore::pangoFontMap):
- (WebCore::createPangoFontForFont):
- (WebCore::createScaledFontForFont):
- (WebCore::pango_font_get_glyph):
- (WebCore::drawTextWithSpacing):
- * platform/wx/wxcode/non-kerned-drawing.h:
-
-2009-02-12 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=23942
-
- Hook up 3D CSS transforms to the accelerated compositor backend.
- Not enabled by default.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- (WebCore::ensurePropertyMap):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::willNeedService):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::willNeedService):
- * platform/graphics/GraphicsLayer.cpp:
- (WebCore::GraphicsLayer::TransformValueList::makeFunctionList):
- (WebCore::GraphicsLayer::dumpProperties):
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::copyTransform):
- (WebCore::getValueFunctionNameForTransformOperation):
- (WebCore::GraphicsLayerCA::animateTransform):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::updateBoxModelInfoFromStyle):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::hasTransformStyle3D):
- (WebCore::RenderLayer::hasPerspective):
- (WebCore::RenderLayer::perspectiveTransform):
- * rendering/RenderLayer.h:
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayers):
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- (WebCore::RenderLayerBacking::computeTransformOrigin):
- (WebCore::RenderLayerBacking::computePerspectiveOrigin):
- * rendering/RenderLayerBacking.h:
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::has3DContent):
- (WebCore::requiresCompositingLayerForTransform):
- (WebCore::RenderLayerCompositor::requiresCompositingLayer):
- (WebCore::RenderLayerCompositor::layerHas3DContent):
- * rendering/RenderLayerCompositor.h:
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Eric Seidel
-
- Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
- containingBlock()->availableHeight(). The latter reads better anyway. Rename containingBlockWidth() to
- containingBlockWidthForContent() and move it to RenderBoxModelObject.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::containingBlockWidthForContent):
- (WebCore::RenderBox::calcWidth):
- (WebCore::RenderBox::calcReplacedWidthUsing):
- * rendering/RenderBox.h:
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::relativePositionOffsetX):
- (WebCore::RenderBoxModelObject::relativePositionOffsetY):
- (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
- * rendering/RenderBoxModelObject.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::marginLeft):
- (WebCore::RenderInline::marginRight):
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::calcReplacedWidth):
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Fix non-Mac builds by adding Matrix3DTransformOperation.* and
- PerspectiveTransformOperation.*. Cleaned out some cruft in
- the WebCore.vcproj fle.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-02-12 David Smith <catfish.man@gmail.com>
-
- Reviewed by Dave Hyatt.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=23935
- Nested :not() and non-simple selectors in :not() should be invalid
-
- * css/CSSGrammar.y: Reject nested :not()
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now
-
-2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes.
-
- * WebCoreSources.bkl:
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Fix build with ACCELERATED_COMPOSITING turned on.
-
- Need to cast toRenderBox() in order to call overflowClipRect().
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
-
-2009-02-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix windows build.
-
- * css/CSSParser.h:
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect. Move them to RenderBox, since these methods
- only apply to boxes. Devirtualize clipRect, since it was not subclassed. Move controlClip stuff to RenderBox also.
-
- Reviewed by Simon Fraser
-
- * editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::overflowClipRect):
- (WebCore::RenderBox::clipRect):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::hasControlClip):
- (WebCore::RenderBox::controlClipRect):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::paint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::calculateClipRects):
- (WebCore::RenderLayer::calculateRects):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::hasClip):
- (WebCore::RenderObject::hasOverflowClip):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::overflowClipRect):
- * rendering/RenderTable.h:
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)
-
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::GraphicsLayerCA::setBasicAnimation):
-
-2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
-
- Not reviewed.
-
- Release build fix when VIDEO is disabled (it should also
- help the builds with WORKERS or XSLT disabled).
-
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when
- VIDEO is disabled.
- (jsDOMWindowBaseWorker): Ditto for WORKERS.
- (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
-
-2009-02-12 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=23923
- Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
- Supporting this requires that we know when we are processing a media engine callback so
- we don't turn around and tell the media player to change the volume when it is reporting
- a volume change.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback
- (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged
- to make it easier to maintain m_processingMediaPlayerCallback.
- (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
- (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto.
- (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New
- (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing
- a callback from the engine.
- * html/HTMLMediaElement.h:
- (WebCore::HTMLMediaElement::processingMediaPlayerCallback): New, return true if (m_processingMediaPlayerCallback>0)
- (WebCore::HTMLMediaElement::beginProcessingMediaPlayerCallback): New, increment m_processingMediaPlayerCallback
- (WebCore::HTMLMediaElement::endProcessingMediaPlayerCallback): New, decrement m_processingMediaPlayerCallback
-
-2009-02-12 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser.
-
- Support MPEG content on Mac and Windows.
- <rdar://problem/5917509>
- https://bugs.webkit.org/show_bug.cgi?id=23495
-
- Test: media/audio-mpeg-supported.html
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::disableUnsupportedTracks):
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: fix typo added in r40925
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig
-
- Move containsFloats, hasOverhangingFloats, shrinkToAvoidFloats and avoidsFloats down to
- RenderBox, since these methods only apply to boxes.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::clearFloatsIfNeeded):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::clearFloats):
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- (WebCore::RenderBlock::calcBlockPrefWidths):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::containsFloats):
- (WebCore::RenderBlock::hasOverhangingFloats):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::shrinkToAvoidFloats):
- (WebCore::RenderBox::avoidsFloats):
- * rendering/RenderBox.h:
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isFloatingOrPositioned):
- * rendering/RenderView.h:
-
-2009-02-12 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23908
-
- Added parsing of 3d transform functions and properties
- (perspective, perspective-origin, transform-style-3d,
- and backface-visibility).
-
- Test: transforms/3d/cssmatrix-3d-interface.xhtml
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::):
- (WebCore::computedTransform):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::parseFillProperty):
- (WebCore::CSSParser::parseTransformOriginShorthand):
- (WebCore::TransformOperationInfo::TransformOperationInfo):
- (WebCore::CSSParser::parseTransform):
- (WebCore::CSSParser::parseTransformOrigin):
- (WebCore::CSSParser::parsePerspectiveOrigin):
- * css/CSSParser.h:
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::isUnitTypeLength):
- * css/CSSPropertyNames.in:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- (WebCore::convertToLength):
- (WebCore::CSSStyleSelector::applyProperty):
- (WebCore::CSSStyleSelector::mapFillSize):
- (WebCore::CSSStyleSelector::mapFillXPosition):
- (WebCore::CSSStyleSelector::mapFillYPosition):
- (WebCore::getTransformOperationType):
- (WebCore::CSSStyleSelector::createTransformOperations):
- * css/CSSValueKeywords.in:
- * css/WebKitCSSTransformValue.cpp:
- (WebCore::WebKitCSSTransformValue::cssText):
- * css/WebKitCSSTransformValue.h:
- (WebCore::WebKitCSSTransformValue::):
- * css/WebKitCSSTransformValue.idl:
- * platform/graphics/transforms/Matrix3DTransformOperation.cpp:
- * platform/graphics/transforms/Matrix3DTransformOperation.h:
- * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
- * platform/graphics/transforms/PerspectiveTransformOperation.h:
- * platform/graphics/transforms/RotateTransformOperation.cpp:
- (WebCore::RotateTransformOperation::blend):
- * platform/graphics/transforms/RotateTransformOperation.h:
- (WebCore::RotateTransformOperation::RotateTransformOperation):
- * platform/graphics/transforms/ScaleTransformOperation.h:
- (WebCore::ScaleTransformOperation::ScaleTransformOperation):
- * platform/graphics/transforms/TransformOperation.h:
- (WebCore::TransformOperation::is3DOperation):
- * platform/graphics/transforms/TransformOperations.h:
- (WebCore::TransformOperations::has3DOperation):
- * platform/graphics/transforms/TranslateTransformOperation.h:
- (WebCore::TranslateTransformOperation::TranslateTransformOperation):
-
-2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
-
- * webcore-base.bkl:
-
-2009-02-12 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.
-
- * platform/mac/SharedBufferMac.mm: Change to use RefPtr<> instead of ref()/deref().
- (-[WebCoreSharedBufferData dealloc]):
- (-[WebCoreSharedBufferData finalize]):
- (-[WebCoreSharedBufferData initWithSharedBuffer:]):
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Remove calcWidth from RenderObject. Nobody ever called it on RenderObjects.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderObject.h:
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Mark Rowe
-
- Fix for regression where form controls would paint yellow highlights. The containsComposition check needs to
- null check node() now.
-
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paint):
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Build fix
-
- Change Animation::setDirection() to take the new enum value, and fix
- the single caller.
-
- Fix build error in MediaPlayerPrivateQTKit.h.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapAnimationDirection):
- * platform/animation/Animation.h:
- (WebCore::Animation::setDirection):
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- Remove the overrideSize methods from RenderObject. Devirtualize all of the accessors on RenderBox.
-
- * rendering/RenderBox.h:
- * rendering/RenderObject.h:
-
-2009-02-12 Eric Carlson <eric.carlson@apple.com>
-
- Darin Adler, Antti Koivisto, Holger Hans Peter Freyther
-
- Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
- https://bugs.webkit.org/show_bug.cgi?id=23797
-
- * WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to
- MediaPlayer::load so it can choose the right media engine
- (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry
- functions to strip params from the url and extract the codecs parameter. call
- MediaPlayer::supportsType to see if we can open the file since only a media engine can
- answer questions about supported type+codecs.
- * html/HTMLMediaElement.h:
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter
- (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
- * platform/MIMETypeRegistry.h:
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate):
- (WebCore::NullMediaPlayerPrivate::load):
- (WebCore::NullMediaPlayerPrivate::cancelLoad):
- (WebCore::NullMediaPlayerPrivate::play):
- (WebCore::NullMediaPlayerPrivate::pause):
- (WebCore::NullMediaPlayerPrivate::naturalSize):
- (WebCore::NullMediaPlayerPrivate::hasVideo):
- (WebCore::NullMediaPlayerPrivate::setVisible):
- (WebCore::NullMediaPlayerPrivate::duration):
- (WebCore::NullMediaPlayerPrivate::currentTime):
- (WebCore::NullMediaPlayerPrivate::seek):
- (WebCore::NullMediaPlayerPrivate::seeking):
- (WebCore::NullMediaPlayerPrivate::setEndTime):
- (WebCore::NullMediaPlayerPrivate::setRate):
- (WebCore::NullMediaPlayerPrivate::paused):
- (WebCore::NullMediaPlayerPrivate::setVolume):
- (WebCore::NullMediaPlayerPrivate::networkState):
- (WebCore::NullMediaPlayerPrivate::readyState):
- (WebCore::NullMediaPlayerPrivate::maxTimeSeekable):
- (WebCore::NullMediaPlayerPrivate::maxTimeBuffered):
- (WebCore::NullMediaPlayerPrivate::dataRate):
- (WebCore::NullMediaPlayerPrivate::totalBytesKnown):
- (WebCore::NullMediaPlayerPrivate::totalBytes):
- (WebCore::NullMediaPlayerPrivate::bytesLoaded):
- (WebCore::NullMediaPlayerPrivate::setRect):
- (WebCore::NullMediaPlayerPrivate::paint):
- (WebCore::createNullMediaPlayer):
- Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.
-
- (WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
- (WebCore::installedMediaEngines): New, returns vector of all installed engines.
- (WebCore::addMediaEngine): New, add a media engine to the cache.
- (WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
- (WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
- (WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
- (WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right
- media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
- based on the MIME type and codecs parameter.
- (WebCore::MediaPlayer::currentTime): Remove excess white space.
- (WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
- indicate "maybe" condition.
- (WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
- (WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.
-
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayer::):
- (WebCore::MediaPlayer::frameView): accessor function.
-
- * platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines.
- (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface):
- (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):
-
- * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::create): New, media engine factory function
- (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory
- (WebCore::MediaPlayerPrivate::load): URL is a const String.
- (WebCore::MediaPlayerPrivate::duration): Declare const.
- (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
- (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
- (WebCore::MediaPlayerPrivate::networkState): Ditto.
- (WebCore::MediaPlayerPrivate::readyState): Ditto.
- (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto.
- (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto.
- (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
- (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto.
- (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto.
- (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
- (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- (WebCore::MediaPlayerPrivate::isAvailable):
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function
- (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory
- (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly,
- use accessor function.
- (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto.
- (WebCore::MediaPlayerPrivate::paint): Ditto.
- (WebCore::mimeTypeCache): New.
- (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function.
- (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool
- (-[WebCoreMovieObserver initWithCallback:]): fix formatting
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::create):
- (WebCore::MediaPlayerPrivate::registerMediaEngine):
- (WebCore::MediaPlayerPrivate::supportsType):
- (WebCore::MediaPlayerPrivate::load): URL is a const String.
- * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- (WebCore::MediaPlayerPrivate::isAvailable):
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- (WebCore::MediaPlayerPrivate::create): New, media engine factory function
- (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory
- (WebCore::MediaPlayerPrivate::load): URL is a const String.
- (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly,
- use accessor function.
- (WebCore::mimeTypeCache): New.
- (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function.
- (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
-
-2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Test: fast/dom/prefixed-image-tag.xhtml
-
- Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
-
- Instead we now directly propage the QualifiedName inside the generated Factory.
-
- Test: fast/dom/prefixed-image-tag.xhtml
-
- * dom/Document.cpp:
- (WebCore::Document::createElement): Removed the setPrefix work-around
- and replaced it with an ASSERT to catch mistakes inside the Factory code.
- Remove the unneeded ExceptionCode argument.
-
- (WebCore::Document::createElementNS): Removed ExceptionCode argument.
- * dom/Document.h: Updated the signature.
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
- * dom/XMLTokenizerQt.cpp: Ditto.
- (WebCore::XMLTokenizer::parseStartElement): Ditto.
-
- * dom/make_names.pl: Implemented the QualifiedName propogation logic
- in the Factory.
-
-2009-02-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23188
-
- Define enum values for Animation::direction(), and one for
- IterationCountInfinite to make the code more self-documenting.
-
- Order the member vars of Animation to optimize packing.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * platform/animation/Animation.cpp:
- (WebCore::Animation::Animation):
- (WebCore::Animation::operator=):
- (WebCore::Animation::animationsMatch):
- * platform/animation/Animation.h:
- (WebCore::Animation::):
- (WebCore::Animation::direction):
- (WebCore::Animation::initialAnimationDirection):
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::GraphicsLayerCA::setBasicAnimation):
- (WebCore::GraphicsLayerCA::setKeyframeAnimation):
-
-2009-02-12 Christian Dywan <christian@twotoasts.de>
-
- Reviewed by Holger Freyther.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.
-
-2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 23826: Potential bug with before/after rule while moving element from one document to another
-
- Moved the document before/after toggle from the constructor to insertedIntoDocument.
-
- Test: fast/css-generated-content/beforeAfter-interdocument.html
-
- * html/HTMLQuoteElement.cpp:
- (WebCore::HTMLQuoteElement::HTMLQuoteElement):
- (WebCore::HTMLQuoteElement::insertedIntoDocument):
- * html/HTMLQuoteElement.h:
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Reviewed by Simon Fraser
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
-
- I have no idea why this broke. As far as I can tell the old code never should have worked in
- the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node
- in order to attempt a wheel scroll.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleWheelEvent):
-
-2009-02-12 David Hyatt <hyatt@apple.com>
-
- Move the functions that paint borders, box shadows and border images into RenderBoxModelObject. drawBorder and drawBorderArc, because they are used
- for outlines as well as borders, need to stay in RenderObject. Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
- more generic use. Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.
-
- Reviewed by Simon Fraser
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::paintFillLayer):
- (WebCore::InlineFlowBox::paintBoxShadow):
- (WebCore::InlineFlowBox::paintBoxDecorations):
- (WebCore::InlineFlowBox::paintMask):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintColumns):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintNinePieceImage):
- (WebCore::RenderBoxModelObject::paintBorder):
- (WebCore::RenderBoxModelObject::paintBoxShadow):
- * rendering/RenderBoxModelObject.h:
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::paintBorderMinusLegend):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::paintOutlineForLine):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::drawLineForBoxSide):
- (WebCore::RenderObject::drawArcForBoxSide):
- (WebCore::RenderObject::paintOutline):
- * rendering/RenderObject.h:
- (WebCore::):
- (WebCore::RenderObject::hasBoxDecorations):
- * rendering/RenderTableCell.cpp:
- (WebCore::CollapsedBorders::addBorder):
- (WebCore::RenderTableCell::paintCollapsedBorder):
-
-2009-02-12 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser
-
- Bug 18322: video element should have ui when scripting is disabled
- https://bugs.webkit.org/show_bug.cgi?id=18322
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
- * manual-tests/media-controls-when-javascript-disabled.html: Added.
-
-2009-02-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23906
- Add custom V8 bindings for HTMLPlugInElement.
-
- * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added.
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::INDEXED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
(WebCore::NAMED_PROPERTY_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
(WebCore::INDEXED_PROPERTY_GETTER):
(WebCore::INDEXED_PROPERTY_SETTER):
-
-2009-02-12 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Mark Rowe.
-
- [GTK] Soup backend must handle upload of multiple files
- https://bugs.webkit.org/show_bug.cgi?id=18343
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::):
- (WebCore::freeFileMapping):
- (WebCore::ResourceHandle::startHttp): Support multipart request bodies
- mmap'ing files to be uploaded.
-
-2009-02-12 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build following r40871 which changed RenderObject::element()
- into RenderObject::node().
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::getMediaElementFromRenderObject):
- (WebCore::RenderThemeQt::getMediaControlForegroundColor):
-
-2009-02-12 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix.
-
- * platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.
-
-2009-02-12 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Change worker code to use different proxy class pointers.
- https://bugs.webkit.org/show_bug.cgi?id=23859
-
- This is a step towards using separate proxies in multi-process implementation.
-
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- * dom/Worker.cpp:
- (WebCore::Worker::Worker):
- (WebCore::Worker::~Worker):
- (WebCore::Worker::postMessage):
- (WebCore::Worker::terminate):
- (WebCore::Worker::hasPendingActivity):
- (WebCore::Worker::notifyFinished):
- (WebCore::Worker::dispatchMessage):
- * dom/Worker.h:
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::~WorkerContext):
- (WebCore::WorkerContext::reportException):
- (WebCore::WorkerContext::addMessage):
- (WebCore::WorkerContext::postMessage):
- (WebCore::WorkerContext::dispatchMessage):
- * dom/WorkerContext.h:
- * dom/WorkerContextProxy.h:
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerContextTask::performTask):
- (WebCore::MessageWorkerTask::performTask):
- (WebCore::WorkerContextProxy::create):
- (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
- (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
- (WebCore::WorkerMessagingProxy::startWorkerContext):
- (WebCore::postConsoleMessageTask):
- (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
- (WebCore::WorkerMessagingProxy::workerThreadCreated):
- * dom/WorkerMessagingProxy.h:
- * dom/WorkerObjectProxy.h:
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::create):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::workerThread):
- * dom/WorkerThread.h:
- (WebCore::WorkerThread::workerObjectProxy):
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
-
-2009-02-12 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23688: ThreadableLoader needs a sync implementation for Workers.
- <https://bugs.webkit.org/show_bug.cgi?id=23688>
-
- Add ResourceError to ThreadableLoaderClient.
-
- No observable change in behavior, so no test.
-
- * loader/DocumentThreadableLoader.cpp:
- (WebCore::DocumentThreadableLoader::create):
- (WebCore::DocumentThreadableLoader::willSendRequest):
- (WebCore::DocumentThreadableLoader::didFail):
- * loader/ThreadableLoaderClient.h:
- (WebCore::ThreadableLoaderClient::didFail):
- (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
- * loader/ThreadableLoaderClientWrapper.h:
- (WebCore::ThreadableLoaderClientWrapper::didFail):
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- (WebCore::workerContextDidFail):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
- * loader/WorkerThreadableLoader.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::didFail):
- (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
- * xml/XMLHttpRequest.h:
-
-2009-02-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Fix the build on Leopard with ACCELERATED_COMPOSITING turned on.
-
- * WebCore.xcodeproj/project.pbxproj:
- FloatPoint3D needs to be a private header, since it's included by GraphicsLayer.h
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::getTransformFunctionValue):
- (WebCore::caValueFunctionSupported):
- (WebCore::GraphicsLayerCA::setAnchorPoint):
- (WebCore::GraphicsLayerCA::setPreserves3D):
- (WebCore::GraphicsLayerCA::setContentsToImage):
- (WebCore::GraphicsLayerCA::setBasicAnimation):
- (WebCore::GraphicsLayerCA::setKeyframeAnimation):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isRootLayer):
- Fix isRootLayer to return true for the renderView's layer, not the root
- renderer's layer.
-
-2009-02-11 Adele Peterson <adele@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23910
- <rdar://problem/6160546> REGRESSION: In Full page mode, movie controller hides when I drag the knob if movie is playing
-
- * rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent):
- When we get a mouseOut event, consider the mouse as still within the RenderMedia if the relatedTarget is a descendant.
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Remove all of the inline box wrapper functions from RenderObject, since they only apply to RenderBox. Devirtualize the functions.
- Patch all of the call sites to convert to a RenderBox.
-
- Reviewed by Simon Fraser
-
- * dom/Position.cpp:
- (WebCore::nextRenderedEditable):
- (WebCore::previousRenderedEditable):
- (WebCore::Position::getInlineBoxAndOffset):
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::deleteLine):
- (WebCore::InlineBox::extractLine):
- (WebCore::InlineBox::attachLine):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderObjectChildList.cpp:
- (WebCore::RenderObjectChildList::removeChildNode):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::textWithHardLineBreaks):
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Eliminate createInlineBox and dirtyLineBoxes from RenderObject. These functions have been devirtualized.
- The single call site now calls a helper function that just bit checks and casts before calling the correct
- type. RenderBlock's dirtyLineBoxes function was dead code (caused by the RenderFlow deletion), so it has
- just been removed.
-
- Reviewed by Eric Seidel
-
- * rendering/RenderBR.cpp:
- * rendering/RenderBR.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::createRootInlineBox):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::createInlineBox):
- * rendering/RenderBox.h:
- * rendering/RenderCounter.cpp:
- * rendering/RenderCounter.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::createInlineFlowBox):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::createTextBox):
- * rendering/RenderSVGInlineText.h:
- (WebCore::RenderSVGInlineText::isSVGText):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::createTextBox):
- (WebCore::RenderText::createInlineTextBox):
- * rendering/RenderText.h:
- * rendering/bidi.cpp:
- (WebCore::createInlineBoxForRenderer):
- (WebCore::RenderBlock::createLineBoxes):
- (WebCore::RenderBlock::constructLine):
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-02-11 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23905
-
- Adds support for 3D CSS properties (transform-style-3d, perspective,
- perspective-origin, and backface-visibility) to RenderStyle and friends
-
- * platform/graphics/transforms/TransformOperation.h
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
- (WebCore::RenderStyle::applyTransform):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::transformOriginZ):
- (WebCore::InheritedFlags::hasTransformRelatedProperty):
- (WebCore::InheritedFlags::transformStyle3D):
- (WebCore::InheritedFlags::backfaceVisibility):
- (WebCore::InheritedFlags::perspective):
- (WebCore::InheritedFlags::perspectiveOriginX):
- (WebCore::InheritedFlags::perspectiveOriginY):
- (WebCore::InheritedFlags::setTransformOriginZ):
- (WebCore::InheritedFlags::setTransformStyle3D):
- (WebCore::InheritedFlags::setBackfaceVisibility):
- (WebCore::InheritedFlags::setPerspective):
- (WebCore::InheritedFlags::setPerspectiveOriginX):
- (WebCore::InheritedFlags::setPerspectiveOriginY):
- (WebCore::InheritedFlags::initialTransformOriginZ):
- (WebCore::InheritedFlags::initialTransformStyle3D):
- (WebCore::InheritedFlags::initialBackfaceVisibility):
- (WebCore::InheritedFlags::initialPerspective):
- (WebCore::InheritedFlags::initialPerspectiveOriginX):
- (WebCore::InheritedFlags::initialPerspectiveOriginY):
- * rendering/style/RenderStyleConstants.h:
- (WebCore::):
- * rendering/style/StyleRareNonInheritedData.cpp:
- (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- (WebCore::StyleRareNonInheritedData::operator==):
- * rendering/style/StyleRareNonInheritedData.h:
- * rendering/style/StyleTransformData.cpp:
- (WebCore::StyleTransformData::StyleTransformData):
- (WebCore::StyleTransformData::operator==):
- * rendering/style/StyleTransformData.h:
-
-2009-02-11 Simon Fraser <simon.fraser@apple.com>
-
- No review.
-
- Fix ACCELERATED_COMPOSITING build.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::createGraphicsLayer):
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
-
-2009-02-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23862
-
- Add a bit on RenderStyle that gets set when running accelerated
- transitions of transform or opacity. These ensure that styles
- compare as different during the transition, so that interruption
- can be detected reliably.
-
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::isRunningAcceleratedAnimation):
- (WebCore::InheritedFlags::setIsRunningAcceleratedAnimation):
- * rendering/style/StyleRareNonInheritedData.cpp:
- (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- (WebCore::StyleRareNonInheritedData::operator==):
- * rendering/style/StyleRareNonInheritedData.h:
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Eliminate the virtual position() function from RenderObject. Rename the position() overrides
- in RenderText and RenderBox to positionLineBox and devirtualize them.
-
- Patch the one call site to just check for isText() and isBox() and call the methods directly.
-
- Remove some unnecessary overrides of position() on table sections and rows.
-
- Reviewed by Simon Fraser
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::positionLineBox):
- * rendering/RenderBox.h:
- * rendering/RenderObject.h:
- * rendering/RenderSVGRoot.cpp:
- * rendering/RenderSVGRoot.h:
- * rendering/RenderTableRow.h:
- (WebCore::RenderTableRow::lineHeight):
- * rendering/RenderTableSection.h:
- (WebCore::RenderTableSection::lineHeight):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::positionLineBox):
- * rendering/RenderText.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::computeVerticalPositionsForLine):
-
-2009-02-11 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23901
- Add HTML options/collections V8 custom bindings.
-
- * bindings/v8/custom/V8HTMLCollectionCustom.cpp: Added.
- (WebCore::getNamedItems):
- (WebCore::getItem):
+ * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::INDEXED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::removeElement):
+ * bindings/v8/custom/V8InspectorControllerCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::INDEXED_ACCESS_CHECK):
+ (WebCore::NAMED_ACCESS_CHECK):
+ * bindings/v8/custom/V8MessageChannelConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8MessagePortCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_GETTER):
(WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8NavigatorCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ * bindings/v8/custom/V8NodeCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8NodeIteratorCustom.cpp:
+ (WebCore::toV8):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Added.
+ * bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
- * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SVGLengthCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SVGMatrixCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8StyleSheetListCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8TreeWalkerCustom.cpp:
+ (WebCore::toV8):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8WebKitPointConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::ACCESSOR_GETTER):
(WebCore::ACCESSOR_SETTER):
+ (WebCore::SetTimeoutOrInterval):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+ * bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::getEventListener):
+ (WebCore::ACCESSOR_GETTER):
(WebCore::ACCESSOR_SETTER):
- * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Added.
+ * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- (WebCore::removeElement):
- * bindings/v8/custom/V8HTMLSelectElementCustom.h: Added.
- * bindings/v8/custom/V8NamedNodesCollection.cpp: Added.
- (WebCore::V8NamedNodesCollection::item):
- (WebCore::V8NamedNodesCollection::itemWithName):
- * bindings/v8/custom/V8NamedNodesCollection.h: Added.
- (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
- (WebCore::V8NamedNodesCollection::length):
-
-2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
-
- Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
- This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.
-
- Reviewed by Timothy Hatcher.
-
- * inspector/InspectorClient.h:
- * inspector/InspectorController.cpp:
- (WebCore::hiddenPanels):
- (WebCore::InspectorController::hiddenPanels):
- (WebCore::InspectorController::windowScriptObjectAvailable):
- * inspector/InspectorController.h:
- * inspector/front-end/inspector.js:
- (WebInspector.loaded):
- * loader/EmptyClients.h:
- (WebCore::EmptyInspectorClient::hiddenPanels):
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Combine RenderObject::element() and RenderObject::node() into a single function.
- node() now has the "anonymous bit" checking behavior of element() and will
- return 0 for anonymous content. This patch switches all callers of element()
- to node() and patches old callers of node() to deal with situations where they
- did not expect node() to be 0. A bunch of node() calls were calling stuff on
- Document that they clearly didn't intend, so overall this is a nice improvement.
-
- Reviewed by Sam Weinig
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- * dom/Element.cpp:
- (WebCore::Element::offsetParent):
- * dom/Position.cpp:
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- * editing/ModifySelectionListLevel.cpp:
- (WebCore::getStartEndListChildren):
- (WebCore::IncreaseSelectionListLevelCommand::doApply):
- (WebCore::DecreaseSelectionListLevelCommand::doApply):
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::advance):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- * editing/visible_units.cpp:
- (WebCore::startPositionForLine):
- (WebCore::endPositionForLine):
- * page/AXObjectCache.cpp:
- (WebCore::AXObjectCache::get):
- * page/AccessibilityList.cpp:
- (WebCore::AccessibilityList::isUnorderedList):
- (WebCore::AccessibilityList::isOrderedList):
- (WebCore::AccessibilityList::isDefinitionList):
- * page/AccessibilityListBox.cpp:
- (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isPasswordField):
- (WebCore::AccessibilityRenderObject::isFileUploadButton):
- (WebCore::AccessibilityRenderObject::isInputImage):
- (WebCore::AccessibilityRenderObject::isMultiSelect):
- (WebCore::AccessibilityRenderObject::isControl):
- (WebCore::AccessibilityRenderObject::getAttribute):
- (WebCore::AccessibilityRenderObject::anchorElement):
- (WebCore::AccessibilityRenderObject::actionElement):
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- (WebCore::AccessibilityRenderObject::helpText):
- (WebCore::AccessibilityRenderObject::textUnderElement):
- (WebCore::AccessibilityRenderObject::hasIntValue):
- (WebCore::AccessibilityRenderObject::intValue):
- (WebCore::AccessibilityRenderObject::labelElementContainer):
- (WebCore::AccessibilityRenderObject::title):
- (WebCore::AccessibilityRenderObject::accessibilityDescription):
- (WebCore::AccessibilityRenderObject::boundingBoxRect):
- (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
- (WebCore::AccessibilityRenderObject::titleUIElement):
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- (WebCore::AccessibilityRenderObject::text):
- (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
- (WebCore::AccessibilityRenderObject::accessKey):
- (WebCore::AccessibilityRenderObject::setSelectedTextRange):
- (WebCore::AccessibilityRenderObject::url):
- (WebCore::AccessibilityRenderObject::isFocused):
- (WebCore::AccessibilityRenderObject::setFocused):
- (WebCore::AccessibilityRenderObject::setValue):
- (WebCore::AccessibilityRenderObject::isEnabled):
- (WebCore::AccessibilityRenderObject::visiblePositionRange):
- (WebCore::AccessibilityRenderObject::index):
- (WebCore::AccessibilityRenderObject::activeDescendant):
- (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- (WebCore::AccessibilityRenderObject::observableObject):
- (WebCore::AccessibilityRenderObject::roleValue):
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- (WebCore::AccessibilityTable::title):
- * page/AccessibilityTableCell.cpp:
- (WebCore::AccessibilityTableCell::titleUIElement):
- * page/AccessibilityTableColumn.cpp:
- (WebCore::AccessibilityTableColumn::headerObjectForSection):
- * page/AccessibilityTableRow.cpp:
- (WebCore::AccessibilityTableRow::headerObject):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchMouseEvent):
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- (WebCore::EventHandler::shouldDragAutoNode):
- * page/Frame.cpp:
- (WebCore::Frame::searchForLabelsAboveCell):
- (WebCore::Frame::setFocusedNodeIfNeeded):
- * page/FrameView.cpp:
- (WebCore::FrameView::updateOverflowStatus):
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- (WebCore::AnimationController::cancelAnimations):
- (WebCore::AnimationController::updateAnimations):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
- (WebCore::KeyframeAnimation::endAnimation):
- * page/mac/AccessibilityObjectWrapper.mm:
- (blockquoteLevel):
- (AXAttributeStringSetHeadingLevel):
- * page/mac/FrameMac.mm:
- (WebCore::Frame::searchForNSLabelsAboveCell):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::verticallyAlignBoxes):
- (WebCore::InlineFlowBox::paint):
- (WebCore::shouldDrawTextDecoration):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintDocumentMarkers):
- * rendering/RenderBR.cpp:
- (WebCore::RenderBR::positionForCoordinates):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::handleRunInChild):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::isSelectionRoot):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::positionForBox):
- (WebCore::RenderBlock::positionForRenderer):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::hasLineIfEmpty):
- (WebCore::RenderBlock::updateFirstLetter):
- (WebCore::RenderBlock::updateHitTestResult):
- (WebCore::RenderBlock::addFocusRingRects):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::updateBoxModelInfoFromStyle):
- (WebCore::RenderBox::paintRootBoxDecorations):
- (WebCore::RenderBox::positionForCoordinates):
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::updateFromElement):
- (WebCore::RenderButton::canHaveChildren):
- * rendering/RenderCounter.cpp:
- (WebCore::planCounter):
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::findLegend):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::translationForAttributes):
- (WebCore::RenderForeignObject::calculateLocalTransform):
- * rendering/RenderFrame.h:
- (WebCore::RenderFrame::element):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::paintReplaced):
- (WebCore::RenderImage::imageMap):
- (WebCore::RenderImage::nodeAtPoint):
- (WebCore::RenderImage::updateAltText):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::cloneInline):
- (WebCore::RenderInline::updateHitTestResult):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::isTransparent):
- (WebCore::RenderLayer::scrollToOffset):
- (WebCore::RenderLayer::resize):
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::updateOverflowStatus):
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- (WebCore::RenderLayer::enclosingElement):
- (WebCore::RenderLayer::updateHoverActiveState):
- (WebCore::RenderLayer::updateScrollCornerStyle):
- (WebCore::RenderLayer::updateResizerStyle):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isRootLayer):
- * rendering/RenderListItem.cpp:
- (WebCore::getParentOfFirstLineBox):
- * rendering/RenderMarquee.cpp:
- (WebCore::RenderMarquee::marqueeSpeed):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- (WebCore::RenderObject::isBody):
- (WebCore::RenderObject::isHR):
- (WebCore::RenderObject::isHTMLMarquee):
- (WebCore::RenderObject::isEditable):
- (WebCore::RenderObject::addPDFURLRect):
- (WebCore::RenderObject::showTreeForThis):
- (WebCore::RenderObject::draggableNode):
- (WebCore::RenderObject::hasOutlineAnnotation):
- (WebCore::RenderObject::positionForCoordinates):
- (WebCore::RenderObject::updateDragState):
- (WebCore::RenderObject::updateHitTestResult):
- (WebCore::RenderObject::getUncachedPseudoStyle):
- (WebCore::RenderObject::getTextDecorationColors):
- (WebCore::RenderObject::caretMaxOffset):
- (WebCore::RenderObject::offsetParent):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isRoot):
- (WebCore::RenderObject::isInlineContinuation):
- (WebCore::RenderObject::node):
- (WebCore::RenderObject::setNode):
- * rendering/RenderObjectChildList.cpp:
- (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::updateWidgetPosition):
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::updateWidget):
- (WebCore::RenderPartObject::viewCleared):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::calculateLocalTransform):
- (WebCore::RenderPath::layout):
- (WebCore::RenderPath::paint):
- (WebCore::RenderPath::drawMarkersIfNeeded):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::positionForCoordinates):
- (WebCore::RenderReplaced::isSelected):
- * rendering/RenderSVGGradientStop.cpp:
- (WebCore::RenderSVGGradientStop::gradientElement):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::calculateLocalTransform):
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::positionForCoordinates):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- (WebCore::RenderSVGRoot::applyContentTransforms):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::calcViewport):
- (WebCore::RenderSVGRoot::absoluteTransform):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::calculateLocalTransform):
- (WebCore::RenderSVGText::layout):
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::layoutPath):
- (WebCore::RenderSVGTextPath::startOffset):
- (WebCore::RenderSVGTextPath::exactAlignment):
- (WebCore::RenderSVGTextPath::stretchMethod):
- * rendering/RenderSVGTransformableContainer.cpp:
- (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::calcViewport):
- (WebCore::RenderSVGViewportContainer::viewportTransform):
- (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::updateFromElement):
- (WebCore::RenderTableCell::calcPrefWidths):
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::updateFromElement):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::addChild):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addChild):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::originalText):
- (WebCore::RenderText::positionForCoordinates):
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- * rendering/RenderTextFragment.cpp:
- (WebCore::RenderTextFragment::originalText):
- (WebCore::RenderTextFragment::previousCharacter):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::isActive):
- (WebCore::RenderTheme::isChecked):
- (WebCore::RenderTheme::isIndeterminate):
- (WebCore::RenderTheme::isEnabled):
- (WebCore::RenderTheme::isFocused):
- (WebCore::RenderTheme::isPressed):
- (WebCore::RenderTheme::isReadOnlyControl):
- (WebCore::RenderTheme::isHovered):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::updatePressedState):
- (WebCore::RenderThemeMac::paintMediaFullscreenButton):
- (WebCore::RenderThemeMac::paintMediaMuteButton):
- (WebCore::RenderThemeMac::paintMediaPlayButton):
- (WebCore::RenderThemeMac::paintMediaSeekBackButton):
- (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
- (WebCore::RenderThemeMac::paintMediaSliderTrack):
- (WebCore::RenderThemeMac::paintMediaSliderThumb):
- (WebCore::RenderThemeMac::paintMediaTimelineContainer):
- (WebCore::RenderThemeMac::paintMediaCurrentTime):
- (WebCore::RenderThemeMac::paintMediaTimeRemaining):
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::paintMediaMuteButton):
- (WebCore::RenderThemeSafari::paintMediaPlayButton):
- (WebCore::RenderThemeSafari::paintMediaSliderTrack):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- (WebCore::writeSelection):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::setWidgetGeometry):
- (WebCore::RenderWidget::updateWidgetPosition):
- (WebCore::RenderWidget::nodeAtPoint):
- * rendering/RootInlineBox.cpp:
- (WebCore::isEditableLeaf):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::prepareToRenderSVGContent):
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::write):
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBox::buildLayoutInformation):
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- (WebCore::SVGRootInlineBox::buildTextChunks):
- * rendering/style/SVGRenderStyle.cpp:
- (WebCore::SVGRenderStyle::cssPrimitiveToLength):
- * svg/SVGFont.cpp:
- (WebCore::SVGTextRunWalker::walk):
- (WebCore::floatWidthOfSubStringUsingSVGFont):
- (WebCore::Font::drawTextUsingSVGFont):
- * svg/SVGTextContentElement.cpp:
- (WebCore::findInlineTextBoxInTextChunks):
- * svg/graphics/SVGPaintServer.cpp:
- (WebCore::SVGPaintServer::fillPaintServer):
- (WebCore::SVGPaintServer::strokePaintServer):
-
-2009-02-11 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/3541409> - Further FrameLoader and page cache cleanup
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method. This method was
- the only caller and - in the future - will benefit from doing parts of opened()'s work differently.
- (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method.
- (WebCore::FrameLoader::closeAndRemoveChild): Added. Do the non-tree related cleanup that
- FrameTree::removeChild() used to do.
- (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead.
- (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
- * loader/FrameLoader.h:
-
- * page/FrameTree.cpp:
- (WebCore::FrameTree::removeChild): Just remove the Frame from the tree. Closing it and other
- cleanup is the responsibility of the FrameLoader.
- * page/FrameTree.h:
- (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer
-
-2009-02-11 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23882
- GraphicsContextSkia draws round rects as solid rects
-
- Fixes two bugs in Skia's GraphicsContext::fillRoundedRect:
- . fillRoundedRect had an extra call to fillRect, resulting in always
- drawing a solid rectangle.
- . if the total radius along a given axis is greater than the size of
- the axis to draw, a solid rect should be drawn.
-
- The layout tests LayoutTests/fast/css/shadow-multiple.html and
- LayoutTests/fast/box-shadow/basic-shadows.html cover this.
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::fillRoundedRect):
-
-2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 23536: Auto-generate HTMLElementFactory
-
- Remove the HTMLElementFactory files. Farewell.
-
- * html/HTMLElementFactory.cpp: Removed.
- * html/HTMLElementFactory.h: Removed.
-
-2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 23536: Auto-generate HTMLElementFactory
-
- Make the platform auto-generate the HTMLElementFactory.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * webcore-base.bkl:
-
-2009-02-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Remove unneeded ASSERTS.
-
- * rendering/RenderBox.h:
- (WebCore::RenderBox::width):
- (WebCore::RenderBox::height):
- (WebCore::RenderBox::size):
- (WebCore::RenderBox::frameRect):
-
-2009-02-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Add function to RenderStyle to ask whether a background image has been specified.
-
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::hasBackgroundImage):
-
-2009-02-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23548
-
- When opacity or transform change on an object which has a compositing layer,
- avoid repainting the layer.
-
- Added a new StyleDifference value, StyleDifferenceRecompositeLayer, which indicates
- that the only thing styleChanged() has to do is to update composited properties of
- the layer. RenderStyle::diff() now has an out param for a bitmask of "context sensitive"
- properties, currently for opacity and transform. When one of these changes, we need
- to see if we have a compositing layer before we decide whether to layout/repaint,
- or just update the composited layer, via adjustStyleDifference().
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::adjustStyleDifference):
- (WebCore::RenderObject::setStyle):
- (WebCore::RenderObject::styleDidChange):
- * rendering/RenderObject.h:
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
- * rendering/style/RenderStyle.h:
- * rendering/style/RenderStyleConstants.h:
- (WebCore::):
-
-2009-02-11 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6562920> Pasted text should be normalized to NFC
-
- Testing requires putting non-HTML content in pasteboard, so it cannot be done with WebKit alone.
-
- * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::plainText): Route the text through
- -[NSString precomposedStringWithCanonicalMapping].
-
-2009-02-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser.
-
- https://bugs.webkit.org/show_bug.cgi?id=23883
-
- Added new TransformOperation subclasses and methods to existing ones
- to support 3D.
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/transforms/IdentityTransformOperation.h:
- (WebCore::IdentityTransformOperation::isAffine):
- * platform/graphics/transforms/Matrix3DTransformOperation.cpp: Added.
- (WebCore::Matrix3DTransformOperation::blend):
- * platform/graphics/transforms/Matrix3DTransformOperation.h: Added.
- (WebCore::Matrix3DTransformOperation::create):
- (WebCore::Matrix3DTransformOperation::isIdentity):
- (WebCore::Matrix3DTransformOperation::isAffine):
- (WebCore::Matrix3DTransformOperation::getOperationType):
- (WebCore::Matrix3DTransformOperation::isSameType):
- (WebCore::Matrix3DTransformOperation::operator==):
- (WebCore::Matrix3DTransformOperation::apply):
- (WebCore::Matrix3DTransformOperation::Matrix3DTransformOperation):
- * platform/graphics/transforms/MatrixTransformOperation.h:
- (WebCore::MatrixTransformOperation::isAffine):
- (WebCore::MatrixTransformOperation::apply):
- * platform/graphics/transforms/PerspectiveTransformOperation.cpp: Added.
- (WebCore::PerspectiveTransformOperation::blend):
- * platform/graphics/transforms/PerspectiveTransformOperation.h: Added.
- (WebCore::PerspectiveTransformOperation::create):
- (WebCore::PerspectiveTransformOperation::isIdentity):
- (WebCore::PerspectiveTransformOperation::isAffine):
- (WebCore::PerspectiveTransformOperation::getOperationType):
- (WebCore::PerspectiveTransformOperation::isSameType):
- (WebCore::PerspectiveTransformOperation::operator==):
- (WebCore::PerspectiveTransformOperation::apply):
- (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation):
- * platform/graphics/transforms/RotateTransformOperation.cpp:
- (WebCore::RotateTransformOperation::blend):
- * platform/graphics/transforms/RotateTransformOperation.h:
- (WebCore::RotateTransformOperation::create):
- (WebCore::RotateTransformOperation::angle):
- (WebCore::RotateTransformOperation::isAffine):
- (WebCore::RotateTransformOperation::operator==):
- (WebCore::RotateTransformOperation::apply):
- (WebCore::RotateTransformOperation::RotateTransformOperation):
- * platform/graphics/transforms/ScaleTransformOperation.cpp:
- (WebCore::ScaleTransformOperation::blend):
- * platform/graphics/transforms/ScaleTransformOperation.h:
- (WebCore::ScaleTransformOperation::create):
- (WebCore::ScaleTransformOperation::z):
- (WebCore::ScaleTransformOperation::isIdentity):
- (WebCore::ScaleTransformOperation::isAffine):
- (WebCore::ScaleTransformOperation::operator==):
- (WebCore::ScaleTransformOperation::apply):
- (WebCore::ScaleTransformOperation::ScaleTransformOperation):
- * platform/graphics/transforms/SkewTransformOperation.h:
- (WebCore::SkewTransformOperation::isAffine):
- * platform/graphics/transforms/TransformOperation.h:
- (WebCore::TransformOperation::):
- (WebCore::TransformOperation::is3DOperation):
- * platform/graphics/transforms/TransformOperations.h:
- (WebCore::TransformOperations::isAffine):
- (WebCore::TransformOperations::has3DOperation):
- * platform/graphics/transforms/TranslateTransformOperation.cpp:
- (WebCore::TranslateTransformOperation::blend):
- * platform/graphics/transforms/TranslateTransformOperation.h:
- (WebCore::TranslateTransformOperation::create):
- (WebCore::TranslateTransformOperation::z):
- (WebCore::TranslateTransformOperation::isIdentity):
- (WebCore::TranslateTransformOperation::isAffine):
- (WebCore::TranslateTransformOperation::operator==):
- (WebCore::TranslateTransformOperation::apply):
- (WebCore::TranslateTransformOperation::TranslateTransformOperation):
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Move createAnonymousBlock() to RenderBlock. Since anonymous blocks are always parented to some other block,
- we can move this function to RenderBlock. Fix a couple of call sites as a result of this restriction.
-
- Reviewed by Simon Fraser
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::createAnonymousBlock):
- * rendering/RenderBlock.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::childBecameNonInline):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::handleDynamicFloatPositionChange):
- * rendering/RenderObject.h:
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=23895
-
- Remove two complete nonsense lines that I accidentally added from a cut and paste error. This
- restores the original logic.
-
- Reviewed by Simon Fraser
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
-
-2009-02-11 David Hyatt <hyatt@apple.com>
-
- Rename getBaselineOfFirstLineBox to firstLineBoxBaseline. Rename getBaselineOfLastLineBox to
- lastLineBoxBaseline. Remove the functions from RenderObject and add them to RenderBox instead.
-
- Reviewed by Eric Seidel
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::baselinePosition):
- (WebCore::RenderBlock::firstLineBoxBaseline):
- (WebCore::RenderBlock::lastLineBoxBaseline):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.h:
- (WebCore::RenderBox::firstLineBoxBaseline):
- (WebCore::RenderBox::lastLineBoxBaseline):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- * rendering/RenderObject.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::firstLineBoxBaseline):
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::baselinePosition):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::firstLineBoxBaseline):
- * rendering/RenderTableSection.h:
-
-2009-02-11 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=23877
- Allow port to disable progress events from <video> and <audio> elements
-
- * html/HTMLMediaElement.cpp: Initialize m_sendProgressEvents.
- (WebCore::HTMLMediaElement::HTMLMediaElement): Don't post progress events if m_sendProgressEvents is false.
- (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Ditto.
- (WebCore::HTMLMediaElement::load): Ditto.
- * html/HTMLMediaElement.h: Add m_sendProgressEvents
-
-2009-02-11 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * DerivedSources.cpp: Removed SVGElementFactory.cpp, since including
- it leads to ambiguities for symbols like "aTag", which exist in both
- the HTMLNames and SVGNames namespaces.
-
- * WebCore.vcproj/WebCore.vcproj: Added SVGElementFactory.cpp to the
- project directly. VS also decided to reformat this file a little bit.
-
-2009-02-10 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 23536: Auto-generate HTMLElementFactory
-
- Those are the last auto-generation bits needed to have a working generated HTMLElementFactory:
-
- - Added a new option mapToTagName that enables a tag to use another's options and tagName (<image>
- uses imgTag for example) and wired the code generation to be consistent with the current factory.
-
- - Disabled dashboard compatibility check for HTMLElementFactory as it would make at least one test case fail.
-
- - Pass the QualifiedName down to the Element constructor for shared constructors to make the generated code as
- close as possible to the current one. We will pass the QualifiedName for all Element in a forthcoming patch.
-
- * dom/make_names.pl: Did all the above points and tweaked the code generation to match the current HTMLElementFactory
- as closely as possible.
-
- * html/HTMLElementFactory.cpp:
- (WebCore::quoteConstructor):
- * html/HTMLQuoteElement.cpp:
- (WebCore::HTMLQuoteElement::HTMLQuoteElement): Moved setUsesBeforeAfterRules to HTMLQuoteElement' constructor because some
- part of the code creates elements without using the HTMLElementFactory. Also added a FIXME as it is not the right place.
-
- * html/HTMLTagNames.in: Corrected <image> parameters.
-
-2009-02-10 David Hyatt <hyatt@apple.com>
-
- Fix for pixel test regression in fast/text. Make sure not to add in
- the borderTop and paddingTop of the block to the baseline when painting
- strict mode text decorations.
-
- Reviewed by Mark Rowe
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::paintTextDecorations):
- * rendering/InlineFlowBox.h:
-
-2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
-
- Windows build fix after r40837.
-
- Not reviewed.
-
- * DerivedSources.cpp:
-
-2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
-
- <rdar://6349412> REGRESSION(r37204): Page is not repainted during and
- after pan scrolling
-
- Reviewed by Steve Falkenburg.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents): Don't repaint the pan scroll
- icon rect immediately; we will paint after the view has been scrolled.
-
-2009-02-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop
-
- This problem was caused by incorrectly ignoring whether or not the
- default behaviour of the mousedown event was suppressed. If a
- mousedown handler in a frame prevents default handling then the
- subsequent mousemove events fired for the drag should not be
- captured by that frame, should the mouse move out of its bounds.
-
- Test: fast/events/mouse-drag-from-frame.html
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::EventHandler):
- (WebCore::EventHandler::clear):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- Reset new m_capturesDragging flag
-
- (WebCore::EventHandler::handleMousePressEvent):
- Respect the m_capturesDragging flag when we propagate
- a mousedown event to a subframe.
-
- * page/EventHandler.h:
- (WebCore::EventHandler::capturesDragging):
-
-2009-02-10 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes for recent changes to TransformationMatrix and DOMElement.
-
- * WebCoreSources.bkl:
- * dom/Element.cpp:
- * platform/graphics/transforms/TransformationMatrix.h:
- * platform/graphics/wx/TransformationMatrixWx.cpp:
- (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
-
-2009-02-10 David Hyatt <hyatt@apple.com>
-
- Some renames on line boxes. xPos()/yPos() -> x()/y(). setXPos()/setYPos() -> setX()/setY(). m_object/object() -> m_renderer/renderer(). textObject() -> textRenderer().
-
- Reviewed by Sam Weinig
-
- * dom/Position.cpp:
- (WebCore::Position::upstream):
- (WebCore::Position::downstream):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- (WebCore::VisiblePosition::localCaretRect):
- * editing/visible_units.cpp:
- (WebCore::startPositionForLine):
- (WebCore::endPositionForLine):
- (WebCore::previousLinePosition):
- (WebCore::nextLinePosition):
- * rendering/EllipsisBox.cpp:
- (WebCore::EllipsisBox::paint):
- (WebCore::EllipsisBox::nodeAtPoint):
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::showTreeForThis):
- (WebCore::InlineBox::height):
- (WebCore::InlineBox::caretMinOffset):
- (WebCore::InlineBox::caretMaxOffset):
- (WebCore::InlineBox::deleteLine):
- (WebCore::InlineBox::extractLine):
- (WebCore::InlineBox::attachLine):
- (WebCore::InlineBox::adjustPosition):
- (WebCore::InlineBox::paint):
- (WebCore::InlineBox::nodeAtPoint):
- (WebCore::InlineBox::selectionState):
- (WebCore::InlineBox::canAccommodateEllipsis):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
- (WebCore::InlineBox::renderer):
- (WebCore::InlineBox::setX):
- (WebCore::InlineBox::x):
- (WebCore::InlineBox::setY):
- (WebCore::InlineBox::y):
- (WebCore::InlineBox::topOverflow):
- (WebCore::InlineBox::bottomOverflow):
- (WebCore::InlineBox::leftOverflow):
- (WebCore::InlineBox::rightOverflow):
- (WebCore::InlineBox::visibleToHitTesting):
- (WebCore::InlineBox::boxModelObject):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::height):
- (WebCore::InlineFlowBox::addToLine):
- (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
- (WebCore::InlineFlowBox::rendererLineBoxes):
- (WebCore::InlineFlowBox::onEndChain):
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::InlineFlowBox::verticallyAlignBoxes):
- (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
- (WebCore::verticalPositionForBox):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- (WebCore::InlineFlowBox::nodeAtPoint):
- (WebCore::InlineFlowBox::paint):
- (WebCore::InlineFlowBox::paintFillLayer):
- (WebCore::InlineFlowBox::paintBoxShadow):
- (WebCore::InlineFlowBox::paintBoxDecorations):
- (WebCore::InlineFlowBox::paintMask):
- (WebCore::InlineFlowBox::paintTextDecorations):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::borderLeft):
- (WebCore::InlineFlowBox::borderRight):
- (WebCore::InlineFlowBox::borderTop):
- (WebCore::InlineFlowBox::borderBottom):
- (WebCore::InlineFlowBox::baseline):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::height):
- (WebCore::InlineTextBox::selectionState):
- (WebCore::InlineTextBox::selectionRect):
- (WebCore::InlineTextBox::deleteLine):
- (WebCore::InlineTextBox::extractLine):
- (WebCore::InlineTextBox::attachLine):
- (WebCore::InlineTextBox::placeEllipsisBox):
- (WebCore::InlineTextBox::isLineBreak):
- (WebCore::InlineTextBox::nodeAtPoint):
- (WebCore::InlineTextBox::paint):
- (WebCore::InlineTextBox::selectionStartEnd):
- (WebCore::InlineTextBox::paintSelection):
- (WebCore::InlineTextBox::paintCompositionBackground):
- (WebCore::InlineTextBox::paintCustomHighlight):
- (WebCore::InlineTextBox::paintDecoration):
- (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
- (WebCore::InlineTextBox::paintTextMatchMarker):
- (WebCore::InlineTextBox::paintDocumentMarkers):
- (WebCore::InlineTextBox::paintCompositionUnderline):
- (WebCore::InlineTextBox::textPos):
- (WebCore::InlineTextBox::offsetForPosition):
- (WebCore::InlineTextBox::positionForOffset):
- * rendering/InlineTextBox.h:
- (WebCore::InlineTextBox::textRenderer):
- * rendering/ListMarkerBox.cpp:
- (WebCore::ListMarkerBox::isText):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintEllipsisBoxes):
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- (WebCore::RenderBlock::positionForBox):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::getBaselineOfFirstLineBox):
- (WebCore::RenderBlock::getBaselineOfLastLineBox):
- (WebCore::RenderBlock::adjustForBorderFit):
- (WebCore::RenderBlock::addFocusRingRects):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::paintCustomHighlight):
- (WebCore::RenderBox::position):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::absoluteQuads):
- (WebCore::RenderInline::offsetLeft):
- (WebCore::RenderInline::offsetTop):
- (WebCore::RenderInline::linesBoundingBox):
- (WebCore::RenderInline::relativePositionedInlineOffset):
- (WebCore::RenderInline::addFocusRingRects):
- (WebCore::RenderInline::paintOutline):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::localBoundingBox):
- * rendering/RenderSVGTSpan.cpp:
- (WebCore::RenderSVGTSpan::absoluteRects):
- (WebCore::RenderSVGTSpan::absoluteQuads):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
- (WebCore::RenderSVGText::relativeBBox):
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::absoluteRects):
- (WebCore::RenderSVGTextPath::absoluteQuads):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::absoluteRects):
- (WebCore::RenderText::absoluteRectsForRange):
- (WebCore::RenderText::absoluteQuads):
- (WebCore::RenderText::absoluteQuadsForRange):
- (WebCore::RenderText::localCaretRect):
- (WebCore::RenderText::linesBoundingBox):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::height):
- (WebCore::RootInlineBox::clearTruncation):
- (WebCore::RootInlineBox::placeEllipsis):
- (WebCore::RootInlineBox::paintEllipsisBox):
- (WebCore::RootInlineBox::addHighlightOverflow):
- (WebCore::RootInlineBox::paintCustomHighlight):
- (WebCore::RootInlineBox::paint):
- (WebCore::RootInlineBox::nodeAtPoint):
- (WebCore::RootInlineBox::childRemoved):
- (WebCore::RootInlineBox::fillLineSelectionGap):
- (WebCore::RootInlineBox::block):
- (WebCore::isEditableLeaf):
- (WebCore::RootInlineBox::closestLeafChildForXPos):
- (WebCore::RootInlineBox::setVerticalOverflowPositions):
- * rendering/RootInlineBox.h:
- (WebCore::RootInlineBox::bottomOverflow):
- (WebCore::RootInlineBox::floats):
- (WebCore::RootInlineBox::setHorizontalOverflowPositions):
- (WebCore::RootInlineBox::setVerticalSelectionPositions):
- * rendering/SVGCharacterLayoutInfo.cpp:
- (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::SVGInlineTextBox::calculateGlyphWidth):
- (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
- (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
- (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
- (WebCore::SVGInlineTextBox::nodeAtPoint):
- (WebCore::SVGInlineTextBox::paintCharacters):
- (WebCore::SVGInlineTextBox::paintSelection):
- (WebCore::SVGInlineTextBox::paintDecoration):
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::writeSVGInlineTextBox):
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
- (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
- (WebCore::SVGRootInlineBox::paint):
- (WebCore::cummulatedWidthOfInlineBoxCharacterRange):
- (WebCore::cummulatedHeightOfInlineBoxCharacterRange):
- (WebCore::svgTextRunForInlineTextBox):
- (WebCore::cummulatedWidthOrHeightOfTextChunk):
- (WebCore::applyTextAnchorToTextChunk):
- (WebCore::SVGRootInlineBox::buildLayoutInformation):
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- (WebCore::SVGRootInlineBox::buildTextChunks):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::constructLine):
- (WebCore::RenderBlock::computeVerticalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::RenderBlock::checkLinesForTextOverflow):
- * svg/SVGTextContentElement.cpp:
- (WebCore::cumulativeCharacterRangeLength):
- (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
- (WebCore::findInlineTextBoxInTextChunks):
-
-2009-02-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Clean up "fallbackAnimating" logic in AnimationBase. This flag indicates
- that animation of an accelerated property must run in software for some reason.
-
- Also remove use of private headers in GraphicsLayerCA related to a case
- where we may have to fall back on software animation of transform.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::blendProperties):
- * page/animation/AnimationBase.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
- * platform/graphics/mac/GraphicsLayerCA.h:
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::getValueFunctionNameForTransformOperation):
- (WebCore::caValueFunctionSupported):
- (WebCore::GraphicsLayerCA::setBackgroundColor):
- (WebCore::GraphicsLayerCA::setOpacity):
- (WebCore::GraphicsLayerCA::animateTransform):
- (WebCore::GraphicsLayerCA::animateFloat):
- (WebCore::GraphicsLayerCA::setBasicAnimation):
- (WebCore::GraphicsLayerCA::setKeyframeAnimation):
-
-2009-02-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Move enclosingCompositingLayer() from RenderObject to RenderLayer, since it
- relates to the RenderLayer z-order/overflow structure, rather than the render tree
- parent chain. Add a convenience method, ancestorCompositingLayer(), which finds
- the enclosing layer excluding self.
-
- Fix enclosingCompositingLayer() to correctly look at stacking context and overflow
- lists.
-
- Check for documentBeingDestroyed() in a few places to avoid work on document
- teardown.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::enclosingCompositingLayer):
- (WebCore::RenderLayer::setParent):
- (WebCore::RenderLayer::dirtyZOrderLists):
- (WebCore::RenderLayer::dirtyOverflowList):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::ancestorCompositingLayer):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- (WebCore::RenderLayerCompositor::calculateCompositedBounds):
- (WebCore::RenderLayerCompositor::layerWillBeRemoved):
- (WebCore::RenderLayerCompositor::clippedByAncestor):
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containerForRepaint):
- * rendering/RenderObject.h:
-
-2009-02-10 David Hyatt <hyatt@apple.com>
-
- Rename xPos() and yPos() on RenderLayer to x() and y() to match RenderBox. Rename setPos to setLocation.
-
- Reviewed by Simon Fraser
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::convertToLayerCoords):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::x):
- (WebCore::RenderLayer::y):
- (WebCore::RenderLayer::setLocation):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::write):
- (WebCore::externalRepresentation):
-
-2009-02-10 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23879
- Add missing PLATFORM(SKIA) changes to TransformationMatrix.h
-
- * platform/graphics/transforms/TransformationMatrix.h:
-
-2009-02-10 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
- Please implement getBoundingClientRect and getClientRects
- <rdar://problem/6139669>
-
- Cursory implementation of Element.getBoundingClientRect and
- Element.getClientRects. Adds necessary infrastructure classes
- ClientRect and ClientRectList.
-
- Tests: fast/dom/getBoundingClientRect.html
- fast/dom/getClientRects.html
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/ClientRect.cpp: Added.
- (WebCore::ClientRect::ClientRect):
- * dom/ClientRect.h: Added.
- (WebCore::ClientRect::create):
- (WebCore::ClientRect::top):
- (WebCore::ClientRect::right):
- (WebCore::ClientRect::bottom):
- (WebCore::ClientRect::left):
- (WebCore::ClientRect::width):
- (WebCore::ClientRect::height):
- * dom/ClientRect.idl: Added.
- * dom/ClientRectList.cpp: Added.
- (WebCore::ClientRectList::ClientRectList):
- (WebCore::ClientRectList::~ClientRectList):
- (WebCore::ClientRectList::length):
- (WebCore::ClientRectList::item):
- * dom/ClientRectList.h: Added.
- (WebCore::ClientRectList::create):
- * dom/ClientRectList.idl: Added.
- * dom/Element.cpp:
- (WebCore::Element::getClientRects):
- (WebCore::Element::getBoundingClientRect):
- * dom/Element.h:
- * dom/Element.idl:
- * page/DOMWindow.idl:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::absoluteQuads):
-
-2009-02-10 David Hyatt <hyatt@apple.com>
-
- Get rid of capsLockStateMayHaveChanged on RenderObject. It is only implemented by one class (text fields),
- so devirtualize and just query at the single call site.
-
- Reviewed by Eric Seidel
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::capsLockStateMayHaveChanged):
- * rendering/RenderObject.h:
- * rendering/RenderTextControlSingleLine.h:
-
-2009-02-10 David Hyatt <hyatt@apple.com>
-
- Shrink the size of all RenderObjects (except for RenderInlines) by 4 bytes. This patch moves the cached vertical position member to RenderInlines,
- since they were the only objects being queried across multiple lines.
-
- Reviewed by Sam Weinig
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::verticalPositionForBox):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::verticalPosition):
- * rendering/RenderBoxModelObject.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::verticalPositionFromCache):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::invalidateVerticalPosition):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- * rendering/RenderObject.h:
- * rendering/RenderText.cpp:
- * rendering/RenderText.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=23868
- Fix code style issues: removed 80-col wrapping, incorrect include style, if statement body on same line.
-
- * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
- * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
-
-2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23868
- Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings.
-
- * bindings/v8/custom/V8HTMLInputElementCustom.cpp: Added.
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::getEventListener):
(WebCore::ACCESSOR_GETTER):
(WebCore::ACCESSOR_SETTER):
(WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Added.
+ * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
(WebCore::ACCESSOR_GETTER):
(WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XMLSerializerConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
-2009-02-10 Adam Roben <aroben@apple.com>
-
- Fix Bug 23871: Assertion failure beneath WebCore::openFunc when
- running http/tests/security/xss-DENIED-xsl-document-redirect.xml
+2009-06-26 Kevin McCullough <kmccullough@apple.com>
- <https://bugs.webkit.org/show_bug.cgi?id=23871>
+ Reviewed by Tim Hatcher.
- Reviewed by Alexey Proskuryakov.
+ <rdar://problem/7011047> Profiler shows the record button 'on' even
+ though it's finished
- Covered by existing tests.
+ I consolidated the creation of the user initiated profile name into
+ its own function and then called it from console::profile instead of
+ calling startUserInitiatedProfiling(). This way we don't call
+ toggleRecordButton() which turns on the record button.
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::openFunc): Use the two-parameter KURL constructor so that
- the string will be parsed. libxml2 gives us a UTF-8-encoded string
- that needs to be parsed.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
+ (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
+ (WebCore::InspectorController::startUserInitiatedProfiling):
+ (WebCore::InspectorController::stopUserInitiatedProfiling):
+ * inspector/InspectorController.h:
+ * page/Console.cpp:
+ (WebCore::Console::profile):
+ (WebCore::Console::profileEnd):
-2009-02-10 David Hyatt <hyatt@apple.com>
+2009-06-26 Jeremy Moskovich <jeremy@chromium.org>
- Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
- overflow boolean into the RenderObject base class.
+ Reviewed by Eric Seidel.
- Reviewed by Sam Weinig
+ https://bugs.webkit.org/show_bug.cgi?id=26691
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::replacedHasOverflow):
- (WebCore::RenderObject::setReplacedHasOverflow):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::RenderReplaced):
- (WebCore::RenderReplaced::~RenderReplaced):
- (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
- (WebCore::RenderReplaced::overflowHeight):
- (WebCore::RenderReplaced::overflowWidth):
- (WebCore::RenderReplaced::overflowLeft):
- (WebCore::RenderReplaced::overflowTop):
- (WebCore::RenderReplaced::overflowRect):
- * rendering/RenderReplaced.h:
-
-2009-02-10 Eric Carlson <eric.carlson@apple.com>
+ Cleanup: Move focusRingColor to RenderTheme.
- Reviewed by Simon Fraser.
+ Most of this CL involves deleting files and removing dead code.
- https://bugs.webkit.org/show_bug.cgi?id=23870
- Make it possible for a port to require a user gesture for an <audio> or <video> element
- to load a url.
+ focusRingColor() is now defined in RenderTheme rather than in
+ misc. places on each port. The default color is specified as
+ black in renderTheme and ports can override it in their own
+ custom renderThemes.
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions.
- (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests.
- (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set
- and we are not preocessing a user gesture.
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space.
- (WebCore::HTMLMediaElement::play): Ditto.
- (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789.
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it
- multiple times.
- (WebCore::HTMLMediaElement::processingUserGesture): New.
- * html/HTMLMediaElement.h:
- (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.
+ Behavior should be identical except for the following cases,
+ this lists platform and what the focus ring color used to be
+ before this cl and the file where it used to be defined:
-2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
+ Android - red
+ WebCore/platform/android/TemporaryLinkStubs.cpp
- Reviewed by Sam Weinig.
+ Cairo - aqua focus ring color - 0xFF7DADD9
+ WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
- Remove the SVG checks from FloatPoint3D as it is used
- by TransformationMatrix.
+ wx - red
+ WebCore/platform/wx/TemporaryLinkStubs.cpp
- * platform/graphics/FloatPoint3D.cpp:
- * platform/graphics/FloatPoint3D.h:
+ QT - black
+ WebCore/platform/graphics/qt/GraphicsContextQt.cpp
-2009-02-10 David Hyatt <hyatt@apple.com>
+ Manual test: manual-tests/focusringcolor-change-on-theme-change.html
- Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
+ * manual-tests/focusringcolor-change-on-theme-change.html: Added.
+ * platform/android/TemporaryLinkStubs.cpp:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ * platform/graphics/chromium/ColorChromium.cpp: Removed.
+ * platform/graphics/chromium/ColorChromiumMac.mm: Removed.
+ * platform/graphics/mac/ColorMac.h:
+ * platform/graphics/mac/ColorMac.mm:
+ (WebCore::oldAquaFocusRingColor):
+ (WebCore::setUsesTestModeFocusRingColor):
+ (WebCore::usesTestModeFocusRingColor):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::drawFocusRing):
+ * platform/graphics/win/ColorSafari.cpp: Removed.
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::focusRingColor):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeChromiumMac.h:
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::focusRingColor):
+ (WebCore::RenderThemeChromiumMac::systemColor):
+ * rendering/RenderThemeChromiumSkia.cpp:
+ (WebCore::RenderThemeChromiumSkia::focusRingColor):
+ * rendering/RenderThemeChromiumSkia.h:
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::focusRingColor):
+ (WebCore::RenderThemeMac::systemColor):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::makeRGBAFromCGColor):
+ (WebCore::RenderThemeSafari::focusRingColor):
+ * rendering/RenderThemeSafari.h:
- Reviewed by Sam Weinig
+2009-06-26 Dmitry Titov <dimich@chromium.org>
- * rendering/EllipsisBox.cpp:
- (WebCore::EllipsisBox::paint):
- (WebCore::EllipsisBox::nodeAtPoint):
- * rendering/EllipsisBox.h:
- (WebCore::EllipsisBox::EllipsisBox):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::verticallyAlignBoxes):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- (WebCore::InlineFlowBox::paintTextDecorations):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::marginBorderPaddingLeft):
- (WebCore::InlineFlowBox::marginBorderPaddingRight):
- (WebCore::InlineFlowBox::marginLeft):
- (WebCore::InlineFlowBox::marginRight):
- (WebCore::InlineFlowBox::borderLeft):
- (WebCore::InlineFlowBox::borderRight):
- (WebCore::InlineFlowBox::borderTop):
- (WebCore::InlineFlowBox::borderBottom):
- (WebCore::InlineFlowBox::paddingLeft):
- (WebCore::InlineFlowBox::paddingRight):
- (WebCore::InlineFlowBox::paddingTop):
- (WebCore::InlineFlowBox::paddingBottom):
- (WebCore::InlineFlowBox::includeLeftEdge):
- (WebCore::InlineFlowBox::includeRightEdge):
- (WebCore::InlineFlowBox::baseline):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paint):
- (WebCore::InlineTextBox::paintDecoration):
- (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
- (WebCore::InlineTextBox::paintCompositionUnderline):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::getBaselineOfFirstLineBox):
- (WebCore::RenderBlock::getBaselineOfLastLineBox):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::baselinePosition):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::placeEllipsis):
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::SVGInlineTextBox::paintDecoration):
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::applyTextAnchorToTextChunk):
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ Reviewed by David Levin.
-2009-02-10 Alexey Proskuryakov <ap@webkit.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26761
+ [Chromium] Enable Dedicated Workers in Chromium.
- Reviewed by Darin Adler.
+ * bindings/v8/custom/V8WorkerCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ Remove the check that prevented workers from being created w/o a command-line switch.
+ The flag itself and methods will be removed in a subsequent patch, after
+ corresponding change in Chromium.
- https://bugs.webkit.org/show_bug.cgi?id=23867
- Eliminate obsolete frame->document() checks
+2009-06-26 Jessie Berlin <jberlin@apple.com>
- * page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo
- (document vs. !document), fillWithRed was always set to false, and other branches were
- never taken. Removing the check for document restores debug-only red color filling.
+ Reviewed by Mark Rowe.
+
+ Fix: https://bugs.webkit.org/show_bug.cgi?id=26723
+ Where the m_mouseDown event was never being set on windows, so the
+ client X and Y coordinates were always being reported as zero in a
+ dragstart handler.
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable()
- after a document is created. A client can do anything in its delegate method, so we'd need
- to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its
- custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().
+ Test: editing/selection/drag-start-event-client-x-y.html
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- * bindings/js/JSNavigatorCustom.cpp:
- (WebCore::needsYouTubeQuirk):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::updateRenderingForBindings):
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
- * editing/Editor.cpp:
- (WebCore::Editor::deleteWithDirection):
- (WebCore::Editor::dispatchCPPEvent):
- (WebCore::Editor::applyStyle):
- (WebCore::Editor::applyParagraphStyle):
- * editing/EditorCommand.cpp:
- (WebCore::Editor::Command::execute):
- (WebCore::Editor::Command::isEnabled):
- (WebCore::Editor::Command::state):
- (WebCore::Editor::Command::value):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::recomputeCaretRect):
- (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
- (WebCore::SelectionController::selectAll):
- (WebCore::SelectionController::setFocused):
- * inspector/InspectorController.cpp:
- (WebCore::getResourceDocumentNode):
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- * loader/DocumentLoader.cpp:
- (WebCore::canonicalizedTitle):
- (WebCore::DocumentLoader::stopLoading):
- (WebCore::DocumentLoader::isLoadingInAPISense):
- (WebCore::DocumentLoader::subresource):
- (WebCore::DocumentLoader::getSubresources):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::urlSelected):
- (WebCore::FrameLoader::stop):
- (WebCore::FrameLoader::iconURL):
- (WebCore::FrameLoader::executeIfJavaScriptURL):
- (WebCore::FrameLoader::clear):
- (WebCore::FrameLoader::endIfNotLoadingMainResource):
- (WebCore::FrameLoader::restoreDocumentState):
- (WebCore::FrameLoader::gotoAnchor):
- (WebCore::FrameLoader::loadDone):
- (WebCore::FrameLoader::checkCompleted):
- (WebCore::FrameLoader::checkCallImplicitClose):
- (WebCore::FrameLoader::scheduleRefresh):
- (WebCore::FrameLoader::outgoingOrigin):
- (WebCore::FrameLoader::canCachePageContainingThisFrame):
- (WebCore::FrameLoader::logCanCacheFrameDecision):
- (WebCore::FrameLoader::updatePolicyBaseURL):
- (WebCore::FrameLoader::setPolicyBaseURL):
- (WebCore::FrameLoader::frameDetached):
- (WebCore::FrameLoader::shouldScrollToAnchor):
- (WebCore::FrameLoader::saveDocumentState):
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create):
- * loader/icon/IconFetcher.cpp:
- (WebCore::IconFetcher::create):
- * loader/icon/IconLoader.cpp:
- (WebCore::IconLoader::startLoading):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- * page/Chrome.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::sessionStorage):
- (WebCore::DOMWindow::alert):
- (WebCore::DOMWindow::confirm):
- (WebCore::DOMWindow::prompt):
- (WebCore::DOMWindow::scrollX):
- (WebCore::DOMWindow::scrollY):
- (WebCore::DOMWindow::getMatchedCSSRules):
- (WebCore::DOMWindow::openDatabase):
- (WebCore::DOMWindow::scrollBy):
- (WebCore::DOMWindow::scrollTo):
* page/EventHandler.cpp:
- (WebCore::EventHandler::allowDHTMLDrag):
- (WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- (WebCore::EventHandler::updateDragAndDrop):
- (WebCore::EventHandler::handleWheelEvent):
- (WebCore::EventHandler::sendContextMenuEvent):
- (WebCore::EventHandler::capsLockStateMayHaveChanged):
- (WebCore::EventHandler::sendResizeEvent):
- (WebCore::EventHandler::sendScrollEvent):
- * page/FocusController.cpp:
- (WebCore::deepFocusableNode):
- (WebCore::FocusController::advanceFocus):
- * page/Frame.cpp:
- (WebCore::Frame::setFocusedNodeIfNeeded):
- (WebCore::Frame::shouldApplyTextZoom):
- (WebCore::Frame::shouldApplyPageZoom):
- (WebCore::Frame::setZoomFactor):
- (WebCore::Frame::setPrinting):
- (WebCore::Frame::reapplyStyles):
- (WebCore::Frame::isContentEditable):
- (WebCore::Frame::computeAndSetTypingStyle):
- (WebCore::Frame::selectionComputedStyle):
- (WebCore::Frame::applyEditingStyleToBodyElement):
- (WebCore::Frame::removeEditingStyleFromBodyElement):
- (WebCore::Frame::contentRenderer):
- (WebCore::Frame::styleForSelectionStart):
- (WebCore::Frame::setSelectionFromNone):
- (WebCore::Frame::findString):
- (WebCore::Frame::markAllMatchesForText):
- (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
- (WebCore::Frame::documentTypeString):
- (WebCore::Frame::shouldClose):
- (WebCore::Frame::respondToChangedSelection):
- * page/FrameView.cpp:
- (WebCore::FrameView::~FrameView):
- (WebCore::FrameView::createScrollbar):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::layoutTimerFired):
- (WebCore::FrameView::scheduleRelayout):
- (WebCore::FrameView::needsLayout):
- (WebCore::FrameView::unscheduleRelayout):
- (WebCore::FrameView::windowClipRect):
- * page/Geolocation.cpp:
- (WebCore::Geolocation::disconnectFrame):
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- (WebCore::Page::~Page):
- (WebCore::Page::unmarkAllTextMatches):
- (WebCore::Page::setMediaVolume):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
+ Set the m_mouseDown event when the mouse press is handled.
* page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::currentKeyboardEvent):
- (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
- * page/mac/FrameMac.mm:
- (WebCore::Frame::dashboardRegionsDictionary):
- (WebCore::Frame::setUserStyleSheetLocation):
- (WebCore::Frame::setUserStyleSheet):
- * storage/LocalStorageArea.cpp:
- (WebCore::LocalStorageArea::dispatchStorageEvent):
- * storage/SessionStorageArea.cpp:
- (WebCore::SessionStorageArea::dispatchStorageEvent):
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::setContainerSize):
- (WebCore::SVGImage::usesContainerSize):
- (WebCore::SVGImage::size):
- (WebCore::SVGImage::hasRelativeWidth):
- (WebCore::SVGImage::hasRelativeHeight):
- Removed frame->document() checks.
-
-2009-02-10 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Attempt to fix the Qt build after r40791.
-
- * rendering/RenderSVGRoot.cpp:
-
-2009-02-10 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Minor code cleanup.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::replaceChild):
-
-2009-02-10 Adam Treat <adam.treat@torchmobile.com>
-
- Fix Qt build following r40793.
-
- * editing/qt/EditorQt.cpp:
-
-2009-02-10 Feng Qian <feng@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix crashes when accessing navigator object of a deleted frame.
- https://bugs.webkit.org/show_bug.cgi?id=23626
- A layout test is added: fast/dom/navigator-detached-no-crash.html
-
- * page/Navigator.cpp:
- (WebCore::Navigator::cookieEnabled):
- (WebCore::Navigator::javaEnabled):
-
-2009-02-10 Sverrir Berg <sverrir@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23630
- Add complex font rendering using Skia instead of Windows ScriptTextOut.
- This adds support for enhanced webkit styles when drawing complex
- glyphs.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::Font::drawGlyphs):
- (WebCore::Font::drawComplexText):
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::containsMissingGlyphs):
- (WebCore::UniscribeHelper::draw):
- (WebCore::UniscribeHelper::shape):
- * platform/graphics/chromium/UniscribeHelper.h:
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::skiaDrawText):
- (WebCore::paintSkiaText):
- * platform/graphics/skia/SkiaFontWin.h:
-
-2009-02-10 Darin Fisher <darin@chromium.org>
-
- Revert r40797 as requested by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23809
-
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/Document.idl:
- * html/HTMLCanvasElement.idl:
+ (WebCore::EventHandler::mouseDown):
+ Removed now redundant setting of m_mouseDown.
-2009-02-09 Darin Fisher <darin@chromium.org>
+2009-06-26 Brady Eidson <beidson@apple.com>
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23855
- Fix TransformationMatrixSkia.cpp and GraphicsContextSkia.cpp bustage
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::getCTM):
- * platform/graphics/skia/TransformationMatrixSkia.cpp:
- (WebCore::TransformationMatrix::operator SkMatrix):
-
-2009-02-09 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)
-
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is
- in the advanced graphics mode before calling GetCharWidthI(), because
- otherwise that function returns incorrect results for the default UI
- font at a certain size.
-
-2009-02-09 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Simon Fraser
-
- https://bugs.webkit.org/show_bug.cgi?id=23689
-
- Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
- added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868
-
- Test: transforms/3d/cssmatrix-3d-interface.xhtml
+ Tiger build fix
- * css/WebKitCSSMatrix.cpp:
- * css/WebKitCSSMatrix.h:
- * css/WebKitCSSMatrix.idl:
-
-2009-02-09 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Darin Adler.
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/network/mac/WebCoreURLResponse.mm:
+ (swizzleMIMETypeMethodIfNecessary):
- Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
- Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
- as it can be invalidated by any of the calls to focus() within the function. Instead, retrieve it and
- null-check it when it is needed.
-
-2009-02-09 David Hyatt <hyatt@apple.com>
-
- Remove the m_height member from InlineBox. This shaves 4 bytes off of all inline boxes. Unfortunately SVG
- sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
- member variables.
-
- height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
- with no text children). For SVG boxes there is also a non-virtual setHeight function for updating the
- m_height member variable like before.
-
- Reviewed by Darin Adler
-
- * rendering/EllipsisBox.cpp:
- (WebCore::EllipsisBox::nodeAtPoint):
- * rendering/EllipsisBox.h:
- (WebCore::EllipsisBox::EllipsisBox):
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::height):
- (WebCore::InlineBox::root):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
- (WebCore::InlineBox::isInlineFlowBox):
- (WebCore::InlineBox::isRootInlineBox):
- (WebCore::InlineBox::topOverflow):
- (WebCore::InlineBox::bottomOverflow):
- (WebCore::InlineBox::leftOverflow):
- (WebCore::InlineBox::rightOverflow):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::height):
- (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- (WebCore::InlineFlowBox::nodeAtPoint):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::isInlineFlowBox):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::height):
- (WebCore::InlineTextBox::nodeAtPoint):
- (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
- (WebCore::InlineTextBox::paintCompositionUnderline):
- * rendering/InlineTextBox.h:
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::height):
- (WebCore::RootInlineBox::placeEllipsis):
- (WebCore::RootInlineBox::setVerticalOverflowPositions):
- * rendering/RootInlineBox.h:
- (WebCore::RootInlineBox::isRootInlineBox):
- (WebCore::RootInlineBox::topOverflow):
- (WebCore::RootInlineBox::bottomOverflow):
- (WebCore::RootInlineBox::leftOverflow):
- (WebCore::RootInlineBox::rightOverflow):
- (WebCore::RootInlineBox::selectionBottom):
- (WebCore::RootInlineBox::Overflow::Overflow):
- (WebCore::RootInlineBox::setVerticalSelectionPositions):
- * rendering/SVGInlineFlowBox.h:
- (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
- (WebCore::SVGInlineFlowBox::height):
- (WebCore::SVGInlineFlowBox::setHeight):
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::SVGInlineTextBox::SVGInlineTextBox):
- * rendering/SVGInlineTextBox.h:
- (WebCore::SVGInlineTextBox::height):
- (WebCore::SVGInlineTextBox::setHeight):
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- * rendering/SVGRootInlineBox.h:
- (WebCore::SVGRootInlineBox::SVGRootInlineBox):
- (WebCore::SVGRootInlineBox::height):
- (WebCore::SVGRootInlineBox::setHeight):
-
-2009-02-09 Eric Seidel <eric@webkit.org>
+2009-06-26 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
- Document our Selection DOM extensions
- (in preparation for re-writing Selection to work with ranges)
-
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::type):
- * page/DOMSelection.h:
- * page/DOMSelection.idl:
-
-2009-02-09 Eric Seidel <eric@webkit.org>
-
- Attempt to fix wx build
-
- * WebCoreSources.bkl: change Selection to VisibleSelection
-
-2009-02-06 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23809
- Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs
-
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/Document.idl:
- * html/HTMLCanvasElement.idl:
-
-2009-02-09 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Transform the gradient instead of the context for most platforms and
- transform the context after CGContextReplacePathWithStrokedPath for CG.
-
- REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
- https://bugs.webkit.org/show_bug.cgi?id=23547
-
- * platform/graphics/Gradient.h:
- (WebCore::Gradient::setGradientSpaceTransform):
- (WebCore::Gradient::gradientSpaceTransform):
- * platform/graphics/cairo/GradientCairo.cpp:
- (WebCore::Gradient::platformGradient):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- * platform/graphics/skia/GradientSkia.cpp:
- (WebCore::Gradient::platformGradient):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
- (WebCore::clipToTextMask):
- (WebCore::SVGPaintServerGradient::setup):
- (WebCore::SVGPaintServerGradient::teardown):
-
-2009-02-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Fix the highlight when inspecting inline elements.
-
- * inspector/InspectorController.cpp:
- (WebCore::drawHighlightForBox):
- (WebCore::drawHighlightForLineBoxes):
- (WebCore::InspectorController::drawNodeHighlight):
-
-2009-02-09 Eric Seidel <eric@webkit.org>
-
- Fix the gtk build by adding VisibleSelection and removing Selection.
-
- * GNUmakefile.am:
-
-2009-02-09 Eric Seidel <eric@webkit.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26681
+ Problem updating applicationCache when server returns 304
+
+ Improve the fix, make the test pass on Tiger.
- Reviewed by Dave Hyatt.
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::didReceiveResponse): Fix another code path to remove the
+ current item from list.
- Rename Selection to VisibleSelection to allow us to separate
- the selections the user works with from the ones used by
- the JS editing APIs.
- https://bugs.webkit.org/show_bug.cgi?id=23852
+ * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): On Tiger,
+ conditional requests that cannot be cached by network layer cause errors with default cache
+ policy.
- No functional changes, thus no tests.
+2009-06-26 Brady Eidson <beidson@apple.com>
- * WebCore.base.exp:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Element.cpp:
- (WebCore::Element::updateFocusAppearance):
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::updateStartEnd):
- (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::inputText):
- (WebCore::CompositeEditCommand::deleteSelection):
- (WebCore::CompositeEditCommand::rebalanceWhitespace):
- (WebCore::CompositeEditCommand::pushAnchorElementDown):
- (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
- (WebCore::CompositeEditCommand::moveParagraphs):
- (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
- (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- * editing/CompositeEditCommand.h:
- * editing/CreateLinkCommand.cpp:
- (WebCore::CreateLinkCommand::doApply):
- * editing/DeleteButtonController.cpp:
- (WebCore::enclosingDeletableElement):
- (WebCore::DeleteButtonController::respondToChangedSelection):
- * editing/DeleteButtonController.h:
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
- (WebCore::DeleteSelectionCommand::clearTransientState):
- (WebCore::DeleteSelectionCommand::doApply):
- * editing/DeleteSelectionCommand.h:
- (WebCore::DeleteSelectionCommand::create):
- * editing/EditCommand.cpp:
- (WebCore::EditCommand::setStartingSelection):
- (WebCore::EditCommand::setEndingSelection):
- * editing/EditCommand.h:
- (WebCore::EditCommand::startingSelection):
- (WebCore::EditCommand::endingSelection):
- * editing/Editor.cpp:
- (WebCore::Editor::selectionForCommand):
- (WebCore::Editor::respondToChangedSelection):
- (WebCore::Editor::respondToChangedContents):
- (WebCore::Editor::applyStyle):
- (WebCore::Editor::applyParagraphStyle):
- (WebCore::Editor::appliedEditing):
- (WebCore::Editor::unappliedEditing):
- (WebCore::Editor::reappliedEditing):
- (WebCore::Editor::insertTextWithoutSendingTextEvent):
- (WebCore::Editor::selectComposition):
- (WebCore::Editor::confirmComposition):
- (WebCore::Editor::advanceToNextMisspelling):
- (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- (WebCore::markMisspellingsOrBadGrammar):
- (WebCore::Editor::markMisspellings):
- (WebCore::Editor::markBadGrammar):
- (WebCore::Editor::rangeForPoint):
- (WebCore::Editor::transpose):
- * editing/Editor.h:
- * editing/EditorCommand.cpp:
- (WebCore::expandSelectionToGranularity):
- (WebCore::executeSwapWithMark):
- (WebCore::enabledVisibleSelection):
- (WebCore::enabledVisibleSelectionAndMark):
- (WebCore::enableCaretInEditableText):
- * editing/FormatBlockCommand.cpp:
- (WebCore::FormatBlockCommand::modifyRange):
- (WebCore::FormatBlockCommand::doApply):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::indentRegion):
- (WebCore::IndentOutdentCommand::outdentRegion):
- (WebCore::IndentOutdentCommand::doApply):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::modifyRange):
- (WebCore::InsertListCommand::doApply):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::performTrivialReplace):
- (WebCore::InsertTextCommand::input):
- * editing/ModifySelectionListLevel.cpp:
- (WebCore::getStartEndListChildren):
- (WebCore::canIncreaseListLevel):
- (WebCore::canDecreaseListLevel):
- * editing/MoveSelectionCommand.cpp:
- (WebCore::MoveSelectionCommand::doApply):
- * editing/RemoveFormatCommand.cpp:
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- (WebCore::ReplaceSelectionCommand::doApply):
- (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- * editing/Selection.cpp: Removed.
- * editing/Selection.h: Removed.
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::moveTo):
- (WebCore::SelectionController::setSelection):
- (WebCore::SelectionController::nodeWillBeRemoved):
- (WebCore::SelectionController::clear):
- (WebCore::SelectionController::setBase):
- (WebCore::SelectionController::setExtent):
- (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
- (WebCore::SelectionController::selectAll):
- (WebCore::SelectionController::setSelectedRange):
- * editing/SelectionController.h:
- (WebCore::SelectionController::selection):
- (WebCore::SelectionController::selectionType):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::insertText):
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- * editing/TypingCommand.h:
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore):
- (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter):
- * editing/VisibleSelection.cpp: Added.
- (WebCore::VisibleSelection::VisibleSelection):
- (WebCore::VisibleSelection::selectionFromContentsOfNode):
- (WebCore::VisibleSelection::setBase):
- (WebCore::VisibleSelection::setExtent):
- (WebCore::VisibleSelection::firstRange):
- (WebCore::VisibleSelection::toNormalizedRange):
- (WebCore::VisibleSelection::expandUsingGranularity):
- (WebCore::makeSearchRange):
- (WebCore::VisibleSelection::appendTrailingWhitespace):
- (WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):
- (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
- (WebCore::VisibleSelection::updateSelectionType):
- (WebCore::VisibleSelection::validate):
- (WebCore::VisibleSelection::setWithoutValidation):
- (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
- (WebCore::VisibleSelection::isContentEditable):
- (WebCore::VisibleSelection::isContentRichlyEditable):
- (WebCore::VisibleSelection::rootEditableElement):
- (WebCore::VisibleSelection::shadowTreeRootNode):
- (WebCore::VisibleSelection::debugPosition):
- (WebCore::VisibleSelection::formatForDebugger):
- (WebCore::VisibleSelection::showTreeForThis):
- (showTree):
- * editing/VisibleSelection.h: Added.
- (WebCore::VisibleSelection::):
- (WebCore::VisibleSelection::selectionType):
- (WebCore::VisibleSelection::setAffinity):
- (WebCore::VisibleSelection::affinity):
- (WebCore::VisibleSelection::base):
- (WebCore::VisibleSelection::extent):
- (WebCore::VisibleSelection::start):
- (WebCore::VisibleSelection::end):
- (WebCore::VisibleSelection::visibleStart):
- (WebCore::VisibleSelection::visibleEnd):
- (WebCore::VisibleSelection::isNone):
- (WebCore::VisibleSelection::isCaret):
- (WebCore::VisibleSelection::isRange):
- (WebCore::VisibleSelection::isCaretOrRange):
- (WebCore::VisibleSelection::isBaseFirst):
- (WebCore::VisibleSelection::granularity):
- (WebCore::operator==):
- (WebCore::operator!=):
- * editing/htmlediting.cpp:
- (WebCore::selectionForParagraphIteration):
- (WebCore::avoidIntersectionWithNode):
- * editing/htmlediting.h:
- * editing/markup.cpp:
- (WebCore::createMarkup):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::selection):
- * html/HTMLInputElement.h:
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::selection):
- * html/HTMLTextAreaElement.h:
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::selection):
- (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::selection):
- (WebCore::AccessibilityRenderObject::setSelectedTextRange):
- (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
- (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
- (WebCore::AccessibilityRenderObject::doAXRangeForLine):
- * page/AccessibilityRenderObject.h:
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::anchorNode):
- (WebCore::DOMSelection::anchorOffset):
- (WebCore::DOMSelection::focusNode):
- (WebCore::DOMSelection::focusOffset):
- (WebCore::DOMSelection::collapseToEnd):
- (WebCore::DOMSelection::collapseToStart):
- (WebCore::DOMSelection::getRangeAt):
- (WebCore::DOMSelection::addRange):
- * page/DOMSelection.h:
- * page/DragController.cpp:
- (WebCore::DragController::tryDocumentDrag):
- (WebCore::setSelectionToDragCaret):
- (WebCore::DragController::concludeEditDrag):
- (WebCore::prepareClipboardForImageDrag):
- (WebCore::DragController::startDrag):
- (WebCore::DragController::placeDragCaret):
- * page/EditorClient.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::selectClosestWordFromMouseEvent):
- (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
- (WebCore::EventHandler::handleMousePressEventTripleClick):
- (WebCore::EventHandler::handleMousePressEventSingleClick):
- (WebCore::EventHandler::updateSelectionForMouseDrag):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- * page/Frame.cpp:
- (WebCore::Frame::mark):
- (WebCore::Frame::setMark):
- (WebCore::Frame::selectionLayoutChanged):
- (WebCore::Frame::shouldChangeSelection):
- (WebCore::Frame::shouldDeleteSelection):
- (WebCore::Frame::revealSelection):
- (WebCore::Frame::setSelectionFromNone):
- (WebCore::Frame::findString):
- (WebCore::Frame::respondToChangedSelection):
- * page/Frame.h:
- * page/Page.cpp:
- (WebCore::Page::selection):
- * page/Page.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::fillInlineSelectionGaps):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setSelectionRange):
- (WebCore::RenderTextControl::selection):
- * rendering/RenderTextControl.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::writeSelection):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::fillLineSelectionGap):
- * svg/SVGTextContentElement.cpp:
- (WebCore::SVGTextContentElement::selectSubString):
-
-2009-02-09 Dimitri Glazkov <dglazkov@chromium.org>
+ Reviewed by Sam Weinig
- Reviewed by Dave Hyatt.
+ <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
- https://bugs.webkit.org/show_bug.cgi?id=23806
- Fix a regression crash where an empty src value and a "text/html" type
- on an EMBED element did not finish ResourceRequest initialization due to
- an early return.
+ When we disabled content sniffing for file urls we lost knowledge of many file extensions that we
+ didn't intend to lose. Turns out the CoreTypes UTI database doesn't know about every extension Gatekeeper
+ knew about.
- Test: fast/loader/empty-embed-src-attribute.html
+ By comparing CoreTypes' database to Gatekeepers, this patch adds a hardcoded list of file extension to MIME
+ type mappings that are missing in CoreType's database.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::addExtraFieldsToRequest):
+ Test: platform/mac/fast/loader/file-url-mimetypes.html
-2009-02-09 Rob Buis <rwlbuis@gmail.com>
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Move the MIME Type swizzling code to
+ WebCoreURLResponse.
- Reviewed by Eric Seidel.
+ * platform/network/mac/ResourceResponseMac.mm:
+ (WebCore::ResourceResponse::platformLazyInit): _webcore_MIMEType -> MIMEType, as we now have only one place
+ where we do all MIMEType correction.
+
+ * platform/network/mac/WebCoreURLResponse.h: Remove _webcore_MIMEType, as it is now folded into the swizzled
+ implementation of MIMEType.
+ * platform/network/mac/WebCoreURLResponse.mm:
+ (createBinaryExtensionsSet):
+ (createExtensionToMIMETypeMap):
+ (swizzleMIMETypeMethodIfNecessary):
+ (webNSURLResponseMIMEType): If it's a file URL and there's no MIME type, see if the extension exists in the
+ extension -> MIME type map before turning to the default MIME type. Also roll in what was previously
+ implemented in _webcore_MIMEType.
- https://bugs.webkit.org/show_bug.cgi?id=23816
- Clean up RenderSVGRoot.cpp
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::~SVGImage): Tweak this ASSERT - SVGImages might get destroyed without ever having a client.
- Clean up RenderSVGRoot.cpp.
+2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::calcViewport):
+ Reviewed by Simon Fraser.
-2009-02-09 Eric Carlson <eric.carlson@apple.com>
+ Show the fullscreen button only if the backend has support for it.
- Reviewed by Antti Koivisto
+ https://bugs.webkit.org/show_bug.cgi?id=26661
- https://bugs.webkit.org/show_bug.cgi?id=23737
- Make it possible to control media element playback without knowing so many
- internal implementation details.
+ No test since this is not reachable via the DOM.
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state.
- (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode.
- (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
* html/HTMLMediaElement.h:
-
- (WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
+ (WebCore::HTMLMediaElement::supportsFullscreen): new
* html/HTMLVideoElement.h:
-
- (WebCore::HTMLVideoElement::hasVideo): New.
-
+ (WebCore::HTMLVideoElement::supportsFullscreen): new
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::supportsFullscreen): new
+ (WebCore::MediaPlayer::supportsFullscreen): new
+ * platform/graphics/MediaPlayer.h: new
+ * platform/graphics/MediaPlayerPrivate.h: new
+ (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): new
* rendering/MediaControlElements.cpp:
- (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element
- togglePlayState method.
- (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing
- begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time
- will change.
-
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including
- internal logic here.
- (WebCore::RenderMedia::updateControlVisibility): Ditto.
-
-2009-02-09 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto
-
- Change RenderPart and RenderPartObject constructors to take a Node*
- instead of a HTMLFrameOwnerElement* since that is all then need.
-
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
- * rendering/RenderPart.h:
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::RenderPartObject): take Node* instead of HTMLFrameOwnerElement*
- * rendering/RenderPartObject.h:
-
-2009-02-09 Dan Bernstein <mitz@apple.com>
-
- - fix -Wmissing-prototypes builds
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::isHeaderElement): Marked this function static.
- (WebCore::haveSameTagName): Ditto.
- * editing/markup.cpp:
- (WebCore::isSpecialAncestorBlock): Ditto.
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::makeMapBetweenRects): Removed unused function.
- * platform/graphics/transforms/TransformationMatrix.h: Removed unused
- declaration of private member makeMapBetweenRects().
-
-2009-02-09 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23850
- Code cleanup of HTMLParser class which was using a mix of m_* and bare
- class member variable names which helps to obfuscate the code. Also
- changed a few of the static helper functions to take a const pointer type
- as they should not be modifying the node.
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::HTMLParser):
- (WebCore::HTMLParser::~HTMLParser):
- (WebCore::HTMLParser::reset):
- (WebCore::HTMLParser::setCurrent):
- (WebCore::HTMLParser::parseToken):
- (WebCore::HTMLParser::parseDoctypeToken):
- (WebCore::isTableSection):
- (WebCore::isTablePart):
- (WebCore::isTableRelated):
- (WebCore::HTMLParser::insertNode):
- (WebCore::HTMLParser::handleError):
- (WebCore::HTMLParser::textCreateErrorCheck):
- (WebCore::HTMLParser::commentCreateErrorCheck):
- (WebCore::HTMLParser::headCreateErrorCheck):
- (WebCore::HTMLParser::bodyCreateErrorCheck):
- (WebCore::HTMLParser::framesetCreateErrorCheck):
- (WebCore::HTMLParser::formCreateErrorCheck):
- (WebCore::HTMLParser::isindexCreateErrorCheck):
- (WebCore::HTMLParser::noscriptCreateErrorCheck):
- (WebCore::HTMLParser::pCloserStrictCreateErrorCheck):
- (WebCore::HTMLParser::mapCreateErrorCheck):
- (WebCore::HTMLParser::getNode):
- (WebCore::HTMLParser::allowNestedRedundantTag):
- (WebCore::HTMLParser::processCloseTag):
- (WebCore::HTMLParser::isInline):
- (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
- (WebCore::HTMLParser::reopenResidualStyleTags):
- (WebCore::HTMLParser::pushBlock):
- (WebCore::HTMLParser::popBlock):
- (WebCore::HTMLParser::popOneBlockCommon):
- (WebCore::HTMLParser::popOneBlock):
- (WebCore::HTMLParser::moveOneBlockToStack):
- (WebCore::HTMLParser::checkIfHasPElementInScope):
- (WebCore::HTMLParser::popInlineBlocks):
- (WebCore::HTMLParser::freeBlock):
- (WebCore::HTMLParser::createHead):
- (WebCore::HTMLParser::handleIsindex):
- (WebCore::HTMLParser::startBody):
- (WebCore::HTMLParser::finished):
- (WebCore::HTMLParser::reportErrorToConsole):
- * html/HTMLParser.h:
-
-2009-02-09 Alexey Proskuryakov <ap@webkit.org>
-
- Applying review comment on a second location.
-
- * rendering/RenderText.cpp: (WebCore::RenderText::nextOffset):
- Use "ifdef BUILDING_ON_TIGER".
-
-2009-02-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23845
- editing/deleting/backward-deletion.html fails on Tiger
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::previousOffset):
- (WebCore::RenderText::nextOffset):
- Work around a bug in older ICU versions by hardcoding narrow voiced marks.
-
-2009-02-09 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.
-
-2009-02-09 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Make WorkerMessagingProxy derive from two base proxy classes.
- https://bugs.webkit.org/show_bug.cgi?id=23777
-
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- * dom/Worker.cpp:
- (WebCore::Worker::terminate):
- (WebCore::Worker::hasPendingActivity):
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::reportException):
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::WorkerThreadActivityReportTask::performTask):
- (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
- (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
- (WebCore::WorkerMessagingProxy::terminateWorkerContext):
- (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
- (WebCore::WorkerMessagingProxy::reportPendingActivity):
- (WebCore::WorkerMessagingProxy::reportPendingActivityInternal):
- (WebCore::WorkerMessagingProxy::hasPendingActivity):
- * dom/WorkerMessagingProxy.h:
-
-2009-02-09 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Introduce 2 base classes to split WorkerMessagingProxy.
- https://bugs.webkit.org/show_bug.cgi?id=23776
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/WorkerContextProxy.h: Added.
- (WebCore::WorkerContextProxy::~WorkerContextProxy):
- * dom/WorkerObjectProxy.h: Added.
- (WebCore::WorkerObjectProxy::~WorkerObjectProxy):
-
-2009-02-08 David Hyatt <hyatt@apple.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23839
-
- Make sure that generated content is properly handled when content is moved from a block run-in
- to an inline run-in.
-
- Reviewed by Sam Weinig
-
- Added fast/runin/002.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::handleRunInChild):
-
-2009-02-08 David Hyatt <hyatt@apple.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
- Web inspector.
-
- Reviewed by Mark Rowe
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteRectsForRange):
- (WebCore::RenderObject::absoluteQuadsForRange):
-
-2009-02-08 Dirk Schulze <krit@webkit.org>
-
- Unreviewed Qt build fix.
-
- TransformationMatrix changes in r40761 broke QT build.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::getCTM):
- (WebCore::GraphicsContext::scale):
-
-2009-02-08 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Holger Freyther.
-
- This is a follow up of the last commit. It cleans up TransformationMatrix.h
- and convert to a series of #elif.
-
- * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): new
+ * rendering/MediaControlElements.h:
-2009-02-08 Gustavo Noronha Silva <gns@gnome.org>
+2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
- [CAIRO] build broken by TransformationMatrix rework
- https://bugs.webkit.org/show_bug.cgi?id=23831
-
- Fixed cairo build after the TransformationMatrix rework done in
- revision 40761.
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::getCTM):
- (WebCore::GraphicsContext::concatCTM):
- * platform/graphics/cairo/TransformationMatrixCairo.cpp:
- (WebCore::TransformationMatrix::operator cairo_matrix_t):
- * platform/graphics/transforms/TransformationMatrix.h:
-
-2009-02-07 David Hyatt <hyatt@apple.com>
-
- Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
- Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
- base InlineBox class. Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
- back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
- boxes and image boxes shrink by 4 bytes.
-
- Reviewed by Anders
-
- * rendering/InlineBox.h:
- (WebCore::InlineBox::InlineBox):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::InlineFlowBox):
- (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
- (WebCore::InlineFlowBox::hasTextChildren):
-
-2009-02-07 Dean Jackson <dino@apple.com>
-
- Attempted build fix for Qt. Not reviewed.
-
- TransformationMatrix changes in r40761 broke non-Apple builds.
-
- * platform/graphics/qt/TransformationMatrixQt.cpp:
- (WebCore::TransformationMatrix::operator QMatrix):
- * platform/graphics/transforms/TransformationMatrix.h:
-
-2009-02-07 David Hyatt <hyatt@apple.com>
-
- This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject. This shift
- in base class knocks 32 bytes off the size of every RenderInline. All of the necessary functions
- for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
- or split into two functions (one in each derived class).
-
- Reviewed by Anders and Antti
-
- * dom/Element.cpp:
- (WebCore::Element::offsetLeft):
- (WebCore::Element::offsetTop):
- (WebCore::Element::offsetWidth):
- (WebCore::Element::offsetHeight):
- (WebCore::Element::offsetParent):
- (WebCore::Element::clientWidth):
- (WebCore::Element::clientHeight):
- (WebCore::Element::scrollWidth):
- (WebCore::Element::scrollHeight):
- * dom/Node.cpp:
- (WebCore::Node::renderBox):
- (WebCore::Node::renderBoxModelObject):
- * dom/Node.h:
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::boxModelObject):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::marginLeft):
- (WebCore::InlineFlowBox::marginRight):
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::borderLeft):
- (WebCore::InlineFlowBox::borderRight):
- (WebCore::InlineFlowBox::paddingLeft):
- (WebCore::InlineFlowBox::paddingRight):
- * rendering/RenderBlock.cpp:
- (WebCore::getBorderPaddingMargin):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::imageChanged):
- (WebCore::RenderBox::calcReplacedWidthUsing):
- (WebCore::RenderBox::calcReplacedHeightUsing):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontal):
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
- (WebCore::RenderBox::calcAbsoluteVertical):
- (WebCore::RenderBox::calcAbsoluteVerticalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- (WebCore::RenderBox::positionForCoordinates):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::borderBoundingBox):
- (WebCore::RenderBox::offsetHeight):
- (WebCore::RenderBox::marginTop):
- (WebCore::RenderBox::marginBottom):
- (WebCore::RenderBox::marginLeft):
- (WebCore::RenderBox::marginRight):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::offsetLeft):
- (WebCore::RenderBoxModelObject::offsetTop):
- (WebCore::RenderBoxModelObject::paddingTop):
- (WebCore::RenderBoxModelObject::paddingBottom):
- (WebCore::RenderBoxModelObject::paddingLeft):
- (WebCore::RenderBoxModelObject::paddingRight):
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- (WebCore::RenderBoxModelObject::calculateBackgroundSize):
- (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- * rendering/RenderBoxModelObject.h:
- (WebCore::RenderBoxModelObject::borderTop):
- (WebCore::RenderBoxModelObject::borderBottom):
- (WebCore::RenderBoxModelObject::borderLeft):
- (WebCore::RenderBoxModelObject::borderRight):
- (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin):
- (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding):
- (WebCore::RenderBoxModelObject::childBecameNonInline):
- (WebCore::RenderBoxModelObject::isBoxModelObject):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::destroy):
- (WebCore::RenderInline::styleDidChange):
- (WebCore::nextContinuation):
- (WebCore::RenderInline::continuationBefore):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::splitFlow):
- (WebCore::RenderInline::addChildToContinuation):
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::offsetLeft):
- (WebCore::RenderInline::offsetTop):
- (WebCore::RenderInline::marginLeft):
- (WebCore::RenderInline::marginRight):
- (WebCore::RenderInline::positionForCoordinates):
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- (WebCore::RenderInline::rectWithOutlineForRepaint):
- (WebCore::RenderInline::computeRectForRepaint):
- (WebCore::RenderInline::updateDragState):
- (WebCore::RenderInline::childBecameNonInline):
- (WebCore::RenderInline::updateHitTestResult):
- (WebCore::RenderInline::imageChanged):
- (WebCore::RenderInline::addFocusRingRects):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::marginTop):
- (WebCore::RenderInline::marginBottom):
- (WebCore::RenderInline::continuation):
- (WebCore::RenderInline::setContinuation):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::paint):
- (WebCore::RenderLineBoxList::hitTest):
- * rendering/RenderLineBoxList.h:
- * rendering/RenderObject.cpp:
- (WebCore::addLayers):
- (WebCore::RenderObject::removeLayers):
- (WebCore::RenderObject::moveLayers):
- (WebCore::RenderObject::findNextLayer):
- (WebCore::RenderObject::enclosingLayer):
- (WebCore::RenderObject::enclosingCompositingLayer):
- (WebCore::RenderObject::setLayerNeedsFullRepaint):
- (WebCore::RenderObject::handleDynamicFloatPositionChange):
- (WebCore::RenderObject::destroy):
- (WebCore::RenderObject::offsetParent):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isInlineContinuation):
- * rendering/RenderSVGTSpan.cpp:
- (WebCore::RenderSVGTSpan::absoluteRects):
- (WebCore::RenderSVGTSpan::absoluteQuads):
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::absoluteRects):
- (WebCore::RenderSVGTextPath::absoluteQuads):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::setBestTruncatedAt):
- * rendering/RenderView.h:
- * rendering/bidi.cpp:
- (WebCore::getBorderPaddingMargin):
- (WebCore::inlineWidth):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::inlineFlowRequiresLineBox):
- (WebCore::requiresLineBox):
- (WebCore::RenderBlock::findNextLineBreak):
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::isKeyboardFocusable):
-
-2009-02-07 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Timothy Hatcher <timothy@hatcher.name>
-
- Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
- Include localStorage and sessionStorage in DatabasesPanel.
-
- * WebCore.vcproj/WebCore.vcproj:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorDOMStorageResource::create):
- (WebCore::InspectorDOMStorageResource::setScriptObject):
- (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
- (WebCore::InspectorController::populateScriptObjects):
- (WebCore::InspectorController::addDOMStorageScriptResource):
- (WebCore::InspectorController::removeDOMStorageScriptResource):
- (WebCore::InspectorController::resetScriptObjects):
- (WebCore::InspectorController::didCommitLoad):
- (WebCore::InspectorController::didUseDOMStorage):
- * inspector/InspectorController.h:
- * inspector/front-end/DOMStorage.js: Added.
- (WebInspector.DOMStorage):
- (WebInspector.DOMStorage.prototype.get domStorage):
- (WebInspector.DOMStorage.prototype.set domStorage):
- (WebInspector.DOMStorage.prototype.get domain):
- (WebInspector.DOMStorage.prototype.set domain):
- (WebInspector.DOMStorage.prototype.get isLocalStorage):
- (WebInspector.DOMStorage.prototype.set isLocalStorage):
- * inspector/front-end/DOMStorageItemsView.js: Added.
- (WebInspector.DOMStorageItemsView):
- (WebInspector.DOMStorageItemsView.prototype.show):
- (WebInspector.DOMStorageItemsView.prototype.update):
- * inspector/front-end/DatabaseQueryView.js:
- (WebInspector.DatabaseQueryView):
- * inspector/front-end/DatabaseTableView.js:
- (WebInspector.DatabaseTableView):
- (WebInspector.DatabaseTableView.prototype._queryFinished):
- (WebInspector.DatabaseTableView.prototype._queryError):
- * inspector/front-end/DatabasesPanel.js:
- (WebInspector.DatabasesPanel):
- (WebInspector.DatabasesPanel.prototype.reset):
- (WebInspector.DatabasesPanel.prototype.addDatabase):
- (WebInspector.DatabasesPanel.prototype.addDOMStorage):
- (WebInspector.DatabasesPanel.prototype.showDatabase):
- (WebInspector.DatabasesPanel.prototype.showDOMStorage):
- (WebInspector.DatabasesPanel.prototype.closeVisibleView):
- (WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
- (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
- (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
- (WebInspector.DOMStorageSidebarTreeElement):
- (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect):
- (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
- (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle):
- (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle):
- (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
- * inspector/front-end/Images/domStorage.png: Added.
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/inspector.css:
- * inspector/front-end/inspector.html:
- * inspector/front-end/inspector.js:
- (WebInspector.addDOMStorage):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::sessionStorage):
- (WebCore::DOMWindow::localStorage):
+ <rdar://problem/7007776> Controller doesn't automatically update counters when file
+ is playing ( http://www.jazzguitar.be/mp3/Michael%20Lewis%20-%20SSSJ.mp3 )
-2009-02-07 Feng Qian <feng@chromium.org>
+ Update the time display when the movie time changes.
- Reviewed by Eric Seidel <eric@webkit.org>
-
- Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
- https://bugs.webkit.org/show_bug.cgi?id=23574
-
- * page/EventHandler.cpp:
- * page/EventHandler.h:
-
-2009-02-07 Zalan Bujtas <zbujtas@gmail.com>
-
- Reviewed by Rob Buis <rwlbuis@gmail.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=23788
- call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.
-
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::skipLeadingWhitespace):
-
-2009-02-07 Rob Buis <rwlbuis@gmail.com>
-
- Reviewed by Darin.
-
- https://bugs.webkit.org/show_bug.cgi?id=3248
- Bug 3248: Mouse events on OPTION element seem to be ignored
-
- Support mouse events on options in a select when it forms a list box.
-
- Test: fast/forms/option-mouseevents.html
-
- * html/HTMLSelectElement.cpp: Convert to coords relative to the list box.
- (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- * rendering/RenderListBox.cpp: Handle hit testing for option elements.
- (WebCore::RenderListBox::nodeAtPoint):
- * rendering/RenderListBox.h:
-
-2009-02-07 Adam Treat <adam.treat@torchmobile.com>
-
- Prospective build fix for all non-Apple platforms.
-
- * platform/graphics/transforms/TransformationMatrix.h:
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::updateControls):
-2009-02-06 Chris Marrin <cmarrin@apple.com>
+2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
- https://bugs.webkit.org/show_bug.cgi?id=6868
-
- I have not only made TransformationMatrix platform independent
- but I've also added 3D methods, which will be used when I update
- WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
- I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
- the math as doubles rather than floats. This makes a TransformationMatrix
- go from 24 bytes to 128 bytes, but I don't think this class is used enough to
- make this overhead will be significant.
-
- The change from floats to doubles has caused some differences in rounding and
- display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
- so I've had to change some LayoutTest results in the SVG tests.
-
- * platform/graphics/FloatPoint.cpp:
- (WebCore::FloatPoint::matrixTransform):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::getCTM):
- * platform/graphics/cg/TransformationMatrixCG.cpp:
- (WebCore::TransformationMatrix::operator CGAffineTransform):
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::determinant2x2):
- (WebCore::determinant3x3):
- (WebCore::determinant4x4):
- (WebCore::adjoint):
- (WebCore::inverse):
- (WebCore::transposeMatrix4):
- (WebCore::v4MulPointByMatrix):
- (WebCore::v3Length):
- (WebCore::v3Scale):
- (WebCore::v3Dot):
- (WebCore::v3Combine):
- (WebCore::v3Cross):
- (WebCore::decompose):
- (WebCore::slerp):
- (WebCore::TransformationMatrix::scale):
- (WebCore::TransformationMatrix::rotateFromVector):
- (WebCore::TransformationMatrix::flipX):
- (WebCore::TransformationMatrix::flipY):
- (WebCore::makeMapBetweenRects):
- (WebCore::TransformationMatrix::projectPoint):
- (WebCore::TransformationMatrix::mapPoint):
- (WebCore::TransformationMatrix::mapRect):
- (WebCore::TransformationMatrix::mapQuad):
- (WebCore::TransformationMatrix::scale3d):
- (WebCore::TransformationMatrix::rotate3d):
- (WebCore::TransformationMatrix::translate):
- (WebCore::TransformationMatrix::translate3d):
- (WebCore::TransformationMatrix::skew):
- (WebCore::TransformationMatrix::applyPerspective):
- (WebCore::TransformationMatrix::multLeft):
- (WebCore::TransformationMatrix::multVecMatrix):
- (WebCore::TransformationMatrix::isInvertible):
- (WebCore::TransformationMatrix::inverse):
- (WebCore::blendFloat):
- (WebCore::TransformationMatrix::blend):
- (WebCore::TransformationMatrix::decompose):
- (WebCore::TransformationMatrix::recompose):
- * platform/graphics/transforms/TransformationMatrix.h:
- (WebCore::TransformationMatrix::TransformationMatrix):
- (WebCore::TransformationMatrix::setMatrix):
- (WebCore::TransformationMatrix::operator =):
- (WebCore::TransformationMatrix::makeIdentity):
- (WebCore::TransformationMatrix::isIdentity):
- (WebCore::TransformationMatrix::map):
- (WebCore::TransformationMatrix::m11):
- (WebCore::TransformationMatrix::setM11):
- (WebCore::TransformationMatrix::m12):
- (WebCore::TransformationMatrix::setM12):
- (WebCore::TransformationMatrix::m13):
- (WebCore::TransformationMatrix::setM13):
- (WebCore::TransformationMatrix::m14):
- (WebCore::TransformationMatrix::setM14):
- (WebCore::TransformationMatrix::m21):
- (WebCore::TransformationMatrix::setM21):
- (WebCore::TransformationMatrix::m22):
- (WebCore::TransformationMatrix::setM22):
- (WebCore::TransformationMatrix::m23):
- (WebCore::TransformationMatrix::setM23):
- (WebCore::TransformationMatrix::m24):
- (WebCore::TransformationMatrix::setM24):
- (WebCore::TransformationMatrix::m31):
- (WebCore::TransformationMatrix::setM31):
- (WebCore::TransformationMatrix::m32):
- (WebCore::TransformationMatrix::setM32):
- (WebCore::TransformationMatrix::m33):
- (WebCore::TransformationMatrix::setM33):
- (WebCore::TransformationMatrix::m34):
- (WebCore::TransformationMatrix::setM34):
- (WebCore::TransformationMatrix::m41):
- (WebCore::TransformationMatrix::setM41):
- (WebCore::TransformationMatrix::m42):
- (WebCore::TransformationMatrix::setM42):
- (WebCore::TransformationMatrix::m43):
- (WebCore::TransformationMatrix::setM43):
- (WebCore::TransformationMatrix::m44):
- (WebCore::TransformationMatrix::setM44):
- (WebCore::TransformationMatrix::a):
- (WebCore::TransformationMatrix::setA):
- (WebCore::TransformationMatrix::b):
- (WebCore::TransformationMatrix::setB):
- (WebCore::TransformationMatrix::c):
- (WebCore::TransformationMatrix::setC):
- (WebCore::TransformationMatrix::d):
- (WebCore::TransformationMatrix::setD):
- (WebCore::TransformationMatrix::e):
- (WebCore::TransformationMatrix::setE):
- (WebCore::TransformationMatrix::f):
- (WebCore::TransformationMatrix::setF):
- (WebCore::TransformationMatrix::multiply):
- (WebCore::TransformationMatrix::rotate):
- (WebCore::TransformationMatrix::skewX):
- (WebCore::TransformationMatrix::skewY):
- (WebCore::TransformationMatrix::hasPerspective):
- (WebCore::TransformationMatrix::):
- (WebCore::TransformationMatrix::isAffine):
- (WebCore::TransformationMatrix::operator==):
- (WebCore::TransformationMatrix::operator*=):
- (WebCore::TransformationMatrix::operator*):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::nodeAtPoint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateTransform):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::mapAbsolutePointToLocal):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::nodeAtPoint):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::nodeAtPoint):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::nodeAtPoint):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- * svg/SVGAnimateMotionElement.cpp:
- (WebCore::SVGAnimateMotionElement::resetToBaseValue):
- (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::viewport):
- * svg/SVGTransform.cpp:
- (SVGTransform::setTranslate):
- (SVGTransform::setScale):
- (SVGTransform::setRotate):
- (SVGTransform::setSkewX):
- (SVGTransform::setSkewY):
- * svg/graphics/SVGResourceMarker.cpp:
- (WebCore::SVGResourceMarker::draw):
-
-2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- For the Qt port implement Image::drawPattern via
- BitmapImage::drawPatterns' implementation and implement
- Gradient::fill.
-
- This partially fixes rendering of generated gradient content.
-
- * platform/graphics/BitmapImage.h: Remove the drawPattern
- implementation for the Qt port in BitmapImage, it's been moved to
- Image::drawPattern.
- * platform/graphics/qt/GradientQt.cpp:
- (WebCore::Gradient::fill): Implement using a simple fillRect.
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::Image::drawPattern): Moved implementation from
- BitmapImage::drawPattern.
-
-2009-02-06 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- DOMSelection.getRangeAt() returns a different range than the selection
- https://bugs.webkit.org/show_bug.cgi?id=23601
-
- Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
-
- Test: fast/dom/Selection/getRangeAt.html
-
- * WebCore.base.exp:
- * dom/InputElement.cpp:
- (WebCore::InputElement::handleBeforeTextInsertedEvent):
- * editing/DeleteButtonController.cpp:
- (WebCore::enclosingDeletableElement):
- * editing/Editor.cpp:
- (WebCore::Editor::selectedRange):
- (WebCore::Editor::fontForSelection):
- (WebCore::Editor::applyStyleToSelection):
- (WebCore::Editor::applyParagraphStyleToSelection):
- (WebCore::Editor::insertTextWithoutSendingTextEvent):
- (WebCore::Editor::insertLineBreak):
- (WebCore::Editor::insertParagraphSeparator):
- (WebCore::Editor::ignoreSpelling):
- (WebCore::Editor::isSelectionUngrammatical):
- (WebCore::Editor::guessesForUngrammaticalSelection):
- (WebCore::markMisspellingsOrBadGrammar):
- (WebCore::Editor::rangeForPoint):
- * editing/EditorCommand.cpp:
- (WebCore::expandSelectionToGranularity):
- (WebCore::executeDeleteToMark):
- (WebCore::executeSelectToMark):
- * editing/RemoveFormatCommand.cpp:
- (WebCore::RemoveFormatCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * editing/Selection.cpp:
- (WebCore::Selection::firstRange):
- (WebCore::Selection::toNormalizedRange):
- * editing/Selection.h:
- * editing/SelectionController.h:
- (WebCore::SelectionController::toNormalizedRange):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- * editing/markup.cpp:
- (WebCore::createMarkup):
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::createFromSelection):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::contextMenuItemSelected):
- * page/DOMSelection.cpp:
- (WebCore::DOMSelection::getRangeAt):
- (WebCore::DOMSelection::addRange):
- (WebCore::DOMSelection::deleteFromDocument):
- (WebCore::DOMSelection::containsNode):
- (WebCore::DOMSelection::toString):
- * page/DragController.cpp:
- (WebCore::setSelectionToDragCaret):
- (WebCore::DragController::concludeEditDrag):
- (WebCore::DragController::startDrag):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchMouseEvent):
- * page/Frame.cpp:
- (WebCore::Frame::selectedText):
- (WebCore::Frame::shouldChangeSelection):
- (WebCore::Frame::shouldDeleteSelection):
- (WebCore::Frame::selectionComputedStyle):
- (WebCore::Frame::selectionTextRects):
- (WebCore::Frame::findString):
- (WebCore::Frame::respondToChangedSelection):
- * platform/ContextMenu.cpp:
- (WebCore::selectionContainsPossibleWord):
-
-2009-02-06 Brady Eidson <beidson@apple.com>
-
- Reviewed by Dan Bernstein
-
- <rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
- before ::didReceiveResponse().
-
- No layout test, as we don't have a concrete way to reproduce these conditions. To that effect, I've added an ASSERT
- to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
- this case and can come up with something more reproducible.
-
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response. This is much
- like the FrameLoader::init() response that is used for initial document creation.
-
-2009-02-06 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * WebCore.base.exp:
-
-2009-02-06 Xan Lopez <xan@gnome.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26659
- Reviewed by Holger Freyther.
+ Support hidding a control bar element from the Media element controller.
- https://bugs.webkit.org/show_bug.cgi?id=23621
+ Update layout tests since the fullscreen button no longer has a renderer.
- Do not use m_scrollOffset to check if we are setting the same
- value than we already have.
-
- m_scrollOffset starts at 0 for ScrollView, so when opening a new
- page and scrolling to 0 (the usual case) the check will fail and
- we won't update the adjustment value, resulting in a possibly
- mispositioned scrollbar. Use the adjustment value directly
- instead, which is what we are updating anyway.
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformHandleHorizontalAdjustment):
- (WebCore::ScrollView::platformHandleVerticalAdjustment):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaTextDisplayElement::update): call updateStyle() so everything
+ is updated properly.
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ (WebCore::MediaControlInputElement::update): call updateStyle()
+ (WebCore::MediaControlInputElement::updateStyle): create the renderer properly
+ or not depending on what rendererIsNeeded() return.
+ * rendering/MediaControlElements.h:
-2009-02-06 Justin Garcia <justin.garcia@apple.com>
+2009-06-26 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
- https://bugs.webkit.org/show_bug.cgi?id=23800
- Header elements are not always preserved during paste
-
- At paste time, don't merge out of header elements. At copy time, be sure to include
- headers in the list of special common ancestor blocks, so that copying a paragraph or less
- of content inside a header will include the header element in the copied markup.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::areSameHeaderElements):
- (WebCore::ReplaceSelectionCommand::shouldMerge):
- * editing/markup.cpp:
- (WebCore::isSpecialAncestorBlock):
- (WebCore::createMarkup):
-
-2009-02-06 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Part III of <rdar://problem/6552272>.
-
- Make redirect data available to WebKit. (I tried having WebKit track this
- data for itself, but that went wrong -- it's just too hard to figure
- out the weird corners of the WebCore loader from within another framework.)
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::DocumentLoader):
- * loader/DocumentLoader.h: Store a flag indicating whether we created
- a global history entry. If we didn't, then we know that the next redirect
- should not link to us, since we're not in history.
-
- (WebCore::DocumentLoader::clientRedirectSourceForHistory):
- (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
- (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
- (WebCore::DocumentLoader::serverRedirectSourceForHistory):
- (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
- (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
- (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
- to help WebKit wade through the muck of WebCore history.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
- this client function to say what it does, instead of when it's called.
+ <rdar://problem/6968137> Profiler title numbers increment even after a
+ reload.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::load):
- (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
- store a link to the previous history URL in the new DocumentLoader, so
- it can update WebKit with that link when the load commits.
+ - Now the numbers are reset when the profiles are.
- (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
- described above.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
- * loader/FrameLoader.h:
- (WebCore::FrameLoader::documentLoader):
- (WebCore::FrameLoader::policyDocumentLoader):
- (WebCore::FrameLoader::provisionalDocumentLoader):
- (WebCore::FrameLoader::state): Inlined a few trivial functions because
- performance mistakes give me the itches.
+2009-06-26 Adele Peterson <adele@apple.com>
- * loader/FrameLoaderClient.h: Renamed this client function to say what
- it does, instead of when it's called.
+ Reviewed by Darin Adler.
-2009-02-06 Eric Seidel <eric@webkit.org>
+ Fix for <rdar://problem/7000796>
+ REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages
- Reviewed by Justin Garcia.
+ Test: editing/inserting/break-blockquote-after-delete.html
- Minor refactoring and cleanup to Selection code
- https://bugs.webkit.org/show_bug.cgi?id=23774
+ Keep track of whether the typing style should be preserved after the TypingCommand is applied. When adding onto an open
+ typing command, keep that flag up to date.
- No functional changes, thus no tests.
+ In this case, an InsertParagraphSeparatorInQuotedContent command, which should not preserve typing style,
+ was following an open Delete command, which does preserve the typing style. So we were applying the original
+ typing style (from before the delete, so blue text) to the cursor in the unquoted area after breaking up the blockquote.
- * editing/Editor.cpp:
- (WebCore::Editor::applyStyle):
- (WebCore::Editor::applyParagraphStyle):
- * editing/Selection.cpp:
- (WebCore::Selection::Selection):
- (WebCore::Selection::setBaseAndExtentToDeepEquivalents):
- (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity):
- (WebCore::Selection::updateSelectionType):
- (WebCore::Selection::validate):
- (WebCore::Selection::setWithoutValidation):
- (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
- * editing/Selection.h:
- (WebCore::Selection::):
- (WebCore::Selection::selectionType):
- (WebCore::Selection::extent):
- (WebCore::Selection::isNone):
- (WebCore::Selection::isCaret):
- (WebCore::Selection::isRange):
- (WebCore::Selection::isCaretOrRange):
- * editing/SelectionController.h:
- (WebCore::SelectionController::selectionType):
* editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::TypingCommand):
+ (WebCore::TypingCommand::typingAddedToOpenCommand):
+ (WebCore::TypingCommand::insertTextRunWithoutNewlines):
+ (WebCore::TypingCommand::insertLineBreak):
+ (WebCore::TypingCommand::insertParagraphSeparator):
+ (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
- * page/Frame.cpp:
- (WebCore::Frame::revealSelection):
-
-2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23801
- Add custom V8 bindings for SVG.
-
- * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8SVGLengthCustom.cpp: Added.
- (WebCore::ACCESSOR_GETTER):
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8SVGMatrixCustom.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-02-06 David Levin <levin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Bug 23792: unused param is used in RenderLayer.cpp but not #include'd
- <https://bugs.webkit.org/show_bug.cgi?id=23792>
-
- Add include file for UnusedParam which is used in this file.
-
- * rendering/RenderLayer.cpp:
-
-2009-02-06 David Levin <levin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- <https://bugs.webkit.org/show_bug.cgi?id=23741>
-
- Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
- <https://bugs.webkit.org/show_bug.cgi?id=23798>
-
- Add protocolInHTTPFamily() to the KURLGoogle implementation.
- This is another chromium build fix to mirror r40553.
-
- While in this file, I did some style fixes and consistency fixes:
- + fixed many_occurences_of_underscoring_naming
- + usages of NULL
- + comparisons to 0
- + changed the copyright remove an extraneous , and capitalize the (C)
- which was suggested for other files that I've submitted.
-
- No observable change in behavior, so no test.
-
- * platform/KURL.h:
- (WebCore::KURL::protocolInHTTPFamily):
- * platform/KURLGoogle.cpp:
- (WebCore::KURLCharsetConverter::ConvertFromUTF16):
- (WebCore::lowerCaseEqualsASCII):
- (WebCore::KURLGooglePrivate::KURLGooglePrivate):
- (WebCore::KURLGooglePrivate::setUtf8):
- (WebCore::KURLGooglePrivate::setAscii):
- (WebCore::KURLGooglePrivate::init):
- (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily):
- (WebCore::KURLGooglePrivate::copyTo):
- (WebCore::KURLGooglePrivate::replaceComponents):
- (WebCore::KURL::KURL):
- (WebCore::KURL::createCFURL):
- (WebCore::KURL::isEmpty):
- (WebCore::KURL::protocolInHTTPFamily):
- (WebCore::KURL::query):
- (WebCore::decodeURLEscapeSequences):
- (WebCore::KURL::protocolIs):
- (WebCore::encodeWithURLEscapeSequences):
- (WebCore::KURL::invalidate):
- (WebCore::equalIgnoringRef):
- * platform/KURLGooglePrivate.h:
-
-2009-02-06 David Kilzer <ddkilzer@apple.com>
-
- Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer
-
- Reviewed by Darin Adler.
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::contentDataEquivalent): Moved method to
- WebCore::StyleRareNonInheritedData class.
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration
- with inline method that calls contentDataEquivalent() on
- WebCore::StyleRareNonInheritedData instead.
- * rendering/style/StyleRareNonInheritedData.cpp:
- (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix!
- Replaced pointer comparison of ContentData objects with call to
- StyleRareNonInheritedData::contentDataEquivalent().
- (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
- * rendering/style/StyleRareNonInheritedData.h:
- (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added
- declaration.
-
-2009-02-06 Simon Fraser <simon.fraser@apple.com>
+ (WebCore::TypingCommand::deleteSelection):
+ (WebCore::TypingCommand::updatePreservesTypingStyle):
+ * editing/TypingCommand.h: (WebCore::TypingCommand::preservesTypingStyle):
- Reviewed by Eric Seidel
-
- Factor code that checks whether the object is rooted in
- repaint() and repaintRectangle() into a common isRooted()
- method.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::repaint):
- (WebCore::RenderObject::repaintRectangle):
- (WebCore::RenderObject::isRooted):
- * rendering/RenderObject.h:
-
-2009-02-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Expose an isRootLayer() method on RenderLayer that works whether the
- layer is rooted or not, and use that in a few places in the
- accelerated compositing code.
-
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isRootLayer):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::paintingGoesToWindow):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- (WebCore::RenderLayerCompositor::requiresCompositingLayer):
-
-2009-02-06 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache
-
- Most platforms do not retrieve the small caps font from the FontCache,
- but cross-platform code in ~SimpleFontData() assumes the the small caps
- font data did come from the cache and therefore calls releaseFontData()
- on it.
-
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::~SimpleFontData): Reordered to call
- platformDestroy() before releasing the small caps font and pruning the
- glyph page tree. This allows platformDestroy() to reset
- m_smallCapsFontData to 0 if it was not obtained from the cache.
- * platform/graphics/chromium/SimpleFontDataLinux.cpp:
- (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to
- 0 after deleting it.
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformDestroy): Ditto.
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::platformDestroy): Ditto.
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformDestroy): Ditto.
-
-2009-02-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Make RenderStyle::transitionForProperty() const.
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::transitionForProperty):
- * rendering/style/RenderStyle.h:
-
-2009-02-06 Simon Fraser <simon.fraser@apple.com>
-
- Fix build when ACCELERATED_COMPOSITING is turned on.
-
- Remove font smoothing changes that will be committed
- separately.
-
- * platform/graphics/mac/WebLayer.mm:
- (WebCore::if):
-
-2009-02-06 Anders Carlsson <andersca@apple.com>
-
- Build fix.
-
- * bridge/npapi.h:
-
-2009-02-06 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23790
- Custom -> JSCCustom in SVGPointList.idl
-
- * svg/SVGPointList.idl:
-
-2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23309
- Fix whitespace indent errors. The rest of the original patch has already
- landed.
-
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::clear):
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::clear):
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::clear):
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::clear):
-
-2009-02-06 Dirk Schulze <krit@webkit.org>
+2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
- Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
- the context transparent.
-
- [QT] clearRect fill's a given rect with white
- https://bugs.webkit.org/show_bug.cgi?id=23728
+ Add support for saving and loading of QWebHistory to and from a QByteArray.
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::clearRect):
-
-2009-02-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23781
-
- When the document is attached and detached, and when it becomes active/inactive
- (e.g. coming out or going into the page cache) we need to call
- RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
- layers.
-
- Also, if Document::recalcStyle() does not do a layout, it needs to
- update the compositing layers.
-
- * dom/Document.cpp:
- (WebCore::Document::updateRendering):
- (WebCore::Document::updateLayout):
- (WebCore::Document::attach):
- (WebCore::Document::detach):
- (WebCore::Document::documentWillBecomeInactive):
- (WebCore::Document::documentDidBecomeActive):
+ This includes streaming operators for QWebHistory. for convenience.
-2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>
+ New autotests that test QWebHistory and QWebHistoryItem serialization.
- Reviewed by Tor Arne Vestbø.
-
- Added support for different ownership models for wrapped QObjects in
- the JavaScript environment.
-
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget): Specify
- QtOwnership for scriptable widgets.
- * bridge/npruntime_internal.h: Add "NormalState" to the list of
- undef'ed macros as an included Qt header uses "NormalState" as value
- in an enum.
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::QtInstance): Save and initialize ownership
- member.
- (JSC::Bindings::QtInstance::~QtInstance): Respect
- QScriptEngine::ValueOwnership policy with regards to wrapped m_object.
- (JSC::Bindings::QtInstance::getQtInstance): Pass the ownership down to
- the instance.
- * bridge/qt/qt_instance.h:
- (JSC::Bindings::QtInstance::create): Ditto.
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue): Use QtOwnership for
- automatically wrapped QObjects.
- (JSC::Bindings::QtConnectionObject::execute): Ditto.
-
-2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
-
- Reviewed by Dan Bernstein and Geoff Garen.
-
- - WebCore code to track per-day and per-week visit counts in history
-
- The basic idea is as follows: we track daily visits for up to 13
- days, and weekly visits for up to 5 weeks past the end of the
- current daily visits. As soon as the number of daily counts goes
- over 13, we squish them down into weeks, and then prune the excess weeks.
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace.
- (WebCore::timeToDay): Helper function: convert time to days from the epoch.
- (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if
- a site is visited after a span of days.
- (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade
- algorithm as described above.
- (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all
- info about a visit to this history item.
- (WebCore::HistoryItem::setLastVisitedTime): Updated.
- (WebCore::HistoryItem::visited): Updated.
- (WebCore::HistoryItem::recordInitialVisit): New function to
- handle recording data about the very first visit, replacing the
- prior practice of explicitly setting visit count to 1.
- (WebCore::HistoryItem::adoptVisitCounts): Take ownership of
- daily and weekly visit count vectors.
- (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment
- noting that this function doesn't work properly now (though
- this shouldn't matter much in practice.)
+ * WebCore.pro:
* history/HistoryItem.h:
- (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts.
- (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
- * WebCore.base.exp: Add new symbols and sort.
-
-2009-02-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6438271> Improve backspace handling of accented characters
-
- Test: platform/mac/editing/deleting/backward-delete.html
-
- This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
- because the current behavior matches their standards (tested on Windows, assumed elsewhere).
-
- * dom/Position.cpp:
- (WebCore::Position::previous):
- (WebCore::Position::next):
- (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
- * dom/Position.h:
- Added a new option for previous(), used to move to a next position for backward deletion.
- Renamed EUsingComposedCharacters to PositionMoveType.
-
- * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
- surrounding this code a little.
-
- * editing/htmlediting.cpp:
- (WebCore::nextVisuallyDistinctCandidate):
- (WebCore::previousVisuallyDistinctCandidate):
- Adjusted for renamed enum values.
-
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderText.h:
- Added previousOffsetForBackwardDeletion().
-
- * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
- On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
-
-2009-02-05 Adam Roben <aroben@apple.com>
-
- Fix a crash in RenderWidget::destroy when navigating away from a page
- with an <iframe>
-
- This was a regression caused by r40679
-
- Reviewed by Dave Hyatt.
-
- Tested by many many tests.
-
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we
- finish accessing its members.
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- getAnimatedStyleForRenderer() should not create a new
- CompositeAnimation if the object isn't already animating, and
- it should just fall back to returning renderer->style().
-
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Fix build when ACCELERATED_COMPOSITING is turned on.
-
- Give RenderLayerBacking some love after the great
- RenderBoxModelObject split.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateLayerTransform):
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- (WebCore::RenderLayerBacking::contentsBox):
- (WebCore::RenderLayerBacking::paintIntoLayer):
- (WebCore::RenderLayerBacking::startAnimation):
- (WebCore::RenderLayerBacking::startTransition):
- * rendering/RenderLayerBacking.h:
- (WebCore::RenderLayerBacking::renderer):
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Fix build when ACCELERATED_COMPOSITING is turned on.
-
- writeIndent() needs to be static to avoid warnings on some OSes,
- and remove unused CAToTransform3D() method.
-
- * platform/graphics/GraphicsLayer.cpp:
- (WebCore::writeIndent):
- * platform/graphics/mac/GraphicsLayerCA.mm:
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- Add some methods to the TransformOperation classes that are required
- by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.
-
- * platform/graphics/transforms/MatrixTransformOperation.h:
- (WebCore::MatrixTransformOperation::create):
- (WebCore::MatrixTransformOperation::MatrixTransformOperation):
- * platform/graphics/transforms/ScaleTransformOperation.h:
- (WebCore::ScaleTransformOperation::x):
- (WebCore::ScaleTransformOperation::y):
- * platform/graphics/transforms/TranslateTransformOperation.h:
- (WebCore::TranslateTransformOperation::x):
- (WebCore::TranslateTransformOperation::y):
+ (WebCore::HistoryItem::dailyVisitCounts):
+ (WebCore::HistoryItem::weeklyVisitCounts):
+ * history/qt/HistoryItemQt.cpp: Added.
+ (WebCore::HistoryItem::restoreState):
+ (WebCore::HistoryItem::saveState):
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
+2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
- Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
- and correct a usage of UNUSED_PARAM().
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::startAnimation):
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Fix build when ACCELERATED_COMPOSITING is turned on.
-
- animationOfPropertyIsAccelerated() needs to be public because
- it is called from AnimationController.
-
- * page/animation/AnimationBase.h:
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
- the build.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::updateCompositingLayers):
-
-2009-02-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix missing checked toRenderBlock casts.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::clearFloats):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::availableHeightUsing):
-
-2009-02-05 Sam Weinig <sam@webkit.org>
-
- Patch from Darin Adler.
- Reviewed by Sam Weinig.
-
- Fix case where we were casting to RenderView.
-
- No test case possible.
-
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
-
-2009-02-05 Aaron Boodman <aa@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23708
- Adds documentElementAvailable() callback to FrameLoaderClient.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::startElementNs):
- Add call to dispatchDocumentElementAvailable()
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseStartElement):
- Ditto.
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::insertNode):
- Ditto.
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::documentElementAvailable):
- Stub out documentElementAvailable().
- * loader/FrameLoader.cpp:
- documentElementAvailable() callback plumbing.
- * loader/FrameLoader.h:
- Ditto.
- * loader/FrameLoaderClient.h:
- Add new documentElementAvailable() callback.
-
-2009-02-05 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23766
- CanvasRenderingContext2D::setShadow needs else for other platforms.
-
- Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
- other platforms using the CMYK color constructor.
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setShadow):
-
-2009-02-05 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23687
- Wires up Skia'a ImageBuffer::toDataURL to support pngs.
- This helps Chromium pass a couple of layout tests.
-
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::toDataURL):
- * platform/image-encoders: Added.
- * platform/image-encoders/skia: Added.
- * platform/image-encoders/skia/PNGImageEncoder.cpp: Added.
- (WebCore::):
- (WebCore::PngEncoderState::EncoderWriteCallback):
- (WebCore::PngEncoderState::ConvertBGRAtoRGB):
- (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer):
- (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer):
- (WebCore::PNGImageEncoder::encode):
- * platform/image-encoders/skia/PNGImageEncoder.h: Added.
-
-2009-02-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
+ Reviewed by Simon Hausmann.
- Fix missing checked cast.
+ Add support for QDataStream operators to String and IntPoint.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containingBlock):
+ * platform/graphics/IntPoint.h:
+ (WebCore::operator<<):
+ (WebCore::operator>>):
+ * platform/text/PlatformString.h:
+ * platform/text/qt/StringQt.cpp:
+ (WebCore::operator<<):
+ (WebCore::operator>>):
-2009-02-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+2009-06-26 Ben Murdoch <benm@google.com>
- Not reviewed. Fix WML enabled builds.
+ Reviewed by Darin Fisher.
- FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.
+ Add #if ENABLE(DOM_STORAGE) to the V8 custom bindings for local/session storage.
+ https://bugs.webkit.org/show_bug.cgi?id=26757
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::executeTask):
+ * bindings/v8/custom/V8StorageCustom.cpp
-2009-02-05 Scott Violet <sky@google.com>
+2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=23625
- Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer
-
- Fixes three bugs in PlatformContextSkia:
-
- * When a new layer was started clipped to an image we used the
- assignment operator to copy the SkBitmap. If the SkBitmap owns it's
- pixels, this is not the right thing to do. Instead we need to create
- a copy of the image.
- * State holds an SkBitmap by value. State's copy constructor does a
- memcpy. This is confusing and subtle, I've converted to use a member
- initializer list which I think is clearer and less error prone.
- * When creating a new layer there is no need to copy the clip image.
-
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::State::State):
- (PlatformContextSkia::save):
- (PlatformContextSkia::beginLayerClippedToImage):
-
-2009-02-05 Scott Violet <sky@google.com>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=23462
- Changes call from setFillColor to setStrokeColor.
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
-
-2009-02-05 David Hyatt <hyatt@apple.com>
-
- Fix crash on svg custom stop test. A virtual function didn't get patched properly.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::clippedOverflowRectForRepaint):
- * rendering/RenderSVGGradientStop.h:
- (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
-
-2009-02-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23765
+ Test: platform/qt/fast/events/event-sender-keydown-frame.html
- Add toRenderBoxModelObject() so that we can cast objects that
- can have layers.
+ Bug 20303: [Qt] Key events are not working in frames.
- Fix getComputedStyle to return the current value of style
- properties that are undergoing accelerated animations, by
- asking the AnimationController if the property has accelerated
- animations, and, if so, asking it to generate an appropriate
- style.
+ Merge scrolling handling code in qt and win port, move it to
+ EventHandler.
- Tightened up some type safety (CSSPropertyID), and code clarity
- (replace bool with enum).
-
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::hasCompositedLayer):
- (WebCore::computedTransform):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
- (WebCore::AnimationController::isAnimatingPropertyOnRenderer):
- (WebCore::AnimationController::supportsAcceleratedAnimationOfProperty):
- * page/animation/AnimationController.h:
- * page/animation/AnimationControllerPrivate.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::startAnimation):
- (WebCore::ImplicitAnimation::endAnimation):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::startAnimation):
- (WebCore::KeyframeAnimation::endAnimation):
- * rendering/RenderBoxModelObject.h:
- (WebCore::RenderBoxModelObject::isBoxModelObject):
- (WebCore::toRenderBoxModelObject):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateLayerTransform):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isBoxModelObject):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::applyTransform):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::scrollRecursively):
+ * page/EventHandler.h:
-2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
+2009-06-26 Rob Buis <rwlbuis@gmail.com>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=23767
- Add custom V8 bindings for HTML5 database.
+ https://bugs.webkit.org/show_bug.cgi?id=26682
+ Bug 26682: It should be possible to add image to SVG DOM programmatically (using JavaScript)
- * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added.
- (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
- (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback):
- (WebCore::V8CustomSQLStatementCallback::handleEvent):
- * bindings/v8/custom/V8CustomSQLStatementCallback.h: Added.
- (WebCore::V8CustomSQLStatementCallback::create):
- * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added.
- (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
- (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback):
- (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added.
- (WebCore::V8CustomSQLStatementErrorCallback::create):
- * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added.
- (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
- (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback):
- (WebCore::V8CustomSQLTransactionCallback::handleEvent):
- * bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added.
- (WebCore::V8CustomSQLTransactionCallback::create):
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added.
- (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
- (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback):
- (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
- * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added.
- (WebCore::V8CustomSQLTransactionErrorCallback::create):
- * bindings/v8/custom/V8CustomVoidCallback.cpp: Added.
- (WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
- (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback):
- (WebCore::V8CustomVoidCallback::handleEvent):
- (WebCore::invokeCallback):
- * bindings/v8/custom/V8CustomVoidCallback.h: Added.
- (WebCore::V8CustomVoidCallback::create):
- * bindings/v8/custom/V8DatabaseCustom.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
- * bindings/v8/custom/V8SQLTransactionCustom.cpp: Added.
- (WebCore::CALLBACK_FUNC_DECL):
+ Make sure the xlink:href animated property setting syncs the corresponding attribute with the right namespace.
-2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
+ Test: svg/custom/createImageElement.svg
- Reviewed by Eric Seidel.
+ * svg/SVGAnimatedProperty.h:
+ (WebCore::synchronizeProperty):
- https://bugs.webkit.org/show_bug.cgi?id=23747
- Add Chromium threading-related files.
+2009-06-26 Takeshi Yoshino <tyoshino@google.com>
- * platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
+ Reviewed by Timothy Hatcher.
-2009-02-05 Sam Weinig <sam@webkit.org>
+ Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
+ https://bugs.webkit.org/show_bug.cgi?id=26156
- Reviewed by Adam Roben.
+ When in view-source mode, render the contents using HTMLViewSourceDocument
+ regardless it's applicable for any plugin or not.
- Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
- is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
- is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.
+ Chromium tells WebCore to render the contents of specified URL when
+ view-source: prefix is added to the URL. But currently, DOMImplementation
+ ignores inViewSourceMode() when the MIME type is indicating that the contents
+ are neither texts nor HTML family documents.
- * rendering/RenderButton.h:
- (WebCore::RenderButton::isRenderButton):
- (WebCore::toRenderButton):
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::paintObject):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isRenderButton):
+ For example, we can check the contents of asf file without launching media
+ player. Rendering contents for view-source:-specified input is not what user
+ expects.
-2009-02-05 David Hyatt <hyatt@apple.com>
+ http://code.google.com/p/chromium/issues/detail?id=10545
- Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
- of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
- In order to set the various RenderObject bits properly prior to the test for whether a layer is
- required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
- for setting all of the bits.
+ I want to fix this issue by this patch. IMHO, regardless of this Chromium
+ specific issue, I think we should force use of HTMLViewSourceDocument when
+ inViewSourceMode() is specified.
- Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
- RenderStyle, and just use the corresponding layer() methods for the
- staticX/Y getters/setters.
+ Test: fast/frames/viewsource-on-image-file.html
- Reviewed by Sam Weinig
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument):
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::createTokenizer):
+ * html/HTMLViewSourceDocument.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::adjustPositionedBlock):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- (WebCore::RenderBlock::layoutPositionedObjects):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::offsetForContents):
- (WebCore::RenderBlock::calcPrefWidths):
- (WebCore::RenderBlock::baselinePosition):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::RenderBox):
- (WebCore::RenderBox::destroy):
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::updateBoxModelInfoFromStyle):
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
- (WebCore::RenderBox::scrollLeft):
- (WebCore::RenderBox::scrollTop):
- (WebCore::RenderBox::setScrollLeft):
- (WebCore::RenderBox::setScrollTop):
- (WebCore::RenderBox::getOverflowClipRect):
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::absoluteToLocal):
- (WebCore::RenderBox::localToContainerQuad):
- (WebCore::RenderBox::position):
- (WebCore::RenderBox::computeRectForRepaint):
- (WebCore::RenderBox::calcAbsoluteHorizontal):
- (WebCore::RenderBox::calcAbsoluteVertical):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- * rendering/RenderBox.h:
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::RenderBoxModelObject):
- (WebCore::RenderBoxModelObject::destroy):
- (WebCore::RenderBoxModelObject::styleWillChange):
- (WebCore::RenderBoxModelObject::styleDidChange):
- (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
- * rendering/RenderBoxModelObject.h:
- (WebCore::RenderBoxModelObject::layer):
- (WebCore::RenderBoxModelObject::requiresLayer):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::updateBoxModelInfoFromStyle):
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::relativePositionedInlineOffset):
- * rendering/RenderInline.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::setStaticY):
- (WebCore::RenderLayer::updateLayerPosition):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setStyle):
- (WebCore::RenderObject::styleDidChange):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::markContainingBlocksForLayout):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::paint):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy):
- * rendering/bidi.cpp:
- (WebCore::appendRunsForObject):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::RenderBlock::skipTrailingWhitespace):
- (WebCore::RenderBlock::skipLeadingWhitespace):
- (WebCore::RenderBlock::findNextLineBreak):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::hasStaticX):
- (WebCore::InheritedFlags::hasStaticY):
-
-2009-02-05 Sam Weinig <sam@webkit.org>
-
- Fix the windows build.
-
- * bindings/scripts/CodeGeneratorCOM.pm:
- * dom/Node.idl:
+2009-06-26 Xan Lopez <xlopez@igalia.com>
-2009-02-05 Anders Carlsson <andersca@apple.com>
+ Reviewed by Jan Alonzo.
- Reviewed by Kevin Decker.
+ https://bugs.webkit.org/show_bug.cgi?id=25529
+ [Gtk] Expected states not exposed to assistive technologies
- Update to match Gecko.
+ Add support for VISIBLE, EDITABLE and SENSITIVE states.
- * bridge/npapi.h:
- * plugins/npfunctions.h:
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (setAtkStateSetFromCoreObject):
-2009-02-05 Sam Weinig <sam@webkit.org>
+2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
- Finish merging EventTargetNode up into Node.
+ "Pointer to incomplete class type is not allowed" error with RVCT
+ https://bugs.webkit.org/show_bug.cgi?id=26721
- This also fixes a small recently introduced issue where EventListeners
- would not be removed from the document if they were attached to comment
- nodes outside of the documentElement.
+ Based on Norbert Leser's work.
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSEventTargetNodeCustom.cpp: Removed.
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- (WebCore::JSNode::pushEventHandlerScope):
- * bindings/scripts/CodeGenerator.pm:
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::CharacterData):
- (WebCore::CharacterData::rendererIsNeeded):
- * dom/CharacterData.h:
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::willRemove):
- (WebCore::ContainerNode::attach):
- (WebCore::ContainerNode::detach):
- (WebCore::ContainerNode::insertedIntoDocument):
- (WebCore::ContainerNode::removedFromDocument):
- (WebCore::ContainerNode::setFocus):
- (WebCore::ContainerNode::setActive):
- (WebCore::ContainerNode::setHovered):
- (WebCore::dispatchChildInsertionEvents):
- (WebCore::dispatchChildRemovalEvents):
- * dom/ContainerNode.h:
- (WebCore::ContainerNode::ContainerNode):
* dom/Document.cpp:
- (WebCore::Document::removeAllEventListenersFromAllNodes):
- (WebCore::Document::removeAllDisconnectedNodeEventListeners):
(WebCore::Document::setFocusedNode):
- * dom/EventTargetNode.cpp: Removed.
- * dom/EventTargetNode.h: Removed.
* dom/Node.cpp:
- (WebCore::Node::scriptExecutionContext):
- (WebCore::Node::eventListeners):
- (WebCore::Node::insertedIntoDocument):
- (WebCore::Node::removedFromDocument):
- (WebCore::Node::willMoveToNewOwnerDocument):
- (WebCore::Node::didMoveToNewOwnerDocument):
- (WebCore::updateSVGElementInstancesAfterEventListenerChange):
- (WebCore::Node::addEventListener):
- (WebCore::Node::removeEventListener):
- (WebCore::Node::removeAllEventListenersSlowCase):
- (WebCore::Node::handleLocalEvents):
- (WebCore::eventTargetAsSVGElementInstance):
- (WebCore::eventTargetRespectingSVGTargetRules):
- (WebCore::Node::dispatchEvent):
- (WebCore::Node::dispatchGenericEvent):
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- (WebCore::Node::dispatchWindowEvent):
- (WebCore::Node::dispatchUIEvent):
- (WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
- (WebCore::Node::dispatchSimulatedMouseEvent):
- (WebCore::Node::dispatchSimulatedClick):
- (WebCore::Node::dispatchWheelEvent):
- (WebCore::Node::dispatchWebKitAnimationEvent):
- (WebCore::Node::dispatchWebKitTransitionEvent):
- (WebCore::Node::dispatchFocusEvent):
- (WebCore::Node::dispatchBlurEvent):
- (WebCore::Node::dispatchEventForType):
- (WebCore::Node::dispatchProgressEvent):
- (WebCore::Node::dispatchStorageEvent):
- (WebCore::Node::removeInlineEventListenerForType):
- (WebCore::Node::setInlineEventListenerForType):
- (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
- (WebCore::Node::inlineEventListenerForType):
- (WebCore::Node::disabled):
- (WebCore::Node::defaultEventHandler):
- (WebCore::Node::onabort):
- (WebCore::Node::setOnabort):
- (WebCore::Node::onblur):
- (WebCore::Node::setOnblur):
- (WebCore::Node::onchange):
- (WebCore::Node::setOnchange):
- (WebCore::Node::onclick):
- (WebCore::Node::setOnclick):
- (WebCore::Node::oncontextmenu):
- (WebCore::Node::setOncontextmenu):
- (WebCore::Node::ondblclick):
- (WebCore::Node::setOndblclick):
- (WebCore::Node::onerror):
- (WebCore::Node::setOnerror):
- (WebCore::Node::onfocus):
- (WebCore::Node::setOnfocus):
- (WebCore::Node::oninput):
- (WebCore::Node::setOninput):
- (WebCore::Node::onkeydown):
- (WebCore::Node::setOnkeydown):
- (WebCore::Node::onkeypress):
- (WebCore::Node::setOnkeypress):
- (WebCore::Node::onkeyup):
- (WebCore::Node::setOnkeyup):
- (WebCore::Node::onload):
- (WebCore::Node::setOnload):
- (WebCore::Node::onmousedown):
- (WebCore::Node::setOnmousedown):
- (WebCore::Node::onmousemove):
- (WebCore::Node::setOnmousemove):
- (WebCore::Node::onmouseout):
- (WebCore::Node::setOnmouseout):
- (WebCore::Node::onmouseover):
- (WebCore::Node::setOnmouseover):
- (WebCore::Node::onmouseup):
- (WebCore::Node::setOnmouseup):
- (WebCore::Node::onmousewheel):
- (WebCore::Node::setOnmousewheel):
- (WebCore::Node::onbeforecut):
- (WebCore::Node::setOnbeforecut):
- (WebCore::Node::oncut):
- (WebCore::Node::setOncut):
- (WebCore::Node::onbeforecopy):
- (WebCore::Node::setOnbeforecopy):
- (WebCore::Node::oncopy):
- (WebCore::Node::setOncopy):
- (WebCore::Node::onbeforepaste):
- (WebCore::Node::setOnbeforepaste):
- (WebCore::Node::onpaste):
- (WebCore::Node::setOnpaste):
- (WebCore::Node::ondragenter):
- (WebCore::Node::setOndragenter):
- (WebCore::Node::ondragover):
- (WebCore::Node::setOndragover):
- (WebCore::Node::ondragleave):
- (WebCore::Node::setOndragleave):
- (WebCore::Node::ondrop):
- (WebCore::Node::setOndrop):
- (WebCore::Node::ondragstart):
- (WebCore::Node::setOndragstart):
- (WebCore::Node::ondrag):
- (WebCore::Node::setOndrag):
- (WebCore::Node::ondragend):
- (WebCore::Node::setOndragend):
- (WebCore::Node::onreset):
- (WebCore::Node::setOnreset):
- (WebCore::Node::onresize):
- (WebCore::Node::setOnresize):
- (WebCore::Node::onscroll):
- (WebCore::Node::setOnscroll):
- (WebCore::Node::onsearch):
- (WebCore::Node::setOnsearch):
- (WebCore::Node::onselect):
- (WebCore::Node::setOnselect):
- (WebCore::Node::onselectstart):
- (WebCore::Node::setOnselectstart):
- (WebCore::Node::onsubmit):
- (WebCore::Node::setOnsubmit):
- (WebCore::Node::onunload):
- (WebCore::Node::setOnunload):
- * dom/Node.h:
- * editing/Editor.cpp:
- (WebCore::Editor::dispatchCPPEvent):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::handleLocalEvents):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished):
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchDragEvent):
- (WebCore::EventHandler::updateMouseEventTargetNode):
- (WebCore::EventHandler::dispatchMouseEvent):
- (WebCore::EventHandler::handleWheelEvent):
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- (WebCore::eventTargetNodeForDocument):
- (WebCore::EventHandler::keyEvent):
- * page/FrameView.cpp:
- (WebCore::FrameView::scheduleEvent):
- (WebCore::FrameView::updateOverflowStatus):
- * page/FrameView.h:
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollToOffset):
- (WebCore::RenderLayer::updateOverflowStatus):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::valueChanged):
- * rendering/RenderMedia.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::selectionChanged):
- * svg/SVGElementInstance.h:
- (WebCore::SVGElementInstance::toNode):
- * xml/XPathExpression.cpp:
- (WebCore::XPathExpression::evaluate):
- * xml/XPathResult.cpp:
- (WebCore::XPathResult::XPathResult):
-
-2009-02-05 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build now that EventTargetNode.idl was removed in r40672.
+ * dom/Node.h: Remove the default value for PassRefPtr<Event> args,
+ to eliminate dependency on the Event class definition
- * WebCore.pro:
-
-2009-02-05 Scott Violet <sky@google.com>
+2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
- Reviewed by Sam Weinig.
-
- Bug 23462: Add RGB -> CMYK conversion algorithm
- <https://bugs.webkit.org/show_bug.cgi?id=23462>
-
- Adds an RGB -> CMYK converter. This isn't perfect, but better than
- nothing.
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
- (WebCore::CanvasStyle::cmykToRGB):
- * html/CanvasStyle.h:
-
-2009-02-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- First stage of merging EventTargetNode up into Node. The intent of this change
- is to both simplify the inheritance hierarchy (at the same time making it more
- closely match the spec which states that all Nodes are EventTargets) and save
- 4 bytes per Node that the polymorphic multiple-inheritance was costing us.
-
- This does the bare minimum to get things compiling, the next patch will clean
-
- * DerivedSources.make:
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::mark):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventTarget.cpp:
- (WebCore::toEventTarget):
- * bindings/js/JSEventTarget.h:
- * bindings/js/JSEventTargetNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- (WebCore::JSNode::pushEventHandlerScope):
- * bindings/js/JSStyleSheetCustom.cpp:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bindings/scripts/CodeGeneratorObjC.pm:
- * dom/Attr.idl:
- * dom/CharacterData.h:
- * dom/CharacterData.idl:
- * dom/Document.idl:
- * dom/DocumentFragment.idl:
- * dom/Element.idl:
- * dom/EventTarget.cpp:
- (WebCore::EventTarget::toNode):
- * dom/EventTarget.h:
- * dom/EventTarget.idl:
- * dom/EventTargetNode.cpp:
- (WebCore::Node::scriptExecutionContext):
- (WebCore::Node::eventListeners):
- (WebCore::Node::insertedIntoDocument):
- (WebCore::Node::removedFromDocument):
- (WebCore::Node::willMoveToNewOwnerDocument):
- (WebCore::Node::didMoveToNewOwnerDocument):
- (WebCore::Node::addEventListener):
- (WebCore::Node::removeEventListener):
- (WebCore::Node::removeAllEventListenersSlowCase):
- (WebCore::Node::handleLocalEvents):
- (WebCore::Node::dispatchEvent):
- (WebCore::Node::dispatchGenericEvent):
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- (WebCore::Node::dispatchWindowEvent):
- (WebCore::Node::dispatchUIEvent):
- (WebCore::Node::dispatchKeyEvent):
- (WebCore::Node::dispatchMouseEvent):
- (WebCore::Node::dispatchSimulatedMouseEvent):
- (WebCore::Node::dispatchSimulatedClick):
- (WebCore::Node::dispatchWheelEvent):
- (WebCore::Node::dispatchWebKitAnimationEvent):
- (WebCore::Node::dispatchWebKitTransitionEvent):
- (WebCore::Node::dispatchFocusEvent):
- (WebCore::Node::dispatchBlurEvent):
- (WebCore::Node::dispatchEventForType):
- (WebCore::Node::dispatchProgressEvent):
- (WebCore::Node::dispatchStorageEvent):
- (WebCore::Node::removeInlineEventListenerForType):
- (WebCore::Node::setInlineEventListenerForType):
- (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
- (WebCore::Node::inlineEventListenerForType):
- (WebCore::Node::disabled):
- (WebCore::Node::defaultEventHandler):
- (WebCore::Node::onabort):
- (WebCore::Node::setOnabort):
- (WebCore::Node::onblur):
- (WebCore::Node::setOnblur):
- (WebCore::Node::onchange):
- (WebCore::Node::setOnchange):
- (WebCore::Node::onclick):
- (WebCore::Node::setOnclick):
- (WebCore::Node::oncontextmenu):
- (WebCore::Node::setOncontextmenu):
- (WebCore::Node::ondblclick):
- (WebCore::Node::setOndblclick):
- (WebCore::Node::onerror):
- (WebCore::Node::setOnerror):
- (WebCore::Node::onfocus):
- (WebCore::Node::setOnfocus):
- (WebCore::Node::oninput):
- (WebCore::Node::setOninput):
- (WebCore::Node::onkeydown):
- (WebCore::Node::setOnkeydown):
- (WebCore::Node::onkeypress):
- (WebCore::Node::setOnkeypress):
- (WebCore::Node::onkeyup):
- (WebCore::Node::setOnkeyup):
- (WebCore::Node::onload):
- (WebCore::Node::setOnload):
- (WebCore::Node::onmousedown):
- (WebCore::Node::setOnmousedown):
- (WebCore::Node::onmousemove):
- (WebCore::Node::setOnmousemove):
- (WebCore::Node::onmouseout):
- (WebCore::Node::setOnmouseout):
- (WebCore::Node::onmouseover):
- (WebCore::Node::setOnmouseover):
- (WebCore::Node::onmouseup):
- (WebCore::Node::setOnmouseup):
- (WebCore::Node::onmousewheel):
- (WebCore::Node::setOnmousewheel):
- (WebCore::Node::onbeforecut):
- (WebCore::Node::setOnbeforecut):
- (WebCore::Node::oncut):
- (WebCore::Node::setOncut):
- (WebCore::Node::onbeforecopy):
- (WebCore::Node::setOnbeforecopy):
- (WebCore::Node::oncopy):
- (WebCore::Node::setOncopy):
- (WebCore::Node::onbeforepaste):
- (WebCore::Node::setOnbeforepaste):
- (WebCore::Node::onpaste):
- (WebCore::Node::setOnpaste):
- (WebCore::Node::ondragenter):
- (WebCore::Node::setOndragenter):
- (WebCore::Node::ondragover):
- (WebCore::Node::setOndragover):
- (WebCore::Node::ondragleave):
- (WebCore::Node::setOndragleave):
- (WebCore::Node::ondrop):
- (WebCore::Node::setOndrop):
- (WebCore::Node::ondragstart):
- (WebCore::Node::setOndragstart):
- (WebCore::Node::ondrag):
- (WebCore::Node::setOndrag):
- (WebCore::Node::ondragend):
- (WebCore::Node::setOndragend):
- (WebCore::Node::onreset):
- (WebCore::Node::setOnreset):
- (WebCore::Node::onresize):
- (WebCore::Node::setOnresize):
- (WebCore::Node::onscroll):
- (WebCore::Node::setOnscroll):
- (WebCore::Node::onsearch):
- (WebCore::Node::setOnsearch):
- (WebCore::Node::onselect):
- (WebCore::Node::setOnselect):
- (WebCore::Node::onselectstart):
- (WebCore::Node::setOnselectstart):
- (WebCore::Node::onsubmit):
- (WebCore::Node::setOnsubmit):
- (WebCore::Node::onunload):
- (WebCore::Node::setOnunload):
- * dom/EventTargetNode.h:
- (WebCore::toEventTargetNode):
- (WebCore::EventTargetNodeCast):
- * dom/EventTargetNode.idl: Removed.
- * dom/MouseEvent.cpp:
- (WebCore::MouseEvent::MouseEvent):
- (WebCore::MouseEvent::initMouseEvent):
- (WebCore::MouseEvent::toElement):
- (WebCore::MouseEvent::fromElement):
- * dom/MouseEvent.h:
- (WebCore::MouseEvent::create):
- (WebCore::MouseEvent::relatedTarget):
- * dom/Node.cpp:
- (WebCore::Node::~Node):
- * dom/Node.h:
- (WebCore::Node::isEventTargetNode):
- (WebCore::Node::toNode):
- (WebCore::Node::removeAllEventListeners):
- (WebCore::Node::refEventTarget):
- (WebCore::Node::derefEventTarget):
- * dom/Node.idl:
- * page/EventHandler.h:
- * page/FrameView.h:
- * xml/XPathResult.h:
- (WebCore::XPathResult::create):
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
- container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.
-
- All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
- or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
- properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
- under the right conditions.
-
- There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
- 0, this subtraction wasn't necessary. It has been removed.
-
- Reviewed by Adam Roben
-
- * page/animation/AnimationBase.cpp:
- * rendering/RenderBR.h:
- (WebCore::RenderBR::selectionRectForRepaint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::selectionGapRectsForRepaint):
- (WebCore::RenderBlock::rectWithOutlineForRepaint):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::selectionRectForRepaint):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::outlineBoundsForRepaint):
- (WebCore::RenderBox::localToContainerQuad):
- (WebCore::RenderBox::clippedOverflowRectForRepaint):
- (WebCore::RenderBox::computeRectForRepaint):
- * rendering/RenderBox.h:
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::relativePositionOffsetX):
- (WebCore::RenderBoxModelObject::relativePositionOffsetY):
- * rendering/RenderBoxModelObject.h:
- (WebCore::RenderBoxModelObject::relativePositionOffset):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::computeRectForRepaint):
- * rendering/RenderForeignObject.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- (WebCore::RenderInline::rectWithOutlineForRepaint):
- * rendering/RenderInline.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::setHasVisibleContent):
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::scrollToOffset):
- (WebCore::RenderLayer::scrollRectToVisible):
- (WebCore::resizerCornerRect):
- (WebCore::RenderLayer::scrollbarCornerPresent):
- (WebCore::RenderLayer::invalidateScrollbarRect):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::computeScrollDimensions):
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::isPointInResizeControl):
- (WebCore::RenderLayer::hitTestOverflowControls):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::localBoundingBox):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::renderer):
- (WebCore::RenderLayer::renderBox):
- (WebCore::RenderLayer::renderBoxX):
- (WebCore::RenderLayer::renderBoxY):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::selectionRectForRepaint):
- * rendering/RenderListMarker.h:
- * rendering/RenderMarquee.cpp:
- (WebCore::RenderMarquee::computePosition):
- (WebCore::RenderMarquee::timerFired):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containerForRepaint):
- (WebCore::RenderObject::repaintUsingContainer):
- (WebCore::RenderObject::repaint):
- (WebCore::RenderObject::repaintRectangle):
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- (WebCore::RenderObject::rectWithOutlineForRepaint):
- (WebCore::RenderObject::clippedOverflowRectForRepaint):
- (WebCore::RenderObject::computeRectForRepaint):
- (WebCore::RenderObject::localToContainerQuad):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::selectionRectForRepaint):
- (WebCore::RenderObject::outlineBoundsForRepaint):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::clippedOverflowRectForRepaint):
- (WebCore::RenderPath::outlineBoundsForRepaint):
- * rendering/RenderPath.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::selectionRectForRepaint):
- (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::selectionRectForRepaint):
- (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- * rendering/RenderSVGText.h:
- * rendering/RenderSelectionInfo.h:
- (WebCore::RenderSelectionInfoBase::repaintContainer):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- (WebCore::RenderTableCell::computeRectForRepaint):
- (WebCore::RenderTableCell::localToContainerQuad):
- * rendering/RenderTableCell.h:
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- * rendering/RenderTableCol.h:
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- * rendering/RenderTableRow.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::clippedOverflowRectForRepaint):
- (WebCore::RenderText::selectionRectForRepaint):
- * rendering/RenderText.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::write):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::localToContainerQuad):
- (WebCore::RenderView::computeRectForRepaint):
- * rendering/RenderView.h:
-
-2009-02-05 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix.
-
- * page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
-
-2009-02-05 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Alexey Proskuryakov.
- Landed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=23733
-
- Use a 2 arguments constructor for KURL to avoid ASSERT failure.
-
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
-
-2009-02-04 Feng Qian <feng@chromium.org>
-
- Reviewed by Darin Adler.
-
- Add Android-specific files to WebCore/editing directory.
- https://bugs.webkit.org/show_bug.cgi?id=23294
-
- * editing/android: Added.
- * editing/android/EditorAndroid.cpp: Added.
- (WebCore::Editor::newGeneralClipboard):
-
-2009-02-04 Dean Jackson <dino@apple.com>
-
- Reviewed by Darin Adler.
-
- Remove -webkit-animation-play-state
- The AnimationController still has the code to execute the property, but
- it is no longer parsed or recorded.
- https://bugs.webkit.org/show_bug.cgi?id=22907
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::parseAnimationProperty):
- * css/CSSParser.h:
- * css/CSSPropertyNames.in:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSStyleSelector.h:
- * platform/animation/Animation.h:
- * rendering/style/RenderStyleConstants.h:
-
-2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Darin Adler.
-
- Make sure we don't load on removing the media element from the document
- https://bugs.webkit.org/show_bug.cgi?id=22105
-
- Test: media/remove-from-document-no-load.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::removedFromDocument):
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
- now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
- derived from RenderBox for now.
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::RenderBox):
- (WebCore::RenderBox::destroy):
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::computeRectForRepaint):
- * rendering/RenderBox.h:
- * rendering/RenderBoxModelObject.cpp: Added.
- (WebCore::RenderBoxModelObject::RenderBoxModelObject):
- (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
- * rendering/RenderBoxModelObject.h: Added.
- * rendering/RenderObject.h:
-
-2009-02-04 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt
-
- Added accelerated animation support to AnimationController and friends. The primary
- changes are:
- * accelerated animations get their start time from the compositing engine, so we
- wait for a callback (notifyAnimationStarted()) in order to get the start time.
- * if software and accelerated animations start in the same cycle, they all need
- to use the same start time, which is that of the accelerated animations.
-
- Added AnimationControllerPrivate to preserve the encapsulation under
- AnimationController.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * page/animation/AnimationBase.cpp:
- (WebCore::PropertyWrapperBase::animationIsAccelerated):
- (WebCore::PropertyWrapperAcceleratedOpacity::PropertyWrapperAcceleratedOpacity):
- (WebCore::PropertyWrapperAcceleratedOpacity::animationIsAccelerated):
- (WebCore::PropertyWrapperAcceleratedOpacity::blend):
- (WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform):
- (WebCore::PropertyWrapperAcceleratedTransform::animationIsAccelerated):
- (WebCore::PropertyWrapperAcceleratedTransform::blend):
- (WebCore::ensurePropertyMap):
- (WebCore::AnimationBase::AnimationBase):
- (WebCore::AnimationBase::~AnimationBase):
- (WebCore::AnimationBase::blendProperties):
- (WebCore::AnimationBase::animationOfPropertyIsAccelerated):
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- (WebCore::AnimationBase::willNeedService):
- (WebCore::AnimationBase::getTimeToNextEvent):
- (WebCore::AnimationBase::goIntoEndingOrLoopingState):
- (WebCore::AnimationBase::beginAnimationUpdateTime):
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::onAnimationStartResponse):
- (WebCore::AnimationBase::getAnimatedStyle):
- (WebCore::AnimationBase::isAnimatingProperty):
- (WebCore::AnimationBase::endAnimation):
- (WebCore::AnimationBase::isFallbackAnimating):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
- (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
- (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
- (WebCore::AnimationControllerPrivate::animationTimerFired):
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
- (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
- (WebCore::AnimationControllerPrivate::styleAvailable):
- (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
- (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
- (WebCore::AnimationControllerPrivate::startTimeResponse):
- (WebCore::AnimationController::getAnimatedStyleForRenderer):
- (WebCore::AnimationController::notifyAnimationStarted):
- (WebCore::AnimationController::endAnimationUpdate):
- * page/animation/AnimationController.h:
- * page/animation/AnimationControllerPrivate.h: Added.
- (WebCore::AnimationControllerPrivate::hasAnimations):
- (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
- (WebCore::AnimationControllerPrivate::endAnimationUpdate):
- (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
- (WebCore::CompositeAnimationPrivate::animationControllerPriv):
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
- (WebCore::CompositeAnimationPrivate::animate):
- (WebCore::CompositeAnimationPrivate::getAnimatedStyle):
- (WebCore::CompositeAnimationPrivate::addToStartTimeResponseWaitList):
- (WebCore::CompositeAnimationPrivate::removeFromStartTimeResponseWaitList):
- (WebCore::CompositeAnimation::CompositeAnimation):
- (WebCore::CompositeAnimation::animationControllerPriv):
- (WebCore::CompositeAnimation::getAnimatedStyle):
- (WebCore::CompositeAnimation::addToStartTimeResponseWaitList):
- (WebCore::CompositeAnimation::removeFromStartTimeResponseWaitList):
- * page/animation/CompositeAnimation.h:
- (WebCore::CompositeAnimation::create):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::shouldSendEventForListener):
- (WebCore::ImplicitAnimation::animate):
- (WebCore::ImplicitAnimation::getAnimatedStyle):
- (WebCore::ImplicitAnimation::startAnimation):
- (WebCore::ImplicitAnimation::endAnimation):
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- (WebCore::ImplicitAnimation::willNeedService):
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
- (WebCore::KeyframeAnimation::animate):
- (WebCore::KeyframeAnimation::getAnimatedStyle):
- (WebCore::KeyframeAnimation::startAnimation):
- (WebCore::KeyframeAnimation::endAnimation):
- (WebCore::KeyframeAnimation::shouldSendEventForListener):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- (WebCore::KeyframeAnimation::willNeedService):
- * page/animation/KeyframeAnimation.h:
- * platform/graphics/GraphicsLayerClient.h:
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (-[WebAnimationDelegate animationDidStart:]):
- * rendering/RenderLayerBacking.h:
-
-2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
-
- Not reviewed, build fix.
-
- Remove duplicate definition of msSans in FontCache::alternateFamilyName.
-
- * platform/graphics/FontCache.cpp:
- (WebCore::alternateFamilyName):
-
-2009-02-04 Eric Seidel <eric@webkit.org>
-
- Reviewed by George Staikos.
-
- Reverse the meaning of the if check so that Android
- (dpad devices) do not scroll on focus and normal platforms do
- http://trac.webkit.org/changeset/40647
-
- This was caught by George Staikos, and I wrote the patch.
-
- * dom/Element.cpp:
- (WebCore::Element::updateFocusAppearance):
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- Eliminate RenderContainer.
+ Reviewed by Maciej Stachowiak.
- Reviewed by Sam and Anders
+ [Qt] Build fix after r45183
+ https://bugs.webkit.org/show_bug.cgi?id=26748
- * GNUmakefile.am:
* WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::RenderBlock):
- (WebCore::RenderBlock::destroy):
- (WebCore::RenderBlock::styleWillChange):
- (WebCore::RenderBlock::styleDidChange):
- (WebCore::RenderBlock::addChild):
- (WebCore::RenderBlock::dirtyLineBoxes):
- (WebCore::RenderBlock::createInlineBox):
- (WebCore::RenderBlock::removeChild):
- (WebCore::RenderBlock::setSelectionState):
- (WebCore::RenderBlock::avoidsFloats):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- (WebCore::RenderBlock::baselinePosition):
- (WebCore::RenderBlock::getBaselineOfFirstLineBox):
- (WebCore::RenderBlock::getBaselineOfLastLineBox):
- (WebCore::RenderBlock::rectWithOutlineForRepaint):
- (WebCore::RenderBlock::hoverAncestor):
- (WebCore::RenderBlock::updateDragState):
- (WebCore::RenderBlock::localCaretRect):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::virtualChildren):
- (WebCore::RenderBlock::children):
- * rendering/RenderContainer.cpp: Removed.
- * rendering/RenderContainer.h: Removed.
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::RenderFrameSet):
- (WebCore::RenderFrameSet::nodeAtPoint):
- (WebCore::RenderFrameSet::layout):
- * rendering/RenderFrameSet.h:
- (WebCore::RenderFrameSet::virtualChildren):
- (WebCore::RenderFrameSet::children):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::destroy):
- (WebCore::RenderInline::styleDidChange):
- (WebCore::nextContinuation):
- (WebCore::RenderInline::continuationBefore):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::splitFlow):
- (WebCore::RenderInline::addChildToContinuation):
- (WebCore::RenderInline::offsetLeft):
- (WebCore::RenderInline::offsetTop):
- (WebCore::RenderInline::positionForCoordinates):
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- (WebCore::RenderInline::rectWithOutlineForRepaint):
- (WebCore::RenderInline::updateDragState):
- (WebCore::RenderInline::childBecameNonInline):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::virtualChildren):
- (WebCore::RenderInline::children):
- (WebCore::RenderInline::continuation):
- (WebCore::RenderInline::setContinuation):
- * rendering/RenderLineBoxList.h:
- * rendering/RenderObject.h:
- * rendering/RenderObjectChildList.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::RenderSVGRoot):
- (WebCore::RenderSVGRoot::applyContentTransforms):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::absoluteTransform):
- (WebCore::RenderSVGRoot::nodeAtPoint):
- (WebCore::RenderSVGRoot::position):
- * rendering/RenderSVGRoot.h:
- (WebCore::RenderSVGRoot::virtualChildren):
- (WebCore::RenderSVGRoot::children):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- (WebCore::RenderTable::removeChild):
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::RenderTableCol):
- * rendering/RenderTableCol.h:
- (WebCore::RenderTableCol::virtualChildren):
- (WebCore::RenderTableCol::children):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::RenderTableRow):
- (WebCore::RenderTableRow::destroy):
- (WebCore::RenderTableRow::styleWillChange):
- (WebCore::RenderTableRow::addChild):
- * rendering/RenderTableRow.h:
- (WebCore::RenderTableRow::virtualChildren):
- (WebCore::RenderTableRow::children):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::RenderTableSection):
- (WebCore::RenderTableSection::destroy):
- (WebCore::RenderTableSection::addChild):
- (WebCore::RenderTableSection::removeChild):
- (WebCore::RenderTableSection::lowestPosition):
- (WebCore::RenderTableSection::rightmostPosition):
- (WebCore::RenderTableSection::leftmostPosition):
- * rendering/RenderTableSection.h:
- (WebCore::RenderTableSection::virtualChildren):
- (WebCore::RenderTableSection::children):
-
-2009-02-04 Mads Adger <mad@chromium.org>
-
- Reviewed by Antti Koivisto.
-
- Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
- https://bugs.webkit.org/show_bug.cgi?id=23180
-
- Added a protector for the document potentially holding on the last reference to the loader we are interating with.
-
- * loader/loader.cpp:
- (WebCore::Loader::Host::didFinishLoading):
- (WebCore::Loader::Host::didFail):
-
-2009-02-04 Cary Clark <caryclark@google.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23163
- Don't scroll to show current focus on devices that use
- directional pads for navigation.
- * dom/Element.cpp:
- (WebCore::Element::updateFocusAppearance):
-
-2009-02-04 Cary Clark <caryclark@google.com>
+2009-06-25 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
- Change RenderBlock::columnGap() access permissions from protected to
- public. ANDROID creates an array of focus rectangles for navigation
- with a trackball or directional pad, and needs access to the column gap
- to implement this logic.
-
- Android has no testing harness @ webkit.org, thus no tests.
-
- * rendering/RenderBlock.h:
-
-2009-02-04 Cary Clark <caryclark@google.com>
-
- Reviewed by Darin Adler and Eric Seidel.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917
-
- Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
- platform to select all when focusing on a textarea. This matches
- the user interface guidelines other applications on the platform.
-
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::updateFocusAppearance):
-
-2009-02-04 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6386112> Some inline-elements are not
- becoming proper dashboard-regions
-
- RenderInline needs its own implementation of addDashboardRegions
- because otherwise all of the coordinate calculations are
- inaccurate.
-
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::addDashboardRegions):
- * rendering/RenderInline.h:
- * rendering/RenderObject.h:
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- Move addChild/removeChild from RenderContainer to RenderObject.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderContainer.cpp:
- * rendering/RenderContainer.h:
- * rendering/RenderObject.cpp:
- (WebCore::updateListMarkerNumbers):
- (WebCore::RenderObject::addChild):
- (WebCore::RenderObject::removeChild):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::addChildIgnoringContinuation):
- * rendering/RenderSVGContainer.cpp:
- * rendering/RenderSVGContainer.h:
-
-2009-02-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by Sam Weinig
-
- <rdar://problem/3541409> - Further HistoryItem / BF cache cleanup
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrame::CachedFrame):
- (WebCore::CachedFrame::restore):
- * history/CachedFrame.h:
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::restore):
- * history/CachedPage.h:
- (WebCore::CachedPage::mainFrameView):
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem):
- (WebCore::HistoryItem::~HistoryItem):
- * history/HistoryItem.h:
- (WebCore::HistoryItem::isInPageCache):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::open):
-
-2009-02-04 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23743
- Fix memory corruption with open-source GIF decoders.
-
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::RGBA32Buffer::clear):
- * platform/image-decoders/gif/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoder::clearFrameBufferCache):
- * platform/image-decoders/skia/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoder::clearFrameBufferCache):
- (WebCore::GIFImageDecoder::initFrameBuffer):
- * platform/image-decoders/skia/ImageDecoder.h:
- (WebCore::RGBA32Buffer::clear):
-
-2009-02-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23360
-
- When using accelerated compositing, make repaints use the correct
- repaint container. Hook up the RenderLayerCompositor in RenderView,
- and add to RenderView a method that repaints both the view
- contents, and any intersecting composited layers.
-
- Make enclosingCompositingLayer() a method on RenderObject, and update
- the compositor to use that. Add a helper method on the compositor to
- get the non-self compositing ancestor: ancestorCompositingLayer().
-
- Call repaintRectangleInViewAndCompositedLayers() in places that don't do
- container-relative repainting: selection redraw on focus change, caret,
- and widget updates.
-
- Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
- would get cleared for partial updates, thus preventing subsequent full updates.
-
- Fix a bug in RenderLayer::ensureBacking() that made new backing every time.
-
- * WebCore.xcodeproj/project.pbxproj:
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::recomputeCaretRect):
- (WebCore::SelectionController::invalidateCaretRect):
- (WebCore::SelectionController::focusedOrActiveStateChanged):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::compositor):
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::removeChild):
- (WebCore::RenderLayer::ensureBacking):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::backing):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- (WebCore::RenderLayerBacking::paintIntoLayer):
- (WebCore::RenderLayerBacking::notifyTransitionStarted):
- (WebCore::RenderLayerBacking::notifyAnimationStarted):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateCompositingLayers):
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- (WebCore::RenderLayerCompositor::layerWillBeRemoved):
- (WebCore::RenderLayerCompositor::ancestorCompositingLayer):
- (WebCore::RenderLayerCompositor::clippedByAncestor):
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::enclosingCompositingLayer):
- (WebCore::RenderObject::containingBlockWidth):
- (WebCore::RenderObject::containingBlockHeight):
- (WebCore::RenderObject::containerForRepaint):
- (WebCore::RenderObject::repaintUsingContainer):
- * rendering/RenderObject.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::shouldRepaint):
- (WebCore::RenderView::repaintViewRectangle):
- (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
- (WebCore::RenderView::setMaximalOutlineSize):
- (WebCore::RenderView::usesCompositing):
- (WebCore::RenderView::compositor):
- (WebCore::RenderView::didMoveOnscreen):
- (WebCore::RenderView::willMoveOffscreen):
- * rendering/RenderView.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::updateWidgetPosition):
-
-2009-02-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
- is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
- is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::defaultEventHandler):
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::attach):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- (WebCore::HTMLImageElement::attach):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::attach):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::attach):
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::attach):
- * loader/ImageLoader.cpp:
- (WebCore::ImageLoader::setImage):
- (WebCore::ImageLoader::updateFromElement):
- (WebCore::ImageLoader::notifyFinished):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- (WebCore::AccessibilityRenderObject::addChildren):
- * page/DragController.cpp:
- (WebCore::getCachedImage):
- (WebCore::getImage):
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writeImage):
- * rendering/RenderImage.h:
- (WebCore::toRenderImage):
- * wml/WMLImageElement.cpp:
- (WebCore::WMLImageElement::parseMappedAttribute):
- (WebCore::WMLImageElement::attach):
-
-2009-02-04 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel and Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=20531
-
- Make alternateFamilyName customized for Windows and Chromium.
-
- * platform/graphics/FontCache.cpp:
- (WebCore::alternateFamilyName):
-
-2009-02-04 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- This comes from Chromium patch (http://codereview.chromium.org/17624).
-
- Add m_disableFontFallback to UniscriberHelper class and set it
- to true when filling up glyph pages for non-BMP code points.
- When it's set true, UniscriberHelper does not do its own font
- fallback. Neither does it do glyph placement. Font fallback
- will be taken care of in the simple script font path and glyph
- placement is not necessary for simple scripts.
-
- Layout test is missing at the moment due to the lack of freely
- distributable font covering a non-BMP code page. A test page
- is available at http://i18nl10n.com/webkit/nonbmp2.html
-
- See also https://bugs.webkit.org/show_bug.cgi?id=23602
-
- * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
- (WebCore::fillNonBMPGlyphs):
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::UniscribeHelper::UniscribeHelper):
- (WebCore::UniscribeHelper::shape):
- (WebCore::UniscribeHelper::fillShapes):
- * platform/graphics/chromium/UniscribeHelper.h:
- (WebCore::UniscribeHelper::setDisableFontFallback):
-
-2009-02-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Remove some unnecessary #includes of RenderStyle.h
-
- * css/CSSPrimitiveValueMappings.h:
- * css/SVGCSSComputedStyleDeclaration.cpp:
- * dom/Node.h:
- * rendering/PointerEventsHitRules.h:
- * rendering/RenderImageGeneratedContent.h:
- * rendering/RenderMarquee.h:
- * rendering/RenderScrollbar.h:
-
-2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23657
- Clean up WebCore/storage IDLs.
-
- * storage/SQLError.idl: Changed to match spec.
- * storage/SQLResultSet.idl: Changed to match spec.
- * storage/SQLStatementCallback.idl: Removed.
- * storage/SQLStatementErrorCallback.idl: Removed.
- * storage/SQLTransactionCallback.idl: Removed.
- * storage/SQLTransactionErrorCallback.idl: Removed.
-
-2009-02-04 David Hyatt <hyatt@apple.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26681
+ <rdar://problem/7003461> Problem updating applicationCache when server returns 304
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.
-
- Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
- during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
- paint.
-
- The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
- sure to do only a local setNeedsLayout inside that function.
-
- Reviewed by Beth Dakin
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isSetNeedsLayoutForbidden):
- (WebCore::RenderObject::setNeedsLayoutIsForbidden):
- (WebCore::RenderObject::setNeedsLayout):
- (WebCore::RenderObject::setChildNeedsLayout):
- (WebCore::RenderObject::markContainingBlocksForLayout):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::layout):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::calcRowHeight):
- (WebCore::RenderTableSection::layoutRows):
-
-2009-02-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Rename RenderStyle::Diff to StyleDifference and move it to
- RenderStyleConstants.h.
-
- * rendering/RenderBR.cpp:
- (WebCore::RenderBR::styleDidChange):
- * rendering/RenderBR.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleWillChange):
- (WebCore::RenderBlock::styleDidChange):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::styleDidChange):
- * rendering/RenderBox.h:
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::styleWillChange):
- (WebCore::RenderButton::styleDidChange):
- * rendering/RenderButton.h:
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::styleDidChange):
- * rendering/RenderFieldset.h:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::styleDidChange):
- * rendering/RenderFileUploadControl.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- * rendering/RenderInline.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::styleDidChange):
- * rendering/RenderListBox.h:
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::styleDidChange):
- * rendering/RenderListItem.h:
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::styleWillChange):
- (WebCore::RenderListMarker::styleDidChange):
- * rendering/RenderListMarker.h:
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::styleDidChange):
- * rendering/RenderMenuList.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setStyle):
- (WebCore::RenderObject::styleWillChange):
- (WebCore::RenderObject::styleDidChange):
- * rendering/RenderObject.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::styleDidChange):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGGradientStop.cpp:
- (WebCore::RenderSVGGradientStop::styleDidChange):
- * rendering/RenderSVGGradientStop.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::styleDidChange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::styleWillChange):
- (WebCore::RenderScrollbarPart::styleDidChange):
- * rendering/RenderScrollbarPart.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::styleDidChange):
- * rendering/RenderSlider.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::styleDidChange):
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::styleWillChange):
- (WebCore::RenderTableCell::styleDidChange):
- * rendering/RenderTableCell.h:
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::styleWillChange):
- * rendering/RenderTableRow.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::styleDidChange):
- * rendering/RenderText.h:
- (WebCore::RenderText::styleWillChange):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::styleDidChange):
- * rendering/RenderTextControl.h:
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- * rendering/RenderTextControlSingleLine.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::styleDidChange):
- * rendering/RenderWidget.h:
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
- (WebCore::RenderStyle::setClip):
- * rendering/style/RenderStyle.h:
- * rendering/style/RenderStyleConstants.h:
- (WebCore::):
-
-2009-02-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::matchRulesForList):
- (WebCore::CSSStyleSelector::initForStyleResolve):
- (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
- (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- (WebCore::CSSStyleSelector::styleForElement):
- (WebCore::CSSStyleSelector::pseudoStyleForElement):
- (WebCore::CSSStyleSelector::checkSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSStyleSelector.h:
- * dom/Node.cpp:
- (WebCore::Node::diff):
- * page/FrameView.cpp:
- (WebCore::FrameView::createScrollbar):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paint):
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
- (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement):
- (WebCore::MediaControlInputElement::MediaControlInputElement):
- (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
- (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
- (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
- (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
- (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
- * rendering/MediaControlElements.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleDidChange):
- (WebCore::RenderBlock::updateBeforeAfterContent):
- (WebCore::RenderBlock::firstLineBlock):
- (WebCore::RenderBlock::updateFirstLetter):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::isAfterContent):
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::updateBeforeAfterContent):
- * rendering/RenderButton.h:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::createButtonStyle):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- (WebCore::isAfterContent):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::splitInlines):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::updateScrollCornerStyle):
- (WebCore::RenderLayer::updateResizerStyle):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::createScrollbar):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createPanel):
- (WebCore::RenderMedia::createTimelineContainer):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::createScrollbar):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::selectionBackgroundColor):
- (WebCore::RenderObject::selectionForegroundColor):
- (WebCore::RenderObject::firstLineStyleSlowCase):
- (WebCore::RenderObject::getCachedPseudoStyle):
- (WebCore::RenderObject::getUncachedPseudoStyle):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isAnonymousBlock):
- * rendering/RenderObjectChildList.cpp:
- (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- (WebCore::beforeAfterContainer):
- (WebCore::RenderObjectChildList::invalidateCounters):
- (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- * rendering/RenderObjectChildList.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- (WebCore::pseudoForScrollbarPart):
- * rendering/RenderScrollbar.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::createThumbStyle):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
- (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- * rendering/style/RenderStyle.cpp:
- (WebCore::pseudoBit):
- * rendering/style/RenderStyle.h:
- (WebCore::):
- * rendering/style/RenderStyleConstants.h:
- (WebCore::):
-
-2009-02-04 David Kilzer <ddkilzer@apple.com>
-
- CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
-
- <rdar://problem/6509514>
-
- Reviewed by Mark Rowe.
+ Test: http/tests/appcache/update-cache.html
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Fix it correctly this time.
- Check for the value returned from WebCore::IconDatabase::iconForPageURL(),
- not WebCore::Image::data().
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):
+ We're already done with the resource, don't try to load it again.
-2009-02-04 David Hyatt <hyatt@apple.com>
+2009-06-25 Simon Fraser <simon.fraser@apple.com>
- Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6990481>
+
+ Handle perspective computation on non-layer objects.
- Reviewed by Adam Roben
+ Test: transforms/3d/general/perspective-non-layer.html
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
- (WebCore::RenderBox::styleWillChange):
- * rendering/RenderBox.h:
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::removeChild):
* rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
- * rendering/RenderObject.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::removeChild):
-
-2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23471
- Fix text-overflow:ellipsis; for RTL case.
-
- Test: fast/css/text-overflow-ellipses.html
-
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement.
- (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations
- for rtl truncation.
-
-2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23700
- Upstream local changes to due to unforking of SimpleFontData
- (corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).
-
- * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
- (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- <rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook
-
- Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
- because, like, they point to a lot of stuff... like ... everything...
-
- Reviewed by Darin Adler
-
- * dom/Document.cpp:
- (WebCore::Document::removeAllEventListenersFromAllNodes):
-
-2009-02-04 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23731
- Add JSCCustom and V8Custom as extended IDL attributes
-
- This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.
-
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/Document.idl:
- * dom/Node.idl:
- * svg/SVGPathSegList.idl:
- * svg/SVGPointList.idl:
- * svg/SVGTransformList.idl:
-
-2009-02-04 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * rendering/RenderImageGeneratedContent.h:
-
-2009-02-04 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
- with assigning to uninitialized HashTable buckets.
-
- https://bugs.webkit.org/show_bug.cgi?id=23669
-
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::getWxFont):
- * platform/graphics/wx/FontPlatformData.h:
- (WebCore::):
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::font):
- (WebCore::FontPlatformData::operator==):
- * platform/graphics/wx/FontPlatformDataWx.cpp:
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::computeHash):
- (WebCore::FontPlatformData::~FontPlatformData):
- * platform/graphics/wx/SimpleFontDataWx.cpp:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
- (WebCore::drawTextWithSpacing):
-
-2009-02-04 David Hyatt <hyatt@apple.com>
-
- Fix a crash in generated content when a generated image with an already-cached background image gets
- created. It's not completely clear how to reproduce this crash.
-
- Reviewed by Adam Roben
-
- * rendering/RenderImageGeneratedContent.h:
- (WebCore::RenderImageGeneratedContent::imagePtr):
-
-2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
-
- Unreviewed Qt build fix.
-
- Changed ASSERT(image) to ASSERT(!image.isNull()).
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::getImageData):
-
-2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix implementation of PluginViewMac::invalidateRect to update only the
- specified rect, not the entire browser window.
-
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::invalidateRect):
-
-2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Rubber stamped by Mark Rowe.
-
- FramePrivate was removed in r40024 remove the forward
- declaration as well.
-
- * page/Frame.h:
-
-2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23426
-
- Make isFrameSet virtual and by default return false. Reimplement
- it in HTMLDocument.
-
- * dom/Document.cpp:
- * dom/Document.h:
- (WebCore::Document::isFrameSet):
- * html/HTMLDocument.cpp:
- (WebCore::HTMLDocument::isFrameSet):
- * html/HTMLDocument.h:
-
-2009-02-03 Oliver Hunt <oliver@apple.com>
-
- Reviewed by John Sullivan.
-
- <rdar://problem/6554092> Slow script dialog starts coming up over and over again
-
- Work around <rdar://problem/6554067> by consuming any exceptions that are
- thrown by _web_localizedDescription
-
- * platform/network/mac/ResourceErrorMac.mm:
- (WebCore::ResourceError::platformLazyInit):
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
- versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
- functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
- availableWidth/Height.
-
- Reviewed by Mark Rowe
-
- * dom/Element.cpp:
- (WebCore::Element::clientWidth):
- (WebCore::Element::clientHeight):
- (WebCore::Element::scrollWidth):
- (WebCore::Element::scrollHeight):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::clientWidth):
- (WebCore::RenderBox::clientHeight):
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
+ (WebCore::RenderObject::getTransformFromContainer):
-2009-02-03 Brad Garcia <bgarcia@google.com>
+2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=20443
- Remove call to canResize when trying to determine if pointer
- is within a frame.
- Also removed the implementation of canResize as it is no longer used.
-
- Test: fast/frames/frame-dead-region.html
-
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::nodeAtPoint):
- * rendering/RenderFrameSet.h:
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
- This is a small gain on the PLT.
-
- Reviewed by Mark Rowe
-
- * rendering/bidi.cpp:
- (WebCore::inlineWidth):
- (WebCore::bidiNext):
-
-2009-02-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23628
-
- Fix selection repainting to do container-relative repaints. RenderView now
- repaints the selection using the containerForRepaint() for each RenderSelectionInfo.
- selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
-
- Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
- of RenderBlock.h and move them into RenderSelectionInfo.h, with some
- sharing and refactoring.
-
- RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderBR.h:
- (WebCore::RenderBR::selectionRectForRepaint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::selectionGapRectsForRepaint):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::selectionRectForRepaint):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::paint):
- (WebCore::RenderListMarker::selectionRectForRepaint):
- * rendering/RenderListMarker.h:
- * rendering/RenderObject.h:
- (WebCore::RenderObject::selectionRect):
- (WebCore::RenderObject::selectionRectForRepaint):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::selectionRectForRepaint):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::absoluteRects):
- (WebCore::RenderSVGInlineText::absoluteQuads):
- (WebCore::RenderSVGInlineText::selectionRectForRepaint):
- (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderSelectionInfo.h: Added.
- (WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
- (WebCore::RenderSelectionInfoBase::object):
- (WebCore::RenderSelectionInfoBase::repaintContainer):
- (WebCore::RenderSelectionInfoBase::state):
- (WebCore::RenderSelectionInfo::RenderSelectionInfo):
- (WebCore::RenderSelectionInfo::repaint):
- (WebCore::RenderSelectionInfo::rect):
- (WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
- (WebCore::RenderBlockSelectionInfo::repaint):
- (WebCore::RenderBlockSelectionInfo::block):
- (WebCore::RenderBlockSelectionInfo::rects):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::selectionRectForRepaint):
- * rendering/RenderText.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::selectionBounds):
- (WebCore::RenderView::setSelection):
- * rendering/RenderView.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint):
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
-
- Reviewed by Darin Adler & Sam Weinig
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- * css/CSSMutableStyleDeclaration.h:
-
-2009-02-03 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=13490
- Implement execCommand("styleWithCSS", ...)
-
- Determine whether or not to use HTML formatting tags for styling on the new
- boolean on Editor instead of whether or not the document is quirks mode.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::StyleChange::StyleChange):
- (WebCore::StyleChange::init):
- (WebCore::ApplyStyleCommand::applyBlockStyle):
- (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- * editing/Editor.cpp:
- (WebCore::Editor::Editor):
- (WebCore::Editor::clear):
- * editing/Editor.h:
- (WebCore::Editor::setShouldStyleWithCSS):
- (WebCore::Editor::shouldStyleWithCSS):
- * editing/EditorCommand.cpp:
- (WebCore::executeStyleWithCSS):
- (WebCore::stateStyleWithCSS):
- (WebCore::CommandEntry::):
-
-2009-02-03 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Sam Weinig.
-
- This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::getImageData):
-
-2009-02-03 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
-
- - Fix for <rdar://problem/6549743>
-
- On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
- after the call to -[NSView displayRectIgnoringOpacity:inContext:].
-
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::paint):
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Back this change out since it is causing layout tests to crash. There is something subtle going on
- here.
-
- Reviewed by Darin Adler
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- * css/CSSMutableStyleDeclaration.h:
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
-
- Reviewed by Sam Weinig
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- * css/CSSMutableStyleDeclaration.h:
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
- as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
- Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
-
- Reviewed by Darin Adler
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::addExtraFieldsToRequest):
- * platform/KURL.cpp:
- (WebCore::KURL::invalidate):
- (WebCore::KURL::KURL):
- * platform/KURL.h:
- (WebCore::KURL::isHTTPOrHTTPS):
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::setCachePolicy):
- (WebCore::ResourceRequestBase::setTimeoutInterval):
- (WebCore::ResourceRequestBase::setMainDocumentURL):
- (WebCore::ResourceRequestBase::setHTTPMethod):
- (WebCore::ResourceRequestBase::setHTTPHeaderField):
- (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- (WebCore::ResourceRequestBase::setHTTPBody):
- (WebCore::ResourceRequestBase::setAllowHTTPCookies):
-
-2009-02-03 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=23711
-
- Add manual test for floating divs with scrollbars.
-
- * manual-tests/gtk/floatingdiv.html: Added.
-
-2009-02-03 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=23711
-
- There's no need to hold an extra ref to the scrollbar, calling
- setPlatformWidget takes ownership of it.
-
- Also do not disconnect the signals when destroying the widget,
- it's superfluous.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::ScrollbarGtk):
- * platform/gtk/ScrollbarGtk.h:
-
-2009-02-03 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=23711
-
- Declare scrollBar as GtkWidget* to avoid needless
- casting.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::ScrollbarGtk):
- (ScrollbarGtk::~ScrollbarGtk):
-
-2009-02-03 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=23711
-
- Properly calculate the scrollbar location for their
- usage in RenderLayout.
-
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::frameRectsChanged):
-
-2009-02-03 David Hyatt <hyatt@apple.com>
-
- Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
- of these methods up to RenderObject.
-
- Reviewed by Beth Dakin
-
- * bindings/objc/DOM.mm:
- (-[DOMNode lineBoxRects]):
- * dom/Range.cpp:
- (WebCore::Range::addLineBoxRects):
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::drawNodeHighlight):
- * rendering/RenderContainer.cpp:
- * rendering/RenderContainer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteRectsForRange):
- (WebCore::RenderObject::absoluteQuadsForRange):
- * rendering/RenderObject.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::absoluteRectsForRange):
- (WebCore::RenderText::absoluteQuadsForRange):
- * rendering/RenderText.h:
-
-2009-02-03 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Sam Weinig and Oliver Hunt.
-
- Added getImageData() support for QtWebKit.
-
- [QT] lacks getImageData / putImageData support in Canvas
- https://bugs.webkit.org/show_bug.cgi?id=22186
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::getImageData):
-
-2009-02-03 Eric Roman <eroman@chromium.org>
-
- Reviewed by Holger Freyther.
-
- Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.
-
- * page/chromium/FrameChromium.cpp:
- (WebCore::computePageRectsForFrame):
-
-2009-02-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23358
-
- Hook accelerated compositing into RenderLayer.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::~RenderLayer):
- Init and clean up backing and the hasCompositingDescendant bit.
-
- (WebCore::RenderLayer::compositor):
- Shortcut to get to the RenderLayerCompositor.
-
- (WebCore::RenderLayer::updateLayerPositions):
- We need to let full repaints propagate to all compositing layers, and
- update the backing after layout here.
-
- (WebCore::RenderLayer::transparentAncestor):
- (WebCore::transparencyClipBox):
- (WebCore::RenderLayer::beginTransparencyLayers):
- Account for the fact that opacity may be rendered via the compositing
- layer sometimes.
-
- (WebCore::RenderLayer::addChild):
- (WebCore::RenderLayer::removeChild):
- (WebCore::RenderLayer::removeOnlyThisLayer):
- Tell the compositor when the RenderLayer hierarchy changes.
-
- (WebCore::RenderLayer::scrollToOffset):
- Update layer geometry after scrolling.
-
- (WebCore::RenderLayer::paintLayer):
- We short-circuit painting on composited layers, because these layers
- are painted on a callback from the compositing system.
-
- (WebCore::RenderLayer::hitTestLayer):
- Only apply transforms if we are rendering them in software.
-
- (WebCore::RenderLayer::localBoundingBox):
- (WebCore::RenderLayer::boundingBox):
- (WebCore::RenderLayer::absoluteBoundingBox):
- Refactor bounding box code that we can compute local, and ancestor-relative
- bounding box, as well as absolute.
-
- (WebCore::RenderLayer::ensureBacking):
- (WebCore::RenderLayer::clearBacking):
- RenderLayerBacking creation and destruction.
-
- (WebCore::RenderLayer::setParent):
- Tell the compositor when the RenderLayer hierarchy changes.
-
- (WebCore::RenderLayer::dirtyZOrderLists):
- (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
- (WebCore::RenderLayer::dirtyOverflowList):
- When the z-order and overflow lists change, we need to tell the
- compositor that the composited layers need to be rejiggered soon.
-
- (WebCore::RenderLayer::updateZOrderLists):
- Whitespace cleanup.
-
- (WebCore::RenderLayer::setBackingNeedsRepaint):
- (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
- Dirty composited layer contents for painting.
-
- (WebCore::RenderLayer::styleChanged):
- Update the layer backing after style changes.
-
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isComposited):
- (WebCore::RenderLayer::backing):
- Accessors for testing and getting the backing for this RenderLayer.
-
- (WebCore::RenderLayer::paintsWithTransparency):
- (WebCore::RenderLayer::paintsWithTransform):
- Transform and opacity can be applied via the compositing layer, or rendered
- in software. These methods tell us if we need to account for them in the
- non-compositing path.
-
- (WebCore::RenderLayer::hasCompositingDescendant):
- (WebCore::RenderLayer::setHasCompositingDescendant):
- Maintain a bit to tell if this layer has composited descendants.
-
-2009-02-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23365
-
- Hook up accelerated compositing layers the native
- view system on Mac.
-
- * WebCore.base.exp:
- Export new Page methods.
-
- * page/ChromeClient.h:
- (WebCore::ChromeClient::attachRootGraphicsLayer):
- (WebCore::ChromeClient::setNeedsOneShotDrawingSynchronization):
- New methods for attaching/detaching the root GraphicsLayer, and
- synchronizing layer changes with window drawing.
-
- * page/FrameView.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::updateCompositingLayers):
- (WebCore::FrameView::setNeedsOneShotDrawingSynchronization):
- (WebCore::FrameView::didMoveOnscreen):
- (WebCore::FrameView::willMoveOffscreen):
- New methods to update the compositing layer hierarchy,
- and pass-throughs to the RenderLayerCompositor.
-
- (WebCore::FrameView::layout):
- Update compositing layers after layout() and updateLayerPositions().
-
- * page/Page.cpp:
- (WebCore::Page::didMoveOnscreen):
- (WebCore::Page::willMoveOffscreen):
- * page/Page.h:
- New methods to allow the native view system to tell the Page when it
- starts to be presented on-screen, and when it will be hidden.
-
- * rendering/RenderLayerCompositor.h:
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- (WebCore::RenderLayerCompositor::didMoveOnscreen):
- (WebCore::RenderLayerCompositor::willMoveOffscreen):
- (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- Rename 'attached' methods to 'moveOnscreen/moveOffscreen' to match
- the calls through from Page, FrameView.
-
- (WebCore::RenderLayerCompositor::layerWillBeRemoved):
- Dont' try to repaint or update layers if the document is being torn
- down.
-
- * rendering/RenderView.cpp:
- (WebCore::RenderView::didMoveOnscreen):
- (WebCore::RenderView::willMoveOffscreen):
- * rendering/RenderView.h:
- New methods.
-
-2009-02-03 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Holger Hans Peter Freyther.
-
- Fixed getImageData and putImageData and respect pre-
- multiplied colors.
-
- Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
- https://bugs.webkit.org/show_bug.cgi?id=21575
-
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
-
-2009-02-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Brady Eidson.
-
- - fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
-
- Test: fast/history/window-open.html
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::createWindow): Pass the missing lockBackForwardList parameter
- to FrameLoader::changeLocation().
-
-2009-02-03 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build after r40536.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
-
-2009-02-03 Dan Bernstein <mitz@apple.com>
-
- - fix -Wmissing-prototypes builds
-
- * loader/WorkerThreadableLoader.cpp:
- (WebCore::workerContextDidSendData): Marked this function static.
- (WebCore::workerContextDidReceiveResponse): Ditto.
- (WebCore::workerContextDidReceiveData): Ditto.
- (WebCore::workerContextDidFinishLoading): Ditto.
- (WebCore::workerContextDidFail): Ditto.
- (WebCore::workerContextDidGetCancelled): Ditto.
- (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
-
-2009-02-03 David Kilzer <ddkilzer@apple.com>
-
- CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
-
- <rdar://problem/6509514>
-
- Reviewed by Adam Roben.
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Null check the value returned
- from WebCore::IconDatabase::iconForPageURL().
-
-2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix conversion of QByteArray to JavaScript and back. Instead of
- converting it to a String (data loss!) we now map it to JSByteArray.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::):
- (JSC::Bindings::valueRealType): Added JSByteArray as converstion type.
- (JSC::Bindings::convertValueToQVariant): Convert from JSByteArray to
- QVariant(QByteArray).
- (JSC::Bindings::convertQVariantToValue): Convert from
- QVariant::ByteArray to jsByteArray.
-
-2009-02-03 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix.
-
- * GNUmakefile.am: Removed WorkerTask.{h,cpp}.
-
-2009-02-03 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22718
- Implement WindowTimers interface in Workers.
-
- This patch moves timeoutID from Document to ScriptExecutionContext
- and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
- Also added a test for those methods.
-
- Test: fast/workers/worker-timeout.html
-
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::setTimeoutOrInterval):
- Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.
-
- (WebCore::JSWorkerContext::setTimeout):
- (WebCore::JSWorkerContext::clearTimeout):
- (WebCore::JSWorkerContext::setInterval):
- (WebCore::JSWorkerContext::clearInterval):
- Added methods exposed to JS.
-
- * dom/Document.cpp:
- * dom/Document.h:
- * dom/ScriptExecutionContext.cpp:
- (WebCore::ScriptExecutionContext::addTimeout):
- (WebCore::ScriptExecutionContext::removeTimeout):
- (WebCore::ScriptExecutionContext::findTimeout):
- * dom/ScriptExecutionContext.h:
- The timerID map moves from Document to ScriptExecutionContext,
- to be available to Document and to WorkerContext.
-
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout.
- (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
- * dom/WorkerContext.h:
-
- * page/DOMTimer.cpp:
- (WebCore::DOMTimer::DOMTimer):
- (WebCore::DOMTimer::~DOMTimer):
- (WebCore::DOMTimer::removeById):
- Code change here reflects move of timeoutID map to the ScriptExecutionContext.
- Some checks and casts are no longer needed.
-
-2009-02-03 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23560
- Implement SharedTimer for Workers.
-
- * dom/WorkerRunLoop.cpp:
- Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads.
- (WebCore::WorkerSharedTimer::WorkerSharedTimer):
- (WebCore::WorkerSharedTimer::setFiredFunction):
- (WebCore::WorkerSharedTimer::setFireTime):
- (WebCore::WorkerSharedTimer::stop):
- (WebCore::WorkerSharedTimer::isActive):
- (WebCore::WorkerSharedTimer::fireTime):
- (WebCore::WorkerSharedTimer::fire):
- (WebCore::WorkerRunLoop::WorkerRunLoop):
- Initializes a WorkerSharedTimer instance.
- (WebCore::WorkerRunLoop::~WorkerRunLoop):
- The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer.
- (WebCore::WorkerRunLoop::run):
- Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
- * dom/WorkerRunLoop.h:
- Add member of type OwnPtr<WorkerSharedTimer>
-
-2009-02-03 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-02-03 Alexey Proskuryakov <ap@webkit.org>
-
- Windows build fix.
-
- * dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where
- appropriate.
-
-2009-02-02 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
- <https://bugs.webkit.org/show_bug.cgi?id=23636>
-
- Enable the async portion of ThreadableLoader for workers.
-
- No observable change in behavior, so no test.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/CrossThreadCopier.h:
- * dom/GenericWorkerTask.h:
- * dom/WorkerThread.cpp:
- * loader/ThreadableLoader.cpp:
- (WebCore::ThreadableLoader::create):
- * loader/ThreadableLoaderClient.h:
- (WebCore::ThreadableLoaderClient::didFinishLoading):
- * loader/ThreadableLoaderClientWrapper.h: Added.
- (WebCore::ThreadableLoaderClientWrapper::create):
- (WebCore::ThreadableLoaderClientWrapper::clearClient):
- (WebCore::ThreadableLoaderClientWrapper::didSendData):
- (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
- (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
- (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
- (WebCore::ThreadableLoaderClientWrapper::didFail):
- (WebCore::ThreadableLoaderClientWrapper::didGetCancelled):
- (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
- (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
- * loader/WorkerThreadableLoader.cpp: Added.
- (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
- (WebCore::WorkerThreadableLoader::~WorkerThreadableLoader):
- (WebCore::WorkerThreadableLoader::cancel):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::clearClientWrapper):
- (WebCore::workerContextDidSendData):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
- (WebCore::workerContextDidReceiveResponse):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
- (WebCore::workerContextDidReceiveData):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
- (WebCore::workerContextDidFinishLoading):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
- (WebCore::workerContextDidFail):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
- (WebCore::workerContextDidGetCancelled):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didGetCancelled):
- (WebCore::workerContextDidReceiveAuthenticationCancellation):
- (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
- * loader/WorkerThreadableLoader.h: Added.
- (WebCore::WorkerThreadableLoader::create):
- (WebCore::WorkerThreadableLoader::refThreadableLoader):
- (WebCore::WorkerThreadableLoader::derefThreadableLoader):
-
-2009-02-02 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
+ https://bugs.webkit.org/show_bug.cgi?id=26653
- Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
- <https://bugs.webkit.org/show_bug.cgi?id=23636>
+ Use flex box in the mediaControls.css style, to nicely scale if a button gets
+ dynamically added or removed.
- No observable change in behavior, so no test.
+ Media tests results are affected by this changes.
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Worker.cpp:
- * dom/Worker.h:
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::addMessage):
- (WebCore::WorkerContext::postTask):
- (WebCore::WorkerContext::postTaskToWorkerObject):
- * dom/WorkerContext.h:
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerContextTask::performTask):
- (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
- Expose postTaskToWorkerContext for use by the worker object thread.
-
- (WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
- Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
- with postMessageToWorkerObject.
-
- * dom/WorkerMessagingProxy.h:
- * dom/WorkerRunLoop.cpp:
- (WebCore::WorkerRunLoop::run):
- (WebCore::WorkerRunLoop::postTask):
- * dom/WorkerRunLoop.h:
- * dom/WorkerTask.cpp: Removed.
- * dom/WorkerTask.h: Removed.
- Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.
-
- The resulted in the class going away along with an adapter that made
- a ScriptExecutionContext::Task look like a WorkerTask.
-
- * dom/WorkerThread.cpp:
- * dom/WorkerThread.h:
-
-2009-02-02 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23618: Templated worker tasks should be more error proof to use.
- <https://bugs.webkit.org/show_bug.cgi?id=23618>
-
- Add the generic worker tasks templates needed for the WorkerThreadableLoader.
-
- No observable change in behavior, so no test.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/CrossThreadCopier.cpp: Added.
- * dom/CrossThreadCopier.h: Added.
- (WebCore::CrossThreadCopierPassThrough::copy):
- * dom/GenericWorkerTask.h:
- Stop doing the WorkerMessagingProxy::askedToTerminate call automatically
- in performTask because was not obvious that it would be done and not always needed.
-
- (WebCore::GenericWorkerTask1::create):
- (WebCore::GenericWorkerTask1::GenericWorkerTask1):
- (WebCore::GenericWorkerTask1::performTask):
- (WebCore::GenericWorkerTask2::create):
- (WebCore::GenericWorkerTask2::GenericWorkerTask2):
- (WebCore::GenericWorkerTask2::performTask):
- (WebCore::GenericWorkerTask3::create):
- (WebCore::GenericWorkerTask3::GenericWorkerTask3):
- (WebCore::GenericWorkerTask3::performTask):
- (WebCore::GenericWorkerTask4::create):
- (WebCore::GenericWorkerTask4::GenericWorkerTask4):
- (WebCore::GenericWorkerTask4::performTask):
- (WebCore::GenericWorkerTask5::create):
- (WebCore::GenericWorkerTask5::GenericWorkerTask5):
- (WebCore::GenericWorkerTask5::performTask):
- (WebCore::GenericWorkerTask6::create):
- (WebCore::GenericWorkerTask6::GenericWorkerTask6):
- (WebCore::GenericWorkerTask6::performTask):
- (WebCore::GenericWorkerTask7::create):
- (WebCore::GenericWorkerTask7::GenericWorkerTask7):
- (WebCore::GenericWorkerTask7::performTask):
- (WebCore::createCallbackTask):
- * dom/WorkerContext.cpp:
- (WebCore::addMessageTask):
- (WebCore::WorkerContext::addMessage):
- * dom/WorkerMessagingProxy.h:
- (WebCore::WorkerMessagingProxy::askedToTerminate):
-
-2009-02-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by David "The Barnabas Jones" Hyatt.
-
- Move removeChildNode, appendChildNode and insertChildNode from
- RenderContainer into RenderObjectChildList. Make moveChildNode
- static in RenderBlock, as that was the only user.
-
- * rendering/RenderBlock.cpp:
- (WebCore::moveChild):
- (WebCore::RenderBlock::makeChildrenNonInline):
- (WebCore::RenderBlock::removeChild):
- (WebCore::RenderBlock::handleRunInChild):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addChild):
- (WebCore::RenderContainer::removeChild):
- * rendering/RenderContainer.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::splitFlow):
- (WebCore::RenderInline::childBecameNonInline):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::handleDynamicFloatPositionChange):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::createsAnonymousWrapper):
- * rendering/RenderObjectChildList.cpp:
- (WebCore::updateListMarkerNumbers):
- (WebCore::RenderObjectChildList::removeChildNode):
- (WebCore::RenderObjectChildList::appendChildNode):
- (WebCore::RenderObjectChildList::insertChildNode):
- * rendering/RenderObjectChildList.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::addChild):
- (WebCore::RenderSVGContainer::removeChild):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::removeChild):
- * rendering/RenderTable.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::removeChild):
- * rendering/RenderTableSection.h:
-
-2009-02-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Alder.
-
- https://bugs.webkit.org/show_bug.cgi?id=23697
- Leaks seen on Worker tests
-
- * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
- Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed()
- is called.
-
-2009-02-02 David Hyatt <hyatt@apple.com>
-
- Move positionForCoordinates up from RenderContainer into RenderBox.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::positionForCoordinates):
- * rendering/RenderBox.h:
- * rendering/RenderContainer.cpp:
- * rendering/RenderContainer.h:
-
-2009-02-02 Hiroaki Nakamura <hnakamur@gmail.com>
-
- Reviewed by Adam Roben.
-
- Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
- Modify pre-build step to properly handle the errorlevel
- shell command.
-
- * WebCore.vcproj/WebCore.vcproj: Change errorlevel handling
- for all targets so prefast is only enabled in builds
- where /analyze is available.
-
-2009-02-02 David Hyatt <hyatt@apple.com>
-
- Refactor the handling of before/after content and generated content. Move most of the functions from
- RenderContainer into RenderObjectChildList.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::updateBeforeAfterContent):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::isAfterContent):
- * rendering/RenderBox.h:
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::updateBeforeAfterContent):
- * rendering/RenderContainer.cpp:
- * rendering/RenderContainer.h:
- * rendering/RenderCounter.cpp:
- (WebCore::destroyCounterNodeChildren):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::splitInlines):
- * rendering/RenderObject.h:
- * rendering/RenderObjectChildList.cpp:
- (WebCore::beforeAfterContainer):
- (WebCore::findBeforeAfterParent):
- (WebCore::invalidateCountersInContainer):
- (WebCore::RenderObjectChildList::invalidateCounters):
- (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- * rendering/RenderObjectChildList.h:
-
-2009-02-02 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23661
- Fix Chromium build.
-
- * history/HistoryItem.h: need to include <wtf/OwnPtr.h>
-
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
-
-2009-02-02 Geoffrey Garen <ggaren@apple.com>
-
- Build fix.
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::performRequest):
-
-2009-02-02 Geoffrey Garen <ggaren@apple.com>
+ * css/mediaControls.css:
+ * css/mediaControlsQT.css:
- Build fix.
-
- * WebCore.base.exp:
-
-2009-02-02 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Track redirects in global history.
-
- * WebCore.base.exp: Renamed some exports.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::createWindow):
- (windowProtoFuncOpen):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::setLocation):
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::submit):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::setProtocol):
- (WebCore::JSLocation::setHost):
- (WebCore::JSLocation::setHostname):
- (WebCore::JSLocation::setPort):
- (WebCore::JSLocation::setPathname):
- (WebCore::JSLocation::setSearch):
- (WebCore::JSLocation::setHash):
- (WebCore::JSLocation::assign): Treat any navigation that is not initiated
- by the user as a redirect from the perspective of global history.
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
- chain.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::DocumentLoader):
- * loader/DocumentLoader.h:
- (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
- (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
- (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
- added yet another way to track redirect state during loading, since none
- of the others did what I wanted, and I didn't want to cause behavior
- changes in existing code.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
- Stubbed out a client function to keep things building.
-
- * loader/FrameLoader.cpp:
- (WebCore::isBackForwardLoadType):
- (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
- FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
- the other meanings of "redirect" in the loading code.
-
- (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
- redirect as a redirect from the perspective of global history.
-
- (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
- parameter.
-
- (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
-
- (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
- (WebCore::FrameLoader::loadURL):
- (WebCore::FrameLoader::load): Updated for rename and extra parameter.
-
- (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
- in the DocumentLoader, so it's accessible to WebKit's global history code.
-
- (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
- only has meaning to global history, and m_quickRedirectComing pertains
- to other kinds of history.
-
- (WebCore::FrameLoader::loadPostRequest):
- (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
- (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
- (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
+2009-06-25 Albert J. Wong <ajwong@chromium.org>
- (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
- navigations even if they don't create new history items, so we can track
- the redirect in the existing history item.
-
- * loader/FrameLoader.h: See above.
-
- * loader/FrameLoaderClient.h: New client interface used by
- FrameLoader::updateHistory* to record a redirect even if it doesn't create
- a new history item of its own.
-
- * loader/FrameLoaderTypes.h: See above.
- (WebCore::):
-
- * page/DragController.cpp:
- (WebCore::DragController::performDrag):
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::dataChanged): Updated for extra parameter.
-
-2009-02-02 David Hyatt <hyatt@apple.com>
-
- Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
- Remove RenderSVGContainer's implementation, since it was never called.
-
- Reviewed by Beth Dakin
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::minPrefWidth):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::calcPrefWidths):
- * rendering/RenderContainer.h:
- (WebCore::RenderContainer::moveChildNode):
- * rendering/RenderSVGContainer.h:
-
-2009-02-02 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.
-
- * WebCore.LP64.exp:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createScriptObjectForPluginElement):
- (WebCore::ScriptController::jsObjectForPluginElement):
- * bindings/js/ScriptController.h:
-
-2009-02-02 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel (and Ojan Vafai).
-
- https://bugs.webkit.org/show_bug.cgi?id=23696
- Select element doesn't show new value when focus is switched in
- onchange event.
-
- Fix PopupMenuChromium to hide itself before calling valueChanged. This
- better matches the behavior of the other ports.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::create):
- (WebCore::PopupContainer::PopupContainer):
- (WebCore::PopupContainer::showPopup):
- (WebCore::PopupContainer::hidePopup):
- (WebCore::PopupListBox::abandon):
- (WebCore::PopupListBox::acceptIndex):
- (WebCore::PopupMenu::show):
- (WebCore::PopupMenu::hide):
-
-2009-02-02 David Hyatt <hyatt@apple.com>
-
- Make sure scrollWidth/Height just return 0 for inline flows.
-
- Reviewed by Beth Dakin
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
- https://bugs.webkit.org/show_bug.cgi?id=23676
-
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::cssPropertyName):
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
- * css/CSSStyleDeclaration.cpp:
- (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::sortMatchedRules):
- * dom/Document.cpp:
- (WebCore::Document::formElementsState):
- * dom/NamedAttrMap.h:
- (WebCore::NamedAttrMap::reserveInitialCapacity):
- * editing/TextIterator.cpp:
- (WebCore::CharacterIterator::string):
- (WebCore::SearchBuffer::SearchBuffer):
- (WebCore::plainTextToMallocAllocatedBuffer):
- * editing/markup.cpp:
- (WebCore::joinMarkups):
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem):
- * html/HTMLTokenizer.cpp:
- (WebCore::Token::addAttribute):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::items):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::toString):
- * page/mac/AccessibilityObjectWrapper.mm:
- (convertToVector):
- * platform/graphics/FontCache.cpp:
- (WebCore::FontCache::purgeInactiveFontData):
- (WebCore::FontCache::invalidate):
- * platform/network/FormData.cpp:
- (WebCore::FormData::deepCopy):
- * platform/network/HTTPHeaderMap.cpp:
- (WebCore::HTTPHeaderMap::copyData):
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::copyData):
- * platform/network/mac/FormDataStreamMac.mm:
- (WebCore::formCreate):
- * xml/XPathNodeSet.cpp:
- (WebCore::XPath::NodeSet::sort):
- Use reserveInitialCapacity instead of of reserveCapacity in all these call sites,
- which are working on new vectors that are guaranteed not to be empty.
-
-2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>
-
- Build fix after r40486.
-
- Rubber-stamped by Ada Chan.
-
- * dom/Document.h: Changed HitTestRequest to a class from a struct.
- * page/EventHandler.h: Ditto.
- * rendering/EllipsisBox.h: Ditto.
- * rendering/InlineBox.h: Ditto.
- * rendering/InlineFlowBox.h: Ditto.
- * rendering/RenderLayer.h: Ditto.
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
- https://bugs.webkit.org/show_bug.cgi?id=23694
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode.
- (WebCore::ContainerNode::removedFromDocument): Ditto.
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node.
- (WebCore::EventTargetNode::removedFromDocument): Ditto.
- * dom/Node.cpp:
- (WebCore::Node::insertedIntoDocument): Updated comment.
- (WebCore::Node::removedFromDocument): Ditto.
-
-2009-02-02 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- More plug-in cleanup.
-
- * WebCore.NPAPI.exp:
- Add new symbols.
-
- * bindings/objc/DOM.mm:
- * bindings/objc/DOMPrivate.h:
- Remove methods that WebKit doesn't use anymore.
+ Reviewed by Darin Fisher.
-2009-02-02 Jay Campan <jcampan@chromium.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26724
- Reviewed by Eric Seidel.
+ Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
+ up into RenderThemeChromiumSkia.
- Clean up PopupMenuChromium a little.
- https://bugs.webkit.org/show_bug.cgi?id=23653
+ * rendering/RenderThemeChromiumSkia.cpp:
+ (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
+ * rendering/RenderThemeChromiumSkia.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
+ * rendering/RenderThemeChromiumWin.h:
- No functional changes, only code cleanup, thus no tests.
+2009-06-25 Matt Perry <mpcomplete@chromium.org>
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::):
- (WebCore::PopupListBox::PopupListBox):
- (WebCore::PopupContainer::create):
- (WebCore::PopupContainer::PopupContainer):
- (WebCore::PopupContainer::showPopup):
- (WebCore::PopupListBox::handleKeyEvent):
- (WebCore::PopupListBox::isSelectableItem):
- (WebCore::PopupListBox::selectNextRow):
- (WebCore::PopupListBox::selectPreviousRow):
- (WebCore::PopupMenu::show):
- * platform/chromium/PopupMenuChromium.h:
-
-2009-02-02 Anders Carlsson <andersca@apple.com>
+ Reviewed by Darin Fisher.
- Reviewed by Dan Bernstein.
+ https://bugs.webkit.org/show_bug.cgi?id=26733
- Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
+ Add V8-only methods to FrameLoaderClient that V8 can use to send
+ out notifications when it creates/destroys a script context.
- * WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::createPlugin):
- (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
- * loader/FrameLoader.cpp:
- (WebCore::toPlugInElement):
- (WebCore::FrameLoader::loadPlugin):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
- * loader/FrameLoaderClient.h:
-
-2009-02-02 Genevieve Mak <gen@staikos.net>
-
- Reviewed by George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=23508
- Returns Blank Page for all "about" protocols
-
- * loader/MainResourceLoader.cpp:
- Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
- url or about:blank only (for now, exclusively for Torch Mobile platform).
-
-2009-02-02 Brent Fulgham <bfulgham@webkit.org>
-
- Reviewed by George Staikos.
-
- Fixes https://bugs.webkit.org/show_bug.cgi?id=23691.
- Correct build break caused by @r40366 by moving the
- common code implmentations from GraphicsContextCGWin.cpp
- into the base Windows class (GraphicsContextWin.cpp). Also
- move inTransparencyLayer since it is identical in both
- children.
-
- * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- Added member m_shouldIncludeChildWindows to Windows version,
- similar to GraphicsContextPlatformPrivateCG.h.
- * platform/graphics/win/GraphicsContextCGWin.cpp: Remove the
- implementations of shouldIncludeChildWindows,
- setShouldIncludeChildWindows, and inTransparencyLayer.
- * platform/graphics/win/GraphicsContextCairoWin.cpp: Remove
- the implementation of inTransparencyLayer.
- * platform/graphics/win/GraphicsContextWin.cpp: Move common code
- from GraphicsContextCGWin.cpp and GraphicsContextCairoWin.cpp.
- (WebCore::GraphicsContext::inTransparencyLayer):
- (WebCore::GraphicsContext::setShouldIncludeChildWindows):
- (WebCore::GraphicsContext::shouldIncludeChildWindows):
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Try to fix Wx build, and maybe Chromium build too.
-
- * WebCore.scons: Added IdentifierRep.cpp.
- * WebCoreSources.bkl: Ditto.
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Try to fix Wx build.
-
- * html/HTMLAreaElement.cpp: Added missing include of "Path.h".
-
-2009-02-02 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Nikolas Zimmermann.
-
- https://bugs.webkit.org/show_bug.cgi?id=23587
- Refactor HitTestRequest to eliminate all the ugly boolean arguments and
- use an enum bitflag instead. Cleanup all the code that constructs the
- various HitTestRequests to make the code more readable.
-
- * dom/Document.cpp:
- (WebCore::Document::elementFromPoint):
- (WebCore::Document::prepareMouseEvent):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::contains):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::eventMayStartDrag):
- (WebCore::EventHandler::updateSelectionForMouseDrag):
- (WebCore::EventHandler::hitTestResultAtPoint):
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- (WebCore::EventHandler::updateDragAndDrop):
- (WebCore::EventHandler::handleWheelEvent):
- (WebCore::EventHandler::sendContextMenuEvent):
- (WebCore::EventHandler::hoverTimerFired):
- (WebCore::EventHandler::handleDrag):
- * page/EventHandler.h:
- * rendering/HitTestRequest.h:
- (WebCore::HitTestRequest::):
- (WebCore::HitTestRequest::HitTestRequest):
- (WebCore::HitTestRequest::readOnly):
- (WebCore::HitTestRequest::active):
- (WebCore::HitTestRequest::mouseMove):
- (WebCore::HitTestRequest::mouseUp):
- (WebCore::HitTestRequest::ignoreClipping):
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::nodeAtPoint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTest):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::updateHoverActiveState):
-
-2009-02-02 George Staikos <george.staikos@torchmobile.com>
-
- Reviewed by Niko Zimmermann.
-
- Fix WML build by including the inlined renderStyle().
-
- * wml/WMLOptGroupElement.cpp:
- * wml/WMLOptionElement.cpp:
-
-2009-02-02 Darin Adler <darin@apple.com>
-
- Reviewed by Niko Zimmermann.
-
- Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
- https://bugs.webkit.org/show_bug.cgi?id=23686
- rdar://problem/6547971
-
- Also fix other XPath tests that are crashing.
-
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
- * xml/XPathStep.cpp:
- (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we
- need to make Attr nodes here. Yuck!
-
-2009-02-02 Yichao Yin <yichao.yin@torchmobile.com.cn>
-
- Reviewed by Niko Zimmermann.
-
- Test: wml/input-format.html
-
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::WMLInputElement):
- (WebCore::formatCodes):
- (WebCore::WMLInputElement::dispatchBlurEvent):
- (WebCore::WMLInputElement::parseMappedAttribute):
- (WebCore::WMLInputElement::attach):
- (WebCore::WMLInputElement::defaultEventHandler):
- (WebCore::WMLInputElement::init):
- (WebCore::WMLInputElement::validateInputMask):
- (WebCore::WMLInputElement::isConformedToInputMask):
- (WebCore::WMLInputElement::cursorPositionToMaskIndex):
- * wml/WMLInputElement.h:
-
-2009-02-02 Brent Fulgham <bfulgham@webkit.org>
-
- Build fix only, no review.
-
- Fixes https://bugs.webkit.org/show_bug.cgi?id=23685.
- Correct build break caused by @r40473.
-
- * page/win/FrameWin.cpp: Correct access for adjustPageHeight.
- (WebCore::computePageRectsForFrame):
-
-2009-02-02 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Fix WML enabled builds.
- FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
-
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::defaultEventHandler):
-
-2009-02-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
-
- Not easily testable.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource
- handle in a manner that is closer to what CachedResource does. We now make conditional
- requests for better performance, and set max-age to ensure that stale responses are not used.
- (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method.
- (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource
- is 304, take it from the newest cache.
- (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL.
- (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for
- the manifest if the response code was 304 - it won't be needed.
- (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that
- m_manifestResource is not null with a check.
- (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as
- an indication that the response was 304.
- (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
-
- * loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
-
-2009-02-01 Darin Adler <darin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Bug 23674: Speed up some things based on profiling the page load test
- https://bugs.webkit.org/show_bug.cgi?id=23674
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead
- of the old name, getCSSTarget.
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than
- calling through to EventTargetNode::insertedIntoDocument.
- (WebCore::ContainerNode::removedFromDocument): Ditto.
- (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit.
- (WebCore::ContainerNode::removedFromTree): Ditto.
-
- * dom/ContainerNode.h: Moved the constructor definition here and made it inline.
-
- * dom/Document.cpp:
- (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and
- its contents only to avoid the document type node. This allows us to remove the virtual
- function call to isEventTargetNode from the loop.
- (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
-
- * dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed
- getCSSTarget to cssTarget.
-
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the
- rare data check into an assertion.
-
- * dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline.
- Also moved the constructor definition here and made it inline. And added toEventTargetNode,
- matching the design of the render tree checked casts. Later we can migrate all callers
- from EventTargetNodeCast to toEventTargetNode.
-
- * dom/NamedAttrMap.cpp:
- (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from
- clearAttributes, so we could use this loop in cases where we're not clearing the attributes.
- (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of
- clearAttributes here.
- (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here.
- (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of
- clearAttributes. We don't need to clear the attributes array just because the element is
- going away, so don't.
- (WebCore::NamedAttrMap::virtualLength): Added.
-
- * dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private.
- These are all unnecessarily inefficient for use outside the DOM. Changed length to be a
- non-virtual function. This was a fairly hot function.
-
- * dom/NamedMappedAttrMap.cpp:
- (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the
- m_element data member is private.
-
- * dom/NamedMappedAttrMap.h: Made a few functions private. Made the
- hasMappedAttributes function non-virtual.
-
- * dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual
- function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
-
- * dom/Node.cpp:
- (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's
- only non-empty in subclasses of ContainerNode.
- (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS
- target has to be an Element, this can be moved down to ContainerNode (or it could be
- moved down to Element for that matter).
-
- * dom/QualifiedName.cpp:
- (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
-
- * dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and
- setPrefix function definitions into the header and made them inline.
-
- * html/HTMLAreaElement.cpp:
- (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now
- an OwnPtr.
- (WebCore::HTMLAreaElement::accessKey): Use AtomicString.
- (WebCore::HTMLAreaElement::setAccessKey): Ditto.
- (WebCore::HTMLAreaElement::alt): Ditto.
- (WebCore::HTMLAreaElement::setAlt): Ditto.
- (WebCore::HTMLAreaElement::coords): Ditto.
- (WebCore::HTMLAreaElement::setCoords): Ditto.
- (WebCore::HTMLAreaElement::setHref): Ditto.
- (WebCore::HTMLAreaElement::shape): Ditto.
- (WebCore::HTMLAreaElement::setShape): Ditto.
- (WebCore::HTMLAreaElement::setTarget): Ditto.
-
- * html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations.
- Change the region data member to be an OwnPtr<Path> instead of a Path to optimize
- the common case where an area element is parsed but never hit-tested. This could
- also have been done by changing the Path class's null case to be more efficient,
- but this seems fine.
-
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead
- of insertAttribute.
- (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto.
- (WebCore::HTMLViewSourceDocument::addLine): Ditto.
- (WebCore::HTMLViewSourceDocument::addLink): Ditto.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead
- of its old name getCSSTarget.
-
- * platform/graphics/GlyphWidthMap.cpp:
- (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
-
- * platform/graphics/GlyphWidthMap.h: Made most of this class inline.
- Changed m_pages to use OwnPtr.
-
- * platform/text/PlatformString.h: Remove include no longer needed since
- StringImpl.h includes it.
-
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored
- from createStrippingNullCharacters.
- * platform/text/StringImpl.h: Moved the definition of
- createStrippingNullCharacters here and made it inline.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from
- firstLineStyle.
-
- * rendering/RenderObject.h: Moved the definition of the firstLineStyle
- function here and made it inline. Moved the definition of the
- documentBeingDestroyed function here and made it inline.
-
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of
- getNamedItem here since it accomplishes the same thing but is more efficient.
- (WebCore::SVGSVGElement::getScreenCTM): Ditto.
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
-
- * xml/XPathFunctions.cpp:
- (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of
- getNamedItemNS.
-
- * xml/XPathStep.cpp:
- (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
-
-2009-02-02 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
-
- https://bugs.webkit.org/show_bug.cgi?id=23428
-
- FrameView::forceLayout could be killed but the comment might
- contain a value over the the plain FrameView::layout...
-
- Adjust the WebCore/WebKit consumers of these methods.
-
- * WebCore.base.exp:
- * page/Frame.cpp:
- (WebCore::Frame::setPrinting):
- * page/Frame.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::forceLayout):
- (WebCore::FrameView::forceLayoutWithPageWidthRange):
- (WebCore::FrameView::adjustPageHeight):
- * page/FrameView.h:
- * page/PrintContext.cpp:
- (WebCore::PrintContext::computePageRects):
-
-2009-02-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
-
- Fixes http/tests/navigation/multiple-back-forward-entries.html
-
- r40432 added a parameter to FrameLoader::scheduleLocationChange() and
- failed to update all call sites.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::createWindow): Pass the lockBackForwardHistory parameter,
- giving it the same value as the lockHistory parameter.
- (windowProtoFuncOpen): Ditto.
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation): Ditto.
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::setLocation): Ditto.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::requestFrame): Ditto.
-
-2009-01-31 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
-
- On the PLT, this results in 0.36x the number of virtual function calls
- to RenderText::width() and 0.69x the number of calls to
- Font::isFixedPitch(), but makes 1.0004x the number of calls to
- Font::width().
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len'
- with an assertion.
- * rendering/bidi.cpp:
- (WebCore::textWidth): Added this inlined helper function which calls
- Font::width() directly in the non-fixed-pitch, non-full-range case, and
- otherwise calls RenderText::width().
- (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has
- fixed pitch (in which case RenderText::width() will be called in order
- to take advantage of the widthFromCache() optimization for fixed-pitch
- fonts). Replaced all calls to RenderText::width() with calls to the
- textWidth() helper function.
-
-2009-01-31 David Hyatt <hyatt@apple.com>
-
- Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
- and setNeedsPositionedMovementLayout.
-
- Reviewed by Dan Bernstein
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setLayerNeedsFullRepaint):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::setNeedsLayout):
- (WebCore::RenderObject::setChildNeedsLayout):
- (WebCore::RenderObject::setNeedsPositionedMovementLayout):
- (WebCore::objectIsRelayoutBoundary):
- (WebCore::RenderObject::markContainingBlocksForLayout):
-
-2009-01-31 Darin Adler <darin@apple.com>
-
- Fix Mac build.
-
- * loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here.
- We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely
- deleted and I don't want to bring it back just to fix the build.
-
- * loader/FrameLoaderClient.h: Rearrange virtual functions and corrected
- a possibly-confusing comment.
-
-2009-01-31 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23664
- Remove unused dead code from RenderTable class. The dead code includes
- two enums and the associated member variables as well as one getter function.
-
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::RenderTable):
- * rendering/RenderTable.h:
-
-2009-01-31 David Hyatt <hyatt@apple.com>
-
- More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
- Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
- RenderObjectChildList.
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::destroy):
- (WebCore::RenderBlock::addChild):
- (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
- (WebCore::RenderBlock::layoutPositionedObjects):
- (WebCore::RenderBlock::childBecameNonInline):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::layout):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::firstChildBox):
- (WebCore::RenderBox::lastChildBox):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addChild):
- (WebCore::RenderContainer::removeChildNode):
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- (WebCore::RenderContainer::appendChildNode):
- (WebCore::RenderContainer::insertChildNode):
- (WebCore::RenderContainer::positionForCoordinates):
- (WebCore::RenderContainer::addLineBoxRects):
- (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- * rendering/RenderContainer.h:
- (WebCore::RenderContainer::virtualChildren):
- (WebCore::RenderContainer::children):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::destroy):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::layout):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::destroy):
- (WebCore::RenderMedia::children):
- * rendering/RenderMedia.h:
- (WebCore::RenderMedia::virtualChildren):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::destroy):
- (WebCore::RenderObject::layout):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::firstChild):
- (WebCore::RenderObject::lastChild):
- (WebCore::RenderObject::virtualChildren):
- (WebCore::RenderObject::canHaveChildren):
- * rendering/RenderObjectChildList.cpp: Added.
- (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- * rendering/RenderObjectChildList.h:
- * rendering/RenderReplaced.h:
- (WebCore::RenderReplaced::canHaveChildren):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::RenderSVGContainer):
- (WebCore::RenderSVGContainer::destroy):
- (WebCore::RenderSVGContainer::removeChildNode):
- (WebCore::RenderSVGContainer::appendChildNode):
- (WebCore::RenderSVGContainer::insertChildNode):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::virtualChildren):
- (WebCore::RenderSVGContainer::children):
-
-2009-01-31 David Hyatt <hyatt@apple.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=11363
-
- Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
- With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
- layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
- be properly ignored.
-
- Reviewed by Oliver Hunt
-
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::createDeletionUI):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- (WebCore::RenderTable::layout):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::layout):
- * rendering/RenderTableSection.h:
-
-2009-01-31 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23663
- Add a void toRenderBox() method which catches unnecessary casts at compile
- time and also fix the four cases where this was happening.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::determineHorizontalPosition):
- * rendering/RenderBox.h:
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::updateHitTestResult):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
-
-2009-01-30 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Add a pref to disable web security.
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::SecurityOrigin):
- (WebCore::SecurityOrigin::canAccess):
- (WebCore::SecurityOrigin::canRequest):
- (WebCore::SecurityOrigin::grantUniversalAccess):
- * page/SecurityOrigin.h:
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setWebSecurityEnabled):
- * page/Settings.h:
- (WebCore::Settings::isWebSecurityEnabled):
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- Move the inline virtual destructor after a non-inline virtual
- function so that the symbol for the vtable is not marked as a
- weakly exported symbol.
-
- This trick was previously used at revision 36122 in JSObject.h
-
+ (WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
+ (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
* loader/FrameLoaderClient.h:
- (WebCore::FrameLoaderClient::~FrameLoaderClient):
+ (WebCore::FrameLoaderClient::didCreateScriptContext):
+ (WebCore::FrameLoaderClient::didDestroyScriptContext):
-2009-01-30 Oliver Hunt <oliver@apple.com>
+2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
- Reviewed by Stephanie Lewis
+ Reviewed by David Levin.
- Inline SimpleFontData::widthForGlyph for a minor page load improvement.
+ Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
+ to match WebKit style.
- * platform/graphics/SimpleFontData.cpp:
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::widthForGlyph):
+ * bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+2009-06-25 Adam Langley <agl@google.com>
- Build fix for WX and maybe even Windows.
+ TBRed: fix for Chromium tree.
- * WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
+ Add missing include for r45199.
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26736
- Reviewed by Darin Adler.
-
- Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler
-
- Carry out the move and catch up in two call sites.
+ r45199 added a reference to throwError without including V8Proxy.h
- * WebCore.base.exp:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::sendResizeEvent):
- (WebCore::EventHandler::sendScrollEvent):
- * page/EventHandler.h:
- * page/Frame.cpp:
- * page/Frame.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::performPostLayoutTasks):
- (WebCore::FrameView::valueChanged):
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- Move Frame::isFrameSet to Document::isFrameSet
-
- Changed the FrameLoader callsite. I assume that as this
- point m_frame.document() might return a null pointer. Change
- the condition to either not having a document or not having a
- frame set. This should be semantically equivalent to the
- old code.
-
- Make Document::body() const to be able to call it from within
- Document::isFrameSet. Leave the isHTMLDocument() check as this
- is a stronger condition than simply having a HTMLElement in the
- DOM.
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::Document::isFrameSet):
- (WebCore::Document::body):
- * dom/Document.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::shouldScrollToAnchor):
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::createFromSelection):
- * page/Frame.cpp:
- * page/Frame.h:
-
-2009-01-30 Aurelian Maga <aurelianmaga@yahoo.com>
-
- Reviewed by Holger Freyther.
-
- [GTK] Logic fixes and build fixes
-
- https://bugs.webkit.org/show_bug.cgi?id=22022
-
- Catch up with the internal GeoLocation API and fix the logic of
- the previous version.
-
- * platform/gtk/GeolocationServiceGtk.cpp:
- (WebCore::GeolocationServiceGtk::startUpdating):
- (WebCore::GeolocationServiceGtk::updateLocationInformation):
- (WebCore::GeolocationServiceGtk::position_changed):
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Nikolas Zimmermann.
-
- [GTK] Implement GeolocationService using the Geoclue library
-
- https://bugs.webkit.org/show_bug.cgi?id=22022
-
- Untested implementation of the GeolocationService using the geoclue
- library. Velocity handling is completely missing and the accuracy
- handling might be wrong.
-
- * platform/gtk/GeolocationServiceGtk.cpp:
- (WTF::GeoclueAccuracy):
- (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
- (WebCore::GeolocationServiceGtk::~GeolocationServiceGtk):
- (WebCore::GeolocationServiceGtk::startUpdating):
- (WebCore::GeolocationServiceGtk::stopUpdating):
- (WebCore::GeolocationServiceGtk::suspend):
- (WebCore::GeolocationServiceGtk::resume):
- (WebCore::GeolocationServiceGtk::lastPosition):
- (WebCore::GeolocationServiceGtk::lastError):
- (WebCore::GeolocationServiceGtk::updateLocationInformation):
- (WebCore::GeolocationServiceGtk::updatePosition):
- (WebCore::GeolocationServiceGtk::position_changed):
- (WebCore::GeolocationServiceGtk::setError):
- * platform/gtk/GeolocationServiceGtk.h:
-
-2009-01-30 Mark Rowe <mrowe@apple.com>
-
- Build fix. Declare preferredSize as static.
-
- * platform/text/cf/StringImplCF.cpp:
- (WebCore::StringWrapperCFAllocator::preferredSize):
-
-2009-01-30 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
- https://bugs.webkit.org/show_bug.cgi?id=23622
-
- * platform/text/cf/StringImplCF.cpp:
- (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator.
- (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator.
- (WebCore::StringWrapperCFAllocator::release): Ditto.
- (WebCore::StringWrapperCFAllocator::copyDescription): Ditto.
- (WebCore::StringWrapperCFAllocator::allocate): Ditto.
- (WebCore::StringWrapperCFAllocator::reallocate): Ditto.
- (WebCore::StringWrapperCFAllocator::deallocate): Ditto.
- (WebCore::StringWrapperCFAllocator::preferredSize): Ditto.
- (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but
- returns 0 if garbage collection is enabled.
- (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
-
- * platform/text/mac/StringImplMac.mm:
- (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging,
- rather than using NSString directly. This lets NSString benefit from the above.
-
-2009-01-30 Darin Adler <darin@apple.com>
-
- * page/Frame.cpp:
- (WebCore::Frame::createView): Fix debug build by removing get() from assert.
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=22056
-
- Kill FrameLoaderClient.cpp, move the code over to Frame::createView
-
- FrameLoaderClient is supposed to be an interface, move the
- to be shared code to Frame which is a controller and is
- allowed to create a FrameView.
-
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * loader/FrameLoaderClient.cpp: Removed.
- * loader/FrameLoaderClient.h:
- (WebCore::FrameLoaderClient::~FrameLoaderClient):
- * page/Frame.cpp:
- (WebCore::Frame::createView):
- * page/Frame.h:
-
-2009-01-30 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23357
-
- New files to support accelerated compositing at the RenderLayer
- level.
-
- * WebCore.xcodeproj/project.pbxproj:
- New files added to project, and run through the sort script.
-
- * rendering/RenderLayerBacking.cpp: Added.
- * rendering/RenderLayerBacking.h: Added.
- New object to store compositing-related data for a single
- RenderLayer.
-
- * rendering/RenderLayerCompositor.cpp: Added.
- * rendering/RenderLayerCompositor.h: Added.
- Per-RenderView controller object for compositing hierarchy
- maintenance.
-
-2009-01-30 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23356
+ * bindings/v8/WorkerScriptController.cpp:
- Add new files related to accelerated compositing:
+2009-06-25 Adam Langley <agl@google.com>
- * WebCore.xcodeproj/project.pbxproj:
- Add the files to the project. Also add ColorCG.cpp, for the
- Color(CGColorRef) constructor.
+ TBRed: fix for Chromium tree.
- * platform/graphics/GraphicsLayer.cpp: Added.
- * platform/graphics/GraphicsLayer.h: Added.
- GraphicsLayer is a platform abstraction for a hardware-backed
- layer.
+ https://bugs.webkit.org/show_bug.cgi?id=26735
- * platform/graphics/GraphicsLayerClient.h: Added.
- Client of GraphicsLayer, allowing GraphicsLayer to call out
- to WebCore code.
+ Fix V8IsolatedWorld to point to the correct include file.
- * platform/graphics/mac/GraphicsLayerCA.h: Added.
- * platform/graphics/mac/GraphicsLayerCA.mm: Added.
- Mac Core Animation implementation of GraphicsLayer.
+ The deprecated v8_index.h was removed from the Chromium tree in r19291
+ and upstreamed into WebKit with r45193. However V8IsolatedWorld
+ slipped in between the cracks and broke the build.
- * platform/graphics/mac/WebLayer.h: Added.
- * platform/graphics/mac/WebLayer.mm: Added.
- * platform/graphics/mac/WebTiledLayer.h: Added.
- * platform/graphics/mac/WebTiledLayer.mm: Added.
- Subclasses of CALayer and CATiledLayer -- helpers for the
- GraphicsLayerCA implementation.
+ * bindings/v8/V8IsolatedWorld.h: update with new header location.
-2009-01-30 Geoffrey Garen <ggaren@apple.com>
+2009-06-25 Chris Marrin <cmarrin@apple.com>
- Reviewed by Sam Weinig.
+ Reviewed by Simon Fraser <simon.fraser@apple.com>.
- Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
- preparation for setting them differently during a redirect.
+ https://bugs.webkit.org/show_bug.cgi?id=26651
+
+ Preference is named "WebKitAcceleratedCompositingEnabled"
+ and is a boolean value. When false, prevents compositing layers from
+ being created, which prevents hardware animation from running.
+ Also forces video to do software rendering. Added a cache for
+ the flag in RenderLayerCompositing and made it all work
+ on-the-fly when the flag is changed while a page is loaded.
* WebCore.base.exp:
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::submit):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::navigateIfAllowed):
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::setProtocol):
- (WebCore::JSLocation::setHost):
- (WebCore::JSLocation::setHostname):
- (WebCore::JSLocation::setPort):
- (WebCore::JSLocation::setPathname):
- (WebCore::JSLocation::setSearch):
- (WebCore::JSLocation::setHash):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::assign):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::defaultEventHandler):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::submit):
- * html/HTMLFormElement.h:
- * loader/FrameLoader.cpp:
- (WebCore::FormSubmission::FormSubmission):
- (WebCore::ScheduledRedirection::ScheduledRedirection):
- (WebCore::isBackForwardLoadType):
- (WebCore::FrameLoader::createWindow):
- (WebCore::FrameLoader::changeLocation):
- (WebCore::FrameLoader::urlSelected):
- (WebCore::FrameLoader::submitFormAgain):
- (WebCore::FrameLoader::submitForm):
- (WebCore::FrameLoader::restoreDocumentState):
- (WebCore::FrameLoader::scheduleHTTPRedirection):
- (WebCore::FrameLoader::scheduleLocationChange):
- (WebCore::FrameLoader::scheduleRefresh):
- (WebCore::FrameLoader::redirectionTimerFired):
- (WebCore::FrameLoader::loadURLIntoChildFrame):
- (WebCore::FrameLoader::startRedirectionTimer):
- (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
- (WebCore::FrameLoader::transitionToCommitted):
- (WebCore::FrameLoader::clientRedirected):
- (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
- * loader/FrameLoaderTypes.h:
- (WebCore::):
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::contextMenuItemSelected):
- * svg/SVGAElement.cpp:
- (WebCore::SVGAElement::defaultEventHandler):
-
-2009-01-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6545095>
- ASSERTION FAILED: RenderBlock.h:519: !o || o->isRenderBlock()
-
- Test: fast/block/float/crash-replaced-display-block.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into
- isRenderBlock if-statement.
-
-2009-01-30 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23656: AX hierarchy for iFrames is incorrect
- https://bugs.webkit.org/show_bug.cgi?id=23656
-
- The AX hierarchy when an iFrame was present was incorrect. A different scroll area was
- returned when going down compared to when going up.
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (convertToNSArray):
-
-2009-01-30 Adam Treat <adam.treat@torchmobile.com>
-
- Fix Qt build to include new class IdentifierRep introduced in revision 40412.
-
- * WebCore.pro:
-
-2009-01-30 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.
-
- * WebCore.LP64.exp:
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-01-30 Sam Weinig <sam@webkit.org>
-
- Commit files I forgot to in the previous commit.
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::layoutCount):
- * page/Frame.cpp:
- (WebCore::Frame::contentRenderer):
- (WebCore::Frame::forceLayoutWithPageWidthRange):
* page/FrameView.cpp:
- (WebCore::FrameView::layout):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::nodeAtPoint):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::repaintUsingContainer):
- (WebCore::RenderObject::repaint):
- (WebCore::RenderObject::repaintRectangle):
- (WebCore::RenderObject::view):
- (WebCore::RenderObject::scheduleRelayout):
- (WebCore::RenderObject::maximalOutlineSize):
- * rendering/SVGRenderSupport.cpp:
- (WebCore::clampImageBufferSizeToViewport):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
-
-2009-01-30 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- More scaffolding for redirect tracking. No behavior change yet.
-
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for
- redirect checking in a form submission through JS. (Currently, we
- just specify "no redirect.")
-
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::processingUserGesture):
- (WebCore::ScriptController::processingUserGestureEvent):
- (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored
- user gesture check to make it more clear.
-
- (WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
- for checking if there's a user gesture in any frame on the page (a more
- relaxed rule than our popup blocking rule, which requires the user
- gesture to occur in the frame that's executing JavaScript.)
-
- * html/HTMLFormElement.h:
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::submit): Added scaffolding necessary for
- redirect checking in a form submission through the DOM. (Currently, we
- just specify "no redirect.")
-
- * html/HTMLFormElement.idl: Made submit custom so it can participate
- in redirect checking.
-
- * loader/FrameLoader.h:
- * loader/FrameLoader.cpp:
- (WebCore::FormSubmission::FormSubmission): Clarified some names, and
- added a "lockHistory" parameter to form submissions, to match other
- navigations.
-
- (WebCore::FrameLoader::submitFormAgain):
- (WebCore::FrameLoader::submitForm): Use the lockHistory parameter.
-
- (WebCore::FrameLoader::userGestureHint): Refactored this function for
- clarity, and added a FIXME for a change I was too scared to make myself.
- (Really, we should just get rid of this function.)
-
- (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
- to pass a FrameLoadType to form posts, too, so they can participate in
- redirect tracking.
-
- (WebCore::FrameLoader::loadPostRequest):
- (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- (WebCore::FrameLoader::loadItem): Use the lockHistory parameter.
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Mark Rowe.
-
- [Gtk+] Use AccessibilityObject::stringValue for the AtkObject name
-
- https://bugs.webkit.org/show_bug.cgi?id=21546
-
- The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
- states that: "AtkObjects whose text content is simple, unattributed, and very
- brief may expose that content via atk_object_get_name instead"
-
- As we are currently not able to always provide a AtkTextInterface
- implementation this will make the whole content available to accerciser,
- and other tools.
-
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
-
-2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix.
-
- Include string.h for strdup.
-
- * bridge/IdentifierRep.h:
-
-2009-01-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
- is not a RenderView.
-
- * dom/Document.cpp:
- (WebCore::Document::renderView):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::nodeWillBeRemoved):
- (WebCore::SelectionController::recomputeCaretRect):
- (WebCore::SelectionController::invalidateCaretRect):
- (WebCore::SelectionController::focusedOrActiveStateChanged):
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::repaintLayerRectsForImage):
- (WebCore::RenderBox::availableHeightUsing):
- * rendering/RenderView.h:
- (WebCore::toRenderView):
-
-2009-01-30 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23360
-
- Really use the container-relative repaint rect methods
- for repaint during layout
-
- * rendering/RenderObject.h:
- (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
-
-2009-01-30 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- Get rid of PrivateIdentifier and use IdentifierRep instead.
-
- * bridge/NP_jsobject.cpp:
- (_NPN_Invoke):
- (_NPN_GetProperty):
- (_NPN_SetProperty):
- (_NPN_RemoveProperty):
- (_NPN_HasProperty):
- (_NPN_HasMethod):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::getPropertyNames):
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertNPStringToUTF16):
- * bridge/c/c_utility.h:
- * bridge/npruntime.cpp:
- (_NPN_GetStringIdentifier):
- (_NPN_GetStringIdentifiers):
- (_NPN_GetIntIdentifier):
- (_NPN_IdentifierIsString):
- (_NPN_UTF8FromIdentifier):
- (_NPN_IntFromIdentifier):
-
-2009-01-30 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig and Darin Adler.
-
- Make IdentifierRep a real class, add necessary class methods.
-
- * bridge/IdentifierRep.cpp:
- (WebCore::identifierSet):
- Returns a set of all identifiers.
-
- (WebCore::IdentifierRep::isValid):
- Return whether an identifier is valid, meaning that it's present in the
- set of identifiers.
-
- * bridge/IdentifierRep.h:
- (WebCore::IdentifierRep::isString):
- (WebCore::IdentifierRep::number):
- (WebCore::IdentifierRep::string):
- (WebCore::IdentifierRep::IdentifierRep):
- (WebCore::IdentifierRep::):
-
-2009-01-30 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add IdentifierRep which will be used by both plug-in implementations.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bridge/IdentifierRep.cpp: Added.
- (WebCore::IdentifierRep::IdentifierRep):
- (WebCore::IdentifierRep::):
- (WebCore::intIdentifierMap):
- (WebCore::identifierRep):
- (WebCore::stringIdentifierMap):
- * bridge/IdentifierRep.h: Added.
- * bridge/c/c_utility.h:
- * platform/text/PlatformString.h:
- * platform/text/String.cpp:
- (WebCore::String::fromUTF8WithLatin1Fallback):
-
-2009-01-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by David Hyatt.
-
- Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
- is not a RenderInline.
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
- (WebCore::InlineFlowBox::rendererLineBoxes):
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- (WebCore::InlineFlowBox::paint):
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::addFocusRingRects):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeRectForRepaint):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::inlineContinuation):
- (WebCore::nextContinuation):
- (WebCore::RenderInline::splitInlines):
- * rendering/RenderInline.h:
- (WebCore::toRenderInline):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::boundingBox):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- * rendering/RenderText.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::createLineBoxes):
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-01-30 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23647
- Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports
-
- * platform/graphics/skia/ImageSourceSkia.cpp:
- (WebCore::ImageSource::clear):
-
-2009-01-30 David Hyatt <hyatt@apple.com>
-
- Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
- is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
- is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.
-
- Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
- patch with a containsFloats() check.
-
- Reviewed by Darin Adler
-
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::isCandidate):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
- * editing/Editor.cpp:
- (WebCore::Editor::hasBidiSelection):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::anchorElement):
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleWillChange):
- (WebCore::RenderBlock::removeChild):
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::clearFloatsIfNeeded):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::fillBlockSelectionGaps):
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- (WebCore::RenderBlock::firstLineBlock):
- (WebCore::getLineAtIndex):
- (WebCore::getHeightForLineCount):
- (WebCore::RenderBlock::lineCount):
- (WebCore::RenderBlock::adjustForBorderFit):
- (WebCore::RenderBlock::clearTruncation):
- * rendering/RenderBlock.h:
- (WebCore::toRenderBlock):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeRectForRepaint):
- (WebCore::RenderBox::calcReplacedHeightUsing):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::inlineContinuation):
- (WebCore::nextContinuation):
- (WebCore::RenderInline::positionForCoordinates):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- * rendering/RenderListItem.cpp:
- (WebCore::getParentOfFirstLineBox):
- (WebCore::RenderListItem::positionListMarker):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containingBlock):
- (WebCore::RenderObject::computeRectForRepaint):
- (WebCore::RenderObject::removeFromObjectLists):
- (WebCore::RenderObject::getTextDecorationColors):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- (WebCore::RenderTable::recalcSections):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::styleDidChange):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::block):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::createLineBoxes):
-
-2009-01-30 Brady Eidson <beidson@apple.com>
-
- Reviewed by Sam Weinig
-
- - Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of
- relying on some outside force.
- - Clear the previous history item inside FrameLoader instead of relying on multiple
- FrameLoaderClients to do it.
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here.
- (WebCore::CachedFrame::restore): Resume those DOM objects here.
- * history/CachedFrame.h:
- (WebCore::CachedFrame::domWindow):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the
- suspending of active DOM objects.
- (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects.
- (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead
- of performing a client call by itself.
- (WebCore::FrameLoader::frameLoadCompleted):
-
-2009-01-30 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6448823> Application Cache is kept after a private browsing session
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::selectCache):
- (WebCore::ApplicationCacheGroup::update):
- Cache update will not be started if private browsing is enabled. Existing cache version
- from disk database will be used.
-
- * loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call
- it when refusing to update from selectCache().
-
- * loader/appcache/ApplicationCache.cpp:
- (WebCore::ApplicationCache::addDynamicEntry):
- (WebCore::ApplicationCache::removeDynamicEntry):
- Added reminders about private browsing to unimplemented methods.
-
-2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Bug 23580: GNU mode RVCT compilation support
- <https://bugs.webkit.org/show_bug.cgi?id=23580>
-
- * html/PreloadScanner.cpp: Use COMPILER(GCC) instead of __GNUC__.
-
-2009-01-30 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
- <https://bugs.webkit.org/show_bug.cgi?id=23616>
-
- Added forwarding header.
-
- * ForwardingHeaders/wtf/TypeTraits.h: Added.
-
-2009-01-30 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23599: ResourceError needs to be copyable for use in another thread.
- <https://bugs.webkit.org/show_bug.cgi?id=23599>
-
- Add ResourceErrorBase::copy method. (Not yet used.)
-
- * platform/network/ResourceErrorBase.cpp:
- (WebCore::ResourceErrorBase::copy):
- * platform/network/ResourceErrorBase.h:
-
-2009-01-29 Stephanie Lewis <slewis@apple.com>
-
- RS by Oliver Hunt.
-
- Update the order files.
-
- * WebCore.order:
-
-2009-01-29 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23488
-
- Make TimerBase thread-aware (for Workers).
- Added new class ThreadTimers - it keeps a heap of all timers for a thread (previously kept in a static global).
- Pointer to instance of ThreadTimers is stored in GlobalThreadData.
- Most static methods of TimerBase went to ThreadTimers.
-
- The TimerBase functionality did not change (it maintains the timer heap which computes the nearest firing).
-
- Added new abstract class SharedTimer, so worker threads can provide their own implementation (will be implemented on WorkerRunLoop).
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Added new ThreadTimers.cpp to build files.
-
- * platform/SharedTimer.h:
- (WebCore::SharedTimer::~SharedTimer):
- (WebCore::MainThreadSharedTimer::setFiredFunction):
- (WebCore::MainThreadSharedTimer::setFireTime):
- (WebCore::MainThreadSharedTimer::stop):
- Added abstract SharedTimer and MainThreadSharedTimer which redirects to the existing port-supplied functions.
-
- * platform/ThreadGlobalData.cpp:
- (WebCore::ThreadGlobalData::ThreadGlobalData):
- (WebCore::ThreadGlobalData::~ThreadGlobalData):
- * platform/ThreadGlobalData.h:
- (WebCore::ThreadGlobalData::threadTimers):
- Added ThreadTimers to ThreadGlobalData.
-
- * platform/ThreadTimers.cpp: Added.
- (WebCore::mainThreadSharedTimer):
- Static getter for a MainThreadSharedTimer singleton.
-
- (WebCore::ThreadTimers::ThreadTimers):
- (WebCore::ThreadTimers::setSharedTimer):
- (WebCore::ThreadTimers::updateSharedTimer):
- (WebCore::ThreadTimers::collectFiringTimers):
- (WebCore::ThreadTimers::fireTimers):
- (WebCore::ThreadTimers::sharedTimerFired):
- (WebCore::ThreadTimers::sharedTimerFiredInternal):
- (WebCore::ThreadTimers::fireTimersInNestedEventLoop):
- ThreadTimers implementation. Most of the code is moved from previous static functions on TimerBase.
- Need a new class so each thread may get ts own copy of the timer heap.
-
- * platform/ThreadTimers.h: Added.
- (WebCore::ThreadTimers::timerHeap):
- (WebCore::ThreadTimers::timersReadyToFire):
-
- * platform/Timer.cpp:
- (WebCore::timerHeap):
- (WebCore::timersReadyToFire):
- (WebCore::TimerHeapElement::TimerHeapElement):
- (WebCore::TimerHeapElement::checkConsistency):
- (WebCore::TimerHeapElement::operator=):
- (WebCore::TimerHeapIterator::checkConsistency):
- (WebCore::TimerBase::TimerBase):
- (WebCore::TimerBase::~TimerBase):
- (WebCore::TimerBase::isActive):
- (WebCore::TimerBase::checkHeapIndex):
- (WebCore::TimerBase::heapDelete):
- (WebCore::TimerBase::heapDeleteMin):
- (WebCore::TimerBase::heapInsert):
- (WebCore::TimerBase::heapPopMin):
- (WebCore::TimerBase::setNextFireTime):
- (WebCore::TimerBase::fireTimersInNestedEventLoop):
- Now instead of static timer heap these use accessor functions that pull thread-specific heap instance.
-
- * platform/Timer.h:
- static methods moved to ThreadTimers.
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Beginning of work to eliminate RenderContainer and make containership "pluggable" into any spot in the render tree. The first step is to create
- the new object that will handle children: RenderObjectChildList and move RenderContainer's member variables into it. Subsequent patches will begin
- moving RenderContainer's functionality into RenderObjectChildList.
-
- Reviewed by Eric Seidel
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::RenderContainer):
- (WebCore::RenderContainer::destroyLeftoverChildren):
- (WebCore::RenderContainer::addChild):
- (WebCore::RenderContainer::removeChildNode):
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- (WebCore::RenderContainer::appendChildNode):
- (WebCore::RenderContainer::insertChildNode):
- (WebCore::RenderContainer::layout):
- (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
- (WebCore::RenderContainer::positionForCoordinates):
- (WebCore::RenderContainer::addLineBoxRects):
- (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- * rendering/RenderContainer.h:
- (WebCore::RenderContainer::firstChild):
- (WebCore::RenderContainer::lastChild):
- (WebCore::RenderContainer::firstChildBox):
- (WebCore::RenderContainer::lastChildBox):
- * rendering/RenderObjectChildList.h: Added.
- (WebCore::RenderObjectChildList::RenderObjectChildList):
- (WebCore::RenderObjectChildList::firstChild):
- (WebCore::RenderObjectChildList::lastChild):
- (WebCore::RenderObjectChildList::setFirstChild):
- (WebCore::RenderObjectChildList::setLastChild):
-
-2009-01-29 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- http://bugs.webkit.org/show_bug.cgi?id=23598
- Replace smart-quotes in UTF-8 with ASCII double-quotes to avoid
- the compilation error on CJK Windows
-
- * wml/WMLTableElement.cpp:
- (WebCore::WMLTableElement::parseMappedAttribute):
-
-2009-01-29 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23627
- Fix the PLATFORM(SKIA) build.
-
- * svg/graphics/SVGPaintServer.cpp:
- (WebCore::SVGPaintServer::teardown):
-
-2009-01-29 Scott Violet <sky@google.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23625
- Skia platform doesn't render text to a canvas or support clipping to an image buffer
-
- Fixes two bugs in Skia rendering to a canvas:
- . Text was not rendered at all. This is because we never properly
- fixed up the alpha values. The fix is to create a layer when
- rendering text to a layer.
- . We were not honoring clipping to an image buffer.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::Font::drawGlyphs):
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::clipToImageBuffer):
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::ImageBuffer):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::PlatformContextSkia):
- (PlatformContextSkia::setDrawingToImageBuffer):
- (PlatformContextSkia::isDrawingToImageBuffer):
- (PlatformContextSkia::beginLayerClippedToImage):
- (PlatformContextSkia::restore):
- (PlatformContextSkia::applyClipFromImage):
- * platform/graphics/skia/PlatformContextSkia.h:
-
-2009-01-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- First step in tracking the urls a HistoryItem was redirected through.
-
- * WebCore.base.exp:
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem):
- (WebCore::HistoryItem::addRedirectURL):
- (WebCore::HistoryItem::redirectURLs):
- (WebCore::HistoryItem::setRedirectURLs):
- * history/HistoryItem.h:
-
-2009-01-29 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann, Eric Seidel.
-
- Just transform the pattern directly instead of transforming the context fixes this
- problem. Texts or strokes are no longer affected by transformations.
-
- SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions
- https://bugs.webkit.org/show_bug.cgi?id=23472
-
- Test: svg/custom/pattern-with-transformation.svg
-
- * platform/graphics/Pattern.h:
- (WebCore::Pattern::setPatternSpaceTransform):
- * platform/graphics/cairo/PatternCairo.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * platform/graphics/cg/PatternCG.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * platform/graphics/qt/PatternQt.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * svg/graphics/SVGPaintServerPattern.cpp:
- (WebCore::SVGPaintServerPattern::setup):
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Move the line box list member out of RenderFlow and down into RenderBlock and RenderInline. Eliminate RenderFlow from the tree.
-
- Reviewed by Sam Weinig
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * html/HTMLAnchorElement.cpp:
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::rendererLineBoxes):
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- * rendering/InlineFlowBox.h:
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::RenderBlock):
- (WebCore::RenderBlock::destroy):
- (WebCore::RenderBlock::styleWillChange):
- (WebCore::RenderBlock::styleDidChange):
- (WebCore::RenderBlock::dirtyLineBoxes):
- (WebCore::RenderBlock::removeChild):
- (WebCore::RenderBlock::setSelectionState):
- (WebCore::RenderBlock::avoidsFloats):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- (WebCore::RenderBlock::baselinePosition):
- (WebCore::RenderBlock::getBaselineOfFirstLineBox):
- (WebCore::RenderBlock::getBaselineOfLastLineBox):
- (WebCore::RenderBlock::rectWithOutlineForRepaint):
- (WebCore::RenderBlock::hoverAncestor):
- (WebCore::RenderBlock::updateDragState):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::lineBoxes):
- (WebCore::RenderBlock::firstLineBox):
- (WebCore::RenderBlock::lastLineBox):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeRectForRepaint):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- * rendering/RenderBox.h:
- * rendering/RenderFlow.cpp: Removed.
- * rendering/RenderFlow.h: Removed.
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::destroy):
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::cloneInline):
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::offsetLeft):
- (WebCore::RenderInline::offsetTop):
- (WebCore::RenderInline::positionForCoordinates):
- (WebCore::RenderInline::rectWithOutlineForRepaint):
- (WebCore::RenderInline::updateDragState):
- (WebCore::RenderInline::relativePositionedInlineOffset):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::lineBoxes):
- (WebCore::RenderInline::firstLineBox):
- (WebCore::RenderInline::lastLineBox):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::rendererLineBoxes):
- * rendering/RootInlineBox.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::createLineBoxes):
- * wml/WMLAElement.cpp:
-
-2009-01-29 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Cleaned up some naming in ScheduledRedirection.
-
- * loader/FrameLoader.cpp:
- (WebCore::ScheduledRedirection::ScheduledRedirection):
-
-2009-01-29 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Update to use new API.
-
- * platform/graphics/mac/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
- (WebCore::createFontCustomPlatformData):
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- https://bugs.webkit.org/show_bug.cgi?id=23619
- ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load
- is cancelled
-
- Covered by existing tests (as a random crash).
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::cancelledError):
- (WebCore::EmptyFrameLoaderClient::blockedError):
- (WebCore::EmptyFrameLoaderClient::cannotShowURLError):
- (WebCore::EmptyFrameLoaderClient::interruptForPolicyChangeError):
- (WebCore::EmptyFrameLoaderClient::cannotShowMIMETypeError):
- (WebCore::EmptyFrameLoaderClient::fileDoesNotExistError):
- (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
- Create non-null errors.
-
-2009-01-29 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Removed an unused case of "lockHistory" to help make the other cases
- clearer.
-
- * page/FrameLoadRequest.h:
- (WebCore::FrameLoadRequest::FrameLoadRequest):
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Move all of the contination insertion code from RenderFlow to RenderInline. addChildToFlow is renamed to addChildIgnoringContinuation, and it has been moved to
- RenderContainer so that it can still be called on either blocks or inlines. The base class implementation in RenderContainer is what RenderBlock uses. RenderInline
- subclasses it to do all the work it used to do in addChildToFlow.
-
- RenderBlock's old addChildToFlow can just become addChild. This simplification is possible because addChild was actually never being called on anonymous
- block continuations.
-
- The code dealing with anonymous table parts in the old addChildWithContinuation method can now be removed as a result with no harmful side effects. Falling through to the
- base class and ignoring a block continuation makes the right thing happen.
-
- addChildWithContinuation moved to RenderInline and has been renamed to addChildToContinuation.
-
- Reviewed by Eric Seidel
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::addChild):
- * rendering/RenderBlock.h:
- * rendering/RenderContainer.h:
- (WebCore::RenderContainer::addChildIgnoringContinuation):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::addChild):
- (WebCore::nextContinuation):
- (WebCore::RenderInline::continuationBefore):
- (WebCore::RenderInline::addChildIgnoringContinuation):
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::splitFlow):
- (WebCore::RenderInline::addChildToContinuation):
- (WebCore::RenderInline::childBecameNonInline):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::continuation):
- (WebCore::RenderInline::setContinuation):
-
-2009-01-29 Brady Eidson <beidson@apple.com>
-
- Reviewed by Oliver Hunt
-
- <rdar://problem/6337157> hyundaiusa.com closes window or tab during load
-
- Test: fast/loader/subframe-self-close.html
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::close): Only allow mainframes to close the window.
-
-2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by David Hyatt.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23539
-
- Remove several virtual functions from Node & Element related to form control / input elements,
- that shouldn't reside there, but move to approriate locations, in the new form control /
- input element abstract base classes.
-
- Remove the isControl() method from Node, as it's redundant - isFormControlElement() provides the same information.
- Move isEnabled( / isReadOnlyControl() / isTextControl() from Node to FormControlElement.
- Move isAutofilled() / isChecked() / isIndeterminate() from Node to InputElement.
- Move isInputTypeHidden() / isPasswordField() from Element to InputElement.
-
- Querying these methods requires using the toInputElement/toFormControlElement casting helper functions
- to cast Element pointers to InputElement/FormControlElement pointers.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::canShareStyleWithElement):
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * dom/Element.h:
- (WebCore::Element::isFormControlElementWithState):
- * dom/FormControlElement.h:
- * dom/InputElement.h:
- * dom/Node.h:
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::advance):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::attach):
- * html/HTMLFormControlElement.h:
- (WebCore::HTMLFormControlElement::isTextControl):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::CheckedRadioButtons::removeButton):
- * html/HTMLInputElement.h:
- (WebCore::HTMLInputElement::isAutofilled):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isPasswordField):
- (WebCore::AccessibilityRenderObject::isIndeterminate):
- (WebCore::AccessibilityRenderObject::isChecked):
- (WebCore::AccessibilityRenderObject::isControl):
- (WebCore::AccessibilityRenderObject::isEnabled):
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- * page/mac/AccessibilityObjectWrapper.mm:
- (textMarkerForVisiblePosition):
- * platform/ContextMenu.cpp:
- (WebCore::ContextMenu::populate):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::resize):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::itemIsEnabled):
- * rendering/RenderTextControl.cpp:
- (WebCore::updateUserModifyProperty):
- (WebCore::RenderTextControl::adjustInnerTextStyle):
- (WebCore::RenderTextControl::updateFromElement):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::isChecked):
- (WebCore::RenderTheme::isIndeterminate):
- (WebCore::RenderTheme::isEnabled):
- (WebCore::RenderTheme::isReadOnlyControl):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustMenuListStyle):
- * wml/WMLFormControlElement.cpp:
- (WebCore::WMLFormControlElement::isFocusable):
- * wml/WMLFormControlElement.h:
- (WebCore::WMLFormControlElement::isEnabled):
- (WebCore::WMLFormControlElement::isReadOnlyControl):
- (WebCore::WMLFormControlElement::isTextControl):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::isKeyboardFocusable):
- (WebCore::WMLInputElement::isMouseFocusable):
- * wml/WMLInputElement.h:
- (WebCore::WMLInputElement::isAutofilled):
-
-2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Fix WML build - apply same fix as HTMLAnchorElement received.
-
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::isKeyboardFocusable):
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23620
- Crash in appcache/resource-redirect.html on Tiger
-
- There was a bug in the test case - it didn't send a Location header, and on Tiger, this
- resulted in a failure callback being sent. It turned out that proper redirects weren't
- caught at all.
-
- Tests: http/tests/appcache/manifest-redirect-2.html
- http/tests/appcache/resource-redirect-2.html
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::didFail): Fixed this function to not crash if
- didReceiveResponse() wasn't called for this request.
- (WebCore::ApplicationCacheGroup::didReceiveResponse): Fixed to check for redirects correctly.
- (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Ditto.
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Move dirtyLinesFromChangedChild into RenderLineBoxList so that it can be shared by RenderBlock and RenderInline.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::dirtyLinesFromChangedChild):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.h:
- (WebCore::RenderInline::dirtyLinesFromChangedChild):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- * rendering/RenderLineBoxList.h:
-
-2009-01-29 Adam Roben <aroben@apple.com>
-
- Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
- receives a WM_PRINTCLIENT message
-
- <https://bugs.webkit.org/show_bug.cgi?id=23623>
- <rdar://problem/6513921>
- <rdar://problem/6536874>
-
- Flash doesn't seem to respond to WM_PRINTCLIENT, so we change
- WM_PRINTCLIENT messages into WM_PAINT messages and hook into the
- BeginPaint/EndPaint APIs to return the HDC we received from
- WM_PRINTCLIENT. This causes the plugin to paint into the
- WM_PRINTCLIENT HDC via its normal WM_PAINT handler. This technique
- came from <http://www.fengyuan.com/article/wmprint.html>.
-
- No test possible.
-
- Reviewed by Darin Adler.
-
- * platform/graphics/GraphicsContext.h: Added
- [set]ShouldIncludeChildWindows on Windows.
-
- * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Added
- m_shouldIncludeChildWindows.
- (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- Initialize the new member.
-
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- (WebCore::GraphicsContext::setShouldIncludeChildWindows):
- (WebCore::GraphicsContext::shouldIncludeChildWindows):
- Added simple setter and getter.
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView): Initialize the new member.
-
- * plugins/PluginView.h: Added m_wmPrintHDC and various functions
- required for making WM_PRINTCLIENT work.
-
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::hookedBeginPaint):
- (WebCore::PluginView::hookedEndPaint):
- (WebCore::hook):
- (WebCore::setUpOffscreenPaintingHooks):
- Added. Code was modified from code available on fengyuan.com.
-
- (WebCore::PluginView::wndProc): Turn WM_PRINTCLIENT messages into
- WM_PAINT messages and save off the HDC that we're supposed to paint
- into.
-
- (WebCore::PluginView::paintWindowedPluginIntoContext): Added. Gets an
- HDC from the GraphicsContext, translates it into client coordinates,
- gets the plugin to draw into the HDC by sending a WM_PRINTCLIENT
- message, and returns the HDC to the GraphicsContext.
-
- (WebCore::PluginView::paint): If we're trying to paint a windowed
- plugin into the GraphicsContext, call paintWindowedPluginIntoContext.
-
- (WebCore::PluginView::init): Call setUpOffscreenPaintingHooks to make
- our WM_PRINTCLIENT trick work.
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Move RenderFlow::destroy down into RenderBlock and RenderInline.
-
- Reviewed by Anders Carlsson
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::destroy):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::destroy):
-
-2009-01-29 David Kilzer <ddkilzer@apple.com>
-
- Remove semi-colons from the end of ObjC method implementations
-
- Rubber-stamped by Adam Roben.
-
- $ find WebCore -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
-
- * bridge/testbindings.mm:
-
-2009-01-29 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23609
- Use the two-arg constructor for implicit QUrl->KURL conversion as the
- single argument ctors assume that KURL::parse has already been called
- and assert if the parse results in a different string. This was causing
- an assert for QUrl's with no path and without a trailing slash.
-
- * platform/qt/KURLQt.cpp:
- (WebCore::KURL::KURL):
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Rubber-stamped by Darin Adler.
-
- Renamed ApplicationCacheResource::Implicit to Master, because that's the word HTML5 uses,
- and it describes the meaning better.
-
- * loader/appcache/ApplicationCache.cpp:
- * loader/appcache/ApplicationCacheGroup.cpp:
- * loader/appcache/ApplicationCacheResource.cpp:
- * loader/appcache/ApplicationCacheResource.h:
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Release build fix.
-
- * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- Got rid of a variable that wasn't used in release builds.
-
-2009-01-29 David Hyatt <hyatt@apple.com>
-
- Get rid of createAnonymousFlow. It was only called in one spot, so just inline the code.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::updateFirstLetter):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23476
- HTTP redirect should make application cache updating fail
-
- Tests: http/tests/appcache/manifest-redirect.html
- http/tests/appcache/resource-redirect.html
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::didReceiveResponse):
- (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
- Fail if response code isn't 2xx.
-
-2009-01-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23592
- Update appcache manifest signature parsing
-
- Test: http/tests/appcache/wrong-signature-2.html
-
- * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Allow comments on signature
- line. Removed code that replaced nulls with 0xFFFD characters, because there is no such
- requirement in the spec.
-
-2009-01-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23584
- Update application cache code for the latest round of spec changes
-
- The changes mostly affect the update process - events are sent at a different
- time, and caches are associated with documents earlier.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::mainReceivedError): Changed an always passing test to an assertion.
- (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Caches are now associated
- with DocumentLoader before being complete, but they only affect loading after being completed.
- (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Ditto.
-
- * loader/appcache/ApplicationCache.cpp:
- (WebCore::ApplicationCache::setGroup): Allow setting the group to the same one, to simplify
- ApplicationCacheGroup code.
- (WebCore::ApplicationCache::isComplete): A new method that tells whether the cache is
- complete, as defined in HTML5.
- * loader/appcache/ApplicationCache.h: Added isComplete().
-
- * loader/appcache/ApplicationCacheGroup.h:
- (WebCore::ApplicationCacheUpdateOption): Per HTML5, cache updating should work differently
- when invoked with or without a browsing context (Frame). A Frame is currently always needed
- for updating in WebKit, so a new argument to update() tells whether we should pretend that
- there isn't one.
- (WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): A helper for ApplicationCache::isComplete().
- (WebCore::ApplicationCacheGroup::CompletionType): Cache update algorithm now waits for
- ne main resources to finish loading in more cases. A member variable of this type is used to
- distinguish between different cases when waiting.
- (WebCore::ApplicationCacheGroup::m_cacheCandidates): The new algorithm doesn't track cache
- candidates. Caches are associated with documents much earlier, but the ones whose main resources
- have not been loaded from a cache are being tracked in a pending master entry list.
-
- * loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::update):
- An explicit call to update() invokes the algorithm without a browsing context.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
- (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
- (WebCore::ApplicationCacheGroup::selectCache):
- (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
- (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
- (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
- (WebCore::ApplicationCacheGroup::stopLoading):
- (WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
- (WebCore::ApplicationCacheGroup::cacheDestroyed):
- (WebCore::ApplicationCacheGroup::setNewestCache):
- (WebCore::ApplicationCacheGroup::update):
- (WebCore::ApplicationCacheGroup::didReceiveResponse):
- (WebCore::ApplicationCacheGroup::didFinishLoading):
- (WebCore::ApplicationCacheGroup::didFail):
- (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
- (WebCore::ApplicationCacheGroup::manifestNotFound):
- (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- (WebCore::ApplicationCacheGroup::startLoadingEntry):
- (WebCore::ApplicationCacheGroup::deliverDelayedMainResources):
- (WebCore::ApplicationCacheGroup::addEntry):
- (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache):
- (WebCore::CallCacheListenerTask::create):
- (WebCore::CallCacheListenerTask::performTask):
- (WebCore::CallCacheListenerTask::CallCacheListenerTask):
- (WebCore::ApplicationCacheGroup::postListenerTask):
- Rewrote the update algorithm.
-
-2009-01-28 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Merged FrameLoadTypeReloadAllowingStaleData with FrameLoadTypeReload.
-
- Technically, selecting View->Text Encoding->[Non-Default Encoding] on
- a page with frames may now be slightly slower than it used to be. Oh well.
-
- * loader/FrameLoader.cpp:
- (WebCore::isBackForwardLoadType):
- (WebCore::FrameLoader::restoreDocumentState): Subbed in FrameLoadTypeReload.
-
- (WebCore::FrameLoader::loadURLIntoChildFrame): No need to account for
- non-back-forward navigations anymore.
-
- (WebCore::FrameLoader::canCachePage):
- (WebCore::FrameLoader::logCanCachePageDecision):
- (WebCore::FrameLoader::reloadWithOverrideEncoding):
- (WebCore::FrameLoader::transitionToCommitted):
- (WebCore::FrameLoader::loadItem): Subbed in FrameLoadTypeReload.
-
- * loader/FrameLoader.h: Renamed reloadAllowingStaleData => reloadWithOverrideEncoding,
- since that's what it actually does.
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move hit testing and painting of lines from RenderFlow into RenderLineBoxList.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintContents):
- (WebCore::RenderBlock::hitTestContents):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::paint):
- (WebCore::RenderInline::nodeAtPoint):
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::paint):
- (WebCore::RenderLineBoxList::hitTest):
- * rendering/RenderLineBoxList.h:
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Fix SVG pixel test regressions. I wish I could say that I understand this fix, but I don't. For
- some reason the original code returned 0 for RenderSVGInlineText::yPos() and somehow my literal
- replacement of yPos() with the body of that method changed the results. I am completely baffled,
- but all SVG pixel tests pass again when I just take the code out.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move dirtyLineBoxes from RenderFlow to RenderInline and RenderBlock.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::dirtyLineBoxes):
- * rendering/RenderBlock.h:
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::dirtyLineBoxes):
- * rendering/RenderInline.h:
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLineBoxes):
- * rendering/RenderLineBoxList.h:
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Back out my change to scrollWidth/Height from an earlier checkin since it broke stuff. The current
- behavior is not correct, but this will need to be investigated before being changed again.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move paintOutline and paintOutlineWithLine from RenderFlow to RenderInline, since they only apply to inlines. Tighten up all of the code that
- called paintOutline to use RenderInline as the type instead of RenderFlow.
-
- Reviewed by cpst
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::paint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::addContinuationWithOutline):
- (WebCore::RenderBlock::paintContinuationOutlines):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::paintLines):
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::paintOutline):
- (WebCore::RenderInline::paintOutlineForLine):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::paintOutline):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::PaintInfo::PaintInfo):
-
-2009-01-28 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23596
- XMLHttpRequest.cpp no longer compiles without USE(JSC)
-
- * xml/XMLHttpRequest.cpp:
-
-2009-01-28 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23597
- Make it possible to compile Database.cpp when USE(JSC) is not defined
-
- * storage/Database.cpp:
- (WebCore::Database::Database):
-
-2009-01-28 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6077047> REGRESSION (r34544): Custom icon does not
- appear in address field on first visit to any site
-
- * loader/icon/IconLoader.cpp:
- (WebCore::IconLoader::finishLoading): Changed to set the icon data only
- after establishing a mapping from the page URL(s) to the icon. Doing
- things the other way around resulted in the data not being cached
- in the icon-URL to IconRecord map (because there was no interested page
- at the time) and subsequently having to be fetched asynchronously from
- the database when the page-to-icon mapping was established.
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move addFocusRingRects from RenderFlow down into RenderBlock and RenderInline.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::addFocusRingRects):
- * rendering/RenderBlock.h:
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::addFocusRingRects):
- * rendering/RenderInline.h:
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move localCaretRect from RenderFlow into RenderBlock, since it only applied to blocks anyway and
- was misplaced from the start.
-
- Reviewed by Antti Koivisto.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect):
- * rendering/RenderBlock.h:
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
-
-2009-01-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Add forwarding header.
-
- * ForwardingHeaders/debugger/DebuggerActivation.h: Added.
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move createInlineBox out of RenderFlow and down into RenderInline and RenderBlock.
-
- Reviewed by Beth Dakin
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::createInlineBox):
- * rendering/RenderBlock.h:
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::createInlineBox):
- * rendering/RenderInline.h:
- * rendering/bidi.cpp:
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move calcMargins from RenderFlow to RenderInline, since it was only ever called on RenderInlines.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.h:
- (WebCore::RenderInline::calcMargins):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Refactor the first and last line box member variables from RenderFlow. Encapsulate them into a new class called RenderLineBoxList that manages all modifications to
- the list. This change will make it easier to give RenderInline and RenderBlock separate versions of the line box list without having to duplicate very much code.
-
- Reviewed by Oliver Hunt
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::deleteLine):
- (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::extractLine):
- (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
- (WebCore::InlineFlowBox::attachLine):
- (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
- * rendering/InlineFlowBox.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::deleteLineBoxTree):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::destroy):
- (WebCore::RenderFlow::dirtyLineBoxes):
- (WebCore::RenderFlow::createInlineBox):
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::RenderFlow):
- (WebCore::RenderFlow::lineBoxes):
- (WebCore::RenderFlow::firstLineBox):
- (WebCore::RenderFlow::lastLineBox):
- * rendering/RenderLineBoxList.cpp: Added.
- (WebCore::RenderLineBoxList::~RenderLineBoxList):
- (WebCore::RenderLineBoxList::appendLineBox):
- (WebCore::RenderLineBoxList::deleteLineBoxTree):
- (WebCore::RenderLineBoxList::extractLineBox):
- (WebCore::RenderLineBoxList::attachLineBox):
- (WebCore::RenderLineBoxList::removeLineBox):
- (WebCore::RenderLineBoxList::deleteLineBoxes):
- (WebCore::RenderLineBoxList::checkConsistency):
- * rendering/RenderLineBoxList.h: Added.
- (WebCore::RenderLineBoxList::RenderLineBoxList):
- (WebCore::RenderLineBoxList::firstLineBox):
- (WebCore::RenderLineBoxList::lastLineBox):
- (WebCore::RenderLineBoxList::checkConsistency):
- * rendering/RenderSVGInline.cpp:
- (WebCore::RenderSVGInline::createInlineBox):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::createInlineBox):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::removeLineBoxFromRenderObject):
- (WebCore::RootInlineBox::extractLineBoxFromRenderObject):
- (WebCore::RootInlineBox::attachLineBoxToRenderObject):
- * rendering/RootInlineBox.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-01-28 David Kilzer <ddkilzer@apple.com>
-
- Clean up FontPlatformData constructor
-
- Reviewed by David Hyatt.
-
- * platform/graphics/mac/FontPlatformData.h: Updated copyright.
- (WebCore::FontPlatformData::FontPlatformData): Provide readable
- names for constructor arguments and reformat member variables.
- * platform/graphics/mac/FontPlatformDataMac.mm: Updated copyright.
- (WebCore::FontPlatformData::FontPlatformData): Provide readable
- names for constructor arguments and reformat member variables.
-
-2009-01-28 Tony Chang <tony@chromium.org>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23593
- Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
- This is a follow up for hyatt's RenderBox changes.
-
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::baselinePosition):
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::RenderThemeChromiumWin::paintMenuList):
-
-2009-01-28 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23582
-
- Fix assertions when inline elements have both opacity (or something
- else that creates a RenderLayer), and transform by ensuring that
- setHasTransform() is only called for non-inline or replaced elements.
- We also have to ensure that RenderReplicas will get transforms applied
- to them by lying about them being replaced.
-
- Tests: fast/transforms/transform-on-inline.html
- fast/transforms/transform-table-row.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
- * rendering/RenderReplica.cpp:
- (WebCore::RenderReplica::RenderReplica):
- * rendering/RenderTableRow.h:
- (WebCore::RenderTableRow::requiresLayer):
-
-2009-01-28 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Justin Garcia.
-
- https://bugs.webkit.org/show_bug.cgi?id=18835
- Spelling underlines disappear when they shouldn't
-
- The WebCore::InsertLineBreakCommand::doApply() function splits a text node
- without copying existing markers. To fix this bug, change code which
- manually splits a text node into a CompositeEditCommand::splitTextNode() call.
-
- Test: editing/spelling/spelling-linebreak.html
-
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Move the m_lineHeight member variable out of RenderFlow and down into RenderBlock and RenderInline. Shift the line height computation into RenderStyle so
- that it isn't repeated in three places.
-
- Reviewed by Sam Weinig
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::RenderBlock):
- (WebCore::RenderBlock::lineHeight):
- * rendering/RenderBlock.h:
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::RenderFlow):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::lineHeight):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::lineHeight):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::computedLineHeight):
-
-2009-01-28 Zachary Kuznia <zork@chromiuum.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22070
- Add an option to allow scripts to close windows.
-
+ (WebCore::FrameView::updateCompositingLayers):
* page/Settings.cpp:
+ (WebCore::setNeedsReapplyStylesInAllFrames):
(WebCore::Settings::Settings):
- (WebCore::Settings::setAllowScriptsToCloseWindows):
+ (WebCore::Settings::setAcceleratedCompositingEnabled):
* page/Settings.h:
- (WebCore::Settings::allowScriptsToCloseWindows):
-
-2009-01-28 Adam Langley <agl@google.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23573
- Make PlatformWidget on chromium an intptr_t to match changes made in Chromium
-
- * platform/chromium/PlatformWidget.h:
-
-2009-01-28 David Hyatt <hyatt@apple.com>
-
- Fix for
-
- <rdar://problem/6531287> REGRESSION: CrashTracer: [USER] 12 crashes in Safari at com.apple.WebCore • WebCore::RenderBlock::removeFloatingObject + 59
-
- My tightening up of markAllDescendantsWithFloatsForLayout exposed a buggy check in that code that could
- lead to a bad cast.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
-
-2009-01-27 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=23576
-
- Work towards eliminating RenderFlow from the tree.
-
- Move the m_continuation variable down from RenderFlow into RenderInline and RenderBlock. Since a block can only have an inline continuation following it, the type
- of the member and methods reflect this (inlineContinuation() and m_inlineContinuation). Since an inline can have either a block or an inline continuation following it,
- a base class of RenderBox* is used for the type of object returned (in anticipation of the removal of RenderFlow).
-
- Since moving the continuation variable down into the subclasses increased the size of RenderInline and RenderBlock by 4 bytes, this patch also moves all of the bitfield
- members of RenderFlow up to RenderObject. Since they fit within the available bits on RenderObject, this patch actually results in a net savings of 4 bytes on RenderInlines
- and RenderBlocks!
-
- One bitfield member was eliminated rather than moved: m_firstLine. This was really more of a state variable used during line layout only, so I removed it as a member
- and just passed firstLine down to various methods as needed. Doing so uncovered some potential bugs where the first line state was not being respected when querying for
- line offsets.
-
- Continuations have been completely hidden from all files except for RenderFlow, RenderBlock and RenderInline. All of the code that referenced continuations directly
- from base classes has been refactored to use virtual methods on RenderBlock and RenderInline instead.
-
- RenderFlow still has a common addChildWithContinuation method that is used by both blocks and inlines. Since refactoring that method will be pretty tricky, I've held
- off on that for a later patch.
-
- Reviewed by Oliver Hunt
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::anchorElement):
- (WebCore::AccessibilityRenderObject::boundingBoxRect):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- (WebCore::InlineFlowBox::paint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::RenderBlock):
- (WebCore::RenderBlock::~RenderBlock):
- (WebCore::RenderBlock::destroy):
- (WebCore::RenderBlock::addChildToFlow):
- (WebCore::RenderBlock::makeChildrenNonInline):
- (WebCore::RenderBlock::removeChild):
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::determineHorizontalPosition):
- (WebCore::RenderBlock::setCollapsedBottomMargin):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::addContinuationWithOutline):
- (WebCore::RenderBlock::setSelectionState):
- (WebCore::RenderBlock::shouldPaintSelectionGaps):
- (WebCore::RenderBlock::fillSelectionGaps):
- (WebCore::RenderBlock::leftSelectionOffset):
- (WebCore::RenderBlock::rightSelectionOffset):
- (WebCore::RenderBlock::leftOffset):
- (WebCore::RenderBlock::leftRelOffset):
- (WebCore::RenderBlock::rightOffset):
- (WebCore::RenderBlock::rightRelOffset):
- (WebCore::RenderBlock::lineWidth):
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- (WebCore::RenderBlock::getClearDelta):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::offsetForContents):
- (WebCore::RenderBlock::availableWidth):
- (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
- (WebCore::RenderBlock::desiredColumnWidth):
- (WebCore::RenderBlock::desiredColumnCount):
- (WebCore::RenderBlock::columnRects):
- (WebCore::RenderBlock::layoutColumns):
- (WebCore::RenderBlock::adjustPointToColumnContents):
- (WebCore::RenderBlock::adjustRectForColumns):
- (WebCore::RenderBlock::absoluteRects):
- (WebCore::RenderBlock::absoluteQuads):
- (WebCore::RenderBlock::rectWithOutlineForRepaint):
- (WebCore::RenderBlock::hoverAncestor):
- (WebCore::RenderBlock::updateDragState):
- (WebCore::RenderBlock::outlineStyleForRepaint):
- (WebCore::RenderBlock::childBecameNonInline):
- (WebCore::RenderBlock::updateHitTestResult):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::rightOffset):
- (WebCore::RenderBlock::leftOffset):
- (WebCore::RenderBlock::inlineContinuation):
- (WebCore::RenderBlock::setInlineContinuation):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::absoluteRects):
- (WebCore::RenderBox::absoluteQuads):
- (WebCore::RenderBox::addFocusRingRects):
- (WebCore::RenderBox::containingBlockWidth):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::collapsedMarginBottom):
- (WebCore::RenderBox::childBecameNonInline):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderFlow.cpp:
- (WebCore::nextContinuation):
- (WebCore::RenderFlow::continuationBefore):
- (WebCore::RenderFlow::addChildWithContinuation):
- (WebCore::RenderFlow::addChild):
- (WebCore::RenderFlow::destroy):
- (WebCore::RenderFlow::addFocusRingRects):
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::RenderFlow):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::RenderInline):
- (WebCore::RenderInline::destroy):
- (WebCore::RenderInline::inlineContinuation):
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::addChildToFlow):
- (WebCore::RenderInline::cloneInline):
- (WebCore::RenderInline::splitInlines):
- (WebCore::RenderInline::splitFlow):
- (WebCore::RenderInline::positionForCoordinates):
- (WebCore::RenderInline::rectWithOutlineForRepaint):
- (WebCore::RenderInline::updateDragState):
- (WebCore::RenderInline::childBecameNonInline):
- (WebCore::RenderInline::updateHitTestResult):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::isRenderInline):
- (WebCore::RenderInline::continuation):
- (WebCore::RenderInline::setContinuation):
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::positionListMarker):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::RenderListMarker):
- (WebCore::RenderListMarker::setSelectionState):
- * rendering/RenderListMarker.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- (WebCore::RenderObject::rectWithOutlineForRepaint):
- (WebCore::RenderObject::handleDynamicFloatPositionChange):
- (WebCore::RenderObject::updateDragState):
- (WebCore::RenderObject::updateHitTestResult):
- (WebCore::RenderObject::getTextDecorationColors):
- (WebCore::RenderObject::adjustRectForOutlineAndShadow):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isInlineBlockOrInlineTable):
- (WebCore::RenderObject::childrenInline):
- (WebCore::RenderObject::setChildrenInline):
- (WebCore::RenderObject::hasColumns):
- (WebCore::RenderObject::setHasColumns):
- (WebCore::RenderObject::cellWidthChanged):
- (WebCore::RenderObject::setCellWidthChanged):
- (WebCore::RenderObject::isInlineContinuation):
- (WebCore::RenderObject::hoverAncestor):
- (WebCore::RenderObject::outlineStyleForRepaint):
- (WebCore::RenderObject::setHasMarkupTruncation):
- (WebCore::RenderObject::hasMarkupTruncation):
- (WebCore::RenderObject::selectionState):
- (WebCore::RenderObject::setSelectionState):
- (WebCore::RenderObject::hasSelectedChildren):
- (WebCore::RenderObject::isTopMarginQuirk):
- (WebCore::RenderObject::isBottomMarginQuirk):
- (WebCore::RenderObject::setTopMarginQuirk):
- (WebCore::RenderObject::setBottomMarginQuirk):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::RenderReplaced):
- (WebCore::RenderReplaced::setSelectionState):
- * rendering/RenderReplaced.h:
- (WebCore::RenderReplaced::canBeSelectionLeaf):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::calcWidth):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::updateWidth):
- (WebCore::RenderTableCell::layout):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
- (WebCore::RenderText::localCaretRect):
- (WebCore::RenderText::setSelectionState):
- * rendering/RenderText.h:
- (WebCore::RenderText::canBeSelectionLeaf):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::updateHitTestResult):
- * rendering/RenderView.h:
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::selectionTop):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::createLineBoxes):
- (WebCore::RenderBlock::constructLine):
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::RenderBlock::determineStartPosition):
- (WebCore::RenderBlock::skipTrailingWhitespace):
- (WebCore::RenderBlock::skipLeadingWhitespace):
- (WebCore::RenderBlock::fitBelowFloats):
- (WebCore::RenderBlock::findNextLineBreak):
- (WebCore::RenderBlock::checkLinesForTextOverflow):
-
-2009-01-28 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Nikolas Zimmermann and George Staikos.
-
- https://bugs.webkit.org/show_bug.cgi?id=23557
- Allow option of hit testing frame content without clipping to the visible
- viewport.
-
- * WebCore.base.exp:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/EventHandler.h:
- * rendering/HitTestRequest.h:
- (WebCore::HitTestRequest::HitTestRequest):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTest):
-
-2009-01-28 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Fix the build with Qt on Windows.
-
- Make sure that the QTWEBKIT_EXPORT macro becomes the Q_DECL_EXPORT macro
- instead of the import macro when building the dll, by defining
- QT_MAKEDLL.
-
- SystemTimeWin.cpp is needed on Windows for userIdleTime(), which for the
- other Qt platforms comes from TemporaryLinkStubs.cpp.
-
- * WebCore.pro:
-
-2009-01-28 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Speed-up clipping: avoid calling expensive QPainter::clipRegion().
- Beside, the check is not necessary since QPainter::setClipRect() will
- work just fine if there is no clip region yet.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::clip):
-
-2009-01-28 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23546
- Upstream GoogleURL implementation of KURL
-
- * platform/KURL.h:
- * platform/KURLGoogle.cpp: Added.
- * platform/KURLGooglePrivate.h: Added.
-
-2009-01-27 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- REGRESSION (r40234): Launching iTunes from a link displays a
- "Safari can't find the Internet plug-in" sheet in Safari
- rdar://problem/6533678
-
- * rendering/RenderPartObject.cpp:
- (WebCore::havePlugin): Put the check for empty string in here.
- (WebCore::serviceTypeForClassId): Only return activeXType() if
- we have a plug-in that can handle that type. While it might be logical
- to return an Active X type for any <object> with a classId in it,
- even if we don't have a plug-in that implements Active X, existing
- clients, such as Safari, don't expect that.
-
-2009-01-27 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Steve Falkenburg.
-
- - fix <rdar://problem/6524351> Text looks bad when font smoothing is
- forced off
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::Font::drawGlyphs): Changed to use GDI rather than Core
- Graphics if the client has turned font smoothing off.
-
-2009-01-27 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23360
-
- Use the new container-relative repaint methods to compute
- post-layout repaints, and repaints using RenderLayer's
- cached repaintRect() relative to that container, rather than
- using absolute coords.
-
- Replaced lots of boilerplate old/new rect code in various
- layout methods with a stack-based LayoutRepainter class, and
- fixed a bug in RenderTable which set didFullRepaint to
- 'true' every time.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::layout):
+ (WebCore::Settings::acceleratedCompositingEnabled):
* rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::setHasVisibleContent):
+ (WebCore::RenderLayer::hasAcceleratedCompositing):
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::currentTransform):
* rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::repaintUsingContainer):
- (WebCore::RenderObject::repaint):
- (WebCore::RenderObject::repaintRectangle):
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
- (WebCore::RenderObject::LayoutRepainter::repaintAfterLayout):
- (WebCore::RenderObject::LayoutRepainter::checkForRepaint):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::layout):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::layout):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::layout):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::layout):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::layout):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::layout):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-01-27 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/3541409> - More groundwork and cleanup for CachedFrames
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrame::CachedFrame): Make the savePlatformDataToCachedFrame() client call here,
- and add the code for caching subframes.
- (WebCore::CachedFrame::clear):
- * history/CachedFrame.h: Change to be RefCounted
- (WebCore::CachedFrame::create):
- (WebCore::CachedFrame::url):
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- * history/CachedPage.h:
- (WebCore::CachedPage::document):
- (WebCore::CachedPage::documentLoader):
- (WebCore::CachedPage::view):
- (WebCore::CachedPage::url):
- (WebCore::CachedPage::domWindow):
- (WebCore::CachedPage::cachedMainFrame):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::cachePageForHistoryItem): Move the platform data saving into the
- CachedFrame itself.
-
-2009-01-27 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Flip the arguments of computeRectForRepaint() from
- computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)
- to
- computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::clippedOverflowRectForRepaint):
- (WebCore::RenderBox::computeRectForRepaint):
- * rendering/RenderBox.h:
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::computeRectForRepaint):
- * rendering/RenderForeignObject.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::computeRectForRepaint):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::computeAbsoluteRepaintRect):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- (WebCore::RenderTableCell::computeRectForRepaint):
- * rendering/RenderTableCell.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::computeRectForRepaint):
- * rendering/RenderView.h:
-
-2009-01-27 David Kilzer <ddkilzer@apple.com>
-
- Add missing header guards to AccessibilityObjectWrapper.h
-
- Reviewed by Anders Carlsson.
-
- * page/mac/AccessibilityObjectWrapper.h: Added missing header guards.
-
-2009-01-27 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23567
-
- Fix crash of svg/custom/stop-crash.svg testcase because of
- infinite recursion, as I missed replacing absoluteClippedOverflowRect()
- with clippedOverflowRectForRepaint() in RenderSVGGradientStop.
-
- Also fix a missed conversion in RenderTableCol, and add a couple
- of comments.
-
- * rendering/RenderSVGGradientStop.h:
- (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::imageChanged):
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::layout):
-
-2009-01-27 Adele Peterson <adele@apple.com>
-
- RS by Dave Hyatt
-
- Use the textfield appearance for search fields in themeWin.css so the border/background
- styling will work correctly on these fields.
-
- * css/themeWin.css:
-
-2009-01-27 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::setSelectionStart):
- (WebCore::JSHTMLInputElement::setSelectionEnd):
- (WebCore::JSHTMLInputElement::setSelectionRange):
-
-2009-01-27 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * platform/graphics/Gradient.cpp:
- (WebCore::Gradient::setSpreadMethod):
-
-2009-01-27 Paul Godavari <paul@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23561
- Explicitly send the MIME type from an image dragged from a web
- page to the desktop, to Chromium so that it can properly generate
- a file name.
-
- * platform/chromium/ChromiumDataObject.cpp:
- (WebCore::ChromiumDataObject::clear):
- (WebCore::ChromiumDataObject::hasData):
- * platform/chromium/ChromiumDataObject.h:
- * platform/chromium/ClipboardChromium.cpp:
- (WebCore::writeImageToDataObject):
-
-2009-01-27 Mads Ager <ager@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23300
- Follow Firefox in throwing exceptions when using selection
- functions on HTMLInputElements that cannot have selection.
-
- This requires custom setSelectionRange, setSelectionStart and
- setSelectionEnd implementations, but it gets rid of the custom
- getOwnPropertySlot.
-
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::selectionStart):
- (WebCore::JSHTMLInputElement::selectionEnd):
- (WebCore::JSHTMLInputElement::setSelectionRange):
- * html/HTMLInputElement.idl:
-
-2009-01-27 Evan Stade <estade@chromium.org>
-
- Reviewed by Nikolas Zimmermann.
-
- https://bugs.webkit.org/show_bug.cgi?id=23435
- Make spreadMethod a member of Gradient rather than GraphicsContext.
- Implement spreadMethod for Skia.
-
- * platform/graphics/Gradient.cpp:
- (WebCore::Gradient::Gradient):
- * platform/graphics/Gradient.h:
- (WebCore::Gradient::setSpreadMethod):
- (WebCore::Gradient::spreadMethod):
- * platform/graphics/GraphicsContext.cpp:
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsContextPrivate.h:
- * platform/graphics/GraphicsTypes.h:
- (WebCore::):
- * platform/graphics/cairo/GradientCairo.cpp:
- (WebCore::Gradient::platformGradient):
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- * platform/graphics/qt/GradientQt.cpp:
- (WebCore::Gradient::platformGradient):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- * platform/graphics/skia/GradientSkia.cpp:
- (WebCore::Gradient::platformGradient):
- * svg/SVGLinearGradientElement.cpp:
- (WebCore::SVGLinearGradientElement::buildGradient):
- * svg/SVGRadialGradientElement.cpp:
- (WebCore::SVGRadialGradientElement::buildGradient):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
- (WebCore::SVGPaintServerGradient::setup):
- (WebCore::SVGPaintServerGradient::externalRepresentation):
- * svg/graphics/SVGPaintServerGradient.h:
-
-2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- http://www.qtsoftware.com/developer/task-tracker/index_html?id=238662&method=entry
-
- [Qt] Map function keys F1 to F24.
-
- * platform/qt/PlatformKeyboardEventQt.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
-
-2009-01-27 Brady Eidson <beidson@apple.com>
-
- Reviewed by Dan Bernstein
-
- Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
-
- * WebCore.base.exp:
- * history/CachedPage.cpp:
- * history/CachedPage.h:
- (WebCore::CachedPage::cachedMainFrame):
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::savePlatformDataToCachedFrame):
- (WebCore::EmptyFrameLoaderClient::transitionToCommittedFromCachedFrame):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::restoreDocumentState):
- (WebCore::FrameLoader::commitProvisionalLoad):
- (WebCore::FrameLoader::transitionToCommitted):
- (WebCore::FrameLoader::cachePageForHistoryItem):
- * loader/FrameLoaderClient.h:
-
-2009-01-26 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=23360
-
- Add variants of all the methods that compute dirty rects for repainting
- with versions that compute those rects relative to some container
- RenderBox that acts as a painting root.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::outlineBoundsForRepaint):
- (WebCore::RenderBox::localToContainerQuad):
- (WebCore::RenderBox::clippedOverflowRectForRepaint):
- (WebCore::RenderBox::computeRectForRepaint):
- * rendering/RenderBox.h:
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::computeRectForRepaint):
- * rendering/RenderForeignObject.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containerForRepaint):
- (WebCore::RenderObject::repaint):
- (WebCore::RenderObject::repaintRectangle):
- (WebCore::RenderObject::rectWithOutlineForRepaint):
- (WebCore::RenderObject::clippedOverflowRectForRepaint):
- (WebCore::RenderObject::computeRectForRepaint):
- (WebCore::RenderObject::localToContainerQuad):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::localToAbsoluteQuad):
- (WebCore::RenderObject::absoluteClippedOverflowRect):
- (WebCore::RenderObject::computeAbsoluteRepaintRect):
- (WebCore::RenderObject::absoluteOutlineBounds):
- (WebCore::RenderObject::outlineBoundsForRepaint):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::clippedOverflowRectForRepaint):
- (WebCore::RenderPath::outlineBoundsForRepaint):
- * rendering/RenderPath.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
- (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- * rendering/RenderSVGText.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- (WebCore::RenderTableCell::computeRectForRepaint):
- (WebCore::RenderTableCell::localToContainerQuad):
- * rendering/RenderTableCell.h:
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- * rendering/RenderTableCol.h:
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- * rendering/RenderTableRow.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::clippedOverflowRectForRepaint):
- * rendering/RenderText.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::localToContainerQuad):
- (WebCore::RenderView::computeRectForRepaint):
- * rendering/RenderView.h:
-
-2009-01-26 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by David Hyatt
-
- Back out r40285, because it was checked in with no bug number, no
- testcase, is rendering change that did not get thorough review,
- and broke the Mac build.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/EventHandler.h:
- * rendering/HitTestRequest.h:
- (WebCore::HitTestRequest::HitTestRequest):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTest):
-
-2009-01-26 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- -Make the recently added back/forward cache logging much better by actually
- walking the entire frame tree and indenting the resulting output.
- -Fix a null-termination bug in HistoryItem tree logging
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::showTreeWithIndent):
-
- * loader/FrameLoader.cpp:
- (WebCore::pageCacheLogPrefix):
- (WebCore::pageCacheLog):
- (WebCore::FrameLoader::logCanCachePageDecision):
- (WebCore::FrameLoader::logCanCacheFrameDecision):
- * loader/FrameLoader.h:
-
-2009-01-26 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Nikolas Zimmermann.
-
- Allow option of hit testing frame content without clipping to the visible
- viewport.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/EventHandler.h:
- * rendering/HitTestRequest.h:
- (WebCore::HitTestRequest::HitTestRequest):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTest):
-
-2009-01-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=18141
- Acid3 tests 77 and 78 fail on reload due to SVG font race
- <rdar://problem/6504899>
-
- Match Opera's behavior of loading SVGFonts as soon as <font-face-uri>
- tag is inserted into the document and not at the first use of the font
- as is done for CSS web fonts.
-
- This fixes a race condition noticeable by some in the Acid3 test that
- happened because the onload event handler for an iframe containing a
- <font-face-uri> with an external reference was not delayed by the pending
- load of the font.
-
- Test: http/tests/misc/SVGFont-delayed-load.html
-
- * svg/SVGFontFaceUriElement.cpp:
- (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement):
- (WebCore::SVGFontFaceUriElement::parseMappedAttribute): Call loadFont if
- the href attribute changes.
- (WebCore::SVGFontFaceUriElement::insertedIntoDocument): Call loadFont.
- (WebCore::SVGFontFaceUriElement::loadFont): Force a load of the
- font specified in href attribute.
- * svg/SVGFontFaceUriElement.h:
-
-2009-01-26 Timothy Hatcher <timothy@apple.com>
-
- Change Web Archive serialization back to the binary property list format.
-
- <rdar://problem/6127865> Web archives saved with Safari 4 cannot be read by Safari 3
-
- Reviewed by Brady Eidson.
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::rawDataRepresentation):
-
-2009-01-26 Anders Carlsson <andersca@apple.com>
-
- Fix 64-bit build.
-
- * WebCore.LP64.exp:
-
-2009-01-26 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23511
- Move DOMTimer from bindings/js to page/.
- This was prepared by moving all JSC dependencies from DOMTimer
- to ScheduledAction earlier, and helps unfork the Chromuim version
- of the DOMTimer.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/DOMTimer.cpp: Removed.
- * bindings/js/DOMTimer.h: Removed.
- * page/DOMTimer.cpp: Copied from WebCore/bindings/js/DOMTimer.cpp.
- * page/DOMTimer.h: Copied from WebCore/bindings/js/DOMTimer.h.
-
-2009-01-26 David Hyatt <hyatt@apple.com>
-
- Eliminate rightmostPosition, lowestPosition and leftmostPosition from RenderFlow. Move the code into
- RenderBlock's methods.
-
- Reviewed by Eric Seidel
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
-
-2009-01-26 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23553
- Upstream changes from jcampan to fix chromium bugs 6692 and 6694.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::setLoopSelectionNavigation):
- (WebCore::PopupListBox::PopupListBox):
- (WebCore::PopupContainer::setLoopSelectionNavigation):
- (WebCore::PopupListBox::handleKeyEvent):
- (WebCore::PopupListBox::paintRow):
- (WebCore::PopupListBox::clearSelection):
- (WebCore::PopupListBox::selectNextRow):
- (WebCore::PopupListBox::selectPreviousRow):
- * platform/chromium/PopupMenuChromium.h:
-
-2009-01-26 Brady Eidson <beidson@apple.com>
-
- Reviewed by Sam Weinig
-
- Remove some historical CachedPage time stamp fluff.
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- * history/CachedPage.h:
- (WebCore::CachedPage::timeStamp):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::cachePageForHistoryItem):
-
-2009-01-26 David Hyatt <hyatt@apple.com>
-
- Move absoluteClippedOverflowRect, linesBoundingBox and borderBoundingBox from RenderFlow to RenderInline.
-
- Reviewed by Eric Seidel
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- * rendering/RenderFlow.cpp:
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::linesBoundingBox):
- (WebCore::RenderInline::absoluteClippedOverflowRect):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::borderBoundingBox):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
-
-2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=22650
- Implement support for "Immutable" attribute to CodeGeneratorJS.pm, thus
- allowing to explicitly mark methods as immutable (i.e. returning a new
- instance rather than a reference to an existing instance).
-
- * bindings/js/JSSVGMatrixCustom.cpp: Removed custom methods.
- * bindings/scripts/CodeGeneratorJS.pm: Added check for Immutable
- attribute when generating function call.
- * svg/SVGMatrix.idl: Replaced Custom attribute with Immutable on
- methods.
-
-2009-01-26 David Hyatt <hyatt@apple.com>
-
- Eliminate isInlineFlow() now that a RenderBlock can never be an inline flow. isInlineFlow() is now
- equivalent to isRenderInline(), so all calls to isInlineFlow() have been replaced with isRenderInline().
-
- Reviewed by Eric Seidel
-
- * dom/Text.cpp:
- (WebCore::Text::rendererIsNeeded):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::shouldDrawTextDecoration):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::hitTestContents):
- (WebCore::InlineMinMaxIterator::next):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::isBlockFlow):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::clientWidth):
- (WebCore::RenderBox::clientHeight):
- (WebCore::RenderBox::nodeAtPoint):
- (WebCore::RenderBox::imageChanged):
- (WebCore::RenderBox::offsetForPositionedInContainer):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::width):
- (WebCore::RenderBox::height):
- (WebCore::RenderBox::size):
- (WebCore::RenderBox::frameRect):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::dirtyLinesFromChangedChild):
- (WebCore::RenderFlow::createInlineBox):
- (WebCore::RenderFlow::paintLines):
- (WebCore::RenderFlow::hitTestLines):
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::lowestPosition):
- (WebCore::RenderFlow::rightmostPosition):
- (WebCore::RenderFlow::leftmostPosition):
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::borderBoundingBox):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::isRenderInline):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::intersectsDamageRect):
- (WebCore::RenderLayer::boundingBox):
- * rendering/RenderListItem.cpp:
- (WebCore::getParentOfFirstLineBox):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- (WebCore::RenderObject::styleWillChange):
- (WebCore::RenderObject::firstLineStyle):
- * rendering/RenderObject.h:
- * rendering/RenderSVGInline.cpp:
- (WebCore::RenderSVGInline::createInlineBox):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::createInlineBox):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::nodeAtPoint):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::nodeAtPoint):
- * rendering/RenderText.cpp:
- (WebCore::isInlineFlowOrEmptyText):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/bidi.cpp:
- (WebCore::bidiNext):
- (WebCore::bidiFirst):
- (WebCore::appendRunsForObject):
- (WebCore::RenderBlock::createLineBoxes):
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::inlineFlowRequiresLineBox):
- (WebCore::requiresLineBox):
- (WebCore::RenderBlock::skipTrailingWhitespace):
- (WebCore::RenderBlock::skipLeadingWhitespace):
- (WebCore::RenderBlock::findNextLineBreak):
-
-2009-01-26 David Hyatt <hyatt@apple.com>
-
- Drop support for display:compact.
-
- (1) display:compact is no longer part of CSS2.1.
- (2) Shipping Safari has completely broken compact support with severely broken rendering
- (all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
- (3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
- anyone even noticing.
-
- Reviewed by Eric Seidel
-
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::handleSpecialChild):
- (WebCore::RenderBlock::handleRunInChild):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::paint):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::shouldCheckLines):
- (WebCore::getHeightForLineCount):
- (WebCore::RenderBlock::renderName):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::sizesToIntrinsicWidth):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::width):
- (WebCore::RenderBox::height):
- (WebCore::RenderBox::size):
- (WebCore::RenderBox::frameRect):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::paintLines):
- (WebCore::RenderFlow::hitTestLines):
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::linesBoundingBox):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateLayerTransform):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::RenderLayerCompositor):
+ (WebCore::RenderLayerCompositor::enableCompositingMode):
+ (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingEnabledFlag):
+ (WebCore::RenderLayerCompositor::updateCompositingLayers):
+ (WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::needsToBeComposited):
+ (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
+ * rendering/RenderLayerCompositor.h:
+ (WebCore::RenderLayerCompositor::hasAcceleratedCompositing):
* rendering/RenderObject.h:
- (WebCore::RenderObject::isInline):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
- * rendering/bidi.h:
- (WebCore::BidiRun::BidiRun):
-
-2009-01-26 Adam Langley <agl@google.com>
-
- Reviewed by Nikolas Zimmermann.
-
- gtk2drawing: fix compiler warnings
-
- g_object_set_data expects a gpointer as the last argument. Cast the
- TRUE/FALSE values to avoid a warning.
- gtk_tree_view_column_new doesn't return a GtkWidget.
-
- * platform/gtk/gtk2drawing.c:
- (setup_widget_prototype):
- (moz_gtk_get_combo_box_inner_button):
- (moz_gtk_get_combo_box_button_inner_widgets):
- (ensure_combo_box_widgets):
- (moz_gtk_get_combo_box_entry_inner_widgets):
- (moz_gtk_get_combo_box_entry_arrow):
- (ensure_combo_box_entry_widgets):
- (ensure_toolbar_widget):
- (ensure_menu_bar_item_widget):
- (ensure_menu_popup_widget):
- (ensure_menu_item_widget):
- (ensure_image_menu_item_widget):
- (ensure_menu_separator_widget):
- (ensure_check_menu_item_widget):
- (ensure_tree_header_cell_widget):
- (moz_gtk_entry_paint):
-
-2009-01-26 David Hyatt <hyatt@apple.com>
-
- Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
- Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
- inline as the new element's renderer.
-
- Reviewed by Dan Bernstein
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::handleRunInChild):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::renderName):
-
-2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23480
- Add missing method stubs to BackForwardListChromium.
-
- * history/BackForwardListChromium.cpp:
- (WebCore::BackForwardList::backItem):
- (WebCore::BackForwardList::forwardItem):
-
-2009-01-25 Darin Adler <darin@apple.com>
-
- Try to fix Tiger buildbot.
-
- * WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
- * page/mac/WebDashboardRegion.m:
- (typeName): Added.
- (-[WebDashboardRegion description]): Use typeName.
- (-[WebDashboardRegion isEqual:]): Added comment.
-
-2009-01-25 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23535
- Strengthen debug checks in KURL
-
- Covered (and prompted) by existing tests.
-
- * platform/KURL.cpp:
- (WebCore::checkEncodedString): Check that the first character of the URL is an allowed
- first scheme character, not just that it isn't a slash.
- (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
- because of parsing being idempotent).
-
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
- empty security origin is created.
- (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
- it - it is not guaranteed to be properly encoded.
-
- * dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
- string, it needs to be parsed into an URL, not just converted into one.
-
- * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
- Create the security origin with createFromString() instead of create(). I do not know where
- the string comes from and whether it might not be properly encoded, but this change can't
- hurt, and makes the code slightly more clear.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
- origin with createFromString() instead of create(). The string comes from an HTTP response
- header, so it may not be a properly encoded URL.
-
- * loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
- invalid URLs.
-
- * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
- SecurityOrigin::createFromString() (no change in behavior).
-
-2009-01-25 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- Improve the consistency of settings in our .xcconfig files.
-
- * Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS to match other projects,
- and handle all cases in GCC_GENERATE_DEBUGGING_SYMBOLS.
-
-2009-01-25 David Hyatt <hyatt@apple.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
-
- The new table code created a bug involving markAllDescendantsWithFloatsForLayout, namely that it could
- end up marking ancestors of a block as needing layout when that block was still in the process of
- doing a layout.
-
- The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
- we are "mid-layout." If this flag is set, then the method will make sure to do only local dirtying
- of objects to avoid accidentally marking a clean ancestor as needing layout again.
-
- Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
- with a check of whether or not we are mid-layout being done by those methods instead.
-
- Reviewed by Oliver Hunt
+ (WebCore::makeMatrixRenderable):
- Added fast/repaint/dynamic-table-vertical-alignment-change.html
+2009-06-25 Jian Li <jianli@chromium.org>
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::clearFloatsIfNeeded):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- * rendering/RenderBlock.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::removeFromObjectLists):
- * rendering/RenderObject.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::layoutRows):
+ Reviewed by Dimitri Glazkov.
-2009-01-25 Darin Adler <darin@apple.com>
+ Bug 26701: Implement the missing code for "FIXME: Need to return an
+ exception" in WorkerScriptController::evaluate for v8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=26701
- Reviewed by Mark Rowe.
+ * bindings/v8/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
+2009-06-25 Nate Chapin <japhet@chromium.org>
- Turn on the following warnings:
+ Reviewed by Dimitri Glazkov.
- -Wcast-qual
- -Wextra-tokens
- -Wformat=2
- -Winit-self
- -Wmissing-noreturn
- -Wpacked
- -Wrendundant-decls
+ Upstream V8Index.
- * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
- -W for clarity since we don't have to support the older versions of gcc that require the
- old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
- -Wno-format-y2k since we can have that one on now.
+ https://bugs.webkit.org/show_bug.cgi?id=26495
-2009-01-25 Dan Bernstein <mitz@apple.com>
+ * bindings/v8/V8Index.cpp: Added.
+ (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org.
+ (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
+ * bindings/v8/V8Index.h:
+ (WebCore::V8ClassIndex::): Moved from src.chromium.org.
+ (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org.
+ (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.
- Reviewed by Oliver Hunt.
+2009-06-25 Adam Langley <agl@google.com>
- - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
- string hashing code when opening a Digg RSS article
+ Reviewed by Darin Fisher.
- Test: fast/loader/null-request-after-willSendRequest.html
+ https://bugs.webkit.org/show_bug.cgi?id=26529
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): Null-check the request returned from
- the client's willSendRequest method.
+ This is hopefully the last step before our renderers can run
+ cleanly in a chroot.
-2009-01-25 David Hyatt <hyatt@apple.com>
+ WebKit needs to be able to ask for the correct font to use in
+ the case that the current font doesn't include glyphs for
+ certain code points. Currently we make a fontconfig call in our
+ WebKit port to handle this.
- Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
- instead of the ancestor overflow (23525)
+ This patch changes this so that the call is sent our via
+ ChromiumBridge.
- Make sure that we always call scroll() on the nearest enclosing RenderBox. No test case is possible
- here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
+ http://codereview.chromium.org/132007
- Reviewed by Dan Bernstein
+ This should not affect any layout tests.
- * page/EventHandler.cpp:
- (WebCore::scrollAndAcceptEvent):
- (WebCore::EventHandler::scrollOverflow):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::enclosingBox):
- * rendering/RenderObject.h:
+ * platform/chromium/ChromiumBridge.h:
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
-2009-01-25 Darin Adler <darin@apple.com>
+2009-06-25 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by David Levin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26566
+ Upstream these files from the chromium v8 code. No tests were
+ affected because this is essentially a code move.
+
+ * bindings/v8/NPV8Object.cpp: Added.
+ (allocV8NPObject):
+ (freeV8NPObject):
+ (listFromVariantArgs):
+ (npIdentifierToV8Identifier):
+ (npCreateV8ScriptObject):
+ (NPN_Invoke):
+ (NPN_InvokeDefault):
+ (NPN_Evaluate):
+ (NPN_EvaluateHelper):
+ (NPN_GetProperty):
+ (NPN_SetProperty):
+ (NPN_RemoveProperty):
+ (NPN_HasProperty):
+ (NPN_HasMethod):
+ (NPN_SetException):
+ (NPN_Enumerate):
+ (NPN_Construct):
+ * bindings/v8/NPV8Object.h: Added.
+ (PrivateIdentifier::):
+ * bindings/v8/V8NPUtils.cpp: Added.
+ (convertV8ObjectToNPVariant):
+ (convertNPVariantToV8Object):
+ (getStringIdentifier):
+ * bindings/v8/V8NPUtils.h: Added.
+
+2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>
- Reviewed by Dan Bernstein.
+ Reviewed by Dimitri Glazkov.
- Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
- https://bugs.webkit.org/show_bug.cgi?id=23538
- rdar://problem/6523719
+ https://bugs.webkit.org/show_bug.cgi?id=26436
- I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
+ Windows Chromium bug fix: save context of destination canvas in
+ TransparencyWin::compositeTextComposite() before the function
+ modifies the context.
- The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
- the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
- than doing fallback.
+ Test: fast/canvas/translate-text.html
- * rendering/RenderPartObject.cpp:
- (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
- inelegant if statement.
- (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
- (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
- (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
- return a string than an "out" parameter. Fixed the logic to only prefer the ActiveX type over the
- type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
- there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
- other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
- new havePlugin function so we handle the case where pluginData is 0.
- (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
- instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
- that knows how to handle <object> elements.
- (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
- use this data still need to be called; they still do something even if no plug-ins are present. And
- they have now been corrected to handle 0 properly.
-
-2009-01-25 Darin Adler <darin@apple.com>
-
- * rendering/RenderMenuList.cpp: Fix build by adding back needed include.
-
-2009-01-25 Darin Adler <darin@apple.com>
+ * platform/graphics/chromium/TransparencyWin.cpp:
+ (WebCore::TransparencyWin::compositeTextComposite):
- Reviewed by Sam Weinig.
+2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
+ Reviewed by Timothy Hatcher.
- Fourth patch: Deal with the last few stray warnings.
+ Show the filename and first line for "(program)" in the Profiler/Debugger
+ https://bugs.webkit.org/show_bug.cgi?id=25475
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
- Also make the local variable be a RenderBlock so the cast is closer to the code
- that guarantees it's correct.
+ Add support to associate a sourceURL with an eval()'d string
+ via a @sourceURL comment. Currently the sourceURL is only available
+ in the script debugger, not in the console or profiler, but it's
+ most needed in the script debugger.
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::writeStyle): Put the enum into a local variable that's a built-in
- type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
+ * English.lproj/localizedStrings.js: added new "(program): %s" string
+ * inspector/front-end/Script.js:
+ (WebInspector.Script): if no sourceURL is available for the Script,
+ search for a comment of the form //@ sourceURL=(url) to use
+ as the sourceURL instead.
+ * manual-tests/inspector/named-evals.html: Added.
-2009-01-25 Darin Adler <darin@apple.com>
+2009-06-25 John Gregg <johnnyg@google.com>
Reviewed by Sam Weinig.
- Bug 23522: use checked casts for render tree
- https://bugs.webkit.org/show_bug.cgi?id=23522
+ Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
+ https://bugs.webkit.org/show_bug.cgi?id=23721
- Step one: RenderText.
+ onchange events fire when a SELECT element has
+ focus and the selectedIndex is updated by script in some way--either
+ during another onchange, onkeypress, onfocus, or timer--and then
+ focus is lost.
- Also change set of RenderFlow* to be a ListHashSet as the comment in the
- header indicated.
-
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::setData): Use toRenderText.
- (WebCore::CharacterData::appendData): Ditto.
- (WebCore::CharacterData::insertData): Ditto.
- (WebCore::CharacterData::deleteData): Ditto.
- (WebCore::CharacterData::replaceData): Ditto.
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
- (WebCore::ContainerNode::getLowerRightCorner): Ditto.
- * dom/Position.cpp:
- (WebCore::nextRenderedEditable): Ditto.
- (WebCore::previousRenderedEditable): Ditto.
- (WebCore::Position::renderedOffset): Ditto. Also use function members
- instead of data members of InlineTextBox.
- (WebCore::Position::upstream): Ditto.
- (WebCore::Position::downstream): Ditto.
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
- (WebCore::Position::inRenderedText): Ditto.
- (WebCore::Position::isRenderedCharacter): Ditto.
- (WebCore::searchAheadForBetterMatch): Ditto.
- (WebCore::Position::getInlineBoxAndOffset): Ditto.
-
- * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
- included in RenderObject.h.
-
- * dom/Text.cpp:
- (WebCore::Text::splitText): Use toRenderText.
- (WebCore::Text::recalcStyle): Ditto.
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::debugRenderer): Ditto.
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::handleTextNode): Ditto.
- (WebCore::TextIterator::handleTextBox): Ditto.
- (WebCore::TextIterator::emitText): Ditto.
- (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
-
- * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
- no longer included in RenderObject.h.
- * inspector/InspectorController.cpp: Ditto.
- * page/Frame.cpp: Ditto.
- * rendering/RenderBox.cpp: Ditto.
- * rendering/RenderInline.cpp: Ditto.
- * rendering/RenderPath.cpp: Ditto.
- * rendering/RenderSVGContainer.cpp: Ditto.
- * rendering/RenderSVGImage.cpp: Ditto.
- * rendering/RenderSVGInlineText.cpp: Ditto.
- * rendering/RenderSVGTSpan.cpp: Ditto.
- * rendering/RenderSVGText.cpp: Ditto.
- * rendering/RenderSVGTextPath.cpp: Ditto.
- * rendering/RenderTableCell.cpp: Ditto.
- * rendering/RenderView.cpp: Ditto.
-
- * editing/visible_units.cpp:
- (WebCore::startPositionForLine): Use function members instead of data
- members of InlineTextBox.
- (WebCore::endPositionForLine): Ditto.
- (WebCore::startOfParagraph): Use toRenderText.
- (WebCore::endOfParagraph): Ditto.
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::deleteLine): Ditto.
- (WebCore::InlineTextBox::extractLine): Ditto.
- (WebCore::InlineTextBox::attachLine): Ditto.
- (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
- (WebCore::InlineTextBox::paintDecoration): Ditto.
- (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
- (WebCore::InlineTextBox::offsetForPosition): Ditto.
- (WebCore::InlineTextBox::positionForOffset): Ditto.
-
- * rendering/InlineTextBox.h: Made most members private. Use toRenderText.
-
- * rendering/RenderArena.cpp:
- (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
- (WebCore::RenderArena::free): Ditto.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
- instead of RenderFlowSequencedSet.
- (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
- (WebCore::stripTrailingSpace): Ditto.
- (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
- (WebCore::RenderBlock::updateFirstLetter): Ditto.
-
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addChild): Use toRenderText.
-
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
- instead of RenderFlowSequencedSet.
- (WebCore::RenderFlow::paintLines): Ditto.
-
- * rendering/RenderMenuList.cpp: Removed some unneeded includes.
-
- * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
- Made more members private.
-
- * rendering/RenderObject.cpp: Updated includes.
- (WebCore::RenderObject::isEditable): Use toRenderText.
- (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
- include VisiblePosition.h in the header just for this.
-
- * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
- Changed special vertical position values to be constants rather than an enum.
- Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
- data members of InlineTextBox.
- (WebCore::RenderText::positionForCoordinates): Ditto.
- (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
- (WebCore::RenderText::previousCharacter): Use function members instead of
- data members of InlineTextBox.
- (WebCore::RenderText::position): Ditto.
- (WebCore::RenderText::caretMinOffset): Ditto.
- (WebCore::RenderText::caretMaxOffset): Ditto.
- (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
-
- * rendering/RenderText.h: Added definition of toRenderText.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<): Use toRenderText and toRenderBox.
- (WebCore::writeTextRun): Ditto.
- (WebCore::write): Ditto.
-
- * rendering/bidi.cpp:
- (WebCore::InlineIterator::increment): Use toRenderText.
- (WebCore::InlineIterator::current): Ditto.
- (WebCore::checkMidpoints): Ditto.
- (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
- (WebCore::RenderBlock::layoutInlineChildren): Ditto.
- (WebCore::RenderBlock::determineStartPosition): Ditto.
- (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
- (WebCore::RenderBlock::findNextLineBreak): Ditto.
-
-2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix gcc compiler warning (deprecated conversion from constant string to char*)
-
- "" cannot be stored in a char*
-
- * plugins/PluginStream.cpp:
- (WebCore::PluginStream::destroyStream):
-
-2009-01-24 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
-
- Changed single argument KURL constructors back to always expect an already encoded string,
- eliminating extra conversions.
-
- This is a rather unstable situation, as it is often unclear whether a given string is safe
- to convert to KURL without resolving. I think that going forward, the solution is to try to
- keep encoded URLs as KURL instances, and not as strings.
-
- * platform/KURL.h: Updated comments.
-
- * platform/KURL.cpp:
- (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
- intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
- since encoding is scheme-dependent, such a verification would be quite complicated.
- Don't encode the string as UTF-8, as it supposed to be ASCII-only.
- Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
- any reason for it to exist, but I saw several cases where this code path was taken
- inadvertently (see examples in LayoutTests/ChangeLog).
- (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
- is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
- the old one), and an already encoded string is expected by parse().
- In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
- (WebCore::KURL::setHost): Ditto.
- (WebCore::KURL::setPort): Ditto.
- (WebCore::KURL::setHostAndPort): Ditto.
- (WebCore::KURL::setUser): Ditto.
- (WebCore::KURL::setPass): Ditto.
- (WebCore::KURL::setRef): Ditto.
- (WebCore::KURL::setQuery): Ditto.
- (WebCore::KURL::setPath): Ditto.
- (WebCore::KURL::parse): Verify that the passed string is already encoded.
-
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::parseMappedAttribute):
- (WebCore::HTMLLinkElement::process):
- * html/HTMLLinkElement.h:
- Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see
- LayoutTests/ChangeLog).
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
- (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
- String to KURL conversion requires the string to be already encoded.
-
- * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
- HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
- a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
- security origin object), so I just made the code as close to what we already had as possible.
-
-2009-01-24 Darin Adler <darin@apple.com>
-
- Try to fix Qt build.
-
- * WebCore.pro: Added JSTextCustom.cpp.
-
-2009-01-23 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23467
-
- Change styleAvailable functionality to be a linked list
- rather than scanning every CompositeAnimation for
- Animations that are waiting for styleAvailable. This has
- potential for large performance improvement in cases where
- there are many animations firing at once. But it will also
- help in my next fix, which is to synchronize software and
- accelerated animations.
-
- I also changed slightly when the beginAnimationUpdate and
- endAnimationUpdate calls are made. But this has no real
- effect on performance or behavior.
-
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- (WebCore::Document::updateRendering):
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::AnimationBase):
- (WebCore::AnimationBase::~AnimationBase):
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::next):
- (WebCore::AnimationBase::setNext):
- (WebCore::AnimationBase::styleAvailable):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
- (WebCore::AnimationControllerPrivate::addToStyleAvailableWaitList):
- (WebCore::AnimationControllerPrivate::removeFromStyleAvailableWaitList):
- (WebCore::AnimationControllerPrivate::styleAvailable):
- (WebCore::AnimationController::AnimationController):
- (WebCore::AnimationController::endAnimationUpdate):
- (WebCore::AnimationController::addToStyleAvailableWaitList):
- (WebCore::AnimationController::removeFromStyleAvailableWaitList):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::addToStyleAvailableWaitList):
- (WebCore::CompositeAnimationPrivate::removeFromStyleAvailableWaitList):
- (WebCore::CompositeAnimation::addToStyleAvailableWaitList):
- (WebCore::CompositeAnimation::removeFromStyleAvailableWaitList):
- * page/animation/CompositeAnimation.h:
-
-2009-01-24 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
-
- Test: http/tests/xmlhttprequest/encode-request-url-2.html
-
- * platform/KURL.cpp:
- (WebCore::appendASCII): Added a helper function.
- (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
- specified behavior.
- (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
- stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
- of the byte stream can use different encodings, round-tripping is not possible.
- (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
- this function convert the string to utf-8. I think that on the remanining code paths, it is
- correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
- FIXME warning.
-
-2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix after r40170
-
- * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
- and editing/RemoveNodeAttributeCommand.h
-
-2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+ Fixed by making a separate method for user-driven selectedIndex
+ changes, leaving scripts to use one which doesn't cause onchange to
+ be queued.
+
+ Test: fast/forms/select-script-onchange.html
- Fix the Qt build after r40205.
+ * dom/SelectElement.cpp: check if the pending change is user driven
+ before calling onchange
+ (WebCore::SelectElement::menuListOnChange):
+ (WebCore::SelectElement::setSelectedIndex):
+ * dom/SelectElement.h: store whether the pending change is user driven
+ (WebCore::SelectElementData::userDrivenChange):
+ (WebCore::SelectElementData::setUserDrivenChange):
+ * html/HTMLSelectElement.cpp: split into two methods -- script version
+ [non-user-driven] corresponds to IDL defined property name
+ (WebCore::HTMLSelectElement::setSelectedIndex):
+ (WebCore::HTMLSelectElement::setSelectedIndexByUser):
+ * html/HTMLSelectElement.h:
+ * rendering/RenderMenuList.cpp: use ByUser method when coming through
+ the renderer
+ (WebCore::RenderMenuList::valueChanged):
- * WebCore.pro:
+2009-06-25 Jeremy Orlow <jorlow@chromium.org>
-2009-01-23 Brady Eidson <beidson@apple.com>
+ Reviewed by Darin Fisher.
- Reviewed by Darin Adler
+ https://bugs.webkit.org/show_bug.cgi?id=26698
- In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
+ Combined LocalStorageArea and SessionStorageArea into StorageArea since
+ (after my other refactorings) there are no longer substantial
+ differences between the two.
* GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.pro:
- * WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
+ * storage/LocalStorage.cpp:
+ (WebCore::LocalStorage::storageArea):
+ * storage/LocalStorage.h:
+ * storage/LocalStorageArea.cpp: Removed.
+ * storage/LocalStorageArea.h: Removed.
+ * storage/SessionStorage.cpp:
+ (WebCore::SessionStorage::copy):
+ (WebCore::SessionStorage::storageArea):
+ * storage/SessionStorage.h:
+ * storage/SessionStorageArea.cpp: Removed.
+ * storage/SessionStorageArea.h: Removed.
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::createLocalStorage):
+ (WebCore::StorageArea::StorageArea):
+ (WebCore::StorageArea::createSessionStorage):
+ (WebCore::StorageArea::copy):
+ (WebCore::StorageArea::setItem):
+ (WebCore::StorageArea::removeItem):
+ (WebCore::StorageArea::clear):
+ (WebCore::StorageArea::scheduleFinalSync):
+ (WebCore::StorageArea::blockUntilImportComplete):
+ (WebCore::StorageArea::dispatchStorageEvent):
+ * storage/StorageArea.h:
+ * storage/StorageAreaSync.cpp:
+ (WebCore::StorageAreaSync::StorageAreaSync):
+ (WebCore::StorageAreaSync::scheduleFinalSync):
+ (WebCore::StorageAreaSync::syncTimerFired):
+ (WebCore::StorageAreaSync::performImport):
+ * storage/StorageAreaSync.h:
+ * storage/StorageSyncManager.h:
+
+2009-06-25 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=26671
+ <rdar://problem/7001880> Safari 4.0 crashes in
+ WebCore::DOMTimer::fired()
+
+ Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html
+
+ When a "style sheet candidate" element is removed from a document,
+ call Document::removeStyleSheetCandidateNode() regardless of whether
+ the document is rendered. Otherwise, the document's style sheet
+ candidate set can end up containing stale references.
- * history/CachedFrame.cpp: Added.
- (WebCore::cachedFrameCounter):
- (WebCore::CachedFrame::CachedFrame):
- (WebCore::CachedFrame::~CachedFrame):
- (WebCore::CachedFrame::restore):
- (WebCore::CachedFrame::clear):
- (WebCore::CachedFrame::setCachedFramePlatformData):
- (WebCore::CachedFrame::cachedFramePlatformData):
- * history/CachedFrame.h: Added.
- (WebCore::CachedFrame::document):
- (WebCore::CachedFrame::documentLoader):
- (WebCore::CachedFrame::view):
- (WebCore::CachedFrame::mousePressNode):
- (WebCore::CachedFrame::url):
- (WebCore::CachedFrame::domWindow):
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- (WebCore::CachedPage::clear):
- (WebCore::CachedPage::setCachedFramePlatformData):
- (WebCore::CachedPage::cachedFramePlatformData):
- * history/CachedPage.h:
- (WebCore::CachedPage::document):
- (WebCore::CachedPage::documentLoader):
- (WebCore::CachedPage::view):
- (WebCore::CachedPage::mousePressNode):
- (WebCore::CachedPage::url):
- (WebCore::CachedPage::domWindow):
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
- creating a CachedPage was a historical relic. Take the opportunity to clean that up.
-
-2009-01-23 David Hyatt <hyatt@apple.com>
-
- Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
- that triggered the ASSERT (since all of these places are effectively regressions from my landing that
- devirtualized width()/height()).
-
- Reviewed by Adele
-
- * dom/Position.cpp:
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::clientWidth):
- (WebCore::RenderBox::clientHeight):
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
- (WebCore::RenderBox::absoluteOutlineBounds):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::width):
- (WebCore::RenderBox::height):
- (WebCore::RenderBox::size):
- (WebCore::RenderBox::frameRect):
- (WebCore::RenderBox::borderBoundingBox):
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::borderBoundingBox):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::styleWillChange):
- * rendering/RenderScrollbarPart.h:
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::isKeyboardFocusable):
-
-2009-01-23 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- Second patch: Slightly less simple cases of various warnings.
-
- * bridge/jni/jni_runtime.h:
- (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
- away const.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
- reinterpret_cast; this is casting the result of malloc, and the idiom is to use
- static_cast, which works because we're casting from void*.
- (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
- C-style casts.
-
- * xml/XSLTUnicodeSort.cpp:
- (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
- instead of redefining the function.
-
-2009-01-23 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
- https://bugs.webkit.org/show_bug.cgi?id=23475
-
- * editing/TextIterator.cpp:
- (WebCore::SearchBuffer::search): Set the character start flag to false to
- ensure we won't ever return the same result twice. There are other ways we
- could accomplish this, mentioned in the comment, but this one was the smallest
- and cleanest I could think of.
-
-2009-01-23 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
- https://bugs.webkit.org/show_bug.cgi?id=23510
-
- That patch fixed the optimization that's supposed to give a faster path for
- allocating the wrappers for DOM Text objects. But CDATASection is the one
- subclass of Text objects.
-
- * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
- (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
-
- * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
- for CDATASection. We don't want to have to check when creating a wrapper for a
- Text object whether it's a CDATASection object or not, so we need to do this overload
- at compile time.
-
-2009-01-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Eric Seidel.
-
- Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
- WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
-
- WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
- Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
- from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
- base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
- another base class, just like FormControlElement.
-
- Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
- HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
- objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::removedFromDocument):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::removedFromDocument):
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::removedFromDocument):
- Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
- Add new virtual function isFormControlElementWithState() to Element.h.
+2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
- * GNUmakefile.am:
- * WebCore.order:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/Document.cpp:
- (WebCore::Document::formElementsState):
- * dom/Document.h:
- (WebCore::Document::registerFormElementWithState):
- (WebCore::Document::unregisterFormElementWithState):
- * dom/Element.h:
- (WebCore::Element::isFormControlElement):
- (WebCore::Element::isFormControlElementWithState):
- * dom/FormControlElement.cpp:
- (WebCore::toFormControlElement):
- * dom/FormControlElement.h:
- * dom/FormControlElementWithState.cpp: Added.
- (WebCore::FormControlElementWithState::registerFormControlElementWithState):
- (WebCore::FormControlElementWithState::unregisterFormControlElementWithState):
- (WebCore::FormControlElementWithState::finishParsingChildren):
- (WebCore::toFormControlElementWithState):
- * dom/FormControlElementWithState.h: Added.
- (WebCore::FormControlElementWithState::~FormControlElementWithState):
- (WebCore::FormControlElementWithState::FormControlElementWithState):
- * html/HTMLElement.h:
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
- (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
- * html/HTMLFormControlElement.h:
- (WebCore::HTMLFormControlElement::isFormControlElement):
- (WebCore::HTMLFormControlElementWithState::isFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::toFormControlElement):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::formElementIndex):
- * html/HTMLLabelElement.cpp:
- (WebCore::HTMLLabelElement::correspondingControl):
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::formElement):
- * page/Frame.cpp:
- (WebCore::Frame::searchForLabelsBeforeElement):
- (WebCore::scanForForm):
- (WebCore::Frame::currentForm):
- * page/mac/FrameMac.mm:
- (WebCore::Frame::searchForLabelsBeforeElement):
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::parseMappedAttribute):
- (WebCore::WMLCardElement::insertedIntoDocument):
- * wml/WMLCardElement.h:
- * wml/WMLDoElement.cpp:
- (WebCore::WMLDoElement::insertedIntoDocument):
- * wml/WMLElement.h:
- (WebCore::WMLElement::isWMLElement):
- * wml/WMLEventHandlingElement.cpp:
- (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
- (WebCore::WMLEventHandlingElement::registerDoElement):
- (WebCore::toWMLEventHandlingElement):
- * wml/WMLEventHandlingElement.h:
- * wml/WMLFormControlElement.cpp: Added.
- (WebCore::WMLFormControlElement::WMLFormControlElement):
- (WebCore::WMLFormControlElement::~WMLFormControlElement):
- (WebCore::WMLFormControlElementWithState::WMLFormControlElementWithState):
- (WebCore::WMLFormControlElementWithState::~WMLFormControlElementWithState):
- * wml/WMLFormControlElement.h: Added.
- (WebCore::WMLFormControlElement::isFormControlElement):
- (WebCore::WMLFormControlElement::valueMatchesRenderer):
- (WebCore::WMLFormControlElement::setValueMatchesRenderer):
- (WebCore::WMLFormControlElement::name):
- (WebCore::WMLFormControlElementWithState::isFormControlElementWithState):
- (WebCore::WMLFormControlElementWithState::toFormControlElement):
- * wml/WMLInputElement.cpp:
- (WebCore::WMLInputElement::WMLInputElement):
- (WebCore::WMLInputElement::type):
- * wml/WMLInputElement.h:
- * wml/WMLOnEventElement.cpp:
- (WebCore::WMLOnEventElement::registerTask):
- * wml/WMLOptGroupElement.cpp:
- (WebCore::WMLOptGroupElement::WMLOptGroupElement):
- (WebCore::WMLOptGroupElement::type):
- * wml/WMLOptGroupElement.h:
- * wml/WMLOptionElement.cpp:
- (WebCore::WMLOptionElement::WMLOptionElement):
- (WebCore::WMLOptionElement::type):
- * wml/WMLOptionElement.h:
- * wml/WMLTemplateElement.cpp:
- (WebCore::WMLTemplateElement::WMLTemplateElement):
- (WebCore::WMLTemplateElement::parseMappedAttribute):
- * wml/WMLTemplateElement.h:
+ Reviewed by Darin Fisher.
-2009-01-23 Chris Fleizach <cfleizach@apple.com>
+ Update CodeGeneratorV8.pm to sync up with the changes downstream.
- Reviewed by Darin Adler.
+ * bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check,
+ FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.
- Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
- https://bugs.webkit.org/show_bug.cgi?id=23509
+2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
- Add null checking in makeRange instead of AX code
+ Unreviewed, build fix.
- * editing/VisiblePosition.cpp:
- (WebCore::makeRange):
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::nextSentenceEndPosition):
- (WebCore::AccessibilityObject::previousSentenceStartPosition):
+ Add FileList.h include to fix Chromium build.
-2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+ * platform/chromium/ClipboardChromium.cpp: Added FileList.h include.
- Fix the Gtk build too after removal of RenderBox::toConstRenderBox
+2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::baselinePosition):
+ Reviewed by Jan Alonzo.
-2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+ Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
+ https://bugs.webkit.org/show_bug.cgi?id=26489
- Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
+ Fixed a Typo in a Web Inspector error message.
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::baselinePosition):
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/DatabaseQueryView.js:
+ (WebInspector.DatabaseQueryView.prototype._queryError):
-2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
- Fix the Qt build after r40168.
+ Fix the Qt build, add missing StorageAreaSync files to the build.
* WebCore.pro:
-2009-01-23 Brady Eidson <beidson@apple.com>
-
- Rubberstamped by Darin Adler
-
- Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
-
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.order:
- * WebCore.xcodeproj/project.pbxproj:
-
- * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
- (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
- * history/CachedPagePlatformData.h: Removed.
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::clear):
- (WebCore::CachedPage::setCachedFramePlatformData):
- (WebCore::CachedPage::cachedFramePlatformData):
- * history/CachedPage.h:
-
-2009-01-23 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Fix drawing in situations where sub-portions of the bitmap are to be
- drawn to the screen.
-
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
-
-2009-01-23 Kevin Ollivier <kevino@theolliviers.com>
-
- Build fixes for recent changes.
-
- * WebCoreSources.bkl:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::invalidateWindowlessPluginRect):
-
-2009-01-23 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele Peterson
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23407
-
- Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
- is never hidden (as with an <audio> element).
-
- Test: media/video-controls-visible-audio-only.html
-
- * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- (WebCore::MediaPlayerPrivate::hasVideo):
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::hasVideo):
- * platform/graphics/win/QTMovieWin.h:
-
-2009-01-23 David Hyatt <hyatt@apple.com>
-
- Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.
-
- Reviewed by Oliver Hunt
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::sizingBox):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- (WebCore::ContainerNode::getLowerRightCorner):
- * dom/Element.cpp:
- (WebCore::Element::scrollByUnits):
- * dom/Position.cpp:
- (WebCore::endsOfNodeAreVisuallyDistinctPositions):
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- (WebCore::Position::isCandidate):
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
- * editing/EditorCommand.cpp:
- (WebCore::verticalScrollDistance):
- * editing/TextIterator.cpp:
- (WebCore::shouldEmitExtraNewlineForNode):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::isFocusable):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::width):
- (WebCore::HTMLFrameElementBase::height):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseDraggedEvent):
- (WebCore::EventHandler::autoscrollTimerFired):
- (WebCore::EventHandler::updateAutoscrollRenderer):
- (WebCore::EventHandler::stopAutoscrollTimer):
- (WebCore::EventHandler::scrollOverflow):
- * page/FrameView.cpp:
- (WebCore::FrameView::layout):
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::adjustPosition):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::renderBox):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::clearFloats):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontal):
- (WebCore::RenderBox::calcAbsoluteVertical):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- * rendering/RenderBox.h:
- (WebCore::toRenderBox):
- (WebCore::RenderBox::previousSiblingBox):
- (WebCore::RenderBox::nextSiblingBox):
- (WebCore::RenderBox::parentBox):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::resize):
- (WebCore::RenderLayer::boundingBox):
- * rendering/RenderObject.cpp:
- (WebCore::addLayers):
- (WebCore::RenderObject::removeLayers):
- (WebCore::RenderObject::moveLayers):
- (WebCore::RenderObject::findNextLayer):
- (WebCore::RenderObject::enclosingLayer):
- (WebCore::RenderObject::setNeedsLayout):
- (WebCore::RenderObject::setNeedsPositionedMovementLayout):
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- (WebCore::RenderObject::computeAbsoluteRepaintRect):
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::absoluteToLocal):
- (WebCore::RenderObject::localToAbsoluteQuad):
- (WebCore::RenderObject::offsetFromContainer):
- (WebCore::RenderObject::removeFromObjectLists):
- (WebCore::RenderObject::destroy):
- (WebCore::RenderObject::updateHitTestResult):
- (WebCore::RenderObject::addDashboardRegions):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::layoutRows):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::hitTestMediaControlPart):
- (WebCore::RenderTheme::baselinePosition):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::hitTestMediaControlPart):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::externalRepresentation):
- * rendering/bidi.cpp:
- (WebCore::inlineWidth):
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::requiresLineBox):
- (WebCore::RenderBlock::findNextLineBreak):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::isKeyboardFocusable):
- * wml/WMLInputElement.cpp:
- (WebCore::isInputFocusable):
-
-2009-01-23 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
- https://bugs.webkit.org/show_bug.cgi?id=23509
-
- Add null checking around next/previous sentence retrieval in AX code
-
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::nextSentenceEndPosition):
- (WebCore::AccessibilityObject::previousSentenceStartPosition):
+2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
-2009-01-23 David Hyatt <hyatt@apple.com>
+ Reviewed by and done with Tor Arne Vestbø.
- Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
+ Fix shortcut keyboard handling with plugins on the Qt/Mac build.
- Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
- method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
- since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
+ When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
+ empty. If we're asked to disambiguate the event into a Char keyboard event,
+ we try to detect this situation and still set the text, to ensure that the
+ general event handling sends a key press event after this disambiguation.
- For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
- well.
-
- Reviewed by Oliver Hunt
-
- * WebCore.base.exp:
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- (WebCore::ContainerNode::getLowerRightCorner):
- * dom/Position.cpp:
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::linesBoundingBox):
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- * rendering/RenderInline.h:
- (WebCore::RenderInline::offsetWidth):
- (WebCore::RenderInline::offsetHeight):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::linesBoundingBox):
- * rendering/RenderText.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::write):
-
-2009-01-23 David Hyatt <hyatt@apple.com>
-
- Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
- to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
- RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
- RenderText, since none of the work done in styleWillChange was relevant to text nodes.
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
- Reviewed by Sam Weinig
+2009-06-25 Eric Seidel <eric@webkit.org>
- * dom/Document.cpp:
- (WebCore::Document::elementFromPoint):
- (WebCore::Document::renderView):
- (WebCore::Document::prepareMouseEvent):
- * dom/Document.h:
- * dom/Element.cpp:
- (WebCore::Element::scrollByUnits):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::contains):
- * html/HTMLMarqueeElement.cpp:
- (WebCore::HTMLMarqueeElement::start):
- (WebCore::HTMLMarqueeElement::stop):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::topRenderer):
- (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- * page/AccessibilityRenderObject.h:
- * page/EventHandler.cpp:
- (WebCore::scrollAndAcceptEvent):
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::handleMouseDraggedEvent):
- (WebCore::EventHandler::updateSelectionForMouseDrag):
- (WebCore::EventHandler::autoscrollTimerFired):
- (WebCore::EventHandler::updateAutoscrollRenderer):
- (WebCore::EventHandler::stopAutoscrollTimer):
- (WebCore::EventHandler::scrollOverflow):
- (WebCore::EventHandler::handleWheelEvent):
- (WebCore::EventHandler::hoverTimerFired):
- * page/Frame.cpp:
- (WebCore::Frame::clearTimers):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleWillChange):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::verticalScrollbarWidth):
- (WebCore::RenderBox::horizontalScrollbarHeight):
- (WebCore::RenderBox::scroll):
- (WebCore::RenderBox::canBeProgramaticallyScrolled):
- (WebCore::RenderBox::autoscroll):
- (WebCore::RenderBox::panScroll):
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::layer):
- (WebCore::RenderBox::requiresLayer):
- (WebCore::RenderBox::stopAutoscroll):
- (WebCore::RenderBox::hasAutoVerticalScrollbar):
- (WebCore::RenderBox::hasAutoHorizontalScrollbar):
- (WebCore::RenderBox::scrollsOverflow):
- (WebCore::RenderBox::scrollsOverflowX):
- (WebCore::RenderBox::scrollsOverflowY):
- (WebCore::RenderBox::includeVerticalScrollbarSize):
- (WebCore::RenderBox::includeHorizontalScrollbarSize):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::addFocusRingRects):
- * rendering/RenderForeignObject.cpp:
- * rendering/RenderForeignObject.h:
- (WebCore::RenderForeignObject::requiresLayer):
- * rendering/RenderInline.cpp:
- * rendering/RenderInline.h:
- (WebCore::RenderInline::requiresLayer):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::childrenClipRect):
- (WebCore::RenderLayer::selfClipRect):
- * rendering/RenderListBox.cpp:
- * rendering/RenderListBox.h:
- * rendering/RenderObject.cpp:
- (WebCore::addLayers):
- (WebCore::RenderObject::removeLayers):
- (WebCore::RenderObject::moveLayers):
- (WebCore::RenderObject::findNextLayer):
- (WebCore::RenderObject::enclosingLayer):
- (WebCore::RenderObject::setNeedsLayout):
- (WebCore::RenderObject::setNeedsPositionedMovementLayout):
- (WebCore::RenderObject::computeAbsoluteRepaintRect):
- (WebCore::RenderObject::styleWillChange):
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::absoluteToLocal):
- (WebCore::RenderObject::localToAbsoluteQuad):
- (WebCore::RenderObject::offsetFromContainer):
- (WebCore::RenderObject::destroy):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- * rendering/RenderPath.h:
- (WebCore::RenderPath::requiresLayer):
- * rendering/RenderReplica.h:
- (WebCore::RenderReplica::requiresLayer):
- * rendering/RenderSVGContainer.cpp:
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::requiresLayer):
- * rendering/RenderSVGHiddenContainer.cpp:
- * rendering/RenderSVGHiddenContainer.h:
- (WebCore::RenderSVGHiddenContainer::requiresLayer):
- * rendering/RenderSVGImage.cpp:
- * rendering/RenderSVGImage.h:
- (WebCore::RenderSVGImage::requiresLayer):
- * rendering/RenderSVGInline.h:
- (WebCore::RenderSVGInline::requiresLayer):
- * rendering/RenderSVGInlineText.h:
- (WebCore::RenderSVGInlineText::requiresLayer):
- * rendering/RenderSVGText.cpp:
- * rendering/RenderSVGText.h:
- (WebCore::RenderSVGText::requiresLayer):
- * rendering/RenderScrollbarPart.h:
- (WebCore::RenderScrollbarPart::requiresLayer):
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::setCurrentPosition):
- * rendering/RenderTableCell.cpp:
- * rendering/RenderTableCell.h:
- (WebCore::RenderTableCell::requiresLayer):
- * rendering/RenderTableCol.h:
- (WebCore::RenderTableCol::requiresLayer):
- * rendering/RenderTableRow.h:
- (WebCore::RenderTableRow::requiresLayer):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::layoutRows):
- * rendering/RenderText.h:
- (WebCore::RenderText::styleWillChange):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::autoscroll):
- (WebCore::RenderTextControl::scroll):
- * rendering/RenderTextControl.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::write):
- (WebCore::externalRepresentation):
-
-2009-01-23 Anders Carlsson <andersca@apple.com>
-
- Fix tyop.
+ Build fix only, no review.
- * editing/markup.cpp:
- (WebCore::joinMarkups):
+ Add FileList.h and NotImplemented.h includes in an attempt to fix bots.
-2009-01-23 Anders Carlsson <andersca@apple.com>
+ * platform/gtk/ClipboardGtk.cpp:
+ * platform/qt/ClipboardQt.cpp:
+ * platform/win/ClipboardWin.cpp:
+ * platform/wx/ClipboardWx.cpp:
- Reviewed by Darin Adler.
+2009-05-21 Eric Seidel <eric@webkit.org>
- * Configurations/Base.xcconfig:
- Fix GCC 4.0 build.
+ Reviewed by Maciej Stachowiak.
- * editing/markup.cpp:
- (WebCore::joinMarkups):
- Pass a const reference to the vector.
+ Expose files in the clipboard in ondrop events
+ https://bugs.webkit.org/show_bug.cgi?id=25916
- * html/HTMLElement.cpp:
- * platform/text/String.cpp:
- Add comments indicating that these functions are for use in the debugger.
+ Make it possible for applications like gmail to implement
+ drag and drop of attachments onto email messages.
-2009-01-23 Anders Carlsson <andersca@apple.com>
+ This patch exposes an event.dataTransfer.files accessor
+ on the drop event. No information is exposed during dragover.
+ This follows the HTML 5 drag and drop security model:
+ http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
+ The test http/tests/security/clipboard/clipboard-file-access.html
+ verifies this behavior.
- Reviewed by Sam Weinig.
+ Internet Explorer shows historical documentation of supporting
+ getData('File') as a way of exposing files on the pasteboard. The current version of their docs:
+ http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
+ has removed this reference (as far as I can tell IE never implemented it)
+ I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
+ IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.
- Turn on -Wmissing-prototypes and fix the resulting warnings.
+ I choose not to use IE's getData('File') and instead added .files
+ so that the accessor could have a type, matching WebKit's existing
+ .files accessor on HTMLInputElement.
- * Configurations/Base.xcconfig:
- * bindings/js/JSHistoryCustom.cpp:
- (WebCore::nonCachingStaticBackFunctionGetter):
- (WebCore::nonCachingStaticForwardFunctionGetter):
- (WebCore::nonCachingStaticGoFunctionGetter):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::nonCachingStaticReplaceFunctionGetter):
- (WebCore::nonCachingStaticReloadFunctionGetter):
- (WebCore::nonCachingStaticAssignFunctionGetter):
- (WebCore::JSLocation::customGetOwnPropertySlot):
- * bindings/objc/DOMRGBColor.mm:
- (WebCore::getWrapperForRGB):
- (WebCore::setWrapperForRGB):
- (WebCore::removeWrapperForRGB):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::globalExceptionString):
- * bridge/runtime_object.cpp:
- (JSC::callRuntimeConstructor):
- * css/CSSParser.cpp:
- (WebCore::parseGradientColorStop):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::scaleFactorForConversion):
- * css/CSSStyleSelector.cpp:
- (WebCore::operator >):
- (WebCore::operator <=):
- (WebCore::getTransformOperationType):
- * dom/make_names.pl:
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::updatePositionForTextRemoval):
- * editing/EditorCommand.cpp:
- (WebCore::valueBackColor):
- (WebCore::valueFontName):
- (WebCore::valueFontSize):
- (WebCore::valueFontSizeDelta):
- (WebCore::valueForeColor):
- * editing/VisiblePosition.cpp:
- (WebCore::canonicalizeCandidate):
- * editing/htmlediting.cpp:
- * editing/markup.cpp:
- (WebCore::joinMarkups):
- * html/HTMLElement.cpp:
- (WebCore::inlineTagList):
- (WebCore::blockTagList):
- * html/HTMLMediaElement.cpp:
- (WebCore::serializeTimeOffset):
- (WebCore::parseTimeOffset):
- * page/mac/FrameMac.mm:
- (WebCore::regExpForLabels):
- * platform/Arena.cpp:
- * platform/graphics/Color.cpp:
- (WebCore::colorFloatToRGBAByte):
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::imageSourceOptions):
- * platform/graphics/cg/PathCG.cpp:
- (WebCore::CGPathApplierToPathApplier):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::initFontData):
- * platform/mac/PlatformMouseEventMac.mm:
- * platform/text/String.cpp:
- * rendering/RenderBlock.cpp:
- (WebCore::continuationOutlineTable):
- (WebCore::getHeightForLineCount):
- * rendering/RenderView.cpp:
- (WebCore::rendererAfterPosition):
- * rendering/RootInlineBox.cpp:
- (WebCore::isEditableLeaf):
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::hasFractions):
- * rendering/style/RenderStyle.cpp:
- (WebCore::positionedObjectMoved):
- * svg/SVGFont.cpp:
- (WebCore::floatWidthUsingSVGFontCallback):
- (WebCore::floatWidthMissingGlyphCallback):
- (WebCore::drawTextUsingSVGFontCallback):
- (WebCore::drawTextMissingGlyphCallback):
- * svg/SVGTransformable.cpp:
- (WebCore::parseTransformParamList):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::operator<<):
- * xml/XPathGrammar.y:
- * xml/XSLTExtensions.cpp:
-
-2009-01-23 Eric Seidel <eric@webkit.org>
+ Mozilla has equivalent file access:
+ event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
+ which also does not return a typed value.
+ https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files
- No review, removing an empty file.
+ This is only implemented for Mac WebKit. All other platforms (including Apple's Win WebKit)
+ have incomplete Clipboard implementations and will require experts from those platforms
+ to add this functionality. Right now they all have Clipboard*::files() methods which call notImplemented();
- Remove RemoveNodeAttributeCommand since it was empty.
+ Test: http/tests/security/clipboard/clipboard-file-access.html
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * editing/RemoveNodeAttributeCommand.cpp: Removed.
- * editing/RemoveNodeAttributeCommand.h: Removed.
+ * dom/Clipboard.h:
+ * dom/Clipboard.idl:
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::files):
+ * platform/chromium/ClipboardChromium.h:
+ * platform/gtk/ClipboardGtk.cpp:
+ (WebCore::ClipboardGtk::files):
+ * platform/gtk/ClipboardGtk.h:
+ * platform/mac/ClipboardMac.h:
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::absoluteURLsFromPasteboardFilenames):
+ (WebCore::absoluteURLsFromPasteboard):
+ (WebCore::ClipboardMac::files):
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::files):
+ * platform/qt/ClipboardQt.h:
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::files):
+ * platform/win/ClipboardWin.h:
+ * platform/wx/ClipboardWx.cpp:
+ (WebCore::ClipboardWx::files):
+ * platform/wx/ClipboardWx.h:
+
+2009-06-25 Eric Seidel <eric@webkit.org>
+
+ No review, only completing revert of r45144.
+
+ Add back files deleted by r45144.
+
+ * storage/LocalStorageArea.cpp: Added.
+ (WebCore::LocalStorageArea::create):
+ (WebCore::LocalStorageArea::LocalStorageArea):
+ (WebCore::LocalStorageArea::scheduleFinalSync):
+ (WebCore::LocalStorageArea::itemChanged):
+ (WebCore::LocalStorageArea::itemRemoved):
+ (WebCore::LocalStorageArea::areaCleared):
+ (WebCore::LocalStorageArea::blockUntilImportComplete):
+ (WebCore::LocalStorageArea::dispatchStorageEvent):
+ * storage/LocalStorageArea.h: Added.
+ * storage/SessionStorageArea.cpp: Added.
+ (WebCore::SessionStorageArea::copy):
+ (WebCore::SessionStorageArea::SessionStorageArea):
+ (WebCore::SessionStorageArea::itemChanged):
+ (WebCore::SessionStorageArea::itemRemoved):
+ (WebCore::SessionStorageArea::areaCleared):
+ (WebCore::SessionStorageArea::blockUntilImportComplete):
+ (WebCore::SessionStorageArea::dispatchStorageEvent):
+ * storage/SessionStorageArea.h: Added.
+ (WebCore::SessionStorageArea::create):
-2009-01-23 Brady Eidson <beidson@apple.com>
+2009-06-25 Eric Seidel <eric@webkit.org>
- Rubberstamped by Sam Weinig
+ No review, reverting r45144 only.
- Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
+ Roll out r45144 after 18 test failures appeared on the bots.
+ https://bugs.webkit.org/show_bug.cgi?id=26698
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
+ * storage/LocalStorage.cpp:
+ (WebCore::LocalStorage::storageArea):
+ * storage/LocalStorage.h:
+ * storage/SessionStorage.cpp:
+ (WebCore::SessionStorage::copy):
+ (WebCore::SessionStorage::storageArea):
+ * storage/SessionStorage.h:
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::StorageArea):
+ (WebCore::StorageArea::~StorageArea):
+ (WebCore::StorageArea::setItem):
+ (WebCore::StorageArea::removeItem):
+ (WebCore::StorageArea::clear):
+ * storage/StorageArea.h:
+ * storage/StorageAreaSync.cpp:
+ (WebCore::StorageAreaSync::StorageAreaSync):
+ (WebCore::StorageAreaSync::scheduleFinalSync):
+ (WebCore::StorageAreaSync::syncTimerFired):
+ (WebCore::StorageAreaSync::performImport):
+ * storage/StorageAreaSync.h:
+ * storage/StorageSyncManager.h:
+
+2009-06-24 Jeremy Orlow <jorlow@chromium.org>
- * bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
- (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
- (WebCore::ScriptCachedFrameData::domWindow):
- (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
- (WebCore::ScriptCachedFrameData::restore):
- (WebCore::ScriptCachedFrameData::clear):
- * bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
- * bindings/js/ScriptCachedPageData.cpp: Removed.
- * bindings/js/ScriptCachedPageData.h: Removed.
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- * history/CachedPage.h:
-
-2009-01-23 Steve Falkenburg <sfalken@apple.com>
-
- Fix build.
-
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::baselinePosition):
-
-2009-01-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23506
- Upstream Chromium's image decoders for use with PLATFORM(SKIA)
-
- * platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
- * platform/image-decoders/skia/BMPImageDecoder.h: Added.
- * platform/image-decoders/skia/BMPImageReader.cpp: Added.
- * platform/image-decoders/skia/BMPImageReader.h: Added.
- * platform/image-decoders/skia/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
- (WebCore::GIFImageDecoderPrivate::decode):
- (WebCore::GIFImageDecoderPrivate::getColorMap):
- (WebCore::GIFImageDecoder::GIFImageDecoder):
- (WebCore::GIFImageDecoder::isSizeAvailable):
- (WebCore::GIFImageDecoder::frameCount):
- (WebCore::GIFImageDecoder::frameBufferAtIndex):
- (WebCore::GIFImageDecoder::clearFrameBufferCache):
- (WebCore::GIFImageDecoder::decode):
- (WebCore::GIFImageDecoder::sizeNowAvailable):
- (WebCore::GIFImageDecoder::initFrameBuffer):
- (WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
- (WebCore::GIFImageDecoder::haveDecodedRow):
- (WebCore::GIFImageDecoder::frameComplete):
- * platform/image-decoders/skia/GIFImageDecoder.h:
- (WebCore::GIFImageDecoder::filenameExtension):
- (WebCore::GIFImageDecoder::frameDurationAtIndex):
- (WebCore::GIFImageDecoder::):
- * platform/image-decoders/skia/GIFImageReader.cpp:
- (GIFImageReader::do_lzw):
- (GIFImageReader::read):
- * platform/image-decoders/skia/GIFImageReader.h:
- * platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
- * platform/image-decoders/skia/ICOImageDecoder.h: Added.
- * platform/image-decoders/skia/ImageDecoder.h:
- (WebCore::RefCountedNativeImageSkia::create):
- (WebCore::RefCountedNativeImageSkia::bitmap):
- (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
- (WebCore::RGBA32Buffer::):
- (WebCore::RGBA32Buffer::RGBA32Buffer):
- (WebCore::RGBA32Buffer::~RGBA32Buffer):
- (WebCore::RGBA32Buffer::operator=):
- (WebCore::RGBA32Buffer::clear):
- (WebCore::RGBA32Buffer::copyBitmapData):
- (WebCore::RGBA32Buffer::bitmap):
- (WebCore::RGBA32Buffer::setSize):
- (WebCore::RGBA32Buffer::width):
- (WebCore::RGBA32Buffer::height):
- (WebCore::RGBA32Buffer::rect):
- (WebCore::RGBA32Buffer::status):
- (WebCore::RGBA32Buffer::duration):
- (WebCore::RGBA32Buffer::disposalMethod):
- (WebCore::RGBA32Buffer::hasAlpha):
- (WebCore::RGBA32Buffer::setRect):
- (WebCore::RGBA32Buffer::setStatus):
- (WebCore::RGBA32Buffer::setDuration):
- (WebCore::RGBA32Buffer::setDisposalMethod):
- (WebCore::RGBA32Buffer::setHasAlpha):
- (WebCore::RGBA32Buffer::setRGBA):
- (WebCore::ImageDecoder::ImageDecoder):
- (WebCore::ImageDecoder::~ImageDecoder):
- (WebCore::ImageDecoder::setData):
- (WebCore::ImageDecoder::isSizeAvailable):
- (WebCore::ImageDecoder::size):
- (WebCore::ImageDecoder::frameCount):
- (WebCore::ImageDecoder::repetitionCount):
- (WebCore::ImageDecoder::supportsAlpha):
- (WebCore::ImageDecoder::failed):
- (WebCore::ImageDecoder::setFailed):
- (WebCore::ImageDecoder::clearFrameBufferCache):
- (WebCore::ImageDecoder::setSize):
- (WebCore::ImageDecoder::isOverSize):
- * platform/image-decoders/skia/JPEGImageDecoder.cpp:
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::decode):
- (WebCore::JPEGImageDecoder::isSizeAvailable):
- (WebCore::JPEGImageDecoder::outputScanlines):
- * platform/image-decoders/skia/JPEGImageDecoder.h:
- (WebCore::JPEGImageDecoder::filenameExtension):
- (WebCore::JPEGImageDecoder::supportsAlpha):
- (WebCore::JPEGImageDecoder::reader):
- * platform/image-decoders/skia/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageDecoder::PNGImageDecoder):
- (WebCore::PNGImageDecoder::isSizeAvailable):
- (WebCore::PNGImageDecoder::frameBufferAtIndex):
- (WebCore::PNGImageDecoder::decode):
- (WebCore::PNGImageDecoder::decodingFailed):
- (WebCore::PNGImageDecoder::headerAvailable):
- (WebCore::rowAvailable):
- (WebCore::PNGImageDecoder::rowAvailable):
- (WebCore::PNGImageDecoder::pngComplete):
- * platform/image-decoders/skia/PNGImageDecoder.h:
- (WebCore::PNGImageDecoder::filenameExtension):
- (WebCore::PNGImageDecoder::reader):
- * platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
- * platform/image-decoders/skia/XBMImageDecoder.h: Added.
-
-2009-01-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23506
- Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
-
- * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
-
-2009-01-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23506
- Copy existing image-decoders in preparation for landing Skia changes on top.
-
- * platform/image-decoders/skia: Added.
- * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
- * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
- * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
- * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
- * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
- * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
- * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
- * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
-
-2009-01-23 Holger Freyther <zecke@selfish.org>
-
- Unreviewed build fix.
-
- Based on https://bugs.webkit.org/show_bug.cgi?id=23498
- from craig.schlenter@gmail.com
-
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::baselinePosition):
-
-2009-01-23 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 22720: Make XMLHttpRequest work in Workers
- <https://bugs.webkit.org/show_bug.cgi?id=22720>
-
- Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
- data to be passed across threads.
-
- No observable change in behavior, so no test.
-
- * platform/network/FormData.cpp:
- (WebCore::FormData::deepCopy):
- * platform/network/FormData.h:
- * platform/network/HTTPHeaderMap.cpp:
- (WebCore::HTTPHeaderMap::copyData):
- (WebCore::HTTPHeaderMap::adopt):
- * platform/network/HTTPHeaderMap.h:
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::adopt):
- (WebCore::ResourceRequestBase::copyData):
- * platform/network/ResourceRequestBase.h:
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::adopt):
- (WebCore::ResourceResponseBase::copyData):
- * platform/network/ResourceResponseBase.h:
-
-2009-01-23 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23374
- Add WorkerRunLoop to encapsulate message queue and timer heap.
- This is first half (timer heap is added as separate patch).
-
- * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
- * WebCore.vcproj/WebCore.vcproj: Same as above.
- * WebCore.xcodeproj/project.pbxproj: Same as above
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::postTask):
- * dom/WorkerContext.h:
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- (WebCore::WorkerMessagingProxy::workerThreadCreated):
- * dom/WorkerRunLoop.cpp: Added.
- (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
- (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
- (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
- * dom/WorkerRunLoop.h: Added.
- (WebCore::WorkerRunLoop::WorkerRunLoop):
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::workerThread):
- (WebCore::WorkerThread::stop):
- * dom/WorkerThread.h:
- (WebCore::WorkerThread::runLoop):
-
-2009-01-23 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Holger Hans Peter Freyther.
-
- Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
- huge memory leak by ensuring that the timer is fired one last time on
- application tear down thus triggering the GCController thereby freeing
- JavaScript objects as well as triggering other timer based tear down methods.
-
- * platform/qt/SharedTimerQt.cpp:
- (WebCore::SharedTimerQt::~SharedTimerQt):
-
-2009-01-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23459
- Workers are not properly terminated if execution hasn't begun yet
-
- Doesn't affect observable behavior, so test case is not possible.
-
- * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
- it couldn't be called earlier.
-
-2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- [Qt] Fix the build after RenderBox refactoring in r40153.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::baselinePosition):
-
-2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Fix the build after RenderBox refactoring in r40153.
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::invalidateWindowlessPluginRect):
-
-2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Simplify the assertion.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::getWindowsContext):
- (WebCore::GraphicsContext::releaseWindowsContext):
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Move the border and padding methods from RenderObject to RenderBox.
-
- Reviewed by Oliver Hunt
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::createDeletionUI):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesVertically):
- * rendering/InlineFlowBox.h:
- (WebCore::InlineFlowBox::borderLeft):
- (WebCore::InlineFlowBox::borderRight):
- (WebCore::InlineFlowBox::paddingLeft):
- (WebCore::InlineFlowBox::paddingRight):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::clearFloats):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::paddingTop):
- (WebCore::RenderBox::paddingBottom):
- (WebCore::RenderBox::paddingLeft):
- (WebCore::RenderBox::paddingRight):
- (WebCore::RenderBox::calcHeight):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontal):
- (WebCore::RenderBox::calcAbsoluteHorizontalValues):
- (WebCore::RenderBox::calcAbsoluteVertical):
- (WebCore::RenderBox::calcAbsoluteVerticalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::borderTop):
- (WebCore::RenderBox::borderBottom):
- (WebCore::RenderBox::borderLeft):
- (WebCore::RenderBox::borderRight):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- * rendering/RenderObject.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::textBlockWidth):
- (WebCore::RenderTextControl::calcHeight):
- (WebCore::RenderTextControl::calcPrefWidths):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::repaintViewRectangle):
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
- other margin functions that have to come along for the ride).
-
- Reviewed by Oliver Hunt
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * editing/TextIterator.cpp:
- (WebCore::shouldEmitExtraNewlineForNode):
- * rendering/InlineBox.cpp:
- * rendering/InlineBox.h:
- (WebCore::InlineBox::renderBox):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::marginLeft):
- (WebCore::InlineFlowBox::marginRight):
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::isSelfCollapsingBlock):
- (WebCore::RenderBlock::adjustPositionedBlock):
- (WebCore::RenderBlock::handleCompactChild):
- (WebCore::RenderBlock::estimateVerticalPosition):
- (WebCore::getBorderPaddingMargin):
- (WebCore::RenderBlock::calcInlinePrefWidths):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcHeight):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
- (WebCore::RenderBox::hasHorizontalBordersOrPadding):
- (WebCore::RenderBox::marginTop):
- (WebCore::RenderBox::marginBottom):
- (WebCore::RenderBox::marginLeft):
- (WebCore::RenderBox::marginRight):
- (WebCore::RenderBox::isSelfCollapsingBlock):
- (WebCore::RenderBox::collapsedMarginTop):
- (WebCore::RenderBox::collapsedMarginBottom):
- (WebCore::RenderBox::isTopMarginQuirk):
- (WebCore::RenderBox::isBottomMarginQuirk):
- (WebCore::RenderBox::maxTopMargin):
- (WebCore::RenderBox::maxBottomMargin):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- * rendering/RenderObject.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::lineHeight):
- (WebCore::RenderSVGContainer::baselinePosition):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::calcHeight):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::baselinePosition):
- * rendering/bidi.cpp:
- (WebCore::getBorderPaddingMargin):
- (WebCore::inlineWidth):
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::inlineFlowRequiresLineBox):
- (WebCore::requiresLineBox):
- (WebCore::RenderBlock::findNextLineBreak):
-
-2009-01-22 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Anders Carlsson.
-
- Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
-
- Current versions of Xcode only respect it for C and Objective-C files,
- and our code doesn't currently compile if it is applied to C++ and
- Objective-C++ files.
-
- * Configurations/Base.xcconfig:
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
- intrinsicPaddingBottom just be normal non-bitfield values.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::RenderFlow):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::RenderTableCell):
- (WebCore::RenderTableCell::updateWidth):
- (WebCore::RenderTableCell::layout):
- * rendering/RenderTableCell.h:
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
- Make m_frameRect private.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paint):
- (WebCore::RenderBlock::clearFloats):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::offsetTop):
- (WebCore::RenderBox::nodeAtPoint):
- (WebCore::RenderBox::paint):
- (WebCore::RenderBox::paintCustomHighlight):
- (WebCore::RenderBox::containingBlockWidth):
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- (WebCore::RenderBox::repaintDuringLayoutIfMoved):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::layout):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::paint):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::paintReplaced):
- (WebCore::RenderImage::nodeAtPoint):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::paint):
- (WebCore::RenderListMarker::getRelativeMarkerRect):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::paint):
- (WebCore::RenderReplaced::shouldPaint):
- * rendering/RenderReplica.cpp:
- (WebCore::RenderReplica::paint):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::applyContentTransforms):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::absoluteTransform):
- (WebCore::RenderSVGRoot::nodeAtPoint):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::calcWidth):
- (WebCore::RenderTable::layout):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::paint):
- (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::setCellWidths):
- (WebCore::RenderTableSection::calcRowHeight):
- (WebCore::RenderTableSection::layoutRows):
- (WebCore::RenderTableSection::paint):
- (WebCore::RenderTableSection::nodeAtPoint):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint):
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23487.
-
- This patch completely reworks vertical alignment of table cells. The current system uses methods called borderTopExtra() and borderBottomExtra() to
- add extra space above and below the content of a cell. This system was not confined to the table code and spilled out into all the other RenderObjects.
- The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra(). height()
- also excluded the extra space, so did not accurately reflect the true size of the cell.
-
- With the new system, the table cell box is completely accurate. The extra space becomes part of the padding of the cell. Padding has been reworked so that
- additional intrinsic padding can be added on to the specified padding from style. Only the table code has to deal with the extra cell padding.
-
- localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.
-
- A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.
-
- Reviewed by Oliver Hunt
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding. This ensures that getComputedStyle continues
- to give the right answer.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getLowerRightCorner):
- * editing/visible_units.cpp:
- (WebCore::previousLinePosition):
- (WebCore::nextLinePosition):
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::overflowRect):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
- The expandsToEncloseOverhangingFloats logic has been reworked. Table cells and fieldsets did not properly handle floats that spilled into the bottom padding. The
- resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float. The switch to make the extra table cell
- space into padding exposed this issue. No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
- this change.
-
- (WebCore::RenderBlock::selectionGapRects):
- (WebCore::RenderBlock::paintSelection):
- (WebCore::RenderBlock::fillSelectionGaps):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::offsetForContents):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderBlock.h:
- Add the new simplified method for expanding to encompass overhanging floats. The method has been devirtualized and made to include all of the cases (and not just a subset).
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::absoluteRects):
- (WebCore::RenderBox::absoluteQuads):
- (WebCore::RenderBox::absoluteContentBox):
- (WebCore::RenderBox::paintBoxDecorations):
- (WebCore::RenderBox::paintMask):
- (WebCore::RenderBox::getOverflowClipRect):
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::absoluteToLocal):
- (WebCore::RenderBox::localToAbsoluteQuad):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderBox.h:
- (WebCore::RenderBox::y):
- (WebCore::RenderBox::location):
- (WebCore::RenderBox::borderBoxRect):
- (WebCore::RenderBox::offsetHeight):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addLineBoxRects):
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::paintBoxDecorations):
- (WebCore::RenderFieldset::paintMask):
- * rendering/RenderFieldset.h:
- (WebCore::RenderFieldset::avoidsFloats):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::localCaretRect):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::boundingBox):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::isPointInOverflowControl):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::absoluteToLocal):
- (WebCore::RenderObject::localToAbsoluteQuad):
- (WebCore::RenderObject::offsetFromContainer):
- (WebCore::RenderObject::paddingTop):
- (WebCore::RenderObject::paddingBottom):
- (WebCore::RenderObject::paddingLeft):
- (WebCore::RenderObject::paddingRight):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::hasOverhangingFloats):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::selectionRect):
- (WebCore::RenderReplaced::localSelectionRect):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls. Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating
- whether or not the intrinsic padding of an object should be included (by default it is). getComputedStyle needs to exclude it, which is why this argument is
- necessary.
-
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::RenderTableCell):
- (WebCore::RenderTableCell::paddingTop):
- (WebCore::RenderTableCell::paddingBottom):
- The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.
-
- (WebCore::RenderTableCell::setOverrideSize):
- When a table's override size gets altered, the intrinsic padding needs to be cleared.
-
- (WebCore::RenderTableCell::absoluteClippedOverflowRect):
- (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
- (WebCore::RenderTableCell::baselinePosition):
- (WebCore::RenderTableCell::paint):
- (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- (WebCore::RenderTableCell::paintBoxDecorations):
- (WebCore::RenderTableCell::paintMask):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderTableCell.h:
- (WebCore::RenderTableCell::setIntrinsicPaddingTop):
- (WebCore::RenderTableCell::setIntrinsicPaddingBottom):
- (WebCore::RenderTableCell::setIntrinsicPadding):
- (WebCore::RenderTableCell::clearIntrinsicPadding):
- (WebCore::RenderTableCell::intrinsicPaddingTop):
- (WebCore::RenderTableCell::intrinsicPaddingBottom):
- Add new helper methods for getting/setting a cell's intrinsic padding.
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::calcRowHeight):
- calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing. Because a cell now includes that
- extra space, it has to be subtracted out in this method.
-
- (WebCore::RenderTableSection::layoutRows):
- Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes. There was also an error where the baseline
- position mismatched leading to negative intrinsic padding being added in (this error exists in ToT). The code now properly ignores cells that don't establish
- a baseline. A number of tests progress with this change.
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::addLineBoxRects):
- Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
-
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- (WebCore::writeTextRun):
- Modify the render tree dumping code to continue to produce the same results as before. This is really a hack, since we're now capable of indicating the correct
- position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is). A future patch can remove these hacks so that the
- layout test results can all be regenerated.
-
-2009-01-22 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Remove <strong>/<em> tags when toggling bold/italic since IE inserts them instead of <b>/<i>
- https://bugs.webkit.org/show_bug.cgi?id=23486
-
- Test: editing/execCommand/toggle-styles.html
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::isHTMLStyleNode):
-
-2009-01-22 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Remove <span> turds left by editing commands
- https://bugs.webkit.org/show_bug.cgi?id=23466
-
- Tests:
- * editing/execCommand/empty-span-removal.html
- * editing/execCommand/toggle-styles.html
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::styleSpanClassString):
- (WebCore::isStyleSpan):
- (WebCore::isUnstyledStyleSpan):
- (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
- (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle):
- (WebCore::ApplyStyleCommand::removeCSSStyle):
-
-2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Eric Seidel.
-
- Rename some of the casting functions in dom/*Element.cpp:
- formControlElementForElement -> toFormControlElement
- inputElementForElement -> toInputElement
- optionElementForElement -> toOptionElement
- optionGroupElementForElement -> toOptionGroupElement
-
- Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
- The Element*->ScriptElement* helper function is already named 'toScriptElement'.
-
- * dom/FormControlElement.cpp:
- (WebCore::toFormControlElement):
- * dom/FormControlElement.h:
- * dom/InputElement.cpp:
- (WebCore::InputElement::setValueFromRenderer):
- (WebCore::toInputElement):
- * dom/InputElement.h:
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
- (WebCore::toOptionElement):
- * dom/OptionElement.h:
- * dom/OptionGroupElement.cpp:
- (WebCore::toOptionGroupElement):
- * dom/OptionGroupElement.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::paintItemForeground):
- (WebCore::RenderListBox::paintItemBackground):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::updateOptionsWidth):
- (WebCore::RenderMenuList::setTextFromOption):
- (WebCore::RenderMenuList::itemText):
- (WebCore::RenderMenuList::itemIsSelected):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::formControlElement):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::inputElement):
-
-2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by George Staikos.
-
- Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.
-
- * dom/OptionElement.cpp:
- (WebCore::optionElementForElement):
- * dom/OptionGroupElement.cpp:
- (WebCore::optionGroupElementForElement):
-
-2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454
-
- Add WML <option>/<optgroup> element support.
- Currently the implementation is stubbed, all relevant parts can be enabled
- once WMLSelectElement/SelectElement has been created.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLOptGroupElement.cpp: Added.
- (WebCore::WMLOptGroupElement::WMLOptGroupElement):
- (WebCore::WMLOptGroupElement::~WMLOptGroupElement):
- (WebCore::WMLOptGroupElement::insertBefore):
- (WebCore::WMLOptGroupElement::replaceChild):
- (WebCore::WMLOptGroupElement::removeChild):
- (WebCore::WMLOptGroupElement::appendChild):
- (WebCore::WMLOptGroupElement::removeChildren):
- (WebCore::ownerSelectElement):
- (WebCore::WMLOptGroupElement::accessKeyAction):
- (WebCore::WMLOptGroupElement::childrenChanged):
- (WebCore::WMLOptGroupElement::parseMappedAttribute):
- (WebCore::WMLOptGroupElement::attach):
- (WebCore::WMLOptGroupElement::detach):
- (WebCore::WMLOptGroupElement::setRenderStyle):
- (WebCore::WMLOptGroupElement::nonRendererRenderStyle):
- (WebCore::WMLOptGroupElement::groupLabelText):
- (WebCore::WMLOptGroupElement::recalcSelectOptions):
- * wml/WMLOptGroupElement.h: Added.
- (WebCore::WMLOptGroupElement::title):
- (WebCore::WMLOptGroupElement::valueMatchesRenderer):
- (WebCore::WMLOptGroupElement::setValueMatchesRenderer):
- (WebCore::WMLOptGroupElement::rendererIsNeeded):
- * wml/WMLOptionElement.cpp: Added.
- (WebCore::WMLOptionElement::WMLOptionElement):
- (WebCore::WMLOptionElement::~WMLOptionElement):
- (WebCore::ownerSelectElement):
- (WebCore::WMLOptionElement::accessKeyAction):
- (WebCore::WMLOptionElement::childrenChanged):
- (WebCore::WMLOptionElement::parseMappedAttribute):
- (WebCore::WMLOptionElement::attach):
- (WebCore::WMLOptionElement::detach):
- (WebCore::WMLOptionElement::setRenderStyle):
- (WebCore::WMLOptionElement::insertedIntoDocument):
- (WebCore::WMLOptionElement::selected):
- (WebCore::WMLOptionElement::setSelectedState):
- (WebCore::WMLOptionElement::value):
- (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
- (WebCore::WMLOptionElement::nonRendererRenderStyle):
- (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
- * wml/WMLOptionElement.h: Added.
- (WebCore::WMLOptionElement::valueMatchesRenderer):
- (WebCore::WMLOptionElement::setValueMatchesRenderer):
- (WebCore::WMLOptionElement::rendererIsNeeded):
- * wml/WMLTagNames.in:
-
-2009-01-22 Eric Roman <eroman@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20806
- Send referrer for history navigations.
-
- Test: http/tests/navigation/back-send-referrer.html
-
- Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem):
- (WebCore::HistoryItem::referrer):
- (WebCore::HistoryItem::setReferrer):
- (WebCore::HistoryItem::formReferrer):
- (WebCore::HistoryItem::rssFeedReferrer):
- (WebCore::HistoryItem::setRSSFeedReferrer):
- (WebCore::HistoryItem::setFormInfoFromRequest):
- * history/HistoryItem.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem):
-
-2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Eric Seidel.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465
-
- Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.
-
- Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
- optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.
-
- Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
- These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
- used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.
-
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::setSelectedState):
- (WebCore::OptionElement::collectOptionText):
- (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
- (WebCore::OptionElement::collectOptionValue):
- (WebCore::OptionElementData::OptionElementData):
- (WebCore::OptionElementData::~OptionElementData):
- * dom/OptionElement.h:
- (WebCore::OptionElementData::element):
- (WebCore::OptionElementData::value):
- (WebCore::OptionElementData::setValue):
- (WebCore::OptionElementData::label):
- (WebCore::OptionElementData::setLabel):
- (WebCore::OptionElementData::selected):
- (WebCore::OptionElementData::setSelected):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::HTMLOptionElement):
- (WebCore::HTMLOptionElement::text):
- (WebCore::HTMLOptionElement::parseMappedAttribute):
- (WebCore::HTMLOptionElement::value):
- (WebCore::HTMLOptionElement::selected):
- (WebCore::HTMLOptionElement::setSelected):
- (WebCore::HTMLOptionElement::setSelectedState):
- (WebCore::HTMLOptionElement::label):
- (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
- * html/HTMLOptionElement.h:
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::typeAheadFind):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::paintItemForeground):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::updateOptionsWidth):
- (WebCore::RenderMenuList::setTextFromOption):
- (WebCore::RenderMenuList::itemText):
-
-2009-01-22 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Justin Garcia.
-
- Bug 23464: Infinite recursion at SelectionController::setSelection
- https://bugs.webkit.org/show_bug.cgi?id=23464
-
- Check for conditions leading to infinite recursion.
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setSelection):
-
-2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
-
- * rendering/RenderBox.cpp:
-
-2009-01-22 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build after RenderBox changes.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::baselinePosition):
-
-2009-01-22 David Hyatt <hyatt@apple.com>
-
- Fix regressions in list box selection on Mac. The wrong color was being used for the list box
- background, and list box colors actually weren't even being properly fetched because of a bug in
- the RenderTheme base class. Existing pixel tests cover the bug fix.
-
- Reviewed by Jon Honeycutt
-
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
- (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
-
-2009-01-22 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 22720: Make XMLHttpRequest work in Workers
- <https://bugs.webkit.org/show_bug.cgi?id=22720>
+ Reviewed by Darin Fisher.
- Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.
+ https://bugs.webkit.org/show_bug.cgi?id=26698
- No observable change in behavior, so no test.
+ Combined LocalStorageArea and SessionStorageArea into StorageArea since
+ (after my other refactorings) there are no longer substantial
+ differences between the two.
* GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- * platform/network/HTTPHeaderMap.cpp: Added.
- (WebCore::HTTPHeaderMap::copyData):
- (WebCore::HTTPHeaderMap::adopt):
- * platform/network/HTTPHeaderMap.h:
-
-2009-01-21 David Hyatt <hyatt@apple.com>
-
- Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
- was before my landing. Fixes failing SVG focus ring tests.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::paintOutline):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::paint):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
-
-2009-01-21 David Hyatt <hyatt@apple.com>
-
- Fix Node's renderBox() method on Windows.
-
- * dom/Node.cpp:
- (WebCore::Node::renderBox):
-
-2009-01-21 David Hyatt <hyatt@apple.com>
-
- Fix RenderThemeSafari bustage on Win32.
-
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::baselinePosition):
-
-2009-01-21 David Hyatt <hyatt@apple.com>
-
- Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
- but that's a problem for another day.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
- (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
-
-2009-01-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
- <https://bugs.webkit.org/show_bug.cgi?id=23470>
-
- Add a RefPtr protector to handleWheelEvent to guard against destruction
- while processing the scroll event. Alas the absurd set of circumstances
- required to trigger this do not appear to be reproducible in DRT.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleWheelEvent):
-
-2009-01-21 David Hyatt <hyatt@apple.com>
+ * storage/LocalStorage.cpp:
+ (WebCore::LocalStorage::storageArea):
+ * storage/LocalStorage.h:
+ * storage/LocalStorageArea.cpp: Removed.
+ * storage/LocalStorageArea.h: Removed.
+ * storage/SessionStorage.cpp:
+ (WebCore::SessionStorage::copy):
+ (WebCore::SessionStorage::storageArea):
+ * storage/SessionStorage.h:
+ * storage/SessionStorageArea.cpp: Removed.
+ * storage/SessionStorageArea.h: Removed.
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::createLocalStorage):
+ (WebCore::StorageArea::StorageArea):
+ (WebCore::StorageArea::createSessionStorage):
+ (WebCore::StorageArea::copy):
+ (WebCore::StorageArea::setItem):
+ (WebCore::StorageArea::removeItem):
+ (WebCore::StorageArea::clear):
+ (WebCore::StorageArea::scheduleFinalSync):
+ (WebCore::StorageArea::blockUntilImportComplete):
+ (WebCore::StorageArea::dispatchStorageEvent):
+ * storage/StorageArea.h:
+ * storage/StorageAreaSync.cpp:
+ (WebCore::StorageAreaSync::StorageAreaSync):
+ (WebCore::StorageAreaSync::scheduleFinalSync):
+ (WebCore::StorageAreaSync::syncTimerFired):
+ (WebCore::StorageAreaSync::performImport):
+ * storage/StorageAreaSync.h:
+ * storage/StorageSyncManager.h:
+
+2009-06-24 Dan Bernstein <mitz@apple.com>
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23453
+ Reviewed by Simon Fraser.
- Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
- Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.
+ - fix <rdar://problem/7001817> REGRESSION (r41902): Base position track
+ at UCSC Genome Browser doesn't work because image map prevents img
+ from hit-testing
- Reviewed by Eric Seidel and Darin Adler
+ Test: fast/replaced/image-map-2.html
- * WebCore.base.exp:
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::sizingBox):
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- (WebCore::ContainerNode::getLowerRightCorner):
- * dom/Element.cpp:
- (WebCore::Element::offsetLeft):
- (WebCore::Element::offsetTop):
- (WebCore::Element::offsetWidth):
- (WebCore::Element::offsetHeight):
- (WebCore::Element::offsetParent):
- (WebCore::Element::clientLeft):
- (WebCore::Element::clientTop):
- (WebCore::Element::clientWidth):
- (WebCore::Element::clientHeight):
- (WebCore::Element::scrollLeft):
- (WebCore::Element::scrollTop):
- (WebCore::Element::setScrollLeft):
- (WebCore::Element::setScrollTop):
- (WebCore::Element::scrollWidth):
- (WebCore::Element::scrollHeight):
- * dom/Node.cpp:
- (WebCore::Node::renderBox):
- (WebCore::Node::getRect):
- * dom/Node.h:
- * dom/Position.cpp:
- (WebCore::endsOfNodeAreVisuallyDistinctPositions):
- (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- (WebCore::Position::isCandidate):
- * dom/PositionIterator.cpp:
- (WebCore::PositionIterator::isCandidate):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
- * editing/DeleteButtonController.cpp:
- (WebCore::isDeletableElement):
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::removeNode):
- * editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea):
- * editing/EditorCommand.cpp:
- (WebCore::verticalScrollDistance):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::willDraw):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::isFocusable):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::width):
- (WebCore::HTMLFrameElementBase::height):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::width):
- (WebCore::HTMLImageElement::height):
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::drawNodeHighlight):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- * page/FrameView.cpp:
- (WebCore::FrameView::createScrollbar):
- (WebCore::FrameView::updateDashboardRegions):
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::imageRect):
- * rendering/InlineBox.cpp:
- (WebCore::InlineBox::renderBox):
- (WebCore::InlineBox::adjustPosition):
- * rendering/InlineBox.h:
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::placeBoxesHorizontally):
- (WebCore::InlineFlowBox::verticallyAlignBoxes):
- (WebCore::InlineFlowBox::placeBoxesVertically):
- * rendering/InlineFlowBox.h:
- * rendering/RenderApplet.cpp:
- (WebCore::RenderApplet::createWidgetIfNecessary):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::overflowHeight):
- (WebCore::RenderBlock::overflowWidth):
- (WebCore::RenderBlock::overflowRect):
- (WebCore::RenderBlock::isSelfCollapsingBlock):
- (WebCore::RenderBlock::layout):
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::adjustPositionedBlock):
- (WebCore::RenderBlock::adjustFloatingBlock):
- (WebCore::RenderBlock::handleSpecialChild):
- (WebCore::RenderBlock::handlePositionedChild):
- (WebCore::RenderBlock::handleFloatingChild):
- (WebCore::RenderBlock::handleCompactChild):
- (WebCore::RenderBlock::insertCompactIfNeeded):
- (WebCore::RenderBlock::handleRunInChild):
- (WebCore::RenderBlock::collapseMargins):
- (WebCore::RenderBlock::clearFloatsIfNeeded):
- (WebCore::RenderBlock::estimateVerticalPosition):
- (WebCore::RenderBlock::determineHorizontalPosition):
- (WebCore::RenderBlock::handleBottomOfBlock):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- (WebCore::RenderBlock::layoutPositionedObjects):
- (WebCore::RenderBlock::markPositionedObjectsForLayout):
- (WebCore::RenderBlock::repaintOverhangingFloats):
- (WebCore::RenderBlock::paint):
- (WebCore::RenderBlock::paintChildren):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::paintFloats):
- (WebCore::RenderBlock::paintContinuationOutlines):
- (WebCore::clipOutPositionedObjects):
- (WebCore::RenderBlock::fillSelectionGaps):
- (WebCore::RenderBlock::fillBlockSelectionGaps):
- (WebCore::RenderBlock::leftSelectionOffset):
- (WebCore::RenderBlock::rightSelectionOffset):
- (WebCore::RenderBlock::insertPositionedObject):
- (WebCore::RenderBlock::removePositionedObject):
- (WebCore::RenderBlock::removePositionedObjects):
- (WebCore::RenderBlock::insertFloatingObject):
- (WebCore::RenderBlock::removeFloatingObject):
- (WebCore::RenderBlock::positionNewFloats):
- (WebCore::RenderBlock::newLine):
- (WebCore::RenderBlock::lowestPosition):
- (WebCore::RenderBlock::rightmostPosition):
- (WebCore::RenderBlock::leftmostPosition):
- (WebCore::RenderBlock::clearFloats):
- (WebCore::RenderBlock::addOverhangingFloats):
- (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- (WebCore::RenderBlock::getClearDelta):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::layoutColumns):
- (WebCore::RenderBlock::getBaselineOfFirstLineBox):
- (WebCore::RenderBlock::getBaselineOfLastLineBox):
- (WebCore::getHeightForLineCount):
- (WebCore::RenderBlock::adjustForBorderFit):
- * rendering/RenderBlock.h:
- (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
- (WebCore::RenderBlock::hasOverhangingFloats):
- (WebCore::RenderBlock::CompactInfo::compact):
- (WebCore::RenderBlock::CompactInfo::set):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::RenderBox):
- (WebCore::RenderBox::offsetLeft):
- (WebCore::RenderBox::offsetTop):
- (WebCore::RenderBox::offsetParent):
- (WebCore::RenderBox::clientWidth):
- (WebCore::RenderBox::clientHeight):
- (WebCore::RenderBox::scrollWidth):
- (WebCore::RenderBox::scrollHeight):
- (WebCore::RenderBox::scrollLeft):
- (WebCore::RenderBox::scrollTop):
- (WebCore::RenderBox::setScrollLeft):
- (WebCore::RenderBox::setScrollTop):
- (WebCore::RenderBox::absoluteRects):
- (WebCore::RenderBox::absoluteQuads):
- (WebCore::RenderBox::absoluteContentBox):
- (WebCore::RenderBox::absoluteContentQuad):
- (WebCore::RenderBox::absoluteOutlineBounds):
- (WebCore::RenderBox::addFocusRingRects):
- (WebCore::RenderBox::reflectionBox):
- (WebCore::RenderBox::reflectionOffset):
- (WebCore::RenderBox::reflectedRect):
- (WebCore::RenderBox::overrideWidth):
- (WebCore::RenderBox::overrideHeight):
- (WebCore::RenderBox::nodeAtPoint):
- (WebCore::RenderBox::paint):
- (WebCore::RenderBox::maskClipRect):
- (WebCore::RenderBox::repaintLayerRectsForImage):
- (WebCore::RenderBox::paintCustomHighlight):
- (WebCore::RenderBox::getOverflowClipRect):
- (WebCore::RenderBox::getClipRect):
- (WebCore::RenderBox::containingBlockWidth):
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::offsetFromContainer):
- (WebCore::RenderBox::position):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- (WebCore::RenderBox::repaintDuringLayoutIfMoved):
- (WebCore::RenderBox::calcWidth):
- (WebCore::RenderBox::calcWidthUsing):
- (WebCore::RenderBox::calcHorizontalMargins):
- (WebCore::RenderBox::calcHeight):
- (WebCore::RenderBox::calcPercentageHeight):
- (WebCore::RenderBox::calcReplacedHeightUsing):
- (WebCore::RenderBox::containingBlockWidthForPositioned):
- (WebCore::RenderBox::containingBlockHeightForPositioned):
- (WebCore::RenderBox::calcAbsoluteHorizontal):
- (WebCore::RenderBox::calcAbsoluteVertical):
- (WebCore::RenderBox::calcAbsoluteVerticalValues):
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- (WebCore::RenderBox::localCaretRect):
- (WebCore::RenderBox::lowestPosition):
- (WebCore::RenderBox::rightmostPosition):
- (WebCore::RenderBox::leftmostPosition):
- (WebCore::RenderBox::localTransform):
- * rendering/RenderBox.h:
- (WebCore::):
- (WebCore::RenderBox::x):
- (WebCore::RenderBox::y):
- (WebCore::RenderBox::width):
- (WebCore::RenderBox::height):
- (WebCore::RenderBox::setX):
- (WebCore::RenderBox::setY):
- (WebCore::RenderBox::setWidth):
- (WebCore::RenderBox::setHeight):
- (WebCore::RenderBox::location):
- (WebCore::RenderBox::size):
- (WebCore::RenderBox::setLocation):
- (WebCore::RenderBox::setSize):
- (WebCore::RenderBox::move):
- (WebCore::RenderBox::frameRect):
- (WebCore::RenderBox::setFrameRect):
- (WebCore::RenderBox::borderBoxRect):
- (WebCore::RenderBox::contentBoxRect):
- (WebCore::RenderBox::previousSiblingBox):
- (WebCore::RenderBox::nextSiblingBox):
- (WebCore::RenderBox::parentBox):
- (WebCore::RenderBox::overflowHeight):
- (WebCore::RenderBox::overflowWidth):
- (WebCore::RenderBox::setOverflowHeight):
- (WebCore::RenderBox::setOverflowWidth):
- (WebCore::RenderBox::overflowLeft):
- (WebCore::RenderBox::overflowTop):
- (WebCore::RenderBox::overflowRect):
- (WebCore::RenderBox::contentWidth):
- (WebCore::RenderBox::contentHeight):
- (WebCore::RenderBox::offsetWidth):
- (WebCore::RenderBox::offsetHeight):
- (WebCore::RenderBox::clientLeft):
- (WebCore::RenderBox::clientTop):
- (WebCore::RenderBox::availableWidth):
- (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::controlClipRect):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::layout):
- (WebCore::RenderContainer::positionForCoordinates):
- * rendering/RenderContainer.h:
- (WebCore::RenderContainer::firstChildBox):
- (WebCore::RenderContainer::lastChildBox):
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::calcPrefWidths):
- (WebCore::RenderFieldset::layoutLegend):
- (WebCore::RenderFieldset::findLegend):
- (WebCore::RenderFieldset::paintBoxDecorations):
- (WebCore::RenderFieldset::paintMask):
- * rendering/RenderFieldset.h:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::maxFilenameWidth):
- (WebCore::RenderFileUploadControl::paintObject):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::FlexBoxIterator::FlexBoxIterator):
- (WebCore::FlexBoxIterator::first):
- (WebCore::FlexBoxIterator::next):
- (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
- (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
- (WebCore::RenderFlexibleBox::layoutBlock):
- (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- (WebCore::RenderFlexibleBox::placeChild):
- (WebCore::RenderFlexibleBox::allowedChildFlex):
- * rendering/RenderFlexibleBox.h:
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::lowestPosition):
- (WebCore::RenderFlow::rightmostPosition):
- (WebCore::RenderFlow::leftmostPosition):
- (WebCore::RenderFlow::localCaretRect):
- (WebCore::RenderFlow::addFocusRingRects):
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::paint):
- (WebCore::RenderFrameSet::layout):
- (WebCore::RenderFrameSet::positionFrames):
- * rendering/RenderHTMLCanvas.cpp:
- (WebCore::RenderHTMLCanvas::paintReplaced):
- (WebCore::RenderHTMLCanvas::canvasSizeChanged):
* rendering/RenderImage.cpp:
- (WebCore::RenderImage::imageChanged):
- (WebCore::RenderImage::paintReplaced):
- (WebCore::RenderImage::nodeAtPoint):
- (WebCore::RenderImage::calcReplacedWidth):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteRects):
- (WebCore::RenderInline::boundingBoxWidth):
- (WebCore::RenderInline::boundingBoxHeight):
- (WebCore::RenderInline::positionForCoordinates):
- * rendering/RenderInline.h:
- (WebCore::RenderInline::offsetWidth):
- (WebCore::RenderInline::offsetHeight):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateTransform):
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::scrollbarCornerPresent):
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::calculateRects):
- (WebCore::RenderLayer::boundingBox):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::calcHeight):
- (WebCore::RenderListBox::controlClipRect):
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::positionListMarker):
- (WebCore::RenderListItem::paint):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::paint):
- (WebCore::RenderListMarker::layout):
- (WebCore::RenderListMarker::imageChanged):
- (WebCore::RenderListMarker::getRelativeMarkerRect):
- (WebCore::RenderListMarker::selectionRect):
- * rendering/RenderMarquee.cpp:
- (WebCore::RenderMarquee::computePosition):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::layout):
- (WebCore::RenderMedia::lowestPosition):
- (WebCore::RenderMedia::rightmostPosition):
- (WebCore::RenderMedia::leftmostPosition):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::controlClipRect):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::RenderObject):
- (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout):
- (WebCore::RenderObject::paintOutline):
- (WebCore::RenderObject::addLineBoxRects):
- (WebCore::RenderObject::absoluteBoundingBoxRect):
- (WebCore::RenderObject::addAbsoluteRectForLayer):
- (WebCore::RenderObject::paintingRootRect):
- (WebCore::RenderObject::container):
- (WebCore::RenderObject::removeFromObjectLists):
- (WebCore::RenderObject::updateHitTestResult):
- (WebCore::RenderObject::addDashboardRegions):
- (WebCore::RenderObject::localTransform):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isBox):
- (WebCore::RenderObject::hasMask):
- (WebCore::RenderObject::setIsText):
- (WebCore::RenderObject::setIsBox):
- (WebCore::RenderObject::borderTop):
- (WebCore::RenderObject::borderBottom):
- (WebCore::RenderObject::absoluteRects):
- (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
- (WebCore::RenderObject::absoluteQuads):
- (WebCore::RenderObject::hasReflection):
- (WebCore::RenderObject::addFocusRingRects):
- (WebCore::RenderObject::absoluteOutlineBounds):
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::updateWidgetPosition):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::layout):
- (WebCore::RenderPath::paint):
- (WebCore::RenderPath::absoluteOutlineBounds):
- * rendering/RenderPath.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::layout):
- (WebCore::RenderReplaced::paint):
- (WebCore::RenderReplaced::shouldPaint):
- (WebCore::RenderReplaced::positionForCoordinates):
- (WebCore::RenderReplaced::localSelectionRect):
- (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
- (WebCore::RenderReplaced::overflowRect):
- * rendering/RenderReplica.cpp:
- (WebCore::RenderReplica::layout):
- (WebCore::RenderReplica::calcPrefWidths):
- (WebCore::RenderReplica::paint):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::paint):
- (WebCore::RenderSVGContainer::absoluteOutlineBounds):
- * rendering/RenderSVGContainer.h:
- (WebCore::RenderSVGContainer::width):
- (WebCore::RenderSVGContainer::height):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::layout):
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
- (WebCore::RenderSVGInlineText::positionForCoordinates):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- (WebCore::RenderSVGRoot::applyContentTransforms):
- (WebCore::RenderSVGRoot::paint):
- (WebCore::RenderSVGRoot::absoluteTransform):
- (WebCore::RenderSVGRoot::nodeAtPoint):
- * rendering/RenderSVGTSpan.cpp:
- (WebCore::RenderSVGTSpan::absoluteRects):
- (WebCore::RenderSVGTSpan::absoluteQuads):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::layout):
- (WebCore::RenderSVGText::relativeBBox):
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::absoluteRects):
- (WebCore::RenderSVGTextPath::absoluteQuads):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::createCustomScrollbar):
- (WebCore::RenderScrollbar::RenderScrollbar):
- (WebCore::RenderScrollbar::setParent):
- * rendering/RenderScrollbar.h:
- (WebCore::RenderScrollbar::owningRenderer):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::layout):
- (WebCore::RenderScrollbarPart::layoutHorizontalPart):
- (WebCore::RenderScrollbarPart::layoutVerticalPart):
- (WebCore::RenderScrollbarPart::computeScrollbarWidth):
- (WebCore::RenderScrollbarPart::computeScrollbarHeight):
- (WebCore::RenderScrollbarPart::paintIntoRect):
- * rendering/RenderSlider.cpp:
- (WebCore::HTMLSliderThumbElement::defaultEventHandler):
- (WebCore::RenderSlider::layout):
- (WebCore::RenderSlider::mouseEventIsInThumb):
- (WebCore::RenderSlider::positionForOffset):
- (WebCore::RenderSlider::trackSize):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::calcWidth):
- (WebCore::RenderTable::layout):
- (WebCore::RenderTable::paint):
- (WebCore::RenderTable::getBaselineOfFirstLineBox):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::updateWidth):
- (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
- (WebCore::RenderTableCell::localToAbsolute):
- (WebCore::RenderTableCell::absoluteToLocal):
- (WebCore::RenderTableCell::localToAbsoluteQuad):
- (WebCore::RenderTableCell::paint):
- (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- * rendering/RenderTableCell.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addChild):
- (WebCore::RenderTableSection::addCell):
- (WebCore::RenderTableSection::setCellWidths):
- (WebCore::RenderTableSection::calcRowHeight):
- (WebCore::RenderTableSection::layoutRows):
- (WebCore::RenderTableSection::lowestPosition):
- (WebCore::RenderTableSection::rightmostPosition):
- (WebCore::RenderTableSection::leftmostPosition):
- (WebCore::RenderTableSection::getBaselineOfFirstLineBox):
- (WebCore::RenderTableSection::paint):
- (WebCore::RenderTableSection::recalcCells):
- (WebCore::RenderTableSection::nodeAtPoint):
- * rendering/RenderTableSection.h:
- (WebCore::RenderTableSection::overflowWidth):
- (WebCore::RenderTableSection::overflowHeight):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
- (WebCore::RenderText::boundingBoxX):
- (WebCore::RenderText::boundingBoxY):
- (WebCore::RenderText::firstRunX):
- (WebCore::RenderText::firstRunY):
- (WebCore::RenderText::boundingBoxHeight):
- (WebCore::RenderText::boundingBoxWidth):
- * rendering/RenderText.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::textBlockHeight):
- (WebCore::RenderTextControl::textBlockWidth):
- (WebCore::RenderTextControl::setSelectionRange):
- (WebCore::RenderTextControl::calcHeight):
- (WebCore::RenderTextControl::hitInnerTextBlock):
- (WebCore::RenderTextControl::controlClipRect):
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::layout):
- (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::forwardEvent):
- (WebCore::RenderTextControlSingleLine::textBlockWidth):
- (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::hitTestMediaControlPart):
- (WebCore::RenderTheme::baselinePosition):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
- (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- (WebCore::RenderThemeMac::hitTestMediaControlPart):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::operator<<):
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::videoBox):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::RenderView):
- (WebCore::RenderView::calcHeight):
- (WebCore::RenderView::calcWidth):
- (WebCore::RenderView::layout):
- (WebCore::RenderView::viewRect):
- (WebCore::RenderView::docHeight):
- (WebCore::RenderView::docWidth):
- (WebCore::RenderView::setBestTruncatedAt):
- * rendering/RenderView.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::paint):
- (WebCore::RenderWidget::updateWidgetPosition):
- (WebCore::RenderWidget::nodeAtPoint):
- * rendering/RootInlineBox.h:
- (WebCore::RootInlineBox::floats):
- (WebCore::RootInlineBox::floatsPtr):
- * rendering/SVGInlineFlowBox.cpp:
- (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
- * rendering/SVGInlineFlowBox.h:
- * rendering/SVGRenderTreeAsText.cpp:
- (WebCore::operator<<):
- (WebCore::write):
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
- (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- * rendering/SVGRootInlineBox.h:
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- (WebCore::RenderBlock::computeVerticalPositionsForLine):
- (WebCore::RenderBlock::layoutInlineChildren):
- (WebCore::RenderBlock::determineStartPosition):
- (WebCore::RenderBlock::matchedEndLine):
- (WebCore::RenderBlock::skipTrailingWhitespace):
- (WebCore::RenderBlock::skipLeadingWhitespace):
- (WebCore::RenderBlock::fitBelowFloats):
- (WebCore::RenderBlock::findNextLineBreak):
- (WebCore::RenderBlock::checkLinesForOverflow):
- * svg/SVGLength.cpp:
- (WebCore::SVGLength::PercentageOfViewport):
-
-2009-01-21 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- * WebCore.LP64.exp:
- Add some bridge related symbols.
+ (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if
+ the image map failed the hit test.
- * WebCore.xcodeproj/project.pbxproj:
- Make runtime_object.h a private header.
-
-2009-01-20 David Levin <levin@chromium.org>
+2009-06-22 Adam Barth <abarth@webkit.org>
- Reviewed by Alexey Proskuryakov.
-
- Bug 22720: Make XMLHttpRequest work in Workers
- <https://bugs.webkit.org/show_bug.cgi?id=22720>
+ Reviewed by Dimitri Glazkov.
- More removal of document usage from XMLHttpRequest.
- * Abstracted away the sync and async requests behind the ThreadableLoader class, which
- will get an implementation for Workers. ThreadableLoader follows the same model as
- SubresourceLoader because DocumentThreadableLoader is a thin wrapper around SubresourceLoader.
- Also, WorkerThreadableLoader (coming soon) will use DocumentThreadableLoader to get things done.
- * Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode
- which handles workers.
+ https://bugs.webkit.org/show_bug.cgi?id=26366
- No observable change in behavior, so no test.
+ Refactor V8DOMMap to support isolated worlds.
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * loader/DocumentThreadableLoader.cpp: Added.
- (WebCore::DocumentThreadableLoader::create):
- (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
- (WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
- (WebCore::DocumentThreadableLoader::cancel):
- (WebCore::DocumentThreadableLoader::willSendRequest):
- (WebCore::DocumentThreadableLoader::didSendData):
- (WebCore::DocumentThreadableLoader::didReceiveResponse):
- (WebCore::DocumentThreadableLoader::didReceiveData):
- (WebCore::DocumentThreadableLoader::didFinishLoading):
- (WebCore::DocumentThreadableLoader::didFail):
- (WebCore::DocumentThreadableLoader::receivedCancellation):
- * loader/DocumentThreadableLoader.h: Added.
- (WebCore::DocumentThreadableLoader::refThreadableLoader):
- (WebCore::DocumentThreadableLoader::derefThreadableLoader):
- * loader/SubresourceLoaderClient.h:
- (WebCore::SubresourceLoaderClient::didReceiveData):
- * loader/ThreadableLoader.cpp: Added.
- (WebCore::ThreadableLoader::create):
- (WebCore::ThreadableLoader::loadResourceSynchronously):
- * loader/ThreadableLoader.h: Added.
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::evaluateInNewWorld):
+ * bindings/v8/ScriptController.h:
+ * bindings/v8/V8DOMMap.cpp:
+ (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap):
+ (WebCore::DOMDataStore::allStores):
+ (WebCore::DOMDataStore::allStoresMutex):
+ (WebCore::DOMDataStore::domData):
+ (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
+ (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
+ (WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::):
- (WebCore::ThreadableLoader::ref):
- (WebCore::ThreadableLoader::deref):
- (WebCore::ThreadableLoader::~ThreadableLoader):
- * loader/ThreadableLoaderClient.h: Added.
- (WebCore::ThreadableLoaderClient::didSendData):
- (WebCore::ThreadableLoaderClient::didReceiveResponse):
- (WebCore::ThreadableLoaderClient::didReceiveData):
- (WebCore::ThreadableLoaderClient::didFinishLoading):
- (WebCore::ThreadableLoaderClient::didFail):
- (WebCore::ThreadableLoaderClient::didGetCancelled):
- (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
- (WebCore::ThreadableLoaderClient::~ThreadableLoaderClient):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
- (WebCore::XMLHttpRequest::send):
- (WebCore::XMLHttpRequest::loadRequestSynchronously):
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::setRequestHeader):
- (WebCore::XMLHttpRequest::processSyncLoadResults):
- (WebCore::XMLHttpRequest::didFail):
- (WebCore::XMLHttpRequest::didGetCancelled):
- (WebCore::XMLHttpRequest::didFinishLoading):
- (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
- (WebCore::XMLHttpRequest::didSendData):
- (WebCore::XMLHttpRequest::didReceiveResponse):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
- (WebCore::XMLHttpRequest::didReceiveData):
- * xml/XMLHttpRequest.h:
-
-2009-01-19 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23317
-
- The high CPU usage was really from repeatedly firing transitions caused
- by a bug in the way we handle background-color animations. If animating
- from a valid background color to no background color, we sometimes left
- (based on timing) the background color as transparent black, but valid
- rather than invalid, which it should be. Fixing that got rid of the
- repeated firing.
-
- But we really were doing more expensive iteration of all objects with
- animations or transitions on them (running or not). So I added two
- optimizations to quickly short circuit when an object had no running
- animations or transitions. Things are now as zippy as ever.
-
- Test: transitions/repeated-firing-background-color.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::hasAnimations):
- (WebCore::CompositeAnimationPrivate::clearRenderer):
- (WebCore::CompositeAnimationPrivate::animate):
- (WebCore::CompositeAnimationPrivate::setAnimating):
- (WebCore::CompositeAnimationPrivate::willNeedService):
- (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
- (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
- (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
- (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
- (WebCore::CompositeAnimationPrivate::suspendAnimations):
- (WebCore::CompositeAnimationPrivate::resumeAnimations):
- (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
- (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
- (WebCore::CompositeAnimationPrivate::styleAvailable):
- (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
- (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
- (WebCore::CompositeAnimation::hasAnimations):
- * page/animation/CompositeAnimation.h:
-
-2009-01-21 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Remove the style='' turds left by some editing commands
- https://bugs.webkit.org/show_bug.cgi?id=23463
-
- Test: editing/execCommand/toggle-styles.html
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
-
-2009-01-21 Eric Seidel <eric@webkit.org>
-
- No review, build fix.
-
- Fix release-only build failure (and do a tiny code-cleanup).
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::createFontElement):
- (WebCore::createStyleSpanElement):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
-
-2009-01-21 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility()
- https://bugs.webkit.org/show_bug.cgi?id=23443
-
- Test: accessibility/table-modification-crash.html
-
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::updateBackingStore):
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::childrenChanged):
- (WebCore::AccessibilityRenderObject::children):
- (WebCore::AccessibilityRenderObject::updateBackingStore):
- * page/AccessibilityRenderObject.h:
- (WebCore::AccessibilityRenderObject::markChildrenDirty):
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::AccessibilityTable):
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityActionNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
- (-[AccessibilityObjectWrapper accessibilityHitTest:]):
- (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
- (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
- (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
- (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
- (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::destroy):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy):
-
-2009-01-16 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
- https://bugs.webkit.org/show_bug.cgi?id=17733
-
- Test changed: editing/execCommand/toggle-styles-expected.txt
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::StyleChange::applySubscript):
- (WebCore::StyleChange::applySuperscript):
- (WebCore::StyleChange::StyleChange):
- (WebCore::StyleChange::init):
- (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
- (WebCore::ApplyStyleCommand::isHTMLStyleNode):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- * editing/EditorCommand.cpp:
- (WebCore::executeSubscript):
- (WebCore::executeSuperscript):
- * editing/htmlediting.cpp:
- (WebCore::createHTMLElement):
- * editing/htmlediting.h:
-
-2009-01-21 Anders Carlsson <andersca@apple.com>
-
- Fix 64-bit build.
-
- * WebCore.LP64.exp:
-
-2009-01-21 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
- <https://bugs.webkit.org/show_bug.cgi?id=23458>
-
- Return CanvasPixelArray, et al -- the only difference between this
- and the original CPA implementation is that it now uses a ByteArray
- rather than a vector. JSC still uses a custom wrapper, but this allows
- ObjC, COM, and V8 bindings to be autogenerated again.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * html/CanvasPixelArray.cpp: Added.
- (WebCore::CanvasPixelArray::create):
- (WebCore::CanvasPixelArray::CanvasPixelArray):
- * html/CanvasPixelArray.h: Added.
- (WebCore::CanvasPixelArray::data):
- (WebCore::CanvasPixelArray::length):
- (WebCore::CanvasPixelArray::set):
- (WebCore::CanvasPixelArray::get):
- * html/CanvasPixelArray.idl: Added.
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::createEmptyImageData):
- * html/ImageData.cpp:
- (WebCore::ImageData::ImageData):
- * html/ImageData.h:
- (WebCore::ImageData::data):
- * html/ImageData.idl:
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- * platform/graphics/cg/ImageBufferCG.cpp:
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
-
-2009-01-21 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Remove last relics of platform dependent PaintServer in SVG.
- We draw everything with the help of GraphicsContext.
-
- Remove SVGPaintServerPlatform's
- [https://bugs.webkit.org/show_bug.cgi?id=23439]
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * svg/graphics/SVGPaintServer.cpp:
- (WebCore::SVGPaintServer::draw):
- (WebCore::SVGPaintServer::renderPath):
- (WebCore::SVGPaintServer::teardown):
- * svg/graphics/SVGPaintServer.h:
- * svg/graphics/SVGPaintServerGradient.cpp:
- * svg/graphics/SVGPaintServerGradient.h:
- * svg/graphics/SVGPaintServerPattern.cpp:
- * svg/graphics/SVGPaintServerPattern.h:
- * svg/graphics/SVGPaintServerSolid.cpp:
- * svg/graphics/SVGPaintServerSolid.h:
- * svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
- * svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
- * svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
-
-2009-01-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Move "Element -> ScriptElement" casting functionality into ScriptElement.h
- to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.
-
- It was living in XMLTokenizer before, which is not an obvious place for this.
- TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
- as suggested by Alexey, it really reads better this way.
-
- * dom/ScriptElement.cpp:
- (WebCore::toScriptElement):
- * dom/ScriptElement.h:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * dom/XMLTokenizer.h:
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::startElementNs):
- (WebCore::XMLTokenizer::endElementNs):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseStartElement):
- (WebCore::XMLTokenizer::parseEndElement):
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444
-
- Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
- in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
- has been done before for FormControlElement and RenderTextControl.
-
- This is needed to prepare the addtion of WMLOption/OptGroupElement.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/OptionElement.cpp: Added.
- (WebCore::optionElementForElement):
- * dom/OptionElement.h: Added.
- (WebCore::OptionElement::~OptionElement):
- (WebCore::OptionElement::OptionElement):
- * dom/OptionGroupElement.cpp: Added.
- (WebCore::optionGroupElementForElement):
- * dom/OptionGroupElement.h: Added.
- (WebCore::OptionGroupElement::~OptionGroupElement):
- (WebCore::OptionGroupElement::OptionGroupElement):
- * html/HTMLOptGroupElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::optionText):
- * html/HTMLOptionElement.h:
- (WebCore::HTMLOptionElement::selected):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::paintItemForeground):
- (WebCore::RenderListBox::paintItemBackground):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::updateOptionsWidth):
- (WebCore::RenderMenuList::setTextFromOption):
- (WebCore::RenderMenuList::itemText):
- (WebCore::RenderMenuList::itemIsSelected):
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
- https://bugs.webkit.org/show_bug.cgi?id=23448
-
- * platform/graphics/cg/ImageSourceCGMac.mm:
- (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- Try to fix Wx build.
-
- * platform/wx/PasteboardWx.cpp:
- (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash
- with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing
- to the clipboard. Other platforms don't do it. If it was needed, the new function
- to use would be displayStringModifiedByEncoding.
-
-2009-01-19 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Mitz Pettel.
-
- Fixes https://bugs.webkit.org/show_bug.cgi?id=23423.
-
- The Windows Cairo post-build targets (Release/Debug) do not
- copy all of the headers that the CG-based build does.
-
- * WebCore.vcproj/WebCore.vcproj: Extend WebCore Cairo build targets
- to copy the page/animation/*.h files into WebKitBuild so that
- WebKit can find them.
-
-2009-01-20 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23413
- Remove unused WebCore::setDeferringTimers()
-
- * platform/Timer.cpp:
- (WebCore::updateSharedTimer):
- * platform/Timer.h:
-
-2009-01-20 David Hyatt <hyatt@apple.com>
-
- Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
- m_renderer to be consistent with the corresponding member function.
-
- Reviewed by Jon Honeycutt
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::updateVisibilityStatus):
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::stackingContext):
- (WebCore::RenderLayer::enclosingPositionedAncestor):
- (WebCore::RenderLayer::enclosingTransformedAncestor):
- (WebCore::RenderLayer::isTransparent):
- (WebCore::RenderLayer::convertToLayerCoords):
- (WebCore::RenderLayer::scrollByRecursively):
- (WebCore::RenderLayer::scrollToOffset):
- (WebCore::RenderLayer::scrollRectToVisible):
- (WebCore::RenderLayer::resize):
- (WebCore::RenderLayer::scrollbarCornerPresent):
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::setHasHorizontalScrollbar):
- (WebCore::RenderLayer::setHasVerticalScrollbar):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::computeScrollDimensions):
- (WebCore::RenderLayer::updateOverflowStatus):
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::isPointInResizeControl):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::updateClipRects):
- (WebCore::RenderLayer::calculateClipRects):
- (WebCore::RenderLayer::calculateRects):
- (WebCore::RenderLayer::clearClipRects):
- (WebCore::RenderLayer::repaintIncludingDescendants):
- (WebCore::RenderLayer::styleChanged):
- (WebCore::RenderLayer::updateScrollCornerStyle):
- (WebCore::RenderLayer::updateResizerStyle):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::renderer):
- (WebCore::RenderLayer::hasReflection):
- (WebCore::RenderLayer::hasTransform):
-
-2009-01-20 David Hyatt <hyatt@apple.com>
-
- Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
- for returning the appropriate listbox selection colors.
-
- Reviewed by Adele
-
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
- (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
- (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
-
-2009-01-20 Dave Hyatt <hyatt@apple.com>
-
- Fix for focus rings on Windows. Make sure that focus rings draw for all controls but buttons.
-
- Fix list box selection colors on Windows. Also add a cache for all of the selection colors (and not just the two
- background selection colors).
-
- Reviewed by Adam Roben
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::selectionForegroundColor):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::activeSelectionBackgroundColor):
- (WebCore::RenderTheme::inactiveSelectionBackgroundColor):
- (WebCore::RenderTheme::activeSelectionForegroundColor):
- (WebCore::RenderTheme::inactiveSelectionForegroundColor):
- (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
- (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
- (WebCore::RenderTheme::platformActiveSelectionForegroundColor):
- (WebCore::RenderTheme::platformInactiveSelectionBackgroundColor):
- (WebCore::RenderTheme::platformInactiveSelectionForegroundColor):
- (WebCore::RenderTheme::platformActiveListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::platformActiveListBoxSelectionForegroundColor):
- (WebCore::RenderTheme::platformInactiveListBoxSelectionBackgroundColor):
- (WebCore::RenderTheme::platformInactiveListBoxSelectionForegroundColor):
- (WebCore::RenderTheme::platformColorsDidChange):
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::supportsForegroundSelectionColors):
- (WebCore::RenderTheme::supportsForegroundListBoxSelectionColors):
- * rendering/RenderThemeMac.h:
- (WebCore::RenderThemeMac::supportsForegroundSelectionColors):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor):
- (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor):
- (WebCore::RenderThemeWin::supportsFocus):
- (WebCore::RenderThemeWin::supportsFocusRing):
- * rendering/RenderThemeWin.h:
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434
-
- Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
- Now any language can provide <input>-style elements, without having to inherit from HTML* classes.
-
- No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
- Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
- Detailed testcases will follow in conjunction with the WML specific attribute support.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * dom/FormControlElement.cpp: Activate disabled code from previous checking.
- (WebCore::formControlElementForElement):
- * dom/InputElement.cpp: Ditto.
- (WebCore::inputElementForElement):
- * wml/WMLInputElement.cpp: Added.
- (WebCore::WMLInputElement::WMLInputElement):
- (WebCore::WMLInputElement::~WMLInputElement):
- (WebCore::isInputFocusable):
- (WebCore::WMLInputElement::isKeyboardFocusable):
- (WebCore::WMLInputElement::isMouseFocusable):
- (WebCore::WMLInputElement::dispatchFocusEvent):
- (WebCore::WMLInputElement::dispatchBlurEvent):
- (WebCore::WMLInputElement::updateFocusAppearance):
- (WebCore::WMLInputElement::aboutToUnload):
- (WebCore::WMLInputElement::size):
- (WebCore::WMLInputElement::name):
- (WebCore::WMLInputElement::value):
- (WebCore::WMLInputElement::setValue):
- (WebCore::WMLInputElement::setValueFromRenderer):
- (WebCore::WMLInputElement::saveState):
- (WebCore::WMLInputElement::restoreState):
- (WebCore::WMLInputElement::select):
- (WebCore::WMLInputElement::accessKeyAction):
- (WebCore::WMLInputElement::parseMappedAttribute):
- (WebCore::WMLInputElement::copyNonAttributeProperties):
- (WebCore::WMLInputElement::createRenderer):
- (WebCore::WMLInputElement::attach):
- (WebCore::WMLInputElement::detach):
- (WebCore::WMLInputElement::appendFormData):
- (WebCore::WMLInputElement::reset):
- (WebCore::WMLInputElement::defaultEventHandler):
- (WebCore::WMLInputElement::cacheSelection):
- (WebCore::WMLInputElement::constrainValue):
- (WebCore::WMLInputElement::documentDidBecomeActive):
- (WebCore::WMLInputElement::placeholderShouldBeVisible):
- (WebCore::WMLInputElement::willMoveToNewOwnerDocument):
- (WebCore::WMLInputElement::didMoveToNewOwnerDocument):
- * wml/WMLInputElement.h: Added.
- (WebCore::WMLInputElement::valueMatchesRenderer):
- (WebCore::WMLInputElement::setValueMatchesRenderer):
- (WebCore::WMLInputElement::shouldUseInputMethod):
- (WebCore::WMLInputElement::isChecked):
- (WebCore::WMLInputElement::isIndeterminate):
- (WebCore::WMLInputElement::isTextControl):
- (WebCore::WMLInputElement::isRadioButton):
- (WebCore::WMLInputElement::isTextField):
- (WebCore::WMLInputElement::isSearchField):
- (WebCore::WMLInputElement::isInputTypeHidden):
- (WebCore::WMLInputElement::isPasswordField):
- (WebCore::WMLInputElement::searchEventsShouldBeDispatched):
- (WebCore::WMLInputElement::placeholderValue):
- * wml/WMLTagNames.in:
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- Reviewed by John Sullivan.
-
- Remove a little dead code left over after the fix for
- https://bugs.webkit.org/show_bug.cgi?id=11395, which
- moved pointer-events from SVG to be shared with HTML.
-
- * css/SVGCSSParser.cpp:
- (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this
- property since it's handled in the non-SVG function now so we'll
- never get here.
-
-2009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 23438: Provide a default value to the .in file parser
+ (WebCore::MainThreadDOMData::MainThreadDOMData):
+ (WebCore::MainThreadDOMData::getStore):
+ (WebCore::ChildThreadDOMData::ChildThreadDOMData):
+ (WebCore::ChildThreadDOMData::getStore):
+ (WebCore::DOMDataStore::DOMDataStore):
+ (WebCore::DOMDataStore::~DOMDataStore):
+ (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
+ (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
+ (WebCore::::forget):
+ (WebCore::getDOMNodeMap):
+ (WebCore::getDOMObjectMap):
+ (WebCore::getActiveDOMObjectMap):
+ (WebCore::getDOMSVGElementInstanceMap):
+ (WebCore::getDOMSVGObjectWithContextMap):
+ (WebCore::DOMData::getCurrent):
+ (WebCore::DOMData::handleWeakObject):
+ (WebCore::DOMData::ensureDeref):
+ (WebCore::weakDOMObjectCallback):
+ (WebCore::weakActiveDOMObjectCallback):
+ (WebCore::weakNodeCallback):
+ (WebCore::weakSVGElementInstanceCallback):
+ (WebCore::weakSVGObjectWithContextCallback):
+ (WebCore::DOMData::derefObject):
+ (WebCore::DOMData::derefDelayedObjects):
+ (WebCore::DOMData::derefDelayedObjectsInCurrentThread):
+ (WebCore::DOMData::removeObjectsFromWrapperMap):
+ (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
+ (WebCore::visitDOMNodesInCurrentThread):
+ (WebCore::visitDOMObjectsInCurrentThread):
+ (WebCore::visitActiveDOMObjectsInCurrentThread):
+ (WebCore::visitDOMSVGElementInstancesInCurrentThread):
+ (WebCore::visitSVGObjectsInCurrentThread):
+ * bindings/v8/V8DOMMap.h:
+ (WebCore::DOMDataStoreHandle::getStore):
+ * bindings/v8/V8IsolatedWorld.cpp: Added.
+ (WebCore::getIsolatedWorldKey):
+ (WebCore::contextWeakReferenceCallback):
+ (WebCore::V8IsolatedWorld::evaluate):
+ (WebCore::V8IsolatedWorld::V8IsolatedWorld):
+ (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
+ (WebCore::V8IsolatedWorld::getEntered):
+ * bindings/v8/V8IsolatedWorld.h: Added.
+ (WebCore::V8IsolatedWorld::getDOMDataStore):
+
+2009-06-24 Mikhail Naganov <mnaganov@chromium.org>
- Added the default value 1 as it simplifies some of
- the format by removing some "=1" that were awkward.
+ Reviewed by Timothy Hatcher.
- This was suggested by Darin Adler as par of a previous
- review.
+ Bug 26604: Search doesn't work in Web Inspector Profiler
+ https://bugs.webkit.org/show_bug.cgi?id=26604
- * bindings/scripts/InFilesParser.pm: When no value
- was entered (the second part of the split is undef),
- provide the default value.
+ Seems like search was damaged in revision 42808.
- * html/HTMLAttributeNames.in: Removed unnecessary "=1".
- * html/HTMLTagNames.in: Ditto.
- * svg/svgattrs.in: Ditto.
- * svg/svgtags.in: Ditto.
- * svg/xlinkattrs.in: Ditto.
- * wml/WMLAttributeNames.in: Ditto.
+ * inspector/front-end/ProfileView.js:
+ (WebInspector.ProfileView.prototype.refresh):
+ Here and in other functions: nodes we're searching in are profile data grid
+ nodes, so there is no more need for '_dataGridNode' references.
+ (WebInspector.ProfileView.prototype.searchCanceled):
+ (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
+ Fixed accidental semicolon that caused 'matchesQuery' always return true.
+ (WebInspector.ProfileView.prototype.performSearch):
+ To perform search correctly in the case of bottom up tree, we need to populate
+ the tree, because there's no 1-to-1 correspondence between profile nodes and
+ data grid nodes in this case.
+ (WebInspector.ProfileView.prototype._jumpToSearchResult):
-2009-01-20 Anders Carlsson <andersca@apple.com>
+2009-06-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
+
+ <rdar://problem/6450239&6574516>
+
+ Fix flashing issues caused by compositing layers rendering content before
+ a deferred layout has happened. Because the -viewWillDraw machinery doesn't
+ work for composited layers, we need to use scheduleViewUpdate() to queue
+ up a layout via the run loop observer in WebKit, whenever we know we
+ are going to be painting soon.
- * bridge/c/c_class.cpp:
- * bridge/c/c_class.h:
- Get rid of CClass::name().
-
- * bridge/jni/jni_class.h:
- Get rid of JavaClass::name().
-
- * bridge/objc/objc_class.h:
- * bridge/objc/objc_class.mm:
- Get rid of ObjcClass::name().
-
- * bridge/objc/objc_instance.h:
- Get rid of supportsSetValueOfUndefinedField.
-
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::setValueOfUndefinedField):
- Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.
-
- * bridge/runtime.cpp:
- Get rid of getValueOfField and setValueOfField.
-
- * bridge/runtime.h:
- (JSC::Bindings::Instance::setValueOfUndefinedField):
- Have this return a bool and get rid of supportsSetValueOfUndefinedField
-
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::fieldGetter):
- Call Field::valueFromInstance on the field.
-
- (JSC::RuntimeObjectImp::put):
- Call Field::setValueToInstance on the field.
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Forgot to land build changes for non-mac platforms.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Adam Roben.
-
- Fix last-minute regression, introduced by simplifying max length determination - by
- clamping using min/max, negative maxLength values got broken.
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::parseMaxLengthAttribute):
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::setContentsNeedDisplay):
+ (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- Reviewed by Adam Roben.
+2009-06-24 David Levin <levin@chromium.org>
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433
+ Fix all builds.
- Add InputElement abstraction, similar to the FormControlElement refactorization
- done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
- In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
- RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
- depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.
+ * ForwardingHeaders/wtf/FastAllocBase.h: Added.
- A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
- InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
- derive from InputElement, and hold a InputElementData member variable, that they pass to the
- static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.
+2009-06-24 Jeremy Orlow <jorlow@chromium.org>
- * WebCore.xcodeproj/project.pbxproj:
- * dom/FormControlElement.cpp: Added.
- (WebCore::formControlElementForElement):
- * dom/FormControlElement.h:
- * dom/InputElement.cpp: Added.
- (WebCore::InputElement::dispatchFocusEvent):
- (WebCore::InputElement::dispatchBlurEvent):
- (WebCore::InputElement::updatePlaceholderVisibility):
- (WebCore::InputElement::updateFocusAppearance):
- (WebCore::InputElement::updateSelectionRange):
- (WebCore::InputElement::aboutToUnload):
- (WebCore::InputElement::setValueFromRenderer):
- (WebCore::numCharactersInGraphemeClusters):
- (WebCore::InputElement::constrainValue):
- (WebCore::numGraphemeClusters):
- (WebCore::InputElement::handleBeforeTextInsertedEvent):
- (WebCore::InputElement::parseSizeAttribute):
- (WebCore::InputElement::parseMaxLengthAttribute):
- (WebCore::InputElement::updateValueIfNeeded):
- (WebCore::InputElement::notifyFormStateChanged):
- (WebCore::InputElementData::InputElementData):
- (WebCore::InputElementData::~InputElementData):
- (WebCore::InputElementData::name):
- (WebCore::inputElementForElement):
- * dom/InputElement.h: Added.
- (WebCore::InputElement::~InputElement):
- (WebCore::InputElement::InputElement):
- (WebCore::InputElementData::inputElement):
- (WebCore::InputElementData::element):
- (WebCore::InputElementData::placeholderShouldBeVisible):
- (WebCore::InputElementData::setPlaceholderShouldBeVisible):
- (WebCore::InputElementData::setName):
- (WebCore::InputElementData::value):
- (WebCore::InputElementData::setValue):
- (WebCore::InputElementData::size):
- (WebCore::InputElementData::setSize):
- (WebCore::InputElementData::maxLength):
- (WebCore::InputElementData::setMaxLength):
- (WebCore::InputElementData::cachedSelectionStart):
- (WebCore::InputElementData::setCachedSelectionStart):
- (WebCore::InputElementData::cachedSelectionEnd):
- (WebCore::InputElementData::setCachedSelectionEnd):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::HTMLInputElement):
- (WebCore::HTMLInputElement::name):
- (WebCore::HTMLInputElement::updateFocusAppearance): Moved to InputElement.
- (WebCore::HTMLInputElement::aboutToUnload): Ditto.
- (WebCore::HTMLInputElement::dispatchFocusEvent): Ditto.
- (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
- (WebCore::HTMLInputElement::setSelectionRange): Moved to InputElement::updateSelectionRange, call it from here.
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::size): Make virtual and override InputElements abstract version.
- (WebCore::HTMLInputElement::copyNonAttributeProperties):
- (WebCore::HTMLInputElement::value): Make virtual and override InputElements abstract version.
- (WebCore::HTMLInputElement::setValue): Ditto.
- (WebCore::HTMLInputElement::placeholderValue): Ditto.
- (WebCore::HTMLInputElement::searchEventsShouldBeDispatched): Ditto.
- (WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
- (WebCore::HTMLInputElement::setFileListFromRenderer): Use new code in InputElement::setValueFromRenderer
- (WebCore::HTMLInputElement::defaultEventHandler):
- (WebCore::HTMLInputElement::setDefaultName): Added as helper function for HTMLIsIndexElement.
- (WebCore::HTMLInputElement::maxLength): Added accesor.
- (WebCore::HTMLInputElement::constrainValue): Move functionality to InputElement::constrainValue.
- (WebCore::HTMLInputElement::cacheSelection): Move functionality to InputElement::cacheSelection.
- (WebCore::HTMLInputElement::selection):
- (WebCore::HTMLInputElement::placeholderShouldBeVisible): Make virtual and override InputElements abstract version.
- * html/HTMLInputElement.h:
- (WebCore::HTMLInputElement::isTextField):
- (WebCore::HTMLInputElement::isSearchField):
- (WebCore::HTMLInputElement::isAutofilled):
- * html/HTMLIsIndexElement.cpp:
- (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::formControlElement):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::cacheSelection):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
- (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
- (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::inputElement):
- * rendering/RenderTextControlSingleLine.h:
-
-2009-01-20 Dirk Schulze <krit@webkit.org>
+ Reviewed by Darin Fisher.
- Reviewed by Nikolas Zimmermann.
+ https://bugs.webkit.org/show_bug.cgi?id=26658
- Make SVG pattern platform independent and remove platform code.
+ Split the syncing portions of LocalStorageArea into StorageAreaSync.
+ This name will make more sense in the next patch (in this set) when
+ LocalStorageArea and SessionStorageArea are merged to become simply
+ StorageArea. (Thus the synching portion of StorageArea is in
+ StorageAreaSync.)
- Make SVGPattern platform independent
- https://bugs.webkit.org/show_bug.cgi?id=21205
+ This looks like a big patch, but really all it's doing is splitting
+ code and patching split-related things up.
* GNUmakefile.am:
- * WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::applyStrokePattern):
- (WebCore::GraphicsContext::applyFillPattern):
- (WebCore::GraphicsContext::drawPath):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::strokeRect):
- * svg/graphics/SVGPaintServerPattern.cpp:
- (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
- (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
- (WebCore::SVGPaintServerPattern::setup):
- (WebCore::SVGPaintServerPattern::renderPath):
- (WebCore::SVGPaintServerPattern::teardown):
- * svg/graphics/SVGPaintServerPattern.h:
- * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
- * svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
- * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.
-
-2009-01-20 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23436
- Upstream rendering/RenderThemeChromium*
-
- * rendering/RenderThemeChromiumGtk.cpp: Added.
- * rendering/RenderThemeChromiumGtk.h: Added.
- * rendering/RenderThemeChromiumMac.h: Added.
- * rendering/RenderThemeChromiumMac.mm: Added.
- * rendering/RenderThemeChromiumWin.cpp: Added.
- * rendering/RenderThemeChromiumWin.h: Added.
-
-2009-01-20 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- Bug 23352: Turn on more compiler warnings in the Mac build
- https://bugs.webkit.org/show_bug.cgi?id=23352
-
- First patch: Fix some simple cases of various warnings.
-
- * platform/DeprecatedPtrListImpl.cpp:
- (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::containsCharacters): Ditto.
-
- * platform/text/PlatformString.h: Overload for short and unsigned short to avoid
- ambiguity leading to warnings.
- * platform/text/String.cpp:
- (WebCore::String::number): Implemented overloads.
-
- * platform/text/TextStream.cpp:
- (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading
- to warnings.
- * platform/text/TextStream.h: Ditto.
-
- * rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.
-
- * svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after
- #endif that should be a comment instead.
- * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.
-
- * xml/XPathPath.h: Remove unneeded redundant declaration.
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Build fix for WML enabled builds, not reviewed.
-
- Fix unused variable warning.
-
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::executeTask):
-
-2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Build fix for WML enabled builds, not reviewed.
-
- Rename 'continuation' to 'virtualContinuation'.
-
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::isKeyboardFocusable):
-
-2009-01-20 Oliver Hunt <oliver@apple.com>
-
- RS=Dan Bernstein
-
- Move runtime/ByteArray to wtf/ByteArray
-
- * ForwardingHeaders/wtf/ByteArray.h: Renamed from WebCore/ForwardingHeaders/runtime/ByteArray.h.
- * html/CanvasRenderingContext2D.cpp:
- * html/ImageData.cpp:
- (WebCore::ImageData::ImageData):
- * html/ImageData.h:
- (WebCore::ImageData::data):
-
-2009-01-20 Darin Fisher <darin@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23391
- Upstream plugins/chromium/
-
- * plugins/chromium: Added.
- * plugins/chromium/PluginDataChromium.cpp: Added.
-
-2009-01-19 Steve Falkenburg <sfalken@apple.com>
-
- Fix Windows release build.
- Move SVG files into all-in-one file for Windows build.
-
- * WebCore.vcproj/WebCore.vcproj:
- * svg/SVGAllInOne.cpp: Added.
-
-2009-01-19 Steve Falkenburg <sfalken@apple.com>
-
- Partial build fix.
- Move new derived sources into all-in-one DerivedSources.cpp
-
- * DerivedSources.cpp:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-01-19 Sam Weinig <sam@webkit.org>
+ * WebCoreSources.bkl:
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::create):
+ (WebCore::LocalStorageArea::LocalStorageArea):
+ (WebCore::LocalStorageArea::scheduleFinalSync):
+ (WebCore::LocalStorageArea::itemChanged):
+ (WebCore::LocalStorageArea::itemRemoved):
+ (WebCore::LocalStorageArea::areaCleared):
+ (WebCore::LocalStorageArea::blockUntilImportComplete):
+ * storage/LocalStorageArea.h:
+ * storage/LocalStorageTask.cpp:
+ (WebCore::LocalStorageTask::LocalStorageTask):
+ * storage/LocalStorageTask.h:
+ (WebCore::LocalStorageTask::createImport):
+ (WebCore::LocalStorageTask::createSync):
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::scheduleImport):
+ (WebCore::LocalStorageThread::scheduleSync):
+ * storage/LocalStorageThread.h:
+ * storage/SessionStorageArea.cpp:
+ (WebCore::SessionStorageArea::blockUntilImportComplete):
+ * storage/SessionStorageArea.h:
+ * storage/StorageArea.h:
+ * storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
+ * storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
+ * storage/StorageSyncManager.cpp:
+ (WebCore::StorageSyncManager::scheduleImport):
+ (WebCore::StorageSyncManager::scheduleSync):
+ * storage/StorageSyncManager.h:
+
+2009-06-24 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build.
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::mark):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::valueRealType):
- (JSC::Bindings::convertValueToQVariant):
- (JSC::Bindings::QtRuntimeConnectionMethod::call):
- (JSC::Bindings::QtConnectionObject::execute):
-
-2009-01-19 Sam Weinig <sam@webkit.org>
-
- Fix wx build.
-
- * plugins/PluginView.cpp:
- (WebCore::getString):
-
-2009-01-19 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Gavin Barraclough.
-
- Remove temporary operator-> from JSValuePtr.
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::constructAudio):
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::toHTMLCanvasStyle):
- (WebCore::JSCanvasRenderingContext2D::setFillColor):
- (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
- (WebCore::JSCanvasRenderingContext2D::strokeRect):
- (WebCore::JSCanvasRenderingContext2D::drawImage):
- (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
- (WebCore::JSCanvasRenderingContext2D::setShadow):
- (WebCore::JSCanvasRenderingContext2D::createPattern):
- (WebCore::JSCanvasRenderingContext2D::putImageData):
- (WebCore::JSCanvasRenderingContext2D::fillText):
- (WebCore::JSCanvasRenderingContext2D::strokeText):
- * bindings/js/JSClipboardCustom.cpp:
- (WebCore::JSClipboard::clearData):
- (WebCore::JSClipboard::getData):
- (WebCore::JSClipboard::setData):
- (WebCore::JSClipboard::setDragImage):
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- (WebCore::toVoidCallback):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::create):
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::hasItem):
- (WebCore::JSDOMApplicationCache::add):
- (WebCore::JSDOMApplicationCache::remove):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::valueToStringWithNullCheck):
- (WebCore::valueToStringWithUndefinedOrNullCheck):
- (WebCore::reportException):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
- * bindings/js/JSDOMStringListCustom.cpp:
- (WebCore::JSDOMStringList::item):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- (windowProtoFuncOpen):
- (WebCore::toJSDOMWindow):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation):
- (WebCore::JSDOMWindow::postMessage):
- (WebCore::setTimeoutOrInterval):
- (WebCore::JSDOMWindow::clearTimeout):
- (WebCore::JSDOMWindow::clearInterval):
- (WebCore::JSDOMWindow::atob):
- (WebCore::JSDOMWindow::btoa):
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- (WebCore::toDOMWindow):
- * bindings/js/JSDatabaseCustom.cpp:
- (WebCore::JSDatabase::changeVersion):
- (WebCore::JSDatabase::transaction):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::setLocation):
- * bindings/js/JSElementCustom.cpp:
- (WebCore::JSElement::setAttribute):
- (WebCore::JSElement::setAttributeNS):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventTargetNodeCustom.cpp:
- (WebCore::JSEventTargetNode::addEventListener):
- (WebCore::JSEventTargetNode::removeEventListener):
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::createPositionOptions):
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::callHTMLCollection):
- (WebCore::JSHTMLCollection::canGetItemsForName):
- (WebCore::JSHTMLCollection::item):
- (WebCore::JSHTMLCollection::namedItem):
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::JSHTMLDocument::open):
- (WebCore::writeHelper):
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- (WebCore::JSHTMLOptionsCollection::setLength):
- (WebCore::JSHTMLOptionsCollection::add):
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- (WebCore::JSHTMLSelectElement::remove):
- (WebCore::selectIndexSetter):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::constructImage):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
- (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::setProtocol):
- (WebCore::JSLocation::setHost):
- (WebCore::JSLocation::setHostname):
- (WebCore::JSLocation::setPort):
- (WebCore::JSLocation::setPathname):
- (WebCore::JSLocation::setSearch):
- (WebCore::JSLocation::setHash):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::assign):
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::mark):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::mark):
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/JSNodeFilterCondition.h:
- * bindings/js/JSNodeFilterCustom.cpp:
- (WebCore::toNodeFilter):
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::callNodeList):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::constructHTMLOptionElement):
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::asWrapper):
- (WebCore::JSQuarantinedObjectWrapper::construct):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item):
- * bindings/js/JSSQLTransactionCustom.cpp:
- (WebCore::JSSQLTransaction::executeSql):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/js/JSSVGLengthCustom.cpp:
- (WebCore::JSSVGLength::convertToSpecifiedUnits):
- * bindings/js/JSSVGMatrixCustom.cpp:
- (WebCore::JSSVGMatrix::translate):
- (WebCore::JSSVGMatrix::scale):
- (WebCore::JSSVGMatrix::scaleNonUniform):
- (WebCore::JSSVGMatrix::rotate):
- (WebCore::JSSVGMatrix::rotateFromVector):
- (WebCore::JSSVGMatrix::skewX):
- (WebCore::JSSVGMatrix::skewY):
- * bindings/js/JSSVGPathSegListCustom.cpp:
- (WebCore::JSSVGPathSegList::getItem):
- (WebCore::JSSVGPathSegList::insertItemBefore):
- (WebCore::JSSVGPathSegList::replaceItem):
- (WebCore::JSSVGPathSegList::removeItem):
- * bindings/js/JSSVGPointListCustom.cpp:
- (WebCore::JSSVGPointList::getItem):
- (WebCore::JSSVGPointList::insertItemBefore):
- (WebCore::JSSVGPointList::replaceItem):
- (WebCore::JSSVGPointList::removeItem):
- * bindings/js/JSSVGTransformListCustom.cpp:
- (WebCore::JSSVGTransformList::getItem):
- (WebCore::JSSVGTransformList::insertItemBefore):
- (WebCore::JSSVGTransformList::replaceItem):
- (WebCore::JSSVGTransformList::removeItem):
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::deleteProperty):
- (WebCore::JSStorage::customPut):
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
- (WebCore::constructWebKitCSSMatrix):
- * bindings/js/JSWorkerConstructor.cpp:
- (WebCore::constructWorker):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::open):
- (WebCore::JSXMLHttpRequest::setRequestHeader):
- (WebCore::JSXMLHttpRequest::send):
- (WebCore::JSXMLHttpRequest::getResponseHeader):
- (WebCore::JSXMLHttpRequest::overrideMimeType):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/js/JSXSLTProcessorCustom.cpp:
- (WebCore::JSXSLTProcessor::importStylesheet):
- (WebCore::JSXSLTProcessor::transformToFragment):
- (WebCore::JSXSLTProcessor::transformToDocument):
- (WebCore::JSXSLTProcessor::setParameter):
- (WebCore::JSXSLTProcessor::getParameter):
- (WebCore::JSXSLTProcessor::removeParameter):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::executeFunctionInContext):
- * bindings/js/ScriptCallStack.cpp:
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createScriptObjectForPluginElement):
- * bindings/js/ScriptValue.cpp:
- (WebCore::ScriptValue::getString):
- (WebCore::ScriptValue::isNull):
- (WebCore::ScriptValue::isUndefined):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_HasMethod):
- (_NPN_Construct):
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertValueToNPVariant):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::invokeMethod):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::convertValueToJObject):
- * bridge/jni/jni_runtime.cpp:
- (JavaField::dispatchValueFromInstance):
- (JavaField::valueFromInstance):
- (JavaField::dispatchSetValueToInstance):
- (JavaField::setValueToInstance):
- * bridge/jni/jni_utility.cpp:
- (JSC::Bindings::convertArrayInstanceToJavaArray):
- (JSC::Bindings::convertValueToJValue):
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::callObjCFallbackObject):
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertValueToObjcValue):
- * bridge/runtime_method.cpp:
- (JSC::callRuntimeMethod):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::getOwnPropertySlot):
- (JSC::callRuntimeConstructor):
-
-2009-01-20 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=23419
- removal of FramePrivate.h breaks GTK+'s make dist
-
- * GNUmakefile.am: No longer mention FramePrivate.h in our build,
- since it was removed.
-
-2009-01-20 Alexander V. Butenko <alex@digiqube.com>
-
- Reviewed by Holger Freyther.
-
- http://bugs.webkit.org/show_bug.cgi?id=23116
- [GTK] Fix crash due a callback called from GIO after the
- destruction of the ResourceHandle
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
- 'client' is set, otherwise cancelling a load could lead to a crash.
-
-2009-01-19 Simon Fraser <simon.fraser@apple.com>
-
- Build fix: remove duplicate entries in the Xcode project, and
- sort the project with sort-Xcode-project-file .
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-01-19 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=18078
-
- Support animations and transitions of shorthand properties by creating
- PropertyWrappers that simply wrap a vector of atomic wrappers, and implement
- equal() and blend(). Build that collection of shorthand wrappers using the
- shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
- shorthand wrappers during 'all' transitions.
-
- * GNUmakefile.am:
* WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Add CSSPropertyLonghand.h/cpp.
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
- Move CSSPropertyLonghand to its own file.
-
- * css/CSSPropertyLonghand.cpp: Added.
- (WebCore::initShorthandMap):
- (WebCore::longhandForProperty):
- * css/CSSPropertyLonghand.h: Added.
- (WebCore::CSSPropertyLonghand::CSSPropertyLonghand):
- (WebCore::CSSPropertyLonghand::properties):
- (WebCore::CSSPropertyLonghand::length):
- Code moved from CSSMutableStyleDeclaration.h/cpp
-
- * page/animation/AnimationBase.cpp:
- (WebCore::PropertyWrapperBase::isShorthandWrapper):
- (WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
- (WebCore::ShorthandPropertyWrapper::isShorthandWrapper):
- (WebCore::ShorthandPropertyWrapper::equals):
- (WebCore::ShorthandPropertyWrapper::blend):
- Add a wrapper class for shorthand properties that simply wraps an
- array of atomic property wrappers.
-
- (WebCore::ensurePropertyMap):
- (WebCore::addPropertyWrapper):
- (WebCore::addShorthandProperties):
- (WebCore::wrapperForProperty):
- (WebCore::AnimationBase::propertiesEqual):
- (WebCore::AnimationBase::getPropertyAtIndex):
- Some minor refactoring to re-use wrapperForProperty(), and ensure that gPropertyWrapperMap
- is filled with an invalid index (-1), not 0.
-
- (WebCore::AnimationBase::blendProperties):
- * page/animation/AnimationBase.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- When doing 'all' transitions, skip shorthand wrappers, since 'all' transitions
- just need to compare all the atomic property wrappers.
-
-2009-01-19 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Actually add the new header.
-
- * dom/GenericWorkerTask.h: Added.
-
-2009-01-19 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22720
-
- Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
- only works for methods that need 6 parameters but similar classes could be added as needed for
- other numbers of parameters.
-
- Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.
-
- Use these methods and others to remove document() from XMLHttpRequest in a few more places.
-
- No observable change in behavior, so no test.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- Sorted project file while adding GenericWorkerTask.h
-
- * bindings/js/ScriptString.h:
- (WebCore::ScriptString::operator=):
- (WebCore::ScriptString::operator+=):
- (WebCore::ScriptString::operator==):
- (WebCore::ScriptString::operator!=):
- Removed unnecessary JSLock.
-
- * dom/Document.cpp:
- (WebCore::Document::addMessage):
- (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- * dom/Document.h:
- * dom/GenericWorkerTask.h: Added.
- (WebCore::GenericWorkerTaskBase::GenericWorkerTaskBase):
- (WebCore::GenericWorkerTaskBase::canPerformTask):
- (WebCore::GenericWorkerTask6::create):
- (WebCore::GenericWorkerTask6::GenericWorkerTask6):
- (WebCore::GenericWorkerTask6::performTask):
- (WebCore::createCallbackTask):
- * dom/ScriptExecutionContext.h:
- * dom/WorkerContext.cpp:
- (WebCore::addMessageTask):
- (WebCore::WorkerContext::addMessage):
- (WebCore::WorkerContext::resourceRetrievedByXMLHttpRequest):
- (WebCore::WorkerContext::postTaskToParentContext):
- * dom/WorkerContext.h:
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::postTaskToParentContext):
- * dom/WorkerMessagingProxy.h:
- * dom/WorkerThread.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::dropProtection):
- (WebCore::reportUnsafeUsage):
- (WebCore::XMLHttpRequest::setRequestHeader):
- (WebCore::XMLHttpRequest::getResponseHeader):
- (WebCore::XMLHttpRequest::didFinishLoading):
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::create):
-
-
-2009-01-19 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 23422: AX: AXLinks should expose access key information
- https://bugs.webkit.org/show_bug.cgi?id=23422
-
- Test: accessibility/accesskey.html
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
-
-2009-01-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23417
- Implement application cache obsolete state
-
- Test: http/tests/appcache/remove-cache.html
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::mark):
- * dom/EventNames.h:
- * loader/appcache/DOMApplicationCache.h:
- (WebCore::DOMApplicationCache::Status):
- (WebCore::DOMApplicationCache::setOnobsolete):
- (WebCore::DOMApplicationCache::onobsolete):
- * loader/appcache/DOMApplicationCache.idl:
- Added "obsolete" event and status.
-
- * loader/appcache/ApplicationCacheGroup.h:
- (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
- any need to track what the newest cache was during teardown.
- (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
- confusion with cache group lifecycle status.
- (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
- (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
- not belong to an obsolete group.
- (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
- (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
- via a JS swapCache() call, not only when the loader is destroyed.
- (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
- (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
- a caller responsibility, because this method is also used when loading caches from disk.
- (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
- inform cache storage, so that it could be removed.
- (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
- was call cacheUpdateFailed().
- (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
- handing.
- (WebCore::ApplicationCacheGroup::didFail): Ditto.
- (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
- method for 404 and 410 responses.
- (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
- directly, instead of the removed didFailToLoadManifest().
- (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
- (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
- after update successfully finishes (moved from setNewestCache()).
- (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
- an explicitly passed pointer, without the need to save it during teardown.
-
- * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
- Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
-
- * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
- some comments.
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
- obsolete.
- (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
- (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
- groups, as they cannot be in storage.
- (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
- completely, so that a new one could replace it, if necessary.
- (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
- (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
-
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
- (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
- application was removed server-side.
- (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
-
- * loader/appcache/DOMApplicationCache.h:
- (WebCore::DOMApplicationCache::Status):
- (WebCore::DOMApplicationCache::setOnobsolete):
- (WebCore::DOMApplicationCache::onobsolete):
- Added support for OBSOLETE state and obsolete event.
-
- * loader/appcache/DOMApplicationCache.idl: Ditto.
-
-2009-01-19 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
-
- Allow plug-in views to return an instance directly.
-
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::createScriptInstanceForWidget):
-
-2009-01-19 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by David Hyatt.
-
- AX: some buttons don't expose AXPress as an action
- https://bugs.webkit.org/show_bug.cgi?id=23399
-
- Test: accessibility/button-press-action.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::actionElement):
-
-2009-01-19 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
- $WebKitOutputDir so that WebKit can access them.
-
- * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
- and header copy.
-
-2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry
-
- [Qt] Show focus rect when a button gets the focus for the first time.
- This is important at least for Windows style.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::applyTheme):
-
-2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- [Qt] Build fix after r39971.
-
- * platform/qt/LoggingQt.cpp:
- (WebCore::InitializeLoggingChannelsIfNecessary):
-
-2009-01-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
- Remove FramePrivate
-
- Minor PLT speedup.
-
- * WebCore.base.exp:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * loader/FrameLoader.cpp:
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
- (WebCore::Frame::~Frame):
- (WebCore::Frame::init):
- (WebCore::Frame::loader):
- (WebCore::Frame::view):
- (WebCore::Frame::setView):
- (WebCore::Frame::script):
- (WebCore::Frame::document):
- (WebCore::Frame::setDocument):
- (WebCore::Frame::settings):
- (WebCore::Frame::selection):
- (WebCore::Frame::editor):
- (WebCore::Frame::selectionGranularity):
- (WebCore::Frame::setSelectionGranularity):
- (WebCore::Frame::dragCaretController):
- (WebCore::Frame::animation):
- (WebCore::Frame::mark):
- (WebCore::Frame::setMark):
- (WebCore::Frame::setCaretVisible):
- (WebCore::Frame::clearCaretRectIfNeeded):
- (WebCore::Frame::selectionLayoutChanged):
- (WebCore::Frame::caretBlinkTimerFired):
- (WebCore::Frame::paintCaret):
- (WebCore::Frame::paintDragCaret):
- (WebCore::Frame::zoomFactor):
- (WebCore::Frame::isZoomFactorTextOnly):
- (WebCore::Frame::shouldApplyTextZoom):
- (WebCore::Frame::shouldApplyPageZoom):
- (WebCore::Frame::setZoomFactor):
- (WebCore::Frame::setPrinting):
- (WebCore::Frame::setJSStatusBarText):
- (WebCore::Frame::setJSDefaultStatusBarText):
- (WebCore::Frame::jsStatusBarText):
- (WebCore::Frame::jsDefaultStatusBarText):
- (WebCore::Frame::setNeedsReapplyStyles):
- (WebCore::Frame::needsReapplyStyles):
- (WebCore::Frame::reapplyStyles):
- (WebCore::Frame::isContentEditable):
- (WebCore::Frame::updateSecureKeyboardEntryIfActive):
- (WebCore::Frame::typingStyle):
- (WebCore::Frame::setTypingStyle):
- (WebCore::Frame::clearTypingStyle):
- (WebCore::Frame::computeAndSetTypingStyle):
- (WebCore::Frame::selectionComputedStyle):
- (WebCore::Frame::applyEditingStyleToBodyElement):
- (WebCore::Frame::removeEditingStyleFromBodyElement):
- (WebCore::Frame::keepAlive):
- (WebCore::Frame::cancelAllKeepAlive):
- (WebCore::Frame::clearDOMWindow):
- (WebCore::Frame::ownerElement):
- (WebCore::Frame::ownerRenderer):
- (WebCore::Frame::isDisconnected):
- (WebCore::Frame::setIsDisconnected):
- (WebCore::Frame::excludeFromTextSearch):
- (WebCore::Frame::setExcludeFromTextSearch):
- (WebCore::Frame::selectionBounds):
- (WebCore::Frame::selectionTextRects):
- (WebCore::Frame::isFrameSet):
- (WebCore::Frame::currentForm):
- (WebCore::Frame::forceLayout):
- (WebCore::Frame::sendScrollEvent):
- (WebCore::Frame::clearTimers):
- (WebCore::Frame::styleForSelectionStart):
- (WebCore::Frame::inViewSourceMode):
- (WebCore::Frame::setInViewSourceMode):
- (WebCore::Frame::markAllMatchesForText):
- (WebCore::Frame::markedTextMatchesAreHighlighted):
- (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
- (WebCore::Frame::tree):
- (WebCore::Frame::setDOMWindow):
- (WebCore::Frame::domWindow):
- (WebCore::Frame::clearFormerDOMWindow):
- (WebCore::Frame::page):
- (WebCore::Frame::eventHandler):
- (WebCore::Frame::pageDestroyed):
- (WebCore::Frame::disconnectOwnerElement):
- (WebCore::Frame::documentAtPoint):
- * page/Frame.h:
- * page/FramePrivate.h: Removed.
- * page/FrameTree.h:
- * page/chromium/FrameChromium.cpp:
- * page/mac/FrameMac.mm:
- (WebCore::Frame::imageFromRect):
- (WebCore::Frame::selectionImage):
- (WebCore::Frame::snapshotDragImage):
- (WebCore::Frame::nodeImage):
- (WebCore::Frame::setUserStyleSheetLocation):
- (WebCore::Frame::setUserStyleSheet):
- * page/qt/FrameQt.cpp:
- (WebCore::Frame::setUserStyleSheetLocation):
- (WebCore::Frame::setUserStyleSheet):
- * page/win/FrameCGWin.cpp:
- (WebCore::Frame::nodeImage):
- * page/win/FrameWin.cpp:
-
-2009-01-18 Eric Carlson <eric.carlson@apple.com>
-
- Build fix for !ENABLE(VIDEO) following r40016.
-
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::mouseEventIsInThumb):
-
-2009-01-17 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
- on Node is now non-virtual and just checks a bit that is set at construction time by Text.
-
- Reviewed by Sam Weinig
-
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::CharacterData):
- * dom/CharacterData.h:
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::EventTargetNode):
- * dom/EventTargetNode.h:
- * dom/Node.cpp:
- (WebCore::Node::Node):
- * dom/Node.h:
- (WebCore::Node::isTextNode):
- (WebCore::Node::isAttributeNode):
- * dom/Text.cpp:
- (WebCore::Text::Text):
- * dom/Text.h:
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
- replacement themselves, the exact transformation is instead done by the encoding (indirectly through
- a method on Document).
-
- These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
- a slight speedup, and also allow encodings to do future alterations to displayed string content without
- having to patch call sites again.
-
- Reviewed by Oliver Hunt
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- * dom/Document.h:
- (WebCore::Document::displayStringModifiedByEncoding):
- (WebCore::Document::displayBufferModifiedByEncoding):
- * editing/Editor.cpp:
- (WebCore::Editor::addToKillRing):
- * editing/TextIterator.cpp:
- (WebCore::plainTextToMallocAllocatedBuffer):
- (WebCore::plainText):
- * editing/TextIterator.h:
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::groupLabelText):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::text):
- * loader/DocumentLoader.cpp:
- (WebCore::canonicalizedTitle):
- * page/Chrome.cpp:
- (WebCore::displayString):
- (WebCore::Chrome::runJavaScriptAlert):
- (WebCore::Chrome::runJavaScriptConfirm):
- (WebCore::Chrome::runJavaScriptPrompt):
- (WebCore::Chrome::setStatusbarText):
- * page/Frame.cpp:
- (WebCore::Frame::shouldClose):
- * page/Frame.h:
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writeSelection):
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::encode):
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::TextEncoding):
- * platform/text/TextEncoding.h:
- (WebCore::TextEncoding::displayString):
- (WebCore::TextEncoding::displayBuffer):
- * rendering/HitTestResult.cpp:
- (WebCore::displayString):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::paintReplaced):
- * rendering/RenderObject.cpp:
- * rendering/RenderObject.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
- (WebCore::RenderText::setTextInternal):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setInnerTextValue):
- (WebCore::RenderTextControl::finishText):
-
-2009-01-17 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele Peterson
-
- Complete <rdar://problem/6293969>
-
- * DerivedSources.make: include mediaControlsQT.css for Mac build.
-
- * WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
-
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart,
- CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
- * css/CSSSelector.h:
- (WebCore::CSSSelector::): Ditto.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media
- controller element styles
-
- * css/CSSValueKeywords.in: add keywords for new media time display controls
-
- * css/mediaControls.css: adjust css for new control elements
-
- * css/mediaControlsQT.css: Added.
-
- * platform/ThemeTypes.h:
- (WebCore::): add media time display controls to ControlPart
-
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added
- (WebCore::MediaTextDisplayElement::attachToParent): Added
- (WebCore::MediaTextDisplayElement::update): Added
- (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added
- (WebCore::MediaControlInputElement::MediaControlInputElement): Added
- (WebCore::MediaControlInputElement::hitTest): Added
- (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when
- dragging the thumb
- * rendering/MediaControlElements.h:
- (WebCore::): Add MediaTextDisplayElement
-
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createTimelineContainer): Added
- (WebCore::RenderMedia::createTimeline): Parent is now the timeline container
- (WebCore::RenderMedia::createCurrentTimeDisplay): Added
- (WebCore::RenderMedia::createTimeRemainingDisplay): Added
- (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update
- timer when the time display elements are not visible
- (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes
- (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not
- visible. Display time remaining as well as current time.
- (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when
- visibility changes
- (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
- as we can't assume that all controls are rectangular
- * rendering/RenderMedia.h: Updated
-
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call
- element hitTest() method instead of assuming it is rectangular
- * rendering/RenderSlider.h: make mouseEventIsInThumb virtual
-
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::paint): Deal with time display and timeline container
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::paintMediaTimelineContainer): Updated
- (WebCore::RenderTheme::paintMediaCurrentTime): Added
- (WebCore::RenderTheme::paintMediaTimeRemaining): Added
-
- * rendering/RenderThemeMac.h: Updated
- * rendering/RenderThemeMac.mm:
- (WebCore::):
- (WebCore::mediaControllerTheme):
- (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb
- size when appropriate
- (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function
- (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
- (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
- (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
- (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added
- (WebCore::RenderThemeMac::paintMediaCurrentTime): Added
- (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added
- (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added
- (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
- * rendering/style/RenderStyle.h: Updated
- (WebCore::):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Inline a few methods in FrameView for speed.
-
- Reviewed by Oliver Hunt
-
- * page/FrameView.cpp:
- * page/FrameView.h:
- (WebCore::FrameView::layoutCount):
- (WebCore::FrameView::needsFullRepaint):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
- the code that fetches and caches the document element into a separate function and inline the part that
- does the null check and the return of the already-cached element.
-
- Reviewed by Oliver Hunt
-
- * dom/Document.cpp:
- (WebCore::Document::cacheDocumentElement):
- * dom/Document.h:
- (WebCore::Document::documentElement):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Minor tweaks to RenderBox::styleChange to speed it up.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Inline FrameLoader::client().
-
- Reviewed by Oliver Hunt
-
- * WebCore.base.exp:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
- (WebCore::FrameLoader::client):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
- than needlessly creating a rect.
-
- Reviewed by Oliver Hunt
-
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::addClient):
- * platform/graphics/Image.cpp:
- * platform/graphics/Image.h:
- (WebCore::Image::isNull):
- (WebCore::Image::rect):
- (WebCore::Image::width):
- (WebCore::Image::height):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.
-
- Reviewed by Oliver Hunt
-
- * css/CSSParserValues.cpp:
- (WebCore::CSSParserValueList::addValue):
-
-2009-01-17 David Hyatt <hyatt@apple.com>
-
- Inline Document::inPageCache(), since - because of animation code - it is now called every time
- styles change on any element and so is now super-hot.
-
- Reviewed by Oliver Hunt
-
- * dom/Document.cpp:
- * dom/Document.h:
- (WebCore::Document::inPageCache):
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Take Font out of the GraphicsContext. Fonts are moderately expensive to both compare and to assign to.
- The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
- and was also causing expensive comparison checks to be made before doing alterations of the Font in the
- GraphicsContext.
-
- A font must now be passed as a parameter to all text drawing functions.
-
- Reviewed by Oliver Hunt
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setFont):
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::drawText):
- (WebCore::GraphicsContext::drawBidiText):
- (WebCore::GraphicsContext::drawHighlightForText):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsContextPrivate.h:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- * rendering/EllipsisBox.cpp:
- (WebCore::EllipsisBox::paint):
- * rendering/InlineTextBox.cpp:
- (WebCore::paintTextWithShadows):
- (WebCore::InlineTextBox::paint):
- (WebCore::InlineTextBox::paintSelection):
- (WebCore::InlineTextBox::paintCompositionBackground):
- (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
- (WebCore::InlineTextBox::paintTextMatchMarker):
- (WebCore::InlineTextBox::paintDocumentMarkers):
- * rendering/InlineTextBox.h:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::paintObject):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::paintReplaced):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::paintItemForeground):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::paint):
- * rendering/SVGInlineTextBox.cpp:
- (WebCore::SVGInlineTextBox::paintCharacters):
- (WebCore::SVGInlineTextBox::paintSelection):
- * rendering/SVGInlineTextBox.h:
- * svg/SVGFont.cpp:
- (WebCore::Font::drawTextUsingSVGFont):
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
- two if statements.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteRects):
- (WebCore::RenderObject::absoluteQuads):
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Fix a regression from my before/after optimization. Make sure the <q> element puts the document
- into a mode where it will respect before/after rules, since <q> implicitly uses such rules.
-
- Make sure view source mode documents also turn on before/after rules, since they are used there also.
-
- Reviewed by Oliver Hunt
- * html/HTMLElementFactory.cpp:
- (WebCore::quoteConstructor):
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
-
-2009-01-16 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23397: AXURL is not reported for <INPUT type="image"> elements
- https://bugs.webkit.org/show_bug.cgi?id=23397
-
- Report an AXURL for inputs that have an image type.
-
- Test: accessibility/input-image-url.html
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::isInputImage):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isInputImage):
- (WebCore::AccessibilityRenderObject::url):
- * page/AccessibilityRenderObject.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
-
-2009-01-16 Adele Peterson <adele@apple.com>
-
- Windows build fix.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):
-
-2009-01-16 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
-
- This was caused by mismatched ENABLE definitions across WebCore and WebKit.
-
- Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
- In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
- to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
- Our Windows ENABLE flags now match Mac.
-
- Reviewed by Adele Peterson.
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.vcproj/build-generated-files.sh:
-
-2009-01-16 Mark Rowe <mrowe@apple.com>
-
- 40,000!
-
- * ChangeLog: Point out revision 40,000.
-
-2009-01-16 Eric Seidel <eric@webkit.org>
-
- Reviewed by Justin Garcia.
-
- Make surroundNodeRangeWithElement call insertNodeBefore implicitly
- Make insertNodeBefore take PassRefPtr
- Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
- https://bugs.webkit.org/show_bug.cgi?id=23389
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
- (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- * editing/ApplyStyleCommand.h:
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::insertNodeAt):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
- * editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::insertTab):
- * editing/ModifySelectionListLevel.cpp:
- (WebCore::IncreaseSelectionListLevelCommand::doApply):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::removeNodePreservingChildren):
- (WebCore::ReplacementFragment::insertNodeBefore):
- (WebCore::ReplacementFragment::removeInterchangeNodes):
- (WebCore::ReplaceSelectionCommand::doApply):
- (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted):
- (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
- (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
- * editing/ReplaceSelectionCommand.h:
-
-2009-01-16 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23393: TextField has AXTitle and AXTitleUIElement
- https://bugs.webkit.org/show_bug.cgi?id=23393
-
- Test: accessibility/double-title.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::title):
-
-2009-01-16 Adam Treat <adam.treat@torchmobile.com>
-
- The correct build fix for all platforms.
-
- * platform/graphics/Font.h:
-
-2009-01-16 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build.
-
- * platform/graphics/Font.h:
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
- are being used. If not, don't waste time probing for those pseudo element styles.
-
- Reviewed by Sam Weinig
-
- * css/CSSGrammar.y:
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- (WebCore::Document::usesBeforeAfterRules):
- (WebCore::Document::setUsesBeforeAfterRules):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleDidChange):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- (WebCore::RenderInline::addChildToFlow):
- (WebCore::RenderInline::splitInlines):
-
-2009-01-16 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=23394
- Remove unnecessary calls to setDeferringTimers().
-
- Use of this function was obsoleted by better handling of EINTR.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
- was resulting in the creation of a cursor list. clearCursorList was creating a new list rather than just
- nulling out the pointer. Since addCursor already lazily recreates the list, in the case of simple cursor types,
- the clear method was wastefully creating a completely unnecessary list for all of these elements.
-
- Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
- set to the same value. Since this is the common case, it prevents a fault and copy of StyleInheritedData for
- all links and form controls.
-
- This is a PLT speedup.
-
- Reviewed by Oliver Hunt
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::clearCursorList):
-
-2009-01-16 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23384
- PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder
-
- * history/BackForwardList.h:
- (WebCore::BackForwardListClient::~BackForwardListClient):
- (WebCore::BackForwardList::setClient):
- * history/BackForwardListChromium.cpp: Added.
-
-2009-01-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Kevin Decker and Adam Roben.
-
- - fix a regression that resulted in a crash when plug-ins were
- disabled.
-
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::updateWidget): Added a null check.
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Split continuation() into virtual and non-virtual versions so that the non-virtual version can
- be used whereever possible. Eventually the virtual method can be eliminated completely.
-
- Reviewed by Sam Weinig and Oliver Hunt
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::anchorElement):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- (WebCore::InlineFlowBox::paint):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::removeChild):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- * rendering/RenderFlow.h:
- (WebCore::RenderFlow::virtualContinuation):
- (WebCore::RenderFlow::continuation):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::positionForCoordinates):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteRects):
- (WebCore::RenderObject::absoluteQuads):
- (WebCore::RenderObject::addFocusRingRects):
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- (WebCore::RenderObject::handleDynamicFloatPositionChange):
- (WebCore::RenderObject::hoverAncestor):
- (WebCore::RenderObject::updateDragState):
- (WebCore::RenderObject::updateHitTestResult):
- (WebCore::RenderObject::getTextDecorationColors):
- (WebCore::RenderObject::adjustRectForOutlineAndShadow):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::virtualContinuation):
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.
-
- Reviewed by ggaren
-
- * platform/graphics/Font.cpp:
- * platform/graphics/Font.h:
- (WebCore::Font::width):
- (WebCore::Font::ascent):
- (WebCore::Font::descent):
- (WebCore::Font::lineSpacing):
- (WebCore::Font::lineGap):
- (WebCore::Font::xHeight):
- (WebCore::Font::unitsPerEm):
- (WebCore::Font::spaceWidth):
-
-2009-01-16 Sam Weinig <sam@webkit.org>
+2009-06-24 David Levin <levin@chromium.org>
Reviewed by David Hyatt.
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
- Remove FrameViewPrivate
-
- Removes an indirection and is a small speedup on PLT.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::~FrameView):
- (WebCore::FrameView::reset):
- (WebCore::FrameView::resetScrollbars):
- (WebCore::FrameView::init):
- (WebCore::FrameView::clear):
- (WebCore::FrameView::didFirstLayout):
- (WebCore::FrameView::initScrollbars):
- (WebCore::FrameView::updateDefaultScrollbarState):
- (WebCore::FrameView::setCanHaveScrollbars):
- (WebCore::FrameView::applyOverflowToViewport):
- (WebCore::FrameView::layoutCount):
- (WebCore::FrameView::needsFullRepaint):
- (WebCore::FrameView::layoutRoot):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::setMediaType):
- (WebCore::FrameView::mediaType):
- (WebCore::FrameView::useSlowRepaints):
- (WebCore::FrameView::setUseSlowRepaints):
- (WebCore::FrameView::addSlowRepaintObject):
- (WebCore::FrameView::removeSlowRepaintObject):
- (WebCore::FrameView::scrollRectIntoViewRecursively):
- (WebCore::FrameView::setScrollPosition):
- (WebCore::FrameView::repaintContentRectangle):
- (WebCore::FrameView::beginDeferredRepaints):
- (WebCore::FrameView::endDeferredRepaints):
- (WebCore::FrameView::scheduleRelayout):
- (WebCore::FrameView::scheduleRelayoutOfSubtree):
- (WebCore::FrameView::layoutPending):
- (WebCore::FrameView::needsLayout):
- (WebCore::FrameView::unscheduleRelayout):
- (WebCore::FrameView::isTransparent):
- (WebCore::FrameView::setTransparent):
- (WebCore::FrameView::baseBackgroundColor):
- (WebCore::FrameView::setBaseBackgroundColor):
- (WebCore::FrameView::shouldUpdateWhileOffscreen):
- (WebCore::FrameView::setShouldUpdateWhileOffscreen):
- (WebCore::FrameView::scheduleEvent):
- (WebCore::FrameView::pauseScheduledEvents):
- (WebCore::FrameView::resumeScheduledEvents):
- (WebCore::FrameView::performPostLayoutTasks):
- (WebCore::FrameView::updateOverflowStatus):
- (WebCore::FrameView::dispatchScheduledEvents):
- (WebCore::FrameView::wasScrolledByUser):
- (WebCore::FrameView::setWasScrolledByUser):
- (WebCore::FrameView::paintContents):
- (WebCore::FrameView::setPaintRestriction):
- (WebCore::FrameView::isPainting):
- (WebCore::FrameView::setNodeToDraw):
- * page/FrameView.h:
- (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.
-
-2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 23237: Some HTML constructors in HTMLElementFactory needs
- an HTMLFormElement argument
-
- - Added 'constructorNeedsFormElement' parameter to make_names.pl to account
- for HTML form elements.
-
- - Added the new information to HTMLTagNames.in.
-
- * dom/make_names.pl:
- * html/HTMLTagNames.in:
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods. The most common reason
- for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
- the cross-platform graphics state. By being able to query for the current antialiasing setting, antialiasing
- can be temporarily changed and then restored back to the real value without needing to do a save/restore.
-
- The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
- a permanent mutation of the fill color in the CGContext. The new code just restores the fill color back
- to its original value without doing the much more expensive save/restore.
-
- Reviewed by Oliver Hunt
-
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::setShouldAntialias):
- (WebCore::GraphicsContext::shouldAntialias):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsContextPrivate.h:
- (WebCore::GraphicsContextState::GraphicsContextState):
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::setPlatformShouldAntialias):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::drawLine):
- (WebCore::GraphicsContext::drawConvexPolygon):
- (WebCore::GraphicsContext::drawLineForText):
- (WebCore::GraphicsContext::setPlatformShouldAntialias):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::setPlatformShouldAntialias):
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::setPlatformShouldAntialias):
- * platform/graphics/wx/GraphicsContextWx.cpp:
- (WebCore::GraphicsContext::setPlatformShouldAntialias):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::paint):
-
-2009-01-16 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Clean up the bridge code and get rid of Field::name() and Method::name().
-
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::invokeMethod):
- * bridge/c/c_runtime.cpp:
- * bridge/c/c_runtime.h:
- (JSC::Bindings::CField::identifier):
- (JSC::Bindings::CMethod::identifier):
- * bridge/jni/jni_class.cpp:
- (JavaClass::JavaClass):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::invokeMethod):
- * bridge/jni/jni_runtime.cpp:
- (JavaField::valueFromInstance):
- (JavaField::setValueToInstance):
- (JavaMethod::methodID):
- * bridge/jni/jni_runtime.h:
- (JSC::Bindings::JavaField::name):
- (JSC::Bindings::JavaMethod::name):
- * bridge/objc/objc_class.mm:
- (JSC::Bindings::ObjcClass::methodsNamed):
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::invokeMethod):
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcMethod::isFallbackMethod):
- (JSC::Bindings::ObjcMethod::selector):
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::ObjcMethod::ObjcMethod):
- (JSC::Bindings::ObjcMethod::getMethodSignature):
- (JSC::Bindings::ObjcField::ObjcField):
- (JSC::Bindings::ObjcField::valueFromInstance):
- (JSC::Bindings::ObjcField::setValueToInstance):
- (JSC::Bindings::callObjCFallbackObject):
- * bridge/runtime.h:
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Optimize RenderText::styleDidChange. Don't call the base class, which does extra meaningless work.
- Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
- Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
- for the existence of m_parent in each if clause.
-
- Reviewed by Darin Adler
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleDidChange):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::styleDidChange):
-
-2009-01-16 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 23387: AX hierarchy is incorrect when iframes are present
- https://bugs.webkit.org/show_bug.cgi?id=23387
-
- The AX hierarchy is incorrect when iframes are present.
-
- Test: accessibility/iframe-bastardization.html
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper renderWidgetChildren]):
-
-2009-01-16 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
- better understand what the common disqualifiers are.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::canCachePageContainingThisFrame):
- (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe.
- (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for
- the back/forward cache.
- (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis.
- (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
- * loader/FrameLoader.h:
-
-2009-01-16 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- Test: transitions/hang-with-bad-transition-list.html
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
- This was happening because I was calling setChanged() from inside updateRendering()
- which causes an infinite loop. I fixed this by deferring the setChanged to the next
- run loop iteration. That made it not infinite loop, but it still retriggers the
- transition forever. The problem is that there is both an 'all' and specific transition
- on 'opacity'. This tickled a bug in AnimationController which causes the opacity
- transition to get constantly cancelled and then retriggered. The problem is that
- the specific opacity transition has a duration of 0. I got rid of the logic to
- flush out 0 duration transitions and it is no longer constantly triggered. The
- logic to flush them was just an optimization, and you really need to keep them
- around to make the logic to override earlier animations by later ones work. And there is
- very little overhead in this case anyway, so the optimization was not that useful.
-
- I made a LayoutTest from the original testcase which tests both the infinite
- loop and constantly triggering animation cases.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
- (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
- (WebCore::AnimationController::addNodeChangeToDispatch):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::adjustAnimations):
- (WebCore::RenderStyle::adjustTransitions):
-
-2009-01-16 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 23385: crash at com.apple.WebCore WebCore::HTMLAnchorElement::isKeyboardFocusable
- https://bugs.webkit.org/show_bug.cgi?id=23385
-
- Option-tabbing through the page mentioned in the bug causes a crash
-
- Test: fast/events/tab-crash-with-image-map.html
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
-
-2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Fixes QString and 8-bit mix fixes.
-
- Details: Make sure we use QLatin1String where appropriate (and don't
- use QString when not necessary)
-
- * platform/graphics/qt/ImageDecoderQt.cpp:
- (WebCore::ImageDecoderQt::create):
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::platformInit):
- * platform/qt/FileSystemQt.cpp:
- (WebCore::openTemporaryFile):
- * platform/qt/LoggingQt.cpp:
- (WebCore::InitializeLoggingChannelsIfNecessary):
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
- * plugins/qt/PluginDataQt.cpp:
- (WebCore::PluginData::initPlugins):
-
-2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=22452
-
- When plugins are disabled, plugin data should not be available for
- the page. This ensures that navigator.plugins would not see the
- additional MIME types supported by the plugins.
-
- * page/Page.cpp:
- (WebCore::Page::pluginData):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::shouldUsePlugin):
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::updateWidget):
-
-2009-01-15 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
- Also fixed the test case to work on ppc.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Another attempt at fixing the Qt build.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getInstance):
-
-2009-01-16 David Hyatt <hyatt@apple.com>
-
- Fix for 1.85% PLT regression. Since asking if a frame is "complete" actually aggressively decodes
- the frame, we add an optimization when advancing animations. If we have received all of the animated
- image's data, then obviously we can go ahead and advance safely. This prevents the first draw of an image
- from decoding two frames' worth of data in the case where all of the image's data has been received.
-
- While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
- as well. It's not immediately clear how that regression would be fixed, though, and it would likely be
- a much smaller percentage of that overall uncached time.
-
- Reviewed by Dan Bernstein
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::startAnimation):
-
-2009-01-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23349
- Don't store obsolete caches in disk storage
-
- * loader/ResourceLoader.cpp:
- (WebCore::ResourceLoader::ResourceLoader):
- (WebCore::ResourceLoader::load):
- (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
- * loader/ResourceLoader.h:
- Don't maintain m_wasLoadedFromApplicationCache, which was never used.
-
- * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
- Assert that only implicit and dynamic resources can be added after the cache has been fully
- loaded and stored to disk database.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk
- database, as this is now done whenever the cache becomes obsolete.
- (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.
-
- * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
- A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed
- the check to no longer rely on savedNewestCachePointer.
-
-2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>
-
- <rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();
-
- Reviewed by Timothy Hatcher.
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::selectorText):
-
-2009-01-15 Justin Garcia <justin.garcia@apple.com>
+ Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
+ https://bugs.webkit.org/show_bug.cgi?id=26696
+
+ * html/DataGridColumnList.cpp:
+ (WebCore::DataGridColumnList::itemWithName):
+ (WebCore::DataGridColumnList::add):
+ * html/DataGridColumnList.h:
+ (WebCore::DataGridColumnList::item):
+ (WebCore::DataGridColumnList::primaryColumn):
+ (WebCore::DataGridColumnList::sortColumn):
+
+2009-06-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dave "Messy" Hyatt.
+
+ Little bit of style cleanup.
+
+ * html/DataGridColumn.cpp:
+ * html/DataGridColumn.h:
+ * html/DataGridColumn.idl:
+ * html/DataGridColumnList.cpp:
+ * html/DataGridColumnList.h:
+ * html/DataGridColumnList.idl:
+ * html/HTMLDataGridCellElement.cpp:
+ * html/HTMLDataGridCellElement.h:
+ * html/HTMLDataGridCellElement.idl:
+ * html/HTMLDataGridColElement.cpp:
+ * html/HTMLDataGridColElement.h:
+ * html/HTMLDataGridColElement.idl:
+ * html/HTMLDataGridElement.h:
+ * html/HTMLDataGridElement.idl:
+ * html/HTMLDataGridRowElement.cpp:
+ * html/HTMLDataGridRowElement.h:
+ * html/HTMLDataGridRowElement.idl:
+
+2009-06-24 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
- <rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break
-
- If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
- applyInlineStyle would style node.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from
- Range::pastLastNode() anymore. pastEndNode is the node after the last one that is fully selected, since
- the work done in the loop that follows should only be performed on fully selected nodes.
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes.
- Those were handled accidently before.
- * editing/htmlediting.cpp:
- (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number
- of children in that container, so I changed it to match that. RenderBR and RenderObject::caretMaxOffset() should
- also be eliminated since maxDeepOffset handles non-text nodes.
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.
-
- * bridge/c/c_instance.h:
- * bridge/jni/jni_instance.h:
- * bridge/objc/objc_instance.h:
- * bridge/qt/qt_instance.h:
- * bridge/runtime.cpp:
- * bridge/runtime.h:
- * bridge/runtime_object.h:
-
-2009-01-15 David Hyatt <hyatt@apple.com>
-
- Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
- code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::styleDidChange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::styleDidChange):
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Another attempt at fixing the Qt build.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getOwnPropertySlot):
- (JSC::Bindings::QtInstance::put):
- * bridge/qt/qt_instance.h:
- * bridge/runtime.h:
- (JSC::Bindings::Instance::getOwnPropertySlot):
- (JSC::Bindings::Instance::put):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::getOwnPropertySlot):
- (JSC::RuntimeObjectImp::put):
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Darin Adler.
-
- Add QtInstance::getInstance and start using it.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtRuntimeObjectImp::mark):
- (JSC::Bindings::QtRuntimeObjectImp::classInfo):
- (JSC::Bindings::):
- (JSC::Bindings::QtInstance::getInstance):
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertValueToQVariant):
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getOwnPropertySlot):
- (JSC::Bindings::QtInstance::put):
- * bridge/qt/qt_instance.h:
- * bridge/runtime.h:
- (JSC::Bindings::Instance::getOwnPropertySlot):
- (JSC::Bindings::Instance::put):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::getOwnPropertySlot):
- (JSC::RuntimeObjectImp::put):
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Fix the QT build.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::createRuntimeObject):
- * bridge/qt/qt_instance.h:
-
-2009-01-15 David Hyatt <hyatt@apple.com>
-
- Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor
-
- setZoomFactor was supposed to bail if both the zoom factor and mode were the same. The mode check was
- buggy and doing the wrong thing.
-
- Reviewed by Darin Adler
-
- * page/Frame.cpp:
- (WebCore::Frame::setZoomFactor):
-
-2009-01-15 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Make Instance::createRuntimeObject a virtual function and override it for QtInstance.
-
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::getRuntimeObject):
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertNPVariantToValue):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::invokeMethod):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::convertJObjectToValue):
- * bridge/jni/jni_runtime.cpp:
- (JavaField::valueFromInstance):
- (JavaArray::valueAt):
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertObjcValueToValue):
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getRuntimeObject):
- (JSC::Bindings::QtInstance::createRuntimeObject):
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
- (JSC::Bindings::QtConnectionObject::execute):
- * bridge/runtime.cpp:
- (JSC::Bindings::Instance::createRuntimeObject):
- * bridge/runtime.h:
-
-2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23354
- Fix up graphics/chromium files to account for Uniscribe style scrubbing.
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::Font::selectionRectForComplexText):
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
- (WebCore::fillNonBMPGlyphs):
-
-2009-01-15 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23333
- Adjust due to a name change that happened in a WebKit.
-
- * svg/graphics/skia/SVGPaintServerPatternSkia.cpp:
- (WebCore::SVGPaintServerPattern::setup):
+ Bug 26668: AX: need a way to retrieve the language for an element
+
+ Provides a way to retrieve the language associated with a specific accessibility element.
-2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
+ Test: accessibility/language-attribute.html
- Reviewed by Eric Seidel.
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::language):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::language):
+ * accessibility/AccessibilityRenderObject.h:
+ * accessibility/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- https://bugs.webkit.org/show_bug.cgi?id=23340
- Add remaining bits of graphics/chromium.
-
- * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added.
- (WebCore::scaleEmToUnits):
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformDestroy):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/graphics/chromium/SimpleFontDataLinux.cpp: Added.
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformDestroy):
- (WebCore::SimpleFontData::smallCapsFontData):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::platformWidthForGlyph):
- * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added.
- (WebCore::ThemeHelperWin::ThemeHelperWin):
- (WebCore::ThemeHelperWin::~ThemeHelperWin):
- * platform/graphics/chromium/ThemeHelperChromiumWin.h: Added.
- (WebCore::ThemeHelperWin::):
- (WebCore::ThemeHelperWin::context):
- (WebCore::ThemeHelperWin::rect):
- * platform/graphics/chromium/UniscribeHelper.cpp: Added.
- (WebCore::treatAsSpace):
- (WebCore::containsMissingGlyphs):
- (WebCore::setLogFontAndStyle):
- (WebCore::UniscribeHelper::UniscribeHelper):
- (WebCore::UniscribeHelper::~UniscribeHelper):
- (WebCore::UniscribeHelper::initWithOptionalLengthProtection):
- (WebCore::UniscribeHelper::width):
- (WebCore::UniscribeHelper::justify):
- (WebCore::UniscribeHelper::characterToX):
- (WebCore::UniscribeHelper::xToCharacter):
- (WebCore::UniscribeHelper::draw):
- (WebCore::UniscribeHelper::firstGlyphForCharacter):
- (WebCore::UniscribeHelper::fillRuns):
- (WebCore::UniscribeHelper::shape):
- (WebCore::UniscribeHelper::fillShapes):
- (WebCore::UniscribeHelper::fillScreenOrder):
- (WebCore::UniscribeHelper::adjustSpaceAdvances):
- (WebCore::UniscribeHelper::applySpacing):
- (WebCore::UniscribeHelper::advanceForItem):
- * platform/graphics/chromium/UniscribeHelper.h: Added.
- (WebCore::UniscribeHelper::directionalOverride):
- (WebCore::UniscribeHelper::setDirectionalOverride):
- (WebCore::UniscribeHelper::inhibitLigate):
- (WebCore::UniscribeHelper::setInhibitLigate):
- (WebCore::UniscribeHelper::letterSpacing):
- (WebCore::UniscribeHelper::setLetterSpacing):
- (WebCore::UniscribeHelper::spaceWidth):
- (WebCore::UniscribeHelper::setSpaceWidth):
- (WebCore::UniscribeHelper::wordSpacing):
- (WebCore::UniscribeHelper::setWordSpacing):
- (WebCore::UniscribeHelper::setAscent):
- (WebCore::UniscribeHelper::init):
- (WebCore::UniscribeHelper::tryToPreloadFont):
- (WebCore::UniscribeHelper::Shaping::Shaping):
- (WebCore::UniscribeHelper::Shaping::glyphLength):
- (WebCore::UniscribeHelper::Shaping::charLength):
- (WebCore::UniscribeHelper::Shaping::effectiveAdvances):
- (WebCore::UniscribeHelper::nextWinFontData):
- (WebCore::UniscribeHelper::resetFontIndex):
- * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added.
- (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
- (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
- (WebCore::UniscribeHelperTextRun::nextWinFontData):
- (WebCore::UniscribeHelperTextRun::resetFontIndex):
- * platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
-
-2009-01-15 Chris Marrin <cmarrin@apple.com>
+2009-06-24 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
+
+ <rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.
- Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-01-15 Aaron Boodman <aa@chromium.org>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=15279
- Right clicking over text (or multiple spaces) auto selects the word
- (or multiple spaces) under it, which is not a desirable effect for some
- platforms.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::sendContextMenuEvent):
- Don't select words on right-click on Chromium.
+ * platform/network/mac/WebCoreURLResponse.mm:
+ (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.
-2009-01-15 Darin Fisher <darin@chromium.org>
+2009-06-24 Nicolas Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=23345
- SharedBuffer.h should include wtf/OwnPtr.h
-
- * platform/SharedBuffer.h:
-
-2009-01-14 David Kilzer <ddkilzer@apple.com>
-
- Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it
-
- <https://bugs.webkit.org/show_bug.cgi?id=23338>
-
- Reviewed by Timothy Hatcher.
-
- * WebCore.xcodeproj/project.pbxproj: Check to see if
- "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector"
- exists before trying to change directories into it and then
- deleting, modifying and adding files to it.
-
-2009-01-14 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
+ https://bugs.webkit.org/show_bug.cgi?id=26685
+ Accomodate for backwards-incompatible skia api changes.
- Fixing wx compilation for wx 2.9/trunk.
-
- * platform/graphics/wx/FontPlatformData.h:
- (WebCore::FontPlatformData::operator==):
- (WebCore::FontPlatformData::computeHash):
- * platform/graphics/wx/GraphicsContextWx.cpp:
- (WebCore::GraphicsContext::clip):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::setCompositeOperation):
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::createFrameAtIndex):
- * platform/graphics/wx/PathWx.cpp:
- (WebCore::Path::contains):
- * platform/wx/RenderThemeWx.cpp:
- (WebCore::RenderThemeWx::paintButton):
- (WebCore::RenderThemeWx::paintTextField):
- (WebCore::RenderThemeWx::paintMenuList):
- * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
-
-2009-01-14 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Adding WebKitCSSMatrix.
-
- * WebCoreSources.bkl:
-
-2009-01-14 Adam Treat <adam.treat@torchmobile.com>
-
- Prospective build fix for Qt following r39922.
-
- * WebCore.pro:
-
-2009-01-14 Darin Adler <darin@apple.com>
-
- Fix debug build.
-
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
- (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- Use ASSERT_UNUSED.
-
-2009-01-14 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
- <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
-
- No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
- we'll need a separate set of results for different themes.
-
- * css/themeWin.css: Renable search fields. Added new rules for sub-element placement.
-
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the
- desired width for the text block.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart.
- (WebCore::RenderThemeWin::determineState): ditto.
- (WebCore::RenderThemeWin::getClassicThemeData): ditto.
- (WebCore::RenderThemeWin::getThemeData): ditto.
- (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork.
- (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto.
- (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto.
- (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height.
- (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto.
- (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.
-
-2009-01-14 Alp Toker <alp@nuanti.com>
-
- GTK+ build fix following r39922.
- Add WebKitCSSMatrix to the build system.
-
- * GNUmakefile.am:
-
-2009-01-14 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implemented 2D WebKitCSSMatrix
- https://bugs.webkit.org/show_bug.cgi?id=21421
-
- Test: transforms/2d/cssmatrix-interface.xhtml
-
- * DerivedSources.make:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseWebKitCSSMatrix):
- (setJSDOMWindowBaseWebKitCSSMatrix):
- * bindings/js/JSWebKitCSSMatrixConstructor.cpp: Added.
- (WebCore::):
- (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- (WebCore::constructWebKitCSSMatrix):
- (WebCore::JSWebKitCSSMatrixConstructor::getConstructData):
- * bindings/js/JSWebKitCSSMatrixConstructor.h: Added.
- (WebCore::JSWebKitCSSMatrixConstructor::classInfo):
- * bindings/objc/DOMInternal.h:
- * css/WebKitCSSMatrix.cpp: Added.
- (WebCore::WebKitCSSMatrix::WebKitCSSMatrix):
- (WebCore::WebKitCSSMatrix::~WebKitCSSMatrix):
- (WebCore::WebKitCSSMatrix::setMatrixValue):
- (WebCore::WebKitCSSMatrix::multiply):
- (WebCore::WebKitCSSMatrix::inverse):
- (WebCore::WebKitCSSMatrix::translate):
- (WebCore::WebKitCSSMatrix::scale):
- (WebCore::WebKitCSSMatrix::rotate):
- (WebCore::WebKitCSSMatrix::toString):
- * css/WebKitCSSMatrix.h: Added.
- (WebCore::WebKitCSSMatrix::create):
- (WebCore::WebKitCSSMatrix::a):
- (WebCore::WebKitCSSMatrix::b):
- (WebCore::WebKitCSSMatrix::c):
- (WebCore::WebKitCSSMatrix::d):
- (WebCore::WebKitCSSMatrix::e):
- (WebCore::WebKitCSSMatrix::f):
- (WebCore::WebKitCSSMatrix::setA):
- (WebCore::WebKitCSSMatrix::setB):
- (WebCore::WebKitCSSMatrix::setC):
- (WebCore::WebKitCSSMatrix::setD):
- (WebCore::WebKitCSSMatrix::setE):
- (WebCore::WebKitCSSMatrix::setF):
- (WebCore::WebKitCSSMatrix::transform):
- * css/WebKitCSSMatrix.idl: Added.
-
-2009-01-14 Michael Moss <mmoss@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Workaround a skia limitation on repeated patterns, and remove extra
- transformations applied to pattern.
- https://bugs.webkit.org/show_bug.cgi?id=23332
-
- Fixes:
- LayoutTests/fast/canvas/patternfill-repeat.html
- LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
-
- * platform/graphics/skia/PatternSkia.cpp:
- (WebCore::Pattern::createPlatformPattern):
-
-2009-01-14 Mark Rowe <mrowe@apple.com>
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=23334
- Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp
-
- Include wtf/UnusedParam.h to get UNUSED_PARAM.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::hackAroundLibXMLEntityBug):
-
-2009-01-14 David Levin <levin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23333
- Platform code fixes. These compensate for changes in platform
- callbacks from WebKit and minor API tweaks.
-
- I enumerated a few below.
-
- * platform/graphics/chromium/FontCacheChromiumWin.cpp:
- fontExists has been gone since r34794.
-
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
-
- (WebCore::FrameData::clear):
- r39751 changes this api to take and return a bool.
-
(WebCore::Image::drawPattern):
- * platform/graphics/skia/PathSkia.cpp:
- (WebCore::Path::apply):
- (WebCore::boundingBoxForCurrentStroke):
- (WebCore::Path::strokeContains):
- * svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
-
-2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Eric Seidel.
-
- <https://bugs.webkit.org/show_bug.cgi?id=16829>
- Implement NPN_SetException()
-
- This mirrors the implementation in the obj-c bindings.
-
- Test: plugins/netscape-throw-exception.html
-
- * bridge/NP_jsobject.cpp:
- (_NPN_SetException):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::getExceptionString):
- (JSC::Bindings::CInstance::setGlobalException):
- (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
- (JSC::Bindings::CInstance::invokeMethod):
- (JSC::Bindings::CInstance::invokeDefaultMethod):
- (JSC::Bindings::CInstance::invokeConstruct):
- (JSC::Bindings::CInstance::getPropertyNames):
- * bridge/c/c_instance.h:
-
-2009-01-14 Pierre-Olivier Latour <pol@apple.com>
-
- Fixed build warning when LIBXML_VERSION >= 20627.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::hackAroundLibXMLEntityBug):
-
-2009-01-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23326
- Resources are never deleted from application cache disk database
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
- a cache is deleted. Note that this change doesn't require bumping schema version. We should
- consider switching to foreign keys and cascade delete instead of triggers in the future.
- (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
- to only remove the cache itself.
- (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
- is done automatically when a cache is deleted.
-
-2009-01-14 David Kilzer <ddkilzer@apple.com>
-
- Bug 22795: favicons should be saved to webarchives
-
- <https://bugs.webkit.org/show_bug.cgi?id=22795>
-
- Reviewed by Darin Adler.
-
- Test: webarchive/test-link-rel-icon.html
-
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
- favicon URLs to the list since no ArchiveResource or CachedResource
- is ever created for them.
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Handle favicons as a special
- case for all main resources.
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::close): Actually close the SQLite database
- so that isOpen() returns false when called. Added an ASSERT() for
- good measure.
-
-2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23321
- Upstream more bits of graphics/chromium.
-
- * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::operator=):
- (WebCore::FontPlatformData::~FontPlatformData):
- (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
- (WebCore::FontPlatformData::hashTableDeletedFontValue):
- (WebCore::FontPlatformData::scriptFontProperties):
- * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
- (WebCore::FontPlatformData::isHashTableDeletedValue):
- (WebCore::FontPlatformData::hfont):
- (WebCore::FontPlatformData::size):
- (WebCore::FontPlatformData::hash):
- (WebCore::FontPlatformData::operator==):
- (WebCore::FontPlatformData::scriptCache):
- (WebCore::FontPlatformData::RefCountedHFONT::create):
- (WebCore::FontPlatformData::RefCountedHFONT::hfont):
- (WebCore::FontPlatformData::RefCountedHFONT::hash):
- (WebCore::FontPlatformData::RefCountedHFONT::operator==):
- (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
- * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::~FontPlatformData):
- (WebCore::FontPlatformData::operator=):
- (WebCore::FontPlatformData::setupPaint):
- (WebCore::FontPlatformData::operator==):
- (WebCore::FontPlatformData::hash):
- (WebCore::FontPlatformData::isFixedPitch):
- * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::size):
- (WebCore::FontPlatformData::isHashTableDeletedValue):
- (WebCore::FontPlatformData::hashTableDeletedFontValue):
- * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
- (WebCore::):
- (WebCore::FontMap::getAscent):
- (WebCore::FontMap::FontData::FontData):
- (WebCore::getFontFamilyForScript):
- (WebCore::getFallbackFamily):
- (WebCore::getDerivedFontData):
- (WebCore::getStyleFromLogfont):
- * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
- (WebCore::):
-
-2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23325
- Upstream even more graphics/chromium bits.
-
- * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
- (WebCore::fillEmptyGlyphs):
- (WebCore::initSpaceGlyph):
- (WebCore::fillBMPGlyphs):
- (WebCore::fillNonBMPGlyphs):
- (WebCore::GlyphPage::fill):
- * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
- (WebCore::GlyphPage::fill):
- * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
- (WebCore::Icon::Icon):
- (WebCore::Icon::~Icon):
- (WebCore::Icon::createIconForFile):
- (WebCore::Icon::createIconForFiles):
- (WebCore::Icon::paint):
- * platform/graphics/chromium/IconChromiumMac.cpp: Added.
- (WebCore::Icon::createIconForFile):
- (WebCore::Icon::createIconForFiles):
- (WebCore::Icon::~Icon):
- (WebCore::Icon::paint):
- * platform/graphics/chromium/IconChromiumWin.cpp: Added.
- (WebCore::Icon::Icon):
- (WebCore::Icon::~Icon):
- (WebCore::Icon::createIconForFile):
- (WebCore::Icon::createIconForFiles):
- (WebCore::Icon::paint):
- * platform/graphics/chromium/ImageBufferData.h: Added.
- * platform/graphics/chromium/ImageChromiumMac.mm: Added.
- (WebCore::Image::loadPlatformResource):
- (WebCore::BitmapImage::initPlatformData):
- (WebCore::BitmapImage::invalidatePlatformData):
- * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
- * platform/graphics/chromium/PlatformIcon.h: Added.
-
-2009-01-14 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23328
- Upstream remaining files from platform/chromium/
-
- * platform/chromium/CursorChromium.cpp:
- (WebCore::pointerCursor):
- (WebCore::crossCursor):
- (WebCore::handCursor):
- (WebCore::iBeamCursor):
- (WebCore::waitCursor):
- (WebCore::helpCursor):
- (WebCore::eastResizeCursor):
- (WebCore::northResizeCursor):
- (WebCore::northEastResizeCursor):
- (WebCore::northWestResizeCursor):
- (WebCore::southResizeCursor):
- (WebCore::southEastResizeCursor):
- (WebCore::southWestResizeCursor):
- (WebCore::westResizeCursor):
- (WebCore::northSouthResizeCursor):
- (WebCore::eastWestResizeCursor):
- (WebCore::northEastSouthWestResizeCursor):
- (WebCore::northWestSouthEastResizeCursor):
- (WebCore::columnResizeCursor):
- (WebCore::rowResizeCursor):
- (WebCore::middlePanningCursor):
- (WebCore::eastPanningCursor):
- (WebCore::northPanningCursor):
- (WebCore::northEastPanningCursor):
- (WebCore::northWestPanningCursor):
- (WebCore::southPanningCursor):
- (WebCore::southEastPanningCursor):
- (WebCore::southWestPanningCursor):
- (WebCore::westPanningCursor):
- (WebCore::moveCursor):
- (WebCore::verticalTextCursor):
- (WebCore::cellCursor):
- (WebCore::contextMenuCursor):
- (WebCore::aliasCursor):
- (WebCore::progressCursor):
- (WebCore::noDropCursor):
- (WebCore::copyCursor):
- (WebCore::noneCursor):
- (WebCore::notAllowedCursor):
- (WebCore::zoomInCursor):
- (WebCore::zoomOutCursor):
- * platform/chromium/DragDataRef.h: Added.
- * platform/chromium/DragImageChromium.cpp: Added.
- (WebCore::dragImageSize):
- (WebCore::deleteDragImage):
- (WebCore::scaleDragImage):
- (WebCore::dissolveDragImageToFraction):
- (WebCore::createDragImageFromImage):
- (WebCore::createDragImageIconForCachedImage):
- * platform/chromium/DragImageRef.h:
- * platform/chromium/KeyCodeConversion.h: Added.
- * platform/chromium/KeyCodeConversionGtk.cpp: Added.
- (WebCore::windowsKeyCodeForKeyEvent):
- * platform/chromium/KeyboardCodes.h: Added.
- * platform/chromium/KeyboardCodesPosix.h: Added.
- (WebCore::):
- * platform/chromium/KeyboardCodesWin.h: Added.
- (WebCore::):
- * platform/chromium/Language.cpp: Added.
- (WebCore::defaultLanguage):
- * platform/chromium/LinkHashChromium.cpp: Added.
- (WebCore::visitedLinkHash):
- * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
- (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- (WebCore::MIMETypeRegistry::getMIMETypeForPath):
- (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
- (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
- (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
- (WebCore::dummyHashSet):
- (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
- (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
- (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
- (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
- (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- * platform/chromium/PasteboardChromium.cpp: Added.
- (WebCore::Pasteboard::generalPasteboard):
- (WebCore::Pasteboard::Pasteboard):
- (WebCore::Pasteboard::clear):
- (WebCore::Pasteboard::writeSelection):
- (WebCore::Pasteboard::writeURL):
- (WebCore::Pasteboard::writeImage):
- (WebCore::Pasteboard::canSmartReplace):
- (WebCore::Pasteboard::plainText):
- (WebCore::Pasteboard::documentFragment):
- * platform/chromium/PasteboardPrivate.h:
- * platform/chromium/PlatformCursor.h: Added.
- (WebCore::PlatformCursor::):
- (WebCore::PlatformCursor::PlatformCursor):
- (WebCore::PlatformCursor::customImage):
- (WebCore::PlatformCursor::hotSpot):
- (WebCore::PlatformCursor::type):
- * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
- (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
- (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- * platform/chromium/PlatformScreenChromium.cpp: Added.
- (WebCore::screenDepth):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenIsMonochrome):
- (WebCore::screenRect):
- (WebCore::screenAvailableRect):
- * platform/chromium/PlatformWidget.h:
- * platform/chromium/PopupMenuChromium.cpp: Added.
- (WebCore::PopupListBox::selectedIndex):
- (WebCore::PopupListBox::numItems):
- (WebCore::PopupListBox::setBaseWidth):
- (WebCore::PopupListBox::setTextOnIndexChange):
- (WebCore::PopupListBox::setAcceptOnAbandon):
- (WebCore::PopupListBox::):
- (WebCore::PopupListBox::ListItem::ListItem):
- (WebCore::PopupListBox::PopupListBox):
- (WebCore::PopupListBox::~PopupListBox):
- (WebCore::PopupListBox::disconnectClient):
- (WebCore::PopupListBox::scrollToRevealSelection):
- (WebCore::constructRelativeMouseEvent):
- (WebCore::constructRelativeWheelEvent):
- (WebCore::PopupContainer::create):
- (WebCore::PopupContainer::PopupContainer):
- (WebCore::PopupContainer::~PopupContainer):
- (WebCore::PopupContainer::showPopup):
- (WebCore::PopupContainer::hidePopup):
- (WebCore::PopupContainer::layout):
- (WebCore::PopupContainer::handleMouseDownEvent):
- (WebCore::PopupContainer::handleMouseMoveEvent):
- (WebCore::PopupContainer::handleMouseReleaseEvent):
- (WebCore::PopupContainer::handleWheelEvent):
- (WebCore::PopupContainer::handleKeyEvent):
- (WebCore::PopupContainer::hide):
- (WebCore::PopupContainer::paint):
- (WebCore::PopupContainer::paintBorder):
- (WebCore::PopupContainer::isInterestedInEventForKey):
- (WebCore::PopupContainer::show):
- (WebCore::PopupContainer::setTextOnIndexChange):
- (WebCore::PopupContainer::setAcceptOnAbandon):
- (WebCore::PopupContainer::refresh):
- (WebCore::PopupListBox::handleMouseDownEvent):
- (WebCore::PopupListBox::handleMouseMoveEvent):
- (WebCore::PopupListBox::handleMouseReleaseEvent):
- (WebCore::PopupListBox::handleWheelEvent):
- (WebCore::PopupListBox::isInterestedInEventForKey):
- (WebCore::PopupListBox::handleKeyEvent):
- (WebCore::PopupListBox::hostWindow):
- (WebCore::PopupListBox::invalidateRect):
- (WebCore::stripLeadingWhiteSpace):
- (WebCore::PopupListBox::typeAheadFind):
- (WebCore::PopupListBox::paint):
- (WebCore::PopupListBox::paintRow):
- (WebCore::PopupListBox::getRowFont):
- (WebCore::PopupListBox::abandon):
- (WebCore::PopupListBox::pointToRowIndex):
- (WebCore::PopupListBox::acceptIndex):
- (WebCore::PopupListBox::selectIndex):
- (WebCore::PopupListBox::setOriginalIndex):
- (WebCore::PopupListBox::getRowHeight):
- (WebCore::PopupListBox::getRowBounds):
- (WebCore::PopupListBox::invalidateRow):
- (WebCore::PopupListBox::scrollToRevealRow):
- (WebCore::PopupListBox::isSelectableItem):
- (WebCore::PopupListBox::adjustSelectedIndex):
- (WebCore::PopupListBox::updateFromElement):
- (WebCore::PopupListBox::layout):
- (WebCore::PopupListBox::clear):
- (WebCore::PopupListBox::isPointInBounds):
- (WebCore::PopupMenu::PopupMenu):
- (WebCore::PopupMenu::~PopupMenu):
- (WebCore::PopupMenu::show):
- (WebCore::PopupMenu::hide):
- (WebCore::PopupMenu::updateFromElement):
- (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- * platform/chromium/PopupMenuChromium.h: Added.
- (WebCore::PopupContainer::listBox):
- * platform/chromium/PopupMenuPrivate.h: Added.
- * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
- (WebCore::supportedKeySizes):
- * platform/chromium/ScrollbarThemeChromium.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
- (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
- (WebCore::ScrollbarThemeChromium::themeChanged):
- (WebCore::ScrollbarThemeChromium::hasThumb):
- (WebCore::ScrollbarThemeChromium::backButtonRect):
- (WebCore::ScrollbarThemeChromium::forwardButtonRect):
- (WebCore::ScrollbarThemeChromium::trackRect):
- (WebCore::ScrollbarThemeChromium::paintTrackBackground):
- (WebCore::ScrollbarThemeChromium::paintTickmarks):
- (WebCore::ScrollbarThemeChromium::paintScrollCorner):
- (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
- (WebCore::ScrollbarThemeChromium::buttonSize):
- * platform/chromium/ScrollbarThemeChromium.h: Added.
- (WebCore::ScrollbarThemeChromium::hasButtons):
- * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
- (WebCore::ScrollbarThemeChromium::scrollbarThickness):
- (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
- (WebCore::initMozState):
- (WebCore::paintScrollbarWidget):
- (WebCore::ScrollbarThemeChromium::paintTrackPiece):
- (WebCore::ScrollbarThemeChromium::paintButton):
- (WebCore::ScrollbarThemeChromium::paintThumb):
- * platform/chromium/ScrollbarThemeChromiumWin.cpp:
- * platform/chromium/SearchPopupMenuChromium.cpp: Added.
- (WebCore::SearchPopupMenu::SearchPopupMenu):
- (WebCore::SearchPopupMenu::enabled):
- (WebCore::SearchPopupMenu::saveRecentSearches):
- (WebCore::SearchPopupMenu::loadRecentSearches):
- * platform/chromium/SharedTimerChromium.cpp: Added.
- (WebCore::setSharedTimerFiredFunction):
- (WebCore::setSharedTimerFireTime):
- (WebCore::stopSharedTimer):
- * platform/chromium/TemporaryLinkStubs.cpp: Added.
- (WebCore::signedPublicKeyAndChallengeString):
- (WebCore::getSupportedKeySizes):
- (WebCore::KURL::fileSystemPath):
- (WebCore::SharedBuffer::createWithContentsOfFile):
- (WTF::scheduleDispatchFunctionsOnMainThread):
-
-2009-01-14 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23323
- Upstream platform/text/chromium/
-
- * platform/text/chromium: Added.
- * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
- (WebCore::currentTextBreakLocaleID):
-
-2009-01-14 Steve Falkenburg <sfalken@apple.com>
-
- Update copyright year in version resources.
-
- Reviewed by Adam Roben.
-
- * WebCore.vcproj/QTMovieWin.rc:
-
-2009-01-14 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23324
- Move platform/chromium/EditorChromium.cpp into editing/chromium/
-
- * editing/chromium: Added.
- * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
- * platform/chromium/EditorChromium.cpp: Removed.
-
-2009-01-14 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23320
- Make it possible to use notImplemented outside of the WebCore namespace
-
- * platform/NotImplemented.h:
-
-2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
-
- Reviewed by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=22476
- Check that the document's SecurityOrigin canLoadLocalResources,
- when pages try to put NSFilenamesPboardtype data on the clipboard,
- by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
-
- Tests: http/tests/security/dataTransfer-set-data-file-url.html
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
-
- * platform/mac/ClipboardMac.mm:
- (WebCore::ClipboardMac::setData):
-
-2009-01-14 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - update copyright
-
- * Info.plist:
-
-2009-01-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23316
- Application cache updating always fails with an assertion
-
- Test: http/tests/appcache/update-cache.html
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
- multiple caches survive the last DocumentLoader destruction, preventing a crash in release
- builds.
- (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
-
-2009-01-14 Alexey Proskuryakov <ap@webkit.org>
-
- Release build fix.
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
-
-2009-01-13 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Test: http/tests/appcache/xhr-foreign-resource.html
-
- https://bugs.webkit.org/show_bug.cgi?id=23256
- Implement application cache foreign entries
-
- * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
-
- * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- If a document that was loaded from appcache should be associated with a different cache,
- mark the resource as foreign in the original cache and start over.
-
- * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
- This function can now be called after a cache is stored, so it no longer asserts the opposite.
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
- in-memory caches that were already rejected.
- (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
- (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
- an already stored cached resource.
-
- * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
-
-2009-01-13 Mark Rowe <mrowe@apple.com>
-
- Fix the Tiger WebCore build after r39880.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markBadGrammar):
- * loader/mac/DocumentLoaderMac.cpp:
- (WebCore::DocumentLoader::schedule):
- (WebCore::DocumentLoader::unschedule):
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writeSelection):
- * platform/mac/WebCoreObjCExtras.mm:
- (WebCoreObjCFinalizeOnMainThread):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::schedule):
- (WebCore::ResourceHandle::unschedule):
-
-2009-01-13 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Bug 23102: turn on unused parameter warnings in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23102
-
- Last step: Turn on the warning and fix the last few instances.
-
- * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
- WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseMessageChannel): Separate the version for use when
- CHANNEL_MESSAGING is turned off, so we can omit the argument names.
- It would be better to not even have this property in that case,
- rather than having the function return undefined, but I don't know
- how to do that with the bindings script.
-
- * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
- functions where they're not used (the SVG context, and the property
- name in the index getter). Use UNUSED_PARAM where arguments are
- sometimes not used.
-
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
-
- * css/MediaQueryEvaluator.cpp:
- (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
- (WebCore::transitionMediaFeatureEval): Ditto.
- (WebCore::transform_2dMediaFeatureEval): Ditto.
- (WebCore::transform_3dMediaFeatureEval): Ditto.
-
- * dom/make_names.pl: Leave out the createdByParser property name in
- cases where it's not used.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
- version for the Mac platform so we can omit the argument names.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
-
- * loader/FrameLoaderClient.h:
- (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
- argument name.
-
- * loader/icon/IconFetcher.cpp:
- (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
- (WebCore::IconFetcher::didReceiveData): Ditto.
- (WebCore::IconFetcher::didFinishLoading): Ditto.
- (WebCore::IconFetcher::didFail): Ditto.
-
- * platform/KURL.cpp:
- (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
- we can omit the argument names.
-
- * platform/Timer.cpp:
- (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
-
- * platform/graphics/GlyphBuffer.h:
- (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
- (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::clear): Removed argument name.
-
- * rendering/SVGRenderSupport.cpp:
- (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
- is not enabled.
- (WebCore::finishRenderSVGContent): Ditto.
-
-2009-01-13 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Darin Adler.
-
- Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
- Simple fix to convertToLength to catch style==null cases
-
- * css/CSSStyleSelector.cpp:
- (WebCore::convertToLength):
-
-2009-01-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Speculative fix for an Uninitialized Memory Read (UMR)
- seen by purify in chormium's equivalent V8 file.
-
- * bindings/js/JSSVGPODTypeWrapper.h:
- (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
-
-2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Land portions of platform/graphics/chromium.
- https://bugs.webkit.org/show_bug.cgi?id=23297
-
- * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
- (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
- (WebCore::FontCustomPlatformData::fontPlatformData):
- (WebCore::EOTStream::EOTStream):
- (WebCore::EOTStream::read):
- (WebCore::readEmbedProc):
- (WebCore::createUniqueFontName):
- (WebCore::createFontCustomPlatformData):
- * platform/graphics/chromium/FontCustomPlatformData.h: Added.
- (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- * platform/graphics/chromium/FontLinux.cpp: Added.
- (WebCore::Font::drawGlyphs):
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- (WebCore::Font::selectionRectForComplexText):
- * platform/graphics/chromium/FontPlatformData.h: Added.
-
-2009-01-13 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Don't copy DOMStringList.idl into the framework bundle.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2009-01-13 Christian Dywan <christian@twotoasts.de>
-
- Build fix, StorageEvent is only defined if we have DOM_STORAGE
-
- * dom/Document.cpp:
- (WebCore::Document::createEvent): Conditionalize StorageEvent
-
-2009-01-13 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Bug 23277: space bar scrolls the page when typed in any text field
- https://bugs.webkit.org/show_bug.cgi?id=23277
- rdar://problem/6490249
-
- There's already a regression test for this, since bug 16421 was the same problem, but on
- Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
-
- This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
- a text input event from being generated at all. That difference may in itself be a bug, but
- the only symptom is that you get text input events in more cases on platforms other than Mac.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
- handled, not the result of the dispatchEvent function, which indicates only whether the
- default behavior was prevented, not if the default behavior did some insertion. This fix
- makes it so the keyboard event handler can detect that no space was inserted and know that
- the space bar keypress event can be treated as a scrolling command.
- (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
- keydown event. Without the change above, making this change would have restored the old
- behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
-
-2009-01-13 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Landing portions of platform/chromium/, taken from here:
- http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
-
- * platform/chromium/ChromiumBridge.h: Added.
- * platform/chromium/ChromiumDataObject.cpp: Added.
- (WebCore::ChromiumDataObject::clear):
- (WebCore::ChromiumDataObject::hasData):
- * platform/chromium/ChromiumDataObject.h: Added.
- (WebCore::ChromiumDataObject::create):
- (WebCore::ChromiumDataObject::ChromiumDataObject):
- * platform/chromium/ClipboardChromium.cpp: Added.
- (WebCore::):
- (WebCore::clipboardTypeFromMIMEType):
- (WebCore::ClipboardChromium::ClipboardChromium):
- (WebCore::ClipboardChromium::create):
- (WebCore::ClipboardChromium::clearData):
- (WebCore::ClipboardChromium::clearAllData):
- (WebCore::ClipboardChromium::getData):
- (WebCore::ClipboardChromium::setData):
- (WebCore::ClipboardChromium::types):
- (WebCore::ClipboardChromium::setDragImage):
- (WebCore::ClipboardChromium::setDragImageElement):
- (WebCore::ClipboardChromium::createDragImage):
- (WebCore::imageToMarkup):
- (WebCore::getCachedImage):
- (WebCore::writeImageToDataObject):
- (WebCore::ClipboardChromium::declareAndWriteDragImage):
- (WebCore::ClipboardChromium::writeURL):
- (WebCore::ClipboardChromium::writeRange):
- (WebCore::ClipboardChromium::hasData):
- * platform/chromium/ClipboardChromium.h: Added.
- (WebCore::ClipboardChromium::~ClipboardChromium):
- (WebCore::ClipboardChromium::dataObject):
- * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
- (WebCore::replaceNewlinesWithWindowsStyleNewlines):
- (WebCore::replaceNBSPWithSpace):
- (WebCore::urlToMarkup):
- * platform/chromium/ClipboardUtilitiesChromium.h: Added.
- * platform/chromium/ContextMenuChromium.cpp: Added.
- (WebCore::ContextMenu::ContextMenu):
- (WebCore::ContextMenu::~ContextMenu):
- (WebCore::ContextMenu::itemCount):
- (WebCore::ContextMenu::insertItem):
- (WebCore::ContextMenu::appendItem):
- (WebCore::ContextMenu::itemWithAction):
- (WebCore::ContextMenu::itemAtIndex):
- (WebCore::ContextMenu::setPlatformDescription):
- (WebCore::ContextMenu::platformDescription):
- (WebCore::ContextMenu::releasePlatformDescription):
- * platform/chromium/ContextMenuItemChromium.cpp: Added.
- (WebCore::ContextMenuItem::ContextMenuItem):
- (WebCore::ContextMenuItem::~ContextMenuItem):
- (WebCore::ContextMenuItem::releasePlatformDescription):
- (WebCore::ContextMenuItem::type):
- (WebCore::ContextMenuItem::action):
- (WebCore::ContextMenuItem::title):
- (WebCore::ContextMenuItem::platformSubMenu):
- (WebCore::ContextMenuItem::setType):
- (WebCore::ContextMenuItem::setAction):
- (WebCore::ContextMenuItem::setTitle):
- (WebCore::ContextMenuItem::setSubMenu):
- (WebCore::ContextMenuItem::setChecked):
- (WebCore::ContextMenuItem::setEnabled):
- (WebCore::ContextMenuItem::enabled):
- * platform/chromium/CursorChromium.cpp: Added.
- (WebCore::Cursor::Cursor):
- (WebCore::Cursor::~Cursor):
- (WebCore::Cursor::operator=):
- (WebCore::pointerCursor):
- (WebCore::crossCursor):
- (WebCore::handCursor):
- (WebCore::iBeamCursor):
- (WebCore::waitCursor):
- (WebCore::helpCursor):
- (WebCore::eastResizeCursor):
- (WebCore::northResizeCursor):
- (WebCore::northEastResizeCursor):
- (WebCore::northWestResizeCursor):
- (WebCore::southResizeCursor):
- (WebCore::southEastResizeCursor):
- (WebCore::southWestResizeCursor):
- (WebCore::westResizeCursor):
- (WebCore::northSouthResizeCursor):
- (WebCore::eastWestResizeCursor):
- (WebCore::northEastSouthWestResizeCursor):
- (WebCore::northWestSouthEastResizeCursor):
- (WebCore::columnResizeCursor):
- (WebCore::rowResizeCursor):
- (WebCore::middlePanningCursor):
- (WebCore::eastPanningCursor):
- (WebCore::northPanningCursor):
- (WebCore::northEastPanningCursor):
- (WebCore::northWestPanningCursor):
- (WebCore::southPanningCursor):
- (WebCore::southEastPanningCursor):
- (WebCore::southWestPanningCursor):
- (WebCore::westPanningCursor):
- (WebCore::moveCursor):
- (WebCore::verticalTextCursor):
- (WebCore::cellCursor):
- (WebCore::contextMenuCursor):
- (WebCore::aliasCursor):
- (WebCore::progressCursor):
- (WebCore::noDropCursor):
- (WebCore::copyCursor):
- (WebCore::noneCursor):
- (WebCore::notAllowedCursor):
- (WebCore::zoomInCursor):
- (WebCore::zoomOutCursor):
- (WebCore::grabCursor):
- (WebCore::grabbingCursor):
- * platform/chromium/DragDataChromium.cpp: Added.
- (WebCore::containsHTML):
- (WebCore::DragData::createClipboard):
- (WebCore::DragData::containsURL):
- (WebCore::DragData::asURL):
- (WebCore::DragData::containsFiles):
- (WebCore::DragData::asFilenames):
- (WebCore::DragData::containsPlainText):
- (WebCore::DragData::asPlainText):
- (WebCore::DragData::containsColor):
- (WebCore::DragData::canSmartReplace):
- (WebCore::DragData::containsCompatibleContent):
- (WebCore::DragData::asFragment):
- (WebCore::DragData::asColor):
- * platform/chromium/EditorChromium.cpp: Added.
- (WebCore::Editor::newGeneralClipboard):
- * platform/chromium/FileChooserChromium.cpp: Added.
- (WebCore::FileChooser::basenameForWidth):
- * platform/chromium/FileSystemChromium.cpp: Added.
- (WebCore::deleteFile):
- (WebCore::deleteEmptyDirectory):
- (WebCore::getFileSize):
- (WebCore::getFileModificationTime):
- (WebCore::directoryName):
- (WebCore::pathByAppendingComponent):
- (WebCore::makeAllDirectories):
- (WebCore::fileExists):
- * platform/chromium/FileSystemChromiumLinux.cpp: Added.
- (WebCore::pathGetFileName):
- * platform/chromium/FileSystemChromiumMac.mm: Added.
- (WebCore::pathGetFileName):
- * platform/chromium/FileSystemChromiumWin.cpp: Added.
- (WebCore::pathGetFileName):
- * platform/chromium/FramelessScrollView.cpp: Added.
- (WebCore::FramelessScrollView::~FramelessScrollView):
- (WebCore::FramelessScrollView::invalidateScrollbarRect):
- (WebCore::FramelessScrollView::isActive):
- (WebCore::FramelessScrollView::invalidateRect):
- (WebCore::FramelessScrollView::hostWindow):
- (WebCore::FramelessScrollView::windowClipRect):
- (WebCore::FramelessScrollView::paintContents):
- (WebCore::FramelessScrollView::contentsResized):
- (WebCore::FramelessScrollView::visibleContentsResized):
- * platform/chromium/FramelessScrollView.h: Added.
- (WebCore::FramelessScrollView::FramelessScrollView):
- (WebCore::FramelessScrollView::client):
- (WebCore::FramelessScrollView::setClient):
- * platform/chromium/FramelessScrollViewClient.h: Added.
- * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
- (WebCore::):
- (WebCore::ScrollbarThemeChromium::scrollbarThickness):
- (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
- (WebCore::ScrollbarThemeChromium::paintTrackPiece):
- (WebCore::ScrollbarThemeChromium::paintButton):
- (WebCore::ScrollbarThemeChromium::paintThumb):
- (WebCore::ScrollbarThemeChromium::getThemeState):
- (WebCore::ScrollbarThemeChromium::getThemeArrowState):
- (WebCore::ScrollbarThemeChromium::getClassicThemeState):
- * platform/chromium/SoundChromiumPosix.cpp: Added.
- (WebCore::systemBeep):
- * platform/chromium/SoundChromiumWin.cpp: Added.
- (WebCore::systemBeep):
- * platform/chromium/SystemTimeChromium.cpp: Added.
- (WebCore::currentTime):
- (WebCore::userIdleTime):
- * platform/chromium/WidgetChromium.cpp: Added.
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- (WebCore::Widget::setCursor):
- (WebCore::Widget::paint):
- (WebCore::Widget::setFocus):
- (WebCore::Widget::setIsSelected):
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * platform/chromium/WindowsVersion.cpp: Added.
- (WebCore::isVistaOrNewer):
- * platform/chromium/WindowsVersion.h: Added.
-
-2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Make sure media elements dispatch the 'loaded' event
-
- We assume that when Phonon goes into paused state that we have the
- complete media file. Once we do media loading ourselves we can
- distinguish between loading the first frame and the complete media.
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::updateStates):
-
-2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt] Add more verbose error output when loading NPAPI plugins
-
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::load):
-
-2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix crash in the Qt port when deleting a popup from within a
- JavaScript onchange handler.
-
- * platform/qt/QWebPopup.cpp:
- (WebCore::QWebPopup::QWebPopup): Perform the activation of the
- combobox item (i.e. the call to the JS handler) from a different
- call stack by using a queued connection.
-
-2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Tor Arne Vestbø.
-
- [GIO] Make sure to untef the GFile and the GInputStream on destruction
-
- Make sure to call cleanupGioOperation from the ResourceHandleInternal
- d'tor. Change the signature of cleanupGioOperation so we can do the
- cleanup of GIO next to the cleanup of SOUP.
-
- This is happening with many tests from dom/html/level2/html e.g.
- LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- (WebCore::cleanupGioOperation):
- (WebCore::closeCallback):
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
-
-2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Tor Arne Vestbø.
-
- [GIO] Attach the ResourceHandle to the GObject and get it from the GObject
-
- https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
-
- Sometimes it is not possible to cancel a pending GIO operation and the
- callback might be invoked with a pointer to an already destructed
- ResourceHandle. To avoid this issue we will attach the ResourceHandle
- to the GObject* and in the callback attempt to get the ResourceHandle
- from the GObject*. If no ResourceHandle is attached we silently fail
- as the cleanup has been already done.
-
- This is happening with many tests from dom/html/level2/html e.g.
- LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::cleanupGioOperation):
- (WebCore::closeCallback):
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
- (WebCore::ResourceHandle::startGio):
-
-2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Tor Arne Vestbø.
-
- [GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
-
- https://bugs.webkit.org/show_bug.cgi?id=23116
-
- The ResourceHandle becomes invalid (e.g. got destructed) from within
- the invocation of didFail. Avoid this by cleaning up everything before
- calling didFail and simply return afterwards.
-
- This is happening with many tests from dom/html/level2/html e.g.
- LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
-
-2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Change how themes adjust mediaControls.css to match html4/quicks.css
-
- Instead of providing the full style sheet, the themes provide extra
- overrides to the default style defined in UserAgentStyleSheetsData.
-
- https://bugs.webkit.org/show_bug.cgi?id=23210
-
- Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
- build time for the Qt port.
-
- * Resources/WebKitResources.qrc: Removed. Merged into WebCore.qrc
- * WebCore.pro:
- * WebCore.qrc: Added.
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::styleForElement):
- * css/qt/mediaControls-extras.css: Rename from html4-adjustments-qt.css
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
- * platform/qt/RenderThemeQt.h:
- * platform/qt/WebCoreResources.qrc: Removed.
- * platform/qt/html4-adjustments-qt.css: Rename to mediaControls-extras.css
- * rendering/RenderTheme.cpp:
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::extraMediaControlsStyleSheet):
-
-2009-01-12 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
-
- * bindings/js/JSSQLTransactionCustom.cpp:
- (WebCore::JSSQLTransaction::executeSql):
- * bindings/objc/WebScriptObject.mm:
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
-
-2009-01-12 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
-
- I added a common getElapsedTime() function to AnimationBase which uses a combination of
- the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
- states.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::progress):
- (WebCore::AnimationBase::getElapsedTime):
- * page/animation/AnimationBase.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
-
-2009-01-12 Robert Blaut <webkit@blaut.biz>
-
- Reviewed by Darin Adler
-
- Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
- Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds
- instead of miliseconds
-
- Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::validUnit): treat unitless values in quirks mode
- as miliseconds instead of seconds.
-
-2009-01-12 David Hyatt <hyatt@apple.com>
-
- Apply the same idea as the previous fix but for matched declarations.
-
- Reviewed by Dan Bernstein
-
- * css/CSSStyleSelector.h:
-
-2009-01-12 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin Adler
-
- <rdar://problem/6468274> - Track Non-get requests in global history
-
- * WebCore.base.exp:
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::HistoryItem):
- * history/HistoryItem.h:
- (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
- (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
-
-2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
-
- !ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header
- so it can be used by all builds.
-
- * platform/graphics/Font.h:
- * platform/graphics/SimpleFontData.cpp:
- * svg/SVGFontFaceElement.cpp:
- * svg/SVGFontFaceElement.h:
-
-2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build typo fix.
-
- * platform/graphics/wx/TransformationMatrixWx.cpp:
- (WebCore::TransformationMatrix::TransformationMatrix):
-
-2009-01-12 David Hyatt <hyatt@apple.com>
-
- Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
- elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
-
- Reviewed by Oliver Hunt
-
- * css/CSSStyleSelector.h:
-
-2009-01-12 David Hyatt <hyatt@apple.com>
-
- Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
- two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
- Tiny speedup.
-
- Reviewed by Oliver Hunt
-
- * dom/Element.cpp:
- (WebCore::Element::attributeChanged):
-
-2009-01-12 David Hyatt <hyatt@apple.com>
-
- Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
- default to the normal case. Tiny speedup on PLT.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::lineHeight):
-
-2009-01-12 David Hyatt <hyatt@apple.com>
-
- Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
- in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
-
-2009-01-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=23273
-
- In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
- to be computed in absolute coordintes. Instead, we compute a repaintRect
- relative to the RenderObject, which can repaint itself.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::repaintLayerRectsForImage):
-
-2009-01-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=23220
-
- Merge layoutDelta into LayoutState. This requires that we
- push even when layoutState is disabled, so that layoutDelta
- can still be stored.
-
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- * rendering/LayoutState.h:
- (WebCore::LayoutState::LayoutState):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::layoutBlockChildren):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::absoluteToLocal):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPositions):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
- (WebCore::RenderTableCell::localToAbsolute):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::pushLayoutState):
- * rendering/RenderView.h:
- (WebCore::RenderView::layoutDelta):
- (WebCore::RenderView::addLayoutDelta):
- (WebCore::RenderView::doingFullRepaint):
- (WebCore::RenderView::pushLayoutState):
- (WebCore::RenderView::popLayoutState):
- (WebCore::RenderView::layoutStateEnabled):
- (WebCore::RenderView::layoutState):
- (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
- (WebCore::LayoutStateMaintainer::push):
- (WebCore::LayoutStateMaintainer::pop):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::layoutInlineChildren):
-
-2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Reviewed by Holger Freyther.
-
- [Qt] Build fix after turning the fontCache to a singleton
- https://bugs.webkit.org/show_bug.cgi?id=23253
-
- Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
-
- * platform/graphics/qt/FontCacheQt.cpp:
- (WebCore::fontCache):
- (WebCore::FontCache::FontCache):
-
-2009-01-12 Eric Roman <eroman@chromium.org>
-
- Reviewed by Darin Adler.
-
- Fix some bugs with Selection::appendTrailingWhitespace().
- https://bugs.webkit.org/show_bug.cgi?id=23232
-
- Test: editing/selection/doubleclick-whitespace-crash.html
-
- * editing/Selection.cpp:
- (WebCore::makeSearchRange):
- (WebCore::Selection::appendTrailingWhitespace):
-
-2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add the first pieces of platform/graphics/chromium
- https://bugs.webkit.org/show_bug.cgi?id=23257
-
- * platform/graphics/chromium/ColorChromium.cpp: Added.
- (WebCore::focusRingColor):
- * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
- (WebCore::FontCache::platformInit):
- (WebCore::isStringASCII):
- (WebCore::LookupAltName):
- (WebCore::FontCodepage::):
- (WebCore::FontCodepage::if):
- (WebCore::createFontIndirectAndGetWinName):
- (WebCore::fontContainsCharacter):
- (WebCore::FontCache::getFontDataForCharacters):
- (WebCore::FontCache::alternateFamilyName):
- (WebCore::FontCache::getSimilarFontPlatformData):
- (WebCore::FontCache::getLastResortFallbackFont):
- (WebCore::toGDIFontWeight):
- (WebCore::FontCache::getGenericFontForScript):
- (WebCore::FillLogFont):
- (WebCore::FontCache::fontExists):
- (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
- (WebCore::traitsInFamilyEnumProc):
- (WebCore::FontCache::getTraitsInFamily):
- (WebCore::FontCache::createFontPlatformData):
- * platform/graphics/chromium/FontCacheLinux.cpp: Added.
- (WebCore::FontCache::platformInit):
- (WebCore::FontCache::getFontDataForCharacters):
- (WebCore::FontCache::alternateFamilyName):
- (WebCore::FontCache::getSimilarFontPlatformData):
- (WebCore::FontCache::getLastResortFallbackFont):
- (WebCore::FontCache::getTraitsInFamily):
- (WebCore::FontCache::createFontPlatformData):
- (WebCore::FontCache::getGenericFontForScript):
- * platform/graphics/chromium/FontChromiumWin.cpp: Added.
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::skiaDrawText):
- (WebCore::PaintSkiaText):
- (WebCore::Font::drawGlyphs):
- (WebCore::Font::selectionRectForComplexText):
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
-
-2009-01-12 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23254
- Upstream page/chromium/
-
- * page/chromium/AXObjectCacheChromium.cpp: Added.
- (WebCore::AXObjectCache::detachWrapper):
- (WebCore::AXObjectCache::attachWrapper):
- (WebCore::AXObjectCache::postNotification):
- (WebCore::AXObjectCache::postNotificationToElement):
- (WebCore::AXObjectCache::handleFocusedUIElementChanged):
- * page/chromium/AccessibilityObjectChromium.cpp:
- * page/chromium/AccessibilityObjectWrapper.h:
- * page/chromium/ChromeClientChromium.h: Added.
- * page/chromium/DragControllerChromium.cpp: Added.
- (WebCore::DragController::dragOperation):
- (WebCore::DragController::isCopyKeyDown):
- (WebCore::DragController::maxDragImageSize):
- (WebCore::DragController::cleanupAfterSystemDrag):
- * page/chromium/EventHandlerChromium.cpp: Added.
- (WebCore::EventHandler::passMousePressEventToSubframe):
- (WebCore::EventHandler::passMouseMoveEventToSubframe):
- (WebCore::EventHandler::passMouseReleaseEventToSubframe):
- (WebCore::EventHandler::passWheelEventToWidget):
- (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
- (WebCore::EventHandler::passMouseDownEventToWidget):
- (WebCore::EventHandler::tabsToAllControls):
- (WebCore::EventHandler::eventActivatedView):
- (WebCore::EventHandler::createDraggingClipboard):
- (WebCore::EventHandler::focusDocumentView):
- (WebCore::EventHandler::accessKeyModifiers):
- * page/chromium/FrameChromium.cpp: Added.
- (WebCore::computePageRectsForFrame):
- (WebCore::Frame::dragImageForSelection):
- * page/chromium/FrameChromium.h: Added.
-
-2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22936
- Fix uninitialized memory read error, reported by Purify.
-
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData): Added initializer for
- m_unitsPerEm using cDefaultUnitsPerEm constant.
- * svg/SVGFontFaceElement.cpp:
- (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
- the constant.
- * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
-
-2009-01-12 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Do not set fixedLayoutSize for anything other than the mainframe during
- the transition as this is a page level state like the viewportSize.
-
- * loader/FrameLoaderClient.cpp:
- (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
-
-2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Reviewed by Darin Adler.
-
- Bug 22861: Turn the FontCache into a singleton
- https://bugs.webkit.org/show_bug.cgi?id=22861
-
- - Added fontCache() to get the global FontCache.
-
- - Made all the methods in FontCache instance method.
-
- - Changed FontCache:: to fontCache()-> in WebCore.
-
- * WebCore.base.exp: Now export fontCache().
- * css/CSSFontFaceSource.cpp:
- (WebCore::CSSFontFaceSource::getFontData):
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::CSSFontSelector):
- (WebCore::CSSFontSelector::~CSSFontSelector):
- (WebCore::CSSFontSelector::addFontFaceRule):
- (WebCore::fontDataForGenericFamily):
- * platform/graphics/Font.cpp:
- (WebCore::Font::glyphDataForCharacter):
- * platform/graphics/FontCache.cpp:
- (WebCore::fontCache):
- (WebCore::FontCache::FontCache):
- * platform/graphics/FontCache.h:
- * platform/graphics/FontFallbackList.cpp:
- (WebCore::FontFallbackList::FontFallbackList):
- (WebCore::FontFallbackList::invalidate):
- (WebCore::FontFallbackList::releaseFontData):
- (WebCore::FontFallbackList::fontDataAt):
- (WebCore::FontFallbackList::fontDataForCharacters):
- (WebCore::FontFallbackList::setPlatformFont):
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::~SimpleFontData):
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::fontCacheATSNotificationCallback):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::smallCapsFontData):
- * platform/graphics/win/FontCacheWin.cpp:
- (WebCore::getCJKCodePageMasks):
- * platform/graphics/win/SimpleFontDataWin.cpp:
- (WebCore::SimpleFontData::containsCharacters):
-
-2009-01-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
- https://bugs.webkit.org/show_bug.cgi?id=23247
-
- Also fix problems where partially parsed paths will still have an effect
- rather than failing parsing and being ignored.
-
- Test: dom/path-segments.html
-
- * platform/graphics/Path.h:
- (WebCore::Path::swap): Added.
-
- * svg/SVGParserUtilities.cpp:
- (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
- (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
- (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
- parsing fails.
- (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
- not directly into the segment list.
- (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
- (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
- (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
- (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
- (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
- (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
- (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
- (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
- (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
-
- * svg/SVGPathSegCurvetoCubicSmooth.h:
- (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
- Set y2 to y2, not to y.
-
-2009-01-11 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23102: turn on unused parameter warnings in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23102
-
- Fourth step: Remove arguments entirely in the many cases where they are not
- needed at all. This step is a little less mechanical than the earlier ones.
-
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
- the regular expression, since we already specify a-zA-Z in our expression.
-
- * dom/Document.cpp:
- (WebCore::Document::databaseThread): Don't pass in the document when creating
- a DatabaseThread.
-
- * dom/Element.cpp:
- (WebCore::Element::createRareData): Don't pass the element when creating an
- ElementRareData.
- (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
- (WebCore::Element::recalcStyle): Ditto.
-
- * dom/ElementRareData.h: Remove the unused Element* from the constructor and
- the resetComputedStyle function.
-
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
- (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
- (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
- * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
-
- * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
- (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
- start and end arguments.
- (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
- and end to pushDownTextDecorationStyleAroundNode.
-
- * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
- unused start and end arguments from pushDownTextDecorationStyleAroundNode.
-
- * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
-
- * html/HTMLTokenizer.cpp:
- (WebCore::Token::addAttribute): Removed unused Document* argument.
- (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
-
- * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
-
- * page/DragController.cpp:
- (WebCore::DragController::dragIsMove): Removed unused DragData argument.
- (WebCore::DragController::performDrag): Call concludeEditDrag rather than
- concludeDrag.
- (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
- (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
- should only be called for edit drags. Removed the action mask argument. Also
- changed dragIsMove call sites to not pass dragData.
-
- * page/DragController.h: Updated for above changes and tweaked comment format.
-
- * page/Frame.cpp:
- (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
- when creating regular expressions for clarity. Call match instead of search,
- since both do the same thing except for with negative start offsets, and none
- used here are negative.
- (WebCore::Frame::matchLabelsAgainstElement): Ditto.
-
- * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (AXAttributeStringSetHeadingLevel): Removed unused object argument.
- (AXAttributedStringAppendText): Ditto.
- (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
-
- * page/mac/FrameMac.mm:
- (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
- when creating regular expressions for clarity. Call match instead of search,
- since both do the same thing except for with negative start offsets, and none
- used here are negative.
- (WebCore::Frame::matchLabelsAgainstElement): Ditto.
-
- * platform/graphics/SegmentedFontData.cpp:
- (WebCore::SegmentedFontData::containsCharacter): Added.
- (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
- instead of just the first one, using containsCharacter.
-
- * platform/graphics/SegmentedFontData.h: Made more members private.
- Added containsCharacter function member.
-
- * platform/mac/DragImageMac.mm:
- (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
- DragImageRef for clarity, since this is platform-specific code.
- (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
- variable warning.
- (WebCore::scaleDragImage): Ditto.
- (WebCore::dissolveDragImageToFraction): Ditto.
- (WebCore::createDragImageFromImage): Ditto.
- (WebCore::createDragImageIconForCachedImage): Ditto.
-
- * platform/mac/WebFontCache.mm:
- (acceptableChoice): Removed the unused weight-related arguments.
- (betterChoice): Ditto.
- (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
-
- * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
- because we'd rather get a link error rather than a runtime error if we use it
- for anything, and right now it's not used.
-
- * platform/text/RegularExpression.cpp: Removed unused private data,
- including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
- and lastMatchPos. Made the RegularExpression::Private::regex be private
- and use an accessor function to get at it.
- (WebCore::RegularExpression::RegularExpression): Removed the const char* version
- of the constructor because it's not any more efficient. Changed the boolean
- constructor argument to use TextCaseSensitivity instead to make it less likely
- we'll use it wrong.
- (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
- just use plain old assignment on it. The only reason we do this instead of using
- the compiler generated assignment operator is that we want the Private structure
- to be internal to the .cpp file.
- (WebCore::RegularExpression::match): Added a null check so we won't crash if
- we fail to compile the regular expression. Removed the code to handle multiple
- match strings, since that was unused.
-
- * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
- TextCaseSensitivity and not have a default value. Removed the default constructor,
- and the pattern, match, and pos functions.
-
- * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
- Page.h, because we should eventually use it in all the places where we have
- an argument to control case sensitivity, starting with the functions in this
- class.
-
- * platform/text/mac/ShapeArabic.c:
- (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
- this is code borrowed from ICU, this seems like a simple safe change to make.
- (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
-
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::RenderPath): Removed the unused style argument.
- Also removed the type check. The argument already has the correct type,
- so it's not helpful to upcast it and then check its type again, unless
- we have some reason to believe the type is not reliable. And we don't.
-
- * rendering/RenderPath.h: Removed the RenderStyle* argument to the
- constructor. Also removed the explicit declaration of the destructor.
- It's not helpful or needed.
-
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
- make it clear that just returning an empty rect is not a good implementation.
- Removed the argument names to get rid of the warning.
-
- * rendering/RenderTreeAsText.cpp:
- (WebCore::printBorderStyle): Removed the unused RenderObject argument.
- (WebCore::operator<<): Updated for the change to printBorderStyle function.
-
- * storage/DatabaseThread.cpp:
- (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
- * storage/DatabaseThread.h: Ditto.
-
- * storage/LocalStorage.cpp:
- (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
- * storage/LocalStorage.h: Ditto.
-
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
- code location to dispatchGenericEvent.
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::dispatchEvent): Ditto.
-
- * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
- (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
- the RenderPath constructor.
-
- * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
-
- * xml/XSLTProcessor.cpp:
- (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
- (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
-
-2009-01-11 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23165
- Disable application cache dynamic entries support.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- * loader/appcache/DOMApplicationCache.idl:
-
-2009-01-11 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Correct coordinate transformation for deeply nested frames on resizing. This
- fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
-
- Test: fast/frames/frame-deep-nested-resize.html
-
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::userResize):
-
-2009-01-11 Mark Rowe <mrowe@apple.com>
-
- Tiger build fix. The connection parameter is still used on Tiger in this method.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
-
-2009-01-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23102: turn on unused parameter warnings in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23102
-
- Third step: Deal with cases of arguments used only in assertions.
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
- * dom/Worker.cpp:
- (WebCore::Worker::notifyFinished): Ditto.
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished): Ditto.
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
- * loader/icon/IconLoader.cpp:
- (WebCore::IconLoader::didReceiveData): Since loader and size are only
- used when logging, use UNUSED_PARAM when logging is disabled.
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
- argument since it's probably a tiny bit more efficient and gets rid
- of the unused argument warning.
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::createInlineBox): Ditto.
- * rendering/RenderSVGInline.cpp:
- (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
- I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
- the only use for two different arguments.
- * rendering/RenderText.cpp:
- (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
- * rendering/RenderThemeMac.mm:
- (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
-
-2009-01-11 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Oliver Hunt
-
- https://bugs.webkit.org/show_bug.cgi?id=23242
-
- Fix CanvasRenderingContext2D::transform to do a pre-multiply,
- rather than a post-multiply into m_transform. This bug did not affect
- drawing, but did cause m_transform to be incorrect, which impacted
- willDraw(), and isPointInPath.
-
- Test: fast/canvas/canvas-incremental-repaint-2.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::transform):
-
-2009-01-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23102: turn on unused parameter warnings in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23102
-
- Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
- That's because you can't omit an argument name in Objective-C methods.
-
- * bindings/objc/DOMObject.mm:
- (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
- the word "unused" so we don't just start using it without removing the macro.
- * bindings/objc/WebScriptObject.mm:
- (+[WebUndefined allocWithZone:]): Ditto.
- (-[WebUndefined initWithCoder:]): Ditto.
- (-[WebUndefined encodeWithCoder:]): Ditto.
- (-[WebUndefined copyWithZone:]): Ditto.
- * page/mac/WebDashboardRegion.m:
- (-[WebDashboardRegion copyWithZone:]): Ditto.
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
- (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
- (-[WebCoreMovieObserver rateChanged:]): Ditto.
- (-[WebCoreMovieObserver sizeChanged:]): Ditto.
- (-[WebCoreMovieObserver timeChanged:]): Ditto.
- (-[WebCoreMovieObserver didEnd:]): Ditto.
- (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
- * platform/mac/ScrollbarThemeMac.mm:
- (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
- (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
- * platform/mac/SharedTimerMac.mm:
- (-[WebCorePowerNotifier didWake:]): Ditto.
- * platform/mac/WebCoreKeyGenerator.m:
- (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
- (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
- (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
- (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
- (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
- (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
- (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
- (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
-
-2009-01-11 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Darin Adler.
-
- Move platform dependent strokeContains back to RenderPath, Path and delete
- unneeded Code in svg.
-
- RenderPath clean-up for strokeContains
- [https://bugs.webkit.org/show_bug.cgi?id=22957]
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/Path.h:
- * platform/graphics/cairo/PathCairo.cpp:
- (WebCore::Path::strokeContains):
- * platform/graphics/cg/PathCG.cpp:
- (WebCore::Path::strokeContains):
- * platform/graphics/qt/PathQt.cpp:
- (WebCore::Path::strokeContains):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::strokeContains):
- * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
- * svg/graphics/cg/CgSupport.cpp: Removed.
- * svg/graphics/cg/CgSupport.h: Removed.
- * svg/graphics/cg/RenderPathCg.cpp: Removed.
- * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
- * svg/graphics/cg/SVGResourceMaskerCg.mm:
- * svg/graphics/qt/RenderPathQt.cpp: Removed.
-
-2009-01-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Anders Carlsson.
-
- [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
-
- make distcheck pass by adding JSWorkerContextBase.lut.h to the
- CLEANFILES that will be cleaned on a make distclean.
-
- * GNUmakefile.am:
-
-2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23235
- Build fix for non-VIDEO builds.
-
- * rendering/RenderTheme.cpp:
- * rendering/RenderTheme.h:
-
-2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19287
- return value of malloc() is not checked in npruntime.cpp
-
- Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
- (like in fastMalloc).
-
- * bridge/npruntime.cpp:
- (_NPN_GetStringIdentifier):
- (_NPN_GetIntIdentifier):
- (NPN_InitializeVariantWithStringCopy):
- (_NPN_CreateObject):
-
-2009-01-11 Glenn Wilson <gwilson@google.com>
-
- Reviewed by Darin Adler.
-
- Changes radio buttons so they can be 'checked' even if they
- don't have the name attribute set.
-
- See https://bugs.webkit.org/show_bug.cgi?id=21534
-
- Test: fast/html/select-unnamed-radio.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::preDispatchEventHandler):
-
-2009-01-11 Bernhard Rosenkraenzer <bero@arklinux.ch>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22205
- Fix compatibility with bison 2.4, partially based on older patch by
- Priit Laes <amd@store20.com>
-
- * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
-
-2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=16001
- Incorrect assumption that selection is always contiguous LTR.
-
- Test: editing/selection/extend-selection-bidi.html
-
- * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
- Make this function not assume a contiguous visual LTR selection range.
-
-2009-01-11 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23207
- Moved currentTime() to from WebCore to WTF.
-
- Most of these files only have a different header file included.
- Various build files reflect removal of SystemTimeGtk, Wx, Qt and Linux
- which were removed since they only implemented currentTime().
-
- * ForwardingHeaders/wtf/CurrentTime.h: Added.
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.pro:
- * dom/ContainerNode.cpp:
- * dom/Document.cpp:
- * dom/Event.cpp:
- * history/CachedPage.cpp:
- * history/PageCache.cpp:
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::load):
- (WebCore::HTMLMediaElement::progressEventTimerFired):
- * html/HTMLTokenizer.cpp:
- * html/PreloadScanner.cpp:
- * inspector/InspectorController.cpp:
- * loader/Cache.cpp:
- (WebCore::Cache::pruneLiveResources):
- * loader/CachedImage.cpp:
- * loader/CachedResource.cpp:
- * loader/FrameLoader.cpp:
- * loader/ProgressTracker.cpp:
- * loader/icon/IconDatabase.cpp:
- * loader/icon/IconRecord.cpp:
- * page/DragController.cpp:
- * page/Frame.cpp:
- * page/FrameView.cpp:
- * page/animation/AnimationBase.cpp:
- * page/animation/AnimationController.cpp:
- * page/animation/KeyframeAnimation.cpp:
- * platform/SystemTime.h:
- * platform/Timer.cpp:
- * platform/graphics/BitmapImage.cpp:
- * platform/gtk/MouseEventGtk.cpp:
- * platform/gtk/SharedTimerGtk.cpp:
- * platform/gtk/SystemTimeGtk.cpp: Removed.
- * platform/gtk/SystemTimeLinux.cpp: Removed.
- * platform/mac/SystemTimeMac.cpp:
- * platform/qt/PlatformMouseEventQt.cpp:
- (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- * platform/qt/SharedTimerQt.cpp:
- * platform/qt/SharedTimerQt.h:
- * platform/qt/SystemTimeQt.cpp: Removed.
- * platform/win/SharedTimerWin.cpp:
- * platform/win/SystemTimeWin.cpp:
- * platform/wx/MouseEventWx.cpp:
- (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- * platform/wx/SharedTimerWx.cpp:
- * platform/wx/SystemTimeWx.cpp: Removed.
- * rendering/RenderImage.cpp:
- * rendering/RenderMedia.cpp:
- * svg/animation/SMILTimeContainer.cpp:
- * webcore-wx.bkl:
- * xml/XMLHttpRequest.cpp:
-
-2009-01-11 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
- Part of 'Timers in Workers' work.
- https://bugs.webkit.org/show_bug.cgi?id=23223
-
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
- (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
- * bindings/js/ScheduledAction.h:
-
-2009-01-10 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23210
- Make it easier for ports to define custom UI for media controls
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
- get the media controller style sheet
-
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlInputElement::hitTest): Added
- * rendering/MediaControlElements.h: Updated
-
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
- so control elements don't necessarily have to be rectangular
-
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::styleSheetForMediaControls): Added
- (WebCore::RenderTheme::hitTestMediaControlPart): Added
- * rendering/RenderTheme.h: Updated
-
-2009-01-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=23222
-
- We need to disable LayoutState when an object has transforms,
- because LayoutState is not transform-aware and therefore
- repaint rects can be computed incorrectly.
-
- Test: fast/repaint/transform-disable-layoutstate.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
-
-2009-01-09 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [QT] Make SharedTimer use QBasicTimer
-
- Kill the SharedTimerQt.h and the usage of signal and slots
- by using QBasicTimer.
-
- * WebCore.pro:
- * platform/qt/SharedTimerQt.cpp:
- (WebCore::SharedTimerQt::SharedTimerQt):
- (WebCore::SharedTimerQt::inst):
- (WebCore::SharedTimerQt::start):
- (WebCore::SharedTimerQt::stop):
- (WebCore::SharedTimerQt::timerEvent):
- (WebCore::setSharedTimerFiredFunction):
- (WebCore::setSharedTimerFireTime):
- (WebCore::stopSharedTimer):
- * platform/qt/SharedTimerQt.h: Removed.
-
-2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
-
- Reviewed by Holger Freyther.
-
- [CURL] POST without body becomes GET
- https://bugs.webkit.org/show_bug.cgi?id=23182
-
- Make sure that method is always set to POST even when the body is
- empty. Cleaned up httpBody null check.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::setupPOST):
-
-2009-01-09 Adam Treat <adam.treat@torchmobile.com>
-
- Build fix.
-
- * plugins/PluginView.cpp:
-
-2009-01-09 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
- how it was before RenderTextControlSingleLine was split out from RenderTextControl.
-
- No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
-
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
-
-2009-01-09 Darin Adler <darin@apple.com>
-
- Reviewed by Jon Honeycutt.
-
- Bug 22913: REGRESSION: Space bar doesn't scroll on windows
- https://bugs.webkit.org/show_bug.cgi?id=22913
- rdar://problem/6479834
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
- defaultSpaceEventHandler.
- (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
- on the shift key.
- * page/EventHandler.h: Added defaultSpaceEventHandler.
-
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformScroll): Return false, because this function does
- not scroll. In an earlier version of this patch, I used this to prevent the
- patch from affecting the Mac, but I decided to use #if instead.
-
-2009-01-09 Gavin Barraclough <barraclough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Delete references to JSValue, removing this class.
-
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::self):
- * bindings/js/ScriptCallStack.h:
-
-2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add svg/graphics/skia files.
- https://bugs.webkit.org/show_bug.cgi?id=23147
-
- * svg/graphics/skia/RenderPathSkia.cpp: Added.
- (WebCore::RenderPath::strokeContains):
- * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
- (WebCore::SVGPaintServerPattern::setup):
- * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
- (WebCore::SVGPaintServer::draw):
- (WebCore::SVGPaintServer::teardown):
- (WebCore::SVGPaintServer::renderPath):
- * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
- (WebCore::SVGResourceFilter::createPlatformData):
- (WebCore::SVGResourceFilter::prepareFilter):
- (WebCore::SVGResourceFilter::applyFilter):
- * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
- (WebCore::SVGResourceMasker::applyMask):
-
-2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add SkiaFontWin to platform/graphics/chromium
- https://bugs.webkit.org/show_bug.cgi?id=23215
-
- * platform/graphics/skia/SkiaFontWin.cpp: Added.
- (WebCore::CachedOutlineKey::CachedOutlineKey):
- (WebCore::operator==):
- (WebCore::CachedOutlineKeyHash::hash):
- (WebCore::CachedOutlineKeyHash::equal):
- (WebCore::FIXEDToSkScalar):
- (WebCore::deleteOutline):
- (WebCore::addPolyCurveToPath):
- (WebCore::getPathForGlyph):
- (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
- (WebCore::SkiaWinOutlineCache::removePathsForFont):
- * platform/graphics/skia/SkiaFontWin.h: Added.
-
-2009-01-09 Anders Carlsson <andersca@apple.com>
-
- Fix build.
-
- * WebCore.LP64.exp:
-
-2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
- https://bugs.webkit.org/show_bug.cgi?id=23215
-
- * platform/graphics/skia/PlatformContextSkia.cpp: Added.
+ * platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::State::State):
- (PlatformContextSkia::State::~State):
- (PlatformContextSkia::State::applyAlpha):
- (PlatformContextSkia::PlatformContextSkia):
- (PlatformContextSkia::~PlatformContextSkia):
- (PlatformContextSkia::setCanvas):
- (PlatformContextSkia::save):
- (PlatformContextSkia::restore):
- (PlatformContextSkia::drawRect):
(PlatformContextSkia::setupPaintCommon):
- (PlatformContextSkia::setupPaintForFilling):
- (PlatformContextSkia::setupPaintForStroking):
- (PlatformContextSkia::setDrawLooper):
- (PlatformContextSkia::setMiterLimit):
- (PlatformContextSkia::setAlpha):
- (PlatformContextSkia::setLineCap):
- (PlatformContextSkia::setLineJoin):
- (PlatformContextSkia::setPorterDuffMode):
- (PlatformContextSkia::setFillColor):
- (PlatformContextSkia::getDrawLooper):
- (PlatformContextSkia::getStrokeStyle):
- (PlatformContextSkia::setStrokeStyle):
- (PlatformContextSkia::setStrokeColor):
- (PlatformContextSkia::getStrokeThickness):
- (PlatformContextSkia::setStrokeThickness):
- (PlatformContextSkia::getTextDrawingMode):
- (PlatformContextSkia::setTextDrawingMode):
- (PlatformContextSkia::setUseAntialiasing):
- (PlatformContextSkia::fillColor):
- (PlatformContextSkia::beginPath):
- (PlatformContextSkia::addPath):
- (PlatformContextSkia::setFillRule):
- (PlatformContextSkia::setGradient):
- (PlatformContextSkia::setPattern):
- (PlatformContextSkia::setDashPathEffect):
- (PlatformContextSkia::paintSkPaint):
- (PlatformContextSkia::bitmap):
- (PlatformContextSkia::isPrinting):
- * platform/graphics/skia/PlatformContextSkia.h: Added.
- (PlatformContextSkia::currentPath):
- (PlatformContextSkia::canvas):
- (PlatformContextSkia::gdk_skia):
- * platform/graphics/skia/PlatformGraphics.h: Added.
-
-2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add TransformationMatrixSkia to platform/graphics/skia
- https://bugs.webkit.org/show_bug.cgi?id=23215
-
- * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
- (WebCore::TransformationMatrix::TransformationMatrix):
- (WebCore::TransformationMatrix::setMatrix):
- (WebCore::TransformationMatrix::map):
- (WebCore::TransformationMatrix::mapRect):
- (WebCore::TransformationMatrix::isIdentity):
- (WebCore::TransformationMatrix::reset):
- (WebCore::TransformationMatrix::scale):
- (WebCore::TransformationMatrix::rotate):
- (WebCore::TransformationMatrix::translate):
- (WebCore::TransformationMatrix::shear):
- (WebCore::TransformationMatrix::det):
- (WebCore::TransformationMatrix::inverse):
- (WebCore::TransformationMatrix::operator SkMatrix):
- (WebCore::TransformationMatrix::operator==):
- (WebCore::TransformationMatrix::operator*=):
- (WebCore::TransformationMatrix::operator*):
- (WebCore::TransformationMatrix::a):
- (WebCore::TransformationMatrix::setA):
- (WebCore::TransformationMatrix::b):
- (WebCore::TransformationMatrix::setB):
- (WebCore::TransformationMatrix::c):
- (WebCore::TransformationMatrix::setC):
- (WebCore::TransformationMatrix::d):
- (WebCore::TransformationMatrix::setD):
- (WebCore::TransformationMatrix::e):
- (WebCore::TransformationMatrix::setE):
- (WebCore::TransformationMatrix::f):
- (WebCore::TransformationMatrix::setF):
-
-2009-01-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
-
- Test: http/tests/appcache/reload.html
-
- On Windows, reloading resulted in the following sequence of events:
- 1) A new main resource loader was created and associated with the cache. Its document loader
- was not associated with the cache yet.
- 2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
- teardown started, with newestCache being zeroed out.
- 3) The new document loader was associated with the cache group, and cache update started.
- 4) Since newestCache was null, this caused many problems.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
- no functional changes.
- (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
- if its newest cache pointer is already saved for teardown. Note that the cache pointer
- validity is ensured by MainResourceLoader that holds a reference to it.
-
-2009-01-09 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=23214
- Upstream platform/network/chromium/
-
- * platform/network/chromium/AuthenticationChallenge.h: Added.
- (WebCore::AuthenticationChallenge::AuthenticationChallenge):
- (WebCore::AuthenticationChallenge::sourceHandle):
- * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
- (WebCore::AuthenticationChallenge::platformCompare):
- * platform/network/chromium/CookieJarChromium.cpp: Added.
- (WebCore::setCookies):
- (WebCore::cookies):
- (WebCore::cookiesEnabled):
- * platform/network/chromium/DNSChromium.cpp: Added.
- (WebCore::prefetchDNS):
- * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
- (WebCore::NetworkStateNotifier::updateState):
- (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
- * platform/network/chromium/ResourceError.h: Added.
- (WebCore::ResourceError::ResourceError):
- * platform/network/chromium/ResourceRequest.h: Added.
- (WebCore::ResourceRequest::):
- (WebCore::ResourceRequest::ResourceRequest):
- (WebCore::ResourceRequest::frame):
- (WebCore::ResourceRequest::setFrame):
- (WebCore::ResourceRequest::setTargetType):
- (WebCore::ResourceRequest::targetType):
- (WebCore::ResourceRequest::originPid):
- (WebCore::ResourceRequest::setOriginPid):
- (WebCore::ResourceRequest::securityInfo):
- (WebCore::ResourceRequest::setSecurityInfo):
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- * platform/network/chromium/ResourceResponse.h:
- (WebCore::ResourceResponse::ResourceResponse):
- (WebCore::ResourceResponse::getSecurityInfo):
- (WebCore::ResourceResponse::setSecurityInfo):
- (WebCore::ResourceResponse::isContentFiltered):
- (WebCore::ResourceResponse::setIsContentFiltered):
- (WebCore::ResourceResponse::doUpdateResourceResponse):
-
-2009-01-09 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22995
- Fix flaky image animation by resetting the metadata for a frame when
- we get new data for that frame. This fixes animations that halted
- when the next frame of the animation wasn't complete by the time the
- current frame's duration expired.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::destroyDecodedData):
- (WebCore::BitmapImage::dataChanged):
- * platform/graphics/BitmapImage.h:
- (WebCore::FrameData::~FrameData):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::FrameData::clear):
-
-2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
-
- Rubber-stamped by Tor Arne Vestbø.
-
- Swap the .h and the .cpp output in the Qt build for the
- UserAgentStyleSheetData files, to put the definition in the .cpp file
- and the declaration in the header file.
-
- * WebCore.pro:
-
-2009-01-09 David Levin <levin@chromium.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23175
-
- Added forwarding header.
-
- * ForwardingHeaders/wtf/PtrAndFlags.h: Added.
-
-2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Prevent qmake from generating duplicate rules for embedded stylesheets
-
- The STYLESHEETS_EMBED variable used to contain only one file name, but
- now that it is a list of files we need to change it to be a dependency
- for the stylesheet generator instead of the input.
-
- * WebCore.pro:
-
-2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix qmake warning about missing test function, a contains() call was
- missing.
-
- * WebCore.pro:
-
-2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
-
- Rubber-stamped by Tor Arne Vestbø.
-
- Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
-
- * WebCore.pro:
-
-2009-01-09 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=23199
-
- Fix deref's of string happening on two different threads.
-
- No observable change in behavior, so no test. However, there are asserts
- being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
- will detect this issue while running the normal worker tests.
-
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThreadStartupData::create):
- (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::workerThread):
- * dom/WorkerThread.h:
-
-2009-01-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adam Roben.
-
- - use native glyph support in Core Graphics when available
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
- native glyph support is not available or stroking is required. Changed
- to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
- request the use of native glyphs.
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
- wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
- * platform/graphics/win/FontPlatformDataCGWin.cpp:
- (WebCore::FontPlatformData::platformDataInit): Ditto.
-
-2009-01-08 Peter Kasting <pkasting@google.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22929
- Fix memory regression when decoding large animated GIFs.
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::clear):
-
-2009-01-08 Scott Violet <sky@chromium.org>
-
- Reviewed by Eric Seidel (and Adam Barth).
-
- Fix Images to return their file extension
- http://code.google.com/p/chromium/issues/detail?id=5827
-
- * platform/graphics/skia/ImageSourceSkia.cpp:
- (WebCore::ImageSource::filenameExtension):
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add PathSkia and PatternSkia implementations to WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23200
-
- * platform/graphics/skia/PathSkia.cpp: Added.
- (WebCore::Path::Path):
- (WebCore::Path::~Path):
- (WebCore::Path::operator=):
- (WebCore::Path::isEmpty):
- (WebCore::Path::contains):
- (WebCore::Path::translate):
- (WebCore::Path::boundingRect):
- (WebCore::Path::moveTo):
- (WebCore::Path::addLineTo):
- (WebCore::Path::addQuadCurveTo):
- (WebCore::Path::addBezierCurveTo):
- (WebCore::Path::addArcTo):
- (WebCore::Path::closeSubpath):
- (WebCore::Path::addArc):
- (WebCore::Path::addRect):
- (WebCore::Path::addEllipse):
- (WebCore::Path::clear):
- (WebCore::convertPathPoints):
- (WebCore::Path::apply):
- (WebCore::Path::transform):
- (WebCore::Path::debugString):
- (WebCore::boundingBoxForCurrentStroke):
- (WebCore::Path::strokeBoundingRect):
- * platform/graphics/skia/PatternSkia.cpp: Added.
- (WebCore::shaderRule):
- (WebCore::Pattern::createPlatformPattern):
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add ImageSourceSkia to platform/graphics/skia
- https://bugs.webkit.org/show_bug.cgi?id=23200
-
- ImageSourceSkia is mostly a hack to support our
- ICO decoder model. See ImageSourceSkia.h for more
- explanation. Eventually we'd like to make our ICO
- decoder lazy.
-
- * platform/graphics/ImageSource.h: mark m_decoder as protected
- * platform/graphics/skia/ImageSourceSkia.cpp: Added.
- (WebCore::createDecoder):
- (WebCore::ImageSource::ImageSource):
- (WebCore::ImageSource::~ImageSource):
- (WebCore::ImageSource::clear):
- (WebCore::ImageSource::initialized):
- (WebCore::ImageSource::setData):
- (WebCore::ImageSource::isSizeAvailable):
- (WebCore::ImageSource::size):
- (WebCore::ImageSource::frameSizeAtIndex):
- (WebCore::ImageSource::repetitionCount):
- (WebCore::ImageSource::frameCount):
- (WebCore::ImageSource::createFrameAtIndex):
- (WebCore::ImageSource::frameIsCompleteAtIndex):
- (WebCore::ImageSource::frameDurationAtIndex):
- (WebCore::ImageSource::frameHasAlphaAtIndex):
- (WebCore::ImageSourceSkia::setData):
- (WebCore::ImageSource::filenameExtension):
- * platform/graphics/skia/ImageSourceSkia.h: Added.
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
- https://bugs.webkit.org/show_bug.cgi?id=23200
-
- * platform/graphics/skia/NativeImageSkia.cpp: Added.
- (NativeImageSkia::NativeImageSkia):
- (NativeImageSkia::decodedSize):
- (NativeImageSkia::hasResizedBitmap):
- (NativeImageSkia::resizedBitmap):
- (NativeImageSkia::shouldCacheResampling):
- * platform/graphics/skia/NativeImageSkia.h: Added.
- (NativeImageSkia::setDataComplete):
- (NativeImageSkia::isDataComplete):
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add ImageBufferSkia and ImageSkia files.
- https://bugs.webkit.org/show_bug.cgi?id=23200
- For now we've left BitmapImage and BitmapImageSingleFrameSkia
- implementations in the ImageSkia file (like ImageCG has), but
- we intend to break them out into their own files.
-
- * platform/graphics/skia/ImageBufferSkia.cpp: Added.
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::~ImageBuffer):
- (WebCore::ImageBuffer::context):
- (WebCore::ImageBuffer::image):
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- (WebCore::ImageBuffer::toDataURL):
- * platform/graphics/skia/ImageSkia.cpp: Added.
- (WebCore::):
- (WebCore::FrameData::clear):
- (WebCore::Image::loadPlatformResource):
- (WebCore::Image::drawPattern):
- (WebCore::BitmapImage::initPlatformData):
- (WebCore::BitmapImage::invalidatePlatformData):
- (WebCore::BitmapImage::checkForSolidColor):
- (WebCore::BitmapImage::draw):
- (WebCore::BitmapImageSingleFrameSkia::draw):
- (WebCore::BitmapImageSingleFrameSkia::create):
-
-2009-01-08 James Robinson <jamesr@google.com>
-
- Reviewed by Mark Rowe.
- Landed by Pamela Greene.
-
- WebCore::Event::timeStamp() is a simple accessor and should be const
-
- https://bugs.webkit.org/show_bug.cgi?id=23176
-
- * dom/Event.h:
- (WebCore::Event::timeStamp):
-
-2009-01-08 Antti Koivisto <antti@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix <rdar://problem/6467206>
- Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
-
- Use CachedResourceHandle in document resource map so resources get updated correctly when using
- using cache validation conditionals.
-
- * loader/Cache.cpp:
- (WebCore::Cache::evict):
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::~DocLoader):
- (WebCore::DocLoader::requestResource):
- (WebCore::DocLoader::setAutoLoadImages):
- (WebCore::DocLoader::removeCachedResource):
- * loader/DocLoader.h:
- (WebCore::DocLoader::cachedResource):
- (WebCore::DocLoader::allCachedResources):
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::getSubresources):
- * loader/ImageLoader.cpp:
- (WebCore::ImageLoader::updateFromElement):
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add a cleaned-up GraphicsContextSkia implementation to WebKit.
- https://bugs.webkit.org/show_bug.cgi?id=23191
-
- * platform/graphics/skia/GraphicsContextSkia.cpp: Added.
- (WebCore::):
- (WebCore::GraphicsContext::GraphicsContext):
- (WebCore::GraphicsContext::~GraphicsContext):
- (WebCore::GraphicsContext::platformContext):
- (WebCore::GraphicsContext::savePlatformState):
- (WebCore::GraphicsContext::restorePlatformState):
- (WebCore::GraphicsContext::beginTransparencyLayer):
- (WebCore::GraphicsContext::endTransparencyLayer):
- (WebCore::GraphicsContext::addInnerRoundedRectClip):
- (WebCore::GraphicsContext::addPath):
- (WebCore::GraphicsContext::beginPath):
- (WebCore::GraphicsContext::clearPlatformShadow):
- (WebCore::GraphicsContext::clearRect):
- (WebCore::GraphicsContext::clip):
- (WebCore::GraphicsContext::clipOut):
- (WebCore::GraphicsContext::clipOutEllipseInRect):
- (WebCore::GraphicsContext::clipPath):
- (WebCore::GraphicsContext::clipToImageBuffer):
- (WebCore::GraphicsContext::concatCTM):
- (WebCore::GraphicsContext::drawConvexPolygon):
- (WebCore::GraphicsContext::drawEllipse):
- (WebCore::GraphicsContext::drawFocusRing):
- (WebCore::GraphicsContext::drawLine):
- (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- (WebCore::GraphicsContext::drawLineForText):
- (WebCore::GraphicsContext::drawRect):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::fillRoundedRect):
- (WebCore::GraphicsContext::getCTM):
- (WebCore::GraphicsContext::roundToDevicePixels):
- (WebCore::GraphicsContext::scale):
- (WebCore::GraphicsContext::setAlpha):
- (WebCore::GraphicsContext::setCompositeOperation):
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::setLineCap):
- (WebCore::GraphicsContext::setLineDash):
- (WebCore::GraphicsContext::setLineJoin):
- (WebCore::GraphicsContext::setMiterLimit):
- (WebCore::GraphicsContext::setPlatformFillColor):
- (WebCore::GraphicsContext::setPlatformShadow):
- (WebCore::GraphicsContext::setPlatformStrokeColor):
- (WebCore::GraphicsContext::setPlatformStrokeStyle):
- (WebCore::GraphicsContext::setPlatformStrokeThickness):
- (WebCore::GraphicsContext::setPlatformTextDrawingMode):
- (WebCore::GraphicsContext::setURLForRect):
- (WebCore::GraphicsContext::setUseAntialiasing):
- (WebCore::GraphicsContext::strokeArc):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::strokeRect):
- (WebCore::GraphicsContext::rotate):
- (WebCore::GraphicsContext::translate):
-
-2009-01-08 David Hyatt <hyatt@apple.com>
-
- Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
-
- Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
- any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
- might eventually be of interest to other platforms.
-
- Reviewed by Oliver Hunt
-
- * WebCore.base.exp:
- * page/Chrome.cpp:
- (WebCore::Chrome::scrollRectIntoView):
- * page/Chrome.h:
- * page/ChromeClient.h:
- (WebCore::ChromeClient::scrollRectIntoView):
- * platform/HostWindow.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollRectIntoViewRecursively):
-
-2009-01-08 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by David Hyatt.
-
- No need to make this part of HostWindow and moreover HostWindow should
- not have any reference to non-platform parts of WebCore.
-
- * page/Chrome.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::setContentsSize):
- * platform/HostWindow.h:
-
-2009-01-08 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele Peterson.
-
- Simplify Mac interfaces for drawing media controller elements
-
- <rdar://problem/6293969>
-
- * WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
-
- * platform/mac/WebCoreSystemInterface.h: Ditto
- * platform/mac/WebCoreSystemInterface.mm: Ditto
-
- * rendering/MediaControlElements.h:
- (WebCore::): Add MediaControlElements enum
-
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface
- media controller functions
- (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
- (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
- (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
- (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add two more files for platform/graphics/skia.
- https://bugs.webkit.org/show_bug.cgi?id=23191
-
- * platform/graphics/skia/GradientSkia.cpp: Added.
- (WebCore::Gradient::platformDestroy):
- (WebCore::F2B):
- (WebCore::makeSkColor):
- (WebCore::totalStopsNeeded):
- (WebCore::fillStops):
- (WebCore::compareStops):
- (WebCore::Gradient::platformGradient):
- (WebCore::Gradient::fill):
- * platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h.
- (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- (WebCore::GraphicsContextPlatformPrivate::context):
-
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Commit the right files this time! (Instead of the ugly unfixed ones.)
- https://bugs.webkit.org/show_bug.cgi?id=23191
-
- * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
- * platform/graphics/skia/FloatPointSkia.cpp:
- * platform/graphics/skia/FloatRectSkia.cpp:
- * platform/graphics/skia/IntPointSkia.cpp:
- * platform/graphics/skia/IntRectSkia.cpp:
- (WebCore::IntRect::operator SkRect):
+ (PlatformContextSkia::setXfermodeMode):
+ (PlatformContextSkia::applyClipFromImage):
+ * platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::):
(WebCore::WebCoreCompositeToSkiaComposite):
- (WebCore::SkPMColorToWebCoreColor):
- (WebCore::IntersectRectAndRegion):
- (WebCore::ClipRectToCanvas):
- (WebCore::SkPathContainsPoint):
- (WebCore::scratchContext):
* platform/graphics/skia/SkiaUtils.h:
- (WebCore::WebCoreFloatToSkScalar):
- (WebCore::WebCoreDoubleToSkScalar):
-2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add the first few files from platform/graphics/skia
- https://bugs.webkit.org/show_bug.cgi?id=23191
-
- These are all pretty simple.
- Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
- SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
-
- * platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added.
- (WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
- (WebCore::BitmapImageSingleFrameSkia::size):
- (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
- (WebCore::BitmapImageSingleFrameSkia::decodedSize):
- (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
- (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
- * platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm.
- (WebCore::FloatPoint::FloatPoint):
- (WebCore::FloatPoint::operator SkPoint):
- * platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
- (WebCore::FloatRect::FloatRect):
- (WebCore::FloatRect::operator SkRect):
- * platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp.
- (WebCore::IntPoint::IntPoint):
- (WebCore::IntPoint::operator SkIPoint):
- (WebCore::IntPoint::operator SkPoint):
- * platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
- (WebCore::IntRect::operator SkIRect):
- (WebCore::IntRect::operator SkRect):
- (WebCore::IntRect::IntRect):
- * platform/graphics/skia/SkiaUtils.cpp: Added.
- (WebCore::WebCorePointToSkiaPoint):
- (WebCore::WebCoreRectToSkiaRect):
- (WebCore::):
- (WebCore::WebCoreCompositeToSkiaComposite):
- (WebCore::InvScaleByte):
- (WebCore::SkPMColorToColor):
- (WebCore::SkPMColorToWebCoreColor):
- (WebCore::IntersectRectAndRegion):
- (WebCore::ClipRectToCanvas):
- (WebCore::SkPathContainsPoint):
- (WebCore::scratchContext):
- * platform/graphics/skia/SkiaUtils.h: Added.
- (WebCore::WebCoreFloatToSkScalar):
- (WebCore::WebCoreDoubleToSkScalar):
-
-2009-01-08 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
-
- Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
- instead of simply the "running" ones.
-
- https://bugs.webkit.org/show_bug.cgi?id=23177
-
- Tests: transitions/zero-duration-with-non-zero-delay-end.html
- transitions/zero-duration-with-non-zero-delay-start.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::animationTimerFired):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
-
-2009-01-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
-
- The crash happened whenever a cached resource was downloaded, as opposed to used directly.
-
- No test, as downloading cannot be tested automatically.
-
- * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- Cancel downloads that do not have an associated ResourceHandle, such as downloads from the
- application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
-
-2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix the Qt build on older X11 systems with special X paths.
-
- * WebCore.pro: Use the x11 qmake config to pull in extra paths
- needed for NPAPI.
-
-2009-01-08 Adam Roben <aroben@apple.com>
-
- Windows build fix after r39699
-
- * DerivedSources.cpp: Added JSDOMStringList.cpp.
-
-2009-01-08 Kent Hansen <khansen@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Fix copy & paste of images in the Qt port.
-
- Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
-
- * platform/qt/ClipboardQt.cpp:
- (WebCore::ClipboardQt::declareAndWriteDragImage):
+2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>
-2009-01-08 Hiroyuki Ikezoe <poincare@ikezoe.net>
+ Gtk build fix. Add files that were added in r45093 and r45096
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=23127
-
- Invoke pango_coverage_get with each Unicode character.
-
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::containsCharacters):
-
-2009-01-07 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Part one of
- https://bugs.webkit.org/show_bug.cgi?id=23165
- Add support for application cache dynamic entries
-
- Test: http/tests/appcache/dynamic-entries-no-cache.html
-
- * DerivedSources.make:
* GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Added new files.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem):
- Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom
- to resolve relative URLs correctly.
-
- * bindings/js/JSDOMStringListCustom.cpp: Added.
- * dom/DOMStringList.cpp: Added.
- * dom/DOMStringList.h: Added.
- * dom/DOMStringList.idl: Added.
- Added an implementation of DOM 3 Core DOMStringList interface, which is returned by
- DOMApplicationCache items attribute.
-
- * dom/StaticStringList.cpp: Added.
- * dom/StaticStringList.h: Added.
- An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this
- matches Firefox, as the spec doesn't say whether the returned list should be live or not).
- * loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be
- used in the near future.
+2009-06-24 Brady Eidson <beidson@apple.com>
- * loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length
- attribute and item(), we now have an items attribute that returns a DOMStringList, and a
- hasItem convenience method.
-
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::items):
- (WebCore::DOMApplicationCache::hasItem):
- * loader/appcache/DOMApplicationCache.h:
- Added implementations of items attribute and hasItem() (note that underlying ApplicationCache
- methods are still unimplemented though).
+ Fix 64-bit SnowLeopard build.
- * page/DOMWindow.idl: Expose a DOMStringList global constructor.
+ * html/DataGridColumnList.cpp:
+ (WebCore::DataGridColumnList::remove):
+ (WebCore::DataGridColumnList::move):
-2009-01-07 Chris Marrin <cmarrin@apple.com>
+2009-06-24 Rob Buis <rwlbuis@gmail.com>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=23122
-
- This completes the removal of dependencies on WebKit from the platform code
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::getDelayValue):
- (WebCore::getDurationValue):
- (WebCore::getTimingFunctionValue):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSHelper.h:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapAnimationDelay):
- (WebCore::CSSStyleSelector::mapAnimationDirection):
- (WebCore::CSSStyleSelector::mapAnimationDuration):
- (WebCore::CSSStyleSelector::mapAnimationIterationCount):
- (WebCore::CSSStyleSelector::mapAnimationName):
- (WebCore::CSSStyleSelector::mapAnimationPlayState):
- (WebCore::CSSStyleSelector::mapAnimationProperty):
- (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
- * platform/animation/Animation.cpp:
- (WebCore::Animation::Animation):
- * platform/animation/Animation.h:
- (WebCore::Animation::initialAnimationDelay):
- (WebCore::Animation::initialAnimationDirection):
- (WebCore::Animation::initialAnimationDuration):
- (WebCore::Animation::initialAnimationIterationCount):
- (WebCore::Animation::initialAnimationName):
- (WebCore::Animation::initialAnimationPlayState):
- (WebCore::Animation::initialAnimationProperty):
- (WebCore::Animation::initialAnimationTimingFunction):
- * rendering/style/RenderStyle.h:
-
-2008-01-07 Peter Kasting <pkasting@google.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22929
-
- Fix errors while decoding GIFs by not calling setData() repeatedly
- when it's not necessary. Pushes the responsibility for calling
- setData() after clear() into the ImageSource which presumably knows
- better than BitmapImage what needs to be done.
-
- NOTE: The above bug is mainly about a memory regression, which this
- patch does not fix.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::destroyDecodedData):
- * platform/graphics/ImageSource.h:
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::clear):
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::clear):
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::~ImageSource):
- (WebCore::ImageSource::clear):
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::~ImageSource):
- (WebCore::ImageSource::clear):
-
-2009-01-07 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6355786> Find fails for queries that contain a line break
-
- * editing/TextIterator.cpp:
- (WebCore::findPlainText): Allow find with queries that contain newlines.
-
-2009-01-07 Dean Jackson <dino@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Allow removal of inline shorthand properties for
- animation, transition and transform origin. Also
- add getter for shorthand animation property.
-
- https://bugs.webkit.org/show_bug.cgi?id=22605
-
- Test: fast/css/transform-inline-style-remove.html
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- Getter for animation property shorthand
- (WebCore::initShorthandMap):
- Adds initialisation for transform-origin, animation and transition
-
-2009-01-07 Benjamin Otte <otte@gnome.org>
-
- Reviewed by Holger Freyther.
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- (WebCore::parseDataUrl):
- (WebCore::ResourceHandle::startData): keep track of the idle handler
- we add and remove it in the destructor
-
-2009-01-07 Dean Jackson <dino@apple.com>
-
- Reviewed by Darin Adler.
-
- Finish renaming of AffineTransform to TransformationMatrix, this
- time ensuring that the platform implementations get the correct
- name. Also, clean up some whitespace cruft in old content.
-
- https://bugs.webkit.org/show_bug.cgi?id=23151
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
- * platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
- * platform/graphics/cg/AffineTransformCG.cpp: Removed.
- * platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
- * platform/graphics/qt/AffineTransformQt.cpp: Removed.
- * platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
- * platform/graphics/transforms/TransformationMatrix.cpp:
- * platform/graphics/transforms/TransformationMatrix.h:
- * platform/graphics/wx/AffineTransformWx.cpp: Removed.
- * platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
- * webcore-wx.bkl:
-
-2009-01-07 Anders Carlsson <andersca@apple.com>
-
- Another build fix.
-
- * WebCore.LP64.exp:
-
-2008-12-16 David Hyatt <hyatt@apple.com>
-
- Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
- back to the document-level default.
-
- Reviewed by Darin Adler
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSValueKeywords.in:
-
-2009-01-07 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
- https://bugs.webkit.org/show_bug.cgi?id=23160
-
- * WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource
- so that there's no extra work the caller has to do when the inspector is disabled.
- * inspector/InspectorController.h: Ditto.
-
- * loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification,
- takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when
- there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled
- and if it's false, use recordMemoryCacheLoadForFutureClientNotification.
- (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
- * loader/FrameLoader.h: Ditto.
-
- * page/Page.cpp:
- (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior.
- (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
- * page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled,
- and m_areMemoryCacheClientCallsEnabled.
-
-2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Qt build fix after r39670.
-
- * bridge/qt/qt_class.cpp:
- (JSC::Bindings::QtClass::fallbackObject):
- * bridge/qt/qt_class.h:
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::mark):
- (JSC::Bindings::QtInstance::invokeMethod):
- (JSC::Bindings::QtInstance::defaultValue):
- (JSC::Bindings::QtInstance::stringValue):
- (JSC::Bindings::QtInstance::numberValue):
- (JSC::Bindings::QtInstance::booleanValue):
- (JSC::Bindings::QtInstance::valueOf):
- (JSC::Bindings::QtField::valueFromInstance):
- (JSC::Bindings::QtField::setValueToInstance):
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::valueRealType):
- (JSC::Bindings::convertValueToQVariant):
- (JSC::Bindings::convertQVariantToValue):
- (JSC::Bindings::findMethodIndex):
- (JSC::Bindings::QtRuntimeMetaMethod::call):
- (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
- (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
- (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
- (JSC::Bindings::QtRuntimeConnectionMethod::call):
- (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
- (JSC::Bindings::::setValueAt):
- (JSC::Bindings::::valueAt):
- * bridge/qt/qt_runtime.h:
- (JSC::Bindings::QtRuntimeMethod::createStructure):
-
-2009-01-06 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
-
- Can't create an automated test case for specific contextual menu items yet and
- a normal Copy doesn't cause a crash.
-
- * platform/mac/PasteboardMac.mm:
- (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may,
- for example, have a purgeable or regular buffer.
-
-2009-01-06 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
- Bug 23157: Crashes on Acid 3
-
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle): Null-check the frame.
-
-2009-01-05 Gavin Barraclough <baraclough@apple.com>
-
- Rubber Stamped by Oliver Hunt.
-
- Replace all uses of JSValue* with new wrapper class, JSValuePtr.
- See JavaScriptCore/ChangeLog for more detailed description.
-
- * bindings/js/JSAttrCustom.cpp:
- (WebCore::JSAttr::setValue):
- * bindings/js/JSCSSRuleCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter):
- (WebCore::JSCSSStyleDeclaration::customPut):
- * bindings/js/JSCSSValueCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSCanvasPixelArrayCustom.h:
- (WebCore::JSCanvasPixelArray::getByIndex):
- (WebCore::JSCanvasPixelArray::indexSetter):
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::toJS):
- (WebCore::toHTMLCanvasStyle):
- (WebCore::JSCanvasRenderingContext2D::strokeStyle):
- (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
- (WebCore::JSCanvasRenderingContext2D::fillStyle):
- (WebCore::JSCanvasRenderingContext2D::setFillStyle):
- (WebCore::JSCanvasRenderingContext2D::setFillColor):
- (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
- (WebCore::JSCanvasRenderingContext2D::strokeRect):
- (WebCore::JSCanvasRenderingContext2D::drawImage):
- (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
- (WebCore::JSCanvasRenderingContext2D::setShadow):
- (WebCore::JSCanvasRenderingContext2D::createPattern):
- (WebCore::JSCanvasRenderingContext2D::putImageData):
- (WebCore::JSCanvasRenderingContext2D::fillText):
- (WebCore::JSCanvasRenderingContext2D::strokeText):
- * bindings/js/JSClipboardCustom.cpp:
- (WebCore::JSClipboard::types):
- (WebCore::JSClipboard::clearData):
- (WebCore::JSClipboard::getData):
- (WebCore::JSClipboard::setData):
- (WebCore::JSClipboard::setDragImage):
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::profiles):
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- (WebCore::toVoidCallback):
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::create):
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSCustomXPathNSResolver.h:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::add):
- (WebCore::JSDOMApplicationCache::remove):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::jsStringOrNull):
- (WebCore::jsOwnedStringOrNull):
- (WebCore::jsStringOrUndefined):
- (WebCore::jsStringOrFalse):
- (WebCore::valueToStringWithNullCheck):
- (WebCore::valueToStringWithUndefinedOrNullCheck):
- (WebCore::reportException):
- (WebCore::reportCurrentException):
- (WebCore::setDOMException):
- (WebCore::objectToStringFunctionGetter):
- * bindings/js/JSDOMBinding.h:
- (WebCore::getDOMObjectWrapper):
- (WebCore::getDOMNodeWrapper):
- (WebCore::toJS):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::createWindow):
- (WebCore::showModalDialog):
- (jsDOMWindowBaseCrypto):
- (jsDOMWindowBaseEvent):
- (jsDOMWindowBaseImage):
- (jsDOMWindowBaseMessageChannel):
- (jsDOMWindowBaseOption):
- (jsDOMWindowBaseXMLHttpRequest):
- (jsDOMWindowBaseAudio):
- (jsDOMWindowBaseWorker):
- (jsDOMWindowBaseXSLTProcessor):
- (setJSDOMWindowBaseEvent):
- (setJSDOMWindowBaseAudio):
- (setJSDOMWindowBaseImage):
- (setJSDOMWindowBaseMessageChannel):
- (setJSDOMWindowBaseOption):
- (setJSDOMWindowBaseWorker):
- (setJSDOMWindowBaseXMLHttpRequest):
- (setJSDOMWindowBaseXSLTProcessor):
- (WebCore::JSDOMWindowBase::childFrameGetter):
- (WebCore::JSDOMWindowBase::indexGetter):
- (WebCore::JSDOMWindowBase::namedItemGetter):
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- (WebCore::JSDOMWindowBase::put):
- (WebCore::JSDOMWindowBase::clear):
- (windowProtoFuncOpen):
- (windowProtoFuncShowModalDialog):
- (windowProtoFuncNotImplemented):
- (WebCore::JSDOMWindowBase::setReturnValueSlot):
- (WebCore::JSDOMWindowBase::installTimeout):
- (WebCore::toJS):
- (WebCore::toJSDOMWindow):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::lookupGetter):
- (WebCore::JSDOMWindow::lookupSetter):
- (WebCore::JSDOMWindow::setLocation):
- (WebCore::JSDOMWindow::postMessage):
- (WebCore::setTimeoutOrInterval):
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::clearTimeout):
- (WebCore::JSDOMWindow::setInterval):
- (WebCore::JSDOMWindow::clearInterval):
- (WebCore::JSDOMWindow::atob):
- (WebCore::JSDOMWindow::btoa):
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- (WebCore::toDOMWindow):
- (WebCore::nonCachingStaticCloseFunctionGetter):
- (WebCore::nonCachingStaticBlurFunctionGetter):
- (WebCore::nonCachingStaticFocusFunctionGetter):
- (WebCore::nonCachingStaticPostMessageFunctionGetter):
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customPut):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::put):
- (WebCore::JSDOMWindowShell::putWithAttributes):
- (WebCore::JSDOMWindowShell::lookupGetter):
- (WebCore::JSDOMWindowShell::lookupSetter):
- (WebCore::toJS):
- * bindings/js/JSDOMWindowShell.h:
- (WebCore::JSDOMWindowShell::createStructure):
- * bindings/js/JSDatabaseCustom.cpp:
- (WebCore::JSDatabase::changeVersion):
- (WebCore::JSDatabase::transaction):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::location):
- (WebCore::JSDocument::setLocation):
- (WebCore::toJS):
- * bindings/js/JSElementCustom.cpp:
- (WebCore::JSElement::setAttribute):
- (WebCore::JSElement::setAttributeNode):
- (WebCore::JSElement::setAttributeNS):
- (WebCore::JSElement::setAttributeNodeNS):
- (WebCore::toJSNewlyCreated):
- * bindings/js/JSEventCustom.cpp:
- (WebCore::JSEvent::clipboardData):
- (WebCore::toJS):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::eventParameterName):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventTarget.cpp:
- (WebCore::toJS):
- * bindings/js/JSEventTarget.h:
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetNodeCustom.cpp:
- (WebCore::JSEventTargetNode::addEventListener):
- (WebCore::JSEventTargetNode::removeEventListener):
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::createPositionOptions):
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::createStructure):
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- (WebCore::JSHTMLAppletElement::customPut):
- (WebCore::JSHTMLAppletElement::nameGetter):
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::getNamedItems):
- (WebCore::callHTMLCollection):
- (WebCore::JSHTMLCollection::nameGetter):
- (WebCore::JSHTMLCollection::item):
- (WebCore::JSHTMLCollection::namedItem):
- (WebCore::toJS):
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::JSHTMLDocument::nameGetter):
- (WebCore::JSHTMLDocument::all):
- (WebCore::JSHTMLDocument::setAll):
- (WebCore::JSHTMLDocument::open):
- (WebCore::JSHTMLDocument::write):
- (WebCore::JSHTMLDocument::writeln):
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- (WebCore::JSHTMLEmbedElement::customPut):
- (WebCore::JSHTMLEmbedElement::nameGetter):
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::nameGetter):
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- (WebCore::JSHTMLFrameElement::setSrc):
- (WebCore::JSHTMLFrameElement::setLocation):
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- (WebCore::JSHTMLFrameSetElement::nameGetter):
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- (WebCore::JSHTMLIFrameElement::setSrc):
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::selectionStart):
- (WebCore::JSHTMLInputElement::selectionEnd):
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- (WebCore::JSHTMLObjectElement::customPut):
- (WebCore::JSHTMLObjectElement::nameGetter):
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- (WebCore::JSHTMLOptionsCollection::length):
- (WebCore::JSHTMLOptionsCollection::setLength):
- (WebCore::JSHTMLOptionsCollection::indexSetter):
- (WebCore::JSHTMLOptionsCollection::add):
- (WebCore::JSHTMLOptionsCollection::remove):
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- (WebCore::JSHTMLSelectElement::remove):
- (WebCore::selectIndexSetter):
- (WebCore::JSHTMLSelectElement::indexSetter):
- * bindings/js/JSHTMLSelectElementCustom.h:
- * bindings/js/JSHistoryCustom.cpp:
- (WebCore::nonCachingStaticBackFunctionGetter):
- (WebCore::nonCachingStaticForwardFunctionGetter):
- (WebCore::nonCachingStaticGoFunctionGetter):
- (WebCore::JSHistory::customPut):
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
- (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- * bindings/js/JSInspectedObjectWrapper.h:
- (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap):
- (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
- * bindings/js/JSInspectorCallbackWrapper.h:
- (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate):
- (WebCore::JSJavaScriptCallFrame::thisObject):
- (WebCore::JSJavaScriptCallFrame::type):
- (WebCore::JSJavaScriptCallFrame::scopeChain):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::nonCachingStaticReplaceFunctionGetter):
- (WebCore::nonCachingStaticReloadFunctionGetter):
- (WebCore::nonCachingStaticAssignFunctionGetter):
- (WebCore::JSLocation::customPut):
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::setProtocol):
- (WebCore::JSLocation::setHost):
- (WebCore::JSLocation::setHostname):
- (WebCore::JSLocation::setPort):
- (WebCore::JSLocation::setPathname):
- (WebCore::JSLocation::setSearch):
- (WebCore::JSLocation::setHash):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::reload):
- (WebCore::JSLocation::assign):
- (WebCore::JSLocation::toString):
- * bindings/js/JSMessageChannelConstructor.h:
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- (WebCore::JSMimeTypeArray::nameGetter):
- * bindings/js/JSNamedNodeMapCustom.cpp:
- (WebCore::JSNamedNodeMap::nameGetter):
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::lengthGetter):
- (WebCore::JSNamedNodesCollection::indexGetter):
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createStructure):
- * bindings/js/JSNavigatorCustom.cpp:
- (WebCore::needsYouTubeQuirk):
- (WebCore::JSNavigator::appVersion):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::insertBefore):
- (WebCore::JSNode::replaceChild):
- (WebCore::JSNode::removeChild):
- (WebCore::JSNode::appendChild):
- (WebCore::createWrapper):
- (WebCore::toJSNewlyCreated):
- (WebCore::toJS):
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/JSNodeFilterCondition.h:
- (WebCore::JSNodeFilterCondition::create):
- * bindings/js/JSNodeFilterCustom.cpp:
- (WebCore::JSNodeFilter::acceptNode):
- (WebCore::toNodeFilter):
- * bindings/js/JSNodeIteratorCustom.cpp:
- (WebCore::JSNodeIterator::nextNode):
- (WebCore::JSNodeIterator::previousNode):
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::callNodeList):
- (WebCore::JSNodeList::nameGetter):
- * bindings/js/JSPluginArrayCustom.cpp:
- (WebCore::JSPluginArray::nameGetter):
- * bindings/js/JSPluginCustom.cpp:
- (WebCore::JSPlugin::nameGetter):
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::runtimeObjectGetter):
- (WebCore::runtimeObjectPropertyGetter):
- (WebCore::runtimeObjectCustomPut):
- (WebCore::callPlugin):
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::asWrapper):
- (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
- (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
- (WebCore::JSQuarantinedObjectWrapper::put):
- (WebCore::JSQuarantinedObjectWrapper::construct):
- (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- (WebCore::JSQuarantinedObjectWrapper::call):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::createStructure):
- * bindings/js/JSRGBColor.cpp:
- (WebCore::getJSRGBColor):
- (jsRGBColorRed):
- (jsRGBColorGreen):
- (jsRGBColorBlue):
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::createStructure):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item):
- * bindings/js/JSSQLTransactionCustom.cpp:
- (WebCore::JSSQLTransaction::executeSql):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/js/JSSVGLengthCustom.cpp:
- (WebCore::JSSVGLength::value):
- (WebCore::JSSVGLength::convertToSpecifiedUnits):
- * bindings/js/JSSVGMatrixCustom.cpp:
- (WebCore::JSSVGMatrix::multiply):
- (WebCore::JSSVGMatrix::inverse):
- (WebCore::JSSVGMatrix::translate):
- (WebCore::JSSVGMatrix::scale):
- (WebCore::JSSVGMatrix::scaleNonUniform):
- (WebCore::JSSVGMatrix::rotate):
- (WebCore::JSSVGMatrix::rotateFromVector):
- (WebCore::JSSVGMatrix::flipX):
- (WebCore::JSSVGMatrix::flipY):
- (WebCore::JSSVGMatrix::skewX):
- (WebCore::JSSVGMatrix::skewY):
- * bindings/js/JSSVGPathSegCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSSVGPathSegListCustom.cpp:
- (WebCore::JSSVGPathSegList::clear):
- (WebCore::JSSVGPathSegList::initialize):
- (WebCore::JSSVGPathSegList::getItem):
- (WebCore::JSSVGPathSegList::insertItemBefore):
- (WebCore::JSSVGPathSegList::replaceItem):
- (WebCore::JSSVGPathSegList::removeItem):
- (WebCore::JSSVGPathSegList::appendItem):
- * bindings/js/JSSVGPointListCustom.cpp:
- (WebCore::finishGetter):
- (WebCore::finishSetter):
- (WebCore::finishSetterReadOnlyResult):
- (WebCore::JSSVGPointList::clear):
- (WebCore::JSSVGPointList::initialize):
- (WebCore::JSSVGPointList::getItem):
- (WebCore::JSSVGPointList::insertItemBefore):
- (WebCore::JSSVGPointList::replaceItem):
- (WebCore::JSSVGPointList::removeItem):
- (WebCore::JSSVGPointList::appendItem):
- * bindings/js/JSSVGTransformListCustom.cpp:
- (WebCore::finishGetter):
- (WebCore::finishSetter):
- (WebCore::finishSetterReadOnlyResult):
- (WebCore::JSSVGTransformList::clear):
- (WebCore::JSSVGTransformList::initialize):
- (WebCore::JSSVGTransformList::getItem):
- (WebCore::JSSVGTransformList::insertItemBefore):
- (WebCore::JSSVGTransformList::replaceItem):
- (WebCore::JSSVGTransformList::removeItem):
- (WebCore::JSSVGTransformList::appendItem):
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::nameGetter):
- (WebCore::JSStorage::deleteProperty):
- (WebCore::JSStorage::customPut):
- * bindings/js/JSStyleSheetCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSStyleSheetListCustom.cpp:
- (WebCore::JSStyleSheetList::nameGetter):
- * bindings/js/JSTextCustom.cpp:
- (WebCore::toJSNewlyCreated):
- * bindings/js/JSTreeWalkerCustom.cpp:
- (WebCore::JSTreeWalker::parentNode):
- (WebCore::JSTreeWalker::firstChild):
- (WebCore::JSTreeWalker::lastChild):
- (WebCore::JSTreeWalker::nextSibling):
- (WebCore::JSTreeWalker::previousSibling):
- (WebCore::JSTreeWalker::previousNode):
- (WebCore::JSTreeWalker::nextNode):
- * bindings/js/JSWorkerContextBase.cpp:
- (WebCore::JSWorkerContextBase::put):
- * bindings/js/JSWorkerContextBase.h:
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::self):
- (WebCore::JSWorkerContext::setSelf):
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSWorkerCustom.cpp:
- (WebCore::JSWorker::addEventListener):
- (WebCore::JSWorker::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::open):
- (WebCore::JSXMLHttpRequest::setRequestHeader):
- (WebCore::JSXMLHttpRequest::send):
- (WebCore::JSXMLHttpRequest::getResponseHeader):
- (WebCore::JSXMLHttpRequest::overrideMimeType):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- (WebCore::JSXMLHttpRequest::responseText):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/js/JSXSLTProcessorCustom.cpp:
- (WebCore::JSXSLTProcessor::importStylesheet):
- (WebCore::JSXSLTProcessor::transformToFragment):
- (WebCore::JSXSLTProcessor::transformToDocument):
- (WebCore::JSXSLTProcessor::setParameter):
- (WebCore::JSXSLTProcessor::getParameter):
- (WebCore::JSXSLTProcessor::removeParameter):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::ScheduledAction):
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptCallStack.cpp:
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createScriptObjectForPluginElement):
- * bindings/js/ScriptValue.cpp:
- (WebCore::ScriptValue::getString):
- (WebCore::ScriptValue::isNull):
- (WebCore::ScriptValue::isUndefined):
- * bindings/js/ScriptValue.h:
- (WebCore::ScriptValue::ScriptValue):
- (WebCore::ScriptValue::jsValue):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- (-[WebScriptObject evaluateWebScript:]):
- (-[WebScriptObject valueForKey:]):
- (-[WebScriptObject webScriptValueAtIndex:]):
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- * bindings/objc/WebScriptObjectPrivate.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Evaluate):
- (_NPN_GetProperty):
- (_NPN_HasMethod):
- (_NPN_Construct):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::invokeMethod):
- (JSC::Bindings::CInstance::invokeDefaultMethod):
- (JSC::Bindings::CInstance::invokeConstruct):
- (JSC::Bindings::CInstance::defaultValue):
- (JSC::Bindings::CInstance::stringValue):
- (JSC::Bindings::CInstance::numberValue):
- (JSC::Bindings::CInstance::booleanValue):
- (JSC::Bindings::CInstance::valueOf):
- * bridge/c/c_instance.h:
- * bridge/c/c_runtime.cpp:
- (JSC::Bindings::CField::valueFromInstance):
- (JSC::Bindings::CField::setValueToInstance):
- * bridge/c/c_runtime.h:
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertValueToNPVariant):
- (JSC::Bindings::convertNPVariantToValue):
- * bridge/c/c_utility.h:
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::stringValue):
- (JavaInstance::numberValue):
- (JavaInstance::booleanValue):
- (JavaInstance::invokeMethod):
- (JavaInstance::defaultValue):
- (JavaInstance::valueOf):
- * bridge/jni/jni_instance.h:
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::eval):
- (JavaJSObject::getMember):
- (JavaJSObject::getSlot):
- (JavaJSObject::convertValueToJObject):
- (JavaJSObject::convertJObjectToValue):
- * bridge/jni/jni_objc.mm:
- (JSC::Bindings::dispatchJNICall):
- * bridge/jni/jni_runtime.cpp:
- (JavaArray::convertJObjectToArray):
- (JavaField::dispatchValueFromInstance):
- (JavaField::valueFromInstance):
- (JavaField::dispatchSetValueToInstance):
- (JavaField::setValueToInstance):
- (JavaArray::setValueAt):
- (JavaArray::valueAt):
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- (JSC::Bindings::convertArrayInstanceToJavaArray):
- (JSC::Bindings::convertValueToJValue):
- * bridge/jni/jni_utility.h:
- * bridge/objc/WebScriptObject.h:
- * bridge/objc/objc_class.h:
- * bridge/objc/objc_class.mm:
- (JSC::Bindings::ObjcClass::fallbackObject):
- * bridge/objc/objc_instance.h:
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::invokeMethod):
- (ObjcInstance::invokeDefaultMethod):
- (ObjcInstance::setValueOfUndefinedField):
- (ObjcInstance::getValueOfUndefinedField):
- (ObjcInstance::defaultValue):
- (ObjcInstance::stringValue):
- (ObjcInstance::numberValue):
- (ObjcInstance::booleanValue):
- (ObjcInstance::valueOf):
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::ObjcField::valueFromInstance):
- (JSC::Bindings::convertValueToObjcObject):
- (JSC::Bindings::ObjcField::setValueToInstance):
- (JSC::Bindings::ObjcArray::setValueAt):
- (JSC::Bindings::ObjcArray::valueAt):
- (JSC::Bindings::ObjcFallbackObjectImp::put):
- (JSC::Bindings::callObjCFallbackObject):
- (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertValueToObjcValue):
- (JSC::Bindings::convertNSStringToString):
- (JSC::Bindings::convertObjcValueToValue):
- * bridge/runtime.cpp:
- (JSC::Bindings::Instance::getValueOfField):
- (JSC::Bindings::Instance::setValueOfField):
- * bridge/runtime.h:
- (JSC::Bindings::Class::fallbackObject):
- (JSC::Bindings::Instance::getValueOfUndefinedField):
- (JSC::Bindings::Instance::setValueOfUndefinedField):
- (JSC::Bindings::Instance::invokeDefaultMethod):
- (JSC::Bindings::Instance::invokeConstruct):
- (JSC::Bindings::Instance::valueOf):
- * bridge/runtime_array.cpp:
- (JSC::RuntimeArray::lengthGetter):
- (JSC::RuntimeArray::indexGetter):
- (JSC::RuntimeArray::put):
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::createStructure):
- * bridge/runtime_method.cpp:
- (JSC::RuntimeMethod::lengthGetter):
- (JSC::callRuntimeMethod):
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createStructure):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::fallbackObjectGetter):
- (JSC::RuntimeObjectImp::fieldGetter):
- (JSC::RuntimeObjectImp::methodGetter):
- (JSC::RuntimeObjectImp::put):
- (JSC::RuntimeObjectImp::defaultValue):
- (JSC::callRuntimeObject):
- (JSC::callRuntimeConstructor):
- * bridge/runtime_object.h:
- (JSC::RuntimeObjectImp::createStructure):
- * inspector/InspectorController.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::evaluate):
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptProfile.cpp:
- (WebCore::toJS):
- * inspector/JavaScriptProfile.h:
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::toJS):
- * inspector/JavaScriptProfileNode.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::dropProtection):
-
-2009-01-06 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Darin Adler.
-
- Added new API on AnimationController::numberOfActiveAnimations() to be used by DRT.
-
- https://bugs.webkit.org/show_bug.cgi?id=23126
-
- Test: animations/animation-controller-drt-api.html
-
- * WebCore.base.exp:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
- (WebCore::AnimationController::numberOfActiveAnimations):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
- (WebCore::CompositeAnimation::numberOfActiveAnimations):
- * page/animation/CompositeAnimation.h:
-
-2009-01-06 Eric Seidel <eric@webkit.org>
-
- Reviewed by Gavin Barraclough.
-
- Upstream 3 more files to get the WebCore-Chromium build a bit further.
-
- * WebCore.scons:
- * page/chromium/AccessibilityObjectChromium.cpp: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- * page/chromium/AccessibilityObjectWrapper.h: Added.
- (WebCore::AccessibilityObjectWrapper::~AccessibilityObjectWrapper):
- (WebCore::AccessibilityObjectWrapper::attached):
- (WebCore::AccessibilityObjectWrapper::accessibilityObject):
- (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
- * platform/chromium/PasteboardPrivate.h: Added.
- (WebCore::PasteboardPrivate::):
-
-2009-01-06 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by David Hyatt.
-
- Tests: animations/simultaneous-start-left.html
- animations/simultaneous-start-transform.html
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22870
-
- I added calls beginAnimationUpdate() and endAnimationUpdate() calls
- to AnimationController. These are called by Document at the start
- and end of the recalcStyle cycle. Right now, I'm just using the
- beginAnimationUpdate() method to reset an animation time value.
- The first time the animation time is accessed after this reset I set
- it to the currentTime. So all animations in that cycle get the same
- start time.
-
- The test cases checked in test this, but in the case of the 'left'
- test it actually doesn't make any difference in most cases. This is
- because values are clamped to whole pixels, so the start times would
- have to be pretty far off for the test to fail using the old
- currentTime() model. Still, under really heavy load, it's possible for
- the test to fail without these changes.
-
- The 'transform' test is another story. It animates to the full resolution
- of a floating point number, so the test fails miserably without this
- fix.
-
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- (WebCore::AnimationBase::willNeedService):
- (WebCore::AnimationBase::progress):
- (WebCore::AnimationBase::goIntoEndingOrLoopingState):
- (WebCore::AnimationBase::beginAnimationUpdateTime):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
- (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
- (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
- (WebCore::AnimationController::updateAnimations):
- (WebCore::AnimationController::beginAnimationUpdateTime):
- (WebCore::AnimationController::beginAnimationUpdate):
- (WebCore::AnimationController::endAnimationUpdate):
- * page/animation/AnimationController.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
-
-2009-01-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Bug 22858: Simplify make_names.pl code for avoiding multiple definitions or inclusions
- https://bugs.webkit.org/show_bug.cgi?id=22858
-
- I had introduced an awkward situation using hasCustomJSWrapper and
- sometimes boolean parameter in order to ensure JS wrapper generated once
- or header included once.
-
- Simplified the code by using a %seenTag hash to detect multiple definitions
- or inclusions and skipping it.
-
- Also cleaned up a bit make_names.pl by using more explicit names and moving
- code to where it belongs.
-
- * dom/make_names.pl:
- * html/HTMLTagNames.in: Necessary changes that were not detected by
- the previous syntax but will be required for autogenerating HTMLElementFactory.
-
-2009-01-06 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Add a way for frame loader clients to always create a PluginDocument, regardless of
- the real document MIME type.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::begin):
- (WebCore::FrameLoader::shouldUsePlugin):
- * loader/FrameLoaderClient.h:
- (WebCore::FrameLoaderClient::shouldUsePluginDocument):
-
-2009-01-06 Dean Jackson <dino@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Extend Media Queries to cover transitions,
- animations, transform-2d and transform-3d
- http://webkit.org/specs/MediaQueriesExtensions.html
- Note that the implementation uses -webkit- prefixes
- even though the spec doesn't have them.
- https://bugs.webkit.org/show_bug.cgi?id=22494
-
- Tests: fast/media/mq-animation.html
- fast/media/mq-transform-01.html
- fast/media/mq-transform-02.html
- fast/media/mq-transform-03.html
- fast/media/mq-transform-04.html
- fast/media/mq-transition.html
-
- * css/MediaFeatureNames.h:
- * css/MediaQueryEvaluator.cpp:
- (WebCore::animationMediaFeatureEval):
- (WebCore::transitionMediaFeatureEval):
- (WebCore::transform_2dMediaFeatureEval):
- (WebCore::transform_3dMediaFeatureEval):
-
-2009-01-06 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Bring the Chromium-WebCore build closer to building
- by upstreaming PlatformWidget.h add adding the JSC
- plugin bridge files to the build.
-
- * WebCore.scons:
- * platform/chromium/PlatformWidget.h: Added.
-
-2009-01-06 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- Bring the Chromium-WebCore build back closer to building
- by adding files from recent commits.
-
- * WebCore.scons:
-
-2009-01-06 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6474973> REGRESSION: PLT ~2% slower due to 39465 (consolidate thread data)
-
- I could not reproduce the slowdown on my PowerPC test machine, but the change should bring
- performance back.
-
- * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Don't use AtomicallyInitializedStatic.
- Prior to r39465, it was only used for cached converters, which was necessary because the
- first access to ICU or TEC one could happen on a secondary thread, but now they are all
- initialized from ThreadGlobalData constructor.
-
-2009-01-06 David Smith <catfish.man@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23129
- Devirtualize Node::childNodes().
-
-2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Unreviewed build fix.
-
- Fix the Qt build with Qt 4.4.x, the HTTP-only cookie support was
- added in Qt 4.5.
-
- * platform/qt/CookieJarQt.cpp:
- (WebCore::setCookies):
- (WebCore::cookies):
-
-2009-01-06 Zalan Bujtas <zbujtas@gmail.com>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=23133
- Fix SVG disabled build. Move 'pointer-events' from SVGCSSPropertyNames.in to
- CSSPropertyNames.in and move PointerEvents functions out of #if ENABLE(SVG)
-
- NOTE: Property name fixes landed as part of r39648.
-
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator EPointerEvents):
- * css/CSSPropertyNames.in:
- * css/SVGCSSPropertyNames.in:
-
-2009-01-06 David Kilzer <ddkilzer@apple.com>
-
- BUILD FIX (r39634): Fix build for non-SVG builds (Wx)
-
- * css/CSSPropertyNames.in: Added 'pointer-events'.
- * css/SVGCSSPropertyNames.in: Commented out pointer-events
- since it's now a plain CSS property.
-
-2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
-
- Reviewed by Lars Knoll.
-
- Added support for HTTP-only cookies to the Qt build.
-
- * platform/qt/CookieJarQt.cpp:
- (WebCore::setCookies): Don't set HTTP-only cookies through the DOM.
- (WebCore::cookies): Don't return HTTP-only cookies to the DOM.
-
-2009-01-05 David Smith <catfish.man@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23084
- Avoid redundant AtomicString conversions
-
- * dom/Node.cpp: Create an AtomicString early to avoid converting twice
- (WebCore::Node::getElementsByTagNameNS):
- * dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String
-
-2009-01-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=22985
-
- Add an assertion that clip rects are being used when painting with the same
- rootLayer that they were computed with.
-
- Fix two issues detected by the assertion:
-
- RenderLayer::updateClipRects() should not unconditionally update the clip rects
- on its parent, but stop when reaching rootLayer (just like calculateClipRects()).
-
- We need to pass the temporaryClipRects flag down through reflection painting
- to handle the case of nested reflections.
-
- Also use temporary clip rects in RenderTreeAsText, since that code does not
- reset the painting root for transformed layers, so cached clip rects will not
- match those used for painting.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::updateClipRects):
- (WebCore::RenderLayer::clearClipRects):
- * rendering/RenderLayer.h:
- * rendering/RenderTreeAsText.cpp:
- (WebCore::writeLayers):
-
-2009-01-05 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build
-
- * platform/graphics/qt/AffineTransformQt.cpp:
- (WebCore::TransformationMatrix::TransformationMatrix):
-
-2009-01-05 Mark Rowe <mrowe@apple.com>
-
- Fix the build some more.
-
- * platform/graphics/cairo/AffineTransformCairo.cpp:
- (WebCore::TransformationMatrix::TransformationMatrix):
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix Cairo/Gtk build
-
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::putImageData):
-
-2009-01-05 Dean Jackson <dino@apple.com>
-
- Reviewed by Darin Adler.
-
- Rename AffineTransform to TransformationMatrix in
- preparation for future enhancements (non-affine matrices)
-
- https://bugs.webkit.org/show_bug.cgi?id=22943
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * platform/graphics/transforms/AffineTransform.cpp: Removed.
- * platform/graphics/transforms/AffineTransform.h: Removed.
- * platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
- * platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
- * lots of other files with s/AffineTransform/TransformationMatrix/g
-
-2008-01-05 Dean Jackson <dino@apple.com>
-
- Reviewed by David Hyatt.
-
- Implement 'pointer-events' for HTML content. This involved
- adding a new value 'auto' which behaves as 'visiblePainted'
- in SVG content.
-
- Moved the property out of the SVG CSS code and into
- the general CSS (both parsing and RenderStyle).
-
- Changes to the hit testing functionality of the Render tree,
- specifically the nodeAtPoint methods. Where they used to
- test for visibility, they now use a helper function defined
- on base classes (RenderObject and InlineBox) that checks both
- visibility and pointer-events.
-
- https://bugs.webkit.org/show_bug.cgi?id=11395
-
- Tests: fast/events/pointer-events-2.html
- fast/events/pointer-events.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator EPointerEvents):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * css/SVGCSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- * css/SVGCSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applySVGProperty):
- * manual-tests/pointer-events.html: Added.
- * rendering/EllipsisBox.cpp:
- (WebCore::EllipsisBox::nodeAtPoint):
- * rendering/InlineBox.h:
- (WebCore::InlineBox::visibleToHitTesting):
- * rendering/InlineFlowBox.cpp:
- (WebCore::InlineFlowBox::nodeAtPoint):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::nodeAtPoint):
- * rendering/PointerEventsHitRules.cpp:
- (WebCore::PointerEventsHitRules::PointerEventsHitRules):
- * rendering/PointerEventsHitRules.h:
- (WebCore::PointerEventsHitRules::):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::nodeAtPoint):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::nodeAtPoint):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::visibleToHitTesting):
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::nodeAtPoint):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::nodeAtPoint):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::nodeAtPoint):
- * rendering/RootInlineBox.cpp:
- (WebCore::RootInlineBox::nodeAtPoint):
- * rendering/TextControlInnerElements.cpp:
- (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- * rendering/style/RenderStyle.h:
- (WebCore::):
- (WebCore::InheritedFlags::setBitDefaults):
- (WebCore::InheritedFlags::pointerEvents):
- (WebCore::InheritedFlags::setPointerEvents):
- (WebCore::InheritedFlags::initialPointerEvents):
- * rendering/style/RenderStyleConstants.h:
- (WebCore::):
- * rendering/style/SVGRenderStyle.h:
- (WebCore::SVGRenderStyle::InheritedFlags::operator==):
- (WebCore::SVGRenderStyle::setBitDefaults):
- * rendering/style/SVGRenderStyleDefs.h:
- * css/CSSValueKeywords.in:
- * css/SVGCSSValueKeywords.in:
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Fix Cairo/Gtk build
-
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::getImageData):
-
-2009-01-05 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Gavin Barraclough.
-
- CanvasPixelArray performance is too slow
- <https://bugs.webkit.org/show_bug.cgi?id=23123>
-
- Remove the WebCore CanvasPixelArray implementation and replace
- CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
- wrapper with an explicitly instantiated JSByteArray put on the
- JSImageData object as an ordinary ReadOnly, DontDelete property.
-
- * DerivedSources.make:
- * ForwardingHeaders/runtime/ByteArray.h: Added.
- * ForwardingHeaders/runtime/JSByteArray.h: Added.
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSCanvasPixelArrayCustom.h: Removed.
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * html/CanvasPixelArray.cpp: Removed.
- * html/CanvasPixelArray.h: Removed.
- * html/CanvasPixelArray.idl: Removed.
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::createEmptyImageData):
- * html/ImageData.cpp:
- (WebCore::ImageData::ImageData):
- * html/ImageData.h:
- (WebCore::ImageData::data):
- * html/ImageData.idl:
- * platform/graphics/cg/ImageBufferCG.cpp:
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
-
-2009-01-05 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Add notification for contentsSizeChanged which the Qt API will
- introduce.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::contentsSizeChanged):
- * page/Chrome.cpp:
- (WebCore::Chrome::contentsSizeChanged):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::setContentsSize):
- * page/FrameView.h:
- * platform/HostWindow.h:
- * platform/ScrollView.h:
-
-2009-01-05 Anders Carlsson <andersca@apple.com>
-
- Build fix.
-
- * plugins/PluginView.h:
- (WebCore::PluginManualLoader::~PluginManualLoader):
-
-2009-01-05 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
-
- Add an abstract PluginManualLoader class and make PluginView inherit from it.
-
- Add some error checking that currently exists in WebKit (but not for long!)
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::didReceiveResponse):
- (WebCore::PluginView::didReceiveData):
- (WebCore::PluginView::didFinishLoading):
- (WebCore::PluginView::didFail):
- * plugins/PluginView.h:
-
-2009-01-05 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes FrameView to respect the state of scrollbarmode when it is explicitly
- set programatically via a webkit API.
-
- * loader/FrameLoaderClient.cpp:
- (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
- * loader/FrameLoaderClient.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::initScrollbars):
- (WebCore::FrameView::updateDefaultScrollbarState):
- * page/FrameView.h:
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
- https://bugs.webkit.org/show_bug.cgi?id=23109
-
- Test: fast/text/find-backwards.html
-
- * editing/TextIterator.cpp:
- (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy.
- (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but
- we're at a break; must not try to search because ICU will give us an error.
- Fix incorrect size passed to memcpy and memmove.
- (WebCore::findPlainText): Fix case where we found a match and need to search
- again because we want to find the last match. We need to try again without
- adding any more text or handling the break before moving on.
-
-2009-01-05 Adam Treat <adam.treat@torchmobile.com>
-
- Fix the Qt build
-
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::put):
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Fix platforms that don't have Workers enabled.
-
- * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in
- two stages, so that EventNames constructor can access the just-created atomic string table.
- This matches what happens in ThreadSpecific case.
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Suggested by Dave Levin.
-
- Mac release build fix.
-
- * WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- * dom/Document.cpp: Fix build. Oops again.
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Fix hang whenever following an anchor.
-
- * dom/Document.cpp:
- (WebCore::Document::findAnchor): Oops!
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23073
- <rdar://problem/6471129> Workers crash on Windows Release builds
-
- * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
- * platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames):
- Now that ThreadSpecific sets up the pointer before invoking data constructor, we can
- initialize EventNames right away.
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument
- https://bugs.webkit.org/show_bug.cgi?id=23106
-
- This led me to a bunch of dead code. It turns out that HTML collections
- were carrying the case-insensitive code just so they could be used to
- find anchors, something we can do more simply and efficiently without
- creating a DOM HTMLCollection object.
-
- No behavior change. Just adding a new function findAnchor function and
- removing some dead code.
-
- * dom/Document.cpp:
- (WebCore::Document::findAnchor): Added.
- * dom/Document.h: Ditto.
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString
- references for better efficiency.
- (WebCore::HTMLAnchorElement::setAccessKey): Ditto.
- (WebCore::HTMLAnchorElement::charset): Ditto.
- (WebCore::HTMLAnchorElement::setCharset): Ditto.
- (WebCore::HTMLAnchorElement::coords): Ditto.
- (WebCore::HTMLAnchorElement::setCoords): Ditto.
- (WebCore::HTMLAnchorElement::setHref): Ditto.
- (WebCore::HTMLAnchorElement::hreflang): Ditto.
- (WebCore::HTMLAnchorElement::setHreflang): Ditto.
- (WebCore::HTMLAnchorElement::name): Ditto.
- (WebCore::HTMLAnchorElement::setName): Ditto.
- (WebCore::HTMLAnchorElement::rel): Ditto.
- (WebCore::HTMLAnchorElement::setRel): Ditto.
- (WebCore::HTMLAnchorElement::rev): Ditto.
- (WebCore::HTMLAnchorElement::setRev): Ditto.
- (WebCore::HTMLAnchorElement::shape): Ditto.
- (WebCore::HTMLAnchorElement::setShape): Ditto.
- (WebCore::HTMLAnchorElement::setTarget): Ditto.
- (WebCore::HTMLAnchorElement::type): Ditto.
- (WebCore::HTMLAnchorElement::setType): Ditto.
- * html/HTMLAnchorElement.h: Ditto.
-
- * html/HTMLCollection.cpp:
- (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an
- AtomicString and removed the caseSensitive boolean, since we're now always
- case sensitive.
- (WebCore::HTMLCollection::namedItem): Ditto.
- (WebCore::HTMLCollection::nextNamedItem): Ditto.
- * html/HTMLCollection.h: Ditto.
- * html/HTMLFormCollection.cpp:
- (WebCore::HTMLFormCollection::getNamedItem): Ditto.
- (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
- (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto.
- (WebCore::HTMLFormCollection::namedItem): Ditto.
- (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
- * html/HTMLFormCollection.h: Ditto.
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::namedItem): Ditto.
- * html/HTMLSelectElement.h: Ditto.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Bug 23104: minor mistakes in init functions for animation and transition events
- https://bugs.webkit.org/show_bug.cgi?id=23104
-
- Test: fast/events/init-events.html
-
- Also fixed two StorageEvent problems the test case uncovered:
-
- Made document.createEvent("StorageEvent") work.
- Allow null values for StorageEvent.oldValue and StorageEvent.newValue.
-
- * dom/Document.cpp:
- (WebCore::Document::createEvent): Sorted alphabetically by the name of the event
- class. Added StorageEvent.
-
- * dom/UIEvent.idl: Fixed typo in a comment.
-
- * dom/WebKitAnimationEvent.cpp:
- (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
- * dom/WebKitTransitionEvent.cpp:
- (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
-
- * storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the
- arguments to initStorageEvent so it can create events with null values for the
- oldValue and newValue, just like the real storage events. Note that the properties
- already had ConvertNullStringTo=Null, so this is just the other half of that.
-
-2009-01-05 Darin Adler <darin@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 23102: turn on unused parameter warnings in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=23102
-
- First step: Fix the simple cases where we can just remove an argument name.
- Also made a few more things protected and private.
-
- * many files
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23115
- Create a version of ASSERT for use with otherwise unused variables
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Non-Mac build fix.
-
- * loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.
-
-2009-01-05 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Remove unnecessary methods from EmptyFrameLoaderClient
-
- * loader/EmptyClients.h:
-
-2009-01-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23077
- Make application cache use SQLite built-in user_version
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with
- PRAGMA user_version.
-
- * loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
- Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic
- cache entries.
-
-2009-01-04 David Smith <catfish.man@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=23084
- Avoid redundant AtomicString conversions
-
- * dom/Node.cpp:
- (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*"
- (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI
- (WebCore::Node::isDefaultNamespace): Ditto
- (WebCore::Node::lookupPrefix): Ditto
- (WebCore::Node::lookupNamespacePrefix): Ditto
- * dom/Node.h: Ditto
-
-2009-01-04 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
+ https://bugs.webkit.org/show_bug.cgi?id=26392
+ Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
+ https://bugs.webkit.org/show_bug.cgi?id=26328
+ Bug 26328: changing href attribute of svg images does not work when changing display attribute as well
- Bug 23105: canvas setFillColor function ignores alpha argument
- https://bugs.webkit.org/show_bug.cgi?id=23105
+ React to href updates even when there is no renderer, i.e. display=none.
- Test: fast/canvas/set-colors.html
+ Tests: svg/custom/js-update-image-and-display.svg
+ svg/custom/js-update-image-and-display2.svg
+ svg/custom/js-update-image-and-display3.svg
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead
- of ignoring it and always passing 1.
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments.
- (WebCore::CanvasStyle::applyFillColor): Ditto.
-
-2009-01-04 Darin Adler <darin@apple.com>
-
- Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
- https://bugs.webkit.org/show_bug.cgi?id=23086
-
- * editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile
- in the new search path if it's 0.
-
-2009-01-04 David Kilzer <ddkilzer@apple.com>
-
- Don't install *.idl and *.in files as resources
-
- Reviewed by Oliver Hunt.
-
- Don't install these files as resources in the WebCore framework:
- - WMLAttributeNames.in
- - WMLTagNames.in
- - WorkerContext.idl
- - WorkerLocation.idl
- - WorkerNavigator.idl
-
- * WebCore.xcodeproj/project.pbxproj: Removed resources.
-
-2009-01-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=23090
-
- If an object gets a Layout hint, and the style change will result in
- the creation of a RenderLayer, then we need to repaint the old position
- of the object. This was done for transform, but we have to test opacity too.
-
- Test: fast/repaint/create-layer-repaint.html
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
-
-2009-01-04 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23103: Safari's auto-fill no longer works for <select> elements
- https://bugs.webkit.org/show_bug.cgi?id=23103
- rdar://problem/6472061
-
- * bindings/objc/DOMHTML.mm:
- (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
-
-2009-01-04 Adam Treat <adam.treat@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Add fixedLayoutSize feature to ScrollView to allow for controlling the
- layout beyond the constraint of the current viewports dynamic size
-
- * css/MediaQueryEvaluator.cpp:
- (WebCore::heightMediaFeatureEval):
- (WebCore::widthMediaFeatureEval):
- * dom/Element.cpp:
- (WebCore::Element::clientWidth):
- (WebCore::Element::clientHeight):
- * loader/FrameLoaderClient.cpp:
- (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
- * loader/FrameLoaderClient.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::layout):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::layoutWidth):
- (WebCore::ScrollView::layoutHeight):
- (WebCore::ScrollView::fixedLayoutSize):
- (WebCore::ScrollView::setFixedLayoutSize):
- (WebCore::ScrollView::useFixedLayout):
- (WebCore::ScrollView::setUseFixedLayout):
- * platform/ScrollView.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::viewHeight):
- (WebCore::RenderView::viewWidth):
- * rendering/RenderView.h:
-
-2009-01-03 Rob Buis <rwlbuis@gmail.com>
-
- Reviewed by Darin.
-
- https://bugs.webkit.org/show_bug.cgi?id=22660
- SVG elements that are moved are nor fully invalidated/earsed
-
- Mark the SVG root as needing a layout when its position changes.
-
- Tests: svg/custom/circle-move-invalidation.svg
-
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::position):
- * rendering/RenderSVGRoot.h:
-
-2009-01-03 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * loader/FrameLoader.h:
-
-2009-01-02 Cary Clark <caryclark@google.com>
-
- Reviewed and landed by Darin Adler.
-
- Bug 22963: write icons before reading them
- https://bugs.webkit.org/show_bug.cgi?id=22963
-
- Reverse the order in the icon database main thread loop to
- write the pending icons to the database before trying
- to read any requested icons. This ensures that a requested icon
- has the correct data when read.
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::syncThreadMainLoop):
-
-2009-01-02 Darin Adler <darin@apple.com>
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in.
- This cuts down on the number of hash table operations during loading.
-
-2009-01-02 Dmitry Titov <dimich@chromium.org>
-
- Reviewed and landed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23025
- DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
- Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
- Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
- unnecessary HashMap remove in case the Document is being destroyed.
-
- * bindings/js/DOMTimer.cpp:
- (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap.
- (WebCore::DOMTimer::install):
- (WebCore::DOMTimer::removeById): simply uses 'delete this'.
- (WebCore::DOMTimer::fired): same.
- (WebCore::DOMTimer::contextDestroyed): same.
- * dom/Document.cpp:
- (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::svgAttributeChanged):
-2009-01-02 Darin Adler <darin@apple.com>
+2009-06-24 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
- Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
- inside its web view when resizing its window
- https://bugs.webkit.org/show_bug.cgi?id=23072
- rdar://problem/6368028
-
- The first attempt at fixing this did not work.
- This time I was able to reproduce the bug and test the fix.
-
- Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh
- https://bugs.webkit.org/show_bug.cgi?id=11212
- rdar://problem/4959702
-
- I had to fix this second bug because otherwise the WebKit code to trigger the first
- fix didn't run.
-
- Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
- a particular frame. Bad idea! It's bad enough that we do it for each document, but
- the old version kept the set around forever as you moved from one document to the next.
-
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow
- turning off scrolling when the quirk is enabled. We just don't allow turning it on.
- This fixes one of the two problems with the initial patch; the other fix is in WebKit.
-
- * loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad
- here from FrameLoader. The old way meant that a given frame would forever remember
- the URL of any resources loaded in that frame and never send any "loaded from cache"
- client calls about those URLs.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad.
- This is now handled by dispatchWillSendRequest, which is safer since that's the actual
- function that tells the client about the load.
- (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to
- haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader.
- Also removed the call in the case where we don't load from the cache, since
- dispatchWillSendRequest now takes care of it.
- (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad
- here. Call it both on the URL we pass in and the URL the client returns; we won't
- tell the client about either if it's loaded from the memory cache.
-
- * loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and
- m_urlsClientKnowsAbout.
-
- * loader/SubresourceLoader.cpp: Removed unneeded load function that called
- didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.
-
- * loader/SubresourceLoader.h: Removed load function. Also made all members private
- except for create and clearClient.
-
-2009-01-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=23082
-
- Fix GIF animation by ensuring that the signature of
- startAnimation() in the base class matches the method in BitmapImage.
-
- Test: fast/backgrounds/animated-gif-as-background.html
-
- * platform/graphics/Image.h:
- (WebCore::Image::startAnimation):
-
-2009-01-02 David Smith <catfish.man@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22699
- Enable NodeList caching for getElementsByTagName
-
- test: fast/dom/getelementsbytagnamens-mixed-namespaces.html
-
- * dom/Document.cpp:
- (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
- * dom/Node.cpp:
- (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache
- (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others
- (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
- * dom/NodeRareData.h: Add m_tagNodeListCaches
- * dom/QualifiedName.cpp:
- * dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
- * dom/StyledElement.cpp:
- (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
- * dom/TagNodeList.cpp:
- (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
- * dom/TagNodeList.h:
- (WebCore::TagNodeList::create): Add a NodeList cache argument
- * platform/text/StringHash.h:
- (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
- * platform/text/TextEncodingRegistry.cpp:
- (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue
-
-2009-01-02 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Darin Adler
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
- Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
-
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom()
- (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- BUILD FIX (r39552): Add mediaControls.css to other build files
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Try to fix Wx build after r39427
-
- * platform/graphics/wx/PathWx.cpp:
- (WebCore::Path::strokeBoundingRect): Added stub.
-
-2009-01-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6471356> Failed assertion on quit
-
- * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData):
- Only assert that empty string are all removed on secondary threads.
-
-2009-01-02 David Kilzer <ddkilzer@apple.com>
-
- Bug 23081: These files are no longer part of the KDE libraries
-
- <https://bugs.webkit.org/show_bug.cgi?id=23081>
-
- Reviewed by Darin Adler.
-
- Removed "This file is part of the KDE libraries" comment from
- source files. Added or updated Apple copyrights as well.
-
- No tests since there are only changes to comments.
-
- * bridge/testbindings.cpp:
- * html/HTMLEntityNames.gperf:
- * loader/Cache.h:
- * loader/CachedCSSStyleSheet.h:
- * loader/CachedResourceClient.h:
- * loader/CachedResourceClientWalker.cpp:
- * loader/CachedResourceClientWalker.h:
- * loader/CachedScript.cpp:
- * loader/CachedScript.h:
- * loader/CachedXBLDocument.cpp:
- * loader/CachedXBLDocument.h:
- * loader/CachedXSLStyleSheet.cpp:
- * loader/CachedXSLStyleSheet.h:
- * rendering/GapRects.h:
- * xml/XMLSerializer.cpp:
-
-2009-01-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- Use an OwnPtr for m_chromeClient.
-
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::~SVGImage):
- (WebCore::SVGImage::dataChanged):
- * svg/graphics/SVGImage.h:
-
-2009-01-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=22981
-
- Repaints inside of an SVGImage were thrown on the floor,
- which broke incremental painting due to loading, or SVG animation.
- Fix this by assigning the SVGImage a ChromeClient subclass that passes
- along repaints via a new method on ImageObserver, which also takes
- a rect parameter for the changed rect, allowing incremental repaints.
- Fix RenderImage::imageChanged to take advantage of this changedRect to
- only repaint the changed parts of the image.
-
- This also enables incremental painting for canvas-as-image, so
- add tests for that too.
-
- Tests: fast/backgrounds/animated-svg-as-background.html
- fast/backgrounds/animated-svg-as-mask.html
- fast/canvas/canvas-as-image-incremental-repaint.html
- fast/canvas/canvas-as-image.html
- fast/images/animated-svg-as-image.html
+ https://bugs.webkit.org/show_bug.cgi?id=26687
- * css/CSSCanvasValue.cpp:
- (WebCore::CSSCanvasValue::canvasChanged):
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::notifyObservers):
- (WebCore::CachedImage::data):
- (WebCore::CachedImage::changedInRect):
- * loader/CachedImage.h:
- * loader/CachedResourceClient.h:
- (WebCore::CachedResourceClient::imageChanged):
- * platform/graphics/ImageObserver.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::imageChanged):
- * rendering/RenderBox.h:
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::imageChanged):
- * rendering/RenderImage.h:
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::imageChanged):
- * rendering/RenderListMarker.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::imageChanged):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::imageChanged):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::imageChanged):
- * rendering/RenderSVGImage.h:
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::imageChanged):
- * rendering/RenderScrollbarPart.h:
- * rendering/RenderTableCol.cpp:
- (WebCore::RenderTableCol::imageChanged):
- * rendering/RenderTableCol.h:
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::imageChanged):
- * rendering/RenderTableRow.h:
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::imageChanged):
- * rendering/RenderTableSection.h:
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImageChromeClient::SVGImageChromeClient):
- (WebCore::SVGImageChromeClient::image):
- (WebCore::SVGImageChromeClient::chromeDestroyed):
- (WebCore::SVGImageChromeClient::repaint):
- (WebCore::SVGImage::SVGImage):
- (WebCore::SVGImage::~SVGImage):
- (WebCore::SVGImage::dataChanged):
- * svg/graphics/SVGImage.h:
-
-2009-01-02 Eric Carlson <eric.carlson@apple.com>
+ Add basic back-end column support to datagrid.
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=23043
-
- Pull media controls css out of html4.css into separate file. Don't generate
- wml, svg, or media css globals unless the feature is enabled.
+ Added fast/dom/HTMLDataGridElement/ column tests.
+ * DerivedSources.cpp:
* DerivedSources.make:
- Don't include css for unused features.
-
- * WebCore.xcodeproj/project.pbxproj:
- include mediaControls.css
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::styleForElement):
- don't parse or add media css unless VIDEO feature is enabled and the target
- element is video or audio
-
- * css/html4.css:
- moved media controls css to mediaControls.css
-
- * css/mediaControls.css: Added.
-
-2009-01-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23022
- Fix multiple issues with appcache online whitelist handling
-
- Test: http/tests/appcache/online-whitelist.html
-
- * loader/appcache/ApplicationCache.cpp:
- (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes,
- making it possible to use them for CGI invocation (as required by HTML5).
-
- * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- Re-ordered checks, so that resources that are cached, but are also listed in online whitelist
- are loaded from the cache. This is required by HTML5, although Firefox doesn't match.
-
- * loader/appcache/ManifestParser.cpp:
- (WebCore::parseManifest):
- * loader/appcache/ManifestParser.h:
- * loader/appcache/ApplicationCache.h:
- (WebCore::ApplicationCache::onlineWhitelist):
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::store):
- (WebCore::ApplicationCacheStorage::loadCache):
- Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.
-
-2009-01-02 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
- https://bugs.webkit.org/show_bug.cgi?id=23072
- rdar://problem/6368028
-
- * WebCore.base.exp: Updated.
- * WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.
-
- * dom/Document.cpp:
- (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
- * dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling,
- and m_frameElementsShouldIgnoreScrolling.
-
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute
- to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only
- triggered on Mac OS X when running the Dictionary application.
-
-2009-01-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23036
- <rdar://problem/6451666> Implement AppCache fallback entries (23036)
-
- Test: http/tests/appcache/fallback.html
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback
- entries if normal loading fails.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal
- loading for resources that match fallback namespaces - they are only loaded from the cache
- if that fails.
- (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for
- resource from associated appcache, or from passed in one, if any.
- (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback
- entry for resourse exists, add it to pending substitute loads.
-
- * loader/DocumentLoader.h: Added new functions for loading fallback data for resources.
-
- * loader/ResourceLoader.h:
- * loader/ResourceLoader.cpp:
- (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function
- is called when normal loading fails (which includes network failures, 4xx and 5xx responses,
- and cross-origin redirects) to load appcache fallback data instead. It can use either the
- cache that is associated with the browsing context, or a custom one if association is yet
- to take place.
- (WebCore::ResourceLoader::willSendRequest): Try using fallback data.
- (WebCore::ResourceLoader::didReceiveResponse): Ditto.
- (WebCore::ResourceLoader::didFail): Ditto.
-
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load
- fallback data from it if loading fails. The browsing context may still be associated with
- its previous document here, so the cache to load from must be passed explicitly.
- (WebCore::MainResourceLoader::didFail): Ditto.
- (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.
-
- * loader/appcache/ApplicationCache.cpp:
- (WebCore::ApplicationCache::setFallbackURLs):
- (WebCore::ApplicationCache::urlMatchesFallbackNamespace):
- * loader/appcache/ApplicationCache.h:
- (WebCore::ApplicationCache::fallbackURLs):
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::cacheGroupForURL):
- (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
- (WebCore::ApplicationCacheStorage::store):
- (WebCore::ApplicationCacheStorage::loadCache):
- (WebCore::ApplicationCacheStorage::storeCopyOfCache):
- * loader/appcache/ApplicationCacheStorage.h:
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
- (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- * loader/appcache/ApplicationCacheGroup.h:
- Implement fallback map saving and loading, pass it to the cache.
-
- * loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys
- are matched by prefix, so HAshMap cannot be used.
-
- * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section
- parsing.
-
-2009-01-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6450530> WebCore::FontPlatformData should not leak
-
- Whoops, previous patch should also have fixed the font referencing in
- the constructor.
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/mac/FontPlatformDataMac.mm:
- (WebCore::FontPlatformData::FontPlatformData):
-
-2009-01-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Dan Bernstein.
-
- <rdar://problem/6450530> WebCore::FontPlatformData should not leak
-
- Make sure we only adopt the new font, rather than re-referencing (and so leaking).
-
- * platform/graphics/mac/FontPlatformDataMac.mm:
- (WebCore::FontPlatformData::setFont):
-
-2009-01-01 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23071: REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)
- https://bugs.webkit.org/show_bug.cgi?id=23071
-
- Also fix some things that Dan suggested during review of the ICU search patch that I forgot
- the first time around.
-
- * editing/TextIterator.cpp: Use ICU search on all platforms that use ICU, now that
- we've double checked it works everywhere, removing HAVE_ICU_SEARCH entirely.
- Removed unused m_atBreak data member from the non-ICU code path.
- (WebCore::TextIterator::TextIterator): Move null check up.
- (WebCore::TextIterator::handleTextBox): Fix mistake that made the iterator include
- collapsed whitespace. This was left over from an earlier version of the patch.
- (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
- Move null check up.
-
-2009-01-01 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler, Oliver Hunt
-
- https://bugs.webkit.org/show_bug.cgi?id=23065
-
- Enable incremental painting of canvas. This turns incremental painting
- back on, and fixes issues with stroke width and miters, calling willDraw()
- for strokeText and fillText, and taking shadows into account.
-
- Test: fast/canvas/canvas-incremental-repaint.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasStrokeStyleApplier::CanvasStrokeStyleApplier):
- (WebCore::CanvasStrokeStyleApplier::strokeStyle):
- (WebCore::CanvasRenderingContext2D::stroke):
- (WebCore::CanvasRenderingContext2D::willDraw):
- (WebCore::CanvasRenderingContext2D::putImageData):
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
- * html/CanvasRenderingContext2D.h:
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::willDraw):
- * platform/graphics/FloatRect.h:
- (WebCore::mapRect): new method to map a rect contained
- in one rect to an equivalent rect inside another rect.
-
-2008-12-29 Konstantin Käfer <kkaefer@gmail.com>
-
- Reviewed by Tim Hatcher.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=17229
- <rdar://problem/5732829> Inspector should show properties of all JS objects in Console
-
- Prints objects not as plain text but makes them expandable so that
- they can be inspected.
-
- * inspector/front-end/Console.js:
- (): added a parameter "inline" to the WebInspector.Console._format function which indicates
- whether the object is printed in the context of another string (with console.log()) or
- as sole element.
- (.): objects and DOM nodes are now printed in an expandable form when they are printed alone
- (i.e. not in the context of a console.log() string) so that they can be inspected.
- * inspector/front-end/PropertiesSection.js:
- (WebInspector.PropertiesSection.prototype.set title): Allow DOM Nodes as title instead of strings
- in that case, the Node is inserted into the title instead of the string value of the passed
- object. This is used for displaying linkified titles, for example when inspecting DOM nodes,
- the syntax highlighted HTML representation is shown instead of the plain source code.
- * inspector/front-end/inspector.css: correct the offsetParent for the expandable object inspector.
-
-2009-01-01 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences
- https://bugs.webkit.org/show_bug.cgi?id=23051
- rdar://problem/3574497
-
- Test: editing/execCommand/findString-diacriticals.html
-
- * editing/TextIterator.cpp: Changed the CircularSearchBuffer class to have a new
- name, since it doesn't always use a circular buffer any more. Changed the interface
- so it can work well in the new chunky comparison mode for ICU search, and also
- added private data members for both the ICU-search and non-ICU-search code paths.
- (WebCore::TextIterator::TextIterator): Use the versions of the Range functions
- that don't take an exception code.
- (WebCore::TextIterator::handleTextBox): Added a special case to handle the position
- of a collapsed-away space better. This is not needed for search mechanism, but was
- helpful in an earlier version of this patch, and is still an improvement.
- (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Use the
- versions of the Range functions that don't take an exception code.
- (WebCore::CharacterIterator::range): Ditto.
- (WebCore::characterSubrange): Added. Helper function used in both places below where
- we want to convert a range and character offsets into a subrange.
- (WebCore::WordAwareIterator::advance): Use the versions of the Range functions that
- don't take an exception code.
- (WebCore::createSearcher): Added.
- (WebCore::searcher): Added.
- (WebCore::lockSearcher): Added.
- (WebCore::unlockSearcher): Added.
- (WebCore::SearchBuffer::SearchBuffer): Added.
- (WebCore::SearchBuffer::~SearchBuffer): Added.
- (WebCore::SearchBuffer::append): Added.
- (WebCore::SearchBuffer::atBreak): Added.
- (WebCore::SearchBuffer::reachedBreak): Added.
- (WebCore::SearchBuffer::search): Added.
- (WebCore::SearchBuffer::length): Added.
- (WebCore::TextIterator::subrange): Changed to call the characterSubrange
- function above.
- (WebCore::TextIterator::rangeFromLocationAndLength): Use the versions of the
- Range functions that don't take an exception code. Also tweak some other details
- of the code.
- (WebCore::isAllCollapsibleWhitespace): Added.
- (WebCore::collapsedToBoundary): Added.
- (WebCore::findPlainText): Rewrote to use new interface and streamline the
- logic a bit.
-
- Add the relevant files in the icu directory. As icu/README says, the "icu"
- directory is really just for Mac OS X, where we have the ICU library but not
- the headers installed. It should be moved inside platform/mac at some point
- to make this more clear (and the copy in JavaScriptCore should be moved
- somewhere similar for the same reason).
-
- * icu/unicode/ucoleitr.h: Added.
- * icu/unicode/usearch.h: Added.
-
-2009-01-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- CrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS::JSGlobalObject::stopTimeoutCheck + 0
- <rdar://problem/5821130>
-
- This was caused by a plugin instance calling into JS code that removed the plugin
- object. This fix is to cache the global object locally in a ProtectedPtr so we don't
- need to rely on the continued existence of the plugin instance.
-
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Evaluate):
- (_NPN_Construct):
-
-2008-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Holger Freyther.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22964
-
- MinGW build failure.
-
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::containsCharacters):
-
-2008-12-31 Alexander V. Butenko <alex@digiqube.com>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=22750
- [gtk] webkit up to r39121 crash on image urls like
- http:///sitename.com
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::ResourceHandle::start):
-
-2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=18310
-
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::determinePitch): Do not invoke
- isFixedPitch() when the font is a custom font.
-
-2008-12-31 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- More work on Bug 3781: Animation via canvas could be faster
- <https://bugs.webkit.org/show_bug.cgi?id=3781>
-
- Make use of the fast path parsing of color strings that Color
- uses. This improves performance of '#rgb', '#rrggbb', etc and
- named (eg. 'green') colors.
-
- Improves frame rate of test by around 40%
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
-
-2008-12-30 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=23042
-
- Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
- when there is a reflection, compute the location of the rect inside
- the reflection and take the union of the unreflected and reflected rects.
-
- Test: fast/repaint/reflection-redraw.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::reflectedRect):
- * rendering/RenderObject.h:
-
-2008-12-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adele Peterson.
-
- - fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
-
- Test: fast/forms/placeholder-non-textfield.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute): Only call
- updatePlaceholderVisibility() when the placeholder attribute changes if
- the element is a text field.
-
-2008-12-30 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Antti Koivisto.
-
- First step of Bug 3781: Animation via canvas could be faster
-
- Amortise the cost of calling repaint by coalescing repaint rects
- while the canvas is drawn to. In a later step we'll stop calling
- repaint() directly, and instead have all dirty canvases repaint
- at the end of JS execution.
-
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::willDraw):
- (WebCore::HTMLCanvasElement::paint):
- * html/HTMLCanvasElement.h:
-
-2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Antti Koivisto.
-
- Bug 22931: Using the inspector with purgeable resources leads to assertion failures
- <https://bugs.webkit.org/show_bug.cgi?id=22931>
-
- Change InspectorResource::sourceString() so that it doesn't attempt to
- unsafely get the data of a purgeable CachedResource.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorResource::sourceString): Attempt to make a purgeable
- resource unpurgeable, and if this not possible, return an empty string.
- * loader/CachedResource.h: Make InspectorResource a friend of CachedResource.
-
-2008-12-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=23023
- Remove incomplete support for opportunistic appcache entries
-
- No change in behavior, thus no test.
-
- * loader/appcache/ApplicationCacheResource.h:
- (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema
- version changes.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- * loader/appcache/ApplicationCacheResource.cpp:
- (WebCore::ApplicationCacheResource::dumpType):
-
-2008-12-29 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Add arcTo support for Cairo. This is needed by Canvas.
- Cairo has no native support for arcTo. We have to make our
- own implementation.
-
- [Canvas] Cairo needs arcTo
- https://bugs.webkit.org/show_bug.cgi?id=23003
-
- * platform/graphics/cairo/PathCairo.cpp:
- (WebCore::Path::addArcTo):
-
-2008-12-29 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Bug 23030: Cannot setTransform with a non-invertible ctm
-
- Removed a series of unnecessary and incorrect checks for an invertible
- transform.
-
- Test: fast/canvas/canvas-set-properties-with-non-invertible-ctm.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setStrokeStyle):
- (WebCore::CanvasRenderingContext2D::setFillStyle):
- These properties are not effected by the current CTM, so there
- is no need to prevent them from being assigned.
-
- (WebCore::CanvasRenderingContext2D::setTransform):
- The whole point of tracking whether the current CTM was expected to be
- non-invertible was to allow setTransform to be used when the CTM had become
- non-invertible.
-
- (WebCore::CanvasRenderingContext2D::beginPath):
- (WebCore::CanvasRenderingContext2D::closePath):
- beginPath and closePath change the state of the path, but not any of
- its coordinates so there is no need prevent them from being called.
-
-2008-12-29 Josh Roesslein <jroesslein@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22968
-
- Context menu rendering error when full page zoomed
-
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::handleContextMenuEvent):
-
-2008-12-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Add some basic memory statistic logging for Node.
-
- * dom/Node.cpp:
- (WebCore::Node::dumpStatistics):
- (WebCore::Node::Node):
- (WebCore::Node::~Node):
- (WebCore::Node::setDocument):
- * dom/Node.h:
-
-2008-12-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Remove one use of DeprecatedPtrList.
-
- * css/CSSRuleList.cpp:
- (WebCore::CSSRuleList::~CSSRuleList):
- (WebCore::CSSRuleList::length):
- (WebCore::CSSRuleList::item):
- (WebCore::CSSRuleList::deleteRule):
- (WebCore::CSSRuleList::append):
- (WebCore::CSSRuleList::insertRule):
- * css/CSSRuleList.h: Change m_lstCSSRules from using DeprecatedPtrList to a Vector.
- I measured no performance change and was comforted by the fact that we use a Vector
- for StyleList, which serves the exact same purpose.
-
-2008-12-29 Adele Peterson <adele@apple.com>
-
- Reviewed by Brady Eidson.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21797
- <rdar://problem/6310682> REGRESSION: Crash in CFHTTPCookieStorageCopy beneath WebCore::cookies() when
- running fast/dom/document-attribute-js-null.html and http/tests/security/cookies/create-document.html
-
- Return early if the document is trying to get or set a cookie with an empty cookie url.
-
- * dom/Document.cpp:
- (WebCore::Document::cookie):
- (WebCore::Document::setCookie):
-
-2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Sam Weinig.
-
- Bug 23016: JavaScriptDebugServer::recompileAllJSFunctions() should not execute JS while reparsing all functions
- <https://bugs.webkit.org/show_bug.cgi?id=23016>
- <rdar://problem/6425077>
-
- JavaScriptDebugServer::recompileAllJSFunctions() calls sourceParsed() while
- reparsing all JS functions, which will execute JS in the inspector. Depending
- on the order in which functions are recompiled, a function could have a new
- body but other functions that have not been recompiled could have an optimized
- (in the sense of inline caching) call to it, bypassing the check of whether or
- not there is generated bytecode. This leads to a crash caused by accessing
- indices off of a null pointer.
-
- To fix the problem, simply delay calling sourceParsed() until after all functions
- have been reparsed. The crash isn't 100% reproducible, but on the one test case
- I have, this makes it impossible to reproduce after a large number of attempts,
- when it used to happen every few attempts.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
-
-2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by Antti Koivisto.
- Oops, remove some last minute ASSERTS that are obviously wrong.
-
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
-
-2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Antti Koivisto.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=23015
-
- Don't rely on HTMLFormControlElement in RenderTextControl.
-
- Introduce an abstract FormControlElement class, containing the
- valueMatchesRenderer/setValueMatchesRenderer, the only HTMLFormControlElement
- specific methods that RenderTextControl relies on.
-
- This makes it possible for WML to reuse RenderTextControl.
- RenderTextControlSingleLine still relies on HTMLInputElement,
- this will change if WMLInputElement is introduced.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/FormControlElement.h: Added.
- (WebCore::FormControlElement::~FormControlElement):
- (WebCore::FormControlElement::FormControlElement):
- * html/HTMLFormControlElement.h:
- (WebCore::HTMLFormControlElement::valueMatchesRenderer):
- (WebCore::HTMLFormControlElement::setValueMatchesRenderer):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::updateValue):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::adjustInnerTextStyle):
- (WebCore::RenderTextControl::updateFromElement):
- (WebCore::RenderTextControl::setInnerTextValue):
- (WebCore::RenderTextControl::selectionChanged):
- (WebCore::RenderTextControl::formControlElement):
- * rendering/RenderTextControl.h:
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
-
-2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Darin Adler.
-
- Bug 23006: Many Loader::Host member functions are not safe to use reentrantly
- <https://bugs.webkit.org/show_bug.cgi?id=23006>
- <rdar://problem/6216106>
-
- Many Loader::Host member functions set m_processingResource to true when they
- begin processing a resource and set it to false when they are done. Thanks to
- JavaScript and the web inspector, almost anything can happen during the
- processing of a resource, including these functions being called reentrantly,
- which is unsafe due to this way of using m_processingResource.
-
- This can theoretically cause a Loader::Host to be used after it is freed,
- because when Loader::servedPendingRequests() is called, it will free Hosts
- that have m_processingResource set to false.
-
- To fix this, we replace m_processingResource with m_numResourcesProcessing,
- which is incremented and decremented using a helper object, ProcessingResource.
-
- There are no occurrences of crashes caused by this bug that are reproducible
- by multiple people, but this fixes the problem of m_processingResource being
- set to false while a Host is still alive.
-
- * loader/loader.cpp:
- (WebCore::Loader::Host::Host):
- (WebCore::Loader::Host::didFinishLoading): Change to use ProcessingResource
- instead of manually setting m_processingResource.
- (WebCore::Loader::Host::didFail): Ditto.
- (WebCore::Loader::Host::didReceiveData): Ditto.
- * loader/loader.h:
- (WebCore::Loader::Host::ProcessingResource::ProcessingResource): Added.
- (WebCore::Loader::Host::ProcessingResource::~ProcessingResource): Added.
- (WebCore::Loader::Host::processingResource): Change to use m_numResourcesProcessing
- instead of just getting m_processingResource.
-
-2008-12-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23007
- REGRESSION: Timer-related crash when closing Web Inspector
-
- Test: fast/dom/Window/remove-timeout-crash.html
-
- * bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::fired): Besides deleting the timer, make
- sure to remove it from a Document map.
-
-2008-12-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=23012
- Bring application cache manifest parsing up to date
-
- Test: http/tests/appcache/manifest-parsing.html
-
- * loader/appcache/ManifestParser.cpp:
- (WebCore::Mode): Added a constant for unknown sections, which are ignored when parsing. This
- is necessary for future extensions.
- (WebCore::parseManifest): Parse unknown sections correctly. Ignore trailing tokens in
- supported sections.
-
-2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22996
-
- RenderTextControl heavily depends on HTMLInputElement & HTMLTextAreaElement.
- It handles multi & single line text control rendering in one class. Split up
- in two new classes: RenderTextControlSingleLine & RenderTextControlMultiLine.
-
- This has several benefits - code is more readable now, the memory usage
- for RenderTextControlMultiLine is reduced, as all stuff related to search fields
- lives in RenderTextControlSingleLine, and it's easier to introduce an
- abstraction for input/textarea-like elements for other HTML flavours like WML.
-
- * GNUmakefile.am:
- * WebCore.order:
* WebCore.pro:
- * WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::createRenderer):
- (WebCore::HTMLInputElement::defaultEventHandler):
- (WebCore::HTMLInputElement::updatePlaceholderVisibility):
- (WebCore::HTMLInputElement::addSearchResult):
- (WebCore::HTMLInputElement::onSearch):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::createRenderer):
- (WebCore::HTMLTextAreaElement::defaultEventHandler):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::RenderTextControl):
- (WebCore::RenderTextControl::~RenderTextControl):
- (WebCore::RenderTextControl::styleDidChange):
- (WebCore::RenderTextControl::adjustInnerTextStyle):
- (WebCore::RenderTextControl::createSubtreeIfNeeded):
- (WebCore::RenderTextControl::textBlockHeight):
- (WebCore::RenderTextControl::textBlockWidth):
- (WebCore::RenderTextControl::updateFromElement):
- (WebCore::RenderTextControl::setInnerTextValue):
- (WebCore::RenderTextControl::setSelectionRange):
- (WebCore::RenderTextControl::visiblePositionForIndex):
- (WebCore::RenderTextControl::indexForVisiblePosition):
- (WebCore::RenderTextControl::subtreeHasChanged):
- (WebCore::RenderTextControl::scrollbarThickness):
- (WebCore::RenderTextControl::calcHeight):
- (WebCore::RenderTextControl::hitInnerTextBlock):
- (WebCore::RenderTextControl::forwardEvent):
- (WebCore::RenderTextControl::calcPrefWidths):
- (WebCore::RenderTextControl::selectionChanged):
- (WebCore::RenderTextControl::innerTextElement):
- * rendering/RenderTextControl.h:
- (WebCore::RenderTextControl::hasControlClip):
- (WebCore::RenderTextControl::canHaveChildren):
- (WebCore::RenderTextControl::avoidsFloats):
- (WebCore::RenderTextControl::isEdited):
- (WebCore::RenderTextControl::setEdited):
- * rendering/RenderTextControlMultiLine.cpp: Added.
- (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
- (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- (WebCore::RenderTextControlMultiLine::layout):
- (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- (WebCore::RenderTextControlMultiLine::forwardEvent):
- (WebCore::RenderTextControlMultiLine::preferredContentWidth):
- (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
- (WebCore::RenderTextControlMultiLine::baselinePosition):
- (WebCore::RenderTextControlMultiLine::updateFromElement):
- (WebCore::RenderTextControlMultiLine::cacheSelection):
- (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- * rendering/RenderTextControlMultiLine.h: Added.
- (WebCore::RenderTextControlMultiLine::isTextArea):
- * rendering/RenderTextControlSingleLine.cpp: Added.
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
- (WebCore::RenderTextControlSingleLine::updatePlaceholderVisibility):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::forwardEvent):
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::textBlockWidth):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
- (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::cacheSelection):
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
- (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
- (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- * rendering/RenderTextControlSingleLine.h: Added.
- (WebCore::RenderTextControlSingleLine::hasControlClip):
- (WebCore::RenderTextControlSingleLine::isTextField):
- (WebCore::RenderTextControlSingleLine::placeholderIsVisible):
- (WebCore::RenderTextControlSingleLine::popupIsVisible):
- (WebCore::RenderTextControlSingleLine::shouldPopOver):
- (WebCore::RenderTextControlSingleLine::valueShouldChangeOnHotTrack):
- * rendering/TextControlInnerElements.cpp:
- (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
-
-2008-12-28 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22755
- Prepare to add create/remove timeout methods to JSWorkerContext by moving
- timer-specific code from JSDOMWindowBase to DOMTimer.
- Moved everything JS-related from DOMTimer to ScheduledAction.
- Now ScheduledAction is what it wanted to be all the time: a JS engine-specific
- container for timer callback that knows how to invoke it.
- DOMTimer is not anymore JS-specific.
-
- This is mostly moving the code around. No intended functional changes.
-
- * bindings/js/DOMTimer.cpp:
- (WebCore::DOMTimer::DOMTimer):
- (WebCore::DOMTimer::~DOMTimer):
- (WebCore::DOMTimer::install):
- (WebCore::DOMTimer::removeById):
- (WebCore::DOMTimer::fired):
- (WebCore::DOMTimer::stop):
- * bindings/js/DOMTimer.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::installTimeout):
- (WebCore::JSDOMWindowBase::removeTimeout):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScheduledAction.h:
- * dom/Document.cpp:
- (WebCore::Document::addTimeout):
-
-2008-12-26 Zalan Bujtas <zbujtas@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22999
- Check if database thread exists.
-
- * storage/Database.cpp:
- (WebCore::Database::openAndVerifyVersion):
- (WebCore::Database::markAsDeletedAndClose):
- (WebCore::Database::tableNames):
-
-2008-12-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=23001
- A call to applicationCache.update() from a cached event listener should be ignored
-
- Test: http/tests/appcache/idempotent-update.html
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Only reset m_status after
- dispatching events.
-
-2008-12-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22997
- ASSERTION FAILED: !m_resources.contains(url) in ApplicationCache::addResource()
-
- Tests: http/tests/appcache/top-frame-1.html
- http/tests/appcache/top-frame-2.html
- http/tests/appcache/top-frame-3.html
- http/tests/appcache/top-frame-4.html
-
- * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest):
- Fixed one more instance of top level frame being used for caching purposes.
-
-2008-12-26 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22987
- Fix for broken test editing/execCommand/5763082.html
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::mergeIdenticalElements): Used local RefPtr to hold onto
- function parameter across multiple calls.
-
-2008-12-25 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22993
- Application cache shouldn't be inherited by subframes
-
- <rdar://problem/6284708> AppCache crashes in ApplicationCacheResource::addType()
- This crash happened because main resource for subframe was looked up in top frame's
- appcache. If not for the spec change, it could have been fixed by preventing the load
- altogether.
-
- Test: http/tests/appcache/foreign-iframe-main.html
- I intend to write additional tests for the behavior change.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- * loader/DocumentLoader.h:
- (WebCore::DocumentLoader::applicationCache):
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::load):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::associatedCache):
- Removed DocumentLoader::topLevelApplicationCache(), and changed callers accordingly.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::selectCache):
- (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
- Removed checks for the frame being top-level one, now that subframes are cached independently.
-
-2008-12-25 Antti Koivisto <antti@apple.com>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6465669> Frequent !isPurgeable() assertion in WebCore::CachedResource::addClient
-
- Disallow turning resources that are being revalidated to purgable state.
-
- No test, the condition is difficult to produce in DRT.
-
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::allClientsRemoved):
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::destroyDecodedData):
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::isSafeToMakePurgeable):
- (WebCore::CachedResource::makePurgeable):
- * loader/CachedResource.h:
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::destroyDecodedData):
-
-2008-12-25 Alexey Proskuryakov <ap@webkit.org>
-
- Qt build fix.
-
- * WebCore.pro: Added ThreadGlobalData.cpp.
-
-2008-12-24 Mark Rowe <mrowe@apple.com>
-
- Build fix.
-
- * WebCore.base.exp: Remove a symbol from the export file now that it is no longer generated.
-
-2008-12-24 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed build fix to find addSubresourceURL
-
- This is needed to compile on WebKit/Gtk+
-
- * css/CSSFontFaceSrcValue.cpp:
-
-2008-12-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22980
- WebCore uses more thread specific keys than it really needs
-
- Consolidated ThreadSpecific data into a single ThreadGlobalData structure.
-
- * GNUmakefile.am:
- * WebCore.base.exp:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/EventNames.cpp:
- * dom/EventNames.h:
- (WebCore::eventNames):
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
- * platform/ThreadGlobalData.cpp: Added.
- (WebCore::threadGlobalData):
- (WebCore::ThreadGlobalData::ThreadGlobalData):
- (WebCore::ThreadGlobalData::~ThreadGlobalData):
- * platform/ThreadGlobalData.h: Added.
- (WebCore::ThreadGlobalData::eventNames):
- (WebCore::ThreadGlobalData::emptyString):
- (WebCore::ThreadGlobalData::atomicStringTable):
- (WebCore::ThreadGlobalData::cachedConverterICU):
- (WebCore::ThreadGlobalData::cachedConverterTEC):
- * platform/text/AtomicString.cpp:
- (WebCore::stringTable):
- (WebCore::AtomicString::add):
- (WebCore::AtomicString::remove):
- (WebCore::AtomicString::find):
- (WebCore::AtomicString::init):
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::empty):
- * platform/text/StringImpl.h:
- * platform/text/TextCodecICU.cpp:
- (WebCore::ICUConverterWrapper::~ICUConverterWrapper):
- (WebCore::cachedConverterICU):
- * platform/text/TextCodecICU.h:
- (WebCore::ICUConverterWrapper::ICUConverterWrapper):
- * platform/text/mac/TextCodecMac.cpp:
- (WebCore::cachedConverterTEC):
- * platform/text/mac/TextCodecMac.h:
- (WebCore::TECConverterWrapper::TECConverterWrapper):
- (WebCore::TECConverterWrapper::~TECConverterWrapper):
-
-2008-12-23 Mark Rowe <mrowe@apple.com>
-
- Build fix.
-
- * WebCore.xcodeproj/project.pbxproj: CSSPropertyNames.h is a generated file so it needs to be explicitly copied
- into the PrivateHeaders directory, rather than relying on the automatic copying of headers which runs before the
- derived sources are generated.
-
-2008-12-23 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22941
-
- If the document element has opacity, we need to erase the view background to
- white before painting.
-
- Test: fast/backgrounds/opacity-on-document-element.html
-
- * rendering/RenderView.cpp:
- (WebCore::rendererObscuresBackground):
-
-2008-12-23 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=21910
-
- Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
- Otherwise the FrameView is left at 0x0, and nothing paints.
-
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::draw):
-
-2008-12-23 Darin Adler <darin@apple.com>
-
- Reviewed by John Sullivan.
-
- - improve robustness of undo/redo in HTML editing to fix the following bugs
- <https://bugs.webkit.org/show_bug.cgi?id=19703> Crash in WebCore::InsertNodeBeforeCommand::doUnapply()
- <rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo
-
- Major categories of improvements:
-
- 1) Added null checks.
- 2) Eliminated type casts without corresponding type checks.
- 3) Avoided possible infinite loops by building up lists of nodes to operate on
- before starting to make DOM changes.
- 4) Use more RefPtr.
-
- No test at this time, but test cases should follow in separate patches.
-
- * WebCore.xcodeproj/project.pbxproj: Set the role of CSSPropertyNames.h to Private so it
- can be used in other Private headers, specifically editing ones.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::locateCousinList): Adopt parentElement.
- (WebCore::CSSStyleSelector::locateSharedStyle): Ditto.
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
-
- * dom/Element.cpp: (WebCore::Element::cloneElement): Added.
- * dom/Element.h: Added cloneElement and an implementation of parentElement.
- * dom/Node.h: Moved parentElement from here to Element.h and changed its
- implementation so it will return 0 when the parent is not an element
- (document, document fragment, etc.).
-
- * editing/AppendNodeCommand.cpp:
- (WebCore::AppendNodeCommand::AppendNodeCommand): Made parent be an Element.
- Moved assertions from doApply in here.
- (WebCore::AppendNodeCommand::doApply): Simplified to just a single unchecked
- appendChild call.
- (WebCore::AppendNodeCommand::doUnapply): Simplified to just a single remove call.
- * editing/AppendNodeCommand.h: Updated.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::createStyleSpanElement): Eliminate casting by creating an element in a more
- direct way with new instead of createElementNS.
- (WebCore::ApplyStyleCommand::ApplyStyleCommand): Use PassRefPtr.
- (WebCore::ApplyStyleCommand::removeCSSStyle): Use CSSPropertyID.
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Use cloneElement.
- * editing/ApplyStyleCommand.h:
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply): Use Element* and cloneElement.
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::applyStyledElement): Use PassRefPtr and unsigned.
- (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
- (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
- (WebCore::CompositeEditCommand::insertNodeAfter): Ditto.
- (WebCore::CompositeEditCommand::insertNodeAt): Ditto.
- (WebCore::CompositeEditCommand::appendNode): Ditto.
- (WebCore::CompositeEditCommand::removeChildrenInRange): Ditto. Also use a vector to
- make the list of children in case removing them has side effects.
- (WebCore::CompositeEditCommand::removeNode): Ditto.
- (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
- (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Ditto.
- (WebCore::CompositeEditCommand::splitTextNode): Ditto.
- (WebCore::CompositeEditCommand::splitElement): Ditto.
- (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
- (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
- (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
- (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
- (WebCore::CompositeEditCommand::inputText): Ditto.
- (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
- (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
- (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
- (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): Ditto.
- (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
- (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Implement by calling
- setNodeAttribute instead of with its own SimpleEditCommand.
- (WebCore::CompositeEditCommand::setNodeAttribute): Ditto.
- (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
- (WebCore::CompositeEditCommand::appendBlockPlaceholder): Ditto.
- (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto.
- (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto. Don't
- bother using an undoable operation to put the break element into the paragraph
- element because there's no need to split them and redo this when doing undo/redo.
- (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
- (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
- * editing/CompositeEditCommand.h: Ditto.
-
- * editing/DeleteFromTextNodeCommand.cpp:
- (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Use unsigned.
- (WebCore::DeleteFromTextNodeCommand::doApply): Eliminated inappropriate assertions.
- (WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
- * editing/DeleteFromTextNodeCommand.h:
-
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::removeNode): Use PassRefPtr.
- (WebCore::DeleteSelectionCommand::deleteTextFromNode): Ditto.
- * editing/DeleteSelectionCommand.h:
-
- * editing/FormatBlockCommand.cpp:
- (WebCore::FormatBlockCommand::FormatBlockCommand): Use AtomicString.
- (WebCore::FormatBlockCommand::doApply): Use Element.
- * editing/FormatBlockCommand.h:
-
- * editing/IndentOutdentCommand.cpp:
- (WebCore::createIndentBlockquoteElement): Use new to create the element
- instead of calling a function so we have a more specific type.
- (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
- Use RefPtr and Element.
- (WebCore::IndentOutdentCommand::indentRegion): Ditto.
- (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
- * editing/IndentOutdentCommand.h:
-
- * editing/InsertIntoTextNodeCommand.cpp:
- (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
- Use unsigned. Added an assertion.
- (WebCore::InsertIntoTextNodeCommand::doApply): Eliminated inappropriate assertions.
- (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
- * editing/InsertIntoTextNodeCommand.h:
-
- * editing/InsertLineBreakCommand.cpp:
- (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use Element.
- (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
-
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::doApply): Use Element.
-
- * editing/InsertNodeBeforeCommand.cpp:
- (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Moved assertions
- here from doApply.
- (WebCore::InsertNodeBeforeCommand::doApply): Eliminated inappropriate assertions.
- Added a null check.
- (WebCore::InsertNodeBeforeCommand::doUnapply): Simplified to just a single remove call.
-
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply): Use Element and cloneElement.
-
- * editing/JoinTextNodesCommand.cpp:
- (WebCore::JoinTextNodesCommand::doApply): Eliminated inappropriate assertions.
- Added some runtime checks. Don't store anything in m_offset.
- (WebCore::JoinTextNodesCommand::doUnapply): Ditto.
- * editing/JoinTextNodesCommand.h:
-
- * editing/MergeIdenticalElementsCommand.cpp:
- (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Moved
- an assertion here from doApply.
- (WebCore::MergeIdenticalElementsCommand::doApply): Eliminated inappropriate assertions.
- Added a null check. Changed implementation to use remove to avoid null parent issue.
- Use a vector of nodes to avoid possible infinite loop if mutation happens while iterating.
- (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
-
- * editing/ModifySelectionListLevel.cpp:
- (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): Use Element*.
- (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
- * editing/ModifySelectionListLevel.h:
-
- * editing/RemoveCSSPropertyCommand.cpp:
- (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Use PassRefPtr and
- CSSPropertyID. Also renamed m_decl to m_style.
- (WebCore::RemoveCSSPropertyCommand::doApply): Eliminated inappropriate assertions.
- (WebCore::RemoveCSSPropertyCommand::doUnapply): Ditto.
-
- * editing/RemoveNodeAttributeCommand.cpp: Removed contents of this file. To be deleted.
- Use SetNodeAttributeCommand instead.
- * editing/RemoveNodeAttributeCommand.h: Ditto.
-
- * editing/RemoveNodeCommand.cpp:
- (WebCore::RemoveNodeCommand::RemoveNodeCommand): Moved assertions here from doApply.
- Don't initialize m_refChild here; rather do it in doApply.
- (WebCore::RemoveNodeCommand::doApply): Eliminated inappropriate assertions. Added
- checks and streamlined implementation.
- (WebCore::RemoveNodeCommand::doUnapply): Ditto.
- * editing/RemoveNodeCommand.h:
-
- * editing/RemoveNodePreservingChildrenCommand.cpp:
- (WebCore::RemoveNodePreservingChildrenCommand::doApply): Use a vector.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::insertFragmentForTestRendering): Removed now-unneeded cast.
-
- * editing/SetNodeAttributeCommand.cpp:
- (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Use AtomicString.
- Removed assertion that prevents us from using this to remove an attribute.
- (WebCore::SetNodeAttributeCommand::doApply): Eliminated inappropriate assertions.
- (WebCore::SetNodeAttributeCommand::doUnapply): Ditto.
- * editing/SetNodeAttributeCommand.h:
-
- * editing/SplitElementCommand.cpp:
- (WebCore::SplitElementCommand::SplitElementCommand): Moved assertion here from doApply.
- (WebCore::SplitElementCommand::doApply): Check some more invariants and use a vector
- to avoid possible infinite loops.
- (WebCore::SplitElementCommand::doUnapply): Ditto.
-
- * editing/SplitTextNodeCommand.cpp:
- (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Moved assertions and comment
- here from doApply.
- (WebCore::SplitTextNodeCommand::doApply): Check for null and failures when applying.
- (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
-
- * editing/SplitTextNodeContainingElementCommand.cpp:
- (WebCore::SplitTextNodeContainingElementCommand::doApply): Use Element.
-
- * editing/WrapContentsInDummySpanCommand.cpp:
- (WebCore::WrapContentsInDummySpanCommand::doApply): Check for null and ignore failures.
- Don't reuse the dummy span. Simplified logic.
- (WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.
-
- * editing/htmlediting.cpp:
- (WebCore::isBlock): Make sure this returns true only for elements.
- (WebCore::enclosingBlock): Return an Element*.
- (WebCore::enclosingTableCell): Ditto.
- (WebCore::enclosingList): Return an HTMLElement*.
- (WebCore::outermostEnclosingList): Return an HTMLElement*.
- (WebCore::createDefaultParagraphElement): Return an HTMLElement*.
- (WebCore::createBreakElement): Return an HTMLElement*.
- (WebCore::createOrderedListElement): Return an HTMLElement*.
- (WebCore::createUnorderedListElement): Return an HTMLElement*.
- (WebCore::createListItemElement): Return an HTMLElement*.
- (WebCore::createHTMLElement): Return an HTMLElement*.
- * editing/htmlediting.h:
-
- * editing/markup.cpp:
- (WebCore::createFragmentFromText): Use createBreakElement and use Element*.
-
- * page/MouseEventWithHitTestResults.cpp:
- (WebCore::MouseEventWithHitTestResults::targetNode): Use parentElement.
-
-2008-12-23 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- * dom/Node.h: Tweak comments and order of bits that Sam moved
- here last night.
- * dom/Node.cpp: Ditto.
-
-2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 11106: Some XMLHttpRequest URI resolving tests fail
- https://bugs.webkit.org/show_bug.cgi?id=11106
-
- Use the ScriptExecutionContext to resolve the URI when calling open in JavaScript.
- The previous code was using the containing DOMWindow to do so which would fail for
- XMLHttpRequest object being passed between iframe.
-
- Tests: http/tests/xmlhttprequest/uri-resolution-opera-open-004.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-005.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-006.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-007.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-008.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-009.html
- http/tests/xmlhttprequest/uri-resolution-opera-open-010.html
-
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::open): Use the ScriptExecutionContext
- to resolve the URL.
-
- * dom/Document.cpp:
- (WebCore::Document::virtualCompleteURL): Virtual method added to
- avoid performance hit on completeURL call.
-
- * dom/Document.h:
- * dom/ScriptExecutionContext.h:
- (WebCore::ScriptExecutionContext::completeURL): Non-virtual method
- that wrap the call to the virtual call.
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::virtualCompleteURL): Pure virtual method.
- * dom/WorkerContext.h:
-
-2008-12-23 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22978
- a couple tweaks to the new strokeBoundingRect functions
-
- * platform/graphics/cairo/PathCairo.cpp:
- (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
- if the applier is non-null.
-
- * platform/graphics/cg/PathCG.cpp:
- (WebCore::putBytesNowhere): Added.
- (WebCore::createScratchContext): Changed to use a "/dev/null" type
- function to discard bytes rather than using a data object. This
- eliminates the possibility that memory will be used if someone draws
- into the scratch context by accident. Also moved to the top of the
- file; it was in a slightly strange place before.
- (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
- if the applier is non-null. Simplify the empty path special case.
-
-2008-12-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Save a word in all Elements by moving the 5 loose bits to Node,
- where we had 16 spare.
-
- * dom/Element.cpp:
- (WebCore::Element::Element):
- * dom/Element.h:
- * dom/Node.cpp:
- (WebCore::Node::Node):
- * dom/Node.h:
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22972
-
- Add WML <meta> element support. All needed functionality is present
- in Document::processHttpEquiv, already covered by tests.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLMetaElement.cpp: Added.
- (WebCore::WMLMetaElement::WMLMetaElement):
- (WebCore::WMLMetaElement::parseMappedAttribute):
- (WebCore::WMLMetaElement::insertedIntoDocument):
- * wml/WMLMetaElement.h: Added.
- * wml/WMLTagNames.in:
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by Darin Adler.
-
- Don't reference specific layout tests in comments.
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::createFormData):
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22965
-
- Add WML <head> element support. Doesn't require a WMLHeadElement.
- No functional behaviour, as we already created a WMLElement for headTag, by default.
- It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.
-
- * wml/WMLTagNames.in:
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
-
- Fix regression caused by the HTMLFormElement refactorization.
- File form elements without a name have to be included in multipart/form-data
- submission. Cover this behaviour with a new test case.
-
- Test: http/tests/misc/empty-file-formdata.html
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::createFormData):
- * wml/WMLTagNames.in:
-
-2008-12-22 David Kilzer <ddkilzer@apple.com>
-
- <rdar://problem/6438298> Bump schema version for app cache
-
- Reviewed by Alexey Proskuryakov.
-
- * loader/appcache/ApplicationCacheStorage.cpp: Increment
- SchemaVersion from 2 to 3.
-
-2008-12-22 David Kilzer <ddkilzer@apple.com>
+ * html/DataGridColumn.cpp: Added.
+ (WebCore::DataGridColumn::setPrimary):
+ * html/DataGridColumn.h: Added.
+ (WebCore::DataGridColumn::create):
+ (WebCore::DataGridColumn::id):
+ (WebCore::DataGridColumn::setId):
+ (WebCore::DataGridColumn::label):
+ (WebCore::DataGridColumn::setLabel):
+ (WebCore::DataGridColumn::type):
+ (WebCore::DataGridColumn::setType):
+ (WebCore::DataGridColumn::sortable):
+ (WebCore::DataGridColumn::setSortable):
+ (WebCore::DataGridColumn::sortDirection):
+ (WebCore::DataGridColumn::setSortDirection):
+ (WebCore::DataGridColumn::primary):
+ (WebCore::DataGridColumn::detachFromColumnList):
+ (WebCore::DataGridColumn::DataGridColumn):
+ * html/DataGridColumn.idl: Added.
+ * html/DataGridColumnList.cpp: Added.
+ (WebCore::DataGridColumnList::~DataGridColumnList):
+ (WebCore::DataGridColumnList::itemWithName):
+ (WebCore::DataGridColumnList::add):
+ (WebCore::DataGridColumnList::remove):
+ (WebCore::DataGridColumnList::move):
+ (WebCore::DataGridColumnList::clear):
+ (WebCore::DataGridColumnList::primaryColumnChanged):
+ * html/DataGridColumnList.h: Added.
+ (WebCore::DataGridColumnList::create):
+ (WebCore::DataGridColumnList::length):
+ (WebCore::DataGridColumnList::item):
+ (WebCore::DataGridColumnList::primaryColumn):
+ (WebCore::DataGridColumnList::sortColumn):
+ * html/DataGridColumnList.idl: Added.
+ * html/HTMLDataGridColElement.cpp:
+ (WebCore::HTMLDataGridColElement::sortable):
+ (WebCore::HTMLDataGridColElement::setSortable):
+ (WebCore::HTMLDataGridColElement::sortDirection):
+ (WebCore::HTMLDataGridColElement::setSortDirection):
+ * html/HTMLDataGridColElement.h:
+ * html/HTMLDataGridColElement.idl:
+ * html/HTMLDataGridElement.cpp:
+ (WebCore::HTMLDataGridElement::HTMLDataGridElement):
+ * html/HTMLDataGridElement.h:
+ (WebCore::HTMLDataGridElement::columns):
+ * html/HTMLDataGridElement.idl:
+ * rendering/RenderDataGrid.cpp:
+ (WebCore::RenderDataGrid::paintObject):
+ (WebCore::RenderDataGrid::paintColumnHeaders):
+ (WebCore::RenderDataGrid::rebuildColumns):
+ * rendering/RenderDataGrid.h:
+ (WebCore::RenderDataGrid::gridElement):
+
+2009-06-24 Jessie Berlin <jberlin@apple.com>
- Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
-
- Reviewed by Darin Adler.
-
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced
- use of ListHashSet with more efficient Deque.
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Fix obvious crash fix for WML enabled builds.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
-
-2008-12-22 David Kilzer <ddkilzer@apple.com>
-
- Bug 11850: Webarchive fails to save images referenced in CSS
-
- <https://bugs.webkit.org/show_bug.cgi?id=11850>
-
- Reviewed by Darin Adler.
-
- This entry contains two parts since the tests for adding a
- completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
- on Bug 11850 being fixed (part 2).
-
- --
-
- Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html
- http/tests/webarchive/test-css-url-encoding-utf-8.html
- http/tests/webarchive/test-css-url-encoding.html
-
- Added completeURL() methods to StyleSheet and CSSStyleSheet that
- match the behavior of Document::completeURL(). Most notably,
- CSSStyleSheet::completeURL() uses the charset of the stylesheet
- (if it exists) to construct URLs, just like Document::completeURL().
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL().
- (WebCore::CSSParser::parseContent): Ditto.
- (WebCore::CSSParser::parseFillImage): Ditto.
- (WebCore::CSSParser::parseFontFaceSrc): Ditto.
- (WebCore::CSSParser::parseBorderImage): Ditto.
-
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::completeURL): Added.
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::completeURL): Added declaration.
-
- * css/StyleSheet.cpp:
- (WebCore::StyleSheet::completeURL): Added.
- * css/StyleSheet.h:
- (WebCore::StyleSheet::completeURL): Added declaration.
-
- * dom/Document.cpp:
- (WebCore::Document::completeURL): Added comment referring to the new
- completeURL() methods in StyleSheet and CSSStyleSheet.
-
- --
-
- Tests: webarchive/test-css-url-resources-in-stylesheets.html
- webarchive/test-css-url-resources-inline-styles.html
-
- Walk stylesheets and inline style attributes for url() references
- when building a list of URLs to include in a webarchive. Note that
- not all URLs found this way will be included in the webarchive if
- they were not used (and thus not downloaded) when laying out the
- page.
-
- The key method for CSS stylesheets is
- CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
- CSSStyleSheet objects recursively referenced from its own stylesheet
- through @import rules. Starting with the CSSRule objects in each
- sheet and continuing down through the CSSMutableStyleDeclaration and
- CSSValue objects, addSubresourceStyleURLs() methods are called to
- gather URLs.
-
- For inline style attributes in HTML DOM elements,
- StyledElement::addSubresourceAttributeURLs() calls
- CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
- from each element, hence the need to call
- addSubresourceAttributeURLs() on superclasses when the method is
- implemented on the element class itself.
-
- * css/CSSBorderImageValue.cpp:
- (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
- * css/CSSBorderImageValue.h:
- (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSFontFaceRule.cpp:
- (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
- * css/CSSFontFaceRule.h:
- (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSFontFaceSrcValue.cpp:
- (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
- * css/CSSFontFaceSrcValue.h:
- (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
- * css/CSSImportRule.h:
- (WebCore::CSSImportRule::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added.
- Iterates over m_properties vector of CSSProperty objects calling
- addSubresourceStyleURLs() on each property's CSSValue object.
- * css/CSSMutableStyleDeclaration.h:
- (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSReflectValue.cpp:
- (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
- * css/CSSReflectValue.h:
- (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSRule.h:
- (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual
- method with empty implementation that's overridden by subclasses
- as needed.
-
- * css/CSSStyleRule.cpp:
- (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
- * css/CSSStyleRule.h:
- (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added
- declaration.
-
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to
- call CSSRule::addSubresourceStyleURLs on each rule to extract
- URLs. Removed unneeded baseURL parameter now that the
- completeURL() method exists.
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated
- declaration.
-
- * css/CSSValue.h:
- (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual
- method with empty implementation that's overridden by subclasses
- as needed.
-
- * css/CSSValueList.cpp:
- (WebCore::CSSValueList::addSubresourceStyleURLs): Added.
- Iterates over m_values vector of CSSValue objects calling
- addSubresourceStyleURLs() on each.
- * css/CSSValueList.h:
- (WebCore::CSSValueList::addSubresourceStyleURLs): Added
- declaration.
-
- * css/StyleSheet.h:
- (WebCore::StyleSheet::addSubresourceStyleURLs): Updated
- declaration to remove unneeded baseURL parameter.
-
- * dom/ProcessingInstruction.cpp:
- (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
- Fixed to use the StyleBase::baseURL() method to get the
- stylesheet's URL instead of calling Document::completeURL().
-
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::addSubresourceAttributeURLs): Added method
- to extract URLs from inline style declarations.
- * dom/StyledElement.h:
- (WebCore::StyledElement::addSubresourceAttributeURLs): Added
- declaration.
-
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call
- addSubresourceAttributeURLs() in superclass to extract URLs
- from inline style declarations.
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLParamElement.cpp:
- (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLTableCellElement.cpp:
- (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLTableElement.cpp:
- (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGCursorElement.cpp:
- (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGImageElement.cpp:
- (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
-
-2008-12-22 Dhananjoy Chutia <dhanrd@gmail.com>
-
- Reviewed by David Kilzer.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22959
- Memory leak fixes for WebKit+soup
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::finishedCallback):
-
-2008-12-22 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available
+ Reviewed by Adam Roben.
- Tests: http/tests/appcache/404-manifest.html
- http/tests/appcache/fail-on-update.html
+ Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
+ (<rdar://problem/5015942>)
+ Where on windows it was not possible to set an element as the drag
+ image using setDragImage on the dataTransfer object.
+
+ Does not "fix" the case of dragging a link where the default link image
+ is still used, even when the -webkit-user-drag is set to "element". This
+ is the same behavior as is found on OS X.
+
+ Added a manual test because it is not possible to check that what is
+ contained in the image snapshot is indeed the requested element.
- * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading):
- Removed the incorrect assertion.
+ * dom/Clipboard.h:
+ (WebCore::Clipboard::dragImageElement):
+ Made getting the raw pointer from the RefPtr a const operation.
+ * manual-tests/drag-with-div-or-image-as-data-image.html: Added.
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::createDragImage):
+ Get an image of the rendered element and its subtree.
- * loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive
- m_currentHandle handling.
+2009-06-24 Darin Fisher <darin@chromium.org>
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+ Reviewed by David Levin.
- Reviewed by Alexey Proskuryakov & George Staikos.
+ https://bugs.webkit.org/show_bug.cgi?id=26683
+ Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22961
+ This change just adds a stub implementation for now to help fix the build.
- Add WML <fieldset> element support.
- Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
- to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
- element. To integrate within the existing RenderFieldset code, we just create an
- internal <insertedLegend> element as first child for a WML <fieldset> element, containing
- the title attribute value.
+ * bindings/v8/custom/V8CustomBinding.h:
+ * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * css/wml.css:
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::RenderFieldset):
- (WebCore::RenderFieldset::findLegend):
- * rendering/RenderFieldset.h:
- * rendering/RenderLegend.cpp:
- (WebCore::RenderLegend::RenderLegend):
- * rendering/RenderLegend.h:
- * wml/WMLFieldSetElement.cpp: Added.
- (WebCore::WMLFieldSetElement::WMLFieldSetElement):
- (WebCore::WMLFieldSetElement::~WMLFieldSetElement):
- (WebCore::WMLFieldSetElement::parseMappedAttribute):
- (WebCore::WMLFieldSetElement::insertedIntoDocument):
- (WebCore::WMLFieldSetElement::removedFromDocument):
- (WebCore::WMLFieldSetElement::createRenderer):
- * wml/WMLFieldSetElement.h: Added.
- * wml/WMLInsertedLegendElement.cpp: Added.
- (WebCore::WMLInsertedLegendElement::WMLInsertedLegendElement):
- (WebCore::WMLInsertedLegendElement::~WMLInsertedLegendElement):
- (WebCore::WMLInsertedLegendElement::createRenderer):
- * wml/WMLInsertedLegendElement.h: Added.
- * wml/WMLTagNames.in:
+2009-06-24 David Kilzer <ddkilzer@apple.com>
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+ Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
- Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h
+ Reviewed by Adam Roben.
- * WebCore.xcodeproj/project.pbxproj:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::deliverNotification): Removed
+ ExceptionCode parameter from togglePlayState().
+ (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL
+ object to a String when assigning to a KURL variable.
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+2009-06-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
- Rubber-stamped by George Staikos.
+ Reviewed by Adam Treat.
- Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
+ Save memory by not storing attribute values in member variables, if not absolutely needed.
+ Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).
- * css/CSSStyleSelector.cpp:
- * css/wml.css:
- * dom/DOMImplementation.cpp:
- * dom/Document.cpp:
- * dom/Document.h:
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizerLibxml2.cpp:
- * dom/XMLTokenizerQt.cpp:
- * history/BackForwardList.cpp:
- * history/BackForwardList.h:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
- * loader/MainResourceLoader.cpp:
- * page/Page.cpp:
- * page/Page.h:
- * platform/MIMETypeRegistry.cpp:
- * platform/network/FormDataBuilder.cpp:
- * platform/network/FormDataBuilder.h:
- * platform/qt/MIMETypeRegistryQt.cpp:
- * wml/WMLAElement.cpp:
- * wml/WMLAElement.h:
- * wml/WMLAccessElement.cpp:
- * wml/WMLAccessElement.h:
- * wml/WMLAnchorElement.cpp:
- * wml/WMLAnchorElement.h:
- * wml/WMLBRElement.cpp:
- * wml/WMLBRElement.h:
- * wml/WMLCardElement.cpp:
- * wml/WMLCardElement.h:
* wml/WMLDoElement.cpp:
+ (WebCore::WMLDoElement::parseMappedAttribute):
+ (WebCore::WMLDoElement::label):
* wml/WMLDoElement.h:
- * wml/WMLDocument.cpp:
- * wml/WMLDocument.h:
- * wml/WMLElement.cpp:
- * wml/WMLElement.h:
- * wml/WMLErrorHandling.cpp:
- * wml/WMLErrorHandling.h:
- * wml/WMLEventHandlingElement.cpp:
- * wml/WMLEventHandlingElement.h:
- * wml/WMLGoElement.cpp:
- * wml/WMLGoElement.h:
- * wml/WMLImageElement.cpp:
- * wml/WMLImageElement.h:
- * wml/WMLImageLoader.cpp:
- * wml/WMLImageLoader.h:
- * wml/WMLIntrinsicEvent.cpp:
- * wml/WMLIntrinsicEvent.h:
- * wml/WMLIntrinsicEventHandler.cpp:
- * wml/WMLIntrinsicEventHandler.h:
- * wml/WMLNoopElement.cpp:
- * wml/WMLNoopElement.h:
- * wml/WMLOnEventElement.cpp:
- * wml/WMLOnEventElement.h:
- * wml/WMLPElement.cpp:
- * wml/WMLPElement.h:
- * wml/WMLPageState.cpp:
- * wml/WMLPageState.h:
- * wml/WMLPostfieldElement.cpp:
- * wml/WMLPostfieldElement.h:
- * wml/WMLPrevElement.cpp:
- * wml/WMLPrevElement.h:
- * wml/WMLRefreshElement.cpp:
- * wml/WMLRefreshElement.h:
- * wml/WMLSetvarElement.cpp:
- * wml/WMLSetvarElement.h:
- * wml/WMLTableElement.cpp:
- * wml/WMLTableElement.h:
- * wml/WMLTaskElement.cpp:
- * wml/WMLTaskElement.h:
- * wml/WMLTemplateElement.cpp:
- * wml/WMLTemplateElement.h:
- * wml/WMLTimerElement.cpp:
- * wml/WMLTimerElement.h:
- * wml/WMLVariables.cpp:
- * wml/WMLVariables.h:
-
-2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22638
-
- Add POST method support to WMLGoElement. GET & POST over HTTP
- covered by a new set of WML HTTP layout tests.
-
- Tests: http/tests/wml/go-task-get-method-accept-charset.html
- http/tests/wml/go-task-get-method.html
- http/tests/wml/go-task-post-method-accept-charset.html
- http/tests/wml/go-task-post-method.html
-
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::WMLGoElement):
- (WebCore::WMLGoElement::registerPostfieldElement):
- (WebCore::WMLGoElement::parseMappedAttribute):
- (WebCore::WMLGoElement::executeTask):
- (WebCore::WMLGoElement::preparePOSTRequest):
- (WebCore::WMLGoElement::prepareGETRequest):
- (WebCore::WMLGoElement::createFormData):
- * wml/WMLGoElement.h:
+ * wml/WMLFieldSetElement.cpp:
+ (WebCore::WMLFieldSetElement::insertedIntoDocument):
+ * wml/WMLFieldSetElement.h:
+ * wml/WMLOptGroupElement.cpp:
+ (WebCore::WMLOptGroupElement::title):
+ (WebCore::WMLOptGroupElement::parseMappedAttribute):
+ (WebCore::WMLOptGroupElement::groupLabelText):
+ * wml/WMLOptGroupElement.h:
* wml/WMLPostfieldElement.cpp:
- (WebCore::encodedString):
- (WebCore::WMLPostfieldElement::encodeData):
- * wml/WMLPostfieldElement.h:
-
-2008-12-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler and George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22949
-
- Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
- Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
- It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
- submission, including boundary string generation, multi-part form handling etc.
-
- No functional changes, no test cases affected.
- WMLGoElement will be converted in a follow-up patch.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::HTMLFormElement):
- (WebCore::HTMLFormElement::dataEncoding):
- (WebCore::HTMLFormElement::createFormData):
- (WebCore::HTMLFormElement::submit):
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFormElement.h:
- (WebCore::HTMLFormElement::enctype):
- (WebCore::HTMLFormElement::encoding):
- (WebCore::HTMLFormElement::setEncoding):
- (WebCore::HTMLFormElement::acceptCharset):
- * platform/network/FormDataBuilder.cpp: Added.
- (WebCore::FormDataBuilder::FormDataBuilder):
- (WebCore::FormDataBuilder::~FormDataBuilder):
- (WebCore::FormDataBuilder::parseEncodingType):
- (WebCore::FormDataBuilder::parseMethodType):
- (WebCore::FormDataBuilder::dataEncoding):
- (WebCore::appendString):
- (WebCore::FormDataBuilder::beginMultiPartHeader):
- (WebCore::FormDataBuilder::addBoundaryToMultiPartHeader):
- (WebCore::FormDataBuilder::addFileNameToMultiPartHeader):
- (WebCore::FormDataBuilder::addContentTypeToMultiPartHeader):
- (WebCore::FormDataBuilder::finishMultiPartHeader):
- (WebCore::FormDataBuilder::clear):
- (WebCore::FormDataBuilder::addKeyValuePairAsFormData):
- (WebCore::FormDataBuilder::encodeStringAsFormData):
- (WebCore::FormDataBuilder::generateUniqueBoundaryString):
- * platform/network/FormDataBuilder.h: Added.
- (WebCore::FormDataBuilder::isPostMethod):
- (WebCore::FormDataBuilder::setIsPostMethod):
- (WebCore::FormDataBuilder::isMultiPartForm):
- (WebCore::FormDataBuilder::setIsMultiPartForm):
- (WebCore::FormDataBuilder::encodingType):
- (WebCore::FormDataBuilder::setEncodingType):
- (WebCore::FormDataBuilder::acceptCharset):
- (WebCore::FormDataBuilder::setAcceptCharset):
- (WebCore::FormDataBuilder::encodedData):
- (WebCore::FormDataBuilder::multiPartData):
-
-2008-12-21 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Darin Adler, Nikolas Zimmermann.
-
- Move the the platform dependent strokeBBox functionality out of RenderPath
- into Path with strokeBoundingRect.
-
- RenderPath clean-up for strokeBoundingBox
- [https://bugs.webkit.org/show_bug.cgi?id=22902]
-
- * GNUmakefile.am:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/Path.h:
- * platform/graphics/StrokeStyleApplier.h: Added.
- (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
- * platform/graphics/cairo/PathCairo.cpp:
- (WebCore::Path::strokeBoundingRect):
- * platform/graphics/cg/PathCG.cpp:
- (WebCore::createScratchContext):
- (WebCore::scratchContext):
- (WebCore::Path::strokeBoundingRect):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::pen):
- * platform/graphics/qt/PathQt.cpp:
- (WebCore::Path::strokeBoundingRect):
- * rendering/RenderPath.cpp:
- (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier):
- (WebCore::StrokeBoundingRectStyleApplier::strokeStyle):
- (WebCore::RenderPath::relativeBBox):
- * rendering/RenderPath.h:
- * svg/graphics/cairo/RenderPathCairo.cpp:
- * svg/graphics/cg/RenderPathCg.cpp:
- * svg/graphics/qt/RenderPathQt.cpp:
-
-2008-12-20 David Kilzer <ddkilzer@apple.com>
-
- Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"
-
- * html/PreloadScanner.cpp:
- (WebCore::PreloadScanner::tokenizeCSS):
- * html/PreloadScanner.h:
- (WebCore::PreloadScanner::CSSState):
-
-2008-12-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- <rdar://problem/6454076> Random crashes on JS raytracer
-
- No test, because the crash is not readily reproducible.
-
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::empty):
- * platform/text/StringImpl.h:
- Made empty string per-thread.
-
-2008-12-19 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- Replace some uses of HardRetain etc with RetainPtr.
-
- * platform/mac/DragImageMac.mm:
- * platform/mac/SharedBufferMac.mm:
- (WebCore::SharedBuffer::createCFData):
- * rendering/RenderThemeMac.mm:
- * svg/graphics/cg/SVGResourceFilterCg.mm:
- (WebCore::SVGResourceFilter::prepareFilter):
- (WebCore::SVGResourceFilter::applyFilter):
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
- * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
- (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
-
-2008-12-19 miggilin <mr.diggilin@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Add Context Menu support to wx bindings.
-
- https://bugs.webkit.org/show_bug.cgi?id=22675
-
- * platform/ContextMenu.h:
- * platform/ContextMenuItem.h:
- (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
- * platform/wx/ContextMenuItemWx.cpp: Added.
- * platform/wx/ContextMenuWx.cpp: Added.
- * platform/wx/LocalizedStringsWx.cpp:
- * platform/wx/TemporaryLinkStubs.cpp:
- * webcore-wx.bkl:
-
-
-2008-12-19 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
- crash occurs at
- AccessibilityTable::isTableExposableThroughAccessibility() when
- attempting to create a link in a rich text message
-
- We need to disable Accessibility Tables until we get this fixed for
- real to prevent rampant crashing.
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::AccessibilityTable):
-
-2008-12-19 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=22938
-
- When the document element is transformed, we need to paint
- the view background to avoid unpainted areas.
-
- Test: fast/transforms/transformed-document-element.html
-
- * rendering/RenderView.cpp:
- (WebCore::RenderView::paintBoxDecorations):
-
-2008-12-19 Steve Falkenburg <sfalken@apple.com>
-
- Fix build.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-12-19 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after recent changes.
-
- * WebCoreSources.bkl:
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::clear):
- * webcore-base.bkl:
-
-2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Sam Weinig.
-
- [GTK] Fix make distcheck again
-
- These files were moved to WebCore/platform/animation
- and WebCore/platform/graphics/transforms.
-
- * GNUmakefile.am:
-
-2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=22900
-
- Fix AtomicString usage, so that building works.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
-
-2008-12-19 Adam Roben <aroben@apple.com>
-
- Windows build fix on older versions of CFNetwork after r39393
-
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::highestSupportedCFURLConnectionClientVersion): Changed
- preprocessor directives not to leave in unreachable code on old
- versions of CFNetwork.
-
-2008-12-19 Antti Koivisto <antti@apple.com>
-
- Comment fix.
-
- * platform/PurgeableBuffer.h:
-
-2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- [GTK] Build fix by adding the new files.
-
- * GNUmakefile.am:
-
-2008-12-19 Jade Han <jade.han@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- [Qt] Allow conversion of JavaScript Number and Boolean types to Qt types
-
- https://bugs.webkit.org/show_bug.cgi?id=22880
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertValueToQVariant):
-
-2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Holger Freyther.
-
- Implement ImageDecoder::filenameExtension() for Qt
-
- * platform/graphics/qt/ImageDecoderQt.cpp:
- (WebCore::ImageDecoderQt::filenameExtension):
- * platform/graphics/qt/ImageDecoderQt.h:
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::filenameExtension):
-
-2008-12-19 Adam Barth <abarth@webkit.org>
-
- Reviewed by Darin Alder.
-
- Implement ImageSource::filenameExtension for Cario
- https://bugs.webkit.org/show_bug.cgi?id=22905
-
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::filenameExtension):
- * platform/image-decoders/ImageDecoder.h:
- * platform/image-decoders/bmp/BMPImageDecoder.h:
- (WebCore::BMPImageDecoder::filenameExtension):
- * platform/image-decoders/gif/GIFImageDecoder.h:
- (WebCore::GIFImageDecoder::filenameExtension):
- * platform/image-decoders/ico/ICOImageDecoder.h:
- (WebCore::ICOImageDecoder::filenameExtension):
- * platform/image-decoders/jpeg/JPEGImageDecoder.h:
- (WebCore::JPEGImageDecoder::filenameExtension):
- * platform/image-decoders/png/PNGImageDecoder.h:
- (WebCore::PNGImageDecoder::filenameExtension):
- * platform/image-decoders/xbm/XBMImageDecoder.h:
- (WebCore::XBMImageDecoder::filenameExtension):
-
-2008-12-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - avoid using the ResourceHandle-level credential storage, if any,
- unless the client opts to use it; when use of the credential
- storage is disallowed, all authentication challenges are sent to
- the client.
- - let the FrameLoaderClient decide whether to use the credential
- storage.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::shouldUseCredentialStorage): Added.
- Returns false.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::shouldUseCredentialStorage): Added. Calls through
- to the FrameLoaderClient.
- * loader/FrameLoader.h: Declared shouldUseCredentialStorage().
- * loader/FrameLoaderClient.h: Declared shouldUseCredentialStorage().
- * loader/ResourceLoader.cpp:
- (WebCore::ResourceLoader::shouldUseCredentialStorage): Added. Calls
- through to the FrameLoader.
- * loader/ResourceLoader.h:
- (WebCore::ResourceLoader::shouldUseCredentialStorage): Implemented this
- ResourceHandleClient method.
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::shouldUseCredentialStorage): Added.
- Overrides the ResourceLoader implementation by letting the client
- supply the return value. If the client does not do this, continues
- with the ResourceLoader behavior of asking the FrameLoader.
- * loader/SubresourceLoader.h: Removed an unused #include and declared
- shouldUseCredentialStorage().
- * loader/SubresourceLoaderClient.h:
- (WebCore::SubresourceLoaderClient::getShouldUseCredentialStorage):
- Added a default implementation which returns false, meaning the client
- does not wish to decide whether the credential storage should be used.
- * platform/network/ResourceHandle.h: Removed unused forward declarations.
- Declared a new member function, shouldUseCredentialStorage(), on Mac and
- CFNetwork-using builds.
- * platform/network/ResourceHandleClient.h:
- (WebCore::ResourceHandleClient::shouldUseCredentialStorage): Added this
- default implementation that returns false.
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::findCFNetworkModule): Added. Returns a handle to the CFNetwork
- module.
- (WebCore::cfNetworkVersion): Added. Returns the high word of the
- CFNetwork library's product version.
- (WebCore::highestSupportedCFURLConnectionClientVersion): Added. Returns
- the highest version of the CFURLConnectionClient structure supported by
- the CFNetwork library. The only reason to check this at runtime is
- that WebKit may be linking at runtime against an older version of
- CFNetwork than the one it was built with, as is the case with nightly
- builds.
- (WebCore::shouldUseCredentialStorageCallback): Added this
- CFURLConnection callback which calls through to
- ResourceHandle::shouldUseCredentialStorage().
- (WebCore::ResourceHandle::start): Pass a version 3 CFURLConnectionClient
- including the shouldUseCredentialStorage callback. At runtime, clamp the
- client structure version down to the highest supported by CFNetwork.
- (WebCore::ResourceHandle::shouldUseCredentialStorage): Added. Calls through
- to the client if there is one. Otherwise returns false.
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::shouldUseCredentialStorage): Ditto.
- (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
- Added this delegate method which callls through to
- ResourceHandle::shouldUseCredentialStorage().
-
-2008-12-18 David Kilzer <ddkilzer@apple.com>
-
- Reset role to "Private" on 6 header files to fix clean builds after r39378
-
- Reviewed by BUILD FIX.
-
- * WebCore.xcodeproj/project.pbxproj: Added back "Private" role
- that was lost on 6 headers when they were "moved":
- AffineTransform.h, Animation.h, AnimationList.h,
- TimingFunction.h, TransformOperation.h and
- TransformOperations.h.
-
-2008-12-18 Pamela Greene <pam@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Add initializer for m_textDirectionSubmenuInclusionBehavior.
- https://bugs.webkit.org/show_bug.cgi?id=22926
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Initialize m_textDirectionSubmenuInclusionBehavior
-
-2008-12-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by John Sullivan.
-
- Add new FrameLoaderClient method to indicate the first visually
- non-empty layout based on an heuristic. Right now that heuristic
- is the first layout after an image, text or plugin has been added
- to the render tree, but I can imagine it becoming much smarter.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::didFirstVisuallyNonEmptyLayout):
- * loader/FrameLoader.h:
- * loader/FrameLoaderClient.h:
- * page/FrameView.cpp:
- (WebCore::FrameViewPrivate::reset):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::performPostLayoutTasks):
- (WebCore::FrameView::setIsVisuallyNonEmpty):
- * page/FrameView.h:
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::RenderImage):
- * rendering/RenderPartObject.cpp:
- (WebCore::RenderPartObject::RenderPartObject):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
-
-2008-12-18 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6449841> reduce memory use of ResourceResponseBase by removing two maps
-
- We were parsing the cache-control and pragma header field values into maps.
- I changed that so instead we only cache two bits with the data we were actually
- using. Later we might want to move this responsibility out of this class entirely;
- we can cache it at the higher level instead.
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::mustRevalidate): Changed to call a specific API to get at
- the bits in quest instead of a general "cache control directives" API.
-
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::setHTTPHeaderField): Remove the logic for the
- pragma header field since no one is using this for now.
- (WebCore::ResourceResponseBase::parseCacheControlDirectives): Eliminated the return
- value and made this function have side effects only. Changed it so it's the caller's
- responsibility to check m_haveParsedCacheControl. Set m_cacheControlContainsNoCache
- and m_cacheControlContainsMustRevalidate rather than keeping a map around.
-
- * platform/network/ResourceResponseBase.h:
- (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Added.
- (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate): Added.
- (WebCore::ResourceResponseBase::ResourceResponseBase): Updated since I removed
- m_haveParsedCacheControl and renamed m_haveParsedCacheControlHeader to remove
- the imprecise use of the term "header".
-
-2008-12-18 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
- Delete 2nd copy of code in these files.
-
- * platform/animation/Animation.cpp:
- * platform/animation/Animation.h:
- * platform/animation/AnimationList.cpp:
- * platform/animation/AnimationList.h:
- * platform/animation/TimingFunction.h:
- * platform/graphics/transforms/AffineTransform.cpp:
- * platform/graphics/transforms/AffineTransform.h:
- * platform/graphics/transforms/IdentityTransformOperation.h:
- * platform/graphics/transforms/MatrixTransformOperation.cpp:
- * platform/graphics/transforms/MatrixTransformOperation.h:
- * platform/graphics/transforms/RotateTransformOperation.cpp:
- * platform/graphics/transforms/RotateTransformOperation.h:
- * platform/graphics/transforms/ScaleTransformOperation.cpp:
- * platform/graphics/transforms/ScaleTransformOperation.h:
- * platform/graphics/transforms/SkewTransformOperation.cpp:
- * platform/graphics/transforms/SkewTransformOperation.h:
- * platform/graphics/transforms/TransformOperation.h:
- * platform/graphics/transforms/TransformOperations.cpp:
- * platform/graphics/transforms/TransformOperations.h:
- * platform/graphics/transforms/TranslateTransformOperation.cpp:
- * platform/graphics/transforms/TranslateTransformOperation.h:
-
-2008-12-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=22859
- Abstract away the use of JSDOMWindow in CachedPage and introduce
- ScriptCachedPageData abstraction.
-
- * GNUmakefile.am: Added ScriptCachedPageData to project.
- * WebCore.pro: Added ScriptCachedPageData to project.
- * WebCore.vcproj/WebCore.vcproj: Added ScriptCachedPageData to project.
- * WebCore.xcodeproj/project.pbxproj: Added ScriptCachedPageData to
- project.
- * bindings/js/ScriptCachedPageData.cpp: Added.
- (WebCore::ScriptCachedPageData::ScriptCachedPageData):
- (WebCore::ScriptCachedPageData::~ScriptCachedPageData):
- (WebCore::ScriptCachedPageData::restore):
- (WebCore::ScriptCachedPageData::clear):
- * bindings/js/ScriptCachedPageData.h: Added.
- * history/CachedPage.cpp: Replaced JSDOMWindow and ProtectedPtr with
- ScriptCachedPageData.
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::domWindow):
- (WebCore::CachedPage::restore):
- (WebCore::CachedPage::clear):
- * history/CachedPage.h: Replaced JSDOMWindow and ProtectedPtr with
- ScriptCachedPageData.
-
-2008-12-18 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22888
-
- To avoid future dependency issues, all the TransformOperations and Animation related files need to be moved to platform
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/animation: Added.
- * platform/animation/Animation.cpp: Copied from WebCore/rendering/style/Animation.cpp.
- * platform/animation/Animation.h: Copied from WebCore/rendering/style/Animation.h.
- * platform/animation/AnimationList.cpp: Copied from WebCore/rendering/style/AnimationList.cpp.
- * platform/animation/AnimationList.h: Copied from WebCore/rendering/style/AnimationList.h.
- * platform/animation/TimingFunction.h: Copied from WebCore/rendering/style/TimingFunction.h.
- * platform/graphics/AffineTransform.cpp: Removed.
- * platform/graphics/AffineTransform.h: Removed.
- * platform/graphics/transforms: Added.
- * platform/graphics/transforms/AffineTransform.cpp: Copied from WebCore/platform/graphics/AffineTransform.cpp.
- * platform/graphics/transforms/AffineTransform.h: Copied from WebCore/platform/graphics/AffineTransform.h.
- * platform/graphics/transforms/IdentityTransformOperation.h: Copied from WebCore/rendering/style/IdentityTransformOperation.h.
- * platform/graphics/transforms/MatrixTransformOperation.cpp: Copied from WebCore/rendering/style/MatrixTransformOperation.cpp.
- * platform/graphics/transforms/MatrixTransformOperation.h: Copied from WebCore/rendering/style/MatrixTransformOperation.h.
- * platform/graphics/transforms/RotateTransformOperation.cpp: Copied from WebCore/rendering/style/RotateTransformOperation.cpp.
- * platform/graphics/transforms/RotateTransformOperation.h: Copied from WebCore/rendering/style/RotateTransformOperation.h.
- * platform/graphics/transforms/ScaleTransformOperation.cpp: Copied from WebCore/rendering/style/ScaleTransformOperation.cpp.
- * platform/graphics/transforms/ScaleTransformOperation.h: Copied from WebCore/rendering/style/ScaleTransformOperation.h.
- * platform/graphics/transforms/SkewTransformOperation.cpp: Copied from WebCore/rendering/style/SkewTransformOperation.cpp.
- * platform/graphics/transforms/SkewTransformOperation.h: Copied from WebCore/rendering/style/SkewTransformOperation.h.
- * platform/graphics/transforms/TransformOperation.h: Copied from WebCore/rendering/style/TransformOperation.h.
- * platform/graphics/transforms/TransformOperations.cpp: Copied from WebCore/rendering/style/TransformOperations.cpp.
- * platform/graphics/transforms/TransformOperations.h: Copied from WebCore/rendering/style/TransformOperations.h.
- * platform/graphics/transforms/TranslateTransformOperation.cpp: Copied from WebCore/rendering/style/TranslateTransformOperation.cpp.
- * platform/graphics/transforms/TranslateTransformOperation.h: Copied from WebCore/rendering/style/TranslateTransformOperation.h.
- * rendering/style/Animation.cpp: Removed.
- * rendering/style/Animation.h: Removed.
- * rendering/style/AnimationList.cpp: Removed.
- * rendering/style/AnimationList.h: Removed.
- * rendering/style/IdentityTransformOperation.h: Removed.
- * rendering/style/MatrixTransformOperation.cpp: Removed.
- * rendering/style/MatrixTransformOperation.h: Removed.
- * rendering/style/RotateTransformOperation.cpp: Removed.
- * rendering/style/RotateTransformOperation.h: Removed.
- * rendering/style/ScaleTransformOperation.cpp: Removed.
- * rendering/style/ScaleTransformOperation.h: Removed.
- * rendering/style/SkewTransformOperation.cpp: Removed.
- * rendering/style/SkewTransformOperation.h: Removed.
- * rendering/style/TimingFunction.h: Removed.
- * rendering/style/TransformOperation.h: Removed.
- * rendering/style/TransformOperations.cpp: Removed.
- * rendering/style/TransformOperations.h: Removed.
- * rendering/style/TranslateTransformOperation.cpp: Removed.
- * rendering/style/TranslateTransformOperation.h: Removed.
-
-2008-12-18 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
- <https://bugs.webkit.org/show_bug.cgi?id=21855>
- <rdar://problem/6278244>
-
- If JavaScript is not currently executing, the handleEvent member function
- of JSAbstractEventListener should set the dynamic global object to the
- global object of the context in which the event occurred.
-
- If this is not set, then JavaScriptCore will simply take the global object
- of the context where the event handler function was created, which may be
- a different frame. This will cause the popup blocker to incorrectly block
- windows opened from onclick events inside of an iframe whose handler was
- created in the outer frame, as it will check the outer frame and see that
- it is not processing any events.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
-
-2008-12-17 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=22570
-
- Add the ability to compute clip rects independently from
- caching them on the RenderLayer. When painting reflections, use
- such temporarily computed clipRects, otherwise the layer may cache
- clipRects which are invalid, since they have been computed with
- a rootLayer that is not the one usually used to paint.
-
- Test: fast/reflections/reflection-overflow-hidden.html
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::hitTestLayer):
- (WebCore::RenderLayer::updateClipRects):
- (WebCore::RenderLayer::calculateClipRects):
- (WebCore::RenderLayer::calculateRects):
- * rendering/RenderLayer.h:
- (WebCore::ClipRects::ClipRects):
- (WebCore::ClipRects::reset):
- (WebCore::ClipRects::overflowClipRect):
- (WebCore::ClipRects::setOverflowClipRect):
- (WebCore::ClipRects::fixedClipRect):
- (WebCore::ClipRects::setFixedClipRect):
- (WebCore::ClipRects::posClipRect):
- (WebCore::ClipRects::setPosClipRect):
- (WebCore::ClipRects::setFixed):
- (WebCore::ClipRects::operator==):
- (WebCore::ClipRects::operator=):
- * rendering/RenderReplica.cpp:
- (WebCore::RenderReplica::paint):
-
-2008-12-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=22618
-
- Fix MinGW QtWebKit linking problems and also make the
- QtWebKit build system more robust.
-
- * WebCore.pro:
-
-2008-12-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Maciej Stachowiak.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22866
-
- wml.css is based on an older copy of html4.css. Synchronize them.
- Remove all entries, that are irrelevant for WML.
-
- Fix <do> appearance: should behave like HTMLs <button>.
-
- * css/wml.css:
-
-2008-12-17 Yury Semikhatsky <yurys@google.com>
-
- Reviewed by Timothy Hatcher.
- Landed by Adam Barth.
-
- Added more checks that WebInspector.panels.{resources,scripts} are
- defined where they are accessed from other panels and WebInspector
- (some panels are not yet supported in Chrome).
-
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype.addMessage):
- (WebInspector.Console.prototype.clearMessages):
- (WebInspector.Console.prototype.completions):
- * inspector/front-end/ObjectPropertiesSection.js:
- (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.get searchableViews):
- (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource):
- (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
- (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- * inspector/front-end/SourceView.js:
- (WebInspector.SourceView.prototype._addBreakpoint):
- * inspector/front-end/inspector.js:
- (WebInspector.addResource):
- (WebInspector.removeResource):
- (WebInspector.showResourceForURL):
-
-2008-12-17 Cary Clark < caryclark@google.com>
-
- Reviewed by Darin Adler.
- Landed by Adam Barth.
-
- Add ENABLE_TEXT_CARET to permit the ANDROID platform
- to invalidate and draw the caret in a separate thread.
-
- * page/Frame.cpp:
- (WebCore::Frame::clearCaretRectIfNeeded): Body of
- function does nothing if text caret is disabled.
- (WebCore::Frame::selectionLayoutChanged): Do nothing
- if text caret is disabled and the caret only blinked.
- (WebCore::Frame::caretBlinkTimerFired):
- (WebCore::Frame::paintCaret):
- (WebCore::Frame::paintDragCaret): Body of
- functions does nothing if text caret is disabled.
-
-2008-12-16 Darin Adler <darin@apple.com>
-
- Reviewed and landed by Cameron Zwarich.
-
- Change the style of AtomicString::add() to match Identifier:add().
-
- * platform/text/AtomicString.cpp:
- (WebCore::AtomicString::add):
-
-2008-12-16 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22827
- <rdar://problem/6247724> RenderThemeWin buttons have weird heavy text
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::fillFontDescription): Add version that takes a font size.
- (WebCore::RenderThemeWin::systemFont): Use the default GUI font for control fonts, but specify the size.
- This will match Firefox.
-
-2008-12-16 Stephanie Lewis <slewis@apple.com>
-
- Another build fix.
-
- * platform/text/AtomicString.h:
- (WebCore::AtomicString::AtomicString):
-
-2008-12-16 Stephanie Lewis <slewis@apple.com>
-
- Windows Build Fix.
-
- * platform/text/AtomicString.h:
- (WebCore::AtomicString::AtomicString):
- (WebCore::AtomicString::createCFString):
-
-2008-12-16 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22885
- Fix memory corruption in GIFImageDecoder.cpp with certain GIFs.
-
- * platform/image-decoders/gif/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoder::frameComplete):
-
-2008-12-16 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Geoff Garen.
-
- Change HTTPHeaderMap to use an AtomicString as its key.
- Shaves ~1MB off of the Mozilla Memory Test
- No functionality difference
-
- * WebCore.xcodeproj/project.pbxproj:
- * inspector/InspectorController.cpp:
- (WebCore::addHeaders):
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::parseHeader):
- * platform/network/HTTPHeaderMap.h:
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::httpHeaderField):
- (WebCore::ResourceRequestBase::setHTTPHeaderField):
- (WebCore::ResourceRequestBase::addHTTPHeaderField):
- * platform/network/ResourceRequestBase.h:
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::httpHeaderField):
- (WebCore::ResourceResponseBase::setHTTPHeaderField):
- * platform/network/ResourceResponseBase.h:
- * platform/text/StringHash.h:
- (WebCore::CaseFoldingHash::hash):
- (WebCore::CaseFoldingHash::equal):
- * xml/XMLHttpRequest.cpp:
- (WebCore::isSetCookieHeader):
- (WebCore::XMLHttpRequest::setRequestHeader):
- (WebCore::XMLHttpRequest::setRequestHeaderInternal):
- (WebCore::XMLHttpRequest::getRequestHeader):
- (WebCore::XMLHttpRequest::getResponseHeader):
- * xml/XMLHttpRequest.h:
-
-2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22876
-
- Remove legacy randomNumber() functionality from HTMLFormElement, and use the new wtf/RandomNumber.h.
- Also remove an uneeded QFileInfo include while I'm at it - there is no Qt usage in this file.
-
- * ForwardingHeaders/wtf/RandomNumber.h: Added.
- * html/HTMLFormElement.cpp:
- (WebCore::getUniqueBoundaryString):
-
-2008-12-16 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Qt/Win build fix
-
- * platform/win/SystemTimeWin.cpp:
-
-2008-12-16 Kalle Vahlman <kalle.vahlman@movial.com>
-
- Reviewed by Holger Freyther.
-
- [CURL] memory leak of ResouceHandles
- http://bugs.webkit.org/show_bug.cgi?id=20777
-
- Fix ResourceHandle ref management to be consistent and correct.
- Original patch from Marco Barisione.
-
- * platform/network/curl/ResourceHandleCurl.cpp:
- (WebCore::ResourceHandle::start):
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::removeFromCurl):
- (WebCore::ResourceHandleManager::add):
- (WebCore::ResourceHandleManager::removeScheduledJob):
-
-2008-12-16 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build.
-
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::clear): Adjust to new signature.
-
-2008-12-15 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Cameron Zwarich.
-
- <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
-
-2008-12-15 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22871
- <rdar://problem/6417316> RenderThemeWin buttons are too short/thin
-
- * rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
- Check if the button's style (not the new inner style) has appearance set to determine whether we should set padding on the inner style.
-
-2008-12-15 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Oliver Hunt.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22865
-
- Add complete WML <table> / <tr> / <td> element support.
- Proper handling of all table related attributes, including tests.
-
- Tests: fast/wml/table-element-align-attribute-invalid.wml (variable reference in 'align' attribute, raises error)
- fast/wml/table-element-columns-attribute-invalid-number.wml (columns='0', raises error)
- fast/wml/table-element-columns-attribute-invalid.wml (non-numeric 'columns' attribute value, raises error)
- fast/wml/table-element-columns-attribute-missing.wml (missing 'columns')
- fast/wml/table-element-columns-attribute.wml (test 'columns' attribute and <td> count mismatches)
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::offsetParent):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::addChild):
- * wml/WMLTableElement.cpp: Added.
- (WebCore::WMLTableElement::WMLTableElement):
- (WebCore::WMLTableElement::~WMLTableElement):
- (WebCore::WMLTableElement::mapToEntry):
- (WebCore::WMLTableElement::parseMappedAttribute):
- (WebCore::WMLTableElement::finishParsingChildren):
- * wml/WMLTableElement.h: Added.
- * wml/WMLTagNames.in:
-
-2008-12-15 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/6427048> crash due to infinite recursion after setting window.__proto__ = window
-
- Test: fast/dom/Window/window-custom-prototype.html
-
- Replaced toGlobalObject with the more generally useful unwrappedObject.
-
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::unwrappedObject): Added.
- * bindings/js/JSDOMWindowShell.h: Declared unwrappedObject.
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::unwrappedObject): Ditto.
-
-2008-12-15 Gustavo Noronha Silva <kov@kov.eti.br>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22686
-
- GTK+ build fix.
-
- * GNUmakefile.am:
-
-2008-12-15 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22847
- Geolocation PositionOptions cannot be an arbitrary object.
-
- Allow the PositionOptions to be a vanilla JS object and parse it
- appropriately.
-
- * DerivedSources.make: Remove PositionOptions.
- * GNUmakefile.am: Ditto.
- * WebCore.pro: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * bindings/js/JSGeolocationCustom.cpp:
- (WebCore::createPositionOptions): Added. Extracts the enableHighAccuracy
- and timeout fields from a vanilla JS object in order to create the
- PositionOptions object, checking for exceptions as necessary.
- (WebCore::JSGeolocation::getCurrentPosition): Use createPositionOptions
- instead of toPositionOptions.
- (WebCore::JSGeolocation::watchPosition): Ditto.
- * page/PositionOptions.idl: Removed
-
-2008-12-15 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22108
- Large animated GIFs weren't always animating. The code that deleted
- the entire decoder after each frame of a large image was resulting in
- us forgetting the loop count, breaking animations intermittently.
-
- Instead of throwing the whole decoder away, we're more careful to just
- delete frames we don't care about. This additionally addresses
- problems in the Cairo and Chromium ports with excessive peak memory
- use and CPU use when decoding large animated GIFs because it leads to
- much less redecoding (O(n) instead of O(n^2) CPU, and O(1) instead of
- O(n) memory).
-
- This change has less impact on the CG decoder, which seems to throw
- away frames automatically when their external references are dropped;
- this means the CG decoder didn't suffer from the peak memory usage
- issue before (and still doesn't), but it also still burns excessive
- CPU redecoding earlier frames, that in theory it wouldn't need to
- redecode if it would judiciously save the most recent frames. At
- least this patch plumbs some useful info to the ImageSource so it can
- help guide the CG decoder heuristics in the future.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::frameBytes):
- (WebCore::BitmapImage::destroyDecodedData):
- (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- (WebCore::BitmapImage::destroyMetadataAndNotify):
- (WebCore::BitmapImage::clearFrame):
- (WebCore::BitmapImage::cacheFrame):
- (WebCore::BitmapImage::dataChanged):
- (WebCore::BitmapImage::startAnimation):
- (WebCore::BitmapImage::resetAnimation):
- (WebCore::BitmapImage::internalAdvanceAnimation):
- * platform/graphics/BitmapImage.h:
- * platform/graphics/GeneratedImage.h:
- (WebCore::GeneratedImage::destroyDecodedData):
- * platform/graphics/Image.h:
- * platform/graphics/ImageSource.h:
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::~ImageSource):
- (WebCore::ImageSource::clear):
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::~ImageSource):
- (WebCore::ImageSource::clear):
- * platform/graphics/cg/PDFDocumentImage.h:
- (WebCore::PDFDocumentImage::destroyDecodedData):
- * platform/graphics/qt/StillImageQt.h:
- (WebCore::StillImage::destroyDecodedData):
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::RGBA32Buffer::clear):
- (WebCore::ImageDecoder::clearFrameBufferCache):
- * platform/image-decoders/gif/GIFImageDecoder.cpp:
- (WebCore::GIFImageDecoder::repetitionCount):
- (WebCore::GIFImageDecoder::clearFrameBufferCache):
- (WebCore::GIFImageDecoder::initFrameBuffer):
- * platform/image-decoders/gif/GIFImageDecoder.h:
- * platform/image-decoders/gif/GIFImageReader.h:
- (GIFImageReader::GIFImageReader):
- * svg/graphics/SVGImage.h:
- (WebCore::SVGImage::destroyDecodedData):
-
-2008-12-15 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22562: REGRESSION (r37971): events not firing after going back in back/forward cache
- <https://bugs.webkit.org/show_bug.cgi?id=22562>
- <rdar://problem/6414593>
-
- Restore the Frame's DOMWindow to its previous value when going back in
- the back/forward cache. The fact that it was not getting set before may
- have always caused some subtle bugs with the back/forward cache, but
- after r37971, it causes no events to fire after restoring a page.
-
- Previously, ScriptController::clearScriptObjects() was calling
- clearPlatformScriptObjects(), which was not actually clearing any
- objects, only updating them to reflect some change in state. Since the
- window shell was not updated until after the call to clearScriptObjects(),
- this didn't actually make that much sense.
-
- We rename clearPlatformScriptObjects() to reflect its actual purpose and
- call it after the window shell has been updated rather than before.
-
- Unfortunately, there is no way to test this with a layout test because
- it involves the back/forward cache.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::updatePlatformScriptObjects): Renamed from
- clearPlatformScriptObjects(), because the only nonempty implementation
- doesn't actually clear any objects, it updates them. Also made public.
- (WebCore::ScriptController::clearScriptObjects): Remove the call to
- clearPlatformScriptObjects().
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::updatePlatformScriptObjects):
- * history/CachedPage.cpp:
- (WebCore::CachedPage::domWindow): Added.
- * history/CachedPage.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::cancelAndClear): Added call to updatePlatformScriptObjects().
- (WebCore::FrameLoader::begin): Added call to updatePlatformScriptObjects().
- (WebCore::FrameLoader::open): Added call to updatePlatformScriptObjects().
- * page/Frame.cpp:
- (WebCore::Frame::setDOMWindow): Added.
- (WebCore::Frame::pageDestroyed): Added call to updatePlatformScriptObjects().
- * page/Frame.h:
-
-2008-12-15 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
- https://bugs.webkit.org/show_bug.cgi?id=17998
-
- - Enable conditional revalidation for reloads by default.
- - Add a parameter to FrameLoader::reload() for forcing end-to-end reload.
- - To avoid duplicating state remove m_cachePolicy variables from FrameLoader and DocLoader.
- Instead synthezise the policy on demand.
-
- This speeds up reloads and makes them use way less bandwidth.
-
- * WebCore.base.exp:
- * loader/CachePolicy.h: Rename CachePolicyRefresh to CachePolicyRevalidate.
- (WebCore::):
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::DocLoader):
- (WebCore::DocLoader::checkForReload): Support CachePolicyRevalidate.
- (WebCore::DocLoader::requestResource):
- (WebCore::DocLoader::cachePolicy):
- * loader/DocLoader.h: Get rid of m_cachePolicy member.
- * loader/FrameLoader.cpp:
- (WebCore::ScheduledRedirection::ScheduledRedirection):
- Add parameter to differentiate refresh from other types of redirects.
- m_cachePolicy was used for signaling this before.
- (WebCore::isBackForwardLoadType):
- (WebCore::FrameLoader::FrameLoader):
- (WebCore::FrameLoader::changeLocation):
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::receivedFirstData):
- (WebCore::FrameLoader::write):
- (WebCore::FrameLoader::startIconLoader):
- (WebCore::FrameLoader::restoreDocumentState):
- (WebCore::FrameLoader::scheduleHTTPRedirection):
- (WebCore::FrameLoader::scheduleLocationChange):
- (WebCore::FrameLoader::scheduleRefresh):
- (WebCore::FrameLoader::redirectionTimerFired):
- (WebCore::FrameLoader::canCachePage):
- (WebCore::FrameLoader::loadURL):
- (WebCore::FrameLoader::reload):
- Differentiate between revalidation and reload.
- No need to use setHTTPHeaderField here, addExtraFieldsToRequest will set the headers.
- (WebCore::FrameLoader::transitionToCommitted):
- (WebCore::FrameLoader::cachePolicy): Determine the cache policy based on current load type.
- (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- (WebCore::FrameLoader::addExtraFieldsToRequest): Set Cache-control: no-cache for FrameLoadTypeReloadFromOrigin
- (WebCore::FrameLoader::shouldScrollToAnchor):
- (WebCore::FrameLoader::loadItem):
- (WebCore::FrameLoader::updateHistoryForReload):
- (WebCore::FrameLoader::updateHistoryForCommit):
- (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- * loader/FrameLoader.h:
- * loader/FrameLoaderTypes.h: Add FrameLoadTypeReloadFromOrigin
- (WebCore::):
- * loader/NavigationAction.cpp:
- (WebCore::navigationType): Support FrameLoadTypeReloadFromOrigin
- * loader/loader.cpp:
- (WebCore::Loader::Host::servePendingRequests):
-
-2008-12-15 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- Add null checks to PlatformScreenQt
-
- The other ports do the null checks and JSDOMWindowBase is
- at least one caller that is passing 0.
-
- * platform/qt/PlatformScreenQt.cpp:
- (WebCore::screenDepth):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenIsMonochrome):
- (WebCore::screenRect):
- (WebCore::screenAvailableRect):
-
-2008-12-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- <rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time
-
- * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
- Detach the thread. Without this, one page of its stack was never unmmaped, and fragmentation
- made RegisterFile allocaiton fail after a while.
-
-2008-12-13 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - half of https://bugs.webkit.org/show_bug.cgi?id=17425
- eliminate DeprecatedPtrList
-
- * dom/Document.cpp:
- (WebCore::Document::removeImage): Change to set slots in the vector
- to 0 rather than removing items from a list.
- (WebCore::Document::dispatchImageLoadEventsNow): Rewrite to process
- the list. Since we now use a "set to zero" design, we don't need to
- be careful about where the iterator points while iterating the list,
- instead we just have to skip zeros.
-
- * dom/Document.h: Use Vector instead of DeprecatedPtrList.
-
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchGenericEvent): Use a Vector instead
- of a DeprecatedPtrList for the list of nodes to handle. Also streamlined
- the logic a bit and used goto in a couple key places.
-
- * dom/Node.cpp:
- (WebCore::Node::eventParentNode): Moved this function into this file
- because it's a virtual function so already can't be inlined. Also updated
- to return a ContainerNode, so it needs to be in a place where the
- definition of ContainerNode is visible, not the header file.
-
- * dom/Node.h: Changed return type of eventParentNode to ContainerNode
- and moved its definition into the cpp file.
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::PendingCallbacks::~PendingCallbacks): Added a call to
- deleteAllValues here instead of setAutoDelete in the constructor, since
- we're using Deque instead of DeprecatedPtrList.
- (WebCore::PendingCallbacks::callAndRemoveFirstCallback): Changed the
- code to use an OwnPtr since the deque won't delete the callback object.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use a
- Vector instead of a DeprecatedPtrList.
-
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::eventParentNode): Moved this function into this file
- because it's a virtual function so already can't be inlined. Also updated
- to return a ContainerNode.
-
- * svg/SVGElement.h: Changed setShadowParentNode to take a ContainerNode*,
- made eventParentNode return a ContainerNode*, and made m_shadowParent a
- ContainerNode*.
-
-2008-12-14 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22857
-
- Jumps within a WML deck using <go> task elements fail. Manual reloading
- is necessary to display the page - fix cache-policy in WMLGoElement::executeTask
- to prevent the problem.
-
- Refactor setActiveCardInDocument in two new functions: findNamedCardInDocument
- and determineActiveCard, to fix a side-effect of executing a <go> task:
- when switching cards within a deck the active card was changed before the load
- was fired which resulted in a flash effect on the screen, and doing unnecessary work.
-
- Test: wml/go-task-animation.html
-
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::findNamedCardInDocument):
- (WebCore::WMLCardElement::determineActiveCard):
- * wml/WMLCardElement.h:
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing):
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::executeTask):
- (WebCore::WMLGoElement::prepareGETRequest):
- * wml/WMLGoElement.h:
-
-2008-12-14 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fixes an issue in cairo. A fully transparent color can cause wrong
- drawings on canvas' composite.
-
- https://bugs.webkit.org/show_bug.cgi?id=22846
- [CAIRO] Canvas: transparent color and composite
-
- Test: fast/canvas/canvas-transparency-and-composite.html
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
-
-2008-12-13 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
- https://bugs.webkit.org/show_bug.cgi?id=22665
-
- Remove setCreatedByParser from frame and iframe.
-
- * html/HTMLElementFactory.cpp:
- (WebCore::frameConstructor):
- (WebCore::iframeConstructor):
- (WebCore::objectConstructor):
- * html/HTMLFrameElement.cpp:
- (WebCore::HTMLFrameElement::HTMLFrameElement):
- * html/HTMLFrameElement.h:
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
- * html/HTMLFrameElementBase.h:
- * html/HTMLFrameOwnerElement.cpp:
- (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
- * html/HTMLFrameOwnerElement.h:
- (WebCore::HTMLFrameOwnerElement::createdByParser):
- * html/HTMLIFrameElement.cpp:
- (WebCore::HTMLIFrameElement::HTMLIFrameElement):
- * html/HTMLIFrameElement.h:
- * html/HTMLPlugInElement.cpp:
- (WebCore::HTMLPlugInElement::HTMLPlugInElement):
- * html/HTMLTagNames.in:
-
-2008-12-13 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22843
- Auto-generate JSWorkerContext
-
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/WorkerContext.idl: Added.
- * page/DOMWindow.idl:
- Added ExtendsDOMGlobalObject, a new attribute for behaviors common to DOMWindow and
- WorkerContext.
-
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::initScript):
- Made JSWorkerContext creation look more like JSDOMWindow creation, to work with generated code.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSWorkerContext.cpp: Removed.
- * bindings/js/JSWorkerContext.h: Removed.
- * bindings/js/JSWorkerContextBase.cpp: Copied from WebCore/bindings/js/JSWorkerContext.cpp.
- (WebCore::JSWorkerContextBase::JSWorkerContextBase):
- (WebCore::JSWorkerContextBase::~JSWorkerContextBase):
- (WebCore::JSWorkerContextBase::scriptExecutionContext):
- (WebCore::getJSWorkerContextBaseTable):
- (WebCore::):
- (WebCore::JSWorkerContextBase::put):
- * bindings/js/JSWorkerContextBase.h: Copied from WebCore/bindings/js/JSWorkerContext.h.
- * bindings/js/JSWorkerContextCustom.cpp: Added.
- (WebCore::JSWorkerContext::customGetOwnPropertySlot):
- (WebCore::JSWorkerContext::mark):
- (WebCore::JSWorkerContext::self):
- (WebCore::JSWorkerContext::setSelf):
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- Moved code around. Note that currently, JSWorkerContextBase lookup table is empty, but we'll
- need to add some global objects to it in the future, as it is done in JSDOMWindowBase.
-
- * page/WorkerNavigator.cpp:
- * page/WorkerNavigator.h:
- Added ENABLE(WORKERS) ifdefs.
-
-2008-12-13 Darin Adler <darin@apple.com>
-
- - fix Release build
-
- * dom/Node.cpp:
- (WebCore::Node::rareData): Remove inappropriate inline directive.
-
-2008-12-13 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=18734
- REGRESSION (r31081): Focus problems in Gmail 2/Plain text message text
- <rdar://problem/5892415>
-
- Test: fast/forms/textarea-selection-preservation.html
-
- The regression reported was caused by the fact that the renderer code had
- a bug where it would constantly think the newline at the end of text was
- missing, and so it would replace all the text even though it wasn't changing,
- which would destroy the selection.
-
- When writing the regression test I discovered another problem: The value
- property in HTMLTextAreaElement was intentionally changing the selection
- to the end of the textarea, but doing that even when the value wasn't changing.
-
- This patch fixes both and the test checks both.
-
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::setValue): Exit early if the value is
- not changing.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::text): Add a newline character for each <br>
- element encountered in the control
-
-2008-12-13 Darin Adler <darin@apple.com>
-
- - file deletion part of https://bugs.webkit.org/show_bug.cgi?id=17497
- eliminate DeprecatedValueList
-
- * GNUmakefile.am: Removed references to deleted files.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * platform/DeprecatedPtrQueue.h: Removed.
- * platform/DeprecatedValueList.h: Removed.
- * platform/DeprecatedValueListImpl.cpp: Removed.
- * platform/DeprecatedValueListImpl.h: Removed.
-
-2008-12-13 Darin Adler <darin@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - https://bugs.webkit.org/show_bug.cgi?id=17497
- eliminate DeprecatedValueList
-
- * css/CSSStyleDeclaration.cpp: Removed unneeded include.
-
- * dom/Document.cpp:
- (WebCore::Document::removeAllEventListenersFromAllNodes):
- Set the removed flag on the window event listeners in case we
- are in the middle of dispatching events on this window.
- (WebCore::Document::clear): Ditto.
- (WebCore::Document::handleWindowEvent): Changed to use a vector
- instead of a DeprecatedPtrList.
- (WebCore::Document::windowInlineEventListenerForType): Ditto.
- (WebCore::Document::removeWindowInlineEventListenerForType): Ditto.
- Also added a call to setRemoved, which is needed here just as in
- other functions that remove.
- (WebCore::Document::removeWindowEventListener): Ditto.
- (WebCore::Document::hasWindowEventListener): Ditto.
-
- * dom/Document.h: Changed RegisteredEventListenerList to
- RegisteredEventListeners.
-
- * dom/Element.cpp:
- (WebCore::Element::attach): Use a function to access rare data instead
- of getting directly at the data field.
- (WebCore::Element::focus): Ditto.
- (WebCore::Element::cancelFocusAppearanceUpdate): Ditto.
-
- * dom/ElementRareData.h: Use "using" to make things that are protected
- in NodeRareData be public here.
-
- * dom/EventTarget.h: Removed include of DeprecatedValueList and
- related declearations that weren't needed. Tweaked the definitions
- of the forbidEventDispatch functions too.
-
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::EventTargetNode): Eliminated code that
- was used to initialized m_regdListeners.
- (WebCore::EventTargetNode::~EventTargetNode): Elminated delete of
- m_regdListeners. Changed code to use eventListeners() instead of
- m_regdListeners.
- (WebCore::EventTargetNode::eventListeners): Added.
- (WebCore::EventTargetNode::insertedIntoDocument): Use eventListeners.
- (WebCore::EventTargetNode::removedFromDocument): Ditto.
- (WebCore::EventTargetNode::willMoveToNewOwnerDocument): Ditto.
- (WebCore::EventTargetNode::didMoveToNewOwnerDocument): Ditto.
- (WebCore::EventTargetNode::addEventListener): Ditto.
- (WebCore::EventTargetNode::removeEventListener): Ditto.
- (WebCore::EventTargetNode::removeAllEventListeners): Ditto.
- Also added code to call setRemoved on all the listeners.
- (WebCore::EventTargetNode::handleLocalEvents): Ditto.
- (WebCore::EventTargetNode::dispatchGenericEvent): Fixed indentation.
- (WebCore::EventTargetNode::removeInlineEventListenerForType): Use
- the new event listeners vector. Also added missing call to setRemoved.
- (WebCore::EventTargetNode::inlineEventListenerForType): Ditto.
-
- * dom/EventTargetNode.h: Added a new RegisteredEventListenerVector
- type and replaced the old localEventListeners function with a new
- eventListeners function. Removed m_regdListeners.
-
- * dom/Node.cpp:
- (WebCore::Node::childNodes): Removed unneeded std prefix.
- (WebCore::Node::setFocus): Use function instead of going directly
- at rare data.
- (WebCore::Node::rareDataFocused): Ditto.
- (WebCore::Node::registerDynamicNodeList): Removed unneeded std prefix.
- (WebCore::Node::getElementsByName): Ditto.
- (WebCore::Node::getElementsByClassName): Ditto.
- (WebCore::Node::compareDocumentPosition): Ditto.
-
- * dom/Node.h: Removed unneeded forward declaration of
- RegisteredEventListener. This is now in EventTargetNode.
-
- * dom/NodeRareData.h: Renamed m_focused to m_isFocused and made it
- private. Made m_needsFocusAppearanceUpdateSoonAfterAttach private.
- Added listeners and ensureListeners functions as well as isFocused,
- setFocused, and focus-appearance functions. Made all data members private.
-
- * dom/RegisteredEventListener.cpp: Removed operator ==.
- * dom/RegisteredEventListener.h: Removed operator == and !=.
-
- * svg/SVGElement.cpp:
- (WebCore::hasLoadListener): Rewrote to work with the vector.
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
-
-2008-12-13 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22824
-
- Change ENABLE(FONT_FAST_PATH) to USE(FONT_FAST_PATH). With r39206
- floatWidth always used the complex path causing a regression
- in the pixel tests.
-
- * platform/graphics/Font.cpp:
- (WebCore::Font::floatWidth): Use the fast path again
-
-2008-12-13 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Darin Adler.
-
- Fixes behavior of gradients on empty path in canvas/Cg
-
- https://bugs.webkit.org/show_bug.cgi?id=22844
- [Cg] Canvas fill() draws gradients even without a path
-
- Test: fast/canvas/canvas-gradient-without-path.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::fill):
- (WebCore::CanvasRenderingContext2D::stroke):
-
-2008-12-13 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
-
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::filenameExtension):
-
-2008-12-12 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
-
- Provides implementation of image dragging logic for Windows Cairo
- back-end.
-
- * platform/win/DragImageCGWin.cpp:
- (WebCore::deallocContext): Add a generic CGContextRef destructor.
- * platform/win/DragImageCairoWin.cpp:
- (WebCore::deallocContext): Add a generic cairo_* destructor.
- (WebCore::allocImage): New implementation to allocate a Cairo
- surface of a specified size.
- (WebCore::createCairoContextFromBitmap): New implementation to
- create a Cairo surface from a Windows BITMAP.
- (WebCore::scaleDragImage): Replace stub with implementation to
- actually create a scaled image.
- (WebCore::createDragImageFromImage): Replace stub with implementation
- to actually create an image.
-
-2008-12-12 Dean Jackson <dino@apple.com>
-
- Reviewed by Darin Adler.
-
- Expose WebKitAnimationEvent, WebKitTransitionEvent,
- WebKitCSSTransformValue, WebKitCSSKeyframeRule and
- WebKitCSSKeyframesRule to Window object.
- This required generating constructors for the event
- interfaces.
-
- https://bugs.webkit.org/show_bug.cgi?id=20560
-
- * dom/WebKitAnimationEvent.idl:
- * dom/WebKitTransitionEvent.idl:
- * page/DOMWindow.idl:
-
-2008-12-12 Dave Moore <davemoore@google.com>
-
- Reviewed by Eric Seidel.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22798
-
- In Font::drawTextUsingSVGFont() a variable of type SVGTextRunWalkerDrawTextData
- is created on the stack (called data). One of its fields, charsConsumed, is
- unitialized, leading to random values after calling walk() on the
- SVGTextRunWalker created with it. I now initialize the variable
-
- This bug was revealed in our Purify run. I don't know of any specific incorrect
- behavior caused by it but it would lead to the charsConsumed field having a
- a wrong value.
-
- * svg/SVGFont.cpp:
- (WebCore::Font::drawTextUsingSVGFont):
-
-2008-12-12 Beth Dakin <bdakin@apple.com>
-
- Rubber Stamped by Steve Falkenburg.
-
- Build fix.
-
- * platform/KURL.h:
-
-2008-12-12 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Adler.
-
- Add the ability so that Google-URL can optionally be used in a build
- of WebKit without changing the shared header. The guts of KURL are
- optionally ifdefed out, and the replacement code goes in a different
- header to avoid polluting KURL.h
-
- * platform/KURL.cpp:
- * platform/KURL.h:
- (WebCore::KURL::string):
- (WebCore::KURL::operator const String&):
- (WebCore::KURL::operator JSC::UString):
- (WebCore::KURL::operator NSString*):
- (WebCore::KURL::parsed):
- (WebCore::KURL::utf8String):
- (WebCore::KURL::isNull):
- (WebCore::KURL::isEmpty):
- (WebCore::KURL::isValid):
- (WebCore::KURL::hostStart):
- (WebCore::KURL::hostEnd):
- (WebCore::KURL::pathStart):
- (WebCore::KURL::pathEnd):
- (WebCore::KURL::pathAfterLastSlash):
-
-2008-12-11 Steve Falkenburg <sfalken@apple.com>
-
- Delete the previous timer-queue timer in the main thread, just prior to scheduling a new timer.
- The code previously called DeleteTimerQueueTimer in the timer callback proc.
-
- The new technique simplifies the code, since we now create and delete timers on the
- same thread, and don't access the timer queue or timer handles in the callback.
- This allows us to remove some mutex use, and more importantly, it solves a race
- condition that was occuring between ChangeTimerQueueTimer and DeleteTimerQueueTimer.
-
- Since the timer callback isn't passed the timer handle, we were retrieving that handle
- via a global. If the timer callback code was entered, but then a new timer was immediately
- scheduled (prior to the callback acquiring the mutex and calling DeleteTimerQueueTimer),
- there was a small window where the timer could be re-scheduled via ChangeTimerQueueTimer
- and then immediately deleted once the already running callback acquired the mutex and
- then called DeleteTimerQueueTimer. This resulted in the newly scheduled timer never firing.
-
- Reviewed by Oliver Hunt.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::queueTimerProc): Don't delete the timer in the callback.
- (WebCore::setSharedTimerFireTime): Always delete and create the timer instead of using ChangeTimerQueueTimer.
- (WebCore::stopSharedTimer): Call DeleteTimerQueueTimer directly.
-
-2008-12-12 Kai Brüning <kai@granus.net>
-
- Reviewed and tweaked by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=18205
- DOMNode objects are garbage collected although there are strong references
- <rdar://problem/6441200>
-
- Fixes resurrection bug for wrapper objects by using an NSMapTable with zeroing weak
- memory for the wrapper reference for DOMWrapperCache (DOMInternal.mm),
- JSWrapperCache (WebScriptObject.mm) and wrapperCache (DOMRGBColor.mm).
- BUILDING_ON_TIGER is used to create a Leopard-only NSMapTable or an old-style
- procedural map table for Tiger systems.
-
- No regression tests yet since we don't currently run any tests in GC mode.
-
- * bindings/objc/DOMInternal.h: added WebCore::createWrapperCache for use by all three caches
- * bindings/objc/DOMInternal.mm:
- (WebCore::createWrapperCache): Contains the compile-time check for map table creation
- (WebCore::getDOMWrapper): HashMap -> NSMapTable
- (WebCore::addDOMWrapper): ditto
- (WebCore::removeDOMWrapper): ditto
- * bindings/objc/DOMObject.mm: removed [DOMObject finalize]
- * bindings/objc/DOMRGBColor.mm: removed [DOMRGBColor finalize]
- (WebCore::getWrapperForRGB): CFMutableDictionaryRef -> NSMapTable
- (WebCore::setWrapperForRGB): ditto
- (WebCore::removeWrapperForRGB): ditto
- * bindings/objc/WebScriptObject.mm:
- (WebCore::getJSWrapper): HashMap -> NSMapTable
- (WebCore::addJSWrapper): ditto
- (WebCore::removeJSWrapper): ditto
- (-[WebScriptObject finalize]): removed call of removeJSWrapper()
-
-2008-12-12 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22813
- Remove unused references to JSDOMBinding, CallFrame, and JSLock.
-
- * dom/Node.cpp: Removed CallFrame and JSLock header includes.
- * loader/FrameLoader.cpp: Removed JSDOMBinding header include.
-
-2008-12-12 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- Update the WebKit.qrc and add a script to automatically generate the file.
-
- With the way rcc and qmake work this can not be done at build time
- as the WebKit.qrc must sit inside the directory that contains the files
- and at build time we may not change the content of the source directory.
-
- * inspector/front-end/WebKit.qrc: Updated with new script
-
-2008-12-12 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- REGRESSION: Canvas is broken in high dpi mode
- <rdar://problem/6432739> <https://bugs.webkit.org/show_bug.cgi?id=22823>
-
- Simply made sure that we correctly scale the graphics context to
- account for the difference between logical and buffer resolution.
-
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::createImageBuffer):
- (WebCore::HTMLCanvasElement::baseTransform):
-
-2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Share PluginView::paintMissingPluginIcon() between ports
-
- Also, enable this feature for Qt/X11, Qt/Mac and GTK
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::paintMissingPluginIcon):
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::paint):
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::paint):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::paint):
- * plugins/win/PluginViewWin.cpp:
-
-2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt/Mac] Implement PluginView::updatePluginWidget()
-
- We should update the window and clip rect regardless of whether or
- not the plugin has been loaded, for example to ensure that the
- missing plugin image is placed correctly.
-
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::setNPWindowIfNeeded):
- (WebCore::PluginView::updatePluginWidget):
-
-2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Oliver Hunt.
-
- Make PluginView::updatePluginWidget() non-const
-
- We can do this now since frameRectsChanged() is no longer const. This
- also allows us to get rid of the mutables in the PluginView.
-
- * platform/qt/TemporaryLinkStubs.cpp:
- (PluginView::updatePluginWidget):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/wx/PluginViewWx.cpp:
- (WebCore::PluginView::updatePluginWidget):
-
-2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Implement ImageSource::filenameExtension() for the Qt port
-
- We're using QImageReader::imageFormat().toLower() to check
- that the image format is supported, and if it is we store
- the resulting extension when creating the ImageDecoderQt.
-
- * platform/graphics/qt/ImageDecoderQt.cpp:
- (WebCore::ImageDecoderQt::create):
- (WebCore::ImageDecoderQt::ImageDecoderQt):
- (WebCore::ImageDecoderQt::imageFormat):
- * platform/graphics/qt/ImageDecoderQt.h:
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::setData):
- (WebCore::ImageSource::filenameExtension):
-
-2008-12-11 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Geoff Garen
-
- Account for the size of the response and request headers as well as other overhead
- when calculating the size a resource takes up in the cache. Halts unbounded
- growth in the cache. Reduced stress test memory high water marks by > 50%.
-
- Uses estimates gathered from the stress test to set the overhead size.
- A version of the patch was created that calculated most of the sizes, but it was
- decided that the patch was still at a basic level an estimate. What gains it made
- in accuracy was offset by the complexity involved in creating and updating the
- estimate.
-
- * loader/Cache.cpp:
- (WebCore::Cache::resourceAccessed):
- (WebCore::Cache::TypeStatistic::addResource):
- (WebCore::Cache::dumpLRULists):
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::overheadSize):
- * loader/CachedResource.h:
- (WebCore::CachedResource::size):
-
-2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Holger Freyther.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22814
-
- Add <wml> image element support. Based on HTML/SVGImage{Element/Loader}, with
- the only difference that WML defines a second source attribute 'localsrc', that
- takes precedence over the 'src' attribute. If loading the 'localsrc' attribute
- fails, the user agent should try loading the 'src' attribute. If both fail the
- 'alt' fallback content will be used - just like in HTML.
-
- Fixes: fast/wml/img-localsrc.wml (<img> and 'localsrc' attribute)
- fast/wml/img-src-localsrc-alt.wml ('localsrc'/'src' fallback handling)
- fast/wml/img-src.wml (<img> and 'src' attribute)
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::altDisplayString):
- (WebCore::HitTestResult::absoluteImageURL):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::updateAltText):
- * wml/WMLImageElement.cpp: Added.
- (WebCore::WMLImageElement::WMLImageElement):
- (WebCore::WMLImageElement::~WMLImageElement):
- (WebCore::WMLImageElement::mapToEntry):
- (WebCore::WMLImageElement::parseMappedAttribute):
- (WebCore::WMLImageElement::attach):
- (WebCore::WMLImageElement::createRenderer):
- (WebCore::WMLImageElement::insertedIntoDocument):
- (WebCore::WMLImageElement::isURLAttribute):
- (WebCore::WMLImageElement::imageSourceAttributeName):
- (WebCore::WMLImageElement::altText):
- * wml/WMLImageElement.h: Added.
- (WebCore::WMLImageElement::useFallbackAttribute):
- (WebCore::WMLImageElement::setUseFallbackAttribute):
- * wml/WMLImageLoader.cpp: Added.
- (WebCore::WMLImageLoader::WMLImageLoader):
- (WebCore::WMLImageLoader::~WMLImageLoader):
- (WebCore::WMLImageLoader::dispatchLoadEvent):
- (WebCore::WMLImageLoader::sourceURI):
- (WebCore::WMLImageLoader::notifyFinished):
- * wml/WMLImageLoader.h: Added.
- * wml/WMLTagNames.in:
-
-2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22043
-
- Do not run into the WebCore::DocumentLoader::updateLoading
- ASSERT on Gtk+/CURL when trying to load tests from our LayoutTests.
-
- Do not call setPrimaryLoadComplete when the
- activeDocumentLoader has already been replaced. This can happen
- when a script executed from within FramerLoader::didFinishLoading will
- navigate to another URL.
-
- The assertion is caused by existing tests (e.g.
- fast/history/clicked-link-is-visited.html) reproducing this with
- network backends not equal to curl is tough or maybe not
- even possible.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::setPrimaryLoadComplete):
-
-2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Eric Seidel.
-
- - Remove some dead, commented-out code from WMLAElement.
- - Add missing virtual destructor for <noop>, as suggested by Alexey.
- - Refactor addHTMLAlignment in a static helper function to share with WML.
-
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::addHTMLAlignment):
- (WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
- * html/HTMLElement.h:
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::defaultEventHandler):
- * wml/WMLNoopElement.cpp:
- (WebCore::WMLNoopElement::~WMLNoopElement):
- * wml/WMLNoopElement.h:
-
-2008-12-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Adele Peterson.
-
- <rdar://problem/6302405> Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
- <https://bugs.webkit.org/show_bug.cgi?id=22804>
-
- This issue was caused by css generated content resulting in non-svg flowboxes
- being injected into SVG content. As SVG spec does not describe behaviour in
- this case, and neither Opera nor Firefox displays such generated content, so
- now we make svg text layout and rendering just ignore any such content.
-
- Test: svg/css/crash-css-generated-content.xhtml
-
- * rendering/SVGRootInlineBox.cpp:
- (WebCore::SVGRootInlineBox::buildLayoutInformation):
- (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- (WebCore::SVGRootInlineBox::buildTextChunks):
-
-2008-12-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Bug 21256: REGRESSION (r36906): horizontally repeating image leaves ghosts when vertical scrolling
- <https://bugs.webkit.org/show_bug.cgi?id=21256>
- <rdar://problem/6362978>
-
- The ScrollView refactoring in r36906 caused the ScrollView and the
- platform widget to disagree about whether optimizing scrolling via
- blitting is allowed. The easiest way to fix this is to make ScrollView
- simply ask the platform widget whether this is safe on platforms that
- are affected.
-
- It is not possible to write a layout test for this bug because it
- involves the back/forward cache.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::setCanBlitOnScroll):
- (WebCore::ScrollView::canBlitOnScroll):
- (WebCore::ScrollView::platformSetCanBlitOnScroll):
- (WebCore::ScrollView::platformCanBlitOnScroll):
- * platform/ScrollView.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformSetCanBlitOnScroll):
- (WebCore::ScrollView::platformCanBlitOnScroll):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetCanBlitOnScroll):
- (WebCore::ScrollView::platformCanBlitOnScroll):
-
-2008-12-11 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=22808
-
- Correct build break due to malformed XML in Visual Studio project
- following @r39205 change.
-
- * WebCore.vcproj/WebCore.vcproj: Correct file entry so project loads.
-
-2008-12-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=22738
-
- This gets rid of the per-animation timers which were used when an animation
- started, ended and looped. Their job is now done by the main AnimationController's
- timer. It is now set to fire as needed. For instance, if there is a delay, it will
- fire after the delay time and then every 30ms to run the animation. The start, loop
- and end events are generated as needed during the firing of this timer.
-
- I had to add one more bit of code. When animation timers used to fire the animation events.
- This would always happen from the RunLoop, so any style changes that happened in the
- event handler would get picked up on the next updateRendering() call. But now the start
- event is generated during the styleIsAvailable() call, which is in the middle of the
- updateRendering() cycle. And calling an event handler in the middle of updateRendering()
- is not allowed and causes style changes to get missed. We already have a mechanism in
- AnimationController to defer updateRendering() calls. So I added logic to defer all
- event handling to there. Now, I put any request for event handling into a list and ask
- for a deferred updateRendering() call. When that deferred timer fires, I go through that
- list, send all the events and then call updateRendering().
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::AnimationBase):
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- (WebCore::AnimationBase::willNeedService):
- (WebCore::AnimationBase::goIntoEndingOrLoopingState):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
- (WebCore::AnimationControllerPrivate::addEventToDispatch):
- (WebCore::AnimationControllerPrivate::animationTimerFired):
- (WebCore::AnimationController::addEventToDispatch):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- (WebCore::CompositeAnimationPrivate::willNeedService):
- (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
- (WebCore::CompositeAnimation::willNeedService):
- (WebCore::CompositeAnimation::getAnimationForProperty):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
- (WebCore::ImplicitAnimation::onAnimationEnd):
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- * page/animation/KeyframeAnimation.h:
- (WebCore::KeyframeAnimation::setUnanimatedStyle):
-
-2008-12-11 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build with an empty filenameExtension() implementation.
-
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::filenameExtension):
-
-2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- Fix crash in the cairo implementation of the SVGPaintServer
-
- For SVGFonts the RenderObject can be zero. The existing SVGFont
- test cases is exposing this bug. Qt and other ports have fixed
- this issue by adding null checks as well.
-
- * svg/graphics/cairo/SVGPaintServerCairo.cpp:
- (WebCore::SVGPaintServer::renderPath):
-
-2008-12-11 Holger Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=20953
-
- Make the Qt port follow the Win, Mac, Gtk+ port in regard to Font
- handling. FontQt.cpp from now on is only implementing the complex path. Create
- FontFallbackListQt.cpp and FontPlatformDataQt.cpp to work within
- the framework set by the Font code.
-
- Sharing the Font.cpp implementation allows the Qt port to support
- the CSS font faces and SVG fonts.
-
- Split out the Qt4.3 Font handling into FonQt43.cpp to allow to more
- easily deprecate it.
-
- This commit is removing a lot of #ifdefs from Font.h as the Qt Font
- implementation is now in line with the rest of WebCore.
-
- * WebCore.pro:
- * platform/graphics/Font.h: Remove #ifdefs
- (WebCore::Font::letterSpacing):
- (WebCore::Font::setLetterSpacing):
- (WebCore::Font::isPlatformFont):
- * platform/graphics/FontFallbackList.h:
- * platform/graphics/SimpleFontData.cpp:
- (WebCore::SimpleFontData::SimpleFontData):
- (WebCore::SimpleFontData::platformGlyphInit): There is no GlyphCache
- on Qt, move the initialisation over.
- (WebCore::SimpleFontData::~SimpleFontData):
- * platform/graphics/SimpleFontData.h:
- (WebCore::SimpleFontData::getQtFont):
- * platform/graphics/qt/FontCacheQt.cpp:
- (WebCore::FontCache::getCachedFontPlatformData): Remove unused parameter
- (WebCore::FontCache::releaseFontData): Add to build
- * platform/graphics/qt/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
- (WebCore::FontCustomPlatformData::fontPlatformData):
- (WebCore::createFontCustomPlatformData):
- * platform/graphics/qt/FontCustomPlatformData.h:
- * platform/graphics/qt/FontFallbackListQt.cpp: Added.
- (WebCore::FontFallbackList::FontFallbackList):
- (WebCore::FontFallbackList::invalidate):
- (WebCore::FontFallbackList::releaseFontData):
- (WebCore::FontFallbackList::determinePitch):
- (WebCore::FontFallbackList::fontDataAt):
- (WebCore::FontFallbackList::fontDataForCharacters):
- (WebCore::FontFallbackList::setPlatformFont):
- * platform/graphics/qt/FontPlatformData.h:
- (WebCore::FontPlatformData::font):
- (WebCore::FontPlatformData::size):
- * platform/graphics/qt/FontPlatformDataQt.cpp: Added.
- (WebCore::FontPlatformData::FontPlatformData):
- * platform/graphics/qt/FontQt.cpp:
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- (WebCore::Font::selectionRectForComplexText):
- (WebCore::Font::font):
- * platform/graphics/qt/FontQt43.cpp: Added. Moved Qt4.3 code from FontQt.cpp
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- (WebCore::Font::selectionRectForComplexText):
- * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
- (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- (WebCore::GlyphPageTreeNode::pruneTreeFontData):
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- (WebCore::SimpleFontData::determinePitch):
- (WebCore::SimpleFontData::containsCharacters):
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformGlyphInit):
- (WebCore::SimpleFontData::platformDestroy):
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::adjustButtonStyle): Avoid crashes.
-
-2008-12-11 Holger Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=20953
-
- For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
- implementation. This is one of the reasons why the Qt port is currently not
- using WebCore/platform/graphics/Font.cpp. By allowing to not use
- the simple/fast-path the Qt port will be able to use it.
-
- Introduce USE(FONT_FAST_PATH) and define it for every port but the
- Qt one.
-
- * platform/graphics/Font.cpp:
- (WebCore::Font::drawText):
- (WebCore::Font::floatWidth):
- (WebCore::Font::selectionRectForText):
- (WebCore::Font::offsetForPosition):
- * platform/graphics/Font.h:
-
-2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20953
-
- Split out the font fast path from Fast.cpp into FontFastPath.cpp. This
- will allow the Qt port to share most of WebCore::Font
- implementation but the fast path. Qt does not provide the API to get
- individual Glyphs making the fast path hard to support.
-
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * platform/graphics/Font.cpp:
- * platform/graphics/FontFastPath.cpp: Added.
- (WebCore::Font::glyphDataForCharacter):
-
-2008-12-11 Robert Carr <racarr@svn.gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=22560
-
- Code in PlatformScreenGtk for screenDepth and screenRect can not
- assume that the platformWindow for the widget has a valid "window"
- member. For example in the case of, a new browser view opening as a
- child of a GtkNotebook, but never being switched to, or manually
- realized. Solve by using the toplevel window of the widget, rather
- than the widget itself.
-
- * platform/gtk/PlatformScreenGtk.cpp:
- (WebCore::screenDepth):
- (WebCore::screenRect):
-
-2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Darin Adler and Holger Freyther.
-
- Make Widget::frameRectsChanged() and overrides non-const
-
- This will hopefully allow us to get rid of some of the mutables in
- the classes that react to the callback by changing their own state.
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::frameRectsChanged):
- * platform/ScrollView.h:
- * platform/Widget.h:
- (WebCore::Widget::frameRectsChanged):
- * platform/gtk/ScrollbarGtk.cpp: Remove non-const version since
- this was more complex and did the same thing, changed const of
- the leftover frameRectsChanged() method.
- (ScrollbarGtk::frameRectsChanged):
- * platform/gtk/ScrollbarGtk.h:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::frameRectsChanged):
- * plugins/PluginView.h:
-
-2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed and implemented with Tor Arne Vestbø.
-
- Reimplement RenderTheme::caretBlinkInterval for Qt.
-
- The QApplication::cursorFlashTime is in milliseconds and describes
- the whole cycle while WebCore expects half a cycle.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::caretBlinkInterval):
- * platform/qt/RenderThemeQt.h:
-
-2008-12-09 Trenton Schulz <trenton.schulz@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- [Qt/Mac] Don't call HIGetScaleFactor() if we're not on Tiger or better
-
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::tigerOrBetter):
- (WebCore::PluginView::globalMousePosForPlugin):
-
-2008-12-10 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Eric Seidel and George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22799
-
- Add WML <template> support. The <template> element is specified at deck-level
- and declares a template for all <card> elements in the document.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * editing/htmlediting.cpp:
- (WebCore::canHaveChildrenForEditing): Treat <do> just like a <button>.
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::setTemplateElement):
- (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- (WebCore::WMLCardElement::handleDeckLevelTaskOverridesIfNeeded):
- * wml/WMLCardElement.h:
- (WebCore::WMLCardElement::templateElement):
- * wml/WMLDoElement.cpp:
- (WebCore::WMLDoElement::insertedIntoDocument):
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing):
- * wml/WMLErrorHandling.cpp:
- (WebCore::errorMessageForErrorCode):
- * wml/WMLErrorHandling.h:
- (WebCore::):
- * wml/WMLEventHandlingElement.cpp:
- (WebCore::WMLEventHandlingElement::~WMLEventHandlingElement):
- * wml/WMLEventHandlingElement.h:
- (WebCore::WMLEventHandlingElement::doElements):
- * wml/WMLTagNames.in:
- * wml/WMLTemplateElement.cpp: Added.
- (WebCore::WMLTemplateElement::WMLTemplateElement):
- (WebCore::WMLTemplateElement::~WMLTemplateElement):
- (WebCore::WMLTemplateElement::parseMappedAttribute):
- (WebCore::WMLTemplateElement::registerTemplatesInDocument):
- * wml/WMLTemplateElement.h: Added.
- * wml/WMLTimerElement.cpp:
- (WebCore::WMLTimerElement::timerFired):
-
-2008-12-09 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler.
-
- Fix memory leak - need to call stopActiveDOMObjects
- when cached pages get destroyed.
- https://bugs.webkit.org/show_bug.cgi?id=22753
-
- * dom/Document.cpp:
- (WebCore::Document::detach):
-
-2008-12-10 Alice Liu <alice.liu@apple.com>
-
- Manual test for https://bugs.webkit.org/show_bug.cgi?id=20685
-
- Reviewed by Darin Adler.
-
- * manual-tests/drag-image-to-desktop.html: Added.
-
-2008-12-10 Alice Liu <alice.liu@apple.com>
-
- fixed https://bugs.webkit.org/show_bug.cgi?id=20685
-
- Reviewed by Darin Adler.
-
- Manual test case is manual-tests/drag-image-to-desktop.html
-
- Added new files to projects
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
-
- * page/DragController.cpp:
- (WebCore::DragController::startDrag):
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedImageMIMETypes):
- (WebCore::initializeSupportedImageMIMETypesForEncoding):
-
- These changes add a method to obtain the extension for an image
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::filenameExtension):
- * platform/graphics/BitmapImage.h:
- * platform/graphics/Image.h:
- (WebCore::Image::filenameExtension):
- * platform/graphics/ImageSource.h:
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::filenameExtension):
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::filenameExtension):
-
- These changes added a utility that returns the preferred extension for a UTI
- * platform/graphics/cg/ImageSourceCG.h: Added.
- * platform/graphics/cg/ImageSourceCGMac.mm: Added.
- (WebCore::MIMETypeForImageSourceType):
- (WebCore::preferredExtensionForImageSourceType):
- * platform/graphics/cg/ImageSourceCGWin.cpp: Added.
- (WebCore::MIMETypeForImageSourceType):
- (WebCore::preferredExtensionForImageSourceType):
-
- * platform/mac/MIMETypeRegistryMac.mm:
- moved getMIMETypeForUTI to ImageSourceCGMac.mm
-
- Ask image for its file extension instead of relying on MIME type and file path
- * platform/win/ClipboardWin.cpp:
- (WebCore::createGlobalImageFileDescriptor):
-
- Remove extraneous code from getPreferredExtensionForMIMEType.
- Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
- * platform/win/MIMETypeRegistryWin.cpp:
- (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
-
-2008-12-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto
-
- <rdar://problem/6431224>
-
- When updating the value of a slider, don't mark the parents
- as needing layout, because the size of the slider can never
- change. This fixes full-page repaints in some cases.
-
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::updateFromElement):
-
-2008-12-10 Simon Fraser <simon.fraser@apple.com>
-
- Potential build fix. The forward declaration of FloatPoint should
- be inside the WebCore namespace.
-
- * platform/graphics/FloatPoint3D.h:
-
-2008-12-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22793
-
- Cleanup FloatPoint3D: inline the getters and setters,
- fix a potential divide-by-zero in normalize(), and add
- a FloatPoint constructor.
-
- * platform/graphics/FloatPoint3D.cpp:
- (WebCore::FloatPoint3D::FloatPoint3D):
- (WebCore::FloatPoint3D::normalize):
- * platform/graphics/FloatPoint3D.h:
- (WebCore::FloatPoint3D::x):
- (WebCore::FloatPoint3D::setX):
- (WebCore::FloatPoint3D::y):
- (WebCore::FloatPoint3D::setY):
- (WebCore::FloatPoint3D::z):
- (WebCore::FloatPoint3D::setZ):
-
-2008-12-09 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
- https://bugs.webkit.org/show_bug.cgi?id=22665
-
- - Removed setCreatedByParser from style and link elements.
-
- - Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
-
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizer.h:
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::startElementNs):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseStartElement):
- * html/HTMLElementFactory.cpp:
- (WebCore::linkConstructor):
- (WebCore::styleConstructor):
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::HTMLLinkElement):
- * html/HTMLLinkElement.h:
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::HTMLStyleElement):
- * html/HTMLStyleElement.h:
- * html/HTMLTagNames.in:
- * svg/SVGStyleElement.cpp:
- (WebCore::SVGStyleElement::SVGStyleElement):
- * svg/SVGStyleElement.h:
- * svg/svgtags.in:
-
-2008-12-10 Brady Eidson <beidson@apple.com>
-
- Reviewed by Darin
-
- https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/6388378> -
- Dialog when going back to a page from whence you submitted a form
-
- http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
- http requests, which caused the networking layer to have an incomplete set of headers
- just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
- us believe we'd be resubmitting the form.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by
- the Origin header mechanism as discussed in bug 22194, restore the previous behavior of
- setting all the headers before the networking layer is asked about the cache lookup.
-
-2008-12-10 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Add back ability to end all profiling via console by invoking profileEnd
- with no arguments.
-
- * page/Console.cpp:
- (WebCore::Console::profileEnd): Removed title null-checking and
- subsequent early exit.
-
-2008-12-10 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Darin Adler.
-
- KeyframeAnimation::animate() needs to compute the elapsed animation time
- properly taking into account its paused state.
-
- https://bugs.webkit.org/show_bug.cgi?id=22773
-
- Test: animations/animation-drt-api-multiple-keyframes.html
-
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
-
-2008-12-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- Part of
- https://bugs.webkit.org/show_bug.cgi?id=22570
-
- Rename methods on RenderLayer for clarity:
- clearClipRects -> clearClipRectsIncludingDescendants
- clearClipRect -> clearClipRects
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::destroy):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::removeOnlyThisLayer):
- (WebCore::RenderLayer::insertOnlyThisLayer):
- (WebCore::RenderLayer::clearClipRectsIncludingDescendants):
- (WebCore::RenderLayer::clearClipRects):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy):
-
-2008-12-10 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix after the script call stack/frame additions.
-
- * WebCoreSources.bkl:
-
-2008-12-10 Srinivasa Rao M. Hamse <msrinirao@gmail.com>
-
- Reviewed by Holger Freyther.
-
- F1-F12 key mappings for WebKit Gtk Port
-
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::windowsKeyCodeForKeyEvent):
-
-2008-12-10 Enrico Ros <enrico.ros@m31.com>
-
- Reviewed by Simon Hausmann.
-
- Fix the Qt build when SVG is disabled. A broken dependancy caused
- unnecessary rebuilds even with no changes.
-
- * WebCore.pro: fix a broken build dependancy
-
-2008-12-10 Hironori Bono <hbono@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
- https://bugs.webkit.org/show_bug.cgi?id=21820
-
- <rdar://problem/5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
- <rdar://problem/5702038> Backspace removes Thai Character in wrong sequence
-
- Tests: editing/deleting/delete-ligature-001.html
- editing/deleting/delete-ligature-002.html
- editing/deleting/delete-ligature-003.html
-
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteKeyPressed): Delete only the last character
- of a ligature which consists of multiple Unicode characters when deleting it with
- a backspace key.
-
-2008-12-10 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22177
- Fix the windows build by removing calls to notifyFormStateChanged
- where they didn't appear in the original reviewed patch.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::type):
- (WebCore::HTMLInputElement::attach):
-
-2008-12-09 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Add ScriptController::updateSecurityOrigin to notify the bindings
- that a document's securityOrigin has been updated. This is used by
- V8 to update its security context.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::updateSecurityOrigin):
- * bindings/js/ScriptController.h:
- * dom/Document.cpp:
- (WebCore::Document::setDomain):
-
-2008-12-09 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Fix a few config issues to let the Chromium Windows WebCore build get further.
-
- * WebCore.scons:
-
-2008-12-09 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22177
-
- Add a callback on ChromeClient that the state of form elements on
- the page has changed. This is to allow clients implementing session
- saving to know when the current state is dirty.
-
- * html/HTMLInputElement.cpp:
- (WebCore::notifyFormStateChanged):
- (WebCore::HTMLInputElement::setInputType):
- (WebCore::HTMLInputElement::type):
- (WebCore::HTMLInputElement::attach):
- (WebCore::HTMLInputElement::setValue):
- (WebCore::HTMLInputElement::setValueFromRenderer):
- (WebCore::HTMLInputElement::setFileListFromRenderer):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::setSelectedIndex):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::notifyFormStateChanged):
- (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
- (WebCore::HTMLTextAreaElement::updateValue):
- (WebCore::HTMLTextAreaElement::setValue):
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::formStateDidChange):
- * page/ChromeClient.h:
-
-2008-12-09 Sam Weinig <sam@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=19762
-
- Fix intermittent crash in buildbot. The CSSCursorImageValues and
- SVGCursorElements held onto raw SVGElement pointers without any
- guarantee that the element is still around.
-
- We did not fix the design that resulted in this issue, we just fixed
- the pointer lifetimes.
-
- * css/CSSCursorImageValue.cpp:
- (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers.
- (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer.
- (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element
- is destroyed.
- * css/CSSCursorImageValue.h: Added removeReferencedElement.
-
- * svg/SVGCursorElement.cpp:
- (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers.
- (WebCore::SVGCursorElement::addClient): Set up a back pointer.
- (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
-
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::SVGElement): Initialize back pointers to zero.
- (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value
- to remove the element from their sets.
- * svg/SVGElement.h:
- (WebCore::SVGElement::setCursorElement): Added.
- (WebCore::SVGElement::setCursorImageValue): Added.
-
-2008-12-09 David Hyatt <hyatt@apple.com>
-
- Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
- frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
- yet as you switch from page to page (until they are destroyed and recreated).
-
- Reviewed by Adele
-
- * page/FrameView.cpp:
- (WebCore::FrameView::createScrollbar):
-
-2008-12-09 Ojan Vafai <ojan@chromium.org>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=22689
- Match Firefox button metrics on Windows.
-
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::addChild):
- (WebCore::RenderButton::styleDidChange):
- (WebCore::RenderButton::setupInnerStyle):
- * rendering/RenderButton.h:
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::adjustButtonInnerStyle):
- * rendering/RenderTheme.h:
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::adjustSliderThumbSize):
- (WebCore::RenderThemeWin::adjustButtonInnerStyle):
- * rendering/RenderThemeWin.h:
-
-2008-12-09 Darin Fisher <darin@chromium.org>
-
- Fixes bustages.
-
- https://bugs.webkit.org/show_bug.cgi?id=22631
- Adding missing files from previous commit.
-
- * bindings/js/ScriptCallFrame.cpp: Added.
- (WebCore::ScriptCallFrame::ScriptCallFrame):
- (WebCore::ScriptCallFrame::~ScriptCallFrame):
- (WebCore::ScriptCallFrame::argumentAt):
- * bindings/js/ScriptCallFrame.h: Added.
- (WebCore::ScriptCallFrame::functionName):
- (WebCore::ScriptCallFrame::sourceURL):
- (WebCore::ScriptCallFrame::lineNumber):
- (WebCore::ScriptCallFrame::argumentCount):
- * bindings/js/ScriptCallStack.cpp: Added.
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::~ScriptCallStack):
- (WebCore::ScriptCallStack::at):
- (WebCore::ScriptCallStack::size):
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptCallStack.h: Added.
- (WebCore::ScriptCallStack::state):
-
-2008-12-09 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=22631
- Streamline Console.cpp, abstract out the use of JSC::ExecState and
- JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
- abstractions.
-
- * GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
- * WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
- * WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and
- ScriptCallStack to project
- * WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and
- ScriptCallStack to project
- * bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
- * bindings/js/ScriptCallFrame.cpp: Added.
- (WebCore::ScriptCallFrame::ScriptCallFrame):
- (WebCore::ScriptCallFrame::~ScriptCallFrame):
- (WebCore::ScriptCallFrame::argumentAt):
- * bindings/js/ScriptCallFrame.h: Added.
- (WebCore::ScriptCallFrame::functionName):
- (WebCore::ScriptCallFrame::sourceURL):
- (WebCore::ScriptCallFrame::lineNumber):
- (WebCore::ScriptCallFrame::argumentCount):
- * bindings/js/ScriptCallStack.cpp: Added.
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::~ScriptCallStack):
- (WebCore::ScriptCallStack::at):
- (WebCore::ScriptCallStack::size):
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptCallStack.h: Added.
- (WebCore::ScriptCallStack::ScriptCallStack):
- (WebCore::ScriptCallStack::~ScriptCallStack):
- (WebCore::ScriptCallStack::state):
- (WebCore::ScriptCallStack::at):
- (WebCore::ScriptCallStack::size):
- (WebCore::ScriptCallStack::initialize):
- * bindings/js/ScriptString.h: Added missing PlatformString include.
- (WebCore::ScriptString::ScriptString): Added default constructor.
- (WebCore::ScriptString::operator==): Added equality operator.
- (WebCore::ScriptString::operator!=):
- * bindings/js/ScriptValue.cpp: Added isNull and isUndefined.
- (WebCore::ScriptValue::isNull):
- (WebCore::ScriptValue::isUndefined):
- * bindings/js/ScriptValue.h: Added isNull and isUndefined
- * bindings/scripts/CodeGeneratorJS.pm: Add handling for
- CustomArgumentHandling attribute.
- * inspector/InspectorController.cpp: Refactored to use
- ScriptCallFrame and ScriptCallStack.
- (WebCore::ConsoleMessage::ConsoleMessage):
- (WebCore::InspectorController::addMessageToConsole):
- (WebCore::InspectorController::startGroup):
- (WebCore::InspectorController::addScriptConsoleMessage):
- (WebCore::InspectorController::count):
- (WebCore::InspectorController::startTiming):
- (WebCore::InspectorController::stopTiming):
- * inspector/InspectorController.h: Refactored to use ScriptCallFrame and
- ScriptCallStack.
- * inspector/front-end/Console.js: Modified to use argument value itself
- rather than f.name for stack trace.
- * page/Console.cpp: Refactored to use ScriptCallFrame and
- ScriptCallStack.
- (WebCore::getFirstArgumentAsString):
- (WebCore::Console::addMessage):
- (WebCore::Console::debug):
- (WebCore::Console::error):
- (WebCore::Console::info):
- (WebCore::Console::log):
- (WebCore::Console::dir):
- (WebCore::Console::dirxml):
- (WebCore::Console::trace):
- (WebCore::Console::assertCondition):
- (WebCore::Console::count):
- (WebCore::Console::profile):
- (WebCore::Console::profileEnd):
- (WebCore::Console::time):
- (WebCore::Console::timeEnd):
- (WebCore::Console::group):
- (WebCore::Console::warn):
- * page/Console.h:
- * page/Console.idl: Removed Custom attributes, added
- CustomArgumentHandling attributes, and tweaked argument defs.
-
-2008-12-09 Darin Adler <darin@apple.com>
-
- Try to fix non-Mac builds.
-
- * GNUmakefile.am: Added NavigatorBase.
- * WebCore.pro: Ditto.
- * WebCore.scons: Ditto.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- Unrelated tweak sitting in my tree.
-
- * bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
-
-2008-12-09 Darin Adler <darin@apple.com>
-
- Try to fix Tiger build.
-
- * platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
-
-2008-12-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22719
- Implement Navigator object in Workers
-
- Test: fast/workers/worker-navigator.html
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- Added WorkerNavigator sources.
-
- * bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator):
- Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec,
- but it is not the same interface that is available on Windows).
-
- * dom/Worker.cpp:
- (WebCore::Worker::notifyFinished):
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::WorkerContext):
- (WebCore::WorkerContext::navigator):
- * dom/WorkerContext.h:
- (WebCore::WorkerContext::create):
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::create):
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::workerThread):
- * dom/WorkerThread.h:
- Pass a pre-computed user agent string into worker, because it cannot call a client method
- directly, and pre-computing is easier than sending a synchronous message to the main thread.
-
- * page/Navigator.cpp:
- * page/Navigator.h:
- * page/NavigatorBase.cpp: Added.
- * page/NavigatorBase.h: Added.
- Factor out common (and uncommon, but very similar) functionality into a base class.
-
- * page/WorkerNavigator.cpp: Added.
- * page/WorkerNavigator.h: Added.
- * page/WorkerNavigator.idl: Added.
- Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
-
- * platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier):
- Make networkStateNotifier() static constructor thread safe. The object is created on the
- thread it is first called from, while callbacks are registered on the main thread. Calls to
- onLine() from other threads are safe, because it is just loading a boolean.
-
- * platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- Schedule notifications on main event loop, not the current one.
-
-2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Forgot to update Qt/WML build - add some new files to the build.
-
- * WebCore.pro:
-
-2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22637
-
- Implement the GET method for WMLGoElement, and some test covering it's behaviour.
- Update all build systems supporting WML that haven't been updated since a while.
-
- Add WMLPostField stub implementation, needed for implementing POST method.
-
- Tests: wml/go-task-get-method-external-deck-with-href.html
- wml/go-task-get-method-external-deck.html
- wml/go-task-get-method-same-deck.html
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Document.cpp:
- (WebCore::Document::resetWMLPageState):
- * wml/WMLCardElement.cpp:
- * wml/WMLCardElement.h:
- * wml/WMLEventHandlingElement.cpp:
- (WebCore::WMLCardElement::registerDoElement):
- * wml/WMLEventHandlingElement.h:
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::WMLGoElement):
- (WebCore::WMLGoElement::registerPostfieldElement):
- (WebCore::WMLGoElement::parseMappedAttribute):
- (WebCore::WMLGoElement::executeTask):
- (WebCore::WMLGoElement::parseContentType):
- (WebCore::WMLGoElement::preparePOSTRequest):
- (WebCore::WMLGoElement::prepareGETRequest):
- * wml/WMLGoElement.h:
- * wml/WMLPostfieldElement.cpp: Added.
- (WebCore::WMLPostfieldElement::WMLPostfieldElement):
- (WebCore::WMLPostfieldElement::parseMappedAttribute):
- (WebCore::WMLPostfieldElement::insertedIntoDocument):
- * wml/WMLPostfieldElement.h: Added.
(WebCore::WMLPostfieldElement::name):
(WebCore::WMLPostfieldElement::value):
- * wml/WMLTagNames.in:
-
-2008-12-08 Peter Kasting <pkasting@google.com>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=16814
- Allow ports to disable ActiveX->NPAPI conversion for Media Player.
- Improve handling of miscellaneous ActiveX objects.
-
- * rendering/RenderPartObject.cpp:
- (WebCore::mapClassIdToServiceType):
- (WebCore::shouldUseChildEmbedOfObject):
- (WebCore::RenderPartObject::updateWidget):
-
-2008-12-08 Darin Adler <darin@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=22409
- REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
-
- Tests: editing/execCommand/enabling-and-selection-2.html
- editing/execCommand/enabling-and-selection.html
-
- * editing/EditorCommand.cpp: Updated table to use these functions by their new names.
- (WebCore::enabledVisibleSelection): Renamed this to reflect its new algorithm.
- An invisible selection with a position that selects no characters doesn't count
- as a visible selection.
- (WebCore::enabledVisibleSelectionAndMark): Ditto.
-
-2008-12-08 David Kilzer <ddkilzer@apple.com>
-
- Remove duplicate entries from WebCore project.
-
- Reviewed by Eric Seidel.
-
- Bug 22555: Sort "children" sections in Xcode project files.
- <https://bugs.webkit.org/show_bug.cgi?id=22555>
-
- Recipe for removing duplicates:
- $ ./WebKitTools/Scripts/sort-Xcode-project-file project.pbxproj
- $ uniq < project.pbxproj | diff -u project.pbxproj - | patch -p0 project.pbxproj
-
- * WebCore.xcodeproj/project.pbxproj: Removed duplicates.
-
-2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
- https://bugs.webkit.org/show_bug.cgi?id=22665
-
- Remove setCreatedByParser from the script elements (HTML and SVG).
-
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): Removed
- call to setCreatedByParser for the 2 elements.
-
- * dom/make_names.pl: Modified to call the constructor with
- the createByParser parameter if 'constructorNeedsCreatedByParser'
- is set.
-
- * html/HTMLElementFactory.cpp:
- (WebCore::scriptConstructor):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::HTMLScriptElement):
- * html/HTMLScriptElement.h:
- * html/HTMLTagNames.in: Added constructorNeedsCreatedByParser
- to script.
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::SVGScriptElement):
- * svg/SVGScriptElement.h:
- * svg/svgtags.in: Added constructorNeedsCreatedByParser
- to script.
-
-2008-12-08 David Kilzer <ddkilzer@apple.com>
-
- Bug 22555: Sort "children" sections in Xcode project files
-
- <https://bugs.webkit.org/show_bug.cgi?id=22555>
-
- Reviewed by Eric Seidel.
-
- * WebCore.xcodeproj/project.pbxproj: Sorted.
- * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Sorted.
-
-2008-12-08 Tony Chang <tony@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add a bool to GraphicsContext so that shadows can ignore
- transformations. This is needed by HTML canvas element
- where the spec says shadows are applied w/o transformations.
- https://bugs.webkit.org/show_bug.cgi?id=22580
-
- No functional changes, thus no tests.
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setShadow):
- (WebCore::CanvasRenderingContext2D::applyShadow):
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::createImageBuffer):
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsContextPrivate.h:
- (WebCore::GraphicsContextState::GraphicsContextState):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::setPlatformShadow):
-
-2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 17897: Not Rendering Images Imported from XHTML Document
- <rdar://problem/5827614>
-
- When we were loading document with XMLHttpRequest that contained images, the images
- would not be fetched as they would not be displayed. However if we inserted such
- an image element into a rendered document, we would not fetch the image and thus never
- display it.
-
- Now we check if the image has been loaded when we insert an HTMLImageElement into a
- document.
- To enable this, the image loader has an error flag. To avoid doing several attempts
- when we know that the image is in error, we store the failed URL.
- However Firefox and Opera ignore errors when the 'src' attribute changes and thus
- we also have an updateFromElementIgnoringPreviousError to match the other browser.
-
- Tests: http/tests/misc/image-blocked-src-change.html
- http/tests/misc/image-blocked-src-no-change.html
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html
-
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute): Ditto.
- (WebCore::HTMLImageElement::insertedIntoDocument): Call updateFromElement if we do not have
- an image.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
- * loader/ImageLoader.cpp:
- (WebCore::ImageLoader::setImage): Added an assertion.
- (WebCore::ImageLoader::updateFromElement): Added a check for load error (to avoid displaying
- multiple errors in the console for a single image load).
-
- (WebCore::ImageLoader::updateFromElementIgnoringPreviousError): This method clears previous error
- before calling updateFromElement.
-
- (WebCore::ImageLoader::notifyFinished): Added an assertion.
- * loader/ImageLoader.h:
- * svg/SVGImageElement.cpp:
- (WebCore::SVGImageElement::svgAttributeChanged): Changed to call updateFromElementIgnoringPreviousError.
-
-2008-12-08 David Hyatt <hyatt@apple.com>
-
- Make scrollbar creation virtual on ScrollView so that FrameView can have the capability to create
- custom CSS scrollbars.
-
- Reviewed by Eric Seidel
-
- * page/FrameView.cpp:
- (WebCore::FrameView::createScrollbar):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setHasHorizontalScrollbar):
- (WebCore::ScrollView::setHasVerticalScrollbar):
- (WebCore::ScrollView::createScrollbar):
- * platform/ScrollView.h:
-
-2008-12-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - WebCore part of tracking the global history item for a WebView
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set the page's
- global history item to the current back/forward list item, respecting
- private browsing mode.
- (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto in this
- case.
- (WebCore::FrameLoader::goToItem): Ditto in this case.
- (WebCore::FrameLoader::updateHistoryForStandardLoad): If this load
- creates a new global history item, set the page's global history item
- to it.
- (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
- Ditto.
- * page/Page.cpp:
- (WebCore::Page::setGlobalHistoryItem): Added this setter.
- * page/Page.h: Added a m_globalHistoryItem data member.
- (WebCore::Page::globalHistoryItem): Added this getter.
-
-2008-12-08 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Kilzer.
-
- A few stylistic fixes suggested by Dave Kilzer.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::createIdentifier):
- (WebCore::CSSPrimitiveValue::create):
-
-2008-12-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22737
- Try debug version when locating CFNetwork
-
- * platform/network/cf/ResourceRequestCFNet.cpp:
- (WebCore::findCFNetworkModule):
- (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
- (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
- * platform/network/win/CookieJarCFNetWin.cpp:
- (WebCore::findCFNetworkModule):
- (WebCore::findIsHTTPOnlyFunction):
-
-2008-12-08 Aaron Boodman <aa@chromium.org>
-
- Reviewed by Stephanie Lewis.
-
- https://bugs.webkit.org/show_bug.cgi?id=22301
- Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::finishedParsing):
-
-2008-12-08 Trenton Schulz <trenton.schulz@nokia.com>
-
- Rubber-stamped by Tor Arne Vestbø.
-
- Fix build warning on Mac
-
- * platform/text/mac/StringImplMac.mm:
-
-2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
-
- Fix the Qt build.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData to RegExp
- constructor.
-
-2008-12-08 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Bug 22398: r39059: Crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler
- <rdar://problem/6426245> REGRESSION(r39059): Reproducible crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler (22398)
-
- This regression was caused by r39059 replacing the protector on the active
- animation with a protector on just the composition. It turns out that both
- protectors are necessary.
-
- Test: transitions/transition-duration-cleared-in-transitionend-crash.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::animationTimerCallbackFired):
-
-2008-12-08 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22732
- Remove unused files PausedTimeouts.h,.cpp
- The change that deprecated this code was https://bugs.webkit.org/show_bug.cgi?id=22620
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.scons:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- These are build files which had PausedTimeouts referenced.
-
- * bindings/js/PausedTimeouts.cpp: Removed.
- * bindings/js/PausedTimeouts.h: Removed.
- * bindings/js/ScriptController.cpp: Removed '#include'
- * page/Chrome.cpp: Removed '#include' and unused variable.
-
-2008-12-07 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22594
-
- Fix issues which break reading inline style for -webkit-transition
- and -webkit-transform-origin.
-
- Test: fast/css/transform-inline-style.html
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Add cases
- for CSSPropertyWebkitTransformOrigin and CSSPropertyWebkitTransition
- so that these shorthand properties are returned correctly.
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseAnimationProperty): Create CSSPrimitiveValues
- with the correct CSSValueAll and CSSValueNone identifiers, not the
- RenderStyle-level cAnimateAll, cAnimateNone.
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapAnimationProperty): Special-case CSSValueAll
- and CSSValueNone values to set cAnimateAll and cAnimateNone transition properties.
-
-2008-12-07 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22717
- Make CSS values use less memory
-
- Share CSSPrimitiveValue objects for commonly used values including
- - idents
- - colors
- - small integers
-
- This reduces the amount CSSPrimitiveValue instances by > 80%.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::createIdentifier):
- (WebCore::CSSPrimitiveValue::createColor):
- (WebCore::CSSPrimitiveValue::create):
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::create):
-
-2008-12-07 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22717
- Make CSS values use less memory
-
- Get CSSValues off from the common StyleBase base class. They don't
- need a parent pointer or anything else there and there is no real
- reason to have them in same data structures with other CSSOM objects.
-
- Disabled (instead of refactoring around the lack of common base) the ability
- to have style declaration blocks as CSS variable values. They don't exist in
- the spec so I wasn't sure if they have future or not. It would not be hard to
- get them back. CSS variables are in any case an experimental feature and
- not enabled by default.
-
- * css/CSSInitialValue.h:
- (WebCore::CSSInitialValue::createExplicit):
- (WebCore::CSSInitialValue::createImplicit):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::addVariableDeclarationBlock):
- * css/CSSParser.h:
- * css/CSSValue.h:
- (WebCore::CSSValue::~CSSValue):
- (WebCore::CSSValue::parserValue):
- * css/CSSVariablesDeclaration.cpp:
- (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
- (WebCore::CSSVariablesDeclaration::getVariableValue):
- (WebCore::CSSVariablesDeclaration::removeVariable):
- (WebCore::CSSVariablesDeclaration::addParsedVariable):
- (WebCore::CSSVariablesDeclaration::getParsedVariable):
- (WebCore::CSSVariablesDeclaration::getParsedVariableDeclarationBlock):
- * css/CSSVariablesDeclaration.h:
- (WebCore::CSSVariablesDeclaration::create):
- * css/StyleBase.h:
-
-2008-12-07 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Add gradient and pattern support for strokeRect on canvas/Cg.
-
- Canvas strokeRect() doesn't support gradients
- https://bugs.webkit.org/show_bug.cgi?id=19790
-
- Test: fast/canvas/canvas-strokeRect.html
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::strokeRect):
-
-2008-12-06 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Add support for setTransform() in canvas.
-
- <canvas> lacks transform() and setTransform()
- https://bugs.webkit.org/show_bug.cgi?id=16604
-
- Test: fast/canvas/canvas-setTransform.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::State::State):
- (WebCore::CanvasRenderingContext2D::setStrokeStyle):
- (WebCore::CanvasRenderingContext2D::setFillStyle):
- (WebCore::CanvasRenderingContext2D::scale):
- (WebCore::CanvasRenderingContext2D::rotate):
- (WebCore::CanvasRenderingContext2D::translate):
- (WebCore::CanvasRenderingContext2D::transform):
- (WebCore::CanvasRenderingContext2D::setTransform):
- (WebCore::CanvasRenderingContext2D::beginPath):
- (WebCore::CanvasRenderingContext2D::closePath):
- (WebCore::CanvasRenderingContext2D::moveTo):
- (WebCore::CanvasRenderingContext2D::lineTo):
- (WebCore::CanvasRenderingContext2D::quadraticCurveTo):
- (WebCore::CanvasRenderingContext2D::bezierCurveTo):
- (WebCore::CanvasRenderingContext2D::arcTo):
- (WebCore::CanvasRenderingContext2D::arc):
- (WebCore::CanvasRenderingContext2D::rect):
- (WebCore::CanvasRenderingContext2D::fill):
- (WebCore::CanvasRenderingContext2D::stroke):
- (WebCore::CanvasRenderingContext2D::clip):
- (WebCore::CanvasRenderingContext2D::isPointInPath):
- (WebCore::CanvasRenderingContext2D::clearRect):
- (WebCore::CanvasRenderingContext2D::fillRect):
- (WebCore::CanvasRenderingContext2D::strokeRect):
- (WebCore::CanvasRenderingContext2D::drawImage):
- (WebCore::CanvasRenderingContext2D::drawImageFromRect):
- (WebCore::CanvasRenderingContext2D::willDraw):
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
- * html/CanvasRenderingContext2D.h:
- * html/CanvasRenderingContext2D.idl:
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::baseTransform):
- * html/HTMLCanvasElement.h:
- * platform/graphics/ImageBuffer.h:
- (WebCore::ImageBuffer::baseTransform):
-
-2008-12-06 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- Also copy m_implicit field. Darin wanted this change commited separately.
-
- * css/CSSProperty.h:
- (WebCore::CSSProperty::operator=):
-
-2008-12-06 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22379
- Make CSSOM use less memory
-
- Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
-
- Taught setter functions to use existing slots to avoid memory moves, plus some
- other optimizations.
-
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- (WebCore::CSSMutableStyleDeclaration::operator=):
- (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
- (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
- (WebCore::CSSMutableStyleDeclaration::removeProperty):
- (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
- (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
- (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
- (WebCore::CSSMutableStyleDeclaration::setProperty):
- (WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
- (WebCore::CSSMutableStyleDeclaration::setStringProperty):
- (WebCore::CSSMutableStyleDeclaration::setImageProperty):
- (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
- (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
- (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
- (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
- (WebCore::CSSMutableStyleDeclaration::length):
- (WebCore::CSSMutableStyleDeclaration::item):
- (WebCore::CSSMutableStyleDeclaration::cssText):
- (WebCore::CSSMutableStyleDeclaration::setCssText):
- (WebCore::CSSMutableStyleDeclaration::merge):
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- (WebCore::CSSMutableStyleDeclaration::copy):
- (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
- * css/CSSMutableStyleDeclaration.h:
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator*):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator->):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator==):
- (WebCore::CSSMutableStyleDeclaration::create):
- (WebCore::CSSMutableStyleDeclaration::begin):
- (WebCore::CSSMutableStyleDeclaration::end):
- (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator):
- (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator=):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator++):
- (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
- * css/CSSProperty.h:
- (WTF::):
- * css/CSSStyleDeclaration.cpp:
- (WebCore::CSSStyleDeclaration::diff):
- (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
- (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- (WebCore::CSSStyleSelector::applyDeclarations):
- * dom/EventTarget.h:
- * editing/ApplyStyleCommand.cpp:
- (WebCore::StyleChange::init):
- (WebCore::ApplyStyleCommand::isHTMLStyleNode):
- (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
- (WebCore::ApplyStyleCommand::removeCSSStyle):
- * editing/Editor.cpp:
- (WebCore::Editor::selectionStartHasStyle):
- (WebCore::updateState):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::handleStyleSpans):
- * editing/markup.cpp:
- (WebCore::appendStartMarkup):
-
-2008-12-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto, Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22088
-
- Fix logic related to repainting when transform changes:
- If an object has a layer, and the transform changes, then we need
- to do a repaintIncludingDescendants(), not just a repaint.
-
- Test: fast/repaint/transform-repaint-descendants.html
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
-
-2008-12-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=15739
-
- When painting the selection on a replaced element, paint
- using local coordinates so that the selection is correctly
- painted for transformed elements.
-
- Test: fast/replaced/selection-rect-transform.html
-
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::paint):
-
-2008-12-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=15671
-
- Fix caret rendering to behave correctly with transforms:
- * Rename caretRect() methods to localCaretRect() and
- absoluteCaretBounds() as appropriate
- * Fix localCaretRect() methods to return a rect in the
- appropriate coordinates.
- * Pass tx, ty down through the paintCaret() methods, after fixing them
- up to account for differences between contents coords, and renderer-local
- coords (via RenderBlock::offsetForContents()).
- * Remove m_caretPositionOnLayout from SelectionController, and instead
- call invalidateSelection() from RenderLayer::scrollToOffset(), because
- we can no longer assume simple x/y offsets from scrolling with transforms.
- * Move the logic to compute which RenderObject actually paints the caret into
- SelectionController::caretRenderer(), rather than having it in RenderBlock.
- * SelectionController now computes and caches a local caret rect. For invalidation,
- it computes the absolute bounds of that (possibly transformed) local rect.
- The local rect is computed in the coordinate system of the RenderObject that
- will paint the caret (this may require offsetting from the actual renderer
- at the start of the selection).
- * Fix LayoutState(RenderObject* root) to take transforms into account
- * Make offsetFromContainer() a virtual method on RenderObject, and implement
- the RenderObject version. It's used to map from selection start renderer
- to caret renderer.
-
- Test: fast/transforms/transformed-caret.html
-
- * WebCore.base.exp:
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::mergeParagraphs):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::SelectionController):
- (WebCore::absoluteCaretY):
- (WebCore::SelectionController::modify):
- (WebCore::SelectionController::xPosForVerticalArrowNavigation):
- (WebCore::SelectionController::layout):
- (WebCore::SelectionController::caretRenderer):
- (WebCore::SelectionController::localCaretRect):
- (WebCore::SelectionController::absoluteCaretBounds):
- (WebCore::SelectionController::caretRepaintRect):
- (WebCore::SelectionController::recomputeCaretRect):
- (WebCore::SelectionController::invalidateCaretRect):
- (WebCore::SelectionController::paintCaret):
- (WebCore::SelectionController::caretRendersInsideNode):
- * editing/SelectionController.h:
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::localCaretRect):
- (WebCore::VisiblePosition::absoluteCaretBounds):
- (WebCore::VisiblePosition::xOffsetForVerticalNavigation):
- * editing/VisiblePosition.h:
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::isContentEditable):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
- * page/Frame.cpp:
- (WebCore::Frame::firstRectForRange):
- (WebCore::Frame::selectionLayoutChanged):
- (WebCore::Frame::paintCaret):
- (WebCore::Frame::paintDragCaret):
- (WebCore::Frame::revealSelection):
- (WebCore::Frame::revealCaret):
- * page/Frame.h:
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintCaret):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::positionForCoordinates):
- (WebCore::RenderBlock::offsetForContents):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localCaretRect):
- * rendering/RenderBox.h:
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::localCaretRect):
- * rendering/RenderFlow.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollToOffset):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::localCaretRect):
- * rendering/RenderObject.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::localCaretRect):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::RenderText):
- (WebCore::RenderText::localCaretRect):
- * rendering/RenderText.h:
-
-2008-12-06 David Kilzer <ddkilzer@apple.com>
-
- Bug 22711: Current svn (build 39065) fails to compile
-
- <https://bugs.webkit.org/show_bug.cgi?id=22711>
-
- BUILD FIX for r39065: Forgot parentheses after "document".
-
- Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
- <https://bugs.webkit.org/show_bug.cgi?id=22666>
-
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed
- document to document().
-
-2008-12-06 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22710
- Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
-
- * bindings/js/DOMTimer.cpp:
- (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
-
-2008-12-06 David Kilzer <ddkilzer@apple.com>
-
- Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
-
- <https://bugs.webkit.org/show_bug.cgi?id=22666>
-
- Reviewed by Darin Adler.
-
- When creating a webarchive from WebCore::LegacyWebArchive::create(),
- HashSet<String>, Vector<KURL> and Vector<String> were all used to
- store a list of URLs for resources found in the document. Instead
- use a single ListHashSet<KURL> to store the list and resolve the
- relative URLs as they're added. We use a new inline method called
- WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
- to prevent "null" KURL objects from crashing in the KURL hashing
- function.
-
- * WebCore.base.exp: Changed export of
- WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL>
- argument instead of a Vector<KURL>.
-
- * WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private
- header for use in WebKit.
-
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from
- addSubresourceURLStrings(). Changed to use ListHashSet<KURL>
- instead of HashSet<String>. Cleaned up code.
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
- * css/StyleSheet.h:
- (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
-
- * dom/Node.cpp:
- (WebCore::Node::getSubresourceURLs): Changed to use
- ListHashSet<KURL> instead of Vector<KURL>. Cleaned up code.
- * dom/Node.h:
- (WebCore::Node::getSubresourceURLs): Ditto.
- (WebCore::Node::addSubresourceAttributeURLs): Renamed from
- getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL>
- instead of Vector<String>.
- (WebCore::addSubresourceURL): Added. Safely adds new KURL objects
- to a ListHashSet<KURL> object. A "null" KURL object will cause the
- hash function to crash since it contains a null StringImpl. Used in
- Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in
- the style subsystem.
-
- * dom/ProcessingInstruction.cpp:
- (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
- Renamed from getSubresourceAttributeStrings(). Changed to use
- ListHashSet<KURL> instead of Vector<String>. Use
- WebCore::addSubresourceURL() to add new KURL objects.
- * dom/ProcessingInstruction.h: Ditto.
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLBodyElement.h: Ditto.
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLEmbedElement.h: Ditto.
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLImageElement.h: Ditto.
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLInputElement.h: Ditto.
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLLinkElement.h: Ditto.
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLObjectElement.h: Ditto.
- * html/HTMLParamElement.cpp:
- (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLParamElement.h: Ditto.
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLScriptElement.h: Ditto.
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLStyleElement.h: Ditto.
- * html/HTMLTableCellElement.cpp:
- (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLTableCellElement.h: Ditto.
- * html/HTMLTableElement.cpp:
- (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- * html/HTMLTableElement.h: Ditto.
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Changed from using
- HashSet<String> to ListHashSet<KURL> for tracking unique
- subresources. Changed from using Vector<KURL> to ListHashSet<KURL>
- when calling WebCore::Node::getSubresourceURLs(). Cleaned up code.
-
- * svg/SVGCursorElement.cpp:
- (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed
- from getSubresourceAttributeStrings(). Changed to use
- ListHashSet<KURL> instead of Vector<String>. Use
- WebCore::addSubresourceURL() to add new KURL objects.
- * svg/SVGCursorElement.h: Ditto.
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGFEImageElement.h: Ditto.
- * svg/SVGImageElement.cpp:
- (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGImageElement.h: Ditto.
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
- * svg/SVGScriptElement.h: Ditto.
-
-2008-12-05 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Adler.
-
- Make the page group use the proper link hashing functions rather than
- calling the string hash functions directly. Add Chromium-specfic ifdefs
- in the visited link computation functions to allow integration.
-
- * page/PageGroup.cpp:
- (WebCore::PageGroup::isLinkVisited):
- (WebCore::PageGroup::addVisitedLink):
- * platform/LinkHash.cpp:
- (WebCore::visitedLinkHash):
- * platform/LinkHash.h:
-
-2008-12-05 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
- For iteration and end events, previous fixes to prevent the deletion of
- Animation objects (ref counting and hanging onto a ref during event callbacks)
- was sufficient to prevent dangling pointers. But start events are sent in
- the styleAvailable() call, which iterates over CompositeAnimation objects,
- which are not ref counted. So that object can get destroyed in the event
- handler while still active. So I added refcounting for CompositeAnimations.
-
- Additionally, when am iterating over the CompositingAnimation list, it can
- be deleted, which mutates the list. So I now make one pass over the list
- building a vector of CompositeAnimation objects that need to be called and
- then iterate over that vector to make the actual calls.
-
- Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
- the Animation objects it owns, I now keep a ref to the CompositeAnimation
- in the timer callback for the iteration and end events. That means I no
- longer need to keep a ref to the Animation objects themselves in that timer
- callback, since the CompositeAnimation already has one.
-
- Tests: animations/animation-iteration-event-destroy-renderer.html
- animations/animation-start-event-destroy-renderer.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::animationTimerCallbackFired):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate):
- (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
- (WebCore::AnimationControllerPrivate::clear):
- (WebCore::AnimationControllerPrivate::styleAvailable):
- (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- (WebCore::AnimationControllerPrivate::animationTimerFired):
- (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
- (WebCore::AnimationControllerPrivate::suspendAnimations):
- (WebCore::AnimationControllerPrivate::resumeAnimations):
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- (WebCore::AnimationController::updateAnimations):
- (WebCore::AnimationController::setAnimationStartTime):
- (WebCore::AnimationController::setTransitionStartTime):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::animationController):
- (WebCore::CompositeAnimationPrivate::isWaitingForStyleAvailable):
- (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
- (WebCore::CompositeAnimationPrivate::clearRenderer):
- (WebCore::CompositeAnimation::clearRenderer):
- (WebCore::CompositeAnimation::animationController):
- (WebCore::CompositeAnimation::isWaitingForStyleAvailable):
- * page/animation/CompositeAnimation.h:
- (WebCore::CompositeAnimation::create):
-
-2008-12-05 David Kilzer <ddkilzer@apple.com>
-
- Bug 22609: Provide a build-time choice when generating hash tables for properties of built-in DOM objects
-
- <https://bugs.webkit.org/show_bug.cgi?id=22609>
- <rdar://problem/6331749>
-
- Reviewed by Darin Adler.
-
- Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
-
- Added back the code that generates a "compact" hash (instead of a
- perfect hash) as a build-time option using the
- ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
-
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateImplementation): Compute the number of elements that will
- be stored in each hash table and pass it to GenerateHashTable().
- (GenerateHashTable): Added new second parameter representing the
- number of elements to store in the compact hash table. Added back
- code to compute compact hash tables. Generate both hash table sizes
- and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
-
-2008-12-05 Brett Wilson <brettw@chromium.org>
-
- Fix build bustage from previous patch.
-
- * css/CSSSelector.h:
-
-2008-12-05 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Add a missing include for OwnPtr to make CSSSelector compile without
- precompiled headers.
-
- * css/CSSSelector.h:
-
-2008-12-05 Finnur Thorarinsson <finnur.webkit@gmail.com>
-
- Reviewed by Darin Adler.
-
- Bug 22579: Providing a function to ScrollbarClient.h which allows us to get at the tickmarks
- without relying on high-level WebCore types, as requested by Dave Hyatt.
-
- No functional changes, thus no test cases.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::getTickmarks):
- * page/FrameView.h:
- * platform/ScrollbarClient.h:
-
-2008-12-05 Dean Jackson <dino@apple.com>
-
- Reviewed by David Hyatt.
-
- Make sure Window event listeners also tell the
- Document about the event type, so noisy events
- will be dispatched even if nothing in the document
- is listening.
- https://bugs.webkit.org/show_bug.cgi?id=20572
-
- * dom/Document.cpp:
- (WebCore::Document::addWindowEventListener):
-
-2008-12-05 Adam Roben <aroben@apple.com>
-
- Windows build fix after r39026
-
- * platform/network/cf/ResourceRequestCFNet.cpp:
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- Add some missing .get()s.
-
-2008-12-05 Alexey Proskuryakov <ap@webkit.org>
-
- Tiger build fix.
-
- * platform/network/mac/ResourceRequestMac.mm: Define NSUInteger.
-
-2008-12-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
- in Safari before opening a mail message in Mail
-
- * platform/mac/WebCoreObjCExtras.mm:
- (WebCoreObjCFinalizeOnMainThread):
- Don't call initializeThreading: we now expect the caller to do it, to simplify keeping
- Tiger and post-Tiger behavior in line.
-
- * bindings/objc/DOMRGBColor.mm:
- (+[DOMRGBColor initialize]):
- * bindings/objc/WebScriptObject.mm:
- (+[WebScriptObject initialize]):
- * page/mac/AccessibilityObjectWrapper.mm:
- (+[AccessibilityObjectWrapper initialize]):
- * platform/mac/SharedBufferMac.mm:
- (+[WebCoreSharedBufferData initialize]):
- Call JSC::initializeThreading();
-
-2008-12-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
-
- * platform/network/ResourceRequestBase.cpp:
- (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- * platform/network/ResourceRequestBase.h:
- * platform/network/cf/ResourceRequestCFNet.cpp:
- (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
- (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
- (WebCore::setContentDispositionEncodingFallbackArray):
- (WebCore::copyContentDispositionEncodingFallbackArray):
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- * platform/network/mac/ResourceRequestMac.mm:
- (WebCore::ResourceRequest::doUpdateResourceRequest):
- (WebCore::ResourceRequest::doUpdatePlatformRequest):
- Added a way to specify encoding fallback list for Content-Disposition header.
-
- * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Generate and
- pass a list of encodings to try when decoding Content-Disposition header, as described
- in comments.
-
-2008-12-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22672
- ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout
-
- Test: http/tests/xmlhttprequest/send-on-abort.html
-
- * dom/ScriptExecutionContext.cpp:
- (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
- (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
- (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
- (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
- Add a comment explaining that ActiveDOMObject methods shouldn't execute arbitrary JS.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't dispatch events. This
- reverts a recent change that made the behavior slightly closer to Firefox - but the
- compatibility effect should be very minor if any, and Firefox itself behaves inconsistently.
-
-2008-12-05 Tobias König <tobias.koenig@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Record required package dependencies for the Qt build for a correct
- pkg-config file.
-
- * WebCore.pro:
-
-2008-12-05 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- [Qt/Mac] Blacklist QuickTime plugin until we support the QuickDraw drawing model
-
- * plugins/mac/PluginPackageMac.cpp:
- (WebCore::PluginPackage::fetchInfo):
- (WebCore::PluginPackage::isPluginBlacklisted):
-
-2008-12-05 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22472
-
- Revises charset alias map for TextCodecICU.
- - Uses windows-949 and windows-874 instead of windows-949-2000 and windows-874-2000
- - Replaces 'windows874' in a couple of place with 'windows-874' (for the canonical name)
- - Maps 'dos-874' to 'windows-874'. Currently, it's aliases to 'cp874', which is in turn
- mapped to 'TIS-620'. 'TIS-620' is manually aliased to 'windows-874'. We'd better directly
- alias 'dos-874' to 'windows-874'.
- - Replaces 'EUC-CN' with 'GBK' when it's used as the canonical name.
- Similar to the above case, we're getting rid of indirection that eventually leads to 'GBK' by
- directly going to 'GBK'.
- - Adds 'x-uhc' as an alias for 'windows-949'. It's used in some web pages.
-
- Tests: fast/encoding/char-decoding-mac.html
- fast/encoding/char-decoding.html
-
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::registerExtendedEncodingNames):
-
-2008-12-04 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Add a MIME mapping for the .htm extension to wx and GTK ports.
-
- https://bugs.webkit.org/show_bug.cgi?id=22668
-
- * platform/gtk/MIMETypeRegistryGtk.cpp:
- (WebCore::):
- * platform/wx/MimeTypeRegistryWx.cpp:
- (WebCore::):
-
-2008-12-04 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Implement basic text paste support in wx and add notImplemented stubs
- to catch other methods.
-
- https://bugs.webkit.org/show_bug.cgi?id=22667
-
- * platform/wx/PasteboardWx.cpp:
- (WebCore::Pasteboard::canSmartReplace):
- (WebCore::Pasteboard::plainText):
- (WebCore::Pasteboard::documentFragment):
- (WebCore::Pasteboard::writeImage):
-
-2008-12-04 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix for !USE(WXGC) build config.
-
- * platform/graphics/wx/PathWx.cpp:
- (WebCore::Path::contains):
- (WebCore::Path::addLineTo):
- (WebCore::Path::addQuadCurveTo):
- (WebCore::Path::addBezierCurveTo):
- (WebCore::Path::addArcTo):
- (WebCore::Path::closeSubpath):
- (WebCore::Path::addArc):
- (WebCore::Path::addRect):
- (WebCore::Path::addEllipse):
- (WebCore::Path::transform):
- (WebCore::Path::apply):
- (WebCore::Path::isEmpty):
-
-2008-12-04 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Turn off styled controls until we can implement them properly.
-
- https://bugs.webkit.org/show_bug.cgi?id=22662
-
- * platform/wx/RenderThemeWx.cpp:
- (WebCore::RenderThemeWx::isControlStyled):
-
-2008-12-04 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- wx implementations for Path API.
-
- https://bugs.webkit.org/show_bug.cgi?id=22661
-
- * platform/graphics/wx/PathWx.cpp:
- (WebCore::Path::~Path):
- (WebCore::Path::contains):
- (WebCore::Path::addLineTo):
- (WebCore::Path::addQuadCurveTo):
- (WebCore::Path::addBezierCurveTo):
- (WebCore::Path::addArcTo):
- (WebCore::Path::closeSubpath):
- (WebCore::Path::addArc):
- (WebCore::Path::addRect):
- (WebCore::Path::addEllipse):
- (WebCore::Path::transform):
- (WebCore::Path::isEmpty):
-
-2008-12-04 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 22564: Make HTML elements' constructors take a QualifiedName
- https://bugs.webkit.org/show_bug.cgi?id=22564
-
- Updated the remaining constructors.
-
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::constructImage):
- * dom/Document.cpp:
- (WebCore::Document::getCSSCanvasElement):
- * editing/DeleteButton.cpp:
- (WebCore::DeleteButton::DeleteButton):
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::HTMLAppletElement):
- * html/HTMLAppletElement.h:
- * html/HTMLAreaElement.cpp:
- (WebCore::HTMLAreaElement::HTMLAreaElement):
- * html/HTMLAreaElement.h:
- * html/HTMLBaseFontElement.cpp:
- (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
- * html/HTMLBaseFontElement.h:
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::HTMLCanvasElement):
- * html/HTMLCanvasElement.h:
- * html/HTMLElementFactory.cpp:
- (WebCore::hrConstructor):
- (WebCore::paragraphConstructor):
- (WebCore::basefontConstructor):
- (WebCore::fontConstructor):
- (WebCore::anchorConstructor):
- (WebCore::imageConstructor):
- (WebCore::mapConstructor):
- (WebCore::areaConstructor):
- (WebCore::canvasConstructor):
- (WebCore::appletConstructor):
- (WebCore::embedConstructor):
- (WebCore::objectConstructor):
- (WebCore::paramConstructor):
- (WebCore::scriptConstructor):
- (WebCore::tableConstructor):
- (WebCore::tableCaptionConstructor):
- (WebCore::tableRowConstructor):
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::HTMLEmbedElement):
- * html/HTMLEmbedElement.h:
- * html/HTMLFontElement.cpp:
- (WebCore::HTMLFontElement::HTMLFontElement):
- * html/HTMLFontElement.h:
- * html/HTMLHRElement.cpp:
- (WebCore::HTMLHRElement::HTMLHRElement):
- * html/HTMLHRElement.h:
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::HTMLImageElement):
- * html/HTMLImageElement.h:
- * html/HTMLMapElement.cpp:
- (WebCore::HTMLMapElement::HTMLMapElement):
- * html/HTMLMapElement.h:
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::HTMLObjectElement):
- * html/HTMLObjectElement.h:
- * html/HTMLParagraphElement.cpp:
- (WebCore::HTMLParagraphElement::HTMLParagraphElement):
- * html/HTMLParagraphElement.h:
- * html/HTMLParamElement.cpp:
- (WebCore::HTMLParamElement::HTMLParamElement):
- * html/HTMLParamElement.h:
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError):
- (WebCore::HTMLParser::mapCreateErrorCheck):
- (WebCore::HTMLParser::handleIsindex):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::HTMLScriptElement):
- * html/HTMLScriptElement.h:
- * html/HTMLTableCaptionElement.cpp:
- (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
- * html/HTMLTableCaptionElement.h:
- * html/HTMLTableElement.cpp:
- (WebCore::HTMLTableElement::HTMLTableElement):
- (WebCore::HTMLTableElement::createCaption):
- (WebCore::HTMLTableElement::insertRow):
- * html/HTMLTableElement.h:
- * html/HTMLTableRowElement.cpp:
- (WebCore::HTMLTableRowElement::HTMLTableRowElement):
- * html/HTMLTableRowElement.h:
- * html/HTMLTableSectionElement.cpp:
- (WebCore::HTMLTableSectionElement::insertRow):
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::createContainingTable):
- (WebCore::HTMLViewSourceDocument::addLine):
- * loader/ImageDocument.cpp:
- (WebCore::ImageDocumentElement::ImageDocumentElement):
-
-2008-12-04 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Add file missing from last commit.
-
- * bindings/js/ScriptState.h: Added.
-
-2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Geoff Garen.
-
- Implement ScriptState abstraction (initially, a simple typedef)
- as means of carrying exception information across bindings boundaries
- and in a script engine-independent way.
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::scriptStateFromNode):
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSNodeFilterCondition.h:
- * bindings/js/ScriptState.h: Added.
- * dom/NodeFilter.cpp:
- (WebCore::NodeFilter::acceptNode):
- * dom/NodeFilter.h:
- (WebCore::NodeFilter::acceptNode):
- * dom/NodeFilterCondition.cpp:
- (WebCore::NodeFilterCondition::acceptNode):
- * dom/NodeFilterCondition.h:
- * dom/NodeIterator.cpp:
- (WebCore::NodeIterator::nextNode):
- (WebCore::NodeIterator::previousNode):
- * dom/NodeIterator.h:
- (WebCore::NodeIterator::nextNode):
- (WebCore::NodeIterator::previousNode):
- * dom/Traversal.cpp:
- (WebCore::Traversal::acceptNode):
- * dom/Traversal.h:
- * dom/TreeWalker.cpp:
- (WebCore::TreeWalker::parentNode):
- (WebCore::TreeWalker::firstChild):
- (WebCore::TreeWalker::lastChild):
- (WebCore::TreeWalker::previousSibling):
- (WebCore::TreeWalker::nextSibling):
- (WebCore::TreeWalker::previousNode):
- (WebCore::TreeWalker::nextNode):
- * dom/TreeWalker.h:
- (WebCore::TreeWalker::parentNode):
- (WebCore::TreeWalker::firstChild):
- (WebCore::TreeWalker::lastChild):
- (WebCore::TreeWalker::previousSibling):
- (WebCore::TreeWalker::nextSibling):
- (WebCore::TreeWalker::previousNode):
- (WebCore::TreeWalker::nextNode):
-
-2008-12-04 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fixed pauseTransitionAtTimeOnElementWithId() in DRT asserting when passed invalid property name
- and potential similar issue with pauseAnimationAtTimeOnElementWithId().
-
- https://bugs.webkit.org/show_bug.cgi?id=22641
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
- (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
-
-2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- Remove unused Completion.h include.
-
- * html/CanvasRenderingContext2D.cpp: Removed Completion.h include.
-
-2008-11-13 David Hyatt <hyatt@apple.com>
-
- Fix a bug in ScrollView's refactoring. An isVisible check should have been isSelfVisible.
-
- Reviewed by Darin Adler
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setParentVisible):
-
-2008-12-04 Friedemann Kleint <friedemann.kleint@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix small translation glitch in the Qt file chooser.
-
- * platform/qt/FileChooserQt.cpp:
- (WebCore::FileChooser::basenameForWidth):
-
-2008-12-04 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Blacklist Silverlight plugin on Qt/Mac until supported
-
- Currently the plugin crashes with a corrupted stack trace, possibly
- related to https://bugs.webkit.org/show_bug.cgi?id=20635
-
- * plugins/mac/PluginPackageMac.cpp:
- (WebCore::PluginPackage::fetchInfo):
- (WebCore::PluginPackage::isPluginBlacklisted):
-
-2008-12-03 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix non-Mac build.
-
- * page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
-
-2008-12-03 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove uses of document() in XMLHttpRequest where simple.
- https://bugs.webkit.org/show_bug.cgi?id=22619
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseXML):
- Return NULL in the worker case which is according to spec (and avoids using document()).
-
- (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- (WebCore::XMLHttpRequest::initSend):
- Use scriptExecutionContext() instead of document().
-
-2008-12-03 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Make ScriptExecutionContextTaskWorkerTask::performTask a pure virtual function.
- https://bugs.webkit.org/show_bug.cgi?id=22642
-
- * dom/Document.cpp:
- (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
- (WebCore::ScriptExecutionContextTaskTimer::fired):
- (WebCore::PerformTaskContext::PerformTaskContext):
- (WebCore::performTask):
- (WebCore::Document::postTask):
- * dom/Document.h:
- * dom/ScriptExecutionContext.cpp:
- * dom/ScriptExecutionContext.h:
- * dom/WorkerContext.cpp:
- (WebCore::ScriptExecutionContextTaskWorkerTask::create):
- (WebCore::ScriptExecutionContextTaskWorkerTask::ScriptExecutionContextTaskWorkerTask):
- (WebCore::ScriptExecutionContextTaskWorkerTask::performTask):
- (WebCore::WorkerContext::postTask):
- * dom/WorkerContext.h:
-
-2008-12-03 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Using ActiveDOMObject as base class for DOMTimer.
- https://bugs.webkit.org/show_bug.cgi?id=22620
-
- Using ActiveDOMObject simplifies the code because ActiveDOMObject
- is wired for stop/pause/resume on loading/unloading/caching the page etc
- so the timer-specific code that does the same can be removed.
- In addition, timers can be now paused/resumed 'in place' which
- makes it unnecessary to 'serialize' them into special PausedTimeouts
- instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
- Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
- of timeouts and makes it possible to not roundtrip them via PausedTimeouts
- every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.
-
- Timeouts are now paused with other ActiveDOMObjects:
- - before creating CachedPage in FrameLoader::commitProvisionalLoad()
- - in JavaScriptDebugServer::setJavaScriptPaused
- - during modal UI operations in Chrome::*
- this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()
-
- Timeouts are stopped to prevent future firing from:
- - FrameLoader::clear()
- - FrameLoader::frameDetached()
- this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()
-
- This is also one of the steps to having timers in Workers. See the plan of
- the next steps in the bug above.
-
- * bindings/js/DOMTimer.cpp:
- (WebCore::DOMTimer::DOMTimer):
- (WebCore::DOMTimer::fired):
- (WebCore::DOMTimer::hasPendingActivity):
- (WebCore::DOMTimer::contextDestroyed):
- (WebCore::DOMTimer::stop):
- (WebCore::DOMTimer::suspend):
- (WebCore::DOMTimer::resume):
- (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
-
- * bindings/js/DOMTimer.h:
- * bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper
- (WebCore::markActiveObjectsForContext):
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- (WebCore::JSDOMWindowBase::clear):
- (WebCore::JSDOMWindowBase::installTimeout):
- (WebCore::JSDOMWindowBase::removeTimeout):
- (WebCore::JSDOMWindowBase::timerFired):
- (WebCore::JSDOMWindowBase::disconnectFrame):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptController.h:
-
- * dom/Document.cpp: Document now holds a hash map id->timeout
- (WebCore::Document::addTimeout):
- (WebCore::Document::removeTimeout):
- (WebCore::Document::findTimeout):
- * dom/Document.h:
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- (WebCore::CachedPage::clear):
- * history/CachedPage.h:
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
- (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- * inspector/JavaScriptDebugServer.h:
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::commitProvisionalLoad):
- removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear();
- I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload'
- and then calls into client which can be external code and can cause any active object created in onunload
- to fire. We can stop them all before firing onunload but it does not make a lot of sense.
- I have a test to go with the next patch which verifies that timers set in onunload do not fire.
-
- (WebCore::FrameLoader::open):
- * page/Chrome.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
-
-2008-12-03 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
-
- In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
- end of pasted content so that users don't get stuck with non-standard pargraph
- spacing. This content threw off our handling of interchange newlines. Any interchange
- newline, regardless of it's position in the incoming fragment was considered to be
- "at the start" of the fragment, and would result in us inserting in a newline before
- inserted content. This patch makes the checks for interchange newlines more strict,
- and treats interchange newlines found elsewhere as normal <br>s.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- (WebCore::ReplacementFragment::removeInterchangeNodes):
- * editing/VisiblePosition.cpp:
- (WebCore::VisiblePosition::init):
- (WebCore::VisiblePosition::canonicalPosition):
- * editing/VisiblePosition.h:
-
-2008-12-03 Eric Seidel <eric@webkit.org>
-
- Rubber-stamped by David Hyatt.
-
- Bring the WebCore chromium build a couple steps closer to building.
-
- * WebCore.scons:
-
-2008-12-03 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
-
- * WebCoreSources.bkl:
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22636
-
- Implement WML variable substitution & validation.
- Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.
-
- Tests: wml/variable-reference-invalid-character.html
- wml/variable-reference-valid.html
-
- * wml/WMLVariables.cpp:
- (WebCore::isValidFirstVariableNameCharacter):
- (WebCore::isValidVariableNameCharacter):
- (WebCore::isValidVariableEscapingModeString):
- (WebCore::isValidVariableName):
- (WebCore::containsVariableReference):
- (WebCore::substituteVariableReferences):
- * wml/WMLVariables.h:
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Cameron Zwarich.
-
- Further preparations for WML layout tests.
- - Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
- - Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
- - Add helper method in Document.idl, to reset the WML page state to a well-known default state.
- (will be used in the upcoming LayoutTests/wml testcases)
-
- * dom/Document.cpp:
- (WebCore::Document::resetWMLPageState):
- * dom/Document.h:
- * dom/Document.idl:
- * dom/Text.cpp:
- (WebCore::Text::insertedIntoDocument):
- * dom/Text.h:
- * page/Console.cpp:
- (WebCore::Console::addMessage):
- * wml/WMLPageState.h: Readd heper function
- (WebCore::WMLPageState::hasVariables):
-
-2008-12-03 Antti Koivisto <antti@apple.com>
-
- Reviewed by Sam Weinig.
-
- Don't leak selectors in case selector list parsing failed.
-
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::~CSSParser):
-
-2008-12-03 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=22520
-
- This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
- This patch fixes the testcase.
-
- This is another case of animations getting destroyed in the end animation callback and causing dangling
- pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
- So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
- and skip that call.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
-
-2008-12-03 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22379
- Make CSSOM use less memory
-
- Reduce size of the CSSSelector by one more pointer by using an array
- instead of a linked list to store them.
-
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::CSSParser):
- (WebCore::CSSParser::parseSelector):
- (WebCore::CSSParser::createStyleRule):
- * css/CSSParser.h:
- (WebCore::CSSParser::reusableSelectorVector):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::CSSSelector):
- (WebCore::CSSSelector::~CSSSelector):
- (WebCore::CSSSelector::isLastInSelectorList):
- (WebCore::CSSSelector::setLastInSelectorList):
- * css/CSSStyleRule.cpp:
- (WebCore::CSSStyleRule::CSSStyleRule):
- (WebCore::CSSStyleRule::~CSSStyleRule):
- (WebCore::CSSStyleRule::selectorText):
- * css/CSSStyleRule.h:
- (WebCore::CSSStyleRule::adoptSelectorVector):
- (WebCore::CSSStyleRule::selectorList):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSRuleSet::addRulesFromSheet):
- * dom/Node.cpp:
- (WebCore::forEachSelector):
- (WebCore::selectorNeedsNamespaceResolution):
- (WebCore::Node::querySelector):
- (WebCore::Node::querySelectorAll):
- * dom/SelectorNodeList.cpp:
- (WebCore::createSelectorNodeList):
- * dom/SelectorNodeList.h:
-
-2008-12-03 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22630
- Assertion failure in XMLHttpRequest::contextDestroyed
-
- Test: http/tests/xmlhttprequest/close-window.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::clear):
- (WebCore::FrameLoader::commitProvisionalLoad):
- Move stopping active objects to clear(), so that closing a window is also covered.
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(),
- because internalAbort() deref()'s.
-
-2008-12-03 Dean Jackson <dino@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Implement CSS 3 <angle> turn unit and support it
- in rotations.
- https://bugs.webkit.org/show_bug.cgi?id=22497
-
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::validUnit):
- (WebCore::unitFromString):
- (WebCore::CSSParser::lex):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
- (WebCore::CSSPrimitiveValue::parserValue):
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::createTransformOperations):
- * css/tokenizer.flex:
-
-2008-12-03 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Nikolas Zimmermann.
-
- Make use of the gradient code in GraphicsContext and get rid of most of the
- platform dependent code.
-
- SVG should use the new Gradient support on GraphicsContext
- https://bugs.webkit.org/show_bug.cgi?id=20543
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/FloatSize.h:
- (WebCore::FloatSize::shrunkTo):
- * svg/SVGLinearGradientElement.cpp:
- (WebCore::SVGLinearGradientElement::buildGradient):
- * svg/SVGRadialGradientElement.cpp:
- (WebCore::SVGRadialGradientElement::buildGradient):
- * svg/graphics/SVGPaintServer.h:
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
- (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
- (WebCore::SVGPaintServerGradient::gradient):
- (WebCore::SVGPaintServerGradient::setGradient):
- (WebCore::findTextRootObject):
- (WebCore::createMaskAndSwapContextForTextGradient):
- (WebCore::clipToTextMask):
- (WebCore::SVGPaintServerGradient::setup):
- (WebCore::SVGPaintServerGradient::renderPath):
- (WebCore::SVGPaintServerGradient::teardown):
- * svg/graphics/SVGPaintServerGradient.h:
- (WebCore::SVGPaintServerGradient::setGradientStops):
- (WebCore::SVGPaintServerGradient::gradientStops):
- * svg/graphics/SVGPaintServerLinearGradient.h:
- * svg/graphics/SVGPaintServerRadialGradient.h:
- * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
- * svg/graphics/cg/SVGPaintServerCg.cpp:
- * svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.
-
-2008-12-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix formatting.
-
- * css/CSSSelector.h:
- (WebCore::CSSSelector::createRareData):
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Adam Roben.
-
- As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.
-
- * inspector/front-end/Console.js:
- * page/Console.h:
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Next steps to make LayoutTests work:
- Never access the main frame from WMLRefreshElement/WMLCardElement, but
- the current documents frame (WML layout tests will run in an <iframe>)
-
- Prepare WMLErrorHandling for the case that no tokenizer is available anymore
- -> report errors through Console::addMessage(), so they get logged in the
- expected layout test results.
-
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::setActiveCardInDocument):
- * wml/WMLErrorHandling.cpp:
- (WebCore::reportWMLError):
- (WebCore::errorMessageForErrorCode):
- * wml/WMLErrorHandling.h:
- * wml/WMLRefreshElement.cpp:
- (WebCore::WMLRefreshElement::executeTask):
- * page/Console.cpp: Handle WMLMessageSource.
- (WebCore::printMessageSourceAndLevelPrefix):
- * page/Console.h: Add WMLMessageSource.
- (WebCore::):
-
-2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Allow passing jsNull and jsUndefined to Qt plugins
-
- Currently limited to functions with QString and QVariant arguments,
- and properties of these types. Both jsNull and jsUndefined ends up
- as default-constructed QStrings and QVariants, which means you can
- check for isEmpty() and isValid() in the native plugin code.
-
- Based on patches by Jade Han <jade.han@nokia.com>
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertValueToQVariant):
- (JSC::Bindings::findMethodIndex):
-
-2008-12-03 Trenton Schulz <trenton.schulz@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix the build with Qt for Mac OS X.
-
- * platform/PurgeableBuffer.h: Use the dummy wrappers for now.
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix error handling in WMLSetvarElement. If an invalid variable reference is contained
- in the 'name' attribute of <setvar>, a 'WMLErrorInvalidVariableName' error should be
- reported, instead of 'WMLErrorInvalidVariableReference'.
-
- * wml/WMLElement.cpp:
- (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
- (WebCore::WMLElement::parseValueForbiddingVariableReferences):
- * wml/WMLElement.h:
+ (WebCore::WMLPostfieldElement::encodeData):
+ * wml/WMLPostfieldElement.h:
* wml/WMLSetvarElement.cpp:
(WebCore::WMLSetvarElement::parseMappedAttribute):
- * wml/WMLSetvarElement.h:
(WebCore::WMLSetvarElement::name):
(WebCore::WMLSetvarElement::value):
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Preparations to get WML layout tests going.
- Make WMLPageState an OwnPtr to Page, and let Page create it on demand.
-
- * page/Page.cpp:
- (WebCore::Page::Page):
- (WebCore::Page::wmlPageState):
- * page/Page.h:
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::WMLDocument):
- (WebCore::WMLDocument::finishedParsing):
- (WebCore::wmlPageStateForDocument):
- * wml/WMLPageState.h: Don't inherit from RefCounted anymore.
- (WebCore::WMLPageState::hasVariables): Remove helper function.
-
-2008-12-03 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22627
- fast/workers/worker-terminate.html fails randomly
-
- The problem is that worker termination uses script timeouts, so an InterruptedExecutionError
- is raised, and it sometimes reaches the main thread.
-
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::WorkerExceptionTask::create):
- (WebCore::WorkerExceptionTask::WorkerExceptionTask):
- (WebCore::WorkerExceptionTask::performTask):
- (WebCore::WorkerMessagingProxy::postWorkerException):
- * dom/WorkerMessagingProxy.h:
- Ignore exceptions that happen in terminated workers.
-
-2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove some unncessary includes.
-
- * wml/WMLAccessElement.cpp:
- * wml/WMLDocument.h:
- * wml/WMLRefreshElement.cpp:
-
-2008-12-03 Alexey Proskuryakov <ap@webkit.org>
-
- Rubber-stamped by Cameron Zwarich and Adam Roben.
-
- Fix a typo: m_executionForbidded.
-
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::WorkerScriptController):
- (WebCore::WorkerScriptController::evaluate):
- (WebCore::WorkerScriptController::forbidExecution):
- * bindings/js/WorkerScriptController.h:
-
-2008-12-03 Dean McNamee <deanm@chromium.org>
-
- Bug 22623: Uninitialized memory access in cache parsing code
- <https://bugs.webkit.org/show_bug.cgi?id=22623>
-
- Reviewed by David Kilzer.
-
- Initialize m_haveParsedCacheControlHeader and m_haveParsedPragmaHeader.
-
- * platform/network/ResourceResponseBase.h:
- (WebCore::ResourceResponseBase::ResourceResponseBase):
-
-2008-12-03 Antti Koivisto <antti@apple.com>
-
- Probable build fix.
-
- * WebCoreSources.bkl:
-
-2008-12-03 Antti Koivisto <antti@apple.com>
-
- Forgot to commit these.
-
- * dom/Node.cpp:
- (WebCore::forEachTagSelector):
- (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- (WebCore::Node::querySelector):
- * dom/SelectorNodeList.cpp:
- (WebCore::createSelectorNodeList):
-
-2008-12-03 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein and Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22379
- Make CSSOM use less memory
-
- Reduce size of the CSSSelector by 3/8 by moving rarely used fields to a rare data
- struct. Browsing around with some instrumentation showed that ~0.1% of all selectors
- encountered had rare data.
-
- This also eliminates the CSSNthSelector subclass which will make possible to store
- CSSSelectors in an array instead of a linked list for futher memory savings.
-
- * css/CSSGrammar.y:
- * css/CSSNthSelector.cpp: Removed.
- * css/CSSNthSelector.h: Removed.
- * css/CSSParser.cpp:
- (WebCore::CSSParser::createFloatingSelector):
- * css/CSSParser.h:
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::specificity):
- (WebCore::CSSSelector::operator==):
- (WebCore::CSSSelector::selectorText):
- (WebCore::CSSSelector::setTagHistory):
- (WebCore::CSSSelector::attribute):
- (WebCore::CSSSelector::setAttribute):
- (WebCore::CSSSelector::setArgument):
- (WebCore::CSSSelector::setSimpleSelector):
- (WebCore::CSSSelector::parseNth):
- (WebCore::CSSSelector::matchNth):
- (WebCore::CSSSelector::RareData::parseNth):
- (WebCore::CSSSelector::RareData::matchNth):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::CSSSelector):
- (WebCore::CSSSelector::~CSSSelector):
- (WebCore::CSSSelector::tagHistory):
- (WebCore::CSSSelector::hasAttribute):
- (WebCore::CSSSelector::argument):
- (WebCore::CSSSelector::simpleSelector):
- (WebCore::CSSSelector::RareData::RareData):
- (WebCore::CSSSelector::createRareData):
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
-
-2008-12-03 Jian Li <jianli@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove unneeded included file in WorkerThread.cpp.
- https://bugs.webkit.org/show_bug.cgi?id=22613
-
- * dom/WorkerThread.cpp: No need to include JSWorkerContext.h.
-
-2008-12-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=22543
- Consolidate ActiveDOMObject page cache interaction
-
- Test: http/tests/xmlhttprequest/abort-on-leaving-page.html
-
- * dom/ActiveDOMObject.cpp:
- (WebCore::ActiveDOMObject::canSuspend):
- (WebCore::ActiveDOMObject::suspend):
- (WebCore::ActiveDOMObject::resume):
- * dom/ActiveDOMObject.h:
- * dom/ScriptExecutionContext.cpp:
- (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
- (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
- (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
- * dom/ScriptExecutionContext.h:
- Added methods for suspending and resuming active objects.
-
- * dom/Worker.cpp:
- (WebCore::Worker::canSuspend):
- (WebCore::Worker::stop):
- * dom/Worker.h:
- Workers cannot be suspended yet. This is a change in behavior, as workers used to keep
- running until their owner was destroyed.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading): No longer call stopActiveDOMObjects() here, because
- their activity is not necessarily loading.
- (WebCore::FrameLoader::canCachePage): Can only cache if all active objects can be suspended.
- Previously, stopLoading() cancelled outstanding XMLHttpRequests, which made the page
- uncacheable due to no-null main document error.
- (WebCore::FrameLoader::commitProvisionalLoad): Suspend or stop active objects, depending on
- whether the document will be cached.
- (WebCore::FrameLoader::frameDetached): Stop active objects to let them clean up before their
- context is destroyed.
-
- * xml/XMLHttpRequest.h: added canSuspend().
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::canSuspend): Only XHRs that are not loading can be suspended.
- (WebCore::XMLHttpRequest::stop): Call abort() instead of internalAbort() to dispatch events
- for Firefox compatibility. This is a change in behavior that helps test that requests do
- get aborted.
- (WebCore::XMLHttpRequest::contextDestroyed): The request must have been stopped by now, so
- assert that.
-
-2008-12-02 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 22606: Can <th> serves as the AXTitleUIElement for <td>?
-
- Test: accessibility/th-as-title-ui.html
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::isGroup):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isGroup):
- * page/AccessibilityRenderObject.h:
- * page/AccessibilityTableCell.cpp:
- (WebCore::AccessibilityTableCell::rowIndexRange):
- (WebCore::AccessibilityTableCell::columnIndexRange):
- (WebCore::AccessibilityTableCell::titleUIElement):
- * page/AccessibilityTableCell.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
-
-2008-12-02 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=22472
-
- Override absoluteClippedOverflowRect() in RenderReplaced to return a rect
- that is large enough to encompass the selection, so that the repainting of
- selected replaced elements works correctly.
-
- Test: fast/repaint/selected-replaced.html
-
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::selectionRect):
- (WebCore::RenderReplaced::localSelectionRect):
- (WebCore::RenderReplaced::absoluteClippedOverflowRect):
- * rendering/RenderReplaced.h:
-
-2008-12-02 Gregory Hughes <ghughes@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 22513: ZOOM: text selection does not send correct zoom bounds
-
- When zoomed, text selection must send the zoom bounds in flipped
- screen coordinates.
-
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- * page/mac/WebCoreViewFactory.h:
-
-2008-12-02 Dean Jackson <dino@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove support for 'now' from CSS (was
- erroneously added to transition and animation delay)
- https://bugs.webkit.org/show_bug.cgi?id=22571
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseAnimationDelay):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapAnimationDelay):
- * css/CSSValueKeywords.in:
-
-2008-12-02 Eric Seidel <eric@webkit.org>
-
- Build fix, no review.
-
- Fix the Mac and gtk builds:
- Don't use a float to hold a double.
- Remove a now duplicate symbol.
-
- * page/Frame.cpp:
- (WebCore::Frame::selectionLayoutChanged):
- * platform/gtk/TemporaryLinkStubs.cpp:
-
-2008-12-02 Chris Fleizach <cfleizach@apple.com>
-
- Bug 22596: Some elements don't report AXBlockQuoteLevel
- https://bugs.webkit.org/show_bug.cgi?id=22596
-
- Reviewed by John Sullivan.
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (blockquoteLevel):
- (AXAttributeStringSetBlockquoteLevel):
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
-
-2008-12-02 Dean McNamee <deanm@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Correctly handle a theme returning a non-blinking interval. We should
- not set any timers when the interval is 0 (non-blinking), otherwise we
- repeatedly set and destroy a blinking timer, causing a paint and timer
- storm. This is applicable to GTK and Windows, where a user can set a
- non-blinking caret in their system preferences.
-
- Renamed caretBlinkFrequency to the more accurate caretBlinkInterval.
-
- * page/Frame.cpp:
- (WebCore::Frame::selectionLayoutChanged):
- * platform/Theme.h:
- (WebCore::Theme::caretBlinkInterval):
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::caretBlinkInterval):
- * platform/gtk/RenderThemeGtk.h:
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::caretBlinkInterval):
-
-2008-12-02 David Levin <levin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=22538
-
- startsWith uses find which searches through the whole string if no match is found.
- Using reverseFind with an index of 0 has the benefit of only searching for the match
- at the beginning of the string. This may only be a small benefit in the overall program,
- but it may help in some cases when the string is big.
-
- No observable change in behavior, so no test.
-
- * platform/text/StringImpl.h:
- (WebCore::StringImpl::startsWith):
-
-2008-10-29 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Wrap a JSC-only hack in a USE(JSC) block to fix the v8 build.
- https://bugs.webkit.org/show_bug.cgi?id=21951
-
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::forgetWrapper):
-
-2008-12-02 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- Add an ASSERT to try and catch the root cause of:
- https://bugs.webkit.org/show_bug.cgi?id=22168
- http://code.google.com/p/chromium/issues/detail?id=4122
-
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::emitText):
-
-2008-12-02 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Adam Roben.
-
- Remove some CG-specific code from the Windows Cairo build.
- https://bugs.webkit.org/show_bug.cgi?id=22586
-
- No new test cases since this update should create no user-visible
- changes, and should be fully covered by the existing regression
- tests.
-
- * WebCore.vcproj/WebCore.vcproj: Remove FontDatabase from
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::focusRingColor): Add stub method
- * platform/win/TemporaryLinkStubs.cpp:
- (WebCore::populateFontDatabase): Add stub method.
-
-2008-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- MinGW compilation fix for PluginPackageWin.cpp
-
- https://bugs.webkit.org/show_bug.cgi?id=22585
-
- * plugins/win/PluginPackageWin.cpp:
- (WebCore::PluginPackage::fetchInfo):
-
-2008-12-02 Adam Roben <aroben@apple.com>
-
- Build fix for Windows projects with NOMINMAX defined globally
-
- * platform/win/COMPtr.h: Don't redefine NOMINMAX if it's already
- defined.
-
-2008-12-02 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Tor Arne Vestbø.
-
- Build JavaScriptCore into libQtWebKit.so through a direct build
- instead of a static library. When linking a static library into
- a shared library qmake generates an incorrect .prl file, which
- causes all sorts of different build problems when linking against
- QtWebKit. Fixing this in qmake requires bigger changes that are
- currently not possible, so we need to work around this limitation
- for now. The advantages of the separate build did not outweight the
- build problems it caused.
-
- * WebCore.pro: include JavaScriptCore.pri, re-enable prl support
- and rename the lut generator to domlut to avoid a conflict with
- JavaScriptCore.pri's lut generator.
-
-2008-12-02 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22588
- Move securityOrigin() from Document and WorkerContext into ScriptExecutionContext.
-
- No observable change in behavior, so no test.
-
- * dom/Document.cpp:
- (WebCore::Document::open):
- (WebCore::Document::domain):
- (WebCore::Document::setDomain):
- (WebCore::Document::initSecurityContext):
- (WebCore::Document::setSecurityOrigin):
- * dom/Document.h:
- * dom/ScriptExecutionContext.cpp:
- (WebCore::ScriptExecutionContext::setSecurityOrigin):
- * dom/ScriptExecutionContext.h:
- (WebCore::ScriptExecutionContext::securityOrigin):
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::WorkerContext):
- * dom/WorkerContext.h:
- These changes are for the move of securityOrigin().
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::createRequest):
- (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
- (WebCore::XMLHttpRequest::setRequestHeader):
- (WebCore::XMLHttpRequest::getAllResponseHeaders):
- (WebCore::XMLHttpRequest::getResponseHeader):
- (WebCore::XMLHttpRequest::processSyncLoadResults):
- (WebCore::XMLHttpRequest::willSendRequest):
- (WebCore::XMLHttpRequest::accessControlCheck):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- Change XMLHttpRequest to use ScriptExecutionContext instead of Document to access securityOrigin().
-
-2008-12-02 André Pönitz <apoenitz@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Disable the creation of debug information for the Qt build when done
- inside Qt. With 670 mb it was slowing down gdb start significantly
- for third-party applications that usually don't need it.
-
- * WebCore.pro:
-
-2008-12-01 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=13736 REGRESSION
- (r19811): Using the down arrow in a textarea gets "stuck" at the
- end of a wrapped line
- And corresponding: <rdar://problem/5347931>
-
- The basic problem here is that Position::getInlineBoxAndOffset()
- failed to look beyond a single renderer. This patch looks for a
- better match beyond the first renderer when the affinity is
- downstream and we failed to find a "perfect" match.
- * dom/Position.cpp:
- (WebCore::isNonTextLeafChild):
- (WebCore::searchAheadForBetterMatch):
- (WebCore::Position::getInlineBoxAndOffset):
-
- This is a fix I made based on code inspection. It looks like the
- old code here and skipped over the parent as a possible match.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::nextInPreOrderAfterChildren):
-
-2008-12-01 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Adam Roben.
-
- Add WML related files to Visual Studio projects.
- https://bugs.webkit.org/show_bug.cgi?id=22561
-
- * WebCore.vcproj/WebCore.vcproj:
- 1. Add files from the wml directory to the set of windows files.
- 2. Extend include paths with new wml directory.
- 3. Add new autogenerated WML files to DerivedSources.
- 4. Alphabetize preprocesor includes (holdover from earlier debugging).
-
-2008-12-01 Steve Falkenburg <sfalken@apple.com>
-
- Revise node/selection image fix.
- Moved updateLayout call so selection rect is fetched after the layout.
-
- Reviewed by Adam Roben.
-
- * page/win/FrameCGWin.cpp:
- (WebCore::imageFromRect):
- (WebCore::imageFromSelection):
- (WebCore::Frame::nodeImage):
-
-2008-12-01 Steve Falkenburg <sfalken@apple.com>
-
- Support needed to implement renderedImage for Windows.
- https://bugs.webkit.org/show_bug.cgi?25648
-
- Reviewed by Adam Roben.
-
- * page/Frame.h:
- * page/win/FrameCGWin.cpp:
- (WebCore::imageFromRect):
- (WebCore::imageFromSelection):
- (WebCore::Frame::nodeImage):
- * page/win/FrameCairoWin.cpp:
- (WebCore::imageFromNode):
-
-2008-12-01 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22581
-
- Fix the painting of the caps lock indicator for transformed text inputs,
- by replacing a call to absoluteContentBox() with code that computes the
- painting rect for the input contents.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::paint):
-
-2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Add two new helper functions to WMLElement, parseValueSubstitutingVariableReferences/parseValueForbiddingVariableReferences.
-
- Convert all elements to parse their attribute values using these new helper functions. This simplifies the
- actual attribute parsing code in all WMLElement derived classes, as most WML attribute values either report
- an error if there's a variable reference used in the attribute value, or if it's invalid.
-
- Split the WMLErrorInvalidVariableReference error which covered both 'invalid syntax' / 'wrong location'
- in two seperated error codes: WMLErrorInvalidVariableReference / WMLErrorInvalidVariableReferenceLocation.
-
- * wml/WMLAccessElement.cpp:
- (WebCore::WMLAccessElement::parseMappedAttribute):
- * wml/WMLDoElement.cpp:
- (WebCore::WMLDoElement::defaultEventHandler):
- (WebCore::WMLDoElement::parseMappedAttribute):
- * wml/WMLElement.cpp:
- (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
- (WebCore::WMLElement::parseValueForbiddingVariableReferences):
- * wml/WMLElement.h:
- * wml/WMLErrorHandling.cpp:
- (WebCore::reportWMLError):
- * wml/WMLErrorHandling.h:
- (WebCore::):
- * wml/WMLOnEventElement.cpp:
- (WebCore::WMLOnEventElement::parseMappedAttribute):
- * wml/WMLPrevElement.cpp:
- (WebCore::WMLPrevElement::executeTask):
- * wml/WMLSetvarElement.cpp:
- (WebCore::WMLSetvarElement::parseMappedAttribute):
+ * wml/WMLSetvarElement.h:
* wml/WMLTimerElement.cpp:
(WebCore::WMLTimerElement::parseMappedAttribute):
-
-2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fix switching active cards within a document. No way to test, until <go> support is implemented.
-
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::showCard):
- (WebCore::WMLCardElement::hideCard):
- (WebCore::WMLCardElement::setActiveCardInDocument):
- * wml/WMLCardElement.h:
-
-2008-12-01 David Kilzer <ddkilzer@apple.com>
-
- Fix logic error in LegacyWebArchive::create() from r38884.
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Only continue if the
- subresource is actually added.
-
-2008-12-01 David Kilzer <ddkilzer@apple.com>
-
- Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
-
- <https://bugs.webkit.org/show_bug.cgi?id=22466>
- <rdar://problem/6403593>
-
- Reviewed by Brady Eidson.
-
- Test: http/tests/webarchive/test-preload-resources.html
-
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create): Check the WebCore cache for
- resources if DocumentLoader::subresource() doesn't return them.
- Note that the DocumentLoader::subresource() method returned
- preloaded resources before r35867, but this caused a regression in
- Mail.
-
-2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 22564: Make HTML elements' constructors take a QualifiedName
- https://bugs.webkit.org/show_bug.cgi?id=22564
-
- - Modified the remaining HTML elements' constructors to take a QualifiedName.
-
- - Added an assertion that the QualifiedName given corresponds to the element constructed.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::constructAudio):
- * html/HTMLAudioElement.cpp:
- (WebCore::HTMLAudioElement::HTMLAudioElement):
- * html/HTMLAudioElement.h:
- * html/HTMLBRElement.cpp:
- (WebCore::HTMLBRElement::HTMLBRElement):
- * html/HTMLBRElement.h:
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::setInnerText):
- * html/HTMLElementFactory.cpp:
- (WebCore::brConstructor):
- (WebCore::quoteConstructor):
- (WebCore::marqueeConstructor):
- (WebCore::audioConstructor):
- (WebCore::videoConstructor):
- (WebCore::sourceConstructor):
- * html/HTMLMarqueeElement.cpp:
- (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
- * html/HTMLMarqueeElement.h:
- * html/HTMLQuoteElement.cpp:
- (WebCore::HTMLQuoteElement::HTMLQuoteElement):
- * html/HTMLQuoteElement.h:
- * html/HTMLSourceElement.cpp:
- (WebCore::HTMLSourceElement::HTMLSourceElement):
- * html/HTMLSourceElement.h:
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::HTMLVideoElement):
- * html/HTMLVideoElement.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::updateFromElement):
-
-2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Antti Koivisto.
-
- Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
- https://bugs.webkit.org/show_bug.cgi?id=22441
-
- Add an assertion to the modified HTML elements' constructor
- to check that the QualifiedName parameter is the one that
- matches the Element's.
-
- * html/HTMLBaseElement.cpp:
- (WebCore::HTMLBaseElement::HTMLBaseElement):
- * html/HTMLBlockquoteElement.cpp:
- (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::HTMLBodyElement):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::HTMLButtonElement):
- * html/HTMLDListElement.cpp:
- (WebCore::HTMLDListElement::HTMLDListElement):
- * html/HTMLDirectoryElement.cpp:
- (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
- * html/HTMLDivElement.cpp:
- (WebCore::HTMLDivElement::HTMLDivElement):
- * html/HTMLFieldSetElement.cpp:
- (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::HTMLFormElement):
- * html/HTMLFrameElement.cpp:
- (WebCore::HTMLFrameElement::HTMLFrameElement):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
- * html/HTMLHeadElement.cpp:
- (WebCore::HTMLHeadElement::HTMLHeadElement):
- * html/HTMLHtmlElement.cpp:
- (WebCore::HTMLHtmlElement::HTMLHtmlElement):
- * html/HTMLIFrameElement.cpp:
- (WebCore::HTMLIFrameElement::HTMLIFrameElement):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::HTMLInputElement):
- * html/HTMLIsIndexElement.cpp:
- (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::HTMLKeygenElement):
- * html/HTMLLIElement.cpp:
- (WebCore::HTMLLIElement::HTMLLIElement):
- * html/HTMLLabelElement.cpp:
- (WebCore::HTMLLabelElement::HTMLLabelElement):
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::HTMLLegendElement):
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::HTMLLinkElement):
- * html/HTMLMenuElement.cpp:
- (WebCore::HTMLMenuElement::HTMLMenuElement):
- * html/HTMLMetaElement.cpp:
- (WebCore::HTMLMetaElement::HTMLMetaElement):
- * html/HTMLOListElement.cpp:
- (WebCore::HTMLOListElement::HTMLOListElement):
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::HTMLOptionElement):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::HTMLSelectElement):
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::HTMLStyleElement):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
- * html/HTMLTitleElement.cpp:
- (WebCore::HTMLTitleElement::HTMLTitleElement):
- * html/HTMLUListElement.cpp:
- (WebCore::HTMLUListElement::HTMLUListElement):
-
-2008-12-01 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22046
-
- Fixed another case of crashing because the animation object is getting deleted when
- it's in the middle of a callback. I actually moved where I am retaining the pointer
- up out of the lower level AnimationBase code and into the timer callback that calls
- them. So now the pointer is valid throughout the entire sequence of callback code.
-
- The testcase for https://bugs.webkit.org/show_bug.cgi?id=22052 also exhibits a
- crash which this patch fixes.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::animationTimerCallbackFired):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
- (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
- (WebCore::CompositeAnimationPrivate::styleAvailable):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
-
-2008-12-01 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- [Qt/Mac] Initialize NPAPI plugins before getting their entry points
-
- The old behavior (calling NP_GetEntryPoints before NP_Initialize) was
- copied from Windows, but caused Silverlight on Mac to crash when loaded.
-
- Apparently the call order of NP_Initialize and NP_GetEntryPoints is
- reversed on Mac. See https://bugzilla.mozilla.org/show_bug.cgi?id=344425
-
- Reported-by: Peter Johnson <peter@zattoo.com>
-
- * plugins/mac/PluginPackageMac.cpp:
- (WebCore::PluginPackage::load):
-
-2008-11-30 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by John Sullivan.
-
- https://bugs.webkit.org/show_bug.cgi?id=22510
- Crash at WebCore::AccessibilityRenderObject::activeDescendant() on Google Reader with ARIA (22510)
-
- A nil pointer needed to be checked
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::activeDescendant):
-
-2008-11-30 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22530
- Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID
-
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::start): Protect worker startup with a mutex to ensure that this
- function runs to completion before the thread begins execution.
- (WebCore::WorkerThread::workerThread): Updated comments.
- (WebCore::WorkerThread::stop): Ditto.
- * dom/WorkerThread.h: Renamed m_workerContextMutex to m_threadCreationMutex, because it now
- protects startup as a whole.
-
- * storage/DatabaseThread.cpp:
- * storage/DatabaseThread.h:
- * storage/LocalStorageThread.cpp:
- * storage/LocalStorageThread.h:
- Fixed the same m_threadID problem.
-
-2008-11-29 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Remove Visual Studio project dependencies on non-redistributable
- components in the Debug_Cairo and Release_Cairo build targets.
- See https://bugs.webkit.org/show_bug.cgi?id=22527
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-11-29 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Fix some sorting
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-11-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
- NULL pointer crash in dispatchEvent(null);
-
- Test: fast/events/dispatchEvent-crash.html
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::dispatchEvent):
- * dom/Worker.cpp:
- (WebCore::Worker::dispatchEvent):
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::dispatchEvent):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::dispatchEvent):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::dispatchEvent):
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::dispatchEvent):
-
-2008-11-29 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=22454
- <rdar://problem/6405550> REGRESSION (3.2-TOT): Crash below FontFallbackList::fontDataAt on jacobian.org
-
- Test: http/tests/misc/font-face-in-multiple-segmented-faces.html
-
- The crash happened because style recalculation was invoked by
- CSSFontSelector after one CSSSegmentedFontFace had pruned its tables but
- before another CSSSegmentedFontFace using the same CSSFontFace had done
- so. The fix is to let all CSSSegmentedFontFaces using the CSSFontFace
- prune their tables before telling the CSSFontSelector to recalc style.
-
- * css/CSSFontFace.cpp:
- (WebCore::CSSFontFace::fontLoaded):
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::fontLoaded):
- * css/CSSFontSelector.h:
- * css/CSSSegmentedFontFace.cpp:
- (WebCore::CSSSegmentedFontFace::fontLoaded):
-
-2008-11-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=14968
- document.open() erroneously returns void instead of the new Document
-
- Test: fast/dom/HTMLDocument/document-open-return-value.html
-
- * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
- Return the document on which this method was invoked, per HTML5.
-
-2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550
-
- Add <timer> element support. It provides a way to execute a task with a delay.
- The user is notified by firing the task associated with the <card>'s ontimer attribute.
- Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)
-
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::setIntrinsicEventTimer):
- (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- * wml/WMLCardElement.h:
- * wml/WMLDoElement.cpp:
- (WebCore::WMLDoElement::defaultEventHandler):
- * wml/WMLErrorHandling.cpp:
- (WebCore::reportWMLError):
- * wml/WMLPageState.h:
- (WebCore::WMLPageState::getVariable):
- * wml/WMLPrevElement.cpp:
- (WebCore::WMLPrevElement::executeTask):
- * wml/WMLRefreshElement.cpp:
- (WebCore::WMLRefreshElement::executeTask):
- * wml/WMLTagNames.in:
- * wml/WMLTimerElement.cpp: Added.
- (WebCore::WMLTimerElement::WMLTimerElement):
- (WebCore::WMLTimerElement::parseMappedAttribute):
(WebCore::WMLTimerElement::insertedIntoDocument):
(WebCore::WMLTimerElement::timerFired):
(WebCore::WMLTimerElement::start):
- (WebCore::WMLTimerElement::stop):
- (WebCore::WMLTimerElement::storeIntervalToPageState):
- * wml/WMLTimerElement.h: Added.
-
-2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+ (WebCore::WMLTimerElement::value):
+ * wml/WMLTimerElement.h:
- Reviewed by Holger Freyther.
+2009-06-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549
+ Reviewed by Adam Roben.
- Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
- Changes numerous of layout tests which contain <do> elements, as they render as buttons now.
+ Forgot to initialize m_task member variable. Results in crashes sometimes.
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::updateFromElement):
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::registerDoElement):
- * wml/WMLCardElement.h:
- * wml/WMLDoElement.cpp: Added.
- (WebCore::WMLDoElement::WMLDoElement):
- (WebCore::WMLDoElement::defaultEventHandler):
- (WebCore::WMLDoElement::parseMappedAttribute):
- (WebCore::WMLDoElement::insertedIntoDocument):
- (WebCore::WMLDoElement::createRenderer):
- (WebCore::WMLDoElement::recalcStyle):
- * wml/WMLDoElement.h: Added.
- (WebCore::WMLDoElement::registerTask):
- (WebCore::WMLDoElement::isActive):
- (WebCore::WMLDoElement::label):
- (WebCore::WMLDoElement::name):
- (WebCore::WMLDoElement::setActive):
- (WebCore::WMLDoElement::setNoop):
- * wml/WMLNoopElement.cpp:
- (WebCore::WMLNoopElement::insertedIntoDocument):
- * wml/WMLTagNames.in:
- * wml/WMLTaskElement.cpp:
- (WebCore::WMLTaskElement::insertedIntoDocument):
+ * wml/WMLAnchorElement.cpp:
+ (WebCore::WMLAnchorElement::WMLAnchorElement):
-2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+2009-06-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
- Reviewed by Sam Weinig.
+ Not reviewed. Forgot to include within last patch.
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545
+ * manual-tests/wml/card-title-attr.wml: Added.
- Add onenterforward/onenterbackward/ontimer support for <card> elements.
+2009-06-24 Wajahat Siddiqui <wajahatmeister@gmail.com>
+
+ Reviewed by Nikolas Zimmermann.
- No testing possible at the moment because WMLGoElement is not yet implemented.
- After that we can add tests covering the <card> event handling.
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
+ Adding WML <card> title attribute handling.
+ * wml/WMLElement.h: marking parseValueSubstitutingVariableReferences and parseValueForbiddingVariableReferences as const
+ * wml/WMLElement.cpp:
+ * wml/WMLCardElement.h:
+ (WebCore::WMLCardElement::title):
* wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- (WebCore::WMLCardElement::parseMappedAttribute):
- (WebCore::WMLCardElement::setActiveCardInDocument):
- * wml/WMLCardElement.h:
- (WebCore::WMLCardElement::isNewContext):
- (WebCore::WMLCardElement::isOrdered):
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing):
- * wml/WMLIntrinsicEvent.cpp:
- (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
- * wml/WMLIntrinsicEvent.h:
- (WebCore::WMLIntrinsicEvent::create):
-
-2008-11-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Regression seen on QtWebKit - causes a build failure on Win using MinGW
-
- https://bugs.webkit.org/show_bug.cgi?id=22536
-
- * WebCore.pro:
-
-2008-11-28 Simon Hausmann <hausmann@webkit.org>
+ * wml/manual-test/card-title-attr.wml: Manual test
+
+2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
- Fix compilation and linking on Windows CE.
-
- Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
- from the Windows'ish build.
-
- Link against the newly required mmtimer.
-
- * WebCore.pro:
- * plugins/PluginPackage.cpp:
-
-2008-11-28 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- http://bugs.webkit.org/show_bug.cgi?id=22524
+ Fix the build without ENABLE_VIDEO.
- Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
- of XMLHttpRequest by Workers (on threads).
-
- No observable change in behavior, so no test.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
- (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
- (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
- (WebCore::PreflightResultCacheItem::allowsRequest):
- (WebCore::createXMLHttpRequestStaticData):
- (WebCore::initializeXMLHttpRequestStaticData):
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::isSafeRequestHeader):
- (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
- * xml/XMLHttpRequest.h:
+ * html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
+ * html/CanvasRenderingContext2D.h: Ditto.
-2008-11-27 Cameron Zwarich <zwarich@apple.com>
+2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>
- Not reviewed.
-
- r38825, was committed without checking whether anything in WebCore
- uses JSFunction::m_body. Use the appropriate getters and setters
- instead.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
-
-2008-11-27 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22529
- Crashes seen on buildbots due to trying to stop a worker thread twice
-
- * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
- Don't try to stop the thread if it's already stopping.
-
-2008-11-27 Kent Hansen <khansen@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Make JavaScript bindings for Qt plugin widgets work again
- this was a regression; need to handle non-NPAPI plugins as in 4.4.
-
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
-
-2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
+ Reviewed by Eric Seidel.
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22522
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
+ the smartReplace set TRUE initially, which was wrong since the purpose of this call is
+ to just replace the selection, and place the caret at the end of the selection it replaced.
- Catch WML errors (invalid variable name/reference, multiple access elements, etc)
- while parsing the document, and stop parsing immediately and wrap the document
- fragment in a XHTML error document, just like it's done from XML parsing errors.
+ * editing/Editor.cpp:
+ (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+ * manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
- Until now all card elements were hidden by default (no renderer created), and
- WMLDocument::finishedParsing() took care of showing the right card (either the first,
- or any named card in the document, specified by document URL reference). Change this
- behaviour to support displaying partially parsed WML document fragments: Mark the first
- WMLCardElement inserted into the document as visible. If the document parsing finishes
- without problems, WMLDocument::finishedParsing() will be called, which takes care of
- showing the desired card (common case: first card in the document, which is already
- visible, so nothing actually has to be done). If an error occours, the document is
- correctly rendered until the error happened - wrapped in a XHTML document.
+2009-06-24 Kevin Watters <kevinwatters@gmail.com>
- Fixes: fast/wml/err-event-binding-conflict.wml
- fast/wml/err-invalid-variable-name.wml
- fast/wml/err-multi-access.wml
- fast/wml/err-unallowed-task-in-anchor.wml
+ Reviewed by Kevin Ollivier.
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLAccessElement.cpp:
- (WebCore::WMLAccessElement::parseMappedAttribute):
- (WebCore::WMLAccessElement::insertedIntoDocument):
- * wml/WMLAccessElement.h:
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::insertedIntoDocument):
- (WebCore::WMLCardElement::setActiveCardInDocument):
- * wml/WMLCardElement.h:
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing):
- * wml/WMLErrorHandling.cpp: Added.
- (WebCore::reportWMLError):
- * wml/WMLErrorHandling.h: Added.
- (WebCore::):
- * wml/WMLIntrinsicEventHandler.cpp:
- (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
- * wml/WMLIntrinsicEventHandler.h:
- * wml/WMLNoopElement.cpp:
- (WebCore::WMLNoopElement::insertedIntoDocument):
- * wml/WMLOnEventElement.cpp:
- (WebCore::WMLOnEventElement::parseMappedAttribute):
- (WebCore::WMLOnEventElement::registerTask):
- * wml/WMLPageState.cpp:
- (WebCore::WMLPageState::setNeedCheckDeckAccess):
- * wml/WMLPageState.h:
- * wml/WMLSetvarElement.cpp:
- (WebCore::WMLSetvarElement::parseMappedAttribute):
+ Don't use an unsigned int for intervalInMS because we sometimes initialize
+ it with a negative value.
-2008-11-26 Glenn Wilson <gwilson@chromium.org>
+ * platform/wx/SharedTimerWx.cpp:
+ (WebCore::setSharedTimerFireTime):
- Reviewed by Dan Bernstein.
+2009-06-24 Eric Seidel <eric@webkit.org>
- Fixed bug http://bugs.webkit.org/show_bug.cgi?id=21953
+ No review, build fix only.
- This fixes the crash when the small-caps font variant is used
- on a lower-case glyph that does not have a corresponding
- upper-case glyph defined in the set of available fonts.
+ The previous checkin had an improper merge. This fixes the build.
- This changes Font.cpp to check if the font being used exists before trying to apply the small-caps variant.
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
- Test: fast/css/small-caps-crash.html
+2009-06-05 Eric Seidel <eric@webkit.org>
- * platform/graphics/Font.cpp:
- (WebCore::Font::glyphDataForCharacter):
+ Reviewed by Oliver Hunt.
-2008-11-26 Tony Chang <tony@chromium.org>
+ https://bugs.webkit.org/show_bug.cgi?id=25922
+ JS setting dropEffect = "none" causes tryDHTMLDrag
+ to return DragOperationNone. Which is also the value
+ tryDHTMLDrag previously used to indicate JS did not
+ want to handle the drag.
- Reviewed by Oliver Hunt.
+ Make it possible for the DragController::try* methods
+ to return a bool to indicate if javascript accepted
+ or rejected the drag event, separate from the DragOperation.
- Add a new platform specific method cleanupAfterSystemDrag
- that platforms can ue to clean up drag state after a
- system drag. Use this method on PLAFORM(MAC).
- https://bugs.webkit.org/show_bug.cgi?id=21956
+ Tests:
+ - fast/events/drag-to-navigate.html
+ - fast/events/prevent-drag-to-navigate.html
- * ChangeLog:
* page/DragController.cpp:
- (WebCore::DragController::doSystemDrag):
+ (WebCore::DragController::dragEnteredOrUpdated):
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::defaultOperationForDrag):
+ (WebCore::DragController::tryDHTMLDrag):
* page/DragController.h:
- * page/gtk/DragControllerGtk.cpp:
- (WebCore::DragController::cleanupAfterSystemDrag):
- * page/mac/DragControllerMac.mm:
- (WebCore::DragController::cleanupAfterSystemDrag):
- * page/qt/DragControllerQt.cpp:
- (WebCore::DragController::cleanupAfterSystemDrag):
- * page/win/DragControllerWin.cpp:
- (WebCore::DragController::cleanupAfterSystemDrag):
- * page/wx/DragControllerWx.cpp:
- (WebCore::DragController::cleanupAfterSystemDrag):
-
-2008-11-26 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver Hunt.
-
- Fix path to string logic, correctly taking closed (sub-)paths into account.
- Code was just broken on cg, observed by Dirk Schulze.
-
- QPainterPath doesn't seem to expose any functionality to detect closed sub paths,
- using the elementAt() function. There might be a workaround - Dirk will investigate.
-
- * platform/graphics/cg/PathCG.cpp:
- (WebCore::CGPathToCFStringApplierFunction):
- * platform/graphics/cairo/PathCairo.cpp:
- (WebCore::Path::debugString):
-2008-11-26 Darin Fisher <darin@chromium.org>
+2009-06-23 Oliver Hunt <oliver@apple.com> and Eric Carlson <eric.carlson@apple.com>
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=22519
- Remove unnecessary include.
+ Reviewed by Sam Weinig and Dave Hyatt.
- * dom/XMLTokenizer.cpp:
+ <rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
+ <https://bugs.webkit.org/show_bug.cgi?id=25920>
-2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Oliver Hunt.
+ Add support for drawing the contents of the video element to the canvas
+ in accordance with the current HTML5 draft.
- Add <noop> element support, completing the task element support.
+ Test: media/video-canvas.html
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLNoopElement.cpp: Added.
- (WebCore::WMLNoopElement::WMLNoopElement):
- (WebCore::WMLNoopElement::insertedIntoDocument):
- * wml/WMLNoopElement.h: Added.
- * wml/WMLTagNames.in: Reorganize file a bit.
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::JSCanvasRenderingContext2D::drawImage):
+ Standard custom bindings stuff we need to do for all canvas methods.
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::size): Helper function for finding the size of a video element
+ (WebCore::CanvasRenderingContext2D::checkOrigin): moved up in the file.
+ (WebCore::CanvasRenderingContext2D::drawImage): The various overloads of HTML5's drawImage(<video>)
+ * html/CanvasRenderingContext2D.h:
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::hasSingleSecurityOrigin):
+ hasSingleSecurityOrigin is needed for security, currently all implementations are trivial
+ as we force QT to maintain a single origin.
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::paint):
+ Paint routine on video so we don't have to look at MediaPlayer directly
+ * html/HTMLVideoElement.h:
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::hasSingleSecurityOrigin):
+ (WebCore::MediaPlayer::hasSingleSecurityOrigin):
+ Default implementations of hasSingleSecurityOrigin
+ * platform/graphics/MediaPlayer.h:
+ * platform/graphics/MediaPlayerPrivate.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::setUpVideoRendering):
+ A video may need a player now even if it is not visible.
+ (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
+ Always return true due to restrictions we've placed on QT.
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::paint):
+ Jump through some hoops to allow windows QT to draw to an intermediate buffer.
+ In the long term we'd like to cache the HDC, but this will do for now.
+ (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+ As for Mac we force QT to only allow same origin loads.
-2008-11-26 Julien Chaffraix <jchaffraix@webkit.org>
+2009-06-23 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
- Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
- https://bugs.webkit.org/show_bug.cgi?id=22441
-
- Make more HTML elements' constructors take a QualifiedName.
-
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::createDeletionUI):
- * html/HTMLBlockquoteElement.cpp:
- (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
- * html/HTMLBlockquoteElement.h:
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::HTMLButtonElement):
- * html/HTMLButtonElement.h:
- * html/HTMLDListElement.cpp:
- (WebCore::HTMLDListElement::HTMLDListElement):
- * html/HTMLDListElement.h:
- * html/HTMLDirectoryElement.cpp:
- (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
- * html/HTMLDirectoryElement.h:
- * html/HTMLDivElement.cpp:
- (WebCore::HTMLDivElement::HTMLDivElement):
- * html/HTMLDivElement.h:
- * html/HTMLElementFactory.cpp:
- (WebCore::styleConstructor):
- (WebCore::titleConstructor):
- (WebCore::frameConstructor):
- (WebCore::framesetConstructor):
- (WebCore::iframeConstructor):
- (WebCore::formConstructor):
- (WebCore::buttonConstructor):
- (WebCore::inputConstructor):
- (WebCore::isindexConstructor):
- (WebCore::fieldsetConstructor):
- (WebCore::keygenConstructor):
- (WebCore::labelConstructor):
- (WebCore::legendConstructor):
- (WebCore::optgroupConstructor):
- (WebCore::optionConstructor):
- (WebCore::selectConstructor):
- (WebCore::textareaConstructor):
- (WebCore::dlConstructor):
- (WebCore::ulConstructor):
- (WebCore::olConstructor):
- (WebCore::dirConstructor):
- (WebCore::menuConstructor):
- (WebCore::liConstructor):
- (WebCore::blockquoteConstructor):
- (WebCore::divConstructor):
- (WebCore::headingConstructor):
- * html/HTMLFieldSetElement.cpp:
- (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
- * html/HTMLFieldSetElement.h:
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::HTMLFormElement):
- * html/HTMLFormElement.h:
- * html/HTMLFrameElement.cpp:
- (WebCore::HTMLFrameElement::HTMLFrameElement):
- * html/HTMLFrameElement.h:
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
- * html/HTMLFrameSetElement.h:
- * html/HTMLIFrameElement.cpp:
- (WebCore::HTMLIFrameElement::HTMLIFrameElement):
- * html/HTMLIFrameElement.h:
- * html/HTMLInputElement.cpp:
- * html/HTMLInputElement.h:
- * html/HTMLIsIndexElement.cpp:
- (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
- * html/HTMLIsIndexElement.h:
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::HTMLKeygenElement):
- * html/HTMLKeygenElement.h:
- * html/HTMLLIElement.cpp:
- (WebCore::HTMLLIElement::HTMLLIElement):
- * html/HTMLLIElement.h:
- * html/HTMLLabelElement.cpp:
- (WebCore::HTMLLabelElement::HTMLLabelElement):
- * html/HTMLLabelElement.h:
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::HTMLLegendElement):
- * html/HTMLLegendElement.h:
- * html/HTMLMenuElement.cpp:
- (WebCore::HTMLMenuElement::HTMLMenuElement):
- * html/HTMLMenuElement.h:
- * html/HTMLOListElement.cpp:
- (WebCore::HTMLOListElement::HTMLOListElement):
- * html/HTMLOListElement.h:
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
- * html/HTMLOptGroupElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::HTMLOptionElement):
- * html/HTMLOptionElement.h:
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::formCreateErrorCheck):
- (WebCore::HTMLParser::handleIsindex):
- * html/HTMLSelectElement.cpp:
- * html/HTMLSelectElement.h:
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::HTMLStyleElement):
- * html/HTMLStyleElement.h:
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
- * html/HTMLTextAreaElement.h:
- * html/HTMLTitleElement.cpp:
- (WebCore::HTMLTitleElement::HTMLTitleElement):
- * html/HTMLTitleElement.h:
- * html/HTMLUListElement.cpp:
- (WebCore::HTMLUListElement::HTMLUListElement):
- * html/HTMLUListElement.h:
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::createContainingTable):
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
- (WebCore::MediaControlInputElement::MediaControlInputElement):
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createPanel):
- (WebCore::RenderMedia::createTimeDisplay):
- * rendering/RenderSlider.cpp:
- (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
- * rendering/TextControlInnerElements.cpp:
- (WebCore::TextControlInnerElement::TextControlInnerElement):
-
-2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Fix obvious problem in WMLPageState constructor, m_page was not set to the passed Page pointer.
-
- * wml/WMLPageState.cpp:
- (WebCore::WMLPageState::WMLPageState):
-
-2008-11-26 Matt Perry <mpcomplete@gmail.com>
+ Chromium: Fix crash with inherited font-size in <option>
- Fix Qt bustage.
-
- See https://bugs.webkit.org/show_bug.cgi?id=22051
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::extraDefaultStyleSheet):
-
-2008-11-26 Matt Perry <mpcomplete@gmail.com>
-
- Reviewed by Maciej Stachowiak.
+ https://bugs.webkit.org/show_bug.cgi?id=26656
+ http://code.google.com/p/chromium/issues/detail?id=14853
- Fix https://bugs.webkit.org/show_bug.cgi?id=22051
- Renderthemes should be able to supply additional CSS rules to the core
- ones.
+ In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
+ the <select> handing for Chromium to fix a rendering bug. However,
+ although the font-size is correctly ignored, getRowHeight wasn't
+ updated and so was calculating the height of the rows in an
+ inconsistent manner. This can lead to a crash.
- * DerivedSources.make:
- * css/CSSStyleSelector.cpp:
- (WebCore::parseUASheet):
- (WebCore::loadFullDefaultStyle):
- (WebCore::loadSimpleDefaultStyle):
- * css/themeWin.css: Added.
- * css/themeWinQuirks.css: Added.
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::extraDefaultStyleSheet):
- * platform/qt/RenderThemeQt.h:
- * rendering/RenderTheme.cpp:
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::extraDefaultStyleSheet):
- (WebCore::RenderTheme::extraQuirksStyleSheet):
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::extraDefaultStyleSheet):
- (WebCore::RenderThemeWin::extraQuirksStyleSheet):
- * rendering/RenderThemeWin.h:
-
-2008-11-26 David Kilzer <ddkilzer@apple.com>
-
- Make CSSStyleSheet::addSubresourceURLStrings() iterative
+ * manual-tests/optgroup-empty-and-nested.html: adding test case for crash
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::getRowHeight):
- Part of the fix for Bug 11850: Webarchive fails to save images referenced in CSS
- <https://bugs.webkit.org/show_bug.cgi?id=11850>
+2009-06-23 Brady Eidson <beidson@apple.com>
+ Patch by Antti Koivisto.
Reviewed by Brady Eidson.
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::addSubresourceURLStrings): Switch algorithm
- from recursive to iterative for gathering the list of all CSS
- stylesheets referenced in @import statements.
-
-2008-11-26 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Simon Hausmann.
-
- Transformations to the context shouldn't transform the currentPath.
- Fixed this on Qt.
-
- [QT] GraphicsContext's currenPath can be transformed
- https://bugs.webkit.org/show_bug.cgi?id=22163
-
- * platform/graphics/GraphicsContextPrivate.h:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::restorePlatformState):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::translate):
- (WebCore::GraphicsContext::rotate):
- (WebCore::GraphicsContext::scale):
- (WebCore::GraphicsContext::concatCTM):
-
-2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build script minor fixes. Not reviewed.
-
- * GNUmakefile.am:
- - Add ScriptInstance.h (introduced in r38774) to
- the build.
- - Move WML and GEOLOCATION conditionals before the SVG
- conditional to be consistent with the style of the script.
- - Move GeolocationGtk sources to webcoregtk_sources.
-
-2008-11-26 Dmitry Titov <dimich@chromium.org>
-
- Reviewed by Darin Adler and Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=22469
-
- Move the class DOMWindowTimer from JSDOMWindowBase into its own file in
- preparation to making it work for Workers. For now, just move the code and couple
- of global variables.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::installTimeout):
- (WebCore::JSDOMWindowBase::pauseTimeouts):
- (WebCore::JSDOMWindowBase::resumeTimeouts):
- (WebCore::JSDOMWindowBase::timerFired):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/DOMTimer.cpp: Added.
- (WebCore::DOMTimer::DOMTimer):
- (WebCore::DOMTimer::~DOMTimer):
- (WebCore::DOMTimer::fired):
- * bindings/js/DOMTimer.h: Added.
- (WebCore::DOMTimer::timeoutId):
- (WebCore::DOMTimer::nestingLevel):
- (WebCore::DOMTimer::setNestingLevel):
- (WebCore::DOMTimer::action):
- (WebCore::DOMTimer::takeAction):
-
-2008-11-25 Darin Fisher <darin@chromium.org>
-
- Fix bustage.
-
- https://bugs.webkit.org/show_bug.cgi?id=22493
- Need to expose bridge/*.h to the WebKit build.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-11-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Fix build, by removing some wrong last-minute changes.
-
- * wml/WMLIntrinsicEvent.cpp:
- (WebCore::createTaskElement):
- * wml/WMLOnEventElement.cpp:
- (WebCore::WMLOnEventElement::registerTask):
-
-2008-11-25 Darin Fisher <darin@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=22493
- Abstract away JSC:: usage in WebCore/html
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::pluginInstance):
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bindings/js/ScriptInstance.h: Added.
- * html/HTMLPlugInElement.cpp:
- (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
- (WebCore::HTMLPlugInElement::getInstance):
- * html/HTMLPlugInElement.h:
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477
-
- A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
- Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.
-
- Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
- centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
- function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
- <template>/<option> or <card> element.
-
- Add complete <onevent> support.
-
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::setActiveCardInDocument):
- * wml/WMLCardElement.h:
- (WebCore::WMLCardElement::isVisible):
- (WebCore::WMLCardElement::setVisible):
- * wml/WMLElement.h:
- (WebCore::WMLElement::isWMLTaskElement):
- * wml/WMLEventHandlingElement.cpp: Added.
- (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
- (WebCore::WMLEventHandlingElement::createEventHandlerIfNeeded):
- * wml/WMLEventHandlingElement.h: Added.
- (WebCore::WMLEventHandlingElement::isWMLEventHandlingElement):
- (WebCore::WMLEventHandlingElement::eventHandler):
- * wml/WMLOnEventElement.cpp: Added.
- (WebCore::WMLOnEventElement::WMLOnEventElement):
- (WebCore::WMLOnEventElement::parseMappedAttribute):
- (WebCore::WMLOnEventElement::registerTask):
- * wml/WMLOnEventElement.h: Added.
- * wml/WMLSetvarElement.cpp:
- (WebCore::WMLSetvarElement::parseMappedAttribute):
- (WebCore::WMLSetvarElement::insertedIntoDocument):
- * wml/WMLTagNames.in:
- * wml/WMLTaskElement.cpp:
- (WebCore::WMLTaskElement::insertedIntoDocument):
- * wml/WMLTaskElement.h:
- (WebCore::WMLTaskElement::isWMLTaskElement):
-
-2008-11-25 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Mark Rowe.
-
- createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL
-
- https://bugs.webkit.org/show_bug.cgi?id=22503
-
- * platform/graphics/mac/FontCustomPlatformData.cpp:
- (WebCore::createFontCustomPlatformData):
-
-2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
- https://bugs.webkit.org/show_bug.cgi?id=22441
-
- Element's other than HTML ones take a QualifiedName in their constructors.
- To make HTMLElementFactory closer to the other ElementFactory, we need
- to make them take the same arguments.
- This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
- will go into the next patch.
-
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
- * html/HTMLBaseElement.cpp:
- (WebCore::HTMLBaseElement::HTMLBaseElement):
- * html/HTMLBaseElement.h:
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::HTMLBodyElement):
- * html/HTMLBodyElement.h:
- * html/HTMLElementFactory.cpp:
- (WebCore::htmlConstructor):
- (WebCore::headConstructor):
- (WebCore::bodyConstructor):
- (WebCore::baseConstructor):
- (WebCore::linkConstructor):
- (WebCore::metaConstructor):
- * html/HTMLHeadElement.cpp:
- (WebCore::HTMLHeadElement::HTMLHeadElement):
- * html/HTMLHeadElement.h:
- * html/HTMLHtmlElement.cpp:
- (WebCore::HTMLHtmlElement::HTMLHtmlElement):
- * html/HTMLHtmlElement.h:
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::HTMLLinkElement):
- * html/HTMLLinkElement.h:
- * html/HTMLMetaElement.cpp:
- (WebCore::HTMLMetaElement::HTMLMetaElement):
- * html/HTMLMetaElement.h:
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError):
- (WebCore::HTMLParser::headCreateErrorCheck):
- (WebCore::HTMLParser::createHead):
- (WebCore::HTMLParser::finished):
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::createContainingTable):
-
-2008-11-25 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
- I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.
-
- Tests: animations/empty-keyframes.html
- animations/fill-unset-properties.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
-
-2008-11-25 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=22046
-
- Fix a crash when an animation or transition end event handler
- removes the element upon which the transition/animation is running,
- by keeping a reference to the AnimationBase object on the stack.
-
- Tests: animations/transform-animation-event-destroy-element.html
- transitions/transform-transition-event-destroy-element.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::setChanged):
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::clearRenderer):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::clear):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
- * page/animation/CompositeAnimation.h:
-
-2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
-
- Better wx build fix - support PurgeableBuffer on Mac.
-
- * platform/PurgeableBuffer.h:
- * webcore-wx.bkl:
-
-2008-11-25 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=22022
-
- Add GeoleocationServiceGtk stubs and integrate it into the buildsystem
-
- Add stubs for a Gtk Implementation.
-
- * GNUmakefile.am:
- * platform/gtk/GeolocationServiceGtk.cpp: Added.
- (WebCore::GeolocationService::create):
- (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
- (WebCore::GeolocationServiceGtk::startUpdating):
- (WebCore::GeolocationServiceGtk::stopUpdating):
- (WebCore::GeolocationServiceGtk::suspend):
- (WebCore::GeolocationServiceGtk::resume):
- (WebCore::GeolocationServiceGtk::lastPosition):
- (WebCore::GeolocationServiceGtk::lastError):
- * platform/gtk/GeolocationServiceGtk.h: Added.
-
-2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix - we don't support PurgeableBuffer on Leopard for now.
-
- * platform/PurgeableBuffer.h:
-
-2008-11-25 Antti Koivisto <antti@apple.com>
-
- Reviewed by Mark Rowe.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=22483
- Assertion failure in CachedResource::makePurgeable during layout tests
-
- Deleting SVG image can re-enter destroyDecodedData.
-
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::destroyDecodedData):
-
-2008-11-25 David Levin <levin@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22443
- Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
- Workers on threads.
-
- No observable change in behavior, so no test.
-
- * platform/text/PlatformString.h:
- * platform/text/String.cpp:
- (WebCore::String::substringCopy):
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::substringCopy):
- * platform/text/StringImpl.h:
- Added the ability to copy a substring.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
- (WebCore::PreflightResultCache::PreflightResultCache):
- (WebCore::PreflightResultCacheItem::addToAccessControlAllowList):
- (WebCore::PreflightResultCacheItem::parseAccessControlAllowList):
- (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge):
- (WebCore::PreflightResultCacheItem::parse):
- (WebCore::PreflightResultCacheItem::allowsRequest):
- (WebCore::PreflightResultCache::shared):
- (WebCore::PreflightResultCache::appendEntry):
- (WebCore::PreflightResultCache::canSkipPreflight):
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- Made the PreflightResultCache threadsafe.
-
- (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
- (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
- Consolidation of duplicate logic.
-
-2008-11-24 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Darin Adler.
-
- For Unicode encodings other than UTF-8, use UTF-8 for
- form submission and URL query part encoding.
-
- See https://bugs.webkit.org/show_bug.cgi?id=21635
-
- Tests: http/tests/misc/submit-get-in-utf16be.html
- http/tests/misc/submit-get-in-utf16le.html
- http/tests/misc/submit-get-in-utf32be.html
- http/tests/misc/submit-get-in-utf32le.html
- http/tests/misc/submit-get-in-utf7.html
- http/tests/misc/submit-post-in-utf16be.html
- http/tests/misc/submit-post-in-utf16le.html
- http/tests/misc/submit-post-in-utf32be.html
- http/tests/misc/submit-post-in-utf32le.html
- http/tests/misc/submit-post-in-utf7.html
- http/tests/misc/url-in-utf16be.html
- http/tests/misc/url-in-utf16le.html
- http/tests/misc/url-in-utf32be.html
- http/tests/misc/url-in-utf32le.html
- http/tests/misc/url-in-utf7.html
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::formData):
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::setEncoding):
- * platform/KURL.cpp:
- (WebCore::KURL::KURL):
- * platform/text/TextEncoding.cpp:
- (WebCore::UTF7Encoding):
- (WebCore::TextEncoding::isNonByteBasedEncoding):
- (WebCore::TextEncoding::closestByteBasedEquivalent):
- (WebCore::TextEncoding::encodingForFormSubmission):
- * platform/text/TextEncoding.h:
-
-2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
- https://bugs.webkit.org/show_bug.cgi?id=22441
-
- - Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
-
- - Tweaked the generated files to better match our coding style.
-
- * dom/make_names.pl:
-
-2008-11-24 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
- REGRESSION(r33544): Palace in the Sky crashes WebKit
-
- HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
- there were no scripts left to execute.
-
- If m_hasScriptsWaitingForStylesheets becomes true during script execution
- bail out from executing more scripts synchronously.
-
- Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html
-
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::reset):
- (WebCore::HTMLTokenizer::notifyFinished):
+ <rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK
-2008-11-24 Darin Fisher <darin@chromium.org>
+ A latent bug that cache revalidation uncovered. When a CachedResource failed to load,
+ it should always be revalidated upon reload.
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=22465
- Define KURL::copy() and use it in WorkerThread.cpp
-
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::WorkerThread):
- * platform/KURL.cpp:
- (WebCore::KURL::copy):
- * platform/KURL.h:
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Name enum values in a style guide compatible way.
- Allow WMLIntrinsicEvent inclusion, without needing other includes.
-
- * wml/WMLIntrinsicEvent.cpp:
- (WebCore::createTaskElement):
- * wml/WMLIntrinsicEvent.h:
- * wml/WMLIntrinsicEventHandler.cpp:
- * wml/WMLIntrinsicEventHandler.h:
- (WebCore::):
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Add wmlPageStateForDocument() helper function and use it in some places.
-
- * wml/WMLAccessElement.cpp:
- (WebCore::WMLAccessElement::parseMappedAttribute):
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::WMLDocument):
- (WebCore::WMLDocument::finishedParsing):
- (WebCore::wmlPageStateForDocument):
- * wml/WMLDocument.h:
- * wml/WMLGoElement.cpp:
- (WebCore::WMLGoElement::executeTask):
- * wml/WMLPrevElement.cpp:
- (WebCore::WMLPrevElement::executeTask):
- * wml/WMLRefreshElement.cpp:
- (WebCore::WMLRefreshElement::executeTask):
- * wml/WMLTaskElement.cpp:
- (WebCore::WMLTaskElement::storeVariableState):
- * wml/WMLTaskElement.h:
-
-2008-11-24 Antti Koivisto <antti@apple.com>
-
- Reviewed by Geoff Garen and Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22214
- Keep dead resources in memory cache in purgeable memory.
- <rdar://problem/6333088>
-
- OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
- areas as less important. Under memory pressure system can steal pages that have
- been marked purgeable for (hopefully) better uses. This is ideal for caches.
-
- Only resources larger than 16KB will be moved to the purgeable memory.
-
- * WebCore.base.exp:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * loader/Cache.cpp:
- (WebCore::Cache::requestResource):
- (WebCore::Cache::requestUserCSSStyleSheet):
- (WebCore::Cache::resourceForURL):
- (WebCore::Cache::pruneDeadResources):
- (WebCore::Cache::TypeStatistic::addResource):
- (WebCore::Cache::getStatistics):
- (WebCore::Cache::dumpStats):
- * loader/Cache.h:
- (WebCore::Cache::TypeStatistic::TypeStatistic):
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::allClientsRemoved):
- (WebCore::CachedCSSStyleSheet::sheetText):
- * loader/CachedCSSStyleSheet.h:
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::addClient):
- (WebCore::CachedImage::image):
- (WebCore::CachedImage::imageSize):
- (WebCore::CachedImage::imageRect):
- (WebCore::CachedImage::destroyDecodedData):
* loader/CachedResource.cpp:
- (WebCore::CachedResource::addClient):
- (WebCore::CachedResource::makePurgeable):
- (WebCore::CachedResource::isPurgeable):
- (WebCore::CachedResource::wasPurged):
- * loader/CachedResource.h:
- (WebCore::CachedResource::data):
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::allClientsRemoved):
- (WebCore::CachedScript::script):
- (WebCore::CachedScript::destroyDecodedData):
- * platform/PurgeableBuffer.h: Added.
- (WebCore::PurgeableBuffer::create):
- (WebCore::PurgeableBuffer::size):
- (WebCore::PurgeableBuffer::):
- (WebCore::PurgeableBuffer::purgePriority):
- (WebCore::PurgeableBuffer::isPurgeable):
- (WebCore::PurgeableBuffer::~PurgeableBuffer):
- (WebCore::PurgeableBuffer::data):
- (WebCore::PurgeableBuffer::setPurgePriority):
- (WebCore::PurgeableBuffer::wasPurged):
- (WebCore::PurgeableBuffer::makePurgeable):
- * platform/SharedBuffer.cpp:
- (WebCore::SharedBuffer::~SharedBuffer):
- (WebCore::SharedBuffer::adoptPurgeableBuffer):
- (WebCore::SharedBuffer::size):
- (WebCore::SharedBuffer::data):
- (WebCore::SharedBuffer::append):
- (WebCore::SharedBuffer::clear):
- (WebCore::SharedBuffer::releasePurgeableBuffer):
- * platform/SharedBuffer.h:
- (WebCore::SharedBuffer::hasPurgeableBuffer):
- * platform/cf/SharedBufferCF.cpp:
- * platform/mac/PurgeableBufferMac.cpp: Added.
- (WebCore::PurgeableBuffer::PurgeableBuffer):
- (WebCore::PurgeableBuffer::~PurgeableBuffer):
- (WebCore::PurgeableBuffer::create):
- (WebCore::PurgeableBuffer::makePurgeable):
- (WebCore::PurgeableBuffer::wasPurged):
- (WebCore::PurgeableBuffer::setPurgePriority):
- (WebCore::PurgeableBuffer::data):
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos & Eric Seidel.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22430
-
- Regenerate WML layout test results after implementing WML specific <card> handling:
- Only the first <card> element should be visible after loading the document, others
- can be shown by using the <go> task element.
-
- * dom/Document.h: Make 'finishedParsing()' a virtual function.
- * wml/WMLCardElement.cpp:
- (WebCore::WMLCardElement::WMLCardElement):
- (WebCore::WMLCardElement::~WMLCardElement):
- (WebCore::WMLCardElement::createRenderer):
- (WebCore::WMLCardElement::setActiveCardInDocument):
- (WebCore::WMLCardElement::setVisibility):
- * wml/WMLCardElement.h:
- * wml/WMLDocument.cpp:
- (WebCore::WMLDocument::finishedParsing): Execute WML specific logic after tokenzing.
- * wml/WMLDocument.h:
-
-2008-11-24 Glenn Wilson <gwilson@chromium.org>
-
- Reviewed by Alexey Proskuryakov.
-
- http://bugs.webkit.org/show_bug.cgi?id=15643
-
- Added support for clients that wish to disable smart insert/delete
- and enable the "trailing whitespace selection" work-around.
-
- Tests: editing/selection/doubleclick-whitespace.html
-
- * editing/Editor.cpp:
- (WebCore::Editor::selectTrailingWhitespaceEnabled):
- * editing/Editor.h:
- * editing/Selection.cpp:
- (WebCore::Selection::includeTrailingWhitespace):
- * editing/Selection.h:
- * loader/EmptyClients.h:
- (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
- * page/EditorClient.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::selectClosestWordFromMouseEvent):
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Forgot to include WMLPageState.h in last commit.
-
- * wml/WMLPageState.h:
- (WebCore::WMLPageState::restrictDeckAccessToDomain):
- (WebCore::WMLPageState::restrictDeckAccessToPath):
-
-2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Oliver Hunt & Eric Seidel.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22431
-
- Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.
-
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLAccessElement.cpp: Added.
- (WebCore::WMLAccessElement::WMLAccessElement):
- (WebCore::WMLAccessElement::parseMappedAttribute):
- * wml/WMLAccessElement.h: Added.
- * wml/WMLTagNames.in:
- * wml/WMLPageState.h: Rename functions.
- (WebCore::WMLPageState::restrictDeckAccessToDomain):
- (WebCore::WMLPageState::restrictDeckAccessToPath):
- * wml/WMLVariables.cpp: Add new helper function.
- (WebCore::valueContainsVariableReference):
- * wml/WMLVariables.h:
- (WebCore::):
-
-2008-11-24 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22470
- remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL.
- (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
- * loader/FrameLoaderClient.h: Remove argument.
-
-2008-11-24 Finnur Thorarinsson <finnur.webkit@gmail.com>
-
- Reviewed by Darin Adler.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22432
-
- Add plumbing for tickmark support for the scrollbars. The painting code
- for the scrollbar just needed to call paintTickmarks at the right time
- and a default no-op implementation is provided, which the ports will
- need to override.
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::paintTickmarks):
-
-2008-11-24 Darin Fisher <darin@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22448
- Create an abstraction for JSC::SourceCode
-
- * WebCore.vcproj/WebCore.vcproj:
- * bindings/js/CachedScriptSourceProvider.h:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptSourceCode.h: Added.
- (WebCore::ScriptSourceCode::ScriptSourceCode):
- (WebCore::ScriptSourceCode::length):
- (WebCore::ScriptSourceCode::jsSourceCode):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::Workevn ScriptController::evaluate):
- * bindings/js/WorkerScriptController.h:
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElement::insertedIntoDocument):
- (WebCore::ScriptElement::childrenChanged):
- (WebCore::ScriptElementData::evaluateScript):
- (WebCore::ScriptElementData::notifyFinished):
- * dom/ScriptElement.h:
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::workerThread):
- * dom/WorkerThread.h:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::endElementNs):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseEndElement):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::scriptHandler):
- (WebCore::HTMLTokenizer::scriptExecution):
- (WebCore::HTMLTokenizer::notifyFinished):
- * html/HTMLTokenizer.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeScript):
- * loader/FrameLoader.h:
-
-2008-11-24 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - finish https://bugs.webkit.org/show_bug.cgi?id=22295
- track which history items are from page load failures
-
- * WebCore.base.exp: Exported new function.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
- * loader/DocumentLoader.h: Ditto.
-
-2008-11-24 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class
- https://bugs.webkit.org/show_bug.cgi?id=22461
-
- Changing AccessibilityListBox to use its parent's signature for hit testing
-
- * page/AccessibilityListBox.cpp:
- (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- * page/AccessibilityListBox.h:
-
-2008-11-24 Simon Fraser <simon.fraser@apple.com>
-
- Fix Windows build: selectionRect() -> selectionBounds().
-
- * page/win/FrameCGWin.cpp:
- (WebCore::imageFromSelection):
-
-2008-11-24 Glenn Wilson <gwilson@chromium.org>
-
- Reviewed by Darin Adler.
-
- http://bugs.webkit.org/show_bug.cgi?id=18703
- "Changing the 'size' property on a text input does not affect its length"
-
- Text fields would not repaint themselves after having their "size"
- attributes modified. This fix tells the object to recalculate its
- width and repaint itself when its "size" attribute is parsed.
-
- Test: fast/js/text-field-resize.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
-
-2008-11-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- Followup from changes for https://bugs.webkit.org/show_bug.cgi?id=22433
-
- Make RenderView::selectionRect() private to cause compile-time
- errors if someone tries to call it.
-
- * rendering/RenderView.h:
-
-2008-11-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- Via: https://bugs.webkit.org/show_bug.cgi?id=22433
-
- Rename RenderView::selectionRect() to selectionBounds(), to remove
- longstanding ambiguity with the base class selectionRect() method.
- Do the same on Frame for consistency with RenderView. Assert
- that RenderView::selectionRect() is never called.
-
- * WebCore.base.exp:
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::focusedOrActiveStateChanged):
- * page/DragController.cpp:
- (WebCore::dragLocForSelectionDrag):
- * page/Frame.cpp:
- (WebCore::Frame::selectionBounds):
- (WebCore::Frame::revealSelection):
- * page/Frame.h:
- * page/mac/FrameMac.mm:
- (WebCore::Frame::selectionImage):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::selectionRect):
- (WebCore::RenderView::selectionBounds):
- * rendering/RenderView.h:
-
-2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
- https://bugs.webkit.org/show_bug.cgi?id=22441
-
- - Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of
- an AtomicString.
-
- - Updated the elements' constructors and the callers to reflect the previous change.
-
- * dom/Document.cpp:
- (WebCore::Document::createElement):
- * html/HTMLDocument.cpp:
- (WebCore::HTMLDocument::createElement):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::cloneNode):
- * html/HTMLElementFactory.cpp:
- (WebCore::htmlConstructor):
- (WebCore::headConstructor):
- (WebCore::bodyConstructor):
- (WebCore::baseConstructor):
- (WebCore::linkConstructor):
- (WebCore::metaConstructor):
- (WebCore::styleConstructor):
- (WebCore::titleConstructor):
- (WebCore::frameConstructor):
- (WebCore::framesetConstructor):
- (WebCore::iframeConstructor):
- (WebCore::formConstructor):
- (WebCore::buttonConstructor):
- (WebCore::inputConstructor):
- (WebCore::isindexConstructor):
- (WebCore::fieldsetConstructor):
- (WebCore::keygenConstructor):
- (WebCore::labelConstructor):
- (WebCore::legendConstructor):
- (WebCore::optgroupConstructor):
- (WebCore::optionConstructor):
- (WebCore::selectConstructor):
- (WebCore::textareaConstructor):
- (WebCore::dlConstructor):
- (WebCore::ulConstructor):
- (WebCore::olConstructor):
- (WebCore::dirConstructor):
- (WebCore::menuConstructor):
- (WebCore::liConstructor):
- (WebCore::blockquoteConstructor):
- (WebCore::divConstructor):
- (WebCore::headingConstructor):
- (WebCore::hrConstructor):
- (WebCore::paragraphConstructor):
- (WebCore::preConstructor):
- (WebCore::basefontConstructor):
- (WebCore::fontConstructor):
- (WebCore::modConstructor):
- (WebCore::anchorConstructor):
- (WebCore::imageConstructor):
- (WebCore::mapConstructor):
- (WebCore::areaConstructor):
- (WebCore::canvasConstructor):
- (WebCore::appletConstructor):
- (WebCore::embedConstructor):
- (WebCore::objectConstructor):
- (WebCore::paramConstructor):
- (WebCore::scriptConstructor):
- (WebCore::tableConstructor):
- (WebCore::tableCaptionConstructor):
- (WebCore::tableColConstructor):
- (WebCore::tableRowConstructor):
- (WebCore::tableCellConstructor):
- (WebCore::tableSectionConstructor):
- (WebCore::brConstructor):
- (WebCore::quoteConstructor):
- (WebCore::marqueeConstructor):
- (WebCore::audioConstructor):
- (WebCore::videoConstructor):
- (WebCore::sourceConstructor):
- (WebCore::HTMLElementFactory::createHTMLElement):
- * html/HTMLElementFactory.h:
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::getNode):
-
-2008-11-24 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- https://bugs.webkit.org/show_bug.cgi?id=22444
-
- Correct bad default constructor for Cairo FontPlatformData so that
- the m_scaledFont member is initialized. Previously this would be
- set to 0xbaadf00d, which would result in infinite loops while
- attempting to deal with the font cache.
-
- * platform/graphics/win/FontPlatformData.h:
- (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
+ (WebCore::CachedResource::canUseCacheValidator):
+ (WebCore::CachedResource::mustRevalidate):
-2008-11-24 Alexey Proskuryakov <ap@webkit.org>
+2009-06-23 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=22455
- Add support for Worker.terminate()
-
- Test: fast/workers/worker-terminate.html
-
- * dom/Worker.idl:
- * dom/Worker.cpp:
- * dom/Worker.h:
- Added terminate().
-
- * dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked
- to terminate (this is not mentioned in draft spec, but makes sense anyway).
- (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was
- asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount
- to only track messages that were posted to worker thread, avoiding a leak if the script
- could not be loaded.
- (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating.
- (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for.
- (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context
- was destroyed, the worker object may still be alive now, so don't delete self in this case.
- (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or
- remember to stop it when it is created.
- (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity
- if the thread asked to stop anyway.
- (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
-
- * dom/WorkerThread.cpp:
- * dom/WorkerThread.h:
- Fixed a race condition in stop().
-
-2008-11-24 Alexey Proskuryakov <ap@webkit.org>
+ - fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath
+ EventHandler::passMouseDownEventToWidget()
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=22439
- Won't load stylesheets with filenames less than 2 characters long in xhtml.
-
- Test: http/tests/misc/single-character-pi-stylesheet.xhtml
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passMouseDownEventToWidget): Surround the
+ -mouseDown: call with calls to Widget::beforeMouseDown() and
+ Widget::afterMouseDown(), which prevent the widget's view hierarchy from
+ being removed from its parent view while the scroller is tracking the
+ mouse.
- * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- Fix up the logic.
+2009-06-23 Sam Weinig <sam@webkit.org>
-2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>
+ Reviewed by Dave Hyatt.
- Reviewed by Mark Rowe.
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
+ Add initial implementation of DataGridDataSource
- [Gtk+] Add configure option to enable Web Workers and enable it by default
+ - Initial implementation only supports the initialize callback function.
- Add --enable-workers to the buildsystem (used by build-webkit) add
- the to be build files to the GNUmakefile.am and change build-webkit
- to enable Web Workers by default.
+ Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html
+ * WebCore.xcodeproj/project.pbxproj:
* GNUmakefile.am:
-
-2008-11-24 Alexey Proskuryakov <ap@webkit.org>
-
- Build fix (for Windows Cairo port?)
-
- * page/DOMWindow.idl: Use ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as
- the ENABLE macro is not available in idls.
-
-2008-11-22 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22421
- Added ScriptValue to Visual Studio and XCode projects.
-
+ * WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSDataGridDataSource.cpp: Added.
+ (WebCore::JSDataGridDataSource::JSDataGridDataSource):
+ (WebCore::JSDataGridDataSource::~JSDataGridDataSource):
+ (WebCore::JSDataGridDataSource::initialize):
+ * bindings/js/JSDataGridDataSource.h: Added.
+ (WebCore::JSDataGridDataSource::create):
+ (WebCore::JSDataGridDataSource::isJSDataGridDataSource):
+ (WebCore::JSDataGridDataSource::jsDataSource):
+ (WebCore::asJSDataGridDataSource):
+ * bindings/js/JSHTMLDataGridElementCustom.cpp: Added.
+ (WebCore::JSHTMLDataGridElement::listener):
+ (WebCore::JSHTMLDataGridElement::setListener):
+ * html/DataGridDataSource.h: Added.
+ (WebCore::DataGridDataSource::~DataGridDataSource):
+ (WebCore::DataGridDataSource::isJSDataGridDataSource):
+ * html/HTMLDataGridElement.cpp:
+ (WebCore::HTMLDataGridElement::HTMLDataGridElement):
+ (WebCore::HTMLDataGridElement::setDataSource):
+ (WebCore::HTMLDataGridElement::initializationTimerFired):
+ * html/HTMLDataGridElement.h:
+ (WebCore::HTMLDataGridElement::dataSource):
+ * html/HTMLDataGridElement.idl:
+
+2009-06-23 Ryosuke Niwa <rniwa@google.com>
-2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Holger Freyther.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22426
-
- Add WMLInstrinsicEvent/EventHandler implementation. Code not yet used.
-
- * WebCore.xcodeproj/project.pbxproj:
- * wml/WMLIntrinsicEvent.cpp: Added.
- (WebCore::createTaskElement):
- (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
- * wml/WMLIntrinsicEvent.h: Added.
- (WebCore::WMLIntrinsicEvent::create):
- (WebCore::WMLIntrinsicEvent::createWithTask):
- (WebCore::WMLIntrinsicEvent::taskElement):
- * wml/WMLIntrinsicEventHandler.cpp: Added.
- (WebCore::WMLIntrinsicEventHandler::WMLIntrinsicEventHandler):
- (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
- (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
- (WebCore::WMLIntrinsicEventHandler::hasIntrinsicEvent):
- * wml/WMLIntrinsicEventHandler.h: Added.
- (WebCore::):
-
-2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Holger Freyther.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22423
-
- Add <go> stub implementation. Add complete <prev>/<refresh> and <setvar> implementation.
- Activate code handling <setvar> registration in WMLTaskElement.
-
- * wml/WMLGoElement.cpp: Added.
- (WebCore::WMLGoElement::WMLGoElement):
- (WebCore::WMLGoElement::~WMLGoElement):
- (WebCore::WMLGoElement::parseMappedAttribute):
- (WebCore::WMLGoElement::executeTask):
- * wml/WMLGoElement.h: Added.
- * wml/WMLPrevElement.cpp: Added.
- (WebCore::WMLPrevElement::WMLPrevElement):
- (WebCore::WMLPrevElement::~WMLPrevElement):
- (WebCore::WMLPrevElement::executeTask):
- * wml/WMLPrevElement.h: Added.
- * wml/WMLRefreshElement.cpp: Added.
- (WebCore::WMLRefreshElement::WMLRefreshElement):
- (WebCore::WMLRefreshElement::~WMLRefreshElement):
- (WebCore::WMLRefreshElement::executeTask):
- * wml/WMLRefreshElement.h: Added.
- * wml/WMLSetvarElement.cpp: Added.
- (WebCore::WMLSetvarElement::WMLSetvarElement):
- (WebCore::WMLSetvarElement::~WMLSetvarElement):
- (WebCore::WMLSetvarElement::parseMappedAttribute):
- (WebCore::WMLSetvarElement::insertedIntoDocument):
- (WebCore::WMLSetvarElement::name):
- (WebCore::WMLSetvarElement::value):
- * wml/WMLSetvarElement.h: Added.
- * wml/WMLTagNames.in:
- * wml/WMLTaskElement.cpp:
- (WebCore::WMLTaskElement::registerVariableSetter):
- (WebCore::WMLTaskElement::storeVariableState):
- * wml/WMLTaskElement.h:
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Forgot to include WMLPageState.* in the last commit.
-
- * wml/WMLPageState.cpp:
- (WebCore::WMLPageState::setNeedCheckDeckAccess):
- * wml/WMLPageState.h:
- (WebCore::WMLPageState::storeVariables):
-
-2008-11-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22397
- Worker threads are not destroyed if running a JS loop
-
- Since the event loop is not ever entered again in this case, the fix necessarily involves
- some shared data hackery.
-
- * dom/WorkerThread.cpp: (WebCore::WorkerThread::stop):
- * dom/WorkerThread.h:
- Added a stop() method, which asks the thread to exit as soon as possible. In the future, it
- may need to abort other kinds of synchronous processing, such as importScripts or XHR.
-
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::WorkerScriptController):
- (WebCore::WorkerScriptController::evaluate):
- (WebCore::WorkerScriptController::forbidExecution):
- * bindings/js/WorkerScriptController.h:
- Added a forbidExecution() method, which interrupts currently running JS, and makes any
- future calls to evaluate() return immediately.
-
- * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
- Call WorkerThread::stop().
-
-2008-11-21 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Improve wx image drawing performance considerably when using wxGraphicsContext
- by avoiding unnecessary copies and drawing.
-
- https://bugs.webkit.org/show_bug.cgi?id=22404
-
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
- (WebCore::BitmapImage::drawPattern):
-
-
-2008-11-21 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Implementation of AffineTransform::mapRect for wx.
-
- https://bugs.webkit.org/show_bug.cgi?id=22401
-
- * platform/graphics/wx/AffineTransformWx.cpp:
- (WebCore::AffineTransform::mapRect):
-
-2008-11-21 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
+ Reviewed by Justin Garcia.
- Change link editing behavior to match TextEdit and MS Word when editing before and after
- a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we
- used to, so it's difficult to get out of link editing mode):
- When inserting before or after a link, always insert content outside of the link. This
- makes it impossible to get stuck in link editing mode, while making it slightly more
- difficult to edit link labels. WebKit editors that care about this can add UI for editing
- link labels, like GMail and GoogleDocs have done. We never actually had any bugs complaining
- about how it was difficult to edit link labels at the start/end, the code was just introduced
- with another bug fix without much thought.
+ Undo the changeset 21212 to fix the regression bug 14062.
+ The changeset 21212 attempted to fix rdar://problem/5002441.
+ The changeset 21212 modified InsertTextCommand::input so as to convert
+ all spaces in text to non-breaking spaces for rdar://problem/5002441.
+ However, the bug was originally caused by rebalanceWhitespaceAt
+ and this workaround introduced a regression bug 14062.
+ Because rebalanceWhitespaceAt appears to behave correctly now,
+ the workaround introduced in 21212 is no longer needed.
- Don't remember removed links anymore, no other editor does this and it made it
- difficult/impossible to get out of link editing mode. This code was added to fix
- <rdar://problem/4069359>, which is fixed instead by removing the styles from an
- enclosing anchor element from those styles that we remember when we delete content.
+ Test: editing/inserting/space-after-removeformat.html
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- * editing/CompositeEditCommand.h:
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::removeEnclosingAnchorStyle):
- (WebCore::DeleteSelectionCommand::saveTypingStyleState):
- (WebCore::DeleteSelectionCommand::doApply):
- * editing/DeleteSelectionCommand.h:
- * editing/EditCommand.cpp:
- (WebCore::EditCommand::apply):
- * editing/Editor.cpp:
- (WebCore::Editor::appliedEditing):
* editing/InsertTextCommand.cpp:
- (WebCore::InsertTextCommand::prepareForTextInsertion):
(WebCore::InsertTextCommand::input):
- * editing/RemoveFormatCommand.cpp:
- (WebCore::RemoveFormatCommand::doApply):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setSelection):
- * editing/SelectionController.h:
-
-2008-11-21 Alice Liu <alice.liu@apple.com>
-
- Rubber-stamped by Dan Bernstein.
-
- fixed <rdar://6340771> crashing on print preview
-
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- (WebCore::GraphicsContext::drawWindowsBitmap):
-
-2008-11-21 Darin Fisher <darin@chromium.org>
-
- Reviewed by Geoffrey Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=22390
- Abstract away JSC:: usage in WebCore/xml
-
- * bindings/js/ScriptString.h: Added.
- (WebCore::ScriptString::ScriptString):
- (WebCore::ScriptString::operator JSC::UString):
- (WebCore::ScriptString::isNull):
- (WebCore::ScriptString::size):
- (WebCore::ScriptString::operator=):
- (WebCore::ScriptString::operator+=):
- * inspector/InspectorController.cpp:
- (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
- (WebCore::InspectorResource::setXMLHttpRequestProperties):
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- * inspector/InspectorController.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseText):
- (WebCore::XMLHttpRequest::clearResponse):
- (WebCore::XMLHttpRequest::dropProtection):
- (WebCore::XMLHttpRequest::didFinishLoading):
- (WebCore::XMLHttpRequest::didReceiveData):
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::setLastSendURL):
-
-2008-11-21 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Destroy script decoded data on a zero-delay timer after
- decoding. This means we now have no decoded script data
- at the end of Membuster.
-
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::CachedScript):
- (WebCore::CachedScript::allClientsRemoved):
- (WebCore::CachedScript::script):
- (WebCore::CachedScript::decodedDataDeletionTimerFired):
- * loader/CachedScript.h:
-
-2008-11-21 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=22159
-
- RenderBox::absoluteClippedOverflowRect() needs to inflate the rect by
- maximalOutlineSize(), since a child might have an outline which projects
- outside the parent overflowRect().
- We also need to ensure that maximalOutlineSize() is updated early in styleDidChange,
- so that it is valid for these repaints.
+2009-06-23 Beth Dakin <bdakin@apple.com>
- Test: fast/repaint/outline-child-repaint.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::absoluteClippedOverflowRect):
-
-2008-11-21 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk, Qt, and Wx build fix.
-
- Add LinkHash.cpp in the build scripts.
- Add LinkHash.h to Gtk's build script.
-
- LinkHash.cpp/h was introduced in r38661.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCoreSources.bkl:
+ Reviewed by Dave Hyatt.
-2008-11-21 Sam Weinig <sam@webkit.org>
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
+ elements width can't be changed with javascript
- Reviewed by Dan Bernstein.
+ This patch both fixes setting the width attribute directly in
+ JavaScript, and setting the width on the style attribute.
- Third step in https://bugs.webkit.org/show_bug.cgi?id=22394
- Be more eager in destroying script decoded data
+ * html/HTMLTableColElement.cpp:
+ (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a
+ new width, call setNeedsLayoutAndPrefWidthsRecalc()
- Destroy the decoded data when all clients are removed from a CachedScript.
+ Call calcPrefWidths() on the table cols.
+ * rendering/AutoTableLayout.cpp:
+ (WebCore::AutoTableLayout::recalcColumn):
+ * rendering/FixedTableLayout.cpp:
+ (WebCore::FixedTableLayout::calcWidthArray):
+
+ Call layoutIfNeeded on the table cols.
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::layout):
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::allClientsRemoved):
- * loader/CachedScript.h:
- (WebCore::CachedScript::allClientsRemoved):
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new
+ table() convenience function.
+ (WebCore::RenderTableCol::calcPrefWidths): Just call
+ setPrefWidthsDirty(false) on ourself and our children.
+ (WebCore::RenderTableCol::table):
+ * rendering/RenderTableCol.h:
-2008-11-21 Pierre-Olivier Latour <pol@apple.com>
+2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
- WebKit should be using Device RGB colorspace everywhere for
- consistency.
-
- https://bugs.webkit.org/show_bug.cgi?id=22300
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (CreateCGColorIfDifferent):
- * platform/graphics/mac/ColorMac.h:
- * platform/graphics/mac/ColorMac.mm:
- (WebCore::nsColor):
- (+[WebCoreControlTintObserver controlTintDidChange]):
- * rendering/RenderThemeMac.mm:
- (WebCore::convertNSColorToColor):
- (WebCore::menuBackgroundColor):
-
-2008-11-20 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 22388: Add JSInterfaceName to the .in files
- https://bugs.webkit.org/show_bug.cgi?id=22388
-
- Add JSInterfaceName that is similar to interfaceName but
- for the JS wrappers. JSInterfaceName is always equal to interfaceName
- unless explicitly set.
-
- * dom/make_names.pl:
- * html/HTMLTagNames.in:
- * svg/svgtags.in:
-
-2008-11-21 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Second step in https://bugs.webkit.org/show_bug.cgi?id=22394
- Be more eager in destroying script decoded data
-
- Use a new CachedScriptSourceProvider to keep CachedScripts as
- CachedScripts, even down into JSC. This has the added benefit
- of showing the CachedScripts as live in the Caches window.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/CachedScriptSourceProvider.h: Added.
- (WebCore::CachedScriptSourceProvider::create):
- (WebCore::CachedScriptSourceProvider::~CachedScriptSourceProvider):
- (WebCore::CachedScriptSourceProvider::getRange):
- (WebCore::CachedScriptSourceProvider::data):
- (WebCore::CachedScriptSourceProvider::length):
- (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- (WebCore::makeSource):
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::notifyFinished):
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished):
-
-2008-11-21 Brett Wilson <brettw@chromium.org>
-
- Fix debug-only build bustage due to a typo in an assert, and add new
- files to the Windows build.
-
- * Info.plist:
- * WebCore.vcproj/WebCore.vcproj:
- * platform/LinkHash.h:
- (WebCore::LinkHashHash::avoidDeletedValue):
-
-2008-11-20 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=22131
-
- Factor out visited link hashing and types into a new file, LinkHash.
- This also changes the hash type to 64 bits, but does not actually use
- the extra bits yet.
-
- * WebCore.xcodeproj/project.pbxproj:
- (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
- (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
- * css/CSSStyleSelector.h:
- (WebCore::CSSStyleSelector::visitedStateChanged):
- * dom/Document.cpp:
- * dom/Document.h:
- * page/Page.cpp:
- (WebCore::Page::visitedStateChanged):
- * page/Page.h:
- * page/PageGroup.cpp:
- (WebCore::PageGroup::isLinkVisited):
- (WebCore::PageGroup::addVisitedLink):
- * page/PageGroup.h:
- * platform/LinkHash.cpp: Added.
- (WebCore::findSlashDotDotSlash):
- (WebCore::findSlashSlash):
- (WebCore::findSlashDotSlash):
- (WebCore::containsColonSlashSlash):
- (WebCore::cleanPath):
- (WebCore::matchLetter):
- (WebCore::needsTrailingSlash):
- (WebCore::visitedLinkHash):
- * platform/LinkHash.h: Added
- (WebCore::LinkHashHash::hash):
- (WebCore::LinkHashHash::equal):
- (WebCore::LinkHashHash::avoidDeletedValue):
-
-2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- No need to use getElementsByTagNameNS() in WML documents. Revert to using getElementByTagName() again.
-
- * wml/WMLPElement.cpp:
- (WebCore::WMLPElement::insertedIntoDocument):
-
-2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix some coding style/formatting issues in WMLAElement.
-
- * wml/WMLAElement.cpp:
- (WebCore::WMLAElement::parseMappedAttribute):
- (WebCore::WMLAElement::defaultEventHandler):
- * wml/WMLAElement.h:
-
-2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22399
-
- Implement <anchor> support for WML, add WMLVariables file containing helper functions
- for variable support, and a WMLTaskElement base class for WMLPrev/Go/RefreshElement.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::linkAttribute):
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::absoluteImageURL):
- (WebCore::HitTestResult::absoluteLinkURL):
- (WebCore::HitTestResult::isLiveLink):
- * wml/WMLAnchorElement.cpp: Added.
- (WebCore::WMLAnchorElement::WMLAnchorElement):
- (WebCore::WMLAnchorElement::~WMLAnchorElement):
- (WebCore::WMLAnchorElement::defaultEventHandler):
- * wml/WMLAnchorElement.h: Added.
- (WebCore::WMLAnchorElement::registerTask):
- * wml/WMLTagNames.in:
- * wml/WMLTaskElement.cpp: Added.
- (WebCore::WMLTaskElement::WMLTaskElement):
- (WebCore::WMLTaskElement::~WMLTaskElement):
- (WebCore::WMLTaskElement::insertedIntoDocument):
- (WebCore::WMLTaskElement::addVariableSetter):
- (WebCore::WMLTaskElement::removeVariableSetter):
- (WebCore::WMLTaskElement::storeVariableState):
- * wml/WMLTaskElement.h: Added.
- * wml/WMLVariables.cpp: Added.
- (WebCore::isValidVariableCharacter):
- (WebCore::isValidVariableReferenceCharacter):
- (WebCore::isValidVariableName):
- (WebCore::substituteVariableReferences):
- * wml/WMLVariables.h: Added.
- (WebCore::):
-
-2008-11-21 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Rubber-stamped by Alexey Proskuryakov.
-
- Build fix when building without WORKERS on non-POSIX, non-WINDOWS
- machine.
-
- Spotted by Mario Bensi.
-
- * platform/text/TextCodecICU.cpp:
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- First step in https://bugs.webkit.org/show_bug.cgi?id=22394
- Be more eager in destroying script decoded data
-
- Pass data to be used in script execution around as JSC::SourceCode instead
- of a source, url, and starting line.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/ScriptController.h:
- * bindings/js/StringSourceProvider.h:
- (WebCore::makeSource):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- * bindings/js/WorkerScriptController.h:
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElement::insertedIntoDocument):
- (WebCore::ScriptElement::childrenChanged):
- (WebCore::ScriptElementData::evaluateScript):
- (WebCore::ScriptElementData::notifyFinished):
- * dom/ScriptElement.h:
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::workerThread):
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::endElementNs):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseEndElement):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::scriptHandler):
- (WebCore::HTMLTokenizer::scriptExecution):
- (WebCore::HTMLTokenizer::notifyFinished):
- * html/HTMLTokenizer.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeScript):
- * loader/FrameLoader.h:
-
-2008-11-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22392
- REGRESION: XMLHttpRequest.responseText does unnecessary trip though WebCore::String
-
- - Use jsOwnedStringOrNull to avoid conversion to WebCore::String.
-
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::responseText):
- * xml/XMLHttpRequest.idl:
-
-2008-11-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=19623
-
- When an non-layer object gained a transform, it would only repaint
- the bounds of the new layer, which could result in redraw artifacts
- if the new layer was smaller. So if we're gaining a transform, we
- repaint.
-
- Test: fast/repaint/change-transform.html
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleWillChange):
-
-2008-11-20 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
+ Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
+ keyword values. When diff is called on a CSSStyleDeclaration, we check
+ the keywordSize to see if font-size matches a keyword value.
+
+ This ensures that when we diff a CSSMutableStyleDeclaration returned from
+ copyInheritableProperties on a CSSComputedStyleDeclaration that we
+ correctly identify matching font-sizes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26279
- Fix for <rdar://problem/6111436> Support upload progress events on Windows
+ Test: editing/inserting/font-size-clears-from-typing-style.html
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::didSendBodyData): Added.
- (WebCore::ResourceHandle::start): Hook up didSendBodyData callback.
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
+ * css/CSSComputedStyleDeclaration.h:
+ * css/CSSStyleDeclaration.cpp:
+ (WebCore::CSSStyleDeclaration::cssPropertyMatches):
+ (WebCore::CSSStyleDeclaration::diff):
+ * css/CSSStyleDeclaration.h:
-2008-11-20 Justin Garcia <justin.garcia@apple.com>
+2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
- <rdar://problem/2610675> Blank line that is quoted can't be deleted
+ <rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
+ add a blank line to pasted Facebook content (under
+ CompositeEditCommand::positionAvoidingSpecialElementBoundary)
- If the caret is in an empty quoted paragraph, and either there is nothing before that
- paragraph, or what is before is unquoted, and the user presses delete, unquote that
- paragraph.
+ - Just added null checks and I will create a new bug to prevent the
+ bad behavior.
* editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Added.
- Removes the line break that holds open an empty paragraph and then attempts to
- prune the blockquote(s) that held that line break in case they have been emptied
- out. Places a line break to create in empty unquoted paragraph in place of the
- quoted one that was removed.
- * editing/CompositeEditCommand.h:
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteKeyPressed): Call breakOutOfEmptyBlockquotedParagraph.
- * editing/htmlediting.cpp:
- (WebCore::highestEnclosingNodeOfType): Added.
- * editing/htmlediting.h:
-
-2008-11-20 Dean Jackson <dino@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=21247
-
- Make transition shorthand property accept transition-delay.
-
- Test: transitions/transition-shorthand-delay.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseTransitionShorthand):
-
-2008-11-20 Dean Jackson <dino@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=22368
-
- Make sure pauseTransition API takes transition delay into account.
-
- Test: transitions/transition-drt-api-delay.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::pauseAtTime):
-
-2008-11-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=20368
-
- Implement getComputedStyle for animation properties. Remove individual
- computed values for transform-origin-x, transform-origin-y, and just
- return transform-origin instead. Return "none" for default animation-name,
- and fix the initial value.
-
- Tests: animations/computed-style.html
- transforms/computed-style-origin.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::):
- (WebCore::getDelayValue):
- (WebCore::getDurationValue):
- (WebCore::getTimingFunctionValue):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::initialAnimationName):
-
-2008-11-20 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- Preparation for:
- <rdar://problem/2610675> Blank line that is quoted can't be deleted
-
- To fix this we need to make changes to the code that creates selections to delete
- when the user does a backward or forward delete with a caret selection. For certain
- caret positions, we now want to remove something other than the standard "caret extended
- backward/forward by one unit". The problem is that there were two pieces of code
- responsible for doing this, one in Editor::deleteWithDirection, and another inside
- TypingCommand::deleteKeyPressed. The code in deleteWithDirection is a recent
- addition (r19172), and adding it there caused regressions because it prevented the
- code in deleteKeyPressed from ever running. The regressions were never caught because
- JS deletion uses deleteKeyPressed while manual deletion uses deleteWithDirection.
-
- This patch removes selection creation code from deleteWithDirection so that deleteKeyPressed
- can handle it. That required moving code to handle the kill ring down into deleteKeyPressed.
-
- Follow up patches will fix <rdar://problem/2610675>, and attempt to eliminate the rest of the
- discrepancies between the behavior of JS deletions and manual deletions, so that we
- have better test coverage.
-
- * editing/Editor.cpp:
- (WebCore::Editor::deleteWithDirection): Early return if m_frame->document() is null, instead
- of checking for that periodically throughout the function. There's really nothing to be done
- if it's null anyway.
- Move kill ring code down into deleteKeyPressed.
- * editing/Editor.h:
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::TypingCommand):
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- (WebCore::TypingCommand::doApply):
- * editing/TypingCommand.h:
- (WebCore::TypingCommand::create):
+ (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
-2008-11-20 Darin Adler <darin@apple.com>
+2009-06-23 Simon Fraser <simon.fraser@apple.com>
- Earlier version reviewed by Justin Garcia.
+ Build fix.
- - fix <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
+ Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
+ ACCELERATED_COMPOSITING is not defined.
- * editing/Editor.cpp:
- (WebCore::Editor::handleKeyboardEvent): Remove isContentEditable check -- keyboard events can be
- handled even when the selection is not in an editable area.
- (WebCore::Editor::handleInputMethodKeydown): Ditto.
+ * rendering/RenderLayer.cpp:
- * editing/EditorCommand.cpp: Changed the enabled rule for operations that change the selection to
- allow use when there's a selection even if it's not in an editable area. This includes commands
- like shift-arrow keys to extend the slection, but not commands like arrow keys to move the
- insertion point.
+2009-06-23 Simon Fraser <simon.fraser@apple.com>
-2008-11-20 Alexey Proskuryakov <ap@webkit.org>
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24863
+
+ Fix reflection painting on elements with compositing layers.
- Reviewed by Darin Adler.
+ Test: compositing/reflections/reflection-on-composited.html
- https://bugs.webkit.org/show_bug.cgi?id=22380
- Fix WorkerContext refcounting
+ * rendering/RenderLayer.h:
+ Add a new PaintLayerPaintingReflection flag which is set while painting inside
+ reflections.
+ (WebCore::RenderLayer::setPaintingInsideReflection):
+ Add a setter so that RenderLayerBacking can call it.
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::WorkerContext):
- * dom/WorkerContext.h:
- (WebCore::WorkerContext::script):
- (WebCore::WorkerContext::clearScript):
- Added a method to manually destroy WorkerScriptController.
+ * rendering/RenderLayer.cpp:
+ (WebCore::shouldDoSoftwarePaint):
+ Utility to clarify the logic of when a composited layer should do a software paint.
+
+ (WebCore::RenderLayer::paintLayer):
+ Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
+ Remove transform-related tests from the reflection-painting if test because they appear
+ to be unnecessary.
- * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
- Destroy WorkerScriptController to release any references to WorkerContext.
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ Add the code to paint reflections to the composited layer painting method.
+
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::paint):
+ Set the PaintLayerPaintingReflection flag.
-2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
+2009-06-23 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26643
+ Memory cache should respect Cache-Control: no-store
+
+ Make resources with Cache-Control: no-store uncacheable in the memory cache.
+ They get evicted immediately when all clients are gone and are always
+ reloaded from the server.
- Last part of bug 21106: .in format discussed changes
- https://bugs.webkit.org/show_bug.cgi?id=21106
-
- - Renamed isAudioHack to wrapperOnlyIfMediaIsAvailable as requested.
-
- - Cleaned up additionnal function parameters that were unneeded.
-
- * dom/make_names.pl:
- * html/HTMLTagNames.in:
-
-2008-11-20 Alexey Proskuryakov <ap@webkit.org>
+ Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.
- Reviewed by Darin Adler.
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::removeClient):
+ (WebCore::CachedResource::canUseCacheValidator):
+ (WebCore::CachedResource::mustRevalidate):
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::ResourceResponseBase):
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives):
+ (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
+ * platform/network/ResourceResponseBase.h:
- https://bugs.webkit.org/show_bug.cgi?id=22383
- Worker tests spill error messages over to consequent tests
+2009-06-23 Brady Eidson <beidson@apple.com>
- * dom/Worker.cpp: (WebCore::Worker::Worker):
- Raise an exception immediately if URL is empty. Dcoument::completeURL() returns document URL
- in this case, and there is no sense in starting a thread and trying to parse document source
- as JavaScript.
+ Windows build fix.
- * bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- Return quickly if toString() raised an exception.
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::play):
+ (QTMovieWin::pause):
+ (QTMovieWin::setRate):
+ (QTMovieWin::setCurrentTime):
-2008-11-19 Simon Fraser <simon.fraser@apple.com>
+2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson.
- https://bugs.webkit.org/show_bug.cgi?id=22190
-
- Fix the painting and event handling in transformed search fields.
- When painting the cancel and results button parts, get the rect from AppKit
- relative to the input bounds (rather than in absolute coords), then convert
- it into the coords of the part's renderer (which is the one that is painting).
- To do this we need to compute an offset relative to some container, so expose
- a method on RenderObject for that.
-
- Also fix the location at which the search popup shows up to take transforms
- into account, and fix the math that is used to figure out if the search
- results button, or the cancel button should get the mouse events.
-
- Test: fast/forms/search-transformed.html
-
- * rendering/RenderBox.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::offsetFromContainer):
- * rendering/RenderObject.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::forwardEvent):
- (WebCore::RenderTextControl::showPopup):
- * rendering/RenderThemeMac.h:
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::convertToPaintingRect):
- (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
- (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
-
-2008-11-20 Joerg Bornemann <joerg.bornemann@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Steps towards making the the Qt port of WebKit compile on Windows CE
-
- https://bugs.webkit.org/show_bug.cgi?id=20746
-
- * WebCore.pro: Various fixes to include windows specific build options
- also in the Windows CE build.
- * loader/icon/IconDatabase.cpp: Removed unnecessary errno.h inclusion.
- * platform/FileSystem.h: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::getWindowsContext): SetWorldTransform is
- not available on CE.
- * platform/graphics/qt/PathQt.cpp: Added local definition of M_PI.
- * platform/qt/FileSystemQt.cpp: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
- * platform/qt/KeyboardCodes.h: Extend #idefs to define the missing OEM
- constants on CE.
- * platform/qt/TemporaryLinkStubs.cpp: Added stubs for plugins.
- * platform/text/RegularExpression.cpp: Removed unused sys/types.h and
- pcre.h inclusions.
- * platform/win/SystemTimeWin.cpp:
- (WebCore::userIdleTime): Don't use GetLastInputInfo on CE, it does not
- exist.
-
-2008-11-20 Antti Koivisto <antti@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=22379
- Make CSSOM use less memory
-
- - Shrink CSSProperty by half by using bitfields.
- - Get rid of m_strictParsing field in StyleBase by moving it up to CSSStyleSheet
- and CSSMutableStyleDeclaration. This reduces size of many highly popular objects.
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- (WebCore::CSSMutableStyleDeclaration::operator=):
- * css/CSSMutableStyleDeclaration.h:
- (WebCore::CSSMutableStyleDeclaration::setStrictParsing):
- (WebCore::CSSMutableStyleDeclaration::useStrictParsing):
- * css/CSSProperty.h:
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::CSSStyleSheet):
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::setStrictParsing):
- (WebCore::CSSStyleSheet::useStrictParsing):
- * css/StyleBase.h:
- (WebCore::StyleBase::useStrictParsing):
- (WebCore::StyleBase::StyleBase):
-
-2008-11-19 Darin Fisher <darin@chromium.org>
-
- Fix bustage.
-
- https://bugs.webkit.org/show_bug.cgi?id=22373
- Ports busted by addition of ScriptValue.{h,cpp}
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::performRequest):
-
-2008-11-19 Darin Fisher <darin@chromium.org>
-
- Bustage fix.
-
- https://bugs.webkit.org/show_bug.cgi?id=22373
- Ports busted by addition of ScriptValue.{h,cpp}
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCoreSources.bkl:
- * dom/XMLTokenizerQt.cpp:
- * plugins/PluginView.cpp:
+ <rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
+ after manually quoting blank line then hitting return
-2008-11-19 Darin Fisher <darin@chromium.org>
+ If the insertion point is both the begining and ending visible position
+ then we need to insert at the end instead of the begining, which is what
+ would normally happen if the insertion point was as the begining.
- Reviewed by Geoff Garen.
-
- https://bugs.webkit.org/show_bug.cgi?id=22345
- Define ScriptValue as a thin container for a JSC::Value*.
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/ScheduledAction.cpp:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptValue.cpp: Added.
- (WebCore::ScriptValue::getString):
- * bindings/js/ScriptValue.h: Added.
- (WebCore::ScriptValue::ScriptValue):
- (WebCore::ScriptValue::jsValue):
- * dom/ScriptElement.cpp:
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizerLibxml2.cpp:
- * html/HTMLTokenizer.cpp:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeIfJavaScriptURL):
- (WebCore::FrameLoader::executeScript):
- * loader/FrameLoader.h:
-
-2008-11-19 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Justin Garcia.
-
- Fix for <rdar://problem/5472507> Remove color property when a user
- sets color to black
-
- This patch prevents us from inserting font nodes during the
- ApplyStyleCommand if they will not change the computed style of an
- element.
-
- * editing/ApplyStyleCommand.cpp:
- (WebCore::fontColorChangesComputedStyle):
- (WebCore::fontSizeChangesComputedStyle):
- (WebCore::fontFaceChangesComputedStyle):
- (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
-2008-11-19 Simon Fraser <simon.fraser@apple.com>
+2009-06-23 Brady Eidson <beidson@apple.com>
- Reviewed by Antti Koivisto
+ Reviewed by Sam Weinig, and looked over by Eric Carlson.
- https://bugs.webkit.org/show_bug.cgi?id=22111
+ <rdar://problem/6980466> Media elements should provide option for changing pitch correction
- Fix hit testing in controls on transformed video elements
- by replacing absoluteBoundingBoxRect().contains() with
- code that maps the point into local coords, taking
- transforms into account.
+ Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.
- Test: media/video-controls-transformed.html
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation
+ property (Quicktime on Mac and Win) have had it on by default, so continue that default for now.
+ (WebCore::HTMLMediaElement::loadResource):
+ (WebCore::HTMLMediaElement::webkitPreservesPitch):
+ (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
+ * html/HTMLMediaElement.h:
+ * html/HTMLMediaElement.idl:
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::setPreservesPitch):
+ (WebCore::MediaPlayer::MediaPlayer):
+ (WebCore::MediaPlayer::preservesPitch):
+ (WebCore::MediaPlayer::setPreservesPitch):
* platform/graphics/MediaPlayer.h:
- * rendering/RenderMedia.cpp:
- (WebCore::rendererContainsPoint):
- (WebCore::RenderMedia::forwardEvent):
-
-2008-11-19 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=22348
-
- Need to educate style sharing about autofill, so that style does not
- get shared between input elements that are autofilled, and those
- that are not. Setting autofill should also do a setChanged on the node.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::canShareStyleWithElement):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * dom/Node.h:
- (WebCore::Node::isAutofilled):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setAutofilled):
- * html/HTMLInputElement.h:
- (WebCore::HTMLInputElement::isAutofilled):
-
-2008-11-19 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=22349
-
- Clear the subresource loader client when the client is removed in
- response to a 304 (not modified). This prevents an inconsistent state
- where the loader thinks it's active and the loader::Host doesn't.
-
- * loader/loader.cpp:
- (WebCore::Loader::Host::didReceiveResponse):
-
-2008-11-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22355
- Systematize code for replacing global constructors
-
- Test: fast/workers/worker-replace-global-constructor.html
-
- * bindings/js/JSDOMWindowBase.cpp:
- (setJSDOMWindowBaseEvent): Changed to put the value as property, matching what generated
- code for global constructor setters does.
- (setJSDOMWindowBaseAudio): Ditto.
- (setJSDOMWindowBaseImage): Ditto.
- (setJSDOMWindowBaseMessageChannel): Ditto.
- (setJSDOMWindowBaseOption): Ditto.
- (setJSDOMWindowBaseWorker): Ditto.
- (setJSDOMWindowBaseXMLHttpRequest): Ditto.
- (setJSDOMWindowBaseXSLTProcessor): Ditto.
- (WebCore::JSDOMWindowBase::put): Removed special cases for global constructors.
-
- * bindings/js/JSWorkerContext.cpp:
- (WebCore::JSWorkerContext::getOwnPropertySlot): Look up overrides before own properties,
- as it is done for Window.
- (WebCore::setJSWorkerContextMessageEvent): Implemented in the same way as Window global
- constructors are.
- (WebCore::setJSWorkerContextWorkerLocation): Ditto.
-
-2008-11-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22341
- Text codecs should not use static data without locking
-
- * platform/text/TextCodecICU.cpp:
- * platform/text/mac/TextCodecMac.cpp:
- Made cached converters per-thread.
-
- * platform/text/TextEncodingRegistry.cpp:
- (WebCore::encodingRegistryMutex): Added a mutex for codec maps access.
- (WebCore::addToTextCodecMap): Don't use TextEncoding just to canonicalize the name, as it
- causes a deadlock due to a recursive call into registry.
- (WebCore::buildBaseTextCodecMaps): Added assertions.
- (WebCore::newTextCodec): Take a lock to avoid concurrent access to codec maps.
- (WebCore::atomicCanonicalTextEncodingName): Ditto.
- (WebCore::noExtendedTextEncodingNameUsed): Added a comment, explaining why locking is not
- necessary here.
-
-2008-11-19 Alexey Proskuryakov <ap@webkit.org>
-
- Touch WebCorePrefix.h to force a rebuild, needed because of changed feature defines.
-
- * WebCorePrefix.h:
-
-2008-11-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22310
- Worker exceptions should be printed to console
-
- * dom/Document.cpp: (WebCore::Document::reportException):
- * dom/Document.h:
- * dom/ScriptExecutionContext.h:
- * dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- * dom/WorkerContext.h:
- Added a reportException() method on ScriptExecutionContext. It forwards the exception info
- up until it finds a Document context, and then it prints it to console.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent): Don't talk to Console directly, use
- ScriptExecutionContext::reportException. Also, fixed a bug where Document::updateDocumentsRendering()
- could be called from workers.
- (WebCore::JSLazyEventListener::parseCode): Moved variable declaration inside if block for clarity.
-
- * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- Report exceptions to ScriptExecutionContext.
-
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerTask::performTask):
- (WebCore::WorkerExceptionTask::create):
- (WebCore::WorkerExceptionTask::WorkerExceptionTask):
- (WebCore::WorkerExceptionTask::performTask):
- (WebCore::WorkerMessagingProxy::postWorkerException):
- * dom/WorkerMessagingProxy.h:
- Added a task for posting exception information.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::reportException):
- (WebCore::reportCurrentException):
- * bindings/js/JSDOMBinding.h:
- Added helper methods for reporting exceptions via ScriptExecutionContext.
-
- * page/Console.cpp:
- * page/Console.h:
- Removed methods for directly reporting exceptions to console.
-
- * bindings/js/JSCustomPositionCallback.cpp:
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/objc/WebScriptObject.mm:
- (WebCore::addExceptionToConsole):
- Switch to JSDOMBinding methods for reporting exceptions.
-
-2008-11-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=22331
- <rdar://problem/6381657> REGRESSION: Contextual menu no longer has an "Inspect Element" item
-
- * platform/ContextMenuItem.h:
- (WebCore::ContextMenuAction): Reorder this enum to keep it in sync with
- the one in WebUIDelegate.h.
-
-2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22346
- PlatformString should also include HashSet.h for non-JSC builds
-
- * platform/text/PlatformString.h:
-
-2008-11-18 Adele Peterson <adele@apple.com>
-
- Reviewed by Holger Hans Peter Freyther.
-
- Flip check added in recent refactoring so the background gets updated when the background color is valid, not invalid.
-
- * loader/FrameLoaderClient.cpp: (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
-
-2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22343
- Remove unused runtime/Collector, JSLock includes in Page.cpp
-
- * page/Page.cpp:
-
-2008-11-18 Ada Chan <adachan@apple.com>
-
- Bug 22344: Make select popup window opaque
- https://bugs.webkit.org/show_bug.cgi?id=22344
-
- Reviewed by Steve Falkenburg.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::show):
-
-2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=22342
- Remove unused JSLock.h include
-
- * dom/Document.cpp:
-
-2008-11-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Sam Weinig.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22334
-
- Add WMLBRElement, correcting <br/> behaviour in WML.
- Enable entity replacment for WML documents.
- Handle WML specific <p> 'mode' attribute.
-
- Generate layout tests results for fast/wml.
-
- Tests cases that pass now:
- fast/wml/br-element-in-table.wml
- fast/wml/br-element-in-text.wml
- fast/wml/case-sensitivity.wml
- fast/wml/cdata-section.wml
- fast/wml/comment.wml
- fast/wml/entity.wml
- fast/wml/p-align.wml
- fast/wml/p-mode.wml
- fast/wml/text-emphasis.wml
- fast/wml/validate-dtd.wml
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::isWMLDocument):
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * dom/XMLTokenizer.h:
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::internalSubset):
- (WebCore::getEntityHandler):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parse):
- * wml/WMLBRElement.cpp: Added.
- (WebCore::WMLBRElement::WMLBRElement):
- (WebCore::WMLBRElement::mapToEntry):
- (WebCore::WMLBRElement::parseMappedAttribute):
- (WebCore::WMLBRElement::createRenderer):
- * wml/WMLBRElement.h: Added.
- * wml/WMLPElement.cpp:
- (WebCore::WMLPElement::parseMappedAttribute):
- (WebCore::WMLPElement::insertedIntoDocument):
- * wml/WMLPElement.h:
- * wml/WMLTagNames.in:
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Windows build fix.
-
- * WebCore.vcproj/WebCore.vcproj: Fix relative paths to use $(WebKitOutputDir).
-
-2008-11-18 Darin Adler <darin@apple.com>
-
- - try to fix Wx build
-
- * WebCoreSources.bkl: Added FrameLoaderClient.cpp.
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22337
- Enable workers by default
-
- Tests: fast/workers/worker-constructor.html
- fast/workers/worker-event-listener.html
- fast/workers/worker-gc.html
- fast/workers/worker-location.html
-
- * Configurations/WebCore.xcconfig:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.vcproj/build-generated-files.sh:
- Define ENABLE_WORKERS.
-
-2008-11-18 Darin Adler <darin@apple.com>
-
- Reviewed by Alexey Proskuryakov.
-
- - first cut at https://bugs.webkit.org/show_bug.cgi?id=10957
- <rdar://problem/5516594> please add support for HTTP-only cookies
-
- Test: http/tests/xmlhttprequest/get-dangerous-headers.html
-
- No test for HTTP-only support in JavaScript yet, since the Mac and Win changes
- require an updated CFNetwork.
-
- * platform/mac/CookieJar.mm:
- (WebCore::isHTTPOnly): Added.
- (WebCore::filterCookies): Added.
- (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
- (WebCore::setCookies): Use filterCookies to prevent setting HTTP-only cookies.
-
- * platform/network/win/CookieJarCFNetWin.cpp:
- (WebCore::isHTTPOnly): Added.
- (WebCore::filterCookies): Added.
- (WebCore::setCookies): Use filterCookies to prevent getting HTTP-only cookies.
- (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::isSetCookieHeader): Added.
- (WebCore::XMLHttpRequest::getAllResponseHeaders): Hide Set-Cookie headers from
- clients that don't have local-resource privileges.
- (WebCore::XMLHttpRequest::getResponseHeader): Ditto.
-
- - clean soup-specific details out of shared cookie jar header
-
- * platform/CookieJar.h: Removed the soup-specific parts of this.
- * platform/network/soup/CookieJarSoup.cpp: Changed to include
- CookieJarSoup.h. Tweaked implementation a bit to handle UTF-8 better.
- * platform/network/soup/CookieJarSoup.h: Added. Has the Soup-specified
- part of CookieJar.h.
- * platform/network/soup/ResourceHandleSoup.cpp: Changed to include
- CookieJarSoup.h.
-
-2008-11-18 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=22329
- Improper bitwise and tests against 0 in Windows context menu code
-
- Reviewed by John Sullivan.
-
- * platform/win/ContextMenuItemWin.cpp:
- (WebCore::ContextMenuItem::type):
- (WebCore::ContextMenuItem::enabled):
-
-2008-11-18 John Sullivan <sullivan@apple.com>
-
- Yet more Mac build fixing
-
- * WebCore.base.exp: Export __ZTVN7WebCore17FrameLoaderClientE
-
-2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- React properly to frame rect changes for QWidget based plugins
-
- We now set the geometry of the QWidget in frameRectsChanged,
- intead of setFrameRect, which means we pick up the changes to
- the frame rect when scrolling. We also set a mask on the
- widget to keep it from painting over scrollbars and the like
-
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::setFrameRect):
-
-2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Don't mark scrollbars as focused in QtWebKit
-
- When initing from the widget we also got the focus state,
- but this does not make sense for scrollbars.
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- More Mac build fixing.
-
- * WebCore.base.exp: Export FrameLoaderClient destructor.
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Mac build fix.
-
- * WebCore.xcodeproj/project.pbxproj: Add FrameLoaderClient.cpp for now.
-
-2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=22056
-
- Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
-
- After Hyatt's work on Widget and ScrollView there is little difference
- between the implementation of Qt, Gtk+ and Win. In fact any kind of
- difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
- port and the Qt port has at least one of them left.
-
- The only difference between the implementations is in getting the the
- IntSize for the new FrameView, the background color to be applied and
- eventually some post processing.
-
- Unify the implementations by providing a static helper function that
- takes a Frame, IntSize, color and transparency bit and calling it from
- the Gtk+, the Qt and the Windows port.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * loader/FrameLoaderClient.cpp: Added.
- (WebCore::FrameLoaderClient::~FrameLoaderClient):
- (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
- * loader/FrameLoaderClient.h:
-
-2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- https://bugs.webkit.org/show_bug.cgi?id=22056
-
- Move setting the background color and transparency from WebKit/win
- to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
- to share this code.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::updateBackgroundRecursively):
- * page/FrameView.h:
-
-2008-11-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix the bug where select elements are painted without border.
- http://trolltech.com/developer/task-tracker/index_html?id=218957&method=entry
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::paintMenuList):
-
-2008-11-18 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix. Not reviewed.
-
- * GNUmakefile.am: Fix USER_AGENT_STYLESHEETS, wml.css is in css/,
- not in wml/.
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22308
- Improve Worker GC behavior
-
- * dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::hasPendingActivity):
- * dom/ActiveDOMObject.h:
- Made hasPendingActivity() virtual, letting Worker add behavior to it.
-
- * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
- Tell message proxy whether there are active objects in the worker whenever JS execution
- finishes.
-
- * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::activeDOMObjects):
- Added a typedef for activeDOMObjects() return type, necessary to declare iterators.
-
- * dom/Worker.h:
- * dom/Worker.cpp: (WebCore::Worker::hasPendingActivity): A Worker is active if it is still
- loading, or if it has unconfirmed messages, or it the worker thread has pending activity.
-
- * dom/WorkerContext.h:
- * dom/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Check all registered
- active objects for pending activity.
-
- * dom/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerContextTask::performTask):
- (WebCore::WorkerThreadActivityReportTask::create):
- (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask):
- (WebCore::WorkerThreadActivityReportTask::performTask):
- (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
- (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
- (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
- (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
- (WebCore::WorkerMessagingProxy::reportWorkerThreadActivity):
- (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal):
- (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity):
- * dom/WorkerMessagingProxy.h:
- Track outstanding messages, and activity reported by worker thread.
-
-2008-11-18 Alexey Proskuryakov <ap@webkit.org>
-
- Rubber-stamped by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22306
- Disable channel messaging support
-
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseMessageChannel):
- * page/DOMWindow.idl:
- Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel
- constructor is added, it remains enumerable, but undefined.
-
-2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by Mark Rowe.
-
- Remove WBXML code. MainResourceLoader is not an appropriate location.
- Revert until we find a better place.
-
- The mime type which belongs to wmlc should be enabled anyway so WML documents get build.
- Remove the ENABLE(WBXML) blocks around these types in MIMETypeRegistry / DOMImplementation.
-
- * WebCore.pro:
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::addData):
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedNonImageMimeTypes):
-
-2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Not reviewed. Build fix.
-
- Oops, disable WML by default on Qt.
-
- * WebCore.pro:
-
-2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
-
- Reviewed by George Staikos.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=22324 (Add basic subset of WML elements)
-
- Add first bits of WML support. Only <card> & <p> and <a> elements are supported in this first patch.
- Support for most other elements will be added step-by-step (merging in small chunks from a big patch).
-
- WML is not build by default.
-
- * DerivedSources.make: Handle WMLNames/WMLElementFactory generation.
- * GNUmakefile.am: Add new files and generator hooks.
- * WebCore.pro: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * css/CSSStyleSelector.cpp: Load wml.css on demand, just like it's done for SVG.
- (WebCore::linkAttribute):
- (WebCore::CSSStyleSelector::styleForElement):c
- * css/wml.css: Added.
- * dom/DOMImplementation.cpp: Handle WMLDocument creation
- (WebCore::DOMImplementation::createDocument):
- * dom/Document.cpp: Handle WMLElement creation.
- (WebCore::Document::createElement):
- * dom/Document.h: Add helper function identifying WML documents.
- (WebCore::Document::isWMLDocument):
- * dom/Node.h: Add heper function identifying WML elements.
- (WebCore::Node::isWMLElement):
- * dom/XMLTokenizer.cpp: Handle errors in WML documents
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * dom/XMLTokenizerLibxml2.cpp: Add WML DTD checks.
- (WebCore::XMLTokenizer::internalSubset):
- * dom/XMLTokenizerQt.cpp: Ditto.
- (WebCore::):
- * dom/make_names.pl: Force internal linkage for the "tagConstructor" functions, avoiding SVG<->WML clashes.
- * history/BackForwardList.cpp: Add WML specific function for clearing the history.
- (WebCore::BackForwardList::clearWmlPageHistory):
- * history/BackForwardList.h:
- * loader/FrameLoader.cpp: Add WML specific 'shouldReload' logic.
- (WebCore::FrameLoader::FrameLoader):
- (WebCore::FrameLoader::setForceReloadWmlDeck):
- (WebCore::FrameLoader::shouldReload):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
- * loader/MainResourceLoader.cpp: Add WBXML support (only enabled on Linux/Qt at the moment)
- (WebCore::MainResourceLoader::addData):
- * page/Frame.cpp: Initialize WMLNames.
- (WebCore::Frame::Frame):
- * page/Page.cpp: Maintain WMLPageState object per Page.
- (WebCore::Page::Page):
- (WebCore::Page::setWMLPageState):
- (WebCore::Page::wmlPageState):
- * page/Page.h:
- * platform/MIMETypeRegistry.cpp: Recognize WML extensions.
- (WebCore::initializeSupportedNonImageMimeTypes):
- * platform/gtk/MIMETypeRegistryGtk.cpp: Ditto.
- (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- * platform/qt/MIMETypeRegistryQt.cpp: Ditto.
- (WebCore::):
- * platform/win/MIMETypeRegistryWin.cpp: Ditto.
- (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- * manual-tests/wml: Added.
- * manual-tests/wml/a-br-element.wml: Added.
- * manual-tests/wml/a-element.wml: Added.
- * manual-tests/wml/a-img-element.wml: Added.
- * manual-tests/wml/access-target.wml: Added.
- * manual-tests/wml/anchor-br-element.wml: Added.
- * manual-tests/wml/anchor-element.wml: Added.
- * manual-tests/wml/anchor-img-element.wml: Added.
- * manual-tests/wml/card-newcontext-attr.wml: Added.
- * manual-tests/wml/card-onenterbackward.wml: Added.
- * manual-tests/wml/card-onenterforward.wml: Added.
- * manual-tests/wml/card-ontimer.wml: Added.
- * manual-tests/wml/deck-access-control.wml: Added.
- * manual-tests/wml/go-element.wml: Added.
- * manual-tests/wml/input-emptyok.wml: Added.
- * manual-tests/wml/input-format.wml: Added.
- * manual-tests/wml/onevent-go.wml: Added.
- * manual-tests/wml/onevent-noop.wml: Added.
- * manual-tests/wml/onevent-prev.wml: Added.
- * manual-tests/wml/onevent-refresh.wml: Added.
- * manual-tests/wml/onevent-shadow.wml: Added.
- * manual-tests/wml/postfield-get.wml: Added.
- * manual-tests/wml/postfield-post.wml: Added.
- * manual-tests/wml/select-element.wml: Added.
- * manual-tests/wml/select-onpick-event.wml: Added.
- * manual-tests/wml/setvar-element.wml: Added.
- * manual-tests/wml/targetdeck.wml: Added.
- * manual-tests/wml/task-go-in-anchor.wml: Added.
- * manual-tests/wml/task-noop-in-do.wml: Added.
- * manual-tests/wml/task-noop-in-onevent.wml: Added.
- * manual-tests/wml/task-prev-in-anchor.wml: Added.
- * manual-tests/wml/task-refresh-in-anchor.wml: Added.
- * manual-tests/wml/template-go.wml: Added.
- * manual-tests/wml/template-onevent.wml: Added.
- * manual-tests/wml/template-ontimer.wml: Added.
- * manual-tests/wml/timer.wml: Added.
- * manual-tests/wml/variable-substitution.wml: Added.
- * wml: Added.
- * wml/WMLAElement.cpp: Added.
- (WebCore::WMLAElement::WMLAElement):
- (WebCore::WMLAElement::parseMappedAttribute):
- (WebCore::WMLAElement::supportsFocus):
- (WebCore::WMLAElement::isFocusable):
- (WebCore::WMLAElement::isMouseFocusable):
- (WebCore::WMLAElement::isKeyboardFocusable):
- (WebCore::WMLAElement::defaultEventHandler):
- (WebCore::WMLAElement::accessKeyAction):
- (WebCore::WMLAElement::isURLAttribute):
- (WebCore::WMLAElement::target):
- * wml/WMLAElement.h: Added.
- * wml/WMLAttributeNames.in: Added.
- * wml/WMLCardElement.cpp: Added.
- (WebCore::WMLCardElement::WMLCardElement):
- * wml/WMLCardElement.h: Added.
- * wml/WMLDocument.cpp: Added.
- (WebCore::WMLDocument::WMLDocument):
- (WebCore::WMLDocument::~WMLDocument):
- * wml/WMLDocument.h: Added.
- (WebCore::WMLDocument::create):
- (WebCore::WMLDocument::isWMLDocument):
- * wml/WMLElement.cpp: Added.
- (WebCore::WMLElement::WMLElement):
- (WebCore::WMLElement::mapToEntry):
- (WebCore::WMLElement::parseMappedAttribute):
- (WebCore::WMLElement::rendererIsNeeded):
- (WebCore::WMLElement::createRenderer):
- * wml/WMLElement.h: Added.
- (WebCore::WMLElement::isWMLElement):
- * wml/WMLPElement.cpp: Added.
- (WebCore::WMLPElement::WMLPElement):
- (WebCore::WMLPElement::mapToEntry):
- (WebCore::WMLPElement::parseMappedAttribute):
- * wml/WMLPElement.h: Added.
- * wml/WMLPageState.cpp: Added.
- (WebCore::WMLPageState::WMLPageState):
- (WebCore::WMLPageState::~WMLPageState):
- (WebCore::WMLPageState::reset):
- (WebCore::WMLPageState::setNeedCheckDeckAccess):
- (WebCore::WMLPageState::isDeckAccessible):
- * wml/WMLPageState.h: Added.
- (WebCore::WMLPageState::storeVariable):
- (WebCore::WMLPageState::storeVariables):
- (WebCore::WMLPageState::getVaribale):
- (WebCore::WMLPageState::hasVariables):
- (WebCore::WMLPageState::historyLength):
- (WebCore::WMLPageState::setHistoryLength):
- (WebCore::WMLPageState::page):
- (WebCore::WMLPageState::activeCard):
- (WebCore::WMLPageState::setActiveCard):
- (WebCore::WMLPageState::setDeckAccessDomain):
- (WebCore::WMLPageState::setDeckAccessPath):
- (WebCore::WMLPageState::hasDeckAccess):
- * wml/WMLTagNames.in: Added.
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore renames.
-
- * WebCore.pro:
- * webcore-base.bkl:
-
-2008-11-17 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/4922709> Copying less than a paragraph of quoted text and pasting it doesn't retain quote level
-
- There was code to intentionally avoid quoting pasted content if less than a paragraph of
- it was copied. That was added for <rdar://problem/5006779>, but was unnecessary because
- that bug was about Paste and Match style for single paragraphs. And quote stripping for
- Paste and Match style is handled elsewhere.
-
- * editing/markup.cpp:
- (WebCore::createMarkup):
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore rename.
-
- * ForwardingHeaders/interpreter/CallFrame.h: Copied from WebCore/ForwardingHeaders/runtime/ExecState.h.
- * ForwardingHeaders/runtime/ExecState.h: Removed.
- * bindings/objc/WebScriptObject.mm:
- * bridge/c/c_instance.cpp:
- * bridge/jni/jni_jsobject.mm:
- * dom/Node.cpp:
- * dom/NodeFilter.cpp:
- * dom/NodeIterator.cpp:
- * dom/TreeWalker.cpp:
- * inspector/JavaScriptCallFrame.h:
-
-2008-11-17 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Sam Weinig.
-
- Added functionality to AnimationController to allow pausing a running
- animation or transition at a given time for testing purposes.
-
- https://bugs.webkit.org/show_bug.cgi?id=21261
-
- Tests: animations/animation-drt-api.html
- transitions/transition-drt-api.html
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::progress):
- (WebCore::AnimationBase::pauseAtTime):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- (WebCore::AnimationController::pauseAnimationAtTime):
- (WebCore::AnimationController::pauseTransitionAtTime):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::isAnimating):
- (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
- (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
- (WebCore::CompositeAnimation::pauseAnimationAtTime):
- (WebCore::CompositeAnimation::pauseTransitionAtTime):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore renames.
-
- * ForwardingHeaders/VM: Removed.
- * ForwardingHeaders/VM/Machine.h: Removed.
- * ForwardingHeaders/interpreter: Added.
- * ForwardingHeaders/interpreter/Interpreter.h: Copied from ForwardingHeaders/VM/Machine.h.
- * WebCore.pro:
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- * page/Console.cpp:
- * webcore-base.bkl:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore renames.
-
- * ForwardingHeaders/runtime/Interpreter.h: Removed.
- * WebCore.vcproj/WebCore.vcproj:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/WorkerScriptController.cpp:
- * bindings/objc/WebScriptObject.mm:
- * bridge/NP_jsobject.cpp:
- * bridge/jni/jni_jsobject.mm:
- * html/CanvasRenderingContext2D.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * page/Console.cpp:
-
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix wx build.
-
- * webcore-base.bkl:
-
-2008-11-17 Greg Bolsinga <bolsinga@apple.com>
+ * platform/graphics/MediaPlayerPrivate.h:
+ (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
- Reviewed by Darin Adler.
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
+ (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the
+ exact same attributes as before, with pitch preservation being the difference.
+ (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes.
+ (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie.
+ (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it
+ has been effectively overwritten.
- https://bugs.webkit.org/show_bug.cgi?id=21810
- Remove use of static C++ objects that are destroyed at exit time (destructors)
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::load):
+ (WebCore::MediaPlayerPrivate::setPreservesPitch):
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWinPrivate::QTMovieWinPrivate):
+ (QTMovieWinPrivate::~QTMovieWinPrivate):
+ (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie.
+ (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it.
+ (QTMovieWin::pause): Ditto.
+ (QTMovieWin::setRate): Ditto.
+ (QTMovieWin::setCurrentTime): Ditto.
+ (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes.
+ (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it,
+ but changing the pitch preservation flag.
+ * platform/graphics/win/QTMovieWin.h:
- Find some missing DEFINE_STATIC_LOCAL use cases.
+2009-06-23 Eric Carlson <eric.carlson@apple.com>
- * bindings/js/JSSVGPODTypeWrapper.h:
- (WebCore::PODTypeWrapperCacheInfoTraits::emptyValue):
- (WebCore::JSSVGDynamicPODTypeWrapperCache::dynamicWrapperHashMap):
- * dom/make_names.pl: Generate code to use DEFINE_STATIC_LOCAL.
- * page/AccessibilityRenderObject.cpp:
- (WebCore::RoleEntry::): This method is only called once, so the array does not have to be static.
- * platform/graphics/FontCache.cpp:
- (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
- (WebCore::FontDataCacheKeyTraits::emptyValue):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::initialTransform):
+ Reviewed by Simon Fraser.
-2008-11-17 Geoffrey Garen <ggaren@apple.com>
+ <rdar://problem/6998286> Crash after leaving page with <video>
+
+ Don't try to post events after going into the page cache.
- Not reviewed.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop
+ event timers so we won't try to post events after going into the cache.
- Try to fix Qt build.
+2009-06-23 Jeremy Orlow <jorlow@chromium.org>
- * WebCore.pro:
+ Reviewed by Brady Eidson.
-2008-11-16 Simon Fraser <simon.fraser@apple.com>
+ Simplify the interaction between LocalStorageArea/SessionStorageArea
+ and StorageArea by creating a "blockUntilImportComplete()" function
+ rather than bouncing back and forth between the child and parent
+ classes in a somewhat unintuitive manner.
- Reviewed by Dan Bernstein
+ This patch also paves the way for LocalStorageArea and
+ SessionStorageArea being merged into one. It's part of several in a
+ set which are separating syncing (to disk) code from the rest of the
+ implementation so that local storage and session storage's code can be
+ unified.
- https://bugs.webkit.org/show_bug.cgi?id=22118
+ https://bugs.webkit.org/show_bug.cgi?id=25376
- Fix resize corner tracking in transformed elements by using
- mapping the point into local coords using absoluteToLocal,
- rather than convertToLayerCoords.
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::blockUntilImportComplete):
+ * storage/LocalStorageArea.h:
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::length):
+ (WebCore::StorageArea::key):
+ (WebCore::StorageArea::getItem):
+ (WebCore::StorageArea::setItem):
+ (WebCore::StorageArea::removeItem):
+ (WebCore::StorageArea::clear):
+ (WebCore::StorageArea::contains):
+ * storage/StorageArea.h:
+ (WebCore::StorageArea::blockUntilImportComplete):
+
+2009-06-23 Simon Fraser <simon.fraser@apple.com>
- Test: fast/css/resize-corner-tracking-transformed.html
+ Reviewed by Dave Hyatt
- * page/EventHandler.h:
+ First part of https://bugs.webkit.org/show_bug.cgi?id=26652
+
* rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::absoluteToContents):
- (WebCore::RenderLayer::offsetFromResizeCorner):
- (WebCore::RenderLayer::isPointInResizeControl):
+ (WebCore::RenderLayer::paint):
+ (WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
+ (WebCore::RenderLayer::):
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::paint):
+ Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ (WebCore::RenderLayerBacking::paintContents):
+ * rendering/RenderLayerBacking.h:
+ Remove the unused 'haveTransparency' param to paintIntoLayer().
-2008-11-16 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Qt build.
-
- * WebCore.pro:
-
-2008-11-16 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- Use RefPtr and PassRefPtr where appropriate.
-
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::createTemplateDocumentData):
-
-2008-11-16 Greg Bolsinga <bolsinga@apple.com>
-
- Fix build break for real.
-
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::createTemplateDocumentData):
-
-2008-11-16 Greg Bolsinga <bolsinga@apple.com>
-
- Fix build break and bug.
-
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::createTemplateDocumentData):
-
-2008-11-16 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21810
- Remove use of static C++ objects that are destroyed at exit time (destructors)
-
- Use DEFINE_STATIC_LOCAL for static RetainPtr<T>, RefPtr<T>. Add additional
- uses of DEFINE_STATIC_LOCAL where appropriate.
-
- * html/HTMLTableElement.cpp:
- (WebCore::HTMLTableElement::addSharedCellBordersDecl): new the AtomicStrings
- * loader/CachedImage.cpp:
- (WebCore::brokenImage):
- (WebCore::nullImage):
- * loader/FTPDirectoryDocument.cpp:
- (WebCore::_createTemplateDocumentData): Created so accessor has one line initialization
- (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
- * loader/icon/IconDatabase.cpp:
- (WebCore::loadDefaultIconRecord):
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::actionVerb):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::actionVerb):
- * page/mac/EventHandlerMac.mm:
- (WebCore::currentEvent):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::paint):
- * platform/graphics/Image.cpp:
- (WebCore::Image::nullImage):
- * platform/graphics/mac/ColorMac.mm:
- (WebCore::nsColor):
- * platform/graphics/mac/FontCacheMac.mm: new the Strings
- (WebCore::FontCache::getSimilarFontPlatformData):
- * platform/graphics/mac/GraphicsContextMac.mm:
- (WebCore::_createPatternColor): Created so accessor has one line initialization
- (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::webFallbackFontFamily):
- * platform/mac/PasteboardMac.mm:
- (WebCore::writableTypesForURL):
- (WebCore::createWritableTypesForImage): Created so accessor has one line initialization
- (WebCore::writableTypesForImage):
- (WebCore::stripAttachmentCharacters):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintResizer):
-
-2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
+2009-06-23 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
- Do not spit Curl errors into the stdout as this is used by DRT
-
- We have failing tests results due the curl errors printed to stdout,
- move them to stderr to be able to pass those tests.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::startJob):
-
-2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
-
- - fix the Gtk+ build
-
- * GNUmakefile.am:
-
-2008-11-16 Darin Adler <darin@apple.com>
-
- - try to fix Qt build
-
- * WebCore.pro: Add the worker-related source files.
-
-2008-11-16 Darin Adler <darin@apple.com>
-
- Suggested by Alexey Proskuryakov.
-
- - fix the GTK build another way
-
- * GNUmakefile.am: Add the worker-related source files.
- * bindings/js/JSEventTarget.cpp: Take the #if back out.
-
-2008-11-16 Darin Adler <darin@apple.com>
-
- - try to fix GTK build
-
- * bindings/js/JSEventTarget.cpp: Put worker includes inside an #if.
-
-2008-11-16 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22295
- track which history items are from page load failures
-
- * history/HistoryItem.cpp: Sort includes, add newly needed ones, and remove
- no-longer-needed ones.
- (WebCore::HistoryItem::HistoryItem): Initialize m_lastVisitWasFailure to false.
- (WebCore::HistoryItem::showTreeWithIndent): Rewrote to avoid appending to a
- String, since that's not efficient.
-
- * history/HistoryItem.h: Removed unneeded includes. Added lastVisitWasFailure,
- setLastVisitWasFailure, and m_lastVisitWasFailure.
-
- * history/mac/HistoryItemMac.mm: Add newly-needed include
- (WebCore::HistoryItem::setTransientProperty): Rewrote to avoid keeping a
- m_transientProperties map around when it is empty.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createHistoryItem): Call setLastVisitWasFailure when
- the page was unreachable or an HTTP page with a status code that indicates
- failure.
-
-2008-11-16 Yong Li <yong.li@torchmobile.com>
-
- Reviewed by Timothy Hatcher.
- Landed by George Staikos.
-
- Optimization: don't relayout, repaint, or emit a DOM event if the
- scroll event didn't scroll anywhere.
+ <rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration
+ The updatingControlTints() painting pass goes through compositing layer boundaries,
+ so we need to ensure we don't cache clip rects computed with the wrong root by
+ setting temporaryClipRects to true.
+
* rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollToOffset): add early exit
-
-2008-11-16 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22290
- Remove cross-heap GC and MessagePort multi-threading support
-
- It is broken (and may not be implementable at all), and no longer needed, as we
- don't use MessagePorts for communication with workers any more.
-
- * bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- Removed cross-heap GC implementation.
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::hasPendingActivity):
- * dom/MessagePort.h:
- Made objects RefCounted instead of ThreadSafeShared, added FIXME comments for code that is
- unnecessarily complicated for single threaded case.
-
-2008-11-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=22266
- Stop using MessagePort for communication with workers
-
- The current MessagePort specification is not well suited for being implemented in a
- multi-threaded or multi-process environment, and this doesn't appear to be easily fixable.
- This patch implements a simpler Mozilla API for workers instead.
-
- * WebCore.xcodeproj/project.pbxproj:
- * DerivedSources.make:
- * bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker):
- * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed.
- * bindings/js/JSDedicatedWorkerConstructor.h: Removed.
- * bindings/js/JSDedicatedWorkerCustom.cpp: Removed.
- * bindings/js/JSWorkerConstructor.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.cpp.
- * bindings/js/JSWorkerConstructor.h: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.h.
- * bindings/js/JSWorkerCustom.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerCustom.cpp.
- * dom/DedicatedWorker.cpp: Removed.
- * dom/DedicatedWorker.h: Removed.
- * dom/DedicatedWorker.idl: Removed.
- Renamed DedicatedWorker to Worker to match Mozilla and current WHATWG cpec.
-
- * bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
- Clear worker exceptions to avoid hitting an assertion.
-
- * dom/EventTarget.cpp: (WebCore::EventTarget::toWorker):
- * dom/EventTarget.h:
- * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- WorkerContext is now an EventTarget, too.
-
- * bindings/js/JSWorkerContext.cpp: Removed onconnect, constructors for MessageChannel and
- MessagePort. Added postMessage() and onmessage.
-
- * dom/ScriptExecutionContext.cpp: (WebCore::performTask): Do not reference ScriptExecutionContext
- when posting a task - this operation is not thread safe. It is also not necessary any more,
- as the context is kept alive by WorkerMessagingProxy.
-
- * dom/Worker.cpp: Copied from WebCore/dom/DedicatedWorker.cpp.
- (WebCore::Worker::Worker): Start loading the script right away - there is no reason to do
- that on a timer.
- (WebCore::Worker::~Worker): Notify messaging proxy.
- (WebCore::Worker::postMessage): Just ask the proxy to post the message.
- (WebCore::Worker::notifyFinished): Notify messaging proxy when a thread object becomes
- available. Also, it is now safe to unsetPendingActivity(), making the object collectable.
- I'm not sure if this is the right lifetime for workers, as unreachable workers with event
- listeners should probably be kept alive, but it at least lets the object be collected.
- (WebCore::Worker::addEventListener): Added an EventTarget implementation.
- (WebCore::Worker::removeEventListener): Added an EventTarget implementation.
- (WebCore::Worker::dispatchEvent): Added an EventTarget implementation.
-
- * dom/Worker.h: Copied from WebCore/dom/DedicatedWorker.h.
- * dom/Worker.idl: Copied from WebCore/dom/DedicatedWorker.idl.
- Removed onclose, made an EventListener. Actual messaging is now handled by WorkerMessagingProxy.
-
- * dom/WorkerContext.cpp:
- (WebCore::WorkerContext::~WorkerContext): Notify messaging proxy that the context was shut
- down successfully.
- (WebCore::WorkerContext::postMessage): Added. Post the message via messaging proxy.
-
- * dom/WorkerContext.h: Added postMessage and onmessage, removed onconnect.
-
- * dom/WorkerMessagingProxy.cpp: Added.
- * dom/WorkerMessagingProxy.h: Added.
- This new class implements actual messaging. It is notified when a Worker is garbage collected,
- and asks the thread to shut down. It also owns the thread object, and references script
- execution context, making it safe to post messages to it remotely.
-
- * dom/WorkerThread.cpp:
- * dom/WorkerThread.h:
- Keep a reference to messaging proxy, not to Worker itself. Also, the thread object no longer
- keeps itself alive - it is now the job of messaging proxy.
-
-2008-11-15 Darin Adler <darin@apple.com>
-
- Rubber stamped by Geoff Garen.
-
- - do the long-planned StructureID -> Structure rename
-
- * ForwardingHeaders/runtime/Structure.h: Copied from WebCore/ForwardingHeaders/runtime/StructureID.h.
- * ForwardingHeaders/runtime/StructureID.h: Removed.
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::getCachedDOMStructure):
- (WebCore::cacheDOMStructure):
- * bindings/js/JSDOMBinding.h:
- (WebCore::DOMObject::DOMObject):
- (WebCore::getDOMStructure):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBase):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::JSDOMWindowShell):
- (WebCore::JSDOMWindowShell::setWindow):
- * bindings/js/JSDOMWindowShell.h:
- (WebCore::JSDOMWindowShell::createStructure):
- * bindings/js/JSDedicatedWorkerConstructor.cpp:
- (WebCore::JSDedicatedWorkerConstructor::JSDedicatedWorkerConstructor):
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- (WebCore::JSHTMLAllCollection::createStructure):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
- (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
- * bindings/js/JSInspectedObjectWrapper.h:
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::leakInspectorCallbackWrapperStructure):
- (WebCore::JSInspectorCallbackWrapper::wrap):
- (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
- * bindings/js/JSInspectorCallbackWrapper.h:
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createStructure):
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::createStructure):
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::createStructure):
- * bindings/js/JSWorkerContext.cpp:
- (WebCore::createJSWorkerContextStructure):
- (WebCore::JSWorkerContext::JSWorkerContext):
- (WebCore::JSWorkerContext::createPrototype):
- * bindings/js/JSWorkerContext.h:
- (WebCore::JSWorkerContext::createStructure):
- (WebCore::JSWorkerContextPrototype::JSWorkerContextPrototype):
- (WebCore::JSWorkerContextPrototype::createStructure):
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtConnectionObject::execute):
- * bridge/qt/qt_runtime.h:
- (JSC::Bindings::QtRuntimeMethod::createStructure):
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::createStructure):
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createStructure):
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::RuntimeObjectImp):
- * bridge/runtime_object.h:
- (JSC::RuntimeObjectImp::createStructure):
-
-2008-11-15 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - fix just-introduced crash in the svg/custom/svg-fonts-in-html.html test
-
- This gets rid of the crash. It restores the behavior of the CG case from before Dirk
- Shulze removed the platorm-dependent code, but perhaps it should be changed further
- in the future so that the default for no style is "no stroke". I think the patch is
- fine for fill.
-
- * svg/graphics/SVGPaintServerSolid.cpp:
- (WebCore::SVGPaintServerSolid::setup): Added null checks for svgStyle.
- (WebCore::SVGPaintServerSolid::renderPath): Added null checks for style and svgStyle.
-
-2008-11-15 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Timothy Hatcher.
-
- Initialize m_networkStateChangedFunction to 0 as otherwise the check for null will fail.
-
- https://bugs.webkit.org/show_bug.cgi?id=22284
-
- * platform/network/NetworkStateNotifier.h:
- (WebCore::NetworkStateNotifier::NetworkStateNotifier):
-
-2008-11-15 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Geoffrey Garen.
-
- r38426 caused a wrong drawing of a LayoutTest. Use another
- way to set the color to pass this test again.
-
- * svg/graphics/SVGPaintServerSolid.cpp:
- (WebCore::SVGPaintServerSolid::setup):
-
-2008-11-15 Dirk Schulze <krit@webkit.org>
-
- Reviewed by Darin Adler.
-
- Removed platform dependent code on SVGPaintServerSolid.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * svg/graphics/SVGPaintServerSolid.cpp:
- (WebCore::SVGPaintServerSolid::setup):
- (WebCore::SVGPaintServerSolid::renderPath):
- * svg/graphics/SVGPaintServerSolid.h:
- * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp: Removed.
- * svg/graphics/cg/SVGPaintServerSolidCg.cpp: Removed.
- * svg/graphics/qt/SVGPaintServerSolidQt.cpp: Removed.
-
-2008-11-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Sam Weinig.
-
- Updated for JavaScriptCore renames.
-
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::mark):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::send):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::evaluate):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject evaluateWebScript:]):
- * bridge/NP_jsobject.cpp:
- (_NPN_Evaluate):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::eval):
- * page/Console.cpp:
- (WebCore::retrieveLastCaller):
- (WebCore::Console::trace):
-
-2008-11-14 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21810
- Remove use of static C++ objects that are destroyed at exit time (destructors)
-
- Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
- exit-time destructor. Update code that was changed to fix this issue that ran
- into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
- in gcc build 5465). Also typdefs for template types needed to be added in some
- cases so the type could make it through the macro successfully.
-
- Basically code of the form:
- static T m;
- becomes:
- DEFINE_STATIC_LOCAL(T, m, ());
-
- Also any code of the form:
- static T& m = *new T;
- also becomes:
- DEFINE_STATIC_LOCAL(T, m, ());
-
- * ForwardingHeaders/wtf/StdLibExtras.h: Added.
- * bindings/js/GCController.cpp:
- (WebCore::gcController):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::wrapperSet):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::wrappers):
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::wrappers):
- * bindings/js/JSNavigatorCustom.cpp:
- (WebCore::needsYouTubeQuirk):
- * bridge/runtime_root.cpp:
- (JSC::Bindings::rootObjectSet):
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::initShorthandMap):
- (WebCore::CSSMutableStyleDeclaration::removeProperty):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSStyleSelector.cpp:
- (WebCore::screenEval):
- (WebCore::printEval):
- * dom/DOMImplementation.cpp:
- (WebCore::addString):
- (WebCore::isSVG10Feature):
- (WebCore::isSVG11Feature):
- (WebCore::DOMImplementation::isXMLMIMEType):
- * dom/Document.cpp:
- (WebCore::Document::hasPrefixNamespaceMismatch):
- * dom/ScriptElement.cpp:
- (WebCore::isSupportedJavaScriptLanguage):
- * editing/ApplyStyleCommand.cpp:
- (WebCore::styleSpanClassString):
- * editing/HTMLInterchange.cpp:
- (WebCore::):
- * editing/IndentOutdentCommand.cpp:
- (WebCore::indentBlockquoteString):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::isInterchangeNewlineNode):
- (WebCore::isInterchangeConvertedSpaceSpan):
- * editing/htmlediting.cpp:
- (WebCore::stringWithRebalancedWhitespace):
- (WebCore::nonBreakingSpaceString):
- * editing/markup.cpp:
- (WebCore::appendAttributeValue):
- (WebCore::appendEscapedContent):
- (WebCore::shouldAddNamespaceAttr):
- (WebCore::appendNamespace):
- (WebCore::appendStartMarkup):
- (WebCore::createMarkup):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::type):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::isRecognizedTagName):
- (WebCore::inlineTagList):
- (WebCore::blockTagList):
- * html/HTMLFieldSetElement.cpp:
- (WebCore::HTMLFieldSetElement::type):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::type):
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::type):
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::type):
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::type):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::type):
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::getNode):
- (WebCore::HTMLParser::isHeaderTag):
- (WebCore::HTMLParser::isResidualStyleTag):
- (WebCore::HTMLParser::isAffectedByResidualStyle):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::type):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::type):
- * inspector/InspectorController.cpp:
- (WebCore::platform):
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::shared):
- * inspector/JavaScriptProfile.cpp:
- (WebCore::profileCache):
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::profileNodeCache):
- * loader/FrameLoader.cpp:
- (WebCore::localSchemes):
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::cacheStorage):
- * loader/archive/ArchiveFactory.cpp:
- (WebCore::archiveMIMETypes):
- (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::defaultDatabaseFilename):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dragState):
- * page/Frame.cpp:
- (WebCore::createRegExpForLabels):
- (WebCore::keepAliveSet):
- * page/Page.cpp:
- (WebCore::Page::groupName):
- * page/SecurityOrigin.cpp:
- (WebCore::isDefaultPortForProtocol):
- (WebCore::SecurityOrigin::databaseIdentifier):
- * page/mac/FrameMac.mm:
- (WebCore::regExpForLabels):
- * platform/KURL.cpp:
- (WebCore::blankURL):
- * platform/graphics/FontCache.cpp:
- (WebCore::alternateFamilyName):
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::FontCache::getSimilarFontPlatformData):
- (WebCore::FontCache::getLastResortFallbackFont):
- * platform/mac/CursorMac.mm:
- (WebCore::leakNamedCursor):
- (WebCore::pointerCursor):
- (WebCore::crossCursor):
- (WebCore::handCursor):
- (WebCore::moveCursor):
- (WebCore::verticalTextCursor):
- (WebCore::cellCursor):
- (WebCore::contextMenuCursor):
- (WebCore::aliasCursor):
- (WebCore::zoomInCursor):
- (WebCore::zoomOutCursor):
- (WebCore::copyCursor):
- (WebCore::noneCursor):
- (WebCore::progressCursor):
- (WebCore::noDropCursor):
- (WebCore::notAllowedCursor):
- (WebCore::iBeamCursor):
- (WebCore::waitCursor):
- (WebCore::helpCursor):
- (WebCore::eastResizeCursor):
- (WebCore::northResizeCursor):
- (WebCore::northEastResizeCursor):
- (WebCore::northWestResizeCursor):
- (WebCore::southResizeCursor):
- (WebCore::southEastResizeCursor):
- (WebCore::southWestResizeCursor):
- (WebCore::westResizeCursor):
- (WebCore::northSouthResizeCursor):
- (WebCore::eastWestResizeCursor):
- (WebCore::northEastSouthWestResizeCursor):
- (WebCore::northWestSouthEastResizeCursor):
- (WebCore::columnResizeCursor):
- (WebCore::rowResizeCursor):
- (WebCore::grabCursor):
- (WebCore::grabbingCursor):
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarTheme::nativeTheme):
- * platform/mac/ThemeMac.mm:
- (WebCore::platformTheme):
- * platform/mac/ThreadCheck.mm:
- (WebCoreReportThreadViolation):
- * platform/network/NetworkStateNotifier.cpp:
- (WebCore::networkStateNotifier):
- * platform/network/mac/FormDataStreamMac.mm:
- (WebCore::getStreamFormDataMap):
- (WebCore::getStreamResourceHandleMap):
- * platform/network/mac/ResourceResponseMac.mm:
- (WebCore::ResourceResponse::platformLazyInit):
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::isJapanese):
- * plugins/PluginMainThreadScheduler.cpp:
- (WebCore::PluginMainThreadScheduler::scheduler):
- * rendering/RenderBlock.cpp:
- (WebCore::continuationOutlineTable):
- (WebCore::RenderBlock::addContinuationWithOutline):
- (WebCore::RenderBlock::paintContinuationOutlines):
- * rendering/RenderCounter.cpp:
- (WebCore::counterMaps):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox):
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::markerText):
- * rendering/RenderScrollbarTheme.cpp:
- (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::systemFont):
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::checkLinesForTextOverflow):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::initialDashboardRegions):
- (WebCore::RenderStyle::noneDashboardRegions):
- * storage/Database.cpp:
- (WebCore::guidMutex):
- (WebCore::guidToVersionMap):
- (WebCore::guidToDatabaseMap):
- (WebCore::Database::databaseInfoTableName):
- (WebCore::databaseVersionKey):
- (WebCore::Database::getVersionFromDatabase):
- (WebCore::Database::setVersionInDatabase):
- (WebCore::guidForOriginAndName):
- * storage/DatabaseTracker.cpp:
- (WebCore::DatabaseTracker::tracker):
- (WebCore::notificationMutex):
- (WebCore::notificationQueue):
- * storage/LocalStorage.cpp:
- (WebCore::localStorageMap):
- * svg/SVGAnimateMotionElement.cpp:
- (WebCore::SVGAnimateMotionElement::rotateMode):
- * svg/SVGAnimationElement.cpp:
- (WebCore::SVGAnimationElement::calcMode):
- (WebCore::SVGAnimationElement::attributeType):
- (WebCore::SVGAnimationElement::isAdditive):
- (WebCore::SVGAnimationElement::isAccumulated):
- * svg/SVGLangSpace.cpp:
- (WebCore::SVGLangSpace::xmlspace):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::contentScriptType):
- (WebCore::SVGSVGElement::contentStyleType):
- * svg/SVGStyleElement.cpp:
- (WebCore::SVGStyleElement::type):
- (WebCore::SVGStyleElement::media):
- * svg/SVGTextContentElement.cpp:
- (WebCore::SVGTextContentElement::parseMappedAttribute):
- * svg/animation/SVGSMILElement.cpp:
- (WebCore::SVGSMILElement::parseClockValue):
- (WebCore::SVGSMILElement::restart):
- (WebCore::SVGSMILElement::fill):
- (WebCore::SVGSMILElement::repeatCount):
- (WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
- * svg/graphics/SVGResource.cpp:
- (WebCore::clientMap):
- (WebCore::SVGResource::removeClient):
- * svg/graphics/SVGResourceMarker.cpp:
- (WebCore::SVGResourceMarker::draw):
- * xml/XMLHttpRequest.cpp:
- (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
- (WebCore::preflightResultCache):
- (WebCore::appendPreflightResultCacheEntry):
- (WebCore::isSafeRequestHeader):
- (WebCore::isOnAccessControlResponseHeaderWhitelist):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- * xml/XPathExpressionNode.cpp:
- (WebCore::XPath::Expression::evaluationContext):
- * xml/XPathParser.cpp:
- (WebCore::XPath::setUpAxisNamesMap):
- (WebCore::XPath::isAxisName):
- (WebCore::XPath::isNodeTypeName):
- * xml/XPathValue.cpp:
- (WebCore::XPath::Value::toNodeSet):
-
-2008-11-14 Dan Bernstein <mitz@apple.com>
-
- - attempt to fix the Qt build
-
- * platform/qt/Localizations.cpp:
- (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string
- needs to go somewhere else in addition to here.
-
-2008-11-14 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
-
- * platform/wx/LocalizedStringsWx.cpp:
- (WebCore::contextMenuItemTagTextDirectionMenu):
-
-2008-11-14 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - <rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
- - WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
-
- * WebCore.base.exp: Exported
- WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().
-
- * editing/ApplyStyleCommand.cpp:
- (StyleChange::init): Changed to always include the direction property
- in the result if the unicode-bidi property is included.
- (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the
- highest ancestor of the given node that establishes bidi embedding. If
- that embedding agrees with the given allowed direction, finds the
- second-highest embedding ancestor. Splits all nodes through that
- ancestor. If the highest embedding ancestor did not need to be split,
- it is returned.
- (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes
- bidi embedding attributes and styles from all ancestors of the given
- node up to its enclosing block or the given node.
- (ApplyStyleCommand::applyInlineStyle): Added code to handle the
- unicode-bidi property. Applying style the includes this property
- involves removing all bidi embedding in effect, except for one-level
- embedding that agrees with the desired embedding, then applying the
- desired embedding where it is not already in effect.
- (ApplyStyleCommand::applyInlineStyleToRange): Factored out from
- applyInlineStyle().
- (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the
- "dir" attribute if necessary and the element if it becomes an unstyled
- style span.
- (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction
- property when removing the unicode-bidi property.
- (ApplyStyleCommand::removeInlineStyle): Added a call to
- removeHTMLBidiEmbeddingStyle().
-
- * editing/ApplyStyleCommand.h:
- * editing/Editor.cpp:
- (Editor::textDirectionForSelection): Added. Returns the character-level
- writing direction of the selection if it is uniform and simple (at most
- one level of embedding).
- (Editor::hasBidiSelection): Added. Returns true if the selection lies
- entirely within a single block, and that block has direction:rtl or
- contains any inline boxes with non-zero bidi embedding level.
-
- * editing/Editor.h:
- * editing/EditorCommand.cpp:
- (stateTextWritingDirection): Added this helper function for deciding
- the state of Text Direction submenu items.
- (executeMakeTextWritingDirectionLeftToRight): Added. Applies
- "unicode-bidi: embed; direction: ltr;".
- (executeMakeTextWritingDirectionNatural): Added. Applies
- "unicode-bidi: normal;"
- (executeMakeTextWritingDirectionRightToLeft): Added. Applies
- "unicode-bidi: embed; direction: rtl;".
- (stateTextWritingDirectionLeftToRight): Added.
- (stateTextWritingDirectionNatural): Added.
- (stateTextWritingDirectionRightToLeft): Added.
- (createCommandMap): Added "MakeTextWritingDirectionLeftToRight",
- "MakeTextWritingDirectionNatural",
- and "MakeTextWritingDirectionRightToLeft".
-
- * editing/InsertTextCommand.cpp:
- (InsertTextCommand::input): Added code to maintain the unicode-bidi
- and direction properties in the typing style. Even if they have the
- same values as the computed style at the caret, they need to be included
- in the typing style so that inserted text will not inherit any nested
- embedding.
-
- * page/ContextMenuController.cpp:
- (ContextMenuController::contextMenuItemSelected): Added calls to
- the editor for the text direction menu items.
-
- * page/Frame.cpp
- (Frame::computeAndSetTypingStyle): Added code to maintain the
- unicode-bidi and direction properties in the typing style.
-
- * page/Settings.cpp:
- (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.
-
- * page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum,
- an m_textDirectionSubmenuInclusionBehavior member, and accessors.
-
- * page/mac/WebCoreViewFactory.h:
- * platform/ContextMenu.cpp:
- (WebCore::createAndAppendTextDirectionSubMenu): Added.
- (ContextMenu::populate): Added the Text Direction submenu item based on
- the inclusion behavior and the existence of a bidi selection.
- (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction
- menu items.
-
- * platform/ContextMenuItem.h:
- * platform/LocalizedStrings.h: Declared
- contextMenuItemTagTextDirectionMenu().
-
- * platform/mac/LocalizedStringsMac.mm: Defined
- contextMenuItemTagTextDirectionMenu().
-
- * rendering/RenderBlock.cpp:
- (RenderBlock::containsNonZeroBidiLevel): Added.
- * rendering/RenderBlock.h:
-
-2008-11-14 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22264
- Need to update to latest Geolocation spec (13 November 2008)
-
- Update to new error code constants and values.
-
- * page/Geolocation.cpp: Use new named ErrorCode enums
- (WebCore::Geolocation::GeoNotifier::timerFired):
- (WebCore::Geolocation::getCurrentPosition):
- (WebCore::Geolocation::watchPosition):
- * page/PositionError.h: Have ErrorCode enum names match new error constant names and values
- (WebCore::PositionError::):
- * page/PositionError.idl: Add new named error constants
-
-2008-11-14 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Justin Garcia.
-
- Fix (again) for <rdar://problem/5089327> Too much indentation when
- pasting quoted paragraphs
-
- This patch goes back to Justin's original approach to fix this bug,
- written in revision 38273. That fix was mostly rolled out by
- revision 38310 because of styling issues created by the addition of
- extra blockquote nodes. This patch again goes back to Justin's
- original fix because of cases we discovered the newer fix could not
- possibly cover. This version of the patch minimizes the styling
- issues of extra blockquotes by opting into the merge start code.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to
- return true when the quoting level of the end of the inserted
- content matches the quoting level of the end of the existing
- content.
- (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls
- hasMatchingQuoteLevel
- (WebCore::ReplaceSelectionCommand::doApply):
-
-2008-11-14 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- Made SVGResourceClipper platform independent.
- https://bugs.webkit.org/show_bug.cgi?id=21444
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::clipPath):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::clipPath):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::addPath):
- (WebCore::GraphicsContext::clipPath):
- * svg/graphics/SVGResourceClipper.cpp:
- (WebCore::SVGResourceClipper::applyClip):
- * svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
- * svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
- * svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.
-
-2008-11-14 Antti Koivisto <antti@apple.com>
-
- Reviewed by Anders Carlsson.
-
- Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
- * loader/FrameLoader.h:
-
-2008-11-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Eric Seidel.
-
- Remove unneeded forward declaration.
-
- * plugins/Plugin.h:
-
-2008-11-14 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22251
- HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h
-
- * html/HTMLCanvasElement.cpp:
-
-2008-11-14 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Add new files from the Qt port to the build.
-
- * WebCore.pro:
-
-2008-11-14 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Made DatabaseTracker::hasEntryForOrigin() public. This allows the Qt
- port to apply a default quota only if there is no entry in the
- database for a given origin yet.
-
- * storage/DatabaseTracker.h:
-
-2008-11-14 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Make it possible to get the cache directory set in the application
- cache storage.
-
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::ApplicationCacheStorage::cacheDirectory): Added.
- * loader/appcache/ApplicationCacheStorage.h:
-
-2008-11-14 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages
-
- When applying block styles, we would add block properties to the body element, and Mail's
- Make Plain Text feature isn't equipped to remove those. This could have been fixed on our side,
- but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.
-
- We have code that puts the paragraphs that we're operating on into blocks of their own before
- adding or removing block properties from the blocks that enclose them. We need to run this code
- when the enclosing block is the body element.
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents
- to here.
- (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity.
- Added a few comments. Fixed bug by not bailing out when the block about to be used is the body element.
- * editing/CompositeEditCommand.h:
-
-2008-11-14 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22245: Move wtf/dtoa.h into the WTF namespace
- <https://bugs.webkit.org/show_bug.cgi?id=22245>
-
- Move wtf/dtoa.h into the WTF namespace from the JSC namespace.
-
- * platform/text/String.cpp:
- (WebCore::charactersToDouble):
-
-2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Make sure Qt scrollbars follow the style with regard to context menus
-
- * platform/qt/ScrollbarQt.cpp:
- (WebCore::Scrollbar::contextMenu):
-
-2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Make scrollbar look active when the window is active on Qt/Mac
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
- (WebCore::ScrollbarThemeQt::paint):
-
-2008-11-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Adam Roben.
-
- Add a basic Scons-based build system for building
- Chromium-Mac WebCore.
- https://bugs.webkit.org/show_bug.cgi?id=21991
-
- The build currently fails due to missing files from our
- platform directory (platform skia and platform chromium)
- I will be sending those up shortly in separate patches.
- I expect it will be a while before our WebCore build links.
-
- * SConstruct: Added.
- * WebCore.scons: Added.
-
-2008-11-13 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22248
- AtomicString.cpp uses JSC types outside of #if USE(JSC)
-
- * platform/text/AtomicString.cpp:
- (WebCore::AtomicString::add):
+ (WebCore::RenderLayer::paintLayer):
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
+ Remove a printf that I left in by mistake.
-2008-11-13 Justin Garcia <justin.garcia@apple.com>
+2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=18620
- Long hang under TextIterator::advance() when loading http://www.lsvd.de/
-
- A huge section at the beginning of this document is invisible. As we iterate through it,
- we create VisiblePositions unnecessarily.
-
- * editing/TextIterator.cpp:
- (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition
- creation if m_node is unrendered or invisible. The answers wouldn't have much meaning
- and would be wasteful. Also fixed some comments to reflect the fact that this function
- isn't specifically about emitting a newline.
-
-2008-11-13 Pierre-Olivier Latour <pol@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove unused or unnecessary code from AnimationBase class.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::AnimationBase):
- (WebCore::AnimationBase::playStatePlaying):
- * page/animation/AnimationBase.h:
-
-2008-11-12 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore
-
- Currently only used by QtWebKit. See also:
-
- https://bugs.webkit.org/show_bug.cgi?id=21427
-
- * WebCore.pro:
- * platform/qt/TemporaryLinkStubs.cpp:
- (PluginView::userAgentStatic):
- (PluginView::getValueStatic):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::handleEvent):
- (WebCore::PluginView::setValue):
- (WebCore::PluginView::PluginView):
- * plugins/PluginView.h:
- (WebCore::PluginView::setPlatformPluginWidget):
- * plugins/mac/PluginPackageMac.cpp: Added.
- (WebCore::PluginPackage::determineQuirks):
- (WebCore::readPListFile):
- (WebCore::stringListFromResourceId):
- (WebCore::PluginPackage::fetchInfo):
- (WebCore::PluginPackage::load):
- (WebCore::PluginPackage::hash):
- (WebCore::PluginPackage::equal):
- (WebCore::PluginPackage::compareFileVersion):
- * plugins/mac/PluginViewMac.cpp: Added.
- (WebCore::nativeWindowFor):
- (WebCore::cgHandleFor):
- (WebCore::topLevelOffsetFor):
- (WebCore::PluginView::init):
- (WebCore::PluginView::~PluginView):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::getValueStatic):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::setParent):
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setFocus):
- (WebCore::PluginView::setParentVisible):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::setNPWindowIfNeeded):
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::paint):
- (WebCore::PluginView::invalidateRect):
- (WebCore::PluginView::invalidateRegion):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::handleMouseEvent):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::nullEventTimerFired):
- (WebCore::modifiersForEvent):
- (WebCore::PluginView::globalMousePosForPlugin):
- (WebCore::PluginView::dispatchNPEvent):
- (WebCore::PluginView::userAgent):
- (WebCore::PluginView::userAgentStatic):
- (WebCore::PluginView::handlePostReadFile):
+ WebCore side of <rdar://problem/6946094>.
+
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::setExternalDataObject):
+ * platform/win/ClipboardWin.h:
-2008-11-12 Alexey Proskuryakov <ap@webkit.org>
+2009-06-23 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=22200
- Crash when close event is dispatched to MessagePort due to document destruction
+ https://bugs.webkit.org/show_bug.cgi?id=26650
- Test: fast/events/message-port-onclose.html
+ Add setFormContentType and setFormData since it is awkward for Chromium
+ to use setFormInfoFromRequest to set the underlying members. Also, add
+ a clearChildren method that Chromium needs. These methods are used as
+ part of the Chromium code that serializes a HistoryItem for storing in
+ the browser's session history.
- * dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed):
- Don't dispatch close event, even though HTML5 currently says that we should. It is not
- right for GC to have observable effects.
+ * history/HistoryItem.cpp:
+ * history/HistoryItem.h:
-2008-11-12 Alexey Proskuryakov <ap@webkit.org>
+2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=22203
- Implement Worker messaging
-
- No test cases included, because this functionality is disabled by default.
-
- The implementation is known to still have many race condition, but works quite well for
- testing.
-
- * WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::markActiveObjectsForContext): Re-worded comments a little.
- (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was
- incorrect, changed it to a much simpler (but still incorrect) version.
-
- * dom/WorkerTask.cpp: Added.
- (WebCore::WorkerTask::~WorkerTask):
- * dom/WorkerTask.h: Added.
- Tasks posted to workers implement this new interface.
-
- * bindings/js/JSDedicatedWorkerCustom.cpp:
- (WebCore::JSDedicatedWorker::mark):
- (WebCore::JSDedicatedWorker::connect):
- * dom/DedicatedWorker.h:
- * dom/DedicatedWorker.idl:
- Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking
- WHATWG discussions.
-
- * dom/DedicatedWorker.cpp:
- (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect()
- operations.
- (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer.
- (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts
- one to worker. Since message port registration in ScriptExecutionContext is not thread safe,
- this port starts with a null context pointer.
- (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately
- after creation, we have to queue tasks until after a WorkerThread object is created. Then we
- forward all queued tasks to its queue.
-
- * dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
- * dom/EventTarget.h:
- * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- Added cases for WorkerContext, which is now an EventTarget, too.
-
- * bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
- * bindings/js/JSWorkerContext.cpp:
- (WebCore::JSWorkerContext::mark): Mark event listeners.
- (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID.
- (WebCore::JSWorkerContext::put): Implemented.
- (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation.
- (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto.
- (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto.
- (WebCore::jsWorkerContextOnconnect): Added.
- (WebCore::setJSWorkerContextOnconnect): Added.
-
- * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- Made it actually work by adding necessary setup.
-
- * bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded):
- Check the right variable - it is the wrapper that may not be initialized yet.
-
- * dom/ActiveDOMObject.cpp:
- (WebCore::ActiveDOMObject::ActiveDOMObject):
- (WebCore::ActiveDOMObject::~ActiveDOMObject):
- Assert being called from the correct thread, as active DOM object tracking is not thread safe.
-
- * dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used
- for asynchronously executing tasks in context's thread.
-
- * dom/ScriptExecutionContext.cpp:
- (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task
- (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer.
- It was an optimization that couldn't be easily preserved without introducing race conditions
- in multithreading case.
- (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask().
- (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining
- why it's OK to not ref() ports in a frozen copy.
- (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called
- from a wrong thread.
- (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto.
- (WebCore::ScriptExecutionContextTaskTimer): Part of
- ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main
- thread.
- (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting
- to a worker.
- (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting
- to main thread from a secondary one.
- (WebCore::performTask): A helper function for callOnMainThread().
- (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
-
- * dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would
- ref/deref EventData::message from different threads, which is not allowed.
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads.
- (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now.
- (WebCore::MessagePort::EventData::EventData): Ditto.
- (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at
- first, because we need to create ports for posting to other threads, and it is not possible
- to register in a context from another thread.
- (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message
- receiver's job to set the context.
- (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any
- context yet.
- (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached.
- (WebCore::MessagePort::contextDestroyed): Assert that we had a context.
- (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in
- context.
- (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual.
- (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask().
- (WebCore::MessagePort::queueCloseEvent): Use postTask().
- (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above,
- MessagePort cross-heap GC is still quite wrong.
-
- * dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
- * dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions
- now, but there is no harm in tracking it in release builds, too.
-
- * dom/WorkerThread.cpp:
- (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create().
- (WebCore::WorkerThread::workerThread): Implemented a message loop.
- * dom/WorkerThread.h:
- (WebCore::WorkerThread::threadID): Also only used for assertions.
- (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it
- always sets it to null.
- (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
-
-2008-11-12 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed Darin Adler.
-
- use strokeColor.alpha() instead of fillColor.alpha()
- on GraphicsContext::strokePath()
-
- [Canvas] Transparent fillStyle stops line rendering
- https://bugs.webkit.org/show_bug.cgi?id=21888
-
- Test: fast/canvas/canvas-stroke-empty-fill.html
-
- * ChangeLog:
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::strokePath):
-
-2008-11-12 Stephanie <slewis@apple.com>
-
- Reviewed by Mark Rowe.
-
- Fix context leak in XSLStyleSheets.
- See bug https://bugs.webkit.org/show_bug.cgi?id=15715
-
- * xml/XSLStyleSheet.cpp:
- (WebCore::XSLStyleSheet::parseString):
-
-2008-11-12 Alp Toker <alp@nuanti.com>
-
- autotools: List web worker-related headers needed for a successful
- build. distcheck is passing again with this change.
-
- * GNUmakefile.am:
-
-2008-11-12 Alp Toker <alp@nuanti.com>
-
- autotools build system fix-up only. Add FloatQuad.h to the source
- lists and sort them.
-
- * GNUmakefile.am:
-
-2008-11-12 Alp Toker <alp@nuanti.com>
-
- Build fixes for r38346. FloatQuad.cpp is missing:
-
- 1) #include "config.h"
- 2) #include <algorithm> for various mathematical definitions it uses.
-
- * platform/graphics/FloatQuad.cpp:
-
-2008-11-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22212
-
- Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
- it may be the bounding outline box of a transformed element, and fix it
- to respect transforms by mapping the outline box to an absolute quad and
- taking the enclosing rect.
-
- RenderBox::localToAbsoluteQuad() can no longer assert that there is no
- LayoutState, but LayoutState cannot be used during quad mapping (it knows
- nothing about transforms).
-
- Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
- borderTopExtra() from the object, rather than its container (as localToAbsolute()
- does).
-
- Test: fast/repaint/transform-absolute-child.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localToAbsoluteQuad):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- * rendering/RenderForeignObject.cpp:
- (WebCore::RenderForeignObject::layout):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::setHasVisibleContent):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- (WebCore::RenderObject::absoluteOutlineBounds):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::layout):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::layout):
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::layout):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::layout):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::layout):
- * rendering/RenderSVGViewportContainer.cpp:
- (WebCore::RenderSVGViewportContainer::layout):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::layout):
-
-2008-11-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=21942
- https://bugs.webkit.org/show_bug.cgi?id=18557
-
- Add methods which can be used to map renderer-local rectangles
- to quads in absolute coordinates, taking transforms into account:
- localToAbsoluteQuad() converts a local rect into an absolute quad.
- collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()
- that works with quads.
- absoluteQuads() is an analogue of absoluteRects(), for quads.
-
- Use the quad methods to fix the inspector highlight for transformed
- elements.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * inspector/InspectorController.cpp:
- (WebCore::drawOutlinedQuad):
- (WebCore::drawHighlightForBoxes):
- (WebCore::frameToMainFrameOffset):
- (WebCore::InspectorController::drawNodeHighlight):
- * platform/graphics/AffineTransform.cpp:
- (WebCore::AffineTransform::mapQuad):
- * platform/graphics/AffineTransform.h:
- * platform/graphics/FloatQuad.cpp: Added.
- (WebCore::min4):
- (WebCore::max4):
- (WebCore::FloatQuad::boundingBox):
- * platform/graphics/FloatQuad.h: Added.
- (WebCore::FloatQuad::FloatQuad):
- (WebCore::FloatQuad::p1):
- (WebCore::FloatQuad::p2):
- (WebCore::FloatQuad::p3):
- (WebCore::FloatQuad::p4):
- (WebCore::FloatQuad::setP1):
- (WebCore::FloatQuad::setP2):
- (WebCore::FloatQuad::setP3):
- (WebCore::FloatQuad::setP4):
- (WebCore::FloatQuad::isEmpty):
- (WebCore::FloatQuad::enclosingBoundingBox):
- (WebCore::FloatQuad::move):
- (WebCore::operator+=):
- (WebCore::operator-=):
- (WebCore::operator==):
- (WebCore::operator!=):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localToAbsoluteQuad):
- * rendering/RenderBox.h:
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- * rendering/RenderContainer.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::absoluteQuads):
- * rendering/RenderInline.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteBoundingBoxRect):
- (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
- (WebCore::RenderObject::absoluteQuads):
- (WebCore::RenderObject::localToAbsoluteQuad):
- (WebCore::RenderObject::absoluteContentQuad):
- * rendering/RenderObject.h:
- * rendering/RenderPath.cpp:
- (WebCore::RenderPath::absoluteQuads):
- * rendering/RenderPath.h:
- * rendering/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::absoluteQuads):
- * rendering/RenderSVGContainer.h:
- * rendering/RenderSVGHiddenContainer.cpp:
- (WebCore::RenderSVGHiddenContainer::absoluteQuads):
- * rendering/RenderSVGHiddenContainer.h:
- * rendering/RenderSVGImage.cpp:
- (WebCore::RenderSVGImage::calculateAbsoluteBounds):
- (WebCore::RenderSVGImage::absoluteQuads):
- * rendering/RenderSVGImage.h:
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::absoluteQuads):
- (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
- * rendering/RenderSVGInlineText.h:
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::absoluteQuads):
- * rendering/RenderSVGRoot.h:
- * rendering/RenderSVGTSpan.cpp:
- (WebCore::RenderSVGTSpan::absoluteRects):
- (WebCore::RenderSVGTSpan::absoluteQuads):
- * rendering/RenderSVGTSpan.h:
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- (WebCore::RenderSVGText::absoluteQuads):
- * rendering/RenderSVGText.h:
- * rendering/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::absoluteRects):
- (WebCore::RenderSVGTextPath::absoluteQuads):
- * rendering/RenderSVGTextPath.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::localToAbsolute):
- (WebCore::RenderTableCell::localToAbsoluteQuad):
- * rendering/RenderTableCell.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::absoluteQuads):
- (WebCore::RenderText::collectAbsoluteLineBoxQuads):
- * rendering/RenderText.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::localToAbsoluteQuad):
- (WebCore::RenderView::absoluteQuads):
- * rendering/RenderView.h:
-
-2008-11-12 Brent Fulgham <bfulgham@gmail.com>
-
- Fix Bug 22178: Build errors in WebKit Cairo port
-
- <https://bugs.webkit.org/show_bug.cgi?id=22178>
-
- Reviewed by Mark Rowe.
-
- * platform/graphics/cairo/PatternCairo.cpp: Correct build error under
- Visual Studio.
- (WebCore::Pattern::createPlatformPattern):
-
-2008-11-12 Adam Roben <aroben@apple.com>
-
- Fix a typo in the include path for the Release_Cairo configuration
-
- * WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
-
-2008-11-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=17840
- Patch 2
-
- Code cleanup in RenderBox::computeAbsoluteRepaintRect().
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
-
-2008-11-12 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=17840
-
- Fix repainting when the transform on a positioned element changes.
- In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
- and being in a positioned container after applying the transform to the local
- rect.
-
- Tests: fast/repaint/transform-absolute-in-positioned-container.html
- fast/repaint/transform-relative-position.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
-
-2008-11-12 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/5495723> Selecting and deleting quoted text quotes other text
- <rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted
-
- We don't want to merge into a block if it will mean changing the quote level of content after deleting
- selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
- that such a selection actually ends at the start of the next paragraph. Instead we want to completely
- remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
- for indented paragraphs.
-
- * editing/DeleteSelectionCommand.cpp:
- (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not
- try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied
- so that we remove evidence of the deleted paragraphs' quote level.
- (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also
- make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection
- started on, instead of one higher.
- * editing/DeleteSelectionCommand.h:
- * editing/htmlediting.cpp:
- (WebCore::numEnclosingMailBlockquotes): Added.
- * editing/htmlediting.h:
-
-2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Move _web_encodingForResource from WebKit into WebCore and change return type
-
- This change is needed to implement NSAPI in WebCore for Mac, see:
-
- https://bugs.webkit.org/show_bug.cgi?id=21427
-
- * WebCore.base.exp:
- * platform/mac/WebCoreNSStringExtras.h:
- * platform/mac/WebCoreNSStringExtras.mm:
- (stringEncodingForResource):
-
-2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
- WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.
-
- This change is needed to implement NSAPI in WebCore for Mac, see:
+ <rdar://problem/6978938> Need HTML 5 event attributes for media elements
- https://bugs.webkit.org/show_bug.cgi?id=21427
+ Test: media/event-attributes.html
- * WebCore.base.exp:
- * platform/mac/WebCoreNSStringExtras.h:
- * platform/mac/WebCoreNSStringExtras.mm:
- (stringIsCaseInsensitiveEqualToString):
-
-2008-11-11 Stephanie <slewis@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Null check image data before setting it as image source.
-
- Test: fast/images/image-empty-data.html
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::destroyDecodedData):
-
-2008-11-11 Adele Peterson <adele@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Remove ifdef so future OS versions can use the new delegate method.
-
- * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
-
-2008-11-11 Eric Seidel <eric@webkit.org>
-
- Reviewed by Antti Koivisto and Sam Weinig.
-
- Clean up HTMLTokenizer a litle
- https://bugs.webkit.org/show_bug.cgi?id=22188
-
- Rename pendingScripts to m_pendingScripts
- Rename scriptNode to m_scriptNode make the type specific
- Rename pendingSrc to m_pendingSrc
- Rename currentPrependingSrc to m_currentPrependingSrc
- Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
- Remove long-since-dead kdDebug and qDebug calls
- Rename brokenComments to m_brokenComments
- Remove HTMLTokenizer includes and document the rest
- Rename src to m_src
- Rename parser to m_parser and make it an OwnPtr
- Rename inWrite to m_inWrite and jsProxy to scriptController
- Rename brokenServer to m_brokenServer
- Rename buffer to m_buffer and dest to m_dest
- Rename size to m_bufferSize
- Rename attrName to m_attrName
- Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
- Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
- Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
- Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
- Rename flat to selfClosingTag
- Rename currToken to m_currentToken
-
- * css/CSSParser.cpp:
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizerLibxml2.cpp:
- * html/HTMLDocument.cpp:
- * html/HTMLElement.cpp:
- * html/HTMLFormControlElement.cpp:
- * html/HTMLParser.h:
- * html/HTMLTokenizer.cpp:
- (WebCore::Token::addAttribute):
- (WebCore::HTMLTokenizer::HTMLTokenizer):
- (WebCore::HTMLTokenizer::reset):
- (WebCore::HTMLTokenizer::begin):
- (WebCore::HTMLTokenizer::processListing):
- (WebCore::HTMLTokenizer::parseSpecial):
- (WebCore::HTMLTokenizer::scriptHandler):
- (WebCore::HTMLTokenizer::scriptExecution):
- (WebCore::HTMLTokenizer::parseComment):
- (WebCore::HTMLTokenizer::parseServer):
- (WebCore::HTMLTokenizer::parseProcessingInstruction):
- (WebCore::HTMLTokenizer::parseText):
- (WebCore::HTMLTokenizer::parseEntity):
- (WebCore::HTMLTokenizer::parseTag):
- (WebCore::HTMLTokenizer::write):
- (WebCore::HTMLTokenizer::processingData):
- (WebCore::HTMLTokenizer::end):
- (WebCore::HTMLTokenizer::finish):
- (WebCore::HTMLTokenizer::processToken):
- (WebCore::HTMLTokenizer::processDoctypeToken):
- (WebCore::HTMLTokenizer::~HTMLTokenizer):
- (WebCore::HTMLTokenizer::enlargeBuffer):
- (WebCore::HTMLTokenizer::enlargeScriptBuffer):
- (WebCore::HTMLTokenizer::notifyFinished):
- (WebCore::HTMLTokenizer::setSrc):
- * html/HTMLTokenizer.h:
- (WebCore::Token::Token):
- (WebCore::Token::reset):
- (WebCore::HTMLTokenizer::processingContentWrittenByScript):
- (WebCore::HTMLTokenizer::htmlParser):
- (WebCore::HTMLTokenizer::checkBuffer):
- (WebCore::HTMLTokenizer::checkScriptBuffer):
- * html/HTMLViewSourceDocument.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::leftRelOffset):
- (WebCore::RenderBlock::rightRelOffset):
- (WebCore::RenderBlock::lineWidth):
- * xml/XSLTProcessor.cpp:
-
-2008-11-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
- Track CachedScript decoded data
-
- We now track the decoded size of CachedScripts in the Cache allowing
- them to accounted for when deciding when to evict data. The decoded
- data itself can be evicted when Cache pressure gets high enough through
- CachedScript::destroyDecodedData.
-
- * loader/CachedResource.h:
- (WebCore::CachedResource::allClientsRemoved):
- (WebCore::CachedResource::destroyDecodedData):
- * loader/CachedScript.cpp:
- (WebCore::CachedScript::script):
- (WebCore::CachedScript::data):
- (WebCore::CachedScript::destroyDecodedData):
- * loader/CachedScript.h:
-
-2008-11-11 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Remove pointless dependencies on the now-deleted kjs directory and
- mentions of it in comments that are no longer relevant.
-
- * WebCore.pro:
- * webcore-base.bkl:
-
-2008-11-11 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adam Roben.
-
- WebCore part of adding a master volume control for media elements in a WebView
-
- * WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
- * dom/Document.cpp:
- (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page
- when the media volume is changed.
- (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows
- elements to register for a callback when the media volume is changed.
- (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows
- elements to unregister for the callback.
- * dom/Document.h:
- * dom/Element.h:
- (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
+ * html/HTMLAttributeNames.in: Add media event attribute names.
* html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to
- registerForMediaVolumeCallbacks().
- (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to
- unregisterForMediaVolumeCallbacks().
- (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the
- element's intrinsic volume by the master volume from the page.
- (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls
- updateVolume().
- * html/HTMLMediaElement.h:
- * page/Page.cpp:
- (WebCore::Page::Page): Initialize m_mediaVolume to 1.
- (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on
- every document in the page when the master volume changes.
- * page/Page.h:
- (WebCore::Page::mediaVolume): Added this getter.
-
-2008-11-11 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=22182
-
- Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
- is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
- errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.
-
- Reviewed by Adele
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::mouseDown):
-
-2008-11-11 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for <rdar://problem/5089327> Too much indentation when pasting
- quoted paragraphs
-
- This patch re-addresses pasting blockquotes into blockquotes. It
- backs out most of revision 38273. 38273 fixed the bug by inserting
- the pasted content as a sibling blockquote node to the pre-existing
- blockquote node. The problem with that is that by default,
- blockquotes have a giant margin, so visually, this can be weird.
- This patch instead inserts the pasted content as siblings of the
- the content already inside the outer blockquote, and then removes
- the blockquote node from the pasted content itself, so that it
- doesn't nest itself into the outer blockquote.
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::doApply):
-
- Move contains() from Element to Node since there is nothing
- Element-specific about it.
- * dom/Element.cpp:
- * dom/Element.h:
- * dom/Node.cpp:
- (WebCore::Node::contains):
- * dom/Node.h:
-
-2008-11-11 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=17997
-
- Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
- is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
- is a Leopard-only workaround, since the API has been fixed on Snow Leopard.
-
- Reviewed by John Sullivan
-
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::Image::drawPattern):
-
-2008-11-10 David Hyatt <hyatt@apple.com>
-
- Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
- when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
- how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.
-
- Reviewed by Adam Roben
-
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::isControlStyled):
-
-2008-11-11 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22160
- speculative fix for <rdar://problem/5995450> Nil deref because nextLinePosition
- (previousLinePosition, too) uses a nil node
-
- * editing/visible_units.cpp:
- (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element
- to check editingIgnoresContent. It makes sense to use the associated DOM node for
- this, even in cases of anonymous content, and it avoids the case where element() can
- be 0.
- (WebCore::previousLinePosition): Ditto.
-
-2008-11-11 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Darin Adler.
-
- Removed default: in applySpreadMethod. This causes the problems
- in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
- or CSS.
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::applySpreadMethod):
-
-2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix crash when rendering the file chooser.
- Also proper implementation for multi-selected files.
-
- * platform/qt/FileChooserQt.cpp:
- (WebCore::FileChooser::basenameForWidth):
-
-2008-11-11 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Oliver Hunt.
-
- PatternCairo needs to invert the pattern matrix because
- of transformation from user space to pattern space.
- Give a identity matrix to pattern for Qt and Cairo. Because the
- context is transformed already.
-
- [CAIRO][QT] Canvas transformations applied twice to Patterns
- https://bugs.webkit.org/show_bug.cgi?id=21555
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- * platform/graphics/cairo/PatternCairo.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
-
-2008-11-10 Stephanie Lewis <slewis@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Clear the image source cache even if we haven't decoded any of the image data.
- We use the image source cache when calculating layout.
-
- * loader/Cache.cpp:
- (WebCore::Cache::pruneDeadResources):
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::destroyDecodedData):
-
-2008-11-10 Adam Roben <aroben@apple.com>
-
- Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
- loading microsoftpdc.com
-
- <https://bugs.webkit.org/show_bug.cgi?id=22161>
-
- Reviewed by Dan Bernstein.
-
- Test: fast/css/outline-invert-assertion.html
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::systemColor): If we can't determine a good
- Win32 system color to use, defer to RenderTheme instead of asserting.
- This matches what RenderThemeMac does.
-
-2008-11-10 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
- into quoted text yields double-quoting
-
- Don't nest inserted content in Mail blockquotes. Perform a
- BreakBlockquoteCommand if we're in
- one and insert the incoming fragment between the split blockquotes.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from ->
- source and to -> destination.
- (WebCore::ReplaceSelectionCommand::doApply):
-
-2008-11-10 Adam Roben <aroben@apple.com>
-
- Fix Bug 22158: Would like to turn on WebCore logging channels via an
- environment variable
-
- <https://bugs.webkit.org/show_bug.cgi?id=22158>
-
- Logging channels can now be enabled by setting the WebCoreLogLevel
- environment variable to a hexadecimal number.
-
- Reviewed by Anders Carlsson.
-
- * WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
- * platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm.
- (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel
- environment variable, parse its value as a hexadecimal number, and
- turn the channel on/off based on whether the mask bit is set.
- (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each
- logging channel in turn.
-
-2008-11-10 Darin Adler <darin@apple.com>
-
- Reviewed by Adam Roben.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=22103
- Changing fonts in preferences does not immediately update WebViews
-
- This broke when the meaning of FrameView::invalidate changed.
- I changed setNeedsReapplyStyles to no longer depend on invalidate.
-
- * dom/Document.cpp: (WebCore::Document::shouldScheduleLayout):
- Removed the part of this function that duplicated what's already in
- FrameView::needsLayout, since the copy here left out a few key things.
- For example, it didn't handle the fact that "needs reapply styles"
- counts as needing layout.
-
- * page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called
- FrameView::invalidate before. There were two things wrong with that.
- 1) It requested that the entire view repaint even if the style change
- didn't necessitate that. 2) FrameView::invalidate no longer causes any
- repainting at all in certain cases, because of Hyatt's changes to how
- widgets and the host window are involved in the repainting process.
- So call FrameView::scheduleRelayout instead, which is more precisely
- what we want and need here.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here
- so that Document::shouldScheduleLayout doesn't have to replicate the
- logic that's in needsLayout and can instead rely on the fact that it
- was already called.
- (WebCore::FrameView::needsLayout): Tweaked the comments and formatting
- in this function.
-
-2008-11-10 Darin Adler <darin@apple.com>
-
- Reviewed by Adam Roben.
-
- - speculative fix for <rdar://problem/5557243> crashes in Safari at
- WebCore::HTMLSelectElement::updateListBoxSelection + 280
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::updateListBoxSelection):
- Check index against size of vector before indexing into the vector.
-
-2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix QtWebkit build failure on arm.
-
- pen.widthF() is a qreal, which means it's a float on arm.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::setLineDash):
-
-2008-11-10 Morten Sørvig <msorvig@trolltech.com>
-
- Reviewed by Simon Hausmann.
-
- Improve mouse wheel scolling on Qt/Cocoa.
- Cocoa differs from Carbon (and other platforms I think) in that the
- mouse wheel events we get have a much higher acceleration factor.
-
- This submit switches over to scroll-per-pixel from scroll-per-line
- for most of our scrolling views. This matches the native views
- and works well with the increased acceleration.
-
- * platform/qt/WheelEventQt.cpp:
-
-2008-11-09 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 19541: Null pointer in showModalDialog()
- <https://bugs.webkit.org/show_bug.cgi?id=19541>
-
- Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
- and JSDOMWindowBase::canShowModalDialogNow()C
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::canShowModalDialog):
- (WebCore::canShowModalDialogNow):
-
-2008-11-09 Darin Adler <darin@apple.com>
-
- - try to fix Windows build
-
- * platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules
- about needed a separate definition for static const integer data members.
- Until I get to the bottom of this, put the definitions inside an ifdef.
-
-2008-11-09 David Kilzer <ddkilzer@apple.com>
-
- BUILD FIX: Qt build broke after r38235.
-
- Added HAVE(ACCESSIBILITY) header guards to platform implementation
- source files.
-
- * page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY)
- guards.
- * page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
- * page/qt/AccessibilityObjectQt.cpp: Ditto.
- * page/win/AccessibilityObjectWin.cpp: Ditto.
- * page/wx/AccessibilityObjectWx.cpp: Ditto.
-
-2008-11-09 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22104
- Javascript URL percent encoding/decoding broken by some characters
-
- Test: fast/loader/javascript-url-encoding-2.html
-
- * platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
-
-2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed and tweaked by Darin Adler.
+ (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.
- * platform/graphics/Color.cpp: Added definitions for the static data members
- in this class. Static data members need a definition, even when they are the
- simple integer constant kind that can be initialized in the header.
-
-2008-11-08 Antti Koivisto <antti@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=22141
- REGRESSION: Safari error page is not fully styled when loaded from cache
-
- Reset text decoder on flush so it does not pass through the BOM when it is reused.
-
- Test: fast/encoding/css-cached-bom.html
-
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::flush):
-
-2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Mark Rowe.
-
- Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
- it was causing these errors to end up in the page's text representation.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::downloadTimerCallback):
-
-2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after addition of JSCore parser and bycompiler dirs.
-
- * webcore-base.bkl:
- * webcore-wx.bkl:
-
-2008-11-08 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=21906
-
- Override addFocusRingRects() in RenderTextControl to avoid
- the RenderFlow behavior of recursing on descendent renderers.
- RenderTextControl should only ever need a simple focus rect.
-
- This fixes focus ring issues with transforms on text controls.
-
- Test: fast/transforms/transformed-focused-text-input.html
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::addFocusRingRects):
- * rendering/RenderTextControl.h:
-
-2008-11-08 Dimitri Dupuis-Latour <dupuislatour@apple.com>
-
- Make sure the icon thumbnail width/height is at least 1px in
- the Web Inspector's resource panel.
-
- <rdar://problem/5988888>
-
- Reviewed by Tim Hatcher.
-
- * inspector/front-end/inspector.css:
-
-2008-11-08 David Kilzer <ddkilzer@apple.com>
-
- Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled
-
- <https://bugs.webkit.org/show_bug.cgi?id=22137>
-
- Reviewed by Darin Adler.
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- Provide a default implementation when HAVE(ACCESSIBILITY) is false.
- * page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
- * page/mac/AccessibilityObjectMac.mm: Ditto.
- * page/mac/AccessibilityObjectWrapper.mm: Ditto.
-
-2008-11-08 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - WebCore part of adding WebPreferences for controlling databases and local storage
-
- * WebCore.base.exp: Exported Settings::setDatabasesEnabled() and
- Settings::setLocalStorageEnabled().
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage
- is disabled in settings.
- (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases
- are disabled in settings.
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Initialize m_databasesEnabled and
- m_localStorageEnabled.
- (WebCore::Settings::setDatabasesEnabled): Added.
- (WebCore::Settings::setLocalStorageEnabled): Added.
- * page/Settings.h:
- (WebCore::Settings::databasesEnabled): Added.
- (WebCore::Settings::localStorageEnabled): Added.
-
-2008-11-07 Alp Toker <alp@nuanti.com>
-
- Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
- now require that only their top-level header file is included.
-
- Patch tested and still builds fine with older GTK+ versions (back to
- 2.8).
-
- Future WebKit GTK+ contributions are required to adhere to this
- policy.
-
- * platform/gtk/FileSystemGtk.cpp:
- * platform/gtk/KeyEventGtk.cpp:
- * platform/gtk/MouseEventGtk.cpp:
- * platform/gtk/WheelEventGtk.cpp:
- * platform/gtk/gtkdrawing.h:
- * plugins/gtk/gtk2xtbin.c:
- * plugins/gtk/gtk2xtbin.h:
-
-2008-11-07 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker
-
- Explicitly initialize the NPDrawingModelCoreAnimation.
-
- * bridge/npapi.h:
-
-2008-11-07 Alp Toker <alp@nuanti.com>
-
- autotools fix. Always use the configured perl binary (which may be
- different to the one in $PATH) when generating sources.
-
- * GNUmakefile.am:
-
-2008-11-07 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- https://bugs.webkit.org/show_bug.cgi?id=22122
-
- Use a stack-based object to simplify the pushLayoutState/popLayoutState
- code. LayoutStateMaintainer either pushes in the constructor, or allows
- an explicit push() later. Both cases require an explicit pop().
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::layout):
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutBlock):
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::layout):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::layout):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::setCellWidths):
- (WebCore::RenderTableSection::calcRowHeight):
- (WebCore::RenderTableSection::layoutRows):
- * rendering/RenderView.h:
- (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
- (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
- (WebCore::LayoutStateMaintainer::pop):
- (WebCore::LayoutStateMaintainer::push):
- (WebCore::LayoutStateMaintainer::didPush):
-
-2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Fix the QtWebKit build on Mac
-
- * platform/qt/TemporaryLinkStubs.cpp:
- (PluginView::invalidateRect):
-
-2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Don't allow Phonon's invisible video widget to keep the app running
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
-
-2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>
+2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
- Fix valgrind warning about uninitialized lastStop variable.
-
- * platform/graphics/qt/GradientQt.cpp:
- (WebCore::Gradient::platformGradient):
-
-2008-11-07 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Fix layout test brokenness following r38211.
-
- * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
- Restore old Shift key behavior. We ignore Shift key state when matching access keys (which
- matches neither IE nor Firefox), and this patch made WebKit behave like Firefox
- inadvertently. This may or may not be a good thing, but it's certainly not something that
- should change by accident.
-
-2008-11-06 Antti Koivisto <antti@apple.com>
-
- Eh, this trivial last minute change was wrong.
-
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::sheetText):
-
-2008-11-06 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22093
-
- Delaying the text decoding caused regression since the decoding
- also determines the encoding in case of @charset rule.
-
- Decode immediately in data() and keep the decoded string around
- during the checkNotify().
-
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::sheetText):
- (WebCore::CachedCSSStyleSheet::data):
- * loader/CachedCSSStyleSheet.h:
-
-2008-11-06 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22097
- Expose MessageEvent constructor on WorkerContext
-
- * bindings/js/JSWorkerContext.cpp:
- (WebCore::jsWorkerContextMessageEvent):
- (WebCore::setJSWorkerContextMessageEvent):
-
-2008-11-06 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21107
- <rdar://problem/6264219> New access key combination conflicts with VoiceOver
-
- * page/EventHandler.h:
- * page/gtk/EventHandlerGtk.cpp:
- (WebCore::EventHandler::accessKeyModifiers):
- * page/qt/EventHandlerQt.cpp:
- (WebCore::EventHandler::accessKeyModifiers):
- * page/win/EventHandlerWin.cpp:
- (WebCore::EventHandler::accessKeyModifiers):
- * page/wx/EventHandlerWx.cpp:
- (WebCore::EventHandler::accessKeyModifiers):
- Access access key modifiers via a function, not a static variable.
-
- * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers):
- Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is
- less troublesome than one with VO keys.
-
- * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
- Also fix an access key matching bug introduced in r32424 - Any superset of specified
- modifier set invoked access keys. We can use simple equality comparison instead because
- CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
-
-2008-11-06 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
+ Fix Qt build with Phonon.
- https://bugs.webkit.org/show_bug.cgi?id=22115
- NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
-
- Export _NPN_HasMethod and _NPN_HasProperty.
-
- * WebCore.NPAPI.exp:
-
-2008-11-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=15678
-
- Fix transformed menu selects to show the popup in the correct
- location.
-
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::showPopup):
-
-2008-11-06 David Kilzer <ddkilzer@apple.com>
-
- BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
-
- Apparently older versions of gcc have issues with this patch.
- Backing out a second time until the issues are resolved.
-
-2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21106: .in format discussed changes
- https://bugs.webkit.org/show_bug.cgi?id=21106
-
- Include the namespace into the interfaceName.
-
- * dom/make_names.pl: Do not append the namespace when
- using the interfaceName.
- * html/HTMLTagNames.in: Added namespace prefix for custom
- interfaceName.
- * svg/svgtags.in: Ditto.
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Geoff Garen.
-
- Move the remaining files in the kjs subdirectory of JavaScriptCore to
- a new parser subdirectory, and remove the kjs subdirectory entirely.
-
- * ForwardingHeaders/kjs: Removed.
- * ForwardingHeaders/kjs/Parser.h: Removed.
- * ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
- * ForwardingHeaders/kjs/SourceCode.h: Removed.
- * ForwardingHeaders/kjs/SourceProvider.h: Removed.
- * ForwardingHeaders/parser: Added.
- * ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
- * ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
- * ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * bindings/js/StringSourceProvider.h:
- * bindings/js/WorkerScriptController.cpp:
- * bridge/NP_jsobject.cpp:
- * bridge/jni/jni_jsobject.mm:
- * bridge/testbindings.pro:
- * inspector/JavaScriptDebugServer.cpp:
-
-2008-11-06 David Kilzer <ddkilzer@apple.com>
-
- BUILD WAS NOT BROKEN: Rolling r38189 back in.
-
- Please perform a clean build if you see crashes.
-
-2008-11-06 David Kilzer <ddkilzer@apple.com>
-
- BUILD FIX: Backed out r38189 since it apparently broke the world.
-
-2008-11-06 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
- https://bugs.webkit.org/show_bug.cgi?id=22112
-
- Test: accessibility/content-editable.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isReadOnly):
-
-2008-11-06 Sam Weinig <sam@webkit.org>
-
- Reviewed by Alice Liu.
-
- Fix failed assert at launch caused by unintialized data member on the mac.
-
- * platform/network/mac/NetworkStateNotifierMac.cpp:
- (WebCore::NetworkStateNotifier::NetworkStateNotifier):
-
-2008-11-06 Steve Falkenburg <sfalken@apple.com>
-
- Fix failed assert at launch caused by unintialized data member.
-
- Reviewed by Maciej Stachowiak.
-
- * platform/network/win/NetworkStateNotifierWin.cpp:
- (WebCore::NetworkStateNotifier::NetworkStateNotifier):
-
-2008-11-06 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Antti Koivisto
-
- https://bugs.webkit.org/show_bug.cgi?id=22109
- Make <input type="range"> work correctly with transforms
-
- Test: fast/forms/slider-transformed.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler):
- Compute a correct local point when the event is retargeted
- * rendering/RenderSlider.cpp:
- (WebCore::HTMLSliderThumbElement::defaultEventHandler):
- Compute m_initialClickPoint in slider-local coords, so that
- deltas are computed correctly with transforms
- (WebCore::RenderSlider::mouseEventIsInThumb):
- Rather than computing an absolute bounds for the thumb,
- convert the point to local coords and compare it with the border box.
-
-2008-11-06 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
- https://bugs.webkit.org/show_bug.cgi?id=21810
-
- * bindings/js/GCController.cpp:
- (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::wrapperSet): Ditto
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::wrappers): Ditto
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::wrappers): Ditto
- * bridge/runtime_root.cpp:
- (JSC::Bindings::rootObjectSet): Ditto
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText): Ditto
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType): Ditto
- * css/CSSStyleSelector.cpp:
- (WebCore::screenEval): Ditto
- (WebCore::printEval): Ditto
- * dom/DOMImplementation.cpp:
- (WebCore::isSVG10Feature): Ditto
- (WebCore::isSVG11Feature): Ditto
- (WebCore::DOMImplementation::isXMLMIMEType): Ditto
- * dom/Document.cpp:
- (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
- * dom/ScriptElement.cpp:
- (WebCore::isSupportedJavaScriptLanguage): Ditto
- * editing/ApplyStyleCommand.cpp:
- (WebCore::styleSpanClassString): Ditto
- * editing/HTMLInterchange.cpp:
- (WebCore::): Ditto
- * editing/IndentOutdentCommand.cpp:
- (WebCore::indentBlockquoteString): Ditto
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::isInterchangeNewlineNode): Ditto
- (WebCore::isInterchangeConvertedSpaceSpan): Ditto
- * editing/htmlediting.cpp:
- (WebCore::stringWithRebalancedWhitespace): Ditto
- (WebCore::nonBreakingSpaceString): Ditto
- * editing/markup.cpp:
- (WebCore::appendAttributeValue): Ditto
- (WebCore::appendEscapedContent): Ditto
- (WebCore::shouldAddNamespaceAttr): Ditto
- (WebCore::appendNamespace): Ditto
- (WebCore::appendStartMarkup): Ditto
- (WebCore::createMarkup): Ditto
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::type): Ditto
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::isRecognizedTagName): Ditto
- (WebCore::inlineTagList): Ditto
- (WebCore::blockTagList): Ditto
- * html/HTMLFieldSetElement.cpp:
- (WebCore::HTMLFieldSetElement::type): Ditto
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::type): Ditto
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::type): Ditto
- * html/HTMLLegendElement.cpp:
- (WebCore::HTMLLegendElement::type): Ditto
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::type): Ditto
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::type): Ditto
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::getNode): Ditto
- (WebCore::HTMLParser::isHeaderTag): Ditto
- (WebCore::HTMLParser::isResidualStyleTag): Ditto
- (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::type): Ditto
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::type): Ditto
- * inspector/InspectorController.cpp:
- (WebCore::platform): Ditto
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::shared): Ditto
- * inspector/JavaScriptProfile.cpp:
- (WebCore::profileCache): Ditto
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::profileNodeCache): Ditto
- * loader/FrameLoader.cpp:
- (WebCore::localSchemes): Ditto
- * loader/appcache/ApplicationCacheStorage.cpp:
- (WebCore::cacheStorage): Ditto
- * loader/archive/ArchiveFactory.cpp:
- (WebCore::archiveMIMETypes): Ditto
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dragState): Ditto
- * page/Frame.cpp:
- (WebCore::createRegExpForLabels): Ditto
- (WebCore::keepAliveSet): Ditto
- * page/Page.cpp:
- (WebCore::Page::groupName): Ditto
- * page/SecurityOrigin.cpp:
- (WebCore::isDefaultPortForProtocol): Ditto
- (WebCore::SecurityOrigin::databaseIdentifier): Ditto
- * page/mac/FrameMac.mm:
- (WebCore::regExpForLabels): Ditto
- * platform/KURL.cpp:
- (WebCore::blankURL): Ditto
- * platform/graphics/FontCache.cpp:
- (WebCore::alternateFamilyName): Ditto
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::FontCache::getSimilarFontPlatformData): Ditto
- (WebCore::FontCache::getLastResortFallbackFont): Ditto
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarTheme::nativeTheme): Ditto
- * platform/mac/ThemeMac.mm:
- (WebCore::platformTheme): Ditto
- * platform/mac/ThreadCheck.mm:
- (WebCoreReportThreadViolation): Ditto
- * platform/network/NetworkStateNotifier.cpp:
- (WebCore::networkStateNotifier): Ditto
- * platform/network/mac/FormDataStreamMac.mm:
- (WebCore::getStreamFormDataMap): Ditto
- (WebCore::getStreamResourceHandleMap): Ditto
- * platform/network/mac/ResourceResponseMac.mm:
- (WebCore::ResourceResponse::platformLazyInit): Ditto
- * platform/text/TextEncoding.cpp:
- (WebCore::TextEncoding::isJapanese): Ditto
- * rendering/RenderBlock.cpp:
- (WebCore::continuationOutlineTable): Ditto
- * rendering/RenderCounter.cpp:
- (WebCore::counterMaps): Ditto
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::markerText): Ditto
- * rendering/RenderScrollbarTheme.cpp:
- (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::systemFont): Ditto
- * rendering/bidi.cpp:
- (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::initialDashboardRegions): Ditto
- (WebCore::RenderStyle::noneDashboardRegions): Ditto
- * storage/LocalStorage.cpp:
- (WebCore::localStorageMap): Ditto
- * svg/SVGAnimateMotionElement.cpp:
- (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
- * svg/SVGAnimationElement.cpp:
- (WebCore::SVGAnimationElement::calcMode): Ditto
- (WebCore::SVGAnimationElement::attributeType): Ditto
- (WebCore::SVGAnimationElement::isAdditive): Ditto
- (WebCore::SVGAnimationElement::isAccumulated): Ditto
- * svg/SVGLangSpace.cpp:
- (WebCore::SVGLangSpace::xmlspace): Ditto
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::contentScriptType): Ditto
- (WebCore::SVGSVGElement::contentStyleType): Ditto
- * svg/SVGStyleElement.cpp:
- (WebCore::SVGStyleElement::type): Ditto
- (WebCore::SVGStyleElement::media): Ditto
- * svg/SVGTextContentElement.cpp:
- (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
- * svg/animation/SVGSMILElement.cpp:
- (WebCore::SVGSMILElement::parseClockValue): Ditto
- (WebCore::SVGSMILElement::restart): Ditto
- (WebCore::SVGSMILElement::fill): Ditto
- (WebCore::SVGSMILElement::repeatCount): Ditto
- (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
- * svg/graphics/SVGResource.cpp:
- (WebCore::clientMap): Ditto
- * svg/graphics/SVGResourceMarker.cpp:
- (WebCore::SVGResourceMarker::draw): Ditto
- * xml/XMLHttpRequest.cpp:
- (WebCore::preflightResultCache): Ditto
- (WebCore::isSafeRequestHeader): Ditto
- (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
- * xml/XPathExpressionNode.cpp:
- (WebCore::XPath::Expression::evaluationContext): Ditto
- * xml/XPathParser.cpp:
- (WebCore::XPath::isAxisName): Ditto
- (WebCore::XPath::isNodeTypeName): Ditto
- * xml/XPathValue.cpp:
- (WebCore::XPath::Value::toNodeSet): Ditto
-
-2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Rubber-stamped by Simon Hausmann.
-
- Remove a bunch of unused methods in the Qt media element implementation
+ The #include <phonon> header no longer exists. And the <Phonon> or
+ <Phonon/Phonon> headers have never existed (neither for us nor for the
+ Phonon sources). You have to select each and every header that you do
+ want now.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
-
-2008-11-05 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=21870
-
- Implement absoluteToLocal() to convert a point from absolute
- to local coordinates, optionally taking transforms into account.
-
- Use this to set offsetX/offsetY in mouse events, thus fixing
- offsetX/offsetY in events on elements with transforms.
-
- Test: fast/events/offsetX-offsetY.html
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::absoluteToLocal):
- (WebCore::RenderBox::offsetFromContainer):
- * rendering/RenderBox.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteToLocal):
- * rendering/RenderObject.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::localToAbsolute):
- (WebCore::RenderTableCell::absoluteToLocal):
- * rendering/RenderTableCell.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::absoluteToLocal):
- * rendering/RenderView.h:
-
-2008-11-06 Alp Toker <alp@nuanti.com>
-
- Reviewed by Cameron Zwarich.
-
- https://bugs.webkit.org/show_bug.cgi?id=22067
- [GTK] Sun Java plugin segfaults at PluginPackage::createPackage()
-
- null-check symbols loaded from plugin modules, initialize the function
- table (like Win already does) and update it with the latest
- additions. Adjust whitespace for easy diff'ing with the Win port code
- from which it was forked.
-
- This fixes crashes with libnspr4.so and any other plugins that don't
- provide the symbols we expect.
-
- * plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::fetchInfo):
- (WebCore::PluginPackage::load):
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Removed dead (and broken) code from an ancient Symbian port.
-
- * config.h:
- * platform/text/AtomicString.h:
- * platform/text/PlatformString.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Use QLibrary as PlatformModule when compiling with Qt for S60.
-
- * platform/FileSystem.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Compile fix for Symbian.
- The snprintf function is defined in stdio.h, the inclusion
- of snprintf.h inside this PLATFORM(SYMBIAN) block does not
- compile.
-
- * config.h:
-
-2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Disable webkit plugins for Symbian.
- * WebCore.pro:
-
-2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Fix build break in debug mode when XSLT is not enabled
-
- * loader/Cache.cpp:
- (WebCore::Cache::dumpStats):
-
-2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
- Repaint video on UpdateRequest to prevent recursive painting
-
- Calling QWidget::render() to update the video generates a paint
- event that's then picked up by the event filter once more :(
-
- We're really only interested in updates from Phonon, which we
- get through the UpdateRequest for each new frame.
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::eventFilter):
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the WebCore build for some platforms by changing build scripts to
- account for the recent move of the create_hash_table script from the kjs
- subdirectory of JavaScriptCore to the root directory.
-
- * WebCore.pro:
- * make-generated-sources.sh:
-
-2008-11-06 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix a case-sensitivity issue in Mac forwarding headers. Strangely
- enough, this does not always cause the build to break, even with a
- case-sensitive filesystem.
-
- * ForwardingHeaders/runtime/Interpreter.h:
-
-2008-11-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=22083
- MessageEvents cannot be used across threads
-
- * dom/Event.idl:
- * dom/MessageEvent.idl:
- Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables
- won't work.
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::EventData::EventData):
- (WebCore::MessagePort::EventData::~EventData):
- (WebCore::MessagePort::clone):
- (WebCore::MessagePort::postMessage):
- (WebCore::MessagePort::startConversation):
- (WebCore::MessagePort::dispatchMessages):
- * dom/MessagePort.h:
- Don't create a MessageEvent until dispatch time - messages can be posted across threads,
- but MessageEvents are tied to the thread that they were created in.
-
-2008-11-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22066
- Implement Worker global object
-
- * DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.
-
- * WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker
- support is still disabled by default.
-
- * bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.
-
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.
-
- * bindings/js/JSWorkerContext.cpp: Added.
- * bindings/js/JSWorkerContext.h: Added.
- * bindings/js/WorkerScriptController.cpp: Added.
- * bindings/js/WorkerScriptController.h: Added.
- * dom/WorkerContext.cpp: Added.
- * dom/WorkerContext.h: Added.
- Added an implementation of worker contexts.
-
- * dom/DedicatedWorker.cpp:
- (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests.
- (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership
- and lifetime is not clear at all.
-
- * dom/WorkerLocation.cpp: Added.
- * dom/WorkerLocation.h: Added.
- * dom/WorkerLocation.idl: Added.
- Added WorkerLocation, which is one of the objects available to workers.
-
- * dom/WorkerThread.cpp: Added.
- (WebCore::WorkerThread::WorkerThread):
- (WebCore::WorkerThread::start):
- (WebCore::WorkerThread::workerThreadStart):
- (WebCore::WorkerThread::workerThread):
- * dom/WorkerThread.h: Added.
- (WebCore::WorkerThread::create):
- Run some code in a worker thread (no message loop yet).
-
-2008-11-05 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=22093
- Don't keep decoded stylesheet data in cache
-
- <rdar://problem/6343588>
-
- Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
- performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
- style sheet data in cache by 2/3 in common case.
-
- * loader/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::sheetText):
- (WebCore::CachedCSSStyleSheet::data):
- * loader/CachedCSSStyleSheet.h:
-
-2008-11-05 David Kilzer <ddkilzer@apple.com>
-
- Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers
-
- <https://bugs.webkit.org/show_bug.cgi?id=21596>
-
- Reviewed by Antti.
-
- This patch adds real parsing for Pragma and Cache-Control headers
- based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
- new String and StringImpl methods to assist with the parsing.
-
- * loader/Cache.cpp:
- (WebCore::Cache::dumpStats): Added. Convenience method for dumping
- stats outside of Safari.
- * loader/Cache.h: Declared dumpStats().
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::mustRevalidate): Updated to use
- ResourceResponseBase::cacheControlDirectives() instead of substring
- matching of the entire Cache-Control header.
-
- * loader/loader.cpp:
- (WebCore::Loader::Host::didReceiveResponse): Used the local
- 'resource' variable instead of 'request->cachedResource()'.
-
- * platform/network/ResourceResponseBase.cpp:
- (WebCore::ResourceResponseBase::setHTTPHeaderField): Set
- m_haveParsedCacheControlHeader to false when a "Cache-Control"
- header is set. Ditto for m_haveParsedPragmaHeader and "Pragma".
- (WebCore::ResourceResponseBase::parsePragmaDirectives): Added.
- Provides parsed Pragma header directives.
- (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added.
- Provides parsed Cache-Control header directives.
- (WebCore::isCacheHeaderSeparator): Added. Returns true if a
- character is a separator character per RFC 2616, Section 2.2, else
- returns false.
- (WebCore::isControlCharacter): Added. Returns true if a character
- is a control character per RFC 2616 Section 2.2, else returns false.
- (WebCore::trimToNextSeparator): Added. Returns a string truncated
- at the first separator character per isCacheHeaderSeparator().
- (WebCore::parseCacheHeader): Added. This is the main parsing
- routine for both Cache-Control and Pragma headers.
- (WebCore::parseCacheControlDirectiveValues): Added. This splits
- certain Cache-Control directive values into a vector of strings.
- * platform/network/ResourceResponseBase.h:
- (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed
- Cache-Control header.
- (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma
- header.
- (WebCore::ResourceResponseBase::parsePragmaDirectives): Added
- declaration.
- (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto.
- (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader):
- Added. Boolean to describe when the "Cache-Control" header needs to
- be reparsed.
- (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added.
- Boolean to describe when the "Pragma" header needs to be reparsed.
- (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added.
- Cached map to hold parsed "Cache-Control" headers.
- (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added.
- Cached map to hold parsed "Pragma" headers.
-
- * platform/text/PlatformString.h:
- (WebCore::String::find): Added. Returns the first match based on
- the character-matching function pointer passed in.
- (WebCore::String::removeCharacters): Added declaration.
- (WebCore::find): Added. Inline method that takes a character-
- matching function pointer. Called by StringImpl::find().
- * platform/text/String.cpp:
- (WebCore::String::removeCharacters): Added. Calls
- StringImpl::removeCharacters().
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::removeCharacters): Added. Returns a string
- with all characters removed that match the character-matching
- function pointer passed in. If there is no change to the string, it
- returns itself. Based heavily on StringImpl::simplifyWhitespace().
- (WebCore::StringImpl::find): Added. Calls WebCore::find().
- * platform/text/StringImpl.h:
- (WebCore::FindMatchFunctionPtr): Added. Typedef for a character-
- matching function pointer.
- (WebCore::StringImpl::removeCharacters): Added declaration.
- (WebCore::StringImpl::find): Ditto.
-
-2008-11-05 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break
-
- As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
- between two blockquotes. Because the start merge moves the text node into a blockquote, when we
- determine whether or not we should do the end merge, it incorrectly appears as though the end merge
- is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
- before we do the start merge, so that the start merge doesn't effect our decision.
-
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean.
- (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity.
- (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
- * editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.
+ Remove duplicated code in Qt & GTK logging initialization
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
+ We now share the getChannelFromName() function in Logging.cpp
- Not reviewed.
-
- Speculatively fix the Windows build, even though these changes may not
- actually matter for anything in the build, because the Windows bots are
- behind.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the Qt build.
-
- * bridge/qt/qt_class.cpp:
- * bridge/qt/qt_runtime.h:
-
-2008-11-05 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move more files to the runtime subdirectory of JavaScriptCore.
-
- * ForwardingHeaders/kjs/collector.h: Removed.
- * ForwardingHeaders/kjs/completion.h: Removed.
- * ForwardingHeaders/kjs/identifier.h: Removed.
- * ForwardingHeaders/kjs/interpreter.h: Removed.
- * ForwardingHeaders/kjs/lookup.h: Removed.
- * ForwardingHeaders/kjs/operations.h: Removed.
- * ForwardingHeaders/kjs/protect.h: Removed.
- * ForwardingHeaders/kjs/ustring.h: Removed.
- * ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
- * ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
- * ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
- * ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
- * ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
- * ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
- * ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
- * ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
- * bindings/js/GCController.cpp:
- * bindings/js/JSCustomPositionCallback.h:
- * bindings/js/JSCustomPositionErrorCallback.h:
- * bindings/js/JSCustomSQLStatementCallback.h:
- * bindings/js/JSCustomSQLStatementErrorCallback.h:
- * bindings/js/JSCustomSQLTransactionErrorCallback.h:
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSEventListener.h:
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptController.h:
- * bindings/objc/WebScriptObject.mm:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- * bridge/c/c_class.cpp:
- * bridge/jni/jni_class.cpp:
- * bridge/jni/jni_jsobject.mm:
- * bridge/npruntime.cpp:
- * bridge/runtime_root.h:
- * history/CachedPage.h:
- * html/CanvasRenderingContext2D.cpp:
- * html/HTMLCanvasElement.cpp:
- * inspector/InspectorController.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * page/Console.cpp:
- * page/Page.cpp:
- * platform/text/AtomicString.cpp:
- * platform/text/PlatformString.h:
-
-2008-11-05 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=22085
- The Plugin JS object should expose item() and namedItem() methods to match Firefox
-
- * bindings/js/JSPluginCustom.cpp:
- (WebCore::JSPlugin::nameGetter):
- * plugins/Plugin.cpp:
- (WebCore::Plugin::namedItem):
- * plugins/Plugin.h:
- * plugins/Plugin.idl:
-
-2008-11-05 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=21060
- Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR
-
- Test: fast/dom/Range/surroundContents-check-boundary-points.html
-
- * dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.
-
-2008-11-05 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Remove two global destructors from CoreTextController.
-
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
-
-2008-11-05 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- CRASH at Scrollbar::invalidateRect due to null m_client
- https://bugs.webkit.org/show_bug.cgi?id=22080
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::isWindowActive):
- (WebCore::Scrollbar::invalidateRect):
+ * platform/gtk/LoggingGtk.cpp:
+ * platform/qt/LoggingQt.cpp:
-2008-11-04 Sam Weinig <sam@webkit.org>
+2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
- Fix https://bugs.webkit.org/show_bug.cgi?id=21648
- navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS
-
- - Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.
-
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- (WebCore::JSMimeTypeArray::nameGetter):
- * bindings/js/JSPluginArrayCustom.cpp:
- (WebCore::JSPluginArray::nameGetter):
- * page/DOMWindow.idl:
- * plugins/MimeType.idl:
- * plugins/MimeTypeArray.cpp:
- (WebCore::MimeTypeArray::namedItem):
- * plugins/MimeTypeArray.h:
- * plugins/MimeTypeArray.idl:
- * plugins/Plugin.idl:
- * plugins/PluginArray.cpp:
- (WebCore::PluginArray::namedItem):
- * plugins/PluginArray.h:
- * plugins/PluginArray.idl:
-
-2008-11-05 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
-
- * plugins/PluginPackage.cpp:
-
-2008-11-05 Jeff Cook <cookiecaper@gmail.com>
-
- Reviewed by Simon Hausmann and Tor Arne.
-
- Fix crash in the Qt port when unloading swfdec and Flash 10
- by reordering window destruction and plugin stop.
-
- See https://bugs.webkit.org/show_bug.cgi?id=20779
+ Rename the plugin logging channel to plural form 'Plugins'
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::stop):
+ This matches both the other logging channel names, as well as the
+ WebKit logging channel used by Safari/Mac for plugins.
-2008-11-05 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Tor Arne Vestbø
-
- Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.
-
- Otherwise Flash refuses to load and function :(
-
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::determineQuirks):
- * plugins/PluginQuirkSet.h:
- (WebCore::):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::getValue):
-
-2008-11-05 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Tor Arne Vestbø
-
- Unify determineQuirks between the Qt and the Gtk PluginPackage.
- Share the code for parsing the module version from the description.
- This is currently used to determine Flash based quirks.
-
- * plugins/PluginPackage.cpp:
- (WebCore::PluginPackage::createPackage):
- (WebCore::PluginPackage::determineQuirks):
- (WebCore::PluginPackage::determineModuleVersionFromDescription):
- * plugins/PluginPackage.h:
+ * platform/Logging.cpp:
+ * platform/Logging.h:
+ * platform/gtk/LoggingGtk.cpp:
+ * platform/mac/LoggingMac.mm:
+ * platform/qt/LoggingQt.cpp:
+ * platform/win/LoggingWin.cpp:
+ * plugins/PluginDebug.h:
* plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::fetchInfo):
+ * plugins/mac/PluginPackageMac.cpp:
+ * plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::fetchInfo):
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore.
-
- * ForwardingHeaders/kjs/dtoa.h: Removed.
- * ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
- * css/CSSParser.cpp:
- * platform/text/String.cpp:
- * platform/text/StringImpl.cpp:
-
-2008-11-04 Jonathan Haas <myrdred@gmail.com>
-
- Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>
-
- Reviewed by Darin Adler.
-
- Fixed an issue which could cause memory corruption using ToT libxml.
- See https://bugs.webkit.org/show_bug.cgi?id=15715
-
- Test: fast/xsl/xslt-nested-stylesheets.xml
-
- * xml/XSLImportRule.cpp:
- (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
- * xml/XSLStyleSheet.cpp:
- (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet
- (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary
- (WebCore::XSLStyleSheet::setParentStyleSheet): Added
- * xml/XSLStyleSheet.h: Added m_parentStyleSheet member
-
-2008-11-04 Simon Fraser <simon.fraser@apple.com>
-
- No review.
-
- Improved buid fix: include MathExtras.h to get roundf on all platforms.
-
- * platform/graphics/FloatPoint.h:
-
-2008-11-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by John Sullivan
-
- Add a simple "visited" method to HistoryItem for use by global history
-
- * WebCore.base.exp:
-
- * history/HistoryItem.cpp:
- (WebCore::HistoryItem::visited): Update the title on the item, set last visited time,
- and bump the visit count. All things that should happen when a url is visited again!
- * history/HistoryItem.h:
-
-2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>
- Build fix. Not reviewed.
-
- * platform/graphics/FloatPoint.h: include math.h.
- reported by zdobersek in #webkit.
-
-2008-11-04 Darin Fisher <darin@chromium.org>
-
- Reviewed by Anders Carlsson.
-
- No need to clobber all ResourceRequest fields in FrameLoader::reload()
- https://bugs.webkit.org/show_bug.cgi?id=21949
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::reload):
-
-2008-11-04 Darin Adler <darin@apple.com>
-
- Reviewed by Tim Hatcher.
-
- * storage/Database.cpp:
- (WebCore::databaseVersionKey): Tweaked formatting.
-
-2008-11-03 Darin Adler <darin@apple.com>
-
- Reviewed by Tim Hatcher.
-
- - https://bugs.webkit.org/show_bug.cgi?id=22061
- create script to check for exit-time destructors
-
- * WebCore.xcodeproj/project.pbxproj: Added a script
- phase that runs the check-for-exit-time-destructors script.
-
- * html/HTMLAttributeNames.in: Removed some unused attribute names.
-
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that
- sets the write-only m_pluginPage.
- * html/HTMLEmbedElement.h: Ditto.
-
- * platform/mac/CursorMac.mm:
- (WebCore::leakNamedCursor): Changed to return a Cursor&.
- (WebCore::pointerCursor): Changed to leak an object to avoid an
- exit-time destructor.
- (WebCore::crossCursor): Ditto.
- (WebCore::handCursor): Ditto.
- (WebCore::moveCursor): Ditto.
- (WebCore::verticalTextCursor): Ditto.
- (WebCore::cellCursor): Ditto.
- (WebCore::contextMenuCursor): Ditto.
- (WebCore::aliasCursor): Ditto.
- (WebCore::zoomInCursor): Ditto.
- (WebCore::zoomOutCursor): Ditto.
- (WebCore::copyCursor): Ditto.
- (WebCore::noneCursor): Ditto.
- (WebCore::progressCursor): Ditto.
- (WebCore::noDropCursor): Ditto.
- (WebCore::notAllowedCursor): Ditto.
- (WebCore::iBeamCursor): Ditto.
- (WebCore::waitCursor): Ditto.
- (WebCore::helpCursor): Ditto.
- (WebCore::eastResizeCursor): Ditto.
- (WebCore::northResizeCursor): Ditto.
- (WebCore::northEastResizeCursor): Ditto.
- (WebCore::northWestResizeCursor): Ditto.
- (WebCore::southResizeCursor): Ditto.
- (WebCore::southEastResizeCursor): Ditto.
- (WebCore::southWestResizeCursor): Ditto.
- (WebCore::westResizeCursor): Ditto.
- (WebCore::northSouthResizeCursor): Ditto.
- (WebCore::eastWestResizeCursor): Ditto.
- (WebCore::northEastSouthWestResizeCursor): Ditto.
- (WebCore::northWestSouthEastResizeCursor): Ditto.
- (WebCore::columnResizeCursor): Ditto.
- (WebCore::rowResizeCursor): Ditto.
- (WebCore::grabCursor): Ditto.
- (WebCore::grabbingCursor): Ditto.
-
- * storage/Database.cpp:
- (WebCore::guidMutex): Changed to leak an object to avoid an
- exit-time destructor. Also added a comment explaining why it's
- thread safe.
- (WebCore::guidToVersionMap): Ditto.
- (WebCore::guidToDatabaseMap): Ditto.
- (WebCore::Database::databaseInfoTableName): Ditto.
- (WebCore::databaseVersionKey): Ditto.
- (WebCore::Database::getVersionFromDatabase): Ditto.
- (WebCore::Database::setVersionInDatabase): Ditto.
- (WebCore::guidForOriginAndName): Ditto.
- * storage/DatabaseTracker.cpp:
- (WebCore::DatabaseTracker::tracker): Ditto.
- (WebCore::notificationMutex): Ditto.
- (WebCore::notificationQueue): Ditto.
- (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.
-
-2008-11-04 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- https://bugs.webkit.org/show_bug.cgi?id=21941
-
- Rename absolutePosition() to localToAbsolute(), and add the ability
- to optionally take transforms into account (which will eventually be the
- default behavior).
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::getUpperLeftCorner):
- (WebCore::ContainerNode::getLowerRightCorner):
- (WebCore::ContainerNode::getRect):
- * dom/ContainerNode.h:
- * dom/MouseRelatedEvent.cpp:
- (WebCore::MouseRelatedEvent::receivedTarget):
- * dom/Node.cpp:
- (WebCore::Node::getRect):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::layout):
- (WebCore::SelectionController::caretRect):
- * editing/visible_units.cpp:
- (WebCore::previousLinePosition):
- (WebCore::nextLinePosition):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- (WebCore::HTMLAnchorElement::defaultEventHandler):
- * html/HTMLAreaElement.cpp:
- (WebCore::HTMLAreaElement::getRect):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::x):
- (WebCore::HTMLImageElement::y):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::defaultEventHandler):
- * html/HTMLInputElement.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::boundingBoxRect):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleDrag):
- * platform/graphics/FloatPoint.h:
- (WebCore::roundedIntPoint):
- * platform/graphics/IntSize.h:
- (WebCore::IntSize::expand):
- * rendering/LayoutState.cpp:
- (WebCore::LayoutState::LayoutState):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock):
- (WebCore::RenderBlock::paintObject):
- (WebCore::RenderBlock::selectionGapRects):
- (WebCore::RenderBlock::fillBlockSelectionGaps):
- (WebCore::RenderBlock::nodeAtPoint):
- (WebCore::RenderBlock::positionForCoordinates):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::localToAbsolute):
- (WebCore::RenderBox::computeAbsoluteRepaintRect):
- (WebCore::RenderBox::caretRect):
- * rendering/RenderBox.h:
- (WebCore::RenderBox::relativePositionOffset):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addLineBoxRects):
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::absoluteClippedOverflowRect):
- (WebCore::RenderFlow::caretRect):
- (WebCore::RenderFlow::addFocusRingRects):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPosition):
- (WebCore::RenderLayer::convertToLayerCoords):
- (WebCore::RenderLayer::addScrolledContentOffset):
- (WebCore::RenderLayer::subtractScrolledContentOffset):
- (WebCore::RenderLayer::scrollRectToVisible):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::scrolledContentOffset):
- (WebCore::RenderLayer::relativePositionOffset):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::panScroll):
- (WebCore::RenderListBox::scrollToward):
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::selectionRect):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::absoluteBoundingBoxRect):
- (WebCore::RenderObject::computeAbsoluteRepaintRect):
- (WebCore::RenderObject::localToAbsolute):
- (WebCore::RenderObject::addDashboardRegions):
- (WebCore::RenderObject::absoluteContentBox):
- (WebCore::RenderObject::absoluteOutlineBox):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::localToAbsoluteForContent):
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::updateWidgetPosition):
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::selectionRect):
- * rendering/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
- * rendering/RenderSVGText.cpp:
- (WebCore::RenderSVGText::absoluteRects):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::localToAbsolute):
- * rendering/RenderTableCell.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::addLineBoxRects):
- (WebCore::RenderText::caretRect):
- (WebCore::RenderText::selectionRect):
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::updatePlayer):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::localToAbsolute):
- * rendering/RenderView.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::updateWidgetPosition):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::getScreenCTM):
-
-2008-11-03 Yael Aharon <yael.aharon@nokia.com>
+2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
- Add methods for getting and setting user data on History Item.
- This change is limited to QT port only. Tests were added in
- the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.
-
- Minor change by Simon: made the functions inline and added a missing
- const.
-
- * history/HistoryItem.h:
-
-2008-11-01 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22030
- Make EventNames usable from multiple threads
-
- * platform/text/AtomicString.cpp:
- (WebCore::stringTable):
- (WebCore::AtomicString::add):
- (WebCore::AtomicString::remove):
- (WebCore::AtomicString::find):
- (WebCore::AtomicString::init):
- * platform/text/AtomicString.h:
- Atomic string table is now per-thread. Individual strings cannot be shared between threads,
- so global AtomicString constants cannot be used from threads other than the main one.
-
- * dom/EventNames.cpp:
- (WebCore::EventNames::EventNames):
- (WebCore::eventNames):
- (WebCore::EventNames::init):
- * dom/EventNames.h:
- Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
- eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
- threads.
-
- * WebCore.base.exp:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::processingUserGesture):
- * dom/BeforeTextInsertedEvent.cpp:
- (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent):
- * dom/BeforeUnloadEvent.cpp:
- (WebCore::BeforeUnloadEvent::BeforeUnloadEvent):
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::dispatchModifiedEvent):
- * dom/ContainerNode.cpp:
- (WebCore::dispatchChildInsertionEvents):
- (WebCore::dispatchChildRemovalEvents):
- * dom/DedicatedWorker.cpp:
- (WebCore::DedicatedWorker::dispatchErrorEvent):
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
- (WebCore::Document::setFocusedNode):
- (WebCore::Document::addListenerTypeIfNeeded):
- (WebCore::Document::removeWindowInlineEventListenerForType):
- (WebCore::Document::addWindowEventListener):
- (WebCore::Document::removeWindowEventListener):
- (WebCore::Document::finishedParsing):
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchGenericEvent):
- (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
- (WebCore::EventTargetNode::dispatchWindowEvent):
- (WebCore::EventTargetNode::dispatchUIEvent):
- (WebCore::EventTargetNode::dispatchSimulatedClick):
- (WebCore::EventTargetNode::dispatchMouseEvent):
- (WebCore::EventTargetNode::dispatchFocusEvent):
- (WebCore::EventTargetNode::dispatchBlurEvent):
- (WebCore::EventTargetNode::defaultEventHandler):
- (WebCore::EventTargetNode::on*): (multiple methods)
- (WebCore::EventTargetNode::setOn*): (multiple methods)
- * dom/KeyboardEvent.cpp:
- (WebCore::eventTypeForKeyboardEventType):
- (WebCore::KeyboardEvent::keyCode):
- (WebCore::KeyboardEvent::charCode):
- * dom/MessageEvent.cpp:
- (WebCore::MessageEvent::MessageEvent):
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::dispatchMessages):
- (WebCore::MessagePort::dispatchCloseEvent):
- * dom/MouseEvent.cpp:
- (WebCore::MouseEvent::isDragEvent):
- (WebCore::MouseEvent::toElement):
- (WebCore::MouseEvent::fromElement):
- * dom/OverflowEvent.cpp:
- (WebCore::OverflowEvent::OverflowEvent):
- * dom/TextEvent.cpp:
- (WebCore::TextEvent::TextEvent):
- * dom/WebKitAnimationEvent.cpp:
- (WebCore::WebKitAnimationEvent::WebKitAnimationEvent):
- (WebCore::WebKitAnimationEvent::~WebKitAnimationEvent):
- (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent):
- (WebCore::WebKitAnimationEvent::animationName):
- (WebCore::WebKitAnimationEvent::elapsedTime):
- * dom/WebKitTransitionEvent.cpp:
- (WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
- (WebCore::WebKitTransitionEvent::~WebKitTransitionEvent):
- (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):
- (WebCore::WebKitTransitionEvent::propertyName):
- (WebCore::WebKitTransitionEvent::elapsedTime):
- * dom/WheelEvent.cpp:
- (WebCore::WheelEvent::WheelEvent):
- (WebCore::WheelEvent::initWheelEvent):
- * dom/XMLTokenizerLibxml2.cpp:
- * dom/XMLTokenizerQt.cpp:
- * editing/DeleteButton.cpp:
- (WebCore::DeleteButton::defaultEventHandler):
- * editing/EditCommand.cpp:
- * editing/Editor.cpp:
- (WebCore::Editor::canDHTMLCut):
- (WebCore::Editor::canDHTMLCopy):
- (WebCore::Editor::canDHTMLPaste):
- (WebCore::Editor::tryDHTMLCopy):
- (WebCore::Editor::tryDHTMLCut):
- (WebCore::Editor::tryDHTMLPaste):
- (WebCore::dispatchEditableContentChangedEvents):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::setFocused):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::defaultEventHandler):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::parseMappedAttribute):
- (WebCore::HTMLButtonElement::defaultEventHandler):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::parseMappedAttribute):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::onChange):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::handleLocalEvents):
- (WebCore::HTMLFormElement::prepareSubmit):
- (WebCore::HTMLFormElement::reset):
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::setValueFromRenderer):
- (WebCore::HTMLInputElement::preDispatchEventHandler):
- (WebCore::HTMLInputElement::postDispatchEventHandler):
- (WebCore::HTMLInputElement::defaultEventHandler):
- (WebCore::HTMLInputElement::onSearch):
- * html/HTMLLabelElement.cpp:
- (WebCore::HTMLLabelElement::defaultEventHandler):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::load):
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
- (WebCore::HTMLMediaElement::setReadyState):
- (WebCore::HTMLMediaElement::progressEventTimerFired):
- (WebCore::HTMLMediaElement::seek):
- (WebCore::HTMLMediaElement::setDefaultPlaybackRate):
- (WebCore::HTMLMediaElement::setPlaybackRate):
- (WebCore::HTMLMediaElement::play):
- (WebCore::HTMLMediaElement::pause):
- (WebCore::HTMLMediaElement::setVolume):
- (WebCore::HTMLMediaElement::setMuted):
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
- (WebCore::HTMLMediaElement::documentWillBecomeInactive):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLOptionElement.cpp:
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- (WebCore::HTMLScriptElement::dispatchErrorEvent):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- (WebCore::HTMLSelectElement::defaultEventHandler):
- (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
- (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- (WebCore::HTMLTextAreaElement::defaultEventHandler):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::canCachePage):
- * loader/ImageDocument.cpp:
- (WebCore::ImageEventListener::handleEvent):
- * loader/ImageLoader.cpp:
- * loader/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::callCheckingListener):
- (WebCore::DOMApplicationCache::callErrorListener):
- (WebCore::DOMApplicationCache::callNoUpdateListener):
- (WebCore::DOMApplicationCache::callDownloadingListener):
- (WebCore::DOMApplicationCache::callProgressListener):
- (WebCore::DOMApplicationCache::callUpdateReadyListener):
- (WebCore::DOMApplicationCache::callCachedListener):
- * page/AccessibilityObject.cpp:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/ContextMenuController.cpp:
- (WebCore::ContextMenuController::handleContextMenuEvent):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::on*): (multiple methods)
- (WebCore::DOMWindow::setOn*): (multiple methods)
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- (WebCore::EventHandler::updateDragAndDrop):
- (WebCore::EventHandler::cancelDragAndDrop):
- (WebCore::EventHandler::performDragAndDrop):
- (WebCore::EventHandler::updateMouseEventTargetNode):
- (WebCore::EventHandler::dispatchMouseEvent):
- (WebCore::EventHandler::sendContextMenuEvent):
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- (WebCore::EventHandler::defaultKeyboardEventHandler):
- (WebCore::EventHandler::dragSourceMovedTo):
- (WebCore::EventHandler::dragSourceEndedAt):
- (WebCore::EventHandler::handleDrag):
- (WebCore::EventHandler::handleTextInputEvent):
- * page/FocusController.cpp:
- * page/Frame.cpp:
- (WebCore::Frame::sendResizeEvent):
- (WebCore::Frame::sendScrollEvent):
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- (WebCore::AnimationBase::animationTimerCallbackFired):
- (WebCore::AnimationBase::primeEventTimers):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::onAnimationEnd):
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::onAnimationStart):
- (WebCore::KeyframeAnimation::onAnimationIteration):
- (WebCore::KeyframeAnimation::onAnimationEnd):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- * page/gtk/EventHandlerGtk.cpp:
- * page/mac/EventHandlerMac.mm:
- (WebCore::isKeyboardOptionTab):
- * page/mac/FrameMac.mm:
- * page/qt/EventHandlerQt.cpp:
- (WebCore::isKeyboardOptionTab):
- * plugins/PluginView.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- * plugins/qt/PluginViewQt.cpp:
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlMuteButtonElement::defaultEventHandler):
- (WebCore::MediaControlPlayButtonElement::defaultEventHandler):
- (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
- (WebCore::MediaControlTimelineElement::defaultEventHandler):
- (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::userResize):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollToOffset):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::valueChanged):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::forwardEvent):
- * rendering/RenderObject.cpp:
- * rendering/RenderSlider.cpp:
- (WebCore::HTMLSliderThumbElement::defaultEventHandler):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::forwardEvent):
- (WebCore::RenderTextControl::selectionChanged):
- * rendering/RenderWidget.cpp:
- * rendering/TextControlInnerElements.cpp:
- (WebCore::TextControlInnerTextElement::defaultEventHandler):
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- * storage/LocalStorageArea.cpp:
- (WebCore::LocalStorageArea::dispatchStorageEvent):
- * storage/SessionStorageArea.cpp:
- (WebCore::SessionStorageArea::dispatchStorageEvent):
- * svg/SVGAElement.cpp:
- (WebCore::SVGAElement::defaultEventHandler):
- * svg/SVGDocument.cpp:
- (WebCore::SVGDocument::dispatchZoomEvent):
- (WebCore::SVGDocument::dispatchScrollEvent):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::parseMappedAttribute):
- (WebCore::hasLoadListener):
- (WebCore::SVGElement::sendSVGLoadEventIfPossible):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::on*): (multiple methods)
- (WebCore::SVGElementInstance::setOn*): (multiple methods)
- * svg/SVGImageLoader.cpp:
- (WebCore::SVGImageLoader::dispatchLoadEvent):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::dispatchErrorEvent):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
- (WebCore::XMLHttpRequest::dispatchAbortEvent):
- (WebCore::XMLHttpRequest::dispatchErrorEvent):
- (WebCore::XMLHttpRequest::dispatchLoadEvent):
- (WebCore::XMLHttpRequest::dispatchLoadStartEvent):
- (WebCore::XMLHttpRequest::dispatchProgressEvent):
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
- (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
- (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
- (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
- (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- * xml/XPathResult.cpp:
- (WebCore::XPathResult::XPathResult):
- (WebCore::XPathResult::~XPathResult):
- (WebCore::XPathResult::invalidateIteratorState):
- Access event names via eventNames() function.
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Mark Rowe.
-
- Delete unused forwarding headers.
-
- * ForwardingHeaders/kjs/Activation.h: Removed.
- * ForwardingHeaders/kjs/Register.h: Removed.
- * ForwardingHeaders/kjs/RegisterID.h: Removed.
-
-2008-11-04 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix stupid typo in previous build fix.
-
- * bindings/js/JSStorageCustom.cpp:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
-
-2008-11-03 Cameron Zwarich <zwarich@apple.com>
+ Fix NPAPI mouse translation issues on Mac
- Not reviewed.
+ The WindowRef we pass to the plugin refers to the the top level window,
+ so the x and y positions have to be relative to this position, but we
+ have to manually compensate for title bar decorations and other parents
+ of the QWebView since contentsToWindow() only traverses to the QWebView.
- Fix the build for all non-Mac platforms.
+ Previously we did this compensation when passing on mouse coordinates to
+ the plugin, which caused various issues with translations such as not
+ being able to close the Flash settings dialog, or the hand cursor not
+ appearing over links.
- * ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
- * ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
- * bindings/js/JSStorageCustom.cpp:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
+ We now do the compensation as part of the call to NPP_SetWindow, and
+ then pass mouse coordinates in global context without any compensation,
+ similar to how both Safari and Mozilla does it.
-2008-11-03 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the wxWindows build.
-
- * bridge/c/c_instance.cpp:
-
-2008-11-03 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Maciej Stachowiak.
-
- Move more files into the runtime subdirectory of JavaScriptCore.
-
- * ForwardingHeaders/kjs/ArgList.h: Removed.
- * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
- * ForwardingHeaders/kjs/ExecState.h: Removed.
- * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
- * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
- * ForwardingHeaders/kjs/JSLock.h: Removed.
- * ForwardingHeaders/kjs/SymbolTable.h: Removed.
- * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
- * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
- * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
- * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
- * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
- * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
- * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
- * bindings/js/GCController.cpp:
- * bindings/js/JSCustomPositionCallback.cpp:
- * bindings/js/JSCustomPositionErrorCallback.cpp:
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- * bindings/js/JSCustomVoidCallback.cpp:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSEventCustom.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSNodeFilterCondition.cpp:
- * bindings/js/ScheduledAction.cpp:
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptControllerMac.mm:
- * bindings/objc/WebScriptObject.mm:
- * bridge/NP_jsobject.cpp:
- * bridge/c/c_class.cpp:
- * bridge/c/c_instance.cpp:
- * bridge/c/c_runtime.cpp:
- * bridge/c/c_utility.cpp:
- * bridge/jni/jni_class.cpp:
- * bridge/jni/jni_instance.cpp:
- * bridge/jni/jni_jsobject.mm:
- * bridge/jni/jni_objc.mm:
- * bridge/jni/jni_runtime.cpp:
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- * bridge/npruntime.cpp:
- * bridge/objc/objc_instance.mm:
- * bridge/objc/objc_runtime.mm:
- * bridge/objc/objc_utility.mm:
- * bridge/runtime.cpp:
- * dom/Document.cpp:
- * dom/Node.cpp:
- * dom/NodeFilter.cpp:
- * dom/NodeIterator.cpp:
- * dom/TreeWalker.cpp:
- * history/CachedPage.cpp:
- * inspector/InspectorController.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptDebugServer.cpp:
- * inspector/JavaScriptProfileNode.cpp:
- * loader/FrameLoader.cpp:
- * loader/icon/IconDatabase.cpp:
- * page/Console.cpp:
- * page/Page.cpp:
- * page/mac/FrameMac.mm:
- * plugins/PluginView.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- * plugins/qt/PluginViewQt.cpp:
- * plugins/win/PluginViewWin.cpp:
- * storage/Database.cpp:
- * xml/XMLHttpRequest.cpp:
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::globalMousePosForPlugin):
-2008-11-03 Cameron Zwarich <zwarich@apple.com>
+2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
- Reviewed by Sam Weinig.
+ Rubber-stamped by Simon Hausmann.
- Remove the forwarding header for FunctionCallProfile, because it was
- renamed to ProfileNode in r33466.
+ [Qt] Resolve absolute path to library install_name manually
- * ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.
+ Since our target.path is set to the Qt directory (to be able
+ to do 'make install') the 'absolute_library_soname' option
+ to QMake did not do the right thing.
-2008-11-03 Simon Fraser <simon.fraser@apple.com>
+ We now compute the absolute path manually using DESTDIR.
- Reviewed by Dave Hyatt
+ * WebCore.pro:
- https://bugs.webkit.org/show_bug.cgi?id=22026
+2009-06-22 Simon Fraser <simon.fraser@apple.com>
- When computing the bounds of the transparency layer, we need to
- map the clipRect through the enclosing transform.
+ Reviewed by Oliver Hunt.
- Test: fast/layers/opacity-transforms.html
+ <rdar://problem/6991146> Scrollbars in hardware layers don't change to the
+ inactive look in background windows
* rendering/RenderLayer.cpp:
- (WebCore::transparencyClipBox):
-
-2008-11-03 Kevin Decker <kdecker@apple.com>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=22053
-
- Added additional support needed for the NPDrawingModelCoreAnimation drawing model.
-
- * bridge/npapi.h:
-
-2008-11-03 Xan Lopez <xan@gnome.org>
-
- Reviewed by Alp Toker.
-
- Update parseDataUrl() function in the libsoup http backend with
- the one from the curl backend which has recent correctness and crash
- fixes.
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::parseDataUrl):
-
-2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=22041
- Fix CURL crashes on the test suite
-
- Fix segfault with setDefersLoading(). Do not call into curl when we
- don't have a CURL handle.
-
- It is attempted to defer the loading before the load has been
- started (no curl handle was allocated yet). If that happens then
- just remember that. ResourceHandleManager::startJob is already taking
- care of this and in initResourceHandle the the downloading will
- be paused if needed.
-
- Fixes fast/loader/simultaneous-reloads-assert.html
-
- * platform/network/curl/ResourceHandleCurl.cpp:
- (WebCore::ResourceHandle::setDefersLoading):
-
-2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=22041
- Fix CURL crashes on the test suite
-
- Do not send "no data" to WebCore in parseDataUrl().
-
- Fixes assert on fast/tokenizer/image-empty-crash.html
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::parseDataUrl):
-
-2008-11-02 Xan Lopez <xan@gnome.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=22009
- HTML5 Video with GStreamer pulls gnome-vfs without using it
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- Remove gnome-vfs include.
+ (WebCore::RenderLayer::paintLayer):
+ Don't short-circuit the "painting" pass that is used to udpate control tints.
-2008-11-01 Adam Barth <abarth@webkit.org>
+2009-06-22 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Sam Weinig.
- Be sure to check the final URLs of requested resources to make sure we
- don't get fooled by HTTP redirects.
-
- https://bugs.webkit.org/show_bug.cgi?id=21963
-
- Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
- http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
-
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::openFunc):
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::canRequest):
- (WebCore::DocLoader::requestResource):
- * loader/DocLoader.h:
- * xml/XSLTProcessor.cpp:
- (WebCore::docLoaderFunc):
-
-2008-11-01 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=22001
- AtomicStringImpl* keys of event listener maps can outlive their strings
-
- Test: fast/events/destroyed-atomic-string.html
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::addEventListener):
- (WebCore::MessagePort::removeEventListener):
- (WebCore::MessagePort::dispatchEvent):
- * dom/MessagePort.h:
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::addEventListener):
- (WebCore::DOMApplicationCache::removeEventListener):
- (WebCore::DOMApplicationCache::dispatchEvent):
- * loader/appcache/DOMApplicationCache.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::addEventListener):
- (WebCore::XMLHttpRequest::removeEventListener):
- (WebCore::XMLHttpRequest::dispatchEvent):
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::addEventListener):
- (WebCore::XMLHttpRequestUpload::removeEventListener):
- (WebCore::XMLHttpRequestUpload::dispatchEvent):
- * xml/XMLHttpRequestUpload.h:
- Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
-
-2008-10-31 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21998
- Use JSDOMGlobalObject in EventListener-related bindings
-
- * dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
-
- * bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
- bindings for inline event handlers.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSEventTargetNodeCustom.cpp:
- (WebCore::JSEventTargetNode::addEventListener):
- (WebCore::JSEventTargetNode::removeEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
-
- * dom/EventTarget.h:
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::scriptExecutionContext):
- * dom/EventTargetNode.h:
- * dom/MessagePort.cpp:
- * dom/MessagePort.h:
- (WebCore::MessagePort::scriptExecutionContext):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::scriptExecutionContext):
- * loader/appcache/DOMApplicationCache.h:
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::scriptExecutionContext):
- * svg/SVGElementInstance.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::scriptExecutionContext):
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
- * xml/XMLHttpRequestUpload.h:
- Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
- available yet.
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Geoff Garen.
-
- Rename SourceRange.h to SourceCode.h.
-
- * ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
- * ForwardingHeaders/kjs/SourceRange.h: Removed.
- * bindings/js/StringSourceProvider.h:
- * bridge/NP_jsobject.cpp:
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Darin Adler.
-
- Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
- <https://bugs.webkit.org/show_bug.cgi?id=22019>
-
- * WebCore.base.exp:
- * page/Console.cpp:
- (WebCore::printToStandardOut):
- (WebCore::Console::shouldPrintExceptions):
- (WebCore::Console::setShouldPrintExceptions):
- * page/Console.h:
-
-2008-10-31 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
-
- * dom/Document.cpp:
- (WebCore::Document::cookie): Added checking if cookies are disabled.
- (WebCore::Document::setCookie): Ditto.
- * page/Navigator.cpp:
- (WebCore::Navigator::cookieEnabled): Ditto.
- * page/Page.cpp:
- (WebCore::Page::Page): Initialize m_cookieEnabled to true.
- * page/Page.h:
- (WebCore::Page::cookieEnabled): Added.
- (WebCore::Page::setCookieEnabled): Added.
-
-2008-10-31 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
- https://bugs.webkit.org/show_bug.cgi?id=22008
-
- * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon):
- Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
- * platform/graphics/Icon.h: ditto.
- * platform/graphics/gtk/IconGtk.cpp:
- (WebCore::Icon::createIconForFile): ditto.
- (WebCore::Icon::createIconForFiles): ditto.
- * platform/graphics/mac/IconMac.mm:
- (WebCore::Icon::createIconForFile): ditto.
- (WebCore::Icon::createIconForFiles): ditto.
- * platform/graphics/qt/IconQt.cpp:
- (WebCore::Icon::createIconForFile): ditto.
- (WebCore::Icon::createIconForFiles): ditto.
- * platform/wx/TemporaryLinkStubs.cpp:
- (Icon::createIconForFile): ditto.
- (Icon::createIconForFiles): ditto.
- * platform/graphics/win/IconWin.cpp:
- (WebCore::Icon::createIconForFile): ditto.
- (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
-
- * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
- Improve icon creation code to match new code in Icon::createIconForFiles
-
-2008-10-31 Timothy Hatcher <timothy@apple.com>
-
- Add manual tests that check breakpoints on a blockless body of "for" loops.
-
- https://bugs.webkit.org/show_bug.cgi?id=22004
-
- Reviewed by Darin Adler.
-
- * manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
- * manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
-
-2008-10-31 Darin Adler <darin@apple.com>
-
- - fix build
-
- * platform/win/WCDataObject.cpp: Added missing include of "config.h".
-
-2008-10-30 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21970
- Make MessagePort event dispatch work in workers
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
- (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- (WebCore::JSDOMGlobalObject::findJSEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
- (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
- (WebCore::JSDOMGlobalObject::jsEventListeners):
- (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
- (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
- (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
- (WebCore::JSDOMGlobalObject::setCurrentEvent):
- (WebCore::JSDOMGlobalObject::currentEvent):
- (WebCore::toJSDOMGlobalObject):
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
- (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
- * bindings/js/JSDOMWindowBase.h:
- Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
- (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
- (WebCore::JSUnprotectedEventListener::globalObject):
- (WebCore::JSUnprotectedEventListener::clearGlobalObject):
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSEventListener::globalObject):
- (WebCore::JSEventListener::clearGlobalObject):
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventListener.h:
- (WebCore::JSUnprotectedEventListener::create):
- (WebCore::JSEventListener::create):
- (WebCore::JSLazyEventListener::create):
- Changed to use JSDOMGlobalObject and ScriptExecutionContext.
-
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- (WebCore::JSMessagePort::setOnmessage):
- (WebCore::JSMessagePort::setOnclose):
- Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
- such code, and stop using a custom implementation for JSMessagePort inline event handler
- getters and setters.
-
- * dom/Document.cpp:
- (WebCore::Document::virtualURL):
- * dom/Document.h:
- * dom/ScriptExecutionContext.h:
- Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
- JSLazyEventListener).
-
-2008-10-31 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Speculative wxWindows build fix.
-
- * webcore-base.bkl:
-
-2008-10-30 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Jon Homeycutt.
-
- Explicitly default to building for only the native architecture in debug and release builds.
-
- * Configurations/DebugRelease.xcconfig:
-
-2008-10-30 Cameron Zwarich <zwarich@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Create a debugger directory in JavaScriptCore and move the relevant
- files to it.
-
- * ForwardingHeaders/debugger: Added.
- * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
- * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
- * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
- * ForwardingHeaders/kjs/debugger.h: Removed.
- * WebCore.pro:
- * bindings/js/ScriptController.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptDebugServer.cpp:
- * inspector/JavaScriptDebugServer.h:
-
-2008-10-30 Tony Chang <tony@chromium.org>
-
- Fix 2 Windows theme bugs:
- 1) Checkboxes marked readonly were rendered incorrectly
- 2) If a button has focus and is pressed, it was rendered
- as focused rather than pressed.
-
- https://bugs.webkit.org/show_bug.cgi?id=21859
-
- Reviewed by Dave Hyatt.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::determineState):
- (WebCore::RenderThemeWin::determineButtonState):
-
-2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
-
- gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
- warnings; add some parentheses to disambiguate things. No functional
- changes, so no tests.
-
- https://bugs.webkit.org/show_bug.cgi?id=21973
- Add parentheses to clean up some gcc warnings
-
- Reviewed by Dan Bernstein.
-
- * platform/graphics/Font.h:
- (WebCore::Font::treatAsZeroWidthSpace):
-
-2008-10-30 Aaron Boodman <aa@chromium.org>
-
- Added an explicit dependency on HashMap.h. It was getting pulled in via
- <kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.
-
- Reviewed by Darin Adler.
-
- * platform/text/PlatformString.h:
-
-2008-10-30 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=21967
-
- For some platforms the GeolocationService must be suspended and resumed.
-
- * page/Geolocation.cpp:
- (WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners()
- (WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners
- (WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners
- (WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
- * page/Geolocation.h:
- (WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
- * platform/GeolocationService.h:
- (WebCore::GeolocationService::suspend): empty implementation
- (WebCore::GeolocationService::resume): empty implementation
-
-2008-10-30 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=21966
-
- The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
- http://dev.w3.org/geo/api/spec-source.html
-
- * page/Geolocation.cpp:
- (WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
- * page/Geoposition.cpp: velocity is now called speed
- (WebCore::Geoposition::toString):
- * page/Geoposition.h: velocity is now called speed
- (WebCore::Geoposition::create):
- (WebCore::Geoposition::speed):
- (WebCore::Geoposition::Geoposition):
- * page/Geoposition.idl: velocity is now called speed
- * page/PositionOptions.h: timeout is now unsigned
- (WebCore::PositionOptions::create):
- (WebCore::PositionOptions::timeout):
- (WebCore::PositionOptions::setTimeout):
- (WebCore::PositionOptions::PositionOptions):
- * page/PositionOptions.idl: timeout is now unsigned long
-
-2008-10-30 Justin Garcia <justin.garcia@apple.com>
-
- Also handle preserved newlines.
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
-
-2008-10-30 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- Don't store the endingSelection() in selection, just call endingSelection() in the few places it's
- needed. This function is cheap since it just returns a reference to a Selection instead of creating one.
- Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote),
- we now use visiblePos (in order to avoid VisiblePosition creation).
- Set pos after we delete the current selection (if there is one), and be consistent about what we set
- pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact...
- ...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is
- in the first node that we want to move. This fixes the bug, since it lets code that checks for the case
- where the caret is between text and a br work correctly.
-
-2008-10-30 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Darin Adler.
-
- Fix the Qt build.
-
- https://bugs.webkit.org/show_bug.cgi?id=21969
-
- * inspector/front-end/WebKit.qrc:
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::context):
- (WebCore::ImageBuffer::image):
- (WebCore::ImageBuffer::toDataURL):
-
-2008-10-30 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- More preparation for:
- <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the
- startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote.
- This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This
- doesn't really fix a bug, since we can't really get into a situation where we move to a different
- topBlockquote, but it simplifies the code.
-
-2008-10-30 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=21883
- [CAIRO] globalAlpha has to be stored and restored
-
- Cairo's globalAlpha has to be stored and reloaded on calling
- save() and restore(). We use the power of GraphicsContextState for this.
-
- * platform/graphics/GraphicsContextPrivate.h:
- (WebCore::GraphicsContextState::GraphicsContextState):
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::setAlpha):
- (WebCore::GraphicsContext::getAlpha):
- * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
-
-2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26567
+ Upstream V8 bindings code generator. With this change, also added interface ancestor
+ traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
+ to determine whether an interface is a Node to facilitate proper casting and storage
+ in V8DOMMap.
- Reviewed by Maciej Stachowiak.
+ * bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed
+ by V8 bindings.
+ * bindings/scripts/CodeGeneratorV8.pm: Added.
+ * bindings/scripts/IDLParser.pm: Modified to allow limited parsing for
+ parent traversal cases.
- Rename "attachedToEventTargetNode" to "isInline".
+2009-06-22 Sam Weinig <sam@webkit.org>
- Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
- XMLHttpRequest, MessagePort et al.
+ Reviewed by Gavin Barraclough.
- Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
- attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
- And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
- "inlineEventListenerForType", as they work with inline listeners.
+ Add event handler attribute getter/setters to HTMLFrameSetElement
+ as specified in HTML 5. These match the ones on HTMLBodyElement.
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::setOnmessage):
- (WebCore::JSMessagePort::setOnclose):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- Pass a correct value for this argument - callers used to be confused, because they didn't
- consider themselves event target nodes. This doesn't affect behavior however, as the only
- difference between inline and non-inline event handlers is that the former treat
- "return false" as "event.preventDefault()", which is not important to any of these objects.
-
- * bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
- Assert that isInline is true instead of checking its value, as the constructor of this class
- always sets it to true.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- (WebCore::JSDOMWindowBase::findJSEventListener):
- (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
- (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
- (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
- (WebCore::JSDOMWindowBase::jsInlineEventListeners):
- (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::JSAbstractEventListener::isInline):
- (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
- (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSLazyEventListener::parseCode):
- * bindings/js/JSEventListener.h:
- (WebCore::JSAbstractEventListener::JSAbstractEventListener):
- (WebCore::JSUnprotectedEventListener::create):
- (WebCore::JSEventListener::create):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createInlineEventHandler):
- * bindings/js/ScriptController.h:
- * dom/Document.cpp:
- (WebCore::Document::setWindowInlineEventListenerForType):
- (WebCore::Document::windowInlineEventListenerForType):
- (WebCore::Document::removeWindowInlineEventListenerForType):
- (WebCore::Document::createEventListener):
- (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
- * dom/Document.h:
- * dom/EventListener.h:
- (WebCore::EventListener::isInline):
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::removeInlineEventListenerForType):
- (WebCore::EventTargetNode::setInlineEventListenerForType):
- (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute):
- (WebCore::EventTargetNode::inlineEventListenerForType):
- (WebCore::EventTargetNode::on*): (many methods)
- (WebCore::EventTargetNode::setOn*): (many methods)
- * dom/EventTargetNode.h:
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::parseMappedAttribute):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::parseMappedAttribute):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * dom/Node.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::setInlineEventListenerForType):
- (WebCore::DOMWindow::inlineEventListenerForType):
- (WebCore::DOMWindow::on*): (many methods)
- (WebCore::DOMWindow::setOn*): (many methods)
- * page/DOMWindow.h:
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::parseMappedAttribute):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::on*): (many methods)
- (WebCore::SVGElementInstance::setOn*): (many methods)
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
- Rename things, as described above.
-
-2008-10-29 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed and slightly changed by Holger Freyther.
-
- Added all the files that need to be installed for the Inspector to
- work.
-
- * GNUmakefile.am: Invoke the shell to get the files.
-
-2008-10-29 Andrew Scherkus <scherkus@chromium.org>
-
- Reviewed by Darin Adler
-
- Add MediaPlayerPrivateChromium to MediaPlayer
- https://bugs.webkit.org/show_bug.cgi?id=21930
-
- * platform/graphics/MediaPlayer.cpp:
-
-2008-10-29 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- Some preparation for:
- <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
-
- Added an early return to avoid a level of if-nesting. No other changes. We probably don't
- need to rebalance whitespace before the early return but for now don't risk any change in behavior
- I'll revisit that later.
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
-
-2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after addition of runtime and ImageBuffer changes.
-
- * platform/graphics/wx/ImageBufferData.h: Added.
- * platform/graphics/wx/ImageBufferWx.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::context):
- * webcore-base.bkl:
-
-2008-10-29 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Adler
- https://bugs.webkit.org/attachment.cgi?id=24745
-
- Allow Skia implementations to get text style changed notifications.
-
- * platform/graphics/GraphicsContext.cpp:
+ (WebCore::HTMLFrameSetElement::onblur):
+ (WebCore::HTMLFrameSetElement::setOnblur):
+ (WebCore::HTMLFrameSetElement::onerror):
+ (WebCore::HTMLFrameSetElement::setOnerror):
+ (WebCore::HTMLFrameSetElement::onfocus):
+ (WebCore::HTMLFrameSetElement::setOnfocus):
+ (WebCore::HTMLFrameSetElement::onload):
+ (WebCore::HTMLFrameSetElement::setOnload):
+ (WebCore::HTMLFrameSetElement::onbeforeunload):
+ (WebCore::HTMLFrameSetElement::setOnbeforeunload):
+ (WebCore::HTMLFrameSetElement::onmessage):
+ (WebCore::HTMLFrameSetElement::setOnmessage):
+ (WebCore::HTMLFrameSetElement::onoffline):
+ (WebCore::HTMLFrameSetElement::setOnoffline):
+ (WebCore::HTMLFrameSetElement::ononline):
+ (WebCore::HTMLFrameSetElement::setOnonline):
+ (WebCore::HTMLFrameSetElement::onresize):
+ (WebCore::HTMLFrameSetElement::setOnresize):
+ (WebCore::HTMLFrameSetElement::onstorage):
+ (WebCore::HTMLFrameSetElement::setOnstorage):
+ (WebCore::HTMLFrameSetElement::onunload):
+ (WebCore::HTMLFrameSetElement::setOnunload):
+ * html/HTMLFrameSetElement.h:
+ * html/HTMLFrameSetElement.idl:
-2008-10-29 Timothy Hatcher <timothy@apple.com>
+2009-06-22 Darin Adler <darin@apple.com>
- Add a manual test that checks breakpoints on a blockless body of
- an "else" statement.
+ Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21944
+ Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
+ https://bugs.webkit.org/show_bug.cgi?id=25425
- Reviewed by Maciej Stachowiak.
+ * bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
+ * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- * manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
+ * dom/Element.cpp:
+ (WebCore::Element::getURLAttribute): Added. For use implementing getters
+ for ReflectURL.
+ * dom/Element.h: Added getURLAttribute.
-2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+ * html/HTMLImageElement.idl: Use Reflect and ReflectURL.
- Reviewed by Darin Adler.
+2009-06-22 Jian Li <jianli@chromium.org>
- https://bugs.webkit.org/show_bug.cgi?id=21921
- MessagePort messages are dispatched to documents that are not fully active
+ Reviewed by Dimitri Glazkov.
- Covered by corrected fast/events/message-port-inactive-document.html
+ Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
+ objects.
+ https://bugs.webkit.org/show_bug.cgi?id=26626
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts
- that are not fully active.
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::ToV8Object):
-2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21922
- Expose MessagePort global constructor
-
- Covered by existing dumper tests.
-
- * dom/MessagePort.idl:
- * page/DOMWindow.idl:
-
-2008-10-29 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21924
- HashTable internal index is not always deleted
-
- * bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
- Call deleteTable for HashTables that are being deleted.
-
-2008-10-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21923
- Create an abstraction for script execution context
+ Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
+ of 300x150.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- Added ScriptExecutionContext.{h,cpp}.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSAudioConstructor.h:
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSImageConstructor.h:
- * bindings/js/JSOptionConstructor.cpp:
- (WebCore::JSOptionConstructor::JSOptionConstructor):
- * bindings/js/JSOptionConstructor.h:
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- * bindings/js/JSXMLHttpRequestConstructor.h:
- Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy.
- Since these objects can only work within documents now, it is immediately converted back
- to Document.
-
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- (WebCore::JSMessageChannelConstructor::construct):
- * bindings/js/JSMessageChannelConstructor.h:
- (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
- MessageChannel needs to be supported in workers right away, so the constructor operates with
- it directly.
-
- * dom/ActiveDOMObject.cpp:
- (WebCore::ActiveDOMObject::ActiveDOMObject):
- (WebCore::ActiveDOMObject::~ActiveDOMObject):
- (WebCore::ActiveDOMObject::contextDestroyed):
- * dom/ActiveDOMObject.h:
- (WebCore::ActiveDOMObject::scriptExecutionContext):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::markActiveObjectsForContext):
- (WebCore::markCrossHeapDependentObjectsForContext):
- Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort
- tracking is handled by ScriptExecutionContext.
-
- * bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
-
- * bindings/js/JSDOMGlobalObject.h:
- (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject.
- Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible
- to worker context implementation.
- (WebCore::scriptExecutionContext): Added a pure virtual method to access
- ScriptExecutionContext, implemented by subclasses.
-
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext):
- Implement by returning the associated document. Note that this method currently gives bogus
- results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document
- that is currently in the frame, not the one associated with this window.
-
- * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
-
- * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
- Call markActiveObjectsForContext() by its new name.
-
- * dom/DedicatedWorker.cpp:
- (WebCore::DedicatedWorker::DedicatedWorker):
- (WebCore::DedicatedWorker::document):
- * dom/DedicatedWorker.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::document):
- * xml/XMLHttpRequest.h:
- Added a document() function that upcasts ScriptExecutionContext, as these objects only work
- within documents currently (at least for XMLHttpRequest, this will change soon though).
-
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::~Document):
- Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code
- with workers.
-
- * dom/Document.h:
- (WebCore::Document::isDocument):
- (WebCore::Document::refScriptExecutionContext):
- (WebCore::Document::derefScriptExecutionContext):
- Inherit from ScriptExecutionContext.
-
- * dom/MessageChannel.cpp:
- (WebCore::MessageChannel::MessageChannel):
- * dom/MessageChannel.h:
- (WebCore::MessageChannel::create):
- Use ScriptExecutionContext instead of Document.
-
- * dom/MessagePort.cpp:
- (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because
- MessagePort doesn't ref() itself when posting this event any more (this is a fix for an
- unrelated issue that was causing random crashes in layout tests).
- (WebCore::MessagePort::MessagePort):
- (WebCore::MessagePort::~MessagePort):
- (WebCore::MessagePort::associatedFrame):
- (WebCore::MessagePort::clone):
- (WebCore::MessagePort::postMessage):
- (WebCore::MessagePort::startConversation):
- (WebCore::MessagePort::start):
- (WebCore::MessagePort::contextDestroyed):
- (WebCore::MessagePort::dispatchMessages):
- * dom/MessagePort.h:
- (WebCore::MessagePort::create):
- (WebCore::MessagePort::scriptExecutionContext):
- Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort
- work in worker contexts - we need to also make some its method thread safe for cross-thread
- messaging, and make event dispatching thread safe.
-
- * dom/ScriptExecutionContext.cpp: Added.
- * dom/ScriptExecutionContext.h: Added.
- ActiveDOMObject and MessagePort tracking is moved from Document.
- It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow,
- but as I'm just moving Document code, and it is Document that is the main context object
- in our implementation currently.
- Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that
- seem non-trivial to fix, and isn't really a part of this task.
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- List newly-added ImageBufferData.h in build system.
-
- * GNUmakefile.am:
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- Reviewed by Cameron Zwarich.
-
- De-list unused WebCore ForwardingHeaders to fix the dist target.
-
- * GNUmakefile.am:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Attempt to fix the Windows build by generating Forwardingheaders for the
- runtime directory in JavaScriptCore.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-10-28 Justin Garcia <justin.garcia@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
-
- * editing/Editor.cpp:
- (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
- (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which
- will probably require a change more complicated than just marking the learned word as
- misspelled. I'll address it with a separate patch.
- * editing/EditorCommand.cpp:
- (WebCore::executeIgnoreSpelling): Added.
- (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Mark Rowe.
-
- Move ForwardingHeaders to their correct location after the creation of
- the runtime directory in JavaScriptCore.
-
- * ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
- * ForwardingHeaders/kjs/BooleanObject.h: Removed.
- * ForwardingHeaders/kjs/CallData.h: Removed.
- * ForwardingHeaders/kjs/ConstructData.h: Removed.
- * ForwardingHeaders/kjs/DateInstance.h: Removed.
- * ForwardingHeaders/kjs/Error.h: Removed.
- * ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
- * ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
- * ForwardingHeaders/kjs/InternalFunction.h: Removed.
- * ForwardingHeaders/kjs/JSArray.h: Removed.
- * ForwardingHeaders/kjs/JSFunction.h: Removed.
- * ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
- * ForwardingHeaders/kjs/JSNumberCell.h: Removed.
- * ForwardingHeaders/kjs/JSObject.h: Removed.
- * ForwardingHeaders/kjs/JSString.h: Removed.
- * ForwardingHeaders/kjs/JSValue.h: Removed.
- * ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
- * ForwardingHeaders/kjs/PropertyMap.h: Removed.
- * ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
- * ForwardingHeaders/kjs/StringObject.h: Removed.
- * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
- * ForwardingHeaders/kjs/StringPrototype.h: Removed.
- * ForwardingHeaders/kjs/StructureID.h: Removed.
- * ForwardingHeaders/runtime: Added.
- * ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
- * ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
- * ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
- * ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
- * ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
- * ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
- * ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
- * ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
- * ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
- * ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
- * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
- * ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
- * ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
- * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
- * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
- * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
- * ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
- * ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
- * ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
- * ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
- * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
- * ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
- * ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- * bindings/js/JSClipboardCustom.cpp:
- * bindings/js/JSConsoleCustom.cpp:
- * bindings/js/JSCustomPositionCallback.h:
- * bindings/js/JSCustomPositionErrorCallback.h:
- * bindings/js/JSCustomSQLStatementCallback.h:
- * bindings/js/JSCustomSQLStatementErrorCallback.h:
- * bindings/js/JSCustomSQLTransactionErrorCallback.h:
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSCustomXPathNSResolver.h:
- * bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMGlobalObject.h:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowCustom.cpp:
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSDatabaseCustom.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventTarget.h:
- * bindings/js/JSHTMLDocumentCustom.cpp:
- * bindings/js/JSHistoryCustom.cpp:
- * bindings/js/JSInspectedObjectWrapper.cpp:
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- * bindings/js/JSLocationCustom.cpp:
- * bindings/js/JSNodeFilterCondition.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- * bindings/js/JSQuarantinedObjectWrapper.h:
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- * bindings/objc/WebScriptObject.mm:
- * bindings/objc/WebScriptObjectPrivate.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- * bridge/c/c_instance.cpp:
- * bridge/c/c_utility.cpp:
- * bridge/c/c_utility.h:
- * bridge/jni/jni_instance.cpp:
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- * bridge/jni/jni_runtime.cpp:
- * bridge/jni/jni_utility.cpp:
- * bridge/jni/jni_utility.h:
- * bridge/objc/objc_instance.mm:
- * bridge/objc/objc_runtime.h:
- * bridge/objc/objc_runtime.mm:
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- * bridge/runtime.h:
- * bridge/runtime_array.cpp:
- * bridge/runtime_array.h:
- * bridge/runtime_method.cpp:
- * bridge/runtime_method.h:
- * bridge/runtime_object.cpp:
- * bridge/runtime_object.h:
- * bridge/runtime_root.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * inspector/JavaScriptProfile.cpp:
- * inspector/JavaScriptProfile.h:
- * inspector/JavaScriptProfileNode.cpp:
- * inspector/JavaScriptProfileNode.h:
- * loader/FrameLoader.cpp:
- * page/Console.cpp:
- * plugins/PluginView.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- * plugins/qt/PluginViewQt.cpp:
- * plugins/win/PluginViewWin.cpp:
-
-2008-10-28 Adele Peterson <adele@apple.com>
-
- Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-10-28 Adele Peterson <adele@apple.com>
-
- Windows build fix.
-
- * platform/graphics/ImageBuffer.h:
- (WebCore::ImageBuffer::create):
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Roll out a mistaken attempt at fixing the GTK build in r37947.
-
- * GNUmakefile.am:
-
-2008-10-28 Adele Peterson <adele@apple.com>
-
- Reviewed by John Sullivan.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
- "files" string for multifile uploads needs to be localized
-
- * page/mac/WebCoreViewFactory.h:
- * platform/LocalizedStrings.h:
- * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
- * platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
- * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
- * platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
- * platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
- * platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
-
-2008-10-28 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21816
-
- Remove platform ifdefs in ImageBuffer.h by moving platform specific code
- into a new PlatformImageBuffer class. Move the static create function
- into the header because it can be cross-platform. Initialization now
- happens in the cunstructor which sets a flag that create uses to know
- whether it should return null or not. I also made passing of IntSize
- more consistent (always by reference).
-
- This change also changes the ifdefs in GraphicsContext to allow Skia
- ports to implement text drawing modes.
-
- * platform/graphics/ImageBuffer.h:
- (WebCore::ImageBuffer::create):
- (WebCore::ImageBuffer::size):
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::~ImageBuffer):
- (WebCore::ImageBuffer::image):
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- * platform/graphics/cairo/ImageBufferData.h:
- * platform/graphics/cg/ImageBufferCG.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::~ImageBuffer):
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- * platform/graphics/cg/ImageBufferData.h:
- * platform/graphics/qt/ImageBufferData.h:
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBufferData::ImageBufferData):
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::~ImageBuffer):
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Fix the GTK build.
-
- * GNUmakefile.am:
-
-2008-10-28 Cameron Zwarich <zwarich@apple.com>
-
- Not reviewed.
-
- Another Qt build fix.
-
- * WebCore.pro:
-
-2008-10-28 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=21932
- Add non-pointer constant lookups to SoftLinking.h
-
- * platform/mac/SoftLinking.h:
-
-2008-10-28 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by David Kilzer.
-
- https://bugs.webkit.org/show_bug.cgi?id=2192
- Missing semi-colons in Geoposition.idl
-
- * page/Geoposition.idl: Add missing semi-colons
-
-2008-10-28 Timothy Hatcher <timothy@apple.com>
-
- Make the Profiles panel in the Web Inspector have an enable screen.
- Profiling now needs to be enabled before console.profile() works.
-
- <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
- not slow down JavaScript all the time
-
- Reviewed by Darin Adler and Kevin McCullough.
-
- * English.lproj/localizedStrings.js: New strings.
- * WebCore.base.exp: New and changed exports.
- * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
- Timer to call InspectorController::startUserInitiatedProfiling.
- (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
- that calls InspectorController::startUserInitiatedProfiling.
- (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
- and enable the profiler if the profiler was not enabled.
- (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
- (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
- if the skipRecompile argument is false. Call the profilerWasEnabled script function.
- (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
- Call the profilerWasEnabled script function.
- (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
- so it won't be started later.
- * inspector/InspectorController.h:
- (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
- * inspector/front-end/Images/debuggingButtons.png: Remove.
- * inspector/front-end/Images/enableButtons.png: Added.
- * inspector/front-end/Images/profilesSilhouette.png: Added.
- * inspector/front-end/Images/scriptsSilhouette.png: Added.
- * inspector/front-end/PanelEnablerView.js: Added.
- (WebInspector.PanelEnablerView):
- (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
- event so listeners can do their thing.
- (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
- * inspector/front-end/ProfilesPanel.js:
- (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
- (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
- (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
- (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
- (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
- (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
- (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
- show/hide other buttons. Also show/hide the PanelEnablerView.
- (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
- (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
- disableProfiler or enableProfiler.
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
- debuggingButton with the enableToggleButton.
- (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
- the enableToggleButton.
- (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
- when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
- with the enableToggleButton.
- (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
- (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
- since reset is called from debuggerWasEnabled and debuggerWasDisabled.
- * inspector/front-end/View.js: Inherit from WebInspector.Object.
- * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
- * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
- * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
- * inspector/front-end/inspector.js:
- (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
- (WebInspector.profilerWasDisabled): Ditto.
- * page/Console.cpp:
- (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
- (WebCore::Console::info): Ditto.
- (WebCore::Console::log): Ditto.
- (WebCore::Console::assertCondition): Ditto.
- (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
- (WebCore::Console::count): Ditto.
- (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
- (WebCore::Console::profileEnd): Ditto.
- (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
- (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
- Now just sets the member boolean.
- * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
-
-2008-10-28 Timothy Hatcher <timothy@apple.com>
-
- Rename a few methods related to attaching and detaching the debugger. Also
- adds stub methods for enabling and disabling the profiler.
-
- * Rename attachDebugger to enableDebugger.
- * Rename detachDebugger to disableDebugger.
- * Rename the debuggerAttached getter to debuggerEnabled.
- * Rename the debuggerAttached callback to debuggerWasEnabled.
- * Rename the debuggerDetached callback to debuggerWasDisabled.
-
- Reviewed by Darin Adler.
-
- * WebCore.base.exp:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::windowScriptObjectAvailable):
- (WebCore::InspectorController::close):
- (WebCore::InspectorController::enableProfiler):
- (WebCore::InspectorController::disableProfiler):
- (WebCore::InspectorController::enableDebugger):
- (WebCore::InspectorController::disableDebugger):
- (WebCore::InspectorController::pauseInDebugger):
- (WebCore::InspectorController::resumeDebugger):
- (WebCore::InspectorController::stepOverStatementInDebugger):
- (WebCore::InspectorController::stepIntoStatementInDebugger):
- (WebCore::InspectorController::stepOutOfFunctionInDebugger):
- * inspector/InspectorController.h:
- (WebCore::InspectorController::profilerEnabled):
- (WebCore::InspectorController::debuggerEnabled):
- * inspector/front-end/BreakpointsSidebarPane.js:
- (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
- (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
- (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- * inspector/front-end/Object.js:
- * inspector/front-end/ProfilesPanel.js:
- (WebInspector.ProfilesPanel):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel):
- (WebInspector.ScriptsPanel.prototype.get statusBarItems):
- (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
- (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
- (WebInspector.ScriptsPanel.prototype.reset):
- (WebInspector.ScriptsPanel.prototype.canShowResource):
- (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
- (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
- (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- * inspector/front-end/View.js:
- * inspector/front-end/inspector.css:
- * inspector/front-end/inspector.html:
- * inspector/front-end/inspector.js:
- (WebInspector.addResource):
- (WebInspector.debuggerWasEnabled):
- (WebInspector.debuggerWasDisabled):
-
-2008-10-28 Timothy Hatcher <timothy@apple.com>
-
- Fix an exception when searching the Resources panel while there
- and resources queued to be added to the list.
-
- Reviewed by Kevin McCullough.
-
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check
- the _resourcesTreeElement property.
- (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
- isn't defined.
-
- * platform/graphics/gtk/FontGtk.cpp:
- (WebCore::getDefaultPangoLayout):
- * platform/graphics/gtk/FontPlatformDataPango.cpp:
-
-2008-10-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21893
- Character set is incorrect for external scripts in XHTML pages
-
- <rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/
-
- Test: fast/encoding/external-script-charset.xhtml
-
- Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.
-
- * dom/ScriptElement.h:
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::XMLTokenizer::endElementNs):
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::parseEndElement):
- * html/HTMLScriptElement.h:
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::scriptCharset):
- * svg/SVGScriptElement.h:
-
-2008-10-28 Alp Toker <alp@nuanti.com>
-
- Include copyright license files in the autotools dist target and
- exclude unused zlib headers.
-
- Change suggested by Mike Hommey.
-
- * GNUmakefile.am:
-
-2008-10-27 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Clear the window shell when destroying a page to allow documents
- which have no way of being reached anymore, to be torn down.
-
- * page/Frame.cpp:
- (WebCore::Frame::pageDestroyed):
-
-2008-10-27 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Update the active state as well as the focused state as both need to be true
- for the caret to be drawn.
-
- https://bugs.webkit.org/show_bug.cgi?id=21900
-
- * WebView.cpp:
- (wxWebView::OnSetFocus):
- (wxWebView::OnKillFocus):
-
-2008-10-27 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
-
- * webcore-wx.bkl:
-
-2008-10-27 Michael Knaup <michael.knaup@mac.com>
-
- Reviewed and tweaked by Darin Adler.
-
- - https://bugs.webkit.org/show_bug.cgi?id=8988
-
- Bug 8988: Add support for Mozilla CSS custom cursors.
- Added -webkit-grab and -webkit-grabbing cursor suppport
- for the Mac, dummy implementations for other platforms.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Updated since the
- -webkit-grabbing cursor is now the last one.
-
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added
- CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
-
- * css/CSSValueKeywords.in: Added -webkit-grab and
- -webkit-grabbing.
-
- * manual-tests/cursor.html: Added -webkit-zoom-in,
- webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::selectCursor): Added
- CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
-
- * platform/Cursor.h: Added grabCursor and grabbingCursor.
-
- * platform/gtk/CursorGtk.cpp:
- (WebCore::grabCursor): Added.
- (WebCore::grabbingCursor): Added.
- * platform/mac/CursorMac.mm:
- (WebCore::grabCursor): Added.
- (WebCore::grabbingCursor): Added.
- * platform/qt/CursorQt.cpp:
- (WebCore::grabCursor): Added.
- (WebCore::grabbingCursor): Added.
- * platform/win/CursorWin.cpp:
- (WebCore::grabCursor): Added.
- (WebCore::grabbingCursor): Added.
- * platform/wx/CursorWx.cpp:
- (WebCore::grabCursor): Added.
- (WebCore::grabbingCursor): Added.
-
- * rendering/style/RenderStyleConstants.h:
- Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
- Also broke ECursor out into a single constant per line.
- Also added a couple of comments.
-
-2008-10-27 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed by Darin Adler.
-
- * svg/SVGAnimatedTemplate.h: needed a HashMap define
-
-2008-10-21 Eric Seidel <eric@webkit.org>
+ * css/html4.css:
+ * html/HTMLDataGridElement.cpp:
+ (WebCore::HTMLDataGridElement::createRenderer):
+ * html/HTMLDataGridElement.h:
+ * html/HTMLDataGridElement.idl:
+ * rendering/RenderDataGrid.cpp: Added.
+ (WebCore::RenderDataGrid::RenderDataGrid):
+ (WebCore::RenderDataGrid::~RenderDataGrid):
+ (WebCore::RenderDataGrid::calcPrefWidths):
+ (WebCore::RenderDataGrid::paintObject):
+ (WebCore::RenderDataGrid::valueChanged):
+ (WebCore::RenderDataGrid::invalidateScrollbarRect):
+ (WebCore::RenderDataGrid::isActive):
+ * rendering/RenderDataGrid.h: Added.
+ (WebCore::RenderDataGrid::renderName):
+ (WebCore::RenderDataGrid::canHaveChildren):
+ (WebCore::RenderDataGrid::scrollbarCornerPresent):
+
+2009-06-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt.
- Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
- https://bugs.webkit.org/show_bug.cgi?id=20400
-
- Test: svg/custom/stop-crash.svg
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/RenderSVGGradientStop.h:
- (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
-
-2008-10-27 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- No need to call release if the connection is null.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::start):
-
-2008-10-27 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin Decker.
+ https://bugs.webkit.org/show_bug.cgi?id=26430
+ <rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
+ <rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()
+ during window resize when using hardware layers
+
+ Fix an ordering dependency which caused the compositing position of a layer
+ to be affected by some later sibling, which affected the compositing ancestor's
+ composited bounds.
+
+ The fix is to only update the compositing positions of layers in some subtree
+ when updateAfterLayout() has been called on all the layers in that subtree,
+ from the ancestor down.
+
+ Also cache the composited bounds of a RenderLayerBacking, now that we can
+ guarantee that those bounds are accurate.
+
+ Test: compositing/sibling-positioning.html
- <rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::hitTestLayer):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::RenderLayerBacking):
+ (WebCore::RenderLayerBacking::updateAfterLayout):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
+ (WebCore::RenderLayerBacking::paintContents):
+ (WebCore::RenderLayerBacking::compositedBounds):
+ (WebCore::RenderLayerBacking::setCompositedBounds):
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateBacking):
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::layerWillBeRemoved):
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
+ * rendering/RenderLayerCompositor.h:
- Make sure to null check the NSURLConnection object.
+2009-06-22 Jeremy Orlow <jorlow@chromium.org>
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::setDefersLoading):
+ Reviewed by Darin Fisher.
-2008-10-27 Alexey Proskuryakov <ap@webkit.org>
+ First step in https://bugs.webkit.org/show_bug.cgi?id=25376
- Fix non-Mac builds.
+ Add StorageSyncManager.cpp/h
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
- Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
-
-2008-10-26 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21886
- window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor
-
- Test: fast/dom/HTMLOptionElement/option-prototype.html
-
- We now have separate objects for window.Option and window.HTMLOptionElement - the latter
- "constructor" cannot be used to construct anything. This matches Firefox behavior.
-
* WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseOption):
- * bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
- * bindings/js/JSHTMLOptionElementConstructor.h: Removed.
- * bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
- * bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
- * html/HTMLOptionElement.idl:
- Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
-
- * html/HTMLOptionElement.idl: Generate a constructor.
-
-2008-10-25 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
-
- Try to fix Mac debug build on the buildbot.
-
- * platform/FileChooser.cpp:
- (WebCore::FileChooserClient::~FileChooserClient):
- * platform/FileChooser.h: Moved destructor to .cpp file, to avoid a
- weak exported symbol.
-
-2008-10-25 Jade Han <jade.han@nokia.com>
-
- Reviewed by Anders.
-
- Enable custom properties for Qt runtime objects in QtWebKit
-
- https://bugs.webkit.org/show_bug.cgi?id=21813
-
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::getOwnPropertySlot):
- (JSC::RuntimeObjectImp::put):
-
-2008-10-24 Sam Weinig <sam@webkit.org>
-
- Fix windows build.
-
- * page/Chrome.cpp:
- * page/Chrome.h:
-
-2008-10-24 Sam Weinig <sam@webkit.org>
-
- Fix Qt build.
-
- * platform/qt/FileChooserQt.cpp:
-
-2008-10-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=21759
- Layering violation: FileChooser should not depend on Document/Frame/Page
-
- Move file choosing into WebKit ChromeClient.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::runOpenPanel):
- * page/Chrome.cpp:
- (WebCore::Chrome::runOpenPanel):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * page/mac/ChromeMac.mm:
- * platform/FileChooser.h:
- * platform/mac/FileChooserMac.mm:
- * platform/qt/FileChooserQt.cpp:
- * platform/win/FileChooserWin.cpp:
- * platform/wx/TemporaryLinkStubs.cpp:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::click):
-
-2008-10-24 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix - add newIconForFiles stub.
-
- * platform/wx/TemporaryLinkStubs.cpp:
- (Icon::newIconForFiles):
-
-2008-10-24 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier.
-
- Use the CGFont metrics APIs for more accurate measurements, and tweak the y
- value the text is drawn at (it was a couple pixels off before because wx
- internally adds to the y value.
-
- https://bugs.webkit.org/show_bug.cgi?id=21853
-
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (wxFontProperties::wxFontProperties):
- * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
- (WebCore::drawTextWithSpacing):
-
-2008-10-24 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Generate missing constructors and add test to prevent missing ones in the future
- https://bugs.webkit.org/show_bug.cgi?id=21846
-
- Test: fast/js/global-constructors.html
-
- * css/CSSStyleSheet.idl:
- * css/RGBColor.idl:
- * dom/NodeIterator.idl:
- * dom/TreeWalker.idl:
- * xml/XPathExpression.idl:
-
-2008-10-24 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21836
- REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
-
- Test: http/tests/xmlhttprequest/detaching-frame.html
-
- * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window -
- even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected
- when dispatching the same callback that results in this function being called.
-
-2008-10-24 David Kilzer <ddkilzer@apple.com>
-
- Gtk build fix.
-
- * platform/gtk/TemporaryLinkStubs.cpp:
- (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
-
-2008-10-24 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::imageInterpolationQuality):
-
-2008-10-24 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- <rdar://problem/5440917> Support NPN_Construct
-
- * WebCore.NPAPI.exp:
- Export _NPN_Construct.
-
- * bridge/NP_jsobject.cpp:
- (_NPN_Construct):
- Implement this.
-
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::supportsConstruct):
- (JSC::Bindings::CInstance::invokeConstruct):
- Have this call the appropriate NPClass method.
-
- * bridge/npruntime.h:
- Add NPN_Construct.
-
- * bridge/npruntime_impl.h:
- Add _NPN_Construct.
-
- * bridge/runtime.h:
- (JSC::Bindings::Instance::supportsConstruct):
- (JSC::Bindings::Instance::invokeConstruct):
- New methods.
-
- * bridge/runtime_object.cpp:
- (JSC::callRuntimeConstructor):
- Call the native instance.
-
- (JSC::RuntimeObjectImp::getConstructData):
- Implement this.
-
- * bridge/runtime_object.h:
- Add new method declarations.
-
- * plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::load):
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::load):
- * plugins/win/PluginPackageWin.cpp:
- (WebCore::PluginPackage::load):
- Initialize m_pluginFuncs.construct.
-
-2008-10-24 Adele Peterson <adele@apple.com>
-
- Build fix.
-
- * platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
- * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):
-
-2008-10-24 Greg Bolsinga <bolsinga@apple.com>
-
- Fix GTK build break.
-
- Reviewed by David Kilzer.
-
- * GNUmakefile.am: Do not include .idl files whose generated files should not be
- compiled.
-
-2008-10-24 David Kilzer <ddkilzer@apple.com>
-
- Wx build fix.
-
- * platform/wx/TemporaryLinkStubs.cpp:
- (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
-
-2008-10-24 Adele Peterson <adele@apple.com>
-
- Reviewed by Sam Weinig.
-
- WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
-
- This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
- This is consistent with the direction HTML5 will be going in the future.
-
- The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
- the individual files in a tooltip for now. Improvements to this control will come later.
+ * WebCoreSources.bkl:
- Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
- These FileList Files can also be sent in an XMLHTTPRequest.
+ In preparation for combining SessionStorage and LocalStorage into a
+ single StorageManager, move the syncing bits out of LocalStorage and
+ into its own class.
- * manual-tests/post-multi-file-upload.html: Added.
- * manual-tests/resources/multiFileResources: Added.
- * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
- * manual-tests/resources/multiFileResources/testFile1.html: Added.
- * manual-tests/resources/multiFileResources/testFile2.html: Added.
- * manual-tests/resources/multiFileResources/testFile3.html: Added.
+ The next step is to combine LocalStorageArea and SessionStorageArea
+ into one. Then SessionStorage and LocalStorage can be combined.
- * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
+ Note that combining them will cut down on code paths that must be
+ proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
+ write historical sessionStorage to disk when memory is getting tight.
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
- (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control,
- but we don't want to break the behavior for existing websites that may rely on this.
- (WebCore::HTMLInputElement::setValue): ditto.
- (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
- (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
- * html/HTMLInputElement.h:
-
- * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
-
- * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
-
- * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
- (WebCore::FileChooser::FileChooser):
- (WebCore::FileChooser::create):
- (WebCore::FileChooser::clear):
- (WebCore::FileChooser::chooseFile):
- (WebCore::FileChooser::chooseFiles):
- (WebCore::FileChooser::chooseIcon):
- * platform/FileChooser.h:
- (WebCore::FileChooser::filePaths):
- (WebCore::FileChooser::allowsMultipleFiles):
-
- * platform/graphics/Icon.h:
- * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
- * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
- * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
- * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
-
- * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
- * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
- * platform/qt/FileChooserQt.cpp:
- (WebCore::FileChooser::openFileChooser):
- (WebCore::FileChooser::basenameForWidth):
- * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
+ Also remove a couple bits of cruft including code for quotas which is
+ unnecessary (since a meta-data db is unnecessary since you can just
+ count bytes as you read the local storage databases into memory).
- * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
- Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel
- both get called for the same ResourceHandle. This getting called twice has no negative effect.
+ * storage/LocalStorage.cpp:
+ (WebCore::LocalStorage::LocalStorage):
+ (WebCore::LocalStorage::storageArea):
+ (WebCore::LocalStorage::close):
+ * storage/LocalStorage.h:
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::LocalStorageArea):
+ (WebCore::LocalStorageArea::scheduleFinalSync):
+ (WebCore::LocalStorageArea::syncTimerFired):
+ (WebCore::LocalStorageArea::performImport):
+ * storage/LocalStorageArea.h:
+ (WebCore::LocalStorageArea::create):
+ * storage/LocalStorageTask.cpp:
+ (WebCore::LocalStorageTask::performTask):
+ * storage/LocalStorageTask.h:
+ (WebCore::LocalStorageTask::):
+ (WebCore::LocalStorageTask::createImport):
+ * storage/LocalStorageThread.cpp:
+ * storage/LocalStorageThread.h:
+ * storage/SessionStorage.h:
+ * storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp.
+ (WebCore::StorageSyncManager::create):
+ (WebCore::StorageSyncManager::StorageSyncManager):
+ (WebCore::StorageSyncManager::fullDatabaseFilename):
+ (WebCore::StorageSyncManager::close):
+ (WebCore::StorageSyncManager::scheduleImport):
+ (WebCore::StorageSyncManager::scheduleSync):
+ * storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h.
+ (WebCore::):
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer.
- (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added.
- (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser.
- (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
- * rendering/RenderFileUploadControl.h:
+2009-06-22 Darin Fisher <darin@chromium.org>
-2008-10-23 Peter Kasting <pkasting@google.com>
+ Reviewed by Dimitri Glazkov.
- Reviewed by David Hyatt.
+ https://bugs.webkit.org/show_bug.cgi?id=26622
+ Add ChromiumDataObject::copy()
- https://bugs.webkit.org/show_bug.cgi?id=21844
- Remove setFocusRingColorChangeFunction.
+ * platform/chromium/ChromiumDataObject.cpp:
+ * platform/chromium/ChromiumDataObject.h:
- * page/Page.cpp:
- (WebCore::Page::Page):
- * platform/graphics/Color.h:
- * platform/graphics/mac/ColorMac.mm:
- (WebCore::focusRingColor):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- * platform/graphics/win/ColorSafari.cpp:
+2009-06-22 Timothy Hatcher <timothy@apple.com>
-2008-10-24 David Kilzer <ddkilzer@apple.com>
+ Add a silhouette image for the enable view of the Resource panel.
- Build fix for Qt.
+ Reviewed by Kevin McCullough.
- Reviewed by Greg.
+ * inspector/front-end/Images/resourcesSilhouette.png: Added.
+ * inspector/front-end/inspector.css:
- * WebCore.pro: Added missing *.idl files.
+2009-06-22 Kyle Prete <kylep@chromium.org>
-2008-10-24 Greg Bolsinga <bolsinga@apple.com>
+ Reviewed by Dimitri Glazkov.
- Reviewed by Sam Weinig.
+ https://bugs.webkit.org/show_bug.cgi?id=26552
+ Add V8 JS bindings for Audio Constructor.
- https://bugs.webkit.org/show_bug.cgi?id=21475
+ * bindings/v8/custom/V8CustomBinding.h:
+ Added a callback declaration for audio ctor to macro.
+ * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
+ Added the whole file.
- Provide support for the Geolocation API
+2009-06-22 Alexey Proskuryakov <ap@webkit.org>
- http://dev.w3.org/geo/api/spec-source.html
+ Reviewed by David Levin.
- Test: geolocation/geolocation-not-implemented.html
+ https://bugs.webkit.org/show_bug.cgi?id=26600
+ StringImpl::copy() no longer copies empty string correctly
- * DerivedSources.make:
- * GNUmakefile.am: Added Geolocation support
- * WebCore.pro: Added Geolocation support
- * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
- * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
- * WebCoreSources.bkl: Added Geolocation support
- * bindings/js/JSCustomPositionCallback.cpp: Added.
- (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionCallback.h: Added.
- (WebCore::JSCustomPositionCallback::create):
- * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
- (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.h: Added.
- (WebCore::JSCustomPositionErrorCallback::create):
- * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
- (WebCore::markDOMObjectWrapper):
- * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
- * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
- * bindings/js/JSGeolocationCustom.cpp: Added.
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
- (WebCore::JSNavigator::mark):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- (WebCore::Document::setUsingGeolocation):
- (WebCore::Document::usingGeolocation):
- * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
- (WebCore::FrameLoader::canCachePage):
- * page/Geolocation.cpp: Added.
- (WebCore::Geolocation::GeoNotifier::GeoNotifier):
- (WebCore::Geolocation::GeoNotifier::timerFired):
- (WebCore::Geolocation::Geolocation):
- (WebCore::Geolocation::disconnectFrame):
- (WebCore::Geolocation::getCurrentPosition):
- (WebCore::Geolocation::watchPosition):
- (WebCore::Geolocation::clearWatch):
- (WebCore::Geolocation::stopUpdatingIfEmpty):
- (WebCore::Geolocation::sendErrorToOneShots):
- (WebCore::Geolocation::sendErrorToWatchers):
- (WebCore::Geolocation::sendPositionToOneShots):
- (WebCore::Geolocation::sendPositionToWatchers):
- (WebCore::Geolocation::handleError):
- (WebCore::Geolocation::geolocationServicePositionChanged):
- (WebCore::Geolocation::geolocationServiceErrorOccurred):
- * page/Geolocation.h: Added.
- (WebCore::Geolocation::create):
- (WebCore::Geolocation::~Geolocation):
- (WebCore::Geolocation::lastPosition):
- (WebCore::Geolocation::GeoNotifier::create):
- * page/Geolocation.idl: Added.
- * page/Geoposition.cpp: Added.
- (WebCore::Geoposition::toString):
- * page/Geoposition.h: Added.
- (WebCore::Geoposition::create):
- (WebCore::Geoposition::latitude):
- (WebCore::Geoposition::longitude):
- (WebCore::Geoposition::altitude):
- (WebCore::Geoposition::accuracy):
- (WebCore::Geoposition::altitudeAccuracy):
- (WebCore::Geoposition::heading):
- (WebCore::Geoposition::velocity):
- (WebCore::Geoposition::timestamp):
- (WebCore::Geoposition::Geoposition):
- * page/Geoposition.idl: Added.
- * page/Navigator.cpp:
- (WebCore::Navigator::disconnectFrame): disconnect Geolocation
- (WebCore::Navigator::geolocation): accessor for Geolocation
- * page/Navigator.h:
- (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
- * page/Navigator.idl: accessor for Geolocation
- * page/PositionCallback.h: Added.
- (WebCore::PositionCallback::~PositionCallback):
- * page/PositionCallback.idl: Added.
- * page/PositionError.h: Added.
- (WebCore::PositionError::):
- (WebCore::PositionError::create):
- (WebCore::PositionError::code):
- (WebCore::PositionError::message):
- (WebCore::PositionError::PositionError):
- * page/PositionError.idl: Added.
- * page/PositionErrorCallback.h: Added.
- (WebCore::PositionErrorCallback::~PositionErrorCallback):
- * page/PositionErrorCallback.idl: Added.
- * page/PositionOptions.h: Added.
- (WebCore::PositionOptions::create):
- (WebCore::PositionOptions::enableHighAccuracy):
- (WebCore::PositionOptions::setEnableHighAccuracy):
- (WebCore::PositionOptions::timeout):
- (WebCore::PositionOptions::setTimeout):
- (WebCore::PositionOptions::PositionOptions):
- * page/PositionOptions.idl: Added.
- * platform/GeolocationService.cpp: Added.
- (WebCore::GeolocationService::GeolocationService):
- (WebCore::GeolocationService::positionChanged):
- (WebCore::GeolocationService::errorOccurred):
- * platform/GeolocationService.h: Added.
- (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
- (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
- (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
- (WebCore::GeolocationService::~GeolocationService):
-
-2008-10-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=21818
-
- Add HashTraits for AtomicString so that AtomicString can be used as
- the key for a HashMap or HashSet.
-
- * GNUmakefile.am: add AtomicStringHash.h
- * WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
- * WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
- * platform/text/AtomicString.h:
- (WebCore::AtomicString::AtomicString):
- (WebCore::AtomicString::isHashTableDeletedValue):
- specialize DefaultHash for AtomicString to use AtomicStringHash
- * platform/text/AtomicStringHash.h: Added.
* platform/text/StringImpl.cpp:
- (WebCore::StringImpl::StringImpl):
- compute the hash up-front for the empty string
- * platform/text/StringImpl.h:
- (WebCore::StringImpl::existingHash):
- method to get the hash without a test and branch, for callers like
- AtomicStringHash who can guarantee that the hash has already been computed.
-
-2008-10-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=21857
-
- Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
- switch in _wrapCSSRule.
+ (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a
+ static method.
+ (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
- * bindings/objc/DOMCSS.mm:
- (+[DOMCSSRule _wrapCSSRule:WebCore::]):
+2009-06-22 Xiaomei Ji <xji@chromium.org>
-2008-10-24 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * plugins/PluginView.cpp:
-
-2008-10-24 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
+ Reviewed by Eric Seidel
- - fix https://bugs.webkit.org/show_bug.cgi?id=21851
- <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height
+ Not auto-testable since it involves sending a keyboard event to
+ the popup, which is not possible (eventSender sends the key
+ events through webview, we want to go through the webwidget).
- Test: fast/replaced/percent-height-in-anonymous-block-widget.html
+ This patch is one part of the fix for issue "keyboard selection in
+ Hebrew select element does not work in Windows". The other part of the
+ fix is in chromium's webkit/glue layer.
+ https://bugs.webkit.org/show_bug.cgi?id=25899
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::destroy): Copied code added to
- RenderBox::destroy() in r36513 into this function.
+ * manual-tests/keyboard_select_non_english.html: Added.
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::isCharacterTypeEvent): Added. Check whether the event is a
+ character type event. "Char" in Windows or "KeyDown" in Mac is character
+ type event.
+ (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to
+ indicate whether user types multiple characters continuely as a search
+ prefix or not, it should be only assigned when the event is character
+ type event.
-2008-10-24 Timothy Hatcher <timothy@apple.com>
+2009-06-22 Kevin McCullough <kmccullough@apple.com>
- Add a mechanism to ask the InspectorClient for key/value setting pairs.
- These settings can be strings, numbers, booleans or string vectors. The
- settings are also bridged to and from JavaScript.
+ Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=21856
+ <rdar://problem/6115819> Notify of profile start in console
- Reviewed by Darin Adler.
+ Put a message in the console that announces that a profile has started,
+ similar to how a console message announces that a profile has finished.
- * WebCore.base.exp: Expose the String CFStringRef constructor.
- * inspector/InspectorClient.h:
- (WebCore::InspectorClient::populateSetting): Added, pure virtual.
- (WebCore::InspectorClient::storeSetting): Ditto.
- (WebCore::InspectorClient::removeSetting): Ditto.
* inspector/InspectorController.cpp:
- (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
- (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
- (WebCore::InspectorController::InspectorController): Increment a global static
- to track the number of live InspectorControllers.
- (WebCore::InspectorController::~InspectorController): Decrement the global static
- that tracks the number of live InspectorControllers. Delete the setting cache if there
- are no more live controllers.
- (WebCore::InspectorController::setting): Check the cache and return the setting from there,
- otherwise make a new Setting and ask the client to populate it.
- (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
- (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
- to the InspectorController script class.
+ (WebCore::InspectorController::addProfile): Use renamed function.
+ (WebCore::InspectorController::addProfileFinishedMessageToConsole):
+ Renamed.
+ (WebCore::InspectorController::addStartProfilingMessageToConsole):
+ New function that logs the message about the profile starting.
+ (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
* inspector/InspectorController.h:
- (WebCore::InspectorController::Setting::Setting):
- (WebCore::InspectorController::Setting::operator=):
- (WebCore::InspectorController::Setting::type): Return m_type.
- (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
- (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
- Assert the type is correct.
- (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
- Assert the type is correct.
- (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
- Assert the type is correct.
- (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
- Assert the type is correct.
- (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
- field and the type.
- * loader/EmptyClients.h:
- (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
- (WebCore::EmptyInspectorClient::storeSetting): Ditto.
- (WebCore::EmptyInspectorClient::removeSetting): Ditto.
-
-2008-10-24 Cameron Zwarich <zwarich@apple.com>
-
- Reviewed by Sam Weinig.
-
- Remove some C-style casts.
-
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::addViewSourceToken):
-
-2008-10-24 Darin Adler <darin@apple.com>
-
- - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
-
- * bindings/js/JSAttrCustom.cpp:
- * bindings/js/JSCSSRuleCustom.cpp:
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- * bindings/js/JSCSSValueCustom.cpp:
- * bindings/js/JSCanvasPixelArrayCustom.h:
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- * bindings/js/JSClipboardCustom.cpp:
- * bindings/js/JSConsoleCustom.cpp:
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- * bindings/js/JSCustomVoidCallback.cpp:
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- * bindings/js/JSCustomXPathNSResolver.h:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- * bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- * bindings/js/JSDOMWindowCustom.h:
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSDOMWindowShell.h:
- * bindings/js/JSDatabaseCustom.cpp:
- * bindings/js/JSDedicatedWorkerCustom.cpp:
- * bindings/js/JSDocumentCustom.cpp:
- * bindings/js/JSElementCustom.cpp:
- * bindings/js/JSEventCustom.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventTarget.cpp:
- * bindings/js/JSEventTarget.h:
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetNodeCustom.cpp:
- * bindings/js/JSHTMLAllCollection.h:
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- * bindings/js/JSHTMLCollectionCustom.cpp:
- * bindings/js/JSHTMLDocumentCustom.cpp:
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- * bindings/js/JSHTMLFormElementCustom.cpp:
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- * bindings/js/JSHTMLInputElementCustom.cpp:
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- * bindings/js/JSHTMLSelectElementCustom.h:
- * bindings/js/JSHistoryCustom.cpp:
- * bindings/js/JSImageDataCustom.cpp:
- * bindings/js/JSInspectedObjectWrapper.cpp:
- * bindings/js/JSInspectedObjectWrapper.h:
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- * bindings/js/JSInspectorCallbackWrapper.h:
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- * bindings/js/JSLocationCustom.cpp:
- * bindings/js/JSMessagePortCustom.cpp:
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- * bindings/js/JSNamedNodeMapCustom.cpp:
- * bindings/js/JSNamedNodesCollection.cpp:
- * bindings/js/JSNamedNodesCollection.h:
- * bindings/js/JSNavigatorCustom.cpp:
- * bindings/js/JSNodeCustom.cpp:
- * bindings/js/JSNodeFilterCondition.cpp:
- * bindings/js/JSNodeFilterCondition.h:
- * bindings/js/JSNodeFilterCustom.cpp:
- * bindings/js/JSNodeIteratorCustom.cpp:
- * bindings/js/JSNodeListCustom.cpp:
- * bindings/js/JSPluginArrayCustom.cpp:
- * bindings/js/JSPluginCustom.cpp:
- * bindings/js/JSPluginElementFunctions.cpp:
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- * bindings/js/JSQuarantinedObjectWrapper.h:
- * bindings/js/JSRGBColor.cpp:
- * bindings/js/JSRGBColor.h:
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- * bindings/js/JSSQLTransactionCustom.cpp:
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- * bindings/js/JSSVGLengthCustom.cpp:
- * bindings/js/JSSVGMatrixCustom.cpp:
- * bindings/js/JSSVGPathSegCustom.cpp:
- * bindings/js/JSSVGPathSegListCustom.cpp:
- * bindings/js/JSSVGPointListCustom.cpp:
- * bindings/js/JSSVGTransformListCustom.cpp:
- * bindings/js/JSStorageCustom.cpp:
- * bindings/js/JSStyleSheetCustom.cpp:
- * bindings/js/JSStyleSheetListCustom.cpp:
- * bindings/js/JSTextCustom.cpp:
- * bindings/js/JSTreeWalkerCustom.cpp:
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- * bindings/js/JSXSLTProcessorCustom.cpp:
- * bindings/js/ScheduledAction.cpp:
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptController.h:
- * bindings/objc/WebScriptObject.mm:
- * bindings/objc/WebScriptObjectPrivate.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- * bridge/c/c_instance.cpp:
- * bridge/c/c_instance.h:
- * bridge/c/c_runtime.cpp:
- * bridge/c/c_runtime.h:
- * bridge/c/c_utility.cpp:
- * bridge/c/c_utility.h:
- * bridge/jni/jni_instance.cpp:
- * bridge/jni/jni_instance.h:
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- * bridge/jni/jni_objc.mm:
- * bridge/jni/jni_runtime.cpp:
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- * bridge/jni/jni_utility.h:
- * bridge/objc/WebScriptObject.h:
- * bridge/objc/objc_class.h:
- * bridge/objc/objc_class.mm:
- * bridge/objc/objc_instance.h:
- * bridge/objc/objc_instance.mm:
- * bridge/objc/objc_runtime.h:
- * bridge/objc/objc_runtime.mm:
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- * bridge/qt/qt_class.cpp:
- * bridge/qt/qt_class.h:
- * bridge/qt/qt_instance.cpp:
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- * bridge/qt/qt_runtime.h:
- * bridge/runtime.cpp:
- * bridge/runtime.h:
- * bridge/runtime_array.cpp:
- * bridge/runtime_array.h:
- * bridge/runtime_method.cpp:
- * bridge/runtime_method.h:
- * bridge/runtime_object.cpp:
- * bridge/runtime_object.h:
- * bridge/testqtbindings.cpp:
- * inspector/JavaScriptCallFrame.cpp:
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptProfile.cpp:
- * inspector/JavaScriptProfile.h:
- * inspector/JavaScriptProfileNode.cpp:
- * inspector/JavaScriptProfileNode.h:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
+ * inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's
+ title if there are multiple profiles, and take into account the fact
+ that titles are displayed twice as much now.
+ (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
* page/Console.cpp:
- * page/Console.h:
- * plugins/MimeTypeArray.h:
- * plugins/Plugin.h:
- * plugins/PluginArray.h:
- * plugins/PluginView.cpp:
- * xml/XMLHttpRequest.cpp:
- Use JSValue* instead of JSValuePtr.
-
-2008-10-24 Simon Hausmann <hausmann@webkit.org>
-
- Fix the Qt build.
+ (WebCore::Console::profile): Call new function.
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtField::valueFromInstance):
-
-2008-10-24 David Kilzer <ddkilzer@apple.com>
-
- Rolled out r37840 and r37841.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSCustomPositionCallback.cpp: Removed.
- * bindings/js/JSCustomPositionCallback.h: Removed.
- * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
- * bindings/js/JSCustomPositionErrorCallback.h: Removed.
- * bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::markDOMObjectWrapper):
- * bindings/js/JSGeolocationCustom.cpp: Removed.
- * bindings/js/JSNavigatorCustom.cpp:
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::canCachePage):
- * page/Geolocation.cpp: Removed.
- * page/Geolocation.h: Removed.
- * page/Geolocation.idl: Removed.
- * page/Geoposition.cpp: Removed.
- * page/Geoposition.h: Removed.
- * page/Geoposition.idl: Removed.
- * page/Navigator.cpp:
- (WebCore::Navigator::disconnectFrame):
- * page/Navigator.h:
- * page/Navigator.idl:
- * page/PositionCallback.h: Removed.
- * page/PositionCallback.idl: Removed.
- * page/PositionError.h: Removed.
- * page/PositionError.idl: Removed.
- * page/PositionErrorCallback.h: Removed.
- * page/PositionErrorCallback.idl: Removed.
- * page/PositionOptions.h: Removed.
- * page/PositionOptions.idl: Removed.
- * platform/GeolocationService.cpp: Removed.
- * platform/GeolocationService.h: Removed.
-
-2008-10-23 David Kilzer <ddkilzer@apple.com>
-
- Attempt to fix GTK build.
-
- * GNUmakefile.am: Added new *.idl files that were missing.
-
-2008-10-23 Greg Bolsinga <bolsinga@apple.com>
+2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21475
+ https://bugs.webkit.org/show_bug.cgi?id=26615
- Provide support for the Geolocation API
+ Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
+ correspond to ones you find on <select> elements.
- http://dev.w3.org/geo/api/spec-source.html
-
- Test: geolocation/geolocation-not-implemented.html
+ Add an expanded property to row elements.
+ * DerivedSources.cpp:
* DerivedSources.make:
- * GNUmakefile.am: Added Geolocation support
- * WebCore.pro: Added Geolocation support
- * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
- * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
- * WebCoreSources.bkl: Added Geolocation support
- * bindings/js/JSCustomPositionCallback.cpp: Added.
- (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
- (WebCore::JSCustomPositionCallback::handleEvent):
- * bindings/js/JSCustomPositionCallback.h: Added.
- (WebCore::JSCustomPositionCallback::create):
- * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
- (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
- (WebCore::JSCustomPositionErrorCallback::handleEvent):
- * bindings/js/JSCustomPositionErrorCallback.h: Added.
- (WebCore::JSCustomPositionErrorCallback::create):
- * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
- (WebCore::markDOMObjectWrapper):
- * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
- * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
- * bindings/js/JSGeolocationCustom.cpp: Added.
- (WebCore::JSGeolocation::getCurrentPosition):
- (WebCore::JSGeolocation::watchPosition):
- * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
- (WebCore::JSNavigator::mark):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- (WebCore::Document::setUsingGeolocation):
- (WebCore::Document::usingGeolocation):
- * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
- (WebCore::FrameLoader::canCachePage):
- * page/Geolocation.cpp: Added.
- (WebCore::Geolocation::GeoNotifier::GeoNotifier):
- (WebCore::Geolocation::GeoNotifier::timerFired):
- (WebCore::Geolocation::Geolocation):
- (WebCore::Geolocation::disconnectFrame):
- (WebCore::Geolocation::getCurrentPosition):
- (WebCore::Geolocation::watchPosition):
- (WebCore::Geolocation::clearWatch):
- (WebCore::Geolocation::stopUpdatingIfEmpty):
- (WebCore::Geolocation::sendErrorToOneShots):
- (WebCore::Geolocation::sendErrorToWatchers):
- (WebCore::Geolocation::sendPositionToOneShots):
- (WebCore::Geolocation::sendPositionToWatchers):
- (WebCore::Geolocation::handleError):
- (WebCore::Geolocation::geolocationServicePositionChanged):
- (WebCore::Geolocation::geolocationServiceErrorOccurred):
- * page/Geolocation.h: Added.
- (WebCore::Geolocation::create):
- (WebCore::Geolocation::~Geolocation):
- (WebCore::Geolocation::lastPosition):
- (WebCore::Geolocation::GeoNotifier::create):
- * page/Geolocation.idl: Added.
- * page/Geoposition.cpp: Added.
- (WebCore::Geoposition::toString):
- * page/Geoposition.h: Added.
- (WebCore::Geoposition::create):
- (WebCore::Geoposition::latitude):
- (WebCore::Geoposition::longitude):
- (WebCore::Geoposition::altitude):
- (WebCore::Geoposition::accuracy):
- (WebCore::Geoposition::altitudeAccuracy):
- (WebCore::Geoposition::heading):
- (WebCore::Geoposition::velocity):
- (WebCore::Geoposition::timestamp):
- (WebCore::Geoposition::Geoposition):
- * page/Geoposition.idl: Added.
- * page/Navigator.cpp:
- (WebCore::Navigator::disconnectFrame): disconnect Geolocation
- (WebCore::Navigator::geolocation): accessor for Geolocation
- * page/Navigator.h:
- (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
- * page/Navigator.idl: accessor for Geolocation
- * page/PositionCallback.h: Added.
- (WebCore::PositionCallback::~PositionCallback):
- * page/PositionCallback.idl: Added.
- * page/PositionError.h: Added.
- (WebCore::PositionError::):
- (WebCore::PositionError::create):
- (WebCore::PositionError::code):
- (WebCore::PositionError::message):
- (WebCore::PositionError::PositionError):
- * page/PositionError.idl: Added.
- * page/PositionErrorCallback.h: Added.
- (WebCore::PositionErrorCallback::~PositionErrorCallback):
- * page/PositionErrorCallback.idl: Added.
- * page/PositionOptions.h: Added.
- (WebCore::PositionOptions::create):
- (WebCore::PositionOptions::enableHighAccuracy):
- (WebCore::PositionOptions::setEnableHighAccuracy):
- (WebCore::PositionOptions::timeout):
- (WebCore::PositionOptions::setTimeout):
- (WebCore::PositionOptions::PositionOptions):
- * page/PositionOptions.idl: Added.
- * platform/GeolocationService.cpp: Added.
- (WebCore::GeolocationService::GeolocationService):
- (WebCore::GeolocationService::positionChanged):
- (WebCore::GeolocationService::errorOccurred):
- * platform/GeolocationService.h: Added.
- (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
- (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
- (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
- (WebCore::GeolocationService::~GeolocationService):
-
-2008-10-23 Alp Toker <alp@nuanti.com>
-
- Fix typo in comment in previous commit. GTK -> GLIB
-
- * platform/gtk/guriescape.c:
-
-2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=21824
- [GTK] FileSystem abstraction uses features from Glib 2.16
-
- Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib
-
- * platform/gtk/guriescape.c:
- (unescape_character):
- (_webcore_g_uri_unescape_segment):
- (_webcore_g_uri_unescape_string):
- * platform/gtk/guriescape.h:
-
-2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.
-
- * GNUmakefile.am:
-
-2008-10-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- m_frame null checked but then dereferenced
- https://bugs.webkit.org/show_bug.cgi?id=21845
-
- This error was found using a static analysis tool, and so I do not know
- how to produce a null m_frame on entry to this method. Hence, I have
- not included a regression test.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::allowDHTMLDrag): Add an early return.
-
-2008-10-23 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig with no hesitation.
-
- - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
- <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
-
- Test: fast/text/bidi-embedding-pop-and-push-same.html
-
- * platform/text/BidiResolver.h:
- (WebCore::BidiResolver::embed): Changed to only add the embedding
- operation to a vector of pending operations.
-
- (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
- code that used to be in the PDF case of embed() here, except the part
- that sets the context.
-
- (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
- code that used to be in the non-PDF case of embed() here, except the
- part the sets the context.
-
- (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
- explicit embedding operations in the vector by creating an updated
- context and determining the old and new embedding levels. If the levels
- are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
- sets the context to the new one.
-
- (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
- commitExplicitEmbedding() after calling embed() and after calling
- increment().
-
- * rendering/bidi.cpp:
- (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
- this function increments the resolver.
-
- (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
-
-2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix. Not reviewed.
-
- Add DNSCurl and DNSSoup to the Gtk build
-
- * GNUmakefile.am:
- * platform/gtk/TemporaryLinkStubs.cpp:
- * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
- (WebCore::prefetchDNS):
-
-2008-10-23 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Un-break the Darwin build.
-
- * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- * platform/graphics/cg/ImageCG.cpp:
-
-2008-10-23 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- Fix forward decls to be struct instead of class.
- https://bugs.webkit.org/show_bug.cgi?id=21838
-
- * rendering/style/StyleRareInheritedData.h:
- * rendering/style/StyleRareNonInheritedData.h:
-
-2008-10-23 Brent Fulgham <bfulgham@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- * platform/network/curl/ResourceRequest.h: A better implementation
- of CFURLRequest, rather than void*. This gives better compatibility
- with the WebKit.idl interface.
- (WebCore::ResourceRequest::cfURLRequest):
-
-2008-10-23 Mike Pinkerton <pinkerton@chromium.org>
-
- Reviewed by Eric Seidel.
-
- PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
- ifdefs to reflect that.
-
- * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- * platform/graphics/cg/ImageCG.cpp:
-
-2008-10-23 Peter Kasting <pkasting@google.com>
-
- Reviewed by Adam Roben.
-
- https://bugs.webkit.org/show_bug.cgi?id=21833
- Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::windowScriptObjectAvailable):
- (WebCore::InspectorController::close):
- * inspector/InspectorController.h:
- * page/Page.cpp:
- (WebCore::Page::Page):
-
-2008-10-23 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=21817
- Bug 21817: Manual profiler tests should be made into layout tests
-
- -Moving the tests before diffing so that it's clear what changed.
-
- * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
- * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
- * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
- * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
- * manual-tests/inspector/profiler-test-apply.html: Removed.
- * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
- * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
- * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
- * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
- * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
- * manual-tests/inspector/profiler-test-constructor.html: Removed.
- * manual-tests/inspector/profiler-test-dead-time.html: Removed.
- * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
- * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
- * manual-tests/inspector/profiler-test-event-handler.html: Removed.
- * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
- * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
- * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
- * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
- * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
- * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
- * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
- * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
- * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
- * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
- * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
- * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
- * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
- * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
- * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
- * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
- * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
- * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
- * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
- * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
- * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
- * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
- * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
- * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
- * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
- * manual-tests/inspector/resources/other-frame.html: Removed.
- * manual-tests/inspector/resources/other-window.html: Removed.
- * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
-
-2008-10-23 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21826
-
- Add accessor for SecurityOrigin::m_domainWasSetInDOM.
-
- * page/SecurityOrigin.h:
- (WebCore::SecurityOrigin::domainWasSetInDOM):
-
-2008-10-23 Darin Adler <darin@apple.com>
-
- - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
-
- * bindings/js/ScheduledAction.h:
- * inspector/InspectorController.cpp:
- ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
-
-2008-10-23 Simon Hausmann <hausmann@webkit.org>
-
- Fix the Qt build.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtConnectionObject::execute):
- * bridge/qt/qt_runtime.h:
- (JSC::Bindings::QtRuntimeMethod::createStructureID):
-
-2008-10-23 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=21825
- JSDOMBinding should not blindly cast the global object to JSDOMWindow
-
- * bindings/js/JSDOMGlobalObject.cpp:
- * bindings/js/JSDOMGlobalObject.h:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::getCachedDOMStructure):
- (WebCore::cacheDOMStructure):
- (WebCore::getCachedDOMConstructor):
- (WebCore::cacheDOMConstructor):
- Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBase):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::mark):
- Moved constructor and structure tracking to JSDOMGlobalObject.
-
-2008-10-23 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21787
-
- Update postMessage to send origin = "null" for non-serializable
- origins to match latest spec. Merge SecurityOrigin::toString and
- SecurityOrigin::toHTTPOrigin because they are now the same.
-
- Test: http/tests/security/postMessage/data-url-sends-null-origin.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::outgoingOrigin):
- (WebCore::FrameLoader::loadURL):
- (WebCore::FrameLoader::addHTTPOriginIfNeeded):
- (WebCore::FrameLoader::loadItem):
- * loader/loader.cpp:
- (WebCore::Loader::Host::servePendingRequests):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::toString):
- * page/SecurityOrigin.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
-
-2008-10-22 David Kilzer <ddkilzer@apple.com>
-
- Bug 21781: WebCore::Settings should have a maximum decoded image size setting
-
- <https://bugs.webkit.org/show_bug.cgi?id=21781>
-
- Reviewed by Antti.
-
- No tests since there is no change in behavior.
-
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::maximumDecodedImageSize): Added. Returns
- WebCore::Settings::maximumDecodedImageSize() or 0 on error.
- (WebCore::CachedImage::data): Flag an error if the image being
- loaded is too big.
- * loader/CachedImage.h:
- (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
- * page/Settings.cpp:
- (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
- to the maximum value of size_t.
- * page/Settings.h:
- (WebCore::Settings::setMaximumDecodedImageSize): Added method.
- (WebCore::Settings::maximumDecodedImageSize): Ditto.
-
-2008-10-22 Mike Pinkerton <pinkerton@chromium.org>
-
- Reviewed by Dan Bernstein.
- Landed and tweaked a bit by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21809
-
- Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
- its use for PLATFORM(CHROMIUM) in the future.
-
- * platform/graphics/SimpleFontData.h:
-
-2008-10-22 David Smith <catfish.man@gmail.com>
-
- Reviewed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=19974
- getElementsByClassName not live enough
-
- Test: fast/dom/getElementsByClassName/015.html
-
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()
-
-2008-10-22 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21294
- Bug 21294: Devirtualize getOwnPropertySlot()
-
- * bindings/js/JSDOMWindowShell.h:
- (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
-
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
- for this class rather than sharing nullProtoStructureID, which no longer exists.
-
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
- HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::createStructureID): Ditto.
-
- * bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
- constructors, and prototypes in any case where they override getOwnPropertySlot, without
- HasStandardGetOwnPropertySlot.
-
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
- without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
- * bridge/qt/qt_runtime.h:
- (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::createStructureID): Ditto.
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createStructureID): Ditto.
- * bridge/runtime_object.h:
- (JSC::RuntimeObjectImp::createStructureID): Ditto.
-
-2008-10-22 Brent Fulgham <bfulgham@gmail.com>
-
- Bring Windows Cairo Port's font handling in line with CG.
- http://bugs.webkit.org/show_bug.cgi?id=21812.
-
- Reviewed by Adam Roben.
-
- * platform/graphics/win/FontCacheWin.cpp:
- (WebCore::createGDIFont): Remove unnecessary special-case for Cairo
- TrueType font search. It should match CG in all font selections.
-
-2008-10-22 Brent Fulgham <bfulgham@gmail.com>
-
- http://bugs.webkit.org/show_bug.cgi?id=21812.
- Bring Windows Cairo Port's font handling in line with CG.
-
- Reviewed by David Hyatt.
-
- * platform/graphics/win/FontCacheWin.cpp:
- (WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.
-
-2008-10-22 Brady Eidson <beidson@apple.com>
-
- Reviewed by Adam Roben
-
- <rdar://6261773> - autocomplete="off" doesn't work on Windows
-
- Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
- statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
- instead of the much more correct "true."
-
- In the past we have worked around this by declaring the bitfield member as an unsigned instead
- of the enum type.
-
- For more discussion, see http://trac.webkit.org/changeset/25329
-
- * html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*
-
-2008-10-22 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Oliver Hunt and Tim Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=19225
- Bug 19225: JSProfiler: Create automated profiler tests
- - This change exports profiles on the console object so that they can be
- iterated over via JavaScript, and thus can be used in automated tests.
-
- * bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
- that JS can use.
- (WebCore::JSConsole::profiles):
- * inspector/InspectorController.h: Use the new typedef.
- (WebCore::InspectorController::profiles):
- * page/Console.cpp: Keep our own array of profile objects.
- (WebCore::Console::profileEnd):
- * page/Console.h: Ditto.
- (WebCore::Console::profiles):
- * page/Console.idl: Expose the profiles to JS.
-
-2008-10-22 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21775
-
- Convert buttons over to use the new Theme API on OS X.
-
- Reviewed by Adam Roben
-
- * platform/LengthBox.h:
- (WebCore::LengthBox::LengthBox):
- * platform/Theme.cpp:
- (WebCore::Theme::controlBorder):
- (WebCore::Theme::controlPadding):
- * platform/Theme.h:
- (WebCore::Theme::controlFont):
- (WebCore::Theme::controlSize):
- (WebCore::Theme::minControlSize):
- (WebCore::Theme::controlRequiresPreWhiteSpace):
- * platform/mac/ThemeMac.h:
- (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
- * platform/mac/ThemeMac.mm:
- (WebCore::checkboxSize):
- (WebCore::radioSize):
- (WebCore::buttonSizes):
- (WebCore::buttonMargins):
- (WebCore::button):
- (WebCore::paintButton):
- (WebCore::ThemeMac::controlFont):
- (WebCore::ThemeMac::controlSize):
- (WebCore::ThemeMac::minControlSize):
- (WebCore::ThemeMac::controlBorder):
- (WebCore::ThemeMac::controlPadding):
- (WebCore::ThemeMac::inflateControlPaintRect):
- (WebCore::ThemeMac::paint):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::adjustStyle):
- (WebCore::RenderTheme::paint):
- (WebCore::RenderTheme::controlStatesForRenderer):
- (WebCore::RenderTheme::isDefault):
- (WebCore::RenderTheme::adjustRadioStyle):
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::setRadioSize):
- * rendering/RenderThemeMac.h:
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustRepaintRect):
- (WebCore::menuListButtonSizes):
- (WebCore::RenderThemeMac::adjustMenuListStyle):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::paddingBox):
- (WebCore::InheritedFlags::setPaddingBox):
-
-2008-10-22 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt
-
- Make sure that the AtomicString that identifies a set of animation keyframes
- stays live by keeping a copy in the WebKitCSSKeyframesRule.
-
- Also call styleSheetChanged() when the keyframes name changes, but
- add an internal method that doesn't call styleSheetChanged() for use
- during normal stylesheet parsing.
-
- Test: animations/change-keyframes-name.html
-
- * css/CSSGrammar.y:
- * css/WebKitCSSKeyframesRule.cpp:
- (WebCore::WebKitCSSKeyframesRule::setName):
- * css/WebKitCSSKeyframesRule.h:
- (WebCore::WebKitCSSKeyframesRule::setNameInternal):
-
-2008-10-22 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21791
- WebCore JS bindings should be able to use non-static hash tables for properties
-
- Add a map for HashTables to WebCore JS client data.
-
- This makes property access noticeably slower, so it is an opt-in. For classes that need to be
- supported in workers in forseeable future this is not critical.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::DOMObjectHashTableMap::get):
- (WebCore::DOMObjectHashTableMap::mapFor):
- (WebCore::getHashTableForGlobalData):
- (WebCore::DOMObjectWrapperMap::mapFor):
- WebCore client data is now a class that contains both a DOM wrapper map and a property hash
- table one.
-
- * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.
-
- * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
- JSDOMBinding map to access its property hash tables.
-
- * dom/MessageChannel.idl:
- * dom/MessagePort.idl:
- Added NoStaticTables attribute.
-
-2008-10-22 Gustavo Noronha Silva <gns@gnome.org>
-
- Reviewed by Timothy Hatcher.
-
- Build failure because of missing include
- https://bugs.webkit.org/show_bug.cgi?id=21765
-
- Build failure fix for WebKit/GTK+; added missing
- include (GOwnPtr.h)
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
-
-2008-10-22 Alp Toker <alp@nuanti.com>
-
- Reviewed by Adam Roben.
-
- Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
- doesn't initialize values if the requested property doesn't exist, so
- initialize the values to the documented defaults before calling it
- where necessary. Additionally, avoid critical warnings by not calling
- gtk_widget_style_get() when we know the property isn't available.
-
- Note that this is an imported source file which doesn't follow the
- WebKit coding style.
-
- * platform/gtk/gtk2drawing.c:
- (moz_gtk_init):
- (moz_gtk_button_get_inner_border):
- (moz_gtk_combo_box_paint):
- (moz_gtk_toolbar_separator_paint):
- (moz_gtk_menu_separator_paint):
- (moz_gtk_get_widget_border):
- (moz_gtk_get_tab_scroll_arrow_size):
- (moz_gtk_get_toolbar_separator_width):
- (moz_gtk_get_menu_separator_height):
-
-2008-10-22 Alp Toker <alp@nuanti.com>
-
- Fix build for Cairo 1.2.
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::clipOut):
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::paintMozWidget):
-
-2008-10-22 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- A little more PLATFORM(CHROMIUM) in WebCore
- https://bugs.webkit.org/show_bug.cgi?id=21758
-
- * page/AccessibilityObject.h:
- * platform/graphics/Icon.h:
-
-2008-10-21 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- Test: fast/events/message-channel-gc-3.html
-
- https://bugs.webkit.org/show_bug.cgi?id=21769
- MessagePort should be GC protected if there are messages to be delivered
-
- * dom/MessagePort.h: Removed pending activity count. Now we track if a close event is
- pending, and check if the queue is non-empty.
- (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug
- fix (below).
-
- * dom/MessagePort.cpp:
- (WebCore::CloseMessagePortTimer::fired):
- (WebCore::MessagePort::MessagePort):
- (WebCore::MessagePort::queueCloseEvent):
- (WebCore::MessagePort::dispatchCloseEvent):
- (WebCore::MessagePort::hasPendingActivity):
- Track message and close event activity separately.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was
- causing same-heap ports to never be deleted.
-
-2008-10-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - remove unreachable code
-
- * platform/text/BidiResolver.h:
- (WebCore::::embed):
-
-2008-10-21 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
- REGRESSION(r31030-31055): Choosing "Print window" from frame set
- prints blank page
- and corresponding: <rdar://problem/6142398>
-
- viewHeight() and viewWidth() only return valuable information if we
- are not printing. Everywhere else in the code, we make sure we are
- not printing before we call these functions. Adding a check for
- printing here fixes this bug, and framesets print again.
-
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::layout):
-
-2008-10-21 Yael Aharon <yael.aharon@nokia.com>
-
- Reviewed by Simon.
-
- Pixmap in canvas tag was not getting initialized.
-
- See https://bugs.webkit.org/show_bug.cgi?id=21771
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::create):
-
-2008-10-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- Add a comment explaining layoutDelta(), and an assertion
- that checks that delta changes were correctly paired during layout.
-
- * rendering/RenderView.cpp:
- (WebCore::RenderView::layout):
- * rendering/RenderView.h:
-
-2008-10-20 Timothy Hatcher <timothy@apple.com>
-
- Make auto-complete only suggest properties that are valid syntax
- when using dot-notation. Also when completing numeric properties,
- the quotes are omitted inside the brackets.
-
- https://bugs.webkit.org/show_bug.cgi?id=21760
- https://bugs.webkit.org/show_bug.cgi?id=21761
-
- Reviewed by Oliver Hunt.
-
- * inspector/front-end/Console.js:
- (WebInspector.Console.prototype.completions): Skip properties that
- are not valid identifies when using dot-notation. And omit the quotes
- when completing numbers in bracket-notation.
-
-2008-10-20 Timothy Hatcher <timothy@apple.com>
-
- Fixes the Profiles panel in the Web Inspector, which was broken by
- the JSValue base-class changes. Also renames some functions and
- variables in JavaScriptProfileNode.cpp that where title case.
-
- https://bugs.webkit.org/show_bug.cgi?id=21764
-
- Reviewed by Oliver Hunt.
-
- * inspector/JavaScriptProfile.cpp:
- (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the
- returned JSValuePtr will be treated as an object and not a value.
- * inspector/JavaScriptProfileNode.cpp:
- (WebCore::toJS): Ditto.
-
-2008-10-20 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::detachFromParent):
- * loader/FrameLoaderClient.h:
-
-2008-10-20 Antti Koivisto <antti@apple.com>
-
- Reviewed by Adele Peterson.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=21763
- REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
- <rdar://problem/6285025
-
- If we get 304 response we need to explicitly check if that completes the frame load.
-
- No test case, simulating the condition is pretty difficult.
-
- * loader/loader.cpp:
- (WebCore::Loader::Host::didReceiveResponse):
-
-2008-10-20 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Mark Rowe.
-
- Work around <rdar://problem/6301728>.
-
- Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.
-
- * loader/MainResourceLoader.cpp:
- (WebCore::MainResourceLoader::didReceiveResponse):
- (WebCore::MainResourceLoader::didReceiveData):
- (WebCore::MainResourceLoader::didFinishLoading):
- (WebCore::MainResourceLoader::didFail):
-
-2008-10-20 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Adele Peterson.
-
- Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
- crashes in Safari at com.apple.WebCore
- WebCore::ScrollView::visibleContentRect const + 153
-
- d->m_view can be null and is null-checked at other points in the
- code. The logs indicate that this crash occurs when closing a
- window containing a PDF, so in case where we crash, the PDF's view
- is probably already null. So the fix is to simply add a null-check.
-
- * page/Frame.cpp:
- (WebCore::Frame::selectionRect):
-
-2008-10-20 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
- Removed stray increment that would screw up any form with multiple files in it.
-
-2008-10-20 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by David Hyatt.
-
- Split LengthBox and LengthSize into their own files.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/Length.h:
- (WebCore::Length::blend):
- * platform/LengthBox.h: Copied from platform/Length.h.
- (WebCore::LengthBox::LengthBox):
- (WebCore::LengthBox::nonZero):
- * platform/LengthSize.h: Copied from platform/Length.h.
- (WebCore::LengthSize::LengthSize):
- (WebCore::LengthSize::setWidth):
- (WebCore::LengthSize::setHeight):
- (WebCore::LengthSize::height):
- * platform/Theme.h:
- * rendering/style/FillLayer.h:
- * rendering/style/NinePieceImage.h:
- (WebCore::NinePieceImage::NinePieceImage):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleDashboardRegion.h:
- * rendering/style/StyleSurroundData.h:
- * rendering/style/StyleVisualData.h:
-
-2008-10-20 Dan Bernstein <mitz@apple.com>
-
- - Mac build fix
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Fix autotools dist build target by listing recently added header
- files only. Not reviewed.
-
- * GNUmakefile.am:
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
- refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
- originally.
-
- ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.
-
- Reviewed by Adam Roben
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/Theme.cpp: Added.
- (WebCore::Theme::controlSupportsBorder):
- (WebCore::Theme::controlSupportsPadding):
- * platform/Theme.h:
- * platform/mac/ThemeMac.h:
- * platform/mac/ThemeMac.mm:
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::adjustStyle):
- * rendering/RenderTheme.h:
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- Rename LengthBox's members to have m_ in front of them.
-
- Reviewed by Sam Weinig
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::valueForNinePieceImage):
- (WebCore::getPositionOffsetValue):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapNinePieceImage):
- * platform/Length.h:
- (WebCore::LengthBox::LengthBox):
- (WebCore::LengthBox::left):
- (WebCore::LengthBox::right):
- (WebCore::LengthBox::top):
- (WebCore::LengthBox::bottom):
- (WebCore::LengthBox::operator==):
- (WebCore::LengthBox::nonZero):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::paintNinePieceImage):
- (WebCore::RenderObject::addDashboardRegions):
- * rendering/style/RenderStyle.cpp:
- (WebCore::positionedObjectMoved):
- (WebCore::RenderStyle::setClip):
- (WebCore::RenderStyle::noneDashboardRegions):
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::left):
- (WebCore::InheritedFlags::right):
- (WebCore::InheritedFlags::top):
- (WebCore::InheritedFlags::bottom):
- (WebCore::InheritedFlags::clipLeft):
- (WebCore::InheritedFlags::clipRight):
- (WebCore::InheritedFlags::clipTop):
- (WebCore::InheritedFlags::clipBottom):
- (WebCore::InheritedFlags::marginTop):
- (WebCore::InheritedFlags::marginBottom):
- (WebCore::InheritedFlags::marginLeft):
- (WebCore::InheritedFlags::marginRight):
- (WebCore::InheritedFlags::paddingTop):
- (WebCore::InheritedFlags::paddingBottom):
- (WebCore::InheritedFlags::paddingLeft):
- (WebCore::InheritedFlags::paddingRight):
- (WebCore::InheritedFlags::setLeft):
- (WebCore::InheritedFlags::setRight):
- (WebCore::InheritedFlags::setTop):
- (WebCore::InheritedFlags::setBottom):
- (WebCore::InheritedFlags::setDashboardRegion):
- (WebCore::InheritedFlags::setClipLeft):
- (WebCore::InheritedFlags::setClipRight):
- (WebCore::InheritedFlags::setClipTop):
- (WebCore::InheritedFlags::setClipBottom):
- (WebCore::InheritedFlags::setMarginTop):
- (WebCore::InheritedFlags::setMarginBottom):
- (WebCore::InheritedFlags::setMarginLeft):
- (WebCore::InheritedFlags::setMarginRight):
- (WebCore::InheritedFlags::setPaddingTop):
- (WebCore::InheritedFlags::setPaddingBottom):
- (WebCore::InheritedFlags::setPaddingLeft):
- (WebCore::InheritedFlags::setPaddingRight):
-
-2008-10-20 Timothy Hatcher <timothy@apple.com>
-
- Make the Resource panel perform graph updates atomically, so when resources
- are added the graph and summary graph update at the same time.
-
- https://bugs.webkit.org/show_bug.cgi?id=21755
-
- Reviewed by Kevin McCullough.
-
- * inspector/front-end/Resource.js:
- (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime
- property is undefined, null or 0. This allows callers to check for -1 and not
- the other values when there is no startTime yet.
- (WebInspector.Resource.prototype.get responseReceivedTime): Ditto.
- (WebInspector.Resource.prototype.get endTime): Ditto.
- (WebInspector.Resource.prototype.get duration): Remove an extra empty line.
- (WebInspector.Resource.prototype.get latency): Ditto.
- (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration
- property is undefined or null. This allows callers to always assume a number.
- (WebInspector.Resource.prototype.get expectedContentLength): Ditto.
- (WebInspector.Resource.prototype.get errors): Simplify the case where there is
- no _errors property yet.
- (WebInspector.Resource.prototype.set errors): Remove the check if the new value
- if the same as the previous value, since there is no work to guard.
- (WebInspector.Resource.prototype.get warnings): Simplify the case where there is
- no _warnings property yet.
- (WebInspector.Resource.prototype.set warnings): Remove the check if the new value
- if the same as the previous value, since there is no work to guard.
- (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the
- responseReceivedTime is -1.
- (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not
- have a _resourcesTreeElement yet, exclude it from the searchable views.
- (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources
- and call refresh to refresh the entire graph.
- (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel
- is visible that calls refresh.
- (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and
- graph for a resource if it hasn't been created yet. If the boundaries changed during
- the first stale resource pass, do a full pass of all resources when updating the graphs.
- (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items.
- (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and
- graph, these are now created during the first refresh.
- (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement.
- (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto.
- (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
- (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just
- add the resource to the _staleResources and set needsRefresh.
- (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check
- _resourcesTreeElement.
- (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear
- the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild
- since the insertBefore call will do it if needed.
- (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to
- clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded.
- (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the
- timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel,
- since all the legend items are removed in one pass right before.
- (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction
- before the calculator so the correct sortingFunction is there when a refresh happens.
- (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0
- when the startTime is -1, since that looks best visually. Also set middle and end
- to the start and middle (respectfully) when startAtZero. This looks best visually.
- (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh.
- (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21733
-
- Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
- no attempt is made to re-cache the frame from a non-existent image source.
-
- Reviewed by Sam Weinig
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::BitmapImage):
-
-2008-10-20 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - make hasARenderedDescendant() have internal linkage
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::hasARenderedDescendant):
-
-2008-10-20 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Jon Honeycutt
-
- Fix a crash in Accessibility where a table section was being
- referenced without first checking if it was null
-
- https://bugs.webkit.org/show_bug.cgi?id=21721
-
- Test: accessibility/table-nofirstbody.html
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::addChildren):
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.
-
- Reviewed by Darin Adler
-
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::repetitionCount):
- (WebCore::ImageSource::frameDurationAtIndex):
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Reviewed by Mark Rowe.
-
- Fix the pthread conditionals in the FTP code to correctly define
- threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
- build.
-
- * loader/FTPDirectoryDocument.cpp:
- * loader/FTPDirectoryParser.cpp:
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21751
-
- Convert checkboxes and radio buttons on OS X over to the new Theme API.
-
- Reviewed by Adam Roben
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapFillSize):
- * platform/Length.h:
- (WebCore::LengthSize::LengthSize):
- (WebCore::LengthSize::operator==):
- (WebCore::LengthSize::width):
- (WebCore::LengthSize::height):
- (WebCore::LengthSize::setWidth):
- (WebCore::LengthSize::setHeight):
- * platform/Theme.h:
- (WebCore::Theme::controlSize):
- (WebCore::Theme::controlSupportsBorder):
- (WebCore::Theme::controlSupportsPadding):
- (WebCore::Theme::paint):
- (WebCore::Theme::inflateControlPaintRect):
- * platform/ThemeTypes.h:
- (WebCore::):
- * platform/mac/ThemeMac.h:
- * platform/mac/ThemeMac.mm:
- (WebCore::):
- (WebCore::controlSizeForFont):
- (WebCore::sizeFromFont):
- (WebCore::setControlSize):
- (WebCore::updateStates):
- (WebCore::inflateRect):
- (WebCore::checkboxSizes):
- (WebCore::checkboxMargins):
- (WebCore::checkboxSize):
- (WebCore::checkbox):
- (WebCore::paintCheckbox):
- (WebCore::radioSizes):
- (WebCore::radioMargins):
- (WebCore::radioSize):
- (WebCore::radio):
- (WebCore::paintRadio):
- (WebCore::ThemeMac::baselinePositionAdjustment):
- (WebCore::ThemeMac::controlSize):
- (WebCore::ThemeMac::controlSupportsBorder):
- (WebCore::ThemeMac::controlSupportsPadding):
- (WebCore::ThemeMac::inflateControlPaintRect):
- (WebCore::ThemeMac::paint):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calculateBackgroundSize):
- * rendering/RenderObject.cpp:
- (WebCore::mustRepaintFillLayers):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::adjustStyle):
- (WebCore::RenderTheme::paint):
- (WebCore::RenderTheme::baselinePosition):
- (WebCore::RenderTheme::adjustRepaintRect):
- (WebCore::RenderTheme::controlStatesForRenderer):
- (WebCore::RenderTheme::isFocused):
- * rendering/RenderTheme.h:
- * rendering/RenderThemeMac.h:
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustRepaintRect):
- * rendering/style/FillLayer.cpp:
- (WebCore::FillLayer::operator==):
-
-2008-10-18 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
- Emit profiling instrumentation only if the Web Inspector's profiling
- feature is enabled
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::supportsProfiling):
- * bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying
- whether a target global object has the Web Inspector's profiling feature
- enabled.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon):
- (WebCore::JavaScriptDebugServer::didAddListener):
- (WebCore::JavaScriptDebugServer::didRemoveListener):
- * inspector/JavaScriptDebugServer.h: Exported an API for recompiling,
- used by the Settings object.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setDeveloperExtrasEnabled):
- * page/Settings.h: Recompile when the developer menu is enabled/disabled
- for the first time, to add/remove profiling hooks. In the future, with
- better Web Inspector UI, we can do this on a page-by-page basis,
- instead of a global basis.
-
-2008-10-20 David Hyatt <hyatt@apple.com>
-
- Move Length to platform/.
-
- Reviewed by Adam Roben
-
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- * platform/Length.cpp: Copied from rendering/Length.cpp.
- * platform/Length.h: Copied from rendering/Length.h.
-
-2008-10-20 Darin Adler <darin@apple.com>
-
- - try to fix Qt build
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls.
- (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
-
-2008-10-20 Darin Adler <darin@apple.com>
-
- - try to fix Qt build
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr.
- (JSC::Bindings::QtField::valueFromInstance): Ditto.
- * bridge/qt/qt_instance.h: Ditto.
-
-2008-10-20 Darin Adler <darin@apple.com>
-
- - try to fix Tiger build
-
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted
- volatile qualifier.
- (ObjcInstance::invokeDefaultMethod): Ditto.
- (ObjcInstance::getValueOfUndefinedField): Ditto.
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::ObjcField::valueFromInstance): Ditto.
-
-2008-10-20 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21750
- Eliminate the notion of "temporary events"
-
- We mark some events as temporary when dispatching, for the sole reason of
- manually calling forgetDOMObject when done dispatching.
-
- There doesn't seem to be any reason to call it manually, as JSEvent destructor
- will do this automatically right away.
-
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptController.h:
- Removed ScriptController::finishedWithEvent(), which was called after dispatching
- a temporary event.
-
- * dom/ContainerNode.cpp:
- (WebCore::dispatchChildInsertionEvents):
- (WebCore::dispatchChildRemovalEvents):
- * dom/EventTarget.h:
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchEvent):
- (WebCore::EventTargetNode::dispatchGenericEvent):
- (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
- (WebCore::EventTargetNode::dispatchWindowEvent):
- (WebCore::EventTargetNode::dispatchUIEvent):
- (WebCore::EventTargetNode::dispatchKeyEvent):
- (WebCore::EventTargetNode::dispatchMouseEvent):
- (WebCore::EventTargetNode::dispatchWheelEvent):
- (WebCore::EventTargetNode::dispatchWebKitAnimationEvent):
- (WebCore::EventTargetNode::dispatchWebKitTransitionEvent):
- (WebCore::EventTargetNode::dispatchEventForType):
- (WebCore::EventTargetNode::dispatchProgressEvent):
- (WebCore::EventTargetNode::dispatchStorageEvent):
- * dom/EventTargetNode.h:
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::dispatchMessages):
- (WebCore::MessagePort::dispatchCloseEvent):
- (WebCore::MessagePort::dispatchEvent):
- * dom/MessagePort.h:
- * editing/Editor.cpp:
- (WebCore::Editor::dispatchCPPEvent):
- (WebCore::dispatchEditableContentChangedEvents):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::insertText):
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::dispatchEvent):
- (WebCore::DOMApplicationCache::callListener):
- * loader/appcache/DOMApplicationCache.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchDragEvent):
- (WebCore::EventHandler::keyEvent):
- (WebCore::EventHandler::handleTextInputEvent):
- * page/FrameView.cpp:
- (WebCore::FrameView::scheduleEvent):
- (WebCore::FrameView::updateOverflowStatus):
- (WebCore::FrameView::dispatchScheduledEvents):
- * page/FrameView.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollToOffset):
- (WebCore::RenderLayer::updateOverflowStatus):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::sendSVGLoadEventIfPossible):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::dispatchEvent):
- * svg/SVGElementInstance.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::dispatchEvent):
- (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
- (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::dispatchEvent):
- (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
- * xml/XMLHttpRequestUpload.h:
- Don't pass the tempEvent boolean around.
-
-2008-10-20 Alp Toker <alp@nuanti.com>
-
- Remove unused includes only. Partial GTK+/Win build fix.
-
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
-
-2008-10-20 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=21705
- Implement Web Workers client-side API
-
- The implementation is experimental, and disabled by default. It doesn't quite match the
- published draft, being influenced by further WHATWG discussions.
-
- This only implements the client-side API, and does not actually create any threads or
- global contexts yet.
-
- * DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm
- still not sure if having separate classes for these helps at all.
-
- * WebCore.xcodeproj/project.pbxproj: Added new files.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (jsDOMWindowBaseWorker):
- (WebCore::JSDOMWindowBase::put):
- (setJSDOMWindowBaseWorker):
- Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef
- to match prevailing style.
-
- * bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
- * bindings/js/JSDedicatedWorkerConstructor.h: Added.
- * bindings/js/JSDedicatedWorkerCustom.cpp: Added.
- The implementation of event listeners are left custom intentionally, for easier implementation
- of listeners that are not tied to any Document in the future.
-
- * dom/DedicatedWorker.cpp: Added.
- * dom/DedicatedWorker.h: Added.
- * dom/DedicatedWorker.idl: Added.
- Added an implementation that can only load requested scripts for now.
-
-2008-10-19 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - fix assertion seen when opening inspector
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
- Removed unneeded asObject cast.
-
-2008-10-19 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Timothy Hatcher.
-
- - remove empty directories and correct the MIME type of inspector images
-
- * page/inspector: Removed.
- * page/inspector/Images: Removed.
-
-2008-10-19 Timothy Hatcher <timothy@apple.com>
-
- Make the Web Inspector Resources panel open quicker and change graphs
- faster. There was some accidental n^2 logic at fault when updating the
- graph boundaries.
-
- https://bugs.webkit.org/show_bug.cgi?id=21742
-
- Reviewed by Darin Adler.
-
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.set calculator): Return early for
- a null calculator. Remove the second argument passed to _refreshAllResources.
- (WebInspector.ResourcesPanel.prototype.refresh): Call updateBoundaries on
- the calculator for all the stale resources before calling refreshResource.
- Pass true for the first argument of refreshResource to skip the boundary update.
- (WebInspector.ResourcesPanel.prototype._updateGraphBoundariesIfNeeded): Remove
- the second argument passed to _refreshAllResources.
- (WebInspector.ResourcesPanel.prototype._refreshAllResourcesSoon): Remove the
- skipSort argument since every passed true, and it would be bad to pass false.
- (WebInspector.ResourcesPanel.prototype._refreshAllResources): Ditto. And if
- skipBoundaryUpdate is false, call updateBoundaries on the calculator for all
- the resources before calling refreshResource. Pass true for the first argument
- of refreshResource to skip the boundary update.
-
-2008-10-19 Timothy Hatcher <timothy@apple.com>
-
- Visually distinguish resources that loaded from the memory cache.
-
- https://bugs.webkit.org/show_bug.cgi?id=14279
-
- Reviewed by Dan Bernstein.
-
- * English.lproj/localizedStrings.js: New string.
- * inspector/front-end/Images/timelineHollowPillBlue.png: Added.
- * inspector/front-end/Images/timelineHollowPillGray.png: Added.
- * inspector/front-end/Images/timelineHollowPillGreen.png: Added.
- * inspector/front-end/Images/timelineHollowPillOrange.png: Added.
- * inspector/front-end/Images/timelineHollowPillPurple.png: Added.
- * inspector/front-end/Images/timelineHollowPillRed.png: Added.
- * inspector/front-end/Images/timelineHollowPillYellow.png: Added.
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels):
- Add the "(from cache)" suffix to the tooltip.
- (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
- Add the "(from cache)" suffix to the tooltip.
- (WebInspector.ResourceGraph): Add the "resource-cached" class.
- * inspector/front-end/inspector.css: New styles to make the timeline
- bars use the hollow pill images.
-
-2008-10-19 Timothy Hatcher <timothy@apple.com>
-
- Update the scroll position in the Resources panel when loading
- a new page or toggling on small resource rows.
-
- https://bugs.webkit.org/show_bug.cgi?id=20114
-
- Reviewed by Darin Adler.
-
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.reset): Scroll to the top,
- since all the resource are being removed.
- (WebInspector.ResourcesPanel.prototype.removeResource): Call
- _adjustScrollPosition in case the view is shorter and needs scrolled.
- (WebInspector.ResourcesPanel.prototype._toggleLargerResources): Ditto.
- (WebInspector.ResourcesPanel.prototype._adjustScrollPosition): Check
- the height of the sidebar against the scrollTop and height of the
- resourcesContainerElement. If the sidebar is shorter, scroll up
- so the last resource is at the bottom again.
-
-2008-10-19 Timothy Hatcher <timothy@apple.com>
-
- Show per resource times and sizes when hovering over the bar graph for a resource.
-
- https://bugs.webkit.org/show_bug.cgi?id=14300
- rdar://problem/5712802
-
- Reviewed by Cameron Zwarich.
-
- * English.lproj/localizedStrings.js: Add new strings.
- * inspector/front-end/Images/graphLabelCalloutLeft.png: Added.
- * inspector/front-end/Images/graphLabelCalloutRight.png: Added.
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.refreshResource): Pass the calculator to the
- ResourceGraph.refresh function.
- (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Default implementation
- returns the formatted value.
- (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Return discrete values
- for the latency and download times. Also generate a custom tooltip.
- (WebInspector.ResourceGraph): Add a mouseover event listener that calls refreshLabelPositions.
- (WebInspector.ResourceGraph.prototype.refreshLabelPositions): Added. Updates the label positions
- in case the bar has changed size.
- (WebInspector.ResourceGraph.prototype.refresh): Set the label text and tooltips.
- * inspector/front-end/inspector.css: New styles for the labels.
-
-2008-10-19 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Remove most uses of JSValue, which will be removed in a future patch.
-
- * bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue
- and used JSValuePtr instead.
- * bindings/js/JSEventTarget.h: Ditto.
- * bindings/js/JSNodeFilterCondition.h: Ditto.
- * bindings/js/ScheduledAction.h: Ditto.
- * bindings/js/ScriptController.h: Ditto.
- * bindings/objc/WebScriptObjectPrivate.h: Ditto.
- * bridge/c/c_utility.h: Ditto.
- * bridge/jni/jni_jsobject.h: Ditto.
- * bridge/jni/jni_utility.h: Ditto.
- * bridge/objc/WebScriptObject.h: Ditto.
- * dom/Traversal.h: Ditto.
- * inspector/InspectorController.cpp: Ditto.
- * inspector/JavaScriptProfile.h: Ditto.
- * inspector/JavaScriptProfileNode.h: Ditto.
- * loader/FrameLoader.h: Ditto.
- * page/Console.h: Ditto.
- * plugins/MimeTypeArray.h: Ditto.
- * plugins/Plugin.h: Ditto.
- * plugins/PluginArray.h: Ditto.
- * plugins/PluginView.cpp:
- (WebCore::getString): Ditto.
- (WebCore::PluginView::performRequest): Ditto.
- * plugins/gtk/PluginViewGtk.cpp: Ditto.
- * plugins/qt/PluginViewQt.cpp: Ditto.
- * plugins/win/PluginViewWin.cpp: Ditto.
-
- * bridge/qt/qt_class.cpp:
- (JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject*
- instead of JSValue*.
- * bridge/qt/qt_class.h: Ditto.
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::mark): Ditto.
- (JSC::Bindings::QtInstance::invokeMethod): Ditto.
- (JSC::Bindings::QtInstance::defaultValue): Ditto.
- (JSC::Bindings::QtInstance::stringValue): Ditto.
- (JSC::Bindings::QtInstance::numberValue): Ditto.
- (JSC::Bindings::QtInstance::booleanValue): Ditto.
- (JSC::Bindings::QtInstance::valueOf): Ditto.
- (JSC::Bindings::QtField::valueFromInstance): Ditto.
- (JSC::Bindings::QtField::setValueToInstance): Ditto.
- * bridge/qt/qt_instance.h: Ditto.
- * bridge/qt/qt_runtime.cpp: Ditto.
- (JSC::Bindings::valueRealType): Ditto.
- (JSC::Bindings::convertValueToQVariant): Ditto.
- (JSC::Bindings::convertQVariantToValue): Ditto.
- (JSC::Bindings::findMethodIndex): Ditto.
- (JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
- (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto.
- (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
- (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
- (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
- (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
- (JSC::Bindings::QtArray::setValueAt): Ditto.
- (JSC::Bindings::QtArray::valueAt): Ditto.
- * bridge/qt/qt_runtime.h: Ditto.
-
- * bridge/testqtbindings.cpp:
- (main): Use JSValuePtr.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Tweak a little more to get closer to where we can make JSValuePtr a class.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject.
- (WebCore::constructAudio): Ditto.
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.
-
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::toHTMLCanvasStyle): Use asString and asObject.
- (WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto.
- (WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto.
- (WebCore::JSCanvasRenderingContext2D::drawImage): Ditto.
- (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto.
- (WebCore::JSCanvasRenderingContext2D::setShadow): Ditto.
- (WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.
-
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::setDOMException): Use noValue.
-
- * bindings/js/JSDOMBinding.h:
- (WebCore::getDOMPrototype): Use asObject.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::showModalDialog): Use noValue.
- (jsDOMWindowBaseEvent): Use asObject.
- (jsDOMWindowBaseImage): Ditto.
- (jsDOMWindowBaseMessageChannel): Ditto.
- (jsDOMWindowBaseOption): Ditto.
- (jsDOMWindowBaseXMLHttpRequest): Ditto.
- (jsDOMWindowBaseAudio): Ditto.
- (jsDOMWindowBaseXSLTProcessor): Ditto.
- (WebCore::JSDOMWindowBase::childFrameGetter): Ditto.
- (WebCore::JSDOMWindowBase::indexGetter): Ditto.
- (WebCore::JSDOMWindowBase::namedItemGetter): Ditto.
- (WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto.
- (WebCore::JSDOMWindowBase::findJSEventListener): Ditto.
- (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto.
- (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto.
- (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto.
- (windowProtoFuncOpen): Use noValue.
- (WebCore::toJSDOMWindow): Use asObject.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::setTimeoutOrInterval): Use asString.
- (WebCore::toDOMWindow): Use asObject.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent): Use noValue.
- (WebCore::JSLazyEventListener::parseCode): Use asObject.
-
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::JSHTMLCollection::nameGetter): Use asObject.
- * bindings/js/JSHTMLDocumentCustom.cpp:
- (WebCore::JSHTMLDocument::nameGetter): Ditto.
- * bindings/js/JSHTMLElementCustom.cpp:
- (WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::nameGetter): Ditto.
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- (WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
- * bindings/js/JSHTMLOptionElementConstructor.cpp:
- (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
- (WebCore::constructHTMLOptionElement): Ditto.
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- (WebCore::JSHTMLOptionsCollection::remove): Ditto.
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
- (WebCore::constructImage): Ditto.
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap): Ditto.
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
-
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.
-
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject.
- (WebCore::JSMessageChannelConstructor::construct): Ditto.
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- (WebCore::JSMimeTypeArray::nameGetter): Ditto.
- * bindings/js/JSNamedNodeMapCustom.cpp:
- (WebCore::JSNamedNodeMap::nameGetter): Ditto.
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::lengthGetter): Ditto.
- (WebCore::JSNamedNodesCollection::indexGetter): Ditto.
- * bindings/js/JSNodeFilterCustom.cpp:
- (WebCore::toNodeFilter): Ditto.
- * bindings/js/JSNodeListCustom.cpp:
- (WebCore::JSNodeList::nameGetter): Ditto.
- * bindings/js/JSPluginArrayCustom.cpp:
- (WebCore::JSPluginArray::nameGetter): Ditto.
- * bindings/js/JSPluginCustom.cpp:
- (WebCore::JSPlugin::nameGetter): Ditto.
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::runtimeObjectGetter): Ditto.
- (WebCore::runtimeObjectPropertyGetter): Ditto.
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto.
- (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto.
- (WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
- * bindings/js/JSRGBColor.cpp:
- (jsRGBColorRed): Ditto.
- (jsRGBColorGreen): Ditto.
- (jsRGBColorBlue): Ditto.
-
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item): Use noValue.
-
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::nameGetter): Use asObject.
- (WebCore::JSStorage::deleteProperty): Ditto.
- (WebCore::JSStorage::customPut): Ditto.
- * bindings/js/JSStyleSheetListCustom.cpp:
- (WebCore::JSStyleSheetList::nameGetter): Ditto.
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
- * bindings/js/JSXSLTProcessorCustom.cpp:
- (WebCore::JSXSLTProcessor::importStylesheet): Ditto.
- (WebCore::JSXSLTProcessor::transformToFragment): Ditto.
- (WebCore::JSXSLTProcessor::transformToDocument): Ditto.
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate): Use noValue.
- * bindings/objc/DOMInternal.mm:
- (-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.
-
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject evaluateWebScript:]): Use JSValuePtr.
- (-[WebScriptObject valueForKey:]): Ditto.
- (-[WebScriptObject webScriptValueAtIndex:]): Ditto.
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- Use asObject and asString.
-
- * bindings/scripts/CodeGeneratorJS.pm: Use asObject.
-
- * bridge/c/c_instance.h: Use JSValuePtr.
- * bridge/c/c_runtime.cpp:
- (JSC::Bindings::CField::setValueToInstance): Ditto.
-
- * bridge/c/c_utility.cpp:
- (JSC::Bindings::convertValueToNPVariant): Use asObject.
-
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::booleanValue): Use JSValuePtr.
- (JavaInstance::invokeMethod): Ditto. And noValue.
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::getSlot): Ditto.
- (JavaJSObject::convertValueToJObject): Ditto.
- * bridge/jni/jni_runtime.cpp:
- (JavaField::dispatchValueFromInstance): Ditto.
- (JavaField::valueFromInstance): Ditto.
- (JavaField::dispatchSetValueToInstance): Ditto.
- (JavaField::setValueToInstance): Ditto.
- (JavaArray::setValueAt): Ditto.
- (JavaArray::valueAt): Ditto.
- * bridge/jni/jni_runtime.h: Ditto.
-
- * bridge/jni/jni_utility.cpp:
- (JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray*
- instead of a JSValue*.
- (JSC::Bindings::convertValueToJValue): Use asObject and asArray.
-
- * bridge/objc/objc_class.h: Use JSValuePtr.
- * bridge/objc/objc_instance.h: Ditto.
- * bridge/objc/objc_runtime.h: Ditto.
-
- * bridge/objc/objc_runtime.mm:
- (JSC::Bindings::callObjCFallbackObject): Use asObject.
-
- * bridge/objc/objc_utility.h: Use JSValuePtr.
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject.
- (JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.
-
- * bridge/runtime.cpp:
- (JSC::Bindings::Instance::getValueOfField): Use JSValuePtr.
- (JSC::Bindings::Instance::setValueOfField): Ditto.
-
- * bridge/runtime_array.cpp:
- (JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject.
- (JSC::RuntimeArray::indexGetter): Ditto.
- * bridge/runtime_array.h: Ditto.
- * bridge/runtime_method.cpp:
- (JSC::RuntimeMethod::lengthGetter): Ditto.
- (JSC::callRuntimeMethod): Ditto.
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto.
- (JSC::RuntimeObjectImp::fieldGetter): Ditto.
- (JSC::RuntimeObjectImp::methodGetter): Ditto.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeScript): Use noValue.
-
- * page/Console.cpp:
- (WebCore::Console::trace): Use asInternalFunction.
-
-2008-10-19 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Timothy Hatcher.
-
- - lower the default button repaint frequency
-
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::styleDidChange): Changed the timer interval from
- 0.01 to 0.03.
+ * html/HTMLAttributeNames.in:
+ * html/HTMLDataGridCellElement.cpp: Added.
+ (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement):
+ (WebCore::HTMLDataGridCellElement::label):
+ (WebCore::HTMLDataGridCellElement::setLabel):
+ (WebCore::HTMLDataGridCellElement::focused):
+ (WebCore::HTMLDataGridCellElement::setFocused):
+ (WebCore::HTMLDataGridCellElement::checked):
+ (WebCore::HTMLDataGridCellElement::setChecked):
+ (WebCore::HTMLDataGridCellElement::indeterminate):
+ (WebCore::HTMLDataGridCellElement::setIndeterminate):
+ (WebCore::HTMLDataGridCellElement::progress):
+ (WebCore::HTMLDataGridCellElement::setProgress):
+ * html/HTMLDataGridCellElement.h: Added.
+ (WebCore::HTMLDataGridCellElement::endTagRequirement):
+ (WebCore::HTMLDataGridCellElement::tagPriority):
+ * html/HTMLDataGridCellElement.idl: Added.
+ * html/HTMLDataGridElement.cpp:
+ (WebCore::HTMLDataGridElement::autofocus):
+ (WebCore::HTMLDataGridElement::setAutofocus):
+ (WebCore::HTMLDataGridElement::disabled):
+ (WebCore::HTMLDataGridElement::setDisabled):
+ (WebCore::HTMLDataGridElement::size):
+ (WebCore::HTMLDataGridElement::setSize):
+ * html/HTMLDataGridElement.h:
+ * html/HTMLDataGridElement.idl:
+ * html/HTMLDataGridRowElement.cpp:
+ (WebCore::HTMLDataGridRowElement::checkDTD):
+ (WebCore::HTMLDataGridRowElement::expanded):
+ (WebCore::HTMLDataGridRowElement::setExpanded):
+ * html/HTMLDataGridRowElement.h:
+ * html/HTMLDataGridRowElement.idl:
+ * html/HTMLElementsAllInOne.cpp:
+ * html/HTMLTagNames.in:
-2008-10-18 Dan Bernstein <mitz@apple.com>
+2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
- - Windows build fix
-
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::paintMediaFullscreenButton):
- (WebCore::RenderThemeSafari::paintMediaMuteButton):
- (WebCore::RenderThemeSafari::paintMediaPlayButton):
- (WebCore::RenderThemeSafari::paintMediaSeekBackButton):
- (WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
- (WebCore::RenderThemeSafari::paintMediaSliderThumb):
-
-2008-10-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736
- Long-dead decoded image data make up for most of the object cache's memory use over time
+ Add event handler attribute getter/setters to HTMLBodyElement
+ as specified in HTML 5.
- Add a cache setting for how long decoded image data should be allowed to
- persist in memory after the image has died. By default, this is set to
- 0, which means "forever".
-
- * loader/Cache.cpp:
- (WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
- * loader/Cache.h:
- (WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter.
- (WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::CachedImage): Initialize the decoded data
- deletion timer.
- (WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys
- the decoded image data.
- (WebCore::CachedImage::addClient): Stop the timer if it is active.
- (WebCore::CachedImage::allClientsRemoved): Start the decoded data
- deletion timer.
- * loader/CachedImage.h:
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21645
- REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::formData):
- Fix loop that goes through the FormDataList to go two at a time in a clearer
- way. My last patch screwed up the way it got form content from the items.
- This "two at a time" approach is a confusing way to do things, which explains
- why I got it wrong last time through, but I decided to just fix it locally for
- now rather than changing the design of FormDataList.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - next step on https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
- changing JSValuePtr to be a class, and then eventually renaming it
- to JSValue once that's done.
-
- * bindings/js/JSAttrCustom.cpp:
- * bindings/js/JSCSSRuleCustom.cpp:
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- * bindings/js/JSCSSValueCustom.cpp:
- * bindings/js/JSCanvasPixelArrayCustom.h:
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- * bindings/js/JSClipboardCustom.cpp:
- * bindings/js/JSConsoleCustom.cpp:
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- * bindings/js/JSCustomVoidCallback.cpp:
- * bindings/js/JSCustomVoidCallback.h:
- * bindings/js/JSCustomXPathNSResolver.cpp:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- * bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- * bindings/js/JSDOMWindowCustom.h:
- * bindings/js/JSDOMWindowShell.cpp:
- * bindings/js/JSDOMWindowShell.h:
- * bindings/js/JSDatabaseCustom.cpp:
- * bindings/js/JSDocumentCustom.cpp:
- * bindings/js/JSElementCustom.cpp:
- * bindings/js/JSEventCustom.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventTarget.cpp:
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetNodeCustom.cpp:
- * bindings/js/JSHTMLAllCollection.h:
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- * bindings/js/JSHTMLCollectionCustom.cpp:
- * bindings/js/JSHTMLDocumentCustom.cpp:
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- * bindings/js/JSHTMLFormElementCustom.cpp:
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- * bindings/js/JSHTMLInputElementCustom.cpp:
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- * bindings/js/JSHTMLSelectElementCustom.h:
- * bindings/js/JSHistoryCustom.cpp:
- * bindings/js/JSImageDataCustom.cpp:
- * bindings/js/JSInspectedObjectWrapper.cpp:
- * bindings/js/JSInspectedObjectWrapper.h:
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- * bindings/js/JSInspectorCallbackWrapper.h:
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- * bindings/js/JSLocationCustom.cpp:
- * bindings/js/JSMessagePortCustom.cpp:
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- * bindings/js/JSNamedNodeMapCustom.cpp:
- * bindings/js/JSNamedNodesCollection.cpp:
- * bindings/js/JSNamedNodesCollection.h:
- * bindings/js/JSNavigatorCustom.cpp:
- * bindings/js/JSNodeCustom.cpp:
- * bindings/js/JSNodeFilterCondition.cpp:
- * bindings/js/JSNodeFilterCustom.cpp:
- * bindings/js/JSNodeIteratorCustom.cpp:
- * bindings/js/JSNodeListCustom.cpp:
- * bindings/js/JSPluginArrayCustom.cpp:
- * bindings/js/JSPluginCustom.cpp:
- * bindings/js/JSPluginElementFunctions.cpp:
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- * bindings/js/JSQuarantinedObjectWrapper.h:
- * bindings/js/JSRGBColor.cpp:
- * bindings/js/JSRGBColor.h:
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- * bindings/js/JSSQLTransactionCustom.cpp:
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- * bindings/js/JSSVGLengthCustom.cpp:
- * bindings/js/JSSVGMatrixCustom.cpp:
- * bindings/js/JSSVGPathSegCustom.cpp:
- * bindings/js/JSSVGPathSegListCustom.cpp:
- * bindings/js/JSSVGPointListCustom.cpp:
- * bindings/js/JSSVGTransformListCustom.cpp:
- * bindings/js/JSStorageCustom.cpp:
- * bindings/js/JSStyleSheetCustom.cpp:
- * bindings/js/JSStyleSheetListCustom.cpp:
- * bindings/js/JSTextCustom.cpp:
- * bindings/js/JSTreeWalkerCustom.cpp:
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- * bindings/js/JSXSLTProcessorCustom.cpp:
- * bindings/js/ScheduledAction.cpp:
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptController.cpp:
- * bindings/js/ScriptController.h:
- * bindings/objc/WebScriptObject.mm:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- * bridge/c/c_instance.cpp:
- * bridge/c/c_instance.h:
- * bridge/c/c_runtime.cpp:
- * bridge/c/c_runtime.h:
- * bridge/c/c_utility.cpp:
- * bridge/jni/jni_instance.cpp:
- * bridge/jni/jni_instance.h:
- * bridge/jni/jni_jsobject.mm:
- * bridge/jni/jni_objc.mm:
- * bridge/jni/jni_runtime.cpp:
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- * bridge/objc/objc_class.mm:
- * bridge/objc/objc_instance.h:
- * bridge/objc/objc_instance.mm:
- * bridge/objc/objc_runtime.h:
- * bridge/objc/objc_runtime.mm:
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- * bridge/runtime.h:
- * bridge/runtime_array.cpp:
- * bridge/runtime_array.h:
- * bridge/runtime_method.cpp:
- * bridge/runtime_method.h:
- * bridge/runtime_object.cpp:
- * bridge/runtime_object.h:
- * inspector/JavaScriptCallFrame.cpp:
- * inspector/JavaScriptCallFrame.h:
- * inspector/JavaScriptProfile.cpp:
- * inspector/JavaScriptProfileNode.cpp:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
- * page/Console.cpp:
- * page/Console.h:
- * plugins/MimeTypeArray.h:
- * plugins/Plugin.h:
- * plugins/PluginArray.h:
- * xml/XMLHttpRequest.cpp:
- Replace JSValue* with JSValuePtr.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- Reviewed by Oliver Hunt.
-
- - first step of https://bugs.webkit.org/show_bug.cgi?id=21732
- improve performance by eliminating JSValue as a base class for JSCell
-
- Update for change to make PreferredPrimitiveType no longer
- a member of JSValue.
-
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::defaultValue): Removed JSValue:: prefix.
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::defaultValue): Ditto.
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::defaultValue): Ditto.
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::defaultValue): Ditto.
- * bridge/runtime.h: Ditto. Also removed typedef.
-
-2008-10-18 Darin Adler <darin@apple.com>
-
- - try to fix Windows build
-
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::paintCheckbox): Explicitly qualify part name with
- SafariTheme namespace, since there is now an identically named constant in
- the ControlPart enum.
- (WebCore::RenderThemeSafari::paintButton): Ditto.
- (WebCore::RenderThemeSafari::paintTextField): Ditto.
- (WebCore::RenderThemeSafari::paintTextArea): Ditto.
- (WebCore::RenderThemeSafari::paintSearchField): Ditto.
- (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto.
- (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto.
- (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
-
-2008-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Alp Toker.
-
- [GTK] crash after selecting a file on an <input type=file>
- https://bugs.webkit.org/show_bug.cgi?id=21385
-
- Follow Mac and Win's behaviors for Icon::paint
-
- * platform/graphics/gtk/IconGtk.cpp:
- (WebCore::Icon::paint): check if painting is enabled before
- painting the icon
-
-2008-10-18 Zan Dobersek <zandobersek@gmail.com>
-
- Reviewed by Oliver Hunt.
-
- Qt port build fix.
-
- * platform/qt/RenderThemeQt.h:
-
-2008-10-17 Kevin Watters <kevinwatters@gmail.com>
-
- Reviewed by Kevin Ollivier
-
- Fix wx port's scrollbar and drawing handling after recent changes.
-
- https://bugs.webkit.org/show_bug.cgi?id=21720
-
- * platform/ScrollView.h:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformVisibleContentRect):
- (WebCore::ScrollView::platformContentsSize):
- (WebCore::ScrollView::platformSetContentsSize):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::paint):
-
-2008-10-17 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. EAppearance -> ControlPart.
-
- * platform/wx/RenderThemeWx.cpp:
- (WebCore::RenderThemeWx::isControlStyled):
- (WebCore::RenderThemeWx::adjustRepaintRect):
- (WebCore::RenderThemeWx::controlSupportsTints):
- (WebCore::RenderThemeWx::supportsFocus):
- (WebCore::RenderThemeWx::paintButton):
+ - Removes erroneous inclusion of the onresize and onunload event
+ handler attributes in Element and Document.
-2008-10-17 David Hyatt <hyatt@apple.com>
-
- Eliminate the EAppearance enum in favor of the new ControlPart enum. Cut out the scrollbar
- values from the enum since they are handled by ScrollbarTheme instead.
-
- Reviewed by Tim Hatcher
-
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator ControlPart):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * css/CSSValueKeywords.in:
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::supportsFocus):
- (WebCore::RenderThemeGtk::baselinePosition):
- (WebCore::setToggleSize):
- (WebCore::RenderThemeGtk::setCheckboxSize):
- (WebCore::RenderThemeGtk::setRadioSize):
- (WebCore::RenderThemeGtk::adjustButtonStyle):
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::baselinePosition):
- (WebCore::RenderThemeQt::controlSupportsTints):
- (WebCore::RenderThemeQt::adjustRepaintRect):
- (WebCore::RenderThemeQt::isControlStyled):
- (WebCore::computeSizeBasedOnStyle):
- (WebCore::RenderThemeQt::paintButton):
- (WebCore::RenderThemeQt::paintTextField):
- (WebCore::RenderThemeQt::paintMenuList):
- (WebCore::RenderThemeQt::supportsFocus):
- (WebCore::RenderThemeQt::applyTheme):
- (WebCore::RenderThemeQt::adjustSliderThumbSize):
- * platform/qt/RenderThemeQt.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::createThumbStyle):
- (WebCore::RenderSlider::layout):
- (WebCore::RenderSlider::setValueForPosition):
- (WebCore::RenderSlider::setPositionFromValue):
- (WebCore::RenderSlider::positionForOffset):
- (WebCore::RenderSlider::currentPosition):
- (WebCore::RenderSlider::setCurrentPosition):
- (WebCore::RenderSlider::trackSize):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::adjustStyle):
- (WebCore::RenderTheme::paint):
- (WebCore::RenderTheme::paintBorderOnly):
- (WebCore::RenderTheme::paintDecorations):
- (WebCore::RenderTheme::isControlContainer):
- (WebCore::RenderTheme::isControlStyled):
- (WebCore::RenderTheme::supportsFocusRing):
- (WebCore::RenderTheme::isDefault):
- * rendering/RenderTheme.h:
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::isControlStyled):
- (WebCore::RenderThemeMac::adjustRepaintRect):
- (WebCore::RenderThemeMac::baselinePosition):
- (WebCore::RenderThemeMac::controlSupportsTints):
- (WebCore::RenderThemeMac::adjustButtonStyle):
- (WebCore::RenderThemeMac::setButtonCellState):
- (WebCore::RenderThemeMac::popupInternalPaddingLeft):
- (WebCore::RenderThemeMac::popupInternalPaddingRight):
- (WebCore::RenderThemeMac::popupInternalPaddingTop):
- (WebCore::RenderThemeMac::popupInternalPaddingBottom):
- (WebCore::RenderThemeMac::paintSliderTrack):
- (WebCore::RenderThemeMac::paintSliderThumb):
- (WebCore::RenderThemeMac::adjustSliderThumbSize):
- * rendering/RenderThemeSafari.cpp:
- (WebCore::RenderThemeSafari::isControlStyled):
- (WebCore::RenderThemeSafari::adjustRepaintRect):
- (WebCore::RenderThemeSafari::baselinePosition):
- (WebCore::RenderThemeSafari::controlSupportsTints):
- (WebCore::RenderThemeSafari::adjustButtonStyle):
- (WebCore::RenderThemeSafari::popupInternalPaddingLeft):
- (WebCore::RenderThemeSafari::popupInternalPaddingRight):
- (WebCore::RenderThemeSafari::popupInternalPaddingTop):
- (WebCore::RenderThemeSafari::popupInternalPaddingBottom):
- (WebCore::RenderThemeSafari::paintSliderTrack):
- (WebCore::RenderThemeSafari::adjustSliderThumbSize):
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::supportsFocus):
- (WebCore::RenderThemeWin::determineClassicState):
- (WebCore::RenderThemeWin::getClassicThemeData):
- (WebCore::RenderThemeWin::getThemeData):
- (WebCore::drawControl):
- (WebCore::RenderThemeWin::paintSliderTrack):
- (WebCore::RenderThemeWin::adjustSliderThumbSize):
- * rendering/RenderThemeWin.h:
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::hasAppearance):
- (WebCore::InheritedFlags::appearance):
- (WebCore::InheritedFlags::setAppearance):
- (WebCore::InheritedFlags::initialAppearance):
- * rendering/style/RenderStyleConstants.h:
-
-2008-10-17 David Hyatt <hyatt@apple.com>
-
- Beginning of the RenderTheme re-architecture (to share more code). Add the new Theme API header
- file. Add new USE(NEW_THEME) switch that is enabled on Mac. The Mac theme will be converted first.
-
- Reviewed by Tim Hatcher
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * config.h:
- * platform/Theme.h: Added.
- (WebCore::Theme::Theme):
- (WebCore::Theme::~Theme):
- (WebCore::Theme::baselinePositionAdjustment):
- (WebCore::Theme::controlHasInactiveAppearance):
- (WebCore::Theme::controlsCanHaveInactiveAppearance):
- (WebCore::Theme::controlsCanHaveHoveredAppearance):
- (WebCore::Theme::controlDrawsBorder):
- (WebCore::Theme::controlDrawsBackground):
- (WebCore::Theme::controlDrawsFocusOutline):
- (WebCore::Theme::selectionColor):
- (WebCore::Theme::textSearchHighlightColor):
- (WebCore::Theme::systemColor):
- (WebCore::Theme::systemFont):
- (WebCore::Theme::caretBlinkFrequency):
- (WebCore::Theme::themeChanged):
- (WebCore::Theme::controlSize):
- (WebCore::Theme::controlFont):
- (WebCore::Theme::controlPadding):
- (WebCore::Theme::controlInternalPadding):
- (WebCore::Theme::controlBorder):
- (WebCore::Theme::controlBorderRadius):
- (WebCore::Theme::paint):
- (WebCore::Theme::inflateControlPaintRect):
- * platform/ThemeTypes.h: Added.
- (WebCore::):
- (WebCore::ControlBox::ControlBox):
- (WebCore::ControlBox::top):
- (WebCore::ControlBox::right):
- (WebCore::ControlBox::bottom):
- (WebCore::ControlBox::left):
- * platform/mac/ThemeMac.h: Added.
- (WebCore::ThemeMac::ThemeMac):
- (WebCore::ThemeMac::~ThemeMac):
- * platform/mac/ThemeMac.mm: Added.
- (WebCore::platformTheme):
- * rendering/RenderTheme.cpp:
- (WebCore::RenderTheme::RenderTheme):
- * rendering/RenderTheme.h:
-
-2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Sam Weinig. Landed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=21603
- [GTK] Minor fixes to GOwnPtr
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::mediaPlayerPrivateErrorCallback):
-
-2008-10-17 Timothy Hatcher <timothy@apple.com>
-
- Recompile the JavaScript functions when removing any listener, so functions that are
- not being debugged can resume normal speed again.
-
- https://bugs.webkit.org/show_bug.cgi?id=21715
-
- Reviewed by Geoffrey Garen.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::globalExec): Changed an assert into an if check. This assert
- was firing when closing the window and having the recompile fire after. This was an
- overzelious assert now.
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::didRemoveListener): Start the recompile timer.
- (WebCore::JavaScriptDebugServer::didRemoveLastListener): Removed the recompile timer start.
-
-2008-10-17 Timothy Hatcher <timothy@apple.com>
-
- Fixes a regression where starting a debugging session in
- another Web Inspector window would not show any scripts.
- Also only attach the debugger to only the required Pages.
-
- https://bugs.webkit.org/show_bug.cgi?id=21708
-
- Reviewed by Darin Adler.
-
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::addListener): Add an assert and
- remove the call to willAddFirstListener(). Add a call to
- didAddListener().
- (WebCore::JavaScriptDebugServer::removeListener): Add an assert
- and call to didRemoveListener().
- (WebCore::JavaScriptDebugServer::pageCreated): Attach the debugger
- if there is a listener interested in the new Page.
- (WebCore::JavaScriptDebugServer::hasListenersInterestedInPage):
- Use hasGlobalListeners() instead of isEmpty().
- (WebCore::JavaScriptDebugServer::sourceParsed): Ditto.
- (WebCore::JavaScriptDebugServer::didAddListener): Added. Attach the
- debugger to the page if non-null, or all pages if page is null.
- (WebCore::JavaScriptDebugServer::didRemoveListener): Added. Detach
- the debugger only if there are no interested listeners.
- (WebCore::JavaScriptDebugServer::didRemoveLastListener): Remove the
- call to Page::setDebuggerForAllPages().
- * inspector/JavaScriptDebugServer.h:
- (WebCore::JavaScriptDebugServer::hasGlobalListeners): Added.
-
-2008-10-15 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Have ImageDocument generate its own filename for the title of images
- without relying on the suggested filename from the network layer, which
- may be nonexistant or not relevant.
- https://bugs.webkit.org/show_bug.cgi?id=21565
-
- * loader/ImageDocument.cpp:
- (WebCore::ImageTokenizer::finish):
-
-2008-10-17 Alexey Proskuryakov <ap@webkit.org>
-
- Non-Mac build fix.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
- Added ActiveDOMObject to the build.
-
-2008-10-17 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21642
- Abstract out active object tracking
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::markActiveObjectsForDocument):
- * dom/ActiveDOMObject.cpp: Added.
- (WebCore::ActiveDOMObject::ActiveDOMObject):
- (WebCore::ActiveDOMObject::~ActiveDOMObject):
- (WebCore::ActiveDOMObject::contextDestroyed):
- (WebCore::ActiveDOMObject::stop):
- * dom/ActiveDOMObject.h: Added.
- (WebCore::ActiveDOMObject::document):
- (WebCore::ActiveDOMObject::hasPendingActivity):
- (WebCore::ActiveDOMObject::setPendingActivity):
- (WebCore::ActiveDOMObject::unsetPendingActivity):
* dom/Document.cpp:
- (WebCore::Document::~Document):
- (WebCore::Document::stopActiveDOMObjects):
- (WebCore::Document::createdActiveDOMObject):
- (WebCore::Document::destroyedActiveDOMObject):
+ (WebCore::Document::getWindowAttributeEventListener):
* dom/Document.h:
- (WebCore::Document::activeDOMObjects):
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::contextDestroyed):
- * dom/MessagePort.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::~XMLHttpRequest):
- (WebCore::XMLHttpRequest::associatedFrame):
- (WebCore::XMLHttpRequest::responseXML):
- (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- (WebCore::XMLHttpRequest::initSend):
- (WebCore::XMLHttpRequest::send):
- (WebCore::XMLHttpRequest::createRequest):
- (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
- (WebCore::XMLHttpRequest::loadRequestSynchronously):
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::dropProtection):
- (WebCore::XMLHttpRequest::setRequestHeader):
- (WebCore::XMLHttpRequest::processSyncLoadResults):
- (WebCore::XMLHttpRequest::didFinishLoading):
- (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
- (WebCore::XMLHttpRequest::willSendRequest):
- (WebCore::XMLHttpRequest::accessControlCheck):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- (WebCore::XMLHttpRequest::stop):
- (WebCore::XMLHttpRequest::contextDestroyed):
- * xml/XMLHttpRequest.h:
- Move activity tracking to a new ActiveDOMObject class.
-
-2008-10-16 David Hyatt <hyatt@apple.com>
-
- Simplify styleForRenderer to avoid confusion. Callers in the SVG filter code thought "forRenderer" meant
- they would be given a style that corresponded to the RenderObject* passed in. This is not what the code
- did though. This patch removes the renderer argument and the Element subclass shadow implementation
- so that confusion like this can't occur again.
-
- Reviewed by Oliver Hunt
-
- * dom/Element.cpp:
- * dom/Element.h:
- * dom/Node.cpp:
- (WebCore::Node::createRendererIfNeeded):
- (WebCore::Node::styleForRenderer):
- * dom/Node.h:
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::attach):
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::attach):
- * svg/SVGClipPathElement.cpp:
- (WebCore::SVGClipPathElement::canvasResource):
- * svg/SVGFEDiffuseLightingElement.cpp:
- (WebCore::SVGFEDiffuseLightingElement::build):
- * svg/SVGFEFloodElement.cpp:
- (WebCore::SVGFEFloodElement::build):
- * svg/SVGFESpecularLightingElement.cpp:
- (WebCore::SVGFESpecularLightingElement::build):
- * svg/SVGGradientElement.cpp:
- (WebCore::SVGGradientElement::buildStops):
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::attachShadowTree):
-
-2008-10-16 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/attachment.cgi?bugid=21647
-
- Make RenderStyle inherit from RefCounted so that it works with RefPtr. RenderStyle was being malloced
- out of the RenderArena. Years and years ago (before TCMalloc), the plan was to make RenderStyles and
- all their associated sub-structs use the arena. However only the RenderStyle itself was ever changed
- to use the arena.
-
- At a later point style sharing was implemented, which made using the arena for styles pretty pointless,
- as the bulk of the styles on a given page are actually shared. Not ever making the sub-structs use the
- arena also limited the usefulness.
-
- Now that we have RefPtr/PassRefPtr to eliminate manual ref/deref and now that we use TCMalloc for fast
- mallocs, there is no reason to keep RenderStyles in the arena. The benefits of being able to eliminate
- manual ref/deref far outweigh keeping them in the arena.
-
- Reviewed by Adam Roben
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::CSSStyleSelector):
- (WebCore::CSSStyleSelector::~CSSStyleSelector):
- (WebCore::CSSStyleSelector::styleForElement):
- (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- (WebCore::CSSStyleSelector::pseudoStyleForElement):
- These methods now return a PassRefPtr. They will null out the m_style variable as they hand it back
- so that it isn't left pointing to the previous style resolve RenderStyle (which is what the old code did).
-
- (WebCore::CSSStyleSelector::updateFont):
- (WebCore::CSSStyleSelector::checkSelector):
- (WebCore::CSSStyleSelector::applyProperty):
- (WebCore::CSSStyleSelector::mapFillSize):
- (WebCore::CSSStyleSelector::mapFillXPosition):
- (WebCore::CSSStyleSelector::mapFillYPosition):
- * css/CSSStyleSelector.h:
- (WebCore::CSSStyleSelector::style):
- * dom/Document.cpp:
- (WebCore::Document::recalcStyle):
- * dom/Element.cpp:
- (WebCore::Element::styleForRenderer):
- (WebCore::Element::recalcStyle):
- (WebCore::Element::computedStyle):
- * dom/Element.h:
- * dom/ElementRareData.h:
- (WebCore::ElementRareData::ElementRareData):
- (WebCore::ElementRareData::resetComputedStyle):
- * dom/Node.cpp:
- (WebCore::Node::diff):
- (WebCore::Node::createRendererIfNeeded):
- (WebCore::Node::styleForRenderer):
- (WebCore::Node::setRenderStyle):
- * dom/Node.h:
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setFont):
- * html/HTMLOptGroupElement.cpp:
- (WebCore::HTMLOptGroupElement::attach):
- (WebCore::HTMLOptGroupElement::detach):
- (WebCore::HTMLOptGroupElement::setRenderStyle):
- (WebCore::HTMLOptGroupElement::nonRendererRenderStyle):
- * html/HTMLOptGroupElement.h:
- * html/HTMLOptionElement.cpp:
- (WebCore::HTMLOptionElement::attach):
- (WebCore::HTMLOptionElement::detach):
- (WebCore::HTMLOptionElement::setRenderStyle):
- (WebCore::HTMLOptionElement::nonRendererRenderStyle):
- * html/HTMLOptionElement.h:
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::animate):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationController::updateAnimations):
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
- (WebCore::CompositeAnimationPrivate::animate):
- (WebCore::CompositeAnimation::animate):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::ImplicitAnimation):
- (WebCore::ImplicitAnimation::~ImplicitAnimation):
- (WebCore::ImplicitAnimation::animate):
- (WebCore::ImplicitAnimation::reset):
- (WebCore::ImplicitAnimation::isTargetPropertyEqual):
- (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
- * page/animation/ImplicitAnimation.h:
- (WebCore::ImplicitAnimation::create):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
- (WebCore::KeyframeAnimation::~KeyframeAnimation):
- (WebCore::KeyframeAnimation::animate):
- (WebCore::KeyframeAnimation::validateTransformFunctionList):
- * page/animation/KeyframeAnimation.h:
- (WebCore::KeyframeAnimation::create):
- (WebCore::KeyframeAnimation::unanimatedStyle):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paint):
- * rendering/MediaControlElements.cpp:
- (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
- (WebCore::MediaControlInputElement::MediaControlInputElement):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleDidChange):
- (WebCore::RenderBlock::updateFirstLetter):
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::addChild):
- (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::updateFromElement):
- (WebCore::RenderFileUploadControl::createButtonStyle):
- * rendering/RenderFileUploadControl.h:
- * rendering/RenderFlow.cpp:
- (WebCore::RenderFlow::createAnonymousFlow):
- * rendering/RenderFlow.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::addChildToFlow):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateScrollCornerStyle):
- (WebCore::RenderLayer::updateResizerStyle):
- (WebCore::RenderLayer::updateReflectionStyle):
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::styleDidChange):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::createPanel):
- (WebCore::RenderMedia::createTimeDisplay):
- (WebCore::RenderMedia::changeOpacity):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::selectionBackgroundColor):
- (WebCore::RenderObject::selectionForegroundColor):
- (WebCore::RenderObject::createAnonymousBlock):
- (WebCore::RenderObject::setAnimatableStyle):
- (WebCore::RenderObject::setStyle):
- (WebCore::RenderObject::setStyleInternal):
- (WebCore::RenderObject::arenaDelete):
- (WebCore::RenderObject::firstLineStyle):
- (WebCore::RenderObject::getPseudoStyle):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::style):
- * rendering/RenderSVGBlock.cpp:
- (WebCore::RenderSVGBlock::setStyle):
- * rendering/RenderSVGBlock.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- * rendering/RenderScrollbar.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::styleDidChange):
- (WebCore::RenderSlider::createThumbStyle):
- (WebCore::RenderSlider::updateFromElement):
- * rendering/RenderSlider.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::addChild):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::addChild):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::addChild):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::styleDidChange):
- (WebCore::RenderTextControl::createInnerBlockStyle):
- (WebCore::RenderTextControl::createInnerTextStyle):
- (WebCore::RenderTextControl::createResultsButtonStyle):
- (WebCore::RenderTextControl::createCancelButtonStyle):
- (WebCore::RenderTextControl::createSubtreeIfNeeded):
- (WebCore::RenderTextControl::updatePlaceholderVisibility):
- * rendering/RenderTextControl.h:
- * rendering/TextControlInnerElements.cpp:
- (WebCore::TextControlInnerElement::attachInnerElement):
- * rendering/TextControlInnerElements.h:
- * rendering/style/KeyframeList.cpp:
- (WebCore::KeyframeList::clear):
- (WebCore::KeyframeList::operator==):
- (WebCore::KeyframeList::insert):
- * rendering/style/KeyframeList.h:
- (WebCore::KeyframeValue::KeyframeValue):
- (WebCore::KeyframeValue::~KeyframeValue):
- (WebCore::KeyframeValue::key):
- (WebCore::KeyframeValue::style):
- * rendering/style/RenderStyle.cpp:
- (WebCore::defaultStyle):
- (WebCore::RenderStyle::create):
- (WebCore::RenderStyle::createDefaultStyle):
- (WebCore::RenderStyle::clone):
- (WebCore::RenderStyle::RenderStyle):
- (WebCore::RenderStyle::getCachedPseudoStyle):
- (WebCore::RenderStyle::addCachedPseudoStyle):
- * rendering/style/RenderStyle.h:
- (WebCore::):
- (WebCore::InheritedFlags::operator!=):
- * svg/SVGClipPathElement.cpp:
- (WebCore::SVGClipPathElement::canvasResource):
- * svg/SVGGradientElement.cpp:
- (WebCore::SVGGradientElement::buildStops):
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::resolveStyle):
- * svg/SVGStyledElement.h:
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::recalcStyle):
- (WebCore::SVGUseElement::attachShadowTree):
-
-2008-10-16 Kenneth Russell <kenneth.russell@sun.com>
-
- Reviewed and landed by Anders Carlsson.
-
- https://bugs.webkit.org/show_bug.cgi?id=21587
- NPN_PluginThreadAsyncCall does not work properly
-
- * plugins/PluginMainThreadScheduler.cpp:
- (WebCore::PluginMainThreadScheduler::dispatchCalls):
- Make sure to set m_callPending to false once the queue has been cleared.
-
-2008-10-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21609
- Make MessagePorts protect their peers across heaps
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::MessagePort):
- * dom/MessagePort.h:
- (WebCore::MessagePort::setJSWrapperIsKnownToBeInaccessible):
- (WebCore::MessagePort::jsWrapperIsKnownToBeInaccessible):
- Track objects whose JS wrappers are no longer reachable in MessagePort. Unfortunately, this
- means that the implementation object knows about JS bindings - but it is not possible to
- access JS wrappers from another heap/thread.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::markCrossHeapDependentObjectsForDocument):
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::markCrossHeapDependentObjects):
- * bindings/js/JSDOMWindowBase.h:
- Implement cross-heap dependency tracking for entangled MessagePorts. If a wrapper object
- hasn't been marked normally, it is marked as inaccessible. It is then marked manually,
- as long as its entangled port is accessible itself.
-
-2008-10-15 Jon Honeycutt <jhoneycutt@apple.com>
-
- Remove unneeded check of whether a Page defers loading before running it
- in a modal dialog.
-
- No test possible.
-
- Reviewed by Tim Hatcher.
-
- * page/Chrome.cpp:
-
-2008-10-15 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
- Start the debugger without reloading the inspected page
-
- * WebCore.base.exp: New symbols.
-
- * ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
- * ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
- * WebCore.xcodeproj/project.pbxproj: New forwarding headers.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::setWindowVisible):
- (WebCore::InspectorController::windowScriptObjectAvailable):
- (WebCore::InspectorController::startDebugging):
- * inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage
- to startDebugging, and changed its behavior to match.
-
- * inspector/JavaScriptDebugListener.h:
- * inspector/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::JavaScriptDebugServer):
- (WebCore::JavaScriptDebugServer::addListener):
- (WebCore::JavaScriptDebugServer::removeListener):
- (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
- (WebCore::JavaScriptDebugServer::willAddFirstListener):
- (WebCore::JavaScriptDebugServer::didRemoveLastListener):
- * inspector/JavaScriptDebugServer.h: Refactored the
- JavaScriptDebugServer to centralize handling of adding the first listener
- and removing the last. Then, added a feature to recompile all JS functions
- in these cases. This allows us to dynamically add and remove hooks like
- the debugger hooks without reloading the page.
-
- * inspector/front-end/ScriptsPanel.js:
- * English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage =>
- startDebugging rename. Removed all UI that claimed that starting the
- debugger would reload the page.
-
-2008-10-15 Adele Peterson <adele@apple.com>
-
- Attempt to fix the Tiger build.
-
- * platform/network/mac/ResourceHandleMac.mm:
-
-2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix attempt.
-
- Try to fix static/non-static declaration of g_string_append_uri_escape
- by renaming that string. Another look needs to be taken.
-
- * platform/gtk/guriescape.c:
- (_webcore_g_string_append_uri_escaped):
- (_webcore_g_uri_escape_string):
-
-2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- m_animatingImageType is gone.
-
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
-
-2008-10-15 Jeff Cook <cookiecaper@gmail.com>
-
- Reviewed by Holger Freyther.
-
- Stop SIGSEGV when leaving a page with a Flash object by reordering
- window destruction and plugin stop.
-
- See https://bugs.webkit.org/show_bug.cgi?id=20779
-
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::stop):
-
-2008-10-15 Adele Peterson <adele@apple.com>
-
- Reviewed by Sam Weinig.
-
- Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.
-
- * platform/network/ResourceHandle.h:
- * platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::cancel):
- (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
- (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
- (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
- (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
-
-2008-10-15 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- Qt build bustage fix.
-
- * platform/graphics/qt/StillImageQt.h:
- (WebCore::StillImage::destroyDecodedData):
-
-2008-10-15 David Hyatt <hyatt@apple.com>
-
- Make sure scrollbar styles get deleted if they aren't assigned to a renderer.
-
- Reviewed by Mark Rowe
-
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- (WebCore::RenderScrollbar::updateScrollbarPart):
-
-2008-10-15 Peter Kasting <pkasting@google.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
- Account for paint and timer lag when animating images. Also pretend
- that images whose animations were paused (by becoming invisible)
- continued to animate, by "catching up" to the correct frame when they're
- shown again.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::destroyDecodedData):
- (WebCore::BitmapImage::cacheFrame):
- (WebCore::BitmapImage::frameIsCompleteAtIndex):
- (WebCore::BitmapImage::frameDurationAtIndex):
- (WebCore::BitmapImage::frameHasAlphaAtIndex):
- (WebCore::BitmapImage::repetitionCount):
- (WebCore::BitmapImage::shouldAnimate):
- (WebCore::BitmapImage::startAnimation):
- (WebCore::BitmapImage::resetAnimation):
- (WebCore::BitmapImage::advanceAnimation):
- (WebCore::BitmapImage::internalAdvanceAnimation):
- (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
- * platform/graphics/BitmapImage.h:
- (WebCore::FrameData::FrameData):
- (WebCore::BitmapImage::):
- * platform/graphics/GeneratedImage.h:
- (WebCore::GeneratedImage::destroyDecodedData):
- * platform/graphics/Image.h:
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::FrameData::clear):
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::draw):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::FrameData::clear):
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::draw):
- * platform/graphics/cg/PDFDocumentImage.h:
- (WebCore::PDFDocumentImage::destroyDecodedData):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::FrameData::clear):
- (WebCore::BitmapImage::draw):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::FrameData::clear):
- (WebCore::BitmapImage::draw):
- * svg/graphics/SVGImage.h:
- (WebCore::SVGImage::destroyDecodedData):
-
-2008-10-14 Maxime Britto <britto@apple.com>
-
- Reviewed by Darin Adler, tweaked and landed by Beth.
-
- * WebCore.base.exp: Exposes two functions to be able to create a
- selection from a point on the screen. Also exposes the new
- TextIterator::currentNode function.
- * WebCore/editing/TextIterator.cpp:
- (TextIterator::currentNode) : New function that returns the current
- text node or NULL if there is no text node.
-
-2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- http://bugs.webkit.org/show_bug.cgi?id=21211
- [CURL] Upload doesn't work because cancel is called
-
- FormDataStream::read returns 0 when retrieving data from the form
- fails, but also when there is no more data to send. This means that
- ResourceHandleManager::cancel is always called even when the data was
- successfully sent.
-
- Check if there are more elements in the form before calling
- FormDataStream::read.
-
- * platform/network/curl/FormDataStreamCurl.cpp:
- (WebCore::FormDataStream::hasMoreElements):
- * platform/network/curl/FormDataStreamCurl.h:
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::readCallback):
-
-2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- http://bugs.webkit.org/show_bug.cgi?id=20664
- [GTK] File names are not always encodable in UTF-8
-
- On Linux file names are just raw data and cannot always be directly
- encoded in UTF-8 or in any other encodings, so we escape them before
- storing the file name in a String and unescape them before passing
- them to native functions handling files.
-
- * GNUmakefile.am:
- * platform/FileSystem.h:
- * platform/gtk/FileChooserGtk.cpp:
- (WebCore::stringByAdoptingFileSystemRepresentation):
- (WebCore::FileChooser::basenameForWidth):
- * platform/gtk/FileSystemGtk.cpp:
- (WebCore::filenameToString):
- (WebCore::filenameFromString):
- (WebCore::filenameForDisplay):
- (WebCore::fileExists):
- (WebCore::deleteFile):
- (WebCore::deleteEmptyDirectory):
- (WebCore::getFileSize):
- (WebCore::getFileModificationTime):
- (WebCore::makeAllDirectories):
- (WebCore::homeDirectoryPath):
- (WebCore::pathGetFileName):
- (WebCore::listDirectory):
- * platform/gtk/KURLGtk.cpp:
- (WebCore::KURL::fileSystemPath):
- * platform/gtk/SharedBufferGtk.cpp:
- (WebCore::SharedBuffer::createWithContentsOfFile):
- * platform/gtk/guriescape.c: Added.
- (is_valid):
- (gunichar_ok):
- (g_string_append_uri_escaped):
- (_webcore_g_uri_escape_string):
- * platform/gtk/guriescape.h: Added.
-
-2008-10-15 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- - part of https://bugs.webkit.org/show_bug.cgi?id=20543
- Moved gradient spread method out of SVG into the GraphicsContext.
-
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::spreadMethod):
- (WebCore::GraphicsContext::setSpreadMethod):
- * platform/graphics/GraphicsContext.h:
- (WebCore::):
- * platform/graphics/GraphicsContextPrivate.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::applySpreadMethod):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::applySpreadMethod):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- * svg/GradientAttributes.h:
- (WebCore::GradientAttributes::GradientAttributes):
- (WebCore::GradientAttributes::spreadMethod):
- (WebCore::GradientAttributes::setSpreadMethod):
- * svg/SVGGradientElement.cpp:
- (WebCore::SVGGradientElement::parseMappedAttribute):
- * svg/SVGGradientElement.h:
- * svg/SVGLinearGradientElement.cpp:
- (WebCore::SVGLinearGradientElement::collectGradientProperties):
- * svg/SVGRadialGradientElement.cpp:
- (WebCore::SVGRadialGradientElement::collectGradientProperties):
- * svg/graphics/SVGPaintServerGradient.cpp:
- (WebCore::operator<<):
- (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
- (WebCore::SVGPaintServerGradient::spreadMethod):
- (WebCore::SVGPaintServerGradient::setGradientSpreadMethod):
- (WebCore::SVGPaintServerGradient::externalRepresentation):
- * svg/graphics/SVGPaintServerGradient.h:
- * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
- (WebCore::SVGPaintServerGradient::setup):
- * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
- (WebCore::SVGPaintServerGradient::setup):
-
-2008-10-09 Darin Fisher <darin@chromium.org>
-
- Reviewed by Sam Weinig.
-
- Make pan scrolling a platform configurable option
- https://bugs.webkit.org/show_bug.cgi?id=21515
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleAutoscroll):
- (WebCore::EventHandler::autoscrollTimerFired):
- (WebCore::EventHandler::stopAutoscrollTimer):
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::keyEvent):
-
-2008-10-10 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Add some PLATFORM(CHROMIUM) ifdefs to WebCore
- https://bugs.webkit.org/show_bug.cgi?id=21511
-
- * loader/FTPDirectoryDocument.cpp:
- * loader/FTPDirectoryParser.cpp:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::finishedLoadingDocument):
- * platform/ContextMenuItem.h:
- * platform/Cursor.h:
- * platform/DragData.h:
- * platform/DragImage.h:
- * platform/Pasteboard.h:
- * platform/PlatformKeyboardEvent.h:
- (WebCore::PlatformKeyboardEvent::isSystemKey):
- * platform/PlatformMenuDescription.h:
- * platform/PlatformMouseEvent.h:
- * platform/PlatformWheelEvent.h:
- * platform/PopupMenu.h:
- * platform/ScrollView.h:
- * platform/Widget.h:
- * platform/network/NetworkStateNotifier.h:
-
-2008-10-14 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
- Optimize keyframe style sheet changes by avoiding styleSheetChanged()
-
- Test: css3/change-keyframes.html
-
- * css/WebKitCSSKeyframesRule.cpp:
- (WebCore::WebKitCSSKeyframesRule::append):
- (WebCore::WebKitCSSKeyframesRule::deleteRule):
-
-2008-10-14 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21595
-
- Clean up background and overflow propagation from the body to the viewport. Make it match the
- latest CSS2.1 spec thinking.
-
- Reviewed by Adam Roben
-
- Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
- (available at http://simon.html5.org/test/css/magic-body/).
-
- * dom/Document.cpp:
- (WebCore::Document::body):
- * page/FrameView.cpp:
- (WebCore::FrameView::layout):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::styleDidChange):
- (WebCore::RenderBox::paintRootBoxDecorations):
- (WebCore::RenderBox::paintBoxDecorations):
- (WebCore::RenderBox::repaintLayerRectsForImage):
-
-2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
-
- Reviewed and landed by Sam Weinig.
-
- Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
- remove NSResolver code, leaving only checking for selectors that need
- NS resolution and throwing a coresponding error.
-
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSDocumentCustom.cpp:
- * bindings/js/JSDocumentFragmentCustom.cpp:
- * bindings/js/JSElementCustom.cpp:
- * bindings/js/JSNSResolver.cpp: Removed.
- * bindings/js/JSNSResolver.h: Removed.
* dom/Document.idl:
- * dom/DocumentFragment.idl:
* dom/Element.idl:
- * dom/NSResolver.h: Removed.
- * dom/NSResolver.idl: Removed.
- * dom/Node.h:
* dom/Node.cpp:
- (WebCore::forEachTagSelector):
- (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- (WebCore::selectorNeedsNamespaceResolution):
- (WebCore::Node::querySelector):
- (WebCore::Node::querySelectorAll):
-
-2008-10-14 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig (all but the FormDataListItem rename).
-
- - https://bugs.webkit.org/show_bug.cgi?id=21593
- Bug 21593: add multiple-file support to HTMLFormElement
-
- * html/FormDataList.cpp: Removed appendFile since it's now inline.
- Also took incorrect old copyrights off of this file that are left
- over from when it was split.
- * html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and
- made it a member of FormDataList. Changed it to hold a File object
- instead of a path. And made its data members private. Changed
- FormDataList::appendFile accordingly.
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::formData): Updated for above changes.
- Removed the code that special-cases HTMLInputElement, because now
- the FormDataListItem has everything we need. And if there are
- multiple files, we'll get multiple list items for them.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::appendFormData): Changed the code for
- <input type=file> to use File objects instead of path strings and
- also to append multiple files if the file list has them.
-
-2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Fix QtWebKit scrollbar painting errors
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::ScrollbarThemeQt::paint):
- (WebCore::ScrollbarThemeQt::paintScrollCorner):
-
-2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Fix scrollbar arrows for horizontal scrollbars
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
-
-2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Use style-painter to draw scrollbars in ScrollbarThemeQt
-
- This has the benefit of setting up the painter properly without
- antialiasing and saving and restoring the brush. It also ensures
- that we use the style of the QWebView over the QApplication style
- if possible.
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::StylePainter::StylePainter):
- (WebCore::StylePainter::init):
- * platform/qt/RenderThemeQt.h:
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::ScrollbarThemeQt::paint):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
- for how to add support for the rest.
-
- Reviewed by Oliver Hunt
-
- * page/animation/AnimationBase.cpp:
- (WebCore::ensurePropertyMap):
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::fillOpacity):
- (WebCore::RenderStyle::setFillOpacity):
- (WebCore::RenderStyle::strokeOpacity):
- (WebCore::RenderStyle::setStrokeOpacity):
- (WebCore::RenderStyle::floodOpacity):
- (WebCore::RenderStyle::setFloodOpacity):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- <rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.
-
- Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
- implements paintTrackBackground so that when the thumb is not present the track still paints.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::paintTrackBackground):
- * platform/win/ScrollbarThemeWin.h:
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Fix over-invalidation of native scrollbars.
-
- Reviewed by Oliver Hunt
-
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::styleChanged):
- * platform/mac/ScrollbarThemeMac.mm:
- (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::styleChanged):
-
-2008-10-13 Alp Toker <alp@nuanti.com>
-
- Fix autotools dist build target by listing recently added header
- files only. Not reviewed.
-
- * GNUmakefile.am:
-
-2008-10-13 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Brady Eidson.
-
- Don't run a SQLite query on every iteration of the sync thread when the query
- will touch a large portion of the icon database while performing no useful work.
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
- we modified the database.
- (WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
- unless we've been asked to prune any dangling pageURLs that we find.
-
-2008-10-13 Maciej Stachowiak <mjs@apple.com>
-
- Rubber stamped by Mark Rowe.
-
- - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
-
- * Configurations/DebugRelease.xcconfig:
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Make dropdown lists on Windows work with CSS custom scrollbars.
-
- Reviewed by Adele
-
- * platform/PopupMenu.h:
- (WebCore::PopupMenu::scrollbarCornerPresent):
- * platform/PopupMenuClient.h:
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::show):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::createScrollbar):
- * rendering/RenderMenuList.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::createScrollbar):
- * rendering/RenderTextControl.h:
-
-2008-10-13 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements
-
- Links from image maps were not being included in the web area's AXLinkUIElements attribute.
- The position of image map links was being reported incorrectly and the parent-chain
- hierarchy for image map links was incorrect because image map links did not have a reference
- to their parent image.
-
- Test: accessibility/document-links.html
-
- * page/AccessibilityImageMapLink.cpp:
- (WebCore::AccessibilityImageMapLink::parentObject):
- (WebCore::AccessibilityImageMapLink::actionElement):
- (WebCore::AccessibilityImageMapLink::elementRect):
- * page/AccessibilityImageMapLink.h:
- (WebCore::AccessibilityImageMapLink::setHTMLMapElement):
- (WebCore::AccessibilityImageMapLink::setParent):
- * page/AccessibilityObject.cpp:
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
- (WebCore::AccessibilityRenderObject::getDocumentLinks):
- (WebCore::AccessibilityRenderObject::addChildren):
- * page/AccessibilityRenderObject.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
- the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
- idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
-
- Reviewed by Tim Hatcher
-
- Added scrollbars/listbox-scrollbar-combinations.html
-
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::~RenderListBox):
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::createScrollbar):
- (WebCore::RenderListBox::destroyScrollbar):
- (WebCore::RenderListBox::setHasVerticalScrollbar):
- * rendering/RenderListBox.h:
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- In order to always match the :corner-present pseudo-class properly, delay initial updating of
- scrollbar styles until the layer has the scrollbars in its member variables.
-
- Reviewed by Tim Hatcher
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::setHasHorizontalScrollbar):
- (WebCore::RenderLayer::setHasVerticalScrollbar):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::RenderScrollbar):
-
-2008-10-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
- 5 false positive StructureID leaks
-
- In WebCore, we intentionally leak the common JSGlobalData which in turn
- leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
- ignore the StructureIDs leaked within.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::commonJSGlobalData):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
- artwork based on whether there is a scrollbar corner present.
-
- Reviewed by Tim Hatcher
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollbarCornerPresent):
- * platform/ScrollView.h:
- * platform/ScrollbarClient.h:
- * rendering/RenderLayer.cpp:
- (WebCore::cornerRect):
- (WebCore::scrollCornerRect):
- (WebCore::resizerCornerRect):
- (WebCore::RenderLayer::scrollbarCornerPresent):
- (WebCore::RenderLayer::setHasHorizontalScrollbar):
- (WebCore::RenderLayer::setHasVerticalScrollbar):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::horizontalScrollbar):
- (WebCore::RenderLayer::verticalScrollbar):
- * rendering/RenderListBox.h:
- (WebCore::RenderListBox::scrollbarCornerPresent):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
- test case for all this can land).
-
- Reviewed by Tim Hatcher
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::styleChanged):
- (WebCore::RenderLayer::updateScrollCornerStyle):
- (WebCore::RenderLayer::updateResizerStyle):
- * rendering/RenderLayer.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::paint):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::paintIntoRect):
-
-2008-10-13 David Hyatt <hyatt@apple.com>
-
- Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
- and invalidate properly as images load, etc.
-
- Reviewed by Tim Hatcher
-
- * rendering/RenderLayer.cpp:
- (WebCore::cornerRect):
- (WebCore::scrollCornerRect):
- (WebCore::resizerCornerRect):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::isPointInResizeControl):
- (WebCore::RenderLayer::hitTestOverflowControls):
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.h:
- (WebCore::RenderObject::setRect):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::styleDidChange):
- (WebCore::RenderScrollbarPart::imageChanged):
-
-2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Darin Adler. Landed by Jan Alonzo.
-
- WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
- http://bugs.webkit.org/show_bug.cgi?id=20483
-
- Start the conversion to use GOwnPtr and fix a memory leak.
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::mediaPlayerPrivateErrorCallback):
-
-2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>
-
- Windows build fix.
-
- * loader/TextResourceDecoder.cpp:
-
-2008-10-12 Darin Fisher <darin@chromium.org>
-
- Reviewed by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21229
- Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)
-
- * platform/network/NetworkStateNotifier.h: Add the #include.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Based on work by Holger Freyther.
-
- - part of https://bugs.webkit.org/show_bug.cgi?id=20953
- Split WidthIterator into its own source file.
-
- * GNUmakefile.am: Added new source files.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Ditto.
-
- * platform/graphics/Font.cpp: Use WidthIterator from its new place.
- * platform/graphics/WidthIterator.cpp: Added.
- * platform/graphics/WidthIterator.h: Added.
-
-2008-10-12 Tony Chang <tony@chromium.org>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21480
- Remove duplicate definitions of MimeClassInfo and PluginInfo.
-
- * plugins/PluginInfoStore.cpp: Added an include.
- * plugins/PluginInfoStore.h: Removed struct declarations.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21563
- Bug 21563: platform Gradient class should not use the CSS parser
-
- * platform/graphics/Gradient.cpp: Removed the overload of addColorStop
- that accepts a CSS color string. That's handled in the DOM now, not here.
- (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own
- copy of it here.
- * platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
-
-2008-10-12 Glenn Wilson <gwilson@google.com>
-
- Reviewed by Darin Adler.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20461
-
- Added feature to allow multi-line inputs into text fields.
- HTMLInputElement would cut the set text at the first 'system' character,
- so it would truncate at the first carriage return or newline.
- This fix modifies that behavior to truncate at any non-space system character
- but changes \r, \n, and \r\n to a single space.
-
- Tests: editing/pasteboard/paste-multiline-text-input.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::constrainValue):
-
-2008-10-12 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20435
-
- Added exception codes to canvas gradients to match current specification.
-
- Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html
- fast/canvas/linearGradient-infinite-values.html
- fast/canvas/radialGradient-infinite-values.html
-
- * html/CanvasGradient.cpp:
- (WebCore::CanvasGradient::addColorStop):
- * html/CanvasGradient.h:
- * html/CanvasGradient.idl:
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::createLinearGradient):
- (WebCore::CanvasRenderingContext2D::createRadialGradient):
- * html/CanvasRenderingContext2D.h:
- * html/CanvasRenderingContext2D.idl:
-
-2008-10-12 Eric Roman <eroman@chromium.org>
-
- - https://bugs.webkit.org/show_bug.cgi?id=20246
- Implement RenderThemeWin::systemColor() to match Windows colors.
-
- Reviewed by David Hyatt.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::cssValueIdToSysColorIndex):
- (WebCore::RenderThemeWin::systemColor):
- * rendering/RenderThemeWin.h:
-
-2008-10-12 Aaron Bockover <abockover@novell.com>
-
- Reviewed by Alp Toker.
-
- Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
- plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
- handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>
-
- * plugins/gtk/PluginPackageGtk.cpp:
-
-2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
-
- Reviewed by Oliver Hunt.
-
- - https://bugs.webkit.org/show_bug.cgi?id=19331
- <rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()
-
- * page/DragController.cpp:
- (WebCore::DragController::startDrag): When a link is dragged without any
- text selected (note: for this to work, the EditableLinkBehavior setting must be
- set to 'live' or 'default') and then dropped into an editable html document it
- will eventually violate an ASSERT in MoveSelectionCommand that requires that there
- is a selection. To prevent this, expand the selection to the enclosing anchor tag
- when the drag begins.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21557
- Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain
- until we hit an Element. Nowadays, Node::isElementNode() is just as efficient
- as RenderObject::isText(), and this guarantees that the node can be cast to
- Element*, which is done just below. The reason this is hit is that RenderLayer
- can call getPseudoStyle on a RenderView, which has the document as its
- element() -- and a document is neither a Text node nor an Element. A loose
- end is that this seems to mean you can't style the scrollbar corner or the
- resizer on a RenderView. Hyatt may want to look into that later.
-
-2008-10-12 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21556
- Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
-
- Tests: fast/dom/HTMLFontElement/size-attribute.html
- fast/dom/HTMLInputElement/size-attribute.html
- fast/dom/HTMLTableElement/cellpadding-attribute.html
-
- * html/HTMLFontElement.cpp:
- (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of
- Unicode::isDigit, since non-ASCII digits are not valid here.
- * html/HTMLFontElement.h: Tweaked formatting a bit and removed
- the unneeded destructor declaration.
- * platform/text/String.cpp:
- (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead
- of Unicode::isDigit, since non-ASCII digits are not valid.
-
-2008-10-12 Jungshik Shin <jshin@chromium.org>
-
- Reviewed by Darin Adler.
-
- Treat x-user-defined as windows-1252 for html files with meta charset
- declaration to be compatible with Indian web sites.
- ( https://bugs.webkit.org/show_bug.cgi?id=18270 )
-
- Test: fast/encoding/charset-xuser-defined.html
-
- * loader/TextResourceDecoder.cpp:
- (WebCore::TextResourceDecoder::setEncoding):
-
-2008-10-12 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Remove unneeded forward declaration.
-
- * platform/graphics/ImageBuffer.h:
+ * dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared
+ virtual, since their behavior for HTMLBodyElement differs from the base
+ implementation.
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::onblur):
+ (WebCore::HTMLBodyElement::setOnblur):
+ (WebCore::HTMLBodyElement::onerror):
+ (WebCore::HTMLBodyElement::setOnerror):
+ (WebCore::HTMLBodyElement::onfocus):
+ (WebCore::HTMLBodyElement::setOnfocus):
+ (WebCore::HTMLBodyElement::onload):
+ (WebCore::HTMLBodyElement::setOnload):
+ (WebCore::HTMLBodyElement::onbeforeunload):
+ (WebCore::HTMLBodyElement::setOnbeforeunload):
+ (WebCore::HTMLBodyElement::onmessage):
+ (WebCore::HTMLBodyElement::setOnmessage):
+ (WebCore::HTMLBodyElement::onoffline):
+ (WebCore::HTMLBodyElement::setOnoffline):
+ (WebCore::HTMLBodyElement::ononline):
+ (WebCore::HTMLBodyElement::setOnonline):
+ (WebCore::HTMLBodyElement::onresize):
+ (WebCore::HTMLBodyElement::setOnresize):
+ (WebCore::HTMLBodyElement::onstorage):
+ (WebCore::HTMLBodyElement::setOnstorage):
+ (WebCore::HTMLBodyElement::onunload):
+ (WebCore::HTMLBodyElement::setOnunload):
+ * html/HTMLBodyElement.h:
+ * html/HTMLBodyElement.idl:
-2008-10-12 Sam Weinig <sam@webkit.org>
+2009-06-22 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
- Layering violation: String should not be responsible for creating Lengths
+ https://bugs.webkit.org/show_bug.cgi?id=26601
+ Remove disabled code for appcache dynamic entries
- It was a layering violation for String to know haw to parse
- into Lengths, LengthArrays, and CoordsArrays.
+ This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.
+ * DerivedSources.cpp:
+ * DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- * html/HTMLAreaElement.cpp:
- (WebCore::HTMLAreaElement::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * platform/text/AtomicString.h:
- (WebCore::AtomicString::percentage):
- * platform/text/PlatformString.h:
- * platform/text/String.cpp:
- * platform/text/StringImpl.cpp:
- * platform/text/StringImpl.h:
- * rendering/Length.cpp: Added.
- (WebCore::parseLength):
- (WebCore::countCharacter):
- (WebCore::newCoordsArray):
- (WebCore::newLengthArray):
- * rendering/Length.h:
- (WebCore::LengthSize::LengthSize):
-
-2008-10-12 Brad Garcia <bgarcia@google.com>
-
- Reviewed by Darin Adler.
-
- Interpret fractional percentage values for %MultiLength values.
- Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
- Test: fast/frames/frame-length-fractional-percentage.html
-
- * platform/text/StringImpl.cpp:
- (WebCore::parseLength):
-
-2008-10-12 Timothy Hatcher <timothy@apple.com>
-
- Remember the expanded state of the rules in the Styles pane. So
- collapsing a rule will persist across all the elements that have
- that same rule. The same applies to Computed Style, so the Computed
- Style rule is now collapsed by default. This should help lessen the
- confusion on why Computed Style can't be edited (a common confusion.)
-
- https://bugs.webkit.org/show_bug.cgi?id=21553
-
- Reviewed by Darin Adler.
-
- * inspector/front-end/PropertiesSection.js:
- (WebInspector.PropertiesSection): Set the _expanded property directly,
- instead of using the setter. Expanded is the default, so no work is needed.
- This prevents calling StylesSidebarPane.collapse before object initialization
- is complete.
- * inspector/front-end/StylesSidebarPane.js:
- (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object
- for the expanded state of the StylePropertiesSection. Collapse computed style
- by default and expand everything else.
- (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used
- when remembering expanded state.
- (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state
- to true for this identifier in Preferences.styleRulesExpandedState. Don't remember
- the state if the dontRememberState property is true.
- (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state
- to false for this identifier in Preferences.styleRulesExpandedState.
- * inspector/front-end/inspector.js:
- (Preferences.styleRulesExpandedState): Initialize to an empty object.
-
-2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Alp Toker.
-
- [Gtk] Remove libWebCoreJS.la when doing make clean
- https://bugs.webkit.org/show_bug.cgi?id=21544
-
- Remove libWebCoreJS.la when doing a clean target
-
- * GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
-
-2008-10-11 Alp Toker <alp@nuanti.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20592
- The focus ring is not shown while navigating on some pages
-
- Fix drawFocusRing() so it doesn't depend on the current graphics
- state, thus matching other platforms which already work this way.
-
- This patch provides two code paths: one using straight Cairo and
- one specialised for the GTK+ port with a more conventional appearance.
-
- Also change focusRingColor() to return a null color, allowing the
- focus ring to pick up the style's current color if it isn't overridden
- with CSS.
-
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::drawFocusRing):
- * platform/gtk/TemporaryLinkStubs.cpp:
- (WebCore::focusRingColor):
-
-2008-10-11 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- - change all internal callers to use Cache::evict() instead of remove()
-
- * loader/Cache.cpp:
- (WebCore::Cache::revalidateResource):
- (WebCore::Cache::revalidationSucceeded):
- (WebCore::Cache::pruneDeadResources):
- (WebCore::Cache::setDisabled):
-
-2008-10-11 David Hyatt <hyatt@apple.com>
-
- Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::invalidatePart):
-
-2008-10-11 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).
-
- Also fixed resizer positioning problems.
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::splitTrack):
- (WebCore::ScrollbarThemeComposite::trackPosition):
- (WebCore::ScrollbarThemeComposite::trackLength):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
- * rendering/RenderLayer.cpp:
- (WebCore::scrollCornerRect):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::isPointInResizeControl):
- (WebCore::RenderLayer::hitTestOverflowControls):
- * rendering/RenderScrollbarTheme.cpp:
- (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
- * rendering/RenderScrollbarTheme.h:
-
-2008-10-11 Alp Toker <alp@nuanti.com>
-
- Reviewed by David Hyatt.
-
- Implement release/retain for Widget GTK+.
-
- * platform/Widget.cpp:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::~Widget):
- (WebCore::Widget::releasePlatformWidget):
- (WebCore::Widget::retainPlatformWidget):
-
-2008-10-11 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
- and add a corresponding getter; add the same functions on Windows
-
- * WebCore.base.exp:
- * platform/graphics/Font.cpp:
- (WebCore::Font::setCodePath):
- (WebCore::codePath):
- (WebCore::Font::canUseGlyphCache):
- * platform/graphics/Font.h:
- * platform/mac/WebCoreTextRenderer.h:
- * platform/mac/WebCoreTextRenderer.mm:
- (WebCoreSetAlwaysUsesComplexTextCodePath):
- (WebCoreAlwaysUsesComplexTextCodePath):
- * platform/win/WebCoreTextRenderer.cpp:
- (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
- (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
- * platform/win/WebCoreTextRenderer.h:
-
-2008-10-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Stop leaking the event parameter names. The protected strings were showing up
- in the caches window after one use. No measurable performance loss.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::eventParameterName):
-
-2008-10-11 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Remove unused function getNodeEventListener.
-
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventListener.h:
-
-2008-10-11 David Hyatt <hyatt@apple.com>
-
- Add support for both positive and negative margins to tracks and track pieces.
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::hitTest):
- (WebCore::ScrollbarThemeComposite::splitTrack):
- (WebCore::ScrollbarThemeComposite::trackPieceRects):
- (WebCore::ScrollbarThemeComposite::trackPosition):
- (WebCore::ScrollbarThemeComposite::trackLength):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::trackRect):
- (WebCore::RenderScrollbar::trackPieceRectWithMargins):
- * rendering/RenderScrollbar.h:
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::computeScrollbarWidth):
- (WebCore::RenderScrollbarPart::computeScrollbarHeight):
- * rendering/RenderScrollbarTheme.cpp:
- (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
- * rendering/RenderScrollbarTheme.h:
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
- the scrollbar pseudo-elements anyway.
-
- Reviewed by Tim Hatcher
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
-
-2008-10-10 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - separate Cache::remove() into a private method and a public interface,
- then make Cache::pruneDeadResources() use the private method.
-
- * loader/Cache.cpp:
- (WebCore::Cache::pruneDeadResources):
- (WebCore::Cache::evict):
- * loader/Cache.h:
- (WebCore::Cache::remove):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
- now that the track pieces meet under the thumb.
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::splitTrack):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::hitTest):
- (WebCore::ScrollbarThemeComposite::splitTrack):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.
-
- Reviewed by Tim Hatcher
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createScrollbar):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::createCustomScrollbar):
- (WebCore::RenderScrollbar::RenderScrollbar):
- (WebCore::RenderScrollbar::setParent):
- (WebCore::RenderScrollbar::updateScrollbarParts):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- * rendering/RenderScrollbar.h:
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Make sure scrollbar background images cause proper part invalidation to occur.
-
- Reviewed by Tim Hatcher
-
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::setHoveredPart):
- (WebCore::RenderScrollbar::setPressedPart):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::styleDidChange):
- (WebCore::RenderScrollbarPart::imageChanged):
- * rendering/RenderScrollbarPart.h:
-
-2008-10-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=21538
-
- The blendFunc() for TransformOperations should never mess with the
- operation lists by replacing some ops with identity, otherwise the lists
- no longer match and transitions break.
-
- Test: transitions/matched-transform-functions.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
-
-2008-10-10 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Darin Adler
-
- https://bugs.webkit.org/show_bug.cgi?id=21537
-
- Fix re-targetting a running transition; if the target property
- changes, we do need to make a new ImplicitAnimation.
-
- Test: transitions/retargetted-transition.html
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::updateTransitions):
-
-2008-10-10 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion.
-
- When JS is terminated by the user choosing to stop a slow script
- the exception toString method throws, yet the console logger does
- not perform exception checks after logging. This leaves an
- exception on the Machine, which in turn results in an assertion
- failure next time we attempt to enter JS. The solution is just to
- clear the exception state after attempting to record the exception.
-
- * page/Console.cpp:
- (WebCore::Console::reportException):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
- when looking for pseudo styles.
-
- Reviewed by Tim Hatcher
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::styleChanged):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Add the ability to style the scroll corner and the resizer from CSS.
-
- Reviewed by Tim Hatcher
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::~RenderLayer):
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::paintScrollCorner):
- (WebCore::RenderLayer::paintResizer):
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::updateScrollbarPart):
- (WebCore::RenderScrollbar::paintPart):
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::RenderScrollbarPart):
- (WebCore::RenderScrollbarPart::paintIntoRect):
- * rendering/RenderScrollbarPart.h:
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Make CSS scrollbars respect the OS setting regarding where buttons should be placed.
-
- Reviewed by Sam Weinig
-
- No test case possible, since the OS setting can vary.
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::styleChanged):
- * platform/mac/ScrollbarThemeMac.mm:
- (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
- (WebCore::ScrollbarThemeMac::preferencesChanged):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::invalidateScrollbarRect):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::styleChanged):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- * rendering/RenderScrollbar.h:
- * rendering/RenderScrollbarTheme.h:
- (WebCore::RenderScrollbarTheme::buttonsPlacement):
-
-2008-10-10 Timothy Hatcher <timothy@apple.com>
-
- Fixes a regression with input search fields, where the placeholder text
- would not be updated when the value of the placeholder attribute changed.
-
- https://bugs.webkit.org/show_bug.cgi?id=21521
-
- Reviewed by Adele Peterson.
-
- Test: fast/forms/search-placeholder-value-changed.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
- placeholderValueChanged parameter of updatePlaceholderVisibility.
- (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
- for placeholderValueChanged that informs the method that the value changed.
- * html/HTMLInputElement.h: Add the placeholderValueChanged to the
- updatePlaceholderVisibility method. Made it default to false.
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- Allow the track part to have negative margins so that it can slightly overlap buttons. This
- is necessary to emulate the Aqua look in CSS.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::hitTest):
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::setHoveredPart):
- (WebCore::RenderScrollbar::trackRect):
- * rendering/RenderScrollbar.h:
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::computeScrollbarWidth):
- (WebCore::RenderScrollbarPart::computeScrollbarHeight):
- * rendering/RenderScrollbarTheme.cpp:
- (WebCore::RenderScrollbarTheme::backButtonRect):
- (WebCore::RenderScrollbarTheme::forwardButtonRect):
- (WebCore::RenderScrollbarTheme::trackRect):
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21527
-
- Make CSS scrollbars support :not, :hover and :active.
-
- Reviewed by Adam Roben
-
- Added WebCore/manual-tests/scrollbar-hover-active.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::autoscrollPressedPart):
- (WebCore::Scrollbar::startTimerIfNeeded):
- (WebCore::Scrollbar::setHoveredPart):
- (WebCore::Scrollbar::setPressedPart):
- (WebCore::Scrollbar::mouseMoved):
- (WebCore::Scrollbar::mouseExited):
- (WebCore::Scrollbar::mouseUp):
- (WebCore::Scrollbar::mouseDown):
- * platform/Scrollbar.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::setHoveredPart):
- (WebCore::RenderScrollbar::setPressedPart):
- (WebCore::RenderScrollbar::updateScrollbarParts):
- (WebCore::pseudoForScrollbarPart):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- * rendering/RenderScrollbar.h:
-
-2008-10-10 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
- CSS transition with duration=0 and delay=0 doesn't override ongoing transition
-
- Test: transitions/interrupt-zero-duration.html
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
-
-2008-10-10 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Add new scrollbar-related sources.
-
- * WebCoreSources.bkl:
-
-2008-10-10 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21522
-
- Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
- created. (Just :hover/:active left to finish it up.)
+ * bindings/js/JSDOMStringListCustom.cpp: Removed.
+ * bindings/v8/custom/V8CustomBinding.h:
+ * bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
+ * dom/DOMStringList.cpp: Removed.
+ * dom/DOMStringList.h: Removed.
+ * dom/DOMStringList.idl: Removed.
+ * dom/StaticStringList.cpp: Removed.
+ * dom/StaticStringList.h: Removed.
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::addResource):
+ * loader/appcache/ApplicationCache.h:
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
+ * loader/appcache/ApplicationCacheResource.cpp:
+ (WebCore::ApplicationCacheResource::dumpType):
+ * loader/appcache/ApplicationCacheResource.h:
+ (WebCore::ApplicationCacheResource::):
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::storeUpdatedType):
+ * loader/appcache/DOMApplicationCache.cpp:
+ * loader/appcache/DOMApplicationCache.h:
+ * loader/appcache/DOMApplicationCache.idl:
+ * page/DOMWindow.idl:
- Reviewed by Adam Roben
+2009-06-22 Steve Falkenburg <sfalken@apple.com>
- Added scrollbars/scrollbar-buttons.html
+ Windows build fix.
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * DerivedSources.cpp:
+ * html/HTMLElementsAllInOne.cpp:
-2008-10-10 David Hyatt <hyatt@apple.com>
+2009-06-22 Alexey Proskuryakov <ap@webkit.org>
- Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
- back/forward to decrement/increment. Adding start/end pseudoclasses.
+ Reviewed by John Sullivan.
- Reviewed by Eric Seidel
+ <rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
+ Japanese can't be input.
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ WebKit uses a per-frame input context for most editable fields, and application's global
+ context for password fields, manually controlling secure input state and the list of available
+ input sources.
-2008-10-10 David Hyatt <hyatt@apple.com>
+ We were setting TSMDocument property to disable non-Roman input methods after focus changed
+ to a password field, but before selection was updated. This resulted in the property being
+ applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
+ context cached by +[NSApplication updateWindows], we change context based on selection,
+ not on focus.
- Switch window-active to window-inactive, since that will work better as far as degrading in other
- browsers.
+ * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one
+ context that we use for password fields - the global one - there is no need to get the active
+ one.
- Reviewed by Tim Hatcher
+2009-06-22 David Levin <levin@chromium.org>
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ Reviewed by David Hyatt and Eric Seidel.
-2008-10-09 Chris Marrin <cmarrin@apple.com>
+ REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
+ https://bugs.webkit.org/show_bug.cgi?id=26326
- Reviewed by Dan Bernstein.
+ Test: scrollbars/scrollbar-crash-on-refresh.html
- https://bugs.webkit.org/show_bug.cgi?id=21310
-
- Redesigned how animation events are sent in order to get rid of
- AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
- are now ref counted. While calling the event handler, I keep a
- reference to this class to avoid it getting destroyed out from under me.
-
- I also moved most of the functionality of CompositeAnimation to
- and internal class (CompositeAnimationPrivate) to reduce the exposure
- of the internals of the various animation classes.
-
- We have several transition and animation LayoutTests which verify that
- this fix works as expected and continues to avoid crashes.
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::AnimationBase):
- * page/animation/AnimationBase.h:
- (WebCore::AnimationBase::cancelTimers):
- (WebCore::AnimationBase::waitingForStyleAvailable):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
- (WebCore::CompositeAnimationPrivate::suspended):
- (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
- (WebCore::CompositeAnimationPrivate::updateTransitions):
- (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
- (WebCore::CompositeAnimationPrivate::animate):
- (WebCore::CompositeAnimationPrivate::setAnimating):
- (WebCore::CompositeAnimationPrivate::animating):
- (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
- (WebCore::CompositeAnimationPrivate::resetTransitions):
- (WebCore::CompositeAnimationPrivate::resetAnimations):
- (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
- (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
- (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
- (WebCore::CompositeAnimationPrivate::suspendAnimations):
- (WebCore::CompositeAnimationPrivate::resumeAnimations):
- (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
- (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
- (WebCore::compareAnimationIndices):
- (WebCore::CompositeAnimationPrivate::styleAvailable):
- (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
- (WebCore::CompositeAnimationPrivate::setWaitingForStyleAvailable):
- (WebCore::CompositeAnimation::CompositeAnimation):
- (WebCore::CompositeAnimation::~CompositeAnimation):
- (WebCore::CompositeAnimation::animate):
- (WebCore::CompositeAnimation::animating):
- (WebCore::CompositeAnimation::setWaitingForStyleAvailable):
- (WebCore::CompositeAnimation::resetTransitions):
- (WebCore::CompositeAnimation::suspendAnimations):
- (WebCore::CompositeAnimation::resumeAnimations):
- (WebCore::CompositeAnimation::suspended):
- (WebCore::CompositeAnimation::styleAvailable):
- (WebCore::CompositeAnimation::setAnimating):
- (WebCore::CompositeAnimation::isAnimatingProperty):
- (WebCore::CompositeAnimation::setAnimationStartTime):
- (WebCore::CompositeAnimation::setTransitionStartTime):
- (WebCore::CompositeAnimation::overrideImplicitAnimations):
- (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/ImplicitAnimation.h:
- (WebCore::ImplicitAnimation::create):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- * page/animation/KeyframeAnimation.h:
- (WebCore::KeyframeAnimation::create):
-
-2008-10-09 David Hyatt <hyatt@apple.com>
-
- Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
- is active as well.
-
- Reviewed by Tim Hatcher
-
- Added scrollbars/scrollbar-orientation.html
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::isWindowActive):
+ * dom/Document.cpp:
+ (WebCore::Document::detach):
+ Gives the FrameView a change to do any necessary cleanup on
+ Document::detach() which is where the renderArena gets detroyed.
+ * page/FrameView.cpp:
+ (WebCore::FrameView::detachCustomScrollbars):
+ Gets rid of any custom scrollbars (if the docment supplied them).
+ * page/FrameView.h:
* platform/Scrollbar.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::paint):
- (WebCore::RenderScrollbar::partForStyleResolve):
- * rendering/RenderScrollbar.h:
-
-2008-10-09 David Hyatt <hyatt@apple.com>
-
- Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
- :enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.
-
- Reviewed by Tim Hatcher
-
- Added scrollbars/disabled-scrollbar.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- * css/CSSStyleSelector.h:
+ (WebCore::Scrollbar::isCustomScrollbar):
* rendering/RenderObject.cpp:
- (WebCore::RenderObject::getPseudoStyle):
- * rendering/RenderObject.h:
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::setEnabled):
- (WebCore::RenderScrollbar::scrollbarForStyleResolve):
- (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- (WebCore::RenderScrollbar::paintPart):
+ (WebCore::RenderObject::destroy):
+ Removed the check for document()->frame(). If frame() is 0 in this code,
+ then the call to animation() is also incorrect (since it does document()->frame()->animation()).
* rendering/RenderScrollbar.h:
+ (WebCore::RenderScrollbar::isCustomScrollbar):
-2008-10-09 Eric Carlson <eric.carlson@apple.com>
-
- Media controls should not show when element is not visible
-
- https://bugs.webkit.org/show_bug.cgi?id=21155
-
- Reviewed by Adele Peterson.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
- in sync with visibility changes
- * html/HTMLMediaElement.h:
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
- (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
- if element is visible or not. Don't animate controller visibility when change triggered by
- showing or hiding media element.
- * rendering/RenderMedia.h: declare m_previousVisible
-
-2008-10-09 Timothy Hatcher <timothy@apple.com>
-
- Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
- availability macros and version macros.
-
- https://bugs.webkit.org/show_bug.cgi?id=21496
- rdar://problem/6259225
-
- Reviewed by Sam Weinig.
-
- * bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
- * bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
- and add an #if around the enum.
- * bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
- comment to match the other headers.
- * bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
- * bindings/objc/DOMObject.h: Add a version #if around class interface.
- * bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
- and add a version #if around the enum.
- * bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
- * bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
- * bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
- when they where added to WebKit. Also annotate individual methods that are
- deprecated or where added after the class was added to WebKit.
- * bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
- since this header is included by most DOM headers. Annotate the JSObject method.
-
- * bindings/scripts/CodeGeneratorObjC.pm:
- (ReadPublicInterfaces): Parse out the availability macro for each function/property.
- And parse out the availability version for the class/protocol. Default to
- WEBKIT_VERSION_LATEST if the class is new.
- (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
- interface availability version check if the class has a required version. Create
- a public interface key (used to lookup in $publicInterfaces) and make a declaration
- suffix that includes the availability macro (if needed). Use the "available in 1.3
- and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
- the default availability macro for old style methods. Tweak line breaks in the generated
- headers to look good and not have too many extra lines.
-
-2008-10-09 Simon Fraser <simon.fraser@apple.com>
+2009-06-22 Dan Bernstein <mitz@apple.com>
- Reviewed by Dave Hyatt
+ Reviewed by Simon Fraser.
- https://bugs.webkit.org/show_bug.cgi?id=20947
+ - fix https://bugs.webkit.org/show_bug.cgi?id=23606
+ <rdar://problem/6537777> CSS gradient not repainted when image load
+ completes
- Refactor setStyle() methods into styleWillChange()
- and styleDidChange(), so most of the setStyle() overrides can
- be removed.
+ Test: fast/repaint/background-generated.html
- * rendering/RenderBR.cpp:
- (WebCore::RenderBR::styleDidChange):
- * rendering/RenderBR.h:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::styleWillChange):
- (WebCore::RenderBlock::styleDidChange):
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::~RenderBox):
- (WebCore::RenderBox::destroy):
- (WebCore::RenderBox::styleWillChange):
- (WebCore::RenderBox::styleDidChange):
- * rendering/RenderBox.h:
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::styleWillChange):
- (WebCore::RenderButton::styleDidChange):
- * rendering/RenderButton.h:
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::styleDidChange):
- * rendering/RenderFieldset.h:
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::styleDidChange):
- * rendering/RenderFileUploadControl.h:
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::styleDidChange):
- * rendering/RenderInline.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::styleDidChange):
- * rendering/RenderListBox.h:
- * rendering/RenderListItem.cpp:
- (WebCore::RenderListItem::styleDidChange):
- * rendering/RenderListItem.h:
- * rendering/RenderListMarker.cpp:
- (WebCore::RenderListMarker::styleWillChange):
- (WebCore::RenderListMarker::styleDidChange):
- * rendering/RenderListMarker.h:
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::styleDidChange):
- * rendering/RenderMenuList.h:
* rendering/RenderObject.cpp:
- (WebCore::RenderObject::setStyle):
- (WebCore::RenderObject::setStyleInternal):
- (WebCore::RenderObject::styleWillChange):
- (WebCore::RenderObject::styleDidChange):
- * rendering/RenderObject.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::styleDidChange):
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGGradientStop.cpp:
- (WebCore::RenderSVGGradientStop::styleDidChange):
- * rendering/RenderSVGGradientStop.h:
- * rendering/RenderScrollbarPart.cpp:
- (WebCore::RenderScrollbarPart::styleDidChange):
- * rendering/RenderScrollbarPart.h:
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::styleDidChange):
- * rendering/RenderSlider.h:
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::styleDidChange):
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::styleWillChange):
- (WebCore::RenderTableCell::styleDidChange):
- * rendering/RenderTableCell.h:
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::styleWillChange):
- * rendering/RenderTableRow.h:
- * rendering/RenderText.cpp:
- (WebCore::RenderText::styleDidChange):
- * rendering/RenderText.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::styleDidChange):
- * rendering/RenderTextControl.h:
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::styleDidChange):
- * rendering/RenderWidget.h:
-
-2008-10-09 David Hyatt <hyatt@apple.com>
-
- Make sure to destroy a custom scrollbar's RenderObjects before the arena goes away. When our widget
- parent is nulled out is a good time.
-
- Reviewed by Oliver Hunt
-
- * rendering/RenderScrollbar.cpp:
- (WebCore::RenderScrollbar::~RenderScrollbar):
- (WebCore::RenderScrollbar::setParent):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- * rendering/RenderScrollbar.h:
-
-2008-10-09 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21446
-
- This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
- orientation and back vs. forward on the buttons, but it's a start.
+ (WebCore::mustRepaintFillLayers): Return true if the layer does not
+ specify a size and the image uses the container size.
- Reviewed by Oliver Hunt
-
- Added scrollbars/basic-scrollbar.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- * platform/ScrollTypes.h:
- (WebCore::):
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::styleChanged):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::splitTrack):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
- (WebCore::ScrollbarThemeComposite::paintTrackBackground):
- (WebCore::ScrollbarThemeComposite::paintTrackPiece):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarThemeSafari::paintTrackBackground):
- * platform/win/ScrollbarThemeSafari.h:
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::paintTrack):
- * platform/win/ScrollbarThemeWin.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderScrollbar.cpp: Added.
- (WebCore::RenderScrollbar::createCustomScrollbar):
- (WebCore::RenderScrollbar::RenderScrollbar):
- (WebCore::RenderScrollbar::~RenderScrollbar):
- (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
- (WebCore::RenderScrollbar::updateScrollbarParts):
- (WebCore::RenderScrollbar::updateScrollbarPart):
- (WebCore::RenderScrollbar::paintPart):
- (WebCore::RenderScrollbar::buttonRect):
- (WebCore::RenderScrollbar::minimumThumbLength):
- * rendering/RenderScrollbar.h: Added.
- (WebCore::RenderScrollbar::styleChanged):
- (WebCore::RenderScrollbar::owningRenderer):
- * rendering/RenderScrollbarPart.cpp: Added.
- (WebCore::RenderScrollbarPart::RenderScrollbarPart):
- (WebCore::RenderScrollbarPart::~RenderScrollbarPart):
- (WebCore::RenderScrollbarPart::layout):
- (WebCore::RenderScrollbarPart::layoutHorizontalPart):
- (WebCore::RenderScrollbarPart::layoutVerticalPart):
- (WebCore::calcScrollbarThicknessUsing):
- (WebCore::RenderScrollbarPart::computeScrollbarWidth):
- (WebCore::RenderScrollbarPart::computeScrollbarHeight):
- (WebCore::RenderScrollbarPart::calcPrefWidths):
- (WebCore::RenderScrollbarPart::setStyle):
- * rendering/RenderScrollbarPart.h: Added.
- (WebCore::RenderScrollbarPart::renderName):
- (WebCore::RenderScrollbarPart::requiresLayer):
- * rendering/RenderScrollbarTheme.cpp: Added.
- (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
- (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
- (WebCore::RenderScrollbarTheme::hasButtons):
- (WebCore::RenderScrollbarTheme::hasThumb):
- (WebCore::RenderScrollbarTheme::minimumThumbLength):
- (WebCore::RenderScrollbarTheme::backButtonRect):
- (WebCore::RenderScrollbarTheme::forwardButtonRect):
- (WebCore::RenderScrollbarTheme::trackRect):
- (WebCore::RenderScrollbarTheme::paintScrollCorner):
- (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
- (WebCore::RenderScrollbarTheme::paintTrackBackground):
- (WebCore::RenderScrollbarTheme::paintTrackPiece):
- (WebCore::RenderScrollbarTheme::paintButton):
- (WebCore::RenderScrollbarTheme::paintThumb):
- * rendering/RenderScrollbarTheme.h: Added.
- (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
- (WebCore::RenderScrollbarTheme::scrollbarThickness):
- (WebCore::RenderScrollbarTheme::buttonsPlacement):
- (WebCore::RenderScrollbarTheme::supportsControlTints):
- (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
- (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
- (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
- (WebCore::RenderScrollbarTheme::registerScrollbar):
- (WebCore::RenderScrollbarTheme::unregisterScrollbar):
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::):
-
-2008-10-09 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix Canvex DOOM Game
- Gradient clips were not getting cleared after filling the
- gradient, this was causing nothing to draw in Canvex
- https://bugs.webkit.org/show_bug.cgi?id=21498
-
- Tests forthcoming.
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
+2009-06-22 David Hyatt <hyatt@apple.com>
-2008-10-09 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix transformed patterns
- https://bugs.webkit.org/show_bug.cgi?id=21498
-
- Test: fast/canvas/patternfill-repeat.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::setStrokePattern):
- (WebCore::GraphicsContext::setFillPattern):
- (WebCore::GraphicsContext::setStrokeGradient):
- (WebCore::GraphicsContext::setFillGradient):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::applyStrokePattern):
- (WebCore::applyFillPattern):
- (WebCore::GraphicsContext::drawPath):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- * platform/graphics/wx/GraphicsContextWx.cpp:
-
-2008-10-09 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes.
-
- * platform/wx/WidgetWx.cpp:
- * plugins/wx/PluginViewWx.cpp:
- (WebCore::PluginView::invalidateRect):
- * webcore-base.bkl:
-
-2008-10-09 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
- Animations assert when navigating from page
-
- Changed assertions to test the right flag for the paused state
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
-
-2008-10-09 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fixed > 180 degree rotation bug
- Ensure that validateTransformFunctionList() is called after updating keyframe styles
-
- https://bugs.webkit.org/show_bug.cgi?id=21420
-
- Test: animations/big-rotation.html
-
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
-
-2008-10-09 Brady Eidson <beidson@apple.com>
-
- Reviewed by Anders
-
- <rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things
-
- The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion
- (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page,
- so perform a second null check on the page. Bail if it has been cleared.
-
-2008-10-09 Alp Toker <alp@nuanti.com>
-
- Build fix for recent DOM generation Makefile changes when custom
- CFLAGS/CXXFLAGS are passed in.
-
- * GNUmakefile.am:
-
-2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Alp Toker.
-
- https://bugs.webkit.org/show_bug.cgi?id=21390
- [Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformRemoveChild):
-
-2008-10-09 Darin Adler <darin@apple.com>
-
- - try to fix Qt build
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
-
-2008-10-08 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver Hunt & Sam Weinig.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)
-
- Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
- Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
- use tree is rebuild.
-
- Make SVGElementInstance a real EventTarget, as the SVG specification demands.
- When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
- is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
- share an event listener list. Every event listener change on the SVGElementInstance object is forwared
- to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
- Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
- to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
- Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.
+ Reviewed by Sam Weinig.
- Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
- see resources/use-instanceRoot-event-bubbling.js for details.
+ https://bugs.webkit.org/show_bug.cgi?id=26607
- Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
- svg/custom/use-elementInstance-methods.svg (reenabled)
- svg/custom/use-setAttribute-crash.svg (covers bug 20550)
- svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
- svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
- svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)
+ Add IDL for HTMLDataGridRowElement.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSEventListener.h:
- (WebCore::JSLazyEventListener::wasCreatedFromMarkup):
- * bindings/js/JSEventTarget.cpp:
- * bindings/js/JSEventTargetSVGElementInstance.cpp: Removed.
- * bindings/js/JSEventTargetSVGElementInstance.h: Removed.
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- (WebCore::JSSVGElementInstance::pushEventHandlerScope):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bindings/scripts/CodeGeneratorObjC.pm:
- * dom/EventListener.h:
- (WebCore::EventListener::wasCreatedFromMarkup):
- * dom/EventTargetNode.cpp:
- (WebCore::updateSVGElementInstancesAfterEventListenerChange):
- (WebCore::EventTargetNode::addEventListener):
- (WebCore::EventTargetNode::removeEventListener):
- (WebCore::eventTargetAsSVGElementInstance):
- (WebCore::eventTargetRespectingSVGTargetRules):
- (WebCore::EventTargetNode::dispatchEvent):
- (WebCore::EventTargetNode::dispatchGenericEvent):
- (WebCore::EventTargetNode::removeEventListenerForType):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::clear):
- (WebCore::instanceAssociatedWithShadowTreeElement):
- (WebCore::EventHandler::updateMouseEventTargetNode):
- * page/EventHandler.h:
- * svg/EventTargetSVGElementInstance.cpp: Removed.
- * svg/EventTargetSVGElementInstance.h: Removed.
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::SVGElementInstance):
- (WebCore::SVGElementInstance::~SVGElementInstance):
- (WebCore::SVGElementInstance::childNodes):
- (WebCore::SVGElementInstance::setShadowTreeElement):
- (WebCore::SVGElementInstance::forgetWrapper):
- (WebCore::SVGElementInstance::appendChild):
- (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
- (WebCore::SVGElementInstance::setNeedsUpdate):
- (WebCore::SVGElementInstance::associatedFrame):
- (WebCore::SVGElementInstance::addEventListener):
- (WebCore::SVGElementInstance::removeEventListener):
- (WebCore::SVGElementInstance::dispatchEvent):
- (WebCore::SVGElementInstance::onabort):
- (WebCore::SVGElementInstance::setOnabort):
- (WebCore::SVGElementInstance::onblur):
- (WebCore::SVGElementInstance::setOnblur):
- (WebCore::SVGElementInstance::onchange):
- (WebCore::SVGElementInstance::setOnchange):
- (WebCore::SVGElementInstance::onclick):
- (WebCore::SVGElementInstance::setOnclick):
- (WebCore::SVGElementInstance::oncontextmenu):
- (WebCore::SVGElementInstance::setOncontextmenu):
- (WebCore::SVGElementInstance::ondblclick):
- (WebCore::SVGElementInstance::setOndblclick):
- (WebCore::SVGElementInstance::onerror):
- (WebCore::SVGElementInstance::setOnerror):
- (WebCore::SVGElementInstance::onfocus):
- (WebCore::SVGElementInstance::setOnfocus):
- (WebCore::SVGElementInstance::oninput):
- (WebCore::SVGElementInstance::setOninput):
- (WebCore::SVGElementInstance::onkeydown):
- (WebCore::SVGElementInstance::setOnkeydown):
- (WebCore::SVGElementInstance::onkeypress):
- (WebCore::SVGElementInstance::setOnkeypress):
- (WebCore::SVGElementInstance::onkeyup):
- (WebCore::SVGElementInstance::setOnkeyup):
- (WebCore::SVGElementInstance::onload):
- (WebCore::SVGElementInstance::setOnload):
- (WebCore::SVGElementInstance::onmousedown):
- (WebCore::SVGElementInstance::setOnmousedown):
- (WebCore::SVGElementInstance::onmousemove):
- (WebCore::SVGElementInstance::setOnmousemove):
- (WebCore::SVGElementInstance::onmouseout):
- (WebCore::SVGElementInstance::setOnmouseout):
- (WebCore::SVGElementInstance::onmouseover):
- (WebCore::SVGElementInstance::setOnmouseover):
- (WebCore::SVGElementInstance::onmouseup):
- (WebCore::SVGElementInstance::setOnmouseup):
- (WebCore::SVGElementInstance::onmousewheel):
- (WebCore::SVGElementInstance::setOnmousewheel):
- (WebCore::SVGElementInstance::onbeforecut):
- (WebCore::SVGElementInstance::setOnbeforecut):
- (WebCore::SVGElementInstance::oncut):
- (WebCore::SVGElementInstance::setOncut):
- (WebCore::SVGElementInstance::onbeforecopy):
- (WebCore::SVGElementInstance::setOnbeforecopy):
- (WebCore::SVGElementInstance::oncopy):
- (WebCore::SVGElementInstance::setOncopy):
- (WebCore::SVGElementInstance::onbeforepaste):
- (WebCore::SVGElementInstance::setOnbeforepaste):
- (WebCore::SVGElementInstance::onpaste):
- (WebCore::SVGElementInstance::setOnpaste):
- (WebCore::SVGElementInstance::ondragenter):
- (WebCore::SVGElementInstance::setOndragenter):
- (WebCore::SVGElementInstance::ondragover):
- (WebCore::SVGElementInstance::setOndragover):
- (WebCore::SVGElementInstance::ondragleave):
- (WebCore::SVGElementInstance::setOndragleave):
- (WebCore::SVGElementInstance::ondrop):
- (WebCore::SVGElementInstance::setOndrop):
- (WebCore::SVGElementInstance::ondragstart):
- (WebCore::SVGElementInstance::setOndragstart):
- (WebCore::SVGElementInstance::ondrag):
- (WebCore::SVGElementInstance::setOndrag):
- (WebCore::SVGElementInstance::ondragend):
- (WebCore::SVGElementInstance::setOndragend):
- (WebCore::SVGElementInstance::onreset):
- (WebCore::SVGElementInstance::setOnreset):
- (WebCore::SVGElementInstance::onresize):
- (WebCore::SVGElementInstance::setOnresize):
- (WebCore::SVGElementInstance::onscroll):
- (WebCore::SVGElementInstance::setOnscroll):
- (WebCore::SVGElementInstance::onsearch):
- (WebCore::SVGElementInstance::setOnsearch):
- (WebCore::SVGElementInstance::onselect):
- (WebCore::SVGElementInstance::setOnselect):
- (WebCore::SVGElementInstance::onselectstart):
- (WebCore::SVGElementInstance::setOnselectstart):
- (WebCore::SVGElementInstance::onsubmit):
- (WebCore::SVGElementInstance::setOnsubmit):
- (WebCore::SVGElementInstance::onunload):
- (WebCore::SVGElementInstance::setOnunload):
- * svg/SVGElementInstance.h:
- (WebCore::SVGElementInstance::needsUpdate):
- (WebCore::SVGElementInstance::toNode):
- (WebCore::SVGElementInstance::toSVGElementInstance):
- (WebCore::SVGElementInstance::correspondingElement):
- (WebCore::SVGElementInstance::correspondingUseElement):
- (WebCore::SVGElementInstance::shadowTreeElement):
- (WebCore::SVGElementInstance::parentNode):
- (WebCore::SVGElementInstance::previousSibling):
- (WebCore::SVGElementInstance::nextSibling):
- (WebCore::SVGElementInstance::firstChild):
- (WebCore::SVGElementInstance::lastChild):
- (WebCore::SVGElementInstance::ownerDocument):
- (WebCore::SVGElementInstance::hasChildNodes):
- (WebCore::SVGElementInstance::setFirstChild):
- (WebCore::SVGElementInstance::setLastChild):
- (WebCore::SVGElementInstance::setNextSibling):
- (WebCore::SVGElementInstance::setPreviousSibling):
- (WebCore::SVGElementInstance::refEventTarget):
- (WebCore::SVGElementInstance::derefEventTarget):
- * svg/SVGElementInstance.idl:
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::svgAttributeChanged):
- (WebCore::SVGStyledElement::childrenChanged):
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::svgAttributeChanged):
- (WebCore::shadowTreeContainsChangedNodes):
- (WebCore::SVGUseElement::recalcStyle):
- (WebCore::dumpInstanceTree):
- (WebCore::SVGUseElement::buildPendingResource):
- (WebCore::SVGUseElement::buildInstanceTree):
- (WebCore::SVGUseElement::transferEventListenersToShadowTree):
- * svg/SVGUseElement.h:
-
-2008-10-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
- REGRESSION (r36977): getRGBColorValue().red returning incorrect value
-
- Update JSRGBColor to use the new static function per getter approach.
-
- Test: fast/dom/css-RGBValue.html
-
- * bindings/js/JSRGBColor.cpp:
- (WebCore::):
- (jsRGBColorRed):
- (jsRGBColorGreen):
- (jsRGBColorBlue):
- * bindings/js/JSRGBColor.h:
-
-2008-10-08 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
-
- svgElement.className.baseValue = "foo" does not work
- https://bugs.webkit.org/show_bug.cgi?id=20651
-
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::classAttributeChanged):
- (WebCore::StyledElement::parseMappedAttribute):
- * dom/StyledElement.h:
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::svgAttributeChanged):
-
-2008-10-08 Anthony Ricaud <rik24d@gmail.com>
-
- Make the toolbar label text-shadow not disappear when clicking on the
- search result count or around the search field.
-
- Reviewed by Timothy Hatcher.
-
- * inspector/front-end/inspector.css:
- (.toolbar-item:active .toolbar-label): Make this rule also require the
- toggleable class with the toolbar-item class.
-
-2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Updated the qrc file for the Web Inspector to contain the current set
- of images.
-
- * inspector/front-end/WebKit.qrc:
-
-2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Simon.
-
- Fix the linking of applications against WebKit on Qt/Windows.
-
- The prl files that qmake creates are buggy on Unix, but we they're
- fine on Windows and we have to have them there in order to get the
- dependencies correct.
-
- * WebCore.pro:
-
-2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon.
-
- Speed up rectangle filling by not re-creating a QBrush all the time.
-
- This triggers faster path in QPainter where the brush is reused.
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- (WebCore::GraphicsContext::fillRect):
-
-2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon.
+ * WebCoreSources.bkl:
+ * html/HTMLAttributeNames.in:
+ * html/HTMLDataGridColElement.cpp:
+ (WebCore::HTMLDataGridColElement::primary):
+ (WebCore::HTMLDataGridColElement::setPrimary):
+ * html/HTMLDataGridColElement.h:
+ * html/HTMLDataGridColElement.idl:
+ * html/HTMLDataGridElement.cpp:
+ (WebCore::HTMLDataGridElement::checkDTD):
+ (WebCore::HTMLDataGridElement::multiple):
+ (WebCore::HTMLDataGridElement::setMultiple):
+ * html/HTMLDataGridElement.h:
+ * html/HTMLDataGridElement.idl:
+ * html/HTMLDataGridRowElement.cpp: Added.
+ (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement):
+ (WebCore::HTMLDataGridRowElement::selected):
+ (WebCore::HTMLDataGridRowElement::setSelected):
+ (WebCore::HTMLDataGridRowElement::focused):
+ (WebCore::HTMLDataGridRowElement::setFocused):
+ * html/HTMLDataGridRowElement.h: Added.
+ (WebCore::HTMLDataGridRowElement::tagPriority):
+ * html/HTMLDataGridRowElement.idl: Added.
+ * html/HTMLTagNames.in:
- Fixes: Encoding of Qt URLs
+2009-06-19 Yael Aharon <yael.aharon@nokia.com>
- This encoding was added by Simon and I because QUrl's
- tolerant parser wasn't tolerant enough. Now it is, so we don't need
- this anymore.
+ Reviewed by Holger Freyther.
- * platform/qt/KURLQt.cpp:
- (WebCore::KURL::operator QUrl):
+ https://bugs.webkit.org/show_bug.cgi?id=26556
-2008-10-08 Marius Storm-Olsen <marius@trolltech.com>
+ Fix a crash in case that the QNetworkReply::readReady signal is
+ "stuck" in deferred mode due to JavaScript alert, and in the meantime,
+ QNetworkreply::finished signal is received and processed before
+ QNetworkReply::readReady is processed.
- Reviewed by Simon.
+ * manual-tests/qt/unload-alert.html: Added.
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::setLoadMode):
+ (WebCore::QNetworkReplyHandler::finish):
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+ (WebCore::QNetworkReplyHandler::forwardData):
+ (WebCore::QNetworkReplyHandler::start):
+ (WebCore::QNetworkReplyHandler::sendQueuedItems):
+ * platform/network/qt/QNetworkReplyHandler.h:
+ (WebCore::QNetworkReplyHandler::):
- Fixes dependencies in qmake generated visual studio projects.
+2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
- Only add debug lib name if we're in the debug build_pass, else the release version.
- The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.
+ Fix the Qt build.
* WebCore.pro:
-2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compilation errors on VS2008 64Bit
-
- * platform/text/TextStream.cpp:
- (WebCore::TextStream::operator<<):
- * platform/text/TextStream.h:
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::init):
-
-2008-10-07 Alp Toker <alp@nuanti.com>
-
- GTK+ build fix for older automake versions (1.7). Discussed in bug
- #21392.
-
- * GNUmakefile.am:
-
-2008-10-07 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Antti Koivisto.
-
- <rdar://problem/6273887> Crash in ApplicationCacheGroup
-
- Make sure to stop loading even before a cache update is in progress so that the
- manifest load will be stopped.
-
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
- (WebCore::ApplicationCacheGroup::stopLoading):
- (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
-
-2008-10-07 Timothy Hatcher <timothy@apple.com>
-
- Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.
-
- https://bugs.webkit.org/show_bug.cgi?id=21433
+2009-06-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- * WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
- * bindings/objc/DOM.mm: Remove previous category implementations
- on DOMDocument for createNodeIterator: and createTreeWalker:. Also
- moves ObjCNodeFilterCondition to its own file.
- * bindings/objc/DOMTraversal.h: Remove the category methods that added
- createNodeIterator: and createTreeWalker: to DOMDocument. This is fine
- to do since DOmDocument.h is included still, and has these methods.
- * bindings/objc/DOMUtility.mm:
- (JSC::createDOMWrapper): Remove special case for JSNodeIterator and
- JSTreeWalker now that the ObjC binding conforms to the standard wrap.
- * bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm.
- (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm.
- (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
- * bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm.
- (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
- * bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and
- createTreeWalker: methods to DOMDocument.
- * bindings/scripts/CodeGeneratorObjC.pm:
- (GetObjCTypeGetter): Add a case for NodeFilter.
- (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter.
- (GenerateImplementation): Remove existing NodeFilter special case that
- used the m_filter member variable. Add a new special getter for protocol
- types that aren't EventTarget, so the right class is used for NodeFilter.
- Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
- * dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the
- OldStyleObjC extended attribute to createNodeIterator and createTreeWalker.
- Rename the entityReferenceExpansion parameter to expandEntityReferences to
- match the previous ObjC API.
- * dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The
- m_filter member variable was never used in practice, it was always nil!
- We can remove it and not pad the object because this can't be subclassed.
- * dom/TreeWalker.idl: Ditto.
-
-2008-10-07 Timothy Hatcher <timothy@apple.com>
-
- Auto-generate the DOMEventTarget protocol implementation for
- DOMNode and DOMSVGElementInstance.
-
- https://bugs.webkit.org/show_bug.cgi?id=21432
+ Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
+ https://bugs.webkit.org/show_bug.cgi?id=25425
- Reviewed by Darin Adler.
-
- * WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
- * bindings/objc/DOM.mm: Remove many unneeded header includes. Move
- ObjCEventListener to it's own file. Remove the manual impelmentations
- of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
- * bindings/objc/DOMEvents.h: Remove the categories that defined
- DOMEventTarget for DOMNode and DOMSVGElementInstance.
- * bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
- * bindings/objc/ObjCEventListener.mm: Split out from DOM.mm.
- (WebCore::ObjCEventListener::find): Moved from DOM.mm.
- (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the
- callers from doing a manual deref.
- (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm.
- (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
- * bindings/scripts/CodeGeneratorObjC.pm:
- (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr.
- (AddIncludesForType): Include ObjCEventListener.h for EventListener.
- And include EventTargetSVGElementInstance.h for SVGElementInstance.
- (GenerateHeader): Remove the check for multiple parents.
- (GenerateImplementation): Remove the check for multiple parents. Remove
- the @deprecatedFunctions array since deprecated methods get generated
- into the main @interface now to work with protocols. Add support
- for the EventTargetNodeCast extended attribute. Add support for
- EventListener parameters.
- * dom/Node.idl: Define superclasses for ObjC so the implementation
- and interface implement the DOMEventTarget protocol. Explicitly
- specify Object as a superclass to use DOMEventTarget. Object will turn
- into DOMObject. This is needed to take the code generator down the right
- path of multiple super-classes as protocols. It is ObjC only for legacy
- reasons. The event target methods are normally on NodeEventTarget, a
- subclass of Node. But the ObjC API has never has this subclass and
- they are on DOMNode.
- * svg/SVGElementInstance.idl: Ditto.
-
-2008-10-07 David Hyatt <hyatt@apple.com>
-
- Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.
-
- The new pseudo-elements are:
- scrollbar
- scrollbar-button
- scrollbar-corner
- scrollbar-thumb
- scrollbar-track
-
- These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
- the following new pseudo-classes:
- scrollbar-active
- scrollbar-back
- scrollbar-forward
- scrollbar-horizontal
- scrollbar-vertical
-
- Reviewed by Adele
-
- * css/CSSSelector.cpp:
- (WebCore::CSSSelector::extractPseudoType):
- * css/CSSSelector.h:
- (WebCore::CSSSelector::):
-
-2008-10-06 Timothy Hatcher <timothy@apple.com>
-
- Add support to the Resources panel for queries like "#123", "foo #123",
- "line: 123" and "foo line: 123". These will match the query limiting
- the search only to the line specified. If only a line is specified,
- the whole line is matched.
-
- https://bugs.webkit.org/show_bug.cgi?id=21422
-
- Reviewed by Darin Adler.
-
- * inspector/front-end/SourceFrame.js:
- (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last
- row if the index is greater than the rows collection. Let it return
- undefined by indexing out-of-bounds.
- * inspector/front-end/SourceView.js:
- (WebInspector.SourceView.prototype.performSearch): Add support for
- queries like "#123", "foo #123", "line: 123" and "foo line: 123".
- Also match the whole query to the whole document in case there are
- colors like "#333".
-
-2008-10-07 Alp Toker <alp@nuanti.com>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=21392
- [GTK] Auto-generate JS DOM binding sources list
-
- Remove the huge lists of generated DOM binding sources and headers in
- the build system. These are difficult to maintain and can be derived
- automatically.
-
- The new strategy is to re-use the existing lists of IDL sources (which
- are needed for dist support anyway). This will also ease the addition
- of new language bindings.
-
- * GNUmakefile.am:
-
-2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
+ * bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit
+ more consistent and to make SVGElement.h be included in the header rather than in
+ every implementation file that includes the header. Added code to use getAttribute
+ and setAttribute directly when the [Reflect] extended attribute is used.
- Reviewed by Simon.
-
- Don't attempt to paint when updating control tints
-
- We don't have a valid PlatformGraphicsContext so schedule
- the dirty scrollbar/scrollview area for repaint instead.
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::ScrollbarThemeQt::paint):
- (WebCore::ScrollbarThemeQt::paintScrollCorner):
-
-2008-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
-
- [qt] Build fix after Scrollbar.h and Widget.h changes.
-
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::init):
-
-2008-10-06 David Hyatt <hyatt@apple.com>
-
- Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::hasWebView):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadWithDocumentLoader):
- (WebCore::FrameLoader::transitionToCommitted):
- * loader/FrameLoaderClient.h:
- * page/FocusController.cpp:
- (WebCore::FocusController::setActive):
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::init):
- (WebCore::FrameView::layoutIfNeededRecursive):
- * page/FrameView.h:
-
-2008-10-06 Dan Bernstein <mitz@apple.com>
-
- - build fix
+ * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- * bindings/objc/DOMEvents.h:
+ * html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that
+ reflect content attributes. Restricting this to one class for now to keep the
+ patch small and start out slowly.
-2008-10-06 Mark Mentovai <mark@moxienet.com>
+2009-06-21 Sam Weinig <sam@webkit.org>
- Reviewed by Tim Hatcher.
+ Reviewed by Oliver Hunt.
- Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
- Platform.h is not available, in preference to #ifdef ENABLE_feature.
- #ifdef is wrong now that features are disabled by #defining
- ENABLE_feature to 0.
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
+ Only expose event handler attributes to elements and documents.
- https://bugs.webkit.org/show_bug.cgi?id=21338
+ Test: fast/dom/event-attribute-availability.html
- * bindings/objc/DOMEvents.h:
- * bindings/objc/PublicDOMInterfaces.h:
* dom/Document.idl:
- * page/DOMWindow.idl:
- * svg/svgtags.in:
-
-2008-10-06 Mark Mentovai <mark@moxienet.com>
-
- Reviewed by Sam Weinig.
-
- * platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h>
- to get the declaration for isMainThread().
-
-2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Tim Hatcher.
-
- WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
- to reflect that.
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/mac/WebCoreObjCExtras.c: Removed.
- * platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
-
-2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Added C++ forward declaration for the NSURLAuthenticationChallenge class
- so that the m_currentMacChallenge variable doesn't cause a
- compilation error when ResourceHandleInternal.h is included from a C++ file.
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=21411
-
- * platform/network/ResourceHandleInternal.h:
-
-2008-10-06 Steve Falkenburg <sfalken@apple.com>
-
- Windows build fix.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-10-06 Steve Falkenburg <sfalken@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21416
- Add missing null checks identified by Application Verifier.
-
- Reviewed by Darin Adler.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::clearTimer):
-
-2008-10-06 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Removed accidentally left in debugging statement.
-
- * inspector/front-end/inspector.js:
-
-2008-10-06 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher and Oliver Hunt.
-
- https://bugs.webkit.org/show_bug.cgi?id=21412
- Bug 21412: Refactor user initiated profile count to be more stable
-
- * inspector/InspectorController.cpp: Keep track of the user-initiated
- profiles here now.
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::startUserInitiatedProfiling):
- (WebCore::InspectorController::stopUserInitiatedProfiling):
- * inspector/InspectorController.h:
- The front end will now need to check for the existence of the user-
- initiated profile title and use its count instead of keeping its own.
- * inspector/front-end/ProfilesPanel.js:
-
-2008-10-06 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - separate GDI text drawing into its own function
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::drawGDIGlyphs):
- (WebCore::Font::drawGlyphs):
-
-2008-10-03 Steve Falkenburg <sfalken@apple.com>
-
- <rdar://problem/6249833> Fix default button appearance
-
- Reviewed by Adele Peterson.
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::supportsFocus):
- (WebCore::RenderThemeWin::determineClassicState):
- (WebCore::RenderThemeWin::determineButtonState):
- (WebCore::RenderThemeWin::getClassicThemeData):
- (WebCore::RenderThemeWin::getThemeData):
- (WebCore::drawControl):
- * rendering/RenderThemeWin.h:
-
-2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Add native virtual keycode to PlatformKeyboardEvent
-
- * platform/PlatformKeyboardEvent.h:
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/mac/KeyEventMac.mm:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/qt/PlatformKeyboardEventQt.cpp:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/win/KeyEventWin.cpp:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- * platform/wx/KeyboardEventWx.cpp:
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
-
-2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac
-
- * platform/text/PlatformString.h:
- * platform/text/StringImpl.h:
- * platform/text/cf/StringCF.cpp:
- * platform/text/cf/StringImplCF.cpp:
-
-2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Use bundles on QtWebKit/Mac for platform modules
-
- * platform/FileSystem.h:
- * platform/qt/FileSystemQt.cpp:
- (WebCore::unloadModule):
-
-2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon.
-
- Build fix for MinGW.
-
- * platform/win/SystemTimeWin.cpp:
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::invalidateRect):
-
-2008-10-06 Adam Roben <aroben@apple.com>
-
- Mimic the inspector/ directory structure in WebCore.vcproj
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-10-06 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Update the Include path for all
- configurations to include WebCore/inspector.
-
-2008-10-04 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin Adler.
-
- SVG should support ascent and descent properties <font-face> instead of <font>!
- https://bugs.webkit.org/show_bug.cgi?id=21365
-
- Tested by many many existing SVG tests.
-
- * svg/SVGFontFaceElement.cpp:
- (WebCore::SVGFontFaceElement::ascent):
- (WebCore::SVGFontFaceElement::descent):
-
-2008-10-05 Darin Fisher <darin@chromium.org>
-
- Reviewed by Eric Seidel.
-
- REGRESSION: crash in ScriptElement::notifyFinished
- Fixes https://bugs.webkit.org/show_bug.cgi?id=21329
-
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to
- ensure that the ScriptElementData object is not destroyed prematurely.
-
-2008-10-05 Chris Lord <chris@openedhand.com>
-
- Reviewed by Alp Toker. Landed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=20624
- WebKit-gtk uses deprecated GtkType/GtkObject
-
- * plugins/gtk/gtk2xtbin.c:
- (gtk_xtbin_get_type):
- * plugins/gtk/gtk2xtbin.h:
-
-2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
-
- Reviewed by David Hyatt.
-
- GTK_WINDOW_HWND not GTK_WINDOWING_HWND
- https://bugs.webkit.org/show_bug.cgi?id=20725
-
- Updated to ToT by Jan Alonzo.
-
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::getValue):
-
-2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Darin Adler.
-
- Invalid cast from GdkWindow to GtkWidget
- https://bugs.webkit.org/show_bug.cgi?id=21391
-
- Fix a misplaced closing parenthesis to actually cast the widget, not the window
-
- * platform/gtk/PlatformScreenGtk.cpp:
- (WebCore::screenDepth):
-
-2008-10-05 Adam Barth <abarth@webkit.org>
-
- Reviewed by Darin Alder.
-
- Attach the Origin header to POST requests to help defend against
- cross-site request forgery.
-
- https://bugs.webkit.org/show_bug.cgi?id=20792
-
- Collin Jackson <collinj@webkit.org> also contributed to this patch.
-
- Tests: http/tests/security/originHeader/origin-header-for-data.html
- http/tests/security/originHeader/origin-header-for-empty.html
- http/tests/security/originHeader/origin-header-for-get.html
- http/tests/security/originHeader/origin-header-for-https.html
- http/tests/security/originHeader/origin-header-for-post.html
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::createWindow):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createWindow):
- (WebCore::FrameLoader::urlSelected):
- (WebCore::FrameLoader::submitForm):
- (WebCore::FrameLoader::outgoingOrigin):
- (WebCore::FrameLoader::loadURL):
- (WebCore::FrameLoader::addExtraFieldsToRequest):
- (WebCore::FrameLoader::loadPostRequest):
- (WebCore::FrameLoader::loadResourceSynchronously):
- (WebCore::FrameLoader::loadItem):
- * loader/FrameLoader.h:
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::create):
- * loader/loader.cpp:
- (WebCore::Loader::Host::servePendingRequests):
- * platform/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::toHTTPOrigin):
- * platform/SecurityOrigin.h:
- * platform/network/ResourceRequestBase.h:
- (WebCore::ResourceRequestBase::httpOrigin):
- (WebCore::ResourceRequestBase::setHTTPOrigin):
- (WebCore::ResourceRequestBase::clearHTTPOrigin):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
- (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
- (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
-
-2008-10-04 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
- <https://bugs.webkit.org/show_bug.cgi?id=21381>
-
- If we hit a parsing boundary (end of a packet, etc) in the middle of a
- <script> element when we are doing an incremental parse, we exit the
- parser, and reenter later when more data is available. During this
- reentry we incorrectly reset the scriptStartLineno to the current line
- in the parser, which is now part way through the script element.
-
- The solution is to track whether we are entering or reentering the parsing
- of a script element. We do this simply by 0 checking scriptStartLineno,
- and resetting it after we complete parsing of each script element.
-
- Test: http/tests/incremental/pause-in-script-element.pl
-
- * ChangeLog:
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::parseSpecial):
- (WebCore::HTMLTokenizer::scriptHandler):
-
-2008-10-04 Alp Toker <alp@nuanti.com>
-
- Reviewed by David Hyatt. Landed by Jan Alonzo.
-
- https://bugs.webkit.org/show_bug.cgi?id=20924
- [Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3
-
- https://bugs.webkit.org/show_bug.cgi?id=19578
- [CURL] problem in parseDataUrl
-
- De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
- This patch also fixes encoding support in escaped (non-Base64) data
- URLs. All manual data URL tests now pass in both GLib and non-GLib
- code paths.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::parseDataUrl):
-
-2008-10-04 Timothy Hatcher <timothy@apple.com>
-
- Makes breakpoints and debugging code during page load work in the
- Web Inspector's debugger. Specifically, this makes the source
- code for loading resources show up in the Scripts panel.
-
- https://bugs.webkit.org/show_bug.cgi?id=19053
- rdar://problem/5933408
-
- Reviewed by Mark Rowe.
-
- * WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
- not using tabs and a tab width of 8.
- * inspector/InspectorController.cpp:
- (WebCore::addResourceSourceToFrame): Return a bool to report if the
- source was added successfully or not.
- (WebCore::addSourceToFrame): Ditto.
- * inspector/front-end/ScriptView.js:
- (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- Return early if the InspectorController.addSourceToFrame fails.
- Moved the delete of the _frameNeedsSetup property after that call so
- if the source wasn't added it will be attempted again.
- * inspector/front-end/SourceView.js:
- (WebInspector.SourceView.prototype.detach): Move a comment.
- (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
- Don't check if the resource is finished or failed, just attempt
- to add the source to the frame. WebCore has the source, but the
- finished property hasn't been set yet. Return early if the
- InspectorController.addSourceToFrame fails. Moved the delete
- of the _frameNeedsSetup property after that call so if the source
- wasn't added it will be attempted again.
- (WebInspector.SourceView.prototype._resourceLoadingFinished):
- Clear the _frameNeedsSetup and _sourceFrameSetup properties so
- the source frame will we populated again now that the resource
- load has finished.
- * manual-tests/inspector/debugger-pause-during-load.html: Added.
-
-2008-10-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-10-04 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21373
-
- Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
- is still present.
-
- Reviewed by Mark Rowe
-
- * page/FrameView.cpp:
- (WebCore::FrameView::~FrameView):
-
-2008-10-04 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Avoid copying a Vector when using getSupportedKeySizes.
-
- * html/HTMLKeygenElement.cpp:
- (WebCore::HTMLKeygenElement::HTMLKeygenElement):
- * platform/SSLKeyGenerator.h:
- * platform/gtk/TemporaryLinkStubs.cpp:
- (WebCore::getSupportedKeySizes):
- * platform/mac/SSLKeyGeneratorMac.mm:
- (WebCore::getSupportedKeySizes):
- * platform/qt/TemporaryLinkStubs.cpp:
- (WebCore::getSupportedKeySizes):
- * platform/win/TemporaryLinkStubs.cpp:
- (WebCore::getSupportedKeySizes):
- * platform/wx/TemporaryLinkStubs.cpp:
- (WebCore::getSupportedKeySizes):
-
-2008-10-04 Darin Adler <darin@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - prepare for https://bugs.webkit.org/show_bug.cgi?id=21295
- Bug 21295: Replace ExecState with a call frame Register pointer
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
- Remove bogus "const".
- * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
-
-2008-10-04 David Hyatt <hyatt@apple.com>
-
- Make PopupMenuClient obey the platform abstraction. Remove any connection to Document and RenderStyle.
-
- Reviewed by Darin Adler
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/PopupMenuClient.h:
- * platform/gtk/PopupMenuGtk.cpp:
- (WebCore::PopupMenu::show):
- * platform/mac/PopupMenuMac.mm:
- (WebCore::PopupMenu::populate):
- (WebCore::PopupMenu::show):
- * platform/qt/PopupMenuQt.cpp:
- (WebCore::PopupMenu::populate):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::calculatePositionAndSize):
- (WebCore::PopupMenu::paint):
- (WebCore::PopupWndProc):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::itemStyle):
- (WebCore::RenderMenuList::menuStyle):
- (WebCore::RenderMenuList::hostWindow):
- * rendering/RenderMenuList.h:
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::itemStyle):
- (WebCore::RenderTextControl::menuStyle):
- (WebCore::RenderTextControl::hostWindow):
- * rendering/RenderTextControl.h:
-
-2008-10-04 Matt Lilek <webkit@mattlilek.com>
-
- Build fix - restore Private role to headers that had it before the move.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-10-04 Darin Adler <darin@apple.com>
-
- - try to fix build
-
- * DerivedSources.make: Add new inspector directory to VPATH.
- * GNUmakefile.am: Add new inspector directory to includes.
- Re-sort the IDL_BINDINGS list. Add new inspector directory
- to VPATH.
-
-2008-10-04 Matt Lilek <webkit@mattlilek.com>
+ * dom/Element.idl:
+ * dom/Node.cpp:
+ * dom/Node.h:
+ * dom/Node.idl:
- Not reviewed, attempt to fix Gtk build.
+2009-06-21 Daniel Bates <dbates@intudata.com>
- * GNUmakefile.am:
+ Reviewed by Adam Barth.
-2008-10-03 Timothy Hatcher <timothy@apple.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26580
+
+ Fix to enable XSSAuditor on child windows.
+
+ Test: http/tests/security/xssAuditor/link-opens-new-window.html
+
+ * page/XSSAuditor.cpp:
+ (WebCore::XSSAuditor::XSSAuditor):
+ (WebCore::XSSAuditor::isEnabled):
+ (WebCore::XSSAuditor::canEvaluate):
+ (WebCore::XSSAuditor::canCreateInlineEventListener):
+ (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
+ (WebCore::XSSAuditor::canLoadObject):
+ * page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled.
+ Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation
+ to query Settings.
- Move the Web Inspector files into a top-level "inspector" folder.
+2009-06-21 David Levin <levin@chromium.org>
- https://bugs.webkit.org/show_bug.cgi?id=21359
+ Reviewed by NOBODY.
- Reviewed by Dave Hyatt.
+ Speculative windows build fix (idea by Mark Rowe).
- * GNUmakefile.am:
- * WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
- * inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
- * inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
- * inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
- * inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
- * inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
- * inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
- * inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
- * inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
- * inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
- * inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
- * inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
- * inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
- * inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
- * inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
- * inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
- * inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
- * inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
- * inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
- * inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
- * inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
- * inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
- * inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
- * inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
- * inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
- * inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
- * inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
- * inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
- * inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
- * inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
- * inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
- * inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
- * inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
- * inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
- * inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
- * inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
- * inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
- * inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
- * inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
- * inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
- * inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
- * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
- * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
- * inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
- * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
- * inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
- * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
- * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
- * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
- * inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
- * inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
- * inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
- * inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
- * inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
- * inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
- * inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
- * inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
- * inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
- * inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
- * inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
- * inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
- * inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
- * inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
- * inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
- * inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
- * inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
- * inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
- * inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
- * inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
- * inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
- * inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
- * inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
- * inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
- * inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
- * inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
- * inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
- * inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
- * inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
- * inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
- * inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
- * inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
- * inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
- * inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
- * inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
- * inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
- * inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
- * inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
- * inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
- * inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
- * inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
- * inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
- * inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
- * inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
- * inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
- * inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
- * inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
- * inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
- * inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
- * inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
- * inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
- * inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
- * inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
- * inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
- * inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
- * inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
- * inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
- * inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
- * inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
- * inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
- * inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
- * inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
- * inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
- * inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
- * inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
- * inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
- * inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
- * inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
- * inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
- * inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
- * inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
- * inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
- * inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
- * inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
- * inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
- * inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
- * inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
- * inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
- * inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
- * inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
- * inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
- * inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
- * inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
- * inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
- * inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
- * inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
- * inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
- * inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
- * inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
- * inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
- * inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
- * inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
- * inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
- * inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
- * inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
- * inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
- * inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
- * inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
- * inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
- * inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
- * inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
- * inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
- * inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
- * inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
- * inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
- * inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
- * inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
-
-2008-10-03 Timothy Hatcher <timothy@apple.com>
-
- Adds support to the Web Inspector's Elements panel for fast tag name,
- class name, id and attribute name searching. The panel first tries
- using getElementById, getElementsByClassName and getElementsByTagName
- with the search query. Then does a slower search using XPath for partial
- matches, text and comment matches.
-
- Adds support for search queries like "<div>", "<h" and "frame>".
- These forms limit the search to tag names, text and comment matches.
-
- https://bugs.webkit.org/show_bug.cgi?id=21353
-
- Reviewed by Maciej Stachowiak.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax
- support. Add new search functions that try exact matches first.
-
-2008-10-03 Timothy Hatcher <timothy@apple.com>
-
- Changes how searching works in the Web Inspector's Elements
- panel. The search tasks are divided into chunks that are small
- units of work that are performed at a time interval. This
- change also prevents queries that will select all elements,
- since that isn't useful.
-
- https://bugs.webkit.org/show_bug.cgi?id=21285
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.searchCancled):
- Remove the searchResultsProperty form results since there might
- be an unfinished search.
- (WebInspector.ElementsPanel.prototype.performSearch): Divide the
- documents and search functions into chunks that are performed on
- a interval of 25ms. Prevent searches for "//*" and "*".
-
-2008-10-03 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - "this" object in methods called on primitives should be wrapper object
- https://bugs.webkit.org/show_bug.cgi?id=21362
- Updated so toThis conversion for the split window is handled properly.
+2009-06-21 David Levin <levin@chromium.org>
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2008-10-03 Sam Weinig <sam@webkit.org>
-
- Reviewed by David "The Motivator" Hyatt.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
- Move SecurityOrigin out of platform/ to page/.
-
- It was a layering violation for SecurityOrigin to be in platform
- as it depended on FrameLoader.
+ Reviewed by NOBODY (Speculative gtk build fix).
* GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
- * page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
- * page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
- * platform/SecurityOrigin.cpp: Removed.
- * platform/SecurityOrigin.h: Removed.
- * platform/SecurityOriginHash.h: Removed.
-
-2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Alp Toker.
-
- http://bugs.webkit.org/show_bug.cgi?id=18832
- [curl] file upload does not work
-
- The curl_off_t integer type has a different size depending if large
- file support is enabled or not. There is no different public API for
- the two cases, so the same function accepts a different type based on
- a compilation option the could be different in WebKit and libcurl.
- To fix the bug we query libcurl at runtime for large file support and
- pass the right type based on that.
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::setupPOST):
-
-2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by David Hyatt.
-
- Gtk build fixes.
-
- * platform/gtk/FileChooserGtk.cpp:
- (WebCore::FileChooser::openFileChooser):
- * platform/gtk/PlatformScreenGtk.cpp:
- (WebCore::screenDepth):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenAvailableRect):
- * platform/gtk/PopupMenuGtk.cpp:
- (WebCore::PopupMenu::show):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformAddChild):
- (WebCore::ScrollView::platformRemoveChild):
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::setCursor):
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::init):
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Fix Qt bustage from missing include.
-
- * platform/qt/PlatformScreenQt.cpp:
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Fix Windows scrollbar bustage in popup menus.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupWndProc):
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Fix Windows bustage.
-
- * platform/win/FileChooserWin.cpp:
- (WebCore::FileChooser::openFileChooser):
- * platform/win/PlatformScreenWin.cpp:
- (WebCore::monitorInfoForWidget):
- * platform/win/WidgetWin.cpp:
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::init):
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- * bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure
- seen on some machines but not others by adding an include.
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- - Qt build fix
-
- * bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and
- execute functions. Declarations for these relied on the CodeType
- enumeration, which used to be in ExecState.h; but the functions
- aren't needed at all.
- * bridge/qt/qt_runtime.h: Ditto.
-
-2008-10-03 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
- Turn ExecState into a call frame pointer.
-
- Remove m_globalObject and m_globalData from ExecState.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
- Removed an argument now that JSGlobalObject doesn't need it any more.
- (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from
- the JSDOMWindowBaseData constructor, and added the this argument to the
- JSGlobalObject constructor. This is because a couple key bits of
- initialization moved from the data constructor to the JSGlobalObject
- constructor.
- * bindings/js/JSDOMWindowBase.h: Ditto.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- * bridge/runtime_method.cpp:
- (JSC::RuntimeMethod::RuntimeMethod):
- Pass JSGlobalData* instead of ExecState* to the InternalFunction
- constructor.
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Fix Windows/Qt build bustage.
-
- Reviewed by ggaren
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::platformWindow):
- * page/Chrome.cpp:
- (WebCore::Chrome::platformWindow):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * platform/HostWindow.h:
- * platform/qt/PlatformScreenQt.cpp:
- (WebCore::screenDepth):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenIsMonochrome):
- (WebCore::screenRect):
- (WebCore::screenAvailableRect):
- * platform/qt/PopupMenuQt.cpp:
- (WebCore::PopupMenu::show):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::show):
- (WebCore::PopupMenu::calculatePositionAndSize):
- (WebCore::PopupWndProc):
-
-2008-10-03 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Make setStyle() take a const RenderStyle, to ensure that an
- earlier RenderStyle::diff() remains valid.
-
- * rendering/RenderBR.cpp:
- * rendering/RenderBR.h:
- * rendering/RenderBlock.cpp:
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- * rendering/RenderBox.h:
- * rendering/RenderButton.cpp:
- * rendering/RenderButton.h:
- * rendering/RenderFieldset.cpp:
- * rendering/RenderFieldset.h:
- * rendering/RenderFileUploadControl.cpp:
- * rendering/RenderFileUploadControl.h:
- * rendering/RenderInline.cpp:
- * rendering/RenderInline.h:
- * rendering/RenderListBox.cpp:
- * rendering/RenderListBox.h:
- * rendering/RenderListItem.cpp:
- * rendering/RenderListItem.h:
- * rendering/RenderListMarker.cpp:
- * rendering/RenderListMarker.h:
- * rendering/RenderMenuList.cpp:
- * rendering/RenderMenuList.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setStyle):
- * rendering/RenderObject.h:
- * rendering/RenderReplaced.cpp:
- * rendering/RenderReplaced.h:
- * rendering/RenderSVGBlock.cpp:
- (WebCore::RenderSVGBlock::setStyle):
- * rendering/RenderSVGBlock.h:
- * rendering/RenderSVGGradientStop.cpp:
- * rendering/RenderSVGGradientStop.h:
- * rendering/RenderSlider.cpp:
- * rendering/RenderSlider.h:
- * rendering/RenderTable.cpp:
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- * rendering/RenderTableCell.h:
- * rendering/RenderTableRow.cpp:
- * rendering/RenderTableRow.h:
- * rendering/RenderText.cpp:
- * rendering/RenderText.h:
- * rendering/RenderTextControl.cpp:
- * rendering/RenderTextControl.h:
- * rendering/RenderWidget.cpp:
- * rendering/RenderWidget.h:
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::isDisplayReplacedType):
- (WebCore::RenderStyle::isDisplayInlineType):
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
- event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
- method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
- that will work properly for hit testing. This patch just stubs out that method to return the same
- event untransformed.
-
- Reviewed by Darin Adler
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * page/gtk/EventHandlerGtk.cpp:
- * page/mac/EventHandlerMac.mm:
- * page/qt/EventHandlerQt.cpp:
- * page/win/EventHandlerWin.cpp:
- * page/wx/EventHandlerWx.cpp:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::mouseMoved):
- (WebCore::Scrollbar::mouseExited):
- (WebCore::Scrollbar::mouseUp):
- (WebCore::Scrollbar::mouseDown):
- (WebCore::Scrollbar::transformEvent):
- * platform/Scrollbar.h:
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21340
-
- Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
-
- Reviewed by Dan Bernstein & Darin Adler
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::addChild):
- * platform/Widget.cpp:
- (WebCore::Widget::init):
- * platform/Widget.h:
- * platform/mac/WidgetMac.mm:
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::show):
-
-2008-10-03 Adele Peterson <adele@apple.com>
-
- Reviewed by Sam Weinig.
-
- * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily):
- Return early if settings is nil.
-
-2008-10-03 Rob Buis <buis@kde.org>
-
- Reviewed by Darin.
-
- https://bugs.webkit.org/show_bug.cgi?id=20134
- REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
-
- Make sure the input element gets the right default value when no value is set.
-
- Test: fast/forms/range-default-value.html
-
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::setPositionFromValue):
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
- destructor that calls them, switch to having a cross-platform constructor/destructor that calls
- platform-specific init/destroy methods.
-
- With this change, ScrollViewWin.cpp can be removed from the build (yay!).
-
- Reviewed by Darin Adler
-
- * WebCore.vcproj/WebCore.vcproj:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
- (WebCore::ScrollView::platformInit):
- (WebCore::ScrollView::platformDestroy):
- (WebCore::ScrollView::platformAddChild):
- (WebCore::ScrollView::platformRemoveChild):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformInit):
- (WebCore::ScrollView::platformDestroy):
- * platform/mac/ScrollViewMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::platformInit):
- (WebCore::ScrollView::platformDestroy):
- * platform/win/ScrollViewWin.cpp: Removed.
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformInit):
- (WebCore::ScrollView::platformDestroy):
- (WebCore::ScrollView::setPlatformWidget):
-
-2008-10-03 Adele Peterson <adele@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for <rdar://problem/6012018>
- https://bugs.webkit.org/show_bug.cgi?id=21335
- CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8
-
- * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
-
-2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Build fix.
-
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::invalidateRect):
-
-2008-10-03 Alp Toker <alp@nuanti.com>
-
- Remove some left-over GTK+ includes. No change in functionality.
-
- * platform/Cursor.h:
- * platform/graphics/Icon.h:
- * platform/gtk/RenderThemeGtk.h:
-
-2008-10-03 Alp Toker <alp@nuanti.com>
-
- Build fix for trailing comment after #endif
-
- * dom/ElementRareData.h:
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Remove addToDirtyRegion.
-
- Reviewed by Oliver Hunt
-
- * page/Chrome.cpp:
- * page/Chrome.h:
- * page/ChromeClient.h:
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
-
-2008-10-03 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - fix a CachedResource leak introduced in r37176
-
- Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
- afterwards bail out of the outer pruneDeadResources().
-
- * loader/Cache.cpp:
- (WebCore::Cache::Cache):
- (WebCore::Cache::pruneDeadResources):
- (WebCore::Cache::remove):
- * loader/Cache.h:
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21330
-
- Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
- scrollbars.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setHasHorizontalScrollbar):
- (WebCore::ScrollView::setHasVerticalScrollbar):
- (WebCore::ScrollView::platformHasHorizontalAdjustment):
- (WebCore::ScrollView::platformHasVerticalAdjustment):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::adjustmentChanged):
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
- (WebCore::ScrollView::setGtkAdjustments):
- (WebCore::ScrollView::platformHandleHorizontalAdjustment):
- (WebCore::ScrollView::platformHandleVerticalAdjustment):
-
-2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21106: .in format discussed changes
- https://bugs.webkit.org/show_bug.cgi?id=21106
-
- Change "upperCase" to "interfaceName" per-tag parameter as
- discussed on the mailing list. Removed the per-attribute version
- as it was not used.
-
- Also add the "Element" suffix to all interfaceName parameter to match
- the class name (and thus remove it from make_names.pl).
-
- * dom/make_names.pl:
- * html/HTMLTagNames.in:
- * svg/svgtags.in:
-
-2008-10-03 David Hyatt <hyatt@apple.com>
-
- Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
- Hopefully this is a temporary hack that could eventually be removed.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents):
- * platform/ScrollView.h:
- (WebCore::ScrollView::rootPreventsBlitting):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
- (WebCore::ScrollView::platformAddChild):
- (WebCore::ScrollView::platformRemoveChild):
-
-2008-10-02 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21328
-
- Make widget invalidation more cross-platform.
-
- (1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
-
- (2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
- This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
-
- (3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
-
- (4) FrameViews now do a repaintRectangle on their owner element's renderer.
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::invalidateRect):
- (WebCore::FrameView::invalidateScrollbarRect):
- * page/FrameView.h:
- * platform/PopupMenu.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents):
- * platform/ScrollView.h:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::setEnabled):
- (WebCore::Scrollbar::invalidateRect):
- * platform/Scrollbar.h:
- * platform/ScrollbarClient.h:
- * platform/Widget.h:
- * platform/gtk/WidgetGtk.cpp:
- * platform/mac/WidgetMac.mm:
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::invalidateScrollbarRect):
- * platform/win/WidgetWin.cpp:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::invalidateTimerFired):
- (WebCore::PluginView::invalidateWindowlessPluginRect):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::invalidateRect):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::invalidateRect):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::invalidateRect):
- (WebCore::PluginView::invalidateRegion):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::invalidateScrollbarRect):
- * rendering/RenderLayer.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::paintObject):
- (WebCore::RenderListBox::paintScrollbar):
- (WebCore::RenderListBox::invalidateScrollbarRect):
- * rendering/RenderListBox.h:
-
-2008-10-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen and Sam Weinig.
-
- - fix SVGFontFaceElement leaks seen in Acid3
- - make font-face elements take effect only when they are in the document tree
-
- Test: svg/custom/font-face-not-in-document.svg
-
- * svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a
- RefPtr to a plain pointer to break a ref cycle.
- (WebCore::SVGFontData::svgFontFaceElement):
-
- * svg/SVGFontFaceElement.cpp: Changed to insert and remove the
- @font-face rule from the document's mapped element sheet when the
- element is inserted and removed from the document, and to update it
- only when the element is in the document.
- (WebCore::SVGFontFaceElement::SVGFontFaceElement):
- (WebCore::SVGFontFaceElement::parseMappedAttribute):
- (WebCore::SVGFontFaceElement::rebuildFontFace):
- (WebCore::SVGFontFaceElement::insertedIntoDocument):
- (WebCore::SVGFontFaceElement::removedFromDocument):
- (WebCore::SVGFontFaceElement::childrenChanged):
- (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
- * svg/SVGFontFaceElement.h:
-
-2008-10-01 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Fix RenderFileUploadControl::setStyle() and
- RenderMenuList::setStyle() to not touch the style; replace
- with html4.css and CSSStyleSelector changes.
-
- https://bugs.webkit.org/show_bug.cgi?id=21287
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * css/html4.css:
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::setStyle):
- * rendering/RenderFileUploadControl.cpp:
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::setStyle):
-
-2008-10-01 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Clean up code that changes the RenderStyle passed in to
- table renderer setStyle() methods.
-
- https://bugs.webkit.org/show_bug.cgi?id=21287
-
- Tests: fast/table/floating-th.html
- fast/table/table-display-types-strict.html
- fast/table/table-display-types.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::adjustRenderStyle):
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::setStyle):
- * rendering/RenderTableRow.cpp:
- (WebCore::RenderTableRow::setStyle):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::setStyle):
-
-2008-10-02 Darin Adler <darin@apple.com>
-
- - fix build
-
- * bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too.
- Not just locally in my generated file!
-
-2008-10-02 Adele Peterson <adele@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
- REGRESSION: <input> color specified in inline style applies to placeholder
-
- I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
- is more appropriate. This change adds "-webkit-input-placeholder".
-
- * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- Added definition for "-webkit-input-placeholder" pseudo element.
- * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
- * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- Added case for PseudoInputPlaceholder.
- * css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
- * rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
- (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
- (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
- setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
- (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
- the text will be updated correctly.
- * rendering/RenderTextControl.h:
-
-2008-10-02 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=21280
- <rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables
-
- Updated AXTable detection to be more robust to false-positives. Specifically, added checks
- to ensure that there is more than one valid table cell, and that at least half of the cells
- have borders or have specific background colors. Modified the table detection layout test
- to test for the tables mentioned in the bug
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
-
-2008-10-02 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff Garen.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21321
- Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
-
- * bindings/js/GCController.cpp:
- (WebCore::collect): Use heap. instead of heap-> to work with the heap.
- (WebCore::GCController::gcTimerFired): Ditto.
- (WebCore::GCController::garbageCollectNow): Ditto.
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::operator new): Ditto.
- * storage/Database.cpp:
- (WebCore::Database::Database): Ditto.
-2008-10-02 Dan Bernstein <mitz@apple.com>
+2009-06-21 David Levin <levin@chromium.org>
- Reviewed by Alexey Proskuryakov.
-
- - fix a Database leak that resulted in Document leaks
-
- * storage/Database.cpp:
- (WebCore::Database::openDatabase): Account for the fact that RefCounted
- objects start out with a ref count of 1.
-
-2008-10-02 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mr. Geoffrey Garen.
-
- Always mark your parent before marking members.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::mark):
-
-2008-10-02 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21314
-
- Make scrollBackingStore cross-platform.
-
- Reviewed by Sam Weinig
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::repaint):
- (WebCore::EmptyChromeClient::scroll):
- * page/Chrome.cpp:
- (WebCore::Chrome::repaint):
- (WebCore::Chrome::scroll):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleAutoscroll):
- * platform/HostWindow.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollContents):
- (WebCore::ScrollView::addPanScrollIcon):
- (WebCore::ScrollView::removePanScrollIcon):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::~ScrollView):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
-
-2008-10-02 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after Frame/ScrollView changes.
-
- * WebCoreSources.bkl:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformContentsToScreen):
- (WebCore::ScrollView::platformScreenToContents):
- (WebCore::ScrollView::platformIsOffscreen):
-
-2008-10-02 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=21292
-
- Revert the changes to enclosingIntRect made in r12530 since the new code
- doesn't round correctly.
-
- * ChangeLog:
- * platform/graphics/FloatRect.cpp:
- (WebCore::enclosingIntRect):
-
-2008-10-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson and Eric Seidel.
-
- - fix HTMLCanvaseElement leak from -webkit-canvas() values
-
- Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
- pointer, as the document owns the canvas elements. Added code to release
- those elements in Document::removedLastRef() because they reference
- the document.
-
- * css/CSSCanvasValue.cpp:
- (WebCore::CSSCanvasValue::element):
- * css/CSSCanvasValue.h:
- (WebCore::CSSCanvasValue::CSSCanvasValue):
- * dom/Document.cpp:
- (WebCore::Document::removedLastRef):
-
-2008-10-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Build fix for platforms that don't implement WTF::ThreadSpecific.
-
- * bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet):
- Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this
- code is only needed for JS bindings in worker threads.
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21298
-
- Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
- will make that cross-platform.
-
- The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
- multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
- windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
-
- Reviewed by Sam Weinig
-
- * page/FrameView.cpp:
- (WebCore::FrameView::windowClipRect):
- (WebCore::FrameView::isActive):
- * page/FrameView.h:
- (WebCore::FrameView::visibleContentsResized):
- * platform/PopupMenu.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::init):
- (WebCore::ScrollView::destroy):
- (WebCore::ScrollView::setHasHorizontalScrollbar):
- (WebCore::ScrollView::setHasVerticalScrollbar):
- (WebCore::ScrollView::valueChanged):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollContents):
- (WebCore::ScrollView::platformHandleHorizontalAdjustment):
- (WebCore::ScrollView::platformHandleVerticalAdjustment):
- * platform/ScrollView.h:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::windowClipRect):
- * platform/ScrollbarClient.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::platformHandleHorizontalAdjustment):
- (WebCore::ScrollView::platformHandleVerticalAdjustment):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::scrollContents):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::windowClipRect):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::scrollContents):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::windowClipRect):
- * rendering/RenderLayer.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::panScroll):
- (WebCore::RenderListBox::windowClipRect):
- * rendering/RenderListBox.h:
+ Reviewed by NOBODY.
-2008-10-02 Alexey Proskuryakov <ap@webkit.org>
+ Speculative tiger build fix and a windows build fix.
+ More fixes may still be in order.
- Reviewed by Darin Adler.
+ * WebCore.vcproj/WebCoreCommon.vsprops:
+ * dom/default/PlatformMessagePortChannel.h:
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- https://bugs.webkit.org/show_bug.cgi?id=21304
- Stop using a static wrapper map for WebCore JS bindings
+2009-06-21 David Levin <levin@chromium.org>
- The static domObjects map was not thread safe.
+ Reviewed by NOBODY (Speculative tiger build fix).
- * dom/Document.h:
- (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message
- ports.
- (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
+ * dom/default/PlatformMessagePortChannel.h:
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
- * dom/Document.cpp:
- (WebCore::Document::createdXMLHttpRequest):
- (WebCore::Document::destroyedXMLHttpRequest):
- Moved XMLHttpRequest tracking from a global map to Document.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * webcore-base.bkl:
- * bindings/DOMProtect.cpp: Removed.
- * bindings/DOMProtect.h: Removed.
- Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference,
- so they can no longer protect bindings objects.
+2009-06-21 Drew Wilson <atwilson@google.com>
- * dom/MessagePort.cpp:
- (WebCore::CloseMessagePortTimer::CloseMessagePortTimer):
- (WebCore::CloseMessagePortTimer::fired):
- (WebCore::MessagePort::MessagePort):
- (WebCore::MessagePort::queueCloseEvent):
- (WebCore::MessagePort::setPendingActivity):
- (WebCore::MessagePort::unsetPendingActivity):
- * dom/MessagePort.h:
- (WebCore::MessagePort::hasPendingActivity):
- MessagePort now counts outstanding async events, so JSDocument::mark can decide whether
- to protect it.
+ Reviewed by David Levin.
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::hasPendingActivity):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::~XMLHttpRequest):
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::dropProtection):
- (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
- (WebCore::XMLHttpRequest::cancelRequests):
- (WebCore::XMLHttpRequest::detachRequests):
- (WebCore::XMLHttpRequest::setPendingActivity):
- (WebCore::XMLHttpRequest::unsetPendingActivity):
- Moved XMLHttpRequest tracking from a global map to Document.
+ <https://bugs.webkit.org/show_bug.cgi?id=26448>
+
+ Added optimized GC for MessagePorts when the entangled port is run by the same thread.
+ Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
* bindings/js/JSDOMBinding.cpp:
- (WebCore::wrapperSet):
- (WebCore::DOMObjectWrapperMap::mapFor):
- (WebCore::DOMObjectWrapperMap::get):
- (WebCore::DOMObjectWrapperMap::set):
- (WebCore::DOMObjectWrapperMap::remove):
- (WebCore::getCachedDOMObjectWrapper):
- (WebCore::cacheDOMObjectWrapper):
- (WebCore::forgetDOMObject):
- (WebCore::getCachedDOMNodeWrapper):
- (WebCore::forgetDOMNode):
- (WebCore::cacheDOMNodeWrapper):
- (WebCore::markActiveObjectsForDocument):
- * bindings/js/JSDOMBinding.h:
- (WebCore::createDOMObjectWrapper):
- (WebCore::getDOMObjectWrapper):
- Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet
- to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug).
- WebCore objects can never migrate between threads.
-
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::mark):
- Call markActiveObjectsForDocument() from JSDOMBinding.
-
- * bindings/js/JSCSSRuleCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSCSSValueCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::markDOMObjectWrapper):
- (WebCore::JSDOMWindow::mark):
- * bindings/js/JSEventCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSEventTarget.cpp:
- (WebCore::toJS):
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSMessageChannelCustom.cpp:
- (WebCore::JSMessageChannel::mark):
+ (WebCore::markActiveObjectsForContext):
+ Now marks remotely entangled ports as in-use, in addition to those with pending activity.
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::mark):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::mark):
- * bindings/js/JSSVGPathSegCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSStyleSheetCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::finishedWithEvent):
- * bindings/scripts/CodeGeneratorJS.pm:
- Pass a JSGlobalData reference to functions that track JS wrapper objects.
-
-2008-10-02 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * page/JavaScriptCallFrame.idl:
-
-2008-10-02 Oliver Hunt <oliver@apple.com>
-
- Reviewed by NOBODY (Build fix).
-
- Add new file to project files
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-10-02 Geoffrey Garen <ggaren@apple.com>
-
- Not reviewed.
+ Now checks if the entangled port is local (run by same thread) and if so mark()s it.
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::postMessage):
+ (WebCore::MessagePort::disentangle):
+ Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports.
+ (WebCore::MessagePort::start):
+ (WebCore::MessagePort::locallyEntangledPort):
+ Added API for fetching the entangled port if it is run by the same thread
+ * dom/MessagePort.h:
+ * dom/MessagePortProxyWrapper.h:
+ * dom/default/MessagePortProxy.cpp:
+ (WebCore::MessagePortProxyWrapper::locallyEntangledPort):
+ Added API for fetching the entangled port if it is run by the same thread
+ (WebCore::MessagePortProxy::hasPendingActivity):
+ Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages.
+ (WebCore::MessagePortProxy::locallyEntangledPort):
+ * dom/default/MessagePortProxy.h:
- Try to fix some more builds.
+2009-06-21 Drew Wilson <atwilson@google.com>
- * GNUmakefile.am:
- * WebCore.pro:
+ Reviewed by David Levin.
-2008-10-02 Geoffrey Garen <ggaren@apple.com>
+ <https://bugs.webkit.org/show_bug.cgi?id=25043>
+ Removed obsolete MessagePort.startConversation(), active and onclose APIs.
- Not reviewed.
+ Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
+ implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
+ entirely into the platform-dependent proxy.
- Try to fix Windows build.
+ Created a thread-safe default PlatformMessagePortChannel implementation.
+ Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
+ cross-thread MessagePorts work.
+
+ * GNUMakefile.am:
* WebCore.vcproj/WebCore.vcproj:
-
-2008-10-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler and Cameron Zwarich.
-
- Updated for JavaScriptCore API changes: use a SourceCode instead of
- broken out parameters; treat sourceId as intptr_t.
-
- * ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::send):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- * bindings/js/StringSourceProvider.h:
- (WebCore::StringSourceProvider::create):
- (WebCore::StringSourceProvider::StringSourceProvider):
-
- (WebCore::makeSource): Added a makeSource function for convenience.
-
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject evaluateWebScript:]):
- * bridge/NP_jsobject.cpp:
- (_NPN_Evaluate):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::eval):
- (JavaJSObject::getMember):
- (JavaJSObject::setMember):
- (JavaJSObject::removeMember):
-
- * bridge/jni/jni_runtime.h:
- (JSC::Bindings::JavaString::operator UString): Replaced the explicit
- ustring() function with an implicit operator because this class already
- holds a UString::rep.
-
- * page/Console.cpp:
- (WebCore::retrieveLastCaller):
- (WebCore::Console::trace):
- * page/InspectorController.cpp:
- (WebCore::jsStringRef):
- (WebCore::InspectorController::addBreakpoint):
- (WebCore::InspectorController::removeBreakpoint):
- (WebCore::InspectorController::didParseSource):
- (WebCore::InspectorController::failedToParseSource):
- * page/InspectorController.h:
- * page/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
- * page/JavaScriptCallFrame.h:
- (WebCore::JavaScriptCallFrame::create):
- (WebCore::JavaScriptCallFrame::sourceIdentifier):
- (WebCore::JavaScriptCallFrame::update):
- * page/JavaScriptDebugListener.h:
- * page/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::addBreakpoint):
- (WebCore::JavaScriptDebugServer::removeBreakpoint):
- (WebCore::JavaScriptDebugServer::hasBreakpoint):
- (WebCore::dispatchDidParseSource):
- (WebCore::dispatchFailedToParseSource):
- (WebCore::JavaScriptDebugServer::sourceParsed):
- (WebCore::JavaScriptDebugServer::callEvent):
- (WebCore::JavaScriptDebugServer::atStatement):
- (WebCore::JavaScriptDebugServer::returnEvent):
- (WebCore::JavaScriptDebugServer::exception):
- (WebCore::JavaScriptDebugServer::willExecuteProgram):
- (WebCore::JavaScriptDebugServer::didExecuteProgram):
- (WebCore::JavaScriptDebugServer::didReachBreakpoint):
- * page/JavaScriptDebugServer.h:
- * page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and
- sourceIdentifier to sourceID.
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Geoffrey Garen.
-
- - fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html
-
- Broke a ref cycle by changing the m_svgFontFaceElement members of
- CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
- pointers. Also made sure that the @font-face rule added by
- SVGFontFaceElement to the document's mapped element sheet is removed
- when the font-face element is deleted or moved to another document.
-
- * css/CSSFontFaceSource.cpp:
- (WebCore::CSSFontFaceSource::CSSFontFaceSource):
- (WebCore::CSSFontFaceSource::getFontData):
- * css/CSSFontFaceSource.h:
- (WebCore::CSSFontFaceSource::svgFontFaceElement):
- * css/CSSFontFaceSrcValue.h:
- (WebCore::CSSFontFaceSrcValue::svgFontFaceElement):
- (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
- * svg/SVGFontFaceElement.cpp:
- (WebCore::SVGFontFaceElement::~SVGFontFaceElement):
- (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument):
- (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument):
- (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
- * svg/SVGFontFaceElement.h:
-
-2008-10-01 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20315: Memory leak with Canvas getImageData
- <https://bugs.webkit.org/show_bug.cgi?id=20315>
-
- This wasn't a leak, the issue was that we were reporting the cost
- of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
- and we should have been reporting the cost when we create the
- JSImageData wrapper.
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed.
- This was only needed to report the extra memory cost
- of the CPA.
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- We need a custom toJS function now so that we can report
- the extra memory cost.
- * bindings/scripts/CodeGeneratorJS.pm:
- Need to replace the reference to CanvasPixelArray with ImageData
- to be able to create the custom toJS implementation.
- * html/CanvasPixelArray.idl:
- * html/ImageData.idl:
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - https://bugs.webkit.org/show_bug.cgi?id=21293
- REGRESSION: Crash beneath RenderSVGViewportContainer::viewportTransform() during SVGSVGElement destruction
-
- * svg/SVGMarkerElement.cpp:
- (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so
- that renderer destruction happens before the SVGMarkerElement is
- destroyed.
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
-
-2008-10-01 Evan Martin <evan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20669
-
- * css/makeprop.pl:
- Die if gperf fails.
-
-2008-10-01 Evan Martin <evan@chromium.org>
-
- Reviewed by Eric Seidel.
-
- * loader/icon/IconDatabase.h:
- IconDatabase uses HashMap, so it needs to #include the header.
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
-
- * loader/Cache.cpp:
- (WebCore::Cache::remove): Disable pruning temporarily during
- CachedResource deletion.
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
-
- * svg/SVGFontFaceElement.cpp:
- (WebCore::SVGFontFaceElement::rebuildFontFace):
- * svg/SVGFontFaceElement.h:
- (WebCore::SVGFontFaceElement::associatedFontElement):
-
-2008-10-01 Brett Wilson <brettw@chromium.org>
-
- Reviewed by Maciej Stachowiak.
-
- Document the rounding behavior of the mapRect(IntRect) function in
- AffineTransform.h.
-
- * platform/graphics/AffineTransform.h:
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- Move prohibitsScrolling from the Frame to the ScrollView.
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * page/Frame.cpp:
- (WebCore::FramePrivate::FramePrivate):
- * page/Frame.h:
- * page/FramePrivate.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::scrollRectIntoViewRecursively):
- (WebCore::FrameView::setScrollPosition):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::init):
- (WebCore::ScrollView::scrollRectIntoViewRecursively):
- (WebCore::ScrollView::setScrollPosition):
- * platform/ScrollView.h:
- (WebCore::ScrollView::setProhibitsScrolling):
- (WebCore::ScrollView::prohibitsScrolling):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2008-10-01 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Geoff Garen.
-
- Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
- that we do during the loadRequestAsynchronously of the preflight request with a deref and
- GC unprotect.
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
- clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.
-
- Reviewed by Tim Hatcher
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::setCanHaveScrollbars):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setCanHaveScrollbars):
- (WebCore::ScrollView::wheelEvent):
- * platform/ScrollView.h:
- (WebCore::ScrollView::canHaveScrollbars):
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix some CachedResource leaks seen on buildbot
-
- The issue here was that emptying the cache was a no-op when it only
- contained resources with no data. Changed to go after those
- resources when the desired cache capacity is zero.
-
- * loader/Cache.cpp:
- (WebCore::Cache::pruneLiveResources):
- (WebCore::Cache::pruneDeadResources):
- * loader/Cache.h:
- (WebCore::Cache::prune):
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
- HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)
-
- Reviewed by Adam Roben
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::isOffscreen):
- (WebCore::ScrollView::platformIsOffscreen):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformIsOffscreen):
- * platform/qt/ScrollViewQt.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- Make show/hide/setParentVisible cross-platform on ScrollView.
-
- Reviewed by Adam Roben
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setParentVisible):
- (WebCore::ScrollView::show):
- (WebCore::ScrollView::hide):
- * platform/ScrollView.h:
- * platform/win/ScrollViewWin.cpp:
-
-2008-10-01 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- https://bugs.webkit.org/show_bug.cgi?id=21284
- Bug 21284: Max height affects max width
- - Looks like a cut and paste bug
- - Added layout test fast/css/max-height-and-max-width.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21282
-
- Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.
-
- Reviewed by Adam Roben
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::screenToWindow):
- (WebCore::EmptyChromeClient::windowToScreen):
- * page/Chrome.cpp:
- (WebCore::Chrome::screenToWindow):
- (WebCore::Chrome::windowToScreen):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * platform/HostWindow.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::contentsToScreen):
- (WebCore::ScrollView::screenToContents):
- (WebCore::ScrollView::platformContentsToScreen):
- (WebCore::ScrollView::platformScreenToContents):
- * platform/ScrollView.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformContentsToScreen):
- (WebCore::ScrollView::platformScreenToContents):
- * platform/win/ScrollViewWin.cpp:
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
-
- Test: fast/parser/residual-style-close-across-removed-block.html
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed
- an assertion that turned out to be wrong in this case, and changed to
- terminate the algorithm at the first empty block.
-
-2008-10-01 David Hyatt <hyatt@apple.com>
-
- Make setFrameRect on ScrollView cross-platform.
-
- Reviewed by Sam Weinig
-
- * page/FrameView.h:
- (WebCore::FrameView::contentsResized):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setFrameRect):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
-
-2008-10-01 Sam Weinig <sam@webkit.org>
-
- Reviewed by Adele Peterson.
-
- Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
- to JSDOMWindow from JSDOMWindowBase.
-
* WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::removeTimeout):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::setTimeoutOrInterval):
- (WebCore::JSDOMWindow::setTimeout):
- (WebCore::JSDOMWindow::clearTimeout):
- (WebCore::JSDOMWindow::setInterval):
- (WebCore::JSDOMWindow::clearInterval):
- (WebCore::JSDOMWindow::atob):
- (WebCore::JSDOMWindow::btoa):
- * page/DOMWindow.idl:
-
-2008-10-01 Dan Bernstein <mitz@apple.com>
-
- - Mac build fix
-
- * WebCore.base.exp:
-
-2008-10-01 Timothy Hatcher <timothy@apple.com>
-
- Prevent stealing focus from the search field when focusing a DOM node.
-
- https://bugs.webkit.org/show_bug.cgi?id=21275
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged):
- Don't steal focus if the current focus element is the search field.
-
-2008-09-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.
-
- Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
- Autogenerate JS event listeners
-
- - Generate getting/setting of EventListeners.
-
- - Adding a new named EventListener now has the same process as adding any other DOM
- attribute. (Add a method with the same name in the c++ file).
-
- (The EventListeners for MessagePort have been intentionally left custom so that we
- can continue to experiment with making those EventListeners work in a frame-less world.)
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
- * bindings/js/JSDOMWindowCustom.cpp: ditto.
- * bindings/js/JSEventTargetNodeCustom.cpp: ditto.
- * bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
- * bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener
- getter/setters
- * dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
- * dom/EventTargetNode.h: ditto.
- * dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator
- will use JSEventListerner instead of JSUnprotectedEventListener.
- * loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
- * page/DOMWindow.cpp: Add getter/setters for named EventListener
- * page/DOMWindow.h: ditto.
- * page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator
- will use JSEventListerner instead of JSUnprotectedEventListener.
- * xml/XMLHttpRequest.idl: Remove custom attributes.
- * xml/XMLHttpRequestUpload.idl: ditto.
-
-2008-09-30 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Add a leak counter for CachedResources since we've had two recent leaks involving them.
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::CachedResource):
- (WebCore::CachedResource::~CachedResource):
-
-2008-09-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21127
- <rdar://problem/6259134> REGRESSION: CFF format fonts fail to load
-
- If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
- the font name in memory.
-
- * WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to
- OpenTypeUtilities.*.
-
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call
- to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is
- used.
- (WebCore::FontCustomPlatformData::fontPlatformData): Added a code path
- for fonts loaded using AddFontMemResourceEx.
- (WebCore::createFontCustomPlatformData): Added a call to
- renameAndActivateFont() if TTLoadEmbeddedFont fails. If
- TTLoadEmbeddedFont succeeds, set the font name to the null string, as
- fontPlatformData() will retrieve the name from the font reference.
-
- * platform/graphics/win/FontCustomPlatformData.h:
- (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
- font name member.
-
- * platform/graphics/win/GetEOTHeader.cpp: Renamed.
- * platform/graphics/win/GetEOTHeader.h: Renamed.
-
- * platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp.
- (WebCore::BigEndianUShort::BigEndianUShort): Added a constructor.
- (WebCore::BigEndianULong::BigEndianULong): Ditto.
- (WebCore::renameAndActivateFont): Added. Creates an in-memory copy of
- the font data and modifies it to have the given name, then activates
- it using AddFontMemResourceEx.
-
- * platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
-
-2008-09-30 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix many leaks seen on fast/backgrounds/svg-as-mask.html.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
- with calls to removeClient when we're being destroyed.
-
-2008-09-30 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti Koivisto.
-
- https://bugs.webkit.org/show_bug.cgi?id=21243
-
- Fix loopstart and loopend default values.
-
- Tests: media/loopend-limits.html
- media/loopstart-limits.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value
- (WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value
-
-2008-09-30 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.
-
- * WebCoreSources.bkl:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
-
-2008-09-30 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix HTMLViewSourceDocument leaks by breaking a ref cycle which
- was fixed in r17249 and re-introduced in r31435.
-
- * html/HTMLViewSourceDocument.cpp:
- (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
- (WebCore::HTMLViewSourceDocument::addLine):
- (WebCore::HTMLViewSourceDocument::addLink):
- * html/HTMLViewSourceDocument.h:
-
-2008-09-30 Sam Weinig <sam@webkit.org>
-
- Reviewed by Eric Seidel.
-
- More for https://bugs.webkit.org/show_bug.cgi?id=21122
- Autogenerate JS event listeners
-
- - Make EventListener getter/setters names in c++ files match those in
- JS (ie. onLoadListener -> onload).
- - Add standard way to access the frame associated with the EventTarget
- for EventListener lookup.
- - Autogenerate dispatchEvent, it wasn't doing anything custom.
-
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::mark):
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- (WebCore::JSDOMApplicationCache::setOnchecking):
- (WebCore::JSDOMApplicationCache::onchecking):
- (WebCore::JSDOMApplicationCache::setOnerror):
- (WebCore::JSDOMApplicationCache::onerror):
- (WebCore::JSDOMApplicationCache::setOnnoupdate):
- (WebCore::JSDOMApplicationCache::onnoupdate):
- (WebCore::JSDOMApplicationCache::setOndownloading):
- (WebCore::JSDOMApplicationCache::ondownloading):
- (WebCore::JSDOMApplicationCache::setOnprogress):
- (WebCore::JSDOMApplicationCache::onprogress):
- (WebCore::JSDOMApplicationCache::setOnupdateready):
- (WebCore::JSDOMApplicationCache::onupdateready):
- (WebCore::JSDOMApplicationCache::setOncached):
- (WebCore::JSDOMApplicationCache::oncached):
- * bindings/js/JSEventTargetNodeCustom.cpp:
- (WebCore::JSEventTargetNode::addEventListener):
- (WebCore::JSEventTargetNode::removeEventListener):
- (WebCore::JSEventTargetNode::getListener):
- (WebCore::JSEventTargetNode::setListener):
+ Added MessagePortChannel/PlatformMessagePortChannel files.
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::mark):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- (WebCore::JSMessagePort::setOnmessage):
- (WebCore::JSMessagePort::onmessage):
- (WebCore::JSMessagePort::setOnclose):
- (WebCore::JSMessagePort::onclose):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark):
- (WebCore::JSXMLHttpRequest::onreadystatechange):
- (WebCore::JSXMLHttpRequest::setOnreadystatechange):
- (WebCore::JSXMLHttpRequest::onabort):
- (WebCore::JSXMLHttpRequest::setOnabort):
- (WebCore::JSXMLHttpRequest::onerror):
- (WebCore::JSXMLHttpRequest::setOnerror):
- (WebCore::JSXMLHttpRequest::onload):
- (WebCore::JSXMLHttpRequest::setOnload):
- (WebCore::JSXMLHttpRequest::onloadstart):
- (WebCore::JSXMLHttpRequest::setOnloadstart):
- (WebCore::JSXMLHttpRequest::onprogress):
- (WebCore::JSXMLHttpRequest::setOnprogress):
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark):
- (WebCore::JSXMLHttpRequestUpload::onabort):
- (WebCore::JSXMLHttpRequestUpload::setOnabort):
- (WebCore::JSXMLHttpRequestUpload::onerror):
- (WebCore::JSXMLHttpRequestUpload::setOnerror):
- (WebCore::JSXMLHttpRequestUpload::onload):
- (WebCore::JSXMLHttpRequestUpload::setOnload):
- (WebCore::JSXMLHttpRequestUpload::onloadstart):
- (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
- (WebCore::JSXMLHttpRequestUpload::onprogress):
- (WebCore::JSXMLHttpRequestUpload::setOnprogress):
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/EventTarget.h:
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::associatedFrame):
- * dom/EventTargetNode.h:
- * dom/EventTargetNode.idl:
+ Changed ports to not mark their entangled pair as reachable, per the spec.
+ * bindings/v8/custom/V8MessagePortCustom.cpp:
+ * dom/MessageChannel.cpp:
+ (WebCore::MessageChannel::MessageChannel):
+ Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
* dom/MessagePort.cpp:
- (WebCore::MessagePort::associatedFrame):
- * dom/MessagePort.h:
+ (WebCore::MessagePort::MessagePort):
+ (WebCore::MessagePort::~MessagePort):
+ (WebCore::MessagePort::postMessage):
+ (WebCore::MessagePort::disentangle):
+ (WebCore::MessagePort::messageAvailable):
+ (WebCore::MessagePort::start):
+ (WebCore::MessagePort::close):
+ (WebCore::MessagePort::entangle):
+ (WebCore::MessagePort::contextDestroyed):
+ (WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::setOnmessage):
- (WebCore::MessagePort::onmessage):
- (WebCore::MessagePort::setOnclose):
- (WebCore::MessagePort::onclose):
+ (WebCore::MessagePort::hasPendingActivity):
+ Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
+ * dom/MessagePort.h:
+ Renamed isQueueOpen() to started().
* dom/MessagePort.idl:
- * loader/appcache/DOMApplicationCache.h:
- (WebCore::DOMApplicationCache::setOnchecking):
- (WebCore::DOMApplicationCache::onchecking):
- (WebCore::DOMApplicationCache::setOnerror):
- (WebCore::DOMApplicationCache::onerror):
- (WebCore::DOMApplicationCache::setOnnoupdate):
- (WebCore::DOMApplicationCache::onnoupdate):
- (WebCore::DOMApplicationCache::setOndownloading):
- (WebCore::DOMApplicationCache::ondownloading):
- (WebCore::DOMApplicationCache::setOnprogress):
- (WebCore::DOMApplicationCache::onprogress):
- (WebCore::DOMApplicationCache::setOnupdateready):
- (WebCore::DOMApplicationCache::onupdateready):
- (WebCore::DOMApplicationCache::setOncached):
- (WebCore::DOMApplicationCache::oncached):
- (WebCore::DOMApplicationCache::associatedFrame):
- * loader/appcache/DOMApplicationCache.idl:
- * svg/EventTargetSVGElementInstance.cpp:
- (WebCore::EventTargetSVGElementInstance::associatedFrame):
- (WebCore::EventTargetSVGElementInstance::addEventListener):
- (WebCore::EventTargetSVGElementInstance::removeEventListener):
- (WebCore::EventTargetSVGElementInstance::dispatchEvent):
- * svg/EventTargetSVGElementInstance.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::associatedFrame):
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::setOnreadystatechange):
- (WebCore::XMLHttpRequest::onreadystatechange):
- (WebCore::XMLHttpRequest::setOnabort):
- (WebCore::XMLHttpRequest::onabort):
- (WebCore::XMLHttpRequest::setOnerror):
- (WebCore::XMLHttpRequest::onerror):
- (WebCore::XMLHttpRequest::setOnload):
- (WebCore::XMLHttpRequest::onload):
- (WebCore::XMLHttpRequest::setOnloadstart):
- (WebCore::XMLHttpRequest::onloadstart):
- (WebCore::XMLHttpRequest::setOnprogress):
- (WebCore::XMLHttpRequest::onprogress):
- * xml/XMLHttpRequest.idl:
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::associatedFrame):
- * xml/XMLHttpRequestUpload.h:
- (WebCore::XMLHttpRequestUpload::setOnabort):
- (WebCore::XMLHttpRequestUpload::onabort):
- (WebCore::XMLHttpRequestUpload::setOnerror):
- (WebCore::XMLHttpRequestUpload::onerror):
- (WebCore::XMLHttpRequestUpload::setOnload):
- (WebCore::XMLHttpRequestUpload::onload):
- (WebCore::XMLHttpRequestUpload::setOnloadstart):
- (WebCore::XMLHttpRequestUpload::onloadstart):
- (WebCore::XMLHttpRequestUpload::setOnprogress):
- (WebCore::XMLHttpRequestUpload::onprogress):
- * xml/XMLHttpRequestUpload.idl:
-
-2008-09-30 Darin Adler <darin@apple.com>
-
- - roll out assertion breaking regression tests
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion
- that fires in regression tests. Hyatt can add it back later. The assertion
- fires in the regression test because of layout that triggers repaint occuring
- during the process of removing a frame.
-
-2008-09-30 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
- <rdar://problem/6222134> add a way to set color for input placeholder text
-
- Test: fast/forms/placeholder-pseudo-style.html
-
- This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
- input elements when they are displaying the placeholder text.
-
- * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
- * css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
- * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
- * css/html4.css: Add rule to make placeholder text default to darkGray.
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
- (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
- (WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
- (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
- (WebCore::HTMLInputElement::setValue): ditto.
- (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
- (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
- This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
- renderer will just ask the node if it should draw the placeholder.
- * html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
-
- * rendering/RenderTextControl.cpp:
- (WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color,
- just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast.
- If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
- (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
- This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
- is called directly from updateFromElement. updateFromElement will immediately update the text displayed.
- (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
- (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
- * rendering/RenderTextControl.h:
-
-2008-09-30 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
- by failed allocation due to invalid counter/attr
- and corresponding: <rdar://problem/6152371>
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseCounterContent): The spec indicates that
- only identifiers should be accepted here.
-
-2008-09-30 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Bug 21255: console.profileEnd() without a console.profile() crashes the
- web inspector
-
- * page/Console.cpp:
- (WebCore::Console::profileEnd):
-
-2008-09-30 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Bug 21252: calling console.profile() with a title that is 2 chars or
- shorter does not linkify it
-
- - Previously we tried to not linkify very short URLs but since profile
- titles can be any length this is not always true.
-
- * page/inspector/inspector.js:
-
-2008-09-30 Dave Hyatt <hyatt@apple.com>
-
- Remove the update() method on ScrollView. This method was only called in one place, and its purpose
- was to cause a display/flush to happen. Here is a breakdown of the method use on each platform:
- (1) Not used on Mac
- (2) Used on Windows
- (3) Used on Qt, but implemented incorrectly to cause a full repaint for no reason.
- (4) Used on Gtk, but implemented incorrectly to cause a full repaint for no reason.
- (5) Used on wx, but probably not needed (since wx has platform widgets like Mac).
-
- There is now a paint method on HostWindow that does an immediate mode repaint of an empty rect to
- cause the display/flush to happen if needed (thus saving an extra method on ChromeClient).
- With the changes to this method, the new behavior is as follows:
- (1) Not used on Mac
- (2) Used on Windows
- (3) Nothing happens on Qt, but only because they have not implemented immediate mode updating.
- (4) Gtk now behaves like Windows and will process updates but not do any incorrect additional invalidation.
- (5) Not used on wx
-
- This method was originally added for Windows. It's not clear the display/flush is really even necessary on the other
- platforms. At the very least stopping unnecessary full invalidations on Qt/Gtk is a good thing. :)
-
- Reviewed by Sam Weinig
-
- * ChangeLog:
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
- * platform/HostWindow.h:
- (WebCore::HostWindow::paint):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-09-30 Timothy Hatcher <timothy@apple.com>
-
- Focus the DOM tree in the Web Inspector when a node is inspected.
- So when the search field has focus, the focus moves to the tree,
- allowing the arrow keys work. This can happen when using the new
- find in page feature.
-
- https://bugs.webkit.org/show_bug.cgi?id=21251
-
- Reviewed by Geoff Garen.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel): Set currentFocusElement to
- the main-panels element if the panel is visible.
- (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
- Remove a set of currentFocusElement since this moved.
- * page/inspector/inspector.js:
- (WebInspector.set currentFocusElement): Always focus the element.
- This ensures that when focus changes in the page and we don't
- catch it, we will still focus the elements even if we think it
- was already focused.
-
-2008-09-30 Timothy Hatcher <timothy@apple.com>
-
- Make the Web Inspector's toolbar icons darker when the mouse is
- pressed on them. This matches the standard NSToolbar look.
-
- https://bugs.webkit.org/show_bug.cgi?id=21249
- rdar://problem/6033752
-
- Reviewed by Adam Roben.
-
- * page/inspector/Images/databasesIcon.png:
- * page/inspector/Images/elementsIcon.png:
- * page/inspector/Images/profilesIcon.png:
- * page/inspector/Images/resourcesIcon.png:
- * page/inspector/Images/scriptsIcon.png:
- * page/inspector/Panel.js:
- * page/inspector/inspector.css:
-
-2008-09-30 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Bug 21139: Profiler log message is wrong
- - Correctly fix =(
- Don't call _format twice.
-
- * page/Page.h:
- * page/inspector/Console.js:
- * page/inspector/ProfilesPanel.js:
- * page/inspector/inspector.js:
-
-2008-09-30 Dave Hyatt <hyatt@apple.com>
-
- http://bugs.webkit.org/show_bug.cgi?id=21250
-
- Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
- repaints up through the ChromeClient.
-
- Reviewed by Darin Adler
-
- * loader/EmptyClients.h:
- (WebCore::EmptyChromeClient::repaint):
- * page/Chrome.cpp:
- (WebCore::Chrome::repaint):
- * page/Chrome.h:
- * page/ChromeClient.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::hostWindow):
- (WebCore::FrameView::repaintContentRectangle):
- * page/FrameView.h:
- * platform/HostWindow.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::repaintContentRectangle):
- (WebCore::ScrollView::platformRepaintContentRectangle):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformRepaintContentRectangle):
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformRepaintContentRectangle):
-
-2008-09-30 Alexey Proskuryakov <ap@webkit.org>
-
- Non-Mac build fixes.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCoreSources.bkl:
- * webcore-base.bkl:
- Added DOMProtect.{cpp,h}.
-
-2008-09-39 Kevin Decker <kdecker@apple.com>
-
- Reviewed by John Sullivan.
-
- * bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way
- for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
-
-2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21106: .in format discussed changes
- https://bugs.webkit.org/show_bug.cgi?id=21106
-
- - Removed "cppNamespace" global parameter and hard-coded "WebCore" as it
- is the only namespace used.
-
- - Removed "generateFactory" and "generateWrapperFactory" parameters and
- re-introduced the command line options.
-
- - Cleaned up the output of make_names.pl (removed unneeded new line).
-
- * DerivedSources.make: Added factories command line options.
- * GNUmakefile.am: Ditto.
- * WebCore.pro: Ditto and removed some arguments that were migrated to
- the .in files.
-
- * dom/make_names.pl: Clean up (see above).
-
- * html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory"
- and "generateWrapperFactory" occurences.
- * html/HTMLTagNames.in: Ditto.
- * svg/svgattrs.in: Ditto.
- * svg/svgtags.in: Ditto.
- * svg/xlinkattrs.in: Ditto.
- * xml/xmlattrs.in: Ditto.
-
-2008-09-29 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by John Sullivan.
-
- <rdar://problem/6255456> AX: <file> input button shouldn't have children exposed
- Make sure that certain types of elements do not return children and, moreover, do not waste their
- energy trying to return children
-
- Test: accessibility/nochildren-elements.html
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::canHaveChildren):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::canHaveChildren):
- (WebCore::AccessibilityRenderObject::addChildren):
- * page/AccessibilityRenderObject.h:
-
-2008-09-30 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21213
- MessagePort crash when GC collects an object with a pending close event
-
- Test: fast/events/message-channel-gc-2.html
- fast/events/message-channel-listener-circular-ownership.html
-
- * bindings/DOMProtect.cpp: Added.
- (WebCore::gcProtectDOMObject):
- (WebCore::gcUnprotectDOMObject):
- * bindings/DOMProtect.h: Added.
- Added an abstraction for GC protection to avoid the need to call JS bindings code from
- DOM objects directly.
-
- * dom/MessagePort.cpp:
- (WebCore::CloseMessagePortTimer::fired):
- (WebCore::MessagePort::queueCloseEvent):
- GC protect MessagePort wrapper while there is a pending close event.
- This may be necessary for message events, too, but that case is not a crasher, and actually
- behaves to the letter of the current HTML5 text, so I'll consider it later.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::dropProtection):
- Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
-
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- (WebCore::JSMessagePort::setOnmessage):
- (WebCore::JSMessagePort::setOnclose):
- Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not
- know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
-
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark):
- While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not
- from XMLHttpRequest.
-
-2008-09-30 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * DerivedSources.cpp: Add JSEventTargetNode.cpp.
-
-2008-09-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Tim Hatcher.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
- Autogenerate JS event listeners
+ Removed startConversation and onclose.
+ * dom/MessagePortProxy.h: Removed.
+ * dom/MessagePortChannel.cpp: Added.
+ (WebCore::MessagePortChannel::EventData::create):
+ (WebCore::MessagePortChannel::EventData::EventData):
+ (WebCore::MessagePortChannel::~MessagePortChannel):
+ * dom/MessagePortChannel.h: Added.
+ (WebCore::MessagePortChannel::EventData::message):
+ (WebCore::MessagePortChannel::EventData::channel):
+ Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
+ (WebCore::MessagePortChannel::MessagePortChannel):
+ (WebCore::MessagePortChannel::create):
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
+ Renamed isQueueOpen() to started().
+ * dom/default/PlatformMessagePortChannel.cpp: Added.
+ (WebCore::MessagePortChannel::entangleIfOpen):
+ (WebCore::MessagePortChannel::disentangle):
+ (WebCore::MessagePortChannel::postMessageToRemote):
+ (WebCore::MessagePortChannel::tryGetMessageFromRemote):
+ (WebCore::MessagePortChannel::close):
+ (WebCore::MessagePortChannel::isConnectedTo):
+ (WebCore::MessagePortChannel::hasPendingActivity):
+ (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
+ (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
+ (WebCore::PlatformMessagePortChannel::createChannel):
+ (WebCore::PlatformMessagePortChannel::entangleIfOpen):
+ (WebCore::PlatformMessagePortChannel::disentangle):
+ (WebCore::PlatformMessagePortChannel::setRemotePort):
+ (WebCore::PlatformMessagePortChannel::remotePort):
+ (WebCore::PlatformMessagePortChannel::entangledChannel):
+ (WebCore::PlatformMessagePortChannel::setEntangledChannel):
+ (WebCore::PlatformMessagePortChannel::postMessageToRemote):
+ (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
+ (WebCore::PlatformMessagePortChannel::isConnectedTo):
+ (WebCore::PlatformMessagePortChannel::close):
+ (WebCore::PlatformMessagePortChannel::closeInternal):
+ (WebCore::PlatformMessagePortChannel::hasPendingActivity):
+ * dom/default/PlatformMessagePortChannel.h: Added.
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::create):
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty):
+ (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
+ * page/DOMWindow.cpp:
+ (WebCore::PostMessageTimer::PostMessageTimer):
+ Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
+ (WebCore::PostMessageTimer::event):
+ (WebCore::DOMWindow::postMessage):
+ (WebCore::DOMWindow::postMessageTimerFired):
- - Generate EventTargetNode.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventTarget.cpp: Added.
- (WebCore::toJS):
- * bindings/js/JSEventTarget.h: Added.
- * bindings/js/JSEventTargetBase.cpp: Removed.
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetNode.cpp: Removed.
- * bindings/js/JSEventTargetNode.h: Removed.
- * bindings/js/JSEventTargetNodeCustom.cpp: Added.
- (WebCore::JSEventTargetNode::addEventListener):
- (WebCore::JSEventTargetNode::removeEventListener):
- (WebCore::JSEventTargetNode::dispatchEvent):
- (WebCore::JSEventTargetNode::getListener):
- (WebCore::JSEventTargetNode::setListener):
- (WebCore::JSEventTargetNode::pushEventHandlerScope):
- * bindings/js/JSEventTargetSVGElementInstance.cpp:
- (WebCore::):
- (WebCore::JSEventTargetSVGElementInstancePrototype::self):
- (WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot):
- (jsEventTargetAddEventListener):
- (jsEventTargetRemoveEventListener):
- (jsEventTargetDispatchEvent):
- * bindings/js/JSEventTargetSVGElementInstance.h:
- (WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype):
- (WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/EventTargetNode.idl: Added.
-
-2008-09-29 Darin Adler <darin@apple.com>
+2009-06-21 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- - https://bugs.webkit.org/show_bug.cgi?id=21214
- work on getting rid of ExecState
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument
- for base class constructor.
-
-2008-09-29 David Hyatt <hyatt@apple.com>
-
- Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
- now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
- and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
- (Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * page/Chrome.h:
- * platform/HostWindow.h: Added.
- (WebCore::HostWindow::HostWindow):
- (WebCore::HostWindow::~HostWindow):
-
-2008-09-29 Kevin Decker <kdecker@apple.com>
-
- Reviewed by Anders Carlsson.
-
- * bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
- 2000.
-
-2008-09-29 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Adam Roben.
-
- - WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added.
- (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being
- unloaded, to avoid calling uxtheme.dll functions after that library has
- been unloaded.
- * rendering/RenderThemeWin.h:
-
-2008-09-29 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by John Sullivan
-
- <rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas
-
- Sends AXLoadComplete only when the top level web area is finished loading
-
- * dom/Document.cpp:
- (WebCore::Document::implicitClose):
-
-2008-09-29 Timothy Hatcher <timothy@apple.com>
-
- Makes the node highlight always show up when hovering a node in
- the Web Inspector now that the highlight does not scroll to reveal
- the node. Also adds a hover effect in the inspector when hovering
- causes a highlight in the page. This ties the user hovering action
- to the highlight so it is clear what causes the highlight to appear.
-
- Also the highlight now temporarily shows up for 2 seconds after
- selecting a node in the DOM tree. So arrowing around in the tree
- will show the node on the page, providing feedback to the user.
-
- Plus fixes an issue where quickly moving away from hovering
- a node would keep showing the page highlight. This was happening
- in breadcrumbs and the DOM tree.
-
- https://bugs.webkit.org/show_bug.cgi?id=21220
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/Console.js:
- (WebInspector.Console.prototype._mouseOverNode): Added. Used for
- hovering DOM nodes in the console.
- (WebInspector.Console.prototype._mouseOutOfNode): Ditto.
- (WebInspector.Console.prototype._formatnode): Use the new event
- listeners and add a class name to the anchor element.
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel): Add new event listeners to the
- crumbs element to do the node hovering highlight.
- (WebInspector.ElementsPanel.prototype.hide):
- (WebInspector.ElementsPanel.prototype.reset):
- (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
- (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
- (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
- * page/inspector/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
- Show the node hishlight for 2 seconds then restore the highlight
- to the current hovered node.
- (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the
- hovered node and set the hovered state on the tree element.
- (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the
- hovered node to null and removed the hovered state from the previous
- hovered tree element.
- (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds
- the hovered class to the list item.
- (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
- * page/inspector/inspector.css:
- * page/inspector/inspector.js:
- (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon
- based on the showingDOMNodeHighlight property of 50ms or 500ms. This
- causes the highlight to change sooner if there is one already showing
- and appear later if there isn't one showing. This is like tooltips,
- hovering a node for 500ms will cause highlight then mousing between nodes
- will keep the highlight and change to the new node.
- (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and
- always reset the timeout so continuous mousing does not keep flasshing
- the highlight on the screen.
- (WebInspector._updateHoverHighlight): Removed the alt key check and added
- the showingDOMNodeHighlight property.
- (WebInspector.documentKeyDown): Removed the alt key check.
- (WebInspector.documentKeyUp): Ditto.
- (WebInspector.reset): Clear the hoveredDOMNode.
-
-2008-09-29 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Anders Carlsson
-
- Fix RenderStyle leak in animation code, and assert that
- keyframe resolution in CSSStyleSelector is not going to clobber
- m_style.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::~KeyframeAnimation):
+ - fix https://bugs.webkit.org/show_bug.cgi?id=15383
+ <rdar://problem/5682745> resize: vertical does not restrict to vertical
+ resize
-2008-09-29 Chris Marrin <cmarrin@apple.com>
+ Test: fast/css/resize-single-axis.html
- Reviewed by Dave Hyatt
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
- Rewrite keyframe resolution to be like styleForElement()
-
- Test: animations/lineheight-animation.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::addKeyframeStyle):
- (WebCore::CSSStyleSelector::~CSSStyleSelector):
- (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- (WebCore::CSSRuleSet::addRulesFromSheet):
- (WebCore::CSSStyleSelector::mapAnimationName):
- * css/CSSStyleSelector.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
- (WebCore::KeyframeAnimation::animate):
- (WebCore::KeyframeAnimation::hasAnimationForProperty):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- (WebCore::KeyframeAnimation::overrideAnimations):
- (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
- (WebCore::KeyframeAnimation::affectsProperty):
- (WebCore::KeyframeAnimation::validateTransformFunctionList):
- * page/animation/KeyframeAnimation.h:
- * rendering/style/Animation.cpp:
- (WebCore::Animation::animationsMatch):
- * rendering/style/Animation.h:
- * rendering/style/KeyframeList.cpp:
- (WebCore::KeyframeList::~KeyframeList):
- (WebCore::KeyframeList::clear):
- (WebCore::KeyframeList::insert):
- * rendering/style/KeyframeList.h:
- (WebCore::KeyframeValue::KeyframeValue):
- (WebCore::KeyframeList::KeyframeList):
- (WebCore::KeyframeList::operator!=):
- (WebCore::KeyframeList::animationName):
- (WebCore::KeyframeList::addProperty):
- (WebCore::KeyframeList::containsProperty):
- (WebCore::KeyframeList::beginProperties):
- (WebCore::KeyframeList::endProperties):
- (WebCore::KeyframeList::isEmpty):
- (WebCore::KeyframeList::size):
- (WebCore::KeyframeList::beginKeyframes):
- (WebCore::KeyframeList::endKeyframes):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleRareNonInheritedData.cpp:
- * rendering/style/StyleRareNonInheritedData.h:
-
-2008-09-29 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Eric Seidel
-
- Clean up fix in PropertyWrapperGetter::equals
- https://bugs.webkit.org/show_bug.cgi?id=21011
-
- Test: transitions/override-transition-crash.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::PropertyWrapperGetter::equals):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::resize): Ignore movement along the non-resizing
+ axis.
-2008-09-29 Chris Marrin <cmarrin@apple.com>
+2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel
- https://bugs.webkit.org/show_bug.cgi?id=21001
- Starting transition after animation, when animation
- is finished, transition is wrong.
-
- Test: animations/transition-and-animation-2.html
-
- * page/animation/AnimationBase.h:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- (WebCore::CompositeAnimation::resetTransitions):
- (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::ImplicitAnimation):
- (WebCore::ImplicitAnimation::~ImplicitAnimation):
- (WebCore::ImplicitAnimation::animate):
- (WebCore::ImplicitAnimation::reset):
- * page/animation/ImplicitAnimation.h:
-
-2008-09-29 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=20921
- -webkit-animation-timing-function: inside of keyframes is ignored
-
- Test: animations/keyframe-timing-functions.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::progress):
- * page/animation/AnimationBase.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::animate):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::animate):
-
-2008-09-29 Dan Bernstein <mitz@apple.com>
-
- - Windows build fix
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::platformScroll):
-
-2008-09-29 Dan Bernstein <mitz@apple.com>
-
- - another attempt at a Windows build fix
-
- * platform/ScrollView.cpp:
- (WebCore::platformScroll):
-
-2008-09-29 Dan Bernstein <mitz@apple.com>
-
- - Windows build fix
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::platformSetScrollPosition):
-
-2008-09-29 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21218
-
- Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
- It's silly that the code was this fragile, but for now just put the check back in.
-
- Reviewed by Dan Bernstein
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setScrollbarModes):
-
-2008-09-29 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21216
-
- Make setScrollPosition and scroll() cross-platform.
-
- Reviewed by Anders
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
+ event.currentTarget for listener registered on window should point to the window object like in Firefox
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setScrollPosition):
- (WebCore::ScrollView::scroll):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformSetScrollPosition):
- (WebCore::ScrollView::platformScroll):
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetScrollPosition):
- (WebCore::ScrollView::platformScroll):
-
-2008-09-29 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Oliver.
-
- Bug 21139: Profiler log message is wrong
- - Because _format was called twice the number in the log was incremented
- too many times, but we were passing it around in the link the whole time
-
- * page/inspector/ProfilesPanel.js:
- * page/inspector/inspector.js:
+ Test: fast/events/event-trace.html
-2008-09-29 Sam Weinig <sam@webkit.org>
-
- Reviewed by Cameron Zwarich.
-
- Autogenerate EventListeners, addEventListener and removeEventListener
- for JSDOMWindow.
-
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::onwebkitanimationstart):
- (WebCore::JSDOMWindow::setOnwebkitanimationstart):
- (WebCore::JSDOMWindow::onwebkitanimationiteration):
- (WebCore::JSDOMWindow::setOnwebkitanimationiteration):
- (WebCore::JSDOMWindow::onwebkitanimationend):
- (WebCore::JSDOMWindow::setOnwebkitanimationend):
- (WebCore::JSDOMWindow::onwebkittransitionend):
- (WebCore::JSDOMWindow::setOnwebkittransitionend):
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- (WebCore::JSDOMWindow::setListener):
- (WebCore::JSDOMWindow::getListener):
- * bindings/scripts/CodeGeneratorJS.pm:
- * page/DOMWindow.idl:
-
-2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
-
- Reviewed by Simon.
-
- Changed copyright from Trolltech ASA to Nokia.
-
- Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
-
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- * bindings/js/JSNavigatorCustom.cpp:
- * bindings/js/JSPluginArrayCustom.cpp:
- * bindings/js/JSPluginCustom.cpp:
- * bindings/js/ScriptControllerMac.mm:
- * bindings/js/ScriptControllerQt.cpp:
- * bridge/qt/qt_class.cpp:
- * bridge/qt/qt_class.h:
- * bridge/qt/qt_instance.cpp:
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- * bridge/qt/qt_runtime.h:
- * bridge/testqtbindings.cpp:
- * css/makegrammar.pl:
- * css/makeprop.pl:
- * css/makevalues.pl:
* dom/Node.cpp:
- * dom/TagNodeList.cpp:
- * dom/TagNodeList.h:
- * dom/XMLTokenizer.cpp:
- * dom/XMLTokenizer.h:
- * dom/XMLTokenizerLibxml2.cpp:
- * dom/XMLTokenizerQt.cpp:
- * editing/Editor.cpp:
- * editing/EditorCommand.cpp:
- * html/CanvasRenderingContext2D.cpp:
- * html/CanvasStyle.cpp:
- * html/HTMLAppletElement.cpp:
- * html/HTMLEmbedElement.cpp:
- * html/HTMLObjectElement.cpp:
- * loader/FrameLoader.cpp:
- * page/Chrome.cpp:
- * page/EditorClient.h:
- * page/Frame.cpp:
- * page/Frame.h:
- * page/FramePrivate.h:
- * page/Navigator.cpp:
- * page/Navigator.h:
- * page/Navigator.idl:
- * page/mac/FrameMac.mm:
- * page/qt/EventHandlerQt.cpp:
- * platform/graphics/qt/FontCacheQt.cpp:
- * platform/graphics/qt/FontCustomPlatformData.cpp:
- * platform/graphics/qt/FontCustomPlatformData.h:
- * platform/graphics/qt/FontPlatformData.h:
- * platform/graphics/qt/FontQt.cpp:
- * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- * platform/graphics/qt/ImageDecoderQt.cpp:
- * platform/graphics/qt/ImageDecoderQt.h:
- * platform/graphics/qt/ImageSourceQt.cpp:
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- * platform/graphics/qt/SimpleFontDataQt.cpp:
- * platform/gtk/MIMETypeRegistryGtk.cpp:
- * platform/mac/MIMETypeRegistryMac.mm:
- * platform/network/qt/QNetworkReplyHandler.cpp:
- * platform/network/qt/QNetworkReplyHandler.h:
- * platform/network/qt/ResourceHandleQt.cpp:
- * platform/network/qt/ResourceRequestQt.cpp:
- * platform/qt/ClipboardQt.cpp:
- * platform/qt/EventLoopQt.cpp:
- * platform/qt/KURLQt.cpp:
- * platform/qt/LoggingQt.cpp:
- * platform/qt/MIMETypeRegistryQt.cpp:
- * platform/qt/PasteboardQt.cpp:
- * platform/qt/PlatformScreenQt.cpp:
- * platform/qt/PopupMenuQt.cpp:
- * platform/qt/QWebPopup.cpp:
- * platform/qt/QWebPopup.h:
- * platform/qt/RenderThemeQt.cpp:
- * platform/qt/ScrollbarQt.cpp:
- * platform/qt/ScrollbarThemeQt.cpp:
- * platform/qt/WheelEventQt.cpp:
- * platform/qt/html4-adjustments-qt.css:
- * platform/wx/MimeTypeRegistryWx.cpp:
- * plugins/MimeType.cpp:
- * plugins/MimeType.h:
- * plugins/MimeType.idl:
- * plugins/MimeTypeArray.cpp:
- * plugins/MimeTypeArray.h:
- * plugins/MimeTypeArray.idl:
- * plugins/Plugin.cpp:
- * plugins/Plugin.h:
- * plugins/Plugin.idl:
- * plugins/PluginArray.cpp:
- * plugins/PluginArray.h:
- * plugins/PluginArray.idl:
- * plugins/PluginData.cpp:
- * plugins/PluginData.h:
- * plugins/gtk/PluginDataGtk.cpp:
- * plugins/mac/PluginDataMac.mm:
- * plugins/qt/PluginDataQt.cpp:
- * plugins/win/PluginDataWin.cpp:
- * rendering/RenderTableCol.cpp:
- * rendering/RenderTableCol.h:
-
-2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>
-
- Reviewed by Simon
-
- Fix compilation with gcc 4.3
-
- gcc 4.3 is stricter and ctype.h isn't getting included
- automatically here by dependencies. So do it directly.
-
- * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched
+ to it. We previously used the document because DOMWindow was not yet an EventTarget.
-2008-09-29 Morten Sørvig <msorvig@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compilation with Qt/Mac without plugins.
-
- * platform/qt/TemporaryLinkStubs.cpp:
-
-2008-09-29 Mark Rowe <mrowe@apple.com>
+2009-06-21 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
- In the few places that we call .upper() in WebCore the strings represent things like
- tag and attribute names, which are nearly always going to be ASCII.
-
- * platform/text/StringImpl.cpp:
- (WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
- in to Unicode::toLower the second time.
- (WebCore::StringImpl::upper):
+ - fix https://bugs.webkit.org/show_bug.cgi?id=9694
+ resize value not compared
-2008-09-28 Mark Rowe <mrowe@apple.com>
+ Test: fast/css/resize-value-compared.html
- Reviewed by Sam Weinig.
-
- Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
- rather than String::operator+=.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
-
-2008-09-28 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Speed up computedStyle.getPropertyValue('color') by 4.5x.
-
- Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
- as it avoids many memory reallocations.
-
- This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
- by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
- unrelated properties on an element.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
- and use appendNumber rather than the String::number in order to cut down on memory allocations.
- * platform/text/PlatformString.h:
- (WebCore::appendNumber): A helper function for formatting an unsigned character as a number
- into a Vector<UChar>.
-
-2008-09-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Remove spurious call to lower().
-
- * css/MediaQueryEvaluator.cpp:
- (WebCore::MediaQueryEvaluator):
-
-2008-09-28 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Use a CaseFoldingHash instead of calling lower on family strings.
-
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::addFontFaceRule):
- (WebCore::CSSFontSelector::getFontData):
- * css/CSSFontSelector.h:
-
-2008-09-28 Timothy Hatcher <timothy@apple.com>
+ * rendering/style/StyleRareInheritedData.cpp:
+ (WebCore::StyleRareInheritedData::operator==): Compare the resize
+ member.
- Remove the scrollIntoViewIfNeeded() call when drawing the
- Inspector node highlight.
+2009-06-19 Alice Liu <alice.liu@apple.com>
- <rdar://problem/6115804> Don't scroll when highlighting (21000)
- https://bugs.webkit.org/show_bug.cgi?id=21000
+ Fix https://bugs.webkit.org/show_bug.cgi?id=26568
+ Repro crash animating GIF if previously used in a closed window's back/forward list
+ Also filed as <rdar://problem/6978362>
- Reviewed by Dan Bernstein.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::drawNodeHighlight):
+ Reviewed by Maciej Stachowiak.
-2008-09-28 David Hyatt <hyatt@apple.com>
+ Can't test this bug with an automated layout test since it requires b/f caching
+ * manual-tests/animated-gif-bfcache-crash.html: Added.
+ * manual-tests/resources/containsAnimatedGif.html: Added.
- Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
- changed.
+ Adding checks for hostWindow() since there is no guarantee that the Page is alive
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+ (WebCore::ScrollView::contentsToScreen):
+ (WebCore::ScrollView::screenToContents):
+ (WebCore::ScrollView::wheelEvent):
- Reviewed by Dan Bernstein
+2009-06-20 Sam Weinig <sam@webkit.org>
- * platform/mac/ScrollbarThemeMac.mm:
- (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
+ Reviewed by Adam Barth.
-2008-09-28 Timothy Hatcher <timothy@apple.com>
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
+ Shadowing of top and parent
- Clear the current search results in the Inspector when
- the search query is less than 3 characters long. Incremental
- searches only occur for 3 characters or longer, but deleting
- under this limit would not clear the results unless the whole
- query was deleted.
+ * page/DOMWindow.idl:
- https://bugs.webkit.org/show_bug.cgi?id=21196
+2009-06-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
- * page/inspector/inspector.js:
- (WebInspector.performSearch): Check for short queries in the
- if statement that triggers the clear.
-
-2008-09-28 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
-
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and
- overlayLength parameters.
- (WebCore::EOTStream::read): Added code to overlay the
- m_overlayLength bytes starting at m_overlayDst with the same number of
- bytes from m_overlaySrc.
- (WebCore::createFontCustomPlatformData): Changed to get overlay
- parameters from getEOTHeader.
- * platform/graphics/win/GetEOTHeader.cpp:
- (WebCore::getEOTHeader): Added code to specify overlaying of the
- family name with the prefix of the full name if they differ, because
- that such a difference causes TTLoadEmbeddedFont to fail.
- * platform/graphics/win/GetEOTHeader.h:
-
-2008-09-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Eric Seidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20366
- Reproducible test failure for editing/undo/undo-iframe-location-change.html
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
+ Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
- * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
+ We allow selections to begin within an element that has -webkit-user-select: none set,
+ unless the element is draggable as dragging should take priority over starting a selection.
-2008-09-28 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig (except for a few comment and header tweaks).
-
- - https://bugs.webkit.org/show_bug.cgi?id=21158
- reduce use of virtual functions in Node for speed
-
- Speeds up Dromaeo a bit less than 1%.
-
- * bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of
- Node.h now that some inlines are in there.
-
- * dom/Attr.h: Override both the virtual and non-virtual name functions.
-
- * dom/ChildNodeList.cpp:
- (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
- * dom/ChildNodeList.h: Ditto.
- * dom/ClassNodeList.cpp:
- (WebCore::ClassNodeList::nodeMatches): Ditto.
- * dom/ClassNodeList.h: Ditto.
-
- * dom/Document.h: Put the Node::isDocumentNode() function's inline
- definition here where it can see the Document class definition.
-
- * dom/DynamicNodeList.cpp:
- (WebCore::DynamicNodeList::length): Changed to pass an Element.
- (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto.
- (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto.
- (WebCore::DynamicNodeList::itemWithName): Ditto.
- * dom/DynamicNodeList.h: Ditto.
-
- * dom/Element.cpp: Removed virtualHasTagName.
- * dom/Element.h: Made localName, prefix, namespaceURI, and
- styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName,
- virtualNamespaceURI, and removed virtualHasTagName. Put the
- Node::hasTagName, Node::hasAttributes, and Node::attributes
- functions' inline definitions here where they can see the Element
- class definition.
-
- * dom/NameNodeList.cpp:
- (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
- * dom/NameNodeList.h: Ditto.
+ Test: editing/selection/user-drag-element-and-user-select-none.html
* dom/Node.cpp:
- (WebCore::Node::virtualPrefix): Renamed from prefix.
- (WebCore::Node::virtualLocalName): Renamed from localName.
- (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI.
- (WebCore::Node::styleForRenderer): Handle the Element case here.
-
- * dom/Node.h: Removed definition of hasTagName that calls virtual,
- since we now have a non-virtual version. Made hasAttributes,
- attributes, remove, localName, namespaceURI, prefix, isDocumentNode,
- and styleForRenderer non-virtual. Added virtualPrefix,
- virtualLocalName, and virtualNamespaceURI. Removed isMalformed
- and setMalformed, which are used only on HTMLFormElement objects.
-
- * dom/TagNodeList.cpp:
- (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
- * dom/TagNodeList.h: Ditto.
-
- * html/HTMLAnchorElement.cpp: Added a comment.
- * html/HTMLFormControlElement.cpp: Ditto.
+ (WebCore::Node::canStartSelection):
- * html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex
- function. Marked tabIndex function virtual explicitly for clarity.
+2009-06-20 Darin Adler <darin@apple.com>
- * html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex
- function. Marked isFocusable function virtual explicitly for clarity.
-
- * html/HTMLElement.h: Marked tabIndex function virtual explicitly for
- clarity.
- * html/HTMLFormControlElement.h: Ditto.
-
- * html/HTMLFormElement.h: Made isMalformed non-virtual.
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement
- pointer to call localName since that one does not need to call a virtual
- function.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before
- calling isMalformed. We already did a tag name check so we know it's
- an HTMLFormELement.
-
- * xml/XPathUtil.cpp:
- (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls
- to nodeType(), since it's a virtual function.
-
-2008-09-28 David Hyatt <hyatt@apple.com>
-
- Make frameRectsChanged() cross-platform on ScrollView.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::frameRectsChanged):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-09-28 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 21141: REGRESSION: Exception messages for user entered commands are poor
- <https://bugs.webkit.org/show_bug.cgi?id=21141>
-
- The bug repsonsible for this was the the JSInspectedObjectWrapper instances
- were not initialising their StructureID's to indicate that the wrapper
- overrides hasInstance, etc. The solution is simply to use the createStructureID
- helper on JSQuarantinedObjectWrapper to create a correct StructureID.
+ Reviewed by Dan Bernstein.
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
+ Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
+ https://bugs.webkit.org/show_bug.cgi?id=26528
+ rdar://problem/6985329
-2008-09-28 David Hyatt <hyatt@apple.com>
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::handleReplacedElement): When entering a text control,
+ start at the top of the shadow tree (by calling shadowTreeRootNode). Also
+ remove assumption that innerTextElement will never be 0 since RenderTextControl
+ doesn't really guarantee this.
- Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
- terms of lines.
+2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
- Reviewed by Oliver Hunt
+ Reviewed by NOBODY.
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchWheelEvent):
+ Speculative Qt build fix - add HTMLDataGridColElement to the build script.
-2008-09-28 David Hyatt <hyatt@apple.com>
+ * WebCore.pro:
- https://bugs.webkit.org/show_bug.cgi?id=21191
+2009-06-19 Adam Barth <abarth@webkit.org>
- Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
- on ScrollView to be cross-platform.
+ Reviewed by Darin Adler.
- Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
- events are now pixel wheel events.
+ https://bugs.webkit.org/show_bug.cgi?id=26561
- Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
- (1) Page scrolling has been corrected to be properly detected (on Windows
- page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
- old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
- you could page scroll horizontally.
- (2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
- This caused the scroll amount for page scrolling to be way too large on layers.
+ Remove a memcpy by retrieving the already existing copy of a string
+ instead of making a new one.
- Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.
+ * bindings/js/ScriptSourceCode.h:
+ (WebCore::ScriptSourceCode::ScriptSourceCode):
+ (WebCore::ScriptSourceCode::source):
+ * bindings/js/StringSourceProvider.h:
+ (WebCore::StringSourceProvider::source):
- Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
- for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).
+2009-06-19 Brian Weinstein <bweinstein@apple.com>
- Reviewed by Oliver Hunt
+ Reviewed by Steve Falkenburg.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26488
+ No Support for Single Finger or Two Finger Panning in Windows 7
+
+ The code in WebCore allows us to interpret a Pan gesture as
+ a mousewheel event, and we are able to reuse the scrolling code.
+ Another constructor was created in WheelEventWin which takes data
+ better suited to the pan guesture than what was currently there.
+
+ Unable to add tests to simulate touch behavior/gestures.
- * editing/EditorCommand.cpp:
- (WebCore::verticalScrollDistance):
- * page/EventHandler.cpp:
- (WebCore::scrollAndAcceptEvent):
- (WebCore::EventHandler::handleWheelEvent):
* platform/PlatformWheelEvent.h:
- (WebCore::):
- (WebCore::PlatformWheelEvent::pos):
- (WebCore::PlatformWheelEvent::globalPos):
- (WebCore::PlatformWheelEvent::deltaX):
- (WebCore::PlatformWheelEvent::deltaY):
- (WebCore::PlatformWheelEvent::granularity):
- (WebCore::PlatformWheelEvent::x):
- (WebCore::PlatformWheelEvent::globalX):
- (WebCore::PlatformWheelEvent::ignore):
- (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
- (WebCore::PlatformWheelEvent::verticalLineMultiplier):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::wheelEvent):
- * platform/Scrollbar.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/mac/ScrollViewMac.mm:
- * platform/mac/WheelEventMac.mm:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/qt/WheelEventQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::updateScrollbars):
* platform/win/WheelEventWin.cpp:
- (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
- (WebCore::PlatformWheelEvent::verticalLineMultiplier):
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
- (WebCore::ScrollView::wheelEvent):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateScrollInfoAfterLayout):
-2008-09-27 Eric Carlson <eric.carlson@apple.com>
+2009-06-19 Chris Marrin <cmarrin@apple.com>
- Reviewed by Sam Weinig.
-
- fix https://bugs.webkit.org/show_bug.cgi?id=20994
- <rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned
-
- HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
- all unsigned media attributes from string with toUInt() instead of toInt().
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().
-
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::videoWidth):
- (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl.
- (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return
- unsigned value.
- (WebCore::HTMLVideoElement::height): Ditto.
- (WebCore::HTMLVideoElement::setWidth): take unsigned value.
- (WebCore::HTMLVideoElement::setHeight): Ditto.
+ Fixed a build error, which only shows up in the i386 compile
- * html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.
-
- * html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.
-
-2008-09-27 Timothy Hatcher <timothy@apple.com>
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::animateTransform):
- Fixes an exception when typing a command in the Console.
+2009-06-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Oliver Hunt.
- * page/inspector/Console.js:
- (WebInspector.Console.prototype.addMessage): Null check
- this.previosMessage.
-
-2008-09-27 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where the Profiles panel sidebar would be empty
- after closing and reopening the Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=21179
-
- Reviewed by Sam Weinig.
-
- * page/inspector/ProfilesPanel.js:
- (WebInspector.ProfilesPanel.prototype.reset): Don't call
- populateInterface, it is called automatically.
- (WebInspector.ProfilesPanel.prototype._populateProfiles):
- Return early if the sidebar is already populated.
-
-2008-09-27 Dave Hyatt <hyatt@apple.com>
-
- Bug 21190. The line scroll amount on Windows is way too small. A patch for bug 17589 for wheel sensitivity
- incorrectly applied the tinier wheel step delta (unmultiplied) to line scrolling. Line scrolling with the
- scrollbar has nothing to do with mouse wheeling. This patch reverts the scrollbars to use the same line
- step as other platforms while leaving the wheel delta alone for use with wheel scrolling.
-
- There was a lot wrong with 17589, so more patches will be coming to deal with the fallout of this patch
- (which should never have landed in the first place).
-
- Reviewed by Tim Hatcher, Sam Weinig
-
- * platform/win/ScrollViewWin.cpp:
- (WebCore::adjustDeltaForPageScrollMode):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::wheelEvent):
-
-2008-09-27 David Hyatt <hyatt@apple.com>
-
- Make the scrollbarUnderMouse method cross-platform.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollbarUnderMouse):
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Gtk+ build fix.
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
-
-2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Holger Freyther.
-
- https://bugs.webkit.org/show_bug.cgi?id=20287
- [Gtk] disable plugins for gtk/directfb target
-
- Introduce WTF_PLATFORM_X11 for X11 builds.
- Also use target-specific packages when building the port
-
- * platform/gtk/PlatformScreenGtk.cpp:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::getValueStatic):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::init):
-
-2008-09-27 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21188
-
- Make scrollbar suppression and resizer avoidance cross-platform.
-
- Reviewed by Anders
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::transitionToCommitted):
- * page/FrameView.cpp:
- (WebCore::FrameView::resetScrollbars):
- (WebCore::FrameView::clear):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::restoreScrollbar):
- (WebCore::FrameView::windowResizerRect):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::init):
- (WebCore::ScrollView::resizerOverlapsContent):
- (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
- (WebCore::ScrollView::setParent):
- (WebCore::ScrollView::setScrollbarsSuppressed):
- (WebCore::ScrollView::platformSetScrollbarsSuppressed):
- * platform/ScrollView.h:
- (WebCore::ScrollView::scrollbarsSuppressed):
- (WebCore::ScrollView::windowResizerRect):
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::setFrameRect):
- (WebCore::Scrollbar::setParent):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::paint):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
- (WebCore::ScrollView::platformSetScrollbarsSuppressed):
- (WebCore::ScrollView::setScrollPosition):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::frameRectsChanged):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::paint):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::paint):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
-
-2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Rubber-stamped by Anders Carlsson.
-
- Compile fix.
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::load):
-
-2008-09-27 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
- Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html
-
- Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.
-
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::~CachedResource):
-
-2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [qt] Use QImageReader to figure out which image formats are supported
- - Qt can have many different plugins for different image formats. Instead
- of checking only for a few in WebCore use Qt to determine if this data
- can be treated as an image.
-
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::canHandleImage):
- (WebCore::createDecoder):
-
-2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
-
-
- [qt] Clean the pattern code
- - Use save/restore on the painter after manipulating the
- pen/brush
- - Make the context and object null checking consistent. CG is using
- the object unconditionally so the Qt webkit platform can do the
- same.
- - Move code below the early exit. Only use the m_ownerElement before
- the early exit as the CG code is doing it.
-
- * svg/graphics/SVGPaintServerPattern.h:
- * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
- (WebCore::SVGPaintServerPattern::setup):
- (WebCore::SVGPaintServerPattern::teardown):
-
-2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
-
- Added support for console.trace.
-
- https://bugs.webkit.org/show_bug.cgi?id=19157
-
- Reviewed by Kevin McCullough and Tim Hatcher.
-
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::trace):
- * page/Console.cpp:
- (WebCore::Console::trace): Calls Machine::retrieveCaller to
- get a stack trace.
- * page/Console.h:
- (WebCore::): Added TraceMessageLevel.
- * page/Console.idl: Added console.trace.
- * page/inspector/Console.js:
- (ConsoleMessage): Added case for TraceMessageLevel.
-
-2008-09-27 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=21178
- <rdar://problem/6248651>
-
- Check if the plug-in is allowed to load the resource. This matches Firefox.
-
- Test: http/tests/plugins/local-geturl-from-remote.html
-
- * plugins/PluginView.cpp:
- (WebCore::PluginView::load):
-
-2008-09-22 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- Added SVG pattern support to Qt.
-
- [Qt] SVG patterns are missing
- https://bugs.webkit.org/show_bug.cgi?id=20973
-
- * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
- (WebCore::SVGPaintServerPattern::setup):
-
-2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
-
- Fixed a bug in the JS syntax highlighter with multiple line tokens.
-
- https://bugs.webkit.org/show_bug.cgi?id=21171
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/SourceFrame.js:
- (syntaxHighlightJavascriptLine): Initialize previousMatchLength.
-
-2008-09-27 Timothy Hatcher <timothy@apple.com>
-
- Change searching in the Profiles panel to not match the
- Self and Total columns when there are no units. The only
- column that is matched for unitless number searches is
- now the Calls column.
-
- https://bugs.webkit.org/show_bug.cgi?id=21169
-
- Reviewed by Sam Weinig.
-
- * page/inspector/ProfileView.js:
- (WebInspector.ProfileView.prototype.performSearch):
-
-2008-09-27 David Hyatt <hyatt@apple.com>
-
- Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollView.h:
- * platform/Widget.h:
- (WebCore::Widget::boundsRect):
- (WebCore::Widget::invalidate):
- (WebCore::Widget::frameRectsChanged):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollViewScrollbar::frameRectsChanged):
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::frameRectsChanged):
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::setFrameRect):
- (ScrollbarGtk::frameRectsChanged):
- * platform/gtk/ScrollbarGtk.h:
- * platform/gtk/WidgetGtk.cpp:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::frameRectsChanged):
- (WebCore::ScrollView::updateScrollbars):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::frameRectsChanged):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::frameRectsChanged):
- * plugins/PluginView.h:
-
-2008-09-27 Simon Hausmann <hausmann@webkit.org>
-
- Refix the previous build fix to compile on non-Qt platforms, too.
-
- * WebCore.pro: Don't pass -i to create_hashtable, added missing -n
- WebCore to generate the PrototypeTable in the WebCore namespace
- * bindings/js/JSEventTargetBase.h: Revert previous fix, the Prototype
- table remains in the Webcore namespace
- (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
-
-2008-09-27 Simon Hausmann <hausmann@webkit.org>
-
- Fix compilation with gcc 4.3 (probably > 4.0)
-
- * bindings/js/JSDOMWindowBase.cpp: Don't define static property
- get/put functions inside the WebCore namespace.
- * bindings/js/JSEventTargetBase.cpp: Ditto.
- * bindings/js/JSEventTargetNode.cpp: Ditto.
- * bindings/js/JSEventTargetSVGElementInstance.cpp: Ditto.
- * bindings/js/JSEventTargetBase.h: Forward declare
- JSEventTargetPrototypeTable in the JSC namespace as the lut.h file
- defines it in the JSC namespace.
- (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): Add JSC::
- prefix for PrototypeTable symbol.
-
-2008-09-27 David Hyatt <hyatt@apple.com>
-
- Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.
-
- Reviewed by Dan Bernstein
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::updateControlTints):
- * platform/ScrollView.h:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::paint):
- (WebCore::Scrollbar::setFrameRect):
- * platform/Scrollbar.h:
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/Widget.h:
- (WebCore::Widget::x):
- (WebCore::Widget::y):
- (WebCore::Widget::width):
- (WebCore::Widget::height):
- (WebCore::Widget::size):
- (WebCore::Widget::pos):
- (WebCore::Widget::resize):
- (WebCore::Widget::move):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollViewScrollbar::geometryChanged):
- (WebCore::ScrollView::update):
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::paint):
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::setFrameRect):
- (ScrollbarGtk::geometryChanged):
- * platform/gtk/ScrollbarGtk.h:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::trackRect):
- (WebCore::ScrollbarThemeMac::paint):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::paint):
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::invalidateItem):
- (WebCore::PopupMenu::valueChanged):
- (WebCore::PopupWndProc):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::setFrameRect):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::paint):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarThemeSafari::trackRect):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::frameRect):
- (WebCore::Widget::setFrameRect):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::setFrameRect):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::paint):
- (WebCore::PluginView::init):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::init):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::updatePluginWidget):
- (WebCore::PluginView::paintMissingPluginIcon):
- (WebCore::PluginView::paint):
- (WebCore::PluginView::init):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::positionOverflowControls):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::paintScrollbar):
- * rendering/RenderPart.cpp:
- (WebCore::RenderPart::updateWidgetPosition):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::setWidgetGeometry):
- (WebCore::RenderWidget::updateWidgetPosition):
-
-2008-09-27 David Hyatt <hyatt@apple.com>
-
- <rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF
-
- This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
- access an actual member variable.
-
- Reviewed by Dan Bernstein
-
- * page/FocusController.cpp:
- (WebCore::FocusController::setFocusedFrame):
-
-2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Attempt to fix QT Build. Not reviewed.
-
- * WebCore.pro: add -n WebCore parameter to create_hash_table
-
-2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
-
- Reviewed by Eric Seidel.
-
- http://bugs.webkit.org/show_bug.cgi?id=18905
- [GTK] Fix build with older pango (1.14.8)
-
- * platform/graphics/gtk/FontGtk.cpp:
- * platform/gtk/Language.cpp:
- (_pango_get_lc_ctype):
- (pango_language_get_default):
-
-2008-09-26 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21168
-
- Make contentsToWindow/windowToContents cross-platform.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::windowToContents):
- (WebCore::ScrollView::contentsToWindow):
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-09-26 Sam Weinig <sam@webkit.org>
-
- GTK build fix.
-
- * GNUmakefile.am:
-
-2008-09-26 David Hyatt <hyatt@apple.com>
-
- Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
- offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
- more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.
-
- Reviewed by Oliver Hunt
-
- * page/FrameView.cpp:
- (WebCore::FrameView::repaintContentRectangle):
- * page/FrameView.h:
- * platform/ScrollView.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::isOffscreen):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::updateContents):
- (WebCore::ScrollView::isOffscreen):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::isOffscreen):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::isOffscreen):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::isOffscreen):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::willRenderImage):
-
-2008-09-26 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21164
-
- Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::setAllowsScrolling):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setAllowsScrolling):
- * platform/ScrollView.h:
- (WebCore::ScrollView::allowsScrolling):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::wheelEvent):
+ <rdar://problem/6988385> REGRESSION: In full page video player, movie's
+ video track becomes detached from its controller.
+
+ When in the media document, the MediaPlayer should not report that it
+ is capable of hardware acceleration, because it renders via a QTMovieView
+ which is already accelerated.
-2008-09-26 Kevin Ollivier <kevino@theolliviers.com>
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
- wx build fixes after Widget/ScrollView changes.
+2009-06-19 Kevin Ollivier <kevino@theolliviers.com>
- * platform/wx/PopupMenuWx.cpp:
- (WebCore::PopupMenu::show):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetContentsSize):
- (WebCore::ScrollView::platformSetScrollbarModes):
- (WebCore::ScrollView::wheelEvent):
- * platform/wx/TemporaryLinkStubs.cpp:
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::containingWindow):
+ Adding XSSAuditor.cpp to the wx build.
-2008-09-26 Timothy Hatcher <timothy@apple.com>
+ * WebCoreSources.bkl:
- Allow searching for paths by always performing the
- three search methods in the Elements panel and not
- assume a search with a "/" is a XPath query.
+2009-06-19 Chris Marrin <cmarrin@apple.com>
- https://bugs.webkit.org/show_bug.cgi?id=21159
+ Reviewed by Simon Fraser <simon.fraser@apple.com>.
- Reviewed by Geoff Garen.
+ https://bugs.webkit.org/show_bug.cgi?id=26544
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.performSearch):
+ If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
+ This is not really testable, since we can't see what the hardware animation is doing.
-2008-09-26 Sam Weinig <sam@webkit.org>
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::animateTransform):
- Reviewed by Darin Adler.
+2009-06-19 Geoffrey Garen <ggaren@apple.com>
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
- Speedup static property get/put
+ Reviewed by Maciej Stachowiak.
+
+ An additional fix for Bug 26532: Native functions do not correctly unlink
+ from optimised callsites when they're collected
+ <https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
+ Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
+ accessors, so the type of object you get to wrap a function is the same,
+ regardless of whether the access to the function is cross-frame.
+
+ This is faster and more idiomatic than what we had before. It also would
+ have avoided Bug 26532 because it would have prevented a conflicting
+ PrototypeFunction from being allocated to wrap postMessage, where a
+ NativeFunctionWrapper had been allocated previously.
+
* bindings/js/JSDOMBinding.cpp:
- * bindings/js/JSDOMBinding.h:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::getDOMConstructor):
- (WebCore::jsDOMWindowBaseCrypto):
- (WebCore::jsDOMWindowBaseEvent):
- (WebCore::jsDOMWindowBaseImage):
- (WebCore::jsDOMWindowBaseMessageChannel):
- (WebCore::jsDOMWindowBaseOption):
- (WebCore::jsDOMWindowBaseXMLHttpRequest):
- (WebCore::jsDOMWindowBaseAudio):
- (WebCore::jsDOMWindowBaseXSLTProcessor):
- (WebCore::jsDOMWindowBaseOnabort):
- (WebCore::jsDOMWindowBaseOnblur):
- (WebCore::jsDOMWindowBaseOnchange):
- (WebCore::jsDOMWindowBaseOnclick):
- (WebCore::jsDOMWindowBaseOndblclick):
- (WebCore::jsDOMWindowBaseOnerror):
- (WebCore::jsDOMWindowBaseOnfocus):
- (WebCore::jsDOMWindowBaseOnkeydown):
- (WebCore::jsDOMWindowBaseOnkeypress):
- (WebCore::jsDOMWindowBaseOnkeyup):
- (WebCore::jsDOMWindowBaseOnload):
- (WebCore::jsDOMWindowBaseOnmousedown):
- (WebCore::jsDOMWindowBaseOnmousemove):
- (WebCore::jsDOMWindowBaseOnmouseout):
- (WebCore::jsDOMWindowBaseOnmouseover):
- (WebCore::jsDOMWindowBaseOnmouseup):
- (WebCore::jsDOMWindowBaseOnMouseWheel):
- (WebCore::jsDOMWindowBaseOnreset):
- (WebCore::jsDOMWindowBaseOnresize):
- (WebCore::jsDOMWindowBaseOnscroll):
- (WebCore::jsDOMWindowBaseOnsearch):
- (WebCore::jsDOMWindowBaseOnselect):
- (WebCore::jsDOMWindowBaseOnsubmit):
- (WebCore::jsDOMWindowBaseOnbeforeunload):
- (WebCore::jsDOMWindowBaseOnunload):
- (WebCore::jsDOMWindowBaseOnWebKitAnimationStart):
- (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration):
- (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd):
- (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd):
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- (WebCore::JSDOMWindowBase::put):
- (WebCore::setJSDOMWindowBaseOnabort):
- (WebCore::setJSDOMWindowBaseOnblur):
- (WebCore::setJSDOMWindowBaseOnchange):
- (WebCore::setJSDOMWindowBaseOnclick):
- (WebCore::setJSDOMWindowBaseOndblclick):
- (WebCore::setJSDOMWindowBaseOnerror):
- (WebCore::setJSDOMWindowBaseOnfocus):
- (WebCore::setJSDOMWindowBaseOnkeydown):
- (WebCore::setJSDOMWindowBaseOnkeypress):
- (WebCore::setJSDOMWindowBaseOnkeyup):
- (WebCore::setJSDOMWindowBaseOnload):
- (WebCore::setJSDOMWindowBaseOnmousedown):
- (WebCore::setJSDOMWindowBaseOnmousemove):
- (WebCore::setJSDOMWindowBaseOnmouseout):
- (WebCore::setJSDOMWindowBaseOnmouseover):
- (WebCore::setJSDOMWindowBaseOnmouseup):
- (WebCore::setJSDOMWindowBaseOnMouseWheel):
- (WebCore::setJSDOMWindowBaseOnreset):
- (WebCore::setJSDOMWindowBaseOnresize):
- (WebCore::setJSDOMWindowBaseOnscroll):
- (WebCore::setJSDOMWindowBaseOnsearch):
- (WebCore::setJSDOMWindowBaseOnselect):
- (WebCore::setJSDOMWindowBaseOnsubmit):
- (WebCore::setJSDOMWindowBaseOnbeforeunload):
- (WebCore::setJSDOMWindowBaseOnunload):
- (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart):
- (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration):
- (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd):
- (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd):
- (WebCore::setJSDOMWindowBaseEvent):
- (WebCore::setJSDOMWindowBaseAudio):
- (WebCore::setJSDOMWindowBaseImage):
- (WebCore::setJSDOMWindowBaseMessageChannel):
- (WebCore::setJSDOMWindowBaseOption):
- (WebCore::setJSDOMWindowBaseXMLHttpRequest):
- (WebCore::setJSDOMWindowBaseXSLTProcessor):
- * bindings/js/JSDOMWindowBase.h:
+ (WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::nonCachingStaticCloseFunctionGetter):
- (WebCore::nonCachingStaticBlurFunctionGetter):
- (WebCore::nonCachingStaticFocusFunctionGetter):
- (WebCore::nonCachingStaticPostMessageFunctionGetter):
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- * bindings/js/JSEventTargetBase.cpp:
- * bindings/js/JSEventTargetBase.h:
- (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
- (WebCore::JSEventTargetBasePrototype::classInfo):
- * bindings/js/JSEventTargetNode.cpp:
- (WebCore::):
- (WebCore::JSEventTargetNode::getOwnPropertySlot):
- (WebCore::JSEventTargetNode::put):
- * bindings/js/JSEventTargetNode.h:
- (WebCore::JSEventTargetNode::classInfo):
- (WebCore::JSEventTargetNode::prototypeClassName):
- * bindings/js/JSEventTargetSVGElementInstance.cpp:
- (WebCore::):
- (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
- (WebCore::JSEventTargetSVGElementInstance::put):
- * bindings/js/JSEventTargetSVGElementInstance.h:
- (WebCore::JSEventTargetSVGElementInstance::classInfo):
- (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
- * bindings/js/JSHTMLInputElementCustom.cpp:
- (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
+ (WebCore::nonCachingStaticFunctionGetter):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
- (WebCore::JSHistory::customGetOwnPropertySlot):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
- (WebCore::JSLocation::customGetOwnPropertySlot):
- (WebCore::JSLocation::customPut):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2008-09-26 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21149
-
- Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
- Eliminate the unused isScrollable() method.
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameView::resetScrollbars):
- (WebCore::FrameView::initScrollbars):
- (WebCore::FrameView::layout):
- * page/FrameView.h:
- * page/mac/WebCoreFrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::init):
- (WebCore::ScrollView::setScrollbarModes):
- (WebCore::ScrollView::scrollbarModes):
- (WebCore::ScrollView::platformSetScrollbarModes):
- (WebCore::ScrollView::platformScrollbarModes):
- * platform/ScrollView.h:
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- (WebCore::ScrollView::isScrollViewScrollbar):
- (WebCore::ScrollView::setHorizontalScrollbarMode):
- (WebCore::ScrollView::setVerticalScrollbarMode):
- (WebCore::ScrollView::horizontalScrollbarMode):
- (WebCore::ScrollView::verticalScrollbarMode):
- (WebCore::ScrollView::convertSelfToChild):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::isScrollViewScrollbar):
- (WebCore::ScrollView::paint):
- (WebCore::ScrollView::scroll):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformSetScrollbarModes):
- (WebCore::ScrollView::platformScrollbarModes):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- (WebCore::ScrollView::invalidateScrollbars):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::paint):
- (WebCore::ScrollView::scroll):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
- (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
- (WebCore::ScrollView::suppressScrollbars):
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::paint):
- (WebCore::ScrollView::scroll):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetScrollbarModes):
- (WebCore::ScrollView::platformScrollbarModes):
-
-2008-09-26 David Kilzer <ddkilzer@apple.com>
-
- Fix Mac build with XPATH and XSLT disabled
-
- Reviewed by Alexey.
-
- * bindings/objc/DOMUtility.mm:
- (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
- * dom/XMLTokenizerLibxml2.cpp:
- (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to
- prevent an unused code warning.
-
-2008-09-26 Kevin McCullough <kmccullough@apple.com>
-
- Rubber stamped by Tim Hatcher.
-
- Bug 21098: Crashing under Console::log
- - Speculative ASSERT to help find the problem.
-
- * page/InspectorController.cpp:
- (WebCore::ConsoleMessage::isEqual):
-
-2008-09-26 Holger Hans Peter Freyther <zecke@selfish.org>
-
- [gtk+] Build fix for the latest ScrollView changes
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
-
-2008-09-26 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where the console message repeat count would be wrong
- when typing commands in between repeated messages.
-
- https://bugs.webkit.org/show_bug.cgi?id=21145
-
- Reviewed by Kevin McCullough.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel.
- (WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
- * page/inspector/Console.js:
- (WebInspector.Console.prototype.addMessage): Remember the original repeat count
- for each message as totalRepeatCount, since we now modify repeatCount to mean
- repeats since previous console command. If repeatCountBeforeCommand is a number,
- subtract that value from the repeatCount.
- (WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand
- and commandSincePreviousMessage properties.
-
-2008-09-26 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Antti
-
- https://bugs.webkit.org/show_bug.cgi?id=21116
- <rdar://problem/5726325> Audio from <video> can still be heard after navigating
- back to page with <video>, then closing tab
-
- Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
- documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
- deletion.
-
- * dom/Document.cpp:
- (WebCore::Document::documentWillBecomeInactive):
- (WebCore::Document::documentDidBecomeActive):
- (WebCore::Document::registerForDocumentActivationCallbacks):
- (WebCore::Document::unregisterForDocumentActivationCallbacks):
- * dom/Document.h:
- * dom/Element.h:
- (WebCore::Element::documentWillBecomeInactive):
- (WebCore::Element::documentDidBecomeActive):
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::~HTMLFormElement):
- (WebCore::HTMLFormElement::parseMappedAttribute):
- (WebCore::HTMLFormElement::documentDidBecomeActive):
- (WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
- (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
- * html/HTMLFormElement.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::~HTMLInputElement):
- (WebCore::HTMLInputElement::setInputType):
- (WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::needsActivationCallback):
- (WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded):
- (WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded):
- (WebCore::HTMLInputElement::documentDidBecomeActive):
- (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
- (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
- * html/HTMLInputElement.h:
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement):
- (WebCore::HTMLMediaElement::~HTMLMediaElement):
- (WebCore::HTMLMediaElement::documentWillBecomeInactive):
- (WebCore::HTMLMediaElement::documentDidBecomeActive):
- * html/HTMLMediaElement.h:
- (WebCore::HTMLMediaElement::inActiveDocument):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::opened):
- * page/Page.cpp:
- (WebCore::Page::~Page):
- * rendering/RenderMedia.cpp:
- (WebCore::RenderMedia::updateControls):
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::updatePlayer):
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::SVGSVGElement):
- (WebCore::SVGSVGElement::~SVGSVGElement):
- (WebCore::SVGSVGElement::documentWillBecomeInactive):
- (WebCore::SVGSVGElement::documentDidBecomeActive):
- * svg/SVGSVGElement.h:
-
-2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon
-
- Fix the build inside Qt, don't create faulty prl files for now.
-
- * WebCore.pro:
-
-2008-09-26 Simon Hausmann <hausmann@webkit.org>
-
- Fix compilation on Qt/Windows
-
- * Add WebCore/ to the include path so that config.h is found that enables JSC
- * Link against winmm for the multimedia timer functions
- * Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/
- subdirectory
- * In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port
- but set m_window directly as setPlatformWidget takes a QWidget*.
-
- * WebCore.pro:
- * platform/win/SystemTimeWin.cpp:
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::init):
-
-2008-09-26 Oliver Hunt <oliver@apple.com>
-
- Reviewed by Maciej Stachowiak.
- Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
- <https://bugs.webkit.org/show_bug.cgi?id=21054>
+2009-06-19 Simon Fraser <simon.fraser@apple.com>
- This performance regression is actually just a symptom of a correctness
- bug. The constructor objects for a number of properties that have security
- checks on access were returning new objects each time. The most obvious
- symptom of this bug is that window.Image != window.Image, etc.
-
- The solution to this is to make sure we cache these constructors
- in the same way as all the other DOM constructors. To achieve this
- without causing any refcount cycles it is necessary to replace the
- refcounted document pointer in the Image, MessageChannel, Option,
- XMLHttpRequest, and Audio constructor objects with a reference to
- the document's JS wrapper.
-
- Tests: fast/dom/constructors-cached-navigate.html
- fast/dom/constructors-cached.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::mark):
- * bindings/js/JSAudioConstructor.h:
- (WebCore::JSAudioConstructor::document):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::getDOMConstructor):
- (WebCore::JSDOMWindowBase::getValueProperty):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSHTMLOptionElementConstructor.cpp:
- (WebCore::JSHTMLOptionElementConstructor::mark):
- * bindings/js/JSHTMLOptionElementConstructor.h:
- (WebCore::JSHTMLOptionElementConstructor::document):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::mark):
- * bindings/js/JSImageConstructor.h:
- (WebCore::JSImageConstructor::document):
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::mark):
- * bindings/js/JSXMLHttpRequestConstructor.h:
- (WebCore::JSXMLHttpRequestConstructor::document):
-
-2008-09-26 Simon Hausmann <hausmann@webkit.org>
-
- Unreviewed one-liner build fix for the Qt/Windows build.
-
- The build requires NPAPI support to be enabled, fix the condition in
- the .pro file for that.
-
- * WebCore.pro:
-
-2008-09-26 Trenton Schulz <twschulz@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compilation with the Qt/Cocoa port.
-
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2008-09-26 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Holger.
-
- Fix compilation with VC9SP1, work around bug in TR1 library by
- disabling it.
-
- * WebCore.pro:
-
-2008-09-26 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Holger.
-
- Fix an lupdate() warning.
-
- Don't use tr() in a class that is not a QObject, use
- QCoreApplication::translate() directly.
-
- * platform/qt/ScrollbarQt.cpp:
- (WebCore::Scrollbar::handleContextMenuEvent):
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- Remove the scrollTo() method from FrameView, since it is not used by anyone.
-
- Reviewed by Oliver Hunt
-
- * page/FrameView.cpp:
- * page/FrameView.h:
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- Make scrollRectIntoViewRecursively cross-platform.
-
- Reviewed by Oliver Hunt
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::scrollRectIntoViewRecursively):
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21133
-
- Rename resizeContents method on ScrollView to setContentsSize (to match contentsSize()). Make it
- cross-platform.
-
- Reviewed by Oliver Hunt
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::begin):
- * page/FrameView.cpp:
- (WebCore::FrameView::adjustViewSize):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::setContentsSize):
- * platform/ScrollView.h:
- (WebCore::ScrollView::updateScrollbars):
- * platform/gtk/ScrollViewGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformSetContentsSize):
- * platform/qt/ScrollViewQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformSetContentsSize):
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21132
-
- Clean up the methods that actually do the scrolling in ScrollView.
-
- Reviewed by Oliver Hunt
-
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::setScrollLeft):
- (WebCore::HTMLBodyElement::setScrollTop):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::restoreScrollPositionAndViewState):
- * loader/ImageDocument.cpp:
- (WebCore::ImageDocument::imageClicked):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::scrollBy):
- (WebCore::DOMWindow::scrollTo):
- * page/FrameView.cpp:
- (WebCore::FrameView::scrollTo):
- (WebCore::FrameView::setScrollPosition):
- * page/FrameView.h:
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::maximumScrollPosition):
- * platform/ScrollView.h:
- (WebCore::ScrollView::contentsWidth):
- (WebCore::ScrollView::contentsHeight):
- (WebCore::ScrollView::scrollBy):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::setScrollPosition):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::setScrollPosition):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::setScrollPosition):
- (WebCore::ScrollView::scrollRectIntoViewRecursively):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::setScrollPosition):
- (WebCore::ScrollView::scrollRectIntoViewRecursively):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::setScrollPosition):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollByRecursively):
- (WebCore::RenderLayer::scrollRectToVisible):
-
-2008-09-25 Dan Bernstein <mitz@apple.com>
-
- - attempted Windows build fix
-
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::setContentsPos):
- (WebCore::ScrollView::paint):
-
-2008-09-25 Timothy Hatcher <timothy@apple.com>
-
- Revert the padding changes done in r36905 to prevent the
- scrollbar from overlapping the URLs in the Console.
-
- https://bugs.webkit.org/show_bug.cgi?id=21126
-
- * page/inspector/inspector.css:
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21129
-
- Refactor contents size and scroll offset to be cross-platform. Reduce further the number
- of platform-specific methods required of ScrollView implementations.
-
- Reviewed by Tim Hatcher
-
- * dom/MouseRelatedEvent.cpp:
- (WebCore::contentsX):
- (WebCore::contentsY):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::scrollLeft):
- (WebCore::HTMLBodyElement::setScrollLeft):
- (WebCore::HTMLBodyElement::scrollTop):
- (WebCore::HTMLBodyElement::setScrollTop):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::scrollX):
- (WebCore::DOMWindow::scrollY):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/FrameView.cpp:
- (WebCore::FrameView::scrollTo):
- (WebCore::FrameView::windowClipRect):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::visibleContentRect):
- (WebCore::ScrollView::contentsSize):
- (WebCore::ScrollView::platformContentsSize):
- * platform/ScrollView.h:
- (WebCore::ScrollView::scrollPosition):
- (WebCore::ScrollView::scrollOffset):
- (WebCore::ScrollView::scrollX):
- (WebCore::ScrollView::scrollY):
- (WebCore::ScrollView::contentsWidth):
- (WebCore::ScrollView::contentsHeight):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
- (WebCore::ScrollView::setGtkAdjustments):
- (WebCore::ScrollView::resizeContents):
- (WebCore::ScrollView::contentsWidth):
- (WebCore::ScrollView::contentsHeight):
- (WebCore::ScrollView::scrollOffset):
- (WebCore::ScrollView::maximumScroll):
- (WebCore::ScrollView::scrollBy):
- (WebCore::ScrollView::suppressScrollbars):
- (WebCore::ScrollView::setHScrollbarMode):
- (WebCore::ScrollView::setVScrollbarMode):
- (WebCore::ScrollView::setScrollbarsMode):
- (WebCore::ScrollView::setFrameGeometry):
- (WebCore::ScrollView::updateScrollbars):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::platformContentsSize):
- (WebCore::ScrollView::scrollBy):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertFromContainingWindow):
- (WebCore::Widget::convertToContainingWindow):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::resizeContents):
- (WebCore::ScrollView::setFrameGeometry):
- (WebCore::ScrollView::scrollOffset):
- (WebCore::ScrollView::maximumScroll):
- (WebCore::ScrollView::scrollBy):
- (WebCore::ScrollView::setHScrollbarMode):
- (WebCore::ScrollView::setVScrollbarMode):
- (WebCore::ScrollView::setScrollbarsMode):
- (WebCore::ScrollView::updateScrollbars):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
- (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
- (WebCore::ScrollView::resizeContents):
- (WebCore::ScrollView::setFrameGeometry):
- (WebCore::ScrollView::scrollOffset):
- (WebCore::ScrollView::maximumScroll):
- (WebCore::ScrollView::scrollBy):
- (WebCore::ScrollView::setHScrollbarMode):
- (WebCore::ScrollView::setVScrollbarMode):
- (WebCore::ScrollView::setScrollbarsMode):
- (WebCore::ScrollView::updateScrollbars):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformVisibleContentRect):
- (WebCore::ScrollView::platformContentsSize):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::nodeAtPoint):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollRectToVisible):
- (WebCore::RenderLayer::calculateClipRects):
- (WebCore::RenderLayer::calculateRects):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::absolutePosition):
- (WebCore::RenderView::computeAbsoluteRepaintRect):
-
-2008-09-25 David Smith <catfish.man@gmail.com>
-
- Reviewed by Dave Hyatt.
-
- Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.
-
- * dom/Element.cpp:
- (WebCore::Element::rareData):
- * dom/Element.h:
- * dom/Node.cpp:
- (WebCore::Node::rareData):
- * dom/Node.h:
-
-2008-09-25 David Smith <catfish.man@gmail.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20980
- Split off uncommonly used data from Node similar to ElementRareData
-
- Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
- which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
- for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
- * dom/ContainerNode.cpp: Set isContainer to true
- (WebCore::ContainerNode::ContainerNode):
- * dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h
- (WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container
- (WebCore::Node::containerChildNode): ditto
- (WebCore::Node::containerFirstChild): ditto
- (WebCore::Node::containerLastChild): ditto
- * dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h
- (WebCore::Element::Element):
- (WebCore::Element::~Element):
- (WebCore::Element::rareData):
- (WebCore::Element::ensureRareData): Renamed from createRareData
- (WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type
- (WebCore::Element::attach): Check hasRareData rather than null-checking rareData()
- (WebCore::Element::detach): ditto
- (WebCore::Element::recalcStyle): ditto
- (WebCore::Element::focus):
- (WebCore::Element::minimumSizeForResizing): ditto
- (WebCore::Element::setMinimumSizeForResizing): ditto
- (WebCore::Element::computedStyle):
- (WebCore::Element::cancelFocusAppearanceUpdate): ditto
- * dom/Element.h:
- * dom/ElementRareData.h: Added; everything copied from Element.cpp
- (WebCore::defaultMinimumSizeForResizing):
- (WebCore::ElementRareData::ElementRareData):
- (WebCore::ElementRareData::resetComputedStyle):
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
- * dom/EventTargetNode.h:
- * dom/Node.cpp:
- (WebCore::Node::Node):
- (WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData
- (WebCore::Node::rareData):
- (WebCore::Node::ensureRareData):
- (WebCore::Node::createRareData):
- (WebCore::Node::tabIndex): nonzero tab indexes are now in rareData
- (WebCore::Node::setTabIndexExplicitly):
- (WebCore::Node::childNodes): NodeLists are now in rareData
- (WebCore::Node::setFocus):
- (WebCore::Node::rareDataFocused):
- (WebCore::Node::isFocusable):
- (WebCore::Node::isKeyboardFocusable):
- (WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData
- (WebCore::Node::unregisterDynamicNodeList): ditto
- (WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto
- (WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto
- (WebCore::Node::getElementsByName): ditto
- (WebCore::Node::getElementsByClassName): ditto
- * dom/Node.h:
- (WebCore::Node::firstChild): Use isContainerNode() to devirtualize
- (WebCore::Node::lastChild): ditto
- (WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container
- (WebCore::Node::focused): focus is in rareData if set
- (WebCore::Node::childTypeAllowed):
- (WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize
- (WebCore::Node::childNode): ditto
- (WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
- * dom/NodeRareData.h: Added. Most of this is just properties moved from Node
- (WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :(
- (WebCore::NodeRareData::NodeRareData):
- (WebCore::NodeRareData::rareDataMap):
- (WebCore::NodeRareData::rareDataFromMap):
- (WebCore::NodeRareData::clearNodeLists):
- (WebCore::NodeRareData::setNodeLists):
- (WebCore::NodeRareData::nodeLists):
- (WebCore::NodeRareData::tabIndex):
- (WebCore::NodeRareData::setTabIndex):
- (WebCore::NodeRareData::tabIndexSetExplicitly):
- * dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
- * xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
-
-2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [qt] ImageBuffer::toDataURL implementation
-
- There needs to be a Qt specific test result for the above mentioned
- implementation.
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::toDataURL):
-
-2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [qt] Implement SharedBuffer for Qt.
-
- * WebCore.pro:
- * platform/qt/SharedBufferQt.cpp: Added.
- (WebCore::SharedBuffer::createWithContentsOfFile):
- * platform/qt/TemporaryLinkStubs.cpp:
-
-2008-09-25 Feng Qian <feng@chromium.org>
-
- Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
- <rdar://problem/6243032>
-
- Reviewed by Dave Hyatt.
-
- Test: fast/dom/attribute-downcast-right.html
-
- Add isMappedAttribute function to Attribute for checking if an object
- is an instance of MappedAttribute. Removed attributeItem,
- getAttributeItem functions from NamedMappedAttrMap, and callers
- expecting MappedAttribute have to check isMappedAttribute before
- downcasting the return value to MappedAttribute.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::styleForElement):
- * dom/Attribute.h:
- (WebCore::Attribute::isMappedAttribute):
- * dom/MappedAttribute.h:
- (WebCore::MappedAttribute::isMappedAttribute):
- * dom/NamedMappedAttrMap.cpp:
- (WebCore::NamedMappedAttrMap::declCount):
- (WebCore::NamedMappedAttrMap::mapsEquivalent):
- * dom/NamedMappedAttrMap.h:
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::attributeChanged):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::setInputType):
- * svg/SVGForeignObjectElement.cpp:
- (WebCore::addCSSPropertyAndNotifyAttributeMap):
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::getPresentationAttribute):
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21120
-
- Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
- to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
- didn't want to mix that change in with this patch).
-
- Reviewed by Sam Weinig
-
- * page/Frame.cpp:
- (WebCore::Frame::markAllMatchesForText):
- * page/FrameView.cpp:
- (WebCore::FrameView::repaintContentRectangle):
- (WebCore::FrameView::windowClipRect):
- (WebCore::FrameView::updateControlTints):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::visibleContentRect):
- (WebCore::ScrollView::platformVisibleContentRect):
- * platform/ScrollView.h:
- (WebCore::ScrollView::visibleWidth):
- (WebCore::ScrollView::visibleHeight):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- (WebCore::ScrollView::platformVisibleContentRect):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::platformVisibleContentRect):
- (WebCore::ScrollView::horizontalScrollbar):
- (WebCore::ScrollView::verticalScrollbar):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::scrollRectToVisible):
- (WebCore::frameVisibleRect):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::viewRect):
-
-2008-09-25 David Smith <catfish.man@gmail.com>
-
- Reviewed by Timothy Hatcher
-
- https://bugs.webkit.org/show_bug.cgi?id=21052
- Generalize id selector special case for querySelectorAll
-
- By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
- Changes results on http://native.khan.mozilla.org
- from
- #title: 2ms
- h1#title: 55ms
- div #title: 55ms
-
- to:
- #title: 1ms
- h1#title: 2ms
- div #title: 5ms
-
- * dom/Node.cpp:
- (WebCore::Node::querySelector):
- * dom/SelectorNodeList.cpp:
- (WebCore::createSelectorNodeList):
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21118
-
- Make the concept of whether you can blit on scroll cross-platform on ScrollView.
-
- Reviewed by Sam Weinig
-
- * page/FrameView.cpp:
- (WebCore::FrameView::clear):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::setUseSlowRepaints):
- (WebCore::FrameView::addSlowRepaintObject):
- (WebCore::FrameView::removeSlowRepaintObject):
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::init):
- (WebCore::ScrollView::addChild):
- (WebCore::ScrollView::removeChild):
- (WebCore::ScrollView::setCanBlitOnScroll):
- * platform/ScrollView.h:
- (WebCore::ScrollView::canBlitOnScroll):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::ScrollView):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::platformAddChild):
- (WebCore::ScrollView::platformRemoveChild):
- (WebCore::ScrollView::platformSetCanBlitOnScroll):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::ScrollView):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::ScrollView):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::scrollBy):
-
-2008-09-25 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Bug 21109: Console should right-align urls
-
- * page/inspector/Console.js: Re-order the message elements so that when
- it overflows it doesn't get mixed in with the next message.
- * page/inspector/inspector.css:
-
-2008-09-25 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21113
-
- Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.
-
- Reviewed by Darin Adler
-
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::insertedIntoParent):
- * css/CSSRule.cpp:
- (WebCore::CSSRule::parentStyleSheet):
- (WebCore::CSSRule::parentRule):
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::CSSStyleSheet):
- * css/CSSStyleSheet.h:
-
-2008-09-25 Darin Adler <darin@apple.com>
-
- Reviewed by Adele Peterson.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21115
- <rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips
- bundled documents
-
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::formData): Use files() instead of value()
- to get the path, since value() now returns just the basename.
-
-2008-09-25 Brady Eidson <beidson@apple.com>
-
- Rubberstamped by Mark Rowe
-
- Roll out 36771 as it caused <rdar://problem/6246554>
- "nytimes.com doesn't display after returning to it with back/forward"
-
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::insertedIntoParent):
- * css/CSSRule.cpp:
- (WebCore::CSSRule::parentStyleSheet):
- (WebCore::CSSRule::parentRule):
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::CSSStyleSheet):
- (WebCore::CSSStyleSheet::docLoader):
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::doc):
-
-2008-09-25 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.
-
-2008-09-25 Dan Bernstein <mitz@apple.com>
-
- - Windows build fix
-
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::addChildPlatformWidget):
- (WebCore::ScrollView::removeChildPlatformWidget):
-
-2008-09-25 Timothy Hatcher <timothy@apple.com>
-
- Fixes a leak of ConsoleMessage seen when repeated console
- messages occur.
-
- Reviewed by Mark Rowe.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::addConsoleMessage): Delete the repeat
- since we don't add it to m_consoleMessages.
-
-2008-09-25 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Bug 21105: XHRs logged in the console may show the wrong URL for the
- source
- - Get the url at the time of the send() and pass it on to the XHR.
-
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::send):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::didFinishLoading):
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::setLastSendURL):
+ Reviewed by John Sullivan
-2008-09-25 Kevin McCullough <kmccullough@apple.com>
+ <rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent
+
+ Fix a crash that could occur in complex content due to timing issues
+ when doing a partial layer tree rebuild which is required when painting;
+ setCompositingParent() could be called with a parent which has not been made
+ compositing yet.
- Reviewed by Geoff and Tim.
+2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
- Bug 20322: XHRs logged in the console do not have line numbers
- - Get the line number at the time of the send and pass it on to the XHR.
+ Build fix. Adding missing HTMLDataGrid* files to the build.
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::send):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::XMLHttpRequest):
- (WebCore::XMLHttpRequest::didFinishLoading):
- * xml/XMLHttpRequest.h:
- (WebCore::XMLHttpRequest::setLastSendLineNumber):
+ * GNUmakefile.am:
-2008-09-25 Eric Carlson <eric.carlson@apple.com>
+2009-06-19 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- <rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
- https://bugs.webkit.org/show_bug.cgi?id=21003
-
- * dom/EventNames.h: remove "begin" event
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"
-
-2008-09-25 Alexey Proskuryakov <ap@webkit.org>
+ https://bugs.webkit.org/show_bug.cgi?id=26460 part three
+ Make BMPImageReader a standalone class that is used by ICOImageDecoder
+ and BMPImageDecoder to decode individual BMPs within a file. These
+ decoders now inherit directly from ImageDecoder.
+
+ This also makes these decoders decode on-demand in isSizeAvailable() and
+ frameBufferAtIndex(), like the other decoders, instead of when setData()
+ is called, like before. This should provide a speedup on pages
+ containing BMPs that aren't immediately onscreen.
- Reviewed by Eric Seidel.
+ * platform/image-decoders/bmp/BMPImageDecoder.cpp:
+ (WebCore::BMPImageDecoder::BMPImageDecoder):
+ (WebCore::BMPImageDecoder::setData):
+ (WebCore::BMPImageDecoder::isSizeAvailable):
+ (WebCore::BMPImageDecoder::frameBufferAtIndex):
+ (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded):
+ (WebCore::BMPImageDecoder::decode):
+ (WebCore::BMPImageDecoder::processFileHeader):
+ * platform/image-decoders/bmp/BMPImageDecoder.h:
+ (WebCore::BMPImageDecoder::readUint32):
+ * platform/image-decoders/bmp/BMPImageReader.cpp:
+ (WebCore::BMPImageReader::BMPImageReader):
+ (WebCore::BMPImageReader::decodeBMP):
+ (WebCore::BMPImageReader::readInfoHeaderSize):
+ (WebCore::BMPImageReader::processInfoHeader):
+ (WebCore::BMPImageReader::readInfoHeader):
+ (WebCore::BMPImageReader::processBitmasks):
+ (WebCore::BMPImageReader::processColorTable):
+ (WebCore::BMPImageReader::processRLEData):
+ (WebCore::BMPImageReader::processNonRLEData):
+ (WebCore::BMPImageReader::setFailed):
+ * platform/image-decoders/bmp/BMPImageReader.h:
+ (WebCore::BMPImageReader::readUint16):
+ (WebCore::BMPImageReader::readUint32):
+ (WebCore::BMPImageReader::setBuffer):
+ (WebCore::BMPImageReader::setData):
+ (WebCore::BMPImageReader::):
+ (WebCore::BMPImageReader::pastEndOfImage):
+ (WebCore::BMPImageReader::readCurrentPixel):
+ (WebCore::BMPImageReader::setRGBA):
+ * platform/image-decoders/ico/ICOImageDecoder.cpp:
+ (WebCore::ICOImageDecoder::ICOImageDecoder):
+ (WebCore::ICOImageDecoder::setData):
+ (WebCore::ICOImageDecoder::isSizeAvailable):
+ (WebCore::ICOImageDecoder::size):
+ (WebCore::ICOImageDecoder::frameBufferAtIndex):
+ (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded):
+ (WebCore::ICOImageDecoder::decode):
+ (WebCore::ICOImageDecoder::processDirectory):
+ (WebCore::ICOImageDecoder::processDirectoryEntries):
+ (WebCore::ICOImageDecoder::readDirectoryEntry):
+ (WebCore::ICOImageDecoder::processImageType):
+ * platform/image-decoders/ico/ICOImageDecoder.h:
+ (WebCore::ICOImageDecoder::readUint16):
+ (WebCore::ICOImageDecoder::readUint32):
- https://bugs.webkit.org/show_bug.cgi?id=21097
- Calling a MessageChannel constructor from a destroyed document results in a crash
+2009-06-19 Adam Barth <abarth@webkit.org>
- Test: fast/events/message-port-constructor-for-deleted-document.html
+ Reviewed by Dimitri Glazkov.
- * bindings/js/JSMessageChannelConstructor.cpp:
- (WebCore::JSMessageChannelConstructor::construct):
- * bindings/js/JSMessageChannelConstructor.h:
- Made m_document a RefPtr.
+ https://bugs.webkit.org/show_bug.cgi?id=26555
-2008-09-24 Alexey Proskuryakov <ap@webkit.org>
+ Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
+ the same API in V8 and JSC.
- Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.
+ * WebCore/bindings/js/ScriptController.cpp:
+ * WebCore/bindings/js/ScriptSourceCode.h:
+ * WebCore/bindings/v8/ScriptController.cpp:
+ * WebCore/page/XSSAuditor.cpp:
+ * WebCore/page/XSSAuditor.h:
- https://bugs.webkit.org/show_bug.cgi?id=20879
- Implement HTML5 channel messaging
+2009-06-19 David Hyatt <hyatt@apple.com>
- Tests: fast/events/message-channel-gc.html
- fast/events/message-port-deleted-document.html
- fast/events/message-port-deleted-frame.html
- fast/events/message-port-inactive-document.html
- fast/events/message-port.html
- http/tests/security/MessagePort/event-listener-context.html
+ Reviewed by Anders Carlsson.
- * Configurations/WebCore.xcconfig:
- Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.
+ https://bugs.webkit.org/show_bug.cgi?id=26547
+
+ Implement the IDL interface for HTMLDataGridColElement.
+ * DerivedSources.cpp:
* DerivedSources.make:
- Added MessageChannel and MessagePort.
-
- * WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be
- turmed off anyway. Added new files.
-
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- Added new files.
-
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
- Added suport for window.MessageChannel constructor.
-
- * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::postMessage):
- * page/DOMWindow.h:
+ * html/HTMLAttributeNames.in:
+ * html/HTMLDataGridColElement.cpp: Added.
+ (WebCore::HTMLDataGridColElement::HTMLDataGridColElement):
+ (WebCore::HTMLDataGridColElement::label):
+ (WebCore::HTMLDataGridColElement::setLabel):
+ (WebCore::HTMLDataGridColElement::type):
+ (WebCore::HTMLDataGridColElement::setType):
+ (WebCore::HTMLDataGridColElement::sortable):
+ (WebCore::HTMLDataGridColElement::setSortable):
+ (WebCore::HTMLDataGridColElement::sortDirection):
+ (WebCore::HTMLDataGridColElement::setSortDirection):
+ (WebCore::HTMLDataGridColElement::selected):
+ (WebCore::HTMLDataGridColElement::setSelected):
+ * html/HTMLDataGridColElement.h: Added.
+ (WebCore::HTMLDataGridColElement::endTagRequirement):
+ (WebCore::HTMLDataGridColElement::tagPriority):
+ * html/HTMLDataGridColElement.idl: Added.
+ * html/HTMLDataGridElement.h:
+ * html/HTMLElementsAllInOne.cpp:
+ * html/HTMLTagNames.in:
* page/DOMWindow.idl:
- Added support for three-argument postMessage (that posts a MessagePort).
-
- * dom/EventTarget.cpp:
- (WebCore::EventTarget::toMessagePort):
- * dom/EventTarget.h:
- * bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another
- EventTarget variant.
-
- * bindings/js/JSMessageChannelConstructor.h:
- * bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could
- take a browsing context (document) parameter.
-
- * bindings/js/JSMessageChannelCustom.cpp: Added.
- (WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark
- port1 and port2 that it owns.
-
- * bindings/js/JSMessagePortCustom.cpp: Added.
- (WebCore::JSMessagePort::startConversation):
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- (WebCore::JSMessagePort::dispatchEvent):
- (WebCore::JSMessagePort::setOnmessage):
- (WebCore::JSMessagePort::onmessage):
- (WebCore::JSMessagePort::setOnclose):
- (WebCore::JSMessagePort::onclose):
- (WebCore::JSMessagePort::mark):
- * dom/MessagePort.cpp: Added.
- * dom/MessagePort.h: Added.
- * dom/MessagePort.idl: Added.
- Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works
- with Documents as contexts, but in the future, it will be used for communication with worker
- threads.
-
- * bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not
- really have Obj-C bindings, as they are far from being final, but a MessagePort stub is
- needed for MessageEvent.
-
- * bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.
-
- * dom/Document.cpp:
- (WebCore::MessagePortTimer::MessagePortTimer):
- (WebCore::MessagePortTimer::fired):
- (WebCore::Document::processMessagePortMessagesSoon):
- (WebCore::Document::~Document):
- (WebCore::Document::dispatchMessagePortEvents):
- (WebCore::Document::createdMessagePort):
- (WebCore::Document::destroyedMessagePort):
- * dom/Document.h:
- Document keeps track of all MessagePort objects that were created when it was fully active
- in its context.
- * dom/EventNames.h: Added closeEvent.
+2009-06-19 Chris Evans <scarybeasts@gmail.com>
- * dom/MessageChannel.cpp: Added.
- (WebCore::MessageChannel::MessageChannel):
- (WebCore::MessageChannel::~MessageChannel):
- * dom/MessageChannel.h: Added.
- (WebCore::MessageChannel::create):
- (WebCore::MessageChannel::port1):
- (WebCore::MessageChannel::port2):
- * dom/MessageChannel.idl: Added.
- Addded JSMessageChannel implementation.
-
- * dom/MessageEvent.cpp:
- (WebCore::MessageEvent::MessageEvent):
- (WebCore::MessageEvent::initMessageEvent):
- * dom/MessageEvent.h:
- (WebCore::MessageEvent::create):
- (WebCore::MessageEvent::messagePort):
- * dom/MessageEvent.idl:
- MessageEvent has a MessagePort member now, making it possible to pass ports across
- documents.
-
-2008-09-25 David Smith <catfish.man@gmail.com>
-
- Reviewed by Eric Seidel
-
- fix https://bugs.webkit.org/show_bug.cgi?id=21091
- Regression: querySelector matches tag names case sensitively
-
- Tests: fast/dom/SelectorAPI/caseTag.html
- fast/dom/SelectorAPI/caseTagX.xhtml
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
- * css/CSSParser.h:
- * dom/Node.cpp:
- (WebCore::Node::querySelector):
- (WebCore::Node::querySelectorAll):
-
-2008-09-24 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21084
-
- Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
- functionality. Add platform stubs for connecting/disconnecting the platform widgets.
-
- Reviewed by Sam Weinig
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * platform/ScrollView.h:
- (WebCore::ScrollView::children):
- * platform/Widget.h:
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::addChildPlatformWidget):
- (WebCore::ScrollView::removeChildPlatformWidget):
- (WebCore::ScrollView::geometryChanged):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::addChildPlatformWidget):
- (WebCore::ScrollView::removeChildPlatformWidget):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::geometryChanged):
- (WebCore::ScrollView::addChildPlatformWidget):
- (WebCore::ScrollView::removeChildPlatformWidget):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::geometryChanged):
- (WebCore::ScrollView::setParentVisible):
- (WebCore::ScrollView::show):
- (WebCore::ScrollView::hide):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::addChildPlatformWidget):
- (WebCore::ScrollView::removeChildPlatformWidget):
-
-2008-09-25 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=21024
- <rdar://problem/6240821> Scrollbar not painted until hovered
-
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with
- this method, which sets both the location and the size.
- (WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget
- with a call to the new method setWidgetGeometry. Positioning the
- widget correctly ensures that the scroll bars invalidate correctly when
- they are created and resized.
- * rendering/RenderWidget.h:
-
-2008-09-24 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- - create a "style" subfolder under "rendering" and move style files to that folder
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-09-24 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- Remove staticFunctionGetter. There is only one remaining user of
- staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::getOwnPropertySlot):
-
-2008-09-24 Jeremy Moskovich <jeremy@chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Test: editing/spelling/inline_spelling_markers.html
-
- - https://bugs.webkit.org/show_bug.cgi?id=20092
- Spelling markers positioned incorrectly in RTL text
-
- Measure spelling markers with selectionRectForText() to fix RTL.
-
- This patch also fixes hit-testing for spelling marker tool tips,
- which used to work only on the first line.
-
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
-
-2008-09-24 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21074
-
- Make sure the viewless scrollbar knows how to paint properly when transformed.
-
- Reviewed by Sam Weinig
-
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
- (WebCore::ScrollbarThemeMac::paint):
-
-2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
-
- Not reviewed. Try to fix win build.
-
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::toJS):
- * dom/ContainerNodeAlgorithms.h:
- (WebCore::removeAllChildrenInContainer):
- (WebCore::appendChildToContainer):
- (WebCore::Private::addChildNodesToDeletionQueue):
-
-2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver.
-
- Add ContainerNodeAlgorithms.h, as central place to share algorithms
- operating on TreeShared-derived classes with a Node-style interface.
-
- This allows SVGElementInstance & ContainerNode to share code.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::removeAllChildren):
- (WebCore::ContainerNode::addChild):
- * dom/ContainerNode.h:
- * dom/ContainerNodeAlgorithms.h: Added.
- (WebCore::removeAllChildrenInContainer):
- (WebCore::appendChildToContainer):
- (WebCore::Private::NodeRemovalDispatcher::dispatch):
- (WebCore::Private::addChildNodesToDeletionQueue):
-
-2008-09-24 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Wrap up dirtying the z-order list of the stacking context
- RenderLayer into a method.
- https://bugs.webkit.org/show_bug.cgi?id=21072
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::setHasVisibleContent):
- (WebCore::RenderLayer::addChild):
- (WebCore::RenderLayer::removeChild):
- (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
- (WebCore::RenderLayer::styleChanged):
- * rendering/RenderLayer.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setStyle):
-
-2008-09-24 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- Bug 21070: REGRESSION Repeated messages with arguments are not repeated
- or displayed multiple times
- - The Insepctor Controller was comparing JSValue pointers so thought the
- message was not a repeat, but the JS of the inspector compared the
- strings and so knew it was the same message and so overwrote the old
- message.
-
- * page/InspectorController.cpp:
- (WebCore::ConsoleMessage::isEqual):
- (WebCore::InspectorController::addMessageToConsole):
- (WebCore::InspectorController::addConsoleMessage):
- (WebCore::InspectorController::startGroup):
- (WebCore::InspectorController::endGroup):
- * page/InspectorController.h:
-
-2008-09-24 David Hyatt <hyatt@apple.com>
-
- Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
- arrow placement preference and the thumb jump preference).
-
- Reviewed by Adam Roben
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::~Scrollbar):
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::registerScrollbar):
- (WebCore::ScrollbarTheme::unregisterScrollbar):
- * platform/mac/ScrollbarThemeMac.h:
- * platform/mac/ScrollbarThemeMac.mm:
- (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
- (+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
- (+[ScrollbarPrefsObserver registerAsObserver]):
- (WebCore::ScrollbarThemeMac::registerScrollbar):
- (WebCore::ScrollbarThemeMac::unregisterScrollbar):
- (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
- (WebCore::ScrollbarThemeMac::preferencesChanged):
-
-2008-09-24 Rob Buis <buis@kde.org>
-
- Reviewed by Darin.
-
- https://bugs.webkit.org/show_bug.cgi?id=20557
- getScreenCTM() returns wrong values
-
- Use the absolute position of the svg root when
- determining the screen ctm.
-
- Test: svg/custom/getscreenctm-in-mixed-content2.xhtml
-
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::getScreenCTM):
-
-2008-09-24 David Hyatt <hyatt@apple.com>
-
- Turn off support for CSS variables.
-
- * ChangeLog:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::createVariablesRule):
- (WebCore::CSSParser::addVariable):
- (WebCore::CSSParser::addVariableDeclarationBlock):
-
-2008-09-24 David Hyatt <hyatt@apple.com>
-
- Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).
-
- * css/CSSGrammar.y:
- * css/CSSParserValues.cpp:
- (WebCore::CSSParserValue::isVariable):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cleanup):
- (WebCore::CSSPrimitiveValue::getStringValue):
- (WebCore::CSSPrimitiveValue::cssText):
- (WebCore::CSSPrimitiveValue::parserValue):
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::):
- (WebCore::CSSPrimitiveValue::isVariable):
-
-2008-09-24 Timothy Hatcher <timothy@apple.com>
-
- Fixes a regression where the "incorrect MIME-type" warning would not
- show up correctly in the Console or the resources sidebar.
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/Resource.js:
- (WebInspector.Resource.prototype._addTip): Add the repeat count argument
- to the WebInspector.ConsoleMessage constructor call.
- (WebInspector.Resource.prototype._checkWarning): Ditto.
-
-2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Remove deprecated JS Qt bindings object call/construct code and fix autotests
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::QtInstance):
- * bridge/qt/qt_instance.h:
-
-2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>
-
- Reviewed by Alp Toker. Landed by Jan Alonzo.
-
- Bug 20883: [CURL] Add deferred loading
- https://bugs.webkit.org/show_bug.cgi?id=20883
-
- Implement deferred loading for the libcURL backend using curl_easy_pause.
- As the method was introduced in version 7.18.0, all the code checks for libcURL
- version.
-
- * platform/network/curl/ResourceHandleCurl.cpp:
- (WebCore::ResourceHandle::setDefersLoading):
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::writeCallback): Add an assertion that deferred loading is not
- activated.
- (WebCore::headerCallback): Ditto.
- (WebCore::readCallback): Ditto.
- (WebCore::ResourceHandleManager::dispatchSynchronousJob): Force
- defersLoading to be false in order to avoid triggering an assertion.
- (WebCore::ResourceHandleManager::initializeHandle): If deferred loading is
- activated, pause the easy handle.
-
-2008-09-23 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Tim Hatcher.
-
- Inspector search field style tweaks.
-
- * page/inspector/inspector.css:
-
-2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=21046 (Several LayoutTests crash)
-
- Fix missing negation in EventTargetNode::insertedIntoDocument.
- Made handleLocalEvents() virtual again, HTMLFormElement overrides it.
- Remove code, that wasn't supposed to go in in dispatchGenericEvent().
-
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::insertedIntoDocument):
- (WebCore::EventTargetNode::dispatchGenericEvent):
- * dom/EventTargetNode.h:
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Adds search support to the Profiles panel.
-
- The Profiles panel supports a few types of queries:
- * Standard string matching for function names and file URLs.
- * Greater than and less than search for numeric columns.
- So a query of ">24" will match all rows that have calls
- greater than 24. Or "<=42" will match all 42 or less.
- * Percent and time units. Adding a unit of "s", "ms" or "%"
- is supported and will match only the Self and Total columns.
- So a query of ">1.25s" will match all rows that took longer
- than 1.25 seconds.
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ProfileView.js:
- (WebInspector.ProfileView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
- it will start at the first result.
- (WebInspector.ProfileView.prototype.refreshShowAsPercents): Moved from the bottom of the file.
- (WebInspector.ProfileView.prototype.searchCanceled): Clear the search properties and refresh highlighted
- data grid nodes.
- (WebInspector.ProfileView.prototype.performSearch): Search the profile nodes.
- (WebInspector.ProfileView.prototype.jumpToFirstSearchResult): Does what the function says. Calls _jumpToSearchResult.
- (WebInspector.ProfileView.prototype.jumpToLastSearchResult): Ditto.
- (WebInspector.ProfileView.prototype.jumpToNextSearchResult): Ditto.
- (WebInspector.ProfileView.prototype.jumpToPreviousSearchResult): Ditto.
- (WebInspector.ProfileView.prototype.showingFirstSearchResult): Does what the function says.
- (WebInspector.ProfileView.prototype.showingLastSearchResult): Ditto.
- (WebInspector.ProfileView.prototype._jumpToSearchResult): Select and reveal the profile node.
- Expand all the ancestors first so the profile node will have a DataGridNode.
- (WebInspector.ProfileView.prototype._changeView): Perform the search again on the new tree.
- (WebInspector.ProfileDataGridNode.prototype.createCell): Add the highlight class to cells that
- have search matches.
- * page/inspector/ProfilesPanel.js:
- (WebInspector.ProfilesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
- (WebInspector.ProfilesPanel.prototype.showProfile): Use profileViewForProfile.
- (WebInspector.ProfilesPanel.prototype.showView): Call showProfile. Used by Panel to show a view.
- (WebInspector.ProfilesPanel.prototype.profileViewForProfile): Create the ProfileView if needed.
- (WebInspector.ProfilesPanel.prototype.closeVisibleView): Renamed visibleProfileView to visibleView.
- (WebInspector.ProfilesPanel.prototype.get searchableViews): Return all the views.
- (WebInspector.ProfilesPanel.prototype.searchMatchFound): Update the sidebar search matches.
- (WebInspector.ProfilesPanel.prototype.searchCanceled): Clear all the sidebar search matches.
- (WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches): Set the class and bubbleText.
- * page/inspector/inspector.css: New style rules for the cell highlight color.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Adds search support to the Resources and Scripts panels.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/Images/searchSmallBlue.png: Added.
- * page/inspector/Images/searchSmallBrightBlue.png: Added.
- * page/inspector/Images/searchSmallGray.png: Added.
- * page/inspector/Images/searchSmallWhite.png: Added.
- * page/inspector/ResourceView.js:
- (WebInspector.ResourceView.prototype.attach): Attempt to attach to "resource-views"
- or "script-resource-views" since one might not be created yet.
- * page/inspector/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.show): Hide any views that are visible that
- are not this panel's current visible view. This can happen when a ResourceView is
- visible in the Scripts panel then switched to the this panel.
- (WebInspector.ResourcesPanel.prototype.get searchableViews): Return all views, with the
- visibleView first.
- (WebInspector.ResourcesPanel.prototype.searchResultsSortFunction): Return a sort function
- that uses the current graph search function. So cycling through results will be in the order
- things appear in the sidebar.
- (WebInspector.ResourcesPanel.prototype.searchMatchFound): Update the search matches on the
- resource's sidebar tree element.
- (WebInspector.ResourcesPanel.prototype.searchCanceled): Restore the error and warning bubbles
- in the sidebar. Calls the Panel prototype's searchCanceled.
- (WebInspector.ResourcesPanel.prototype.performSearch): Hide all the error and warning bubbles
- in the sidebar. Calls the Panel prototype's performSearch.
- (WebInspector.ResourcesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
- (WebInspector.ResourcesPanel.prototype.addMessageToResource): Don't call updateErrorsAndWarnings
- if there is a current search query.
- (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
- (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Ditto.
- (WebInspector.ResourcesPanel.prototype.showView): Call showResource. Used by Panel to show a view.
- (WebInspector.ResourceSidebarTreeElement.prototype.resetBubble): Clear all the classes and content.
- (WebInspector.ResourceSidebarTreeElement.prototype.set searchMatches): Set the bubbleText and class.
- (WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings): Call resetBubble.
- * page/inspector/ScriptView.js:
- (WebInspector.ScriptView): Set _sourceFrameSetup to flase.
- (WebInspector.ScriptView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
- it will start at the first result.
- (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Add an event listener for "syntax
- highlighting complete".
- (WebInspector.ScriptView.prototype): Share many methods with SourceView.
- * page/inspector/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.show): Hide any views that are visible that are not this
- This can happen when a ResourceView is visible in the Resources panel then switched to the this panel.
- (WebInspector.ScriptsPanel.prototype.get searchableViews): Return all views, with the visibleView first.
- (WebInspector.ScriptsPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
- (WebInspector.ScriptsPanel.prototype.showView): Call _showScriptOrResource. Used by Panel to show a view.
- (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource): Added helper.
- * page/inspector/SourceFrame.js:
- (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Dispatch a "syntax highlighting complete" event.
- * page/inspector/SourceView.js:
- (WebInspector.SourceView.prototype.hide):
- (WebInspector.SourceView.prototype.detach):
- (WebInspector.SourceView.prototype._resourceLoadingFinished): Moved from the bottom of the file.
- (WebInspector.SourceView.prototype._addBreakpoint): Ditto.
- (WebInspector.SourceView.prototype.searchCanceled): Delete search properties.
- (WebInspector.SourceView.prototype.performSearch): Search the frame if it is loaded, otherwise
- store the worker function as _delayedFindSearchMatches and call it later in _sourceFrameSetupFinished.
- (WebInspector.SourceView.prototype.jumpToFirstSearchResult):
- (WebInspector.SourceView.prototype.jumpToLastSearchResult):
- (WebInspector.SourceView.prototype.jumpToNextSearchResult):
- (WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
- (WebInspector.SourceView.prototype.showingFirstSearchResult):
- (WebInspector.SourceView.prototype.showingLastSearchResult):
- (WebInspector.SourceView.prototype._jumpToSearchResult): Selects the found Range.
- (WebInspector.SourceView.prototype._sourceFrameSetupFinished): Calls _delayedFindSearchMatches.
- (WebInspector.SourceView.prototype._syntaxHighlightingComplete): Call _sourceFrameSetupFinished.
- * page/inspector/inspector.css:
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Rename some properties of ResourcesPanel and ScriptsPanel to be the same,
- so future code can be shared.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ResourcesPanel.js: Renamed resourceViews to viewsContainerElement.
- And visibleResourceView to visibleView.
- * page/inspector/ScriptsPanel.js: Renamed scriptResourceViews to viewsContainerElement.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Highlight all matched search results in the Elements panel DOM tree.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.searchCanceled): Clear the highlight
- on all previous search results.
- (WebInspector.ElementsPanel.prototype.performSearch): Set the hihglight
- on all new search results.
- * page/inspector/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeElement): Delay setting the title until onattach.
- (WebInspector.ElementsTreeElement.prototype.get/set highlighted): Sets or removes
- the highlighted class on the listItemElement.
- (WebInspector.ElementsTreeElement.prototype.onattach): Set the highlighted class
- if needed. Calls _updateTitle.
- (WebInspector.ElementsTreeElement.prototype._updateTitle): Adds a span with the highlight
- class so it can be styled when the highlighted class is present.
- * page/inspector/inspector.css: New style rules for the hihglight.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Add search support to the Elements panel.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.searchCanceled): Call updateSearchMatchesCount
- with a 0 match count to rest. Reset the other search properties.
- (WebInspector.ElementsPanel.prototype.performSearch): Evaluates the search as an XPath
- query and a CSS selector on all the Documents in the page. Remembers the found nodes
- and avoids duplicates. Focuses the first result.
- (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): Focuses the next result.
- (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): Focuses the previous result.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Add support to Panel that allows easy searching of sub-views.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/Panel.js:
- (WebInspector.Panel.prototype.searchCanceled): Call searchCanceled on all the
- views in the search results and delete the currentQuery property. Call
- WebInspector.updateSearchMatchesCount wit ha 0 match count to rest. Reset the
- other search properties.
- (WebInspector.Panel.prototype.performSearch): Call searchCanceled since it will
- reset everything we need before doing a new search. Get an array of searchableViews
- from the panel, implemented by sub-classes. Iterate over the views one-by-one
- with an interval to prevent blocking the UI for large lists of searchableViews.
- This keeps the interface really responsive. Pass a finishedCallback function to
- the performSearch on each view so it can notify the panel of results.
- (WebInspector.Panel.prototype.jumpToNextSearchResult): Finds the index in the
- searchResults of the visibleView, so we know where in the results we are.
- This is done every time incase the user manually navigates to a new view.
- If the view is showing the last result, jump to the next view and show it's
- first result. Otherwise jump to the next result in the current view.
- (WebInspector.Panel.prototype.jumpToPreviousSearchResult): Ditto, but in reverse.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Add support for asking the current panel to perform a search, find next/previous and clear.
- A search is performed on the new new current panel when switching between panels. The search
- label/placeholder in the toolbar now includes the panel name to make it clear that panel will
- be searched. The search field contents are selected when Command/Control-F or Enter/Return
- is pressed, so the user can easily type an entirely new query. The search match count shows
- up in the toolbar next to the search field.
-
- Also changed:
- * Rename lastQuery to currentQuery since it better matches the truth.
- * Set the search field "results" attribute to zero since results arn't saved for
- how we use the search field.
- * Make repeated presses of the Return key jump to the next search result instead
- of doing nothing.
- * Increased the search field width.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * English.lproj/localizedStrings.js: New strings.
- * page/inspector/inspector.css: New styles.
- * page/inspector/inspector.html: Add the search-results-matches element. Add the
- incremental attribute to the search field and set the results attribute to zero.
- * page/inspector/inspector.js:
- (WebInspector.set currentPanel): perform the search on the new panel.
- (WebInspector.loaded): Change the event listeners and remove code that changes
- the search label text.
- (WebInspector.documentKeyDown): Add support for Command/Control-G and
- Command/Control-Shift-G. To jump to the next and previous search results.
- (WebInspector.updateSearchLabel): Added. Update the search placeholder/label.
- This does different things depending on the attached state.
- (WebInspector.searchKeyDown): Call preventDefault since this was the Enter key.
- This prevents a "search" event from firing for key down. We handle the Enter key
- on key up in searchKeyUp. This stops performSearch from being called twice in a row.
- (WebInspector.searchKeyUp): Calls performSearch when it is the Enter key.
- (WebInspector.performSearch): Delete the currentQuery property and call searchCanceled
- on all the panels. Call jumpToNextSearchResult when this is the same query or a forced search.
- Call updateSearchMatchesCount to reset the matches count in the toolbar.
- (WebInspector.updateSearchMatchesCount): Added. Updates the matches count in the toolbar.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Remove the previous Inspector search code to make room for the new stuff.
-
- https://bugs.webkit.org/show_bug.cgi?id=21005
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/inspector.css:
- * page/inspector/inspector.html:
- * page/inspector/inspector.js:
- (WebInspector.get/set showingSearchResults): Removed.
- (WebInspector.searchResultsKeyDown): Removed.
- (WebInspector.searchResultsResizerDragStart): Removed.
- (WebInspector.searchResultsResizerDragEnd): Removed.
- (WebInspector.searchResultsResizerDrag): Removed.
- (WebInspector.performSearch): Removed searching parts.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Use the Array.remove helper function in more places.
-
- https://bugs.webkit.org/show_bug.cgi?id=21037
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ResourceCategory.js:
- (WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
- * page/inspector/ResourcesPanel.js:
- (WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
- * page/inspector/inspector.js:
- (WebInspector.removeResource): Ditto.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where inspecting a node after reloading the page
- would not reveal the node in the DOM tree. The TreeOutline
- was not being told to forget decendants of a removed child.
- So old TreeElements would be found that are not in the tree.
-
- https://bugs.webkit.org/show_bug.cgi?id=21036
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/treeoutline.js:
- (TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive
- in addition to _forgetTreeElement.
- (TreeOutline._removeChildren): Call _forgetChildrenRecursive
- in addition to _forgetTreeElement.
- (TreeOutline._rememberTreeElement): Use Array.indexOf to quickly
- search for known elements.
- (TreeOutline._forgetTreeElement): Use Array.remove to remove elements.
- (TreeOutline._forgetChildrenRecursive): Recursively traverse the
- descendants and call _forgetTreeElement.
- * page/inspector/utilities.js:
- (Array.prototype.remove): Speed up this function by using Array.indexOf
- when onlyFirst is true.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where inspecting some short text nodes does
- not reveal them in the Elements panel DOM tree.
-
- https://bugs.webkit.org/show_bug.cgi?id=21035
-
- Reviewed by Oliver Hunt.
-
- * page/inspector/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
- The revealAndSelectNode() method might find a different element
- if there is inlined text, and the select() call would change the
- focusedDOMNode and reenter this setter. So to avoid calling
- focusedNodeChanged() twice, first check if _focusedDOMNode is
- the same node as the one passed in.
- (WebInspector.ElementsTreeOutline.prototype.update): Remove use of
- this.treeOutline, since this is the TreeOutline.
- (WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added.
- Provides default functions for isAncestor, getParet and equal.
- Calls the base protoype's findTreeElement. If that returns null
- and the node is a text node, try finding it's parent.
- (WebInspector.ElementsTreeOutline.prototype.revealNode): Removed.
- Renamed to revealAndSelectNode.
- (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
- Selects and reveals the node passed in. Use the simple findTreeElement.
- (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
- Remove use of this.treeOutline, since this is the TreeOutline.
-
-2008-09-23 Timothy Hatcher <timothy@apple.com>
-
- Fixes an exception that happened when removing a Resource
- from the ResourcesPanel.
-
- https://bugs.webkit.org/show_bug.cgi?id=21034
+ Reviewed by Eric Seidel.
- Reviewed by Kevin McCullough.
+ There is no new test because this cannot be tested deterministically.
+ I've not been able to cause a crash at all in the test framework, but
+ I have verified that this is happening in the wild and that the patch
+ fixes the likely cause in the debugger.
- * page/inspector/ResourcesPanel.js:
- (WebInspctor.ResourcesPanel.prototype.removeResource):
- Remove the graphElement.
-
-2008-09-23 Kevin McCullough <kmccullough@apple.com>
-
- Fixed "Time" to "Tim"
-
- * ChangeLog:
-
-2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver.
-
- Move mapInstanceToElement/removeInstanceMapping/instancesForElement
- from SVGDocumentExtensions to SVGElement. It's more useful to store
- the list of SVGElementInstances per SVGElement, instead of using
- a document-wide hash for this purpose.
-
- * svg/SVGAnimateMotionElement.cpp:
- (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- * svg/SVGAnimateTransformElement.cpp:
- (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- * svg/SVGAnimationElement.cpp:
- (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- * svg/SVGDocumentExtensions.cpp:
- (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
- * svg/SVGDocumentExtensions.h:
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::mapInstanceToElement):
- (WebCore::SVGElement::removeInstanceMapping):
- (WebCore::SVGElement::instancesForElement):
- * svg/SVGElement.h:
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::SVGElementInstance):
- (WebCore::SVGElementInstance::~SVGElementInstance):
- (WebCore::SVGElementInstance::updateAllInstancesOfElement):
- * svg/SVGElementInstance.h:
- * svg/SVGStyledElement.cpp:
- (WebCore::SVGStyledElement::svgAttributeChanged):
- (WebCore::SVGStyledElement::childrenChanged):
- * svg/SVGStyledElement.h:
-
-2008-09-23 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
+ * loader/TextResourceDecoder.cpp: careful not to iterate off the end
+ of our input buffer looking for the end of the comment.
- * WebCoreSources.bkl:
+2009-06-19 Adam Barth <abarth@webkit.org>
-2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
+ Reviewed by Dimitri Glazkov.
- Rubber stamped by Sam.
+ https://bugs.webkit.org/show_bug.cgi?id=26536
- Move code from EventTarget to EventTargetNode.
+ Fix external-script-URL-location.html and
+ write-external-script-open.html LayoutTests.
- I refactored most parts to live in EventTarget, a year ago,
- though the implementation of EventTargetSVGElementInstance is
- done in another way, that obsoletes this.
+ implicitOpen is called from several places. We need to setXSSAuditor
+ each time, so I moved the call inside implicitOpen.
* dom/Document.cpp:
- (WebCore::Document::addListenerTypeIfNeeded):
- * dom/Document.h:
- * dom/EventTarget.cpp:
- * dom/EventTarget.h:
- (WebCore::allowEventDispatch):
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::insertedIntoDocument):
- (WebCore::EventTargetNode::removedFromDocument):
- (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
- (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
- (WebCore::EventTargetNode::addEventListener):
- (WebCore::EventTargetNode::removeEventListener):
- (WebCore::EventTargetNode::removeAllEventListeners):
- (WebCore::EventTargetNode::handleLocalEvents):
- (WebCore::setCurrentEventTargetRespectingSVGTargetRules):
- (WebCore::EventTargetNode::dispatchEvent):
- (WebCore::EventTargetNode::dispatchGenericEvent):
- (WebCore::EventTargetNode::dispatchWindowEvent):
- (WebCore::EventTargetNode::removeEventListenerForType):
- * dom/EventTargetNode.h:
- * svg/EventTargetSVGElementInstance.cpp:
- (WebCore::EventTargetSVGElementInstance::dispatchEvent):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::sendSVGLoadEventIfPossible):
- * svg/SVGElement.h:
- (WebCore::SVGElement::supplementalTransform):
-
-2008-09-23 Dave Hyatt <hyatt@apple.com>
-
- Fix for bug 21012. The Aqua scrollbar was returning the wrong track rect on Windows Aqua theme. Make
- sure to not accidentally fall into the vertical scrollbar case for horizontal scrollbars. :)
+ (WebCore::Document::open):
+ (WebCore::Document::implicitOpen):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::begin):
- Reviewed by Sam Weinig
+2009-06-19 Kent Tamura <tkent@chromium.org>
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::trackRect):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeSafari::trackRect):
+ Reviewed by David Levin.
-2008-09-23 Beth Dakin <bdakin@apple.com>
+ Use WebCore::multipleFileUploadText() in Chromium to fix a problem
+ that Chromium shows only the first filename even if a user selects
+ multiple files for <input type=file multiple>.
+ <https://bugs.webkit.org/show_bug.cgi?id=26502>
- Reviewed by Sam Weinig.
+ * platform/chromium/FileChooserChromium.cpp:
+ (WebCore::FileChooser::basenameForWidth):
- Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
- link at gmail does not support AXPress action
- and corresponding: <rdar://problem/6216178>
-
- I fixed this bug by making AccessibilityObject::anchorElement
- support ARIA links.
-
- * page/AccessibilityImageMapLink.cpp:
- (WebCore::AccessibilityImageMapLink::anchorElement):
- * page/AccessibilityImageMapLink.h:
- * page/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::anchorElement):
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::isNativeAnchor):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isNativeAnchor):
- (WebCore::AccessibilityRenderObject::anchorElement):
- (WebCore::AccessibilityRenderObject::internalLinkElement):
- (WebCore::AccessibilityRenderObject::url):
- * page/AccessibilityRenderObject.h:
- * page/mac/AccessibilityObjectWrapper.mm:
- (AXLinkElementForNode):
-
-2008-09-23 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim and Oliver.
-
- Bug 20949: Catch repeated messages in Inspector Controller to limit
- memory usage
- - Store the repeat count in the Console Message object, in the
- Inspector Controller and JS ConsoleMessage object.
-
- * page/InspectorController.cpp:
- (WebCore::ConsoleMessage::ConsoleMessage):
- (WebCore::ConsoleMessage::operator==):
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::addConsoleMessage):
- (WebCore::InspectorController::addScriptConsoleMessage):
- * page/InspectorController.h:
- * page/inspector/Console.js:
- * page/inspector/Resource.js:
- * page/inspector/ResourcesPanel.js:
- * page/inspector/SourceFrame.js:
-
-2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric.
-
- Working on proper EventTarget support for SVGElementInstance.
-
- Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
- Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.
-
- Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
- implementation. Let it use TreeShared directly.
-
- It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
- The transition to EventTargetSVGElementInstance will be done in a few individual patches.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSEventTargetBase.cpp:
- (WebCore::retrieveEventTargetAndCorrespondingNode):
- (WebCore::toJS):
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetSVGElementInstance.cpp: Added.
- (WebCore::):
- (WebCore::JSEventTargetSVGElementInstance::JSEventTargetSVGElementInstance):
- (WebCore::JSEventTargetSVGElementInstance::createPrototype):
- (WebCore::JSEventTargetSVGElementInstance::setListener):
- (WebCore::JSEventTargetSVGElementInstance::getListener):
- (WebCore::toEventTargetSVGElementInstance):
- * bindings/js/JSEventTargetSVGElementInstance.h: Added.
- (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
- (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
- (WebCore::JSEventTargetSVGElementInstance::getValueProperty):
- (WebCore::JSEventTargetSVGElementInstance::put):
- (WebCore::JSEventTargetSVGElementInstance::putValueProperty):
- * bindings/js/JSSVGElementInstanceCustom.cpp: Added.
- (WebCore::toJS):
- * bindings/objc/DOM.mm:
- (+[DOMNode _wrapEventTarget:WebCore::]):
- (-[DOMSVGElementInstance _initWithSVGElementInstance:WebCore::]):
- (+[DOMSVGElementInstance _wrapSVGElementInstance:WebCore::]):
- (+[DOMSVGElementInstance _wrapEventTarget:WebCore::]):
- (-[DOMSVGElementInstance WebCore::]):
- (-[DOMSVGElementInstance addEventListener:listener:useCapture:]):
- (-[DOMSVGElementInstance addEventListener:::]):
- (-[DOMSVGElementInstance removeEventListener:listener:useCapture:]):
- (-[DOMSVGElementInstance removeEventListener:::]):
- (-[DOMSVGElementInstance dispatchEvent:]):
- * bindings/objc/DOMEvents.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bindings/scripts/CodeGeneratorObjC.pm:
- * svg/EventTargetSVGElementInstance.cpp: Added.
- (WebCore::EventTargetSVGElementInstance::EventTargetSVGElementInstance):
- (WebCore::EventTargetSVGElementInstance::~EventTargetSVGElementInstance):
- (WebCore::EventTargetSVGElementInstance::addEventListener):
- (WebCore::EventTargetSVGElementInstance::removeEventListener):
- (WebCore::EventTargetSVGElementInstance::dispatchEvent):
- * svg/EventTargetSVGElementInstance.h: Added.
- (WebCore::EventTargetSVGElementInstance::isEventTargetSVGElementInstance):
- (WebCore::EventTargetSVGElementInstance::toNode):
- (WebCore::EventTargetSVGElementInstance::toSVGElementInstance):
- (WebCore::EventTargetSVGElementInstance::refEventTarget):
- (WebCore::EventTargetSVGElementInstance::derefEventTarget):
- (WebCore::EventTargetSVGElementInstanceCast):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::dispatchEvent):
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::SVGElementInstance):
- (WebCore::SVGElementInstance::~SVGElementInstance):
- * svg/SVGElementInstance.h:
- (WebCore::SVGElementInstance::isEventTargetSVGElementInstance):
- * svg/SVGElementInstance.idl:
-
-2008-09-23 Dan Bernstein <mitz@apple.com>
+2009-06-19 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- - https://bugs.webkit.org/show_bug.cgi?id=21040
- Pass NULL instead of the identity matrix to CTFontCreateWithGraphicsFont()
+ - fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried
+ to look up a word in Dictionary using command-control-d
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::getCTFont):
+ Test: editing/selection/move-by-line-005.html
-2008-09-23 David Hyatt <hyatt@apple.com>
+ The root cause of this bug was searchAheadForBetterMatch() continuing
+ past the first rendered text object after the given object. While we
+ want to skip non-rendered text and empty containers, when we encounter
+ rendered text object, we must return a text box for that object.
- https://bugs.webkit.org/show_bug.cgi?id=21039
-
- Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollView.h:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::setFrameGeometry):
- * platform/Scrollbar.h:
- * platform/Widget.cpp:
- (WebCore::Widget::convertFromContainingWindow):
- * platform/Widget.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::ScrollView):
- (WebCore::ScrollView::~ScrollView):
- (WebCore::ScrollView::windowResizerRect):
- (WebCore::ScrollView::resizerOverlapsContent):
- (WebCore::ScrollView::adjustOverlappingScrollbarCount):
- (WebCore::ScrollView::setParent):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertFromContainingWindow):
-
-2008-09-23 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Darin Adler. Landed by Jan Alonzo.
-
- Added support for getImageData() and putImageData()
- to Cairo.
-
- [CAIRO] needs getImageData and putImageData support
- https://bugs.webkit.org/show_bug.cgi?id=20838
-
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
-
-2008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>
+ * dom/Position.cpp:
+ (WebCore::searchAheadForBetterMatch):
- Reviewed by Holger Freyther.
+2009-06-19 Jungshik Shin <jshin@chromium.org>
- http://bugs.webkit.org/show_bug.cgi?id=18987
- [GTK] Implement SharedBuffer::createWithContentsOfFile and
- KURL::fileSystemPath
+ Reviewed by David Levin
- * GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
- * platform/gtk/KURLGtk.cpp: Added.
- (WebCore::KURL::fileSystemPath): Implemented.
- * platform/gtk/SharedBufferGtk.cpp: Added.
- (WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
- * platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
+ https://bugs.webkit.org/show_bug.cgi?id=25657
-2008-09-23 Alexey Proskuryakov <ap@webkit.org>
+ Chromium Linux port does not handle non-BMP characters properly.
+ It's fixed with a 'UTF-16 iterator macro' to extract Unicode
+ codepoints out of a UTF-16 input string.
- Reviewed by Oliver Hunt, okayed by Darin Adler.
+ A manual test is added for non-BMP character rendering,
+ which we can use until a small freely-distributable font
+ covering non-BMP is added to the Webkit source tree.
- <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+ * manual-tests/non-bmp.html: Added.
-2008-09-23 Alexey Proskuryakov <ap@webkit.org>
+2009-06-19 Pavel Feldman <pfeldman@chromium.org>
- Reviewed by Darin Adler.
+ Reviewed by Dimitri Glazkov.
- https://bugs.webkit.org/show_bug.cgi?id=21023
- Don't use TEC for encodings supported by ICU
+ V8 Bindings: return proper state from the script stack.
- * platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic,
- x-mac-greek, and x-mac-turkish.
+ https://bugs.webkit.org/show_bug.cgi?id=26512
- * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
- Register aliases for these encodings that are not registered automatically; updated comments.
+ * bindings/v8/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ * bindings/v8/ScriptCallStack.h:
+ (WebCore::ScriptCallStack::state):
-2008-09-23 Maciej Stachowiak <mjs@apple.com>
+2009-06-19 Jessie Berlin <jberlin@apple.com>
- Reviewed by Darin.
+ Reviewed by Simon Fraser.
- - speed up instanceof some more
- https://bugs.webkit.org/show_bug.cgi?id=20818
+ Windows build fix.
+
+ * platform/graphics/cg/PatternCG.cpp:
+ (WebCore::Pattern::createPlatformPattern):
- ~2% speedup on EarleyBoyer
+2009-06-19 Yael Aharon <yael.aharon@nokia.com>
- (WebCore updates.)
+ Reviewed by Simon Hausmann.
+ Build fix after 44825.
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::createStructureID):
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::isSizeAvailable):
+ * platform/graphics/qt/ImageDecoderQt.h:
-2008-09-22 Darin Adler <darin@apple.com>
+2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
- - fix https://bugs.webkit.org/show_bug.cgi?id=21008
- getting pixels by index from CanvasPixelArray is unnecessarily slow
-
- * GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
-
- * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and
- indexSetter. These are now both inlined, so in the header.
- * bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex
- function is what's used for HasCustomIndexGetter. Also moved the
- indexSetter function here.
-
- * bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter
- to use a getByIndex member function rather than an indexGetter static
- member function in a property slot. This lets us avoid the property
- slot mechanism's rule where it turns numeric property names into
- strings in the identifier table, which is good because that's slow.
- Also added a new property CustomHeader that allows IDL files to
- introduce headers to be included -- useful when we have functions
- that we want to inline into the binding.
-
- * html/CanvasPixelArray.idl: Added CustomHeader attribute.
-
-2008-09-23 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Another blind stab in the dark.
-
- * svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
+ Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
+ <https://bugs.webkit.org/show_bug.cgi?id=26426>
-2008-09-23 Eric Seidel <eric@webkit.org>
+ Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
+ The original number cannot be represented by mantissa of float
+ (23bit) so that it caused some error.
- No review, build fix only.
-
- Third time's the charm, eh? My local build is sadly still not done...
-
- * platform/graphics/AffineTransform.cpp: remove extra &
- * platform/graphics/AffineTransform.h: remove extra &
-
-2008-09-22 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- * platform/graphics/AffineTransform.cpp: remove extra ;
-
-2008-09-22 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Speculative fix for the build while I wait for my compile to finish.
-
- * platform/graphics/AffineTransform.cpp:
-
-2008-09-22 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by eseidel. Landed by eseidel.
-
- Moved makeMapBetweenRects from SVG/CG to AffineTransform
- Make SVGResourceClipper::applyClip more cross-platform
-
- * platform/graphics/AffineTransform.cpp:
- * platform/graphics/AffineTransform.h:
- * svg/graphics/cg/CgSupport.cpp:
- * svg/graphics/cg/CgSupport.h:
- * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
- (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
- * svg/graphics/cg/SVGResourceClipperCg.cpp:
- (WebCore::SVGResourceClipper::applyClip):
-
-2008-09-22 Alp Toker <alp@nuanti.com>
-
- Reviewed by David Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=16331
- [Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed
-
- Obey GTK+ focusing conventions for controls and anchor elements.
-
- It could be interesting to push these decisions up to Settings or
- ChromeClient some day but this gets things working.
-
- Right and middle click events still need some work to match GTK+
- conventions.
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::isMouseFocusable):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::isMouseFocusable):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::sendContextMenuEvent):
-
-2008-09-22 Darin Adler <darin@apple.com>
-
- * page/mac/FrameMac.mm:
- (WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
-
-2008-09-22 Sam Weinig <sam@webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
- Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
- and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
- class!
-
- - selectionStart, selectionEnd and setSelectionRange now are visible in iteration of
- non-selectable input types, but return undefined when accessed.
-
- * DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * bindings/js/JSHTMLInputElementBase.cpp: Removed.
- * bindings/js/JSHTMLInputElementBase.h: Removed.
- * bindings/js/JSHTMLInputElementCustom.cpp: Added.
- (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
- (WebCore::JSHTMLInputElement::selectionStart):
- (WebCore::JSHTMLInputElement::selectionEnd):
- * bindings/js/JSHTMLInputElementCustom.h: Added.
- * html/HTMLInputElement.idl:
-
-2008-09-22 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message
-
- Not testable in DumpRenderTree or in Safari
-
- * page/mac/FrameMac.mm:
- (WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the
- case that the selection start node is a block.
-
-2008-09-22 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21007
-
- Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.
-
- Reviewed by Sam Weinig
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
-
-2008-09-22 Eric Seidel <eric@webkit.org>
-
- No review, rollback only.
+ Test: fast/canvas/image-object-in-canvas.html:
- Roll out Peter's change (per his request)
- http://trac.webkit.org/changeset/36069
- https://bugs.webkit.org/show_bug.cgi?id=19663
- This change has been the source of numerous regressions
- (several of which were latent bugs revealed by this change,
- others were bugs in this change)
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::startAnimation):
- (WebCore::BitmapImage::advanceAnimation):
- * platform/graphics/BitmapImage.h:
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
-
-2008-09-22 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/5158514> Switch the complex text code path to Core Text
-
- Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html
- platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html
-
- * config.h: Use Core Text if not building for Leopard or Tiger.
-
-2008-09-22 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=21006
-
- Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
- switched on. There are still a few more refinements to make to the rendering and behavior.
-
- Reviewed by Darin Adler
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::paintTrack):
- (WebCore::ScrollbarThemeComposite::paintButton):
- (WebCore::ScrollbarThemeComposite::paintThumb):
- * platform/mac/ScrollbarThemeMac.h:
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::backButtonRect):
- (WebCore::ScrollbarThemeMac::forwardButtonRect):
- (WebCore::scrollbarPartToHIPressedState):
- (WebCore::ScrollbarThemeMac::paint):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::invalidateRect):
-
-2008-09-22 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig
-
- transition end event when -webkit-transition-property: all puts wrong
- propertyName in event
- https://bugs.webkit.org/show_bug.cgi?id=20903
-
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::sendTransitionEvent):
-
-2008-09-22 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell
-
- Test: accessibility/table-one-cell.html
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
-
-2008-09-22 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly
-
- Test: accessibility/textarea-selected-text-range.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::setSelectedTextRange):
-
-2008-09-22 David Hyatt <hyatt@apple.com>
-
- Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
- properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
- parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
- rule.
+ * platform/graphics/cg/PatternCG.cpp:
+ (WebCore::Pattern::createPlatformPattern):
- Reviewed by Sam Weinig
+2009-06-19 Adam Barth <abarth@webkit.org>
- Added fast/css/nested-rule-parent-sheet.html
+ Unreviewed attempt to fix the Chromium build.
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::insertedIntoParent):
- * css/CSSRule.cpp:
- (WebCore::CSSRule::parentStyleSheet):
- (WebCore::CSSRule::parentRule):
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::CSSStyleSheet):
- * css/CSSStyleSheet.h:
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ (WebCore::ScriptController::evaluate):
+ * bindings/v8/ScriptController.h:
+ (WebCore::ScriptController::xssAuditor):
+ * bindings/v8/ScriptEventListener.cpp:
+ (WebCore::createAttributeEventListener):
-2008-09-22 Dan Bernstein <mitz@apple.com>
+2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
- - fix https://bugs.webkit.org/show_bug.cgi?id=21002
- Make the ATSUI code path respect spacingDisabled()
-
- Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text
-
- * platform/graphics/mac/FontMacATSUI.mm:
- (WebCore::overrideLayoutOperation):
-
-2008-09-22 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
-
- Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
-
- 2.2% speedup on EarleyBoyer benchmark.
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::createStructureID):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2008-09-22 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
-
-2008-09-22 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Dave Hyatt.
+ https://bugs.webkit.org/show_bug.cgi?id=26199
- Based on initial work by Darin Adler.
+ Added an experimental reflective XSS filter. The filter is disabled by
+ default.
- - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
- - use this to JIT inline code for eq_null and neq_null
- https://bugs.webkit.org/show_bug.cgi?id=20823
-
- * WebCore.xcodeproj/project.pbxproj:
- * WebCore.vcproj/WebCore.vcproj:
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter):
- * bindings/js/JSHTMLAllCollection.cpp: Added.
- (WebCore::):
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::createStructureID):
- (WebCore::JSHTMLAllCollection::toBoolean):
-
-2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Fix the QtWebKit build
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtRuntimeObjectImp::construct):
- * bridge/qt/qt_runtime.cpp:
-
-2008-09-22 Alp Toker <alp@nuanti.com>
-
- Suggested by David Hyatt.
-
- Build fix: ScrollView::update() is still used by Document.cpp on !MAC
- so make it public.
-
- * platform/ScrollView.h:
-
-2008-09-22 David Hyatt <hyatt@apple.com>
-
- Fix a regression in Windows scrollbar painting. (Also fix the same
- bug in my new viewless Mac scrollbar painting code). The track rect
- was being improperly inflated when painting resulting in the scrollbar
- being too tall and painting in the border of overflow sections.
-
- Reviewed by Oliver Hunt
-
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::trackRect):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarThemeSafari::trackRect):
-
-2008-09-22 David Hyatt <hyatt@apple.com>
-
- Fix a hit testing bug where events are mistakenly passed to subframes
- if the mouse is over the border or padding area of the frame. Add
- a boolean flag, isOverWidget(), to hit test results so that EventHandler
- can check it to tell if the mouse is really over the content box of a
- RenderWidget and not just in the border/padding area.
-
- This is not testable, since the old code properly recovered when it detected
- that the mouse was outside the bounds of the view, but this prevents
- the extra passdown from even occurring (and is basically a nice cleanup).
-
- Reviewed by Oliver Hunt
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::hitTestResultAtPoint):
- (WebCore::subframeForHitTestResult):
- (WebCore::EventHandler::handleMouseDoubleClickEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::handleMouseReleaseEvent):
- (WebCore::EventHandler::handleWheelEvent):
- * page/MouseEventWithHitTestResults.h:
- (WebCore::MouseEventWithHitTestResults::isOverWidget):
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::HitTestResult):
- (WebCore::HitTestResult::operator=):
- * rendering/HitTestResult.h:
- (WebCore::HitTestResult::isOverWidget):
- (WebCore::HitTestResult::setIsOverWidget):
- * rendering/RenderWidget.cpp:
- (WebCore::RenderWidget::nodeAtPoint):
- * rendering/RenderWidget.h:
-
-2008-09-21 David Hyatt <hyatt@apple.com>
-
- Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
- both it and ScrollView's updateContents method be off-limits to everyone in
- WebCore except for RenderView.
-
- Make repaintViewRectangle the only possible method for WebCore code to do
- an invalidation. This ensures that all invalidates triggered by WebCore
- cross-platform code that cross ownerElement() boundaries are transform-aware.
-
- Make sure that iframes/frames contained inside objects that have transforms
- or reflections are not allowed to blit (this was already true for transparency).
-
- It is not possible to make a test for any of this, since iframe scrolling
- still doesn't work on Mac (since the invalidates are not being done
- through WebCore's cross-platform invalidation code but are instead going
- through NSScrollView's setNeedsDisplay still).
-
- Reviewed by Oliver Hunt
-
- * editing/SelectionController.cpp:
- (WebCore::SelectionController::recomputeCaretRect):
- (WebCore::SelectionController::invalidateCaretRect):
- (WebCore::SelectionController::focusedOrActiveStateChanged):
- * page/FrameView.cpp:
- (WebCore::FrameView::repaintContentRectangle):
- (WebCore::FrameView::endDeferredRepaints):
- * page/FrameView.h:
- * platform/ScrollView.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::paintFillLayerExtended):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::enclosingPositionedAncestor):
- (WebCore::RenderLayer::requiresSlowRepaints):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::hasTransform):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::paintBoxDecorations):
- (WebCore::RenderView::repaintViewRectangle):
- (WebCore::RenderView::setSelection):
-
-2008-09-21 Maciej Stachowiak <mjs@apple.com>
-
- Reviewed by Darin.
-
- - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
- https://bugs.webkit.org/show_bug.cgi?id=20981
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor):
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::createDOMStructure):
- * bindings/js/JSDOMBinding.h:
- (WebCore::getDOMStructure):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::JSDOMWindowShell):
- (WebCore::JSDOMWindowShell::setWindow):
- * bindings/js/JSEventTargetNode.cpp:
- (WebCore::JSEventTargetNode::createPrototype):
- * bindings/js/JSHTMLOptionElementConstructor.cpp:
- (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor):
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2008-09-21 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - fix problem Maciej noticed where every JSNamedNodesCollection
- gets its own StructureID
-
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use
- getDOMStructure to get the structure.
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::createPrototype): Return the
- object prototype.
-
-2008-09-20 David Hyatt <hyatt@apple.com>
-
- Make sure transformed scrollbars in overflow sections position
- properly. This patch mimics the same behavior that works for
- iframes, namely making sure that the same code that dynamically
- adjusts iframe widget positions at paint time for fixed positioning
- and transforms also applies to scrollbars. (This is as simple as passing
- in the current translation factor at paint time rather than crawling
- up the layer tree to compute a "false" absolute position.)
-
- An existing transform test covers this (although only a pixel result
- reveals the correct rendering).
-
- Reviewed by Darin Adler
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::positionOverflowControls):
- (WebCore::RenderLayer::paintOverflowControls):
- (WebCore::RenderLayer::paintLayer):
- * rendering/RenderLayer.h:
-
-2008-09-21 Steve Falkenburg <sfalken@apple.com>
-
- Removed unnecessary nested timer check.
-
- Rubber-stamped by Dan Bernstein.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::TimerWindowWndProc):
-
-2008-09-21 Steve Falkenburg <sfalken@apple.com>
-
- Improve timer resolution on WinXP.
- https://bugs.webkit.org/show_bug.cgi?id=20979
-
- Removed last-chance timer. It should not be necessary.
- Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
- Remove Vista checks. We now run the same code on both XP and Vista.
-
- Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
- The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).
-
- Reviewed by Maciej Stachowiak.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::):
- (WebCore::TimerWindowWndProc):
- (WebCore::setSharedTimerFireTime):
- * platform/win/SystemTimeWin.cpp:
- (WebCore::currentTime):
-
-2008-09-21 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by eseidel. Landed by eseidel.
-
- All platforms use the DashArray in the GraphicsContext.
-
- * svg/graphics/SVGPaintServer.h:
- * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
- (WebCore::SVGPaintServerGradient::setup):
- * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
- (WebCore::SVGPaintServerPattern::setup):
- * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp:
- (WebCore::SVGPaintServerSolid::setup):
- * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
- (WebCore::SVGPaintServerGradient::setup):
- * svg/graphics/qt/SVGPaintServerQt.cpp:
- * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
- (WebCore::SVGPaintServerSolid::setup):
-
-2008-09-21 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by eseidel. Landed by eseidel.
-
- Moved DashArray to GraphicsContext.
+ Test: http/tests/security/xssAuditor/script-tag.html
* GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/graphics/DashArray.h: Added.
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::setLineDash):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::setLineDash):
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::setLineDash):
- * svg/graphics/SVGPaintServer.cpp:
- (WebCore::applyStrokeStyleToContext):
- * svg/graphics/SVGPaintServer.h:
- * svg/graphics/cg/CgSupport.cpp:
- * svg/graphics/cg/CgSupport.h:
-
-2008-09-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - fix linker warnings
-
* WebCore.base.exp:
-
-2008-09-20 Darin Adler <darin@apple.com>
-
- - another try at fixing Qt
-
- * bridge/qt/qt_runtime.cpp: "using namespce WebCore"
-
-2008-09-20 Darin Adler <darin@apple.com>
-
- - blind attempt to fix Qt build
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue): Use regExpStructure instead
- of regExpPrototype to make a RegExpObject. There should really be
- some sort of public helper function for this. Same thing for
- DateInstance and dateStructure. For JSObject, use constructEmptyObject.
- (JSC::Bindings::):
- (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure.
- It is not correct to do this inside the constructor because it could
- cause a garbage collect while the QtRuntimeMethod object is half-
- allocated, which could lead to a crash; note that RuntimeMethod,
- QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
- * bridge/qt/qt_runtime.h: Add s_info and createPrototype.
-
-2008-09-20 Collin Jackson <collinj@webkit.org>
-
- Prefetch DNS for hyperlinks that the user mouses over.
-
- https://bugs.webkit.org/show_bug.cgi?id=20931
-
- Reviewed by Sam Weinig.
-
- * page/Chrome.cpp:
- (WebCore::Chrome::mouseDidMoveOverElement):
-
-2008-09-20 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - finish https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure
- ID. Note that this makes a new structure every time -- we could
- optimize this slightly be caching and reusing a single one.
-
- * bridge/runtime_method.cpp:
- (JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using
- getDOMStructure.
- * bridge/runtime_method.h:
- (JSC::RuntimeMethod::createPrototype): Added createPrototype so
- getDOMStructure will work.
-
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to
- 0; needed in case garbage collection happens while creating the
- JSDOMWindow.
-
-2008-09-20 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Eric Seidel.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20950
- <rdar://problem/6234059> Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc
-
- * svg/SVGTextContentElement.cpp:
- (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to
- not include the first character in the extraCharsAvailable count.
-
-2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
-
- Reviewed by Dan Bernstein.
-
- Fix memory leak.
-
- https://bugs.webkit.org/show_bug.cgi?id=20505
-
- * platform/wx/wxcode/mac/carbon/fontprops.cpp:
- (GetTextExtent):
-
-2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.
-
- * WebCoreSources.bkl:
- * platform/ScrollView.h:
- * platform/wx/PopupMenuWx.cpp:
- (WebCore::PopupMenu::show):
- * platform/wx/RenderThemeWx.cpp:
- (WebCore::RenderThemeWx::paintButton):
- (WebCore::RenderThemeWx::paintTextField):
- (WebCore::RenderThemeWx::paintMenuList):
- (WebCore::RenderThemeWx::paintMenuListButton):
- * platform/wx/ScrollViewWx.cpp:
- (WebCore::ScrollView::setPlatformWidget):
- (WebCore::ScrollView::updateContents):
- (WebCore::ScrollView::update):
- (WebCore::ScrollView::visibleWidth):
- (WebCore::ScrollView::visibleHeight):
- (WebCore::ScrollView::scrollBy):
- (WebCore::ScrollView::resizeContents):
- (WebCore::ScrollView::contentsWidth):
- (WebCore::ScrollView::contentsHeight):
- (WebCore::ScrollView::isScrollViewScrollbar):
- (WebCore::ScrollView::adjustScrollbars):
- (WebCore::ScrollView::inWindow):
- (WebCore::ScrollView::removeChild):
- * platform/wx/WidgetWx.cpp:
- * plugins/wx/PluginViewWx.cpp:
- (WebCore::PluginView::setParentVisible):
- (WebCore::PluginView::updatePluginWidget):
-
-2008-09-20 Timothy Hatcher <timothy@apple.com>
-
- Fix the new Node Search button image to not be blurry.
-
- * page/inspector/Images/nodeSearchButtons.png:
-
-2008-09-20 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Tim Hatcher.
-
- Cut down some of the inspector javascript -> InspectorController glue code
- with two new macros. Also rearrange the exposed function list to be grouped
- by implementation and to all explicitly use the WebCore namespace.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::windowScriptObjectAvailable):
-
-2008-09-20 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Tim Hatcher.
-
- Fix regression from my previous patch where the breadcrumbs bar was not displayed.
-
- * page/inspector/inspector.css:
-
-2008-09-20 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric.
-
- Refactor HTMLImageLoader/SVGImageLoader code.
- Move html/HTMLImageLoader.* to loader/ImageLoader.*
-
- Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
- SVGImageLoader used to inherit from HTMLImageLoader which is awkward.
-
- * GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/Document.cpp:
- (WebCore::Document::dispatchImageLoadEventSoon):
- (WebCore::Document::removeImage):
- (WebCore::Document::dispatchImageLoadEventsNow):
- * dom/Document.h:
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::HTMLImageLoader):
- (WebCore::HTMLImageLoader::~HTMLImageLoader):
- (WebCore::HTMLImageLoader::sourceURI):
- (WebCore::HTMLImageLoader::notifyFinished):
- * html/HTMLImageLoader.h:
- * loader/DocLoader.h:
- * loader/ImageLoader.cpp: Copied from html/HTMLImageLoader.cpp.
- (WebCore::ImageLoader::ImageLoader):
- (WebCore::ImageLoader::~ImageLoader):
- (WebCore::ImageLoader::setImage):
- (WebCore::ImageLoader::setLoadingImage):
- (WebCore::ImageLoader::updateFromElement):
- (WebCore::ImageLoader::notifyFinished):
- * loader/ImageLoader.h: Copied from html/HTMLImageLoader.h.
- * svg/SVGImageElement.cpp:
- (WebCore::SVGImageElement::attach):
- (WebCore::SVGImageElement::insertedIntoDocument):
- (WebCore::SVGImageElement::imageSourceAttributeName):
- * svg/SVGImageElement.h:
- * svg/SVGImageLoader.cpp:
- (WebCore::SVGImageLoader::SVGImageLoader):
- (WebCore::SVGImageLoader::dispatchLoadEvent):
- (WebCore::SVGImageLoader::sourceURI):
- * svg/SVGImageLoader.h:
-
-2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- [qtwebkit] ScrollBar build fix after r36684.
- BackButtonPart was split into Start and End Part
- ForwardButtonPart was split into Start and End Part
-
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::scPart):
- (WebCore::scrollbarPart):
- (WebCore::styleOptionSlider):
-
-2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- [qtwebkit] Make qt_instance.cpp compile.
- Revision of 36675 introduced getDOMStructure to give unique
- structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
- the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getRuntimeObject):
-
-2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Nikolas Zimmermann.
-
- [svg] Change SVGLocatable to deal with a plain SVGElement
- There is no requirement in the code that we have to have a
- SVGStyledElement. Remove that artificial limitation and compile
- with SVGElement.
-
- * svg/SVGLocatable.cpp:
- * svg/SVGLocatable.h:
-
-2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Nikolas Zimmermann.
-
- [svg] Use OwnPtr for the SVGExtensions to avoid custom lifetime
- management.
-
- * dom/Document.cpp:
- (WebCore::Document::~Document):
- (WebCore::Document::svgExtensions):
- (WebCore::Document::accessSVGExtensions):
- * dom/Document.h:
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Fix for crash in updateTransitions. Make sure to test for a style
- being null when comparing two RenderStyles.
-
- Reviewed by Oliver Hunt
-
- * page/animation/AnimationBase.cpp:
- (WebCore::PropertyWrapperGetter::equals):
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=20954
-
- Roll out r36628 since it has caused horrible regressions with
- animated GIF CPU usage.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::cacheFrame):
- (WebCore::BitmapImage::startAnimation):
- * platform/graphics/BitmapImage.h:
- (WebCore::FrameData::FrameData):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::FrameData::clear):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::FrameData::clear):
-
-2008-09-20 Alp Toker <alp@nuanti.com>
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=20913
- Avoid redudant includes
-
- Document.h is included excessively such that a modification to Document.h (or
- any of the header it includes itself) triggers a rebuild of many files
- including the whole of SVG and a lot of the JS bindings.
-
- Some of these includes can be avoided by only including Document.h where
- necessary.
-
- * bindings/js/JSAttrCustom.cpp:
- * bindings/js/JSElementCustom.cpp:
- * bindings/js/JSEventTargetBase.cpp:
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSEventTargetNode.cpp:
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- * bindings/scripts/CodeGeneratorJS.pm:
- * css/CSSCursorImageValue.cpp:
- * css/SVGCSSStyleSelector.cpp:
- * dom/make_names.pl:
- * svg/SVGAnimateElement.h:
- * svg/SVGAnimatedProperty.h:
- (WebCore::::baseValue):
- (WebCore::::setBaseValue):
- (WebCore::::startAnimation):
- (WebCore::::stopAnimation):
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::accessDocumentSVGExtensions):
- * svg/SVGElement.h:
- * svg/SVGElementInstance.cpp:
- * svg/SVGFitToViewBox.cpp:
- * svg/SVGFontElement.cpp:
- * svg/SVGFontFaceElement.cpp:
- * svg/SVGLinearGradientElement.cpp:
- * svg/SVGMPathElement.cpp:
- * svg/SVGViewSpec.cpp:
-
-2008-09-19 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Antti & Eric.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
-
- Finish HTMLScriptElement / SVGScriptElement unification.
- SVG <script> support is complete now, full SVGLoad event
- respecting the influence of the externalResourcesRequired attribute
- as well as SVGError event support. All other features shared with HTML.
-
- Tests: fast/dom/HTMLScriptElement/script-reexecution.html
- svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
- svg/dom/SVGScriptElement/script-load-and-error-events.svg
- svg/dom/SVGScriptElement/script-reexecution.svg
- svg/dom/SVGScriptElement/script-set-href.svg
-
- * dom/ScriptElement.cpp:
- (WebCore::ScriptElementData::ScriptElementData):
- (WebCore::ScriptElementData::requestScript):
- * dom/ScriptElement.h:
- (WebCore::ScriptElementData::haveFiredLoadEvent):
- (WebCore::ScriptElementData::setHaveFiredLoadEvent):
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::setCreatedByParser):
- (WebCore::SVGScriptElement::parseMappedAttribute):
- (WebCore::SVGScriptElement::svgAttributeChanged):
- (WebCore::SVGScriptElement::insertedIntoDocument):
- (WebCore::SVGScriptElement::removedFromDocument):
- (WebCore::SVGScriptElement::childrenChanged):
- (WebCore::SVGScriptElement::isURLAttribute):
- (WebCore::SVGScriptElement::finishParsingChildren):
- (WebCore::SVGScriptElement::type):
- (WebCore::SVGScriptElement::setType):
- (WebCore::SVGScriptElement::haveLoadedRequiredResources):
- (WebCore::SVGScriptElement::dispatchLoadEvent):
- (WebCore::SVGScriptElement::dispatchErrorEvent):
- * svg/SVGScriptElement.h:
-
-2008-09-19 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20951
- Typo in Position::getInlineBoxAndOffset()
- and add an assertion
-
- Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
-
- * dom/Position.cpp:
- (WebCore::Position::getInlineBoxAndOffset):
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::positionForOffset):
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Add support for hit testing of all five possible scrollbar button placements.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::):
- (WebCore::ScrollbarThemeMac::backButtonRect):
- (WebCore::ScrollbarThemeMac::forwardButtonRect):
- (WebCore::ScrollbarThemeMac::trackRect):
- (WebCore::ScrollbarThemeMac::paintButton):
-
-2008-09-19 Darin Adler <darin@apple.com>
-
- - try to fix Qt build
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
- (JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
- * bridge/runtime_object.h: Ditto.
-
-2008-09-19 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Transition starts running when it shouldn't
- https://bugs.webkit.org/show_bug.cgi?id=20892
-
- When there is a transition and an animation on the
- same element, make sure the animation wins.
-
- The fix is to save the unanimated style when an animation is started.
- Then, when starting a transition, check to see if there is a current
- animation on the same prop. If so, use the unanimated style as the
- fromStyle rather than the current style.
-
- Test: animations/transition-and-animation-1.html
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- (WebCore::CompositeAnimation::animate):
- (WebCore::CompositeAnimation::getAnimationForProperty):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::reset):
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::hasAnimationForProperty):
- * page/animation/KeyframeAnimation.h:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
- (WebCore::KeyframeAnimation::unanimatedStyle):
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Add support for painting/hit testing of four possible scrollbar buttons.
- The Windows themes simply ignore the two parts that they will never
- show. The Mac theme also ignores the other two buttons for now.
-
- The cross-platform base for all three themes, ScrollbarThemeComposite,
- has all the proper support though.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::hitTest):
- (WebCore::ScrollbarThemeComposite::invalidatePart):
- * platform/ScrollbarThemeComposite.h:
- * platform/mac/ScrollbarThemeMac.h:
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::backButtonRect):
- (WebCore::ScrollbarThemeMac::forwardButtonRect):
- (WebCore::ScrollbarThemeMac::paintButton):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarThemeSafari::backButtonRect):
- (WebCore::ScrollbarThemeSafari::forwardButtonRect):
- (WebCore::ScrollbarThemeSafari::paintButton):
- * platform/win/ScrollbarThemeSafari.h:
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::backButtonRect):
- (WebCore::ScrollbarThemeWin::forwardButtonRect):
- (WebCore::ScrollbarThemeWin::paintButton):
- * platform/win/ScrollbarThemeWin.h:
-
-2008-09-19 Matt Lilek <webkit@mattlilek.com>
-
- Reviewed by Tim Hatcher.
-
- Bug 17772: Inspector should support point-and-click to select a node to inspect
- https://bugs.webkit.org/show_bug.cgi?id=17772
- <rdar://problem/5792395>
-
- * English.lproj/localizedStrings.js:
- * page/Chrome.cpp:
- (WebCore::Chrome::mouseDidMoveOverElement):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMousePressEvent):
- * page/InspectorController.cpp:
- (WebCore::toggleNodeSearch):
- (WebCore::searchingForNode):
- (WebCore::InspectorController::InspectorController):
- (WebCore::InspectorController::toggleSearchForNodeInPage):
- (WebCore::InspectorController::mouseDidMoveOverElement):
- (WebCore::InspectorController::handleMousePressOnNode):
- (WebCore::InspectorController::windowScriptObjectAvailable):
- * page/InspectorController.h:
- (WebCore::InspectorController::searchingForNodeInPage):
- * page/inspector/ElementsPanel.js:
- * page/inspector/Images/nodeSearchButtons.png: Added.
- * page/inspector/inspector.css:
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Add new scrollbar parts to be able to represent back and forward buttons
- at either end of the scrollbar. The current scrollbar still just draws
- a single button at either end, but the parts now exist.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollTypes.h:
- (WebCore::):
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::autoscrollTimerFired):
- (WebCore::Scrollbar::pressedPartScrollDirection):
- (WebCore::Scrollbar::pressedPartScrollGranularity):
- (WebCore::Scrollbar::handleMouseMoveEvent):
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::buttonsPlacement):
- (WebCore::ScrollbarTheme::invalidateParts):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::hitTest):
- (WebCore::ScrollbarThemeComposite::invalidatePart):
- * platform/ScrollbarThemeComposite.h:
-
-2008-09-19 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6231308> crash in AutoTableLayout
-
- The code assumes later on that a TableSection's grid's row vector
- will never be empty. So make 1 the minimum number of columns.
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::ensureRows):
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Add a new ScrollbarButtonsPlacement type for specifying where
- the button arrows are in a scrollbar.
-
- Read in the placement settings for Mac. Nothing is done with the
- setting yet.
-
- Add a new buttonsPlacement() method to ScrollbarTheme composite
- so that the arrow settings can be obtained.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollTypes.h:
- (WebCore::):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::buttonsPlacement):
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::updateArrowPlacement):
- (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
-
-2008-09-19 Steve Falkenburg <sfalken@apple.com>
-
- Roll out r36626. It is causing variance in SunSpider numbers on XP.
-
- Rubber stamped by Mark Rowe.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::isRunningOnVistaOrLater):
- (WebCore::setSharedTimerFireTime):
-
-2008-09-19 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- https://bugs.webkit.org/show_bug.cgi?id=20942
- Bug 20942: Repeated messages in resources don't collapse
- - Now repeated messages in a resource's view are collapsed and a message
- says how many were repeated.
-
- * English.lproj/localizedStrings.js:
- * manual-tests/inspector/multiple-console-messages.html:
- * page/inspector/Console.js: Send all the messages to the resource's
- view before possibly returning early if the message is a repeat.
- * page/inspector/SourceFrame.js: Add the text about the message being
- repeated, if it is, and increment it when necessary.
-
-2008-09-19 Chris Fleizach <cfleizach@apple.com>
-
- Removed unnecessary #if
-
- * page/mac/AccessibilityObjectWrapper.mm:
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Read in prefs for the scroll delay repeat values for buttons. Also
- honor the option-click pref for jumping to the thumb when clicking in
- the track.
-
- Reviewed by Sam Weinig
-
- * platform/mac/ScrollbarThemeMac.h:
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
- (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
- (WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
- (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
- Set the initial button repeat delay to 0.5 for Mac.
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/mac/ScrollbarThemeMac.cpp: Removed.
- * platform/mac/ScrollbarThemeMac.h:
- (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
- * platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
-
-2008-09-19 Darin Adler <darin@apple.com>
-
- Reviewed by Sam Weinig.
-
- - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- + Fixed all cases where we were using a shared structure for multiple
- C++ classes in WebCore. This still has to be done in JavaScriptCore.
-
- + Got rid of cacheGlobalObject.
-
- + Improved use of PassRefPtr in bindings code.
-
- + Removed a couple cases where we were potentially allocating prototypes
- inside a JSObject's construction process -- this can lead to trouble if
- we do a garbage collection while an object is only partly constructed.
-
- * bindings/js/JSAudioConstructor.cpp:
- (WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
- so we don't implicitly share the structure with other objects that use the object
- prototype.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
- don't need cacheGlobalObject any more.
- (WebCore::cacheDOMConstructor): Ditto.
-
- * bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
- Added functions and a function template for getting cached DOM constructors.
- Removed cacheGlobalObject function template.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
- we're taking ownership.
- * bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
- we're taking ownership. Added constructor map.
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::mark): Mark the constructors in the map.
-
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
- we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
- this is now done in only that one place.
- (WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
- the passed-in DOMWindow. Code was moved here and changed to allocate unique
- structures for both the window prototype and the window.
- * bindings/js/JSDOMWindowShell.h: Ditto.
-
- * bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
- have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
- private/friend in JSEventTargetBase. Removed comments referring to defunct
- macros. Changed JSEventTargetBasePrototype to get the prototype with the new
- rather than its own copy of cacheGlobalObject (I missed this during pass 1).
- Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
-
- * bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
- for caching structures and prototypes.
- (WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
- (WebCore::JSEventTargetNode::createPrototype): Added.
- * bindings/js/JSEventTargetNode.h: Updated for above changes.
-
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::getNamedItems): Pass ExecState instead of prototype.
- * bindings/js/JSHTMLFormElementCustom.cpp:
- (WebCore::JSHTMLFormElement::nameGetter): Ditto.
- * bindings/js/JSHTMLInputElementBase.cpp:
- (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
- * bindings/js/JSHTMLInputElementBase.h: Ditto.
- * bindings/js/JSHTMLOptionElementConstructor.cpp:
- (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
- Create a unique structure instead of sharing.
- * bindings/js/JSImageConstructor.cpp:
- (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
-
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
- a prototype rather than a structure. Made the use of inheritorID() here
- explicit.
- * bindings/js/JSInspectedObjectWrapper.h: Ditto.
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
- * bindings/js/JSInspectorCallbackWrapper.h: Ditto.
-
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
- take an ExecState argument instead of a prototype. Create a unique
- StructureID instead of sharing.
- * bindings/js/JSNamedNodesCollection.h: Ditto.
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
- constructor that takes a prototype instead of a structure.
- * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
-
- * bindings/js/JSRGBColor.cpp:
- (WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
- prototype; create a unique structure.
- (WebCore::getJSRGBColor): Ditto.
- * bindings/js/JSRGBColor.h: Ditto.
-
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- (WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
- of explicit coding the idiom for making a new object.
-
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- Create a unique structure instead of the shared one.
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- Ditto.
-
* bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::clearWindowShell): Let the window shell's
- setWindow function create the JSDOMWindow instead of doing it here.
-
- * bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
- the structure and the wrapped object when creating wrappers.
- Simplified some of the special cases for DOMWindow so they are
- different only in ways the need to be. Eliminated the
- JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
- functions. Moved responsibility for creating the structure and
- parent prototype out of the prototype constructor into the
- createPrototype function. Removed the unused "DoNotCache" flag for
- objects other than DOMWindow. Use getDOMConstructor instead of
- cacheGlobalObject for constructors. Make each constructor have
- a unique structure ID.
-
- * bridge/objc/objc_runtime.h: Added createPrototype and changed the
- name of the info member to s_info so we can use the standard DOM
- binding macros to handl the prototype.
- * bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
- (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
- Create a unique structure using getDOMStructure.
-
- * bridge/runtime_array.cpp: Fixed namespacing a bit.
- (JSC::RuntimeArray::RuntimeArray): Create a unique structure using
- getDOMStructure.
- * bridge/runtime_array.h: Added createPrototype so getDOMStructure
- will work.
-
- * bridge/runtime_object.cpp:
- (JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
- getDOMStructure.
- * bridge/runtime_object.h: Added createPrototype so getDOMStructure
- will work.
-
- * history/CachedPage.cpp:
- (WebCore::CachedPage::restore): Let the window shell's
- setWindow function create the JSDOMWindow instead of doing it here.
-
- * page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
-
-2008-09-19 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- This optimization was suggested by Daniel Fenwick
-
- - speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
-
- Specifying LTR paragraph directionality when measuring runs of RTL text
- resulted in typically two CTRuns being generated for every run instead
- of one, due to the leading space being reordered to the left.
-
- * platform/graphics/SimpleFontData.h: Removed the ltr parameter to
- getCFStringAttributes() and changed m_CFStringAttributes from an array
- to a single value.
- * platform/graphics/mac/CoreTextController.cpp:
- (WebCore::CoreTextController::CoreTextController): Added a
- mayUseNaturalWritingDirection parameter.
- (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
- to force the bidi embedding level whenever
- m_mayUseNaturalWritingDirectrion is false. Since this is now a common
- case, made the typesetter options dictionaries static.
- * platform/graphics/mac/CoreTextController.h:
- * platform/graphics/mac/FontMacCoreText.cpp:
- (WebCore::Font::selectionRectForComplexText): Renamed a local variable.
- (WebCore::Font::floatWidthForComplexText): Changed to allow the
- CoreTextController to not set the writing direction.
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
- parameter and the paragraph style attribute.
-
-2008-09-19 David Hyatt <hyatt@apple.com>
-
- Reviewed by Sam Weinig
-
- https://bugs.webkit.org/show_bug.cgi?id=20941
-
- Incorrect height calculation for replaced element inside nested
- positioned elements (where the inner has a percentage height and
- the outer implicitly has a fixed height because of explicit top/bottom
- values).
-
- Added fast/block/positioning/replaced-inside-top-bottom.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::availableHeightUsing):
-
-2008-09-19 Chris Fleizach <cfleizach@apple.com>
-
- Fix Tiger bustage
-
- * page/mac/AccessibilityObjectWrapper.mm:
-
-2008-09-18 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6211041> Expose legend tag in accessibility
-
- Exposes the legend tag as the titleUIElement of a fieldset
-
- Test: accessibility/legend.html
-
- * page/AccessibilityObject.h:
- (WebCore::AccessibilityObject::isFieldset):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::isFieldset):
- (WebCore::AccessibilityRenderObject::titleUIElement):
- * page/AccessibilityRenderObject.h:
- * rendering/RenderFieldset.h:
-
-2008-09-19 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
-
- Implement a few AX API methods that will be called by AppKit, which will
- speed up access to accessibility objects
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
- (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
-
-2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [qtwebkit] Set the m_should* flags to their proper value on entry
- With plugins it was possible that we finished a job twice. This was
- some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
- setting the flag to (m_loadMode == LoadDeferred) they will always have
- the right value and we will not send responses twice.
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
-
-2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon Hausmann.
-
- [qtwebkit] Pass test 70 of acid3. Handle text decoding errors
- Handle text decoding errors before instructing the parser to parse. We
- have converted the text to QString and all encoding errors are gone and
- the parser will not be able to detect them. So handle them before parsing.
-
- * dom/XMLTokenizerQt.cpp:
- (WebCore::XMLTokenizer::doWrite):
-
-2008-09-18 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
- make each distinct C++ class get a distinct JSC::Structure
-
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
- instead of DOMExceptionTranslator.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::getCachedDOMObjectWrapper): Updated function name.
- (WebCore::cacheDOMObjectWrapper): Ditto.
- (WebCore::forgetDOMObject): Ditto.
- (WebCore::getCachedDOMNodeWrapper): Ditto.
- (WebCore::forgetDOMNode): Ditto.
- (WebCore::cacheDOMNodeWrapper): Ditto.
- (WebCore::forgetAllDOMNodesForDocument): Ditto.
- (WebCore::markDOMNodesForDocument): Ditto.
- (WebCore::updateDOMNodeDocument): Ditto.
- (WebCore::getCachedDOMStructure): Added.
- (WebCore::createDOMStructure): Ditto.
-
- * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
- class and replace the static member functions with non-member
- functions. Added many other functions for getting at structures,
- prototypes, wrappers, and creating them. Also moved the
- cacheGlobalObject function here from JavaScriptCore; eventually
- I'll remove that once I get rid of the remaining callers. Also
- removed the DOMExceptionTranslator class.
-
- * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
- and put one of those maps in each window.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::markDOMObjectWrapper): Updated for function name change.
- (WebCore::JSDOMWindow::mark): Added code to mark all the structures
- in the structure map.
-
- * bindings/js/JSEventTargetNode.cpp:
- (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
- a structure instead of a prototype.
- * bindings/js/JSEventTargetNode.h: Ditto.
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
-
- * bindings/js/JSHTMLInputElementBase.cpp:
- (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
- use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
- structure instead of a prototype.
- * bindings/js/JSHTMLInputElementBase.h: Removed use of the
- JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
- to take a structure instead of a prototype. Created a dummy prototype
- class that causes the HTMLInputElement prototype to have the
- HTMLElement prototype.
-
- * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
- structures instead of prototypes. Changed the prototype self function
- to use the getDOMPrototype function -- later we can eliminate it and
- have callers invoke getDOMPrototype directly instead. Updated other
- functions that have name changes. Added code to generate the
- createPrototype member function. Changed use of cacheGlobalObject to
- get it from the WebCore namespace instead of the JSC namespace.
- Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
-
- * dom/Document.cpp:
- (WebCore::Document::~Document): Updated for name change and also
- removed unnecessary JSLock use -- there's no need to lock around this.
- * dom/Node.cpp:
- (WebCore::Node::setDocument): Ditto.
-
- * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
- instead of calling new directly.
-
- * bindings/js/JSCSSRuleCustom.cpp:
- (WebCore::toJS): Updated for function name changes and used the
- CREATE_DOM_OBJECT_WRAPPER macro.
- * bindings/js/JSCSSValueCustom.cpp:
- (WebCore::toJS): Ditto.
- * bindings/js/JSCanvasPixelArrayCustom.cpp:
- (WebCore::toJS): Ditto.
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::mark): Ditto.
- (WebCore::toJS): Ditto.
- * bindings/js/JSElementCustom.cpp:
- (WebCore::toJSNewlyCreated): Ditto.
- * bindings/js/JSEventCustom.cpp:
- (WebCore::toJS): Ditto.
- * bindings/js/JSEventTargetBase.cpp:
- (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
- of DOMExceptionTranslator.
- (WebCore::toJS): Updated for function name changes and used the
- CREATE_DOM_OBJECT_WRAPPER macro.
- * bindings/js/JSHTMLCollectionCustom.cpp:
- (WebCore::toJS): Ditto.
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::mark): Ditto.
- (WebCore::createWrapper): Ditto.
- (WebCore::toJS): Ditto.
- * bindings/js/JSSVGPathSegCustom.cpp:
- (WebCore::toJS): Ditto.
- * bindings/js/JSStyleSheetCustom.cpp:
- (WebCore::toJS): Ditto.
- (WebCore::JSStyleSheet::mark): Ditto.
- * bindings/js/JSTextCustom.cpp:
- (WebCore::toJSNewlyCreated): Ditto.
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- (WebCore::constructXMLHttpRequest): Ditto.
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::mark): Ditto.
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- (WebCore::constructXSLTProcessor): Ditto.
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::finishedWithEvent): Ditto.
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
- (WebCore::XMLHttpRequest::dropProtection): Ditto.
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- This patch gets a viewless scrollbar working on Mac. It is turned off
- by default. Hit testing works. For now the scrollbar just paints ugly
- debug rects in the place of the buttons, track and thumb. It does match
- Aqua metrics though.
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::paint):
- (WebCore::ScrollbarThemeComposite::trackPosition):
- * platform/ScrollbarThemeComposite.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::addChild):
- * platform/mac/ScrollbarThemeMac.cpp:
- (WebCore::):
- (WebCore::ScrollbarThemeMac::hasButtons):
- (WebCore::ScrollbarThemeMac::hasThumb):
- (WebCore::buttonRepaintRect):
- (WebCore::ScrollbarThemeMac::backButtonRect):
- (WebCore::ScrollbarThemeMac::forwardButtonRect):
- (WebCore::trackRepaintRect):
- (WebCore::ScrollbarThemeMac::trackRect):
- (WebCore::ScrollbarThemeMac::minimumThumbLength):
- (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
- (WebCore::ScrollbarThemeMac::paintTrack):
- (WebCore::ScrollbarThemeMac::paintButton):
- (WebCore::ScrollbarThemeMac::paintThumb):
- * platform/mac/ScrollbarThemeMac.h:
- (WebCore::ScrollbarThemeMac::supportsControlTints):
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::ScrollbarThemeQt::trackPosition):
-
-2008-09-18 Collin Jackson <collinj@webkit.org>
-
- Build fix; added missing header file to GNUmakefile.am
-
- * GNUmakefile.am:
-
-2008-09-18 Sam Weinig <sam@webkit.org>
-
- Reviewed by David "the Hair" Hyatt.
-
- Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/DataRef.h: Removed.
- * rendering/SVGRenderStyle.cpp: Removed.
- * rendering/SVGRenderStyle.h: Removed.
- * rendering/SVGRenderStyleDefs.cpp: Removed.
- * rendering/SVGRenderStyleDefs.h: Removed.
- * rendering/style/DataRef.h: Copied from rendering/DataRef.h.
- * rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
- * rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
- * rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
- * rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
-
-2008-09-18 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Add a means of clearing a FrameTree's name.
-
- * WebCore.base.exp:
- * page/FrameTree.cpp:
- (WebCore::FrameTree::clearName):
- * page/FrameTree.h:
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Eliminate addToSuperview from Widget, since it was only called
- by ScrollViewMac's addChild method. Just shift the original body
- of addToSuperView into addChild.
-
- Reviewed by Sam Weinig
-
- * platform/Widget.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::addChild):
- * platform/mac/WidgetMac.mm:
-
-2008-09-18 Collin Jackson <collinj@webkit.org>
-
- Reviewed by Antti Koivisto and Mark Rowe.
-
- Test: http/tests/misc/dns-prefetch-control.html
-
- https://bugs.webkit.org/show_bug.cgi?id=20690
-
- Invoke WebCore::prefetchDNS() on host names that appear in
- in the href of hyperlinks and <link rel="dns-prefetch">. This
- can be used to implement DNS prefetching.
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::processHttpEquiv):
- (WebCore::Document::setSecurityOrigin):
- (WebCore::Document::initDNSPrefetch):
- (WebCore::Document::parseDNSPrefetchControlHeader):
- * dom/Document.h:
- (WebCore::Document::isDNSPrefetchEnabled):
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::parseMappedAttribute):
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::HTMLLinkElement):
- (WebCore::HTMLLinkElement::parseMappedAttribute):
- (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- (WebCore::HTMLLinkElement::process):
- * html/HTMLLinkElement.h:
- * html/PreloadScanner.cpp:
- (WebCore::PreloadScanner::processAttribute):
+ (WebCore::ScriptController::ScriptController):
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/ScriptController.h:
+ (WebCore::ScriptController::xssAuditor):
+ * bindings/js/ScriptEventListener.cpp:
+ (WebCore::createAttributeEventListener):
+ * dom/Tokenizer.h:
+ (WebCore::Tokenizer::xssAuditor):
+ (WebCore::Tokenizer::setXSSAuditor):
+ (WebCore::Tokenizer::Tokenizer):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::scriptHandler):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
- * platform/gtk/TemporaryLinkStubs.cpp:
- (WebCore::prefetchDNS):
- * platform/network/DNS.h: Added.
- * platform/network/cf/DNSCFNet.cpp: Added.
- (WebCore::prefetchDNS):
- * platform/qt/TemporaryLinkStubs.cpp:
- (WebCore::prefetchDNS):
- * platform/wx/TemporaryLinkStubs.cpp:
- (WebCore::prefetchDNS):
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Eliminate the convertToScreenCoordinate method on Widget, since
- ScrollView has redundant methods that already do the same thing.
-
- Reviewed by Sam Weinig
-
- * editing/mac/SelectionControllerMac.mm:
- (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- * platform/Widget.h:
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::containingWindow):
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Move to only one constructor for Widgets. Rename data to m_data and make
- it have an #ifdef only for platforms that have platform-specific data (Mac
- and Gtk).
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * platform/Widget.cpp:
- (WebCore::Widget::init):
- * platform/Widget.h:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::cursor):
- (WebCore::Widget::setCursor):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::addToSuperview):
- (WebCore::Widget::removeFromSuperview):
- (WebCore::Widget::beforeMouseDown):
- (WebCore::Widget::afterMouseDown):
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::Widget):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::Widget):
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
- was no reason for it to be on Widget. This change eliminates Qt ifdefs
- from Widget.
-
- Reviewed by Sam Weinig
-
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- (WebCore::WidgetPrivate::~WidgetPrivate):
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView):
- * plugins/PluginView.h:
- (WebCore::PluginView::isNPAPIPlugin):
- (WebCore::PluginView::setIsNPAPIPlugin):
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Make geometryChanged() cross-platform on Widget. GTK and WIN platform
- ifdefs are now gone from Widget!
-
- Reviewed by Sam Weinig
-
- * platform/Widget.h:
- (WebCore::Widget::geometryChanged):
- * platform/gtk/WidgetGtk.cpp:
- * platform/qt/WidgetQt.cpp:
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Consolidate convertTo/FromContainingWindow methods so that all platforms
- but Mac share the same code.
-
- Move convertSelfToChild and convertChildToSelf to ScrollView, since
- Widget should know nothing about children. Make the methods cross-platform
- on ScrollView.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollView.h:
- (WebCore::ScrollView::convertChildToSelf):
- (WebCore::ScrollView::convertSelfToChild):
- * platform/Widget.cpp:
- (WebCore::Widget::convertToContainingWindow):
- (WebCore::Widget::convertFromContainingWindow):
- * platform/Widget.h:
- (WebCore::Widget::geometryChanged):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::isScrollViewScrollbar):
- * platform/gtk/WidgetGtk.cpp:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::isScrollViewScrollbar):
- * platform/mac/WidgetMac.mm:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::isScrollViewScrollbar):
- * platform/qt/WidgetQt.cpp:
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::isScrollViewScrollbar):
- * platform/win/WidgetWin.cpp:
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Make the conversion methods that go to and from some containingWindow
- cross-platform. Implement them on Mac.
-
- Reviewed by Sam Weinig
-
- * platform/Widget.h:
- (WebCore::Widget::setContainingWindow):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertFromContainingWindow):
- (WebCore::Widget::convertToContainingWindow):
-
-2008-09-18 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by David "Yeah-yeah" Hyatt.
-
- Cleanup RenderStyle.
-
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/style/CounterContent.h:
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
-
-2008-09-18 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig
-
- Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
- Now TransformOperations and AnimationList no longer
- inherit from Vector<> but rather have API to access.
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::computedTransform):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::createTransformOperations):
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- (WebCore::CompositeAnimation::animate):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::validateTransformFunctionList):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::validateTransformFunctionList):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateReflectionStyle):
- * rendering/style/AnimationList.cpp:
- (WebCore::AnimationList::operator==):
- * rendering/style/AnimationList.h:
- (WebCore::AnimationList::operator!=):
- (WebCore::AnimationList::size):
- (WebCore::AnimationList::isEmpty):
- (WebCore::AnimationList::resize):
- (WebCore::AnimationList::remove):
- (WebCore::AnimationList::append):
- (WebCore::AnimationList::animation):
- * rendering/style/RenderStyle.cpp:
- (WebCore::StyleRareNonInheritedData::updateKeyframes):
- (WebCore::RenderStyle::applyTransform):
- (WebCore::RenderStyle::adjustAnimations):
- (WebCore::RenderStyle::adjustTransitions):
- (WebCore::RenderStyle::transitionForProperty):
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::hasTransform):
- * rendering/style/TransformOperations.cpp:
- (WebCore::TransformOperations::TransformOperations):
- (WebCore::TransformOperations::operator==):
- * rendering/style/TransformOperations.h:
- (WebCore::TransformOperations::apply):
- (WebCore::TransformOperations::operations):
-
-2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Build fix.
-
- [qt] Build fixes after the Widget/ScrollView cleanup
- topLevel() is now root()
-
-
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
- (WebCore::ScrollView::addChild):
- (WebCore::ScrollView::removeChild):
-
-2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=20437
-
- XMLTokenizer.cpp used to contain two different implementations. One was using
- libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
- separating the two implementations from each other.
- Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
- was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
- XMLTokenizerLibxml2.cpp. There should be no functional changes.
-
- Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
- to work.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * dom/XMLTokenizer.cpp:
- (WebCore::isScriptElement):
- (WebCore::castToScriptElement):
- (WebCore::XMLTokenizer::setCurrentNode):
- (WebCore::XMLTokenizer::write):
- (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
- (WebCore::XMLTokenizer::enterText):
- (WebCore::toString):
- (WebCore::XMLTokenizer::exitText):
- (WebCore::XMLTokenizer::end):
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * dom/XMLTokenizer.h:
- (WebCore::XMLTokenizer::wellFormed):
- * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
- (WebCore::createMemoryParser):
- (WebCore::XMLTokenizer::XMLTokenizer):
- (WebCore::XMLTokenizer::~XMLTokenizer):
- (WebCore::XMLTokenizer::doWrite):
- (WebCore::ignorableWhitespaceHandler):
- (WebCore::XMLTokenizer::initializeParserContext):
- (WebCore::XMLTokenizer::doEnd):
- (WebCore::XMLTokenizer::lineNumber):
- (WebCore::XMLTokenizer::columnNumber):
- (WebCore::XMLTokenizer::stopParsing):
- (WebCore::XMLTokenizer::resumeParsing):
- (WebCore::parseXMLDocumentFragment):
- (WebCore::attributesStartElementNsHandler):
- (WebCore::parseAttributes):
- * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
- (WebCore::EntityResolver::resolveUndeclaredEntity):
- (WebCore::XMLTokenizer::XMLTokenizer):
- (WebCore::XMLTokenizer::~XMLTokenizer):
- (WebCore::XMLTokenizer::doWrite):
- (WebCore::XMLTokenizer::initializeParserContext):
- (WebCore::XMLTokenizer::doEnd):
- (WebCore::XMLTokenizer::lineNumber):
- (WebCore::XMLTokenizer::columnNumber):
- (WebCore::XMLTokenizer::stopParsing):
- (WebCore::XMLTokenizer::resumeParsing):
- (WebCore::parseXMLDocumentFragment):
- (WebCore::attributesStartElementNsHandler):
- (WebCore::parseAttributes):
- (WebCore::):
-
-2008-09-18 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Geoff Garen.
-
- Build fix for non-Mac builds.
-
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
-
-2008-09-18 Peter Kasting <pkasting@google.com>
-
- Reviewed by hyatt. Landed by eseidel.
-
- https://bugs.webkit.org/show_bug.cgi?id=20745
- Animated GIFs do not animate properly with (at least) CG.
-
- * WebCore\platform\graphics\BitmapImage.cpp:
- * WebCore\platform\graphics\BitmapImage.h:
- * WebCore\platform\graphics\cairo\ImageCairo.cpp:
- * WebCore\platform\graphics\cg\ImageCG.cpp:
- * WebCore\platform\graphics\qt\ImageQt.cpp:
- * WebCore\platform\graphics\wx\ImageWx.cpp:
-
-2008-09-18 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin
-
- <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
- role specifies otherwise
-
- If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
-
- Test: accessibility/table-with-aria-role.html
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- (WebCore::AccessibilityTable::addChildren):
- (WebCore::AccessibilityTable::roleValue):
- (WebCore::AccessibilityTable::accessibilityIsIgnored):
- (WebCore::AccessibilityTable::title):
- * page/AccessibilityTableCell.cpp:
- (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
- (WebCore::AccessibilityTableCell::isTableCell):
- (WebCore::AccessibilityTableCell::roleValue):
- * page/AccessibilityTableCell.h:
- * page/AccessibilityTableRow.cpp:
- (WebCore::AccessibilityTableRow::roleValue):
- (WebCore::AccessibilityTableRow::isTableRow):
- (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
- * page/AccessibilityTableRow.h:
-
-2008-09-18 Steve Falkenburg <sfalken@apple.com>
-
- Use higher-resolution timers on all variants of Windows.
-
- Reviewed by Darin Adler.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::setSharedTimerFireTime):
-
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Make containingWindow() and setContainingWindow() cross-platform.
- Add a root() function cross-platform so Qt doesn't have to
- define its own.
-
- Reviewed by Darin Adler
-
- * platform/Widget.cpp:
- (WebCore::Widget::root):
- * platform/Widget.h:
- (WebCore::Widget::setContainingWindow):
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::containingWindow):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::addChild):
- (WebCore::ScrollView::removeChild):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::containingWindow):
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::invalidateRect):
- (WebCore::Widget::containingWindow):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::containingWindow):
-
-2008-09-18 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
- parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
- dashboard-region=
- and corresponding: <rdar://problem/6174100>
-
- This patch makes CSSParserValue::createCSSValue handle unknown
- identifiers.
-
- * css/CSSParserValues.cpp:
- (WebCore::CSSParserValue::createCSSValue): If we have an identifier
- with no id (an unknown identifier) create a CSSPrimitiveValue of
- type CSS_PARSER_IDENTIFIER
- * css/CSSPrimitiveValue.cpp:
- (WebCore::CSSPrimitiveValue::cssText):
- (WebCore::CSSPrimitiveValue::parserValue):
- * css/CSSPrimitiveValue.h:
- (WebCore::CSSPrimitiveValue::):
-
-2008-09-18 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by David "I'd prefer not" Hyatt.
-
- More the remaining class out of RenderStyle.h/cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::CursorData::CursorData):
- (WebCore::CursorData::operator==):
- (WebCore::CursorData::operator!=):
- * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::CursorList::operator[]):
- (WebCore::CursorList::CursorList):
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::deref):
- (WebCore::RenderStyle::hasOneRef):
- (WebCore::RenderStyle::InheritedFlags::operator!=):
- (WebCore::RenderStyle::NonInheritedFlags::operator!=):
- (WebCore::RenderStyle::hasBackground):
- (WebCore::RenderStyle::outlineWidth):
- (WebCore::RenderStyle::autoWrap):
- (WebCore::RenderStyle::preserveNewline):
- (WebCore::RenderStyle::collapseWhiteSpace):
- (WebCore::RenderStyle::isCollapsibleWhiteSpace):
- (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
- (WebCore::RenderStyle::breakWords):
- (WebCore::RenderStyle::outlineOffset):
- (WebCore::RenderStyle::setLeft):
- (WebCore::RenderStyle::setRight):
- (WebCore::RenderStyle::setTop):
- (WebCore::RenderStyle::setBottom):
- (WebCore::RenderStyle::setDashboardRegion):
- (WebCore::RenderStyle::setBackgroundColor):
- (WebCore::RenderStyle::setBorderImage):
- (WebCore::RenderStyle::setBorderRadius):
- (WebCore::RenderStyle::setFontDescription):
- (WebCore::RenderStyle::adjustBackgroundLayers):
- (WebCore::RenderStyle::adjustMaskLayers):
- (WebCore::RenderStyle::deleteBindingURIs):
- (WebCore::RenderStyle::inheritBindingURIs):
- (WebCore::RenderStyle::isDisplayReplacedType):
- (WebCore::RenderStyle::isDisplayInlineType):
- (WebCore::RenderStyle::isOriginalDisplayInlineType):
- * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleInheritedData::operator!=):
- * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleRareInheritedData::operator!=):
- * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
- * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Move the concept of suppression invalidation on Widgets to Scrollbar
- instead. Since this is only used by Scrollbars, there is no need for
- it to be on Widget.
-
- Reviewed by Sam Weinig
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::invalidateRect):
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::suppressInvalidation):
- (WebCore::Scrollbar::setSuppressInvalidation):
- * platform/Widget.h:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::invalidateRect):
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- (WebCore::Widget::invalidateRect):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::invalidateRect):
-
-2008-09-18 David Hyatt <hyatt@apple.com>
-
- Make invalidate() on Widget non-virtual and make it just call
- invalidateRect() on the boundsGeometry() of the Widget.
-
- Reviewed by Dan Bernstein
-
- * platform/Widget.h:
- (WebCore::Widget::boundsGeometry):
- (WebCore::Widget::invalidate):
- * platform/gtk/WidgetGtk.cpp:
- * platform/mac/WidgetMac.mm:
- * platform/qt/WidgetQt.cpp:
- * platform/win/WidgetWin.cpp:
- * platform/wx/WidgetWx.cpp:
-
-2008-09-18 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped in exile by David Hyatt.
-
- Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
- KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
- RenderStyle.h/cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * css/CSSStyleSelector.cpp:
- * css/CSSStyleSelector.h:
- * page/animation/CompositeAnimation.cpp:
- * page/animation/KeyframeAnimation.cpp:
- * page/animation/KeyframeAnimation.h:
- * rendering/RenderCounter.h:
- * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
- (WebCore::Animation::~Animation):
- (WebCore::Animation::animationsMatch):
- (WebCore::Animation::keyframeList):
- (WebCore::Animation::setAnimationKeyframe):
- * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
- * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
- * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::BindingURI::operator!=):
- * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::ContentData::ContentData):
- (WebCore::ContentData::~ContentData):
- * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::CounterContent::CounterContent):
- * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::CounterDirectives::CounterDirectives):
- * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
- (WebCore::KeyframeList::insert):
- * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::KeyframeValue::KeyframeValue):
- (WebCore::KeyframeList::create):
- (WebCore::KeyframeList::KeyframeList):
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
- * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::ShadowData::ShadowData):
- (WebCore::ShadowData::~ShadowData):
- (WebCore::ShadowData::operator!=):
- * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleFlexibleBoxData::operator!=):
- * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::TimingFunction::TimingFunction):
- (WebCore::TimingFunction::operator==):
-
-2008-09-18 Adele Peterson <adele@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix RenderStyle leaks.
-
- * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
-
-2008-09-18 Kevin McCullough <kmccullough@apple.com>
-
- Accidentally checked in code.
-
- * html/HTMLElementFactory.cpp:
- (WebCore::frameConstructor):
- (WebCore::iframeConstructor):
-
-2008-09-18 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- <rdar://problem/5722310> gracefully handle too many console messages
- (20904)
- - Keep track of the most previous message and then compare it to the
- subsequent messages as they come in. If there are multiple of the same
- message create a count that indicates the current number.
-
- * manual-tests/inspector/multiple-console-messages.html: Added.
- * page/inspector/Console.js:
- * page/inspector/inspector.css:
-
-2008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
-
- Reviewed by Alp Toker
-
- https://bugs.webkit.org/show_bug.cgi?id=20830
- [GTK] Don't use deprecated pango API
-
- Replace deprecated pango functions with non-deprecated ones for newer
- versions of pango
-
- * platform/graphics/gtk/FontGtk.cpp:
- (WebCore::getDefaultPangoLayout):
- * platform/graphics/gtk/FontPlatformDataPango.cpp:
- (WebCore::FontPlatformData::FontPlatformData):
-
-2008-09-18 Alp Toker <alp@nuanti.com>
-
- Build fix for r36587. Add new sources (and sort the lists).
-
- * GNUmakefile.am:
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Fix Windows build.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- Switch back to having frameGeometry be virtual in order to keep Mac
- the way it used to be.
-
- Reviewed by Sam Weinig
-
- * WebCore.base.exp:
- * platform/Widget.cpp:
- (WebCore::Widget::setParent):
- * platform/Widget.h:
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFrameGeometry):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFrameGeometry):
- * platform/qt/WidgetQt.cpp:
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFrameGeometry):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFrameGeometry):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFrameGeometry):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::setFrameGeometry):
- (WebCore::PluginView::geometryChanged):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePluginWidget):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::updatePluginWidget):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix assertion in DOMWindow::adjustWindowRect where we were passing
- in garbage values and were getting lucky that they were a not Nan.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::windowProtoFuncOpen):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Fix gtk build.
-
- * rendering/style/MatrixTransformOperation.cpp:
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped with love by David Hyatt.
-
- Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
- ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
- TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * css/CSSStyleSelector.cpp:
- * page/animation/AnimationBase.cpp:
- (WebCore::solveEpsilon):
- * rendering/RenderLayer.cpp:
- * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::MatrixTransformOperation::MatrixTransformOperation):
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
- * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::RotateTransformOperation::RotateTransformOperation):
- * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::ScaleTransformOperation::ScaleTransformOperation):
- * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::SkewTransformOperation::SkewTransformOperation):
- * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleTransformData::operator!=):
- * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::TransformOperation::):
- * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
- (WebCore::TransformOperations::TransformOperations):
- * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::TransformOperations::operator!=):
- * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::TranslateTransformOperation::TranslateTransformOperation):
-
-2008-09-17 Mark Rowe <mrowe@apple.com>
-
- Build fix.
-
- * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- (1) Inline a bunch of methods for accessing frame geometry.
- (2) Make sure frameGeometry() works even when you have no underlying
- native widget.
- (3) Cache a frame geometry rect cross-platform (even for widgets that
- have underlying native widgets.
- (4) PluginView's updateWindow call is now a virtual function on Widget.
-
- Reviewed by Sam Weinig
-
- * ChangeLog:
- * WebCore.base.exp:
- * platform/Widget.cpp:
- (WebCore::Widget::setFrameGeometry):
- * platform/Widget.h:
- (WebCore::Widget::x):
- (WebCore::Widget::y):
- (WebCore::Widget::width):
- (WebCore::Widget::height):
- (WebCore::Widget::size):
- (WebCore::Widget::pos):
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::resize):
- (WebCore::Widget::move):
- (WebCore::Widget::isFrameView):
- (WebCore::Widget::windowClipRect):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::~Widget):
- (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::setFrameGeometry):
- (WebCore::PluginView::geometryChanged):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- * plugins/wx/PluginViewWx.cpp:
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Reviewed by David "Waterman" Hyatt.
-
- Fix a leak of NSViews in WidgetMac.mm.
-
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::~Widget):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by David Waterman Hyatt.
-
- Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
- StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::FillLayer::operator!=):
- (WebCore::FillLayer::hasImage):
- (WebCore::FillLayer::hasFixedImage):
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
- (WebCore::StyleBackgroundData::StyleBackgroundData):
- * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleBackgroundData::~StyleBackgroundData):
- (WebCore::StyleBackgroundData::operator!=):
- * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleBoxData::operator!=):
- * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleDashboardRegion::operator!=):
- * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleMarqueeData::operator!=):
- * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleMultiColData::operator!=):
- (WebCore::StyleMultiColData::ruleWidth):
- * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleVisualData::operator==):
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- Remove WidgetClient from Widget.
-
- Reviewed by Sam Weinig
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/Widget.h:
- (WebCore::Widget::setClient):
- (WebCore::Widget::client):
- * platform/WidgetClient.h: Removed.
- * platform/gtk/WidgetGtk.cpp:
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::Widget):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::Widget):
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- Remove isEnabled/setEnabled from Widget. The concept of being enabled now
- only applies to Scrollbars so the method has been moved there and made
- cross-platform. Scrollbar subclasses that have a corresponding native
- widget can subclass setEnabled to change the enabled state of the native
- widget.
-
- Reviewed by Sam Weinig & Darin Adler
-
- * WebCore.base.exp:
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- * platform/Scrollbar.h:
- (WebCore::Scrollbar::enabled):
- (WebCore::Scrollbar::setEnabled):
- * platform/Widget.h:
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::setEnabled):
- * platform/gtk/ScrollbarGtk.h:
- * platform/gtk/WidgetGtk.cpp:
- * platform/mac/ScrollbarMac.h:
- * platform/mac/ScrollbarMac.mm:
- (WebCore::ScrollbarMac::scrollbarHit):
- (WebCore::ScrollbarMac::setEnabled):
- * platform/mac/WidgetMac.mm:
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- * platform/wx/WidgetWx.cpp:
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by David Hyatt.
-
- Split all RenderStyle enums into their own file.
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * rendering/style/BorderValue.h:
- * rendering/style/CollapsedBorderValue.h:
- * rendering/style/RenderStyle.h:
- * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::):
- * rendering/style/StyleCachedImage.h:
- * rendering/style/StyleGeneratedImage.h:
- * rendering/style/StyleImage.h:
-
-2008-09-17 Steve Falkenburg <sfalken@apple.com>
-
- Add back isFrameView check to fix failed assertion during scroll bar teardown.
-
- Reviewed by Dave Hyatt.
-
- * platform/Scrollbar.cpp:
- (WebCore::Scrollbar::setParent):
-
-2008-09-17 Brady Eidson <beidson@apple.com>
-
- Reviewed by Mac build fix
-
- * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
-
-2008-09-17 Steve Falkenburg <sfalken@apple.com>
-
- Fix build.
-
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::setParentVisible):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::init):
-
-2008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon.
-
- [QtWebKit] Implement error handling in TextCodecQt::decode
- Use the QTextCodec parsing state to set the sawError out variable. This
- is needed to pass Test 70 of acid3. The test case for this bug is
- fast/encoding/invalid-xml.html that is now partially passed. To pass
- it completely the Qt text codecs need to be adjusted to have proper
- error handling.
-
- * platform/text/qt/TextCodecQt.cpp:
- (WebCore::TextCodecQt::decode):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Rubber-stamped by Dave Hyatt.
-
- Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
- out of RenderStyle.h/cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::BorderData::hasBorderRadius):
- (WebCore::BorderData::borderLeftWidth):
- (WebCore::BorderData::borderRightWidth):
- (WebCore::BorderData::borderTopWidth):
- (WebCore::BorderData::borderBottomWidth):
- (WebCore::BorderData::operator!=):
- * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::):
- (WebCore::BorderValue::BorderValue):
- (WebCore::BorderValue::nonZero):
- (WebCore::BorderValue::isTransparent):
- (WebCore::BorderValue::isVisible):
- * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::):
- (WebCore::CollapsedBorderValue::CollapsedBorderValue):
- (WebCore::CollapsedBorderValue::operator==):
- * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::OutlineValue::OutlineValue):
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
- * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
- (WebCore::StyleSurroundData::operator!=):
-
-2008-09-17 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Darin Adler.
-
- This is a better fix for: Invalid CSS code crashes Safari
- https://bugs.webkit.org/show_bug.cgi?id=20512
-
- The spec indicates that the only valid input for a counter is a
- number or an identifier. So that is exactly what we allow.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseCounterContent):
-
-2008-09-17 Alp Toker <alp@nuanti.com>
-
- GTK+ build fix. Adapt to use PlatformWidget functions.
-
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollViewScrollbar::geometryChanged):
- (WebCore::ScrollView::addChild):
- (WebCore::ScrollView::removeChild):
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::ScrollbarGtk):
- (ScrollbarGtk::~ScrollbarGtk):
- (ScrollbarGtk::geometryChanged):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Reviewed by Adele Peterson.
-
- Patch for <rdar://problem/6133884>
- Calling window.resizeTo() on a subframe shouldn't change the window size
-
- Test: fast/dom/Window/window-resize-and-move-sub-frame.html
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::moveBy):
- (WebCore::DOMWindow::moveTo):
- (WebCore::DOMWindow::resizeBy):
- (WebCore::DOMWindow::resizeTo):
-
-2008-09-17 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Adam Roben.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
- code crashes Safari
- and corresponding: <rdar://problem/6173832>
-
- Reading through the spec, it seems like a function is not valid
- input for a counter. So this patch checks for that and bails in the
- case of invalid input.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseCounterContent):
-
-2008-09-17 Greg Bolsinga <bolsinga@apple.com>
-
- Reviewed by Antti Koivisto.
-
- Fix <rdar://problem/6227089>
- Crash in WebCore::Frame::setNeedsReapplyStyles()
-
- View is null checked elsewhere too.
-
- * page/Frame.cpp:
- (WebCore::Frame::setNeedsReapplyStyles):
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- Make the notion of having a native widget backing a Widget cross-platform.
- The PlatformWidget abstraction (which already existed) is used for this.
- Windows = HWND
- Qt = QWidget
- Mac = NSView
- wx = wxWindow
- Gtk = GtkWidget
-
- There are new cross-platform methods that replace all of the unique
- platform-specific methods.
- platformWidget()
- setPlatformWidget()
-
- For plugins, on every platform except Qt on Windows, the plugin's native
- widget is now stored in the Widget base class. Since Qt on Windows uses
- HWNDs for plugins instead of QWidget, it is the only platform to keep the
- m_window variable in PluginView.
+ (WebCore::FrameLoader::requestObject):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setXSSAuditorEnabled):
+ * page/Settings.h:
+ (WebCore::Settings::xssAuditorEnabled):
+ * page/XSSAuditor.cpp: Added.
+ (WebCore::isControlCharacter):
+ (WebCore::XSSAuditor::XSSAuditor):
+ (WebCore::XSSAuditor::~XSSAuditor):
+ (WebCore::XSSAuditor::canEvaluate):
+ (WebCore::XSSAuditor::canCreateInlineEventListener):
+ (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
+ (WebCore::XSSAuditor::canLoadObject):
+ (WebCore::XSSAuditor::decodeURL):
+ (WebCore::XSSAuditor::findInRequest):
+ * page/XSSAuditor.h: Added.
+ (WebCore::XSSAuditor::isEnabled):
+ (WebCore::XSSAuditor::setXSSAuditorEnabled):
+
+2009-06-18 Dirk Schulze <krit@webkit.org>
- Reviewed by Sam Weinig
+ Reviewed by Oliver Hunt.
- * WebCore.base.exp:
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper attachmentView]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::passMouseDownEventToWidget):
- (WebCore::EventHandler::mouseDownViewIfStillGood):
- (WebCore::EventHandler::passWheelEventToWidget):
- (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- * platform/Widget.cpp:
- (WebCore::Widget::init):
- (WebCore::Widget::setParent):
- (WebCore::Widget::releasePlatformWidget):
- (WebCore::Widget::retainPlatformWidget):
- * platform/Widget.h:
- (WebCore::Widget::platformWidget):
- (WebCore::Widget::setPlatformWidget):
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::setFocus):
- (WebCore::gdkDrawable):
- (WebCore::Widget::setCursor):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- (WebCore::Widget::setEnabled):
- (WebCore::Widget::isEnabled):
- (WebCore::Widget::paint):
- * platform/mac/PlatformScreenMac.mm:
- (WebCore::screenRect):
- (WebCore::screenAvailableRect):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::scrollView):
- (WebCore::ScrollView::update):
- (WebCore::ScrollView::inWindow):
- * platform/mac/ScrollbarMac.mm:
- (WebCore::ScrollbarMac::ScrollbarMac):
- (WebCore::ScrollbarMac::~ScrollbarMac):
- (WebCore::ScrollbarMac::updateThumbPosition):
- (WebCore::ScrollbarMac::updateThumbProportion):
- (WebCore::ScrollbarMac::scrollbarHit):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::Widget):
- (WebCore::Widget::setEnabled):
- (WebCore::Widget::isEnabled):
- (WebCore::Widget::setFocus):
- (WebCore::Widget::getOuterView):
- (WebCore::Widget::paint):
- (WebCore::Widget::invalidate):
- (WebCore::Widget::invalidateRect):
- (WebCore::Widget::setIsSelected):
- (WebCore::Widget::releasePlatformWidget):
- (WebCore::Widget::retainPlatformWidget):
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- (WebCore::Widget::Widget):
- (WebCore::Widget::setFrameGeometry):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- (WebCore::Widget::isEnabled):
- (WebCore::Widget::setEnabled):
- (WebCore::Widget::invalidateRect):
- (WebCore::Widget::containingWindow):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::frameGeometry):
- (WebCore::Widget::setFocus):
- (WebCore::Widget::setCursor):
- (WebCore::Widget::show):
- (WebCore::Widget::hide):
- (WebCore::Widget::setFrameGeometry):
- (WebCore::Widget::setEnabled):
- (WebCore::Widget::isEnabled):
- (WebCore::Widget::invalidate):
- (WebCore::Widget::invalidateRect):
- (WebCore::Widget::paint):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView):
- * plugins/PluginView.h:
- (WebCore::PluginView::platformPluginWidget):
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::updateWindow):
- (WebCore::PluginView::setFocus):
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::setParentVisible):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::init):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::updateWindow):
- (WebCore::PluginView::setFocus):
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::setParentVisible):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::~PluginView):
- (WebCore::PluginView::init):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::updateWindow):
- (WebCore::PluginView::setFocus):
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::paint):
- (WebCore::PluginView::setParent):
- (WebCore::PluginView::setParentVisible):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::invalidateRect):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::~PluginView):
- (WebCore::PluginView::init):
-
-2008-09-17 Sam Weinig <sam@webkit.org>
-
- Fix assert.
-
- * platform/Widget.cpp:
- (WebCore::Widget::setParent):
-
-2008-09-17 David Hyatt <hyatt@apple.com>
-
- Beginnings of Widget refactoring (in order to make the mixing of
- widgets with and without corresponding native widgets more cross-platform).
-
- This first patch makes the concept of a parent ScrollView cross-platform.
-
- Note the similarity of the show/hide methods on the three PluginViews. This
- will be refactored better in a later patch so that they can all share
- a base class Widget show/hide method. For now the changes were made
- simply to be able to bring WidgetWin's setParent method up into Widget.
+ feOffset and objectBoundingBox
+ [https://bugs.webkit.org/show_bug.cgi?id=26441]
- Reviewed by Sam Weinig
+ If we use objectBoundingBox for primitiveUnits, the fractions given
+ to dx or dy of feOffset must be multiplied with the referenced objects
+ objectBoundingBox size.
- * WebCore.base.exp:
- * platform/ScrollView.h:
- * platform/Widget.cpp:
- (WebCore::Widget::init):
- (WebCore::Widget::setParent):
- * platform/Widget.h:
- (WebCore::Widget::isSelfVisible):
- (WebCore::Widget::isParentVisible):
- (WebCore::Widget::isVisible):
- (WebCore::Widget::setParentVisible):
- (WebCore::Widget::isPluginView):
- (WebCore::Widget::parent):
- (WebCore::Widget::handleEvent):
- (WebCore::Widget::geometryChanged):
- * platform/gtk/WidgetGtk.cpp:
- (WebCore::Widget::Widget):
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::addChild):
- (WebCore::ScrollView::removeChild):
- * platform/mac/ScrollbarMac.mm:
- (WebCore::ScrollbarMac::~ScrollbarMac):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- * platform/qt/WidgetQt.cpp:
- (WebCore::WidgetPrivate::WidgetPrivate):
- (WebCore::Widget::Widget):
- (WebCore::Widget::topLevel):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
- (WebCore::ScrollView::setAncestorVisible):
- (WebCore::ScrollView::show):
- (WebCore::ScrollView::hide):
- * platform/win/WidgetWin.cpp:
- (WebCore::Widget::Widget):
- (WebCore::Widget::setParent):
- * platform/wx/WidgetWx.cpp:
- (WebCore::Widget::Widget):
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParentVisible):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParentVisible):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::show):
- (WebCore::PluginView::hide):
- (WebCore::PluginView::setParentVisible):
-
-2008-09-17 Alexey Proskuryakov <ap@webkit.org>
+ Test: svg/filters/feOffset.svg
- Reviewed by Adam Roben.
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ (WebCore::FEOffset::apply):
- <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
+2009-06-18 Dirk Schulze <krit@webkit.org>
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
+ Reviewed by Oliver Hunt.
-2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
+ feTile implementation missing
+ [https://bugs.webkit.org/show_bug.cgi?id=26419]
- Fix the QtWebKit/Mac build
+ Implementation of feTile, a pattern effect for SVG filters. It was
+ necessary to modify FilterEffect since source inputs need a secial
+ logic and we have to identify if an effect is a source input.
- * platform/qt/ScrollViewQt.cpp: add include
+ Tests: svg/batik/filters/feTile.svg
+ svg/filters/feTile.svg
-2008-09-17 David Hyatt <hyatt@apple.com>
+ * platform/graphics/filters/FilterEffect.h:
+ (WebCore::FilterEffect::isSourceInput):
+ * platform/graphics/filters/SourceAlpha.h:
+ (WebCore::SourceAlpha::isSourceInput):
+ * platform/graphics/filters/SourceGraphic.h:
+ (WebCore::SourceGraphic::isSourceInput):
+ * svg/graphics/filters/SVGFETile.cpp:
+ (WebCore::FETile::apply):
- Add a #define to control whether or not to use an NSScroller on Mac.
- This ifdef will allow the new NSView-less NSScroller on Mac to be
- developed side by side with the current one.
+2009-06-18 Dirk Schulze <krit@webkit.org>
- The new scroller paints a debug red if turned on (although due to
- Widget issues you won't see anything paint yet).
+ Reviewed by Oliver Hunt.
- Reviewed by olliej
+ feMerge implementation
+ [https://bugs.webkit.org/show_bug.cgi?id=26480]
- * platform/Scrollbar.cpp:
- * platform/Scrollbar.h:
- * platform/mac/ScrollbarMac.h:
- * platform/mac/ScrollbarMac.mm:
- * platform/mac/ScrollbarThemeMac.cpp:
- (WebCore::ScrollbarThemeMac::paint):
- * platform/mac/ScrollbarThemeMac.h:
+ Added feMerge to the SVG Filter system.
-2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
+ Test: svg/filters/feMerge.svg
- Reviewed by Alp Toker.
+ * svg/graphics/filters/SVGFEMerge.cpp:
+ (WebCore::FEMerge::uniteChildEffectSubregions):
+ (WebCore::FEMerge::apply):
+ * svg/graphics/filters/SVGFEMerge.h:
- http://bugs.webkit.org/show_bug.cgi?id=20854
- [GTK] Windows can be not realized in ScrollView::update
+2009-06-18 Mark Rowe <mrowe@apple.com>
- Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
+ Speculative Windows build fix.
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::update):
+ * page/win/FrameCGWin.cpp: Add missing #include.
-2008-09-16 Alp Toker <alp@nuanti.com>
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
- Suggested by Dave Hyatt.
+ Reviewed by Dave Levin.
- Build fix and cleanup. Rename ScrollBar to Scrollbar.
+ https://bugs.webkit.org/show_bug.cgi?id=26425
+ Final refactorings, picking up a few places where BitmapInfo
+ could be used.
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * editing/EditorCommand.cpp:
- * page/EventHandler.cpp:
- * page/gtk/EventHandlerGtk.cpp:
- * page/mac/EventHandlerMac.mm:
- * page/mac/FrameMac.mm:
- * page/qt/EventHandlerQt.cpp:
- * page/wx/EventHandlerWx.cpp:
- * platform/PopupMenu.h:
- * platform/ScrollBar.cpp: Removed.
- * platform/ScrollBar.h: Removed.
- * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
- * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
- * platform/gtk/ScrollbarGtk.cpp:
- (ScrollbarGtk::ScrollbarGtk):
- * platform/gtk/ScrollbarGtk.h:
- * platform/mac/ScrollbarMac.h:
- * platform/qt/ScrollViewQt.cpp:
- * platform/qt/ScrollbarQt.cpp:
- * platform/qt/ScrollbarThemeQt.cpp:
- * platform/win/PlatformScrollBar.h:
+ * page/win/FrameCGWin.cpp:
+ (WebCore::imageFromRect):
+ * platform/win/CursorWin.cpp:
+ (WebCore::Cursor::Cursor):
* platform/win/PopupMenuWin.cpp:
- * platform/win/ScrollViewWin.cpp:
- * platform/win/ScrollbarThemeWin.cpp:
- * platform/wx/ScrollViewWx.cpp:
- * platform/wx/TemporaryLinkStubs.cpp:
- * rendering/HitTestResult.cpp:
- * rendering/RenderLayer.cpp:
- * rendering/RenderTextControl.cpp:
-
-2008-09-16 David Hyatt <hyatt@apple.com>
-
- Fix Qt build bustage by making moveThumb a member of Scrollbar so that
- it can be called from ScrollbarQt.
-
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::moveThumb):
- (WebCore::Scrollbar::handleMouseMoveEvent):
- (WebCore::Scrollbar::handleMousePressEvent):
- * platform/ScrollBar.h:
- * platform/qt/ScrollViewQt.cpp:
- * platform/qt/ScrollbarQt.cpp:
- (WebCore::Scrollbar::handleContextMenuEvent):
-
-2008-09-16 David Hyatt <hyatt@apple.com>
-
- Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
- native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
- now just use Scrollbar.
-
- Reviewed by Sam Weinig
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * page/mac/FrameMac.mm:
- * platform/PopupMenu.h:
- (WebCore::PopupMenu::scrollbar):
- * platform/ScrollBar.cpp:
- (WebCore::createNativeScrollbar):
- * platform/ScrollBar.h:
- * platform/gtk/PlatformScrollBar.h: Removed.
- * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
- * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
- (gtkScrollEventCallback):
- (ScrollbarGtk::ScrollbarGtk):
- (ScrollbarGtk::~ScrollbarGtk):
- (ScrollbarGtk::updateThumbPosition):
- (ScrollbarGtk::updateThumbProportion):
- (ScrollbarGtk::setFrameGeometry):
- (ScrollbarGtk::geometryChanged):
- (ScrollbarGtk::gtkValueChanged):
- * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
- * platform/mac/PlatformScrollBar.h: Removed.
- * platform/mac/PlatformScrollBarMac.mm: Removed.
- * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
- * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
- (-[WebCoreScrollBar initWithScrollbarMac:]):
- (-[WebCoreScrollBar detachScrollbarMac]):
- (WebCore::Scrollbar::createNativeScrollbar):
- (WebCore::ScrollbarMac::ScrollbarMac):
- (WebCore::ScrollbarMac::~ScrollbarMac):
- (WebCore::ScrollbarMac::updateThumbPosition):
- (WebCore::ScrollbarMac::updateThumbProportion):
- (WebCore::ScrollbarMac::scrollbarHit):
- * platform/qt/PlatformScrollBar.h: Removed.
- * platform/qt/PlatformScrollBarQt.cpp: Removed.
- * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
- (WebCore::Scrollbar::handleContextMenuEvent):
- * rendering/HitTestResult.cpp:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::destroyScrollbar):
- * rendering/RenderLayer.h:
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::~RenderListBox):
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::isPointInOverflowControl):
- * rendering/RenderObject.h:
- * rendering/RenderTextControl.cpp:
-
-2008-09-16 David Hyatt <hyatt@apple.com>
-
- Make the scrollbar resizer-dodging logic cross-platform in the
- Scrollbar class.
-
- Reviewed by Sam Weinig
+ (WebCore::PopupMenu::paint):
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::setFrameGeometry):
- (WebCore::Scrollbar::setParent):
- (WebCore::Scrollbar::windowClipRect):
- * platform/ScrollBar.h:
- * platform/ScrollView.h:
- (WebCore::ScrollView::windowResizerRect):
- (WebCore::ScrollView::resizerOverlapsContent):
- (WebCore::ScrollView::adjustOverlappingScrollbarCount):
- * platform/Widget.h:
- (WebCore::Widget::setParent):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertToContainingWindow):
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarWin.cpp:
-
-2008-09-16 Dan Bernstein <mitz@apple.com>
+2009-06-18 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
- - fix https://bugs.webkit.org/show_bug.cgi?id=15129
- <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
-
- Covered by fast/repaint/4776765.html
+ Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
+ https://bugs.webkit.org/show_bug.cgi?id=26522
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
- did not have layout in the beginning.
- (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
- layout in the beginning, repaint it in its new position, to compensate
- for the above (regardless of whether it "moved").
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
- about generalizing this fix in the future.
-
-2008-09-16 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
+ Test: accessibility/non-data-table-cell-title-ui-element.html
- - fix https://bugs.webkit.org/show_bug.cgi?id=15384
- Div does not notice when grandparent changes height
-
- Test: fast/block/basic/quirk-percent-height-grandchild.html
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20714
- Resizing Gmail inbox vertically results in whitespace at the bottom of the window
-
- Test: fast/replaced/percent-height-in-anonymous-block.html
-
- Added a two-way mapping between boxes with percentage heights and
- their non-parent ancestors up to the one the height is computed relative
- to. In quirks mode (the first bug), this can be any number of containing
- block with auto height. In strict mode (the second bug) this can be
- the containing block of an anonymous block containing a replaced
- element.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
- mapping to/from this block to percentage-height descendants.
- (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
- percentage-height descendants (and their containing block ancestry chain
- up to this block) for layout. This ensures that those descendants whose
- height depends on the height of this block (or an ancestor) are updated.
- (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
- a two-way mapping between this block and the given box.
- (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
- all the mapping to/from this box.
- * rendering/RenderBlock.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::setStyle): Added calls to
- removePercentHeightDescendant() when style changes and the box
- previously had a percentage height. An exception is when the style
- change does not require layout, in which case the box still has
- a percentage height and the mappings are valid. In all other cases,
- any required mappings will be (re-)established during layout.
- (WebCore::RenderBox::destroy): Added a call to
- removePercentHeightDescendant.
- (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
- mode, if a higher-than-parent containing block is affecting the box's
- height, creates a mapping between the box and that block.
- (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
- anonymous containing blocks, if any, and when that happens, use
- addPercentHeightDescendant() to ensure that the non-anonymous block
- is aware of the dependent percent-height box.
-
-2008-09-16 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Oliver Hunt and Alp Toker.
-
- Implemented toDataURL in Cairo. Only PNG support
- at the moment.
-
- Qt, Cairo and wx require toDataURL implementations
- https://bugs.webkit.org/show_bug.cgi?id=17719
-
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedImageMIMETypesForEncoding):
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::ImageBuffer):
- (WebCore::writeFunction):
- (WebCore::ImageBuffer::toDataURL):
+ * accessibility/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::titleUIElement):
-2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
+2009-06-18 Kevin Ollivier <kevino@theolliviers.com>
- Reviewed by Simon.
+ wx build fix after recent RenderTheme changes.
- Hide unused media element controls in the QtWebKit port
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::~RenderThemeWx):
+ (WebCore::RenderTheme::themeForPage):
+
+2009-06-18 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26460 part two
+ Attempt to minimize diff of following functional change by first landing
+ non-functional change to:
+ * Make readUintX() public and static (since they will need to be once
+ BMPImageReader is included in *ImageDecoder via composition rather
+ than inheritance). Add wrappers in each class so callers can be
+ simpler. In the next patch, these wrappers will be beefed up slightly
+ and the callers will get even simpler.
+ * Change direct setting of m_failed to use setFailed(), since in the
+ next patch much of this code won't even have direct access to m_failed
+ * Add a helper function in ICOImageDecoder to determine the image type
+ instead of simply doing it inline
+ * Rewrap lines that used to be <=80 cols and slipped over it during the
+ original landing of these decoders
+ * Other misc. changes, e.g. adding constructor definitions, reordering
+ functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no
+ functional effect but minimize the subsequent diff for readability
+
+
+ * platform/image-decoders/bmp/BMPImageDecoder.cpp:
+ (WebCore::BMPImageDecoder::BMPImageDecoder):
+ (WebCore::BMPImageDecoder::processFileHeader):
+ * platform/image-decoders/bmp/BMPImageDecoder.h:
+ (WebCore::BMPImageDecoder::readUint32):
+ * platform/image-decoders/bmp/BMPImageReader.cpp:
+ (WebCore::BMPImageReader::decodeBMP):
+ (WebCore::BMPImageReader::getInfoHeaderSize):
+ (WebCore::BMPImageReader::processInfoHeader):
+ (WebCore::BMPImageReader::readInfoHeader):
+ (WebCore::BMPImageReader::processBitmasks):
+ (WebCore::BMPImageReader::processColorTable):
+ (WebCore::BMPImageReader::processRLEData):
+ (WebCore::BMPImageReader::processNonRLEData):
+ * platform/image-decoders/bmp/BMPImageReader.h:
+ (WebCore::BMPImageReader::readUint16Helper):
+ (WebCore::BMPImageReader::readUint32Helper):
+ (WebCore::BMPImageReader::):
+ (WebCore::BMPImageReader::readUint16):
+ (WebCore::BMPImageReader::readUint32):
+ (WebCore::BMPImageReader::readCurrentPixel):
+ (WebCore::BMPImageReader::getComponent):
+ (WebCore::BMPImageReader::setI):
+ (WebCore::BMPImageReader::setRGBA):
+ (WebCore::BMPImageReader::fillRGBA):
+ * platform/image-decoders/ico/ICOImageDecoder.cpp:
+ (WebCore::ICOImageDecoder::ICOImageDecoder):
+ (WebCore::ICOImageDecoder::isSizeAvailable):
+ (WebCore::ICOImageDecoder::size):
+ (WebCore::ICOImageDecoder::decodeImage):
+ (WebCore::ICOImageDecoder::processDirectory):
+ (WebCore::ICOImageDecoder::processDirectoryEntries):
+ (WebCore::ICOImageDecoder::isBetterEntry):
+ (WebCore::ICOImageDecoder::processImageType):
+ * platform/image-decoders/ico/ICOImageDecoder.h:
+ (WebCore::ICOImageDecoder::readUint16):
+ (WebCore::ICOImageDecoder::readUint32):
- * platform/qt/html4-adjustments-qt.css
+2009-06-18 Peter Kasting <pkasting@google.com>
-2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
+ Fix build bustage.
- Reviewed by Simon.
+ * platform/image-decoders/gif/GIFImageDecoder.h:
- Fix compilation of the Qt scrollbar code.
+2009-06-18 Kevin McCullough <kmccullough@apple.com>
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::scPart):
- (WebCore::styleOptionSlider):
- (WebCore::thumbLength):
- (WebCore::pixelPosToRangeValue):
- (WebCore::PlatformScrollbar::handleContextMenuEvent):
+ Reviewed by Oliver Hunt.
-2008-09-16 Adam Treat <treat@kde.org>
+ <rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
- Reviewed by Anders Carlsson.
+ Convert intptr_t to Strings so that we don't loose bits in the
+ conversion to JS. Previously they were being put into 32bit ints.
- Prevent accesses off of the end of the buffer introduced in r36450
- and when checking for descriptions of mime. Also, coding style fix.
+ * inspector/InspectorController.cpp: Convert the String back to an
+ intptr_t.
+ (WebCore::InspectorController::addBreakpoint):
+ (WebCore::InspectorController::removeBreakpoint):
+ * inspector/InspectorController.h:
+ * inspector/InspectorController.idl: Use strings in JS to avoid 32bit
+ truncation.
+ * inspector/InspectorFrontend.cpp: Make the intptr_t into a String.
+ (WebCore::InspectorFrontend::parsedScriptSource):
+ * platform/text/PlatformString.h: Implemented the necessary conversion
+ functions to be able to convert to and from an intptr_t.
+ * platform/text/String.cpp: Ditto.
+ (WebCore::String::toIntPtrStrict):
+ (WebCore::String::toIntPtr):
+ (WebCore::charactersToIntPtrStrict):
+ (WebCore::charactersToIntPtr):
+ * platform/text/StringImpl.cpp: Ditto.
+ (WebCore::StringImpl::toIntPtrStrict):
+ (WebCore::StringImpl::toIntPtr):
+ * platform/text/StringImpl.h: Ditto.
+
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Final cleanups in this refactoring:
+ (1) Move WindowsBitmap implementation from CG-specific file to
+ the platform-common GraphicsContextWin.cpp, since it is
+ equally useful on both platforms.
+ (2) Revise the TransformationMatrix logic as suggested by
+ Adam Roben in his review comments to Part #2 of this
+ refactoring.
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::fetchInfo):
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ * platform/graphics/win/GraphicsContextWin.cpp:
+ (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
+ (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap):
+ (WebCore::GraphicsContext::createWindowsBitmap):
+ (WebCore::GraphicsContext::getWindowsContext):
+ (WebCore::GraphicsContextPlatformPrivate::scale):
+ (WebCore::GraphicsContextPlatformPrivate::rotate):
+ (WebCore::GraphicsContextPlatformPrivate::translate):
+ (WebCore::GraphicsContextPlatformPrivate::concatCTM):
-2008-09-15 Rob Buis <buis@kde.org>
+2009-06-18 Peter Kasting <pkasting@google.com>
- Reviewed by Eric.
+ Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=20634
- SVG transform attribute is ignored by <use> in <clipPath>
+ https://bugs.webkit.org/show_bug.cgi?id=26460 part one
+ Make isSizeAvailable non-const, since it's not logically const (it
+ triggers lazy decoding), and simplify all the implementations (without
+ changing behavior; just make less verbose). Remove some other
+ inappropriate consts, which enables the removal of all the mutable
+ declarations in the decoders.
- Transform the paths with the local transform when part
- of a clip path.
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::ImageDecoder::isSizeAvailable):
+ (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::isSizeAvailable):
+ (WebCore::GIFImageDecoder::repetitionCount):
+ (WebCore::GIFImageDecoder::decode):
+ * platform/image-decoders/gif/GIFImageDecoder.h:
+ * platform/image-decoders/ico/ICOImageDecoder.cpp:
+ (WebCore::ICOImageDecoder::isSizeAvailable):
+ * platform/image-decoders/ico/ICOImageDecoder.h:
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageDecoder::isSizeAvailable):
+ (WebCore::JPEGImageDecoder::decode):
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h:
+ * platform/image-decoders/png/PNGImageDecoder.cpp:
+ (WebCore::PNGImageDecoder::isSizeAvailable):
+ (WebCore::PNGImageDecoder::decode):
+ * platform/image-decoders/png/PNGImageDecoder.h:
+ * platform/image-decoders/xbm/XBMImageDecoder.cpp:
+ (WebCore::XBMImageDecoder::isSizeAvailable):
+ (WebCore::XBMImageDecoder::frameBufferAtIndex):
+ (WebCore::XBMImageDecoder::decode):
+ * platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
- Test: svg/custom/use-clipped-transform.svg
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
- * svg/SVGClipPathElement.cpp:
- (WebCore::SVGClipPathElement::canvasResource):
- * svg/SVGStyledTransformableElement.cpp:
- (WebCore::SVGStyledTransformableElement::toClipPath):
- * svg/SVGStyledTransformableElement.h:
+ Reviewed by Eric Seidel.
-2008-09-15 Dave Hyatt <hyatt@apple.com>
+ Move some common functions out of platform files and into
+ the common implementation.
- Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
- to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
+ https://bugs.webkit.org/show_bug.cgi?id=26425.
+ Add a new platform context method (flush) so that the
+ getWindowsContext method can be consolidated into the common
+ GraphicsContextWin.cpp file.
+
+ * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+ (WebCore::GraphicsContextPlatformPrivate::flush):
+ * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
+ (WebCore::GraphicsContextPlatformPrivate::flush):
+ * platform/graphics/win/GraphicsContextCGWin.cpp: Remove
+ getWindowContext method.
+ * platform/graphics/win/GraphicsContextCairoWin.cpp: Remove
+ getWindowContext method and fillWithClearColor methods.
+ * platform/graphics/win/GraphicsContextWin.cpp:
+ (WebCore::fillWithClearColor): Moved from *CairoWin.cpp
+ (WebCore::GraphicsContext::getWindowsContext): Moved
+ from *CairoWin.cpp
- Reviewed by Sam Weinig
+2009-06-18 Ojan Vafai <ojan@chromium.org>
- * platform/ScrollBar.cpp:
- (WebCore::thumbUnderMouse):
- (WebCore::Scrollbar::autoscrollPressedPart):
- (WebCore::Scrollbar::startTimerIfNeeded):
- (WebCore::moveThumb):
- (WebCore::Scrollbar::handleMouseMoveEvent):
- (WebCore::Scrollbar::handleMousePressEvent):
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::pressedPos):
- (WebCore::Scrollbar::pixelStep):
- (WebCore::Scrollbar::setPressedPos):
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::thumbPosition):
- (WebCore::ScrollbarTheme::thumbLength):
- (WebCore::ScrollbarTheme::trackPosition):
- (WebCore::ScrollbarTheme::trackLength):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::trackPosition):
- * platform/ScrollbarThemeComposite.h:
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::):
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
- (WebCore::ScrollbarThemeQt::hitTest):
- (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
- (WebCore::ScrollbarThemeQt::invalidatePart):
- (WebCore::ScrollbarThemeQt::thumbPosition):
- (WebCore::):
- * platform/qt/ScrollbarThemeQt.h:
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
- * platform/win/ScrollbarThemeSafari.h:
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
- * platform/win/ScrollbarThemeWin.h:
+ Reviewed by Oliver Hunt.
-2008-09-15 David Smith <catfish.man@gmail.com>
+ Remove code that I accidentally committed in r44811.
- Reviewed by Sam Weinig.
+ * editing/markup.cpp:
+ (WebCore::createMarkup):
- https://bugs.webkit.org/show_bug.cgi?id=20180
-
- Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
-
- * GNUmakefile.am: Add CSSNthSelector
- * WebCore.pro: Add CSSNthSelector
- * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
- * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
- * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
- * css/CSSNthSelector.cpp: Added.
- (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
- (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
- * css/CSSNthSelector.h: Added.
- (WebCore::CSSNthSelector::CSSNthSelector):
- (WebCore::CSSNthSelector::~CSSNthSelector):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::createFloatingNthSelector):
- * css/CSSParser.h:
- * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
- (WebCore::CSSSelector::CSSSelector):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
+2009-06-18 Simon Fraser <simon.fraser@apple.com>
-2008-09-15 Matt Lilek <webkit@mattlilek.com>
+ Reviewed by Dan Bernstein.
- Reviewed by Tim Hatcher.
+ <rdar://problem/6983207> Non-layer content is not re-rendered when transition
+ starts sometimes (with hardware acceleration).
+
+ When deciding which RenderLayers should be composited, when a layer goes into
+ compositing mode we repaint the old location. However, we did that before
+ we'd looked at all the factors that may force a layer to composite, so missed
+ some cases. Fix by doing the repaint once we really know whether it's going
+ to composite.
- Clean up some inspector JS callbacks to remove an extra return.
-
- * page/InspectorController.cpp:
- (WebCore::hideDOMNodeHighlight):
- (WebCore::loaded):
- (WebCore::unloading):
- (WebCore::attach):
- (WebCore::detach):
- (WebCore::startDebuggingAndReloadInspectedPage):
- (WebCore::stopDebugging):
- (WebCore::debuggerAttached):
- (WebCore::pauseOnExceptions):
- (WebCore::pauseInDebugger):
- (WebCore::resumeDebugger):
- (WebCore::stepOverStatementInDebugger):
- (WebCore::stepIntoStatementInDebugger):
- (WebCore::stepOutOfFunctionInDebugger):
- (WebCore::isWindowVisible):
- (WebCore::closeWindow):
-
-2008-09-15 Dave Hyatt <hyatt@apple.com>
-
- Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
- now share most of their code.
-
- Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
- also is never used in our code anyway.
+ Test: compositing/repaint/become-overlay-composited-layer.html
- Reviewed by Sam Weinig
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- * WebCore.vcproj/WebCore.vcproj:
- * platform/ScrollTypes.h:
- (WebCore::):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::splitTrack):
- (WebCore::ScrollbarThemeComposite::thumbLength):
- (WebCore::ScrollbarThemeComposite::minimumThumbLength):
- * platform/ScrollbarThemeComposite.h:
- * platform/mac/PlatformScrollBarMac.mm:
- (NSControlSizeForScrollBarControlSize):
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp: Removed.
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- * platform/win/ScrollbarThemeSafari.cpp:
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::):
- (WebCore::scrollbarControlStateFromThemeState):
- (WebCore::ScrollbarThemeSafari::hasButtons):
- (WebCore::ScrollbarThemeSafari::hasThumb):
- (WebCore::buttonRepaintRect):
- (WebCore::ScrollbarThemeSafari::backButtonRect):
- (WebCore::ScrollbarThemeSafari::forwardButtonRect):
- (WebCore::trackRepaintRect):
- (WebCore::ScrollbarThemeSafari::trackRect):
- (WebCore::ScrollbarThemeSafari::minimumThumbLength):
- (WebCore::ScrollbarThemeSafari::paintTrack):
- (WebCore::ScrollbarThemeSafari::paintButton):
- (WebCore::ScrollbarThemeSafari::paintThumb):
- * platform/win/ScrollbarThemeSafari.h:
- * platform/win/ScrollbarThemeWin.cpp:
- * platform/win/ScrollbarThemeWin.h:
-
-2008-09-15 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler, Beth Dakin
-
- <rdar://problem/4003789> Expose lists as AXList
- <rdar://problem/5707399> VO: Definition lists not announced in Safari
-
- Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
- AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
- Inside the definition list, each <dt> "term" has an accessibility description ("term"),
- as does each <dd> tag ("definition")
-
- Test: accessibility/lists.html
+2009-06-18 Simon Fraser <simon.fraser@apple.com>
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * page/AXObjectCache.cpp:
- * page/AccessibilityList.cpp: Added.
- * page/AccessibilityList.h: Added.
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- * page/AccessibilityTable.cpp:
- * page/mac/AccessibilityObjectWrapper.mm:
- * page/mac/WebCoreViewFactory.h:
- * platform/LocalizedStrings.h:
- * platform/mac/LocalizedStringsMac.mm:
- * platform/qt/Localizations.cpp:
+ Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
+ the Tiger build where QTMovieLayer does not exist.
-2008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovieLayer):
+ (WebCore::MediaPlayerPrivate::destroyQTMovieLayer):
+ (WebCore::MediaPlayerPrivate::currentRenderingMode):
+ (WebCore::MediaPlayerPrivate::setUpVideoRendering):
+ (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
+ (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
- Reviewed by Eric.
+2009-06-18 Simon Fraser <simon.fraser@apple.com>
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
- Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
+ Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.
- Several renames:
- dispatchHTMLEvent -> dispatchEventForType
- setHTMLEventListener -> setEventListenerForType
- getHTMLEventListener -> eventListenerForType
- removeHTMLEventListener -> removeEventListenerForType
- isHTMLEventListener -> isAttachedToEventTargetNode
- ...
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::currentRenderingMode):
+ (WebCore::MediaPlayerPrivate::setUpVideoRendering):
+ (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
- Similar renames for the dispatch/get/set/*Window*Event functions.
- Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
+2009-06-17 Erik Arvidsson <arv@chromium.org>
- Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
- as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
+ Reviewed by Adele Peterson.
- setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
- SVG is able to use the code as well now. This affects most files in html/.
+ https://bugs.webkit.org/show_bug.cgi?id=15189
+ Adds the HTML5 input event support for textarea.
+
+ Also, moves the oninput attribute parse handling to HTMLElement so that
+ it can be set on any HTML element so that bubbling events can be handled
+ using HTML attribute handlers.
- No functional changes.
+ Test: fast/forms/textarea-input-event.html
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- (WebCore::JSDOMWindowBase::setListener):
- (WebCore::JSDOMWindowBase::getListener):
- (WebCore::JSDOMWindowBase::findJSEventListener):
- (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
- (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
- (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
- (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
- (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
- (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
- (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
- (WebCore::JSEventListener::JSEventListener):
- (WebCore::JSEventListener::~JSEventListener):
- (WebCore::JSLazyEventListener::JSLazyEventListener):
- (WebCore::eventParameterName):
- (WebCore::JSLazyEventListener::parseCode):
- (WebCore::getNodeEventListener):
- * bindings/js/JSEventListener.h:
- (WebCore::JSAbstractEventListener::JSAbstractEventListener):
- (WebCore::JSUnprotectedEventListener::create):
- (WebCore::JSEventListener::create):
- (WebCore::JSLazyEventListener::):
- (WebCore::JSLazyEventListener::create):
- * bindings/js/JSEventTargetNode.cpp:
- (WebCore::JSEventTargetNode::setListener):
- (WebCore::JSEventTargetNode::getListener):
- * bindings/js/JSSVGLazyEventListener.cpp: Removed.
- * bindings/js/JSSVGLazyEventListener.h: Removed.
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::createHTMLEventHandler):
- (WebCore::ScriptController::createSVGEventHandler):
- * dom/Document.cpp:
- (WebCore::Document::setFocusedNode):
- (WebCore::Document::handleWindowEvent):
- (WebCore::Document::setWindowEventListenerForType):
- (WebCore::Document::windowEventListenerForType):
- (WebCore::Document::removeWindowEventListenerForType):
- (WebCore::Document::addWindowEventListener):
- (WebCore::Document::hasWindowEventListener):
- (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
- (WebCore::Document::createEventListener):
- (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
- * dom/Document.h:
- * dom/EventListener.h:
- (WebCore::EventListener::isAttachedToEventTargetNode):
- * dom/EventTargetNode.cpp:
- (WebCore::EventTargetNode::dispatchFocusEvent):
- (WebCore::EventTargetNode::dispatchBlurEvent):
- (WebCore::EventTargetNode::dispatchEventForType):
- (WebCore::EventTargetNode::removeEventListenerForType):
- (WebCore::EventTargetNode::setEventListenerForType):
- (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
- (WebCore::EventTargetNode::eventListenerForType):
- * dom/EventTargetNode.h:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::notifyFinished):
- * editing/ReplaceSelectionCommand.cpp:
- (WebCore::ReplacementFragment::ReplacementFragment):
- * html/HTMLBodyElement.cpp:
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::parseMappedAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- (WebCore::HTMLElement::checkDTD):
- * html/HTMLElement.h:
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::onChange):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::prepareSubmit):
- (WebCore::HTMLFormElement::reset):
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
- (WebCore::HTMLInputElement::setValueFromRenderer):
- (WebCore::HTMLInputElement::onSearch):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::asyncEventTimerFired):
- (WebCore::HTMLMediaElement::load):
- (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
- (WebCore::HTMLMediaElement::setReadyState):
- (WebCore::HTMLMediaElement::seek):
- (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
- (WebCore::HTMLMediaElement::willSaveToCache):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- (WebCore::HTMLScriptElement::dispatchErrorEvent):
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::parseMappedAttribute):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::mouseButtonListener):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- * page/Frame.cpp:
- (WebCore::Frame::sendScrollEvent):
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::valueChanged):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::selectionChanged):
- * svg/SVGDocumentExtensions.cpp:
- * svg/SVGDocumentExtensions.h:
- * svg/SVGElement.cpp:
- (WebCore::SVGElement::parseMappedAttribute):
- (WebCore::SVGElement::finishParsingChildren):
- * svg/SVGElement.h:
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::parseMappedAttribute):
- * svg/SVGSVGElement.h:
-
-2008-09-15 Dave Hyatt <hyatt@apple.com>
-
- Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
- need to be converted.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::updateThumbPosition):
- (WebCore::Scrollbar::updateThumbProportion):
- (WebCore::Scrollbar::autoscrollPressedPart):
- (WebCore::Scrollbar::startTimerIfNeeded):
- * platform/ScrollBar.h:
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::invalidateParts):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::hitTest):
- (WebCore::ScrollbarThemeComposite::invalidatePart):
- (WebCore::ScrollbarThemeComposite::thumbPosition):
- (WebCore::ScrollbarThemeComposite::thumbLength):
- (WebCore::ScrollbarThemeComposite::trackLength):
- * platform/ScrollbarThemeComposite.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
-
-2008-09-15 David Smith <catfish.man@gmail.com>
-
- "Just do it"'d by Mark Rowe
-
- https://bugs.webkit.org/show_bug.cgi?id=20856
- Add missing license header
-
- * dom/NodeRenderStyle.h:
-
-2008-09-15 Dean Jackson <dino@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Add default constructor for ShadowData
- https://bugs.webkit.org/show_bug.cgi?id=20757
-
- Test: transitions/shadow.html
-
- * rendering/style/RenderStyle.h:
-
-2008-09-15 Dean Jackson <dino@apple.com>
-
- Reviewed by Tim Hatcher.
-
- RenderStyle should update keyframes.
- http://bugs.webkit.org/show_bug.cgi?id=20756
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::StyleRareNonInheritedData::updateKeyframes):
-
-2008-09-15 Dean Jackson <dino@apple.com>
-
- Reviewed by Tim Hatcher.
-
- Unnecessary ASSERT in ImplicitAnimation destructor.
- https://bugs.webkit.org/show_bug.cgi?id=20817
-
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::~ImplicitAnimation):
-
-2008-09-15 Adam Treat <treat@kde.org>
-
- Reviewed by Simon.
-
- Fix plugin extension info. It was returning the mimetype where the
- extension was given.
-
- * plugins/qt/PluginPackageQt.cpp:
- (WebCore::PluginPackage::fetchInfo):
-
-2008-09-15 Dean Jackson <dino@apple.com>
-
- Reviewed by Tim Hatcher
-
- Coding style violation!!!! Cleanup AnimationBase.cpp
-
- * page/animation/AnimationBase.cpp:
- (WebCore::blendFunc):
-
-2008-09-15 David Hyatt <hyatt@apple.com>
-
- Move all hit testing code for scrollbars into the base class. Refactor
- it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
- functions.
-
- No platform is using this code yet. Although it has been moved and compiles
- (even on Mac), it is not being used on any platform.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::autoscrollPressedPart):
- (WebCore::Scrollbar::startTimerIfNeeded):
- (WebCore::Scrollbar::handleMouseMoveEvent):
- (WebCore::Scrollbar::handleMouseOutEvent):
- (WebCore::Scrollbar::handleMouseReleaseEvent):
- (WebCore::Scrollbar::handleMousePressEvent):
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::handleContextMenuEvent):
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::hitTest):
- (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
- (WebCore::ScrollbarTheme::invalidatePart):
- (WebCore::ScrollbarTheme::shouldCenterOnThumb):
- (WebCore::ScrollbarTheme::centerOnThumb):
- (WebCore::ScrollbarTheme::thumbPosition):
- (WebCore::ScrollbarTheme::thumbLength):
- (WebCore::ScrollbarTheme::trackLength):
- (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
- (WebCore::ScrollbarTheme::autoscrollTimerDelay):
- * platform/Widget.h:
- (WebCore::Widget::parent):
- * platform/mac/PlatformScrollBar.h:
- (WebCore::PlatformScrollbar::handleMouseMoveEvent):
- (WebCore::PlatformScrollbar::handleMouseOutEvent):
- (WebCore::PlatformScrollbar::handleMousePressEvent):
- (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
- * platform/mac/WidgetMac.mm:
- (WebCore::Widget::convertFromContainingWindow):
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
- * platform/win/ScrollbarThemeWin.h:
-
-2008-09-15 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
-
- Cache the next breakable position for text nodes in InlineIterator.
-
- * rendering/bidi.cpp:
- (WebCore::InlineIterator::InlineIterator):
- (WebCore::InlineIterator::increment):
- (WebCore::RenderBlock::findNextLineBreak):
-
-2008-09-15 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dan Bernstein
-
- Fix assertion and integral pixel issue when creating subimages.
- https://bugs.webkit.org/show_bug.cgi?id=20786
-
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw):
-
-2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Implment seek() and clean up and improve debugging output
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (debugMediaObject):
- (WebCore::MediaPlayerPrivate::seek):
- (WebCore::MediaPlayerPrivate::setVolume):
- (WebCore::MediaPlayerPrivate::setMuted):
- (WebCore::MediaPlayerPrivate::updateStates):
- (WebCore::MediaPlayerPrivate::naturalSize):
- (WebCore::MediaPlayerPrivate::paint):
- (WebCore::MediaPlayerPrivate::stateChanged):
- (WebCore::MediaPlayerPrivate::tick):
-
-2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon.
-
- Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
-
- m_mediaObject, m_audioOutput, m_videoWidget get created in the
- c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
- only check if we use the MediaPlayerPrivate after it has been deleted.
-
- Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::play):
- (WebCore::MediaPlayerPrivate::setVolume):
- (WebCore::MediaPlayerPrivate::updateStates):
-
-2008-09-15 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Maciej.
-
- <rdar://problem/6163988>
- https://bugs.webkit.org/show_bug.cgi?id=20457
- Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
-
- Check the width and height and throw an exception if any of them are 0.
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::createPattern):
-
-2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Render media element controls with antialiasing enabled
-
- * platform/qt/RenderThemeQt.cpp:
- (WebCore::RenderThemeQt::paintMediaMuteButton):
- (WebCore::RenderThemeQt::paintMediaPlayButton):
- (WebCore::RenderThemeQt::paintMediaSliderTrack):
- (WebCore::RenderThemeQt::paintMediaSliderThumb):
-
-2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
-
- Reviewed by Simon.
-
- Upon non fatal error, switch to the pause state (so that playback can continue)
-
- * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- (WebCore::MediaPlayerPrivate::updateStates):
-
-2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
-
- * WebCore.pro:
-
-2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Make QtInstance::create() private and fix caching
-
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getQtInstance):
- (JSC::Bindings::QtInstance::getRuntimeObject):
- * bridge/qt/qt_instance.h:
- (JSC::Bindings::QtInstance::create):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
- (JSC::Bindings::QtConnectionObject::execute):
-
-2008-09-15 David Smith <catfish.man@gmail.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=20180
-
- >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
- With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
- querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::CSSStyleSelector):
- (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
- * css/CSSStyleSelector.h:
-
-2008-09-14 Dave Hyatt <hyatt@apple.com>
-
- Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
- is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::client):
- (WebCore::Scrollbar::currentPos):
- (WebCore::Scrollbar::totalSize):
- * platform/ScrollbarTheme.h:
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::pageForScrollView):
- (WebCore::ScrollbarThemeComposite::paint):
- * platform/ScrollbarThemeComposite.h:
- (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- * platform/win/PlatformScrollBarWin.cpp:
- * platform/win/ScrollbarThemeSafari.h:
- (WebCore::ScrollbarThemeSafari::hasButtons):
- (WebCore::ScrollbarThemeSafari::hasThumb):
- (WebCore::ScrollbarThemeSafari::backButtonRect):
- (WebCore::ScrollbarThemeSafari::forwardButtonRect):
- (WebCore::ScrollbarThemeSafari::trackRect):
- (WebCore::ScrollbarThemeSafari::splitTrack):
- (WebCore::ScrollbarThemeSafari::paintTrack):
- (WebCore::ScrollbarThemeSafari::paintButton):
- (WebCore::ScrollbarThemeSafari::paintThumb):
- * platform/win/ScrollbarThemeWin.cpp:
- (WebCore::isRunningOnVistaOrLater):
- (WebCore::checkAndInitScrollbarTheme):
- (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
- (WebCore::ScrollbarThemeWin::themeChanged):
- (WebCore::ScrollbarThemeWin::hasThumb):
- (WebCore::ScrollbarThemeWin::backButtonRect):
- (WebCore::ScrollbarThemeWin::forwardButtonRect):
- (WebCore::ScrollbarThemeWin::trackRect):
- (WebCore::ScrollbarThemeWin::splitTrack):
- (WebCore::ScrollbarThemeWin::paintTrack):
- (WebCore::ScrollbarThemeWin::paintButton):
- (WebCore::gripperRect):
- (WebCore::paintGripper):
- (WebCore::ScrollbarThemeWin::paintThumb):
- (WebCore::ScrollbarThemeWin::thumbPosition):
- (WebCore::ScrollbarThemeWin::thumbLength):
- (WebCore::ScrollbarThemeWin::trackLength):
- * platform/win/ScrollbarThemeWin.h:
- (WebCore::ScrollbarThemeWin::hasButtons):
- (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
-
-2008-09-14 Anthony Ricaud <rik24d@gmail.com>
-
- Moving all resource graphs under the same container for future scalable feature.
- This is a speedup on resize but maybe a loss on changing the sorting function.
-
- https://bugs.webkit.org/show_bug.cgi?id=20555
-
- Reviewed by Timothy Hatcher.
-
- * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
- Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
- * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
-
-2008-09-14 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej Stachowiak.
-
- https://bugs.webkit.org/show_bug.cgi?id=20738
- compareBoundaryPoints gives incorrect results
-
- Test: fast/dom/Range/compareBoundaryPoints-2.html
-
- * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
- and END_TO_START.
- * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
-
-2008-09-14 Maciej Stachowiak <mjs@apple.com>
-
- Unreviewed build fix.
-
- Trying again.
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::hasInstance):
-
-2008-09-14 Maciej Stachowiak <mjs@apple.com>
-
- Unreviewed build fix.
-
- Blind attempt to fix build. Correct parameters for hasInstance.
-
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- * bindings/js/JSQuarantinedObjectWrapper.h:
-
-2008-09-14 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Sam Weinig.
-
- - revert <http://trac.webkit.org/changeset/36382> because it exposed
- <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
- on Tiger.
-
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::FontCache::getFontDataForCharacters):
- (WebCore::FontCache::getLastResortFallbackFont):
-
-2008-09-14 Dave Hyatt <hyatt@apple.com>
-
- Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
- ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
- theme.
-
- Reviewed by Sam Weinig
-
- * WebCore.vcproj/WebCore.vcproj:
- * platform/win/ScrollbarThemeSafari.h:
- * platform/win/ScrollbarThemeWin.h:
-
-2008-09-14 Alp Toker <alp@nuanti.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=20320
- [GTK] A white rectangle is visible behind widgets with rounded corners
-
- Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
- style exempt).
-
- Requested by Michael Monreal.
-
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::RenderThemeGtk):
- * platform/gtk/gtk2drawing.c:
- (moz_gtk_set_widget_name):
- (ensure_window_widget):
- (setup_widget_prototype):
- (ensure_button_arrow_widget):
- (moz_gtk_get_combo_box_inner_button):
- (moz_gtk_get_combo_box_button_inner_widgets):
- (ensure_combo_box_widgets):
- (moz_gtk_get_combo_box_entry_inner_widgets):
- (moz_gtk_get_combo_box_entry_arrow):
- (ensure_combo_box_entry_widgets):
- (ensure_toolbar_widget):
- (ensure_tooltip_widget):
- (ensure_menu_bar_widget):
- (ensure_menu_bar_item_widget):
- (ensure_menu_popup_widget):
- (ensure_menu_item_widget):
- (ensure_image_menu_item_widget):
- (ensure_menu_separator_widget):
- (ensure_check_menu_item_widget):
- (ensure_tree_header_cell_widget):
- (ensure_scrolled_window_widget):
- (moz_gtk_button_paint):
- (moz_gtk_init):
- (moz_gtk_button_get_inner_border):
- (moz_gtk_toggle_paint):
- (calculate_button_inner_rect):
- (calculate_arrow_rect):
- (moz_gtk_scrollbar_button_paint):
- (moz_gtk_scrollbar_thumb_paint):
- (moz_gtk_caret_paint):
- (moz_gtk_entry_paint):
- (moz_gtk_treeview_paint):
- (moz_gtk_tree_header_cell_paint):
- (moz_gtk_combo_box_paint):
- (moz_gtk_downarrow_paint):
- (moz_gtk_combo_box_entry_button_paint):
- (moz_gtk_toolbar_paint):
- (moz_gtk_tab_scroll_arrow_paint):
- (moz_gtk_menu_bar_paint):
- (moz_gtk_menu_item_paint):
- (moz_gtk_get_widget_border):
- (moz_gtk_get_combo_box_entry_button_size):
- (moz_gtk_get_tab_scroll_arrow_size):
- (moz_gtk_get_downarrow_size):
- (moz_gtk_images_in_menus):
- (moz_gtk_widget_paint):
- (moz_gtk_shutdown):
- * platform/gtk/gtkdrawing.h:
-
-2008-09-14 David Hyatt <hyatt@apple.com>
-
- Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
- painting. Mac and Gtk themes don't do anything and just let the
- underlying widget paint. Qt now uses the theme to paint. wx doesn't
- do anything yet.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::paint):
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::value):
- (WebCore::Scrollbar::visibleSize):
- (WebCore::Scrollbar::maximum):
- (WebCore::Scrollbar::lineStep):
- (WebCore::Scrollbar::pageStep):
- (WebCore::Scrollbar::pixelStep):
- (WebCore::Scrollbar::pressedPart):
- (WebCore::Scrollbar::hoveredPart):
- (WebCore::Scrollbar::theme):
- * platform/ScrollbarTheme.h:
- (WebCore::ScrollbarTheme::paint):
- (WebCore::ScrollbarTheme::scrollbarThickness):
- (WebCore::ScrollbarTheme::supportsControlTints):
- (WebCore::ScrollbarTheme::themeChanged):
- * platform/gtk/PlatformScrollBar.h:
- * platform/gtk/PlatformScrollBarGtk.cpp:
- * platform/mac/PlatformScrollBar.h:
- * platform/mac/PlatformScrollBarMac.mm:
- * platform/qt/PlatformScrollBar.h:
- * platform/qt/PlatformScrollBarQt.cpp:
- * platform/qt/ScrollbarThemeQt.cpp:
- (WebCore::styleOptionSlider):
- * platform/qt/ScrollbarThemeQt.h:
- (WebCore::ScrollbarThemeQt::paint):
- * platform/win/PlatformScrollBarSafari.cpp:
- (WebCore::PlatformScrollbar::paint):
- * platform/win/ScrollbarThemeSafari.h:
- (WebCore::ScrollbarThemeSafari::supportsControlTints):
- * platform/wx/PlatformScrollBar.h:
- * platform/wx/TemporaryLinkStubs.cpp:
- (PlatformScrollbar::~PlatformScrollbar):
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Qt build fix.
-
- * platform/qt/PlatformScrollBarQt.cpp:
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Remove extraneous semicolons.
-
- * bindings/scripts/CodeGeneratorObjC.pm:
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::charsetAttributeValue):
- (WebCore::HTMLScriptElement::typeAttributeValue):
- * platform/graphics/qt/GradientQt.cpp:
- (WebCore::Gradient::platformGradient):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintEllipsisBoxes):
- * svg/SVGPathSegList.cpp:
- (WebCore::SVGPathSegList::toPathData):
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Qt build fix.
-
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2008-09-14 Sam Weinig <sam@webkit.org>
-
- Qt build fix.
-
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::PlatformScrollbar::paint):
-
-2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Gtk build fix, not reviewed.
-
- * platform/gtk/PlatformScrollBarGtk.cpp:
- (PlatformScrollbar::PlatformScrollbar):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2008-09-13 Dave Hyatt <hyatt@apple.com>
-
- Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
- to set the dimensions of a scrollbar.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.h:
- * platform/gtk/PlatformScrollBar.h:
- * platform/gtk/PlatformScrollBarGtk.cpp:
- (PlatformScrollbar::setFrameGeometry):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/mac/PlatformScrollBarMac.mm:
- * platform/qt/PlatformScrollBarQt.cpp:
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::PlatformScrollbar::setFrameGeometry):
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::PlatformScrollbar::setFrameGeometry):
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupWndProc):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::updateScrollbars):
- * platform/wx/PlatformScrollBar.h:
- * platform/wx/TemporaryLinkStubs.cpp:
- (PlatformScrollbar::updateThumbProportion):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::positionOverflowControls):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::paintScrollbar):
-
-2008-09-13 Dave Hyatt <hyatt@apple.com>
-
- Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.h:
- * platform/gtk/PlatformScrollBar.h:
- * platform/gtk/PlatformScrollBarGtk.cpp:
- * platform/mac/PlatformScrollBar.h:
- * platform/mac/PlatformScrollBarMac.mm:
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- * platform/win/PlatformScrollBarWin.cpp:
- * platform/wx/PlatformScrollBar.h:
- * platform/wx/TemporaryLinkStubs.cpp:
- (PlatformScrollbar::~PlatformScrollbar):
-
-2008-09-13 Dave Hyatt <hyatt@apple.com>
-
- Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
- all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.h:
- * platform/gtk/PlatformScrollBar.h:
- * platform/gtk/PlatformScrollBarGtk.cpp:
- * platform/mac/PlatformScrollBar.h:
- * platform/mac/PlatformScrollBarMac.mm:
- * platform/win/PlatformScrollBarSafari.cpp:
- * platform/win/PlatformScrollBarWin.cpp:
- * platform/wx/PlatformScrollBar.h:
- * platform/wx/TemporaryLinkStubs.cpp:
- (PlatformScrollbar::~PlatformScrollbar):
-
-2008-09-13 Dave Hyatt <hyatt@apple.com>
-
- Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::~Scrollbar):
- * platform/ScrollBar.h:
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::PlatformScrollbar::~PlatformScrollbar):
- * platform/win/PlatformScrollBarSafari.cpp:
- (WebCore::PlatformScrollbar::~PlatformScrollbar):
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::PlatformScrollbar::~PlatformScrollbar):
-
-2008-09-13 David Hyatt <hyatt@apple.com>
-
- Move maximum() from Qt's PlatformScrollbar to be a cross-platform
- function on Scrollbar. Fixes Qt build bustage.
-
- Reviewed by Sam Weinig
-
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::orientation):
- (WebCore::Scrollbar::value):
- (WebCore::Scrollbar::maximum):
- * platform/qt/PlatformScrollBar.h:
-
-2008-09-13 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - use the LastResort font for missing glyphs instead of showing the
- primary font's missing glyph
-
- Test: platform/mac/fast/text/last-resort-font.html
-
- * platform/graphics/mac/FontCacheMac.mm:
- (WebCore::FontCache::getFontDataForCharacters): Changed to return the
- last resort font if a substitute font cannot be found.
- (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
- comment (the user's preferred standard font is included in the search
- thanks to code in FontCache::getFontData()) and changed to return the
- LastResort font.
-
-2008-09-13 Dave Hyatt <hyatt@apple.com>
-
- This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
- scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
- patches will move rendering and hit testing functionality into this class.
-
- Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
- implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
-
- Reviewed by Sam Weinig
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- * platform/ScrollBar.h:
- * platform/ScrollbarTheme.h: Added.
- (WebCore::ScrollbarTheme::~ScrollbarTheme):
- (WebCore::ScrollbarTheme::scrollbarThickness):
- (WebCore::ScrollbarTheme::themeChanged):
- * platform/gtk/ScrollbarThemeGtk.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
- (WebCore::ScrollbarThemeGtk::scrollbarThickness):
- * platform/gtk/ScrollbarThemeGtk.h: Added.
- * platform/mac/PlatformScrollBar.h:
- * platform/mac/ScrollbarThemeMac.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::):
- (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
- (WebCore::ScrollbarThemeMac::scrollbarThickness):
- * platform/mac/ScrollbarThemeMac.h: Added.
- * platform/qt/PlatformScrollBarQt.cpp:
- * platform/qt/ScrollbarThemeQt.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
- (WebCore::ScrollbarThemeQt::scrollbarThickness):
- * platform/qt/ScrollbarThemeQt.h: Added.
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- * platform/win/PlatformScrollBarWin.cpp:
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::calculatePositionAndSize):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::updateScrollbars):
- (WebCore::ScrollView::themeChanged):
- * platform/win/ScrollbarThemeSafari.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::):
- (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
- (WebCore::ScrollbarThemeSafari::scrollbarThickness):
- * platform/win/ScrollbarThemeSafari.h: Added.
- * platform/win/ScrollbarThemeWin.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
- (WebCore::ScrollbarThemeWin::scrollbarThickness):
- (WebCore::ScrollbarThemeWin::themeChanged):
- * platform/win/ScrollbarThemeWin.h: Added.
- * platform/wx/TemporaryLinkStubs.cpp:
- (ScrollbarTheme::nativeTheme):
- * rendering/RenderLayer.cpp:
- (WebCore::scrollCornerRect):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::calcHeight):
- (WebCore::RenderTextControl::calcPrefWidths):
-
-2008-09-13 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Timothy Hatcher.
-
- <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
-
-2008-09-13 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Timothy Hatcher.
-
- - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
-
- No regression test because the back/forward cache is disabled in DumpRenderTree
-
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::invalidateCounters): Bail out if the document
- is being destroyed.
-
-2008-09-13 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes for new methods recently introduced.
-
- * platform/graphics/wx/AffineTransformWx.cpp:
- (WebCore::AffineTransform::AffineTransform):
- (WebCore::AffineTransform::setMatrix):
- (WebCore::AffineTransform::setA):
- (WebCore::AffineTransform::setB):
- (WebCore::AffineTransform::setC):
- (WebCore::AffineTransform::setD):
- (WebCore::AffineTransform::setE):
- (WebCore::AffineTransform::setF):
- * platform/wx/LocalizedStringsWx.cpp:
- (WebCore::AXDefinitionListTermText):
- (WebCore::AXDefinitionListDefinitionText):
-
-2008-09-12 Dave Hyatt <hyatt@apple.com>
-
- Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
- up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
- "PlatformScrollbar."
-
- Reviewed by Sam Weinig
-
- * WebCore.vcproj/WebCore.vcproj:
- * editing/EditorCommand.cpp:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::selectCursor):
- (WebCore::EventHandler::handleMousePressEvent):
- (WebCore::EventHandler::handleMouseMoveEvent):
- * page/EventHandler.h:
- * page/MouseEventWithHitTestResults.cpp:
- (WebCore::MouseEventWithHitTestResults::scrollbar):
- * page/MouseEventWithHitTestResults.h:
- * page/gtk/EventHandlerGtk.cpp:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * page/mac/EventHandlerMac.mm:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * page/qt/EventHandlerQt.cpp:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * page/win/EventHandlerWin.cpp:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * page/wx/EventHandlerWx.cpp:
- (WebCore::EventHandler::passMousePressEventToScrollbar):
- * platform/PopupMenu.h:
- * platform/ScrollBar.cpp:
- (WebCore::Scrollbar::Scrollbar):
- (WebCore::Scrollbar::autoscrollTimerFired):
- (WebCore::Scrollbar::autoscrollPressedPart):
- (WebCore::Scrollbar::startTimerIfNeeded):
- (WebCore::Scrollbar::stopTimerIfNeeded):
- (WebCore::Scrollbar::pressedPartScrollDirection):
- (WebCore::Scrollbar::pressedPartScrollGranularity):
- * platform/ScrollBar.h:
- (WebCore::Scrollbar::handleMousePressEvent):
- (WebCore::Scrollbar::invalidatePart):
- (WebCore::Scrollbar::thumbUnderMouse):
- * platform/ScrollView.h:
- * platform/ScrollbarClient.h: Added.
- (WebCore::ScrollbarClient::~ScrollbarClient):
- * platform/gtk/ScrollViewGtk.cpp:
- (WebCore::ScrollView::scrollbarUnderMouse):
- * platform/qt/PlatformScrollBar.h:
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::scrollbarPart):
- (WebCore::PlatformScrollbar::handleMouseMoveEvent):
- (WebCore::PlatformScrollbar::handleMouseOutEvent):
- (WebCore::PlatformScrollbar::handleMousePressEvent):
- (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
- * platform/qt/ScrollViewQt.cpp:
- (WebCore::ScrollView::scrollbarUnderMouse):
- (WebCore::ScrollView::wheelEvent):
- * platform/win/PlatformScrollBar.h:
- * platform/win/PlatformScrollBarSafari.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::scrollbarUnderMouse):
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::setScrollbar):
- * rendering/HitTestResult.h:
- (WebCore::HitTestResult::scrollbar):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::hitTestOverflowControls):
- * rendering/RenderLayer.h:
- * rendering/RenderListBox.h:
-
-2008-09-12 Steve Falkenburg <sfalken@apple.com>
-
- Fix Mac build.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::getTransformOperationType):
-
-2008-09-12 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Make transform animation behavior match spec
- https://bugs.webkit.org/show_bug.cgi?id=20770
-
- Tests: transitions/transform-op-list-match.html
- transitions/transform-op-list-no-match.html
-
- * css/CSSStyleSelector.cpp:
- * css/CSSStyleSelector.h:
- * page/animation/AnimationBase.cpp:
- * page/animation/AnimationBase.h:
- * page/animation/ImplicitAnimation.cpp:
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- * page/animation/KeyframeAnimation.h:
- * rendering/RenderLayer.cpp:
- * rendering/style/RenderStyle.cpp:
- * rendering/style/RenderStyle.h:
-
-2008-09-12 Ojan Vafai <ojan@chromium.org>
-
- Properly escape contents of links added to the inspector.
- For now, just build the link with the DOM and get the
- outerHTML. Eventually, we probably just want to do
- this entirely with the DOM.
-
- Reviewed by Timothy Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=20684
-
- * manual-tests/inspector/escape-links.html: Added.
- * page/inspector/StylesSidebarPane.js:
- * page/inspector/inspector.js:
- * page/inspector/utilities.js:
-
-2008-09-12 Adele Peterson <adele@apple.com>
-
- Reviewed by John Sullivan and Kevin McCullough.
-
- Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
- Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
- cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
+2009-06-18 Dirk Schulze <krit@webkit.org>
-2008-09-12 Kevin McCullough <kmccullough@apple.com>
+ Reviewed by Oliver Hunt.
- RS by Tim .
+ Share code between filterEffects
+ [https://bugs.webkit.org/show_bug.cgi?id=26479]
- Re-introducing the code since it was not the cause of the crash.
- See r36343.
+ Share more code of filter effects. The imageBuffer creation can move to
+ FilterEffect ant every effect asks for the GraphicsContext. Move the
+ drawingRect calculation to FilterEffect.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::canBeProgramaticallyScrolled):
- * rendering/RenderObject.h:
+ * platform/graphics/filters/FilterEffect.cpp:
+ (WebCore::FilterEffect::calculateDrawingRect):
+ (WebCore::FilterEffect::getEffectContext):
+ * platform/graphics/filters/FilterEffect.h:
+ * platform/graphics/filters/SourceGraphic.cpp:
+ (WebCore::SourceGraphic::apply):
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::apply):
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ (WebCore::FEOffset::apply):
-2008-09-12 Chris Marrin <cmarrin@apple.com>
+2009-06-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26499
+
+ Support hardware-accelerationed rendering of video elements.
- When changing one animation in a list, don't reset other animations
- https://bugs.webkit.org/show_bug.cgi?id=20675
-
- Test: animations/change-one-anim.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::getNumProperties):
- * page/animation/AnimationBase.h:
- * page/animation/AnimationController.cpp:
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateKeyframeAnimations):
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- * page/animation/KeyframeAnimation.cpp:
- * page/animation/KeyframeAnimation.h:
- (WebCore::KeyframeAnimation::setIndex):
-
-2008-09-12 Brady Eidson <beidson@apple.com>
-
- Reviewed by Mitz Pettel
-
- Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
+ (WebCore::HTMLMediaElement::mediaPlayerRepaint):
+ Just move these methods to group the render-related methods together.
+
+ (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
+ Call out method to ask the RenderLayerCompositor if presentation of this video
+ can be acclerated. It might say no, if, for example, the video has a reflection.
+
+ (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
+ Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.
+
+ * html/HTMLMediaElement.h:
+ Reordered the rendering-related methods, and added two methods related to video
+ acceleration.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::acceleratedRenderingStateChanged):
+ Called by the rendering system when it determines that the video must go into, or
+ fall off of the hardware-accelerated path.
+
+ (WebCore::MediaPlayer::supportsAcceleratedRendering):
+ Method to say whether the media engine supports accelerated rendering.
+
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayerClient::mediaPlayerRepaint):
+ (WebCore::MediaPlayerClient::mediaPlayerSizeChanged):
+ Moved.
+
+ (WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
+ (WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
+ New methods to ask the client if the rendering system can support accelerated
+ rendering, and to get a GraphicsLayer to plug the movie layer into.
+
+ * platform/graphics/MediaPlayerPrivate.h:
+ (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering):
+ (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged):
+ Forwarding methods from MediaPlayer.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
- Subresources can never be created from nil data, but there is always a MainResource, whether
- or not there's any data. So in the case where the main resource has no data, fake it for the
- sake of creating the ArchiveResource.
-
-2008-09-12 Dave Hyatt <hyatt@apple.com>
-
- Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
- scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
- Remove all the isWidget and hasPlatformScrollbars guards.
-
- Reviewed by Tim Hatcher
-
- * platform/ScrollBar.h:
- * platform/gtk/PlatformScrollBar.h:
- * platform/mac/PlatformScrollBar.h:
- * platform/qt/PlatformScrollBar.h:
- * platform/win/PlatformScrollBar.h:
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
- * platform/wx/PlatformScrollBar.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovieLayer):
+ (WebCore::MediaPlayerPrivate::destroyQTMovieLayer):
+ Methods to create and destroy the QTMovieLayer.
+
+ (WebCore::MediaPlayerPrivate::currentRenderingMode):
+ (WebCore::MediaPlayerPrivate::preferredRenderingMode):
+ Methods to clarify the code that decides which of the 3 rendering modes to use.
+
+ (WebCore::MediaPlayerPrivate::setUpVideoRendering):
+ Changed to use the new rendering mode methods.
+
+ (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
+ Destroy the layer if we have one.
+
+ (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
+ Small utility method.
+
+ (WebCore::MediaPlayerPrivate::updateStates):
+ Move the call to setUpVideoRendering() to before we send out the state notifications,
+ so that we will have created the rendering objects already.
+
+ (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
+ Return true if we have QTMovieLayer.
+
+ (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
+ We've been told that we went into or out of accelerated mode; maybe reset
+ the renderer, and set the layer if we have to.
+
* rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::horizontalScrollbarWidget):
- (WebCore::RenderLayer::verticalScrollbarWidget):
- (WebCore::RenderLayer::createScrollbar):
- (WebCore::RenderLayer::destroyScrollbar):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::~RenderListBox):
- (WebCore::RenderListBox::updateFromElement):
- (WebCore::RenderListBox::isPointInOverflowControl):
-
-2008-09-12 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
-
- * page/animation/AnimationController.cpp:
- * page/animation/AnimationController.h:
- * page/animation/CompositeAnimation.cpp:
- * page/animation/CompositeAnimation.h:
- * page/animation/ImplicitAnimation.cpp:
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- * page/animation/KeyframeAnimation.h:
-
-2008-09-11 Timothy Hatcher <timothy@apple.com>
-
- Add a renderedImage method to DOMNode to get an image
- of the rendering for the node and it's descendants.
-
- <rdar://problem/5849349> Would like API to create
- an image for a DOM node
-
- Reviewed by Oliver Hunt.
-
- * bindings/objc/DOM.mm:
- (-[DOMNode renderedImage]): Call Frame::nodeImage.
- * bindings/objc/DOMPrivate.h:
- * page/Frame.h:
- * page/mac/FrameMac.mm:
- (WebCore::Frame::nodeImage):
-
-2008-09-08 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt
-
- Need to support comma separated list of key times in keyframes selectors
- https://bugs.webkit.org/show_bug.cgi?id=20680
-
- Test: animations/keyframes-comma-separated.html
-
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::createKeyframeRule):
- * css/CSSParser.h:
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::addKeyframeStyle):
- * css/WebKitCSSKeyframeRule.cpp:
- (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
- (WebCore::WebKitCSSKeyframeRule::cssText):
- (WebCore::WebKitCSSKeyframeRule::parseKeyString):
- * css/WebKitCSSKeyframeRule.h:
- (WebCore::WebKitCSSKeyframeRule::keyText):
- (WebCore::WebKitCSSKeyframeRule::setKeyText):
- (WebCore::WebKitCSSKeyframeRule::getKeys):
- * css/WebKitCSSKeyframesRule.cpp:
- (WebCore::WebKitCSSKeyframesRule::append):
- (WebCore::WebKitCSSKeyframesRule::insertRule):
- (WebCore::WebKitCSSKeyframesRule::deleteRule):
- (WebCore::WebKitCSSKeyframesRule::findRule):
- (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
- * css/WebKitCSSKeyframesRule.h:
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::blendProperties):
-
-2008-09-11 Kevin McCullough <kmccullough@apple.com>
-
- RS by Tim.
-
- Reverting because this caused a crash.
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::canBeProgramaticallyScrolled):
- (WebCore::RenderObject::hasScrollableView):
- * rendering/RenderObject.h:
-
-2008-09-11 Dean Jackson <dino@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Fix assertion on transition property "none"
- https://bugs.webkit.org/show_bug.cgi?id=20751
-
- Test: transitions/transition-end-event-set-none.html
-
- * page/animation/CompositeAnimation.cpp:
- (WebCore::CompositeAnimation::updateTransitions):
-
-2008-09-11 David Smith <catfish.man@gmail.com>
-
- Rubber-stamped by mitzpettel.
-
- Remove an accidentally added extra file.
-
- * WebCore: Removed.
-
-2008-09-11 David Smith <catfish.man@gmail.com>
-
- Reviewed by Darin
-
- https://bugs.webkit.org/show_bug.cgi?id=20180
-
- This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
-
- * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
- * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
- * dom/Element.cpp: include NodeRenderStyle.h
- * dom/Node.cpp: Remove the definition of renderStyle()
- (WebCore::Node::nonRendererRenderStyle):
- * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
- * dom/NodeRenderStyle.h: Added.
- (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
- * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
- * html/HTMLOptGroupElement.h:
- (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
- * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
- * html/HTMLOptionElement.h:
- (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
- * rendering/RenderListBox.cpp: include NodeRenderStyle.h
- * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
- * svg/SVGUseElement.cpp: include NodeRenderStyle.h
-
-2008-09-11 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Adele and Tim.
-
- <rdar://problem/6100597> REGRESSION: clicking on search results in Web
- Inspector does not scroll to the line of the results (20167)
- - This was put in by Max to fix auto scrolling but is not correct for
- the whole web: rdar://problem/6213098
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::canBeProgramaticallyScrolled):
- * rendering/RenderObject.h:
-
-2008-09-11 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin
-
- <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
-
- Test: accessibility/frame-with-title.html
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityDescription):
-
-2008-09-11 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Simon.
-
- Fixed stroke() and strokeRect() to support gradients
- and patterns on Qt.
-
- [Qt] Canvas stroke don't work for gradients and patterns
- [https://bugs.webkit.org/show_bug.cgi?id=20749]
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::strokeRect):
-
-2008-09-11 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Simon.
-
- https://bugs.webkit.org/show_bug.cgi?id=20729
-
- Fixed canvas gradients for Qt
-
- [Qt] Canvas gradients don't work as expected
- [https://bugs.webkit.org/show_bug.cgi?id=20729]
-
- * platform/graphics/qt/GradientQt.cpp:
- (WebCore::Gradient::platformGradient):
-
-2008-09-11 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Simon.
-
- https://bugs.webkit.org/show_bug.cgi?id=20568
+ (WebCore::RenderLayer::rendererContentChanged):
+ We may need to udpate compositing layers if the video went into accelerated mode.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::canUseDirectCompositing):
+ Add smarts to deal with video, which allows us to avoid extra backing store.
+
+ (WebCore::RenderLayerBacking::contentsBox):
+ Use the videoBox to use the content layer for video layers.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ Poke the RenderVideo if the state changed.
+
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ Handle an edge case when the video element itself is a stacking context
+ because of opacity or transform.
+
+ (WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
+ (WebCore::RenderLayerCompositor::requiresCompositingLayer):
+ (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
+ Allow video to throw us into compositing mode if the media engine supports it.
+
+ * rendering/RenderLayerCompositor.h:
+ New methods related to video.
+
+ * rendering/RenderVideo.h:
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::updatePlayer):
+ Call rendererContentChanged() to give the compositor a change to throw the video into
+ compositing mode.
+
+ (WebCore::RenderVideo::supportsAcceleratedRendering):
+ (WebCore::RenderVideo::acceleratedRenderingStateChanged):
+ (WebCore::RenderVideo::videoGraphicsLayer):
+ Methods to allow the MediaPlayer to do rendering-related stuff via the media element.
- Add support for patterns to Qt.
+2009-06-18 Rob Buis <rwlbuis@gmail.com>
- * platform/graphics/qt/PatternQt.cpp:
- (WebCore::Pattern::createPlatformPattern):
+ Reviewed by Niko.
-2008-09-10 Dan Bernstein <mitz@apple.com>
+ https://bugs.webkit.org/show_bug.cgi?id=26385
+ Root SVG element is not checked on requiredFeatures, requiredExtension like other elements
- Reviewed by Sam Weinig.
+ Also do the isValid check for outer <svg>.
- - clean up AnimationBase
+ Test: svg/custom/outer-svg-unknown-feature.svg
- * page/animation/AnimationBase.cpp:
- * page/animation/AnimationBase.h:
- * page/animation/CompositeAnimation.cpp:
- * page/animation/ImplicitAnimation.cpp:
- * page/animation/ImplicitAnimation.h:
- * page/animation/KeyframeAnimation.cpp:
- * page/animation/KeyframeAnimation.h:
+ * svg/SVGDocument.cpp:
+ (WebCore::SVGDocument::childShouldCreateRenderer):
+ * svg/SVGDocument.h:
-2008-09-10 Alexey Proskuryakov <ap@webkit.org>
+2009-06-18 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=20741
- REGRESSION: ISO-8859-8-I encoding is registered incorrectly
-
- Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
- check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
- tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
-
- I also found and fixed a potential crasher for non-Mac ports.
-
- Tests: fast/encoding/hebrew/8859-8-e.html
- fast/encoding/hebrew/8859-8-i.html
- fast/encoding/hebrew/8859-8.html
- fast/encoding/hebrew/csISO88598I.html
- fast/encoding/hebrew/hebrew.html
- fast/encoding/hebrew/iso-ir-138.html
- fast/encoding/hebrew/logical.html
-
- * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
- (case-insensitively, because different versions of ICU report this MIME name in different
- case).
-
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
- (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
- There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
- with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
- we also support these via TEC (which we should stop doing), but on Windows, this would
- likely crash.
-
-2008-09-09 Dave Hyatt <hyatt@apple.com
-
- Resurrect PlatformScrollbarWin.
-
- Reviewed by Adam Roben
-
- * WebCore.vcproj/WebCore.vcproj:
- * platform/win/PlatformScrollBarWin.cpp:
- (WebCore::isRunningOnVistaOrLater):
- (WebCore::checkAndInitScrollbarTheme):
- (WebCore::PlatformScrollbar::PlatformScrollbar):
- (WebCore::PlatformScrollbar::invalidateTrack):
- (WebCore::PlatformScrollbar::invalidatePart):
- (WebCore::PlatformScrollbar::paint):
- (WebCore::PlatformScrollbar::hasButtons):
- (WebCore::PlatformScrollbar::hasThumb):
- (WebCore::PlatformScrollbar::backButtonRect):
- (WebCore::PlatformScrollbar::forwardButtonRect):
- (WebCore::PlatformScrollbar::trackRect):
- (WebCore::PlatformScrollbar::gripperRect):
- (WebCore::PlatformScrollbar::thumbLength):
- (WebCore::PlatformScrollbar::paintButton):
- (WebCore::PlatformScrollbar::paintTrack):
- (WebCore::PlatformScrollbar::paintThumb):
- (WebCore::PlatformScrollbar::paintGripper):
- (WebCore::PlatformScrollbar::hitTest):
- (WebCore::PlatformScrollbar::handleMouseMoveEvent):
- (WebCore::PlatformScrollbar::handleMouseOutEvent):
- (WebCore::PlatformScrollbar::themeChanged):
-
-2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20759: Remove MacroAssembler
- <https://bugs.webkit.org/show_bug.cgi?id=20759>
-
- Make the necessary changes to ForwardingHeaders to remove
- MacroAssembler.
-
- * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
- * ForwardingHeaders/masm/MacroAssembler.h: Removed.
- * ForwardingHeaders/masm/X86Assembler.h: Added.
-
-2008-09-09 Alp Toker <alp@nuanti.com>
-
- Reviewed by Dave Hyatt.
-
- https://bugs.webkit.org/show_bug.cgi?id=16792
- [GTK] Fails to render Japanese/Chinese text with simple path
-
- https://bugs.webkit.org/show_bug.cgi?id=16942
- [GTK] Oddities in font selection and fall back
-
- https://bugs.webkit.org/show_bug.cgi?id=16862
- [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
-
- GTK+ font fixes and enhancements.
-
- Implement font fallback for the simple FontConfig-based text path and
- improve the Pango-based complex text path to make use of requested
- font properties and available font selection.
-
- Add text shadow support to the complex path.
-
- * platform/graphics/gtk/FontCacheGtk.cpp:
- (WebCore::FontCache::getFontDataForCharacters):
- (WebCore::FontCache::getSimilarFontPlatformData):
- * platform/graphics/gtk/FontGtk.cpp:
- (WebCore::setPangoAttributes):
- (WebCore::Font::drawComplexText):
- (WebCore::getDefaultPangoLayout):
- (WebCore::Font::floatWidthForComplexText):
- (WebCore::Font::offsetForPositionForComplexText):
- (WebCore::Font::selectionRectForComplexText):
- * platform/graphics/gtk/FontPlatformData.h:
- (WebCore::FontPlatformData::FontPlatformData):
- (WebCore::FontPlatformData::hash):
- * platform/graphics/gtk/FontPlatformDataGtk.cpp:
- (WebCore::FontPlatformData::FontPlatformData):
- * platform/graphics/gtk/SimpleFontDataGtk.cpp:
- (WebCore::SimpleFontData::platformDestroy):
-
-2008-09-09 Dave Hyatt <hyatt@apple.com>
-
- Make the Windows classic case work again. Overlap in slider constants and other constants broke
- the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
- value to make sure it's really a slider thumb to resolve this conflict.
-
- Reviewed by Adam Roben
-
- * rendering/RenderThemeWin.cpp:
- (WebCore::drawControl):
-
-2008-09-05 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Need to handle the case when 0% or 100% keyframe is omitted
- https://bugs.webkit.org/show_bug.cgi?id=20679
-
- Tests: animations/keyframes-from-missing.html
- animations/keyframes-to-missing.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::addKeyframeStyle):
-
-2008-09-09 Dave Hyatt <hyatt@apple.com>
-
- Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
- RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
- merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
- what changes have been made as compared with the old RenderThemeWin).
-
- Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
- text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
- vs. printer advancement rounding).
-
- Reviewed by Adam/Sam
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * platform/graphics/Icon.h:
- (WebCore::Icon::create):
- * rendering/RenderThemeWin.cpp:
- (WebCore::RenderThemeWin::RenderThemeWin):
- (WebCore::RenderThemeWin::~RenderThemeWin):
- (WebCore::RenderThemeWin::buttonTheme):
- (WebCore::RenderThemeWin::textFieldTheme):
- (WebCore::RenderThemeWin::menuListTheme):
- (WebCore::RenderThemeWin::sliderTheme):
- (WebCore::RenderThemeWin::close):
- (WebCore::RenderThemeWin::themeChanged):
- (WebCore::RenderThemeWin::supportsHover):
- (WebCore::fillFontDescription):
- (WebCore::RenderThemeWin::systemFont):
- (WebCore::RenderThemeWin::supportsFocus):
- (WebCore::RenderThemeWin::determineClassicState):
- (WebCore::RenderThemeWin::determineState):
- (WebCore::RenderThemeWin::determineSliderThumbState):
- (WebCore::RenderThemeWin::getClassicThemeData):
- (WebCore::RenderThemeWin::getThemeData):
- (WebCore::drawControl):
- (WebCore::RenderThemeWin::paintButton):
- (WebCore::RenderThemeWin::paintTextField):
- (WebCore::RenderThemeWin::paintMenuList):
- (WebCore::RenderThemeWin::adjustMenuListStyle):
- (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
- (WebCore::RenderThemeWin::paintMenuListButton):
- (WebCore::RenderThemeWin::paintSliderTrack):
- (WebCore::RenderThemeWin::paintSliderThumb):
- (WebCore::RenderThemeWin::adjustSliderThumbSize):
- (WebCore::RenderThemeWin::paintSearchField):
- (WebCore::RenderThemeWin::adjustSearchFieldStyle):
- (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
- (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
- (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
- (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
- (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
- (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
- (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
- * rendering/RenderThemeWin.h:
- (WebCore::ThemeData::ThemeData):
- (WebCore::RenderThemeWin::paintSearchFieldDecoration):
- (WebCore::RenderThemeWin::adjustButtonStyle):
- (WebCore::RenderThemeWin::adjustTextFieldStyle):
- (WebCore::RenderThemeWin::adjustTextAreaStyle):
-
-2008-09-09 Dean Jackson <dino@apple.com>
-
- Reviewed by Sam Weinig.
-
- Document::createEvent missing cases for animation and
- transition events.
- https://bugs.webkit.org/show_bug.cgi?id=20734
-
- Test: transitions/transition-end-event-create.html
- Test: animations/animation-events-create.html
+ - fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on
+ apple.com cuts entered text
- * dom/Document.cpp:
- (WebCore::Document::createEvent):
- - add the two cases
-
-2008-09-09 Dan Bernstein <mitz@apple.com>
+ Test: fast/forms/search-vertical-alignment.html
- - Tiger build fix
-
- * WebCore.Tiger.exp:
- * WebCore.base.exp:
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm:
-
-2008-09-09 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::layout): Vertically center the
+ the search field's inner block.
- - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
+2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>
- * WebCore.Tiger.exp:
- * WebCore.base.exp:
- * platform/graphics/SimpleFontData.h:
- * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
- (WebCore::GlyphPage::fill):
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::initFontData):
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformDestroy):
- * platform/mac/WebCoreSystemInterface.h:
- * platform/mac/WebCoreSystemInterface.mm:
+ Reviewed by Simon Hausmann.
-2008-09-09 Kevin McCullough <kmccullough@apple.com>
+ Fix compilation with Symbian WINSCW compiler, which produced
+ multiple definitions of the CSSPrimitiveValue conversion operators.
- Reviewed by Tim.
+ It turns out that they are defined inline but not declared inline.
- <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
- breakpoints inside eval.
+ Adding the inline keyword to the declaration fixes the build.
- * page/inspector/inspector.js:
+ * css/CSSPrimitiveValue.h:
-2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
+2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>
- Reviewed by Simon.
+ Reviewed by Simon Hausman.
- Fix compilation of the Qt port with disabled plugins on Windows
+ Clarify in docs how to compile with debug information.
* WebCore.pro:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::PluginView):
- * plugins/PluginView.h:
-
-2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
-
- Reviewed by Alexey Proskuryakov.
-
- Try MIME charset names before trying IANA names
- ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
-
- With this change, shorter and more widely used names (preferred MIME
- names) are returned by document.charset, document.characterSet,
- document.inputEncoding rather than IANA names. This helps
- fixing bug 18085 in addition to web developers who are more familiar
- with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
- returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
- ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
- Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
- used, the former is still recognized as aliases to the latter so that
- there's very little, if any, to worry about.
-
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::registerExtendedEncodingNames):
-
-2008-09-08 Sam Weinig <sam@webkit.org>
-
- Reviewed by Maciej Stachowiak and Oliver Hunt.
-
- Add forwarding headers.
-
- * ForwardingHeaders/wtf/HashFunctions.h: Added.
-
-2008-09-05 Dean Jackson <dino@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Update grammar so that we can add a keyframe rule via the DOM.
- https://bugs.webkit.org/show_bug.cgi?id=20613
-
- * css/CSSGrammar.y:
- * css/tokenizer.flex:
-
-2008-09-08 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
- Allow <br> for simple UA stylesheet. Editing code generates them. It does not
- actually show up in any of the default stylesheets.
+2009-06-18 Jakub Wieczorek <faw217@gmail.com>
- * css/CSSStyleSelector.cpp:
- (WebCore::elementCanUseSimpleDefaultStyle):
-
-2008-09-08 Dimitri Glazkov <dglazkov@google.com>
-
- Reviewed by Dan Bernstein.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=20237
- Zero width and space characters are displayed incorrectly if not contained in a fallback font
-
- Adds an extra check for Object Replacement Character (U+FFFC) to address
- the issue with fast/text/zero-width-characters.html test when run
- with Windows system default fonts.
-
- * platform/graphics/Font.h:
- (WebCore::Font::treatAsZeroWidthSpace):
-
-2008-09-08 Dean Jackson <dino@apple.com>
-
- Reviewed by Sam Weinig.
-
- Code style issue I forgot to fix from previous commit.
-
- * platform/graphics/AffineTransform.cpp:
- (WebCore::AffineTransform::blend):
-
-2008-09-08 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Sam Weinig
-
- - Animation of -webkit-transform matrix() function should not do linear interpolation
- https://bugs.webkit.org/show_bug.cgi?id=20667
-
- Test: animations/matrix-anim.html
-
- * ChangeLog:
- * platform/graphics/AffineTransform.cpp:
- (WebCore::affineTransformDecompose):
- (WebCore::affineTransformCompose):
- (WebCore::AffineTransform::blend):
- * platform/graphics/AffineTransform.h:
- * rendering/style/RenderStyle.cpp:
- (WebCore::MatrixTransformOperation::blend):
-
-2008-09-08 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20668
- multipart/form-data does not always include Content-type for submitted files
+ Reviewed by Simon Hausmann.
- Cannot be tested with DRT or manual tests.
+ [Qt] When writing an URL to the clipboard, save the corresponding title
+ in the mime data as well.
- * platform/MIMETypeRegistry.cpp:
- (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
- (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
- unknown extensions, not just missing ones.
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::writeURL):
-2008-09-08 Simon Hausmann <hausmann@webkit.org>
+2009-06-18 Jakub Wieczorek <faw217@gmail.com>
- Build fix for the Qt/Windows build, define USE_JSC to
- enable the WebCore::String -> JSC::UString operator that
- MSVC insists on seeing
+ [Qt] Fix build. Add HTMLDataGridElement.
* WebCore.pro:
-2008-09-08 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Maciej.
-
- <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
-
- In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
- page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
-
- Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
-
- * bindings/js/JSDOMWindowBase.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::commitProvisionalLoad):
-
-2008-09-07 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Hyatt.
-
- Don't leak the simple stylesheet.
- Also call RenderTheme::adjustDefaultStyleSheet() in right place.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::loadFullDefaultStyle):
- (WebCore::loadSimpleDefaultStyle):
- (WebCore::CSSStyleSelector::styleForElement):
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Oliver Hunt.
-
- Bug 20711: Change KJS prefix on preprocessor macros to JSC
- <https://bugs.webkit.org/show_bug.cgi?id=20711>
-
- * bindings/js/JSEventTargetBase.h:
- * bindings/js/JSHTMLInputElementBase.cpp:
- * bindings/js/JSHTMLInputElementBase.h:
- * bindings/scripts/CodeGeneratorJS.pm:
-
-2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Reviewed by Maciej Stachowiak.
-
- Bug 20704: Replace the KJS namespace
- <https://bugs.webkit.org/show_bug.cgi?id=20704>
-
- Rename the KJS namespace to JSC. There are still some uses of KJS in the
- names of JNI functions, and I will check if these are safe to change
- as well.
-
- * WebCore.base.exp:
- * bindings/js/GCController.cpp:
- * bindings/js/JSAttrCustom.cpp:
- * bindings/js/JSAudioConstructor.cpp:
- * bindings/js/JSAudioConstructor.h:
- (WebCore::JSAudioConstructor::classInfo):
- * bindings/js/JSCSSRuleCustom.cpp:
- * bindings/js/JSCSSStyleDeclarationCustom.cpp:
- * bindings/js/JSCSSValueCustom.cpp:
- * bindings/js/JSCanvasPixelArrayCustom.cpp:
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- * bindings/js/JSClipboardCustom.cpp:
- * bindings/js/JSConsoleCustom.cpp:
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementCallback.h:
- (WebCore::JSCustomSQLStatementCallback::create):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.h:
- (WebCore::JSCustomSQLStatementErrorCallback::create):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.h:
- (WebCore::JSCustomSQLTransactionCallback::create):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.h:
- (WebCore::JSCustomSQLTransactionErrorCallback::create):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.h:
- (WebCore::JSCustomVoidCallback::create):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::create):
- * bindings/js/JSCustomXPathNSResolver.h:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::dispatchEvent):
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::jsOwnedStringOrNull):
- * bindings/js/JSDOMBinding.h:
- (WebCore::DOMObject::DOMObject):
- (WebCore::cacheDOMObject):
- (WebCore::cacheSVGDOMObject):
- (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
- (WebCore::toJS):
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- (WebCore::JSDOMWindowBase::classInfo):
- (WebCore::JSDOMWindowBase::d):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::getPropertyAttributes):
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::asJSDOMWindow):
- (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- (WebCore::JSDOMWindow::customPut):
- (WebCore::JSDOMWindowBase::allowsAccessFrom):
- (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::getPropertyAttributes):
- * bindings/js/JSDOMWindowShell.h:
- (WebCore::JSDOMWindowShell::classInfo):
- * bindings/js/JSDatabaseCustom.cpp:
- * bindings/js/JSDocumentCustom.cpp:
- * bindings/js/JSDocumentFragmentCustom.cpp:
- * bindings/js/JSElementCustom.cpp:
- * bindings/js/JSEventCustom.cpp:
- * bindings/js/JSEventListener.cpp:
- * bindings/js/JSEventListener.h:
- (WebCore::JSUnprotectedEventListener::create):
- (WebCore::JSEventListener::create):
- * bindings/js/JSEventTargetBase.cpp:
- * bindings/js/JSEventTargetBase.h:
- (WebCore::JSEventTargetBase::getValueProperty):
- (WebCore::JSEventTargetBase::putValueProperty):
- (WebCore::JSEventTargetBase::getOwnPropertySlot):
- (WebCore::JSEventTargetBase::put):
- (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
- (WebCore::JSEventTargetPrototype::self):
- (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
- (WebCore::JSEventTargetPrototype::classInfo):
- * bindings/js/JSEventTargetNode.cpp:
- * bindings/js/JSEventTargetNode.h:
- (WebCore::JSEventTargetNode::getOwnPropertySlot):
- (WebCore::JSEventTargetNode::getValueProperty):
- (WebCore::JSEventTargetNode::put):
- (WebCore::JSEventTargetNode::putValueProperty):
- * bindings/js/JSHTMLAllCollection.h:
- (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- (WebCore::JSHTMLAllCollection::toBoolean):
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- * bindings/js/JSHTMLCollectionCustom.cpp:
- * bindings/js/JSHTMLDocumentCustom.cpp:
- * bindings/js/JSHTMLElementCustom.cpp:
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- * bindings/js/JSHTMLFormElementCustom.cpp:
- * bindings/js/JSHTMLFrameElementCustom.cpp:
- * bindings/js/JSHTMLFrameSetElementCustom.cpp:
- * bindings/js/JSHTMLIFrameElementCustom.cpp:
- * bindings/js/JSHTMLInputElementBase.cpp:
- (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
- (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
- * bindings/js/JSHTMLInputElementBase.h:
- (WebCore::JSHTMLInputElementBase::classInfo):
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- * bindings/js/JSHTMLOptionElementConstructor.cpp:
- * bindings/js/JSHTMLOptionElementConstructor.h:
- (WebCore::JSHTMLOptionElementConstructor::classInfo):
- * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- * bindings/js/JSHTMLSelectElementCustom.cpp:
- (WebCore::selectIndexSetter):
- (WebCore::JSHTMLSelectElement::indexSetter):
- * bindings/js/JSHTMLSelectElementCustom.h:
- * bindings/js/JSHistoryCustom.cpp:
- * bindings/js/JSImageConstructor.cpp:
- * bindings/js/JSImageConstructor.h:
- (WebCore::JSImageConstructor::classInfo):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- * bindings/js/JSInspectedObjectWrapper.h:
- (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
- (WebCore::JSInspectedObjectWrapper::classInfo):
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- * bindings/js/JSInspectorCallbackWrapper.h:
- (WebCore::JSInspectorCallbackWrapper::classInfo):
- (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- * bindings/js/JSLocationCustom.cpp:
- * bindings/js/JSMimeTypeArrayCustom.cpp:
- * bindings/js/JSNSResolver.cpp:
- * bindings/js/JSNSResolver.h:
- (WebCore::JSNSResolver::create):
- * bindings/js/JSNamedNodeMapCustom.cpp:
- * bindings/js/JSNamedNodesCollection.cpp:
- (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
- * bindings/js/JSNamedNodesCollection.h:
- (WebCore::JSNamedNodesCollection::classInfo):
- * bindings/js/JSNavigatorCustom.cpp:
- * bindings/js/JSNodeCustom.cpp:
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/JSNodeFilterCondition.h:
- (WebCore::JSNodeFilterCondition::create):
- * bindings/js/JSNodeFilterCustom.cpp:
- * bindings/js/JSNodeIteratorCustom.cpp:
- * bindings/js/JSNodeListCustom.cpp:
- * bindings/js/JSPluginArrayCustom.cpp:
- * bindings/js/JSPluginCustom.cpp:
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::getRuntimeObject):
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::construct):
- (WebCore::JSQuarantinedObjectWrapper::call):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
- (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
- (WebCore::JSQuarantinedObjectWrapper::className):
- * bindings/js/JSRGBColor.cpp:
- * bindings/js/JSRGBColor.h:
- (WebCore::JSRGBColor::classInfo):
- * bindings/js/JSSQLResultSetRowListCustom.cpp:
- * bindings/js/JSSQLTransactionCustom.cpp:
- * bindings/js/JSSVGLazyEventListener.cpp:
- * bindings/js/JSSVGLazyEventListener.h:
- * bindings/js/JSSVGLengthCustom.cpp:
- * bindings/js/JSSVGMatrixCustom.cpp:
- (WebCore::JSSVGMatrix::inverse):
- (WebCore::JSSVGMatrix::rotateFromVector):
- * bindings/js/JSSVGPathSegCustom.cpp:
- * bindings/js/JSSVGPathSegListCustom.cpp:
- (WebCore::JSSVGPathSegList::initialize):
- (WebCore::JSSVGPathSegList::getItem):
- (WebCore::JSSVGPathSegList::insertItemBefore):
- (WebCore::JSSVGPathSegList::replaceItem):
- (WebCore::JSSVGPathSegList::removeItem):
- (WebCore::JSSVGPathSegList::appendItem):
- * bindings/js/JSSVGPointListCustom.cpp:
- * bindings/js/JSSVGTransformListCustom.cpp:
- * bindings/js/JSStorageCustom.cpp:
- * bindings/js/JSStyleSheetCustom.cpp:
- * bindings/js/JSStyleSheetListCustom.cpp:
- * bindings/js/JSTextCustom.cpp:
- * bindings/js/JSTreeWalkerCustom.cpp:
- * bindings/js/JSXMLHttpRequestConstructor.cpp:
- * bindings/js/JSXMLHttpRequestConstructor.h:
- (WebCore::JSXMLHttpRequestConstructor::classInfo):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- * bindings/js/JSXSLTProcessorConstructor.cpp:
- * bindings/js/JSXSLTProcessorConstructor.h:
- (WebCore::JSXSLTProcessorConstructor::classInfo):
- * bindings/js/JSXSLTProcessorCustom.cpp:
- * bindings/js/ScheduledAction.cpp:
- * bindings/js/ScheduledAction.h:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::attachDebugger):
- (WebCore::ScriptController::windowScriptNPObject):
- * bindings/js/ScriptController.h:
- * bindings/js/ScriptControllerGtk.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- (WebCore::ScriptController::windowScriptObject):
- (WebCore::ScriptController::clearPlatformScriptObjects):
- (WebCore::updateRenderingForBindings):
- (WebCore::ScriptController::initJavaJSBindings):
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bindings/js/ScriptControllerWin.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bindings/js/ScriptControllerWx.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bindings/js/StringSourceProvider.h:
- (WebCore::StringSourceProvider::getRange):
- * bindings/objc/DOM.mm:
- (-[DOMNode JSC::Bindings::]):
- * bindings/objc/DOMInternal.h:
- * bindings/objc/DOMInternal.mm:
- (-[WebScriptObject _initializeScriptDOMNodeImp]):
- * bindings/objc/DOMUtility.mm:
- (JSC::createDOMWrapper):
- (WebCore::createDOMWrapper):
- * bindings/objc/WebScriptObject.mm:
- (WebCore::createJSWrapper):
- (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
- * bindings/objc/WebScriptObjectPrivate.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- * bridge/NP_jsobject.h:
- * bridge/c/c_class.cpp:
- * bridge/c/c_class.h:
- * bridge/c/c_instance.cpp:
- * bridge/c/c_instance.h:
- * bridge/c/c_runtime.cpp:
- * bridge/c/c_runtime.h:
- * bridge/c/c_utility.cpp:
- * bridge/c/c_utility.h:
- * bridge/jni/jni_class.cpp:
- * bridge/jni/jni_class.h:
- * bridge/jni/jni_instance.cpp:
- * bridge/jni/jni_instance.h:
- * bridge/jni/jni_jsobject.h:
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::convertJObjectToValue):
- * bridge/jni/jni_objc.mm:
- (JSC::Bindings::dispatchJNICall):
- * bridge/jni/jni_runtime.cpp:
- * bridge/jni/jni_runtime.h:
- * bridge/jni/jni_utility.cpp:
- * bridge/jni/jni_utility.h:
- * bridge/npruntime.cpp:
- (_NPN_GetStringIdentifier):
- * bridge/objc/WebScriptObject.h:
- * bridge/objc/objc_class.h:
- * bridge/objc/objc_class.mm:
- * bridge/objc/objc_instance.h:
- * bridge/objc/objc_instance.mm:
- * bridge/objc/objc_runtime.h:
- * bridge/objc/objc_runtime.mm:
- * bridge/objc/objc_utility.h:
- * bridge/objc/objc_utility.mm:
- * bridge/qt/qt_class.cpp:
- * bridge/qt/qt_class.h:
- * bridge/qt/qt_instance.cpp:
- * bridge/qt/qt_instance.h:
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
- (JSC::Bindings::):
- * bridge/qt/qt_runtime.h:
- * bridge/runtime.cpp:
- * bridge/runtime.h:
- * bridge/runtime_array.cpp:
- * bridge/runtime_array.h:
- * bridge/runtime_method.cpp:
- * bridge/runtime_method.h:
- * bridge/runtime_object.cpp:
- * bridge/runtime_object.h:
- * bridge/runtime_root.cpp:
- (JSC::Bindings::RootObject::invalidate):
- (JSC::Bindings::RootObject::gcProtect):
- (JSC::Bindings::RootObject::gcUnprotect):
- * bridge/runtime_root.h:
- * bridge/testbindings.cpp:
- * bridge/testbindings.mm:
- * bridge/testqtbindings.cpp:
- * dom/Document.cpp:
- (WebCore::Document::~Document):
- * dom/NSResolver.h:
- * dom/Node.cpp:
- (WebCore::Node::setDocument):
- (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
- (WebCore::resolveNamespacesForSelector):
- (WebCore::Node::querySelector):
- (WebCore::Node::querySelectorAll):
- * dom/Node.h:
- * dom/NodeFilter.cpp:
- * dom/NodeFilter.h:
- * dom/NodeFilterCondition.cpp:
- * dom/NodeFilterCondition.h:
- * dom/NodeIterator.cpp:
- * dom/NodeIterator.h:
- * dom/Traversal.cpp:
- * dom/Traversal.h:
- * dom/TreeWalker.cpp:
- * dom/TreeWalker.h:
- * dom/make_names.pl:
- * history/CachedPage.cpp:
- * history/CachedPage.h:
- * html/HTMLPlugInElement.cpp:
- (WebCore::HTMLPlugInElement::getInstance):
- * html/HTMLPlugInElement.h:
- * loader/FrameLoader.cpp:
- * loader/FrameLoader.h:
- * loader/icon/IconDatabase.cpp:
- (WebCore::iconDatabase):
- * page/Console.cpp:
- * page/Console.h:
- * page/InspectorController.cpp:
- (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
- (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
- (WebCore::InspectorResource::setXMLHttpRequestProperties):
- (WebCore::InspectorResource::sourceString):
- (WebCore::getResourceDocumentNode):
- (WebCore::search):
- (WebCore::InspectorController::focusNode):
- (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
- (WebCore::InspectorController::addDatabaseScriptResource):
- (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- * page/InspectorController.h:
- (WebCore::InspectorController::profiles):
- * page/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::scopeChain):
- * page/JavaScriptCallFrame.h:
- (WebCore::JavaScriptCallFrame::create):
- (WebCore::JavaScriptCallFrame::update):
- * page/JavaScriptDebugListener.h:
- * page/JavaScriptDebugServer.cpp:
- (WebCore::dispatchDidParseSource):
- * page/JavaScriptDebugServer.h:
- * page/JavaScriptProfile.cpp:
- * page/JavaScriptProfile.h:
- * page/JavaScriptProfileNode.cpp:
- (WebCore::getTotalTime):
- (WebCore::getSelfTime):
- (WebCore::getTotalPercent):
- (WebCore::getSelfPercent):
- (WebCore::getNumberOfCalls):
- (WebCore::getChildren):
- (WebCore::getVisible):
- * page/JavaScriptProfileNode.h:
- * page/Page.cpp:
- (WebCore::Page::setDebuggerForAllPages):
- (WebCore::Page::setDebugger):
- * page/Page.h:
- (WebCore::Page::debugger):
- * page/mac/FrameMac.mm:
- * platform/KURL.h:
- (WebCore::KURL::operator JSC::UString):
- * platform/text/AtomicString.cpp:
- (WebCore::AtomicString::add):
- (WebCore::AtomicString::find):
- * platform/text/AtomicString.h:
- (WebCore::AtomicString::AtomicString):
- * platform/text/PlatformString.h:
- * platform/text/String.cpp:
- (WebCore::charactersToDouble):
- * platform/win/BString.cpp:
- * platform/win/BString.h:
- * plugins/MimeTypeArray.h:
- * plugins/Plugin.h:
- * plugins/PluginArray.h:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::start):
- (WebCore::PluginView::performRequest):
- (WebCore::PluginView::bindingInstance):
- * plugins/PluginView.h:
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::paint):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::init):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::init):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::dispatchNPEvent):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- * storage/Database.cpp:
- (WebCore::Database::Database):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseText):
- (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- (WebCore::XMLHttpRequest::clearResponse):
- (WebCore::XMLHttpRequest::dropProtection):
- (WebCore::XMLHttpRequest::didFinishLoading):
- (WebCore::XMLHttpRequest::didReceiveData):
- * xml/XMLHttpRequest.h:
-
-2008-09-07 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- Adopt opener restriction on frame navigation.
- https://bugs.webkit.org/show_bug.cgi?id=20642
-
- This restriction helps prevent an attacker from navigating top-level
- windows that were created by another web site.
-
- Tests: http/tests/security/frameNavigation/not-opener.html
- http/tests/security/frameNavigation/opener.html
-
- * loader/FrameLoader.cpp:
- (WebCore::canAccessAncestor):
- (WebCore::FrameLoader::shouldAllowNavigation):
-
-2008-09-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Maciej Stachowiak.
-
- - use the correct sign for vertical offsets of combining marks
-
- * platform/graphics/win/UniscribeController.cpp:
- (WebCore::UniscribeController::shapeAndPlaceItem):
-
-2008-09-07 Dan Bernstein <mitz@apple.com>
+2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>
- Reviewed by Dave Hyatt.
-
- - add the combining mark offsets in two places where I forgot them
-
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::Font::drawGlyphs):
-
-2008-09-07 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - correct glyph advances in complex text using web fonts rendered with
- Core Graphics
-
- * platform/graphics/win/FontCustomPlatformData.cpp:
- (WebCore::FontCustomPlatformData::fontPlatformData):
-
-2008-09-07 Keishi Hattori <casey.hattori@gmail.com>
-
- Adds console.dirxml support to the Web Inspector.
-
- https://bugs.webkit.org/show_bug.cgi?id=19156
-
- Reviewed by Timothy Hatcher.
-
- * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::dirxml):
- * page/Console.cpp:
- (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
- * page/Console.h:
- (WebCore::): Added NodeMessageLevel.
- * page/Console.idl: Added console.dirxml.
- * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
- * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
- in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
- * page/inspector/ElementsTreeOutline.js: Added.
- (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
- (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
- * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
- * page/inspector/inspector.css:
- * page/inspector/inspector.html: Added ElementsTreeOutline.js.
- * page/inspector/inspector.js: Moved hover related methods to WebInspector.
- (WebInspector.altKeyDown):
- (WebInspector.forceHoverHighlight):
- (WebInspector.hoveredDOMNode):
- (WebInspector._updateHoverHighlightSoon):
- (WebInspector._updateHoverHighlight):
- (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
- (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
- * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
- isAncestorIncludingParentFrames.
-
-2008-09-06 Mark Rowe <mrowe@apple.com>
-
- Qt build fix.
-
- * bridge/qt/qt_runtime.cpp:
- (KJS::Bindings::convertQVariantToValue):
-
-=== End merge of squirrelfish-extreme ===
-
-2008-09-05 Oliver Hunt <oliver@apple.com>
-
- Start bringing up SFX on windows.
-
- Reviewed by Mark Rowe and Sam Weinig
-
- Start doing the work to bring up SFX on windows. Initially
- just working on WREC, as it does not make any calls so reduces
- the amount of code that needs to be corrected.
-
- Add forwarding headers
-
- * ChangeLog:
- * ForwardingHeaders/masm/MacroAssembler.h: Added.
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-08-27 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Oliver Hunt.
-
- Fix the build of the full WebKit stack.
-
- Add forwarding headers.
-
- * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
- * ForwardingHeaders/wrec/WREC.h: Added.
-
-=== Start merge of squirrelfish-extreme ===
-
-2008-09-06 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dave Hyatt.
-
- <rdar://problem/6187043>
- Don't parse full HTML user agent style sheet unless it is actually needed
- <rdar://problem/6131889>
- WebView is significantly more expensive to create recently
-
- Parsing the html4.css takes significant amount of time and memory (~50kb) on application
- startup. Some clients may never use most of the rules.
-
- With this patch we use simplified UA stylesheet until we hit something it can't handle.
- This avoids full stylesheet parsing on application startup (due to empty document construction)
- and also makes it possible for clients with very simple demands (divs and spans only) never to load
- the full style.
-
- It also delays view source style parsing until it is used.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::elementCanUseSimpleDefaultStyle):
- (WebCore::CSSStyleSelector::CSSStyleSelector):
- (WebCore::loadFullDefaultStyle):
- (WebCore::loadSimpleDefaultStyle):
- (WebCore::loadViewSourceStyle):
- (WebCore::CSSStyleSelector::matchUARules):
- (WebCore::CSSStyleSelector::styleForElement):
-
-2008-09-06 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix.
-
- * WebCoreSources.bkl:
-
-2008-09-06 Antti Koivisto <antti@apple.com>
-
- Reverting r35953 which was causing problems on Windows which relies on
- WebCore timers in nested event loops. r36132 did alternative fix.
-
- * page/Chrome.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
-
-2008-09-06 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
+ Gtk build fix.
- Fix <rdar://problem/6201644>
- https://bugs.webkit.org/show_bug.cgi?id=20493
- Crash after OK in dialog box and reloading page in secure mode
+ Add HTMLDataGridElement header and IDL to the build script.
- Limited loader only fix since the general timer fix is causing problems on Windows.
+ * GNUmakefile.am:
- * loader/loader.cpp:
- (WebCore::Loader::servePendingRequests):
- (WebCore::Loader::Host::Host):
- (WebCore::Loader::Host::didFinishLoading):
- (WebCore::Loader::Host::didFail):
- (WebCore::Loader::Host::didReceiveData):
- * loader/loader.h:
- (WebCore::Loader::Host::processingResource):
+2009-06-18 Chris Evans <scarybeasts@gmail.com>
-2008-09-06 Dan Bernstein <mitz@apple.com>
+ Reviewed by Adam Barth.
- Reviewed by Dave Hyatt.
+ Fix 8-digit long hex entities. Fixes bug 26454
+ https://bugs.webkit.org/show_bug.cgi?id=26454
- The initial Core Text adoption prototype was made by Daniel Fenwick.
-
- - <rdar://problem/5158514> Add a Core Text-based complex text code path
-
- Currently the Core Text code path is not used in any configuration.
-
- * WebCore.xcodeproj/project.pbxproj: Added files.
- * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
- * platform/graphics/Font.cpp:
- (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
- of the loop.
- * platform/graphics/GlyphBuffer.h:
- (WebCore::GlyphBuffer::add): Added this version that takes an advance.
- * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
- Added getCTFont() and getCFStringAttributes() and corresponding data
- members for Core Text.
- * platform/graphics/mac/CoreTextController.cpp: Added.
- (WebCore::roundCGFloat): Helper function.
- (WebCore::ceilCGFloat): Helper function.
- (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
- (WebCore::CoreTextController::CoreTextController):
- (WebCore::CoreTextController::offsetForPosition):
- (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
- run into subruns as necessary such that each subrun can be rendered with
- a single font. Also separates out soft hyphens and replaces them with
- real hyphens, because Core Text does not emit a glyph for soft hyphens.
- Then calls collectCoreTextRunsForCharacters() on each subrun.
- (WebCore::CoreTextController::advance):
- (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
- a CTLine from the given subrun and collects its CoreTextRuns.
- (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
- rounding hacks, letter- and word-spacing and glyph substitutions and
- stores the resulting adjusted glyphs and advances.
- * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
- (WebCore::CoreTextController::totalWidth):
- (WebCore::CoreTextController::finalRoundingWidth):
- (WebCore::CoreTextController::CoreTextRun::ctRun):
- (WebCore::CoreTextController::CoreTextRun::glyphCount):
- (WebCore::CoreTextController::CoreTextRun::fontData):
- (WebCore::CoreTextController::CoreTextRun::characters):
- (WebCore::CoreTextController::CoreTextRun::stringLocation):
- (WebCore::CoreTextController::CoreTextRun::stringLength):
- (WebCore::CoreTextController::CoreTextRun::indexAt):
- * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
- FontMacATSUI.mm.
- * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
- (WebCore::disableLigatures): Changed to call
- FontPlatformData::allowsLigatures().
- (WebCore::overrideLayoutOperation): Changed to call
- FontPlatformData::roundsGlyphAdvances().
- * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
- (WebCore::Font::selectionRectForComplexText): Changed to use
- totalWidth() instead of advancing to the end and using runWidthSoFar().
- (WebCore::Font::drawComplexText):
- (WebCore::Font::floatWidthForComplexText): Ditto.
- (WebCore::Font::offsetForPositionForComplexText):
- * platform/graphics/mac/FontPlatformData.h:
- * platform/graphics/mac/FontPlatformDataMac.mm:
- (WebCore::FontPlatformData::setFont):
- (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
- AppKit rendering mode.
- (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
- heuristic that allows ligatures in fonts that do not have a glyph for
- 'a', based on the assumption that such fonts are only used in complex
- text.
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::platformInit):
- (WebCore::SimpleFontData::platformDestroy):
- (WebCore::SimpleFontData::getCTFont): Added.
- (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
- returns an attributes dictionary.
- * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
- * platform/text/mac/ShapeArabic.h: Ditto.
-
-2008-09-06 Dan Bernstein <mitz@apple.com>
+ Test: fast/parser/eightdigithexentity.html
- Reviewed by Dave Hyatt.
+ * html/HTMLTokenizer.cpp: fix off-by-ones.
- - make combining mark offsets work in CG text on Windows
+2009-06-18 David Levin <levin@chromium.org>
- * platform/graphics/win/FontCGWin.cpp:
- (WebCore::Font::drawGlyphs): The old code tried to translate the text
- matrix, but failed for two reasons: it did not actually change the
- matrix, and even if it did, CGContextSetTextPosition overwrites the
- translation values in the text matrix. Instead, just added the
- translation to the anchor point.
+ Fix chromium linux build.
-2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
+ Fixes a mistake that happened during the complicated merge for
+ landing r44775, r44776, r44777.
- Reviewed by Alp Toker.
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::create):
- https://bugs.webkit.org/show_bug.cgi?id=18346
- [GTK] Remove build warnings
+2009-06-17 Simon Fraser <simon.fraser@apple.com>
- Applied some casts, and removed an unused typedef to make the
- compiler happy, printing less warnings when building.
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26499
+
+ First step to making video rendering be hardware-accelerated:
+ make <video> elements get self-painting RenderLayers, and add
+ an isVideo() virtual method to RenderObject.
- * page/gtk/AccessibilityObjectWrapperAtk.cpp:
- * platform/graphics/gtk/SimpleFontDataPango.cpp:
- (WebCore::SimpleFontData::containsCharacters):
- * platform/graphics/gtk/VideoSinkGStreamer.cpp:
- (webkit_video_sink_set_caps):
- * platform/network/soup/ResourceHandleSoup.cpp:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setReadyState):
+ (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
+ (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::shouldBeNormalFlowOnly):
+ (WebCore::RenderLayer::isSelfPaintingLayer):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isVideo):
+ * rendering/RenderVideo.h:
+ (WebCore::RenderVideo::requiresLayer):
+ (WebCore::RenderVideo::isVideo):
-2008-09-05 Eric Seidel <eric@webkit.org>
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
- Build fix for WebKitWin and Chromium
-
- * platform/FileSystem.h:
-
-2008-09-05 Eric Seidel <eric@webkit.org>
+ Refactor a few common routines in the various Windows ports
+ and reduce some duplicated code.
- Reviewed by Darin Adler.
-
- Try to make Chromium compile with ToT:
- - Wrap a few places which depend on KJS:: in #if USE(JSC)
- - Include some windows forward declarations
-
- * dom/Node.h:
- * page/Console.h:
- * page/animation/CompositeAnimation.h:
- * platform/FileSystem.h:
- * platform/graphics/Image.h:
- * platform/text/AtomicString.h:
- * platform/text/String.cpp:
- * rendering/style/RenderStyle.h:
+ (1) Create TransformationMatrix XFORM casting operator, and
+ switch various XFORM structure uses to utilize it.
+ (2) Push concatCTM call to GraphicsContextWin now that the
+ TransformationMatrix can directly create XFORM (rather
+ than converting to CGAffineTransform/cairo_matrix_t first.)
-2008-09-05 Dave Hyatt <hyatt@apple.com>
+ * WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ * platform/graphics/win/GraphicsContextCairoWin.cpp:
+ * platform/graphics/win/GraphicsContextWin.cpp:
+ (WebCore::GraphicsContextPlatformPrivate::scale):
+ (WebCore::GraphicsContextPlatformPrivate::rotate):
+ (WebCore::GraphicsContextPlatformPrivate::translate):
+ (WebCore::GraphicsContextPlatformPrivate::concatCTM):
+ * platform/graphics/win/TransformationMatrixWin.cpp: Added.
+ (WebCore::TransformationMatrix::operator XFORM): New operator
- Add support for runtime switchability of the Aqua look and the native look on Windows.
- Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
- Reviewed by Adam Roben
+ Non-CG Windows build fix after @r44758.
- * WebCore.vcproj/WebCore.vcproj:
- * page/Settings.cpp:
- (WebCore::Settings::setShouldPaintNativeControls):
- * page/Settings.h:
- (WebCore::Settings::shouldPaintNativeControls):
- * rendering/RenderThemeSafari.cpp:
- (WebCore::theme):
* rendering/RenderThemeWin.cpp:
+ (WebCore::RenderTheme::themeForPage):
-2008-09-05 Antti Koivisto <antti@apple.com>
-
- Qt build fix.
-
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::build):
-
-2008-09-05 Dirk Schulze <vbs85@gmx.de>
-
- Gtk build fix
-
- * GNUmakefile.am:
-
-2008-09-05 Antti Koivisto <antti@apple.com>
-
- Another build fix.
-
- * svg/SVGFEImageElement.cpp:
- (WebCore::SVGFEImageElement::notifyFinished):
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
-2008-09-05 Antti Koivisto <antti@apple.com>
-
- Build fixes.
-
- * WebCore.xcodeproj/project.pbxproj:
- * svg/graphics/filters/SVGFEImage.cpp:
- (WebCore::FEImage::cachedImage):
-
-2008-09-05 Antti Koivisto <antti@apple.com>
-
- Reviewed by Darin Adler.
-
- Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
- When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
-
- Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
- not yet enable it for the biggest use case, reloading. However it is good for general browsing as
- well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
- we avoid re-decoding resources, especially images.
-
- To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
- CacheControl: max-age=0 header. That would be added in reload case.
+ Reviewed by Adam Roben.
- The approach for revalidation is to kick the original resource out from the memory cache
- and create a new CachedResource that represents the revalidation request. In case
- we get 304 back for the request we put the original resource back to the cache, update
- its expiration date and switch the clients registered to revalidation resource to be
- clients of the original resource.
+ Refactor a few common routines in the various Windows ports
+ and reduce some duplicated code.
+ https://bugs.webkit.org/show_bug.cgi?id=26425.
- All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
- This allows updating the handles to point to the original resource when the revalidation succeeds. It
- also acts as refcounting smart pointer.
+ Refactor use of BITMAPINFO for the new BitmapInfo structure.
- * WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSFontFaceSource.h:
- * css/CSSImportRule.h:
- * dom/Clipboard.h:
- (WebCore::Clipboard::dragImage):
- * dom/ProcessingInstruction.h:
- * dom/ScriptElement.h:
- * dom/XMLTokenizer.cpp:
- (WebCore::XMLTokenizer::isWaitingForScripts):
- * dom/XMLTokenizer.h:
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::setImage):
- (WebCore::HTMLImageLoader::updateFromElement):
- (WebCore::HTMLImageLoader::notifyFinished):
- * html/HTMLImageLoader.h:
- (WebCore::HTMLImageLoader::image):
- * html/HTMLLinkElement.h:
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::reset):
- (WebCore::HTMLTokenizer::scriptHandler):
- (WebCore::HTMLTokenizer::notifyFinished):
- * html/HTMLTokenizer.h:
- * loader/Cache.cpp:
- (WebCore::Cache::revalidateResource):
- (WebCore::Cache::revalidationSucceeded):
- (WebCore::Cache::revalidationFailed):
- * loader/Cache.h:
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::CachedResource):
- (WebCore::CachedResource::~CachedResource):
- (WebCore::CachedResource::isExpired):
- (WebCore::CachedResource::setResponse):
- (WebCore::CachedResource::deleteIfPossible):
- (WebCore::CachedResource::setResourceToRevalidate):
- (WebCore::CachedResource::clearResourceToRevalidate):
- (WebCore::CachedResource::switchClientsToRevalidatedResource):
- (WebCore::CachedResource::canUseCacheValidator):
- (WebCore::CachedResource::mustRevalidate):
- * loader/CachedResource.h:
- (WebCore::CachedResource::canDelete):
- (WebCore::CachedResource::registerHandle):
- (WebCore::CachedResource::unregisterHandle):
- (WebCore::CachedResource::isCacheValidator):
- (WebCore::CachedResource::resourceToRevalidate):
- (WebCore::CachedResource::setExpirationDate):
- * loader/CachedResourceHandle.cpp: Added.
- (WebCore::CachedResourceHandleBase::setResource):
- * loader/CachedResourceHandle.h: Added.
- (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
- (WebCore::CachedResourceHandleBase::get):
- (WebCore::CachedResourceHandleBase::operator!):
- (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
- (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
- (WebCore::CachedResourceHandleBase::operator=):
- (WebCore::CachedResourceHandle::CachedResourceHandle):
- (WebCore::CachedResourceHandle::get):
- (WebCore::CachedResourceHandle::operator->):
- (WebCore::CachedResourceHandle::operator=):
- (WebCore::CachedResourceHandle::operator==):
- (WebCore::CachedResourceHandle::operator!=):
- (WebCore::operator==):
- (WebCore::operator!=):
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::checkForReload):
- * loader/UserStyleSheetLoader.h:
- * loader/loader.cpp:
- (WebCore::Loader::Host::servePendingRequests):
- (WebCore::Loader::Host::didFinishLoading):
- (WebCore::Loader::Host::didFail):
- (WebCore::Loader::Host::didReceiveResponse):
- (WebCore::Loader::Host::didReceiveData):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::selectCursor):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::setCachedImage):
- (WebCore::RenderImage::imageChanged):
- * rendering/RenderImage.h:
- (WebCore::RenderImage::cachedImage):
- (WebCore::RenderImage::imagePtr):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleCachedImage.h:
- (WebCore::StyleCachedImage::data):
- (WebCore::StyleCachedImage::cachedImage):
- * svg/SVGFEImageElement.h:
- * svg/graphics/filters/SVGFEImage.h:
- * xml/XSLImportRule.h:
-
-2008-09-04 Brady Eidson <beidson@apple.com>
-
- Reviewed by Mitz
-
- <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
-
- A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
- to model default NSURLRequest behavior in a cross-platform manner.
-
- Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
- client that wished to enforce a much larger default timeout using NSURLRequest API.
-
- Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
- behavior on the web and this restores previous Safari/WebKit behavior.
-
- It would be easy to write a layout test for this, but to be effective it would have
- to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
-
- * manual-tests/timeout-test.html: Added.
- * manual-tests/timeout-test.php: Added.
-
- * platform/network/ResourceRequestBase.h:
- (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
- and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
- * platform/network/mac/ResourceRequestMac.mm:
- (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
- "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
- WebKit applications to enforce their own default timeout.
-
-2008-09-04 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Beth Dakin.
-
- - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
-
- Test: fast/repaint/button-spurious-layout-hint.html
-
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::setStyle): Reset the inner block's style box
- flex to 0 to avoid getting a spurious layout hint.
-
-2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes.
-
- * WebCoreSources.bkl:
- * bindings/js/ScriptControllerWx.cpp: Added.
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * page/wx/AccessibilityObjectWx.cpp: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- * platform/graphics/wx/GraphicsContextWx.cpp:
- * webcore-base.bkl:
- * webcore-wx.bkl:
-
-2008-09-04 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Mark Rowe.
-
- - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
- and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
- require a different approach
-
- * css/CSSGrammar.y:
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Eric Seidel.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
- Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
-
- * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
- * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
- for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
-
-2008-09-04 Mark Rowe <mrowe@apple.com>
-
- Mac build fix.
-
- * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
-
-2008-09-04 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
-
-2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Eric Seidel.
-
- http://bugs.webkit.org/show_bug.cgi?id=20380
- [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
-
- * config.h: Include the configuration header generated by autotools if
- available.
-
-2008-09-04 Dan Bernstein <mitz@apple.com>
-
- Rubber-stamped by Dave Hyatt.
-
- - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
-
- * loader/CachedFont.cpp:
- (WebCore::CachedFont::allClientsRemoved):
- * loader/CachedFont.h:
- * loader/CachedImage.cpp:
- (WebCore::CachedImage::allClientsRemoved):
- * loader/CachedImage.h:
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::removeClient):
- * loader/CachedResource.h:
- (WebCore::CachedResource::allClientsRemoved):
-
-2008-09-04 Adam Roben <aroben@apple.com>
-
- Windows build fix after r36071
-
- We were getting these errors:
-
- error C2356: initialization segment must not change during translation
- unit
-
- This was happening because multiple files #included by
- DerivedSources.cpp were themselves #including StaticConstructors.h. I
- fixed the error by adding header guards to StaticConstructors.h so its
- contents will only be included once.
-
- But it's also not a good idea for StaticConstructors.h to end up in
- DerivedSources.cpp, since it ends up "polluting" all the source files
- we have in there. So I removed all the files that include
- StaticConstructors.h and added some preprocessor directives to
- DerivedSources.cpp to catch this error in the future.
-
- * DerivedSources.cpp: Removed the *Names.cpp files, which include
- StaticConstructors.h, and added some preprocessor directives to make
- sure we don't end up accidentally including StaticConstructors.h in
- the future.
- * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
- * platform/StaticConstructors.h: Added header guards.
-
-2008-09-04 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * platform/graphics/win/FontPlatformData.h: Added a missing #include
- of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
- * platform/text/PlatformString.h: Added a missing #include of
- PassRefPtr.h.
-
-2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Fix the QtWebKit build to match changes in r36016
-
- * WebCore.pro:
- * bridge/qt/qt_instance.cpp:
- (KJS::Bindings::QtInstance::getRuntimeObject):
- * bridge/qt/qt_runtime.cpp:
- (KJS::Bindings::convertQVariantToValue):
- (KJS::Bindings::QtConnectionObject::execute):
-
-2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
-
- Reviewed by Simon.
-
- Re-enable support for user stylesheets in QtWebKit
-
- QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
- code path, which allows us to keep API support for
- loading user style sheets from remote URLs.
-
- As part of the change UserStyleSheetLoader.cpp/h was
- moved from WebCore/loader/mac to WebCore/loader.
-
- * WebCore.pro:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Document.h:
- * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
- (UserStyleSheetLoader::UserStyleSheetLoader):
- (UserStyleSheetLoader::~UserStyleSheetLoader):
- * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
- * page/qt/FrameQt.cpp:
- (WebCore::Frame::setUserStyleSheetLocation):
- (WebCore::Frame::setUserStyleSheet):
-
-2008-09-04 Alp Toker <alp@nuanti.com>
-
- Reviewed by Eric.
-
- Remove left-over QT and CAIRO platform checks.
+ * platform/win/BitmapInfo.cpp: Added.
+ (WebCore::bitmapInfoForSize):
+ (WebCore::BitmapInfo::create):
+ (WebCore::BitmapInfo::createBottomUp):
+ * platform/win/BitmapInfo.h: Added.
+ * platform/graphics/win/GraphicsContextCairoWin.cpp:
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ * platform/graphics/win/TransformationMatrixWin.cpp: Added.
+ (WebCore::TransformationMatrix::operator XFORM): New operator
+ * platform/win/DragImageCGWin.cpp:
+ (WebCore::allocImage):
+ * platform/win/DragImageCairoWin.cpp:
+ (WebCore::allocImage):
+ * platform/win/PasteboardWin.cpp:
+ (WebCore::Pasteboard::writeImage):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::paint):
- * html/CanvasRenderingContext2D.cpp:
+2009-06-17 Adam Roben <aroben@apple.com>
-2008-09-04 Eric Seidel <eric@webkit.org>
+ Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL
Reviewed by Mark Rowe.
- Fix leak of TextMetrics due to over-ref as see on buildbot.
+ * platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and
+ an unnecessary parameter name.
+ * platform/win/SoftLinking.h: Removed the unused 6th parameter.
- * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
+2009-06-17 Adam Roben <aroben@apple.com>
-2008-09-04 Dan Bernstein <mitz@apple.com>
+ Make Settings::shouldPaintNativeControls default to true
- Reviewed by Dave Hyatt.
+ This matches the default up in WebKit (that was changed in r43318).
- - fix https://bugs.webkit.org/show_bug.cgi?id=19717
- <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
+ Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
+ form controls
+ <https://bugs.webkit.org/show_bug.cgi?id=26493>
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
- positioned movement only case, call
- tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
- layout if that fails.
- (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
- * rendering/RenderBox.h:
- (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
- layoutDoingPositionedMovementOnly to this, and made this function
- check if the width changed. If it did, return, leaving the object
- dirty. The caller can then call layout(). The width can change even
- in the "positioned movement only" case if the object is shrink-to-fit
- and the available width constraint is met. (This was the case in the
- bug).
- * rendering/RenderObject.h:
- (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
- Renamed layoutDoingPositionedMovementOnly() to this.
-
-2008-09-03 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Attempt to fix the Qt build.
-
- * WebCore.pro: add page/animation to include path
-
-2008-09-03 Mark Rowe <mrowe@apple.com>
-
- Mac build fix. Correctly detect whether dashboard support is enabled.
-
- * DerivedSources.make:
-
-2008-09-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam.
-
- Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
+ Reviewed by Darin Adler and Dave Hyatt.
- * Configurations/WebCore.xcconfig: add missing ENABLE_*
- * config.h: add rules for V8_BINDINGS
+ No test possible since DRT always uses Mac-style form controls.
-2008-09-03 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam.
-
- https://bugs.webkit.org/show_bug.cgi?id=20620
-
- Add #if USE(JSC) around KJS dependencies
- Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
- 1. Most platforms have it on anyway
- 2. V8 is going to want to share some of that code
- 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
-
- * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
- * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
- * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
- * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
- * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
- * platform/text/AtomicString.cpp: add USE(JSC)
- * platform/text/AtomicString.h: add USE(JSC)
- * platform/text/PlatformString.h: add USE(JSC)
- * platform/text/String.cpp: add USE(JSC)
- * platform/text/StringImpl.cpp: add USE(JSC)
- * platform/text/StringImpl.h: add USE(JSC)
-
-2008-09-03 Dean McNamee <deanm@chromium.org>
-
- Reviewed by Darin Adler.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20511
- Bug 20511: Remove static initializers on Windows
-
- Avoid static initializers on Windows by forcing Visual C++ to put
- all static initializers in a code segment that is never executed.
-
- * config.h:
- * css/MediaFeatureNames.cpp:
- * dom/EventNames.cpp:
- * dom/QualifiedName.cpp:
- * dom/make_names.pl:
- * platform/StaticConstructors.h:
- * platform/text/AtomicString.cpp:
-
-2008-09-03 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Dave Hyatt.
+ * page/Settings.cpp: Changed the initial value of
+ gShouldPaintNativeControls to true.
- Make FontCairo draw TextStroke and TextFill separately.
-
- [CAIRO] draw TextFill and TextStroke separately.
- [https://bugs.webkit.org/show_bug.cgi?id=20631]
-
- * platform/graphics/cairo/FontCairo.cpp:
- (WebCore::Font::drawGlyphs):
-
-2008-09-03 Peter Kasting <pkasting@google.com>
-
- Reviewed by Dave Hyatt.
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderTheme::themeForPage): Added a FIXME about the design
+ flaw here involving querying Settings before it's been initialized.
- https://bugs.webkit.org/show_bug.cgi?id=19663
- Account for paint and timer lag when animating images. Also pretend
- that images whose animations were paused (by becoming invisible)
- continued to animate, by "catching up" to the correct frame when they're
- shown again.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- (WebCore::BitmapImage::startAnimation):
- (WebCore::BitmapImage::advanceAnimation):
- (WebCore::BitmapImage::internalAdvanceAnimation):
- (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
- * platform/graphics/BitmapImage.h:
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::draw):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::BitmapImage::draw):
+2009-06-17 David Levin <levin@chromium.org>
-2008-09-03 Kevin McCullough <kmccullough@apple.com>
+ Fix chromium windows build.
- Reviewed by Tim.
+ A mistake that happened during the complicated merge for
+ landing r44775, r44776, r44777.
- Remove the rest of the "zombie" code from the profiler.
- - There is no longer a need for the ProfilerClient callback mechanism.
+ * rendering/RenderThemeChromiumWin.h:
+ (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
+ (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
- * page/Console.cpp:
- (WebCore::Console::Console):
- (WebCore::Console::profile):
- (WebCore::Console::profileEnd): Move the variables from the header to
- here since we don't have to wait for a callback to use them.
- * page/Console.h:
- * page/InspectorController.cpp:
- (WebCore::InspectorController::startUserInitiatedProfiling):
- (WebCore::InspectorController::stopUserInitiatedProfiling):
- * page/InspectorController.h:
+2009-06-17 Eric Carlson <eric.carlson@apple.com>
-2008-09-03 Ada Chan <adachan@apple.com>
+ Reviewed by Simon Fraser.
- Windows build fix.
+ <rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent
- * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer.
+ (WebCore::MediaControlInputElement::attachToParent): Ditto.
-2008-09-01 Dean Jackson <dino@apple.com>
+2009-06-17 David Hyatt <hyatt@apple.com>
- Reviewed by Dave Hyatt.
+ Fix Windows build. There's no HTMLDataGridElement.cpp file yet.
- https://bugs.webkit.org/show_bug.cgi?id=20594
- Add DOM interfaces for WebKitCSSKeyframeRule
- and WebKitCSSKeyframesRule.
+ * html/HTMLElementsAllInOne.cpp:
- TEST: LayoutTests/css3/keyframes-rule.html
+2009-06-17 David Hyatt <hyatt@apple.com>
- * css/WebKitCSSKeyframeRule.idl: Added
- * css/WebKitCSSKeyframesRule.idl: Added
+ Reviewed by Adam Roben and Anders Carlsson.
- * bindings/js/JSCSSRuleCustom.cpp:
- (WebCore::toJS):
- Add return of new JS Keyframe rules
- * bindings/objc/DOMInternal.h:
- Include new internal header
+ Stub out the HTMLDataGridElement.
* DerivedSources.make:
- * GNUmakefile.am:
- * WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
- Build configs for new files
-
-2008-09-03 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
- * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
- convenience/consistency.
-
-2008-09-03 Adele Peterson <adele@apple.com>
-
- Build fix.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-09-03 David Hyatt <hyatt@apple.com>
-
- Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
-
- Reviewed by Darin (ages ago)
-
- Added fast/block/float/clamped-right-float.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::positionNewFloats):
-
-2008-09-02 David Hyatt <hyatt@apple.com>
-
- Add support for canvas text drawing APIs.
-
- Reviewed by olliej
-
- Tests added as fast/canvas/canvas-text-*.html
-
- * DerivedSources.make:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::JSCanvasRenderingContext2D::fillText):
- (WebCore::JSCanvasRenderingContext2D::strokeText):
* css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::initForStyleResolve):
- (WebCore::CSSStyleSelector::applyPropertyToStyle):
- * css/CSSStyleSelector.h:
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::State::State):
- (WebCore::CanvasRenderingContext2D::font):
- (WebCore::CanvasRenderingContext2D::setFont):
- (WebCore::CanvasRenderingContext2D::textAlign):
- (WebCore::CanvasRenderingContext2D::setTextAlign):
- (WebCore::CanvasRenderingContext2D::textBaseline):
- (WebCore::CanvasRenderingContext2D::setTextBaseline):
- (WebCore::CanvasRenderingContext2D::fillText):
- (WebCore::CanvasRenderingContext2D::strokeText):
- (WebCore::CanvasRenderingContext2D::measureText):
- (WebCore::CanvasRenderingContext2D::drawTextInternal):
- (WebCore::CanvasRenderingContext2D::accessFont):
- * html/CanvasRenderingContext2D.h:
- * html/CanvasRenderingContext2D.idl:
- * html/TextMetrics.h: Added.
- (WebCore::TextMetrics::create):
- (WebCore::TextMetrics::width):
- (WebCore::TextMetrics::setWidth):
- (WebCore::TextMetrics::TextMetrics):
- * html/TextMetrics.idl: Added.
- * platform/graphics/Font.cpp:
- (WebCore::Font::lineGap):
- * platform/graphics/Font.h:
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::drawBidiText):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsTypes.cpp:
- (WebCore::textAlignName):
- (WebCore::parseTextAlign):
- (WebCore::textBaselineName):
- (WebCore::parseTextBaseline):
- * platform/graphics/GraphicsTypes.h:
- (WebCore::):
-
-2008-09-03 John Sullivan <sullivan@apple.com>
-
- Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
-
- Fixed by Darin, reviewed by me
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::propertiesEqual):
- added ensurePropertyMap() to this static function
- (WebCore::AnimationBase::getPropertyAtIndex):
- ditto
- (WebCore::AnimationBase::getNumProperties):
- ditto
-
-2008-09-03 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Darin and Tim.
-
- Remove most of the "zombie" mode from the profiler. Next we will need
- to remove the client callback mechanism in profiles.
- - These changes are a result of changes to JSCore.
-
- * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
- * page/Console.cpp:
- (WebCore::retrieveLastCaller):
- (WebCore::Console::profileEnd):
- * page/InspectorController.cpp:
- (WebCore::InspectorController::stopUserInitiatedProfiling):
-
-2008-09-03 Adele Peterson <adele@apple.com>
-
- Reviewed by Darin Adler.
-
- Test: fast/forms/search-display-none-cancel-button.html
-
- Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
-
- * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
- (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
- (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
- (WebCore::RenderTextControl::createSubtreeIfNeeded):
- Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
- (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
- (WebCore::RenderTextControl::subtreeHasChanged): ditto.
- (WebCore::RenderTextControl::calcHeight): ditto.
- (WebCore::RenderTextControl::nodeAtPoint): ditto.
- (WebCore::RenderTextControl::layout): ditto.
- (WebCore::RenderTextControl::calcPrefWidths): ditto.
- (WebCore::RenderTextControl::clientPaddingLeft): ditto.
- (WebCore::RenderTextControl::clientPaddingRight): ditto.
-
- * rendering/TextControlInnerElements.cpp:
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
- (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
- (WebCore::TextControlInnerElement::attachInnerElement): Added.
- This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
- (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
- * rendering/TextControlInnerElements.h:
-
-2008-08-28 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Maciej.
-
- Elminate SQLiteAuthorizer class.
-
- * WebCore.xcodeproj/project.pbxproj:
- * WebCore.vcproj/WebCore.vcproj:
- * GNUmakefile.am
- Removed SQLiteAuthorizer.h.
-
- * platform/sql/SQLiteAuthorizer.cpp:
- * platform/sql/SQLiteAuthorizer.h: Removed.
- * platform/sql/SQLiteDatabase.cpp:
- (WebCore::SQLiteDatabase::authorizerFunction):
- (WebCore::SQLiteDatabase::setAuthorizer):
- * platform/sql/SQLiteDatabase.h:
- * storage/DatabaseAuthorizer.h:
- (WebCore::DatabaseAuthorizer::create):
- (WebCore::DatabaseAuthorizer::createView):
- (WebCore::DatabaseAuthorizer::createTempView):
- (WebCore::DatabaseAuthorizer::dropView):
- (WebCore::DatabaseAuthorizer::dropTempView):
- (WebCore::DatabaseAuthorizer::allowSelect):
- (WebCore::DatabaseAuthorizer::allowReindex):
- Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
-
-2008-09-03 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Mark Rowe.
-
- WebKitGtk build fix.
-
- * GNUmakefile.am:
- * page/animation/AnimationController.h:
-
-2008-09-02 Robert Blaut <webkit@blaut.biz>
-
- Reviewed by Geoff Garen.
-
- Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
- Misplaced elements should not close DL lists.
-
- Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
-
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * editing/htmlediting.cpp:
+ (WebCore::canHaveChildrenForEditing):
+ * html/HTMLDataGridElement.h: Added.
+ (WebCore::HTMLDataGridElement::HTMLDataGridElement):
+ (WebCore::HTMLDataGridElement::tagPriority):
+ * html/HTMLDataGridElement.idl: Added.
+ * html/HTMLElement.cpp:
+ (WebCore::inlineTagList):
* html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleError):
-
-2008-09-02 Glenn Wilson <wilsong@gmail.com>
-
- Reviewed by Darin Adler.
-
- Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
- Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
-
- We would inappropriately interpret and apply an invalid CSS "color" property
- when the value is a predefined color preceded by a '#' symbol. For example,
- style="color:#gray;" would apply the color gray when it should not.
-
- In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
- This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
- interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
- an ignorable token.
-
- To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
- '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
- CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
-
- Test: css1/color_and_background/invalid_color.html
-
- * css/CSSGrammar.y:
+ (WebCore::HTMLParser::isAffectedByResidualStyle):
+ * html/HTMLTagNames.in:
-2008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
+2009-06-17 David Levin <levin@chromium.org>
- Reviewed by Darin Adler.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
- Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
+ Reviewed by NOBODY (chromium build fix).
- Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
+ Fix typo in previous changes.
- Test: css3/khtml-background-size-0x0-bmp.html
+ * rendering/RenderThemeChromiumSkia.cpp:
+ (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::repaintLayerRectsForImage):
-
-2008-09-02 Glenn Wilson <wilsong@gmail.com>
+2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
- Fix https://bugs.webkit.org/show_bug.cgi?id=20397
- Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
-
- The function checkForOrphanedUnits() would change the length of a list whose size was
- was already determined before the call to checkForOrphanedUnits was made. Later in
- the caller, the old size was being used for boundary management.
-
- This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
- calling function, before the size of the list is determined.
-
- Test: fast/css/orphaned_units_crash.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
-
-2008-09-02 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Darin Adler.
-
- Fallback on invalid fill or stroke styles in Canvas was
- transparent black. Changed it to last valid style.
-
- Canvas fillStyle() and strokeStyle() needs fallback
- https://bugs.webkit.org/show_bug.cgi?id=20474
-
- Tests: fast/canvas/canvas-invalid-fillstyle.html
- fast/canvas/canvas-invalid-strokestyle.html
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
-
-2008-09-02 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Darin Adler.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20468
- Updated drawImage() in canvas to match the current specification.
-
- Test: fast/canvas/drawImage-with-negative-source-destination.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::normalizeRect):
- (WebCore::CanvasRenderingContext2D::drawImage):
-
-2008-08-26 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/5768210> Switch back to the system version of SQLite
-
- Use the system version of SQLite when it is new enough to provide the functionality
- that WebCore requires.
-
- * Configurations/Base.xcconfig:
- * Configurations/DebugRelease.xcconfig:
- * Configurations/WebCore.xcconfig:
-
-2008-09-02 Dan Bernstein <mitz@apple.com>
-
- - build fix
-
- * page/animation/AnimationBase.h:
-
-2008-09-02 Chris Marrin <cmarrin@apple.com>
-
- Reviewed by Dave Hyatt.
-
- AnimationController.cpp should be split into separate files
- https://bugs.webkit.org/show_bug.cgi?id=20604
-
- Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
- recommendation of Dave Hyatt.
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Build files.
-
- * page/AnimationController.cpp: Removed.
- * page/AnimationController.h: Removed.
- * page/animation: Added.
- * page/animation/AnimationBase.cpp: Added.
- * page/animation/AnimationBase.h: Added.
- * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
- * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
- * page/animation/CompositeAnimation.cpp: Added.
- * page/animation/CompositeAnimation.h: Added.
- * page/animation/ImplicitAnimation.cpp: Added.
- * page/animation/ImplicitAnimation.h: Added.
- * page/animation/KeyframeAnimation.cpp: Added.
- * page/animation/KeyframeAnimation.h: Added.
-
-2008-09-02 Dan Bernstein <mitz@apple.com>
-
- - release build fix
-
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::calculateDrawingMode):
-
-2008-09-02 Timothy Hatcher <timothy@apple.com>
-
- Make console functions log the correct resource URL and
- line number for where the call originated.
-
- https://bugs.webkit.org/show_bug.cgi?id=17234
- <rdar://problem/5732837>
-
- Reviewed by Kevin McCullough.
-
- Test: manual-tests/inspector/console-call-line-numbers.html
-
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::count): Call the impl.
- (WebCore::JSConsole::timeEnd): Ditto.
- * manual-tests/inspector/console-call-line-numbers.html: Added.
- * manual-tests/inspector/resources/script-console-calls.js: Added.
- * page/Console.cpp:
- (WebCore::retrieveLastCaller): Helper to get the URL and line.
- (WebCore::Console::error): Call retrieveLastCaller to get the URL and
- line number to pass to addMessageToConsole.
- (WebCore::Console::info): Ditto.
- (WebCore::Console::log): Ditto.
- (WebCore::Console::assertCondition): Ditto.
- (WebCore::Console::count): Ditto.
- (WebCore::Console::timeEnd): Ditto.
- (WebCore::Console::warn): Ditto.
- * page/Console.h:
- * page/Console.idl: Make count and timeEnd custom.
-
-2008-09-02 Timothy Hatcher <timothy@apple.com>
-
- Removed IDL files from WebCore's framework resources.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-09-02 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
-
- * html/HTMLParser.cpp:
- (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
- cap on the number of consecutive identical residual style tags to
- reopen.
- (WebCore::HTMLParser::popBlock): Ditto.
-
-2008-09-02 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Adam Roben.
-
- A little database quota management cleanup.
-
- * storage/OriginQuotaManager.cpp:
- (WebCore::OriginQuotaManager::OriginQuotaManager):
- (WebCore::OriginQuotaManager::lock):
- (WebCore::OriginQuotaManager::unlock):
- (WebCore::OriginQuotaManager::trackOrigin):
- (WebCore::OriginQuotaManager::tracksOrigin):
- (WebCore::OriginQuotaManager::addDatabase):
- (WebCore::OriginQuotaManager::removeDatabase):
- (WebCore::OriginQuotaManager::removeOrigin):
- (WebCore::OriginQuotaManager::markDatabase):
- (WebCore::OriginQuotaManager::diskUsage):
- * storage/OriginQuotaManager.h:
- Changed to assert that a lock is taken more directly and reliably. Removed comments about
- main/background threads, as this is likely to stop being true with synchronous Database calls
- being made on worker threads.
-
- * storage/OriginUsageRecord.cpp:
- (WebCore::OriginUsageRecord::OriginUsageRecord):
- (WebCore::OriginUsageRecord::addDatabase):
- (WebCore::OriginUsageRecord::removeDatabase):
- (WebCore::OriginUsageRecord::markDatabase):
- (WebCore::OriginUsageRecord::diskUsage):
- * storage/OriginUsageRecord.h:
- (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
- Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
- can be replaced with a single boolean for OriginUsageRecord.
- Added assertions for string parameters being unshared.
-
-
-2008-09-01 Adam Barth <abarth@webkit.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=19760
-
- Make granting LoadLocalResources conditional on a policy.
-
- * WebCore.base.exp:
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::setLocalLoadPolicy):
- (WebCore::FrameLoader::restrictAccessToLocal):
- * loader/FrameLoader.h:
- (WebCore::FrameLoader::):
- * platform/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::grantLoadLocalResources):
- * platform/SecurityOrigin.h:
-
-2008-09-01 Dean Jackson <dino@apple.com>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=20571
- Make sure Window object can assign Animation/Transition event
- listeners via attributes.
-
- Also added a bunch of transition event tests, although
- only transition-end-event-window is directly relevant to this patch.
-
- (WebCore::JSDOMWindowBase::put):
-
- Tests: transitions/transition-end-event-all-properties.html
- transitions/transition-end-event-attributes.html
- transitions/transition-end-event-container.html
- transitions/transition-end-event-left.html
- transitions/transition-end-event-multiple-01.html
- transitions/transition-end-event-multiple-02.html
- transitions/transition-end-event-multiple-03.html
- transitions/transition-end-event-multiple-04.html
- transitions/transition-end-event-nested.html
- transitions/transition-end-event-transform.html
- transitions/transition-end-event-window.html
-
-2008-09-01 Dean Jackson <dino@apple.com>
-
- Reviewed by Sam Weinig
-
- Code styling cleanup.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::getValueProperty):
- (WebCore::JSDOMWindowBase::put):
-
-2008-09-01 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Darin Adler.
-
- First cut at inline caching for access to vanilla JavaScript properties.
-
- Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
- to WebCore classes, and PutPropertySlot& arguments to put functions.
-
- (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
- inline caching for global properties, so global assignment can be optimized.
-
- * ForwardingHeaders/kjs/StructureID.h: Added.
- * bindings/js/JSDOMBinding.h:
- (WebCore::DOMObject::DOMObject):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::put):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSDOMWindowCustom.h:
- (WebCore::JSDOMWindow::customPut):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::JSDOMWindowShell):
- (WebCore::JSDOMWindowShell::put):
- * bindings/js/JSDOMWindowShell.h:
- * bindings/js/JSEventTargetBase.h:
- (WebCore::JSEventTargetBase::put):
- * bindings/js/JSEventTargetNode.h:
- (WebCore::JSEventTargetNode::put):
- * bindings/js/JSHTMLAppletElementCustom.cpp:
- (WebCore::JSHTMLAppletElement::customPut):
- * bindings/js/JSHTMLEmbedElementCustom.cpp:
- (WebCore::JSHTMLEmbedElement::customPut):
- * bindings/js/JSHTMLInputElementBase.cpp:
- (WebCore::JSHTMLInputElementBase::put):
- * bindings/js/JSHTMLInputElementBase.h:
- * bindings/js/JSHTMLObjectElementCustom.cpp:
- (WebCore::JSHTMLObjectElement::customPut):
- * bindings/js/JSHistoryCustom.cpp:
- (WebCore::JSHistory::customPut):
- * bindings/js/JSInspectedObjectWrapper.cpp:
- (WebCore::JSInspectedObjectWrapper::wrap):
- (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
- * bindings/js/JSInspectedObjectWrapper.h:
- * bindings/js/JSInspectorCallbackWrapper.cpp:
- (WebCore::JSInspectorCallbackWrapper::wrap):
- (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
- * bindings/js/JSInspectorCallbackWrapper.h:
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::customPut):
- * bindings/js/JSPluginElementFunctions.cpp:
- (WebCore::runtimeObjectCustomPut):
- * bindings/js/JSPluginElementFunctions.h:
- * bindings/js/JSQuarantinedObjectWrapper.cpp:
- (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
- (WebCore::JSQuarantinedObjectWrapper::put):
- * bindings/js/JSQuarantinedObjectWrapper.h:
- * bindings/js/JSStorageCustom.cpp:
- (WebCore::JSStorage::customPut):
- * bindings/objc/WebScriptObject.mm:
- (-[WebScriptObject setValue:forKey:]):
- * bindings/scripts/CodeGeneratorJS.pm:
- * bridge/NP_jsobject.cpp:
- (_NPN_SetProperty):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::setMember):
- * bridge/objc/objc_class.mm:
- (KJS::Bindings::ObjcClass::fallbackObject):
- * bridge/objc/objc_runtime.h:
- * bridge/objc/objc_runtime.mm:
- (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
- (ObjcFallbackObjectImp::put):
- * bridge/runtime.cpp:
- (KJS::Bindings::Instance::createRuntimeObject):
- * bridge/runtime_array.cpp:
- (RuntimeArray::put):
- * bridge/runtime_array.h:
- * bridge/runtime_object.cpp:
- (RuntimeObjectImp::RuntimeObjectImp):
- (RuntimeObjectImp::put):
- * bridge/runtime_object.h:
-
-2008-09-01 Dirk Schulze <vbs85@gmx.de>
+ https://bugs.webkit.org/show_bug.cgi?id=26148
+ Remove common code from RenderThemeChromiumWin that is shared with
+ RenderThemeChromiumSkia.
- Reviewed by Eric Seidel.
+ Also move supportsControlTints to RenderThemeChromiumLinux since it
+ is linux specific.
- Fixed border-radius for Cairo.
+ There are no tests changed because this just removes functions with
+ duplicate implementations between the base and derived classes.
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::strokeArc):
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::supportsControlTints):
+ * rendering/RenderThemeChromiumLinux.h:
+ * rendering/RenderThemeChromiumSkia.cpp:
+ * rendering/RenderThemeChromiumSkia.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::):
+ (WebCore::getNonClientMetrics):
+ (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
+ (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
+ (WebCore::RenderThemeChromiumWin::systemFont):
+ (WebCore::RenderThemeChromiumWin::paintCheckbox):
+ (WebCore::RenderThemeChromiumWin::paintRadio):
+ (WebCore::RenderThemeChromiumWin::paintSliderThumb):
+ (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
+ * rendering/RenderThemeChromiumWin.h:
-2008-09-01 Dirk Schulze <vbs85@gmx.de>
+2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
- Added canvas's globalAlpha to cairo.
-
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::setAlpha):
- (WebCore::GraphicsContext::getAlpha):
- * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::draw):
-
-2008-08-31 Simon Hausmann <hausmann@webkit.org>
-
- Unreviewed Qt build fix.
-
- * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
- the .h file
-
-2008-08-30 Darin Adler <darin@apple.com>
-
- Reviewed by Maciej.
-
- - adopt some new JavaScriptCore functions where appropriate
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
- (WebCore::windowProtoFuncBToA): Ditto.
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSLazyEventListener::eventParameterName): Adopted
- jsNontrivialString.
- * bindings/js/JSSVGLazyEventListener.cpp:
- (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
-
-2008-08-29 Brady Eidson <beidson@apple.com>
-
- Reviewed by Anders' rubberstamp
-
- Style cleanup to match MediaTokenizer::writeRawData()
-
- * loader/PluginDocument.cpp:
- (WebCore::PluginTokenizer::writeRawData):
-
-2008-08-29 Brady Eidson <beidson@apple.com>
-
- Reviewed by Anders
-
- https://bugs.webkit.org/show_bug.cgi?id=20556
- <rdar://problem/6181817> REGRESSION (r35946): media/video-click-dlbclick-standalone.html [sic] fails because load never fires
-
- Fix regression I introducted in 35946
- Already covered by media/video-click-dlbclick-standalone.html
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
- (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
- an ASSERT signifying that this method should only be called once, to more closely follow the
- PluginDocument case.
-
-2008-08-29 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for <rdar://problem/6181588>
-
- This patch makes hit testing take into account the new concept of a
- disconnected frame, in which some of the content may not be
- visible. The current hit testing mechanism starts at a target frame
- and drills down for a HitTestResult. In some cases, drilling down
- will find a non-visible result. When this happens, we need to try
- again, starting at a higher level -- namely, starting at the main
- frame.
-
- * editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea): New function that tests if a
- point is inside the visible area for a disconnected frame.
- * editing/Editor.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
-
-2008-08-29 Adele Peterson <adele@apple.com>
-
- Reviewed by Adam Roben.
-
- Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * html/HTMLTextFieldInnerElement.cpp: Removed.
- * html/HTMLTextFieldInnerElement.h: Removed.
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::createSubtreeIfNeeded):
- * rendering/RenderTextControl.h:
- * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
- (WebCore::TextControlInnerElement::TextControlInnerElement):
- (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
- (WebCore::TextControlInnerTextElement::defaultEventHandler):
- (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
- (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
-
-2008-08-29 Eric Seidel <eric@webkit.org>
-
- Rubber-stamped by aroben.
-
- Add GraphicsContext.h include to GraphcisContextPrivate.h
-
- GraphicsContextPrivate uses StrokeStyle which is defined
- in GraphicsContext.h but it doesn't include that header.
- CoreGraphics build doesn't fail here due to the order
- it happens to include files.
-
- * platform/graphics/GraphicsContextPrivate.h:
-
-2008-08-29 Eric Seidel <eric@webkit.org>
-
- Reviewed by hyatt.
-
- Fix GeneratedImage to respect Image's refcounting
- Fixing potential crashers (future if not current)
- https://bugs.webkit.org/show_bug.cgi?id=20567
-
- I don't know if it's possible to make the current code
- crash, thus I've not made a test.
-
- * css/CSSGradientValue.cpp:
- (WebCore::CSSGradientValue::image):
- * css/CSSImageGeneratorValue.cpp:
- (WebCore::CSSImageGeneratorValue::removeClient):
- (WebCore::CSSImageGeneratorValue::getImage):
- * css/CSSImageGeneratorValue.h:
- * platform/graphics/GeneratedImage.h:
- (WebCore::GeneratedImage::GeneratedImage):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::setContent):
- * rendering/style/RenderStyle.h:
-
-2008-08-29 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele.
-
- Fix for <rdar://problem/6093767>
- https://bugs.webkit.org/show_bug.cgi?id=20526
-
- Don't allow video to render until unsupported track types have been disabled.
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWinPrivate::task):
- (QTMovieWinPrivate::drawingComplete):
- (QTMovieWinPrivate::clearGWorld):
-
-2008-08-29 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
- <rdar://problem/6169301>
-
- Return the size of the movie data instead of 1000.
-
- Test: media/progress-event-total.html
-
- * platform/graphics/win/QTMovieWin.cpp:
- (QTMovieWin::dataSize):
+ https://bugs.webkit.org/show_bug.cgi?id=26148
+ Move RenderThemeChromiumSkia into its own file. This is purely a code move.
-2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
+ * rendering/RenderThemeChromiumLinux.cpp:
+ * rendering/RenderThemeChromiumLinux.h:
+ * rendering/RenderThemeChromiumSkia.cpp:
+ (WebCore::):
+ (WebCore::setSizeIfAuto):
+ (WebCore::mediaElementParent):
+ (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
+ (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia):
+ (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia):
+ (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::supportsHover):
+ (WebCore::RenderThemeChromiumSkia::supportsFocusRing):
+ (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor):
+ (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
+ (WebCore::RenderThemeChromiumSkia::systemFont):
+ (WebCore::RenderThemeChromiumSkia::minimumMenuListSize):
+ (WebCore::RenderThemeChromiumSkia::paintCheckbox):
+ (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
+ (WebCore::RenderThemeChromiumSkia::paintRadio):
+ (WebCore::RenderThemeChromiumSkia::setRadioSize):
+ (WebCore::brightenColor):
+ (WebCore::paintButtonLike):
+ (WebCore::RenderThemeChromiumSkia::paintButton):
+ (WebCore::RenderThemeChromiumSkia::paintTextField):
+ (WebCore::RenderThemeChromiumSkia::paintTextArea):
+ (WebCore::RenderThemeChromiumSkia::paintSearchField):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
+ (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal):
+ (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
+ (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
+ (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
+ (WebCore::RenderThemeChromiumSkia::paintMenuList):
+ (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintMenuListButton):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom):
+ (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal):
+ (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
+ * rendering/RenderThemeChromiumSkia.h:
+ (WebCore::RenderThemeChromiumSkia::supportsControlTints):
+
+2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
- [janitor/qt] Start replacing port specific getters with the generic native getter
- To get the native presentation of an image we currently have platform
- specific #ifdef's and a generic getter using NativeImagePtr. This patch
- extends this to the ImageBuffer and updates the Qt platform to get rid
- of the special #ifdefs.
-
- https://bugs.webkit.org/attachment.cgi?id=22861
-
- * platform/graphics/BitmapImage.h:
- * platform/graphics/Image.h:
- * platform/graphics/qt/ImageQt.cpp:
- * platform/graphics/qt/StillImageQt.cpp:
- * platform/graphics/qt/StillImageQt.h:
- * platform/qt/ClipboardQt.cpp:
- (WebCore::ClipboardQt::createDragImage):
- (WebCore::ClipboardQt::declareAndWriteDragImage):
- * platform/qt/CursorQt.cpp:
- * platform/qt/PasteboardQt.cpp:
- (WebCore::Pasteboard::writeImage):
-
-2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon.
-
- [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
-
- * svg/graphics/qt/SVGPaintServerQt.cpp:
- (WebCore::SVGPaintServer::renderPath):
- * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
- (WebCore::SVGPaintServerSolid::setup):
-
-2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon.
-
- [network/qt] Implement defering of loading ResourceHandle's
- This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
- implementation is simply not forwarding anything to the
- ResourceHandleClient until we are allowed to. This might lead to a deadlock
- in Qt as we do not empty the QNetworkReply input buffer and wait until we
- are allowed to read. If that happens we are forced to buffer the data
- within QNetworkReplyHandler, for now this is not done.
-
- Manual test:
- - Open http://acid3.acidtests.org
- - Wait for the test to complete
- - Click on the Reference Rendering link
- - Be fast and see the results of acid3
- => assert
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
- (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
- (WebCore::QNetworkReplyHandler::setLoadMode):
- (WebCore::QNetworkReplyHandler::finish):
- (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- (WebCore::QNetworkReplyHandler::forwardData):
- (WebCore::QNetworkReplyHandler::start):
- (WebCore::QNetworkReplyHandler::resetState):
- (WebCore::QNetworkReplyHandler::sendQueuedItems):
- * platform/network/qt/QNetworkReplyHandler.h:
- (WebCore::QNetworkReplyHandler::):
- * platform/network/qt/ResourceHandleQt.cpp:
- (WebCore::ResourceHandle::start):
- (WebCore::ResourceHandle::loadResourceSynchronously):
- (WebCore::ResourceHandle::setDefersLoading):
-
-2008-08-29 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Holger.
-
- Don't crash when drawing patterns with the HTML canvas. Patterns
- remain unimplemented but at least they don't crash anymore. This is
- done by changing the PlatformPatternPtr to be a brush for the Qt
- platform.
-
- * platform/graphics/Pattern.h:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- * platform/graphics/qt/PatternQt.cpp:
- (WebCore::Pattern::createPlatformPattern):
-
-2008-08-29 Simon Hausmann <hausmann@webkit.org>
-
- Fix the Qt build, fontSelector() is not used by the Qt port yet
- and we just return 0 in Font::fontSelector().
-
- * platform/graphics/Font.h:
-
-2008-08-28 Alp Toker <alp@nuanti.com>
-
- GTK+ dist/build fix. List newly added header files.
-
- * GNUmakefile.am:
-
-2008-08-28 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Various WebKitCSSTransformValue-related fixes
- https://bugs.webkit.org/show_bug.cgi?id=20562
+ https://bugs.webkit.org/show_bug.cgi?id=26148
+ Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
+ is mostly a code shuffle. The non-suffle changes are:
+ 1) Creation of a caretBlinkIntervalInternal.
+ 2) Moving of some inline functions into the implementation files.
+ 3) Changing of defaultGUIFont into a static class constant from a
+ static function. Also the type is changed to String.
+ 4) Changing of defaultFontSize into a static class constant from a
+ static variable in the file scope.
+ 5) The static supportsFocus function was collapsed into
+ supportsFocusRing.
+ 6) Split the extraDefaultStyleSheet into Skia and Linux versions.
- Test: css3/transform-value-types.html
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
+ (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia):
+ (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia):
+ (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::supportsHover):
+ (WebCore::RenderThemeChromiumSkia::supportsFocusRing):
+ (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor):
+ (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor):
+ (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
+ (WebCore::RenderThemeChromiumSkia::systemFont):
+ (WebCore::RenderThemeChromiumSkia::minimumMenuListSize):
+ (WebCore::RenderThemeChromiumSkia::paintCheckbox):
+ (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
+ (WebCore::RenderThemeChromiumSkia::paintRadio):
+ (WebCore::RenderThemeChromiumSkia::setRadioSize):
+ (WebCore::RenderThemeChromiumSkia::paintButton):
+ (WebCore::RenderThemeChromiumSkia::paintTextField):
+ (WebCore::RenderThemeChromiumSkia::paintTextArea):
+ (WebCore::RenderThemeChromiumSkia::paintSearchField):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
+ (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal):
+ (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
+ (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
+ (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
+ (WebCore::RenderThemeChromiumSkia::paintMenuList):
+ (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
+ (WebCore::RenderThemeChromiumSkia::paintMenuListButton):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop):
+ (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop):
+ (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom):
+ (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal):
+ (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
+ (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
+ (WebCore::RenderThemeChromiumLinux::systemColor):
+ (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
+ * rendering/RenderThemeChromiumLinux.h:
- * bindings/js/JSCSSValueCustom.cpp:
- (WebCore::toJS):
- * css/CSSValue.h:
- * css/WebKitCSSTransformValue.cpp:
- (WebCore::WebKitCSSTransformValue::cssText):
- * css/WebKitCSSTransformValue.h:
- (WebCore::WebKitCSSTransformValue::):
- * css/WebKitCSSTransformValue.idl:
+2009-06-17 Adam Roben <aroben@apple.com>
-2008-08-28 Dan Bernstein <mitz@apple.com>
+ Add a SOFT_LINK_OPTIONAL macro
- Reviewed by Steve Falkenburg.
+ This macro is useful when soft-linking functions that are present in
+ only some versions of a particular library (e.g., APIs added in
+ Windows Vista that aren't available on Windows XP).
- - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
+ Reviewed by Ada Chan.
- * platform/win/SharedTimerWin.cpp:
- (WebCore::TimerWindowWndProc):
+ * platform/graphics/win/ColorSafari.cpp:
+ (WebCore::focusRingColor):
+ Use the SoftLinking.h macros instead of doing the soft-link ourselves.
+ Also removed an unused call to focusRingColor.isValid().
-2008-08-28 David Hyatt <hyatt@apple.com>
+ * platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
- RenderStyle cleanup.
+2009-06-17 Brent Fulgham <bfulgham@webkit.org>
- Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
+ Reviewed by Gustavo Noronha.
- Reviewed by Adam
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
+ The use of zero-width or zero-height rectangles in generating
+ gradients caused Windows Cairo to crash, and webkitgtk to
+ produce invalid images.
- * css/CSSImageGeneratorValue.cpp:
- * css/CSSImageValue.cpp:
- * css/CSSStyleSelector.cpp:
- * rendering/RenderImageGeneratedContent.cpp:
- * rendering/style/NinePieceImage.cpp: Added.
- * rendering/style/NinePieceImage.h: Added.
- * rendering/style/RenderStyle.cpp:
- (WebCore::FillLayer::operator==):
- (WebCore::FillLayer::containsImage):
- (WebCore::StyleInheritedData::operator==):
- (WebCore::RenderStyle::contentDataEquivalent):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleCachedImage.cpp: Added.
- * rendering/style/StyleCachedImage.h: Added.
- * rendering/style/StyleGeneratedImage.cpp: Added.
- * rendering/style/StyleGeneratedImage.h: Added.
- * rendering/style/StyleImage.h: Added.
-
-2008-08-28 Simon Fraser <simon.fraser@apple.com>
+ We now test for NaN in the phase argument, which is calculated
+ using fmodf and can blow up when the width/height values passed
+ are zero.
- Reviewed by Dave Hyatt
+ Test: fast/gradients/border-image-gradient-sides-and-corners.html
- Make all the 'isFoo()' methods on CSSValue const,
- and fix the subclasses.
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::Image::drawPattern):
- https://bugs.webkit.org/show_bug.cgi?id=20561
+2009-06-17 Ojan Vafai <ojan@chromium.org>
- * css/CSSTimingFunctionValue.h:
- * css/CSSValue.h:
- (WebCore::CSSValue::isFontValue):
- (WebCore::CSSValue::isImageGeneratorValue):
- (WebCore::CSSValue::isImageValue):
- (WebCore::CSSValue::isImplicitInitialValue):
- * css/CSSValueList.h:
- * css/FontValue.h:
+ Reviewed by Dimitri Glazkov.
-2008-08-28 David Hyatt <hyatt@apple.com>
+ If loading a font fails because of the sandbox, we ask the browser process to
+ try to load it by calling ensureFontLoaded. If it still fails after
+ ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
- The great RenderStyle cleanup begins!
+ This case happens once in a while during browser shutdown. The browser will
+ queue a message to the renderer to shutdown, and will then stop answering sync
+ messages from the renderer. If the renderer is still loading a page during this
+ time, it might try to call the browser process to ask to load a font. The
+ browser process will ignore the request, and the font will fail to load, even
+ after the second try.
- Move LengthBox and LengthSize out of RenderStyle and into Length.
+ This is unfortunate, but there is no real risk here, since the renderer will be
+ going away as soon as it processes another message.
+
+ This can't be layout tested as it depends on the sandbox.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26484
- Reviewed by Adam
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ (WebCore::fontContainsCharacter):
- * rendering/Length.h:
- (WebCore::):
- (WebCore::Length::Length):
- (WebCore::Length::operator==):
- (WebCore::Length::operator!=):
- (WebCore::Length::value):
- (WebCore::Length::rawValue):
- (WebCore::Length::percent):
- (WebCore::Length::type):
- (WebCore::Length::quirk):
- (WebCore::Length::setValue):
- (WebCore::Length::setRawValue):
- (WebCore::Length::calcValue):
- (WebCore::Length::calcMinValue):
- (WebCore::Length::calcFloatValue):
- (WebCore::Length::isUndefined):
- (WebCore::Length::isZero):
- (WebCore::Length::isPositive):
- (WebCore::Length::isNegative):
- (WebCore::Length::isAuto):
- (WebCore::Length::isRelative):
- (WebCore::Length::isPercent):
- (WebCore::Length::isFixed):
- (WebCore::Length::isStatic):
- (WebCore::Length::isIntrinsicOrAuto):
- (WebCore::Length::blend):
- (WebCore::LengthBox::LengthBox):
- (WebCore::LengthBox::operator=):
- (WebCore::LengthBox::operator==):
- (WebCore::LengthBox::operator!=):
- (WebCore::LengthBox::nonZero):
- (WebCore::LengthSize::LengthSize):
- * rendering/style/RenderStyle.h:
-
-2008-08-28 David Hyatt <hyatt@apple.com>
-
- Reviewed by Darin
-
- https://bugs.webkit.org/show_bug.cgi?id=18091
-
- font-size should be animatable using -webkit-transition.
-
- * page/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::ensurePropertyMap):
- * rendering/style/RenderStyle.h:
- (WebCore::RenderStyle::setFontSize):
-
-2008-08-28 Brad Garcia <bgarcia@google.com>
+2009-06-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=20549
- Correctly determine when cursor is over a resizable border within
- a nested frameset.
+ https://bugs.webkit.org/show_bug.cgi?id=26482
+ <rdar://problem/6978590> When setting playback rate to 0, the audio element stops
+ playing (doesn't resume later)
- * rendering/RenderFrameSet.cpp:
- (WebCore::RenderFrameSet::canResizeRow):
- (WebCore::RenderFrameSet::canResizeColumn):
-
-2008-08-28 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
- https://bugs.webkit.org/show_bug.cgi?id=20552
-
- Test: animations/animation-css-rule-types.html
-
- * css/CSSRule.idl:
-
-2008-08-28 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Kevin and Darin.
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
- <rdar://problem/6182541>
- https://bugs.webkit.org/show_bug.cgi?id=20202
- Missing http status line from the http headers.
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::setRate): Ditto.
- Add a status line to the header string.
+2009-06-17 Adam Roben <aroben@apple.com>
- * plugins/PluginStream.cpp:
- (WebCore::PluginStream::startStream):
+ Add all the generated JS*.cpp files back to WebCore.vcproj
-2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
+ They are not compiled by the vcproj directly. Instead they are
+ compiled as part of DerivedSources.cpp. Having them listed in the
+ vcproj makes them be included in Project Find, etc.
- Rubber-stamped by Darin Adler.
+ Rubber-stamped in advance by Steve Falkenburg.
- https://bugs.webkit.org/show_bug.cgi?id=17261
+ * WebCore.vcproj/WebCore.vcproj:
- Make it possible to theme the default Url icon and enable this for
- the Qt port. To have a minimal usage of #ifdef in the code the setting
- of the icon was moved to a new method which comes in two flavors.
+2009-06-17 Kent Tamura <tkent@chromium.org>
- * loader/icon/IconDatabase.cpp:
- (WebCore::loadDefaultIconRecord): Load or set the default icon
- (WebCore::IconDatabase::defaultIcon):
+ Reviewed by Darin Fisher.
-2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
+ Don't fire redundant 'change' events for a file upload form.
+ https://bugs.webkit.org/show_bug.cgi?id=26471
- Unreviewed compile fix
+ * platform/FileChooser.cpp:
+ (WebCore::FileChooser::chooseFiles): Suppress change event if the
+ existing selected files and the incoming selected files are equal.
+ (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected
+ files.
- * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
+2009-06-17 Adam Treat <adam.treat@torchmobile.com>
-2008-08-28 Adam Roben <aroben@apple.com>
+ Reviewed by George Staikos.
- Windows (and others?) build fix
+ https://bugs.webkit.org/show_bug.cgi?id=23155
+ Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- * page/Chrome.cpp: Added a missing #include.
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
+ * platform/KeyboardCodes.h:
-2008-08-27 Eric Seidel <eric@webkit.org>
+2009-06-17 George Staikos <george.staikos@torchmobile.com>
- Reviewed by Oliver Hunt.
+ Reviewed by Adam Treat.
- Qt and Cairo support from krit (and blind stab @ wx compile support)
- https://bugs.webkit.org/show_bug.cgi?id=20373
+ https://bugs.webkit.org/show_bug.cgi?id=23155
+ Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::drawPath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::setPlatformFillColor):
- (WebCore::GraphicsContext::setPlatformStrokeColor):
- (WebCore::GraphicsContext::setPlatformStrokeStyle):
- (WebCore::GraphicsContext::strokeRect):
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::imageInterpolationQuality):
- (WebCore::GraphicsContext::setPlatformFillPattern):
- (WebCore::GraphicsContext::setPlatformStrokePattern):
- (WebCore::GraphicsContext::setPlatformFillGradient):
- (WebCore::GraphicsContext::setPlatformStrokeGradient):
* platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::strokeRect):
- (WebCore::GraphicsContext::clipToImageBuffer):
- (WebCore::GraphicsContext::setPlatformFillPattern):
- (WebCore::GraphicsContext::setPlatformStrokePattern):
- (WebCore::GraphicsContext::setPlatformFillGradient):
- (WebCore::GraphicsContext::setPlatformStrokeGradient):
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::imageInterpolationQuality):
- * platform/graphics/wx/GraphicsContextWx.cpp:
- (WebCore::GraphicsContext::clipToImageBuffer):
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::imageInterpolationQuality):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::drawPath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::setPlatformFillPattern):
- (WebCore::GraphicsContext::setPlatformStrokePattern):
- (WebCore::GraphicsContext::setPlatformFillGradient):
-
-2008-08-27 Eric Seidel <eric@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
- https://bugs.webkit.org/show_bug.cgi?id=20373
-
- Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
-
- Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
- have to store large Gradient objects in the GraphicsContextState
-
- Made Pattern RefCounted for the same reason.
-
- Many updates to GraphicsContext to support easier drawing with
- Patterns and Gradients.
-
- * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
- * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- (WebCore::toJS):
- * css/CSSGradientValue.cpp:
- (WebCore::CSSGradientValue::createGradient):
- * css/CSSGradientValue.h:
- * html/CanvasGradient.cpp:
- (WebCore::CanvasGradient::CanvasGradient):
- * html/CanvasGradient.h:
- (WebCore::CanvasGradient::gradient):
- (WebCore::CanvasGradient::addColorStop):
- (WebCore::CanvasGradient::getColor):
- * html/CanvasPattern.cpp:
- * html/CanvasPattern.h:
- (WebCore::CanvasPattern::pattern):
- (WebCore::CanvasPattern::originClean):
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::State::State):
- (WebCore::CanvasRenderingContext2D::setStrokeStyle):
- (WebCore::CanvasRenderingContext2D::setFillStyle):
- (WebCore::CanvasRenderingContext2D::fill):
- (WebCore::CanvasRenderingContext2D::stroke):
- (WebCore::CanvasRenderingContext2D::fillRect):
- (WebCore::CanvasRenderingContext2D::strokeRect):
- * html/CanvasRenderingContext2D.h:
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
- * html/CanvasStyle.h:
- * platform/graphics/GeneratedImage.h:
- (WebCore::GeneratedImage::GeneratedImage):
- * platform/graphics/Generator.h:
- * platform/graphics/Gradient.h:
- (WebCore::Gradient::create):
- * platform/graphics/GraphicsContext.cpp:
- (WebCore::GraphicsContext::fillRule):
- (WebCore::GraphicsContext::setFillRule):
- (WebCore::GraphicsContext::setStrokePattern):
- (WebCore::GraphicsContext::setFillPattern):
- (WebCore::GraphicsContext::setStrokeGradient):
- (WebCore::GraphicsContext::setFillGradient):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/GraphicsContextPrivate.h:
- (WebCore::):
- (WebCore::GraphicsContextState::GraphicsContextState):
- * platform/graphics/GraphicsTypes.h:
- * platform/graphics/Path.h:
- * platform/graphics/Pattern.h:
- (WebCore::Pattern::create):
- (WebCore::Pattern::tileImage):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::drawRect):
- (WebCore::GraphicsContext::drawEllipse):
- (WebCore::GraphicsContext::drawConvexPolygon):
- (WebCore::calculateDrawingMode):
- (WebCore::GraphicsContext::drawPath):
- (WebCore::fillPathWithFillRule):
- (WebCore::GraphicsContext::fillPath):
- (WebCore::GraphicsContext::strokePath):
- (WebCore::GraphicsContext::fillRect):
- (WebCore::GraphicsContext::fillRoundedRect):
- (WebCore::GraphicsContext::setPlatformStrokePattern):
- (WebCore::GraphicsContext::setPlatformFillPattern):
- (WebCore::GraphicsContext::setPlatformStrokeGradient):
- (WebCore::GraphicsContext::setPlatformFillGradient):
-
-2008-08-20 Eric Seidel <eric@webkit.org>
-
- Reviewed by Darin and Alexey.
-
- Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
- with timeouts paused.
- https://bugs.webkit.org/show_bug.cgi?id=20469
-
- I attempted to clean up the memory management of PausedTimeouts, I'm not
- sure the solution I came up with is "cleaner", but it's in some ways
- "safer", since it no longer uses raw pointers and manual new/delete.
-
- This also now prevents CachedPage from needlessly creating Window
- objects when caching pages which didn't already have one. :)
-
- I also made Chrome.cpp no longer depend on the JavaScript bindings
- (aka JSDOMWindowBase.h), since there was no real reason for it to.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::pauseTimeouts):
- (WebCore::JSDOMWindowBase::resumeTimeouts):
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::pauseTimeouts):
- (WebCore::ScriptController::resumeTimeouts):
- * bindings/js/ScriptController.h:
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- * page/Chrome.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- * page/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
- (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
-
-2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed compile fix
-
- Add the stub for the Qt port.
-
- * WebCore.pro:
- * page/qt/AccessibilityObjectQt.cpp: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
-
-2008-08-27 Alp Toker <alp@nuanti.com>
-
- Reviewed by Eric.
-
- https://bugs.webkit.org/show_bug.cgi?id=20551
- [GTK] search popup crash
-
- * platform/gtk/SearchPopupMenuGtk.cpp:
- (WebCore::SearchPopupMenu::enabled):
- Fix a search popup crasher by disabling the history popup since we
- don't support this feature yet in the GTK+ port.
-
-2008-08-27 Alp Toker <alp@nuanti.com>
-
- Reviewed by Eric.
-
- https://bugs.webkit.org/show_bug.cgi?id=20551
- [GTK] curl crashers
-
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::ResourceHandleManager::startScheduledJobs):
- Remove the resource handle from the pending list before starting the
- job, not afterwards. Fixes crashers in the test suite.
-
- Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
- Test: fast/encoding/char-encoding.html
-
-2008-08-27 Dirk Schulze <vbs85@gmx.de>
+ (WebCore::GraphicsContext::getWindowsContext):
+ * platform/win/SystemTimeWin.cpp:
+ (WebCore::userIdleTime):
- Reviewed by eseidel.
+2009-06-17 Adam Roben <aroben@apple.com>
- Fix canvas drawImage to support composite operations.
- Composite had no effect on canvas elements like these:
- http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
+ Speculative Mac build fix
- [CAIRO] Canvas composite don't work on canvas-elements.
- https://bugs.webkit.org/show_bug.cgi?id=20548
+ * page/Page.h: Forward-declare RenderTheme instead of including
+ RenderTheme.h so that we don't need to make RenderTheme.h a private
+ header for WebKit's benefit.
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
+ * editing/SelectionController.cpp:
+ * rendering/InlineTextBox.cpp:
+ * rendering/RenderObject.cpp:
+ Added #includes of RenderTheme.h.
-2008-08-27 Mario Bensi <mbensi@pleyo.com>
+2009-06-17 Adam Roben <aroben@apple.com>
- Reviewed by Eric Seidel.
+ Speculative Mac build fix
- Fix the data content of an image with a base64.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderTheme::create): Added.
- * platform/network/curl/ResourceHandleManager.cpp:
- (WebCore::parseDataUrl): Remove the String and use only the data
- Vector because the data.latin1().data() convert the data content and
- the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
- not drawn correctly.
+2009-06-17 Adam Roben <aroben@apple.com>
-2008-08-27 Antti Koivisto <antti@apple.com>
+ Speculative Mac build fix
- Reviewed by Eric Seidel.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderTheme::themeForPage): Remove the name of an unused
+ parameter.
- Crash after OK in dialog box and reloading page in secure mode
- https://bugs.webkit.org/show_bug.cgi?id=20493
+2009-06-17 Adam Roben <aroben@apple.com>
- The new run loop spawned by a modal dialog causes a timer in the loader to run
- synchronously inside didFinishLoading() deleting "this" object.
+ Speculative Mac build fix
- Defer all WebCore timers when a modal dialog is up. They are not
- safe to execute.
+ * page/Page.cpp:
+ (WebCore::Page::Page): Change the initializer order to match the
+ declaration order.
- * page/Chrome.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
-2008-08-27 Chris Marrin <cmarrin@apple.com>
+ Reviewed by Simon Hausmann.
- Reviewed by Dave Hyatt
+ Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
+ Patch that make WebCore have a RenderTheme per page
- Memory leaks when animating transforms
- https://bugs.webkit.org/show_bug.cgi?id=20532
+ Make the Qt implementation of RenderTheme create a theme per page,
+ and use the QStyle associated with the view of each page, in order
+ to make the QWidget setStyle() method work as advertised.
- * rendering/style/RenderStyle.cpp:
- (WebCore::ScaleTransformOperation::blend):
- (WebCore::RotateTransformOperation::blend):
- (WebCore::SkewTransformOperation::blend):
- (WebCore::TranslateTransformOperation::blend):
- (WebCore::MatrixTransformOperation::blend):
- * rendering/style/RenderStyle.h:
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::RenderThemeQt):
+ (WebCore::RenderThemeQt::qStyle):
+ (WebCore::findFrameLineWidth):
+ (WebCore::inflateButtonRect):
+ (WebCore::RenderThemeQt::adjustRepaintRect):
+ (WebCore::RenderThemeQt::isControlStyled):
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
+ (WebCore::RenderThemeQt::setButtonPadding):
+ (WebCore::RenderThemeQt::paintButton):
+ (WebCore::RenderThemeQt::paintTextField):
+ (WebCore::RenderThemeQt::setPopupPadding):
+ * platform/qt/RenderThemeQt.h:
-2008-08-27 Timothy Hatcher <timothy@apple.com>
+2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
- Add support for support for -webkit-appearance: default-button on the Mac platform.
+ Reviewed by Dave Hyatt and Adam Roben.
- <rdar://problem/6173530>
+ https://bugs.webkit.org/show_bug.cgi?id=26278
+ Patch that make WebCore have a RenderTheme per page
- Reviewed by Dave Hyatt.
- * WebCore.base.exp: Export new symbols.
- * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
- * platform/mac/WebCoreSystemInterface.mm: Ditto.
- * rendering/RenderButton.cpp:
- (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
- (WebCore::RenderButton::setStyle): Ditto.
- * rendering/RenderButton.h: Ditto.
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
- (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
- key if the button is default, otherwise reset the key equivalent.
- (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
- on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
- the window's previous default button cell when finished.
+ Create a different RenderTheme per page, so that RenderTheme has
+ access to page specific theming. This is needed for the Qt port, as Qt
+ supports setting the theme (style) per widget.
-2008-08-26 David Hyatt <hyatt@apple.com>
+ This change was suggested and discussed with Dave Hyatt.
- First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
+ More detailed:
- Reviewed by weinig
+ 1) Create a theme per page or one global one, depending on the needs
+ of the platform.
+ 2) Add an accesser to the theme from RenderObject.
+ 3) Change all uses of the theming to access the theme through
+ RenderObject, using the global default theme as fallback, when the
+ document of RenderObject has no page.
+ When we don't have access to a RenderObject, use the default theme.
+ 4) Modify all RenderTheme platform implementations to work with the
+ above changes, still creating only one global theme.
- Added fast/forms/zoomed-controls.html
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
* css/CSSStyleSelector.cpp:
- (WebCore::addIntrinsicMargins):
- * rendering/RenderSlider.cpp:
- (WebCore::RenderSlider::calcPrefWidths):
+ (WebCore::loadFullDefaultStyle):
+ (WebCore::CSSStyleSelector::styleForElement):
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ (WebCore::CSSStyleSelector::applyProperty):
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::setActive):
+ (WebCore::ContainerNode::setHovered):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::parseMappedAttribute):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setChecked):
+ (WebCore::HTMLInputElement::setIndeterminate):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionLayoutChanged):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateControlTints):
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ * page/Page.h:
+ (WebCore::Page::theme):
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::paintRow):
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::create):
+ (WebCore::RenderTheme::themeForPage):
+ (WebCore::RenderThemeGtk::RenderThemeGtk):
+ (WebCore::RenderThemeGtk::~RenderThemeGtk):
+ (WebCore::RenderThemeGtk::gtkEntry):
+ (WebCore::RenderThemeGtk::gtkTreeView):
+ * platform/gtk/RenderThemeGtk.h:
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::create):
+ (WebCore::RenderTheme::themeForPage):
+ * platform/qt/RenderThemeQt.h:
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::paint):
+ * rendering/RenderMediaControls.cpp:
+ (WebCore::determineState):
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintTextMatchMarker):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlInputElement::hitTest):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::theme):
+ * rendering/RenderObject.h:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::defaultTheme):
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeChromiumLinux.h:
+ (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
+ * rendering/RenderThemeChromiumMac.h:
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeChromiumWin.h:
+ (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
+ (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::adjustRepaintRect):
- (WebCore::RenderThemeMac::inflateRect):
- (WebCore::RenderThemeMac::baselinePosition):
- (WebCore::RenderThemeMac::setControlSize):
- (WebCore::RenderThemeMac::sizeForFont):
- (WebCore::RenderThemeMac::sizeForSystemFont):
- (WebCore::RenderThemeMac::setFontFromControlSize):
- (WebCore::RenderThemeMac::paintCheckbox):
- (WebCore::RenderThemeMac::setCheckboxCellState):
- (WebCore::RenderThemeMac::paintRadio):
- (WebCore::RenderThemeMac::setRadioCellState):
- (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
- (WebCore::RenderThemeMac::adjustButtonStyle):
- (WebCore::RenderThemeMac::setButtonCellState):
- (WebCore::RenderThemeMac::paintButton):
- (WebCore::RenderThemeMac::paintMenuList):
- (WebCore::RenderThemeMac::paintMenuListButton):
- (WebCore::RenderThemeMac::popupInternalPaddingLeft):
- (WebCore::RenderThemeMac::popupInternalPaddingRight):
- (WebCore::RenderThemeMac::popupInternalPaddingTop):
- (WebCore::RenderThemeMac::popupInternalPaddingBottom):
- (WebCore::RenderThemeMac::setPopupButtonCellState):
- (WebCore::RenderThemeMac::paintSliderTrack):
- (WebCore::RenderThemeMac::paintSliderThumb):
- (WebCore::RenderThemeMac::adjustSliderThumbSize):
- (WebCore::RenderThemeMac::paintSearchField):
- (WebCore::RenderThemeMac::adjustSearchFieldStyle):
- (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
- (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
-
-2008-08-27 Brady Eidson <beidson@apple.com>
-
- Reviewed by Anders
-
- <rdar://problem/6134133> - Crash when loading large movie as a standalone document
-
- We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
- to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
- away the virtual address space and a crash.
-
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
- * loader/FrameLoaderClient.h: Added client method to get platform specific error for
- "plugin will handle load"
-
- * loader/MediaDocument.cpp:
- (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
- and cancel the WebCore-managed load
- (WebCore::MediaTokenizer::writeRawData):
- (WebCore::MediaTokenizer::finish):
-
-2008-08-26 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Linear timing functions should have control points 0, 0, 1, 1.
- https://bugs.webkit.org/show_bug.cgi?id=20535
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
- * rendering/style/RenderStyle.h:
-
-2008-08-27 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * WebCore.vcproj/WebCore.vcproj: Fix file extension.
-
-2008-08-26 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
-
- Added platform-specific accessibilityIgnoreAttachment, which allows the platform
- to determine if an attachment is ignored through accessibility. Added equivalent
- methods in Gtk, Win and Mac
-
- Test: accessibility/plugin.html
-
- * GNUmakefile.am:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * page/AccessibilityObject.h:
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- * page/gtk/AccessibilityObjectAtk.cpp: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- * page/mac/AccessibilityObjectMac.mm: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- * page/mac/AccessibilityObjectWrapper.h:
- * page/win/AccessibilityObjectWin.cpp: Added.
- (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
-
-2008-08-26 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
-
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
- (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
-
-2008-08-26 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Darin Adler.
-
- <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
-
- Tests: accessibility/table-notbody.html
-
- * page/AccessibilityTable.cpp:
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
-
-2008-08-26 Sam Weinig <sam@webkit.org>
-
- Reviewed by Beth Dakin.
-
- Fix typo.
-
- * dom/DOMCoreException.h:
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeSafari.h:
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeWin.h:
-2008-08-26 Sam Weinig <sam@webkit.org>
+2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
- Fix https://bugs.webkit.org/show_bug.cgi?id=20479
- <rdar://problem/6167660>
- Take image redirects into account when tainting the canvas.
+ <rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
- Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
+ JSDOMWindowCustom was using PropertySlot::putValue, however this interface
+ appears to be fundaementally incorrect - PropertySlots are only used to get
+ values, all puts use PutPropertySlot. However PutPropertySlot cannot be
+ used in the fashion desired here - it only reports the caching type of a
+ write that has been performed.
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawImage):
- (WebCore::CanvasRenderingContext2D::drawImageFromRect):
+ (This caused a bug where the put should have triggered a transition, and
+ failed to do so.)
-2008-08-26 Sam Weinig <sam@webkit.org>
+ Removing the faulty case from the optimization leads to a ~0.5% progression
+ on in-browser SunSpider (presumably the very first case was not being hit
+ often, and the simplification here is beneficial).
- Reviewed by Darin Adler.
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::put):
- Change canvas tainting logic to ask the image if it contains
- any resources outside of its own origin. Since there is no
- way to determine if SVG images contain any resources outside its
- origin, we always assume it does.
+2009-06-17 David Levin <levin@chromium.org>
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawImage):
- (WebCore::CanvasRenderingContext2D::drawImageFromRect):
- * platform/graphics/BitmapImage.h:
- (WebCore::BitmapImage::hasSingleSecurityOrigin):
- * platform/graphics/GeneratedImage.h:
- (WebCore::GeneratedImage::hasSingleSecurityOrigin):
- * platform/graphics/Image.h:
- (WebCore::Image::hasSingleSecurityOrigin):
- * platform/graphics/cg/PDFDocumentImage.h:
- (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
- * svg/graphics/SVGImage.h:
-
-2008-08-26 Maxime Britto <britto@apple.com>
+ Reviewed by NOBODY, layout tests fix.
- Reviewed by Adele.
+ https://bugs.webkit.org/show_bug.cgi?id=26326
+ This reverts commit r44751.
- <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
- This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
- This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
+ Once that change was checked scrollbars/scrollbar-orientation.html started
+ crashing on Windows.
- * page/EventHandler.cpp:
- (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
- * page/EventHandler.h:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
- (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
- * rendering/RenderLayer.h:
+ * dom/Document.cpp:
+ (WebCore::Document::detach):
+ * page/FrameView.cpp:
+ * page/FrameView.h:
+ * platform/Scrollbar.h:
* rendering/RenderObject.cpp:
- (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
- (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
- (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
-
-2008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
-
- Reviewed by Darin Adler.
-
- Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
- https://bugs.webkit.org/show_bug.cgi?id=20247
-
- <rdar://problem/6118218>
-
- Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
- check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
- (case insensitive for HTML elements).
-
- Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
-
- * dom/Element.cpp:
- (WebCore::Element::getAttribute):
- * dom/NamedAttrMap.cpp:
- (WebCore::NamedAttrMap::getNamedItem):
- (WebCore::NamedAttrMap::getAttributeItem):
- * dom/NamedAttrMap.h:
-
-2008-08-25 Sam Weinig <sam@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
- <rdar://problem/6174096>
- Treat SVG images as dirty when drawing to a canvas.
-
- Test: http/tests/security/canvas-remote-read-svg-image.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::drawImage):
- (WebCore::CanvasRenderingContext2D::drawImageFromRect):
- * platform/graphics/Image.h:
- (WebCore::Image::isSVGImage):
- * svg/graphics/SVGImage.h:
- (WebCore::SVGImage::isSVGImage):
-
-2008-08-25 Sam Weinig <sam@webkit.org>
-
- Reviewed by Mark Rowe.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20377
- Leak in XMLHttpRequest.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
-
-2008-08-25 Brady Eidson <beidson@apple.com>
-
- Reviewed by Anders
-
- Speculative fix for <rdar://problem/6173217>
-
- Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
- Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
- the first null check invalid.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopAllLoaders):
-
-
-2008-08-25 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
- there is no profile, can cause crash
-
- * page/inspector/ProfilesPanel.js:
-
-2008-08-25 Dean Jackson <dino@apple.com>
-
- Reviewed by Dave Hyatt
-
- Make sure 'inherit' is handled by transition property.
- https://bugs.webkit.org/show_bug.cgi?id=20513
-
- Test: transitions/inherit.html
- Test: transitions/inherit-other-props.html
-
- * css/CSSStyleSelector.cpp:
- fix macro to check existence of list before getting size
-
-2008-08-25 Anders Carlsson <andersca@apple.com>
-
- Reviewed by Mark.
-
- <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
-
- Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
- (safely) that any class that needs finalization on the main thread will also need to be deallocated
- on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
- calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
-
- * platform/mac/WebCoreObjCExtras.c:
- (WebCoreObjCFinalizeOnMainThread):
-
-2008-08-25 Antti Koivisto <antti@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Rename CachedResource::referenced() to CachedResource::hasClients() to
- match previous ref() -> addClient() rename.
-
- * loader/Cache.cpp:
- (WebCore::Cache::pruneLiveResources):
- (WebCore::Cache::pruneDeadResources):
- (WebCore::Cache::remove):
- (WebCore::Cache::getStatistics):
- (WebCore::Cache::dumpLRULists):
- * loader/CachedResource.cpp:
- (WebCore::CachedResource::addClient):
- (WebCore::CachedResource::removeClient):
- (WebCore::CachedResource::setDecodedSize):
- (WebCore::CachedResource::setEncodedSize):
- * loader/CachedResource.h:
- (WebCore::CachedResource::hasClients):
- (WebCore::CachedResource::canDelete):
-
-2008-08-25 Anthony Ricaud <rik24d@gmail.com>
-
- Add a missing Inspector localized string for "other".
-
- https://bugs.webkit.org/show_bug.cgi?id=20509
-
- Reviewed by Tim Hatcher.
-
- * English.lproj/localizedStrings.js:
-
-2008-08-22 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff, Mark and Tim.
-
- <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
- in the console said what file and line number they came from
- - Lay the foundation for getting line numbers and other data from the
- JavaScript engine.
-
- * ForwardingHeaders/VM: Added.
- * ForwardingHeaders/VM/Machine.h: Added.
- * page/Console.cpp: Gather the line number and file information when
- profileEnd has been called, but don't use it until didFinishProfiling is
- called. We won't need to wait once we remove the profiler "zombie" mode
- which this patch helps pave the foundation for.
- (WebCore::Console::Console):
- (WebCore::Console::profileEnd):
- (WebCore::Console::finishedProfiling):
- * page/Console.h:
- * page/InspectorController.cpp: Modify calls to
- addProfileMessageToConsole to satisfy the new arguments it takes.
- (WebCore::InspectorController::finishedProfiling):
- (WebCore::InspectorController::addProfile):
- (WebCore::InspectorController::addProfileMessageToConsole):
- (WebCore::InspectorController::finishedProfiling):
- * page/InspectorController.h:
-
-2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Reviewed by Simon.
-
- [inspector] Update the WebKit.qrc Qt resources file
- Catchup with the changes in the directory.
-
- * page/inspector/WebKit.qrc:
-
-2008-08-25 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Simon.
-
- Transformed the radian to degree, to get rotate()
- in canvas work as expected.
-
- [Qt] Canvas.rotate() doesn't work
- https://bugs.webkit.org/show_bug.cgi?id=20496
-
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::rotate):
-
-2008-08-24 Steve Falkenburg <sfalken@apple.com>
-
- Add a "last chance" WM_TIMER to the Windows shared timer.
-
- The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
- Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
- timers if a timer with an earlier expiration is already pending. This results in no timers
- firing from that point on.
-
- We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
- buggy window message hook.
-
- This timer will start when the first WM_TIMER is scheduled, and will
- fire every 5 seconds thereafter, causing any lost timers to be fired.
-
- Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
- and prevents the WebFrame leak.
-
- Reviewed by Darin Adler, Geoff Garen.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::):
- (WebCore::TimerWindowWndProc):
- (WebCore::setSharedTimerFireTime):
-
-2008-08-24 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
-
- Test: fast/css/font-property-priority.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
- to the font-property-parsing functions.
- (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
- changed to use it rather than the m_important member.
- (WebCore::CSSParser::parseFontVariant): Ditto.
- (WebCore::CSSParser::parseFontWeight): Ditto.
- * css/CSSParser.h:
-
-2008-08-24 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where the Inspector's UI would not animate or
- fully function because JavaScript timeouts, intervals and
- CSS animation timers where not firing while paused at a
- a breakpoint in the inspected page.
-
- https://bugs.webkit.org/show_bug.cgi?id=20042
-
- Reviewed by Darin Adler.
-
- Test: manual-tests/inspector/forzen-ui-while-paused.html
-
- * page/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::pauseIfNeeded):
- Add a call to TimerBase::fireTimersInNestedEventLoop before
- spinning the EventLoop.
-
-2008-08-24 Rob Buis <buis@kde.org>
-
- Reviewed by Sam Weinig.
-
- https://bugs.webkit.org/show_bug.cgi?id=20324
- A change in SVG Glyph wont show up
-
- Invalidate the glyph cache when the d attribute is set.
-
- Test: svg/custom/glyph-setting-d-attribute.svg
-
- * svg/SVGGlyphElement.cpp:
- (WebCore::SVGGlyphElement::invalidateGlyphCache):
- (WebCore::SVGGlyphElement::parseMappedAttribute):
- (WebCore::SVGGlyphElement::insertedIntoDocument):
- (WebCore::SVGGlyphElement::removedFromDocument):
- * svg/SVGGlyphElement.h:
-
-2008-08-24 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Sam Weinig.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=13864
- <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
-
- * rendering/RenderText.cpp:
- (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
- beginWS and endWS before the early return to ensure that they are
- initialized in that case.
-
-2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Rubber-stamped by Mark Rowe.
-
- Remove modelines.
-
- * WebCore.pro:
- * bridge/testbindings.cpp:
- * dom/DocPtr.h:
- * loader/SubstituteData.h:
- * page/Chrome.cpp:
- * page/Chrome.h:
- * page/ChromeClient.h:
- * page/Frame.h:
- * page/FrameLoadRequest.h:
- * page/FrameTree.cpp:
- * page/FrameTree.h:
- * page/Page.h:
- * page/mac/ChromeMac.mm:
- * platform/network/HTTPHeaderMap.h:
- * platform/network/ResourceErrorBase.cpp:
- * platform/network/ResourceErrorBase.h:
- * platform/network/ResourceHandleInternal.h:
- * platform/network/ResourceRequestBase.cpp:
- * platform/network/ResourceRequestBase.h:
- * platform/network/ResourceResponseBase.cpp:
- * platform/network/ResourceResponseBase.h:
- * platform/network/cf/ResourceError.h:
- * platform/network/cf/ResourceRequest.h:
- * platform/network/cf/ResourceRequestCFNet.h:
- * platform/network/cf/ResourceResponse.h:
- * platform/network/cf/ResourceResponseCFNet.h:
- * platform/network/curl/ResourceError.h:
- * platform/network/curl/ResourceRequest.h:
- * platform/network/curl/ResourceResponse.h:
- * platform/network/mac/ResourceError.h:
- * platform/network/mac/ResourceErrorMac.mm:
- * platform/network/mac/ResourceRequest.h:
- * platform/network/mac/ResourceRequestMac.mm:
- * platform/network/mac/ResourceResponse.h:
- * platform/network/mac/ResourceResponseMac.mm:
- * platform/network/qt/ResourceError.h:
- * platform/network/qt/ResourceRequest.h:
- * platform/network/qt/ResourceResponse.h:
- * platform/network/soup/CookieJarSoup.cpp:
- * platform/network/soup/ResourceError.h:
- * platform/network/soup/ResourceRequest.h:
- * platform/network/soup/ResourceResponse.h:
-
-2008-08-23 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
-
- Test: fast/table/vertical-align-baseline.html
-
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
- baseline of the first table row, if there is one, -1 otherwise.
- * rendering/RenderTable.h:
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::baselinePosition): Changed to follow the
- CSS2.1 definition of the baseline of a table cell.
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
- the baseline of the first row in the section.
- * rendering/RenderTableSection.h:
-
-2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
-
- Add SPI to make a Windows WebView transparent.
-
- Reviewed by Dan Bernstein.
-
- * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
- determines whether the created context has an alpha channel.
- * platform/graphics/win/GraphicsContextCGWin.cpp:
- (WebCore::CGContextWithHDC):
-
-2008-08-22 Timothy Hatcher <timothy@apple.com>
-
- Rolls out r35834 because it caused a regression in the Inspector's
- Console where some expressions always threw a syntax error.
-
- https://bugs.webkit.org/show_bug.cgi?id=20487
-
- * page/inspector/Console.js:
- (Console.prototype._evalInInspectedWindow): Removes parenthesis
- around the expression.
-
-2008-08-22 Timothy Hatcher <timothy@apple.com>
-
- Makes getStyleProperty return a value for the overflow property
- when overflow-x and overflow-y are equal.
-
- https://bugs.webkit.org/show_bug.cgi?id=20485
-
- Reviewed by Dan Bernstein.
-
- Test: fast/css/overflow-property.html
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
-
-2008-08-22 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug where while editing in the Inspector the
- sidebar scroll position would jump to the top.
-
- https://bugs.webkit.org/show_bug.cgi?id=20484
-
- Reviewed by Darin Adler.
-
- * page/inspector/treeoutline.js:
- (TreeOutline._removeChildren): Remove the offsetTop call that
- was forcing a layout, since layout causes scroll positions
- to be clamped to the new scrollHeight/Width. Layout will happen
- normally when needed.
-
-2008-08-22 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix. Add AccessibilityTable sources.
-
- * WebCoreSources.bkl:
-
-2008-08-21 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Jon Honeycutt and Alexey Proskuryakov.
-
- - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
-
- Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
-
- * platform/graphics/mac/SimpleFontDataMac.mm:
- (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
- ascent and 100% to its reported descent.
-
-2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=20267
- [GTK] Crash on some pages due to a plugin
-
- Fix handling of badly formatted and empty plugin mime descriptions
-
- * plugins/gtk/PluginPackageGtk.cpp:
- (WebCore::PluginPackage::fetchInfo):
+ (WebCore::RenderObject::destroy):
+ * rendering/RenderScrollbar.h:
-2008-08-21 Kevin Watters <kevinwatters@gmail.com>
+2009-06-16 Kevin Watters <kevinwatters@gmail.com>
- Reviewed by Darin Adler.
+ Reviewed by Kevin Ollivier.
- Follow other ports (and IE) in ImageSourceWx.cpp never to return an
- animated GIF frame duration of less than 50ms.
+ In ImageSource::setData, delete the old m_encoder before replacing it with a new one.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26458
* platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::frameDurationAtIndex):
-
-2008-08-21 Maxime Britto <britto@apple.com>
-
- Reviewed by Kevin McCullough.
-
- Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
- https://bugs.webkit.org/show_bug.cgi?id=20451
-
- rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
- When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
- This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
-
- (WebCore::EventHandler::handleMousePressEvent): ditto
-
-2008-08-21 Anthony Ricaud <rik24d@gmail.com>
-
- Small optimization for when the dividers in the Inspector's
- Resources panel are updated.
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/ResourcesPanel.js:
- (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
- Combind a for loop and clone the divider element.
-
-2008-08-21 Chris Marrin <cmarrin@apple.com>
-
- Allow 0 (without units) for Time eg. duration
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
-
- Reviewed by Dave Hyatt.
-
- Test: css1/units/zero-duration-without-units.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::validUnit):
-
-2008-08-21 Timothy Hatcher <timothy@apple.com>
-
- Make deleting all text while editing a DOM attribute in
- the Inspector delete the attribute. This also fixes
- an exception that would happen before.
-
- https://bugs.webkit.org/show_bug.cgi?id=20472
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
- Don't check for hasAttributes on the parseElement, continuing
- through the function will correctly remove the attribute.
- If the parseElement is null, call _editingCancelled not
- editingCancelled, this fixes an exception.
-
-2008-08-21 Timothy Hatcher <timothy@apple.com>
-
- Update the Inspector's Metrics pane when editing in
- the Styles pane. This makes sure the metrics shown
- always match what the Styles pane shows.
-
- https://bugs.webkit.org/show_bug.cgi?id=20470
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel): Add event listeners for
- the "style edited" and "style property toggled" events,
- so the Metrics pane is updated.
- (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
- Update the Metrics pane.
- * page/inspector/StylesSidebarPane.js:
- (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
- Dispatch the "style property toggled" event.
- (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
- Dispatch the "style edited" event when the CSS text is restored.
- (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
- Dispatch the "style edited" event.
-
-2008-08-21 Timothy Hatcher <timothy@apple.com>
-
- Make the Inspector's Metrics sidebar pane editable.
-
- https://bugs.webkit.org/show_bug.cgi?id=17218
- rdar://problem/5732818
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ElementsPanel.js:
- (WebInspector.ElementsPanel): Add an event listener for
- the "metrics edited" event, so the Styles pane is updated.
- * page/inspector/MetricsSidebarPane.js:
- (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
- so future updates work. Add a double click event listener for the
- metric values to start editing.
- (WebInspector.MetricsSidebarPane.prototype.startEditing):
- Call WebInspector.startEditing with some context.
- (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
- (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- Set the user input on the elements inline style. Fire the
- "metrics edited" event.
-
-2008-08-21 Steve Falkenburg <sfalken@apple.com>
-
- Fix a race condition in Windows timer code.
- Timer function could end up being called with a 0 timer, leading to a Windows exception.
-
- Don't post a timer message if one is already pending.
-
- Reviewed by Ada Chan.
-
- * platform/win/SharedTimerWin.cpp:
- (WebCore::TimerWindowWndProc):
- (WebCore::clearTimer):
- (WebCore::queueTimerProc):
- (WebCore::setSharedTimerFireTime):
-
-2008-08-21 Anthony Ricaud <rik24d@gmail.com>
-
- After trying to add the expression, try again with quotes for
- easier edition.
-
- https://bugs.webkit.org/show_bug.cgi?id=20466
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/ObjectPropertiesSection.js: Added an
- evaluateExpression function.
-
-2008-08-21 Anthony Ricaud <rik24d@gmail.com>
-
- Perform Inspector searches on search event to clear results when
- clicking the cross to empty it. Delete the lastQuery when the field
- is emptied in order to perform the search if exactly the same query
- is entered next.
-
- https://bugs.webkit.org/show_bug.cgi?id=20462
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/inspector.js:
-
-2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Mark Rowe.
-
- http://bugs.webkit.org/show_bug.cgi?id=19656
- [SOUP] The gio code should call didFail() instead of
- didFinishLoading() in case of error
-
- In case of error call didFail() instead of didReceiveResponse() and
- didFinishLoading().
-
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::networkErrorForFile):
- (WebCore::readCallback):
- (WebCore::openCallback):
- (WebCore::queryInfoCallback):
-
-2008-08-20 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Jon Honeycutt.
-
- Fix build failure.
-
- * bridge/c/c_instance.cpp:
- (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
- as that is what NPEnumerationFunctionPtr is declared as accepting.
-
-2008-08-20 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Dan Bernstein.
+ (WebCore::ImageSource::setData):
- Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
+2009-06-16 David Levin <levin@chromium.org>
- * platform/graphics/GraphicsContext.h:
- (WebCore::):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::setImageInterpolationQuality):
- (WebCore::GraphicsContext::imageInterpolationQuality):
-
-2008-08-20 Dan Bernstein <mitz@apple.com>
+ Reviewed by David Hyatt.
- Rubber-stamped by John Sullivan.
+ REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
+ https://bugs.webkit.org/show_bug.cgi?id=26326
- - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
- rename related methods and variables accordingly.
+ Test: scrollbars/scrollbar-crash-on-refresh.html
- * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::detach):
+ Gives the FrameView a change to do any necessary cleanup on
+ Document::detach() which is where the renderArena gets detroyed.
* page/FrameView.cpp:
- (WebCore::FrameViewPrivate::FrameViewPrivate):
- (WebCore::FrameView::shouldUpdateWhileOffscreen):
- (WebCore::FrameView::setShouldUpdateWhileOffscreen):
+ (WebCore::FrameView::detachCustomScrollbars):
+ Gets rid of any custom scrollbars (if the docment supplied them).
* page/FrameView.h:
- * platform/ScrollView.h:
- * platform/mac/ScrollViewMac.mm:
- (WebCore::ScrollView::updateContents):
-
-2008-08-20 Brady Eidson <beidson@apple.com>
-
- Reviewed by Mitzpettel
-
- <rdar://problem/6153432> - Many images broken in Mail
-
- This can be traced back to the preload scanner. With that change, CachedResources are created a lot
- sooner than before and confuse the WebArchive machinery.
-
- When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
- such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
- machinery and nothing is known about where the data will eventually come from.
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
- CachedResource::PreloadReferenced.
-
-2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
-
- Unreviewed compile fix
-
- Catch up with the JSValue::type elimination.
-
- * bridge/qt/qt_instance.cpp:
- (KJS::Bindings::QtRuntimeObjectImp::construct):
- (KJS::Bindings::QtInstance::defaultValue):
- * bridge/qt/qt_runtime.cpp:
- (KJS::Bindings::QtRuntimeConnectionMethod::call):
-
-2008-08-20 Chris Teague <chris.teague@gmail.com>
-
- Reviewed by Mark Rowe.
-
- Fix https://bugs.webkit.org/show_bug.cgi?id=20449
- Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
-
- * ChangeLog:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
-
-2008-08-20 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- getComputedStyle() for webkitTransform should return a transform
- that does not have the transform origin baked into it.
- https://bugs.webkit.org/show_bug.cgi?id=20464
-
- Test: fast/css/getComputedStyle-transform.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::computedTransform):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::applyTransform):
- * rendering/style/RenderStyle.h:
-
-2008-08-20 Josh Aas <joshmoz@gmail.com>
-
- Reviewed and landed by Anders.
-
- <rdar://problem/6163636>
- rename NPCocoaEvent's "event" struct to "data" (20446)
-
- * bridge/npapi.h:
- (_NPCocoaEvent::):
-
-2008-08-20 Beth Dakin <bdakin@apple.com>
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::isCustomScrollbar):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::destroy):
+ Removed the check for document()->frame(). If frame() is 0 in this code,
+ then the call to animation() is also incorrect (since it does document()->frame()->animation()).
+ * rendering/RenderScrollbar.h:
+ (WebCore::RenderScrollbar::isCustomScrollbar):
- Reviewed by Darin Adler.
+2009-06-16 Brian Weinstein <bweinstein@apple.com>
- Fix for <rdar://problem/6145626>
- This patch fixes a number of remaining problems getting
- disconnected frames to work correctly with markAllMatchesForText()
- and findString(). Details inline.
+ Reviewed by Adele Peterson.
- This was a static helper function in Frame, but this patch requires
- the same functionality in Editor, so I just added it as a function
- on Node.
- * dom/Node.cpp:
- (WebCore::Node::isInShadowTree):
- * dom/Node.h:
+ Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
+ This patch kept the way events were firing as they were before, and Windows events are
+ consistent with Mac.
* editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea): Returns false if
- excludeFromTextSearch() is true.
-
- In a normal (non-disconnected) frame, findString returns a range of
- the document node if the text is not found in the frame. I changed
- firstVisibleRange and lastVisibleRange to match that behavior when
- the text is not found
- (WebCore::Editor::firstVisibleRange):
- (WebCore::Editor::lastVisibleRange):
-
- Here are the bulk of the changes in the patch. A lot of text was
- not being found in disconnected frames because I failed to account
- for all of the possible problems associated with shadow trees. That
- is fixed here.
- (WebCore::Editor::nextVisibleRange):
- * editing/Editor.h:
-
- excludeFromTextSearch() is new. It allows a WebKit client to mark a
- frame as not-text-searchable through SPI.
- * WebCore.base.exp:
- * page/Frame.cpp:
- (WebCore::Frame::excludeFromTextSearch):
- (WebCore::Frame::setExcludeFromTextSearch):
- (WebCore::FramePrivate::FramePrivate):
- * page/Frame.h:
- * page/FramePrivate.h:
-
- (WebCore::Frame::findString):
- (WebCore::Frame::markAllMatchesForText): I kept running into an
- assertion failure in paining code because of the forced paint on
- empty visible rects.
-
-2008-08-20 Timothy Hatcher <timothy@apple.com>
-
- Adds a positon box to the Inspector's Metrics sidebar
- pane. When an element is not statically positioned, there
- is now a position box that show top, right, bottom and
- left computed values.
-
- Reviewed by Kevin McCullough.
-
- * English.lproj/localizedStrings.js: Updated the strings.
- * page/inspector/MetricsSidebarPane.js:
- (WebInspector.MetricsSidebarPane.prototype.update):
- Renamed the boxPartValue function to createBoxPartElement
- and made it create the entire element. Made it understand
- how to get position style properties. Don't use the figure dash
- when 0px is used for positions, since the 0 is meaningful there.
- Instead use the figure dash when a position is auto.
- * page/inspector/inspector.css: Added a new rule for position.
-
-2008-08-20 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin
-
- Qt build fix
-
- * WebCore.pro:
-
-2008-08-20 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Anders Carlsson.
-
- - avoid using a deprecated NSScroller method on Leopard
-
- * platform/mac/PlatformScrollBarMac.mm:
- (WebCore::PlatformScrollbar::updateThumbPosition):
- (WebCore::PlatformScrollbar::updateThumbProportion):
-
-2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Oliver Hunt.
-
- Gtk build fix
-
- * GNUmakefile.am:
- * page/AccessibilityTable.cpp: Change nil to 0
- (WebCore::AccessibilityTable::cellForColumnAndRow):
-
-2008-08-19 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
-
- * ForwardingHeaders/kjs/JSLock.h: Added.
- * WebCore.vcproj/WebCore.vcproj:
- * bindings/js/GCController.cpp:
- (WebCore::collect):
- (WebCore::GCController::gcTimerFired):
- (WebCore::GCController::garbageCollectNow):
- * bindings/js/JSCustomSQLStatementCallback.cpp:
- (WebCore::JSCustomSQLStatementCallback::handleEvent):
- * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionCallback.cpp:
- (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- * bindings/js/JSCustomVoidCallback.cpp:
- (WebCore::JSCustomVoidCallback::handleEvent):
- * bindings/js/JSCustomXPathNSResolver.cpp:
- (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::DOMWindowTimer::~DOMWindowTimer):
- (WebCore::JSDOMWindowBase::clear):
- (WebCore::JSDOMWindowBase::timerFired):
- * bindings/js/JSEventCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSAbstractEventListener::handleEvent):
- * bindings/js/JSNSResolver.cpp:
- (WebCore::JSNSResolver::lookupNamespaceURI):
- * bindings/js/JSNodeFilterCondition.cpp:
- (WebCore::JSNodeFilterCondition::acceptNode):
- * bindings/js/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate):
- (WebCore::ScriptController::clearWindowShell):
- (WebCore::ScriptController::createHTMLEventHandler):
- (WebCore::ScriptController::createSVGEventHandler):
- (WebCore::ScriptController::initScript):
- (WebCore::ScriptController::updateDocument):
- (WebCore::ScriptController::bindingRootObject):
- (WebCore::ScriptController::windowScriptNPObject):
- (WebCore::ScriptController::createScriptObjectForPluginElement):
- (WebCore::ScriptController::clearScriptObjects):
- * bindings/js/ScriptControllerMac.mm:
- (WebCore::ScriptController::windowScriptObject):
- * bindings/objc/WebScriptObject.mm:
- (_didExecute):
- (-[WebScriptObject callWebScriptMethod:withArguments:]):
- (-[WebScriptObject evaluateWebScript:]):
- (-[WebScriptObject setValue:forKey:]):
- (-[WebScriptObject valueForKey:]):
- (-[WebScriptObject removeWebScriptKey:]):
- (-[WebScriptObject stringRepresentation]):
- (-[WebScriptObject webScriptValueAtIndex:]):
- (-[WebScriptObject setWebScriptValueAtIndex:value:]):
- (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- * bridge/NP_jsobject.cpp:
- (_NPN_InvokeDefault):
- (_NPN_Invoke):
- (_NPN_Evaluate):
- (_NPN_GetProperty):
- (_NPN_SetProperty):
- (_NPN_RemoveProperty):
- (_NPN_HasProperty):
- (_NPN_HasMethod):
- (_NPN_Enumerate):
- * bridge/c/c_class.cpp:
- (KJS::Bindings::CClass::~CClass):
- (KJS::Bindings::CClass::methodsNamed):
- (KJS::Bindings::CClass::fieldNamed):
- * bridge/c/c_instance.cpp:
- (KJS::Bindings::CInstance::invokeMethod):
- (KJS::Bindings::CInstance::invokeDefaultMethod):
- (KJS::Bindings::CInstance::getPropertyNames):
- * bridge/c/c_runtime.cpp:
- (KJS::Bindings::CField::valueFromInstance):
- (KJS::Bindings::CField::setValueToInstance):
- * bridge/c/c_utility.cpp:
- (KJS::Bindings::convertValueToNPVariant):
- (KJS::Bindings::convertNPVariantToValue):
- * bridge/jni/jni_class.cpp:
- (JavaClass::JavaClass):
- (JavaClass::~JavaClass):
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::stringValue):
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::call):
- (JavaJSObject::eval):
- (JavaJSObject::getMember):
- (JavaJSObject::setMember):
- (JavaJSObject::removeMember):
- (JavaJSObject::getSlot):
- (JavaJSObject::setSlot):
- (JavaJSObject::toString):
- (JavaJSObject::convertValueToJObject):
- (JavaJSObject::convertJObjectToValue):
- * bridge/jni/jni_objc.mm:
- (KJS::Bindings::dispatchJNICall):
- * bridge/jni/jni_runtime.cpp:
- (appendClassName):
- (JavaMethod::signature):
- * bridge/jni/jni_runtime.h:
- (KJS::Bindings::JavaString::JavaString):
- (KJS::Bindings::JavaString::_commonInit):
- (KJS::Bindings::JavaString::~JavaString):
- (KJS::Bindings::JavaString::UTF8String):
- * bridge/jni/jni_utility.cpp:
- (KJS::Bindings::convertValueToJValue):
- * bridge/npruntime.cpp:
- (_NPN_GetStringIdentifier):
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::moveGlobalExceptionToExecState):
- (ObjcInstance::invokeMethod):
- (ObjcInstance::invokeDefaultMethod):
- (ObjcInstance::setValueOfUndefinedField):
- (ObjcInstance::getValueOfUndefinedField):
- * bridge/objc/objc_runtime.mm:
- (ObjcField::valueFromInstance):
- (ObjcField::setValueToInstance):
- * bridge/objc/objc_utility.mm:
- (KJS::Bindings::convertValueToObjcValue):
- (KJS::Bindings::convertNSStringToString):
- (KJS::Bindings::convertObjcValueToValue):
- * bridge/qt/qt_instance.cpp:
- (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
- (KJS::Bindings::QtInstance::~QtInstance):
- (KJS::Bindings::QtInstance::getQtInstance):
- (KJS::Bindings::QtInstance::getRuntimeObject):
- * bridge/qt/qt_runtime.cpp:
- (KJS::Bindings::convertValueToQVariant):
- (KJS::Bindings::convertQVariantToValue):
- (KJS::Bindings::QtRuntimeMetaMethod::call):
- (KJS::Bindings::QtRuntimeConnectionMethod::call):
- (KJS::Bindings::QtConnectionObject::QtConnectionObject):
- (KJS::Bindings::QtConnectionObject::execute):
- * bridge/runtime.cpp:
- (KJS::Bindings::Instance::createRuntimeObject):
- * bridge/testbindings.cpp:
- (main):
- * bridge/testbindings.mm:
- (main):
- * bridge/testqtbindings.cpp:
- (main):
- * dom/Document.cpp:
- (WebCore::Document::~Document):
- * dom/Node.cpp:
- (WebCore::Node::setDocument):
- * history/CachedPage.cpp:
- (WebCore::CachedPage::CachedPage):
- (WebCore::CachedPage::restore):
- (WebCore::CachedPage::clear):
- * loader/FrameLoader.cpp:
- (WebCore::getString):
- * page/InspectorController.cpp:
- (WebCore::ConsoleMessage::ConsoleMessage):
- (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
- (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
- (WebCore::getResourceDocumentNode):
- (WebCore::search):
- (WebCore::inspectedWindow):
- (WebCore::wrapCallback):
- (WebCore::currentCallFrame):
- (WebCore::profiles):
- (WebCore::InspectorController::focusNode):
- (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
- (WebCore::InspectorController::addDatabaseScriptResource):
- (WebCore::InspectorController::addScriptProfile):
- * page/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::evaluate):
- * page/JavaScriptProfileNode.cpp:
- (WebCore::getTotalTime):
- (WebCore::getSelfTime):
- (WebCore::getTotalPercent):
- (WebCore::getSelfPercent):
- (WebCore::getNumberOfCalls):
- (WebCore::getChildren):
- (WebCore::getVisible):
- * page/Page.cpp:
- * page/mac/FrameMac.mm:
- * plugins/PluginView.cpp:
- (WebCore::PluginView::start):
- (WebCore::getString):
- (WebCore::PluginView::performRequest):
- (WebCore::PluginView::bindingInstance):
- * plugins/gtk/PluginViewGtk.cpp:
- (WebCore::PluginView::paint):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::init):
- * plugins/qt/PluginViewQt.cpp:
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- (WebCore::PluginView::init):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::dispatchNPEvent):
- (WebCore::PluginView::handleKeyboardEvent):
- (WebCore::PluginView::handleMouseEvent):
- (WebCore::PluginView::setNPWindowRect):
- (WebCore::PluginView::stop):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::clearResponse):
- (WebCore::XMLHttpRequest::didFinishLoading):
- (WebCore::XMLHttpRequest::didReceiveData):
-
-2008-08-19 Eric Seidel <eric@webkit.org>
-
- Reviewed by Geoff Garen.
-
- Add the beginnings of Skia graphics support to WebCore
- as I try to begin the long process of un-forking the changes
- needed to WebCore to make Andriod's WebCore build.
-
- I'll follow this up with actual *Skia.cpp files in a separate patch.
-
- * platform/graphics/AffineTransform.h:
- * platform/graphics/FloatPoint.h:
- * platform/graphics/FloatRect.h:
- * platform/graphics/Gradient.h:
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/Image.h:
- * platform/graphics/ImageBuffer.h:
- * platform/graphics/ImageSource.h:
- * platform/graphics/IntPoint.h:
- * platform/graphics/IntRect.h:
- * platform/graphics/Path.h:
- * platform/graphics/Pattern.h:
- * svg/graphics/SVGPaintServerPattern.h:
- * svg/graphics/SVGPaintServerSolid.h:
-
-2008-08-19 Steve Falkenburg <sfalken@apple.com>
-
- Fix Windows build more.
-
- * WebCore.vcproj/WebCore.vcproj:
-
-2008-08-19 Steve Falkenburg <sfalken@apple.com>
-
- Fix Windows build.
-
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
-
-2008-08-19 Chris Fleizach <cfleizach@apple.com>
-
- Reviewed by Beth Dakin.
-
- <rdar://problem/4003764> Expose tables as AXTables
-
- Tests: accessibility/table-attributes.html
- accessibility/table-cell-spans.html
- accessibility/table-cells.html
- accessibility/table-detection.html
- accessibility/table-sections.html
- accessibility/table-with-rules.html
-
- * WebCore.xcodeproj/project.pbxproj:
- * page/AXObjectCache.cpp:
- (WebCore::AXObjectCache::get):
- * page/AccessibilityObject.h:
- (WebCore::):
- (WebCore::AccessibilityObject::isDataTable):
- (WebCore::AccessibilityObject::isTableRow):
- (WebCore::AccessibilityObject::isTableColumn):
- (WebCore::AccessibilityObject::isTableCell):
- * page/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- * page/AccessibilityTable.cpp: Added.
- (WebCore::AccessibilityTable::AccessibilityTable):
- (WebCore::AccessibilityTable::~AccessibilityTable):
- (WebCore::AccessibilityTable::create):
- (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- (WebCore::AccessibilityTable::clearChildren):
- (WebCore::AccessibilityTable::addChildren):
- (WebCore::AccessibilityTable::headerContainer):
- (WebCore::AccessibilityTable::columns):
- (WebCore::AccessibilityTable::rows):
- (WebCore::AccessibilityTable::rowHeaders):
- (WebCore::AccessibilityTable::columnHeaders):
- (WebCore::AccessibilityTable::cells):
- (WebCore::AccessibilityTable::columnCount):
- (WebCore::AccessibilityTable::rowCount):
- (WebCore::AccessibilityTable::cellForColumnAndRow):
- (WebCore::AccessibilityTable::roleValue):
- (WebCore::AccessibilityTable::accessibilityIsIgnored):
- (WebCore::AccessibilityTable::title):
- (WebCore::AccessibilityTable::isDataTable):
- * page/AccessibilityTable.h: Added.
- * page/AccessibilityTableCell.cpp: Added.
- (WebCore::AccessibilityTableCell::AccessibilityTableCell):
- (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
- (WebCore::AccessibilityTableCell::create):
- (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
- (WebCore::AccessibilityTableCell::rowIndexRange):
- (WebCore::AccessibilityTableCell::columnIndexRange):
- * page/AccessibilityTableCell.h: Added.
- (WebCore::AccessibilityTableCell::isTableCell):
- (WebCore::AccessibilityTableCell::roleValue):
- * page/AccessibilityTableColumn.cpp: Added.
- (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
- (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
- (WebCore::AccessibilityTableColumn::create):
- (WebCore::AccessibilityTableColumn::setParentTable):
- (WebCore::AccessibilityTableColumn::elementRect):
- (WebCore::AccessibilityTableColumn::size):
- (WebCore::AccessibilityTableColumn::children):
- (WebCore::AccessibilityTableColumn::headerObject):
- (WebCore::AccessibilityTableColumn::headerObjectForSection):
- (WebCore::AccessibilityTableColumn::addChildren):
- * page/AccessibilityTableColumn.h: Added.
- (WebCore::AccessibilityTableColumn::parentObject):
- (WebCore::AccessibilityTableColumn::roleValue):
- (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
- (WebCore::AccessibilityTableColumn::isTableColumn):
- (WebCore::AccessibilityTableColumn::setColumnIndex):
- (WebCore::AccessibilityTableColumn::columnIndex):
- * page/AccessibilityTableHeaderContainer.cpp: Added.
- (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
- (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
- (WebCore::AccessibilityTableHeaderContainer::create):
- (WebCore::AccessibilityTableHeaderContainer::children):
- (WebCore::AccessibilityTableHeaderContainer::elementRect):
- (WebCore::AccessibilityTableHeaderContainer::size):
- (WebCore::AccessibilityTableHeaderContainer::addChildren):
- * page/AccessibilityTableHeaderContainer.h: Added.
- (WebCore::AccessibilityTableHeaderContainer::roleValue):
- (WebCore::AccessibilityTableHeaderContainer::setParentTable):
- (WebCore::AccessibilityTableHeaderContainer::parentObject):
- (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
- * page/AccessibilityTableRow.cpp: Added.
- (WebCore::AccessibilityTableRow::AccessibilityTableRow):
- (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
- (WebCore::AccessibilityTableRow::create):
- (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
- (WebCore::AccessibilityTableRow::headerObject):
- * page/AccessibilityTableRow.h: Added.
- (WebCore::AccessibilityTableRow::isTableRow):
- (WebCore::AccessibilityTableRow::roleValue):
- (WebCore::AccessibilityTableRow::setRowIndex):
- (WebCore::AccessibilityTableRow::rowIndex):
- * page/mac/AccessibilityObjectWrapper.mm:
- (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
- (RoleEntry::):
- (-[AccessibilityObjectWrapper roleDescription]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
- (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
-
-2008-08-19 Steve Falkenburg <sfalken@apple.com>
-
- Build fix.
- Add buildfailed support to stop builds early (preventing inaccurate error messages).
- Add missing post-build rule to Release.
-
- * WebCore.vcproj/QTMovieWin.vcproj:
-
-2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
-
- Added support for console.count in the inspector.
-
- Reviewed by Geoff Garen.
-
- * page/Console.cpp:
- (WebCore::Console::count):
- * page/Console.h:
- * page/Console.idl: Added console.count.
- * page/InspectorController.cpp:
- (WebCore::InspectorController::didCommitLoad): Clears m_counts.
- (WebCore::InspectorController::count): Updates the count number
- sing "title@source:line" as the identifier, and adds a
- message to the console.
- * page/InspectorController.h: Added m_counts.
-
-2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
-
- Clear console.time timers when changing page.
-
- Reviewed by Geoff Garen.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::didCommitLoad):
-
-2008-08-19 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele.
-
- Fix for <rdar://problem/6154695> Full-page movies flicker while playing
- https://bugs.webkit.org/show_bug.cgi?id=20404
-
- Ignore setVisible() when visibility doesn't change.
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- (WebCore::MediaPlayerPrivate::setVisible):
-
-2008-08-19 Timothy Hatcher <timothy@apple.com>
-
- Fixes a bug in the Profile view where switching sort order, then
- switching from heavy to tree mode would show the tree in the
- previous sort order.
-
- https://bugs.webkit.org/show_bug.cgi?id=20441
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ProfileView.js:
- (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
- on the next profile before assigning it to this.profile.
- (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
- (WebInspector.ProfileView.prototype._sortProfile): Moves from
- _sortData and takes a profile argument. If the profile passed in
- matches the this.profile, then call refresh.
-
-2008-08-18 Timothy Hatcher <timothy@apple.com>
-
- Changed the default sort order now that heavy view is the default.
- Also fixes a bug where the heavy profile was not sorted at first.
-
- https://bugs.webkit.org/show_bug.cgi?id=20440
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ProfileView.js:
- (WebInspector.ProfileView): Changed the default sort column. Also assign
- heavyProfile to profile, so the sortSelfTimeDescending call happens
- on the heavy profile before assigning to this.profile.
-
-2008-08-18 Timothy Hatcher <timothy@apple.com>
-
- Add support for editing DOM properties and scope variables by double
- clicking a property to enter edit mode.
-
- https://bugs.webkit.org/show_bug.cgi?id=20415
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/ObjectPropertiesSection.js:
- (WebInspector.ObjectPropertiesSection): Set editable to true by default.
- (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
- Factored out code into update, and calls update.
- (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
- Call removeChildren since this method can be called multiple times now.
- (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
- gets made later in onattach.
- (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
- if shouldRefreshChildren is true. Call removeChildren since this method can be
- called multiple times now.
- (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
- (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
- (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
- this element (code moved from the constructor.)
- (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
- sibling property elements.
- (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
- WebInspector.startEditing after rememebring some context.
- (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
- for the list element, since it might have scrolled during editing.
- (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
- then restore the state from the context. Then call update to restore the title.
- (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
- if the user input and the previous input are the same. Call editingEnded, then call applyExpression
- to commit the user input.
- (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
- and stores the result on the object for the property name of this element. If the expression is
- empty, delete the property and remove the tree element.
- * page/inspector/ScopeChainSidebarPane.js:
- (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
- property on each ObjectPropertiesSection.
- (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
- since it is now implemented.
- * page/inspector/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
- that defaults to true if omitted. It specifies whether to call update on the scope chain.
- * page/inspector/inspector.css: New styles.
- * page/inspector/treeoutline.js:
- (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
- change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
-
-2008-08-18 Timothy Hatcher <timothy@apple.com>
-
- Surround the expression to be evaluated in parenthesis so the
- result of the eval is the result of the whole expression not
- the last potential sub-expression. So evaluating {x: 123}
- will show the Object not 123.
-
- https://bugs.webkit.org/show_bug.cgi?id=20428
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/Console.js:
- (Console.prototype._evalInInspectedWindow): Add parenthesis
- around the expression. And add couple comments.
-
-2008-08-19 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff.
-
- -Implement a page() function to extract a common code pattern.
-
- * WebCore.xcodeproj/project.pbxproj:
- * page/Console.cpp:
- (WebCore::Console::addMessage):
- (WebCore::Console::error):
- (WebCore::Console::info):
- (WebCore::Console::log):
- (WebCore::Console::dir):
- (WebCore::Console::assertCondition):
- (WebCore::Console::time):
- (WebCore::Console::timeEnd):
- (WebCore::Console::group):
- (WebCore::Console::groupEnd):
- (WebCore::Console::finishedProfiling):
- (WebCore::Console::warn):
- (WebCore::Console::framePage):
- * page/Console.h:
-
-2008-08-12 Darin Adler <darin@apple.com>
-
- Reviewed by Geoff.
-
- - eliminate JSValue::type()
-
- * bridge/c/c_instance.cpp:
- (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
- argument instead of JSType argument. Removed unneeded code to handle
- boolean, since that's never passed.
- * bridge/c/c_instance.h: Ditto.
-
- * bridge/c/c_utility.cpp:
- (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
- instead of JSValue::type(). Removed unneeded code to handle
- "unspecified".
-
- * bridge/jni/jni_instance.cpp:
- (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
- instead of JSType argument. Removed unneeded code to handle boolean.
- * bridge/jni/jni_instance.h: Ditto.
-
- * bridge/jni/jni_jsobject.mm:
- (JavaJSObject::convertValueToJObject): Use JSValue::is functions
- instead of JSValue::type().
-
- * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
- instead of JSType argument. Removed unused argument.
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
- (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
- instead of JSType argument. Removed unneeded code to handle boolean
- and another dead code path for unknown types.
-
- * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
- instead of JSType argument. Removed override of type() that caused
- the fallback object to return "UndefinedType" when there is no
- invokeUndefinedMethodFromWebScript:withArguments: method defined.
- That didn't accomplish much, since most checks for undefined don't
- ever call type().
- * bridge/objc/objc_runtime.mm:
- (ObjcFallbackObjectImp::defaultValue): Ditto.
-
- * bridge/qt/qt_instance.cpp:
- (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
- argument instead of JSType argument. Removed unneeded code to handle
- boolean.
- * bridge/qt/qt_instance.h: Ditto.
-
- * bridge/runtime.h:
- (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
- unsed argument.
- * bridge/runtime_object.cpp:
- (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
- argument instead of JSType argument.
- * bridge/runtime_object.h: Ditto.
-
-2008-08-18 Maxime Britto <britto@apple.com>
-
- Reviewed by Adele.
-
- <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
- Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
- We shouldn't be able to create another window while we are in pan scrolling.
- Other browsers behaviors :
- FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
- IE7 : Keys are not disabled but stops immediately the panning.
- This patch matches FF3 behavior by disabling every key but the esc key.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
- (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
-
-2008-08-18 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Dave Hyatt.
-
- - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
-
- Test: fast/replaced/max-width-percent.html
-
- Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
- When false, max-width is not factored into the
- calculation.
- Changed RenderReplaced and subclasses' calcPrefWidths() to call
- calcReplacedWidth(false) and then apply max-width only if it has a
- fixed, positive value.
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcReplacedWidth):
- * rendering/RenderBox.h:
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::calcReplacedWidth):
- (WebCore::RenderImage::calcPrefWidths):
- * rendering/RenderImage.h:
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::calcPrefWidths):
- * rendering/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::calcPrefWidths):
- * rendering/RenderVideo.cpp:
- (WebCore::RenderVideo::calcReplacedWidth):
- (WebCore::RenderVideo::calcPrefWidths):
- * rendering/RenderVideo.h:
-
-2008-08-18 Daniel Macks <dmacks@netspace.org>
-
- Reviewed by Mark Rowe.
-
- https://bugs.webkit.org/show_bug.cgi?id=20410
- More portable/self-documenting replacement for SIZE_MAX.
-
- * platform/network/curl/FormDataStreamCurl.cpp:
- (WebCore::FormDataStream::read):
-
-2008-08-18 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Dave Hyatt
-
- Need to make sure we have an Animation in the AnimationList
- before setting the initial value.
- https://bugs.webkit.org/show_bug.cgi?id=20408
-
- Test: fast/css/transition_shorthand_parsing.html
-
- * css/CSSStyleSelector.cpp:
-
-2008-08-18 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
- is another profile.
-
- * page/inspector/ProfilesPanel.js:
-
-2008-08-18 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Geoff.
-
- <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
- all console messages
-
- * page/inspector/Console.js:
-
-2008-08-18 Dirk Schulze <vbs85@gmx.de>
-
- Reviewed by Eric Seidel.
-
- Fixed Canvas for Cairo. Stroke and fill colors didn't work after
- the canvas clean up.
-
- https://bugs.webkit.org/show_bug.cgi?id=20405
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::fill):
- (WebCore::CanvasRenderingContext2D::stroke):
- (WebCore::CanvasRenderingContext2D::fillRect):
-
-2008-08-17 Timothy Hatcher <timothy@apple.com>
-
- Complete in scope variables in the Console when paused.
-
- https://bugs.webkit.org/show_bug.cgi?id=19115
-
- Reviewed by Geoffrey Garen.
-
- * page/inspector/Console.js:
- (WebInspector.Console.prototype.completions): If the expressionString
- is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
- to get an object that declares all the in scope variables. That way
- "top level" expressions are completed.
- * page/inspector/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
- Return an object that has all the variables that are in scope for the
- selected call frame. The value of each property is just true.
- The return object is useful for quick lookups or auto completion.
-
-2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
-
- Not reviewed.
-
- Speculative Qt build fix.
-
- * bridge/qt/qt_runtime.cpp:
- (KJS::Bindings::convertValueToQVariant):
- (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
-
-2008-08-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Updated project files to XCode 3.1.
-
- * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
-
-2008-08-17 Geoffrey Garen <ggaren@apple.com>
-
- Reviewed by Cameron Zwarich.
-
- Made room for a free word in JSCell.
-
- Changed JSDOMWindowBase to store its auxiliary data in a subclass of
- JSGlobalData, so the two could share a pointer.
-
- Added a bunch of ASSERTs, to help catch over-sized objects.
-
-2008-08-15 Mark Rowe <mrowe@apple.com>
-
- Reviewed by Dan Bernstein.
-
- Disable dead code stripping in debug builds.
-
- * Configurations/Base.xcconfig:
- * WebCore.xcodeproj/project.pbxproj:
-
-2008-08-15 Mark Rowe <mrowe@apple.com>
-
- Rubber-stamped by Geoff Garen.
-
- <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
-
- * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
- between the Debug configuration and debug Production variant.
- * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
-
-2008-08-15 Antti Koivisto <antti@apple.com>
-
- Reviewed by Anders.
-
- Don't start preloading body resources before the head is complete. This prevents
- body preloads from slowing down initial display when there is limited amount
- of bandwidth available.
-
- Works by queuing up found body preloads to DocLoader and only issuing them
- after document has rendering.
-
- With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
- without affecting complete load time.
-
- * html/PreloadScanner.cpp:
- (WebCore::PreloadScanner::PreloadScanner):
- (WebCore::PreloadScanner::scanningBody):
- (WebCore::PreloadScanner::emitTag):
- (WebCore::PreloadScanner::emitCSSRule):
- * html/PreloadScanner.h:
- * loader/DocLoader.cpp:
- (WebCore::DocLoader::preload):
- (WebCore::DocLoader::checkForPendingPreloads):
- (WebCore::DocLoader::requestPreload):
- * loader/DocLoader.h:
- * loader/loader.cpp:
- (WebCore::Loader::Host::didFinishLoading):
- (WebCore::Loader::Host::didFail):
-
-2008-08-15 Ada Chan <adachan@apple.com>
-
- Use item's computed style if the render style is 0 before falling back to the <select>'s style.
- This way style set on an <hr> within a <select> will be honored.
-
- Reviewed by Dave Hyatt and Dan Bernstein.
-
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::itemStyle):
-
-2008-08-15 Antti Koivisto <antti@apple.com>
-
- Reviewed by Oliver.
-
- Some loader performance tweaks:
- - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
- Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
- to not delay rendering.
- - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
- can take long time when latency is high so it is good to get started early.
- - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
- load queues. Issue remaining loads to the network layer.
-
- * loader/loader.cpp:
- (WebCore::Loader::determinePriority):
- (WebCore::Loader::load):
- (WebCore::Loader::Host::servePendingRequests):
- * loader/loader.h:
-
-2008-08-15 Timothy Hatcher <timothy@apple.com>
-
- Detach the script debugger when the Web Inspector's window closes.
- This has always been the intended design, but never fully implemented.
-
- https://bugs.webkit.org/show_bug.cgi?id=20402
-
- Reviewed by Adam Roben.
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
- if the window is no longer visible.
-
-2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
-
- Reviewed by Simon.
+ (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard
+ (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
- Fixes: compile with QT_NO_CONTEXTMENU
-
- * platform/qt/PlatformMouseEventQt.cpp:
- (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- * platform/qt/PlatformScrollBarQt.cpp:
- (WebCore::PlatformScrollbar::handleMouseMoveEvent):
- (WebCore::PlatformScrollbar::handleContextMenuEvent):
-
-2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
-
- Reviewed by Simon.
-
- Fixes: compile with QT_NO_WHEELEVENT
-
- * platform/qt/WheelEventQt.cpp:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent):
-
-2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
-
- Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
-
- https://bugs.webkit.org/show_bug.cgi?id=20210
-
- Reviewed by Tim Hatcher.
-
- * page/Console.cpp:
- (WebCore::Console::group):
- (WebCore::Console::groupEnd):
- * page/Console.h:
- (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
- * page/InspectorController.cpp:
- (WebCore::InspectorController::startGroup): Increments group level by
- one and adds console message with StartGroupMessaageLevel.
- (WebCore::InspectorController::endGroup): Decrements group level by one
- and adds console message with EndGroupMessaageLevel.
- * page/InspectorController.h:
- * page/inspector/Console.js:
- (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
- if the message is StartGroupMessaageLevel.
- (WebInspector.ConsoleMessage.prototype.toMessageElement):
- (WebInspector.ConsoleGroup.prototype.addMessage):
- * page/inspector/inspector.js:
-
-2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
-
- Adds support for console.dir to the Inspector
-
- https://bugs.webkit.org/show_bug.cgi?id=19155
-
- Reviewed by Tim Hatcher.
-
- * bindings/js/JSConsoleCustom.cpp:
- (WebCore::JSConsole::dir):
- * page/Console.cpp:
- (WebCore::Console::dir):
- * page/Console.h: Added ObjectMessageLevel.
- * page/Console.idl: Added console.dir.
- * page/inspector/Console.js:
- (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
- ObjectPropertiesSection if the MessageLevel is Object.
- * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
- used on primitive data types.
- * page/inspector/inspector.css:
-
-2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
-
- Adds support for clear() in the Inspector console.
-
- https://bugs.webkit.org/show_bug.cgi?id=19873
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/Console.js:
-
-2008-08-15 Anthony Ricaud <rik24d@gmail.com>
-
- Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
-
- Platform distinction and modifier key matching adjusted
- by Daniel Jalkut <jalkut@red-sweater.com>
-
- Bug 16313: text search (find) keybindings should work in the Web Inspector
- https://bugs.webkit.org/show_bug.cgi?id=16313
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/inspector.js: Added a case for the F key
-
-2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
-
- Fix for error when the string doesn't contain a webkit-profile link.
-
- https://bugs.webkit.org/show_bug.cgi?id=20399
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/inspector.js:
-
-2008-08-15 Timothy Hatcher <timothy@apple.com>
-
- Fixes two bugs where JavaScript could be executed from the page
- while the debugger is paused.
-
- The first issue was JSLazyEventListener not checking the paused
- state before parsing the code.
-
- The second issue was with the PageGroup version of
- JavaScriptDebugServer::setJavaScriptPaused always passing false
- to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
- and not the paused argument.
-
- https://bugs.webkit.org/show_bug.cgi?id=20284
-
- Reviewed by Adam Roben.
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSLazyEventListener::parseCode): Check the paused
- state of the ScriptController. Return early if paused.
- * manual-tests/inspector/debugger-execution-while-paused.html: Added.
- * page/JavaScriptDebugServer.cpp:
- (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- Pass the paused argument to the Page version of setJavaScriptPaused.
-
-2008-08-15 Alexey Proskuryakov <ap@webkit.org>
-
- Reviewed by Geoff Garen.
-
- JSStringRef is created context-free, but can get linked to one via an identifier table,
- breaking an implicit API contract.
-
- * page/InspectorController.cpp:
- (WebCore::jsStringRef):
- (WebCore::InspectorController::didParseSource):
- (WebCore::InspectorController::failedToParseSource):
- * page/JavaScriptProfile.cpp:
- (WebCore::getTitleCallback):
- Updated for JavaScriptCore changes.
-
-2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
-
- wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
- an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
-
- * platform/graphics/AffineTransform.h:
-
-2008-08-14 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
- <video> elements on Windows never becomes visible when a page is restored from the cache
-
- Always pass "set" calls down to MediaPlayerPrivate instead of only when the
- value is different from the cached value. Let the implementation decide when
- to avoid work because nothing has changed.
-
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::setVolume):
- (WebCore::MediaPlayer::setRate):
- (WebCore::MediaPlayer::setRect):
- (WebCore::MediaPlayer::setVisible):
-
-2008-08-14 Keishi Hattori <casey.hattori@gmail.com>
-
- Make Firebug command line API respect predefined variables.
-
- https://bugs.webkit.org/show_bug.cgi?id=20385
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/Console.js:
-
-2008-08-14 Sam Weinig <sam@webkit.org>
-
- Reviewed by Geoffrey Garen and Timothy Hatcher.
-
- Allow programatically setting the HTMLTokenizers time delay and chunk size
- which are used for determining how aggressively we yield.
-
- * WebCore.base.exp:
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::begin):
- (WebCore::HTMLTokenizer::continueProcessing):
- * html/HTMLTokenizer.h:
- * page/Page.cpp:
- (WebCore::Page::Page):
- (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
- (WebCore::Page::setCustomHTMLTokenizerChunkSize):
- * page/Page.h:
- (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
- (WebCore::Page::customHTMLTokenizerTimeDelay):
- (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
- (WebCore::Page::customHTMLTokenizerChunkSize):
-
-2008-08-14 Eric Seidel <eric@webkit.org>
-
- Reviewed by Beth.
-
- Move us one step closer to cross-platform svg/graphics code
-
- * WebCore.xcodeproj/project.pbxproj:
- * html/CanvasStyle.cpp:
- * platform/graphics/Color.cpp:
- (WebCore::colorWithOverrideAlpha):
- * platform/graphics/Color.h:
- * svg/graphics/cg/CgSupport.cpp:
- (WebCore::applyStrokeStyleToContext):
- (WebCore::strokeBoundingBox):
- * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
- (WebCore::SVGPaintServerSolid::setup):
-
-2008-08-14 Eric Seidel <eric@webkit.org>
-
- Reviewed by Alexey.
-
- Remove un-need includes from HTMLCanvas and use the
- Gradient platform abstraction in one place in CanvasStyle
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::fillRect):
- * html/CanvasStyle.cpp:
- * html/HTMLCanvasElement.cpp:
-
-2008-08-14 Eric Seidel <eric@webkit.org>
-
- Reviewed by Alexey.
-
- Clean up GlyphBuffer.h, removing more #ifdefs
-
- * platform/graphics/GlyphBuffer.h:
- (WebCore::GlyphBuffer::glyphAt):
- (WebCore::GlyphBuffer::advanceAt):
- (WebCore::GlyphBuffer::add):
-
-2008-08-14 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam.
-
- Clean up AffineTransform.h, removing #ifdefs
-
- * platform/graphics/AffineTransform.h:
- * platform/graphics/cairo/AffineTransformCairo.cpp:
- * platform/graphics/cg/AffineTransformCG.cpp:
- * platform/graphics/qt/AffineTransformQt.cpp:
- * platform/graphics/wx/AffineTransformWx.cpp:
-
-2008-08-14 Dan Bernstein <mitz@apple.com>
-
- - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
-
- * platform/graphics/cairo/ImageSourceCairo.cpp:
- (WebCore::ImageSource::frameSizeAtIndex):
- * platform/graphics/qt/ImageSourceQt.cpp:
- (WebCore::ImageSource::frameSizeAtIndex):
- * platform/graphics/wx/ImageSourceWx.cpp:
- (WebCore::ImageSource::frameSizeAtIndex):
-
-2008-08-14 Dan Bernstein <mitz@apple.com>
+2009-06-16 Antti Koivisto <antti@apple.com>
Reviewed by Brady Eidson.
- - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage): Added initialization of
- m_hasUniformFrameSize.
- (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
- cached frame for use in decoded size computation and for setting
- m_hasUniformFrameSize.
- (WebCore::BitmapImage::currentFrameSize): Added.
- (WebCore::BitmapImage::dataChanged): Added code to reset
- m_hasUniformFrameSize.
- * platform/graphics/BitmapImage.h: Added currentFrameSize() and
- m_hasUniformFrameSize.
- * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
- fixes the bug, which resulted from assuming that the frame being drawn
- was the same size as the first frame.
- * platform/graphics/cg/ImageSourceCG.cpp:
- (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
- changed to get the size of the frame at the given index.
- (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
-
-2008-08-13 Simon Fraser <simon.fraser@apple.com>
-
- Reviewed by Eric Seidel
-
- Fix @font-face inside @media rule crash.
- https://bugs.webkit.org/show_bug.cgi?id=20367
-
- Test: fast/css/font-face-in-media-rule.html
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSRuleSet::addRulesFromSheet):
-
-2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fixes after recent changes to Canvas and Image classes.
-
- * platform/graphics/Pattern.h:
- * platform/graphics/wx/GradientWx.cpp:
- (WebCore::Gradient::fill):
- * platform/graphics/wx/GraphicsContextWx.cpp:
- (WebCore::GraphicsContext::applyFillPattern):
- (WebCore::GraphicsContext::applyStrokePattern):
- * platform/graphics/wx/ImageBufferWx.cpp:
- (WebCore::ImageBuffer::image):
- * platform/graphics/wx/ImageWx.cpp:
- (WebCore::Image::loadPlatformResource):
-
-2008-08-14 Maxime Britto <britto@apple.com>
-
- Reviewed by Sam Weinig.
-
- rdar://6102511
- When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
- IE and FF are both preventing the keyboard event to interact with the page while scrolling.
- Some differences exist between them concerning the kind of key which is pressed :
- IE7 : every key leads to a stop of the panning
- FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
- For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
-
-2008-08-14 Christian Dywan <christian@twotoasts.de>
-
- Gtk+/ Cairo build fix, patch by Dirk Schulze.
-
- * html/CanvasStyle.cpp:
- * platform/graphics/cairo/PatternCairo.cpp:
- (WebCore::Pattern::createPlatformPattern):
- * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
-
-2008-08-14 Kevin McCullough <kmccullough@apple.com>
-
- Reviewed by Tim.
-
- <rdar://problem/6115819> Notify of profile in console
-
- * page/InspectorController.cpp:
- (WebCore::InspectorController::addProfile):
- (WebCore::InspectorController::addProfileMessageToConsole): Called by
- addProfile this is the function that adds a message to the console that
- a profile finished.
- * page/InspectorController.h:
- * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
- the console log to the profile in the web inspector.
- (WebCore::getUniqueIdCallback):
- (WebCore::ProfileClass):
- * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
- Id to bring up the requested profile. Also select and reveal the
- profile in the profile panel. And created displayTitleForProfileLink()
- which formats a title taking into account if it's user initiated or if
- there are multiples. Lasty, I put the user initiated profile in a
- variable.
- * page/inspector/inspector.js: Make the profile title be a clickable
- link that will take the user to the identified profile. Also expose
- the count of user initiated profiles so they can be displayed in the
- console with the correct count.
-
-2008-08-14 Timothy Hatcher <timothy@apple.com>
-
- Avoid formating ConsoleMessages twice unless the message will be
- displayed in bubbles of a SourceFrame.
-
- Reviewed by Kevin McCullough.
-
- * page/inspector/Console.js:
- (WebInspector.ConsoleMessage): Only format the plain text message
- if the URL and line are valid and the level is error or warning.
- (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
- Helper to test for error or warning level.
- * page/inspector/SourceFrame.js:
- (WebInspector.SourceFrame.prototype.addMessage): Don't add the
- message if there is no message or valid line or if the msg
- isn't an error or warning.
-
-2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- partial Gtk build fix, not reviewed
-
- * platform/graphics/cairo/PatternCairo.cpp:
-
-2008-08-13 Sam Weinig <sam@webkit.org>
-
- Reviewed by Anders Carlsson.
-
- Fix style issue.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::pickMedia):
-
-2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
-
- Build fix for Cairo, not reviewed. (exposed by gtk build slave)
- Continue Erics build fixes, after the Image cleanup.
-
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::image):
-
-2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
-
- Build fix for Qt, not reviewed.
- Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
-
- * dom/XMLTokenizer.cpp:
- (WebCore::eventuallyMarkAsParserCreated): Was erre
-
-2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
-
- Build fix, not reviewed.
- Add ScriptElement.cpp to Gtk build.
-
- * GNUmakefile.am:
-
-2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Eric.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
-
- Refactor HTMLScriptElement's code into a common base class: ScriptElement.
- SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
-
- This resolves code duplications and allows us to completly replace the old
- SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
-
- As ScriptElement, doesn't actually inherit from Element, we may want to rename
- it, though StyleElement uses the same naming convention, so I left it as is for now.
- Eventually we'll rename both files in future.
-
- No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
-
- * WebCore.pro: Add new ScriptElement.cpp to build.
- * WebCore.vcproj/WebCore.vcproj: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto.
- * WebCoreSources.bkl: Dutto.
- * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
- (WebCore::ScriptElement::insertedIntoDocument):
- (WebCore::ScriptElement::removedFromDocument):
- (WebCore::ScriptElement::childrenChanged):
- (WebCore::ScriptElement::finishParsingChildren):
- (WebCore::ScriptElement::handleSourceAttribute):
- (WebCore::isSupportedJavaScriptLanguage):
- (WebCore::ScriptElementData::ScriptElementData):
- (WebCore::ScriptElementData::~ScriptElementData):
- (WebCore::ScriptElementData::requestScript):
- (WebCore::ScriptElementData::evaluateScript):
- (WebCore::ScriptElementData::stopLoadRequest):
- (WebCore::ScriptElementData::notifyFinished):
- (WebCore::ScriptElementData::ignoresLoadRequest):
- (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
- (WebCore::ScriptElementData::scriptCharset):
- (WebCore::ScriptElementData::scriptContent):
- * dom/ScriptElement.h: Added.
- (WebCore::ScriptElement::ScriptElement):
- (WebCore::ScriptElement::~ScriptElement):
- (WebCore::ScriptElementData::element):
- (WebCore::ScriptElementData::createdByParser):
- (WebCore::ScriptElementData::setCreatedByParser):
- * dom/XMLTokenizer.cpp:
- (WebCore::isScriptElement):
- (WebCore::castToScriptElement):
- (WebCore::eventuallyMarkAsParserCreated):
- (WebCore::XMLTokenizer::startElementNs):
- (WebCore::XMLTokenizer::endElementNs):
- (WebCore::createXHTMLParserErrorHeader):
- (WebCore::XMLTokenizer::insertErrorMessageBlock):
- * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
- (WebCore::HTMLScriptElement::HTMLScriptElement):
- (WebCore::HTMLScriptElement::~HTMLScriptElement):
- (WebCore::HTMLScriptElement::isURLAttribute):
- (WebCore::HTMLScriptElement::setCreatedByParser):
- (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
- (WebCore::HTMLScriptElement::childrenChanged):
- (WebCore::HTMLScriptElement::parseMappedAttribute):
- (WebCore::HTMLScriptElement::finishParsingChildren):
- (WebCore::HTMLScriptElement::insertedIntoDocument):
- (WebCore::HTMLScriptElement::removedFromDocument):
- (WebCore::HTMLScriptElement::text):
- (WebCore::HTMLScriptElement::setText):
- (WebCore::HTMLScriptElement::setHtmlFor):
- (WebCore::HTMLScriptElement::setEvent):
- (WebCore::HTMLScriptElement::charset):
- (WebCore::HTMLScriptElement::src):
- (WebCore::HTMLScriptElement::type):
- (WebCore::HTMLScriptElement::scriptCharset):
- (WebCore::HTMLScriptElement::scriptContent):
- (WebCore::HTMLScriptElement::sourceAttributeValue):
- (WebCore::HTMLScriptElement::charsetAttributeValue):
- (WebCore::HTMLScriptElement::typeAttributeValue):
- (WebCore::HTMLScriptElement::languageAttributeValue):
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- (WebCore::HTMLScriptElement::dispatchErrorEvent):
- * html/HTMLScriptElement.h:
- * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::SVGScriptElement):
- (WebCore::SVGScriptElement::scriptContent):
- (WebCore::SVGScriptElement::sourceAttributeValue):
- (WebCore::SVGScriptElement::charsetAttributeValue):
- (WebCore::SVGScriptElement::typeAttributeValue):
- (WebCore::SVGScriptElement::languageAttributeValue):
- (WebCore::SVGScriptElement::dispatchLoadEvent):
- (WebCore::SVGScriptElement::dispatchErrorEvent):
- * svg/SVGScriptElement.h:
- (WebCore::SVGScriptElement::setCreatedByParser):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Attempt to fix the Gtk build, no review.
-
- I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
-
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- * platform/graphics/qt/GradientQt.cpp:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::paintMozWidget):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Yet another attempt to fix the Qt build, no review.
-
- * platform/graphics/qt/GradientQt.cpp:
- * platform/graphics/qt/GraphicsContextQt.cpp:
- (WebCore::GraphicsContext::applyStrokePattern):
- (WebCore::GraphicsContext::applyFillPattern):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Attempt to fix the Windows build, no review.
-
- * platform/win/CursorWin.cpp:
- (WebCore::loadCursorByName):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::paint):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Attempt to fix the Windows build, no review.
-
- * platform/win/CursorWin.cpp:
- (WebCore::loadCursorByName):
- * platform/win/ScrollViewWin.cpp:
- (WebCore::ScrollView::paint):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Attempt to fix the Qt build, no review.
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- (WebCore::ImageBuffer::image):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Attempt to fix the Windows build, no review.
-
- * platform/graphics/win/ImageWin.cpp:
- (WebCore::Image::loadPlatformResource):
- * plugins/win/PluginViewWin.cpp:
- (WebCore::PluginView::paintMissingPluginIcon):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Another attempt to fix the Qt build, no review.
-
- * platform/graphics/qt/ImageQt.cpp:
- * platform/graphics/qt/StillImageQt.h:
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- No review, build fix only.
-
- Fix mac build, due to change in new code since my patch was written.
-
- * svg/graphics/cg/SVGResourceMaskerCg.mm:
- (WebCore::SVGResourceMasker::applyMask):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- Attempt to fix the Qt build.
-
- * platform/graphics/qt/ImageBufferQt.cpp:
- * platform/graphics/qt/StillImageQt.h:
- (WebCore::StillImage::create):
- (WebCore::StillImage::destroyDecodedData):
- (WebCore::StillImage::decodedSize):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Build fix only, no review.
-
- Attempt to fix the Qt build.
-
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Sam.
-
- Match HTML5 spec by throwing INVALID_STATE_ERR when
- createPattern is called and the HTMLImageElement is not
- yet done loading the image (!isComplete)
- https://bugs.webkit.org/show_bug.cgi?id=20351
-
- Test: http/misc/canvas-pattern-from-incremental-image.html
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::createPattern):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Niko.
-
- Split out a Pattern class from CanvasPattern
- and remove all the Pattern-related #ifdefs
- (This will break non-mac platforms! I will fix them.)
- https://bugs.webkit.org/show_bug.cgi?id=20351
-
- * GNUmakefile.am:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- * html/CanvasPattern.cpp:
- (WebCore::CanvasPattern::parseRepetitionType):
- (WebCore::CanvasPattern::CanvasPattern):
- * html/CanvasPattern.h:
- (WebCore::CanvasPattern::create):
- (WebCore::CanvasPattern::pattern):
- (WebCore::CanvasPattern::originClean):
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::createPattern):
- (WebCore::CanvasRenderingContext2D::applyStrokePattern):
- (WebCore::CanvasRenderingContext2D::applyFillPattern):
- * html/CanvasRenderingContext2D.h:
- * html/HTMLCanvasElement.cpp:
- * html/HTMLCanvasElement.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::createHistoryItem):
- * platform/graphics/GraphicsContext.h:
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::applyStrokePattern):
- (WebCore::GraphicsContext::applyFillPattern):
- * platform/graphics/cg/GraphicsContextCG.cpp:
- (WebCore::GraphicsContext::clipToImageBuffer):
- (WebCore::GraphicsContext::applyStrokePattern):
- (WebCore::GraphicsContext::applyFillPattern):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Niko.
-
- Make Images RefCounted (and clean up callers)
- https://bugs.webkit.org/show_bug.cgi?id=20351
+ <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53
+
+ When revalidating a resource, calling addClient() on one client might cause another to get removed.
+
+ - made CachedResource::addClient() non-virtual and added virtual didAddClient()
+ - in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
+ - check if the client is still in the set before invoking didAddClient() for it
+
+ No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
+ reference each other via @imports and reloading.
- * editing/DeleteButtonController.cpp:
- (WebCore::DeleteButtonController::createDeletionUI):
+ * WebCore.base.exp:
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::didAddClient):
+ * loader/CachedCSSStyleSheet.h:
+ * loader/CachedFont.cpp:
+ (WebCore::CachedFont::didAddClient):
+ * loader/CachedFont.h:
* loader/CachedImage.cpp:
- (WebCore::CachedImage::CachedImage):
- (WebCore::brokenImage):
- (WebCore::nullImage):
- (WebCore::CachedImage::image):
- (WebCore::CachedImage::notifyObservers):
- (WebCore::CachedImage::createImage):
+ (WebCore::CachedImage::didAddClient):
* loader/CachedImage.h:
- * loader/icon/IconRecord.cpp:
- (WebCore::IconRecord::setImageData):
- (WebCore::IconRecord::loadImageFromResource):
- * loader/icon/IconRecord.h:
- * platform/graphics/BitmapImage.h:
- (WebCore::BitmapImage::create):
- * platform/graphics/GeneratedImage.h:
- * platform/graphics/Gradient.cpp:
- * platform/graphics/Gradient.h:
- * platform/graphics/Image.cpp:
- (WebCore::Image::nullImage):
- * platform/graphics/Image.h:
- * platform/graphics/ImageBuffer.h:
- * platform/graphics/cairo/ImageBufferCairo.cpp:
- (WebCore::ImageBuffer::image):
- * platform/graphics/cg/ImageBufferCG.cpp:
- (WebCore::ImageBuffer::image):
- (WebCore::ImageBuffer::getImageData):
- (WebCore::ImageBuffer::putImageData):
- * platform/graphics/cg/PDFDocumentImage.h:
- (WebCore::PDFDocumentImage::create):
- (WebCore::PDFDocumentImage::destroyDecodedData):
- (WebCore::PDFDocumentImage::decodedSize):
- * platform/graphics/gtk/ImageGtk.cpp:
- (WebCore::Image::loadPlatformResource):
- * platform/graphics/mac/ImageMac.mm:
- (WebCore::Image::loadPlatformResource):
- * rendering/RenderImage.cpp:
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintOverflowControls):
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::nativeImageForCurrentFrame):
- * svg/graphics/SVGImage.h:
- (WebCore::SVGImage::create):
- (WebCore::SVGImage::destroyDecodedData):
- (WebCore::SVGImage::decodedSize):
- (WebCore::SVGImage::frameAtIndex):
- * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
- (WebCore::SVGPaintServerPattern::setup):
- * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
- (WebCore::SVGResourceMasker::applyMask):
- * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
- (WebCore::patternCallback):
- * svg/graphics/cg/SVGResourceMaskerCg.mm:
- (WebCore::SVGResourceMasker::applyMask):
-
-2008-08-13 Eric Seidel <eric@webkit.org>
-
- Reviewed by Niko.
-
- Remove #ifdefs from CanvasStyle by using platform/Color.h
- https://bugs.webkit.org/show_bug.cgi?id=20351
-
- There are some down-sides to this commit.
- This commit limits us to 255 levels of grey for calls like:
- context.setStrokeStyle(.37, 1.0)
- previously CG might have used up to 32bits to store the grey level
- Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
-
- Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
- to RGBA32 (like all the rest of colors in WebCore), thus:
- context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
- context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
-
- If this is a problem for Dashboard, we can either roll out this commit
- or add a beefier Color abstraction, which can be used internally by GraphicsContext
- when keeping state, and then GraphicsContext can grow some additional set* routines
- for setting the a grey/float/whatever fill and stroke.
-
- * html/CanvasRenderingContext2D.cpp:
- (WebCore::CanvasRenderingContext2D::setFillStyle):
- * html/CanvasStyle.cpp:
- (WebCore::CanvasStyle::CanvasStyle):
- (WebCore::colorWithOverrideAlpha):
- (WebCore::CanvasStyle::applyStrokeColor):
- (WebCore::CanvasStyle::applyFillColor):
- * html/CanvasStyle.h:
- * platform/graphics/Color.cpp:
- (WebCore::colorFloatToRGBAByte):
- (WebCore::makeRGBA32FromFloats):
- * platform/graphics/Color.h:
-
-2008-08-13 Eric Carlson <eric.carlson@apple.com>
-
- Reviewed by Adele Peterson.
-
- Fix for <rdar://problem/6137931>
- https://bugs.webkit.org/show_bug.cgi?id=20360
- Remove all parameters from the MIME type before checking with the MIME type registry
-
- Tests: media/video-source-type-params.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
- to isSupportedMediaMIMEType()
-
-2008-08-13 Beth Dakin <bdakin@apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix for <rdar://problem/6141345>
-
- This patch refines findString and markAllMatchesForText functions'
- interactions with disconnected frames. They no longer rely on
- knowing where a range is relative to the visible region and work
- with disconnected frames that contain frames.
-
- * editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
- the visiblity enum.
- (WebCore::Editor::firstVisibleRange): This now returns the very
- first visible range in the document. It's no longer dependent on
- searching forward.
- (WebCore::Editor::lastVisibleRange): This now returns the very last
- visible range in the document. It's no longer dependent on
- searching backwards.
- (WebCore::Editor::nextVisibleRange): This returns the next visible
- range in the appropriate direction from the current range.
- * editing/Editor.h:
- * page/Frame.cpp:
- (WebCore::Frame::findString):
- (WebCore::Frame::markAllMatchesForText):
-
-2008-08-13 Kevin Ollivier <kevino@theolliviers.com>
-
- wx build fix for case-sensitive platforms, like Linux.
-
- * WebCoreSources.bkl:
-
-2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
-
- Reviewed by Holger Freyther.
-
- http://bugs.webkit.org/show_bug.cgi?id=16881
- [GTK] PlatformScreenGtk is unimplemented
-
- Original patch by Christian Dywan.
-
- * platform/gtk/PlatformScreenGtk.cpp:
- (WebCore::screenDepth):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenIsMonochrome):
- (WebCore::screenRect):
- (WebCore::screenAvailableRect):
-
-2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
-
- Reviewed by Holger Freyther.
-
- http://bugs.webkit.org/show_bug.cgi?id=20318
- SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
-
- g_idle_add is the same as g_idle_add_full with a priority of
- G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
-
- * platform/gtk/SharedTimerGtk.cpp:
- (WebCore::setSharedTimerFireTime):
-
-2008-08-13 Timothy Hatcher <timothy@apple.com>
-
- Changed the InspectorController so it can be notified when the
- attached state of the Inspector changes in WebKit.
-
- Reviewed by Kevin McCullough.
-
- * WebCore.base.exp: Updated the symbol for setWindowVisible.
- * page/InspectorController.cpp:
- (WebCore::InspectorController::setWindowVisible): Added an attached argument,
- that defaults to false.Call setAttachedWindow with the attached argument.
- (WebCore::InspectorController::setAttachedWindow): Call the script version
- of setAttachedWindow.
- * page/InspectorController.h:
- * page/inspector/inspector.js:
- (WebInspector.setAttachedWindow): Set the attached property.
-
-2008-08-12 Timothy Hatcher <timothy@apple.com>
-
- Added a close button to the Inspector's toolbar when docked.
-
- https://bugs.webkit.org/show_bug.cgi?id=14270
-
- Reviewed by Kevin McCullough.
-
- * page/InspectorController.cpp:
- (WebCore::closeWindow): Call InspectorController::closeWindow.
- (WebCore::InspectorController::windowScriptObjectAvailable):
- Added closeWindow to the script class.
- * page/InspectorController.h:
- * page/inspector/Images/closeButtons.png: Added.
- * page/inspector/inspector.css: Added and changed styles.
- * page/inspector/inspector.html: Added the close button.
- * page/inspector/inspector.js:
- (WebInspector.loaded): Added click event listener to the close button.
- (WebInspector.close): Call InspectorController.closeWindow.
-
-2008-08-12 Timothy Hatcher <timothy@apple.com>
-
- Make the docked Web Inspector resizable. This is the cross platform
- portion of the code. Each InspectorClient needs to implement the
- real resize code.
-
- https://bugs.webkit.org/show_bug.cgi?id=14282
-
- Reviewed by Kevin McCullough.
-
- * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
- * page/InspectorClient.h: Added setAttachedWindowHeight.
- * page/InspectorController.cpp:
- (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
- on the InspectorController.
- (WebCore::InspectorController::setAttachedWindowHeight): Call
- setAttachedWindowHeight on the client.
- (WebCore::InspectorController::windowScriptObjectAvailable):
- Added setAttachedWindowHeight to the script class.
- * page/InspectorController.h:
- * page/inspector/inspector.css: Make the cursor on the toolbar be
- row-resize when docked.
- * page/inspector/inspector.js:
- (WebInspector.loaded): Always add the toolbarDragStart event listener.
- (WebInspector.toolbarDragStart): Return early if we are not attached
- and not on Leopard. Call WebInspector.elementDragStart.
- (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
- (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
- otherwise call moveByUnrestricted.
-
-2008-08-13 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Holger.
-
- Initialize m_zoomsTextOnly in the Settings constructor.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
-
-2008-08-13 Brad Hughes <bhughes@trolltech.com>
-
- Reviewed by Simon.
-
- Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
-
- The latest upgrade of the intel compiler allows us to compile all of
- Qt with optimizations enabled (yay!).
-
- * WebCore.pro:
-
-2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
-
- Reviewed by Simon.
-
- Fix QtWebKit not displaying content on 403 HTTP responses
-
- Just like with 404 responses also display content with 403, as
- used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
-
- * platform/network/qt/QNetworkReplyHandler.cpp:
- (WebCore::QNetworkReplyHandler::finish):
-
-2008-08-13 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Holger.
-
- Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
-
- Make the formatting of String::format() locale independent through the use of QString::vsprintf.
-
- * platform/text/String.cpp:
- (WebCore::String::format):
-
-2008-08-13 Simon Hausmann <hausmann@webkit.org>
-
- Reviewed by Lars.
-
- Fix QWebFrame::setHtml() not setting the new contents immediately.
-
- Added a setter to the DocumentLoader to toggle the deferred loading of the main
- resource when it comes from substitute data.
-
- Disable deferred loading of the main resource when we have valid substitute data,
- as used by QWebFrame::setHtml.
-
- * loader/DocumentLoader.h:
-
-2008-08-13 Mark Rowe <mrowe@apple.com>
-
- Speculative GTK build fix.
-
- * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
-
-2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
-
- Reviewed by Simon.
-
- Fix encoding of [ and ] in the host part of the URL
-
- Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
- add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
- doesn't encode [ and ] when they are found in the host part. That is, the
- following URL:
- http://[::1]/
- is valid and should not be reencoded to:
- http://%5b::1%5d/
-
- * platform/qt/KURLQt.cpp:
- (WebCore::KURL::operator QUrl):
-
-2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
- Broken HTML object elements cause de-reference of pointer to freed memory.
- If we fail to load an image for an object tag and we no longer believe the object tag points at
- an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
- fall back content.
-
- Reviewed by Dave Hyatt and Alexey Proskuryakov.
-
- Test: http/tests/misc/object-image-error-with-onload.html
-
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::renderFallbackContent):
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
-
-2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Dave.
-
- Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
- Masks are translated, and the mask images are swapped on the y-axis.
-
- Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
- is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
-
- Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
- the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
-
- * svg/graphics/cg/SVGResourceMaskerCg.mm:
- (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
-
-2008-08-12 Dan Bernstein <mitz@apple.com>
-
- - WebCore part of <rdar://problem/6121636>
- Make fast*alloc() abort() on failure and add "try" variants that
- return NULL on failure.
-
- Reviewed by Darin Adler.
-
- * platform/Arena.cpp:
- (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
- result.
- * platform/graphics/cg/ImageBufferCG.cpp:
- (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
-
-2008-08-12 Dan Bernstein <mitz@apple.com>
-
- Reviewed by Darin Adler.
-
- - fix https://bugs.webkit.org/show_bug.cgi?id=19348
- <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
-
- Test: fast/frames/frameset-style-recalc.html
-
- * html/HTMLFrameSetElement.cpp:
- (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
- class implementation after marking for layout.
-
-2008-08-12 Dan Bernstein <mitz@apple.com>
-
- Reviewed by John Sullivan.
-
- - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
-
- * WebCore.base.exp:
- * page/FrameView.cpp:
- (WebCore::FrameViewPrivate::FrameViewPrivate):
- (WebCore::FrameView::shouldUpdateWhileHidden):
- (WebCore::FrameView::setShouldUpdateWhileHidden):
- * page/FrameView.h:
- * page/Settings.cpp:
- * page/Settings.h:
-
-2008-08-12 Adam Roben <aroben@apple.com>
-
- Windows build fix
-
- * bindings/js/JSSVGPODTypeWrapper.h: Align
- JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
- members on 16-byte boundaries to avoid an alignment warning.
-
-2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver.
-
- Add new dynamice-update layout tests covering SVGMarkerElement.
- Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
- Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
-
- Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
- svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
- svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
- svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
- svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
- svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
- svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
-
- * svg/SVGMarkerElement.cpp:
- (WebCore::SVGMarkerElement::SVGMarkerElement):
- (WebCore::SVGMarkerElement::parseMappedAttribute):
- (WebCore::SVGMarkerElement::svgAttributeChanged):
- (WebCore::SVGMarkerElement::childrenChanged):
- (WebCore::SVGMarkerElement::setOrientToAuto):
- (WebCore::SVGMarkerElement::setOrientToAngle):
- (WebCore::SVGMarkerElement::canvasResource):
-
-2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
-
- Reviewed by Oliver.
-
- Add new dynamic-update layout tests covering SVGImageElement.
- Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
-
- Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
- svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
- svg/dynamic-updates/SVGImageElement-dom-width-attr.html
- svg/dynamic-updates/SVGImageElement-dom-x-attr.html
- svg/dynamic-updates/SVGImageElement-dom-y-attr.html
- svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
- svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
- svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
- svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
- svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
-
- * svg/SVGImageElement.cpp:
- (WebCore::SVGImageElement::svgAttributeChanged):
-
-2008-08-11 Anthony Ricaud <rik24d@gmail.com>
-
- Changed Option/Alt-Up or Down in CSS editing when the value is
- near zero to jump to the next integer.
-
- Reviewed by Tim Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=20326
-
- * page/inspector/StylesSidebarPane.js:
-
-2008-08-11 Anthony Ricaud <rik24d@gmail.com>
-
- Changed the line highlight transition for an easier animation.
-
- Reviewed by Tim Hatcher.
-
- * page/inspector/SourceFrame.js:
-
-2008-08-11 Keishi Hattori <casey.hattori@gmail.com>
-
- Added support for some Firebug Command Line APIs.
-
- Reviewed by Tim Hatcher.
-
- https://bugs.webkit.org/show_bug.cgi?id=19867
- https://bugs.webkit.org/show_bug.cgi?id=19868
- https://bugs.webkit.org/show_bug.cgi?id=19869
- https://bugs.webkit.org/show_bug.cgi?id=19875
- https://bugs.webkit.org/show_bug.cgi?id=19876
- https://bugs.webkit.org/show_bug.cgi?id=19880
-
- * page/inspector/Console.js:
- (WebInspector.Console.prototype._evalInInspectedWindow):
- Create an object on the inspected window that holds the console
- command line API functions. This object is used in a with statement
- around the typed expression.
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::addClient):
+ (WebCore::CachedResource::addClientToSet):
+ (WebCore::CachedResource::switchClientsToRevalidatedResource):
+ * loader/CachedResource.h:
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::didAddClient):
+ * loader/CachedScript.h:
+ * loader/CachedXSLStyleSheet.cpp:
+ (WebCore::CachedXSLStyleSheet::didAddClient):
+ * loader/CachedXSLStyleSheet.h:
-2008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
+2009-06-16 Simon Fraser <simon.fraser@apple.com>
- Reviewed by Antti.
+ No Review
- Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
+ Fix code inside an #ifdef that draws the video framerate.
- JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
- failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::paint):
- Added tests: svg/custom/svg-modify-currentTranslate.html
- svg/custom/tearoffs-with-tearoffs.html
- svg/custom/immutable-properties.html
+2009-06-16 Jian Li <jianli@chromium.org>
- Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
+ Reviewed by Dimitri Glazkov.
- * bindings/js/JSSVGPODTypeWrapper.h:
- (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
- (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
- (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
- (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
- (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
- (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
- (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
- (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
- * bindings/scripts/CodeGenerator.pm:
- * bindings/scripts/CodeGeneratorJS.pm:
- * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
- * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
+ Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
+ https://bugs.webkit.org/show_bug.cgi?id=26456
-2008-08-11 Brady Eidson <beidson@apple.com>
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code
+ handling in Worker constructor for V8 bindings.
+ (WebCore::CALLBACK_FUNC_DECL):
- Reviewed by John and Anders
+2009-06-16 Brent Fulgham <bfulgham@webkit.org>
- Fix for <rdar://problem/6141797>
+ Reviewed by Maciej Stachowiak.
- When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
- would never have nil data.
+ Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
+ Provide an assignment operator to avoid improper reference
+ counts on the Cairo font objects. This brings the Windows
+ Cairo port in line with the GTK+ port.
- When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
- semantics with some WebKit applications.
+ * platform/graphics/win/FontPlatformData.h:
+ * platform/graphics/win/FontPlatformDataCairoWin.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::operator=):
- The guarantee was a good one and should be restored.
+2009-06-16 Eric Carlson <eric.carlson@apple.com>
- Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
- creates an empty data object in the case of null data for its own purposes.
+ Reviewed by Simon Fraser.
- * loader/SubstituteResource.h:
- (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
- well help any future subclassers not make this mistake.
+ Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from
+ the MediaControlInputElement, rather than computing it again
- * loader/archive/ArchiveResource.cpp:
- (WebCore::ArchiveResource::create): Return 0 if the data is null.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
+ * html/HTMLMediaElement.h:
-2008-08-11 Simon Fraser <simon.fraser@apple.com>
+ * rendering/MediaControlElements.h:
+ (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
- Reviewed by Dave Hyatt
+ * rendering/RenderMediaControls.cpp:
+ (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button
+ state from the button itself and get movie state from HTMLMediaElement.
- https://bugs.webkit.org/show_bug.cgi?id=20328
- Fix a problem when an 'all' transition transition with more than
- one property changing is interrupted, and did some AnimationController
- cleanup.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer.
+ (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
- Test: transitions/interrupted-all-transition.html
+2009-06-16 Jian Li <jianli@chromium.org>
- * page/AnimationController.cpp:
- (WebCore::ImplicitAnimation::ImplicitAnimation):
- (WebCore::AnimationControllerPrivate::blendProperties):
- (WebCore::CompositeAnimation::updateTransitions):
- (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- (WebCore::CompositeAnimation::setTransitionStartTime):
- (WebCore::CompositeAnimation::overrideImplicitAnimations):
- (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
- (WebCore::ImplicitAnimation::animate):
- (WebCore::ImplicitAnimation::onAnimationEnd):
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- (WebCore::ImplicitAnimation::affectsProperty):
- (WebCore::KeyframeAnimation::endAnimation):
- (WebCore::KeyframeAnimation::onAnimationEnd):
+ Reviewed by David Levin.
-2008-08-11 Kevin McCullough <kmccullough@apple.com>
+ Bug 26450: Rename values of enum RedirectOriginCheck to make them
+ clearer.
+ https://bugs.webkit.org/show_bug.cgi?id=26450
- Reviewed by Tim.
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::create):
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::willSendRequest):
+ * loader/DocumentThreadableLoader.h:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/ThreadableLoader.h:
+ * workers/Worker.cpp:
+ (WebCore::Worker::Worker):
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::importScripts):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ * loader/WorkerThreadableLoader.h:
+ (WebCore::WorkerThreadableLoader::create):
+ * workers/WorkerScriptLoader.cpp:
+ (WebCore::WorkerScriptLoader::loadSynchronously):
+ (WebCore::WorkerScriptLoader::loadAsynchronously):
+ * workers/WorkerScriptLoader.h:
+ (WebCore::WorkerContext::importScripts):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- - Because console messages have group levels now, newly created messages
- that do not specify the level lose their message since the number of
- arguments is wrong.
+2009-06-16 Tony Chang <tony@chromium.org>
- * page/inspector/Console.js:
- * page/inspector/Resource.js:
+ Reviewed by Darin Fisher.
-2008-08-11 Alp Toker <alp@nuanti.com>
+ Fix a UMR in WebCore::BitStack by initializing new memory to 0.
+ https://bugs.webkit.org/show_bug.cgi?id=26449
+ No new tests, covered by purify.
- Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
- the opportunity to sort the sources lists.
+ * editing/TextIterator.cpp:
+ (WebCore::BitStack::push):
- * GNUmakefile.am:
+2009-06-16 Brent Fulgham <bfulgham@webkit.org>
-2008-08-11 Timothy Hatcher <timothy@apple.com>
+ Reviewed by Xan Lopez.
- Speed up the the JavaScript syntax highlighter by generating
- the finders only once per script instead of per line.
+ Test: fast/multicol/columns-shorthand-parsing.html
- https://bugs.webkit.org/show_bug.cgi?id=20346
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
+ Null Cairo contextwill crash Windows Cairo build.
- Reviewed by Adam Roben.
+ * platform/graphics/win/GraphicsContextCairoWin.cpp:
+ (WebCore::GraphicsContextPlatformPrivate::syncContext):
+ Add a check for null context before attempting to
+ retrieve the Cairo surface.
- * page/inspector/SourceFrame.js:
- (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
- Removed, factored into syntaxHighlightJavascript as an inline function.
- (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
- Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
- Generate the finders before iterating the lines.
+2009-06-16 Peter Kasting <pkasting@google.com>
-2008-08-11 Adam Roben <aroben@apple.com>
+ Reviewed by Xan Lopez.
- Windows build fix
+ https://bugs.webkit.org/show_bug.cgi?id=26447
+ Fix animated GIF breakage in Cairo/wx ports.
- * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
- JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
- too.
+ * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::operator=):
+ * platform/image-decoders/wx/ImageDecoderWx.cpp:
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::operator=):
-2008-08-11 Dan Bernstein <mitz@apple.com>
+2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>
- Reviewed by Darin Adler.
+ Reviewed by John Sullivan
+
+ <rdar://problem/6937882>
+
+ Tweak "time remaining" and "time elapsed" fields in the overlay video controller.
- - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
-
- Test: fast/css/counters/invalidate-cached-counter-node.html
-
- * rendering/RenderContainer.cpp:
- (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
- RenderCounters in :before and :after content.
- * rendering/RenderContainer.h:
- * rendering/RenderCounter.cpp:
- (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
- to match the RenderObject method.
- (WebCore::RenderCounter::invalidate): Added. Resets the cached
- CounterNode and invalidates the object's layout and preferred widths.
- (WebCore::destroyCounterNodeChildren): Added a call to
- invalidateCounters().
- * rendering/RenderCounter.h:
- * rendering/RenderObject.h:
- (WebCore::RenderObject::invalidateCounters):
+ * css/mediaControlsQT.css:
-2008-08-11 Dean Jackson <dino@apple.com>
+2009-06-16 Jian Li <jianli@chromium.org>
- Implement CSS Animation and Transition Events
- https://bugs.webkit.org/show_bug.cgi?id=20337
+ Reviewed by Adam Barth and David Levin.
- Implement the events defined in the CSS Animations
- and Transitions specifications so code can react
- to animations and transitions.
+ Bug 26146: Change to use ThreadableLoader to load the worker script
+ in order to check URL origin for redirection.
+ https://bugs.webkit.org/show_bug.cgi?id=26146
- Reviewed by Tim Hatcher and Dave Hyatt.
+ Test: http/tests/workers/worker-redirect.html
- * DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- * WebCoreSources.bkl:
- Build configs for new files
+ * workers/Worker.cpp:
+ (WebCore::Worker::Worker):
+ (WebCore::Worker::notifyFinished):
+ * workers/Worker.h:
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::importScripts):
+ * workers/WorkerImportScriptsClient.cpp: Removed.
+ * workers/WorkerImportScriptsClient.h: Removed.
+ * workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp.
+ This to make it more generic so worker script loading could use it.
+ (WebCore::WorkerScriptLoader::loadSynchronously):
+ (WebCore::WorkerScriptLoader::loadAsynchronously):
+ (WebCore::WorkerScriptLoader::didFinishLoading):
+ (WebCore::WorkerScriptLoader::didFail):
+ (WebCore::WorkerScriptLoader::didFailRedirectCheck):
+ (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
+ (WebCore::WorkerScriptLoader::notifyFinished):
+ * workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h.
+ This to make it more generic so worker script loading could use it.
+ * workers/WorkerScriptLoaderClient.h: Added.
- * bindings/js/JSDOMWindowBase.cpp:
- * bindings/js/JSDOMWindowBase.h:
- * bindings/js/JSEventCustom.cpp:
- * dom/Document.h:
- * dom/Event.cpp:
- * dom/Event.h:
- * dom/EventTarget.cpp:
- * dom/EventTargetNode.cpp:
- * dom/EventTargetNode.h:
- * html/HTMLElement.cpp:
- * page/AnimationController.cpp:
- do all the new event stuff
+2009-06-16 Brent Fulgham <bfulgham@gmail.com>
- * html/HTMLAttributeNames.in:
- the onwebkitanimation* and onwebkittransitionend attrs
+ Reviewed by Darin Adler.
- * dom/WebKitAnimationEvent.cpp: Added.
- * dom/WebKitAnimationEvent.h: Added.
- * dom/WebKitAnimationEvent.idl: Added.
- * dom/WebKitTransitionEvent.cpp: Added.
- * dom/WebKitTransitionEvent.h: Added.
- * dom/WebKitTransitionEvent.idl: Added.
- New files for the events
+ Use consistent GUID comparison functions.
+ https://bugs.webkit.org/show_bug.cgi?id=26427
- * manual-tests/transition-events.html: Added.
- New testfile
+ * platform/win/WCDataObject.cpp:
+ (WebCore::WCDataObject::QueryInterface):
-2008-08-11 Adam Roben <aroben@apple.com>
+2009-06-16 Xan Lopez <xlopez@igalia.com>
- Add a ForwardingHeader for wtf/NotFound.h
+ Reviewed by Gustavo Noronha.
- Rubberstamped by Darin Adler.
+ Fix compiler warning.
- * ForwardingHeaders/wtf/NotFound.h: Added.
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_class_init):
-2008-08-11 Timothy Hatcher <timothy@apple.com>
+2009-06-16 Xan Lopez <xlopez@igalia.com>
- Fixes a bug where error bubbles in JavaScript resources would
- be clobbered by the syntax highlighter.
+ Reviewed by Gustavo Noronha.
- https://bugs.webkit.org/show_bug.cgi?id=20345
+ Remove dummy AtkStreamableContent implementation.
- Reviewed by Adam Roben.
+ It's completely empty, we'll add it back (and conditionally
+ instead of unconditionally) when it does something.
- * manual-tests/inspector/resources/script-error.js: Added.
- * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
- * page/inspector/SourceFrame.js:
- (WebInspector.SourceFrame.prototype._addMessageToSource):
- Check the nodeType and not the nodeName, this is less fragile.
- (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
- Check if the lastChild is an error bubble, if so remove it before
- getting the line's textContent. Add the error bubble back at the end.
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (GetAtkInterfaceTypeFromWAIType):
+ (getInterfaceMaskFromObject):
-== Rolled over to ChangeLog-2008-08-10 ==
+== Rolled over to ChangeLog-2009-06-16 ==
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog-2006-12-31 b/src/3rdparty/webkit/WebCore/ChangeLog-2006-12-31
index b2a350e..804ca3f 100644
--- a/src/3rdparty/webkit/WebCore/ChangeLog-2006-12-31
+++ b/src/3rdparty/webkit/WebCore/ChangeLog-2006-12-31
@@ -6304,7 +6304,7 @@
* config.h:
-2006-12-08 Peter Kasting <pkasting@chromium.org>
+2006-12-08 Peter Kasting <pkasting@google.com>
Reviewed and landed by Alexey.
@@ -6577,7 +6577,7 @@
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::setIsAutoRepeat):
-2006-12-07 Peter Kasting <pkasting@chromium.org>
+2006-12-07 Peter Kasting <pkasting@google.com>
Reviewed by Darin.
@@ -7421,7 +7421,7 @@
Fix obvious-in-retrospect copy and paste error -- call
passMouseDownEventToWidget instead of passWheelEventToWidget.
-2006-12-04 Peter Kasting <pkasting@chromium.org>
+2006-12-04 Peter Kasting <pkasting@google.com>
Reviewed and landed by Alexey.
@@ -7468,7 +7468,7 @@
(WebCore::FrameLoader::createFrame):
(WebCore::FrameLoaderClientWin::setTitle):
-2006-12-04 Peter Kasting <pkasting@chromium.org>
+2006-12-04 Peter Kasting <pkasting@google.com>
Reviewed by Mitz.
@@ -7970,7 +7970,7 @@
now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately
instead of trying to interweave the spelling and grammar logic
-2006-12-01 Peter Kasting <pkasting@chromium.org>
+2006-12-01 Peter Kasting <pkasting@google.com>
Reviewed by Mitz.
@@ -9946,7 +9946,7 @@
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor):
-2006-11-18 Peter Kasting <pkasting@chromium.org>
+2006-11-18 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
@@ -10415,7 +10415,7 @@
(WebCore::createMarkup):
Add null-checks for the frame, it might not exist for all documents.
-2006-11-16 Peter Kasting <pkasting@chromium.org>
+2006-11-16 Peter Kasting <pkasting@google.com>
Reviewed and landed by ap.
@@ -24148,7 +24148,7 @@ t2006-10-29 Darin Adler <darin@apple.com>
* ksvg2/svg/SVGPathSegMovetoAbs.idl:
* ksvg2/svg/SVGPathSegMovetoRel.idl:
-2006-10-09 Peter Kasting <pkasting@chromium.org>
+2006-10-09 Peter Kasting <pkasting@google.com>
Unreviewed build fix.
@@ -25062,7 +25062,7 @@ t2006-10-29 Darin Adler <darin@apple.com>
(WebCore::Frame::stopAutoscrollTimer):
* page/Frame.h:
-2006-10-05 Peter Kasting <pkasting@chromium.org>
+2006-10-05 Peter Kasting <pkasting@google.com>
Reviewed by Eric.
@@ -25284,7 +25284,7 @@ t2006-10-29 Darin Adler <darin@apple.com>
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
-2006-10-05 Peter Kasting <pkasting@chromium.org>
+2006-10-05 Peter Kasting <pkasting@google.com>
Reviewed by Darin, landed by Adam.
@@ -25416,7 +25416,7 @@ t2006-10-29 Darin Adler <darin@apple.com>
(WebCore::RenderObject::NodeInfo::scrollbar):
(WebCore::RenderObject::NodeInfo::setScrollbar):
-2006-10-05 Peter Kasting <pkasting@chromium.org>
+2006-10-05 Peter Kasting <pkasting@google.com>
Reviewed by Adam.
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog-2007-10-14 b/src/3rdparty/webkit/WebCore/ChangeLog-2007-10-14
index 9275e32..018c5b4 100644
--- a/src/3rdparty/webkit/WebCore/ChangeLog-2007-10-14
+++ b/src/3rdparty/webkit/WebCore/ChangeLog-2007-10-14
@@ -9453,7 +9453,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
(WebCore::ArrayImpl::operator==):
Fixed typo so that correct variable is used in equality comparison.
-2007-08-29 Peter Kasting <zerodpx@gmail.com>
+2007-08-29 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -9469,7 +9469,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
-2007-08-29 Peter Kasting <zerodpx@gmail.com>
+2007-08-29 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -9485,7 +9485,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
-2007-08-29 Peter Kasting <zerodpx@gmail.com>
+2007-08-29 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -9793,7 +9793,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
Only restricts hit testing if the placeholder text is visible.
* rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added.
-2007-08-25 Peter Kasting <zerodpx@gmail.org>
+2007-08-25 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
@@ -10975,7 +10975,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
(WebCore::StyleRareInheritedData::operator==):
(WebCore::RenderStyle::diff):
-2007-08-15 Peter Kasting <zerodpx@gmail.org>
+2007-08-15 Peter Kasting <pkasting@google.com>
Reviewed by Darin.
@@ -15750,7 +15750,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
<script> quirk in cases where the / appears in a mangled attribtue
value.
-2007-07-17 Peter Kasting <zerodpx@gmail.com>
+2007-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Hyatt.
@@ -43567,7 +43567,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
(WebCore::RenderObject::verticalPositionHint):
(WebCore::RenderObject::firstLineStyle):
-2007-04-20 Peter Kasting <pkasting@chromium.org>
+2007-04-20 Peter Kasting <pkasting@google.com>
Reviewed by Oliver.
@@ -60245,7 +60245,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
non-obvious side-effect of setting the focused frame.
* WebCore.xcodeproj/project.pbxproj: Version wars.
-2007-01-27 Peter Kasting <pkasting@chromium.org>
+2007-01-27 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -69463,7 +69463,7 @@ a2007-08-31 Darin Adler <darin@apple.com>
(WebCore::contextMenuItemTagRightToLeft):
Added missing stubs.
-2007-01-04 Peter Kasting <pkasting@chromium.org>
+2007-01-04 Peter Kasting <pkasting@google.com>
Reviewed by Alexey.
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog-2008-08-10 b/src/3rdparty/webkit/WebCore/ChangeLog-2008-08-10
index a47ebab..92cbc3f 100644
--- a/src/3rdparty/webkit/WebCore/ChangeLog-2008-08-10
+++ b/src/3rdparty/webkit/WebCore/ChangeLog-2008-08-10
@@ -16230,7 +16230,7 @@
(WebCore::TextResourceDecoder::checkForHeadCharset): Correct the length passed to
findIgnoringCase().
-2008-05-29 Peter Kasting <zerodpx@gmail.com>
+2008-05-29 Peter Kasting <pkasting@google.com>
Reviewed by Dave Hyatt.
@@ -63513,7 +63513,7 @@ element is when the element reports itself to the screen reader. So all of these
directories to the plugin paths.
(WebCore::PluginDatabaseWin::defaultPluginPaths):
-2007-12-20 Peter Kasting <zerodpx@gmail.com>
+2007-12-20 Peter Kasting <pkasting@google.com>
Reviewed by Alp Toker.
@@ -71115,7 +71115,7 @@ element is when the element reports itself to the screen reader. So all of these
width among columns, skip those whose effective (rather than
specified) width is auto and contain only empty cells.
-2007-11-28 Peter Kasting <zerodpx@gmail.com>
+2007-11-28 Peter Kasting <pkasting@google.com>
Reviewed by Alp Toker.
@@ -71349,7 +71349,7 @@ element is when the element reports itself to the screen reader. So all of these
(WebCore::DatabaseTracker::defaultOriginQuota):
* storage/DatabaseTracker.h:
-2007-11-26 Peter Kasting <zerodpx@gmail.com>
+2007-11-26 Peter Kasting <pkasting@google.com>
Reviewed by Alp Toker.
@@ -72529,7 +72529,7 @@ element is when the element reports itself to the screen reader. So all of these
(WebCore::XMLHttpRequest::getResponseXML):
* xml/XMLHttpRequest.h:
-2007-11-19 Peter Kasting <zerodpx@gmail.com>
+2007-11-19 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
@@ -74725,7 +74725,7 @@ element is when the element reports itself to the screen reader. So all of these
(WebCore::ContextMenu::appendItem):
(WebCore::ContextMenu::itemCount):
-2007-11-09 Peter Kasting <zerodpx@gmail.com>
+2007-11-09 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
@@ -76617,7 +76617,7 @@ element is when the element reports itself to the screen reader. So all of these
* platform/network/ResourceResponse.cpp:
(WebCore::ResourceResponse::isAttachment):
-2007-11-01 Peter Kasting <zerodpx@gmail.com>
+2007-11-01 Peter Kasting <pkasting@google.com>
Reviewed by Dave Hyatt.
@@ -82084,7 +82084,7 @@ element is when the element reports itself to the screen reader. So all of these
(WebCore::renderSubtreeToImage):
* rendering/SVGRenderSupport.h:
-2007-10-14 Peter Kasting <zerodpx@gmail.com>
+2007-10-14 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -82180,7 +82180,7 @@ element is when the element reports itself to the screen reader. So all of these
not added into generated after content. Also made adding a child before
a table caption work correctly instead of adding the child after the caption.
-2007-10-14 Peter Kasting <zerodpx@gmail.com>
+2007-10-14 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
@@ -82191,7 +82191,7 @@ element is when the element reports itself to the screen reader. So all of these
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
-2007-10-14 Peter Kasting <zerodpx@gmail.com>
+2007-10-14 Peter Kasting <pkasting@google.com>
Reviewed by Maciej.
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog-2009-06-16 b/src/3rdparty/webkit/WebCore/ChangeLog-2009-06-16
new file mode 100644
index 0000000..1041c90
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/ChangeLog-2009-06-16
@@ -0,0 +1,97559 @@
+2009-06-15 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
+
+ * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
+ When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
+
+2009-06-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove outdated comment.
+
+ * bindings/js/JSDOMWindowBase.h:
+
+2009-06-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Bring CustomGetPropertyNames more inline with the other
+ extended attributes prefixed with Custom, by making it
+ require a complete implementation.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::getPropertyNames):
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::JSHistory::getPropertyNames):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::getPropertyNames):
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::getPropertyNames):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-06-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove commented out ondataunavailable attribute event listener which
+ has now been removed from HTML 5.
+
+ * page/DOMWindow.idl:
+
+2009-06-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Move entire custom implementation of getOwnPropertySlot and put
+ for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
+ JSDOMWindowBase.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::nonCachingStaticFunctionGetter):
+ (WebCore::childFrameGetter):
+ (WebCore::indexGetter):
+ (WebCore::namedItemGetter):
+ (WebCore::JSDOMWindow::getOwnPropertySlot):
+ (WebCore::JSDOMWindow::put):
+ (WebCore::JSDOMWindow::getPropertyAttributes):
+ * bindings/js/JSDOMWindowCustom.h:
+ * page/DOMWindow.idl:
+
+2009-06-15 Jeremy Orlow (jorlow@chromium.org)
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26356
+ Define the functions in V8CustomBindings.h. "Forgot" this in my
+ earlier patch since it wasn't fully upstreamed when I wrote the
+ patch.
+
+ * bindings/v8/custom/V8CustomBinding.h:
+
+2009-06-15 Andre Boule <aboule@apple.com>
+
+ Reviewed by Cameron Zwarich and Dan Bernstein.
+
+ - fix <rdar://problem/6967975> crash with NSString drawAtPoint
+
+ No test possible because this crash can only occur if the client uses
+ WebKit text drawing without ever using WebCore text, and DumpRenderTree
+ cannot do either.
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::purgeInactiveFontData): Null-check
+ gFontPlatformDataCache.
+
+2009-06-15 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6974857>
+
+ Define ENABLE_3D_RENDERING when building on 10.6, and move ENABLE_3D_RENDERING
+ switch from config.h to wtf/Platform.h.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * config.h:
+
+2009-06-15 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Make WebInspector's console evaluation/completion asynchronous.
+ This way of evaluation allows serializing calls between
+ InspectorController and its frontend.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26350
+
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype.completions):
+ (WebInspector.Console.prototype._reportCompletions):
+ (WebInspector.Console.prototype._evalInInspectedWindow):
+ (WebInspector.Console.prototype._enterKeyPressed.printResult):
+ (WebInspector.Console.prototype._enterKeyPressed):
+ * inspector/front-end/DatabaseQueryView.js:
+ * inspector/front-end/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt.prototype.complete):
+ (WebInspector.TextPrompt.prototype._completionsReady):
+
+2009-06-15 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Reverted previous change as the old behavior was correct for heavy view.
+
+ * inspector/front-end/BottomUpProfileDataGridTree.js:
+ (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
+
+2009-06-15 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ <rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
+ view (26418)
+
+ - Removed code that copied call and time data from it's ancestor.
+
+ * inspector/front-end/BottomUpProfileDataGridTree.js:
+ (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
+
+2009-06-15 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser <simon.fraser@apple.com>.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26163
+
+ Added logic to updateTransitions similar to that in updateKeyframeAnimations
+ which detects and removes stale transitions.
+
+ Test: transitions/cancel-transition.html
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::ImplicitAnimation):
+ * page/animation/ImplicitAnimation.h:
+ (WebCore::ImplicitAnimation::active):
+ (WebCore::ImplicitAnimation::setActive):
+
+2009-06-15 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ - allow the source code font in the Web Inspector to be customized
+
+ * css/view-source.css: Use the default monospace font family and size
+ for source code.
+ * inspector/front-end/inspector.css: Use the default monospace font
+ family and size for console I/O.
+
+2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by and done with Tor Arne Vestbø.
+
+ Fix initialization of uninitialized members in FontFallbackListQt, leading
+ to random crashes when rendering text.
+
+ * platform/graphics/qt/FontFallbackListQt.cpp:
+ (WebCore::FontFallbackList::FontFallbackList):
+ (WebCore::FontFallbackList::invalidate):
+
+2009-06-15 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25895
+ [Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
+
+ Use computeOffsetInContainerNode instead of the inline
+ offsetInContainerNode to return the caret offset, since the former
+ can handle all types of anchoring. Otherwise we'll hit an ASSERT
+ in some situations in debug builds, and crash.
+
+ * editing/gtk/SelectionControllerGtk.cpp:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+
+2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix build break
+ Rename JSONObject to InspectorJSONObject
+
+ https://bugs.webkit.org/show_bug.cgi?id=26340
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::addToConsole):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::bind):
+ * inspector/InspectorDatabaseResource.cpp:
+ (WebCore::InspectorDatabaseResource::bind):
+ * inspector/InspectorFrontend.cpp:
+ (WebCore::InspectorFrontend::newInspectorJSONObject):
+ (WebCore::InspectorFrontend::addMessageToConsole):
+ (WebCore::InspectorFrontend::addResource):
+ (WebCore::InspectorFrontend::updateResource):
+ (WebCore::InspectorFrontend::addDatabase):
+ (WebCore::InspectorFrontend::addDOMStorage):
+ * inspector/InspectorFrontend.h:
+ * inspector/InspectorJSONObject.cpp: Copied from WebCore/inspector/JSONObject.cpp.
+ (WebCore::InspectorJSONObject::InspectorJSONObject):
+ (WebCore::InspectorJSONObject::set):
+ (WebCore::InspectorJSONObject::scriptObject):
+ (WebCore::InspectorJSONObject::createNew):
+ * inspector/InspectorJSONObject.h: Copied from WebCore/inspector/JSONObject.h.
+ * inspector/InspectorResource.cpp:
+ (WebCore::populateHeadersObject):
+ (WebCore::InspectorResource::createScriptObject):
+ (WebCore::InspectorResource::updateScriptObject):
+ * inspector/JSONObject.cpp: Removed.
+ * inspector/JSONObject.h: Removed.
+
+2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Refactor handling of options in the build-webkit script
+
+ Options are now defined in one place, and then reused when creating
+ the usage help text, the arguments to GetOptions(), and when passing
+ the options on to the underlying port-dependent build systems.
+
+ This allows the Qt port to read the defaults for the options from the
+ pro file (dynamically), and to pass the options on to qmake at build.
+
+ * WebCore.pro:
+
+2009-06-14 chris fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 26399: REGRESSION: java applet accessibility broken
+ https://bugs.webkit.org/show_bug.cgi?id=26399
+
+ Accessibility could not access the elements in a java applet
+ when going down the AX hierarchy.
+
+ Test: DRT does not allow java applets so add a manual test:
+ manual-tests/accessibility/java-applet.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ * accessibility/mac/AccessibilityObjectMac.mm:
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ * accessibility/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper attachmentView]):
+ * manual-tests/accessibility: Added.
+ * manual-tests/accessibility/java-applet.html: Added.
+ * manual-tests/accessibility/resources: Added.
+ * manual-tests/accessibility/resources/AppletTest.class: Added.
+ * manual-tests/accessibility/resources/AppletTest.java: Added.
+ (AppletTest):
+ (AppletTest.init):
+
+2009-06-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
+ to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
+ their functionality (customGetOwnPropertySlot and customPut member functions have
+ been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
+ and CustomPutFunction have been repurposed to mean a complete custom implementation
+ of the function which is inline with other extended attributes prefixed with Custom.
+
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::putDelegate):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::getOwnPropertySlotDelegate):
+ (WebCore::JSDOMWindow::putDelegate):
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
+ (WebCore::JSHTMLAppletElement::putDelegate):
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
+ (WebCore::JSHTMLEmbedElement::putDelegate):
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
+ (WebCore::JSHTMLObjectElement::putDelegate):
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::JSHistory::getOwnPropertySlotDelegate):
+ (WebCore::JSHistory::putDelegate):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::getOwnPropertySlotDelegate):
+ (WebCore::JSLocation::putDelegate):
+ (WebCore::JSLocationPrototype::putDelegate):
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::putDelegate):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * css/CSSStyleDeclaration.idl:
+ * html/HTMLAppletElement.idl:
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLObjectElement.idl:
+ * page/DOMWindow.idl:
+ * page/History.idl:
+ * page/Location.idl:
+ * storage/Storage.idl:
+ * workers/WorkerContext.idl:
+
+2009-06-14 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=26395
+ <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after
+ going back/forward to page with focused text field
+
+ No test, since the back/forward cache is disabled in DumpRenderTree
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::open): Added a call to CachedPage::restore(),
+ which was removed in r40870.
+
+2009-06-14 Darin Adler <darin@apple.com>
+
+ * editing/TextIterator.cpp:
+ (WebCore::BitStack::push): Use named constant instead of hardcoded numbers.
+ (WebCore::BitStack::top): Ditto.
+
+2009-06-14 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 26364: Search can find text that's hidden by overflow:hidden
+ https://bugs.webkit.org/show_bug.cgi?id=26364
+ <rdar://problem/6952081>
+
+ Test: fast/text/find-hidden-text.html
+
+ * editing/TextIterator.cpp:
+ (WebCore::BitStack::BitStack): Added.
+ (WebCore::BitStack::push): Added.
+ (WebCore::BitStack::pop): Added.
+ (WebCore::BitStack::top): Added.
+ (WebCore::BitStack::size): Added.
+ (WebCore::parentOrShadowParent): Added. Helper function for walking up
+ the parent node chain, crossing shadow tree boundaries.
+ (WebCore::depthCrossingShadowBoundaries): Added for use in assertions.
+ Counts the depth of a node using the parentOrShadowParent function.
+ (WebCore::fullyClipsContents): Added. Returns true for an element that
+ fully clips its contents, currently defined as a box that has zero width
+ or height and hides overflow. We can add other cases here later.
+ (WebCore::ignoresContainerClip): Added. Returns true for an element that
+ ignores its container clip, currently defined as an element with absolute
+ or fixed positioning.
+ (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating
+ if the node in question fully clips its contents.
+ (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of
+ a node. Used when creating an iterator.
+ (WebCore::TextIterator::TextIterator): Removed code to initialize
+ m_inShadowContent. Call setUpFullyClippedStack.
+ (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving
+ up to a parent node, and also one extra time when moving to a sibling node.
+ Call pushFullyClippedState when moving to a child node, or when moving to a
+ sibling node after the aforementioned call to pop.
+ (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped.
+ (WebCore::TextIterator::handleReplacedElement): Ditto.
+ (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
+ Call setUpFullyClippedStack.
+ (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as
+ TextIterator::advance above.
+
+ * editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both
+ TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
+
+2009-06-14 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26362
+
+ Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
+ Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
+ changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
+
+ * dom/Element.cpp:
+ (WebCore::Element::recalcStyle):
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::setChildIndex):
+
+2009-06-14 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
+ copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
+ inside the FontFallbackList.
+
+ * WebCore.base.exp:
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::Font):
+ (WebCore::Font::operator=):
+ (WebCore::Font::primaryFont):
+ (WebCore::Font::update):
+ * platform/graphics/Font.h:
+ (WebCore::Font::setWordSpacing):
+ (WebCore::Font::setLetterSpacing):
+ * platform/graphics/FontFallbackList.cpp:
+ (WebCore::FontFallbackList::FontFallbackList):
+ (WebCore::FontFallbackList::invalidate):
+ (WebCore::FontFallbackList::determinePitch):
+ * platform/graphics/FontFallbackList.h:
+ (WebCore::FontFallbackList::primarySimpleFontData):
+ (WebCore::FontFallbackList::primaryFontData):
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+
+2009-06-14 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=26362
+
+ Fix an issue noted on quirksmode.com where dynamically adding siblings does not
+ update :nth-child style correctly.
+
+ Test: fast/css/nth-child-dynamic.html
+
+ * dom/Node.h:
+ Change diff() to take const RenderStyle*
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ When comparing styles to decide whether to detach and reattach, we
+ need to look at whether the pseudoclass-related data in the style
+ changed (since RenderStyle::diff doesn't check this).
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::getCachedPseudoStyle):
+ (WebCore::RenderStyle::inheritedNotEqual):
+ Make these methods const.
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::styleType):
+ (WebCore::InheritedFlags::pseudoClassStateEquivalent):
+ Make methods const.
+ Add new method that compares the pseudoclass-related members.
+
+2009-06-13 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Kevin Ollivier.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
+ Write a wx implementation so the wx port can compile. For now this is
+ mostly a copy of the Cairo port, but in the future it can be changed to
+ use a wxBitmap as the storage type everywhere (just as Cairo can
+ probably be changed).
+
+ Also ASSERT for any other ports who call getAddr() (I don't think there
+ are any, and besides, they probably won't link, but this doesn't hurt).
+
+ Also fixes a dumb Cairo build bustage typo introduced in part ten.
+
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::createFrameAtIndex):
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::getAddr):
+ * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
+ (WebCore::RGBA32Buffer::setStatus):
+ * platform/image-decoders/wx: Added.
+ * platform/image-decoders/wx/ImageDecoderWx.cpp: Added.
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::zeroFill):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::asNewNativeImage):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ * webcore-wx.bkl:
+
+2009-06-13 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Dimitri Glazkov. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26320
+
+ Some minor code cleanup for chromium/skia port. Removed #ifdef's
+ around skia API changes, since the new version seems solid and we
+ don't need to go back. Added some comments to
+ TransparencyWin.h, as requested by Brett in
+ https://bugs.webkit.org/show_bug.cgi?id=24584.
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::createFontPlatformData):
+ * platform/graphics/chromium/TransparencyWin.h:
+ * platform/graphics/skia/PathSkia.cpp:
+ (WebCore::Path::boundingRect):
+ (WebCore::boundingBoxForCurrentStroke):
+ * platform/graphics/skia/SkiaUtils.cpp:
+ (WebCore::SkPathContainsPoint):
+
+2009-06-13 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24492
+
+ Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
+ FrameLoader to SecurityOrigin.
+
+ * WebCore.base.exp:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadFrameRequest):
+ (WebCore::FrameLoader::canLoad):
+ * loader/FrameLoader.h:
+ * page/SecurityOrigin.cpp:
+ (WebCore::localSchemes):
+ (WebCore::noAccessSchemes):
+ (WebCore::SecurityOrigin::SecurityOrigin):
+ (WebCore::SecurityOrigin::isLocal):
+ (WebCore::SecurityOrigin::registerURLSchemeAsLocal):
+ (WebCore::SecurityOrigin::shouldTreatURLAsLocal):
+ (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
+ (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
+ (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
+ * page/SecurityOrigin.h:
+
+2009-06-13 Ben Murdoch <benm@google.com>
+
+ Reviewed by David Kilzer. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26189
+
+ This patch changes the way PageGroups create their localStorage
+ objects. Rather than creating a local storage object for the page group
+ when a page is added to the group, the local storage object is now
+ created lazily when the local storage object is requested by the
+ DOMWindow.
+
+ * page/PageGroup.cpp:
+ (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created.
+ (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group.
+ (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
+ * page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
+
+
+2009-06-13 Ben Murdoch <benm@google.com>
+
+ Reviewed by Eric Seidel. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26189
+
+ Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
+
+ * storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
+ * storage/LocalStorage.h: Ditto
+ * storage/LocalStorageArea.cpp: Ditto
+ * storage/LocalStorageArea.h: Ditto
+ * storage/LocalStorageTask.cpp: Ditto
+ * storage/LocalStorageTask.h: Ditto
+ * storage/LocalStorageThread.cpp: Ditto
+ * storage/LocalStorageThread.h: Ditto
+ * storage/SessionStorage.cpp: Ditto
+ * storage/SessionStorage.h: Ditto
+ * storage/SessionStorageArea.cpp: Ditto
+ * storage/SessionStorageArea.h: Ditto
+ * storage/Storage.cpp: Ditto
+ * storage/Storage.h: Ditto
+ * storage/StorageArea.cpp: Ditto
+ * storage/StorageArea.h: Ditto
+ * storage/StorageEvent.cpp: Ditto
+ * storage/StorageEvent.h: Ditto
+ * storage/StorageMap.cpp: Ditto
+ * storage/StorageMap.h: Ditto
+ * storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
+ * storage/Storage.idl: Ditto
+
+2009-06-13 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
+ Make Skia use the root directory ImageDecoder.h and factor out most
+ Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
+ style violations in ImageDecoderCairo.cpp. This is the last patch for
+ this bug, everything beyond this is an enhancement rather than
+ unforking.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::getAddr):
+ * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::setStatus):
+ * platform/image-decoders/skia/ImageDecoder.h: Removed.
+ * platform/image-decoders/skia/ImageDecoderSkia.cpp: Added.
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::zeroFill):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::asNewNativeImage):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+
+2009-06-13 Victor Wang <victorw@chromium.org>
+
+ Reviewed by Eric Seidel. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26333
+ Alert during a dragenter event handler will crash the renderer
+
+ This crash is casued by calling NULL pointer m_documentUnderMouse in
+ DragController::tryDocumentDrag()
+
+ tryDHTMLDrag fires dragenter event. The event listener that listens
+ to this event may create a nested message loop (open a modal dialog),
+ which could process dragleave event and reset m_documentUnderMouse in
+ dragExited.
+
+ Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
+ do not continue if the pointer has been set to NULL.
+
+ Test: DRT does not show alerts so add a manual test:
+ manual-tests/drag-enter-alert.html
+
+ * manual-tests/drag-enter-alert.html: Added.
+ * manual-tests/resources/drag-image.png: Added.
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
+
+2009-06-13 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov. Landed by Adam Barth.
+
+ Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26227
+
+ * bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added.
+ (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org.
+ (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org.
+ (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
+ * bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
+ * bindings/v8/custom/V8DocumentCustom.cpp: Updated includes.
+ (WebCore::CALLBACK_FUNC_DECL): Updated class name.
+
+2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Mark Rowe. Landed by Adam Barth.
+
+ Remove obsolete declarations for old Symbian port
+ https://bugs.webkit.org/show_bug.cgi?id=26339
+
+ * platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
+ * platform/graphics/FloatRect.h: Ditto.
+ * platform/graphics/IntPoint.h: Ditto.
+ * platform/graphics/IntRect.h: Ditto.
+ * platform/graphics/IntSize.h: Ditto.
+
+2009-06-13 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Added subRegion calculation to SVG filter. Every filter effect is
+ clipped to the filter region (according to the spec). This makes
+ ImageBuffers for filter effects smaller and we just need to take
+ care about big filter regions.
+ SVGFEImage needed a correction, to avoid an ASSERT. The two filter
+ effects feOffset and feFlood help to test the new subRegion code.
+
+ Tests: svg/filters/subRegion-one-effect.svg
+ svg/filters/subRegion-two-effects.svg
+
+ * platform/graphics/filters/FEBlend.h:
+ (WebCore::FEBlend::uniteChildEffectSubregions):
+ * platform/graphics/filters/FEColorMatrix.h:
+ (WebCore::FEColorMatrix::uniteChildEffectSubregions):
+ * platform/graphics/filters/FEComponentTransfer.h:
+ (WebCore::FEComponentTransfer::uniteChildEffectSubregions):
+ * platform/graphics/filters/FEComposite.h:
+ (WebCore::FEComposite::uniteChildEffectSubregions):
+ * platform/graphics/filters/Filter.h:
+ (WebCore::Filter::setSourceImage):
+ (WebCore::Filter::sourceImage):
+ * platform/graphics/filters/FilterEffect.cpp:
+ (WebCore::FilterEffect::FilterEffect):
+ (WebCore::FilterEffect::calculateUnionOfChildEffectSubregions):
+ (WebCore::FilterEffect::calculateEffectRect):
+ * platform/graphics/filters/FilterEffect.h:
+ (WebCore::FilterEffect::setUnionOfChildEffectSubregions):
+ (WebCore::FilterEffect::unionOfChildEffectSubregions):
+ (WebCore::FilterEffect::hasX):
+ (WebCore::FilterEffect::setHasX):
+ (WebCore::FilterEffect::hasY):
+ (WebCore::FilterEffect::setHasY):
+ (WebCore::FilterEffect::hasWidth):
+ (WebCore::FilterEffect::setHasWidth):
+ (WebCore::FilterEffect::hasHeight):
+ (WebCore::FilterEffect::setHasHeight):
+ (WebCore::FilterEffect::setEffectBuffer):
+ (WebCore::FilterEffect::uniteChildEffectSubregions):
+ * platform/graphics/filters/SourceAlpha.h:
+ (WebCore::SourceAlpha::calculateEffectRect):
+ * platform/graphics/filters/SourceGraphic.cpp:
+ (WebCore::SourceGraphic::calculateEffectRect):
+ (WebCore::SourceGraphic::apply):
+ * platform/graphics/filters/SourceGraphic.h:
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::prepareToRenderSVGContent):
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ * svg/SVGFilterPrimitiveStandardAttributes.cpp:
+ (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
+ * svg/graphics/SVGResourceFilter.cpp:
+ (WebCore::SVGResourceFilter::prepareFilter):
+ (WebCore::SVGResourceFilter::applyFilter):
+ * svg/graphics/SVGResourceFilter.h:
+ * svg/graphics/filters/SVGFEConvolveMatrix.h:
+ (WebCore::FEConvolveMatrix::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFEDiffuseLighting.h:
+ (WebCore::FEDiffuseLighting::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFEDisplacementMap.h:
+ (WebCore::FEDisplacementMap::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::apply):
+ * svg/graphics/filters/SVGFEGaussianBlur.h:
+ (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFEImage.cpp:
+ (WebCore::FEImage::FEImage):
+ * svg/graphics/filters/SVGFEImage.h:
+ * svg/graphics/filters/SVGFEMerge.cpp:
+ (WebCore::FEMerge::uniteEffectRect):
+ * svg/graphics/filters/SVGFEMerge.h:
+ * svg/graphics/filters/SVGFEMorphology.h:
+ (WebCore::FEMorphology::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ (WebCore::FEOffset::apply):
+ * svg/graphics/filters/SVGFEOffset.h:
+ (WebCore::FEOffset::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFESpecularLighting.h:
+ (WebCore::FESpecularLighting::uniteEffectRect):
+ * svg/graphics/filters/SVGFETile.cpp:
+ (WebCore::FETile::uniteChildEffectSubregions):
+ * svg/graphics/filters/SVGFETile.h:
+ * svg/graphics/filters/SVGFilter.cpp:
+ (WebCore::SVGFilter::calculateEffectSubRegion):
+ * svg/graphics/filters/SVGFilter.h:
+ (WebCore::SVGFilter::effectBoundingBoxMode):
+ (WebCore::SVGFilter::filterRegion):
+ (WebCore::SVGFilter::sourceImageRect):
+
+2009-06-13 Peter Kasting <pkasting@google.com>
+
+ Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::copyRowNTimes):
+ * platform/image-decoders/bmp/BMPImageReader.cpp:
+ (WebCore::BMPImageReader::processBitmasks):
+
+2009-06-13 Peter Kasting <pkasting@google.com>
+
+ GTK bustage fix. "inline" is handled differently by different compilers.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::getAddr):
+ * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
+
+2009-06-13 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
+ Factor Cairo-specific implementation out of ImageDecoder.h into
+ ImageDecoderCairo.cpp. Add some comments to functions declared
+ in ImageDecoder.h.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/image-decoders/ImageDecoder.h:
+ * platform/image-decoders/cairo: Added.
+ * platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added.
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::zeroFill):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::asNewNativeImage):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::getAddr):
+
+2009-06-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
+ assertion removal and some unintentional whitespace changes.
+
+ * platform/text/BidiResolver.h:
+ (WebCore::MidpointState::reset):
+ * rendering/RenderBlock.h:
+ * rendering/bidi.cpp:
+ (WebCore::BidiRun::operator delete):
+ (WebCore::chopMidpointsAt):
+ (WebCore::checkMidpoints):
+ (WebCore::addMidpoint):
+ (WebCore::appendRunsForObject):
+ (WebCore::RenderBlock::findNextLineBreak):
+
+2009-06-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26367
+
+ Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
+ midpoint information. Add the remaining global variables as arguments passed down through functions
+ as needed.
+
+ * platform/text/BidiResolver.h:
+ (WebCore::MidpointState::MidpointState):
+ (WebCore::MidpointState::reset):
+ (WebCore::BidiResolver::midpointState):
+ * rendering/RenderBlock.h:
+ * rendering/bidi.cpp:
+ (WebCore::BidiRun::operator delete):
+ (WebCore::chopMidpointsAt):
+ (WebCore::checkMidpoints):
+ (WebCore::addMidpoint):
+ (WebCore::appendRunsForObject):
+ (WebCore::RenderBlock::bidiReorderLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::determineStartPosition):
+ (WebCore::skipNonBreakingSpace):
+ (WebCore::shouldCollapseWhiteSpace):
+ (WebCore::requiresLineBox):
+ (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::shouldSkipWhitespaceAfterStartObject):
+ (WebCore::RenderBlock::findNextLineBreak):
+
+2009-06-12 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix for Qt. After recent ImageDeocder.h changes. I want
+ the original change to be backed out as the whole Skia merging
+ is going in the wrong direction. The discussion will happen in
+ the bugtracker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709.
+
+ * platform/image-decoders/ImageDecoder.h:
+
+2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix: include cstdio so we can use sscanf
+
+ Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
+ Suggested by Brent Fulgham
+
+ * platform/image-decoders/xbm/XBMImageDecoder.cpp:
+ (WebCore::XBMImageDecoder::decodeDatum):
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Yet another Skia bustage fix.
+
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Fix remaining Cairo build bustage from
+ https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
+ Vector<char> in place of std::string.
+
+ * platform/image-decoders/xbm/XBMImageDecoder.cpp:
+ (WebCore::XBMImageDecoder::setData):
+ (WebCore::XBMImageDecoder::decodeHeader):
+ (WebCore::XBMImageDecoder::decodeDatum):
+ * platform/image-decoders/xbm/XBMImageDecoder.h:
+
+2009-06-12 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ UString shouldn't create sharedBuffer for SmallStrings.
+ https://bugs.webkit.org/show_bug.cgi?id=26347
+
+ Change the call to use the method UString::Rep::sharedBuffer due
+ to changes in UString.
+
+ No noticable change in behavior, so no test.
+
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::create):
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Fix Chromium and some of Cairo build bustage, fallout from
+ https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
+
+ * WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
+
+2009-06-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=26095
+
+ Fix crash when a renderer for an anonymous node is composited
+ by null-checking renderer()->node().
+
+ Test: compositing/generated-content.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::createGraphicsLayer):
+ (WebCore::RenderLayerBacking::rendererHasBackground):
+ (WebCore::RenderLayerBacking::rendererBackgroundColor):
+ (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+
+2009-06-12 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is defined.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::attachRootGraphicsLayer):
+ (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
+ (WebCore::EmptyChromeClient::scheduleViewUpdate):
+ Add stubs for the compositing-related ChromeClient methods.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateRootLayerPosition):
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
+ docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
+ matches what is used to size the WebHTMLView.
+
+2009-06-12 jorlow <jorlow@chromium.org>
+
+ Reviewed by David Levin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26356
+ http://crbug.com/14006
+ Create custom bindings for v8. The rest of these files are still
+ forked (so the review is happening on the chromium review site).
+ These bindings have been tested on a hacked up Chromium instance
+ (also running --single-process) and Android.
+
+ * bindings/v8/custom/V8StorageCustom.cpp: Added.
+
+2009-06-12 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by David Levin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26359
+ [v8] Add XMLHttpRequest to WorkerContextExecutionProxy.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types.
+ (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
+ * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
+ Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
+ all the decoders from skia/ since they are now just mirrors of the Cairo
+ ones.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
+ * platform/graphics/skia/ImageSourceSkia.cpp:
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
+ * platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
+ * platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
+ * platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
+ * platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
+ * platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
+ * platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
+ * platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/BMPImageDecoder.h: Removed.
+ * platform/image-decoders/skia/BMPImageReader.cpp: Removed.
+ * platform/image-decoders/skia/BMPImageReader.h: Removed.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/GIFImageDecoder.h: Removed.
+ * platform/image-decoders/skia/GIFImageReader.cpp: Removed.
+ * platform/image-decoders/skia/GIFImageReader.h: Removed.
+ * platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/ICOImageDecoder.h: Removed.
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
+ * platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/PNGImageDecoder.h: Removed.
+ * platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
+ * platform/image-decoders/skia/XBMImageDecoder.h: Removed.
+ * platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
+ * platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
+
+2009-06-11 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
+ Update Skia's ImageDecoder.h with a few changes designed to reduce the
+ delta between specific implementations of ImageDecoder.h. Update
+ Cairo's ImageDecoder.h to sync up with the API changes in the Skia
+ version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
+ decoders to use the APIs as well. All the Cairo image decoder changes
+ are direct copies of the Skia versions except ImageDecoder.h, which is
+ modified in the necessary ways for the differences between Cairo and
+ Skia.
+
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
+ * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
+ (WebCore::RGBA32Buffer::):
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::zeroFill):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::copyRowNTimes):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::asNewNativeImage):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::disposalMethod):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setDisposalMethod):
+ (WebCore::RGBA32Buffer::setRGBA):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::getAddr):
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
+ (WebCore::GIFImageDecoder::initFrameBuffer):
+ (WebCore::GIFImageDecoder::haveDecodedRow):
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
+ (WebCore::JPEGImageDecoder::outputScanlines):
+ * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
+ (WebCore::PNGImageDecoder::rowAvailable):
+ * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
+ (WebCore::RGBA32Buffer::):
+ (WebCore::RGBA32Buffer::copyRowNTimes):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::asNewNativeImage):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::disposalMethod):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::setDisposalMethod):
+ (WebCore::RGBA32Buffer::setRGBA):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::getAddr):
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
+
+2009-06-12 Brent Fulgham <bfulgham@webkit.org>
+
+ Unreviewed build correction.
+
+ Revert accidental configuration checkin. Was not meant to
+ be part of the last changeset.
+
+ * config.h:
+
+2009-06-12 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26353
+ Corrects handling of Cairo fonts that were getting out of
+ sync due to default copy construction. Also refactors
+ some incorrect platform font destruction code that belongs
+ in the font object's destructor.
+
+ * platform/graphics/win/FontPlatformData.h:
+ * platform/graphics/win/FontPlatformDataCGWin.cpp:
+ (WebCore::FontPlatformData::~FontPlatformData):
+ * platform/graphics/win/FontPlatformDataCairoWin.cpp:
+ (WebCore::FontPlatformData::platformDataInit):
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::setFont):
+ (WebCore::FontPlatformData::~FontPlatformData):
+ * platform/graphics/win/FontPlatformDataWin.cpp:
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+
+2009-06-12 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ * ChangeLog-2007-10-14: Update my email address.
+ * ChangeLog-2008-08-10: Update my email address.
+
+2009-06-12 Nate Chapin <japhet@google.com>
+
+ Reviewed by David Levin.
+
+ Upstream V8Helpers.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26332
+
+ * bindings/v8/V8Helpers.cpp: Added.
+ (wrapNPObject): Moved from v8_helpers.cpp.
+ (toV8Context): Moved from v8_helpers.cpp.
+ (toV8Proxy): Moved from v8_helpers.cpp.
+ * bindings/v8/V8Helpers.h: Added.
+
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+
+2009-06-12 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25609
+ [GTK] Implement support for get_selection and get_n_selections
+
+ Only use the VisibleSelection object if it actually belongs to the
+ object we are using.
+
+ This is pretty hacky-ish, but I can't seem to find a direct API to
+ get the VisibleSelection for a given object, only the global one.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (selectionBelongsToObject):
+ (webkit_accessible_text_get_n_selections):
+ (webkit_accessible_text_get_selection):
+
+2009-06-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Crash at Node::nodeIndex()
+ https://bugs.webkit.org/show_bug.cgi?id=26044
+
+ This crash seems to be caused by calling nodeIndex() on
+ and invalid Node pointer. As far as I can tell, the most likely
+ explanation is that the Range holding the node is actually
+ deleted already (thus the memory is junk). Looking at the code
+ Range changes m_start.container() in its destructor to tell if
+ the range is detached or not. If somehow m_start.container() was
+ cleared, the range will never be detached and the Document will end
+ up with pointers to deleted ranges. I don't know how to reproduce this
+ any reproduction I could think of would hit ASSERTS in Debug mode.
+ One reproduction I tried, did not crash in Release mode, even though it
+ did in Debug mode.
+
+ I'm making a speculative fix by always detaching the Range from the document
+ during ~Range. This is safer, and all we lose is an ASSERT to prevent double-detach.
+
+ Another solution would be to instead store an m_attached bool on the Range object, or
+ expose a Document::isRangeAttached(range) call. Either of those solutions
+ could affect performance, so I went with this solution for now.
+
+ I also removed the RangeBoundaryPoint default constructor
+ as it is not used anywhere (and is more likely to cause confusion).
+
+ Since I can't reproduce the crash, no test.
+
+ * dom/Document.cpp:
+ (WebCore::Document::detachRange):
+ * dom/Range.cpp:
+ (WebCore::Range::~Range):
+ (WebCore::Range::detach):
+ * dom/RangeBoundaryPoint.h:
+ (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
+ RangeBoundaryPoints always have an m_containerNode, ASSERT that.
+ (WebCore::RangeBoundaryPoint::set):
+ ASSERT(container) to match all the other functions.
+ All callers already ASSERT(container). Since we only
+ have reports if this crash from Release mode, I can only
+ assume that those ASSERTs would have been hit in a Debug reproduction.
+
+2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25512
+ Handle texts after unfinished special tags (i.e., script, style, textarea,
+ title, xmp, and iframe) as the text node under the tags in view-source mode.
+ Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.
+
+ This was already done only for title. This change allows other special tags to be handled as well.
+
+ Test: fast/frames/viewsource-unfinished-tags.html
+
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::parseNonHTMLText):
+ (WebCore::HTMLTokenizer::parseTag):
+ (WebCore::HTMLTokenizer::write):
+ * html/HTMLTokenizer.h:
+ (WebCore::HTMLTokenizer::State::inAnyNonHTMLText):
+
+2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26291
+
+ [Qt] build break in ImageDecoderQt.cpp.
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::reset):
+ (WebCore::ImageDecoderQt::setData):
+ (WebCore::ImageDecoderQt::isSizeAvailable):
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::ImageDecoder::setSize):
+
+2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Ariya Hidayat.
+
+ Removed obsolete and unmaintained files from the old Symbian port.
+
+ * platform/symbian/FloatPointSymbian.cpp: Removed.
+ * platform/symbian/FloatRectSymbian.cpp: Removed.
+ * platform/symbian/IntPointSymbian.cpp: Removed.
+ * platform/symbian/IntRectSymbian.cpp: Removed.
+ * platform/symbian/IntSizeSymbian.cpp: Removed.
+ * platform/text/symbian/StringImplSymbian.cpp: Removed.
+ * platform/text/symbian/StringSymbian.cpp: Removed.
+
+2009-06-10 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part six
+ Miscellaneous tiny changes. The important bits here are the ANSI C++
+ compliance fix in skia/ImageDecoders.h (needed to compile this file on
+ non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
+ unit tests partly exposed. Other changes are mostly cosmetic.
+
+ * platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
+ (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
+ * platform/image-decoders/png/PNGImageDecoder.cpp:
+ (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
+ * platform/image-decoders/skia/BMPImageReader.cpp:
+ (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity.
+ (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity.
+ (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0).
+ (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
+ (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
+ * platform/image-decoders/skia/PNGImageDecoder.cpp:
+ (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
+ * platform/image-decoders/skia/XBMImageDecoder.cpp:
+ (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
+
+2009-06-10 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ The shadow node inside empty textareas gets collapsed in disabled
+ textareas. This is a regression from moving the overflow from
+ the shadow node to it's parent. The fix is to return true in
+ RenderBlock::hasLineIfEmpty for textarea shadow nodes as we
+ currently do for input shadow nodes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26296
+
+ Test: fast/forms/empty-textarea-toggle-disabled.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::hasLineIfEmpty):
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25609
+ [GTK] Implement support for get_selection and get_n_selections
+
+ Implement atk_text_get_n_selections.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_text_get_n_selections):
+
+2009-06-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a
+ Google map in iPhoto Places, it drags a map tile instead
+
+ Calling stopLoadRequest() from notifyFinished() removed the
+ ScriptElementData from the CachedScript's client set, which could make
+ it eligible for purging. The fix is to call removeClient() only after
+ executing the script, which protects it from being purged while it is
+ in the document's queue of scripts to execute soon.
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::execute): Call removeClient() here.
+ (WebCore::ScriptElementData::notifyFinished): Instead of calling
+ stopLoadRequest(), which calls removeClient(), just reset
+ m_cachedScript.
+
+2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Mark Rowe and Eric Seidel.
+
+ Update WebInspector localizedStrings.js with new resource tracking strings
+ https://bugs.webkit.org/show_bug.cgi?id=26247
+
+ * English.lproj/localizedStrings.js:
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android specific files.
+ https://bugs.webkit.org/show_bug.cgi?id=26280
+
+ * platform/text/android: Added.
+ * platform/text/android/TextBreakIteratorInternalICU.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android specific file to WebCore/platform/android (part 9).
+ https://bugs.webkit.org/show_bug.cgi?id=26266
+
+ * platform/android/TemporaryLinkStubs.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android platform specific files.
+ https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).
+
+ * platform/android/SystemTimeAndroid.cpp: Added.
+ * platform/android/WidgetAndroid.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform. (part 6).
+ https://bugs.webkit.org/show_bug.cgi?id=26264
+
+ * platform/android/RenderThemeAndroid.cpp: Added.
+ * platform/android/RenderThemeAndroid.h: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform (part 7).
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android/ScreenAndroid.cpp: Added.
+ * platform/android/ScrollViewAndroid.cpp: Added.
+ * platform/android/SearchPopupMenuAndroid.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform (part 5).
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android/LocalizedStringsAndroid.cpp: Added.
+ * platform/android/PopupMenuAndroid.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform (part 4).
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android/KeyEventAndroid.cpp: Added.
+ * platform/android/KeyboardCodes.h: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform (part 3).
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android/FileChooserAndroid.cpp: Added.
+ * platform/android/FileSystemAndroid.cpp: Added.
+
+2009-06-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add Android port files to WebCore/platform (part 2).
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android/CursorAndroid.cpp: Added.
+ * platform/android/DragDataAndroid.cpp: Added.
+ * platform/android/EventLoopAndroid.cpp: Added.
+
+2009-06-10 Nate Chapin <japhet@google.com>
+
+ Reviewed by David Levin.
+
+ Finish moving V8Custom from src.chromium.org to svn.webkit.org.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26258
+
+ * bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming.
+ (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
+ (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
+ (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
+ (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp.
+ (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
+ * bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
+ * bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
+ * bindings/v8/custom/V8WebKitPointConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
+
+2009-06-10 Takeshi Yoshino <tyoshino@google.com>
+
+ Reviewed by Justin Garcia.
+
+ Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.
+ https://bugs.webkit.org/show_bug.cgi?id=26214
+
+ visiblePositionForIndex can return an instance that returns true for
+ isNotNull(). One of common case is when the corresponding input element has
+ "-webkit-user-select: none" style attribute. We should allow the case instead
+ of putting ASSERT.
+
+ Test: fast/forms/input-select-webkit-user-select-none.html
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setSelectionRange):
+
+2009-06-10 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=26197
+
+ The PlatformContextSkia constructor does a (very likely) wrong size
+ initialization for its m_stateStack member:
+
+ m_stateStack(sizeof(State))
+
+ The intended initialization is probably rather
+
+ m_stateStack(1)
+
+ However, since this doesn't buy much (see also comment #4),
+ I removed the initialization completely.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::PlatformContextSkia): remove member initialization
+
+2009-06-10 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ When there is no backing bitmap, return a transparent pattern.
+ https://bugs.webkit.org/show_bug.cgi?id=26061
+
+ Test: fast/canvas/canvas-empty-image-pattern.html
+
+ * platform/graphics/skia/PatternSkia.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+
+2009-06-10 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix a crash for radial gradients with a zero radius.
+ https://bugs.webkit.org/show_bug.cgi?id=26059
+
+ Test: fast/gradients/crash-on-zero-radius.html
+
+ * platform/graphics/skia/GradientSkia.cpp:
+ (WebCore::Gradient::platformGradient):
+
+2009-06-10 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part five
+ Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
+ This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
+ well and modifies Skia's usage of those interfaces accordingly. Once a
+ similar change lands on the Cairo side, the Skia and Cairo decoders
+ should be identical except for the implementation of RGBA32Buffer.
+
+ * platform/graphics/skia/ImageSourceSkia.cpp:
+ (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
+ * platform/image-decoders/skia/BMPImageReader.cpp:
+ (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
+ * platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height().
+ (WebCore::RGBA32Buffer::zeroFill): Added.
+ (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away.
+ (WebCore::RGBA32Buffer::copyRowNTimes): Added.
+ (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function.
+ (WebCore::RGBA32Buffer::asNewNativeImage): Added.
+ (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25671
+ [GTK] Implement support for set_caret_offset
+
+ Make an implementation that actually works.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_text_set_caret_offset):
+
+2009-06-10 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26294
+
+ Make sure all member variables are initialized so that the default
+ assignment operator and copy constructors do not read uninitialized
+ memory.
+
+ * platform/network/ResourceResponseBase.cpp:
+
+2009-06-10 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Update main resource meta-data when resource tracking is disabled.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26253
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::getTrackedResource):
+ (WebCore::InspectorController::willSendRequest):
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didReceiveContentLength):
+ (WebCore::InspectorController::didFinishLoading):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/InspectorController.h:
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25609
+ [GTK] Implement support for get_selection and get_n_selections
+
+ Implement atk_text_get_selection.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_text_get_selection):
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ Do not check if our parent class has the finalize method, it's
+ guaranteed to be there.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_finalize):
+
+2009-06-10 Brent Fulgham <bfulgham@webkit.org>
+
+ Build correct for Windows Cairo targets.
+
+ * WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction
+ between '_setjmp' and C++ object destruction is non-portable) for
+ the two Cairo targets. This used to be disabled in a #pragma,
+ but recent refactoring removed these lines.
+
+2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the build of PluginView on Qt with 64-bit where we disable plugins
+ at compile time.
+
+ Use the FooNone.cpp files at compile-time.
+
+ * plugins/PluginPackageNone.cpp:
+ * plugins/mac/PluginPackageMac.cpp:
+ * plugins/mac/PluginViewMac.cpp:
+
+2009-06-10 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ ImageDecoderQt needs m_size and m_sizeAvailable to be protected.
+
+ * platform/image-decoders/ImageDecoder.h:
+
+2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Use absolute path for install_name on Mac
+
+ * WebCore.pro:
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25415
+ [GTK][ATK] Please implement support for get_text_at_offset
+
+ Reduce duplicated code to access the text of a AtkText
+ object. doAXStringForRange calls text() internally, so we are
+ doing exactly the same after the change.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (getGailTextUtilForAtk):
+ (getPangoLayoutForAtk):
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25415
+ [GTK][ATK] Please implement support for get_text_at_offset
+
+ Pass a PangoLayout to the GailTextUtil function calls.
+
+ It's needed for LINE boundary calls to work correctly.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (updateLayout):
+ (getPangoLayoutForAtk):
+ (webkit_accessible_text_get_text_after_offset):
+ (webkit_accessible_text_get_text_at_offset):
+
+2009-06-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25415
+ [GTK][ATK] Please implement support for get_text_at_offset
+
+ Use GailUtilText instead of my crappy partial reimplementation of
+ it. This should add support for LINE boundaries too, although it's
+ mostly untested for now.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (getGailTextUtilForAtk):
+ (webkit_accessible_text_get_text_after_offset):
+ (webkit_accessible_text_get_text_at_offset):
+
+2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix: include <stdio.h> as it is required in jpeglib.h
+
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+
+2009-06-09 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part four
+ Most of the remaining Cairo changes needed before merging Skia/Cairo
+ image decoders. Most of these involve plumbing more error detection and
+ handling (or, in some cases, merely the capability to detect errors, as
+ e.g. Skia detects and handles image allocation failure while Cairo
+ currently doesn't). There is also some general cleanup and
+ simplification; RGBA32Buffer::m_height and all associated functions have
+ been removed (set but never used) and some places now rely on superclass
+ implementations.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::RGBA32Buffer): Remove m_height, ensureHeight() and associated stuff
+ (WebCore::RGBA32Buffer::copyBitmapData): Add API function so refcounted backing stores (like Skia uses) can be used with GIFs
+ (WebCore::RGBA32Buffer::setSize): Zero-fill image to avoid garbage
+ (WebCore::RGBA32Buffer::height): Remove
+ (WebCore::RGBA32Buffer::ensureHeight): Remove
+ (WebCore::ImageDecoder::ImageDecoder): Keep member initialization in order, force subclasses to go through size() instead of accessing m_size directly
+ (WebCore::ImageDecoder::isSizeAvailable): Check that decoding hasn't failed
+ (WebCore::ImageDecoder::size): Check that decoding hasn't failed
+ (WebCore::ImageDecoder::setSize): Protect against integer overflow
+ (WebCore::ImageDecoder::isOverSize): Protect against integer overflow
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove prepEmptyFrameBuffer()
+ (WebCore::GIFImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
+ (WebCore::GIFImageDecoder::sizeNowAvailable): Add return values for better failure handling, rely on superclass setSize() for overflow protection
+ (WebCore::GIFImageDecoder::initFrameBuffer): Add return values for better failure handling, remove prepEmptyFrameBuffer(), use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), use RGBA32Buffer::copyBitmapData() so backing store can be refcounted internally (Cairo won't be, Skia is), rely on superclass size() for better failure handling
+ (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation, remove RGBA32Buffer::ensureHeight()
+ (WebCore::GIFImageDecoder::frameComplete): Remove RGBA32Buffer::ensureHeight()
+ * platform/image-decoders/gif/GIFImageDecoder.h: Remove prepEmptyFrameBuffer(), add return values for better failure handling
+ * platform/image-decoders/gif/GIFImageReader.cpp:
+ (GIFImageReader::do_lzw): Protect against array overflow, add comments
+ (GIFImageReader::read): Protect against array overflow, be more tolerant of bad data, better failure handling
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files)
+ (WebCore::JPEGImageReader::decode): Better failure handling
+ (WebCore::JPEGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
+ (WebCore::JPEGImageDecoder::outputScanlines): Use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), rely on superclass size() for better failure handling, remove RGBA32Buffer::ensureHeight()
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h: Rely on superclass setSize() for overflow protection
+ * platform/image-decoders/png/PNGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files)
+ (WebCore::PNGImageDecoder::PNGImageDecoder): Don't allocate a slot in the framebuffer cache until it's needed
+ (WebCore::PNGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
+ (WebCore::PNGImageDecoder::frameBufferAtIndex): Don't allocate a slot in the framebuffer cache until it's needed
+ (WebCore::PNGImageDecoder::decode): Don't allocate a slot in the framebuffer cache until it's needed
+ (WebCore::PNGImageDecoder::decodingFailed): Fix style violation
+ (WebCore::PNGImageDecoder::headerAvailable): Rely on superclass isSizeAvailable() and setSize() for overflow protection and better failure handling
+ (WebCore::PNGImageDecoder::rowAvailable): Don't allocate a slot in the framebuffer cache until it's needed, use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), remove RGBA32Buffer::ensureHeight()
+ (WebCore::PNGImageDecoder::pngComplete): Don't allocate a slot in the framebuffer cache until it's needed
+
+2009-06-09 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix, adding JSCore/assembler to the list of include dirs, and
+ adding editing/ReplaceNodeSpanCommand.cpp to the build.
+
+ * WebCoreSources.bkl:
+ * webcore-base.bkl:
+
+2009-06-09 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ When checking if the loader is the main resource loader make sure that the loader's frame is the main frame.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26218
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didLoadResourceFromMemoryCache):
+ (WebCore::InspectorController::identifierForInitialRequest):
+ (WebCore::InspectorController::isMainResourceLoader):
+ * inspector/InspectorController.h:
+
+2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26190
+
+ Test: media/controls-css-overload.html
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::updateControls): Prevent NULL dereference in case containers gets hidden.
+
+2009-06-08 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part three
+ Various minor cleanups to the Skia files. Mostly non-functional, except
+ for two specific changes:
+ * JPEGs and PNGs were always marked as transparent; now they are only
+ marked as transparent when they actually are. I doubt this has much
+ of an effect but in theory it could be used to optimize their display.
+ * Instead of arbitrarily disallowing images over 32 * 1024 * 1024 px^2,
+ only disallow images which are so large they will cause overflow in
+ other parts of the code. This should fix the testcase on
+ http://code.google.com/p/chromium/issues/detail?id=3643.
+
+ * platform/image-decoders/skia/BMPImageReader.h:
+ (WebCore::BMPImageReader::setRGBA): Use simpler non-static setRGBA() form
+ * platform/image-decoders/skia/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::initFrameBuffer): Remove unneeded code, use more readable setRGBA() form
+ (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation
+ * platform/image-decoders/skia/GIFImageDecoder.h: Remove unneeded code
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::setSize): setSize() should just setStatus() when it fails since all callers were doing it
+ (WebCore::ImageDecoder::isOverSize): Ease "oversized" image constraints to allow any image that won't overflow
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageDecoder::outputScanlines): Remove unneeded code, mark JPEGs as non-transparent
+ * platform/image-decoders/skia/PNGImageDecoder.cpp:
+ (WebCore::PNGImageDecoder::decodingFailed): Fix style violation
+ (WebCore::PNGImageDecoder::rowAvailable): Mark un-decoded PNGs as non-transparent (this will get reset later as needed)
+ * platform/image-decoders/skia/XBMImageDecoder.cpp:
+ (WebCore::XBMImageDecoder::frameBufferAtIndex): Remove unneeded code
+
+2009-06-09 Darin Fisher <darin@chromium.org>
+
+ Fix Chromium build bustage.
+
+ CachedResource.cpp no longer compiles if USE(JSC) is not defined. The
+ problem is that this file is using a macro from StdLibExtras.h without
+ including that file. It just happenes to get that file via a JSC
+ specific include.
+
+ * loader/CachedResource.cpp:
+
+2009-06-09 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Oliver Hunt.
+
+ Make sure the graphics backends are in sync with the canvas lineWidth state.
+ https://bugs.webkit.org/show_bug.cgi?id=26187
+
+ Test: fast/canvas/canvas-line-width.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
+
+2009-06-09 Michael Nordman <michaeln@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Proactively cancel pending requests at DocLoader dtor time,
+ otherwise crashes can occur.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26230
+ http://code.google.com/p/chromium/issues/detail?id=12161
+
+ Test: fast/frames/javascript-url-as-framesrc-crash.html
+
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::~DocLoader):
+
+2009-06-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix ASSERT seen in shadow tree testing
+ https://bugs.webkit.org/show_bug.cgi?id=25092
+
+ Test: svg/custom/use-mutation-event-crash.svg
+
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::instanceForShadowTreeElement):
+
+2009-06-09 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=22891
+ Scrolling in Windows Cairo Broken if no background color set.
+
+ * platform/graphics/cairo/GradientCairo.cpp:
+ (WebCore::Gradient::fill): Use the GraphicsContext save and restore
+ methods (rather than the Cairo-only functions) so that the Windows
+ device context is kept in sync.
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::GraphicsContext): Add new constructor call
+ to sync Windows HDC with Cairo surface.
+ * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+ (WebCore::GraphicsContextPlatformPrivate::syncContext): Provide
+ declaration for Windows HDC sync method (and stub for non-Windows
+ Cairo implementations).
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::draw): Use GraphicsContext save and restore
+ methods (rather than the Cairo-only functions) so that the Windows
+ device context is kept in sync.
+ * platform/graphics/win/GraphicsContextCairoWin.cpp:
+ (WebCore::CairoContextWithHDC): New method to create a valid Cairo
+ context for a given HDC.
+ (WebCore::GraphicsContext::GraphicsContext): Modify constructor to
+ use new CairoContextWithHDC call.
+ (WebCore::GraphicsContext::getWindowsContext): Revise to match
+ behavior of CG implementation.
+ (WebCore::GraphicsContext::releaseWindowsContext): Revise to match
+ behavior of CG implementation.
+ (WebCore::GraphicsContextPlatformPrivate::concatCTM): Get rid of
+ incorrect new HDC, and use object's HDC member for dealing with
+ concatCTM operations.
+ (WebCore::GraphicsContextPlatformPrivate::syncContext): New method
+ to sync Windows HDC with Cairo context.
+ * platform/graphics/win/ImageCairoWin.cpp:
+ (WebCore::BitmapImage::getHBITMAPOfSize): Revise implementation to
+ match CG behavior.
+
+2009-06-09 Jian Li <jianli@chromium.org>
+
+ Reviewed by David Levin.
+
+ Bug 26196: Fix the problem that worker's importScripts fails if the
+ script URL is redirected from different origin.
+ https://bugs.webkit.org/show_bug.cgi?id=26196
+
+ Test: http/tests/workers/worker-importScripts.html
+
+ The fix is to pass an additional enum parameter to the loader in
+ order to tell it to perform the redirect origin check or not.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::create):
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::willSendRequest):
+ * loader/DocumentThreadableLoader.h:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/ThreadableLoader.h:
+ (WebCore::):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ * loader/WorkerThreadableLoader.h:
+ (WebCore::WorkerThreadableLoader::create):
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::importScripts):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+
+2009-06-09 Anand K. Mistry <amistry@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Paint bitmaps with the alpha channel in Skia.
+ https://bugs.webkit.org/show_bug.cgi?id=26037
+
+ Test: fast/canvas/drawImage-with-globalAlpha.html
+
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::paintSkBitmap):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::getAlpha):
+ * platform/graphics/skia/PlatformContextSkia.h:
+
+2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26104
+ [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
+
+ Refactor how SoupMessage is handled, so that our ResourceRequest
+ object doesn't have to store it as a member, which complicates
+ managing ResourceRequest's lifetime.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp):
+ * platform/network/soup/ResourceRequest.h:
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::toSoupMessage):
+ (WebCore::ResourceRequest::updateFromSoupMessage):
+
+2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build, the time functions moved into the WTF namespace.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+ (JSC::Bindings::convertQVariantToValue):
+
+2009-06-08 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ <rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.
+
+ Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
+
+ Loader::Host objects were manually managed via new/delete.
+ There's a variety of circumstances where a Host might've been deleted while it was still in the middle
+ of a resource load delegate callback.
+ Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.
+
+ At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
+ fully implemented.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Loader):
+ (WebCore::Loader::load):
+ (WebCore::Loader::servePendingRequests):
+ (WebCore::Loader::resumePendingRequests):
+ (WebCore::Loader::cancelRequests):
+ (WebCore::Loader::Host::didFinishLoading):
+ (WebCore::Loader::Host::didFail):
+ (WebCore::Loader::Host::didReceiveResponse):
+ (WebCore::Loader::Host::didReceiveData):
+ * loader/loader.h:
+ (WebCore::Loader::Host::create):
+
+2009-06-08 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by David Levin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26126
+ Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.
+
+ Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
+ implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
+ Chromium's workers.
+
+ No changes in functionality so no tests added.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ Added WorkerLoaderProxy.h to the bulid.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
+ * bindings/v8/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate): same.
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::~WorkerContext): same.
+ (WebCore::WorkerContext::reportException): same.
+ (WebCore::WorkerContext::addMessage): same.
+ (WebCore::WorkerContext::postMessage): same.
+
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
+ Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge.
+ Mostly rename.
+
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
+ AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
+ when worker termination is requested a very short time before the request to load something
+ (XHR or importScript) was dispatched on the main thread.
+
+ * loader/WorkerThreadableLoader.h:
+ Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows
+ to implement WorkerThreadableLoader for Chromium.
+
+ * workers/WorkerLoaderProxy.h: Added.
+ (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):
+
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::startWorkerContext):
+ (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
+ * workers/WorkerMessagingProxy.h:
+ Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual.
+ Removed unused postTaskToWorkerContext() method.
+
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ * workers/WorkerThread.h:
+ (WebCore::WorkerThread::workerLoaderProxy):
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * workers/WorkerThread.h:
+ (WebCore::WorkerThread::workerLoaderProxy):
+ (WebCore::WorkerThread::workerObjectProxy):
+ WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor.
+ Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.
+
+2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26238
+ Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.
+
+ * ForwardingHeaders/runtime/DateMath.h: Removed.
+ * ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
+ * platform/network/HTTPParsers.cpp:
+ (WebCore::parseDate): Added.
+ * platform/network/HTTPParsers.h:
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::parseDateValueInHeader): Changed to use the new helper.
+
+2009-06-08 Adam Langley <agl@google.com>
+
+ Reviewed by Eric Siedel.
+
+ Chromium Linux ignored the background color on <select>s. Rather
+ than encode magic colours, we start with a base color (specified
+ via CSS) and derive the other colors from it. Thus, setting the
+ CSS background-color now correctly changes the colour of the
+ control.
+
+ This should not change the appearence controls without
+ background-colors. However, <select>s with a background-color
+ will now renderer correctly, which may require rebaselining
+ pixel tests in the Chromium tree.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26030
+ http://code.google.com/p/chromium/issues/detail?id=12596
+
+ * platform/graphics/Color.cpp:
+ (WebCore::Color::getHSL): new member
+ * platform/graphics/Color.h:
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::systemColor):
+ (WebCore::brightenColor):
+ (WebCore::paintButtonLike):
+
+2009-06-08 Victor Wang <victorw@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26087
+ Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event
+
+ Fix tab crash caused by destroying the popup list that fired the change event on abandon.
+
+ If a popup list is abandoned (press a key to jump to an item
+ and then use tab or mouse to get away from the select box),
+ the current code fires a change event in PopupListBox::updateFromElemt().
+ The JS that listens to this event may destroy the object and cause the
+ rest of popup list code crashes.
+
+ The updateFromElement() is called before abandon() and this causes
+ the selected index to be discarded after updateFromElement(). From
+ the code comments, this appears to be the reason why valueChanged is
+ called in updateFromElement.
+
+ Fix the issue by removing the valueChanged call in updateFromElement,
+ saving the selected index that we should accept on abandon and pass
+ it to the valueChange in abandon().
+
+ A manual test has been added.
+
+ * manual-tests/chromium: Added.
+ * manual-tests/chromium/onchange-reload-popup.html: Added.
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::updateFromElement):
+
+2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Disable a few warnings on Windows
+
+ * WebCore.pro:
+
+2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows
+
+ This define was brought in after refactoring some code from
+ PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.
+
+ * WebCore.pro:
+
+2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
+
+ * WebCore.pro:
+
+2009-06-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ [Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
+ https://bugs.webkit.org/show_bug.cgi?id=26244
+
+ * WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if
+ NETSCAPE_PLUGIN_API is turned on
+ * plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
+ * plugins/PluginViewNone.cpp: Match guards with PluginView.h
+
+2009-06-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES
+ when the selection is inside a text field.
+
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::isAll): Return false if the selection is in
+ a shadow tree.
+
+2009-06-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26106
+ [GTK] Crashes when you keep a combo open during a page transition, then close it
+
+ Hide the combo popup and disconnect from its signals during
+ PopupMenu destruction to handle this exceptional case with no
+ crash.
+
+ * platform/gtk/PopupMenuGtk.cpp:
+ (WebCore::PopupMenu::~PopupMenu):
+ (WebCore::PopupMenu::menuUnmapped):
+
+2009-06-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6930540>
+ REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
+
+ Test: fast/css/font-family-builtins.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::identifierForFamily): Fix typo. Fantasy family should be
+ -webkit-fantasy not, -webkit-serif.
+
+2009-06-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Brady Eidson.
+
+ Fix for <rdar://problem/6936235>
+ Need to support StorageEvent.storageArea to meet the Web Storage spec
+
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for
+ the frame being dispatched to.
+ * storage/SessionStorageArea.cpp:
+ (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
+
+ * storage/StorageEvent.cpp:
+ (WebCore::StorageEvent::StorageEvent):
+ (WebCore::StorageEvent::initStorageEvent):
+ * storage/StorageEvent.h:
+ (WebCore::StorageEvent::create):
+ (WebCore::StorageEvent::storageArea):
+ * storage/StorageEvent.idl:
+ Add storageArea member.
+
+2009-06-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Anders Carlsson.
+
+ Fix WMLInputElement initialization code. Don't call initialize() on attach(), let
+ WMLCardElement handle initialization once, after the document has been parsed.
+
+ To keep layout tests working introduce a new function in Document.idl: initializeWMLPageState().
+ WMLTestCase.js (the wml/ layout test framework) will use it to simulate a regular WML document,
+ whose variable state gets initialized on WMLDocument::finishedParsing(). Force initialization
+ of the WML variable state, right after the dynamically created elements have been inserted into the tree.
+
+ * dom/Document.cpp:
+ (WebCore::Document::initializeWMLPageState):
+ * dom/Document.h:
+ * dom/Document.idl:
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing):
+ (WebCore::WMLDocument::initialize):
+ * wml/WMLDocument.h:
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::initialize):
+ * wml/WMLInputElement.h:
+
+2009-06-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Add ononline and onoffline attributes for the <body> element.
+
+ * html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr
+ and onofflineAttr to window event listeners.
+
+2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Add missing includes of config.h
+
+ * platform/qt/QWebPopup.cpp:
+ * platform/text/qt/TextBreakIteratorQt.cpp:
+
+2009-06-05 Fumitoshi Ukai <ukai@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26215
+ Try to fix the Chromium build.
+
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+ (WebCore::fillBMPGlyphs):
+ (WebCore::fillNonBMPGlyphs):
+
+2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
+
+ <https://bugs.webkit.org/show_bug.cgi?id=26160>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Use /bin/ln instead of ln for cases where this command is used with -h option.
+ As this option is not supported by GNU fileutils, this change helps users
+ who have GNU fileutils in their PATH.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-06-03 Ben Murdoch <benm@google.com>
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
+
+ Test: storage/hash-change-with-xhr.html
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::stopLoading):
+ * loader/DocumentLoader.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::stopAllLoaders):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderTypes.h:
+ (WebCore::):
+ * page/Page.cpp:
+ (WebCore::Page::goToItem):
+ * WebCore.base.exp:
+
+2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Make sure the correct config.h is included when shadowbuilding
+
+ * WebCore.pro:
+
+2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix Qt build after r44452
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+
+2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Remove some dead code (MenuEventProxy)
+
+ * WebCore.pro:
+ * platform/ContextMenu.h:
+ * platform/qt/ContextMenuQt.cpp:
+ * platform/qt/MenuEventProxy.h: Removed.
+
+2009-06-05 Xan Lopez <xlopez@igalia.com>
+
+ More build fixes.
+
+ * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
+ (WebCore::GlyphPage::fill):
+
+2009-06-05 Xan Lopez <xlopez@igalia.com>
+
+ Fix the GTK+ build.
+
+ * GNUmakefile.am:
+ * platform/graphics/gtk/FontCacheGtk.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+ * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
+ (WebCore::GlyphPage::fill):
+
+2009-06-05 Antti Koivisto <antti@apple.com>
+
+ Try to fix Windows (and possibly other platforms) build.
+
+ Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
+ for now since PluginStream used on some platforms expects them and calculations differ from plain
+ Last-modified header value.
+
+ Also include <wtf/MathExtras.h> to get isfinite().
+
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::adopt):
+ (WebCore::ResourceResponseBase::copyData):
+ (WebCore::ResourceResponseBase::setLastModifiedDate):
+ (WebCore::ResourceResponseBase::lastModifiedDate):
+ * platform/network/ResourceResponseBase.h:
+ * platform/network/cf/ResourceResponseCFNet.cpp:
+ (WebCore::ResourceResponse::platformLazyInit):
+
+2009-06-03 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13128
+ Safari not obeying cache header
+
+ Implement RFC 2616 cache expiration calculations in WebKit instead of
+ relying on the networking layer.
+
+ * ForwardingHeaders/runtime/DateMath.h: Added.
+ * WebCore.base.exp:
+ * loader/Cache.cpp:
+ (WebCore::Cache::revalidationSucceeded):
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::CachedResource):
+ (WebCore::CachedResource::isExpired):
+ (WebCore::CachedResource::currentAge):
+ (WebCore::CachedResource::freshnessLifetime):
+ (WebCore::CachedResource::setResponse):
+ (WebCore::CachedResource::updateResponseAfterRevalidation):
+ (WebCore::CachedResource::mustRevalidate):
+ * loader/CachedResource.h:
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::ResourceResponseBase):
+ (WebCore::ResourceResponseBase::adopt):
+ (WebCore::ResourceResponseBase::copyData):
+ (WebCore::ResourceResponseBase::setHTTPHeaderField):
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives):
+ (WebCore::ResourceResponseBase::cacheControlContainsNoCache):
+ (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
+ (WebCore::ResourceResponseBase::cacheControlMaxAge):
+ (WebCore::parseDateValueInHeader):
+ (WebCore::ResourceResponseBase::date):
+ (WebCore::ResourceResponseBase::age):
+ (WebCore::ResourceResponseBase::expires):
+ (WebCore::ResourceResponseBase::lastModified):
+ (WebCore::ResourceResponseBase::isAttachment):
+ (WebCore::ResourceResponseBase::compare):
+ * platform/network/ResourceResponseBase.h:
+ * platform/network/cf/ResourceResponseCFNet.cpp:
+ (WebCore::ResourceResponse::platformLazyInit):
+ * platform/network/mac/ResourceResponseMac.mm:
+ (WebCore::ResourceResponse::platformLazyInit):
+
+2009-06-04 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 26201: Remove superfluous 'if' statements in RenderTable::addChild
+ https://bugs.webkit.org/show_bug.cgi?id=26201
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild): remove superfluous 'if' statements
+
+
+2009-06-04 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 26202: add macros for primitive values to simplify CSSStyleSelector::applyProperty
+ https://bugs.webkit.org/show_bug.cgi?id=26202
+
+ * css/CSSStyleSelector.cpp: add HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE[_WITH_VALUE] macros
+ (WebCore::CSSStyleSelector::applyProperty): use new macros
+
+2009-06-04 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel
+
+ Bug 26203: Move parsing of 'attr(X)' values to own method
+ https://bugs.webkit.org/show_bug.cgi?id=26203
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseAttr): new method
+ (WebCore::CSSParser::parseContent): use new parseAttr method
+ * css/CSSParser.h:
+ (WebCore::CSSParser::parseAttr): new method
+
+2009-06-04 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 26205: RenderTableSection::addChild : correct comment
+ https://bugs.webkit.org/show_bug.cgi?id=26205
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addChild): correct comment
+
+2009-06-04 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 26204: RenderBlock : simplify handleSpecialChild, comment correction
+ https://bugs.webkit.org/show_bug.cgi?id=26204
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::handleSpecialChild): simplify usage
+ (WebCore::RenderBlock::handlePositionedChild): simplify usage
+ (WebCore::RenderBlock::handleFloatingChild): simplify usage
+ (WebCore::RenderBlock::handleRunInChild): simplify usage
+ (WebCore::RenderBlock::layoutBlock): correct comment
+ (WebCore::RenderBlock::layoutBlockChildren): simplify loop, change call to handleSpecialChild
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::handleSpecialChild): change signature
+ (WebCore::RenderBlock::handlePositionedChild): change signature
+ (WebCore::RenderBlock::handleFloatingChild): change signature
+ (WebCore::RenderBlock::handleRunInChild): change signature
+
+2009-06-04 Dan Bernstein <mitz@apple.com>
+
+ - retry to fix the Tiger build
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::initFontData):
+
+2009-06-04 Dan Bernstein <mitz@apple.com>
+
+ - try to fix the Tiger build
+
+ * platform/graphics/SimpleFontData.h:
+
+2009-06-04 Dan Bernstein <mitz@apple.com>
+
+ - try to fix the Leopard and Tiger builds
+
+ * platform/graphics/SimpleFontData.h:
+
+2009-06-04 Dan Bernstein <mitz@apple.com>
+
+ - try to fix the Windows build
+
+ * platform/graphics/win/UniscribeController.cpp:
+ (WebCore::UniscribeController::shapeAndPlaceItem):
+
+2009-06-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - make SimpleFontData's data members private
+ - rename SimpleFontData's m_font member to m_platformData
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::spaceWidth):
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData):
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::platformData):
+ (WebCore::SimpleFontData::spaceWidth):
+ (WebCore::SimpleFontData::adjustedSpaceWidth):
+ (WebCore::SimpleFontData::syntheticBoldOffset):
+ (WebCore::SimpleFontData::spaceGlyph):
+ (WebCore::SimpleFontData::getNSFont):
+ (WebCore::SimpleFontData::getQtFont):
+ (WebCore::SimpleFontData::getWxFont):
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::WidthIterator::advance):
+ * platform/graphics/cairo/FontCairo.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/gtk/FontGtk.cpp:
+ (WebCore::setPangoAttributes):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ (WebCore::SimpleFontData::setFont):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ (WebCore::SimpleFontData::setFont):
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::adjustGlyphsAndAdvances):
+ * platform/graphics/mac/FontMac.mm:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/mac/FontMacATSUI.mm:
+ (WebCore::initializeATSUStyle):
+ (WebCore::overrideLayoutOperation):
+ (WebCore::ATSULayoutParameters::initialize):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::initFontData):
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ (WebCore::SimpleFontData::checkShapesArabic):
+ (WebCore::SimpleFontData::getCTFont):
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::drawGDIGlyphs):
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ (WebCore::SimpleFontData::setFont):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::initGDIFont):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::widthForGDIGlyph):
+ (WebCore::SimpleFontData::scriptFontProperties):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+
+2009-06-04 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Initialize the width of PopupMenuListBox properly for Mac Chromium.
+
+ Added a test that works only with this patch applied. The test is
+ a manual one, since the hit testing infrastructure in the layout
+ tests sends keyboard and mouse events to the main window and not
+ the cocoa control that implements the popup up, which means we can't
+ select items from the popup up.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25904
+
+
+ * manual-tests/select-narrow-width.html: Added.
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupContainer::showExternal):
+
+2009-06-04 Brent Fulgham <bfulgham@webkit.org>
+
+ Unreviewed Windows build correction.
+
+ * WebCore.vcproj/WebCore.vcproj: Add missing 'ReplaceNodeWithSpanCommand.cpp'
+ and 'ReplaceNodeWithSpanCommand.h'
+
+2009-02-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Make sure execCommand("bold") on <b style="text-decoration: underline">test</b>
+ only removes the bold and not the underline.
+ https://bugs.webkit.org/show_bug.cgi?id=23496
+
+ Test: editing/execCommand/convert-style-elements-to-spans.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSStyleDeclaration.h:
+ (WebCore::CSSStyleDeclaration::isEmpty):
+ * dom/NamedAttrMap.h:
+ (WebCore::NamedAttrMap::isEmpty):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::isUnstyledStyleSpan):
+ (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
+ (WebCore::ApplyStyleCommand::applyBlockStyle):
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle):
+ (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
+ (WebCore::ApplyStyleCommand::removeCSSStyle):
+ (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
+ (WebCore::ApplyStyleCommand::removeInlineStyle):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+ * editing/ApplyStyleCommand.h:
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::replaceNodeWithSpanPreservingChildrenAndAttributes):
+ * editing/CompositeEditCommand.h:
+ * editing/RemoveNodePreservingChildrenCommand.cpp:
+ (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
+ * editing/ReplaceNodeWithSpanCommand.cpp: Added.
+ (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
+ (WebCore::swapInNodePreservingAttributesAndChildren):
+ (WebCore::ReplaceNodeWithSpanCommand::doApply):
+ (WebCore::ReplaceNodeWithSpanCommand::doUnapply):
+ * editing/ReplaceNodeWithSpanCommand.h: Added.
+ (WebCore::ReplaceNodeWithSpanCommand::create):
+
+2009-06-04 Brent Fulgham <bfulgham@webkit.org>
+
+ Unreviewed build fix for Windows Cairo target.
+
+ Add missing post-build command to copy history/cf contents
+ to output directory.
+
+ * WebCore.vcproj/WebCore.vcproj: Update Debug_Cairo and Release_Cairo
+ target post-build steps with copy commands.
+
+2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6854695> Movie controller thumb fails to scale with full page zoom
+
+ Account for zoom level when drawing media controller thumb on Windows.
+
+ * rendering/RenderMediaControls.cpp:
+ (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
+
+2009-06-04 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Move DOM window focus/blur out of SelectionController and into FocusController. Make sure it
+ fires on the focused frame when the page activation state changes also. This is covered by an existing
+ layout test (albeit badly). I have modified the test to be correct.
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setFocused):
+ * page/FocusController.cpp:
+ (WebCore::FocusController::setFocusedFrame):
+ (WebCore::FocusController::setActive):
+
+2009-06-04 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26148
+ Adding in empty files to stage the extract of RenderThemeChromiumSkia
+ from RenderThemeChromiumLinux and RenderThemeChromiumWindows.
+
+ * rendering/RenderThemeChromiumSkia.cpp: Added.
+ * rendering/RenderThemeChromiumSkia.h: Added.
+
+2009-06-04 Andrei Popescu <andreip@google.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25562
+ Potential crash after ApplicationCacheStorage::storeNewestCache() fails
+
+ Fix the crash by checking the return value of cacheStorage().storeNewestCache(this)
+ in WebCore::ApplicationCacheGroup::checkIfLoadIsComplete. If storeNewestCache failed,
+ we run the cache failure steps:
+
+ 1. Fire the error events to all pending master entries, as well any other cache hosts
+ currently associated with a cache in this group.
+ 2. Disassociate the pending master entries from the failed new cache.
+ 3. Reinstate the old "newest cache", if there was one.
+
+ We also introduce two other changes:
+
+ 1. a mechanism to rollback storageID changes to the in-memory resource
+ objects when the storing of an ApplicationCache object fails.
+
+ 2. defer removing the pending master entries from the list of pending master entries
+ until the entire load is complete. This matches the HTML 5 spec better. To track
+ if the load is complete we now introduce a counter for those pending master entries
+ that haven't yet finshed downloading.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): initializes the new counter to 0
+ (WebCore::ApplicationCacheGroup::selectCache): increments the counter when a new pending
+ master entry is added.
+ (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): decrements the counter
+ instead of removing the pending master entry.
+ (WebCore::ApplicationCacheGroup::failedLoadingMainResource): decrements the counter
+ instead of removing the pending master entry.
+ (WebCore::ApplicationCacheGroup::setNewestCache): removes an assertion that no longer
+ holds true. In particular, the newest cache is not necessarily new anymore. We can
+ set an old cache as the new cache. This can happen if we failed to store a newly
+ downloaded cache to the database and we are now reinstating the former newest cache.
+ (WebCore::ApplicationCacheGroup::manifestNotFound): resets the counter to 0.
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): check if the loading is complete
+ based on the counter instead of the list of pending master entries. Empty the list of
+ master entries if the load is complete.
+ * loader/appcache/ApplicationCacheGroup.h: add the new counter.
+ * loader/appcache/ApplicationCacheStorage.cpp: introduce the journaling mechanism for
+ in-memory resource objects.
+ (WebCore::ResourceStorageIDJournal::~ResourceStorageIDJournal):
+ (WebCore::ResourceStorageIDJournal::add):
+ (WebCore::ResourceStorageIDJournal::commit):
+ (WebCore::ResourceStorageIDJournal::Record::Record):
+ (WebCore::ResourceStorageIDJournal::Record::restore):
+ (WebCore::ApplicationCacheStorage::store): log the changes to the in-memory resource
+ objects.
+ (WebCore::ApplicationCacheStorage::storeNewestCache): create the journal object.
+ * loader/appcache/ApplicationCacheStorage.h: modify the signature of
+ bool store(ApplicationCache*) to add a pointer to the logger object used to
+ trace the changes to the storageID of the resource objects.
+
+2009-06-04 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26154
+ Allow underscores in the hostnames we parse out of databaseIdentifiers.
+ This code is used for HTML 5 database support.
+
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
+
+2009-06-04 Mihnea Ovidenie <mihnea@adobe.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
+ https://bugs.webkit.org/show_bug.cgi?id=26084
+
+ When painting multiple images, make sure that at least one image is valid before pushing a transparency layer.
+
+ Added a manual test.
+
+ * manual-tests/mask-composite-missing-images.html: Added.
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintMaskImages):
+
+2009-06-04 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26180
+ Add a fast path for SecurityOrigin::equal. If "other == this" (where
+ other is the other security origin), then we really don't need to do
+ all the other (expensive) comparisons. We know it's equal.
+
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::equal):
+
+2009-06-03 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Improvements in how selection behaves with focus/activation and a reversion back to using isActive
+ in the scrollbar theme code to remove a Chromium ifdef.
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::SelectionController):
+ Make the controller set its focused state correctly upon initial creation.
+
+ (WebCore::SelectionController::setSelection):
+ Make selection willing to shift the focus node if the selection is focused even if the
+ selection is not active. Whether or not the Page is active is irrelevant to focus changes.
+
+ (WebCore::SelectionController::setFocused):
+ * editing/SelectionController.h:
+ (WebCore::SelectionController::isFocused):
+ Add a new isFocused() method so that code can check if the Selection is focused without caring
+ about the active state.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setFocusedNodeIfNeeded):
+ Allow focus shifts even when the selection is not active.
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::paint):
+ Revert Dan's change to directly talk to AppKit for checking active state. Now that the WebCore isActive
+ method works, ditch the Chromium-specific #ifdef and go back to the original code.
+
+2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Test: media/before-load-member-access.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=26081
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::played): Ensure that if m_playedTimeRanges,
+ is not initialized we return a valid range, and don't attempt to use it.
+
+2009-06-03 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Implement a way to invalidate the FontCache used by the Qt port.
+
+ * platform/graphics/qt/FontCacheQt.cpp:
+ (WebCore::FontCache::invalidate):
+
+2009-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26015
+
+ [Qt] Single-threaded QtWebKit configuration
+
+ Turn off Database, DOM storage, icon database and Web Workers support
+ when ENABLE_SINGLE_THREADED is turned on.
+
+ Set SQLITE_THREADSAFE to false to turn off SQLite mutexes
+ when ENABLE_SINGLE_THREADED is turned on.
+
+ * WebCore.pro:
+
+2009-06-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - add some assertions that Font methods are used on the main thread
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::setShouldUseSmoothing):
+ * platform/graphics/Font.h:
+ (WebCore::Font::primaryFont):
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+
+2009-06-03 Dan Bernstein <mitz@apple.com>
+
+ - Windows build fix
+
+ Rolled out apparently-accidental changes to config.h from r44398. These
+ were not part of the patch as reviewed.
+
+ * config.h:
+
+2009-06-03 Dmitry Titov <dimich@chromium.org>
+
+ Not reviewed, Chromium build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26177
+ Reverting 'private' to 'protected' on 2 classes.
+ Chromium glue layer (not yet in Webkit tree) relies on ability to derive
+ Chromium-specific platform classes and access the data members.
+ See bug for more details.
+
+ * platform/PlatformMouseEvent.h:
+ * platform/PlatformWheelEvent.h:
+
+2009-06-03 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser <simonfr@apple.com>.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=26162
+
+ This corrects an error when destroying an animation
+ or transition where endAnimation was never getting
+ called and therefore the hardware animation was never
+ getting removed.
+
+ This includes a manual-test since it's really impossible
+ to make a meaningful automatic test for an animation
+ bug like this.
+
+ This has no effect unless accelerated compositing is
+ enabled.
+
+ * manual-tests/interrupted-compound-transform.html: Added.
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::~ImplicitAnimation):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::~KeyframeAnimation):
+
+2009-06-03 Adam Langley <agl@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Make the scrollbar thumb size twice the width for Chromium Linux. This
+ matches Firefox on Linux.
+
+ This will need layout test pixel results to be rebaselined in the
+ Chromium tree.
+
+ http://code.google.com/p/chromium/issues/detail?id=12602
+ https://bugs.webkit.org/show_bug.cgi?id=26176
+
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
+ * platform/chromium/ScrollbarThemeChromiumLinux.h:
+
+2009-06-03 Adam Langley <agl@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Change Chromium scrollbar theme code to use different classes on
+ Windows and Linux rather than suppling symbols. The ScrollbarTheme
+ class is already using virtual dispatch, so there's no reason not to.
+
+ This should not affect any layout tests.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26174
+
+ * platform/chromium/ScrollbarThemeChromium.cpp:
+ * platform/chromium/ScrollbarThemeChromium.h:
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
+ (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromiumLinux::paintButton):
+ (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
+ (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
+ * platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
+ * platform/chromium/ScrollbarThemeChromiumWin.cpp:
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
+ (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
+ (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
+ (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromiumWin::paintButton):
+ (WebCore::ScrollbarThemeChromiumWin::paintThumb):
+ (WebCore::ScrollbarThemeChromiumWin::getThemeState):
+ (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
+ (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
+ (WebCore::ScrollbarThemeChromiumWin::buttonSize):
+ * platform/chromium/ScrollbarThemeChromiumWin.h: Added.
+
+2009-06-03 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Enabling debugger requires that Scripts panel is already attached to the
+ render tree. The reason is that recompile events result in script sources
+ being added into the source frames. Prior to the global options introduced,
+ debugger was enabled from the Scripts panel, so that it was guaranteed to
+ exist. The InspectorController::enableDebugger API calls with no inspector
+ frontend showing were failing though.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26145
+
+ * WebCore.base.exp:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::scriptObjectReady):
+ (WebCore::InspectorController::enableDebuggerFromFrontend):
+ (WebCore::InspectorController::enableDebugger):
+ * inspector/InspectorController.h:
+ * inspector/InspectorController.idl:
+ * inspector/InspectorFrontend.cpp:
+ (WebCore::InspectorFrontend::attachDebuggerWhenShown):
+ * inspector/InspectorFrontend.h:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.show):
+ (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
+ * inspector/front-end/inspector.js:
+ (WebInspector.attachDebuggerWhenShown):
+
+2009-06-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - fix a regression from the previous patch
+
+ * platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.
+
+2009-06-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - eliminate WebCoreTextRenderer
+
+ * WebCore.base.exp: Updated.
+ * WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
+ and promoted WebFontCache.h to private.
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::setShouldUseSmoothing): Added this static setter for
+ a new file-static boolean.
+ (WebCore::Font::shouldUseSmoothing): Added this static getter.
+ * platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
+ shouldUseSmoothing().
+ * platform/graphics/mac/FontMac.mm:
+ (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of
+ WebCoreShouldUseFontSmoothing().
+ * platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
+ * platform/mac/WebCoreTextRenderer.h: Removed.
+ * platform/mac/WebCoreTextRenderer.mm: Removed.
+
+2009-06-03 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ v8's ScriptController::evaluate should protect the Frame like the jsc version.
+ https://bugs.webkit.org/show_bug.cgi?id=26172
+
+ This change is simply copying protections done for Frame in the method
+ WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.
+
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+
+2009-06-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix <rdar://problem/6841120> Use CTFontManager notifications instead
+ of ATS notifications
+
+ * platform/graphics/FontCache.h: Made it an error to destroy a
+ FontCache instance.
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added
+ this notification callback for the
+ kCTFontManagerRegisteredFontsChangedNotification, which calls
+ invalidate().
+ (WebCore::FontCache::platformInit): Register for
+ kCTFontManagerRegisteredFontsChangedNotification.
+
+2009-06-03 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26161
+
+ * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
+ (WebCore::drawTextWithSpacing):
+
+2009-06-03 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Reorder ResourcesPanel components initialization to unfreeze resource list scroller.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26159
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel):
+
+2009-06-03 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ - Fix for crash (preceded by assertion) in InspectorController::didCommitLoad
+ when reloading or navigating with the Inspector open.
+ - Fix for Inspector's Elements panel being empty when Inspector first appears.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26134
+ https://bugs.webkit.org/show_bug.cgi?id=26135
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::scriptObjectReady):
+ (WebCore::InspectorController::didLoadResourceFromMemoryCache):
+ (WebCore::InspectorController::identifierForInitialRequest):
+ (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
+ * inspector/InspectorController.h:
+
+2009-06-03 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r44379
+
+ * svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the
+ other #includes to fix a compiler warning on Windows.
+
+2009-06-02 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Add workaround for crash in Linux Flash Player when hosted by
+ another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
+ issue (FP-2140).
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::setNPWindowIfNeeded):
+
+2009-06-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Refactor the Qt plugin code to use NPP_SetWindow correctly,
+ to make resizing of plugins work.
+
+ Attention was paid to make sure that the windowed plugins scroll
+ synchronized with the page view. A manual test has been added.
+
+ * manual-tests/qt/plugin-iframe.html: Added.
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::setFrameRect):
+ (WebCore::PluginView::frameRectsChanged):
+ * plugins/PluginView.h:
+ * plugins/qt/PluginContainerQt.cpp:
+ (PluginContainerQt::PluginContainerQt):
+ * plugins/qt/PluginContainerQt.h:
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::load):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::setParent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::setNPWindowIfNeeded):
+ (WebCore::PluginView::handlePostReadFile):
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::invalidateRect):
+ (WebCore::PluginView::init):
+
+2009-06-02 Darin Adler <darin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Bug 26112: viewless WebKit -- make events work
+ https://bugs.webkit.org/show_bug.cgi?id=26112
+
+ The main fix here is to make mouse and wheel event coordinates in the coordinate
+ system of the top level NSView rather than the NSWindow when in the viewless mode.
+ This is the design Hyatt chose, but the event part of it wasn't done yet.
+
+ Also fix FrameView to do normal reference counting instead of a strange model with
+ an explicit deref near creation time.
+
+ * WebCore.base.exp: Updated.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file
+ to reduce conditionals in the header.
+ (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
+
+ * page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types.
+ Made currentNSEvent a static member function. Added sendContextMenuEvent and
+ eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent
+ can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and
+ eventLoopHandleMouseDragged unconditional.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership.
+ (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove
+ the explicit deref.
+
+ * page/Frame.h: Changed setView to take a PassRefPtr.
+
+ * page/FrameTree.cpp: Added newly-needed include.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed
+ the initialization of m_refCount and call to show from the reamining one.
+ (WebCore::FrameView::create): Added two create functions that do what the two
+ constructors did before, except that they return a PassRefPtr to make sure the
+ reference counting is handled correctly.
+ (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented
+ its own reference counting.
+
+ * page/FrameView.h: Inherit from RefCounted for reference counting. Made the
+ constructor private and added create functions. Got rid of the hand-implemented
+ reference counting in this class.
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to
+ make it more clear how it relates to currentNSEvent.
+ (WebCore::EventHandler::currentNSEvent): Updated.
+ (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the
+ current event in a foolproof way.
+ (WebCore::CurrentEventScope::~CurrentEventScope): Ditto.
+ (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform
+ window in when constructing the PlatformWheelEvent.
+ (WebCore::EventHandler::keyEvent): Use CurrentEventScope.
+ (WebCore::lastEventIsMouseUp): Use currentNSEvent.
+ (WebCore::EventHandler::passMouseDownEventToWidget): Ditto.
+ (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
+ (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto.
+ (WebCore::EventHandler::passSubframeEventToSubframe): Use
+ currentPlatformMouseEvent to get a mouse event that has the appropriate
+ platform window passed to create it.
+ (WebCore::EventHandler::passWheelEventToWidget): Ditto.
+ (WebCore::EventHandler::mouseDown): Ditto.
+ (WebCore::EventHandler::mouseDragged): Ditto.
+ (WebCore::EventHandler::mouseUp): Ditto.
+ (WebCore::EventHandler::mouseMoved): Ditto.
+ (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the
+ platform window that's now needed to create a PlatformMouseEvent.
+ (WebCore::EventHandler::sendContextMenuEvent): Added.
+ (WebCore::EventHandler::eventMayStartDrag): Added.
+
+ * platform/HostWindow.h: Removed unneeded includes and constructor definition.
+
+ * platform/PlatformMouseEvent.h: Sorted things in alphabetical order.
+ Changed Mac constructor to take a windowView as well as the event. This is
+ needed in viewless mode, since the "window" is actually an NSView, so the
+ event has to know which view to compute the coordinates with. Made the
+ same change to pointForEvent.
+ * platform/PlatformWheelEvent.h: Ditto.
+
+ * platform/mac/PlatformMouseEventMac.mm:
+ (WebCore::pointForEvent): Convert point from window coordinates to view
+ coordinates if a windowView is passed in. This is used in viewless mode.
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
+ * platform/mac/WheelEventMac.mm:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.
+
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertFromContainingWindow): Fixed case where there
+ is no platform widget and no parent. Before it would yield unpredictable
+ results because of dispatching to a nil object and returning a structure.
+ Now it returns the point without changing coordinates at all, which is what
+ we need for this case in viewless mode.
+
+ * rendering/RenderApplet.cpp: Removed unneeded includes.
+ (WebCore::RenderApplet::intrinsicSize): Use widget function.
+ (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.
+
+ * rendering/RenderApplet.h: Make more things private. Get rid of unneeded
+ explicit destructor.
+
+ * rendering/RenderFrame.cpp: Removed unneeded includes.
+ (WebCore::RenderFrame::edgeInfo): Updated to use node function so header
+ doesn't have to define element function.
+ (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget
+ function.
+
+ * rendering/RenderFrame.h: Removed unneeded includes. Made some things
+ private. Got rid of element function.
+
+ * rendering/RenderPart.cpp: Removed unneeded includes.
+ (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function.
+ (WebCore::RenderPart::setWidget): Changed to use widget function.
+ (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget.
+ This is now only called by the clearWidget function.
+
+ * rendering/RenderPart.h: Removed unneeded forward declarations.
+ Made more functions private. Updated deleteWidget to take widget argument.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::~RenderPartObject): use frameView function
+ instead of getting at m_view directly.
+ (WebCore::RenderPartObject::updateWidget): Ditto.
+ (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget.
+ (WebCore::RenderPartObject::viewCleared): Ditto.
+
+ * rendering/RenderPartObject.h: Made some functions private.
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with
+ construction syntax instead of assignment.
+ (WebCore::RenderWidget::destroy): Updated for name change of m_view
+ to m_frameView.
+ (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete
+ the widget.
+ (WebCore::RenderWidget::setWidget): Use clearWidget.
+ (WebCore::RenderWidget::paint): Updated for name change of m_view
+ to m_frameView.
+ (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.
+
+ * rendering/RenderWidget.h: Made many functions protected, others
+ private and made all data members private.
+
+ * svg/animation/SMILTime.h: Removed unhelpful max and min functions. These
+ just do what std::max and std::min will already do automatically for this
+ type, so they are not helpful.
+
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types
+ that initialize to zero without anything explicit.
+ (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are
+ no longer stored.
+ (WebCore::SVGImage::setContainerSize): Ditto.
+ (WebCore::SVGImage::usesContainerSize): Ditto.
+ (WebCore::SVGImage::size): Ditto.
+ (WebCore::SVGImage::hasRelativeWidth): Ditto.
+ (WebCore::SVGImage::hasRelativeHeight): Ditto.
+ (WebCore::SVGImage::draw): Ditto.
+ (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
+ (WebCore::SVGImage::dataChanged): Ditto.
+
+ * svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data
+ members m_document, m_frame, m_frameView, and m_minSize.
+
+2009-06-02 Adam Langley <agl@google.com>
+
+ Reviewed by Eric Seidel.
+
+ The previous code was assuming that we'll be painting buttons on the scrollbar
+ which isn't true on Linux. To reproduce, resize a page with scrollbars until
+ they are less than two widths high.
+
+ This will need pixel test baselines to be updated in the Chromium tree.
+
+ * platform/chromium/ScrollbarThemeChromium.cpp: move this function...
+ * platform/chromium/ScrollbarThemeChromiumWin.cpp:
+ (WebCore::ScrollbarThemeChromium::trackRect): ... to here
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which
+ doesn't remove the track when the scrollbar is less than two widths
+ high.
+
+2009-06-02 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
+
+ * Configurations/Base.xcconfig:
+
+2009-06-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Insert*List on an stand-alone image in a content editable region ASSERTS
+ ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
+ https://bugs.webkit.org/show_bug.cgi?id=19066
+
+ Attempt to fix this by noticing that we inserted the list inside
+ the selection which includes the image, and re-adjust the selection
+ to not include the list before trying to move the image into
+ the list item.
+
+ Test: editing/execCommand/list-wrapping-image-crash.html
+
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::doApply):
+
+2009-06-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Rename PositionIterator members in hope of further clarity
+ https://bugs.webkit.org/show_bug.cgi?id=24854
+
+ Rename m_parent to m_anchorNode (since although it's always the parent
+ of the previous m_child member, it is not always the parent of the effective position)
+ Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
+ directly following the position. This member is often NULL, but is always
+ a child of m_parent, now m_anchorNode if set.
+ Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)
+
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::operator Position):
+ (WebCore::PositionIterator::increment):
+ (WebCore::PositionIterator::decrement):
+ (WebCore::PositionIterator::atStart):
+ (WebCore::PositionIterator::atEnd):
+ (WebCore::PositionIterator::atStartOfNode):
+ (WebCore::PositionIterator::atEndOfNode):
+ (WebCore::PositionIterator::isCandidate):
+ * dom/PositionIterator.h:
+ (WebCore::PositionIterator::PositionIterator):
+ (WebCore::PositionIterator::node):
+ (WebCore::PositionIterator::offsetInLeafNode):
+
+2009-06-02 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 17167: Failures in fast/dom/Node/initial-values.html
+
+ This partly solve a compatibility issue with other browsers. It will also
+ make us more consistent while handling XHTML element.
+
+ The issue is that when we create an XHTML element inside an HTML document
+ (as it is the case when calling createElementNS), we default to the HTML
+ behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
+ element, our fix is to check whether it has a prefix and then default
+ to XML behaviour for nodeName.
+
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::nodeName): Add a prefix check before
+ returning the uppercase tagName (HTML behaviour).
+
+2009-06-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add a compareBoundaryPoints which takes RangeBoundaryPoints
+ https://bugs.webkit.org/show_bug.cgi?id=25500
+
+ I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
+ This patch is almost entirely minus lines.
+
+ No functional changes, thus no tests.
+
+ * dom/Range.cpp:
+ (WebCore::Range::setStart):
+ (WebCore::Range::setEnd):
+ (WebCore::Range::compareBoundaryPoints):
+ (WebCore::Range::boundaryPointsValid):
+ * dom/Range.h:
+
+2009-06-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
+ https://bugs.webkit.org/show_bug.cgi?id=25500
+
+ Darin indicated the Range should deal only with primitive DOM node/offset
+ pairs, and that Position (which is a more robust editing construct) should have
+ its own comparison functions and that Range.h should not mention Position at all.
+
+ Turns out that Position already has a comparePositions() function (which knows
+ how to additionally handled positions in shadow trees). So I've just changed
+ all callers of compareBoundaryPoints(Position, Position) to use the existing
+ comparePositions() function. I've also added a comparePositions which takes
+ VisiblePositions for convenience.
+
+ * dom/Range.cpp:
+ * dom/Range.h:
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::updateStartEnd):
+ (WebCore::ApplyStyleCommand::applyBlockStyle):
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::applyInlineStyle):
+ (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
+ (WebCore::ApplyStyleCommand::removeInlineStyle):
+ (WebCore::ApplyStyleCommand::nodeFullySelected):
+ (WebCore::ApplyStyleCommand::nodeFullyUnselected):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::deleteInsignificantText):
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::initializeStartEnd):
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+ (WebCore::DeleteSelectionCommand::mergeParagraphs):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::nodeWillBeRemoved):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::toNormalizedRange):
+ * editing/htmlediting.cpp:
+ (WebCore::comparePositions):
+ * editing/htmlediting.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+
+2009-06-02 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26122
+ Upstream v8_utility.h functions into V8Utilities.h. This patch has
+ some transitional code to make upstreaming easier. This code will
+ be deleted in a few days.
+
+ * bindings/v8/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
+ * bindings/v8/V8Utilities.h:
+ (WebCore::AllowAllocation::AllowAllocation): Function added.
+ (WebCore::AllowAllocation::~AllowAllocation): Function added.
+ (WebCore::SafeAllocation::NewInstance): Function added.
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
+ NewInstance -> newInstance.
+ (WebCore::WorkerContextExecutionProxy::toV8): NewInstance ->
+ newInstance.
+
+2009-06-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix <rdar://problem/6940747> Search field’s focus ring is outset
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused
+ search field outline offset to -2.
+
+2009-06-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add list of unimplemented event handlers to DOMWindow.
+
+ * page/DOMWindow.idl:
+
+2009-06-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26133
+ Adapt and import py-dom-xpath tests
+
+ Tests: fast/xpath/py-dom-xpath/abbreviations.html
+ fast/xpath/py-dom-xpath/axes.html
+ fast/xpath/py-dom-xpath/data.html
+ fast/xpath/py-dom-xpath/expressions.html
+ fast/xpath/py-dom-xpath/functions.html
+ fast/xpath/py-dom-xpath/nodetests.html
+ fast/xpath/py-dom-xpath/paths.html
+ fast/xpath/py-dom-xpath/predicates.html
+
+ Fix bugs found with this test suite:
+ - name and local-name were incorrect for processing instructions (XPath expanded-name
+ doesn't match DOM exactly);
+ - name, local-name and namespace functions should crash on attribute nodes;
+ - attemps to make node sets from other types were not detected as errors.
+
+ No performance impact.
+
+ * xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation.
+ An error won't stop evaluation, but an exception will be raised afterwards. We could also
+ detect conversion errors at compile time, but not if we're going to support XPath variables
+ (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own
+ XSLT one day).
+
+ * xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type
+ conversion exception occurred during evaluation, and raise an excpetion if it did.
+
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::expandedNameLocalPart):
+ (WebCore::XPath::expandedName):
+ XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name,
+ which doesn't match anything available via DOM exactly. Calculate the expanded name properly.
+ (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an
+ attribute node, because it released what was possibly the only reference to attribute node
+ before using it. Changed the function to avoid such situation.
+ (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart()
+ to work properly with processing instruction nodes.
+ (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()).
+ (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set
+ (by using toNodeSet unconditionally, which will raise an error, and return an empty set).
+
+ * xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression
+ evaluation result is not a node-set.
+
+ * xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually
+ always a node-set (this is not so for FilterExpr production in the spec, but is for us,
+ because we don't naively map BNF productions to classes).
+
+ * xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side
+ is not a node-set.
+
+ * xml/XPathStep.cpp: Removed an unnecesary include.
+
+ * xml/XPathValue.cpp:
+ (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails.
+ (WebCore::XPath::Value::modifiableNodeSet): Ditto.
+ (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production
+ (in particular, those using exponential notation).
+
+2009-06-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Brady Eidson.
+
+ Part of https://bugs.webkit.org/show_bug.cgi?id=26100
+ Add missing event handler properties to the DOMWindow
+
+ Added oncontextmenu, oninput, and onmessage event handlers to
+ the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
+ and onsuspend event handlers were implemented but not added to
+ DOMWindow.idl.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::oninput):
+ (WebCore::DOMWindow::setOninput):
+ (WebCore::DOMWindow::onmessage):
+ (WebCore::DOMWindow::setOnmessage):
+ (WebCore::DOMWindow::oncontextmenu):
+ (WebCore::DOMWindow::setOncontextmenu):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-06-01 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Darin Adler. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26123
+
+ Remove a redundant checkEncodedString call when constructing a
+ KURL object from a string.
+
+ * platform/KURL.cpp:
+ (WebCore::KURL::KURL):
+
+2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
+ Bad Dimitri.
+
+ * platform/KeyboardCodes.h: Repositioned the guard to avoid nested
+ WebCore namespace declarations.
+
+2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ * platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h
+ with a stern FIXME.
+ * platform/chromium/KeyboardCodes.h: Removed.
+
+2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix assertion error in --filters enabled debug builds.
+ Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.
+
+ * svg/graphics/filters/SVGFilterBuilder.cpp:
+ (WebCore::SVGFilterBuilder::SVGFilterBuilder):
+ (WebCore::SVGFilterBuilder::add):
+ (WebCore::SVGFilterBuilder::getEffectById):
+ * svg/graphics/filters/SVGFilterBuilder.h:
+
+2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix --filters enabled build on Mac.
+ Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
+ Kill several warnings, to make build pass.
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::paint):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::paint):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::paint):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ * rendering/SVGRenderSupport.h:
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
+ * svg/SVGFEGaussianBlurElement.cpp:
+ (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::FEFlood):
+
+2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ Fix Chromium build by adding an #ifdef, restoring the code path to that
+ before http://trac.webkit.org/changeset/44287.
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.
+
+2009-06-01 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Remove last pieces of the old SVG filter system. They are not
+ usable with our current filter system. The new filter effects
+ will replace the functionality step by step.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/graphics/cairo: Removed.
+ * svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
+ * svg/graphics/cg: Removed.
+ * svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
+ * svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
+ * svg/graphics/filters/SVGFilterEffect.cpp: Removed.
+ * svg/graphics/filters/SVGFilterEffect.h: Removed.
+ * svg/graphics/filters/cg: Removed.
+ * svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
+ * svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
+ * svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
+ * svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
+ * svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
+ * svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
+ * svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
+ * svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
+ * svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
+ * svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
+ * svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
+ * svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
+ * svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
+ * svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
+ * svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
+ * svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
+ * svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
+ * svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
+ * svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
+ * svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
+ * svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
+ * svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
+ * svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
+ * svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
+ * svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
+ * svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
+ * svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
+ * svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
+ * svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
+ * svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
+ * svg/graphics/mac: Removed.
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
+ * svg/graphics/qt: Removed.
+ * svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
+ * svg/graphics/skia: Removed.
+ * svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.
+
+2009-06-01 Dmitry Titov <dimich@chromium.org>
+
+ Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
+ This adds a comment suggested during review.
+
+ * platform/ThreadGlobalData.cpp:
+ (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.
+
+2009-06-01 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25973
+ Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
+ Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
+ for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
+ the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
+ the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
+ in establishIdentifierForPthreadHandle() since the id is already in the map.
+
+ The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
+ on OSX Chromium and will stop failing after this change.
+
+ * platform/ThreadGlobalData.h:
+ * platform/ThreadGlobalData.cpp:
+ (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ Store the result of "isMainThread()" in a member variable during construction of thread-specific data
+ to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.
+
+2009-06-01 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Alder and Maciej Stachowiak.
+
+ Bug 26057: StringImpl should share buffers with UString.
+ https://bugs.webkit.org/show_bug.cgi?id=26057
+
+ This change results in the following performance improvements:
+ On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
+ the time went from 78ms to 40ms for append (other times remained constant).
+
+ On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
+ the time went from 3900ms to 2600ms.
+
+ For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
+ Other tests in dom seemed to be faster across several runs but within the
+ margin of error (except DOM Attributes which was slightly ~1.5% worse).
+
+ Existing tests cover this code and there is no new functionality
+ that is exposed to test.
+
+ * platform/text/AtomicString.cpp:
+ (WebCore::AtomicString::add):
+ * platform/text/String.cpp:
+ (WebCore::String::String):
+ (WebCore::String::operator UString):
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::StringImpl):
+ (WebCore::StringImpl::~StringImpl):
+ (WebCore::StringImpl::create): Consumes a shared buffer.
+ (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString.
+ (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
+ * platform/text/StringImpl.h:
+ (WebCore::StringImpl::hasTerminatingNullCharacter):
+ (WebCore::StringImpl::inTable):
+ (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags
+ to avoid growing StringImpl in size.
+
+2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ V8 bindings follow-up to to DOMWindow-related cleanup:
+ http://trac.webkit.org/changeset/44215
+
+ * bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated
+ its body to destructor.
+ * bindings/v8/ScriptController.h: Removed disconnectFrame() decl.
+
+2009-05-28 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ - Add panel enabler to the resources panel.
+ - Add session / always options into the panel enabler.
+ - Make enabled status for three panels sticky (globally).
+ - Persist enabled status using InspectorController::Settings
+ - Make InspectorController produce no network-related overhead when
+ resources panel is not enabled.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26046
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::populateScriptObjects):
+ (WebCore::InspectorController::identifierForInitialRequest):
+ (WebCore::InspectorController::willSendRequest):
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didReceiveContentLength):
+ (WebCore::InspectorController::didFinishLoading):
+ (WebCore::InspectorController::didFailLoading):
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
+ (WebCore::InspectorController::scriptImported):
+ (WebCore::InspectorController::enableResourceTracking):
+ (WebCore::InspectorController::disableResourceTracking):
+ (WebCore::InspectorController::startUserInitiatedProfiling):
+ (WebCore::InspectorController::enableProfiler):
+ (WebCore::InspectorController::disableProfiler):
+ (WebCore::InspectorController::enableDebugger):
+ (WebCore::InspectorController::disableDebugger):
+ * inspector/InspectorController.h:
+ (WebCore::InspectorController::Setting::Setting):
+ (WebCore::InspectorController::resourceTrackingEnabled):
+ * inspector/InspectorController.idl:
+ * inspector/InspectorFrontend.cpp:
+ (WebCore::InspectorFrontend::resourceTrackingWasEnabled):
+ (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
+ * inspector/InspectorFrontend.h:
+ * inspector/front-end/PanelEnablerView.js:
+ (WebInspector.PanelEnablerView.enableOption):
+ (WebInspector.PanelEnablerView):
+ (WebInspector.PanelEnablerView.prototype._windowResized):
+ (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype._enableProfiling):
+ (WebInspector.ProfilesPanel.prototype._toggleProfiling):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel):
+ (WebInspector.ResourcesPanel.prototype.get statusBarItems):
+ (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
+ (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled):
+ (WebInspector.ResourcesPanel.prototype.reset):
+ (WebInspector.ResourcesPanel.prototype._updateSidebarWidth):
+ (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
+ (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._enableDebugging):
+ (WebInspector.ScriptsPanel.prototype._toggleDebugging):
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/inspector.js:
+ (WebInspector.resourceTrackingWasEnabled):
+ (WebInspector.resourceTrackingWasDisabled):
+
+2009-06-01 Drew Wilson <atwilson@google.com>
+
+ Reviewed by Darin Adler. Landed (and tweaked) by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25902
+
+ Added WorkerContext.close()
+
+ Test: fast/workers/worker-close.html
+
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::close):
+ * workers/WorkerContext.h:
+ * workers/WorkerContext.idl:
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
+
+2009-06-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=12471
+ XPathResult not invalidated for documents retrieved via XMLHttpRequest
+
+ Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.
+
+ Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
+ reliable and much faster.
+
+ * xml/XPathExpression.cpp:
+ (WebCore::XPathExpression::evaluate):
+ * xml/XPathResult.cpp:
+ (WebCore::XPathResult::XPathResult):
+ (WebCore::XPathResult::~XPathResult):
+ (WebCore::XPathResult::invalidIteratorState):
+ (WebCore::XPathResult::iterateNext):
+ * xml/XPathResult.h:
+ (WebCore::XPathResult::create):
+
+2009-06-01 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Adler. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25750
+
+ Test: fast/transforms/bounding-rect-zoom.html
+
+ Make getClientRects and getBoundingClientRect account for ther zoom
+ factor.
+
+ * dom/Element.cpp:
+ (WebCore::adjustFloatPointForAbsoluteZoom):
+ (WebCore::adjustFloatQuadForAbsoluteZoom):
+ (WebCore::adjustIntRectForAbsoluteZoom):
+ (WebCore::Element::getClientRects):
+ (WebCore::Element::getBoundingClientRect):
+
+2009-06-01 Tony Chang <tony@chromium.org>
+
+ Reviewed by Dimitri Glazkov. Landed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26026
+
+ Fix an infinite loop when using the keyboard in Chromium select
+ popups.
+
+ Not testable since it involves sending a keyboard event to
+ the popup, which is not possible (eventSender sends the key
+ events through webview, we want to go through the webwidget).
+
+ * platform/chromium/PopupMenuChromium.cpp:
+
+2009-06-01 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov. Landed by Adam Barth.
+
+ If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
+ has finished loading compeltely or the user has manually scrolled. Refreshing an anchor url after
+ scrolling to a new location on the page will still result in jumping to the new location.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26034
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor.
+ (WebCore::FrameLoader::completed): Release anchor lock.
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView): Ensure anchor lock starts unset.
+ (WebCore::FrameView::reset): Ensure anchor lock starts unset.
+ (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout.
+ (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins.
+ (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls.
+ (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
+ * page/FrameView.h:
+ (WebCore::FrameView::lockedToAnchor): Added.
+ (WebCore::FrameView::setLockedToAnchor): Added.
+
+2009-05-31 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ A short clean-up. FilterBuilder is SVG specific. Move it
+ to svg/graphics/filters and rename it to SVGFilterBuilder.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/FilterBuilder.cpp: Removed.
+ * svg/FilterBuilder.h: Removed.
+ * svg/SVGFilterElement.cpp:
+ * svg/SVGFilterPrimitiveStandardAttributes.h:
+ * svg/graphics/SVGResourceFilter.cpp:
+ (WebCore::SVGResourceFilter::SVGResourceFilter):
+ * svg/graphics/SVGResourceFilter.h:
+ (WebCore::SVGResourceFilter::builder):
+ * svg/graphics/filters/SVGFilterBuilder.cpp: Added.
+ (WebCore::SVGFilterBuilder::SVGFilterBuilder):
+ (WebCore::SVGFilterBuilder::add):
+ (WebCore::SVGFilterBuilder::getEffectById):
+ (WebCore::SVGFilterBuilder::clearEffects):
+ * svg/graphics/filters/SVGFilterBuilder.h: Added.
+ (WebCore::SVGFilterBuilder::lastEffect):
+
+2009-05-31 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13233
+ Need to implement an optimizing XPath evaluator
+
+ Avoid sorting results of hierarchical paths that are naturally sorted. On a flat data structure
+ with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
+ to 33 ms.
+
+ * xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint,
+ which is useful for optimization.
+ (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one.
+ (WebCore::XPath::NodeSet::operator=): Ditto.
+ (WebCore::XPath::NodeSet::swap): Ditto.
+ (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort()
+ was never called.
+ (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is
+ maintained by callers.
+ (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree.
+ Currently, the only way for a set to gain this flag is to be produced from a single element
+ set with a hierarchical location path.
+
+ * xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid
+ maintaining a set of unique nodes, and to avoid sorting the result.
+
+2009-05-31 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13233
+ Need to implement an optimizing XPath evaluator
+
+ This patch adds some infrastructure and simple optimizations. Namely,
+ - we now avoid building a full NodeSet just to evaluate a predicate in some cases;
+ - "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;
+
+ * xml/XPathExpressionNode.cpp:
+ (WebCore::XPath::Expression::Expression):
+ * xml/XPathExpressionNode.h:
+ (WebCore::XPath::Expression::addSubExpression):
+ (WebCore::XPath::Expression::isContextNodeSensitive):
+ (WebCore::XPath::Expression::isContextPositionSensitive):
+ (WebCore::XPath::Expression::isContextSizeSensitive):
+ (WebCore::XPath::Expression::setIsContextNodeSensitive):
+ (WebCore::XPath::Expression::setIsContextPositionSensitive):
+ (WebCore::XPath::Expression::setIsContextSizeSensitive):
+ XPath expression now knows its result type, and whether evaluation depends on context.
+
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::FunLast::resultType):
+ (WebCore::XPath::FunLast::FunLast):
+ (WebCore::XPath::FunPosition::resultType):
+ (WebCore::XPath::FunPosition::FunPosition):
+ (WebCore::XPath::FunCount::resultType):
+ (WebCore::XPath::FunId::resultType):
+ (WebCore::XPath::FunLocalName::resultType):
+ (WebCore::XPath::FunLocalName::FunLocalName):
+ (WebCore::XPath::FunNamespaceURI::resultType):
+ (WebCore::XPath::FunNamespaceURI::FunNamespaceURI):
+ (WebCore::XPath::FunName::resultType):
+ (WebCore::XPath::FunName::FunName):
+ (WebCore::XPath::FunString::resultType):
+ (WebCore::XPath::FunString::FunString):
+ (WebCore::XPath::FunConcat::resultType):
+ (WebCore::XPath::FunStartsWith::resultType):
+ (WebCore::XPath::FunContains::resultType):
+ (WebCore::XPath::FunSubstringBefore::resultType):
+ (WebCore::XPath::FunSubstringAfter::resultType):
+ (WebCore::XPath::FunSubstring::resultType):
+ (WebCore::XPath::FunStringLength::resultType):
+ (WebCore::XPath::FunStringLength::FunStringLength):
+ (WebCore::XPath::FunNormalizeSpace::resultType):
+ (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace):
+ (WebCore::XPath::FunTranslate::resultType):
+ (WebCore::XPath::FunBoolean::resultType):
+ (WebCore::XPath::FunNot::resultType):
+ (WebCore::XPath::FunTrue::resultType):
+ (WebCore::XPath::FunFalse::resultType):
+ (WebCore::XPath::FunLang::resultType):
+ (WebCore::XPath::FunLang::FunLang):
+ (WebCore::XPath::FunNumber::resultType):
+ (WebCore::XPath::FunNumber::FunNumber):
+ (WebCore::XPath::FunSum::resultType):
+ (WebCore::XPath::FunFloor::resultType):
+ (WebCore::XPath::FunCeiling::resultType):
+ (WebCore::XPath::FunRound::resultType):
+ (WebCore::XPath::Function::setArguments):
+ Set optimization details for the expression. Normally, a function does not introduce context
+ node set dependency, but some use context node as default argument, or otherwise use the context.
+
+ * xml/XPathFunctions.h: Tweaked style.
+
+ * xml/XPathPath.cpp:
+ (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is.
+ (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive,
+ and only if the path relative.
+ (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations.
+ (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
+ (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
+
+ * xml/XPathPath.h:
+ (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression
+ (useful filters return NodeSets, of course).
+ (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set
+ insensitive.
+ (WebCore::XPath::LocationPath::resultType): A path's result is always a node set.
+ (WebCore::XPath::Path::resultType): Ditto.
+
+ * xml/XPathPredicate.h:
+ (WebCore::XPath::Number::resultType): Return a proper result type.
+ (WebCore::XPath::StringExpression::resultType): Ditto.
+ (WebCore::XPath::Negative::resultType): Ditto.
+ (WebCore::XPath::NumericOp::resultType): Ditto.
+ (WebCore::XPath::EqTestOp::resultType): Ditto.
+ (WebCore::XPath::LogicalOp::resultType): Ditto.
+ (WebCore::XPath::Union::resultType): Ditto.
+ (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position
+ sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5].
+ (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
+
+ * xml/XPathStep.h:
+ (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously
+ borrowed from XPath 2.0 to express some optimizations.
+ (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and
+ filtering it with predicates, we now try to apply predicates while enumerating an axis.
+ (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
+
+ * xml/XPathStep.cpp:
+ (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still
+ possible to copy NodeTests.
+ (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible.
+ (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "//".
+ (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only
+ possible if there are no context sensitive predicates for "//".
+ (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate.
+ (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring
+ merged predicates.
+ (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position.
+ (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code
+ path.
+
+ * xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable
+ references are not used with XPathEvaluator, so we'll only need them if we decide to
+ reimplement XSLT. The type of variable reference is not known at compile time.
+
+2009-05-31 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Remove unused JSEventTargetBase.h
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSEventTargetBase.h: Removed.
+
+2009-05-31 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Part of https://bugs.webkit.org/show_bug.cgi?id=26100
+ Add missing event handler properties to the DOMWindow
+
+ Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
+ onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
+ onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
+ onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
+ ondragend, ondragenter, ondragleave, ondragover, ondragstart and
+ ondrop event handlers to the DOMWindow.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::ondrag):
+ (WebCore::DOMWindow::setOndrag):
+ (WebCore::DOMWindow::ondragend):
+ (WebCore::DOMWindow::setOndragend):
+ (WebCore::DOMWindow::ondragenter):
+ (WebCore::DOMWindow::setOndragenter):
+ (WebCore::DOMWindow::ondragleave):
+ (WebCore::DOMWindow::setOndragleave):
+ (WebCore::DOMWindow::ondragover):
+ (WebCore::DOMWindow::setOndragover):
+ (WebCore::DOMWindow::ondragstart):
+ (WebCore::DOMWindow::setOndragstart):
+ (WebCore::DOMWindow::ondrop):
+ (WebCore::DOMWindow::setOndrop):
+ (WebCore::DOMWindow::oncanplay):
+ (WebCore::DOMWindow::setOncanplay):
+ (WebCore::DOMWindow::oncanplaythrough):
+ (WebCore::DOMWindow::setOncanplaythrough):
+ (WebCore::DOMWindow::ondurationchange):
+ (WebCore::DOMWindow::setOndurationchange):
+ (WebCore::DOMWindow::onemptied):
+ (WebCore::DOMWindow::setOnemptied):
+ (WebCore::DOMWindow::onended):
+ (WebCore::DOMWindow::setOnended):
+ (WebCore::DOMWindow::onloadeddata):
+ (WebCore::DOMWindow::setOnloadeddata):
+ (WebCore::DOMWindow::onloadedmetadata):
+ (WebCore::DOMWindow::setOnloadedmetadata):
+ (WebCore::DOMWindow::onpause):
+ (WebCore::DOMWindow::setOnpause):
+ (WebCore::DOMWindow::onplay):
+ (WebCore::DOMWindow::setOnplay):
+ (WebCore::DOMWindow::onplaying):
+ (WebCore::DOMWindow::setOnplaying):
+ (WebCore::DOMWindow::onratechange):
+ (WebCore::DOMWindow::setOnratechange):
+ (WebCore::DOMWindow::onseeked):
+ (WebCore::DOMWindow::setOnseeked):
+ (WebCore::DOMWindow::onseeking):
+ (WebCore::DOMWindow::setOnseeking):
+ (WebCore::DOMWindow::ontimeupdate):
+ (WebCore::DOMWindow::setOntimeupdate):
+ (WebCore::DOMWindow::onvolumechange):
+ (WebCore::DOMWindow::setOnvolumechange):
+ (WebCore::DOMWindow::onwaiting):
+ (WebCore::DOMWindow::setOnwaiting):
+ (WebCore::DOMWindow::onloadstart):
+ (WebCore::DOMWindow::setOnloadstart):
+ (WebCore::DOMWindow::onprogress):
+ (WebCore::DOMWindow::setOnprogress):
+ (WebCore::DOMWindow::onstalled):
+ (WebCore::DOMWindow::setOnstalled):
+ (WebCore::DOMWindow::onsuspend):
+ (WebCore::DOMWindow::setOnsuspend):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-05-31 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Part of https://bugs.webkit.org/show_bug.cgi?id=26100
+ Add missing event handler properties to the DOMWindow
+
+ Add missing onstorage event handler to the DOMWindow.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::onstorage):
+ (WebCore::DOMWindow::setOnstorage):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-05-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
+ Update online/offline events to match the current spec.
+ - Also adds window.ononline and window.onoffline event handler
+ properties.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::onoffline):
+ (WebCore::DOMWindow::setOnoffline):
+ (WebCore::DOMWindow::ononline):
+ (WebCore::DOMWindow::setOnonline):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+
+2009-05-31 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
+ and replace it by a platform independent code. Calculation of subRegions
+ is missing but needed for a first filter effect.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/filters/Filter.h:
+ (WebCore::Filter::~Filter):
+ (WebCore::Filter::setSourceImage):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::prepareToRenderSVGContent):
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ * svg/FilterBuilder.h:
+ (WebCore::FilterBuilder::lastEffect):
+ * svg/SVGFEBlendElement.cpp:
+ (WebCore::SVGFEBlendElement::SVGFEBlendElement):
+ (WebCore::SVGFEBlendElement::build):
+ * svg/SVGFEBlendElement.h:
+ * svg/SVGFEColorMatrixElement.cpp:
+ (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
+ (WebCore::SVGFEColorMatrixElement::build):
+ * svg/SVGFEColorMatrixElement.h:
+ * svg/SVGFEComponentTransferElement.cpp:
+ (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
+ (WebCore::SVGFEComponentTransferElement::build):
+ * svg/SVGFEComponentTransferElement.h:
+ * svg/SVGFECompositeElement.cpp:
+ (WebCore::SVGFECompositeElement::SVGFECompositeElement):
+ (WebCore::SVGFECompositeElement::build):
+ * svg/SVGFECompositeElement.h:
+ * svg/SVGFEDiffuseLightingElement.cpp:
+ (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
+ (WebCore::SVGFEDiffuseLightingElement::build):
+ * svg/SVGFEDiffuseLightingElement.h:
+ * svg/SVGFEDisplacementMapElement.cpp:
+ (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
+ (WebCore::SVGFEDisplacementMapElement::build):
+ * svg/SVGFEDisplacementMapElement.h:
+ * svg/SVGFEFloodElement.cpp:
+ (WebCore::SVGFEFloodElement::SVGFEFloodElement):
+ (WebCore::SVGFEFloodElement::build):
+ * svg/SVGFEFloodElement.h:
+ * svg/SVGFEGaussianBlurElement.cpp:
+ (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
+ (WebCore::SVGFEGaussianBlurElement::build):
+ * svg/SVGFEGaussianBlurElement.h:
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::SVGFEImageElement):
+ (WebCore::SVGFEImageElement::notifyFinished):
+ (WebCore::SVGFEImageElement::build):
+ * svg/SVGFEImageElement.h:
+ * svg/SVGFEMergeElement.cpp:
+ (WebCore::SVGFEMergeElement::SVGFEMergeElement):
+ (WebCore::SVGFEMergeElement::build):
+ * svg/SVGFEMergeElement.h:
+ * svg/SVGFEOffsetElement.cpp:
+ (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
+ (WebCore::SVGFEOffsetElement::build):
+ * svg/SVGFEOffsetElement.h:
+ * svg/SVGFESpecularLightingElement.cpp:
+ (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
+ (WebCore::SVGFESpecularLightingElement::build):
+ * svg/SVGFESpecularLightingElement.h:
+ * svg/SVGFETileElement.cpp:
+ (WebCore::SVGFETileElement::SVGFETileElement):
+ (WebCore::SVGFETileElement::build):
+ * svg/SVGFETileElement.h:
+ * svg/SVGFETurbulenceElement.cpp:
+ (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
+ (WebCore::SVGFETurbulenceElement::build):
+ * svg/SVGFETurbulenceElement.h:
+ * svg/SVGFilterElement.cpp:
+ (WebCore::SVGFilterElement::canvasResource):
+ * svg/SVGFilterPrimitiveStandardAttributes.cpp:
+ (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
+ * svg/SVGFilterPrimitiveStandardAttributes.h:
+ (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
+ * svg/graphics/SVGResourceFilter.cpp:
+ (WebCore::SVGResourceFilter::SVGResourceFilter):
+ (WebCore::SVGResourceFilter::addFilterEffect):
+ (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
+ (WebCore::SVGResourceFilter::prepareFilter):
+ (WebCore::SVGResourceFilter::applyFilter):
+ (WebCore::SVGResourceFilter::externalRepresentation):
+ * svg/graphics/SVGResourceFilter.h:
+ (WebCore::SVGResourceFilter::filterBoundingBox):
+ (WebCore::SVGResourceFilter::setFilterBoundingBox):
+ (WebCore::SVGResourceFilter::itemBoundingBox):
+ (WebCore::SVGResourceFilter::setItemBoundingBox):
+ (WebCore::SVGResourceFilter::builder):
+
+2009-05-31 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
+ This change helps creating test cases, once filters are activated.
+
+ * svg/SVGFEFloodElement.cpp:
+ (WebCore::SVGFEFloodElement::SVGFEFloodElement):
+ (WebCore::SVGFEFloodElement::parseMappedAttribute):
+ (WebCore::SVGFEFloodElement::build):
+ * svg/SVGFEFloodElement.h:
+ * svg/SVGFEFloodElement.idl:
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::FEFlood):
+ (WebCore::FEFlood::create):
+ * svg/graphics/filters/SVGFEFlood.h:
+
+2009-05-31 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ Replace all occurrences of SVGResourceFilter by Filter. This is the last
+ step for a SVG independent filter system. Every other part of WebCore can
+ use the filter system by creating a new Filter object.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/filters/FEBlend.cpp:
+ (WebCore::FEBlend::apply):
+ * platform/graphics/filters/FEBlend.h:
+ * platform/graphics/filters/FEColorMatrix.cpp:
+ (WebCore::FEColorMatrix::apply):
+ * platform/graphics/filters/FEColorMatrix.h:
+ * platform/graphics/filters/FEComponentTransfer.cpp:
+ (WebCore::FEComponentTransfer::apply):
+ * platform/graphics/filters/FEComponentTransfer.h:
+ * platform/graphics/filters/FEComposite.cpp:
+ (WebCore::FEComposite::apply):
+ * platform/graphics/filters/FEComposite.h:
+ * platform/graphics/filters/Filter.h: Added.
+ (WebCore::Filter::setSourceImage):
+ (WebCore::Filter::sourceImage):
+ * platform/graphics/filters/FilterEffect.h:
+ * platform/graphics/filters/SourceAlpha.cpp:
+ (WebCore::SourceAlpha::apply):
+ * platform/graphics/filters/SourceAlpha.h:
+ * platform/graphics/filters/SourceGraphic.cpp:
+ (WebCore::SourceGraphic::apply):
+ * platform/graphics/filters/SourceGraphic.h:
+ * svg/Filter.cpp: Removed.
+ * svg/Filter.h: Removed.
+ * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
+ (WebCore::FEConvolveMatrix::apply):
+ * svg/graphics/filters/SVGFEConvolveMatrix.h:
+ * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
+ (WebCore::FEDiffuseLighting::apply):
+ * svg/graphics/filters/SVGFEDiffuseLighting.h:
+ * svg/graphics/filters/SVGFEDisplacementMap.cpp:
+ (WebCore::FEDisplacementMap::apply):
+ * svg/graphics/filters/SVGFEDisplacementMap.h:
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::apply):
+ * svg/graphics/filters/SVGFEFlood.h:
+ * svg/graphics/filters/SVGFEGaussianBlur.cpp:
+ (WebCore::FEGaussianBlur::apply):
+ * svg/graphics/filters/SVGFEGaussianBlur.h:
+ * svg/graphics/filters/SVGFEImage.cpp:
+ (WebCore::FEImage::apply):
+ * svg/graphics/filters/SVGFEImage.h:
+ * svg/graphics/filters/SVGFEMerge.cpp:
+ (WebCore::FEMerge::apply):
+ * svg/graphics/filters/SVGFEMerge.h:
+ * svg/graphics/filters/SVGFEMorphology.cpp:
+ (WebCore::FEMorphology::apply):
+ * svg/graphics/filters/SVGFEMorphology.h:
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ (WebCore::FEOffset::apply):
+ * svg/graphics/filters/SVGFEOffset.h:
+ * svg/graphics/filters/SVGFESpecularLighting.cpp:
+ (WebCore::FESpecularLighting::apply):
+ * svg/graphics/filters/SVGFESpecularLighting.h:
+ * svg/graphics/filters/SVGFETile.cpp:
+ (WebCore::FETile::apply):
+ * svg/graphics/filters/SVGFETile.h:
+ * svg/graphics/filters/SVGFETurbulence.cpp:
+ (WebCore::FETurbulence::apply):
+ * svg/graphics/filters/SVGFETurbulence.h:
+ * svg/graphics/filters/SVGFilter.cpp: Added.
+ (WebCore::SVGFilter::SVGFilter):
+ (WebCore::SVGFilter::calculateEffectSubRegion):
+ (WebCore::SVGFilter::create):
+ * svg/graphics/filters/SVGFilter.h: Added.
+
+2009-05-30 Kevin Ollivier <kevino@theolliviers.com>
+
+ Build fix for platforms without plugins support.
+
+ * plugins/PluginViewNone.cpp:
+ (WebCore::PluginView::userAgentStatic):
+ (WebCore::PluginView::getValueStatic):
+
+2009-05-30 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979
+
+ Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
+ Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
+
+2009-05-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
+ Make storage events match the current spec.
+ - Storage event listeners are added to the window.
+ - Storage events are dispatched to the window.
+
+ Updated existing tests.
+
+ * dom/Document.cpp:
+ (WebCore::Document::dispatchWindowEvent):
+ * dom/Document.h:
+ * dom/Node.cpp:
+ * dom/Node.h:
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::dispatchStorageEvent):
+ * storage/SessionStorageArea.cpp:
+ (WebCore::SessionStorageArea::dispatchStorageEvent):
+
+2009-05-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element
+
+ Test: fast/forms/focus-control-to-page.html
+
+ * dom/SelectElement.h: Made destructor protected. Tweaked a bit.
+
+ * html/HTMLSelectElement.cpp: Removed unneeded includes.
+ (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the
+ result of optionToListIndex.
+ (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the
+ unused attribute, m_minwidth.
+ (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix.
+ Call through to the base class defaultEventHandler if the event hasn't
+ been handled yet.
+
+ * html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions
+ private. Removed unused minWidth function and m_minwidth data member.
+
+2009-05-30 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Holger Freyther.
+
+ The two KeyboardCodes.h files are basically identical and the
+ qt one is properly #ifdef-ed for different win32 systems. Share
+ them between Qt and Gtk implementations.
+
+ * GNUmakefile.am:
+ * platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
+ * platform/gtk/KeyboardCodes.h: Removed.
+ * platform/qt/KeyboardCodes.h: Removed.
+
+2009-05-30 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ LocalStorage and SessionStorage's implicit setters do not correctly
+ handle null. The custom JS bindings should convert to strings
+ unconditionally and not try to handle null specially.
+ https://bugs.webkit.org/show_bug.cgi?id=25970
+
+ Tests: storage/domstorage/localstorage/string-conversion.html
+ storage/domstorage/sessionstorage/string-conversion.html
+
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::customPut):
+
+2009-05-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll
+ bars in key window draw as inactive if the WebView is not active
+
+ Test: platform/mac/scrollbars/key-window-not-first-responder.html
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead
+ of the WebView's first responder state to switch between active and
+ inactive state.
+
+2009-05-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=18445
+ <rdar://problem/5931174> Assertion failure in CSSGradientValue::image
+ with -webkit-gradient as body's background
+
+ Test: fast/backgrounds/body-generated-image-propagated-to-root.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this
+ is the root element painting a background layer propagated from the
+ body, and if it is, use the body's renderer as the client to
+ StyleImage::image().
+
+2009-05-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix for AXObjectCache.
+
+ For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
+ that into the #ifdef.
+
+ * accessibility/AXObjectCache.cpp:
+
+2009-05-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072
+
+ Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
+ the same functionality HTMLSelectElement has. The WML specific features will follow soon.
+
+ Add simple testcase covering <select> element rendering: fast/wml/select.wml
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/OptionElement.cpp:
+ (WebCore::OptionElement::optionIndex):
+ (WebCore::isOptionElement):
+ * dom/OptionElement.h:
+ * dom/OptionGroupElement.cpp:
+ (WebCore::isOptionGroupElement):
+ * dom/OptionGroupElement.h:
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::accessKeySetSelectedIndex):
+ (WebCore::toSelectElement):
+ * dom/SelectElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::index):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintItemForeground):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::itemIsEnabled):
+ (WebCore::RenderMenuList::itemIsLabel):
+ * wml/WMLFormControlElement.cpp:
+ (WebCore::WMLFormControlElement::attach):
+ (WebCore::WMLFormControlElement::recalcStyle):
+ * wml/WMLFormControlElement.h:
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::attach):
+ * wml/WMLOptGroupElement.cpp:
+ (WebCore::WMLOptGroupElement::insertBefore):
+ (WebCore::WMLOptGroupElement::replaceChild):
+ (WebCore::WMLOptGroupElement::removeChild):
+ (WebCore::WMLOptGroupElement::appendChild):
+ (WebCore::WMLOptGroupElement::removeChildren):
+ (WebCore::ownerSelectElement):
+ (WebCore::WMLOptGroupElement::accessKeyAction):
+ (WebCore::WMLOptGroupElement::childrenChanged):
+ (WebCore::WMLOptGroupElement::parseMappedAttribute):
+ (WebCore::WMLOptGroupElement::attach):
+ (WebCore::WMLOptGroupElement::detach):
+ (WebCore::WMLOptGroupElement::recalcSelectOptions):
+ * wml/WMLOptionElement.cpp:
+ (WebCore::ownerSelectElement):
+ (WebCore::WMLOptionElement::accessKeyAction):
+ (WebCore::WMLOptionElement::childrenChanged):
+ (WebCore::WMLOptionElement::parseMappedAttribute):
+ (WebCore::WMLOptionElement::attach):
+ (WebCore::WMLOptionElement::detach):
+ (WebCore::WMLOptionElement::insertedIntoDocument):
+ * wml/WMLSelectElement.cpp: Added.
+ (WebCore::WMLSelectElement::WMLSelectElement):
+ (WebCore::WMLSelectElement::~WMLSelectElement):
+ (WebCore::WMLSelectElement::formControlType):
+ (WebCore::WMLSelectElement::isKeyboardFocusable):
+ (WebCore::WMLSelectElement::isMouseFocusable):
+ (WebCore::WMLSelectElement::selectAll):
+ (WebCore::WMLSelectElement::recalcStyle):
+ (WebCore::WMLSelectElement::dispatchFocusEvent):
+ (WebCore::WMLSelectElement::dispatchBlurEvent):
+ (WebCore::WMLSelectElement::selectedIndex):
+ (WebCore::WMLSelectElement::setSelectedIndex):
+ (WebCore::WMLSelectElement::saveFormControlState):
+ (WebCore::WMLSelectElement::restoreFormControlState):
+ (WebCore::WMLSelectElement::childrenChanged):
+ (WebCore::WMLSelectElement::parseMappedAttribute):
+ (WebCore::WMLSelectElement::createRenderer):
+ (WebCore::WMLSelectElement::appendFormData):
+ (WebCore::WMLSelectElement::optionToListIndex):
+ (WebCore::WMLSelectElement::listToOptionIndex):
+ (WebCore::WMLSelectElement::reset):
+ (WebCore::WMLSelectElement::defaultEventHandler):
+ (WebCore::WMLSelectElement::accessKeyAction):
+ (WebCore::WMLSelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::WMLSelectElement::setActiveSelectionEndIndex):
+ (WebCore::WMLSelectElement::updateListBoxSelection):
+ (WebCore::WMLSelectElement::listBoxOnChange):
+ (WebCore::WMLSelectElement::menuListOnChange):
+ (WebCore::WMLSelectElement::activeSelectionStartListIndex):
+ (WebCore::WMLSelectElement::activeSelectionEndListIndex):
+ (WebCore::WMLSelectElement::accessKeySetSelectedIndex):
+ (WebCore::WMLSelectElement::setRecalcListItems):
+ (WebCore::WMLSelectElement::scrollToSelection):
+ (WebCore::WMLSelectElement::insertedIntoTree):
+ * wml/WMLSelectElement.h: Added.
+ (WebCore::WMLSelectElement::canSelectAll):
+ (WebCore::WMLSelectElement::canStartSelection):
+ (WebCore::WMLSelectElement::size):
+ (WebCore::WMLSelectElement::multiple):
+ (WebCore::WMLSelectElement::listItems):
+ * wml/WMLTagNames.in:
+
+2009-05-29 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (build fix for windows).
+
+ http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
+ that it was trying to replace. Resulting in this variable being defined twice (and
+ the second time incorrectly).
+
+ * platform/win/Language.cpp:
+ (WebCore::localeInfo):
+
+2009-05-29 Takeshi Yoshino <tyoshino@google.com>
+
+ Reviewed by Darin Alder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26018
+
+ Fix behavior of the Element View of the Web Inspector for double
+ clicking the element outline tree.
+
+ Double clicking the element outline tree should
+ 1) on attribute: enter attribute editing mode
+ 2) on text: enter text editing mode
+ 3) otherwise: change root node to the parent element of double clicked
+ element.
+
+ Now, 3) is broken. For example, clicking <html> clears the element
+ outline view.
+
+ rootDOMNode should be updated to this.representedObject.parentNode, not
+ this.parent.representedObject which is parent inside the element
+ outline tree itself.
+
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeElement.prototype.ondblclick):
+
+2009-05-29 David Moore <davemoore@google.com>
+
+ Reviewed by Darin Alder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26001
+ Change many of the uses of String::adopt() to String::createUninitialized().
+ This allows those strings to use an inlined buffer for their characters.
+
+ * dom/StyleElement.cpp:
+ Loop over nodes to precompute length of string and then
+ write the characters into the allocated inline buffer
+ (WebCore::StyleElement::process):
+ * dom/Text.cpp:
+ Loop over nodes to precompute length of string and then
+ write the characters into the allocated inline buffer
+ (WebCore::Text::wholeText):
+ (WebCore::Text::rendererIsNeeded):
+ (WebCore::Text::createRenderer):
+ (WebCore::Text::createWithLengthLimit):
+ (WebCore::Text::formatForDebugger):
+ * platform/text/String.cpp:
+ (WebCore::String::append):
+ (WebCore::String::insert):
+ (WebCore::String::truncate):
+ (WebCore::String::remove):
+ * platform/text/StringBuilder.cpp:
+ (WebCore::StringBuilder::toString):
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::lower):
+ (WebCore::StringImpl::upper):
+ (WebCore::StringImpl::secure):
+ (WebCore::StringImpl::foldCase):
+ (WebCore::StringImpl::replace):
+ * platform/text/TextCodecLatin1.cpp:
+ (WebCore::TextCodecLatin1::decode):
+ * platform/text/TextCodecUserDefined.cpp:
+ (WebCore::TextCodecUserDefined::decode):
+ * platform/win/Language.cpp:
+ (WebCore::localeInfo):
+
+2009-05-29 Takeshi Yoshino <tyoshino@google.com>
+
+ Reviewed by Darin Alder.
+
+ Bug 25911: Apply href in base elements to anchors shown on the source viewer
+ https://bugs.webkit.org/show_bug.cgi?id=25911
+
+ In rendering HTML sources, parse base elements to apply the base URI to
+ anchors shown on the source viewer.
+
+ This issue was originally reported to the Chromium issue tracker.
+ http://code.google.com/p/chromium/issues/detail?id=2418
+
+ Test: fast/frames/viewsource-link-on-href-value.html
+
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::addViewSourceToken):
+
+2009-05-29 Rob Buis <rwlbuis@gmail.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22429
+ document.styleSheets collection ignores media=presentation
+
+ Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.
+
+ Test: fast/css/sheet-collection-link.html
+
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::process):
+
+2009-05-29 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26069
+ Fix a crash in custom V8 bindings code for XMLHttpRequest.
+
+ Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
+
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-29 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
+ https://bugs.webkit.org/show_bug.cgi?id=26074
+
+ The constructor for SQLStatement already does a copy for this string.
+
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::executeSQL):
+
+2009-05-29 Darin Adler <darin@apple.com>
+
+ Fix build; the new Cairo code compiled on Windows only.
+
+ * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
+ and syntheticOblique functions as in the Windows version to make it
+ easier to use this cross-platform. Later we can make data members
+ private as in the Windows version.
+ * platform/graphics/mac/FontPlatformData.h: Ditto.
+
+2009-05-29 Alexander Macdonald <alexmac@adobe.com>
+
+ Reviewed by Darin Adler.
+
+ Added support for synthetic bold/oblique font rendering
+ on platforms that use cairo.
+
+ * platform/graphics/SimpleFontData.h:
+ * platform/graphics/cairo/FontCairo.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+
+2009-05-29 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
+ https://bugs.webkit.org/show_bug.cgi?id=26024
+
+ AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
+ Consolidated postNotification and postNotificationToElement into one method.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::AXObjectCache):
+ (WebCore::AXObjectCache::notificationPostTimerFired):
+ (WebCore::AXObjectCache::postNotification):
+ (WebCore::AXObjectCache::selectedChildrenChanged):
+ * accessibility/AXObjectCache.h:
+ (WebCore::AXObjectCache::postNotification):
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
+ * accessibility/chromium/AXObjectCacheChromium.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/gtk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/win/AXObjectCacheWin.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ * editing/Editor.cpp:
+ (WebCore::Editor::respondToChangedContents):
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setInnerTextValue):
+
+2009-05-29 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Build fix for Windows Cairo target.
+ https://bugs.webkit.org/show_bug.cgi?id=25972
+
+ Compiler mistakenly selects SMILTime min/max instead of STL version,
+ resulting in a build error. This change makes the meaning of the
+ min/max explicit and avoids the problem.
+
+ * html/TimeRanges.h:
+ (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
+
+2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Jan Alonzo.
+
+ Make SoupMessage a member of ResourceRequest, instead of creating
+ it in startHttp. Implement updating of ResourceRequest from
+ SoupMessage, and vice versa.
+
+ * GNUmakefile.am:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::~ResourceHandle):
+ (WebCore::gotHeadersCallback):
+ (WebCore::ResourceHandle::startHttp):
+ * platform/network/soup/ResourceRequest.h:
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::~ResourceRequest):
+ * platform/network/soup/ResourceRequestSoup.cpp: Added.
+ (WTF::SoupURI):
+ (WebCore::ResourceRequest::soupMessage):
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+
+2009-05-28 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26068
+ V8: Remove the remaining b8::Locker usage in worker code.
+ This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
+ since the patches for enabling timers and that bug have "crossed in the queue".
+ Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
+
+ * bindings/v8/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+
+2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ Simplify the Accept-Encoding header we are sending out, for it
+ seems some servers do not enjoy parsing the full, explicit
+ version.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp):
+
+2009-05-28 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Added a new build flag --filters. This replaces the old --svg-filters and enables
+ other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
+ This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
+ doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
+ Filters are not working yet. This patch is just a preperation. Filters are deactivated by
+ default.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * bindings/objc/DOM.mm:
+ (WebCore::createElementClassMap):
+ * dom/DOMImplementation.cpp:
+ (WebCore::isSVG10Feature):
+ (WebCore::isSVG11Feature):
+ * page/DOMWindow.idl:
+ * platform/graphics/filters/FEBlend.cpp:
+ * platform/graphics/filters/FEBlend.h:
+ * platform/graphics/filters/FEColorMatrix.cpp:
+ * platform/graphics/filters/FEColorMatrix.h:
+ * platform/graphics/filters/FEComponentTransfer.cpp:
+ * platform/graphics/filters/FEComponentTransfer.h:
+ * platform/graphics/filters/FEComposite.cpp:
+ * platform/graphics/filters/FEComposite.h:
+ * platform/graphics/filters/FilterEffect.cpp:
+ * platform/graphics/filters/FilterEffect.h:
+ * platform/graphics/filters/SourceAlpha.cpp:
+ * platform/graphics/filters/SourceAlpha.h:
+ * platform/graphics/filters/SourceGraphic.cpp:
+ * platform/graphics/filters/SourceGraphic.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::selfWillPaint):
+ * rendering/RenderSVGModelObject.cpp:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::selfWillPaint):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::prepareToRenderSVGContent):
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
+ * svg/Filter.cpp:
+ * svg/Filter.h:
+ * svg/FilterBuilder.cpp:
+ * svg/FilterBuilder.h:
+ * svg/SVGComponentTransferFunctionElement.cpp:
+ * svg/SVGComponentTransferFunctionElement.h:
+ * svg/SVGComponentTransferFunctionElement.idl:
+ * svg/SVGFEBlendElement.cpp:
+ * svg/SVGFEBlendElement.h:
+ * svg/SVGFEBlendElement.idl:
+ * svg/SVGFEColorMatrixElement.cpp:
+ * svg/SVGFEColorMatrixElement.h:
+ * svg/SVGFEColorMatrixElement.idl:
+ * svg/SVGFEComponentTransferElement.cpp:
+ * svg/SVGFEComponentTransferElement.h:
+ * svg/SVGFEComponentTransferElement.idl:
+ * svg/SVGFECompositeElement.cpp:
+ * svg/SVGFECompositeElement.h:
+ * svg/SVGFECompositeElement.idl:
+ * svg/SVGFEDiffuseLightingElement.cpp:
+ * svg/SVGFEDiffuseLightingElement.h:
+ * svg/SVGFEDiffuseLightingElement.idl:
+ * svg/SVGFEDisplacementMapElement.cpp:
+ * svg/SVGFEDisplacementMapElement.h:
+ * svg/SVGFEDisplacementMapElement.idl:
+ * svg/SVGFEDistantLightElement.cpp:
+ * svg/SVGFEDistantLightElement.h:
+ * svg/SVGFEDistantLightElement.idl:
+ * svg/SVGFEFloodElement.cpp:
+ * svg/SVGFEFloodElement.h:
+ * svg/SVGFEFloodElement.idl:
+ * svg/SVGFEFuncAElement.cpp:
+ * svg/SVGFEFuncAElement.h:
+ * svg/SVGFEFuncAElement.idl:
+ * svg/SVGFEFuncBElement.cpp:
+ * svg/SVGFEFuncBElement.h:
+ * svg/SVGFEFuncBElement.idl:
+ * svg/SVGFEFuncGElement.cpp:
+ * svg/SVGFEFuncGElement.h:
+ * svg/SVGFEFuncGElement.idl:
+ * svg/SVGFEFuncRElement.cpp:
+ * svg/SVGFEFuncRElement.h:
+ * svg/SVGFEFuncRElement.idl:
+ * svg/SVGFEGaussianBlurElement.cpp:
+ * svg/SVGFEGaussianBlurElement.h:
+ * svg/SVGFEGaussianBlurElement.idl:
+ * svg/SVGFEImageElement.cpp:
+ * svg/SVGFEImageElement.h:
+ * svg/SVGFEImageElement.idl:
+ * svg/SVGFELightElement.cpp:
+ * svg/SVGFELightElement.h:
+ * svg/SVGFEMergeElement.cpp:
+ * svg/SVGFEMergeElement.h:
+ * svg/SVGFEMergeElement.idl:
+ * svg/SVGFEMergeNodeElement.cpp:
+ * svg/SVGFEMergeNodeElement.h:
+ * svg/SVGFEMergeNodeElement.idl:
+ * svg/SVGFEOffsetElement.cpp:
+ * svg/SVGFEOffsetElement.h:
+ * svg/SVGFEOffsetElement.idl:
+ * svg/SVGFEPointLightElement.cpp:
+ * svg/SVGFEPointLightElement.h:
+ * svg/SVGFEPointLightElement.idl:
+ * svg/SVGFESpecularLightingElement.cpp:
+ * svg/SVGFESpecularLightingElement.h:
+ * svg/SVGFESpecularLightingElement.idl:
+ * svg/SVGFESpotLightElement.cpp:
+ * svg/SVGFESpotLightElement.h:
+ * svg/SVGFESpotLightElement.idl:
+ * svg/SVGFETileElement.cpp:
+ * svg/SVGFETileElement.h:
+ * svg/SVGFETileElement.idl:
+ * svg/SVGFETurbulenceElement.cpp:
+ * svg/SVGFETurbulenceElement.h:
+ * svg/SVGFETurbulenceElement.idl:
+ * svg/SVGFilterElement.cpp:
+ * svg/SVGFilterElement.h:
+ * svg/SVGFilterElement.idl:
+ * svg/SVGFilterPrimitiveStandardAttributes.cpp:
+ * svg/SVGFilterPrimitiveStandardAttributes.h:
+ * svg/graphics/SVGResourceFilter.cpp:
+ * svg/graphics/SVGResourceFilter.h:
+ * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
+ * svg/graphics/cg/SVGResourceFilterCg.cpp:
+ * svg/graphics/cg/SVGResourceFilterCg.mm:
+ * svg/graphics/filters/SVGDistantLightSource.h:
+ * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
+ * svg/graphics/filters/SVGFEConvolveMatrix.h:
+ * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
+ * svg/graphics/filters/SVGFEDiffuseLighting.h:
+ * svg/graphics/filters/SVGFEDisplacementMap.cpp:
+ * svg/graphics/filters/SVGFEDisplacementMap.h:
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ * svg/graphics/filters/SVGFEFlood.h:
+ * svg/graphics/filters/SVGFEGaussianBlur.cpp:
+ * svg/graphics/filters/SVGFEGaussianBlur.h:
+ * svg/graphics/filters/SVGFEImage.cpp:
+ * svg/graphics/filters/SVGFEImage.h:
+ * svg/graphics/filters/SVGFEMerge.cpp:
+ * svg/graphics/filters/SVGFEMerge.h:
+ * svg/graphics/filters/SVGFEMorphology.cpp:
+ * svg/graphics/filters/SVGFEMorphology.h:
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ * svg/graphics/filters/SVGFEOffset.h:
+ * svg/graphics/filters/SVGFESpecularLighting.cpp:
+ * svg/graphics/filters/SVGFESpecularLighting.h:
+ * svg/graphics/filters/SVGFETile.cpp:
+ * svg/graphics/filters/SVGFETile.h:
+ * svg/graphics/filters/SVGFETurbulence.cpp:
+ * svg/graphics/filters/SVGFETurbulence.h:
+ * svg/graphics/filters/SVGFilterEffect.cpp:
+ * svg/graphics/filters/SVGFilterEffect.h:
+ * svg/graphics/filters/SVGLightSource.cpp:
+ * svg/graphics/filters/SVGLightSource.h:
+ * svg/graphics/filters/SVGPointLightSource.h:
+ * svg/graphics/filters/SVGSpotLightSource.h:
+ * svg/graphics/filters/cg/SVGFEHelpersCg.h:
+ * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
+ * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
+ * svg/graphics/filters/cg/WKArithmeticFilter.h:
+ * svg/graphics/filters/cg/WKArithmeticFilter.m:
+ * svg/graphics/filters/cg/WKComponentMergeFilter.h:
+ * svg/graphics/filters/cg/WKComponentMergeFilter.m:
+ * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
+ * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
+ * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
+ * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
+ * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
+ * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
+ * svg/graphics/filters/cg/WKDistantLightFilter.h:
+ * svg/graphics/filters/cg/WKDistantLightFilter.m:
+ * svg/graphics/filters/cg/WKGammaTransferFilter.h:
+ * svg/graphics/filters/cg/WKGammaTransferFilter.m:
+ * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
+ * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
+ * svg/graphics/filters/cg/WKLinearTransferFilter.h:
+ * svg/graphics/filters/cg/WKLinearTransferFilter.m:
+ * svg/graphics/filters/cg/WKNormalMapFilter.h:
+ * svg/graphics/filters/cg/WKNormalMapFilter.m:
+ * svg/graphics/filters/cg/WKPointLightFilter.h:
+ * svg/graphics/filters/cg/WKPointLightFilter.m:
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
+ * svg/graphics/filters/cg/WKSpotLightFilter.h:
+ * svg/graphics/filters/cg/WKSpotLightFilter.m:
+ * svg/graphics/filters/cg/WKTableTransferFilter.h:
+ * svg/graphics/filters/cg/WKTableTransferFilter.m:
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
+ * svg/graphics/qt/SVGResourceFilterQt.cpp:
+ * svg/graphics/skia/SVGResourceFilterSkia.cpp:
+ * svg/svgtags.in:
+
+2009-05-28 Brett Wilson <brettw@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26067
+
+ Add casts for scale function to make more explicit what is happening
+ and fix a compiler warning.
+
+ * platform/graphics/IntSize.h:
+ (WebCore::IntSize::scale):
+
+2009-05-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
+ are not cleared on navigation it is no longer necessary.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
+ (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::showModalDialog):
+
+2009-05-19 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo and Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25415
+ [GTK][ATK] Please implement support for get_text_at_offset
+
+ Implement atk_text_get_text_{at,after,before}_offset.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by Darin Adler.
+
+ Remove unnecessary destructor from InputElementData/OptionElementData.
+
+ * dom/InputElement.cpp:
+ * dom/InputElement.h:
+ * dom/OptionElement.cpp:
+ * dom/OptionElement.h:
+
+2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
+
+ Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
+ in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
+
+ A follow-up patch can now easily add WMLSelectElement.
+
+ * dom/OptionElement.h:
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::selectAll):
+ (WebCore::SelectElement::saveLastSelection):
+ (WebCore::isOptionElement):
+ (WebCore::isOptionGroupElement):
+ (WebCore::SelectElement::nextSelectableListIndex):
+ (WebCore::SelectElement::previousSelectableListIndex):
+ (WebCore::SelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::SelectElement::setActiveSelectionEndIndex):
+ (WebCore::SelectElement::updateListBoxSelection):
+ (WebCore::SelectElement::listBoxOnChange):
+ (WebCore::SelectElement::menuListOnChange):
+ (WebCore::SelectElement::scrollToSelection):
+ (WebCore::SelectElement::recalcStyle):
+ (WebCore::SelectElement::setRecalcListItems):
+ (WebCore::SelectElement::recalcListItems):
+ (WebCore::SelectElement::selectedIndex):
+ (WebCore::SelectElement::setSelectedIndex):
+ (WebCore::SelectElement::optionToListIndex):
+ (WebCore::SelectElement::listToOptionIndex):
+ (WebCore::SelectElement::dispatchFocusEvent):
+ (WebCore::SelectElement::dispatchBlurEvent):
+ (WebCore::SelectElement::deselectItems):
+ (WebCore::SelectElement::saveFormControlState):
+ (WebCore::SelectElement::restoreFormControlState):
+ (WebCore::SelectElement::parseMultipleAttribute):
+ (WebCore::SelectElement::appendFormData):
+ (WebCore::SelectElement::reset):
+ (WebCore::SelectElement::menuListDefaultEventHandler):
+ (WebCore::SelectElement::listBoxDefaultEventHandler):
+ (WebCore::SelectElement::defaultEventHandler):
+ (WebCore::SelectElement::lastSelectedListIndex):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::SelectElement::typeAheadFind):
+ (WebCore::SelectElement::insertedIntoTree):
+ (WebCore::SelectElementData::SelectElementData):
+ (WebCore::SelectElementData::checkListItems):
+ (WebCore::SelectElementData::listItems):
+ * dom/SelectElement.h:
+ (WebCore::SelectElementData::multiple):
+ (WebCore::SelectElementData::setMultiple):
+ (WebCore::SelectElementData::size):
+ (WebCore::SelectElementData::setSize):
+ (WebCore::SelectElementData::usesMenuList):
+ (WebCore::SelectElementData::lastOnChangeIndex):
+ (WebCore::SelectElementData::setLastOnChangeIndex):
+ (WebCore::SelectElementData::lastOnChangeSelection):
+ (WebCore::SelectElementData::activeSelectionState):
+ (WebCore::SelectElementData::setActiveSelectionState):
+ (WebCore::SelectElementData::activeSelectionAnchorIndex):
+ (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
+ (WebCore::SelectElementData::activeSelectionEndIndex):
+ (WebCore::SelectElementData::setActiveSelectionEndIndex):
+ (WebCore::SelectElementData::cachedStateForActiveSelection):
+ (WebCore::SelectElementData::shouldRecalcListItems):
+ (WebCore::SelectElementData::setShouldRecalcListItems):
+ (WebCore::SelectElementData::rawListItems):
+ (WebCore::SelectElementData::repeatingChar):
+ (WebCore::SelectElementData::setRepeatingChar):
+ (WebCore::SelectElementData::lastCharTime):
+ (WebCore::SelectElementData::setLastCharTime):
+ (WebCore::SelectElementData::typedString):
+ (WebCore::SelectElementData::setTypedString):
+ * html/HTMLOptionElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::HTMLSelectElement):
+ (WebCore::HTMLSelectElement::recalcStyle):
+ (WebCore::HTMLSelectElement::formControlType):
+ (WebCore::HTMLSelectElement::selectedIndex):
+ (WebCore::HTMLSelectElement::deselectItems):
+ (WebCore::HTMLSelectElement::setSelectedIndex):
+ (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
+ (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
+ (WebCore::HTMLSelectElement::saveFormControlState):
+ (WebCore::HTMLSelectElement::restoreFormControlState):
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ (WebCore::HTMLSelectElement::canSelectAll):
+ (WebCore::HTMLSelectElement::selectAll):
+ (WebCore::HTMLSelectElement::createRenderer):
+ (WebCore::HTMLSelectElement::appendFormData):
+ (WebCore::HTMLSelectElement::optionToListIndex):
+ (WebCore::HTMLSelectElement::listToOptionIndex):
+ (WebCore::HTMLSelectElement::recalcListItems):
+ (WebCore::HTMLSelectElement::setRecalcListItems):
+ (WebCore::HTMLSelectElement::reset):
+ (WebCore::HTMLSelectElement::dispatchFocusEvent):
+ (WebCore::HTMLSelectElement::dispatchBlurEvent):
+ (WebCore::HTMLSelectElement::defaultEventHandler):
+ (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ (WebCore::HTMLSelectElement::menuListOnChange):
+ (WebCore::HTMLSelectElement::listBoxOnChange):
+ (WebCore::HTMLSelectElement::saveLastSelection):
+ (WebCore::HTMLSelectElement::setOption):
+ (WebCore::HTMLSelectElement::scrollToSelection):
+ (WebCore::HTMLSelectElement::insertedIntoTree):
+ * html/HTMLSelectElement.h:
+ (WebCore::HTMLSelectElement::size):
+ (WebCore::HTMLSelectElement::multiple):
+ (WebCore::HTMLSelectElement::listItems):
+ * wml/WMLOptionElement.cpp:
+ (WebCore::WMLOptionElement::text):
+ * wml/WMLOptionElement.h:
+
+
+ * dom/OptionElement.h:
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::selectAll):
+ (WebCore::SelectElement::saveLastSelection):
+ (WebCore::isOptionElement):
+ (WebCore::isOptionGroupElement):
+ (WebCore::SelectElement::nextSelectableListIndex):
+ (WebCore::SelectElement::previousSelectableListIndex):
+ (WebCore::SelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::SelectElement::setActiveSelectionEndIndex):
+ (WebCore::SelectElement::updateListBoxSelection):
+ (WebCore::SelectElement::listBoxOnChange):
+ (WebCore::SelectElement::menuListOnChange):
+ (WebCore::SelectElement::scrollToSelection):
+ (WebCore::SelectElement::recalcStyle):
+ (WebCore::SelectElement::setRecalcListItems):
+ (WebCore::SelectElement::recalcListItems):
+ (WebCore::SelectElement::selectedIndex):
+ (WebCore::SelectElement::setSelectedIndex):
+ (WebCore::SelectElement::optionToListIndex):
+ (WebCore::SelectElement::listToOptionIndex):
+ (WebCore::SelectElement::dispatchFocusEvent):
+ (WebCore::SelectElement::dispatchBlurEvent):
+ (WebCore::SelectElement::deselectItems):
+ (WebCore::SelectElement::saveFormControlState):
+ (WebCore::SelectElement::restoreFormControlState):
+ (WebCore::SelectElement::parseMultipleAttribute):
+ (WebCore::SelectElement::appendFormData):
+ (WebCore::SelectElement::reset):
+ (WebCore::SelectElement::menuListDefaultEventHandler):
+ (WebCore::SelectElement::listBoxDefaultEventHandler):
+ (WebCore::SelectElement::defaultEventHandler):
+ (WebCore::SelectElement::lastSelectedListIndex):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::SelectElement::typeAheadFind):
+ (WebCore::SelectElement::insertedIntoTree):
+ (WebCore::SelectElementData::SelectElementData):
+ (WebCore::SelectElementData::~SelectElementData):
+ (WebCore::SelectElementData::checkListItems):
+ (WebCore::SelectElementData::listItems):
+ * dom/SelectElement.h:
+ (WebCore::SelectElementData::multiple):
+ (WebCore::SelectElementData::setMultiple):
+ (WebCore::SelectElementData::size):
+ (WebCore::SelectElementData::setSize):
+ (WebCore::SelectElementData::usesMenuList):
+ (WebCore::SelectElementData::lastOnChangeIndex):
+ (WebCore::SelectElementData::setLastOnChangeIndex):
+ (WebCore::SelectElementData::lastOnChangeSelection):
+ (WebCore::SelectElementData::activeSelectionState):
+ (WebCore::SelectElementData::setActiveSelectionState):
+ (WebCore::SelectElementData::activeSelectionAnchorIndex):
+ (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
+ (WebCore::SelectElementData::activeSelectionEndIndex):
+ (WebCore::SelectElementData::setActiveSelectionEndIndex):
+ (WebCore::SelectElementData::cachedStateForActiveSelection):
+ (WebCore::SelectElementData::shouldRecalcListItems):
+ (WebCore::SelectElementData::setShouldRecalcListItems):
+ (WebCore::SelectElementData::rawListItems):
+ (WebCore::SelectElementData::repeatingChar):
+ (WebCore::SelectElementData::setRepeatingChar):
+ (WebCore::SelectElementData::lastCharTime):
+ (WebCore::SelectElementData::setLastCharTime):
+ (WebCore::SelectElementData::typedString):
+ (WebCore::SelectElementData::setTypedString):
+ * html/HTMLOptionElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::HTMLSelectElement):
+ (WebCore::HTMLSelectElement::recalcStyle):
+ (WebCore::HTMLSelectElement::formControlType):
+ (WebCore::HTMLSelectElement::selectedIndex):
+ (WebCore::HTMLSelectElement::deselectItems):
+ (WebCore::HTMLSelectElement::setSelectedIndex):
+ (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
+ (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
+ (WebCore::HTMLSelectElement::saveFormControlState):
+ (WebCore::HTMLSelectElement::restoreFormControlState):
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ (WebCore::HTMLSelectElement::canSelectAll):
+ (WebCore::HTMLSelectElement::selectAll):
+ (WebCore::HTMLSelectElement::createRenderer):
+ (WebCore::HTMLSelectElement::appendFormData):
+ (WebCore::HTMLSelectElement::optionToListIndex):
+ (WebCore::HTMLSelectElement::listToOptionIndex):
+ (WebCore::HTMLSelectElement::recalcListItems):
+ (WebCore::HTMLSelectElement::setRecalcListItems):
+ (WebCore::HTMLSelectElement::reset):
+ (WebCore::HTMLSelectElement::dispatchFocusEvent):
+ (WebCore::HTMLSelectElement::dispatchBlurEvent):
+ (WebCore::HTMLSelectElement::defaultEventHandler):
+ (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ (WebCore::HTMLSelectElement::menuListOnChange):
+ (WebCore::HTMLSelectElement::listBoxOnChange):
+ (WebCore::HTMLSelectElement::saveLastSelection):
+ (WebCore::HTMLSelectElement::setOption):
+ (WebCore::HTMLSelectElement::scrollToSelection):
+ (WebCore::HTMLSelectElement::insertedIntoTree):
+ * html/HTMLSelectElement.h:
+ (WebCore::HTMLSelectElement::size):
+ (WebCore::HTMLSelectElement::multiple):
+ (WebCore::HTMLSelectElement::listItems):
+ * wml/WMLOptionElement.cpp:
+ (WebCore::WMLOptionElement::text):
+ * wml/WMLOptionElement.h:
+
+2009-05-28 Adam Roben <aroben@apple.com>
+
+ Don't try to use the new combobox parts on Vista in Classic mode
+
+ Fixes:
+ <rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
+ theme: drop down lists in Preferences get a line/square
+ <rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
+ down lists are black with a circle on many sites
+
+ Reviewed by Steve Falkenburg.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
+ parts when we have a theme (i.e., when we're not in Classic mode).
+ When we don't have a theme, fall back to the pre-r42289 code.
+
+2009-05-27 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25659
+ Avoid calling frameCount() unnecessarily (which could lead to extra
+ GIF decoding).
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
+
+2009-05-28 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=8736
+
+ Tests: fast/borders/border-radius-constraints.html
+ fast/borders/border-radius-split-inline.html
+
+ When the sum of the corner radii on a side exceed the length of the side,
+ reduce the radii according to CSS 3 rules.
+
+ Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
+ the constraints. Use that for painting borders, box-shadow, clipping replaced
+ elements
+
+ * platform/graphics/IntSize.h:
+ (WebCore::IntSize::scale):
+ Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
+
+ * platform/graphics/Path.cpp:
+ Make the QUARTER const static.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::pushContentsClip):
+ Use getBorderRadiiForRect to fetch border radii.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ Use getBorderRadiiForRect to fetch border radii.
+
+ (WebCore::RenderBoxModelObject::paintBorder):
+ Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
+ borders for split inlines, which used to apply the radii for each segment,
+ and no longer does.
+
+ (WebCore::RenderBoxModelObject::paintBoxShadow):
+ Use getBorderRadiiForRect to fetch border radii.
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::paint):
+ Use getBorderRadiiForRect to fetch border radii for clipping.
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+ Use getBorderRadiiForRect to fetch border radii for clipping.
+
+ * rendering/style/RenderStyle.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::getBorderRadiiForRect):
+ New bottleneck method to fetch corner radiil given a rect, applying the constraint
+ rules.
+
+2009-05-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26005
+ Optimization for XPath //* does not preserve context size
+
+ Test: fast/xpath/position.html
+
+ Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
+ get a performance progression on my tests.
+
+ * xml/XPathPath.h: Removed broken optimizeStepPair().
+
+ * xml/XPathPath.cpp:
+ (WebCore::XPath::LocationPath::evaluate): Style fix.
+ (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
+ (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
+ (WebCore::XPath::Path::Path): Style fix.
+
+ * xml/XPathStep.cpp:
+ (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
+ (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
+ (and might never be).
+ (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
+
+ * xml/XPathStep.h:
+ (WebCore::XPath::Step::NodeTest::data):
+ (WebCore::XPath::Step::NodeTest::namespaceURI):
+ Made these data members AtomicString to avoid repeated conversions. This is the biggest
+ performance win here.
+
+ * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
+
+2009-05-28 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ When creating a linear or radial gradient with a single stop
+ at offset 1.0, the Skia layer was allocating 3 stops, but only
+ filling 2, leaving one uninitialized. Only 2 stops are necessary
+ in this case, at offsets (0.0, 1.0).
+
+ http://bugs.webkit.org/show_bug.cgi?id=26063
+
+ Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
+ LayoutTests/svg/custom/gradient-stop-corner-cases.svg
+ LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
+
+ * platform/graphics/skia/GradientSkia.cpp:
+ (WebCore::totalStopsNeeded):
+
+2009-05-28 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26041
+ Allow adding resource source to WebInspector.SourceFrame asynchronously.
+
+ Provide common implementation for InspectorController::addResourceSourceToFrame and
+ InspectorController::addSourceToFrame methods.
+
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ * bindings/v8/custom/V8InspectorControllerCustom.cpp:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::addResourceSourceToFrame):
+ * inspector/InspectorController.h:
+ * inspector/InspectorController.idl:
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.revealLine):
+ (WebInspector.SourceFrame.prototype.highlightLine):
+ (WebInspector.SourceFrame.prototype._loaded):
+ (WebInspector.SourceFrame.prototype._isContentLoaded):
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
+ (WebInspector.SourceView.prototype._contentLoaded):
+
+2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ After r44177 we had a problem when increasing the size
+ of the window the scrollbars stayed and were not hidden.
+ This was due WebCore giving up on the Scrollbar as it became
+ unnecessary but the GtkAdjustment remained unchanged.
+ So from the point of view of the GtkScrolledWindow scrolling
+ was still necessary and the GtkScrollbar kept being displayed.
+
+ Solve the issue by resetting the GtkAdjustment in the
+ destructor of ScrollbarGtk.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::~ScrollbarGtk):
+
+2009-05-28 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Clean up window.open()'s use of lexical and dynamic scope.
+
+ (Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
+ for DOMWindow::allowPopUp.)
+
+ Test: http/tests/security/frameNavigation/context-for-window-open.html
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::toDynamicFrame):
+ (WebCore::processingUserGesture):
+ (WebCore::completeURL):
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::createWindow):
+ (WebCore::JSDOMWindow::open):
+ (WebCore::JSDOMWindow::showModalDialog):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::createWindow):
+
+2009-05-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26056
+ XPath string() function can be very slow
+
+ * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
+
+2009-05-27 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
+ and initially not visible
+
+ Test: fast/forms/isindex-placeholder.html
+
+ * css/html4.css: Added a default style for <isindex> placeholder text.
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
+ the new protected function updatePlaceholderVisibility().
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
+ protected function to allow HTMLIsIndexElement::parseMappedAttribute()
+ to invoke InputElement::updatePlaceholderVisibility().
+ * html/HTMLIsIndexElement.cpp:
+ (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
+ updatePlaceholderVisibility() when parsing the placeholder attribute.
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
+ is no placeholder pseudo-element style, use the normal style.
+
+2009-05-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ More cleanup of DOMWindow related functions.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
+ * bindings/js/JSDOMWindowBase.h:
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::showModalDialog): Update Comment.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSDOMWindowShell.h:
+ Remove JSDOMWindowShell::clear(). It was unused.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::clearWindowShell):
+
+2009-05-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Miscellaneous cleanup of DOMWindow related functions.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
+ checking for null frames if the build does not support profiling.
+ (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
+ clearHelperObjectProperties(). It is clearer.
+ * bindings/js/JSDOMWindowBase.h:
+ Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
+ function, and the empty destructor.
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSDOMWindowShell.h:
+ Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
+ is a no-op.
+ * page/Frame.cpp:
+ (WebCore::Frame::~Frame):
+ (WebCore::Frame::pageDestroyed):
+ Remove calls to JSDOMWindowShell::disconnectFrame() which only called
+ JSDOMWindowBase::disconnectFrame(), which is a no-op.
+
+2009-05-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25974
+ Remove extra qualifiers from the ScheduledAction decl.
+
+ * bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
+
+2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed make distcheck fix. One more missing file.
+
+ * GNUmakefile.am:
+
+2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fixed trunk build on Linux after r44126.
+
+ * WebCore.pro:
+
+2009-05-27 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
+
+2009-05-27 David Levin <levin@chromium.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
+ https://bugs.webkit.org/show_bug.cgi?id=26029
+
+ No functional changes, so no tests.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::canLoad):
+ * loader/FrameLoader.h:
+
+2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed build fix.
+
+ Remove file that does not exist from the build.
+
+ * GNUmakefile.am:
+
+2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
+
+ * dom/InputElement.h:
+ * dom/OptionGroupElement.h:
+
+2009-05-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17725
+ XPath should be case insensitive for HTML
+
+ Test: fast/xpath/node-name-case-sensitivity.html
+
+ * xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
+ for HTML elements in HTML documents.
+
+2009-05-27 John Sullivan <sullivan@apple.com>
+
+ fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
+ bookmarks (at least) over Top Sites (at least)
+
+ Reviewed by Kevin Decker
+
+ * page/DragController.cpp:
+ (WebCore::DragController::dragExited):
+ nil check m_documentUnderMouse and take the "local file" case if it's nil
+
+2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Gustavo Noronha.
+
+ When building on window, consider Windows specific files.
+
+ * GNUmakefile.am:
+
+2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
+
+ InputElementData is too heavy, save storing two pointers by passing them
+ directly to the static helper functions (the only place which needs them).
+
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::dispatchFocusEvent):
+ (WebCore::InputElement::dispatchBlurEvent):
+ (WebCore::InputElement::updatePlaceholderVisibility):
+ (WebCore::InputElement::updateFocusAppearance):
+ (WebCore::InputElement::updateSelectionRange):
+ (WebCore::InputElement::aboutToUnload):
+ (WebCore::InputElement::setValueFromRenderer):
+ (WebCore::InputElement::constrainValue):
+ (WebCore::InputElement::handleBeforeTextInsertedEvent):
+ (WebCore::InputElement::parseSizeAttribute):
+ (WebCore::InputElement::parseMaxLengthAttribute):
+ (WebCore::InputElement::updateValueIfNeeded):
+ (WebCore::InputElement::notifyFormStateChanged):
+ (WebCore::InputElementData::InputElementData):
+ * dom/InputElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::HTMLInputElement):
+ (WebCore::HTMLInputElement::updateFocusAppearance):
+ (WebCore::HTMLInputElement::aboutToUnload):
+ (WebCore::HTMLInputElement::dispatchFocusEvent):
+ (WebCore::HTMLInputElement::dispatchBlurEvent):
+ (WebCore::HTMLInputElement::setInputType):
+ (WebCore::HTMLInputElement::setSelectionRange):
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ (WebCore::HTMLInputElement::setFileListFromRenderer):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ (WebCore::HTMLInputElement::constrainValue):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::WMLInputElement):
+ (WebCore::WMLInputElement::dispatchFocusEvent):
+ (WebCore::WMLInputElement::dispatchBlurEvent):
+ (WebCore::WMLInputElement::updateFocusAppearance):
+ (WebCore::WMLInputElement::aboutToUnload):
+ (WebCore::WMLInputElement::setValue):
+ (WebCore::WMLInputElement::setValueFromRenderer):
+ (WebCore::WMLInputElement::parseMappedAttribute):
+ (WebCore::WMLInputElement::defaultEventHandler):
+ (WebCore::WMLInputElement::constrainValue):
+
+2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
+
+ OptionElementData saves an Element pointer, which is unnessary.
+ Just pass it to the static function calls directly.
+
+ * dom/OptionElement.cpp:
+ (WebCore::OptionElement::setSelectedState):
+ (WebCore::OptionElement::collectOptionText):
+ (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
+ (WebCore::OptionElement::collectOptionValue):
+ (WebCore::OptionElementData::OptionElementData):
+ * dom/OptionElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::HTMLOptionElement):
+ (WebCore::HTMLOptionElement::text):
+ (WebCore::HTMLOptionElement::value):
+ (WebCore::HTMLOptionElement::setSelected):
+ (WebCore::HTMLOptionElement::setSelectedState):
+ (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
+ * wml/WMLOptionElement.cpp:
+ (WebCore::WMLOptionElement::WMLOptionElement):
+ (WebCore::WMLOptionElement::setSelectedState):
+ (WebCore::WMLOptionElement::value):
+ (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
+
+2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Maciej Stachowiak.
+
+ When building with MinGW, don't use the __declspec(dl{import,export})
+ decorations and rely on the linker to use its nifty auto-import feature.
+ It is extremely hard to get the decorations right with MinGW in general
+ and impossible in WebKit, where the resulting shared library is linking
+ together some static libraries.
+
+ * config.h:
+
+2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25613
+
+ Add a WebCore::Widget that can embed GtkWidget with and
+ without a GdkWindow. This can be used to embed any GtkWidget.
+
+ Some bits are directly copied from the Scrollbar implementation
+ but can not be easily shared here.
+
+ * GNUmakefile.am:
+ * platform/gtk/GtkPluginWidget.cpp: Added.
+ (WebCore::GtkPluginWidget::GtkPluginWidget):
+ (WebCore::GtkPluginWidget::invalidateRect):
+ (WebCore::GtkPluginWidget::frameRectsChanged):
+ (WebCore::GtkPluginWidget::paint):
+ * platform/gtk/GtkPluginWidget.h: Added.
+
+2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25613.
+
+ Implement Widget::setIsSelected for Gtk+ by searching
+ for a property of the name "webkit-widget-is-selected" and if
+ such property exists we are going to set it. We expect
+ the property to take a boolean.
+
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::setIsSelected):
+
+2009-05-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Brady Eidson.
+
+ Fix for <rdar://problem/6916371>
+ iWeb 'Announce' button does nothing after publishing to MobileMe
+
+ Add ability to force content sniffing for all urls (including file: urls)
+
+ * WebCore.base.exp:
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::shouldContentSniffURL):
+ (WebCore::ResourceHandle::forceContentSniffing):
+ * platform/network/ResourceHandle.h:
+
+2009-05-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25996
+
+ [Qt] Dead-code stripping for unix
+
+ * WebCore.pro: Turn on GCC dead-code stripping flags for Unix
+
+2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25646
+
+ [GTK] Send onscroll events for the main FrameView
+
+ WebKit/GTK+ is currently not sending any onscroll
+ events for a frame with external adjustments. This is
+ due the fact that the value-changed signal of the GtkAdjustment
+ is handled by WebCore::ScrollView directly and is not going through
+ the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
+ WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
+ path.
+
+ Fix the above problem by wrapping the GtkAdjustment we get
+ assigned from GTK+ in a ScrollbarGtk that will not have any
+ visual appearance. Remove code from ScrollView that knows
+ about adjustments and create a special case for
+ WebCore::ScrollView::createScrollbar that will create such
+ a special WebCore::ScrollbarGtk.
+
+ * platform/ScrollView.cpp: Remove adjustment code
+ (WebCore::ScrollView::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::setHasVerticalScrollbar):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::wheelEvent):
+ * platform/ScrollView.h: Remove adjustment code
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformDestroy):
+ (WebCore::ScrollView::createScrollbar):
+ (WebCore::ScrollView::setGtkAdjustments):
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::createScrollbar): Special case.
+ (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment
+ (ScrollbarGtk::~ScrollbarGtk): Disconnect signal
+ (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
+ * platform/gtk/ScrollbarGtk.h:
+
+2009-05-26 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
+ <https://bugs.webkit.org/show_bug.cgi?id=26035>
+ <rdar://problem/6924087>
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
+ is JPEG, there is no image type, or m_decoder is null.
+
+2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix for the JPEGImageDecoder.
+
+ Revision 44167 removed stdio.h from the included headers and
+ this will lead to an error that FILE is not known inside the
+ jpeglib.h Put back the stdio.h include.
+
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+
+2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix the crash issue while running layout tests after enalbed XHTMLMP
+ https://bugs.webkit.org/show_bug.cgi?id=26017
+
+ * dom/Document.cpp:
+ (WebCore::Document::isXHTMLMPDocument):
+
+2009-05-26 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6901751>
+ REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
+
+ Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
+ the improved selection drawing on Tiger.
+
+ * WebCore.Tiger.exp:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::clip):
+ (WebCore::GraphicsContext::clipOut):
+ (WebCore::GraphicsContext::clipOutEllipseInRect):
+ (WebCore::GraphicsContext::clipPath):
+ (WebCore::GraphicsContext::addInnerRoundedRectClip):
+ (WebCore::GraphicsContext::strokeRect):
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::fillSelectionGaps):
+
+2009-05-26 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part two
+ Mostly cosmetic changes, mainly to get image decoders for Cairo build to
+ comply with WebKit style guidelines:
+ * Fix header guard names
+ * Fix initializer list wrapping
+ * Fix class/function "{" wrapping
+ * Fix wrapping of long boolean expressions
+ * Fix whitespace around operators
+ * Eliminate whitespace on otherwise-blank lines
+ * No {} on single-line conditional arms
+ * Use 0 instead of NULL
+ * Don't #include "config.h" in headers
+
+ Also a few non-cosmetic changes:
+ * Remove unneeded #ifdef protecting the contents of these files. The
+ platforms listed don't match who uses these files anymore (even
+ without considering Skia), and platforms which don't use them at all
+ (like CG) aren't harmed by the files, since they don't have
+ equivalently-named classes. It's simpler to just ditch these.
+ * Convert a use of Vector<>& into SharedBuffer*, since that's how the
+ data is really stored anyway.
+ * Use size() instead of m_size, for consistency with Skia code, and
+ future-proofing (if a particular decoder wants to specialize this).
+ * Move an ASSERT that was slightly more aggressive than necessary.
+ * Change variable names/types for clarity/accuracy and to match Skia.
+ * Remove unnecessary macro magic to work around a problem which no
+ longer exists in the third-party JPEG headers.
+ * Stop silencing a portability warning about setjmp (the vcproj/vsprops
+ are the right place for this)
+ * In Skia code, don't explicitly check |m_failed| before calling
+ isSizeAvailable(), which itself checks |m_failed|.
+
+ * platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
+ (WebCore::RGBA32Buffer::):
+ (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
+ (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
+ * platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
+ * platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
+ (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
+ (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
+ (WebCore::GIFImageDecoderPrivate::getColorMap):
+ (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
+ (WebCore::GIFImageDecoder::frameCount): Add comment.
+ (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
+ (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
+ (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
+ (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
+ (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
+ (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
+ * platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
+ * platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
+ (GIFImageReader::read):
+ * platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
+ * platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
+ * platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
+ (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
+ * platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
+ (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
+ (WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
+ (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
+ (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
+ (WebCore::PNGImageDecoder::rowAvailable):
+ * platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
+ (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
+ * platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
+ * platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
+ (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
+ (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
+ * platform/image-decoders/skia/PNGImageDecoder.cpp:
+ (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
+ (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
+ (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
+ (WebCore::rowAvailable):
+ * platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
+ * platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
+ * platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
+
+2009-05-26 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25944
+ Remove the uses of V8 Locker in worker execution code. No additional test is needed.
+ The normal WebKit layout tests should cover it. However, layout tests that start
+ multiple workers will fail to pass due to test shell limitation in Chromium. To cover
+ this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
+
+ * bindings/v8/V8WorkerContextEventListener.cpp:
+ (WebCore::V8WorkerContextEventListener::handleEvent):
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::dispose):
+ (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
+ (WebCore::WorkerContextExecutionProxy::evaluate):
+ (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
+ (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
+
+2009-05-26 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25974
+ Enable timers in Chromuim workers.
+
+ * bindings/v8/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
+ * bindings/v8/ScheduledAction.h:
+ (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
+ (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
+ Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
+
+2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23649
+ Update V8 bindings to match SQLTransactionErrorCallback change.
+
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
+ (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
+
+2009-05-26 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Move FilterEffect to platform/graphics/filters. First step to get an
+ SVG independent filter system.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/filters/FilterEffect.cpp: Added.
+ (WebCore::FilterEffect::FilterEffect):
+ (WebCore::FilterEffect::~FilterEffect):
+ (WebCore::FilterEffect::externalRepresentation):
+ * platform/graphics/filters/FilterEffect.h: Added.
+ (WebCore::FilterEffect::xBoundingBoxMode):
+ (WebCore::FilterEffect::setXBoundingBoxMode):
+ (WebCore::FilterEffect::yBoundingBoxMode):
+ (WebCore::FilterEffect::setYBoundingBoxMode):
+ (WebCore::FilterEffect::widthBoundingBoxMode):
+ (WebCore::FilterEffect::setWidthBoundingBoxMode):
+ (WebCore::FilterEffect::heightBoundingBoxMode):
+ (WebCore::FilterEffect::setHeightBoundingBoxMode):
+ (WebCore::FilterEffect::subRegion):
+ (WebCore::FilterEffect::setSubRegion):
+ (WebCore::FilterEffect::resultImage):
+ (WebCore::FilterEffect::setEffectBuffer):
+ * svg/FilterEffect.cpp: Removed.
+ * svg/FilterEffect.h: Removed.
+
+2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23649
+ Update SQLTransactionErrorCallback to not return a value per changes in
+ HTML5 spec.
+
+ Test: storage/transaction-error-callback.html
+
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h:
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::SQLTransaction):
+ (WebCore::SQLTransaction::postflightAndCommit):
+ (WebCore::SQLTransaction::handleTransactionError):
+ (WebCore::SQLTransaction::deliverTransactionErrorCallback):
+ (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
+ * storage/SQLTransaction.h:
+ * storage/SQLTransactionErrorCallback.h:
+
+2009-05-26 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
+
+ Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
+ continue to show scrollbars.
+
+ Added two tests in fast/dynamic.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2009-05-26 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 25801: change AccessibilityAria -> AccessibilityARIA
+ https://bugs.webkit.org/show_bug.cgi?id=25801
+
+ * GNUmakefile.am:
+ * WebCore.order:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::getOrCreate):
+ * accessibility/AccessibilityARIAGrid.cpp: Copied from WebCore/accessibility/AccessibilityAriaGrid.cpp.
+ (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
+ (WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
+ (WebCore::AccessibilityARIAGrid::create):
+ (WebCore::AccessibilityARIAGrid::addChild):
+ (WebCore::AccessibilityARIAGrid::addChildren):
+ (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
+ * accessibility/AccessibilityARIAGrid.h: Copied from WebCore/accessibility/AccessibilityAriaGrid.h.
+ * accessibility/AccessibilityARIAGridCell.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridCell.cpp.
+ (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
+ (WebCore::AccessibilityARIAGridCell::~AccessibilityARIAGridCell):
+ (WebCore::AccessibilityARIAGridCell::create):
+ (WebCore::AccessibilityARIAGridCell::parentTable):
+ (WebCore::AccessibilityARIAGridCell::rowIndexRange):
+ (WebCore::AccessibilityARIAGridCell::columnIndexRange):
+ * accessibility/AccessibilityARIAGridCell.h: Copied from WebCore/accessibility/AccessibilityAriaGridCell.h.
+ * accessibility/AccessibilityARIAGridRow.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridRow.cpp.
+ (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow):
+ (WebCore::AccessibilityARIAGridRow::~AccessibilityARIAGridRow):
+ (WebCore::AccessibilityARIAGridRow::create):
+ (WebCore::AccessibilityARIAGridRow::parentTable):
+ (WebCore::AccessibilityARIAGridRow::headerObject):
+ * accessibility/AccessibilityARIAGridRow.h: Copied from WebCore/accessibility/AccessibilityAriaGridRow.h.
+ * accessibility/AccessibilityAriaGrid.cpp: Removed.
+ * accessibility/AccessibilityAriaGrid.h: Removed.
+ * accessibility/AccessibilityAriaGridCell.cpp: Removed.
+ * accessibility/AccessibilityAriaGridCell.h: Removed.
+ * accessibility/AccessibilityAriaGridRow.cpp: Removed.
+ * accessibility/AccessibilityAriaGridRow.h: Removed.
+
+2009-05-26 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26012
+
+ Fix the Skia path to normalize the given source rect when
+ drawing patterns, so it accepts negative width/height (as CG does).
+ Fixes Chromium bug http://www.crbug.com/6167.
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::Image::drawPattern):
+
+2009-05-26 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Serialize calls to WebInspector. This is the first step where method
+ calls are being serialized to arrays (not yet JSON stringified ones) and
+ are being dispatched on the client. This change also allows client to override
+ InspectorFrontend, so that the serialized calls can be made on a given object
+ instead of in-process WebInspector global. This will be the main control flow
+ when InspectorController is decoupled from the in-process frontend.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26010
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::scriptObjectReady):
+ (WebCore::InspectorController::overrideFrontendObject):
+ (WebCore::InspectorController::show):
+ (WebCore::InspectorController::populateScriptObjects):
+ * inspector/InspectorController.h:
+ * inspector/InspectorFrontend.cpp:
+ (WebCore::InspectorFrontend::addMessageToConsole):
+ (WebCore::InspectorFrontend::addResource):
+ (WebCore::InspectorFrontend::updateResource):
+ (WebCore::InspectorFrontend::removeResource):
+ (WebCore::InspectorFrontend::updateFocusedNode):
+ (WebCore::InspectorFrontend::setAttachedWindow):
+ (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
+ (WebCore::InspectorFrontend::showPanel):
+ (WebCore::InspectorFrontend::populateInterface):
+ (WebCore::InspectorFrontend::reset):
+ (WebCore::InspectorFrontend::debuggerWasEnabled):
+ (WebCore::InspectorFrontend::debuggerWasDisabled):
+ (WebCore::InspectorFrontend::profilerWasEnabled):
+ (WebCore::InspectorFrontend::profilerWasDisabled):
+ (WebCore::InspectorFrontend::parsedScriptSource):
+ (WebCore::InspectorFrontend::failedToParseScriptSource):
+ (WebCore::InspectorFrontend::addProfile):
+ (WebCore::InspectorFrontend::setRecordingProfile):
+ (WebCore::InspectorFrontend::pausedScript):
+ (WebCore::InspectorFrontend::resumedScript):
+ (WebCore::InspectorFrontend::addDatabase):
+ (WebCore::InspectorFrontend::addDOMStorage):
+ (WebCore::InspectorFrontend::newFunctionCall):
+ (WebCore::InspectorFrontend::callSimpleFunction):
+ * inspector/InspectorFrontend.h:
+ * inspector/front-end/inspector.js:
+ (WebInspector.dispatch):
+
+2009-05-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
+
+ * dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
+ * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
+ Adjust empty namespace before QNameComponentsTranslator black magic, not after.
+
+2009-05-25 David Levin <levin@chromium.org>
+
+ Reviewed by Maciej Stachowiak and Oliver Hunt.
+
+ Added forwarding headers.
+
+ * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
+ * ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
+
+2009-05-25 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - WebCore side of <rdar://problem/6914001>.
+
+ Add a new m_allowPopupsFromPlugin flag.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ (WebCore::ScriptController::processingUserGesture):
+ * bindings/js/ScriptController.h:
+ (WebCore::ScriptController::setAllowPopupsFromPlugin):
+ (WebCore::ScriptController::allowPopupsFromPlugin):
+
+2009-05-25 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26006
+
+ Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
+ window.location. The correct use appears to be as follows:
+
+ 1) Use dynamicGlobalObject to find the user gesture.
+ 2) Use dynamicGlobalObject to complete URLs.
+ 3) Use lexicalGlobalObject to find the referrer.
+ 4) Use lexicalGlobalObject for the frame navigation checks.
+ 5) Use lexicalGlobalObject for the XSS checks.
+
+ Tests: http/tests/security/frameNavigation/context-for-location-assign.html
+ http/tests/security/frameNavigation/context-for-location-href.html
+ http/tests/security/frameNavigation/context-for-location.html
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::shouldAllowNavigation):
+ (WebCore::toLexicalFrame):
+ (WebCore::processingUserGesture):
+ (WebCore::completeURL):
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::navigateIfAllowed):
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::reload):
+ (WebCore::JSLocation::assign):
+ (WebCore::JSLocation::toString):
+ (WebCore::JSLocationPrototype::customPut):
+ * bindings/v8/V8Utilities.cpp:
+ (WebCore::processingUserGesture):
+ (WebCore::shouldAllowNavigation):
+ (WebCore::completeURL):
+ (WebCore::navigateIfAllowed):
+ * bindings/v8/V8Utilities.h:
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::V8Custom::WindowSetLocation):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Maciej Stachowiak.
+
+ With Windows compilers older then MSVC 2005, the functions
+ gmtime_s and localtime_s don't exist. The gmtime and localtime are
+ on Windows always thread safe. So use them in the cases where
+ gmtime_s and localtime_s are not present.
+
+ * loader/FTPDirectoryDocument.cpp:
+ * loader/FTPDirectoryParser.cpp:
+
+2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ Follow up on r44120. PluginPackageMac.cpp is used
+ by Qt on Mac and contained a copy of the m_browserFunc
+ assignments and ::equal, ::hash and ::compareFileVersion.
+ Change it to use the ones from PluginPackage.cpp as well.
+
+ * plugins/mac/PluginPackageMac.cpp:
+ (WebCore::PluginPackage::load):
+
+2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25612
+
+ Support conditionals in the tag factories, by placing
+ feature #ifdefs around the individual factory functions
+ and the registration.
+
+ Made the Audio and Video elements conditional in the tag factories
+
+ * html/HTMLTagNames.in:
+ * dom/make_names.pl:
+
+2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Gtk build when video is disabled.
+
+ * GNUmakefile.am: Always generate and compile the IDL files for the media
+ elements. They contain proper feature #ifdefs.
+
+2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build when video is disabled.
+
+ * WebCore.pro: Always generate the IDL files for the media elements. They
+ contain proper ENABLE(VIDEO) #ifdefs.
+
+2009-05-25 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26004
+
+ The origin for postMessage should follow lexical scope, not dynamic
+ scope. Yes, this is a super-obscure corner case.
+
+ Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::postMessage):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-24 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix build bustage related to PassOwnPtr changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25999
+
+ * platform/graphics/chromium/TransparencyWin.cpp:
+
+2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25988
+
+ Minor cleanup in PluginPackage::hash. Let the compiler
+ figure out the size of the array. Do not have it in the
+ definition and specially not the in the call to
+ StringImpl::hash.
+
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::hash):
+
+2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25988
+
+ Move ::hash, ::equal and ::compareFileVersion from
+ the duplicated copies in PluginPackageQt.cpp and
+ PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
+ this for the PluginPackageWin version. Use the new style
+ ENABLE() for this feature/policy and enable it in the Gtk+
+ and Qt buildsystem.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::hash):
+ (WebCore::PluginPackage::equal):
+ (WebCore::PluginPackage::compareFileVersion):
+ * plugins/gtk/PluginPackageGtk.cpp:
+ * plugins/qt/PluginPackageQt.cpp:
+
+2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25988
+
+ So far the initialization of the browserfuncs struct
+ is done in PluginPackageQt, PluginPackageGtk and
+ PluginPackageWin there is no need for this duplication.
+
+ The PluginPackageWin version got copied to PluginPackage
+
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::initializeBrowserFuncs):
+ * plugins/PluginPackage.h:
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::load):
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::load):
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::load):
+
+2009-05-24 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ Added standard input for filter system.
+
+ No testcases were added. Filter system is still off.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/filters/SourceAlpha.cpp: Added.
+ (WebCore::SourceAlpha::create):
+ (WebCore::SourceAlpha::effectName):
+ (WebCore::SourceAlpha::apply):
+ (WebCore::SourceAlpha::dump):
+ * platform/graphics/filters/SourceAlpha.h: Added.
+ (WebCore::SourceAlpha::SourceAlpha):
+ * platform/graphics/filters/SourceGraphic.cpp: Added.
+ (WebCore::SourceGraphic::create):
+ (WebCore::SourceGraphic::effectName):
+ (WebCore::SourceGraphic::apply):
+ (WebCore::SourceGraphic::dump):
+ * platform/graphics/filters/SourceGraphic.h: Added.
+ (WebCore::SourceGraphic::SourceGraphic):
+ * svg/FilterBuilder.cpp: Added.
+ (WebCore::FilterBuilder::FilterBuilder):
+ (WebCore::FilterBuilder::add):
+ (WebCore::FilterBuilder::getEffectById):
+ (WebCore::FilterBuilder::clearEffects):
+ * svg/FilterBuilder.h:
+
+2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25612
+
+ Add support conditionals in the JSC bindings generator code for attributes,
+ by placing feature #ifdefs around the setters/getters.
+
+ Made the audio and video element specific DOM attributes conditional
+ in the generated code, by moving the #ifdefs from the IDL files into
+ the generated code. This allows for re-using the same generated code
+ with or without ENABLE(VIDEO).
+
+ * page/DOMWindow.idl:
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
+
+ * platform/text/qt/TextCodecQt.cpp:
+ (WebCore::newTextCodecQt):
+
+2009-05-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - clean up ColorMac a little
+
+ * platform/graphics/mac/ColorMac.h: Whitespace change.
+ * platform/graphics/mac/ColorMac.mm: Removed redundant #import
+ statements and sorted the remaining ones.
+ (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
+ with a single call and removed redundant casts to int.
+ (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
+ In one case, this avoids an intermediate conversion to float before
+ conversion to double on 64-bit.
+ (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
+ with a single call.
+ (WebCore::focusRingColor):
+ (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
+
+2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
+ https://bugs.webkit.org/show_bug.cgi?id=25900
+
+ Use ATK_ROLE_TEXT for ListMarkerRole.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (atkRole):
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Reformat WebCore::requiresContextForWordBoundary()
+
+ * platform/text/TextBoundaries.h:
+ (WebCore::requiresContextForWordBoundary):
+
+2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::shouldContentSniffURL):
+
+2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
+
+ After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
+ RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
+ This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
+
+ WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
+ HTMLSelectElement/WMLSelectElement.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * accessibility/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::addChildren):
+ (WebCore::AccessibilityListBox::doAccessibilityHitTest):
+ * accessibility/AccessibilityListBoxOption.cpp:
+ (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::actionElement):
+ * dom/Element.h:
+ (WebCore::Element::isFormControlElement):
+ (WebCore::Element::dispatchFormControlChangeEvent):
+ * dom/SelectElement.cpp: Added.
+ (WebCore::toSelectElement):
+ * dom/SelectElement.h: Added.
+ (WebCore::SelectElement::~SelectElement):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
+ * html/HTMLFormControlElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setChecked):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::index):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::selectedIndex):
+ (WebCore::HTMLSelectElement::lastSelectedListIndex):
+ (WebCore::HTMLSelectElement::deselectItems):
+ (WebCore::HTMLSelectElement::setSelectedIndex):
+ (WebCore::HTMLSelectElement::length):
+ (WebCore::HTMLSelectElement::remove):
+ (WebCore::HTMLSelectElement::value):
+ (WebCore::HTMLSelectElement::setValue):
+ (WebCore::HTMLSelectElement::saveFormControlState):
+ (WebCore::HTMLSelectElement::restoreFormControlState):
+ (WebCore::HTMLSelectElement::selectAll):
+ (WebCore::HTMLSelectElement::appendFormData):
+ (WebCore::HTMLSelectElement::optionToListIndex):
+ (WebCore::HTMLSelectElement::listToOptionIndex):
+ (WebCore::HTMLSelectElement::recalcListItems):
+ (WebCore::HTMLSelectElement::reset):
+ (WebCore::HTMLSelectElement::dispatchFocusEvent):
+ (WebCore::HTMLSelectElement::dispatchBlurEvent):
+ (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ (WebCore::HTMLSelectElement::menuListOnChange):
+ (WebCore::HTMLSelectElement::listBoxOnChange):
+ (WebCore::HTMLSelectElement::saveLastSelection):
+ (WebCore::HTMLSelectElement::typeAheadFind):
+ (WebCore::HTMLSelectElement::nextSelectableListIndex):
+ (WebCore::HTMLSelectElement::previousSelectableListIndex):
+ (WebCore::HTMLSelectElement::setLength):
+ (WebCore::HTMLSelectElement::checkListItems):
+ * html/HTMLSelectElement.h:
+ (WebCore::HTMLSelectElement::size):
+ (WebCore::HTMLSelectElement::multiple):
+ (WebCore::HTMLSelectElement::listItems):
+ (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::shouldContentSniffURL):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::valueChanged):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::RenderListBox):
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::scrollToRevealSelection):
+ (WebCore::RenderListBox::size):
+ (WebCore::RenderListBox::numItems):
+ (WebCore::RenderListBox::paintItemForeground):
+ (WebCore::RenderListBox::paintItemBackground):
+ (WebCore::RenderListBox::panScroll):
+ (WebCore::RenderListBox::autoscroll):
+ (WebCore::RenderListBox::stopAutoscroll):
+ (WebCore::RenderListBox::valueChanged):
+ (WebCore::RenderListBox::nodeAtPoint):
+ * rendering/RenderListBox.h:
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::RenderMenuList):
+ (WebCore::RenderMenuList::updateOptionsWidth):
+ (WebCore::RenderMenuList::updateFromElement):
+ (WebCore::RenderMenuList::setTextFromOption):
+ (WebCore::RenderMenuList::showPopup):
+ (WebCore::RenderMenuList::valueChanged):
+ (WebCore::RenderMenuList::itemText):
+ (WebCore::RenderMenuList::itemIsEnabled):
+ (WebCore::RenderMenuList::itemStyle):
+ (WebCore::RenderMenuList::itemBackgroundColor):
+ (WebCore::RenderMenuList::listSize):
+ (WebCore::RenderMenuList::selectedIndex):
+ (WebCore::RenderMenuList::itemIsSeparator):
+ (WebCore::RenderMenuList::itemIsLabel):
+ (WebCore::RenderMenuList::itemIsSelected):
+ (WebCore::RenderMenuList::setTextFromItem):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::setValueForPosition):
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Fix Gtk/Qt builds for PassOwnPtr
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
+ instead of an std::auto_ptr<ImageBuffer> to store the result of
+ ImageBuffer::create() now that it returns a
+ PassOwnPtr<ImageBuffer>.
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::Path::strokeContains): Ditto.
+ (WebCore::Path::strokeBoundingRect): Ditto.
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25495>
+
+ Reviewed by Oliver Hunt.
+
+ No test cases added since there is no change in behavior.
+
+ * WebCore.base.exp: Updated export for
+ HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
+ * dom/Node.cpp:
+ (WebCore::Node::childNodes): Use NodeListsNodeData::create()
+ instead of new NodeListsNodeData.
+ (WebCore::Node::registerDynamicNodeList): Ditto.
+ (WebCore::Node::getElementsByTagNameNS): Ditto.
+ (WebCore::Node::getElementsByName): Ditto.
+ (WebCore::Node::getElementsByClassName): Ditto.
+ * dom/NodeRareData.h:
+ (WebCore::NodeListsNodeData::create): Added. Implements
+ create() pattern popularized by RefCounted classes.
+ (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
+ private constructor.
+ (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
+ instead of an auto_ptr<>.
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::setRedirectURLs): Ditto.
+ * history/HistoryItem.h:
+ (WebCore::HistoryItem::setRedirectURLs): Ditto.
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
+ OwnPtr<> instead of auto_ptr<> for stack variable.
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
+ assignment operator now that ImageBuffer::create() returns a
+ PassOwnPtr<>.
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
+ PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
+ * platform/graphics/GeneratedImage.cpp:
+ (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
+ auto_ptr<> for stack variable.
+ * platform/graphics/ImageBuffer.h:
+ (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
+ auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack
+ variable.
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
+ auto_ptr<> for stack variable.
+ * platform/text/TextCodec.h:
+ (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
+ auto_ptr<>.
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::newTextCodecICU): Ditto.
+ * platform/text/TextCodecLatin1.cpp:
+ (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
+ * platform/text/TextCodecUTF16.cpp:
+ (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
+ (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
+ * platform/text/TextCodecUserDefined.cpp:
+ (WebCore::newStreamingTextDecoderUserDefined): Ditto.
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::newTextCodec): Ditto.
+ * platform/text/TextEncodingRegistry.h:
+ (WebCore::newTextCodec): Ditto.
+ * platform/text/mac/TextCodecMac.cpp:
+ (WebCore::newTextCodecMac): Ditto.
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
+ OwnPtr<> instead of auto_ptr<> for stack variable.
+ * svg/SVGMaskElement.cpp:
+ (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return
+ OwnPtr<> instead of auto_ptr<>.
+ * svg/SVGMaskElement.h:
+ (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
+ instead of auto_ptr<>.
+ * svg/SVGPatternElement.cpp:
+ (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
+ of auto_ptr<> for stack variable.
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
+ assignment operator now that ImageBuffer::create() returns a
+ PassOwnPtr<>.
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
+ instead of auto_ptr<> for stack variable.
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ (WebCore::SVGPaintServerPattern::setTile): Updated to take a
+ PassOwnPtr<> instead of an auto_ptr<>.
+ (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
+ auto_ptr<> for stack variable.
+ * svg/graphics/SVGPaintServerPattern.h:
+ (WebCore::SVGPaintServerPattern::setTile): Updated to take a
+ PassOwnPtr<> instead of an auto_ptr<>.
+ * svg/graphics/SVGResourceMasker.cpp:
+ (WebCore::SVGResourceMasker::applyMask): Updated to use
+ assignment operator now that SVGMaskElement::drawMaskerContent()
+ returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for
+ stack variable.
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25495>
+
+ Reviewed by Oliver Hunt.
+
+ * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
+ * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
+ * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
+ PassOwnPtr.h.
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Fix Mac builds by backing out r44093
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ * bindings/js/JSCustomPositionCallback.h:
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ * bindings/js/JSCustomPositionErrorCallback.h:
+ * bindings/js/JSGeolocationCustom.cpp:
+ * page/Geolocation.cpp:
+ * page/Geolocation.idl:
+ * page/Geoposition.cpp:
+ * page/Geoposition.h:
+ * page/Geoposition.idl:
+ * page/Navigator.cpp:
+ (WebCore::Navigator::disconnectFrame):
+ (WebCore::Navigator::geolocation):
+ * page/PositionError.idl:
+ * platform/GeolocationService.cpp:
+ (WebCore::GeolocationService::create):
+
+2009-05-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Eric Seidel.
+
+ Add GEOLOCATION guards around Geolocation API code
+ https://bugs.webkit.org/show_bug.cgi?id=25756
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ * bindings/js/JSCustomPositionCallback.h:
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ * bindings/js/JSCustomPositionErrorCallback.h:
+ * bindings/js/JSGeolocationCustom.cpp:
+ * page/Geolocation.cpp:
+ * page/Geolocation.idl:
+ * page/Geoposition.cpp:
+ * page/Geoposition.h:
+ * page/Geoposition.idl:
+ * page/Navigator.cpp:
+ (WebCore::Navigator::disconnectFrame):
+ (WebCore::Navigator::geolocation):
+ * page/PositionError.idl:
+ * platform/GeolocationService.cpp:
+
+2009-05-23 David Kilzer <ddkilzer@apple.com>
+
+ Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
+
+ In r42377, startUpdateRenderingDispatcher() was renamed to
+ startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
+ dropped. This change restores it.
+
+ * WebCore.order:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
+ (WebCore::AnimationControllerPrivate::addEventToDispatch):
+ (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
+ (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
+ (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
+ * page/animation/AnimationControllerPrivate.h:
+
+2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build-fix for Qt. Disable SVG Filters.
+
+ SVG Filters can not be built right now and Qt should not have
+ them enabled anyway as they do not carry out any filtering.
+
+ * WebCore.pro:
+
+2009-05-23 Dirk Schulze <krit@webkit.org>
+
+ Unreviewed build-fix for gtk. Remove source input files
+ for SVG filter system from the build for the moment and
+ add them later again.
+
+ * GNUmakefile.am:
+
+2009-05-23 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ WebKit needs cross-platform filter system
+ [https://bugs.webkit.org/show_bug.cgi?id=19991]
+
+ Preparing Filter primitves for the new filter system.
+
+ No testcases were added. SVG filters are off by default.
+
+ * GNUmakefile.am:
+ * platform/graphics/filters/FEBlend.cpp:
+ (WebCore::FEBlend::apply):
+ * platform/graphics/filters/FEBlend.h:
+ * platform/graphics/filters/FEColorMatrix.cpp:
+ (WebCore::FEColorMatrix::apply):
+ * platform/graphics/filters/FEColorMatrix.h:
+ * platform/graphics/filters/FEComponentTransfer.cpp:
+ (WebCore::FEComponentTransfer::apply):
+ * platform/graphics/filters/FEComponentTransfer.h:
+ * platform/graphics/filters/FEComposite.cpp:
+ (WebCore::FEComposite::apply):
+ * platform/graphics/filters/FEComposite.h:
+ * svg/Filter.h:
+ * svg/FilterBuilder.h:
+ (WebCore::FilterBuilder::lastFilter):
+ * svg/FilterEffect.cpp:
+ (WebCore::FilterEffect::FilterEffect):
+ * svg/FilterEffect.h:
+ (WebCore::FilterEffect::xBoundingBoxMode):
+ (WebCore::FilterEffect::setXBoundingBoxMode):
+ (WebCore::FilterEffect::yBoundingBoxMode):
+ (WebCore::FilterEffect::setYBoundingBoxMode):
+ (WebCore::FilterEffect::widthBoundingBoxMode):
+ (WebCore::FilterEffect::setWidthBoundingBoxMode):
+ (WebCore::FilterEffect::heightBoundingBoxMode):
+ (WebCore::FilterEffect::setHeightBoundingBoxMode):
+ (WebCore::FilterEffect::subRegion):
+ (WebCore::FilterEffect::setSubRegion):
+ (WebCore::FilterEffect::resultImage):
+ (WebCore::FilterEffect::setEffectBuffer):
+ * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
+ (WebCore::FEConvolveMatrix::apply):
+ * svg/graphics/filters/SVGFEConvolveMatrix.h:
+ * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
+ (WebCore::FEDiffuseLighting::apply):
+ * svg/graphics/filters/SVGFEDiffuseLighting.h:
+ * svg/graphics/filters/SVGFEDisplacementMap.cpp:
+ (WebCore::FEDisplacementMap::apply):
+ * svg/graphics/filters/SVGFEDisplacementMap.h:
+ * svg/graphics/filters/SVGFEFlood.cpp:
+ (WebCore::FEFlood::apply):
+ * svg/graphics/filters/SVGFEFlood.h:
+ * svg/graphics/filters/SVGFEGaussianBlur.cpp:
+ (WebCore::FEGaussianBlur::apply):
+ * svg/graphics/filters/SVGFEGaussianBlur.h:
+ * svg/graphics/filters/SVGFEImage.cpp:
+ (WebCore::FEImage::apply):
+ * svg/graphics/filters/SVGFEImage.h:
+ * svg/graphics/filters/SVGFEMerge.cpp:
+ (WebCore::FEMerge::apply):
+ * svg/graphics/filters/SVGFEMerge.h:
+ * svg/graphics/filters/SVGFEMorphology.cpp:
+ (WebCore::FEMorphology::apply):
+ * svg/graphics/filters/SVGFEMorphology.h:
+ * svg/graphics/filters/SVGFEOffset.cpp:
+ (WebCore::FEOffset::apply):
+ * svg/graphics/filters/SVGFEOffset.h:
+ * svg/graphics/filters/SVGFESpecularLighting.cpp:
+ (WebCore::FESpecularLighting::apply):
+ * svg/graphics/filters/SVGFESpecularLighting.h:
+ * svg/graphics/filters/SVGFETile.cpp:
+ (WebCore::FETile::apply):
+ * svg/graphics/filters/SVGFETile.h:
+ * svg/graphics/filters/SVGFETurbulence.cpp:
+ (WebCore::FETurbulence::apply):
+ * svg/graphics/filters/SVGFETurbulence.h:
+
+2009-05-22 Dirk Schulze <krit@webkit.org>
+
+ Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::Image::drawPattern):
+
+2009-05-22 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Added the use of tileRect() for a correct drawing of
+ border-images.
+
+ Testcases for border-image are in fast/borders like
+ border-image-01.html and will be activated for cairo, once
+ gtk supports pixel tests.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19652
+ [CAIRO] wrong drawing of border-image
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::Image::drawPattern):
+
+2009-05-22 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25684
+
+ Ask the Scrollbar for the orientation.
+
+ Use Scrollbar::orientation to figure out the
+ direction of scrolling.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::valueChanged):
+
+2009-05-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6916082> Incorrect handling of % as CSS value.
+
+ Test: fast/css/percent-character-as-value.html
+
+ * css/CSSGrammar.y: Make a stray % character reliably cause
+ CSS parsing to succeed, but the CSS value to be ignored because
+ of incorrect type. A type of 0 has this effect.
+
+2009-05-22 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25971
+ Correct a handful of build errors in the Windows Cairo variant
+ due to missing VIDEO support.
+
+ * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
+ the Cairo-based Windows target.
+ * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
+ for non-VIDEO builds.
+
+2009-05-22 David Kilzer <ddkilzer@apple.com>
+
+ One <limits> is enough
+
+ * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
+
+2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
+
+ <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
+ plug-in
+
+ Reviewed by Steve Falkenburg.
+
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::determineQuirks):
+ Look for the VLC plug-in's new name.
+
+2009-05-22 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25966
+
+ Remove redudant member from Chromium's ResourceRequest. We already
+ have this data in the cross-platform ResourceRequestBase. Also, rename
+ ChromiumBridge parameter to be consistant with the new name for this
+ piece of data.
+
+ * platform/chromium/ChromiumBridge.h:
+ * platform/network/chromium/ResourceRequest.h:
+
+2009-05-22 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Only account for overhang for multi-character strings.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25961
+
+ * platform/wx/wxcode/win/fontprops.cpp:
+ (GetTextExtent):
+
+2009-05-22 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Switch to CURL cookies so we can benefit from API updates.
+
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * webcore-wx.bkl:
+
+2009-05-22 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25709 part one
+ Indent contents of namespaces in header files, to comply with the
+ style guide. No functional change.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::):
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::bytes):
+ (WebCore::RGBA32Buffer::rect):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::status):
+ (WebCore::RGBA32Buffer::duration):
+ (WebCore::RGBA32Buffer::disposalMethod):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setRect):
+ (WebCore::RGBA32Buffer::ensureHeight):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::setDuration):
+ (WebCore::RGBA32Buffer::setDisposalMethod):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setRGBA):
+ (WebCore::ImageDecoder::m_failed):
+ (WebCore::ImageDecoder::~ImageDecoder):
+ (WebCore::ImageDecoder::setData):
+ (WebCore::ImageDecoder::size):
+ (WebCore::ImageDecoder::frameCount):
+ (WebCore::ImageDecoder::repetitionCount):
+ (WebCore::ImageDecoder::supportsAlpha):
+ (WebCore::ImageDecoder::failed):
+ (WebCore::ImageDecoder::setFailed):
+ (WebCore::ImageDecoder::clearFrameBufferCache):
+ * platform/image-decoders/bmp/BMPImageDecoder.h:
+ (WebCore::BMPImageDecoder::filenameExtension):
+ * platform/image-decoders/gif/GIFImageDecoder.h:
+ (WebCore::GIFImageDecoder::filenameExtension):
+ (WebCore::GIFImageDecoder::frameDurationAtIndex):
+ (WebCore::GIFImageDecoder::):
+ * platform/image-decoders/ico/ICOImageDecoder.h:
+ (WebCore::ICOImageDecoder::filenameExtension):
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h:
+ (WebCore::JPEGImageDecoder::filenameExtension):
+ (WebCore::JPEGImageDecoder::supportsAlpha):
+ (WebCore::JPEGImageDecoder::reader):
+ (WebCore::JPEGImageDecoder::setSize):
+ * platform/image-decoders/png/PNGImageDecoder.h:
+ (WebCore::PNGImageDecoder::filenameExtension):
+ (WebCore::PNGImageDecoder::reader):
+ (WebCore::PNGImageDecoder::decodingFailed):
+ * platform/image-decoders/xbm/XBMImageDecoder.h:
+ (WebCore::XBMImageDecoder::filenameExtension):
+
+2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15914
+ [GTK] Implement Unicode functionality using GLib
+
+ Minor changes that allow building a hybrid version of WebKit
+ that has WTF Unicode backend based on GLib functions while
+ text codecs and TextBreakIterator remain based on ICU.
+
+ Fixed some includes that were assuming a WTF ICU backend and
+ introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
+ macro.
+
+ * platform/ThreadGlobalData.cpp:
+ (WebCore::ThreadGlobalData::ThreadGlobalData):
+ (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ * platform/ThreadGlobalData.h:
+ * platform/text/TextBoundariesICU.cpp:
+ * platform/text/TextCodecICU.h:
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::encode):
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::buildBaseTextCodecMaps):
+ (WebCore::extendTextCodecMaps):
+
+2009-05-22 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25955
+
+ Remove the policyBaseURL parameter from setCookie. This parameter is
+ redundant with the document parameter.
+
+ * WebCore.base.exp:
+ * WebCore.order:
+ * dom/Document.cpp:
+ (WebCore::Document::setCookie):
+ * platform/CookieJar.h:
+ * platform/mac/CookieJar.mm:
+ (WebCore::setCookies):
+ * platform/network/chromium/CookieJarChromium.cpp:
+ (WebCore::setCookies):
+ * platform/network/curl/CookieJarCurl.cpp:
+ (WebCore::setCookies):
+ * platform/network/soup/CookieJarSoup.cpp:
+ (WebCore::setCookies):
+ * platform/network/win/CookieJarCFNetWin.cpp:
+ (WebCore::setCookies):
+ * platform/network/win/CookieJarWin.cpp:
+ (WebCore::setCookies):
+ * platform/qt/CookieJarQt.cpp:
+ (WebCore::setCookies):
+
+2009-05-22 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25955
+
+ Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
+ previous names were confusing and inaccurate.
+
+ * WebCore.order:
+ * dom/Document.cpp:
+ (WebCore::Document::setCookie):
+ * dom/Document.h:
+ (WebCore::Document::firstPartyForCookies):
+ (WebCore::Document::setFirstPartyForCookies):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::begin):
+ (WebCore::FrameLoader::updateFirstPartyForCookies):
+ (WebCore::FrameLoader::setFirstPartyForCookies):
+ (WebCore::FrameLoader::open):
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+ (WebCore::FrameLoader::loadResourceSynchronously):
+ * loader/FrameLoader.h:
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::willSendRequest):
+ (WebCore::ResourceRequestBase::adopt):
+ (WebCore::ResourceRequestBase::copyData):
+ (WebCore::ResourceRequestBase::firstPartyForCookies):
+ (WebCore::ResourceRequestBase::setFirstPartyForCookies):
+ (WebCore::equalIgnoringHeaderFields):
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/cf/ResourceRequestCFNet.cpp:
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ * platform/network/chromium/CookieJarChromium.cpp:
+ (WebCore::setCookies):
+ * platform/network/mac/ResourceRequestMac.mm:
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::firstPartyForCookies):
+ (WebCore::ResourceRequestBase::setFirstPartyForCookies):
+ * platform/network/chromium/CookieJarChromium.cpp:
+ (WebCore::setCookies):
+ * platform/network/curl/CookieJarCurl.cpp:
+ (WebCore::setCookies):
+ * platform/network/soup/CookieJarSoup.cpp:
+ (WebCore::setCookies):
+ * platform/network/win/CookieJarCFNetWin.cpp:
+ (WebCore::setCookies):
+ * platform/network/win/CookieJarWin.cpp:
+ (WebCore::setCookies):
+ * platform/qt/CookieJarQt.cpp:
+ (WebCore::setCookies):
+
+2009-05-22 Pavel Feldman <pfeldman@chromium.org>
+
+ Fix the call to editingCancelled to be this._editingCancelled, since
+ editingCancelled doesn't exist and throws an exception.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=24881>
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
+
+2009-05-22 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25928
+ Several errors detected by cppcheck
+
+ Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
+ should take a look at other reports.
+
+ * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
+ are billions of those.
+
+2009-05-22 Shinichiro Hamaji <hamaji@google.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
+ This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
+
+ https://bugs.webkit.org/show_bug.cgi?id=25956
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::drawLine):
+ (WebCore::GraphicsContext::strokeArc):
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::fillRoundedRect):
+ (WebCore::GraphicsContext::strokeRect):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::drawEllipse):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+
+2009-05-22 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ Revert the whole thing, since we can't figure out a way to make it
+ work in all platforms.
+
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::pathForDecoration):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+
+2009-05-22 Xan Lopez <xlopez@igalia.com>
+
+ Try to fix Windows build.
+
+ Apparently it can't tell if '1.0f' is float or double, so cast to
+ float.
+
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::pathForDecoration):
+
+2009-05-22 Xan Lopez <xlopez@igalia.com>
+
+ Try to fix breakage from the previous patch.
+
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::pathForDecoration):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+
+2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25805
+ In debug build, mingw win32 build has problems with powf
+
+ Change C-style calls to powf and sqrtf to C++-style calls to
+ overloaded pow and sqrt. This solves also a problem with mingw
+ compiler during the debug build.
+
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::pathForDecoration):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+
+2009-05-21 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6913680> Update image caching options.
+ Disable extra ImageIO cache because we already handle caching decoded image data.
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::imageSourceOptions):
+
+2009-05-21 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 25903: Create a default UI theme for media controls in Chromium.
+ https://bugs.webkit.org/show_bug.cgi?id=25903
+
+ Implement a default UI for chromium. Add a style sheet for Chromium
+ media controls with good defaults and implemented basic draw functions
+ for play/pause & mute buttons.
+
+ * css/mediaControlsChromium.css: Added.
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
+ our custom media controls style sheet.
+ (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
+ buttons respecting chromium media controls color scheme.
+ (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
+ specific to play/pause button.
+ (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
+ specific to mute button.
+ * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
+ our custom media controls style sheet.
+ (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
+ buttons respecting chromium media controls color scheme.
+ (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
+ specific to play/pause button.
+ (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
+ to mute button.
+ (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
+ header changes.
+ * rendering/RenderThemeChromiumWin.h:
+
+2009-05-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ When stripping the query from a file:// URL, do not leave a trailing question mark.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25940
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::initializeHandle):
+
+2009-05-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Notify ImageObserver::didDraw to help the cache purge alive resources.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25942
+
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+ (WebCore::BitmapImage::drawPattern):
+
+2009-05-21 Evan Martin <evan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Flesh out font fallback for Chromium's Skia port.
+ getLastResortFallbackFont should fall back on well-known fonts.
+ https://bugs.webkit.org/show_bug.cgi?id=25860
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont): try known font names.
+
+2009-05-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - speculative fix for <rdar://problem/6890716> crash at
+ FontCache::purgeInactiveFontData + 199
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
+ can cause releaseFontData() to be called, which modifies
+ gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
+ while iterating over gInactiveFontData and delete them afterwards.
+
+2009-05-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
+ Incorrect URL returned to the DOM while the user drags a file
+
+ * page/DragController.cpp:
+ (WebCore::DragController::dragExited):
+ (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
+ since that only looks at the text of the document's URL. Do base our
+ decision on the securityOrigin(), which knows more about the document's
+ actual origin.
+
+2009-05-21 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Mark Rowe.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=25947
+ Assertion failure in FrameLoader::transitionToCommitted on launch in
+ Safari with r43985
+
+ Rolled out r43979.
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedNonImageMimeTypes):
+ (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
+
+2009-05-21 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Brady Eidson and Mark Rowe.
+
+ Fix for <rdar://problem/6901522>
+ REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
+
+ If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
+ the MIME type to be text/html.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
+
+2009-05-21 Kevin Ollivier <kevino@theolliviers.com>
+
+ Blind windows fix after last commit.
+
+ * platform/Logging.cpp:
+ (WebCore::getChannelFromName):
+
+2009-05-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Use an environment variable to control which logs are on and off.
+ Also, make a generic function for translating channel name to its log.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25936
+
+ * platform/Logging.cpp:
+ (WebCore::getChannelFromName):
+ * platform/Logging.h:
+ * platform/wx/LoggingWx.cpp:
+ (WebCore::InitializeLoggingChannelsIfNecessary):
+
+2009-05-21 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
+ https://bugs.webkit.org/show_bug.cgi?id=25946
+
+ A very simple implementation to keep it working. A bug has been filed in the chromium db
+ (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
+ complete.
+
+ * platform/chromium/MimeTypeRegistryChromium.cpp:
+ (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
+
+2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>
+
+ Reviewed by Justin Garcia.
+
+ Add automatic spell correction support in WebKit
+
+ https://bugs.webkit.org/show_bug.cgi?id=24953
+
+ * editing/Editor.cpp:
+ (WebCore::findFirstMisspellingInRange):
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+ (WebCore::markAllMisspellingsInRange):
+ (WebCore::markMisspellingsOrBadGrammar):
+ (WebCore::Editor::markMisspellings):
+ (WebCore::Editor::markBadGrammar):
+ (WebCore::Editor::markMisspellingsAndBadGrammar):
+ * editing/Editor.h:
+ * loader/EmptyClients.h:
+ (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
+ * page/EditorClient.h:
+
+2009-05-21 Christian Dywan <christian@twotoasts.de>
+
+ Reviewed by Darin Adler.
+
+ Text files which have sub MIME types are treated as not displayable
+ http://bugs.webkit.org/show_bug.cgi?id=24903
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedNonImageMimeTypes):
+ (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
+ MIME type beginning with "text/" as supported and remove all "text/"
+ types from the list.
+
+2009-05-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25890
+ Implement Network logging channel on Mac
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::~ResourceHandle):
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::cancel):
+ (WebCore::ResourceHandle::setDefersLoading):
+ (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
+ (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
+ (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
+ (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
+ Added logging for async requests (as these are most interesting).
+
+2009-05-21 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by David Kilzer.
+
+ <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
+
+ Add a static table to map from some common file extensions to their MIME types so it
+ is possible to detect support even when the platform mapping is incomplete. Use the
+ table to lookup types not found by UTI on the OSX, and when looking for a media engine
+ with a generic or missing type.
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
+ (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
+ MIME type in the static mapping table if the platform specific getMIMETypeForExtension
+ doesn't find a match.
+ * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
+ "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
+ to MIME type if UTI fails.
+
+2009-05-21 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Clean up DragController
+ https://bugs.webkit.org/show_bug.cgi?id=25926
+
+ I renamed m_document to m_documentUnderMouse to better document what it does
+ I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
+ long enough.
+
+ I also saw copy/paste code involving clearing the selection when moving out of
+ one document and into another. I moved that code into a function called
+ mouseMovedIntoDocument.
+
+ I also got rid of a couple needless null-checks after confirming via source
+ inspection they were not ever possible.
+ In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
+ I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
+ It's also not possible to return a document from documentAtPoint that is not
+ in a frame (as such a document would not be rendered).
+
+ No functional changes, thus no tests.
+
+ * page/DragController.cpp:
+ (WebCore::DragController::DragController):
+ (WebCore::DragController::dragIsMove):
+ (WebCore::DragController::dragExited):
+ (WebCore::DragController::performDrag):
+ (WebCore::DragController::mouseMovedIntoDocument):
+ (WebCore::DragController::dragEnteredOrUpdated):
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::DragController::operationForLoad):
+ (WebCore::DragController::concludeEditDrag):
+ (WebCore::DragController::canProcessDrag):
+ (WebCore::DragController::tryDHTMLDrag):
+ (WebCore::DragController::placeDragCaret):
+ * page/DragController.h:
+ (WebCore::DragController::documentUnderMouse):
+
+2009-05-21 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Rename DragController::dragOperation() to sourceDragOperation() for clarity
+ Remove unused setDragOperation()
+
+ There are two times DragOperation is used. The source specifies
+ what drag operations it supports (in a mask) and the destination
+ picks a subset of those as DragOperations it supports if a drop were
+ to occur. I was confused when I first saw this accessor as to which
+ it meant. It turns out that this is only used when WebKit starts a
+ drag, and we keep it around so that we can provide this information
+ to other Mac OS X applications when they ask. I've renamed the method
+ for clarity so the next person in this code will be less confused.
+
+ No functional changes, thus no tests.
+
+ * page/DragController.h:
+ (WebCore::DragController::sourceDragOperation):
+
+2009-05-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
+ crash painting the selection on registration page of car2go.com
+
+ A bug in old versions of Core Graphics causes memory corruption to occur
+ when clipping under certain conditions. Make the clipping functions
+ fail silently under those conditions.
+
+ Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
+
+ * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
+ on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
+ (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
+ (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
+ (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
+ of CGContextClip, CGContextEOClip and CGContextClipToRect.
+ (WebCore::GraphicsContext::strokePath): Ditto.
+ (WebCore::GraphicsContext::fillRect): Ditto.
+ (WebCore::GraphicsContext::clip): Ditto.
+ (WebCore::GraphicsContext::clipOut): Ditto.
+ (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
+ (WebCore::GraphicsContext::clipPath): Ditto.
+ (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
+ (WebCore::GraphicsContext::strokeRect): Ditto.
+ * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
+ * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
+
+2009-05-21 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25910
+ WebkitGTK r43960 cannot compile
+
+ Do not include local copy of guriescape header, which was
+ removed. We now use the copy in glib.
+
+ * platform/gtk/FileSystemGtk.cpp:
+
+2009-05-20 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25706
+
+ It turns out the CurrentContext wasn't currect either because it gave
+ us the frame for the write() function itself. We actually want the
+ *calling* context.
+
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] Implement Image::loadPlatformResource.
+
+ Install the four resources we are using. For the icons
+ where an icon name is specified by freedeskop.org try to
+ map the WebCore name to that name and fallback to the
+ internal icon. For everything else use the internal icon
+ name. Remove the temporary link stub as this is not
+ required any more.
+
+ * GNUmakefile.am: Install the png files, set DATA_DIR again
+ * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
+ * platform/graphics/gtk/ImageGtk.cpp:
+ (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
+ (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
+ (WebCore::loadResourceIntoSharedBuffer):
+ (WebCore::Image::loadPlatformResource): Implement
+ * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
+
+2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19357
+
+ [GTK] The Gtk+ port wants to have a themable
+ urlIcon too.
+
+ * loader/icon/IconDatabase.cpp:
+
+2009-05-20 Stephanie Lewis <slewis@apple.com>
+
+ Update the order files. <rdar://problem/6881750> Generate new order files.
+
+ * WebCore.order:
+
+2009-05-20 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix some assertion failures in plug-in tests on the Windows debug build bot.
+
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
+ * plugins/PluginView.cpp:
+ (WebCore::scriptStringIfJavaScriptURL): Ditto.
+
+2009-05-20 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ More protocolInHTTPFamily() cleanup.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::send):
+
+2009-05-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for <rdar://problem/6905475>
+ Office 2008: Entourage: Crash when you switch to "My Day" view
+
+ The host function callback callObjCFallbackObject was not annotated
+ with JSC_HOST_CALL which meant that when it was called by the JIT, which
+ expects the JSC_HOST_CALL calling convention, the arguments are not in the
+ expected places.
+
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
+ annotation on callObjCFallbackObject.
+
+2009-05-20 David Levin <levin@chromium.org>
+
+ Not Reviewed, build fix.
+
+ Need to disable this assert while the chormium code is fixed for it.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURL::protocolIs):
+
+2009-05-20 David Levin <levin@chromium.org>
+
+ Not Reviewed, build fix.
+
+ Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
+ http://trac.webkit.org/changeset/43929. Fix assert placement.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURL::protocolIs):
+ (WebCore::protocolIs):
+
+2009-05-20 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Upstream V8 bindings for V8DomWindow.
+ https://bugs.webkit.org/show_bug.cgi?id=25869
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
+ (WebCore::isAscii): Moved from v8_custom.cpp.
+ (WebCore::convertBase64): Moved from v8_custom.cpp.
+ (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
+ (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
+ (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
+ (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
+ (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
+ (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
+
+2009-05-21 Christian Dywan <christian@twotoasts.de>
+
+ Reviewed by Jan Alonzo.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::parseDataUrl): Always use Glib Base64 decoding.
+
+2009-05-21 Christian Dywan <christian@twotoasts.de>
+
+ Rubberstamped by Gustavo Noronha.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
+
+2009-05-20 Christian Dywan <christian@twotoasts.de>
+
+ Reviewed by Gustavo Noronha.
+
+ * GNUmakefile.am:
+ * platform/gtk/guriescape.c:
+ * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
+ g_uri_unescape_string now that we require Glib 2.16.
+
+2009-05-20 David Levin <levin@chromium.org>
+
+ Not Reviewed, build fix.
+
+ Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
+ http://trac.webkit.org/changeset/43929.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::protocolIsJavaScript):
+ (WebCore::protocolIs):
+
+2009-05-20 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Sam Weinig
+
+ At all call sites that check if a KURL has either the http or https protocol,
+ use the KURL::protocolInHTTPFamily() accessor, instead.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::iconURL):
+ (WebCore::FrameLoader::didOpenURL):
+ (WebCore::FrameLoader::open):
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
+
+ * loader/loader.cpp:
+ (WebCore::Loader::load):
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::send):
+
+2009-05-20 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
+
+ KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
+ "javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
+ invalid, you can no longer ask it a question such as "is your protocol javascript?"
+ Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
+ navigate to them.
+
+ URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
+ being a high profile example) and actually represent valid javascript.
+
+ Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
+ as it functions on a String which doesn't have to pass KURLs parsing rules.
+
+ Test: fast/loader/javascript-url-hierarchical-execution.html
+
+ * bindings/js/JSAttrCustom.cpp:
+ (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation): Ditto.
+ (WebCore::createWindow): Ditto.
+ (WebCore::JSDOMWindow::open): Ditto.
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::allowSettingSrcToJavascriptURL): Ditto.
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ (WebCore::allowSettingJavascriptURL): Ditto.
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::navigateIfAllowed): Ditto.
+ (WebCore::JSLocation::reload): Ditto.
+ * editing/markup.cpp:
+ (WebCore::appendQuotedURLAttributeValue): Ditto.
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::requestFrame): Ditto.
+ (WebCore::FrameLoader::submitForm): Ditto.
+ (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
+
+ * platform/KURL.cpp:
+ (WebCore::KURL::init): Use protocolIsJavaScript().
+ (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
+ Such checks should go through protocolIsJavaScript() instead.
+ (WebCore::encodeRelativeString): Use protocolIsJavaScript().
+ (WebCore::protocolIsJavaScript):
+ * platform/KURL.h:
+
+2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24510
+
+ Fix a bug where the browserfuncs were not properly assigned,
+ make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
+
+ Test: plugins/netscape-invoke-browserfuncs.html
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::load): Fix assignment
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::load): Fix assignment
+
+2009-05-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
+ and only exist on RenderText.
+
+ * dom/Range.cpp:
+ (WebCore::Range::textRects):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
+ of absoluteQuadsForRange since no range is being specifiec.
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderText.h:
+
+2009-05-20 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ Implement AtkObject::focus-event and
+ AtkObject::state-changed:focused signal emission.
+
+ Adds a new handleFocusedUIElementChangedWithRenderers, only in the
+ GTK port, called at the same point than
+ handleFocusedUIElementChanged but with two parameters, the old and
+ the newly focused RenderObjects. We need this, since the ATK
+ signals require us to pass the objects involved in the focus
+ change as arguments.
+
+ * accessibility/AXObjectCache.h:
+ * accessibility/gtk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+
+2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25834
+
+ Make ChromeClient a interface again
+
+ With recent additions to ChromeClient.h empty defaults were
+ added. This is bad for porters as these changes go unnoticed
+ and at runtime no notImplemented warning is logged and grepping
+ for notImplemented will not show anything. Change this Client
+ to be like the other Clients again and always have pure virtuals
+ (but for stuff inside #ifdef PLATFORM(MAC)).
+
+ Update the various WebKit/* implementations to compile again.
+
+ * loader/EmptyClients.h: Add empty defaults
+ (WebCore::EmptyChromeClient::setCursor):
+ (WebCore::EmptyChromeClient::scrollRectIntoView):
+ (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
+ * page/ChromeClient.h: Make methods pure virtual
+
+2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Fix a bug where a non visible plugin would show it self in a
+ sibling frame. The problem was due to our clipping. In Qt,
+ if setMask is set with an empty QRegion, no clipping will
+ be performed, so in that case we hide the PluginContainer
+
+ Added manual test.
+
+ * plugins/qt/PluginContainerQt.cpp:
+ (PluginContainerQt::adjustGeometry):
+ * manual-tests/qt/plugin-sibling-frame-include.html
+ * manual-tests/qt/plugin-sibling-frame.html
+
+2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Do not call the parent implementation (Widget::) in show() and hide()
+ of the PluginViewQt, as it always changes the visible state of the
+ platformWidget (equal to the platformPluginWidget in the Qt port),
+ thus ignoring the isParentVisible() test.
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+
+2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23452
+ Change the implementation of HTMLNoScriptElement to avoid the pain of
+ adding virtual function for XHTMLMP support
+
+ Includes changes suggested by Simon Fraser.
+
+ * dom/Node.cpp:
+ (WebCore::Node::styleForRenderer):
+ * dom/Node.h:
+ * html/HTMLNoScriptElement.cpp:
+ * html/HTMLNoScriptElement.h:
+
+2009-05-20 Kevin Ollivier <kevino@theolliviers.com>
+
+ CURL backend build fix. Make sure URL is always set.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::downloadTimerCallback):
+
+2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
+
+ Reviewed by George Staikos.
+
+ Fix Qt WebKit build break in Mac OS.
+
+ * platform/FileSystem.h:
+
+2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Rubber-stamped by Eric Seidel.
+
+ Enable code that was commented out waiting for a way to get a
+ GdkPixbuf from an image, effectively enabling copying images to
+ the clipboard.
+
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::Pasteboard::writeImage):
+
+2009-05-20 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25414
+ [GTK] ROLE_PANEL should not be used for paragraphs and list items.
+
+ Implement Atk list item role for list items.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_get_role):
+
+2009-05-20 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25414
+ [GTK] ROLE_PANEL should not be used for paragraphs and list items.
+
+ Implement Atk paragraph role for paragraph elements.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_get_role):
+
+2009-05-20 Eric Seidel <eric@webkit.org>
+
+ Fix bug URL in ChangeLogs in r43903.
+ https://bugs.webkit.org/show_bug.cgi?id=25742
+
+2009-05-20 Takeshi Yoshino <tyoshino@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
+ https://bugs.webkit.org/show_bug.cgi?id=25742
+
+ Fix RenderThemeChromiumWin::paintTextFieldInternal().
+
+ We shouldn't paint the content area of text fields when o->style() has
+ background image or transparent background color. paintTextFieldInternal() is
+ used for painting inner area of HTML option elements by Chromium.
+
+ When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
+ the background image rendered by RenderBoxModelObject. So, we should set
+ fillContentArea = false in such case.
+
+ Besides, when background-color:transparent is specified for CSS property,
+ o->style().backgroundColor returns black color with alpha channel == 0. But
+ since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
+ recognize alpha channel, it fills the rect with black. I made workaround to set
+ fillContentArea = false when alpha channel == 0 to avoid this.
+
+ And more, I'd like to fallback the color passed to ChromiumBridge to white when
+ o->style()->backgroundColor() is invalid.
+
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
+
+2009-05-20 Shinichiro Hamaji <hamaji@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25417
+ Map CompositeCopy to Skia's kSrc_Mode composite operation.
+
+ Test: fast/canvas/canvas-composite-alpha.html
+
+ * platform/graphics/skia/SkiaUtils.cpp:
+ (WebCore::):
+
+2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Rubber-stamped by Xan Lopez.
+
+ Remove misplaced extern "C"
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Expose password field with role of PASSWORD_TEXT
+ https://bugs.webkit.org/show_bug.cgi?id=25682
+
+ Check if input type is a password field and return
+ ATK_ROLE_PASSWORD_TEXT if it is.
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
+ <https://bugs.webkit.org/show_bug.cgi?id=25845>
+
+ * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
+
+2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ BUG 25843: [Qt] Remove qt-port build flag
+ <https://bugs.webkit.org/show_bug.cgi?id=25843>
+
+ * bridge/testbindings.pro:
+
+2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25824
+
+ [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
+ and WORKERS under the appropriate build section
+
+ * WebCore.pro:
+
+2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Unreviewed Qt build fix, after r43892.
+
+ * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
+
+2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25856
+ [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::Image::drawPattern):
+ (WebCore::BitmapImage::draw):
+
+2009-05-20 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY, layout tests fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23727
+ This reverts commit r43888.
+
+ Once that change was checked in many of the fast/flexbox0*.html
+ tests (and others) started failing.
+
+ * WebCore.pro:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ * css/CSSPropertyNames.in:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/CSSValueKeywords.in:
+ * rendering/RenderMarquee.cpp:
+ (WebCore::RenderMarquee::updateMarqueePosition):
+ (WebCore::RenderMarquee::timerFired):
+
+2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by George Staikos.
+
+ Add XHTMLMP support to Webkit
+ Update the configure files for building XHTMLMP-enabled WebKit on different platform
+ https://bugs.webkit.org/show_bug.cgi?id=23452
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+
+2009-05-19 Antti Koivisto <antti@apple.com>
+
+ I can't figure out how to make this not timing dependent, making it manual test instead.
+
+ * manual-tests/preload-scanner-entities.html: Added.
+
+2009-05-19 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
+
+ This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
+ in QuickLooks (rdar://problem/6619630).
+
+ We need to respect the DocumentLoader's request cache policy when deciding the cache policy
+ for subresources, but the check (originally removed in r39304 and added back in in the same
+ place in r41424) needs to be tweaked and relocated a bit.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking
+ the DocumentLoader's request to a more appropriate place. Add code to handle the recently
+ added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
+ cleaner in the future.
+ * loader/FrameLoader.h:
+
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
+
+2009-05-19 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
+ https://bugs.webkit.org/show_bug.cgi?id=25872
+
+ When setting the aria-labeledby text it should stay within the element identified by the id
+ when searching through the sibling list.
+
+ This also removes an outdated assert in getDocumentLinks. Its possible for the document to
+ think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
+
+ Test: accessibility/aria-labelledby-stay-within.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
+ (WebCore::AccessibilityRenderObject::getDocumentLinks):
+
+2009-05-19 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler).
+
+ <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
+
+ Push characters back in correct order when entity parsing fails after 3 characters.
+
+ Test: fast/tokenizer/preload-scanner-entities.html
+
+ * html/PreloadScanner.cpp:
+ (WebCore::PreloadScanner::consumeEntity):
+
+2009-05-19 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Fix a crash in Mac Chromium when displaying an HTML select element
+ with no items.
+ https://bugs.webkit.org/show_bug.cgi?id=25874
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::showExternal):
+
+2009-05-19 Nate Chapin <japhet@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Upstream V8 bindings for CanvasRenderingContext2D.
+ https://bugs.webkit.org/show_bug.cgi?id=25858
+
+ * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
+
+2009-05-19 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Windows Build Fix.
+
+ * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
+
+2009-05-19 Timothy Hatcher <timothy@apple.com>
+
+ <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
+ loaded because willSendRequest doesn't happen immediately
+
+ Reviewed by Antti Koivisto.
+
+ * WebCore.base.exp: Export Loader::servePendingRequests().
+
+2009-05-19 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Bug 25859: Need to upstream ScriptController.* for v8.
+ https://bugs.webkit.org/show_bug.cgi?id=25859
+
+ Fixing the header file (which I accidentally made identical to the cpp file).
+
+ * bindings/v8/ScriptController.h:
+
+2009-05-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler and Brady Eidson.
+
+ <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
+
+ The problem was that Document::removeAllEventListeners() was called for a wrong document
+ when a CachedFrame was destroyed.
+
+ Cannot be tested automatically, because DRT doesn't have a b/f cache.
+
+ * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
+ unrelated window even if document's m_frame pointer is stale.
+
+ * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
+
+2009-05-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25419
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::addToConsole):
+ * inspector/ConsoleMessage.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::~InspectorController):
+ (WebCore::InspectorController::inspect):
+ (WebCore::InspectorController::focusNode):
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::addConsoleMessage):
+ (WebCore::InspectorController::setAttachedWindow):
+ (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
+ (WebCore::InspectorController::scriptObjectReady):
+ (WebCore::InspectorController::showPanel):
+ (WebCore::InspectorController::close):
+ (WebCore::InspectorController::populateScriptObjects):
+ (WebCore::InspectorController::resetScriptObjects):
+ (WebCore::InspectorController::pruneResources):
+ (WebCore::InspectorController::didCommitLoad):
+ (WebCore::InspectorController::didLoadResourceFromMemoryCache):
+ (WebCore::InspectorController::identifierForInitialRequest):
+ (WebCore::InspectorController::willSendRequest):
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didReceiveContentLength):
+ (WebCore::InspectorController::didFinishLoading):
+ (WebCore::InspectorController::didFailLoading):
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
+ (WebCore::InspectorController::scriptImported):
+ (WebCore::InspectorController::didOpenDatabase):
+ (WebCore::InspectorController::didUseDOMStorage):
+ (WebCore::InspectorController::addScriptProfile):
+ (WebCore::InspectorController::toggleRecordButton):
+ (WebCore::InspectorController::enableProfiler):
+ (WebCore::InspectorController::disableProfiler):
+ (WebCore::InspectorController::enableDebugger):
+ (WebCore::InspectorController::disableDebugger):
+ (WebCore::InspectorController::didParseSource):
+ (WebCore::InspectorController::failedToParseSource):
+ (WebCore::InspectorController::didPause):
+ (WebCore::InspectorController::didContinue):
+ * inspector/InspectorController.h:
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::bind):
+ * inspector/InspectorDOMStorageResource.h:
+ * inspector/InspectorDatabaseResource.cpp:
+ (WebCore::InspectorDatabaseResource::bind):
+ * inspector/InspectorDatabaseResource.h:
+ * inspector/InspectorFrontend.cpp: Added.
+ (WebCore::callSimpleFunction):
+ (WebCore::InspectorFrontend::InspectorFrontend):
+ (WebCore::InspectorFrontend::~InspectorFrontend):
+ (WebCore::InspectorFrontend::newJSONObject):
+ (WebCore::InspectorFrontend::addMessageToConsole):
+ (WebCore::InspectorFrontend::addResource):
+ (WebCore::InspectorFrontend::updateResource):
+ (WebCore::InspectorFrontend::removeResource):
+ (WebCore::InspectorFrontend::updateFocusedNode):
+ (WebCore::InspectorFrontend::setAttachedWindow):
+ (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
+ (WebCore::InspectorFrontend::showPanel):
+ (WebCore::InspectorFrontend::populateInterface):
+ (WebCore::InspectorFrontend::reset):
+ (WebCore::InspectorFrontend::debuggerWasEnabled):
+ (WebCore::InspectorFrontend::debuggerWasDisabled):
+ (WebCore::InspectorFrontend::profilerWasEnabled):
+ (WebCore::InspectorFrontend::profilerWasDisabled):
+ (WebCore::InspectorFrontend::parsedScriptSource):
+ (WebCore::InspectorFrontend::failedToParseScriptSource):
+ (WebCore::InspectorFrontend::addProfile):
+ (WebCore::InspectorFrontend::setRecordingProfile):
+ (WebCore::InspectorFrontend::pausedScript):
+ (WebCore::InspectorFrontend::resumedScript):
+ (WebCore::InspectorFrontend::addDatabase):
+ (WebCore::InspectorFrontend::addDOMStorage):
+ * inspector/InspectorFrontend.h: Added.
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::createScriptObject):
+ (WebCore::InspectorResource::updateScriptObject):
+ (WebCore::InspectorResource::releaseScriptObject):
+ * inspector/InspectorResource.h:
+
+2009-05-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
+
+ https://bugs.webkit.org/show_bug.cgi?id=25419
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::addToConsole):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::bind):
+ * inspector/InspectorDatabaseResource.cpp:
+ (WebCore::InspectorDatabaseResource::bind):
+ * inspector/InspectorResource.cpp:
+ (WebCore::populateHeadersObject):
+ (WebCore::InspectorResource::createScriptObject):
+ (WebCore::InspectorResource::updateScriptObject):
+ * inspector/JSONObject.cpp: Added.
+ (WebCore::JSONObject::JSONObject):
+ (WebCore::JSONObject::set):
+ (WebCore::JSONObject::scriptObject):
+ (WebCore::JSONObject::createNew):
+ * inspector/JSONObject.h: Added.
+
+2009-05-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25419
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::addToConsole):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didReceiveContentLength):
+ (WebCore::InspectorController::didFinishLoading):
+ (WebCore::InspectorController::didFailLoading):
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
+ (WebCore::InspectorController::scriptImported):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+ (WebCore::InspectorDOMStorageResource::bind):
+ (WebCore::InspectorDOMStorageResource::unbind):
+ * inspector/InspectorDOMStorageResource.h:
+ * inspector/InspectorDatabaseResource.cpp:
+ (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
+ (WebCore::InspectorDatabaseResource::bind):
+ (WebCore::InspectorDatabaseResource::unbind):
+ * inspector/InspectorDatabaseResource.h:
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::InspectorResource):
+ (WebCore::populateHeadersObject):
+ (WebCore::InspectorResource::createScriptObject):
+ (WebCore::InspectorResource::updateScriptObject):
+ (WebCore::InspectorResource::releaseScriptObject):
+ * inspector/InspectorResource.h:
+ * inspector/front-end/Console.js:
+ (WebInspector.ConsoleMessage):
+ * inspector/front-end/inspector.js:
+ (WebInspector.addResource):
+ (WebInspector.updateResource):
+ (WebInspector.removeResource):
+ (WebInspector.addDatabase):
+ (WebInspector.addDOMStorage):
+ (WebInspector.reset):
+ (WebInspector.addMessageToConsole):
+
+2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Ariya Hidayat.
+
+ The Qt port has code that disables scrolling optimizations
+ when the root contains native windows, such as windowed plugins.
+
+ This code broke when detaching iframes containing windowed
+ plugins.
+
+ Each ScrollView now knows how many native windows it and its
+ children contain, and when it is detached, that number is
+ substracted from its old parents.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+ (WebCore::ScrollView::setParent):
+ * platform/ScrollView.h:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
+ (WebCore::ScrollView::platformAddChild):
+ (WebCore::ScrollView::platformRemoveChild):
+
+2009-05-18 David Kilzer <ddkilzer@apple.com>
+
+ Tiger build fix for r43850
+
+ * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
+ when building on Tiger.
+
+2009-05-18 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ ClipboardMac cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=25847
+
+ I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
+
+ No functional changes, so no tests.
+
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::ClipboardMac::clearData):
+ (WebCore::absoluteURLsFromPasteboardFilenames):
+ Broke out logic for filenames into its own function to make the caller more readable.
+ (WebCore::absoluteURLsFromPasteboard):
+ Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
+ so that we can use -[NSArray componentsJoinedByString] in the caller (which is
+ cleaner than the manual "\n" addition before).
+ This also access to the full list of file urls for future callers.
+ (WebCore::ClipboardMac::getData):
+ unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
+ explicit check for "URL", before it was a check for != "text/uri-list" which
+ was much more confusing in my opinion. text/uri-list and URL are the only
+ two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
+ (WebCore::ClipboardMac::types):
+ I removed an extra if (!types) check, right before [types count]. In Obj-C
+ messaging nil will return 0 (size of a pointer), so it's safe to message nil
+ here and expect it to return 0.
+
+2009-05-18 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Bug 25859: Need to upstream ScriptController.* for v8.
+ https://bugs.webkit.org/show_bug.cgi?id=25859
+
+ * bindings/v8/ScriptController.cpp: Added.
+ * bindings/v8/ScriptController.h: Added.
+
+2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by George Staikos.
+
+ Change ScriptElement to support XHTMLMP in a better way
+ https://bugs.webkit.org/show_bug.cgi?id=23452
+
+ * dom/ScriptElement.h:
+ * html/HTMLScriptElement.h:
+ * svg/SVGScriptElement.h:
+ (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
+
+2009-05-18 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix, finish up changes after the accessibility dir split.
+
+ * webcore-base.bkl:
+
+2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by George Staikos (and others).
+
+ Add XHTMLMP support to Webkit
+ https://bugs.webkit.org/show_bug.cgi?id=23452
+ XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
+ functionality. Most of the functionalities have already been implemented by Webkit.
+
+ The changes include:
+ 1) Adding <noscript> support
+ 2) Document conformance validation
+ 3) User Agent conformance validation
+
+ refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
+
+ Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
+ fast/xhtmlmp/check-rootelement.xhtml
+ fast/xhtmlmp/noscript-in-multiscripts.xhtml
+ fast/xhtmlmp/noscript-nested.xhtml
+ fast/xhtmlmp/noscript.xhtml
+
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument):
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::isXHTMLMPDocument):
+ * dom/Document.h:
+ (WebCore::Document::shouldProcessNoscriptElement):
+ (WebCore::Document::setShouldProcessNoscriptElement):
+ * dom/Node.cpp:
+ (WebCore::Node::createRendererIfNeeded):
+ * dom/Node.h:
+ * dom/XMLTokenizer.h:
+ (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
+ (WebCore::XMLTokenizer::isXHTMLMPDocument):
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::XMLTokenizer):
+ (WebCore::XMLTokenizer::startElementNs):
+ (WebCore::XMLTokenizer::endElementNs):
+ (WebCore::XMLTokenizer::endDocument):
+ (WebCore::XMLTokenizer::internalSubset):
+ (WebCore::getEntityHandler):
+ (WebCore::externalSubsetHandler):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::XMLTokenizer):
+ (WebCore::XMLTokenizer::parse):
+ (WebCore::XMLTokenizer::parseStartElement):
+ (WebCore::XMLTokenizer::parseEndElement):
+ (WebCore::):
+ * dom/make_names.pl:
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::rendererIsNeeded):
+ * html/HTMLNoScriptElement.cpp: Added.
+ (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
+ (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
+ (WebCore::HTMLNoScriptElement::checkDTD):
+ (WebCore::HTMLNoScriptElement::attach):
+ (WebCore::HTMLNoScriptElement::recalcStyle):
+ (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
+ (WebCore::HTMLNoScriptElement::styleForRenderer):
+ * html/HTMLNoScriptElement.h: Added.
+ (WebCore::HTMLNoScriptElement::rendererIsNeeded):
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::getNode):
+ (WebCore::HTMLParser::isInline):
+ * html/HTMLTagNames.in:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::scriptHandler):
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedNonImageMimeTypes):
+
+2009-05-18 Mark Rowe <mrowe@apple.com>
+
+ Fix the build.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Rubber-stamped by Gustavo Noronha.
+
+ Fixed build for the Qt port by adding the WebCore/accessibility
+ directory to the includepath.
+
+ * WebCore.pro:
+
+2009-05-18 Chris Fleizach <cfleizach@apple.com>
+
+ Bug 25776: accessibility should have its own folder in WebCore project
+ https://bugs.webkit.org/show_bug.cgi?id=25776
+
+ Speculative fix for windows build failure.
+
+ * WebCore.vcproj/WebCoreCommon.vsprops:
+
+2009-05-18 David Kilzer <ddkilzer@apple.com>
+
+ Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
+
+ <https://bugs.webkit.org/show_bug.cgi?id=20652>
+
+ Reviewed by Darin Adler.
+
+ Test: http/tests/misc/favicon-as-image.html
+
+ * inspector/front-end/inspector.js: Added
+ image/vnd.microsoft.icon to WebInspector.MIMETypes.
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedImageMIMETypes): Added
+ image/vnd.microsoft.icon to list of supported image and image
+ resource MIME types.
+
+2009-05-18 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 25776: accessibility should have its own folder in WebCore project
+ https://bugs.webkit.org/show_bug.cgi?id=25776
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * accessibility: Added.
+ * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
+ * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
+ * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
+ * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
+ * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
+ * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
+ * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
+ * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
+ * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
+ * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
+ * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
+ * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
+ * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
+ * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
+ * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
+ * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
+ * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
+ * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
+ * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
+ * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
+ * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
+ * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
+ * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
+ * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
+ * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
+ * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
+ * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
+ * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
+ * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
+ * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
+ * accessibility/chromium: Added.
+ * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
+ * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
+ * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
+ * accessibility/gtk: Added.
+ * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
+ * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
+ * accessibility/mac: Added.
+ * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
+ * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
+ * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
+ * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
+ * accessibility/qt: Added.
+ * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
+ * accessibility/win: Added.
+ * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
+ * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
+ * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
+ * accessibility/wx: Added.
+ * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
+ * page/AXObjectCache.cpp: Removed.
+ * page/AXObjectCache.h: Removed.
+ * page/AccessibilityAriaGrid.cpp: Removed.
+ * page/AccessibilityAriaGrid.h: Removed.
+ * page/AccessibilityAriaGridCell.cpp: Removed.
+ * page/AccessibilityAriaGridCell.h: Removed.
+ * page/AccessibilityAriaGridRow.cpp: Removed.
+ * page/AccessibilityAriaGridRow.h: Removed.
+ * page/AccessibilityImageMapLink.cpp: Removed.
+ * page/AccessibilityImageMapLink.h: Removed.
+ * page/AccessibilityList.cpp: Removed.
+ * page/AccessibilityList.h: Removed.
+ * page/AccessibilityListBox.cpp: Removed.
+ * page/AccessibilityListBox.h: Removed.
+ * page/AccessibilityListBoxOption.cpp: Removed.
+ * page/AccessibilityListBoxOption.h: Removed.
+ * page/AccessibilityObject.cpp: Removed.
+ * page/AccessibilityObject.h: Removed.
+ * page/AccessibilityRenderObject.cpp: Removed.
+ * page/AccessibilityRenderObject.h: Removed.
+ * page/AccessibilityTable.cpp: Removed.
+ * page/AccessibilityTable.h: Removed.
+ * page/AccessibilityTableCell.cpp: Removed.
+ * page/AccessibilityTableCell.h: Removed.
+ * page/AccessibilityTableColumn.cpp: Removed.
+ * page/AccessibilityTableColumn.h: Removed.
+ * page/AccessibilityTableHeaderContainer.cpp: Removed.
+ * page/AccessibilityTableHeaderContainer.h: Removed.
+ * page/AccessibilityTableRow.cpp: Removed.
+ * page/AccessibilityTableRow.h: Removed.
+ * page/chromium/AXObjectCacheChromium.cpp: Removed.
+ * page/chromium/AccessibilityObjectChromium.cpp: Removed.
+ * page/chromium/AccessibilityObjectWrapper.h: Removed.
+ * page/gtk/AXObjectCacheAtk.cpp: Removed.
+ * page/gtk/AccessibilityObjectAtk.cpp: Removed.
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
+ * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
+ * page/mac/AXObjectCacheMac.mm: Removed.
+ * page/mac/AccessibilityObjectMac.mm: Removed.
+ * page/mac/AccessibilityObjectWrapper.h: Removed.
+ * page/mac/AccessibilityObjectWrapper.mm: Removed.
+ * page/qt/AccessibilityObjectQt.cpp: Removed.
+ * page/win/AXObjectCacheWin.cpp: Removed.
+ * page/win/AccessibilityObjectWin.cpp: Removed.
+ * page/win/AccessibilityObjectWrapperWin.h: Removed.
+ * page/wx/AccessibilityObjectWx.cpp: Removed.
+
+2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25854
+ [GTK] Should tell servers we only support identity as content encoding
+
+ Let servers know we only support identity as content
+ encoding. We will implement this in libsoup.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp):
+
+2009-05-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
+ CAPTCHA failure.
+
+ The problem was that after loading and displaying a CAPTCHA image, it was loaded from
+ the server again due to preloading. So, the server expected the last loaded (invisible)
+ CAPTCHA text to be typed and posted back.
+
+ I don't know how to make tests for preloading.
+
+ * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
+ to preload after loading for real - and if cache policy is CachePolicyReload, that actually
+ results in another load from network layer.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
+ to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
+
+2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24551
+
+ [Qt] Reuse FontPlatformData for the same FontDescription.
+ This effectively prevents growing heap usage for loading every web page.
+
+ * platform/graphics/qt/FontCacheQt.cpp:
+ (WebCore::qHash): Necessary for FontPlatformDataCache.
+ (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
+ it exists, otherwise create a new one and insert it in the cache.
+
+2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
+
+ Reviewed by Ariya Hidayat.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24551
+
+ [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
+ When creating a new instance of SimpleFontData, put it in the font list
+ so that it can deleted later on.
+
+ * platform/graphics/qt/FontFallbackListQt.cpp:
+ (WebCore::FontFallbackList::invalidate):
+ (WebCore::FontFallbackList::releaseFontData):
+ (WebCore::FontFallbackList::fontDataAt):
+
+2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] Various autotools build refactoring and fixes
+ https://bugs.webkit.org/show_bug.cgi?id=25286
+
+ Style fixes
+
+ * GNUmakefile.am:
+
+2009-05-17 George Staikos <george.staikos@torchmobile.com>
+
+ Not reviewed - build fix.
+
+ Fix typo: constr -> const.
+
+ * wml/WMLInputElement.h:
+ (WebCore::WMLInputElement::setPlaceholder):
+
+2009-05-17 Darin Adler <darin@apple.com>
+
+ Fix done by Simon Fraser (reviewed by me).
+
+ <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
+ transitions has bad layout and overlapping garbled text when printing
+
+ * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
+
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
+
+2009-05-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
+ also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
+
+ * manual-tests/select-option-in-onload.html: Added.
+
+2009-05-17 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ Rename local variables for readability.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintBorder):
+
+2009-05-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 25840: fix some warnings seen on the GTK bot
+ https://bugs.webkit.org/show_bug.cgi?id=25840
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
+ This is really just to quiet warnings. I think this code is unreachable.
+ Someone could put ASSERT_NOT_REACHED() in here too at some point.
+
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::startStream): Use proper printf format for int
+ here, %d, not %lu. This could cause a real problem when compiled 64-bit,
+ so it's good to fix.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
+ really just to quiet the warning, but still seems like a good idea.
+
+2009-05-17 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25769: Fix accessibility warnings on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=25769
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
+ (WebCore::AccessibilityTable::rowCount): Ditto.
+ * page/AccessibilityTable.h: Ditto.
+
+2009-05-17 Kai Brüning <kai@granus.net>
+
+ Reviewed by Darin Adler.
+
+ bug 25822: DOM normalize does not remove empty text node between element nodes
+ https://bugs.webkit.org/show_bug.cgi?id=25822
+
+ Test: fast/dom/Node/normalize.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::normalize): Changed to remove any empty text nodes.
+
+2009-05-16 Dave Moore <davemoore@google.com>
+
+ Reviewed by Darin Adler.
+
+ Allow Strings to be created with one malloc node with no copying
+ https://bugs.webkit.org/show_bug.cgi?id=25779
+
+ Add new methods to String and StringImpl, refactoring existing
+ methods in StringImpl to use new createUninitialized() method.
+
+ * platform/text/PlatformString.h:
+ (WebCore::String::createUninitialized):
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::createUninitialized):
+ (WebCore::StringImpl::create):
+ * platform/text/StringImpl.h:
+
+2009-05-16 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
+ dramatically improve animated GIF decoding performance
+
+ Recent versions of ImageIO discard previously decoded image frames if the client
+ application no longer holds references to them, so there's no need to throw away
+ the decoder unless we're explicitly asked to destroy all of the frames.
+
+ This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
+ from over 90% to below 3%.
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::clear):
+
+2009-05-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - fix <rdar://problem/6873305> Two distinct characters are not displayed
+ correctly with 2 of the font selections from the stickies widget
+
+ Test: platform/mac/editing/pasteboard/text-precomposed.html
+
+ Ensure that "text/plain" data retrieved from the clipboard is always
+ precomposed. This makes Clipboard::getData() and
+ Pasteboard::documentFragment() consistent with Pasteboard::plainText()
+ and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
+
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::ClipboardMac::getData):
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::Pasteboard::documentFragment):
+
+2009-05-16 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::valueForFamily): Declare valueForFamily as static.
+
+2009-05-15 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
+ only the generic font, if any generic font is in the family list
+
+ Test: fast/css/getComputedStyle/computed-style-font-family.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
+ (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
+ (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
+ property as specified in the CSS standard. Fixed clip to return "auto" when there is no
+ clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
+ internal linkage since there was no reason for them to have external linkage.
+
+2009-05-15 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25741
+
+ Append instead of throwing when insertItemBefore gets an out-of-bound
+ index.
+
+ Test: svg/dom/svglist-insertItemBefore-appends.html
+
+ * svg/SVGList.h:
+ (WebCore::SVGList::insertItemBefore):
+
+2009-05-15 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=25829
+
+ Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
+
+ Test: fast/backgrounds/background-clip-text.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+
+2009-05-15 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
+ arrows, I can't navigate caret between To Do items in a Note message
+
+ Test: editing/selection/move-by-line-004.html
+
+ * editing/visible_units.cpp:
+ (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
+ function.
+ (WebCore::previousLinePosition): When advancing to the next candidate
+ node, stop when leaving the closest ancestor of the original node that
+ is not an inline. The code, incorrectly, was trying to exit the closest
+ ancestor of that type which was editable, and therefore missing other
+ blocks in the same editable root.
+ (WebCore::nextLinePosition): Ditto.
+
+2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
+
+ Reviewed by Jan Alonzo.
+
+ Converting filename to uri by concatenating strings is broken
+ on Windows. So, don't do it for that platform.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startGio):
+
+2009-05-15 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
+ https://bugs.webkit.org/show_bug.cgi?id=25739
+
+ * bindings/v8/V8Collection.cpp: Added.
+ (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
+ * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
+ * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp.
+ (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
+
+2009-05-15 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
+
+ Reviewed by Darin Adler and Timothy Hatcher.
+
+ * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
+ WebCore.base.exp into the group, and added 10 other *.exp files
+ in WebCore.
+
+2009-05-15 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25826
+ Change type to only have custom getter in JCS.
+
+ * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
+
+2009-05-15 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ Add a settings entry to en/disable web font support
+ https://bugs.webkit.org/show_bug.cgi?id=25239
+
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::addFontFaceRule):
+
+2009-05-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Steve Falkenburg.
+
+ Remove dead youtube site specific hack that was commented out.
+
+ * bindings/js/JSNavigatorCustom.cpp:
+ * page/Navigator.idl:
+
+2009-05-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Beth Dakin.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
+ <rdar://problem/6884742>
+ REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
+
+ Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
+
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::needsGmailQuirk):
+ (WebCore::JSHTMLInputElement::type):
+ * html/HTMLInputElement.idl:
+
+2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25810
+ Upstream V8 DOM Wrapper map declarations.
+
+ No behavior change, so no tests.
+
+ * bindings/v8/V8DOMMap.h:
+ (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
+ (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
+ (WebCore::WeakReferenceMap::get): Added.
+ (WebCore::WeakReferenceMap::set): Added.
+ (WebCore::WeakReferenceMap::forget): Added.
+ (WebCore::WeakReferenceMap::contains): Added.
+ (WebCore::WeakReferenceMap::impl): Added.
+ (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
+
+2009-05-15 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=25773
+
+ Rename GraphicsLayer::graphicsContextsFlipped() to
+ GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
+
+ Clean up code around the GraphicsLayer "contents" layer that makes use of this
+ flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
+ which can then always do the flipping if necessary.
+
+ Only affects ACCELERATED_COMPOSITING builds.
+
+ * platform/graphics/GraphicsLayer.h:
+ (WebCore::GraphicsLayer::):
+ * platform/graphics/mac/GraphicsLayerCA.h:
+ (WebCore::GraphicsLayerCA::contentsLayer):
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
+ (WebCore::GraphicsLayerCA::setBackgroundColor):
+ (WebCore::GraphicsLayerCA::clearBackgroundColor):
+ (WebCore::GraphicsLayerCA::setContentsToImage):
+ (WebCore::GraphicsLayerCA::clearContents):
+ (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
+ (WebCore::GraphicsLayerCA::setContentsLayer):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
+
+2009-05-15 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25765
+
+ Avoid calling setNeedsStyleRecalc() when we are
+ putting an animated page in the cache. This avoids
+ the assert and subsequent problems with a dirty
+ page going into the cache.
+
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::endAnimation):
+
+2009-05-15 Francisco Tolmasky <francisco@280north.com>
+
+ BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
+ <https://bugs.webkit.org/show_bug.cgi?id=25467>
+
+ Reviewed by Adam Roben.
+
+ * inspector/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
+ * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
+ (WebInspector.CallStackSidebarPane.prototype.update):
+
+2009-05-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::start):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start):
+ Check strings with isEmpty(), not relying on any implicit conversions.
+
+2009-05-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
+
+ <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
+ username and password (Lightwave 9.6 for Mac from Newtek site)
+
+ CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
+ for other protocols (including FTP) should be included as part of the URL.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::start):
+ (WebCore::WebCoreSynchronousLoader::load):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start):
+ (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
+ Put credentials in URL for non-HTTP requests.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
+ Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
+ headers to be received, so they cannot work with other protocols.
+
+2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ [Qt] In the image decoder, remove the raw image data represented as QImage
+ once the image is converted to QPixmap and inserted in the pixmap cache.
+ This effectively reduces the heap usage when running on graphics system
+ other than raster (i.e the case where QImage != QPixmap).
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
+ * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
+
+2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ [Qt] Refactor alpha channel detection the image decoder.
+ Sets the boolean flag as soon as the image is being read.
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
+ (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
+ (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
+ (WebCore::ImageDecoderQt::reset): Resetted the flag.
+ * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
+
+2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Finish support for disabling the JavaScript Debugger and Profiler
+ at compile time in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=24917
+
+ * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
+ * inspector/JavaScriptCallFrame.cpp: Ditto.
+ * inspector/JavaScriptCallFrame.h: Ditto.
+ * inspector/JavaScriptCallFrame.idl: Ditto.
+ * inspector/JavaScriptDebugListener.h: Ditto.
+ * inspector/JavaScriptDebugServer.cpp: Ditto.
+ * inspector/JavaScriptDebugServer.h: Ditto.
+ * inspector/JavaScriptProfile.cpp: Ditto.
+ * inspector/JavaScriptProfile.h: Ditto.
+ * inspector/JavaScriptProfileNode.cpp: Ditto.
+ * inspector/JavaScriptProfileNode.h: Ditto.
+ * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
+ * page/Console.h: Ditto.
+ * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
+
+2009-05-15 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Dimitri Glazkov
+
+ http://bugs.webkit.org/show_bug.cgi?id=25464
+
+ Improve the font fallback for characters belonging to 'common' scripts
+ in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
+ marks in North Indian scripts) and currency signs (e.g. Thai Baht)
+ rendered correctly in Chromium on Win.
+
+ Tests: fast/text/international/danda-space.html
+ fast/text/international/thai-baht-space.html
+
+ * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
+ (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
+ (WebCore::FontMap::getScript):
+ (WebCore::getFallbackFamily):
+
+2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25731
+ [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
+ appropriate build section
+
+ * WebCore.pro:
+
+2009-05-14 Evan Martin <evan@chromium.org>
+
+ Reviewed by Eric Seidel and Darin Fisher.
+
+ Fix a font-related leak in Chromium's Skia backend found by Valgrind.
+ https://bugs.webkit.org/show_bug.cgi?id=25760
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+ Use caches instead of "new" on every call.
+
+2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Initialize m_spreadMethod in the second constructor too. Not sure if
+ a test case can be written, so no test case.
+ https://bugs.webkit.org/show_bug.cgi?id=25814
+
+ No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
+ this case, since several other SVG tests already should be calling
+ spreadMethod().
+
+ * platform/graphics/Gradient.cpp:
+ (WebCore::Gradient::Gradient):
+
+2009-05-14 Simon Fraser <simon.fraser@apple.com>
+
+ No review.
+
+ Fix Windows build after renaming MediaControlElements to MediaControlElementType.
+
+ * rendering/RenderMediaControls.cpp:
+ (WebCore::RenderMediaControls::paintMediaControlsPart):
+ * rendering/RenderMediaControls.h:
+
+2009-05-14 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6739671> Movie controller’s play button does not change into a pause
+ button
+
+ Fix a controls repaint issue when the playing state of a video changes by
+ educating the MediaControlInputElements about the state they are currently
+ displaying, and making them repaint when that state changes. This applies
+ to the play/pause and mute/unmute buttons, which both have two states.
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
+ (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
+ (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
+ Pass in and initialize the MediaControlElementType.
+
+ (WebCore::MediaControlInputElement::update):
+ Update the display type too
+
+ (WebCore::MediaControlInputElement::setDisplayType):
+ (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
+ (WebCore::MediaControlMuteButtonElement::updateDisplayType):
+ Choose muted vs. unmuted display.
+
+ (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
+ (WebCore::MediaControlPlayButtonElement::updateDisplayType):
+ Choose play vs. paused display.
+
+ * rendering/MediaControlElements.h:
+ Renamed the MediaControlElements enum to MediaControlElementType.
+ (WebCore::MediaControlInputElement::updateDisplayType):
+ Add a MediaControlElementType member variable with a setter to allow
+ the element to know what type it is displaying.
+
+2009-05-14 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25197
+
+ Add support for aspect-ratio and orientation
+ media queries.
+
+ Tests: fast/media/mq-aspect-ratio.html
+ fast/media/mq-orientation.html
+
+ * css/MediaFeatureNames.h:
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::orientationMediaFeatureEval):
+ (WebCore::aspect_ratioMediaFeatureEval):
+ (WebCore::min_aspect_ratioMediaFeatureEval):
+ (WebCore::max_aspect_ratioMediaFeatureEval):
+ * css/MediaQueryExp.h:
+ (WebCore::MediaQueryExp::isViewportDependent):
+
+2009-05-14 Kevin McCullough <kmccullough@apple.com>
+
+ - Resubmitting previous patch, correctly this time.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::splitTreeToNode):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::outdentParagraph):
+
+2009-05-14 Kevin McCullough <kmccullough@apple.com>
+
+ - Rolling out to fix a bug and the build
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::splitTreeToNode):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::outdentParagraph):
+
+2009-05-14 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6510362> In some situations message content is messed up
+ when indentation is decreased
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
+ here served to do nothing because this function will return if the
+ second argument is the parent of the first. Not only does this now work
+ as intended, but is necessary for the rest of this fix.
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we
+ are the last node in a <blockquote>, and can therefore remove the
+ <blockquote> we need the endOfEnclosingBlock to extend to the end of
+ the <blockquote> not just the next block, which could be a <div>, for
+ example.
+ - Also If a <blockquote> is removed, but it's the child of another
+ <blockquote> then its children are now children of the top <blockquote>.
+ In this case we want to split the parent <blockquote> because the next
+ paragraph assumes that it is the first node in its <blockquote> and if
+ that is not true, various bugs arise.
+
+2009-05-14 Brady Eidson <beidson@apple.com>
+
+ Build fix.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::setDefaultMIMEType):
+
+2009-05-14 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Fix http/tests/xmlhttprequest/cache-override.html on Windows
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
+ (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
+ (WebCore::WebCoreSynchronousLoader::load): Ditto.
+
+2009-05-14 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Bug: Mac Chromium popup menus are not positioned correctly
+ on scrolled pages:
+ https://bugs.webkit.org/show_bug.cgi?id=25772
+
+ Fix Mac Chromium popup menu placement by taking into
+ account any scrolling in the current window. This mirrors
+ the positioning done in PopupContainer::show(), which is
+ used on Chromium Windows and linux.
+
+ Also fixed indenting for this method.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::showExternal):
+
+2009-05-14 Drew Wilson <atwilson@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25774
+ Upstream V8MessagePortCustom.cpp from the chromium repository.
+
+ * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-14 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=25777
+
+ StyleGeneratedImage::imageSize() needs to take zooming into account for
+ fixed-size images (i.e. canvas) so that canvas-as-image-background
+ renders correctly with zooming.
+
+ Test: fast/canvas/canvas-bg-zoom.html
+
+ * rendering/style/StyleGeneratedImage.cpp:
+ (WebCore::StyleGeneratedImage::imageSize):
+
+2009-05-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch originally by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25796
+ <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
+
+ Test: http/tests/security/credentials-in-referer.html
+
+ * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
+ SubresourceLoader::create() anyway.
+
+2009-05-14 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25797: Pages with image maps are not properly read with Voiceover
+ https://bugs.webkit.org/show_bug.cgi?id=25797
+
+ * page/AccessibilityImageMapLink.h:
+ (WebCore::AccessibilityImageMapLink::isEnabled):
+
+2009-05-14 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
+
+ Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::shouldContentSniff):
+ * platform/network/ResourceHandle.h:
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::createCFURLResponseWithDefaultMIMEType):
+ (WebCore::didReceiveResponse):
+
+2009-05-14 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25791
+ Bug 25791: HTMLMediaElement: implement 'startTime' attribute
+
+ Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
+ value that only the media engine can know, so we just need to add the attribute
+ to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
+ the engine can make it available.
+
+ Test: media/media-startTime.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::startTime): New.
+ * html/HTMLMediaElement.h:
+ * html/HTMLMediaElement.idl:
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::startTime): New.
+ * platform/graphics/MediaPlayer.h:
+
+ * platform/graphics/MediaPlayerPrivate.h:
+ (WebCore::MediaPlayerPrivateInterface::startTime): New.
+
+2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Ariya Hidayat.
+
+ Only create a QWidget wrapper for the plugin in the case it is not
+ in the Qt window mapper, and thus receiving events from the Qt
+ event system. Native Qt based plugins running in process, will
+ already be in the window mapper, and thus creating a wrapper,
+ stops them from getting events from Qt, as they are redirected
+ to the wrapper.
+
+ * plugins/qt/PluginContainerQt.cpp:
+ (PluginContainerQt::on_clientIsEmbedded):
+
+2009-05-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25784
+ Leaks seen on HTTP tests
+
+ We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
+ disabling content sniffing, matching the normal code path.
+ (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
+ and m_pass before overwriting.
+ (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
+
+2009-05-14 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25418
+ Remove new lines from event handler wrapper to make line numbers
+ in the wrapped script conside with the lines in the original script.
+
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::getListenerFunction):
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction):
+
+2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove a JSC-specific include that is already added by including
+ ScriptController.
+
+ No change in behavior, so no tests.
+
+ * dom/Document.cpp: Removed JSDOMBinding include.
+
+2009-05-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Brady Eidson.
+
+ <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
+
+ Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
+ CFString function was used, so a user-friendly name was stored in encoding fallback array.
+
+ * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
+ * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
+
+2009-05-14 Ben Murdoch <benm@google.com>
+
+ Reviewed by Darin Adler.
+
+ Add more ENABLE_DATABASE guards.
+ https://bugs.webkit.org/show_bug.cgi?id=25616
+
+ See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
+
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
+ * bindings/v8/custom/V8CustomSQLStatementCallback.h:
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
+ * bindings/v8/custom/V8DatabaseCustom.cpp:
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp:
+ * storage/Database.cpp:
+ * storage/DatabaseDetails.h:
+ * storage/OriginUsageRecord.cpp:
+ * storage/OriginUsageRecord.h:
+ * storage/SQLError.h:
+ * storage/SQLError.idl:
+ * storage/SQLResultSet.cpp:
+ * storage/SQLResultSet.h:
+ * storage/SQLResultSet.idl:
+ * storage/SQLResultSetRowList.cpp:
+ * storage/SQLResultSetRowList.h:
+ * storage/SQLResultSetRowList.idl:
+ * storage/SQLStatementCallback.h:
+ * storage/SQLStatementErrorCallback.h:
+ * storage/SQLTransactionCallback.h:
+ * storage/SQLTransactionErrorCallback.h:
+
+2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25787
+
+ Gtk was the last platform to not unregister plugins when
+ the plugin is stopped. Catch up with r43550.
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::stop):
+
+2009-05-14 Adam Roben <aroben@apple.com>
+
+ Make WebCore.vcproj's pre-build event work again
+
+ * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
+ pre-build event that was accidentally left in when the pre-build event
+ was moved to WebCoreCommon.vsprops.
+
+2009-05-14 Darin Adler <darin@apple.com>
+
+ * manual-tests/right-click-crash.html: Added.
+
+2009-05-14 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Darin Adler.
+
+ <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
+
+ The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
+ Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
+ if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
+
+ * Configurations/Base.xcconfig:
+
+2009-05-13 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * WebCore.NPAPI.exp:
+
+2009-05-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix invalid memory write seen in HTMLCanvasElement by Valgrind
+ https://bugs.webkit.org/show_bug.cgi?id=25759
+
+ I can't think of any way to catch this with a layout test, so no test.
+
+ * css/CSSCanvasValue.cpp:
+ (WebCore::CSSCanvasValue::canvasDestroyed):
+ * css/CSSCanvasValue.h:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
+ * html/HTMLCanvasElement.h:
+
+2009-05-13 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - fix <rdar://problem/5483015> Replies in Mail are drawn first without
+ the user style sheet and then redrawn with the style sheet
+
+ Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
+
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
+ base64-encoded UTF-8 data, just decode the style sheet here an apply
+ it synchronously instead of invoking an asynchronous loader.
+
+2009-05-13 Chris Fleizach <cfleizach@apple.com>
+
+ Bug 25755: Implement ARIA grid role
+ https://bugs.webkit.org/show_bug.cgi?id=25755
+
+ Fix build bustage from last checkin.
+
+ * page/AccessibilityAriaGrid.cpp:
+ (WebCore::AccessibilityAriaGrid::addChild):
+
+2009-05-13 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25755: Implement ARIA grid role
+ https://bugs.webkit.org/show_bug.cgi?id=25755
+
+ Test: accessibility/aria-tables.html
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * page/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::nodeIsAriaType):
+ (WebCore::AXObjectCache::getOrCreate):
+ * page/AXObjectCache.h:
+ * page/AccessibilityAriaGrid.cpp: Added.
+ (WebCore::AccessibilityAriaGrid::AccessibilityAriaGrid):
+ (WebCore::AccessibilityAriaGrid::~AccessibilityAriaGrid):
+ (WebCore::AccessibilityAriaGrid::create):
+ (WebCore::AccessibilityAriaGrid::addChild):
+ (WebCore::AccessibilityAriaGrid::addChildren):
+ (WebCore::AccessibilityAriaGrid::cellForColumnAndRow):
+ * page/AccessibilityAriaGrid.h: Added.
+ (WebCore::AccessibilityAriaGrid::isAriaTable):
+ * page/AccessibilityAriaGridCell.cpp: Added.
+ (WebCore::AccessibilityAriaGridCell::AccessibilityAriaGridCell):
+ (WebCore::AccessibilityAriaGridCell::~AccessibilityAriaGridCell):
+ (WebCore::AccessibilityAriaGridCell::create):
+ (WebCore::AccessibilityAriaGridCell::parentTable):
+ (WebCore::AccessibilityAriaGridCell::rowIndexRange):
+ (WebCore::AccessibilityAriaGridCell::columnIndexRange):
+ * page/AccessibilityAriaGridCell.h: Added.
+ * page/AccessibilityAriaGridRow.cpp: Added.
+ (WebCore::AccessibilityAriaGridRow::AccessibilityAriaGridRow):
+ (WebCore::AccessibilityAriaGridRow::~AccessibilityAriaGridRow):
+ (WebCore::AccessibilityAriaGridRow::create):
+ (WebCore::AccessibilityAriaGridRow::parentTable):
+ (WebCore::AccessibilityAriaGridRow::headerObject):
+ * page/AccessibilityAriaGridRow.h: Added.
+ * page/AccessibilityList.cpp:
+ (WebCore::AccessibilityList::accessibilityIsIgnored):
+ * page/AccessibilityList.h:
+ * page/AccessibilityObject.h:
+ (WebCore::):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::RoleEntry::):
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::AccessibilityTable):
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+ * page/AccessibilityTable.h:
+ (WebCore::AccessibilityTable::isAriaTable):
+ * page/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::parentTable):
+ (WebCore::AccessibilityTableCell::isTableCell):
+ (WebCore::AccessibilityTableCell::titleUIElement):
+ * page/AccessibilityTableCell.h:
+ * page/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::setParentTable):
+ (WebCore::AccessibilityTableColumn::headerObject):
+ * page/AccessibilityTableRow.cpp:
+ (WebCore::AccessibilityTableRow::isTableRow):
+ (WebCore::AccessibilityTableRow::parentTable):
+ * page/AccessibilityTableRow.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (RoleEntry::):
+
+2009-05-13 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Bug 25763: Need to move v8 custom binding to the custom directory.
+ https://bugs.webkit.org/show_bug.cgi?id=25763
+
+ No test due to no change in behavior.
+
+ * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
+
+2009-05-13 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
+ https://bugs.webkit.org/show_bug.cgi?id=25758
+
+ * bindings/v8/custom/V8ElementCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
+
+2009-05-13 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ Fix a number of bugs relating to RTL and text-overflow:ellipsis.
+ Also refactor the relevant code to make it a little clearer.
+
+ This CL fixes 3 fundamental issues:
+ - Corrects behavior if the truncated InlineTextBox's directionality is
+ different from the overall flow direction - bug 25135.
+ - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
+ - Full truncation on InlineBoxes in RTL flow - bug 24186
+ - Add tests for the above + reorder/cleanup tests for easier
+ interpretation of outcome.
+
+ The code for placing ellipsis has been refactored to use
+ left/right notation rather than a single variable whose meaning
+ could differ based on flow directionality.
+
+ To support differing inline directionality vs flow directionality,
+ different variables are now used in InlineTextBox::placeEllipsisBox to
+ track the two.
+
+ The drawing mode for underlines in standards mode now correctly handles
+ RTL truncation and relevant test where added.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24186
+ https://bugs.webkit.org/show_bug.cgi?id=25135
+ https://bugs.webkit.org/show_bug.cgi?id=24206
+
+ Tests: fast/css/text-overflow-ellipsis-bidi.html
+ fast/css/text-overflow-ellipsis-strict.html
+
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::placeEllipsisBox):
+ * rendering/InlineBox.h:
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ (WebCore::InlineFlowBox::placeEllipsisBox):
+ * rendering/InlineFlowBox.h:
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::placeEllipsisBox):
+ (WebCore::InlineTextBox::paint):
+ * rendering/InlineTextBox.h:
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::placeEllipsis):
+ (WebCore::RootInlineBox::placeEllipsisBox):
+ * rendering/RootInlineBox.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::checkLinesForTextOverflow):
+
+2009-05-13 Dmitry Titov <dimich@chromium.org>
+
+ Rubber-stamped by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25746
+ Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::matchFunc):
+ (WebCore::openFunc):
+ (WebCore::createStringParser):
+ (WebCore::createMemoryParser):
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open):
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::SQLiteDatabase):
+ (WebCore::SQLiteDatabase::close):
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::DatabaseThread):
+ (WebCore::DatabaseThread::start):
+ (WebCore::DatabaseThread::databaseThread):
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::LocalStorageThread):
+ (WebCore::LocalStorageThread::start):
+ (WebCore::LocalStorageThread::localStorageThread):
+ (WebCore::LocalStorageThread::scheduleImport):
+ (WebCore::LocalStorageThread::scheduleSync):
+ (WebCore::LocalStorageThread::terminate):
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::start):
+
+2009-05-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus
+
+ Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
+ (which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
+ content.
+
+ Added fast/overflow/border-radius-clipping.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::pushContentsClip):
+
+2009-05-13 Darin Adler <darin@apple.com>
+
+ Revert the parser arena change. It was a slowdown, not a speedup.
+ Better luck next time (I'll break it up into pieces).
+
+2009-05-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Beth Dakin and Darin Adler.
+
+ Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
+
+ Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
+ to a non-self-painting layer (and vice versa).
+
+ Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
+ repaint properly on opacity changes, etc.
+
+ Added fast/repaint/opacity-change-on-overflow-float.html.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleWillChange):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::styleWillChange):
+ (WebCore::RenderBoxModelObject::styleDidChange):
+ * rendering/RenderBoxModelObject.h:
+
+2009-05-13 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Not reviewed, build fix.
+
+ Move an include, needed by Debugger under the corresponding guard.
+
+ * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
+ guard.
+
+2009-05-13 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
+ https://bugs.webkit.org/show_bug.cgi?id=25394
+
+ Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html
+
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::create):
+ Add another check to subresource loader to avoid doing any loads in frames
+ when the loaders are being stopped.
+
+2009-05-13 Stephan Haller <nomad@froevel.de>
+
+ Reviewed by Gustavo Noronha.
+
+ Wrong handling of file upload if no file selected
+ https://bugs.webkit.org/show_bug.cgi?id=25649
+
+ Fixed returned path if path is empty
+
+ * WebCore/platform/gtk/FileSystemGtk.cpp:
+
+2009-05-13 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white
+ when loading
+
+ Tests: fast/frames/content-opacity-1.html
+ fast/frames/content-opacity-2.html
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::reset): Reset m_contentIsOpaque to false.
+ (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content
+ is not known to be opaque.
+ (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque
+ and enables or disables fast repaints accordingly.
+ * page/FrameView.h:
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the
+ document()->haveStylesheetsLoaded() condition in determining whether the
+ root is opaque. This is what was causing the bug, as iframes were
+ considered to be opaque, and thus painted an opaque white background,
+ whenever they were pending a style sheet load.
+ Changed to call FrameView::setContentIsOpaqe() instead of
+ setUseSlowRepaints(), which allows the frame to go back to fast repaints
+ if the content becomes opaque.
+ Corrected the check for background color opacity: any alpha value other
+ than 255--not just zero--is not opaque.
+
+2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Sam Weinig.
+
+ [Qt] Fix "lighther" composition mode.
+ QPainter::CompositionMode_Plus is the right match.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::toQtCompositionMode):
+
+2009-05-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 25674: syntax tree nodes should use arena allocation
+ https://bugs.webkit.org/show_bug.cgi?id=25674
+
+ * bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
+ We don't want the entire DOM binding to depend on that file.
+
+ * bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
+ Before we inherited this automatically because JDDOMBinding.h
+ included JSFunction.h, but that was excessive.
+ * bindings/js/JSDOMWindowCustom.cpp: Ditto.
+ * bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
+ * bindings/js/JSImageConstructor.cpp: Ditto.
+ * bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
+ * bindings/js/JSMessageChannelConstructor.cpp: Ditto.
+ * bindings/js/JSOptionConstructor.cpp: Ditto.
+ * bindings/js/JSWorkerConstructor.cpp: Ditto.
+ * bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
+ * bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
+ * inspector/InspectorController.cpp: Ditto.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+ Moved mose of this function into the base class in JavaScriptCore,
+ so the details of compilation don't have to be exposed.
+
+2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6879145>
+ Generate a contextual menu item allowing autocorrections to
+ easily be changed back. Refrain from re-correcting items
+ that have already been autocorrected once.
+
+ * dom/DocumentMarker.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
+ (WebCore::Editor::changeBackToReplacedString):
+ * editing/Editor.h:
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected):
+ * page/mac/WebCoreViewFactory.h:
+ * platform/ContextMenu.cpp:
+ (WebCore::ContextMenu::populate):
+ (WebCore::ContextMenu::checkOrEnableIfNeeded):
+ * platform/ContextMenuItem.h:
+ * platform/LocalizedStrings.h:
+ * platform/mac/LocalizedStringsMac.mm:
+ (WebCore::contextMenuItemTagChangeBack):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::replacedString):
+ * rendering/HitTestResult.h:
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::computeRectForReplacementMarker):
+ (WebCore::InlineTextBox::paintDocumentMarkers):
+ * rendering/InlineTextBox.h:
+
+2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber Stamped by Oliver Hunt.
+
+ [GTK] Fix Gtk+/X11 build on OSX
+
+ Including the CoreFoundation header here and X11 headers
+ later will result in different definitions of Boolean. The
+ CoreFoundation include does not seem to be necessary here
+ and my mac build was successfull without it. I will remove
+ it for now. If the build bots disagree this will be replaced
+ by a #if PLATFORM(CF).
+
+ * platform/FileSystem.h:
+
+2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber Stamped by Gustavo Noronha.
+
+ [GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
+
+ When building Gtk+ on OSX we ended up declaring
+ setNPWindowIfNeeded twice. Fix that by moving
+ the #if PLATFORM(GTK) up and using elif instead of
+ else.
+
+ * plugins/PluginView.h:
+
+2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25685
+ [GTK] Middle click paste form the pasteboard
+
+ The kit wants to paste from at least two different
+ clipboards. By introducing getCurrentTarget to the
+ PasteboardHelper interface we can make this decision
+ in the kit.
+ Use the new method in PasteboardGtk to get the right
+ GdkClipboard for the paste operation.
+
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::Pasteboard::documentFragment):
+ (WebCore::Pasteboard::plainText):
+ * platform/gtk/PasteboardHelper.h:
+
+2009-05-13 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
+ <rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
+
+ QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
+ on Tiger or Leopard.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
+ when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
+ (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute
+ when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
+
+2009-05-12 Roland Steiner <rolandsteiner@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 25738: Skia: CSS border style not cleared for SVG object
+ https://bugs.webkit.org/show_bug.cgi?id=25738
+
+ If no dashing is set, this change reverts to solid stroke
+ (previously the code bailed and left the old setting, whatever it was)
+
+ Test case listed in above bug entry.
+ (Additional complications due to each platform rendering dotted lines differently -
+ c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::setLineDash):
+
+2009-05-11 Erik Arvidsson <arv@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 21903: Adds DOM bindings for the placeholder property of the
+ HTMLInputElement.
+ https://bugs.webkit.org/show_bug.cgi?id=21903
+
+ Test: fast/forms/placeholder-dom-property.html
+
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::updatePlaceholderVisibility):
+ * dom/InputElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::placeholder):
+ (WebCore::HTMLInputElement::setPlaceholder):
+ * html/HTMLInputElement.h:
+ * html/HTMLInputElement.idl:
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+ * wml/WMLInputElement.h:
+ (WebCore::WMLInputElement::placeholder):
+ (WebCore::WMLInputElement::setPlaceholder):
+
+2009-05-12 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25706
+
+ Change V8 bindings to match JSC bindings with respect to using
+ the lexical or dynamic global object.
+
+ Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
+ http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
+ http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
+
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-03-19 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
+
+ SVGList::insertItemBefore would not perform a bounds check on the
+ index it was provided, potentially leading to a buffer overflow.
+
+ Test: svg/dom/svglist-exception-on-out-bounds-error.html
+
+ * svg/SVGList.h:
+ (WebCore::SVGList::insertItemBefore):
+
+2009-05-12 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Bug 25708: Cannot choose menu items in popups with many entries in Chromium
+ https://bugs.webkit.org/show_bug.cgi?id=25708
+
+ This change sets the window size for popups on Mac to include all items
+ in the menu. This is required for hit testing on Mac, where we use native
+ controls to manage the popups and don't want to artificially limit the
+ valid hit testing region to a limited scroll window.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::layout):
+
+2009-05-12 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Fixes to build with latest skia: SkTypeface::Create() is now
+ SkTypeface::CreateFromName(); computeBounds() has been reworked
+ as getBounds(). The changes are placed behind an #ifdef for now,
+ so that we can roll back the skia version in Chromium if necessary
+ without having to roll back this change.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25705
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::createFontPlatformData):
+ * platform/graphics/skia/PathSkia.cpp:
+ (WebCore::Path::boundingRect):
+ (WebCore::boundingBoxForCurrentStroke):
+ * platform/graphics/skia/SkiaUtils.cpp:
+ (WebCore::SkPathContainsPoint):
+
+2009-05-12 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25732
+ Update V8ElementCustom.cpp to match the current API of V8Proxy.
+
+ (WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
+
+2009-05-12 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25694
+ HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
+ to the document NULL ptr
+
+ Test: fast/parser/implicit-head-in-fragment-crash.html
+
+ * html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly
+ create <head> when parsing a fragment.
+
+2009-05-12 Soren Gjesse <sgjesse@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25687
+ Missing check for valid function in V8 bindings for toString function for event listeners.
+
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
+
+2009-05-11 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
+ Not doing that can cause assersion failure.
+ https://bugs.webkit.org/show_bug.cgi?id=25702
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::stop):
+
+2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Bug 25714: [Qt] Decouple HTML5 Database support from the
+ SQLite/generic database support in the Qt port
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25714>
+
+ * WebCore.pro:
+
+2009-05-11 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25713: AX: Control Elements not identified in HTML content
+ https://bugs.webkit.org/show_bug.cgi?id=25713
+
+ Test: accessibility/onclick-handlers.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+
+2009-05-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6276843> REGRESSION: TextIterator generates
+ an extra newline for ranges that start outside of body
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
+ Check startPos for null, not just currPos.
+
+2009-05-11 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
+ https://bugs.webkit.org/show_bug.cgi?id=25700
+
+ Keyboard selection movement handlers need to also watch for the Cmd key when Accessibility is enabled.
+ Note: This code is only used when accessibility is enabled.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleKeyboardSelectionMovement):
+
+2009-05-11 David Kilzer <ddkilzer@apple.com>
+
+ Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25087>
+
+ Reviewed by Timothy Hatcher.
+
+ Change tests for ENABLE macros to check for both existence and
+ value:
+
+ - Negative: #if !defined(ENABLE_FOO) || !ENABLE_FOO
+ - Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
+
+ * css/CSSCharsetRule.idl:
+ * css/CSSPrimitiveValue.idl:
+ * css/RGBColor.idl:
+ * dom/Attr.idl:
+ * dom/DOMCoreException.idl:
+ * dom/DOMImplementation.idl:
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * dom/Event.idl:
+ * dom/EventException.idl:
+ * dom/KeyboardEvent.idl:
+ * dom/MessagePort.idl:
+ * dom/MouseEvent.idl:
+ * dom/Node.idl:
+ * dom/ProcessingInstruction.idl:
+ * dom/Range.idl:
+ * dom/RangeException.idl:
+ * dom/WheelEvent.idl:
+ * html/CanvasPixelArray.idl:
+ * html/HTMLAnchorElement.idl:
+ * html/HTMLAppletElement.idl:
+ * html/HTMLAreaElement.idl:
+ * html/HTMLBaseFontElement.idl:
+ * html/HTMLCanvasElement.idl:
+ * html/HTMLDocument.idl:
+ * html/HTMLElement.idl:
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLFrameElement.idl:
+ * html/HTMLIFrameElement.idl:
+ * html/HTMLImageElement.idl:
+ * html/HTMLInputElement.idl:
+ * html/HTMLLinkElement.idl:
+ * html/HTMLObjectElement.idl:
+ * html/HTMLOptionElement.idl:
+ * html/HTMLOptionsCollection.idl:
+ * html/HTMLSelectElement.idl:
+ * html/HTMLStyleElement.idl:
+ * html/ImageData.idl:
+ * inspector/InspectorController.idl:
+ * loader/appcache/DOMApplicationCache.idl:
+ * page/Console.idl:
+ * page/Coordinates.idl:
+ * page/DOMSelection.idl:
+ * page/DOMWindow.idl:
+ * page/Geoposition.idl:
+ * page/History.idl:
+ * page/Location.idl:
+ * page/Navigator.idl:
+ * svg/SVGElementInstance.idl:
+ * svg/SVGException.idl:
+ * workers/WorkerContext.idl:
+ * xml/XMLHttpRequestException.idl:
+ * xml/XPathException.idl:
+
+2009-05-11 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 24538: class/struct mixup in forward declarations
+ https://bugs.webkit.org/show_bug.cgi?id=24538
+
+ * inspector/InspectorResource.h:
+ * loader/CachedFont.h:
+ * loader/appcache/ApplicationCache.h:
+ * rendering/RenderBlock.h:
+ * rendering/RootInlineBox.h:
+ * rendering/SVGInlineTextBox.h:
+ * svg/SVGGlyphElement.h:
+ * svg/SVGHKernElement.h:
+
+2009-05-11 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 24539: Unresolved CSSMutableStyleDeclaration
+ https://bugs.webkit.org/show_bug.cgi?id=24539
+
+ The Symbian tools can't compile and link this without this include.
+ It's not clear why this is different from other toolsets or why it affects
+ only this header file, but adding the include for now.
+
+ * editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
+
+2009-05-11 Alice Liu <alice.liu@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25701
+ REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
+
+ Test: fast/forms/search-styled.html
+
+ * css/themeWin.css:
+ Remove the overriding of -webkit-appearance for searchfields. This will cause background
+ images to not be honored when styling searchfields
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::adjustSearchFieldStyle):
+ * rendering/RenderThemeWin.h:
+ Re-instate final adjustments to searchfield styling that were removed in r42020
+
+2009-05-11 Brady Eidson <beidson@apple.com>
+
+ Fix Windows build
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::createCFURLResponseWithDefaultMIMEType):
+
+2009-05-11 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25626
+ Update V8ElementCustom.cpp to match the current API of Node.
+
+ * bindings/v8/custom/V8ElementCustom.cpp:
+ (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
+ (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
+
+2009-05-11 Brady Eidson <beidson@apple.com>
+
+ Fix Windows build
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::createCFURLResponseWithDefaultMIMEType):
+ (WebCore::WebCoreSynchronousLoader::load):
+
+2009-05-11 Brady Eidson <beidson@apple.com>
+
+ Fix Windows build
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::createCFURLResponseWithDefaultMIMEType):
+
+2009-05-11 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ V8CustomBinding.cpp is missing a header file
+
+ https://bugs.webkit.org/show_bug.cgi?id=25644
+
+ * bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
+
+2009-05-11 Aaron Boodman <aa@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25634
+ Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().
+
+ Also, change instances of ScriptController::retrieveActiveFrame() to
+ V8::retrieveFrameForEnteredContext() for consistency.
+
+
+ See http://codereview.chromium.org/113085 for the corresponding Chromium change.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::V8Custom::WindowSetLocation):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::navigateIfAllowed):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-05-11 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.
+
+ First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
+ Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::defaultMIMEType): "application/octet-stream"
+ * platform/MIMETypeRegistry.h:
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which
+ might override it to false.
+ (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
+ * platform/network/ResourceHandle.h:
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead
+ of null.
+ (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type.
+ (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same
+ sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the
+ same sniffing policy as asynchronous loads.
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if
+ it hasn't been set up yet.
+ (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by
+ the new mechanism.
+
+2009-05-11 David Kilzer <ddkilzer@apple.com>
+
+ Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"
+
+ This was added in r39816 to disable dynamic entries. They are
+ still disabled after fixing the typo since this feature define
+ is never set anywhere.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ * loader/appcache/DOMApplicationCache.idl:
+
+2009-05-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov and Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25348
+ Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
+
+ Most of the change is in WTF.
+ Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
+ method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
+ is now a class rather then an integer.
+ Also, there is no need to initialize threadID in constructors to 0 now.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
+ since now ThreadIdentifier needs construction and we avoid having global initializers.
+ (WebCore::matchFunc): use the new accessor function.
+ (WebCore::openFunc): ditto.
+ (WebCore::createStringParser): ditto.
+ (WebCore::createMemoryParser): ditto.
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open):
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::SQLiteDatabase):
+ (WebCore::SQLiteDatabase::close):
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::start):
+ (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::start):
+ (WebCore::LocalStorageThread::scheduleImport):
+ (WebCore::LocalStorageThread::scheduleSync):
+ (WebCore::LocalStorageThread::terminate):
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::start):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::start):
+
+2009-05-11 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Remove unused header that declared one function which was never defined anywhere.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means
+ platform/network/cf/ResourceResponse.h)
+ * platform/network/cf/ResourceResponseCFNet.h: Removed.
+
+2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25213
+ Fix assert during Inspector destruction.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::inspectedPageDestroyed): Moved closing
+ inspector above removing InspectorController object to fix JS errors,
+ added clearing inspector page ptr.
+
+2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ [Qt] Make sure that public APIs are properly exported on all Qt platforms
+ https://bugs.webkit.org/show_bug.cgi?id=25601
+
+ * WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win
+
+2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24284
+
+ * WebCore.pro: duplicated values removed from INCLUDEPATH
+
+2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Eric Seidel.
+
+ Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
+ https://bugs.webkit.org/show_bug.cgi?id=24688
+
+ * WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
+ * platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
+
+2009-05-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix a crash when deactivating a document that had adopted a <form>
+ element
+
+ Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the
+ logic here: <form> elements should be registered for document activation
+ callbacks if and only if autocomplete is off.
+
+2009-05-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
+ to view protected MobileMe video
+
+ Add a temporary workaround.
+
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when
+ starting a request, so we need to store this data for later use.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks.
+ (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
+
+2009-05-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
+
+ * platform/network/cf/AuthenticationCF.cpp:
+ * platform/network/cf/AuthenticationCF.h:
+ (WebCore::WebCoreCredentialStorage::set):
+ (WebCore::WebCoreCredentialStorage::get):
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ Move WebCore credential storage to AuthenticationCF, so that WebKit could use it (macthing
+ an earlier Mac change).
+
+2009-05-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
+ called at a wrong time.
+
+ No test, because we are waiting for a newer version of system frameworks to test the attribute.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
+ * xml/XMLHttpRequest.h:
+ * xml/XMLHttpRequest.idl:
+ Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
+
+2009-05-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=25602
+ REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
+ on ToT
+
+ Test: fast/layers/self-painting-outline.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
+ if it is a self-painting layer.
+
+2009-05-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen and Mark Rowe.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=25666
+ Assertion failure in Node::setDocument()
+ (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
+
+ Test: fast/dom/HTMLFormElement/adopt-assertion.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
+ this method are required to call the base class implementation. Do it.
+ (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
+
+2009-03-29 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
+ make sure CURL does not create empty ResourceError() objects.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24927
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::downloadTimerCallback):
+
+2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
+
+ Build fix, adding missing files to make dist.
+
+ * GNUmakefile.am:
+
+2009-05-08 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=25656
+
+ Reduce the inline capacity of CSSParserValueList's m_values
+ vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.
+
+ * css/CSSParserValues.h:
+
+2009-05-08 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-05-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6864786> REGRESSION: Crash below
+ ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in
+ Bugzilla
+
+ Test: editing/style/apply-through-end-of-document.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null
+ check for the case of a range extending through the end of the document,
+ in which pastEndNode is 0.
+
+2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
+ marked as misspelled even though contraction is a word
+ Make sure spelling underline does not persist on words like
+ <doesn't>.
+
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::typingAddedToOpenCommand):
+
+2009-05-08 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Make sure the path's refdata isn't deleted before we're done with the object.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25652
+
+ * platform/graphics/wx/PathWx.cpp:
+ (WebCore::Path::~Path):
+ (WebCore::Path::Path):
+ (WebCore::Path::translate):
+
+2009-05-08 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for memory leak on Mac.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25650
+
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+
+2009-05-08 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6857446> REGRESSION (r37591): Cannot print or
+ preview from maps.yandex.ru
+
+ We need to fall into the stretchesToViewHeight() quirk when we are
+ printing and we are the root and the root has percentage height OR
+ when we are the body and the root has percentage height. Otherwise
+ we have a height of 0 and can run into painting troubles.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcHeight):
+
+2009-05-08 Douglas Davidson <ddavidso@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes for <rdar://problem/6852771>.
+ Prevent text checking replacement immediately after an apostrophe
+ and automatic link addition except immediately after typing.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
+
+2009-05-08 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25627
+ Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
+
+ Update for HTML5 spec change to fire 'error' events on <source> element
+ when there is a failure while processing/loading a <source>.
+
+ Test: media/video-source-error.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::enqueueEvent): Remove white-space.
+ (WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead
+ of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on
+ all <source> element.
+ (WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in
+ loadResource() as we need to report errors differently depending on the type of failure. Use
+ KURL instead of String.
+ (WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild.
+ Fail silently when there are no more <source> canditates because that is what spec mandates.
+ Keep url as KURL instead of converting to String.
+ (WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now
+ assume the safety check now done before this function. Takes KURL instead of String.
+ (WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs
+ failure if not.
+ (WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
+ (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on
+ the media and all source elements.
+ (WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the
+ the failure happened while processing one. Only call nonSupported() when the failure happened
+ while processing media element 'src' attribute.
+ (WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild.
+ Deal with selectNextSourceChild returning a KURL instead of a String.
+ (WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional
+ param to control whether or not errors are fired on a source element when it will not be used.
+ Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a
+ String.
+ (WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as
+ a KURL instead of a String.
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::):
+
+ * html/HTMLSourceElement.cpp:
+ (WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables.
+ (WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error
+ event ASAP.
+ (WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event.
+ (WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been
+ cancelled.
+ * html/HTMLSourceElement.h:
+
+ * html/MediaError.h:
+ (WebCore::MediaError::): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
+ * html/MediaError.idl: Ditto
+
+2009-05-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - fix <rdar://problem/6859955> Undoing typed text after selecting all
+ leaves non-text areas highlighted
+
+ Test: fast/repaint/selection-clear.html
+
+ When RenderView::clearSelection() is called from
+ SelectionController::nodeWillBeRemoved(), selected renderers may already
+ be marked for layout, which means that they can no longer compute
+ their selection repaint info. Instead, an empty IntRect (or GapRects) is
+ returned, leading to incomplete repaint.
+
+ The fix is not to rely on individual renderers when clearing the
+ selection, but instead, cache the bounding rectangle of the selected
+ blocks' GapRects when setting the selection, and invalidate that
+ entire rectangle when clearing it.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::setSelection): Added a parameter saying whether
+ the repainting of selected blocks should include both
+ previously-selected areas and newly-selected areas or only
+ newly-selected areas. The default is both. Also compute
+ m_cachedSelectionBounds to be the bounding rectangle of the
+ new selection's BlockSelectionInfos' GapRects.
+ (WebCore::RenderView::clearSelection): Repaint m_cachedSelectionBounds,
+ and tell setSelection() that it should not paint areas that were in
+ the old selection's BlockSelectionInfos' GapRects.
+ * rendering/RenderView.h:
+ (WebCore::RenderView::):
+
+2009-05-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ <rdar://problem/6868773> NPN_GetAuthenticationInfo does not work with non-permanent credentials
+
+ * WebCore.base.exp:
+ * platform/network/mac/AuthenticationMac.h:
+ (WebCore::WebCoreCredentialStorage::set):
+ (WebCore::WebCoreCredentialStorage::get):
+ * platform/network/mac/AuthenticationMac.mm:
+ * platform/network/mac/ResourceHandleMac.mm:
+ Moved WebCoreCredentialStorage to AuthenticationMac, so that it could be used from WebKit.
+
+2009-05-08 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the Qt build, add missing JSC_HOST_CALL macros to the runtime
+ call methods.
+
+ * bridge/qt/qt_runtime.h:
+
+2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Add missing strings to localizedStrings.js
+ https://bugs.webkit.org/show_bug.cgi?id=25635
+
+ Add the strings "Delete", "Key", "Refresh" and "Value".
+
+ * English.lproj/localizedStrings.js:
+
+2009-05-08 Robert Hogan <robert@roberthogan.net>
+
+ Reviewed, tweaked and landed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24992
+ [Qt] crash at http://browserspy.dk/browser.php
+
+ This cannot be easily tested in DRT, because it relies on interaction with QApplication,
+ but the added assertions guard against re-introducing this issue.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Don't make client calls
+ while the frame is being constructed, because the intermediate state without a document
+ is something we don't want to expose.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setJSStatusBarText): Assert that the frame has a document, which is an
+ approximation of it being in a consistent state for client calls.
+ (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
+
+2009-05-07 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
+ Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
+
+ Roll out r43366 as it removed symbols that Safari 4 Beta uses.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::matchFunc):
+ (WebCore::openFunc):
+ (WebCore::createStringParser):
+ (WebCore::createMemoryParser):
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open):
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::SQLiteDatabase):
+ (WebCore::SQLiteDatabase::close):
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::DatabaseThread):
+ (WebCore::DatabaseThread::start):
+ (WebCore::DatabaseThread::databaseThread):
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::LocalStorageThread):
+ (WebCore::LocalStorageThread::start):
+ (WebCore::LocalStorageThread::localStorageThread):
+ (WebCore::LocalStorageThread::scheduleImport):
+ (WebCore::LocalStorageThread::scheduleSync):
+ (WebCore::LocalStorageThread::terminate):
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::start):
+
+2009-05-08 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ Unify scrolling code via adjustments and keys. Use the WebCore
+ defined constants, since that's what people are most used to at
+ this point.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformHandleHorizontalAdjustment):
+ (WebCore::ScrollView::platformHandleVerticalAdjustment):
+
+2009-05-07 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY.
+ Suggested by Oliver Hunt.
+
+ Rolling back http://trac.webkit.org/changeset/43385
+ because we have to use mac artwork for the underline on OSX.
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ * platform/graphics/mac/GraphicsContextMac.mm:
+ (WebCore::createPatternColor):
+ (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ (WebCore::setCGStrokeColor):
+ (WebCore::spellingPatternColor):
+ (WebCore::grammarPatternColor):
+ (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
+
+2009-05-07 John Grabowski <jrg@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25573
+ Unify use of CG-common routine for drawLineForMisspellingOrBadGrammar.
+ Cleanup for WebKit, but required for Chromium happiness.
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::spellingPatternColor):
+ (WebCore::grammarPatternColor):
+ (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
+ * platform/graphics/mac/GraphicsContextMac.mm:
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+
+2009-05-07 Darin Adler <darin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Bug 25575: Registered mutation event listener crashes HTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=25575
+
+ Test: fast/media/video-controls-with-mutation-event-handler.html
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createTimeline): Call setAttribute here.
+
+2009-05-07 Simon Fraser <simon.fraser@apple.com>
+
+ Rubber Stamped by Dave Hyatt
+
+ Shuffle the data members to minimize padding.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::RenderTableSection):
+ * rendering/RenderTableSection.h:
+
+2009-05-07 Simon Fraser <simon.fraser@apple.com>
+
+ Rubber Stamped by Dave Hyatt
+
+ Shuffle the data members to make Events 8 bytes smaller in 64-bit.
+
+ * dom/Event.cpp:
+ (WebCore::Event::Event):
+ * dom/Event.h:
+
+2009-05-07 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Beth Dakin.
+
+ Fix regression caused by r41469, add test case to prevent it from
+ happening again.
+ https://bugs.webkit.org/show_bug.cgi?id=25252
+
+ hasLayer() was true during removeOnlyThisLayer()/
+ updateLayerPositions()
+ which caused updateLayerPosition()'s walk up the render tree to
+ include offsets from the layer we were about to remove.
+
+ I'm not 100% convinced that this wasn't a bug in
+ updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
+ because the layer in question is not the containing block for the
+ block which gets laid out wrong. But this restores the previous
+ behavior and adds a test. So the next time someone is in here re-
+ factoring, they will at least know if they break something.
+
+ Test: fast/layers/remove-only-this-layer-update.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::destroyLayer):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::removeOnlyThisLayer):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::destroy):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy):
+
+2009-05-07 Dmitry Titov <dimich@chromium.org>
+
+ Attempt to fix GTK build.
+
+ * platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.
+
+2009-05-07 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Improve native call performance
+
+ Add calling convention declarations where necessary, and update bindings
+ script to generate them as well.
+
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::callHTMLCollection):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::callNodeList):
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::callPlugin):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/runtime_method.cpp:
+ (JSC::callRuntimeMethod):
+ * bridge/runtime_object.cpp:
+ (JSC::callRuntimeObject):
+
+2009-05-07 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
+
+ Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
+
+ Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
+ gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
+
+ The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
+ This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
+ To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
+ methods are renamed to clarify where they belong to. All renames are listed here:
+
+ From FormControlElement:
+ - isEnabled() -> isEnabledFormControl()
+ - isReadOnly() -> isReadOnlyFormControl()
+ - isTextControl() -> isTextFormControl()
+ - valueMatchesRenderer() -> formControlValueMatchesRenderer()
+ - setValueMatchesRenderer() -> setFormControlValueMatchesRenderer()
+ - name() -> formControlName()
+ - type() -> formControlType()
+
+ From FormControlElementWithState:
+ - saveState() -> saveFormControlState()
+ - restoreState() -> restoreFormControlState()
+
+ A lot of Element -> FormControlElement(WithState) casting is gone again, so it's not only a memory, but also a performance progression.
+
+ No testcases affected, no new tests needed.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::canShareStyleWithElement):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * dom/Document.cpp:
+ (WebCore::Document::formElementsState):
+ * dom/Document.h:
+ (WebCore::Document::registerFormElementWithState):
+ (WebCore::Document::unregisterFormElementWithState):
+ * dom/Element.h:
+ (WebCore::Element::isFormControlElement):
+ (WebCore::Element::isEnabledFormControl):
+ (WebCore::Element::isReadOnlyFormControl):
+ (WebCore::Element::isTextFormControl):
+ (WebCore::Element::formControlValueMatchesRenderer):
+ (WebCore::Element::setFormControlValueMatchesRenderer):
+ (WebCore::Element::formControlName):
+ (WebCore::Element::formControlType):
+ (WebCore::Element::saveFormControlState):
+ (WebCore::Element::restoreFormControlState):
+ * dom/FormControlElement.cpp: Removed.
+ * dom/FormControlElement.h: Removed.
+ * dom/FormControlElementWithState.cpp: Removed.
+ * dom/FormControlElementWithState.h: Removed.
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::setValueFromRenderer):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::formControlType):
+ * html/HTMLButtonElement.h:
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::formControlType):
+ * html/HTMLFieldSetElement.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::attach):
+ (WebCore::HTMLFormControlElement::formControlName):
+ (WebCore::HTMLFormControlElement::willValidate):
+ (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
+ (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
+ (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
+ (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
+ (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
+ * html/HTMLFormControlElement.h:
+ (WebCore::HTMLFormControlElement::isTextFormControl):
+ (WebCore::HTMLFormControlElement::isEnabledFormControl):
+ (WebCore::HTMLFormControlElement::formControlValueMatchesRenderer):
+ (WebCore::HTMLFormControlElement::setFormControlValueMatchesRenderer):
+ (WebCore::HTMLFormControlElement::isReadOnlyFormControl):
+ (WebCore::HTMLFormControlElement::type):
+ (WebCore::HTMLFormControlElement::name):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::formControlName):
+ (WebCore::HTMLInputElement::formControlType):
+ (WebCore::HTMLInputElement::saveFormControlState):
+ (WebCore::HTMLInputElement::restoreFormControlState):
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::detach):
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setFileListFromRenderer):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::readOnly):
+ (WebCore::HTMLInputElement::isTextFormControl):
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::formControlType):
+ * html/HTMLKeygenElement.h:
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::formControlType):
+ * html/HTMLLegendElement.h:
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::formControlType):
+ * html/HTMLOptGroupElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::formControlType):
+ * html/HTMLOptionElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::formControlType):
+ (WebCore::HTMLSelectElement::saveFormControlState):
+ (WebCore::HTMLSelectElement::restoreFormControlState):
+ * html/HTMLSelectElement.h:
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
+ (WebCore::HTMLTextAreaElement::formControlType):
+ (WebCore::HTMLTextAreaElement::saveFormControlState):
+ (WebCore::HTMLTextAreaElement::restoreFormControlState):
+ (WebCore::HTMLTextAreaElement::updateValue):
+ (WebCore::HTMLTextAreaElement::setValue):
+ * html/HTMLTextAreaElement.h:
+ (WebCore::HTMLTextAreaElement::readOnly):
+ (WebCore::HTMLTextAreaElement::isTextFormControl):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isEnabled):
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ * page/DragController.cpp:
+ (WebCore::DragController::concludeEditDrag):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::itemIsEnabled):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::updateUserModifyProperty):
+ (WebCore::RenderTextControl::setInnerTextValue):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isEnabled):
+ (WebCore::RenderTheme::isReadOnlyControl):
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustMenuListStyle):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::adjustMenuListStyle):
+ * wml/WMLFormControlElement.cpp:
+ * wml/WMLFormControlElement.h:
+ (WebCore::WMLFormControlElement::isReadOnlyFormControl):
+ (WebCore::WMLFormControlElement::isTextFormControl):
+ (WebCore::WMLFormControlElement::formControlValueMatchesRenderer):
+ (WebCore::WMLFormControlElement::setFormControlValueMatchesRenderer):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::WMLInputElement):
+ (WebCore::WMLInputElement::isKeyboardFocusable):
+ (WebCore::WMLInputElement::isMouseFocusable):
+ (WebCore::WMLInputElement::dispatchBlurEvent):
+ (WebCore::WMLInputElement::formControlType):
+ (WebCore::WMLInputElement::formControlName):
+ (WebCore::WMLInputElement::setValue):
+ (WebCore::WMLInputElement::saveFormControlState):
+ (WebCore::WMLInputElement::restoreFormControlState):
+ (WebCore::WMLInputElement::parseMappedAttribute):
+ (WebCore::WMLInputElement::detach):
+ (WebCore::WMLInputElement::appendFormData):
+ (WebCore::WMLInputElement::init):
+ * wml/WMLInputElement.h:
+ (WebCore::WMLInputElement::isTextFormControl):
+ * wml/WMLOptGroupElement.cpp:
+ (WebCore::WMLOptGroupElement::formControlType):
+ * wml/WMLOptGroupElement.h:
+ * wml/WMLOptionElement.cpp:
+ (WebCore::WMLOptionElement::formControlType):
+ * wml/WMLOptionElement.h:
+
+2009-05-07 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov and Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25348
+ Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
+
+ Most of the change is in WTF.
+ Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
+ method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
+ is now a class rather then an integer.
+ Also, there is no need to initialize threadID in constructors to 0 now.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
+ since now ThreadIdentifier needs construction and we avoid having global initializers.
+ (WebCore::matchFunc): use the new accessor function.
+ (WebCore::openFunc): ditto.
+ (WebCore::createStringParser): ditto.
+ (WebCore::createMemoryParser): ditto.
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open):
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::SQLiteDatabase):
+ (WebCore::SQLiteDatabase::close):
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::start):
+ (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::start):
+ (WebCore::LocalStorageThread::scheduleImport):
+ (WebCore::LocalStorageThread::scheduleSync):
+ (WebCore::LocalStorageThread::terminate):
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::start):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::start):
+
+2009-05-07 Simon Fraser <simon.fraser@apple.com>
+
+ Rubber Stamped by Dave Hyatt
+
+ Shuffle the data members to minimize padding.
+
+ * dom/ClassNames.h:
+
+2009-05-07 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
+ https://bugs.webkit.org/show_bug.cgi?id=25605
+
+ Shrink GlyphPage by splitting the array of GlyphData, which has lots
+ of padding, into separate Glyph and SimpleFontData* arrays.
+
+ * platform/graphics/Font.h:
+ glyphDataForCharacter has to return a GlyphData by value now.
+
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+ Return GlyphData by value.
+
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::GlyphPageTreeNode::initializePage):
+ Better encapsulation of GlyphPage, using the new methods.
+
+ * platform/graphics/Font.h:
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::GlyphPageTreeNode::initializePage):
+ * platform/graphics/GlyphPageTreeNode.h:
+ (WebCore::GlyphData::GlyphData):
+ (WebCore::GlyphPage::indexForCharacter):
+ (WebCore::GlyphPage::glyphDataForCharacter):
+ (WebCore::GlyphPage::glyphDataForIndex):
+ (WebCore::GlyphPage::glyphAt):
+ (WebCore::GlyphPage::fontDataForCharacter):
+ (WebCore::GlyphPage::setGlyphDataForCharacter):
+ (WebCore::GlyphPage::setGlyphDataForIndex):
+ (WebCore::GlyphPage::copyFrom):
+ (WebCore::GlyphPage::clear):
+
+2009-05-07 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25625
+ Implement Image/Option constructors in V8 bindings.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
+ * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
+ * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.
+
+2009-05-07 Brady Eidson <beidson@apple.com>
+
+ I hate myself for doing this, but need to fix that ChangeLog entry.
+
+ * ChangeLog:
+
+2009-05-07 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Darin Adler
+
+ * html/HTMLParser.cpp: Use the correct style of BUILDING_ON_* for WebCore.
+ * html/HTMLParser.h: Ditto
+
+2009-05-07 David Hyatt <hyatt@apple.com>
+
+ Restore intrinsic margins to all form controls on Mac and Windows. Some of this regressed in 43007
+ when textareas were given explicit margins. Some of it had already regressed earlier whenever intrinsic
+ margins were turned off in themeWin.css.
+
+ Reviewed by Beth Dakin.
+
+ * css/html4.css:
+ * css/themeWin.css:
+
+2009-05-07 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler and Alexey Proskuryakov.
+
+ <rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
+ (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
+ (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
+ * html/HTMLParser.h:
+ (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
+
+2009-05-07 Antony Sargent <asargent@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Fix a memory leak in V8EventListenerList::remove.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25618
+
+ No new functionality so no new tests.
+
+ * bindings/v8/V8EventListenerList.cpp:
+ (WebCore::V8EventListenerList::remove):
+
+2009-05-07 Darin Fisher <darin@chromium.org>
+
+ Fix Chromium build bustage.
+
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing
+ HTMLCollection.h include.
+
+2009-05-07 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
+ https://bugs.webkit.org/show_bug.cgi?id=25598
+
+ Test: accessibility/radio-button-title-label.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::exposesTitleUIElement):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
+ (WebCore::AccessibilityRenderObject::titleUIElement):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ * page/AccessibilityRenderObject.h:
+
+2009-05-07 Darin Fisher <darin@chromium.org>
+
+ Fix Chromium build bustage.
+
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"
+
+2009-05-07 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25610
+ [GTK] text.caretOffset is reportedly always 0
+
+ Use the right function to get the caret offset in an
+ element. selectionStart() would only work for text
+ controls (there's even an ASSERT when calculating the selected
+ text range). Instead just get the selection and get the offset of
+ the start position.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix support for antialiased CSS border-radius
+
+ WebKit implements border-radius by drawing a double-size border,
+ and then letting the clip constrain the border to the right width
+ and position. This requires support for antialiased clipping, as
+ well as painting, to get a nice smooth border.
+
+ Qt only does antialiased clipping if the anti-alias flag is set
+ at the time of clipping, so we have to enable this in the method
+ addInnerRoundedRectClip(), as well as when we draw the border.
+
+ Currently the raster-engine is the only Qt paint engine to support
+ anti-aliased clipping, but the OpenGL and Mac paint engines could
+ potentially support this in the future.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::strokeArc):
+ (WebCore::GraphicsContext::addInnerRoundedRectClip):
+
+2009-05-07 Adam Langley <agl@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Render empty optgroup elements.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24900
+
+ Currently, optgroup elements which are empty are not rendered. The
+ HTML specification gives no guidance on this situation.
+
+ However, the test for being empty is that they have no children, thus
+ this will not render:
+ <optgroup label="test"></optgroup>
+ while this /will/ render (because of the text node child):
+ <optgroup label="test"> </optgroup>
+
+ This patch will cause both cases to render which matches IE's and
+ Firefox's behaviour.
+
+ The difference only appears when opening the select element and does
+ not appear in the render tree. Thus, a manual layout-test is required.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::recalcListItems):
+ * manual-tests/optgroup-empty-and-nested.html: Added.
+
+2009-05-06 Julie Parent <jparent@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 25608: Unused m_frame in ChromiumClipboard.
+ https://bugs.webkit.org/show_bug.cgi?id=25608
+
+ * platform/chromium/ClipboardChromium.h:
+
+ No tests added as this is only removing dead code, no functional changes.
+
+2009-05-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser and Justin Garcia.
+
+ - fix another part of <rdar://problem/6703873> Triple-click quoted line
+ and type Return creates an extra quoted blank line
+
+ Test: editing/inserting/6703873-2.html
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for
+ determining the first node that should go into the new blockquote
+ given the split position: if it is at the end of a container, use the
+ next node after the container. Otherwise, use the child at the
+ position's offset.
+
+2009-05-06 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix, fixes for wx trunk builds.
+
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/wx/RenderThemeWx.cpp:
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+
+2009-05-06 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25597
+ Fix API drift compile errors that occurred while this was ifdef-ed out.
+ The two big issues were that RenderObject::element() became
+ RenderObject::node() and some of the wk* drawing functions had
+ an extra theme parameter added to the argument list.
+
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
+ (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
+ (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
+ (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton):
+ (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton):
+ (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
+ (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
+
+2009-05-06 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25385
+ Upstream changes to V8 bindings for supporting nested workers.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::ToV8Object):
+ (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
+ * bindings/v8/custom/V8WorkerCustom.cpp:
+ (WebCore::getEventListener):
+ (WebCore::ACCESSOR_SETTER WorkerOnmessage):
+ (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
+
+2009-05-06 Dave Moore <davemoore@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25513
+ The V8 bindings convert every javascript property to its associated css style
+ name. It then calls functions that convert that name to an id. This makes
+ getting or setting css styles on elements slow.
+
+ The patch fixes this by caching the results of the transformation, mapping a
+ javascript property name to its css property id. It then calls the already
+ public webkit methods that take the id in place of the string property names.
+
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+
+2009-05-06 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25591
+ Upstream V8HTMLFormElement from the Chromium repository.
+
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+ (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository
+ (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor();
+ (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
+
+2009-05-06 Albert J. Wong <ajwong@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25595
+ Upstream V8CanvasPixelArrayCustom from chromium port tree.
+
+ * bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
+
+2009-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Rubber-stampted by Eric Seidel
+
+ Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
+ Only affects ACCELERATED_COMPOSITING builds.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::adjustStyleDifference):
+
+2009-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ <rdar://problem/6862550> Reduce size of RenderText in 64-bit
+
+ Rearrange data members of RenderText so that an int comes
+ first, to minimize padding.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+ * rendering/RenderText.h:
+
+2009-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ <rdar://problem/6862823> Reduce size of RenderStyle in 64-bit
+
+ Rearrange data members of RenderStyle to minimize padding
+ when building for 64-bit.
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::RenderStyle):
+ * rendering/style/RenderStyle.h:
+ (WebCore::):
+
+2009-05-06 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25596
+
+ Fixes Chromium build bustage caused by r43317 (making
+ RefCountedBase::m_refCount private)
+
+ * page/chromium/AccessibilityObjectWrapper.h:
+ (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
+
+2009-05-06 Hin-Chung Lam <hclam@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25593
+
+ Refactor for MediaPlayerPrivate for Chromium port. Remove
+ the implementation of MediaPlayerPrivateInferface from it.
+
+ * platform\graphics\chromium\MediaPlayerPrivateChromium.h:
+
+2009-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt, Dan Bernstein
+
+ <rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit
+
+ Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.
+
+ * platform/graphics/FontFallbackList.cpp:
+ (WebCore::FontFallbackList::FontFallbackList):
+ * platform/graphics/FontFallbackList.h:
+
+2009-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler, Dan Bernstein
+
+ <rdar://problem/6860068> Reduce size of InlineBox in 64-bit
+
+ Re-order the data members of InlineBox to save 8 bytes when building 64-bit.
+
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+
+2009-05-06 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25588
+ Adding the custom v8 bindings Document.location.
+
+ * bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
+
+2009-05-06 Kevin McCullough <kmccullough@apple.com>
+
+ -Clarified a comment
+
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+
+2009-05-06 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.
+
+ * wml/WMLAElement.cpp:
+ * wml/WMLAccessElement.cpp:
+ * wml/WMLBRElement.cpp:
+ * wml/WMLCardElement.cpp:
+ * wml/WMLDoElement.cpp:
+ * wml/WMLElement.cpp:
+ * wml/WMLFieldSetElement.cpp:
+ * wml/WMLGoElement.cpp:
+ * wml/WMLImageElement.cpp:
+ * wml/WMLInputElement.cpp:
+ * wml/WMLMetaElement.cpp:
+ * wml/WMLOnEventElement.cpp:
+ * wml/WMLOptGroupElement.cpp:
+ * wml/WMLOptionElement.cpp:
+ * wml/WMLPElement.cpp:
+ * wml/WMLPostfieldElement.cpp:
+ * wml/WMLSetvarElement.cpp:
+ * wml/WMLTableElement.cpp:
+ * wml/WMLTemplateElement.cpp:
+ * wml/WMLTimerElement.cpp:
+
+2009-05-06 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25526
+ [Gtk] Additional support is needed for caret browsing
+
+ Emit AtkText::text-selection-changed when the selection changes
+ and the current selection is of Range (ie, the start and end
+ positions are different) type. This seems to match what Gecko
+ does.
+
+ * editing/gtk/SelectionControllerGtk.cpp:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+
+2009-05-05 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25526
+ [Gtk] Additional support is needed for caret browsing
+
+ Emit AtkText::text-caret-moved when selection changes.
+
+ * GNUmakefile.am:
+ * editing/SelectionController.h:
+ * editing/gtk/SelectionController.cpp: Added.
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+
+2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ Use mozilla cursors for the previously not implemented
+ cursors. The manual-tests/cursor.html is looking complete
+ now.
+
+ * platform/gtk/CursorGtk.cpp:
+ (WebCore::cellCursor):
+ (WebCore::noDropCursor):
+ (WebCore::progressCursor):
+ (WebCore::noneCursor):
+ (WebCore::notAllowedCursor):
+ (WebCore::grabCursor):
+ (WebCore::grabbingCursor):
+ * platform/gtk/CursorGtk.h:
+
+2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ Properly indent the header file.
+
+ * platform/gtk/CursorGtk.h:
+
+2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ Use the mozilla copyright header. Use MPL1.1/GPL2.0
+ and LGPL2.1 as the license compared to LGPL2.0.
+
+ * platform/gtk/CursorGtk.h:
+
+2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Gustavo Noronha.
+
+ Move PluginView::invalidateRegion from the
+ TemporaryLinkStubs to PluginViewGtk.cpp and implement
+ it with a call to Widget::invalidate() just like
+ mac is doing. Optimisations would have to be window
+ system specific.
+
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::invalidateRegion):
+
+2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ Misc fixes to InspectorClientGtk.
+
+ * GNUmakefile.am: Add localizedStrings.js to webinspector_DATA.
+ This prevents copious amounts "Localized string not found" errors
+ in the console
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ Fix the Qt build on Windows.
+
+ * platform/graphics/GraphicsContext.h:
+ (WebCore::GraphicsContext::shouldIncludeChildWindows): Implemented dummy accessor.
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Tweak WebCore.pro for being able to override the generated sources dir for the
+ generated_files target.
+
+ * WebCore.pro:
+
+2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Fix the Qt/Windows build, use iface instead of interface to avoid conflict
+ with VS2005 headers.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
+
+2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ We need to include StringExtras.h on Windows CE to access the strdup function.
+
+ * plugins/PluginStream.cpp:
+
+2009-05-06 Soren Gjesse <sgjesse@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=25544
+
+ In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
+ function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
+ use the source of an event handler to create new functions this wrapper code causes compatibility problems.
+
+ Create a specific toString function for these handlers which will return a function source compatible with the
+ source returned by the JSC bindings and other browsers.
+
+ Test: fast/events/event-function-toString.html
+
+ * bindings/v8/ScriptEventListener.cpp:
+ (WebCore::createAttributeEventListener):
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::V8LazyEventListener):
+ (WebCore::V8LazyEventListener::getListenerFunction):
+ (WebCore::V8LazyEventListenerToString):
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction):
+ * bindings/v8/V8LazyEventListener.h:
+ (WebCore::V8LazyEventListener::create):
+
+2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Build QtWebKit as a framework on Mac
+
+ This implies both debug and release build by default, unless
+ one of the --debug or --release config options are passed to
+ the build-webkit script.
+
+ Frameworks can be disabled by passing CONFIG+=webkit_no_framework
+ to the build-webkit script.
+
+ To be able to build both debug and release targets in parallel
+ we have to use separate output directories for the generated
+ sources, which is not optimal, but required to avoid race conditions.
+
+ An optimization would be to only require this spit-up on Mac.
+
+ * WebCore.pro:
+
+2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
+
+ A couple of the generators left the bison output file in the source
+ tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
+ work well when building release and debug configurations in parallel.
+
+ * WebCore.pro:
+
+2009-05-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ - fix an assertion failure in RemoveNodeCommand() when deleting a <br>
+ between a block and a mail blockquote
+
+ Test: editing/deleting/removeNodeCommand-assert.html
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block
+ to prune() instead of passing m_upstreamStart.node(), because the latter
+ may have been removed already.
+
+2009-05-05 Eric Seidel <eric@webkit.org>
+
+ No review, roll out only.
+
+ Roll out r23072 since it broke layout tests
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+
+2009-05-05 Ben Murdoch <benm@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
+ https://bugs.webkit.org/show_bug.cgi?id=24776
+
+ No functional changes, thus no tests.
+
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.h:
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ * bindings/js/JSCustomSQLStatementErrorCallback.h:
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionCallback.h:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h:
+ * bindings/js/JSDatabaseCustom.cpp:
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ * loader/EmptyClients.h:
+ * page/ChromeClient.h:
+ * storage/ChangeVersionWrapper.cpp:
+ * storage/ChangeVersionWrapper.h:
+ * storage/Database.cpp:
+ (WebCore::Database::databaseInfoTableName):
+ * storage/Database.h:
+ * storage/Database.idl:
+ * storage/DatabaseTask.cpp:
+ * storage/DatabaseTask.h:
+ * storage/DatabaseThread.cpp:
+ * storage/DatabaseThread.h:
+ * storage/DatabaseTracker.cpp:
+ * storage/DatabaseTracker.h:
+ * storage/DatabaseTrackerClient.h:
+ * storage/OriginQuotaManager.cpp:
+ * storage/OriginQuotaManager.h:
+ * storage/SQLStatement.cpp:
+ * storage/SQLStatement.h:
+ * storage/SQLTransaction.cpp:
+ * storage/SQLTransaction.h:
+ * storage/SQLTransaction.idl:
+
+2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add some documentation to InlineBox::x(),y().
+ https://bugs.webkit.org/show_bug.cgi?id=25378
+
+ * rendering/InlineBox.h:
+
+2009-05-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Eric Seidel.
+
+ Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
+ https://bugs.webkit.org/show_bug.cgi?id=24693
+
+ * WebCore.pro:
+
+2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
+
+ Reviewed by Eric Seidel.
+
+ Anonymous blocks should not be exposed in accessibility tree.
+ Part of https://bugs.webkit.org/show_bug.cgi?id=23072
+
+ Tests: accessibility/ignore-anonymous-block.html
+ platform/win/accessibility/document-role.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return
+ true for Anonymous blocks. Matching Firefox 2.0.0.14
+
+2009-05-05 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ http://bugs.webkit.org/show_bug.cgi?id=25487
+
+ For euc-kr and other 8bit Korean encodings
+ (similar to euc-kr/windows-949), make document.charset return
+ EUC-KR instead of windows-949. The latter is not recognized by
+ Korean web servers.
+
+ Add domName method to TextEncoding to deal with cases where
+ our internal encoding name does not match what's widely recognized
+ by web servers. Currently, the only case is 'windows-949' (internal
+ name) vs 'EUC-KR'.
+
+ Test: fast/encoding/euckr-name.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::encoding): Call TextEncoding.domName() instead
+ of TextEncoding.name().
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::domName): For the canonical name 'windows-949',
+ return 'EUC-KR'. Otherwise, just return the canonical name.
+ * platform/text/TextEncoding.h:
+
+2009-05-05 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Adler.
+
+ Rendering fix for <select> elements.
+ https://bugs.webkit.org/show_bug.cgi?id=25558
+
+ When switching a <select> element from display:none to default
+ display, we would fail to invalidate the parent's pref widths in some
+ situations:
+
+ When attaching the element, RenderMenuList::updateOptionsWidth would
+ call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
+ set. This would mark the pref widths as dirty, but not for any parent
+ objects.
+
+ When RenderObjectChildList::appendChildNode later calls
+ setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
+ nothing would be done because the pref widths were already dirty for.
+ the RenderMenuList.
+
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::updateOptionsWidth):
+
+2009-05-05 Antony Sargent <asargent@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Switch V8EventListenerList to use HashTable<T>.
+ https://bugs.webkit.org/show_bug.cgi?id=25496
+
+ This avoids some tricky issues with event listener removal in the
+ current implementation and has slightly better performance.
+
+ No new functionality so no new tests.
+
+ * bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
+ * bindings/v8/V8EventListenerList.h:
+ (WebCore::V8EventListenerList::size):
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
+
+2009-05-05 Darin Fisher <darin@chromium.org>
+
+ Fixing build bustage.
+
+ Add some missing includes to fix the Chromium build.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+
+2009-05-05 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25570
+
+ history.{back,forward,go} should always be dispatched asynchronously,
+ even when the history navigation would just result in scrolling the
+ page. This matches the behavior of other browsers like IE and FF.
+
+ Test: fast/history/back-forward-is-asynchronous.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::scheduleHistoryNavigation):
+
+2009-05-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+ https://bugs.webkit.org/show_bug.cgi?id=25568
+
+ Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
+ which was causing transformed SVG text when filled/stroked with a
+ pattern using patternUnits=objectBoundingBox to draw incorrectly.
+
+ I fixed the incorrect drawing (by removing the broken code) and added
+ two test cases to test the fix:
+ * svg/transforms/text-with-pattern-inside-transformed-html.xhtml
+ * svg/transforms/text-with-pattern-with-svg-transform.svg
+
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::mapLocalToContainer):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::mapLocalToContainer):
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+
+2009-05-05 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25554
+
+ Support HTML5 text control input types: email, number, tel, url
+
+ Test: fast/html/text-field-input-types.html
+
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
+ * html/HTMLInputElement.cpp: Use the new types where appropriate.
+ (WebCore::HTMLInputElement::setInputType):
+ (WebCore::HTMLInputElement::type):
+ (WebCore::HTMLInputElement::saveState):
+ (WebCore::HTMLInputElement::restoreState):
+ (WebCore::HTMLInputElement::accessKeyAction):
+ (WebCore::HTMLInputElement::rendererIsNeeded):
+ (WebCore::HTMLInputElement::createRenderer):
+ (WebCore::HTMLInputElement::appendFormData):
+ (WebCore::HTMLInputElement::valueWithDefault):
+ (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * html/HTMLInputElement.h: Ditto.
+ (WebCore::HTMLInputElement::):
+ (WebCore::HTMLInputElement::isTextField):
+
+2009-04-01 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Mouse wheel scrolling and keyboard shortcut support for wx.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24797
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/wx/KeyboardEventWx.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetScrollPosition):
+
+2009-05-05 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix for Windows, add missing include.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24798
+
+ * platform/wx/wxcode/win/non-kerned-drawing.cpp:
+
+2009-05-05 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
+ https://bugs.webkit.org/show_bug.cgi?id=25574
+
+ Enable accessibility hit-testing for image map links.
+ Allow image map links to return AXURLs and AXAccessKey information.
+
+ Test: platform/mac/accessibility/imagemap-hittest.html
+
+ * page/AccessibilityImageMapLink.cpp:
+ (WebCore::AccessibilityImageMapLink::url):
+ * page/AccessibilityImageMapLink.h:
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::minValueForRange):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
+ (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ * page/AccessibilityRenderObject.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2009-05-05 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6552129> Select a quote line and paste elsewhere, you
+ get that line and an extra quoted blank line
+ <rdar://problem/6609308> Triple-click a quoted header line, copy, paste
+ onto an empty line makes an extra quoted line
+
+ - When pasting a blockquote with a newline, make sure we put the newline
+ outside of the blockquote so that it is not quoted.
+
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+
+2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ Call moz_gtk_shutdown on RenderThemeGtk destruction.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::~RenderThemeGtk):
+ * platform/gtk/RenderThemeGtk.h:
+
+2009-05-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Steve Falkenburg.
+
+ <rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"
+
+ * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
+
+2009-05-05 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Brady Eidson.
+
+ Safety-check m_documentLoader before dereferencing. While it seems
+ unlikely this could fail (as Safari 3 shipped without this),
+ technically almost any call can change or reset m_documentLoader.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::receivedFirstData):
+
+2009-05-05 Dan Bernstein <mitz@apple.com>
+
+ - Tiger build fix
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::toCSSIdentifier):
+
+2009-05-05 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25303
+ No need to ref the internal buffer inside the Skia ImageDecoder.
+
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::bitmap):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setRGBA):
+
+2009-05-05 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=24192
+ <rdar://problem/5760774> Replying to a Mail message that contains
+ fixed width text can change the size of the text
+
+ Covered by existing tests: editing/pasteboard/5027857.html
+ editing/pasteboard/paste-pre-002.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
+ Added. If the font-size is keyword-based, returns the keyword value
+ instead of the pixel size.
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If
+ font-family is a generic family, return the generic family instead of
+ the the internal string -webkit-[serif|sans-serif|cursive|fantasy
+ |monospace].
+ (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
+ For the font-size property, prefer a keyword value over a pixel size.
+ * css/CSSComputedStyleDeclaration.h:
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::StyleChange::currentlyHasStyle): For the font-size property,
+ call getFontSizeCSSValuePreferringKeyword().
+ * platform/graphics/FontDescription.h:
+ (WebCore::FontDescription::keywordSize): Changed the return type to
+ unsigned.
+ (WebCore::FontDescription::setKeywordSize): Changed the parameter type
+ to unsigned.
+ (WebCore::FontDescription::m_keywordSize): Changed the type of this
+ 4-bit field to unsigned, because it takes values as high as 8.
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix http/tests/misc/DOMContentLoaded-event.html
+
+ The native call performance improvement removed a few places where we
+ unintentionally performed a toThisObject conversion. This patch updates
+ the bindings codegen to not rely on this bug.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez and Gustavo Noronha.
+
+ Implement WebCore::directoryName for Gtk+.
+
+ * platform/gtk/FileSystemGtk.cpp:
+ (WebCore::directoryName):
+
+2009-05-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Fix mappedAttributes() access without NULL check
+ https://bugs.webkit.org/show_bug.cgi?id=25553
+
+ SVGStyledElement::getPresentationAttribute was using mappedAttributes()
+ without checking for NULL.
+
+ HTMLInputElement::setInputType also doesn't NULL check, but I was not
+ able to get it to crash with a test case so I just added an ASSERT.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setInputType):
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::getPresentationAttribute):
+
+2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Xan Lopez.
+
+ Implement WebCore::imageTitle for Gtk+.
+
+ * platform/gtk/LocalizedStringsGtk.cpp:
+ (WebCore::imageTitle):
+
+2009-05-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Bug 25559: Improve native function call performance
+ <https://bugs.webkit.org/show_bug.cgi?id=25559>
+
+ Add forwarding header necessary for compilation, and fix debugger
+ to correctly account for change in JSFunction behaviour.
+
+ * ForwardingHeaders/jit/JITCode.h: Added.
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+
+2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ Make convertValueToQVariant more robust against null JSValues.
+
+ Don't require the caller to do the null check.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+
+2009-05-05 Eric Seidel <eric@webkit.org>
+
+ No review, just a revert.
+
+ Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.
+
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::mapLocalToContainer):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::mapLocalToContainer):
+
+2009-05-04 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dave Hyatt.
+
+ <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
+
+ The problem was caused by missing <head> element - we used to create it when moving a
+ misplaced <style> element, but we now handle those in place. Other browsers always create
+ a <head> element.
+
+ There is no guarantee that a <head> element always exists - first, it can be removed with
+ removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
+ for manually created ones (e.g. ImageDocument).
+
+ Test: fast/parser/head-element-for-yahoo-player.html
+
+ * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
+ A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
+ code is removed completely.
+
+ * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
+ elements as children of <html>. This isn't directly related to this bug, but it was easier
+ to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
+ Create a <head> it a <body> is created implicitly to contain some other element.
+ (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
+ explicitly present in source.
+ (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
+
+2009-05-04 Jakub Wieczorek <faw217@gmail.com>
+
+ Reviewed by Simon Hausmann.
+
+ As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
+ returns the application/octet-stream mimetype when it can't associate
+ extension with any mimetype, it can happen that the application/octet-stream
+ mimetype will hit the list of supported image formats. For instance,
+ it is possible when QImageReader or QImageWriter support an extension
+ that is not in the extensions map.
+
+ Make sure that this mimetype is not treated as displayable image type.
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedImageMIMETypes):
+ (WebCore::initializeSupportedImageMIMETypesForEncoding):
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ ASSERT(useTransforms) in SVG mapLocalToContainer implementations
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::mapLocalToContainer):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::mapLocalToContainer):
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Remove m_absoluteBounds hack from RenderSVGText
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)
+
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout):
+ * rendering/RenderSVGText.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Remove the vestigial calculateLocalTransform()
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ RenderSVGContainer is now the only render which needs this
+ function, but it no longer returns the unused bool.
+
+ calculateLocalTransform() previously was called by the DOM before
+ transform updates were part of layout().
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::layout):
+ * rendering/RenderForeignObject.h:
+ (WebCore::RenderForeignObject::localTransform):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::layout):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::calculateLocalTransform):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::layout):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSVGTransformableContainer.cpp:
+ (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
+ * rendering/RenderSVGTransformableContainer.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Move more code into SVGRenderBase
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
+ are now all shared via SVGRenderBase.
+
+ RenderForeignObject should also be sharing this code, but I've left it
+ alone for now, as changing that would likely cause test changes.
+
+ No test changes. It's possible that transformed <svg:image> elements will
+ now show up with better metrics in the inspector.
+
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGImage::computeRectForRepaint):
+ (WebCore::RenderSVGImage::mapLocalToContainer):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGModelObject::computeRectForRepaint):
+ (WebCore::RenderSVGModelObject::mapLocalToContainer):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGText::computeRectForRepaint):
+ (WebCore::RenderSVGText::mapLocalToContainer):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::clippedOverflowRectForRepaint):
+ (WebCore::SVGRenderBase::computeRectForRepaint):
+ (WebCore::SVGRenderBase::mapLocalToContainer):
+ * rendering/SVGRenderSupport.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Add SVGRenderBase to share logic between SVG renderers
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ I've added an SVGRenderBase base class which is shared by
+ all of the SVG renders now. This patch is just moving code
+ there are no functional changes in this patch.
+
+ Currently I've left these functions in SVGRenderSupport.h
+ In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*
+
+ clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.
+
+ * rendering/RenderSVGBlock.h:
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGRoot.h:
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderBase::prepareToRenderSVGContent):
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ (WebCore::clampImageBufferSizeToViewport):
+ (WebCore::SVGRenderBase::computeContainerBoundingBox):
+ (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
+ * rendering/SVGRenderSupport.h:
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
+ (WebCore::SVGRootInlineBox::paint):
+ * svg/SVGMaskElement.cpp:
+ (WebCore::SVGMaskElement::drawMaskerContent):
+ * svg/SVGPatternElement.cpp:
+ (WebCore::SVGPatternElement::buildPattern):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::createMaskAndSwapContextForTextGradient):
+ (WebCore::clipToTextMask):
+
+2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Unreviewed SVG build fix.
+
+ Include MappedAttribute.h after r43187.
+
+ * svg/SVGComponentTransferFunctionElement.cpp:
+ * svg/SVGFEBlendElement.cpp:
+ * svg/SVGFEColorMatrixElement.cpp:
+ * svg/SVGFEComponentTransferElement.cpp:
+ * svg/SVGFECompositeElement.cpp:
+ * svg/SVGFEDiffuseLightingElement.cpp:
+ * svg/SVGFEDisplacementMapElement.cpp:
+ * svg/SVGFEGaussianBlurElement.cpp:
+ * svg/SVGFEImageElement.cpp:
+ * svg/SVGFELightElement.cpp:
+ * svg/SVGFEMergeNodeElement.cpp:
+ * svg/SVGFEOffsetElement.cpp:
+ * svg/SVGFESpecularLightingElement.cpp:
+ * svg/SVGFETileElement.cpp:
+ * svg/SVGFETurbulenceElement.cpp:
+ * svg/SVGFilterElement.cpp:
+ * svg/SVGFilterPrimitiveStandardAttributes.cpp:
+
+2009-05-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Sam 'The Belly' Weinig
+
+ <rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only
+
+ In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
+ themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.
+
+ The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
+ the canLoad() check if a codebase was actually set on the applet tag.
+
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
+
+2009-05-04 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * html/HTMLCollection.h:
+ * html/HTMLFormElement.h:
+ Declare CollectionCache as a struct, not a class, to match its
+ definition.
+
+2009-05-04 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin, Oliver Hunt.
+
+ Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
+ https://bugs.webkit.org/show_bug.cgi?id=25557
+
+ Test: accessibility/canvas.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::roleValue):
+
+2009-05-04 Brady Eidson <beidson@apple.com>
+
+ Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.
+
+ * ChangeLog
+
+2009-05-04 Kai Brüning <kai@granus.net>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24883
+ 24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
+
+ Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
+
+ Test: fast/innerHTML/innerHTML-nbsp.xhtml
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::parseXMLDocumentFragment):
+
+2009-05-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
+ and NamedMappedAttrMap.h include of MappedAttribute.h
+ https://bugs.webkit.org/show_bug.cgi?id=24924
+
+ Make compiles faster, and debugging info smaller.
+
+ * GNUmakefile.am: Added new source files.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::toJS): Updated for new collection type names.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createAttribute): Added. No longer inline.
+ (WebCore::Document::images): Updated for new collection type names.
+ (WebCore::Document::applets): Ditto.
+ (WebCore::Document::embeds): Ditto.
+ (WebCore::Document::plugins): Ditto.
+ (WebCore::Document::objects): Ditto.
+ (WebCore::Document::scripts): Ditto.
+ (WebCore::Document::links): Ditto.
+ (WebCore::Document::forms): Ditto.
+ (WebCore::Document::anchors): Ditto.
+ (WebCore::Document::all): Ditto.
+ (WebCore::Document::windowNamedItems): Ditto.
+ (WebCore::Document::documentNamedItems): Ditto.
+ (WebCore::Document::nameCollectionInfo): Ditto.
+
+ * dom/Document.h: Changed around includes and forward declarations.
+ Updated for changes to collection types.
+
+ * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
+
+ * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
+ Contains the class that used to be HTMLCollection::CollectionInfo.
+ * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
+ Ditto.
+
+ * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
+ Has the enum that used to be HTMLCollection::Type.
+
+ * html/HTMLCollection.cpp:
+ (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
+ (WebCore::HTMLCollection::create): Ditto.
+ (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
+ (WebCore::HTMLCollection::itemAfter): Ditto.
+ * html/HTMLCollection.h: Ditto.
+
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::children): Updated for new collection type names.
+ * html/HTMLFormCollection.cpp:
+ (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
+ (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
+ * html/HTMLFormCollection.h: Ditto.
+ * html/HTMLFormElement.h: Ditto.
+ * html/HTMLMapElement.cpp:
+ (WebCore::HTMLMapElement::areas): Ditto.
+ * html/HTMLNameCollection.cpp:
+ (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
+ * html/HTMLNameCollection.h:
+ (WebCore::HTMLNameCollection::create): Ditto.
+ * html/HTMLSelectElement.h:
+ (WebCore::HTMLSelectElement::collectionInfo): Ditto.
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::tBodies):Ditto.
+ * html/HTMLTableRowElement.cpp:
+ (WebCore::HTMLTableRowElement::cells):Ditto.
+ * html/HTMLTableRowsCollection.cpp:
+ (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
+ * html/HTMLTableSectionElement.cpp:
+ (WebCore::HTMLTableSectionElement::rows): Ditto.
+
+ * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
+ * css/CSSStyleSelector.cpp: Ditto.
+ * dom/Element.cpp: Ditto.
+ * dom/InputElement.cpp: Ditto.
+ * dom/NamedAttrMap.cpp: Ditto.
+ * dom/NamedMappedAttrMap.cpp: Ditto.
+ * dom/Node.cpp: Ditto.
+ * dom/StyledElement.cpp: Ditto.
+ * dom/StyledElement.h: Ditto.
+ * editing/ApplyStyleCommand.cpp: Ditto.
+ * editing/DeleteSelectionCommand.cpp: Ditto.
+ * editing/Editor.cpp: Ditto.
+ * editing/EditorCommand.cpp: Ditto.
+ * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
+ * editing/ReplaceSelectionCommand.cpp: Ditto.
+ * editing/markup.cpp: Ditto.
+ * html/CanvasRenderingContext2D.cpp: Ditto.
+ * html/HTMLAnchorElement.cpp: Ditto.
+ * html/HTMLAppletElement.cpp: Ditto.
+ * html/HTMLAreaElement.cpp: Ditto.
+ * html/HTMLBRElement.cpp: Ditto.
+ * html/HTMLBaseElement.cpp: Ditto.
+ * html/HTMLBodyElement.cpp: Ditto.
+ * html/HTMLButtonElement.cpp: Ditto.
+ * html/HTMLCanvasElement.cpp: Ditto.
+ * html/HTMLDivElement.cpp: Ditto.
+ * html/HTMLEmbedElement.cpp: Ditto.
+ * html/HTMLFontElement.cpp: Ditto.
+ * html/HTMLFormControlElement.cpp: Ditto.
+ * html/HTMLFormElement.cpp: Ditto.
+ * html/HTMLFrameElement.cpp: Ditto.
+ * html/HTMLFrameElementBase.cpp: Ditto.
+ * html/HTMLFrameSetElement.cpp: Ditto.
+ * html/HTMLHRElement.cpp: Ditto.
+ * html/HTMLIFrameElement.cpp: Ditto.
+ * html/HTMLImageElement.cpp: Ditto.
+ * html/HTMLInputElement.cpp: Ditto.
+ * html/HTMLIsIndexElement.cpp: Ditto.
+ * html/HTMLKeygenElement.cpp: Ditto.
+ * html/HTMLLIElement.cpp: Ditto.
+ * html/HTMLLinkElement.cpp: Ditto.
+ * html/HTMLMarqueeElement.cpp: Ditto.
+ * html/HTMLMetaElement.cpp: Ditto.
+ * html/HTMLOListElement.cpp: Ditto.
+ * html/HTMLObjectElement.cpp: Ditto.
+ * html/HTMLOptionElement.cpp: Ditto.
+ * html/HTMLParagraphElement.cpp: Ditto.
+ * html/HTMLParamElement.cpp: Ditto.
+ * html/HTMLPlugInElement.cpp: Ditto.
+ * html/HTMLPreElement.cpp: Ditto.
+ * html/HTMLScriptElement.cpp: Ditto.
+ * html/HTMLSelectElement.cpp: Ditto.
+ * html/HTMLStyleElement.cpp: Ditto.
+ * html/HTMLTableCaptionElement.cpp: Ditto.
+ * html/HTMLTableCellElement.cpp: Ditto.
+ * html/HTMLTableColElement.cpp: Ditto.
+ * html/HTMLTablePartElement.cpp: Ditto.
+ * html/HTMLTextAreaElement.cpp: Ditto.
+ * html/HTMLTokenizer.cpp: Ditto.
+ * html/HTMLUListElement.cpp: Ditto.
+ * html/HTMLVideoElement.cpp: Ditto.
+ * html/HTMLViewSourceDocument.cpp: Ditto.
+ * loader/ImageDocument.cpp: Ditto.
+ * page/Frame.cpp: Ditto.
+ * rendering/RenderTreeAsText.cpp: Ditto.
+ * svg/SVGAElement.cpp: Ditto.
+ * svg/SVGAnimateMotionElement.cpp: Ditto.
+ * svg/SVGAnimateTransformElement.cpp: Ditto.
+ * svg/SVGAnimationElement.cpp: Ditto.
+ * svg/SVGCircleElement.cpp: Ditto.
+ * svg/SVGClipPathElement.cpp: Ditto.
+ * svg/SVGCursorElement.cpp: Ditto.
+ * svg/SVGElement.cpp: Ditto.
+ * svg/SVGEllipseElement.cpp: Ditto.
+ * svg/SVGExternalResourcesRequired.cpp: Ditto.
+ * svg/SVGFitToViewBox.cpp: Ditto.
+ * svg/SVGFontFaceElement.cpp: Ditto.
+ * svg/SVGFontFaceUriElement.cpp: Ditto.
+ * svg/SVGForeignObjectElement.cpp: Ditto.
+ * svg/SVGGlyphElement.cpp: Ditto.
+ * svg/SVGGradientElement.cpp: Ditto.
+ * svg/SVGImageElement.cpp: Ditto.
+ * svg/SVGLangSpace.cpp: Ditto.
+ * svg/SVGLineElement.cpp: Ditto.
+ * svg/SVGLinearGradientElement.cpp: Ditto.
+ * svg/SVGMarkerElement.cpp: Ditto.
+ * svg/SVGMaskElement.cpp: Ditto.
+ * svg/SVGPathElement.cpp: Ditto.
+ * svg/SVGPatternElement.cpp: Ditto.
+ * svg/SVGPolyElement.cpp: Ditto.
+ * svg/SVGRadialGradientElement.cpp: Ditto.
+ * svg/SVGRectElement.cpp: Ditto.
+ * svg/SVGSVGElement.cpp: Ditto.
+ * svg/SVGScriptElement.cpp: Ditto.
+ * svg/SVGStopElement.cpp: Ditto.
+ * svg/SVGStyleElement.cpp: Ditto.
+ * svg/SVGStyledElement.cpp: Ditto.
+ * svg/SVGStyledTransformableElement.cpp: Ditto.
+ * svg/SVGTests.cpp: Ditto.
+ * svg/SVGTextContentElement.cpp: Ditto.
+ * svg/SVGTextElement.cpp: Ditto.
+ * svg/SVGTextPathElement.cpp: Ditto.
+ * svg/SVGTextPositioningElement.cpp: Ditto.
+ * svg/SVGURIReference.cpp: Ditto.
+ * svg/SVGUseElement.cpp: Ditto.
+ * svg/SVGViewElement.cpp: Ditto.
+ * svg/animation/SVGSMILElement.cpp: Ditto.
+ * xml/XPathStep.cpp: Ditto.
+
+2009-05-04 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
+ https://bugs.webkit.org/show_bug.cgi?id=25520
+
+ * inspector/front-end/inspector.js:
+ (WebInspector.loaded):
+
+2009-05-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window
+
+ DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
+ particularly sticky behavior.
+
+ If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
+ prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
+ from the WebArchive.
+
+ In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
+ loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.
+
+ When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
+ ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
+ WebResource is returned, and the client thinks the subresource doesn't exist even though it does.
+
+ This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the
+ ArchiveResource.
+
+2009-05-04 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25545
+ Bug 25545: HTMLMediaElement: display anamorphic video correctly
+
+ Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
+ and displayed correctly.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't
+ filled beyond capacity.
+
+2009-05-03 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
+ Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load
+
+ Only the first plug-in in a PluginDocument can use the main resource data. For all
+ subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
+ out for the real Flash plug-in, we need to load the resource data in the same manner
+ as for other embedded plug-ins.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadPlugin):
+
+2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Ariya Hidayat.
+
+ Update the qrc file for the Web Inspector in the Qt build
+ with missing files.
+
+ * inspector/front-end/WebKit.qrc:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderSVGInline.cpp:
+ (WebCore::RenderSVGInline::absoluteRects):
+ (WebCore::RenderSVGInline::absoluteQuads):
+ * rendering/RenderSVGInline.h:
+ * rendering/RenderSVGTSpan.cpp:
+ * rendering/RenderSVGTSpan.h:
+ * rendering/RenderSVGTextPath.cpp:
+ * rendering/RenderSVGTextPath.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Move RenderSVGText off of localToAbsolute()
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Remove broken absoluteTransform() code from RenderSVGInlineText
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ This improved SVG text focus rings.
+ This also improved SVG.getScreenCTM() results.
+
+ SVGSVGElement::getScreenCTM was passing "true" for the second argument in
+ localToAbsolute, which is "fixed" it meant to pass "true" for the
+ third argument (useTransforms). That change alone caused no layout test changes, however
+ before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
+
+ mapLocalToContainer implementations really should be shared,
+ but I'll do that in a later patch.
+
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::styleDidChange):
+ (WebCore::RenderSVGInlineText::absoluteQuads):
+ (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
+ (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::mapLocalToContainer):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::mapLocalToContainer):
+ * rendering/RenderSVGText.h:
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::getScreenCTM):
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Remove dead code from RenderPath
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderPath.cpp:
+ * rendering/RenderPath.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Share layout code between RenderSVGViewportContainer and RenderSVGContainer
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::calcViewport):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::applyViewportClip):
+ * rendering/RenderSVGViewportContainer.h:
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Remove redundant disableLayoutState() calls
+ https://bugs.webkit.org/show_bug.cgi?id=25532
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::layout):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::layout):
+
+2009-05-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Simplify RenderForeignObject::paint and fix a repaint bug.
+ Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
+ https://bugs.webkit.org/show_bug.cgi?id=16939
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::paint):
+
+2009-05-03 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Test: editing/spelling/spellcheck-attribute.html
+
+ Bug 14552: Add a way to disable spell checking for specific element
+ https://bugs.webkit.org/show_bug.cgi?id=14552
+
+ For compatibility with Firefox, this code ascends the DOM tree when an element does
+ not have its "spellcheck" attribute.
+
+ * editing/Editor.cpp:
+ (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
+ attribute of an element before calling a spell checker or a grammar checker.
+ * html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
+
+2009-05-03 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back in one last time (I hope).
+
+2009-05-03 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back out. It still breaks windows.
+
+2009-05-03 Sam Weinig <sam@webkit.org>
+
+ Roll JSC API number marshaling back in.
+
+2009-05-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - another fix for <rdar://problem/6617298> Typing delete on an unquoted
+ blank line unquotes the preceding, quoted blank line
+
+ Test: editing/deleting/type-delete-after-quote-2.html
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize
+ m_startsAtEmptyLine.
+ (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the
+ selection starts at an empty line, do not prevent the merging of blocks.
+ This is what allows the text after the line break to be merged into the
+ block containing the line break. Also set m_startsAtEmptyLine to true.
+ (WebCore::DeleteSelectionCommand::mergeParagraphs): If
+ m_startsAtEmptyLine is true, create a placeholder BR to serve as the
+ merge destination.
+ * editing/DeleteSelectionCommand.h:
+
+2009-05-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Simplified null-ish JSValues.
+
+ Replaced calls to noValue() with calls to JSValue() (which is what
+ noValue() returned). Removed noValue().
+
+ Removed "JSValue()" initialiazers, since default construction happens...
+ by default.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::setDOMException):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::open):
+ (WebCore::JSDOMWindow::showModalDialog):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::handleEvent):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/ScriptValue.h:
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::hasNoValue):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::invokeMethod):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaField::dispatchValueFromInstance):
+ (JavaField::dispatchSetValueToInstance):
+ * bridge/runtime.h:
+ (JSC::Bindings::Instance::invokeConstruct):
+
+2009-05-02 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)
+
+ Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::suspendPostAttachCallbacks):
+ (WebCore::ContainerNode::resumePostAttachCallbacks):
+ (WebCore::ContainerNode::attach):
+ * dom/Element.cpp:
+ (WebCore::Element::attach):
+ * loader/loader.cpp:
+ (WebCore::Loader::Loader):
+ (WebCore::Loader::servePendingRequests):
+ (WebCore::Loader::suspendPendingRequests):
+ (WebCore::Loader::resumePendingRequests):
+ (WebCore::Loader::Host::servePendingRequests):
+ * loader/loader.h:
+ (WebCore::Loader::isSuspendingPendingRequests):
+
+2009-05-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
+ https://bugs.webkit.org/show_bug.cgi?id=25352
+ rdar://problem/6823239
+
+ Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
+
+ * platform/network/HTTPParsers.cpp:
+ (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.
+
+2009-05-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ Bug 25491: WebFrame leak when a subframe removes itself
+ https://bugs.webkit.org/show_bug.cgi?id=25491
+ rdar://problem/6833859
+
+ Test: fast/loading/subframe-removes-itself.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true,
+ treat load as complete, even if isLoadingInAPISense is still returning true.
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Roll out JavaScriptCore API number marshaling.
+
+ * bindings/js/ScriptValue.cpp:
+ (WebCore::ScriptValue::isEqual):
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::getHeadCallback):
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::getChildren):
+ (WebCore::getParent):
+ (WebCore::getHead):
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Fix build.
+
+ * workers/WorkerContext.idl:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Cleanup workers code a bit.
+
+ * bindings/js/JSWorkerContextBase.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSWorkerContextBase.h:
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::customGetOwnPropertySlot):
+ * workers/WorkerContext.h:
+ (WebCore::WorkerContext::toWorkerContext):
+ (WebCore::WorkerContext::self):
+ (WebCore::WorkerContext::setOnmessage):
+ (WebCore::WorkerContext::onmessage):
+ * workers/WorkerContext.idl:
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ A little clean up.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createJavaAppletWidget):
+
+2009-05-01 Sam Weinig <sam@webkit.org>
+
+ Fix the build.
+
+ * bindings/js/ScriptValue.cpp:
+ (WebCore::ScriptValue::isEqual):
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::getHeadCallback):
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::getChildren):
+ (WebCore::getParent):
+ (WebCore::getHead):
+
+2009-05-01 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig
+
+ Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail
+
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
+
+2009-05-01 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber Stamped by Sam Weinig.
+
+ Renamed JSValuePtr => JSValue.
+
+ * bindings/js/JSAttrCustom.cpp:
+ (WebCore::JSAttr::setValue):
+ * bindings/js/JSCDATASectionCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSCSSRuleCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter):
+ (WebCore::JSCSSStyleDeclaration::customPut):
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::toJS):
+ (WebCore::toHTMLCanvasStyle):
+ (WebCore::JSCanvasRenderingContext2D::strokeStyle):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
+ (WebCore::JSCanvasRenderingContext2D::fillStyle):
+ (WebCore::JSCanvasRenderingContext2D::setFillStyle):
+ (WebCore::JSCanvasRenderingContext2D::setFillColor):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
+ (WebCore::JSCanvasRenderingContext2D::strokeRect):
+ (WebCore::JSCanvasRenderingContext2D::drawImage):
+ (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
+ (WebCore::JSCanvasRenderingContext2D::setShadow):
+ (WebCore::JSCanvasRenderingContext2D::createPattern):
+ (WebCore::JSCanvasRenderingContext2D::putImageData):
+ (WebCore::JSCanvasRenderingContext2D::fillText):
+ (WebCore::JSCanvasRenderingContext2D::strokeText):
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore::JSClipboard::types):
+ (WebCore::JSClipboard::clearData):
+ (WebCore::JSClipboard::getData):
+ (WebCore::JSClipboard::setData):
+ (WebCore::JSClipboard::setDragImage):
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::profiles):
+ * bindings/js/JSCoordinatesCustom.cpp:
+ (WebCore::JSCoordinates::altitude):
+ (WebCore::JSCoordinates::altitudeAccuracy):
+ (WebCore::JSCoordinates::heading):
+ (WebCore::JSCoordinates::speed):
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ (WebCore::toVoidCallback):
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::create):
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::hasItem):
+ (WebCore::JSDOMApplicationCache::add):
+ (WebCore::JSDOMApplicationCache::remove):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::jsStringOrNull):
+ (WebCore::jsOwnedStringOrNull):
+ (WebCore::jsStringOrUndefined):
+ (WebCore::jsStringOrFalse):
+ (WebCore::valueToStringWithNullCheck):
+ (WebCore::valueToStringWithUndefinedOrNullCheck):
+ (WebCore::reportException):
+ (WebCore::reportCurrentException):
+ (WebCore::setDOMException):
+ (WebCore::objectToStringFunctionGetter):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::getDOMObjectWrapper):
+ (WebCore::getDOMNodeWrapper):
+ (WebCore::toJS):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMStringListCustom.cpp:
+ (WebCore::JSDOMStringList::getByIndex):
+ (WebCore::JSDOMStringList::item):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::childFrameGetter):
+ (WebCore::JSDOMWindowBase::indexGetter):
+ (WebCore::JSDOMWindowBase::namedItemGetter):
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+ (WebCore::JSDOMWindowBase::put):
+ (WebCore::JSDOMWindowBase::setReturnValueSlot):
+ (WebCore::toJS):
+ (WebCore::toJSDOMWindow):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::lookupGetter):
+ (WebCore::JSDOMWindow::lookupSetter):
+ (WebCore::JSDOMWindow::history):
+ (WebCore::JSDOMWindow::location):
+ (WebCore::JSDOMWindow::setLocation):
+ (WebCore::JSDOMWindow::crypto):
+ (WebCore::JSDOMWindow::event):
+ (WebCore::JSDOMWindow::image):
+ (WebCore::JSDOMWindow::option):
+ (WebCore::JSDOMWindow::audio):
+ (WebCore::JSDOMWindow::webKitPoint):
+ (WebCore::JSDOMWindow::webKitCSSMatrix):
+ (WebCore::JSDOMWindow::xmlHttpRequest):
+ (WebCore::JSDOMWindow::xsltProcessor):
+ (WebCore::JSDOMWindow::messageChannel):
+ (WebCore::JSDOMWindow::worker):
+ (WebCore::createWindow):
+ (WebCore::JSDOMWindow::open):
+ (WebCore::JSDOMWindow::showModalDialog):
+ (WebCore::JSDOMWindow::postMessage):
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ (WebCore::JSDOMWindow::atob):
+ (WebCore::JSDOMWindow::btoa):
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ (WebCore::toDOMWindow):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::nonCachingStaticFunctionGetter):
+ (WebCore::JSDOMWindow::customPut):
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::put):
+ (WebCore::JSDOMWindowShell::putWithAttributes):
+ (WebCore::JSDOMWindowShell::lookupGetter):
+ (WebCore::JSDOMWindowShell::lookupSetter):
+ (WebCore::toJS):
+ * bindings/js/JSDOMWindowShell.h:
+ (WebCore::JSDOMWindowShell::createStructure):
+ * bindings/js/JSDatabaseCustom.cpp:
+ (WebCore::JSDatabase::changeVersion):
+ (WebCore::JSDatabase::transaction):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::location):
+ (WebCore::JSDocument::setLocation):
+ (WebCore::toJS):
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::JSElement::setAttribute):
+ (WebCore::JSElement::setAttributeNode):
+ (WebCore::JSElement::setAttributeNS):
+ (WebCore::JSElement::setAttributeNodeNS):
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSEventCustom.cpp:
+ (WebCore::JSEvent::clipboardData):
+ (WebCore::toJS):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::handleEvent):
+ * bindings/js/JSEventTarget.cpp:
+ (WebCore::toJS):
+ (WebCore::toEventTarget):
+ * bindings/js/JSEventTarget.h:
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions):
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::createStructure):
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ (WebCore::JSHTMLAppletElement::customPut):
+ (WebCore::JSHTMLAppletElement::nameGetter):
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::getNamedItems):
+ (WebCore::callHTMLCollection):
+ (WebCore::JSHTMLCollection::nameGetter):
+ (WebCore::JSHTMLCollection::item):
+ (WebCore::JSHTMLCollection::namedItem):
+ (WebCore::toJS):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::nameGetter):
+ (WebCore::JSHTMLDocument::all):
+ (WebCore::JSHTMLDocument::setAll):
+ (WebCore::JSHTMLDocument::open):
+ (WebCore::JSHTMLDocument::write):
+ (WebCore::JSHTMLDocument::writeln):
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ (WebCore::JSHTMLEmbedElement::customPut):
+ (WebCore::JSHTMLEmbedElement::nameGetter):
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::nameGetter):
+ (WebCore::JSHTMLFormElement::submit):
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ (WebCore::JSHTMLFrameElement::setSrc):
+ (WebCore::JSHTMLFrameElement::setLocation):
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ (WebCore::JSHTMLFrameSetElement::nameGetter):
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ (WebCore::JSHTMLIFrameElement::setSrc):
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::selectionStart):
+ (WebCore::JSHTMLInputElement::setSelectionStart):
+ (WebCore::JSHTMLInputElement::selectionEnd):
+ (WebCore::JSHTMLInputElement::setSelectionEnd):
+ (WebCore::JSHTMLInputElement::setSelectionRange):
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ (WebCore::JSHTMLObjectElement::customPut):
+ (WebCore::JSHTMLObjectElement::nameGetter):
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ (WebCore::JSHTMLOptionsCollection::length):
+ (WebCore::JSHTMLOptionsCollection::setLength):
+ (WebCore::JSHTMLOptionsCollection::indexSetter):
+ (WebCore::JSHTMLOptionsCollection::add):
+ (WebCore::JSHTMLOptionsCollection::remove):
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ (WebCore::JSHTMLSelectElement::remove):
+ (WebCore::selectIndexSetter):
+ (WebCore::JSHTMLSelectElement::indexSetter):
+ * bindings/js/JSHTMLSelectElementCustom.h:
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::nonCachingStaticBackFunctionGetter):
+ (WebCore::nonCachingStaticForwardFunctionGetter):
+ (WebCore::nonCachingStaticGoFunctionGetter):
+ (WebCore::JSHistory::customPut):
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+ (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
+ * bindings/js/JSInspectedObjectWrapper.h:
+ (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap):
+ (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::highlightDOMNode):
+ (WebCore::JSInspectorController::addResourceSourceToFrame):
+ (WebCore::JSInspectorController::addSourceToFrame):
+ (WebCore::JSInspectorController::getResourceDocumentNode):
+ (WebCore::JSInspectorController::search):
+ (WebCore::JSInspectorController::databaseTableNames):
+ (WebCore::JSInspectorController::inspectedWindow):
+ (WebCore::JSInspectorController::setting):
+ (WebCore::JSInspectorController::setSetting):
+ (WebCore::JSInspectorController::wrapCallback):
+ (WebCore::JSInspectorController::currentCallFrame):
+ (WebCore::JSInspectorController::profiles):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate):
+ (WebCore::JSJavaScriptCallFrame::thisObject):
+ (WebCore::JSJavaScriptCallFrame::type):
+ (WebCore::JSJavaScriptCallFrame::scopeChain):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::nonCachingStaticReplaceFunctionGetter):
+ (WebCore::nonCachingStaticReloadFunctionGetter):
+ (WebCore::nonCachingStaticAssignFunctionGetter):
+ (WebCore::JSLocation::customPut):
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::setProtocol):
+ (WebCore::JSLocation::setHost):
+ (WebCore::JSLocation::setHostname):
+ (WebCore::JSLocation::setPort):
+ (WebCore::JSLocation::setPathname):
+ (WebCore::JSLocation::setSearch):
+ (WebCore::JSLocation::setHash):
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::reload):
+ (WebCore::JSLocation::assign):
+ (WebCore::JSLocation::toString):
+ (WebCore::JSLocationPrototype::customPut):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ (WebCore::JSMimeTypeArray::nameGetter):
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ (WebCore::JSNamedNodeMap::nameGetter):
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::lengthGetter):
+ (WebCore::JSNamedNodesCollection::indexGetter):
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createStructure):
+ * bindings/js/JSNavigatorCustom.cpp:
+ (WebCore::needsYouTubeQuirk):
+ (WebCore::JSNavigator::appVersion):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::insertBefore):
+ (WebCore::JSNode::replaceChild):
+ (WebCore::JSNode::removeChild):
+ (WebCore::JSNode::appendChild):
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ (WebCore::createWrapper):
+ (WebCore::toJSNewlyCreated):
+ (WebCore::toJS):
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/JSNodeFilterCondition.h:
+ (WebCore::JSNodeFilterCondition::create):
+ * bindings/js/JSNodeFilterCustom.cpp:
+ (WebCore::JSNodeFilter::acceptNode):
+ (WebCore::toNodeFilter):
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ (WebCore::JSNodeIterator::nextNode):
+ (WebCore::JSNodeIterator::previousNode):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::callNodeList):
+ (WebCore::JSNodeList::nameGetter):
+ * bindings/js/JSPluginArrayCustom.cpp:
+ (WebCore::JSPluginArray::nameGetter):
+ * bindings/js/JSPluginCustom.cpp:
+ (WebCore::JSPlugin::nameGetter):
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::runtimeObjectGetter):
+ (WebCore::runtimeObjectPropertyGetter):
+ (WebCore::runtimeObjectCustomPut):
+ (WebCore::callPlugin):
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::asWrapper):
+ (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
+ (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
+ (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
+ (WebCore::JSQuarantinedObjectWrapper::put):
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ (WebCore::JSQuarantinedObjectWrapper::hasInstance):
+ (WebCore::JSQuarantinedObjectWrapper::call):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::createStructure):
+ * bindings/js/JSRGBColor.cpp:
+ (WebCore::getJSRGBColor):
+ (jsRGBColorRed):
+ (jsRGBColorGreen):
+ (jsRGBColorBlue):
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::createStructure):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ (WebCore::toJS):
+ * bindings/js/JSSVGLengthCustom.cpp:
+ (WebCore::JSSVGLength::value):
+ (WebCore::JSSVGLength::convertToSpecifiedUnits):
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ (WebCore::JSSVGMatrix::inverse):
+ (WebCore::JSSVGMatrix::rotateFromVector):
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ (WebCore::JSSVGPathSegList::clear):
+ (WebCore::JSSVGPathSegList::initialize):
+ (WebCore::JSSVGPathSegList::getItem):
+ (WebCore::JSSVGPathSegList::insertItemBefore):
+ (WebCore::JSSVGPathSegList::replaceItem):
+ (WebCore::JSSVGPathSegList::removeItem):
+ (WebCore::JSSVGPathSegList::appendItem):
+ * bindings/js/JSSVGPointListCustom.cpp:
+ (WebCore::finishGetter):
+ (WebCore::finishSetter):
+ (WebCore::finishSetterReadOnlyResult):
+ (WebCore::JSSVGPointList::clear):
+ (WebCore::JSSVGPointList::initialize):
+ (WebCore::JSSVGPointList::getItem):
+ (WebCore::JSSVGPointList::insertItemBefore):
+ (WebCore::JSSVGPointList::replaceItem):
+ (WebCore::JSSVGPointList::removeItem):
+ (WebCore::JSSVGPointList::appendItem):
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ (WebCore::finishGetter):
+ (WebCore::finishSetter):
+ (WebCore::finishSetterReadOnlyResult):
+ (WebCore::JSSVGTransformList::clear):
+ (WebCore::JSSVGTransformList::initialize):
+ (WebCore::JSSVGTransformList::getItem):
+ (WebCore::JSSVGTransformList::insertItemBefore):
+ (WebCore::JSSVGTransformList::replaceItem):
+ (WebCore::JSSVGTransformList::removeItem):
+ (WebCore::JSSVGTransformList::appendItem):
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::nameGetter):
+ (WebCore::JSStorage::deleteProperty):
+ (WebCore::JSStorage::customPut):
+ * bindings/js/JSStyleSheetCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ (WebCore::JSStyleSheetList::nameGetter):
+ * bindings/js/JSTextCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ (WebCore::JSTreeWalker::parentNode):
+ (WebCore::JSTreeWalker::firstChild):
+ (WebCore::JSTreeWalker::lastChild):
+ (WebCore::JSTreeWalker::nextSibling):
+ (WebCore::JSTreeWalker::previousSibling):
+ (WebCore::JSTreeWalker::previousNode):
+ (WebCore::JSTreeWalker::nextNode):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::self):
+ (WebCore::JSWorkerContext::setSelf):
+ (WebCore::JSWorkerContext::xmlHttpRequest):
+ (WebCore::JSWorkerContext::importScripts):
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ (WebCore::JSWorkerContext::setTimeout):
+ (WebCore::JSWorkerContext::setInterval):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::open):
+ (WebCore::JSXMLHttpRequest::setRequestHeader):
+ (WebCore::JSXMLHttpRequest::send):
+ (WebCore::JSXMLHttpRequest::getResponseHeader):
+ (WebCore::JSXMLHttpRequest::overrideMimeType):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ (WebCore::JSXMLHttpRequest::responseText):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ (WebCore::JSXSLTProcessor::importStylesheet):
+ (WebCore::JSXSLTProcessor::transformToFragment):
+ (WebCore::JSXSLTProcessor::transformToDocument):
+ (WebCore::JSXSLTProcessor::setParameter):
+ (WebCore::JSXSLTProcessor::getParameter):
+ (WebCore::JSXSLTProcessor::removeParameter):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::create):
+ (WebCore::ScheduledAction::ScheduledAction):
+ (WebCore::ScheduledAction::executeFunctionInContext):
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptCallStack.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::jsObjectForPluginElement):
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::appendArgument):
+ (WebCore::ScriptFunctionCall::call):
+ (WebCore::ScriptFunctionCall::construct):
+ * bindings/js/ScriptFunctionCall.h:
+ * bindings/js/ScriptObject.cpp:
+ (WebCore::ScriptGlobalObject::get):
+ * bindings/js/ScriptValue.h:
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::jsValue):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ (-[WebScriptObject evaluateWebScript:]):
+ (-[WebScriptObject valueForKey:]):
+ (-[WebScriptObject webScriptValueAtIndex:]):
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+ * bindings/objc/WebScriptObjectPrivate.h:
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Evaluate):
+ (_NPN_GetProperty):
+ (_NPN_HasMethod):
+ (_NPN_Construct):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::invokeMethod):
+ (JSC::Bindings::CInstance::invokeDefaultMethod):
+ (JSC::Bindings::CInstance::invokeConstruct):
+ (JSC::Bindings::CInstance::defaultValue):
+ (JSC::Bindings::CInstance::stringValue):
+ (JSC::Bindings::CInstance::numberValue):
+ (JSC::Bindings::CInstance::booleanValue):
+ (JSC::Bindings::CInstance::valueOf):
+ * bridge/c/c_instance.h:
+ * bridge/c/c_runtime.cpp:
+ (JSC::Bindings::CField::valueFromInstance):
+ (JSC::Bindings::CField::setValueToInstance):
+ * bridge/c/c_runtime.h:
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertValueToNPVariant):
+ (JSC::Bindings::convertNPVariantToValue):
+ * bridge/c/c_utility.h:
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::stringValue):
+ (JavaInstance::numberValue):
+ (JavaInstance::booleanValue):
+ (JavaInstance::invokeMethod):
+ (JavaInstance::defaultValue):
+ (JavaInstance::valueOf):
+ * bridge/jni/jni_instance.h:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::eval):
+ (JavaJSObject::getMember):
+ (JavaJSObject::getSlot):
+ (JavaJSObject::convertValueToJObject):
+ (JavaJSObject::convertJObjectToValue):
+ * bridge/jni/jni_objc.mm:
+ (JSC::Bindings::dispatchJNICall):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaArray::convertJObjectToArray):
+ (JavaField::dispatchValueFromInstance):
+ (JavaField::valueFromInstance):
+ (JavaField::dispatchSetValueToInstance):
+ (JavaField::setValueToInstance):
+ (JavaArray::setValueAt):
+ (JavaArray::valueAt):
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ (JSC::Bindings::convertArrayInstanceToJavaArray):
+ (JSC::Bindings::convertValueToJValue):
+ * bridge/jni/jni_utility.h:
+ * bridge/objc/WebScriptObject.h:
+ * bridge/objc/objc_class.h:
+ * bridge/objc/objc_class.mm:
+ (JSC::Bindings::ObjcClass::fallbackObject):
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::invokeMethod):
+ (ObjcInstance::invokeDefaultMethod):
+ (ObjcInstance::setValueOfUndefinedField):
+ (ObjcInstance::getValueOfUndefinedField):
+ (ObjcInstance::defaultValue):
+ (ObjcInstance::stringValue):
+ (ObjcInstance::numberValue):
+ (ObjcInstance::booleanValue):
+ (ObjcInstance::valueOf):
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcField::valueFromInstance):
+ (JSC::Bindings::convertValueToObjcObject):
+ (JSC::Bindings::ObjcField::setValueToInstance):
+ (JSC::Bindings::ObjcArray::setValueAt):
+ (JSC::Bindings::ObjcArray::valueAt):
+ (JSC::Bindings::ObjcFallbackObjectImp::put):
+ (JSC::Bindings::callObjCFallbackObject):
+ (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ (JSC::Bindings::convertValueToObjcValue):
+ (JSC::Bindings::convertNSStringToString):
+ (JSC::Bindings::convertObjcValueToValue):
+ * bridge/runtime.h:
+ (JSC::Bindings::Class::fallbackObject):
+ (JSC::Bindings::Instance::setValueOfUndefinedField):
+ (JSC::Bindings::Instance::invokeDefaultMethod):
+ (JSC::Bindings::Instance::invokeConstruct):
+ (JSC::Bindings::Instance::put):
+ * bridge/runtime_array.cpp:
+ (JSC::RuntimeArray::lengthGetter):
+ (JSC::RuntimeArray::indexGetter):
+ (JSC::RuntimeArray::put):
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::createStructure):
+ * bridge/runtime_method.cpp:
+ (JSC::RuntimeMethod::lengthGetter):
+ (JSC::callRuntimeMethod):
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createStructure):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::fallbackObjectGetter):
+ (JSC::RuntimeObjectImp::fieldGetter):
+ (JSC::RuntimeObjectImp::methodGetter):
+ (JSC::RuntimeObjectImp::put):
+ (JSC::RuntimeObjectImp::defaultValue):
+ (JSC::callRuntimeObject):
+ (JSC::callRuntimeConstructor):
+ * bridge/runtime_object.h:
+ (JSC::RuntimeObjectImp::createStructure):
+ * inspector/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::evaluate):
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::toJS):
+ * inspector/JavaScriptProfile.h:
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::toJS):
+ * inspector/JavaScriptProfileNode.h:
+
+2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25485
+ Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
+ which broke Chromium build.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to
+ provide separate code paths for Qt and non-Qt ports. Also restored original
+ order of execution.
+
+2009-05-01 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6839222>
+ CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader
+
+ After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
+ return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
+ which is why I've added the ASSERT.
+
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::didCancel):
+
+2009-05-01 Timothy Hatcher <timothy@apple.com>
+
+ Disallow the deletion UI for elements that have any overflow clipping.
+ Also disallow the UI for the body element it isn't practical to delete,
+ and the deletion UI would be clipped.
+
+ <rdar://problem/6840161> Deletion UI can be clipped by some
+ elements (with overflow: hidden)
+
+ Reviewed by Darin Adler.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+
+2009-05-01 Timothy Hatcher <timothy@apple.com>
+
+ Decrease the minimum height for deleteable elements to 16px, and increase the
+ minimum width to 48px. This allows deleting shorter items like navigation bars.
+
+ <rdar://problem/6840735> Deletion UI does not show up for short
+ elements (22px or less)
+
+ Reviewed by Adele Peterson.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+
+2009-05-01 Timothy Hatcher <timothy@apple.com>
+
+ Clean up the comments and logic in the code for picking a
+ deleteable element for the deletion UI.
+
+ Reviewed by Adele Peterson.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+
+2009-05-01 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Adele Peterson and Darin Adler.
+
+ <rdar://problem/4815598> Stuck in double spacing mode after pasting a
+ paragraph with padding/margin (or table mode !)
+
+ A lot of the issues in this bug were resolved on Mail's side by using
+ WebKit to convert to plain text. This is the final issue, that floating
+ style stays on copied nodes causing them to float when they are pasted
+ which is not what the user intended.
+
+ * editing/markup.cpp:
+ (WebCore::removeExteriorStyles):
+ (WebCore::):
+ (WebCore::appendStartMarkup):
+ (WebCore::getStartMarkup):
+ (WebCore::createMarkup):
+
+2009-05-01 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
+ This is the only resource-related information that is available in InspectorController
+ and is missing in the FrameLoaderClient.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25347
+
+ * WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
+ * dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
+ (WebCore::Document::resourceRetrievedByXMLHttpRequest):
+ * loader/EmptyClients.h: Added stub implementation.
+ (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
+ * loader/FrameLoader.cpp: Call initiating dispatches.
+ (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+
+2009-04-30 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
+ To Do's in a Mail note (excessive recursion in mouse drag tracking)
+
+ Oliver's recent change to dragging seems to have revealed a long-
+ time bug in passSubframeEventToSubframe where we did not set
+ m_sendingEventToSubview to true before calling
+ handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
+ that and adds ASSERTions around all of the places where
+ m_sendingEventToSubview is set to true and then false to make sure
+ we are not trampling its state.
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::eventLoopHandleMouseDragged):
+ (WebCore::EventHandler::eventLoopHandleMouseUp):
+ (WebCore::EventHandler::passSubframeEventToSubframe):
+ (WebCore::EventHandler::passWheelEventToWidget):
+
+2009-04-30 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ MediaDocument falls back to plug-in unnecessarily
+ https://bugs.webkit.org/show_bug.cgi?id=25504
+ <rdar://problem/6844702>
+
+ Don't allow harmless media types to cause a MediaDocument to fall
+ back to PluginDocument.
+
+ Test: media/video-document-types.html
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64,
+ odsm, and sdsm to allowed track types.
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::disableUnsupportedTracks): Ditto.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add CHROMIUM guard to unfork Document.cpp
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode): Added guard.
+
+2009-04-30 David Kilzer <ddkilzer@apple.com>
+
+ Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
+
+ Reviewed by Geoff Garen.
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
+ * html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
+
+2009-04-30 David Kilzer <ddkilzer@apple.com>
+
+ Provide a mechanism to create a quirks delegate for HTMLParser
+
+ Reviewed by David Hyatt.
+
+ No tests since there is no change in behavior.
+
+ HTMLParserQuirks.h defines an abstract base class that may be
+ extended as needed. The ChromeClient::createHTMLParserQuirks()
+ factory method should be used to return an HTMLParserQuirks
+ subclassed object when needed.
+
+ * WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
+ using ChromeClient::createHTMLParserQuirks().
+ (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
+ set.
+ (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
+ m_parserQuirks is set.
+ (WebCore::HTMLParser::insertNode): Call
+ HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
+ and return early if it returns false.
+ (WebCore::HTMLParser::popBlock): Call
+ HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
+ return early if it returns false.
+ * html/HTMLParser.h: Added m_parserQuirks.
+ * html/HTMLParserQuirks.h: Added.
+ (WebCore::HTMLParserQuirks::HTMLParserQuirks):
+ (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::createHTMLParserQuirks): Added.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25492
+ Add JSC guards around node wrapper cache calls. These are not used by V8.
+
+ Also, remove JSDOMBinding include, which is brought in by ScriptController.
+
+ * dom/Document.cpp:
+ (WebCore::Document::~Document): Added JSC guard.
+ * dom/Node.cpp:
+ (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25493
+ Remove debugger/profiler custom method stubs, catching V8 bindings up to
+ http://trac.webkit.org/changeset/43072.
+
+ * bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
+
+2009-04-30 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
+
+ Use transform-aware quad methods when computing the boundingBoxRect for
+ an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
+
+ Test: accessibility/transformed-element.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, Chromium build fix.
+
+ Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
+
+ * bindings/v8/ScriptObject.cpp:
+ (WebCore::ScriptGlobalObject::get): Renamed from getObject.
+ (WebCore::ScriptGlobalObject::remove): Added.
+ * bindings/v8/ScriptObject.h: Ditto.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25470
+ Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
+
+ * WebCore.pro: Fix copy-paste error.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25470
+ Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
+
+ * GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
+ * WebCore.pro: Ditto.
+
+2009-04-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Change Position to pre-compute the AnchorType and store it.
+ Also store a "legacy editing mode" bit on the Position.
+ https://bugs.webkit.org/show_bug.cgi?id=24763
+
+ The old Postion(node, offset) constructor creates legacy positions
+ but there are new constructors to create explicitly anchored positions
+ which the next patch will use.
+
+ Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
+ only affect legacy positions, we will be able to distinguish
+ between [table, 1] and [table, after] in the code correctly!
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Position.cpp:
+ (WebCore::Position::Position):
+ (WebCore::Position::moveToPosition):
+ (WebCore::Position::moveToOffset):
+ (WebCore::Position::anchorTypeForLegacyEditingPosition):
+ (WebCore::Position::element):
+ * dom/Position.h:
+ (WebCore::Position::):
+ (WebCore::Position::Position):
+ (WebCore::Position::anchorType):
+ (WebCore::Position::deprecatedEditingOffset):
+
+2009-04-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
+ collected even if the WorkerContext is still alive.
+
+ Test: fast/workers/worker-context-gc.html
+
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::mark):
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::WorkerContext):
+ (WebCore::WorkerContext::completeURL):
+ (WebCore::WorkerContext::location):
+ * workers/WorkerContext.h:
+ (WebCore::WorkerContext::optionalNavigator):
+ (WebCore::WorkerContext::optionalLocation):
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25470
+ Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
+
+ * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
+ * WebCore.vcproj/build-generated-files.sh: Ditto.
+ * bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
+ * bindings/js/JSDOMWindowBase.cpp: Ditto.
+ * bindings/js/JSInspectorControllerCustom.cpp: Ditto.
+ * inspector/InspectorController.cpp: Moved profiler/debugger methods under
+ ENABLE(JAVASCRIPT_DEBUGGER) flag.
+ * inspector/InspectorController.h: Ditto.
+ * inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
+ * page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
+
+2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25275
+ This patch snuck in a re-definition of a local.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
+
+2009-04-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix a leak introduced yesterday. Don't allocate a ScheduledAction
+ if the toString()ing throws an exception.
+
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::create):
+
+2009-04-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25379
+ <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
+
+ Test: fast/forms/multiple-selected-options-innerHTML.html
+
+ This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
+ For normal HTML parsing, it is called immediately after an element is inserted, but for
+ innerHTML, it is only called after the whole subtree is inserted into a document.
+
+ It may make sense to harmonize these cases one day, but for now, I only made the minimal
+ changes necessary to fix the bug.
+
+ * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
+ * html/HTMLSelectElement.h:
+ Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
+ which one to keep selected themselves, because their logic assumes normal parsing, with
+ insertedIntoTree() called after each element is inserted.
+
+2009-04-30 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25342
+ Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
+
+ Chromium async/out-of-process version of WebInspector is currently not based on
+ InspectorController. The reason was that we did not want to interfere with
+ the unforking effort, yet wanted to experiment. So we came up with these
+ agents concept that basically mimic InspectorController, but separating 'agent'
+ nature from the 'transport'. Now that InspectorController is unforked, I am
+ planning to bring these concepts into the WebKit land and use what we have in
+ Chromium as a proof of concept / experimental playground.
+
+ * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
+ (WebCore::EmptyChromeClient::addMessageToConsole): ditto
+ * page/ChromeClient.h: ditto
+ * page/Console.cpp: Used new method signature.
+ (WebCore::Console::addMessage): ditto
+
+2009-04-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=25476
+ <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
+ animation is jittery
+
+ Reverted r42987.
+
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw):
+
+2009-04-30 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Maciej Stachowiak
+
+ <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
+ https://bugs.webkit.org/show_bug.cgi?id=21193
+
+ Some websites use for attributes in script elements to specify events that the script
+ should be run for. One example is greekembassy.org which has the following in their <head>:
+
+ <script for=window event=onresize>
+ location.reload(false);
+ </script>
+
+ Since we don't support the full for attribute syntax, we would just blissfully ignore the
+ condition and execute the code unconditionally. This caused breakage on multiple real-world
+ sites besides greekembassy.org.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
+ support for the for attribute in scripts. In the meantime it's best to not execute them
+ unconditionally.
+
+ Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
+ passed, only return true if there is no for attribute in the script element.
+ * dom/ScriptElement.h:
+
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
+ * html/HTMLScriptElement.h:
+
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
+ attribute getters do for SVGScriptElement)
+ * svg/SVGScriptElement.h:
+
+2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again
+
+ https://bugs.webkit.org/show_bug.cgi?id=20952
+
+ The QtWebKit port made the mistake of exposing a global history. This broke
+ with the addition of PageGroup and LinkHash. This needs to be repaired
+ for Qt4.5.
+
+ Add a function to LinkHash.cpp that is resolving a URL. Use this
+ function from within CSSStyleSelector to forward the url to the
+ QWebHistoryInterface API.
+
+ It is sad that there is a path within visitedLinkHash which is now
+ doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
+ and using QtWebKit types within WebCore is a layering violation as well.
+
+ PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
+ Qt4.6 a second version of the QWebHistoryInterface is going to be
+ added which will fix things up.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
+ * platform/LinkHash.cpp:
+ (WebCore::visitedURL):
+ (WebCore::visitedLinkHash):
+ * platform/LinkHash.h:
+
+2009-04-30 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ * platform/graphics/SimpleFontData.cpp: Don't use initCharWidths() for the Qt build.
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit): Instead initialize the average and
+ max char widths from QFontMetrics.
+
+2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Unreview build fix after r43037.
+
+ Use MarkedArgumentBuffer instead of ArgList.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtConnectionObject::execute):
+
+2009-04-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
+ setTimeout should stringify non-string/non-function first arguments
+
+ Test: fast/dom/Window/setTimeout-string-argument.html
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::setTimeout):
+ (WebCore::JSWorkerContext::setInterval):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::create):
+ * bindings/js/ScheduledAction.h:
+
+2009-04-29 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ - WebCore part of <rdar://problem/6609509> Select All and then Delete
+ should put Mail editing back into the same state as a new message
+
+ Test: editing/deleting/in-visibly-empty-root.html
+
+ * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
+ * editing/SelectionController.h:
+ (WebCore::SelectionController::isAll): Added. Calls through to
+ VisibleSelection.
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
+ of the root editable element the selection is in, other than a
+ placeholder. Returns true iff it did anything.
+ (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
+ visible position in the root editable element, but it has children other
+ than a placeholder, remove those children.
+ * editing/TypingCommand.h:
+ * editing/VisiblePosition.h:
+ Added a StayInEditableContent enum and a FIXME.
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::isAll): Added. Returns whether the
+ selection encompasses all visible positions, either in the document or
+ in the editable root.
+ * editing/VisibleSelection.h:
+
+2009-04-29 Sam Weinig <sam@webkit.org>
+
+ Fix style nit.
+
+ * editing/visible_units.cpp:
+ (WebCore::getLeafBoxesInLogicalOrder):
+
+2009-04-29 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
+ trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
+ assertions.
+
+ Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
+ and not do it (which is basically what was happening before).
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setContentsSize):
+ (WebCore::FrameView::needsLayout):
+
+2009-04-29 Douglas Davidson <ddavidso@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
+
+ Updates to the text checking code to enable text checking even if spellchecking is turned off
+ and fix an off-by-one error in selection handling.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
+ (WebCore::Editor::markMisspellingsAndBadGrammar):
+ * editing/Editor.h:
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::markMisspellingsAfterTyping):
+
+2009-04-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Clean up ArgList to be a trivial type
+
+ Start using MarkedArgumentBuffer to create argument lists for function calls
+
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore::JSClipboard::types):
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::profiles):
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::handleEvent):
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::profiles):
+ (WebCore::JSInspectorController::search):
+ (WebCore::JSInspectorController::databaseTableNames):
+ (WebCore::JSInspectorController::setting):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::scopeChain):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ (WebCore::JSQuarantinedObjectWrapper::call):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::ScheduledAction):
+ (WebCore::ScheduledAction::executeFunctionInContext):
+ * bindings/js/ScriptFunctionCall.h:
+ * bindings/objc/WebScriptObject.mm:
+ (getListFromNSArray):
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ * bridge/NP_jsobject.cpp:
+ (getListFromVariantArgs):
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Construct):
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::getListFromJArray):
+
+2009-04-29 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Fix m_offset uses added while I wasn't looking.
+
+ * editing/visible_units.cpp:
+ (WebCore::logicalStartPositionForLine):
+ (WebCore::logicalEndPositionForLine):
+
+2009-04-29 Xiaomei Ji <xji@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=24168
+ RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
+
+ Test: editing/selection/home-end.html
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
+ to logicalEndOfLine() when granularity is LineBoundary.
+ (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
+ to logicalEndOfLine() when granularity is LineBoundary
+ (WebCore::SelectionController::modifyExtendingBackward): Change calling
+ startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
+ (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
+ to logicalStartOfLine() when granularity is LineBoundary.
+ * editing/visible_units.cpp:
+ (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
+ (WebCore::getLogicalStartBoxAndNode): Added.
+ (WebCore::getLogicalEndBoxAndNode): Added.
+ (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
+ (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
+ (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
+ (WebCore::inSameLogicalLine): Added.
+ (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
+ * editing/visible_units.h:
+
+2009-04-29 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Make m_offset private and change all callers to use deprecatedEditingOffset().
+ https://bugs.webkit.org/show_bug.cgi?id=25472
+
+ Per Darin's suggestion, this was just a simple search replace
+ of .m_offset with .deprecatedEditingOffset().
+
+ There was one change in InsertParagraphSeparatorCommand::doApply to use
+ Position::moveToOffset(0) instead of .m_offset = 0;
+
+ * dom/Position.cpp:
+ (WebCore::Position::rendersInDifferentPosition):
+ (WebCore::Position::leadingWhitespacePosition):
+ * dom/Position.h:
+ (WebCore::Position::deprecatedEditingOffset):
+ (WebCore::Position::moveToOffset):
+ (WebCore::operator==):
+ * dom/PositionIterator.h:
+ (WebCore::PositionIterator::PositionIterator):
+ * dom/Range.cpp:
+ (WebCore::Range::create):
+ (WebCore::Range::compareBoundaryPoints):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
+ (WebCore::ApplyStyleCommand::removeInlineStyle):
+ (WebCore::ApplyStyleCommand::nodeFullySelected):
+ (WebCore::ApplyStyleCommand::nodeFullyUnselected):
+ (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
+ (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
+ (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
+ (WebCore::ApplyStyleCommand::joinChildTextNodes):
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::insertNodeAt):
+ (WebCore::CompositeEditCommand::positionOutsideTabSpan):
+ (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
+ (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
+ (WebCore::CompositeEditCommand::deleteInsignificantText):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::updatePositionForNodeRemoval):
+ (WebCore::updatePositionForTextRemoval):
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+ (WebCore::DeleteSelectionCommand::fixupWhitespace):
+ * editing/Editor.cpp:
+ (WebCore::Editor::setComposition):
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::Editor::getCompositionSelection):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::performTrivialReplace):
+ (WebCore::InsertTextCommand::input):
+ (WebCore::InsertTextCommand::insertTab):
+ * editing/MoveSelectionCommand.cpp:
+ (WebCore::MoveSelectionCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::debugRenderer):
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::rangeFromLocationAndLength):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::characterAfter):
+ (WebCore::VisiblePosition::debugPosition):
+ (WebCore::makeRange):
+ (WebCore::setStart):
+ (WebCore::setEnd):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::toNormalizedRange):
+ (WebCore::makeSearchRange):
+ (WebCore::VisibleSelection::debugPosition):
+ (WebCore::VisibleSelection::showTreeForThis):
+ * editing/htmlediting.cpp:
+ (WebCore::comparePositions):
+ (WebCore::rangeCompliantEquivalent):
+ * editing/visible_units.cpp:
+ (WebCore::previousBoundary):
+ (WebCore::nextBoundary):
+ (WebCore::startPositionForLine):
+ (WebCore::startOfLine):
+ (WebCore::endPositionForLine):
+ (WebCore::nextLinePosition):
+ (WebCore::startOfParagraph):
+ (WebCore::endOfParagraph):
+ (WebCore::logicalStartPositionForLine):
+ (WebCore::logicalEndPositionForLine):
+ * page/AccessibilityObject.cpp:
+ (WebCore::updateAXLineStartForVisiblePosition):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::anchorOffset):
+ (WebCore::DOMSelection::focusOffset):
+ (WebCore::DOMSelection::baseOffset):
+ (WebCore::DOMSelection::extentOffset):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionLayoutChanged):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (textMarkerForVisiblePosition):
+ (visiblePositionForTextMarker):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::indexForVisiblePosition):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeSelection):
+
+2009-04-29 Eric Seidel <eric@webkit.org>
+
+ No review, rolling out a patch.
+
+ Revert http://trac.webkit.org/changeset/43019
+
+ New tests failed because I removed the tabs from them
+ when landing (since we avoid tabs in WebKit files).
+ I couldn't tell if the new results were correct with
+ spaces or not.
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::modifyExtendingForward):
+ (WebCore::SelectionController::modifyMovingForward):
+ (WebCore::SelectionController::modifyExtendingBackward):
+ (WebCore::SelectionController::modifyMovingBackward):
+ * editing/visible_units.cpp:
+ * editing/visible_units.h:
+
+2009-04-29 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
+ when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
+ flag on Mac.
+
+ FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
+ from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView):
+ (WebCore::FrameView::setContentsSize):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::needsLayout):
+ (WebCore::FrameView::setNeedsLayout):
+ * page/FrameView.h:
+
+2009-04-29 Eric Seidel <eric@webkit.org>
+
+ No review, rolling out a patch.
+
+ Revert 43020 as it caused accessibility/lists.html to fail
+ and no one is around to tell me if it's a progression or not.
+
+ * page/AccessibilityObject.h:
+ (WebCore::):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::roleValue):
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (RoleEntry::):
+
+2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
+
+ Reviewed by Jon Honeycutt.
+
+ Add a new accessibility role for list items. Part of
+ http://bugs.webkit.org/show_id.cgi?id=20013
+
+ Tests: platform/win/accessibility/listitem-role.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::): Add ListItemRole to accessibilityRole enum.
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::roleValue):Return
+ listItemRole when rendered object is a list item.
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute): Return
+ true for ListItemRole, matching firefox.
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (RoleEntry::): Map ListItemRole with NSAccessibilityGroupRole in
+ MAC.
+
+2009-04-29 Xiaomei Ji <xji@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=24168
+ RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
+
+ Test: editing/selection/home-end.html
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
+ to logicalEndOfLine() when granularity is LineBoundary.
+ (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
+ to logicalEndOfLine() when granularity is LineBoundary
+ (WebCore::SelectionController::modifyExtendingBackward): Change calling
+ startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
+ (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
+ to logicalStartOfLine() when granularity is LineBoundary.
+ * editing/visible_units.cpp:
+ (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
+ (WebCore::getLogicalStartBoxAndNode): Added.
+ (WebCore::getLogicalEndBoxAndNode): Added.
+ (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
+ (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
+ (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
+ (WebCore::inSameLogicalLine): Added.
+ (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
+ * editing/visible_units.h:
+
+2009-04-29 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Eric Seidel.
+
+ Update location while page is loading.
+ https://bugs.webkit.org/show_bug.cgi?id=21597
+
+ Tested by:
+ - fast/dom/location-new-window-no-crash
+ - fast/dom/Window/window-open-pending-url
+
+ * page/Location.cpp:
+
+2009-04-29 Feng Qian <feng@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add Android port files to WebCore/platform.
+ https://bugs.webkit.org/show_bug.cgi?id=23296
+
+ * platform/android: Added.
+ * platform/android/ClipboardAndroid.cpp: Added.
+ * platform/android/ClipboardAndroid.h: Added.
+
+2009-04-29 Feng Qian <feng@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add Android-specific files to the WebCore/page directory.
+ https://bugs.webkit.org/show_bug.cgi?id=23295
+
+ * page/android: Added.
+ * page/android/DragControllerAndroid.cpp: Added.
+ * page/android/EventHandlerAndroid.cpp: Added.
+ * page/android/InspectorControllerAndroid.cpp: Added.
+
+2009-04-29 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Extract PageGroupLoadDeferrer from Chrome.cpp
+
+ * GNUmakefile.am: added PageGroupLoadDeferrer
+ * WebCore.pro: ditto
+ * WebCore.scons: ditto
+ * WebCore.vcproj/WebCore.vcproj: ditto
+ * WebCore.xcodeproj/project.pbxproj: ditto
+ * WebCoreSources.bkl: ditto
+ * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
+ * page/PageGroupLoadDeferrer.cpp: Added.
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+ * page/PageGroupLoadDeferrer.h: Added.
+
+2009-04-24 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Make textarea and text input metrics more closely match IEs.
+
+ This involves:
+ -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
+ -set textarea width to cols*avgCharWidth
+ -Make default CSS match IEs
+ -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
+
+ Those values for textarea and inputs were derived by doing a ton of manual
+ testing of IE's width values for various textareas and fonts. On Windows we match
+ IE exactly except for a couple fonts of the ~12 tested.
+
+ To get the average and max character width of a font, we do the following
+ for each platform:
+ -Win: TextMetrics expose avgCharWidth and maxCharWidth
+ -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
+ maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
+ -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
+ maxCharWidth = max of avgCharWidth and m_ascent
+ -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
+ If either one is non-positive, then calculate the value using the Linux approach.
+
+ Tests: fast/forms/text-control-intrinsic-widths.html
+ fast/forms/textarea-metrics.html
+ svg/custom/svg-fonts-in-text-controls.html
+
+ * css/html4.css:
+ * css/themeWin.css:
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData):
+ (WebCore::SimpleFontData::initCharWidths):
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::maxCharWidth):
+ (WebCore::SimpleFontData::avgCharWidth):
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::initGDIFont):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::calcPrefWidths):
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+
+2009-04-29 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * bindings/objc/DOMCSS.mm:
+ (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore
+ type and not the binding type.
+
+2009-04-29 John Abd-El-Malek <jam@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Reverted my previous change to add resetChromiumPluginCache().
+ https://bugs.webkit.org/show_bug.cgi?id=25318
+
+ * plugins/chromium/PluginDataChromium.cpp:
+
+2009-04-29 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
+
+ Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
+
+ Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
+
+2009-04-29 Alpha Lam <hclam@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25430
+
+ Provide style sheet for UI controls of media elements for Chromium port.
+
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
+
+2009-04-29 John Abd-El-Malek <jam@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Expose sudden termination to Chromium port.
+ https://bugs.webkit.org/show_bug.cgi?id=25457
+
+ * platform/SuddenTermination.h:
+ * platform/chromium/ChromiumBridge.h:
+ * platform/chromium/SuddenTerminationChromium.cpp: Added.
+ (WebCore::disableSuddenTermination):
+ (WebCore::enableSuddenTermination):
+
+2009-04-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Remove unused EventListeners.
+
+ * page/DOMWindow.idl:
+
+2009-04-29 Yury Semikhatsky <yurys@chromium.org>
+
+ Reveal current execution line once SourceFrame content is loaded.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25448
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._loaded):
+
+2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Simon Fraser.
+
+ [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
+ the default values of canvas attributes.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+
+2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::findMethodIndex): Removed exec param from at() call.
+ (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
+
+2009-04-28 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber stamped by Beth Dakin.
+
+ Missed one.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-28 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber stamped by Beth Dakin.
+
+ Removed scaffolding supporting dynamically converting between 32bit and
+ 64bit value representations.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::constructAudio):
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::JSCanvasRenderingContext2D::setFillColor):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
+ (WebCore::JSCanvasRenderingContext2D::strokeRect):
+ (WebCore::JSCanvasRenderingContext2D::drawImage):
+ (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
+ (WebCore::JSCanvasRenderingContext2D::setShadow):
+ (WebCore::JSCanvasRenderingContext2D::createPattern):
+ (WebCore::JSCanvasRenderingContext2D::putImageData):
+ (WebCore::JSCanvasRenderingContext2D::fillText):
+ (WebCore::JSCanvasRenderingContext2D::strokeText):
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore::JSClipboard::clearData):
+ (WebCore::JSClipboard::getData):
+ (WebCore::JSClipboard::setData):
+ (WebCore::JSClipboard::setDragImage):
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::hasItem):
+ (WebCore::JSDOMApplicationCache::add):
+ (WebCore::JSDOMApplicationCache::remove):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMStringListCustom.cpp:
+ (WebCore::JSDOMStringList::item):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::open):
+ (WebCore::JSDOMWindow::showModalDialog):
+ (WebCore::JSDOMWindow::postMessage):
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ (WebCore::JSDOMWindow::atob):
+ (WebCore::JSDOMWindow::btoa):
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ * bindings/js/JSDatabaseCustom.cpp:
+ (WebCore::JSDatabase::changeVersion):
+ (WebCore::JSDatabase::transaction):
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::JSElement::setAttribute):
+ (WebCore::JSElement::setAttributeNode):
+ (WebCore::JSElement::setAttributeNS):
+ (WebCore::JSElement::setAttributeNodeNS):
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::callHTMLCollection):
+ (WebCore::JSHTMLCollection::item):
+ (WebCore::JSHTMLCollection::namedItem):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::documentWrite):
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::setSelectionRange):
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ (WebCore::JSHTMLOptionsCollection::add):
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ (WebCore::JSHTMLSelectElement::remove):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::constructImage):
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::highlightDOMNode):
+ (WebCore::JSInspectorController::addResourceSourceToFrame):
+ (WebCore::JSInspectorController::addSourceToFrame):
+ (WebCore::JSInspectorController::getResourceDocumentNode):
+ (WebCore::JSInspectorController::search):
+ (WebCore::JSInspectorController::databaseTableNames):
+ (WebCore::JSInspectorController::setting):
+ (WebCore::JSInspectorController::setSetting):
+ (WebCore::JSInspectorController::wrapCallback):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::assign):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::insertBefore):
+ (WebCore::JSNode::replaceChild):
+ (WebCore::JSNode::removeChild):
+ (WebCore::JSNode::appendChild):
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ * bindings/js/JSNodeFilterCustom.cpp:
+ (WebCore::JSNodeFilter::acceptNode):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::callNodeList):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::constructHTMLOptionElement):
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ (WebCore::JSQuarantinedObjectWrapper::call):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ * bindings/js/JSSVGLengthCustom.cpp:
+ (WebCore::JSSVGLength::convertToSpecifiedUnits):
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ (WebCore::JSSVGMatrix::rotateFromVector):
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ (WebCore::JSSVGPathSegList::initialize):
+ (WebCore::JSSVGPathSegList::getItem):
+ (WebCore::JSSVGPathSegList::insertItemBefore):
+ (WebCore::JSSVGPathSegList::replaceItem):
+ (WebCore::JSSVGPathSegList::removeItem):
+ (WebCore::JSSVGPathSegList::appendItem):
+ * bindings/js/JSSVGPointListCustom.cpp:
+ (WebCore::JSSVGPointList::initialize):
+ (WebCore::JSSVGPointList::getItem):
+ (WebCore::JSSVGPointList::insertItemBefore):
+ (WebCore::JSSVGPointList::replaceItem):
+ (WebCore::JSSVGPointList::removeItem):
+ (WebCore::JSSVGPointList::appendItem):
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ (WebCore::JSSVGTransformList::initialize):
+ (WebCore::JSSVGTransformList::getItem):
+ (WebCore::JSSVGTransformList::insertItemBefore):
+ (WebCore::JSSVGTransformList::replaceItem):
+ (WebCore::JSSVGTransformList::removeItem):
+ (WebCore::JSSVGTransformList::appendItem):
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
+ (WebCore::constructWebKitCSSMatrix):
+ * bindings/js/JSWebKitPointConstructor.cpp:
+ (WebCore::constructWebKitPoint):
+ * bindings/js/JSWorkerConstructor.cpp:
+ (WebCore::constructWorker):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::importScripts):
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ (WebCore::JSWorkerContext::setTimeout):
+ (WebCore::JSWorkerContext::setInterval):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::open):
+ (WebCore::JSXMLHttpRequest::setRequestHeader):
+ (WebCore::JSXMLHttpRequest::send):
+ (WebCore::JSXMLHttpRequest::getResponseHeader):
+ (WebCore::JSXMLHttpRequest::overrideMimeType):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ (WebCore::JSXSLTProcessor::importStylesheet):
+ (WebCore::JSXSLTProcessor::transformToFragment):
+ (WebCore::JSXSLTProcessor::transformToDocument):
+ (WebCore::JSXSLTProcessor::setParameter):
+ (WebCore::JSXSLTProcessor::getParameter):
+ (WebCore::JSXSLTProcessor::removeParameter):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::create):
+ (WebCore::ScheduledAction::ScheduledAction):
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptCallFrame.cpp:
+ (WebCore::ScriptCallFrame::ScriptCallFrame):
+ * bindings/js/ScriptCallFrame.h:
+ * bindings/js/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::initialize):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::invokeMethod):
+ (JSC::Bindings::CInstance::invokeDefaultMethod):
+ (JSC::Bindings::CInstance::invokeConstruct):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::invokeMethod):
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::invokeMethod):
+ (ObjcInstance::invokeDefaultMethod):
+
+2009-04-28 David Carson <dacarson@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Restore alignment to device pixel boundaries.
+ https://bugs.webkit.org/show_bug.cgi?id=25458
+
+ Adjust the adjusted destination rect to be device pixel aligned.
+
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw):
+
+2009-04-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Move unimplemented captureEvents and releaseEvents from JSDOMWindow
+ to DOMWindow.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::captureEvents):
+ (WebCore::DOMWindow::releaseEvents):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-04-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25420
+ <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
+
+ Test: http/tests/xmlhttprequest/detaching-frame-2.html
+
+ This was caused by faulty DOMWindow::document(), which could return a new document from
+ the window's frame after navigation.
+
+ * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
+ Removed an obsolete check that allowed access when document was null. Contrary to what a
+ comment said, that can happen for a window that is no longer in frame, not to one whose
+ document is not constructed yet.
+
+ * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
+ out if context was not found. This currently happens due to a shortcoming in
+ DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
+ test will be constructed successfully, but won't be sent, because its context will be
+ frameless.
+
+ * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
+ been replaced yet. Added FIXME comments about how this may be better fixed in the future.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::document):
+ (WebCore::constructAudio):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::document):
+ (WebCore::constructImage):
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::construct):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::document):
+ (WebCore::constructHTMLOptionElement):
+ Make matching changes to other constructors that hold a reference to global object.
+
+2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
+
+ wxMSW build fix. Switch JSCore build back to static.
+
+ * config.h:
+
+2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6834830>
+
+ Make sure we cover the two possible values reported by event.total that are playback engine
+ specific.
+
+ * media/progress-event-total-expected.txt: Match the new test.
+ * media/progress-event-total.html: Test the two values.
+
+2009-04-28 Timothy Hatcher <timothy@apple.com>
+
+ Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
+ collects the individual rects, making sure to only include RenderText.
+
+ <rdar://problem/6810061>
+
+ Reviewed by Sam Weinig.
+
+ * bindings/objc/DOM.mm:
+ (-[DOMNode textRects]): Added. Make a Range and call textRects.
+ (-[DOMNode lineBoxRects]): Call textRects method.
+ (-[DOMRange textRects]): Call Range::textRects.
+ (-[DOMRange lineBoxRects]): Call textRects method.
+ * bindings/objc/DOMPrivate.h: Add the new methods and a comment
+ about lineBoxRects being deprecated.
+ * dom/Range.cpp:
+ (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
+ (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
+ nodes instead of the RenderObjects to correctly account for offsets. Also
+ only call absoluteRectsForRange on RenderText.
+ * dom/Range.h: Renamed addLineBoxRects to textRects.
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
+ function very specific for the lineBoxRects API. These functions are still used
+ by the InspectorController, and this change improves what the Inspector shows.
+ (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
+
+2009-04-28 Timothy Hatcher <timothy@apple.com>
+
+ Remove the topLevel boolean argument from absolute{Rects,Quads}.
+ This argument was default to true and no one ever passed false.
+
+ Reviewed by Sam Weinig.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::absoluteRects):
+ (WebCore::RenderBlock::absoluteQuads):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::absoluteRects):
+ (WebCore::RenderBox::absoluteQuads):
+ * rendering/RenderBox.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::absoluteQuads):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::absoluteRects):
+ (WebCore::RenderObject::absoluteQuads):
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::absoluteRects):
+ (WebCore::RenderSVGHiddenContainer::absoluteQuads):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::absoluteRects):
+ (WebCore::RenderSVGImage::absoluteQuads):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::absoluteRects):
+ (WebCore::RenderSVGInlineText::absoluteQuads):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::absoluteRects):
+ (WebCore::RenderSVGModelObject::absoluteQuads):
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGTSpan.cpp:
+ (WebCore::RenderSVGTSpan::absoluteRects):
+ (WebCore::RenderSVGTSpan::absoluteQuads):
+ * rendering/RenderSVGTSpan.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::absoluteQuads):
+ * rendering/RenderSVGTextPath.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::absoluteRects):
+ * rendering/RenderText.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::absoluteRects):
+ (WebCore::RenderView::absoluteQuads):
+ * rendering/RenderView.h:
+
+2009-04-28 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
+
+ RenderThemeWin doesn't implement the media element controller rendering methods, so media
+ controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
+ of the code in both places, the logic is in a new class that is called from both.
+
+ * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
+
+ * rendering/RenderMediaControls.cpp: Added.
+ (WebCore::determineState): Translate renderer state to ThemeControlState.
+ (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
+ (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
+ (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
+ * rendering/RenderMediaControls.h: Added.
+
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
+ called for the media slider.
+ (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
+ (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
+ (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
+ (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
+ (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
+ (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
+ (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
+ (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
+ (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
+ (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
+ * rendering/RenderThemeWin.h:
+
+2009-04-28 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
+ images with % height are collapsed when printing
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcHeight): Make sure we don't ignore
+ printing here!
+
+2009-04-28 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
+
+ Test: editing/deleting/type-delete-after-quote.html
+
+ When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
+ since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
+ with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
+ we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
+ that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
+ from deleting a range they selected.
+
+ * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
+
+2009-04-28 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed: fix distcheck build, add missing header to file list.
+
+ * GNUmakefile.am:
+
+2009-04-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Fix foreignObject transform order
+ https://bugs.webkit.org/show_bug.cgi?id=25433
+
+ Transforms were being applied in the wrong order.
+ When mapping from local to parent, first apply the viewport transform
+ then map from the viewport box to the parent box.
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::localToParentTransform):
+
+2009-04-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Simplify nodeAtPoint for SVG
+ https://bugs.webkit.org/show_bug.cgi?id=25432
+
+ Added a new nodeAtFloatPoint method which takes a FloatPoint
+ instead of the *super confusing* x/y tx/ty pairs that HTML uses.
+ Mostly this is just lots of minus-lines as the new code is *much* simpler.
+
+ I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
+ for the nodeAtPoint HTML/CSS int x/y version.
+
+ Eventually the rest of CSS/HTML render objects will follow suit
+ and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
+ over was well outside the scope of this change.
+
+ SVG hit testing is not actually floating point precise yet, since its still
+ passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
+ by moving to FloatPoint here, but I didn't try to find one.
+
+ This should not cause functional changes for common-case hit testing, thus
+ no tests changed, nor should new tests be needed.
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::translationForAttributes):
+ (WebCore::RenderForeignObject::paint):
+ (WebCore::RenderForeignObject::computeRectForRepaint):
+ (WebCore::RenderForeignObject::localToParentTransform):
+ (WebCore::RenderForeignObject::layout):
+ (WebCore::RenderForeignObject::nodeAtFloatPoint):
+ * rendering/RenderForeignObject.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::nodeAtFloatPoint):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::nodeAtFloatPoint):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::nodeAtFloatPoint):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::paint):
+ (WebCore::RenderSVGImage::nodeAtFloatPoint):
+ * rendering/RenderSVGImage.h:
+ (WebCore::RenderSVGImage::localToParentTransform):
+ (WebCore::RenderSVGImage::localTransform):
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::nodeAtFloatPoint):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::nodeAtFloatPoint):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
+ * rendering/RenderSVGViewportContainer.h:
+
+2009-04-28 Eric Carlson <eric.carlson@apple.com>
+
+ - fix the Tiger build
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::cacheMovieScale):
+
+2009-04-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Beth Dakin.
+
+ Consolidate ScheduleAction creation into ScheduledAction::create.
+ Autogenerate JSWorkerContext.clearTimeout and clearInterval.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::setTimeout):
+ (WebCore::JSWorkerContext::setInterval):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::create):
+ (WebCore::ScheduledAction::ScheduledAction):
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScheduledAction.h:
+ * workers/WorkerContext.cpp:
+ (WebCore::DOMWindow::setTimeout):
+ (WebCore::DOMWindow::clearTimeout):
+ (WebCore::DOMWindow::setInterval):
+ (WebCore::DOMWindow::clearInterval):
+ * workers/WorkerContext.h:
+ * workers/WorkerContext.idl:
+
+2009-04-28 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
+
+ When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
+ as creating webarchives, would tickle this bug.
+
+ Tests: webarchive/adopt-attribute-styled-body-webarchive.html
+ webarchive/adopt-attribute-styled-node-webarchive.html
+ webarchive/adopt-inline-styled-node-webarchive.html
+
+ * dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument
+ calls their parent-class implementation after they've done their own work.
+ (WebCore::setWillMoveToNewOwnerDocumentWasCalled):
+ (WebCore::setDidMoveToNewOwnerDocumentWasCalled):
+ (WebCore::Node::setDocument):
+ (WebCore::Node::willMoveToNewOwnerDocument):
+ (WebCore::Node::didMoveToNewOwnerDocument):
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap
+ to update style declarations.
+ (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
+ * dom/StyledElement.h:
+
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
+ * html/HTMLBodyElement.h:
+
+2009-04-28 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
+ QTMoviePreferredTransformAttribute
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of
+ BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit
+ that throw an exception on QTMovieCurrentSizeAttribute but don't support
+ QTMoviePreferredTransformAttribute
+
+2009-04-28 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count
+ churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment.
+ (WebCore::RenderText::setTextInternal): Ditto.
+
+2009-04-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Simplify how SVG containers paint
+ https://bugs.webkit.org/show_bug.cgi?id=25431
+
+ Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
+ Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
+ RenderSVGText now applies transforms at paint() time instead of during chunk draw time
+ this should be much more efficient.
+
+ Fixed the order in which RenderSVGViewportContainer applied
+ transforms and clips. We now clip to the viewport first and apply
+ all transforms at once. Also since the viewport logic is now only
+ inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
+ we always know we have a viewport. We now use only viewportSize instead of
+ viewport() since RenderSVGViewportContainers can't have x/y offsets.
+
+ We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
+ This allowed us to apply the transform during text paint() instead of at chunk paint
+ time. Previously we had to apply the transform during chunk paint time because
+ RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
+ before telling any of the inlines to draw. Now that we adjust the damage rect correctly
+ we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
+ but since I still have a bunch of those to fix, I've not tried to write additional tests
+ to cover these potential fixes yet.)
+
+ SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::repaintRectInLocalCoordinates):
+ (WebCore::RenderPath::paint):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::applyViewportClip):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::layout):
+ (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
+ (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGImage::computeRectForRepaint):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGModelObject.cpp:
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ (WebCore::RenderSVGRoot::selfWillPaint):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::viewportSize):
+ (WebCore::RenderSVGRoot::calcViewport):
+ (WebCore::RenderSVGRoot::localToBorderBoxTransform):
+ (WebCore::RenderSVGRoot::parentOriginToBorderBox):
+ (WebCore::RenderSVGRoot::borderOriginToContentBox):
+ (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
+ (WebCore::RenderSVGRoot::localToParentTransform):
+ (WebCore::RenderSVGRoot::computeRectForRepaint):
+ (WebCore::RenderSVGRoot::nodeAtPoint):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGText::computeRectForRepaint):
+ (WebCore::RenderSVGText::paint):
+ (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGText.h:
+ (WebCore::RenderSVGText::localToParentTransform):
+ (WebCore::RenderSVGText::localTransform):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::applyViewportClip):
+ * rendering/RenderSVGViewportContainer.h:
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::filterBoundingBoxForRenderer):
+ (WebCore::applyTransformToPaintInfo):
+ * rendering/SVGRenderSupport.h:
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
+ (WebCore::SVGRootInlineBox::paint):
+
+2009-04-28 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
+ https://bugs.webkit.org/show_bug.cgi?id=25453
+
+ Test: accessibility/placeholder.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::title):
+
+2009-04-28 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
+ https://bugs.webkit.org/show_bug.cgi?id=25452
+
+ Test: accessibility/ignore-spacer-elements.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+
+2009-04-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
+ This removes the need for us to explicitly initialize all of the members, which have a tendency
+ to change in meaning and number between versions of libxml2.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::):
+ (WebCore::sharedXHTMLEntity):
+ (WebCore::getXHTMLEntity):
+
+2009-04-28 Steve Falkenburg <sfalken@apple.com>
+
+ Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
+
+ Reviewed by Mark Rowe.
+
+ * WebCore.vcproj/QTMovieWin.vcproj:
+
+2009-04-28 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
+ https://bugs.webkit.org/show_bug.cgi?id=25449
+
+ Test: accessibility/img-aria-button-alt-tag.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityDescription):
+
+2009-04-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - formatting cleanup
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcHeight): Corrected indentation and added braces
+ around a multi-line "else" clause.
+
+2009-04-28 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adam Roben
+
+ <rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=25094
+
+ Display movies saved with a non-identity matrix at the correct size.
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor.
+ (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial
+ size and natural size so naturalSize() accounts for non-identity movie matrix.
+ (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches
+ kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState.
+ (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState.
+ (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches
+ kMovieLoadStateLoaded because we do not try to draw it before that point.
+ (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded
+ because we need to get the movie's initial size in cacheMovieScale.
+ (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.
+
+2009-04-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
+ clearInterval can now be autogenerated.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::createScheduledAction):
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setTimeout):
+ (WebCore::DOMWindow::clearTimeout):
+ (WebCore::DOMWindow::setInterval):
+ (WebCore::DOMWindow::clearInterval):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-04-28 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Small optimization, don't get the widget's handle twice in one method.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25446
+
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::setFocus):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ (WebCore::Widget::invalidateRect):
+ (WebCore::Widget::paint):
+
+2009-04-28 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ ScrollView copy and paste typo fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25445
+
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetScrollbarModes):
+
+2009-04-28 John Sullivan <sullivan@apple.com>
+
+ <rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII
+
+ Reviewed by Adam Roben
+
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageTokenizer::finish):
+ decode the filename before processing it as part of the image name that's passed to the client
+
+2009-04-28 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed, build fix.
+
+ - fix initialization order to match declaration order to fix release build
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+
+2009-04-28 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Justin Garcia.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16135
+ [GTK] Support caret browsing
+
+ Based on a patch by Alp Toker.
+
+ Implement basic support for caret browsing, active only when the
+ corresponding setting is enabled.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ * page/FocusController.cpp:
+ (WebCore::FocusController::advanceFocus):
+ (WebCore::clearSelectionIfNeeded):
+ (WebCore::FocusController::setFocusedNode):
+ * page/Frame.cpp:
+ (WebCore::Frame::setFocusedNodeIfNeeded):
+ (WebCore::Frame::setSelectionFromNone):
+ (WebCore::Frame::respondToChangedSelection):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintCaret):
+
+2009-04-27 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Fix a compile breakage.
+ <https://bugs.webkit.org/show_bug.cgi?id=25384>
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-04-27 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash
+
+ QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
+ multiplier to scale from natural size to current size when a movie is opened and use that to
+ return the correct value from the naturalSize() method.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor.
+ (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale.
+ (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial
+ size and natural size so naturalSize() accounts for non-identity movie matrix.
+ (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches
+ QTMovieLoadStateLoaded for the first time.
+
+2009-04-27 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
+
+ The problem here is that we had a self-painting layer nested inside
+ a non-self-painting layer. We ended up ignoring the self-painting
+ layer both during painting and hit-testing. This patch corrects
+ that.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-04-27 Ada Chan <adachan@apple.com>
+
+ If it has been set to allow any HTTPS certificates for this host, set
+ kCFStreamSSLAllowsExpiredCertificates to true to allow expired
+ certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
+ certificate chain validation. (<rdar://problem/6382059>)
+
+ Reviewed by John Sullivan.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::makeFinalRequest):
+
+2009-04-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson
+
+ <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
+
+ Fix a 'size changed' notification thrash that caused standalone video elements
+ to continually resize after full page zooming, by using the movie's natual size (which is independent
+ of zooming), rather than its current size (which is not).
+
+ Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
+ disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
+ QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
+ <rdar://problem/6822344>.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::naturalSize):
+
+2009-04-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
+ load if movie had been previously viewed
+
+ Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
+ to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.
+
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::rendererIsNeeded):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::rendererIsNeeded):
+
+2009-04-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Move more window event related code into DOMWindow.
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ (WebCore::Document::setWindowAttributeEventListener):
+ (WebCore::Document::dispatchWindowEvent):
+ (WebCore::Document::dispatchLoadEvent):
+ * dom/Document.h:
+ * dom/Element.cpp:
+ * dom/Element.h:
+ * dom/Node.cpp:
+ * dom/Node.h:
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
+ (WebCore::DOMWindow::postMessageTimerFired):
+ (WebCore::DOMWindow::dispatchEvent):
+ (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget):
+ (WebCore::DOMWindow::dispatchLoadEvent):
+ (WebCore::DOMWindow::dispatchUnloadEvent):
+ (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
+ * page/DOMWindow.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::shouldClose):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+
+2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
+
+ Implement the editing mechanisms and add context menu items for
+ <rdar://problem/6724106> WebViews need to implement text checking
+
+ Reviewed by Justin Garcia.
+
+ * editing/Editor.cpp:
+ * editing/Editor.h:
+ * editing/TypingCommand.cpp:
+ * loader/EmptyClients.h:
+ * page/ContextMenuController.cpp:
+ * page/EditorClient.h:
+ * page/mac/WebCoreViewFactory.h:
+ * platform/ContextMenu.cpp:
+ * platform/ContextMenuItem.h:
+ * platform/LocalizedStrings.h:
+ * platform/mac/LocalizedStringsMac.mm:
+
+2009-04-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower
+
+ Be slightly less eager in collecting after page close/navigation by increasing
+ the time before collection from 0 seconds to .5 seconds.
+
+ 3% speedup on the PLT.
+
+ * bindings/js/GCController.cpp:
+ (WebCore::GCController::garbageCollectSoon):
+
+2009-04-27 David Kilzer <ddkilzer@apple.com>
+
+ Consolidate runtime application checks for Apple Mail and Safari
+
+ Reviewed by Mark Rowe and Darin Adler.
+
+ * WebCore.base.exp: Added exports.
+ * WebCore.xcodeproj/project.pbxproj: Added
+ RuntimeApplicationChecks.{h|mm} source files to the project.
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
+ Removed local checkedSafari and isSafari variables and switched
+ to use applicationIsSafari().
+ * platform/mac/RuntimeApplicationChecks.h: Added.
+ * platform/mac/RuntimeApplicationChecks.mm: Added.
+ (WebCore::applicationIsAppleMail): Runtime application check for
+ Apple Mail.
+ (WebCore::applicationIsSafari): Runtime application check for
+ Safari.
+
+2009-04-27 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25374: AX: No AXValue change sent when text is auto-inserted
+ https://bugs.webkit.org/show_bug.cgi?id=25374
+
+ First patch caused some regression tests to fail.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setInnerTextValue):
+
+2009-04-16 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Cover more WebCore role -> ATK role conversions.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-18 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Do not call ATK setters in the getters, just return the
+ value. Among other things calling the setter will emit the notify
+ signal, which is wrong.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-16 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Implement AtkImage interface.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed debug build fix.
+
+ * platform/gtk/gtk2drawing.c:
+ (moz_gtk_toggle_paint):
+
+2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Build fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25382
+ Remove direct reference to CallFrame.h include to pacify Win build.
+
+ * bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
+ * bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
+
+2009-04-27 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25374: AX: No AXValue change sent when text is auto-inserted
+ https://bugs.webkit.org/show_bug.cgi?id=25374
+
+ When an input's text value is changed through the DOM, no AXValueChange notification is being sent.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setInnerTextValue):
+
+2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25382
+ Move scriptStateFromNode to ScriptState.
+
+ * bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
+ * bindings/js/JSDOMBinding.h: Ditto.
+ * bindings/js/ScriptState.cpp:
+ (WebCore::scriptStateFromNode): Added.
+ * bindings/js/ScriptState.h: Ditto.
+ * bindings/v8/ScriptState.cpp:
+ (WebCore::scriptStateFromNode): Added.
+ * bindings/v8/ScriptState.h: Ditto.
+ * dom/NodeFilter.h: Removed JSDOMBinding header include.
+ * dom/NodeIterator.h: Ditto.
+ * dom/TreeWalker.h: Ditto.
+
+2009-04-27 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
+ https://bugs.webkit.org/show_bug.cgi?id=25428
+
+ When marking children as changed in accessibility, we cannot rely on the accessibility parent chain existing.
+ Instead, the render chain needs to be consulted.
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::childrenChanged):
+
+2009-04-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25399
+ <rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
+ beneath WebCore::Cache::evict
+
+ The crash happened because a cached resource handle was removed from a document's cached
+ resources map twice recursively, so a destructor was called for a value in a deleted bucket.
+ The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
+ CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
+ an inconsistent state.
+
+ I couldn't fully reconstruct the loading sequence to make a test.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache
+ (it makes no sense to revalidate one that isn't).
+ (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource
+ from the cache in no way implies that documents no longer use the old version. This fixes the
+ crash, and also fixes many cases of resource content being unavailable in Web Inspector.
+
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache,
+ reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never
+ being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases,
+ switchClientsToRevalidatedResource() results in the same resource being requested again,
+ but we were only enforcing CachedResource invariants after calling this function.
+ (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
+
+ * loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed
+ resource is removed, not some other resource that happens to have the same URL (this used to
+ fail on LexisNexis search before this patch).
+
+ * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED
+ with notImplemented(). This method can be legally called via document.write(), and should
+ work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it
+ doesn't affect site functionality.
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate
+ is being revalidated - this may no longer be true, because we now reset this member in
+ CachedResource::setInCache().
+
+2009-04-27 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - make BidiContext a RefCounted class, starting with a refcount of 1,
+ and share the root BidiContexts.
+
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
+ * platform/text/BidiContext.cpp:
+ (WebCore::BidiContext::create): Added. For the four "root" contexts,
+ returns a reference to a shared static BidiContext.
+ * platform/text/BidiContext.h:
+ (WebCore::BidiContext::BidiContext):
+ * platform/text/BidiResolver.h:
+ (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::determineStartPosition): Ditto.
+
+2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Rubber-stamped by Gustavo Noronha.
+
+ Build fix for r42893: change GDK_exclaim to GDK_exclam
+
+ * platform/chromium/KeyCodeConversionGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+ * platform/gtk/KeyEventGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+
+2009-04-27 Fumitoshi Ukai <ukai@google.com>
+
+ Reviewed by Xan Lopez.
+
+ Fix wrong key code conversion.
+
+ Missing conversion for GDK_exlaim ('!').
+ Parens are opposite: GDK_parenleft is open paren '('
+ and GDK_parenright is close paren ')'.
+ https://bugs.webkit.org/show_bug.cgi?id=25367
+
+ * platform/chromium/KeyCodeConversionGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+ * platform/gtk/KeyEventGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+
+2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Gustavo Noronha.
+
+ [Gtk] gtkdrawing update
+ https://bugs.webkit.org/show_bug.cgi?id=25408
+
+ Update to the 25 Apr 2009 version of gtk2drawing.c and
+ gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
+
+ * platform/gtk/gtk2drawing.c:
+ (setup_widget_prototype):
+ (moz_gtk_get_combo_box_entry_arrow):
+ (ensure_toolbar_widget):
+ (ensure_tree_header_cell_widget):
+ (moz_gtk_init):
+ (moz_gtk_button_get_inner_border):
+ (moz_gtk_toggle_paint):
+ (moz_gtk_caret_paint):
+ (moz_gtk_entry_paint):
+ (moz_gtk_tree_header_cell_paint):
+ (moz_gtk_combo_box_paint):
+ (moz_gtk_toolbar_separator_paint):
+ (moz_gtk_menu_separator_paint):
+ (moz_gtk_get_widget_border):
+ (moz_gtk_get_tab_scroll_arrow_size):
+ (moz_gtk_get_toolbar_separator_width):
+ (moz_gtk_get_menu_separator_height):
+ (moz_gtk_widget_paint):
+ (moz_gtk_shutdown):
+ * platform/gtk/gtkdrawing.h:
+
+2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18475
+
+ [Qt] Widget painting should follow the layout direction (LTR, RTL)
+ of the element style, not the application layout direction.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::applyTheme):
+
+2009-04-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25412
+ The Window object should be an EventTarget
+
+ Test: fast/dom/Window/dispatchEvent.html
+
+ * bindings/js/JSEventTarget.cpp:
+ (WebCore::toJS): Add DOMWindow case.
+ (WebCore::toEventTarget): Ditto.
+
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::toDOMWindow): Added.
+ * dom/EventTarget.h:
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document.
+ (WebCore::DOMWindow::dispatchEvent): Added.
+ * page/DOMWindow.h:
+ (WebCore::DOMWindow::toDOMWindow):
+ (WebCore::DOMWindow::refEventTarget):
+ (WebCore::DOMWindow::derefEventTarget):
+ * page/DOMWindow.idl:
+
+2009-04-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove scons-based build system.
+
+ * WebCore.scons: Removed.
+
+2009-04-26 Darin Adler <darin@apple.com>
+
+ Suggested by Darin Fisher.
+
+ Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
+ https://bugs.webkit.org/show_bug.cgi?id=25355
+ rdar://problem/6823543
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0.
+ Not sure if when this case can really arise in practice, but it's good to match the original
+ logic more closely.
+
+2009-04-25 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ A width or height of zero for the destination or source rect of an
+ image causes a not invertible pattern matrix.
+ This crahes newer versions of Cairo and give some graphic gliches in
+ Canvas.
+ With this patch we check if there is something to draw and return if not.
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::draw):
+
+2009-04-25 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=25390
+
+ Fix point mapping and hit testing through transforms and perspective
+ with ENABLE_3D_RENDERING. Previously the code did the more efficient
+ move(), rather than getTransformFromContainer(), when the object had
+ no transform. However, this skipped the application of perspective
+ when the immediate child of the perspective element had no transform
+ itself.
+
+ Test: transforms/3d/point-mapping/3d-point-mapping-3.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToContainer):
+ (WebCore::RenderBox::mapAbsoluteToLocalPoint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createLocalTransformState):
+ Call shouldUseTransformFromContainer() to determine if we need to
+ go through the more expensive getTransformFromContainer() code
+ path.
+
+ * rendering/RenderObject.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::shouldUseTransformFromContainer):
+ New method that indicates whether we need use getTransformFromContainer()
+ when mapping points through renderers, and hit testing.
+
+2009-04-25 Adele Peterson <adele@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
+ https://bugs.webkit.org/show_bug.cgi?id=25396
+
+ Test: editing/deleting/delete-br-013.html
+
+ * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
+ Only preserve an empty paragraph's style when moving paragraphs around if the selection is still
+ in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite
+ the previous paragraph's style during a delete of an empty paragraph.
+
+2009-04-25 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
+ properly display non-linear media
+
+ If a media engine claims it can support the MIME type, WebCore now creates a <video>
+ element for document mode media files instead of an <embed> element. Because WebCore's
+ QuickTime backed media players do not support every kind of media the QuickTime plug-in
+ supports, and because it is not always possible to tell what type of media is in a file
+ without opening and parsing it, some types of media that used to be displayed properly
+ by a plug-in are no longer supported properly. To fix this, if the media engine
+ sees that it can not completely support a media file it now informs the media
+ document, which replaces the <video> element with an <embed>.
+
+ r42301 landed support for OSX. This patch modifies those changes slighly and adds support
+ for Windows.
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer.
+ (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video>
+ element immediately.
+ (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed.
+ Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
+ * loader/MediaDocument.h:
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks.
+ (WebCore::MediaPlayerPrivate::rateChanged): Ditto.
+ (WebCore::MediaPlayerPrivate::timeChanged): Ditto.
+ (WebCore::MediaPlayerPrivate::didEnd): Ditto.
+ (WebCore::MediaPlayerPrivate::repaint): Ditto.
+ (WebCore::MediaPlayerPrivate::paint): Ditto.
+ (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks.
+ (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported
+ media type(s) or if it fails completely.
+ (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the
+ media player client we won't play this movie correctly.
+ (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks.
+ (WebCore::MediaPlayerPrivate::setSize): Ditto.
+ (WebCore::MediaPlayerPrivate::setVisible): Ditto.
+ (WebCore::MediaPlayerPrivate::paint): Ditto.
+ (WebCore::MediaPlayerPrivate::movieEnded): Ditto.
+ (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto.
+ (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto.
+ (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state
+ change callback.
+ (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled.
+ (QTMovieWin::QTMovieWin): Initialize m_disabled.
+ (QTMovieWin::disableUnsupportedTracks): Return total number of tracks.
+ (QTMovieWin::setDisabled): New, set m_disabled flag.
+ * platform/graphics/win/QTMovieWin.h:
+
+2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Error reporting
+ https://bugs.webkit.org/show_bug.cgi?id=18344
+
+ Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
+ errors and G_IO_ERROR for gio errors.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::finishedCallback):
+ (WebCore::ResourceHandle::startHttp):
+ (WebCore::ResourceHandle::start):
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+ (WebCore::ResourceHandle::startGio):
+
+2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Mark Rowe.
+
+ Only set the new URL once for the request. Doing it a second time
+ after the call to willSendRequest was causing crashes when
+ redirected requests got cancelled.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::restartedCallback):
+
+2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Adding ScriptEventListener.cpp.
+
+ * WebCoreSources.bkl:
+
+2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17267
+ [GTK] Primary selection/clipboard support
+
+ Copy the link location to the primary selection as well as the
+ clipboard selection when using the "copy link selection" context
+ menu entry.
+
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::Pasteboard::writeURL):
+ * platform/gtk/PasteboardHelper.h:
+
+2009-04-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25383
+ Changing SVG size via JS does not update CSS width/height
+
+ Add an ugly hack to fix CSS width/height updates from JS.
+
+ We can't easily call setAttribute when width/height changes
+ as that would cause infinite recursion (as we'd try to set
+ the animation storage from the attributes)
+
+ For now, when we get notification that JS changed width/height
+ we copy what parseMappedAttribute does and update the CSS values as well.
+
+ A better fix for this would be:
+ https://bugs.webkit.org/show_bug.cgi?id=25383
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::updateCSSForAttribute):
+ (WebCore::SVGSVGElement::svgAttributeChanged):
+
+2009-04-24 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ We should not show the deletion UI for blockquotes in mail but they do
+ show now that we only check for one visible border.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+
+2009-04-24 Dan Bernstein <mitz@apple.com>
+
+ - address Hyatt's review comments on the last patch
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::performOverlapTests):
+ (WebCore::RenderLayer::paintLayer):
+
+2009-04-24 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=5909
+ <rdar://problem/5863349> overlapping element leaves trail when
+ scrolling iframe
+
+ * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::reset): Initialize m_isOverlapped.
+ (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
+ (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
+ so overlapping is taken into account.
+ (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
+ enables or disables copy-on-scroll accordingly.
+
+ * page/FrameView.h:
+ Added setIsOverlapped() and m_isOverlapped.
+
+ * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
+ an OverlapTestRequestClient can make a request to test if any subsequently-
+ painted layers overlap a rect. The test result is delivered to the
+ requestClient via setOverlapTestResult().
+ (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
+ paintLayer(). When done painting, inform any remaining requestClients that
+ they are not overlapped.
+
+ (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
+ pass it down to child and reflection layers. Inform requestClients if this
+ layer overlaps their requested rects.
+
+ * rendering/RenderLayer.h:
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
+ OverlapTestRequestMap member.
+
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
+ to paintLayer().
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
+ with the frame.
+ (WebCore::RenderWidget::setOverlapTestResult): Call
+ FrameView::setIsOverlapped() with the result of the overlap test.
+
+ * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
+
+2009-04-24 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser, Dan Bernstein.
+
+ Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
+ a ~0.5% slowdown. This patch does the following to get the speed back:
+
+ (a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
+ then be removed.
+ (b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
+ member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
+ (c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
+ been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::height):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ (WebCore::InlineBox::isSVG):
+ (WebCore::InlineBox::setIsSVG):
+ (WebCore::InlineBox::isText):
+ (WebCore::InlineBox::setIsText):
+ (WebCore::InlineBox::svgBoxHeight):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::paintBoxDecorations):
+ (WebCore::InlineFlowBox::paintMask):
+ * rendering/InlineFlowBox.h:
+ * rendering/InlineTextBox.cpp:
+ * rendering/InlineTextBox.h:
+ * rendering/ListMarkerBox.cpp: Removed.
+ * rendering/ListMarkerBox.h: Removed.
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::createInlineBox):
+ * rendering/RenderSVGInline.cpp:
+ (WebCore::RenderSVGInline::createFlowBox):
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::createTextBox):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::createRootBox):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::createInlineTextBox):
+ * rendering/RootInlineBox.cpp:
+ * rendering/RootInlineBox.h:
+ * rendering/SVGInlineFlowBox.h:
+ (WebCore::SVGInlineFlowBox::svgBoxHeight):
+ * rendering/SVGInlineTextBox.h:
+ (WebCore::SVGInlineTextBox::svgBoxHeight):
+ * rendering/SVGRootInlineBox.h:
+ (WebCore::SVGRootInlineBox::svgBoxHeight):
+
+2009-04-24 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25370
+ Introduce ScriptEventListener to refactor away direct references to
+ JSLazyEventListener in WebCore code.
+
+ * GNUmakefile.am: Added ScriptEventListener to project.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
+ * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
+ to ScriptEventListener.
+ * bindings/js/JSLazyEventListener.h: Ditto.
+ * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
+ * bindings/js/ScriptEventListener.cpp: Added.
+ * bindings/js/ScriptEventListener.h: Added.
+ * bindings/v8/ScriptEventListener.cpp: Added.
+ * bindings/v8/ScriptEventListener.h: Added.
+ * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
+ * html/HTMLBodyElement.cpp: Ditto.
+ * html/HTMLButtonElement.cpp: Ditto.
+ * html/HTMLElement.cpp: Ditto.
+ * html/HTMLFormElement.cpp: Ditto.
+ * html/HTMLFrameElementBase.cpp: Ditto.
+ * html/HTMLFrameSetElement.cpp: Ditto.
+ * html/HTMLImageElement.cpp: Ditto.
+ * html/HTMLInputElement.cpp: Ditto.
+ * html/HTMLObjectElement.cpp: Ditto.
+ * html/HTMLScriptElement.cpp: Ditto.
+ * html/HTMLSelectElement.cpp: Ditto.
+ * html/HTMLTextAreaElement.cpp: Ditto.
+ * svg/SVGElement.cpp: Ditto.
+ * svg/SVGSVGElement.cpp: Ditto.
+
+2009-04-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
+ https://bugs.webkit.org/show_bug.cgi?id=25355
+ rdar://problem/6823543
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): Added a null check.
+
+2009-04-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Fix RenderSVGImage to dump with full bounds and style information.
+ https://bugs.webkit.org/show_bug.cgi?id=25377
+
+ No functional changes, we're just now including more info in render tree dumps.
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isSVGImage):
+ * rendering/RenderSVGImage.h:
+ (WebCore::RenderSVGImage::isSVGImage):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ (WebCore::write):
+ * rendering/SVGRenderTreeAsText.h:
+
+2009-04-24 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (chromium build fix).
+
+ Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).
+
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::V8AbstractEventListener):
+ (WebCore::V8AbstractEventListener::invokeEventHandler):
+ * bindings/v8/V8AbstractEventListener.h:
+ * bindings/v8/V8EventListenerList.cpp:
+ (WebCore::V8EventListenerList::add):
+ (WebCore::V8EventListenerList::remove):
+ (WebCore::V8EventListenerList::clear):
+ * bindings/v8/V8LazyEventListener.h:
+ (WebCore::V8LazyEventListener::virtualisAttribute):
+ * bindings/v8/custom/V8CustomEventListener.cpp:
+ (WebCore::V8EventListener::V8EventListener):
+ * bindings/v8/custom/V8CustomEventListener.h:
+ (WebCore::V8EventListener::create):
+ (WebCore::V8EventListener::virtualisAttribute):
+
+2009-04-24 Nate Chapin <japhet@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25343
+ Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
+ ignores blur.
+
+ * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
+ (WebCore::GraphicsContext::setPlatformShadow): Add check against
+ blur before clearing looper.
+
+2009-04-24 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Initialize TextIterator::m_textLength to 0.
+
+ This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25335>
+
+ Test: editing/selection/doubleclick-whitespace-img-crash.html
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::TextIterator):
+
+2009-04-24 Fumitoshi Ukai <ukai@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25329
+ Add indexed access method in v8 binding of ClientRectList.
+
+ * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
+
+2009-04-24 Fumitoshi Ukai <ukai@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25257
+ Use null for unspecified event listener attributes of XMLHttpRequest
+ and XMLHttpRequestUpload in v8 binding.
+
+ cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
+ An event handler attribute, unless otherwise specified, can either
+ have the value null or be set to a Function object.
+ Initially, an event handler attribute must be set to null.
+
+ Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html
+
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
+ * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
+ (WebCore::ACCESSOR_GETTER): Ditto.
+
+2009-04-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::reportException): Added a null check.
+
+2009-04-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=23219
+
+ Add support for transtions and animations of background-position, -webkit-background-size,
+ -webkit-mask-position and -webkit-mask-size.
+
+ Tests: transitions/background-transitions.html
+ transitions/mask-transitions.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ Add a blend func for LengthSize.
+
+ (WebCore::ensurePropertyMap):
+ Add wrappers for the new properties.
+
+ (WebCore::addShorthandProperties):
+ Add a shorthand property for CSSPropertyBackgroundPosition to map to
+ CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
+ add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
+ CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
+ CSSPropertyWebkitMaskPositionY.
+
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::setBackgroundXPosition):
+ (WebCore::InheritedFlags::setBackgroundYPosition):
+ (WebCore::InheritedFlags::setBackgroundSize):
+ (WebCore::InheritedFlags::setMaskXPosition):
+ (WebCore::InheritedFlags::setMaskYPosition):
+ (WebCore::InheritedFlags::setMaskSize):
+ Add setters for the properties that can be animated now.
+
+2009-04-24 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
+
+ Test: editing/pasteboard/paste-blockquote-after-blockquote.html
+
+ When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
+ But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
+ blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
+ to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
+ (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
+ * editing/ReplaceSelectionCommand.h:
+
+2009-04-23 Francisco Tolmasky <francisco@280north.com>
+
+ BUG 24604: WebKit profiler reports incorrect total times
+ <https://bugs.webkit.org/show_bug.cgi?id=24604>
+
+ Reviewed by Timothy Hatcher and Kevin McCullough.
+
+ Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
+ heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
+ displays flattened statistics for a particular function that ran during the profile, and each child
+ of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
+ nodes should show how much of the root nodes values came from it. For example, if you had the following to
+ stacks take place during the profile:
+
+ A ->calls 1 times-> B ->calls 2 times-> C
+ D ->calls 4 times-> C
+
+ The tree for the C root node would look like this:
+
+ C -> B -> A
+ -> D
+
+ The number of calls values would look like this:
+
+ C (6) -> B (2) -> A(2)
+ -> D (4)
+
+ What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
+ "4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
+ particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
+ is the reason that we would get things like 40000% previously with recursion.
+
+ This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
+ can't know exactly how many calls came from where, etc).
+
+ * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::ProfileClass):
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::getParent):
+ (WebCore::getHead):
+ (WebCore::getCallUID):
+ (WebCore::ProfileNodeClass):
+ * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
+ (WebInspector.BottomUpProfileDataGridTree):
+ (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
+ (WebInspector.BottomUpProfileDataGridNode):
+ (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
+ (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
+ (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
+ (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
+ (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGrid.prototype.insertChild):
+ (WebInspector.DataGrid.prototype.removeChild):
+ (WebInspector.DataGrid.prototype.removeChildren):
+ (WebInspector.DataGridNode.prototype.set hasChildren):
+ (WebInspector.DataGridNode.prototype.get hasChildren):
+ * inspector/front-end/ProfileDataGridTree.js: Added.
+ (WebInspector.ProfileDataGridNode):
+ (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
+ (WebInspector.ProfileDataGridNode.prototype.get data):
+ (WebInspector.ProfileDataGridNode.prototype.createCell):
+ (WebInspector.ProfileDataGridNode.prototype.select):
+ (WebInspector.ProfileDataGridNode.prototype.deselect):
+ (WebInspector.ProfileDataGridNode.prototype.expand):
+ (WebInspector.ProfileDataGridNode.prototype.insertChild):
+ (WebInspector.ProfileDataGridNode.prototype.removeChild):
+ (WebInspector.ProfileDataGridNode.prototype.removeChildren):
+ (WebInspector.ProfileDataGridNode.prototype.findChild):
+ (WebInspector.ProfileDataGridNode.prototype.get averageTime):
+ (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
+ (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
+ (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
+ (WebInspector.ProfileDataGridNode.prototype._save):
+ (WebInspector.ProfileDataGridNode.prototype._restore):
+ (WebInspector.ProfileDataGridNode.prototype._merge):
+ (WebInspector.ProfileDataGridTree):
+ (WebInspector.ProfileDataGridTree.prototype.get expanded):
+ (WebInspector.ProfileDataGridTree.prototype.appendChild):
+ (WebInspector.ProfileDataGridTree.prototype.insertChild):
+ (WebInspector.ProfileDataGridTree.prototype.removeChildren):
+ (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
+ (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
+ (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
+ (WebInspector.ProfileDataGridTree.propertyComparator):
+ * inspector/front-end/ProfileView.js:
+ (WebInspector.ProfileView):
+ (WebInspector.ProfileView.prototype.set profile):
+ (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
+ (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
+ (WebInspector.ProfileView.prototype.get currentTree):
+ (WebInspector.ProfileView.prototype.set currentTree):
+ (WebInspector.ProfileView.prototype.get topDownTree):
+ (WebInspector.ProfileView.prototype.get bottomUpTree):
+ (WebInspector.ProfileView.prototype.refresh):
+ (WebInspector.ProfileView.prototype.refreshVisibleData):
+ (WebInspector.ProfileView.prototype.refreshShowAsPercents):
+ (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
+ (WebInspector.ProfileView.prototype.performSearch):
+ (WebInspector.ProfileView.prototype._changeView):
+ (WebInspector.ProfileView.prototype._focusClicked):
+ (WebInspector.ProfileView.prototype._excludeClicked):
+ (WebInspector.ProfileView.prototype._resetClicked):
+ (WebInspector.ProfileView.prototype._sortProfile):
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.showProfile):
+ (WebInspector.ProfilesPanel.prototype.showView):
+ (WebInspector.ProfilesPanel.prototype.searchMatchFound):
+ * inspector/front-end/TopDownProfileDataGridTree.js: Added.
+ (WebInspector.TopDownProfileDataGridNode):
+ (WebInspector.TopDownProfileDataGridNode.prototype._populate):
+ (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
+ (WebInspector.TopDownProfileDataGridTree):
+ (WebInspector.TopDownProfileDataGridTree.prototype.focus):
+ (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/inspector.html:
+
+2009-04-23 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Use static functions (and a couple templates)
+ to further reduce the amount of copy/paste code in SVGRenderTreeAsText
+
+ No test changes, only code cleanup.
+
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::writeNameValuePair):
+ (WebCore::writeNameAndQuotedValue):
+ (WebCore::writeIfNotEmpty):
+ (WebCore::writeIfNotDefault):
+ (WebCore::writeStyle):
+ (WebCore::writePositionAndStyle):
+ (WebCore::operator<<):
+
+2009-04-23 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ SVGRenderTreeAsText cleanup/code sharing.
+
+ No test changes, only code cleanup.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::firstRunOrigin):
+ * rendering/RenderText.h:
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::writeStandardPrefix):
+ (WebCore::writeChildren):
+ (WebCore::write):
+ (WebCore::writeRenderResources):
+
+2009-04-23 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ WebCore part of fix for <rdar://problem/6333461> REGRESSION
+ (r36864-r36869): Dragging stocks widget scrollbar drags the whole
+ widget
+
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::isScrollbar):
+ * platform/Widget.h:
+ (WebCore::Widget::isScrollbar):
+
+2009-04-23 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Adam Roben.
+
+ <rdar://problem/6808109> "Deletion UI" is not available for many
+ portions of HTML content
+
+ This patch makes the deletion UI show up in some new situations:
+ 1) If a block's background color is different from its parent's
+ 2) If a block has a background image.
+ 3) If a block has a single visible border.
+ However the block must now not only be at least a minimum width and
+ height, but also exceed a minimum area. In practice this has led to
+ much better element selection.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+
+2009-04-23 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Adding XMLTokenizerScope.cpp to the build.
+
+ * WebCoreSources.bkl:
+
+2009-04-23 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
+ https://bugs.webkit.org/show_bug.cgi?id=25312
+
+ I was unable to reproduce the problem, but I'm pretty sure this will fix it.
+
+ * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
+ Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
+
+2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25313
+ Missing scroll bars in GMail.
+
+ Test: fast/overflow/overflow-y-scroll.html
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
+ scroll mode.
+
+2009-04-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
+ some messages in WebCore::canHaveChildrenForEditing
+
+ Test: editing/selection/extend-by-line-anonymous-content-crash.html
+
+ * editing/visible_units.cpp:
+ (WebCore::previousLinePosition): Null-check node. If p is not an
+ editable position, then closestLeafChildForXPos() may have returned a
+ non-editable box, and in particular one belonging to anonymous content.
+ If node is 0, fall back on RenderObject::positionForPoint, which
+ finds the closest position in non-anonymous content.
+ (WebCore::nextLinePosition): Ditto.
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createVisiblePosition): Fixed a typo.
+
+2009-04-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
+
+ Test: http/tests/history/back-to-post.php
+
+ * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ Apply a new cache policy if it changed after the platform request was first created.
+ While at it, also made sure to update timeout.
+
+2009-04-23 Zan Dobersek <zandobersek@gmail.com>
+
+ Reviewed by Gustavo Noronha.
+
+ When creating a new drawable object, collect system's
+ information about the best depth it can provide and use it
+ in a new colormap that the new drawable requires.
+
+ * platform/graphics/gtk/ImageGtk.cpp:
+ (WebCore::BitmapImage::getGdkPixbuf):
+
+2009-04-23 Zan Dobersek <zandobersek@gmail.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15654
+ GdkPixbuf support for ImageCairo
+
+ Add support for converting a Cairo surface to a GdkPixbuf.
+
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/Image.h:
+ (WebCore::Image::getGdkPixbuf):
+ * platform/graphics/gtk/ImageGtk.cpp:
+ (WebCore::BitmapImage::getGdkPixbuf):
+
+2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.
+
+ Basically, what we want is to send wheel events to the plugin *only*
+ when it has focus, or else send it to the parent frame.
+
+ This is a work around, and basically what we do, is to steal the
+ wheel events from the plugin, modify the window ID, and put the
+ event back into the Qt event loop.
+
+ * plugins/qt/PluginContainerQt.cpp:
+ (PluginClientWrapper::PluginClientWrapper):
+ (PluginClientWrapper::~PluginClientWrapper):
+ (PluginClientWrapper::x11Event):
+ (PluginContainerQt::PluginContainerQt):
+ (PluginContainerQt::~PluginContainerQt):
+ (PluginContainerQt::on_clientClosed):
+ (PluginContainerQt::on_clientIsEmbedded):
+ (PluginContainerQt::redirectWheelEventsToParent):
+ (PluginContainerQt::x11Event):
+ (PluginContainerQt::focusInEvent):
+ * plugins/qt/PluginContainerQt.h:
+
+2009-04-22 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Maciej Stachowiak
+
+ <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
+
+ For most loads, we were consulting the navigation policy delegate twice. Once from FrameLoader before
+ the load started and once from MainResourceLoader in its willSendRequest callback.
+
+ In the past we tried removing MainResourceLoader's call altogether. This caused a regression where urls
+ that redirect to a url handled by an external application would no longer work in Safari. It probably
+ also broke other WebKit apps in subtle ways.
+
+ Changing MainResourceLoader to make the check only on redirects fixes both bugs. We now only call the
+ policy delegate once for most standard loads, but we do correctly call it a second time for redirects.
+
+ Tests: http/tests/misc/policy-delegate-called-twice.html
+ http/tests/misc/redirect-to-external-url.html
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.
+
+2009-04-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix for <rdar://problem/6800695>
+
+ Add a hack to only allow navigating (via a link from a http page)
+ to feed: urls (same for feeds: and feedsearch:) that map to http:
+ or https: via their nested protocol. This includes both feed://example.com
+ and feed:http://example.com.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::isFeedWithNestedProtocolInHTTPFamily):
+ (WebCore::FrameLoader::loadFrameRequest):
+
+2009-04-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Autogenerate the XMLHttpRequest constructor getter/setter for the
+ WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
+ file.
+
+ * DerivedSources.make: Remove JSWorkerContextBase.lut.h
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+
+ * bindings/js/JSWorkerContextBase.cpp:
+ * bindings/js/JSWorkerContextBase.h: Remove code to support hand written
+ code for XMLHttpRequest constructor lookup and shadowing.
+
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes.
+ (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of
+ cached constructor lookup.
+ * workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not
+ V8 specific.
+
+2009-04-22 Darin Adler <darin@apple.com>
+
+ * page/Navigator.idl: Touch this file to fix build since Geolocation
+ configuration was recently turned off.
+
+2009-04-22 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25322
+ Can't delete empty paragraph after a block image
+
+ Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
+ because of some code that avoided problems that would arise from Positions that would go
+ bad during deletion.
+
+ We have several checks that prevent us from using bad Positions, this one in particular
+ was added to avoid bad Positions that result from text removal. So, I removed the check
+ and started correctly updating m_downstreamEnd during text removal so that it doesn't go
+ bad. m_upstreamStart doesn't need to be updated during text removal, since only text
+ after it will ever be removed.
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::deleteTextFromNode):
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+ (WebCore::DeleteSelectionCommand::mergeParagraphs):
+
+2009-04-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
+
+ Make mouseUp target the correct frame when the original
+ mousedown made the drag non-capturing.
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passSubframeEventToSubframe):
+
+2009-04-22 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
+
+ This is the first step of allowing drag events to match the behaviour
+ of mouse move events when the default action of the initial mouse down
+ is prevented. Remaining issue is that the final mouse up event still
+ targets the original root frame.
+
+ Test: fast/events/mouse-drag-from-frame-to-other-frame.html
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passSubframeEventToSubframe):
+
+2009-04-22 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson
+
+ <rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
+ <rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting
+
+ When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
+ layer backing under some circumstances. However, drawing the view via
+ displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
+ So when in the media document, we draw via displayRectIgnoringOpacity:.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::paint):
+
+2009-04-22 Timothy Hatcher <timothy@apple.com>
+
+ Fix a crash in Mail when forwarding a specific HTML email.
+ Caused by the fix for <rdar://problem/6512520> (r42096).
+ Unable to create a test case that works outside of Mail.
+
+ <rdar://problem/6796069>
+
+ Reviewed by Ada Chan.
+
+ * editing/markup.cpp:
+ (WebCore::createMarkup): Null check pastEnd before trying to
+ call Range::compareBoundaryPoints.
+
+2009-04-22 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Darin Adler.
+
+ Fix for <rdar://problem/6816957>
+ Turn off Geolocation by default
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2009-04-22 Eric Seidel <eric@webkit.org>
+
+ Rubber-stamped by David Hyatt.
+
+ Change RenderSVGImage to dump as RenderSVGImage instead of RenderImage
+
+ * rendering/RenderSVGImage.h:
+ (WebCore::RenderSVGImage::renderName):
+
+2009-04-21 Timothy Hatcher <timothy@apple.com>
+
+ Fix a crash on Gmail when they remove a "before unload" event listener when
+ it was never added to the pending map in the first place.
+
+ <rdar://problem/6814144>
+
+ Reviewed by Darin Adler.
+
+ * page/DOMWindow.cpp:
+ (WebCore::allowsPendingBeforeUnloadListeners): Renamed from shouldAddPendingBeforeUnloadListener.
+ (WebCore::DOMWindow::addEventListener): Call allowsPendingBeforeUnloadListeners now.
+ (WebCore::DOMWindow::removeEventListener): Call allowsPendingBeforeUnloadListeners before
+ removing the before unload listener.
+ (WebCore::DOMWindow::clearAttributeEventListener): Ditto.
+
+2009-04-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
+
+ Reviewed by Ariya Hidayat.
+
+ Made windowed plugins move/resize synchronized with the painting, so
+ that windowed plugins are not moved before the rest of the parent
+ frame during scrolling.
+
+ * plugins/qt/PluginContainerQt.cpp:
+ (PluginContainerQt::PluginContainerQt):
+ (PluginContainerQt::requestGeometry):
+ (PluginContainerQt::adjustGeometry):
+ * plugins/qt/PluginContainerQt.h:
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::paint):
+
+2009-04-22 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Ariya Hidayat.
+
+ Fix various bugs in the X11 Qt plugin focus handling.
+
+ Notify the focus controller on activation/deactivation of the plugin and
+ set focus on the plugin's element when it receives the window system
+ focus.
+
+ * WebCore.pro: Added PluginContainerQt to the Qt build.
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::focusPluginElement): New helper function, moved from PluginViewWin.
+ * plugins/PluginView.h:
+ (WebCore::PluginView::parentFrame): Added parent frame accessor.
+ * plugins/qt/PluginContainerQt.cpp: Added.
+ (PluginContainerQt::PluginContainerQt):
+ (PluginContainerQt::focusInEvent): Set the focus controller active on focus in events.
+ (PluginContainerQt::focusOutEvent): Deactivate the focus controller when loosing the focus.
+ * plugins/qt/PluginContainerQt.h: Added.
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::init): Allocate a PluginContainerQt instead of QX11EmbedContainer.
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::handleMouseEvent): Moved the code to set focus on the plugin element
+ to PluginView::focusPluginElement.
+
+2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
+
+ Reviewed by Ariya Hidayat.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25023
+ Delete reply in QNetworkReplyHandler::abort() to avoid leak.
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::abort):
+
+2009-04-21 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Allow the UI delegate to control cursor-setting.
+
+ Reviewed by Ada Chan.
+
+ * page/Chrome.cpp:
+ (WebCore::Chrome::setCursor):
+ Pass the call to the client.
+
+ * page/Chrome.h:
+
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::setCursor):
+ Stubbed; returns false.
+
+ * platform/Cursor.h:
+ Define PlatformCursorHandle for each platform.
+
+ * platform/win/WidgetWin.cpp:
+ Reordered some includes. Added an include of Page.h.
+ (WebCore::Widget::setCursor):
+ Fixed a typo in the comment about ignoreNextSetCursor. Get the Page, and
+ call its Chrome's setCursor() method with the passed cursor. Fall back
+ to SetCursor() if the Page is not available.
+
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::handleMouseEvent):
+ Remove an unused variable. Cleaned up some whitespace.
+
+2009-04-21 John Abd-El-Malek <jam@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Add a method to purge the Chromium plugin list cache.
+ https://bugs.webkit.org/show_bug.cgi?id=25318
+
+ * plugins/chromium/PluginDataChromium.cpp:
+ (WebCore::resetChromiumPluginCache):
+
+2009-04-21 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=25164> / <rdar://problem/6786319>.
+
+ We need to ensure that XMLTokenizer sets the current DocLoader before calling in to
+ any libxml2 methods that may trigger a load. The presence of a DocLoader indicates
+ that the load was originated by WebCore's use of libxml2 and that we should enforce
+ the same-origin policy on it. XMLTokenizer::initializeParserContext,
+ XMLTokenizer::doWrite and XMLTokenizer::doEnd were three methods that were not setting
+ the current DocLoader when they should have.
+
+ The XMLTokenizerScope class is introduced to simplify the pattern of saving, setting and
+ restoring the current DocLoader and libxml2 error handlers. The DocLoader and error handlers
+ are saved and set when the scope is allocated, and restored to their previous values when
+ the scope is exited.
+
+ Test: http/tests/security/xss-DENIED-xml-external-entity.xhtml
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizer.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::matchFunc):
+ (WebCore::shouldAllowExternalLoad):
+ (WebCore::openFunc):
+ (WebCore::XMLTokenizer::doWrite):
+ (WebCore::XMLTokenizer::initializeParserContext):
+ (WebCore::XMLTokenizer::doEnd):
+ (WebCore::xmlDocPtrForString):
+ * dom/XMLTokenizerScope.cpp:
+ (WebCore::XMLTokenizerScope::XMLTokenizerScope):
+ (WebCore::XMLTokenizerScope::~XMLTokenizerScope):
+ * dom/XMLTokenizerScope.h:
+ * xml/XSLStyleSheet.cpp:
+ (WebCore::XSLStyleSheet::parseString):
+ * xml/XSLTProcessor.cpp:
+
+2009-04-21 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/5874009>
+ Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::portAllowed):
+
+2009-04-21 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25320
+ Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If the enclosing block is the
+ root editable element and it contains no visible content, create a new block but don't try and move
+ content into it, since there's nothing for moveParagraphs to move.
+
+
+2009-04-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
+ https://bugs.webkit.org/show_bug.cgi?id=25162
+ rdar://problem/6764354
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
+ Later we may want to change this default to encompass other versions running on Mac.
+
+ * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
+ m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
+ the bit fields.
+
+ * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
+ I'm not sure the distinction here is serving us well at the moment. When converting from
+ global to local coordinates you want to do IntPoint - IntPoint and have the result be
+ another IntPoint, not an IntSize. And so on.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
+ separate coordinates less.
+ (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
+ Added separate cases to support the Mac and Windows behavior.
+ (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
+ computation of pointInContents closer to the place it's used.
+
+ * rendering/RenderBlock.h: Updated for the new private member function.
+
+2009-04-17 Timothy Hatcher <timothy@apple.com>
+
+ Change pending unload and beforeunload counts to store the listeners
+ in a single data structure that can be quickly iterated for dispatch.
+
+ <rdar://problem/6383352&6383379&6383940>
+
+ Reviewed by Darin Adler.
+
+ * WebCore.base.exp: Change what symbols are exported.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading): Remove count updating code
+ and move an if inside a block already checking m_frame->document().
+ * page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
+ * page/Chrome.h: Ditto.
+ * page/ChromeClient.h: Ditto.
+ * page/DOMWindow.cpp:
+ (WebCore::pendingUnloadEventListenerMap): Create a static map.
+ (WebCore::pendingBeforeUnloadEventListenerMap): Ditto.
+ (WebCore::addPendingEventListener): Add the event listener to the map.
+ (WebCore::removePendingEventListener): Remove the event listener from the map.
+ (WebCore::removePendingEventListeners): Remove all listeners for the window.
+ (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners.
+ (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event.
+ (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners.
+ (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event.
+ (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps.
+ (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed.
+ (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed.
+ (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners.
+ (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
+ * page/DOMWindow.h:
+ (WebCore::DOMWindow::frame): Changed to be const.
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::EventHandler): Remove count tracking code.
+ * page/EventHandler.h: Ditto.
+ * page/Page.cpp:
+ (WebCore::Page::Page): Ditto.
+ * page/Page.h: Ditto.
+
+2009-04-21 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19644
+ Text copied with Select All pastes with a indent but shouldn't
+ <rdar://problem/6102483>
+ Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
+
+ To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
+ a div that held properties and attributes from the fully selected body. To fix the above issues,
+ only do this if if the body has certain properties or attributes. We'll begin adding to this list as
+ necessary. For now it's just background colors and images. Tested copy/paste of nytimes, wired,
+ arstechnica, and several others.
+
+ Massive nesting can still happen, it will just be much less common.
+
+ * editing/markup.cpp:
+ (WebCore::createMarkup):
+
+2009-04-21 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25250
+ Allow platforms to snap the scroll thumb back to the drag origin
+ during a drag. Implement functions for Safari/Win and Chromium/Win
+ to do this snapping at distances approximating the native ones.
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::setValue):
+ (WebCore::Scrollbar::scroll):
+ (WebCore::Scrollbar::moveThumb):
+ (WebCore::Scrollbar::setCurrentPos):
+ (WebCore::Scrollbar::mouseMoved):
+ (WebCore::Scrollbar::mouseDown):
+ * platform/Scrollbar.h:
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
+ * platform/chromium/ScrollbarThemeChromium.h:
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
+ * platform/chromium/ScrollbarThemeChromiumWin.cpp:
+ (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
+ (WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
+ * platform/win/ScrollbarThemeWin.h:
+
+2009-04-21 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::eventParameterName): Remove unreachable code when SVG is
+ enabled.
+
+2009-04-21 Kevin Ollivier <kevino@theolliviers.com>
+
+ !ENABLE(SVG) build fix.
+
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::eventParameterName):
+
+2009-04-21 Dave Moore <davemoore@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25309
+ Better use AtomicStrings when calling from the V8
+ bindings into WebCore code.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+ * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
+
+2009-04-21 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25304: AX: Safari not identifying a secure text field
+ https://bugs.webkit.org/show_bug.cgi?id=25304
+
+ Secure text fields need to be able to return AXTitleUIElements.
+
+ Test: accessibility/secure-textfield-title-ui.html
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2009-04-21 Dan Bernstein <mitz@apple.com>
+
+ - fix the Tiger build
+
+ * page/mac/EventHandlerMac.mm:
+ (method_setImplementation):
+
+2009-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25271
+
+ Fix the build with disabled DOM storage or disabled database support.
+
+ * bindings/js/ScriptObjectQuarantine.cpp:
+ * bindings/js/ScriptObjectQuarantine.h:
+
+2009-04-21 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix.
+
+ Compile fix for r42633. const qualifier does not work
+ on a static method.
+
+ * dom/Document.h:
+ (WebCore::Document::isSVGDocument):
+
+2009-04-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler and John Sullivan.
+
+ - fix <rdar://problem/5914146> Crash at -[NSScrollView scrollWheel:]
+
+ -[NSScrollView scrollWheel:] runs a nested event-tracking run loop
+ in a mode that allows WebCore timers to fire and NSURLConnection
+ callbacks to be dispatched, which can release the NSScrollView and
+ cause it to be deallocated (one example is a DOM timer callback that
+ removes a subframe from the document). This leads to a crash in
+ -scrollView:.
+
+ The fix is to replace the implementation of -[NSScrollView scrollWheel:]
+ with one that optionally retains the receiver for the duration of the
+ call.
+
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::nsScrollViewScrollWheelShouldRetainSelf): Added.
+ (WebCore::setNSScrollViewScrollWheelShouldRetainSelf): Added. Replaces
+ the implementation of -[NSScrollView scrollWheel:] with the
+ self-retaining one, and sets a static boolean that tells it whether to
+ retain the receiver around the call to the original implementation.
+ (WebCore::selfRetainingNSScrollViewScrollWheel): Added. If
+ setNSScrollViewScrollWheelShouldRetainSelf(true) was called and this
+ function is executing on the main thread, it retains the NSScrollView,
+ invokes the original -[NSScrollView scrollWheel:], then releases the
+ view. Otherwise it just calls through to the original implementation.
+ (WebCore::EventHandler::passWheelEventToWidget): Added calls to
+ setNSScrollViewScrollWheelShouldRetainSelf() around the call to
+ -scrollWheel:.
+
+2009-04-21 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Tiger crash fix: Put VM tags in their own header file, and fixed up the
+ #ifdefs so they're not used on Tiger.
+
+ * ForwardingHeaders/wtf/VMTags.h: Copied from WebCore/ForwardingHeaders/wtf/HashTraits.h.
+
+2009-04-21 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Implement AtkComponent interface.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (core):
+
+2009-04-21 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Only implement AtkAction interface if we actually have an action.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25290
+ REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document
+
+ Test: fast/dom/xmlhttprequest-constructor-in-detached-document.html
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSAudioConstructor.h:
+ * bindings/js/JSDOMGlobalObject.h:
+ (WebCore::getDOMConstructor):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSImageConstructor.h:
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
+ * bindings/js/JSMessageChannelConstructor.h:
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ * bindings/js/JSOptionConstructor.h:
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ Avoid accessing JSDOMGlobalObject via ScriptExecutionContext, since it may not
+ work during frame teardown.
+
+2009-04-20 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber stamped by Darin Adler and Sam Weinig.
+
+ Renamed "*InlineEventListener*" => "*AttributeEventListener*", and
+ "isInline" => "isAttribute".
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSEventListener::handleEvent):
+ (WebCore::JSEventListener::virtualisAttribute):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSEventListener::create):
+ (WebCore::JSEventListener::isAttribute):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::createAttributeEventListener):
+ * bindings/js/JSLazyEventListener.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/Element.cpp:
+ (WebCore::Element::setWindowAttributeEventListener):
+ * dom/Element.h:
+ * dom/EventListener.h:
+ (WebCore::EventListener::isAttribute):
+ (WebCore::EventListener::virtualisAttribute):
+ * dom/Node.cpp:
+ (WebCore::Node::clearAttributeEventListener):
+ (WebCore::Node::setAttributeEventListener):
+ (WebCore::Node::getAttributeEventListener):
+ (WebCore::Node::onabort):
+ (WebCore::Node::setOnabort):
+ (WebCore::Node::onblur):
+ (WebCore::Node::setOnblur):
+ (WebCore::Node::onchange):
+ (WebCore::Node::setOnchange):
+ (WebCore::Node::onclick):
+ (WebCore::Node::setOnclick):
+ (WebCore::Node::oncontextmenu):
+ (WebCore::Node::setOncontextmenu):
+ (WebCore::Node::ondblclick):
+ (WebCore::Node::setOndblclick):
+ (WebCore::Node::onerror):
+ (WebCore::Node::setOnerror):
+ (WebCore::Node::onfocus):
+ (WebCore::Node::setOnfocus):
+ (WebCore::Node::oninput):
+ (WebCore::Node::setOninput):
+ (WebCore::Node::onkeydown):
+ (WebCore::Node::setOnkeydown):
+ (WebCore::Node::onkeypress):
+ (WebCore::Node::setOnkeypress):
+ (WebCore::Node::onkeyup):
+ (WebCore::Node::setOnkeyup):
+ (WebCore::Node::onload):
+ (WebCore::Node::setOnload):
+ (WebCore::Node::onmousedown):
+ (WebCore::Node::setOnmousedown):
+ (WebCore::Node::onmousemove):
+ (WebCore::Node::setOnmousemove):
+ (WebCore::Node::onmouseout):
+ (WebCore::Node::setOnmouseout):
+ (WebCore::Node::onmouseover):
+ (WebCore::Node::setOnmouseover):
+ (WebCore::Node::onmouseup):
+ (WebCore::Node::setOnmouseup):
+ (WebCore::Node::onmousewheel):
+ (WebCore::Node::setOnmousewheel):
+ (WebCore::Node::onbeforecut):
+ (WebCore::Node::setOnbeforecut):
+ (WebCore::Node::oncut):
+ (WebCore::Node::setOncut):
+ (WebCore::Node::onbeforecopy):
+ (WebCore::Node::setOnbeforecopy):
+ (WebCore::Node::oncopy):
+ (WebCore::Node::setOncopy):
+ (WebCore::Node::onbeforepaste):
+ (WebCore::Node::setOnbeforepaste):
+ (WebCore::Node::onpaste):
+ (WebCore::Node::setOnpaste):
+ (WebCore::Node::ondragenter):
+ (WebCore::Node::setOndragenter):
+ (WebCore::Node::ondragover):
+ (WebCore::Node::setOndragover):
+ (WebCore::Node::ondragleave):
+ (WebCore::Node::setOndragleave):
+ (WebCore::Node::ondrop):
+ (WebCore::Node::setOndrop):
+ (WebCore::Node::ondragstart):
+ (WebCore::Node::setOndragstart):
+ (WebCore::Node::ondrag):
+ (WebCore::Node::setOndrag):
+ (WebCore::Node::ondragend):
+ (WebCore::Node::setOndragend):
+ (WebCore::Node::onreset):
+ (WebCore::Node::setOnreset):
+ (WebCore::Node::onresize):
+ (WebCore::Node::setOnresize):
+ (WebCore::Node::onscroll):
+ (WebCore::Node::setOnscroll):
+ (WebCore::Node::onsearch):
+ (WebCore::Node::setOnsearch):
+ (WebCore::Node::onselect):
+ (WebCore::Node::setOnselect):
+ (WebCore::Node::onselectstart):
+ (WebCore::Node::setOnselectstart):
+ (WebCore::Node::onsubmit):
+ (WebCore::Node::setOnsubmit):
+ (WebCore::Node::onunload):
+ (WebCore::Node::setOnunload):
+ * dom/Node.h:
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::parseMappedAttribute):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::parseMappedAttribute):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::parseMappedAttribute):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setAttributeEventListener):
+ (WebCore::DOMWindow::clearAttributeEventListener):
+ (WebCore::DOMWindow::getAttributeEventListener):
+ (WebCore::DOMWindow::onabort):
+ (WebCore::DOMWindow::setOnabort):
+ (WebCore::DOMWindow::onblur):
+ (WebCore::DOMWindow::setOnblur):
+ (WebCore::DOMWindow::onchange):
+ (WebCore::DOMWindow::setOnchange):
+ (WebCore::DOMWindow::onclick):
+ (WebCore::DOMWindow::setOnclick):
+ (WebCore::DOMWindow::ondblclick):
+ (WebCore::DOMWindow::setOndblclick):
+ (WebCore::DOMWindow::onerror):
+ (WebCore::DOMWindow::setOnerror):
+ (WebCore::DOMWindow::onfocus):
+ (WebCore::DOMWindow::setOnfocus):
+ (WebCore::DOMWindow::onkeydown):
+ (WebCore::DOMWindow::setOnkeydown):
+ (WebCore::DOMWindow::onkeypress):
+ (WebCore::DOMWindow::setOnkeypress):
+ (WebCore::DOMWindow::onkeyup):
+ (WebCore::DOMWindow::setOnkeyup):
+ (WebCore::DOMWindow::onload):
+ (WebCore::DOMWindow::setOnload):
+ (WebCore::DOMWindow::onmousedown):
+ (WebCore::DOMWindow::setOnmousedown):
+ (WebCore::DOMWindow::onmousemove):
+ (WebCore::DOMWindow::setOnmousemove):
+ (WebCore::DOMWindow::onmouseout):
+ (WebCore::DOMWindow::setOnmouseout):
+ (WebCore::DOMWindow::onmouseover):
+ (WebCore::DOMWindow::setOnmouseover):
+ (WebCore::DOMWindow::onmouseup):
+ (WebCore::DOMWindow::setOnmouseup):
+ (WebCore::DOMWindow::onmousewheel):
+ (WebCore::DOMWindow::setOnmousewheel):
+ (WebCore::DOMWindow::onreset):
+ (WebCore::DOMWindow::setOnreset):
+ (WebCore::DOMWindow::onresize):
+ (WebCore::DOMWindow::setOnresize):
+ (WebCore::DOMWindow::onscroll):
+ (WebCore::DOMWindow::setOnscroll):
+ (WebCore::DOMWindow::onsearch):
+ (WebCore::DOMWindow::setOnsearch):
+ (WebCore::DOMWindow::onselect):
+ (WebCore::DOMWindow::setOnselect):
+ (WebCore::DOMWindow::onsubmit):
+ (WebCore::DOMWindow::setOnsubmit):
+ (WebCore::DOMWindow::onunload):
+ (WebCore::DOMWindow::setOnunload):
+ (WebCore::DOMWindow::onbeforeunload):
+ (WebCore::DOMWindow::setOnbeforeunload):
+ (WebCore::DOMWindow::onwebkitanimationstart):
+ (WebCore::DOMWindow::setOnwebkitanimationstart):
+ (WebCore::DOMWindow::onwebkitanimationiteration):
+ (WebCore::DOMWindow::setOnwebkitanimationiteration):
+ (WebCore::DOMWindow::onwebkitanimationend):
+ (WebCore::DOMWindow::setOnwebkitanimationend):
+ (WebCore::DOMWindow::onwebkittransitionend):
+ (WebCore::DOMWindow::setOnwebkittransitionend):
+ * page/DOMWindow.h:
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::parseMappedAttribute):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::onabort):
+ (WebCore::SVGElementInstance::setOnabort):
+ (WebCore::SVGElementInstance::onblur):
+ (WebCore::SVGElementInstance::setOnblur):
+ (WebCore::SVGElementInstance::onchange):
+ (WebCore::SVGElementInstance::setOnchange):
+ (WebCore::SVGElementInstance::onclick):
+ (WebCore::SVGElementInstance::setOnclick):
+ (WebCore::SVGElementInstance::oncontextmenu):
+ (WebCore::SVGElementInstance::setOncontextmenu):
+ (WebCore::SVGElementInstance::ondblclick):
+ (WebCore::SVGElementInstance::setOndblclick):
+ (WebCore::SVGElementInstance::onerror):
+ (WebCore::SVGElementInstance::setOnerror):
+ (WebCore::SVGElementInstance::onfocus):
+ (WebCore::SVGElementInstance::setOnfocus):
+ (WebCore::SVGElementInstance::oninput):
+ (WebCore::SVGElementInstance::setOninput):
+ (WebCore::SVGElementInstance::onkeydown):
+ (WebCore::SVGElementInstance::setOnkeydown):
+ (WebCore::SVGElementInstance::onkeypress):
+ (WebCore::SVGElementInstance::setOnkeypress):
+ (WebCore::SVGElementInstance::onkeyup):
+ (WebCore::SVGElementInstance::setOnkeyup):
+ (WebCore::SVGElementInstance::onload):
+ (WebCore::SVGElementInstance::setOnload):
+ (WebCore::SVGElementInstance::onmousedown):
+ (WebCore::SVGElementInstance::setOnmousedown):
+ (WebCore::SVGElementInstance::onmousemove):
+ (WebCore::SVGElementInstance::setOnmousemove):
+ (WebCore::SVGElementInstance::onmouseout):
+ (WebCore::SVGElementInstance::setOnmouseout):
+ (WebCore::SVGElementInstance::onmouseover):
+ (WebCore::SVGElementInstance::setOnmouseover):
+ (WebCore::SVGElementInstance::onmouseup):
+ (WebCore::SVGElementInstance::setOnmouseup):
+ (WebCore::SVGElementInstance::onmousewheel):
+ (WebCore::SVGElementInstance::setOnmousewheel):
+ (WebCore::SVGElementInstance::onbeforecut):
+ (WebCore::SVGElementInstance::setOnbeforecut):
+ (WebCore::SVGElementInstance::oncut):
+ (WebCore::SVGElementInstance::setOncut):
+ (WebCore::SVGElementInstance::onbeforecopy):
+ (WebCore::SVGElementInstance::setOnbeforecopy):
+ (WebCore::SVGElementInstance::oncopy):
+ (WebCore::SVGElementInstance::setOncopy):
+ (WebCore::SVGElementInstance::onbeforepaste):
+ (WebCore::SVGElementInstance::setOnbeforepaste):
+ (WebCore::SVGElementInstance::onpaste):
+ (WebCore::SVGElementInstance::setOnpaste):
+ (WebCore::SVGElementInstance::ondragenter):
+ (WebCore::SVGElementInstance::setOndragenter):
+ (WebCore::SVGElementInstance::ondragover):
+ (WebCore::SVGElementInstance::setOndragover):
+ (WebCore::SVGElementInstance::ondragleave):
+ (WebCore::SVGElementInstance::setOndragleave):
+ (WebCore::SVGElementInstance::ondrop):
+ (WebCore::SVGElementInstance::setOndrop):
+ (WebCore::SVGElementInstance::ondragstart):
+ (WebCore::SVGElementInstance::setOndragstart):
+ (WebCore::SVGElementInstance::ondrag):
+ (WebCore::SVGElementInstance::setOndrag):
+ (WebCore::SVGElementInstance::ondragend):
+ (WebCore::SVGElementInstance::setOndragend):
+ (WebCore::SVGElementInstance::onreset):
+ (WebCore::SVGElementInstance::setOnreset):
+ (WebCore::SVGElementInstance::onresize):
+ (WebCore::SVGElementInstance::setOnresize):
+ (WebCore::SVGElementInstance::onscroll):
+ (WebCore::SVGElementInstance::setOnscroll):
+ (WebCore::SVGElementInstance::onsearch):
+ (WebCore::SVGElementInstance::setOnsearch):
+ (WebCore::SVGElementInstance::onselect):
+ (WebCore::SVGElementInstance::setOnselect):
+ (WebCore::SVGElementInstance::onselectstart):
+ (WebCore::SVGElementInstance::setOnselectstart):
+ (WebCore::SVGElementInstance::onsubmit):
+ (WebCore::SVGElementInstance::setOnsubmit):
+ (WebCore::SVGElementInstance::onunload):
+ (WebCore::SVGElementInstance::setOnunload):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+
+2009-04-20 Geoffrey Garen <ggaren@apple.com>
+
+ Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
+
+ Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
+ they broke the Tiger and Windows buildbots.
+
+ * css/html4.css:
+ * css/themeWin.css:
+ * platform/graphics/SimpleFontData.cpp:
+ * platform/graphics/SimpleFontData.h:
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ * rendering/RenderTextControl.cpp:
+ * rendering/RenderTextControlMultiLine.cpp:
+ * rendering/RenderTextControlSingleLine.cpp:
+
+2009-04-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Adam Roben.
+
+ One last loose end, discovered using COLLECT_ON_EVERY_ALLOCATION, for
+ https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::mark): Don't ASSERT that an ElementInstance's
+ correspondingElement has a JS wrapper. If a GC falls exactly between the
+ allocation of the ElementInstance wrapper and the correspondingElement
+ wrapper, the correspondingElement won't have a wrapper at the time we
+ mark the ElementInstance's wrapper.
+
+2009-04-20 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Mark Rowe
+
+ Clean builds are broken on case-sensitive filesystems. Let's fix, shall we?
+
+ * platform/graphics/SimpleFontData.cpp: Remove "String.h" include. Ojan probably intended to include
+ "PlatformString.h" which was unnecessary because it is pulled in through other headers. This wasn't a
+ build failure on case-insensitive file systems because those systems would find the system <string.h>, averting
+ the warning.
+
+2009-04-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Last patch for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Converted "lazy" event listeners to be unprotected, just like all the others.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSEventListener::jsFunction):
+ (WebCore::JSEventListener::markJSFunction):
+ (WebCore::JSEventListener::handleEvent):
+ (WebCore::JSEventListener::virtualIsInline):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSEventListener::isInline): Merged JSAbstractEventListener
+ into JSEventListener. Now that the only difference between JSEventListener
+ and JSLazyEventListener is that JSLazyEventListener compiles lazily,
+ there's no need for an abstract base class.
+
+ * bindings/js/JSLazyEventListener.cpp: Converted JSLazyEventListener to
+ inherit from JSEventListener and match its un-GC-protected behavior.
+ (WebCore::JSLazyEventListener::JSLazyEventListener): ditto
+ (WebCore::JSLazyEventListener::parseCode): ditto
+ (WebCore::createInlineEventListener): When creating a lazy event listener,
+ ensure that the related node has a JS wrapper to mark the listener. Since
+ the parser makes these listeners, it's possible that no JS reference has
+ been made to the node yet.
+ * bindings/js/JSLazyEventListener.h: ditto
+
+ * dom/EventListener.h:
+ (WebCore::EventListener::clearJSFunction): Removed an usused function.
+
+2009-04-20 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25299
+ Don't bound caret to root line box if it is still inside its containing block
+
+ Can't yet write tests for behavior of non-standard caret widths.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::localCaretRect):
+
+2009-04-20 Steve Falkenburg <sfalken@apple.com>
+
+ Separate JavaScriptCore.dll from WebKit.dll.
+ Slight performance improvement or no change on benchmarks.
+
+ Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
+ and simplifies standalone JavaScriptCore builds.
+
+ Reviewed by Oliver Hunt.
+
+ * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
+
+2009-04-20 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6722845> In the Cocoa event model, NPWindow's window field should be null
+
+ * bridge/npapi.h:
+ (_NPCocoaEvent::):
+ Add a CGContextRef member to the draw struct. Add an NPCoordinateSpace enum.
+
+ * plugins/npfunctions.h:
+ Add a prototype for NPN_ConvertPoint.
+
+2009-04-10 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Make textarea and text input metrics more closely match IEs.
+ https://bugs.webkit.org/show_bug.cgi?id=15312
+
+ This involves:
+ -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
+ -set textarea width to cols*avgCharWidth
+ -Make default CSS match IEs
+ -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
+
+ Those values for textarea and inputs were derived by doing a ton of manual
+ testing of IE's width values for various textareas and fonts.
+
+ To get the average and max character width of a font, we do the following
+ for each platform:
+ -Win: TextMetrics expose avgCharWidth and maxCharWidth
+ -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
+ maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
+ -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
+ maxCharWidth = max of avgCharWidth and m_ascent
+ -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
+ If either one is not there, then calculate the value using the Linux approach.
+
+ Linux ports could probably dig into the OS/2 table as well, but I'll leave
+ that up to them to implement.
+
+ Tests: fast/forms/text-control-intrinsic-widths.html
+ fast/forms/textarea-metrics.html
+ svg/custom/svg-fonts-in-text-controls.html
+
+ * css/html4.css:
+ * css/themeWin.css:
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData):
+ (WebCore::SimpleFontData::initCharWidths):
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::maxCharWidth):
+ (WebCore::SimpleFontData::avgCharWidth):
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::initGDIFont):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformCharWidthInit):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::calcPrefWidths):
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+
+2009-04-17 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Remove m_absoluteBounds hack from SVG renderers and move outlineBoundsForRepaint into RenderSVGModelObject
+ https://bugs.webkit.org/show_bug.cgi?id=25276
+
+ This also exposed a buggy paint check in RenderSVGContainer::layout()
+ we should repaint if we are self painting OR if our kids changed, not AND.
+
+ Writing real outlineBoundsForRepaint required writing a mapLocalToContainer() function
+
+ No functional changes, thus no tests.
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::localToParentTransform):
+ (WebCore::RenderPath::layout):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::mapLocalToContainer):
+ (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::localToParentTransformWithoutCSSParentOffset):
+ (WebCore::RenderSVGRoot::localToParentTransform):
+ (WebCore::RenderSVGRoot::computeRectForRepaint):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::layout):
+
+2009-04-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=25282
+
+ outlineBoundsForRepaint() should compute a quad relative to the
+ repaintContainer. This fixes the repaint issues originally fixed in
+ https://bugs.webkit.org/show_bug.cgi?id=12885 for elements in compositing layers.
+ Failure was only apparent when building with ACCELERATED_COMPOSITING enabled.
+
+ Tests: compositing/repaint/content-into-overflow.html
+ compositing/repaint/overflow-into-content.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::outlineBoundsForRepaint):
+
+2009-04-20 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Tim Hatcher.
+
+ Add licenses for xcconfig files.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ * Configurations/FeatureDefines.xcconfig:
+ * Configurations/Version.xcconfig:
+ * Configurations/WebCore.xcconfig:
+
+2009-04-20 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25261
+ Implement the V8 binding for DOMWindow.event similarly to JSC, by using
+ the custom getter boilerplate from the IDL file.
+ Also, stub out DOMWindow.crypto which is defined by the idl.
+
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::invokeEventHandler):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+
+2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25243
+ Crash when data:// loads are cancelled
+
+ Properly handle cancellation of the load for data:// loads. This
+ fixes crashing in the followin test:
+
+ plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::parseDataUrl):
+
+2009-04-19 Dan Bernstein <mitz@apple.com>
+
+ - maybe fix release builds
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::notifyFinished):
+
+2009-04-19 Dan Bernstein <mitz@apple.com>
+
+ - not fix release builds
+
+ * dom/Document.cpp:
+ (WebCore::Document::executeScriptSoonTimerFired):
+
+2009-04-19 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link
+ does nothing the second time search results are opened
+
+ Test: fast/dom/HTMLScriptElement/nested-execution.html
+
+ Instead of executing scripts as soon as they finish loading, which may
+ happen synchronously during execution of another script, defer their
+ execution until the next run loop iteration, using a queue that is
+ similar to the HTML5 notion of the "list of scripts that will execute as
+ soon as possible", and in my testing was consistent with how Firefox
+ behaved.
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document): Initialize m_executeScriptSoonTimer.
+ (WebCore::Document::~Document): deref() script elements in
+ m_scriptsToExecuteSoon.
+ (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the
+ scripts in m_scriptsToExecuteSoon and deref()s them.
+ (WebCore::Document::executeScriptSoon): Added. Appends to
+ m_scriptsToExecuteSoon and ref()s the script element, which keeps the
+ ScriptElementData alive as well.
+ * dom/Document.h:
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested.
+ (WebCore::ScriptElementData::requestScript): Set m_requested to true, to
+ prevent further load requests.
+ (WebCore::ScriptElementData::execute): Added. Moved the code from
+ notifyFinished() which should not execute synchronously here, to be
+ called by the Document on a 0-interval timer.
+ (WebCore::ScriptElementData::notifyFinished): Moved the code to
+ dispatch events and evaluate the script, which should not execute
+ synchronously, out of here.
+ (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for
+ m_requested instead of m_cachedScript, because the latter is cleared
+ before the script is evaluated.
+ * dom/ScriptElement.h:
+
+2009-04-19 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Antti Koivisto and Darin Adler.
+
+ <rdar://problem/6127705> Excessive memory consumption on image load failure
+
+ When we fail to decode an image we clear most of the image data, but not the
+ input data itself, which can be backed by a CFData object that itself holds onto
+ a few hundred Kbs of memory. This patch merely ensures that this buffer gets
+ cleared.
+
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::error):
+
+2009-04-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add hooks so sudden termination will not cause loss of icons or local storage.
+ rdar://problem/5951701
+
+ * loader/icon/IconDatabase.cpp: Marked various constants static to give them
+ internal linkage.
+ (WebCore::IconDatabase::IconDatabase): Added initial value for m_syncTimer.
+ Removed unneeded initial value for m_defaultIconRecord. Changed assertion to
+ work cross-platform.
+ (WebCore::IconDatabase::wakeSyncThread): Added disableSuddenTermination, so
+ we won't terminate until the sync thread has done its thing.
+ (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Added disableSuddenTermination,
+ so we won't terminate if we have an outstanding sync timer.
+ (WebCore::IconDatabase::syncTimerFired): Added enableSuddenTermination, to
+ balance the one in scheduleOrDeferSyncTimer.
+ (WebCore::IconDatabase::syncThreadMainLoop): Added enableSuddenTermination, to
+ balance the one in wakeSyncThread.
+ (WebCore::IconDatabase::deleteAllPreparedStatements): Use clear() instead of set(0).
+
+ * loader/icon/IconDatabase.h: Use a Timer instead of an OwnPtr<Timer>.
+
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::scheduleFinalSync): Added disableSuddenTermination.
+ (WebCore::LocalStorageArea::scheduleItemForSync): Ditto.
+ (WebCore::LocalStorageArea::scheduleClear): Ditto.
+ (WebCore::LocalStorageArea::syncTimerFired): Added a disableSuddenTermination if
+ we schedule a performSync callback for later and an unconditional
+ enableSuddenTermination to balance the ones in the schedule calls above.
+ (WebCore::LocalStorageArea::sync): Factored out the work of the sync function so it
+ can continue to use early return idiom.
+ (WebCore::LocalStorageArea::performSync): Added a call to enableSuddenTermination.
+
+ * storage/LocalStorageArea.h: Added declaration of the sync function.
+
+2009-04-19 David Kilzer <ddkilzer@apple.com>
+
+ Make FEATURE_DEFINES completely dynamic
+
+ Reviewed by Darin Adler.
+
+ Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
+ variables for each feature, making it possible to remove all
+ knowledge of FEATURE_DEFINES from build-webkit.
+
+ * Configurations/FeatureDefines.xcconfig: Extract a variable
+ from FEATURE_DEFINES for each feature setting.
+
+2009-04-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Removed a little more complexity from event handler creation and destruction.
+
+ Removed the jsProtectedEventListeners, jsProtectedInlineEventListeners,
+ and jsInlineEventListeners maps, and all the code for managing them.
+
+ ProtectedEventListeners don't exist anymore, so they're easy to nix.
+
+ Inline EventListeners do still exist, but there's no reason to track
+ them in a map. The map exists to enable 'removeEventListener' to associate
+ a unique JSEventListener with a given JavaScript function. But the
+ 'removeEventListener' API only works with non-inline event listeners!
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::createJSInlineEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::clearJSFunctionInline):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::~JSLazyEventListener):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-18 Dan Bernstein <mitz@apple.com>
+
+ - try to fix the Windows build
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::characterAfter):
+
+2009-04-18 Dan Bernstein <mitz@apple.com>
+
+ - revert the previous change, which was to a file that the Windows
+ port does not even use
+
+ * icu/unicode/utf16.h:
+
+2009-04-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ - try to fix the Windows build
+
+ * icu/unicode/utf16.h:
+
+2009-04-18 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25066
+
+ When a <video> element gained a RenderLayer via opacity, reflection etc., the
+ layer hierarchy was not correctly updated because RenderMedia skipped a level
+ when asked for its children; it skipped m_controlsShadowRoot's renderer, which
+ actually has a layer.
+
+ Test: fast/layers/video-layer.html
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
+ Don't manually call setParent() on the renderer. It will happen later
+ as a result of addChild().
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createControlsShadowRoot):
+ Add m_controlsShadowRoot's renderer as a child.
+
+ * rendering/RenderMedia.h:
+ (WebCore::RenderMedia::children):
+ Now maintain a RenderObjectChildList, m_children, and remove the unneeded
+ removeChild() method. Make the two children() methods inline.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::moveLayers):
+ Assert if moveLayers() is called with an oldParent that is not the
+ layer's actual parent (which would have revealed this bug).
+
+2009-04-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed a layout test failure, caused by my last check-in
+ (fast/dom/script-element-gc.html).
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::isObservableThroughDOM):
+ * html/HTMLScriptElement.h:
+ (WebCore::HTMLScriptElement::haveFiredLoadEvent): Treat script elements
+ just like image elements: if a script element is loading, mark its JS
+ wrapper, even if the element is not in the document.
+
+2009-04-18 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25170
+ Upstream V8WorkerCustom.cpp and V8WorkerContextCustom.cpp for V8 bindings.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
+ * bindings/v8/WorkerContextExecutionProxy.h:
+ * bindings/v8/custom/V8WorkerContextCustom.cpp: Added.
+ * bindings/v8/custom/V8WorkerCustom.cpp: Added.
+
+2009-04-18 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/post_bug.cg://bugs.webkit.org/show_bug.cgi?id=25167
+ Change createHiddenXHRDependency and removeHiddenXHRDependency so that they can be used by other custom code in V8 bindings.
+
+ * bindings/v8/V8Utilities.cpp: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.cpp.
+ (WebCore::createHiddenDependency):
+ (WebCore::removeHiddenDependency):
+ * bindings/v8/V8Utilities.h: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.h.
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-04-18 Drew Wilson <amw@apple.com>
+
+ <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
+
+ Reviewed by Dan Bernstein.
+
+ No test case since there is no change in behavior.
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::characterAfter): Now handles surrogate
+ pairs correctly and returns a UChar32.
+ * editing/VisiblePosition.h:
+ (WebCore::VisiblePosition::characterBefore): Now returns a UChar32.
+ * editing/visible_units.cpp:
+ (WebCore::endOfFirstWordBoundaryContext): Renamed
+ firstNonComplexContextLineBreak() to this. Changed it to use the
+ generic requiresContextForWordBoundary() instead of
+ hasLineBreakingPropertyComplexContext().
+ (WebCore::startOfLastWordBoundaryContext): Replaces
+ lastNonComplexContextLineBreak(), but returns the offset of
+ the character after the last character that does not require
+ context for word breaking. Also changed to use
+ requiresContextForWordBoundary().
+ (WebCore::previousBoundary): Updated for the above changes in
+ names and semantics, and changed to use
+ requiresContextForWordBoundary().
+ (WebCore::nextBoundary): Ditto.
+ (WebCore::startWordBoundary): Ditto.
+ (WebCore::endWordBoundary): Ditto.
+ (WebCore::previousWordPositionBoundary): Ditto.
+ (WebCore::nextWordPositionBoundary): Ditto.
+ * platform/text/TextBoundaries.h:
+ (WebCore::requiresContextForWordBoundary): Added.
+ * platform/text/mac/TextBoundaries.mm:
+
+2009-04-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
+ REGRESSION (r42569): Profiles cannot be selected in inspector profiler
+
+ EventListeners are shared; RegisteredEventListeners are not. Therefore,
+ when a node wrapper needs to invalidate the node's JS event listeners,
+ it should invalidate its RegisteredEventListeners, not its EventListeners.
+ Otherwise, it might invalidate an EventListener shared by another node.
+
+ * dom/RegisteredEventListener.h:
+ (WebCore::invalidateEventListeners): ditto
+
+2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6781295> video.buffered and video.seekable are not
+ the same. video.buffered should return only what is buffered and
+ not what is seekable
+
+ * WebCore.base.exp: Added wkQTMovieMaxTimeSeekable.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::maxTimeSeekable): Return wkQTMovieMaxTimeSeekable.
+
+ * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeSeekable.
+ * platform/mac/WebCoreSystemInterface.mm: Ditto.
+
+2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6747241> work around QTKit no longer reaching
+ QTMovieLoadStateComplete
+
+ * WebCore.base.exp: Export wkQTMovieMaxTimeLoadedChangeNotification.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovie): observe QTMovieMaxTimeLoadedChangeNotification.
+ (WebCore::MediaPlayerPrivate::updateStates): compare duuration() with maxTimeLoaded() instead of
+ using QTMovieLoadStateComplete to determine if a movie are fully loaded.
+
+ * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeLoadedChangeNotification.
+ * platform/mac/WebCoreSystemInterface.mm: Ditto.
+
+2009-04-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Make WML work again, most regressions test were failing.
+
+ * dom/Document.cpp: Be sure to create WML elements in WML namespace. Otherwhise hasTagName() comparisions fail.
+ (WebCore::Document::createElement):
+ * wml/WMLCardElement.cpp: Add ASSERT(hasTagName(cardTag)) to catch errors like this in future.
+ (WebCore::WMLCardElement::WMLCardElement):
+ * wml/WMLTagNames.in: Wrap comment in #if 0/#endif blocks, to silence the generation script.
+
+2009-04-17 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25277
+ If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
+
+ Also added code to handle a caret wider than one pixel.
+
+ Added fast/inline/25277.html and fast/inline/25277-2.html
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset,
+ so that a caret between two characters doesn't hang over one character more than the other.
+ If there is no wrapping, the caret can leave its containing block, but not its root line box.
+
+2009-04-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Some refactoring of "inline" event listeners.
+
+ Renames:
+ dispatchEventForType => dispatchEvent
+ setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
+ removeInlineEventListenerForType => clearInlineEventListener
+ setInlineEventListenerForType => setInlineEventListener
+ inlineEventListenerForType => getInlineEventListener
+
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::eventParameterName):
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::createInlineEventListener):
+ * bindings/js/JSLazyEventListener.h: Added two helper functions for
+ creating "inline" event listeners. These replace Document::createEventListener,
+ and abstract the creation of JS event listeners for DOM attributes out
+ of the DOM. Removed legacy JSProtectedEventListener constructor code for
+ adding the event listener's function to a map, since lazy event listeners
+ don't have functions at construction time.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * dom/Document.h:
+ (WebCore::Document::isSVGDocument):
+ * dom/Element.cpp:
+ (WebCore::Element::setWindowInlineEventListener):
+ * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
+ mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
+ to Element, for simplicity.
+
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::setValueFromRenderer):
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchFocusEvent):
+ (WebCore::Node::dispatchBlurEvent):
+ (WebCore::Node::dispatchEvent):
+ (WebCore::Node::clearInlineEventListener):
+ (WebCore::Node::setInlineEventListener):
+ (WebCore::Node::getInlineEventListener):
+ (WebCore::Node::onabort):
+ (WebCore::Node::setOnabort):
+ (WebCore::Node::etc.):
+ * dom/Node.h: Updated for renames.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
+
+ Updated these files for renames, and to use the new createInlineEventListener
+ helper function:
+
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::parseMappedAttribute):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::parseMappedAttribute):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::onChange):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::prepareSubmit):
+ (WebCore::HTMLFormElement::reset):
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::onSearch):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::loadInternal):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ (WebCore::HTMLScriptElement::dispatchLoadEvent):
+ (WebCore::HTMLScriptElement::dispatchErrorEvent):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::parseMappedAttribute):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/DOMWindow.cpp:
+ * page/DOMWindow.h:
+ (WebCore::DOMWindow::eventListeners):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::canMouseDownStartSelect):
+ (WebCore::EventHandler::canMouseDragExtendSelect):
+ (WebCore::EventHandler::sendScrollEvent):
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::valueChanged):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::selectionChanged):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::parseMappedAttribute):
+ * svg/SVGElementInstance.cpp:
+ * svg/SVGImageLoader.cpp:
+ (WebCore::SVGImageLoader::dispatchLoadEvent):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::dispatchErrorEvent):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::defaultEventHandler):
+
+2009-04-17 David Kilzer <ddkilzer@apple.com>
+
+ Simplify FEATURE_DEFINES definition
+
+ Reviewed by Darin Adler.
+
+ This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
+ variables to their own FeatureDefines.xcconfig file. It also
+ extracts a new ENABLE_GEOLOCATION variable so that
+ FEATURE_DEFINES only needs to be defined once.
+
+ * Configurations/FeatureDefines.xcconfig: Added.
+ * Configurations/WebCore.xcconfig: Removed definition of
+ ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include
+ of FeatureDefines.xcconfig.
+ * WebCore.xcodeproj/project.pbxproj: Added
+ FeatureDefines.xcconfig file.
+ * bindings/scripts/CodeGeneratorObjC.pm: When creating a list of
+ command-line macro definitions, split on one-or-more spaces
+ instead of a single space since the FEATURE_DEFINES macro may
+ now contain more than one space between macros if some macros
+ aren't defined.
+
+2009-04-17 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Mark Rowe
+
+ <rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::willLoadFromCache):
+
+2009-04-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ Added sudden termination functions that can be called without involving
+ the page or client.
+
+ * GNUmakefile.am: Added SuddenTermination.h.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.
+
+ * platform/SuddenTermination.h: Added.
+ * platform/mac/SuddenTermination.mm: Added.
+
+2009-04-17 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Move more code into RenderSVGModelObject
+
+ needsLayer() already returns false from RenderSVGModelObject
+ lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.
+
+ I also added comments to explain how focus rings work (now that I understand)
+ I got rid of two more uses of m_absoluteBounds (nearly dead!)
+
+ * rendering/RenderPath.cpp:
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ (WebCore::RenderSVGContainer::addFocusRingRects):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::absoluteRects):
+ (WebCore::RenderSVGModelObject::absoluteQuads):
+ * rendering/RenderSVGModelObject.h:
+
+2009-04-16 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25238
+ Invalidate the hovered scrollbar part when resetting the pressed part,
+ since once there is no pressed part we can draw a hovered state.
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::setHoveredPart):
+ (WebCore::Scrollbar::setPressedPart):
+
+2009-04-16 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25223
+ REGRESSION: Back button after form submission to the same URL fails to navigate.
+
+ Test: http/tests/navigation/post-goback-same-url.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): Check if the page we are leaving has
+ FormData.
+
+2009-04-17 Nikolas Zimmermann <nikolas.zimmerman@torchmobile.com>
+
+ Not reviewed. Fix WML enabled builds.
+
+ * rendering/RenderTableRow.cpp: Remove dead code, which is no longer necessary.
+ (WebCore::RenderTableRow::addChild):
+ * wml/WMLInputElement.cpp: Apply same fix HTMLInputElement received. Covert RenderObject's to RenderTextControl where needed.
+ (WebCore::WMLInputElement::defaultEventHandler):
+
+2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24849
+
+ Add support for the media element 'played' attribute.
+ This involves support of "normalized TimeRanges" as described by
+ the spec.
+
+ Test: media/video-played.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed
+ m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges.
+ (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and
+ m_playedTimeRanges
+ (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges
+ (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime
+ (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges.
+ (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing.
+ Set the m_playing flag.
+ * html/HTMLMediaElement.h:
+
+ * html/TimeRanges.cpp:
+ (TimeRanges::add): Merge range(s) if overlap.
+ * html/TimeRanges.h: Add various helpers (below).
+ (WebCore::TimeRanges::Range::isPointInRange): Added.
+ (WebCore::TimeRanges::Range::isOverlappingRange): Ditto.
+ (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto.
+ (WebCore::TimeRanges::Range::isBeforeRange): Ditto.
+
+2009-04-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
+ https://bugs.webkit.org/show_bug.cgi?id=25210
+
+ * WebCore.base.exp: Export the core and kit function overloads that are used
+ in WebKit. Also resorted this file.
+
+ * WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix
+ a strange problem with the file type.
+
+ * bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes
+ so we can use and implement the new core and kit functions. Import DOMInternal.h
+ first so it can do its public/private magic.
+ (-[DOMNode _rootObject]): Changed to use early-return style.
+ (kitClass): Added. Tells the wrapper generator what kind of node class to create
+ to wrap DOM nodes. This has the code that used to be in the _wrapNode method.
+ (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper,
+ dpending on whether it's a Node or an SVGElementInstance. This replace methods
+ that used to be on both of those classes.
+ (-[DOMNode boundingBox]): Changed to use early return, and the core function.
+ (-[DOMNode lineBoxRects]): Ditto.
+ (-[DOMNode renderedImage]): Ditto.
+ (-[DOMRange boundingBox]): Ditto.
+ (-[DOMRange lineBoxRects]): Ditto.
+ (-[DOMElement image]): Ditto.
+ (-[DOMElement _font]): Ditto.
+ (-[DOMElement _imageTIFFRepresentation]): Ditto.
+ (-[DOMElement _getURLAttribute:]): Ditto.
+ (-[DOMElement isFocused]): Ditto.
+ (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol,
+ not a class in the binding.
+ (core): Ditto.
+ (-[DOMNodeFilter acceptNode:]): Use core.
+
+ * bindings/objc/DOMAbstractView.mm:
+ (-[DOMAbstractView document]): Use kit.
+ (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer
+ in the WebCore namespace, since it's headed for WebKit in the future.
+ (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store
+ a pointer to the Frame, not the DMWindow.
+ (kit): Ditto.
+
+ * bindings/objc/DOMCSS.mm:
+ (kitClass): Added. Tells the wrapper generator what kind of node class to create
+ to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet,
+ _wrapCSSRule, and _wrapCSSValue methods.
+
+ * bindings/objc/DOMEvents.mm:
+ (kitClass): Added. Tells the wrapper generator what kind of node class to create
+ to wrap event objects. This has the code that used to be in the _wrapEvent methods.
+
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core.
+ (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto.
+ (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
+ (-[DOMHTMLInputElement _rectOnScreen]): Ditto.
+ (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto.
+ (-[DOMHTMLInputElement _selectedRange]): Ditto.
+ (-[DOMHTMLInputElement _setAutofilled:]): Ditto.
+ (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto.
+ (-[DOMHTMLInputElement _isEdited]): Ditto.
+ (-[DOMHTMLTextAreaElement _isEdited]): Ditto.
+ (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.
+
+ * bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason
+ to have this header include all the other internal DOM headers. Removed unneeded
+ interfaces, including the redeclaration of _init in DOMObject, since it's already
+ inherited from WebScriptObject. Moved all the functions out of the WebCore
+ namespace since this code is destined for WebKit, which doesn't use a namespace.
+ Added kit and core functions for the two classes that live in this header.
+
+ * bindings/objc/DOMInternal.mm:
+ (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.
+
+ * bindings/objc/DOMObject.h: Made the _internal field be private instead of
+ protected. This also allows the "#define private public" trick to be used to
+ make the field accessible inside the bindings code.
+
+ * bindings/objc/DOMObject.mm:
+ (-[DOMObject dealloc]): Updated for namespace change.
+ (-[DOMObject sheet]): Use core and kit functions.
+
+ * bindings/objc/DOMRGBColor.mm:
+ (-[DOMRGBColor dealloc]): Updated for namespace change.
+ (-[DOMRGBColor red]): Use kit function.
+ (-[DOMRGBColor green]): Ditto.
+ (-[DOMRGBColor blue]): Ditto.
+ (-[DOMRGBColor alpha]): Ditto.
+ (core): Added. Replaces the _RGBColor method.
+ (kit): Added. Replaces the _wrapRGBColor method.
+
+ * bindings/objc/DOMSVGPathSegInternal.mm:
+ (kitClass): Added. Replaces the _wrapSVGPathSeg method.
+
+ * bindings/objc/DOMUtility.mm:
+ (JSC::createDOMWrapper): Use kit function.
+ (createDOMWrapper): Ditto.
+
+ * bindings/objc/DOMXPath.mm:
+ (core): Added. Replaces the _xpathNSResolver method.
+ (kit): Added. Replaces the _wrapXPathNSResolver method.
+
+ * bindings/objc/ObjCEventListener.mm:
+ (WebCore::ObjCEventListener::find): Changed to use early return.
+ (WebCore::ObjCEventListener::handleEvent): Use kit function.
+
+ * bindings/objc/ObjCNodeFilterCondition.mm:
+ (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.
+
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
+ Updated for namespace change.
+
+ * bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license"
+ to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName,
+ GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature.
+ Changed includes to conform to new scheme. Generate core and kit
+ functions instead of methods and calls to those functions. Added a new
+ attribute, Polymorphic, to indicate classes that have derived subclasses.
+ Removed the old ObjCCustomInternalImpl attribute.
+
+ * css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions
+ will be generated, with kit calling kitClass. This requires less hand-
+ written code than the old ObjCCustomInternalImpl.
+ * css/CSSValue.idl: Ditto.
+ * css/StyleSheet.idl: Ditto.
+ * dom/Event.idl: Ditto.
+ * dom/Node.idl: Ditto.
+ * html/HTMLCollection.idl: Ditto.
+ * svg/SVGPathSeg.idl: Ditto.
+
+ * editing/TextAffinity.h: Moved kit and core functions out of the
+ WebCore namespace since this code is destined for WebKit, which
+ doesn't use a namespace
+
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.
+
+ * platform/mac/DragDataMac.mm:
+ (WebCore::DragData::asFragment): Use core function.
+
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::Pasteboard::writeSelection): Use kit function.
+
+ * svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl
+ function. This can be generated in a standard way now.
+ * svg/SVGViewSpec.idl: Ditto.
+
+2009-04-17 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Maciej Stachowiak
+
+ <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage
+
+ If the Page is in private browsing mode when a statement is queued up, flag that
+ statement as read-only.
+
+ It would be better to set the read-only flag on the database thread when it actually
+ executes, but that would either require making Settings access a lock-protected operation
+ or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
+ If it becomes an issue in practice, we can revisit this later.
+
+ Test: storage/private-browsing-readonly.html
+
+ * storage/Database.cpp:
+ (WebCore::Database::setAuthorizerReadOnly):
+ * storage/Database.h:
+
+ * storage/DatabaseAuthorizer.cpp: For all action types that would alter the database,
+ deny when in read-only mode.
+ (WebCore::DatabaseAuthorizer::reset):
+ (WebCore::DatabaseAuthorizer::createTable):
+ (WebCore::DatabaseAuthorizer::dropTable):
+ (WebCore::DatabaseAuthorizer::allowAlterTable):
+ (WebCore::DatabaseAuthorizer::createIndex):
+ (WebCore::DatabaseAuthorizer::dropIndex):
+ (WebCore::DatabaseAuthorizer::createTrigger):
+ (WebCore::DatabaseAuthorizer::dropTrigger):
+ (WebCore::DatabaseAuthorizer::createVTable):
+ (WebCore::DatabaseAuthorizer::dropVTable):
+ (WebCore::DatabaseAuthorizer::allowDelete):
+ (WebCore::DatabaseAuthorizer::allowInsert):
+ (WebCore::DatabaseAuthorizer::allowUpdate):
+ (WebCore::DatabaseAuthorizer::setReadOnly):
+ * storage/DatabaseAuthorizer.h:
+
+ * storage/SQLStatement.cpp:
+ (WebCore::SQLStatement::create): Add a m_readOnly flag.
+ (WebCore::SQLStatement::SQLStatement): Ditto.
+ (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change
+ to read-only mode.
+ * storage/SQLStatement.h:
+
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is
+ currently in private browsing mode.
+
+2009-04-17 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Antti Koivisto.
+
+ Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
+ https://bugs.webkit.org/show_bug.cgi?id=25268
+
+ Lots of minus lines. Now we're sharing more sane code
+ (which will respect -webkit-transforms! and scroll offsets correctly)
+
+ Which means this fixes:
+ https://bugs.webkit.org/show_bug.cgi?id=20769 and
+ https://bugs.webkit.org/show_bug.cgi?id=21968 too!
+
+ We're no longer expanding the paint rect "for anti-aliasing", since
+ I can't find a case where that's required. If it is, repaintRectInLocalCoordinates()
+ should be fixed to handle those cases instead of here.
+
+ This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
+ as well as improves our focus ring drawing seen in svg/custom/focus-ring
+ focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
+ Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::repaintRectInLocalCoordinates):
+ (WebCore::RenderPath::setPath):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGModelObject::computeRectForRepaint):
+ * rendering/RenderSVGModelObject.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::computeRectForRepaint):
+ * rendering/RenderSVGRoot.h:
+
+2009-04-17 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
+ https://bugs.webkit.org/show_bug.cgi?id=25259
+
+ When a node becomes visible or hidden, accessibility needs to be told to update.
+
+ Test: accessibility/visible-elements.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+
+2009-04-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix, added missing header.
+
+ * platform/graphics/wx/TransformationMatrixWx.cpp:
+
+2009-04-17 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Unreviewed build fix.
+
+ Fix the build with enabled SVG filters
+
+ * rendering/RenderSVGModelObject.cpp: Include SVGResourceFilter.h.
+
+2009-04-16 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25196
+ Add a missing V8DOMMap include.
+
+ * bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.
+
+2009-04-16 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25260
+ Finish V8 custom bindings for InspectorController.
+
+ * bindings/v8/custom/V8InspectorControllerCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL): Added.
+
+2009-04-16 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing
+ unnecessary conversions internally when drawing bitmaps.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25248
+
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::createFrameAtIndex):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+ (WebCore::BitmapImage::drawPattern):
+
+2009-04-16 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Performing a block style change in an editable root that contains only a br adds a newline
+ https://bugs.webkit.org/show_bug.cgi?id=25256
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root
+ block that didn't handle a root that contained a placeholder.
+
+2009-04-16 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Fix computeContainerBoundingBox to respect viewport translations
+ https://bugs.webkit.org/show_bug.cgi?id=25254
+
+ Previously computeContainerBoundingBox was just adding the viewportTranslation.
+ Which, although it has a confusing name, only contains the scale and translation
+ for the viewBox/preserveAspectRatio adjustment. It does not contain the
+ translation for the x/y offset of the viewport.
+ localToParentTransform() does contain this offset, so we use that instead
+ of the previous hacky code.
+
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGViewportContainer.h:
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::computeContainerBoundingBox):
+
+2009-04-16 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Add a localToParentTransform() method which includes the
+ full transform between local and parent local coordinates.
+ https://bugs.webkit.org/show_bug.cgi?id=25226
+
+ Moved m_localTransform up into RenderSVGTransformableContainer
+ and added a comment to RenderSVGViewportContainer to make it more
+ clear that it does not have a localTransform().
+
+ This patch reveals two more failed design decisions:
+ 1. Use of RenderBox::absoluteTransform() to mean "absoluteTransform()
+ including only my localTransform()" callers are probably using it
+ incorrectly anyway and are just masking bugs in the confused code.
+ 2. computeContainerBoundingBox does not include viewport translations in
+ its computed bounding box, so bounding boxes will be off for parents of
+ inner <svg> elements. I'll fix this an updated the results in a separate change.
+
+ No functional changes, thus no tests.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::localToParentTransform):
+ (WebCore::RenderObject::absoluteTransform):
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::viewportTransform):
+ * rendering/RenderSVGHiddenContainer.cpp:
+ * rendering/RenderSVGHiddenContainer.h:
+ (WebCore::RenderSVGHiddenContainer::absoluteTransform):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::localToParentTransform):
+ (WebCore::RenderSVGRoot::absoluteTransform):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGTransformableContainer.cpp:
+ (WebCore::RenderSVGTransformableContainer::localToParentTransform):
+ (WebCore::RenderSVGTransformableContainer::localTransform):
+ * rendering/RenderSVGTransformableContainer.h:
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::localToParentTransform):
+ (WebCore::RenderSVGViewportContainer::absoluteTransform):
+ * rendering/RenderSVGViewportContainer.h:
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::computeContainerBoundingBox):
+
+2009-04-16 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Fix Chromium's rendering of <option> elements inside of <optgroups>.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25244
+
+ Test (will included as a manual test by https://bugs.webkit.org/show_bug.cgi?id=24900):
+
+ <select>
+ <optgroup label="Should be bold">
+ <option>Should not be bold</option>
+ </optgroup>
+ </select>
+
+ * css/themeWin.css: adding comments
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::getRowFont): use menuStyle() rather than the item's style
+
+2009-04-16 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25218
+
+ Make DOMWindow::inlineEventListenerForType not have the "inline"
+ keyword. As this method gets used outside of DOMWindow.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::inlineEventListenerForType):
+
+2009-04-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ Fix <rdar://problem/6766969>
+
+ When deferred repaints are enabled and being reset and there is a active
+ timer, stop the timer and do the deferred repaints immediately.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::resetDeferredRepaintDelay):
+
+2009-04-16 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25241
+ Remove superfluous NotImplemented.h includes.
+
+ * html/CanvasRenderingContext2D.cpp:
+ * html/CanvasStyle.cpp:
+ * page/AccessibilityRenderObject.cpp:
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ * platform/graphics/GraphicsContext.cpp:
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ * platform/graphics/cairo/PathCairo.cpp:
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ * platform/graphics/gtk/FontGtk.cpp:
+ * platform/graphics/gtk/IconGtk.cpp:
+ * platform/graphics/qt/IconQt.cpp:
+ * platform/graphics/qt/ImageQt.cpp:
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ * platform/graphics/skia/ImageSkia.cpp:
+ * platform/graphics/win/ColorSafari.cpp:
+ * platform/graphics/win/FontWin.cpp:
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ * platform/graphics/win/GraphicsContextCairoWin.cpp:
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ * platform/graphics/wx/ImageWx.cpp:
+ * platform/graphics/wx/TransformationMatrixWx.cpp:
+ * platform/gtk/PlatformScreenGtk.cpp:
+ * platform/gtk/PopupMenuGtk.cpp:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/gtk/ScrollbarGtk.cpp:
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ * platform/posix/FileSystemPOSIX.cpp:
+ * platform/qt/DragDataQt.cpp:
+ * platform/qt/FileSystemQt.cpp:
+ * platform/qt/Localizations.cpp:
+ * platform/qt/PopupMenuQt.cpp:
+ * platform/win/EditorWin.cpp:
+ * platform/win/PasteboardWin.cpp:
+ * platform/wx/KeyboardEventWx.cpp:
+ * platform/wx/PopupMenuWx.cpp:
+ * platform/wx/SharedTimerWx.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ * plugins/mac/PluginPackageMac.cpp:
+ * plugins/qt/PluginPackageQt.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ * rendering/RenderThemeChromiumLinux.cpp:
+ * svg/graphics/SVGImage.cpp:
+
+2009-04-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Some cleanup in event handling code.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ * bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener
+ and findJSProtectedEventListener because they are now unused.
+
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSEventListener::clearGlobalObject):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::JSLazyEventListener::~JSLazyEventListener):
+ (WebCore::JSLazyEventListener::globalObject):
+ * bindings/js/JSLazyEventListener.h:
+ (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener,
+ and merged it with JSLazyEventListener, the only remaining event listener
+ that still GC-protects its function and global object.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ * bindings/js/ScriptController.h:
+ (WebCore::ScriptController::setEventHandlerLineNumber):
+ (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno =>
+ handlerLineNumber, because anything less would be uncivilized. Removed
+ createInlineEventListener because it mostly did irrelevent work, so it
+ just got in the way of understanding how event handler creation works.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createEventListener):
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::startElementNs):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::processToken): Ditto.
+
+2009-04-16 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
+ crashes on load due to messy HTML in search form
+ -and corresponding-
+ <rdar://problem/6210633>
+
+ Before this patch, <form>s were allowed to sit inside tables
+ without being wrapped by anonymous table parts. There was also a
+ concept that such a form could be "demoted" and would not be
+ allowed to have any children. This patch has the HTML parser mark
+ form elements that have been demoted as such, and then the demoted
+ forms are not given renderers. I also removed the code that allowed
+ forms to sit in tables without anonymous table sections. So now any
+ forms that do manage to get a renderer inside a table will also be
+ wrapped with appropriate table parts.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::HTMLFormElement):
+ (WebCore::HTMLFormElement::rendererIsNeeded):
+ * html/HTMLFormElement.h:
+ (WebCore::HTMLFormElement::setDemoted):
+ (WebCore::HTMLFormElement::isDemoted):
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::insertNode):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::addChild):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addChild):
+
+2009-04-16 Xiaomei Ji <xji@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=24527
+ caret does not paint the first time you focus on a 0px right padding RTL div
+
+ Test: fast/forms/caret-rtl.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::localCaretRect): When calculating x-axis if
+ alignment is alignRight, we need to subtract the caretWidth so that the
+ caret at IntRect(x, y, caretWidth, height) is inside the block.
+
+2009-04-16 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25228
+ SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
+
+ Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::localCaretRect):
+ (WebCore::SelectionController::absoluteBoundsForLocalRect):
+ (WebCore::SelectionController::caretRepaintRect):
+ (WebCore::SelectionController::recomputeCaretRect):
+ * editing/SelectionController.h:
+
+2009-04-16 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25187
+ Bug 25187: <video> may not be rendered upon certain racy conditions
+
+ Always create the video renderer when the load state reaches QTMovieLoadStateLoaded and
+ the element is visible, not just when the movie has just been opened.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false
+ assumption on the state changes order. Create the renderer if none is present,
+ when movie is loaded instead.
+
+2009-04-16 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code
+
+ RenderSVGModelObject has much more interesting code it can share,
+ but I'm just trying to get the commits out of my local branch and into
+ the repository in any order I can. :) This one was small.
+
+ This will be used by the unified RenderSVGModelObject
+ clippedOverflowRectForRepaint patch coming soon.
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::filterBoundingBox):
+ * rendering/RenderSVGModelObject.h:
+
+2009-04-16 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Eric Seidel and Adam Roben.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Simplified some EventHandler creation code.
+
+ Removed a pile of code whose sole purpose was to allow SVG event handlers
+ to supply a parameter named "evt" instead of the normal "event", and
+ replaced it with a single parameter to JSLazyEventListener's constructor
+ specifying the parameter name to use.
+
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSLazyEventListener.h:
+ (WebCore::JSLazyEventListener::create):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createInlineEventListener):
+ * bindings/js/ScriptController.h:
+ * dom/Document.cpp:
+ (WebCore::Document::createEventListener):
+
+2009-04-15 Eric Seidel <eric@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
+ in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
+ https://bugs.webkit.org/show_bug.cgi?id=25224
+
+ objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"
+
+ repaintRectInLocalCoordinates() should return the a rect covering all painted content.
+ However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
+ in this patch. In a future patch, repaintRectInLocalCoordinates will be fixed to return
+ a rect covering all painted content. In order to avoid changing several hundred layout test results, I've left
+ the behavior as-is for now. The returned rect is used by various repaintRectInLocalCoordinates
+ implementations and sometimes adjusted to include all painted content, but not always, and
+ the places where the adjustments are made are sometimes wrong. Again, will be fixed in
+ an upcoming patch.
+
+ This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
+ bounding-box relative gradients on SVGFont glyphs to not paint correctly.
+ I chose not to try and fix the bug in this patch and instead left a FIXME.
+
+ This patch also discovered that at least tspan.getBBox() is broken. This
+ along with the foreignObject.getBBox() change will be tested (and fixed) in a
+ later patch. https://bugs.webkit.org/show_bug.cgi?id=25225
+
+ No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.
+
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch
+ (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
+ * rendering/RenderForeignObject.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented.
+ (WebCore::RenderObject::repaintRectInLocalCoordinates):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::objectBoundingBox):
+ (WebCore::RenderPath::repaintRectInLocalCoordinates):
+ (WebCore::RenderPath::clippedOverflowRectForRepaint):
+ (WebCore::RenderPath::lineHeight):
+ (WebCore::RenderPath::baselinePosition):
+ (WebCore::RenderPath::paint):
+ (WebCore::RenderPath::addFocusRingRects):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ (WebCore::RenderSVGContainer::objectBoundingBox):
+ (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGGradientStop.h:
+ (WebCore::RenderSVGGradientStop::objectBoundingBox):
+ (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::objectBoundingBox):
+ (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::objectBoundingBox):
+ (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
+ (WebCore::RenderSVGImage::calculateAbsoluteBounds):
+ (WebCore::RenderSVGImage::addFocusRingRects):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::objectBoundingBox):
+ (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGTSpan.h:
+ (WebCore::RenderSVGTSpan::objectBoundingBox):
+ (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+ (WebCore::RenderSVGText::objectBoundingBox):
+ (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::viewportTransform):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::computeContainerBoundingBox):
+ * rendering/SVGRenderSupport.h:
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * svg/SVGFont.cpp:
+ (WebCore::Font::drawTextUsingSVGFont):
+ * svg/SVGLocatable.cpp:
+ (WebCore::SVGLocatable::getBBox):
+ * svg/SVGPatternElement.cpp:
+ (WebCore::SVGPatternElement::buildPattern):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::createMaskAndSwapContextForTextGradient):
+ (WebCore::clipToTextMask):
+ (WebCore::SVGPaintServerGradient::setup):
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+
+2009-04-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6032139> Table cell widths calculated
+ incorrectly on table that uses table-layout:fixed, colspans, and a mix
+ of percentage and pixel widths
+
+ Test: fast/table/fixed-granular-cols.html
+
+ The incorrect widths resulted from incorrect handling of the case where
+ the <col> elements are more granular than the table cells.
+
+ * rendering/FixedTableLayout.cpp:
+ (WebCore::FixedTableLayout::calcWidthArray): When processing <col>
+ elements, append effective columns or split existing effective columns
+ as needed.
+
+2009-04-16 Alexey Proskuryakov <ap@webkit.org>
+
+ <rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential
+
+ Rolled out <http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
+ authentication challenge are different, after all. Added a FIXME comment about a possible
+ future improvement.
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::clearAuthentication):
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+ (WebCore::ResourceHandle::receivedCredential):
+ (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
+ (WebCore::ResourceHandle::receivedCancellation):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+ (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
+ (WebCore::ResourceHandle::receivedCredential):
+ (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
+ (WebCore::ResourceHandle::receivedCancellation):
+
+2009-04-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
+ a page with breakpoints set
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::clearJSFunctionInline):
+ (WebCore::JSEventListener::markJSFunction):
+ * bindings/js/JSEventListener.h: Actually clear our function and global
+ object pointers when our client instructs us to. (Oops!) Also, mark
+ our global object while we still intend to use it.
+
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::mark):
+ (WebCore::toJS):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure
+ that the corresponding element also has a wrapper, to keep its event
+ listeners alive.
+
+2009-04-15 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25201
+ Add ScriptFunctionCall/ScriptObject for V8.
+
+ * bindings/v8/ScriptFunctionCall.cpp: Added.
+ * bindings/v8/ScriptFunctionCall.h: Added.
+ * bindings/v8/ScriptObject.cpp: Added.
+ * bindings/v8/ScriptObject.h: Added.
+ * bindings/v8/ScriptObjectQuarantine.cpp: Added.
+ * bindings/v8/ScriptObjectQuarantine.h: Added.
+ * bindings/v8/ScriptScope.cpp: Added.
+ * bindings/v8/ScriptScope.h: Added.
+ * bindings/v8/ScriptState.h:
+ (WebCore::ScriptState::ScriptState): Added new constructors.
+ (WebCore::ScriptState::frame): Added Frame ptr accessor.
+ * bindings/v8/ScriptString.h:
+ (WebCore::ScriptString::ScriptString): Added default constructor.
+ * bindings/v8/ScriptValue.h:
+ (WebCore::ScriptValue::isEqual): Added.
+
+2009-04-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.
+
+ * GNUmakefile.am:
+
+2009-04-15 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6785760> WebCore should use a maximum of 6 connections per host, not 4
+
+ Reviewed by Adam Roben.
+
+ * platform/network/ResourceRequestBase.cpp:
+ * platform/network/cf/ResourceRequestCFNet.cpp:
+ (WebCore::initializeMaximumHTTPConnectionCountPerHost):
+
+2009-04-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Add special casing to bindings generator so that custom functions
+ starting with xml or xslt conform to WebKit style guidelines.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::xmlHttpRequest):
+ (WebCore::JSDOMWindow::xsltProcessor):
+ * bindings/scripts/CodeGenerator.pm:
+
+2009-04-15 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
+ https://bugs.webkit.org/show_bug.cgi?id=25221
+
+ RenderSVGModelObject is the base rendering class for things which live
+ in the SVG rendering tree. Not all SVG renders are RenderSVGModelObjects yet.
+
+ More patches coming. This is just adding the class, future patches
+ will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.
+
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::RenderPath):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::RenderSVGContainer):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGModelObject.cpp: Added.
+ (WebCore::RenderSVGModelObject::RenderSVGModelObject):
+ * rendering/RenderSVGModelObject.h: Added.
+ (WebCore::RenderSVGModelObject::requiresLayer):
+ * rendering/RenderTreeAsText.cpp:
+ * rendering/SVGRenderTreeAsText.cpp:
+
+2009-04-15 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Remove more dead code from RenderSVGHiddenContainer.
+
+ lineHeight and baselinePosition used to be on RenderSVGContainer
+ (of which this is a subclass) because RenderSVGContainer used
+ to be a RenderBox and always the renderer for <svg>
+ Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
+ and RenderSVGViewportContainer (when inside SVG content)
+ so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.
+
+ * rendering/RenderSVGHiddenContainer.cpp:
+ * rendering/RenderSVGHiddenContainer.h:
+
+2009-04-15 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Remove unneeded (broken) code from SVG renderers
+ https://bugs.webkit.org/show_bug.cgi?id=25214
+
+ Mostly due to my historical confusions about the render tree
+ and some methods not being removed after classes were split.
+
+ RenderSVGRoot is an RenderBox and should just use all the
+ standard RenderBox methods for inspector and repaint rects.
+
+ RenderSVGContainer is *not* a RenderBox (any more) and thus
+ doesn't need lineHeight or width/height or calcBounds.
+
+ RenderSVGViewportContainer had some broken code which tried
+ to see if the click was inside the container at all, but it
+ was using width/height metrics based off of the containing
+ block (from calcWidth) which is wrong (since its real
+ width/height are from its containing viewport not containing block).
+
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::RenderSVGContainer):
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGRoot.cpp:
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::layout):
+ (WebCore::RenderSVGViewportContainer::nodeAtPoint):
+
+2009-04-15 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser and Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25217
+ Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
+ Add ASSERT(element) to all these functions since they should never be passed a null element.
+
+ * svg/SVGLocatable.cpp:
+ (WebCore::isViewportElement):
+ (WebCore::SVGLocatable::nearestViewportElement):
+ (WebCore::SVGLocatable::farthestViewportElement):
+ (WebCore::SVGLocatable::getBBox):
+ (WebCore::SVGLocatable::getCTM):
+ (WebCore::SVGLocatable::getScreenCTM):
+
+2009-04-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove support for the ObjCIvar extended attribute from the Objective-C
+ bindings generator. It is not used anymore.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+
+2009-04-15 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25204
+ Create a fast path for ReplaceSelectionCommand that merges text nodes
+
+ During simple pastes, where we're just pasting a text node into a run of text, we would split the current
+ text and insert the new node in between. This is slow and we hit this bug:
+
+ https://bugs.webkit.org/show_bug.cgi?id=6148
+
+ in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
+
+ This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
+ text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+ (WebCore::ReplaceSelectionCommand::performTrivialReplace):
+ * editing/ReplaceSelectionCommand.h:
+ * editing/TextIterator.cpp:
+
+2009-04-15 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Move VDMX parsing into the Chromium Linux port.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25116
+
+ VDMX tables are optional tables in TrueType fonts which contain the
+ exact pixel height of a given font at a given pel size. In order to
+ match Windows font metrics we have to use these numbers.
+
+ Previously, the parsing was performed in Skia. As part of the merge
+ with upstream Skia, an interface for getting table data from a font
+ has been added to Skia and we're moving the parsing into WebKit.
+
+ This does not change any layout tests.
+
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp:
+ (WebCore::FontPlatformData::uniqueID):
+ * platform/graphics/chromium/FontPlatformDataLinux.h:
+ * platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
+ * platform/graphics/chromium/FontTrueTypeLinux.h: Added.
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+
+2009-04-15 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25180
+
+ Restore stroked outlines to PlatformContextSkia::drawRect().
+ These were removed inadvertently in r41805, aka
+ https://bugs.webkit.org/show_bug.cgi?id=24662.
+ SkRect is { left, top, right, bottom }, not { left, top, width, height }.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::drawRect):
+
+2009-04-15 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6777374> Generated content with display: run-in
+ causes a crash
+
+ Test: fast/runin/generated.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is
+ generated, and if so, make the RenderInline anonymous instead of passing
+ a 0 node to the RenderInline constructor. If the run-in itself is
+ generated, do move :before and :after children from the block into the
+ inline, as they will not be regenerated. Changed nested ifs into early
+ returns.
+
+2009-04-15 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25192
+
+ Expose DOMWindow::removeInlineEventListenerForType and
+ DOMWindow::inlineEventListenerForType as public.
+
+ * page/DOMWindow.h:
+
+2009-04-14 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25198
+
+ Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
+ in a USE(JSC), since it doesn't compile with V8 bindings.
+
+ * dom/RegisteredEventListener.h:
+
+2009-04-15 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25194
+
+ Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
+ use the new name.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+
+2009-04-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Rubber-stamped by Darin Adler.
+
+ Don't keep platform objects for authentication challenge in ResourceHandleInternal.
+ We already have a copy in AuthenticationChallenge object.
+
+ * platform/network/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::clearAuthentication):
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+ (WebCore::ResourceHandle::receivedCredential):
+ (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
+ (WebCore::ResourceHandle::receivedCancellation):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+ (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
+ (WebCore::ResourceHandle::receivedCredential):
+ (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
+ (WebCore::ResourceHandle::receivedCancellation):
+
+2009-04-14 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Nixed some now-defunct autogeneration code.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-14 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
+ file:/// URLs from remote in Safari
+
+ Tests: http/tests/security/local-video-poster-from-remote.html
+ http/tests/security/local-video-source-from-remote.html
+ http/tests/security/local-video-src-from-remote.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine unless loader->canLoad()
+ says it is OK.
+
+2009-04-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Part of <rdar://problem/6150868>
+ Fix incorrect handling of content that needs to go into the head element
+ once the head element has been removed.
+
+ Test: fast/parser/head-content-after-head-removal.html
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
+ (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
+ (WebCore::HTMLParser::createHead): Ditto.
+ * html/HTMLParser.h: Make m_head a RefPtr.
+
+2009-04-14 Geoffrey Garen <ggaren@apple.com>
+
+ Used svn merge -r42529:42528 to roll out my last patch because it broke
+ the build.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
+ (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
+ * bindings/js/JSDOMGlobalObject.h:
+
+2009-04-14 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Nixed some now-dead code related to protected event listeners.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ * bindings/js/JSDOMGlobalObject.h:
+
+2009-04-14 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Stop using protected event listeners on SVGElementInstance.
+
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::mark): Mark our event listeners, since
+ they're not protected anymore.
+
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener): Make unprotected
+ event listeners, since we mark them now.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Autogenerate event listener
+ invalidation for SVGElementInstance.
+
+ * svg/SVGElementInstance.h:
+ (WebCore::SVGElementInstance::eventListeners): Added an accessor, for
+ the sake of autogenerated code.
+
+ * svg/SVGElementInstance.idl: Removed the ProtectedEventListener attribute
+ from event listener properties. Added a CustomMarkFunction attribute,
+ since we need to mark our event listeners.
+
+2009-04-14 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-04-14 Steve Falkenburg <sfalken@apple.com>
+
+ Add header guards to WebCore forwarding headers.
+
+ Speeds up WebCore debug build on Windows by 12% on my system,
+ since Visual Studio appears to not optimize for standard header
+ guards in included files.
+
+ Rubber stamped by Ada Chan.
+
+ * ForwardingHeaders/debugger/Debugger.h:
+ * ForwardingHeaders/debugger/DebuggerActivation.h:
+ * ForwardingHeaders/debugger/DebuggerCallFrame.h:
+ * ForwardingHeaders/interpreter/CallFrame.h:
+ * ForwardingHeaders/interpreter/Interpreter.h:
+ * ForwardingHeaders/masm/X86Assembler.h:
+ * ForwardingHeaders/parser/Parser.h:
+ * ForwardingHeaders/parser/SourceCode.h:
+ * ForwardingHeaders/parser/SourceProvider.h:
+ * ForwardingHeaders/pcre/pcre.h:
+ * ForwardingHeaders/profiler/Profile.h:
+ * ForwardingHeaders/profiler/ProfileNode.h:
+ * ForwardingHeaders/profiler/Profiler.h:
+ * ForwardingHeaders/runtime/ArgList.h:
+ * ForwardingHeaders/runtime/ArrayPrototype.h:
+ * ForwardingHeaders/runtime/BooleanObject.h:
+ * ForwardingHeaders/runtime/CallData.h:
+ * ForwardingHeaders/runtime/Collector.h:
+ * ForwardingHeaders/runtime/CollectorHeapIterator.h:
+ * ForwardingHeaders/runtime/Completion.h:
+ * ForwardingHeaders/runtime/ConstructData.h:
+ * ForwardingHeaders/runtime/DateInstance.h:
+ * ForwardingHeaders/runtime/Error.h:
+ * ForwardingHeaders/runtime/FunctionConstructor.h:
+ * ForwardingHeaders/runtime/FunctionPrototype.h:
+ * ForwardingHeaders/runtime/Identifier.h:
+ * ForwardingHeaders/runtime/InitializeThreading.h:
+ * ForwardingHeaders/runtime/InternalFunction.h:
+ * ForwardingHeaders/runtime/JSArray.h:
+ * ForwardingHeaders/runtime/JSByteArray.h:
+ * ForwardingHeaders/runtime/JSFunction.h:
+ * ForwardingHeaders/runtime/JSGlobalData.h:
+ * ForwardingHeaders/runtime/JSGlobalObject.h:
+ * ForwardingHeaders/runtime/JSLock.h:
+ * ForwardingHeaders/runtime/JSNumberCell.h:
+ * ForwardingHeaders/runtime/JSObject.h:
+ * ForwardingHeaders/runtime/JSString.h:
+ * ForwardingHeaders/runtime/JSValue.h:
+ * ForwardingHeaders/runtime/Lookup.h:
+ * ForwardingHeaders/runtime/ObjectPrototype.h:
+ * ForwardingHeaders/runtime/Operations.h:
+ * ForwardingHeaders/runtime/PropertyMap.h:
+ * ForwardingHeaders/runtime/PropertyNameArray.h:
+ * ForwardingHeaders/runtime/Protect.h:
+ * ForwardingHeaders/runtime/PrototypeFunction.h:
+ * ForwardingHeaders/runtime/StringObject.h:
+ * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h:
+ * ForwardingHeaders/runtime/StringPrototype.h:
+ * ForwardingHeaders/runtime/Structure.h:
+ * ForwardingHeaders/runtime/SymbolTable.h:
+ * ForwardingHeaders/runtime/UString.h:
+ * ForwardingHeaders/wrec/WREC.h:
+ * ForwardingHeaders/wtf/ASCIICType.h:
+ * ForwardingHeaders/wtf/AlwaysInline.h:
+ * ForwardingHeaders/wtf/Assertions.h:
+ * ForwardingHeaders/wtf/ByteArray.h:
+ * ForwardingHeaders/wtf/CurrentTime.h:
+ * ForwardingHeaders/wtf/Deque.h:
+ * ForwardingHeaders/wtf/DisallowCType.h:
+ * ForwardingHeaders/wtf/FastMalloc.h:
+ * ForwardingHeaders/wtf/Forward.h:
+ * ForwardingHeaders/wtf/GetPtr.h:
+ * ForwardingHeaders/wtf/HashCountedSet.h:
+ * ForwardingHeaders/wtf/HashFunctions.h:
+ * ForwardingHeaders/wtf/HashMap.h:
+ * ForwardingHeaders/wtf/HashSet.h:
+ * ForwardingHeaders/wtf/HashTable.h:
+ * ForwardingHeaders/wtf/HashTraits.h:
+ * ForwardingHeaders/wtf/ListHashSet.h:
+ * ForwardingHeaders/wtf/ListRefPtr.h:
+ * ForwardingHeaders/wtf/Locker.h:
+ * ForwardingHeaders/wtf/MainThread.h:
+ * ForwardingHeaders/wtf/MathExtras.h:
+ * ForwardingHeaders/wtf/MessageQueue.h:
+ * ForwardingHeaders/wtf/Noncopyable.h:
+ * ForwardingHeaders/wtf/NotFound.h:
+ * ForwardingHeaders/wtf/OwnArrayPtr.h:
+ * ForwardingHeaders/wtf/OwnPtr.h:
+ * ForwardingHeaders/wtf/PassRefPtr.h:
+ * ForwardingHeaders/wtf/Platform.h:
+ * ForwardingHeaders/wtf/PtrAndFlags.h:
+ * ForwardingHeaders/wtf/RandomNumber.h:
+ * ForwardingHeaders/wtf/RefCounted.h:
+ * ForwardingHeaders/wtf/RefCountedLeakCounter.h:
+ * ForwardingHeaders/wtf/RefPtr.h:
+ * ForwardingHeaders/wtf/RetainPtr.h:
+ * ForwardingHeaders/wtf/StdLibExtras.h:
+ * ForwardingHeaders/wtf/StringExtras.h:
+ * ForwardingHeaders/wtf/ThreadSpecific.h:
+ * ForwardingHeaders/wtf/Threading.h:
+ * ForwardingHeaders/wtf/TypeTraits.h:
+ * ForwardingHeaders/wtf/UnusedParam.h:
+ * ForwardingHeaders/wtf/Vector.h:
+ * ForwardingHeaders/wtf/VectorTraits.h:
+ * ForwardingHeaders/wtf/dtoa.h:
+ * ForwardingHeaders/wtf/unicode/Collator.h:
+ * ForwardingHeaders/wtf/unicode/UTF8.h:
+ * ForwardingHeaders/wtf/unicode/Unicode.h:
+ * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h:
+
+2009-04-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ Use a template function to generalize the way we create non-caching
+ JS function getters.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::nonCachingStaticFunctionGetter):
+ (WebCore::JSDOMWindow::customGetOwnPropertySlot):
+
+2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25099
+
+ When creating a QNetworkRequest make sure to populate the
+ CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
+
+ * WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:
+ (tst_QWebPage::requestCache):
+
+ * platform/network/qt/ResourceRequestQt.cpp:
+ (WebCore::ResourceRequest::toNetworkRequest):
+
+2009-04-14 Timothy Hatcher <timothy@apple.com>
+
+ Fix a world leak caused by opening the Web Inspector. This was
+ a regression caused by the InspectorController becoming refcounted.
+
+ <rdar://problem/6782944>
+
+ Reviewed by Darin Adler.
+
+ * bindings/js/ScriptObject.cpp:
+ (WebCore::ScriptGlobalObject::get): Renamed to better match the
+ other functions.
+ (WebCore::ScriptGlobalObject::remove): Added. Deletes the property.
+ * bindings/js/ScriptObject.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::~InspectorController): Do less work
+ at destruction time since the object lifetime is tied to JS GC.
+ Assert that inspectedPageDestroyed cleared everything needed.
+ (WebCore::InspectorController::inspectedPageDestroyed): Do most
+ of the work that ~InspectorController was doing.
+ (WebCore::InspectorController::scriptObjectReady): Renamed getObject.
+
+2009-04-14 Antony Sargent <asargent@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ This is some cleanup motivated by the crash in http://crbug.com/9775 , which
+ happens because of calling window.open inside a window.onload handler.
+
+ These changes are just part of the fix, along with some asserts to help prevent
+ breakage on future changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25132
+
+ * bindings/v8/V8EventListenerList.cpp:
+ (WebCore::V8EventListenerList::add):
+ (WebCore::V8EventListenerList::remove):
+ (WebCore::V8EventListenerList::clear):
+ * bindings/v8/V8EventListenerList.h:
+ (WebCore::V8EventListenerList::size):
+
+2009-04-14 Evan Martin <evan@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25142
+ Fix a race that can occur between flex and the perl script that parses
+ its output.
+
+ * css/maketokenizer: Consume all input.
+
+2009-04-14 Rohit Rao <rohitrao@google.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25184
+ Do not change the text color for selected text in Mac Chromium.
+
+ * rendering/RenderThemeChromiumMac.h:
+ (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
+ Now returns false, matching the behavior of Safari on Mac.
+
+2009-04-14 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25172
+ Extra partial layout during the first keypress in an empty block
+
+ Determining if a placeholder needs to be removed requires the creation of a VisiblePosition
+ which was triggering layout before we were finished modifying the DOM for the insert operation.
+
+ Find out if we need to remove a placeholder near the start of the operation, and if we do remember
+ where it's located. Then, later, remove it along with all of the other DOM operations we perform.
+
+ Renamed lineBreakExistsAtPosition to lineBreakExistsAtVisiblePosition and added a lineBreakExistsAtPosition
+ that takes in a Position. In InsertTextCommand, we can use the latter, since we normalize manually.
+
+ removePlaceholderAt now takes in a Position that it assumes has already been checked for a placeholder.
+
+ No test added as this only effects performance.
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::removePlaceholderAt):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+ (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
+ * editing/CompositeEditCommand.h:
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
+ (WebCore::DeleteSelectionCommand::doApply):
+ * editing/FormatBlockCommand.cpp:
+ (WebCore::FormatBlockCommand::doApply):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::input):
+ * editing/htmlediting.cpp:
+ (WebCore::lineBreakExistsAtVisiblePosition):
+ (WebCore::lineBreakExistsAtPosition):
+ * editing/htmlediting.h:
+
+2009-04-14 Adam Roben <aroben@apple.com>
+
+ Remove support for profile-guided optimization on Windows
+
+ Rubber-stamped by Steve Falkenburg.
+
+ * WebCore.vcproj/WebCore.vcproj: Removed the Release_PGO
+ configuration.
+
+2009-04-14 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25163
+ Upstream fix for releasing v8 objects on worker thread termination in Chromium.
+
+ * bindings/v8/V8DOMMap.cpp:
+ (WebCore::domDataList): Now uses Vector instead of HashMap.
+ (WebCore::domDataListMutex):
+ (WebCore::ThreadSpecificDOMData::ThreadSpecificDOMData): remove usage of currentThread();
+ (WebCore::ThreadSpecificDOMData::~ThreadSpecificDOMData): ditto.
+ (WebCore::NonMainThreadSpecificDOMData::~NonMainThreadSpecificDOMData): moved call to removeAllDOMObjectsInCurrentThread() to ~WorkerScriptController.
+ (WebCore::handleWeakObjectInOwningThread):
+ (WebCore::derefDelayedObjects):
+ (WebCore::removeAllDOMObjectsInCurrentThread): not static anymore.
+ * bindings/v8/V8DOMMap.h:
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::dispose): removed code that avoided dual-dereference of WorkerContext.
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): this ref() is countered in removeAllDOMObjectsInCurrentThread(), when the WorkerContext is removed from the v8 map.
+ * bindings/v8/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::~WorkerScriptController):
+
+2009-04-14 Adam Roben <aroben@apple.com>
+
+ Fix Bug 25183: Split up WebCore.vcproj's settings into vsprops files
+
+ <https://bugs.webkit.org/show_bug.cgi?id=25183>
+
+ WebCore.vcproj now uses a set of .vsprops files to store most of its
+ settings.
+
+ Reviewed by Darin Adler.
+
+ * WebCore.vcproj/WebCore.vcproj: Moved settings from here into the new
+ .vsprops files.
+
+ * WebCore.vcproj/WebCoreCFNetwork.vsprops: Added. Contains settings
+ for ports that build against CFNetwork.
+ * WebCore.vcproj/WebCoreCG.vsprops: Added. Contains settings for ports
+ that build against CoreGraphics.
+ * WebCore.vcproj/WebCoreCURL.vsprops: Added. Contains settings for
+ ports that build against libcurl.
+ * WebCore.vcproj/WebCoreCairo.vsprops: Added. Contains settings for
+ ports that build against Cairo.
+ * WebCore.vcproj/WebCoreCommon.vsprops: Added. Contains settings
+ shared by all ports.
+ * WebCore.vcproj/WebCoreMediaQT.vsprops: Added. Contains settings for
+ ports that use QTMovieWin to implement the MediaPlayerPrivate
+ interface.
+ * WebCore.vcproj/WebCorePthreads.vsprops: Added. Contains settings for
+ ports that build against pthreads.
+
+2009-04-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ http/tests/xmlhttprequest/basic-auth.html fails on Tiger.
+
+ Turns out that NSURLCredentialPersistenceNone doesn't work on Tiger, so we have to use
+ session persistence.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Route the credential through
+ receivedCredential(), ensuring that the Tiger-specific need to use session credentials
+ is honored.
+ (WebCore::ResourceHandle::receivedCredential): On Tiger, change PersistenceNone to
+ PersistenceForSession, because the former doesn't work.
+
+2009-04-14 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
+
+ Test: editing/inserting/6703873.html
+
+ * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
+ If the startNode's original parent is now empty, we can remove it. Its already been cloned and copied with the startNode,
+ so we only need to keep it around if it actually holds some original content, otherwise it will look like an extra empty
+ container in the document.
+
+2009-04-14 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Add a proper implementation of AtkText::get_text and
+ AtkText::get_character_count, which takes into account non
+ TextControl text. With this the 'Text' field in Accerciser's
+ Interface Viewer is filled correctly.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-14 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Remove some dead code and g_return_if_fail from static functions.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-14 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Also implement text interface for StaticTextRole, which covers
+ most of the text in web pages.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Another Windows build fix.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::WebCoreSynchronousLoader::load):
+
+2009-04-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Windows build fix.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::WebCoreSynchronousLoader::willSendRequest):
+ (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
+
+2009-04-13 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6698851> Implement XMLHttpRequest withCredentials attribute
+
+ * WebCore.xcodeproj/project.pbxproj: Made ThreadableLoader.h private, as enum definitions
+ from it are now used in otehr private headers.
+
+ * xml/XMLHttpRequest.h:
+ * xml/XMLHttpRequest.idl:
+ Added withCredentials attribute. When it is false (default), neither credentials nor cookies
+ are sent with cross origin requests, When it is true, those are sent, but the server needs
+ to allow handling results via Access-Control-Allow-Credentials header. It was always possible
+ to send a cross-site request with credentials via IFRAME or IMG, so this just adds a way to
+ read results, as long as the server reports that it's allowed.
+ Having the default set to false ensures that requests won't fail unexpectedly because of
+ stored credentials and cookies for other resources in the target protection space.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestSynchronously): Allow stored credentials for same origin
+ requests, and for cross origin ones that have withCredentials attribute set. Such code already
+ existed for cookies (but it's simpler, because we could just set a ResourceRequest flag).
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
+
+ * platform/network/ResourceHandle.h: Added willSendRequest() - just like for other callbacks,
+ is is easier to have code in the class. Also, loadResourceSynchronously() now takes a
+ StoredCredentials option, matching async case.
+
+ * platform/network/ResourceHandleClient.h:
+ (WebCore::ResourceHandleClient::receivedCredential): Removed. This method could never be
+ called, and no client used it.
+ (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): Ditto.
+
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal): Split username and password out
+ of request URL. We want to always get a callback for credentials to manage them in WebCore,
+ so network back-end shouldn't see them too early.
+
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::removeCredentials):
+ * platform/network/ResourceRequestBase.h:
+ Added a removeCredentials() method that removes login and password parts from request URL.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCoreCredentialStorage): Added a simple storage class for per-session credentials.
+ (WebCore::ResourceHandle::loadResourceSynchronously): Pass allowStoredCredentials through.
+ (WebCore::ResourceHandle::willSendRequest): On a redirect, credentials should be replaced.
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try credentials from the URL
+ and per-session credentials. Code was partially moved from Obj-C callback.
+ (WebCore::ResourceHandle::receivedCredential): Intercept per-session credentials and store
+ them in WebCore storage.
+ (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Don't
+ store the redirected URL - we only needed credentials, which are now stored separately.
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Removed
+ code that was setting credentials from URL. First, the code is now in ResourceHandle, and
+ also, it wasn't actually needed in Leopard release before this patch, see <rdar://problem/5298142>.
+ (-[WebCoreSynchronousLoader dealloc]): Release credentials. Note that unlike ResourceHandle,
+ this class still needs to track URL for checking whether a redirect is allowed. This is
+ not a great solution, and we should unify client code to use the same checks in sync and
+ async cases.
+ (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Just like in
+ async case, put credentials aside to ensure that network back-end asks for them.
+ (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use credentials
+ from URL, or from WebCore storage.
+ (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Don't use stored
+ credentials when not allowed to.
+ (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
+ Put credentials aside to ensure that network back-end asks for them.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::WebCoreCredentialStorage::set):
+ (WebCore::WebCoreCredentialStorage::get):
+ (WebCore::willSendRequest):
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::willSendRequest):
+ (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+ (WebCore::ResourceHandle::receivedCredential):
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ (WebCore::WebCoreSynchronousLoader::willSendRequest):
+ (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
+ (WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage):
+ (WebCore::WebCoreSynchronousLoader::load):
+ Same changes as in Mac case.
+
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ * platform/network/qt/ResourceHandleQt.cpp:
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ Trying not to break the build.
+
+ * dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
+ * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
+ Unconditionally allow stored credentials for these, as they only support same origin loads.
+
+ * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
+ WorkerContext.importScripts() can be cross-origin, but sending credentials with it is no worse
+ than sending them with <script src=...>, so this is also unconditionally allowed.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Pass through storedCredentials.
+ (WebCore::DocumentThreadableLoader::create): Ditto.
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Save storedCredentials and
+ sameOrigin flags foruse in callbacks.
+ (WebCore::DocumentThreadableLoader::willSendRequest): Assert that loaders aren't all confused.
+ (WebCore::DocumentThreadableLoader::didSendData): Ditto.
+ (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
+ (WebCore::DocumentThreadableLoader::didReceiveData): Ditto.
+ (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
+ (WebCore::DocumentThreadableLoader::didFail): Ditto.
+ (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Don't use credential
+ storage if that's not allowed by the code that invoked DocumentThreadableLoader.
+ (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Simulate a failure
+ and cancel the request if we are about to ask the user for credentials for a cross-origin
+ request, which is forbidden by CORS (and would have been very confusing if allowed).
+ (WebCore::DocumentThreadableLoader::receivedCancellation): Assert that loaders aren't all confused.
+
+ * loader/DocumentThreadableLoader.h: Updated for the new flags (storedCredentials and
+ sameOrigin) that affect the loader. Eventually, we need to move all CORS logic from XHR here.
+
+ * loader/ThreadableLoader.h: (StoredCredentials): Added another flag that affects loader
+ behavior. We should combine all of these into a structure, and use it for sync requests, too.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
+ * loader/FrameLoader.h:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ * loader/WorkerThreadableLoader.h:
+ (WebCore::WorkerThreadableLoader::create):
+ Pass through storedCredentials.
+
+2009-04-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Remove an outdated comment in ScrollView.h
+
+ * platform/ScrollView.h:
+
+2009-04-13 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25177
+
+ QTTrack's -media method always return NULL in 64-bit QTKit, so
+ MediaPlayerPrivate::disableUnsupportedTracks should use
+ QTTrackMediaTypeAttribute to get a track's type.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ Stop using protected event listeners on the window object.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're
+ no longer protected.
+
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener): Create unprotected event
+ listeners, since we mark them now.
+
+ * bindings/js/JSEventListener.h: Made some functions public so
+ DOMWindow could call them.
+
+ * bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header,
+ so it could be shared.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking
+ and invalidating code for the DOMWindow.
+
+ * dom/RegisteredEventListener.h:
+ (WebCore::markEventListeners):
+ (WebCore::invalidateEventListeners): Added helper functions.
+
+ * page/DOMWindow.idl: Make the window's event listener attributes not
+ protected.
+
+2009-04-13 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25155
+
+ OS X standalone media documents should not switch from <video> to <embed> when
+ QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
+ with a slow network connection or when a movie is not saved fast-start.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's
+ loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
+
+2009-04-13 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24453
+ REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
+ the main document that timer callback makes are not flushed.
+
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded()
+ since timers may affect documents other then their own.
+
+2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by David Hyatt.
+
+ Check document for nullity to avoid crashing on GTK+, when
+ creating the WebView.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::needsLayout):
+
+2009-04-13 Ada Chan <adachan@apple.com>
+
+ Forgot to capitalize the "US".
+
+ * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
+ (WebCore::currentTextBreakLocaleID):
+
+2009-04-13 Ada Chan <adachan@apple.com>
+
+ <rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
+ Revert back to the old word breaking behavior by using en_US_POSIX locale.
+
+ Reviewed by Steve Falkenburg.
+
+ * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
+ (WebCore::currentTextBreakLocaleID):
+
+2009-04-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ * platform/cf/BinaryPropertyList.cpp: Added comment.
+ * platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
+
+2009-04-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
+ https://bugs.webkit.org/show_bug.cgi?id=25158
+ rdar://problem/6769693
+
+ Test: editing/selection/click-after-nested-block.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint
+ can share code.
+ (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first
+ child box. Changed special case for last child box to propertly handle the various
+ types of child box that are not hit test candidates (the same ones already handled
+ by the hit test loop below), adding in a loop so we find the last candidate.
+
+2009-04-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
+ it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
+
+ * WebCore.base.exp:
+ * page/FrameView.h:
+ (WebCore::FrameView::visibleContentsResized):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/ScrollView.h:
+
+2009-04-13 Adam Roben <aroben@apple.com>
+
+ Add SharedBuffer::wrapCFData
+
+ This is the CF-equivalent of wrapNSData.
+
+ Reviewed by Brady Eidson.
+
+ * platform/SharedBuffer.h:
+ * platform/cf/SharedBufferCF.cpp:
+ (WebCore::SharedBuffer::wrapCFData):
+
+2009-04-13 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * page/EventHandler.cpp:
+ (WebCore::documentPointForWindowPoint):
+
+2009-04-13 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6740294> Increase the connection count per host
+
+ Try to use six connections per host if possible.
+
+ * WebCore.base.exp:
+ * loader/loader.cpp:
+ (WebCore::Loader::Loader):
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm:
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::initMaximumHTTPConnectionCountPerHost):
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/mac/ResourceRequestMac.mm:
+ (WebCore::initMaximumHTTPConnectionCountPerHost):
+
+2009-04-13 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25153
+ Can't place the caret into text field that scrolls the window on focus
+
+ We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
+ be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
+ coordinate) and use that any time we refetch.
+
+ * page/EventHandler.cpp:
+ (WebCore::documentPointForWindowPoint):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::prepareMouseEvent):
+
+2009-04-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
+ to conform to our style guidelines.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::allowPopUp):
+ * page/Settings.h:
+ (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Mac build fix: Made another header private.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-04-13 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25121
+ Upstream changes to handle error messages from V8 when running worker script.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::reportFatalErrorInV8):
+ (WebCore::handleConsoleMessage):
+ (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
+ (WebCore::WorkerContextExecutionProxy::dispose):
+ (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
+ (WebCore::WorkerContextExecutionProxy::evaluate):
+ * bindings/v8/WorkerContextExecutionProxy.h:
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix: Made setInlineEventListenerForType not inline, since Document
+ calls it now. Made RegisteredEventListener.h a private header on Mac,
+ so WebKit can use it.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setInlineEventListenerForType):
+
+2009-04-13 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6404439> REGRESSION: Overlapping text and other
+ layout issues in View Sample feature of MYOB FIrstEdge v3
+
+ * page/Navigator.cpp:
+ (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of
+ JavaScript files this quirk applies to.
+
+2009-04-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Move open and showModalDialog functions out of JSDOMWindowBase
+ and into JSDOMWindow by partially generating them.
+
+ This slightly changes the behavior of getting window.showModalDialog
+ when the embedding app does not support it to return undefined regardless
+ of shadowing. This should not be an issue in a practice, but will be addressed
+ when we add a generic way to handle runtime specialization of property
+ access.
+
+ * DerivedSources.make: Remove JSDOMWindowBase.lut.h
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::):
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from
+ here to JSDOMWindow::customGetOwnPropertySlot.
+ (WebCore::JSDOMWindowBase::put): Remove dead code.
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::createWindow):
+ (WebCore::JSDOMWindow::open):
+ (WebCore::JSDOMWindow::showModalDialog):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customGetOwnPropertySlot):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase.
+ (WebCore::DOMWindow::allowPopUp): Ditto.
+ (WebCore::DOMWindow::canShowModalDialog): Ditto.
+ (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2009-04-13 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Moved storage for window event listeners into the window object.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener): Add / remove window event
+ listeners to / from the window object.
+
+ * dom/Document.cpp:
+ (WebCore::Document::removeAllEventListeners):
+ (WebCore::Document::clear):
+ (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved
+ a bunch of code to the DOMWindow class, and left behind a few calls through
+ to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
+
+ * dom/Document.h: ditto.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchGenericEvent):
+ (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window
+ object, not the document.
+
+ * dom/Node.h:
+ * dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector
+ declaration, since it's required in more places now.
+
+ * history/CachedFrame.cpp:
+ (WebCore::CachedFrame::clear): Updated for rename. Also, remove event
+ listeners before detaching and clearing the document's window pointer,
+ since the the document needs its window pointer in order to tell the window
+ to clear its event listeners.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::canCachePageContainingThisFrame):
+ (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and
+ movement of window event listeners into the window.
+
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageDocument::createDocumentStructure): Updated for movement
+ of window event listeners into the window.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::handleEvent):
+ (WebCore::DOMWindow::addEventListener):
+ (WebCore::DOMWindow::removeEventListener):
+ (WebCore::DOMWindow::removeAllEventListeners):
+ (WebCore::DOMWindow::hasEventListener):
+ (WebCore::DOMWindow::setInlineEventListenerForType):
+ (WebCore::DOMWindow::removeInlineEventListenerForType):
+ (WebCore::DOMWindow::inlineEventListenerForType):
+ (WebCore::DOMWindow::addPendingFrameUnloadEventCount):
+ (WebCore::DOMWindow::removePendingFrameUnloadEventCount):
+ (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount):
+ (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
+ * page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
+
+2009-04-13 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25149
+
+ The Geolocation timer needs to start after the UA has granted permission.
+
+ * bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions>
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used
+ later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions>
+ where needed.
+ (WebCore::Geolocation::GeoNotifier::GeoNotifier):
+ (WebCore::Geolocation::GeoNotifier::startTimer):
+ (WebCore::Geolocation::getCurrentPosition):
+ (WebCore::Geolocation::watchPosition):
+ (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows
+ (WebCore::Geolocation::startTimer):
+ (WebCore::Geolocation::startTimersForOneShots):
+ (WebCore::Geolocation::startTimersForWatchers):
+ (WebCore::Geolocation::startTimers):
+ * page/Geolocation.h:
+ (WebCore::Geolocation::GeoNotifier::create):
+
+2009-04-13 Pamela Greene <pam@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Fix Chromium (V8) build by renaming methods to match changes
+ in http://trac.webkit.org/changeset/42377.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25141
+
+ * bindings/v8/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
+
+2009-04-13 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25136
+ CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
+
+ Test: fast/frames/frame-unload-crash.html
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
+
+2009-04-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Tim Hatcher.
+
+ Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.
+
+ * page/DOMWindow.idl:
+
+2009-04-13 Greg Bolsinga <bolsinga@apple.com>
+
+ Fix GTK build break.
+
+ * platform/gtk/GeolocationServiceGtk.cpp:
+ (WebCore::GeolocationServiceGtk::updatePosition):
+
+2009-04-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler and Dan Bernstein.
+
+ Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
+ the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
+ Schedule a style recalc if needed when an object comes out of the page cache.
+
+ * dom/Document.cpp:
+ (WebCore::Document::scheduleStyleRecalc):
+ (WebCore::Document::setInPageCache):
+
+2009-04-13 Timothy Hatcher <timothy@apple.com>
+
+ Correctly sort (program) scripts in the Scripts panel popup menu.
+
+ Reviewed by Ada Chan.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code
+ and sort "(program)" options by the sourceID to maintain some order.
+ * inspector/front-end/utilities.js:
+ (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause
+ an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction.
+ Just set 'first' and break so the correct result will be returned.
+
+2009-04-13 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24770
+
+ Add custom code for Coordinates that returns null when required by the
+ Geolocation spec.
+
+ http://dev.w3.org/geo/api/spec-source.html#coordinates
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSCoordinatesCustom.cpp: Added.
+ (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided.
+ (WebCore::JSCoordinates::altitudeAccuracy): Ditto
+ (WebCore::JSCoordinates::heading): Ditto
+ (WebCore::JSCoordinates::speed): Ditto
+ * page/Coordinates.h:
+ (WebCore::Coordinates::create): Add 'canProvide' parameters and values
+ (WebCore::Coordinates::canProvideAltitude):
+ (WebCore::Coordinates::canProvideAltitudeAccuracy):
+ (WebCore::Coordinates::canProvideHeading):
+ (WebCore::Coordinates::canProvideSpeed):
+ (WebCore::Coordinates::Coordinates):
+ * page/Coordinates.idl: specify custom getters
+ * platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided.
+ (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
+
+2009-04-13 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
+
+ Test: editing/inserting/5510537.html
+
+ * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position
+ is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break
+ insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level
+ so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
+
+2009-04-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix problem when encoding history files with duplicate integer arrays near the end of the file.
+ This results in an assertion failure, and if assertions are turned off, corrupted output.
+
+ When writing an integer array it's important not to add an object reference to the
+ aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
+ more importantly, it's possible this instance integer array is a duplicate and won't be
+ written out. If so, there's no guarantee there's enough space in the aggregate buffer to
+ store the object references (the references will be ignored). In some cases the aggregate
+ buffer can then overrun the data being written; normally this is prevented by the fact that
+ the data being written will include a copy of the aggregate buffer.
+
+ Also removed a bit of unneeded dead code to handle the integer -1.
+
+ * platform/cf/BinaryPropertyList.cpp:
+ (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded
+ m_integerNegativeOneObjectReference, since property lists support only non-negative integers.
+ (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for
+ m_integerNegativeOneObjectReference.
+ (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto.
+ (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference):
+ Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling
+ addAggregateObjectReference.
+ (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new
+ writeIntegerWithoutAddingAggregateObjectReference function.
+ (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new
+ writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the
+ code to save and restore m_currentAggregateBufferByte, which is no longer needed.
+
+2009-04-13 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed Qt build fix.
+
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::Font::floatWidthForComplexText):
+
+2009-04-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Move the event and crypto attributes and the captureEvents and releaseEvents
+ functions out of JSDOMWindowBase by partially generating them.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::currentEvent): Make const.
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::crypto): Not implemented.
+ (WebCore::JSDOMWindow::event):
+ (WebCore::JSDOMWindow::captureEvents): Not implemented.
+ (WebCore::JSDOMWindow::releaseEvents): Ditto.
+ * page/DOMWindow.idl:
+
+2009-04-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Move more attributes out of JSDOMWindowBase by
+ partially generating them.
+
+ - Expose the MessagePort constructor.
+
+ * bindings/js/JSDOMGlobalObject.h:
+ (WebCore::getDOMConstructor):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (setJSDOMWindowBaseEvent):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::image):
+ (WebCore::JSDOMWindow::option):
+ (WebCore::JSDOMWindow::audio):
+ (WebCore::JSDOMWindow::webKitPoint):
+ (WebCore::JSDOMWindow::webKitCSSMatrix):
+ (WebCore::JSDOMWindow::xMLHttpRequest):
+ (WebCore::JSDOMWindow::xSLTProcessor):
+ (WebCore::JSDOMWindow::messageChannel):
+ (WebCore::JSDOMWindow::worker):
+ * page/DOMWindow.idl:
+
+2009-04-12 Timothy Hatcher <timothy@apple.com>
+
+ A resource's filename is not correct after a redirect in the Inspector.
+
+ Reviewed by Dan Bernstein.
+
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::updateScriptObject): Fix a typo in the
+ lastPathComponent property name.
+
+2009-04-12 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Test: editing/inserting/6609479-1.html
+
+ Follow-up to <rdar://problem/6609479>.
+
+ Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
+ was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
+ at the start of a paragraph.
+
+ * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):
+
+2009-04-11 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
+
+ Test: editing/inserting/6609479.html
+
+ Don't break a blockquote if pasting or inserting into a table.
+
+ * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
+ * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
+
+2009-04-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6643103> Unscaled values from body.scrollHeight
+
+ Test: fast/css/zoom-body-scroll.html
+
+ Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
+ setters.
+
+ * html/HTMLBodyElement.cpp:
+ (WebCore::adjustForZoom):
+ (WebCore::HTMLBodyElement::scrollLeft):
+ (WebCore::HTMLBodyElement::setScrollLeft):
+ (WebCore::HTMLBodyElement::scrollTop):
+ (WebCore::HTMLBodyElement::setScrollTop):
+ (WebCore::HTMLBodyElement::scrollHeight):
+ (WebCore::HTMLBodyElement::scrollWidth):
+
+2009-04-10 Timothy Hatcher <timothy@apple.com>
+
+ Allow page navigation and reload while stopped at a breakpoint.
+
+ <rdar://problem/6781108> Having a breakpoint active prevents page reload
+
+ Reviewed by Darin Adler.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didContinue): Call the resumedScript function.
+ * inspector/InspectorController.h: Added didContinue.
+ * inspector/JavaScriptDebugListener.h: Ditto.
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
+ * inspector/front-end/inspector.js:
+ (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
+
+2009-04-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ Remove unused include for JSLock.
+
+ * page/mac/FrameMac.mm:
+
+2009-04-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Add back the keepAlive timer for after the script execution to
+ protect the callers of evaluate, as was part of the original intent
+ of timer.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * page/mac/FrameMac.mm:
+
+2009-04-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=25137
+
+ If we reload, the animation controller sticks around and has
+ a stale animation time. So the needed delay is computed wrong.
+ I added a reset of the animation timer on load.
+
+ I did not do a test case because this only happens on reload so I
+ couldn't make an automated test. I tried using an iframe and using
+ reload() but that doesn't tickle the bug.
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitOpen):
+
+2009-04-10 Grace Kloba <klobag@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Move WORKERS header files inside ENABLE(WORKERS).
+ So if WORKERS is not enabled and the generated files are not generated, the build is still working.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ * bindings/js/ScheduledAction.cpp:
+
+2009-04-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ <rdar://problem/6773515> crash in push_heap inside WebCore when printing
+
+ The crash was due to manipulating a timer on a different thread than the one it was created on.
+ This adds some diagnostics so we'll catch that kind of mistake immediately.
+
+ * platform/Timer.cpp:
+ (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions.
+ (WebCore::TimerBase::start): Assert it's the same thread the timer was created on.
+ (WebCore::TimerBase::stop): Ditto.
+ (WebCore::TimerBase::isActive): Ditto.
+ (WebCore::TimerBase::setNextFireTime): Ditto.
+
+ * platform/Timer.h: Added the thread identifier data member.
+
+2009-04-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=25108
+
+ If you remove a class with a transition while that transition is running
+ the animation timer will continue to fire after the transition is finished.
+ This has no visual indication, but it does drain the processor. And in some
+ cases it might even cause a glitch in future animations. Unfortunately there
+ is no way to test this without putting in printfs.
+
+ This happens because the animation logic is never traversed after a transition
+ is removed, so we never get a chance to cleanup. So I added cleanup in the logic
+ that fires the dispatch of the last style change when the animation finishes.
+
+ Test: transitions/remove-transition-style.html
+
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::animate):
+ (WebCore::CompositeAnimation::cleanupFinishedAnimations):
+ * page/animation/CompositeAnimation.h:
+
+2009-04-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for <rdar://problem/6648858>
+ CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241
+
+ The Frame (and therefore ScriptController) were being destroyed
+ during JavaScript execution causing the JSDOMWindowShell to become
+ null.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame
+ instead of the keep-alive timer, since a nested event loop used from with-in
+ JavaScript execution could cause the timer to fire before returning.
+
+2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25133
+ Fix an error in InspectorController's bindings, clean up a few header
+ includes, make empty object construction in ScriptObject less ambiguous.
+
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::setSetting): Send correct argument from
+ the bindings.
+ * bindings/js/ScriptObject.cpp:
+ (WebCore::ScriptObject::createNew): Added.
+ * bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
+ * inspector/ConsoleMessage.cpp: Remove unused header.
+ * inspector/ConsoleMessage.h: Ditto.
+ * inspector/InspectorResource.cpp:
+ (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
+
+2009-04-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=25134
+
+ This both fixes a bug where I was not sending in the right time
+ to continue the animation and was not recomputing current time
+ when coming out of suspend.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::suspendAnimations):
+ (WebCore::AnimationControllerPrivate::resumeAnimations):
+
+2009-04-10 Adam Roben <aroben@apple.com>
+
+ Give Windows's <select> popup menus drop shadows
+
+ Rubber-stamped by Steve Falkenburg.
+
+ No test possible.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
+
+2009-04-10 Timothy Hatcher <timothy@apple.com>
+
+ Fix a bug in the Web Inspector where it would show scripts
+ from previous pages when toggling the debugger off and back on.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25095
+ rdar://problem/6769970
+
+ Reviewed by John Sullivan.
+
+ * bindings/js/ScriptCachedFrameData.cpp:
+ (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the
+ debugger for the scriptController. This balances the attachDebugger
+ that was already in ScriptCachedFrameData::restore.
+ (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::clearWindowShell): Clear the debugger from
+ the current window before setting the new window.
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate
+ source providers for code associated this as the debugger.
+
+2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6646998> Avoid starting QTKitServer if possible
+ When possible avoid asking QTKit for the MIME types that require QTKitServer
+ when running 64-bit.
+
+ * WebCore.base.exp: Added new entry point.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::addFileTypesToCache): Add an NSArray of types to the cache.
+ (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache.
+ (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does
+ not start QTKitServer if it is not already running).
+ (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored.
+ (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid
+ starting QTKitServer if possible.
+
+ * platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
+ * platform/mac/WebCoreSystemInterface.mm: Ditto.
+
+2009-04-10 Adam Roben <aroben@apple.com>
+
+ Turn on window animations for <select> popup menus
+
+ We turned these off back when <select> popup menus were partially
+ transparent. Now that they're opaque, there's no reason not to
+ animate them.
+
+ Reviewed by Steve Falkenburg.
+
+ No test possible.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the
+ window animation.
+
+2009-04-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix a regression from r42379 which made zero-width characters affect
+ line height
+
+ Test: fixes fast/text/wide-zero-width-space.html
+
+ * platform/graphics/mac/FontMacATSUI.mm:
+ (WebCore::overrideLayoutOperation): Add to the fallback font list set
+ here, and only if the glyph is not zero-width...
+ (WebCore::ATSULayoutParameters::initialize): ...instead of doing it
+ here. This matches WidthIterator's behavior.
+
+2009-04-10 Darin Fisher <darin@chromium.org>
+
+ Fixing build bustage caused by warnings being treated as errors.
+ 1- A local variable was only be used inside a debug assertion, which
+ caused grief for the release build.
+ 2- Missing initializer for member 'DocumentMarker::activeMatch'
+
+ * dom/Document.cpp:
+ (WebCore::Document::addMarker):
+ (WebCore::Document::setMarkersActive):
+
+2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>
+
+ Reviewed by John Sullivan.
+
+ Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
+ (TextMatches don't have a concept of active match)
+
+ For the ports that use the DocumentMarker as highlighting for FindInPage it is
+ useful to have a flag that specifies which marker is active, so it can be drawn
+ in a different color.
+
+ This allows me to remove the hack to use the SelectionController to highlight
+ the active match (in the ChromiumWin port).
+
+ * dom/Document.cpp:
+ (WebCore::Document::setMarkersActive):
+ * dom/Document.h:
+ * dom/DocumentMarker.h:
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintTextMatchMarker):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::platformActiveTextSearchHighlightColor):
+ (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
+ (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor):
+ (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
+ * rendering/RenderThemeChromiumWin.h:
+
+2009-04-10 Pamela Greene <pam@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Build fix for Chromium.
+ https://bugs.webkit.org/show_bug.cgi?id=12440
+
+ * page/chromium/FrameChromium.cpp:
+ (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
+
+2009-04-09 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Oliver Hunt
+
+ Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
+ to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
+ following DOM events and JavaScript timeouts. Eventually these calls will be removed.
+
+ Where the timer will really kick in and be useful is for clients that do style changes from
+ Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertBefore):
+ (WebCore::ContainerNode::replaceChild):
+ (WebCore::ContainerNode::removeChild):
+ (WebCore::ContainerNode::appendChild):
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::~Document):
+ (WebCore::Document::scheduleStyleRecalc):
+ (WebCore::Document::unscheduleStyleRecalc):
+ (WebCore::Document::styleRecalcTimerFired):
+ (WebCore::Document::updateStyleForAllDocuments):
+ (WebCore::Document::detach):
+ * dom/Document.h:
+ * dom/Node.cpp:
+ (WebCore::Node::setNeedsStyleRecalc):
+ (WebCore::Node::lazyAttach):
+
+2009-04-09 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ <rdar://problem/6586787> JS debugger does not work in 64-bit
+
+ Don't truncate the source id in JSCallFrame
+
+ * inspector/JavaScriptCallFrame.h:
+
+2009-04-09 Adam Roben <aroben@apple.com>
+
+ Start compiling HistoryPropertyList on Windows
+
+ Reviewed by Darin Adler.
+
+ * WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its
+ dependencies to the project. Copy headers from history/cf to
+ $WebKitOutputDir.
+ * history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that
+ this file will compile on Windows.
+
+2009-04-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6166612> Text boxes' metrics should be based on
+ the actual fonts used in them, not just the primary font
+
+ Covered by many existing layout tests
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
+ platform supports collecting fallback fonts in its complex font path
+ and fallbackFonts is not null, all fallback fonts used for the text run
+ will be added to it.
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::width): Ditto.
+
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
+ qualifier.
+ (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
+ parameter, which is passed down to WidthIterator.
+
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
+ and used it to initialize the m_fallbackFonts member.
+ (WebCore::WidthIterator::advance): Track the fonts being used and add
+ any fallback fonts to the m_fallbackFonts set. Make sure to only add
+ non-small-caps fonts.
+
+ * platform/graphics/WidthIterator.h:
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
+ implementation that returns false, meaning this platform's
+ implementation of floatWidthForComplexText() does not populate the
+ fallbackFonts set.
+ (WebCore::Font::floatWidthForComplexText): Updated for the new
+ prototype.
+
+ * platform/graphics/chromium/FontLinux.cpp: Ditto.
+
+ * platform/graphics/gtk/FontGtk.cpp: Ditto.
+
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
+ parameter and used it to initialize the m_fallbackFonts member.
+ (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
+ fallback fonts to m_fallbackFonts.
+
+ * platform/graphics/mac/CoreTextController.h:
+
+ * platform/graphics/mac/FontMac.mm:
+ (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
+ implementation that returns true, indicating that the Mac
+ implementations of floatWidthForComplexText() populate the fallbackFonts
+ set.
+ * platform/graphics/mac/FontMacATSUI.mm:
+ (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
+ fallbackFonts parameter and used it to initialize the m_fallbackFonts
+ member.
+ (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
+ m_fallbackFonts.
+ (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
+ parameter, which is passed down to ATSULayoutParameters.
+
+ * platform/graphics/mac/FontMacCoreText.cpp:
+ (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
+ parameter, which is passed down to CoreTextController.
+
+ * platform/graphics/win/FontWin.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
+ implementation that returns true, indicating that the
+ UniscribeController-based implementations of floatWidthForComplexText()
+ populate the fallbackFonts set.
+ (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
+ parameter, which is passed down to UniscribeController.
+
+ * platform/graphics/win/UniscribeController.cpp:
+ (WebCore::UniscribeController::UniscribeController): Added a
+ fallbackfonts parameter and used it to initialize m_fallbackFonts.
+ (WebCore::UniscribeController::advance): Add fallback fonts to
+ m_fallbackFonts.
+
+ * platform/graphics/win/UniscribeController.h:
+
+ * platform/graphics/wx/FontWx.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
+ implementation that returns false, meaning this platform's
+ implementation of floatWidthForComplexText() does not populate the
+ fallbackFonts set.
+ (WebCore::Font::floatWidthForComplexText): Updated for the new
+ prototype.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
+ with multiple fonts, compute a common baseline and line height by
+ considering all fonts' ascents and descents (and line spacing, if
+ applicable).
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
+ the set of fallback fonts in a vector.
+ (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
+ fonts previously stored and removes them from storage.
+
+ * rendering/InlineTextBox.h:
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText): Initialized the
+ m_knownNotToUseFallbackFonts to false.
+ (WebCore::RenderText::styleDidChange): Reset
+ m_knownNotToUseFallbackFonts to false if the style difference is such that
+ affects layout.
+ (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
+ which is passed down to Font::width().
+ (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
+ widthFromCache().
+ (WebCore::RenderText::calcPrefWidths): Made this call a private version
+ of calcPrefWidths() that takes a fallbackFonts parameter and set the
+ m_knownNotToUseFallbackFonts to true if the set comes back empty.
+ The private version passes the fallbackFonts set to widthFromCache().
+ (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
+ false.
+ (WebCore::RenderText::createFallbackFontMetricsBox): Added.
+ (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
+ passed down to calcPrefWidths(), widthFromCache() and Font::width().
+ Set m_knownNotToUseFallbackFonts to true when appropriate.
+
+ * rendering/RenderText.h:
+
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::constructLine): Added an assertion and a continue
+ statement to remove one level of indentation.
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
+ store the set of fallback fonts in the InlineTextBox.
+ (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
+ assertion.
+
+2009-04-09 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Adam Roben
+
+ Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
+ explicitly instead.
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::updateStyleIfNeededForBindings):
+ (WebCore::ScriptController::initJavaJSBindings):
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removeProperty):
+ (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
+ (WebCore::CSSMutableStyleDeclaration::setProperty):
+ (WebCore::CSSMutableStyleDeclaration::setStringProperty):
+ (WebCore::CSSMutableStyleDeclaration::setImageProperty):
+ (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
+ (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
+ (WebCore::CSSMutableStyleDeclaration::setCssText):
+ (WebCore::CSSMutableStyleDeclaration::merge):
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ * css/CSSMutableStyleDeclaration.h:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
+ (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
+ * css/CSSVariablesDeclaration.cpp:
+ (WebCore::CSSVariablesDeclaration::removeVariable):
+ (WebCore::CSSVariablesDeclaration::setVariable):
+ (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
+ * css/CSSVariablesDeclaration.h:
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertBefore):
+ (WebCore::ContainerNode::replaceChild):
+ (WebCore::ContainerNode::removeChild):
+ (WebCore::ContainerNode::appendChild):
+ (WebCore::ContainerNode::detach):
+ (WebCore::ContainerNode::setFocus):
+ (WebCore::ContainerNode::setActive):
+ (WebCore::ContainerNode::setHovered):
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::~Document):
+ (WebCore::Document::scheduleStyleRecalc):
+ (WebCore::Document::unscheduleStyleRecalc):
+ (WebCore::Document::recalcStyle):
+ (WebCore::Document::updateStyleIfNeeded):
+ (WebCore::Document::updateStyleForAllDocuments):
+ (WebCore::Document::updateLayout):
+ (WebCore::Document::implicitClose):
+ (WebCore::Document::prepareMouseEvent):
+ (WebCore::Document::setFocusedNode):
+ (WebCore::Document::setCSSTarget):
+ * dom/Document.h:
+ * dom/Element.cpp:
+ (WebCore::Element::recalcStyle):
+ (WebCore::checkForSiblingStyleChanges):
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::parseMaxLengthAttribute):
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+ * dom/Node.cpp:
+ (WebCore::Node::Node):
+ (WebCore::Node::setNeedsStyleRecalc):
+ (WebCore::Node::lazyAttach):
+ (WebCore::Node::dispatchGenericEvent):
+ * dom/Node.h:
+ (WebCore::Node::needsStyleRecalc):
+ (WebCore::Node::childNeedsStyleRecalc):
+ (WebCore::Node::setChildNeedsStyleRecalc):
+ * dom/OptionElement.cpp:
+ (WebCore::OptionElement::setSelectedState):
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::evaluateScript):
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::attributeChanged):
+ (WebCore::StyledElement::classAttributeChanged):
+ (WebCore::StyledElement::parseMappedAttribute):
+ * dom/Text.cpp:
+ (WebCore::Text::recalcStyle):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::enable):
+ * editing/Editor.cpp:
+ (WebCore::Editor::setBaseWritingDirection):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::nodeWillBeRemoved):
+ (WebCore::SelectionController::layout):
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::parseMappedAttribute):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::setInnerText):
+ (WebCore::HTMLElement::isContentEditable):
+ (WebCore::HTMLElement::isContentRichlyEditable):
+ (WebCore::HTMLElement::contentEditable):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::updateWidget):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ (WebCore::HTMLFrameSetElement::recalcStyle):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::setChecked):
+ (WebCore::HTMLInputElement::setIndeterminate):
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setAutofilled):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::finishParsingChildren):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::updateWidget):
+ (WebCore::HTMLObjectElement::finishParsingChildren):
+ (WebCore::HTMLObjectElement::childrenChanged):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::recalcStyle):
+ (WebCore::HTMLSelectElement::restoreState):
+ (WebCore::HTMLSelectElement::setRecalcListItems):
+ (WebCore::HTMLSelectElement::reset):
+ (WebCore::HTMLSelectElement::typeAheadFind):
+ * html/HTMLTableElement.cpp:
+ (WebCore::setTableCellsChanged):
+ (WebCore::HTMLTableElement::parseMappedAttribute):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::setValue):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::executeScript):
+ (WebCore::FrameLoader::gotoAnchor):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::alert):
+ (WebCore::DOMWindow::confirm):
+ (WebCore::DOMWindow::prompt):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hoverTimerFired):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::needsLayout):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::setNeedsStyleRecalc):
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
+ (WebCore::AnimationControllerPrivate::clear):
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
+ (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher):
+ (WebCore::AnimationControllerPrivate::addEventToDispatch):
+ (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
+ (WebCore::AnimationControllerPrivate::animationTimerFired):
+ (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
+ (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
+ (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
+ (WebCore::AnimationController::cancelAnimations):
+ * page/animation/AnimationControllerPrivate.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::endAnimation):
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::updateDragState):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::selectionBounds):
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::svgAttributeChanged):
+ * svg/SVGAnimationElement.cpp:
+ (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
+ * svg/SVGCursorElement.cpp:
+ (WebCore::SVGCursorElement::svgAttributeChanged):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::setNeedsUpdate):
+ * svg/SVGForeignObjectElement.cpp:
+ (WebCore::addCSSPropertyAndNotifyAttributeMap):
+ * svg/SVGStopElement.cpp:
+ (WebCore::SVGStopElement::parseMappedAttribute):
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::parseMappedAttribute):
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::svgAttributeChanged):
+ (WebCore::SVGUseElement::childrenChanged):
+ (WebCore::SVGUseElement::recalcStyle):
+ * svg/animation/SMILTimeContainer.cpp:
+ (WebCore::SMILTimeContainer::updateAnimations):
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::parseMappedAttribute):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::setValue):
+ (WebCore::WMLInputElement::parseMappedAttribute):
+ * wml/WMLNoopElement.cpp:
+ (WebCore::WMLNoopElement::insertedIntoDocument):
+
+2009-04-09 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ When there is a shadow set but it specifies "no shadow", clear the
+ shadow shader. This will prevent Chromium from thinking there's a
+ shadow and using the Skia codepath rather than Windows.
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::setPlatformShadow):
+
+2009-04-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Crash when accessing svg.viewport on a detached SVGSVGElement
+ https://bugs.webkit.org/show_bug.cgi?id=25105
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as to what behavior we should have in this case, and I doubt anyone cares for now).
+
+2009-04-09 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25084
+ Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::dispose):
+ (WebCore::WorkerContextExecutionProxy::retrieve):
+ (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
+ (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
+ (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
+ (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
+ * bindings/v8/WorkerContextExecutionProxy.h:
+ * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::getEventListener):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-04-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson and Sam Weinig.
+
+ Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
+
+ Longer term solution is to change the design so Safari doesn't read and write all of history.
+ This patch is step one: Do the serializing, which is done on the main thread, much faster.
+
+ * WebCore.base.exp: Added new entry points.
+ * WebCore.xcodeproj/project.pbxproj: Added new source files.
+
+ * history/cf: Added.
+
+ * history/cf/HistoryPropertyList.cpp: Added.
+ * history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also
+ have code for reading here too.
+
+ * platform/cf/BinaryPropertyList.cpp: Added.
+ * platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.
+
+2009-04-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=25122
+
+ If deferred repainting is active, we need to ensure that there are no repaints
+ pending at the end of layoutIfNeededRecursive, which is called just before
+ painting via -viewWillDraw.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layoutIfNeededRecursive):
+
+2009-04-09 John Grabowski <jrg@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25117
+ Fix Mac Chromium form controls.
+
+ * rendering/RenderThemeChromiumMac.mm:
+ When rendering native controls in Mac Chromium, use a clean NSGraphicsContext.
+ Properly save and restore native graphics context.
+ (WebCore::RenderThemeChromiumMac::paintCheckbox):
+ (WebCore::RenderThemeChromiumMac::paintRadio):
+ (WebCore::RenderThemeChromiumMac::paintMenuList):
+ (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
+
+2009-04-09 Drew Wilson <atwilson@google.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25030
+ Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
+ instead of a real MessagePort for the entangledPort, since it could
+ theoretically live in a separate process.
+
+ The goal of this refactoring is to remove all assumptions that the object
+ representing the entangled port is actually of type MessagePort. All
+ operations that were previously directly modifying private MessagePort member
+ variables in the entangled port (i.e. entangle(), postMessage()) have been changed
+ to invoke functions in the MessagePortProxy interface instead which will allow
+ the Chrome bindings to proxy these calls to another process.
+
+ No new layout tests, as this is just a refactoring with no bug fixes
+ or new functionality.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark):
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::clone):
+ (WebCore::MessagePort::postMessage):
+ (WebCore::MessagePort::deliverMessage):
+ (WebCore::MessagePort::startConversation):
+ (WebCore::MessagePort::close):
+ (WebCore::MessagePort::entangle):
+ (WebCore::MessagePort::unentangle):
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::entangledPort):
+ * dom/MessagePortProxy.h: Added.
+ (WebCore::MessagePortProxy::~MessagePortProxy):
+
+2009-04-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey "Big Boy" Garen.
+
+ Fix for <rdar://problem/5745677> Possible to stop load during an unload event
+ Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
+
+ Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
+ fast/events/stop-load-in-unload-handler-using-window-stop.html
+
+ Don't allow calling methods that would stop the new load inside the unload
+ event.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::FrameLoader):
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::stopAllLoaders):
+ * loader/FrameLoader.h:
+
+2009-04-09 David Kilzer <ddkilzer@apple.com>
+
+ Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
+
+ Rolled r42345 back in. The build failure was caused by an
+ internal script which had not been updated the same way that
+ build-webkit was updated.
+
+ * Configurations/WebCore.xcconfig:
+ * DerivedSources.make:
+ * bindings/objc/DOM.mm:
+ (WebCore::createElementClassMap):
+ (+[DOMNode _wrapNode:WebCore::]):
+ * bindings/objc/DOMCSS.mm:
+ (+[DOMCSSValue _wrapCSSValue:WebCore::]):
+ * bindings/objc/DOMEvents.mm:
+ (+[DOMEvent _wrapEvent:WebCore::]):
+ * bindings/objc/DOMInternal.h:
+ * bindings/objc/ExceptionHandlers.mm:
+ (WebCore::raiseDOMException):
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLFrameElement.idl:
+ * html/HTMLIFrameElement.idl:
+ * html/HTMLObjectElement.idl:
+
+2009-04-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=25109
+
+ Eliminate CompositeAnimationPrivate, which was a needless level
+ of abstraction. Remove the methods like addToStyleAvailableWaitList()
+ that simply turn around and call the animation controller.
+
+ Rename animationControllerPriv() to animationController().
+ Rename willNeedService() to timeToNextService().
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::~AnimationBase):
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::timeToNextService):
+ (WebCore::AnimationBase::beginAnimationUpdateTime):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::~CompositeAnimation):
+ (WebCore::CompositeAnimation::clearRenderer):
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ (WebCore::CompositeAnimation::animate):
+ (WebCore::CompositeAnimation::getAnimatedStyle):
+ (WebCore::CompositeAnimation::setAnimating):
+ (WebCore::CompositeAnimation::timeToNextService):
+ (WebCore::CompositeAnimation::getAnimationForProperty):
+ (WebCore::CompositeAnimation::cleanupFinishedAnimations):
+ (WebCore::CompositeAnimation::suspendAnimations):
+ (WebCore::CompositeAnimation::resumeAnimations):
+ (WebCore::CompositeAnimation::overrideImplicitAnimations):
+ (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
+ (WebCore::CompositeAnimation::isAnimatingProperty):
+ (WebCore::CompositeAnimation::pauseAnimationAtTime):
+ (WebCore::CompositeAnimation::pauseTransitionAtTime):
+ (WebCore::CompositeAnimation::numberOfActiveAnimations):
+ * page/animation/CompositeAnimation.h:
+ (WebCore::CompositeAnimation::animationController):
+ (WebCore::CompositeAnimation::isSuspended):
+ (WebCore::CompositeAnimation::hasAnimations):
+ (WebCore::CompositeAnimation::CompositeAnimation):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ (WebCore::ImplicitAnimation::timeToNextService):
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ (WebCore::KeyframeAnimation::timeToNextService):
+ * page/animation/KeyframeAnimation.h:
+
+2009-04-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
+ It broke Mac build, and I don't know how to fix it.
+
+ * Configurations/WebCore.xcconfig:
+ * DerivedSources.make:
+ * bindings/objc/DOM.mm:
+ (WebCore::createElementClassMap):
+ (+[DOMNode _wrapNode:WebCore::]):
+ * bindings/objc/DOMCSS.mm:
+ (+[DOMCSSValue _wrapCSSValue:WebCore::]):
+ * bindings/objc/DOMEvents.mm:
+ (+[DOMEvent _wrapEvent:WebCore::]):
+ * bindings/objc/DOMInternal.h:
+ * bindings/objc/ExceptionHandlers.mm:
+ (WebCore::raiseDOMException):
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLFrameElement.idl:
+ * html/HTMLIFrameElement.idl:
+ * html/HTMLObjectElement.idl:
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Unreviewed build fix.
+
+ RenderView::docWidth() was made private by r42334. That commit
+ changes its usage for overflowWidth(), so do that here too.
+
+ * page/PrintContext.cpp:
+ (WebCore::PrintContext::computePageRects):
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Implement AtkObject::ref_state_set. Still quite a few states not
+ implemented.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Move fallback object creation to its own function, as it will be
+ used in several places.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (fallbackObject):
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Based on a patch by Alp Toker.
+
+ Move AccessibilityObject methods to their file.
+
+ * page/gtk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::wrapper):
+ (WebCore::AccessibilityObject::setWrapper):
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-09 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+ [GTK] ATK accessibility enhancements
+
+ Rework accessibility type generation code, based on Mozilla a11y
+ implementation.
+
+ Have one base a11y type, and generate derived types that implement
+ only the necessary interfaces at runtime, based on the specific
+ object we are wrapping. This allows to save a lot of code while
+ covering all possible cases.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-04-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix document.implementation.createDocument(null, "a:b") not to crash!
+ https://bugs.webkit.org/show_bug.cgi?id=25096
+
+ Test: fast/dom/DOMImplementation/createDocument-namespace-err.html
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument): check the exception code before using the result
+
+2009-04-08 Adam Roben <aroben@apple.com>
+
+ Make <select>s in application chrome documents match the Vista system
+ dialog look
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::documentIsInApplicationChromeMode): Added this simple helper
+ function.
+ (WebCore::RenderThemeWin::getThemeData): In application chrome mode,
+ the drop down button never uses any look but the "normal" look.
+ (WebCore::RenderThemeWin::paintMenuList): In application chrome mode,
+ use the "readonly" style to match system dialogs.
+
+2009-04-08 Adam Roben <aroben@apple.com>
+
+ Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow
+ showing after clicking "Go Back" in phishing alert
+
+ RenderButton's m_timer is not stopped when its Document enters the
+ page cache. When the WebView was torn down, the timer would fire after
+ the Frame's Page had been destroyed, leading to a crash. This patch
+ just makes the timer do nothing when it fires. Making the timer not
+ fire when in the page cache is covered by bug 25110.
+
+ Reviewed by Dave Hyatt.
+
+ No test possible.
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::timerFired): Do nothing when we're in the page
+ cache.
+
+2009-04-09 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Adam Roben
+
+ Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
+ caused the checks to be triggered too early in the loading process of the frame.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+
+2009-04-08 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Cameron Zwarich
+
+ https://bugs.webkit.org/show_bug.cgi?id=25106
+
+ Fix signature of virtual function on AnimationBase so that it matches
+ those in the derived classes, by removing unused parameter.
+
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::endAnimation):
+
+2009-04-08 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
+
+ Reviewed by Darin Adler and Maciej Stachowiak.
+
+ Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
+ that SVG DOM Objective-C bindings may be optionally disabled.
+
+ * Configurations/WebCore.xcconfig: Added
+ ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in
+ FEATURE_DEFINES and EXCLUDED_SOURCE_FILE_NAMES. When SVG DOM
+ Objective-C bindings are disabled, two generated header files no
+ longer exist and none of the generated DOMSVG*.mm files should
+ be compiled.
+ * DerivedSources.make: All of the WebCore.SVG*.exp files contain
+ SVG DOM Objective-C bindings classes, so exclude them unless
+ ENABLE_SVG_DOM_OBJC_BINDINGS is set.
+ * bindings/objc/DOM.mm: Switched from using ENABLE(SVG) to using
+ ENABLE(SVG_DOM_OBJC_BINDINGS).
+ (WebCore::createElementClassMap):
+ (+[DOMNode _wrapNode:WebCore::]):
+ * bindings/objc/DOMCSS.mm: Ditto.
+ (+[DOMCSSValue _wrapCSSValue:WebCore::]):
+ * bindings/objc/DOMEvents.mm: Ditto.
+ (+[DOMEvent _wrapEvent:WebCore::]):
+ * bindings/objc/DOMInternal.h: Ditto.
+ * bindings/objc/ExceptionHandlers.mm: Added use of
+ ENABLE(SVG_DOM_OBJC_BINDINGS).
+ (WebCore::raiseDOMException):
+ * html/HTMLEmbedElement.idl: Excluded -getSVGDocument method
+ in generated Objective-C DOM classes if SVG DOM Objective-C
+ bindings are disabled.
+ * html/HTMLFrameElement.idl: Ditto.
+ * html/HTMLIFrameElement.idl: Ditto.
+ * html/HTMLObjectElement.idl: Ditto.
+
+2009-04-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - limit the workaround for <rdar://problem/5781372> to Mac OS X versions
+ that need it
+
+ * platform/mac/WebFontCache.mm:
+ (fixUpWeight): Changed this function to be a no-op post-Leopard.
+
+2009-04-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6771547> Appending to a RenderText causes all its
+ lines to be dirtied
+
+ Test: fast/repaint/text-append-dirty-lines.html
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::setTextWithOffset): If no text boxes intersected
+ with or came after the new text, dirty the last root box, since the new
+ text may begin there. Having at least one dirty line prevents the
+ incorrect dirtying of all lines later during layoutInlineChildren().
+
+2009-04-08 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25100
+
+ Fixes a Chromium-specific crash in WebCore::ImageBuffer::context that
+ occurs when rendering semi-transparent RTL text.
+
+ Test: fast/text/complex-text-opacity.html
+
+ * platform/graphics/chromium/FontChromiumWin.cpp: Handle RTL when computing text bounds.
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
+
+2009-04-08 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Beth Dakin
+
+ Fix a porting error in my previous patch. A != was supposed to be an ==.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2009-04-08 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Adam Roben and Darin Adler
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, repaints inconsistent for
+ fixed positioned elements.
+
+ Rewrite the updateScrollers method to be more correct in its results.
+
+ Test: fast/block/positioning/fixed-positioning-scrollbar-bug.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ (WebCore::Document::implicitClose):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::adjustPageHeight):
+ * page/FrameView.h:
+ * page/win/FrameWin.cpp:
+ (WebCore::computePageRectsForFrame):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/ScrollView.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::layout):
+ (WebCore::RenderView::docHeight):
+ (WebCore::RenderView::docWidth):
+ * rendering/RenderView.h:
+
+2009-04-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
+
+ Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
+ http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
+ http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
+ http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
+ http/tests/security/XFrameOptions/x-frame-options-deny.html
+ http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
+ http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank
+ if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse
+ the X-FRAME-OPTIONS parameter.
+ * loader/FrameLoader.h:
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and
+ a X-FRAME-OPTIONS header and its parameter dictate that we should.
+
+2009-04-08 Adam Roben <aroben@apple.com>
+
+ Fix http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html on Windows
+
+ Reviewed by Sam Weinig.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::loadResourceSynchronously): Mimic the
+ ResourceHandleMac code by propagating the CFError's error code for
+ kCFErrorDomainCFNetwork errors to the ResourceResponse.
+
+2009-04-08 Anders Carlsson <andersca@apple.com>
+
+ Try to fix the PPC build.
+
+ * plugins/npfunctions.h:
+
+2009-04-08 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/5908616> tokenizer resizer should handle edge cases consistently
+
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::enlargeBuffer): Handle edge cases the same way as a failed fastMalloc.
+ (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto.
+
+2009-04-08 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler
+
+ Make sure that cloneNode works with SVG attributes that require synchronization. This fixes
+ issues with <use> element shadow tree cloning where the clones can end up not obtaining the
+ correct attribute values.
+
+ A subsequent patch of mine will expose this problem and cause it to be covered by existing
+ layout tests, so no test is required at this time for this problem.
+
+ * dom/Element.cpp:
+ (WebCore::Element::cloneElementWithoutChildren):
+
+2009-04-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25093
+ REGRESSION: some scripts are showing in the Inspector with only "true"
+ as the source.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didParseSource): Fixed conversion issue.
+ (WebCore::InspectorController::failedToParseSource): Ditto.
+
+2009-04-08 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24904
+
+ Verify the MIME type of stylesheets (in standards mode) by looking
+ at the Content-Type header directly. This bypasses any content
+ sniffing that might be confusing the issue.
+
+ Test: http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html
+
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::canUseSheet):
+
+2009-04-08 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25041
+ <rdar://problem/6697754>
+ Bug 25041: HTMLMediaElement: OSX autoplay broken by r41907
+
+ OSX media player should set readyState to HAVE_ENOUGH_DATA when the movie's load state
+ reaches QTMovieLoadStatePlaythroughOK, not when the entire file has been downloaded,
+ so autoplay can begin when it should.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::updateStates): Set readState to
+ HAVE_ENOUGH_DATA when QTMovie load state reaches QTMovieLoadStatePlaythroughOK.
+ (WebCore::MediaPlayerPrivate::paint): Add braces missed in r42203.
+
+2009-04-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by David Kilzer. Based on a patch by Grace Kloba.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24656
+ cacheControlContainsNoCache() in ResourceResponseBase.h is wrong
+
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives): Removed misused code for
+ parsing directive values, fixing parsing of directives that we care about.
+
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Fixed a copy/paste mistake,
+ m_cacheControlContainsMustRevalidate was returned instead of m_cacheControlContainsNoCache.
+
+2009-04-08 Adam Roben <aroben@apple.com>
+
+ Make text fields match the system look on Vista
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::getThemeData): Use the new-to-Vista
+ EP_EDITBORDER_NOSCROLL part for text fields.
+
+2009-04-07 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24957
+ REGRESSION: Google calendar widget no longer shows upcoming events
+
+ Test: http/tests/xmlhttprequest/authorization-header.html
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from
+ the list of forbidden headers.
+
+2009-04-07 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Remove no longer needed debug warning and Windows-specific codepaths
+ (as we now use the Safari/Win port's timer there)
+
+ https://bugs.webkit.org/show_bug.cgi?id=25070
+
+ * platform/wx/SharedTimerWx.cpp:
+ (WebCore::setSharedTimerFireTime):
+
+
+2009-04-07 Adam Roben <aroben@apple.com>
+
+ Fix many <video> regression tests on Windows
+
+ Reviewed by Dave Hyatt.
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::getNaturalSize): Call GetMovieNaturalBoundsRect, which
+ returns the movie's natural bounds (duh), rather than GetMovieBox,
+ which returns the movie's current displayed size/position.
+
+2009-04-07 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler and Sam Weinig
+
+ <rdar://problem/5968249> "Private Browsing" doesn't affect HTML 5 LocalStorage
+
+ The expected behavior for persistent storage when private browsing mode is undefined by the spec.
+ For now we're going with a "read-only when in private browsing" policy until we can get feedback
+ and/or get the behavior specified in the spec.
+
+ Note that I purposefully made the change to restrict SessionStorage to read-only, also, with the
+ understanding that the spec allows for SessionStorage to persist across relaunches, even though
+ our implementation currently doesn't do this.
+
+ * dom/DOMCoreException.idl: Add some new ExceptionCodes defined in HTML5, one of which is needed
+ for LocalStorage changes (QUOTA_EXCEEDED_ERR)
+ * dom/ExceptionCode.cpp:
+ * dom/ExceptionCode.h:
+
+ * storage/StorageArea.cpp:
+ (WebCore::StorageArea::internalSetItem): If private browsing is enabled, throw the QUOTA_EXCEEDED_ERR
+ exception as the spec allows.
+ (WebCore::StorageArea::internalRemoveItem): If private browsing is enabled, silently fail to remove
+ the item.
+ (WebCore::StorageArea::internalClear): If private browsing is enabled, silently fail to clear the area.
+
+2009-04-07 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6148255>
+
+ Standalone media documents can not always handle everything
+ using a <video> element. In these cases switch to an <embed>
+ element that uses the QuickTime plugin, in the hope that it
+ will have more luck. Typical media types that trigger this
+ are streamed media and QTVR.
+
+ Equivalent Windows fix to come once reviewed. Note also that
+ this area of code needs a cleanup:
+ https://bugs.webkit.org/show_bug.cgi?id=25085
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
+ * html/HTMLMediaElement.h:
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::mediaElementSawUnsupportedTracks):
+ (WebCore::MediaDocument::replaceVideoWithEmbed):
+ * loader/MediaDocument.h:
+ - removes the <video> element and puts in an <embed>
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayerClient::mediaPlayerSawUnsupportedTracks):
+ - new internal method for flagging a problem
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
+ (WebCore::MediaPlayerPrivate::updateStates):
+ - looks for the types of content we don't handle
+ (WebCore::MediaPlayerPrivate::rateChanged):
+ (WebCore::MediaPlayerPrivate::sizeChanged):
+ (WebCore::MediaPlayerPrivate::timeChanged):
+ (WebCore::MediaPlayerPrivate::didEnd):
+ (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
+ (WebCore::MediaPlayerPrivate::sawUnsupportedTracks):
+ - inform the MediaClient that we have a potential problem
+
+2009-04-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6767428> Resurrect
+ +[WebFontCache fontWithFamily:traits:size:] for clients that call it
+ directly
+
+ WebFontCache is a class in the WebCore framework and is not WebKit API,
+ but apparently (perhaps mistakenly) some clients call this private
+ interface.
+
+ This change resurrects the interface and gives it reasonable behavior
+ (however, note that WebCore will not call the old interface, so hacks that
+ override it will have no effect on WebKit clients).
+
+ * platform/mac/WebFontCache.h:
+ * platform/mac/WebFontCache.mm:
+ (+[WebFontCache fontWithFamily:traits:size:]): Added. Call through to
+ +fontWithFamily:traits:weight:size:.
+
+2009-04-07 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Adam Roben
+
+ Fix ScrollView's algorithm that determines whether or not to show scrollbars. There was a bug
+ with the method mainly because RenderView will size itself to the viewport's size, making it
+ impossible to really know the document's "true" size.
+
+ In order to solve this problem ScrollView now has a minimumContentsSize method. This method
+ returns the document size excluding the RenderView from the calculation. This width/height
+ is now cached on RenderView in m_docWidth/m_docHeight member variables.
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::adjustPageHeight):
+ (WebCore::FrameView::minimumContentsSize):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::minimumContentsSize):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::layout):
+ (WebCore::RenderView::calcDocHeight):
+ (WebCore::RenderView::calcDocWidth):
+ * rendering/RenderView.h:
+ (WebCore::RenderView::docWidth):
+ (WebCore::RenderView::docHeight):
+
+2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Build fix, not reviewed.
+
+ * WebCore.xcodeproj/project.pbxproj: Made ScriptObject.h private.
+
+2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25063
+ Refactor InspectorController to use ScriptObject/State.
+
+ * GNUmakefile.am: Added ScriptState.cpp.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter.
+ (WebCore::ScriptFunctionCall::construct): Ditto.
+ * bindings/js/ScriptFunctionCall.h: Ditto.
+ * bindings/js/ScriptObject.cpp:
+ (WebCore::handleException): Added exception-reporting heloper.
+ (WebCore::ScriptObject::set): Changed to use handleException.
+ (WebCore::ScriptGlobalObject::set): Ditto,
+ * bindings/js/ScriptObject.cpp: Added ScriptGlobalObject.
+ (WebCore::ScriptGlobalObject::set): Added.
+ (WebCore::ScriptGlobalObject::getObject): Added.
+ * bindings/js/ScriptObject.h: Added ScriptGlobalObject decls.
+ (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
+ * bindings/js/ScriptState.cpp: Added.
+ * bindings/js/ScriptState.h: Added scriptStateFromPage decl.
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
+ to avoid re-entrancy.
+ * inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
+ * inspector/InspectorController.h: Ditto.
+
+2009-04-07 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25083
+
+ Skia was previously calculating the leading value incorrectly, leading
+ us to add fHeight to get the height of a line of text. Now that Skia
+ is calculating fLeading correctly, we can remove fHeight.
+
+ This doesn't affect any layout tests.
+
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformInit):
+
+2009-04-07 Brian Weinstein <bweinstein@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24851
+
+ This fix removes the status code from the status message in a ResourceResponse, which allows a few more tests in http to pass.
+
+ * platform/network/cf/ResourceResponseCFNet.cpp:
+ (WebCore::ResourceResponse::platformLazyInit):
+
+2009-04-07 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25081
+
+ Skia is changing from reporting the XRange to reporting the XMin and
+ XMax. Obviously these are equivalent, but other users of the metrics
+ need the two numbers to be separate.
+
+ This doesn't affect any layout tests.
+
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformInit):
+
+2009-04-07 Adam Roben <aroben@apple.com>
+
+ Make the look of <select>s match the system look on Vista
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeWin.cpp: Added new constants.
+ (WebCore::RenderThemeWin::getThemeData): On Vista, use the
+ CP_DROPDOWNBUTTONRIGHT part for drop down buttons.
+ (WebCore::RenderThemeWin::paintMenuList): On Vista, use the CP_BORDER
+ part to draw the border of <select>s.
+ (WebCore::RenderThemeWin::paintMenuListButton): On Vista, outset the
+ drop down button to make its border coincide with the <select>'s
+ border.
+
+2009-04-07 Adam Roben <aroben@apple.com>
+
+ Move isRunningOnVistaOrLater to a shared location
+
+ Rubber-stamped in advance by Dave Hyatt.
+
+ * WebCore.vcproj/WebCore.vcproj: Added SystemInfo.{cpp,h}, and let VS
+ have its way with the rest of the file.
+ * platform/win/ScrollbarThemeWin.cpp: Moved isRunningOnVistaOrLater
+ from here...
+ * platform/win/SystemInfo.cpp: Added.
+ (WebCore::isRunningOnVistaOrLater): ...to here.
+ * platform/win/SystemInfo.h: Added.
+
+2009-04-07 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24692
+ Enable PopupMenuChromium to handle HTML select popups using native
+ cocoa controls on the Mac, all other platforms are unchanged.
+
+ We also split out the storage container for the popup menu items
+ so that ChromeClientChromium can access them for forwarding to
+ the embedding host (Chromium.app or test_shell).
+
+ * page/chromium/ChromeClientChromium.h:
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::items):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::~PopupContainer):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::showExternal):
+ (WebCore::PopupContainer::menuItemHeight):
+ (WebCore::popupData):
+ (WebCore::PopupListBox::pointToRowIndex):
+ (WebCore::PopupListBox::getRowBounds):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::updateFromElement):
+ (WebCore::PopupListBox::layout):
+ (WebCore::PopupListBox::clear):
+ (WebCore::PopupMenu::show):
+ * platform/chromium/PopupMenuChromium.h:
+ (WebCore::PopupItem::):
+ (WebCore::PopupItem::PopupItem):
+
+2009-04-07 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Added some double-checking to event handler marking. Now, when the
+ wrapper that's responsible for marking an event handler's JavaScript
+ function gets collected, it clears the event handler's JavaScript function
+ so we won't dereference it after it's collected.
+
+ In theory, we would never dereference a JavaScript event handler after
+ its node's wrapper was collected anyway, but it's nice to be safe.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::mark):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::jsFunction):
+ (WebCore::JSEventListener::invalidateJSFunction):
+ (WebCore::JSEventListener::markJSFunction):
+ * bindings/js/JSEventListener.h:
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::markEventListeners):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::mark):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::mark):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/EventListener.h:
+ (WebCore::EventListener::invalidateJSFunction):
+ (WebCore::EventListener::markJSFunction):
+ (WebCore::markIfNotNull):
+
+2009-04-07 David Levin <levin@chromium.org>
+
+ Build fix.
+
+ r44280 undid the change in r42268 that made CookieJar.h private.
+ This redoes the change.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-04-07 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Upstream changes to WorkerContextExecutionProxy for enabling V8 preemption.
+ https://bugs.webkit.org/show_bug.cgi?id=25034
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::evaluate):
+
+2009-04-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6764359> Thai word selection misbehaves for the
+ last sentence in the document
+
+ Test: editing/selection/thai-word-at-document-end.html
+
+ * editing/visible_units.cpp:
+ - Added a BoundarySearchContextAvailability enum used to indicate
+ whether the caller to a boundary search function may be able to provide
+ additional text in the search direction and call again.
+ - Added a named type for the boundary search function signature. Changed
+ the signature to take a context availability parameter and a boolean
+ out parameter indicating whether more context is needed to perform
+ the search.
+ (WebCore::previousBoundary): If the beginning of the range was reached
+ but the last search wanted more context, perform the search again, this
+ time indicating that there is no earlier text.
+ (WebCore::nextBoundary): Similarly, in the other direction.
+ (WebCore::startWordBoundary): Check whether more context may be available
+ and ask for more context if needed.
+ (WebCore::endWordBoundary): Ditto.
+ (WebCore::previousWordPositionBoundary): Ditto.
+ (WebCore::nextWordPositionBoundary): Ditto.
+ (WebCore::startSentenceBoundary): Updated signature.
+ (WebCore::endSentenceBoundary): Ditto.
+ (WebCore::previousSentencePositionBoundary): Ditto.
+ (WebCore::nextSentencePositionBoundary): Ditto.
+
+2009-04-07 Geoffrey Garen <ggaren@apple.com>
+
+ Rubber stamped by Sam Weinig.
+
+ A little renaming:
+
+ function => jsFunction
+ listener => jsFunction
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSEventListener::jsFunction):
+ (WebCore::JSEventListener::mark):
+ (WebCore::JSProtectedEventListener::JSProtectedEventListener):
+ (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
+ (WebCore::JSProtectedEventListener::jsFunction):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSProtectedEventListener::create):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::jsFunction):
+ (WebCore::JSLazyEventListener::parseCode):
+ * dom/EventListener.h:
+ (WebCore::EventListener::jsFunction):
+
+2009-04-07 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to
+ avoid creating multiple representations for the same underlying StorageArea.
+ * page/DOMWindow.h:
+ (WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
+
+2009-04-07 Darin Adler <darin@apple.com>
+
+ Roll out incorrect build fix.
+
+ * WebCore.NPAPI.exp: Reverted.
+
+2009-04-07 Darin Adler <darin@apple.com>
+
+ Another build fix.
+
+ * WebCore.NPAPI.exp: Added new functions.
+
+2009-04-07 Anders Carlsson <andersca@apple.com>
+
+ Another build fix.
+
+ * plugins/npfunctions.h:
+
+2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Unreviewed build fix. Fix non-Mac builds.
+
+ * bridge/npapi.h:
+
+2009-04-07 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=25082
+
+ Clean up repaint logic when RenderLayers become and stop being composited.
+
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::rendererContentChanged):
+ (WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
+ New compositing-only method that repaints a layer and all its non-composited descendants.
+ Takes a repaintContainer for performance; all the repaints necessarily share the same
+ repaintContainer.
+
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ Rather than use calculateCompositedBounds() to compute the repaint rect (which gave
+ the wrong answer when the composited layer tree was in flux), use the new
+ repaintOnCompositingChange() method.
+
+ (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
+ Call repaintIncludingNonCompositingDescendants(), and if necessary make sure
+ that the view/layer drawing synchronization happens.
+
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ Do a repaintOnCompositingChange() when a layer is going to be composited. This is
+ a good place because we haven't started to change the compositing tree.
+
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ After we've finished updating all the descendant layers, we can do a repaint for
+ layers that ceased compositing.
+
+2009-04-07 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=25069
+
+ Clean up the accelerated compositing code that determines the format of
+ the GraphicsLayer hierarchy, being more explicit about which parts have
+ to happen before and after descendant layers have been updated. Also remove
+ some unhelpful caching of state.
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ Only call updateCompositingLayers() if we know we're not going to be
+ doing a layout soon.
+
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::setDrawsContent):
+ Toggling drawsContent from false to true should do a setNeedsDisplay().
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ updateLayerCompositingState() no longer updates the layer geometry, so
+ do that here if we're not going to rebuild layers anyway.
+ Also, updateLayerCompositingState() no longer does a setContentsNeedDisplay,
+ so do that if the style change indicates that a repaint is required.
+
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::RenderLayerBacking):
+ (WebCore::RenderLayerBacking::updateAfterLayout):
+ The 'drawing optimizations' logic has been rolled into updateGraphicsLayerConfiguration()
+ and updateGraphicsLayerGeometry().
+
+ (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
+ Group that code that decides what GraphicsLayers are needed into this method,
+ which deals with clipping layers and 'direct compositing': images that can be
+ rendered via the compositor.
+
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ Call setDrawsContent() if updateGraphicsLayerConfiguration() didn't already
+ figure it out for image layers.
+
+ (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
+ Remove the m_simpleCompositingLayerStatusDirty cache indicator, since we just
+ computed it every time anyway.
+
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ updateGraphicsLayers() was renamed to updateGraphicsLayerConfiguration(),
+ which calls clippedByAncestor() etc. itself rather than having everything passed in.
+ Repaints are taken care of by styleChanged() and setDrawsContent().
+
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ !layer->isComposited() && layer->transform() is a synonym for paintsWithTransform().
+
+ (WebCore::RenderLayerCompositor::setCompositingParent):
+ No need to call updateGraphicsLayerGeometry() here, because we're going to
+ rebuild layers anyway.
+
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ Add comments, and test layerBacking instead of layer->isComposited().
+
+2009-04-07 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * WebCore.base.exp:
+
+2009-04-07 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6667001> NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()
+
+ * WebCore.base.exp:
+ Add symbols needed by WebKit.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ Make CookieJar a private header.
+
+ * bridge/npapi.h:
+ Add function definitions.
+
+ * plugins/npfunctions.h:
+ Fix the NPN_SetValueForURLProcPtr signature.
+
+2009-04-07 Adam Roben <aroben@apple.com>
+
+ Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in
+ WebView and Bookmarks view after switching theme or turning on High
+ Contrast mode
+
+ Reviewed by Dave Hyatt.
+
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::themeChanged): Null out scrollbarTheme
+ after closing it so that we'll re-open the theme next time we paint.
+
+2009-04-07 Adam Roben <aroben@apple.com>
+
+ Small cleanup/correctness fix in ScrollbarThemeWin
+
+ Reviewed by Dave Hyatt.
+
+ * platform/win/ScrollbarThemeWin.cpp: Removed the now-unused
+ haveTheme boolean.
+ (WebCore::checkAndInitScrollbarTheme): Check IsThemeActive() before
+ calling OpenThemeData. This seems to be what MSDN recommends.
+ (WebCore::ScrollbarThemeWin::themeChanged): Null-check scrollbarTheme
+ before closing it, rather than indirectly null-checking it via
+ checking haveTheme.
+
+2009-04-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - when -webkit-line-break: after-white-space is specified but the text
+ does not auto-wrap, do not shrink the trailing space to fit in the
+ available width
+
+ Test: fast/text/whitespace/nowrap-line-break-after-white-space.html
+
+ - when shrinking such trailing space, do not shrink below zero
+
+ Covered by existing tests
+
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-04-07 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Move RangeBoundaryPoint off of Position, per Darin's suggestion
+ https://bugs.webkit.org/show_bug.cgi?id=24966
+
+ Rename setToChild to setToBeforeChild (since that's what the method does)
+
+ * dom/Position.h:
+ (WebCore::Position::offsetInContainerNode):
+ * dom/Range.cpp:
+ (WebCore::Range::insertNode):
+ (WebCore::Range::selectNodeContents):
+ (WebCore::boundaryNodeWillBeRemoved):
+ * dom/Range.h:
+ (WebCore::Range::startPosition):
+ (WebCore::Range::endPosition):
+ * dom/RangeBoundaryPoint.h:
+ (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
+ (WebCore::RangeBoundaryPoint::container):
+ (WebCore::RangeBoundaryPoint::childBefore):
+ (WebCore::RangeBoundaryPoint::position):
+ (WebCore::RangeBoundaryPoint::offset):
+ (WebCore::RangeBoundaryPoint::clear):
+ (WebCore::RangeBoundaryPoint::set):
+ (WebCore::RangeBoundaryPoint::setOffset):
+ (WebCore::RangeBoundaryPoint::setToBeforeChild):
+ (WebCore::RangeBoundaryPoint::setToStartOfNode):
+ (WebCore::RangeBoundaryPoint::setToEndOfNode):
+ (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
+ (WebCore::RangeBoundaryPoint::invalidateOffset):
+
+2009-04-07 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Add containerNode(), computeOffsetInContainerNode(),
+ computeNodeBeforePosition() and computeNodeAfterPosition().
+ https://bugs.webkit.org/show_bug.cgi?id=24763
+
+ These functions will replace uses of rangeCompliantPosition()
+ in future patches.
+
+ No changes in behavior, thus no tests.
+
+ * dom/Position.cpp:
+ (WebCore::Position::containerNode):
+ (WebCore::Position::computeOffsetInContainerNode):
+ (WebCore::Position::computeNodeBeforePosition):
+ (WebCore::Position::computeNodeAfterPosition):
+ (WebCore::Position::anchorType):
+ * dom/Position.h:
+ (WebCore::Position::):
+
+2009-04-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Bottleneck dispatching mutation events in a new dispatchMutationEvent
+ function.
+
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::dispatchModifiedEvent):
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchSubtreeModifiedEvent):
+ (WebCore::Node::dispatchMutationEvent):
+ * dom/Node.h:
+
+2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25059
+ Remove references to dominantScript, getGenericFontForScript.
+
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
+ to getGenericFontForScript.
+ (WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
+ * platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::defaultGUIFont): Removed Document* arg.
+ (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
+ * rendering/RenderThemeChromiumLinux.h: Ditto.
+ * rendering/RenderThemeChromiumMac.h: Ditto.
+ * rendering/RenderThemeChromiumMac.mm: Ditto.
+ (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::defaultGUIFont): Ditto.
+ (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
+ * rendering/RenderThemeChromiumWin.h: Ditto.
+
+2009-04-06 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
+ Unbounded memory growth when churning elements with anonymous event handler functions
+
+ The problem was that a protected event listener's scope chain would end
+ up with a reference to the Node protecting it, causing a cycle. The
+ solution is to stop protecting event listeners and rely on marking instead.
+
+ This patch converts most Node event listeners to use marking instead of
+ GC protection.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::isObservableThroughDOM):
+ (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node
+ needs marking, and added a case for marking the node in order to mark its
+ event listeners.
+
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::markEventListeners):
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ (WebCore::JSNode::mark): Added code to mark a Node's event listeners when
+ marking the Node. Changed code using protected event listeners to use event
+ listeners.
+
+ * dom/Node.idl: Changed code using protected event listeners to use event
+ listeners.
+
+2009-04-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove unchecked bool return values for some dispatch event functions.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchSubtreeModifiedEvent):
+ (WebCore::Node::dispatchUIEvent):
+ (WebCore::Node::dispatchWebKitAnimationEvent):
+ (WebCore::Node::dispatchWebKitTransitionEvent):
+ (WebCore::Node::dispatchProgressEvent):
+ * dom/Node.h:
+
+2009-04-06 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25058
+ Fix chromium build bustage caused by r42216
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * page/DOMWindow.idl:
+
+2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Rubber-stamped by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20575
+ No localization in WebKitGtk
+
+ * platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h,
+ since there are not translatable strings.
+ * platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header
+ that is specific for libraries.
+
+2009-04-06 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24978
+ Use custom implementations of a few Node methods so that
+ we don't over-aggressively create JS wrappers here.
+
+ * bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
+ * dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
+
+2009-04-06 Dave Moore <davemoore@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25031
+ Make the V8 element collections check for named properties *before*
+ checking if there are any elements with the same name. Otherwise
+ it is both incorrect and slow.
+
+ Test: fast/dom/HTMLSelectElement/length-not-overridden.html
+
+ Both of these interceptors were attempting to find an element in the
+ collection that had a name or id of the property name before checking
+ for a JS property with that name.
+ * bindings/v8/V8Collection.h:
+ (WebCore::collectionNamedPropertyGetter):
+ (WebCore::nodeCollectionNamedPropertyGetter):
+
+2009-04-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=25052
+
+ Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
+ because we need to call it at the end of rebuildCompositingLayerTree() once
+ we've determined which descendant layers are composited, otherwise
+ calculateCompositedBounds() can give the wrong answer.
+
+ Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
+ call that explicitly from styleChanged(), if we know a layer update is not pending,
+ and similarly from updateAfterLayout().
+
+ Test: compositing/overflow/overflow-positioning.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateAfterLayout):
+ (WebCore::RenderLayerBacking::updateGraphicsLayers):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+
+2009-04-06 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add accessors to AtomicString which take String/const char* arguments
+ so that we don't accidentally thrash the AtomicString table.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24979
+
+ * platform/text/AtomicString.h:
+
+2009-04-03 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ Make col and row work in WebCore/manual-tests/cursor.html. The issue
+ was spotted in the WebKit inspector.
+
+ * platform/gtk/CursorGtk.cpp:
+ (WebCore::columnResizeCursor):
+ (WebCore::rowResizeCursor):
+
+2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
+
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParentVisible):
+
+2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Add new files to the Qt build.
+ Export helper function from the Qt JSC binding, needed in WebKit/qt.
+
+ * WebCore.pro: Add new files.
+ * bridge/qt/qt_runtime.h: Declare convertQVariantToValue.
+
+2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.
+
+ Internally the function name is stored as a WebCore::String and the Qt port wants to use this
+ constructor programmatically where the function name is also a WebCore::String.
+
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::ScriptFunctionCall):
+ * bindings/js/ScriptFunctionCall.h:
+
+2009-04-06 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Eric Seidel.
+
+ HTMLCanvasElement crash when ImageBuffer creation fails.
+ https://bugs.webkit.org/show_bug.cgi?id=23212
+
+ Check for NULL before using the ImageBuffer as we might
+ be low on memory and creation may have failed.
+
+ Test case creation blocked by:
+ https://bugs.webkit.org/show_bug.cgi?id=25055
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::createImageBuffer):
+
+2009-04-05 Geoffrey Garen <ggaren@apple.com>
+
+ [Originally] Reviewed by Sam Weinig.
+
+ Rolled back in r42214 with crashes fixed.
+
+ [Removed irrelevant ExecState* parameter from event handler registration code.]
+
+ [No change in behavior.]
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-05 Erik L. Bunce <elbunce@xendom.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25050
+
+ Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
+
+ * platform/qt/DragDataQt.cpp:
+ (WebCore::DragData::asURL):
+
+2009-04-05 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMethod::createPrototype): Take the JSGlobalObject
+ as second argument.
+
+2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
+
+ Build fixes for wxMac/Tiger.
+
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+ * rendering/break_lines.cpp:
+ (WebCore::nextBreakablePosition):
+ * webcore-wx.bkl:
+
+2009-04-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Cameron Zwarich
+
+ https://bugs.webkit.org/show_bug.cgi?id=24648
+
+ Ensure that mapPoint(const IntPoint&) calls the FloatPoint
+ version to avoid infinite recursion.
+
+ No test because mapPoint(const IntPoint&) isn't ever called
+ on Mac, so I can't reproduce.
+
+ * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::TransformationMatrix::mapPoint):
+
+2009-04-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place
+ the insertion point inside a Thai character
+
+ Test: fast/text/international/thai-offsetForPosition-inside-character.html
+
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::offsetForPosition): Changed to use
+ cursorMovementIterator instead of characterBreakIterator, allowing this
+ function to return a valid cursor position even if it is not at
+ a character boundary.
+
+2009-04-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix an assertion failure when clicking at the beginning of a
+ glyph cluster at the beginning of a text run
+
+ Test: fast/text/offsetForPosition-cluster-at-zero.html
+
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::offsetForPosition): Corrected the bound
+ check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less
+ than -1.
+
+2009-04-03 Brian Weinstein <bweinstein@gmail.com>
+
+ Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
+ when the names are given.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25044
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
+
+2009-04-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6330929>
+ https://bugs.webkit.org/show_bug.cgi?id=21456
+
+ Don't update the document pointer for all inactive windows on navigations.
+ This change causes us to differ slightly from Firefox when accessing the
+ document from within a closure tied to a navigated context, but as all
+ browsers differ on this edge case, I don't foresee compatibility issues.
+
+ Test: http/tests/security/cross-frame-access-document-direct.html
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::clearWindowShell):
+ (WebCore::ScriptController::initScript):
+ (WebCore::ScriptController::updateDocument):
+ * bindings/js/ScriptController.h:
+
+2009-04-03 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Test: transitions/bad-transition-shorthand-crash.html
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.
+
+ We were starting transitions with 0 duration and delay, which is
+ useless. With accelerated compositing on, this went through a code
+ path that tried to use m_toStyle, which never got set because the
+ transitions was short circuited before it had a chance to. So I
+ both protect against using that null pointer and avoid starting
+ the transition in the first place.
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
+
+2009-04-03 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where you could not type any more in the Web Inspector's
+ search field after the first match is selected in the Resources panel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23982
+ rdar://problem/6592367
+
+ Reviewed by Darin Adler.
+
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype._jumpToSearchResult): Use the
+ window object of the frame to set the selection, not the main window.
+
+2009-04-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
+ <rdar://problem/6346030>
+ Don't allow overriding the return value of window.location.
+
+ Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html
+ fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
+ fast/dom/Window/Location/location-override-toString-on-proto.html
+ fast/dom/Window/Location/location-override-toString-using-defineGetter.html
+ fast/dom/Window/Location/location-override-toString-using-with.html
+ fast/dom/Window/Location/location-override-toString.html
+ fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
+ fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
+ fast/dom/Window/Location/location-override-valueOf-on-proto.html
+ fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
+ fast/dom/Window/Location/location-override-valueOf-using-with.html
+ fast/dom/Window/Location/location-override-valueOf.html
+ fast/dom/Window/Location/window-override-location-using-defineGetter.html
+ fast/dom/Window/Location/window-override-window-using-defineGetter.html
+ fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
+ fast/dom/Window/Location/window-shadow-location-using-string.html
+ fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::defineGetter):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::customPut):
+ (WebCore::JSLocation::defineGetter):
+ (WebCore::JSLocationPrototype::customPut):
+ (WebCore::JSLocationPrototype::defineGetter):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * page/Location.idl:
+
+2009-04-03 Geoffrey Garen <ggaren@apple.com>
+
+ Rolled out r42214 since it seems to have caused crashes on the buildbot.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for <rdar://problem/6476356>
+ https://bugs.webkit.org/show_bug.cgi?id=23148
+
+ - Use the window object the Location and History objects are directly associated with
+ instead of the lexical global object to pick the object prototype to serve as the
+ base of the their respective prototype chains.
+ - Re-factor as necessary to allow passing the correct global object to the createPrototype
+ functions.
+
+ Tests: http/tests/security/cross-frame-access-history-prototype.html
+ http/tests/security/cross-frame-access-location-prototype.html
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::getCachedDOMStructure):
+ (WebCore::cacheDOMStructure):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::getDOMStructure):
+ (WebCore::getDOMPrototype):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::history):
+ (WebCore::JSDOMWindow::location):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::location):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createPrototype):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::createPrototype):
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
+ (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
+ * bindings/js/JSWebKitPointConstructor.cpp:
+ (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
+ * bindings/js/JSWorkerConstructor.cpp:
+ (WebCore::JSWorkerConstructor::JSWorkerConstructor):
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::createPrototype):
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createPrototype):
+ * bridge/runtime_object.h:
+ (JSC::RuntimeObjectImp::createPrototype):
+ * page/DOMWindow.idl:
+
+2009-04-03 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25009
+ Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
+ (WebCore::WorkerContextExecutionProxy::dispose):
+ (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
+ (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
+ * bindings/v8/WorkerContextExecutionProxy.h:
+
+2009-04-03 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Removed irrelevant ExecState* parameter from event handler registration code.
+
+ No change in behavior.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-04-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ - fix <rdar://problem/6634771> Under full-page zoom, cannot scroll
+ MobileMe contact list
+
+ Test: fast/css/zoom-in-length-round-trip.html
+
+ * dom/Element.cpp:
+ (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure
+ that the returned value is equal to the original unscaled value.
+ (WebCore::adjustForAbsoluteZoom): Ditto.
+
+2009-04-03 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=24941
+
+ This fix essentially does a -viewWillDraw call for layout. It adds
+ a CFRunLoopObserver which performs layout just before drawing on the
+ Mac platform. This makes sure layout is complete before rendering and
+ avoids a flash.
+
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::scheduleViewUpdate):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::setCompositingLayersNeedUpdate):
+ (WebCore::RenderLayerCompositor::scheduleViewUpdate):
+ * rendering/RenderLayerCompositor.h:
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24648
+
+ Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.
+
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::TransformationMatrix::mapPoint):
+ (WebCore::TransformationMatrix::mapRect):
+ (WebCore::TransformationMatrix::mapQuad):
+ * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::TransformationMatrix::mapPoint):
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=25018
+
+ Add containsPoint() and containsQuad() methods to FloatQuad.
+
+ * platform/graphics/FloatQuad.cpp:
+ (WebCore::dot):
+ (WebCore::isPointInTriangle):
+ (WebCore::FloatQuad::containsPoint):
+ (WebCore::FloatQuad::containsQuad):
+ * platform/graphics/FloatQuad.h:
+
+2009-04-03 Kevin Decker <kdecker@apple.com>
+
+ Reviewed by Darin.
+
+ * loader/ProgressTracker.cpp: Included DocumentLoader.h
+ (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to
+ documents that use WebCore's layout system.
+
+2009-04-03 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25029
+ <rdar://problem/6336092> REGRESSION: movie does not resize correctly
+
+ Test: media/video-size-intrinsic-scale.html
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead
+ of QTMovieNaturalSizeAttribute so we return the correct size for movies saved
+ with a non-default matrix.
+ (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView
+ because [QTMovieView setFrame] also resizes the movie itself, and as
+ the renderer calls setSize immediately when a movie reports a size change
+ (QTMovieSizeDidChangeNotification) we can get into a feedback loop
+ observing the size change and resetting the size, and this can cause
+ QuickTime to miss correctly setting a movie's size when the media size
+ changes after opening (as happens with an rtsp movie once the server sends
+ the track sizes). Instead, remember the size passed to paint() and
+ resize the view when it changes.
+ (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect
+ so we return the correct size for movies saved with non-default matrix.
+
+2009-04-03 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
+ https://bugs.webkit.org/show_bug.cgi?id=25028
+
+ * loader/FrameLoader.h:
+ (WebCore::FrameLoader::policyDocumentLoader):
+
+2009-04-02 Michael Nordman <michaeln@google.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Use long long, not int64, when working in webcore (sorry).
+ https://bugs.webkit.org/show_bug.cgi?id=25011
+
+ No change in functionality, so no tests.
+
+ * platform/network/chromium/ResourceResponse.h:
+ (WebCore::ResourceResponse::getAppCacheID):
+ (WebCore::ResourceResponse::setAppCacheID):
+
+2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ Remove pre-processor checks for GTK+ >= 2.10, since we now require
+ at least that version.
+
+ * platform/graphics/gtk/FontPlatformDataGtk.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ * platform/gtk/ContextMenuItemGtk.cpp:
+ (WebCore::gtkStockIDFromContextMenuAction):
+ * platform/gtk/KeyEventGtk.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/gtk/LocalizedStringsGtk.cpp:
+ (WebCore::contextMenuItemTagSelectAll):
+ * platform/gtk/MouseEventGtk.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ (WebCore::Pasteboard::documentFragment):
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=25021
+
+ Fix repainting an element with a reflection and transform after layout.
+ Telling the reflection to repaint directly is wrong, because, with
+ LayoutState enabled, it only takes the reflection's transform into account,
+ not that of the element. We can fix this, and keep the benefits of LayoutState,
+ by computing the reflected repaint rect, and repainting that using the original
+ renderer.
+
+ Test: fast/repaint/reflection-repaint-test.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=23307
+
+ When repainting during layout (when LayoutState is enabled), we need
+ to apply the transform to the dirty rect, before applying x(), y() and
+ the offset storted in the LayoutState.
+
+ Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
+ since LayoutState is always root-relative.
+
+ Test: fast/repaint/transform-layout-repaint.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToContainer):
+ (WebCore::RenderBox::computeRectForRepaint):
+
+2009-04-02 Mark Rowe <mrowe@apple.com>
+
+ Fix the Mac build after r42191.
+
+ * WebCore.base.exp:
+
+2009-04-02 Mark Rowe <mrowe@apple.com>
+
+ Fix Windows build after r42190.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::keyEvent): Update to use the new name of the constant.
+
+2009-04-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ <rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/
+
+ Test: http/tests/navigation/onload-navigation-iframe-2.html
+
+ * html/HTMLFrameElement.cpp:
+ (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
+ * html/HTMLFrameElement.h: Ditto.
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
+ * html/HTMLFrameElementBase.h: Ditto.
+ * html/HTMLFrameOwnerElement.cpp:
+ (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
+ * html/HTMLFrameOwnerElement.h: Ditto.
+ * html/HTMLIFrameElement.cpp:
+ (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
+ * html/HTMLIFrameElement.h: Ditto.
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag.
+ The original change that introduced this, http://trac.webkit.org/changeset/25410, does
+ not make it clear why this check was needed. And it seems it is not needed.
+
+2009-04-02 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Add a way to get a list of focusable nodes.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ (WebCore::Document::getFocusableNodes):
+ * dom/Document.h:
+
+2009-04-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6654255> crash due to null FrameView in EventHandler
+
+ Lots of code was added to EventHandler that used view() and page() without
+ null checking, but both of those can become null due to the frame lifetime.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ (WebCore::EventHandler::eventMayStartDrag):
+ (WebCore::EventHandler::handleAutoscroll):
+ (WebCore::EventHandler::autoscrollTimerFired):
+ (WebCore::EventHandler::setPanScrollCursor):
+ (WebCore::EventHandler::allowDHTMLDrag):
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ (WebCore::EventHandler::stopAutoscrollTimer):
+ (WebCore::EventHandler::selectCursor):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::dispatchDragEvent):
+ (WebCore::EventHandler::prepareMouseEvent):
+ (WebCore::EventHandler::dispatchMouseEvent):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::hoverTimerFired):
+ (WebCore::EventHandler::keyEvent):
+ (WebCore::EventHandler::dragHysteresisExceeded):
+ (WebCore::EventHandler::shouldDragAutoNode):
+ (WebCore::EventHandler::handleDrag):
+ (WebCore::EventHandler::handleTextInputEvent):
+ (WebCore::EventHandler::addPendingFrameUnloadEventCount):
+ (WebCore::EventHandler::removePendingFrameUnloadEventCount):
+ (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
+ (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
+ (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
+ (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
+ Added null checks for view() and page(). Made minor code cleanups.
+
+2009-04-02 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
+ still considers it an error for the purposes of firing onerror.
+
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent):
+
+2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25010
+ Refactor InspectorController to replace all JS function invocations with
+ ScriptFunctionCall.
+
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
+ and JSValuePtr methods.
+ (WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
+ method.
+ * bindings/js/ScriptFunctionCall.h: Decls for above.
+ * bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow.
+ (WebCore::getQuarantinedScriptObject):
+ * bindings/js/ScriptObjectQuarantine.h: Decls for above.
+ * inspector/InspectorController.cpp:
+ (WebCore::callSimpleFunction): Made into a static.
+ (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall.
+ (WebCore::InspectorController::toggleRecordButton): Ditto.
+ (WebCore::InspectorController::startGroup): Ditto.
+ (WebCore::InspectorController::setAttachedWindow): Ditto.
+ (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto.
+ (WebCore::InspectorController::addScriptProfile): Ditto.
+ (WebCore::InspectorController::didParseSource): Ditto.
+ (WebCore::InspectorController::failedToParseSource): Ditto.
+ (WebCore::InspectorController::didPause): Ditto.
+ * inspector/InspectorController.h: Removed callFunction and callSimpleFunction
+ decls.
+
+2009-04-02 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Upstream changes to V8WorkerContextEventListener for V8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=25007
+
+ * bindings/v8/V8ObjectEventListener.h:
+ * bindings/v8/V8WorkerContextEventListener.cpp:
+
+2009-04-02 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Upstream V8WorkerContextObjectEventListener for V8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=25005
+
+ * bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
+ * bindings/v8/V8WorkerContextObjectEventListener.h: Added.
+
+2009-04-02 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Upstream V8EventListenerList for V8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=25004
+
+ * bindings/v8/V8EventListenerList.cpp: Added.
+ * bindings/v8/V8EventListenerList.h: Added.
+
+2009-04-02 Michael Nordman <michaeln@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Chromium's ResourceRequest and ResourceResponse structs need some new data members.
+ https://bugs.webkit.org/show_bug.cgi?id=24897
+
+ These fields are needed to facilitate Chromium's implementation of the HTML5
+ ApplicationCache feature. We need to know what frame (or context) is doing the
+ requesting, and from what cache the resulting resource was retrieved.
+
+ No change in functionality, so no tests.
+
+ * platform/network/chromium/ResourceRequest.h:
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::appCacheContextID):
+ (WebCore::ResourceRequest::setAppCacheContextID):
+ * platform/network/chromium/ResourceResponse.h:
+ (WebCore::ResourceResponse::ResourceResponse):
+ (WebCore::ResourceResponse::getAppCacheID):
+ (WebCore::ResourceResponse::setAppCacheID):
+
+2009-04-02 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.
+
+ Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
+ else just ignores it and displays the image anyway.
+
+ Added http/tests/misc/image-error.html
+
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::notifyFinished):
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::CachedImage):
+ * loader/CachedImage.h:
+ (WebCore::CachedImage::httpStatusCodeError):
+ (WebCore::CachedImage::httpStatusCodeErrorOccurred):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::httpStatusCodeError):
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didReceiveData):
+
+2009-04-02 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Add XHR constructor in WorkerContext.idl for V8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=24962
+
+ * workers/WorkerContext.idl:
+
+2009-04-02 Ben Murdoch <benm@google.com>
+
+ Fix Bug 19743: Release build fails on 32-bit Windows
+
+ <https://bugs.webkit.org/show_bug.cgi?id=19743>
+
+ Combines all the HTML element cpp files into one to help reduce the
+ size of WebCore.lib so we can build in release mode on 32bit Windows.
+
+ Reviewed by Adam Roben.
+
+ * WebCore.vcproj/WebCore.vcproj: Excluded all the separate
+ HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp
+ to the build.
+ * html/HTMLElementsAllInOne.cpp: Added.
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24999
+
+ Optimize hit testing with transforms.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToContainer):
+ (WebCore::RenderBox::mapAbsoluteToLocalPoint):
+ getTransformFromContainer() change to return the matrix by reference.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::update3DTransformedDescendantStatus):
+ The method failed to set m_3DTransformedDescendantStatusDirty to false,
+ so did the work every time.
+
+ (WebCore::RenderLayer::createLocalTransformState):
+ Only call the expensive getTransformFromContainer() if there is a transform,
+ otherwise we just have a translation.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::getTransformFromContainer):
+ * rendering/RenderObject.h:
+ Change transformFromContainer() to getTransformFromContainer(), and return
+ the matrix by reference to reduce copying.
+ New enum values for arguments for readability.
+
+ * rendering/TransformState.cpp:
+ (WebCore::TransformState::move):
+ (WebCore::TransformState::applyTransform):
+ (WebCore::HitTestingTransformState::translate):
+ New method that adds a translation to the accumulated matrix, optionally
+ without flattening. Cheaper than applyTransform().
+
+ (WebCore::HitTestingTransformState::applyTransform):
+ (WebCore::HitTestingTransformState::flatten):
+ (WebCore::HitTestingTransformState::flattenWithTransform):
+ Add flattenWithTransform(), which is a helper that allows us to
+ avoid doing the inverse() twice.
+
+ * rendering/TransformState.h:
+ (WebCore::TransformState::):
+ (WebCore::TransformState::move):
+ (WebCore::HitTestingTransformState::):
+ New method on HitTestingTransformState that adds a translation to the
+ accumulated matrix, optionally without flattening. Cheaper than applyTransform().
+ New enum values for arguments for readability.
+
+2009-04-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24648
+
+ Optimize common code paths in TransformationMatrix.
+
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::TransformationMatrix::translate):
+ (WebCore::TransformationMatrix::translate3d):
+ Optimize to avoid matrix copy.
+
+ (WebCore::TransformationMatrix::isInvertible):
+ Test for identity and translation matrices before computing
+ the determinant.
+
+ (WebCore::TransformationMatrix::inverse):
+ Optimize for identity matrix and translations.
+
+ * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::TransformationMatrix::isIdentityOrTranslation):
+ Utility method.
+
+2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24930
+ [Gtk] ISO files content is displayed inside the webview instead of being downloaded
+
+ Also sniff content of types declared as text/plain. This is
+ justified by the fact that it is common to have Apache HTTP
+ servers configured to send text/plain as Content-Type by default.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::gotHeadersCallback):
+
+2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Protect the handle when notifying the client that the response was
+ received also in gotChunkCallback, or we crash in didReceiveData
+ when the load is cancelled in didReceiveResponse.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::gotChunkCallback):
+
+2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=25001
+ Crash when content type parameters have no value
+
+ Handle the case where a Content-Type header parameter has no
+ value (i.e. no = character), to work-around a bug in libsoup.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+
+2009-04-02 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24490
+
+ Enable web workers in Qt.
+
+ * WebCore.pro:
+
+2009-04-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler. Based on work of Julien Chaffraix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22475
+ REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore
+
+ https://bugs.webkit.org/show_bug.cgi?id=24886
+ XHR requests opened when offline never return
+
+ Tests: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
+ http/tests/xmlhttprequest/state-after-network-error.html
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this
+ wasn't an error.
+ (WebCore::XMLHttpRequest::abort): Fixed formatting.
+ (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange.
+ The comment saying that this doesn't match Firefox was added in r33559 without explanation
+ or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state
+ to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt
+ that any code depends on this, so I went with the spec here.
+
+2009-04-01 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=24997
+ Race conditions in icon database threading code
+
+ m_syncThreadRunning set was mistakenly eliminated in r27717.
+ This reintroduces it.
+
+ Reviewed by Oliver Hunt.
+
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open): Set m_syncThreadRunning.
+
+2009-04-01 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6748609> Use ActiveDOMObject to suspend marquees
+
+ Make marquees ActiveDOMObjects, get rid of the special suspension code.
+
+ * html/HTMLMarqueeElement.cpp:
+ (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
+ (WebCore::HTMLMarqueeElement::canSuspend):
+ (WebCore::HTMLMarqueeElement::suspend):
+ (WebCore::HTMLMarqueeElement::resume):
+ * html/HTMLMarqueeElement.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::clearTimers):
+ * rendering/RenderLayer.cpp:
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::marquee):
+
+2009-04-01 Dean Jackson <dino@apple.com>
+
+ Reviewed by Darin Adler
+
+ Make constant values static in previous commit, as suggested
+ by Darin.
+
+ * rendering/RenderVideo.cpp:
+
+2009-04-01 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=24993
+
+ Standalone media should have a smaller instrinsic
+ height.
+
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::RenderVideo):
+
+2009-04-01 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 22378: Crash submitting a form when parsing an XHTML document
+ https://bugs.webkit.org/show_bug.cgi?id=22378
+ rdar://problem/6388377
+
+ Tests: fast/loader/submit-form-while-parsing-1.xhtml
+ fast/loader/submit-form-while-parsing-2.html
+
+ * WebCore.base.exp: Updated.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children.
+ Used uncheckedAppend because we reserveInitialCapacity.
+ (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children.
+ Added an assertion that this is only used to add items that don't have
+ duplicate frame names.
+ (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item
+ if any, preserving the isTargetItem flag.
+ (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName
+ for consistency with the other functions here that all call the frame name the
+ "target". Also updated for rename of m_subItems to m_children.
+ (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem.
+ Removed unneeded size check.
+ (WebCore::HistoryItem::targetItem): Changed to always return the top item
+ if no item has the isTargetItem flag set. The old version would instead return
+ 0 in some cases, but return the top item if it had no children.
+ (WebCore::HistoryItem::children): Renamed m_subItems to m_children.
+ (WebCore::HistoryItem::hasChildren): Ditto.
+ (WebCore::HistoryItem::showTreeWithIndent): Ditto.
+
+ * history/HistoryItem.h: Name changes.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of
+ attaching "recorded form values" and "form about to be submitted" to the frame
+ loader. Parameter work fine for this; there's no need to store state on the
+ FrameLoader.
+
+ * loader/FormState.cpp:
+ (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map.
+ (WebCore::FormState::create): Ditto.
+ * loader/FormState.h: Update to use a vector that we adopt instead of hash map
+ that we copy for auto-fill text field values.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for
+ form submissions and turned the "wasDuringLoad" state into a separate boolean
+ instead of using a special redirection type to track it.
+ (WebCore::FrameLoader::createWindow): Updated for name and argument change of
+ loadFrameRequest.
+ (WebCore::FrameLoader::urlSelected): Ditto.
+ (WebCore::FrameLoader::submitForm): Removed the "deferred form submission"
+ machinery, replacing it with the "scheduled redirection" mechanism, shared
+ with other kinds of redirection and navigation. Moved frame targeting here
+ so we can schedule the redirection on the right frame. Moved the multiple
+ form submission protection here. Moved the code to implement the rule that
+ m_navigationDuringLoad was used for here too.
+ (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead
+ of the locationChangeDuringLoad type to detect location change during a load.
+ (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function,
+ submitFormAgain.
+ (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading
+ out of this function into scheduleRedirection, so it can be shared with the
+ new scheduleFormSubmission function.
+ (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as
+ scheduleLocationChange, but with the arguments for a form submission.
+ (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the
+ duringLoad flag.
+ (WebCore::FrameLoader::isLocationChange): Added case for formSubmission
+ and removed case for locationChangeDuringLoad.
+ (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded
+ completeURL call and just use KURL constructor to match the other cases.
+ (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up
+ the m_navigationDuringLoad, which is no longer needed. The new version of
+ this is in the submitForm function and sets the lockHistory boolean.
+ (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load
+ in here that used to be in scheduleLocationChange.
+ (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission
+ and removed case for locationChangeDuringLoad.
+ (WebCore::FrameLoader::stopRedirectionTimer): Ditto.
+ (WebCore::FrameLoader::completed): Removed call to now-obsolete function,
+ submitFormAgain.
+ (WebCore::FrameLoader::loadFrameRequest): Renamed from
+ loadFrameRequestWithFormAndValues. Replaced form element and form values
+ argument with a single FormState argument. Changed frame targeting code
+ to use the source frame in the case of a form submission to better match
+ the actual target frame.
+ (WebCore::FrameLoader::loadURL): Don't search for existing frames in the
+ form submission case since we already did that in the submitForm function.
+ (WebCore::FrameLoader::clientRedirected): Changed to work with the
+ m_isExecutingJavaScriptFormAction data member directly instead of taking
+ it as a function parameter.
+ (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames
+ in the form submission case since we already did that in the submitForm
+ function.
+ (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment
+ in here that was misplaced elsewhere in the file.
+ (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early
+ return idiom.
+ (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes.
+ (WebCore::FrameLoader::childFramesMatchItem): Ditto.
+ (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the
+ m_navigationDuringLoad logic; that's now handled by setting lockHistory
+ to true in the submitForm function.
+ (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
+ Use the new setChildItem function so we don't get multiple items for the
+ same frame name in the history item tree in the back/forward list.
+
+ * loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to
+ loadFrameRequest and made it take a form state object instead of the
+ form element and form values. Removed the unused functions
+ loadEmptyDocumentSynchronously, provisionalDocumentLoader,
+ notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the
+ submitForm function to take a form state argument. Eliminated the
+ clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue
+ functions, which are replaced by the form state arguments to submitForm
+ and loadFrameRequest. Removed the isJavaScriptFormAction argument from
+ the clientRedirected function; instead it looks at a data member directly.
+ Eliminated the submitFormAgain and overload of the submitForm function;
+ these are now subsumed into the remaining submitForm function and the
+ scheduleFormSubmission function. Removed unused and obsolete data
+ members m_navigationDuringLoad, m_deferredFormSubmission,
+ m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
+
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected):
+ Updated for name and argument change of loadFrameRequest.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::~Frame): Removed call to the now-unneeded
+ clearRecordedFormValues function.
+
+2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, fixing previous commit.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24994
+ Revert V8DOMMap.cpp change which accidentally snuck into the previous
+ commit.
+
+ * bindings/v8/V8DOMMap.cpp: Revert change in previous commit.
+
+2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24994
+ Fix miscellaneous merge/upstreaming divergencies in Chromium port.
+
+ * bindings/v8/V8Collection.h: Added an include.
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURL::baseAsString): Added to match KURL.cpp.
+ * platform/chromium/ClipboardChromium.cpp: Added an include.
+
+2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24989
+ Refactor InspectorResource to use ScriptObject/FunctionCall.
+
+ * bindings/js/JSInspectorControllerCustom.cpp:
+ (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use
+ a more appropriate type conversion.
+ (WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to
+ accommodate for InspectorResource refactoring.
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match
+ existing jsNumber call signature.
+ * bindings/js/ScriptFunctionCall.h: Declaration for above.
+ * bindings/js/ScriptObject.cpp:
+ (WebCore::createEmptyObject): Added.
+ (WebCore::ScriptObject::ScriptObject):
+ (WebCore::ScriptObject::set): Added a bunch of property setters.
+ * bindings/js/ScriptObject.h: Declarations for above.
+ * inspector/InspectorController.cpp: Moved all InspectorResource-managing code
+ to InspectorResource.cpp
+ (WebCore::InspectorController::populateScriptObjects): Changed to use
+ refactored InspectorResource.
+ (WebCore::InspectorController::resetScriptObjects): Ditto.
+ (WebCore::InspectorController::pruneResources): Ditto.
+ (WebCore::InspectorController::didCommitLoad): Ditto.
+ (WebCore::InspectorController::addResource): Ditto.
+ (WebCore::InspectorController::removeResource): Ditto.
+ (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
+ (WebCore::InspectorController::identifierForInitialRequest): Ditto.
+ (WebCore::InspectorController::willSendRequest): Ditto.
+ (WebCore::InspectorController::didReceiveResponse): Ditto.
+ (WebCore::InspectorController::didReceiveContentLength): Ditto.
+ (WebCore::InspectorController::didFinishLoading): Ditto.
+ (WebCore::InspectorController::didFailLoading): Ditto,
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
+ (WebCore::InspectorController::scriptImported): Ditto.
+ * inspector/InspectorController.h: Removed InspectorResource-managing code decls
+ and tweaked some signatures to use ScriptString and long long for identifier.
+ * inspector/InspectorController.idl: Changed to use long long for identifier.
+ * inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall.
+ (WebCore::InspectorResource::InspectorResource): Ditto.
+ (WebCore::InspectorResource::~InspectorResource): Ditto.
+ (WebCore::InspectorResource::createCached): Added.
+ (WebCore::InspectorResource::updateRequest): Added.
+ (WebCore::InspectorResource::updateResponse): Added.
+ (WebCore::createHeadersObject): Added.
+ (WebCore::InspectorResource::createScriptObject): Added.
+ (WebCore::InspectorResource::updateScriptObject): Added.
+ (WebCore::InspectorResource::releaseScriptObject): Added.
+ (WebCore::InspectorResource::type): Tweaked to use ScriptString.
+ (WebCore::InspectorResource::setXMLHttpResponseText): Added.
+ (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString.
+ (WebCore::InspectorResource::startTiming): Added.
+ (WebCore::InspectorResource::markResponseReceivedTime): Added.
+ (WebCore::InspectorResource::endTiming): Added.
+ (WebCore::InspectorResource::markFailed): Added.
+ (WebCore::InspectorResource::addLength): Added.
+ * inspector/InspectorResource.h: Added decls for newly refactored-in methods.
+ (WebCore::InspectorResource::create): Added.
+ (WebCore::InspectorResource::isSameLoader): Added.
+ (WebCore::InspectorResource::markMainResource): Added.
+ (WebCore::InspectorResource::identifier): Added.
+ (WebCore::InspectorResource::requestURL): Added.
+ (WebCore::InspectorResource::frame): Added.
+ (WebCore::InspectorResource::mimeType): Added.
+ (WebCore::InspectorResource::Changes::Changes): Added new class to track
+ resource changes.
+ (WebCore::InspectorResource::Changes::hasChange): Added.
+ (WebCore::InspectorResource::Changes::set): Added.
+ (WebCore::InspectorResource::Changes::clear): Added.
+ (WebCore::InspectorResource::Changes::setAll): Added.
+ (WebCore::InspectorResource::Changes::clearAll): Added.
+
+2009-04-01 Tony Chang <tony@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Ensure the right click doesn't deselect text under it. This was
+ happening in the Chromium and GTK+ ports because they don't select
+ the text under the cursor on right click.
+
+ This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737
+
+ https://bugs.webkit.org/show_bug.cgi?id=24946
+
+ Test: fast/events/context-no-deselect.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+
+2009-04-01 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24991
+
+ Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
+ when getting the transform.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::transformFromContainer):
+
+2009-03-31 Darin Adler <darin@apple.com>
+
+ Rolled out that last change until I can investigate the regression test failures it seems
+ to have caused.
+
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::decrement):
+ * dom/PositionIterator.h:
+ (WebCore::PositionIterator::PositionIterator):
+
+2009-03-31 Darin Adler <darin@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
+ https://bugs.webkit.org/show_bug.cgi?id=24621
+
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we
+ don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward
+ iterator, but also should never arise because of the fix below.
+ * dom/PositionIterator.h:
+ (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when
+ the passed-in node has no children. Like the change above, this is consistent with the rest
+ of the class, although in the long run I think it's a bit strange to treat a <p> element
+ with no children differently than a <p> element with children.
+
+2009-03-31 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24965
+ Bug 24965: HTMLMediaElement: network state changes can be missed
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the
+ state changes, even when no event needs to be fired.
+
+2009-03-31 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24964
+ Bug 24964: HTMLMediaElement: 'waiting' event may fire twice
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state
+ drops below HAVE_FUTURE_DATA.
+
+2009-03-31 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24846
+ Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute
+
+ Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
+ the author recommends downloading the entire resource optimistically, so the
+ attribute is made available to the media engine to use if it is able.
+
+ Test: media/video-dom-autobuffer.html
+
+ * html/HTMLAttributeNames.in: Add autobuffer.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::parseMappedAttribute): New.
+ (WebCore::HTMLMediaElement::autobuffer): Ditto.
+ (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
+
+ * html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
+
+ * html/HTMLMediaElement.idl: Add autobuffer.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer.
+ (WebCore::MediaPlayer::autobuffer): New.
+ (WebCore::MediaPlayer::setAutobuffer): Ditto.
+ * platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
+
+ * platform/graphics/MediaPlayerPrivate.h:
+ (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.
+
+2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24550
+ Check return value of vasprintf. This should keep gcc 4.3.3
+ happy rather than have it complain about attribute warn_unused_result.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::error):
+
+2009-03-31 Dean Jackson <dino@apple.com>
+
+ Style guide violation!
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+
+2009-03-31 Dean Jackson <dino@apple.com>
+
+ Fix Tiger build.
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+
+2009-03-31 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Upstream V8DOMMap for v8 bindings.
+ https://bugs.webkit.org/show_bug.cgi?id=24951
+
+ * bindings/v8/V8DOMMap.cpp: Added.
+ * bindings/v8/V8DOMMap.h: Added.
+
+2009-03-31 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24955
+
+ Spacebar didn't play/pause in standalone MediaDocument
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+
+2009-03-31 Alpha Lam <hclam@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24901
+ Added the following methods to MediaPlayerPrivate for Chromium port.
+ void sizeChanged();
+ void rateChanged();
+ void durationChanged();
+
+ The above changes are to reflect changes in MediaPlayer.cpp.
+ More details can be found in the original changeset.
+ http://trac.webkit.org/changeset/41907
+
+ * platform/graphics/chromium/MediaPlayerPrivateChromium.h:
+
+2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24947
+
+ Special-case drawing text-shadow on win32, to let GDI draw in cases
+ when both fill & shadow color are opaque and the shadow has no blur.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::windowsCanHandleDrawTextShadow):
+ (WebCore::windowsCanHandleTextDrawing):
+ * platform/graphics/skia/SkiaFontWin.h:
+
+2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ r42055 removed some functions in FrameLoader used by Chrome,
+ this CL backs out some of those changes to unbreak the Chrome build.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24949
+
+ * WebCore.base.exp:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+
+2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Build fixes for Chromium.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24945
+
+ * dom/Document.h:
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::imageToMarkup):
+
+2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::XMLTokenizer): Use NamedNodeMap instead of NamedAttrMap.
+
+2009-03-30 Steve Falkenburg <sfalken@apple.com>
+
+ Don't create CFDataRef with a fixed size.
+ Fixes synchronous XMLHTTPRequests on Windows.
+
+ Reviewed by Ada Chan.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::WebCoreSynchronousLoader::didReceiveData):
+
+2009-03-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
+ https://bugs.webkit.org/show_bug.cgi?id=24594
+ rdar://problem/6682110
+
+ Test: fast/loader/reload-policy-delegate.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's
+ the policy loader and can use m_policyLoadType rather than letting it get set inside
+ checkNavigationPolicy.
+
+2009-03-30 Timothy Hatcher <timothy@apple.com>
+
+ <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
+ in Finder (painting without up to date layout)
+
+ Reviewed by Dan Bernstein.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents): Add an early return when
+ painting is attempted when layout is needed.
+
+2009-03-30 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24938
+
+ Sort alphabetically.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
+2009-03-30 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24938
+
+ Build fixes for building --3d-rendering and --no-svg
+
+ * rendering/RenderLayerBacking.cpp:
+
+2009-03-30 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24938
+
+ Build fixes when building --no-svg
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
+ * css/CSSCursorImageValue.cpp:
+ (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Add missing CSS properties
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
+ * dom/Node.cpp:
+ (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::floatWidth): Handle unused param
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData): Handle unused param
+
+2009-03-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Bug 24916: REGRESSION: NavigationAction policy dispatch broken
+ https://bugs.webkit.org/show_bug.cgi?id=24916
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr
+ is not used twice. This also optimizes the case where a frame name is specified,
+ but it's the name of the frame being loaded. Also called release in all the final
+ uses of FormState.
+
+2009-03-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
+ https://bugs.webkit.org/show_bug.cgi?id=24937
+
+ Also should fix the Windows COM bindings build.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
+ * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
+
+ * dom/NamedAttrMap.h: Renamed class from NamedAttrMap to
+ NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap
+ functions all public and non-virtual. Removed virtualLength.
+
+ * dom/NamedNodeMap.h: Replaced file with just an include
+ of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap
+ files and remove this file.
+
+ * bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
+ * dom/Attr.h: Ditto.
+ * dom/Attribute.h: Ditto.
+ * dom/Document.cpp:
+ (WebCore::Document::importNode): Ditto.
+ * dom/Element.cpp:
+ (WebCore::Element::attributes): Ditto.
+ (WebCore::Element::setAttributeMap): Ditto.
+ (WebCore::Element::createAttributeMap): Ditto.
+ (WebCore::Element::insertedIntoDocument): Ditto.
+ (WebCore::Element::removedFromDocument): Ditto.
+ (WebCore::Element::openTagStartToString): Ditto.
+ (WebCore::Element::removeAttributeNode): Ditto.
+ (WebCore::Element::getAttributeNode): Ditto.
+ (WebCore::Element::getAttributeNodeNS): Ditto.
+ (WebCore::Element::hasAttribute): Ditto.
+ (WebCore::Element::hasAttributeNS): Ditto.
+ (WebCore::Element::normalizeAttributes): Ditto.
+ * dom/Element.h: Ditto.
+ * dom/NamedAttrMap.cpp:
+ (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto.
+ (WebCore::NamedNodeMap::~NamedNodeMap): Ditto.
+ (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto.
+ (WebCore::NamedNodeMap::getNamedItem): Ditto.
+ (WebCore::NamedNodeMap::getNamedItemNS): Ditto.
+ (WebCore::NamedNodeMap::removeNamedItem): Ditto.
+ (WebCore::NamedNodeMap::removeNamedItemNS): Ditto.
+ (WebCore::NamedNodeMap::setNamedItem): Ditto.
+ (WebCore::NamedNodeMap::item): Ditto.
+ (WebCore::NamedNodeMap::getAttributeItem): Ditto.
+ (WebCore::NamedNodeMap::clearAttributes): Ditto.
+ (WebCore::NamedNodeMap::detachFromElement): Ditto.
+ (WebCore::NamedNodeMap::setAttributes): Ditto.
+ (WebCore::NamedNodeMap::addAttribute): Ditto.
+ (WebCore::NamedNodeMap::removeAttribute): Ditto.
+ (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
+ * dom/NamedMappedAttrMap.cpp:
+ (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
+ * dom/NamedMappedAttrMap.h:
+ (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
+ * dom/Node.cpp:
+ (WebCore::Node::dumpStatistics): Ditto.
+ (WebCore::Node::isEqualNode): Ditto.
+ (WebCore::Node::isDefaultNamespace): Ditto.
+ (WebCore::Node::lookupNamespaceURI): Ditto.
+ (WebCore::Node::lookupNamespacePrefix): Ditto.
+ (WebCore::Node::compareDocumentPosition): Ditto.
+ * dom/Node.h: Ditto.
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto.
+ (WebCore::isEmptyFontTag): Ditto.
+ (WebCore::areIdenticalElements): Ditto.
+ * editing/markup.cpp:
+ (WebCore::appendStartMarkup): Ditto.
+ (WebCore::completeURLs): Ditto.
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError): Ditto.
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::updateWidget): Ditto.
+ * svg/SVGAnimatedProperty.h:
+ (WebCore::synchronizeProperty): Ditto.
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::FunLang::evaluate): Ditto.
+ * xml/XPathStep.cpp:
+ (WebCore::XPath::Step::nodesInAxis): Ditto.
+
+2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24750
+ [GTK] requests download instead of displaying page
+
+ Use soup facilities to append parameters to the content type, to
+ make that more robust;
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+
+2009-03-30 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig
+
+ Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.
+
+ * Configurations/Base.xcconfig: Moved Production definition of
+ SECTORDER_FLAGS to here from Xcode project file.
+ * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
+ in Base.xcconfig to the empty string since it is not used for
+ Debug and Release configurations.
+ * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.
+
+2009-03-30 Adam Roben <aroben@apple.com>
+
+ Windows build fix after recent Node.idl changes
+
+ * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
+ of classes that derive from Node to rebuild.
+
+2009-03-30 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * svg/graphics/SVGImage.cpp: Added a missing #include.
+
+2009-03-30 Mads Ager <ager@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24879
+ Add frame accessor to Screen, Console, and BarInfo objects. Add type
+ accessor to BarInfo objects.
+
+ In the V8 JavaScript bindings, we need access to the frame and
+ type for already created Screen, Console, and BarInfo objects in
+ order to keep their wrappers alive across GCs.
+
+ * page/BarInfo.cpp:
+ (WebCore::BarInfo::frame): Added.
+ (WebCore::BarInfo::type): Added.
+ * page/BarInfo.h:
+ * page/Console.cpp:
+ (WebCore::Console::frame): Added.
+ * page/Console.h:
+ * page/Screen.cpp:
+ (WebCore::Screen::frame): Added.
+ * page/Screen.h:
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Requested by Antti Koivisto.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
+ a better comment.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23445: Copying certain hidden text causes a crash
+ https://bugs.webkit.org/show_bug.cgi?id=23445
+ rdar://problem/6512520
+
+ Test: editing/pasteboard/copy-display-none.html
+
+ * editing/markup.cpp:
+ (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
+ the start of the selection past the end of the range entirely. If we try to iterate we'll
+ never hit the end of the range and will probably crash iterating the rest of the document.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
+ https://bugs.webkit.org/show_bug.cgi?id=24672
+ rdar://problem/6574263
+
+ I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
+ but there is an Apple-internal website I was able to use to reproduce and fix.
+
+ * loader/CachedResource.h: Made makePurgeable public.
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
+ so we can get its data if it hasn't yet been purged.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Fix build again.
+
+ * loader/EmptyClients.h: Fix typo in name of FormState.h.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Try to fix the release build.
+
+ * history/CachedPage.cpp: Make include unconditional, not debug-only.
+
+2009-03-29 Greg Bolsinga <bolsinga@apple.com>
+
+ Undo that last build fix, since it turned out the file wasn't deleted.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-03-29 Greg Bolsinga <bolsinga@apple.com>
+
+ Fix build break by removing references to deleted header files.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Try to fix the Windows build.
+
+ * loader/EmptyClients.h: Added include of FormState.h.
+ * loader/MainResourceLoader.cpp: Ditto.
+
+2009-03-29 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24926
+ Fix Chromium build break.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Another attempt to fix the Qt build.
+
+ * WebCore.pro: Added CheckedRadioButtons.cpp.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 24921: remove include of HTMLFormElement.h from Document.h
+ https://bugs.webkit.org/show_bug.cgi?id=24921
+
+ * GNUmakefile.am: Added CheckedRadioButtons source files.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
+
+ * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
+ Removed all the code except for CheckedRadioButtons, and moved that out to be
+ a namespace-level class instead of a member of HTMLFormElement.
+
+ * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
+ Removed all the code except for CheckedRadioButtons, and moved that out to be
+ a namespace-level class instead of a member of HTMLFormElement.
+
+ * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
+ Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
+ class to use a namespace-level class instead of a member of HTMLFormElement.
+
+ * dom/Node.idl: Changed the type of parentElement from Node to Element for
+ two reasons. 1) Node was incorrect, since parentElement returns an Element.
+ 2) The bindings won't compile any more unless they know parentElement's
+ return value is an Element due to include changes.
+
+ * html/HTMLFormElement.cpp: Moved definitions of the functions in the
+ CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
+
+ * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
+ class to the new CheckedRadioButtons.h.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
+ class to use a namespace-level class instead of a member of HTMLFormElement.
+
+ * page/Chrome.cpp:
+ (WebCore::Chrome::createWindow): Tweaked formatting.
+
+ * css/CSSGrammar.y: Added newly-needed include.
+ * dom/Range.cpp: Ditto.
+ * editing/BreakBlockquoteCommand.cpp: Ditto.
+ * editing/CompositeEditCommand.cpp: Ditto.
+ * editing/InsertLineBreakCommand.cpp: Ditto.
+ * editing/ModifySelectionListLevel.cpp: Ditto.
+ * editing/RemoveFormatCommand.cpp: Ditto.
+ * editing/TextIterator.cpp: Ditto.
+ * editing/VisiblePosition.cpp: Ditto.
+ * loader/DocLoader.cpp: Ditto.
+ * page/AccessibilityRenderObject.cpp: Ditto.
+ * page/Page.cpp: Ditto.
+ * rendering/RenderBlock.cpp: Ditto.
+ * rendering/RenderLayer.cpp: Ditto.
+ * rendering/RenderObject.h: Ditto.
+ * storage/LocalStorageArea.cpp: Ditto.
+ * storage/SessionStorageArea.cpp: Ditto.
+
+2009-03-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6015407> attr parsing should allow only identifiers
+
+ Test: fast/css/attr-parsing.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
+ identifiers that start with "-".
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
+ case works. This has the pleasant side effect of fixing a bug too.
+
+2009-03-29 Alexey Proskuryakov <ap@webkit.org>
+
+ <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
+
+ Forgot to save the file after applying changes for review comments.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::willSendRequest):
+ (WebCore::didReceiveResponse):
+ (WebCore::didReceiveData):
+ (WebCore::didSendBodyData):
+ (WebCore::didFinishLoading):
+ (WebCore::didFail):
+ (WebCore::willCacheResponse):
+ (WebCore::didReceiveChallenge):
+ (WebCore::WebCoreSynchronousLoader::willSendRequest):
+ (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
+ (WebCore::WebCoreSynchronousLoader::didReceiveData):
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading):
+ (WebCore::WebCoreSynchronousLoader::didFail):
+ (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
+
+2009-03-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
+
+ Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ (WebCore::WebCoreSynchronousLoader::willSendRequest):
+ (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
+ (WebCore::WebCoreSynchronousLoader::didReceiveData):
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading):
+ (WebCore::WebCoreSynchronousLoader::didFail):
+ (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
+ (WebCore::WebCoreSynchronousLoader::load):
+ Match Mac behavior more closely - we shouldn't rely on underlying library handling of
+ synchronous requests.
+
+ * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest):
+ -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest
+ delegate method for a redirect.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
+ Match async behavior more closely.
+
+2009-03-28 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 24914: empty-string assertion crash when running storage tests
+ https://bugs.webkit.org/show_bug.cgi?id=24914
+
+ * storage/Database.cpp:
+ (WebCore::Database::performOpenAndVerify): Don't store empty version strings
+ in the map, since empty strings are per-thread.
+
+2009-03-28 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24910
+ Fixes for Chromium build.
+
+ * bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
+ * bindings/v8/custom/V8CustomEventListener.h: ditto.
+ * dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
+
+2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Not reviewed, correcting landing error.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24812
+ Custom bindings should be in v8/custom, not v8.
+
+ * bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
+
+2009-03-28 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24616
+ Add V8 custom bindings for DOMWindow.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
+
+2009-03-28 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24812
+ Add V8 custom bindings for HTMLDocument.
+
+ * bindings/v8/V8HTMLDocumentCustom.cpp: Added.
+
+2009-03-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix two SVG test failures in 64-bit.
+
+ getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
+ This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
+ identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.
+
+ The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
+ but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
+ check for a negative value and lets the implementation treat the arguments purely as unsigned values.
+
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGTextContentElement::getNumberOfChars):
+ (WebCore::SVGTextContentElement::getSubStringLength):
+ (WebCore::SVGTextContentElement::getStartPositionOfChar):
+ (WebCore::SVGTextContentElement::getEndPositionOfChar):
+ (WebCore::SVGTextContentElement::getExtentOfChar):
+ (WebCore::SVGTextContentElement::getRotationOfChar):
+ (WebCore::SVGTextContentElement::getCharNumAtPosition):
+ (WebCore::SVGTextContentElement::selectSubString):
+ * svg/SVGTextContentElement.h:
+ * svg/SVGTextContentElement.idl:
+
+2009-03-27 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Get mailto code out of FrameLoader.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto
+ logic so HTMLFormElement::submit isn't full of ugly bits. This includes the
+ part of the logic that involves transformeing the URL that was previously
+ inside FrameLoader.
+ (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and
+ also release the data for slightly less refcount churn.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto,
+ since HTMLFormElement now properly prepares both the URL and the form data.
+
+2009-03-27 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
+
+ * platform/graphics/chromium/FontCustomPlatformData.cpp:
+ (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
+ (WebCore::createFontCustomPlatformData): Ditto.
+ * platform/graphics/opentype/OpenTypeUtilities.cpp:
+ (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to
+ the size of an EOTPrefix.
+ (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in
+ the prefix.
+ (WebCore::EOTHeader::appendBigEndianString): Changed the static
+ appendBigEndianStringToEOTHeader() into this member function.
+ (WebCore::EOTHeader::appendPaddingShort): Added.
+ (WebCore::getEOTHeader): Changed to use EOTHeader.
+ * platform/graphics/opentype/OpenTypeUtilities.h:
+ (WebCore::EOTHeader::size):
+ (WebCore::EOTHeader::data):
+ (WebCore::EOTHeader::prefix):
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
+ (WebCore::createFontCustomPlatformData): Ditto.
+
+2009-03-27 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ To prepare for work on a form loading fix, remove some unused functions,
+ consolidate some functions, and make many more functions private in
+ FrameLoader.
+
+ * WebCore.base.exp: Remove some unused entry points, update another.
+
+ * dom/Document.cpp:
+ (WebCore::Document::detach): Clear m_frame directly instead of using
+ clearFramePointer.
+ * dom/Document.h: Ditto.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::urlSelected): Consolidate the two functions
+ of this name into a single function. Also changed the event argument
+ to be PassRefPtr<Event>.
+ (WebCore::FrameLoader::submitForm): Changed the event argument to
+ be PassRefPtr<Event>.
+ (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
+ explicitly so we can remove the version of changeLocation that does
+ completeURL for us.
+ (WebCore::FrameLoader::redirectionTimerFired): Ditto.
+ (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
+ directly so we don't need a setProvisionalHistoryItem function.
+ (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
+ m_quickRedirectComing directly so we don't need a isQuickRedirectComing
+ function.
+ (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
+ (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
+ event argument to be PassRefPtr<Event>.
+ (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
+ function here because this is the only caller. If we want to make the
+ resulting function smaller we should refactor some other way. Also
+ streamlined the user-chosen encoding logic, but did not change what it does.
+ (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
+ to be PassRefPtr<Event>.
+ (WebCore::FrameLoader::loadPostRequest): Ditto.
+ (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
+ the didNotOpenURL function here, since this was the only caller.
+
+ * loader/FrameLoader.h: Removed include of FormState.h and used a forward
+ declaration instead. Removed unneeded forward declation of Element.
+ Moved many functions into the private section, and removed some other
+ unused or uneeded functions.
+
+2009-03-27 Xiaomei Ji <xji@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=24303
+ Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.
+
+ Test: editing/selection/extend-selection.html
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::directionOfEnclosingBlock): Added
+ (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly
+ implemented for character and word granularity, all other granularities
+ are treated as "forward".
+ (WebCore::SelectionController::modifyExtendingForward): Renamed
+ modifyExtendingRightForward() to this.
+ (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly
+ implemented for character and word granularity, all other granularities
+ are treated as "backward".
+ (WebCore::SelectionController::modifyExtendingBackward): Renamed
+ modifyExtendingLeftBackward() to this.
+ (WebCore::SelectionController::modify): Change to call either the
+ left/right or backward/forward methods depending on the 'dir' argument
+ for extends.
+ * editing/SelectionController.h:
+
+2009-03-27 John Abd-El-Malek <jam@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24836
+ Fix navigator.plugins.refresh(false) in Chromium.
+
+ * plugins/chromium/PluginDataChromium.cpp:
+ (WebCore::PluginData::refresh):
+
+2009-03-27 Timothy Hatcher <timothy@apple.com>
+
+ Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
+ virtual to fix the broken layout tests from my last commit.
+
+ Reviewed by Mark Rowe.
+
+ * dom/Element.cpp:
+ (WebCore::Element::scrollLeft):
+ (WebCore::Element::scrollTop):
+ (WebCore::Element::scrollWidth):
+ (WebCore::Element::scrollHeight):
+ * dom/Element.h:
+ * html/HTMLBodyElement.h:
+
+2009-03-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
+ Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
+ items after each node is removed, leading to O(N^2) behaviour. By inlining the batch removal in to setLength we can avoid
+ this gratuitous recalcuation.
+
+2009-03-27 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
+ I took crosshair to have a common behavior with firefox.
+
+ [GTK] SVG - Crash on setting the cursor icon
+ https://bugs.webkit.org/show_bug.cgi?id=24565
+
+ * platform/gtk/CursorGtk.cpp:
+ (WebCore::Cursor::Cursor):
+
+2009-03-27 Timothy Hatcher <timothy@apple.com>
+
+ Remove redundant attributes and functions from IDL files that have the
+ same attributes and functions defined in the super class.
+
+ Reviewed by Simon Fraser.
+
+ * WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
+ * bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
+ * html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth
+ and scrollHeight.
+ * html/HTMLElement.idl: Remove blur and focus.
+
+2009-03-27 Adam Roben <aroben@apple.com>
+
+ Don't include substitute data URLs in global history redirect chains
+
+ <rdar://6690169>
+
+ Reviewed by Darin Adler.
+
+ This might be testable if:
+ - support were added to DRT for providing substitute data on failed
+ loads
+ - support were added to DRT for dumping redirect chains
+
+ I tried doing the above and was still unable to make a test.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::updateHistoryForStandardLoad):
+ (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
+ Call updateGlobalHistoryRedirectLinks only if the load succeeded
+ (i.e., there is no unreachableURL). Previous the FrameLoaderClient
+ implementations were unconditionally calling
+ updateGlobalHistoryRedirectLinks from within updateGlobalHistory.
+
+2009-03-27 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24861
+ Chromium port did not render decorations for <input type="search">.
+ This copies RenderThemeWin.*.
+
+ * css/themeChromiumWin.css: Removed.
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle):
+ (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle):
+ (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle):
+ (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
+ * rendering/RenderThemeChromiumLinux.h:
+ (WebCore::RenderThemeChromiumLinux::paintSearchField):
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::):
+ (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle):
+ (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle):
+ (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle):
+ (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
+ * rendering/RenderThemeChromiumWin.h:
+ (WebCore::RenderThemeChromiumWin::paintSearchField):
+
+2009-03-27 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ If an object has a self-painting layer, don't count it as part of a block's visual overflow.
+ This fix has only been made for block-level children. The inline-level case is still broken
+ (and covered by an existing bug).
+
+ Added fast/block/positioning/negative-rel-position.html
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+
+2009-03-27 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6642221>
+ REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed
+
+ Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.
+
+ I've filed <rdar://problem/6731022> against the Movies widget.
+
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::rendererIsNeeded):
+
+2009-03-25 Timothy Hatcher <timothy@apple.com>
+
+ Expose new DOM methods as public Objective-C API.
+
+ <rdar://problem/5837350> Expose new DOM classes and methods
+ as public API (match the additions to the JavaScript DOM)
+
+ Reviewed by Mark Rowe and Darin Adler.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/objc/DOMHTML.h:
+ * bindings/objc/DOMPrivate.h:
+ * bindings/objc/PublicDOMInterfaces.h:
+
+2009-03-27 Zack Rusin <zack@kde.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24280
+
+ Fix propagation of fill rules when rendering paths in the Qt build.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::toQtFillRule):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+
+2009-03-27 Zack Rusin <zack@kde.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24275
+
+ Fix text field theming in the Qt build with the KDE 4 Oxygen
+ style by adjusting the size vertically and horizontally to
+ set padding on the element equal to the width of the style painted border.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::RenderThemeQt):
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
+ (WebCore::RenderThemeQt::adjustTextFieldStyle):
+ (WebCore::RenderThemeQt::paintTextField):
+ * platform/qt/RenderThemeQt.h:
+
+2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24852
+ Build fix for GNU mode RVCT compilation
+
+ * html/PreloadScanner.cpp:
+
+2009-03-27 Erik L. Bunce <elbunce@xendom.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24868
+
+ Make text of the writing direction items more user friendly.
+
+ * platform/qt/Localizations.cpp:
+ (WebCore::contextMenuItemTagLeftToRight):
+ (WebCore::contextMenuItemTagRightToLeft):
+
+2009-03-27 Erik L. Bunce <elbunce@xendom.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24274
+
+ Fixed the Qt 4.4 Mac build with netscape plugins enabled.
+
+ * plugins/mac/PluginViewMac.cpp:
+
+2009-03-26 Mark Rowe <mrowe@apple.com>
+
+ Try and fix the Qt build.
+
+ * platform/text/TextEncodingDetectorNone.cpp:
+ (WebCore::detectTextEncoding):
+
+2009-03-26 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24874
+ 24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it
+
+ The 'duration' attribute is NaN when no media is available, so the
+ media element should take care when comparing with duration().
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when
+ it is NaN.
+ (WebCore::HTMLMediaElement::endedPlayback): Ditto.
+
+2009-03-26 Mark Rowe <mrowe@apple.com>
+
+ Fix the build.
+
+ * platform/text/TextEncodingDetectorICU.cpp:
+ * platform/text/TextEncodingDetectorNone.cpp:
+
+2009-03-26 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Cameron Zwarich.
+
+ 1. Fix the crash in setHintEncoding
+ 2. Fix build failures on Tiger and Qt.
+ UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp
+ in the patch landed in r42023
+ for http://bugs.webkit.org/show_bug.cgi?id=16482
+
+ * loader/TextResourceDecoder.h:
+ (WebCore::TextResourceDecoder::setHintEncoding):
+ * platform/text/TextEncodingDetectorICU.cpp:
+ * platform/text/TextEncodingDetectorNone.cpp:
+
+2009-03-26 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix when ACCELERATED_COMPOSITING is turned on.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::canUseDirectCompositing):
+
+2009-03-26 Eric Seidel <eric@webkit.org>
+
+ No additional review, committing previously reviewed files for build fix only.
+
+ Add files I missed when commiting Jungshik's patch in r42022.
+ https://bugs.webkit.org/show_bug.cgi?id=16482
+
+ * icu/unicode/ucsdet.h: Added.
+ * platform/text/TextEncodingDetector.h: Added.
+ * platform/text/TextEncodingDetectorICU.cpp: Added.
+ (WebCore::detectTextEncoding):
+ * platform/text/TextEncodingDetectorNone.cpp: Added.
+ (WebCore::detectTextEncoding):
+
+2009-03-26 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add an encoding detector 'hook' to TextResourceDecoder.
+ - add |usesEncodingDetector| to Settings. It's off by default.
+ - add a new encoding source type |EncodingFromParent|
+ to distinguish cases when the encoding is inherited from
+ the parent frame from cases when it's actually auto-detected.
+ - add TextEncodingDetector* to platform/text. Currently,
+ the only implementation uses ICU. Stub is added for
+ ports that do not use ICU and a build on Tiger. Mac OS
+ Tiger comes with ICU 3.2 that does not support encoding detector.
+ - add ucsdet.h to icu/unicode for ports using ICU.
+
+ Layout tests will be added once bug 20534 is fixed and a WebPreference
+ can be controlled in test_shell. With UsesEncodingDetector off, there
+ is no change to test.
+
+ http://bugs.webkit.org/show_bug.cgi?id=16482
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCore/GNUmakefile.am
+ * WebCore/WebCore.pro
+ * WebCore/WebCore.scons
+ * WebCore/WebCoreSources.bkl
+ * WebCore.base.exp
+ * icu/unicode/ucsdet.h
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::TextResourceDecoder):
+ (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame
+ (WebCore::TextResourceDecoder::checkForHeadCharset): ditto
+ (WebCore::TextResourceDecoder::shouldAutoDetect):
+ (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true.
+ (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
+ * loader/TextResourceDecoder.h:
+ (WebCore::TextResourceDecoder::):
+ (WebCore::TextResourceDecoder::create):
+ (WebCore::TextResourceDecoder::setHintEncoding):
+ (WebCore::TextResourceDecoder::source):
+ * page/Settings.cpp: add m_usesEncodingDetector
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setUsesEncodingDetector):
+ * page/Settings.h:
+ (WebCore::Settings::usesEncodingDetector):
+ * platform/text/TextEncodingDetector.h: Added.
+ * platform/text/TextEncodingDetectorICU.cpp: Added.
+ (WebCore::detectTextEncoding):
+ * platform/text/TextEncodingDetectorNone.cpp: Added.
+ (WebCore::detectTextEncoding):
+
+2009-03-26 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Removed code that casts EventListener down to derived classes
+ without type checking. A crash could happen if you added event
+ listeners with Objective-C and then manipulated the class with
+ JavaScript.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::mark): Removed all the casts
+ and used the markIfNotNull function and mark functions on
+ EventListener instead.
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark): Ditto.
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::mark): Ditto.
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::mark): Ditto.
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark): Ditto.
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent): Used function,
+ the new name for what used to be called listenerObj.
+ (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since
+ this doesn't need to be virtual for callers who have a pointer to
+ this class, not the base class.
+ (WebCore::JSEventListener::function): Renamed from listenerObj.
+ (WebCore::JSProtectedEventListener::function): Ditto.
+
+ * bindings/js/JSEventListener.h: Removed unneeded forward class
+ declarations. Made all virtual functions private since there's no
+ need to call any of them on a particular derived class, only on
+ EventListener. Explicitly declare JSEventListener::mark as virtual
+ since it's now overriding a function in the EventListener base class.
+ Made JSProtectedEventListener::m_globalObject protected so the
+ JSLazyEventListener derived class can use it directly instead of using
+ a virtual function to get the pointer.
+
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead
+ of globalObject since the latter is a virtual function and there's no
+ need to pay virtual function overhead.
+ (WebCore::JSLazyEventListener::function): Renamed from listenerObj.
+
+ * bindings/js/JSLazyEventListener.h: Moved forward declaration of the
+ Node class here from JSEventListener.h.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to
+ JSEventListener when getting the script object from a listener.
+
+ * dom/EventListener.h: Added virtual function and mark functions
+ so we can extract the JavaScript function object or mark a JavaScript
+ event listener in a type safe manner.
+
+2009-03-26 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24859
+ Use CSS file instead of code to adjust search field styling.
+
+ * css/themeWin.css:
+ * rendering/RenderThemeWin.cpp:
+ * rendering/RenderThemeWin.h:
+
+2009-03-26 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Split JSLazyEventListener out into its own separate source file.
+ We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
+ so leave those in the same file with JSEventListener.
+
+ * GNUmakefile.am: Added JSLazyEventListener.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part.
+ Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since
+ JSAbstractEventListener is not derived from JSCell.
+
+ * bindings/js/JSEventListener.h: Removed the JSLazyEventListener part
+ and the now-unneeded include of PlatformString.h.
+
+ * bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp.
+ Kept only the JSLazyEventListener part.
+ (WebCore::eventParameterName): Made this have internal linkage by adding "static".
+ Also moved the default case out of the switch statement so we will get a warning
+ if we omit any cases in the future.
+
+ * bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h.
+ Kept only the JSLazyEventListener part.
+
+ * bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the
+ remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
+
+2009-03-26 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Renamed JSUnprotectedEventListener to JSEventListener.
+ And related renames.
+
+ Soon Geoff will make all JavaScript event listeners use mark instead
+ of protect, so there's no need to emphasize "unprotected".
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::mark):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::jsEventListeners):
+ (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSEventListener::listenerObj):
+ (WebCore::JSEventListener::globalObject):
+ (WebCore::JSEventListener::clearGlobalObject):
+ (WebCore::JSEventListener::mark):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSEventListener::create):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::mark):
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::mark):
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark):
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ All just renaming.
+
+2009-03-26 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Renamed JSEventListener to JSProtectedEventListener.
+ And related renames.
+
+ Soon Geoff will make all JavaScript event listeners use mark instead
+ of protect, and so this class will be be obsolete. We will rename
+ JSUnrpotectedEventListener to JSEventListener in the next check-in,
+ since that one will remain.
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
+ (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
+ (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSProtectedEventListener::JSProtectedEventListener):
+ (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
+ (WebCore::JSProtectedEventListener::listenerObj):
+ (WebCore::JSProtectedEventListener::globalObject):
+ (WebCore::JSProtectedEventListener::clearGlobalObject):
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSProtectedEventListener::create):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ All just renaming.
+
+2009-03-26 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can
+ create runs extending beyond the end
+
+ No test because Safari does not use this version of
+ createBidiRunsForLine() with the end iterator not pointing to the end
+ of the text run.
+
+ * platform/text/BidiResolver.h:
+ (WebCore::BidiResolver::appendRun): Cap the end of the run at the end
+ of the line and set the reachedEndOfLine flag. This mirrors the logic
+ in the specialized version of appendRun() in bidi.cpp, which is why the
+ problem did not show up in HTML. Also avoid creating empty runs.
+
+2009-03-26 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24864
+
+ Change the terminology from "inner content layer" to "direct compositing"
+ for cases where we can push an image directly over to the compositing system,
+ without having to draw it.
+
+ Clean up much of the code which looks at style to determine if this is possible,
+ and fix some bugs when backgrounds change dynamically.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::hasBorderOutlineOrShadow):
+ (WebCore::hasBoxDecorations):
+ (WebCore::hasBoxDecorationsWithBackgroundImage):
+ (WebCore::RenderLayerBacking::canBeSimpleContainerCompositingLayer):
+ (WebCore::RenderLayerBacking::canUseDirectCompositing):
+ (WebCore::RenderLayerBacking::detectDrawingOptimizations):
+ (WebCore::RenderLayerBacking::rendererContentChanged):
+ (WebCore::RenderLayerBacking::updateImageContents):
+ * rendering/RenderLayerBacking.h:
+
+2009-03-26 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23914
+
+ Tests: compositing/overflow/ancestor-overflow.html
+ compositing/overflow/parent-overflow.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::calculateClipRects):
+ * rendering/RenderLayer.h:
+ (WebCore::ClipRects::infiniteRect):
+ New static method that returns a large rect that is used by the clipping
+ logic.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ Use parentClipRects(), rather than calculateRects(), to compute the overflow
+ rect that we'll use to create a masking layer for composited clipping.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::clippedByAncestor):
+ Use parentClipRects() to see whether there's a layer between us and our
+ compositing ancestor which applies clipping.
+
+ (WebCore::RenderLayerCompositor::clipsCompositingDescendants):
+ A layer which imposes clipping to its children doesn't have to be a stacking
+ context; it might be a normal flow layer; in either case, we can rely on the
+ hasCompositingDescendant() bit.
+
+2009-03-26 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=24837
+ Escape key should dismiss select menu
+
+ Reviewed by Adam Roben.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupWndProc):
+
+2009-03-26 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Make sure the script uses LF line endings even on Windows.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24805
+
+ * WebCore/make-generated-sources.sh: Change svn:eol-style to LF
+
+2009-03-26 Eli Fidler <eli.fidler@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Remove warnings all over the place by making operator precedence
+ explicit in cases like x && y || z. No functional change.
+
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::addFontFaceRule):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseShadow):
+ * dom/Document.cpp:
+ (WebCore::Document::shouldScheduleLayout):
+ * dom/Node.cpp:
+ (WebCore::Node::isBlockFlowOrBlockTable):
+ * dom/Node.h:
+ (WebCore::Node::document):
+ * dom/Position.cpp:
+ (WebCore::Position::next):
+ (WebCore::Position::upstream):
+ (WebCore::Position::downstream):
+ (WebCore::Position::getInlineBoxAndOffset):
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::atStart):
+ * dom/Range.cpp:
+ (WebCore::Range::intersectsNode):
+ * editing/Editor.cpp:
+ (WebCore::Editor::setBaseWritingDirection):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::advance):
+ (WebCore::SimplifiedBackwardsTextIterator::advance):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::canonicalPosition):
+ * editing/htmlediting.cpp:
+ (WebCore::isMailBlockquote):
+ (WebCore::lineBreakExistsAtPosition):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::processFileDateString):
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::updateFromElement):
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::checkForHeadCharset):
+ * page/AccessibilityObject.cpp:
+ (WebCore::updateAXLineStartForVisiblePosition):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::sendContextMenuEvent):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::PropertyWrapperGetter::equals):
+ (WebCore::PropertyWrapperShadow::equals):
+ * platform/ContextMenu.cpp:
+ (WebCore::ContextMenu::populate):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
+ * platform/text/Base64.cpp:
+ (WebCore::base64Encode):
+ * platform/text/BidiResolver.h:
+ (WebCore::::raiseExplicitEmbeddingLevel):
+ (WebCore::::createBidiRunsForLine):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::placeEllipsisBox):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addChild):
+ (WebCore::RenderBlock::repaintOverhangingFloats):
+ (WebCore::RenderBlock::fillInlineSelectionGaps):
+ (WebCore::RenderBlock::positionForPoint):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ (WebCore::RenderBlock::hasLineIfEmpty):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::imageChanged):
+ (WebCore::RenderBox::localCaretRect):
+ (WebCore::RenderBox::positionForPoint):
+ (WebCore::RenderBox::shrinkToAvoidFloats):
+ * rendering/RenderObject.h:
+ (WebCore::objectIsRelayoutBoundary):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::calcPrefWidths):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::determineStartPosition):
+ (WebCore::textWidth):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff):
+ * rendering/style/StyleInheritedData.cpp:
+ (WebCore::cursorDataEquivalent):
+ * rendering/style/StyleRareInheritedData.cpp:
+ (WebCore::StyleRareInheritedData::shadowDataEquivalent):
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::shadowDataEquivalent):
+ (WebCore::StyleRareNonInheritedData::animationDataEquivalent):
+ (WebCore::StyleRareNonInheritedData::transitionDataEquivalent):
+
+2009-03-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24804
+ [GTK] 401 responses cause rogue content to be loaded
+
+ Our soup code handles 401 responses itself, so we should not feed
+ the headers and data of those responses to the loader.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::gotHeadersCallback):
+ (WebCore::gotChunkCallback):
+
+2009-03-25 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt and Darin Adler.
+
+ Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
+ during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
+
+ The problem was that allocation of the global object would, for just a
+ moment, leave the global object's prototype unprotected from GC. This
+ bug doesn't apply to non-global DOM objects because their prototypes are
+ cached and marked by the global object.
+
+ No test case because the crashing condition is hard to deterministically
+ produce in a normal build, and in a Windows Release build with
+ COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::setWindow):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::initScript): Protect the global object's
+ prototype from GC during construction, since the global object does not
+ yet point to it, and therefore won't mark it.
+
+2009-03-25 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=23361
+
+ When using hardware compositing, some images can be directly
+ rendered by the hardware - no need to draw them into a separate
+ context, therefore saving memory.
+ Only images with certain style properties can be directly
+ composited - basically anything that is not a simple image requires
+ the usual rendering path (eg. if the image has borders).
+
+ Test: compositing/direct-image-compositing.html
+
+ * manual-tests/resources/simple_image.png: Added.
+ * manual-tests/simple-image-compositing.html: Added.
+ * platform/graphics/Image.h:
+ (WebCore::Image::startAnimation):
+ - move this to public
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::imageChanged):
+ - poke compositing layer if image has changed
+ (WebCore::RenderImage::notifyFinished):
+ - let the compositing layer know that it can render the image
+ * rendering/RenderImage.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::rendererContentChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::canUseInnerContentLayer):
+ (WebCore::RenderLayerBacking::detectDrawingOptimizations):
+ (WebCore::RenderLayerBacking::rendererContentChanged):
+ * rendering/RenderLayerBacking.h:
+ - code to hook up direct compositing of images where
+ possible
+
+2009-03-25 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
+ rename of V8NodeFilter to V8NodeFilterCondition.
+
+ * bindings/v8/V8NodeFilterCondition.cpp:
+
+2009-03-25 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24817
+
+ When the slider range is zero, avoid a divide by zero, which caused the
+ thumb to be positioned off in the weeds, which broke painting.
+
+ Test: media/video-empty-source.html
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::SliderRange::proportionFromValue):
+ (WebCore::SliderRange::valueFromProportion):
+ (WebCore::sliderPosition):
+ (WebCore::RenderSlider::setValueForPosition):
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove dead code and style cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::CanvasStyle):
+ Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't
+ want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
+ * page/FocusController.cpp:
+ (WebCore::FocusController::setFocusedNode):
+ "node" was checked just above and is already known to be non-null
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::insertOnlyThisLayer):
+ We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check
+ (WebCore::RenderLayer::resize):
+ element is already ASSERTed above, no need to null check it here
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addCell):
+ currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Move ASSERT(foo) to before where foo-> is used
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * platform/chromium/PasteboardChromium.cpp:
+ (WebCore::Pasteboard::writeImage):
+ Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved
+ ASSERT(node) to the top of the function it made sense to move the rest of them there too.
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::prepareToRenderSVGContent):
+ move ASSERT(object) to *before* we use "object" :)
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Make TextTokenizer ASSERT that the buffer was freed
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * loader/TextDocument.cpp:
+ (WebCore::TextTokenizer::TextTokenizer):
+ (WebCore::TextTokenizer::~TextTokenizer):
+ (WebCore::TextTokenizer::finish):
+ Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ I don't have a test case where we were taking the wrong path here
+ However, adding an ASSERT(lBreak.obj) before this usage caused
+ multiple bidi tests to fail, so lBreak.obj can be null here.
+
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::findNextLineBreak):
+ lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Style cleanup and dead code removal in dom, editing
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ (WebCore::ContainerNode::getLowerRightCorner):
+ (WebCore::ContainerNode::getRect):
+ Coverty was (rightly) confused as to what the hell "o" was being used for
+ and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines)
+ would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ Remove dead code, this block already checked that change == Force
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::removeInlineStyle):
+ Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus
+ prev will be null, and we don't really explicitly handle it (like we probably should)
+ It's OK though, because we end up creating a null position object, which may not have
+ been what we intended, but we certainly don't crash.
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ Remove dead code, insertionPosition.node() is already checked to be non-null above.
+ * editing/markup.cpp:
+ (WebCore::appendStartMarkup):
+ removed dead code, annotate is already known to be true at this point in the file
+ !annotate was checked above, and break; was called.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ CSS dead code removal and cleanup from Coverty errors
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Every other place in the code we check settings() for NULL, so I made these places
+ check too, even though we should never be resolving style against a document which has
+ no frame (which I believe is the only time settings() can be null)
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::styleSheetChanged):
+ Removing dead code, "root" can never be null here.
+ * css/SVGCSSStyleSelector.cpp:
+ (WebCore::colorFromSVGColorCSSValue):
+ (WebCore::CSSStyleSelector::applySVGProperty):
+ Extra returns in the old macros caused dead code. Removing the old macros and use modern
+ ones instead. :)
+ Extra null checks to value were not needed. Added an ASSERT at the top of the function
+ to make it clear that value will never be NULL.
+ Added colorFromSVGColorCSSValue to clean up the code a little.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Font fallback cleanup and added ASSERT for GlyphPageTreeNode
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * css/CSSFontSelector.cpp:
+ (WebCore::compareFontFaces):
+ Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets
+ I can't read the code well enough to tell, so I tried to make the code clearer
+ and added an ASSERT.
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::GlyphPageTreeNode::initializePage):
+ Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already
+ known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
+
+2009-03-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Coverty inspired fixes in Animations/Transforms
+ https://bugs.webkit.org/show_bug.cgi?id=24684
+
+ * page/animation/AnimationBase.h:
+ Fix animate() signatures to match so that the virtual methods actually override one another. :)
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
+ Attempt to fix this method, prevAnimation was never set to anything but NULL,
+ as far as I can tell the author originally intended to update it at the end
+ of the loop, which is what I changed this code to do.
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ Make method signature match AnimationBase::animate
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+ Make method signature match AnimationBase::animate
+ * page/animation/KeyframeAnimation.h:
+ * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
+ (WebCore::PerspectiveTransformOperation::blend):
+ if (blendToIdentity) already returned above.
+ * platform/graphics/transforms/RotateTransformOperation.cpp:
+ (WebCore::RotateTransformOperation::blend):
+ if (blendToIdentity) already returned above.
+
+2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fix compiler warnings regarding assignments in if statements.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::createFormData):
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::compare):
+
+2009-03-25 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6472150> repro crash in
+ RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using
+ menus
+
+ Test: fast/inline/continuation-positioned-reparenting.html
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::splitFlow): When repurposing the existing
+ container as the "pre" block, clear its positioned objects list, because
+ positioned descendants may end up in a different block after the split.
+
+2009-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24784
+
+ Length values in transform operations need to take zoom into account.
+
+ Test: fast/transforms/transforms-with-zoom.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::createTransformOperations):
+
+2009-03-25 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
+ values. Add support for the new values (while preserving the old values for backwards
+ compatibility).
+
+ Changed some existing test cases to use the new values.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseFillProperty):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator EFillBox):
+ * css/CSSValueKeywords.in:
+
+2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Fix complex text opacity on the Chromium Windows port.
+ https://bugs.webkit.org/show_bug.cgi?id=24757
+
+ Test: fast/text/complex-text-opacity.html
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+
+2009-03-25 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
+ the border-radius, since the assumption is that any desired rounding will be built into the border-image
+ itself.
+
+ Note that I do not agree with this change, but I am matching the spec.
+
+ Added fast/borders/border-image-border-radius.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintNinePieceImage):
+
+2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24750
+ [GTK] requests download instead of displaying page
+
+ Fix the Content-Type headers we get from soup, so that we set a
+ proper media type on the ResourceResponse.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+
+2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24600
+ [GTK] responses with status code >= 400 should not be given special treatment
+
+ Do not special case requests that have HTTP responses >=
+ 400. Redirects are handled automatically by libsoup, but the rest
+ of the responses should be treated like any other.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::):
+ (WebCore::gotHeadersCallback):
+ (WebCore::gotChunkCallback):
+ (WebCore::finishedCallback):
+
+2009-03-25 Darin Adler <darin@apple.com>
+
+ Reviewed by John Sullivan.
+
+ Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
+ they are being used only for selections, not an entire document.
+
+ * WebCore.base.exp: Remove exported function that's not used in WebKit.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member
+ function so it can share private things with other member functions. Added some FIXME
+ comments to a branch of code I think is dead. Changed boolean argument into a named
+ one. Renamed to match other similar functions.
+ (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto.
+ (WebCore::LegacyWebArchive::createResource): Ditto.
+ (WebCore::LegacyWebArchive::create): Merged the create and init functions.
+ (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because
+ we should never fail to write (we can fail to read).
+ (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static
+ member function as above.
+ (WebCore::LegacyWebArchive::createFromSelection): Ditto.
+ (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than
+ iterators. Only include the favicon if the first node is the document since we don't
+ want to include the favicon when copying and pasting.
+
+ * loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private.
+ Made the Mac-specific functions be static member functions. Made other helpers be
+ static member functions. Removed the nit function.
+
+ * loader/archive/cf/LegacyWebArchiveMac.mm:
+ (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated
+ comment and made this a static member function.
+ (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made
+ it so we only type cast in one place.
+
+2009-03-25 Darin Adler <darin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
+ https://bugs.webkit.org/show_bug.cgi?id=24740
+ rdar://problem/6679873
+
+ Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
+ https://bugs.webkit.org/show_bug.cgi?id=12104
+
+ Test: media/video-display-none-crash.html
+
+ The problem here was that RenderSlider was trying to position its thumb in a way that
+ requires it to call updateLayout inside rendering code. The right way to position a
+ child renderer is to do layout, so I had to write a layout function. And then fix a few
+ other small problems shown by the same test case.
+
+ * rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage.
+ Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
+ prefix for public DOM classes, not elements used as implementation details.
+ Made SliderThumbElement function members private and got rid of unneeded default
+ argument value for shadowParent.
+ (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes.
+ (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above.
+ (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in
+ a way that clamps to the range.
+ (WebCore::sliderPosition): Added. Computes the slider position: a double.
+ (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit
+ initialization of m_initialClickPoint.
+ (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead
+ of calling setCurrentPosition and valueChanged.
+ (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb.
+ (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle.
+ (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code
+ setting the position to relative and setting the left and top. We now handle positioning
+ in a custom layout function.
+ (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout.
+ (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value
+ in the element if it's out of range. This clamping used to be done as a side effect of
+ setPositionFromValue. Also, this has nothing to do with the renderer, so at some point
+ it could be moved into HTMLInputElement. Removed call to setPositionFromValue
+ and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be
+ a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want
+ this to be propagated to the parent -- it's not called during layout.
+ (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange
+ class. Also don't call setCurrentPosition; instead just call setNeedsLayout.
+ (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather
+ than the style to find the position; that means this needs to be done after layout is done.
+ Also removed unneeded runtime checks and replaced them with assertions, after checking
+ all callers to see they already guarantee this.
+ (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them
+ with assertions, after checking all callers to see they already guarantee this.
+ (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't
+ crash if called early on a brand new RenderSlider.
+
+ * rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode.
+ Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
+ prefix for public DOM classes, not elements used as implementation details. Made the
+ mouseEventIsInThumb function non-virtual. Removed the return value and argument from
+ setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle
+ argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some
+ private member functions.
+
+2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fix ambiguous else cases by adding braces to nested if()s with elses.
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::continueAfterContentPolicy):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::updateDragAndDrop):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::toArmenianUnder10000):
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+
+2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Move variable into proper platform block to quiet warning.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+
+2009-03-24 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ Fix for <rdar://problem/6719375> Deal with QTKit loadstate changes when playing streaming movies
+
+ * WebCore/html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setNetworkState): Deal with media engine reviving after having
+ network state of NETWORK_NO_SOURCE.
+
+ * WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::updateStates): Reset m_readyState at each state change since
+ some types of movies currently cause QTKit's load state to bounce around. QTMovieLoadStatePlaythroughOK
+ corresponds to HaveFutureData, not HaveEnoughData.
+
+2009-03-24 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24707
+ <rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
+
+ * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
+ After breaking out of an empty mail blockquote, we still want continue with the deletion
+ so actual content will get deleted, and not just the quote style.
+
+2009-03-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ <rdar://problem/6624662> REGRESSION (r39904): can't save certain web pages as web archive (ones without favicons!)
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Added a null check.
+
+2009-03-24 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24685
+
+ The Skia drawLine function takes subpixel values and attempts to draw
+ a line with subpixel precision. This is complex and slow for drawing
+ scrollbars which use only vertical and horizontal lines.
+
+ This changes the Chromium Linux scrollbar code to use drawIRect.
+
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
+ (WebCore::drawVertLine):
+ (WebCore::drawHorizLine):
+ (WebCore::drawBox):
+ (WebCore::ScrollbarThemeChromium::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromium::paintThumb):
+
+2009-03-24 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23310>
+
+ Reviewed by Darin Adler.
+
+ Test: fast/frames/iframe-no-src-set-location.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::completeURL): If m_baseURL is empty or is
+ about:blank and we have a parent document, use the parent
+ document's URL for the base when completing a new URL.
+
+2009-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24659
+
+ When hit-testing 3d-transformed layers, it doesn't make sense to project the hitTestRect
+ into the coordinate space of the layer, and doing so can result in pathalogical quads
+ that break hit testing. In that case, simply use the same bounds as used for painting,
+ which are the composited bounds for this layer.
+
+ Test: transforms/3d/hit-testing/rotated-hit-test.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24436
+
+ When compositing is enabled, painting and hit testing end up using different
+ clipping roots, because, for painting, every composited layer is a clipping root,
+ but for hit testing only layers with transforms are. To fix this, we use
+ temporary clip rects for hit testing, if the page is in compositing mode.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::parentClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ * rendering/RenderLayer.h:
+
+2009-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24782
+
+ Fix regression with CSS clip rects with non-length values, by reverting to
+ the original code, but passing the zoom multiplier through convertToLength().
+
+ Also make stylistic change in createTransformOperations(), renaming 'inStyle'
+ to 'style.
+
+ Tested by existing tests.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::convertToLength):
+ (WebCore::CSSStyleSelector::applyProperty):
+ (WebCore::CSSStyleSelector::createTransformOperations):
+
+2009-03-24 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents
+ to a border-radius.
+
+ This patch makes non-self-painting overflow layers and control clips work with border-radius. RenderLayers
+ that should be clipped by overflow ancestors with border-radius are still broken.
+
+ Added fast/clip/overflow-border-radius-clip.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::pushContentsClip):
+
+2009-03-24 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents.
+
+ This first patch makes overflow:hidden properly clip the foreground contents of overflow:hidden replaced elements. Common
+ replaced elements now default to overflow:hidden in the UA stylesheet (this is what the spec specifically recommends be
+ done).
+
+ Added fast/replaced/border-radius-clip.html
+
+ * css/html4.css:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::paint):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+
+2009-03-24 Adele Peterson <adele@apple.com>
+
+ RS by Mark Rowe.
+
+ Only build these Mail quirks checks in on the Mac.
+
+ * dom/Document.cpp: (WebCore::disableRangeMutation):
+ * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
+
+2009-03-24 Brent Fulgham <bfulgham@webkit.org>
+
+ Build fix, no review.
+
+ Remove ResourceLoaderCFNet.cpp from build list for Cairo Releas
+ and Debug targets.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-03-24 Eric Carlson <eric.carlson@apple.com>
+
+ Fix layout tests broken by r41907.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setReadyState): Don't set "was playing" based on the new ready state
+
+2009-03-24 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24689
+ Fix Chromium compilation errors.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
+ (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
+
+2009-03-24 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24759
+ Add missing methods Element.prototype.removeMatchingStyleClasses and
+ Node.prototype.enclosingNodeOrSelfWithNodeNameInArray to SourceFrame content
+ iframe. These methods are called by Element.prototype.removeStyleClass and
+ Node.prototype.enclosingNodeOrSelfWithNodeName.
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._loaded):
+
+2009-03-24 Mark Mentovai <mark@chromium.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24653
+ WebKit should be buildable without prefix header injection.
+ Adds missing #includes and forward declarations as needed.
+
+ * editing/SmartReplaceCF.cpp:
+ * platform/graphics/mac/ColorMac.mm:
+ * platform/graphics/mac/FontCacheMac.mm:
+ * platform/graphics/mac/FontCustomPlatformData.h:
+ * platform/graphics/mac/FontMac.mm:
+ * platform/graphics/mac/FontMacATSUI.mm:
+ * platform/graphics/mac/FontPlatformData.h:
+ * platform/graphics/mac/FontPlatformDataMac.mm:
+ * platform/graphics/mac/GraphicsContextMac.mm:
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ * platform/mac/FoundationExtras.h:
+ * platform/mac/LocalCurrentGraphicsContext.h:
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm:
+ * platform/mac/WebCoreTextRenderer.h:
+ * platform/mac/WebCoreTextRenderer.mm:
+ * platform/mac/WebFontCache.h:
+ * platform/mac/WebFontCache.mm:
+ * platform/text/PlatformString.h:
+ * platform/text/mac/ShapeArabic.c:
+ * platform/text/mac/StringMac.mm:
+ * rendering/RenderThemeChromiumMac.h:
+
+2009-03-24 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6107874> by capping the nesting depth of
+ "block-level" elements generated by the parser
+
+ Test: fast/parser/block-nesting-cap.html
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::HTMLParser):
+ (WebCore::HTMLParser::insertNode):
+ (WebCore::HTMLParser::pushBlock):
+ (WebCore::HTMLParser::popOneBlockCommon):
+ (WebCore::HTMLParser::freeBlock):
+ * html/HTMLParser.h:
+
+2009-03-23 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24771
+
+ DOMTimeStamps are based upon 1970.
+
+ * platform/mac/GeolocationServiceMac.mm:
+ (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
+
+2009-03-23 Eric Seidel <eric@webkit.org>
+
+ Build fix, no review.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createVisiblePosition): change .container to .isNotNull()
+
+2009-03-23 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Rename Position::container to m_anchorNode and make it private
+ https://bugs.webkit.org/show_bug.cgi?id=24760
+
+ More code cleanup for Position.
+
+ Change all uses of m_container to node()
+ Eventually most uses of node() should change to anchorNode() to designate
+ that it's the node the Position is anchored to, but not necessarily the
+ container of the position (it could be the before/after neighbor).
+
+ Remove any code which sets m_container, and change it to use a new
+ Position::moveToPosition function which takes a node and offset.
+ It never makes sense to change the node and leave the offset.
+
+ * dom/Position.h:
+ (WebCore::Position::Position):
+ (WebCore::Position::clear):
+ (WebCore::Position::anchorNode):
+ (WebCore::Position::node):
+ (WebCore::Position::moveToPosition):
+ (WebCore::Position::moveToOffset):
+ (WebCore::Position::isNull):
+ (WebCore::Position::isNotNull):
+ (WebCore::operator==):
+ * dom/Range.cpp:
+ (WebCore::Range::create):
+ (WebCore::Range::compareBoundaryPoints):
+ * dom/RangeBoundaryPoint.h:
+ (WebCore::RangeBoundaryPoint::container):
+ (WebCore::RangeBoundaryPoint::set):
+ (WebCore::RangeBoundaryPoint::setOffset):
+ (WebCore::RangeBoundaryPoint::setToChild):
+ (WebCore::RangeBoundaryPoint::setToStart):
+ (WebCore::RangeBoundaryPoint::setToEnd):
+
+2009-03-17 Eric Seidel <eric@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ document.write() should be able to make a document strict mode
+ https://bugs.webkit.org/show_bug.cgi?id=24336
+
+ Remove an implicit write of "<html>" on the first document.write call
+ this was added as part of a KDE import http://trac.webkit.org/changeset/798
+ with no layout test or explanation. I can't think of any reason why
+ an implicit <html> write is necessary (or correct), so I'm removing it and
+ adding a test for the correct behavior. The parser will add any necessary
+ HTMLHTMLElements during the write() anyway.
+
+ Our behavior is now tested by fast/dom/Document/document-write-doctype
+ and matches IE, FF fails this new test. Mozilla bug filed:
+ https://bugzilla.mozilla.org/show_bug.cgi?id=483908
+
+ * dom/Document.cpp:
+ (WebCore::Document::write):
+
+2009-03-23 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6140966>
+ Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/CrossOriginPreflightResultCache.cpp:
+ (WebCore::CrossOriginPreflightResultCache::empty):
+ * loader/CrossOriginPreflightResultCache.h:
+
+2009-03-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 24726: hit testing doesn't work right when the click is on anonymous content
+ https://bugs.webkit.org/show_bug.cgi?id=24726
+ rdar://problem/6696992
+
+ Test: editing/selection/hit-test-anonymous.html
+
+ * rendering/RenderBR.cpp:
+ (WebCore::RenderBR::positionForPoint): Call createVisiblePosition instead of
+ creating a VisiblePosition directly. It will handle finding non-anonymous
+ content nearby if node() is 0.
+ * rendering/RenderBlock.cpp:
+ (WebCore::positionForPointRespectingEditingBoundaries): Ditto.
+ (WebCore::positionForPointWithInlineChildren): Ditto.
+ (WebCore::RenderBlock::positionForPoint): Ditto.
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionForPoint): Ditto.
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::positionForPoint): Ditto.
+ (WebCore::RenderObject::createVisiblePosition): Added.
+ * rendering/RenderObject.h: Added createVisiblePosition.
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::positionForPoint): Call createVisiblePosition.
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::positionForPoint): Ditto.
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::positionForPoint): Ditto.
+
+2009-03-23 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler & Dave Hyatt.
+
+ Fix for <rdar://problem/6621310> REGRESSION(35185): Apple Travel HTML emails missing some style after Safari 4 upgrade
+
+ Leopard Mail doesn't expect <style> to be in the body. This change reverts back to the old behavior of
+ moving <style> to <head> for that version of Mail.
+
+ * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
+
+2009-03-23 Adele Peterson <adele@apple.com>
+
+ Reviewed by Mark Rowe & Dave Hyatt.
+
+ Merge some of the individual Mail quirks into two settings that we can check for future quirks.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::disableRangeMutation):
+ (WebCore::Document::nodeChildrenChanged):
+ (WebCore::Document::nodeWillBeRemoved):
+ (WebCore::Document::textInserted):
+ (WebCore::Document::textRemoved):
+ (WebCore::Document::textNodesMerged):
+ (WebCore::Document::textNodeSplit):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setNeedsLeopardMailQuirks):
+ (WebCore::Settings::setNeedsTigerMailQuirks):
+ * page/Settings.h:
+ (WebCore::Settings::needsLeopardMailQuirks):
+ (WebCore::Settings::needsTigerMailQuirks):
+
+2009-03-23 Ada Chan <adachan@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=24762
+ Support text-indent in <option> elements on windows platform.
+
+ Reviewed by Adele Peterson.
+
+ * css/themeWin.css:
+ * platform/PopupMenuStyle.h: We don't honor font specified on <option> elements right now. Make this
+ explicit via windows themed default stylesheet.
+ (WebCore::PopupMenuStyle::PopupMenuStyle): Also store text-indent and text-direction.
+ (WebCore::PopupMenuStyle::textIndent):
+ (WebCore::PopupMenuStyle::textDirection):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::paint): Adjust the text's x-coordinate if text-indent is supported for options and
+ text-indent is specified with LTR direction.
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::updateOptionsWidth): Take text-indent into account if theme supports text-indent for options.
+ (WebCore::RenderMenuList::itemStyle): Use new PopupMenuStyle constructor on windows.
+ (WebCore::RenderMenuList::menuStyle): Ditto.
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::menuStyle): Ditto.
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::popupOptionSupportsTextIndent): Added. Default is false since we are only supporting it in windows for now.
+ * rendering/RenderThemeWin.h:
+ (WebCore::RenderThemeWin::popupOptionSupportsTextIndent): Returns true for windows.
+
+2009-03-23 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24699
+ REGRESSION: Java Applets broken
+ <rdar://problem/6707494>
+
+ Fix loading Java applets without a codeBase. Only pass the base (up to the
+ the last path component) of the baseURL to the plug-in.
+
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::createRenderer):
+ * platform/KURL.cpp:
+ (WebCore::KURL::baseAsString):
+ * platform/KURL.h:
+
+2009-03-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * platform/KURL.h: Removed now-incorrect comments.
+ None of the parts include the separator characters any more, now that
+ query doesn't include the "?", so the comments explaining which do and do
+ not are no-longer helpful.
+
+2009-03-23 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24764
+
+ Renamed files V8NodeFilter -> V8NodeFilterCondition to reflect
+ class names. Also fixed some headers that got mangled in search/replace
+ operations.
+
+ No change in behavior, so no test.
+
+ * bindings/v8/V8NodeFilter.h: Removed.
+ * bindings/v8/V8NodeFilterCondition.cpp: Renamed from WebCore/bindings/v8/V8NodeFilter.cpp.
+ * bindings/v8/V8NodeFilterCondition.h: Added.
+ * bindings/v8/custom/V8ClipboardCustom.cpp:
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ * bindings/v8/custom/V8ElementCustom.cpp:
+ * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+ * bindings/v8/custom/V8NavigatorCustom.cpp:
+
+2009-03-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24741
+
+ Adds a unique across-browser-sessions identifier to FormData, which may
+ be used by ResourceHandle as a secondary cache key to enable cached
+ form submissions.
+
+ At issue: two otherwise identical form submissions may result in
+ completely independent responses, which may each be appropriate to
+ store and reuse from cache.
+
+ * html/HTMLFormElement.cpp: Added call to FormData::setIdentifier so that
+ we only enable cached form submissions for those generated by HTML. This
+ way we do not bother with POSTs generated by XMLHttpRequest.
+ (WebCore::generateFormDataIdentifier):
+ (WebCore::HTMLFormElement::createFormData):
+ * platform/network/FormData.cpp: Initialize m_identifier to 0, which means
+ the unspecified identifier. So by default there is no identifier and
+ nothing changes.
+ (WebCore::FormData::FormData):
+ * platform/network/FormData.h: Added m_identifier with setter and getter.
+ (WebCore::FormData::setIdentifier):
+ (WebCore::FormData::identifier):
+
+2009-03-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=24733
+
+ Fix media controller with full-page zoom. Previously, the media controller
+ shadow nodes never saw style changes on the RenderMedia, so did not respond
+ to zooming at all. Now, we update the style on the shadow renderers
+ whenever RenderMedia gets a style change. Also fix the video thumb in
+ the theme to be scaled properly.
+
+ Test: media/video-controls-zoomed.html
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::updateStyle):
+ (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
+ (WebCore::MediaTextDisplayElement::updateStyle):
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ (WebCore::MediaControlInputElement::updateStyle):
+ * rendering/MediaControlElements.h:
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::styleDidChange):
+ * rendering/RenderMedia.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustSliderThumbSize):
+
+2009-03-23 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24739
+
+ Rework StringImpl::create methods to try to allocate a single buffer
+ rather than allocating both the StringImpl class and a separate data
+ buffer.
+
+ * platform/text/StringImpl.cpp:
+ * platform/text/StringImpl.h:
+
+2009-03-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ Based on a patch by Nico Weber <nicolasweber@gmx.de>
+
+ Bug 24755: LayoutTests/http/tests/misc/url-in-utf16le.html regression
+ https://bugs.webkit.org/show_bug.cgi?id=24755
+
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::isUTF7Encoding): Added. Checks if the current encoding
+ is UTF7 without loading extended codecs.
+ (WebCore::TextEncoding::encodingForFormSubmission): Use isUTF7Encoding() instead
+ of comparing with UTF7Encoding(). Eliminate the explicit check of
+ noExtendedTextEncodingNameUsed() because that's now handled by the functions
+ that this function calls instead.
+
+ * platform/text/TextEncoding.h: Added isUTF7Encoding function.
+ Also tweaked formatting a bit.
+
+2009-03-20 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24720
+ RenderThemeChromium should draw something for Slider parts instead of
+ dropping them on the floor.
+
+ * platform/chromium/ChromiumBridge.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
+ (WebCore::RenderThemeChromiumWin::paintSliderTrack):
+ (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
+ (WebCore::RenderThemeChromiumWin::getThemeData):
+ * rendering/RenderThemeChromiumWin.h:
+ (WebCore::RenderThemeChromiumWin::paintSliderThumb):
+
+2009-03-23 Glen Murphy <glen@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24657
+
+ Fix Skia drawing of highly scaled bitmaps; the conversion to
+ IntRect produced visible layout test failures in highly scaled
+ coordinate systems.
+
+ Test: svg/custom/image-small-width-height.svg
+
+ * WebCore\platform\graphics\skia\ImageSkia.cpp:
+
+2009-03-23 David Kilzer <ddkilzer@apple.com>
+
+ Provide JavaScript exception information after slow script timeout
+
+ Reviewed by Oliver Hunt.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate): Changed to report
+ exceptions for the Interrupted completion type as well.
+
+2009-03-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24736
+
+ Fix three mostly-unrelated problems with full-page zoom:
+
+ * dom/Document.cpp:
+ (WebCore::Document::elementFromPoint):
+ Document::elementFromPoint() needs to take full-page zoom into account.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+ Take full-page zoom into account when computing offsetX/offsetY.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ Don't use offsetX/offsetY when hit testing list boxes; offsets were broken
+ with full-page zoom, and using pageX/pageY is easier because we don't
+ have to worry about the event target, and we already have a point in
+ absolute coordinates.
+
+ Tests: fast/forms/listbox-hit-test-zoomed.html
+ fast/forms/search-zoomed.html
+ fast/forms/slider-zoomed.html
+
+2009-03-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24753
+
+ The rect for CSS 'clip' needs to have zooming applied to it.
+
+ Test: fast/css/clip-zooming.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+
+2009-03-23 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adam Roben.
+
+ <rdar://problem/6704282>
+ https://bugs.webkit.org/show_bug.cgi?id=24719
+ QTMovieWinTimer logic inversion
+
+ Fix logic inversion in the Win32 timer used by QTMovieWin that caused it to always
+ use SetTimer, even when the intervals was below USER_TIMER_MINIMUM. A side effect of
+ this was that a movie timer would sometimes be blocked for significant amounts of time
+ because WM_TIMER messages are not processed when the thread's message queue has any
+ higher priority messages, and WebCore/Win's timer uses PostMessage for low interval
+ timers. Also change SetTimer call to use HWND and custom message instead of
+ timer function since the timer already has an HWND for processing PostMessage.
+
+ Not possible to make a test for this because it is so timing dependant.
+
+ * platform/graphics/win/QTMovieWinTimer.cpp:
+ (TimerWindowWndProc):
+ (setSharedTimerFireDelay):
+
+2009-03-23 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24588
+
+ Update media element implementation to current HTML5 spec
+
+ New tests:
+ media/media-constants.html
+ media/video-seek-no-src-exception.html
+ media/video-source-add-src.html
+ media/video-src-invalid-remove.html
+ media/video-src-plus-source.html
+ media/video-timeupdate-during-playback.html
+
+ * dom/EventNames.h: Remove obsolute events, add new ones.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member vars.
+ (WebCore::HTMLMediaElement::attributeChanged): Trigger load() only when we don't
+ have a source.
+ (WebCore::HTMLMediaElement::removedFromDocument): Deal with state name changes.
+ (WebCore::HTMLMediaElement::scheduleProgressEvent): New, create a progress event and
+ add it to the event queue to be dispatch when the timer fires.
+ (WebCore::HTMLMediaElement::scheduleEvent): New, create a generic event and add
+ it to the event queue to be dispatch when the timer fires.
+ (WebCore::HTMLMediaElement::enqueueEvent): Add an event to the queue and ticke the
+ asynch event timer.
+ (WebCore::HTMLMediaElement::asyncEventTimerFired): Dispatch all pending events.
+ (WebCore::HTMLMediaElement::loadTimerFired): Either trigger the initial load or
+ try to load the next <source> url.
+ (WebCore::HTMLMediaElement::load): Minor style change.
+ (WebCore::HTMLMediaElement::loadInternal): The first part of the spec load algorithm, cleanup
+ the current load (if any) and set up state for a new load.
+ (WebCore::HTMLMediaElement::selectMediaResource): Deal with no 'src' or <source>, post 'loadstart'
+ event, and initiate load from 'src' if present.
+ (WebCore::HTMLMediaElement::loadNextSourceChild): Initiate load from next <source> url, or trigger
+ noneSupported() if no more to consider.
+ (WebCore::HTMLMediaElement::loadResource): Instantiate a new MediaPlayer and ask it to load a url.
+ (WebCore::HTMLMediaElement::startProgressEventTimer): Start the repeating progress event timer.
+ (WebCore::HTMLMediaElement::noneSupported): Post error event and set up state when no valid
+ media url was found.
+ (WebCore::HTMLMediaElement::mediaEngineError): Post error event and set up state when no valid
+ media engine failed with a decode error or a network error.
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
+ (WebCore::HTMLMediaElement::setNetworkState): Updated for new spec network states.
+ (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
+ (WebCore::HTMLMediaElement::setReadyState): Updated for new spec ready state.
+ (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if the network is not active.
+ (WebCore::HTMLMediaElement::seek): Return INVALID_STATE_ERR exception if state is too low or
+ if player hasn't been set up yet. This is necessary becase load() is async. Clear the flag
+ we use to guard against sending 'ended' more than once.
+ (WebCore::HTMLMediaElement::duration): Don't bother calling media engine before it has metadata.
+ (WebCore::HTMLMediaElement::setDefaultPlaybackRate): Remove exception param, 0 is no longer an
+ invalid rate.
+ (WebCore::HTMLMediaElement::setPlaybackRate): Remove exception param, 0 is no longer an
+ invalid rate. Cache rate being set so we can use it later if media engine isn't ready now.
+ (WebCore::HTMLMediaElement::play): Remove exception param, play() before load() now just
+ starts loading asynchronously.
+ (WebCore::HTMLMediaElement::playInternal): Remove exception param. Fire 'waiting' or 'playing'
+ event depending on current state.
+ (WebCore::HTMLMediaElement::pause): Remove exception param, pause() before load() now just
+ starts loading asynchronously.
+ (WebCore::HTMLMediaElement::pauseInternal): Remove exception param.
+ (WebCore::HTMLMediaElement::setVolume): dispatchEventAsync -> scheduleEvent
+ (WebCore::HTMLMediaElement::setMuted): dispatchEventAsync -> scheduleEvent
+ (WebCore::HTMLMediaElement::togglePlayState): Remove exception param.
+ (WebCore::HTMLMediaElement::beginScrubbing): pause() doesn't take an exception param.
+ (WebCore::HTMLMediaElement::startPlaybackProgressTimer): New, starts timer that fires 4 times per
+ second when the movie is playing to timeupdate so we can post 'timeupdate' events.
+ (WebCore::HTMLMediaElement::playbackProgressTimerFired): Timer proc.
+ (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Bottleneck around scheduling a 'timeupdate'
+ event because we both fire them them when the spec says we should and when the media engine
+ says that time has jumped, but we don't want to fire more than one at a given movie time. We also
+ use this bottleneck to keep track of the last time one was posted so we won't fire too often
+ during playback.
+ (WebCore::HTMLMediaElement::canPlay): readyState now tracks whether or not we have metadata.
+ (WebCore::HTMLMediaElement::havePotentialSourceChild): New, checks to see if there are a <source>
+ element with a 'src' attribute that we have not tried to load yet.
+ (WebCore::HTMLMediaElement::nextSourceChild): New, returns the url and content type of the next
+ <source> element that we haven't tried to load.
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Schedule 'seeked' event when seeking completes.
+ Set a flag when we post the 'ended' event, clear it when time changed and we aren't at the end since
+ some media engines call this proc more than once when playback reaches the end and stops, but we
+ don't want to post 'ended' more than once.
+ (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): New, added so media engine can inform
+ when the movie duration changes and we can post 'durationchanged' event.
+ (WebCore::HTMLMediaElement::mediaPlayerRateChanged): New, added so media engine can inform when
+ the rate changed and we can updated our cached rate. This is useful because we only want to know
+ post periodic 'timeupdate' events when the movie is actually playing, and because we want to know
+ the actual playback rate when it differs from what we tried to set.
+ (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): New, added so media engine can inform when
+ a movie's intrinsic size changes and we can inform the renderer.
+ (WebCore::HTMLMediaElement::potentiallyPlaying): Renamed from activelyPlaying since the spec now
+ uses "actively playing" for this concept. Update logic for new state names and un-comment calls
+ to stoppedDueToErrors() and pausedForUserInteraction() since the spec says those condiditons
+ are part of the answer.
+ (WebCore::HTMLMediaElement::endedPlayback): Update logic for new state names.
+ (WebCore::HTMLMediaElement::stoppedDueToErrors): New, spec says this logic should be part of
+ the determination of "potentially playing".
+ (WebCore::HTMLMediaElement::pausedForUserInteraction): New, placeholder for when (if) user
+ agent supports this spec concept.
+ (WebCore::HTMLMediaElement::updatePlayState): Stop timer used to fire periodic 'timeupdate'
+ events when we pauses the movie. Set the media engine rate before calling play() in case it
+ wasn't set up when the rate was changed.
+ (WebCore::HTMLMediaElement::stopPeriodicTimers): New, stop the progress event and 'timeupate'
+ event timers.
+ (WebCore::HTMLMediaElement::userCancelledLoad): New, logic pulled out of documentWillBecomeInactive
+ and updated for the current spec.
+ (WebCore::HTMLMediaElement::documentWillBecomeInactive): Moved some logic to userCancelledLoad.
+ (WebCore::HTMLMediaElement::documentDidBecomeActive): Update comments.
+ (WebCore::HTMLMediaElement::initialURL): Update for refactoring of code that determines the
+ initial url.
+ * html/HTMLMediaElement.h: Change ReadyState and NetworkState enums to match names in the spec,
+ update for changes in .cpp.
+ (WebCore::HTMLMediaElement::):
+
+ * html/HTMLMediaElement.idl: Update ready state and network state constants for spec changes.
+ defaultPlaybackRate, playbackRate, play(), and pause() no longer raise exceptions.
+
+ * html/HTMLSourceElement.cpp:
+ (WebCore::HTMLSourceElement::insertedIntoDocument): Update for network state name changes.
+
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::updatePosterImage): Update for ready state name changes.
+
+ * html/MediaError.h:
+ (WebCore::MediaError::): add MEDIA_ERR_NONE_SUPPORTED.
+
+ * html/MediaError.idl: add MEDIA_ERR_NONE_SUPPORTED.
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler): play() and pause() don't take an exception.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::readyState): Update for newtork state name changes.
+ (WebCore::MediaPlayer::sizeChanged): New, so engine can report intrinsic size changes.
+ (WebCore::MediaPlayer::rateChanged): New, so engine can report rate changes.
+ (WebCore::MediaPlayer::durationChanged): New, so engine can report duration changes.
+ * platform/graphics/MediaPlayer.h: Update NetworkState and ReadyState enum names to match spec
+ states.
+ (WebCore::MediaPlayerClient::mediaPlayerDurationChanged): New.
+ (WebCore::MediaPlayerClient::mediaPlayerRateChanged): New.
+ (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): New.
+ (WebCore::MediaPlayer::):
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::load): Ditto.
+ (WebCore::MediaPlayerPrivate::updateStates): Ditto.
+ (WebCore::MediaPlayerPrivate::loadingFailed): Ditto.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Update for network/ready state name changes.
+ Remove endPointTimer, it is no longer necessary. Add m_enabledTrackCount and m_duration.
+ (WebCore::MediaPlayerPrivate::metaDataAvailable):
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer or m_endTime. Initialize
+ m_enabledTrackCount and m_duration. Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
+ (WebCore::MediaPlayerPrivate::pause): Ditto.
+ (WebCore::MediaPlayerPrivate::currentTime): No more m_endTime.
+ (WebCore::MediaPlayerPrivate::seek): Ditto.
+ (WebCore::MediaPlayerPrivate::doSeek): Ditto, plus don't call setRate(0) when the rate is
+ already zero.
+ (WebCore::MediaPlayerPrivate::setEndTime): No more m_endTime.
+ (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes. Return
+ different errors depending on what causes a failure. Watch for and report duration changes.
+ (WebCore::MediaPlayerPrivate::rateChanged): Report rate changes.
+ (WebCore::MediaPlayerPrivate::sizeChanged): Report size changes.
+ (WebCore::MediaPlayerPrivate::didEnd): No more endpoint timer.
+ (WebCore::MediaPlayerPrivate::setVisible): Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): Don't return number of unsupported
+ tracks, store in m_enabledTrackCount so we can use it to help determine causes of failure.
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::load): Ditto.
+ (WebCore::MediaPlayerPrivate::duration): Ditto.
+ (WebCore::MediaPlayerPrivate::updateStates): Ditto.
+ (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer. Update for
+ network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes. No more
+ m_endPointTimer.
+ (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
+ (WebCore::MediaPlayerPrivate::pause): Ditto.
+ (WebCore::MediaPlayerPrivate::setEndTime): Ditto.
+ (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes.
+ (WebCore::MediaPlayerPrivate::didEnd): No more m_endPointTimer.
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Update for network/ready state
+ name changes.
+ (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
+
+2009-03-22 Kevin Ollivier <kevino@theolliviers.com>
+
+ wxGTK build fix. Add missing header.
+
+ * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
+
+2009-03-22 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24665
+
+ Image-map code in RenderImage could result in RenderImage::nodeAtPoint()
+ setting HitTestResult::innerNode(), but returning false, which violates
+ hit testing rules. Use a temporary HitTestResult so that we only fill in
+ result when we know we've hit.
+
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::nodeAtPoint):
+
+2009-03-22 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=24743
+
+ Fix hit testing regression from r41840. We need to pass the temporary
+ HitTestResult when testing sublayers, then only copy to 'result' when
+ the layer is known to have been hit.
+
+ Test: fast/layers/zindex-hit-test.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24733
+
+ Fix hit testing on video controls after full page zoom by fixing wider issue
+ with event->pageX(), pageY() with zooming. pageX and pageY are "fixed" to be
+ invariant under zooming (for JavaScript), so we keep an actual page point around
+ in MouseEvent::absoluteLocation() to avoid the need to factor in zooming everywhere.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::initCoordinates):
+ (WebCore::MouseRelatedEvent::computePageLocation):
+ * dom/MouseRelatedEvent.h:
+ (WebCore::MouseRelatedEvent::absoluteLocation):
+ (WebCore::MouseRelatedEvent::setAbsoluteLocation):
+ Member var, and getter and setter for absoluteLocation.
+ New method, computePageLocation(), to compute the actual page point,
+ and call it when creating and initting mouse-related events.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchMouseEvent):
+ (WebCore::Node::dispatchWheelEvent):
+ Keep non-adjusted pageX and pageY around, and call setAbsoluteLocation()
+ on the event to replace a potentially rounded point.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ Clean up slider handling code.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ Add FIXME comment for use of offsetX/offsetY.
+
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::handleContextMenuEvent):
+ Use absoluteLocation() when hit testing for context menus.
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::userResize):
+ Use absoluteLocation() when resizing frames.
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::forwardEvent):
+ Use absoluteLocation() when hit testing media controls.
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::HTMLSliderThumbElement::defaultEventHandler):
+ (WebCore::RenderSlider::mouseEventIsInThumb):
+ Use absoluteLocation() when handling slider events.
+
+ (WebCore::RenderSlider::forwardEvent):
+ Factor some code out of HTMLInputElement::defaultEventHandler().
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ Use absoluteLocation() when hit testing search field buttons, which fixees
+ bugs in the search field with zooming.
+
+2009-03-21 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24727
+ Add V8XMLHttpRequest*.
+
+ * bindings/v8/V8XMLHttpRequestUtilities.cpp: Added.
+ * bindings/v8/V8XMLHttpRequestUtilities.h: Added.
+ * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Added.
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Added.
+ * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Added.
+
+2009-03-21 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24725
+ Add V8NodeFilter.
+
+ * bindings/v8/V8NodeFilter.cpp: Added.
+ * bindings/v8/V8NodeFilter.h: Added.
+
+2009-03-21 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Kevin Decker
+
+ - remove some redundant #include statements
+
+ * bindings/js/JSDOMWindowBase.cpp:
+
+2009-03-20 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix <rdar://problem/6574185> REGRESSION (3.2.2-TOT): hang in text drawing code
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::drawGDIGlyphs): Changed glyph stroking to fill and stroke each
+ glyph as a separate path, instead of all glyphs as a single path. This
+ matches what CGContextShowGlyphsWithAdvances() does, and has comparable
+ performance.
+
+2009-03-20 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser
+
+ Build fix for ENABLE(3D_RENDERING)
+
+ * rendering/RenderObject.h:
+ (WebCore::makeMatrixRenderable):
+
+2009-03-20 Dave Moore <davemoore@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24705
+
+ A bug in the V8 bindings is preventing chromium from setting the href on the
+ location object...any attempt throws a security error, not just for javascript
+ protocol
+
+ * page/Location.idl:
+
+2009-03-20 Craig Schlenter <craig.schlenter@gmail.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24608
+
+ Include stdio.h needed for printf on gcc 4.4.0
+
+ * platform/KURLGoogle.cpp:
+
+2009-03-20 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24577
+
+ Don't let comments at the end of an event handler
+ break the event handler.
+
+ No change in behavior, so no test.
+
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction):
+
+2009-03-20 Norbert Leser <norbert.leser@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24535
+
+ Fixes missing line terminator character (;) after macro call.
+ It is common practice to add the trailing ";" where macros are substituted
+ and not where they are defined with #define.
+ This change is consistent with other macro declarations across webkit,
+ and it also solves compilation failure with symbian compilers.
+
+ No change in behavior, so no test.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSImageConstructor.cpp:
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ * bindings/js/JSNamedNodesCollection.cpp:
+ * bindings/js/JSNodeFilterCondition.cpp:
+ * bindings/js/JSOptionConstructor.cpp:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ * bindings/js/JSRGBColor.cpp:
+ * bindings/js/JSWorkerContextBase.cpp:
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2009-03-20 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov and Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24324
+
+ Make the minimum timer configurable for different platforms.
+
+ * page/DOMTimer.cpp:
+ (WebCore::DOMTimer::DOMTimer):
+ (WebCore::DOMTimer::fired):
+ * page/DOMTimer.h:
+ (WebCore::DOMTimer::minTimerInterval):
+ (WebCore::DOMTimer::setMinTimerInterval):
+
+2009-03-20 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22834
+
+ Make sure to consistently match new/delete and fastMalloc/fastFree.
+
+ * css/CSSSelectorList.cpp:
+ (WebCore::CSSSelectorList::adoptSelectorVector):
+ (WebCore::CSSSelectorList::deleteSelectors):
+
+2009-03-20 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=23739
+ <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::percentHeightDescendants): Added this accessor.
+ * rendering/RenderBlock.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows): Extended the check for
+ children that flex to include other descendants with percent height
+ which is relative to the cell.
+
+2009-03-20 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24706
+ Remove ScriptExecutionContext::encoding() since Workers do not need it.
+ WorkerContext::encoding() is simply removed, while Document::encoding()
+ made non-virtual and private. Workers use UTF-8 now except when instructed
+ otherwise by http header. Also updated test.
+
+ * dom/Document.h: Made encoding() non-virtual and private.
+ * dom/ScriptExecutionContext.h: removed encoding().
+
+ * workers/Worker.cpp:
+ (WebCore::Worker::Worker):
+ (WebCore::Worker::notifyFinished):
+ * workers/WorkerContext.cpp: removed encoding() implementation.
+ (WebCore::WorkerContext::WorkerContext):
+ (WebCore::WorkerContext::completeURL):
+ * workers/WorkerContext.h: removed encoding()
+ (WebCore::WorkerContext::create):
+ * workers/WorkerContextProxy.h:
+ * workers/WorkerImportScriptsClient.cpp:
+ (WebCore::WorkerImportScriptsClient::didReceiveData):
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::startWorkerContext):
+ * workers/WorkerMessagingProxy.h:
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThreadStartupData::create):
+ (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * workers/WorkerThread.h:
+ In all these, removed storing encoding and 'inheriting' it from the parent.
+ Instead, they are all using UTF-8 now.
+
+2009-03-20 Timothy Hatcher <timothy@apple.com>
+
+ Change how threading exceptions are checked so they are reported
+ by what round they were added. That way WebKit can decided the
+ behavior per-round based on linked-on-or-after checks.
+
+ <rdar://problem/6626741&6648478&6635474&6674079>
+
+ Reviewed by Darin Adler.
+
+ * WebCore.base.exp: Export the new symbols.
+ * bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
+ * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
+ * platform/ThreadCheck.h:
+ * platform/mac/ThreadCheck.mm:
+ (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read.
+ (WebCore::setDefaultThreadViolationBehavior): Take a round argument.
+ (WebCore::reportThreadViolation): Ditto.
+ (WebCoreReportThreadViolation): Ditto.
+
+2009-03-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixed up an out-of-date comment.
+
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customPut):
+
+2009-03-20 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
+ (r35318): A press release at pfizer.com does not display correctly
+ - and corresponding -
+ <rdar://problem/6680073>
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::invalidateContainerPrefWidths):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::markContainingBlocksForLayout):
+
+2009-03-20 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ maxDeepOffset is confusing and should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=24586
+
+ Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
+ Add first/lastDeepEditingPositionForNode Position creation functions
+ and deploy them to places we used to call maxDeepOffset.
+
+ Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
+ Add a new Position::atFirst/atLastEditingPositionForNode() and use these
+ to replace a few more callers for maxDeepOffset()
+
+ Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)
+
+ "Editing positions" are confusing because they have one
+ of two behaviors, depending on if the container node is ignored
+ by editing (if editingIgnoresContent(node) returns true) or not.
+ Positions referring to nodes ignored by editing are
+ neighbor-relative (they are before or after the node) where as
+ positions reffering to other nodes are container-relative
+ (they are between two child nodes of the container, identified
+ by the offset() member). I will be fixing this confusion in
+ future patches. These renames hopefully make the current behavior clearer.
+
+ * dom/Position.cpp:
+ (WebCore::Position::previous):
+ (WebCore::Position::next):
+ (WebCore::Position::atFirstEditingPositionForNode):
+ (WebCore::Position::atLastEditingPositionForNode):
+ (WebCore::Position::atStartOfTree):
+ (WebCore::Position::atEndOfTree):
+ (WebCore::Position::previousCharacterPosition):
+ (WebCore::Position::nextCharacterPosition):
+ (WebCore::Position::upstream):
+ (WebCore::Position::isCandidate):
+ (WebCore::firstDeepEditingPositionForNode):
+ (WebCore::lastDeepEditingPositionForNode):
+ * dom/Position.h:
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::operator Position):
+ (WebCore::PositionIterator::increment):
+ (WebCore::PositionIterator::decrement):
+ (WebCore::PositionIterator::atEnd):
+ (WebCore::PositionIterator::atEndOfNode):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::isTableCellEmpty):
+ (WebCore::DeleteSelectionCommand::removeNode):
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+ * editing/Editor.cpp:
+ (WebCore::Editor::advanceToNextMisspelling):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::previous):
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::left):
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::right):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::selectionFromContentsOfNode):
+ (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
+ * editing/htmlediting.cpp:
+ (WebCore::nextVisuallyDistinctCandidate):
+ (WebCore::previousVisuallyDistinctCandidate):
+ (WebCore::firstEditablePositionAfterPositionInRoot):
+ (WebCore::lastEditablePositionBeforePositionInRoot):
+ (WebCore::lastOffsetForEditing):
+ (WebCore::isFirstPositionAfterTable):
+ (WebCore::isLastPositionBeforeTable):
+ (WebCore::positionBeforeNode):
+ (WebCore::positionAfterNode):
+ (WebCore::enclosingEmptyListItem):
+ (WebCore::caretMaxOffset):
+ * editing/htmlediting.h:
+ * editing/visible_units.cpp:
+ (WebCore::renderedAsNonInlineTableOrHR):
+ (WebCore::startOfParagraph):
+ (WebCore::endOfParagraph):
+ (WebCore::startOfEditableContent):
+ (WebCore::endOfEditableContent):
+ * page/AccessibilityObject.cpp:
+ (WebCore::endOfStyleRange):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::visiblePositionRange):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionForPoint):
+
+2009-03-20 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24689
+ Add (upstream) V8 bindings for Workers. Mostly style cleaning.
+
+ * bindings/v8/WorkerContextExecutionProxy.cpp: Added.
+ * bindings/v8/WorkerContextExecutionProxy.h: Added.
+ * bindings/v8/WorkerScriptController.cpp: Added.
+ * bindings/v8/WorkerScriptController.h: Added.
+ * bindings/v8/V8Index.h: Added. This is just a wrapper for v8_index.h, like V8Proxy.h
+ * bindings/v8/V8Proxy.h: Added domObjectMap() function that wraps GetDOMObjectMap().
+ * bindings/v8/V8WorkerContextEventListener.cpp:
+ (WebCore::V8WorkerContextEventListener::callListenerFunction): TrackEvent() renamed trackEvent()
+
+2009-03-20 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix for LayoutTests/fast/canvas/canvas-text-alignment.html
+ on chromium/skia. The problem was that the gradient matrix
+ for text was being applied twice. Fixed by reverting some of
+ https://bugs.webkit.org/show_bug.cgi?id=23957, so that skiaDrawText
+ is no longer responsible for measuring the text and scaling up
+ the gradient matrix. Instead, the text bounding box is passed
+ in from SVGPaintServerGradient. I didn't make this change for CG,
+ since it uses a different method (the gradient is drawn using the
+ text as a pre-rendered mask).
+ https://bugs.webkit.org/show_bug.cgi?id=24687
+
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::skiaDrawText):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::SVGPaintServerGradient::setup):
+
+2009-03-20 Xan Lopez <xlopez@igalia.com>
+
+ Rubber-stamped by Holger Freyther.
+
+ There seems to be some rounding error in cairo (or in how we use
+ cairo) with some fonts, like DejaVu Sans Mono, which makes cairo
+ report a height smaller than ascent + descent, which is wrong and
+ confuses WebCore's layout system. Workaround this while we figure
+ out what's going on.
+
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformInit):
+
+2009-03-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24122
+ <rdar://problem/6674179>
+ REGRESSION: DOM Range extractContents/deleteContents failures seen on Moxiecode tests
+
+ Test: fast/dom/Range/deleted-range-endpoints.html
+
+ * dom/Range.cpp: (WebCore::Range::processContents): Set the final range in accordance
+ to the specification.
+
+2009-03-19 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)
+
+ If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
+ that object would never be updated.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateWidgets):
+ Factor the widget updating code out into this method. Return true if the update set is empty.
+
+ (WebCore::FrameView::performPostLayoutTasks):
+ Loop over the update set multiple times until all widgets have been updated or until we reach the cap.
+
+ * page/FrameView.h:
+
+2009-03-18 Timothy Hatcher <timothy@apple.com>
+
+ Make the defered data loading timer honor the Page's scheduled runloop pairs.
+ Introduces a new RunLoopTimer class that has an API mimicking Timer but
+ allows it to be scheduled with one or more SchedulePairs.
+
+ <rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers
+
+ Reviewed by Darin Adler.
+
+ * WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef.
+ (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on
+ Mac platforms also schedule with the Page's SchedulePairs.
+ (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer().
+ (WebCore::MainResourceLoader::setDefersLoading): Ditto.
+ * loader/MainResourceLoader.h:
+ * platform/cf/RunLoopTimerCF.cpp: Added.
+ (WebCore::RunLoopTimerBase::~RunLoopTimerBase):
+ (WebCore::timerFired):
+ (WebCore::RunLoopTimerBase::start):
+ (WebCore::RunLoopTimerBase::schedule):
+ (WebCore::RunLoopTimerBase::stop):
+ (WebCore::RunLoopTimerBase::isActive):
+ * platform/RunLoopTimer.h: Added.
+ (WebCore::RunLoopTimerBase::RunLoopTimerBase):
+ (WebCore::RunLoopTimerBase::startRepeating):
+ (WebCore::RunLoopTimerBase::startOneShot):
+ (WebCore::RunLoopTimer::RunLoopTimer):
+ (WebCore::RunLoopTimer::fired):
+
+2009-03-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24702
+ Upstream miscellaneous bindings changes.
+
+ * bindings/v8/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
+ * bindings/v8/ScriptCallStack.h: Added an extra include.
+
+2009-03-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24686
+
+ When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
+ we need to compare the computed z-offset with the depth-test z-offset before
+ deciding that such a RenderLayer was hit. This fixes an issue, tested by the
+ 3d-point-mapping-overlapping.html test, where the child of a transformed element
+ is found by hit testing, even when some other element with greater Z overlaps
+ them both.
+
+ Improved the code by adding a utility method, isHitCandidate(), which computes and tests
+ z-depth when necessary.
+
+ Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html
+ transforms/3d/point-mapping/3d-point-mapping-overlapping.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::isHitCandidate):
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-19 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24456
+ Split ColorChromium.cpp into Mac & Windows variants.
+ Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
+ ultimately need to take a different approach. For now, createCGColor()
+ is copied from ColorMac.mm.
+
+ No observable change in behavior, so no test.
+
+ * platform/graphics/chromium/ColorChromium.cpp:
+ (WebCore::focusRingColor):
+ * platform/graphics/chromium/ColorChromiumMac.mm: Added.
+
+2009-03-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24675
+ Unforking frontend: add custom InspectorController methods
+ implementation.
+
+ * bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.
+
+2009-03-19 Jay Campan <jcampan@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24625
+ Adding an accessor to the currently selected index in the PopupMenuChromium.
+ This is required for implementing the deletion of an autocomplete entry in Chromium.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::selectedIndex):
+ * platform/chromium/PopupMenuChromium.h:
+
+2009-03-19 Evan Stade <estade@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24526
+ Improve windows skia text stroking.
+
+ Test: LayoutTests/svg/custom/struct-use-09-b.svg
+
+ * platform/graphics/skia/SkiaFontWin.cpp: Close the path representing
+ each font glyph polygon, rather than only closing the path once per
+ letter. This fixes stroking for letters with multiple polygons, such
+ as 'A' or 'D'.
+ (WebCore::getPathForGlyph):
+ (WebCore::skiaDrawText):
+
+2009-03-19 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.
+
+ Removed dead code for distinguishing between Widget and PluginView in the Qt port.
+
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget): Removed incorrect isNPAPI check.
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView): Removed m_isNPAPIPlugin variable.
+ * plugins/PluginView.h: Removed setter/getter.
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::init): Removed call to setIsNPAPIPlugin.
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::init): Ditto.
+
+2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
+ <https://bugs.webkit.org/show_bug.cgi?id=24596>
+ <rdar://problem/6686493>
+
+ JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
+ JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
+ set twice, once to the value that is illegal to access, and then to undefined
+ This causes an assertion failure in property access caching code.
+
+ The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().
+
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customGetOwnPropertySlot):
+
+2009-03-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24676
+ Simple cross-origin requests shouldn't dispatch upload progress events
+
+ Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html
+
+ * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment
+ explaining the somewhat unexpected behavior of this function.
+
+ * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
+ * xml/XMLHttpRequestUpload.h:
+ Report whether there are any event listeners registered.
+
+ * xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag.
+ (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto.
+ (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto.
+ (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be
+ non-empty for POST requests.
+ (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag.
+ (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto.
+ (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed.
+ (WebCore::XMLHttpRequest::networkError): Ditto.
+ (WebCore::XMLHttpRequest::abortError): Ditto.
+ (WebCore::XMLHttpRequest::didSendData): Ditto.
+
+2009-03-18 Marc-Antoine Ruel <maruel@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24398
+ Fix a crash when loading a svg file in Chromium's test_shell and
+ then reloading the page.
+
+ * history/BackForwardListChromium.cpp:
+ (WebCore::BackForwardList::BackForwardList):
+ (WebCore::BackForwardList::close):
+
+2009-03-18 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Fix for <rdar://problem/6685235>
+ <video> element poster cannot be set dynamically if not originally set up in HTML
+
+ Allocate the media engine immediately so the plug-in proxy is available for
+ scripting right away.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::MediaPlayer):
+
+2009-03-18 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
+ Popup menu appears at the wrong location on page at http://
+ www.signonsandiego.com/
+
+ This was a regression from http://trac.webkit.org/changeset/40769,
+ which changed the base class of RenderInline to
+ RenderBoxModelObject rather than RenderBox.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::offsetParent): offsetParent should return a
+ RenderBoxModelObject rather than just a RenderBox, which is more
+ restrictive.
+
+2009-03-18 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6504776>
+ CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...
+
+ Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.
+
+ * loader/NetscapePlugInStreamLoader.cpp:
+ (WebCore::NetscapePlugInStreamLoader::didCancel):
+
+2009-03-18 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24664
+ Upstreaming v8 collection.h
+
+ No change in behavior, so no test.
+
+ * bindings/v8/V8Collection.h: Added.
+
+2009-03-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
+ REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
+ <rdar://problem/6589657>
+
+ Match the CSSOM spec for getClientRects and getBoundingClientRect by
+ returning a 0x0 rect at the correct top/left position for empty inline
+ boxes.
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::absoluteQuads):
+
+2009-03-18 David Levin <levin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Match the changes done for windows in the bug
+ https://bugs.webkit.org/show_bug.cgi?id=24530.
+
+ No change in behavior, so no test.
+
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
+
+2009-03-18 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ Added support for SVG's stroked texts to Qt.
+
+ [Qt] SVGs stroked text support missing
+ https://bugs.webkit.org/show_bug.cgi?id=24262
+
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::Font::drawComplexText):
+
+2009-03-18 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix fast/encoding/char-decoding.html with recent ICU.
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
+ as newer versions of ICU use GB18030 as the canonical name.
+
+2009-03-17 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24662
+ Chromium build fixes.
+
+ Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
+ the invalid implementation of ScriptCallStack.
+
+ No change in behavior, so no test.
+
+ * bindings/v8/ScriptCallStack.h:
+ (WebCore::ScriptCallStack::state):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::drawRect):
+
+2009-03-17 David Carson <dacarson@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Add anchor elements to the simple style sheet so that applications that
+ are using WebKit just for simple text and links will also take advantage
+ of the fast path.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::elementCanUseSimpleDefaultStyle):
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6687005> Need support for new move-left/right selectors.
+
+ * editing/EditorCommand.cpp:
+ (WebCore::executeMoveToLeftEndOfLine): Added.
+ (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added.
+ (WebCore::executeMoveToRightEndOfLine): Added.
+ (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added.
+ Added command entries for the functions above.
+
+2009-03-17 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ Put the padding inside scrollbars on textareas.
+ https://bugs.webkit.org/show_bug.cgi?id=24370
+
+ Put the padding inside the scrollbars on textareas. This is done by moving the
+ overflow from the shadowNode to the RenderTextControlMultiline. As a result,
+ all of the scroll handing methods that RenderTextControl overrides can be moved
+ down into RenderTextControlSingleLine since RenderTextControlMultiline can now
+ just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
+ no longer need a custom layout method since the shadowNode can now just size
+ like a regular DIV.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ (WebCore::RenderTextControl::selection):
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::hitInnerTextElement):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::nodeAtPoint):
+ (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
+ * rendering/RenderTextControlMultiLine.h:
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::styleDidChange):
+ (WebCore::RenderTextControlSingleLine::autoscroll):
+ (WebCore::RenderTextControlSingleLine::scrollWidth):
+ (WebCore::RenderTextControlSingleLine::scrollHeight):
+ (WebCore::RenderTextControlSingleLine::scrollLeft):
+ (WebCore::RenderTextControlSingleLine::scrollTop):
+ (WebCore::RenderTextControlSingleLine::setScrollLeft):
+ (WebCore::RenderTextControlSingleLine::setScrollTop):
+ (WebCore::RenderTextControlSingleLine::scroll):
+ * rendering/RenderTextControlSingleLine.h:
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
+ (WebCore::RenderTextControlInnerBlock::positionForPoint):
+ (WebCore::TextControlInnerTextElement::createRenderer):
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
+ https://bugs.webkit.org/show_bug.cgi?id=24517
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
+ determining whether to display the delete button involves style and updateRendering
+ also updates style (should probably be named updateStyle, in fact). Not needed to fix
+ this bug, but would have prevented the crash that led to this bug in the first place.
+
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
+ delete button controllers.
+ * editing/Editor.cpp:
+ (WebCore::Editor::rangeForPoint): Ditto.
+
+ * editing/markup.cpp:
+ (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
+ doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
+ This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
+ createMarkup function that's called by innerHTML.
+ (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
+ function. Added a feature where the accumulator will skip a node. Moved arguments
+ that don't change during recursion into an object. This function still is a bit
+ inefficient, since it creates a new HashMap at every level as it recurses, but for now
+ I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
+ for consistency and clarity.
+ (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
+ Instead of calling disable/enable on the delete button controller's container element,
+ pass it in to the markup accumulator as a node to skip.
+
+2009-03-17 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24651
+ Skia does not always render text fill/stroke pattern/gradient/color correctly
+
+ Changes Skia's font rendering to only render gradient/pattern if current
+ color space indicates the gradient/pattern should be used.
+ This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .
+
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::strokeColorSpace):
+ (WebCore::GraphicsContext::fillColorSpace):
+ * platform/graphics/GraphicsContext.h:
+ (WebCore::):
+ * platform/graphics/GraphicsContextPrivate.h:
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::paintSkiaText):
+
+2009-03-17 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
+ <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
+
+ Test: editing/inserting/6633727.html
+
+ This changes does a few things:
+ 1) Renames pos to insertionPosition.
+ 2) Eliminates "startNode". It doesn't work well to consider the node separately from the insertionPosition.
+ The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
+ 3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
+ representation of the insertionPosition, so all ancestor nodes are correctly included.
+
+ * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
+
+2009-03-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Kevin Ollivier.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24115
+ Introduce platform independent stubs for plugins.
+
+ * plugins/PluginDataNone.cpp: Copied from WebCore/plugins/wx/PluginDataWx.cpp.
+ * plugins/PluginPackageNone.cpp: Copied from WebCore/plugins/wx/PluginPackageWx.cpp.
+ * plugins/PluginViewNone.cpp: Copied from WebCore/plugins/wx/PluginViewWx.cpp.
+ * plugins/wx/PluginDataWx.cpp: Removed.
+ * plugins/wx/PluginPackageWx.cpp: Removed.
+ * plugins/wx/PluginViewWx.cpp: Removed.
+ * webcore-wx.bkl:
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ Earlier version reviewed by Adele Peterson.
+
+ Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
+ or push an <input type=button> or <button> causes the page to scroll down.
+
+ Would be best to add a regression test for Windows eventually; tested that this has
+ no effect on the Mac OS X platform.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting.
+ Use the code that calls the base class's defaultEventHandler early only in the cases
+ where it's needed: keydown and keypress events in text fields. In other cases, do the
+ more typical thing and call the default handler only at the end of the function.
+ This function already had code to make sure the keypress event for space never gets
+ through, but it was running too late since the scrolling code was moved into the
+ base class default event handler.
+
+2009-03-17 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24632
+
+ Fix repaint issues when composited layers come and go (only applies
+ when ACCELERATED_COMPOSITING is turned on).
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::mustOverlayCompositedLayers):
+ (WebCore::RenderLayer::setMustOverlayCompositedLayers):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::RenderLayerBacking):
+ * rendering/RenderLayerBacking.h:
+
+ Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
+ to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
+ when setting this flag.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ When a RenderLayer flips into or out of compositing mode, compute a repaint
+ rect relative to the containerForRepaint, and repaint it.
+
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().
+
+ (WebCore::RenderLayerCompositor::needsToBeComposited):
+ (WebCore::RenderLayerCompositor::requiresCompositingLayer):
+ (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
+ (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
+ * rendering/RenderLayerCompositor.h:
+
+ Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
+ and make it a class static method to match requiresCompositingForAnimation(). Both
+ now take RenderObjects, rathern than RenderLayers.
+
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::hasTransformRelatedProperty):
+ Minor tidyup using convenience methods added in an earlier commit.
+
+2009-03-17 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24396
+
+ * config.h:
+ Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some
+ comments to make the #ifdefs more readable.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::computedTransform):
+ Add a comment to mention that we don't flatten the matrix.
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::transform_3dMediaFeatureEval):
+ Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering
+ is supported.
+
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::animateTransform):
+ No need for the #ifdef here. If we don't support 3d, we will have already flattened
+ the matrix.
+
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::TransformationMatrix::makeAffine):
+ * platform/graphics/transforms/TransformationMatrix.h:
+ New method to convert the matrix to an affine matrix by throwing a way the non-affine
+ parts.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::currentTransform):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateLayerTransform):
+ If 3d rendering is not supported, convert the matrix to an affine matrix
+ which can be rendered, and used for hit testing.
+
+ * rendering/RenderLayerCompositor.cpp:
+ Change the name of the exported symbol that webkitdirs.pm uses to know if
+ 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::transformFromContainer):
+ Only take perspective into account if 3d rendering is supported.
+
+ * rendering/RenderObject.h:
+ (WebCore::makeMatrixRenderable):
+ Utility method that flattens a matrix if 3d rendering is not supported.
+
+2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Fix typo after mouse wheel changes.
+
+ * platform/wx/MouseWheelEventWx.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ Fix crash seen right away when running run-webkit-tests.
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring.
+ Also tweaked formatting a bit.
+
+2009-03-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
+ it doesn't need to zero it out before calling.
+
+ * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.
+
+2009-03-17 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - WebCore part of adding a mechanism for controlling the caching of
+ responses through WebFrameLoaderClient
+
+ Mac already has such a mechanism, and this adds one for CFNetwork ports.
+
+ * WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h
+ and ResourceLoaderCFNet.cpp.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an
+ implementation that always returns true.
+
+ * loader/FrameLoaderClient.h: Declared shouldCacheResponse().
+
+ * loader/ResourceLoader.h: Ditto.
+
+ * loader/cf/ResourceLoaderCFNet.cpp: Added.
+ (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to
+ FrameLoaderClient::shouldCacheResponse().
+
+ * platform/network/ResourceHandleClient.h:
+ (WebCore::ResourceHandleClient::shouldCacheResponse): Added an
+ implementation that always returns true.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::willCacheResponse): Added a call to
+ ResourceHandleClient::shouldCacheResponse(). If the client returns
+ false, return 0, which will prevent CFNetwork from caching the response.
+
+2009-03-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13287
+ Cannot change SELECT to a dynamically created option
+
+ Tests: fast/forms/add-and-remove-option.html
+ fast/forms/add-remove-option-modification-event.html
+ fast/forms/add-selected-option.html
+ fast/forms/select-cache-desynchronization.html
+
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when
+ dispatching DOMSubtreeModified again, but the version should be incremented for event
+ listeners to have an up to date view of the DOM.
+ (WebCore::dispatchChildRemovalEvents): Ditto.
+
+ * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree):
+ Make sure that the select element knows about its new selected option.
+
+ * html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(),
+ because DOM also needs to be updated for forms that are not in document yet. Similar
+ problems exist for node removing, but removedFromTree() is called at a wrong time, so
+ those problems cannot be fixed without deeper refactoring.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it
+ doesn't make sense to keep the anchor after programmatically changing the selection, and
+ keeping it was causing a failure in fast/forms/listbox-selection.html.
+
+ * html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called
+ base class versions.
+
+2009-03-17 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes
+
+ Reviewed by Darin Adler.
+
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.
+
+2009-03-16 David Hyatt <hyatt@apple.com>
+
+ <rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/
+
+ Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
+ layers that don't paint themselves. This is done by adding a new enclosingSelfPaintingLayer method
+ so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
+ themselves.
+
+ Reviewed by Darin Adler.
+
+ Added fast/block/float/overlapping-floats-with-overflow-hidden.html
+
+ * WebCore.base.exp:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addOverhangingFloats):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::enclosingSelfPaintingLayer):
+ * rendering/RenderObject.h:
+
+2009-03-17 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24592
+ [GTK] Crash in FcPatternHash
+
+ Style fixes.
+
+ * platform/graphics/gtk/FontPlatformDataGtk.cpp:
+ (WebCore::FontPlatformData::operator=):
+ * platform/graphics/gtk/FontPlatformDataPango.cpp:
+
+2009-03-17 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24592
+ [GTK] Crash in FcPatternHash
+
+ Sanitize memory management in pango fonts.
+
+ Release memory allocated by FontPlatformDataPango in its own
+ destructor instead of doing it from other classes, and add copy
+ constructor and '=' operator to be able to track referenced
+ objects properly.
+
+ * platform/graphics/gtk/FontPlatformDataPango.cpp:
+ (WebCore::FontPlatformData::~FontPlatformData):
+ (WebCore::FontPlatformData::operator=):
+ (WebCore::FontPlatformData::FontPlatformData):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+
+2009-03-17 Darin Adler <darin@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
+ seen with inspector, which uses adoptNode
+ https://bugs.webkit.org/show_bug.cgi?id=24624
+ rdar://problem/6422850
+
+ Test: fast/dom/HTMLImageElement/image-load-cross-document.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document): Removed m_imageLoadEventTimer.
+ (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and
+ m_imageLoadEventDispatchingList.
+ (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents
+ instead of dispatchImageLoadEventsNow.
+
+ * dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon,
+ dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList,
+ m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.
+
+ * loader/ImageLoader.cpp:
+ (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender
+ object used privately as the target of the load event timer.
+ (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent
+ rather than Document::removeImage.
+ (WebCore::ImageLoader::setImage): Use m_element directly, not element().
+ (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable
+ document instead of doc.
+ (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon
+ rather than Document::dispatchImageLoadEventSoon.
+ (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic
+ about when load events can be dispatched so that dispatchLoadEvent only has to
+ have the specific part for each derived class. This includes a check that the
+ document is attached, which used to be handled by having documents empty out the
+ image load event vectors in the detach function.
+ (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate
+ function on the ImageLoadEventSender, which avoids the need to have that class be
+ public in the ImageLoader header.
+ (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that
+ was previously in the Document constructor.
+ (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that
+ was previously in Document::dispatchImageLoadEventSoon.
+ (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was
+ previously in Document::removeImage.
+ (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code
+ that was previously in Document::dispatchImageLoadEventsNow.
+ (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.
+
+ * loader/ImageLoader.h: Improved comments. Made the virtual functions private
+ or protected rather than public. Added static dispatchPendingLoadEvents function
+ for use by Document and private dispatchPendingLoadEvent function for use by
+ ImageLoadEventSender. Made setLoadingImage private and eliminated
+ setHaveFiredLoadEvent since that can all be done inside the class without any
+ member functions.
+
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a
+ load event already fired and whether image() is 0. These are now both base class
+ responsibilities.
+ * svg/SVGImageLoader.cpp:
+ (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
+ * wml/WMLImageLoader.cpp:
+ (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.
+
+2009-03-17 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24623
+ Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
+ dependencies.
+
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
+ * bindings/js/ScriptFunctionCall.h:
+ * bindings/js/ScriptObjectQuarantine.cpp:
+ (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
+ * bindings/js/ScriptObjectQuarantine.h:
+ * bindings/js/ScriptValue.cpp:
+ (WebCore::ScriptValue::isEqual): Added.
+ * bindings/js/ScriptValue.h:
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::ConsoleMessage::addToConsole): Added.
+ (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
+ * inspector/ConsoleMessage.h:
+ (WebCore::ConsoleMessage::incrementCount): Added.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole.
+ (WebCore::InspectorController::populateScriptObjects): Ditto.
+ * inspector/InspectorController.h:
+
+2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Mark Rowe.
+
+ Get BUILDING_ON_* defines from Platform.h.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24630
+
+ * WebCorePrefix.h:
+
+2009-03-16 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24592
+ [GTK] Crash in FcPatternHash
+
+ Sanitize memory management in gtk fonts.
+
+ Release memory allocated by FontPlatformDataGtk in its own
+ destructor instead of doing it from other classes, and add copy
+ constructor and '=' operator to be able to track referenced
+ objects properly.
+
+ * platform/graphics/gtk/FontPlatformData.h:
+ * platform/graphics/gtk/FontPlatformDataGtk.cpp:
+ (WebCore::FontPlatformData::operator=):
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::~FontPlatformData):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformDestroy):
+
+2009-03-17 Ariya Hidayat <ariya.hidayat@nokia.com>
+
+ Build fix for Qt < 4.5.
+
+ As reported by Yael Aharon <yael.aharon@nokia.com>
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::drawLine):
+
+2009-03-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24614
+ Access control checks are different in cached and uncached cases
+
+ Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html
+
+ * loader/CrossOriginAccessControl.cpp:
+ (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method
+ check for use in both cached and uncached cases. In cached case, an old definition that
+ omitted HEAD was still used.
+ (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an
+ allowed value. This is needed in all call sites. Also changed to compare MIME type, not
+ content type.
+ (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.
+
+ * loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.
+
+ * loader/CrossOriginPreflightResultCache.cpp:
+ (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
+ (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
+ Use the new checks for simple method and header.
+
+2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24638
+ [GTK] HTML5 media tags do not work
+
+ Add a repaint-requested signal to the video sink, and use it to
+ call MediaPlayerPrivate::repaint, so that the video actually
+ plays.
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::mediaPlayerPrivateRepaintCallback):
+ (WebCore::MediaPlayerPrivate::createGSTPlayBin):
+ * platform/graphics/gtk/VideoSinkGStreamer.cpp:
+ (webkit_video_sink_idle_func):
+ (webkit_video_sink_render):
+ (webkit_video_sink_class_init):
+
+2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24638
+ [GTK] HTML5 media tags do not work
+
+ Work-around the fact that gst_element_query_duration returns true even
+ though it is unable to figure out the duration when in stream (push)
+ mode.
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivate::duration):
+
+2009-03-16 Darin Adler <darin@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ <rdar://problem/6642742> Top Sites malfunction when switching text zoom mode
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is
+ currently showing a non-HTML view.
+
+2009-03-16 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 24629: moving forward or backward a paragraph fails at edge of document
+ https://bugs.webkit.org/show_bug.cgi?id=24629
+ rdar://problem/6544413
+
+ Test: editing/selection/move-paragraph-document-edges.html
+
+ * editing/visible_units.cpp:
+ (WebCore::previousParagraphPosition): Use the last result from
+ previousLinePosition rather than going all the way back to what was originally
+ passed in when we hit exception cases like null or not moving. This correctly
+ inherits the behavior of previousLinePosition when we are in a paragraph at the
+ edge of a document.
+ (WebCore::nextParagraphPosition): Ditto.
+
+2009-03-16 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
+ https://bugs.webkit.org/show_bug.cgi?id=24619
+
+ * rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
+ * rendering/RenderView.h: Ditto.
+
+2009-03-16 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24368
+ DOM scroll events should be based off the actual number of wheel
+ ticks, not off the number of lines scrolled. This matches IE.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchWheelEvent):
+ * dom/WheelEvent.cpp:
+ (WebCore::WheelEvent::WheelEvent):
+ * dom/WheelEvent.h:
+ (WebCore::WheelEvent::create):
+ * platform/PlatformWheelEvent.h:
+ (WebCore::PlatformWheelEvent::wheelTicksX):
+ (WebCore::PlatformWheelEvent::wheelTicksY):
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/mac/WheelEventMac.mm:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/qt/WheelEventQt.cpp:
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/wx/MouseWheelEventWx.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-16 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Clean up a few issues in the Animation code:
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ Whitespace
+
+ (WebCore::AnimationBase::willNeedService):
+ Don't round to float, use std::max
+
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::startTimeResponse):
+ Fix erroneously copied line to null out m_lastResponseWaiter.
+
+2009-03-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=13632
+
+ Overflow scrolling needs to account for the bottom/right padding on the object itself as well
+ as for bottom/right margins on children.
+
+ Existing tests cover this.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+
+2009-03-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for <rdar://problem/6320555>
+ Add an upper limit for setting HTMLSelectElement.length.
+
+ Test: fast/forms/select-max-length.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setOption):
+ (WebCore::HTMLSelectElement::setLength):
+
+2009-03-16 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/6686721> Media document crash in 64-bit WebKit
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when
+ rendering inline with old versions of QuickTime, so don't look for it when we are in a
+ media document.
+
+2009-03-16 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24590
+ Refactor InspectorDOMStorageResource to use ScriptFunctionCall.
+
+ * bindings/js/ScriptFunctionCall.cpp:
+ (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
+ * bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
+ * bindings/js/ScriptObjectQuarantine.cpp:
+ (WebCore::getQuarantinedScriptObject): Added Storage helper.
+ * bindings/js/ScriptObjectQuarantine.h: Ditto.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::populateScriptObjects): Changed to use bind method.
+ (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method.
+ (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
+ * inspector/InspectorController.h: Removed add/remove methods for DOM storage.
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+ (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added.
+ (WebCore::InspectorDOMStorageResource::bind): Added.
+ (WebCore::InspectorDOMStorageResource::unbind): Added.
+ * inspector/InspectorDOMStorageResource.h:
+
+2009-03-16 Mike Belshe <mike@belse.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24580
+ Fix query() to match KURL behavior, this time with the code that
+ compiles.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURL::query): Fix copy/paste mistake.
+
+2009-03-16 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21752
+ REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it
+
+ Test: fast/dom/Window/window-early-properties-xhr.html
+
+ For some transitions, the Window object is not replaced, but Document is. When this happened,
+ window.document property was updated, but references to Document kept in cached constructors
+ were not.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ (WebCore::JSAudioConstructor::document):
+ (WebCore::JSAudioConstructor::mark):
+ * bindings/js/JSAudioConstructor.h:
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ (WebCore::JSImageConstructor::document):
+ (WebCore::JSImageConstructor::mark):
+ * bindings/js/JSImageConstructor.h:
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
+ (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
+ (WebCore::JSMessageChannelConstructor::mark):
+ * bindings/js/JSMessageChannelConstructor.h:
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ (WebCore::JSOptionConstructor::document):
+ (WebCore::JSOptionConstructor::mark):
+ * bindings/js/JSOptionConstructor.h:
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
+ (WebCore::JSXMLHttpRequestConstructor::mark):
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ Changed cached constructors to keep a reference to Window, not Document.
+
+2009-03-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24549
+ Impose a limit on Access-Control-Max-Age value
+
+ * loader/CrossOriginPreflightResultCache.cpp:
+ (WebCore::CrossOriginPreflightResultCacheItem::parse):
+
+2009-03-15 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ <rdar://problem/6668875> Normalize Geolocation results
+
+ * platform/mac/GeolocationServiceMac.mm:
+ (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
+
+2009-03-15 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Update ::toString format as suggested by Darin Adler.
+
+ * page/Geoposition.cpp:
+ (WebCore::Geoposition::toString):
+
+2009-03-15 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
+
+ Reviewed by Darin Adler.
+
+ Yet another case where we would trigger extended encoding loading needlessly.
+
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::encodingForFormSubmission):
+
+2009-03-15 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix: no review.
+
+ * rendering/style/ContentData.h:
+
+2009-03-15 David Kilzer <ddkilzer@apple.com>
+
+ Bug 24542: Improve ContentData encapsulation
+
+ <https://bugs.webkit.org/show_bug.cgi?id=24542>
+
+ Reviewed by Simon Fraser.
+
+ No tests since there is no change in behavior.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createObject): Used getter methods
+ instead of data members on ContentData class. Used isImage()
+ convenience method.
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
+
+ * rendering/style/ContentData.cpp:
+ (WebCore::ContentData::clear): Extracted code into
+ deleteContent() method.
+ (WebCore::ContentData::dataEquivalent): Added. Extracted code
+ from StyleRareNonInheritedData::contentDataEquivalent().
+ (WebCore::ContentData::deleteContent): Added. Used by setter
+ methods.
+ * rendering/style/ContentData.h: Made m_type, m_content and
+ m_next private.
+ (WebCore::ContentData::isCounter): Added.
+ (WebCore::ContentData::isImage): Added.
+ (WebCore::ContentData::isNone): Added.
+ (WebCore::ContentData::isText): Added.
+ (WebCore::ContentData::type): Added.
+ (WebCore::ContentData::dataEquivalent): Added.
+ (WebCore::ContentData::image): Added.
+ (WebCore::ContentData::setImage): Added.
+ (WebCore::ContentData::text): Added.
+ (WebCore::ContentData::setText): Added.
+ (WebCore::ContentData::counter): Added.
+ (WebCore::ContentData::setCounter): Added.
+ (WebCore::ContentData::next): Added.
+ (WebCore::ContentData::setNext): Added.
+
+ * rendering/style/CounterContent.h:
+ (WebCore::operator!=): Removed.
+ (WebCore::operator==): Renamed operator!=() and reversed its
+ logic after extracting code from
+ StyleRareNonInheritedData::contentDataEquivalent() to create
+ ContentData::dataEquivalent().
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::setContent): Used new getters and setters
+ on ContentData class. Changed first argument from a StringImpl*
+ to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::setContent): Updated declaration.
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::contentDataEquivalent):
+ Extracted most logic in while() loop into
+ ContentData::dataEquivalent().
+
+2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24602
+ [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
+
+ Reintroduce the URI into the soup message after having set it in
+ the KURL, on redirects, to make sure it is properly encoded. This
+ fixes bad request problems when servers give bad URIs on their
+ response's Location header.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::restartedCallback):
+
+2009-03-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19737
+ No cursor and paste not enabled right clicking text field/area
+
+ Test: fast/events/right-click-focus.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ (WebCore::EventHandler::handleMousePressEvent):
+ Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
+
+2009-03-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23949
+ HTMLSelectElement is in inconsistent state when handling mutation events
+
+ Test: fast/forms/mutation-event-recalc.html
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertBefore):
+ (WebCore::ContainerNode::appendChild):
+ Call childrenChanged() before dispatching modification events, not after.
+
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::insertBefore):
+ (WebCore::HTMLOptGroupElement::replaceChild):
+ (WebCore::HTMLOptGroupElement::removeChild):
+ (WebCore::HTMLOptGroupElement::appendChild):
+ (WebCore::HTMLOptGroupElement::removeChildren):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::add):
+ (WebCore::HTMLSelectElement::remove):
+ (WebCore::HTMLSelectElement::insertBefore):
+ (WebCore::HTMLSelectElement::replaceChild):
+ (WebCore::HTMLSelectElement::removeChild):
+ (WebCore::HTMLSelectElement::appendChild):
+ (WebCore::HTMLSelectElement::removeChildren):
+ Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
+ were already dispatched.
+
+2009-03-14 Greg Bolsinga <bolsinga@apple.com>
+
+ <rdar://problem/6683465>
+
+ Geolocation has to be able to handle NULL Frames.
+
+ Reviewed by Mark Rowe
+
+2009-03-14 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Geoposition::toString was missing the Coordinates after the update.
+
+ * page/Geoposition.cpp:
+ (WebCore::Geoposition::toString):
+
+2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ [Gtk] Build fix - pass a Coordinate to Geoposition::create
+ https://bugs.webkit.org/show_bug.cgi?id=24603
+
+ Gtk build fix per r41650
+ https://bugs.webkit.org/show_bug.cgi?id=24506
+ Geolocation in Safari differs from the spec, no Coordinates attribute on Position
+
+ Pass a Coordinate to Geoposition::create.
+
+ * platform/gtk/GeolocationServiceGtk.cpp:
+ (WebCore::GeolocationServiceGtk::updatePosition):
+
+2009-03-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24545
+ Make cross-site XHR simple request definition match current spec draft
+
+ Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html
+ http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
+
+ * loader/CrossOriginAccessControl.cpp:
+ (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language.
+ (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those
+ that could be sent via form submission.
+
+2009-03-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15172
+ object fallback - empty string for first argument of setAttributeNS does not work like null
+
+ https://bugs.webkit.org/show_bug.cgi?id=24548
+ createElementNS("", name) should create an element in null namespace
+
+ Tests: fast/dom/createElementNS-empty-namespace.html
+ fast/dom/setAttributeNS-empty-namespace.html
+
+ * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
+ Convert empty namespaces to null.
+
+2009-03-13 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Take advantage of the ability of recent versions of Xcode to easily switch the active
+ architecture.
+
+ * Configurations/DebugRelease.xcconfig:
+
+2009-03-13 John Abd-El-Malek <jam@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24593
+ Added requestorID so we can track the request to its WebView without using frame (which was removed).
+
+ * platform/network/chromium/ResourceRequest.h:
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::requestorID):
+ (WebCore::ResourceRequest::setRequestorID):
+ (WebCore::ResourceRequest::setTargetType):
+ (WebCore::ResourceRequest::policyURL):
+ (WebCore::ResourceRequest::setPolicyURL):
+ (WebCore::ResourceRequest::requestorPid):
+ (WebCore::ResourceRequest::setRequestorPid):
+
+2009-03-13 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24561
+ Add custom V8 bindings for HTMLElementCanvas, Location.
+
+ * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
+ * bindings/v8/custom/V8LocationCustom.cpp: Added.
+
+2009-03-13 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24584
+
+ Fix transparent text rendering on Chromium. FontChromiumWin
+ was calling beginTransparencyLayer()/endTransparencyLayer(), with
+ a TransparencyWin inside to do GDI ClearType rendering over an
+ opaque background. TransparencyWin does its special sauce
+ in the destructor, but it was being called too late to be used
+ correctly in the layer. Put the special sauce into a new function,
+ composite(), and call that explicitly instead.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
+ * platform/graphics/chromium/TransparencyWin.cpp:
+ (WebCore::TransparencyWin::~TransparencyWin):
+ (WebCore::TransparencyWin::composite):
+ (WebCore::TransparencyWin::init):
+ * platform/graphics/chromium/TransparencyWin.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::):
+
+2009-03-13 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24562
+ Add custom implementation for getCSSCanvasContext to V8 bindings.
+
+ * bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
+
+2009-03-13 Mike Belshe <mike@belse.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24580
+ Fix query() to match KURL behavior.
+
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURL::query): remove extra logic around question mark.
+
+2009-03-13 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
+ https://bugs.webkit.org/show_bug.cgi?id=24474
+
+ Test: platform/mac-snowleopard/accessibility/table-multi-bodies.html
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::cellForColumnAndRow):
+
+2009-03-13 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24589
+ Upstream changes to V8 event listeners (Chromium r11133) in order to
+ fix worker functionality break in Chromium.
+
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::invokeEventHandler):
+ (WebCore::V8AbstractEventListener::handleEvent):
+ * bindings/v8/V8AbstractEventListener.h:
+ * bindings/v8/V8WorkerContextEventListener.cpp:
+ (WebCore::V8WorkerContextEventListener::handleEvent):
+
+2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24524
+ Introduce ScriptObject and ScriptFunctionCall abstractions.
+
+ * GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+ * bindings/js/ScriptFunctionCall.cpp: Added.
+ * bindings/js/ScriptFunctionCall.h: Added.
+ * bindings/js/ScriptObject.cpp: Added.
+ * bindings/js/ScriptObject.h: Added.
+ * bindings/js/ScriptObjectQuarantine.cpp: Added.
+ * bindings/js/ScriptObjectQuarantine.h: Added.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind.
+ (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind.
+ (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
+ * inspector/InspectorController.h: Removed addScriptDatabaseResource and
+ removeScriptDatabaseResource declarations.
+ * inspector/InspectorDatabaseResource.cpp:
+ (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
+ (WebCore::InspectorDatabaseResource::bind): Added.
+ (WebCore::InspectorDatabaseResource::unbind): Added.
+ * inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
+
+2009-03-13 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24467
+ Make Skia drawRect() and stroke behavior match CG.
+
+ This makes drawRect() ignore the stroke width (like CG does), and
+ adds a warning comment about that to the appropriate header.
+
+ It also eliminates some hacky code in Skia's stroke preparation,
+ which tried to adjust odd-width strokes to fall on pixel boundaries.
+ Not only did this not match CG, it wouldn't necessarily work right,
+ because there could be other transforms (e.g. full-page zoom) that
+ would affect the stroke before it reached the device pixel level.
+
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::fillRect):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::drawRect):
+ (PlatformContextSkia::setupPaintForStroking):
+
+2009-03-13 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24583
+ Need to change scope of constructor and destructor of V8ObjectEventListener from private
+ to protected so that they could be used in its derived class V8WorkerContextEventListener.
+
+ * bindings/v8/V8ObjectEventListener.h:
+
+2009-03-13 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24579
+ Many V8*Event* files are misplaced.
+
+ This code is infrastructure for supporting the bindings and thus should
+ be in the bindings/v8 directory.
+
+ * bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
+ * bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
+ * bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
+ * bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
+ * bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
+ * bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
+ * bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
+ * bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
+
+2009-03-13 Adele Peterson <adele@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content
+
+ Test: editing/pasteboard/5089327.html
+
+ Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::handleStyleSpansBeforeInsertion):
+ (WebCore::ReplaceSelectionCommand::handleStyleSpans):
+
+2009-03-13 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Update Geolocation perimission dialogs to be asynchronous.
+ https://bugs.webkit.org/show_bug.cgi?id=24505
+
+ Geolocation now requests permission from the Chrome asynchronously.
+ The Chrome is passed the Geolocation object, and the Chrome sets the permission
+ on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
+ of SecurityOrigins with geolocation permission. This is so that the GeolocationService
+ can inform the Chrome of its request, and the Chrome is also free to implement its
+ own policy.
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::requestGeolocationPermissionForFrame):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::Geolocation):
+ (WebCore::Geolocation::getCurrentPosition):
+ (WebCore::Geolocation::watchPosition):
+ (WebCore::Geolocation::setIsAllowed):
+ (WebCore::Geolocation::displayChallengeIfNecessary):
+ (WebCore::Geolocation::geolocationServicePositionChanged):
+ * page/Geolocation.h:
+ (WebCore::Geolocation::isAllowed):
+ (WebCore::Geolocation::setShouldClearCache):
+ (WebCore::Geolocation::shouldClearCache):
+ (WebCore::Geolocation::):
+
+2009-03-13 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6610666> Revise the Cocoa event model text API
+
+ Add a NPCocoaEventTextInput event type. Remove the text input variables.
+
+ * bridge/npapi.h:
+ (_NPCocoaEvent::):
+
+2009-03-13 Kevin Decker <kdecker@apple.com>
+
+ Reviewed by Anders.
+
+ <rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed
+
+ The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
+ over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
+ for x-oleobject.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
+
+2009-03-13 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24559
+ Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.
+
+ * bindings/v8/custom/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::getListenerFunction):
+ (WebCore::V8LazyEventListener::getWrappedListenerFunction):
+
+2009-03-13 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24557
+ This is to support running multiple workers in a single worker process in chromium.
+
+ * bindings/v8/custom/V8WorkerContextEventListener.cpp:
+ (WebCore::V8WorkerContextEventListener::handleEvent):
+ Add locker to v8 event listener of worker context.
+
+2009-03-13 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24575
+ XHR response is incorrect after a network error.
+
+ Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html
+ http/tests/xmlhttprequest/cross-site-denied-response-sync.html
+ http/tests/xmlhttprequest/cross-site-denied-response.html
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request.
+ (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note
+ that since internalAbort() can drop GC protection, it is not safe to use the object after
+ this call.
+ (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and
+ return early if it was. This can happen during sync requests, as the loader does not know
+ that it was aborted, and just synthesizes all callbacks.
+
+2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=3547
+ XMLHttpRequest.statusText returns always "OK"
+
+ Covered by existing tests (which now pass on all platforms but Mac).
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up
+ to each platform to correctly set the status text or set it to "OK" to retain current
+ behavior.
+
+2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24349
+ [QT] HTTP status text is never set
+
+ Set HTTP status text to the reason phrase attribute of QNetworkReply.
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+
+2009-03-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Mark Rowe
+
+ <rdar://problem/6622300>: Reproducible crash on
+ <http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>
+
+ Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
+ deleted from under itself. The sheetLoaded() notification can allow scripts
+ to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
+ which can cause the last ref to the CSSStyleSheet to be released.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::checkLoaded):
+
+2009-03-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Allow make-generated-sources.sh to pass args down to DerivedSources.make
+
+ * make-generated-sources.sh:
+
+2009-03-12 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24498
+ Fix the Qt port to use the same algorithm for drawing dashed and dotted
+ borders as the other ports. This makes the Qt port pixel-for-pixel perfect
+ compared to border drawing with Apple's canonical mac port and much closer
+ to konqueror and firefox behavior.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::drawLine):
+
+2009-02-26 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Clean up DOMSelection to use some helper functions
+ making the code smaller, and less error-prone.
+ https://bugs.webkit.org/show_bug.cgi?id=19221
+
+ I tried moving DOMSelection off of rangeCompliantEquivalent
+ but failed. VisibleSelection holds positions like (table, 1) to mean
+ "after the table".
+
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::visibleSelection):
+ (WebCore::anchorPosition):
+ (WebCore::focusPosition):
+ (WebCore::basePosition):
+ (WebCore::extentPosition):
+ (WebCore::DOMSelection::anchorNode):
+ (WebCore::DOMSelection::anchorOffset):
+ (WebCore::DOMSelection::focusNode):
+ (WebCore::DOMSelection::focusOffset):
+ (WebCore::DOMSelection::baseNode):
+ (WebCore::DOMSelection::baseOffset):
+ (WebCore::DOMSelection::extentNode):
+ (WebCore::DOMSelection::extentOffset):
+ * page/DOMSelection.h:
+
+2009-03-12 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24563
+ Change ResourceRequest to be a struct rather then a class to match other declarations.
+
+ * platform/network/chromium/ResourceRequest.h:
+
+2009-03-12 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Bug 24530: width100percent-searchfield.html should be fixed for chromium.
+ <https://bugs.webkit.org/show_bug.cgi?id=24530>
+
+ Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html
+
+ * css/themeChromiumWin.css: Added.
+ Overrides the changes to start supporting input[type="search"] on Windows (since
+ Chromium doesn't do anything special for this).
+
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::supportsFocus):
+ (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
+ (WebCore::RenderThemeChromiumWin::determineState):
+ (WebCore::RenderThemeChromiumWin::getThemeData):
+
+2009-03-12 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24506
+ Geolocation in Safari differs from the spec, no Coordinates attribute on Position
+
+ Get up to date.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions):
+ * page/Coordinates.cpp: Added.
+ (WebCore::Coordinates::toString):
+ * page/Coordinates.h: Added.
+ (WebCore::Coordinates::create):
+ (WebCore::Coordinates::latitude):
+ (WebCore::Coordinates::longitude):
+ (WebCore::Coordinates::altitude):
+ (WebCore::Coordinates::accuracy):
+ (WebCore::Coordinates::altitudeAccuracy):
+ (WebCore::Coordinates::heading):
+ (WebCore::Coordinates::speed):
+ (WebCore::Coordinates::Coordinates):
+ * page/Coordinates.idl: Added.
+ * page/Geoposition.cpp:
+ (WebCore::Geoposition::toString):
+ * page/Geoposition.h:
+ (WebCore::Geoposition::create):
+ (WebCore::Geoposition::coords):
+ (WebCore::Geoposition::Geoposition):
+ * page/Geoposition.idl:
+ * page/PositionOptions.h:
+ (WebCore::PositionOptions::create):
+ (WebCore::PositionOptions::maximumAge):
+ (WebCore::PositionOptions::setMaximumAge):
+ (WebCore::PositionOptions::PositionOptions):
+ * platform/mac/GeolocationServiceMac.mm:
+ (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
+
+2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24496
+ Fix console logging of non-string values by coercing the argument to
+ a string, for V8 bindings.
+
+ Test: fast/js/console-non-string-values.html
+
+ * bindings/v8/ScriptValue.cpp: Added toString method.
+ (WebCore::ScriptValue::toString):
+ * bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes
+ and toString declaration.
+
+2009-03-12 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Eliminate ChromiumBridge::uiResourceProtocol
+ https://bugs.webkit.org/show_bug.cgi?id=24558
+
+ * platform/chromium/ChromiumBridge.h:
+
+2009-03-12 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Missing breaks in switch statement
+ https://bugs.webkit.org/show_bug.cgi?id=24556
+
+ * platform/mac/GeolocationServiceMac.mm:
+ (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
+
+2009-03-12 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24554
+ Remove some unused functions from ChromiumBridge.
+
+ * platform/chromium/ChromiumBridge.h:
+
+2009-03-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Fisher and Justin Garcia.
+
+ Safari crashes during drag and drop in Google presentations
+ due to mutation event handlers removing DOM content during insertNode
+ https://bugs.webkit.org/show_bug.cgi?id=22634
+
+ Added a bunch of "null" checks to make sure nodes are still
+ in the document before we operate on them. This is an
+ inelegant solution, but it's the best we have for now.
+
+ Test: editing/selection/crash-on-drag-with-mutation-events.html
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::insertNodeAt):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Adam Treat.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24525
+ REGRESSION: Inspector window doesn't close when inspected page is
+ destroyed. This is a revert of r41158, which became unnecessary when
+ InspectorController became ref-counted in r41462.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage
+ after calling close().
+ (WebCore::InspectorController::stopUserInitiatedProfiling): Remove
+ m_inspectedPage check guard around profile logic.
+
+2009-03-12 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24502
+ Make horizontal scrolling on Windows always go the correct direction.
+
+ * platform/PlatformWheelEvent.h:
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24496
+ Fix console logging of non-string values by coercing the argument to
+ a string.
+
+ Test: fast/js/console-non-string-values.html
+
+ * bindings/js/ScriptValue.cpp: Removed PlatformString include.
+ * bindings/js/ScriptValue.h: Added toString method.
+ (WebCore::ScriptValue::toString):
+ * page/Console.cpp:
+ (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use
+ ScriptValue::toString.
+ (WebCore::Console::addMessage): added extra ScriptState argument to callsite.
+ (WebCore::Console::count): Ditto.
+
+2009-03-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24508
+
+ Fix updating of text field with placeholder text when value is set
+ by ensuring that updatePlaceholderVisibility() is called after
+ the value has been updated, not before.
+
+ Test: fast/forms/placeholder-set-value.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setValue):
+
+2009-03-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24552
+
+ Hit testing involving normal flow, self-painting layers (e.g. reflections)
+ was broken because it was not null-testing the result of hitTestLayer(),
+ so bailing early with a nil hit layer.
+
+ Test: fast/layers/normal-flow-hit-test.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Removed zero-sized files, left over from improperly applied patch.
+
+ * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
+ * platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.
+
+2009-03-12 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Do not ignore alpha color in optimization. Hard to believe, but there
+ are websites that fill the entire page with a tiled image consisting of
+ nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 24110: cloneNode should call cloneElement and not the reverse
+
+ - Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren.
+ Now cloneNode calls one of the 2 previous methods.
+
+ - Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.
+
+ - Moved cloneNode to the Element private section so that WebCore callers cannot use it.
+
+ - Removed Element::cloneNode usage through WebCore.
+
+ * dom/Element.cpp:
+ (WebCore::Element::cloneNode): Moved to Element's private section and it
+ now calls the two next methods.
+ (WebCore::Element::cloneElementWithChildren): Added.
+ (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement
+ to avoid ambiguity.
+ * dom/Element.h:
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement
+ to call to cloneElementWithoutChildren.
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply): Ditto.
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::indentRegion): Ditto.
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
+ * editing/SplitElementCommand.cpp:
+ (WebCore::SplitElementCommand::doApply): Ditto.
+ * editing/markup.cpp:
+ (WebCore::createFragmentFromText): Ditto.
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::buildShadowTree): Ditto.
+ (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
+
+2009-03-12 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fixed a crash on the 1x1 pixel check for background image in gtk.
+ We need to load the image first and need to be sure that the image
+ is not null before checking the type.
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-03-12 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24544
+ Rename setUrl to setURL
+
+ Use proper case for setUrl method, rename it to setURL.
+
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::adopt):
+ * platform/network/ResourceResponseBase.h:
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::writeCallback):
+ (WebCore::headerCallback):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+ (WebCore::queryInfoCallback):
+
+2009-03-12 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24519
+ [GTK] Use two argument KURL ctor in ResourceHandleSoup
+
+ Use two argument KURL ctor, the single argument ctor expects its
+ input to be the output of a previous KURL::parse call, which is
+ not the case here.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+ (WebCore::queryInfoCallback):
+
+2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Fix for <rdar://6418681>
+ https://bugs.webkit.org/show_bug.cgi?id=22644
+
+ Reviewed by Steve Falkenburg.
+
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
+ Client plug-in to the blacklist; it requires a Mozilla-based browser.
+
+2009-03-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (build fix).
+
+ build fix.
+
+ * html/CanvasRenderingContext2D.h:
+
+2009-03-11 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
+
+ A number of dashboard widgets rely on canvas failing silently when given invalid
+ colors for gradient stops, but both the spec and firefox throw exceptions here.
+ So we work around this by creating a dashboard quirk that will only suppress the
+ exception in dashboard compatibility mode.
+
+ Test: fast/canvas/canvas-gradient-addStop-error.html
+
+ * html/CanvasGradient.cpp:
+ (WebCore::CanvasGradient::CanvasGradient):
+ (WebCore::CanvasGradient::addColorStop):
+ * html/CanvasGradient.h:
+ (WebCore::CanvasGradient::setDashboardCompatibilityMode):
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
+ (WebCore::CanvasRenderingContext2D::createLinearGradient):
+ (WebCore::CanvasRenderingContext2D::createRadialGradient):
+ * html/CanvasRenderingContext2D.h:
+
+2009-03-11 David Kilzer <ddkilzer@apple.com>
+
+ Clarify comments regarding order of FEATURE_DEFINES
+
+ Rubber-stamped by Mark Rowe.
+
+ * Configurations/WebCore.xcconfig: Added warning about the
+ consequences when FEATURE_DEFINES are not kept in sync.
+
+2009-03-11 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24515
+ [GTK] soup backend should use GMappedFile instead of mmap directly
+
+ Rewrite mmap code used to upload files to use GMappedFile, so that
+ it is platform-independent.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp):
+
+2009-03-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - WebCore part of fixing <rdar://problem/3919124> Thai text selection
+ in Safari is incorrect
+
+ Test: platform/mac/editing/selection/word-thai.html
+
+ Tested on Mac, but should work on all ICU platforms (or more precisely
+ on all platforms that implement
+ WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).
+
+ * editing/TextIterator.cpp:
+ (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
+ Added.
+ (WebCore::BackwardsCharacterIterator::range): Added.
+ (WebCore::BackwardsCharacterIterator::advance): Added.
+
+ * editing/TextIterator.h: Added BackwardsCharacterIterator with the
+ minimal functionality required for this patch.
+ (WebCore::BackwardsCharacterIterator::atEnd): Added.
+
+ * editing/visible_units.cpp:
+ (WebCore::firstNonComplexContextLineBreak): Added this helper function
+ that returns the index of the first character in the string whose
+ Unicode line breaking property value is not SA ("Complex Context"), or
+ the length of the string if there is no such character.
+ (WebCore::lastNonComplexContextLineBreak): Added this helper function
+ that returns the index of the last character in the string whose
+ Unicode line breaking property value is not SA ("Complex Context"), or
+ -1 if there is no such character.
+ (WebCore::previousBoundary): Changed the signature of the search
+ function to include an offset parameter. Renamed the 'exception' local
+ variable to 'ec' and changed its type to ExceptionCode. Extend the
+ string forwards until the first character with Unicode line breaking
+ property value other than SA. This gives the boundary search function
+ enough context in the forward direction. Changed to use a
+ BackwardsCharacterIterator for translating the backwards offset into
+ a position.
+ (WebCore::nextBoundary): Changed the signature of the search
+ function to include an offset parameter. Extend the string backwards
+ until the first character with Unicode line breaking property value
+ other than SA. This gives the boundary search function enough context in
+ the backwards direction. Restricted the workaround for <rdar://5192593>
+ only to the line break case, because it was causing an extra character
+ to be selected following a word that ended with a combining mark.
+ (WebCore::startWordBoundary): Added an offset parameter. Check that
+ going backwards from the given offset, there is a character with Unicode
+ line breaking property value other than SA, and otherwise return 0 to
+ request more context.
+ (WebCore::endWordBoundary): Similar, but in reverse.
+ (WebCore::previousWordPositionBoundary): Similar.
+ (WebCore::nextWordPositionBoundary): Similar.
+ (WebCore::startSentenceBoundary): Updated for the new search function
+ signature.
+ (WebCore::endSentenceBoundary): Ditto.
+ (WebCore::previousSentencePositionBoundary): Ditto.
+ (WebCore::nextSentencePositionBoundary): Ditto.
+
+2009-03-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Don't use "::" in thread names because it is ugly!
+
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
+ it clear this is a WebCore-created thread.
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
+ * storage/LocalStorageThread.cpp:
+ (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
+
+2009-03-11 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Darin Adler.
+
+ <rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex
+
+ * platform/mac/PlatformScreenMac.mm:
+ (WebCore::screenIsMonochrome): Return false.
+
+2009-03-11 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
+ top value on position:relative child not calculated correctly if
+ parent has percentage height
+ - and corresponding -
+ <rdar://problem/6172925>
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::relativePositionOffsetY):
+
+2009-03-11 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Implement ScriptValue::hasNoValue for V8.
+ https://bugs.webkit.org/show_bug.cgi?id=24507
+
+ * bindings/v8/ScriptValue.h:
+ (WebCore::ScriptValue::hasNoValue):
+
+2009-03-11 David Levin <levin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Bug 24459: Add v8 bindings for event.
+ <https://bugs.webkit.org/show_bug.cgi?id=24459>
+
+ Adding custom event bindings.
+
+ * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
+ * bindings/v8/custom/V8AbstractEventListener.h: Added.
+ * bindings/v8/custom/V8AttrCustom.cpp:
+ Fixed messed up copyright header.
+ * bindings/v8/custom/V8CustomEventListener.cpp: Added.
+ * bindings/v8/custom/V8CustomEventListener.h:
+ Replaced forwarding header with the real implementation.
+ * bindings/v8/custom/V8ElementCustom.cpp:
+ * bindings/v8/custom/V8LazyEventListener.cpp: Added.
+ * bindings/v8/custom/V8LazyEventListener.h: Added.
+ * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
+ * bindings/v8/custom/V8ObjectEventListener.h: Added.
+ * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
+ * bindings/v8/custom/V8WorkerContextEventListener.h: Added.
+
+2009-03-11 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24521
+ Add some missing includes for the non-JSC build.
+
+ * platform/text/PlatformString.h: added OwnPtr.h
+ * xml/XMLHttpRequest.cpp: added SecurityOrigin.h
+
+2009-03-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24531
+
+ Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
+ returns a null style if it has a valid renderer, which could happen if a
+ CompositeAnimation existed, but wasn't running any animations or transitions.
+
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
+
+2009-03-11 Simon Fraser <simon.fraser@apple.com>
+
+ Fix Scons build. Patch from Alexander Guy.
+
+ * WebCore.scons:
+
+2009-03-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=23093
+
+ When the cancel button in the search field is shown or hidden,
+ we need to explicitly setStyle() on the cancel button's renderer,
+ to ensure that repaint happens. Changing the style without telling
+ the renderer won't work.
+
+ Test: fast/repaint/search-field-cancel.html
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+ (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
+ (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
+ (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
+ * rendering/RenderTextControlSingleLine.h:
+
+2009-03-11 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15790
+ Ligatures aren't accounted for when manipulating VisiblePositions
+
+ Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
+ Indic ligature which uses a virama sign.
+
+ Test: editing/deleting/skip-virama-001.html
+
+ * platform/text/TextBreakIteratorICU.cpp:
+ (WebCore::cursorMovementIterator):
+
+2009-03-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24513
+ REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)
+
+ Fixes existing tests on Tiger.
+
+ * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
+ Use characterBreakIterator on Tiger (like we used to do).
+
+2009-03-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
+
+ * platform/network/mac/ResourceRequestMac.mm:
+ (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
+ in instancesRespondToSelector.
+
+2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
+ https://bugs.webkit.org/show_bug.cgi?id=2260
+
+ Add missing stdio.h include to get the build going
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+
+2009-03-10 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Ken Kocienda.
+
+ * dom/Range.cpp:
+ (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
+ would include rects for the divs contents. Set the correct RenderObject to stop at.
+
+2009-03-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
+ comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
+ there are security concerns with exposing them for cross-origin requests, so it's not clear
+ if we want to change anything here.
+
+2009-03-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24503
+
+ Fix hit testing of absolutely positioned single line text controls by
+ ensuring that we set result.innerNode() correctly. If the hit node is
+ a descendant of the inner text element or if it is the <input> itself,
+ then we say we hit the innerTextElement.
+
+ Rename hitInnerTextBlock() to hitInnerTextElement() to match the
+ 'innerTextElement' terminology used elsewhere.
+
+ Assert that if renderer()->hitTest() returns false, no-one set
+ result.innerNode().
+
+ Test: fast/forms/search-abs-pos-cancel-button.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestContents):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::hitInnerTextElement):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::nodeAtPoint):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+
+2009-03-10 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
+
+ Another case where we would trigger extended encoding loading needlessly.
+
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::isNonByteBasedEncoding):
+
+2009-03-10 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
+ scroll bar appears for long line of text with NOWRAP set
+
+ This is a regression from http://trac.webkit.org/changeset/32226
+ I talked with Dan about the original change, and we decided that
+ the best fix was to remove his small potential-optimization that
+ only created a separate line box for whitespace under certain
+ circumstances. This new code will always create a separate line
+ box.
+
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-03-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for <rdar://problem/6166844>
+ https://bugs.webkit.org/show_bug.cgi?id=24495
+
+ Use same rule for loading java applets as we do for images.
+
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::createRenderer):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createJavaAppletWidget):
+
+2009-03-10 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Get rid of revealCaret and use revealSelection instead.
+
+ * WebCore.base.exp:
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setSelection):
+ * page/Frame.cpp:
+ (WebCore::Frame::revealSelection):
+ * page/Frame.h:
+
+2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Geoff Garen.
+
+ Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
+ <https://bugs.webkit.org/show_bug.cgi?id=23736>
+ <rdar://problem/6560278>
+
+ Before replacing the document, FrameLoader::executeIfJavaScriptURL()
+ should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeIfJavaScriptURL):
+
+2009-03-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24494: crash when deleting at end of document and merging paragraphs
+ https://bugs.webkit.org/show_bug.cgi?id=24494
+ rdar://problem/6571537
+
+ Test: editing/deleting/merge-at-end-of-document.html
+
+ * dom/Range.cpp:
+ (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
+ use && in assertions since we'd like to know which condition is failing.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
+ calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
+ function doesn't know which value to return.
+
+2009-03-10 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel. Math checked by Oliver Hunt.
+
+ Implement the Cairo version of the checkForSolidColor() method. This halfes the
+ time to draw on 1x1 px background images.
+ I added two new calls to Color for the pixel manipulation on cairo_surface's.
+ They are neede to premultiply/unpremultiply the colors of the surface.
+
+ [CAIRO] Introduce single-pixel image optimizations
+ https://bugs.webkit.org/show_bug.cgi?id=17284
+
+ * platform/graphics/Color.cpp:
+ (WebCore::colorFromPremultipliedARGB):
+ (WebCore::premultipliedARGBFromColor):
+ * platform/graphics/Color.h:
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-03-06 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24437
+
+ Add support for registering noAccess URL schemes:
+ 1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
+ that list upon construction (similar to how isLocal is implemented).
+ 2- Make InspectorController call grantUniversalAccess on its Document's
+ SecurityOrigin at the time when windowScriptObjectAvailable is called.
+
+ This enables content such as the inspector to be loaded from a custom (non-file)
+ URL, which is how Chromium loads the inspector. It also allows other URL schemes
+ to be treated like data: URLs, which Chromium utilizes for its various HTML-based
+ UI panels.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ * loader/FrameLoader.cpp:
+ (WebCore::localSchemes):
+ (WebCore::noAccessSchemes):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::SecurityOrigin):
+ (WebCore::SecurityOrigin::isLocal):
+
+2009-03-10 Xan Lopez <xlopez@igalia.com>
+
+ Build fix, no review
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (textMarkerForVisiblePosition):
+ (visiblePositionForTextMarker):
+
+2009-03-10 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24491
+ Rename posOffset to m_offset, get rid of accessor
+
+ As suggested in dom/Position.h, this patch gets rid of the
+ 'offset()' accessor and renames posOffset to m_offset. I've used
+ m_offset instead of offset to follow the style guide lines, since
+ Position is still a class and not a structure. If the long term
+ plan is still to make it a structure it would be pretty easy to
+ just s/m_offset/offset/ globally when that is achieved.
+
+ * dom/Position.cpp:
+ (WebCore::Position::previous):
+ (WebCore::Position::next):
+ (WebCore::Position::atStart):
+ (WebCore::Position::atEnd):
+ (WebCore::Position::renderedOffset):
+ (WebCore::Position::isCandidate):
+ (WebCore::Position::inRenderedText):
+ (WebCore::Position::isRenderedCharacter):
+ (WebCore::Position::rendersInDifferentPosition):
+ (WebCore::Position::leadingWhitespacePosition):
+ (WebCore::Position::debugPosition):
+ (WebCore::Position::formatForDebugger):
+ * dom/Position.h:
+ (WebCore::Position::Position):
+ * dom/PositionIterator.h:
+ (WebCore::PositionIterator::PositionIterator):
+ * dom/Range.cpp:
+ * dom/RangeBoundaryPoint.h:
+ (WebCore::RangeBoundaryPoint::position):
+ (WebCore::RangeBoundaryPoint::set):
+ (WebCore::RangeBoundaryPoint::setOffset):
+ (WebCore::RangeBoundaryPoint::setToChild):
+ (WebCore::RangeBoundaryPoint::setToStart):
+ (WebCore::RangeBoundaryPoint::setToEnd):
+ (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
+ (WebCore::ApplyStyleCommand::removeInlineStyle):
+ (WebCore::ApplyStyleCommand::nodeFullySelected):
+ (WebCore::ApplyStyleCommand::nodeFullyUnselected):
+ (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
+ (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
+ (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
+ (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
+ (WebCore::ApplyStyleCommand::joinChildTextNodes):
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::insertNodeAt):
+ (WebCore::CompositeEditCommand::positionOutsideTabSpan):
+ (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
+ (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
+ (WebCore::CompositeEditCommand::deleteInsignificantText):
+ (WebCore::CompositeEditCommand::removePlaceholderAt):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::updatePositionForNodeRemoval):
+ (WebCore::updatePositionForTextRemoval):
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+ (WebCore::DeleteSelectionCommand::fixupWhitespace):
+ * editing/Editor.cpp:
+ (WebCore::Editor::setComposition):
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::Editor::getCompositionSelection):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::performTrivialReplace):
+ (WebCore::InsertTextCommand::input):
+ (WebCore::InsertTextCommand::insertTab):
+ * editing/MoveSelectionCommand.cpp:
+ (WebCore::MoveSelectionCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::debugRenderer):
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::rangeFromLocationAndLength):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::characterAfter):
+ (WebCore::VisiblePosition::debugPosition):
+ (WebCore::makeRange):
+ (WebCore::setStart):
+ (WebCore::setEnd):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::toNormalizedRange):
+ (WebCore::makeSearchRange):
+ (WebCore::VisibleSelection::debugPosition):
+ (WebCore::VisibleSelection::showTreeForThis):
+ * editing/htmlediting.cpp:
+ (WebCore::comparePositions):
+ (WebCore::rangeCompliantEquivalent):
+ (WebCore::isFirstPositionAfterTable):
+ (WebCore::isLastPositionBeforeTable):
+ * editing/visible_units.cpp:
+ (WebCore::previousBoundary):
+ (WebCore::nextBoundary):
+ (WebCore::startPositionForLine):
+ (WebCore::startOfLine):
+ (WebCore::endPositionForLine):
+ (WebCore::nextLinePosition):
+ (WebCore::startOfParagraph):
+ (WebCore::endOfParagraph):
+ * page/AccessibilityObject.cpp:
+ (WebCore::updateAXLineStartForVisiblePosition):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::anchorOffset):
+ (WebCore::DOMSelection::baseOffset):
+ (WebCore::DOMSelection::focusOffset):
+ (WebCore::DOMSelection::extentOffset):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionLayoutChanged):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::indexForVisiblePosition):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeSelection):
+
+2009-03-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
+ https://bugs.webkit.org/show_bug.cgi?id=23564
+ rdar://problem/6537238
+
+ Test: fast/dom/HTMLElement/innerHTML-selection-crash.html
+
+ * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
+ call to the one of the two overloads of this function that wasn't calling it. This fixes
+ this crash and other possible crashes inside innerHTML.
+
+2009-03-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24285
+ Text resource loading checks for BOM twice
+
+ This removes TextDecoder class, since its only purpose was to check for BOM, which is
+ already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
+ BOM checked, but I didn't find any cases where it would significantly change behavior.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Remove TextDecoder.{h,cpp}.
+
+ * platform/text/TextDecoder.cpp: Removed.
+ * platform/text/TextDecoder.h: Removed.
+
+ * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
+ TextCodec separately.
+
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
+ (WebCore::TextResourceDecoder::setEncoding): Ditto.
+ (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
+ even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
+ BOM again. Made this function return the detected BOM length.
+ (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
+ a text resource.
+ (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
+ resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
+
+ * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
+ Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
+ checks for BOM, which was a counter-intuitive feature.
+
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::CachedScript):
+ (WebCore::CachedScript::setEncoding):
+ (WebCore::CachedScript::encoding):
+ (WebCore::CachedScript::script):
+ * loader/CachedScript.h:
+ * loader/appcache/ManifestParser.cpp:
+ (WebCore::parseManifest):
+ Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
+ A side effect of this is that these resources will now be subject to encoding auto-detection.
+
+ * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
+ * page/Page.cpp: (WebCore::Page::userStyleSheet):
+ Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
+ re-usable (for repeated decoding of the same resource).
+
+ * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
+
+2009-03-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24488
+ An assertion failure when updating an offline application cache after emptying caches
+
+ Emptying appcache cannot be performed automatically, so no test.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
+ storage, even if the application wasn't updated server side.
+
+2009-03-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ <rdar://problem/6425807> Implement WorkerUtils.importScripts()
+ <https://bugs.webkit.org/show_bug.cgi?id=22721>
+
+ Implement importScripts, currently uses a series of synchronous loads
+ to fetch the scripts, but this is simpler than a synchronous load of
+ multiple loads in parallel. In future we'll want to switch to parallel
+ loading, but this will do for now.
+
+ Test: http/tests/workers/worker-importScripts.html
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::importScripts):
+ * bindings/js/ScriptValue.h:
+ (WebCore::ScriptValue::hasNoValue):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ (WebCore::WorkerScriptController::setException):
+ * bindings/js/WorkerScriptController.h:
+ * dom/Document.cpp:
+ (WebCore::Document::scriptImported):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::scriptImported):
+ * inspector/InspectorController.h:
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::setScriptProperties):
+ * inspector/InspectorResource.h:
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::scriptImported):
+ (WebCore::WorkerContext::importScripts):
+ * workers/WorkerContext.h:
+ * workers/WorkerContext.idl:
+ * workers/WorkerImportScriptsClient.cpp: Added.
+ (WebCore::WorkerImportScriptsClient::didReceiveResponse):
+ (WebCore::WorkerImportScriptsClient::didReceiveData):
+ (WebCore::WorkerImportScriptsClient::didFinishLoading):
+ (WebCore::WorkerImportScriptsClient::didFail):
+ (WebCore::WorkerImportScriptsClient::didFailRedirectCheck):
+ (WebCore::WorkerImportScriptsClient::didReceiveAuthenticationCancellation):
+ * workers/WorkerImportScriptsClient.h: Added.
+ (WebCore::WorkerImportScriptsClient::WorkerImportScriptsClient):
+ (WebCore::WorkerImportScriptsClient::script):
+ (WebCore::WorkerImportScriptsClient::failed):
+
+2009-03-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24462
+ Move cross-origin access control code out of XMLHttpRequest
+
+ Step 1: move preflight result cache and access control helper functions.
+
+ No change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * loader/CrossOriginAccessControl.cpp: Added.
+ (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
+ (WebCore::isSimpleCrossOriginAccessRequest):
+ (WebCore::createAllowedCrossOriginResponseHeadersSet):
+ (WebCore::isOnAccessControlResponseHeaderWhitelist):
+ (WebCore::passesAccessControlCheck):
+ * loader/CrossOriginAccessControl.h: Added.
+ * loader/CrossOriginPreflightResultCache.cpp: Added.
+ (WebCore::parseAccessControlMaxAge):
+ (WebCore::addToAccessControlAllowList):
+ (WebCore::parseAccessControlAllowList):
+ (WebCore::CrossOriginPreflightResultCacheItem::parse):
+ (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
+ (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
+ (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
+ (WebCore::CrossOriginPreflightResultCache::shared):
+ (WebCore::CrossOriginPreflightResultCache::appendEntry):
+ (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
+ * loader/CrossOriginPreflightResultCache.h: Added.
+ (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
+ (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
+ (WebCore::XMLHttpRequest::createRequest):
+ (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
+ (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
+ (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::didReceiveResponse):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ * xml/XMLHttpRequest.h:
+
+2009-03-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19797
+ Bring the list of forbidden headers in sync with XMLHttpRequest spec draft
+
+ Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
+ XMLHttpRequest 2 draft.
+
+2009-03-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=23975
+ <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
+ scrollbar rect calculation.
+
+2009-03-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein, Oliver Hunt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24475
+
+ When repainting replaced elements, need to union the selection
+ and overflow rects because either may extend outside the other.
+
+ Test: fast/repaint/transform-replaced-shadows.html
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
+
+2009-03-09 Stephanie Lewis <slewis@apple.com>
+
+ Fix build.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::markAllMisspellingsAndBadGrammarInRanges):
+
+2009-03-09 Kim Christensen <kimworking@gmail.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24276
+ Dropdown / select boxes do not consider the windows task bar in Chromium.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::showPopup):
+
+2009-03-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson and Dave Hyatt.
+
+ - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
+ misaligned edit fields
+
+ Test: fast/forms/legend-display-none.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
+ property of legend elements to 'block' unless it is 'none'.
+ * css/html4.css: Do not force the display property of legend elements to
+ 'block' using CSS, because that prevents style rules from setting it to
+ 'none'.
+
+2009-03-09 Alpha Lam <hclam@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23024
+
+ Fix an incorrect criteria in the if statement that leaves references to
+ deleted floating objects in RenderBlock.
+
+ Test: fast/block/float/crash-on-absolute-positioning.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+
+2009-03-09 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Eric Seidel.
+
+ Unify JSC/V8 idl file.
+ https://bugs.webkit.org/show_bug.cgi?id=24424
+
+ * page/Location.idl:
+
+2009-03-09 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Eric Seidel.
+
+ Unify JSC/V8 for History.idl.
+
+ * page/History.idl:
+
+2009-03-09 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Eric Seidel.
+
+ Unify JSC/V8 implementations of DOMWindow.idl.
+
+ * page/DOMWindow.idl:
+
+2009-03-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24163
+
+ Implement mapping of FloatQuads through 3D transforms.
+
+ Removed the redundant localToContainerQuad() methods, which can now
+ shared code with the old mapLocalToAbsolutePoint(), which was
+ renamed to mapLocalToContainer(). This can now convert a point,
+ and optionally a FloatQuad, which are carried along in the TransformState.
+
+ Optimized TransformState to reduce to simple FloatPoint.move()
+ if there are no transforms, and to heap-allocate a transform only if
+ necessary to accumulate transforms (when using preserve-3d).
+
+ Tested by 3d point mapping tests, and the inspector highlight (which now shows
+ the correct quads for 3d-transformed elements).
+
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::TransformationMatrix::projectQuad):
+ (WebCore::TransformationMatrix::translateRight):
+ (WebCore::TransformationMatrix::translateRight3d):
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToContainer):
+ (WebCore::RenderBox::mapAbsoluteToLocalPoint):
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::absoluteToLocal):
+ (WebCore::RenderObject::mapLocalToContainer):
+ (WebCore::RenderObject::localToContainerQuad):
+ * rendering/RenderObject.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::mapLocalToContainer):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::mapLocalToContainer):
+ * rendering/RenderView.h:
+ * rendering/TransformState.cpp:
+ (WebCore::TransformState::move):
+ (WebCore::TransformState::applyTransform):
+ (WebCore::TransformState::flatten):
+ (WebCore::TransformState::mappedPoint):
+ (WebCore::TransformState::mappedQuad):
+ (WebCore::TransformState::flattenWithTransform):
+ (WebCore::HitTestingTransformState::mappedQuad):
+ * rendering/TransformState.h:
+ (WebCore::TransformState::TransformState):
+ (WebCore::TransformState::move):
+ (WebCore::TransformState::lastPlanarPoint):
+ (WebCore::TransformState::lastPlanarQuad):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::preserves3D):
+
+2009-03-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24433
+
+ During hit testing with transforms, if a layer has backface-visibility: hidden,
+ we need to check for it whether or not the layer has a transform, because it
+ might be an ancestor that is transformed.
+
+ Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24353
+ Allow to overrule default build options for Qt build.
+
+ * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
+
+2009-03-09 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24463
+ WebCore::qstring is detaching and copying twice for every single
+ WebCore::TextRun that is processed and drawn. This elevates this method
+ to one of the top-ten most expensive methods in all of QtWebKit according
+ to profiling. This changes the method so that QString only detaches
+ when absolutely necessary.
+
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::qstring):
+ (WebCore::fixSpacing):
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+
+2009-03-08 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
+ Frame.h no longer needs to include it. This cuts the size of the symbols
+ for a debug build by around 3%.
+
+ * dom/Element.cpp:
+ (WebCore::Element::scrollIntoView):
+ (WebCore::Element::scrollIntoViewIfNeeded):
+ * editing/Editor.cpp:
+ (WebCore::Editor::insertTextWithoutSendingTextEvent):
+ (WebCore::Editor::revealSelectionAfterEditingOperation):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setSelection):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::gotoAnchor):
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected):
+ * page/Frame.cpp:
+ (WebCore::Frame::revealSelection):
+ (WebCore::Frame::revealCaret):
+ * page/Frame.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::getRectToExpose):
+ (WebCore::RenderLayer::autoscroll):
+ * rendering/RenderLayer.h:
+ * rendering/ScrollBehavior.cpp: Added.
+ (WebCore::):
+ * rendering/ScrollBehavior.h: Added.
+ (WebCore::):
+ (WebCore::ScrollAlignment::getVisibleBehavior):
+ (WebCore::ScrollAlignment::getPartialBehavior):
+ (WebCore::ScrollAlignment::getHiddenBehavior):
+
+ Add the new files to the build systems:
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+
+ Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
+ * dom/Clipboard.cpp:
+ * editing/EditorCommand.cpp:
+ * editing/InsertLineBreakCommand.cpp:
+ * editing/TypingCommand.cpp:
+ * html/HTMLFormControlElement.cpp:
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ * loader/icon/IconLoader.cpp:
+ * page/animation/AnimationController.cpp:
+ * rendering/RenderSlider.cpp:
+ * rendering/RenderTextControl.cpp:
+
+
+2009-03-08 Mark Rowe <mrowe@apple.com>
+
+ Reviewed Dan Bernstein.
+
+ Push the include of Frame.h out of RenderView.h and down to those files
+ that need it. This cuts the size of symbols for RenderFoo object files
+ by around 15% in a debug build.
+
+ * bindings/objc/DOM.mm:
+ * rendering/RenderFileUploadControl.cpp:
+ * rendering/RenderInline.cpp:
+ * rendering/RenderObject.cpp:
+ * rendering/RenderReplaced.cpp:
+ * rendering/RenderText.cpp:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::zoomFactor):
+ * rendering/RenderView.h:
+
+2009-03-08 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Remove some unnecessary or redundant includes from files related to the JS bindings.
+ This cuts the size of the symbols for a debug build by around 3%.
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.cpp:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ * bindings/js/JSDocumentCustom.cpp:
+ * bindings/js/JSPluginElementFunctions.cpp:
+ * bindings/js/JSSVGPODTypeWrapper.h:
+
+2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
+ and provisionalHistoryItem() from FrameLoader.
+
+ * WebCore.base.exp:
+ * WebCore.order:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::frameLoadCompleted):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+
+2009-03-08 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Implement proper logging for the GTK+ port, inspired by the one in
+ Qt. We use the WEBKIT_DEBUG environment variable which was already
+ being used to decide whether to setup a logger for soup or not.
+
+ * platform/gtk/LoggingGtk.cpp:
+ (WebCore::getChannelFromName):
+ (WebCore::InitializeLoggingChannelsIfNecessary):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ensureSessionIsInitialized):
+
+2009-03-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - WebCore part of removing build-time and run-time support for legacy
+ versions of CFNetwork and Core Graphics
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::fontPlatformData):
+ * platform/graphics/win/FontPlatformDataCGWin.cpp:
+ (WebCore::FontPlatformData::platformDataInit):
+ * platform/network/cf/FormDataStreamCFNet.cpp:
+ (WebCore::setHTTPBody):
+ (WebCore::httpBodyFromRequest):
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::didSendBodyData):
+ (WebCore::shouldUseCredentialStorageCallback):
+ (WebCore::ResourceHandle::start):
+ * platform/network/win/CookieJarCFNetWin.cpp:
+ (WebCore::filterCookies):
+
+2009-03-07 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
+ No multiple JS property for <input type="file" multiple />
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::multiple):
+ (WebCore::HTMLInputElement::setMultiple):
+ * html/HTMLInputElement.h:
+ * html/HTMLInputElement.idl:
+
+2009-03-07 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24358
+ [GTK] Scrollbars not clipped correctly
+
+ ScrollView scrollbars in subframes are *not* native, so take that
+ into account again.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::getLocationInParentWindow):
+ (ScrollbarGtk::frameRectsChanged):
+ (ScrollbarGtk::paint):
+ * platform/gtk/ScrollbarGtk.h:
+
+2009-03-06 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24405
+ Horizontal scrolling on Windows was reversed from Mac (and intuition).
+
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-06 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Sam Weinig.
+
+ Convert some C-style casts to static_cast<>()s.
+
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/mac/WheelEventMac.mm:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/wx/MouseWheelEventWx.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-06 Adele Peterson <adele@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)
+
+ I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.
+
+ * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
+ That is no longer true, so we should return the document element for a truly empty document.
+
+2009-03-06 Jay Campan <jcampan@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24306
+
+ Adding a flag to ResourceRequestBase to indicate whether or not upload
+ progress notifications are needed for a resource. This is useful to
+ avoid sending these notifications when there are no consumers
+ (especially in the Chromium case where IPC is involved).
+
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::reportUploadProgress):
+ (WebCore::ResourceRequestBase::setReportUploadProgress):
+ (WebCore::ResourceRequestBase::ResourceRequestBase):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+
+2009-03-06 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24150
+ Add virtual ScriptExecutionContext::encoding()
+
+ Test: http/tests/workers/text-encoding.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::encoding):
+ * dom/Document.h:
+ (WebCore::Document::inputEncoding):
+ (WebCore::Document::charset):
+ (WebCore::Document::characterSet):
+ Add new virtual method and route DOM synonym functions on Document through it.
+
+ * dom/ScriptExecutionContext.h:
+ * workers/Worker.cpp:
+ (WebCore::Worker::Worker):
+ (WebCore::Worker::notifyFinished):
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::WorkerContext):
+ (WebCore::WorkerContext::encoding):
+ (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
+ * workers/WorkerContext.h:
+ (WebCore::WorkerContext::create):
+ * workers/WorkerContextProxy.h:
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::startWorkerContext):
+ * workers/WorkerMessagingProxy.h:
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThreadStartupData::create):
+ (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * workers/WorkerThread.h:
+ All of the above route the 'encoding' parameter of parent context to the new
+ instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy
+ through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.
+
+2009-03-06 Peter Kasting <pkasting@google.com>
+
+ Build bustage fix.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchWheelEvent):
+
+2009-03-06 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.
+
+2009-03-06 Douglas R. Davidson <ddavidso@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24108
+
+ Update spelling and grammar checking to use the new combined text
+ checking (with automatic language identification) on Snow Leopard.
+ Tested manually in Mail and Safari; automated tests to come later.
+
+ * editing/Editor.cpp:
+ (WebCore::findFirstMisspellingOrBadGrammarInRange):
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::guessesForMisspelledOrUngrammaticalRange):
+ (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
+ (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+ (WebCore::markAllMisspellingsAndBadGrammarInRanges):
+ (WebCore::Editor::markMisspellingsAndBadGrammar):
+ * editing/Editor.h:
+ * loader/EmptyClients.h:
+ (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
+ * page/EditorClient.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::respondToChangedSelection):
+ * platform/ContextMenu.cpp:
+ (WebCore::ContextMenu::populate):
+
+2009-03-06 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24407
+ Windows scroll amount was too small, and wheel scroll distance
+ conversion code was overly complex.
+
+ * page/EventHandler.cpp:
+ (WebCore::scrollAndAcceptEvent):
+ * platform/PlatformWheelEvent.h:
+ (WebCore::):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/Scrollbar.h:
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/mac/WheelEventMac.mm:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/qt/WheelEventQt.cpp:
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::horizontalScrollChars):
+ (WebCore::verticalScrollLines):
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/wx/MouseWheelEventWx.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2009-03-06 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Adam Roben.
+
+ Generate valid bindings with HTML5 database support disabled.
+
+ * inspector/InspectorController.idl: Added feature guard around
+ databaseTableNames definition.
+
+2009-03-04 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24358
+ [GTK] Scrollbars not clipped correctly
+
+ Do not take into account the case of being a ScrollView scrollbar,
+ since those are native in our case.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::frameRectsChanged):
+
+2009-03-04 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24358
+ [GTK] Scrollbars not clipped correctly
+
+ Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
+ specific and it's our only Widget anyway.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::paint):
+ * platform/gtk/ScrollbarGtk.h:
+ * platform/gtk/WidgetGtk.cpp:
+
+2009-03-04 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24358
+ [GTK] Scrollbars not clipped correctly
+
+ Use correct clip rectangle and apply coordinate translation needed
+ for non-ScrollView scrollbars.
+
+ We were ignoring the clip rectangle passed as parameter, which is
+ wrong in the case of non coalesced expose events. This, in turn,
+ uncovers the fact that we were not applying coordinate translation
+ to our position.
+
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::paint):
+
+2009-03-06 Eric Carlson <eric.carlson@apple.com>
+
+ Build fix, no review
+
+ * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
+
+2009-03-06 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22790
+ Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
+ Replace media engine setRect with setSize since they don't use about the
+ position anyway.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
+ (WebCore::MediaPlayer::setSize): Ditto.
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayer::size): Changed from rect().
+
+ * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
+
+ * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
+ (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
+ (WebCore::MediaPlayerPrivate::paint): update comment
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
+ (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
+ (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
+ (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so
+ the movie is drawn in the correct location.
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
+
+2009-03-06 Darin Adler <darin@apple.com>
+
+ Reviewed by Darin Fisher.
+
+ Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
+ https://bugs.webkit.org/show_bug.cgi?id=24422
+ rdar://problem/6402208
+
+ Test: fast/dom/location-new-window-no-crash.html
+
+ The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
+ to add some checks for empty URLs. We could also put the empty URL checks at some
+ other bottleneck level and add more assertions over time. I tried adding a few more
+ assertions to functions like loadURL and hit them while running the regression tests,
+ so it's probably going to be a bit tricky to clean this up throughout the loader.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
+ immutable by making all its members const. Added assertions about the arguments,
+ including that the URL is not empty. Initialized one uninitialized member in one of
+ the constructors.
+ (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
+ a no-op if passed an empty URL.
+ (WebCore::FrameLoader::scheduleLocationChange): Ditto.
+ (WebCore::FrameLoader::scheduleRefresh): Ditto.
+
+2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24423
+ Use new soup_message_body_set_accumulate API in soup backend
+
+ Disable accumulating chunks for request_body on file uploads,
+ using the new soup API.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp):
+
+2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
+ the new soup_message_body_set_accumulate API in soup.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::gotHeadersCallback):
+ (WebCore::ResourceHandle::startHttp):
+
+2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24051
+ Soup backend needs content sniffing capabilities
+
+ Perform content sniffing when using soup, so that we have a chance
+ of figuring out the Content-Type of the file if it's not sent by
+ the server.
+
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::gotHeadersCallback):
+ (WebCore::gotChunkCallback):
+
+2009-03-06 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24342
+ Cannot insert a Thai character after a Thai prepend character when using ICU 4.0
+
+ This change creates a new break iterator "cursorMovementIterator" for
+ moving cursors and use it when moving an input cursor.
+ In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
+ based on the one of ICU 3.8.
+ On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
+ just calls the characterBreakIterator() function.
+
+ Test: editing/inserting/insert-thai-characters-001.html
+
+ * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
+ * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
+ (WebCore::setUpIteratorWithRules): Ditto.
+ (WebCore::cursorMovementIterator): Ditto.
+ * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
+ (WebCore::cursorMovementIterator): Ditto.
+ * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
+ (WebCore::RenderText::previousOffset): Ditto.
+ (WebCore::RenderText::nextOffset): Ditto.
+
+2009-03-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
+ Characters (a compatibility issue with widgets).
+
+ Test: http/tests/xmlhttprequest/broken-xml-encoding.html
+
+ Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
+ responses.
+
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::TextResourceDecoder):
+ (WebCore::TextResourceDecoder::decode):
+ (WebCore::TextResourceDecoder::flush):
+ * loader/TextResourceDecoder.h:
+ (WebCore::TextResourceDecoder::useLenientXMLDecoding):
+ Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
+ decoding errors. This behavior is now limited to other kinds of XML content.
+
+2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>
+
+ Bug 24382: request to add SH4 platform
+
+ <https://bugs.webkit.org/show_bug.cgi?id=24382>
+
+ Reviewed by David Kilzer.
+
+ * platform/text/AtomicString.cpp:
+ (WebCore::equal): Aligned memory access on SH4 platform.
+
+2009-03-05 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24215
+
+ Gears expects an object tag with display:none to instantiate the plugin,
+ so we add a workaround to make this work and fix Gears on WebKit trunk.
+
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::rendererIsNeeded):
+
+2009-03-05 Avi Drissman <avi@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Need to have Chromium Mac match Safari Mac's accesskey handling
+ https://bugs.webkit.org/show_bug.cgi?id=24404
+
+ * page/chromium/EventHandlerChromium.cpp:
+ (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
+
+2009-03-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24412
+
+ Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
+ but no transform. We need to make localTransformState if we see preserve-3d.
+ Also need to call update3DTransformedDescendantStatus() before we test
+ m_has3DTransformedDescendant.
+
+ Test: transforms/3d/hit-testing/hit-preserves-3d.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Changes to RenderLayer destruction to hopefully help catch an elusive crasher
+ https://bugs.webkit.org/show_bug.cgi?id=24409
+
+ Added a new RenderBoxModelObject::destroyLayer() call which is
+ now the only way which RenderLayers should ever be destroyed.
+ This ensures that the pointer to the layer is cleared in the
+ RenderObject after destruction, allowing us to ASSERT in the
+ RenderBoxModelObject destructor.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
+ (WebCore::RenderBoxModelObject::destroyLayer):
+ (WebCore::RenderBoxModelObject::destroy):
+ (WebCore::RenderBoxModelObject::styleDidChange):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::stackingContext):
+ (WebCore::RenderLayer::destroy):
+ (WebCore::RenderLayer::removeOnlyThisLayer):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::destroy):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy):
+
+2009-03-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Remove old, unused IE 5.5 scrollbar-* CSS properties.
+ Sort the unimplemented getComputedStyle properties so it's
+ easier to see which ones actually need implementation.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ * css/CSSPropertyNames.in:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+
+2009-03-05 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
+ within the document without changing its position in the DOM. For example, pressing return in (caret marked by ^):
+ <div contentEditable="true"><div>^Hello</div></div>
+ Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
+ for example).
+
+ Changes to layout tests demonstrate fix.
+
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or
+ not it did work that needs to be applied.
+ * editing/Editor.cpp:
+ (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
+ (WebCore::Editor::unappliedEditing): Ditto.
+ (WebCore::Editor::reappliedEditing): Ditto.
+ (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to
+ EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
+ even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position
+ in the document.
+ * editing/Editor.h:
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
+ (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to.
+ (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
+ adding to the killring and responding to a change in selections if the delete was a no-op.
+ (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
+ * editing/TypingCommand.h:
+
+2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Adam Roben.
+
+ Eliminate a ref-counting leak in InspectorController.
+
+ * inspector/InspectorController.h: Made constructor private, added static create method.
+ * page/Page.cpp:
+ (WebCore::Page::Page): Change initializer to use static create method.
+
+2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24355
+ Add InspectorController.idl and convert InspectorController.cpp to use
+ JSC bindings.
+
+ * DerivedSources.make: Added InspectorController.idl
+ * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
+ * bindings/js/JSInspectorControllerCustom.cpp: Added.
+ * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
+ * inspector/InspectorController.cpp: Removed hand-rolled bindings.
+ * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
+ * inspector/InspectorController.idl: Added.
+ * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
+
+2009-03-05 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24400
+ Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
+ media element attributes
+
+ Test: media/video-loop.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement):
+ (WebCore::HTMLMediaElement::loadInternal):
+ (WebCore::HTMLMediaElement::setNetworkState):
+ (WebCore::HTMLMediaElement::seek):
+ (WebCore::HTMLMediaElement::playInternal):
+ (WebCore::HTMLMediaElement::loop):
+ (WebCore::HTMLMediaElement::setLoop):
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+ (WebCore::HTMLMediaElement::endedPlayback):
+ (WebCore::HTMLMediaElement::updatePlayState):
+ * html/HTMLMediaElement.h:
+ * html/HTMLMediaElement.idl:
+
+2009-03-05 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached
+
+ Reviewed by Ada Chan.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
+
+2009-03-05 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=24248
+
+ Make sure painting of overflow controls checks that visibility:visible is set on the block before
+ painting. Pixel tests caught this regression.
+
+ Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
+ to do to their bounds (which had nothing to do with overflow).
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintResizer):
+
+2009-03-05 Yong Li <yong.li@torchmobile.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24386
+ A faster implementation of extractMIMETypeFromMediaType.
+
+ * platform/network/HTTPParsers.cpp:
+ (WebCore::extractMIMETypeFromMediaType):
+
+2009-03-05 Yong Li <yong.li@torchmobile.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24392
+ Do not get the current time for unless we're doing PRELOAD_DEBUG as this
+ can be unnecessarily expensive.
+
+ * html/PreloadScanner.cpp:
+ (WebCore::PreloadScanner::write):
+
+2009-03-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24327
+
+ When mapping points and hit testing through transforms, work
+ correctly when acclerated animations of transforms are running.
+
+ Tested by LayoutTests/animations/animation-hit-test-transform.html,
+ which only failed when ACCELERATED_COMPOSITING was turned on.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::currentTransform):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::transformFromContainer):
+
+2009-03-05 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24391
+ Frame.cpp uses JSC specific includes
+
+ * page/Frame.cpp:
+
+2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24389
+ WebKitGTK+ crashes when cancelling plugin loads
+
+ Remove bogus calls to the client's didFinishLoading method from
+ our ResourceHandle::cancel implementation. Calling
+ didFinishLoading here is mostly inoffensive for most loads, but
+ causes crashes when plugin loads are cancelled.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::cancel):
+
+2009-03-05 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * WebCore.vcproj/QTMovieWin.vcproj:
+
+2009-03-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
+ ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
+ protected by an #if and uses HTMLPlugInElement so it must be included.
+
+ * bindings/js/ScriptController.cpp:
+
+2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ GTK Build fix.
+
+ * inspector/ConsoleMessage.h: Use proper header.
+
+2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24376
+ Split InspectorController.cpp file into separate classes.
+
+ * GNUmakefile.am: Modified to include new files.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+ * inspector/ConsoleMessage.cpp: Added.
+ * inspector/ConsoleMessage.h: Added.
+ * inspector/InspectorController.cpp:
+ * inspector/InspectorDOMStorageResource.cpp: Added.
+ * inspector/InspectorDOMStorageResource.h: Added.
+ * inspector/InspectorDatabaseResource.cpp: Added.
+ * inspector/InspectorDatabaseResource.h: Added.
+ * inspector/InspectorResource.cpp: Added.
+ * inspector/InspectorResource.h: Added.
+
+2009-03-05 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24387
+ Remove media element bufferingRate attribute. No test necessary as there
+ were none for this attribute.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
+ (WebCore::HTMLMediaElement::loadInternal): Ditto.
+ (WebCore::HTMLMediaElement::setNetworkState): Ditto.
+ (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
+ * html/HTMLMediaElement.h: Remove m_bufferingRate.
+ * html/HTMLMediaElement.idl: Ditto.
+
+2009-03-05 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24377
+ [GTK] Comply better with coding style guidelines in ResourceHandleSoup
+
+ Use C++ booleans, 0 instead of NULL, prefix boolean variables with
+ 'is', do not use 'else if' if the previous if had a return, delete
+ trailing whitespace, etc.
+
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
+ (WebCore::fillResponseFromMessage):
+ (WebCore::restartedCallback):
+ (WebCore::finishedCallback):
+ (WebCore::parseDataUrl):
+ (WebCore::ensureSessionIsInitialized):
+ (WebCore::ResourceHandle::startHttp):
+ (WebCore::reportUnknownProtocolError):
+ (WebCore::ResourceHandle::start):
+ (WebCore::cleanupGioOperation):
+ (WebCore::closeCallback):
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+ (WebCore::ResourceHandle::startGio):
+
+2009-03-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=24328
+
+ If an element has backface-visibility: hidden, hit testing should not
+ hit the back sides of elements. Test for that by inverting the accumulated
+ transform and looking at the z vector.
+
+ Tested by transforms/3d/hit-testing/backface-hit-test.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-03-04 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ r41362 mistakenly added functions "RenderThemeWin::" into
+ RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
+ them to void return types. This patch switches them back to ints.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24360
+
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
+ (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
+ (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
+
+2009-03-04 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Chromium Linux: change some metrics to better match Windows after
+ r41416. Aesthetically this may be worse, but web-compat is king.
+
+ Also, the previous code had an off by one error when drawing
+ scrollbars which caused the scrollbar to overflow it's bounds by 1px
+ at the right and bottom edges.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24369
+
+ * rendering/RenderThemeChromiumLinux.cpp:
+ (WebCore::):
+ (WebCore::RenderThemeChromiumLinux::systemFont):
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromium::paintTrackPiece):
+
+2009-03-04 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add an ASSERT to better demonstrate the cause of the crash in
+ https://bugs.webkit.org/show_bug.cgi?id=23736
+
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::~DocLoader):
+
+2009-03-04 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
+ <https://bugs.webkit.org/show_bug.cgi?id=24337>
+
+ Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
+ http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
+
+ * loader/mac/ResourceLoaderMac.mm:
+ (WebCore::ResourceLoader::willCacheResponse):
+ An identifier is only asssigned if resource load callbacks are done. So don't send
+ willCacheResponse which uses identifier if resource load callbacks aren't being sent.
+
+2009-03-04 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
+ <https://bugs.webkit.org/show_bug.cgi?id=24330>
+
+ Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
+
+ * dom/ExceptionCode.cpp:
+ (WebCore::xmlHttpRequestExceptionNames):
+ Added missing ABORT_ERR whose absence caused an assert.
+
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
+ Add more logic to handle the termination case for sync xhr.
+
+2009-03-04 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24364
+ Add support for HTMLMediaElement canPlayType method. Make
+ MediaPlayer::supportsType take a ContentType instead of a
+ separate mime type and codecs parameter.
+
+ Test: media/video-can-play-type.html
+
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
+ (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
+ (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
+ (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
+ * html/HTMLMediaElement.h: Add prototype.
+ * html/HTMLMediaElement.idl: Ditto.
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
+ (WebCore::MediaPlayer::supportsType): Ditto.
+ * platform/graphics/MediaPlayer.h:
+
+2009-03-04 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24359
+ Repaint throttling mechanism
+
+ Excessive repainting can slow down page loadind. This implements a timer
+ based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
+ enabled by default.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::checkCompleted):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchDragEvent):
+ (WebCore::EventHandler::dispatchMouseEvent):
+ (WebCore::EventHandler::keyEvent):
+ (WebCore::EventHandler::handleTextInputEvent):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView):
+ (WebCore::FrameView::reset):
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::beginDeferredRepaints):
+ (WebCore::FrameView::endDeferredRepaints):
+ (WebCore::FrameView::checkStopDelayingDeferredRepaints):
+ (WebCore::FrameView::doDeferredRepaints):
+ (WebCore::FrameView::updateDeferredRepaintDelay):
+ (WebCore::FrameView::resetDeferredRepaintDelay):
+ (WebCore::FrameView::adjustedDeferredRepaintDelay):
+ (WebCore::FrameView::deferredRepaintTimerFired):
+ (WebCore::FrameView::paintContents):
+ * page/FrameView.h:
+
+2009-03-04 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Antti Koivisto.
+
+ Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::haveStylesheetsLoaded):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::scriptHandler):
+ * loader/Cache.cpp:
+ (WebCore::Cache::requestResource):
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::checkNotify):
+ * loader/DocLoader.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::FrameLoader):
+ (WebCore::FrameLoader::requestFrame):
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::begin):
+ (WebCore::FrameLoader::write):
+ (WebCore::FrameLoader::endIfNotLoadingMainResource):
+ (WebCore::FrameLoader::checkCompleted):
+ (WebCore::FrameLoader::requestObject):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+
+2009-03-02 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24287
+ [GTK] Move auth dialog feature to WebKit/
+
+ Remove WebKitSoupAuthDialog files from build and stop using it.
+
+ * GNUmakefile.am:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ensureSessionIsInitialized):
+ * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
+ * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
+
+2009-03-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24361
+
+ Reinstate code that sets result.innerNode when hitTest() returns true,
+ but never filled in the innerNode. Fixes hit testing of generated content.
+
+ Test: fast/css-generated-content/hit-test-generated-content.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestContents):
+
+2009-03-04 Adam Barth <abath@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24356
+
+ Fix WebKit style for allowUniversalAccessFromFileURLs.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::initSecurityContext):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
+ * page/Settings.h:
+ (WebCore::Settings::allowUniversalAccessFromFileURLs):
+
+2009-03-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
+
+ I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
+ consolidated some of the various decision making pieces of the Cache into the new method
+ FrameLoader::cachePolicy().
+
+ Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
+ is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
+ same URL for this image every time and expects it to be reloaded with each new card.
+
+ The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
+ is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
+ condition for returning CachePolicyReload.
+
+2009-03-04 Timothy Hatcher <timothy@apple.com>
+
+ * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
+ "LOCAL STORAGE" and "SESSION STORAGE".
+
+2009-03-04 Timothy Hatcher <timothy@apple.com>
+
+ Fix a regression where the Web Inspector console would not animate
+ in or out correctly.
+
+ Reviewed by Anders Carlsson.
+
+ * inspector/front-end/inspector.css: Move a z-index to a child element
+ to get the correct stacking order during the animation.
+
+2009-03-03 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
+
+ Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
+ the final position against the y position estimate until after the clear has happened. This gets rid
+ of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
+
+ Reviewed by Dan Bernstein
+
+ Added fast/block/float/nested-clearance.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::estimateVerticalPosition):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::getClearDelta):
+ * rendering/RenderBlock.h:
+
+2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
+
+ Reviewed by Simon Hausmann.
+
+ Improvement to 3d transformations rendering in QtWebKit. QTransform is used
+ instead of QMatrix. This allows perspective transformations since QTransform is
+ a true 3x3 matrix.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
+ (WebCore::GraphicsContext::getCTM):
+ (WebCore::GraphicsContext::restorePlatformState):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::translate):
+ (WebCore::GraphicsContext::rotate):
+ (WebCore::GraphicsContext::scale):
+ (WebCore::GraphicsContext::concatCTM):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::Image::drawPattern):
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::Path::translate):
+ (WebCore::Path::transform):
+ * platform/graphics/qt/PatternQt.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * platform/graphics/qt/TransformationMatrixQt.cpp:
+ (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
+ to QMatrix with one to QTransform.
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * platform/graphics/qt/FontQt.cpp:
+
+2009-02-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24151
+ Fix Qt/S60 build break
+
+ * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
+ * platform/qt/FileSystemQt.cpp: Ditto
+ (WebCore::unloadModule):
+
+2009-03-03 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21939
+ Uninitialized ExceptionCode in DOMWindow::postMessage
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::postMessage):
+
+2009-03-03 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
+
+ Reviewed by Mark Rowe.
+
+ The fix is to add INSTALLHDRS_COPY_PHASE = YES and
+ INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
+ sure various build phase scripts work with the installhdrs build
+ phase.
+
+ * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
+ based on PLATFORM_NAME to work around the missing definition on
+ Tiger.
+ * Configurations/WebCore.xcconfig: Added
+ JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
+ the "Generate Derived Sources" script. Added
+ INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ - Added shell code to prevent running "Check For Global
+ Initializers", "Check For Exit Time Destructors" and "Check
+ For Weak VTables" scripts during the installhdrs build phase.
+ - Made "Generate Derived Sources" work for the installhdrs build
+ phase. Also simplified setting of CREATE_HASH_TABLE by using
+ JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
+
+2009-03-02 Adam Langley <agl@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Chromium Linux: Switch to using Skia to render widgets.
+
+ In order to sandbox the Chromium renderer on Linux we need to remove
+ the X connection. GTK cannot render without an X connection so, for
+ now, we render widgets ourselves.
+
+ Previously didn't use anti-alias fonts in order to match Windows font
+ rendering exactly. This was helpful when bootstrapping our layout
+ tests. Now, however, we are ready to enable it.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24244
+
+ * platform/chromium/ScrollbarThemeChromium.cpp:
+ (WebCore::ScrollbarThemeChromium::buttonSize):
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromium::scrollbarThickness):
+ (WebCore::ScrollbarThemeChromium::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromium::paintButton):
+ (WebCore::ScrollbarThemeChromium::paintThumb):
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp:
+ (WebCore::FontPlatformData::setupPaint):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::PlatformContextSkia):
+ (PlatformContextSkia::~PlatformContextSkia):
+ * platform/graphics/skia/PlatformContextSkia.h:
+ * rendering/RenderThemeChromiumGtk.cpp: Removed.
+ * rendering/RenderThemeChromiumGtk.h: Removed.
+ * rendering/RenderThemeChromiumLinux.cpp: Added.
+ * rendering/RenderThemeChromiumLinux.h: Added.
+
+2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24261
+ Fix return types.
+
+ Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
+
+ * bindings/v8/V8Binding.h:
+ (WebCore::toInt32): change return type to int
+ (WebCore::toFloat): change return type to float.
+
+2009-03-03 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by John Sullivan.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22884
+ <rdar://problem/6449783>
+ modified layout test crashes Safari
+
+ Null check NPStream before dereferencing it.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::destroyStream):
+
+2009-03-03 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Fix for <rdar://problem/6641045>
+ Don't call QTKit to get movie properties until movie metadata has been loaded.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
+ (WebCore::MediaPlayerPrivate::play): Ditto.
+ (WebCore::MediaPlayerPrivate::pause): Ditto.
+ (WebCore::MediaPlayerPrivate::duration): Ditto.
+ (WebCore::MediaPlayerPrivate::currentTime): Ditto.
+ (WebCore::MediaPlayerPrivate::seek): Ditto.
+ (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
+ (WebCore::MediaPlayerPrivate::paused): Ditto.
+ (WebCore::MediaPlayerPrivate::seeking): Ditto.
+ (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
+ (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
+ (WebCore::MediaPlayerPrivate::setVolume): Ditto.
+ (WebCore::MediaPlayerPrivate::setRate): Ditto.
+ (WebCore::MediaPlayerPrivate::dataRate): Ditto.
+ (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
+ (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
+
+2009-03-03 Kevin McCullough <kmccullough@apple.com>
+
+ - Spelling fix.
+
+ * page/Console.cpp:
+ (WebCore::Console::profile):
+
+2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23657
+ Remove Database API callback IDLs from the project.
+ They were removed in r40633.
+
+ * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
+
+2009-03-03 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6639110> console.profile() doesn't work without a title
+
+ * page/Console.cpp:
+ (WebCore::Console::profile): If there is no title assume this is a user
+ initiated profile and give it the next incremented title name.
+
+2009-03-03 Timothy Hatcher <timothy@apple.com>
+
+ Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
+ the console code and refactored things to have fewer code paths and duplication.
+
+ rdar://problem/6367127
+ https://bugs.webkit.org/show_bug.cgi?id=24329
+
+ Reviewed by Kevin McCullough.
+
+ Test: manual-tests/inspector/console-dir.html
+
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
+ to fix an ASSERT about using a wrapper from the wrong ExecState.
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
+ (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
+ When forceObjectFormat is true, the only formatter used is _formatobject.
+ (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
+ (WebInspector.Console.prototype._formatstring): Ditto.
+ (WebInspector.Console.prototype._formatregexp): Ditto.
+ (WebInspector.Console.prototype._formatarray): Ditto.
+ (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
+ (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
+ (WebInspector.Console.prototype._formaterror): Remove the inline argument.
+ (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
+ simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
+ (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
+ (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
+ (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
+ (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
+ * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
+ * inspector/front-end/utilities.js:
+ (Object.type): Return "node" for Node objects.
+ (Object.describe): Handle the "node" type.
+ * page/Console.cpp:
+ (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
+ (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
+ * page/Console.h:
+ (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
+
+2009-03-03 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24325
+ Crash on replacing document contents during drop.
+
+ Makes sure a node is in the document during a move before using it.
+
+ Test: fast/events/crash-on-mutate-during-drop.html
+
+ * editing/MoveSelectionCommand.cpp:
+ (WebCore::MoveSelectionCommand::doApply):
+
+2009-03-03 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23028
+ Enable dynamic web font support to Chromium on Windows.
+ Files that were omitted by mistake in the latest patch
+ that was landed.
+
+ * loader/CachedFont.cpp:
+ (WebCore::CachedFont::~CachedFont):
+ (WebCore::CachedFont::ensureCustomFontData):
+ (WebCore::CachedFont::platformDataFromCustomData):
+ (WebCore::CachedFont::allClientsRemoved):
+ * platform/graphics/chromium/FontCustomPlatformData.cpp:
+ (WebCore::EOTStream::EOTStream):
+ (WebCore::createFontCustomPlatformData):
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::EOTStream::EOTStream):
+ (WebCore::createFontCustomPlatformData):
+
+2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16826
+ [Gtk] Implement WebKitDownload
+
+ Make the Soup backend able to handle requests without a frame,
+ since we may have such things now that we support downloads.
+
+ * platform/network/ResourceHandleInternal.h:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::start):
+
+2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24331
+ Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
+
+ * bindings/v8/custom/V8AttrCustom.cpp: Added.
+ * bindings/v8/custom/V8CustomBinding.cpp: Added.
+ * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
+ * bindings/v8/custom/V8ElementCustom.cpp: Added.
+ * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
+ * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
+
+2009-03-03 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6616664> - Quick looks of various file types is broken
+
+ In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
+ for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
+ overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
+
+ Partially reverted behavior to always set the mainDocumentURL in situations when we would've
+ before that patch.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::setMainDocumentURL):
+
+2009-03-03 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24256
+
+ Added a WebCoreForceSoftwareAnimation flag.
+
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::forceSoftwareAnimation):
+ (WebCore::GraphicsLayerCA::setOpacity):
+ (WebCore::GraphicsLayerCA::animateTransform):
+ (WebCore::GraphicsLayerCA::animateFloat):
+
+2009-03-02 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24257
+
+ Added prototype properties for several classes with constructors that
+ were missing them, including the one mentioned in the bug.
+
+ Test: fast/dom/Window/custom-constructors.html
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseWebKitCSSMatrix):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
+ (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
+ * bindings/js/JSWebKitCSSMatrixConstructor.h:
+ * bindings/js/JSWebKitPointConstructor.cpp:
+ (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
+ * bindings/js/JSWorkerConstructor.cpp:
+ (WebCore::JSWorkerConstructor::JSWorkerConstructor):
+
+2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24321
+ Add V8 bindings headers.
+
+ * bindings/v8/V8Binding.h: Added.
+ * bindings/v8/V8Proxy.h: Added.
+ * bindings/v8/custom/V8CustomBinding.h: Added.
+ * bindings/v8/custom/V8CustomEventListener.h: Added.
+
+2009-03-03 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23803
+ Fix an 'off-by-1' error in ChromiumWin's font fallback.
+
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+
+2009-03-03 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ http://bugs.webkit.org/show_bug.cgi?id=23028
+ Enable dynamic web font support to Chromium on Windows: Part 1
+ - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
+ from platform/graphics/win because both Windows port and Chromium Windows
+ port will use them.
+ - Adjust WebCore.vcproj accordingly.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/graphics/opentype: Added.
+ * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
+ * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
+ * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
+ * platform/graphics/win/OpenTypeUtilities.h: Removed.
+
+2009-03-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24312
+
+ Take 3D transforms into account when hit testing:
+
+ 1. Maintain a bit on each RenderLayer that is set when the layer
+ has 3d descendants, so that we know when to fall into the slow
+ hit testing path.
+
+ 2. Make a ref-counted HitTestingTransformState, which is used to store
+ an accumulated transform, and the hit test point, and hitTestRect
+ in the plane of the ancestor non-3d ('flattening') layer.
+
+ It's ref-counted so we can heap allocate it (to avoid stack bloat),
+ and avoid copying when hitTestLayer calls itself after applying the transform.
+
+ 3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
+ 3D transforms, or to do deep depth-testing when traversing a preserves-3d
+ hierarchy. When hit, layers compute a z-offset from the ancestor flattening
+ layer, which allows for correct depth testing.
+
+ The existing early-return codepath is unaffected when there are no 3d transforms
+ and no preserve-3d.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
+ (WebCore::RenderLayer::update3DTransformedDescendantStatus):
+ (WebCore::RenderLayer::hitTest):
+ (WebCore::computeZOffset):
+ (WebCore::RenderLayer::createLocalTransformState):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::hitTestContents):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::preserves3D):
+ (WebCore::RenderLayer::has3DTransform):
+ (WebCore::RenderLayer::setHas3DTransformedDescendant):
+ (WebCore::RenderLayer::has3DTransformedDescendant):
+ * rendering/RenderLayerBacking.cpp:
+ * rendering/TransformState.cpp:
+ (WebCore::TransformState::flatten):
+ (WebCore::TransformState::mappedPoint):
+ (WebCore::HitTestingTransformState::move):
+ (WebCore::HitTestingTransformState::applyTransform):
+ (WebCore::HitTestingTransformState::flatten):
+ (WebCore::HitTestingTransformState::mappedPoint):
+ (WebCore::HitTestingTransformState::mappedQuad):
+ * rendering/TransformState.h:
+ (WebCore::TransformState::TransformState):
+ (WebCore::HitTestingTransformState::create):
+ (WebCore::HitTestingTransformState::move):
+ (WebCore::HitTestingTransformState::HitTestingTransformState):
+
+2009-03-03 Brett Wilson <brettw@chromium.org>
+
+ Fix uninitialized memory reads in the Chromium Windows transparency
+ code that were identified by Purify,
+
+ Reviewed by Darin Fisher.
+
+ * platform/graphics/chromium/TransparencyWin.cpp:
+ (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
+ (WebCore::TransparencyWin::initializeNewContext):
+
+2009-03-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24312
+
+ Factor the code that compute a transform relative to the container
+ into RenderObject::transformFromContainer().
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToAbsolutePoint):
+ (WebCore::RenderBox::mapAbsoluteToLocalPoint):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::transformFromContainer):
+ * rendering/RenderObject.h:
+
+2009-03-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24317
+
+ Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
+ the superclass found a node, otherwise we set the innerNode of the
+ HitTestResult, but don't actually report that we found a hit.
+
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::nodeAtPoint):
+
+2009-03-03 Onne Gorter <onne.gorter@avinity.net>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23707
+ resizing plugins does not work, because the plugin never gets informed
+
+ Make gtk plugins resize correctly, by sending them the setwindow event
+ correctly. Also ensure that all plugin eventing is done with correct
+ locking/calling. Mostly copied from mac implementation.
+
+ manual test: manual-tests/gtk/plugin-resize-scroll.html
+
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::dispatchNPEvent):
+ ensure locking/calling for NPEvents
+ (WebCore::PluginView::updatePluginWidget):
+ if something changed, let setNPWindowIfNeeded handle it
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ ensure calling conventions
+ (WebCore::PluginView::setNPWindowRect):
+ just pass control to setNPWindowIfNeeded
+ (WebCore::PluginView::setNPWindowIfNeeded):
+ event the plugin correctly of new window
+ (WebCore::PluginView::init):
+ init through the new setup
+
+2009-03-03 Mike Belshe <mike@belshe.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24311
+ Make IDL returning DOMObject use [V8Custom]
+
+ * dom/Document.idl:
+ * html/HTMLCanvasElement.idl:
+
+2009-03-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson
+
+ https://bugs.webkit.org/show_bug.cgi?id=24313
+
+ If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
+ HitTestResult, then it had better well return |true|. And m_innerBlock
+ could never have been set as the hit node by the superclass, because
+ the superclass knows nothing about m_innerBlock.
+
+ Test: fast/forms/input-hit-test-border.html
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+
+2009-03-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Enable Geolocation (except on Tiger and Leopard).
+
+ * Configurations/WebCore.xcconfig:
+
+2009-03-02 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=24307
+ Null out m_highlightedNode on hideHighlight().
+ Ran WebCore/manual-tests/inspector/highlight-nodes.html.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::hideHighlight):
+
+2009-03-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for <rdar://problem/6507404> Add Geolocation support.
+
+ This is not yet turned on for any Mac platform.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::shouldAllowGeolocationForFrame):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::Geolocation):
+ (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
+ will not be alive at this point.
+ (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
+ return a PERMISSION_DENIED if not.
+ (WebCore::Geolocation::watchPosition): Ditto.
+ (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
+ to allow geolocation and cache the result.
+ * page/Geolocation.h:
+ (WebCore::Geolocation::):
+ * platform/GeolocationService.cpp:
+ * platform/GeolocationService.h:
+ (WebCore::GeolocationService::~GeolocationService):
+ (WebCore::GeolocationService::stopUpdating):
+ * platform/mac/GeolocationServiceMac.h: Added.
+ (WebCore::GeolocationServiceMac::lastPosition):
+ (WebCore::GeolocationServiceMac::lastError):
+ * platform/mac/GeolocationServiceMac.mm: Added.
+ (WebCore::GeolocationService::create):
+ (WebCore::GeolocationServiceMac::GeolocationServiceMac):
+ (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
+ (WebCore::GeolocationServiceMac::startUpdating):
+ (WebCore::GeolocationServiceMac::stopUpdating):
+ (WebCore::GeolocationServiceMac::suspend):
+ (WebCore::GeolocationServiceMac::resume):
+ (WebCore::GeolocationServiceMac::positionChanged):
+ (WebCore::GeolocationServiceMac::errorOccurred):
+ (-[WebCoreCoreLocationObserver initWithCallback:]):
+ (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
+ (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
+
+2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
+
+ Build fixes for wxWidgets Mac trunk build.
+
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+ (GetTextExtent):
+ * webcore-wx.bkl:
+
+2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
+
+ wxGTK missing header build fix.
+
+ * platform/wx/wxcode/gtk/fontprops.cpp:
+
+2009-03-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21811
+ REGRESSION: Windows Build Not Selecting Proper Font
+
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::createGDIFont): Added back code to verify that the created
+ HFONT has the requested face name.
+
+2009-03-02 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a regression caused by splitting the input and output of console commands.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24293
+
+ Reviewed by Kevin McCullough.
+
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
+ normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
+
+2009-03-02 Timothy Hatcher <timothy@apple.com>
+
+ Make exception messages and logged Error objects display consistently.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18983
+
+ Reviewed by Adam Roben.
+
+ * English.lproj/localizedStrings.js: Remove a string for line numbers.
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
+ boolean to the ConsoleCommandResult constructor and don't pass level.
+ (WebInspector.Console.prototype._formatnode): Fix a className typo.
+ (WebInspector.Console.prototype._formaterror): Add an error-message
+ classed span around the message to show in red and remove the
+ console-message-url class from the link so it doesn't float right.
+ Instead enclose the link in parentheses and use displayNameForURL
+ to shorten the URL in the link.
+ (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
+ how line numbers are shown since link underlining a string with
+ parentheses looks bad.
+ (WebInspector.ConsoleCommandResult): Take an exception boolean flag
+ instead of a level and get line and URL based on that flag.
+ * inspector/front-end/inspector.css: Tweaks to the styles.
+
+2009-03-02 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ Bug 24048: extra windows button padding doesn't apply when there's no appearance
+ <https://bugs.webkit.org/show_bug.cgi?id=24048>
+
+ Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
+
+ No tests added as existing tests already cover this behavior.
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::setupInnerStyle):
+ * rendering/RenderTheme.cpp:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::buttonInternalPaddingLeft):
+ (WebCore::RenderTheme::buttonInternalPaddingRight):
+ (WebCore::RenderTheme::buttonInternalPaddingTop):
+ * rendering/RenderThemeChromiumGtk.cpp:
+ (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeWin::buttonInternalPaddingRight):
+ (WebCore::RenderThemeWin::buttonInternalPaddingTop):
+ (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
+ * rendering/RenderThemeChromiumGtk.h:
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
+ (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
+ (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
+ * rendering/RenderThemeChromiumWin.h:
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
+ (WebCore::RenderThemeWin::buttonInternalPaddingRight):
+ (WebCore::RenderThemeWin::buttonInternalPaddingTop):
+ (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
+ * rendering/RenderThemeWin.h:
+
+2009-03-02 Adam Treat <adam.treat@torchmobile.com>
+
+ Build fix for Qt port. Remove unnecessary assert.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::putImageData):
+
+2009-03-02 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24227
+ Ensure that the checkForSolidColor() optimization is correctly triggered
+ for all cases of drawPattern. Currently, the optimization was not triggered
+ when the check had not been previously performed via a request for the
+ image's NativeImagePtr.
+
+ Implement the Qt version of the checkForSolidColor() method. Combined with
+ the bug fix this reduces the time it takes to draw a repeating background
+ of a 1x1 image from ~50msecs to ~0msecs on my machine.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::BitmapImage::mayFillWithSolidColor):
+ * platform/graphics/Image.h:
+ (WebCore::Image::mayFillWithSolidColor):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-03-02 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed build fix; adding missing files to EXTRA_DIST, so that
+ they show up in the tarball.
+
+ * GNUmakefile.am:
+
+2009-03-02 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ Added putImageData to Qt. Discussed with Ariya Hidayat.
+
+ [Qt] lacks putImageData support in Canvas
+ https://bugs.webkit.org/show_bug.cgi?id=22186
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::putImageData):
+
+2009-03-02 Timothy Hatcher <timothy@apple.com>
+
+ Show exception messages again when evaluating bad expressions in the
+ Web Inspector's console.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19890
+
+ Reviewed by Oliver Hunt.
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
+ Fix the order in which the exception is set and cleared now that the
+ exception is stored in the shared GlobalData, not per ExecState.
+
+2009-02-28 Timothy Hatcher <timothy@apple.com>
+
+ Make input in the Web Inspector console print before any output
+ that might be added by the called function.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19931
+
+ Reviewed by Oliver Hunt.
+
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype._enterKeyPressed): Add the command
+ message before evaluating the result. Associate the originating
+ command to the result, so if they are adjacent there is no divider.
+ (WebInspector.ConsoleCommand): No longer take a result.
+ (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
+ code removed since it isn't used now.
+ (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
+ (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
+ Call the ConsoleMessage toMessageElement and add a style class.
+ * inspector/front-end/inspector.css: Add a new style class for
+ adjacent results to hide the divider. Also tweak the position of
+ the disclosure triangle for objects to not use the left margin.
+
+2009-03-01 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
+ <https://bugs.webkit.org/show_bug.cgi?id=24282>
+
+ When fetching an array of elements with a range, attachment views need to be returned
+ instead of the actual attachment.
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
+
+2009-03-01 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
+ <https://bugs.webkit.org/show_bug.cgi?id=24251>
+
+ Make RenderObject::positionForCoordinate non-virtual and
+ RenderObject::positionForPoint virtual in preparation for
+ removing positionFor* from RenderObject/RenderText.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::visiblePositionForPoint):
+ * rendering/RenderBR.cpp:
+ (WebCore::RenderBR::positionForPoint):
+ * rendering/RenderBR.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::positionForPoint):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionForPoint):
+ * rendering/RenderBox.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::positionForPoint):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::positionForCoordinates):
+ (WebCore::RenderObject::positionForPoint):
+ * rendering/RenderObject.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::positionForPoint):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::positionForPoint):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::positionForPoint):
+ * rendering/RenderText.h:
+
+2009-03-01 Larry Ewing <lewing@novell.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24080
+ NPN_GetValue casting to the wrong type and writing outside bounds
+
+ Make sure to cast the value to the correct type so that only
+ memory owned by the value is written to.
+
+ * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
+ * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
+ * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic):
+ (PluginView::getValue):
+
+2009-03-01 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24197 and
+ https://bugs.webkit.org/show_bug.cgi?id=23512
+
+ The Windows version of cgColor() is conditionally compiled using
+ !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
+ can use the OS X version instead of the Windows version.
+
+ Also rename cgColor() -> createCGColor()
+
+ No observable change in behavior, so no test.
+
+ * platform/graphics/Color.h:
+ * platform/graphics/cg/ColorCG.cpp:
+ (WebCore::createCGColor):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::setPlatformShadow):
+ * platform/graphics/mac/ColorMac.mm:
+ (WebCore::createCGColor):
+ * platform/graphics/mac/GraphicsContextMac.mm:
+ (WebCore::GraphicsContext::drawFocusRing):
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::setLayerBorderColor):
+ (WebCore::setLayerBackgroundColor):
+ (WebCore::GraphicsLayerCA::setBackgroundColor):
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ (WebCore::GraphicsContext::drawFocusRing):
+ * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
+ (WebCore::ciColor):
+
+2009-03-01 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24271: XMLHttpRequest needs js bindings for Workers.
+ <https://bugs.webkit.org/show_bug.cgi?id=24271>
+
+ Tests: http/tests/xmlhttprequest/workers/methods-async.html
+ http/tests/xmlhttprequest/workers/methods.html
+
+ * bindings/js/JSWorkerContextBase.cpp:
+ (WebCore::JSWorkerContextBase::getOwnPropertySlot):
+ (jsWorkerContextBaseXMLHttpRequest):
+ (setJSWorkerContextBaseXMLHttpRequest):
+ Expose XMLHttpRequest to Workers.
+
+ * bindings/js/JSWorkerContextBase.h:
+
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ (WebCore::constructXMLHttpRequest):
+ (WebCore::JSXMLHttpRequestConstructor::mark):
+ Removed the dependencies on Document.
+
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
+ * dom/EventException.idl:
+ * dom/EventListener.idl:
+ Change to have the NoStaticTables attribute since they are used from XHR.
+
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::workerContextDidFinishLoading):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
+ Fixed identifier to be unsigned long.
+
+ * loader/WorkerThreadableLoader.h:
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::workerThread):
+ Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
+
+ * xml/XMLHttpRequestUpload.cpp:
+
+ * xml/XMLHttpRequest.idl:
+ * xml/XMLHttpRequestException.idl:
+ * xml/XMLHttpRequestProgressEvent.idl:
+ * xml/XMLHttpRequestUpload.idl:
+ Change to have the NoStaticTables attribute since they are used from XHR.
+
+2009-03-01 Horia Olaru <olaru@adobe.com>
+
+ Adding manual debugger test cases for bug.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21073
+
+ Reviewed by Kevin McCullough.
+
+ * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
+ * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
+ * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
+ * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
+ * manual-tests/inspector/resources/loop-statements.js: Added.
+
+2009-03-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
+
+ Test: fast/events/scroll-during-zoom-change.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle): Pause scheduled events during style
+ reclaculation. Changes to the zoom property result in scroll events
+ being generated during style recalc, and those events need to be
+ deferred until the render tree is consistent.
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout): Changed to account for a case in which the
+ post-layout tasks trigger a nested layout, which reactivates the
+ post-layout task timer.
+
+2009-03-01 Ross Boucher <rboucher@gmail.com>
+
+ Alphabetically sort scripts in the Script's panel file popup menu.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23395
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
+ * inspector/front-end/utilities.js:
+ (insertionIndexForObjectInListSortedByFunction):
+ (indexOfObjectInListSortedByFunction):
+
+2009-03-01 Yael Aharon <yael.aharon@nokia.com>
+
+ Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
+ when creating databases, localStorage or sessionStorage. Changing document.domain
+ should have no affect on databases, localStorage and sessionStorage in Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23844
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::addDOMStorageScriptResource):
+ (WebCore::InspectorController::didUseDOMStorage):
+ * storage/Database.cpp:
+ (WebCore::Database::openDatabase):
+
+2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Avoid leaking errors when reporting GIO errors.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+
+2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Fixes crash when the GIO backend is given the URI for a directory.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::networkErrorForFile):
+
+2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24261
+ Fix V8 custom binding scrubbing error.
+
+ Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
+ Test: traversal/exception-forwarding.html
+ TesT: traversal/stay-within-root.html
+
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+ * bindings/v8/custom/V8NodeIteratorCustom.cpp:
+ (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
+ * bindings/v8/custom/V8TreeWalkerCustom.cpp:
+ (WebCore::toV8): Ditto.
+
+2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24261
+ Fix V8 custom binding scrubbing error.
+
+ Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+ (WebCore::cssPropertyName): Remove dubious checks, left over from
+ incomplete conversion of parameter from pointer to pass-by-ref.
+ (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
+ (WebCore::NAMED_PROPERTY_SETTER): Ditto.
+
+2009-02-28 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24263
+ [GTK] ref ResourceHandle until we are finished with it
+
+ Add a ref to the ResourceHandle in startHttp so we can keep it
+ alive untill all callbacks have been executed, and unref it when
+ soup tells us it's done with the SoupMessage (in
+ finishedCallback). Fixes a number of crashes when calling
+ didReceiveData whould crash because of the handle dying.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::finishedCallback):
+ (WebCore::ResourceHandle::startHttp):
+
+2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24226
+ [SOUP] HTTP status text is never set
+
+ Set HTTP status text to SoupMessage reason_phrase.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::fillResponseFromMessage):
+
+2009-02-28 Dan Bernstein <mitz@apple.com>
+
+ - fix malformed project file
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-02-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=23848
+ <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
+
+ Test: fast/layers/inline-dirty-z-order-lists.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
+ layer's and its stacking context's z-order lists when the layer's
+ z-index or visibility change from here...
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
+ it will apply to RenderInline too.
+
+2009-02-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Don't include TextResourceDecoder.h in Document.h
+
+ This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
+ when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
+
+ * dom/Document.cpp:
+ (WebCore::Document::displayStringModifiedByEncoding):
+ (WebCore::Document::displayBufferModifiedByEncoding):
+ * dom/Document.h:
+ * WebCore.base.exp:
+
+2009-02-27 Matt Pennig <pennig@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
+ "Fixed elements have 0 as an offsetLeft property"
+
+ Code also brings offsetLeft/Top in full conformance with the spec.
+ Added two tests, one for fixed-position elements, and one for <html>.
+
+ Tests: fast/dom/Element/fixed-position-offset-parent.html
+ fast/dom/Element/offsetLeft-offsetTop-html.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::offsetLeft):
+ (WebCore::RenderBoxModelObject::offsetTop):
+
+2009-02-27 Dean Jackson <dino@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ renderer()->hasTransform() returns true for elements
+ with perspective, but no transform, so test for transform
+ when hit testing. This fixes ASSERT from
+ https://bugs.webkit.org/show_bug.cgi?id=24252
+
+ Test: transforms/no_transform_hit_testing.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+
+2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Fix scrubbing error -- a reversed condition.
+
+ * bindings/v8/ScriptValue.h:
+ (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
+
+2009-02-27 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add confirmMessageFromWorkerObject to WorkerObjectProxy.
+ https://bugs.webkit.org/show_bug.cgi?id=24152
+
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerContextTask::performTask):
+ (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
+ * workers/WorkerMessagingProxy.h:
+ * workers/WorkerObjectProxy.h:
+
+2009-02-27 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
+ because it leads to assertion failures in the Mac port.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::BitmapImage::mayFillWithSolidColor):
+ * platform/graphics/Image.h:
+ (WebCore::Image::mayFillWithSolidColor):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-02-27 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20249
+
+ Add a preference to allow universal access from local URLs to mitigate
+ some attacks. Some clients still want to allow this access, so we
+ expose this as a preference.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::initSecurityContext):
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::SecurityOrigin):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
+ * page/Settings.h:
+ (WebCore::Settings::allowUniversalAccessFromFileUrls):
+
+2009-02-27 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24229
+ If an image has no alpha channel there is no reason to use SourceOver.
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::Image::drawPattern):
+ (WebCore::BitmapImage::draw):
+
+2009-02-27 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Eric Seidel and Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24227
+ Ensure that the checkForSolidColor() optimization is correctly triggered
+ for all cases of drawPattern. Currently, the optimization was not triggered
+ when the check had not been previously performed via a request for the
+ image's NativeImagePtr.
+
+ Implement the Qt version of the checkForSolidColor() method. Combined with
+ the bug fix this reduces the time it takes to draw a repeating background
+ of a 1x1 image from ~50msecs to ~0msecs on my machine.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::BitmapImage::mayFillWithSolidColor):
+ * platform/graphics/Image.h:
+ (WebCore::Image::mayFillWithSolidColor):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::checkForSolidColor):
+
+2009-02-27 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Zack Rusin.
+
+ Added support for gradients and pattern on Fonts for Qt.
+
+ [Qt] gradients and patterns for FontQt
+ https://bugs.webkit.org/show_bug.cgi?id=24243
+
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::Font::drawComplexText):
+
+2009-02-27 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
+ https://bugs.webkit.org/show_bug.cgi?id=24113
+
+ * workers/WorkerMessagingProxy.cpp:
+
+2009-02-27 Yael Aharon <yael.aharon@nokia.com>
+
+ Added a refresh button to storage views.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24040
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/DOMStorageItemsView.js:
+ (WebInspector.DOMStorageItemsView):
+ (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
+ (WebInspector.DOMStorageItemsView.prototype.update):
+ (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
+ * inspector/front-end/DatabaseTableView.js:
+ (WebInspector.DatabaseTableView):
+ (WebInspector.DatabaseTableView.prototype.get statusBarItems):
+ (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
+ * inspector/front-end/DatabasesPanel.js:
+ (WebInspector.DatabasesPanel):
+ (WebInspector.DatabasesPanel.prototype.get statusBarItems):
+ (WebInspector.DatabasesPanel.prototype.reset):
+ (WebInspector.DatabasesPanel.prototype.showDatabase):
+ (WebInspector.DatabasesPanel.prototype.showDOMStorage):
+ (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
+ * inspector/front-end/inspector.css:
+
+2009-02-27 Yael Aharon <yael.aharon@nokia.com>
+
+ Added support for editing/deleting localStorage and sessionStorage items
+ directly from Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23866.
+
+ Reviewed by Timothy Hatcher.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/front-end/DOMStorageDataGrid.js: Added.
+ (WebInspector.DOMStorageDataGrid):
+ (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
+ (WebInspector.DOMStorageDataGrid.prototype._startEditing):
+ (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
+ (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
+ (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
+ * inspector/front-end/DOMStorageItemsView.js:
+ (WebInspector.DOMStorageItemsView):
+ (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
+ (WebInspector.DOMStorageItemsView.prototype.hide):
+ (WebInspector.DOMStorageItemsView.prototype.update):
+ (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
+ * inspector/front-end/DatabasesPanel.js:
+ (WebInspector.DatabasesPanel):
+ (WebInspector.DatabasesPanel.prototype.get statusBarItems):
+ (WebInspector.DatabasesPanel.prototype.reset):
+ (WebInspector.DatabasesPanel.prototype.showDOMStorage):
+ (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
+ (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/inspector.html:
+
+2009-02-26 Brett Wilson <brettw@chromium.org>
+
+ Fix Windows transparency for the Chromium port. Implement a helper
+ class for handling transparency on Windows. It allows semitransparent
+ ClearType and semitransparent form controls by making new layers in the
+ background.
+
+ It also replaces the "ThemeHelper" which allows better
+ scaling and transforms on Windows form controls. In addition to the
+ functionality that the ThemeHelper did, but additionally handles the
+ antialiasing properly so that the form controls aren't composited on a
+ white square.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24101
+
+ Reviewed by Eric Seidel.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
+ (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
+ * platform/graphics/chromium/ThemeHelperChromiumWin.h:
+ * platform/graphics/chromium/TransparencyWin.cpp: Added.
+ (WebCore::):
+ (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
+ (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
+ (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
+ (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
+ (WebCore::TransparencyWin::TransparencyWin):
+ (WebCore::TransparencyWin::~TransparencyWin):
+ (WebCore::TransparencyWin::init):
+ (WebCore::TransparencyWin::computeLayerSize):
+ (WebCore::TransparencyWin::setupLayer):
+ (WebCore::TransparencyWin::setupLayerForNoLayer):
+ (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
+ (WebCore::TransparencyWin::setupLayerForTextComposite):
+ (WebCore::TransparencyWin::setupLayerForWhiteLayer):
+ (WebCore::TransparencyWin::setupTransform):
+ (WebCore::TransparencyWin::setupTransformForKeepTransform):
+ (WebCore::TransparencyWin::setupTransformForUntransform):
+ (WebCore::TransparencyWin::setupTransformForScaleTransform):
+ (WebCore::TransparencyWin::setTextCompositeColor):
+ (WebCore::TransparencyWin::initializeNewContext):
+ (WebCore::TransparencyWin::compositeOpaqueComposite):
+ (WebCore::TransparencyWin::compositeTextComposite):
+ (WebCore::TransparencyWin::makeLayerOpaque):
+ * platform/graphics/chromium/TransparencyWin.h: Added.
+ (WebCore::TransparencyWin::):
+ (WebCore::TransparencyWin::context):
+ (WebCore::TransparencyWin::platformContext):
+ (WebCore::TransparencyWin::drawRect):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::endTransparencyLayer):
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::paintSkBitmap):
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::):
+ (WebCore::RenderThemeChromiumWin::paintButton):
+ (WebCore::RenderThemeChromiumWin::paintMenuList):
+ (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
+
+2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24211
+ Add ScheduledAction for V8.
+
+ * bindings/v8/ScheduledAction.cpp: Added.
+ (WebCore::ScheduledAction::ScheduledAction):
+ (WebCore::ScheduledAction::~ScheduledAction):
+ (WebCore::ScheduledAction::execute):
+ * bindings/v8/ScheduledAction.h: Added.
+ (WebCore::ScheduledAction::ScheduledAction):
+
+2009-02-27 Zack Rusin <zack@kde.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Qt: be more reasonable about scrolled lines
+
+ cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
+ match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
+ irritating. so lets scroll vertically by the Qt set number of lines * Qt default
+ single step scroll
+
+ * platform/qt/WheelEventQt.cpp:
+
+2009-02-27 Xan Lopez <xan@gnome.org>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24222
+ [GTK] Remove checks for old glib versions
+
+ libsoup, which is a hard dependency, needs at least glib 2.15.3,
+ so remove all glib checks for versions older than that.
+
+ * platform/gtk/ContextMenuGtk.cpp:
+ (WebCore::ContextMenu::ContextMenu):
+ * platform/gtk/ContextMenuItemGtk.cpp:
+ (WebCore::ContextMenuItem::setSubMenu):
+ * platform/gtk/PopupMenuGtk.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::retainPlatformWidget):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+
+2009-02-26 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Added support for Gradients and Patterns on filled or stroked Fonts
+ in Cairo. I also added support for globalAlpha on FontCairo.
+
+ [CAIRO] SVG/Canvas fonts miss gradients/pattern support
+ https://bugs.webkit.org/show_bug.cgi?id=18617
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ * platform/graphics/cairo/FontCairo.cpp:
+ (WebCore::Font::drawGlyphs):
+
+2009-02-26 Stephen White <senorblanco@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23957
+
+ Fix for SVG gradient and pattern text for Chromium/skia.
+ Added accessors for the fill and stroke gradients to
+ GraphicsContext. Changed the paintSkiaText function to take a
+ GraphicsContext, so we can check for gradients/patterns.
+ Changed the skiaDrawText function to set the SkPaint shader
+ correctly, and to scale up the gradient shader matrix to
+ encompass the entire text string. Also offset each glyph
+ separately, rather than transforming the canvas, so that the
+ gradient/pattern stays fixed relative to the text origin.
+
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::getFillGradient):
+ (WebCore::GraphicsContext::getStrokeGradient):
+ (WebCore::GraphicsContext::getFillPattern):
+ (WebCore::GraphicsContext::getStrokePattern):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/chromium/UniscribeHelper.cpp:
+ (WebCore::UniscribeHelper::draw):
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::windowsCanHandleTextDrawing):
+ (WebCore::skiaDrawText):
+ (WebCore::paintSkiaText):
+ * platform/graphics/skia/SkiaFontWin.h:
+
+2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24208
+ Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
+
+ * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8DocumentCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ * bindings/v8/custom/V8NodeCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-02-26 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed build fix for building with GNOME Keyring enabled.
+
+ * platform/network/soup/webkit-soup-auth-dialog.c:
+ (show_auth_dialog):
+
+2009-02-26 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16947
+ [GTK] Missing HTTP Auth challenge
+
+ Add HTTP authentication dialog with optional GNOME Keyring
+ storage.
+
+ * GNUmakefile.am:
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::currentToplevelCallback):
+ (WebCore::ResourceHandle::startHttp):
+ (WebCore::ResourceHandle::start):
+ * platform/network/soup/webkit-soup-auth-dialog.c: Added.
+ (webkit_soup_auth_dialog_class_init):
+ (webkit_soup_auth_dialog_init):
+ (webkit_soup_auth_dialog_session_feature_init):
+ (free_authData):
+ (set_password_callback):
+ (response_callback):
+ (show_auth_dialog):
+ (find_password_callback):
+ (session_authenticate):
+ (attach):
+ * platform/network/soup/webkit-soup-auth-dialog.h: Added.
+
+2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
+
+ Reviewed by Dave Hyatt.
+
+ After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
+ svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
+ started failing because Ojan's new code was now *correctly* calling through to
+ SVG asking for the closest text offset in the last line box, instead of
+ just returning the offset at the end of the last line box when clicking below a box.
+
+ But! The SVG code was wrong, in that it returned the character offset of the last
+ character when you asked for a character offset after the end of the box, instead
+ it should return the offset *after* the last character. This patch fixes
+ that behavior by reordering the last two clauses in svgCharacterHitsPosition.
+
+ The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
+ to document what's wrong. I've also cleaned up the code a bit so it's clearer
+ what it is doing (which also makes more obvious what's wrong with it).
+
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::positionForCoordinates):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
+ (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
+ (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
+ (WebCore::SVGInlineTextBox::closestCharacterToPosition):
+ (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
+
+2009-02-26 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Minor cleanup of ChromiumBridge:
+ Removing unused matchesMIMEType method and s/Javascript/JavaScript/
+
+ * platform/chromium/ChromiumBridge.h:
+ * platform/chromium/MimeTypeRegistryChromium.cpp:
+ (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
+
+2009-02-26 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig
+
+ Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
+ the line-height below the descent.
+
+ Added fast/inline/vertical-align-text-bottom.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::verticalPosition):
+
+2009-02-26 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
+ ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
+ just to implement this three methods to support SVG Masking now.
+
+ Make SVG Masking platform aware
+ https://bugs.webkit.org/show_bug.cgi?id=19243
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/graphics/SVGResourceMasker.cpp:
+ (WebCore::SVGResourceMasker::applyMask):
+ * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
+ * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
+ * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
+ * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
+ * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
+
+2009-02-26 Yong Li <yong.li@torchmobile.com>
+
+ Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
+
+ Test: http/tests/misc/slow-preload-cancel.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=24133
+ Clear all pending preloads in the DocLoader object when we decide to
+ cancel its all requests.
+
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::clearPendingPreloads):
+ * loader/DocLoader.h:
+ * loader/loader.cpp:
+ (WebCore::Loader::cancelRequests):
+
+2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24182
+ Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
+
+ * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
+ (WebCore::toV8):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
+ (WebCore::toV8):
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-02-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23500
+ KURL::parse() incorrectly compares its result to original string
+
+ * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
+
+2009-02-26 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Kevin McCullough.
+
+ Manual test for inspector node highlighting.
+
+ * manual-tests/inspector/highlight-nodes.html: Added.
+
+2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23973
+ ScrollView::scrollContents can be invoked during view shutdown. In
+ this scenario the FrameView::hostWindow method can return NULL, which
+ indicates that the frame/page is being destroyed. This causes a crash
+ when we try to dereference a NULL hostWindow pointer. Fix is to add a
+ NULL check for this.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+
+2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24003
+ Fix a crash caused by unsafe type conversion.
+
+ Test: fast/block/positioning/absolute-in-inline-rtl-4.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+
+2009-02-26 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24202
+ Have drawNodeHighlight clip instead of clearing. This makes it work for
+ both Safari and Chromium since Chromium draws the inspector highlighting
+ in the same buffer as the page.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::quadToPath):
+ (WebCore::drawOutlinedQuad):
+ (WebCore::drawOutlinedQuadWithClip):
+ (WebCore::drawHighlightForBox):
+
+2009-02-26 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein & Darin Adler
+
+ Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
+
+ Added fast/inline/inline-continuation-borders.html
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+
+2009-02-26 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix, no review.
+
+ Try to fix the wx build after r41218.
+
+ * WebCoreSources.bkl:
+
+2009-02-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19527
+ ASSERTION FAILED: containerA && containerB
+
+ Test: fast/dom/Range/bug-19527.html
+
+ * dom/Range.cpp:
+ (WebCore::Range::isPointInRange):
+ (WebCore::Range::comparePoint):
+ Bring the behavior in line with current Firefox, making it impossible for these methods
+ to pass a null container to compareBoundaryPoints().
+
+2009-02-26 Jonathon Jongsma <jonathon@quotidian.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20358
+
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
+ should set the computed size rather than the specified size, otherwise
+ the caps just get rendered normal size.
+
+2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24062
+ QNetworkCookieJar expects the url and not the policy url. Sending the
+ policy url will cause QNetworkCookieJar to behave incorrectly. One
+ example would be a cookie that does not have a path or domain.
+ QNetworkCookieJar will use the url it is given to fill in default values.
+ This allows setting cookies on the url of the main frame from an iFrame
+ when the cookie should be set on the url of the iFrame.
+
+ Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
+
+ * platform/qt/CookieJarQt.cpp:
+ (WebCore::setCookies):
+
+2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>
+
+ Reviewed by George Staikos.
+
+ make WebKit/Qt compile with SVG disabled
+
+ * WebCore.pro:
+ * platform/graphics/qt/FontPlatformDataQt.cpp:
+
+2009-02-25 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed build fix. Add WebCore/workers to the list of paths
+ searched by the bindings generator perl script.
+
+ * GNUmakefile.am:
+
+2009-02-25 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Add canvas to the list of RenderObjects that can mark a page as
+ visually not empty.
+
+ * rendering/RenderHTMLCanvas.cpp:
+ (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
+
+2009-02-25 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
+ as RenderMedia with controls always has a layer.
+
+2009-02-25 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=24130
+ <rdar://problem/6618196> Paint very slow when horizontally resizing
+
+ Test: fast/gradients/background-clipped.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
+ destination rectangle passed to drawTiledImage() with the dirty
+ rectangle. This makes it more likely for the destination rect to be
+ contained in a single tile rect, which results in a faster code path
+ being taken down the road (just drawing a single tile instead of
+ tiling).
+
+2009-02-25 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix test regressions from positionForCoordinates patch.
+ https://bugs.webkit.org/show_bug.cgi?id=24148
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::positionForPointWithInlineChildren):
+ Remove ASSERT that placeholder text codepath is hitting.
+
+2009-02-25 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
+ https://bugs.webkit.org/show_bug.cgi?id=24143
+
+ When an AX object is marked dirty, do not create AX elements while going up the parent chain.
+ Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
+ Make sure the AXObjectWrapper's have an object before calling them
+ In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
+
+ Test: platform/mac-snowleopard/accessibility/table-updating.html
+
+ * WebCore.base.exp:
+ * page/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::~AXObjectCache):
+ (WebCore::AXObjectCache::get):
+ (WebCore::AXObjectCache::getOrCreate):
+ (WebCore::AXObjectCache::removeAXID):
+ (WebCore::AXObjectCache::handleActiveDescendantChanged):
+ (WebCore::AXObjectCache::handleAriaRoleChanged):
+ * page/AXObjectCache.h:
+ * page/AccessibilityImageMapLink.cpp:
+ (WebCore::AccessibilityImageMapLink::parentObject):
+ * page/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
+ (WebCore::AccessibilityListBox::doAccessibilityHitTest):
+ * page/AccessibilityListBoxOption.cpp:
+ (WebCore::AccessibilityListBoxOption::elementRect):
+ (WebCore::AccessibilityListBoxOption::parentObject):
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::detach):
+ (WebCore::AccessibilityObject::parentObjectIfExists):
+ (WebCore::replacedNodeNeedsCharacter):
+ (WebCore::AccessibilityObject::accessibilityObjectForPosition):
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::firstChild):
+ (WebCore::AccessibilityRenderObject::lastChild):
+ (WebCore::AccessibilityRenderObject::previousSibling):
+ (WebCore::AccessibilityRenderObject::nextSibling):
+ (WebCore::AccessibilityRenderObject::parentObjectIfExists):
+ (WebCore::AccessibilityRenderObject::parentObject):
+ (WebCore::AccessibilityRenderObject::isAttachment):
+ (WebCore::AccessibilityRenderObject::headingLevel):
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ (WebCore::AccessibilityRenderObject::menuForMenuButton):
+ (WebCore::AccessibilityRenderObject::menuButtonForMenu):
+ (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
+ (WebCore::AccessibilityRenderObject::internalLinkElement):
+ (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
+ (WebCore::AccessibilityRenderObject::titleUIElement):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
+ (WebCore::AccessibilityRenderObject::getDocumentLinks):
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ (WebCore::AccessibilityRenderObject::focusedUIElement):
+ (WebCore::AccessibilityRenderObject::activeDescendant):
+ (WebCore::AccessibilityRenderObject::observableObject):
+ (WebCore::AccessibilityRenderObject::childrenChanged):
+ (WebCore::AccessibilityRenderObject::addChildren):
+ * page/AccessibilityRenderObject.h:
+ (WebCore::AccessibilityRenderObject::setRenderObject):
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::addChildren):
+ (WebCore::AccessibilityTable::headerContainer):
+ (WebCore::AccessibilityTable::cellForColumnAndRow):
+ * page/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::isTableCell):
+ (WebCore::AccessibilityTableCell::titleUIElement):
+ * page/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::headerObjectForSection):
+ * page/AccessibilityTableRow.cpp:
+ (WebCore::AccessibilityTableRow::isTableRow):
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+ * page/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postNotification):
+ (WebCore::AXObjectCache::postNotificationToElement):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (textMarkerForVisiblePosition):
+ (AXLinkElementForNode):
+ (nsStringForReplacedNode):
+ (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
+ (-[AccessibilityObjectWrapper accessibilityActionNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
+ (-[AccessibilityObjectWrapper accessibilityHitTest:]):
+ (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
+ (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
+ (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
+ (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
+ (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
+ (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
+ (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
+
+2009-02-25 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Re-working of <rdar://problem/6487249> repro crash in
+ WebCore::CSSParser::parseFillImage copying entire contents of this
+ page
+ -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
+
+ Fixes a bunch of layout test failures I caused!
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseContent):
+ (WebCore::CSSParser::parseFillImage):
+ (WebCore::CSSParser::parseFontFaceSrc):
+ (WebCore::CSSParser::parseBorderImage):
+
+2009-02-25 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24174
+ Add more V8 custom bindings.
+
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
+ (WebCore::hasCSSPropertyNamePrefix):
+ (WebCore::cssPropertyName):
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::NAMED_PROPERTY_SETTER):
+ * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8EventCustom.cpp: Added.
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::ACCESSOR_GETTER):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_DELETER):
+ (WebCore::NAMED_PROPERTY_SETTER):
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8NodeListCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER):
+
+2009-02-25 Scott Violet <sky@google.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24171
+ Provides a RenderTheme method for getting the scroll bar size and
+ changes RenderListBox to use it. RenderTheme returns a size of regular,
+ and Mac's override to return small. Changes ScrollbarThemeChromium to
+ use the scrollbarsize of the scrollbar when getting the size
+ instead of passing in no-args.
+
+ * platform/chromium/ScrollbarThemeChromium.cpp:
+ (WebCore::ScrollbarThemeChromium::trackRect):
+ (WebCore::ScrollbarThemeChromium::buttonSize):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::createScrollbar):
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::scrollbarControlSizeForPart):
+ * rendering/RenderThemeChromiumMac.h:
+ (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
+ * rendering/RenderThemeMac.h:
+ (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
+
+2009-02-25 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6487249> repro crash in
+ WebCore::CSSParser::parseFillImage copying entire contents of this
+ page
+ -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Null-check m_styleSheet
+
+2009-02-25 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build.
+
+ * WebCore.pro:
+
+2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix. Not reviewed.
+
+ Add files to the build per r41218.
+ Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
+
+ * GNUmakefile.am:
+ * page/DOMWindow.cpp:
+
+2009-02-25 Zan Dobersek <zandobersek@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24043
+ When faced with URLs with unsupported protocol on Gtk port,
+ report the error through an idle function and return true, so
+ a proper resource handle is created.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::reportUnknownProtocolError):
+ (WebCore::ResourceHandle::start):
+
+2009-02-25 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+ Use struct to forward declare ResourceRequest.
+
+ * history/HistoryItem.h:
+ * inspector/InspectorController.h:
+ * loader/DocumentThreadableLoader.h:
+ * loader/FrameLoaderClient.h:
+ * loader/MainResourceLoader.h:
+ * loader/SubresourceLoader.h:
+ * loader/SubresourceLoaderClient.h:
+ * loader/ThreadableLoader.h:
+ * loader/WorkerThreadableLoader.h:
+ * platform/CrossThreadCopier.h:
+ * platform/network/ResourceHandle.h:
+ * platform/network/ResourceHandleClient.h:
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/cf/ResourceRequestCFNet.h:
+ * xml/XMLHttpRequest.h:
+
+2009-02-25 Steve Falkenburg <sfalken@apple.com>
+
+ Partial Windows build fix.
+
+ * DerivedSources.cpp:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-02-25 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Ported arcTo to Qt. Qt has no native support for arcTo. This changes
+ calculate the behavior of arcTo and draws it with lineTo and arc.
+
+ [QT] implement Canvas arcTo
+ https://bugs.webkit.org/show_bug.cgi?id=23873
+
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::Path::addArcTo):
+
+2009-02-25 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Remove idl files from Resources, and sort.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-02-25 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23943
+
+ Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
+ the window object. Also added WebKitPoint object, which is passed in and out
+ of these functions.
+
+ Test: fast/dom/Window/webkitConvertPoint.html
+
+ * DerivedSources.make:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseWebKitPoint):
+ (setJSDOMWindowBaseWebKitPoint):
+ * bindings/js/JSWebKitPointConstructor.cpp: Added.
+ (WebCore::):
+ (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
+ (WebCore::constructWebKitPoint):
+ (WebCore::JSWebKitPointConstructor::getConstructData):
+ * bindings/js/JSWebKitPointConstructor.h: Added.
+ (WebCore::JSWebKitPointConstructor::classInfo):
+ * dom/Node.cpp:
+ (WebCore::Node::convertToPage):
+ (WebCore::Node::convertFromPage):
+ * dom/Node.h:
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
+ (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+ * page/WebKitPoint.h: Added.
+ (WebCore::WebKitPoint::create):
+ (WebCore::WebKitPoint::x):
+ (WebCore::WebKitPoint::y):
+ (WebCore::WebKitPoint::setX):
+ (WebCore::WebKitPoint::setY):
+ (WebCore::WebKitPoint::WebKitPoint):
+ * page/WebKitPoint.idl: Added.
+
+2009-02-25 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
+ https://bugs.webkit.org/show_bug.cgi?id=24145
+
+ * platform/CrossThreadCopier.cpp:
+ * platform/CrossThreadCopier.h:
+
+2009-02-25 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23688: ThreadableLoader needs a sync implementation for Workers.
+ <https://bugs.webkit.org/show_bug.cgi?id=23688>
+
+ No observable change in behavior, so no test.
+
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/ThreadableLoaderClientWrapper.h:
+ (WebCore::ThreadableLoaderClientWrapper::clearClient):
+ (WebCore::ThreadableLoaderClientWrapper::done):
+ (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
+ (WebCore::ThreadableLoaderClientWrapper::didFail):
+ (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
+ (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
+ Expose whether the loader is done (based on what callbacks were done).
+
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
+ Each loader is given its own mode so that only its callbacks get through the run loop.
+
+ The xhr spec says that the readystatechange events are synchronous, so in the case of a
+ nested sync xhr no readystatechange events should be fired for the outer xhr.
+
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+
+ * loader/WorkerThreadableLoader.h:
+ (WebCore::WorkerThreadableLoader::create):
+ (WebCore::WorkerThreadableLoader::done):
+
+ * workers/WorkerRunLoop.cpp:
+ (WebCore::WorkerRunLoop::WorkerRunLoop):
+ * workers/WorkerRunLoop.h:
+ (WebCore::WorkerRunLoop::createUniqueId):
+ Simple method to create a uniqueId on demand with respect to the run loop.
+
+ * workers/WorkerThread.h:
+
+2009-02-25 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
+ <https://bugs.webkit.org/show_bug.cgi?id=24089>
+
+ Make threadable loader callbacks to happen during the sync load call.
+
+ Changes the behavior of sync xhr for insecure redirects in two ways:
+ + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
+ + Throws a network exception which is what other browsers do and what the spec
+ says to do (http://www.w3.org/TR/XMLHttpRequest/).
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
+ * loader/DocumentThreadableLoader.h:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/ThreadableLoader.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::loadRequestSynchronously):
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::didFail):
+ (WebCore::XMLHttpRequest::didFailRedirectCheck):
+ * xml/XMLHttpRequest.h:
+
+2009-02-24 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23368
+
+ Added logic to correctly hit test accelerated layers.
+
+ Tests: animations/animation-hit-test-transform.html
+ animations/animation-hit-test.html
+ transitions/transition-hit-test-transform.html
+ transitions/transition-hit-test.html
+
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::updateClipRects):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
+2009-02-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24067
+ REGRESSION: Crash in WebCore::Document::initSecurityContext
+
+ The crash started to happen when we removed a check for frame->document() being null.
+ However, the original document shouldn't be null here, because it is needed to alias
+ security origins. So, this patch fixes the crash by correcting security origin behavior.
+
+ Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
+ This tests for not crashing, and for inheriting the domain from the document being replaced.
+ Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
+ domain to remove a prefix from.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
+ clearing the frame, so that Document::initSecurityContext() could access the old one.
+
+2009-02-25 Jay Campan <jcampan@google.com>
+
+ Reviewed by Darin Fisher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24066
+
+ Items in drop-downs were not painted correctly. Makes sure the
+ PopupListBox invalidates in the coordinates of the window as this is
+ FramelessScrollView::invalidateRect paints to.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::invalidateRow):
+
+2009-02-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ https://bugs.webkit.org/show_bug.cgi?id=15081
+
+ Make display:none work for applet, emebed and object elements
+ by calling rendererIsNeeded() on superclasses.
+
+ Tests: fast/replaced/applet-display-none.html
+ fast/replaced/embed-display-none.html
+ fast/replaced/object-display-none.html
+
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::rendererIsNeeded):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::rendererIsNeeded):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::rendererIsNeeded):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::rendererIsNeeded):
+
+2009-02-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=24137
+
+ Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
+ taking perspective and transform-style: preserve-3d into account.
+
+ In order to support transform-style: preserve-3d, which keeps elements in a
+ 3d space, we have to carry along an accumulated matrix in TransformState.
+ We also need to apply the perspective from the parent, if any, with the
+ appropriate origin.
+
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::TransformationMatrix::translate):
+ (WebCore::TransformationMatrix::translate3d):
+ (WebCore::TransformationMatrix::translateRight3d):
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToAbsolutePoint):
+ (WebCore::RenderBox::mapAbsoluteToLocalPoint):
+ * rendering/RenderBox.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::perspectiveTransform):
+ (WebCore::RenderLayer::perspectiveOrigin):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::requiresCompositingLayerForTransform):
+ (WebCore::RenderLayerCompositor::layerHas3DContent):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::absoluteToLocal):
+ (WebCore::RenderObject::mapLocalToAbsolutePoint):
+ (WebCore::RenderObject::mapAbsoluteToLocalPoint):
+ * rendering/RenderObject.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
+ (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::mapLocalToAbsolutePoint):
+ (WebCore::RenderView::mapAbsoluteToLocalPoint):
+ * rendering/RenderView.h:
+ * rendering/TransformState.cpp: Added.
+ (WebCore::TransformState::move):
+ (WebCore::TransformState::applyTransform):
+ (WebCore::TransformState::flatten):
+ * rendering/TransformState.h: Added.
+ (WebCore::TransformState::):
+ (WebCore::TransformState::TransformState):
+ (WebCore::TransformState::move):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::hasPerspective):
+
+2009-02-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
+ Regression (r40837): JavaScript image popup doesn't work
+
+ Make the getClientRects and getBoundingClientRect methods return rects
+ relative to the viewport.
+
+ Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::getClientRects):
+ (WebCore::Element::getBoundingClientRect):
+
+2009-02-24 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ SVG pages don't have a body or an html element!
+ Don't return early if there is no body.
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::canonicalPosition):
+
+2009-02-23 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
+
+ This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
+ layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
+ reflections or masks).
+
+ If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
+ The only difference is that the clip has to be pushed and popped when painting the object's children.
+
+ The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
+ the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
+ use the new functions.
+
+ Hit testing has also been patched to check the overflow clip rect first before recurring into children.
+
+ Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
+ yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.
+
+ Masks are now treated like normal flow layers (just like reflections).
+
+ A couple of test cases have been added to fast/overflow to test the stacking order.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::nodeAtPoint):
+ (WebCore::InlineFlowBox::paint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::repaintOverhangingFloats):
+ (WebCore::RenderBlock::paint):
+ (WebCore::RenderBlock::paintChildren):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::paintFloats):
+ (WebCore::RenderBlock::insertFloatingObject):
+ (WebCore::RenderBlock::floatRect):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::addOverhangingFloats):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::hitTestContents):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::nodeAtPoint):
+ (WebCore::RenderBox::pushContentsClip):
+ (WebCore::RenderBox::popContentsClip):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::paintObject):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::shouldBeNormalFlowOnly):
+ (WebCore::RenderLayer::isSelfPaintingLayer):
+ * rendering/RenderLayer.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::paint):
+ (WebCore::RenderTable::paintObject):
+ (WebCore::RenderTable::nodeAtPoint):
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::paint):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::nodeAtPoint):
+ (WebCore::RenderTableRow::paint):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::paint):
+ (WebCore::RenderTableSection::paintObject):
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderTableSection.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ (WebCore::writeLayers):
+
+2009-02-24 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (build fix).
+
+ Attempted build fix for wx-mac.
+
+ * WebCoreSources.bkl:
+
+2009-02-24 David Levin <levin@chromium.org>
+
+ Reviewed by NOBODY (build fix).
+
+ Attempted build fixes for qt-linux and wx-mac.
+
+ * WebCore.pro:
+ * webcore-base.bkl:
+
+2009-02-24 Ojan Vafai <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix null pointer error. If the node is the Document, then ownerDocument()
+ returns null, document() does not.
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::canonicalPosition):
+
+2009-02-24 Jian Li <jianli@chromium.org>
+
+ Reviewed by NOBODY (attempted build fixes).
+
+ Fix build break for Windows and Linux.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24131
+ Fix-up COM/RefCounted dichotomy in Chromium port.
+
+ * page/chromium/AccessibilityObjectWrapper.h:
+ (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
+ explicit setting of recount.
+
+2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24141
+ Add clarity to V8 interceptor helper function.
+
+ * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
+ (WebCore::NAMED_PROPERTY_SETTER): Ditto.
+ (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
+ (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
+
+2009-02-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Minor numeric cleanup: convert float literals to doubles.
+
+ * platform/graphics/transforms/RotateTransformOperation.cpp:
+ (WebCore::RotateTransformOperation::blend):
+
+2009-02-24 Mark Mentovai <mark@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24139
+ Add missing include.
+
+ * bindings/v8/ScriptInstance.h:
+
+2009-02-24 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Move worker related files from dom directory to worker directory under WebCore.
+ https://bugs.webkit.org/show_bug.cgi?id=24123
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/MigrateIDLAndScripts:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
+ * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
+ * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
+ * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
+ * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
+ * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
+ * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
+ * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
+ * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
+ * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
+ * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
+ * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
+ * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
+ * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
+ * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
+ * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
+ * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
+ * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
+ * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
+ * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
+
+2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
+
+ Reviewed by Dave Hyatt.
+
+ Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
+ around divs inside editable regions.
+ https://bugs.webkit.org/show_bug.cgi?id=23605
+
+ Fix clicks outside editable regions from focusing the editable region.
+ https://bugs.webkit.org/show_bug.cgi?id=23607
+
+ Removed editing/selection/contenteditable-click-outside.html as it's
+ not as useful as our new tests.
+
+ Clean up RenderBlock::positionForCoordinates to remove dead code,
+ duplicate code, and generally make it more readable.
+
+ Tests: editing/selection/click-in-margins-inside-editable-div.html
+ editing/selection/click-in-padding-with-multiple-line-boxes.html
+ editing/selection/click-outside-editable-div.html
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::canonicalPosition):
+ * rendering/RenderBlock.cpp:
+ (WebCore::positionForPointRespectingEditingBoundaries):
+ (WebCore::positionForPointWithInlineChildren):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::updateFirstLetter):
+
+2009-02-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Related to <rdar://problem/6590295>
+ Allow disabling javascript: urls.
+
+ * WebCore.base.exp:
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::parseMappedAttribute):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeIfJavaScriptURL):
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ (WebCore::Page::setJavaScriptURLsAreAllowed):
+ (WebCore::Page::javaScriptURLsAreAllowed):
+ * page/Page.h:
+
+2009-02-24 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is turned on
+ (overflowList() -> normalFlowList()).
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::hasNonCompositingContent):
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
+ (WebCore::RenderLayerCompositor::layerHas3DContent):
+
+2009-02-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=24135
+
+ Round the FloatPoint returned by absoluteToLocal(), rather than
+ truncating it.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+
+2009-02-24 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
+ Ordered list item marker misaligned when line height is not 1.2
+ -and corresponding <rdar://problem/6602506>
+
+ This is a regression from http://trac.webkit.org/changeset/40880
+ where createInlineBox was taken off of RenderObject and moved to
+ RenderBox. The problem was that the RenderBox version still needs
+ to be virtual because there is still an existing implementation in
+ RenderListMarker.
+
+ * rendering/RenderBox.h:
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::createInlineBox):
+ * rendering/RenderListMarker.h:
+
+2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24128
+ Upstream more V8 custom bindings: constructors, XSLTProcessor.
+
+ * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-02-24 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
+ <https://bugs.webkit.org/show_bug.cgi?id=24090>
+
+ No observable change in behavior, so no test.
+
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
+ (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
+ Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
+
+ (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
+
+ * dom/WorkerMessagingProxy.h:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
+ Changed these methods to post task using a mode.
+
+ * loader/WorkerThreadableLoader.h:
+ (WebCore::WorkerThreadableLoader::create):
+
+2009-02-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24091
+ <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
+
+ Test: http/tests/appcache/access-via-redirect.php
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
+ not the original one.
+
+2009-02-24 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
+ https://bugs.webkit.org/show_bug.cgi?id=24112
+
+ * bindings/js/WorkerScriptController.cpp:
+ * dom/WorkerContext.cpp:
+
+2009-02-23 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6613796> Extended text codecs registered on webview creation
+
+ Comparing a text encoding with string "GBK" ended up constructing
+ TextEncoding("GBK") which in turn initialized all extended
+ text codecs.
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::decode):
+
+2009-02-23 Sam Weinig <sam@webkit.org>
+
+ Fix Qt build.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::valueRealType):
+
+2009-02-23 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
+
+ The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
+ element created with createElement could have a wrong nodeName (createElement sets the string as the
+ localName without checking for a prefix).
+
+ The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
+ and will always succeed.
+ Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
+ to ensure that).
+
+ Test: fast/dom/cloneNode.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
+ always return an element.
+
+ * html/HTMLElement.cpp:
+ * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
+
+2009-02-23 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24109
+ Upstream V8 Script abstractions, all except ScriptController.
+
+ * bindings/v8/ScriptCachedFrameData.h: Added.
+ (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
+ (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
+ (WebCore::ScriptCachedFrameData::restore):
+ (WebCore::ScriptCachedFrameData::clear):
+ (WebCore::ScriptCachedFrameData::domWindow):
+ * bindings/v8/ScriptCallFrame.cpp: Added.
+ (WebCore::ScriptCallFrame::ScriptCallFrame):
+ (WebCore::ScriptCallFrame::~ScriptCallFrame):
+ (WebCore::ScriptCallFrame::argumentAt):
+ * bindings/v8/ScriptCallFrame.h: Added.
+ (WebCore::ScriptCallFrame::functionName):
+ (WebCore::ScriptCallFrame::sourceURL):
+ (WebCore::ScriptCallFrame::lineNumber):
+ (WebCore::ScriptCallFrame::argumentCount):
+ * bindings/v8/ScriptCallStack.cpp: Added.
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::~ScriptCallStack):
+ (WebCore::ScriptCallStack::at):
+ * bindings/v8/ScriptCallStack.h: Added.
+ (WebCore::ScriptCallStack::size):
+ * bindings/v8/ScriptInstance.cpp: Added.
+ (WebCore::V8ScriptInstance::V8ScriptInstance):
+ (WebCore::V8ScriptInstance::~V8ScriptInstance):
+ (WebCore::V8ScriptInstance::instance):
+ (WebCore::V8ScriptInstance::clear):
+ (WebCore::V8ScriptInstance::set):
+ * bindings/v8/ScriptInstance.h: Added.
+ (WebCore::V8ScriptInstance::create):
+ * bindings/v8/ScriptSourceCode.h: Added.
+ (WebCore::ScriptSourceCode::ScriptSourceCode):
+ (WebCore::ScriptSourceCode::isEmpty):
+ (WebCore::ScriptSourceCode::source):
+ (WebCore::ScriptSourceCode::url):
+ (WebCore::ScriptSourceCode::startLine):
+ * bindings/v8/ScriptState.h: Added.
+ (WebCore::ScriptState::hadException):
+ (WebCore::ScriptState::setException):
+ (WebCore::ScriptState::exception):
+ * bindings/v8/ScriptString.h: Added.
+ (WebCore::ScriptString::ScriptString):
+ (WebCore::ScriptString::operator String):
+ (WebCore::ScriptString::isNull):
+ (WebCore::ScriptString::size):
+ (WebCore::ScriptString::operator=):
+ (WebCore::ScriptString::operator+=):
+ * bindings/v8/ScriptValue.cpp: Added.
+ (WebCore::ScriptValue::getString):
+ * bindings/v8/ScriptValue.h: Added.
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::operator=):
+ (WebCore::ScriptValue::operator==):
+ (WebCore::ScriptValue::operator!=):
+ (WebCore::ScriptValue::isNull):
+ (WebCore::ScriptValue::isUndefined):
+ (WebCore::ScriptValue::clear):
+ (WebCore::ScriptValue::~ScriptValue):
+ (WebCore::ScriptValue::v8Value):
+
+2009-02-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24106
+ The Qt port is crashing on exit because the tear down procedure involves
+ the WebCore::InspectorController trying to access the JS execution context
+ for a page that is being deleted. This patch amends the inspector so
+ that it does not try and access the execution context of the WebCore::Page
+ in the midst of deletion.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::inspectedPageDestroyed):
+ (WebCore::InspectorController::stopUserInitiatedProfiling):
+
+2009-02-23 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
+ <https://bugs.webkit.org/show_bug.cgi?id=24088>
+
+ No observable change in behavior, so no test.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::create):
+ * loader/ThreadableLoaderClient.h:
+ (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
+ * loader/ThreadableLoaderClientWrapper.h:
+ (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::workerContextDidFailRedirectCheck):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
+ * loader/WorkerThreadableLoader.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ * xml/XMLHttpRequest.h:
+
+2009-02-23 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
+ <https://bugs.webkit.org/show_bug.cgi?id=24047>
+
+ Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
+ using only MessageQueue::waitForMessageFilteredWithTimeout instead
+ of three different MessageQueue methods.
+
+ No observable change in behavior, so no test.
+
+ * dom/WorkerRunLoop.cpp:
+ (WebCore::ModePredicate::operator()):
+ Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
+ (WebCore::WorkerRunLoop::runInMode):
+ * dom/WorkerRunLoop.h:
+
+2009-02-23 David Hyatt <hyatt@apple.com>
+
+ In preparation for making layers for multicol objects (so that they can properly split child layers
+ into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
+ of RenderLayer to use the term "normal flow" instead.
+
+ Reviewed by Cameron Zwarich
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::~RenderLayer):
+ (WebCore::RenderLayer::setHasVisibleContent):
+ (WebCore::RenderLayer::enclosingCompositingLayer):
+ (WebCore::RenderLayer::addChild):
+ (WebCore::RenderLayer::removeChild):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::dirtyNormalFlowList):
+ (WebCore::RenderLayer::updateNormalFlowList):
+ (WebCore::RenderLayer::collectLayers):
+ (WebCore::RenderLayer::updateLayerListsIfNeeded):
+ (WebCore::RenderLayer::shouldBeNormalFlowOnly):
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::isNormalFlowOnly):
+ (WebCore::RenderLayer::normalFlowList):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeLayers):
+
+2009-02-23 David Hyatt <hyatt@apple.com>
+
+ Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
+ after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
+ column rules (rather than ending up above the background of the box but behind the column rules).
+
+ Reviewed by Eric Seidel
+
+ Added fast/multicol/column-rules-stacking.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintColumnRules):
+ (WebCore::RenderBlock::paintColumnContents):
+ (WebCore::RenderBlock::paintObject):
+ * rendering/RenderBlock.h:
+
+2009-02-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by David Hyatt.
+
+ No testcases have been added or modified since this patch should not result in
+ a behavior change for ports that have layout tests enabled.
+
+ Currently, the implementation of GraphicsContext::drawLineForText amongst
+ the various ports differ in that some of them are honoring the context's
+ strokeStyle when drawing a text-decoration and some of them are not.
+ For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
+ but the Cairo implementation does and has an explicit workaround that
+ sets the strokeStyle() temporarily.
+
+ This patch fixes so that all ports are consistent by explicitly making sure
+ to set the GraphicsContext strokeStyle to SolidStroke whenever
+ painting the text-decoration of an InlineFlowBox or InlineTextBox as these
+ should always use a solid stroke.
+
+ This patch addresses these bugs:
+ https://bugs.webkit.org/show_bug.cgi?id=19364
+ https://bugs.webkit.org/show_bug.cgi?id=15659
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintDecoration):
+
+2009-02-23 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24098
+ Bugs in ClipboardChromium
+
+ Fixes the following bugs in ClipboardChromium:
+ * It's possible for the extension to be empty, resulting in a bad file
+ name, for example, 'foo.' or just '.'.
+ * We weren't restricting the size of the file to MAX_PATH.
+ * We weren't removing characters that are invalid for file system names.
+
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::writeImageToDataObject):
+ * platform/chromium/ClipboardChromium.h:
+ * platform/chromium/ClipboardChromiumLinux.cpp: Added.
+ (WebCore::ClipboardChromium::validateFileName):
+ * platform/chromium/ClipboardChromiumMac.cpp: Added.
+ (WebCore::ClipboardChromium::validateFileName):
+ * platform/chromium/ClipboardChromiumWin.cpp: Added.
+ (WebCore::isInvalidFileCharacter):
+ (WebCore::ClipboardChromium::validateFileName):
+
+2009-02-23 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the Copyright notices in a few files
+
+ * platform/qt/RenderThemeQt.h:
+
+2009-02-23 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22624
+ [SOUP][GTK] Need API to get SoupSession from WebKit.
+
+ Allow to retrieve the Soup session and modify the code to take
+ into account users changing features on it.
+
+ * platform/network/ResourceHandle.h:
+ * platform/network/soup/CookieJarSoup.cpp:
+ (WebCore::defaultCookieJar):
+ (WebCore::setDefaultCookieJar):
+ * platform/network/soup/CookieJarSoup.h:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::createSoupSession):
+ (WebCore::ensureSessionIsInitialized):
+ (WebCore::ResourceHandle::startHttp):
+ (WebCore::ResourceHandle::cancel):
+ (WebCore::ResourceHandle::defaultSession):
+
+2009-02-23 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22624
+ [SOUP][GTK] Need API to get SoupSession from WebKit.
+
+ Remove CURL support.
+
+ * GNUmakefile.am:
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Test: fast/dom/empty-hash-and-search.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=21147
+ hash property returns incorrect value for links w/o hash
+
+ Make hash() and search() behavior for empty and missing parts match IE and Firefox.
+
+ * platform/KURL.cpp:
+ (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
+ (WebCore::KURL::prettyURL): Append the query with the question mark.
+
+ * page/Location.cpp:
+ (WebCore::Location::search): Return an empty string if query is empty or missing.
+ (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
+
+ * dom/WorkerLocation.cpp:
+ (WebCore::WorkerLocation::search):
+ (WebCore::WorkerLocation::hash):
+ Match document.location fixes above.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::hash):
+ (WebCore::HTMLAnchorElement::search):
+ Return an empty string for empty and missing parts.
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20184
+ SELECT with no name generates invalid query string
+
+ Test: fast/forms/select-no-name.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Apply review comments for the previous check-in (forgot to save the file, oops).
+
+ * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15707
+ Crash when manipulating document from within an iframe onload function
+
+ Test: fast/dom/onload-open.html
+
+ * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
+ the current node, because anything can happen when dispatching events.
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18970
+ Numerically named input fields cause document.forms loop problems
+
+ Test: fast/forms/numeric-input-name.html
+
+ * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
+ latter overrides properties.
+
+2009-02-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24059
+ Tokenizer::write() return value is never used
+
+ * dom/Tokenizer.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::write):
+ * dom/XMLTokenizer.h:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::write):
+ * html/HTMLTokenizer.h:
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::FTPDirectoryTokenizer::write):
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageTokenizer::write):
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaTokenizer::write):
+ * loader/PluginDocument.cpp:
+ (WebCore::PluginTokenizer::write):
+ * loader/TextDocument.cpp:
+ (WebCore::TextTokenizer::write):
+ Made write() return void, not bool.
+
+2009-02-20 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore changes to timeout checking.
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase):
+ (WebCore::JSDOMWindowBase::commonJSGlobalData):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::executeFunctionInContext):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ (WebCore::WorkerScriptController::forbidExecution):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ (-[WebScriptObject evaluateWebScript:]):
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Evaluate):
+ (_NPN_Construct):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::eval):
+
+2009-02-21 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23786
+ [Chromium] line-break characters in a complex text are treated as zero-width spaces
+
+ This change prevents the UniscribeHelper class from treating the line-break characters
+ as whitespaces.
+
+ Tests: fast/text/international/bidi-linebreak-001.html
+ fast/text/international/bidi-linebreak-002.html
+ fast/text/international/bidi-linebreak-003.html
+
+ * platform/graphics/chromium/UniscribeHelper.cpp:
+ (WebCore::UniscribeHelper::adjustSpaceAdvances):
+ Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
+ the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
+ so does when Chromium renders a simple text.
+
+2009-02-20 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
+
+ Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
+ or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
+ unneeded.
+
+ It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
+ enables us to use some generated QualifiedName.
+
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::constructHTMLOptionElement):
+ * dom/Document.cpp:
+ (WebCore::Document::setTitle):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::createXHTMLParserErrorHeader):
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::createBlockPlaceholderElement):
+ * editing/htmlediting.cpp:
+ (WebCore::createTabSpanElement):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setLength):
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::FTPDirectoryTokenizer::appendEntry):
+ (WebCore::FTPDirectoryTokenizer::createTDForFilename):
+ (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
+ (WebCore::FTPDirectoryTokenizer::createBasicDocument):
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageDocument::createDocumentStructure):
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaTokenizer::createDocumentStructure):
+ * loader/PluginDocument.cpp:
+ (WebCore::PluginTokenizer::createDocumentStructure):
+ * loader/TextDocument.cpp:
+ (WebCore::TextTokenizer::write):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionComputedStyle):
+ (WebCore::Frame::styleForSelectionStart):
+ Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
+
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
+ * page/DragController.cpp:
+ (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
+
+2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24060
+ Fix up to accommodate for CanvasPixelArray return.
+
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
+ (WebCore::ImageBuffer::putImageData): Ditto.
+
+2009-02-20 Eric Carlson <eric.carlson@apple.com>
+
+ Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=24042
+ Bug 24042: MediaPlayer should cache plug-in proxy
+
+ The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
+ MediaPlayer will always have created the private media player object before
+ the plug-in is instantiated and calls back with the proxy object. This is not
+ true on all platforms because of threading latency, so MediaPlayer should
+ cache the plug-in proxy so it can pass it to the media engine at a later time.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
+ (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
+ (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
+ (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
+ (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
+ (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
+ * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
+
+2009-02-20 Eric Carlson <eric.carlson@apple.com>
+
+ Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24063
+ Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions.
+ Initialize m_internalCall.
+ (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
+ (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
+ (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
+ (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
+ (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
+ (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
+ (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
+ (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
+ (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
+ (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
+ * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
+ add RequireUserGestureRateChangeRestriction.
+
+2009-02-20 Darin Fisher <darin@chromium.org>
+
+ Fix build bustage in FileSystemWin.cpp.
+
+ Need to return CString() instead of 0 since there are now two CString
+ constructors that take a pointer type.
+
+ * platform/win/FileSystemWin.cpp:
+ (WebCore::openTemporaryFile):
+
+2009-02-20 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23999
+ Change license headers to accurately reflect code history.
+
+ * platform/ContentType.cpp:
+ * platform/ContentType.h:
+
+2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23999
+ Split off MIME type parsing into its own class.
+
+ * GNUmakefile.am: Added ContentType sources.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+ * html/HTMLMediaElement.cpp: Changed to use ContentType.
+ (WebCore::HTMLMediaElement::selectMediaURL):
+ * platform/ContentType.cpp: Added.
+ (WebCore::ContentType::ContentType):
+ (WebCore::ContentType::parameter):
+ (WebCore::ContentType::type):
+ * platform/ContentType.h: Added.
+ (WebCore::ContentType::raw):
+ * platform/MIMETypeRegistry.cpp:
+ * platform/MIMETypeRegistry.h:
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::load):
+ * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
+ * rendering/style/RenderStyleConstants.h: Ditto.
+ (WebCore::):
+
+2009-02-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix.
+
+ Use CString() instead of 0.
+
+ * platform/gtk/FileSystemGtk.cpp:
+ (WebCore::openTemporaryFile):
+ * platform/qt/FileSystemQt.cpp:
+ (WebCore::openTemporaryFile):
+
+2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ When dealing with local files, use a path instead of an URI. GFile
+ has problems decoding URIs with percent signs on them.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startGio):
+
+2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Protect the ResourceHandle instance from being destroyed by
+ didReceiveData inside the GIO readCallback call, so that
+ cancelling caused by scripts is handled correctly.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::readCallback):
+
+2009-02-20 David Kilzer <ddkilzer@apple.com>
+
+ Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
+
+ Reviewed by Sam Weinig.
+
+ * loader/icon/IconDatabaseNone.cpp:
+ (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
+ (WebCore::IconDatabase::open): Commented out unused parameter.
+ (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
+ (WebCore::IconDatabase::iconForPageURL): Ditto.
+ (WebCore::IconDatabase::iconURLForPageURL): Ditto.
+ (WebCore::IconDatabase::defaultIcon): Ditto.
+ (WebCore::IconDatabase::retainIconForPageURL): Ditto.
+ (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
+ (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
+ (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
+ (WebCore::IconDatabase::setEnabled): Ditto.
+ (WebCore::IconDatabase::pageURLMappingCount): Added stub.
+ (WebCore::IconDatabase::retainedPageURLCount): Ditto.
+ (WebCore::IconDatabase::iconRecordCount): Ditto.
+ (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
+
+2009-02-20 David Kilzer <ddkilzer@apple.com>
+
+ Add comment to generated code when shadowing a built-in object
+
+ Reviewed by Sam Weinig.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Added comment to
+ generated code output.
+
+2009-02-20 Avi Drissman <avi@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24036
+ Keyboard events need disambiguation on the Linux platform too.
+
+ * platform/chromium/PlatformKeyboardEventChromium.cpp:
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
+
+2009-02-19 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24046
+
+ Several improvements to CString:
+ 1- Make it possible to initialize a CString from a CStringBuffer
+ 2- Make it possible to get a CStringBuffer from a CString
+ 3- Change CStringBuffer::data() to return a const pointer to ward off mutation
+ 4- Remove unused releaseBuffer() methods.
+ 5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
+
+ * platform/text/CString.cpp:
+ (WebCore::CString::init):
+ (WebCore::CString::mutableData):
+ (WebCore::CString::newUninitialized):
+ (WebCore::CString::copyBufferIfNeeded):
+ * platform/text/CString.h:
+ (WebCore::CStringBuffer::data):
+ (WebCore::CStringBuffer::length):
+ (WebCore::CStringBuffer::create):
+ (WebCore::CStringBuffer::mutableData):
+ (WebCore::CString::CString):
+ (WebCore::CString::buffer):
+
+2009-02-19 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24017
+ Remove some usage of Document in Worker.
+
+ * dom/WorkerContext.h:
+ (WebCore::WorkerContext::userAgent):
+ * dom/Document.cpp:
+ (WebCore::Document::userAgent):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+ Added virtual ScriptExecutionContext::userAgent(const KURL&).
+ Document implementation uses FrameLoader::userAgent and
+ WorkerContext receives the string on creation and stores it in a member.
+
+ * dom/Worker.cpp:
+ (WebCore::Worker::Worker):
+ (WebCore::Worker::notifyFinished):
+ * dom/Worker.h:
+ (WebCore::Worker::create):
+ Instead of Document the Worker constructor now gets a ScriptExecutionContext.
+ Start using some methods on SEC (like completeURL() and userAgent()).
+ For others, explicitly case to Document and add a FIXME.
+ Remove Worker::document() too.
+
+2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Rubber-stamped by Holger Freyther.
+
+ Do not set httpStatus to SOUP_STATUS_OK when serving local files
+ to match other ports' behavior, fixing xmlhttprequest test
+ regressions.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::queryInfoCallback):
+
+2009-02-19 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
+ Do not send loader callbacks during CSS styling
+
+ Undo the iChat-specific quirk added in
+ <http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
+ cache client callbacks during attach() and recalcStyle().
+
+ * WebCore.base.exp: Removed
+ Settings::setNeedsIChatMemoryCacheCallsQuirk().
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory
+ cache client callbacks and remember to enable them afterwards if needed.
+ (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory
+ cache client callbacks if they were disabled in
+ suspendPostAttachCallbacks().
+ (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and
+ resumePostAttachCallbacks().
+ * dom/ContainerNode.h: Made suspendPostAttachCallbacks()
+ and resumePostAttachCallbacks() non-static.
+ * dom/Document.cpp:
+ (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific
+ workaround.
+ * page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and
+ related code.
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+
+2009-02-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix.
+
+ Build fix after r41092. Make the memoryUsage method
+ public. It will be shadowed by cf/mac and for curl/soup/qt
+ the implementation from ResourceResponseBase will be used.
+
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::memoryUsage):
+
+2009-02-19 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for <rdar://problem/6077775> Should be able to specify
+ inactive ::selection color
+
+ This patch makes the ::selction pseudo-element work with
+ the :window-inactive pseudo type. This was, a user can specify a
+ different ::selection style when a window is inactive.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::selectionBackgroundColor):
+ (WebCore::RenderObject::selectionForegroundColor):
+
+2009-02-19 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Beth Dakin.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=24044
+ Update querySelector/querySelectorAll to match the latest spec
+
+ Update querySelector and querySelectorAll to match the latest version
+ of the Selectors API spec. We now stringify null and undefined to "null"
+ and "undefined" respectively instead of to "".
+
+ Test: fast/dom/SelectorAPI/undefined-null-stringify.html
+
+ * dom/Document.idl:
+ * dom/DocumentFragment.idl:
+ * dom/Element.idl:
+
+2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23732
+ Rework CachedResource overhead accounting to allow platforms to diverge
+ in numbers.
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse
+ for its size and to use actual URL size.
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::size): Added default size method.
+ * platform/network/cf/ResourceResponse.h:
+ (WebCore::ResourceResponse::size): Added Win/CF size method
+ * platform/network/mac/ResourceResponse.h:
+ (WebCore::ResourceResponse::size): Added Mac size method.
+
+2009-02-19 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ - Fix for <rdar://problem/6604968>
+
+ On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
+ after the call to -[NSView displayRectIgnoringOpacity:inContext:].
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::paint):
+
+2009-02-19 David Hyatt <hyatt@apple.com>
+
+ Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
+ also consider reflections to be part of their visual overflow. This had already been done for blocks
+ and lines, but it wasn't being done yet for replaced elements.
+
+ Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
+ transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
+ layer it pushed until we're done painting the real object (rather than the reflection).
+
+ Reviewed by Dan Bernstein
+
+ Added fast/reflections/reflection-masks-opacity.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer):
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::layout):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::layout):
+ (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
+ * rendering/RenderReplaced.h:
+
+2009-02-19 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
+ <https://bugs.webkit.org/show_bug.cgi?id=23980>
+
+ WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.
+ * When WorkerRunLoop::runInMode is called, only task for that mode will run.
+ * When WorkerRunLoop::run is called (or the default mode is used), then all tasks
+ will run regardless of their posted mode.
+
+ Here's a demonstration of the api:
+
+ RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);
+
+ // Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
+ // for any tasks that need to be run during this loop.
+ nameResolution->setTaskMode("MyCoolMode");
+
+ nameResolution->start();
+ while (!nameResolution->done()) {
+ // Only tasks which are posted for "MyCoolMode" will run.
+ workerRunLoop.runInMode(context, "MyCoolMode");
+ }
+
+ No observable change in behavior, so no test.
+
+ * dom/WorkerRunLoop.cpp:
+ (WebCore::ModePredicate::ModePredicate):
+ (WebCore::ModePredicate::operator()):
+ (WebCore::WorkerRunLoop::WorkerRunLoop):
+ (WebCore::WorkerRunLoop::~WorkerRunLoop):
+ (WebCore::WorkerRunLoop::setSharedTimer):
+ (WebCore::WorkerRunLoop::resetSharedTimer):
+ (WebCore::WorkerRunLoop::run):
+ (WebCore::WorkerRunLoop::runInMode):
+ (WebCore::WorkerRunLoop::postTask):
+ (WebCore::WorkerRunLoop::postTaskForMode):
+ * dom/WorkerRunLoop.h:
+ (WebCore::WorkerRunLoop::Task::create):
+ (WebCore::WorkerRunLoop::Task::mode):
+ (WebCore::WorkerRunLoop::Task::performTask):
+ (WebCore::WorkerRunLoop::Task::Task):
+
+2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24034
+ Fix up Selection->VisibleSelection change.
+
+ * page/chromium/EventHandlerChromium.cpp:
+ (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection
+ to VisibleSelection.
+
+2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24041
+ Correct Skia type conversion issues, fix Chromium Linux build.
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.
+
+2009-02-19 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20531
+ Chromium-part follow-up to the patch landed in r40636
+ for bug 20531.
+ Remove a static member function alternateFamilyName
+ from Chromium's Win/Linux ports of FontCache. In r40636,
+ alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
+ So, there's no more need for the static member function per
+ platform.
+
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+
+2009-02-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Call documentWillBecomeInactive() from Document::detach to ensure that
+ media elements are shut down, because they may be kept alive by references
+ from JS past document teardown.
+
+ documentWillBecomeInactive() calls renderView()->willMoveOffscreen(), so no
+ need to do that in detach() as well.
+
+ We no longer need to call documentWillBecomeInactive() from ~Page() (which
+ was added for <https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
+ supersedes that change.
+
+ * dom/Document.cpp:
+ (WebCore::Document::detach):
+ * page/Page.cpp:
+ (WebCore::Page::~Page):
+
+2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24028
+ Fix up Skia path changes.
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
+ * platform/graphics/skia/PathSkia.cpp:
+ (WebCore::boundingBoxForCurrentStroke): Changed call name.
+
+2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Ignore ports on local URLs. This fixes a regression in
+ fast/loader/file-URL-with-port-number.html
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startGio):
+
+2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24011
+ KURL's setPort doesn't unset port if 0 is given
+
+ Make setPort remove port if 0 is given to it, as promised by the
+ comment in KURL's header.
+
+ * platform/KURL.cpp:
+ (WebCore::KURL::setPort):
+
+2009-02-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ - WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
+
+ The crash results from re-entry into
+ CSSMutableStyleDeclaration::setCssText, which in turn is caused by
+ the first style change causing a cached image to load from the memory
+ cache, causing load delegate dispatch, and iChat's delegate method
+ calling back into WebKit.
+
+ The workaround is to use defer delegate callbacks for memory cache. In
+ this case, deferring callbacks during image load event dispatch was
+ found to be sufficient.
+
+ The crash is a regression. See also the discussion in
+ <https://bugs.webkit.org/show_bug.cgi?id=22521>.
+
+ * WebCore.base.exp: Added
+ Settings::setNeedsIChatMemoryCacheCallsQuirk().
+ * dom/Document.cpp:
+ (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is
+ enabled, defer memory cache callbacks during image load event dispatch.
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize
+ m_needsIChatMemoryCacheCallsQuirk.
+ (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this
+ setter.
+ * page/Settings.h:
+ (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.
+
+2009-02-18 Adam Roben <aroben@apple.com>
+
+ Export WebCore::handCursor and Cursor.h
+
+ Reviewed by John Sullivan.
+
+ * WebCore.base.exp: Added WebCore::handCursor.
+ * WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.
+
+2009-02-18 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23992
+ REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do
+
+ Unable to reduce to a layout test.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::contentRenderer):
+
+2009-02-18 Evan Stade <estade@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23861
+ Stroke font outlines on chromium linux
+
+ TEST=LayoutTests/svg/custom/pointer-events-text.svg
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::Font::drawGlyphs):
+
+2009-02-18 Evan Stade <estade@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23860
+ Resync some graphics/skia files with their chromium counterparts
+
+ This comes from chromium patches <http://codereview.chromium.org/17633>
+ and <http://codereview.chromium.org/17454>
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::clipPath):
+ (WebCore::GraphicsContext::fillPath):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::addPath):
+ (PlatformContextSkia::currentPath):
+ * platform/graphics/skia/PlatformContextSkia.h:
+
+2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
+
+ Unreviewed.
+
+ Build fix after r41060.
+
+ * GNUmakefile.am:
+
+2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24005
+ Add an include to fix Chromium build.
+
+ * page/animation/AnimationController.cpp: Add UnusedParam.h include.
+
+2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ Fix symbols.filter location, and add other missing files to the
+ autotools build, so that make dist works.
+
+ * GNUmakefile.am:
+
+2009-02-18 Zan Dobersek <zandobersek@gmail.com>
+
+ Rubber-stamped by Holger Hans Peter Freyther.
+
+ Allow POST method for local requests.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startGio):
+
+2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Hans Peter Freyther.
+
+ Use KURL in startGio instead of passing a string with the URL, so
+ that we can handle removing refs and queries more elegantly. This
+ is fixing more regressions that came from the curl->soup switch.
+
+ Original work by Zan Dobersek.
+
+ * platform/network/ResourceHandle.h:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::startGio):
+
+2009-02-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp
+
+ The implementation is needed to have synchronous loading, e.g. for
+ JavaScript interaction. This is fixing various regressions that
+ came from the curl->soup switch.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
+ (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
+ (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
+ (WebCore::WebCoreSynchronousLoader::didReceiveData):
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading):
+ (WebCore::WebCoreSynchronousLoader::didFail):
+ (WebCore::WebCoreSynchronousLoader::run):
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+
+2009-02-18 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23989
+
+ Based on a patch by Bo Yang <techrazy.yang@gmail.com>
+
+ Make the cursor cache global, that's all we really need and
+ otherwise we can miss cursor transitions in some situations (see
+ the bug for one testcase). Also remove some now useless code.
+
+ * platform/Widget.h:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::setCursor):
+
+2009-02-17 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * loader/FrameLoader.cpp:
+ (WebCore::toPlugInElement): Don't rely on #if being processed before
+ ASSERT.
+
+2009-02-17 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23977: Unnecessary timer related headers in files.
+ <https://bugs.webkit.org/show_bug.cgi?id=23977>
+
+ No observable change in behavior, so no test.
+
+ * dom/Document.cpp:
+ * dom/WorkerRunLoop.cpp:
+ * dom/WorkerRunLoop.h:
+
+2009-02-17 Peter Abrahamsen <rainhead@gmail.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23958
+ <rdar://problem/6587815>
+
+ Updated XMLHttpRequest with new header names from the latest Access
+ Control draft: http://www.w3.org/TR/access-control/
+ - Access-Control-Origin becomes Access-Control-Allow-Origin
+ - Access-Control-Credentials becomes Access-Control-Allow-Credentials
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::accessControlCheck):
+
+2009-02-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Add missing constructor used for empty values.
+
+ * platform/graphics/wx/FontPlatformData.h:
+ (WebCore::FontPlatformData::FontPlatformData):
+
+2009-02-17 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ <rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated
+
+ Need update after callback.
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+
+2009-02-17 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23917
+ Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
+ element.
+
+ * DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
+
+ * WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
+
+ * WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate.
+ (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the
+ proxy plug-in handles the poster frame.
+ (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO.
+ (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO.
+ (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO
+ (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the
+ same plug-in for the life of the element.
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player
+ network state changes to EMPTY, otherwise we can get out of sync with engine.
+ (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO
+ (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to
+ media player.
+ (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player.
+ (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate
+ <source> element to be used as the initial url for the proxy.
+ (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
+ * html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate.
+ (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
+
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO.
+ (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
+ * html/HTMLVideoElement.h:
+
+ * loader/FrameLoader.cpp:
+ (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::MediaPlayer): Remove white space.
+ (WebCore::MediaPlayer::setPoster): New, forward call to private player.
+ (WebCore::MediaPlayer::deliverNotification): Ditto.
+ (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayer::mediaPlayerClient):
+
+ * platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
+
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a
+ non-element node doesn't need a renderer
+ * rendering/RenderPart.h: Ditto.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::RenderPartObject): Ditto.
+ (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is
+ <video> or <audio>.
+ * rendering/RenderPartObject.h:
+
+2009-02-17 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
+
+ Don't allow legends to be anything but display:block.
+
+ Added fast/forms/inline-ignored-on-legend.html
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * css/html4.css:
+ * html/HTMLLegendElement.cpp:
+ * html/HTMLLegendElement.h:
+ * rendering/RenderLegend.cpp: Removed.
+ * rendering/RenderLegend.h: Removed.
+ * wml/WMLInsertedLegendElement.cpp:
+ * wml/WMLInsertedLegendElement.h:
+
+2009-02-13 Brett Wilson <brettw@dhcp-172-22-71-167.mtv.corp.google.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/attachment.cgi?id=27666
+ Fix Chromium build build: forgotten include in RenderObject, sync
+ RenderTheme to the recent changes in RenderObject.
+
+ * rendering/RenderObject.cpp:
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::updatePressedState):
+
+2009-02-17 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22966
+ crash when destroying a webview that opened a page containing <script>
+ tags
+
+ Fix m_group being set to 0 instead of to m_singlePageGroup when
+ GroupName is set to empty
+
+ * page/Page.cpp:
+ (WebCore::Page::setGroupName):
+
+2009-02-16 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for <rdar://problem/6386623>
+
+ I made m_numParsedProperties and m_maxParsedProperties unsigned
+ instead of int, and then added an early return from addPropery() if
+ m_maxParsedProperties exceeds the max value.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::addProperty):
+ (WebCore::CSSParser::rollbackLastProperties):
+ (WebCore::CSSParser::clearProperties):
+ (WebCore::CSSParser::createFontFaceRule):
+ (WebCore::CSSParser::deleteFontFaceOnlyValues):
+ * css/CSSParser.h:
+
+2009-02-16 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16309
+ HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
+
+ When we originally implemented this command, MSDN documentation said that IE set the
+ id attribute of inserted lists to the third argument to execCommand, but IE doesn't
+ do this nor do any other browsers.
+
+ * editing/EditorCommand.cpp:
+ (WebCore::executeInsertOrderedList):
+ (WebCore::executeInsertUnorderedList):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::outdentParagraph):
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::insertList):
+ (WebCore::InsertListCommand::InsertListCommand):
+ (WebCore::InsertListCommand::doApply):
+ * editing/InsertListCommand.h:
+ (WebCore::InsertListCommand::create):
+
+2009-02-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ - fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
+
+ Test: platform/mac/fast/events/pointer-events-dashboard.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty): Do not apply the
+ pointer-events property in Dashboard backwards compatibility mode,
+ in order to work around misuse of that property by the Stocks widget.
+
+2009-02-16 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15381
+ execCommand justify modifies the contentEditable node
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just
+ the body element, but any root editable element.
+
+2009-02-16 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 23979: AX: alt tag not returned for <input type="image">
+ https://bugs.webkit.org/show_bug.cgi?id=23979
+
+ Test: accessibility/input-image-alt.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityDescription):
+
+2009-02-16 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ The ref data is not properly set unless we use the CreateMatrix function.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23978
+
+ * platform/graphics/wx/TransformationMatrixWx.cpp:
+ (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
+
+2009-02-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the
+ FontPlatformData(float, bool, bool) constructor.
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::createFontPlatformData): Changed to pass a valid
+ NSFont to the FontPlatformData constructor, instead of implicitly
+ passing 0 and then calling setFont().
+ * platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter
+ of the constructor mandatory.
+
+2009-02-15 David Kilzer <ddkilzer@apple.com>
+
+ Move duplicate caretWidth constants to RenderObject.h
+
+ Reviewed by Dan Bernstein.
+
+ No test since no change in behavior.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localCaretRect): Ditto.
+ * rendering/RenderObject.h: Added caretWidth definition.
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::localCaretRect): Removed caretWidth.
+
+2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23955
+ V8HTMLPlugInCustom returns undefined, which fools interceptors.
+
+ * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
+ (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value.
+ (WebCore::NAMED_PROPERTY_SETTER): Ditto.
+ (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
+ (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
+
+2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23954
+ Add V8 custom bindings for CanvasRenderingContext2D.
+
+ * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added.
+ (WebCore::toV8):
+ (WebCore::toCanvasStyle):
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+
+2009-02-13 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler and Dan Bernstein.
+
+ <rdar://problem/6583187>
+
+ * page/NavigatorBase.cpp:
+ Handle PPC64 and X86_64 as well.
+
+2009-02-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix broken tokenizer regression test that reflected a lifetime bug
+ in the document.write optimization. The test failure was trivial to
+ reproduce in COLLECT_ON_EVERY_ALLOCATION mode.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::documentWrite): Convert strings to String rather than passing
+ the pointer and length to SegmentedString. The optimization is thus
+ mostly gone. However, there are two ways to bring it back: 1) Apply
+ the patch that makes UString and String share the same buffers.
+ 2) Add a UString feature to SegmentedString; simple to do but might
+ risk slowing down normal document parsing.
+
+2009-02-13 Adam Treat <adam.treat@torchmobile.com>
+
+ Caught by Darin Adler.
+
+ No reason to check m_tokenizer twice for 0 in a row.
+
+ * dom/Document.cpp:
+ (WebCore::Document::write):
+
+2009-02-13 Lyon Chen <lyon.chen@torchmobile.com>
+
+ Reviewed by Dave Hyatt.
+
+ Take into account y() + height() when calculating getLowerRightCorner.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getLowerRightCorner):
+
+2009-02-13 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Most of this code was in RenderBox, restore the copyright lines.
+
+ * rendering/RenderBoxModelObject.cpp:
+ * rendering/RenderBoxModelObject.h:
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Get rid of printBoxDecorations, since it is dead code.
+
+ Reviewed by Dan Bernstein
+
+ * rendering/RenderObject.h:
+
+2009-02-13 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23952
+ Add Document::write overload which takes a SegmentedString since this
+ is what the tokenizer expects anyway. Modified JSHTMLDocument so it once
+ again calls Document::write instead of injecting the string directly into
+ the tokenizer. This ensures that all document.write's are funneled through
+ one method again, but should still be just as fast for JSHTMLDocumentCustom.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::documentWrite):
+ * dom/Document.cpp:
+ (WebCore::Document::write):
+ * dom/Document.h:
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ Remove updateWidgetPosition on RenderObject. Change RenderView's set of widgets
+ to have a tighter type: RenderWidget instead of RenderObject. Devirtualize
+ updateWidgetPosition, since all RenderWidgets (except for applets) are now
+ RenderParts also.
+
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderPart.cpp:
+ * rendering/RenderPart.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::updateWidgetPositions):
+ (WebCore::RenderView::addWidget):
+ (WebCore::RenderView::removeWidget):
+ * rendering/RenderView.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::updateWidgetPosition):
+ * rendering/RenderWidget.h:
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Remove isEditable() on RenderObject. It is dead code.
+
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Add isTextControl() to RenderObject. Patch call sites thats asked isTextField() || isTextArea() to just use
+ isTextControl() instead.
+
+ Add a toRenderTextControl converter for doing checked casting to RenderTextControls.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::updateSelectionRange):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::handleReplacedElement):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::selectionStart):
+ (WebCore::HTMLInputElement::selectionEnd):
+ (WebCore::HTMLInputElement::setSelectionStart):
+ (WebCore::HTMLInputElement::setSelectionEnd):
+ (WebCore::HTMLInputElement::select):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ (WebCore::HTMLInputElement::selection):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::selectionStart):
+ (WebCore::HTMLTextAreaElement::selectionEnd):
+ (WebCore::HTMLTextAreaElement::setSelectionStart):
+ (WebCore::HTMLTextAreaElement::setSelectionEnd):
+ (WebCore::HTMLTextAreaElement::select):
+ (WebCore::HTMLTextAreaElement::setSelectionRange):
+ (WebCore::HTMLTextAreaElement::appendFormData):
+ (WebCore::HTMLTextAreaElement::updateValue):
+ (WebCore::HTMLTextAreaElement::selection):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isNativeTextControl):
+ (WebCore::AccessibilityRenderObject::text):
+ (WebCore::AccessibilityRenderObject::selectedText):
+ (WebCore::AccessibilityRenderObject::selectedTextRange):
+ (WebCore::AccessibilityRenderObject::setSelectedTextRange):
+ (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
+ (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
+ (WebCore::AccessibilityRenderObject::observableObject):
+ * page/Frame.cpp:
+ (WebCore::Frame::notifyRendererOfSelectionChange):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isTextControl):
+ (WebCore::objectIsRelayoutBoundary):
+ * rendering/RenderTextControl.h:
+ (WebCore::RenderTextControl::isTextControl):
+ (WebCore::toRenderTextControl):
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::select):
+ (WebCore::WMLInputElement::defaultEventHandler):
+ (WebCore::WMLInputElement::isConformedToInputMask):
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Get rid of isEdited/setEdited on RenderObject. Devirtualize isEdited/setEdited on RenderTextControl.
+ Callers were already asking if the renderer was a text field (or a text area), so it was especially
+ pointless to waste a second virtual function call after making one just to determine the object type.
+
+ Reviewed by Simon Fraser
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * rendering/RenderObject.h:
+ * rendering/RenderTextControl.h:
+ (WebCore::RenderTextControl::isEdited):
+ (WebCore::RenderTextControl::setEdited):
+
+2009-02-13 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23934
+ Skia platform doesn't render text decoration shadows.
+
+ Makes Skia render text decoration shadows correctly. We weren't
+ preparing the SkPaint correctly and didn't have a couple of checks
+ CG has. Additionally makes the fillColor/strokeColor methods
+ consistent.
+
+ This behavior is covered by existing layout tests (see bug for list).
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::drawLineForText):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::effectiveFillColor):
+ (PlatformContextSkia::effectiveStrokeColor):
+ * platform/graphics/skia/PlatformContextSkia.h:
+
+2009-02-12 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23944
+ KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
+
+ * platform/KURL.h:
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURLGooglePrivate::setUtf8):
+ (WebCore::KURLGooglePrivate::setAscii):
+ (WebCore::KURLGooglePrivate::init):
+ (WebCore::KURLGooglePrivate::replaceComponents):
+ (WebCore::KURL::KURL):
+ * platform/KURLGooglePrivate.h:
+
+2009-02-13 David Hyatt <hyatt@apple.com>
+
+ Remove leftmost/rightmost/lowestPosition from RenderObject. They only need to be called on boxes.
+
+ Reviewed by Dan Bernstein
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::computeScrollDimensions):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::lowestPosition):
+ (WebCore::RenderMedia::rightmostPosition):
+ (WebCore::RenderMedia::leftmostPosition):
+ * rendering/RenderObject.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::lowestPosition):
+ (WebCore::RenderTableSection::rightmostPosition):
+ (WebCore::RenderTableSection::leftmostPosition):
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build with ACCELERATED_COMPOSITING turned on.
+
+ toRenderBox()->x() asserts for a layer on an inline; use
+ m_owningLayer->renderBoxX() instead.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+
+2009-02-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Speed up document.write a bit.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from
+ UString to String and to avoid appending strings. Also added code to handle
+ newlines efficiently.
+ (WebCore::JSHTMLDocument::write): Changed to use documentWrite.
+ (WebCore::JSHTMLDocument::writeln): Ditto.
+
+ * dom/Document.cpp:
+ (WebCore::Document::prepareToWrite): Added. Refactored the initialization part
+ of write into a separate function for use in the JavaScript binding.
+ (WebCore::Document::write): Changed to call prepareToWrite.
+
+ * dom/Document.h: Added declaration for prepareToWrite.
+
+2009-02-13 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fixes crash in the Qt port on Windows with comboboxes
+
+ The focusWidget in the input context is not reset properly.
+ The QApplication::setFocusWidget() wont reset the IC if the reason is
+ PopupFocusReason, this is not ideal. For the time being we are going
+ to do this from webkit itself.
+
+ * platform/qt/QWebPopup.cpp:
+ (WebCore::QWebPopup::hidePopup):
+
+2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix, typo while tweaking last patch for commit.
+
+ * platform/wx/wxcode/gtk/fontprops.cpp:
+ (GetTextExtent):
+
+2009-02-12 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Use Cairo/PANGO to fix text measurements and implement proper
+ non-kerned text drawing on wxGTK.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17727
+
+ * platform/graphics/GlyphBuffer.h:
+ * platform/graphics/wx/FontPlatformDataWx.cpp:
+ (WebCore::fontWeightToWxFontWeight):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/wx/wxcode/fontprops.h:
+ * platform/wx/wxcode/gtk/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+ (GetTextExtent):
+ * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
+ (WebCore::pangoFontMap):
+ (WebCore::createPangoFontForFont):
+ (WebCore::createScaledFontForFont):
+ (WebCore::pango_font_get_glyph):
+ (WebCore::drawTextWithSpacing):
+ * platform/wx/wxcode/non-kerned-drawing.h:
+
+2009-02-12 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=23942
+
+ Hook up 3D CSS transforms to the accelerated compositor backend.
+ Not enabled by default.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ (WebCore::ensurePropertyMap):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::willNeedService):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::willNeedService):
+ * platform/graphics/GraphicsLayer.cpp:
+ (WebCore::GraphicsLayer::TransformValueList::makeFunctionList):
+ (WebCore::GraphicsLayer::dumpProperties):
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::copyTransform):
+ (WebCore::getValueFunctionNameForTransformOperation):
+ (WebCore::GraphicsLayerCA::animateTransform):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::updateBoxModelInfoFromStyle):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::hasTransformStyle3D):
+ (WebCore::RenderLayer::hasPerspective):
+ (WebCore::RenderLayer::perspectiveTransform):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayers):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ (WebCore::RenderLayerBacking::computeTransformOrigin):
+ (WebCore::RenderLayerBacking::computePerspectiveOrigin):
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::has3DContent):
+ (WebCore::requiresCompositingLayerForTransform):
+ (WebCore::RenderLayerCompositor::requiresCompositingLayer):
+ (WebCore::RenderLayerCompositor::layerHas3DContent):
+ * rendering/RenderLayerCompositor.h:
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
+ containingBlock()->availableHeight(). The latter reads better anyway. Rename containingBlockWidth() to
+ containingBlockWidthForContent() and move it to RenderBoxModelObject.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::localCaretRect):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::containingBlockWidthForContent):
+ (WebCore::RenderBox::calcWidth):
+ (WebCore::RenderBox::calcReplacedWidthUsing):
+ * rendering/RenderBox.h:
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::relativePositionOffsetX):
+ (WebCore::RenderBoxModelObject::relativePositionOffsetY):
+ (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::marginLeft):
+ (WebCore::RenderInline::marginRight):
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::calcReplacedWidth):
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Fix non-Mac builds by adding Matrix3DTransformOperation.* and
+ PerspectiveTransformOperation.*. Cleaned out some cruft in
+ the WebCore.vcproj fle.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-02-12 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=23935
+ Nested :not() and non-simple selectors in :not() should be invalid
+
+ * css/CSSGrammar.y: Reject nested :not()
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now
+
+2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes.
+
+ * WebCoreSources.bkl:
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build with ACCELERATED_COMPOSITING turned on.
+
+ Need to cast toRenderBox() in order to call overflowClipRect().
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
+2009-02-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix windows build.
+
+ * css/CSSParser.h:
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect. Move them to RenderBox, since these methods
+ only apply to boxes. Devirtualize clipRect, since it was not subclassed. Move controlClip stuff to RenderBox also.
+
+ Reviewed by Simon Fraser
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::insideVisibleArea):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::overflowClipRect):
+ (WebCore::RenderBox::clipRect):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::hasControlClip):
+ (WebCore::RenderBox::controlClipRect):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::paint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::calculateClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::hasClip):
+ (WebCore::RenderObject::hasOverflowClip):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::overflowClipRect):
+ * rendering/RenderTable.h:
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)
+
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::setBasicAnimation):
+
+2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Not reviewed.
+
+ Release build fix when VIDEO is disabled (it should also
+ help the builds with WORKERS or XSLT disabled).
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when
+ VIDEO is disabled.
+ (jsDOMWindowBaseWorker): Ditto for WORKERS.
+ (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
+
+2009-02-12 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23923
+ Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
+ Supporting this requires that we know when we are processing a media engine callback so
+ we don't turn around and tell the media player to change the volume when it is reporting
+ a volume change.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback
+ (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged
+ to make it easier to maintain m_processingMediaPlayerCallback.
+ (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
+ (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto.
+ (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New
+ (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing
+ a callback from the engine.
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::processingMediaPlayerCallback): New, return true if (m_processingMediaPlayerCallback>0)
+ (WebCore::HTMLMediaElement::beginProcessingMediaPlayerCallback): New, increment m_processingMediaPlayerCallback
+ (WebCore::HTMLMediaElement::endProcessingMediaPlayerCallback): New, decrement m_processingMediaPlayerCallback
+
+2009-02-12 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Support MPEG content on Mac and Windows.
+ <rdar://problem/5917509>
+ https://bugs.webkit.org/show_bug.cgi?id=23495
+
+ Test: media/audio-mpeg-supported.html
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::disableUnsupportedTracks):
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: fix typo added in r40925
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig
+
+ Move containsFloats, hasOverhangingFloats, shrinkToAvoidFloats and avoidsFloats down to
+ RenderBox, since these methods only apply to boxes.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::clearFloats):
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+ (WebCore::RenderBlock::calcBlockPrefWidths):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::containsFloats):
+ (WebCore::RenderBlock::hasOverhangingFloats):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::shrinkToAvoidFloats):
+ (WebCore::RenderBox::avoidsFloats):
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isFloatingOrPositioned):
+ * rendering/RenderView.h:
+
+2009-02-12 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23908
+
+ Added parsing of 3d transform functions and properties
+ (perspective, perspective-origin, transform-style-3d,
+ and backface-visibility).
+
+ Test: transforms/3d/cssmatrix-3d-interface.xhtml
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::):
+ (WebCore::computedTransform):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseFillProperty):
+ (WebCore::CSSParser::parseTransformOriginShorthand):
+ (WebCore::TransformOperationInfo::TransformOperationInfo):
+ (WebCore::CSSParser::parseTransform):
+ (WebCore::CSSParser::parseTransformOrigin):
+ (WebCore::CSSParser::parsePerspectiveOrigin):
+ * css/CSSParser.h:
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::isUnitTypeLength):
+ * css/CSSPropertyNames.in:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ (WebCore::convertToLength):
+ (WebCore::CSSStyleSelector::applyProperty):
+ (WebCore::CSSStyleSelector::mapFillSize):
+ (WebCore::CSSStyleSelector::mapFillXPosition):
+ (WebCore::CSSStyleSelector::mapFillYPosition):
+ (WebCore::getTransformOperationType):
+ (WebCore::CSSStyleSelector::createTransformOperations):
+ * css/CSSValueKeywords.in:
+ * css/WebKitCSSTransformValue.cpp:
+ (WebCore::WebKitCSSTransformValue::cssText):
+ * css/WebKitCSSTransformValue.h:
+ (WebCore::WebKitCSSTransformValue::):
+ * css/WebKitCSSTransformValue.idl:
+ * platform/graphics/transforms/Matrix3DTransformOperation.cpp:
+ * platform/graphics/transforms/Matrix3DTransformOperation.h:
+ * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
+ * platform/graphics/transforms/PerspectiveTransformOperation.h:
+ * platform/graphics/transforms/RotateTransformOperation.cpp:
+ (WebCore::RotateTransformOperation::blend):
+ * platform/graphics/transforms/RotateTransformOperation.h:
+ (WebCore::RotateTransformOperation::RotateTransformOperation):
+ * platform/graphics/transforms/ScaleTransformOperation.h:
+ (WebCore::ScaleTransformOperation::ScaleTransformOperation):
+ * platform/graphics/transforms/TransformOperation.h:
+ (WebCore::TransformOperation::is3DOperation):
+ * platform/graphics/transforms/TransformOperations.h:
+ (WebCore::TransformOperations::has3DOperation):
+ * platform/graphics/transforms/TranslateTransformOperation.h:
+ (WebCore::TranslateTransformOperation::TranslateTransformOperation):
+
+2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * webcore-base.bkl:
+
+2009-02-12 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.
+
+ * platform/mac/SharedBufferMac.mm: Change to use RefPtr<> instead of ref()/deref().
+ (-[WebCoreSharedBufferData dealloc]):
+ (-[WebCoreSharedBufferData finalize]):
+ (-[WebCoreSharedBufferData initWithSharedBuffer:]):
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Remove calcWidth from RenderObject. Nobody ever called it on RenderObjects.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderObject.h:
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Mark Rowe
+
+ Fix for regression where form controls would paint yellow highlights. The containsComposition check needs to
+ null check node() now.
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix
+
+ Change Animation::setDirection() to take the new enum value, and fix
+ the single caller.
+
+ Fix build error in MediaPlayerPrivateQTKit.h.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapAnimationDirection):
+ * platform/animation/Animation.h:
+ (WebCore::Animation::setDirection):
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ Remove the overrideSize methods from RenderObject. Devirtualize all of the accessors on RenderBox.
+
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.h:
+
+2009-02-12 Eric Carlson <eric.carlson@apple.com>
+
+ Darin Adler, Antti Koivisto, Holger Hans Peter Freyther
+
+ Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
+ https://bugs.webkit.org/show_bug.cgi?id=23797
+
+ * WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to
+ MediaPlayer::load so it can choose the right media engine
+ (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry
+ functions to strip params from the url and extract the codecs parameter. call
+ MediaPlayer::supportsType to see if we can open the file since only a media engine can
+ answer questions about supported type+codecs.
+ * html/HTMLMediaElement.h:
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter
+ (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
+ * platform/MIMETypeRegistry.h:
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate):
+ (WebCore::NullMediaPlayerPrivate::load):
+ (WebCore::NullMediaPlayerPrivate::cancelLoad):
+ (WebCore::NullMediaPlayerPrivate::play):
+ (WebCore::NullMediaPlayerPrivate::pause):
+ (WebCore::NullMediaPlayerPrivate::naturalSize):
+ (WebCore::NullMediaPlayerPrivate::hasVideo):
+ (WebCore::NullMediaPlayerPrivate::setVisible):
+ (WebCore::NullMediaPlayerPrivate::duration):
+ (WebCore::NullMediaPlayerPrivate::currentTime):
+ (WebCore::NullMediaPlayerPrivate::seek):
+ (WebCore::NullMediaPlayerPrivate::seeking):
+ (WebCore::NullMediaPlayerPrivate::setEndTime):
+ (WebCore::NullMediaPlayerPrivate::setRate):
+ (WebCore::NullMediaPlayerPrivate::paused):
+ (WebCore::NullMediaPlayerPrivate::setVolume):
+ (WebCore::NullMediaPlayerPrivate::networkState):
+ (WebCore::NullMediaPlayerPrivate::readyState):
+ (WebCore::NullMediaPlayerPrivate::maxTimeSeekable):
+ (WebCore::NullMediaPlayerPrivate::maxTimeBuffered):
+ (WebCore::NullMediaPlayerPrivate::dataRate):
+ (WebCore::NullMediaPlayerPrivate::totalBytesKnown):
+ (WebCore::NullMediaPlayerPrivate::totalBytes):
+ (WebCore::NullMediaPlayerPrivate::bytesLoaded):
+ (WebCore::NullMediaPlayerPrivate::setRect):
+ (WebCore::NullMediaPlayerPrivate::paint):
+ (WebCore::createNullMediaPlayer):
+ Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.
+
+ (WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
+ (WebCore::installedMediaEngines): New, returns vector of all installed engines.
+ (WebCore::addMediaEngine): New, add a media engine to the cache.
+ (WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
+ (WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
+ (WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
+ (WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right
+ media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
+ based on the MIME type and codecs parameter.
+ (WebCore::MediaPlayer::currentTime): Remove excess white space.
+ (WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
+ indicate "maybe" condition.
+ (WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
+ (WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.
+
+ * platform/graphics/MediaPlayer.h:
+ (WebCore::MediaPlayer::):
+ (WebCore::MediaPlayer::frameView): accessor function.
+
+ * platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines.
+ (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface):
+ (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):
+
+ * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivate::create): New, media engine factory function
+ (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory
+ (WebCore::MediaPlayerPrivate::load): URL is a const String.
+ (WebCore::MediaPlayerPrivate::duration): Declare const.
+ (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
+ (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
+ (WebCore::MediaPlayerPrivate::networkState): Ditto.
+ (WebCore::MediaPlayerPrivate::readyState): Ditto.
+ (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto.
+ (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto.
+ (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
+ (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto.
+ (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto.
+ (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
+ (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
+ (WebCore::MediaPlayerPrivate::isAvailable):
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function
+ (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory
+ (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly,
+ use accessor function.
+ (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto.
+ (WebCore::MediaPlayerPrivate::paint): Ditto.
+ (WebCore::mimeTypeCache): New.
+ (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function.
+ (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool
+ (-[WebCoreMovieObserver initWithCallback:]): fix formatting
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::create):
+ (WebCore::MediaPlayerPrivate::registerMediaEngine):
+ (WebCore::MediaPlayerPrivate::supportsType):
+ (WebCore::MediaPlayerPrivate::load): URL is a const String.
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
+ (WebCore::MediaPlayerPrivate::isAvailable):
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::create): New, media engine factory function
+ (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory
+ (WebCore::MediaPlayerPrivate::load): URL is a const String.
+ (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly,
+ use accessor function.
+ (WebCore::mimeTypeCache): New.
+ (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function.
+ (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+
+2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Test: fast/dom/prefixed-image-tag.xhtml
+
+ Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
+
+ Instead we now directly propage the QualifiedName inside the generated Factory.
+
+ Test: fast/dom/prefixed-image-tag.xhtml
+
+ * dom/Document.cpp:
+ (WebCore::Document::createElement): Removed the setPrefix work-around
+ and replaced it with an ASSERT to catch mistakes inside the Factory code.
+ Remove the unneeded ExceptionCode argument.
+
+ (WebCore::Document::createElementNS): Removed ExceptionCode argument.
+ * dom/Document.h: Updated the signature.
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
+ * dom/XMLTokenizerQt.cpp: Ditto.
+ (WebCore::XMLTokenizer::parseStartElement): Ditto.
+
+ * dom/make_names.pl: Implemented the QualifiedName propogation logic
+ in the Factory.
+
+2009-02-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23188
+
+ Define enum values for Animation::direction(), and one for
+ IterationCountInfinite to make the code more self-documenting.
+
+ Order the member vars of Animation to optimize packing.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * platform/animation/Animation.cpp:
+ (WebCore::Animation::Animation):
+ (WebCore::Animation::operator=):
+ (WebCore::Animation::animationsMatch):
+ * platform/animation/Animation.h:
+ (WebCore::Animation::):
+ (WebCore::Animation::direction):
+ (WebCore::Animation::initialAnimationDirection):
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::GraphicsLayerCA::setBasicAnimation):
+ (WebCore::GraphicsLayerCA::setKeyframeAnimation):
+
+2009-02-12 Christian Dywan <christian@twotoasts.de>
+
+ Reviewed by Holger Freyther.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.
+
+2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23826: Potential bug with before/after rule while moving element from one document to another
+
+ Moved the document before/after toggle from the constructor to insertedIntoDocument.
+
+ Test: fast/css-generated-content/beforeAfter-interdocument.html
+
+ * html/HTMLQuoteElement.cpp:
+ (WebCore::HTMLQuoteElement::HTMLQuoteElement):
+ (WebCore::HTMLQuoteElement::insertedIntoDocument):
+ * html/HTMLQuoteElement.h:
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
+
+ I have no idea why this broke. As far as I can tell the old code never should have worked in
+ the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node
+ in order to attempt a wheel scroll.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleWheelEvent):
+
+2009-02-12 David Hyatt <hyatt@apple.com>
+
+ Move the functions that paint borders, box shadows and border images into RenderBoxModelObject. drawBorder and drawBorderArc, because they are used
+ for outlines as well as borders, need to stay in RenderObject. Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
+ more generic use. Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.
+
+ Reviewed by Simon Fraser
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paintFillLayer):
+ (WebCore::InlineFlowBox::paintBoxShadow):
+ (WebCore::InlineFlowBox::paintBoxDecorations):
+ (WebCore::InlineFlowBox::paintMask):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintColumns):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintNinePieceImage):
+ (WebCore::RenderBoxModelObject::paintBorder):
+ (WebCore::RenderBoxModelObject::paintBoxShadow):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::paintBorderMinusLegend):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::paintOutlineForLine):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::drawLineForBoxSide):
+ (WebCore::RenderObject::drawArcForBoxSide):
+ (WebCore::RenderObject::paintOutline):
+ * rendering/RenderObject.h:
+ (WebCore::):
+ (WebCore::RenderObject::hasBoxDecorations):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::CollapsedBorders::addBorder):
+ (WebCore::RenderTableCell::paintCollapsedBorder):
+
+2009-02-12 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser
+
+ Bug 18322: video element should have ui when scripting is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=18322
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
+ * manual-tests/media-controls-when-javascript-disabled.html: Added.
+
+2009-02-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23906
+ Add custom V8 bindings for HTMLPlugInElement.
+
+ * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::NAMED_PROPERTY_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::INDEXED_PROPERTY_GETTER):
+ (WebCore::INDEXED_PROPERTY_SETTER):
+
+2009-02-12 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Mark Rowe.
+
+ [GTK] Soup backend must handle upload of multiple files
+ https://bugs.webkit.org/show_bug.cgi?id=18343
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::):
+ (WebCore::freeFileMapping):
+ (WebCore::ResourceHandle::startHttp): Support multipart request bodies
+ mmap'ing files to be uploaded.
+
+2009-02-12 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build following r40871 which changed RenderObject::element()
+ into RenderObject::node().
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::getMediaElementFromRenderObject):
+ (WebCore::RenderThemeQt::getMediaControlForegroundColor):
+
+2009-02-12 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.
+
+2009-02-12 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Change worker code to use different proxy class pointers.
+ https://bugs.webkit.org/show_bug.cgi?id=23859
+
+ This is a step towards using separate proxies in multi-process implementation.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ * dom/Worker.cpp:
+ (WebCore::Worker::Worker):
+ (WebCore::Worker::~Worker):
+ (WebCore::Worker::postMessage):
+ (WebCore::Worker::terminate):
+ (WebCore::Worker::hasPendingActivity):
+ (WebCore::Worker::notifyFinished):
+ (WebCore::Worker::dispatchMessage):
+ * dom/Worker.h:
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::~WorkerContext):
+ (WebCore::WorkerContext::reportException):
+ (WebCore::WorkerContext::addMessage):
+ (WebCore::WorkerContext::postMessage):
+ (WebCore::WorkerContext::dispatchMessage):
+ * dom/WorkerContext.h:
+ * dom/WorkerContextProxy.h:
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerContextTask::performTask):
+ (WebCore::MessageWorkerTask::performTask):
+ (WebCore::WorkerContextProxy::create):
+ (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
+ (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
+ (WebCore::WorkerMessagingProxy::startWorkerContext):
+ (WebCore::postConsoleMessageTask):
+ (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
+ (WebCore::WorkerMessagingProxy::workerThreadCreated):
+ * dom/WorkerMessagingProxy.h:
+ * dom/WorkerObjectProxy.h:
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * dom/WorkerThread.h:
+ (WebCore::WorkerThread::workerObjectProxy):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+
+2009-02-12 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23688: ThreadableLoader needs a sync implementation for Workers.
+ <https://bugs.webkit.org/show_bug.cgi?id=23688>
+
+ Add ResourceError to ThreadableLoaderClient.
+
+ No observable change in behavior, so no test.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::create):
+ (WebCore::DocumentThreadableLoader::willSendRequest):
+ (WebCore::DocumentThreadableLoader::didFail):
+ * loader/ThreadableLoaderClient.h:
+ (WebCore::ThreadableLoaderClient::didFail):
+ (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
+ * loader/ThreadableLoaderClientWrapper.h:
+ (WebCore::ThreadableLoaderClientWrapper::didFail):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ (WebCore::workerContextDidFail):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
+ * loader/WorkerThreadableLoader.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::didFail):
+ (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
+ * xml/XMLHttpRequest.h:
+
+2009-02-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Fix the build on Leopard with ACCELERATED_COMPOSITING turned on.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ FloatPoint3D needs to be a private header, since it's included by GraphicsLayer.h
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::getTransformFunctionValue):
+ (WebCore::caValueFunctionSupported):
+ (WebCore::GraphicsLayerCA::setAnchorPoint):
+ (WebCore::GraphicsLayerCA::setPreserves3D):
+ (WebCore::GraphicsLayerCA::setContentsToImage):
+ (WebCore::GraphicsLayerCA::setBasicAnimation):
+ (WebCore::GraphicsLayerCA::setKeyframeAnimation):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::isRootLayer):
+ Fix isRootLayer to return true for the renderView's layer, not the root
+ renderer's layer.
+
+2009-02-11 Adele Peterson <adele@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23910
+ <rdar://problem/6160546> REGRESSION: In Full page mode, movie controller hides when I drag the knob if movie is playing
+
+ * rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent):
+ When we get a mouseOut event, consider the mouse as still within the RenderMedia if the relatedTarget is a descendant.
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Remove all of the inline box wrapper functions from RenderObject, since they only apply to RenderBox. Devirtualize the functions.
+ Patch all of the call sites to convert to a RenderBox.
+
+ Reviewed by Simon Fraser
+
+ * dom/Position.cpp:
+ (WebCore::nextRenderedEditable):
+ (WebCore::previousRenderedEditable):
+ (WebCore::Position::getInlineBoxAndOffset):
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::deleteLine):
+ (WebCore::InlineBox::extractLine):
+ (WebCore::InlineBox::attachLine):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::removeChildNode):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textWithHardLineBreaks):
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Eliminate createInlineBox and dirtyLineBoxes from RenderObject. These functions have been devirtualized.
+ The single call site now calls a helper function that just bit checks and casts before calling the correct
+ type. RenderBlock's dirtyLineBoxes function was dead code (caused by the RenderFlow deletion), so it has
+ just been removed.
+
+ Reviewed by Eric Seidel
+
+ * rendering/RenderBR.cpp:
+ * rendering/RenderBR.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::createRootInlineBox):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::createInlineBox):
+ * rendering/RenderBox.h:
+ * rendering/RenderCounter.cpp:
+ * rendering/RenderCounter.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::createInlineFlowBox):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::createTextBox):
+ * rendering/RenderSVGInlineText.h:
+ (WebCore::RenderSVGInlineText::isSVGText):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::createTextBox):
+ (WebCore::RenderText::createInlineTextBox):
+ * rendering/RenderText.h:
+ * rendering/bidi.cpp:
+ (WebCore::createInlineBoxForRenderer):
+ (WebCore::RenderBlock::createLineBoxes):
+ (WebCore::RenderBlock::constructLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-02-11 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23905
+
+ Adds support for 3D CSS properties (transform-style-3d, perspective,
+ perspective-origin, and backface-visibility) to RenderStyle and friends
+
+ * platform/graphics/transforms/TransformOperation.h
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff):
+ (WebCore::RenderStyle::applyTransform):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::transformOriginZ):
+ (WebCore::InheritedFlags::hasTransformRelatedProperty):
+ (WebCore::InheritedFlags::transformStyle3D):
+ (WebCore::InheritedFlags::backfaceVisibility):
+ (WebCore::InheritedFlags::perspective):
+ (WebCore::InheritedFlags::perspectiveOriginX):
+ (WebCore::InheritedFlags::perspectiveOriginY):
+ (WebCore::InheritedFlags::setTransformOriginZ):
+ (WebCore::InheritedFlags::setTransformStyle3D):
+ (WebCore::InheritedFlags::setBackfaceVisibility):
+ (WebCore::InheritedFlags::setPerspective):
+ (WebCore::InheritedFlags::setPerspectiveOriginX):
+ (WebCore::InheritedFlags::setPerspectiveOriginY):
+ (WebCore::InheritedFlags::initialTransformOriginZ):
+ (WebCore::InheritedFlags::initialTransformStyle3D):
+ (WebCore::InheritedFlags::initialBackfaceVisibility):
+ (WebCore::InheritedFlags::initialPerspective):
+ (WebCore::InheritedFlags::initialPerspectiveOriginX):
+ (WebCore::InheritedFlags::initialPerspectiveOriginY):
+ * rendering/style/RenderStyleConstants.h:
+ (WebCore::):
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+ (WebCore::StyleRareNonInheritedData::operator==):
+ * rendering/style/StyleRareNonInheritedData.h:
+ * rendering/style/StyleTransformData.cpp:
+ (WebCore::StyleTransformData::StyleTransformData):
+ (WebCore::StyleTransformData::operator==):
+ * rendering/style/StyleTransformData.h:
+
+2009-02-11 Simon Fraser <simon.fraser@apple.com>
+
+ No review.
+
+ Fix ACCELERATED_COMPOSITING build.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::createGraphicsLayer):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+
+2009-02-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23862
+
+ Add a bit on RenderStyle that gets set when running accelerated
+ transitions of transform or opacity. These ensure that styles
+ compare as different during the transition, so that interruption
+ can be detected reliably.
+
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::isRunningAcceleratedAnimation):
+ (WebCore::InheritedFlags::setIsRunningAcceleratedAnimation):
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+ (WebCore::StyleRareNonInheritedData::operator==):
+ * rendering/style/StyleRareNonInheritedData.h:
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Eliminate the virtual position() function from RenderObject. Rename the position() overrides
+ in RenderText and RenderBox to positionLineBox and devirtualize them.
+
+ Patch the one call site to just check for isText() and isBox() and call the methods directly.
+
+ Remove some unnecessary overrides of position() on table sections and rows.
+
+ Reviewed by Simon Fraser
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionLineBox):
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGRoot.cpp:
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderTableRow.h:
+ (WebCore::RenderTableRow::lineHeight):
+ * rendering/RenderTableSection.h:
+ (WebCore::RenderTableSection::lineHeight):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::positionLineBox):
+ * rendering/RenderText.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::computeVerticalPositionsForLine):
+
+2009-02-11 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23901
+ Add HTML options/collections V8 custom bindings.
+
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp: Added.
+ (WebCore::getNamedItems):
+ (WebCore::getItem):
+ (WebCore::NAMED_PROPERTY_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Added.
+ (WebCore::NAMED_PROPERTY_GETTER):
+ * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::ACCESSOR_SETTER):
+ * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ (WebCore::removeElement):
+ * bindings/v8/custom/V8HTMLSelectElementCustom.h: Added.
+ * bindings/v8/custom/V8NamedNodesCollection.cpp: Added.
+ (WebCore::V8NamedNodesCollection::item):
+ (WebCore::V8NamedNodesCollection::itemWithName):
+ * bindings/v8/custom/V8NamedNodesCollection.h: Added.
+ (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
+ (WebCore::V8NamedNodesCollection::length):
+
+2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
+
+ Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
+ This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InspectorClient.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::hiddenPanels):
+ (WebCore::InspectorController::hiddenPanels):
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ * inspector/InspectorController.h:
+ * inspector/front-end/inspector.js:
+ (WebInspector.loaded):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyInspectorClient::hiddenPanels):
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Combine RenderObject::element() and RenderObject::node() into a single function.
+ node() now has the "anonymous bit" checking behavior of element() and will
+ return 0 for anonymous content. This patch switches all callers of element()
+ to node() and patches old callers of node() to deal with situations where they
+ did not expect node() to be 0. A bunch of node() calls were calling stuff on
+ Document that they clearly didn't intend, so overall this is a nice improvement.
+
+ Reviewed by Sam Weinig
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ * dom/Element.cpp:
+ (WebCore::Element::offsetParent):
+ * dom/Position.cpp:
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::getStartEndListChildren):
+ (WebCore::IncreaseSelectionListLevelCommand::doApply):
+ (WebCore::DecreaseSelectionListLevelCommand::doApply):
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::advance):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
+ * editing/visible_units.cpp:
+ (WebCore::startPositionForLine):
+ (WebCore::endPositionForLine):
+ * page/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::get):
+ * page/AccessibilityList.cpp:
+ (WebCore::AccessibilityList::isUnorderedList):
+ (WebCore::AccessibilityList::isOrderedList):
+ (WebCore::AccessibilityList::isDefinitionList):
+ * page/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::doAccessibilityHitTest):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isPasswordField):
+ (WebCore::AccessibilityRenderObject::isFileUploadButton):
+ (WebCore::AccessibilityRenderObject::isInputImage):
+ (WebCore::AccessibilityRenderObject::isMultiSelect):
+ (WebCore::AccessibilityRenderObject::isControl):
+ (WebCore::AccessibilityRenderObject::getAttribute):
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ (WebCore::AccessibilityRenderObject::actionElement):
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ (WebCore::AccessibilityRenderObject::helpText):
+ (WebCore::AccessibilityRenderObject::textUnderElement):
+ (WebCore::AccessibilityRenderObject::hasIntValue):
+ (WebCore::AccessibilityRenderObject::intValue):
+ (WebCore::AccessibilityRenderObject::labelElementContainer):
+ (WebCore::AccessibilityRenderObject::title):
+ (WebCore::AccessibilityRenderObject::accessibilityDescription):
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+ (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
+ (WebCore::AccessibilityRenderObject::titleUIElement):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::text):
+ (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
+ (WebCore::AccessibilityRenderObject::accessKey):
+ (WebCore::AccessibilityRenderObject::setSelectedTextRange):
+ (WebCore::AccessibilityRenderObject::url):
+ (WebCore::AccessibilityRenderObject::isFocused):
+ (WebCore::AccessibilityRenderObject::setFocused):
+ (WebCore::AccessibilityRenderObject::setValue):
+ (WebCore::AccessibilityRenderObject::isEnabled):
+ (WebCore::AccessibilityRenderObject::visiblePositionRange):
+ (WebCore::AccessibilityRenderObject::index):
+ (WebCore::AccessibilityRenderObject::activeDescendant):
+ (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
+ (WebCore::AccessibilityRenderObject::observableObject):
+ (WebCore::AccessibilityRenderObject::roleValue):
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+ (WebCore::AccessibilityTable::title):
+ * page/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::titleUIElement):
+ * page/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::headerObjectForSection):
+ * page/AccessibilityTableRow.cpp:
+ (WebCore::AccessibilityTableRow::headerObject):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchMouseEvent):
+ (WebCore::EventHandler::canMouseDownStartSelect):
+ (WebCore::EventHandler::canMouseDragExtendSelect):
+ (WebCore::EventHandler::shouldDragAutoNode):
+ * page/Frame.cpp:
+ (WebCore::Frame::searchForLabelsAboveCell):
+ (WebCore::Frame::setFocusedNodeIfNeeded):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateOverflowStatus):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ (WebCore::AnimationController::cancelAnimations):
+ (WebCore::AnimationController::updateAnimations):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::KeyframeAnimation):
+ (WebCore::KeyframeAnimation::endAnimation):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (blockquoteLevel):
+ (AXAttributeStringSetHeadingLevel):
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::searchForNSLabelsAboveCell):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::verticallyAlignBoxes):
+ (WebCore::InlineFlowBox::paint):
+ (WebCore::shouldDrawTextDecoration):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintDocumentMarkers):
+ * rendering/RenderBR.cpp:
+ (WebCore::RenderBR::positionForCoordinates):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::handleRunInChild):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::isSelectionRoot):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::positionForBox):
+ (WebCore::RenderBlock::positionForRenderer):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::hasLineIfEmpty):
+ (WebCore::RenderBlock::updateFirstLetter):
+ (WebCore::RenderBlock::updateHitTestResult):
+ (WebCore::RenderBlock::addFocusRingRects):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::updateBoxModelInfoFromStyle):
+ (WebCore::RenderBox::paintRootBoxDecorations):
+ (WebCore::RenderBox::positionForCoordinates):
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::updateFromElement):
+ (WebCore::RenderButton::canHaveChildren):
+ * rendering/RenderCounter.cpp:
+ (WebCore::planCounter):
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::findLegend):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::translationForAttributes):
+ (WebCore::RenderForeignObject::calculateLocalTransform):
+ * rendering/RenderFrame.h:
+ (WebCore::RenderFrame::element):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::paintReplaced):
+ (WebCore::RenderImage::imageMap):
+ (WebCore::RenderImage::nodeAtPoint):
+ (WebCore::RenderImage::updateAltText):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::cloneInline):
+ (WebCore::RenderInline::updateHitTestResult):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::isTransparent):
+ (WebCore::RenderLayer::scrollToOffset):
+ (WebCore::RenderLayer::resize):
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::updateOverflowStatus):
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+ (WebCore::RenderLayer::enclosingElement):
+ (WebCore::RenderLayer::updateHoverActiveState):
+ (WebCore::RenderLayer::updateScrollCornerStyle):
+ (WebCore::RenderLayer::updateResizerStyle):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::isRootLayer):
+ * rendering/RenderListItem.cpp:
+ (WebCore::getParentOfFirstLineBox):
+ * rendering/RenderMarquee.cpp:
+ (WebCore::RenderMarquee::marqueeSpeed):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ (WebCore::RenderObject::isBody):
+ (WebCore::RenderObject::isHR):
+ (WebCore::RenderObject::isHTMLMarquee):
+ (WebCore::RenderObject::isEditable):
+ (WebCore::RenderObject::addPDFURLRect):
+ (WebCore::RenderObject::showTreeForThis):
+ (WebCore::RenderObject::draggableNode):
+ (WebCore::RenderObject::hasOutlineAnnotation):
+ (WebCore::RenderObject::positionForCoordinates):
+ (WebCore::RenderObject::updateDragState):
+ (WebCore::RenderObject::updateHitTestResult):
+ (WebCore::RenderObject::getUncachedPseudoStyle):
+ (WebCore::RenderObject::getTextDecorationColors):
+ (WebCore::RenderObject::caretMaxOffset):
+ (WebCore::RenderObject::offsetParent):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isRoot):
+ (WebCore::RenderObject::isInlineContinuation):
+ (WebCore::RenderObject::node):
+ (WebCore::RenderObject::setNode):
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::destroyLeftoverChildren):
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::updateWidgetPosition):
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::updateWidget):
+ (WebCore::RenderPartObject::viewCleared):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::calculateLocalTransform):
+ (WebCore::RenderPath::layout):
+ (WebCore::RenderPath::paint):
+ (WebCore::RenderPath::drawMarkersIfNeeded):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::positionForCoordinates):
+ (WebCore::RenderReplaced::isSelected):
+ * rendering/RenderSVGGradientStop.cpp:
+ (WebCore::RenderSVGGradientStop::gradientElement):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::calculateLocalTransform):
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::positionForCoordinates):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ (WebCore::RenderSVGRoot::applyContentTransforms):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::calcViewport):
+ (WebCore::RenderSVGRoot::absoluteTransform):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::calculateLocalTransform):
+ (WebCore::RenderSVGText::layout):
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::layoutPath):
+ (WebCore::RenderSVGTextPath::startOffset):
+ (WebCore::RenderSVGTextPath::exactAlignment):
+ (WebCore::RenderSVGTextPath::stretchMethod):
+ * rendering/RenderSVGTransformableContainer.cpp:
+ (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::calcViewport):
+ (WebCore::RenderSVGViewportContainer::viewportTransform):
+ (WebCore::RenderSVGViewportContainer::nodeAtPoint):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::updateFromElement):
+ (WebCore::RenderTableCell::calcPrefWidths):
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::updateFromElement):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::addChild):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addChild):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::originalText):
+ (WebCore::RenderText::positionForCoordinates):
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::nodeAtPoint):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+ * rendering/RenderTextFragment.cpp:
+ (WebCore::RenderTextFragment::originalText):
+ (WebCore::RenderTextFragment::previousCharacter):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isActive):
+ (WebCore::RenderTheme::isChecked):
+ (WebCore::RenderTheme::isIndeterminate):
+ (WebCore::RenderTheme::isEnabled):
+ (WebCore::RenderTheme::isFocused):
+ (WebCore::RenderTheme::isPressed):
+ (WebCore::RenderTheme::isReadOnlyControl):
+ (WebCore::RenderTheme::isHovered):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::updatePressedState):
+ (WebCore::RenderThemeMac::paintMediaFullscreenButton):
+ (WebCore::RenderThemeMac::paintMediaMuteButton):
+ (WebCore::RenderThemeMac::paintMediaPlayButton):
+ (WebCore::RenderThemeMac::paintMediaSeekBackButton):
+ (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
+ (WebCore::RenderThemeMac::paintMediaSliderTrack):
+ (WebCore::RenderThemeMac::paintMediaSliderThumb):
+ (WebCore::RenderThemeMac::paintMediaTimelineContainer):
+ (WebCore::RenderThemeMac::paintMediaCurrentTime):
+ (WebCore::RenderThemeMac::paintMediaTimeRemaining):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::paintMediaMuteButton):
+ (WebCore::RenderThemeSafari::paintMediaPlayButton):
+ (WebCore::RenderThemeSafari::paintMediaSliderTrack):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ (WebCore::writeSelection):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::setWidgetGeometry):
+ (WebCore::RenderWidget::updateWidgetPosition):
+ (WebCore::RenderWidget::nodeAtPoint):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::isEditableLeaf):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::prepareToRenderSVGContent):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::write):
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBox::buildLayoutInformation):
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
+ (WebCore::SVGRootInlineBox::buildTextChunks):
+ * rendering/style/SVGRenderStyle.cpp:
+ (WebCore::SVGRenderStyle::cssPrimitiveToLength):
+ * svg/SVGFont.cpp:
+ (WebCore::SVGTextRunWalker::walk):
+ (WebCore::floatWidthOfSubStringUsingSVGFont):
+ (WebCore::Font::drawTextUsingSVGFont):
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::findInlineTextBoxInTextChunks):
+ * svg/graphics/SVGPaintServer.cpp:
+ (WebCore::SVGPaintServer::fillPaintServer):
+ (WebCore::SVGPaintServer::strokePaintServer):
+
+2009-02-11 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/3541409> - Further FrameLoader and page cache cleanup
+
+ * history/CachedFrame.cpp:
+ (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method. This method was
+ the only caller and - in the future - will benefit from doing parts of opened()'s work differently.
+ (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method.
+ (WebCore::FrameLoader::closeAndRemoveChild): Added. Do the non-tree related cleanup that
+ FrameTree::removeChild() used to do.
+ (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead.
+ (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
+ * loader/FrameLoader.h:
+
+ * page/FrameTree.cpp:
+ (WebCore::FrameTree::removeChild): Just remove the Frame from the tree. Closing it and other
+ cleanup is the responsibility of the FrameLoader.
+ * page/FrameTree.h:
+ (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer
+
+2009-02-11 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23882
+ GraphicsContextSkia draws round rects as solid rects
+
+ Fixes two bugs in Skia's GraphicsContext::fillRoundedRect:
+ . fillRoundedRect had an extra call to fillRect, resulting in always
+ drawing a solid rectangle.
+ . if the total radius along a given axis is greater than the size of
+ the axis to draw, a solid rect should be drawn.
+
+ The layout tests LayoutTests/fast/css/shadow-multiple.html and
+ LayoutTests/fast/box-shadow/basic-shadows.html cover this.
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::fillRoundedRect):
+
+2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 23536: Auto-generate HTMLElementFactory
+
+ Remove the HTMLElementFactory files. Farewell.
+
+ * html/HTMLElementFactory.cpp: Removed.
+ * html/HTMLElementFactory.h: Removed.
+
+2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 23536: Auto-generate HTMLElementFactory
+
+ Make the platform auto-generate the HTMLElementFactory.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * webcore-base.bkl:
+
+2009-02-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Remove unneeded ASSERTS.
+
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::width):
+ (WebCore::RenderBox::height):
+ (WebCore::RenderBox::size):
+ (WebCore::RenderBox::frameRect):
+
+2009-02-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Add function to RenderStyle to ask whether a background image has been specified.
+
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::hasBackgroundImage):
+
+2009-02-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23548
+
+ When opacity or transform change on an object which has a compositing layer,
+ avoid repainting the layer.
+
+ Added a new StyleDifference value, StyleDifferenceRecompositeLayer, which indicates
+ that the only thing styleChanged() has to do is to update composited properties of
+ the layer. RenderStyle::diff() now has an out param for a bitmask of "context sensitive"
+ properties, currently for opacity and transform. When one of these changes, we need
+ to see if we have a compositing layer before we decide whether to layout/repaint,
+ or just update the composited layer, via adjustStyleDifference().
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::adjustStyleDifference):
+ (WebCore::RenderObject::setStyle):
+ (WebCore::RenderObject::styleDidChange):
+ * rendering/RenderObject.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/RenderStyleConstants.h:
+ (WebCore::):
+
+2009-02-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6562920> Pasted text should be normalized to NFC
+
+ Testing requires putting non-HTML content in pasteboard, so it cannot be done with WebKit alone.
+
+ * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::plainText): Route the text through
+ -[NSString precomposedStringWithCanonicalMapping].
+
+2009-02-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23883
+
+ Added new TransformOperation subclasses and methods to existing ones
+ to support 3D.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/transforms/IdentityTransformOperation.h:
+ (WebCore::IdentityTransformOperation::isAffine):
+ * platform/graphics/transforms/Matrix3DTransformOperation.cpp: Added.
+ (WebCore::Matrix3DTransformOperation::blend):
+ * platform/graphics/transforms/Matrix3DTransformOperation.h: Added.
+ (WebCore::Matrix3DTransformOperation::create):
+ (WebCore::Matrix3DTransformOperation::isIdentity):
+ (WebCore::Matrix3DTransformOperation::isAffine):
+ (WebCore::Matrix3DTransformOperation::getOperationType):
+ (WebCore::Matrix3DTransformOperation::isSameType):
+ (WebCore::Matrix3DTransformOperation::operator==):
+ (WebCore::Matrix3DTransformOperation::apply):
+ (WebCore::Matrix3DTransformOperation::Matrix3DTransformOperation):
+ * platform/graphics/transforms/MatrixTransformOperation.h:
+ (WebCore::MatrixTransformOperation::isAffine):
+ (WebCore::MatrixTransformOperation::apply):
+ * platform/graphics/transforms/PerspectiveTransformOperation.cpp: Added.
+ (WebCore::PerspectiveTransformOperation::blend):
+ * platform/graphics/transforms/PerspectiveTransformOperation.h: Added.
+ (WebCore::PerspectiveTransformOperation::create):
+ (WebCore::PerspectiveTransformOperation::isIdentity):
+ (WebCore::PerspectiveTransformOperation::isAffine):
+ (WebCore::PerspectiveTransformOperation::getOperationType):
+ (WebCore::PerspectiveTransformOperation::isSameType):
+ (WebCore::PerspectiveTransformOperation::operator==):
+ (WebCore::PerspectiveTransformOperation::apply):
+ (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation):
+ * platform/graphics/transforms/RotateTransformOperation.cpp:
+ (WebCore::RotateTransformOperation::blend):
+ * platform/graphics/transforms/RotateTransformOperation.h:
+ (WebCore::RotateTransformOperation::create):
+ (WebCore::RotateTransformOperation::angle):
+ (WebCore::RotateTransformOperation::isAffine):
+ (WebCore::RotateTransformOperation::operator==):
+ (WebCore::RotateTransformOperation::apply):
+ (WebCore::RotateTransformOperation::RotateTransformOperation):
+ * platform/graphics/transforms/ScaleTransformOperation.cpp:
+ (WebCore::ScaleTransformOperation::blend):
+ * platform/graphics/transforms/ScaleTransformOperation.h:
+ (WebCore::ScaleTransformOperation::create):
+ (WebCore::ScaleTransformOperation::z):
+ (WebCore::ScaleTransformOperation::isIdentity):
+ (WebCore::ScaleTransformOperation::isAffine):
+ (WebCore::ScaleTransformOperation::operator==):
+ (WebCore::ScaleTransformOperation::apply):
+ (WebCore::ScaleTransformOperation::ScaleTransformOperation):
+ * platform/graphics/transforms/SkewTransformOperation.h:
+ (WebCore::SkewTransformOperation::isAffine):
+ * platform/graphics/transforms/TransformOperation.h:
+ (WebCore::TransformOperation::):
+ (WebCore::TransformOperation::is3DOperation):
+ * platform/graphics/transforms/TransformOperations.h:
+ (WebCore::TransformOperations::isAffine):
+ (WebCore::TransformOperations::has3DOperation):
+ * platform/graphics/transforms/TranslateTransformOperation.cpp:
+ (WebCore::TranslateTransformOperation::blend):
+ * platform/graphics/transforms/TranslateTransformOperation.h:
+ (WebCore::TranslateTransformOperation::create):
+ (WebCore::TranslateTransformOperation::z):
+ (WebCore::TranslateTransformOperation::isIdentity):
+ (WebCore::TranslateTransformOperation::isAffine):
+ (WebCore::TranslateTransformOperation::operator==):
+ (WebCore::TranslateTransformOperation::apply):
+ (WebCore::TranslateTransformOperation::TranslateTransformOperation):
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Move createAnonymousBlock() to RenderBlock. Since anonymous blocks are always parented to some other block,
+ we can move this function to RenderBlock. Fix a couple of call sites as a result of this restriction.
+
+ Reviewed by Simon Fraser
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::createAnonymousBlock):
+ * rendering/RenderBlock.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::childBecameNonInline):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::handleDynamicFloatPositionChange):
+ * rendering/RenderObject.h:
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=23895
+
+ Remove two complete nonsense lines that I accidentally added from a cut and paste error. This
+ restores the original logic.
+
+ Reviewed by Simon Fraser
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+
+2009-02-11 David Hyatt <hyatt@apple.com>
+
+ Rename getBaselineOfFirstLineBox to firstLineBoxBaseline. Rename getBaselineOfLastLineBox to
+ lastLineBoxBaseline. Remove the functions from RenderObject and add them to RenderBox instead.
+
+ Reviewed by Eric Seidel
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::baselinePosition):
+ (WebCore::RenderBlock::firstLineBoxBaseline):
+ (WebCore::RenderBlock::lastLineBoxBaseline):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::firstLineBoxBaseline):
+ (WebCore::RenderBox::lastLineBoxBaseline):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ * rendering/RenderObject.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::firstLineBoxBaseline):
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::baselinePosition):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::firstLineBoxBaseline):
+ * rendering/RenderTableSection.h:
+
+2009-02-11 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=23877
+ Allow port to disable progress events from <video> and <audio> elements
+
+ * html/HTMLMediaElement.cpp: Initialize m_sendProgressEvents.
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Don't post progress events if m_sendProgressEvents is false.
+ (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Ditto.
+ (WebCore::HTMLMediaElement::load): Ditto.
+ * html/HTMLMediaElement.h: Add m_sendProgressEvents
+
+2009-02-11 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * DerivedSources.cpp: Removed SVGElementFactory.cpp, since including
+ it leads to ambiguities for symbols like "aTag", which exist in both
+ the HTMLNames and SVGNames namespaces.
+
+ * WebCore.vcproj/WebCore.vcproj: Added SVGElementFactory.cpp to the
+ project directly. VS also decided to reformat this file a little bit.
+
+2009-02-10 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 23536: Auto-generate HTMLElementFactory
+
+ Those are the last auto-generation bits needed to have a working generated HTMLElementFactory:
+
+ - Added a new option mapToTagName that enables a tag to use another's options and tagName (<image>
+ uses imgTag for example) and wired the code generation to be consistent with the current factory.
+
+ - Disabled dashboard compatibility check for HTMLElementFactory as it would make at least one test case fail.
+
+ - Pass the QualifiedName down to the Element constructor for shared constructors to make the generated code as
+ close as possible to the current one. We will pass the QualifiedName for all Element in a forthcoming patch.
+
+ * dom/make_names.pl: Did all the above points and tweaked the code generation to match the current HTMLElementFactory
+ as closely as possible.
+
+ * html/HTMLElementFactory.cpp:
+ (WebCore::quoteConstructor):
+ * html/HTMLQuoteElement.cpp:
+ (WebCore::HTMLQuoteElement::HTMLQuoteElement): Moved setUsesBeforeAfterRules to HTMLQuoteElement' constructor because some
+ part of the code creates elements without using the HTMLElementFactory. Also added a FIXME as it is not the right place.
+
+ * html/HTMLTagNames.in: Corrected <image> parameters.
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Fix for pixel test regression in fast/text. Make sure not to add in
+ the borderTop and paddingTop of the block to the baseline when painting
+ strict mode text decorations.
+
+ Reviewed by Mark Rowe
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ * rendering/InlineFlowBox.h:
+
+2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Windows build fix after r40837.
+
+ Not reviewed.
+
+ * DerivedSources.cpp:
+
+2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
+
+ <rdar://6349412> REGRESSION(r37204): Page is not repainted during and
+ after pan scrolling
+
+ Reviewed by Steve Falkenburg.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents): Don't repaint the pan scroll
+ icon rect immediately; we will paint after the view has been scrolled.
+
+2009-02-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop
+
+ This problem was caused by incorrectly ignoring whether or not the
+ default behaviour of the mousedown event was suppressed. If a
+ mousedown handler in a frame prevents default handling then the
+ subsequent mousemove events fired for the drag should not be
+ captured by that frame, should the mouse move out of its bounds.
+
+ Test: fast/events/mouse-drag-from-frame.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::EventHandler):
+ (WebCore::EventHandler::clear):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ Reset new m_capturesDragging flag
+
+ (WebCore::EventHandler::handleMousePressEvent):
+ Respect the m_capturesDragging flag when we propagate
+ a mousedown event to a subframe.
+
+ * page/EventHandler.h:
+ (WebCore::EventHandler::capturesDragging):
+
+2009-02-10 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes for recent changes to TransformationMatrix and DOMElement.
+
+ * WebCoreSources.bkl:
+ * dom/Element.cpp:
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * platform/graphics/wx/TransformationMatrixWx.cpp:
+ (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Some renames on line boxes. xPos()/yPos() -> x()/y(). setXPos()/setYPos() -> setX()/setY(). m_object/object() -> m_renderer/renderer(). textObject() -> textRenderer().
+
+ Reviewed by Sam Weinig
+
+ * dom/Position.cpp:
+ (WebCore::Position::upstream):
+ (WebCore::Position::downstream):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::localCaretRect):
+ * editing/visible_units.cpp:
+ (WebCore::startPositionForLine):
+ (WebCore::endPositionForLine):
+ (WebCore::previousLinePosition):
+ (WebCore::nextLinePosition):
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::paint):
+ (WebCore::EllipsisBox::nodeAtPoint):
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::showTreeForThis):
+ (WebCore::InlineBox::height):
+ (WebCore::InlineBox::caretMinOffset):
+ (WebCore::InlineBox::caretMaxOffset):
+ (WebCore::InlineBox::deleteLine):
+ (WebCore::InlineBox::extractLine):
+ (WebCore::InlineBox::attachLine):
+ (WebCore::InlineBox::adjustPosition):
+ (WebCore::InlineBox::paint):
+ (WebCore::InlineBox::nodeAtPoint):
+ (WebCore::InlineBox::selectionState):
+ (WebCore::InlineBox::canAccommodateEllipsis):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ (WebCore::InlineBox::renderer):
+ (WebCore::InlineBox::setX):
+ (WebCore::InlineBox::x):
+ (WebCore::InlineBox::setY):
+ (WebCore::InlineBox::y):
+ (WebCore::InlineBox::topOverflow):
+ (WebCore::InlineBox::bottomOverflow):
+ (WebCore::InlineBox::leftOverflow):
+ (WebCore::InlineBox::rightOverflow):
+ (WebCore::InlineBox::visibleToHitTesting):
+ (WebCore::InlineBox::boxModelObject):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::height):
+ (WebCore::InlineFlowBox::addToLine):
+ (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
+ (WebCore::InlineFlowBox::rendererLineBoxes):
+ (WebCore::InlineFlowBox::onEndChain):
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::InlineFlowBox::verticallyAlignBoxes):
+ (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
+ (WebCore::verticalPositionForBox):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::nodeAtPoint):
+ (WebCore::InlineFlowBox::paint):
+ (WebCore::InlineFlowBox::paintFillLayer):
+ (WebCore::InlineFlowBox::paintBoxShadow):
+ (WebCore::InlineFlowBox::paintBoxDecorations):
+ (WebCore::InlineFlowBox::paintMask):
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::borderLeft):
+ (WebCore::InlineFlowBox::borderRight):
+ (WebCore::InlineFlowBox::borderTop):
+ (WebCore::InlineFlowBox::borderBottom):
+ (WebCore::InlineFlowBox::baseline):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::height):
+ (WebCore::InlineTextBox::selectionState):
+ (WebCore::InlineTextBox::selectionRect):
+ (WebCore::InlineTextBox::deleteLine):
+ (WebCore::InlineTextBox::extractLine):
+ (WebCore::InlineTextBox::attachLine):
+ (WebCore::InlineTextBox::placeEllipsisBox):
+ (WebCore::InlineTextBox::isLineBreak):
+ (WebCore::InlineTextBox::nodeAtPoint):
+ (WebCore::InlineTextBox::paint):
+ (WebCore::InlineTextBox::selectionStartEnd):
+ (WebCore::InlineTextBox::paintSelection):
+ (WebCore::InlineTextBox::paintCompositionBackground):
+ (WebCore::InlineTextBox::paintCustomHighlight):
+ (WebCore::InlineTextBox::paintDecoration):
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+ (WebCore::InlineTextBox::paintTextMatchMarker):
+ (WebCore::InlineTextBox::paintDocumentMarkers):
+ (WebCore::InlineTextBox::paintCompositionUnderline):
+ (WebCore::InlineTextBox::textPos):
+ (WebCore::InlineTextBox::offsetForPosition):
+ (WebCore::InlineTextBox::positionForOffset):
+ * rendering/InlineTextBox.h:
+ (WebCore::InlineTextBox::textRenderer):
+ * rendering/ListMarkerBox.cpp:
+ (WebCore::ListMarkerBox::isText):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintEllipsisBoxes):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::positionForBox):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::getBaselineOfFirstLineBox):
+ (WebCore::RenderBlock::getBaselineOfLastLineBox):
+ (WebCore::RenderBlock::adjustForBorderFit):
+ (WebCore::RenderBlock::addFocusRingRects):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintCustomHighlight):
+ (WebCore::RenderBox::position):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::absoluteQuads):
+ (WebCore::RenderInline::offsetLeft):
+ (WebCore::RenderInline::offsetTop):
+ (WebCore::RenderInline::linesBoundingBox):
+ (WebCore::RenderInline::relativePositionedInlineOffset):
+ (WebCore::RenderInline::addFocusRingRects):
+ (WebCore::RenderInline::paintOutline):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::localBoundingBox):
+ * rendering/RenderSVGTSpan.cpp:
+ (WebCore::RenderSVGTSpan::absoluteRects):
+ (WebCore::RenderSVGTSpan::absoluteQuads):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+ (WebCore::RenderSVGText::relativeBBox):
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::absoluteRects):
+ (WebCore::RenderSVGTextPath::absoluteQuads):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::absoluteRects):
+ (WebCore::RenderText::absoluteRectsForRange):
+ (WebCore::RenderText::absoluteQuads):
+ (WebCore::RenderText::absoluteQuadsForRange):
+ (WebCore::RenderText::localCaretRect):
+ (WebCore::RenderText::linesBoundingBox):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::height):
+ (WebCore::RootInlineBox::clearTruncation):
+ (WebCore::RootInlineBox::placeEllipsis):
+ (WebCore::RootInlineBox::paintEllipsisBox):
+ (WebCore::RootInlineBox::addHighlightOverflow):
+ (WebCore::RootInlineBox::paintCustomHighlight):
+ (WebCore::RootInlineBox::paint):
+ (WebCore::RootInlineBox::nodeAtPoint):
+ (WebCore::RootInlineBox::childRemoved):
+ (WebCore::RootInlineBox::fillLineSelectionGap):
+ (WebCore::RootInlineBox::block):
+ (WebCore::isEditableLeaf):
+ (WebCore::RootInlineBox::closestLeafChildForXPos):
+ (WebCore::RootInlineBox::setVerticalOverflowPositions):
+ * rendering/RootInlineBox.h:
+ (WebCore::RootInlineBox::bottomOverflow):
+ (WebCore::RootInlineBox::floats):
+ (WebCore::RootInlineBox::setHorizontalOverflowPositions):
+ (WebCore::RootInlineBox::setVerticalSelectionPositions):
+ * rendering/SVGCharacterLayoutInfo.cpp:
+ (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::calculateGlyphWidth):
+ (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
+ (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
+ (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
+ (WebCore::SVGInlineTextBox::nodeAtPoint):
+ (WebCore::SVGInlineTextBox::paintCharacters):
+ (WebCore::SVGInlineTextBox::paintSelection):
+ (WebCore::SVGInlineTextBox::paintDecoration):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::writeSVGInlineTextBox):
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
+ (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
+ (WebCore::SVGRootInlineBox::paint):
+ (WebCore::cummulatedWidthOfInlineBoxCharacterRange):
+ (WebCore::cummulatedHeightOfInlineBoxCharacterRange):
+ (WebCore::svgTextRunForInlineTextBox):
+ (WebCore::cummulatedWidthOrHeightOfTextChunk):
+ (WebCore::applyTextAnchorToTextChunk):
+ (WebCore::SVGRootInlineBox::buildLayoutInformation):
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
+ (WebCore::SVGRootInlineBox::buildTextChunks):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::constructLine):
+ (WebCore::RenderBlock::computeVerticalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::checkLinesForTextOverflow):
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::cumulativeCharacterRangeLength):
+ (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
+ (WebCore::findInlineTextBoxInTextChunks):
+
+2009-02-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Clean up "fallbackAnimating" logic in AnimationBase. This flag indicates
+ that animation of an accelerated property must run in software for some reason.
+
+ Also remove use of private headers in GraphicsLayerCA related to a case
+ where we may have to fall back on software animation of transform.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::blendProperties):
+ * page/animation/AnimationBase.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+ * platform/graphics/mac/GraphicsLayerCA.h:
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (WebCore::getValueFunctionNameForTransformOperation):
+ (WebCore::caValueFunctionSupported):
+ (WebCore::GraphicsLayerCA::setBackgroundColor):
+ (WebCore::GraphicsLayerCA::setOpacity):
+ (WebCore::GraphicsLayerCA::animateTransform):
+ (WebCore::GraphicsLayerCA::animateFloat):
+ (WebCore::GraphicsLayerCA::setBasicAnimation):
+ (WebCore::GraphicsLayerCA::setKeyframeAnimation):
+
+2009-02-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Move enclosingCompositingLayer() from RenderObject to RenderLayer, since it
+ relates to the RenderLayer z-order/overflow structure, rather than the render tree
+ parent chain. Add a convenience method, ancestorCompositingLayer(), which finds
+ the enclosing layer excluding self.
+
+ Fix enclosingCompositingLayer() to correctly look at stacking context and overflow
+ lists.
+
+ Check for documentBeingDestroyed() in a few places to avoid work on document
+ teardown.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::enclosingCompositingLayer):
+ (WebCore::RenderLayer::setParent):
+ (WebCore::RenderLayer::dirtyZOrderLists):
+ (WebCore::RenderLayer::dirtyOverflowList):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::ancestorCompositingLayer):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::layerWillBeRemoved):
+ (WebCore::RenderLayerCompositor::clippedByAncestor):
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::containerForRepaint):
+ * rendering/RenderObject.h:
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Rename xPos() and yPos() on RenderLayer to x() and y() to match RenderBox. Rename setPos to setLocation.
+
+ Reviewed by Simon Fraser
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::convertToLayerCoords):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::x):
+ (WebCore::RenderLayer::y):
+ (WebCore::RenderLayer::setLocation):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ (WebCore::externalRepresentation):
+
+2009-02-10 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23879
+ Add missing PLATFORM(SKIA) changes to TransformationMatrix.h
+
+ * platform/graphics/transforms/TransformationMatrix.h:
+
+2009-02-10 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
+ Please implement getBoundingClientRect and getClientRects
+ <rdar://problem/6139669>
+
+ Cursory implementation of Element.getBoundingClientRect and
+ Element.getClientRects. Adds necessary infrastructure classes
+ ClientRect and ClientRectList.
+
+ Tests: fast/dom/getBoundingClientRect.html
+ fast/dom/getClientRects.html
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/ClientRect.cpp: Added.
+ (WebCore::ClientRect::ClientRect):
+ * dom/ClientRect.h: Added.
+ (WebCore::ClientRect::create):
+ (WebCore::ClientRect::top):
+ (WebCore::ClientRect::right):
+ (WebCore::ClientRect::bottom):
+ (WebCore::ClientRect::left):
+ (WebCore::ClientRect::width):
+ (WebCore::ClientRect::height):
+ * dom/ClientRect.idl: Added.
+ * dom/ClientRectList.cpp: Added.
+ (WebCore::ClientRectList::ClientRectList):
+ (WebCore::ClientRectList::~ClientRectList):
+ (WebCore::ClientRectList::length):
+ (WebCore::ClientRectList::item):
+ * dom/ClientRectList.h: Added.
+ (WebCore::ClientRectList::create):
+ * dom/ClientRectList.idl: Added.
+ * dom/Element.cpp:
+ (WebCore::Element::getClientRects):
+ (WebCore::Element::getBoundingClientRect):
+ * dom/Element.h:
+ * dom/Element.idl:
+ * page/DOMWindow.idl:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::absoluteQuads):
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Get rid of capsLockStateMayHaveChanged on RenderObject. It is only implemented by one class (text fields),
+ so devirtualize and just query at the single call site.
+
+ Reviewed by Eric Seidel
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::capsLockStateMayHaveChanged):
+ * rendering/RenderObject.h:
+ * rendering/RenderTextControlSingleLine.h:
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Shrink the size of all RenderObjects (except for RenderInlines) by 4 bytes. This patch moves the cached vertical position member to RenderInlines,
+ since they were the only objects being queried across multiple lines.
+
+ Reviewed by Sam Weinig
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::verticalPositionForBox):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::verticalPosition):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::verticalPositionFromCache):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::invalidateVerticalPosition):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ * rendering/RenderObject.h:
+ * rendering/RenderText.cpp:
+ * rendering/RenderText.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23868
+ Fix code style issues: removed 80-col wrapping, incorrect include style, if statement body on same line.
+
+ * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+
+2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23868
+ Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings.
+
+ * bindings/v8/custom/V8HTMLInputElementCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::ACCESSOR_SETTER):
+
+2009-02-10 Adam Roben <aroben@apple.com>
+
+ Fix Bug 23871: Assertion failure beneath WebCore::openFunc when
+ running http/tests/security/xss-DENIED-xsl-document-redirect.xml
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23871>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Covered by existing tests.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::openFunc): Use the two-parameter KURL constructor so that
+ the string will be parsed. libxml2 gives us a UTF-8-encoded string
+ that needs to be parsed.
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
+ overflow boolean into the RenderObject base class.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::replacedHasOverflow):
+ (WebCore::RenderObject::setReplacedHasOverflow):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::RenderReplaced):
+ (WebCore::RenderReplaced::~RenderReplaced):
+ (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
+ (WebCore::RenderReplaced::overflowHeight):
+ (WebCore::RenderReplaced::overflowWidth):
+ (WebCore::RenderReplaced::overflowLeft):
+ (WebCore::RenderReplaced::overflowTop):
+ (WebCore::RenderReplaced::overflowRect):
+ * rendering/RenderReplaced.h:
+
+2009-02-10 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23870
+ Make it possible for a port to require a user gesture for an <audio> or <video> element
+ to load a url.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions.
+ (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests.
+ (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set
+ and we are not preocessing a user gesture.
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space.
+ (WebCore::HTMLMediaElement::play): Ditto.
+ (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789.
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it
+ multiple times.
+ (WebCore::HTMLMediaElement::processingUserGesture): New.
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.
+
+2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Sam Weinig.
+
+ Remove the SVG checks from FloatPoint3D as it is used
+ by TransformationMatrix.
+
+ * platform/graphics/FloatPoint3D.cpp:
+ * platform/graphics/FloatPoint3D.h:
+
+2009-02-10 David Hyatt <hyatt@apple.com>
+
+ Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.
+
+ Reviewed by Sam Weinig
+
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::paint):
+ (WebCore::EllipsisBox::nodeAtPoint):
+ * rendering/EllipsisBox.h:
+ (WebCore::EllipsisBox::EllipsisBox):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::verticallyAlignBoxes):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::marginBorderPaddingLeft):
+ (WebCore::InlineFlowBox::marginBorderPaddingRight):
+ (WebCore::InlineFlowBox::marginLeft):
+ (WebCore::InlineFlowBox::marginRight):
+ (WebCore::InlineFlowBox::borderLeft):
+ (WebCore::InlineFlowBox::borderRight):
+ (WebCore::InlineFlowBox::borderTop):
+ (WebCore::InlineFlowBox::borderBottom):
+ (WebCore::InlineFlowBox::paddingLeft):
+ (WebCore::InlineFlowBox::paddingRight):
+ (WebCore::InlineFlowBox::paddingTop):
+ (WebCore::InlineFlowBox::paddingBottom):
+ (WebCore::InlineFlowBox::includeLeftEdge):
+ (WebCore::InlineFlowBox::includeRightEdge):
+ (WebCore::InlineFlowBox::baseline):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+ (WebCore::InlineTextBox::paintDecoration):
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+ (WebCore::InlineTextBox::paintCompositionUnderline):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::getBaselineOfFirstLineBox):
+ (WebCore::RenderBlock::getBaselineOfLastLineBox):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::baselinePosition):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::placeEllipsis):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::paintDecoration):
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::applyTextAnchorToTextChunk):
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+
+2009-02-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23867
+ Eliminate obsolete frame->document() checks
+
+ * page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo
+ (document vs. !document), fillWithRed was always set to false, and other branches were
+ never taken. Removing the check for document restores debug-only red color filling.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable()
+ after a document is created. A client can do anything in its delegate method, so we'd need
+ to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its
+ custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ * bindings/js/JSNavigatorCustom.cpp:
+ (WebCore::needsYouTubeQuirk):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::updateRenderingForBindings):
+ * dom/Document.cpp:
+ (WebCore::Document::initSecurityContext):
+ * editing/Editor.cpp:
+ (WebCore::Editor::deleteWithDirection):
+ (WebCore::Editor::dispatchCPPEvent):
+ (WebCore::Editor::applyStyle):
+ (WebCore::Editor::applyParagraphStyle):
+ * editing/EditorCommand.cpp:
+ (WebCore::Editor::Command::execute):
+ (WebCore::Editor::Command::isEnabled):
+ (WebCore::Editor::Command::state):
+ (WebCore::Editor::Command::value):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::recomputeCaretRect):
+ (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
+ (WebCore::SelectionController::selectAll):
+ (WebCore::SelectionController::setFocused):
+ * inspector/InspectorController.cpp:
+ (WebCore::getResourceDocumentNode):
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
+ * loader/DocumentLoader.cpp:
+ (WebCore::canonicalizedTitle):
+ (WebCore::DocumentLoader::stopLoading):
+ (WebCore::DocumentLoader::isLoadingInAPISense):
+ (WebCore::DocumentLoader::subresource):
+ (WebCore::DocumentLoader::getSubresources):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::urlSelected):
+ (WebCore::FrameLoader::stop):
+ (WebCore::FrameLoader::iconURL):
+ (WebCore::FrameLoader::executeIfJavaScriptURL):
+ (WebCore::FrameLoader::clear):
+ (WebCore::FrameLoader::endIfNotLoadingMainResource):
+ (WebCore::FrameLoader::restoreDocumentState):
+ (WebCore::FrameLoader::gotoAnchor):
+ (WebCore::FrameLoader::loadDone):
+ (WebCore::FrameLoader::checkCompleted):
+ (WebCore::FrameLoader::checkCallImplicitClose):
+ (WebCore::FrameLoader::scheduleRefresh):
+ (WebCore::FrameLoader::outgoingOrigin):
+ (WebCore::FrameLoader::canCachePageContainingThisFrame):
+ (WebCore::FrameLoader::logCanCacheFrameDecision):
+ (WebCore::FrameLoader::updatePolicyBaseURL):
+ (WebCore::FrameLoader::setPolicyBaseURL):
+ (WebCore::FrameLoader::frameDetached):
+ (WebCore::FrameLoader::shouldScrollToAnchor):
+ (WebCore::FrameLoader::saveDocumentState):
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create):
+ * loader/icon/IconFetcher.cpp:
+ (WebCore::IconFetcher::create):
+ * loader/icon/IconLoader.cpp:
+ (WebCore::IconLoader::startLoading):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
+ * page/Chrome.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::sessionStorage):
+ (WebCore::DOMWindow::alert):
+ (WebCore::DOMWindow::confirm):
+ (WebCore::DOMWindow::prompt):
+ (WebCore::DOMWindow::scrollX):
+ (WebCore::DOMWindow::scrollY):
+ (WebCore::DOMWindow::getMatchedCSSRules):
+ (WebCore::DOMWindow::openDatabase):
+ (WebCore::DOMWindow::scrollBy):
+ (WebCore::DOMWindow::scrollTo):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::allowDHTMLDrag):
+ (WebCore::EventHandler::scrollOverflow):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::updateDragAndDrop):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::sendContextMenuEvent):
+ (WebCore::EventHandler::capsLockStateMayHaveChanged):
+ (WebCore::EventHandler::sendResizeEvent):
+ (WebCore::EventHandler::sendScrollEvent):
+ * page/FocusController.cpp:
+ (WebCore::deepFocusableNode):
+ (WebCore::FocusController::advanceFocus):
+ * page/Frame.cpp:
+ (WebCore::Frame::setFocusedNodeIfNeeded):
+ (WebCore::Frame::shouldApplyTextZoom):
+ (WebCore::Frame::shouldApplyPageZoom):
+ (WebCore::Frame::setZoomFactor):
+ (WebCore::Frame::setPrinting):
+ (WebCore::Frame::reapplyStyles):
+ (WebCore::Frame::isContentEditable):
+ (WebCore::Frame::computeAndSetTypingStyle):
+ (WebCore::Frame::selectionComputedStyle):
+ (WebCore::Frame::applyEditingStyleToBodyElement):
+ (WebCore::Frame::removeEditingStyleFromBodyElement):
+ (WebCore::Frame::contentRenderer):
+ (WebCore::Frame::styleForSelectionStart):
+ (WebCore::Frame::setSelectionFromNone):
+ (WebCore::Frame::findString):
+ (WebCore::Frame::markAllMatchesForText):
+ (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
+ (WebCore::Frame::documentTypeString):
+ (WebCore::Frame::shouldClose):
+ (WebCore::Frame::respondToChangedSelection):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::~FrameView):
+ (WebCore::FrameView::createScrollbar):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::layoutTimerFired):
+ (WebCore::FrameView::scheduleRelayout):
+ (WebCore::FrameView::needsLayout):
+ (WebCore::FrameView::unscheduleRelayout):
+ (WebCore::FrameView::windowClipRect):
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::disconnectFrame):
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+ (WebCore::Page::~Page):
+ (WebCore::Page::unmarkAllTextMatches):
+ (WebCore::Page::setMediaVolume):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::currentKeyboardEvent):
+ (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::dashboardRegionsDictionary):
+ (WebCore::Frame::setUserStyleSheetLocation):
+ (WebCore::Frame::setUserStyleSheet):
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::dispatchStorageEvent):
+ * storage/SessionStorageArea.cpp:
+ (WebCore::SessionStorageArea::dispatchStorageEvent):
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::setContainerSize):
+ (WebCore::SVGImage::usesContainerSize):
+ (WebCore::SVGImage::size):
+ (WebCore::SVGImage::hasRelativeWidth):
+ (WebCore::SVGImage::hasRelativeHeight):
+ Removed frame->document() checks.
+
+2009-02-10 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Attempt to fix the Qt build after r40791.
+
+ * rendering/RenderSVGRoot.cpp:
+
+2009-02-10 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Minor code cleanup.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::replaceChild):
+
+2009-02-10 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix Qt build following r40793.
+
+ * editing/qt/EditorQt.cpp:
+
+2009-02-10 Feng Qian <feng@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix crashes when accessing navigator object of a deleted frame.
+ https://bugs.webkit.org/show_bug.cgi?id=23626
+ A layout test is added: fast/dom/navigator-detached-no-crash.html
+
+ * page/Navigator.cpp:
+ (WebCore::Navigator::cookieEnabled):
+ (WebCore::Navigator::javaEnabled):
+
+2009-02-10 Sverrir Berg <sverrir@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23630
+ Add complex font rendering using Skia instead of Windows ScriptTextOut.
+ This adds support for enhanced webkit styles when drawing complex
+ glyphs.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+ * platform/graphics/chromium/UniscribeHelper.cpp:
+ (WebCore::containsMissingGlyphs):
+ (WebCore::UniscribeHelper::draw):
+ (WebCore::UniscribeHelper::shape):
+ * platform/graphics/chromium/UniscribeHelper.h:
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::windowsCanHandleTextDrawing):
+ (WebCore::skiaDrawText):
+ (WebCore::paintSkiaText):
+ * platform/graphics/skia/SkiaFontWin.h:
+
+2009-02-10 Darin Fisher <darin@chromium.org>
+
+ Revert r40797 as requested by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23809
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/Document.idl:
+ * html/HTMLCanvasElement.idl:
+
+2009-02-09 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23855
+ Fix TransformationMatrixSkia.cpp and GraphicsContextSkia.cpp bustage
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::getCTM):
+ * platform/graphics/skia/TransformationMatrixSkia.cpp:
+ (WebCore::TransformationMatrix::operator SkMatrix):
+
+2009-02-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)
+
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is
+ in the advanced graphics mode before calling GetCharWidthI(), because
+ otherwise that function returns incorrect results for the default UI
+ font at a certain size.
+
+2009-02-09 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser
+
+ https://bugs.webkit.org/show_bug.cgi?id=23689
+
+ Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
+ added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868
+
+ Test: transforms/3d/cssmatrix-3d-interface.xhtml
+
+ * css/WebKitCSSMatrix.cpp:
+ * css/WebKitCSSMatrix.h:
+ * css/WebKitCSSMatrix.idl:
+
+2009-02-09 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
+ Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
+ as it can be invalidated by any of the calls to focus() within the function. Instead, retrieve it and
+ null-check it when it is needed.
+
+2009-02-09 David Hyatt <hyatt@apple.com>
+
+ Remove the m_height member from InlineBox. This shaves 4 bytes off of all inline boxes. Unfortunately SVG
+ sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
+ member variables.
+
+ height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
+ with no text children). For SVG boxes there is also a non-virtual setHeight function for updating the
+ m_height member variable like before.
+
+ Reviewed by Darin Adler
+
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::nodeAtPoint):
+ * rendering/EllipsisBox.h:
+ (WebCore::EllipsisBox::EllipsisBox):
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::height):
+ (WebCore::InlineBox::root):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ (WebCore::InlineBox::isInlineFlowBox):
+ (WebCore::InlineBox::isRootInlineBox):
+ (WebCore::InlineBox::topOverflow):
+ (WebCore::InlineBox::bottomOverflow):
+ (WebCore::InlineBox::leftOverflow):
+ (WebCore::InlineBox::rightOverflow):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::height):
+ (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
+ (WebCore::InlineFlowBox::nodeAtPoint):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::isInlineFlowBox):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::height):
+ (WebCore::InlineTextBox::nodeAtPoint):
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+ (WebCore::InlineTextBox::paintCompositionUnderline):
+ * rendering/InlineTextBox.h:
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::height):
+ (WebCore::RootInlineBox::placeEllipsis):
+ (WebCore::RootInlineBox::setVerticalOverflowPositions):
+ * rendering/RootInlineBox.h:
+ (WebCore::RootInlineBox::isRootInlineBox):
+ (WebCore::RootInlineBox::topOverflow):
+ (WebCore::RootInlineBox::bottomOverflow):
+ (WebCore::RootInlineBox::leftOverflow):
+ (WebCore::RootInlineBox::rightOverflow):
+ (WebCore::RootInlineBox::selectionBottom):
+ (WebCore::RootInlineBox::Overflow::Overflow):
+ (WebCore::RootInlineBox::setVerticalSelectionPositions):
+ * rendering/SVGInlineFlowBox.h:
+ (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
+ (WebCore::SVGInlineFlowBox::height):
+ (WebCore::SVGInlineFlowBox::setHeight):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::SVGInlineTextBox):
+ * rendering/SVGInlineTextBox.h:
+ (WebCore::SVGInlineTextBox::height):
+ (WebCore::SVGInlineTextBox::setHeight):
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ * rendering/SVGRootInlineBox.h:
+ (WebCore::SVGRootInlineBox::SVGRootInlineBox):
+ (WebCore::SVGRootInlineBox::height):
+ (WebCore::SVGRootInlineBox::setHeight):
+
+2009-02-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Document our Selection DOM extensions
+ (in preparation for re-writing Selection to work with ranges)
+
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::type):
+ * page/DOMSelection.h:
+ * page/DOMSelection.idl:
+
+2009-02-09 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix wx build
+
+ * WebCoreSources.bkl: change Selection to VisibleSelection
+
+2009-02-06 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23809
+ Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/Document.idl:
+ * html/HTMLCanvasElement.idl:
+
+2009-02-09 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Transform the gradient instead of the context for most platforms and
+ transform the context after CGContextReplacePathWithStrokedPath for CG.
+
+ REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
+ https://bugs.webkit.org/show_bug.cgi?id=23547
+
+ * platform/graphics/Gradient.h:
+ (WebCore::Gradient::setGradientSpaceTransform):
+ (WebCore::Gradient::gradientSpaceTransform):
+ * platform/graphics/cairo/GradientCairo.cpp:
+ (WebCore::Gradient::platformGradient):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ * platform/graphics/skia/GradientSkia.cpp:
+ (WebCore::Gradient::platformGradient):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
+ (WebCore::clipToTextMask):
+ (WebCore::SVGPaintServerGradient::setup):
+ (WebCore::SVGPaintServerGradient::teardown):
+
+2009-02-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Fix the highlight when inspecting inline elements.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::drawHighlightForBox):
+ (WebCore::drawHighlightForLineBoxes):
+ (WebCore::InspectorController::drawNodeHighlight):
+
+2009-02-09 Eric Seidel <eric@webkit.org>
+
+ Fix the gtk build by adding VisibleSelection and removing Selection.
+
+ * GNUmakefile.am:
+
+2009-02-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Dave Hyatt.
+
+ Rename Selection to VisibleSelection to allow us to separate
+ the selections the user works with from the ones used by
+ the JS editing APIs.
+ https://bugs.webkit.org/show_bug.cgi?id=23852
+
+ No functional changes, thus no tests.
+
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Element.cpp:
+ (WebCore::Element::updateFocusAppearance):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::updateStartEnd):
+ (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::inputText):
+ (WebCore::CompositeEditCommand::deleteSelection):
+ (WebCore::CompositeEditCommand::rebalanceWhitespace):
+ (WebCore::CompositeEditCommand::pushAnchorElementDown):
+ (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+ * editing/CompositeEditCommand.h:
+ * editing/CreateLinkCommand.cpp:
+ (WebCore::CreateLinkCommand::doApply):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::enclosingDeletableElement):
+ (WebCore::DeleteButtonController::respondToChangedSelection):
+ * editing/DeleteButtonController.h:
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
+ (WebCore::DeleteSelectionCommand::clearTransientState):
+ (WebCore::DeleteSelectionCommand::doApply):
+ * editing/DeleteSelectionCommand.h:
+ (WebCore::DeleteSelectionCommand::create):
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::setStartingSelection):
+ (WebCore::EditCommand::setEndingSelection):
+ * editing/EditCommand.h:
+ (WebCore::EditCommand::startingSelection):
+ (WebCore::EditCommand::endingSelection):
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectionForCommand):
+ (WebCore::Editor::respondToChangedSelection):
+ (WebCore::Editor::respondToChangedContents):
+ (WebCore::Editor::applyStyle):
+ (WebCore::Editor::applyParagraphStyle):
+ (WebCore::Editor::appliedEditing):
+ (WebCore::Editor::unappliedEditing):
+ (WebCore::Editor::reappliedEditing):
+ (WebCore::Editor::insertTextWithoutSendingTextEvent):
+ (WebCore::Editor::selectComposition):
+ (WebCore::Editor::confirmComposition):
+ (WebCore::Editor::advanceToNextMisspelling):
+ (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+ (WebCore::markMisspellingsOrBadGrammar):
+ (WebCore::Editor::markMisspellings):
+ (WebCore::Editor::markBadGrammar):
+ (WebCore::Editor::rangeForPoint):
+ (WebCore::Editor::transpose):
+ * editing/Editor.h:
+ * editing/EditorCommand.cpp:
+ (WebCore::expandSelectionToGranularity):
+ (WebCore::executeSwapWithMark):
+ (WebCore::enabledVisibleSelection):
+ (WebCore::enabledVisibleSelectionAndMark):
+ (WebCore::enableCaretInEditableText):
+ * editing/FormatBlockCommand.cpp:
+ (WebCore::FormatBlockCommand::modifyRange):
+ (WebCore::FormatBlockCommand::doApply):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::indentRegion):
+ (WebCore::IndentOutdentCommand::outdentRegion):
+ (WebCore::IndentOutdentCommand::doApply):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::modifyRange):
+ (WebCore::InsertListCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::performTrivialReplace):
+ (WebCore::InsertTextCommand::input):
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::getStartEndListChildren):
+ (WebCore::canIncreaseListLevel):
+ (WebCore::canDecreaseListLevel):
+ * editing/MoveSelectionCommand.cpp:
+ (WebCore::MoveSelectionCommand::doApply):
+ * editing/RemoveFormatCommand.cpp:
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ (WebCore::ReplaceSelectionCommand::doApply):
+ (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
+ * editing/Selection.cpp: Removed.
+ * editing/Selection.h: Removed.
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::moveTo):
+ (WebCore::SelectionController::setSelection):
+ (WebCore::SelectionController::nodeWillBeRemoved):
+ (WebCore::SelectionController::clear):
+ (WebCore::SelectionController::setBase):
+ (WebCore::SelectionController::setExtent):
+ (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
+ (WebCore::SelectionController::selectAll):
+ (WebCore::SelectionController::setSelectedRange):
+ * editing/SelectionController.h:
+ (WebCore::SelectionController::selection):
+ (WebCore::SelectionController::selectionType):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::insertText):
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/TypingCommand.h:
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore):
+ (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter):
+ * editing/VisibleSelection.cpp: Added.
+ (WebCore::VisibleSelection::VisibleSelection):
+ (WebCore::VisibleSelection::selectionFromContentsOfNode):
+ (WebCore::VisibleSelection::setBase):
+ (WebCore::VisibleSelection::setExtent):
+ (WebCore::VisibleSelection::firstRange):
+ (WebCore::VisibleSelection::toNormalizedRange):
+ (WebCore::VisibleSelection::expandUsingGranularity):
+ (WebCore::makeSearchRange):
+ (WebCore::VisibleSelection::appendTrailingWhitespace):
+ (WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):
+ (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
+ (WebCore::VisibleSelection::updateSelectionType):
+ (WebCore::VisibleSelection::validate):
+ (WebCore::VisibleSelection::setWithoutValidation):
+ (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
+ (WebCore::VisibleSelection::isContentEditable):
+ (WebCore::VisibleSelection::isContentRichlyEditable):
+ (WebCore::VisibleSelection::rootEditableElement):
+ (WebCore::VisibleSelection::shadowTreeRootNode):
+ (WebCore::VisibleSelection::debugPosition):
+ (WebCore::VisibleSelection::formatForDebugger):
+ (WebCore::VisibleSelection::showTreeForThis):
+ (showTree):
+ * editing/VisibleSelection.h: Added.
+ (WebCore::VisibleSelection::):
+ (WebCore::VisibleSelection::selectionType):
+ (WebCore::VisibleSelection::setAffinity):
+ (WebCore::VisibleSelection::affinity):
+ (WebCore::VisibleSelection::base):
+ (WebCore::VisibleSelection::extent):
+ (WebCore::VisibleSelection::start):
+ (WebCore::VisibleSelection::end):
+ (WebCore::VisibleSelection::visibleStart):
+ (WebCore::VisibleSelection::visibleEnd):
+ (WebCore::VisibleSelection::isNone):
+ (WebCore::VisibleSelection::isCaret):
+ (WebCore::VisibleSelection::isRange):
+ (WebCore::VisibleSelection::isCaretOrRange):
+ (WebCore::VisibleSelection::isBaseFirst):
+ (WebCore::VisibleSelection::granularity):
+ (WebCore::operator==):
+ (WebCore::operator!=):
+ * editing/htmlediting.cpp:
+ (WebCore::selectionForParagraphIteration):
+ (WebCore::avoidIntersectionWithNode):
+ * editing/htmlediting.h:
+ * editing/markup.cpp:
+ (WebCore::createMarkup):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::selection):
+ * html/HTMLInputElement.h:
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::selection):
+ * html/HTMLTextAreaElement.h:
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::selection):
+ (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::selection):
+ (WebCore::AccessibilityRenderObject::setSelectedTextRange):
+ (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
+ (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
+ (WebCore::AccessibilityRenderObject::doAXRangeForLine):
+ * page/AccessibilityRenderObject.h:
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::anchorNode):
+ (WebCore::DOMSelection::anchorOffset):
+ (WebCore::DOMSelection::focusNode):
+ (WebCore::DOMSelection::focusOffset):
+ (WebCore::DOMSelection::collapseToEnd):
+ (WebCore::DOMSelection::collapseToStart):
+ (WebCore::DOMSelection::getRangeAt):
+ (WebCore::DOMSelection::addRange):
+ * page/DOMSelection.h:
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::setSelectionToDragCaret):
+ (WebCore::DragController::concludeEditDrag):
+ (WebCore::prepareClipboardForImageDrag):
+ (WebCore::DragController::startDrag):
+ (WebCore::DragController::placeDragCaret):
+ * page/EditorClient.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::selectClosestWordFromMouseEvent):
+ (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
+ (WebCore::EventHandler::handleMousePressEventTripleClick):
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ (WebCore::EventHandler::updateSelectionForMouseDrag):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ * page/Frame.cpp:
+ (WebCore::Frame::mark):
+ (WebCore::Frame::setMark):
+ (WebCore::Frame::selectionLayoutChanged):
+ (WebCore::Frame::shouldChangeSelection):
+ (WebCore::Frame::shouldDeleteSelection):
+ (WebCore::Frame::revealSelection):
+ (WebCore::Frame::setSelectionFromNone):
+ (WebCore::Frame::findString):
+ (WebCore::Frame::respondToChangedSelection):
+ * page/Frame.h:
+ * page/Page.cpp:
+ (WebCore::Page::selection):
+ * page/Page.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::fillInlineSelectionGaps):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setSelectionRange):
+ (WebCore::RenderTextControl::selection):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeSelection):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::fillLineSelectionGap):
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGTextContentElement::selectSubString):
+
+2009-02-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23806
+ Fix a regression crash where an empty src value and a "text/html" type
+ on an EMBED element did not finish ResourceRequest initialization due to
+ an early return.
+
+ Test: fast/loader/empty-embed-src-attribute.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+
+2009-02-09 Rob Buis <rwlbuis@gmail.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23816
+ Clean up RenderSVGRoot.cpp
+
+ Clean up RenderSVGRoot.cpp.
+
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::calcViewport):
+
+2009-02-09 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=23737
+ Make it possible to control media element playback without knowing so many
+ internal implementation details.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state.
+ (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode.
+ (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
+ * html/HTMLMediaElement.h:
+
+ (WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
+ * html/HTMLVideoElement.h:
+
+ (WebCore::HTMLVideoElement::hasVideo): New.
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element
+ togglePlayState method.
+ (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing
+ begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time
+ will change.
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including
+ internal logic here.
+ (WebCore::RenderMedia::updateControlVisibility): Ditto.
+
+2009-02-09 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ Change RenderPart and RenderPartObject constructors to take a Node*
+ instead of a HTMLFrameOwnerElement* since that is all then need.
+
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
+ * rendering/RenderPart.h:
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::RenderPartObject): take Node* instead of HTMLFrameOwnerElement*
+ * rendering/RenderPartObject.h:
+
+2009-02-09 Dan Bernstein <mitz@apple.com>
+
+ - fix -Wmissing-prototypes builds
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::isHeaderElement): Marked this function static.
+ (WebCore::haveSameTagName): Ditto.
+ * editing/markup.cpp:
+ (WebCore::isSpecialAncestorBlock): Ditto.
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::makeMapBetweenRects): Removed unused function.
+ * platform/graphics/transforms/TransformationMatrix.h: Removed unused
+ declaration of private member makeMapBetweenRects().
+
+2009-02-09 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23850
+ Code cleanup of HTMLParser class which was using a mix of m_* and bare
+ class member variable names which helps to obfuscate the code. Also
+ changed a few of the static helper functions to take a const pointer type
+ as they should not be modifying the node.
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::HTMLParser):
+ (WebCore::HTMLParser::~HTMLParser):
+ (WebCore::HTMLParser::reset):
+ (WebCore::HTMLParser::setCurrent):
+ (WebCore::HTMLParser::parseToken):
+ (WebCore::HTMLParser::parseDoctypeToken):
+ (WebCore::isTableSection):
+ (WebCore::isTablePart):
+ (WebCore::isTableRelated):
+ (WebCore::HTMLParser::insertNode):
+ (WebCore::HTMLParser::handleError):
+ (WebCore::HTMLParser::textCreateErrorCheck):
+ (WebCore::HTMLParser::commentCreateErrorCheck):
+ (WebCore::HTMLParser::headCreateErrorCheck):
+ (WebCore::HTMLParser::bodyCreateErrorCheck):
+ (WebCore::HTMLParser::framesetCreateErrorCheck):
+ (WebCore::HTMLParser::formCreateErrorCheck):
+ (WebCore::HTMLParser::isindexCreateErrorCheck):
+ (WebCore::HTMLParser::noscriptCreateErrorCheck):
+ (WebCore::HTMLParser::pCloserStrictCreateErrorCheck):
+ (WebCore::HTMLParser::mapCreateErrorCheck):
+ (WebCore::HTMLParser::getNode):
+ (WebCore::HTMLParser::allowNestedRedundantTag):
+ (WebCore::HTMLParser::processCloseTag):
+ (WebCore::HTMLParser::isInline):
+ (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
+ (WebCore::HTMLParser::reopenResidualStyleTags):
+ (WebCore::HTMLParser::pushBlock):
+ (WebCore::HTMLParser::popBlock):
+ (WebCore::HTMLParser::popOneBlockCommon):
+ (WebCore::HTMLParser::popOneBlock):
+ (WebCore::HTMLParser::moveOneBlockToStack):
+ (WebCore::HTMLParser::checkIfHasPElementInScope):
+ (WebCore::HTMLParser::popInlineBlocks):
+ (WebCore::HTMLParser::freeBlock):
+ (WebCore::HTMLParser::createHead):
+ (WebCore::HTMLParser::handleIsindex):
+ (WebCore::HTMLParser::startBody):
+ (WebCore::HTMLParser::finished):
+ (WebCore::HTMLParser::reportErrorToConsole):
+ * html/HTMLParser.h:
+
+2009-02-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Applying review comment on a second location.
+
+ * rendering/RenderText.cpp: (WebCore::RenderText::nextOffset):
+ Use "ifdef BUILDING_ON_TIGER".
+
+2009-02-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23845
+ editing/deleting/backward-deletion.html fails on Tiger
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::previousOffset):
+ (WebCore::RenderText::nextOffset):
+ Work around a bug in older ICU versions by hardcoding narrow voiced marks.
+
+2009-02-09 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.
+
+2009-02-09 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Make WorkerMessagingProxy derive from two base proxy classes.
+ https://bugs.webkit.org/show_bug.cgi?id=23777
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ * dom/Worker.cpp:
+ (WebCore::Worker::terminate):
+ (WebCore::Worker::hasPendingActivity):
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::reportException):
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerThreadActivityReportTask::performTask):
+ (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
+ (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
+ (WebCore::WorkerMessagingProxy::terminateWorkerContext):
+ (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
+ (WebCore::WorkerMessagingProxy::reportPendingActivity):
+ (WebCore::WorkerMessagingProxy::reportPendingActivityInternal):
+ (WebCore::WorkerMessagingProxy::hasPendingActivity):
+ * dom/WorkerMessagingProxy.h:
+
+2009-02-09 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Introduce 2 base classes to split WorkerMessagingProxy.
+ https://bugs.webkit.org/show_bug.cgi?id=23776
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/WorkerContextProxy.h: Added.
+ (WebCore::WorkerContextProxy::~WorkerContextProxy):
+ * dom/WorkerObjectProxy.h: Added.
+ (WebCore::WorkerObjectProxy::~WorkerObjectProxy):
+
+2009-02-08 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23839
+
+ Make sure that generated content is properly handled when content is moved from a block run-in
+ to an inline run-in.
+
+ Reviewed by Sam Weinig
+
+ Added fast/runin/002.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::handleRunInChild):
+
+2009-02-08 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
+ Web inspector.
+
+ Reviewed by Mark Rowe
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteRectsForRange):
+ (WebCore::RenderObject::absoluteQuadsForRange):
+
+2009-02-08 Dirk Schulze <krit@webkit.org>
+
+ Unreviewed Qt build fix.
+
+ TransformationMatrix changes in r40761 broke QT build.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::getCTM):
+ (WebCore::GraphicsContext::scale):
+
+2009-02-08 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ This is a follow up of the last commit. It cleans up TransformationMatrix.h
+ and convert to a series of #elif.
+
+ * platform/graphics/transforms/TransformationMatrix.h:
+
+2009-02-08 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Simon Fraser.
+
+ [CAIRO] build broken by TransformationMatrix rework
+ https://bugs.webkit.org/show_bug.cgi?id=23831
+
+ Fixed cairo build after the TransformationMatrix rework done in
+ revision 40761.
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::getCTM):
+ (WebCore::GraphicsContext::concatCTM):
+ * platform/graphics/cairo/TransformationMatrixCairo.cpp:
+ (WebCore::TransformationMatrix::operator cairo_matrix_t):
+ * platform/graphics/transforms/TransformationMatrix.h:
+
+2009-02-07 David Hyatt <hyatt@apple.com>
+
+ Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
+ Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
+ base InlineBox class. Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
+ back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
+ boxes and image boxes shrink by 4 bytes.
+
+ Reviewed by Anders
+
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::InlineFlowBox):
+ (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
+ (WebCore::InlineFlowBox::hasTextChildren):
+
+2009-02-07 Dean Jackson <dino@apple.com>
+
+ Attempted build fix for Qt. Not reviewed.
+
+ TransformationMatrix changes in r40761 broke non-Apple builds.
+
+ * platform/graphics/qt/TransformationMatrixQt.cpp:
+ (WebCore::TransformationMatrix::operator QMatrix):
+ * platform/graphics/transforms/TransformationMatrix.h:
+
+2009-02-07 David Hyatt <hyatt@apple.com>
+
+ This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject. This shift
+ in base class knocks 32 bytes off the size of every RenderInline. All of the necessary functions
+ for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
+ or split into two functions (one in each derived class).
+
+ Reviewed by Anders and Antti
+
+ * dom/Element.cpp:
+ (WebCore::Element::offsetLeft):
+ (WebCore::Element::offsetTop):
+ (WebCore::Element::offsetWidth):
+ (WebCore::Element::offsetHeight):
+ (WebCore::Element::offsetParent):
+ (WebCore::Element::clientWidth):
+ (WebCore::Element::clientHeight):
+ (WebCore::Element::scrollWidth):
+ (WebCore::Element::scrollHeight):
+ * dom/Node.cpp:
+ (WebCore::Node::renderBox):
+ (WebCore::Node::renderBoxModelObject):
+ * dom/Node.h:
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::boxModelObject):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::marginLeft):
+ (WebCore::InlineFlowBox::marginRight):
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::borderLeft):
+ (WebCore::InlineFlowBox::borderRight):
+ (WebCore::InlineFlowBox::paddingLeft):
+ (WebCore::InlineFlowBox::paddingRight):
+ * rendering/RenderBlock.cpp:
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::imageChanged):
+ (WebCore::RenderBox::calcReplacedWidthUsing):
+ (WebCore::RenderBox::calcReplacedHeightUsing):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteVerticalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ (WebCore::RenderBox::positionForCoordinates):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::borderBoundingBox):
+ (WebCore::RenderBox::offsetHeight):
+ (WebCore::RenderBox::marginTop):
+ (WebCore::RenderBox::marginBottom):
+ (WebCore::RenderBox::marginLeft):
+ (WebCore::RenderBox::marginRight):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::offsetLeft):
+ (WebCore::RenderBoxModelObject::offsetTop):
+ (WebCore::RenderBoxModelObject::paddingTop):
+ (WebCore::RenderBoxModelObject::paddingBottom):
+ (WebCore::RenderBoxModelObject::paddingLeft):
+ (WebCore::RenderBoxModelObject::paddingRight):
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ (WebCore::RenderBoxModelObject::calculateBackgroundSize):
+ (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
+ * rendering/RenderBoxModelObject.h:
+ (WebCore::RenderBoxModelObject::borderTop):
+ (WebCore::RenderBoxModelObject::borderBottom):
+ (WebCore::RenderBoxModelObject::borderLeft):
+ (WebCore::RenderBoxModelObject::borderRight):
+ (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin):
+ (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding):
+ (WebCore::RenderBoxModelObject::childBecameNonInline):
+ (WebCore::RenderBoxModelObject::isBoxModelObject):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::destroy):
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::nextContinuation):
+ (WebCore::RenderInline::continuationBefore):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::splitFlow):
+ (WebCore::RenderInline::addChildToContinuation):
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::offsetLeft):
+ (WebCore::RenderInline::offsetTop):
+ (WebCore::RenderInline::marginLeft):
+ (WebCore::RenderInline::marginRight):
+ (WebCore::RenderInline::positionForCoordinates):
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ (WebCore::RenderInline::rectWithOutlineForRepaint):
+ (WebCore::RenderInline::computeRectForRepaint):
+ (WebCore::RenderInline::updateDragState):
+ (WebCore::RenderInline::childBecameNonInline):
+ (WebCore::RenderInline::updateHitTestResult):
+ (WebCore::RenderInline::imageChanged):
+ (WebCore::RenderInline::addFocusRingRects):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::marginTop):
+ (WebCore::RenderInline::marginBottom):
+ (WebCore::RenderInline::continuation):
+ (WebCore::RenderInline::setContinuation):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::paint):
+ (WebCore::RenderLineBoxList::hitTest):
+ * rendering/RenderLineBoxList.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::addLayers):
+ (WebCore::RenderObject::removeLayers):
+ (WebCore::RenderObject::moveLayers):
+ (WebCore::RenderObject::findNextLayer):
+ (WebCore::RenderObject::enclosingLayer):
+ (WebCore::RenderObject::enclosingCompositingLayer):
+ (WebCore::RenderObject::setLayerNeedsFullRepaint):
+ (WebCore::RenderObject::handleDynamicFloatPositionChange):
+ (WebCore::RenderObject::destroy):
+ (WebCore::RenderObject::offsetParent):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isInlineContinuation):
+ * rendering/RenderSVGTSpan.cpp:
+ (WebCore::RenderSVGTSpan::absoluteRects):
+ (WebCore::RenderSVGTSpan::absoluteQuads):
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::absoluteRects):
+ (WebCore::RenderSVGTextPath::absoluteQuads):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::setBestTruncatedAt):
+ * rendering/RenderView.h:
+ * rendering/bidi.cpp:
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::inlineWidth):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::inlineFlowRequiresLineBox):
+ (WebCore::requiresLineBox):
+ (WebCore::RenderBlock::findNextLineBreak):
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::isKeyboardFocusable):
+
+2009-02-07 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Timothy Hatcher <timothy@hatcher.name>
+
+ Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
+ Include localStorage and sessionStorage in DatabasesPanel.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorDOMStorageResource::create):
+ (WebCore::InspectorDOMStorageResource::setScriptObject):
+ (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+ (WebCore::InspectorController::populateScriptObjects):
+ (WebCore::InspectorController::addDOMStorageScriptResource):
+ (WebCore::InspectorController::removeDOMStorageScriptResource):
+ (WebCore::InspectorController::resetScriptObjects):
+ (WebCore::InspectorController::didCommitLoad):
+ (WebCore::InspectorController::didUseDOMStorage):
+ * inspector/InspectorController.h:
+ * inspector/front-end/DOMStorage.js: Added.
+ (WebInspector.DOMStorage):
+ (WebInspector.DOMStorage.prototype.get domStorage):
+ (WebInspector.DOMStorage.prototype.set domStorage):
+ (WebInspector.DOMStorage.prototype.get domain):
+ (WebInspector.DOMStorage.prototype.set domain):
+ (WebInspector.DOMStorage.prototype.get isLocalStorage):
+ (WebInspector.DOMStorage.prototype.set isLocalStorage):
+ * inspector/front-end/DOMStorageItemsView.js: Added.
+ (WebInspector.DOMStorageItemsView):
+ (WebInspector.DOMStorageItemsView.prototype.show):
+ (WebInspector.DOMStorageItemsView.prototype.update):
+ * inspector/front-end/DatabaseQueryView.js:
+ (WebInspector.DatabaseQueryView):
+ * inspector/front-end/DatabaseTableView.js:
+ (WebInspector.DatabaseTableView):
+ (WebInspector.DatabaseTableView.prototype._queryFinished):
+ (WebInspector.DatabaseTableView.prototype._queryError):
+ * inspector/front-end/DatabasesPanel.js:
+ (WebInspector.DatabasesPanel):
+ (WebInspector.DatabasesPanel.prototype.reset):
+ (WebInspector.DatabasesPanel.prototype.addDatabase):
+ (WebInspector.DatabasesPanel.prototype.addDOMStorage):
+ (WebInspector.DatabasesPanel.prototype.showDatabase):
+ (WebInspector.DatabasesPanel.prototype.showDOMStorage):
+ (WebInspector.DatabasesPanel.prototype.closeVisibleView):
+ (WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
+ (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
+ (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
+ (WebInspector.DOMStorageSidebarTreeElement):
+ (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect):
+ (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
+ (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle):
+ (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle):
+ (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
+ * inspector/front-end/Images/domStorage.png: Added.
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/inspector.html:
+ * inspector/front-end/inspector.js:
+ (WebInspector.addDOMStorage):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::sessionStorage):
+ (WebCore::DOMWindow::localStorage):
+
+2009-02-07 Feng Qian <feng@chromium.org>
+
+ Reviewed by Eric Seidel <eric@webkit.org>
+
+ Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
+ https://bugs.webkit.org/show_bug.cgi?id=23574
+
+ * page/EventHandler.cpp:
+ * page/EventHandler.h:
+
+2009-02-07 Zalan Bujtas <zbujtas@gmail.com>
+
+ Reviewed by Rob Buis <rwlbuis@gmail.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=23788
+ call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.
+
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+
+2009-02-07 Rob Buis <rwlbuis@gmail.com>
+
+ Reviewed by Darin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=3248
+ Bug 3248: Mouse events on OPTION element seem to be ignored
+
+ Support mouse events on options in a select when it forms a list box.
+
+ Test: fast/forms/option-mouseevents.html
+
+ * html/HTMLSelectElement.cpp: Convert to coords relative to the list box.
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ * rendering/RenderListBox.cpp: Handle hit testing for option elements.
+ (WebCore::RenderListBox::nodeAtPoint):
+ * rendering/RenderListBox.h:
+
+2009-02-07 Adam Treat <adam.treat@torchmobile.com>
+
+ Prospective build fix for all non-Apple platforms.
+
+ * platform/graphics/transforms/TransformationMatrix.h:
+
+2009-02-06 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=6868
+
+ I have not only made TransformationMatrix platform independent
+ but I've also added 3D methods, which will be used when I update
+ WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
+ I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
+ the math as doubles rather than floats. This makes a TransformationMatrix
+ go from 24 bytes to 128 bytes, but I don't think this class is used enough to
+ make this overhead will be significant.
+
+ The change from floats to doubles has caused some differences in rounding and
+ display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
+ so I've had to change some LayoutTest results in the SVG tests.
+
+ * platform/graphics/FloatPoint.cpp:
+ (WebCore::FloatPoint::matrixTransform):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::getCTM):
+ * platform/graphics/cg/TransformationMatrixCG.cpp:
+ (WebCore::TransformationMatrix::operator CGAffineTransform):
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::determinant2x2):
+ (WebCore::determinant3x3):
+ (WebCore::determinant4x4):
+ (WebCore::adjoint):
+ (WebCore::inverse):
+ (WebCore::transposeMatrix4):
+ (WebCore::v4MulPointByMatrix):
+ (WebCore::v3Length):
+ (WebCore::v3Scale):
+ (WebCore::v3Dot):
+ (WebCore::v3Combine):
+ (WebCore::v3Cross):
+ (WebCore::decompose):
+ (WebCore::slerp):
+ (WebCore::TransformationMatrix::scale):
+ (WebCore::TransformationMatrix::rotateFromVector):
+ (WebCore::TransformationMatrix::flipX):
+ (WebCore::TransformationMatrix::flipY):
+ (WebCore::makeMapBetweenRects):
+ (WebCore::TransformationMatrix::projectPoint):
+ (WebCore::TransformationMatrix::mapPoint):
+ (WebCore::TransformationMatrix::mapRect):
+ (WebCore::TransformationMatrix::mapQuad):
+ (WebCore::TransformationMatrix::scale3d):
+ (WebCore::TransformationMatrix::rotate3d):
+ (WebCore::TransformationMatrix::translate):
+ (WebCore::TransformationMatrix::translate3d):
+ (WebCore::TransformationMatrix::skew):
+ (WebCore::TransformationMatrix::applyPerspective):
+ (WebCore::TransformationMatrix::multLeft):
+ (WebCore::TransformationMatrix::multVecMatrix):
+ (WebCore::TransformationMatrix::isInvertible):
+ (WebCore::TransformationMatrix::inverse):
+ (WebCore::blendFloat):
+ (WebCore::TransformationMatrix::blend):
+ (WebCore::TransformationMatrix::decompose):
+ (WebCore::TransformationMatrix::recompose):
+ * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::TransformationMatrix::TransformationMatrix):
+ (WebCore::TransformationMatrix::setMatrix):
+ (WebCore::TransformationMatrix::operator =):
+ (WebCore::TransformationMatrix::makeIdentity):
+ (WebCore::TransformationMatrix::isIdentity):
+ (WebCore::TransformationMatrix::map):
+ (WebCore::TransformationMatrix::m11):
+ (WebCore::TransformationMatrix::setM11):
+ (WebCore::TransformationMatrix::m12):
+ (WebCore::TransformationMatrix::setM12):
+ (WebCore::TransformationMatrix::m13):
+ (WebCore::TransformationMatrix::setM13):
+ (WebCore::TransformationMatrix::m14):
+ (WebCore::TransformationMatrix::setM14):
+ (WebCore::TransformationMatrix::m21):
+ (WebCore::TransformationMatrix::setM21):
+ (WebCore::TransformationMatrix::m22):
+ (WebCore::TransformationMatrix::setM22):
+ (WebCore::TransformationMatrix::m23):
+ (WebCore::TransformationMatrix::setM23):
+ (WebCore::TransformationMatrix::m24):
+ (WebCore::TransformationMatrix::setM24):
+ (WebCore::TransformationMatrix::m31):
+ (WebCore::TransformationMatrix::setM31):
+ (WebCore::TransformationMatrix::m32):
+ (WebCore::TransformationMatrix::setM32):
+ (WebCore::TransformationMatrix::m33):
+ (WebCore::TransformationMatrix::setM33):
+ (WebCore::TransformationMatrix::m34):
+ (WebCore::TransformationMatrix::setM34):
+ (WebCore::TransformationMatrix::m41):
+ (WebCore::TransformationMatrix::setM41):
+ (WebCore::TransformationMatrix::m42):
+ (WebCore::TransformationMatrix::setM42):
+ (WebCore::TransformationMatrix::m43):
+ (WebCore::TransformationMatrix::setM43):
+ (WebCore::TransformationMatrix::m44):
+ (WebCore::TransformationMatrix::setM44):
+ (WebCore::TransformationMatrix::a):
+ (WebCore::TransformationMatrix::setA):
+ (WebCore::TransformationMatrix::b):
+ (WebCore::TransformationMatrix::setB):
+ (WebCore::TransformationMatrix::c):
+ (WebCore::TransformationMatrix::setC):
+ (WebCore::TransformationMatrix::d):
+ (WebCore::TransformationMatrix::setD):
+ (WebCore::TransformationMatrix::e):
+ (WebCore::TransformationMatrix::setE):
+ (WebCore::TransformationMatrix::f):
+ (WebCore::TransformationMatrix::setF):
+ (WebCore::TransformationMatrix::multiply):
+ (WebCore::TransformationMatrix::rotate):
+ (WebCore::TransformationMatrix::skewX):
+ (WebCore::TransformationMatrix::skewY):
+ (WebCore::TransformationMatrix::hasPerspective):
+ (WebCore::TransformationMatrix::):
+ (WebCore::TransformationMatrix::isAffine):
+ (WebCore::TransformationMatrix::operator==):
+ (WebCore::TransformationMatrix::operator*=):
+ (WebCore::TransformationMatrix::operator*):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::nodeAtPoint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateTransform):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::mapAbsolutePointToLocal):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::nodeAtPoint):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::nodeAtPoint):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::nodeAtPoint):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::nodeAtPoint):
+ * svg/SVGAnimateMotionElement.cpp:
+ (WebCore::SVGAnimateMotionElement::resetToBaseValue):
+ (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::viewport):
+ * svg/SVGTransform.cpp:
+ (SVGTransform::setTranslate):
+ (SVGTransform::setScale):
+ (SVGTransform::setRotate):
+ (SVGTransform::setSkewX):
+ (SVGTransform::setSkewY):
+ * svg/graphics/SVGResourceMarker.cpp:
+ (WebCore::SVGResourceMarker::draw):
+
+2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ For the Qt port implement Image::drawPattern via
+ BitmapImage::drawPatterns' implementation and implement
+ Gradient::fill.
+
+ This partially fixes rendering of generated gradient content.
+
+ * platform/graphics/BitmapImage.h: Remove the drawPattern
+ implementation for the Qt port in BitmapImage, it's been moved to
+ Image::drawPattern.
+ * platform/graphics/qt/GradientQt.cpp:
+ (WebCore::Gradient::fill): Implement using a simple fillRect.
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::Image::drawPattern): Moved implementation from
+ BitmapImage::drawPattern.
+
+2009-02-06 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ DOMSelection.getRangeAt() returns a different range than the selection
+ https://bugs.webkit.org/show_bug.cgi?id=23601
+
+ Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
+
+ Test: fast/dom/Selection/getRangeAt.html
+
+ * WebCore.base.exp:
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::handleBeforeTextInsertedEvent):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::enclosingDeletableElement):
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectedRange):
+ (WebCore::Editor::fontForSelection):
+ (WebCore::Editor::applyStyleToSelection):
+ (WebCore::Editor::applyParagraphStyleToSelection):
+ (WebCore::Editor::insertTextWithoutSendingTextEvent):
+ (WebCore::Editor::insertLineBreak):
+ (WebCore::Editor::insertParagraphSeparator):
+ (WebCore::Editor::ignoreSpelling):
+ (WebCore::Editor::isSelectionUngrammatical):
+ (WebCore::Editor::guessesForUngrammaticalSelection):
+ (WebCore::markMisspellingsOrBadGrammar):
+ (WebCore::Editor::rangeForPoint):
+ * editing/EditorCommand.cpp:
+ (WebCore::expandSelectionToGranularity):
+ (WebCore::executeDeleteToMark):
+ (WebCore::executeSelectToMark):
+ * editing/RemoveFormatCommand.cpp:
+ (WebCore::RemoveFormatCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * editing/Selection.cpp:
+ (WebCore::Selection::firstRange):
+ (WebCore::Selection::toNormalizedRange):
+ * editing/Selection.h:
+ * editing/SelectionController.h:
+ (WebCore::SelectionController::toNormalizedRange):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/markup.cpp:
+ (WebCore::createMarkup):
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::createFromSelection):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected):
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::getRangeAt):
+ (WebCore::DOMSelection::addRange):
+ (WebCore::DOMSelection::deleteFromDocument):
+ (WebCore::DOMSelection::containsNode):
+ (WebCore::DOMSelection::toString):
+ * page/DragController.cpp:
+ (WebCore::setSelectionToDragCaret):
+ (WebCore::DragController::concludeEditDrag):
+ (WebCore::DragController::startDrag):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchMouseEvent):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectedText):
+ (WebCore::Frame::shouldChangeSelection):
+ (WebCore::Frame::shouldDeleteSelection):
+ (WebCore::Frame::selectionComputedStyle):
+ (WebCore::Frame::selectionTextRects):
+ (WebCore::Frame::findString):
+ (WebCore::Frame::respondToChangedSelection):
+ * platform/ContextMenu.cpp:
+ (WebCore::selectionContainsPossibleWord):
+
+2009-02-06 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ <rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
+ before ::didReceiveResponse().
+
+ No layout test, as we don't have a concrete way to reproduce these conditions. To that effect, I've added an ASSERT
+ to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
+ this case and can come up with something more reproducible.
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response. This is much
+ like the FrameLoader::init() response that is used for initial document creation.
+
+2009-02-06 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * WebCore.base.exp:
+
+2009-02-06 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23621
+
+ Do not use m_scrollOffset to check if we are setting the same
+ value than we already have.
+
+ m_scrollOffset starts at 0 for ScrollView, so when opening a new
+ page and scrolling to 0 (the usual case) the check will fail and
+ we won't update the adjustment value, resulting in a possibly
+ mispositioned scrollbar. Use the adjustment value directly
+ instead, which is what we are updating anyway.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformHandleHorizontalAdjustment):
+ (WebCore::ScrollView::platformHandleVerticalAdjustment):
+
+2009-02-06 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23800
+ Header elements are not always preserved during paste
+
+ At paste time, don't merge out of header elements. At copy time, be sure to include
+ headers in the list of special common ancestor blocks, so that copying a paragraph or less
+ of content inside a header will include the header element in the copied markup.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::areSameHeaderElements):
+ (WebCore::ReplaceSelectionCommand::shouldMerge):
+ * editing/markup.cpp:
+ (WebCore::isSpecialAncestorBlock):
+ (WebCore::createMarkup):
+
+2009-02-06 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Part III of <rdar://problem/6552272>.
+
+ Make redirect data available to WebKit. (I tried having WebKit track this
+ data for itself, but that went wrong -- it's just too hard to figure
+ out the weird corners of the WebCore loader from within another framework.)
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::DocumentLoader):
+ * loader/DocumentLoader.h: Store a flag indicating whether we created
+ a global history entry. If we didn't, then we know that the next redirect
+ should not link to us, since we're not in history.
+
+ (WebCore::DocumentLoader::clientRedirectSourceForHistory):
+ (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
+ (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
+ (WebCore::DocumentLoader::serverRedirectSourceForHistory):
+ (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
+ (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
+ (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
+ to help WebKit wade through the muck of WebCore history.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
+ this client function to say what it does, instead of when it's called.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::load):
+ (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
+ store a link to the previous history URL in the new DocumentLoader, so
+ it can update WebKit with that link when the load commits.
+
+ (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
+ described above.
+
+ * loader/FrameLoader.h:
+ (WebCore::FrameLoader::documentLoader):
+ (WebCore::FrameLoader::policyDocumentLoader):
+ (WebCore::FrameLoader::provisionalDocumentLoader):
+ (WebCore::FrameLoader::state): Inlined a few trivial functions because
+ performance mistakes give me the itches.
+
+ * loader/FrameLoaderClient.h: Renamed this client function to say what
+ it does, instead of when it's called.
+
+2009-02-06 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Minor refactoring and cleanup to Selection code
+ https://bugs.webkit.org/show_bug.cgi?id=23774
+
+ No functional changes, thus no tests.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::applyStyle):
+ (WebCore::Editor::applyParagraphStyle):
+ * editing/Selection.cpp:
+ (WebCore::Selection::Selection):
+ (WebCore::Selection::setBaseAndExtentToDeepEquivalents):
+ (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity):
+ (WebCore::Selection::updateSelectionType):
+ (WebCore::Selection::validate):
+ (WebCore::Selection::setWithoutValidation):
+ (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
+ * editing/Selection.h:
+ (WebCore::Selection::):
+ (WebCore::Selection::selectionType):
+ (WebCore::Selection::extent):
+ (WebCore::Selection::isNone):
+ (WebCore::Selection::isCaret):
+ (WebCore::Selection::isRange):
+ (WebCore::Selection::isCaretOrRange):
+ * editing/SelectionController.h:
+ (WebCore::SelectionController::selectionType):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * page/Frame.cpp:
+ (WebCore::Frame::revealSelection):
+
+2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23801
+ Add custom V8 bindings for SVG.
+
+ * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SVGLengthCustom.cpp: Added.
+ (WebCore::ACCESSOR_GETTER):
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SVGMatrixCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-02-06 David Levin <levin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 23792: unused param is used in RenderLayer.cpp but not #include'd
+ <https://bugs.webkit.org/show_bug.cgi?id=23792>
+
+ Add include file for UnusedParam which is used in this file.
+
+ * rendering/RenderLayer.cpp:
+
+2009-02-06 David Levin <levin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23741>
+
+ Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
+ <https://bugs.webkit.org/show_bug.cgi?id=23798>
+
+ Add protocolInHTTPFamily() to the KURLGoogle implementation.
+ This is another chromium build fix to mirror r40553.
+
+ While in this file, I did some style fixes and consistency fixes:
+ + fixed many_occurences_of_underscoring_naming
+ + usages of NULL
+ + comparisons to 0
+ + changed the copyright remove an extraneous , and capitalize the (C)
+ which was suggested for other files that I've submitted.
+
+ No observable change in behavior, so no test.
+
+ * platform/KURL.h:
+ (WebCore::KURL::protocolInHTTPFamily):
+ * platform/KURLGoogle.cpp:
+ (WebCore::KURLCharsetConverter::ConvertFromUTF16):
+ (WebCore::lowerCaseEqualsASCII):
+ (WebCore::KURLGooglePrivate::KURLGooglePrivate):
+ (WebCore::KURLGooglePrivate::setUtf8):
+ (WebCore::KURLGooglePrivate::setAscii):
+ (WebCore::KURLGooglePrivate::init):
+ (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily):
+ (WebCore::KURLGooglePrivate::copyTo):
+ (WebCore::KURLGooglePrivate::replaceComponents):
+ (WebCore::KURL::KURL):
+ (WebCore::KURL::createCFURL):
+ (WebCore::KURL::isEmpty):
+ (WebCore::KURL::protocolInHTTPFamily):
+ (WebCore::KURL::query):
+ (WebCore::decodeURLEscapeSequences):
+ (WebCore::KURL::protocolIs):
+ (WebCore::encodeWithURLEscapeSequences):
+ (WebCore::KURL::invalidate):
+ (WebCore::equalIgnoringRef):
+ * platform/KURLGooglePrivate.h:
+
+2009-02-06 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer
+
+ Reviewed by Darin Adler.
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::contentDataEquivalent): Moved method to
+ WebCore::StyleRareNonInheritedData class.
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration
+ with inline method that calls contentDataEquivalent() on
+ WebCore::StyleRareNonInheritedData instead.
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix!
+ Replaced pointer comparison of ContentData objects with call to
+ StyleRareNonInheritedData::contentDataEquivalent().
+ (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
+ * rendering/style/StyleRareNonInheritedData.h:
+ (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added
+ declaration.
+
+2009-02-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Factor code that checks whether the object is rooted in
+ repaint() and repaintRectangle() into a common isRooted()
+ method.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::isRooted):
+ * rendering/RenderObject.h:
+
+2009-02-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Expose an isRootLayer() method on RenderLayer that works whether the
+ layer is rooted or not, and use that in a few places in the
+ accelerated compositing code.
+
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::isRootLayer):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintingGoesToWindow):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::requiresCompositingLayer):
+
+2009-02-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache
+
+ Most platforms do not retrieve the small caps font from the FontCache,
+ but cross-platform code in ~SimpleFontData() assumes the the small caps
+ font data did come from the cache and therefore calls releaseFontData()
+ on it.
+
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::~SimpleFontData): Reordered to call
+ platformDestroy() before releasing the small caps font and pruning the
+ glyph page tree. This allows platformDestroy() to reset
+ m_smallCapsFontData to 0 if it was not obtained from the cache.
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to
+ 0 after deleting it.
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformDestroy): Ditto.
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformDestroy): Ditto.
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformDestroy): Ditto.
+
+2009-02-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Make RenderStyle::transitionForProperty() const.
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::transitionForProperty):
+ * rendering/style/RenderStyle.h:
+
+2009-02-06 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is turned on.
+
+ Remove font smoothing changes that will be committed
+ separately.
+
+ * platform/graphics/mac/WebLayer.mm:
+ (WebCore::if):
+
+2009-02-06 Anders Carlsson <andersca@apple.com>
+
+ Build fix.
+
+ * bridge/npapi.h:
+
+2009-02-06 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23790
+ Custom -> JSCCustom in SVGPointList.idl
+
+ * svg/SVGPointList.idl:
+
+2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23309
+ Fix whitespace indent errors. The rest of the original patch has already
+ landed.
+
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::clear):
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::clear):
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::clear):
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::clear):
+
+2009-02-06 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
+ the context transparent.
+
+ [QT] clearRect fill's a given rect with white
+ https://bugs.webkit.org/show_bug.cgi?id=23728
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::clearRect):
+
+2009-02-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23781
+
+ When the document is attached and detached, and when it becomes active/inactive
+ (e.g. coming out or going into the page cache) we need to call
+ RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
+ layers.
+
+ Also, if Document::recalcStyle() does not do a layout, it needs to
+ update the compositing layers.
+
+ * dom/Document.cpp:
+ (WebCore::Document::updateRendering):
+ (WebCore::Document::updateLayout):
+ (WebCore::Document::attach):
+ (WebCore::Document::detach):
+ (WebCore::Document::documentWillBecomeInactive):
+ (WebCore::Document::documentDidBecomeActive):
+
+2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Added support for different ownership models for wrapped QObjects in
+ the JavaScript environment.
+
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget): Specify
+ QtOwnership for scriptable widgets.
+ * bridge/npruntime_internal.h: Add "NormalState" to the list of
+ undef'ed macros as an included Qt header uses "NormalState" as value
+ in an enum.
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::QtInstance): Save and initialize ownership
+ member.
+ (JSC::Bindings::QtInstance::~QtInstance): Respect
+ QScriptEngine::ValueOwnership policy with regards to wrapped m_object.
+ (JSC::Bindings::QtInstance::getQtInstance): Pass the ownership down to
+ the instance.
+ * bridge/qt/qt_instance.h:
+ (JSC::Bindings::QtInstance::create): Ditto.
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue): Use QtOwnership for
+ automatically wrapped QObjects.
+ (JSC::Bindings::QtConnectionObject::execute): Ditto.
+
+2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
+
+ Reviewed by Dan Bernstein and Geoff Garen.
+
+ - WebCore code to track per-day and per-week visit counts in history
+
+ The basic idea is as follows: we track daily visits for up to 13
+ days, and weekly visits for up to 5 weeks past the end of the
+ current daily visits. As soon as the number of daily counts goes
+ over 13, we squish them down into weeks, and then prune the excess weeks.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace.
+ (WebCore::timeToDay): Helper function: convert time to days from the epoch.
+ (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if
+ a site is visited after a span of days.
+ (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade
+ algorithm as described above.
+ (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all
+ info about a visit to this history item.
+ (WebCore::HistoryItem::setLastVisitedTime): Updated.
+ (WebCore::HistoryItem::visited): Updated.
+ (WebCore::HistoryItem::recordInitialVisit): New function to
+ handle recording data about the very first visit, replacing the
+ prior practice of explicitly setting visit count to 1.
+ (WebCore::HistoryItem::adoptVisitCounts): Take ownership of
+ daily and weekly visit count vectors.
+ (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment
+ noting that this function doesn't work properly now (though
+ this shouldn't matter much in practice.)
+ * history/HistoryItem.h:
+ (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts.
+ (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
+ * WebCore.base.exp: Add new symbols and sort.
+
+2009-02-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6438271> Improve backspace handling of accented characters
+
+ Test: platform/mac/editing/deleting/backward-delete.html
+
+ This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
+ because the current behavior matches their standards (tested on Windows, assumed elsewhere).
+
+ * dom/Position.cpp:
+ (WebCore::Position::previous):
+ (WebCore::Position::next):
+ (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
+ * dom/Position.h:
+ Added a new option for previous(), used to move to a next position for backward deletion.
+ Renamed EUsingComposedCharacters to PositionMoveType.
+
+ * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
+ Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
+ surrounding this code a little.
+
+ * editing/htmlediting.cpp:
+ (WebCore::nextVisuallyDistinctCandidate):
+ (WebCore::previousVisuallyDistinctCandidate):
+ Adjusted for renamed enum values.
+
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderText.h:
+ Added previousOffsetForBackwardDeletion().
+
+ * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
+ On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
+
+2009-02-05 Adam Roben <aroben@apple.com>
+
+ Fix a crash in RenderWidget::destroy when navigating away from a page
+ with an <iframe>
+
+ This was a regression caused by r40679
+
+ Reviewed by Dave Hyatt.
+
+ Tested by many many tests.
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we
+ finish accessing its members.
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ getAnimatedStyleForRenderer() should not create a new
+ CompositeAnimation if the object isn't already animating, and
+ it should just fall back to returning renderer->style().
+
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is turned on.
+
+ Give RenderLayerBacking some love after the great
+ RenderBoxModelObject split.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateLayerTransform):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ (WebCore::RenderLayerBacking::contentsBox):
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ (WebCore::RenderLayerBacking::startAnimation):
+ (WebCore::RenderLayerBacking::startTransition):
+ * rendering/RenderLayerBacking.h:
+ (WebCore::RenderLayerBacking::renderer):
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is turned on.
+
+ writeIndent() needs to be static to avoid warnings on some OSes,
+ and remove unused CAToTransform3D() method.
+
+ * platform/graphics/GraphicsLayer.cpp:
+ (WebCore::writeIndent):
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ Add some methods to the TransformOperation classes that are required
+ by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.
+
+ * platform/graphics/transforms/MatrixTransformOperation.h:
+ (WebCore::MatrixTransformOperation::create):
+ (WebCore::MatrixTransformOperation::MatrixTransformOperation):
+ * platform/graphics/transforms/ScaleTransformOperation.h:
+ (WebCore::ScaleTransformOperation::x):
+ (WebCore::ScaleTransformOperation::y):
+ * platform/graphics/transforms/TranslateTransformOperation.h:
+ (WebCore::TranslateTransformOperation::x):
+ (WebCore::TranslateTransformOperation::y):
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
+ and correct a usage of UNUSED_PARAM().
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::startAnimation):
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Fix build when ACCELERATED_COMPOSITING is turned on.
+
+ animationOfPropertyIsAccelerated() needs to be public because
+ it is called from AnimationController.
+
+ * page/animation/AnimationBase.h:
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
+ the build.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateCompositingLayers):
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix missing checked toRenderBlock casts.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::clearFloats):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::availableHeightUsing):
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Patch from Darin Adler.
+ Reviewed by Sam Weinig.
+
+ Fix case where we were casting to RenderView.
+
+ No test case possible.
+
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+
+2009-02-05 Aaron Boodman <aa@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23708
+ Adds documentElementAvailable() callback to FrameLoaderClient.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::startElementNs):
+ Add call to dispatchDocumentElementAvailable()
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseStartElement):
+ Ditto.
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::insertNode):
+ Ditto.
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::documentElementAvailable):
+ Stub out documentElementAvailable().
+ * loader/FrameLoader.cpp:
+ documentElementAvailable() callback plumbing.
+ * loader/FrameLoader.h:
+ Ditto.
+ * loader/FrameLoaderClient.h:
+ Add new documentElementAvailable() callback.
+
+2009-02-05 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23766
+ CanvasRenderingContext2D::setShadow needs else for other platforms.
+
+ Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
+ other platforms using the CMYK color constructor.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setShadow):
+
+2009-02-05 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23687
+ Wires up Skia'a ImageBuffer::toDataURL to support pngs.
+ This helps Chromium pass a couple of layout tests.
+
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::toDataURL):
+ * platform/image-encoders: Added.
+ * platform/image-encoders/skia: Added.
+ * platform/image-encoders/skia/PNGImageEncoder.cpp: Added.
+ (WebCore::):
+ (WebCore::PngEncoderState::EncoderWriteCallback):
+ (WebCore::PngEncoderState::ConvertBGRAtoRGB):
+ (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer):
+ (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer):
+ (WebCore::PNGImageEncoder::encode):
+ * platform/image-encoders/skia/PNGImageEncoder.h: Added.
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix missing checked cast.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::containingBlock):
+
+2009-02-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix WML enabled builds.
+
+ FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.
+
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::executeTask):
+
+2009-02-05 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23625
+ Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer
+
+ Fixes three bugs in PlatformContextSkia:
+
+ * When a new layer was started clipped to an image we used the
+ assignment operator to copy the SkBitmap. If the SkBitmap owns it's
+ pixels, this is not the right thing to do. Instead we need to create
+ a copy of the image.
+ * State holds an SkBitmap by value. State's copy constructor does a
+ memcpy. This is confusing and subtle, I've converted to use a member
+ initializer list which I think is clearer and less error prone.
+ * When creating a new layer there is no need to copy the clip image.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::State::State):
+ (PlatformContextSkia::save):
+ (PlatformContextSkia::beginLayerClippedToImage):
+
+2009-02-05 Scott Violet <sky@google.com>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23462
+ Changes call from setFillColor to setStrokeColor.
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+
+2009-02-05 David Hyatt <hyatt@apple.com>
+
+ Fix crash on svg custom stop test. A virtual function didn't get patched properly.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGGradientStop.h:
+ (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
+
+2009-02-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23765
+
+ Add toRenderBoxModelObject() so that we can cast objects that
+ can have layers.
+
+ Fix getComputedStyle to return the current value of style
+ properties that are undergoing accelerated animations, by
+ asking the AnimationController if the property has accelerated
+ animations, and, if so, asking it to generate an appropriate
+ style.
+
+ Tightened up some type safety (CSSPropertyID), and code clarity
+ (replace bool with enum).
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::hasCompositedLayer):
+ (WebCore::computedTransform):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
+ (WebCore::AnimationController::isAnimatingPropertyOnRenderer):
+ (WebCore::AnimationController::supportsAcceleratedAnimationOfProperty):
+ * page/animation/AnimationController.h:
+ * page/animation/AnimationControllerPrivate.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::startAnimation):
+ (WebCore::ImplicitAnimation::endAnimation):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::startAnimation):
+ (WebCore::KeyframeAnimation::endAnimation):
+ * rendering/RenderBoxModelObject.h:
+ (WebCore::RenderBoxModelObject::isBoxModelObject):
+ (WebCore::toRenderBoxModelObject):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateLayerTransform):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isBoxModelObject):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::applyTransform):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::):
+
+2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23767
+ Add custom V8 bindings for HTML5 database.
+
+ * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added.
+ (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
+ (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback):
+ (WebCore::V8CustomSQLStatementCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLStatementCallback.h: Added.
+ (WebCore::V8CustomSQLStatementCallback::create):
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added.
+ (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
+ (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback):
+ (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added.
+ (WebCore::V8CustomSQLStatementErrorCallback::create):
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added.
+ (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
+ (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback):
+ (WebCore::V8CustomSQLTransactionCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added.
+ (WebCore::V8CustomSQLTransactionCallback::create):
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added.
+ (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
+ (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback):
+ (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added.
+ (WebCore::V8CustomSQLTransactionErrorCallback::create):
+ * bindings/v8/custom/V8CustomVoidCallback.cpp: Added.
+ (WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
+ (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback):
+ (WebCore::V8CustomVoidCallback::handleEvent):
+ (WebCore::invokeCallback):
+ * bindings/v8/custom/V8CustomVoidCallback.h: Added.
+ (WebCore::V8CustomVoidCallback::create):
+ * bindings/v8/custom/V8DatabaseCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp: Added.
+ (WebCore::CALLBACK_FUNC_DECL):
+
+2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23747
+ Add Chromium threading-related files.
+
+ * platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
+ is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
+ is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.
+
+ * rendering/RenderButton.h:
+ (WebCore::RenderButton::isRenderButton):
+ (WebCore::toRenderButton):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::paintObject):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isRenderButton):
+
+2009-02-05 David Hyatt <hyatt@apple.com>
+
+ Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
+ of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
+ In order to set the various RenderObject bits properly prior to the test for whether a layer is
+ required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
+ for setting all of the bits.
+
+ Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
+ RenderStyle, and just use the corresponding layer() methods for the
+ staticX/Y getters/setters.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::adjustPositionedBlock):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ (WebCore::RenderBlock::layoutPositionedObjects):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::offsetForContents):
+ (WebCore::RenderBlock::calcPrefWidths):
+ (WebCore::RenderBlock::baselinePosition):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::RenderBox):
+ (WebCore::RenderBox::destroy):
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::updateBoxModelInfoFromStyle):
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+ (WebCore::RenderBox::scrollLeft):
+ (WebCore::RenderBox::scrollTop):
+ (WebCore::RenderBox::setScrollLeft):
+ (WebCore::RenderBox::setScrollTop):
+ (WebCore::RenderBox::getOverflowClipRect):
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::absoluteToLocal):
+ (WebCore::RenderBox::localToContainerQuad):
+ (WebCore::RenderBox::position):
+ (WebCore::RenderBox::computeRectForRepaint):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ * rendering/RenderBox.h:
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::RenderBoxModelObject):
+ (WebCore::RenderBoxModelObject::destroy):
+ (WebCore::RenderBoxModelObject::styleWillChange):
+ (WebCore::RenderBoxModelObject::styleDidChange):
+ (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
+ * rendering/RenderBoxModelObject.h:
+ (WebCore::RenderBoxModelObject::layer):
+ (WebCore::RenderBoxModelObject::requiresLayer):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::updateBoxModelInfoFromStyle):
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::relativePositionedInlineOffset):
+ * rendering/RenderInline.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::setStaticY):
+ (WebCore::RenderLayer::updateLayerPosition):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setStyle):
+ (WebCore::RenderObject::styleDidChange):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::markContainingBlocksForLayout):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::paint):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy):
+ * rendering/bidi.cpp:
+ (WebCore::appendRunsForObject):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::RenderBlock::findNextLineBreak):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::hasStaticX):
+ (WebCore::InheritedFlags::hasStaticY):
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Fix the windows build.
+
+ * bindings/scripts/CodeGeneratorCOM.pm:
+ * dom/Node.idl:
+
+2009-02-05 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ Update to match Gecko.
+
+ * bridge/npapi.h:
+ * plugins/npfunctions.h:
+
+2009-02-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Finish merging EventTargetNode up into Node.
+
+ This also fixes a small recently introduced issue where EventListeners
+ would not be removed from the document if they were attached to comment
+ nodes outside of the documentElement.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSEventTargetNodeCustom.cpp: Removed.
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ (WebCore::JSNode::pushEventHandlerScope):
+ * bindings/scripts/CodeGenerator.pm:
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::CharacterData):
+ (WebCore::CharacterData::rendererIsNeeded):
+ * dom/CharacterData.h:
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::willRemove):
+ (WebCore::ContainerNode::attach):
+ (WebCore::ContainerNode::detach):
+ (WebCore::ContainerNode::insertedIntoDocument):
+ (WebCore::ContainerNode::removedFromDocument):
+ (WebCore::ContainerNode::setFocus):
+ (WebCore::ContainerNode::setActive):
+ (WebCore::ContainerNode::setHovered):
+ (WebCore::dispatchChildInsertionEvents):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/ContainerNode.h:
+ (WebCore::ContainerNode::ContainerNode):
+ * dom/Document.cpp:
+ (WebCore::Document::removeAllEventListenersFromAllNodes):
+ (WebCore::Document::removeAllDisconnectedNodeEventListeners):
+ (WebCore::Document::setFocusedNode):
+ * dom/EventTargetNode.cpp: Removed.
+ * dom/EventTargetNode.h: Removed.
+ * dom/Node.cpp:
+ (WebCore::Node::scriptExecutionContext):
+ (WebCore::Node::eventListeners):
+ (WebCore::Node::insertedIntoDocument):
+ (WebCore::Node::removedFromDocument):
+ (WebCore::Node::willMoveToNewOwnerDocument):
+ (WebCore::Node::didMoveToNewOwnerDocument):
+ (WebCore::updateSVGElementInstancesAfterEventListenerChange):
+ (WebCore::Node::addEventListener):
+ (WebCore::Node::removeEventListener):
+ (WebCore::Node::removeAllEventListenersSlowCase):
+ (WebCore::Node::handleLocalEvents):
+ (WebCore::eventTargetAsSVGElementInstance):
+ (WebCore::eventTargetRespectingSVGTargetRules):
+ (WebCore::Node::dispatchEvent):
+ (WebCore::Node::dispatchGenericEvent):
+ (WebCore::Node::dispatchSubtreeModifiedEvent):
+ (WebCore::Node::dispatchWindowEvent):
+ (WebCore::Node::dispatchUIEvent):
+ (WebCore::Node::dispatchKeyEvent):
+ (WebCore::Node::dispatchMouseEvent):
+ (WebCore::Node::dispatchSimulatedMouseEvent):
+ (WebCore::Node::dispatchSimulatedClick):
+ (WebCore::Node::dispatchWheelEvent):
+ (WebCore::Node::dispatchWebKitAnimationEvent):
+ (WebCore::Node::dispatchWebKitTransitionEvent):
+ (WebCore::Node::dispatchFocusEvent):
+ (WebCore::Node::dispatchBlurEvent):
+ (WebCore::Node::dispatchEventForType):
+ (WebCore::Node::dispatchProgressEvent):
+ (WebCore::Node::dispatchStorageEvent):
+ (WebCore::Node::removeInlineEventListenerForType):
+ (WebCore::Node::setInlineEventListenerForType):
+ (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
+ (WebCore::Node::inlineEventListenerForType):
+ (WebCore::Node::disabled):
+ (WebCore::Node::defaultEventHandler):
+ (WebCore::Node::onabort):
+ (WebCore::Node::setOnabort):
+ (WebCore::Node::onblur):
+ (WebCore::Node::setOnblur):
+ (WebCore::Node::onchange):
+ (WebCore::Node::setOnchange):
+ (WebCore::Node::onclick):
+ (WebCore::Node::setOnclick):
+ (WebCore::Node::oncontextmenu):
+ (WebCore::Node::setOncontextmenu):
+ (WebCore::Node::ondblclick):
+ (WebCore::Node::setOndblclick):
+ (WebCore::Node::onerror):
+ (WebCore::Node::setOnerror):
+ (WebCore::Node::onfocus):
+ (WebCore::Node::setOnfocus):
+ (WebCore::Node::oninput):
+ (WebCore::Node::setOninput):
+ (WebCore::Node::onkeydown):
+ (WebCore::Node::setOnkeydown):
+ (WebCore::Node::onkeypress):
+ (WebCore::Node::setOnkeypress):
+ (WebCore::Node::onkeyup):
+ (WebCore::Node::setOnkeyup):
+ (WebCore::Node::onload):
+ (WebCore::Node::setOnload):
+ (WebCore::Node::onmousedown):
+ (WebCore::Node::setOnmousedown):
+ (WebCore::Node::onmousemove):
+ (WebCore::Node::setOnmousemove):
+ (WebCore::Node::onmouseout):
+ (WebCore::Node::setOnmouseout):
+ (WebCore::Node::onmouseover):
+ (WebCore::Node::setOnmouseover):
+ (WebCore::Node::onmouseup):
+ (WebCore::Node::setOnmouseup):
+ (WebCore::Node::onmousewheel):
+ (WebCore::Node::setOnmousewheel):
+ (WebCore::Node::onbeforecut):
+ (WebCore::Node::setOnbeforecut):
+ (WebCore::Node::oncut):
+ (WebCore::Node::setOncut):
+ (WebCore::Node::onbeforecopy):
+ (WebCore::Node::setOnbeforecopy):
+ (WebCore::Node::oncopy):
+ (WebCore::Node::setOncopy):
+ (WebCore::Node::onbeforepaste):
+ (WebCore::Node::setOnbeforepaste):
+ (WebCore::Node::onpaste):
+ (WebCore::Node::setOnpaste):
+ (WebCore::Node::ondragenter):
+ (WebCore::Node::setOndragenter):
+ (WebCore::Node::ondragover):
+ (WebCore::Node::setOndragover):
+ (WebCore::Node::ondragleave):
+ (WebCore::Node::setOndragleave):
+ (WebCore::Node::ondrop):
+ (WebCore::Node::setOndrop):
+ (WebCore::Node::ondragstart):
+ (WebCore::Node::setOndragstart):
+ (WebCore::Node::ondrag):
+ (WebCore::Node::setOndrag):
+ (WebCore::Node::ondragend):
+ (WebCore::Node::setOndragend):
+ (WebCore::Node::onreset):
+ (WebCore::Node::setOnreset):
+ (WebCore::Node::onresize):
+ (WebCore::Node::setOnresize):
+ (WebCore::Node::onscroll):
+ (WebCore::Node::setOnscroll):
+ (WebCore::Node::onsearch):
+ (WebCore::Node::setOnsearch):
+ (WebCore::Node::onselect):
+ (WebCore::Node::setOnselect):
+ (WebCore::Node::onselectstart):
+ (WebCore::Node::setOnselectstart):
+ (WebCore::Node::onsubmit):
+ (WebCore::Node::setOnsubmit):
+ (WebCore::Node::onunload):
+ (WebCore::Node::setOnunload):
+ * dom/Node.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::dispatchCPPEvent):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::handleLocalEvents):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchDragEvent):
+ (WebCore::EventHandler::updateMouseEventTargetNode):
+ (WebCore::EventHandler::dispatchMouseEvent):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::canMouseDownStartSelect):
+ (WebCore::EventHandler::canMouseDragExtendSelect):
+ (WebCore::eventTargetNodeForDocument):
+ (WebCore::EventHandler::keyEvent):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scheduleEvent):
+ (WebCore::FrameView::updateOverflowStatus):
+ * page/FrameView.h:
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset):
+ (WebCore::RenderLayer::updateOverflowStatus):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::valueChanged):
+ * rendering/RenderMedia.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::selectionChanged):
+ * svg/SVGElementInstance.h:
+ (WebCore::SVGElementInstance::toNode):
+ * xml/XPathExpression.cpp:
+ (WebCore::XPathExpression::evaluate):
+ * xml/XPathResult.cpp:
+ (WebCore::XPathResult::XPathResult):
+
+2009-02-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build now that EventTargetNode.idl was removed in r40672.
+
+ * WebCore.pro:
+
+2009-02-05 Scott Violet <sky@google.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23462: Add RGB -> CMYK conversion algorithm
+ <https://bugs.webkit.org/show_bug.cgi?id=23462>
+
+ Adds an RGB -> CMYK converter. This isn't perfect, but better than
+ nothing.
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+ (WebCore::CanvasStyle::cmykToRGB):
+ * html/CanvasStyle.h:
+
+2009-02-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ First stage of merging EventTargetNode up into Node. The intent of this change
+ is to both simplify the inheritance hierarchy (at the same time making it more
+ closely match the spec which states that all Nodes are EventTargets) and save
+ 4 bytes per Node that the polymorphic multiple-inheritance was costing us.
+
+ This does the bare minimum to get things compiling, the next patch will clean
+
+ * DerivedSources.make:
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::mark):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventTarget.cpp:
+ (WebCore::toEventTarget):
+ * bindings/js/JSEventTarget.h:
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ (WebCore::JSNode::addEventListener):
+ (WebCore::JSNode::removeEventListener):
+ (WebCore::JSNode::pushEventHandlerScope):
+ * bindings/js/JSStyleSheetCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * dom/Attr.idl:
+ * dom/CharacterData.h:
+ * dom/CharacterData.idl:
+ * dom/Document.idl:
+ * dom/DocumentFragment.idl:
+ * dom/Element.idl:
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::toNode):
+ * dom/EventTarget.h:
+ * dom/EventTarget.idl:
+ * dom/EventTargetNode.cpp:
+ (WebCore::Node::scriptExecutionContext):
+ (WebCore::Node::eventListeners):
+ (WebCore::Node::insertedIntoDocument):
+ (WebCore::Node::removedFromDocument):
+ (WebCore::Node::willMoveToNewOwnerDocument):
+ (WebCore::Node::didMoveToNewOwnerDocument):
+ (WebCore::Node::addEventListener):
+ (WebCore::Node::removeEventListener):
+ (WebCore::Node::removeAllEventListenersSlowCase):
+ (WebCore::Node::handleLocalEvents):
+ (WebCore::Node::dispatchEvent):
+ (WebCore::Node::dispatchGenericEvent):
+ (WebCore::Node::dispatchSubtreeModifiedEvent):
+ (WebCore::Node::dispatchWindowEvent):
+ (WebCore::Node::dispatchUIEvent):
+ (WebCore::Node::dispatchKeyEvent):
+ (WebCore::Node::dispatchMouseEvent):
+ (WebCore::Node::dispatchSimulatedMouseEvent):
+ (WebCore::Node::dispatchSimulatedClick):
+ (WebCore::Node::dispatchWheelEvent):
+ (WebCore::Node::dispatchWebKitAnimationEvent):
+ (WebCore::Node::dispatchWebKitTransitionEvent):
+ (WebCore::Node::dispatchFocusEvent):
+ (WebCore::Node::dispatchBlurEvent):
+ (WebCore::Node::dispatchEventForType):
+ (WebCore::Node::dispatchProgressEvent):
+ (WebCore::Node::dispatchStorageEvent):
+ (WebCore::Node::removeInlineEventListenerForType):
+ (WebCore::Node::setInlineEventListenerForType):
+ (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
+ (WebCore::Node::inlineEventListenerForType):
+ (WebCore::Node::disabled):
+ (WebCore::Node::defaultEventHandler):
+ (WebCore::Node::onabort):
+ (WebCore::Node::setOnabort):
+ (WebCore::Node::onblur):
+ (WebCore::Node::setOnblur):
+ (WebCore::Node::onchange):
+ (WebCore::Node::setOnchange):
+ (WebCore::Node::onclick):
+ (WebCore::Node::setOnclick):
+ (WebCore::Node::oncontextmenu):
+ (WebCore::Node::setOncontextmenu):
+ (WebCore::Node::ondblclick):
+ (WebCore::Node::setOndblclick):
+ (WebCore::Node::onerror):
+ (WebCore::Node::setOnerror):
+ (WebCore::Node::onfocus):
+ (WebCore::Node::setOnfocus):
+ (WebCore::Node::oninput):
+ (WebCore::Node::setOninput):
+ (WebCore::Node::onkeydown):
+ (WebCore::Node::setOnkeydown):
+ (WebCore::Node::onkeypress):
+ (WebCore::Node::setOnkeypress):
+ (WebCore::Node::onkeyup):
+ (WebCore::Node::setOnkeyup):
+ (WebCore::Node::onload):
+ (WebCore::Node::setOnload):
+ (WebCore::Node::onmousedown):
+ (WebCore::Node::setOnmousedown):
+ (WebCore::Node::onmousemove):
+ (WebCore::Node::setOnmousemove):
+ (WebCore::Node::onmouseout):
+ (WebCore::Node::setOnmouseout):
+ (WebCore::Node::onmouseover):
+ (WebCore::Node::setOnmouseover):
+ (WebCore::Node::onmouseup):
+ (WebCore::Node::setOnmouseup):
+ (WebCore::Node::onmousewheel):
+ (WebCore::Node::setOnmousewheel):
+ (WebCore::Node::onbeforecut):
+ (WebCore::Node::setOnbeforecut):
+ (WebCore::Node::oncut):
+ (WebCore::Node::setOncut):
+ (WebCore::Node::onbeforecopy):
+ (WebCore::Node::setOnbeforecopy):
+ (WebCore::Node::oncopy):
+ (WebCore::Node::setOncopy):
+ (WebCore::Node::onbeforepaste):
+ (WebCore::Node::setOnbeforepaste):
+ (WebCore::Node::onpaste):
+ (WebCore::Node::setOnpaste):
+ (WebCore::Node::ondragenter):
+ (WebCore::Node::setOndragenter):
+ (WebCore::Node::ondragover):
+ (WebCore::Node::setOndragover):
+ (WebCore::Node::ondragleave):
+ (WebCore::Node::setOndragleave):
+ (WebCore::Node::ondrop):
+ (WebCore::Node::setOndrop):
+ (WebCore::Node::ondragstart):
+ (WebCore::Node::setOndragstart):
+ (WebCore::Node::ondrag):
+ (WebCore::Node::setOndrag):
+ (WebCore::Node::ondragend):
+ (WebCore::Node::setOndragend):
+ (WebCore::Node::onreset):
+ (WebCore::Node::setOnreset):
+ (WebCore::Node::onresize):
+ (WebCore::Node::setOnresize):
+ (WebCore::Node::onscroll):
+ (WebCore::Node::setOnscroll):
+ (WebCore::Node::onsearch):
+ (WebCore::Node::setOnsearch):
+ (WebCore::Node::onselect):
+ (WebCore::Node::setOnselect):
+ (WebCore::Node::onselectstart):
+ (WebCore::Node::setOnselectstart):
+ (WebCore::Node::onsubmit):
+ (WebCore::Node::setOnsubmit):
+ (WebCore::Node::onunload):
+ (WebCore::Node::setOnunload):
+ * dom/EventTargetNode.h:
+ (WebCore::toEventTargetNode):
+ (WebCore::EventTargetNodeCast):
+ * dom/EventTargetNode.idl: Removed.
+ * dom/MouseEvent.cpp:
+ (WebCore::MouseEvent::MouseEvent):
+ (WebCore::MouseEvent::initMouseEvent):
+ (WebCore::MouseEvent::toElement):
+ (WebCore::MouseEvent::fromElement):
+ * dom/MouseEvent.h:
+ (WebCore::MouseEvent::create):
+ (WebCore::MouseEvent::relatedTarget):
+ * dom/Node.cpp:
+ (WebCore::Node::~Node):
+ * dom/Node.h:
+ (WebCore::Node::isEventTargetNode):
+ (WebCore::Node::toNode):
+ (WebCore::Node::removeAllEventListeners):
+ (WebCore::Node::refEventTarget):
+ (WebCore::Node::derefEventTarget):
+ * dom/Node.idl:
+ * page/EventHandler.h:
+ * page/FrameView.h:
+ * xml/XPathResult.h:
+ (WebCore::XPathResult::create):
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
+ container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.
+
+ All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
+ or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
+ properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
+ under the right conditions.
+
+ There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
+ 0, this subtraction wasn't necessary. It has been removed.
+
+ Reviewed by Adam Roben
+
+ * page/animation/AnimationBase.cpp:
+ * rendering/RenderBR.h:
+ (WebCore::RenderBR::selectionRectForRepaint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::selectionGapRectsForRepaint):
+ (WebCore::RenderBlock::rectWithOutlineForRepaint):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::selectionRectForRepaint):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::outlineBoundsForRepaint):
+ (WebCore::RenderBox::localToContainerQuad):
+ (WebCore::RenderBox::clippedOverflowRectForRepaint):
+ (WebCore::RenderBox::computeRectForRepaint):
+ * rendering/RenderBox.h:
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::relativePositionOffsetX):
+ (WebCore::RenderBoxModelObject::relativePositionOffsetY):
+ * rendering/RenderBoxModelObject.h:
+ (WebCore::RenderBoxModelObject::relativePositionOffset):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::computeRectForRepaint):
+ * rendering/RenderForeignObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ (WebCore::RenderInline::rectWithOutlineForRepaint):
+ * rendering/RenderInline.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::setHasVisibleContent):
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::scrollToOffset):
+ (WebCore::RenderLayer::scrollRectToVisible):
+ (WebCore::resizerCornerRect):
+ (WebCore::RenderLayer::scrollbarCornerPresent):
+ (WebCore::RenderLayer::invalidateScrollbarRect):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::computeScrollDimensions):
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::isPointInResizeControl):
+ (WebCore::RenderLayer::hitTestOverflowControls):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::localBoundingBox):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::renderer):
+ (WebCore::RenderLayer::renderBox):
+ (WebCore::RenderLayer::renderBoxX):
+ (WebCore::RenderLayer::renderBoxY):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::selectionRectForRepaint):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderMarquee.cpp:
+ (WebCore::RenderMarquee::computePosition):
+ (WebCore::RenderMarquee::timerFired):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::containerForRepaint):
+ (WebCore::RenderObject::repaintUsingContainer):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ (WebCore::RenderObject::rectWithOutlineForRepaint):
+ (WebCore::RenderObject::clippedOverflowRectForRepaint):
+ (WebCore::RenderObject::computeRectForRepaint):
+ (WebCore::RenderObject::localToContainerQuad):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::selectionRectForRepaint):
+ (WebCore::RenderObject::outlineBoundsForRepaint):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::clippedOverflowRectForRepaint):
+ (WebCore::RenderPath::outlineBoundsForRepaint):
+ * rendering/RenderPath.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::selectionRectForRepaint):
+ (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::selectionRectForRepaint):
+ (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSelectionInfo.h:
+ (WebCore::RenderSelectionInfoBase::repaintContainer):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+ (WebCore::RenderTableCell::computeRectForRepaint):
+ (WebCore::RenderTableCell::localToContainerQuad):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
+ * rendering/RenderTableCol.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::clippedOverflowRectForRepaint):
+ (WebCore::RenderText::selectionRectForRepaint):
+ * rendering/RenderText.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::localToContainerQuad):
+ (WebCore::RenderView::computeRectForRepaint):
+ * rendering/RenderView.h:
+
+2009-02-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
+
+2009-02-05 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Alexey Proskuryakov.
+ Landed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23733
+
+ Use a 2 arguments constructor for KURL to avoid ASSERT failure.
+
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
+
+2009-02-04 Feng Qian <feng@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add Android-specific files to WebCore/editing directory.
+ https://bugs.webkit.org/show_bug.cgi?id=23294
+
+ * editing/android: Added.
+ * editing/android/EditorAndroid.cpp: Added.
+ (WebCore::Editor::newGeneralClipboard):
+
+2009-02-04 Dean Jackson <dino@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Remove -webkit-animation-play-state
+ The AnimationController still has the code to execute the property, but
+ it is no longer parsed or recorded.
+ https://bugs.webkit.org/show_bug.cgi?id=22907
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseAnimationProperty):
+ * css/CSSParser.h:
+ * css/CSSPropertyNames.in:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/CSSStyleSelector.h:
+ * platform/animation/Animation.h:
+ * rendering/style/RenderStyleConstants.h:
+
+2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Darin Adler.
+
+ Make sure we don't load on removing the media element from the document
+ https://bugs.webkit.org/show_bug.cgi?id=22105
+
+ Test: media/remove-from-document-no-load.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::removedFromDocument):
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
+ now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
+ derived from RenderBox for now.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::RenderBox):
+ (WebCore::RenderBox::destroy):
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::computeRectForRepaint):
+ * rendering/RenderBox.h:
+ * rendering/RenderBoxModelObject.cpp: Added.
+ (WebCore::RenderBoxModelObject::RenderBoxModelObject):
+ (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
+ * rendering/RenderBoxModelObject.h: Added.
+ * rendering/RenderObject.h:
+
+2009-02-04 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Added accelerated animation support to AnimationController and friends. The primary
+ changes are:
+ * accelerated animations get their start time from the compositing engine, so we
+ wait for a callback (notifyAnimationStarted()) in order to get the start time.
+ * if software and accelerated animations start in the same cycle, they all need
+ to use the same start time, which is that of the accelerated animations.
+
+ Added AnimationControllerPrivate to preserve the encapsulation under
+ AnimationController.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/animation/AnimationBase.cpp:
+ (WebCore::PropertyWrapperBase::animationIsAccelerated):
+ (WebCore::PropertyWrapperAcceleratedOpacity::PropertyWrapperAcceleratedOpacity):
+ (WebCore::PropertyWrapperAcceleratedOpacity::animationIsAccelerated):
+ (WebCore::PropertyWrapperAcceleratedOpacity::blend):
+ (WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform):
+ (WebCore::PropertyWrapperAcceleratedTransform::animationIsAccelerated):
+ (WebCore::PropertyWrapperAcceleratedTransform::blend):
+ (WebCore::ensurePropertyMap):
+ (WebCore::AnimationBase::AnimationBase):
+ (WebCore::AnimationBase::~AnimationBase):
+ (WebCore::AnimationBase::blendProperties):
+ (WebCore::AnimationBase::animationOfPropertyIsAccelerated):
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
+ (WebCore::AnimationBase::willNeedService):
+ (WebCore::AnimationBase::getTimeToNextEvent):
+ (WebCore::AnimationBase::goIntoEndingOrLoopingState):
+ (WebCore::AnimationBase::beginAnimationUpdateTime):
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::onAnimationStartResponse):
+ (WebCore::AnimationBase::getAnimatedStyle):
+ (WebCore::AnimationBase::isAnimatingProperty):
+ (WebCore::AnimationBase::endAnimation):
+ (WebCore::AnimationBase::isFallbackAnimating):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
+ (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
+ (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
+ (WebCore::AnimationControllerPrivate::animationTimerFired):
+ (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
+ (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
+ (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
+ (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
+ (WebCore::AnimationControllerPrivate::styleAvailable):
+ (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
+ (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
+ (WebCore::AnimationControllerPrivate::startTimeResponse):
+ (WebCore::AnimationController::getAnimatedStyleForRenderer):
+ (WebCore::AnimationController::notifyAnimationStarted):
+ (WebCore::AnimationController::endAnimationUpdate):
+ * page/animation/AnimationController.h:
+ * page/animation/AnimationControllerPrivate.h: Added.
+ (WebCore::AnimationControllerPrivate::hasAnimations):
+ (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
+ (WebCore::AnimationControllerPrivate::endAnimationUpdate):
+ (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
+ (WebCore::CompositeAnimationPrivate::animationControllerPriv):
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
+ (WebCore::CompositeAnimationPrivate::animate):
+ (WebCore::CompositeAnimationPrivate::getAnimatedStyle):
+ (WebCore::CompositeAnimationPrivate::addToStartTimeResponseWaitList):
+ (WebCore::CompositeAnimationPrivate::removeFromStartTimeResponseWaitList):
+ (WebCore::CompositeAnimation::CompositeAnimation):
+ (WebCore::CompositeAnimation::animationControllerPriv):
+ (WebCore::CompositeAnimation::getAnimatedStyle):
+ (WebCore::CompositeAnimation::addToStartTimeResponseWaitList):
+ (WebCore::CompositeAnimation::removeFromStartTimeResponseWaitList):
+ * page/animation/CompositeAnimation.h:
+ (WebCore::CompositeAnimation::create):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::shouldSendEventForListener):
+ (WebCore::ImplicitAnimation::animate):
+ (WebCore::ImplicitAnimation::getAnimatedStyle):
+ (WebCore::ImplicitAnimation::startAnimation):
+ (WebCore::ImplicitAnimation::endAnimation):
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ (WebCore::ImplicitAnimation::willNeedService):
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
+ (WebCore::KeyframeAnimation::animate):
+ (WebCore::KeyframeAnimation::getAnimatedStyle):
+ (WebCore::KeyframeAnimation::startAnimation):
+ (WebCore::KeyframeAnimation::endAnimation):
+ (WebCore::KeyframeAnimation::shouldSendEventForListener):
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ (WebCore::KeyframeAnimation::willNeedService):
+ * page/animation/KeyframeAnimation.h:
+ * platform/graphics/GraphicsLayerClient.h:
+ * platform/graphics/mac/GraphicsLayerCA.mm:
+ (-[WebAnimationDelegate animationDidStart:]):
+ * rendering/RenderLayerBacking.h:
+
+2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Not reviewed, build fix.
+
+ Remove duplicate definition of msSans in FontCache::alternateFamilyName.
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::alternateFamilyName):
+
+2009-02-04 Eric Seidel <eric@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Reverse the meaning of the if check so that Android
+ (dpad devices) do not scroll on focus and normal platforms do
+ http://trac.webkit.org/changeset/40647
+
+ This was caught by George Staikos, and I wrote the patch.
+
+ * dom/Element.cpp:
+ (WebCore::Element::updateFocusAppearance):
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Eliminate RenderContainer.
+
+ Reviewed by Sam and Anders
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::RenderBlock):
+ (WebCore::RenderBlock::destroy):
+ (WebCore::RenderBlock::styleWillChange):
+ (WebCore::RenderBlock::styleDidChange):
+ (WebCore::RenderBlock::addChild):
+ (WebCore::RenderBlock::dirtyLineBoxes):
+ (WebCore::RenderBlock::createInlineBox):
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::setSelectionState):
+ (WebCore::RenderBlock::avoidsFloats):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ (WebCore::RenderBlock::baselinePosition):
+ (WebCore::RenderBlock::getBaselineOfFirstLineBox):
+ (WebCore::RenderBlock::getBaselineOfLastLineBox):
+ (WebCore::RenderBlock::rectWithOutlineForRepaint):
+ (WebCore::RenderBlock::hoverAncestor):
+ (WebCore::RenderBlock::updateDragState):
+ (WebCore::RenderBlock::localCaretRect):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::virtualChildren):
+ (WebCore::RenderBlock::children):
+ * rendering/RenderContainer.cpp: Removed.
+ * rendering/RenderContainer.h: Removed.
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::RenderFrameSet):
+ (WebCore::RenderFrameSet::nodeAtPoint):
+ (WebCore::RenderFrameSet::layout):
+ * rendering/RenderFrameSet.h:
+ (WebCore::RenderFrameSet::virtualChildren):
+ (WebCore::RenderFrameSet::children):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::destroy):
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::nextContinuation):
+ (WebCore::RenderInline::continuationBefore):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::splitFlow):
+ (WebCore::RenderInline::addChildToContinuation):
+ (WebCore::RenderInline::offsetLeft):
+ (WebCore::RenderInline::offsetTop):
+ (WebCore::RenderInline::positionForCoordinates):
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ (WebCore::RenderInline::rectWithOutlineForRepaint):
+ (WebCore::RenderInline::updateDragState):
+ (WebCore::RenderInline::childBecameNonInline):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::virtualChildren):
+ (WebCore::RenderInline::children):
+ (WebCore::RenderInline::continuation):
+ (WebCore::RenderInline::setContinuation):
+ * rendering/RenderLineBoxList.h:
+ * rendering/RenderObject.h:
+ * rendering/RenderObjectChildList.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::RenderSVGRoot):
+ (WebCore::RenderSVGRoot::applyContentTransforms):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::absoluteTransform):
+ (WebCore::RenderSVGRoot::nodeAtPoint):
+ (WebCore::RenderSVGRoot::position):
+ * rendering/RenderSVGRoot.h:
+ (WebCore::RenderSVGRoot::virtualChildren):
+ (WebCore::RenderSVGRoot::children):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ (WebCore::RenderTable::removeChild):
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::RenderTableCol):
+ * rendering/RenderTableCol.h:
+ (WebCore::RenderTableCol::virtualChildren):
+ (WebCore::RenderTableCol::children):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::RenderTableRow):
+ (WebCore::RenderTableRow::destroy):
+ (WebCore::RenderTableRow::styleWillChange):
+ (WebCore::RenderTableRow::addChild):
+ * rendering/RenderTableRow.h:
+ (WebCore::RenderTableRow::virtualChildren):
+ (WebCore::RenderTableRow::children):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::RenderTableSection):
+ (WebCore::RenderTableSection::destroy):
+ (WebCore::RenderTableSection::addChild):
+ (WebCore::RenderTableSection::removeChild):
+ (WebCore::RenderTableSection::lowestPosition):
+ (WebCore::RenderTableSection::rightmostPosition):
+ (WebCore::RenderTableSection::leftmostPosition):
+ * rendering/RenderTableSection.h:
+ (WebCore::RenderTableSection::virtualChildren):
+ (WebCore::RenderTableSection::children):
+
+2009-02-04 Mads Adger <mad@chromium.org>
+
+ Reviewed by Antti Koivisto.
+
+ Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
+ https://bugs.webkit.org/show_bug.cgi?id=23180
+
+ Added a protector for the document potentially holding on the last reference to the loader we are interating with.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didFinishLoading):
+ (WebCore::Loader::Host::didFail):
+
+2009-02-04 Cary Clark <caryclark@google.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23163
+ Don't scroll to show current focus on devices that use
+ directional pads for navigation.
+
+ * dom/Element.cpp:
+ (WebCore::Element::updateFocusAppearance):
+
+2009-02-04 Cary Clark <caryclark@google.com>
+
+ Reviewed by Darin Adler.
+
+ Change RenderBlock::columnGap() access permissions from protected to
+ public. ANDROID creates an array of focus rectangles for navigation
+ with a trackball or directional pad, and needs access to the column gap
+ to implement this logic.
+
+ Android has no testing harness @ webkit.org, thus no tests.
+
+ * rendering/RenderBlock.h:
+
+2009-02-04 Cary Clark <caryclark@google.com>
+
+ Reviewed by Darin Adler and Eric Seidel.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917
+
+ Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
+ platform to select all when focusing on a textarea. This matches
+ the user interface guidelines other applications on the platform.
+
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::updateFocusAppearance):
+
+2009-02-04 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for <rdar://problem/6386112> Some inline-elements are not
+ becoming proper dashboard-regions
+
+ RenderInline needs its own implementation of addDashboardRegions
+ because otherwise all of the coordinate calculations are
+ inaccurate.
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::addDashboardRegions):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.h:
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Move addChild/removeChild from RenderContainer to RenderObject.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderContainer.cpp:
+ * rendering/RenderContainer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::updateListMarkerNumbers):
+ (WebCore::RenderObject::addChild):
+ (WebCore::RenderObject::removeChild):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::addChildIgnoringContinuation):
+ * rendering/RenderSVGContainer.cpp:
+ * rendering/RenderSVGContainer.h:
+
+2009-02-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Sam Weinig
+
+ <rdar://problem/3541409> - Further HistoryItem / BF cache cleanup
+
+ * history/CachedFrame.cpp:
+ (WebCore::CachedFrame::CachedFrame):
+ (WebCore::CachedFrame::restore):
+ * history/CachedFrame.h:
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::restore):
+ * history/CachedPage.h:
+ (WebCore::CachedPage::mainFrameView):
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ (WebCore::HistoryItem::~HistoryItem):
+ * history/HistoryItem.h:
+ (WebCore::HistoryItem::isInPageCache):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::open):
+
+2009-02-04 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23743
+ Fix memory corruption with open-source GIF decoders.
+
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::clear):
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::clearFrameBufferCache):
+ * platform/image-decoders/skia/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::clearFrameBufferCache):
+ (WebCore::GIFImageDecoder::initFrameBuffer):
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::clear):
+
+2009-02-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23360
+
+ When using accelerated compositing, make repaints use the correct
+ repaint container. Hook up the RenderLayerCompositor in RenderView,
+ and add to RenderView a method that repaints both the view
+ contents, and any intersecting composited layers.
+
+ Make enclosingCompositingLayer() a method on RenderObject, and update
+ the compositor to use that. Add a helper method on the compositor to
+ get the non-self compositing ancestor: ancestorCompositingLayer().
+
+ Call repaintRectangleInViewAndCompositedLayers() in places that don't do
+ container-relative repainting: selection redraw on focus change, caret,
+ and widget updates.
+
+ Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
+ would get cleared for partial updates, thus preventing subsequent full updates.
+
+ Fix a bug in RenderLayer::ensureBacking() that made new backing every time.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::recomputeCaretRect):
+ (WebCore::SelectionController::invalidateCaretRect):
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::compositor):
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::removeChild):
+ (WebCore::RenderLayer::ensureBacking):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::backing):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+ (WebCore::RenderLayerBacking::notifyTransitionStarted):
+ (WebCore::RenderLayerBacking::notifyAnimationStarted):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateCompositingLayers):
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ (WebCore::RenderLayerCompositor::layerWillBeRemoved):
+ (WebCore::RenderLayerCompositor::ancestorCompositingLayer):
+ (WebCore::RenderLayerCompositor::clippedByAncestor):
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::enclosingCompositingLayer):
+ (WebCore::RenderObject::containingBlockWidth):
+ (WebCore::RenderObject::containingBlockHeight):
+ (WebCore::RenderObject::containerForRepaint):
+ (WebCore::RenderObject::repaintUsingContainer):
+ * rendering/RenderObject.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::shouldRepaint):
+ (WebCore::RenderView::repaintViewRectangle):
+ (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
+ (WebCore::RenderView::setMaximalOutlineSize):
+ (WebCore::RenderView::usesCompositing):
+ (WebCore::RenderView::compositor):
+ (WebCore::RenderView::didMoveOnscreen):
+ (WebCore::RenderView::willMoveOffscreen):
+ * rendering/RenderView.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::updateWidgetPosition):
+
+2009-02-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
+ is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
+ is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::attach):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ (WebCore::HTMLImageElement::attach):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::attach):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::attach):
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::attach):
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::setImage):
+ (WebCore::ImageLoader::updateFromElement):
+ (WebCore::ImageLoader::notifyFinished):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::addChildren):
+ * page/DragController.cpp:
+ (WebCore::getCachedImage):
+ (WebCore::getImage):
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::Pasteboard::writeImage):
+ * rendering/RenderImage.h:
+ (WebCore::toRenderImage):
+ * wml/WMLImageElement.cpp:
+ (WebCore::WMLImageElement::parseMappedAttribute):
+ (WebCore::WMLImageElement::attach):
+
+2009-02-04 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel and Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20531
+
+ Make alternateFamilyName customized for Windows and Chromium.
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::alternateFamilyName):
+
+2009-02-04 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ This comes from Chromium patch (http://codereview.chromium.org/17624).
+
+ Add m_disableFontFallback to UniscriberHelper class and set it
+ to true when filling up glyph pages for non-BMP code points.
+ When it's set true, UniscriberHelper does not do its own font
+ fallback. Neither does it do glyph placement. Font fallback
+ will be taken care of in the simple script font path and glyph
+ placement is not necessary for simple scripts.
+
+ Layout test is missing at the moment due to the lack of freely
+ distributable font covering a non-BMP code page. A test page
+ is available at http://i18nl10n.com/webkit/nonbmp2.html
+
+ See also https://bugs.webkit.org/show_bug.cgi?id=23602
+
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+ (WebCore::fillNonBMPGlyphs):
+ * platform/graphics/chromium/UniscribeHelper.cpp:
+ (WebCore::UniscribeHelper::UniscribeHelper):
+ (WebCore::UniscribeHelper::shape):
+ (WebCore::UniscribeHelper::fillShapes):
+ * platform/graphics/chromium/UniscribeHelper.h:
+ (WebCore::UniscribeHelper::setDisableFontFallback):
+
+2009-02-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Remove some unnecessary #includes of RenderStyle.h
+
+ * css/CSSPrimitiveValueMappings.h:
+ * css/SVGCSSComputedStyleDeclaration.cpp:
+ * dom/Node.h:
+ * rendering/PointerEventsHitRules.h:
+ * rendering/RenderImageGeneratedContent.h:
+ * rendering/RenderMarquee.h:
+ * rendering/RenderScrollbar.h:
+
+2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23657
+ Clean up WebCore/storage IDLs.
+
+ * storage/SQLError.idl: Changed to match spec.
+ * storage/SQLResultSet.idl: Changed to match spec.
+ * storage/SQLStatementCallback.idl: Removed.
+ * storage/SQLStatementErrorCallback.idl: Removed.
+ * storage/SQLTransactionCallback.idl: Removed.
+ * storage/SQLTransactionErrorCallback.idl: Removed.
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.
+
+ Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
+ during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
+ paint.
+
+ The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
+ sure to do only a local setNeedsLayout inside that function.
+
+ Reviewed by Beth Dakin
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isSetNeedsLayoutForbidden):
+ (WebCore::RenderObject::setNeedsLayoutIsForbidden):
+ (WebCore::RenderObject::setNeedsLayout):
+ (WebCore::RenderObject::setChildNeedsLayout):
+ (WebCore::RenderObject::markContainingBlocksForLayout):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::layout):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::calcRowHeight):
+ (WebCore::RenderTableSection::layoutRows):
+
+2009-02-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Rename RenderStyle::Diff to StyleDifference and move it to
+ RenderStyleConstants.h.
+
+ * rendering/RenderBR.cpp:
+ (WebCore::RenderBR::styleDidChange):
+ * rendering/RenderBR.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleWillChange):
+ (WebCore::RenderBlock::styleDidChange):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::styleDidChange):
+ * rendering/RenderBox.h:
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::styleWillChange):
+ (WebCore::RenderButton::styleDidChange):
+ * rendering/RenderButton.h:
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::styleDidChange):
+ * rendering/RenderFieldset.h:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::styleDidChange):
+ * rendering/RenderFileUploadControl.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ * rendering/RenderInline.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::styleDidChange):
+ * rendering/RenderListBox.h:
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::styleDidChange):
+ * rendering/RenderListItem.h:
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::styleWillChange):
+ (WebCore::RenderListMarker::styleDidChange):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::styleDidChange):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setStyle):
+ (WebCore::RenderObject::styleWillChange):
+ (WebCore::RenderObject::styleDidChange):
+ * rendering/RenderObject.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::styleDidChange):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGGradientStop.cpp:
+ (WebCore::RenderSVGGradientStop::styleDidChange):
+ * rendering/RenderSVGGradientStop.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::styleDidChange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::styleWillChange):
+ (WebCore::RenderScrollbarPart::styleDidChange):
+ * rendering/RenderScrollbarPart.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::styleDidChange):
+ * rendering/RenderSlider.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::styleDidChange):
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::styleWillChange):
+ (WebCore::RenderTableCell::styleDidChange):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::styleWillChange):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::styleDidChange):
+ * rendering/RenderText.h:
+ (WebCore::RenderText::styleWillChange):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::styleDidChange):
+ * rendering/RenderTextControlSingleLine.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::styleDidChange):
+ * rendering/RenderWidget.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff):
+ (WebCore::RenderStyle::setClip):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/RenderStyleConstants.h:
+ (WebCore::):
+
+2009-02-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::matchRulesForList):
+ (WebCore::CSSStyleSelector::initForStyleResolve):
+ (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::styleForElement):
+ (WebCore::CSSStyleSelector::pseudoStyleForElement):
+ (WebCore::CSSStyleSelector::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/CSSStyleSelector.h:
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
+ (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement):
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
+ (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
+ (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
+ (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
+ (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
+ * rendering/MediaControlElements.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleDidChange):
+ (WebCore::RenderBlock::updateBeforeAfterContent):
+ (WebCore::RenderBlock::firstLineBlock):
+ (WebCore::RenderBlock::updateFirstLetter):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::isAfterContent):
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::updateBeforeAfterContent):
+ * rendering/RenderButton.h:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::createButtonStyle):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::isAfterContent):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::splitInlines):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::updateScrollCornerStyle):
+ (WebCore::RenderLayer::updateResizerStyle):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::createScrollbar):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createPanel):
+ (WebCore::RenderMedia::createTimelineContainer):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::createScrollbar):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::selectionBackgroundColor):
+ (WebCore::RenderObject::selectionForegroundColor):
+ (WebCore::RenderObject::firstLineStyleSlowCase):
+ (WebCore::RenderObject::getCachedPseudoStyle):
+ (WebCore::RenderObject::getUncachedPseudoStyle):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isAnonymousBlock):
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::destroyLeftoverChildren):
+ (WebCore::beforeAfterContainer):
+ (WebCore::RenderObjectChildList::invalidateCounters):
+ (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+ * rendering/RenderObjectChildList.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
+ (WebCore::pseudoForScrollbarPart):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::createThumbStyle):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
+ (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
+ (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
+ (WebCore::RenderTextControlSingleLine::createScrollbar):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::pseudoBit):
+ * rendering/style/RenderStyle.h:
+ (WebCore::):
+ * rendering/style/RenderStyleConstants.h:
+ (WebCore::):
+
+2009-02-04 David Kilzer <ddkilzer@apple.com>
+
+ CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
+
+ <rdar://problem/6509514>
+
+ Reviewed by Mark Rowe.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Fix it correctly this time.
+ Check for the value returned from WebCore::IconDatabase::iconForPageURL(),
+ not WebCore::Image::data().
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.
+
+ Reviewed by Adam Roben
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
+ (WebCore::RenderBox::styleWillChange):
+ * rendering/RenderBox.h:
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::removeChild):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::removeChild):
+
+2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23471
+ Fix text-overflow:ellipsis; for RTL case.
+
+ Test: fast/css/text-overflow-ellipses.html
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement.
+ (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations
+ for rtl truncation.
+
+2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23700
+ Upstream local changes to due to unforking of SimpleFontData
+ (corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).
+
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+ (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ <rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook
+
+ Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
+ because, like, they point to a lot of stuff... like ... everything...
+
+ Reviewed by Darin Adler
+
+ * dom/Document.cpp:
+ (WebCore::Document::removeAllEventListenersFromAllNodes):
+
+2009-02-04 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23731
+ Add JSCCustom and V8Custom as extended IDL attributes
+
+ This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/Document.idl:
+ * dom/Node.idl:
+ * svg/SVGPathSegList.idl:
+ * svg/SVGPointList.idl:
+ * svg/SVGTransformList.idl:
+
+2009-02-04 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * rendering/RenderImageGeneratedContent.h:
+
+2009-02-04 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
+ with assigning to uninitialized HashTable buckets.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23669
+
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::getWxFont):
+ * platform/graphics/wx/FontPlatformData.h:
+ (WebCore::):
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::font):
+ (WebCore::FontPlatformData::operator==):
+ * platform/graphics/wx/FontPlatformDataWx.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::computeHash):
+ (WebCore::FontPlatformData::~FontPlatformData):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
+ (WebCore::drawTextWithSpacing):
+
+2009-02-04 David Hyatt <hyatt@apple.com>
+
+ Fix a crash in generated content when a generated image with an already-cached background image gets
+ created. It's not completely clear how to reproduce this crash.
+
+ Reviewed by Adam Roben
+
+ * rendering/RenderImageGeneratedContent.h:
+ (WebCore::RenderImageGeneratedContent::imagePtr):
+
+2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Unreviewed Qt build fix.
+
+ Changed ASSERT(image) to ASSERT(!image.isNull()).
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::getImageData):
+
+2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix implementation of PluginViewMac::invalidateRect to update only the
+ specified rect, not the entire browser window.
+
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::invalidateRect):
+
+2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber stamped by Mark Rowe.
+
+ FramePrivate was removed in r40024 remove the forward
+ declaration as well.
+
+ * page/Frame.h:
+
+2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23426
+
+ Make isFrameSet virtual and by default return false. Reimplement
+ it in HTMLDocument.
+
+ * dom/Document.cpp:
+ * dom/Document.h:
+ (WebCore::Document::isFrameSet):
+ * html/HTMLDocument.cpp:
+ (WebCore::HTMLDocument::isFrameSet):
+ * html/HTMLDocument.h:
+
+2009-02-03 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by John Sullivan.
+
+ <rdar://problem/6554092> Slow script dialog starts coming up over and over again
+
+ Work around <rdar://problem/6554067> by consuming any exceptions that are
+ thrown by _web_localizedDescription
+
+ * platform/network/mac/ResourceErrorMac.mm:
+ (WebCore::ResourceError::platformLazyInit):
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
+ versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
+ functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
+ availableWidth/Height.
+
+ Reviewed by Mark Rowe
+
+ * dom/Element.cpp:
+ (WebCore::Element::clientWidth):
+ (WebCore::Element::clientHeight):
+ (WebCore::Element::scrollWidth):
+ (WebCore::Element::scrollHeight):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::clientWidth):
+ (WebCore::RenderBox::clientHeight):
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+
+2009-02-03 Brad Garcia <bgarcia@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20443
+ Remove call to canResize when trying to determine if pointer
+ is within a frame.
+ Also removed the implementation of canResize as it is no longer used.
+
+ Test: fast/frames/frame-dead-region.html
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::nodeAtPoint):
+ * rendering/RenderFrameSet.h:
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
+ This is a small gain on the PLT.
+
+ Reviewed by Mark Rowe
+
+ * rendering/bidi.cpp:
+ (WebCore::inlineWidth):
+ (WebCore::bidiNext):
+
+2009-02-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23628
+
+ Fix selection repainting to do container-relative repaints. RenderView now
+ repaints the selection using the containerForRepaint() for each RenderSelectionInfo.
+ selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
+
+ Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
+ of RenderBlock.h and move them into RenderSelectionInfo.h, with some
+ sharing and refactoring.
+
+ RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderBR.h:
+ (WebCore::RenderBR::selectionRectForRepaint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::selectionGapRectsForRepaint):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::selectionRectForRepaint):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ (WebCore::RenderListMarker::selectionRectForRepaint):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::selectionRect):
+ (WebCore::RenderObject::selectionRectForRepaint):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::selectionRectForRepaint):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::absoluteRects):
+ (WebCore::RenderSVGInlineText::absoluteQuads):
+ (WebCore::RenderSVGInlineText::selectionRectForRepaint):
+ (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderSelectionInfo.h: Added.
+ (WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
+ (WebCore::RenderSelectionInfoBase::object):
+ (WebCore::RenderSelectionInfoBase::repaintContainer):
+ (WebCore::RenderSelectionInfoBase::state):
+ (WebCore::RenderSelectionInfo::RenderSelectionInfo):
+ (WebCore::RenderSelectionInfo::repaint):
+ (WebCore::RenderSelectionInfo::rect):
+ (WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
+ (WebCore::RenderBlockSelectionInfo::repaint):
+ (WebCore::RenderBlockSelectionInfo::block):
+ (WebCore::RenderBlockSelectionInfo::rects):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::selectionRectForRepaint):
+ * rendering/RenderText.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::selectionBounds):
+ (WebCore::RenderView::setSelection):
+ * rendering/RenderView.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
+
+ Reviewed by Darin Adler & Sam Weinig
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ * css/CSSMutableStyleDeclaration.h:
+
+2009-02-03 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=13490
+ Implement execCommand("styleWithCSS", ...)
+
+ Determine whether or not to use HTML formatting tags for styling on the new
+ boolean on Editor instead of whether or not the document is quirks mode.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::StyleChange::StyleChange):
+ (WebCore::StyleChange::init):
+ (WebCore::ApplyStyleCommand::applyBlockStyle):
+ (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+ * editing/Editor.cpp:
+ (WebCore::Editor::Editor):
+ (WebCore::Editor::clear):
+ * editing/Editor.h:
+ (WebCore::Editor::setShouldStyleWithCSS):
+ (WebCore::Editor::shouldStyleWithCSS):
+ * editing/EditorCommand.cpp:
+ (WebCore::executeStyleWithCSS):
+ (WebCore::stateStyleWithCSS):
+ (WebCore::CommandEntry::):
+
+2009-02-03 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::getImageData):
+
+2009-02-03 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ - Fix for <rdar://problem/6549743>
+
+ On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
+ after the call to -[NSView displayRectIgnoringOpacity:inContext:].
+
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::paint):
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Back this change out since it is causing layout tests to crash. There is something subtle going on
+ here.
+
+ Reviewed by Darin Adler
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ * css/CSSMutableStyleDeclaration.h:
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
+
+ Reviewed by Sam Weinig
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ * css/CSSMutableStyleDeclaration.h:
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
+ as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
+ Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
+
+ Reviewed by Darin Adler
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+ * platform/KURL.cpp:
+ (WebCore::KURL::invalidate):
+ (WebCore::KURL::KURL):
+ * platform/KURL.h:
+ (WebCore::KURL::isHTTPOrHTTPS):
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::setCachePolicy):
+ (WebCore::ResourceRequestBase::setTimeoutInterval):
+ (WebCore::ResourceRequestBase::setMainDocumentURL):
+ (WebCore::ResourceRequestBase::setHTTPMethod):
+ (WebCore::ResourceRequestBase::setHTTPHeaderField):
+ (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
+ (WebCore::ResourceRequestBase::setHTTPBody):
+ (WebCore::ResourceRequestBase::setAllowHTTPCookies):
+
+2009-02-03 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23711
+
+ Add manual test for floating divs with scrollbars.
+
+ * manual-tests/gtk/floatingdiv.html: Added.
+
+2009-02-03 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23711
+
+ There's no need to hold an extra ref to the scrollbar, calling
+ setPlatformWidget takes ownership of it.
+
+ Also do not disconnect the signals when destroying the widget,
+ it's superfluous.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::ScrollbarGtk):
+ * platform/gtk/ScrollbarGtk.h:
+
+2009-02-03 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23711
+
+ Declare scrollBar as GtkWidget* to avoid needless
+ casting.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::ScrollbarGtk):
+ (ScrollbarGtk::~ScrollbarGtk):
+
+2009-02-03 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23711
+
+ Properly calculate the scrollbar location for their
+ usage in RenderLayout.
+
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::frameRectsChanged):
+
+2009-02-03 David Hyatt <hyatt@apple.com>
+
+ Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
+ of these methods up to RenderObject.
+
+ Reviewed by Beth Dakin
+
+ * bindings/objc/DOM.mm:
+ (-[DOMNode lineBoxRects]):
+ * dom/Range.cpp:
+ (WebCore::Range::addLineBoxRects):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::drawNodeHighlight):
+ * rendering/RenderContainer.cpp:
+ * rendering/RenderContainer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteRectsForRange):
+ (WebCore::RenderObject::absoluteQuadsForRange):
+ * rendering/RenderObject.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::absoluteRectsForRange):
+ (WebCore::RenderText::absoluteQuadsForRange):
+ * rendering/RenderText.h:
+
+2009-02-03 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Sam Weinig and Oliver Hunt.
+
+ Added getImageData() support for QtWebKit.
+
+ [QT] lacks getImageData / putImageData support in Canvas
+ https://bugs.webkit.org/show_bug.cgi?id=22186
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::getImageData):
+
+2009-02-03 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Holger Freyther.
+
+ Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.
+
+ * page/chromium/FrameChromium.cpp:
+ (WebCore::computePageRectsForFrame):
+
+2009-02-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23358
+
+ Hook accelerated compositing into RenderLayer.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::~RenderLayer):
+ Init and clean up backing and the hasCompositingDescendant bit.
+
+ (WebCore::RenderLayer::compositor):
+ Shortcut to get to the RenderLayerCompositor.
+
+ (WebCore::RenderLayer::updateLayerPositions):
+ We need to let full repaints propagate to all compositing layers, and
+ update the backing after layout here.
+
+ (WebCore::RenderLayer::transparentAncestor):
+ (WebCore::transparencyClipBox):
+ (WebCore::RenderLayer::beginTransparencyLayers):
+ Account for the fact that opacity may be rendered via the compositing
+ layer sometimes.
+
+ (WebCore::RenderLayer::addChild):
+ (WebCore::RenderLayer::removeChild):
+ (WebCore::RenderLayer::removeOnlyThisLayer):
+ Tell the compositor when the RenderLayer hierarchy changes.
+
+ (WebCore::RenderLayer::scrollToOffset):
+ Update layer geometry after scrolling.
+
+ (WebCore::RenderLayer::paintLayer):
+ We short-circuit painting on composited layers, because these layers
+ are painted on a callback from the compositing system.
+
+ (WebCore::RenderLayer::hitTestLayer):
+ Only apply transforms if we are rendering them in software.
+
+ (WebCore::RenderLayer::localBoundingBox):
+ (WebCore::RenderLayer::boundingBox):
+ (WebCore::RenderLayer::absoluteBoundingBox):
+ Refactor bounding box code that we can compute local, and ancestor-relative
+ bounding box, as well as absolute.
+
+ (WebCore::RenderLayer::ensureBacking):
+ (WebCore::RenderLayer::clearBacking):
+ RenderLayerBacking creation and destruction.
+
+ (WebCore::RenderLayer::setParent):
+ Tell the compositor when the RenderLayer hierarchy changes.
+
+ (WebCore::RenderLayer::dirtyZOrderLists):
+ (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
+ (WebCore::RenderLayer::dirtyOverflowList):
+ When the z-order and overflow lists change, we need to tell the
+ compositor that the composited layers need to be rejiggered soon.
+
+ (WebCore::RenderLayer::updateZOrderLists):
+ Whitespace cleanup.
+
+ (WebCore::RenderLayer::setBackingNeedsRepaint):
+ (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
+ Dirty composited layer contents for painting.
+
+ (WebCore::RenderLayer::styleChanged):
+ Update the layer backing after style changes.
+
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::isComposited):
+ (WebCore::RenderLayer::backing):
+ Accessors for testing and getting the backing for this RenderLayer.
+
+ (WebCore::RenderLayer::paintsWithTransparency):
+ (WebCore::RenderLayer::paintsWithTransform):
+ Transform and opacity can be applied via the compositing layer, or rendered
+ in software. These methods tell us if we need to account for them in the
+ non-compositing path.
+
+ (WebCore::RenderLayer::hasCompositingDescendant):
+ (WebCore::RenderLayer::setHasCompositingDescendant):
+ Maintain a bit to tell if this layer has composited descendants.
+
+2009-02-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23365
+
+ Hook up accelerated compositing layers the native
+ view system on Mac.
+
+ * WebCore.base.exp:
+ Export new Page methods.
+
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::attachRootGraphicsLayer):
+ (WebCore::ChromeClient::setNeedsOneShotDrawingSynchronization):
+ New methods for attaching/detaching the root GraphicsLayer, and
+ synchronizing layer changes with window drawing.
+
+ * page/FrameView.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateCompositingLayers):
+ (WebCore::FrameView::setNeedsOneShotDrawingSynchronization):
+ (WebCore::FrameView::didMoveOnscreen):
+ (WebCore::FrameView::willMoveOffscreen):
+ New methods to update the compositing layer hierarchy,
+ and pass-throughs to the RenderLayerCompositor.
+
+ (WebCore::FrameView::layout):
+ Update compositing layers after layout() and updateLayerPositions().
+
+ * page/Page.cpp:
+ (WebCore::Page::didMoveOnscreen):
+ (WebCore::Page::willMoveOffscreen):
+ * page/Page.h:
+ New methods to allow the native view system to tell the Page when it
+ starts to be presented on-screen, and when it will be hidden.
+
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateLayerCompositingState):
+ (WebCore::RenderLayerCompositor::didMoveOnscreen):
+ (WebCore::RenderLayerCompositor::willMoveOffscreen):
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
+ Rename 'attached' methods to 'moveOnscreen/moveOffscreen' to match
+ the calls through from Page, FrameView.
+
+ (WebCore::RenderLayerCompositor::layerWillBeRemoved):
+ Dont' try to repaint or update layers if the document is being torn
+ down.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::didMoveOnscreen):
+ (WebCore::RenderView::willMoveOffscreen):
+ * rendering/RenderView.h:
+ New methods.
+
+2009-02-03 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Holger Hans Peter Freyther.
+
+ Fixed getImageData and putImageData and respect pre-
+ multiplied colors.
+
+ Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
+ https://bugs.webkit.org/show_bug.cgi?id=21575
+
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+
+2009-02-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ - fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
+
+ Test: fast/history/window-open.html
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::createWindow): Pass the missing lockBackForwardList parameter
+ to FrameLoader::changeLocation().
+
+2009-02-03 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build after r40536.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue):
+
+2009-02-03 Dan Bernstein <mitz@apple.com>
+
+ - fix -Wmissing-prototypes builds
+
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::workerContextDidSendData): Marked this function static.
+ (WebCore::workerContextDidReceiveResponse): Ditto.
+ (WebCore::workerContextDidReceiveData): Ditto.
+ (WebCore::workerContextDidFinishLoading): Ditto.
+ (WebCore::workerContextDidFail): Ditto.
+ (WebCore::workerContextDidGetCancelled): Ditto.
+ (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
+
+2009-02-03 David Kilzer <ddkilzer@apple.com>
+
+ CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
+
+ <rdar://problem/6509514>
+
+ Reviewed by Adam Roben.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Null check the value returned
+ from WebCore::IconDatabase::iconForPageURL().
+
+2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix conversion of QByteArray to JavaScript and back. Instead of
+ converting it to a String (data loss!) we now map it to JSByteArray.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::):
+ (JSC::Bindings::valueRealType): Added JSByteArray as converstion type.
+ (JSC::Bindings::convertValueToQVariant): Convert from JSByteArray to
+ QVariant(QByteArray).
+ (JSC::Bindings::convertQVariantToValue): Convert from
+ QVariant::ByteArray to jsByteArray.
+
+2009-02-03 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix.
+
+ * GNUmakefile.am: Removed WorkerTask.{h,cpp}.
+
+2009-02-03 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22718
+ Implement WindowTimers interface in Workers.
+
+ This patch moves timeoutID from Document to ScriptExecutionContext
+ and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
+ Also added a test for those methods.
+
+ Test: fast/workers/worker-timeout.html
+
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::setTimeoutOrInterval):
+ Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.
+
+ (WebCore::JSWorkerContext::setTimeout):
+ (WebCore::JSWorkerContext::clearTimeout):
+ (WebCore::JSWorkerContext::setInterval):
+ (WebCore::JSWorkerContext::clearInterval):
+ Added methods exposed to JS.
+
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ScriptExecutionContext::addTimeout):
+ (WebCore::ScriptExecutionContext::removeTimeout):
+ (WebCore::ScriptExecutionContext::findTimeout):
+ * dom/ScriptExecutionContext.h:
+ The timerID map moves from Document to ScriptExecutionContext,
+ to be available to Document and to WorkerContext.
+
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout.
+ (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
+ * dom/WorkerContext.h:
+
+ * page/DOMTimer.cpp:
+ (WebCore::DOMTimer::DOMTimer):
+ (WebCore::DOMTimer::~DOMTimer):
+ (WebCore::DOMTimer::removeById):
+ Code change here reflects move of timeoutID map to the ScriptExecutionContext.
+ Some checks and casts are no longer needed.
+
+2009-02-03 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23560
+ Implement SharedTimer for Workers.
+
+ * dom/WorkerRunLoop.cpp:
+ Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads.
+ (WebCore::WorkerSharedTimer::WorkerSharedTimer):
+ (WebCore::WorkerSharedTimer::setFiredFunction):
+ (WebCore::WorkerSharedTimer::setFireTime):
+ (WebCore::WorkerSharedTimer::stop):
+ (WebCore::WorkerSharedTimer::isActive):
+ (WebCore::WorkerSharedTimer::fireTime):
+ (WebCore::WorkerSharedTimer::fire):
+ (WebCore::WorkerRunLoop::WorkerRunLoop):
+ Initializes a WorkerSharedTimer instance.
+ (WebCore::WorkerRunLoop::~WorkerRunLoop):
+ The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer.
+ (WebCore::WorkerRunLoop::run):
+ Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
+ * dom/WorkerRunLoop.h:
+ Add member of type OwnPtr<WorkerSharedTimer>
+
+2009-02-03 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-02-03 Alexey Proskuryakov <ap@webkit.org>
+
+ Windows build fix.
+
+ * dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where
+ appropriate.
+
+2009-02-02 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
+ <https://bugs.webkit.org/show_bug.cgi?id=23636>
+
+ Enable the async portion of ThreadableLoader for workers.
+
+ No observable change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/CrossThreadCopier.h:
+ * dom/GenericWorkerTask.h:
+ * dom/WorkerThread.cpp:
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ * loader/ThreadableLoaderClient.h:
+ (WebCore::ThreadableLoaderClient::didFinishLoading):
+ * loader/ThreadableLoaderClientWrapper.h: Added.
+ (WebCore::ThreadableLoaderClientWrapper::create):
+ (WebCore::ThreadableLoaderClientWrapper::clearClient):
+ (WebCore::ThreadableLoaderClientWrapper::didSendData):
+ (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
+ (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
+ (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
+ (WebCore::ThreadableLoaderClientWrapper::didFail):
+ (WebCore::ThreadableLoaderClientWrapper::didGetCancelled):
+ (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
+ (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
+ * loader/WorkerThreadableLoader.cpp: Added.
+ (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::~WorkerThreadableLoader):
+ (WebCore::WorkerThreadableLoader::cancel):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::clearClientWrapper):
+ (WebCore::workerContextDidSendData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
+ (WebCore::workerContextDidReceiveResponse):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
+ (WebCore::workerContextDidReceiveData):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
+ (WebCore::workerContextDidFinishLoading):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
+ (WebCore::workerContextDidFail):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
+ (WebCore::workerContextDidGetCancelled):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didGetCancelled):
+ (WebCore::workerContextDidReceiveAuthenticationCancellation):
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
+ * loader/WorkerThreadableLoader.h: Added.
+ (WebCore::WorkerThreadableLoader::create):
+ (WebCore::WorkerThreadableLoader::refThreadableLoader):
+ (WebCore::WorkerThreadableLoader::derefThreadableLoader):
+
+2009-02-02 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
+ <https://bugs.webkit.org/show_bug.cgi?id=23636>
+
+ No observable change in behavior, so no test.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Worker.cpp:
+ * dom/Worker.h:
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::addMessage):
+ (WebCore::WorkerContext::postTask):
+ (WebCore::WorkerContext::postTaskToWorkerObject):
+ * dom/WorkerContext.h:
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerContextTask::performTask):
+ (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
+ (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
+ Expose postTaskToWorkerContext for use by the worker object thread.
+
+ (WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
+ Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
+ with postMessageToWorkerObject.
+
+ * dom/WorkerMessagingProxy.h:
+ * dom/WorkerRunLoop.cpp:
+ (WebCore::WorkerRunLoop::run):
+ (WebCore::WorkerRunLoop::postTask):
+ * dom/WorkerRunLoop.h:
+ * dom/WorkerTask.cpp: Removed.
+ * dom/WorkerTask.h: Removed.
+ Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.
+
+ The resulted in the class going away along with an adapter that made
+ a ScriptExecutionContext::Task look like a WorkerTask.
+
+ * dom/WorkerThread.cpp:
+ * dom/WorkerThread.h:
+
+2009-02-02 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23618: Templated worker tasks should be more error proof to use.
+ <https://bugs.webkit.org/show_bug.cgi?id=23618>
+
+ Add the generic worker tasks templates needed for the WorkerThreadableLoader.
+
+ No observable change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/CrossThreadCopier.cpp: Added.
+ * dom/CrossThreadCopier.h: Added.
+ (WebCore::CrossThreadCopierPassThrough::copy):
+ * dom/GenericWorkerTask.h:
+ Stop doing the WorkerMessagingProxy::askedToTerminate call automatically
+ in performTask because was not obvious that it would be done and not always needed.
+
+ (WebCore::GenericWorkerTask1::create):
+ (WebCore::GenericWorkerTask1::GenericWorkerTask1):
+ (WebCore::GenericWorkerTask1::performTask):
+ (WebCore::GenericWorkerTask2::create):
+ (WebCore::GenericWorkerTask2::GenericWorkerTask2):
+ (WebCore::GenericWorkerTask2::performTask):
+ (WebCore::GenericWorkerTask3::create):
+ (WebCore::GenericWorkerTask3::GenericWorkerTask3):
+ (WebCore::GenericWorkerTask3::performTask):
+ (WebCore::GenericWorkerTask4::create):
+ (WebCore::GenericWorkerTask4::GenericWorkerTask4):
+ (WebCore::GenericWorkerTask4::performTask):
+ (WebCore::GenericWorkerTask5::create):
+ (WebCore::GenericWorkerTask5::GenericWorkerTask5):
+ (WebCore::GenericWorkerTask5::performTask):
+ (WebCore::GenericWorkerTask6::create):
+ (WebCore::GenericWorkerTask6::GenericWorkerTask6):
+ (WebCore::GenericWorkerTask6::performTask):
+ (WebCore::GenericWorkerTask7::create):
+ (WebCore::GenericWorkerTask7::GenericWorkerTask7):
+ (WebCore::GenericWorkerTask7::performTask):
+ (WebCore::createCallbackTask):
+ * dom/WorkerContext.cpp:
+ (WebCore::addMessageTask):
+ (WebCore::WorkerContext::addMessage):
+ * dom/WorkerMessagingProxy.h:
+ (WebCore::WorkerMessagingProxy::askedToTerminate):
+
+2009-02-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David "The Barnabas Jones" Hyatt.
+
+ Move removeChildNode, appendChildNode and insertChildNode from
+ RenderContainer into RenderObjectChildList. Make moveChildNode
+ static in RenderBlock, as that was the only user.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::moveChild):
+ (WebCore::RenderBlock::makeChildrenNonInline):
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::handleRunInChild):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addChild):
+ (WebCore::RenderContainer::removeChild):
+ * rendering/RenderContainer.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::splitFlow):
+ (WebCore::RenderInline::childBecameNonInline):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::handleDynamicFloatPositionChange):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::createsAnonymousWrapper):
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::updateListMarkerNumbers):
+ (WebCore::RenderObjectChildList::removeChildNode):
+ (WebCore::RenderObjectChildList::appendChildNode):
+ (WebCore::RenderObjectChildList::insertChildNode):
+ * rendering/RenderObjectChildList.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::addChild):
+ (WebCore::RenderSVGContainer::removeChild):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::removeChild):
+ * rendering/RenderTable.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::removeChild):
+ * rendering/RenderTableSection.h:
+
+2009-02-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Alder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23697
+ Leaks seen on Worker tests
+
+ * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
+ Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed()
+ is called.
+
+2009-02-02 David Hyatt <hyatt@apple.com>
+
+ Move positionForCoordinates up from RenderContainer into RenderBox.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionForCoordinates):
+ * rendering/RenderBox.h:
+ * rendering/RenderContainer.cpp:
+ * rendering/RenderContainer.h:
+
+2009-02-02 Hiroaki Nakamura <hnakamur@gmail.com>
+
+ Reviewed by Adam Roben.
+
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
+ Modify pre-build step to properly handle the errorlevel
+ shell command.
+
+ * WebCore.vcproj/WebCore.vcproj: Change errorlevel handling
+ for all targets so prefast is only enabled in builds
+ where /analyze is available.
+
+2009-02-02 David Hyatt <hyatt@apple.com>
+
+ Refactor the handling of before/after content and generated content. Move most of the functions from
+ RenderContainer into RenderObjectChildList.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::updateBeforeAfterContent):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::isAfterContent):
+ * rendering/RenderBox.h:
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::updateBeforeAfterContent):
+ * rendering/RenderContainer.cpp:
+ * rendering/RenderContainer.h:
+ * rendering/RenderCounter.cpp:
+ (WebCore::destroyCounterNodeChildren):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::splitInlines):
+ * rendering/RenderObject.h:
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::beforeAfterContainer):
+ (WebCore::findBeforeAfterParent):
+ (WebCore::invalidateCountersInContainer):
+ (WebCore::RenderObjectChildList::invalidateCounters):
+ (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+ * rendering/RenderObjectChildList.h:
+
+2009-02-02 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23661
+ Fix Chromium build.
+
+ * history/HistoryItem.h: need to include <wtf/OwnPtr.h>
+
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
+
+2009-02-02 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::performRequest):
+
+2009-02-02 Geoffrey Garen <ggaren@apple.com>
+
+ Build fix.
+
+ * WebCore.base.exp:
+
+2009-02-02 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Track redirects in global history.
+
+ * WebCore.base.exp: Renamed some exports.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::createWindow):
+ (windowProtoFuncOpen):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::setLocation):
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::submit):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::setProtocol):
+ (WebCore::JSLocation::setHost):
+ (WebCore::JSLocation::setHostname):
+ (WebCore::JSLocation::setPort):
+ (WebCore::JSLocation::setPathname):
+ (WebCore::JSLocation::setSearch):
+ (WebCore::JSLocation::setHash):
+ (WebCore::JSLocation::assign): Treat any navigation that is not initiated
+ by the user as a redirect from the perspective of global history.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
+ chain.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::DocumentLoader):
+ * loader/DocumentLoader.h:
+ (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
+ (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
+ (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
+ added yet another way to track redirect state during loading, since none
+ of the others did what I wanted, and I didn't want to cause behavior
+ changes in existing code.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
+ Stubbed out a client function to keep things building.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::isBackForwardLoadType):
+ (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
+ FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
+ the other meanings of "redirect" in the loading code.
+
+ (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
+ redirect as a redirect from the perspective of global history.
+
+ (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
+ parameter.
+
+ (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
+
+ (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
+ (WebCore::FrameLoader::loadURL):
+ (WebCore::FrameLoader::load): Updated for rename and extra parameter.
+
+ (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
+ in the DocumentLoader, so it's accessible to WebKit's global history code.
+
+ (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
+ only has meaning to global history, and m_quickRedirectComing pertains
+ to other kinds of history.
+
+ (WebCore::FrameLoader::loadPostRequest):
+ (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
+ (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
+ (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
+ (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
+
+ (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
+ navigations even if they don't create new history items, so we can track
+ the redirect in the existing history item.
+
+ * loader/FrameLoader.h: See above.
+
+ * loader/FrameLoaderClient.h: New client interface used by
+ FrameLoader::updateHistory* to record a redirect even if it doesn't create
+ a new history item of its own.
+
+ * loader/FrameLoaderTypes.h: See above.
+ (WebCore::):
+
+ * page/DragController.cpp:
+ (WebCore::DragController::performDrag):
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::dataChanged): Updated for extra parameter.
+
+2009-02-02 David Hyatt <hyatt@apple.com>
+
+ Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
+ Remove RenderSVGContainer's implementation, since it was never called.
+
+ Reviewed by Beth Dakin
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::minPrefWidth):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::calcPrefWidths):
+ * rendering/RenderContainer.h:
+ (WebCore::RenderContainer::moveChildNode):
+ * rendering/RenderSVGContainer.h:
+
+2009-02-02 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.
+
+ * WebCore.LP64.exp:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createScriptObjectForPluginElement):
+ (WebCore::ScriptController::jsObjectForPluginElement):
+ * bindings/js/ScriptController.h:
+
+2009-02-02 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel (and Ojan Vafai).
+
+ https://bugs.webkit.org/show_bug.cgi?id=23696
+ Select element doesn't show new value when focus is switched in
+ onchange event.
+
+ Fix PopupMenuChromium to hide itself before calling valueChanged. This
+ better matches the behavior of the other ports.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::hidePopup):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::acceptIndex):
+ (WebCore::PopupMenu::show):
+ (WebCore::PopupMenu::hide):
+
+2009-02-02 David Hyatt <hyatt@apple.com>
+
+ Make sure scrollWidth/Height just return 0 for inline flows.
+
+ Reviewed by Beth Dakin
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
+ https://bugs.webkit.org/show_bug.cgi?id=23676
+
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::cssPropertyName):
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+ * css/CSSStyleDeclaration.cpp:
+ (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::sortMatchedRules):
+ * dom/Document.cpp:
+ (WebCore::Document::formElementsState):
+ * dom/NamedAttrMap.h:
+ (WebCore::NamedAttrMap::reserveInitialCapacity):
+ * editing/TextIterator.cpp:
+ (WebCore::CharacterIterator::string):
+ (WebCore::SearchBuffer::SearchBuffer):
+ (WebCore::plainTextToMallocAllocatedBuffer):
+ * editing/markup.cpp:
+ (WebCore::joinMarkups):
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::Token::addAttribute):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::items):
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::toString):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (convertToVector):
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::purgeInactiveFontData):
+ (WebCore::FontCache::invalidate):
+ * platform/network/FormData.cpp:
+ (WebCore::FormData::deepCopy):
+ * platform/network/HTTPHeaderMap.cpp:
+ (WebCore::HTTPHeaderMap::copyData):
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::copyData):
+ * platform/network/mac/FormDataStreamMac.mm:
+ (WebCore::formCreate):
+ * xml/XPathNodeSet.cpp:
+ (WebCore::XPath::NodeSet::sort):
+ Use reserveInitialCapacity instead of of reserveCapacity in all these call sites,
+ which are working on new vectors that are guaranteed not to be empty.
+
+2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Build fix after r40486.
+
+ Rubber-stamped by Ada Chan.
+
+ * dom/Document.h: Changed HitTestRequest to a class from a struct.
+ * page/EventHandler.h: Ditto.
+ * rendering/EllipsisBox.h: Ditto.
+ * rendering/InlineBox.h: Ditto.
+ * rendering/InlineFlowBox.h: Ditto.
+ * rendering/RenderLayer.h: Ditto.
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
+ https://bugs.webkit.org/show_bug.cgi?id=23694
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode.
+ (WebCore::ContainerNode::removedFromDocument): Ditto.
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node.
+ (WebCore::EventTargetNode::removedFromDocument): Ditto.
+ * dom/Node.cpp:
+ (WebCore::Node::insertedIntoDocument): Updated comment.
+ (WebCore::Node::removedFromDocument): Ditto.
+
+2009-02-02 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ More plug-in cleanup.
+
+ * WebCore.NPAPI.exp:
+ Add new symbols.
+
+ * bindings/objc/DOM.mm:
+ * bindings/objc/DOMPrivate.h:
+ Remove methods that WebKit doesn't use anymore.
+
+2009-02-02 Jay Campan <jcampan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Clean up PopupMenuChromium a little.
+ https://bugs.webkit.org/show_bug.cgi?id=23653
+
+ No functional changes, only code cleanup, thus no tests.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::):
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupContainer::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::selectNextRow):
+ (WebCore::PopupListBox::selectPreviousRow):
+ (WebCore::PopupMenu::show):
+ * platform/chromium/PopupMenuChromium.h:
+
+2009-02-02 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::createPlugin):
+ (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
+ * loader/FrameLoader.cpp:
+ (WebCore::toPlugInElement):
+ (WebCore::FrameLoader::loadPlugin):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+
+2009-02-02 Genevieve Mak <gen@staikos.net>
+
+ Reviewed by George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23508
+ Returns Blank Page for all "about" protocols
+
+ * loader/MainResourceLoader.cpp:
+ Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
+ url or about:blank only (for now, exclusively for Torch Mobile platform).
+
+2009-02-02 Brent Fulgham <bfulgham@webkit.org>
+
+ Reviewed by George Staikos.
+
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=23691.
+ Correct build break caused by @r40366 by moving the
+ common code implmentations from GraphicsContextCGWin.cpp
+ into the base Windows class (GraphicsContextWin.cpp). Also
+ move inTransparencyLayer since it is identical in both
+ children.
+
+ * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+ Added member m_shouldIncludeChildWindows to Windows version,
+ similar to GraphicsContextPlatformPrivateCG.h.
+ * platform/graphics/win/GraphicsContextCGWin.cpp: Remove the
+ implementations of shouldIncludeChildWindows,
+ setShouldIncludeChildWindows, and inTransparencyLayer.
+ * platform/graphics/win/GraphicsContextCairoWin.cpp: Remove
+ the implementation of inTransparencyLayer.
+ * platform/graphics/win/GraphicsContextWin.cpp: Move common code
+ from GraphicsContextCGWin.cpp and GraphicsContextCairoWin.cpp.
+ (WebCore::GraphicsContext::inTransparencyLayer):
+ (WebCore::GraphicsContext::setShouldIncludeChildWindows):
+ (WebCore::GraphicsContext::shouldIncludeChildWindows):
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Try to fix Wx build, and maybe Chromium build too.
+
+ * WebCore.scons: Added IdentifierRep.cpp.
+ * WebCoreSources.bkl: Ditto.
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Try to fix Wx build.
+
+ * html/HTMLAreaElement.cpp: Added missing include of "Path.h".
+
+2009-02-02 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Nikolas Zimmermann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23587
+ Refactor HitTestRequest to eliminate all the ugly boolean arguments and
+ use an enum bitflag instead. Cleanup all the code that constructs the
+ various HitTestRequests to make the code more readable.
+
+ * dom/Document.cpp:
+ (WebCore::Document::elementFromPoint):
+ (WebCore::Document::prepareMouseEvent):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::contains):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::eventMayStartDrag):
+ (WebCore::EventHandler::updateSelectionForMouseDrag):
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::updateDragAndDrop):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::sendContextMenuEvent):
+ (WebCore::EventHandler::hoverTimerFired):
+ (WebCore::EventHandler::handleDrag):
+ * page/EventHandler.h:
+ * rendering/HitTestRequest.h:
+ (WebCore::HitTestRequest::):
+ (WebCore::HitTestRequest::HitTestRequest):
+ (WebCore::HitTestRequest::readOnly):
+ (WebCore::HitTestRequest::active):
+ (WebCore::HitTestRequest::mouseMove):
+ (WebCore::HitTestRequest::mouseUp):
+ (WebCore::HitTestRequest::ignoreClipping):
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::nodeAtPoint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTest):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::updateHoverActiveState):
+
+2009-02-02 George Staikos <george.staikos@torchmobile.com>
+
+ Reviewed by Niko Zimmermann.
+
+ Fix WML build by including the inlined renderStyle().
+
+ * wml/WMLOptGroupElement.cpp:
+ * wml/WMLOptionElement.cpp:
+
+2009-02-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Niko Zimmermann.
+
+ Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
+ https://bugs.webkit.org/show_bug.cgi?id=23686
+ rdar://problem/6547971
+
+ Also fix other XPath tests that are crashing.
+
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
+ * xml/XPathStep.cpp:
+ (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we
+ need to make Attr nodes here. Yuck!
+
+2009-02-02 Yichao Yin <yichao.yin@torchmobile.com.cn>
+
+ Reviewed by Niko Zimmermann.
+
+ Test: wml/input-format.html
+
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::WMLInputElement):
+ (WebCore::formatCodes):
+ (WebCore::WMLInputElement::dispatchBlurEvent):
+ (WebCore::WMLInputElement::parseMappedAttribute):
+ (WebCore::WMLInputElement::attach):
+ (WebCore::WMLInputElement::defaultEventHandler):
+ (WebCore::WMLInputElement::init):
+ (WebCore::WMLInputElement::validateInputMask):
+ (WebCore::WMLInputElement::isConformedToInputMask):
+ (WebCore::WMLInputElement::cursorPositionToMaskIndex):
+ * wml/WMLInputElement.h:
+
+2009-02-02 Brent Fulgham <bfulgham@webkit.org>
+
+ Build fix only, no review.
+
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=23685.
+ Correct build break caused by @r40473.
+
+ * page/win/FrameWin.cpp: Correct access for adjustPageHeight.
+ (WebCore::computePageRectsForFrame):
+
+2009-02-02 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix WML enabled builds.
+ FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
+
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::defaultEventHandler):
+
+2009-02-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
+
+ Not easily testable.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource
+ handle in a manner that is closer to what CachedResource does. We now make conditional
+ requests for better performance, and set max-age to ensure that stale responses are not used.
+ (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method.
+ (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource
+ is 304, take it from the newest cache.
+ (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL.
+ (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for
+ the manifest if the response code was 304 - it won't be needed.
+ (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that
+ m_manifestResource is not null with a check.
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as
+ an indication that the response was 304.
+ (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
+
+ * loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
+
+2009-02-01 Darin Adler <darin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Bug 23674: Speed up some things based on profiling the page load test
+ https://bugs.webkit.org/show_bug.cgi?id=23674
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead
+ of the old name, getCSSTarget.
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than
+ calling through to EventTargetNode::insertedIntoDocument.
+ (WebCore::ContainerNode::removedFromDocument): Ditto.
+ (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit.
+ (WebCore::ContainerNode::removedFromTree): Ditto.
+
+ * dom/ContainerNode.h: Moved the constructor definition here and made it inline.
+
+ * dom/Document.cpp:
+ (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and
+ its contents only to avoid the document type node. This allows us to remove the virtual
+ function call to isEventTargetNode from the loop.
+ (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
+
+ * dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed
+ getCSSTarget to cssTarget.
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the
+ rare data check into an assertion.
+
+ * dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline.
+ Also moved the constructor definition here and made it inline. And added toEventTargetNode,
+ matching the design of the render tree checked casts. Later we can migrate all callers
+ from EventTargetNodeCast to toEventTargetNode.
+
+ * dom/NamedAttrMap.cpp:
+ (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from
+ clearAttributes, so we could use this loop in cases where we're not clearing the attributes.
+ (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of
+ clearAttributes here.
+ (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here.
+ (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of
+ clearAttributes. We don't need to clear the attributes array just because the element is
+ going away, so don't.
+ (WebCore::NamedAttrMap::virtualLength): Added.
+
+ * dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private.
+ These are all unnecessarily inefficient for use outside the DOM. Changed length to be a
+ non-virtual function. This was a fairly hot function.
+
+ * dom/NamedMappedAttrMap.cpp:
+ (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the
+ m_element data member is private.
+
+ * dom/NamedMappedAttrMap.h: Made a few functions private. Made the
+ hasMappedAttributes function non-virtual.
+
+ * dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual
+ function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
+
+ * dom/Node.cpp:
+ (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's
+ only non-empty in subclasses of ContainerNode.
+ (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS
+ target has to be an Element, this can be moved down to ContainerNode (or it could be
+ moved down to Element for that matter).
+
+ * dom/QualifiedName.cpp:
+ (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
+
+ * dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and
+ setPrefix function definitions into the header and made them inline.
+
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now
+ an OwnPtr.
+ (WebCore::HTMLAreaElement::accessKey): Use AtomicString.
+ (WebCore::HTMLAreaElement::setAccessKey): Ditto.
+ (WebCore::HTMLAreaElement::alt): Ditto.
+ (WebCore::HTMLAreaElement::setAlt): Ditto.
+ (WebCore::HTMLAreaElement::coords): Ditto.
+ (WebCore::HTMLAreaElement::setCoords): Ditto.
+ (WebCore::HTMLAreaElement::setHref): Ditto.
+ (WebCore::HTMLAreaElement::shape): Ditto.
+ (WebCore::HTMLAreaElement::setShape): Ditto.
+ (WebCore::HTMLAreaElement::setTarget): Ditto.
+
+ * html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations.
+ Change the region data member to be an OwnPtr<Path> instead of a Path to optimize
+ the common case where an area element is parsed but never hit-tested. This could
+ also have been done by changing the Path class's null case to be more efficient,
+ but this seems fine.
+
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead
+ of insertAttribute.
+ (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto.
+ (WebCore::HTMLViewSourceDocument::addLine): Ditto.
+ (WebCore::HTMLViewSourceDocument::addLink): Ditto.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead
+ of its old name getCSSTarget.
+
+ * platform/graphics/GlyphWidthMap.cpp:
+ (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
+
+ * platform/graphics/GlyphWidthMap.h: Made most of this class inline.
+ Changed m_pages to use OwnPtr.
+
+ * platform/text/PlatformString.h: Remove include no longer needed since
+ StringImpl.h includes it.
+
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored
+ from createStrippingNullCharacters.
+ * platform/text/StringImpl.h: Moved the definition of
+ createStrippingNullCharacters here and made it inline.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from
+ firstLineStyle.
+
+ * rendering/RenderObject.h: Moved the definition of the firstLineStyle
+ function here and made it inline. Moved the definition of the
+ documentBeingDestroyed function here and made it inline.
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of
+ getNamedItem here since it accomplishes the same thing but is more efficient.
+ (WebCore::SVGSVGElement::getScreenCTM): Ditto.
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
+
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of
+ getNamedItemNS.
+
+ * xml/XPathStep.cpp:
+ (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
+
+2009-02-02 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
+
+ https://bugs.webkit.org/show_bug.cgi?id=23428
+
+ FrameView::forceLayout could be killed but the comment might
+ contain a value over the the plain FrameView::layout...
+
+ Adjust the WebCore/WebKit consumers of these methods.
+
+ * WebCore.base.exp:
+ * page/Frame.cpp:
+ (WebCore::Frame::setPrinting):
+ * page/Frame.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::forceLayout):
+ (WebCore::FrameView::forceLayoutWithPageWidthRange):
+ (WebCore::FrameView::adjustPageHeight):
+ * page/FrameView.h:
+ * page/PrintContext.cpp:
+ (WebCore::PrintContext::computePageRects):
+
+2009-02-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
+
+ Fixes http/tests/navigation/multiple-back-forward-entries.html
+
+ r40432 added a parameter to FrameLoader::scheduleLocationChange() and
+ failed to update all call sites.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::createWindow): Pass the lockBackForwardHistory parameter,
+ giving it the same value as the lockHistory parameter.
+ (windowProtoFuncOpen): Ditto.
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation): Ditto.
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::setLocation): Ditto.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::requestFrame): Ditto.
+
+2009-01-31 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
+
+ On the PLT, this results in 0.36x the number of virtual function calls
+ to RenderText::width() and 0.69x the number of calls to
+ Font::isFixedPitch(), but makes 1.0004x the number of calls to
+ Font::width().
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len'
+ with an assertion.
+ * rendering/bidi.cpp:
+ (WebCore::textWidth): Added this inlined helper function which calls
+ Font::width() directly in the non-fixed-pitch, non-full-range case, and
+ otherwise calls RenderText::width().
+ (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has
+ fixed pitch (in which case RenderText::width() will be called in order
+ to take advantage of the widthFromCache() optimization for fixed-pitch
+ fonts). Replaced all calls to RenderText::width() with calls to the
+ textWidth() helper function.
+
+2009-01-31 David Hyatt <hyatt@apple.com>
+
+ Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
+ and setNeedsPositionedMovementLayout.
+
+ Reviewed by Dan Bernstein
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setLayerNeedsFullRepaint):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::setNeedsLayout):
+ (WebCore::RenderObject::setChildNeedsLayout):
+ (WebCore::RenderObject::setNeedsPositionedMovementLayout):
+ (WebCore::objectIsRelayoutBoundary):
+ (WebCore::RenderObject::markContainingBlocksForLayout):
+
+2009-01-31 Darin Adler <darin@apple.com>
+
+ Fix Mac build.
+
+ * loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here.
+ We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely
+ deleted and I don't want to bring it back just to fix the build.
+
+ * loader/FrameLoaderClient.h: Rearrange virtual functions and corrected
+ a possibly-confusing comment.
+
+2009-01-31 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23664
+ Remove unused dead code from RenderTable class. The dead code includes
+ two enums and the associated member variables as well as one getter function.
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::RenderTable):
+ * rendering/RenderTable.h:
+
+2009-01-31 David Hyatt <hyatt@apple.com>
+
+ More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
+ Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
+ RenderObjectChildList.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::destroy):
+ (WebCore::RenderBlock::addChild):
+ (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
+ (WebCore::RenderBlock::layoutPositionedObjects):
+ (WebCore::RenderBlock::childBecameNonInline):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::layout):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::firstChildBox):
+ (WebCore::RenderBox::lastChildBox):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addChild):
+ (WebCore::RenderContainer::removeChildNode):
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ (WebCore::RenderContainer::appendChildNode):
+ (WebCore::RenderContainer::insertChildNode):
+ (WebCore::RenderContainer::positionForCoordinates):
+ (WebCore::RenderContainer::addLineBoxRects):
+ (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
+ * rendering/RenderContainer.h:
+ (WebCore::RenderContainer::virtualChildren):
+ (WebCore::RenderContainer::children):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::destroy):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::layout):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::destroy):
+ (WebCore::RenderMedia::children):
+ * rendering/RenderMedia.h:
+ (WebCore::RenderMedia::virtualChildren):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::destroy):
+ (WebCore::RenderObject::layout):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::firstChild):
+ (WebCore::RenderObject::lastChild):
+ (WebCore::RenderObject::virtualChildren):
+ (WebCore::RenderObject::canHaveChildren):
+ * rendering/RenderObjectChildList.cpp: Added.
+ (WebCore::RenderObjectChildList::destroyLeftoverChildren):
+ * rendering/RenderObjectChildList.h:
+ * rendering/RenderReplaced.h:
+ (WebCore::RenderReplaced::canHaveChildren):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::RenderSVGContainer):
+ (WebCore::RenderSVGContainer::destroy):
+ (WebCore::RenderSVGContainer::removeChildNode):
+ (WebCore::RenderSVGContainer::appendChildNode):
+ (WebCore::RenderSVGContainer::insertChildNode):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::virtualChildren):
+ (WebCore::RenderSVGContainer::children):
+
+2009-01-31 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=11363
+
+ Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
+ With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
+ layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
+ be properly ignored.
+
+ Reviewed by Oliver Hunt
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::createDeletionUI):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ (WebCore::RenderTable::layout):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layout):
+ * rendering/RenderTableSection.h:
+
+2009-01-31 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23663
+ Add a void toRenderBox() method which catches unnecessary casts at compile
+ time and also fix the four cases where this was happening.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::determineHorizontalPosition):
+ * rendering/RenderBox.h:
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::updateHitTestResult):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+
+2009-01-30 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Add a pref to disable web security.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::initSecurityContext):
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::SecurityOrigin):
+ (WebCore::SecurityOrigin::canAccess):
+ (WebCore::SecurityOrigin::canRequest):
+ (WebCore::SecurityOrigin::grantUniversalAccess):
+ * page/SecurityOrigin.h:
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setWebSecurityEnabled):
+ * page/Settings.h:
+ (WebCore::Settings::isWebSecurityEnabled):
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ Move the inline virtual destructor after a non-inline virtual
+ function so that the symbol for the vtable is not marked as a
+ weakly exported symbol.
+
+ This trick was previously used at revision 36122 in JSObject.h
+
+ * loader/FrameLoaderClient.h:
+ (WebCore::FrameLoaderClient::~FrameLoaderClient):
+
+2009-01-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Stephanie Lewis
+
+ Inline SimpleFontData::widthForGlyph for a minor page load improvement.
+
+ * platform/graphics/SimpleFontData.cpp:
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::widthForGlyph):
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix for WX and maybe even Windows.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler
+
+ Carry out the move and catch up in two call sites.
+
+ * WebCore.base.exp:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::sendResizeEvent):
+ (WebCore::EventHandler::sendScrollEvent):
+ * page/EventHandler.h:
+ * page/Frame.cpp:
+ * page/Frame.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::performPostLayoutTasks):
+ (WebCore::FrameView::valueChanged):
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ Move Frame::isFrameSet to Document::isFrameSet
+
+ Changed the FrameLoader callsite. I assume that as this
+ point m_frame.document() might return a null pointer. Change
+ the condition to either not having a document or not having a
+ frame set. This should be semantically equivalent to the
+ old code.
+
+ Make Document::body() const to be able to call it from within
+ Document::isFrameSet. Leave the isHTMLDocument() check as this
+ is a stronger condition than simply having a HTMLElement in the
+ DOM.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::isFrameSet):
+ (WebCore::Document::body):
+ * dom/Document.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::shouldScrollToAnchor):
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::createFromSelection):
+ * page/Frame.cpp:
+ * page/Frame.h:
+
+2009-01-30 Aurelian Maga <aurelianmaga@yahoo.com>
+
+ Reviewed by Holger Freyther.
+
+ [GTK] Logic fixes and build fixes
+
+ https://bugs.webkit.org/show_bug.cgi?id=22022
+
+ Catch up with the internal GeoLocation API and fix the logic of
+ the previous version.
+
+ * platform/gtk/GeolocationServiceGtk.cpp:
+ (WebCore::GeolocationServiceGtk::startUpdating):
+ (WebCore::GeolocationServiceGtk::updateLocationInformation):
+ (WebCore::GeolocationServiceGtk::position_changed):
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ [GTK] Implement GeolocationService using the Geoclue library
+
+ https://bugs.webkit.org/show_bug.cgi?id=22022
+
+ Untested implementation of the GeolocationService using the geoclue
+ library. Velocity handling is completely missing and the accuracy
+ handling might be wrong.
+
+ * platform/gtk/GeolocationServiceGtk.cpp:
+ (WTF::GeoclueAccuracy):
+ (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
+ (WebCore::GeolocationServiceGtk::~GeolocationServiceGtk):
+ (WebCore::GeolocationServiceGtk::startUpdating):
+ (WebCore::GeolocationServiceGtk::stopUpdating):
+ (WebCore::GeolocationServiceGtk::suspend):
+ (WebCore::GeolocationServiceGtk::resume):
+ (WebCore::GeolocationServiceGtk::lastPosition):
+ (WebCore::GeolocationServiceGtk::lastError):
+ (WebCore::GeolocationServiceGtk::updateLocationInformation):
+ (WebCore::GeolocationServiceGtk::updatePosition):
+ (WebCore::GeolocationServiceGtk::position_changed):
+ (WebCore::GeolocationServiceGtk::setError):
+ * platform/gtk/GeolocationServiceGtk.h:
+
+2009-01-30 Mark Rowe <mrowe@apple.com>
+
+ Build fix. Declare preferredSize as static.
+
+ * platform/text/cf/StringImplCF.cpp:
+ (WebCore::StringWrapperCFAllocator::preferredSize):
+
+2009-01-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
+ https://bugs.webkit.org/show_bug.cgi?id=23622
+
+ * platform/text/cf/StringImplCF.cpp:
+ (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator.
+ (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator.
+ (WebCore::StringWrapperCFAllocator::release): Ditto.
+ (WebCore::StringWrapperCFAllocator::copyDescription): Ditto.
+ (WebCore::StringWrapperCFAllocator::allocate): Ditto.
+ (WebCore::StringWrapperCFAllocator::reallocate): Ditto.
+ (WebCore::StringWrapperCFAllocator::deallocate): Ditto.
+ (WebCore::StringWrapperCFAllocator::preferredSize): Ditto.
+ (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but
+ returns 0 if garbage collection is enabled.
+ (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
+
+ * platform/text/mac/StringImplMac.mm:
+ (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging,
+ rather than using NSString directly. This lets NSString benefit from the above.
+
+2009-01-30 Darin Adler <darin@apple.com>
+
+ * page/Frame.cpp:
+ (WebCore::Frame::createView): Fix debug build by removing get() from assert.
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22056
+
+ Kill FrameLoaderClient.cpp, move the code over to Frame::createView
+
+ FrameLoaderClient is supposed to be an interface, move the
+ to be shared code to Frame which is a controller and is
+ allowed to create a FrameView.
+
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/FrameLoaderClient.cpp: Removed.
+ * loader/FrameLoaderClient.h:
+ (WebCore::FrameLoaderClient::~FrameLoaderClient):
+ * page/Frame.cpp:
+ (WebCore::Frame::createView):
+ * page/Frame.h:
+
+2009-01-30 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23357
+
+ New files to support accelerated compositing at the RenderLayer
+ level.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ New files added to project, and run through the sort script.
+
+ * rendering/RenderLayerBacking.cpp: Added.
+ * rendering/RenderLayerBacking.h: Added.
+ New object to store compositing-related data for a single
+ RenderLayer.
+
+ * rendering/RenderLayerCompositor.cpp: Added.
+ * rendering/RenderLayerCompositor.h: Added.
+ Per-RenderView controller object for compositing hierarchy
+ maintenance.
+
+2009-01-30 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23356
+
+ Add new files related to accelerated compositing:
+
+ * WebCore.xcodeproj/project.pbxproj:
+ Add the files to the project. Also add ColorCG.cpp, for the
+ Color(CGColorRef) constructor.
+
+ * platform/graphics/GraphicsLayer.cpp: Added.
+ * platform/graphics/GraphicsLayer.h: Added.
+ GraphicsLayer is a platform abstraction for a hardware-backed
+ layer.
+
+ * platform/graphics/GraphicsLayerClient.h: Added.
+ Client of GraphicsLayer, allowing GraphicsLayer to call out
+ to WebCore code.
+
+ * platform/graphics/mac/GraphicsLayerCA.h: Added.
+ * platform/graphics/mac/GraphicsLayerCA.mm: Added.
+ Mac Core Animation implementation of GraphicsLayer.
+
+ * platform/graphics/mac/WebLayer.h: Added.
+ * platform/graphics/mac/WebLayer.mm: Added.
+ * platform/graphics/mac/WebTiledLayer.h: Added.
+ * platform/graphics/mac/WebTiledLayer.mm: Added.
+ Subclasses of CALayer and CATiledLayer -- helpers for the
+ GraphicsLayerCA implementation.
+
+2009-01-30 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
+ preparation for setting them differently during a redirect.
+
+ * WebCore.base.exp:
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::submit):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::navigateIfAllowed):
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::setProtocol):
+ (WebCore::JSLocation::setHost):
+ (WebCore::JSLocation::setHostname):
+ (WebCore::JSLocation::setPort):
+ (WebCore::JSLocation::setPathname):
+ (WebCore::JSLocation::setSearch):
+ (WebCore::JSLocation::setHash):
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::assign):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::submit):
+ * html/HTMLFormElement.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FormSubmission::FormSubmission):
+ (WebCore::ScheduledRedirection::ScheduledRedirection):
+ (WebCore::isBackForwardLoadType):
+ (WebCore::FrameLoader::createWindow):
+ (WebCore::FrameLoader::changeLocation):
+ (WebCore::FrameLoader::urlSelected):
+ (WebCore::FrameLoader::submitFormAgain):
+ (WebCore::FrameLoader::submitForm):
+ (WebCore::FrameLoader::restoreDocumentState):
+ (WebCore::FrameLoader::scheduleHTTPRedirection):
+ (WebCore::FrameLoader::scheduleLocationChange):
+ (WebCore::FrameLoader::scheduleRefresh):
+ (WebCore::FrameLoader::redirectionTimerFired):
+ (WebCore::FrameLoader::loadURLIntoChildFrame):
+ (WebCore::FrameLoader::startRedirectionTimer):
+ (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
+ (WebCore::FrameLoader::transitionToCommitted):
+ (WebCore::FrameLoader::clientRedirected):
+ (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderTypes.h:
+ (WebCore::):
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected):
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+
+2009-01-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6545095>
+ ASSERTION FAILED: RenderBlock.h:519: !o || o->isRenderBlock()
+
+ Test: fast/block/float/crash-replaced-display-block.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into
+ isRenderBlock if-statement.
+
+2009-01-30 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23656: AX hierarchy for iFrames is incorrect
+ https://bugs.webkit.org/show_bug.cgi?id=23656
+
+ The AX hierarchy when an iFrame was present was incorrect. A different scroll area was
+ returned when going down compared to when going up.
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (convertToNSArray):
+
+2009-01-30 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix Qt build to include new class IdentifierRep introduced in revision 40412.
+
+ * WebCore.pro:
+
+2009-01-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.
+
+ * WebCore.LP64.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-01-30 Sam Weinig <sam@webkit.org>
+
+ Commit files I forgot to in the previous commit.
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::layoutCount):
+ * page/Frame.cpp:
+ (WebCore::Frame::contentRenderer):
+ (WebCore::Frame::forceLayoutWithPageWidthRange):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::nodeAtPoint):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintUsingContainer):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::view):
+ (WebCore::RenderObject::scheduleRelayout):
+ (WebCore::RenderObject::maximalOutlineSize):
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::clampImageBufferSizeToViewport):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+
+2009-01-30 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ More scaffolding for redirect tracking. No behavior change yet.
+
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for
+ redirect checking in a form submission through JS. (Currently, we
+ just specify "no redirect.")
+
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::processingUserGesture):
+ (WebCore::ScriptController::processingUserGestureEvent):
+ (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored
+ user gesture check to make it more clear.
+
+ (WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
+ for checking if there's a user gesture in any frame on the page (a more
+ relaxed rule than our popup blocking rule, which requires the user
+ gesture to occur in the frame that's executing JavaScript.)
+
+ * html/HTMLFormElement.h:
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::submit): Added scaffolding necessary for
+ redirect checking in a form submission through the DOM. (Currently, we
+ just specify "no redirect.")
+
+ * html/HTMLFormElement.idl: Made submit custom so it can participate
+ in redirect checking.
+
+ * loader/FrameLoader.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FormSubmission::FormSubmission): Clarified some names, and
+ added a "lockHistory" parameter to form submissions, to match other
+ navigations.
+
+ (WebCore::FrameLoader::submitFormAgain):
+ (WebCore::FrameLoader::submitForm): Use the lockHistory parameter.
+
+ (WebCore::FrameLoader::userGestureHint): Refactored this function for
+ clarity, and added a FIXME for a change I was too scared to make myself.
+ (Really, we should just get rid of this function.)
+
+ (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
+ to pass a FrameLoadType to form posts, too, so they can participate in
+ redirect tracking.
+
+ (WebCore::FrameLoader::loadPostRequest):
+ (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
+ (WebCore::FrameLoader::loadItem): Use the lockHistory parameter.
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Mark Rowe.
+
+ [Gtk+] Use AccessibilityObject::stringValue for the AtkObject name
+
+ https://bugs.webkit.org/show_bug.cgi?id=21546
+
+ The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
+ states that: "AtkObjects whose text content is simple, unattributed, and very
+ brief may expose that content via atk_object_get_name instead"
+
+ As we are currently not able to always provide a AtkTextInterface
+ implementation this will make the whole content available to accerciser,
+ and other tools.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
+2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix.
+
+ Include string.h for strdup.
+
+ * bridge/IdentifierRep.h:
+
+2009-01-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
+ is not a RenderView.
+
+ * dom/Document.cpp:
+ (WebCore::Document::renderView):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::nodeWillBeRemoved):
+ (WebCore::SelectionController::recomputeCaretRect):
+ (WebCore::SelectionController::invalidateCaretRect):
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+ (WebCore::RenderBox::availableHeightUsing):
+ * rendering/RenderView.h:
+ (WebCore::toRenderView):
+
+2009-01-30 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23360
+
+ Really use the container-relative repaint rect methods
+ for repaint during layout
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
+
+2009-01-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Get rid of PrivateIdentifier and use IdentifierRep instead.
+
+ * bridge/NP_jsobject.cpp:
+ (_NPN_Invoke):
+ (_NPN_GetProperty):
+ (_NPN_SetProperty):
+ (_NPN_RemoveProperty):
+ (_NPN_HasProperty):
+ (_NPN_HasMethod):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::getPropertyNames):
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertNPStringToUTF16):
+ * bridge/c/c_utility.h:
+ * bridge/npruntime.cpp:
+ (_NPN_GetStringIdentifier):
+ (_NPN_GetStringIdentifiers):
+ (_NPN_GetIntIdentifier):
+ (_NPN_IdentifierIsString):
+ (_NPN_UTF8FromIdentifier):
+ (_NPN_IntFromIdentifier):
+
+2009-01-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig and Darin Adler.
+
+ Make IdentifierRep a real class, add necessary class methods.
+
+ * bridge/IdentifierRep.cpp:
+ (WebCore::identifierSet):
+ Returns a set of all identifiers.
+
+ (WebCore::IdentifierRep::isValid):
+ Return whether an identifier is valid, meaning that it's present in the
+ set of identifiers.
+
+ * bridge/IdentifierRep.h:
+ (WebCore::IdentifierRep::isString):
+ (WebCore::IdentifierRep::number):
+ (WebCore::IdentifierRep::string):
+ (WebCore::IdentifierRep::IdentifierRep):
+ (WebCore::IdentifierRep::):
+
+2009-01-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add IdentifierRep which will be used by both plug-in implementations.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bridge/IdentifierRep.cpp: Added.
+ (WebCore::IdentifierRep::IdentifierRep):
+ (WebCore::IdentifierRep::):
+ (WebCore::intIdentifierMap):
+ (WebCore::identifierRep):
+ (WebCore::stringIdentifierMap):
+ * bridge/IdentifierRep.h: Added.
+ * bridge/c/c_utility.h:
+ * platform/text/PlatformString.h:
+ * platform/text/String.cpp:
+ (WebCore::String::fromUTF8WithLatin1Fallback):
+
+2009-01-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
+ is not a RenderInline.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
+ (WebCore::InlineFlowBox::rendererLineBoxes):
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ (WebCore::InlineFlowBox::paint):
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::addFocusRingRects):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeRectForRepaint):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::inlineContinuation):
+ (WebCore::nextContinuation):
+ (WebCore::RenderInline::splitInlines):
+ * rendering/RenderInline.h:
+ (WebCore::toRenderInline):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::boundingBox):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+ * rendering/RenderText.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::createLineBoxes):
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-01-30 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23647
+ Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports
+
+ * platform/graphics/skia/ImageSourceSkia.cpp:
+ (WebCore::ImageSource::clear):
+
+2009-01-30 David Hyatt <hyatt@apple.com>
+
+ Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
+ is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
+ is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.
+
+ Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
+ patch with a containsFloats() check.
+
+ Reviewed by Darin Adler
+
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::isCandidate):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
+ * editing/Editor.cpp:
+ (WebCore::Editor::hasBidiSelection):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleWillChange):
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::fillBlockSelectionGaps):
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+ (WebCore::RenderBlock::firstLineBlock):
+ (WebCore::getLineAtIndex):
+ (WebCore::getHeightForLineCount):
+ (WebCore::RenderBlock::lineCount):
+ (WebCore::RenderBlock::adjustForBorderFit):
+ (WebCore::RenderBlock::clearTruncation):
+ * rendering/RenderBlock.h:
+ (WebCore::toRenderBlock):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeRectForRepaint):
+ (WebCore::RenderBox::calcReplacedHeightUsing):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::inlineContinuation):
+ (WebCore::nextContinuation):
+ (WebCore::RenderInline::positionForCoordinates):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+ * rendering/RenderListItem.cpp:
+ (WebCore::getParentOfFirstLineBox):
+ (WebCore::RenderListItem::positionListMarker):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::containingBlock):
+ (WebCore::RenderObject::computeRectForRepaint):
+ (WebCore::RenderObject::removeFromObjectLists):
+ (WebCore::RenderObject::getTextDecorationColors):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ (WebCore::RenderTable::recalcSections):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::block):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::createLineBoxes):
+
+2009-01-30 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Sam Weinig
+
+ - Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of
+ relying on some outside force.
+ - Clear the previous history item inside FrameLoader instead of relying on multiple
+ FrameLoaderClients to do it.
+
+ * history/CachedFrame.cpp:
+ (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here.
+ (WebCore::CachedFrame::restore): Resume those DOM objects here.
+ * history/CachedFrame.h:
+ (WebCore::CachedFrame::domWindow):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the
+ suspending of active DOM objects.
+ (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects.
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead
+ of performing a client call by itself.
+ (WebCore::FrameLoader::frameLoadCompleted):
+
+2009-01-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6448823> Application Cache is kept after a private browsing session
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::selectCache):
+ (WebCore::ApplicationCacheGroup::update):
+ Cache update will not be started if private browsing is enabled. Existing cache version
+ from disk database will be used.
+
+ * loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call
+ it when refusing to update from selectCache().
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::addDynamicEntry):
+ (WebCore::ApplicationCache::removeDynamicEntry):
+ Added reminders about private browsing to unimplemented methods.
+
+2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Bug 23580: GNU mode RVCT compilation support
+ <https://bugs.webkit.org/show_bug.cgi?id=23580>
+
+ * html/PreloadScanner.cpp: Use COMPILER(GCC) instead of __GNUC__.
+
+2009-01-30 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
+ <https://bugs.webkit.org/show_bug.cgi?id=23616>
+
+ Added forwarding header.
+
+ * ForwardingHeaders/wtf/TypeTraits.h: Added.
+
+2009-01-30 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23599: ResourceError needs to be copyable for use in another thread.
+ <https://bugs.webkit.org/show_bug.cgi?id=23599>
+
+ Add ResourceErrorBase::copy method. (Not yet used.)
+
+ * platform/network/ResourceErrorBase.cpp:
+ (WebCore::ResourceErrorBase::copy):
+ * platform/network/ResourceErrorBase.h:
+
+2009-01-29 Stephanie Lewis <slewis@apple.com>
+
+ RS by Oliver Hunt.
+
+ Update the order files.
+
+ * WebCore.order:
+
+2009-01-29 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23488
+
+ Make TimerBase thread-aware (for Workers).
+ Added new class ThreadTimers - it keeps a heap of all timers for a thread (previously kept in a static global).
+ Pointer to instance of ThreadTimers is stored in GlobalThreadData.
+ Most static methods of TimerBase went to ThreadTimers.
+
+ The TimerBase functionality did not change (it maintains the timer heap which computes the nearest firing).
+
+ Added new abstract class SharedTimer, so worker threads can provide their own implementation (will be implemented on WorkerRunLoop).
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Added new ThreadTimers.cpp to build files.
+
+ * platform/SharedTimer.h:
+ (WebCore::SharedTimer::~SharedTimer):
+ (WebCore::MainThreadSharedTimer::setFiredFunction):
+ (WebCore::MainThreadSharedTimer::setFireTime):
+ (WebCore::MainThreadSharedTimer::stop):
+ Added abstract SharedTimer and MainThreadSharedTimer which redirects to the existing port-supplied functions.
+
+ * platform/ThreadGlobalData.cpp:
+ (WebCore::ThreadGlobalData::ThreadGlobalData):
+ (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ * platform/ThreadGlobalData.h:
+ (WebCore::ThreadGlobalData::threadTimers):
+ Added ThreadTimers to ThreadGlobalData.
+
+ * platform/ThreadTimers.cpp: Added.
+ (WebCore::mainThreadSharedTimer):
+ Static getter for a MainThreadSharedTimer singleton.
+
+ (WebCore::ThreadTimers::ThreadTimers):
+ (WebCore::ThreadTimers::setSharedTimer):
+ (WebCore::ThreadTimers::updateSharedTimer):
+ (WebCore::ThreadTimers::collectFiringTimers):
+ (WebCore::ThreadTimers::fireTimers):
+ (WebCore::ThreadTimers::sharedTimerFired):
+ (WebCore::ThreadTimers::sharedTimerFiredInternal):
+ (WebCore::ThreadTimers::fireTimersInNestedEventLoop):
+ ThreadTimers implementation. Most of the code is moved from previous static functions on TimerBase.
+ Need a new class so each thread may get ts own copy of the timer heap.
+
+ * platform/ThreadTimers.h: Added.
+ (WebCore::ThreadTimers::timerHeap):
+ (WebCore::ThreadTimers::timersReadyToFire):
+
+ * platform/Timer.cpp:
+ (WebCore::timerHeap):
+ (WebCore::timersReadyToFire):
+ (WebCore::TimerHeapElement::TimerHeapElement):
+ (WebCore::TimerHeapElement::checkConsistency):
+ (WebCore::TimerHeapElement::operator=):
+ (WebCore::TimerHeapIterator::checkConsistency):
+ (WebCore::TimerBase::TimerBase):
+ (WebCore::TimerBase::~TimerBase):
+ (WebCore::TimerBase::isActive):
+ (WebCore::TimerBase::checkHeapIndex):
+ (WebCore::TimerBase::heapDelete):
+ (WebCore::TimerBase::heapDeleteMin):
+ (WebCore::TimerBase::heapInsert):
+ (WebCore::TimerBase::heapPopMin):
+ (WebCore::TimerBase::setNextFireTime):
+ (WebCore::TimerBase::fireTimersInNestedEventLoop):
+ Now instead of static timer heap these use accessor functions that pull thread-specific heap instance.
+
+ * platform/Timer.h:
+ static methods moved to ThreadTimers.
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Beginning of work to eliminate RenderContainer and make containership "pluggable" into any spot in the render tree. The first step is to create
+ the new object that will handle children: RenderObjectChildList and move RenderContainer's member variables into it. Subsequent patches will begin
+ moving RenderContainer's functionality into RenderObjectChildList.
+
+ Reviewed by Eric Seidel
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::RenderContainer):
+ (WebCore::RenderContainer::destroyLeftoverChildren):
+ (WebCore::RenderContainer::addChild):
+ (WebCore::RenderContainer::removeChildNode):
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ (WebCore::RenderContainer::appendChildNode):
+ (WebCore::RenderContainer::insertChildNode):
+ (WebCore::RenderContainer::layout):
+ (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
+ (WebCore::RenderContainer::positionForCoordinates):
+ (WebCore::RenderContainer::addLineBoxRects):
+ (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
+ * rendering/RenderContainer.h:
+ (WebCore::RenderContainer::firstChild):
+ (WebCore::RenderContainer::lastChild):
+ (WebCore::RenderContainer::firstChildBox):
+ (WebCore::RenderContainer::lastChildBox):
+ * rendering/RenderObjectChildList.h: Added.
+ (WebCore::RenderObjectChildList::RenderObjectChildList):
+ (WebCore::RenderObjectChildList::firstChild):
+ (WebCore::RenderObjectChildList::lastChild):
+ (WebCore::RenderObjectChildList::setFirstChild):
+ (WebCore::RenderObjectChildList::setLastChild):
+
+2009-01-29 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ http://bugs.webkit.org/show_bug.cgi?id=23598
+ Replace smart-quotes in UTF-8 with ASCII double-quotes to avoid
+ the compilation error on CJK Windows
+
+ * wml/WMLTableElement.cpp:
+ (WebCore::WMLTableElement::parseMappedAttribute):
+
+2009-01-29 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23627
+ Fix the PLATFORM(SKIA) build.
+
+ * svg/graphics/SVGPaintServer.cpp:
+ (WebCore::SVGPaintServer::teardown):
+
+2009-01-29 Scott Violet <sky@google.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23625
+ Skia platform doesn't render text to a canvas or support clipping to an image buffer
+
+ Fixes two bugs in Skia rendering to a canvas:
+ . Text was not rendered at all. This is because we never properly
+ fixed up the alpha values. The fix is to create a layer when
+ rendering text to a layer.
+ . We were not honoring clipping to an image buffer.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::clipToImageBuffer):
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (PlatformContextSkia::PlatformContextSkia):
+ (PlatformContextSkia::setDrawingToImageBuffer):
+ (PlatformContextSkia::isDrawingToImageBuffer):
+ (PlatformContextSkia::beginLayerClippedToImage):
+ (PlatformContextSkia::restore):
+ (PlatformContextSkia::applyClipFromImage):
+ * platform/graphics/skia/PlatformContextSkia.h:
+
+2009-01-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ First step in tracking the urls a HistoryItem was redirected through.
+
+ * WebCore.base.exp:
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ (WebCore::HistoryItem::addRedirectURL):
+ (WebCore::HistoryItem::redirectURLs):
+ (WebCore::HistoryItem::setRedirectURLs):
+ * history/HistoryItem.h:
+
+2009-01-29 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann, Eric Seidel.
+
+ Just transform the pattern directly instead of transforming the context fixes this
+ problem. Texts or strokes are no longer affected by transformations.
+
+ SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions
+ https://bugs.webkit.org/show_bug.cgi?id=23472
+
+ Test: svg/custom/pattern-with-transformation.svg
+
+ * platform/graphics/Pattern.h:
+ (WebCore::Pattern::setPatternSpaceTransform):
+ * platform/graphics/cairo/PatternCairo.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * platform/graphics/cg/PatternCG.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * platform/graphics/qt/PatternQt.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Move the line box list member out of RenderFlow and down into RenderBlock and RenderInline. Eliminate RenderFlow from the tree.
+
+ Reviewed by Sam Weinig
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/HTMLAnchorElement.cpp:
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::rendererLineBoxes):
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ * rendering/InlineFlowBox.h:
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::RenderBlock):
+ (WebCore::RenderBlock::destroy):
+ (WebCore::RenderBlock::styleWillChange):
+ (WebCore::RenderBlock::styleDidChange):
+ (WebCore::RenderBlock::dirtyLineBoxes):
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::setSelectionState):
+ (WebCore::RenderBlock::avoidsFloats):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ (WebCore::RenderBlock::baselinePosition):
+ (WebCore::RenderBlock::getBaselineOfFirstLineBox):
+ (WebCore::RenderBlock::getBaselineOfLastLineBox):
+ (WebCore::RenderBlock::rectWithOutlineForRepaint):
+ (WebCore::RenderBlock::hoverAncestor):
+ (WebCore::RenderBlock::updateDragState):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::lineBoxes):
+ (WebCore::RenderBlock::firstLineBox):
+ (WebCore::RenderBlock::lastLineBox):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeRectForRepaint):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ * rendering/RenderBox.h:
+ * rendering/RenderFlow.cpp: Removed.
+ * rendering/RenderFlow.h: Removed.
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::destroy):
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::cloneInline):
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::offsetLeft):
+ (WebCore::RenderInline::offsetTop):
+ (WebCore::RenderInline::positionForCoordinates):
+ (WebCore::RenderInline::rectWithOutlineForRepaint):
+ (WebCore::RenderInline::updateDragState):
+ (WebCore::RenderInline::relativePositionedInlineOffset):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::lineBoxes):
+ (WebCore::RenderInline::firstLineBox):
+ (WebCore::RenderInline::lastLineBox):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::rendererLineBoxes):
+ * rendering/RootInlineBox.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::createLineBoxes):
+ * wml/WMLAElement.cpp:
+
+2009-01-29 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Cleaned up some naming in ScheduledRedirection.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::ScheduledRedirection::ScheduledRedirection):
+
+2009-01-29 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Update to use new API.
+
+ * platform/graphics/mac/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
+ (WebCore::createFontCustomPlatformData):
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23619
+ ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load
+ is cancelled
+
+ Covered by existing tests (as a random crash).
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::cancelledError):
+ (WebCore::EmptyFrameLoaderClient::blockedError):
+ (WebCore::EmptyFrameLoaderClient::cannotShowURLError):
+ (WebCore::EmptyFrameLoaderClient::interruptForPolicyChangeError):
+ (WebCore::EmptyFrameLoaderClient::cannotShowMIMETypeError):
+ (WebCore::EmptyFrameLoaderClient::fileDoesNotExistError):
+ (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
+ Create non-null errors.
+
+2009-01-29 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Removed an unused case of "lockHistory" to help make the other cases
+ clearer.
+
+ * page/FrameLoadRequest.h:
+ (WebCore::FrameLoadRequest::FrameLoadRequest):
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Move all of the contination insertion code from RenderFlow to RenderInline. addChildToFlow is renamed to addChildIgnoringContinuation, and it has been moved to
+ RenderContainer so that it can still be called on either blocks or inlines. The base class implementation in RenderContainer is what RenderBlock uses. RenderInline
+ subclasses it to do all the work it used to do in addChildToFlow.
+
+ RenderBlock's old addChildToFlow can just become addChild. This simplification is possible because addChild was actually never being called on anonymous
+ block continuations.
+
+ The code dealing with anonymous table parts in the old addChildWithContinuation method can now be removed as a result with no harmful side effects. Falling through to the
+ base class and ignoring a block continuation makes the right thing happen.
+
+ addChildWithContinuation moved to RenderInline and has been renamed to addChildToContinuation.
+
+ Reviewed by Eric Seidel
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addChild):
+ * rendering/RenderBlock.h:
+ * rendering/RenderContainer.h:
+ (WebCore::RenderContainer::addChildIgnoringContinuation):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::addChild):
+ (WebCore::nextContinuation):
+ (WebCore::RenderInline::continuationBefore):
+ (WebCore::RenderInline::addChildIgnoringContinuation):
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::splitFlow):
+ (WebCore::RenderInline::addChildToContinuation):
+ (WebCore::RenderInline::childBecameNonInline):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::continuation):
+ (WebCore::RenderInline::setContinuation):
+
+2009-01-29 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Oliver Hunt
+
+ <rdar://problem/6337157> hyundaiusa.com closes window or tab during load
+
+ Test: fast/loader/subframe-self-close.html
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::close): Only allow mainframes to close the window.
+
+2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by David Hyatt.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23539
+
+ Remove several virtual functions from Node & Element related to form control / input elements,
+ that shouldn't reside there, but move to approriate locations, in the new form control /
+ input element abstract base classes.
+
+ Remove the isControl() method from Node, as it's redundant - isFormControlElement() provides the same information.
+ Move isEnabled( / isReadOnlyControl() / isTextControl() from Node to FormControlElement.
+ Move isAutofilled() / isChecked() / isIndeterminate() from Node to InputElement.
+ Move isInputTypeHidden() / isPasswordField() from Element to InputElement.
+
+ Querying these methods requires using the toInputElement/toFormControlElement casting helper functions
+ to cast Element pointers to InputElement/FormControlElement pointers.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::canShareStyleWithElement):
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * dom/Element.h:
+ (WebCore::Element::isFormControlElementWithState):
+ * dom/FormControlElement.h:
+ * dom/InputElement.h:
+ * dom/Node.h:
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::advance):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::attach):
+ * html/HTMLFormControlElement.h:
+ (WebCore::HTMLFormControlElement::isTextControl):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::CheckedRadioButtons::removeButton):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::isAutofilled):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isPasswordField):
+ (WebCore::AccessibilityRenderObject::isIndeterminate):
+ (WebCore::AccessibilityRenderObject::isChecked):
+ (WebCore::AccessibilityRenderObject::isControl):
+ (WebCore::AccessibilityRenderObject::isEnabled):
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (textMarkerForVisiblePosition):
+ * platform/ContextMenu.cpp:
+ (WebCore::ContextMenu::populate):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::resize):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::itemIsEnabled):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::updateUserModifyProperty):
+ (WebCore::RenderTextControl::adjustInnerTextStyle):
+ (WebCore::RenderTextControl::updateFromElement):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isChecked):
+ (WebCore::RenderTheme::isIndeterminate):
+ (WebCore::RenderTheme::isEnabled):
+ (WebCore::RenderTheme::isReadOnlyControl):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustMenuListStyle):
+ * wml/WMLFormControlElement.cpp:
+ (WebCore::WMLFormControlElement::isFocusable):
+ * wml/WMLFormControlElement.h:
+ (WebCore::WMLFormControlElement::isEnabled):
+ (WebCore::WMLFormControlElement::isReadOnlyControl):
+ (WebCore::WMLFormControlElement::isTextControl):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::isKeyboardFocusable):
+ (WebCore::WMLInputElement::isMouseFocusable):
+ * wml/WMLInputElement.h:
+ (WebCore::WMLInputElement::isAutofilled):
+
+2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix WML build - apply same fix as HTMLAnchorElement received.
+
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::isKeyboardFocusable):
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23620
+ Crash in appcache/resource-redirect.html on Tiger
+
+ There was a bug in the test case - it didn't send a Location header, and on Tiger, this
+ resulted in a failure callback being sent. It turned out that proper redirects weren't
+ caught at all.
+
+ Tests: http/tests/appcache/manifest-redirect-2.html
+ http/tests/appcache/resource-redirect-2.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::didFail): Fixed this function to not crash if
+ didReceiveResponse() wasn't called for this request.
+ (WebCore::ApplicationCacheGroup::didReceiveResponse): Fixed to check for redirects correctly.
+ (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Ditto.
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Move dirtyLinesFromChangedChild into RenderLineBoxList so that it can be shared by RenderBlock and RenderInline.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::dirtyLinesFromChangedChild):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::dirtyLinesFromChangedChild):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+ * rendering/RenderLineBoxList.h:
+
+2009-01-29 Adam Roben <aroben@apple.com>
+
+ Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
+ receives a WM_PRINTCLIENT message
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23623>
+ <rdar://problem/6513921>
+ <rdar://problem/6536874>
+
+ Flash doesn't seem to respond to WM_PRINTCLIENT, so we change
+ WM_PRINTCLIENT messages into WM_PAINT messages and hook into the
+ BeginPaint/EndPaint APIs to return the HDC we received from
+ WM_PRINTCLIENT. This causes the plugin to paint into the
+ WM_PRINTCLIENT HDC via its normal WM_PAINT handler. This technique
+ came from <http://www.fengyuan.com/article/wmprint.html>.
+
+ No test possible.
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/GraphicsContext.h: Added
+ [set]ShouldIncludeChildWindows on Windows.
+
+ * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Added
+ m_shouldIncludeChildWindows.
+ (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
+ Initialize the new member.
+
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ (WebCore::GraphicsContext::setShouldIncludeChildWindows):
+ (WebCore::GraphicsContext::shouldIncludeChildWindows):
+ Added simple setter and getter.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView): Initialize the new member.
+
+ * plugins/PluginView.h: Added m_wmPrintHDC and various functions
+ required for making WM_PRINTCLIENT work.
+
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::hookedBeginPaint):
+ (WebCore::PluginView::hookedEndPaint):
+ (WebCore::hook):
+ (WebCore::setUpOffscreenPaintingHooks):
+ Added. Code was modified from code available on fengyuan.com.
+
+ (WebCore::PluginView::wndProc): Turn WM_PRINTCLIENT messages into
+ WM_PAINT messages and save off the HDC that we're supposed to paint
+ into.
+
+ (WebCore::PluginView::paintWindowedPluginIntoContext): Added. Gets an
+ HDC from the GraphicsContext, translates it into client coordinates,
+ gets the plugin to draw into the HDC by sending a WM_PRINTCLIENT
+ message, and returns the HDC to the GraphicsContext.
+
+ (WebCore::PluginView::paint): If we're trying to paint a windowed
+ plugin into the GraphicsContext, call paintWindowedPluginIntoContext.
+
+ (WebCore::PluginView::init): Call setUpOffscreenPaintingHooks to make
+ our WM_PRINTCLIENT trick work.
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Move RenderFlow::destroy down into RenderBlock and RenderInline.
+
+ Reviewed by Anders Carlsson
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::destroy):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::destroy):
+
+2009-01-29 David Kilzer <ddkilzer@apple.com>
+
+ Remove semi-colons from the end of ObjC method implementations
+
+ Rubber-stamped by Adam Roben.
+
+ $ find WebCore -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
+
+ * bridge/testbindings.mm:
+
+2009-01-29 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23609
+ Use the two-arg constructor for implicit QUrl->KURL conversion as the
+ single argument ctors assume that KURL::parse has already been called
+ and assert if the parse results in a different string. This was causing
+ an assert for QUrl's with no path and without a trailing slash.
+
+ * platform/qt/KURLQt.cpp:
+ (WebCore::KURL::KURL):
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Rubber-stamped by Darin Adler.
+
+ Renamed ApplicationCacheResource::Implicit to Master, because that's the word HTML5 uses,
+ and it describes the meaning better.
+
+ * loader/appcache/ApplicationCache.cpp:
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ * loader/appcache/ApplicationCacheResource.cpp:
+ * loader/appcache/ApplicationCacheResource.h:
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Release build fix.
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
+ Got rid of a variable that wasn't used in release builds.
+
+2009-01-29 David Hyatt <hyatt@apple.com>
+
+ Get rid of createAnonymousFlow. It was only called in one spot, so just inline the code.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::updateFirstLetter):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23476
+ HTTP redirect should make application cache updating fail
+
+ Tests: http/tests/appcache/manifest-redirect.html
+ http/tests/appcache/resource-redirect.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::didReceiveResponse):
+ (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
+ Fail if response code isn't 2xx.
+
+2009-01-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23592
+ Update appcache manifest signature parsing
+
+ Test: http/tests/appcache/wrong-signature-2.html
+
+ * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Allow comments on signature
+ line. Removed code that replaced nulls with 0xFFFD characters, because there is no such
+ requirement in the spec.
+
+2009-01-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23584
+ Update application cache code for the latest round of spec changes
+
+ The changes mostly affect the update process - events are sent at a different
+ time, and caches are associated with documents earlier.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::mainReceivedError): Changed an always passing test to an assertion.
+ (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Caches are now associated
+ with DocumentLoader before being complete, but they only affect loading after being completed.
+ (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Ditto.
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::setGroup): Allow setting the group to the same one, to simplify
+ ApplicationCacheGroup code.
+ (WebCore::ApplicationCache::isComplete): A new method that tells whether the cache is
+ complete, as defined in HTML5.
+ * loader/appcache/ApplicationCache.h: Added isComplete().
+
+ * loader/appcache/ApplicationCacheGroup.h:
+ (WebCore::ApplicationCacheUpdateOption): Per HTML5, cache updating should work differently
+ when invoked with or without a browsing context (Frame). A Frame is currently always needed
+ for updating in WebKit, so a new argument to update() tells whether we should pretend that
+ there isn't one.
+ (WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): A helper for ApplicationCache::isComplete().
+ (WebCore::ApplicationCacheGroup::CompletionType): Cache update algorithm now waits for
+ ne main resources to finish loading in more cases. A member variable of this type is used to
+ distinguish between different cases when waiting.
+ (WebCore::ApplicationCacheGroup::m_cacheCandidates): The new algorithm doesn't track cache
+ candidates. Caches are associated with documents much earlier, but the ones whose main resources
+ have not been loaded from a cache are being tracked in a pending master entry list.
+
+ * loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::update):
+ An explicit call to update() invokes the algorithm without a browsing context.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
+ (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
+ (WebCore::ApplicationCacheGroup::selectCache):
+ (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
+ (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
+ (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
+ (WebCore::ApplicationCacheGroup::stopLoading):
+ (WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
+ (WebCore::ApplicationCacheGroup::cacheDestroyed):
+ (WebCore::ApplicationCacheGroup::setNewestCache):
+ (WebCore::ApplicationCacheGroup::update):
+ (WebCore::ApplicationCacheGroup::didReceiveResponse):
+ (WebCore::ApplicationCacheGroup::didFinishLoading):
+ (WebCore::ApplicationCacheGroup::didFail):
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
+ (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
+ (WebCore::ApplicationCacheGroup::manifestNotFound):
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
+ (WebCore::ApplicationCacheGroup::startLoadingEntry):
+ (WebCore::ApplicationCacheGroup::deliverDelayedMainResources):
+ (WebCore::ApplicationCacheGroup::addEntry):
+ (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache):
+ (WebCore::CallCacheListenerTask::create):
+ (WebCore::CallCacheListenerTask::performTask):
+ (WebCore::CallCacheListenerTask::CallCacheListenerTask):
+ (WebCore::ApplicationCacheGroup::postListenerTask):
+ Rewrote the update algorithm.
+
+2009-01-28 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Merged FrameLoadTypeReloadAllowingStaleData with FrameLoadTypeReload.
+
+ Technically, selecting View->Text Encoding->[Non-Default Encoding] on
+ a page with frames may now be slightly slower than it used to be. Oh well.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::isBackForwardLoadType):
+ (WebCore::FrameLoader::restoreDocumentState): Subbed in FrameLoadTypeReload.
+
+ (WebCore::FrameLoader::loadURLIntoChildFrame): No need to account for
+ non-back-forward navigations anymore.
+
+ (WebCore::FrameLoader::canCachePage):
+ (WebCore::FrameLoader::logCanCachePageDecision):
+ (WebCore::FrameLoader::reloadWithOverrideEncoding):
+ (WebCore::FrameLoader::transitionToCommitted):
+ (WebCore::FrameLoader::loadItem): Subbed in FrameLoadTypeReload.
+
+ * loader/FrameLoader.h: Renamed reloadAllowingStaleData => reloadWithOverrideEncoding,
+ since that's what it actually does.
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move hit testing and painting of lines from RenderFlow into RenderLineBoxList.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintContents):
+ (WebCore::RenderBlock::hitTestContents):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::paint):
+ (WebCore::RenderInline::nodeAtPoint):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::paint):
+ (WebCore::RenderLineBoxList::hitTest):
+ * rendering/RenderLineBoxList.h:
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Fix SVG pixel test regressions. I wish I could say that I understand this fix, but I don't. For
+ some reason the original code returned 0 for RenderSVGInlineText::yPos() and somehow my literal
+ replacement of yPos() with the body of that method changed the results. I am completely baffled,
+ but all SVG pixel tests pass again when I just take the code out.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move dirtyLineBoxes from RenderFlow to RenderInline and RenderBlock.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::dirtyLineBoxes):
+ * rendering/RenderBlock.h:
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::dirtyLineBoxes):
+ * rendering/RenderInline.h:
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLineBoxes):
+ * rendering/RenderLineBoxList.h:
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Back out my change to scrollWidth/Height from an earlier checkin since it broke stuff. The current
+ behavior is not correct, but this will need to be investigated before being changed again.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move paintOutline and paintOutlineWithLine from RenderFlow to RenderInline, since they only apply to inlines. Tighten up all of the code that
+ called paintOutline to use RenderInline as the type instead of RenderFlow.
+
+ Reviewed by cpst
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::addContinuationWithOutline):
+ (WebCore::RenderBlock::paintContinuationOutlines):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::paintLines):
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::paintOutline):
+ (WebCore::RenderInline::paintOutlineForLine):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::paintOutline):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::PaintInfo::PaintInfo):
+
+2009-01-28 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23596
+ XMLHttpRequest.cpp no longer compiles without USE(JSC)
+
+ * xml/XMLHttpRequest.cpp:
+
+2009-01-28 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23597
+ Make it possible to compile Database.cpp when USE(JSC) is not defined
+
+ * storage/Database.cpp:
+ (WebCore::Database::Database):
+
+2009-01-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6077047> REGRESSION (r34544): Custom icon does not
+ appear in address field on first visit to any site
+
+ * loader/icon/IconLoader.cpp:
+ (WebCore::IconLoader::finishLoading): Changed to set the icon data only
+ after establishing a mapping from the page URL(s) to the icon. Doing
+ things the other way around resulted in the data not being cached
+ in the icon-URL to IconRecord map (because there was no interested page
+ at the time) and subsequently having to be fetched asynchronously from
+ the database when the page-to-icon mapping was established.
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move addFocusRingRects from RenderFlow down into RenderBlock and RenderInline.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addFocusRingRects):
+ * rendering/RenderBlock.h:
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::addFocusRingRects):
+ * rendering/RenderInline.h:
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move localCaretRect from RenderFlow into RenderBlock, since it only applied to blocks anyway and
+ was misplaced from the start.
+
+ Reviewed by Antti Koivisto.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::localCaretRect):
+ * rendering/RenderBlock.h:
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+
+2009-01-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Add forwarding header.
+
+ * ForwardingHeaders/debugger/DebuggerActivation.h: Added.
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move createInlineBox out of RenderFlow and down into RenderInline and RenderBlock.
+
+ Reviewed by Beth Dakin
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::createInlineBox):
+ * rendering/RenderBlock.h:
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::createInlineBox):
+ * rendering/RenderInline.h:
+ * rendering/bidi.cpp:
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move calcMargins from RenderFlow to RenderInline, since it was only ever called on RenderInlines.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::calcMargins):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Refactor the first and last line box member variables from RenderFlow. Encapsulate them into a new class called RenderLineBoxList that manages all modifications to
+ the list. This change will make it easier to give RenderInline and RenderBlock separate versions of the line box list without having to duplicate very much code.
+
+ Reviewed by Oliver Hunt
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::deleteLine):
+ (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::extractLine):
+ (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
+ (WebCore::InlineFlowBox::attachLine):
+ (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
+ * rendering/InlineFlowBox.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::deleteLineBoxTree):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::destroy):
+ (WebCore::RenderFlow::dirtyLineBoxes):
+ (WebCore::RenderFlow::createInlineBox):
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::RenderFlow):
+ (WebCore::RenderFlow::lineBoxes):
+ (WebCore::RenderFlow::firstLineBox):
+ (WebCore::RenderFlow::lastLineBox):
+ * rendering/RenderLineBoxList.cpp: Added.
+ (WebCore::RenderLineBoxList::~RenderLineBoxList):
+ (WebCore::RenderLineBoxList::appendLineBox):
+ (WebCore::RenderLineBoxList::deleteLineBoxTree):
+ (WebCore::RenderLineBoxList::extractLineBox):
+ (WebCore::RenderLineBoxList::attachLineBox):
+ (WebCore::RenderLineBoxList::removeLineBox):
+ (WebCore::RenderLineBoxList::deleteLineBoxes):
+ (WebCore::RenderLineBoxList::checkConsistency):
+ * rendering/RenderLineBoxList.h: Added.
+ (WebCore::RenderLineBoxList::RenderLineBoxList):
+ (WebCore::RenderLineBoxList::firstLineBox):
+ (WebCore::RenderLineBoxList::lastLineBox):
+ (WebCore::RenderLineBoxList::checkConsistency):
+ * rendering/RenderSVGInline.cpp:
+ (WebCore::RenderSVGInline::createInlineBox):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::createInlineBox):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::removeLineBoxFromRenderObject):
+ (WebCore::RootInlineBox::extractLineBoxFromRenderObject):
+ (WebCore::RootInlineBox::attachLineBoxToRenderObject):
+ * rendering/RootInlineBox.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-01-28 David Kilzer <ddkilzer@apple.com>
+
+ Clean up FontPlatformData constructor
+
+ Reviewed by David Hyatt.
+
+ * platform/graphics/mac/FontPlatformData.h: Updated copyright.
+ (WebCore::FontPlatformData::FontPlatformData): Provide readable
+ names for constructor arguments and reformat member variables.
+ * platform/graphics/mac/FontPlatformDataMac.mm: Updated copyright.
+ (WebCore::FontPlatformData::FontPlatformData): Provide readable
+ names for constructor arguments and reformat member variables.
+
+2009-01-28 Tony Chang <tony@chromium.org>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23593
+ Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
+ This is a follow up for hyatt's RenderBox changes.
+
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::baselinePosition):
+ * rendering/RenderThemeChromiumWin.cpp:
+ (WebCore::RenderThemeChromiumWin::paintMenuList):
+
+2009-01-28 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23582
+
+ Fix assertions when inline elements have both opacity (or something
+ else that creates a RenderLayer), and transform by ensuring that
+ setHasTransform() is only called for non-inline or replaced elements.
+ We also have to ensure that RenderReplicas will get transforms applied
+ to them by lying about them being replaced.
+
+ Tests: fast/transforms/transform-on-inline.html
+ fast/transforms/transform-table-row.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::RenderReplica):
+ * rendering/RenderTableRow.h:
+ (WebCore::RenderTableRow::requiresLayer):
+
+2009-01-28 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Justin Garcia.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18835
+ Spelling underlines disappear when they shouldn't
+
+ The WebCore::InsertLineBreakCommand::doApply() function splits a text node
+ without copying existing markers. To fix this bug, change code which
+ manually splits a text node into a CompositeEditCommand::splitTextNode() call.
+
+ Test: editing/spelling/spelling-linebreak.html
+
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Move the m_lineHeight member variable out of RenderFlow and down into RenderBlock and RenderInline. Shift the line height computation into RenderStyle so
+ that it isn't repeated in three places.
+
+ Reviewed by Sam Weinig
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::RenderBlock):
+ (WebCore::RenderBlock::lineHeight):
+ * rendering/RenderBlock.h:
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::RenderFlow):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::lineHeight):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::lineHeight):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::computedLineHeight):
+
+2009-01-28 Zachary Kuznia <zork@chromiuum.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22070
+ Add an option to allow scripts to close windows.
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setAllowScriptsToCloseWindows):
+ * page/Settings.h:
+ (WebCore::Settings::allowScriptsToCloseWindows):
+
+2009-01-28 Adam Langley <agl@google.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23573
+ Make PlatformWidget on chromium an intptr_t to match changes made in Chromium
+
+ * platform/chromium/PlatformWidget.h:
+
+2009-01-28 David Hyatt <hyatt@apple.com>
+
+ Fix for
+
+ <rdar://problem/6531287> REGRESSION: CrashTracer: [USER] 12 crashes in Safari at com.apple.WebCore • WebCore::RenderBlock::removeFloatingObject + 59
+
+ My tightening up of markAllDescendantsWithFloatsForLayout exposed a buggy check in that code that could
+ lead to a bad cast.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+
+2009-01-27 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=23576
+
+ Work towards eliminating RenderFlow from the tree.
+
+ Move the m_continuation variable down from RenderFlow into RenderInline and RenderBlock. Since a block can only have an inline continuation following it, the type
+ of the member and methods reflect this (inlineContinuation() and m_inlineContinuation). Since an inline can have either a block or an inline continuation following it,
+ a base class of RenderBox* is used for the type of object returned (in anticipation of the removal of RenderFlow).
+
+ Since moving the continuation variable down into the subclasses increased the size of RenderInline and RenderBlock by 4 bytes, this patch also moves all of the bitfield
+ members of RenderFlow up to RenderObject. Since they fit within the available bits on RenderObject, this patch actually results in a net savings of 4 bytes on RenderInlines
+ and RenderBlocks!
+
+ One bitfield member was eliminated rather than moved: m_firstLine. This was really more of a state variable used during line layout only, so I removed it as a member
+ and just passed firstLine down to various methods as needed. Doing so uncovered some potential bugs where the first line state was not being respected when querying for
+ line offsets.
+
+ Continuations have been completely hidden from all files except for RenderFlow, RenderBlock and RenderInline. All of the code that referenced continuations directly
+ from base classes has been refactored to use virtual methods on RenderBlock and RenderInline instead.
+
+ RenderFlow still has a common addChildWithContinuation method that is used by both blocks and inlines. Since refactoring that method will be pretty tricky, I've held
+ off on that for a later patch.
+
+ Reviewed by Oliver Hunt
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ (WebCore::InlineFlowBox::paint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::RenderBlock):
+ (WebCore::RenderBlock::~RenderBlock):
+ (WebCore::RenderBlock::destroy):
+ (WebCore::RenderBlock::addChildToFlow):
+ (WebCore::RenderBlock::makeChildrenNonInline):
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::determineHorizontalPosition):
+ (WebCore::RenderBlock::setCollapsedBottomMargin):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::addContinuationWithOutline):
+ (WebCore::RenderBlock::setSelectionState):
+ (WebCore::RenderBlock::shouldPaintSelectionGaps):
+ (WebCore::RenderBlock::fillSelectionGaps):
+ (WebCore::RenderBlock::leftSelectionOffset):
+ (WebCore::RenderBlock::rightSelectionOffset):
+ (WebCore::RenderBlock::leftOffset):
+ (WebCore::RenderBlock::leftRelOffset):
+ (WebCore::RenderBlock::rightOffset):
+ (WebCore::RenderBlock::rightRelOffset):
+ (WebCore::RenderBlock::lineWidth):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::getClearDelta):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::offsetForContents):
+ (WebCore::RenderBlock::availableWidth):
+ (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
+ (WebCore::RenderBlock::desiredColumnWidth):
+ (WebCore::RenderBlock::desiredColumnCount):
+ (WebCore::RenderBlock::columnRects):
+ (WebCore::RenderBlock::layoutColumns):
+ (WebCore::RenderBlock::adjustPointToColumnContents):
+ (WebCore::RenderBlock::adjustRectForColumns):
+ (WebCore::RenderBlock::absoluteRects):
+ (WebCore::RenderBlock::absoluteQuads):
+ (WebCore::RenderBlock::rectWithOutlineForRepaint):
+ (WebCore::RenderBlock::hoverAncestor):
+ (WebCore::RenderBlock::updateDragState):
+ (WebCore::RenderBlock::outlineStyleForRepaint):
+ (WebCore::RenderBlock::childBecameNonInline):
+ (WebCore::RenderBlock::updateHitTestResult):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::rightOffset):
+ (WebCore::RenderBlock::leftOffset):
+ (WebCore::RenderBlock::inlineContinuation):
+ (WebCore::RenderBlock::setInlineContinuation):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::absoluteRects):
+ (WebCore::RenderBox::absoluteQuads):
+ (WebCore::RenderBox::addFocusRingRects):
+ (WebCore::RenderBox::containingBlockWidth):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::collapsedMarginBottom):
+ (WebCore::RenderBox::childBecameNonInline):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderFlow.cpp:
+ (WebCore::nextContinuation):
+ (WebCore::RenderFlow::continuationBefore):
+ (WebCore::RenderFlow::addChildWithContinuation):
+ (WebCore::RenderFlow::addChild):
+ (WebCore::RenderFlow::destroy):
+ (WebCore::RenderFlow::addFocusRingRects):
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::RenderFlow):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::RenderInline):
+ (WebCore::RenderInline::destroy):
+ (WebCore::RenderInline::inlineContinuation):
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::addChildToFlow):
+ (WebCore::RenderInline::cloneInline):
+ (WebCore::RenderInline::splitInlines):
+ (WebCore::RenderInline::splitFlow):
+ (WebCore::RenderInline::positionForCoordinates):
+ (WebCore::RenderInline::rectWithOutlineForRepaint):
+ (WebCore::RenderInline::updateDragState):
+ (WebCore::RenderInline::childBecameNonInline):
+ (WebCore::RenderInline::updateHitTestResult):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::isRenderInline):
+ (WebCore::RenderInline::continuation):
+ (WebCore::RenderInline::setContinuation):
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::positionListMarker):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::RenderListMarker):
+ (WebCore::RenderListMarker::setSelectionState):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ (WebCore::RenderObject::rectWithOutlineForRepaint):
+ (WebCore::RenderObject::handleDynamicFloatPositionChange):
+ (WebCore::RenderObject::updateDragState):
+ (WebCore::RenderObject::updateHitTestResult):
+ (WebCore::RenderObject::getTextDecorationColors):
+ (WebCore::RenderObject::adjustRectForOutlineAndShadow):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isInlineBlockOrInlineTable):
+ (WebCore::RenderObject::childrenInline):
+ (WebCore::RenderObject::setChildrenInline):
+ (WebCore::RenderObject::hasColumns):
+ (WebCore::RenderObject::setHasColumns):
+ (WebCore::RenderObject::cellWidthChanged):
+ (WebCore::RenderObject::setCellWidthChanged):
+ (WebCore::RenderObject::isInlineContinuation):
+ (WebCore::RenderObject::hoverAncestor):
+ (WebCore::RenderObject::outlineStyleForRepaint):
+ (WebCore::RenderObject::setHasMarkupTruncation):
+ (WebCore::RenderObject::hasMarkupTruncation):
+ (WebCore::RenderObject::selectionState):
+ (WebCore::RenderObject::setSelectionState):
+ (WebCore::RenderObject::hasSelectedChildren):
+ (WebCore::RenderObject::isTopMarginQuirk):
+ (WebCore::RenderObject::isBottomMarginQuirk):
+ (WebCore::RenderObject::setTopMarginQuirk):
+ (WebCore::RenderObject::setBottomMarginQuirk):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::RenderReplaced):
+ (WebCore::RenderReplaced::setSelectionState):
+ * rendering/RenderReplaced.h:
+ (WebCore::RenderReplaced::canBeSelectionLeaf):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::calcWidth):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::updateWidth):
+ (WebCore::RenderTableCell::layout):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+ (WebCore::RenderText::localCaretRect):
+ (WebCore::RenderText::setSelectionState):
+ * rendering/RenderText.h:
+ (WebCore::RenderText::canBeSelectionLeaf):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::updateHitTestResult):
+ * rendering/RenderView.h:
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::selectionTop):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::createLineBoxes):
+ (WebCore::RenderBlock::constructLine):
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::determineStartPosition):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::RenderBlock::fitBelowFloats):
+ (WebCore::RenderBlock::findNextLineBreak):
+ (WebCore::RenderBlock::checkLinesForTextOverflow):
+
+2009-01-28 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Nikolas Zimmermann and George Staikos.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23557
+ Allow option of hit testing frame content without clipping to the visible
+ viewport.
+
+ * WebCore.base.exp:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * page/EventHandler.h:
+ * rendering/HitTestRequest.h:
+ (WebCore::HitTestRequest::HitTestRequest):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTest):
+
+2009-01-28 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Fix the build with Qt on Windows.
+
+ Make sure that the QTWEBKIT_EXPORT macro becomes the Q_DECL_EXPORT macro
+ instead of the import macro when building the dll, by defining
+ QT_MAKEDLL.
+
+ SystemTimeWin.cpp is needed on Windows for userIdleTime(), which for the
+ other Qt platforms comes from TemporaryLinkStubs.cpp.
+
+ * WebCore.pro:
+
+2009-01-28 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Speed-up clipping: avoid calling expensive QPainter::clipRegion().
+ Beside, the check is not necessary since QPainter::setClipRect() will
+ work just fine if there is no clip region yet.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::clip):
+
+2009-01-28 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23546
+ Upstream GoogleURL implementation of KURL
+
+ * platform/KURL.h:
+ * platform/KURLGoogle.cpp: Added.
+ * platform/KURLGooglePrivate.h: Added.
+
+2009-01-27 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ REGRESSION (r40234): Launching iTunes from a link displays a
+ "Safari can't find the Internet plug-in" sheet in Safari
+ rdar://problem/6533678
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::havePlugin): Put the check for empty string in here.
+ (WebCore::serviceTypeForClassId): Only return activeXType() if
+ we have a plug-in that can handle that type. While it might be logical
+ to return an Active X type for any <object> with a classId in it,
+ even if we don't have a plug-in that implements Active X, existing
+ clients, such as Safari, don't expect that.
+
+2009-01-27 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Steve Falkenburg.
+
+ - fix <rdar://problem/6524351> Text looks bad when font smoothing is
+ forced off
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::Font::drawGlyphs): Changed to use GDI rather than Core
+ Graphics if the client has turned font smoothing off.
+
+2009-01-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23360
+
+ Use the new container-relative repaint methods to compute
+ post-layout repaints, and repaints using RenderLayer's
+ cached repaintRect() relative to that container, rather than
+ using absolute coords.
+
+ Replaced lots of boilerplate old/new rect code in various
+ layout methods with a stack-based LayoutRepainter class, and
+ fixed a bug in RenderTable which set didFullRepaint to
+ 'true' every time.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::layout):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::setHasVisibleContent):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintUsingContainer):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
+ (WebCore::RenderObject::LayoutRepainter::repaintAfterLayout):
+ (WebCore::RenderObject::LayoutRepainter::checkForRepaint):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::layout):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::layout):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::layout):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::layout):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::layout):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-01-27 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/3541409> - More groundwork and cleanup for CachedFrames
+
+ * history/CachedFrame.cpp:
+ (WebCore::CachedFrame::CachedFrame): Make the savePlatformDataToCachedFrame() client call here,
+ and add the code for caching subframes.
+ (WebCore::CachedFrame::clear):
+ * history/CachedFrame.h: Change to be RefCounted
+ (WebCore::CachedFrame::create):
+ (WebCore::CachedFrame::url):
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ * history/CachedPage.h:
+ (WebCore::CachedPage::document):
+ (WebCore::CachedPage::documentLoader):
+ (WebCore::CachedPage::view):
+ (WebCore::CachedPage::url):
+ (WebCore::CachedPage::domWindow):
+ (WebCore::CachedPage::cachedMainFrame):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::cachePageForHistoryItem): Move the platform data saving into the
+ CachedFrame itself.
+
+2009-01-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Flip the arguments of computeRectForRepaint() from
+ computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)
+ to
+ computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::clippedOverflowRectForRepaint):
+ (WebCore::RenderBox::computeRectForRepaint):
+ * rendering/RenderBox.h:
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::computeRectForRepaint):
+ * rendering/RenderForeignObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::computeRectForRepaint):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+ (WebCore::RenderTableCell::computeRectForRepaint):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::computeRectForRepaint):
+ * rendering/RenderView.h:
+
+2009-01-27 David Kilzer <ddkilzer@apple.com>
+
+ Add missing header guards to AccessibilityObjectWrapper.h
+
+ Reviewed by Anders Carlsson.
+
+ * page/mac/AccessibilityObjectWrapper.h: Added missing header guards.
+
+2009-01-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23567
+
+ Fix crash of svg/custom/stop-crash.svg testcase because of
+ infinite recursion, as I missed replacing absoluteClippedOverflowRect()
+ with clippedOverflowRectForRepaint() in RenderSVGGradientStop.
+
+ Also fix a missed conversion in RenderTableCol, and add a couple
+ of comments.
+
+ * rendering/RenderSVGGradientStop.h:
+ (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::imageChanged):
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::layout):
+
+2009-01-27 Adele Peterson <adele@apple.com>
+
+ RS by Dave Hyatt
+
+ Use the textfield appearance for search fields in themeWin.css so the border/background
+ styling will work correctly on these fields.
+
+ * css/themeWin.css:
+
+2009-01-27 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::setSelectionStart):
+ (WebCore::JSHTMLInputElement::setSelectionEnd):
+ (WebCore::JSHTMLInputElement::setSelectionRange):
+
+2009-01-27 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * platform/graphics/Gradient.cpp:
+ (WebCore::Gradient::setSpreadMethod):
+
+2009-01-27 Paul Godavari <paul@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23561
+ Explicitly send the MIME type from an image dragged from a web
+ page to the desktop, to Chromium so that it can properly generate
+ a file name.
+
+ * platform/chromium/ChromiumDataObject.cpp:
+ (WebCore::ChromiumDataObject::clear):
+ (WebCore::ChromiumDataObject::hasData):
+ * platform/chromium/ChromiumDataObject.h:
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::writeImageToDataObject):
+
+2009-01-27 Mads Ager <ager@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23300
+ Follow Firefox in throwing exceptions when using selection
+ functions on HTMLInputElements that cannot have selection.
+
+ This requires custom setSelectionRange, setSelectionStart and
+ setSelectionEnd implementations, but it gets rid of the custom
+ getOwnPropertySlot.
+
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::selectionStart):
+ (WebCore::JSHTMLInputElement::selectionEnd):
+ (WebCore::JSHTMLInputElement::setSelectionRange):
+ * html/HTMLInputElement.idl:
+
+2009-01-27 Evan Stade <estade@chromium.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23435
+ Make spreadMethod a member of Gradient rather than GraphicsContext.
+ Implement spreadMethod for Skia.
+
+ * platform/graphics/Gradient.cpp:
+ (WebCore::Gradient::Gradient):
+ * platform/graphics/Gradient.h:
+ (WebCore::Gradient::setSpreadMethod):
+ (WebCore::Gradient::spreadMethod):
+ * platform/graphics/GraphicsContext.cpp:
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsContextPrivate.h:
+ * platform/graphics/GraphicsTypes.h:
+ (WebCore::):
+ * platform/graphics/cairo/GradientCairo.cpp:
+ (WebCore::Gradient::platformGradient):
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ * platform/graphics/qt/GradientQt.cpp:
+ (WebCore::Gradient::platformGradient):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ * platform/graphics/skia/GradientSkia.cpp:
+ (WebCore::Gradient::platformGradient):
+ * svg/SVGLinearGradientElement.cpp:
+ (WebCore::SVGLinearGradientElement::buildGradient):
+ * svg/SVGRadialGradientElement.cpp:
+ (WebCore::SVGRadialGradientElement::buildGradient):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
+ (WebCore::SVGPaintServerGradient::setup):
+ (WebCore::SVGPaintServerGradient::externalRepresentation):
+ * svg/graphics/SVGPaintServerGradient.h:
+
+2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ http://www.qtsoftware.com/developer/task-tracker/index_html?id=238662&method=entry
+
+ [Qt] Map function keys F1 to F24.
+
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+
+2009-01-27 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
+
+ * WebCore.base.exp:
+ * history/CachedPage.cpp:
+ * history/CachedPage.h:
+ (WebCore::CachedPage::cachedMainFrame):
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::savePlatformDataToCachedFrame):
+ (WebCore::EmptyFrameLoaderClient::transitionToCommittedFromCachedFrame):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::restoreDocumentState):
+ (WebCore::FrameLoader::commitProvisionalLoad):
+ (WebCore::FrameLoader::transitionToCommitted):
+ (WebCore::FrameLoader::cachePageForHistoryItem):
+ * loader/FrameLoaderClient.h:
+
+2009-01-26 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23360
+
+ Add variants of all the methods that compute dirty rects for repainting
+ with versions that compute those rects relative to some container
+ RenderBox that acts as a painting root.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::outlineBoundsForRepaint):
+ (WebCore::RenderBox::localToContainerQuad):
+ (WebCore::RenderBox::clippedOverflowRectForRepaint):
+ (WebCore::RenderBox::computeRectForRepaint):
+ * rendering/RenderBox.h:
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::computeRectForRepaint):
+ * rendering/RenderForeignObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::containerForRepaint):
+ (WebCore::RenderObject::repaint):
+ (WebCore::RenderObject::repaintRectangle):
+ (WebCore::RenderObject::rectWithOutlineForRepaint):
+ (WebCore::RenderObject::clippedOverflowRectForRepaint):
+ (WebCore::RenderObject::computeRectForRepaint):
+ (WebCore::RenderObject::localToContainerQuad):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::localToAbsoluteQuad):
+ (WebCore::RenderObject::absoluteClippedOverflowRect):
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+ (WebCore::RenderObject::absoluteOutlineBounds):
+ (WebCore::RenderObject::outlineBoundsForRepaint):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::clippedOverflowRectForRepaint):
+ (WebCore::RenderPath::outlineBoundsForRepaint):
+ * rendering/RenderPath.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+ (WebCore::RenderTableCell::computeRectForRepaint):
+ (WebCore::RenderTableCell::localToContainerQuad):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
+ * rendering/RenderTableCol.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::clippedOverflowRectForRepaint):
+ * rendering/RenderText.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::localToContainerQuad):
+ (WebCore::RenderView::computeRectForRepaint):
+ * rendering/RenderView.h:
+
+2009-01-26 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by David Hyatt
+
+ Back out r40285, because it was checked in with no bug number, no
+ testcase, is rendering change that did not get thorough review,
+ and broke the Mac build.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * page/EventHandler.h:
+ * rendering/HitTestRequest.h:
+ (WebCore::HitTestRequest::HitTestRequest):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTest):
+
+2009-01-26 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ -Make the recently added back/forward cache logging much better by actually
+ walking the entire frame tree and indenting the resulting output.
+ -Fix a null-termination bug in HistoryItem tree logging
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::showTreeWithIndent):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::pageCacheLogPrefix):
+ (WebCore::pageCacheLog):
+ (WebCore::FrameLoader::logCanCachePageDecision):
+ (WebCore::FrameLoader::logCanCacheFrameDecision):
+ * loader/FrameLoader.h:
+
+2009-01-26 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Allow option of hit testing frame content without clipping to the visible
+ viewport.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * page/EventHandler.h:
+ * rendering/HitTestRequest.h:
+ (WebCore::HitTestRequest::HitTestRequest):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTest):
+
+2009-01-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=18141
+ Acid3 tests 77 and 78 fail on reload due to SVG font race
+ <rdar://problem/6504899>
+
+ Match Opera's behavior of loading SVGFonts as soon as <font-face-uri>
+ tag is inserted into the document and not at the first use of the font
+ as is done for CSS web fonts.
+
+ This fixes a race condition noticeable by some in the Acid3 test that
+ happened because the onload event handler for an iframe containing a
+ <font-face-uri> with an external reference was not delayed by the pending
+ load of the font.
+
+ Test: http/tests/misc/SVGFont-delayed-load.html
+
+ * svg/SVGFontFaceUriElement.cpp:
+ (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement):
+ (WebCore::SVGFontFaceUriElement::parseMappedAttribute): Call loadFont if
+ the href attribute changes.
+ (WebCore::SVGFontFaceUriElement::insertedIntoDocument): Call loadFont.
+ (WebCore::SVGFontFaceUriElement::loadFont): Force a load of the
+ font specified in href attribute.
+ * svg/SVGFontFaceUriElement.h:
+
+2009-01-26 Timothy Hatcher <timothy@apple.com>
+
+ Change Web Archive serialization back to the binary property list format.
+
+ <rdar://problem/6127865> Web archives saved with Safari 4 cannot be read by Safari 3
+
+ Reviewed by Brady Eidson.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::rawDataRepresentation):
+
+2009-01-26 Anders Carlsson <andersca@apple.com>
+
+ Fix 64-bit build.
+
+ * WebCore.LP64.exp:
+
+2009-01-26 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23511
+ Move DOMTimer from bindings/js to page/.
+ This was prepared by moving all JSC dependencies from DOMTimer
+ to ScheduledAction earlier, and helps unfork the Chromuim version
+ of the DOMTimer.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/DOMTimer.cpp: Removed.
+ * bindings/js/DOMTimer.h: Removed.
+ * page/DOMTimer.cpp: Copied from WebCore/bindings/js/DOMTimer.cpp.
+ * page/DOMTimer.h: Copied from WebCore/bindings/js/DOMTimer.h.
+
+2009-01-26 David Hyatt <hyatt@apple.com>
+
+ Eliminate rightmostPosition, lowestPosition and leftmostPosition from RenderFlow. Move the code into
+ RenderBlock's methods.
+
+ Reviewed by Eric Seidel
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+
+2009-01-26 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23553
+ Upstream changes from jcampan to fix chromium bugs 6692 and 6694.
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::setLoopSelectionNavigation):
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupContainer::setLoopSelectionNavigation):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::paintRow):
+ (WebCore::PopupListBox::clearSelection):
+ (WebCore::PopupListBox::selectNextRow):
+ (WebCore::PopupListBox::selectPreviousRow):
+ * platform/chromium/PopupMenuChromium.h:
+
+2009-01-26 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Sam Weinig
+
+ Remove some historical CachedPage time stamp fluff.
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ * history/CachedPage.h:
+ (WebCore::CachedPage::timeStamp):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::cachePageForHistoryItem):
+
+2009-01-26 David Hyatt <hyatt@apple.com>
+
+ Move absoluteClippedOverflowRect, linesBoundingBox and borderBoundingBox from RenderFlow to RenderInline.
+
+ Reviewed by Eric Seidel
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ * rendering/RenderFlow.cpp:
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::linesBoundingBox):
+ (WebCore::RenderInline::absoluteClippedOverflowRect):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::borderBoundingBox):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+
+2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22650
+ Implement support for "Immutable" attribute to CodeGeneratorJS.pm, thus
+ allowing to explicitly mark methods as immutable (i.e. returning a new
+ instance rather than a reference to an existing instance).
+
+ * bindings/js/JSSVGMatrixCustom.cpp: Removed custom methods.
+ * bindings/scripts/CodeGeneratorJS.pm: Added check for Immutable
+ attribute when generating function call.
+ * svg/SVGMatrix.idl: Replaced Custom attribute with Immutable on
+ methods.
+
+2009-01-26 David Hyatt <hyatt@apple.com>
+
+ Eliminate isInlineFlow() now that a RenderBlock can never be an inline flow. isInlineFlow() is now
+ equivalent to isRenderInline(), so all calls to isInlineFlow() have been replaced with isRenderInline().
+
+ Reviewed by Eric Seidel
+
+ * dom/Text.cpp:
+ (WebCore::Text::rendererIsNeeded):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::shouldDrawTextDecoration):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::hitTestContents):
+ (WebCore::InlineMinMaxIterator::next):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::isBlockFlow):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::clientWidth):
+ (WebCore::RenderBox::clientHeight):
+ (WebCore::RenderBox::nodeAtPoint):
+ (WebCore::RenderBox::imageChanged):
+ (WebCore::RenderBox::offsetForPositionedInContainer):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::width):
+ (WebCore::RenderBox::height):
+ (WebCore::RenderBox::size):
+ (WebCore::RenderBox::frameRect):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::dirtyLinesFromChangedChild):
+ (WebCore::RenderFlow::createInlineBox):
+ (WebCore::RenderFlow::paintLines):
+ (WebCore::RenderFlow::hitTestLines):
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::lowestPosition):
+ (WebCore::RenderFlow::rightmostPosition):
+ (WebCore::RenderFlow::leftmostPosition):
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::borderBoundingBox):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::isRenderInline):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::intersectsDamageRect):
+ (WebCore::RenderLayer::boundingBox):
+ * rendering/RenderListItem.cpp:
+ (WebCore::getParentOfFirstLineBox):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
+ (WebCore::RenderObject::styleWillChange):
+ (WebCore::RenderObject::firstLineStyle):
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGInline.cpp:
+ (WebCore::RenderSVGInline::createInlineBox):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::createInlineBox):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::nodeAtPoint):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderText.cpp:
+ (WebCore::isInlineFlowOrEmptyText):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/bidi.cpp:
+ (WebCore::bidiNext):
+ (WebCore::bidiFirst):
+ (WebCore::appendRunsForObject):
+ (WebCore::RenderBlock::createLineBoxes):
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::inlineFlowRequiresLineBox):
+ (WebCore::requiresLineBox):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::RenderBlock::findNextLineBreak):
+
+2009-01-26 David Hyatt <hyatt@apple.com>
+
+ Drop support for display:compact.
+
+ (1) display:compact is no longer part of CSS2.1.
+ (2) Shipping Safari has completely broken compact support with severely broken rendering
+ (all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
+ (3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
+ anyone even noticing.
+
+ Reviewed by Eric Seidel
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::handleSpecialChild):
+ (WebCore::RenderBlock::handleRunInChild):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::paint):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::shouldCheckLines):
+ (WebCore::getHeightForLineCount):
+ (WebCore::RenderBlock::renderName):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::sizesToIntrinsicWidth):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::width):
+ (WebCore::RenderBox::height):
+ (WebCore::RenderBox::size):
+ (WebCore::RenderBox::frameRect):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::paintLines):
+ (WebCore::RenderFlow::hitTestLines):
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::linesBoundingBox):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isInline):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ * rendering/bidi.h:
+ (WebCore::BidiRun::BidiRun):
+
+2009-01-26 Adam Langley <agl@google.com>
+
+ Reviewed by Nikolas Zimmermann.
+
+ gtk2drawing: fix compiler warnings
+
+ g_object_set_data expects a gpointer as the last argument. Cast the
+ TRUE/FALSE values to avoid a warning.
+ gtk_tree_view_column_new doesn't return a GtkWidget.
+
+ * platform/gtk/gtk2drawing.c:
+ (setup_widget_prototype):
+ (moz_gtk_get_combo_box_inner_button):
+ (moz_gtk_get_combo_box_button_inner_widgets):
+ (ensure_combo_box_widgets):
+ (moz_gtk_get_combo_box_entry_inner_widgets):
+ (moz_gtk_get_combo_box_entry_arrow):
+ (ensure_combo_box_entry_widgets):
+ (ensure_toolbar_widget):
+ (ensure_menu_bar_item_widget):
+ (ensure_menu_popup_widget):
+ (ensure_menu_item_widget):
+ (ensure_image_menu_item_widget):
+ (ensure_menu_separator_widget):
+ (ensure_check_menu_item_widget):
+ (ensure_tree_header_cell_widget):
+ (moz_gtk_entry_paint):
+
+2009-01-26 David Hyatt <hyatt@apple.com>
+
+ Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
+ Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
+ inline as the new element's renderer.
+
+ Reviewed by Dan Bernstein
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::handleRunInChild):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::renderName):
+
+2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23480
+ Add missing method stubs to BackForwardListChromium.
+
+ * history/BackForwardListChromium.cpp:
+ (WebCore::BackForwardList::backItem):
+ (WebCore::BackForwardList::forwardItem):
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Try to fix Tiger buildbot.
+
+ * WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
+ * page/mac/WebDashboardRegion.m:
+ (typeName): Added.
+ (-[WebDashboardRegion description]): Use typeName.
+ (-[WebDashboardRegion isEqual:]): Added comment.
+
+2009-01-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23535
+ Strengthen debug checks in KURL
+
+ Covered (and prompted) by existing tests.
+
+ * platform/KURL.cpp:
+ (WebCore::checkEncodedString): Check that the first character of the URL is an allowed
+ first scheme character, not just that it isn't a slash.
+ (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
+ because of parsing being idempotent).
+
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
+ empty security origin is created.
+ (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
+ it - it is not guaranteed to be properly encoded.
+
+ * dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
+ string, it needs to be parsed into an URL, not just converted into one.
+
+ * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
+ Create the security origin with createFromString() instead of create(). I do not know where
+ the string comes from and whether it might not be properly encoded, but this change can't
+ hurt, and makes the code slightly more clear.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
+ origin with createFromString() instead of create(). The string comes from an HTTP response
+ header, so it may not be a properly encoded URL.
+
+ * loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
+ invalid URLs.
+
+ * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
+ SecurityOrigin::createFromString() (no change in behavior).
+
+2009-01-25 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ Improve the consistency of settings in our .xcconfig files.
+
+ * Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS to match other projects,
+ and handle all cases in GCC_GENERATE_DEBUGGING_SYMBOLS.
+
+2009-01-25 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
+
+ The new table code created a bug involving markAllDescendantsWithFloatsForLayout, namely that it could
+ end up marking ancestors of a block as needing layout when that block was still in the process of
+ doing a layout.
+
+ The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
+ we are "mid-layout." If this flag is set, then the method will make sure to do only local dirtying
+ of objects to avoid accidentally marking a clean ancestor as needing layout again.
+
+ Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
+ with a check of whether or not we are mid-layout being done by those methods instead.
+
+ Reviewed by Oliver Hunt
+
+ Added fast/repaint/dynamic-table-vertical-alignment-change.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+ * rendering/RenderBlock.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::removeFromObjectLists):
+ * rendering/RenderObject.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows):
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Turn on the following warnings:
+
+ -Wcast-qual
+ -Wextra-tokens
+ -Wformat=2
+ -Winit-self
+ -Wmissing-noreturn
+ -Wpacked
+ -Wrendundant-decls
+
+ * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
+ -W for clarity since we don't have to support the older versions of gcc that require the
+ old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
+ -Wno-format-y2k since we can have that one on now.
+
+2009-01-25 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
+ string hashing code when opening a Digg RSS article
+
+ Test: fast/loader/null-request-after-willSendRequest.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): Null-check the request returned from
+ the client's willSendRequest method.
+
+2009-01-25 David Hyatt <hyatt@apple.com>
+
+ Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
+ instead of the ancestor overflow (23525)
+
+ Make sure that we always call scroll() on the nearest enclosing RenderBox. No test case is possible
+ here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
+
+ Reviewed by Dan Bernstein
+
+ * page/EventHandler.cpp:
+ (WebCore::scrollAndAcceptEvent):
+ (WebCore::EventHandler::scrollOverflow):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::enclosingBox):
+ * rendering/RenderObject.h:
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
+ https://bugs.webkit.org/show_bug.cgi?id=23538
+ rdar://problem/6523719
+
+ I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
+
+ The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
+ the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
+ than doing fallback.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
+ inelegant if statement.
+ (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
+ (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
+ (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
+ return a string than an "out" parameter. Fixed the logic to only prefer the ActiveX type over the
+ type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
+ there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
+ other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
+ new havePlugin function so we handle the case where pluginData is 0.
+ (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
+ instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
+ that knows how to handle <object> elements.
+ (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
+ use this data still need to be called; they still do something even if no plug-ins are present. And
+ they have now been corrected to handle 0 properly.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ * rendering/RenderMenuList.cpp: Fix build by adding back needed include.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Fourth patch: Deal with the last few stray warnings.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
+ Also make the local variable be a RenderBlock so the cast is closer to the code
+ that guarantees it's correct.
+
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::writeStyle): Put the enum into a local variable that's a built-in
+ type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
+
+2009-01-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23522: use checked casts for render tree
+ https://bugs.webkit.org/show_bug.cgi?id=23522
+
+ Step one: RenderText.
+
+ Also change set of RenderFlow* to be a ListHashSet as the comment in the
+ header indicated.
+
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::setData): Use toRenderText.
+ (WebCore::CharacterData::appendData): Ditto.
+ (WebCore::CharacterData::insertData): Ditto.
+ (WebCore::CharacterData::deleteData): Ditto.
+ (WebCore::CharacterData::replaceData): Ditto.
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
+ (WebCore::ContainerNode::getLowerRightCorner): Ditto.
+ * dom/Position.cpp:
+ (WebCore::nextRenderedEditable): Ditto.
+ (WebCore::previousRenderedEditable): Ditto.
+ (WebCore::Position::renderedOffset): Ditto. Also use function members
+ instead of data members of InlineTextBox.
+ (WebCore::Position::upstream): Ditto.
+ (WebCore::Position::downstream): Ditto.
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
+ (WebCore::Position::inRenderedText): Ditto.
+ (WebCore::Position::isRenderedCharacter): Ditto.
+ (WebCore::searchAheadForBetterMatch): Ditto.
+ (WebCore::Position::getInlineBoxAndOffset): Ditto.
+
+ * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
+ included in RenderObject.h.
+
+ * dom/Text.cpp:
+ (WebCore::Text::splitText): Use toRenderText.
+ (WebCore::Text::recalcStyle): Ditto.
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::debugRenderer): Ditto.
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::handleTextNode): Ditto.
+ (WebCore::TextIterator::handleTextBox): Ditto.
+ (WebCore::TextIterator::emitText): Ditto.
+ (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
+
+ * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
+ no longer included in RenderObject.h.
+ * inspector/InspectorController.cpp: Ditto.
+ * page/Frame.cpp: Ditto.
+ * rendering/RenderBox.cpp: Ditto.
+ * rendering/RenderInline.cpp: Ditto.
+ * rendering/RenderPath.cpp: Ditto.
+ * rendering/RenderSVGContainer.cpp: Ditto.
+ * rendering/RenderSVGImage.cpp: Ditto.
+ * rendering/RenderSVGInlineText.cpp: Ditto.
+ * rendering/RenderSVGTSpan.cpp: Ditto.
+ * rendering/RenderSVGText.cpp: Ditto.
+ * rendering/RenderSVGTextPath.cpp: Ditto.
+ * rendering/RenderTableCell.cpp: Ditto.
+ * rendering/RenderView.cpp: Ditto.
+
+ * editing/visible_units.cpp:
+ (WebCore::startPositionForLine): Use function members instead of data
+ members of InlineTextBox.
+ (WebCore::endPositionForLine): Ditto.
+ (WebCore::startOfParagraph): Use toRenderText.
+ (WebCore::endOfParagraph): Ditto.
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::deleteLine): Ditto.
+ (WebCore::InlineTextBox::extractLine): Ditto.
+ (WebCore::InlineTextBox::attachLine): Ditto.
+ (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
+ (WebCore::InlineTextBox::paintDecoration): Ditto.
+ (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
+ (WebCore::InlineTextBox::offsetForPosition): Ditto.
+ (WebCore::InlineTextBox::positionForOffset): Ditto.
+
+ * rendering/InlineTextBox.h: Made most members private. Use toRenderText.
+
+ * rendering/RenderArena.cpp:
+ (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
+ (WebCore::RenderArena::free): Ditto.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
+ instead of RenderFlowSequencedSet.
+ (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
+ (WebCore::stripTrailingSpace): Ditto.
+ (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
+ (WebCore::RenderBlock::updateFirstLetter): Ditto.
+
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addChild): Use toRenderText.
+
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
+ instead of RenderFlowSequencedSet.
+ (WebCore::RenderFlow::paintLines): Ditto.
+
+ * rendering/RenderMenuList.cpp: Removed some unneeded includes.
+
+ * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
+ Made more members private.
+
+ * rendering/RenderObject.cpp: Updated includes.
+ (WebCore::RenderObject::isEditable): Use toRenderText.
+ (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
+ include VisiblePosition.h in the header just for this.
+
+ * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
+ Changed special vertical position values to be constants rather than an enum.
+ Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
+ data members of InlineTextBox.
+ (WebCore::RenderText::positionForCoordinates): Ditto.
+ (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
+ (WebCore::RenderText::previousCharacter): Use function members instead of
+ data members of InlineTextBox.
+ (WebCore::RenderText::position): Ditto.
+ (WebCore::RenderText::caretMinOffset): Ditto.
+ (WebCore::RenderText::caretMaxOffset): Ditto.
+ (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
+
+ * rendering/RenderText.h: Added definition of toRenderText.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<): Use toRenderText and toRenderBox.
+ (WebCore::writeTextRun): Ditto.
+ (WebCore::write): Ditto.
+
+ * rendering/bidi.cpp:
+ (WebCore::InlineIterator::increment): Use toRenderText.
+ (WebCore::InlineIterator::current): Ditto.
+ (WebCore::checkMidpoints): Ditto.
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
+ (WebCore::RenderBlock::layoutInlineChildren): Ditto.
+ (WebCore::RenderBlock::determineStartPosition): Ditto.
+ (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
+ (WebCore::RenderBlock::findNextLineBreak): Ditto.
+
+2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix gcc compiler warning (deprecated conversion from constant string to char*)
+
+ "" cannot be stored in a char*
+
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::destroyStream):
+
+2009-01-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
+
+ Changed single argument KURL constructors back to always expect an already encoded string,
+ eliminating extra conversions.
+
+ This is a rather unstable situation, as it is often unclear whether a given string is safe
+ to convert to KURL without resolving. I think that going forward, the solution is to try to
+ keep encoded URLs as KURL instances, and not as strings.
+
+ * platform/KURL.h: Updated comments.
+
+ * platform/KURL.cpp:
+ (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
+ intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
+ since encoding is scheme-dependent, such a verification would be quite complicated.
+ Don't encode the string as UTF-8, as it supposed to be ASCII-only.
+ Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
+ any reason for it to exist, but I saw several cases where this code path was taken
+ inadvertently (see examples in LayoutTests/ChangeLog).
+ (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
+ is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
+ the old one), and an already encoded string is expected by parse().
+ In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
+ (WebCore::KURL::setHost): Ditto.
+ (WebCore::KURL::setPort): Ditto.
+ (WebCore::KURL::setHostAndPort): Ditto.
+ (WebCore::KURL::setUser): Ditto.
+ (WebCore::KURL::setPass): Ditto.
+ (WebCore::KURL::setRef): Ditto.
+ (WebCore::KURL::setQuery): Ditto.
+ (WebCore::KURL::setPath): Ditto.
+ (WebCore::KURL::parse): Verify that the passed string is already encoded.
+
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::parseMappedAttribute):
+ (WebCore::HTMLLinkElement::process):
+ * html/HTMLLinkElement.h:
+ Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see
+ LayoutTests/ChangeLog).
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
+ (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
+ String to KURL conversion requires the string to be already encoded.
+
+ * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
+ HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
+ a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
+ security origin object), so I just made the code as close to what we already had as possible.
+
+2009-01-24 Darin Adler <darin@apple.com>
+
+ Try to fix Qt build.
+
+ * WebCore.pro: Added JSTextCustom.cpp.
+
+2009-01-23 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23467
+
+ Change styleAvailable functionality to be a linked list
+ rather than scanning every CompositeAnimation for
+ Animations that are waiting for styleAvailable. This has
+ potential for large performance improvement in cases where
+ there are many animations firing at once. But it will also
+ help in my next fix, which is to synchronize software and
+ accelerated animations.
+
+ I also changed slightly when the beginAnimationUpdate and
+ endAnimationUpdate calls are made. But this has no real
+ effect on performance or behavior.
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ (WebCore::Document::updateRendering):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::AnimationBase):
+ (WebCore::AnimationBase::~AnimationBase):
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::next):
+ (WebCore::AnimationBase::setNext):
+ (WebCore::AnimationBase::styleAvailable):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
+ (WebCore::AnimationControllerPrivate::addToStyleAvailableWaitList):
+ (WebCore::AnimationControllerPrivate::removeFromStyleAvailableWaitList):
+ (WebCore::AnimationControllerPrivate::styleAvailable):
+ (WebCore::AnimationController::AnimationController):
+ (WebCore::AnimationController::endAnimationUpdate):
+ (WebCore::AnimationController::addToStyleAvailableWaitList):
+ (WebCore::AnimationController::removeFromStyleAvailableWaitList):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::addToStyleAvailableWaitList):
+ (WebCore::CompositeAnimationPrivate::removeFromStyleAvailableWaitList):
+ (WebCore::CompositeAnimation::addToStyleAvailableWaitList):
+ (WebCore::CompositeAnimation::removeFromStyleAvailableWaitList):
+ * page/animation/CompositeAnimation.h:
+
+2009-01-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
+
+ Test: http/tests/xmlhttprequest/encode-request-url-2.html
+
+ * platform/KURL.cpp:
+ (WebCore::appendASCII): Added a helper function.
+ (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
+ specified behavior.
+ (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
+ stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
+ of the byte stream can use different encodings, round-tripping is not possible.
+ (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
+ this function convert the string to utf-8. I think that on the remanining code paths, it is
+ correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
+ FIXME warning.
+
+2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix after r40170
+
+ * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
+ and editing/RemoveNodeAttributeCommand.h
+
+2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build after r40205.
+
+ * WebCore.pro:
+
+2009-01-23 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
+
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+
+ * history/CachedFrame.cpp: Added.
+ (WebCore::cachedFrameCounter):
+ (WebCore::CachedFrame::CachedFrame):
+ (WebCore::CachedFrame::~CachedFrame):
+ (WebCore::CachedFrame::restore):
+ (WebCore::CachedFrame::clear):
+ (WebCore::CachedFrame::setCachedFramePlatformData):
+ (WebCore::CachedFrame::cachedFramePlatformData):
+ * history/CachedFrame.h: Added.
+ (WebCore::CachedFrame::document):
+ (WebCore::CachedFrame::documentLoader):
+ (WebCore::CachedFrame::view):
+ (WebCore::CachedFrame::mousePressNode):
+ (WebCore::CachedFrame::url):
+ (WebCore::CachedFrame::domWindow):
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ (WebCore::CachedPage::clear):
+ (WebCore::CachedPage::setCachedFramePlatformData):
+ (WebCore::CachedPage::cachedFramePlatformData):
+ * history/CachedPage.h:
+ (WebCore::CachedPage::document):
+ (WebCore::CachedPage::documentLoader):
+ (WebCore::CachedPage::view):
+ (WebCore::CachedPage::mousePressNode):
+ (WebCore::CachedPage::url):
+ (WebCore::CachedPage::domWindow):
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
+ creating a CachedPage was a historical relic. Take the opportunity to clean that up.
+
+2009-01-23 David Hyatt <hyatt@apple.com>
+
+ Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
+ that triggered the ASSERT (since all of these places are effectively regressions from my landing that
+ devirtualized width()/height()).
+
+ Reviewed by Adele
+
+ * dom/Position.cpp:
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::clientWidth):
+ (WebCore::RenderBox::clientHeight):
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+ (WebCore::RenderBox::absoluteOutlineBounds):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::width):
+ (WebCore::RenderBox::height):
+ (WebCore::RenderBox::size):
+ (WebCore::RenderBox::frameRect):
+ (WebCore::RenderBox::borderBoundingBox):
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::borderBoundingBox):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::styleWillChange):
+ * rendering/RenderScrollbarPart.h:
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::isKeyboardFocusable):
+
+2009-01-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ Second patch: Slightly less simple cases of various warnings.
+
+ * bridge/jni/jni_runtime.h:
+ (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
+ away const.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
+ reinterpret_cast; this is casting the result of malloc, and the idiom is to use
+ static_cast, which works because we're casting from void*.
+ (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
+ C-style casts.
+
+ * xml/XSLTUnicodeSort.cpp:
+ (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
+ instead of redefining the function.
+
+2009-01-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
+ https://bugs.webkit.org/show_bug.cgi?id=23475
+
+ * editing/TextIterator.cpp:
+ (WebCore::SearchBuffer::search): Set the character start flag to false to
+ ensure we won't ever return the same result twice. There are other ways we
+ could accomplish this, mentioned in the comment, but this one was the smallest
+ and cleanest I could think of.
+
+2009-01-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
+ https://bugs.webkit.org/show_bug.cgi?id=23510
+
+ That patch fixed the optimization that's supposed to give a faster path for
+ allocating the wrappers for DOM Text objects. But CDATASection is the one
+ subclass of Text objects.
+
+ * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
+ (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
+ for CDATASection. We don't want to have to check when creating a wrapper for a
+ Text object whether it's a CDATASection object or not, so we need to do this overload
+ at compile time.
+
+2009-01-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Eric Seidel.
+
+ Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
+ WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
+
+ WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
+ Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
+ from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
+ base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
+ another base class, just like FormControlElement.
+
+ Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
+ HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
+ objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
+
+ Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
+ Add new virtual function isFormControlElementWithState() to Element.h.
+
+ * GNUmakefile.am:
+ * WebCore.order:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/Document.cpp:
+ (WebCore::Document::formElementsState):
+ * dom/Document.h:
+ (WebCore::Document::registerFormElementWithState):
+ (WebCore::Document::unregisterFormElementWithState):
+ * dom/Element.h:
+ (WebCore::Element::isFormControlElement):
+ (WebCore::Element::isFormControlElementWithState):
+ * dom/FormControlElement.cpp:
+ (WebCore::toFormControlElement):
+ * dom/FormControlElement.h:
+ * dom/FormControlElementWithState.cpp: Added.
+ (WebCore::FormControlElementWithState::registerFormControlElementWithState):
+ (WebCore::FormControlElementWithState::unregisterFormControlElementWithState):
+ (WebCore::FormControlElementWithState::finishParsingChildren):
+ (WebCore::toFormControlElementWithState):
+ * dom/FormControlElementWithState.h: Added.
+ (WebCore::FormControlElementWithState::~FormControlElementWithState):
+ (WebCore::FormControlElementWithState::FormControlElementWithState):
+ * html/HTMLElement.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
+ (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
+ (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
+ (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
+ * html/HTMLFormControlElement.h:
+ (WebCore::HTMLFormControlElement::isFormControlElement):
+ (WebCore::HTMLFormControlElementWithState::isFormControlElementWithState):
+ (WebCore::HTMLFormControlElementWithState::toFormControlElement):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::formElementIndex):
+ * html/HTMLLabelElement.cpp:
+ (WebCore::HTMLLabelElement::correspondingControl):
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::formElement):
+ * page/Frame.cpp:
+ (WebCore::Frame::searchForLabelsBeforeElement):
+ (WebCore::scanForForm):
+ (WebCore::Frame::currentForm):
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::searchForLabelsBeforeElement):
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::parseMappedAttribute):
+ (WebCore::WMLCardElement::insertedIntoDocument):
+ * wml/WMLCardElement.h:
+ * wml/WMLDoElement.cpp:
+ (WebCore::WMLDoElement::insertedIntoDocument):
+ * wml/WMLElement.h:
+ (WebCore::WMLElement::isWMLElement):
+ * wml/WMLEventHandlingElement.cpp:
+ (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
+ (WebCore::WMLEventHandlingElement::registerDoElement):
+ (WebCore::toWMLEventHandlingElement):
+ * wml/WMLEventHandlingElement.h:
+ * wml/WMLFormControlElement.cpp: Added.
+ (WebCore::WMLFormControlElement::WMLFormControlElement):
+ (WebCore::WMLFormControlElement::~WMLFormControlElement):
+ (WebCore::WMLFormControlElementWithState::WMLFormControlElementWithState):
+ (WebCore::WMLFormControlElementWithState::~WMLFormControlElementWithState):
+ * wml/WMLFormControlElement.h: Added.
+ (WebCore::WMLFormControlElement::isFormControlElement):
+ (WebCore::WMLFormControlElement::valueMatchesRenderer):
+ (WebCore::WMLFormControlElement::setValueMatchesRenderer):
+ (WebCore::WMLFormControlElement::name):
+ (WebCore::WMLFormControlElementWithState::isFormControlElementWithState):
+ (WebCore::WMLFormControlElementWithState::toFormControlElement):
+ * wml/WMLInputElement.cpp:
+ (WebCore::WMLInputElement::WMLInputElement):
+ (WebCore::WMLInputElement::type):
+ * wml/WMLInputElement.h:
+ * wml/WMLOnEventElement.cpp:
+ (WebCore::WMLOnEventElement::registerTask):
+ * wml/WMLOptGroupElement.cpp:
+ (WebCore::WMLOptGroupElement::WMLOptGroupElement):
+ (WebCore::WMLOptGroupElement::type):
+ * wml/WMLOptGroupElement.h:
+ * wml/WMLOptionElement.cpp:
+ (WebCore::WMLOptionElement::WMLOptionElement):
+ (WebCore::WMLOptionElement::type):
+ * wml/WMLOptionElement.h:
+ * wml/WMLTemplateElement.cpp:
+ (WebCore::WMLTemplateElement::WMLTemplateElement):
+ (WebCore::WMLTemplateElement::parseMappedAttribute):
+ * wml/WMLTemplateElement.h:
+
+2009-01-23 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
+ https://bugs.webkit.org/show_bug.cgi?id=23509
+
+ Add null checking in makeRange instead of AX code
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::makeRange):
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::nextSentenceEndPosition):
+ (WebCore::AccessibilityObject::previousSentenceStartPosition):
+
+2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Gtk build too after removal of RenderBox::toConstRenderBox
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::baselinePosition):
+
+2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::baselinePosition):
+
+2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build after r40168.
+
+ * WebCore.pro:
+
+2009-01-23 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Darin Adler
+
+ Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
+
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.order:
+ * WebCore.xcodeproj/project.pbxproj:
+
+ * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
+ (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
+ * history/CachedPagePlatformData.h: Removed.
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::clear):
+ (WebCore::CachedPage::setCachedFramePlatformData):
+ (WebCore::CachedPage::cachedFramePlatformData):
+ * history/CachedPage.h:
+
+2009-01-23 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Fix drawing in situations where sub-portions of the bitmap are to be
+ drawn to the screen.
+
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+
+2009-01-23 Kevin Ollivier <kevino@theolliviers.com>
+
+ Build fixes for recent changes.
+
+ * WebCoreSources.bkl:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::invalidateWindowlessPluginRect):
+
+2009-01-23 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele Peterson
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23407
+
+ Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
+ is never hidden (as with an <audio> element).
+
+ Test: media/video-controls-visible-audio-only.html
+
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+ (WebCore::MediaPlayerPrivate::hasVideo):
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::hasVideo):
+ * platform/graphics/win/QTMovieWin.h:
+
+2009-01-23 David Hyatt <hyatt@apple.com>
+
+ Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::sizingBox):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ (WebCore::ContainerNode::getLowerRightCorner):
+ * dom/Element.cpp:
+ (WebCore::Element::scrollByUnits):
+ * dom/Position.cpp:
+ (WebCore::endsOfNodeAreVisuallyDistinctPositions):
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
+ (WebCore::Position::isCandidate):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+ * editing/EditorCommand.cpp:
+ (WebCore::verticalScrollDistance):
+ * editing/TextIterator.cpp:
+ (WebCore::shouldEmitExtraNewlineForNode):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::isFocusable):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::width):
+ (WebCore::HTMLFrameElementBase::height):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseDraggedEvent):
+ (WebCore::EventHandler::autoscrollTimerFired):
+ (WebCore::EventHandler::updateAutoscrollRenderer):
+ (WebCore::EventHandler::stopAutoscrollTimer):
+ (WebCore::EventHandler::scrollOverflow):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::adjustPosition):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::renderBox):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::clearFloats):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ * rendering/RenderBox.h:
+ (WebCore::toRenderBox):
+ (WebCore::RenderBox::previousSiblingBox):
+ (WebCore::RenderBox::nextSiblingBox):
+ (WebCore::RenderBox::parentBox):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::resize):
+ (WebCore::RenderLayer::boundingBox):
+ * rendering/RenderObject.cpp:
+ (WebCore::addLayers):
+ (WebCore::RenderObject::removeLayers):
+ (WebCore::RenderObject::moveLayers):
+ (WebCore::RenderObject::findNextLayer):
+ (WebCore::RenderObject::enclosingLayer):
+ (WebCore::RenderObject::setNeedsLayout):
+ (WebCore::RenderObject::setNeedsPositionedMovementLayout):
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::absoluteToLocal):
+ (WebCore::RenderObject::localToAbsoluteQuad):
+ (WebCore::RenderObject::offsetFromContainer):
+ (WebCore::RenderObject::removeFromObjectLists):
+ (WebCore::RenderObject::destroy):
+ (WebCore::RenderObject::updateHitTestResult):
+ (WebCore::RenderObject::addDashboardRegions):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::hitTestMediaControlPart):
+ (WebCore::RenderTheme::baselinePosition):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::hitTestMediaControlPart):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::externalRepresentation):
+ * rendering/bidi.cpp:
+ (WebCore::inlineWidth):
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::requiresLineBox):
+ (WebCore::RenderBlock::findNextLineBreak):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::isKeyboardFocusable):
+ * wml/WMLInputElement.cpp:
+ (WebCore::isInputFocusable):
+
+2009-01-23 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
+ https://bugs.webkit.org/show_bug.cgi?id=23509
+
+ Add null checking around next/previous sentence retrieval in AX code
+
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::nextSentenceEndPosition):
+ (WebCore::AccessibilityObject::previousSentenceStartPosition):
+
+2009-01-23 David Hyatt <hyatt@apple.com>
+
+ Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
+
+ Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
+ method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
+ since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
+
+ For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
+ well.
+
+ Reviewed by Oliver Hunt
+
+ * WebCore.base.exp:
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ (WebCore::ContainerNode::getLowerRightCorner):
+ * dom/Position.cpp:
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::linesBoundingBox):
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::offsetWidth):
+ (WebCore::RenderInline::offsetHeight):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::linesBoundingBox):
+ * rendering/RenderText.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::write):
+
+2009-01-23 David Hyatt <hyatt@apple.com>
+
+ Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
+ to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
+ RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
+ RenderText, since none of the work done in styleWillChange was relevant to text nodes.
+
+ Reviewed by Sam Weinig
+
+ * dom/Document.cpp:
+ (WebCore::Document::elementFromPoint):
+ (WebCore::Document::renderView):
+ (WebCore::Document::prepareMouseEvent):
+ * dom/Document.h:
+ * dom/Element.cpp:
+ (WebCore::Element::scrollByUnits):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::contains):
+ * html/HTMLMarqueeElement.cpp:
+ (WebCore::HTMLMarqueeElement::start):
+ (WebCore::HTMLMarqueeElement::stop):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::topRenderer):
+ (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
+ (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
+ * page/AccessibilityRenderObject.h:
+ * page/EventHandler.cpp:
+ (WebCore::scrollAndAcceptEvent):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseDraggedEvent):
+ (WebCore::EventHandler::updateSelectionForMouseDrag):
+ (WebCore::EventHandler::autoscrollTimerFired):
+ (WebCore::EventHandler::updateAutoscrollRenderer):
+ (WebCore::EventHandler::stopAutoscrollTimer):
+ (WebCore::EventHandler::scrollOverflow):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::hoverTimerFired):
+ * page/Frame.cpp:
+ (WebCore::Frame::clearTimers):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleWillChange):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::verticalScrollbarWidth):
+ (WebCore::RenderBox::horizontalScrollbarHeight):
+ (WebCore::RenderBox::scroll):
+ (WebCore::RenderBox::canBeProgramaticallyScrolled):
+ (WebCore::RenderBox::autoscroll):
+ (WebCore::RenderBox::panScroll):
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::layer):
+ (WebCore::RenderBox::requiresLayer):
+ (WebCore::RenderBox::stopAutoscroll):
+ (WebCore::RenderBox::hasAutoVerticalScrollbar):
+ (WebCore::RenderBox::hasAutoHorizontalScrollbar):
+ (WebCore::RenderBox::scrollsOverflow):
+ (WebCore::RenderBox::scrollsOverflowX):
+ (WebCore::RenderBox::scrollsOverflowY):
+ (WebCore::RenderBox::includeVerticalScrollbarSize):
+ (WebCore::RenderBox::includeHorizontalScrollbarSize):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::addFocusRingRects):
+ * rendering/RenderForeignObject.cpp:
+ * rendering/RenderForeignObject.h:
+ (WebCore::RenderForeignObject::requiresLayer):
+ * rendering/RenderInline.cpp:
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::requiresLayer):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::childrenClipRect):
+ (WebCore::RenderLayer::selfClipRect):
+ * rendering/RenderListBox.cpp:
+ * rendering/RenderListBox.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::addLayers):
+ (WebCore::RenderObject::removeLayers):
+ (WebCore::RenderObject::moveLayers):
+ (WebCore::RenderObject::findNextLayer):
+ (WebCore::RenderObject::enclosingLayer):
+ (WebCore::RenderObject::setNeedsLayout):
+ (WebCore::RenderObject::setNeedsPositionedMovementLayout):
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+ (WebCore::RenderObject::styleWillChange):
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::absoluteToLocal):
+ (WebCore::RenderObject::localToAbsoluteQuad):
+ (WebCore::RenderObject::offsetFromContainer):
+ (WebCore::RenderObject::destroy):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ * rendering/RenderPath.h:
+ (WebCore::RenderPath::requiresLayer):
+ * rendering/RenderReplica.h:
+ (WebCore::RenderReplica::requiresLayer):
+ * rendering/RenderSVGContainer.cpp:
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::requiresLayer):
+ * rendering/RenderSVGHiddenContainer.cpp:
+ * rendering/RenderSVGHiddenContainer.h:
+ (WebCore::RenderSVGHiddenContainer::requiresLayer):
+ * rendering/RenderSVGImage.cpp:
+ * rendering/RenderSVGImage.h:
+ (WebCore::RenderSVGImage::requiresLayer):
+ * rendering/RenderSVGInline.h:
+ (WebCore::RenderSVGInline::requiresLayer):
+ * rendering/RenderSVGInlineText.h:
+ (WebCore::RenderSVGInlineText::requiresLayer):
+ * rendering/RenderSVGText.cpp:
+ * rendering/RenderSVGText.h:
+ (WebCore::RenderSVGText::requiresLayer):
+ * rendering/RenderScrollbarPart.h:
+ (WebCore::RenderScrollbarPart::requiresLayer):
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::setCurrentPosition):
+ * rendering/RenderTableCell.cpp:
+ * rendering/RenderTableCell.h:
+ (WebCore::RenderTableCell::requiresLayer):
+ * rendering/RenderTableCol.h:
+ (WebCore::RenderTableCol::requiresLayer):
+ * rendering/RenderTableRow.h:
+ (WebCore::RenderTableRow::requiresLayer):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows):
+ * rendering/RenderText.h:
+ (WebCore::RenderText::styleWillChange):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::autoscroll):
+ (WebCore::RenderTextControl::scroll):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ (WebCore::externalRepresentation):
+
+2009-01-23 Anders Carlsson <andersca@apple.com>
+
+ Fix tyop.
+
+ * editing/markup.cpp:
+ (WebCore::joinMarkups):
+
+2009-01-23 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * Configurations/Base.xcconfig:
+ Fix GCC 4.0 build.
+
+ * editing/markup.cpp:
+ (WebCore::joinMarkups):
+ Pass a const reference to the vector.
+
+ * html/HTMLElement.cpp:
+ * platform/text/String.cpp:
+ Add comments indicating that these functions are for use in the debugger.
+
+2009-01-23 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Turn on -Wmissing-prototypes and fix the resulting warnings.
+
+ * Configurations/Base.xcconfig:
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::nonCachingStaticBackFunctionGetter):
+ (WebCore::nonCachingStaticForwardFunctionGetter):
+ (WebCore::nonCachingStaticGoFunctionGetter):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::nonCachingStaticReplaceFunctionGetter):
+ (WebCore::nonCachingStaticReloadFunctionGetter):
+ (WebCore::nonCachingStaticAssignFunctionGetter):
+ (WebCore::JSLocation::customGetOwnPropertySlot):
+ * bindings/objc/DOMRGBColor.mm:
+ (WebCore::getWrapperForRGB):
+ (WebCore::setWrapperForRGB):
+ (WebCore::removeWrapperForRGB):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::globalExceptionString):
+ * bridge/runtime_object.cpp:
+ (JSC::callRuntimeConstructor):
+ * css/CSSParser.cpp:
+ (WebCore::parseGradientColorStop):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::scaleFactorForConversion):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::operator >):
+ (WebCore::operator <=):
+ (WebCore::getTransformOperationType):
+ * dom/make_names.pl:
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::updatePositionForTextRemoval):
+ * editing/EditorCommand.cpp:
+ (WebCore::valueBackColor):
+ (WebCore::valueFontName):
+ (WebCore::valueFontSize):
+ (WebCore::valueFontSizeDelta):
+ (WebCore::valueForeColor):
+ * editing/VisiblePosition.cpp:
+ (WebCore::canonicalizeCandidate):
+ * editing/htmlediting.cpp:
+ * editing/markup.cpp:
+ (WebCore::joinMarkups):
+ * html/HTMLElement.cpp:
+ (WebCore::inlineTagList):
+ (WebCore::blockTagList):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::serializeTimeOffset):
+ (WebCore::parseTimeOffset):
+ * page/mac/FrameMac.mm:
+ (WebCore::regExpForLabels):
+ * platform/Arena.cpp:
+ * platform/graphics/Color.cpp:
+ (WebCore::colorFloatToRGBAByte):
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::imageSourceOptions):
+ * platform/graphics/cg/PathCG.cpp:
+ (WebCore::CGPathApplierToPathApplier):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::initFontData):
+ * platform/mac/PlatformMouseEventMac.mm:
+ * platform/text/String.cpp:
+ * rendering/RenderBlock.cpp:
+ (WebCore::continuationOutlineTable):
+ (WebCore::getHeightForLineCount):
+ * rendering/RenderView.cpp:
+ (WebCore::rendererAfterPosition):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::isEditableLeaf):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::hasFractions):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::positionedObjectMoved):
+ * svg/SVGFont.cpp:
+ (WebCore::floatWidthUsingSVGFontCallback):
+ (WebCore::floatWidthMissingGlyphCallback):
+ (WebCore::drawTextUsingSVGFontCallback):
+ (WebCore::drawTextMissingGlyphCallback):
+ * svg/SVGTransformable.cpp:
+ (WebCore::parseTransformParamList):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::operator<<):
+ * xml/XPathGrammar.y:
+ * xml/XSLTExtensions.cpp:
+
+2009-01-23 Eric Seidel <eric@webkit.org>
+
+ No review, removing an empty file.
+
+ Remove RemoveNodeAttributeCommand since it was empty.
+
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * editing/RemoveNodeAttributeCommand.cpp: Removed.
+ * editing/RemoveNodeAttributeCommand.h: Removed.
+
+2009-01-23 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Sam Weinig
+
+ Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+
+ * bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
+ (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
+ (WebCore::ScriptCachedFrameData::domWindow):
+ (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
+ (WebCore::ScriptCachedFrameData::restore):
+ (WebCore::ScriptCachedFrameData::clear):
+ * bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
+ * bindings/js/ScriptCachedPageData.cpp: Removed.
+ * bindings/js/ScriptCachedPageData.h: Removed.
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ * history/CachedPage.h:
+
+2009-01-23 Steve Falkenburg <sfalken@apple.com>
+
+ Fix build.
+
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::baselinePosition):
+
+2009-01-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23506
+ Upstream Chromium's image decoders for use with PLATFORM(SKIA)
+
+ * platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
+ * platform/image-decoders/skia/BMPImageDecoder.h: Added.
+ * platform/image-decoders/skia/BMPImageReader.cpp: Added.
+ * platform/image-decoders/skia/BMPImageReader.h: Added.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
+ (WebCore::GIFImageDecoderPrivate::decode):
+ (WebCore::GIFImageDecoderPrivate::getColorMap):
+ (WebCore::GIFImageDecoder::GIFImageDecoder):
+ (WebCore::GIFImageDecoder::isSizeAvailable):
+ (WebCore::GIFImageDecoder::frameCount):
+ (WebCore::GIFImageDecoder::frameBufferAtIndex):
+ (WebCore::GIFImageDecoder::clearFrameBufferCache):
+ (WebCore::GIFImageDecoder::decode):
+ (WebCore::GIFImageDecoder::sizeNowAvailable):
+ (WebCore::GIFImageDecoder::initFrameBuffer):
+ (WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
+ (WebCore::GIFImageDecoder::haveDecodedRow):
+ (WebCore::GIFImageDecoder::frameComplete):
+ * platform/image-decoders/skia/GIFImageDecoder.h:
+ (WebCore::GIFImageDecoder::filenameExtension):
+ (WebCore::GIFImageDecoder::frameDurationAtIndex):
+ (WebCore::GIFImageDecoder::):
+ * platform/image-decoders/skia/GIFImageReader.cpp:
+ (GIFImageReader::do_lzw):
+ (GIFImageReader::read):
+ * platform/image-decoders/skia/GIFImageReader.h:
+ * platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
+ * platform/image-decoders/skia/ICOImageDecoder.h: Added.
+ * platform/image-decoders/skia/ImageDecoder.h:
+ (WebCore::RefCountedNativeImageSkia::create):
+ (WebCore::RefCountedNativeImageSkia::bitmap):
+ (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
+ (WebCore::RGBA32Buffer::):
+ (WebCore::RGBA32Buffer::RGBA32Buffer):
+ (WebCore::RGBA32Buffer::~RGBA32Buffer):
+ (WebCore::RGBA32Buffer::operator=):
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::RGBA32Buffer::copyBitmapData):
+ (WebCore::RGBA32Buffer::bitmap):
+ (WebCore::RGBA32Buffer::setSize):
+ (WebCore::RGBA32Buffer::width):
+ (WebCore::RGBA32Buffer::height):
+ (WebCore::RGBA32Buffer::rect):
+ (WebCore::RGBA32Buffer::status):
+ (WebCore::RGBA32Buffer::duration):
+ (WebCore::RGBA32Buffer::disposalMethod):
+ (WebCore::RGBA32Buffer::hasAlpha):
+ (WebCore::RGBA32Buffer::setRect):
+ (WebCore::RGBA32Buffer::setStatus):
+ (WebCore::RGBA32Buffer::setDuration):
+ (WebCore::RGBA32Buffer::setDisposalMethod):
+ (WebCore::RGBA32Buffer::setHasAlpha):
+ (WebCore::RGBA32Buffer::setRGBA):
+ (WebCore::ImageDecoder::ImageDecoder):
+ (WebCore::ImageDecoder::~ImageDecoder):
+ (WebCore::ImageDecoder::setData):
+ (WebCore::ImageDecoder::isSizeAvailable):
+ (WebCore::ImageDecoder::size):
+ (WebCore::ImageDecoder::frameCount):
+ (WebCore::ImageDecoder::repetitionCount):
+ (WebCore::ImageDecoder::supportsAlpha):
+ (WebCore::ImageDecoder::failed):
+ (WebCore::ImageDecoder::setFailed):
+ (WebCore::ImageDecoder::clearFrameBufferCache):
+ (WebCore::ImageDecoder::setSize):
+ (WebCore::ImageDecoder::isOverSize):
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp:
+ (WebCore::JPEGImageReader::JPEGImageReader):
+ (WebCore::JPEGImageReader::decode):
+ (WebCore::JPEGImageDecoder::isSizeAvailable):
+ (WebCore::JPEGImageDecoder::outputScanlines):
+ * platform/image-decoders/skia/JPEGImageDecoder.h:
+ (WebCore::JPEGImageDecoder::filenameExtension):
+ (WebCore::JPEGImageDecoder::supportsAlpha):
+ (WebCore::JPEGImageDecoder::reader):
+ * platform/image-decoders/skia/PNGImageDecoder.cpp:
+ (WebCore::PNGImageReader::close):
+ (WebCore::PNGImageDecoder::PNGImageDecoder):
+ (WebCore::PNGImageDecoder::isSizeAvailable):
+ (WebCore::PNGImageDecoder::frameBufferAtIndex):
+ (WebCore::PNGImageDecoder::decode):
+ (WebCore::PNGImageDecoder::decodingFailed):
+ (WebCore::PNGImageDecoder::headerAvailable):
+ (WebCore::rowAvailable):
+ (WebCore::PNGImageDecoder::rowAvailable):
+ (WebCore::PNGImageDecoder::pngComplete):
+ * platform/image-decoders/skia/PNGImageDecoder.h:
+ (WebCore::PNGImageDecoder::filenameExtension):
+ (WebCore::PNGImageDecoder::reader):
+ * platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
+ * platform/image-decoders/skia/XBMImageDecoder.h: Added.
+
+2009-01-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23506
+ Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
+
+ * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
+
+2009-01-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23506
+ Copy existing image-decoders in preparation for landing Skia changes on top.
+
+ * platform/image-decoders/skia: Added.
+ * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
+ * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
+ * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
+ * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
+ * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
+ * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
+ * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
+ * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
+
+2009-01-23 Holger Freyther <zecke@selfish.org>
+
+ Unreviewed build fix.
+
+ Based on https://bugs.webkit.org/show_bug.cgi?id=23498
+ from craig.schlenter@gmail.com
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::baselinePosition):
+
+2009-01-23 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 22720: Make XMLHttpRequest work in Workers
+ <https://bugs.webkit.org/show_bug.cgi?id=22720>
+
+ Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
+ data to be passed across threads.
+
+ No observable change in behavior, so no test.
+
+ * platform/network/FormData.cpp:
+ (WebCore::FormData::deepCopy):
+ * platform/network/FormData.h:
+ * platform/network/HTTPHeaderMap.cpp:
+ (WebCore::HTTPHeaderMap::copyData):
+ (WebCore::HTTPHeaderMap::adopt):
+ * platform/network/HTTPHeaderMap.h:
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::adopt):
+ (WebCore::ResourceRequestBase::copyData):
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::adopt):
+ (WebCore::ResourceResponseBase::copyData):
+ * platform/network/ResourceResponseBase.h:
+
+2009-01-23 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23374
+ Add WorkerRunLoop to encapsulate message queue and timer heap.
+ This is first half (timer heap is added as separate patch).
+
+ * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
+ * WebCore.vcproj/WebCore.vcproj: Same as above.
+ * WebCore.xcodeproj/project.pbxproj: Same as above
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::postTask):
+ * dom/WorkerContext.h:
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
+ (WebCore::WorkerMessagingProxy::workerThreadCreated):
+ * dom/WorkerRunLoop.cpp: Added.
+ (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
+ (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
+ (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
+ * dom/WorkerRunLoop.h: Added.
+ (WebCore::WorkerRunLoop::WorkerRunLoop):
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::workerThread):
+ (WebCore::WorkerThread::stop):
+ * dom/WorkerThread.h:
+ (WebCore::WorkerThread::runLoop):
+
+2009-01-23 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Holger Hans Peter Freyther.
+
+ Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
+ huge memory leak by ensuring that the timer is fired one last time on
+ application tear down thus triggering the GCController thereby freeing
+ JavaScript objects as well as triggering other timer based tear down methods.
+
+ * platform/qt/SharedTimerQt.cpp:
+ (WebCore::SharedTimerQt::~SharedTimerQt):
+
+2009-01-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23459
+ Workers are not properly terminated if execution hasn't begun yet
+
+ Doesn't affect observable behavior, so test case is not possible.
+
+ * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
+ it couldn't be called earlier.
+
+2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ [Qt] Fix the build after RenderBox refactoring in r40153.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::baselinePosition):
+
+2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Fix the build after RenderBox refactoring in r40153.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::invalidateWindowlessPluginRect):
+
+2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Simplify the assertion.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::getWindowsContext):
+ (WebCore::GraphicsContext::releaseWindowsContext):
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Move the border and padding methods from RenderObject to RenderBox.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::createDeletionUI):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::borderLeft):
+ (WebCore::InlineFlowBox::borderRight):
+ (WebCore::InlineFlowBox::paddingLeft):
+ (WebCore::InlineFlowBox::paddingRight):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::clearFloats):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paddingTop):
+ (WebCore::RenderBox::paddingBottom):
+ (WebCore::RenderBox::paddingLeft):
+ (WebCore::RenderBox::paddingRight):
+ (WebCore::RenderBox::calcHeight):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteHorizontalValues):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteVerticalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::borderTop):
+ (WebCore::RenderBox::borderBottom):
+ (WebCore::RenderBox::borderLeft):
+ (WebCore::RenderBox::borderRight):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ * rendering/RenderObject.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textBlockWidth):
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::calcPrefWidths):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::repaintViewRectangle):
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
+ other margin functions that have to come along for the ride).
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * editing/TextIterator.cpp:
+ (WebCore::shouldEmitExtraNewlineForNode):
+ * rendering/InlineBox.cpp:
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::renderBox):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::marginLeft):
+ (WebCore::InlineFlowBox::marginRight):
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::isSelfCollapsingBlock):
+ (WebCore::RenderBlock::adjustPositionedBlock):
+ (WebCore::RenderBlock::handleCompactChild):
+ (WebCore::RenderBlock::estimateVerticalPosition):
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::RenderBlock::calcInlinePrefWidths):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcHeight):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
+ (WebCore::RenderBox::hasHorizontalBordersOrPadding):
+ (WebCore::RenderBox::marginTop):
+ (WebCore::RenderBox::marginBottom):
+ (WebCore::RenderBox::marginLeft):
+ (WebCore::RenderBox::marginRight):
+ (WebCore::RenderBox::isSelfCollapsingBlock):
+ (WebCore::RenderBox::collapsedMarginTop):
+ (WebCore::RenderBox::collapsedMarginBottom):
+ (WebCore::RenderBox::isTopMarginQuirk):
+ (WebCore::RenderBox::isBottomMarginQuirk):
+ (WebCore::RenderBox::maxTopMargin):
+ (WebCore::RenderBox::maxBottomMargin):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::lineHeight):
+ (WebCore::RenderSVGContainer::baselinePosition):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::calcHeight):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::baselinePosition):
+ * rendering/bidi.cpp:
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::inlineWidth):
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::inlineFlowRequiresLineBox):
+ (WebCore::requiresLineBox):
+ (WebCore::RenderBlock::findNextLineBreak):
+
+2009-01-22 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Anders Carlsson.
+
+ Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
+
+ Current versions of Xcode only respect it for C and Objective-C files,
+ and our code doesn't currently compile if it is applied to C++ and
+ Objective-C++ files.
+
+ * Configurations/Base.xcconfig:
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
+ intrinsicPaddingBottom just be normal non-bitfield values.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::RenderFlow):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::RenderTableCell):
+ (WebCore::RenderTableCell::updateWidth):
+ (WebCore::RenderTableCell::layout):
+ * rendering/RenderTableCell.h:
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
+ Make m_frameRect private.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paint):
+ (WebCore::RenderBlock::clearFloats):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::offsetTop):
+ (WebCore::RenderBox::nodeAtPoint):
+ (WebCore::RenderBox::paint):
+ (WebCore::RenderBox::paintCustomHighlight):
+ (WebCore::RenderBox::containingBlockWidth):
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ (WebCore::RenderBox::repaintDuringLayoutIfMoved):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::layout):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::paint):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::paintReplaced):
+ (WebCore::RenderImage::nodeAtPoint):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ (WebCore::RenderListMarker::getRelativeMarkerRect):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::paint):
+ (WebCore::RenderReplaced::shouldPaint):
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::paint):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::applyContentTransforms):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::absoluteTransform):
+ (WebCore::RenderSVGRoot::nodeAtPoint):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::calcWidth):
+ (WebCore::RenderTable::layout):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::paint):
+ (WebCore::RenderTableCell::paintBackgroundsBehindCell):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::setCellWidths):
+ (WebCore::RenderTableSection::calcRowHeight):
+ (WebCore::RenderTableSection::layoutRows):
+ (WebCore::RenderTableSection::paint):
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23487.
+
+ This patch completely reworks vertical alignment of table cells. The current system uses methods called borderTopExtra() and borderBottomExtra() to
+ add extra space above and below the content of a cell. This system was not confined to the table code and spilled out into all the other RenderObjects.
+ The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra(). height()
+ also excluded the extra space, so did not accurately reflect the true size of the cell.
+
+ With the new system, the table cell box is completely accurate. The extra space becomes part of the padding of the cell. Padding has been reworked so that
+ additional intrinsic padding can be added on to the specified padding from style. Only the table code has to deal with the extra cell padding.
+
+ localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.
+
+ A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding. This ensures that getComputedStyle continues
+ to give the right answer.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getLowerRightCorner):
+ * editing/visible_units.cpp:
+ (WebCore::previousLinePosition):
+ (WebCore::nextLinePosition):
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::overflowRect):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
+ The expandsToEncloseOverhangingFloats logic has been reworked. Table cells and fieldsets did not properly handle floats that spilled into the bottom padding. The
+ resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float. The switch to make the extra table cell
+ space into padding exposed this issue. No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
+ this change.
+
+ (WebCore::RenderBlock::selectionGapRects):
+ (WebCore::RenderBlock::paintSelection):
+ (WebCore::RenderBlock::fillSelectionGaps):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::offsetForContents):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderBlock.h:
+ Add the new simplified method for expanding to encompass overhanging floats. The method has been devirtualized and made to include all of the cases (and not just a subset).
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::absoluteRects):
+ (WebCore::RenderBox::absoluteQuads):
+ (WebCore::RenderBox::absoluteContentBox):
+ (WebCore::RenderBox::paintBoxDecorations):
+ (WebCore::RenderBox::paintMask):
+ (WebCore::RenderBox::getOverflowClipRect):
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::absoluteToLocal):
+ (WebCore::RenderBox::localToAbsoluteQuad):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::y):
+ (WebCore::RenderBox::location):
+ (WebCore::RenderBox::borderBoxRect):
+ (WebCore::RenderBox::offsetHeight):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addLineBoxRects):
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::paintBoxDecorations):
+ (WebCore::RenderFieldset::paintMask):
+ * rendering/RenderFieldset.h:
+ (WebCore::RenderFieldset::avoidsFloats):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::localCaretRect):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::boundingBox):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::isPointInOverflowControl):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::absoluteToLocal):
+ (WebCore::RenderObject::localToAbsoluteQuad):
+ (WebCore::RenderObject::offsetFromContainer):
+ (WebCore::RenderObject::paddingTop):
+ (WebCore::RenderObject::paddingBottom):
+ (WebCore::RenderObject::paddingLeft):
+ (WebCore::RenderObject::paddingRight):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::hasOverhangingFloats):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::selectionRect):
+ (WebCore::RenderReplaced::localSelectionRect):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls. Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating
+ whether or not the intrinsic padding of an object should be included (by default it is). getComputedStyle needs to exclude it, which is why this argument is
+ necessary.
+
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::RenderTableCell):
+ (WebCore::RenderTableCell::paddingTop):
+ (WebCore::RenderTableCell::paddingBottom):
+ The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.
+
+ (WebCore::RenderTableCell::setOverrideSize):
+ When a table's override size gets altered, the intrinsic padding needs to be cleared.
+
+ (WebCore::RenderTableCell::absoluteClippedOverflowRect):
+ (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
+ (WebCore::RenderTableCell::baselinePosition):
+ (WebCore::RenderTableCell::paint):
+ (WebCore::RenderTableCell::paintBackgroundsBehindCell):
+ (WebCore::RenderTableCell::paintBoxDecorations):
+ (WebCore::RenderTableCell::paintMask):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderTableCell.h:
+ (WebCore::RenderTableCell::setIntrinsicPaddingTop):
+ (WebCore::RenderTableCell::setIntrinsicPaddingBottom):
+ (WebCore::RenderTableCell::setIntrinsicPadding):
+ (WebCore::RenderTableCell::clearIntrinsicPadding):
+ (WebCore::RenderTableCell::intrinsicPaddingTop):
+ (WebCore::RenderTableCell::intrinsicPaddingBottom):
+ Add new helper methods for getting/setting a cell's intrinsic padding.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::calcRowHeight):
+ calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing. Because a cell now includes that
+ extra space, it has to be subtracted out in this method.
+
+ (WebCore::RenderTableSection::layoutRows):
+ Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes. There was also an error where the baseline
+ position mismatched leading to negative intrinsic padding being added in (this error exists in ToT). The code now properly ignores cells that don't establish
+ a baseline. A number of tests progress with this change.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::addLineBoxRects):
+ Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
+
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ (WebCore::writeTextRun):
+ Modify the render tree dumping code to continue to produce the same results as before. This is really a hack, since we're now capable of indicating the correct
+ position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is). A future patch can remove these hacks so that the
+ layout test results can all be regenerated.
+
+2009-01-22 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove <strong>/<em> tags when toggling bold/italic since IE inserts them instead of <b>/<i>
+ https://bugs.webkit.org/show_bug.cgi?id=23486
+
+ Test: editing/execCommand/toggle-styles.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::isHTMLStyleNode):
+
+2009-01-22 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Remove <span> turds left by editing commands
+ https://bugs.webkit.org/show_bug.cgi?id=23466
+
+ Tests:
+ * editing/execCommand/empty-span-removal.html
+ * editing/execCommand/toggle-styles.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::styleSpanClassString):
+ (WebCore::isStyleSpan):
+ (WebCore::isUnstyledStyleSpan):
+ (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
+ (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle):
+ (WebCore::ApplyStyleCommand::removeCSSStyle):
+
+2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Eric Seidel.
+
+ Rename some of the casting functions in dom/*Element.cpp:
+ formControlElementForElement -> toFormControlElement
+ inputElementForElement -> toInputElement
+ optionElementForElement -> toOptionElement
+ optionGroupElementForElement -> toOptionGroupElement
+
+ Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
+ The Element*->ScriptElement* helper function is already named 'toScriptElement'.
+
+ * dom/FormControlElement.cpp:
+ (WebCore::toFormControlElement):
+ * dom/FormControlElement.h:
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::setValueFromRenderer):
+ (WebCore::toInputElement):
+ * dom/InputElement.h:
+ * dom/OptionElement.cpp:
+ (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
+ (WebCore::toOptionElement):
+ * dom/OptionElement.h:
+ * dom/OptionGroupElement.cpp:
+ (WebCore::toOptionGroupElement):
+ * dom/OptionGroupElement.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::paintItemForeground):
+ (WebCore::RenderListBox::paintItemBackground):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::updateOptionsWidth):
+ (WebCore::RenderMenuList::setTextFromOption):
+ (WebCore::RenderMenuList::itemText):
+ (WebCore::RenderMenuList::itemIsSelected):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::formControlElement):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::inputElement):
+
+2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by George Staikos.
+
+ Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.
+
+ * dom/OptionElement.cpp:
+ (WebCore::optionElementForElement):
+ * dom/OptionGroupElement.cpp:
+ (WebCore::optionGroupElementForElement):
+
+2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454
+
+ Add WML <option>/<optgroup> element support.
+ Currently the implementation is stubbed, all relevant parts can be enabled
+ once WMLSelectElement/SelectElement has been created.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLOptGroupElement.cpp: Added.
+ (WebCore::WMLOptGroupElement::WMLOptGroupElement):
+ (WebCore::WMLOptGroupElement::~WMLOptGroupElement):
+ (WebCore::WMLOptGroupElement::insertBefore):
+ (WebCore::WMLOptGroupElement::replaceChild):
+ (WebCore::WMLOptGroupElement::removeChild):
+ (WebCore::WMLOptGroupElement::appendChild):
+ (WebCore::WMLOptGroupElement::removeChildren):
+ (WebCore::ownerSelectElement):
+ (WebCore::WMLOptGroupElement::accessKeyAction):
+ (WebCore::WMLOptGroupElement::childrenChanged):
+ (WebCore::WMLOptGroupElement::parseMappedAttribute):
+ (WebCore::WMLOptGroupElement::attach):
+ (WebCore::WMLOptGroupElement::detach):
+ (WebCore::WMLOptGroupElement::setRenderStyle):
+ (WebCore::WMLOptGroupElement::nonRendererRenderStyle):
+ (WebCore::WMLOptGroupElement::groupLabelText):
+ (WebCore::WMLOptGroupElement::recalcSelectOptions):
+ * wml/WMLOptGroupElement.h: Added.
+ (WebCore::WMLOptGroupElement::title):
+ (WebCore::WMLOptGroupElement::valueMatchesRenderer):
+ (WebCore::WMLOptGroupElement::setValueMatchesRenderer):
+ (WebCore::WMLOptGroupElement::rendererIsNeeded):
+ * wml/WMLOptionElement.cpp: Added.
+ (WebCore::WMLOptionElement::WMLOptionElement):
+ (WebCore::WMLOptionElement::~WMLOptionElement):
+ (WebCore::ownerSelectElement):
+ (WebCore::WMLOptionElement::accessKeyAction):
+ (WebCore::WMLOptionElement::childrenChanged):
+ (WebCore::WMLOptionElement::parseMappedAttribute):
+ (WebCore::WMLOptionElement::attach):
+ (WebCore::WMLOptionElement::detach):
+ (WebCore::WMLOptionElement::setRenderStyle):
+ (WebCore::WMLOptionElement::insertedIntoDocument):
+ (WebCore::WMLOptionElement::selected):
+ (WebCore::WMLOptionElement::setSelectedState):
+ (WebCore::WMLOptionElement::value):
+ (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
+ (WebCore::WMLOptionElement::nonRendererRenderStyle):
+ (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
+ * wml/WMLOptionElement.h: Added.
+ (WebCore::WMLOptionElement::valueMatchesRenderer):
+ (WebCore::WMLOptionElement::setValueMatchesRenderer):
+ (WebCore::WMLOptionElement::rendererIsNeeded):
+ * wml/WMLTagNames.in:
+
+2009-01-22 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20806
+ Send referrer for history navigations.
+
+ Test: http/tests/navigation/back-send-referrer.html
+
+ Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ (WebCore::HistoryItem::referrer):
+ (WebCore::HistoryItem::setReferrer):
+ (WebCore::HistoryItem::formReferrer):
+ (WebCore::HistoryItem::rssFeedReferrer):
+ (WebCore::HistoryItem::setRSSFeedReferrer):
+ (WebCore::HistoryItem::setFormInfoFromRequest):
+ * history/HistoryItem.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem):
+
+2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Eric Seidel.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465
+
+ Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.
+
+ Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
+ optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.
+
+ Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
+ These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
+ used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.
+
+ * dom/OptionElement.cpp:
+ (WebCore::OptionElement::setSelectedState):
+ (WebCore::OptionElement::collectOptionText):
+ (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
+ (WebCore::OptionElement::collectOptionValue):
+ (WebCore::OptionElementData::OptionElementData):
+ (WebCore::OptionElementData::~OptionElementData):
+ * dom/OptionElement.h:
+ (WebCore::OptionElementData::element):
+ (WebCore::OptionElementData::value):
+ (WebCore::OptionElementData::setValue):
+ (WebCore::OptionElementData::label):
+ (WebCore::OptionElementData::setLabel):
+ (WebCore::OptionElementData::selected):
+ (WebCore::OptionElementData::setSelected):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::HTMLOptionElement):
+ (WebCore::HTMLOptionElement::text):
+ (WebCore::HTMLOptionElement::parseMappedAttribute):
+ (WebCore::HTMLOptionElement::value):
+ (WebCore::HTMLOptionElement::selected):
+ (WebCore::HTMLOptionElement::setSelected):
+ (WebCore::HTMLOptionElement::setSelectedState):
+ (WebCore::HTMLOptionElement::label):
+ (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
+ * html/HTMLOptionElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::typeAheadFind):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::paintItemForeground):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::updateOptionsWidth):
+ (WebCore::RenderMenuList::setTextFromOption):
+ (WebCore::RenderMenuList::itemText):
+
+2009-01-22 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ Bug 23464: Infinite recursion at SelectionController::setSelection
+ https://bugs.webkit.org/show_bug.cgi?id=23464
+
+ Check for conditions leading to infinite recursion.
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setSelection):
+
+2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
+
+ * rendering/RenderBox.cpp:
+
+2009-01-22 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build after RenderBox changes.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::baselinePosition):
+
+2009-01-22 David Hyatt <hyatt@apple.com>
+
+ Fix regressions in list box selection on Mac. The wrong color was being used for the list box
+ background, and list box colors actually weren't even being properly fetched because of a bug in
+ the RenderTheme base class. Existing pixel tests cover the bug fix.
+
+ Reviewed by Jon Honeycutt
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
+ (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
+
+2009-01-22 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 22720: Make XMLHttpRequest work in Workers
+ <https://bugs.webkit.org/show_bug.cgi?id=22720>
+
+ Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.
+
+ No observable change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * platform/network/HTTPHeaderMap.cpp: Added.
+ (WebCore::HTTPHeaderMap::copyData):
+ (WebCore::HTTPHeaderMap::adopt):
+ * platform/network/HTTPHeaderMap.h:
+
+2009-01-21 David Hyatt <hyatt@apple.com>
+
+ Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
+ was before my landing. Fixes failing SVG focus ring tests.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::paintOutline):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::paint):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+
+2009-01-21 David Hyatt <hyatt@apple.com>
+
+ Fix Node's renderBox() method on Windows.
+
+ * dom/Node.cpp:
+ (WebCore::Node::renderBox):
+
+2009-01-21 David Hyatt <hyatt@apple.com>
+
+ Fix RenderThemeSafari bustage on Win32.
+
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::baselinePosition):
+
+2009-01-21 David Hyatt <hyatt@apple.com>
+
+ Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
+ but that's a problem for another day.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
+
+2009-01-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
+ <https://bugs.webkit.org/show_bug.cgi?id=23470>
+
+ Add a RefPtr protector to handleWheelEvent to guard against destruction
+ while processing the scroll event. Alas the absurd set of circumstances
+ required to trigger this do not appear to be reproducible in DRT.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleWheelEvent):
+
+2009-01-21 David Hyatt <hyatt@apple.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23453
+
+ Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
+ Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.
+
+ Reviewed by Eric Seidel and Darin Adler
+
+ * WebCore.base.exp:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::sizingBox):
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ (WebCore::ContainerNode::getLowerRightCorner):
+ * dom/Element.cpp:
+ (WebCore::Element::offsetLeft):
+ (WebCore::Element::offsetTop):
+ (WebCore::Element::offsetWidth):
+ (WebCore::Element::offsetHeight):
+ (WebCore::Element::offsetParent):
+ (WebCore::Element::clientLeft):
+ (WebCore::Element::clientTop):
+ (WebCore::Element::clientWidth):
+ (WebCore::Element::clientHeight):
+ (WebCore::Element::scrollLeft):
+ (WebCore::Element::scrollTop):
+ (WebCore::Element::setScrollLeft):
+ (WebCore::Element::setScrollTop):
+ (WebCore::Element::scrollWidth):
+ (WebCore::Element::scrollHeight):
+ * dom/Node.cpp:
+ (WebCore::Node::renderBox):
+ (WebCore::Node::getRect):
+ * dom/Node.h:
+ * dom/Position.cpp:
+ (WebCore::endsOfNodeAreVisuallyDistinctPositions):
+ (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
+ (WebCore::Position::isCandidate):
+ * dom/PositionIterator.cpp:
+ (WebCore::PositionIterator::isCandidate):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
+ * editing/DeleteButtonController.cpp:
+ (WebCore::isDeletableElement):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::removeNode):
+ * editing/Editor.cpp:
+ (WebCore::Editor::insideVisibleArea):
+ * editing/EditorCommand.cpp:
+ (WebCore::verticalScrollDistance):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::willDraw):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::isFocusable):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::width):
+ (WebCore::HTMLFrameElementBase::height):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::width):
+ (WebCore::HTMLImageElement::height):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::drawNodeHighlight):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+ (WebCore::FrameView::updateDashboardRegions):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::imageRect):
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::renderBox):
+ (WebCore::InlineBox::adjustPosition):
+ * rendering/InlineBox.h:
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::placeBoxesHorizontally):
+ (WebCore::InlineFlowBox::verticallyAlignBoxes):
+ (WebCore::InlineFlowBox::placeBoxesVertically):
+ * rendering/InlineFlowBox.h:
+ * rendering/RenderApplet.cpp:
+ (WebCore::RenderApplet::createWidgetIfNecessary):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::overflowHeight):
+ (WebCore::RenderBlock::overflowWidth):
+ (WebCore::RenderBlock::overflowRect):
+ (WebCore::RenderBlock::isSelfCollapsingBlock):
+ (WebCore::RenderBlock::layout):
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::adjustPositionedBlock):
+ (WebCore::RenderBlock::adjustFloatingBlock):
+ (WebCore::RenderBlock::handleSpecialChild):
+ (WebCore::RenderBlock::handlePositionedChild):
+ (WebCore::RenderBlock::handleFloatingChild):
+ (WebCore::RenderBlock::handleCompactChild):
+ (WebCore::RenderBlock::insertCompactIfNeeded):
+ (WebCore::RenderBlock::handleRunInChild):
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::estimateVerticalPosition):
+ (WebCore::RenderBlock::determineHorizontalPosition):
+ (WebCore::RenderBlock::handleBottomOfBlock):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ (WebCore::RenderBlock::layoutPositionedObjects):
+ (WebCore::RenderBlock::markPositionedObjectsForLayout):
+ (WebCore::RenderBlock::repaintOverhangingFloats):
+ (WebCore::RenderBlock::paint):
+ (WebCore::RenderBlock::paintChildren):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::paintFloats):
+ (WebCore::RenderBlock::paintContinuationOutlines):
+ (WebCore::clipOutPositionedObjects):
+ (WebCore::RenderBlock::fillSelectionGaps):
+ (WebCore::RenderBlock::fillBlockSelectionGaps):
+ (WebCore::RenderBlock::leftSelectionOffset):
+ (WebCore::RenderBlock::rightSelectionOffset):
+ (WebCore::RenderBlock::insertPositionedObject):
+ (WebCore::RenderBlock::removePositionedObject):
+ (WebCore::RenderBlock::removePositionedObjects):
+ (WebCore::RenderBlock::insertFloatingObject):
+ (WebCore::RenderBlock::removeFloatingObject):
+ (WebCore::RenderBlock::positionNewFloats):
+ (WebCore::RenderBlock::newLine):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::clearFloats):
+ (WebCore::RenderBlock::addOverhangingFloats):
+ (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
+ (WebCore::RenderBlock::getClearDelta):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::layoutColumns):
+ (WebCore::RenderBlock::getBaselineOfFirstLineBox):
+ (WebCore::RenderBlock::getBaselineOfLastLineBox):
+ (WebCore::getHeightForLineCount):
+ (WebCore::RenderBlock::adjustForBorderFit):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
+ (WebCore::RenderBlock::hasOverhangingFloats):
+ (WebCore::RenderBlock::CompactInfo::compact):
+ (WebCore::RenderBlock::CompactInfo::set):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::RenderBox):
+ (WebCore::RenderBox::offsetLeft):
+ (WebCore::RenderBox::offsetTop):
+ (WebCore::RenderBox::offsetParent):
+ (WebCore::RenderBox::clientWidth):
+ (WebCore::RenderBox::clientHeight):
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+ (WebCore::RenderBox::scrollLeft):
+ (WebCore::RenderBox::scrollTop):
+ (WebCore::RenderBox::setScrollLeft):
+ (WebCore::RenderBox::setScrollTop):
+ (WebCore::RenderBox::absoluteRects):
+ (WebCore::RenderBox::absoluteQuads):
+ (WebCore::RenderBox::absoluteContentBox):
+ (WebCore::RenderBox::absoluteContentQuad):
+ (WebCore::RenderBox::absoluteOutlineBounds):
+ (WebCore::RenderBox::addFocusRingRects):
+ (WebCore::RenderBox::reflectionBox):
+ (WebCore::RenderBox::reflectionOffset):
+ (WebCore::RenderBox::reflectedRect):
+ (WebCore::RenderBox::overrideWidth):
+ (WebCore::RenderBox::overrideHeight):
+ (WebCore::RenderBox::nodeAtPoint):
+ (WebCore::RenderBox::paint):
+ (WebCore::RenderBox::maskClipRect):
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+ (WebCore::RenderBox::paintCustomHighlight):
+ (WebCore::RenderBox::getOverflowClipRect):
+ (WebCore::RenderBox::getClipRect):
+ (WebCore::RenderBox::containingBlockWidth):
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::offsetFromContainer):
+ (WebCore::RenderBox::position):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ (WebCore::RenderBox::repaintDuringLayoutIfMoved):
+ (WebCore::RenderBox::calcWidth):
+ (WebCore::RenderBox::calcWidthUsing):
+ (WebCore::RenderBox::calcHorizontalMargins):
+ (WebCore::RenderBox::calcHeight):
+ (WebCore::RenderBox::calcPercentageHeight):
+ (WebCore::RenderBox::calcReplacedHeightUsing):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::containingBlockHeightForPositioned):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteVerticalValues):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ (WebCore::RenderBox::localCaretRect):
+ (WebCore::RenderBox::lowestPosition):
+ (WebCore::RenderBox::rightmostPosition):
+ (WebCore::RenderBox::leftmostPosition):
+ (WebCore::RenderBox::localTransform):
+ * rendering/RenderBox.h:
+ (WebCore::):
+ (WebCore::RenderBox::x):
+ (WebCore::RenderBox::y):
+ (WebCore::RenderBox::width):
+ (WebCore::RenderBox::height):
+ (WebCore::RenderBox::setX):
+ (WebCore::RenderBox::setY):
+ (WebCore::RenderBox::setWidth):
+ (WebCore::RenderBox::setHeight):
+ (WebCore::RenderBox::location):
+ (WebCore::RenderBox::size):
+ (WebCore::RenderBox::setLocation):
+ (WebCore::RenderBox::setSize):
+ (WebCore::RenderBox::move):
+ (WebCore::RenderBox::frameRect):
+ (WebCore::RenderBox::setFrameRect):
+ (WebCore::RenderBox::borderBoxRect):
+ (WebCore::RenderBox::contentBoxRect):
+ (WebCore::RenderBox::previousSiblingBox):
+ (WebCore::RenderBox::nextSiblingBox):
+ (WebCore::RenderBox::parentBox):
+ (WebCore::RenderBox::overflowHeight):
+ (WebCore::RenderBox::overflowWidth):
+ (WebCore::RenderBox::setOverflowHeight):
+ (WebCore::RenderBox::setOverflowWidth):
+ (WebCore::RenderBox::overflowLeft):
+ (WebCore::RenderBox::overflowTop):
+ (WebCore::RenderBox::overflowRect):
+ (WebCore::RenderBox::contentWidth):
+ (WebCore::RenderBox::contentHeight):
+ (WebCore::RenderBox::offsetWidth):
+ (WebCore::RenderBox::offsetHeight):
+ (WebCore::RenderBox::clientLeft):
+ (WebCore::RenderBox::clientTop):
+ (WebCore::RenderBox::availableWidth):
+ (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::controlClipRect):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::layout):
+ (WebCore::RenderContainer::positionForCoordinates):
+ * rendering/RenderContainer.h:
+ (WebCore::RenderContainer::firstChildBox):
+ (WebCore::RenderContainer::lastChildBox):
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::calcPrefWidths):
+ (WebCore::RenderFieldset::layoutLegend):
+ (WebCore::RenderFieldset::findLegend):
+ (WebCore::RenderFieldset::paintBoxDecorations):
+ (WebCore::RenderFieldset::paintMask):
+ * rendering/RenderFieldset.h:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::maxFilenameWidth):
+ (WebCore::RenderFileUploadControl::paintObject):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::FlexBoxIterator::FlexBoxIterator):
+ (WebCore::FlexBoxIterator::first):
+ (WebCore::FlexBoxIterator::next):
+ (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
+ (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ (WebCore::RenderFlexibleBox::placeChild):
+ (WebCore::RenderFlexibleBox::allowedChildFlex):
+ * rendering/RenderFlexibleBox.h:
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::lowestPosition):
+ (WebCore::RenderFlow::rightmostPosition):
+ (WebCore::RenderFlow::leftmostPosition):
+ (WebCore::RenderFlow::localCaretRect):
+ (WebCore::RenderFlow::addFocusRingRects):
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::paint):
+ (WebCore::RenderFrameSet::layout):
+ (WebCore::RenderFrameSet::positionFrames):
+ * rendering/RenderHTMLCanvas.cpp:
+ (WebCore::RenderHTMLCanvas::paintReplaced):
+ (WebCore::RenderHTMLCanvas::canvasSizeChanged):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::imageChanged):
+ (WebCore::RenderImage::paintReplaced):
+ (WebCore::RenderImage::nodeAtPoint):
+ (WebCore::RenderImage::calcReplacedWidth):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteRects):
+ (WebCore::RenderInline::boundingBoxWidth):
+ (WebCore::RenderInline::boundingBoxHeight):
+ (WebCore::RenderInline::positionForCoordinates):
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::offsetWidth):
+ (WebCore::RenderInline::offsetHeight):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateTransform):
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::scrollbarCornerPresent):
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::calculateRects):
+ (WebCore::RenderLayer::boundingBox):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::calcHeight):
+ (WebCore::RenderListBox::controlClipRect):
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::positionListMarker):
+ (WebCore::RenderListItem::paint):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ (WebCore::RenderListMarker::layout):
+ (WebCore::RenderListMarker::imageChanged):
+ (WebCore::RenderListMarker::getRelativeMarkerRect):
+ (WebCore::RenderListMarker::selectionRect):
+ * rendering/RenderMarquee.cpp:
+ (WebCore::RenderMarquee::computePosition):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::layout):
+ (WebCore::RenderMedia::lowestPosition):
+ (WebCore::RenderMedia::rightmostPosition):
+ (WebCore::RenderMedia::leftmostPosition):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::controlClipRect):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::RenderObject):
+ (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout):
+ (WebCore::RenderObject::paintOutline):
+ (WebCore::RenderObject::addLineBoxRects):
+ (WebCore::RenderObject::absoluteBoundingBoxRect):
+ (WebCore::RenderObject::addAbsoluteRectForLayer):
+ (WebCore::RenderObject::paintingRootRect):
+ (WebCore::RenderObject::container):
+ (WebCore::RenderObject::removeFromObjectLists):
+ (WebCore::RenderObject::updateHitTestResult):
+ (WebCore::RenderObject::addDashboardRegions):
+ (WebCore::RenderObject::localTransform):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isBox):
+ (WebCore::RenderObject::hasMask):
+ (WebCore::RenderObject::setIsText):
+ (WebCore::RenderObject::setIsBox):
+ (WebCore::RenderObject::borderTop):
+ (WebCore::RenderObject::borderBottom):
+ (WebCore::RenderObject::absoluteRects):
+ (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
+ (WebCore::RenderObject::absoluteQuads):
+ (WebCore::RenderObject::hasReflection):
+ (WebCore::RenderObject::addFocusRingRects):
+ (WebCore::RenderObject::absoluteOutlineBounds):
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::updateWidgetPosition):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::layout):
+ (WebCore::RenderPath::paint):
+ (WebCore::RenderPath::absoluteOutlineBounds):
+ * rendering/RenderPath.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::layout):
+ (WebCore::RenderReplaced::paint):
+ (WebCore::RenderReplaced::shouldPaint):
+ (WebCore::RenderReplaced::positionForCoordinates):
+ (WebCore::RenderReplaced::localSelectionRect):
+ (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
+ (WebCore::RenderReplaced::overflowRect):
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::layout):
+ (WebCore::RenderReplica::calcPrefWidths):
+ (WebCore::RenderReplica::paint):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ (WebCore::RenderSVGContainer::absoluteOutlineBounds):
+ * rendering/RenderSVGContainer.h:
+ (WebCore::RenderSVGContainer::width):
+ (WebCore::RenderSVGContainer::height):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::layout):
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
+ (WebCore::RenderSVGInlineText::positionForCoordinates):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ (WebCore::RenderSVGRoot::applyContentTransforms):
+ (WebCore::RenderSVGRoot::paint):
+ (WebCore::RenderSVGRoot::absoluteTransform):
+ (WebCore::RenderSVGRoot::nodeAtPoint):
+ * rendering/RenderSVGTSpan.cpp:
+ (WebCore::RenderSVGTSpan::absoluteRects):
+ (WebCore::RenderSVGTSpan::absoluteQuads):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout):
+ (WebCore::RenderSVGText::relativeBBox):
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::absoluteRects):
+ (WebCore::RenderSVGTextPath::absoluteQuads):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::nodeAtPoint):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::createCustomScrollbar):
+ (WebCore::RenderScrollbar::RenderScrollbar):
+ (WebCore::RenderScrollbar::setParent):
+ * rendering/RenderScrollbar.h:
+ (WebCore::RenderScrollbar::owningRenderer):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::layout):
+ (WebCore::RenderScrollbarPart::layoutHorizontalPart):
+ (WebCore::RenderScrollbarPart::layoutVerticalPart):
+ (WebCore::RenderScrollbarPart::computeScrollbarWidth):
+ (WebCore::RenderScrollbarPart::computeScrollbarHeight):
+ (WebCore::RenderScrollbarPart::paintIntoRect):
+ * rendering/RenderSlider.cpp:
+ (WebCore::HTMLSliderThumbElement::defaultEventHandler):
+ (WebCore::RenderSlider::layout):
+ (WebCore::RenderSlider::mouseEventIsInThumb):
+ (WebCore::RenderSlider::positionForOffset):
+ (WebCore::RenderSlider::trackSize):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::calcWidth):
+ (WebCore::RenderTable::layout):
+ (WebCore::RenderTable::paint):
+ (WebCore::RenderTable::getBaselineOfFirstLineBox):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::updateWidth):
+ (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
+ (WebCore::RenderTableCell::localToAbsolute):
+ (WebCore::RenderTableCell::absoluteToLocal):
+ (WebCore::RenderTableCell::localToAbsoluteQuad):
+ (WebCore::RenderTableCell::paint):
+ (WebCore::RenderTableCell::paintBackgroundsBehindCell):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addChild):
+ (WebCore::RenderTableSection::addCell):
+ (WebCore::RenderTableSection::setCellWidths):
+ (WebCore::RenderTableSection::calcRowHeight):
+ (WebCore::RenderTableSection::layoutRows):
+ (WebCore::RenderTableSection::lowestPosition):
+ (WebCore::RenderTableSection::rightmostPosition):
+ (WebCore::RenderTableSection::leftmostPosition):
+ (WebCore::RenderTableSection::getBaselineOfFirstLineBox):
+ (WebCore::RenderTableSection::paint):
+ (WebCore::RenderTableSection::recalcCells):
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderTableSection.h:
+ (WebCore::RenderTableSection::overflowWidth):
+ (WebCore::RenderTableSection::overflowHeight):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+ (WebCore::RenderText::boundingBoxX):
+ (WebCore::RenderText::boundingBoxY):
+ (WebCore::RenderText::firstRunX):
+ (WebCore::RenderText::firstRunY):
+ (WebCore::RenderText::boundingBoxHeight):
+ (WebCore::RenderText::boundingBoxWidth):
+ * rendering/RenderText.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textBlockHeight):
+ (WebCore::RenderTextControl::textBlockWidth):
+ (WebCore::RenderTextControl::setSelectionRange):
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::hitInnerTextBlock):
+ (WebCore::RenderTextControl::controlClipRect):
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::layout):
+ (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::paint):
+ (WebCore::RenderTextControlSingleLine::layout):
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ (WebCore::RenderTextControlSingleLine::textBlockWidth):
+ (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
+ (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
+ (WebCore::RenderTextControlSingleLine::clientPaddingRight):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::hitTestMediaControlPart):
+ (WebCore::RenderTheme::baselinePosition):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+ (WebCore::RenderThemeMac::hitTestMediaControlPart):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::videoBox):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::RenderView):
+ (WebCore::RenderView::calcHeight):
+ (WebCore::RenderView::calcWidth):
+ (WebCore::RenderView::layout):
+ (WebCore::RenderView::viewRect):
+ (WebCore::RenderView::docHeight):
+ (WebCore::RenderView::docWidth):
+ (WebCore::RenderView::setBestTruncatedAt):
+ * rendering/RenderView.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+ (WebCore::RenderWidget::updateWidgetPosition):
+ (WebCore::RenderWidget::nodeAtPoint):
+ * rendering/RootInlineBox.h:
+ (WebCore::RootInlineBox::floats):
+ (WebCore::RootInlineBox::floatsPtr):
+ * rendering/SVGInlineFlowBox.cpp:
+ (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
+ * rendering/SVGInlineFlowBox.h:
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ (WebCore::write):
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
+ (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ * rendering/SVGRootInlineBox.h:
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::computeHorizontalPositionsForLine):
+ (WebCore::RenderBlock::computeVerticalPositionsForLine):
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::determineStartPosition):
+ (WebCore::RenderBlock::matchedEndLine):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::RenderBlock::fitBelowFloats):
+ (WebCore::RenderBlock::findNextLineBreak):
+ (WebCore::RenderBlock::checkLinesForOverflow):
+ * svg/SVGLength.cpp:
+ (WebCore::SVGLength::PercentageOfViewport):
+
+2009-01-21 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * WebCore.LP64.exp:
+ Add some bridge related symbols.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ Make runtime_object.h a private header.
+
+2009-01-20 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 22720: Make XMLHttpRequest work in Workers
+ <https://bugs.webkit.org/show_bug.cgi?id=22720>
+
+ More removal of document usage from XMLHttpRequest.
+ * Abstracted away the sync and async requests behind the ThreadableLoader class, which
+ will get an implementation for Workers. ThreadableLoader follows the same model as
+ SubresourceLoader because DocumentThreadableLoader is a thin wrapper around SubresourceLoader.
+ Also, WorkerThreadableLoader (coming soon) will use DocumentThreadableLoader to get things done.
+ * Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode
+ which handles workers.
+
+ No observable change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * loader/DocumentThreadableLoader.cpp: Added.
+ (WebCore::DocumentThreadableLoader::create):
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::cancel):
+ (WebCore::DocumentThreadableLoader::willSendRequest):
+ (WebCore::DocumentThreadableLoader::didSendData):
+ (WebCore::DocumentThreadableLoader::didReceiveResponse):
+ (WebCore::DocumentThreadableLoader::didReceiveData):
+ (WebCore::DocumentThreadableLoader::didFinishLoading):
+ (WebCore::DocumentThreadableLoader::didFail):
+ (WebCore::DocumentThreadableLoader::receivedCancellation):
+ * loader/DocumentThreadableLoader.h: Added.
+ (WebCore::DocumentThreadableLoader::refThreadableLoader):
+ (WebCore::DocumentThreadableLoader::derefThreadableLoader):
+ * loader/SubresourceLoaderClient.h:
+ (WebCore::SubresourceLoaderClient::didReceiveData):
+ * loader/ThreadableLoader.cpp: Added.
+ (WebCore::ThreadableLoader::create):
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/ThreadableLoader.h: Added.
+ (WebCore::):
+ (WebCore::ThreadableLoader::ref):
+ (WebCore::ThreadableLoader::deref):
+ (WebCore::ThreadableLoader::~ThreadableLoader):
+ * loader/ThreadableLoaderClient.h: Added.
+ (WebCore::ThreadableLoaderClient::didSendData):
+ (WebCore::ThreadableLoaderClient::didReceiveResponse):
+ (WebCore::ThreadableLoaderClient::didReceiveData):
+ (WebCore::ThreadableLoaderClient::didFinishLoading):
+ (WebCore::ThreadableLoaderClient::didFail):
+ (WebCore::ThreadableLoaderClient::didGetCancelled):
+ (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
+ (WebCore::ThreadableLoaderClient::~ThreadableLoaderClient):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
+ (WebCore::XMLHttpRequest::send):
+ (WebCore::XMLHttpRequest::loadRequestSynchronously):
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::setRequestHeader):
+ (WebCore::XMLHttpRequest::processSyncLoadResults):
+ (WebCore::XMLHttpRequest::didFail):
+ (WebCore::XMLHttpRequest::didGetCancelled):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
+ (WebCore::XMLHttpRequest::didSendData):
+ (WebCore::XMLHttpRequest::didReceiveResponse):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
+ (WebCore::XMLHttpRequest::didReceiveData):
+ * xml/XMLHttpRequest.h:
+
+2009-01-19 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23317
+
+ The high CPU usage was really from repeatedly firing transitions caused
+ by a bug in the way we handle background-color animations. If animating
+ from a valid background color to no background color, we sometimes left
+ (based on timing) the background color as transparent black, but valid
+ rather than invalid, which it should be. Fixing that got rid of the
+ repeated firing.
+
+ But we really were doing more expensive iteration of all objects with
+ animations or transitions on them (running or not). So I added two
+ optimizations to quickly short circuit when an object had no running
+ animations or transitions. Things are now as zippy as ever.
+
+ Test: transitions/repeated-firing-background-color.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::hasAnimations):
+ (WebCore::CompositeAnimationPrivate::clearRenderer):
+ (WebCore::CompositeAnimationPrivate::animate):
+ (WebCore::CompositeAnimationPrivate::setAnimating):
+ (WebCore::CompositeAnimationPrivate::willNeedService):
+ (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
+ (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
+ (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
+ (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
+ (WebCore::CompositeAnimationPrivate::suspendAnimations):
+ (WebCore::CompositeAnimationPrivate::resumeAnimations):
+ (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
+ (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
+ (WebCore::CompositeAnimationPrivate::styleAvailable):
+ (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
+ (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
+ (WebCore::CompositeAnimation::hasAnimations):
+ * page/animation/CompositeAnimation.h:
+
+2009-01-21 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Remove the style='' turds left by some editing commands
+ https://bugs.webkit.org/show_bug.cgi?id=23463
+
+ Test: editing/execCommand/toggle-styles.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
+
+2009-01-21 Eric Seidel <eric@webkit.org>
+
+ No review, build fix.
+
+ Fix release-only build failure (and do a tiny code-cleanup).
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::createFontElement):
+ (WebCore::createStyleSpanElement):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+
+2009-01-21 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility()
+ https://bugs.webkit.org/show_bug.cgi?id=23443
+
+ Test: accessibility/table-modification-crash.html
+
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::updateBackingStore):
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::childrenChanged):
+ (WebCore::AccessibilityRenderObject::children):
+ (WebCore::AccessibilityRenderObject::updateBackingStore):
+ * page/AccessibilityRenderObject.h:
+ (WebCore::AccessibilityRenderObject::markChildrenDirty):
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::AccessibilityTable):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityActionNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+ (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
+ (-[AccessibilityObjectWrapper accessibilityHitTest:]):
+ (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
+ (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
+ (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
+ (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
+ (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
+ (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::destroy):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy):
+
+2009-01-16 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
+ https://bugs.webkit.org/show_bug.cgi?id=17733
+
+ Test changed: editing/execCommand/toggle-styles-expected.txt
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::StyleChange::applySubscript):
+ (WebCore::StyleChange::applySuperscript):
+ (WebCore::StyleChange::StyleChange):
+ (WebCore::StyleChange::init):
+ (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
+ (WebCore::ApplyStyleCommand::isHTMLStyleNode):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+ * editing/EditorCommand.cpp:
+ (WebCore::executeSubscript):
+ (WebCore::executeSuperscript):
+ * editing/htmlediting.cpp:
+ (WebCore::createHTMLElement):
+ * editing/htmlediting.h:
+
+2009-01-21 Anders Carlsson <andersca@apple.com>
+
+ Fix 64-bit build.
+
+ * WebCore.LP64.exp:
+
+2009-01-21 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
+ <https://bugs.webkit.org/show_bug.cgi?id=23458>
+
+ Return CanvasPixelArray, et al -- the only difference between this
+ and the original CPA implementation is that it now uses a ByteArray
+ rather than a vector. JSC still uses a custom wrapper, but this allows
+ ObjC, COM, and V8 bindings to be autogenerated again.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ * html/CanvasPixelArray.cpp: Added.
+ (WebCore::CanvasPixelArray::create):
+ (WebCore::CanvasPixelArray::CanvasPixelArray):
+ * html/CanvasPixelArray.h: Added.
+ (WebCore::CanvasPixelArray::data):
+ (WebCore::CanvasPixelArray::length):
+ (WebCore::CanvasPixelArray::set):
+ (WebCore::CanvasPixelArray::get):
+ * html/CanvasPixelArray.idl: Added.
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::createEmptyImageData):
+ * html/ImageData.cpp:
+ (WebCore::ImageData::ImageData):
+ * html/ImageData.h:
+ (WebCore::ImageData::data):
+ * html/ImageData.idl:
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+
+2009-01-21 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Remove last relics of platform dependent PaintServer in SVG.
+ We draw everything with the help of GraphicsContext.
+
+ Remove SVGPaintServerPlatform's
+ [https://bugs.webkit.org/show_bug.cgi?id=23439]
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/graphics/SVGPaintServer.cpp:
+ (WebCore::SVGPaintServer::draw):
+ (WebCore::SVGPaintServer::renderPath):
+ (WebCore::SVGPaintServer::teardown):
+ * svg/graphics/SVGPaintServer.h:
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ * svg/graphics/SVGPaintServerGradient.h:
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ * svg/graphics/SVGPaintServerPattern.h:
+ * svg/graphics/SVGPaintServerSolid.cpp:
+ * svg/graphics/SVGPaintServerSolid.h:
+ * svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
+ * svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
+ * svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
+
+2009-01-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Move "Element -> ScriptElement" casting functionality into ScriptElement.h
+ to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.
+
+ It was living in XMLTokenizer before, which is not an obvious place for this.
+ TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
+ as suggested by Alexey, it really reads better this way.
+
+ * dom/ScriptElement.cpp:
+ (WebCore::toScriptElement):
+ * dom/ScriptElement.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * dom/XMLTokenizer.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::startElementNs):
+ (WebCore::XMLTokenizer::endElementNs):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseStartElement):
+ (WebCore::XMLTokenizer::parseEndElement):
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444
+
+ Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
+ in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
+ has been done before for FormControlElement and RenderTextControl.
+
+ This is needed to prepare the addtion of WMLOption/OptGroupElement.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/OptionElement.cpp: Added.
+ (WebCore::optionElementForElement):
+ * dom/OptionElement.h: Added.
+ (WebCore::OptionElement::~OptionElement):
+ (WebCore::OptionElement::OptionElement):
+ * dom/OptionGroupElement.cpp: Added.
+ (WebCore::optionGroupElementForElement):
+ * dom/OptionGroupElement.h: Added.
+ (WebCore::OptionGroupElement::~OptionGroupElement):
+ (WebCore::OptionGroupElement::OptionGroupElement):
+ * html/HTMLOptGroupElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::optionText):
+ * html/HTMLOptionElement.h:
+ (WebCore::HTMLOptionElement::selected):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::paintItemForeground):
+ (WebCore::RenderListBox::paintItemBackground):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::updateOptionsWidth):
+ (WebCore::RenderMenuList::setTextFromOption):
+ (WebCore::RenderMenuList::itemText):
+ (WebCore::RenderMenuList::itemIsSelected):
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
+ https://bugs.webkit.org/show_bug.cgi?id=23448
+
+ * platform/graphics/cg/ImageSourceCGMac.mm:
+ (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ Try to fix Wx build.
+
+ * platform/wx/PasteboardWx.cpp:
+ (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash
+ with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing
+ to the clipboard. Other platforms don't do it. If it was needed, the new function
+ to use would be displayStringModifiedByEncoding.
+
+2009-01-19 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Mitz Pettel.
+
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=23423.
+
+ The Windows Cairo post-build targets (Release/Debug) do not
+ copy all of the headers that the CG-based build does.
+
+ * WebCore.vcproj/WebCore.vcproj: Extend WebCore Cairo build targets
+ to copy the page/animation/*.h files into WebKitBuild so that
+ WebKit can find them.
+
+2009-01-20 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23413
+ Remove unused WebCore::setDeferringTimers()
+
+ * platform/Timer.cpp:
+ (WebCore::updateSharedTimer):
+ * platform/Timer.h:
+
+2009-01-20 David Hyatt <hyatt@apple.com>
+
+ Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
+ m_renderer to be consistent with the corresponding member function.
+
+ Reviewed by Jon Honeycutt
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::updateVisibilityStatus):
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::stackingContext):
+ (WebCore::RenderLayer::enclosingPositionedAncestor):
+ (WebCore::RenderLayer::enclosingTransformedAncestor):
+ (WebCore::RenderLayer::isTransparent):
+ (WebCore::RenderLayer::convertToLayerCoords):
+ (WebCore::RenderLayer::scrollByRecursively):
+ (WebCore::RenderLayer::scrollToOffset):
+ (WebCore::RenderLayer::scrollRectToVisible):
+ (WebCore::RenderLayer::resize):
+ (WebCore::RenderLayer::scrollbarCornerPresent):
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::setHasHorizontalScrollbar):
+ (WebCore::RenderLayer::setHasVerticalScrollbar):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::computeScrollDimensions):
+ (WebCore::RenderLayer::updateOverflowStatus):
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::isPointInResizeControl):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::updateClipRects):
+ (WebCore::RenderLayer::calculateClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ (WebCore::RenderLayer::clearClipRects):
+ (WebCore::RenderLayer::repaintIncludingDescendants):
+ (WebCore::RenderLayer::styleChanged):
+ (WebCore::RenderLayer::updateScrollCornerStyle):
+ (WebCore::RenderLayer::updateResizerStyle):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::renderer):
+ (WebCore::RenderLayer::hasReflection):
+ (WebCore::RenderLayer::hasTransform):
+
+2009-01-20 David Hyatt <hyatt@apple.com>
+
+ Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
+ for returning the appropriate listbox selection colors.
+
+ Reviewed by Adele
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
+ (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
+ (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
+
+2009-01-20 Dave Hyatt <hyatt@apple.com>
+
+ Fix for focus rings on Windows. Make sure that focus rings draw for all controls but buttons.
+
+ Fix list box selection colors on Windows. Also add a cache for all of the selection colors (and not just the two
+ background selection colors).
+
+ Reviewed by Adam Roben
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::selectionForegroundColor):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::activeSelectionBackgroundColor):
+ (WebCore::RenderTheme::inactiveSelectionBackgroundColor):
+ (WebCore::RenderTheme::activeSelectionForegroundColor):
+ (WebCore::RenderTheme::inactiveSelectionForegroundColor):
+ (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
+ (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
+ (WebCore::RenderTheme::platformActiveSelectionForegroundColor):
+ (WebCore::RenderTheme::platformInactiveSelectionBackgroundColor):
+ (WebCore::RenderTheme::platformInactiveSelectionForegroundColor):
+ (WebCore::RenderTheme::platformActiveListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::platformActiveListBoxSelectionForegroundColor):
+ (WebCore::RenderTheme::platformInactiveListBoxSelectionBackgroundColor):
+ (WebCore::RenderTheme::platformInactiveListBoxSelectionForegroundColor):
+ (WebCore::RenderTheme::platformColorsDidChange):
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::supportsForegroundSelectionColors):
+ (WebCore::RenderTheme::supportsForegroundListBoxSelectionColors):
+ * rendering/RenderThemeMac.h:
+ (WebCore::RenderThemeMac::supportsForegroundSelectionColors):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor):
+ (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor):
+ (WebCore::RenderThemeWin::supportsFocus):
+ (WebCore::RenderThemeWin::supportsFocusRing):
+ * rendering/RenderThemeWin.h:
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434
+
+ Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
+ Now any language can provide <input>-style elements, without having to inherit from HTML* classes.
+
+ No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
+ Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
+ Detailed testcases will follow in conjunction with the WML specific attribute support.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * dom/FormControlElement.cpp: Activate disabled code from previous checking.
+ (WebCore::formControlElementForElement):
+ * dom/InputElement.cpp: Ditto.
+ (WebCore::inputElementForElement):
+ * wml/WMLInputElement.cpp: Added.
+ (WebCore::WMLInputElement::WMLInputElement):
+ (WebCore::WMLInputElement::~WMLInputElement):
+ (WebCore::isInputFocusable):
+ (WebCore::WMLInputElement::isKeyboardFocusable):
+ (WebCore::WMLInputElement::isMouseFocusable):
+ (WebCore::WMLInputElement::dispatchFocusEvent):
+ (WebCore::WMLInputElement::dispatchBlurEvent):
+ (WebCore::WMLInputElement::updateFocusAppearance):
+ (WebCore::WMLInputElement::aboutToUnload):
+ (WebCore::WMLInputElement::size):
+ (WebCore::WMLInputElement::name):
+ (WebCore::WMLInputElement::value):
+ (WebCore::WMLInputElement::setValue):
+ (WebCore::WMLInputElement::setValueFromRenderer):
+ (WebCore::WMLInputElement::saveState):
+ (WebCore::WMLInputElement::restoreState):
+ (WebCore::WMLInputElement::select):
+ (WebCore::WMLInputElement::accessKeyAction):
+ (WebCore::WMLInputElement::parseMappedAttribute):
+ (WebCore::WMLInputElement::copyNonAttributeProperties):
+ (WebCore::WMLInputElement::createRenderer):
+ (WebCore::WMLInputElement::attach):
+ (WebCore::WMLInputElement::detach):
+ (WebCore::WMLInputElement::appendFormData):
+ (WebCore::WMLInputElement::reset):
+ (WebCore::WMLInputElement::defaultEventHandler):
+ (WebCore::WMLInputElement::cacheSelection):
+ (WebCore::WMLInputElement::constrainValue):
+ (WebCore::WMLInputElement::documentDidBecomeActive):
+ (WebCore::WMLInputElement::placeholderShouldBeVisible):
+ (WebCore::WMLInputElement::willMoveToNewOwnerDocument):
+ (WebCore::WMLInputElement::didMoveToNewOwnerDocument):
+ * wml/WMLInputElement.h: Added.
+ (WebCore::WMLInputElement::valueMatchesRenderer):
+ (WebCore::WMLInputElement::setValueMatchesRenderer):
+ (WebCore::WMLInputElement::shouldUseInputMethod):
+ (WebCore::WMLInputElement::isChecked):
+ (WebCore::WMLInputElement::isIndeterminate):
+ (WebCore::WMLInputElement::isTextControl):
+ (WebCore::WMLInputElement::isRadioButton):
+ (WebCore::WMLInputElement::isTextField):
+ (WebCore::WMLInputElement::isSearchField):
+ (WebCore::WMLInputElement::isInputTypeHidden):
+ (WebCore::WMLInputElement::isPasswordField):
+ (WebCore::WMLInputElement::searchEventsShouldBeDispatched):
+ (WebCore::WMLInputElement::placeholderValue):
+ * wml/WMLTagNames.in:
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ Reviewed by John Sullivan.
+
+ Remove a little dead code left over after the fix for
+ https://bugs.webkit.org/show_bug.cgi?id=11395, which
+ moved pointer-events from SVG to be shared with HTML.
+
+ * css/SVGCSSParser.cpp:
+ (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this
+ property since it's handled in the non-SVG function now so we'll
+ never get here.
+
+2009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23438: Provide a default value to the .in file parser
+
+ Added the default value 1 as it simplifies some of
+ the format by removing some "=1" that were awkward.
+
+ This was suggested by Darin Adler as par of a previous
+ review.
+
+ * bindings/scripts/InFilesParser.pm: When no value
+ was entered (the second part of the split is undef),
+ provide the default value.
+
+ * html/HTMLAttributeNames.in: Removed unnecessary "=1".
+ * html/HTMLTagNames.in: Ditto.
+ * svg/svgattrs.in: Ditto.
+ * svg/svgtags.in: Ditto.
+ * svg/xlinkattrs.in: Ditto.
+ * wml/WMLAttributeNames.in: Ditto.
+
+2009-01-20 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * bridge/c/c_class.cpp:
+ * bridge/c/c_class.h:
+ Get rid of CClass::name().
+
+ * bridge/jni/jni_class.h:
+ Get rid of JavaClass::name().
+
+ * bridge/objc/objc_class.h:
+ * bridge/objc/objc_class.mm:
+ Get rid of ObjcClass::name().
+
+ * bridge/objc/objc_instance.h:
+ Get rid of supportsSetValueOfUndefinedField.
+
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::setValueOfUndefinedField):
+ Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.
+
+ * bridge/runtime.cpp:
+ Get rid of getValueOfField and setValueOfField.
+
+ * bridge/runtime.h:
+ (JSC::Bindings::Instance::setValueOfUndefinedField):
+ Have this return a bool and get rid of supportsSetValueOfUndefinedField
+
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::fieldGetter):
+ Call Field::valueFromInstance on the field.
+
+ (JSC::RuntimeObjectImp::put):
+ Call Field::setValueToInstance on the field.
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Forgot to land build changes for non-mac platforms.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Adam Roben.
+
+ Fix last-minute regression, introduced by simplifying max length determination - by
+ clamping using min/max, negative maxLength values got broken.
+
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::parseMaxLengthAttribute):
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Adam Roben.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433
+
+ Add InputElement abstraction, similar to the FormControlElement refactorization
+ done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
+ In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
+ RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
+ depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.
+
+ A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
+ InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
+ derive from InputElement, and hold a InputElementData member variable, that they pass to the
+ static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/FormControlElement.cpp: Added.
+ (WebCore::formControlElementForElement):
+ * dom/FormControlElement.h:
+ * dom/InputElement.cpp: Added.
+ (WebCore::InputElement::dispatchFocusEvent):
+ (WebCore::InputElement::dispatchBlurEvent):
+ (WebCore::InputElement::updatePlaceholderVisibility):
+ (WebCore::InputElement::updateFocusAppearance):
+ (WebCore::InputElement::updateSelectionRange):
+ (WebCore::InputElement::aboutToUnload):
+ (WebCore::InputElement::setValueFromRenderer):
+ (WebCore::numCharactersInGraphemeClusters):
+ (WebCore::InputElement::constrainValue):
+ (WebCore::numGraphemeClusters):
+ (WebCore::InputElement::handleBeforeTextInsertedEvent):
+ (WebCore::InputElement::parseSizeAttribute):
+ (WebCore::InputElement::parseMaxLengthAttribute):
+ (WebCore::InputElement::updateValueIfNeeded):
+ (WebCore::InputElement::notifyFormStateChanged):
+ (WebCore::InputElementData::InputElementData):
+ (WebCore::InputElementData::~InputElementData):
+ (WebCore::InputElementData::name):
+ (WebCore::inputElementForElement):
+ * dom/InputElement.h: Added.
+ (WebCore::InputElement::~InputElement):
+ (WebCore::InputElement::InputElement):
+ (WebCore::InputElementData::inputElement):
+ (WebCore::InputElementData::element):
+ (WebCore::InputElementData::placeholderShouldBeVisible):
+ (WebCore::InputElementData::setPlaceholderShouldBeVisible):
+ (WebCore::InputElementData::setName):
+ (WebCore::InputElementData::value):
+ (WebCore::InputElementData::setValue):
+ (WebCore::InputElementData::size):
+ (WebCore::InputElementData::setSize):
+ (WebCore::InputElementData::maxLength):
+ (WebCore::InputElementData::setMaxLength):
+ (WebCore::InputElementData::cachedSelectionStart):
+ (WebCore::InputElementData::setCachedSelectionStart):
+ (WebCore::InputElementData::cachedSelectionEnd):
+ (WebCore::InputElementData::setCachedSelectionEnd):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::HTMLInputElement):
+ (WebCore::HTMLInputElement::name):
+ (WebCore::HTMLInputElement::updateFocusAppearance): Moved to InputElement.
+ (WebCore::HTMLInputElement::aboutToUnload): Ditto.
+ (WebCore::HTMLInputElement::dispatchFocusEvent): Ditto.
+ (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
+ (WebCore::HTMLInputElement::setSelectionRange): Moved to InputElement::updateSelectionRange, call it from here.
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::size): Make virtual and override InputElements abstract version.
+ (WebCore::HTMLInputElement::copyNonAttributeProperties):
+ (WebCore::HTMLInputElement::value): Make virtual and override InputElements abstract version.
+ (WebCore::HTMLInputElement::setValue): Ditto.
+ (WebCore::HTMLInputElement::placeholderValue): Ditto.
+ (WebCore::HTMLInputElement::searchEventsShouldBeDispatched): Ditto.
+ (WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
+ (WebCore::HTMLInputElement::setFileListFromRenderer): Use new code in InputElement::setValueFromRenderer
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ (WebCore::HTMLInputElement::setDefaultName): Added as helper function for HTMLIsIndexElement.
+ (WebCore::HTMLInputElement::maxLength): Added accesor.
+ (WebCore::HTMLInputElement::constrainValue): Move functionality to InputElement::constrainValue.
+ (WebCore::HTMLInputElement::cacheSelection): Move functionality to InputElement::cacheSelection.
+ (WebCore::HTMLInputElement::selection):
+ (WebCore::HTMLInputElement::placeholderShouldBeVisible): Make virtual and override InputElements abstract version.
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::isTextField):
+ (WebCore::HTMLInputElement::isSearchField):
+ (WebCore::HTMLInputElement::isAutofilled):
+ * html/HTMLIsIndexElement.cpp:
+ (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::formControlElement):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
+ (WebCore::RenderTextControlSingleLine::addSearchResult):
+ (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
+ (WebCore::RenderTextControlSingleLine::showPopup):
+ (WebCore::RenderTextControlSingleLine::hidePopup):
+ (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
+ (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+ (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+ (WebCore::RenderTextControlSingleLine::cacheSelection):
+ (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
+ (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
+ (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
+ (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
+ (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
+ (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
+ (WebCore::RenderTextControlSingleLine::valueChanged):
+ (WebCore::RenderTextControlSingleLine::setTextFromItem):
+ (WebCore::RenderTextControlSingleLine::inputElement):
+ * rendering/RenderTextControlSingleLine.h:
+
+2009-01-20 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Make SVG pattern platform independent and remove platform code.
+
+ Make SVGPattern platform independent
+ https://bugs.webkit.org/show_bug.cgi?id=21205
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::applyStrokePattern):
+ (WebCore::GraphicsContext::applyFillPattern):
+ (WebCore::GraphicsContext::drawPath):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokeRect):
+ * svg/graphics/SVGPaintServerPattern.cpp:
+ (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
+ (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
+ (WebCore::SVGPaintServerPattern::setup):
+ (WebCore::SVGPaintServerPattern::renderPath):
+ (WebCore::SVGPaintServerPattern::teardown):
+ * svg/graphics/SVGPaintServerPattern.h:
+ * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
+ * svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
+ * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.
+
+2009-01-20 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23436
+ Upstream rendering/RenderThemeChromium*
+
+ * rendering/RenderThemeChromiumGtk.cpp: Added.
+ * rendering/RenderThemeChromiumGtk.h: Added.
+ * rendering/RenderThemeChromiumMac.h: Added.
+ * rendering/RenderThemeChromiumMac.mm: Added.
+ * rendering/RenderThemeChromiumWin.cpp: Added.
+ * rendering/RenderThemeChromiumWin.h: Added.
+
+2009-01-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Bug 23352: Turn on more compiler warnings in the Mac build
+ https://bugs.webkit.org/show_bug.cgi?id=23352
+
+ First patch: Fix some simple cases of various warnings.
+
+ * platform/DeprecatedPtrListImpl.cpp:
+ (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::containsCharacters): Ditto.
+
+ * platform/text/PlatformString.h: Overload for short and unsigned short to avoid
+ ambiguity leading to warnings.
+ * platform/text/String.cpp:
+ (WebCore::String::number): Implemented overloads.
+
+ * platform/text/TextStream.cpp:
+ (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading
+ to warnings.
+ * platform/text/TextStream.h: Ditto.
+
+ * rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.
+
+ * svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after
+ #endif that should be a comment instead.
+ * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.
+
+ * xml/XPathPath.h: Remove unneeded redundant declaration.
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Build fix for WML enabled builds, not reviewed.
+
+ Fix unused variable warning.
+
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::executeTask):
+
+2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Build fix for WML enabled builds, not reviewed.
+
+ Rename 'continuation' to 'virtualContinuation'.
+
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::isKeyboardFocusable):
+
+2009-01-20 Oliver Hunt <oliver@apple.com>
+
+ RS=Dan Bernstein
+
+ Move runtime/ByteArray to wtf/ByteArray
+
+ * ForwardingHeaders/wtf/ByteArray.h: Renamed from WebCore/ForwardingHeaders/runtime/ByteArray.h.
+ * html/CanvasRenderingContext2D.cpp:
+ * html/ImageData.cpp:
+ (WebCore::ImageData::ImageData):
+ * html/ImageData.h:
+ (WebCore::ImageData::data):
+
+2009-01-20 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23391
+ Upstream plugins/chromium/
+
+ * plugins/chromium: Added.
+ * plugins/chromium/PluginDataChromium.cpp: Added.
+
+2009-01-19 Steve Falkenburg <sfalken@apple.com>
+
+ Fix Windows release build.
+ Move SVG files into all-in-one file for Windows build.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * svg/SVGAllInOne.cpp: Added.
+
+2009-01-19 Steve Falkenburg <sfalken@apple.com>
+
+ Partial build fix.
+ Move new derived sources into all-in-one DerivedSources.cpp
+
+ * DerivedSources.cpp:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-01-19 Sam Weinig <sam@webkit.org>
+
+ Fix Qt build.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::mark):
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::valueRealType):
+ (JSC::Bindings::convertValueToQVariant):
+ (JSC::Bindings::QtRuntimeConnectionMethod::call):
+ (JSC::Bindings::QtConnectionObject::execute):
+
+2009-01-19 Sam Weinig <sam@webkit.org>
+
+ Fix wx build.
+
+ * plugins/PluginView.cpp:
+ (WebCore::getString):
+
+2009-01-19 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Gavin Barraclough.
+
+ Remove temporary operator-> from JSValuePtr.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::constructAudio):
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::toHTMLCanvasStyle):
+ (WebCore::JSCanvasRenderingContext2D::setFillColor):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
+ (WebCore::JSCanvasRenderingContext2D::strokeRect):
+ (WebCore::JSCanvasRenderingContext2D::drawImage):
+ (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
+ (WebCore::JSCanvasRenderingContext2D::setShadow):
+ (WebCore::JSCanvasRenderingContext2D::createPattern):
+ (WebCore::JSCanvasRenderingContext2D::putImageData):
+ (WebCore::JSCanvasRenderingContext2D::fillText):
+ (WebCore::JSCanvasRenderingContext2D::strokeText):
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore::JSClipboard::clearData):
+ (WebCore::JSClipboard::getData):
+ (WebCore::JSClipboard::setData):
+ (WebCore::JSClipboard::setDragImage):
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ (WebCore::toVoidCallback):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::create):
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::hasItem):
+ (WebCore::JSDOMApplicationCache::add):
+ (WebCore::JSDOMApplicationCache::remove):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::valueToStringWithNullCheck):
+ (WebCore::valueToStringWithUndefinedOrNullCheck):
+ (WebCore::reportException):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
+ * bindings/js/JSDOMStringListCustom.cpp:
+ (WebCore::JSDOMStringList::item):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+ (windowProtoFuncOpen):
+ (WebCore::toJSDOMWindow):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation):
+ (WebCore::JSDOMWindow::postMessage):
+ (WebCore::setTimeoutOrInterval):
+ (WebCore::JSDOMWindow::clearTimeout):
+ (WebCore::JSDOMWindow::clearInterval):
+ (WebCore::JSDOMWindow::atob):
+ (WebCore::JSDOMWindow::btoa):
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ (WebCore::toDOMWindow):
+ * bindings/js/JSDatabaseCustom.cpp:
+ (WebCore::JSDatabase::changeVersion):
+ (WebCore::JSDatabase::transaction):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::setLocation):
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::JSElement::setAttribute):
+ (WebCore::JSElement::setAttributeNS):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ (WebCore::JSEventTargetNode::addEventListener):
+ (WebCore::JSEventTargetNode::removeEventListener):
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions):
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::callHTMLCollection):
+ (WebCore::JSHTMLCollection::canGetItemsForName):
+ (WebCore::JSHTMLCollection::item):
+ (WebCore::JSHTMLCollection::namedItem):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::open):
+ (WebCore::writeHelper):
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ (WebCore::JSHTMLOptionsCollection::setLength):
+ (WebCore::JSHTMLOptionsCollection::add):
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ (WebCore::JSHTMLSelectElement::remove):
+ (WebCore::selectIndexSetter):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::constructImage):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+ (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::setProtocol):
+ (WebCore::JSLocation::setHost):
+ (WebCore::JSLocation::setHostname):
+ (WebCore::JSLocation::setPort):
+ (WebCore::JSLocation::setPathname):
+ (WebCore::JSLocation::setSearch):
+ (WebCore::JSLocation::setHash):
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::assign):
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::mark):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::mark):
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/JSNodeFilterCondition.h:
+ * bindings/js/JSNodeFilterCustom.cpp:
+ (WebCore::toNodeFilter):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::callNodeList):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::constructHTMLOptionElement):
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::asWrapper):
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ * bindings/js/JSSVGLengthCustom.cpp:
+ (WebCore::JSSVGLength::convertToSpecifiedUnits):
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ (WebCore::JSSVGMatrix::translate):
+ (WebCore::JSSVGMatrix::scale):
+ (WebCore::JSSVGMatrix::scaleNonUniform):
+ (WebCore::JSSVGMatrix::rotate):
+ (WebCore::JSSVGMatrix::rotateFromVector):
+ (WebCore::JSSVGMatrix::skewX):
+ (WebCore::JSSVGMatrix::skewY):
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ (WebCore::JSSVGPathSegList::getItem):
+ (WebCore::JSSVGPathSegList::insertItemBefore):
+ (WebCore::JSSVGPathSegList::replaceItem):
+ (WebCore::JSSVGPathSegList::removeItem):
+ * bindings/js/JSSVGPointListCustom.cpp:
+ (WebCore::JSSVGPointList::getItem):
+ (WebCore::JSSVGPointList::insertItemBefore):
+ (WebCore::JSSVGPointList::replaceItem):
+ (WebCore::JSSVGPointList::removeItem):
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ (WebCore::JSSVGTransformList::getItem):
+ (WebCore::JSSVGTransformList::insertItemBefore):
+ (WebCore::JSSVGTransformList::replaceItem):
+ (WebCore::JSSVGTransformList::removeItem):
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::deleteProperty):
+ (WebCore::JSStorage::customPut):
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
+ (WebCore::constructWebKitCSSMatrix):
+ * bindings/js/JSWorkerConstructor.cpp:
+ (WebCore::constructWorker):
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::open):
+ (WebCore::JSXMLHttpRequest::setRequestHeader):
+ (WebCore::JSXMLHttpRequest::send):
+ (WebCore::JSXMLHttpRequest::getResponseHeader):
+ (WebCore::JSXMLHttpRequest::overrideMimeType):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ (WebCore::JSXSLTProcessor::importStylesheet):
+ (WebCore::JSXSLTProcessor::transformToFragment):
+ (WebCore::JSXSLTProcessor::transformToDocument):
+ (WebCore::JSXSLTProcessor::setParameter):
+ (WebCore::JSXSLTProcessor::getParameter):
+ (WebCore::JSXSLTProcessor::removeParameter):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::executeFunctionInContext):
+ * bindings/js/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createScriptObjectForPluginElement):
+ * bindings/js/ScriptValue.cpp:
+ (WebCore::ScriptValue::getString):
+ (WebCore::ScriptValue::isNull):
+ (WebCore::ScriptValue::isUndefined):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_HasMethod):
+ (_NPN_Construct):
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertValueToNPVariant):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::invokeMethod):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::convertValueToJObject):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaField::dispatchValueFromInstance):
+ (JavaField::valueFromInstance):
+ (JavaField::dispatchSetValueToInstance):
+ (JavaField::setValueToInstance):
+ * bridge/jni/jni_utility.cpp:
+ (JSC::Bindings::convertArrayInstanceToJavaArray):
+ (JSC::Bindings::convertValueToJValue):
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::callObjCFallbackObject):
+ * bridge/objc/objc_utility.mm:
+ (JSC::Bindings::convertValueToObjcValue):
+ * bridge/runtime_method.cpp:
+ (JSC::callRuntimeMethod):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::getOwnPropertySlot):
+ (JSC::callRuntimeConstructor):
+
+2009-01-20 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23419
+ removal of FramePrivate.h breaks GTK+'s make dist
+
+ * GNUmakefile.am: No longer mention FramePrivate.h in our build,
+ since it was removed.
+
+2009-01-20 Alexander V. Butenko <alex@digiqube.com>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=23116
+ [GTK] Fix crash due a callback called from GIO after the
+ destruction of the ResourceHandle
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
+ 'client' is set, otherwise cancelling a load could lead to a crash.
+
+2009-01-19 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix: remove duplicate entries in the Xcode project, and
+ sort the project with sort-Xcode-project-file .
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-01-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=18078
+
+ Support animations and transitions of shorthand properties by creating
+ PropertyWrappers that simply wrap a vector of atomic wrappers, and implement
+ equal() and blend(). Build that collection of shorthand wrappers using the
+ shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
+ shorthand wrappers during 'all' transitions.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Add CSSPropertyLonghand.h/cpp.
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
+ Move CSSPropertyLonghand to its own file.
+
+ * css/CSSPropertyLonghand.cpp: Added.
+ (WebCore::initShorthandMap):
+ (WebCore::longhandForProperty):
+ * css/CSSPropertyLonghand.h: Added.
+ (WebCore::CSSPropertyLonghand::CSSPropertyLonghand):
+ (WebCore::CSSPropertyLonghand::properties):
+ (WebCore::CSSPropertyLonghand::length):
+ Code moved from CSSMutableStyleDeclaration.h/cpp
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::PropertyWrapperBase::isShorthandWrapper):
+ (WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
+ (WebCore::ShorthandPropertyWrapper::isShorthandWrapper):
+ (WebCore::ShorthandPropertyWrapper::equals):
+ (WebCore::ShorthandPropertyWrapper::blend):
+ Add a wrapper class for shorthand properties that simply wraps an
+ array of atomic property wrappers.
+
+ (WebCore::ensurePropertyMap):
+ (WebCore::addPropertyWrapper):
+ (WebCore::addShorthandProperties):
+ (WebCore::wrapperForProperty):
+ (WebCore::AnimationBase::propertiesEqual):
+ (WebCore::AnimationBase::getPropertyAtIndex):
+ Some minor refactoring to re-use wrapperForProperty(), and ensure that gPropertyWrapperMap
+ is filled with an invalid index (-1), not 0.
+
+ (WebCore::AnimationBase::blendProperties):
+ * page/animation/AnimationBase.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ When doing 'all' transitions, skip shorthand wrappers, since 'all' transitions
+ just need to compare all the atomic property wrappers.
+
+2009-01-19 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Actually add the new header.
+
+ * dom/GenericWorkerTask.h: Added.
+
+2009-01-19 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22720
+
+ Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
+ only works for methods that need 6 parameters but similar classes could be added as needed for
+ other numbers of parameters.
+
+ Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.
+
+ Use these methods and others to remove document() from XMLHttpRequest in a few more places.
+
+ No observable change in behavior, so no test.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ Sorted project file while adding GenericWorkerTask.h
+
+ * bindings/js/ScriptString.h:
+ (WebCore::ScriptString::operator=):
+ (WebCore::ScriptString::operator+=):
+ (WebCore::ScriptString::operator==):
+ (WebCore::ScriptString::operator!=):
+ Removed unnecessary JSLock.
+
+ * dom/Document.cpp:
+ (WebCore::Document::addMessage):
+ (WebCore::Document::resourceRetrievedByXMLHttpRequest):
+ * dom/Document.h:
+ * dom/GenericWorkerTask.h: Added.
+ (WebCore::GenericWorkerTaskBase::GenericWorkerTaskBase):
+ (WebCore::GenericWorkerTaskBase::canPerformTask):
+ (WebCore::GenericWorkerTask6::create):
+ (WebCore::GenericWorkerTask6::GenericWorkerTask6):
+ (WebCore::GenericWorkerTask6::performTask):
+ (WebCore::createCallbackTask):
+ * dom/ScriptExecutionContext.h:
+ * dom/WorkerContext.cpp:
+ (WebCore::addMessageTask):
+ (WebCore::WorkerContext::addMessage):
+ (WebCore::WorkerContext::resourceRetrievedByXMLHttpRequest):
+ (WebCore::WorkerContext::postTaskToParentContext):
+ * dom/WorkerContext.h:
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::postTaskToParentContext):
+ * dom/WorkerMessagingProxy.h:
+ * dom/WorkerThread.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::dropProtection):
+ (WebCore::reportUnsafeUsage):
+ (WebCore::XMLHttpRequest::setRequestHeader):
+ (WebCore::XMLHttpRequest::getResponseHeader):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::create):
+
+
+2009-01-19 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 23422: AX: AXLinks should expose access key information
+ https://bugs.webkit.org/show_bug.cgi?id=23422
+
+ Test: accessibility/accesskey.html
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+
+2009-01-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23417
+ Implement application cache obsolete state
+
+ Test: http/tests/appcache/remove-cache.html
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::mark):
+ * dom/EventNames.h:
+ * loader/appcache/DOMApplicationCache.h:
+ (WebCore::DOMApplicationCache::Status):
+ (WebCore::DOMApplicationCache::setOnobsolete):
+ (WebCore::DOMApplicationCache::onobsolete):
+ * loader/appcache/DOMApplicationCache.idl:
+ Added "obsolete" event and status.
+
+ * loader/appcache/ApplicationCacheGroup.h:
+ (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
+ any need to track what the newest cache was during teardown.
+ (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
+ confusion with cache group lifecycle status.
+ (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
+ (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
+ not belong to an obsolete group.
+ (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
+ (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
+ via a JS swapCache() call, not only when the loader is destroyed.
+ (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
+ (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
+ a caller responsibility, because this method is also used when loading caches from disk.
+ (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
+ inform cache storage, so that it could be removed.
+ (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
+ was call cacheUpdateFailed().
+ (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
+ handing.
+ (WebCore::ApplicationCacheGroup::didFail): Ditto.
+ (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
+ method for 404 and 410 responses.
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
+ directly, instead of the removed didFailToLoadManifest().
+ (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
+ after update successfully finishes (moved from setNewestCache()).
+ (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
+ an explicitly passed pointer, without the need to save it during teardown.
+
+ * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
+ Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
+
+ * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
+ some comments.
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
+ obsolete.
+ (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
+ (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
+ groups, as they cannot be in storage.
+ (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
+ completely, so that a new one could replace it, if necessary.
+ (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
+ (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
+
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
+ (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
+ application was removed server-side.
+ (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
+
+ * loader/appcache/DOMApplicationCache.h:
+ (WebCore::DOMApplicationCache::Status):
+ (WebCore::DOMApplicationCache::setOnobsolete):
+ (WebCore::DOMApplicationCache::onobsolete):
+ Added support for OBSOLETE state and obsolete event.
+
+ * loader/appcache/DOMApplicationCache.idl: Ditto.
+
+2009-01-19 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ Allow plug-in views to return an instance directly.
+
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+
+2009-01-19 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by David Hyatt.
+
+ AX: some buttons don't expose AXPress as an action
+ https://bugs.webkit.org/show_bug.cgi?id=23399
+
+ Test: accessibility/button-press-action.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::actionElement):
+
+2009-01-19 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
+ $WebKitOutputDir so that WebKit can access them.
+
+ * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
+ and header copy.
+
+2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry
+
+ [Qt] Show focus rect when a button gets the focus for the first time.
+ This is important at least for Windows style.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::applyTheme):
+
+2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ [Qt] Build fix after r39971.
+
+ * platform/qt/LoggingQt.cpp:
+ (WebCore::InitializeLoggingChannelsIfNecessary):
+
+2009-01-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
+ Remove FramePrivate
+
+ Minor PLT speedup.
+
+ * WebCore.base.exp:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/FrameLoader.cpp:
+ * page/Frame.cpp:
+ (WebCore::Frame::Frame):
+ (WebCore::Frame::~Frame):
+ (WebCore::Frame::init):
+ (WebCore::Frame::loader):
+ (WebCore::Frame::view):
+ (WebCore::Frame::setView):
+ (WebCore::Frame::script):
+ (WebCore::Frame::document):
+ (WebCore::Frame::setDocument):
+ (WebCore::Frame::settings):
+ (WebCore::Frame::selection):
+ (WebCore::Frame::editor):
+ (WebCore::Frame::selectionGranularity):
+ (WebCore::Frame::setSelectionGranularity):
+ (WebCore::Frame::dragCaretController):
+ (WebCore::Frame::animation):
+ (WebCore::Frame::mark):
+ (WebCore::Frame::setMark):
+ (WebCore::Frame::setCaretVisible):
+ (WebCore::Frame::clearCaretRectIfNeeded):
+ (WebCore::Frame::selectionLayoutChanged):
+ (WebCore::Frame::caretBlinkTimerFired):
+ (WebCore::Frame::paintCaret):
+ (WebCore::Frame::paintDragCaret):
+ (WebCore::Frame::zoomFactor):
+ (WebCore::Frame::isZoomFactorTextOnly):
+ (WebCore::Frame::shouldApplyTextZoom):
+ (WebCore::Frame::shouldApplyPageZoom):
+ (WebCore::Frame::setZoomFactor):
+ (WebCore::Frame::setPrinting):
+ (WebCore::Frame::setJSStatusBarText):
+ (WebCore::Frame::setJSDefaultStatusBarText):
+ (WebCore::Frame::jsStatusBarText):
+ (WebCore::Frame::jsDefaultStatusBarText):
+ (WebCore::Frame::setNeedsReapplyStyles):
+ (WebCore::Frame::needsReapplyStyles):
+ (WebCore::Frame::reapplyStyles):
+ (WebCore::Frame::isContentEditable):
+ (WebCore::Frame::updateSecureKeyboardEntryIfActive):
+ (WebCore::Frame::typingStyle):
+ (WebCore::Frame::setTypingStyle):
+ (WebCore::Frame::clearTypingStyle):
+ (WebCore::Frame::computeAndSetTypingStyle):
+ (WebCore::Frame::selectionComputedStyle):
+ (WebCore::Frame::applyEditingStyleToBodyElement):
+ (WebCore::Frame::removeEditingStyleFromBodyElement):
+ (WebCore::Frame::keepAlive):
+ (WebCore::Frame::cancelAllKeepAlive):
+ (WebCore::Frame::clearDOMWindow):
+ (WebCore::Frame::ownerElement):
+ (WebCore::Frame::ownerRenderer):
+ (WebCore::Frame::isDisconnected):
+ (WebCore::Frame::setIsDisconnected):
+ (WebCore::Frame::excludeFromTextSearch):
+ (WebCore::Frame::setExcludeFromTextSearch):
+ (WebCore::Frame::selectionBounds):
+ (WebCore::Frame::selectionTextRects):
+ (WebCore::Frame::isFrameSet):
+ (WebCore::Frame::currentForm):
+ (WebCore::Frame::forceLayout):
+ (WebCore::Frame::sendScrollEvent):
+ (WebCore::Frame::clearTimers):
+ (WebCore::Frame::styleForSelectionStart):
+ (WebCore::Frame::inViewSourceMode):
+ (WebCore::Frame::setInViewSourceMode):
+ (WebCore::Frame::markAllMatchesForText):
+ (WebCore::Frame::markedTextMatchesAreHighlighted):
+ (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
+ (WebCore::Frame::tree):
+ (WebCore::Frame::setDOMWindow):
+ (WebCore::Frame::domWindow):
+ (WebCore::Frame::clearFormerDOMWindow):
+ (WebCore::Frame::page):
+ (WebCore::Frame::eventHandler):
+ (WebCore::Frame::pageDestroyed):
+ (WebCore::Frame::disconnectOwnerElement):
+ (WebCore::Frame::documentAtPoint):
+ * page/Frame.h:
+ * page/FramePrivate.h: Removed.
+ * page/FrameTree.h:
+ * page/chromium/FrameChromium.cpp:
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::imageFromRect):
+ (WebCore::Frame::selectionImage):
+ (WebCore::Frame::snapshotDragImage):
+ (WebCore::Frame::nodeImage):
+ (WebCore::Frame::setUserStyleSheetLocation):
+ (WebCore::Frame::setUserStyleSheet):
+ * page/qt/FrameQt.cpp:
+ (WebCore::Frame::setUserStyleSheetLocation):
+ (WebCore::Frame::setUserStyleSheet):
+ * page/win/FrameCGWin.cpp:
+ (WebCore::Frame::nodeImage):
+ * page/win/FrameWin.cpp:
+
+2009-01-18 Eric Carlson <eric.carlson@apple.com>
+
+ Build fix for !ENABLE(VIDEO) following r40016.
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::mouseEventIsInThumb):
+
+2009-01-17 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
+ on Node is now non-virtual and just checks a bit that is set at construction time by Text.
+
+ Reviewed by Sam Weinig
+
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::CharacterData):
+ * dom/CharacterData.h:
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::EventTargetNode):
+ * dom/EventTargetNode.h:
+ * dom/Node.cpp:
+ (WebCore::Node::Node):
+ * dom/Node.h:
+ (WebCore::Node::isTextNode):
+ (WebCore::Node::isAttributeNode):
+ * dom/Text.cpp:
+ (WebCore::Text::Text):
+ * dom/Text.h:
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
+ replacement themselves, the exact transformation is instead done by the encoding (indirectly through
+ a method on Document).
+
+ These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
+ a slight speedup, and also allow encodings to do future alterations to displayed string content without
+ having to patch call sites again.
+
+ Reviewed by Oliver Hunt
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ * dom/Document.h:
+ (WebCore::Document::displayStringModifiedByEncoding):
+ (WebCore::Document::displayBufferModifiedByEncoding):
+ * editing/Editor.cpp:
+ (WebCore::Editor::addToKillRing):
+ * editing/TextIterator.cpp:
+ (WebCore::plainTextToMallocAllocatedBuffer):
+ (WebCore::plainText):
+ * editing/TextIterator.h:
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::groupLabelText):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::text):
+ * loader/DocumentLoader.cpp:
+ (WebCore::canonicalizedTitle):
+ * page/Chrome.cpp:
+ (WebCore::displayString):
+ (WebCore::Chrome::runJavaScriptAlert):
+ (WebCore::Chrome::runJavaScriptConfirm):
+ (WebCore::Chrome::runJavaScriptPrompt):
+ (WebCore::Chrome::setStatusbarText):
+ * page/Frame.cpp:
+ (WebCore::Frame::shouldClose):
+ * page/Frame.h:
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::Pasteboard::writeSelection):
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::encode):
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::TextEncoding):
+ * platform/text/TextEncoding.h:
+ (WebCore::TextEncoding::displayString):
+ (WebCore::TextEncoding::displayBuffer):
+ * rendering/HitTestResult.cpp:
+ (WebCore::displayString):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::paintReplaced):
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+ (WebCore::RenderText::setTextInternal):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setInnerTextValue):
+ (WebCore::RenderTextControl::finishText):
+
+2009-01-17 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele Peterson
+
+ Complete <rdar://problem/6293969>
+
+ * DerivedSources.make: include mediaControlsQT.css for Mac build.
+
+ * WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart,
+ CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::): Ditto.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media
+ controller element styles
+
+ * css/CSSValueKeywords.in: add keywords for new media time display controls
+
+ * css/mediaControls.css: adjust css for new control elements
+
+ * css/mediaControlsQT.css: Added.
+
+ * platform/ThemeTypes.h:
+ (WebCore::): add media time display controls to ControlPart
+
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added
+ (WebCore::MediaTextDisplayElement::attachToParent): Added
+ (WebCore::MediaTextDisplayElement::update): Added
+ (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added
+ (WebCore::MediaControlInputElement::MediaControlInputElement): Added
+ (WebCore::MediaControlInputElement::hitTest): Added
+ (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when
+ dragging the thumb
+ * rendering/MediaControlElements.h:
+ (WebCore::): Add MediaTextDisplayElement
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createTimelineContainer): Added
+ (WebCore::RenderMedia::createTimeline): Parent is now the timeline container
+ (WebCore::RenderMedia::createCurrentTimeDisplay): Added
+ (WebCore::RenderMedia::createTimeRemainingDisplay): Added
+ (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update
+ timer when the time display elements are not visible
+ (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes
+ (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not
+ visible. Display time remaining as well as current time.
+ (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when
+ visibility changes
+ (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
+ as we can't assume that all controls are rectangular
+ * rendering/RenderMedia.h: Updated
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call
+ element hitTest() method instead of assuming it is rectangular
+ * rendering/RenderSlider.h: make mouseEventIsInThumb virtual
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::paint): Deal with time display and timeline container
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::paintMediaTimelineContainer): Updated
+ (WebCore::RenderTheme::paintMediaCurrentTime): Added
+ (WebCore::RenderTheme::paintMediaTimeRemaining): Added
+
+ * rendering/RenderThemeMac.h: Updated
+ * rendering/RenderThemeMac.mm:
+ (WebCore::):
+ (WebCore::mediaControllerTheme):
+ (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb
+ size when appropriate
+ (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function
+ (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
+ (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
+ (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added
+ (WebCore::RenderThemeMac::paintMediaCurrentTime): Added
+ (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added
+ (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added
+ (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
+ * rendering/style/RenderStyle.h: Updated
+ (WebCore::):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Inline a few methods in FrameView for speed.
+
+ Reviewed by Oliver Hunt
+
+ * page/FrameView.cpp:
+ * page/FrameView.h:
+ (WebCore::FrameView::layoutCount):
+ (WebCore::FrameView::needsFullRepaint):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
+ the code that fetches and caches the document element into a separate function and inline the part that
+ does the null check and the return of the already-cached element.
+
+ Reviewed by Oliver Hunt
+
+ * dom/Document.cpp:
+ (WebCore::Document::cacheDocumentElement):
+ * dom/Document.h:
+ (WebCore::Document::documentElement):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Minor tweaks to RenderBox::styleChange to speed it up.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Inline FrameLoader::client().
+
+ Reviewed by Oliver Hunt
+
+ * WebCore.base.exp:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+ (WebCore::FrameLoader::client):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
+ than needlessly creating a rect.
+
+ Reviewed by Oliver Hunt
+
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::addClient):
+ * platform/graphics/Image.cpp:
+ * platform/graphics/Image.h:
+ (WebCore::Image::isNull):
+ (WebCore::Image::rect):
+ (WebCore::Image::width):
+ (WebCore::Image::height):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSParserValues.cpp:
+ (WebCore::CSSParserValueList::addValue):
+
+2009-01-17 David Hyatt <hyatt@apple.com>
+
+ Inline Document::inPageCache(), since - because of animation code - it is now called every time
+ styles change on any element and so is now super-hot.
+
+ Reviewed by Oliver Hunt
+
+ * dom/Document.cpp:
+ * dom/Document.h:
+ (WebCore::Document::inPageCache):
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Take Font out of the GraphicsContext. Fonts are moderately expensive to both compare and to assign to.
+ The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
+ and was also causing expensive comparison checks to be made before doing alterations of the Font in the
+ GraphicsContext.
+
+ A font must now be passed as a parameter to all text drawing functions.
+
+ Reviewed by Oliver Hunt
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setFont):
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::drawText):
+ (WebCore::GraphicsContext::drawBidiText):
+ (WebCore::GraphicsContext::drawHighlightForText):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsContextPrivate.h:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::paint):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::paintTextWithShadows):
+ (WebCore::InlineTextBox::paint):
+ (WebCore::InlineTextBox::paintSelection):
+ (WebCore::InlineTextBox::paintCompositionBackground):
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+ (WebCore::InlineTextBox::paintTextMatchMarker):
+ (WebCore::InlineTextBox::paintDocumentMarkers):
+ * rendering/InlineTextBox.h:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::paintObject):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::paintReplaced):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintItemForeground):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::paintCharacters):
+ (WebCore::SVGInlineTextBox::paintSelection):
+ * rendering/SVGInlineTextBox.h:
+ * svg/SVGFont.cpp:
+ (WebCore::Font::drawTextUsingSVGFont):
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
+ two if statements.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteRects):
+ (WebCore::RenderObject::absoluteQuads):
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Fix a regression from my before/after optimization. Make sure the <q> element puts the document
+ into a mode where it will respect before/after rules, since <q> implicitly uses such rules.
+
+ Make sure view source mode documents also turn on before/after rules, since they are used there also.
+
+ Reviewed by Oliver Hunt
+
+ * html/HTMLElementFactory.cpp:
+ (WebCore::quoteConstructor):
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
+
+2009-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23397: AXURL is not reported for <INPUT type="image"> elements
+ https://bugs.webkit.org/show_bug.cgi?id=23397
+
+ Report an AXURL for inputs that have an image type.
+
+ Test: accessibility/input-image-url.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::isInputImage):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isInputImage):
+ (WebCore::AccessibilityRenderObject::url):
+ * page/AccessibilityRenderObject.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2009-01-16 Adele Peterson <adele@apple.com>
+
+ Windows build fix.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):
+
+2009-01-16 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
+
+ This was caused by mismatched ENABLE definitions across WebCore and WebKit.
+
+ Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
+ In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
+ to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
+ Our Windows ENABLE flags now match Mac.
+
+ Reviewed by Adele Peterson.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.vcproj/build-generated-files.sh:
+
+2009-01-16 Mark Rowe <mrowe@apple.com>
+
+ 40,000!
+
+ * ChangeLog: Point out revision 40,000.
+
+2009-01-16 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Justin Garcia.
+
+ Make surroundNodeRangeWithElement call insertNodeBefore implicitly
+ Make insertNodeBefore take PassRefPtr
+ Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
+ https://bugs.webkit.org/show_bug.cgi?id=23389
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
+ (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+ * editing/ApplyStyleCommand.h:
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::insertNodeAt):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::insertTab):
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::IncreaseSelectionListLevelCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::removeNodePreservingChildren):
+ (WebCore::ReplacementFragment::insertNodeBefore):
+ (WebCore::ReplacementFragment::removeInterchangeNodes):
+ (WebCore::ReplaceSelectionCommand::doApply):
+ (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted):
+ (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
+ (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
+ * editing/ReplaceSelectionCommand.h:
+
+2009-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23393: TextField has AXTitle and AXTitleUIElement
+ https://bugs.webkit.org/show_bug.cgi?id=23393
+
+ Test: accessibility/double-title.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::title):
+
+2009-01-16 Adam Treat <adam.treat@torchmobile.com>
+
+ The correct build fix for all platforms.
+
+ * platform/graphics/Font.h:
+
+2009-01-16 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build.
+
+ * platform/graphics/Font.h:
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
+ are being used. If not, don't waste time probing for those pseudo element styles.
+
+ Reviewed by Sam Weinig
+
+ * css/CSSGrammar.y:
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::usesBeforeAfterRules):
+ (WebCore::Document::setUsesBeforeAfterRules):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleDidChange):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ (WebCore::RenderInline::addChildToFlow):
+ (WebCore::RenderInline::splitInlines):
+
+2009-01-16 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23394
+ Remove unnecessary calls to setDeferringTimers().
+
+ Use of this function was obsoleted by better handling of EINTR.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
+ was resulting in the creation of a cursor list. clearCursorList was creating a new list rather than just
+ nulling out the pointer. Since addCursor already lazily recreates the list, in the case of simple cursor types,
+ the clear method was wastefully creating a completely unnecessary list for all of these elements.
+
+ Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
+ set to the same value. Since this is the common case, it prevents a fault and copy of StyleInheritedData for
+ all links and form controls.
+
+ This is a PLT speedup.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::clearCursorList):
+
+2009-01-16 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23384
+ PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder
+
+ * history/BackForwardList.h:
+ (WebCore::BackForwardListClient::~BackForwardListClient):
+ (WebCore::BackForwardList::setClient):
+ * history/BackForwardListChromium.cpp: Added.
+
+2009-01-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Kevin Decker and Adam Roben.
+
+ - fix a regression that resulted in a crash when plug-ins were
+ disabled.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::updateWidget): Added a null check.
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Split continuation() into virtual and non-virtual versions so that the non-virtual version can
+ be used whereever possible. Eventually the virtual method can be eliminated completely.
+
+ Reviewed by Sam Weinig and Oliver Hunt
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ (WebCore::InlineFlowBox::paint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::removeChild):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ * rendering/RenderFlow.h:
+ (WebCore::RenderFlow::virtualContinuation):
+ (WebCore::RenderFlow::continuation):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::positionForCoordinates):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteRects):
+ (WebCore::RenderObject::absoluteQuads):
+ (WebCore::RenderObject::addFocusRingRects):
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
+ (WebCore::RenderObject::handleDynamicFloatPositionChange):
+ (WebCore::RenderObject::hoverAncestor):
+ (WebCore::RenderObject::updateDragState):
+ (WebCore::RenderObject::updateHitTestResult):
+ (WebCore::RenderObject::getTextDecorationColors):
+ (WebCore::RenderObject::adjustRectForOutlineAndShadow):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::virtualContinuation):
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.
+
+ Reviewed by ggaren
+
+ * platform/graphics/Font.cpp:
+ * platform/graphics/Font.h:
+ (WebCore::Font::width):
+ (WebCore::Font::ascent):
+ (WebCore::Font::descent):
+ (WebCore::Font::lineSpacing):
+ (WebCore::Font::lineGap):
+ (WebCore::Font::xHeight):
+ (WebCore::Font::unitsPerEm):
+ (WebCore::Font::spaceWidth):
+
+2009-01-16 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
+ Remove FrameViewPrivate
+
+ Removes an indirection and is a small speedup on PLT.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView):
+ (WebCore::FrameView::~FrameView):
+ (WebCore::FrameView::reset):
+ (WebCore::FrameView::resetScrollbars):
+ (WebCore::FrameView::init):
+ (WebCore::FrameView::clear):
+ (WebCore::FrameView::didFirstLayout):
+ (WebCore::FrameView::initScrollbars):
+ (WebCore::FrameView::updateDefaultScrollbarState):
+ (WebCore::FrameView::setCanHaveScrollbars):
+ (WebCore::FrameView::applyOverflowToViewport):
+ (WebCore::FrameView::layoutCount):
+ (WebCore::FrameView::needsFullRepaint):
+ (WebCore::FrameView::layoutRoot):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::setMediaType):
+ (WebCore::FrameView::mediaType):
+ (WebCore::FrameView::useSlowRepaints):
+ (WebCore::FrameView::setUseSlowRepaints):
+ (WebCore::FrameView::addSlowRepaintObject):
+ (WebCore::FrameView::removeSlowRepaintObject):
+ (WebCore::FrameView::scrollRectIntoViewRecursively):
+ (WebCore::FrameView::setScrollPosition):
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::beginDeferredRepaints):
+ (WebCore::FrameView::endDeferredRepaints):
+ (WebCore::FrameView::scheduleRelayout):
+ (WebCore::FrameView::scheduleRelayoutOfSubtree):
+ (WebCore::FrameView::layoutPending):
+ (WebCore::FrameView::needsLayout):
+ (WebCore::FrameView::unscheduleRelayout):
+ (WebCore::FrameView::isTransparent):
+ (WebCore::FrameView::setTransparent):
+ (WebCore::FrameView::baseBackgroundColor):
+ (WebCore::FrameView::setBaseBackgroundColor):
+ (WebCore::FrameView::shouldUpdateWhileOffscreen):
+ (WebCore::FrameView::setShouldUpdateWhileOffscreen):
+ (WebCore::FrameView::scheduleEvent):
+ (WebCore::FrameView::pauseScheduledEvents):
+ (WebCore::FrameView::resumeScheduledEvents):
+ (WebCore::FrameView::performPostLayoutTasks):
+ (WebCore::FrameView::updateOverflowStatus):
+ (WebCore::FrameView::dispatchScheduledEvents):
+ (WebCore::FrameView::wasScrolledByUser):
+ (WebCore::FrameView::setWasScrolledByUser):
+ (WebCore::FrameView::paintContents):
+ (WebCore::FrameView::setPaintRestriction):
+ (WebCore::FrameView::isPainting):
+ (WebCore::FrameView::setNodeToDraw):
+ * page/FrameView.h:
+ (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.
+
+2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 23237: Some HTML constructors in HTMLElementFactory needs
+ an HTMLFormElement argument
+
+ - Added 'constructorNeedsFormElement' parameter to make_names.pl to account
+ for HTML form elements.
+
+ - Added the new information to HTMLTagNames.in.
+
+ * dom/make_names.pl:
+ * html/HTMLTagNames.in:
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods. The most common reason
+ for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
+ the cross-platform graphics state. By being able to query for the current antialiasing setting, antialiasing
+ can be temporarily changed and then restored back to the real value without needing to do a save/restore.
+
+ The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
+ a permanent mutation of the fill color in the CGContext. The new code just restores the fill color back
+ to its original value without doing the much more expensive save/restore.
+
+ Reviewed by Oliver Hunt
+
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::setShouldAntialias):
+ (WebCore::GraphicsContext::shouldAntialias):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsContextPrivate.h:
+ (WebCore::GraphicsContextState::GraphicsContextState):
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::setPlatformShouldAntialias):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::drawLine):
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::drawLineForText):
+ (WebCore::GraphicsContext::setPlatformShouldAntialias):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::setPlatformShouldAntialias):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::setPlatformShouldAntialias):
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+ (WebCore::GraphicsContext::setPlatformShouldAntialias):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::paint):
+
+2009-01-16 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Clean up the bridge code and get rid of Field::name() and Method::name().
+
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::invokeMethod):
+ * bridge/c/c_runtime.cpp:
+ * bridge/c/c_runtime.h:
+ (JSC::Bindings::CField::identifier):
+ (JSC::Bindings::CMethod::identifier):
+ * bridge/jni/jni_class.cpp:
+ (JavaClass::JavaClass):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::invokeMethod):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaField::valueFromInstance):
+ (JavaField::setValueToInstance):
+ (JavaMethod::methodID):
+ * bridge/jni/jni_runtime.h:
+ (JSC::Bindings::JavaField::name):
+ (JSC::Bindings::JavaMethod::name):
+ * bridge/objc/objc_class.mm:
+ (JSC::Bindings::ObjcClass::methodsNamed):
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::invokeMethod):
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcMethod::isFallbackMethod):
+ (JSC::Bindings::ObjcMethod::selector):
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcMethod::ObjcMethod):
+ (JSC::Bindings::ObjcMethod::getMethodSignature):
+ (JSC::Bindings::ObjcField::ObjcField):
+ (JSC::Bindings::ObjcField::valueFromInstance):
+ (JSC::Bindings::ObjcField::setValueToInstance):
+ (JSC::Bindings::callObjCFallbackObject):
+ * bridge/runtime.h:
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Optimize RenderText::styleDidChange. Don't call the base class, which does extra meaningless work.
+ Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
+ Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
+ for the existence of m_parent in each if clause.
+
+ Reviewed by Darin Adler
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleDidChange):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::styleDidChange):
+
+2009-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 23387: AX hierarchy is incorrect when iframes are present
+ https://bugs.webkit.org/show_bug.cgi?id=23387
+
+ The AX hierarchy is incorrect when iframes are present.
+
+ Test: accessibility/iframe-bastardization.html
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper renderWidgetChildren]):
+
+2009-01-16 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
+ better understand what the common disqualifiers are.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::canCachePageContainingThisFrame):
+ (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe.
+ (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for
+ the back/forward cache.
+ (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis.
+ (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
+ * loader/FrameLoader.h:
+
+2009-01-16 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Test: transitions/hang-with-bad-transition-list.html
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
+ This was happening because I was calling setChanged() from inside updateRendering()
+ which causes an infinite loop. I fixed this by deferring the setChanged to the next
+ run loop iteration. That made it not infinite loop, but it still retriggers the
+ transition forever. The problem is that there is both an 'all' and specific transition
+ on 'opacity'. This tickled a bug in AnimationController which causes the opacity
+ transition to get constantly cancelled and then retriggered. The problem is that
+ the specific opacity transition has a duration of 0. I got rid of the logic to
+ flush out 0 duration transitions and it is no longer constantly triggered. The
+ logic to flush them was just an optimization, and you really need to keep them
+ around to make the logic to override earlier animations by later ones work. And there is
+ very little overhead in this case anyway, so the optimization was not that useful.
+
+ I made a LayoutTest from the original testcase which tests both the infinite
+ loop and constantly triggering animation cases.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
+ (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
+ (WebCore::AnimationController::addNodeChangeToDispatch):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::adjustAnimations):
+ (WebCore::RenderStyle::adjustTransitions):
+
+2009-01-16 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 23385: crash at com.apple.WebCore WebCore::HTMLAnchorElement::isKeyboardFocusable
+ https://bugs.webkit.org/show_bug.cgi?id=23385
+
+ Option-tabbing through the page mentioned in the bug causes a crash
+
+ Test: fast/events/tab-crash-with-image-map.html
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+
+2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fixes QString and 8-bit mix fixes.
+
+ Details: Make sure we use QLatin1String where appropriate (and don't
+ use QString when not necessary)
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::create):
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ * platform/qt/FileSystemQt.cpp:
+ (WebCore::openTemporaryFile):
+ * platform/qt/LoggingQt.cpp:
+ (WebCore::InitializeLoggingChannelsIfNecessary):
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
+ * plugins/qt/PluginDataQt.cpp:
+ (WebCore::PluginData::initPlugins):
+
+2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22452
+
+ When plugins are disabled, plugin data should not be available for
+ the page. This ensures that navigator.plugins would not see the
+ additional MIME types supported by the plugins.
+
+ * page/Page.cpp:
+ (WebCore::Page::pluginData):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::shouldUsePlugin):
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::updateWidget):
+
+2009-01-15 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
+ Also fixed the test case to work on ppc.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Another attempt at fixing the Qt build.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getInstance):
+
+2009-01-16 David Hyatt <hyatt@apple.com>
+
+ Fix for 1.85% PLT regression. Since asking if a frame is "complete" actually aggressively decodes
+ the frame, we add an optimization when advancing animations. If we have received all of the animated
+ image's data, then obviously we can go ahead and advance safely. This prevents the first draw of an image
+ from decoding two frames' worth of data in the case where all of the image's data has been received.
+
+ While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
+ as well. It's not immediately clear how that regression would be fixed, though, and it would likely be
+ a much smaller percentage of that overall uncached time.
+
+ Reviewed by Dan Bernstein
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::startAnimation):
+
+2009-01-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23349
+ Don't store obsolete caches in disk storage
+
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::ResourceLoader):
+ (WebCore::ResourceLoader::load):
+ (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
+ * loader/ResourceLoader.h:
+ Don't maintain m_wasLoadedFromApplicationCache, which was never used.
+
+ * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
+ Assert that only implicit and dynamic resources can be added after the cache has been fully
+ loaded and stored to disk database.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk
+ database, as this is now done whenever the cache becomes obsolete.
+ (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.
+
+ * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
+ A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed
+ the check to no longer rely on savedNewestCachePointer.
+
+2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>
+
+ <rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();
+
+ Reviewed by Timothy Hatcher.
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::selectorText):
+
+2009-01-15 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break
+
+ If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
+ applyInlineStyle would style node.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from
+ Range::pastLastNode() anymore. pastEndNode is the node after the last one that is fully selected, since
+ the work done in the loop that follows should only be performed on fully selected nodes.
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes.
+ Those were handled accidently before.
+ * editing/htmlediting.cpp:
+ (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number
+ of children in that container, so I changed it to match that. RenderBR and RenderObject::caretMaxOffset() should
+ also be eliminated since maxDeepOffset handles non-text nodes.
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.
+
+ * bridge/c/c_instance.h:
+ * bridge/jni/jni_instance.h:
+ * bridge/objc/objc_instance.h:
+ * bridge/qt/qt_instance.h:
+ * bridge/runtime.cpp:
+ * bridge/runtime.h:
+ * bridge/runtime_object.h:
+
+2009-01-15 David Hyatt <hyatt@apple.com>
+
+ Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
+ code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::styleDidChange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::styleDidChange):
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Another attempt at fixing the Qt build.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getOwnPropertySlot):
+ (JSC::Bindings::QtInstance::put):
+ * bridge/qt/qt_instance.h:
+ * bridge/runtime.h:
+ (JSC::Bindings::Instance::getOwnPropertySlot):
+ (JSC::Bindings::Instance::put):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::getOwnPropertySlot):
+ (JSC::RuntimeObjectImp::put):
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Add QtInstance::getInstance and start using it.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtRuntimeObjectImp::mark):
+ (JSC::Bindings::QtRuntimeObjectImp::classInfo):
+ (JSC::Bindings::):
+ (JSC::Bindings::QtInstance::getInstance):
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getOwnPropertySlot):
+ (JSC::Bindings::QtInstance::put):
+ * bridge/qt/qt_instance.h:
+ * bridge/runtime.h:
+ (JSC::Bindings::Instance::getOwnPropertySlot):
+ (JSC::Bindings::Instance::put):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::getOwnPropertySlot):
+ (JSC::RuntimeObjectImp::put):
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Fix the QT build.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::createRuntimeObject):
+ * bridge/qt/qt_instance.h:
+
+2009-01-15 David Hyatt <hyatt@apple.com>
+
+ Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor
+
+ setZoomFactor was supposed to bail if both the zoom factor and mode were the same. The mode check was
+ buggy and doing the wrong thing.
+
+ Reviewed by Darin Adler
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setZoomFactor):
+
+2009-01-15 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Make Instance::createRuntimeObject a virtual function and override it for QtInstance.
+
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::getRuntimeObject):
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertNPVariantToValue):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::invokeMethod):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::convertJObjectToValue):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaField::valueFromInstance):
+ (JavaArray::valueAt):
+ * bridge/objc/objc_utility.mm:
+ (JSC::Bindings::convertObjcValueToValue):
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getRuntimeObject):
+ (JSC::Bindings::QtInstance::createRuntimeObject):
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue):
+ (JSC::Bindings::QtConnectionObject::execute):
+ * bridge/runtime.cpp:
+ (JSC::Bindings::Instance::createRuntimeObject):
+ * bridge/runtime.h:
+
+2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23354
+ Fix up graphics/chromium files to account for Uniscribe style scrubbing.
+
+ * platform/graphics/chromium/FontChromiumWin.cpp:
+ (WebCore::windowsCanHandleTextDrawing):
+ (WebCore::Font::selectionRectForComplexText):
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+ (WebCore::fillNonBMPGlyphs):
+
+2009-01-15 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23333
+ Adjust due to a name change that happened in a WebKit.
+
+ * svg/graphics/skia/SVGPaintServerPatternSkia.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+
+2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23340
+ Add remaining bits of graphics/chromium.
+
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added.
+ (WebCore::scaleEmToUnits):
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp: Added.
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ (WebCore::SimpleFontData::smallCapsFontData):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added.
+ (WebCore::ThemeHelperWin::ThemeHelperWin):
+ (WebCore::ThemeHelperWin::~ThemeHelperWin):
+ * platform/graphics/chromium/ThemeHelperChromiumWin.h: Added.
+ (WebCore::ThemeHelperWin::):
+ (WebCore::ThemeHelperWin::context):
+ (WebCore::ThemeHelperWin::rect):
+ * platform/graphics/chromium/UniscribeHelper.cpp: Added.
+ (WebCore::treatAsSpace):
+ (WebCore::containsMissingGlyphs):
+ (WebCore::setLogFontAndStyle):
+ (WebCore::UniscribeHelper::UniscribeHelper):
+ (WebCore::UniscribeHelper::~UniscribeHelper):
+ (WebCore::UniscribeHelper::initWithOptionalLengthProtection):
+ (WebCore::UniscribeHelper::width):
+ (WebCore::UniscribeHelper::justify):
+ (WebCore::UniscribeHelper::characterToX):
+ (WebCore::UniscribeHelper::xToCharacter):
+ (WebCore::UniscribeHelper::draw):
+ (WebCore::UniscribeHelper::firstGlyphForCharacter):
+ (WebCore::UniscribeHelper::fillRuns):
+ (WebCore::UniscribeHelper::shape):
+ (WebCore::UniscribeHelper::fillShapes):
+ (WebCore::UniscribeHelper::fillScreenOrder):
+ (WebCore::UniscribeHelper::adjustSpaceAdvances):
+ (WebCore::UniscribeHelper::applySpacing):
+ (WebCore::UniscribeHelper::advanceForItem):
+ * platform/graphics/chromium/UniscribeHelper.h: Added.
+ (WebCore::UniscribeHelper::directionalOverride):
+ (WebCore::UniscribeHelper::setDirectionalOverride):
+ (WebCore::UniscribeHelper::inhibitLigate):
+ (WebCore::UniscribeHelper::setInhibitLigate):
+ (WebCore::UniscribeHelper::letterSpacing):
+ (WebCore::UniscribeHelper::setLetterSpacing):
+ (WebCore::UniscribeHelper::spaceWidth):
+ (WebCore::UniscribeHelper::setSpaceWidth):
+ (WebCore::UniscribeHelper::wordSpacing):
+ (WebCore::UniscribeHelper::setWordSpacing):
+ (WebCore::UniscribeHelper::setAscent):
+ (WebCore::UniscribeHelper::init):
+ (WebCore::UniscribeHelper::tryToPreloadFont):
+ (WebCore::UniscribeHelper::Shaping::Shaping):
+ (WebCore::UniscribeHelper::Shaping::glyphLength):
+ (WebCore::UniscribeHelper::Shaping::charLength):
+ (WebCore::UniscribeHelper::Shaping::effectiveAdvances):
+ (WebCore::UniscribeHelper::nextWinFontData):
+ (WebCore::UniscribeHelper::resetFontIndex):
+ * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added.
+ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
+ (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
+ (WebCore::UniscribeHelperTextRun::nextWinFontData):
+ (WebCore::UniscribeHelperTextRun::resetFontIndex):
+ * platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
+
+2009-01-15 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-01-15 Aaron Boodman <aa@chromium.org>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=15279
+ Right clicking over text (or multiple spaces) auto selects the word
+ (or multiple spaces) under it, which is not a desirable effect for some
+ platforms.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::sendContextMenuEvent):
+ Don't select words on right-click on Chromium.
+
+2009-01-15 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23345
+ SharedBuffer.h should include wtf/OwnPtr.h
+
+ * platform/SharedBuffer.h:
+
+2009-01-14 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23338>
+
+ Reviewed by Timothy Hatcher.
+
+ * WebCore.xcodeproj/project.pbxproj: Check to see if
+ "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector"
+ exists before trying to change directories into it and then
+ deleting, modifying and adding files to it.
+
+2009-01-14 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Fixing wx compilation for wx 2.9/trunk.
+
+ * platform/graphics/wx/FontPlatformData.h:
+ (WebCore::FontPlatformData::operator==):
+ (WebCore::FontPlatformData::computeHash):
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+ (WebCore::GraphicsContext::clip):
+ (WebCore::GraphicsContext::setCompositeOperation):
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::createFrameAtIndex):
+ * platform/graphics/wx/PathWx.cpp:
+ (WebCore::Path::contains):
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::paintButton):
+ (WebCore::RenderThemeWx::paintTextField):
+ (WebCore::RenderThemeWx::paintMenuList):
+ * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
+
+2009-01-14 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Adding WebKitCSSMatrix.
+
+ * WebCoreSources.bkl:
+
+2009-01-14 Adam Treat <adam.treat@torchmobile.com>
+
+ Prospective build fix for Qt following r39922.
+
+ * WebCore.pro:
+
+2009-01-14 Darin Adler <darin@apple.com>
+
+ Fix debug build.
+
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
+ (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
+ Use ASSERT_UNUSED.
+
+2009-01-14 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
+ <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
+
+ No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
+ we'll need a separate set of results for different themes.
+
+ * css/themeWin.css: Renable search fields. Added new rules for sub-element placement.
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the
+ desired width for the text block.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart.
+ (WebCore::RenderThemeWin::determineState): ditto.
+ (WebCore::RenderThemeWin::getClassicThemeData): ditto.
+ (WebCore::RenderThemeWin::getThemeData): ditto.
+ (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork.
+ (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto.
+ (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto.
+ (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height.
+ (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto.
+ (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.
+
+2009-01-14 Alp Toker <alp@nuanti.com>
+
+ GTK+ build fix following r39922.
+ Add WebKitCSSMatrix to the build system.
+
+ * GNUmakefile.am:
+
+2009-01-14 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implemented 2D WebKitCSSMatrix
+ https://bugs.webkit.org/show_bug.cgi?id=21421
+
+ Test: transforms/2d/cssmatrix-interface.xhtml
+
+ * DerivedSources.make:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseWebKitCSSMatrix):
+ (setJSDOMWindowBaseWebKitCSSMatrix):
+ * bindings/js/JSWebKitCSSMatrixConstructor.cpp: Added.
+ (WebCore::):
+ (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
+ (WebCore::constructWebKitCSSMatrix):
+ (WebCore::JSWebKitCSSMatrixConstructor::getConstructData):
+ * bindings/js/JSWebKitCSSMatrixConstructor.h: Added.
+ (WebCore::JSWebKitCSSMatrixConstructor::classInfo):
+ * bindings/objc/DOMInternal.h:
+ * css/WebKitCSSMatrix.cpp: Added.
+ (WebCore::WebKitCSSMatrix::WebKitCSSMatrix):
+ (WebCore::WebKitCSSMatrix::~WebKitCSSMatrix):
+ (WebCore::WebKitCSSMatrix::setMatrixValue):
+ (WebCore::WebKitCSSMatrix::multiply):
+ (WebCore::WebKitCSSMatrix::inverse):
+ (WebCore::WebKitCSSMatrix::translate):
+ (WebCore::WebKitCSSMatrix::scale):
+ (WebCore::WebKitCSSMatrix::rotate):
+ (WebCore::WebKitCSSMatrix::toString):
+ * css/WebKitCSSMatrix.h: Added.
+ (WebCore::WebKitCSSMatrix::create):
+ (WebCore::WebKitCSSMatrix::a):
+ (WebCore::WebKitCSSMatrix::b):
+ (WebCore::WebKitCSSMatrix::c):
+ (WebCore::WebKitCSSMatrix::d):
+ (WebCore::WebKitCSSMatrix::e):
+ (WebCore::WebKitCSSMatrix::f):
+ (WebCore::WebKitCSSMatrix::setA):
+ (WebCore::WebKitCSSMatrix::setB):
+ (WebCore::WebKitCSSMatrix::setC):
+ (WebCore::WebKitCSSMatrix::setD):
+ (WebCore::WebKitCSSMatrix::setE):
+ (WebCore::WebKitCSSMatrix::setF):
+ (WebCore::WebKitCSSMatrix::transform):
+ * css/WebKitCSSMatrix.idl: Added.
+
+2009-01-14 Michael Moss <mmoss@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Workaround a skia limitation on repeated patterns, and remove extra
+ transformations applied to pattern.
+ https://bugs.webkit.org/show_bug.cgi?id=23332
+
+ Fixes:
+ LayoutTests/fast/canvas/patternfill-repeat.html
+ LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
+
+ * platform/graphics/skia/PatternSkia.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+
+2009-01-14 Mark Rowe <mrowe@apple.com>
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=23334
+ Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp
+
+ Include wtf/UnusedParam.h to get UNUSED_PARAM.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::hackAroundLibXMLEntityBug):
+
+2009-01-14 David Levin <levin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23333
+ Platform code fixes. These compensate for changes in platform
+ callbacks from WebKit and minor API tweaks.
+
+ I enumerated a few below.
+
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ fontExists has been gone since r34794.
+
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::paintSkBitmap):
+
+ (WebCore::FrameData::clear):
+ r39751 changes this api to take and return a bool.
+
+ (WebCore::Image::drawPattern):
+ * platform/graphics/skia/PathSkia.cpp:
+ (WebCore::Path::apply):
+ (WebCore::boundingBoxForCurrentStroke):
+ (WebCore::Path::strokeContains):
+ * svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
+
+2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ <https://bugs.webkit.org/show_bug.cgi?id=16829>
+ Implement NPN_SetException()
+
+ This mirrors the implementation in the obj-c bindings.
+
+ Test: plugins/netscape-throw-exception.html
+
+ * bridge/NP_jsobject.cpp:
+ (_NPN_SetException):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::getExceptionString):
+ (JSC::Bindings::CInstance::setGlobalException):
+ (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
+ (JSC::Bindings::CInstance::invokeMethod):
+ (JSC::Bindings::CInstance::invokeDefaultMethod):
+ (JSC::Bindings::CInstance::invokeConstruct):
+ (JSC::Bindings::CInstance::getPropertyNames):
+ * bridge/c/c_instance.h:
+
+2009-01-14 Pierre-Olivier Latour <pol@apple.com>
+
+ Fixed build warning when LIBXML_VERSION >= 20627.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::hackAroundLibXMLEntityBug):
+
+2009-01-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23326
+ Resources are never deleted from application cache disk database
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
+ a cache is deleted. Note that this change doesn't require bumping schema version. We should
+ consider switching to foreign keys and cascade delete instead of triggers in the future.
+ (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
+ to only remove the cache itself.
+ (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
+ is done automatically when a cache is deleted.
+
+2009-01-14 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22795: favicons should be saved to webarchives
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22795>
+
+ Reviewed by Darin Adler.
+
+ Test: webarchive/test-link-rel-icon.html
+
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
+ favicon URLs to the list since no ArchiveResource or CachedResource
+ is ever created for them.
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Handle favicons as a special
+ case for all main resources.
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::close): Actually close the SQLite database
+ so that isOpen() returns false when called. Added an ASSERT() for
+ good measure.
+
+2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23321
+ Upstream more bits of graphics/chromium.
+
+ * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::operator=):
+ (WebCore::FontPlatformData::~FontPlatformData):
+ (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
+ (WebCore::FontPlatformData::hashTableDeletedFontValue):
+ (WebCore::FontPlatformData::scriptFontProperties):
+ * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
+ (WebCore::FontPlatformData::isHashTableDeletedValue):
+ (WebCore::FontPlatformData::hfont):
+ (WebCore::FontPlatformData::size):
+ (WebCore::FontPlatformData::hash):
+ (WebCore::FontPlatformData::operator==):
+ (WebCore::FontPlatformData::scriptCache):
+ (WebCore::FontPlatformData::RefCountedHFONT::create):
+ (WebCore::FontPlatformData::RefCountedHFONT::hfont):
+ (WebCore::FontPlatformData::RefCountedHFONT::hash):
+ (WebCore::FontPlatformData::RefCountedHFONT::operator==):
+ (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::~FontPlatformData):
+ (WebCore::FontPlatformData::operator=):
+ (WebCore::FontPlatformData::setupPaint):
+ (WebCore::FontPlatformData::operator==):
+ (WebCore::FontPlatformData::hash):
+ (WebCore::FontPlatformData::isFixedPitch):
+ * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::size):
+ (WebCore::FontPlatformData::isHashTableDeletedValue):
+ (WebCore::FontPlatformData::hashTableDeletedFontValue):
+ * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
+ (WebCore::):
+ (WebCore::FontMap::getAscent):
+ (WebCore::FontMap::FontData::FontData):
+ (WebCore::getFontFamilyForScript):
+ (WebCore::getFallbackFamily):
+ (WebCore::getDerivedFontData):
+ (WebCore::getStyleFromLogfont):
+ * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
+ (WebCore::):
+
+2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23325
+ Upstream even more graphics/chromium bits.
+
+ * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
+ (WebCore::fillEmptyGlyphs):
+ (WebCore::initSpaceGlyph):
+ (WebCore::fillBMPGlyphs):
+ (WebCore::fillNonBMPGlyphs):
+ (WebCore::GlyphPage::fill):
+ * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
+ (WebCore::GlyphPage::fill):
+ * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
+ (WebCore::Icon::Icon):
+ (WebCore::Icon::~Icon):
+ (WebCore::Icon::createIconForFile):
+ (WebCore::Icon::createIconForFiles):
+ (WebCore::Icon::paint):
+ * platform/graphics/chromium/IconChromiumMac.cpp: Added.
+ (WebCore::Icon::createIconForFile):
+ (WebCore::Icon::createIconForFiles):
+ (WebCore::Icon::~Icon):
+ (WebCore::Icon::paint):
+ * platform/graphics/chromium/IconChromiumWin.cpp: Added.
+ (WebCore::Icon::Icon):
+ (WebCore::Icon::~Icon):
+ (WebCore::Icon::createIconForFile):
+ (WebCore::Icon::createIconForFiles):
+ (WebCore::Icon::paint):
+ * platform/graphics/chromium/ImageBufferData.h: Added.
+ * platform/graphics/chromium/ImageChromiumMac.mm: Added.
+ (WebCore::Image::loadPlatformResource):
+ (WebCore::BitmapImage::initPlatformData):
+ (WebCore::BitmapImage::invalidatePlatformData):
+ * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
+ * platform/graphics/chromium/PlatformIcon.h: Added.
+
+2009-01-14 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23328
+ Upstream remaining files from platform/chromium/
+
+ * platform/chromium/CursorChromium.cpp:
+ (WebCore::pointerCursor):
+ (WebCore::crossCursor):
+ (WebCore::handCursor):
+ (WebCore::iBeamCursor):
+ (WebCore::waitCursor):
+ (WebCore::helpCursor):
+ (WebCore::eastResizeCursor):
+ (WebCore::northResizeCursor):
+ (WebCore::northEastResizeCursor):
+ (WebCore::northWestResizeCursor):
+ (WebCore::southResizeCursor):
+ (WebCore::southEastResizeCursor):
+ (WebCore::southWestResizeCursor):
+ (WebCore::westResizeCursor):
+ (WebCore::northSouthResizeCursor):
+ (WebCore::eastWestResizeCursor):
+ (WebCore::northEastSouthWestResizeCursor):
+ (WebCore::northWestSouthEastResizeCursor):
+ (WebCore::columnResizeCursor):
+ (WebCore::rowResizeCursor):
+ (WebCore::middlePanningCursor):
+ (WebCore::eastPanningCursor):
+ (WebCore::northPanningCursor):
+ (WebCore::northEastPanningCursor):
+ (WebCore::northWestPanningCursor):
+ (WebCore::southPanningCursor):
+ (WebCore::southEastPanningCursor):
+ (WebCore::southWestPanningCursor):
+ (WebCore::westPanningCursor):
+ (WebCore::moveCursor):
+ (WebCore::verticalTextCursor):
+ (WebCore::cellCursor):
+ (WebCore::contextMenuCursor):
+ (WebCore::aliasCursor):
+ (WebCore::progressCursor):
+ (WebCore::noDropCursor):
+ (WebCore::copyCursor):
+ (WebCore::noneCursor):
+ (WebCore::notAllowedCursor):
+ (WebCore::zoomInCursor):
+ (WebCore::zoomOutCursor):
+ * platform/chromium/DragDataRef.h: Added.
+ * platform/chromium/DragImageChromium.cpp: Added.
+ (WebCore::dragImageSize):
+ (WebCore::deleteDragImage):
+ (WebCore::scaleDragImage):
+ (WebCore::dissolveDragImageToFraction):
+ (WebCore::createDragImageFromImage):
+ (WebCore::createDragImageIconForCachedImage):
+ * platform/chromium/DragImageRef.h:
+ * platform/chromium/KeyCodeConversion.h: Added.
+ * platform/chromium/KeyCodeConversionGtk.cpp: Added.
+ (WebCore::windowsKeyCodeForKeyEvent):
+ * platform/chromium/KeyboardCodes.h: Added.
+ * platform/chromium/KeyboardCodesPosix.h: Added.
+ (WebCore::):
+ * platform/chromium/KeyboardCodesWin.h: Added.
+ (WebCore::):
+ * platform/chromium/Language.cpp: Added.
+ (WebCore::defaultLanguage):
+ * platform/chromium/LinkHashChromium.cpp: Added.
+ (WebCore::visitedLinkHash):
+ * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+ (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
+ (WebCore::MIMETypeRegistry::getMIMETypeForPath):
+ (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
+ (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
+ (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
+ (WebCore::dummyHashSet):
+ (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
+ (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
+ (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
+ (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
+ (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
+ * platform/chromium/PasteboardChromium.cpp: Added.
+ (WebCore::Pasteboard::generalPasteboard):
+ (WebCore::Pasteboard::Pasteboard):
+ (WebCore::Pasteboard::clear):
+ (WebCore::Pasteboard::writeSelection):
+ (WebCore::Pasteboard::writeURL):
+ (WebCore::Pasteboard::writeImage):
+ (WebCore::Pasteboard::canSmartReplace):
+ (WebCore::Pasteboard::plainText):
+ (WebCore::Pasteboard::documentFragment):
+ * platform/chromium/PasteboardPrivate.h:
+ * platform/chromium/PlatformCursor.h: Added.
+ (WebCore::PlatformCursor::):
+ (WebCore::PlatformCursor::PlatformCursor):
+ (WebCore::PlatformCursor::customImage):
+ (WebCore::PlatformCursor::hotSpot):
+ (WebCore::PlatformCursor::type):
+ * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
+ (WebCore::PlatformKeyboardEvent::currentCapsLockState):
+ * platform/chromium/PlatformScreenChromium.cpp: Added.
+ (WebCore::screenDepth):
+ (WebCore::screenDepthPerComponent):
+ (WebCore::screenIsMonochrome):
+ (WebCore::screenRect):
+ (WebCore::screenAvailableRect):
+ * platform/chromium/PlatformWidget.h:
+ * platform/chromium/PopupMenuChromium.cpp: Added.
+ (WebCore::PopupListBox::selectedIndex):
+ (WebCore::PopupListBox::numItems):
+ (WebCore::PopupListBox::setBaseWidth):
+ (WebCore::PopupListBox::setTextOnIndexChange):
+ (WebCore::PopupListBox::setAcceptOnAbandon):
+ (WebCore::PopupListBox::):
+ (WebCore::PopupListBox::ListItem::ListItem):
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupListBox::~PopupListBox):
+ (WebCore::PopupListBox::disconnectClient):
+ (WebCore::PopupListBox::scrollToRevealSelection):
+ (WebCore::constructRelativeMouseEvent):
+ (WebCore::constructRelativeWheelEvent):
+ (WebCore::PopupContainer::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::~PopupContainer):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::hidePopup):
+ (WebCore::PopupContainer::layout):
+ (WebCore::PopupContainer::handleMouseDownEvent):
+ (WebCore::PopupContainer::handleMouseMoveEvent):
+ (WebCore::PopupContainer::handleMouseReleaseEvent):
+ (WebCore::PopupContainer::handleWheelEvent):
+ (WebCore::PopupContainer::handleKeyEvent):
+ (WebCore::PopupContainer::hide):
+ (WebCore::PopupContainer::paint):
+ (WebCore::PopupContainer::paintBorder):
+ (WebCore::PopupContainer::isInterestedInEventForKey):
+ (WebCore::PopupContainer::show):
+ (WebCore::PopupContainer::setTextOnIndexChange):
+ (WebCore::PopupContainer::setAcceptOnAbandon):
+ (WebCore::PopupContainer::refresh):
+ (WebCore::PopupListBox::handleMouseDownEvent):
+ (WebCore::PopupListBox::handleMouseMoveEvent):
+ (WebCore::PopupListBox::handleMouseReleaseEvent):
+ (WebCore::PopupListBox::handleWheelEvent):
+ (WebCore::PopupListBox::isInterestedInEventForKey):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::hostWindow):
+ (WebCore::PopupListBox::invalidateRect):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::PopupListBox::typeAheadFind):
+ (WebCore::PopupListBox::paint):
+ (WebCore::PopupListBox::paintRow):
+ (WebCore::PopupListBox::getRowFont):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::pointToRowIndex):
+ (WebCore::PopupListBox::acceptIndex):
+ (WebCore::PopupListBox::selectIndex):
+ (WebCore::PopupListBox::setOriginalIndex):
+ (WebCore::PopupListBox::getRowHeight):
+ (WebCore::PopupListBox::getRowBounds):
+ (WebCore::PopupListBox::invalidateRow):
+ (WebCore::PopupListBox::scrollToRevealRow):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::adjustSelectedIndex):
+ (WebCore::PopupListBox::updateFromElement):
+ (WebCore::PopupListBox::layout):
+ (WebCore::PopupListBox::clear):
+ (WebCore::PopupListBox::isPointInBounds):
+ (WebCore::PopupMenu::PopupMenu):
+ (WebCore::PopupMenu::~PopupMenu):
+ (WebCore::PopupMenu::show):
+ (WebCore::PopupMenu::hide):
+ (WebCore::PopupMenu::updateFromElement):
+ (WebCore::PopupMenu::itemWritingDirectionIsNatural):
+ * platform/chromium/PopupMenuChromium.h: Added.
+ (WebCore::PopupContainer::listBox):
+ * platform/chromium/PopupMenuPrivate.h: Added.
+ * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
+ (WebCore::supportedKeySizes):
+ * platform/chromium/ScrollbarThemeChromium.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
+ (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
+ (WebCore::ScrollbarThemeChromium::themeChanged):
+ (WebCore::ScrollbarThemeChromium::hasThumb):
+ (WebCore::ScrollbarThemeChromium::backButtonRect):
+ (WebCore::ScrollbarThemeChromium::forwardButtonRect):
+ (WebCore::ScrollbarThemeChromium::trackRect):
+ (WebCore::ScrollbarThemeChromium::paintTrackBackground):
+ (WebCore::ScrollbarThemeChromium::paintTickmarks):
+ (WebCore::ScrollbarThemeChromium::paintScrollCorner):
+ (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
+ (WebCore::ScrollbarThemeChromium::buttonSize):
+ * platform/chromium/ScrollbarThemeChromium.h: Added.
+ (WebCore::ScrollbarThemeChromium::hasButtons):
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
+ (WebCore::ScrollbarThemeChromium::scrollbarThickness):
+ (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
+ (WebCore::initMozState):
+ (WebCore::paintScrollbarWidget):
+ (WebCore::ScrollbarThemeChromium::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromium::paintButton):
+ (WebCore::ScrollbarThemeChromium::paintThumb):
+ * platform/chromium/ScrollbarThemeChromiumWin.cpp:
+ * platform/chromium/SearchPopupMenuChromium.cpp: Added.
+ (WebCore::SearchPopupMenu::SearchPopupMenu):
+ (WebCore::SearchPopupMenu::enabled):
+ (WebCore::SearchPopupMenu::saveRecentSearches):
+ (WebCore::SearchPopupMenu::loadRecentSearches):
+ * platform/chromium/SharedTimerChromium.cpp: Added.
+ (WebCore::setSharedTimerFiredFunction):
+ (WebCore::setSharedTimerFireTime):
+ (WebCore::stopSharedTimer):
+ * platform/chromium/TemporaryLinkStubs.cpp: Added.
+ (WebCore::signedPublicKeyAndChallengeString):
+ (WebCore::getSupportedKeySizes):
+ (WebCore::KURL::fileSystemPath):
+ (WebCore::SharedBuffer::createWithContentsOfFile):
+ (WTF::scheduleDispatchFunctionsOnMainThread):
+
+2009-01-14 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23323
+ Upstream platform/text/chromium/
+
+ * platform/text/chromium: Added.
+ * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
+ (WebCore::currentTextBreakLocaleID):
+
+2009-01-14 Steve Falkenburg <sfalken@apple.com>
+
+ Update copyright year in version resources.
+
+ Reviewed by Adam Roben.
+
+ * WebCore.vcproj/QTMovieWin.rc:
+
+2009-01-14 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23324
+ Move platform/chromium/EditorChromium.cpp into editing/chromium/
+
+ * editing/chromium: Added.
+ * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
+ * platform/chromium/EditorChromium.cpp: Removed.
+
+2009-01-14 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23320
+ Make it possible to use notImplemented outside of the WebCore namespace
+
+ * platform/NotImplemented.h:
+
+2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=22476
+ Check that the document's SecurityOrigin canLoadLocalResources,
+ when pages try to put NSFilenamesPboardtype data on the clipboard,
+ by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
+
+ Tests: http/tests/security/dataTransfer-set-data-file-url.html
+ platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
+
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::ClipboardMac::setData):
+
+2009-01-14 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - update copyright
+
+ * Info.plist:
+
+2009-01-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23316
+ Application cache updating always fails with an assertion
+
+ Test: http/tests/appcache/update-cache.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
+ multiple caches survive the last DocumentLoader destruction, preventing a crash in release
+ builds.
+ (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
+
+2009-01-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Release build fix.
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
+
+2009-01-13 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Test: http/tests/appcache/xhr-foreign-resource.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=23256
+ Implement application cache foreign entries
+
+ * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
+ Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
+ If a document that was loaded from appcache should be associated with a different cache,
+ mark the resource as foreign in the original cache and start over.
+
+ * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
+ This function can now be called after a cache is stored, so it no longer asserts the opposite.
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
+ in-memory caches that were already rejected.
+ (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
+ (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
+ an already stored cached resource.
+
+ * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
+
+2009-01-13 Mark Rowe <mrowe@apple.com>
+
+ Fix the Tiger WebCore build after r39880.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::markBadGrammar):
+ * loader/mac/DocumentLoaderMac.cpp:
+ (WebCore::DocumentLoader::schedule):
+ (WebCore::DocumentLoader::unschedule):
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::Pasteboard::writeSelection):
+ * platform/mac/WebCoreObjCExtras.mm:
+ (WebCoreObjCFinalizeOnMainThread):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::schedule):
+ (WebCore::ResourceHandle::unschedule):
+
+2009-01-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23102: turn on unused parameter warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23102
+
+ Last step: Turn on the warning and fix the last few instances.
+
+ * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
+ WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseMessageChannel): Separate the version for use when
+ CHANNEL_MESSAGING is turned off, so we can omit the argument names.
+ It would be better to not even have this property in that case,
+ rather than having the function return undefined, but I don't know
+ how to do that with the bindings script.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
+ functions where they're not used (the SVG context, and the property
+ name in the index getter). Use UNUSED_PARAM where arguments are
+ sometimes not used.
+
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
+ (WebCore::transitionMediaFeatureEval): Ditto.
+ (WebCore::transform_2dMediaFeatureEval): Ditto.
+ (WebCore::transform_3dMediaFeatureEval): Ditto.
+
+ * dom/make_names.pl: Leave out the createdByParser property name in
+ cases where it's not used.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
+ version for the Mac platform so we can omit the argument names.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
+
+ * loader/FrameLoaderClient.h:
+ (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
+ argument name.
+
+ * loader/icon/IconFetcher.cpp:
+ (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
+ (WebCore::IconFetcher::didReceiveData): Ditto.
+ (WebCore::IconFetcher::didFinishLoading): Ditto.
+ (WebCore::IconFetcher::didFail): Ditto.
+
+ * platform/KURL.cpp:
+ (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
+ we can omit the argument names.
+
+ * platform/Timer.cpp:
+ (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
+
+ * platform/graphics/GlyphBuffer.h:
+ (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
+ (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::clear): Removed argument name.
+
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
+ is not enabled.
+ (WebCore::finishRenderSVGContent): Ditto.
+
+2009-01-13 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
+ Simple fix to convertToLength to catch style==null cases
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::convertToLength):
+
+2009-01-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Speculative fix for an Uninitialized Memory Read (UMR)
+ seen by purify in chormium's equivalent V8 file.
+
+ * bindings/js/JSSVGPODTypeWrapper.h:
+ (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
+
+2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Land portions of platform/graphics/chromium.
+ https://bugs.webkit.org/show_bug.cgi?id=23297
+
+ * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
+ (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
+ (WebCore::FontCustomPlatformData::fontPlatformData):
+ (WebCore::EOTStream::EOTStream):
+ (WebCore::EOTStream::read):
+ (WebCore::readEmbedProc):
+ (WebCore::createUniqueFontName):
+ (WebCore::createFontCustomPlatformData):
+ * platform/graphics/chromium/FontCustomPlatformData.h: Added.
+ (WebCore::FontCustomPlatformData::FontCustomPlatformData):
+ * platform/graphics/chromium/FontLinux.cpp: Added.
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ * platform/graphics/chromium/FontPlatformData.h: Added.
+
+2009-01-13 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Don't copy DOMStringList.idl into the framework bundle.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2009-01-13 Christian Dywan <christian@twotoasts.de>
+
+ Build fix, StorageEvent is only defined if we have DOM_STORAGE
+
+ * dom/Document.cpp:
+ (WebCore::Document::createEvent): Conditionalize StorageEvent
+
+2009-01-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Bug 23277: space bar scrolls the page when typed in any text field
+ https://bugs.webkit.org/show_bug.cgi?id=23277
+ rdar://problem/6490249
+
+ There's already a regression test for this, since bug 16421 was the same problem, but on
+ Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
+
+ This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
+ a text input event from being generated at all. That difference may in itself be a bug, but
+ the only symptom is that you get text input events in more cases on platforms other than Mac.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
+ handled, not the result of the dispatchEvent function, which indicates only whether the
+ default behavior was prevented, not if the default behavior did some insertion. This fix
+ makes it so the keyboard event handler can detect that no space was inserted and know that
+ the space bar keypress event can be treated as a scrolling command.
+ (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
+ keydown event. Without the change above, making this change would have restored the old
+ behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
+
+2009-01-13 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Landing portions of platform/chromium/, taken from here:
+ http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
+
+ * platform/chromium/ChromiumBridge.h: Added.
+ * platform/chromium/ChromiumDataObject.cpp: Added.
+ (WebCore::ChromiumDataObject::clear):
+ (WebCore::ChromiumDataObject::hasData):
+ * platform/chromium/ChromiumDataObject.h: Added.
+ (WebCore::ChromiumDataObject::create):
+ (WebCore::ChromiumDataObject::ChromiumDataObject):
+ * platform/chromium/ClipboardChromium.cpp: Added.
+ (WebCore::):
+ (WebCore::clipboardTypeFromMIMEType):
+ (WebCore::ClipboardChromium::ClipboardChromium):
+ (WebCore::ClipboardChromium::create):
+ (WebCore::ClipboardChromium::clearData):
+ (WebCore::ClipboardChromium::clearAllData):
+ (WebCore::ClipboardChromium::getData):
+ (WebCore::ClipboardChromium::setData):
+ (WebCore::ClipboardChromium::types):
+ (WebCore::ClipboardChromium::setDragImage):
+ (WebCore::ClipboardChromium::setDragImageElement):
+ (WebCore::ClipboardChromium::createDragImage):
+ (WebCore::imageToMarkup):
+ (WebCore::getCachedImage):
+ (WebCore::writeImageToDataObject):
+ (WebCore::ClipboardChromium::declareAndWriteDragImage):
+ (WebCore::ClipboardChromium::writeURL):
+ (WebCore::ClipboardChromium::writeRange):
+ (WebCore::ClipboardChromium::hasData):
+ * platform/chromium/ClipboardChromium.h: Added.
+ (WebCore::ClipboardChromium::~ClipboardChromium):
+ (WebCore::ClipboardChromium::dataObject):
+ * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
+ (WebCore::replaceNewlinesWithWindowsStyleNewlines):
+ (WebCore::replaceNBSPWithSpace):
+ (WebCore::urlToMarkup):
+ * platform/chromium/ClipboardUtilitiesChromium.h: Added.
+ * platform/chromium/ContextMenuChromium.cpp: Added.
+ (WebCore::ContextMenu::ContextMenu):
+ (WebCore::ContextMenu::~ContextMenu):
+ (WebCore::ContextMenu::itemCount):
+ (WebCore::ContextMenu::insertItem):
+ (WebCore::ContextMenu::appendItem):
+ (WebCore::ContextMenu::itemWithAction):
+ (WebCore::ContextMenu::itemAtIndex):
+ (WebCore::ContextMenu::setPlatformDescription):
+ (WebCore::ContextMenu::platformDescription):
+ (WebCore::ContextMenu::releasePlatformDescription):
+ * platform/chromium/ContextMenuItemChromium.cpp: Added.
+ (WebCore::ContextMenuItem::ContextMenuItem):
+ (WebCore::ContextMenuItem::~ContextMenuItem):
+ (WebCore::ContextMenuItem::releasePlatformDescription):
+ (WebCore::ContextMenuItem::type):
+ (WebCore::ContextMenuItem::action):
+ (WebCore::ContextMenuItem::title):
+ (WebCore::ContextMenuItem::platformSubMenu):
+ (WebCore::ContextMenuItem::setType):
+ (WebCore::ContextMenuItem::setAction):
+ (WebCore::ContextMenuItem::setTitle):
+ (WebCore::ContextMenuItem::setSubMenu):
+ (WebCore::ContextMenuItem::setChecked):
+ (WebCore::ContextMenuItem::setEnabled):
+ (WebCore::ContextMenuItem::enabled):
+ * platform/chromium/CursorChromium.cpp: Added.
+ (WebCore::Cursor::Cursor):
+ (WebCore::Cursor::~Cursor):
+ (WebCore::Cursor::operator=):
+ (WebCore::pointerCursor):
+ (WebCore::crossCursor):
+ (WebCore::handCursor):
+ (WebCore::iBeamCursor):
+ (WebCore::waitCursor):
+ (WebCore::helpCursor):
+ (WebCore::eastResizeCursor):
+ (WebCore::northResizeCursor):
+ (WebCore::northEastResizeCursor):
+ (WebCore::northWestResizeCursor):
+ (WebCore::southResizeCursor):
+ (WebCore::southEastResizeCursor):
+ (WebCore::southWestResizeCursor):
+ (WebCore::westResizeCursor):
+ (WebCore::northSouthResizeCursor):
+ (WebCore::eastWestResizeCursor):
+ (WebCore::northEastSouthWestResizeCursor):
+ (WebCore::northWestSouthEastResizeCursor):
+ (WebCore::columnResizeCursor):
+ (WebCore::rowResizeCursor):
+ (WebCore::middlePanningCursor):
+ (WebCore::eastPanningCursor):
+ (WebCore::northPanningCursor):
+ (WebCore::northEastPanningCursor):
+ (WebCore::northWestPanningCursor):
+ (WebCore::southPanningCursor):
+ (WebCore::southEastPanningCursor):
+ (WebCore::southWestPanningCursor):
+ (WebCore::westPanningCursor):
+ (WebCore::moveCursor):
+ (WebCore::verticalTextCursor):
+ (WebCore::cellCursor):
+ (WebCore::contextMenuCursor):
+ (WebCore::aliasCursor):
+ (WebCore::progressCursor):
+ (WebCore::noDropCursor):
+ (WebCore::copyCursor):
+ (WebCore::noneCursor):
+ (WebCore::notAllowedCursor):
+ (WebCore::zoomInCursor):
+ (WebCore::zoomOutCursor):
+ (WebCore::grabCursor):
+ (WebCore::grabbingCursor):
+ * platform/chromium/DragDataChromium.cpp: Added.
+ (WebCore::containsHTML):
+ (WebCore::DragData::createClipboard):
+ (WebCore::DragData::containsURL):
+ (WebCore::DragData::asURL):
+ (WebCore::DragData::containsFiles):
+ (WebCore::DragData::asFilenames):
+ (WebCore::DragData::containsPlainText):
+ (WebCore::DragData::asPlainText):
+ (WebCore::DragData::containsColor):
+ (WebCore::DragData::canSmartReplace):
+ (WebCore::DragData::containsCompatibleContent):
+ (WebCore::DragData::asFragment):
+ (WebCore::DragData::asColor):
+ * platform/chromium/EditorChromium.cpp: Added.
+ (WebCore::Editor::newGeneralClipboard):
+ * platform/chromium/FileChooserChromium.cpp: Added.
+ (WebCore::FileChooser::basenameForWidth):
+ * platform/chromium/FileSystemChromium.cpp: Added.
+ (WebCore::deleteFile):
+ (WebCore::deleteEmptyDirectory):
+ (WebCore::getFileSize):
+ (WebCore::getFileModificationTime):
+ (WebCore::directoryName):
+ (WebCore::pathByAppendingComponent):
+ (WebCore::makeAllDirectories):
+ (WebCore::fileExists):
+ * platform/chromium/FileSystemChromiumLinux.cpp: Added.
+ (WebCore::pathGetFileName):
+ * platform/chromium/FileSystemChromiumMac.mm: Added.
+ (WebCore::pathGetFileName):
+ * platform/chromium/FileSystemChromiumWin.cpp: Added.
+ (WebCore::pathGetFileName):
+ * platform/chromium/FramelessScrollView.cpp: Added.
+ (WebCore::FramelessScrollView::~FramelessScrollView):
+ (WebCore::FramelessScrollView::invalidateScrollbarRect):
+ (WebCore::FramelessScrollView::isActive):
+ (WebCore::FramelessScrollView::invalidateRect):
+ (WebCore::FramelessScrollView::hostWindow):
+ (WebCore::FramelessScrollView::windowClipRect):
+ (WebCore::FramelessScrollView::paintContents):
+ (WebCore::FramelessScrollView::contentsResized):
+ (WebCore::FramelessScrollView::visibleContentsResized):
+ * platform/chromium/FramelessScrollView.h: Added.
+ (WebCore::FramelessScrollView::FramelessScrollView):
+ (WebCore::FramelessScrollView::client):
+ (WebCore::FramelessScrollView::setClient):
+ * platform/chromium/FramelessScrollViewClient.h: Added.
+ * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
+ (WebCore::):
+ (WebCore::ScrollbarThemeChromium::scrollbarThickness):
+ (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
+ (WebCore::ScrollbarThemeChromium::paintTrackPiece):
+ (WebCore::ScrollbarThemeChromium::paintButton):
+ (WebCore::ScrollbarThemeChromium::paintThumb):
+ (WebCore::ScrollbarThemeChromium::getThemeState):
+ (WebCore::ScrollbarThemeChromium::getThemeArrowState):
+ (WebCore::ScrollbarThemeChromium::getClassicThemeState):
+ * platform/chromium/SoundChromiumPosix.cpp: Added.
+ (WebCore::systemBeep):
+ * platform/chromium/SoundChromiumWin.cpp: Added.
+ (WebCore::systemBeep):
+ * platform/chromium/SystemTimeChromium.cpp: Added.
+ (WebCore::currentTime):
+ (WebCore::userIdleTime):
+ * platform/chromium/WidgetChromium.cpp: Added.
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ (WebCore::Widget::setCursor):
+ (WebCore::Widget::paint):
+ (WebCore::Widget::setFocus):
+ (WebCore::Widget::setIsSelected):
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * platform/chromium/WindowsVersion.cpp: Added.
+ (WebCore::isVistaOrNewer):
+ * platform/chromium/WindowsVersion.h: Added.
+
+2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Make sure media elements dispatch the 'loaded' event
+
+ We assume that when Phonon goes into paused state that we have the
+ complete media file. Once we do media loading ourselves we can
+ distinguish between loading the first frame and the complete media.
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::updateStates):
+
+2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Add more verbose error output when loading NPAPI plugins
+
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::load):
+
+2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix crash in the Qt port when deleting a popup from within a
+ JavaScript onchange handler.
+
+ * platform/qt/QWebPopup.cpp:
+ (WebCore::QWebPopup::QWebPopup): Perform the activation of the
+ combobox item (i.e. the call to the JS handler) from a different
+ call stack by using a queued connection.
+
+2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [GIO] Make sure to untef the GFile and the GInputStream on destruction
+
+ Make sure to call cleanupGioOperation from the ResourceHandleInternal
+ d'tor. Change the signature of cleanupGioOperation so we can do the
+ cleanup of GIO next to the cleanup of SOUP.
+
+ This is happening with many tests from dom/html/level2/html e.g.
+ LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
+ (WebCore::cleanupGioOperation):
+ (WebCore::closeCallback):
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+
+2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [GIO] Attach the ResourceHandle to the GObject and get it from the GObject
+
+ https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
+
+ Sometimes it is not possible to cancel a pending GIO operation and the
+ callback might be invoked with a pointer to an already destructed
+ ResourceHandle. To avoid this issue we will attach the ResourceHandle
+ to the GObject* and in the callback attempt to get the ResourceHandle
+ from the GObject*. If no ResourceHandle is attached we silently fail
+ as the cleanup has been already done.
+
+ This is happening with many tests from dom/html/level2/html e.g.
+ LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::cleanupGioOperation):
+ (WebCore::closeCallback):
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+ (WebCore::ResourceHandle::startGio):
+
+2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
+
+ https://bugs.webkit.org/show_bug.cgi?id=23116
+
+ The ResourceHandle becomes invalid (e.g. got destructed) from within
+ the invocation of didFail. Avoid this by cleaning up everything before
+ calling didFail and simply return afterwards.
+
+ This is happening with many tests from dom/html/level2/html e.g.
+ LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+
+2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Change how themes adjust mediaControls.css to match html4/quicks.css
+
+ Instead of providing the full style sheet, the themes provide extra
+ overrides to the default style defined in UserAgentStyleSheetsData.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23210
+
+ Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
+ build time for the Qt port.
+
+ * Resources/WebKitResources.qrc: Removed. Merged into WebCore.qrc
+ * WebCore.pro:
+ * WebCore.qrc: Added.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::styleForElement):
+ * css/qt/mediaControls-extras.css: Rename from html4-adjustments-qt.css
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
+ * platform/qt/RenderThemeQt.h:
+ * platform/qt/WebCoreResources.qrc: Removed.
+ * platform/qt/html4-adjustments-qt.css: Rename to mediaControls-extras.css
+ * rendering/RenderTheme.cpp:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::extraMediaControlsStyleSheet):
+
+2009-01-12 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
+
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+
+2009-01-12 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
+
+ I added a common getElapsedTime() function to AnimationBase which uses a combination of
+ the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
+ states.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::progress):
+ (WebCore::AnimationBase::getElapsedTime):
+ * page/animation/AnimationBase.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+
+2009-01-12 Robert Blaut <webkit@blaut.biz>
+
+ Reviewed by Darin Adler
+
+ Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
+ Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds
+ instead of miliseconds
+
+ Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::validUnit): treat unitless values in quirks mode
+ as miliseconds instead of seconds.
+
+2009-01-12 David Hyatt <hyatt@apple.com>
+
+ Apply the same idea as the previous fix but for matched declarations.
+
+ Reviewed by Dan Bernstein
+
+ * css/CSSStyleSelector.h:
+
+2009-01-12 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin Adler
+
+ <rdar://problem/6468274> - Track Non-get requests in global history
+
+ * WebCore.base.exp:
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ * history/HistoryItem.h:
+ (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
+ (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
+
+2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ !ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header
+ so it can be used by all builds.
+
+ * platform/graphics/Font.h:
+ * platform/graphics/SimpleFontData.cpp:
+ * svg/SVGFontFaceElement.cpp:
+ * svg/SVGFontFaceElement.h:
+
+2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build typo fix.
+
+ * platform/graphics/wx/TransformationMatrixWx.cpp:
+ (WebCore::TransformationMatrix::TransformationMatrix):
+
+2009-01-12 David Hyatt <hyatt@apple.com>
+
+ Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
+ elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
+
+ Reviewed by Oliver Hunt
+
+ * css/CSSStyleSelector.h:
+
+2009-01-12 David Hyatt <hyatt@apple.com>
+
+ Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
+ two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
+ Tiny speedup.
+
+ Reviewed by Oliver Hunt
+
+ * dom/Element.cpp:
+ (WebCore::Element::attributeChanged):
+
+2009-01-12 David Hyatt <hyatt@apple.com>
+
+ Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
+ default to the normal case. Tiny speedup on PLT.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::lineHeight):
+
+2009-01-12 David Hyatt <hyatt@apple.com>
+
+ Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
+ in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+
+2009-01-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=23273
+
+ In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
+ to be computed in absolute coordintes. Instead, we compute a repaintRect
+ relative to the RenderObject, which can repaint itself.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+
+2009-01-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=23220
+
+ Merge layoutDelta into LayoutState. This requires that we
+ push even when layoutState is disabled, so that layoutDelta
+ can still be stored.
+
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/LayoutState.h:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::absoluteToLocal):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
+ (WebCore::RenderTableCell::localToAbsolute):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::pushLayoutState):
+ * rendering/RenderView.h:
+ (WebCore::RenderView::layoutDelta):
+ (WebCore::RenderView::addLayoutDelta):
+ (WebCore::RenderView::doingFullRepaint):
+ (WebCore::RenderView::pushLayoutState):
+ (WebCore::RenderView::popLayoutState):
+ (WebCore::RenderView::layoutStateEnabled):
+ (WebCore::RenderView::layoutState):
+ (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
+ (WebCore::LayoutStateMaintainer::push):
+ (WebCore::LayoutStateMaintainer::pop):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+
+2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Reviewed by Holger Freyther.
+
+ [Qt] Build fix after turning the fontCache to a singleton
+ https://bugs.webkit.org/show_bug.cgi?id=23253
+
+ Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
+
+ * platform/graphics/qt/FontCacheQt.cpp:
+ (WebCore::fontCache):
+ (WebCore::FontCache::FontCache):
+
+2009-01-12 Eric Roman <eroman@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fix some bugs with Selection::appendTrailingWhitespace().
+ https://bugs.webkit.org/show_bug.cgi?id=23232
+
+ Test: editing/selection/doubleclick-whitespace-crash.html
+
+ * editing/Selection.cpp:
+ (WebCore::makeSearchRange):
+ (WebCore::Selection::appendTrailingWhitespace):
+
+2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add the first pieces of platform/graphics/chromium
+ https://bugs.webkit.org/show_bug.cgi?id=23257
+
+ * platform/graphics/chromium/ColorChromium.cpp: Added.
+ (WebCore::focusRingColor):
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
+ (WebCore::FontCache::platformInit):
+ (WebCore::isStringASCII):
+ (WebCore::LookupAltName):
+ (WebCore::FontCodepage::):
+ (WebCore::FontCodepage::if):
+ (WebCore::createFontIndirectAndGetWinName):
+ (WebCore::fontContainsCharacter):
+ (WebCore::FontCache::getFontDataForCharacters):
+ (WebCore::FontCache::alternateFamilyName):
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ (WebCore::toGDIFontWeight):
+ (WebCore::FontCache::getGenericFontForScript):
+ (WebCore::FillLogFont):
+ (WebCore::FontCache::fontExists):
+ (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
+ (WebCore::traitsInFamilyEnumProc):
+ (WebCore::FontCache::getTraitsInFamily):
+ (WebCore::FontCache::createFontPlatformData):
+ * platform/graphics/chromium/FontCacheLinux.cpp: Added.
+ (WebCore::FontCache::platformInit):
+ (WebCore::FontCache::getFontDataForCharacters):
+ (WebCore::FontCache::alternateFamilyName):
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ (WebCore::FontCache::getTraitsInFamily):
+ (WebCore::FontCache::createFontPlatformData):
+ (WebCore::FontCache::getGenericFontForScript):
+ * platform/graphics/chromium/FontChromiumWin.cpp: Added.
+ (WebCore::windowsCanHandleTextDrawing):
+ (WebCore::skiaDrawText):
+ (WebCore::PaintSkiaText):
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::selectionRectForComplexText):
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+
+2009-01-12 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23254
+ Upstream page/chromium/
+
+ * page/chromium/AXObjectCacheChromium.cpp: Added.
+ (WebCore::AXObjectCache::detachWrapper):
+ (WebCore::AXObjectCache::attachWrapper):
+ (WebCore::AXObjectCache::postNotification):
+ (WebCore::AXObjectCache::postNotificationToElement):
+ (WebCore::AXObjectCache::handleFocusedUIElementChanged):
+ * page/chromium/AccessibilityObjectChromium.cpp:
+ * page/chromium/AccessibilityObjectWrapper.h:
+ * page/chromium/ChromeClientChromium.h: Added.
+ * page/chromium/DragControllerChromium.cpp: Added.
+ (WebCore::DragController::dragOperation):
+ (WebCore::DragController::isCopyKeyDown):
+ (WebCore::DragController::maxDragImageSize):
+ (WebCore::DragController::cleanupAfterSystemDrag):
+ * page/chromium/EventHandlerChromium.cpp: Added.
+ (WebCore::EventHandler::passMousePressEventToSubframe):
+ (WebCore::EventHandler::passMouseMoveEventToSubframe):
+ (WebCore::EventHandler::passMouseReleaseEventToSubframe):
+ (WebCore::EventHandler::passWheelEventToWidget):
+ (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
+ (WebCore::EventHandler::passMouseDownEventToWidget):
+ (WebCore::EventHandler::tabsToAllControls):
+ (WebCore::EventHandler::eventActivatedView):
+ (WebCore::EventHandler::createDraggingClipboard):
+ (WebCore::EventHandler::focusDocumentView):
+ (WebCore::EventHandler::accessKeyModifiers):
+ * page/chromium/FrameChromium.cpp: Added.
+ (WebCore::computePageRectsForFrame):
+ (WebCore::Frame::dragImageForSelection):
+ * page/chromium/FrameChromium.h: Added.
+
+2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22936
+ Fix uninitialized memory read error, reported by Purify.
+
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData): Added initializer for
+ m_unitsPerEm using cDefaultUnitsPerEm constant.
+ * svg/SVGFontFaceElement.cpp:
+ (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
+ the constant.
+ * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
+
+2009-01-12 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Do not set fixedLayoutSize for anything other than the mainframe during
+ the transition as this is a page level state like the viewportSize.
+
+ * loader/FrameLoaderClient.cpp:
+ (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
+
+2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22861: Turn the FontCache into a singleton
+ https://bugs.webkit.org/show_bug.cgi?id=22861
+
+ - Added fontCache() to get the global FontCache.
+
+ - Made all the methods in FontCache instance method.
+
+ - Changed FontCache:: to fontCache()-> in WebCore.
+
+ * WebCore.base.exp: Now export fontCache().
+ * css/CSSFontFaceSource.cpp:
+ (WebCore::CSSFontFaceSource::getFontData):
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::CSSFontSelector):
+ (WebCore::CSSFontSelector::~CSSFontSelector):
+ (WebCore::CSSFontSelector::addFontFaceRule):
+ (WebCore::fontDataForGenericFamily):
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+ * platform/graphics/FontCache.cpp:
+ (WebCore::fontCache):
+ (WebCore::FontCache::FontCache):
+ * platform/graphics/FontCache.h:
+ * platform/graphics/FontFallbackList.cpp:
+ (WebCore::FontFallbackList::FontFallbackList):
+ (WebCore::FontFallbackList::invalidate):
+ (WebCore::FontFallbackList::releaseFontData):
+ (WebCore::FontFallbackList::fontDataAt):
+ (WebCore::FontFallbackList::fontDataForCharacters):
+ (WebCore::FontFallbackList::setPlatformFont):
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::~SimpleFontData):
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::fontCacheATSNotificationCallback):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::smallCapsFontData):
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::getCJKCodePageMasks):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::containsCharacters):
+
+2009-01-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
+ https://bugs.webkit.org/show_bug.cgi?id=23247
+
+ Also fix problems where partially parsed paths will still have an effect
+ rather than failing parsing and being ignored.
+
+ Test: dom/path-segments.html
+
+ * platform/graphics/Path.h:
+ (WebCore::Path::swap): Added.
+
+ * svg/SVGParserUtilities.cpp:
+ (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
+ (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
+ (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
+ parsing fails.
+ (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
+ not directly into the segment list.
+ (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
+ (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
+
+ * svg/SVGPathSegCurvetoCubicSmooth.h:
+ (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
+ Set y2 to y2, not to y.
+
+2009-01-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23102: turn on unused parameter warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23102
+
+ Fourth step: Remove arguments entirely in the many cases where they are not
+ needed at all. This step is a little less mechanical than the earlier ones.
+
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
+ the regular expression, since we already specify a-zA-Z in our expression.
+
+ * dom/Document.cpp:
+ (WebCore::Document::databaseThread): Don't pass in the document when creating
+ a DatabaseThread.
+
+ * dom/Element.cpp:
+ (WebCore::Element::createRareData): Don't pass the element when creating an
+ ElementRareData.
+ (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
+ (WebCore::Element::recalcStyle): Ditto.
+
+ * dom/ElementRareData.h: Remove the unused Element* from the constructor and
+ the resetComputedStyle function.
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
+ (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
+ (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
+ * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
+
+ * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
+ (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
+ start and end arguments.
+ (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
+ and end to pushDownTextDecorationStyleAroundNode.
+
+ * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
+ unused start and end arguments from pushDownTextDecorationStyleAroundNode.
+
+ * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
+
+ * html/HTMLTokenizer.cpp:
+ (WebCore::Token::addAttribute): Removed unused Document* argument.
+ (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
+
+ * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
+
+ * page/DragController.cpp:
+ (WebCore::DragController::dragIsMove): Removed unused DragData argument.
+ (WebCore::DragController::performDrag): Call concludeEditDrag rather than
+ concludeDrag.
+ (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
+ (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
+ should only be called for edit drags. Removed the action mask argument. Also
+ changed dragIsMove call sites to not pass dragData.
+
+ * page/DragController.h: Updated for above changes and tweaked comment format.
+
+ * page/Frame.cpp:
+ (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
+ when creating regular expressions for clarity. Call match instead of search,
+ since both do the same thing except for with negative start offsets, and none
+ used here are negative.
+ (WebCore::Frame::matchLabelsAgainstElement): Ditto.
+
+ * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (AXAttributeStringSetHeadingLevel): Removed unused object argument.
+ (AXAttributedStringAppendText): Ditto.
+ (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
+
+ * page/mac/FrameMac.mm:
+ (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
+ when creating regular expressions for clarity. Call match instead of search,
+ since both do the same thing except for with negative start offsets, and none
+ used here are negative.
+ (WebCore::Frame::matchLabelsAgainstElement): Ditto.
+
+ * platform/graphics/SegmentedFontData.cpp:
+ (WebCore::SegmentedFontData::containsCharacter): Added.
+ (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
+ instead of just the first one, using containsCharacter.
+
+ * platform/graphics/SegmentedFontData.h: Made more members private.
+ Added containsCharacter function member.
+
+ * platform/mac/DragImageMac.mm:
+ (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
+ DragImageRef for clarity, since this is platform-specific code.
+ (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
+ variable warning.
+ (WebCore::scaleDragImage): Ditto.
+ (WebCore::dissolveDragImageToFraction): Ditto.
+ (WebCore::createDragImageFromImage): Ditto.
+ (WebCore::createDragImageIconForCachedImage): Ditto.
+
+ * platform/mac/WebFontCache.mm:
+ (acceptableChoice): Removed the unused weight-related arguments.
+ (betterChoice): Ditto.
+ (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
+
+ * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
+ because we'd rather get a link error rather than a runtime error if we use it
+ for anything, and right now it's not used.
+
+ * platform/text/RegularExpression.cpp: Removed unused private data,
+ including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
+ and lastMatchPos. Made the RegularExpression::Private::regex be private
+ and use an accessor function to get at it.
+ (WebCore::RegularExpression::RegularExpression): Removed the const char* version
+ of the constructor because it's not any more efficient. Changed the boolean
+ constructor argument to use TextCaseSensitivity instead to make it less likely
+ we'll use it wrong.
+ (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
+ just use plain old assignment on it. The only reason we do this instead of using
+ the compiler generated assignment operator is that we want the Private structure
+ to be internal to the .cpp file.
+ (WebCore::RegularExpression::match): Added a null check so we won't crash if
+ we fail to compile the regular expression. Removed the code to handle multiple
+ match strings, since that was unused.
+
+ * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
+ TextCaseSensitivity and not have a default value. Removed the default constructor,
+ and the pattern, match, and pos functions.
+
+ * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
+ Page.h, because we should eventually use it in all the places where we have
+ an argument to control case sensitivity, starting with the functions in this
+ class.
+
+ * platform/text/mac/ShapeArabic.c:
+ (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
+ this is code borrowed from ICU, this seems like a simple safe change to make.
+ (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::RenderPath): Removed the unused style argument.
+ Also removed the type check. The argument already has the correct type,
+ so it's not helpful to upcast it and then check its type again, unless
+ we have some reason to believe the type is not reliable. And we don't.
+
+ * rendering/RenderPath.h: Removed the RenderStyle* argument to the
+ constructor. Also removed the explicit declaration of the destructor.
+ It's not helpful or needed.
+
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
+ make it clear that just returning an empty rect is not a good implementation.
+ Removed the argument names to get rid of the warning.
+
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::printBorderStyle): Removed the unused RenderObject argument.
+ (WebCore::operator<<): Updated for the change to printBorderStyle function.
+
+ * storage/DatabaseThread.cpp:
+ (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
+ * storage/DatabaseThread.h: Ditto.
+
+ * storage/LocalStorage.cpp:
+ (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
+ * storage/LocalStorage.h: Ditto.
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
+ code location to dispatchGenericEvent.
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::dispatchEvent): Ditto.
+
+ * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
+ (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
+ the RenderPath constructor.
+
+ * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
+
+ * xml/XSLTProcessor.cpp:
+ (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
+ (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
+
+2009-01-11 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23165
+ Disable application cache dynamic entries support.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ * loader/appcache/DOMApplicationCache.idl:
+
+2009-01-11 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Correct coordinate transformation for deeply nested frames on resizing. This
+ fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
+
+ Test: fast/frames/frame-deep-nested-resize.html
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::userResize):
+
+2009-01-11 Mark Rowe <mrowe@apple.com>
+
+ Tiger build fix. The connection parameter is still used on Tiger in this method.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
+
+2009-01-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23102: turn on unused parameter warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23102
+
+ Third step: Deal with cases of arguments used only in assertions.
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
+ * dom/Worker.cpp:
+ (WebCore::Worker::notifyFinished): Ditto.
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished): Ditto.
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
+ * loader/icon/IconLoader.cpp:
+ (WebCore::IconLoader::didReceiveData): Since loader and size are only
+ used when logging, use UNUSED_PARAM when logging is disabled.
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
+ argument since it's probably a tiny bit more efficient and gets rid
+ of the unused argument warning.
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createInlineBox): Ditto.
+ * rendering/RenderSVGInline.cpp:
+ (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
+ I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
+ the only use for two different arguments.
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
+ * rendering/RenderThemeMac.mm:
+ (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
+
+2009-01-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Oliver Hunt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23242
+
+ Fix CanvasRenderingContext2D::transform to do a pre-multiply,
+ rather than a post-multiply into m_transform. This bug did not affect
+ drawing, but did cause m_transform to be incorrect, which impacted
+ willDraw(), and isPointInPath.
+
+ Test: fast/canvas/canvas-incremental-repaint-2.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::transform):
+
+2009-01-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23102: turn on unused parameter warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23102
+
+ Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
+ That's because you can't omit an argument name in Objective-C methods.
+
+ * bindings/objc/DOMObject.mm:
+ (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
+ the word "unused" so we don't just start using it without removing the macro.
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebUndefined allocWithZone:]): Ditto.
+ (-[WebUndefined initWithCoder:]): Ditto.
+ (-[WebUndefined encodeWithCoder:]): Ditto.
+ (-[WebUndefined copyWithZone:]): Ditto.
+ * page/mac/WebDashboardRegion.m:
+ (-[WebDashboardRegion copyWithZone:]): Ditto.
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
+ (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
+ (-[WebCoreMovieObserver rateChanged:]): Ditto.
+ (-[WebCoreMovieObserver sizeChanged:]): Ditto.
+ (-[WebCoreMovieObserver timeChanged:]): Ditto.
+ (-[WebCoreMovieObserver didEnd:]): Ditto.
+ (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
+ * platform/mac/ScrollbarThemeMac.mm:
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
+ (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
+ * platform/mac/SharedTimerMac.mm:
+ (-[WebCorePowerNotifier didWake:]): Ditto.
+ * platform/mac/WebCoreKeyGenerator.m:
+ (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
+ (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
+ (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
+ (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
+ (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
+ (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
+ (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
+
+2009-01-11 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Move platform dependent strokeContains back to RenderPath, Path and delete
+ unneeded Code in svg.
+
+ RenderPath clean-up for strokeContains
+ [https://bugs.webkit.org/show_bug.cgi?id=22957]
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/Path.h:
+ * platform/graphics/cairo/PathCairo.cpp:
+ (WebCore::Path::strokeContains):
+ * platform/graphics/cg/PathCG.cpp:
+ (WebCore::Path::strokeContains):
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::Path::strokeContains):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::strokeContains):
+ * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
+ * svg/graphics/cg/CgSupport.cpp: Removed.
+ * svg/graphics/cg/CgSupport.h: Removed.
+ * svg/graphics/cg/RenderPathCg.cpp: Removed.
+ * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
+ * svg/graphics/cg/SVGResourceMaskerCg.mm:
+ * svg/graphics/qt/RenderPathQt.cpp: Removed.
+
+2009-01-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Anders Carlsson.
+
+ [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
+
+ make distcheck pass by adding JSWorkerContextBase.lut.h to the
+ CLEANFILES that will be cleaned on a make distclean.
+
+ * GNUmakefile.am:
+
+2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23235
+ Build fix for non-VIDEO builds.
+
+ * rendering/RenderTheme.cpp:
+ * rendering/RenderTheme.h:
+
+2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19287
+ return value of malloc() is not checked in npruntime.cpp
+
+ Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
+ (like in fastMalloc).
+
+ * bridge/npruntime.cpp:
+ (_NPN_GetStringIdentifier):
+ (_NPN_GetIntIdentifier):
+ (NPN_InitializeVariantWithStringCopy):
+ (_NPN_CreateObject):
+
+2009-01-11 Glenn Wilson <gwilson@google.com>
+
+ Reviewed by Darin Adler.
+
+ Changes radio buttons so they can be 'checked' even if they
+ don't have the name attribute set.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=21534
+
+ Test: fast/html/select-unnamed-radio.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::preDispatchEventHandler):
+
+2009-01-11 Bernhard Rosenkraenzer <bero@arklinux.ch>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22205
+ Fix compatibility with bison 2.4, partially based on older patch by
+ Priit Laes <amd@store20.com>
+
+ * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
+
+2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16001
+ Incorrect assumption that selection is always contiguous LTR.
+
+ Test: editing/selection/extend-selection-bidi.html
+
+ * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
+ Make this function not assume a contiguous visual LTR selection range.
+
+2009-01-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23207
+ Moved currentTime() to from WebCore to WTF.
+
+ Most of these files only have a different header file included.
+ Various build files reflect removal of SystemTimeGtk, Wx, Qt and Linux
+ which were removed since they only implemented currentTime().
+
+ * ForwardingHeaders/wtf/CurrentTime.h: Added.
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.pro:
+ * dom/ContainerNode.cpp:
+ * dom/Document.cpp:
+ * dom/Event.cpp:
+ * history/CachedPage.cpp:
+ * history/PageCache.cpp:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::load):
+ (WebCore::HTMLMediaElement::progressEventTimerFired):
+ * html/HTMLTokenizer.cpp:
+ * html/PreloadScanner.cpp:
+ * inspector/InspectorController.cpp:
+ * loader/Cache.cpp:
+ (WebCore::Cache::pruneLiveResources):
+ * loader/CachedImage.cpp:
+ * loader/CachedResource.cpp:
+ * loader/FrameLoader.cpp:
+ * loader/ProgressTracker.cpp:
+ * loader/icon/IconDatabase.cpp:
+ * loader/icon/IconRecord.cpp:
+ * page/DragController.cpp:
+ * page/Frame.cpp:
+ * page/FrameView.cpp:
+ * page/animation/AnimationBase.cpp:
+ * page/animation/AnimationController.cpp:
+ * page/animation/KeyframeAnimation.cpp:
+ * platform/SystemTime.h:
+ * platform/Timer.cpp:
+ * platform/graphics/BitmapImage.cpp:
+ * platform/gtk/MouseEventGtk.cpp:
+ * platform/gtk/SharedTimerGtk.cpp:
+ * platform/gtk/SystemTimeGtk.cpp: Removed.
+ * platform/gtk/SystemTimeLinux.cpp: Removed.
+ * platform/mac/SystemTimeMac.cpp:
+ * platform/qt/PlatformMouseEventQt.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/qt/SharedTimerQt.cpp:
+ * platform/qt/SharedTimerQt.h:
+ * platform/qt/SystemTimeQt.cpp: Removed.
+ * platform/win/SharedTimerWin.cpp:
+ * platform/win/SystemTimeWin.cpp:
+ * platform/wx/MouseEventWx.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/wx/SharedTimerWx.cpp:
+ * platform/wx/SystemTimeWx.cpp: Removed.
+ * rendering/RenderImage.cpp:
+ * rendering/RenderMedia.cpp:
+ * svg/animation/SMILTimeContainer.cpp:
+ * webcore-wx.bkl:
+ * xml/XMLHttpRequest.cpp:
+
+2009-01-11 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
+ Part of 'Timers in Workers' work.
+ https://bugs.webkit.org/show_bug.cgi?id=23223
+
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
+ (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
+ * bindings/js/ScheduledAction.h:
+
+2009-01-10 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23210
+ Make it easier for ports to define custom UI for media controls
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
+ get the media controller style sheet
+
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlInputElement::hitTest): Added
+ * rendering/MediaControlElements.h: Updated
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
+ so control elements don't necessarily have to be rectangular
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::styleSheetForMediaControls): Added
+ (WebCore::RenderTheme::hitTestMediaControlPart): Added
+ * rendering/RenderTheme.h: Updated
+
+2009-01-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=23222
+
+ We need to disable LayoutState when an object has transforms,
+ because LayoutState is not transform-aware and therefore
+ repaint rects can be computed incorrectly.
+
+ Test: fast/repaint/transform-disable-layoutstate.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+
+2009-01-09 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [QT] Make SharedTimer use QBasicTimer
+
+ Kill the SharedTimerQt.h and the usage of signal and slots
+ by using QBasicTimer.
+
+ * WebCore.pro:
+ * platform/qt/SharedTimerQt.cpp:
+ (WebCore::SharedTimerQt::SharedTimerQt):
+ (WebCore::SharedTimerQt::inst):
+ (WebCore::SharedTimerQt::start):
+ (WebCore::SharedTimerQt::stop):
+ (WebCore::SharedTimerQt::timerEvent):
+ (WebCore::setSharedTimerFiredFunction):
+ (WebCore::setSharedTimerFireTime):
+ (WebCore::stopSharedTimer):
+ * platform/qt/SharedTimerQt.h: Removed.
+
+2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
+
+ Reviewed by Holger Freyther.
+
+ [CURL] POST without body becomes GET
+ https://bugs.webkit.org/show_bug.cgi?id=23182
+
+ Make sure that method is always set to POST even when the body is
+ empty. Cleaned up httpBody null check.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::setupPOST):
+
+2009-01-09 Adam Treat <adam.treat@torchmobile.com>
+
+ Build fix.
+
+ * plugins/PluginView.cpp:
+
+2009-01-09 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
+ how it was before RenderTextControlSingleLine was split out from RenderTextControl.
+
+ No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
+ (WebCore::RenderTextControlSingleLine::clientPaddingRight):
+
+2009-01-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Jon Honeycutt.
+
+ Bug 22913: REGRESSION: Space bar doesn't scroll on windows
+ https://bugs.webkit.org/show_bug.cgi?id=22913
+ rdar://problem/6479834
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
+ defaultSpaceEventHandler.
+ (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
+ on the shift key.
+ * page/EventHandler.h: Added defaultSpaceEventHandler.
+
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformScroll): Return false, because this function does
+ not scroll. In an earlier version of this patch, I used this to prevent the
+ patch from affecting the Mac, but I decided to use #if instead.
+
+2009-01-09 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Delete references to JSValue, removing this class.
+
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::self):
+ * bindings/js/ScriptCallStack.h:
+
+2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add svg/graphics/skia files.
+ https://bugs.webkit.org/show_bug.cgi?id=23147
+
+ * svg/graphics/skia/RenderPathSkia.cpp: Added.
+ (WebCore::RenderPath::strokeContains):
+ * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
+ (WebCore::SVGPaintServerPattern::setup):
+ * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
+ (WebCore::SVGPaintServer::draw):
+ (WebCore::SVGPaintServer::teardown):
+ (WebCore::SVGPaintServer::renderPath):
+ * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
+ (WebCore::SVGResourceFilter::createPlatformData):
+ (WebCore::SVGResourceFilter::prepareFilter):
+ (WebCore::SVGResourceFilter::applyFilter):
+ * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
+ (WebCore::SVGResourceMasker::applyMask):
+
+2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add SkiaFontWin to platform/graphics/chromium
+ https://bugs.webkit.org/show_bug.cgi?id=23215
+
+ * platform/graphics/skia/SkiaFontWin.cpp: Added.
+ (WebCore::CachedOutlineKey::CachedOutlineKey):
+ (WebCore::operator==):
+ (WebCore::CachedOutlineKeyHash::hash):
+ (WebCore::CachedOutlineKeyHash::equal):
+ (WebCore::FIXEDToSkScalar):
+ (WebCore::deleteOutline):
+ (WebCore::addPolyCurveToPath):
+ (WebCore::getPathForGlyph):
+ (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
+ (WebCore::SkiaWinOutlineCache::removePathsForFont):
+ * platform/graphics/skia/SkiaFontWin.h: Added.
+
+2009-01-09 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * WebCore.LP64.exp:
+
+2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
+ https://bugs.webkit.org/show_bug.cgi?id=23215
+
+ * platform/graphics/skia/PlatformContextSkia.cpp: Added.
+ (PlatformContextSkia::State::State):
+ (PlatformContextSkia::State::~State):
+ (PlatformContextSkia::State::applyAlpha):
+ (PlatformContextSkia::PlatformContextSkia):
+ (PlatformContextSkia::~PlatformContextSkia):
+ (PlatformContextSkia::setCanvas):
+ (PlatformContextSkia::save):
+ (PlatformContextSkia::restore):
+ (PlatformContextSkia::drawRect):
+ (PlatformContextSkia::setupPaintCommon):
+ (PlatformContextSkia::setupPaintForFilling):
+ (PlatformContextSkia::setupPaintForStroking):
+ (PlatformContextSkia::setDrawLooper):
+ (PlatformContextSkia::setMiterLimit):
+ (PlatformContextSkia::setAlpha):
+ (PlatformContextSkia::setLineCap):
+ (PlatformContextSkia::setLineJoin):
+ (PlatformContextSkia::setPorterDuffMode):
+ (PlatformContextSkia::setFillColor):
+ (PlatformContextSkia::getDrawLooper):
+ (PlatformContextSkia::getStrokeStyle):
+ (PlatformContextSkia::setStrokeStyle):
+ (PlatformContextSkia::setStrokeColor):
+ (PlatformContextSkia::getStrokeThickness):
+ (PlatformContextSkia::setStrokeThickness):
+ (PlatformContextSkia::getTextDrawingMode):
+ (PlatformContextSkia::setTextDrawingMode):
+ (PlatformContextSkia::setUseAntialiasing):
+ (PlatformContextSkia::fillColor):
+ (PlatformContextSkia::beginPath):
+ (PlatformContextSkia::addPath):
+ (PlatformContextSkia::setFillRule):
+ (PlatformContextSkia::setGradient):
+ (PlatformContextSkia::setPattern):
+ (PlatformContextSkia::setDashPathEffect):
+ (PlatformContextSkia::paintSkPaint):
+ (PlatformContextSkia::bitmap):
+ (PlatformContextSkia::isPrinting):
+ * platform/graphics/skia/PlatformContextSkia.h: Added.
+ (PlatformContextSkia::currentPath):
+ (PlatformContextSkia::canvas):
+ (PlatformContextSkia::gdk_skia):
+ * platform/graphics/skia/PlatformGraphics.h: Added.
+
+2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add TransformationMatrixSkia to platform/graphics/skia
+ https://bugs.webkit.org/show_bug.cgi?id=23215
+
+ * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
+ (WebCore::TransformationMatrix::TransformationMatrix):
+ (WebCore::TransformationMatrix::setMatrix):
+ (WebCore::TransformationMatrix::map):
+ (WebCore::TransformationMatrix::mapRect):
+ (WebCore::TransformationMatrix::isIdentity):
+ (WebCore::TransformationMatrix::reset):
+ (WebCore::TransformationMatrix::scale):
+ (WebCore::TransformationMatrix::rotate):
+ (WebCore::TransformationMatrix::translate):
+ (WebCore::TransformationMatrix::shear):
+ (WebCore::TransformationMatrix::det):
+ (WebCore::TransformationMatrix::inverse):
+ (WebCore::TransformationMatrix::operator SkMatrix):
+ (WebCore::TransformationMatrix::operator==):
+ (WebCore::TransformationMatrix::operator*=):
+ (WebCore::TransformationMatrix::operator*):
+ (WebCore::TransformationMatrix::a):
+ (WebCore::TransformationMatrix::setA):
+ (WebCore::TransformationMatrix::b):
+ (WebCore::TransformationMatrix::setB):
+ (WebCore::TransformationMatrix::c):
+ (WebCore::TransformationMatrix::setC):
+ (WebCore::TransformationMatrix::d):
+ (WebCore::TransformationMatrix::setD):
+ (WebCore::TransformationMatrix::e):
+ (WebCore::TransformationMatrix::setE):
+ (WebCore::TransformationMatrix::f):
+ (WebCore::TransformationMatrix::setF):
+
+2009-01-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
+
+ Test: http/tests/appcache/reload.html
+
+ On Windows, reloading resulted in the following sequence of events:
+ 1) A new main resource loader was created and associated with the cache. Its document loader
+ was not associated with the cache yet.
+ 2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
+ teardown started, with newestCache being zeroed out.
+ 3) The new document loader was associated with the cache group, and cache update started.
+ 4) Since newestCache was null, this caused many problems.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
+ no functional changes.
+ (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
+ if its newest cache pointer is already saved for teardown. Note that the cache pointer
+ validity is ensured by MainResourceLoader that holds a reference to it.
+
+2009-01-09 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23214
+ Upstream platform/network/chromium/
+
+ * platform/network/chromium/AuthenticationChallenge.h: Added.
+ (WebCore::AuthenticationChallenge::AuthenticationChallenge):
+ (WebCore::AuthenticationChallenge::sourceHandle):
+ * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
+ (WebCore::AuthenticationChallenge::platformCompare):
+ * platform/network/chromium/CookieJarChromium.cpp: Added.
+ (WebCore::setCookies):
+ (WebCore::cookies):
+ (WebCore::cookiesEnabled):
+ * platform/network/chromium/DNSChromium.cpp: Added.
+ (WebCore::prefetchDNS):
+ * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
+ (WebCore::NetworkStateNotifier::updateState):
+ (WebCore::NetworkStateNotifier::NetworkStateNotifier):
+ * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
+ * platform/network/chromium/ResourceError.h: Added.
+ (WebCore::ResourceError::ResourceError):
+ * platform/network/chromium/ResourceRequest.h: Added.
+ (WebCore::ResourceRequest::):
+ (WebCore::ResourceRequest::ResourceRequest):
+ (WebCore::ResourceRequest::frame):
+ (WebCore::ResourceRequest::setFrame):
+ (WebCore::ResourceRequest::setTargetType):
+ (WebCore::ResourceRequest::targetType):
+ (WebCore::ResourceRequest::originPid):
+ (WebCore::ResourceRequest::setOriginPid):
+ (WebCore::ResourceRequest::securityInfo):
+ (WebCore::ResourceRequest::setSecurityInfo):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ * platform/network/chromium/ResourceResponse.h:
+ (WebCore::ResourceResponse::ResourceResponse):
+ (WebCore::ResourceResponse::getSecurityInfo):
+ (WebCore::ResourceResponse::setSecurityInfo):
+ (WebCore::ResourceResponse::isContentFiltered):
+ (WebCore::ResourceResponse::setIsContentFiltered):
+ (WebCore::ResourceResponse::doUpdateResourceResponse):
+
+2009-01-09 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22995
+ Fix flaky image animation by resetting the metadata for a frame when
+ we get new data for that frame. This fixes animations that halted
+ when the next frame of the animation wasn't complete by the time the
+ current frame's duration expired.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::destroyDecodedData):
+ (WebCore::BitmapImage::dataChanged):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::FrameData::~FrameData):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::FrameData::clear):
+
+2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Tor Arne Vestbø.
+
+ Swap the .h and the .cpp output in the Qt build for the
+ UserAgentStyleSheetData files, to put the definition in the .cpp file
+ and the declaration in the header file.
+
+ * WebCore.pro:
+
+2009-01-09 David Levin <levin@chromium.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23175
+
+ Added forwarding header.
+
+ * ForwardingHeaders/wtf/PtrAndFlags.h: Added.
+
+2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Prevent qmake from generating duplicate rules for embedded stylesheets
+
+ The STYLESHEETS_EMBED variable used to contain only one file name, but
+ now that it is a list of files we need to change it to be a dependency
+ for the stylesheet generator instead of the input.
+
+ * WebCore.pro:
+
+2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix qmake warning about missing test function, a contains() call was
+ missing.
+
+ * WebCore.pro:
+
+2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Rubber-stamped by Tor Arne Vestbø.
+
+ Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
+
+ * WebCore.pro:
+
+2009-01-09 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23199
+
+ Fix deref's of string happening on two different threads.
+
+ No observable change in behavior, so no test. However, there are asserts
+ being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
+ will detect this issue while running the normal worker tests.
+
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThreadStartupData::create):
+ (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * dom/WorkerThread.h:
+
+2009-01-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - use native glyph support in Core Graphics when available
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
+ native glyph support is not available or stroking is required. Changed
+ to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
+ request the use of native glyphs.
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
+ wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
+ * platform/graphics/win/FontPlatformDataCGWin.cpp:
+ (WebCore::FontPlatformData::platformDataInit): Ditto.
+
+2009-01-08 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22929
+ Fix memory regression when decoding large animated GIFs.
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::clear):
+
+2009-01-08 Scott Violet <sky@chromium.org>
+
+ Reviewed by Eric Seidel (and Adam Barth).
+
+ Fix Images to return their file extension
+ http://code.google.com/p/chromium/issues/detail?id=5827
+
+ * platform/graphics/skia/ImageSourceSkia.cpp:
+ (WebCore::ImageSource::filenameExtension):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add PathSkia and PatternSkia implementations to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23200
+
+ * platform/graphics/skia/PathSkia.cpp: Added.
+ (WebCore::Path::Path):
+ (WebCore::Path::~Path):
+ (WebCore::Path::operator=):
+ (WebCore::Path::isEmpty):
+ (WebCore::Path::contains):
+ (WebCore::Path::translate):
+ (WebCore::Path::boundingRect):
+ (WebCore::Path::moveTo):
+ (WebCore::Path::addLineTo):
+ (WebCore::Path::addQuadCurveTo):
+ (WebCore::Path::addBezierCurveTo):
+ (WebCore::Path::addArcTo):
+ (WebCore::Path::closeSubpath):
+ (WebCore::Path::addArc):
+ (WebCore::Path::addRect):
+ (WebCore::Path::addEllipse):
+ (WebCore::Path::clear):
+ (WebCore::convertPathPoints):
+ (WebCore::Path::apply):
+ (WebCore::Path::transform):
+ (WebCore::Path::debugString):
+ (WebCore::boundingBoxForCurrentStroke):
+ (WebCore::Path::strokeBoundingRect):
+ * platform/graphics/skia/PatternSkia.cpp: Added.
+ (WebCore::shaderRule):
+ (WebCore::Pattern::createPlatformPattern):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add ImageSourceSkia to platform/graphics/skia
+ https://bugs.webkit.org/show_bug.cgi?id=23200
+
+ ImageSourceSkia is mostly a hack to support our
+ ICO decoder model. See ImageSourceSkia.h for more
+ explanation. Eventually we'd like to make our ICO
+ decoder lazy.
+
+ * platform/graphics/ImageSource.h: mark m_decoder as protected
+ * platform/graphics/skia/ImageSourceSkia.cpp: Added.
+ (WebCore::createDecoder):
+ (WebCore::ImageSource::ImageSource):
+ (WebCore::ImageSource::~ImageSource):
+ (WebCore::ImageSource::clear):
+ (WebCore::ImageSource::initialized):
+ (WebCore::ImageSource::setData):
+ (WebCore::ImageSource::isSizeAvailable):
+ (WebCore::ImageSource::size):
+ (WebCore::ImageSource::frameSizeAtIndex):
+ (WebCore::ImageSource::repetitionCount):
+ (WebCore::ImageSource::frameCount):
+ (WebCore::ImageSource::createFrameAtIndex):
+ (WebCore::ImageSource::frameIsCompleteAtIndex):
+ (WebCore::ImageSource::frameDurationAtIndex):
+ (WebCore::ImageSource::frameHasAlphaAtIndex):
+ (WebCore::ImageSourceSkia::setData):
+ (WebCore::ImageSource::filenameExtension):
+ * platform/graphics/skia/ImageSourceSkia.h: Added.
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
+ https://bugs.webkit.org/show_bug.cgi?id=23200
+
+ * platform/graphics/skia/NativeImageSkia.cpp: Added.
+ (NativeImageSkia::NativeImageSkia):
+ (NativeImageSkia::decodedSize):
+ (NativeImageSkia::hasResizedBitmap):
+ (NativeImageSkia::resizedBitmap):
+ (NativeImageSkia::shouldCacheResampling):
+ * platform/graphics/skia/NativeImageSkia.h: Added.
+ (NativeImageSkia::setDataComplete):
+ (NativeImageSkia::isDataComplete):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add ImageBufferSkia and ImageSkia files.
+ https://bugs.webkit.org/show_bug.cgi?id=23200
+ For now we've left BitmapImage and BitmapImageSingleFrameSkia
+ implementations in the ImageSkia file (like ImageCG has), but
+ we intend to break them out into their own files.
+
+ * platform/graphics/skia/ImageBufferSkia.cpp: Added.
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::~ImageBuffer):
+ (WebCore::ImageBuffer::context):
+ (WebCore::ImageBuffer::image):
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ (WebCore::ImageBuffer::toDataURL):
+ * platform/graphics/skia/ImageSkia.cpp: Added.
+ (WebCore::):
+ (WebCore::FrameData::clear):
+ (WebCore::Image::loadPlatformResource):
+ (WebCore::Image::drawPattern):
+ (WebCore::BitmapImage::initPlatformData):
+ (WebCore::BitmapImage::invalidatePlatformData):
+ (WebCore::BitmapImage::checkForSolidColor):
+ (WebCore::BitmapImage::draw):
+ (WebCore::BitmapImageSingleFrameSkia::draw):
+ (WebCore::BitmapImageSingleFrameSkia::create):
+
+2009-01-08 James Robinson <jamesr@google.com>
+
+ Reviewed by Mark Rowe.
+ Landed by Pamela Greene.
+
+ WebCore::Event::timeStamp() is a simple accessor and should be const
+
+ https://bugs.webkit.org/show_bug.cgi?id=23176
+
+ * dom/Event.h:
+ (WebCore::Event::timeStamp):
+
+2009-01-08 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix <rdar://problem/6467206>
+ Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
+
+ Use CachedResourceHandle in document resource map so resources get updated correctly when using
+ using cache validation conditionals.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::evict):
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::~DocLoader):
+ (WebCore::DocLoader::requestResource):
+ (WebCore::DocLoader::setAutoLoadImages):
+ (WebCore::DocLoader::removeCachedResource):
+ * loader/DocLoader.h:
+ (WebCore::DocLoader::cachedResource):
+ (WebCore::DocLoader::allCachedResources):
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::getSubresources):
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::updateFromElement):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add a cleaned-up GraphicsContextSkia implementation to WebKit.
+ https://bugs.webkit.org/show_bug.cgi?id=23191
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp: Added.
+ (WebCore::):
+ (WebCore::GraphicsContext::GraphicsContext):
+ (WebCore::GraphicsContext::~GraphicsContext):
+ (WebCore::GraphicsContext::platformContext):
+ (WebCore::GraphicsContext::savePlatformState):
+ (WebCore::GraphicsContext::restorePlatformState):
+ (WebCore::GraphicsContext::beginTransparencyLayer):
+ (WebCore::GraphicsContext::endTransparencyLayer):
+ (WebCore::GraphicsContext::addInnerRoundedRectClip):
+ (WebCore::GraphicsContext::addPath):
+ (WebCore::GraphicsContext::beginPath):
+ (WebCore::GraphicsContext::clearPlatformShadow):
+ (WebCore::GraphicsContext::clearRect):
+ (WebCore::GraphicsContext::clip):
+ (WebCore::GraphicsContext::clipOut):
+ (WebCore::GraphicsContext::clipOutEllipseInRect):
+ (WebCore::GraphicsContext::clipPath):
+ (WebCore::GraphicsContext::clipToImageBuffer):
+ (WebCore::GraphicsContext::concatCTM):
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::drawEllipse):
+ (WebCore::GraphicsContext::drawFocusRing):
+ (WebCore::GraphicsContext::drawLine):
+ (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
+ (WebCore::GraphicsContext::drawLineForText):
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::fillRoundedRect):
+ (WebCore::GraphicsContext::getCTM):
+ (WebCore::GraphicsContext::roundToDevicePixels):
+ (WebCore::GraphicsContext::scale):
+ (WebCore::GraphicsContext::setAlpha):
+ (WebCore::GraphicsContext::setCompositeOperation):
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::setLineCap):
+ (WebCore::GraphicsContext::setLineDash):
+ (WebCore::GraphicsContext::setLineJoin):
+ (WebCore::GraphicsContext::setMiterLimit):
+ (WebCore::GraphicsContext::setPlatformFillColor):
+ (WebCore::GraphicsContext::setPlatformShadow):
+ (WebCore::GraphicsContext::setPlatformStrokeColor):
+ (WebCore::GraphicsContext::setPlatformStrokeStyle):
+ (WebCore::GraphicsContext::setPlatformStrokeThickness):
+ (WebCore::GraphicsContext::setPlatformTextDrawingMode):
+ (WebCore::GraphicsContext::setURLForRect):
+ (WebCore::GraphicsContext::setUseAntialiasing):
+ (WebCore::GraphicsContext::strokeArc):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+ (WebCore::GraphicsContext::rotate):
+ (WebCore::GraphicsContext::translate):
+
+2009-01-08 David Hyatt <hyatt@apple.com>
+
+ Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
+
+ Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
+ any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
+ might eventually be of interest to other platforms.
+
+ Reviewed by Oliver Hunt
+
+ * WebCore.base.exp:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::scrollRectIntoView):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::scrollRectIntoView):
+ * platform/HostWindow.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+
+2009-01-08 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by David Hyatt.
+
+ No need to make this part of HostWindow and moreover HostWindow should
+ not have any reference to non-platform parts of WebCore.
+
+ * page/Chrome.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setContentsSize):
+ * platform/HostWindow.h:
+
+2009-01-08 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Simplify Mac interfaces for drawing media controller elements
+
+ <rdar://problem/6293969>
+
+ * WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
+
+ * platform/mac/WebCoreSystemInterface.h: Ditto
+ * platform/mac/WebCoreSystemInterface.mm: Ditto
+
+ * rendering/MediaControlElements.h:
+ (WebCore::): Add MediaControlElements enum
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface
+ media controller functions
+ (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
+ (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
+ (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add two more files for platform/graphics/skia.
+ https://bugs.webkit.org/show_bug.cgi?id=23191
+
+ * platform/graphics/skia/GradientSkia.cpp: Added.
+ (WebCore::Gradient::platformDestroy):
+ (WebCore::F2B):
+ (WebCore::makeSkColor):
+ (WebCore::totalStopsNeeded):
+ (WebCore::fillStops):
+ (WebCore::compareStops):
+ (WebCore::Gradient::platformGradient):
+ (WebCore::Gradient::fill):
+ * platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h.
+ (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
+ (WebCore::GraphicsContextPlatformPrivate::context):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Commit the right files this time! (Instead of the ugly unfixed ones.)
+ https://bugs.webkit.org/show_bug.cgi?id=23191
+
+ * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
+ * platform/graphics/skia/FloatPointSkia.cpp:
+ * platform/graphics/skia/FloatRectSkia.cpp:
+ * platform/graphics/skia/IntPointSkia.cpp:
+ * platform/graphics/skia/IntRectSkia.cpp:
+ (WebCore::IntRect::operator SkRect):
+ * platform/graphics/skia/SkiaUtils.cpp:
+ (WebCore::):
+ (WebCore::WebCoreCompositeToSkiaComposite):
+ (WebCore::SkPMColorToWebCoreColor):
+ (WebCore::IntersectRectAndRegion):
+ (WebCore::ClipRectToCanvas):
+ (WebCore::SkPathContainsPoint):
+ (WebCore::scratchContext):
+ * platform/graphics/skia/SkiaUtils.h:
+ (WebCore::WebCoreFloatToSkScalar):
+ (WebCore::WebCoreDoubleToSkScalar):
+
+2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add the first few files from platform/graphics/skia
+ https://bugs.webkit.org/show_bug.cgi?id=23191
+
+ These are all pretty simple.
+ Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
+ SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
+
+ * platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added.
+ (WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
+ (WebCore::BitmapImageSingleFrameSkia::size):
+ (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
+ (WebCore::BitmapImageSingleFrameSkia::decodedSize):
+ (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
+ (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
+ * platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm.
+ (WebCore::FloatPoint::FloatPoint):
+ (WebCore::FloatPoint::operator SkPoint):
+ * platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
+ (WebCore::FloatRect::FloatRect):
+ (WebCore::FloatRect::operator SkRect):
+ * platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp.
+ (WebCore::IntPoint::IntPoint):
+ (WebCore::IntPoint::operator SkIPoint):
+ (WebCore::IntPoint::operator SkPoint):
+ * platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
+ (WebCore::IntRect::operator SkIRect):
+ (WebCore::IntRect::operator SkRect):
+ (WebCore::IntRect::IntRect):
+ * platform/graphics/skia/SkiaUtils.cpp: Added.
+ (WebCore::WebCorePointToSkiaPoint):
+ (WebCore::WebCoreRectToSkiaRect):
+ (WebCore::):
+ (WebCore::WebCoreCompositeToSkiaComposite):
+ (WebCore::InvScaleByte):
+ (WebCore::SkPMColorToColor):
+ (WebCore::SkPMColorToWebCoreColor):
+ (WebCore::IntersectRectAndRegion):
+ (WebCore::ClipRectToCanvas):
+ (WebCore::SkPathContainsPoint):
+ (WebCore::scratchContext):
+ * platform/graphics/skia/SkiaUtils.h: Added.
+ (WebCore::WebCoreFloatToSkScalar):
+ (WebCore::WebCoreDoubleToSkScalar):
+
+2009-01-08 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
+
+ Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
+ instead of simply the "running" ones.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23177
+
+ Tests: transitions/zero-duration-with-non-zero-delay-end.html
+ transitions/zero-duration-with-non-zero-delay-start.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::animationTimerFired):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
+
+2009-01-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
+
+ The crash happened whenever a cached resource was downloaded, as opposed to used directly.
+
+ No test, as downloading cannot be tested automatically.
+
+ * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
+ Cancel downloads that do not have an associated ResourceHandle, such as downloads from the
+ application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
+
+2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the Qt build on older X11 systems with special X paths.
+
+ * WebCore.pro: Use the x11 qmake config to pull in extra paths
+ needed for NPAPI.
+
+2009-01-08 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r39699
+
+ * DerivedSources.cpp: Added JSDOMStringList.cpp.
+
+2009-01-08 Kent Hansen <khansen@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix copy & paste of images in the Qt port.
+
+ Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
+
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::declareAndWriteDragImage):
+
+2009-01-08 Hiroyuki Ikezoe <poincare@ikezoe.net>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23127
+
+ Invoke pango_coverage_get with each Unicode character.
+
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::containsCharacters):
+
+2009-01-07 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Part one of
+ https://bugs.webkit.org/show_bug.cgi?id=23165
+ Add support for application cache dynamic entries
+
+ Test: http/tests/appcache/dynamic-entries-no-cache.html
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Added new files.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem):
+ Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom
+ to resolve relative URLs correctly.
+
+ * bindings/js/JSDOMStringListCustom.cpp: Added.
+ * dom/DOMStringList.cpp: Added.
+ * dom/DOMStringList.h: Added.
+ * dom/DOMStringList.idl: Added.
+ Added an implementation of DOM 3 Core DOMStringList interface, which is returned by
+ DOMApplicationCache items attribute.
+
+ * dom/StaticStringList.cpp: Added.
+ * dom/StaticStringList.h: Added.
+ An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this
+ matches Firefox, as the spec doesn't say whether the returned list should be live or not).
+
+ * loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be
+ used in the near future.
+
+ * loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length
+ attribute and item(), we now have an items attribute that returns a DOMStringList, and a
+ hasItem convenience method.
+
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::items):
+ (WebCore::DOMApplicationCache::hasItem):
+ * loader/appcache/DOMApplicationCache.h:
+ Added implementations of items attribute and hasItem() (note that underlying ApplicationCache
+ methods are still unimplemented though).
+
+ * page/DOMWindow.idl: Expose a DOMStringList global constructor.
+
+2009-01-07 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23122
+
+ This completes the removal of dependencies on WebKit from the platform code
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::getDelayValue):
+ (WebCore::getDurationValue):
+ (WebCore::getTimingFunctionValue):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSHelper.h:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapAnimationDelay):
+ (WebCore::CSSStyleSelector::mapAnimationDirection):
+ (WebCore::CSSStyleSelector::mapAnimationDuration):
+ (WebCore::CSSStyleSelector::mapAnimationIterationCount):
+ (WebCore::CSSStyleSelector::mapAnimationName):
+ (WebCore::CSSStyleSelector::mapAnimationPlayState):
+ (WebCore::CSSStyleSelector::mapAnimationProperty):
+ (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
+ * platform/animation/Animation.cpp:
+ (WebCore::Animation::Animation):
+ * platform/animation/Animation.h:
+ (WebCore::Animation::initialAnimationDelay):
+ (WebCore::Animation::initialAnimationDirection):
+ (WebCore::Animation::initialAnimationDuration):
+ (WebCore::Animation::initialAnimationIterationCount):
+ (WebCore::Animation::initialAnimationName):
+ (WebCore::Animation::initialAnimationPlayState):
+ (WebCore::Animation::initialAnimationProperty):
+ (WebCore::Animation::initialAnimationTimingFunction):
+ * rendering/style/RenderStyle.h:
+
+2008-01-07 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22929
+
+ Fix errors while decoding GIFs by not calling setData() repeatedly
+ when it's not necessary. Pushes the responsibility for calling
+ setData() after clear() into the ImageSource which presumably knows
+ better than BitmapImage what needs to be done.
+
+ NOTE: The above bug is mainly about a memory regression, which this
+ patch does not fix.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::destroyDecodedData):
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::clear):
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::clear):
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::~ImageSource):
+ (WebCore::ImageSource::clear):
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::~ImageSource):
+ (WebCore::ImageSource::clear):
+
+2009-01-07 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6355786> Find fails for queries that contain a line break
+
+ * editing/TextIterator.cpp:
+ (WebCore::findPlainText): Allow find with queries that contain newlines.
+
+2009-01-07 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Allow removal of inline shorthand properties for
+ animation, transition and transform origin. Also
+ add getter for shorthand animation property.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22605
+
+ Test: fast/css/transform-inline-style-remove.html
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
+ Getter for animation property shorthand
+ (WebCore::initShorthandMap):
+ Adds initialisation for transform-origin, animation and transition
+
+2009-01-07 Benjamin Otte <otte@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ * platform/network/ResourceHandleInternal.h:
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
+ (WebCore::parseDataUrl):
+ (WebCore::ResourceHandle::startData): keep track of the idle handler
+ we add and remove it in the destructor
+
+2009-01-07 Dean Jackson <dino@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Finish renaming of AffineTransform to TransformationMatrix, this
+ time ensuring that the platform implementations get the correct
+ name. Also, clean up some whitespace cruft in old content.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23151
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
+ * platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
+ * platform/graphics/cg/AffineTransformCG.cpp: Removed.
+ * platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
+ * platform/graphics/qt/AffineTransformQt.cpp: Removed.
+ * platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ * platform/graphics/transforms/TransformationMatrix.h:
+ * platform/graphics/wx/AffineTransformWx.cpp: Removed.
+ * platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
+ * webcore-wx.bkl:
+
+2009-01-07 Anders Carlsson <andersca@apple.com>
+
+ Another build fix.
+
+ * WebCore.LP64.exp:
+
+2008-12-16 David Hyatt <hyatt@apple.com>
+
+ Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
+ back to the document-level default.
+
+ Reviewed by Darin Adler
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/CSSValueKeywords.in:
+
+2009-01-07 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
+ https://bugs.webkit.org/show_bug.cgi?id=23160
+
+ * WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource
+ so that there's no extra work the caller has to do when the inspector is disabled.
+ * inspector/InspectorController.h: Ditto.
+
+ * loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification,
+ takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when
+ there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled
+ and if it's false, use recordMemoryCacheLoadForFutureClientNotification.
+ (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
+ * loader/FrameLoader.h: Ditto.
+
+ * page/Page.cpp:
+ (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior.
+ (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
+ * page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled,
+ and m_areMemoryCacheClientCallsEnabled.
+
+2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Qt build fix after r39670.
+
+ * bridge/qt/qt_class.cpp:
+ (JSC::Bindings::QtClass::fallbackObject):
+ * bridge/qt/qt_class.h:
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::mark):
+ (JSC::Bindings::QtInstance::invokeMethod):
+ (JSC::Bindings::QtInstance::defaultValue):
+ (JSC::Bindings::QtInstance::stringValue):
+ (JSC::Bindings::QtInstance::numberValue):
+ (JSC::Bindings::QtInstance::booleanValue):
+ (JSC::Bindings::QtInstance::valueOf):
+ (JSC::Bindings::QtField::valueFromInstance):
+ (JSC::Bindings::QtField::setValueToInstance):
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::valueRealType):
+ (JSC::Bindings::convertValueToQVariant):
+ (JSC::Bindings::convertQVariantToValue):
+ (JSC::Bindings::findMethodIndex):
+ (JSC::Bindings::QtRuntimeMetaMethod::call):
+ (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
+ (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
+ (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
+ (JSC::Bindings::QtRuntimeConnectionMethod::call):
+ (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
+ (JSC::Bindings::::setValueAt):
+ (JSC::Bindings::::valueAt):
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMethod::createStructure):
+
+2009-01-06 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
+
+ Can't create an automated test case for specific contextual menu items yet and
+ a normal Copy doesn't cause a crash.
+
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may,
+ for example, have a purgeable or regular buffer.
+
+2009-01-06 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
+ Bug 23157: Crashes on Acid 3
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle): Null-check the frame.
+
+2009-01-05 Gavin Barraclough <baraclough@apple.com>
+
+ Rubber Stamped by Oliver Hunt.
+
+ Replace all uses of JSValue* with new wrapper class, JSValuePtr.
+ See JavaScriptCore/ChangeLog for more detailed description.
+
+ * bindings/js/JSAttrCustom.cpp:
+ (WebCore::JSAttr::setValue):
+ * bindings/js/JSCSSRuleCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter):
+ (WebCore::JSCSSStyleDeclaration::customPut):
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSCanvasPixelArrayCustom.h:
+ (WebCore::JSCanvasPixelArray::getByIndex):
+ (WebCore::JSCanvasPixelArray::indexSetter):
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::toJS):
+ (WebCore::toHTMLCanvasStyle):
+ (WebCore::JSCanvasRenderingContext2D::strokeStyle):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
+ (WebCore::JSCanvasRenderingContext2D::fillStyle):
+ (WebCore::JSCanvasRenderingContext2D::setFillStyle):
+ (WebCore::JSCanvasRenderingContext2D::setFillColor):
+ (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
+ (WebCore::JSCanvasRenderingContext2D::strokeRect):
+ (WebCore::JSCanvasRenderingContext2D::drawImage):
+ (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
+ (WebCore::JSCanvasRenderingContext2D::setShadow):
+ (WebCore::JSCanvasRenderingContext2D::createPattern):
+ (WebCore::JSCanvasRenderingContext2D::putImageData):
+ (WebCore::JSCanvasRenderingContext2D::fillText):
+ (WebCore::JSCanvasRenderingContext2D::strokeText):
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore::JSClipboard::types):
+ (WebCore::JSClipboard::clearData):
+ (WebCore::JSClipboard::getData):
+ (WebCore::JSClipboard::setData):
+ (WebCore::JSClipboard::setDragImage):
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::profiles):
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ (WebCore::toVoidCallback):
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::create):
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::add):
+ (WebCore::JSDOMApplicationCache::remove):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::jsStringOrNull):
+ (WebCore::jsOwnedStringOrNull):
+ (WebCore::jsStringOrUndefined):
+ (WebCore::jsStringOrFalse):
+ (WebCore::valueToStringWithNullCheck):
+ (WebCore::valueToStringWithUndefinedOrNullCheck):
+ (WebCore::reportException):
+ (WebCore::reportCurrentException):
+ (WebCore::setDOMException):
+ (WebCore::objectToStringFunctionGetter):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::getDOMObjectWrapper):
+ (WebCore::getDOMNodeWrapper):
+ (WebCore::toJS):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::createWindow):
+ (WebCore::showModalDialog):
+ (jsDOMWindowBaseCrypto):
+ (jsDOMWindowBaseEvent):
+ (jsDOMWindowBaseImage):
+ (jsDOMWindowBaseMessageChannel):
+ (jsDOMWindowBaseOption):
+ (jsDOMWindowBaseXMLHttpRequest):
+ (jsDOMWindowBaseAudio):
+ (jsDOMWindowBaseWorker):
+ (jsDOMWindowBaseXSLTProcessor):
+ (setJSDOMWindowBaseEvent):
+ (setJSDOMWindowBaseAudio):
+ (setJSDOMWindowBaseImage):
+ (setJSDOMWindowBaseMessageChannel):
+ (setJSDOMWindowBaseOption):
+ (setJSDOMWindowBaseWorker):
+ (setJSDOMWindowBaseXMLHttpRequest):
+ (setJSDOMWindowBaseXSLTProcessor):
+ (WebCore::JSDOMWindowBase::childFrameGetter):
+ (WebCore::JSDOMWindowBase::indexGetter):
+ (WebCore::JSDOMWindowBase::namedItemGetter):
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+ (WebCore::JSDOMWindowBase::put):
+ (WebCore::JSDOMWindowBase::clear):
+ (windowProtoFuncOpen):
+ (windowProtoFuncShowModalDialog):
+ (windowProtoFuncNotImplemented):
+ (WebCore::JSDOMWindowBase::setReturnValueSlot):
+ (WebCore::JSDOMWindowBase::installTimeout):
+ (WebCore::toJS):
+ (WebCore::toJSDOMWindow):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::lookupGetter):
+ (WebCore::JSDOMWindow::lookupSetter):
+ (WebCore::JSDOMWindow::setLocation):
+ (WebCore::JSDOMWindow::postMessage):
+ (WebCore::setTimeoutOrInterval):
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::clearTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ (WebCore::JSDOMWindow::clearInterval):
+ (WebCore::JSDOMWindow::atob):
+ (WebCore::JSDOMWindow::btoa):
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ (WebCore::toDOMWindow):
+ (WebCore::nonCachingStaticCloseFunctionGetter):
+ (WebCore::nonCachingStaticBlurFunctionGetter):
+ (WebCore::nonCachingStaticFocusFunctionGetter):
+ (WebCore::nonCachingStaticPostMessageFunctionGetter):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customPut):
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::put):
+ (WebCore::JSDOMWindowShell::putWithAttributes):
+ (WebCore::JSDOMWindowShell::lookupGetter):
+ (WebCore::JSDOMWindowShell::lookupSetter):
+ (WebCore::toJS):
+ * bindings/js/JSDOMWindowShell.h:
+ (WebCore::JSDOMWindowShell::createStructure):
+ * bindings/js/JSDatabaseCustom.cpp:
+ (WebCore::JSDatabase::changeVersion):
+ (WebCore::JSDatabase::transaction):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::location):
+ (WebCore::JSDocument::setLocation):
+ (WebCore::toJS):
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::JSElement::setAttribute):
+ (WebCore::JSElement::setAttributeNode):
+ (WebCore::JSElement::setAttributeNS):
+ (WebCore::JSElement::setAttributeNodeNS):
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSEventCustom.cpp:
+ (WebCore::JSEvent::clipboardData):
+ (WebCore::toJS):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::eventParameterName):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventTarget.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSEventTarget.h:
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ (WebCore::JSEventTargetNode::addEventListener):
+ (WebCore::JSEventTargetNode::removeEventListener):
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions):
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::createStructure):
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ (WebCore::JSHTMLAppletElement::customPut):
+ (WebCore::JSHTMLAppletElement::nameGetter):
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::getNamedItems):
+ (WebCore::callHTMLCollection):
+ (WebCore::JSHTMLCollection::nameGetter):
+ (WebCore::JSHTMLCollection::item):
+ (WebCore::JSHTMLCollection::namedItem):
+ (WebCore::toJS):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::nameGetter):
+ (WebCore::JSHTMLDocument::all):
+ (WebCore::JSHTMLDocument::setAll):
+ (WebCore::JSHTMLDocument::open):
+ (WebCore::JSHTMLDocument::write):
+ (WebCore::JSHTMLDocument::writeln):
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ (WebCore::JSHTMLEmbedElement::customPut):
+ (WebCore::JSHTMLEmbedElement::nameGetter):
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::nameGetter):
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ (WebCore::JSHTMLFrameElement::setSrc):
+ (WebCore::JSHTMLFrameElement::setLocation):
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ (WebCore::JSHTMLFrameSetElement::nameGetter):
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ (WebCore::JSHTMLIFrameElement::setSrc):
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::selectionStart):
+ (WebCore::JSHTMLInputElement::selectionEnd):
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ (WebCore::JSHTMLObjectElement::customPut):
+ (WebCore::JSHTMLObjectElement::nameGetter):
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ (WebCore::JSHTMLOptionsCollection::length):
+ (WebCore::JSHTMLOptionsCollection::setLength):
+ (WebCore::JSHTMLOptionsCollection::indexSetter):
+ (WebCore::JSHTMLOptionsCollection::add):
+ (WebCore::JSHTMLOptionsCollection::remove):
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ (WebCore::JSHTMLSelectElement::remove):
+ (WebCore::selectIndexSetter):
+ (WebCore::JSHTMLSelectElement::indexSetter):
+ * bindings/js/JSHTMLSelectElementCustom.h:
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::nonCachingStaticBackFunctionGetter):
+ (WebCore::nonCachingStaticForwardFunctionGetter):
+ (WebCore::nonCachingStaticGoFunctionGetter):
+ (WebCore::JSHistory::customPut):
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+ (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
+ * bindings/js/JSInspectedObjectWrapper.h:
+ (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap):
+ (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate):
+ (WebCore::JSJavaScriptCallFrame::thisObject):
+ (WebCore::JSJavaScriptCallFrame::type):
+ (WebCore::JSJavaScriptCallFrame::scopeChain):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::nonCachingStaticReplaceFunctionGetter):
+ (WebCore::nonCachingStaticReloadFunctionGetter):
+ (WebCore::nonCachingStaticAssignFunctionGetter):
+ (WebCore::JSLocation::customPut):
+ (WebCore::JSLocation::setHref):
+ (WebCore::JSLocation::setProtocol):
+ (WebCore::JSLocation::setHost):
+ (WebCore::JSLocation::setHostname):
+ (WebCore::JSLocation::setPort):
+ (WebCore::JSLocation::setPathname):
+ (WebCore::JSLocation::setSearch):
+ (WebCore::JSLocation::setHash):
+ (WebCore::JSLocation::replace):
+ (WebCore::JSLocation::reload):
+ (WebCore::JSLocation::assign):
+ (WebCore::JSLocation::toString):
+ * bindings/js/JSMessageChannelConstructor.h:
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ (WebCore::JSMimeTypeArray::nameGetter):
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ (WebCore::JSNamedNodeMap::nameGetter):
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::lengthGetter):
+ (WebCore::JSNamedNodesCollection::indexGetter):
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createStructure):
+ * bindings/js/JSNavigatorCustom.cpp:
+ (WebCore::needsYouTubeQuirk):
+ (WebCore::JSNavigator::appVersion):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::insertBefore):
+ (WebCore::JSNode::replaceChild):
+ (WebCore::JSNode::removeChild):
+ (WebCore::JSNode::appendChild):
+ (WebCore::createWrapper):
+ (WebCore::toJSNewlyCreated):
+ (WebCore::toJS):
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/JSNodeFilterCondition.h:
+ (WebCore::JSNodeFilterCondition::create):
+ * bindings/js/JSNodeFilterCustom.cpp:
+ (WebCore::JSNodeFilter::acceptNode):
+ (WebCore::toNodeFilter):
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ (WebCore::JSNodeIterator::nextNode):
+ (WebCore::JSNodeIterator::previousNode):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::callNodeList):
+ (WebCore::JSNodeList::nameGetter):
+ * bindings/js/JSPluginArrayCustom.cpp:
+ (WebCore::JSPluginArray::nameGetter):
+ * bindings/js/JSPluginCustom.cpp:
+ (WebCore::JSPlugin::nameGetter):
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::runtimeObjectGetter):
+ (WebCore::runtimeObjectPropertyGetter):
+ (WebCore::runtimeObjectCustomPut):
+ (WebCore::callPlugin):
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::asWrapper):
+ (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
+ (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
+ (WebCore::JSQuarantinedObjectWrapper::put):
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ (WebCore::JSQuarantinedObjectWrapper::hasInstance):
+ (WebCore::JSQuarantinedObjectWrapper::call):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::createStructure):
+ * bindings/js/JSRGBColor.cpp:
+ (WebCore::getJSRGBColor):
+ (jsRGBColorRed):
+ (jsRGBColorGreen):
+ (jsRGBColorBlue):
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::createStructure):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ * bindings/js/JSSVGLengthCustom.cpp:
+ (WebCore::JSSVGLength::value):
+ (WebCore::JSSVGLength::convertToSpecifiedUnits):
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ (WebCore::JSSVGMatrix::multiply):
+ (WebCore::JSSVGMatrix::inverse):
+ (WebCore::JSSVGMatrix::translate):
+ (WebCore::JSSVGMatrix::scale):
+ (WebCore::JSSVGMatrix::scaleNonUniform):
+ (WebCore::JSSVGMatrix::rotate):
+ (WebCore::JSSVGMatrix::rotateFromVector):
+ (WebCore::JSSVGMatrix::flipX):
+ (WebCore::JSSVGMatrix::flipY):
+ (WebCore::JSSVGMatrix::skewX):
+ (WebCore::JSSVGMatrix::skewY):
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ (WebCore::JSSVGPathSegList::clear):
+ (WebCore::JSSVGPathSegList::initialize):
+ (WebCore::JSSVGPathSegList::getItem):
+ (WebCore::JSSVGPathSegList::insertItemBefore):
+ (WebCore::JSSVGPathSegList::replaceItem):
+ (WebCore::JSSVGPathSegList::removeItem):
+ (WebCore::JSSVGPathSegList::appendItem):
+ * bindings/js/JSSVGPointListCustom.cpp:
+ (WebCore::finishGetter):
+ (WebCore::finishSetter):
+ (WebCore::finishSetterReadOnlyResult):
+ (WebCore::JSSVGPointList::clear):
+ (WebCore::JSSVGPointList::initialize):
+ (WebCore::JSSVGPointList::getItem):
+ (WebCore::JSSVGPointList::insertItemBefore):
+ (WebCore::JSSVGPointList::replaceItem):
+ (WebCore::JSSVGPointList::removeItem):
+ (WebCore::JSSVGPointList::appendItem):
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ (WebCore::finishGetter):
+ (WebCore::finishSetter):
+ (WebCore::finishSetterReadOnlyResult):
+ (WebCore::JSSVGTransformList::clear):
+ (WebCore::JSSVGTransformList::initialize):
+ (WebCore::JSSVGTransformList::getItem):
+ (WebCore::JSSVGTransformList::insertItemBefore):
+ (WebCore::JSSVGTransformList::replaceItem):
+ (WebCore::JSSVGTransformList::removeItem):
+ (WebCore::JSSVGTransformList::appendItem):
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::nameGetter):
+ (WebCore::JSStorage::deleteProperty):
+ (WebCore::JSStorage::customPut):
+ * bindings/js/JSStyleSheetCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ (WebCore::JSStyleSheetList::nameGetter):
+ * bindings/js/JSTextCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ (WebCore::JSTreeWalker::parentNode):
+ (WebCore::JSTreeWalker::firstChild):
+ (WebCore::JSTreeWalker::lastChild):
+ (WebCore::JSTreeWalker::nextSibling):
+ (WebCore::JSTreeWalker::previousSibling):
+ (WebCore::JSTreeWalker::previousNode):
+ (WebCore::JSTreeWalker::nextNode):
+ * bindings/js/JSWorkerContextBase.cpp:
+ (WebCore::JSWorkerContextBase::put):
+ * bindings/js/JSWorkerContextBase.h:
+ * bindings/js/JSWorkerContextCustom.cpp:
+ (WebCore::JSWorkerContext::self):
+ (WebCore::JSWorkerContext::setSelf):
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::JSWorker::addEventListener):
+ (WebCore::JSWorker::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::open):
+ (WebCore::JSXMLHttpRequest::setRequestHeader):
+ (WebCore::JSXMLHttpRequest::send):
+ (WebCore::JSXMLHttpRequest::getResponseHeader):
+ (WebCore::JSXMLHttpRequest::overrideMimeType):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ (WebCore::JSXMLHttpRequest::responseText):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ (WebCore::JSXSLTProcessor::importStylesheet):
+ (WebCore::JSXSLTProcessor::transformToFragment):
+ (WebCore::JSXSLTProcessor::transformToDocument):
+ (WebCore::JSXSLTProcessor::setParameter):
+ (WebCore::JSXSLTProcessor::getParameter):
+ (WebCore::JSXSLTProcessor::removeParameter):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::ScheduledAction):
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createScriptObjectForPluginElement):
+ * bindings/js/ScriptValue.cpp:
+ (WebCore::ScriptValue::getString):
+ (WebCore::ScriptValue::isNull):
+ (WebCore::ScriptValue::isUndefined):
+ * bindings/js/ScriptValue.h:
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::jsValue):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ (-[WebScriptObject evaluateWebScript:]):
+ (-[WebScriptObject valueForKey:]):
+ (-[WebScriptObject webScriptValueAtIndex:]):
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+ * bindings/objc/WebScriptObjectPrivate.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Evaluate):
+ (_NPN_GetProperty):
+ (_NPN_HasMethod):
+ (_NPN_Construct):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::invokeMethod):
+ (JSC::Bindings::CInstance::invokeDefaultMethod):
+ (JSC::Bindings::CInstance::invokeConstruct):
+ (JSC::Bindings::CInstance::defaultValue):
+ (JSC::Bindings::CInstance::stringValue):
+ (JSC::Bindings::CInstance::numberValue):
+ (JSC::Bindings::CInstance::booleanValue):
+ (JSC::Bindings::CInstance::valueOf):
+ * bridge/c/c_instance.h:
+ * bridge/c/c_runtime.cpp:
+ (JSC::Bindings::CField::valueFromInstance):
+ (JSC::Bindings::CField::setValueToInstance):
+ * bridge/c/c_runtime.h:
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertValueToNPVariant):
+ (JSC::Bindings::convertNPVariantToValue):
+ * bridge/c/c_utility.h:
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::stringValue):
+ (JavaInstance::numberValue):
+ (JavaInstance::booleanValue):
+ (JavaInstance::invokeMethod):
+ (JavaInstance::defaultValue):
+ (JavaInstance::valueOf):
+ * bridge/jni/jni_instance.h:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::eval):
+ (JavaJSObject::getMember):
+ (JavaJSObject::getSlot):
+ (JavaJSObject::convertValueToJObject):
+ (JavaJSObject::convertJObjectToValue):
+ * bridge/jni/jni_objc.mm:
+ (JSC::Bindings::dispatchJNICall):
+ * bridge/jni/jni_runtime.cpp:
+ (JavaArray::convertJObjectToArray):
+ (JavaField::dispatchValueFromInstance):
+ (JavaField::valueFromInstance):
+ (JavaField::dispatchSetValueToInstance):
+ (JavaField::setValueToInstance):
+ (JavaArray::setValueAt):
+ (JavaArray::valueAt):
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ (JSC::Bindings::convertArrayInstanceToJavaArray):
+ (JSC::Bindings::convertValueToJValue):
+ * bridge/jni/jni_utility.h:
+ * bridge/objc/WebScriptObject.h:
+ * bridge/objc/objc_class.h:
+ * bridge/objc/objc_class.mm:
+ (JSC::Bindings::ObjcClass::fallbackObject):
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::invokeMethod):
+ (ObjcInstance::invokeDefaultMethod):
+ (ObjcInstance::setValueOfUndefinedField):
+ (ObjcInstance::getValueOfUndefinedField):
+ (ObjcInstance::defaultValue):
+ (ObjcInstance::stringValue):
+ (ObjcInstance::numberValue):
+ (ObjcInstance::booleanValue):
+ (ObjcInstance::valueOf):
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcField::valueFromInstance):
+ (JSC::Bindings::convertValueToObjcObject):
+ (JSC::Bindings::ObjcField::setValueToInstance):
+ (JSC::Bindings::ObjcArray::setValueAt):
+ (JSC::Bindings::ObjcArray::valueAt):
+ (JSC::Bindings::ObjcFallbackObjectImp::put):
+ (JSC::Bindings::callObjCFallbackObject):
+ (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ (JSC::Bindings::convertValueToObjcValue):
+ (JSC::Bindings::convertNSStringToString):
+ (JSC::Bindings::convertObjcValueToValue):
+ * bridge/runtime.cpp:
+ (JSC::Bindings::Instance::getValueOfField):
+ (JSC::Bindings::Instance::setValueOfField):
+ * bridge/runtime.h:
+ (JSC::Bindings::Class::fallbackObject):
+ (JSC::Bindings::Instance::getValueOfUndefinedField):
+ (JSC::Bindings::Instance::setValueOfUndefinedField):
+ (JSC::Bindings::Instance::invokeDefaultMethod):
+ (JSC::Bindings::Instance::invokeConstruct):
+ (JSC::Bindings::Instance::valueOf):
+ * bridge/runtime_array.cpp:
+ (JSC::RuntimeArray::lengthGetter):
+ (JSC::RuntimeArray::indexGetter):
+ (JSC::RuntimeArray::put):
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::createStructure):
+ * bridge/runtime_method.cpp:
+ (JSC::RuntimeMethod::lengthGetter):
+ (JSC::callRuntimeMethod):
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createStructure):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::fallbackObjectGetter):
+ (JSC::RuntimeObjectImp::fieldGetter):
+ (JSC::RuntimeObjectImp::methodGetter):
+ (JSC::RuntimeObjectImp::put):
+ (JSC::RuntimeObjectImp::defaultValue):
+ (JSC::callRuntimeObject):
+ (JSC::callRuntimeConstructor):
+ * bridge/runtime_object.h:
+ (JSC::RuntimeObjectImp::createStructure):
+ * inspector/InspectorController.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::evaluate):
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::toJS):
+ * inspector/JavaScriptProfile.h:
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::toJS):
+ * inspector/JavaScriptProfileNode.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::dropProtection):
+
+2009-01-06 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Added new API on AnimationController::numberOfActiveAnimations() to be used by DRT.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23126
+
+ Test: animations/animation-controller-drt-api.html
+
+ * WebCore.base.exp:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
+ (WebCore::AnimationController::numberOfActiveAnimations):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
+ (WebCore::CompositeAnimation::numberOfActiveAnimations):
+ * page/animation/CompositeAnimation.h:
+
+2009-01-06 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Upstream 3 more files to get the WebCore-Chromium build a bit further.
+
+ * WebCore.scons:
+ * page/chromium/AccessibilityObjectChromium.cpp: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ * page/chromium/AccessibilityObjectWrapper.h: Added.
+ (WebCore::AccessibilityObjectWrapper::~AccessibilityObjectWrapper):
+ (WebCore::AccessibilityObjectWrapper::attached):
+ (WebCore::AccessibilityObjectWrapper::accessibilityObject):
+ (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
+ * platform/chromium/PasteboardPrivate.h: Added.
+ (WebCore::PasteboardPrivate::):
+
+2009-01-06 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Tests: animations/simultaneous-start-left.html
+ animations/simultaneous-start-transform.html
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22870
+
+ I added calls beginAnimationUpdate() and endAnimationUpdate() calls
+ to AnimationController. These are called by Document at the start
+ and end of the recalcStyle cycle. Right now, I'm just using the
+ beginAnimationUpdate() method to reset an animation time value.
+ The first time the animation time is accessed after this reset I set
+ it to the currentTime. So all animations in that cycle get the same
+ start time.
+
+ The test cases checked in test this, but in the case of the 'left'
+ test it actually doesn't make any difference in most cases. This is
+ because values are clamped to whole pixels, so the start times would
+ have to be pretty far off for the test to fail using the old
+ currentTime() model. Still, under really heavy load, it's possible for
+ the test to fail without these changes.
+
+ The 'transform' test is another story. It animates to the full resolution
+ of a floating point number, so the test fails miserably without this
+ fix.
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
+ (WebCore::AnimationBase::willNeedService):
+ (WebCore::AnimationBase::progress):
+ (WebCore::AnimationBase::goIntoEndingOrLoopingState):
+ (WebCore::AnimationBase::beginAnimationUpdateTime):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
+ (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
+ (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
+ (WebCore::AnimationController::updateAnimations):
+ (WebCore::AnimationController::beginAnimationUpdateTime):
+ (WebCore::AnimationController::beginAnimationUpdate):
+ (WebCore::AnimationController::endAnimationUpdate):
+ * page/animation/AnimationController.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+
+2009-01-06 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Bug 22858: Simplify make_names.pl code for avoiding multiple definitions or inclusions
+ https://bugs.webkit.org/show_bug.cgi?id=22858
+
+ I had introduced an awkward situation using hasCustomJSWrapper and
+ sometimes boolean parameter in order to ensure JS wrapper generated once
+ or header included once.
+
+ Simplified the code by using a %seenTag hash to detect multiple definitions
+ or inclusions and skipping it.
+
+ Also cleaned up a bit make_names.pl by using more explicit names and moving
+ code to where it belongs.
+
+ * dom/make_names.pl:
+ * html/HTMLTagNames.in: Necessary changes that were not detected by
+ the previous syntax but will be required for autogenerating HTMLElementFactory.
+
+2009-01-06 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Add a way for frame loader clients to always create a PluginDocument, regardless of
+ the real document MIME type.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::begin):
+ (WebCore::FrameLoader::shouldUsePlugin):
+ * loader/FrameLoaderClient.h:
+ (WebCore::FrameLoaderClient::shouldUsePluginDocument):
+
+2009-01-06 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Extend Media Queries to cover transitions,
+ animations, transform-2d and transform-3d
+ http://webkit.org/specs/MediaQueriesExtensions.html
+ Note that the implementation uses -webkit- prefixes
+ even though the spec doesn't have them.
+ https://bugs.webkit.org/show_bug.cgi?id=22494
+
+ Tests: fast/media/mq-animation.html
+ fast/media/mq-transform-01.html
+ fast/media/mq-transform-02.html
+ fast/media/mq-transform-03.html
+ fast/media/mq-transform-04.html
+ fast/media/mq-transition.html
+
+ * css/MediaFeatureNames.h:
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::animationMediaFeatureEval):
+ (WebCore::transitionMediaFeatureEval):
+ (WebCore::transform_2dMediaFeatureEval):
+ (WebCore::transform_3dMediaFeatureEval):
+
+2009-01-06 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Bring the Chromium-WebCore build closer to building
+ by upstreaming PlatformWidget.h add adding the JSC
+ plugin bridge files to the build.
+
+ * WebCore.scons:
+ * platform/chromium/PlatformWidget.h: Added.
+
+2009-01-06 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ Bring the Chromium-WebCore build back closer to building
+ by adding files from recent commits.
+
+ * WebCore.scons:
+
+2009-01-06 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6474973> REGRESSION: PLT ~2% slower due to 39465 (consolidate thread data)
+
+ I could not reproduce the slowdown on my PowerPC test machine, but the change should bring
+ performance back.
+
+ * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Don't use AtomicallyInitializedStatic.
+ Prior to r39465, it was only used for cached converters, which was necessary because the
+ first access to ICU or TEC one could happen on a secondary thread, but now they are all
+ initialized from ThreadGlobalData constructor.
+
+2009-01-06 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23129
+ Devirtualize Node::childNodes().
+
+2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Unreviewed build fix.
+
+ Fix the Qt build with Qt 4.4.x, the HTTP-only cookie support was
+ added in Qt 4.5.
+
+ * platform/qt/CookieJarQt.cpp:
+ (WebCore::setCookies):
+ (WebCore::cookies):
+
+2009-01-06 Zalan Bujtas <zbujtas@gmail.com>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23133
+ Fix SVG disabled build. Move 'pointer-events' from SVGCSSPropertyNames.in to
+ CSSPropertyNames.in and move PointerEvents functions out of #if ENABLE(SVG)
+
+ NOTE: Property name fixes landed as part of r39648.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator EPointerEvents):
+ * css/CSSPropertyNames.in:
+ * css/SVGCSSPropertyNames.in:
+
+2009-01-06 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX (r39634): Fix build for non-SVG builds (Wx)
+
+ * css/CSSPropertyNames.in: Added 'pointer-events'.
+ * css/SVGCSSPropertyNames.in: Commented out pointer-events
+ since it's now a plain CSS property.
+
+2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Lars Knoll.
+
+ Added support for HTTP-only cookies to the Qt build.
+
+ * platform/qt/CookieJarQt.cpp:
+ (WebCore::setCookies): Don't set HTTP-only cookies through the DOM.
+ (WebCore::cookies): Don't return HTTP-only cookies to the DOM.
+
+2009-01-05 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23084
+ Avoid redundant AtomicString conversions
+
+ * dom/Node.cpp: Create an AtomicString early to avoid converting twice
+ (WebCore::Node::getElementsByTagNameNS):
+ * dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String
+
+2009-01-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=22985
+
+ Add an assertion that clip rects are being used when painting with the same
+ rootLayer that they were computed with.
+
+ Fix two issues detected by the assertion:
+
+ RenderLayer::updateClipRects() should not unconditionally update the clip rects
+ on its parent, but stop when reaching rootLayer (just like calculateClipRects()).
+
+ We need to pass the temporaryClipRects flag down through reflection painting
+ to handle the case of nested reflections.
+
+ Also use temporary clip rects in RenderTreeAsText, since that code does not
+ reset the painting root for transformed layers, so cached clip rects will not
+ match those used for painting.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::updateClipRects):
+ (WebCore::RenderLayer::clearClipRects):
+ * rendering/RenderLayer.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeLayers):
+
+2009-01-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build
+
+ * platform/graphics/qt/AffineTransformQt.cpp:
+ (WebCore::TransformationMatrix::TransformationMatrix):
+
+2009-01-05 Mark Rowe <mrowe@apple.com>
+
+ Fix the build some more.
+
+ * platform/graphics/cairo/AffineTransformCairo.cpp:
+ (WebCore::TransformationMatrix::TransformationMatrix):
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix Cairo/Gtk build
+
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::putImageData):
+
+2009-01-05 Dean Jackson <dino@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Rename AffineTransform to TransformationMatrix in
+ preparation for future enhancements (non-affine matrices)
+
+ https://bugs.webkit.org/show_bug.cgi?id=22943
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * platform/graphics/transforms/AffineTransform.cpp: Removed.
+ * platform/graphics/transforms/AffineTransform.h: Removed.
+ * platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
+ * platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
+ * lots of other files with s/AffineTransform/TransformationMatrix/g
+
+2008-01-05 Dean Jackson <dino@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Implement 'pointer-events' for HTML content. This involved
+ adding a new value 'auto' which behaves as 'visiblePainted'
+ in SVG content.
+
+ Moved the property out of the SVG CSS code and into
+ the general CSS (both parsing and RenderStyle).
+
+ Changes to the hit testing functionality of the Render tree,
+ specifically the nodeAtPoint methods. Where they used to
+ test for visibility, they now use a helper function defined
+ on base classes (RenderObject and InlineBox) that checks both
+ visibility and pointer-events.
+
+ https://bugs.webkit.org/show_bug.cgi?id=11395
+
+ Tests: fast/events/pointer-events-2.html
+ fast/events/pointer-events.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator EPointerEvents):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/SVGCSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
+ * css/SVGCSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applySVGProperty):
+ * manual-tests/pointer-events.html: Added.
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::nodeAtPoint):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::visibleToHitTesting):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::nodeAtPoint):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::nodeAtPoint):
+ * rendering/PointerEventsHitRules.cpp:
+ (WebCore::PointerEventsHitRules::PointerEventsHitRules):
+ * rendering/PointerEventsHitRules.h:
+ (WebCore::PointerEventsHitRules::):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::nodeAtPoint):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::nodeAtPoint):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::visibleToHitTesting):
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::nodeAtPoint):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::nodeAtPoint):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::nodeAtPoint):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::nodeAtPoint):
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
+ * rendering/style/RenderStyle.h:
+ (WebCore::):
+ (WebCore::InheritedFlags::setBitDefaults):
+ (WebCore::InheritedFlags::pointerEvents):
+ (WebCore::InheritedFlags::setPointerEvents):
+ (WebCore::InheritedFlags::initialPointerEvents):
+ * rendering/style/RenderStyleConstants.h:
+ (WebCore::):
+ * rendering/style/SVGRenderStyle.h:
+ (WebCore::SVGRenderStyle::InheritedFlags::operator==):
+ (WebCore::SVGRenderStyle::setBitDefaults):
+ * rendering/style/SVGRenderStyleDefs.h:
+ * css/CSSValueKeywords.in:
+ * css/SVGCSSValueKeywords.in:
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Fix Cairo/Gtk build
+
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::getImageData):
+
+2009-01-05 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ CanvasPixelArray performance is too slow
+ <https://bugs.webkit.org/show_bug.cgi?id=23123>
+
+ Remove the WebCore CanvasPixelArray implementation and replace
+ CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
+ wrapper with an explicitly instantiated JSByteArray put on the
+ JSImageData object as an ordinary ReadOnly, DontDelete property.
+
+ * DerivedSources.make:
+ * ForwardingHeaders/runtime/ByteArray.h: Added.
+ * ForwardingHeaders/runtime/JSByteArray.h: Added.
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSCanvasPixelArrayCustom.h: Removed.
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ * html/CanvasPixelArray.cpp: Removed.
+ * html/CanvasPixelArray.h: Removed.
+ * html/CanvasPixelArray.idl: Removed.
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::createEmptyImageData):
+ * html/ImageData.cpp:
+ (WebCore::ImageData::ImageData):
+ * html/ImageData.h:
+ (WebCore::ImageData::data):
+ * html/ImageData.idl:
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+
+2009-01-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Add notification for contentsSizeChanged which the Qt API will
+ introduce.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::contentsSizeChanged):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::contentsSizeChanged):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setContentsSize):
+ * page/FrameView.h:
+ * platform/HostWindow.h:
+ * platform/ScrollView.h:
+
+2009-01-05 Anders Carlsson <andersca@apple.com>
+
+ Build fix.
+
+ * plugins/PluginView.h:
+ (WebCore::PluginManualLoader::~PluginManualLoader):
+
+2009-01-05 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ Add an abstract PluginManualLoader class and make PluginView inherit from it.
+
+ Add some error checking that currently exists in WebKit (but not for long!)
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::didReceiveResponse):
+ (WebCore::PluginView::didReceiveData):
+ (WebCore::PluginView::didFinishLoading):
+ (WebCore::PluginView::didFail):
+ * plugins/PluginView.h:
+
+2009-01-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes FrameView to respect the state of scrollbarmode when it is explicitly
+ set programatically via a webkit API.
+
+ * loader/FrameLoaderClient.cpp:
+ (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
+ * loader/FrameLoaderClient.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::initScrollbars):
+ (WebCore::FrameView::updateDefaultScrollbarState):
+ * page/FrameView.h:
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=23109
+
+ Test: fast/text/find-backwards.html
+
+ * editing/TextIterator.cpp:
+ (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy.
+ (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but
+ we're at a break; must not try to search because ICU will give us an error.
+ Fix incorrect size passed to memcpy and memmove.
+ (WebCore::findPlainText): Fix case where we found a match and need to search
+ again because we want to find the last match. We need to try again without
+ adding any more text or handling the break before moving on.
+
+2009-01-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Fix the Qt build
+
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::put):
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Fix platforms that don't have Workers enabled.
+
+ * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in
+ two stages, so that EventNames constructor can access the just-created atomic string table.
+ This matches what happens in ThreadSpecific case.
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Suggested by Dave Levin.
+
+ Mac release build fix.
+
+ * WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ * dom/Document.cpp: Fix build. Oops again.
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Fix hang whenever following an anchor.
+
+ * dom/Document.cpp:
+ (WebCore::Document::findAnchor): Oops!
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23073
+ <rdar://problem/6471129> Workers crash on Windows Release builds
+
+ * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
+ * platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames):
+ Now that ThreadSpecific sets up the pointer before invoking data constructor, we can
+ initialize EventNames right away.
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument
+ https://bugs.webkit.org/show_bug.cgi?id=23106
+
+ This led me to a bunch of dead code. It turns out that HTML collections
+ were carrying the case-insensitive code just so they could be used to
+ find anchors, something we can do more simply and efficiently without
+ creating a DOM HTMLCollection object.
+
+ No behavior change. Just adding a new function findAnchor function and
+ removing some dead code.
+
+ * dom/Document.cpp:
+ (WebCore::Document::findAnchor): Added.
+ * dom/Document.h: Ditto.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString
+ references for better efficiency.
+ (WebCore::HTMLAnchorElement::setAccessKey): Ditto.
+ (WebCore::HTMLAnchorElement::charset): Ditto.
+ (WebCore::HTMLAnchorElement::setCharset): Ditto.
+ (WebCore::HTMLAnchorElement::coords): Ditto.
+ (WebCore::HTMLAnchorElement::setCoords): Ditto.
+ (WebCore::HTMLAnchorElement::setHref): Ditto.
+ (WebCore::HTMLAnchorElement::hreflang): Ditto.
+ (WebCore::HTMLAnchorElement::setHreflang): Ditto.
+ (WebCore::HTMLAnchorElement::name): Ditto.
+ (WebCore::HTMLAnchorElement::setName): Ditto.
+ (WebCore::HTMLAnchorElement::rel): Ditto.
+ (WebCore::HTMLAnchorElement::setRel): Ditto.
+ (WebCore::HTMLAnchorElement::rev): Ditto.
+ (WebCore::HTMLAnchorElement::setRev): Ditto.
+ (WebCore::HTMLAnchorElement::shape): Ditto.
+ (WebCore::HTMLAnchorElement::setShape): Ditto.
+ (WebCore::HTMLAnchorElement::setTarget): Ditto.
+ (WebCore::HTMLAnchorElement::type): Ditto.
+ (WebCore::HTMLAnchorElement::setType): Ditto.
+ * html/HTMLAnchorElement.h: Ditto.
+
+ * html/HTMLCollection.cpp:
+ (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an
+ AtomicString and removed the caseSensitive boolean, since we're now always
+ case sensitive.
+ (WebCore::HTMLCollection::namedItem): Ditto.
+ (WebCore::HTMLCollection::nextNamedItem): Ditto.
+ * html/HTMLCollection.h: Ditto.
+ * html/HTMLFormCollection.cpp:
+ (WebCore::HTMLFormCollection::getNamedItem): Ditto.
+ (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
+ (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto.
+ (WebCore::HTMLFormCollection::namedItem): Ditto.
+ (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
+ * html/HTMLFormCollection.h: Ditto.
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::namedItem): Ditto.
+ * html/HTMLSelectElement.h: Ditto.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Bug 23104: minor mistakes in init functions for animation and transition events
+ https://bugs.webkit.org/show_bug.cgi?id=23104
+
+ Test: fast/events/init-events.html
+
+ Also fixed two StorageEvent problems the test case uncovered:
+
+ Made document.createEvent("StorageEvent") work.
+ Allow null values for StorageEvent.oldValue and StorageEvent.newValue.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createEvent): Sorted alphabetically by the name of the event
+ class. Added StorageEvent.
+
+ * dom/UIEvent.idl: Fixed typo in a comment.
+
+ * dom/WebKitAnimationEvent.cpp:
+ (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
+ * dom/WebKitTransitionEvent.cpp:
+ (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
+
+ * storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the
+ arguments to initStorageEvent so it can create events with null values for the
+ oldValue and newValue, just like the real storage events. Note that the properties
+ already had ConvertNullStringTo=Null, so this is just the other half of that.
+
+2009-01-05 Darin Adler <darin@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 23102: turn on unused parameter warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=23102
+
+ First step: Fix the simple cases where we can just remove an argument name.
+ Also made a few more things protected and private.
+
+ * many files
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23115
+ Create a version of ASSERT for use with otherwise unused variables
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Non-Mac build fix.
+
+ * loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.
+
+2009-01-05 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Remove unnecessary methods from EmptyFrameLoaderClient
+
+ * loader/EmptyClients.h:
+
+2009-01-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23077
+ Make application cache use SQLite built-in user_version
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with
+ PRAGMA user_version.
+
+ * loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
+ Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic
+ cache entries.
+
+2009-01-04 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23084
+ Avoid redundant AtomicString conversions
+
+ * dom/Node.cpp:
+ (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*"
+ (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI
+ (WebCore::Node::isDefaultNamespace): Ditto
+ (WebCore::Node::lookupPrefix): Ditto
+ (WebCore::Node::lookupNamespacePrefix): Ditto
+ * dom/Node.h: Ditto
+
+2009-01-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23105: canvas setFillColor function ignores alpha argument
+ https://bugs.webkit.org/show_bug.cgi?id=23105
+
+ Test: fast/canvas/set-colors.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead
+ of ignoring it and always passing 1.
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments.
+ (WebCore::CanvasStyle::applyFillColor): Ditto.
+
+2009-01-04 Darin Adler <darin@apple.com>
+
+ Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
+ https://bugs.webkit.org/show_bug.cgi?id=23086
+
+ * editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile
+ in the new search path if it's 0.
+
+2009-01-04 David Kilzer <ddkilzer@apple.com>
+
+ Don't install *.idl and *.in files as resources
+
+ Reviewed by Oliver Hunt.
+
+ Don't install these files as resources in the WebCore framework:
+ - WMLAttributeNames.in
+ - WMLTagNames.in
+ - WorkerContext.idl
+ - WorkerLocation.idl
+ - WorkerNavigator.idl
+
+ * WebCore.xcodeproj/project.pbxproj: Removed resources.
+
+2009-01-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=23090
+
+ If an object gets a Layout hint, and the style change will result in
+ the creation of a RenderLayer, then we need to repaint the old position
+ of the object. This was done for transform, but we have to test opacity too.
+
+ Test: fast/repaint/create-layer-repaint.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+
+2009-01-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23103: Safari's auto-fill no longer works for <select> elements
+ https://bugs.webkit.org/show_bug.cgi?id=23103
+ rdar://problem/6472061
+
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
+
+2009-01-04 Adam Treat <adam.treat@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Add fixedLayoutSize feature to ScrollView to allow for controlling the
+ layout beyond the constraint of the current viewports dynamic size
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::heightMediaFeatureEval):
+ (WebCore::widthMediaFeatureEval):
+ * dom/Element.cpp:
+ (WebCore::Element::clientWidth):
+ (WebCore::Element::clientHeight):
+ * loader/FrameLoaderClient.cpp:
+ (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
+ * loader/FrameLoaderClient.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::layoutWidth):
+ (WebCore::ScrollView::layoutHeight):
+ (WebCore::ScrollView::fixedLayoutSize):
+ (WebCore::ScrollView::setFixedLayoutSize):
+ (WebCore::ScrollView::useFixedLayout):
+ (WebCore::ScrollView::setUseFixedLayout):
+ * platform/ScrollView.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::viewHeight):
+ (WebCore::RenderView::viewWidth):
+ * rendering/RenderView.h:
+
+2009-01-03 Rob Buis <rwlbuis@gmail.com>
+
+ Reviewed by Darin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22660
+ SVG elements that are moved are nor fully invalidated/earsed
+
+ Mark the SVG root as needing a layout when its position changes.
+
+ Tests: svg/custom/circle-move-invalidation.svg
+
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::position):
+ * rendering/RenderSVGRoot.h:
+
+2009-01-03 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * loader/FrameLoader.h:
+
+2009-01-02 Cary Clark <caryclark@google.com>
+
+ Reviewed and landed by Darin Adler.
+
+ Bug 22963: write icons before reading them
+ https://bugs.webkit.org/show_bug.cgi?id=22963
+
+ Reverse the order in the icon database main thread loop to
+ write the pending icons to the database before trying
+ to read any requested icons. This ensures that a requested icon
+ has the correct data when read.
+
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::syncThreadMainLoop):
+
+2009-01-02 Darin Adler <darin@apple.com>
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in.
+ This cuts down on the number of hash table operations during loading.
+
+2009-01-02 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed and landed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23025
+ DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
+ Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
+ Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
+ unnecessary HashMap remove in case the Document is being destroyed.
+
+ * bindings/js/DOMTimer.cpp:
+ (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap.
+ (WebCore::DOMTimer::install):
+ (WebCore::DOMTimer::removeById): simply uses 'delete this'.
+ (WebCore::DOMTimer::fired): same.
+ (WebCore::DOMTimer::contextDestroyed): same.
+ * dom/Document.cpp:
+ (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.
+
+2009-01-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
+ inside its web view when resizing its window
+ https://bugs.webkit.org/show_bug.cgi?id=23072
+ rdar://problem/6368028
+
+ The first attempt at fixing this did not work.
+ This time I was able to reproduce the bug and test the fix.
+
+ Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh
+ https://bugs.webkit.org/show_bug.cgi?id=11212
+ rdar://problem/4959702
+
+ I had to fix this second bug because otherwise the WebKit code to trigger the first
+ fix didn't run.
+
+ Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
+ a particular frame. Bad idea! It's bad enough that we do it for each document, but
+ the old version kept the set around forever as you moved from one document to the next.
+
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow
+ turning off scrolling when the quirk is enabled. We just don't allow turning it on.
+ This fixes one of the two problems with the initial patch; the other fix is in WebKit.
+
+ * loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad
+ here from FrameLoader. The old way meant that a given frame would forever remember
+ the URL of any resources loaded in that frame and never send any "loaded from cache"
+ client calls about those URLs.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad.
+ This is now handled by dispatchWillSendRequest, which is safer since that's the actual
+ function that tells the client about the load.
+ (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to
+ haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader.
+ Also removed the call in the case where we don't load from the cache, since
+ dispatchWillSendRequest now takes care of it.
+ (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad
+ here. Call it both on the URL we pass in and the URL the client returns; we won't
+ tell the client about either if it's loaded from the memory cache.
+
+ * loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and
+ m_urlsClientKnowsAbout.
+
+ * loader/SubresourceLoader.cpp: Removed unneeded load function that called
+ didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.
+
+ * loader/SubresourceLoader.h: Removed load function. Also made all members private
+ except for create and clearClient.
+
+2009-01-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=23082
+
+ Fix GIF animation by ensuring that the signature of
+ startAnimation() in the base class matches the method in BitmapImage.
+
+ Test: fast/backgrounds/animated-gif-as-background.html
+
+ * platform/graphics/Image.h:
+ (WebCore::Image::startAnimation):
+
+2009-01-02 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22699
+ Enable NodeList caching for getElementsByTagName
+
+ test: fast/dom/getelementsbytagnamens-mixed-namespaces.html
+
+ * dom/Document.cpp:
+ (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
+ * dom/Node.cpp:
+ (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache
+ (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others
+ (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
+ * dom/NodeRareData.h: Add m_tagNodeListCaches
+ * dom/QualifiedName.cpp:
+ * dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
+ * dom/StyledElement.cpp:
+ (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
+ * dom/TagNodeList.cpp:
+ (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
+ * dom/TagNodeList.h:
+ (WebCore::TagNodeList::create): Add a NodeList cache argument
+ * platform/text/StringHash.h:
+ (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue
+
+2009-01-02 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
+ Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
+
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom()
+ (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX (r39552): Add mediaControls.css to other build files
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Try to fix Wx build after r39427
+
+ * platform/graphics/wx/PathWx.cpp:
+ (WebCore::Path::strokeBoundingRect): Added stub.
+
+2009-01-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6471356> Failed assertion on quit
+
+ * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ Only assert that empty string are all removed on secondary threads.
+
+2009-01-02 David Kilzer <ddkilzer@apple.com>
+
+ Bug 23081: These files are no longer part of the KDE libraries
+
+ <https://bugs.webkit.org/show_bug.cgi?id=23081>
+
+ Reviewed by Darin Adler.
+
+ Removed "This file is part of the KDE libraries" comment from
+ source files. Added or updated Apple copyrights as well.
+
+ No tests since there are only changes to comments.
+
+ * bridge/testbindings.cpp:
+ * html/HTMLEntityNames.gperf:
+ * loader/Cache.h:
+ * loader/CachedCSSStyleSheet.h:
+ * loader/CachedResourceClient.h:
+ * loader/CachedResourceClientWalker.cpp:
+ * loader/CachedResourceClientWalker.h:
+ * loader/CachedScript.cpp:
+ * loader/CachedScript.h:
+ * loader/CachedXBLDocument.cpp:
+ * loader/CachedXBLDocument.h:
+ * loader/CachedXSLStyleSheet.cpp:
+ * loader/CachedXSLStyleSheet.h:
+ * rendering/GapRects.h:
+ * xml/XMLSerializer.cpp:
+
+2009-01-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ Use an OwnPtr for m_chromeClient.
+
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::~SVGImage):
+ (WebCore::SVGImage::dataChanged):
+ * svg/graphics/SVGImage.h:
+
+2009-01-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=22981
+
+ Repaints inside of an SVGImage were thrown on the floor,
+ which broke incremental painting due to loading, or SVG animation.
+ Fix this by assigning the SVGImage a ChromeClient subclass that passes
+ along repaints via a new method on ImageObserver, which also takes
+ a rect parameter for the changed rect, allowing incremental repaints.
+ Fix RenderImage::imageChanged to take advantage of this changedRect to
+ only repaint the changed parts of the image.
+
+ This also enables incremental painting for canvas-as-image, so
+ add tests for that too.
+
+ Tests: fast/backgrounds/animated-svg-as-background.html
+ fast/backgrounds/animated-svg-as-mask.html
+ fast/canvas/canvas-as-image-incremental-repaint.html
+ fast/canvas/canvas-as-image.html
+ fast/images/animated-svg-as-image.html
+
+ * css/CSSCanvasValue.cpp:
+ (WebCore::CSSCanvasValue::canvasChanged):
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::notifyObservers):
+ (WebCore::CachedImage::data):
+ (WebCore::CachedImage::changedInRect):
+ * loader/CachedImage.h:
+ * loader/CachedResourceClient.h:
+ (WebCore::CachedResourceClient::imageChanged):
+ * platform/graphics/ImageObserver.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::imageChanged):
+ * rendering/RenderBox.h:
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::imageChanged):
+ * rendering/RenderImage.h:
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::imageChanged):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::imageChanged):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::imageChanged):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::imageChanged):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::imageChanged):
+ * rendering/RenderScrollbarPart.h:
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::imageChanged):
+ * rendering/RenderTableCol.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::imageChanged):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::imageChanged):
+ * rendering/RenderTableSection.h:
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImageChromeClient::SVGImageChromeClient):
+ (WebCore::SVGImageChromeClient::image):
+ (WebCore::SVGImageChromeClient::chromeDestroyed):
+ (WebCore::SVGImageChromeClient::repaint):
+ (WebCore::SVGImage::SVGImage):
+ (WebCore::SVGImage::~SVGImage):
+ (WebCore::SVGImage::dataChanged):
+ * svg/graphics/SVGImage.h:
+
+2009-01-02 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=23043
+
+ Pull media controls css out of html4.css into separate file. Don't generate
+ wml, svg, or media css globals unless the feature is enabled.
+
+ * DerivedSources.make:
+ Don't include css for unused features.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ include mediaControls.css
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::styleForElement):
+ don't parse or add media css unless VIDEO feature is enabled and the target
+ element is video or audio
+
+ * css/html4.css:
+ moved media controls css to mediaControls.css
+
+ * css/mediaControls.css: Added.
+
+2009-01-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23022
+ Fix multiple issues with appcache online whitelist handling
+
+ Test: http/tests/appcache/online-whitelist.html
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes,
+ making it possible to use them for CGI invocation (as required by HTML5).
+
+ * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
+ Re-ordered checks, so that resources that are cached, but are also listed in online whitelist
+ are loaded from the cache. This is required by HTML5, although Firefox doesn't match.
+
+ * loader/appcache/ManifestParser.cpp:
+ (WebCore::parseManifest):
+ * loader/appcache/ManifestParser.h:
+ * loader/appcache/ApplicationCache.h:
+ (WebCore::ApplicationCache::onlineWhitelist):
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::store):
+ (WebCore::ApplicationCacheStorage::loadCache):
+ Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.
+
+2009-01-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
+ https://bugs.webkit.org/show_bug.cgi?id=23072
+ rdar://problem/6368028
+
+ * WebCore.base.exp: Updated.
+ * WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
+ * dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling,
+ and m_frameElementsShouldIgnoreScrolling.
+
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute
+ to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only
+ triggered on Mac OS X when running the Dictionary application.
+
+2009-01-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23036
+ <rdar://problem/6451666> Implement AppCache fallback entries (23036)
+
+ Test: http/tests/appcache/fallback.html
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback
+ entries if normal loading fails.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal
+ loading for resources that match fallback namespaces - they are only loaded from the cache
+ if that fails.
+ (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for
+ resource from associated appcache, or from passed in one, if any.
+ (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback
+ entry for resourse exists, add it to pending substitute loads.
+
+ * loader/DocumentLoader.h: Added new functions for loading fallback data for resources.
+
+ * loader/ResourceLoader.h:
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function
+ is called when normal loading fails (which includes network failures, 4xx and 5xx responses,
+ and cross-origin redirects) to load appcache fallback data instead. It can use either the
+ cache that is associated with the browsing context, or a custom one if association is yet
+ to take place.
+ (WebCore::ResourceLoader::willSendRequest): Try using fallback data.
+ (WebCore::ResourceLoader::didReceiveResponse): Ditto.
+ (WebCore::ResourceLoader::didFail): Ditto.
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load
+ fallback data from it if loading fails. The browsing context may still be associated with
+ its previous document here, so the cache to load from must be passed explicitly.
+ (WebCore::MainResourceLoader::didFail): Ditto.
+ (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.
+
+ * loader/appcache/ApplicationCache.cpp:
+ (WebCore::ApplicationCache::setFallbackURLs):
+ (WebCore::ApplicationCache::urlMatchesFallbackNamespace):
+ * loader/appcache/ApplicationCache.h:
+ (WebCore::ApplicationCache::fallbackURLs):
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::cacheGroupForURL):
+ (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
+ (WebCore::ApplicationCacheStorage::store):
+ (WebCore::ApplicationCacheStorage::loadCache):
+ (WebCore::ApplicationCacheStorage::storeCopyOfCache):
+ * loader/appcache/ApplicationCacheStorage.h:
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
+ * loader/appcache/ApplicationCacheGroup.h:
+ Implement fallback map saving and loading, pass it to the cache.
+
+ * loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys
+ are matched by prefix, so HAshMap cannot be used.
+
+ * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section
+ parsing.
+
+2009-01-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6450530> WebCore::FontPlatformData should not leak
+
+ Whoops, previous patch should also have fixed the font referencing in
+ the constructor.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/mac/FontPlatformDataMac.mm:
+ (WebCore::FontPlatformData::FontPlatformData):
+
+2009-01-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ <rdar://problem/6450530> WebCore::FontPlatformData should not leak
+
+ Make sure we only adopt the new font, rather than re-referencing (and so leaking).
+
+ * platform/graphics/mac/FontPlatformDataMac.mm:
+ (WebCore::FontPlatformData::setFont):
+
+2009-01-01 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23071: REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)
+ https://bugs.webkit.org/show_bug.cgi?id=23071
+
+ Also fix some things that Dan suggested during review of the ICU search patch that I forgot
+ the first time around.
+
+ * editing/TextIterator.cpp: Use ICU search on all platforms that use ICU, now that
+ we've double checked it works everywhere, removing HAVE_ICU_SEARCH entirely.
+ Removed unused m_atBreak data member from the non-ICU code path.
+ (WebCore::TextIterator::TextIterator): Move null check up.
+ (WebCore::TextIterator::handleTextBox): Fix mistake that made the iterator include
+ collapsed whitespace. This was left over from an earlier version of the patch.
+ (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
+ Move null check up.
+
+2009-01-01 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler, Oliver Hunt
+
+ https://bugs.webkit.org/show_bug.cgi?id=23065
+
+ Enable incremental painting of canvas. This turns incremental painting
+ back on, and fixes issues with stroke width and miters, calling willDraw()
+ for strokeText and fillText, and taking shadows into account.
+
+ Test: fast/canvas/canvas-incremental-repaint.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasStrokeStyleApplier::CanvasStrokeStyleApplier):
+ (WebCore::CanvasStrokeStyleApplier::strokeStyle):
+ (WebCore::CanvasRenderingContext2D::stroke):
+ (WebCore::CanvasRenderingContext2D::willDraw):
+ (WebCore::CanvasRenderingContext2D::putImageData):
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ * html/CanvasRenderingContext2D.h:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::willDraw):
+ * platform/graphics/FloatRect.h:
+ (WebCore::mapRect): new method to map a rect contained
+ in one rect to an equivalent rect inside another rect.
+
+2008-12-29 Konstantin Käfer <kkaefer@gmail.com>
+
+ Reviewed by Tim Hatcher.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=17229
+ <rdar://problem/5732829> Inspector should show properties of all JS objects in Console
+
+ Prints objects not as plain text but makes them expandable so that
+ they can be inspected.
+
+ * inspector/front-end/Console.js:
+ (): added a parameter "inline" to the WebInspector.Console._format function which indicates
+ whether the object is printed in the context of another string (with console.log()) or
+ as sole element.
+ (.): objects and DOM nodes are now printed in an expandable form when they are printed alone
+ (i.e. not in the context of a console.log() string) so that they can be inspected.
+ * inspector/front-end/PropertiesSection.js:
+ (WebInspector.PropertiesSection.prototype.set title): Allow DOM Nodes as title instead of strings
+ in that case, the Node is inserted into the title instead of the string value of the passed
+ object. This is used for displaying linkified titles, for example when inspecting DOM nodes,
+ the syntax highlighted HTML representation is shown instead of the plain source code.
+ * inspector/front-end/inspector.css: correct the offsetParent for the expandable object inspector.
+
+2009-01-01 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences
+ https://bugs.webkit.org/show_bug.cgi?id=23051
+ rdar://problem/3574497
+
+ Test: editing/execCommand/findString-diacriticals.html
+
+ * editing/TextIterator.cpp: Changed the CircularSearchBuffer class to have a new
+ name, since it doesn't always use a circular buffer any more. Changed the interface
+ so it can work well in the new chunky comparison mode for ICU search, and also
+ added private data members for both the ICU-search and non-ICU-search code paths.
+ (WebCore::TextIterator::TextIterator): Use the versions of the Range functions
+ that don't take an exception code.
+ (WebCore::TextIterator::handleTextBox): Added a special case to handle the position
+ of a collapsed-away space better. This is not needed for search mechanism, but was
+ helpful in an earlier version of this patch, and is still an improvement.
+ (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Use the
+ versions of the Range functions that don't take an exception code.
+ (WebCore::CharacterIterator::range): Ditto.
+ (WebCore::characterSubrange): Added. Helper function used in both places below where
+ we want to convert a range and character offsets into a subrange.
+ (WebCore::WordAwareIterator::advance): Use the versions of the Range functions that
+ don't take an exception code.
+ (WebCore::createSearcher): Added.
+ (WebCore::searcher): Added.
+ (WebCore::lockSearcher): Added.
+ (WebCore::unlockSearcher): Added.
+ (WebCore::SearchBuffer::SearchBuffer): Added.
+ (WebCore::SearchBuffer::~SearchBuffer): Added.
+ (WebCore::SearchBuffer::append): Added.
+ (WebCore::SearchBuffer::atBreak): Added.
+ (WebCore::SearchBuffer::reachedBreak): Added.
+ (WebCore::SearchBuffer::search): Added.
+ (WebCore::SearchBuffer::length): Added.
+ (WebCore::TextIterator::subrange): Changed to call the characterSubrange
+ function above.
+ (WebCore::TextIterator::rangeFromLocationAndLength): Use the versions of the
+ Range functions that don't take an exception code. Also tweak some other details
+ of the code.
+ (WebCore::isAllCollapsibleWhitespace): Added.
+ (WebCore::collapsedToBoundary): Added.
+ (WebCore::findPlainText): Rewrote to use new interface and streamline the
+ logic a bit.
+
+ Add the relevant files in the icu directory. As icu/README says, the "icu"
+ directory is really just for Mac OS X, where we have the ICU library but not
+ the headers installed. It should be moved inside platform/mac at some point
+ to make this more clear (and the copy in JavaScriptCore should be moved
+ somewhere similar for the same reason).
+
+ * icu/unicode/ucoleitr.h: Added.
+ * icu/unicode/usearch.h: Added.
+
+2009-01-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ CrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS::JSGlobalObject::stopTimeoutCheck + 0
+ <rdar://problem/5821130>
+
+ This was caused by a plugin instance calling into JS code that removed the plugin
+ object. This fix is to cache the global object locally in a ProtectedPtr so we don't
+ need to rely on the continued existence of the plugin instance.
+
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Evaluate):
+ (_NPN_Construct):
+
+2008-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22964
+
+ MinGW build failure.
+
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::containsCharacters):
+
+2008-12-31 Alexander V. Butenko <alex@digiqube.com>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22750
+ [gtk] webkit up to r39121 crash on image urls like
+ http:///sitename.com
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::start):
+
+2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18310
+
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::determinePitch): Do not invoke
+ isFixedPitch() when the font is a custom font.
+
+2008-12-31 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ More work on Bug 3781: Animation via canvas could be faster
+ <https://bugs.webkit.org/show_bug.cgi?id=3781>
+
+ Make use of the fast path parsing of color strings that Color
+ uses. This improves performance of '#rgb', '#rrggbb', etc and
+ named (eg. 'green') colors.
+
+ Improves frame rate of test by around 40%
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+
+2008-12-30 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=23042
+
+ Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
+ when there is a reflection, compute the location of the rect inside
+ the reflection and take the union of the unreflected and reflected rects.
+
+ Test: fast/repaint/reflection-redraw.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::reflectedRect):
+ * rendering/RenderObject.h:
+
+2008-12-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ - fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
+
+ Test: fast/forms/placeholder-non-textfield.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Only call
+ updatePlaceholderVisibility() when the placeholder attribute changes if
+ the element is a text field.
+
+2008-12-30 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ First step of Bug 3781: Animation via canvas could be faster
+
+ Amortise the cost of calling repaint by coalescing repaint rects
+ while the canvas is drawn to. In a later step we'll stop calling
+ repaint() directly, and instead have all dirty canvases repaint
+ at the end of JS execution.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::willDraw):
+ (WebCore::HTMLCanvasElement::paint):
+ * html/HTMLCanvasElement.h:
+
+2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Antti Koivisto.
+
+ Bug 22931: Using the inspector with purgeable resources leads to assertion failures
+ <https://bugs.webkit.org/show_bug.cgi?id=22931>
+
+ Change InspectorResource::sourceString() so that it doesn't attempt to
+ unsafely get the data of a purgeable CachedResource.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorResource::sourceString): Attempt to make a purgeable
+ resource unpurgeable, and if this not possible, return an empty string.
+ * loader/CachedResource.h: Make InspectorResource a friend of CachedResource.
+
+2008-12-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23023
+ Remove incomplete support for opportunistic appcache entries
+
+ No change in behavior, thus no test.
+
+ * loader/appcache/ApplicationCacheResource.h:
+ (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema
+ version changes.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
+ * loader/appcache/ApplicationCacheResource.cpp:
+ (WebCore::ApplicationCacheResource::dumpType):
+
+2008-12-29 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Add arcTo support for Cairo. This is needed by Canvas.
+ Cairo has no native support for arcTo. We have to make our
+ own implementation.
+
+ [Canvas] Cairo needs arcTo
+ https://bugs.webkit.org/show_bug.cgi?id=23003
+
+ * platform/graphics/cairo/PathCairo.cpp:
+ (WebCore::Path::addArcTo):
+
+2008-12-29 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Bug 23030: Cannot setTransform with a non-invertible ctm
+
+ Removed a series of unnecessary and incorrect checks for an invertible
+ transform.
+
+ Test: fast/canvas/canvas-set-properties-with-non-invertible-ctm.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setStrokeStyle):
+ (WebCore::CanvasRenderingContext2D::setFillStyle):
+ These properties are not effected by the current CTM, so there
+ is no need to prevent them from being assigned.
+
+ (WebCore::CanvasRenderingContext2D::setTransform):
+ The whole point of tracking whether the current CTM was expected to be
+ non-invertible was to allow setTransform to be used when the CTM had become
+ non-invertible.
+
+ (WebCore::CanvasRenderingContext2D::beginPath):
+ (WebCore::CanvasRenderingContext2D::closePath):
+ beginPath and closePath change the state of the path, but not any of
+ its coordinates so there is no need prevent them from being called.
+
+2008-12-29 Josh Roesslein <jroesslein@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22968
+
+ Context menu rendering error when full page zoomed
+
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::handleContextMenuEvent):
+
+2008-12-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Add some basic memory statistic logging for Node.
+
+ * dom/Node.cpp:
+ (WebCore::Node::dumpStatistics):
+ (WebCore::Node::Node):
+ (WebCore::Node::~Node):
+ (WebCore::Node::setDocument):
+ * dom/Node.h:
+
+2008-12-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove one use of DeprecatedPtrList.
+
+ * css/CSSRuleList.cpp:
+ (WebCore::CSSRuleList::~CSSRuleList):
+ (WebCore::CSSRuleList::length):
+ (WebCore::CSSRuleList::item):
+ (WebCore::CSSRuleList::deleteRule):
+ (WebCore::CSSRuleList::append):
+ (WebCore::CSSRuleList::insertRule):
+ * css/CSSRuleList.h: Change m_lstCSSRules from using DeprecatedPtrList to a Vector.
+ I measured no performance change and was comforted by the fact that we use a Vector
+ for StyleList, which serves the exact same purpose.
+
+2008-12-29 Adele Peterson <adele@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21797
+ <rdar://problem/6310682> REGRESSION: Crash in CFHTTPCookieStorageCopy beneath WebCore::cookies() when
+ running fast/dom/document-attribute-js-null.html and http/tests/security/cookies/create-document.html
+
+ Return early if the document is trying to get or set a cookie with an empty cookie url.
+
+ * dom/Document.cpp:
+ (WebCore::Document::cookie):
+ (WebCore::Document::setCookie):
+
+2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Sam Weinig.
+
+ Bug 23016: JavaScriptDebugServer::recompileAllJSFunctions() should not execute JS while reparsing all functions
+ <https://bugs.webkit.org/show_bug.cgi?id=23016>
+ <rdar://problem/6425077>
+
+ JavaScriptDebugServer::recompileAllJSFunctions() calls sourceParsed() while
+ reparsing all JS functions, which will execute JS in the inspector. Depending
+ on the order in which functions are recompiled, a function could have a new
+ body but other functions that have not been recompiled could have an optimized
+ (in the sense of inline caching) call to it, bypassing the check of whether or
+ not there is generated bytecode. This leads to a crash caused by accessing
+ indices off of a null pointer.
+
+ To fix the problem, simply delay calling sourceParsed() until after all functions
+ have been reparsed. The crash isn't 100% reproducible, but on the one test case
+ I have, this makes it impossible to reproduce after a large number of attempts,
+ when it used to happen every few attempts.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+
+2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by Antti Koivisto.
+ Oops, remove some last minute ASSERTS that are obviously wrong.
+
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
+
+2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Antti Koivisto.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=23015
+
+ Don't rely on HTMLFormControlElement in RenderTextControl.
+
+ Introduce an abstract FormControlElement class, containing the
+ valueMatchesRenderer/setValueMatchesRenderer, the only HTMLFormControlElement
+ specific methods that RenderTextControl relies on.
+
+ This makes it possible for WML to reuse RenderTextControl.
+ RenderTextControlSingleLine still relies on HTMLInputElement,
+ this will change if WMLInputElement is introduced.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/FormControlElement.h: Added.
+ (WebCore::FormControlElement::~FormControlElement):
+ (WebCore::FormControlElement::FormControlElement):
+ * html/HTMLFormControlElement.h:
+ (WebCore::HTMLFormControlElement::valueMatchesRenderer):
+ (WebCore::HTMLFormControlElement::setValueMatchesRenderer):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::updateValue):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::adjustInnerTextStyle):
+ (WebCore::RenderTextControl::updateFromElement):
+ (WebCore::RenderTextControl::setInnerTextValue):
+ (WebCore::RenderTextControl::selectionChanged):
+ (WebCore::RenderTextControl::formControlElement):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlMultiLine.cpp:
+ (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
+ (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+
+2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Darin Adler.
+
+ Bug 23006: Many Loader::Host member functions are not safe to use reentrantly
+ <https://bugs.webkit.org/show_bug.cgi?id=23006>
+ <rdar://problem/6216106>
+
+ Many Loader::Host member functions set m_processingResource to true when they
+ begin processing a resource and set it to false when they are done. Thanks to
+ JavaScript and the web inspector, almost anything can happen during the
+ processing of a resource, including these functions being called reentrantly,
+ which is unsafe due to this way of using m_processingResource.
+
+ This can theoretically cause a Loader::Host to be used after it is freed,
+ because when Loader::servedPendingRequests() is called, it will free Hosts
+ that have m_processingResource set to false.
+
+ To fix this, we replace m_processingResource with m_numResourcesProcessing,
+ which is incremented and decremented using a helper object, ProcessingResource.
+
+ There are no occurrences of crashes caused by this bug that are reproducible
+ by multiple people, but this fixes the problem of m_processingResource being
+ set to false while a Host is still alive.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::Host):
+ (WebCore::Loader::Host::didFinishLoading): Change to use ProcessingResource
+ instead of manually setting m_processingResource.
+ (WebCore::Loader::Host::didFail): Ditto.
+ (WebCore::Loader::Host::didReceiveData): Ditto.
+ * loader/loader.h:
+ (WebCore::Loader::Host::ProcessingResource::ProcessingResource): Added.
+ (WebCore::Loader::Host::ProcessingResource::~ProcessingResource): Added.
+ (WebCore::Loader::Host::processingResource): Change to use m_numResourcesProcessing
+ instead of just getting m_processingResource.
+
+2008-12-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23007
+ REGRESSION: Timer-related crash when closing Web Inspector
+
+ Test: fast/dom/Window/remove-timeout-crash.html
+
+ * bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::fired): Besides deleting the timer, make
+ sure to remove it from a Document map.
+
+2008-12-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23012
+ Bring application cache manifest parsing up to date
+
+ Test: http/tests/appcache/manifest-parsing.html
+
+ * loader/appcache/ManifestParser.cpp:
+ (WebCore::Mode): Added a constant for unknown sections, which are ignored when parsing. This
+ is necessary for future extensions.
+ (WebCore::parseManifest): Parse unknown sections correctly. Ignore trailing tokens in
+ supported sections.
+
+2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22996
+
+ RenderTextControl heavily depends on HTMLInputElement & HTMLTextAreaElement.
+ It handles multi & single line text control rendering in one class. Split up
+ in two new classes: RenderTextControlSingleLine & RenderTextControlMultiLine.
+
+ This has several benefits - code is more readable now, the memory usage
+ for RenderTextControlMultiLine is reduced, as all stuff related to search fields
+ lives in RenderTextControlSingleLine, and it's easier to introduce an
+ abstraction for input/textarea-like elements for other HTML flavours like WML.
+
+ * GNUmakefile.am:
+ * WebCore.order:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::createRenderer):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ (WebCore::HTMLInputElement::updatePlaceholderVisibility):
+ (WebCore::HTMLInputElement::addSearchResult):
+ (WebCore::HTMLInputElement::onSearch):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::createRenderer):
+ (WebCore::HTMLTextAreaElement::defaultEventHandler):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::RenderTextControl):
+ (WebCore::RenderTextControl::~RenderTextControl):
+ (WebCore::RenderTextControl::styleDidChange):
+ (WebCore::RenderTextControl::adjustInnerTextStyle):
+ (WebCore::RenderTextControl::createSubtreeIfNeeded):
+ (WebCore::RenderTextControl::textBlockHeight):
+ (WebCore::RenderTextControl::textBlockWidth):
+ (WebCore::RenderTextControl::updateFromElement):
+ (WebCore::RenderTextControl::setInnerTextValue):
+ (WebCore::RenderTextControl::setSelectionRange):
+ (WebCore::RenderTextControl::visiblePositionForIndex):
+ (WebCore::RenderTextControl::indexForVisiblePosition):
+ (WebCore::RenderTextControl::subtreeHasChanged):
+ (WebCore::RenderTextControl::scrollbarThickness):
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::hitInnerTextBlock):
+ (WebCore::RenderTextControl::forwardEvent):
+ (WebCore::RenderTextControl::calcPrefWidths):
+ (WebCore::RenderTextControl::selectionChanged):
+ (WebCore::RenderTextControl::innerTextElement):
+ * rendering/RenderTextControl.h:
+ (WebCore::RenderTextControl::hasControlClip):
+ (WebCore::RenderTextControl::canHaveChildren):
+ (WebCore::RenderTextControl::avoidsFloats):
+ (WebCore::RenderTextControl::isEdited):
+ (WebCore::RenderTextControl::setEdited):
+ * rendering/RenderTextControlMultiLine.cpp: Added.
+ (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
+ (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
+ (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
+ (WebCore::RenderTextControlMultiLine::layout):
+ (WebCore::RenderTextControlMultiLine::nodeAtPoint):
+ (WebCore::RenderTextControlMultiLine::forwardEvent):
+ (WebCore::RenderTextControlMultiLine::preferredContentWidth):
+ (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
+ (WebCore::RenderTextControlMultiLine::baselinePosition):
+ (WebCore::RenderTextControlMultiLine::updateFromElement):
+ (WebCore::RenderTextControlMultiLine::cacheSelection):
+ (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
+ * rendering/RenderTextControlMultiLine.h: Added.
+ (WebCore::RenderTextControlMultiLine::isTextArea):
+ * rendering/RenderTextControlSingleLine.cpp: Added.
+ (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
+ (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
+ (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
+ (WebCore::RenderTextControlSingleLine::updatePlaceholderVisibility):
+ (WebCore::RenderTextControlSingleLine::addSearchResult):
+ (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
+ (WebCore::RenderTextControlSingleLine::showPopup):
+ (WebCore::RenderTextControlSingleLine::hidePopup):
+ (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
+ (WebCore::RenderTextControlSingleLine::paint):
+ (WebCore::RenderTextControlSingleLine::layout):
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ (WebCore::RenderTextControlSingleLine::styleDidChange):
+ (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
+ (WebCore::RenderTextControlSingleLine::textBlockWidth):
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+ (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
+ (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
+ (WebCore::RenderTextControlSingleLine::updateFromElement):
+ (WebCore::RenderTextControlSingleLine::cacheSelection):
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
+ (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
+ (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
+ (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
+ (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
+ (WebCore::RenderTextControlSingleLine::autosaveName):
+ (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
+ (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
+ (WebCore::RenderTextControlSingleLine::valueChanged):
+ (WebCore::RenderTextControlSingleLine::itemText):
+ (WebCore::RenderTextControlSingleLine::itemIsEnabled):
+ (WebCore::RenderTextControlSingleLine::itemStyle):
+ (WebCore::RenderTextControlSingleLine::menuStyle):
+ (WebCore::RenderTextControlSingleLine::clientInsetLeft):
+ (WebCore::RenderTextControlSingleLine::clientInsetRight):
+ (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
+ (WebCore::RenderTextControlSingleLine::clientPaddingRight):
+ (WebCore::RenderTextControlSingleLine::listSize):
+ (WebCore::RenderTextControlSingleLine::selectedIndex):
+ (WebCore::RenderTextControlSingleLine::itemIsSeparator):
+ (WebCore::RenderTextControlSingleLine::itemIsLabel):
+ (WebCore::RenderTextControlSingleLine::itemIsSelected):
+ (WebCore::RenderTextControlSingleLine::setTextFromItem):
+ (WebCore::RenderTextControlSingleLine::fontSelector):
+ (WebCore::RenderTextControlSingleLine::hostWindow):
+ (WebCore::RenderTextControlSingleLine::createScrollbar):
+ * rendering/RenderTextControlSingleLine.h: Added.
+ (WebCore::RenderTextControlSingleLine::hasControlClip):
+ (WebCore::RenderTextControlSingleLine::isTextField):
+ (WebCore::RenderTextControlSingleLine::placeholderIsVisible):
+ (WebCore::RenderTextControlSingleLine::popupIsVisible):
+ (WebCore::RenderTextControlSingleLine::shouldPopOver):
+ (WebCore::RenderTextControlSingleLine::valueShouldChangeOnHotTrack):
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
+ (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
+
+2008-12-28 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22755
+ Prepare to add create/remove timeout methods to JSWorkerContext by moving
+ timer-specific code from JSDOMWindowBase to DOMTimer.
+ Moved everything JS-related from DOMTimer to ScheduledAction.
+ Now ScheduledAction is what it wanted to be all the time: a JS engine-specific
+ container for timer callback that knows how to invoke it.
+ DOMTimer is not anymore JS-specific.
+
+ This is mostly moving the code around. No intended functional changes.
+
+ * bindings/js/DOMTimer.cpp:
+ (WebCore::DOMTimer::DOMTimer):
+ (WebCore::DOMTimer::~DOMTimer):
+ (WebCore::DOMTimer::install):
+ (WebCore::DOMTimer::removeById):
+ (WebCore::DOMTimer::fired):
+ (WebCore::DOMTimer::stop):
+ * bindings/js/DOMTimer.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::installTimeout):
+ (WebCore::JSDOMWindowBase::removeTimeout):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScheduledAction.h:
+ * dom/Document.cpp:
+ (WebCore::Document::addTimeout):
+
+2008-12-26 Zalan Bujtas <zbujtas@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22999
+ Check if database thread exists.
+
+ * storage/Database.cpp:
+ (WebCore::Database::openAndVerifyVersion):
+ (WebCore::Database::markAsDeletedAndClose):
+ (WebCore::Database::tableNames):
+
+2008-12-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=23001
+ A call to applicationCache.update() from a cached event listener should be ignored
+
+ Test: http/tests/appcache/idempotent-update.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Only reset m_status after
+ dispatching events.
+
+2008-12-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22997
+ ASSERTION FAILED: !m_resources.contains(url) in ApplicationCache::addResource()
+
+ Tests: http/tests/appcache/top-frame-1.html
+ http/tests/appcache/top-frame-2.html
+ http/tests/appcache/top-frame-3.html
+ http/tests/appcache/top-frame-4.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest):
+ Fixed one more instance of top level frame being used for caching purposes.
+
+2008-12-26 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22987
+ Fix for broken test editing/execCommand/5763082.html
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::mergeIdenticalElements): Used local RefPtr to hold onto
+ function parameter across multiple calls.
+
+2008-12-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22993
+ Application cache shouldn't be inherited by subframes
+
+ <rdar://problem/6284708> AppCache crashes in ApplicationCacheResource::addType()
+ This crash happened because main resource for subframe was looked up in top frame's
+ appcache. If not for the spec change, it could have been fixed by preventing the load
+ altogether.
+
+ Test: http/tests/appcache/foreign-iframe-main.html
+ I intend to write additional tests for the behavior change.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
+ * loader/DocumentLoader.h:
+ (WebCore::DocumentLoader::applicationCache):
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::load):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::associatedCache):
+ Removed DocumentLoader::topLevelApplicationCache(), and changed callers accordingly.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::selectCache):
+ (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
+ Removed checks for the frame being top-level one, now that subframes are cached independently.
+
+2008-12-25 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6465669> Frequent !isPurgeable() assertion in WebCore::CachedResource::addClient
+
+ Disallow turning resources that are being revalidated to purgable state.
+
+ No test, the condition is difficult to produce in DRT.
+
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::allClientsRemoved):
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::destroyDecodedData):
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::isSafeToMakePurgeable):
+ (WebCore::CachedResource::makePurgeable):
+ * loader/CachedResource.h:
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::destroyDecodedData):
+
+2008-12-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Qt build fix.
+
+ * WebCore.pro: Added ThreadGlobalData.cpp.
+
+2008-12-24 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * WebCore.base.exp: Remove a symbol from the export file now that it is no longer generated.
+
+2008-12-24 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed build fix to find addSubresourceURL
+
+ This is needed to compile on WebKit/Gtk+
+
+ * css/CSSFontFaceSrcValue.cpp:
+
+2008-12-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22980
+ WebCore uses more thread specific keys than it really needs
+
+ Consolidated ThreadSpecific data into a single ThreadGlobalData structure.
+
+ * GNUmakefile.am:
+ * WebCore.base.exp:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/EventNames.cpp:
+ * dom/EventNames.h:
+ (WebCore::eventNames):
+ * page/Frame.cpp:
+ (WebCore::Frame::Frame):
+ * platform/ThreadGlobalData.cpp: Added.
+ (WebCore::threadGlobalData):
+ (WebCore::ThreadGlobalData::ThreadGlobalData):
+ (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ * platform/ThreadGlobalData.h: Added.
+ (WebCore::ThreadGlobalData::eventNames):
+ (WebCore::ThreadGlobalData::emptyString):
+ (WebCore::ThreadGlobalData::atomicStringTable):
+ (WebCore::ThreadGlobalData::cachedConverterICU):
+ (WebCore::ThreadGlobalData::cachedConverterTEC):
+ * platform/text/AtomicString.cpp:
+ (WebCore::stringTable):
+ (WebCore::AtomicString::add):
+ (WebCore::AtomicString::remove):
+ (WebCore::AtomicString::find):
+ (WebCore::AtomicString::init):
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::empty):
+ * platform/text/StringImpl.h:
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::ICUConverterWrapper::~ICUConverterWrapper):
+ (WebCore::cachedConverterICU):
+ * platform/text/TextCodecICU.h:
+ (WebCore::ICUConverterWrapper::ICUConverterWrapper):
+ * platform/text/mac/TextCodecMac.cpp:
+ (WebCore::cachedConverterTEC):
+ * platform/text/mac/TextCodecMac.h:
+ (WebCore::TECConverterWrapper::TECConverterWrapper):
+ (WebCore::TECConverterWrapper::~TECConverterWrapper):
+
+2008-12-23 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * WebCore.xcodeproj/project.pbxproj: CSSPropertyNames.h is a generated file so it needs to be explicitly copied
+ into the PrivateHeaders directory, rather than relying on the automatic copying of headers which runs before the
+ derived sources are generated.
+
+2008-12-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22941
+
+ If the document element has opacity, we need to erase the view background to
+ white before painting.
+
+ Test: fast/backgrounds/opacity-on-document-element.html
+
+ * rendering/RenderView.cpp:
+ (WebCore::rendererObscuresBackground):
+
+2008-12-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=21910
+
+ Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
+ Otherwise the FrameView is left at 0x0, and nothing paints.
+
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::draw):
+
+2008-12-23 Darin Adler <darin@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - improve robustness of undo/redo in HTML editing to fix the following bugs
+ <https://bugs.webkit.org/show_bug.cgi?id=19703> Crash in WebCore::InsertNodeBeforeCommand::doUnapply()
+ <rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo
+
+ Major categories of improvements:
+
+ 1) Added null checks.
+ 2) Eliminated type casts without corresponding type checks.
+ 3) Avoided possible infinite loops by building up lists of nodes to operate on
+ before starting to make DOM changes.
+ 4) Use more RefPtr.
+
+ No test at this time, but test cases should follow in separate patches.
+
+ * WebCore.xcodeproj/project.pbxproj: Set the role of CSSPropertyNames.h to Private so it
+ can be used in other Private headers, specifically editing ones.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::locateCousinList): Adopt parentElement.
+ (WebCore::CSSStyleSelector::locateSharedStyle): Ditto.
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
+
+ * dom/Element.cpp: (WebCore::Element::cloneElement): Added.
+ * dom/Element.h: Added cloneElement and an implementation of parentElement.
+ * dom/Node.h: Moved parentElement from here to Element.h and changed its
+ implementation so it will return 0 when the parent is not an element
+ (document, document fragment, etc.).
+
+ * editing/AppendNodeCommand.cpp:
+ (WebCore::AppendNodeCommand::AppendNodeCommand): Made parent be an Element.
+ Moved assertions from doApply in here.
+ (WebCore::AppendNodeCommand::doApply): Simplified to just a single unchecked
+ appendChild call.
+ (WebCore::AppendNodeCommand::doUnapply): Simplified to just a single remove call.
+ * editing/AppendNodeCommand.h: Updated.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::createStyleSpanElement): Eliminate casting by creating an element in a more
+ direct way with new instead of createElementNS.
+ (WebCore::ApplyStyleCommand::ApplyStyleCommand): Use PassRefPtr.
+ (WebCore::ApplyStyleCommand::removeCSSStyle): Use CSSPropertyID.
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Use cloneElement.
+ * editing/ApplyStyleCommand.h:
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply): Use Element* and cloneElement.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::applyStyledElement): Use PassRefPtr and unsigned.
+ (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
+ (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
+ (WebCore::CompositeEditCommand::insertNodeAfter): Ditto.
+ (WebCore::CompositeEditCommand::insertNodeAt): Ditto.
+ (WebCore::CompositeEditCommand::appendNode): Ditto.
+ (WebCore::CompositeEditCommand::removeChildrenInRange): Ditto. Also use a vector to
+ make the list of children in case removing them has side effects.
+ (WebCore::CompositeEditCommand::removeNode): Ditto.
+ (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
+ (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Ditto.
+ (WebCore::CompositeEditCommand::splitTextNode): Ditto.
+ (WebCore::CompositeEditCommand::splitElement): Ditto.
+ (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
+ (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
+ (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
+ (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
+ (WebCore::CompositeEditCommand::inputText): Ditto.
+ (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
+ (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
+ (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
+ (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): Ditto.
+ (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
+ (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Implement by calling
+ setNodeAttribute instead of with its own SimpleEditCommand.
+ (WebCore::CompositeEditCommand::setNodeAttribute): Ditto.
+ (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
+ (WebCore::CompositeEditCommand::appendBlockPlaceholder): Ditto.
+ (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto.
+ (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto. Don't
+ bother using an undoable operation to put the break element into the paragraph
+ element because there's no need to split them and redo this when doing undo/redo.
+ (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
+ (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
+ * editing/CompositeEditCommand.h: Ditto.
+
+ * editing/DeleteFromTextNodeCommand.cpp:
+ (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Use unsigned.
+ (WebCore::DeleteFromTextNodeCommand::doApply): Eliminated inappropriate assertions.
+ (WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
+ * editing/DeleteFromTextNodeCommand.h:
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::removeNode): Use PassRefPtr.
+ (WebCore::DeleteSelectionCommand::deleteTextFromNode): Ditto.
+ * editing/DeleteSelectionCommand.h:
+
+ * editing/FormatBlockCommand.cpp:
+ (WebCore::FormatBlockCommand::FormatBlockCommand): Use AtomicString.
+ (WebCore::FormatBlockCommand::doApply): Use Element.
+ * editing/FormatBlockCommand.h:
+
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::createIndentBlockquoteElement): Use new to create the element
+ instead of calling a function so we have a more specific type.
+ (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
+ Use RefPtr and Element.
+ (WebCore::IndentOutdentCommand::indentRegion): Ditto.
+ (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
+ * editing/IndentOutdentCommand.h:
+
+ * editing/InsertIntoTextNodeCommand.cpp:
+ (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
+ Use unsigned. Added an assertion.
+ (WebCore::InsertIntoTextNodeCommand::doApply): Eliminated inappropriate assertions.
+ (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
+ * editing/InsertIntoTextNodeCommand.h:
+
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use Element.
+ (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
+
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::doApply): Use Element.
+
+ * editing/InsertNodeBeforeCommand.cpp:
+ (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Moved assertions
+ here from doApply.
+ (WebCore::InsertNodeBeforeCommand::doApply): Eliminated inappropriate assertions.
+ Added a null check.
+ (WebCore::InsertNodeBeforeCommand::doUnapply): Simplified to just a single remove call.
+
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply): Use Element and cloneElement.
+
+ * editing/JoinTextNodesCommand.cpp:
+ (WebCore::JoinTextNodesCommand::doApply): Eliminated inappropriate assertions.
+ Added some runtime checks. Don't store anything in m_offset.
+ (WebCore::JoinTextNodesCommand::doUnapply): Ditto.
+ * editing/JoinTextNodesCommand.h:
+
+ * editing/MergeIdenticalElementsCommand.cpp:
+ (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Moved
+ an assertion here from doApply.
+ (WebCore::MergeIdenticalElementsCommand::doApply): Eliminated inappropriate assertions.
+ Added a null check. Changed implementation to use remove to avoid null parent issue.
+ Use a vector of nodes to avoid possible infinite loop if mutation happens while iterating.
+ (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
+
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): Use Element*.
+ (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
+ * editing/ModifySelectionListLevel.h:
+
+ * editing/RemoveCSSPropertyCommand.cpp:
+ (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Use PassRefPtr and
+ CSSPropertyID. Also renamed m_decl to m_style.
+ (WebCore::RemoveCSSPropertyCommand::doApply): Eliminated inappropriate assertions.
+ (WebCore::RemoveCSSPropertyCommand::doUnapply): Ditto.
+
+ * editing/RemoveNodeAttributeCommand.cpp: Removed contents of this file. To be deleted.
+ Use SetNodeAttributeCommand instead.
+ * editing/RemoveNodeAttributeCommand.h: Ditto.
+
+ * editing/RemoveNodeCommand.cpp:
+ (WebCore::RemoveNodeCommand::RemoveNodeCommand): Moved assertions here from doApply.
+ Don't initialize m_refChild here; rather do it in doApply.
+ (WebCore::RemoveNodeCommand::doApply): Eliminated inappropriate assertions. Added
+ checks and streamlined implementation.
+ (WebCore::RemoveNodeCommand::doUnapply): Ditto.
+ * editing/RemoveNodeCommand.h:
+
+ * editing/RemoveNodePreservingChildrenCommand.cpp:
+ (WebCore::RemoveNodePreservingChildrenCommand::doApply): Use a vector.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::insertFragmentForTestRendering): Removed now-unneeded cast.
+
+ * editing/SetNodeAttributeCommand.cpp:
+ (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Use AtomicString.
+ Removed assertion that prevents us from using this to remove an attribute.
+ (WebCore::SetNodeAttributeCommand::doApply): Eliminated inappropriate assertions.
+ (WebCore::SetNodeAttributeCommand::doUnapply): Ditto.
+ * editing/SetNodeAttributeCommand.h:
+
+ * editing/SplitElementCommand.cpp:
+ (WebCore::SplitElementCommand::SplitElementCommand): Moved assertion here from doApply.
+ (WebCore::SplitElementCommand::doApply): Check some more invariants and use a vector
+ to avoid possible infinite loops.
+ (WebCore::SplitElementCommand::doUnapply): Ditto.
+
+ * editing/SplitTextNodeCommand.cpp:
+ (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Moved assertions and comment
+ here from doApply.
+ (WebCore::SplitTextNodeCommand::doApply): Check for null and failures when applying.
+ (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
+
+ * editing/SplitTextNodeContainingElementCommand.cpp:
+ (WebCore::SplitTextNodeContainingElementCommand::doApply): Use Element.
+
+ * editing/WrapContentsInDummySpanCommand.cpp:
+ (WebCore::WrapContentsInDummySpanCommand::doApply): Check for null and ignore failures.
+ Don't reuse the dummy span. Simplified logic.
+ (WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.
+
+ * editing/htmlediting.cpp:
+ (WebCore::isBlock): Make sure this returns true only for elements.
+ (WebCore::enclosingBlock): Return an Element*.
+ (WebCore::enclosingTableCell): Ditto.
+ (WebCore::enclosingList): Return an HTMLElement*.
+ (WebCore::outermostEnclosingList): Return an HTMLElement*.
+ (WebCore::createDefaultParagraphElement): Return an HTMLElement*.
+ (WebCore::createBreakElement): Return an HTMLElement*.
+ (WebCore::createOrderedListElement): Return an HTMLElement*.
+ (WebCore::createUnorderedListElement): Return an HTMLElement*.
+ (WebCore::createListItemElement): Return an HTMLElement*.
+ (WebCore::createHTMLElement): Return an HTMLElement*.
+ * editing/htmlediting.h:
+
+ * editing/markup.cpp:
+ (WebCore::createFragmentFromText): Use createBreakElement and use Element*.
+
+ * page/MouseEventWithHitTestResults.cpp:
+ (WebCore::MouseEventWithHitTestResults::targetNode): Use parentElement.
+
+2008-12-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ * dom/Node.h: Tweak comments and order of bits that Sam moved
+ here last night.
+ * dom/Node.cpp: Ditto.
+
+2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 11106: Some XMLHttpRequest URI resolving tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=11106
+
+ Use the ScriptExecutionContext to resolve the URI when calling open in JavaScript.
+ The previous code was using the containing DOMWindow to do so which would fail for
+ XMLHttpRequest object being passed between iframe.
+
+ Tests: http/tests/xmlhttprequest/uri-resolution-opera-open-004.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-005.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-006.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-007.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-008.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-009.html
+ http/tests/xmlhttprequest/uri-resolution-opera-open-010.html
+
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::open): Use the ScriptExecutionContext
+ to resolve the URL.
+
+ * dom/Document.cpp:
+ (WebCore::Document::virtualCompleteURL): Virtual method added to
+ avoid performance hit on completeURL call.
+
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+ (WebCore::ScriptExecutionContext::completeURL): Non-virtual method
+ that wrap the call to the virtual call.
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::virtualCompleteURL): Pure virtual method.
+ * dom/WorkerContext.h:
+
+2008-12-23 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22978
+ a couple tweaks to the new strokeBoundingRect functions
+
+ * platform/graphics/cairo/PathCairo.cpp:
+ (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
+ if the applier is non-null.
+
+ * platform/graphics/cg/PathCG.cpp:
+ (WebCore::putBytesNowhere): Added.
+ (WebCore::createScratchContext): Changed to use a "/dev/null" type
+ function to discard bytes rather than using a data object. This
+ eliminates the possibility that memory will be used if someone draws
+ into the scratch context by accident. Also moved to the top of the
+ file; it was in a slightly strange place before.
+ (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
+ if the applier is non-null. Simplify the empty path special case.
+
+2008-12-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Save a word in all Elements by moving the 5 loose bits to Node,
+ where we had 16 spare.
+
+ * dom/Element.cpp:
+ (WebCore::Element::Element):
+ * dom/Element.h:
+ * dom/Node.cpp:
+ (WebCore::Node::Node):
+ * dom/Node.h:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22972
+
+ Add WML <meta> element support. All needed functionality is present
+ in Document::processHttpEquiv, already covered by tests.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLMetaElement.cpp: Added.
+ (WebCore::WMLMetaElement::WMLMetaElement):
+ (WebCore::WMLMetaElement::parseMappedAttribute):
+ (WebCore::WMLMetaElement::insertedIntoDocument):
+ * wml/WMLMetaElement.h: Added.
+ * wml/WMLTagNames.in:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by Darin Adler.
+
+ Don't reference specific layout tests in comments.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::createFormData):
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22965
+
+ Add WML <head> element support. Doesn't require a WMLHeadElement.
+ No functional behaviour, as we already created a WMLElement for headTag, by default.
+ It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.
+
+ * wml/WMLTagNames.in:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
+
+ Fix regression caused by the HTMLFormElement refactorization.
+ File form elements without a name have to be included in multipart/form-data
+ submission. Cover this behaviour with a new test case.
+
+ Test: http/tests/misc/empty-file-formdata.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::createFormData):
+ * wml/WMLTagNames.in:
+
+2008-12-22 David Kilzer <ddkilzer@apple.com>
+
+ <rdar://problem/6438298> Bump schema version for app cache
+
+ Reviewed by Alexey Proskuryakov.
+
+ * loader/appcache/ApplicationCacheStorage.cpp: Increment
+ SchemaVersion from 2 to 3.
+
+2008-12-22 David Kilzer <ddkilzer@apple.com>
+
+ Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
+
+ Reviewed by Darin Adler.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced
+ use of ListHashSet with more efficient Deque.
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix obvious crash fix for WML enabled builds.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+
+2008-12-22 David Kilzer <ddkilzer@apple.com>
+
+ Bug 11850: Webarchive fails to save images referenced in CSS
+
+ <https://bugs.webkit.org/show_bug.cgi?id=11850>
+
+ Reviewed by Darin Adler.
+
+ This entry contains two parts since the tests for adding a
+ completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
+ on Bug 11850 being fixed (part 2).
+
+ --
+
+ Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html
+ http/tests/webarchive/test-css-url-encoding-utf-8.html
+ http/tests/webarchive/test-css-url-encoding.html
+
+ Added completeURL() methods to StyleSheet and CSSStyleSheet that
+ match the behavior of Document::completeURL(). Most notably,
+ CSSStyleSheet::completeURL() uses the charset of the stylesheet
+ (if it exists) to construct URLs, just like Document::completeURL().
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL().
+ (WebCore::CSSParser::parseContent): Ditto.
+ (WebCore::CSSParser::parseFillImage): Ditto.
+ (WebCore::CSSParser::parseFontFaceSrc): Ditto.
+ (WebCore::CSSParser::parseBorderImage): Ditto.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::completeURL): Added.
+ * css/CSSStyleSheet.h:
+ (WebCore::CSSStyleSheet::completeURL): Added declaration.
+
+ * css/StyleSheet.cpp:
+ (WebCore::StyleSheet::completeURL): Added.
+ * css/StyleSheet.h:
+ (WebCore::StyleSheet::completeURL): Added declaration.
+
+ * dom/Document.cpp:
+ (WebCore::Document::completeURL): Added comment referring to the new
+ completeURL() methods in StyleSheet and CSSStyleSheet.
+
+ --
+
+ Tests: webarchive/test-css-url-resources-in-stylesheets.html
+ webarchive/test-css-url-resources-inline-styles.html
+
+ Walk stylesheets and inline style attributes for url() references
+ when building a list of URLs to include in a webarchive. Note that
+ not all URLs found this way will be included in the webarchive if
+ they were not used (and thus not downloaded) when laying out the
+ page.
+
+ The key method for CSS stylesheets is
+ CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
+ CSSStyleSheet objects recursively referenced from its own stylesheet
+ through @import rules. Starting with the CSSRule objects in each
+ sheet and continuing down through the CSSMutableStyleDeclaration and
+ CSSValue objects, addSubresourceStyleURLs() methods are called to
+ gather URLs.
+
+ For inline style attributes in HTML DOM elements,
+ StyledElement::addSubresourceAttributeURLs() calls
+ CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
+ from each element, hence the need to call
+ addSubresourceAttributeURLs() on superclasses when the method is
+ implemented on the element class itself.
+
+ * css/CSSBorderImageValue.cpp:
+ (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
+ * css/CSSBorderImageValue.h:
+ (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSFontFaceRule.cpp:
+ (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
+ * css/CSSFontFaceRule.h:
+ (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSFontFaceSrcValue.cpp:
+ (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
+ * css/CSSFontFaceSrcValue.h:
+ (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSImportRule.cpp:
+ (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
+ * css/CSSImportRule.h:
+ (WebCore::CSSImportRule::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added.
+ Iterates over m_properties vector of CSSProperty objects calling
+ addSubresourceStyleURLs() on each property's CSSValue object.
+ * css/CSSMutableStyleDeclaration.h:
+ (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSReflectValue.cpp:
+ (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
+ * css/CSSReflectValue.h:
+ (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSRule.h:
+ (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual
+ method with empty implementation that's overridden by subclasses
+ as needed.
+
+ * css/CSSStyleRule.cpp:
+ (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
+ * css/CSSStyleRule.h:
+ (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to
+ call CSSRule::addSubresourceStyleURLs on each rule to extract
+ URLs. Removed unneeded baseURL parameter now that the
+ completeURL() method exists.
+ * css/CSSStyleSheet.h:
+ (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated
+ declaration.
+
+ * css/CSSValue.h:
+ (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual
+ method with empty implementation that's overridden by subclasses
+ as needed.
+
+ * css/CSSValueList.cpp:
+ (WebCore::CSSValueList::addSubresourceStyleURLs): Added.
+ Iterates over m_values vector of CSSValue objects calling
+ addSubresourceStyleURLs() on each.
+ * css/CSSValueList.h:
+ (WebCore::CSSValueList::addSubresourceStyleURLs): Added
+ declaration.
+
+ * css/StyleSheet.h:
+ (WebCore::StyleSheet::addSubresourceStyleURLs): Updated
+ declaration to remove unneeded baseURL parameter.
+
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
+ Fixed to use the StyleBase::baseURL() method to get the
+ stylesheet's URL instead of calling Document::completeURL().
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::addSubresourceAttributeURLs): Added method
+ to extract URLs from inline style declarations.
+ * dom/StyledElement.h:
+ (WebCore::StyledElement::addSubresourceAttributeURLs): Added
+ declaration.
+
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call
+ addSubresourceAttributeURLs() in superclass to extract URLs
+ from inline style declarations.
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLParamElement.cpp:
+ (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLTableCellElement.cpp:
+ (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGCursorElement.cpp:
+ (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
+
+2008-12-22 Dhananjoy Chutia <dhanrd@gmail.com>
+
+ Reviewed by David Kilzer.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22959
+ Memory leak fixes for WebKit+soup
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::finishedCallback):
+
+2008-12-22 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available
+
+ Tests: http/tests/appcache/404-manifest.html
+ http/tests/appcache/fail-on-update.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading):
+ Removed the incorrect assertion.
+
+ * loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive
+ m_currentHandle handling.
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov & George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22961
+
+ Add WML <fieldset> element support.
+ Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
+ to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
+ element. To integrate within the existing RenderFieldset code, we just create an
+ internal <insertedLegend> element as first child for a WML <fieldset> element, containing
+ the title attribute value.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * css/wml.css:
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::RenderFieldset):
+ (WebCore::RenderFieldset::findLegend):
+ * rendering/RenderFieldset.h:
+ * rendering/RenderLegend.cpp:
+ (WebCore::RenderLegend::RenderLegend):
+ * rendering/RenderLegend.h:
+ * wml/WMLFieldSetElement.cpp: Added.
+ (WebCore::WMLFieldSetElement::WMLFieldSetElement):
+ (WebCore::WMLFieldSetElement::~WMLFieldSetElement):
+ (WebCore::WMLFieldSetElement::parseMappedAttribute):
+ (WebCore::WMLFieldSetElement::insertedIntoDocument):
+ (WebCore::WMLFieldSetElement::removedFromDocument):
+ (WebCore::WMLFieldSetElement::createRenderer):
+ * wml/WMLFieldSetElement.h: Added.
+ * wml/WMLInsertedLegendElement.cpp: Added.
+ (WebCore::WMLInsertedLegendElement::WMLInsertedLegendElement):
+ (WebCore::WMLInsertedLegendElement::~WMLInsertedLegendElement):
+ (WebCore::WMLInsertedLegendElement::createRenderer):
+ * wml/WMLInsertedLegendElement.h: Added.
+ * wml/WMLTagNames.in:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by George Staikos.
+
+ Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
+
+ * css/CSSStyleSelector.cpp:
+ * css/wml.css:
+ * dom/DOMImplementation.cpp:
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizerLibxml2.cpp:
+ * dom/XMLTokenizerQt.cpp:
+ * history/BackForwardList.cpp:
+ * history/BackForwardList.h:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+ * loader/MainResourceLoader.cpp:
+ * page/Page.cpp:
+ * page/Page.h:
+ * platform/MIMETypeRegistry.cpp:
+ * platform/network/FormDataBuilder.cpp:
+ * platform/network/FormDataBuilder.h:
+ * platform/qt/MIMETypeRegistryQt.cpp:
+ * wml/WMLAElement.cpp:
+ * wml/WMLAElement.h:
+ * wml/WMLAccessElement.cpp:
+ * wml/WMLAccessElement.h:
+ * wml/WMLAnchorElement.cpp:
+ * wml/WMLAnchorElement.h:
+ * wml/WMLBRElement.cpp:
+ * wml/WMLBRElement.h:
+ * wml/WMLCardElement.cpp:
+ * wml/WMLCardElement.h:
+ * wml/WMLDoElement.cpp:
+ * wml/WMLDoElement.h:
+ * wml/WMLDocument.cpp:
+ * wml/WMLDocument.h:
+ * wml/WMLElement.cpp:
+ * wml/WMLElement.h:
+ * wml/WMLErrorHandling.cpp:
+ * wml/WMLErrorHandling.h:
+ * wml/WMLEventHandlingElement.cpp:
+ * wml/WMLEventHandlingElement.h:
+ * wml/WMLGoElement.cpp:
+ * wml/WMLGoElement.h:
+ * wml/WMLImageElement.cpp:
+ * wml/WMLImageElement.h:
+ * wml/WMLImageLoader.cpp:
+ * wml/WMLImageLoader.h:
+ * wml/WMLIntrinsicEvent.cpp:
+ * wml/WMLIntrinsicEvent.h:
+ * wml/WMLIntrinsicEventHandler.cpp:
+ * wml/WMLIntrinsicEventHandler.h:
+ * wml/WMLNoopElement.cpp:
+ * wml/WMLNoopElement.h:
+ * wml/WMLOnEventElement.cpp:
+ * wml/WMLOnEventElement.h:
+ * wml/WMLPElement.cpp:
+ * wml/WMLPElement.h:
+ * wml/WMLPageState.cpp:
+ * wml/WMLPageState.h:
+ * wml/WMLPostfieldElement.cpp:
+ * wml/WMLPostfieldElement.h:
+ * wml/WMLPrevElement.cpp:
+ * wml/WMLPrevElement.h:
+ * wml/WMLRefreshElement.cpp:
+ * wml/WMLRefreshElement.h:
+ * wml/WMLSetvarElement.cpp:
+ * wml/WMLSetvarElement.h:
+ * wml/WMLTableElement.cpp:
+ * wml/WMLTableElement.h:
+ * wml/WMLTaskElement.cpp:
+ * wml/WMLTaskElement.h:
+ * wml/WMLTemplateElement.cpp:
+ * wml/WMLTemplateElement.h:
+ * wml/WMLTimerElement.cpp:
+ * wml/WMLTimerElement.h:
+ * wml/WMLVariables.cpp:
+ * wml/WMLVariables.h:
+
+2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22638
+
+ Add POST method support to WMLGoElement. GET & POST over HTTP
+ covered by a new set of WML HTTP layout tests.
+
+ Tests: http/tests/wml/go-task-get-method-accept-charset.html
+ http/tests/wml/go-task-get-method.html
+ http/tests/wml/go-task-post-method-accept-charset.html
+ http/tests/wml/go-task-post-method.html
+
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::WMLGoElement):
+ (WebCore::WMLGoElement::registerPostfieldElement):
+ (WebCore::WMLGoElement::parseMappedAttribute):
+ (WebCore::WMLGoElement::executeTask):
+ (WebCore::WMLGoElement::preparePOSTRequest):
+ (WebCore::WMLGoElement::prepareGETRequest):
+ (WebCore::WMLGoElement::createFormData):
+ * wml/WMLGoElement.h:
+ * wml/WMLPostfieldElement.cpp:
+ (WebCore::encodedString):
+ (WebCore::WMLPostfieldElement::encodeData):
+ * wml/WMLPostfieldElement.h:
+
+2008-12-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler and George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22949
+
+ Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
+ Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
+ It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
+ submission, including boundary string generation, multi-part form handling etc.
+
+ No functional changes, no test cases affected.
+ WMLGoElement will be converted in a follow-up patch.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::HTMLFormElement):
+ (WebCore::HTMLFormElement::dataEncoding):
+ (WebCore::HTMLFormElement::createFormData):
+ (WebCore::HTMLFormElement::submit):
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFormElement.h:
+ (WebCore::HTMLFormElement::enctype):
+ (WebCore::HTMLFormElement::encoding):
+ (WebCore::HTMLFormElement::setEncoding):
+ (WebCore::HTMLFormElement::acceptCharset):
+ * platform/network/FormDataBuilder.cpp: Added.
+ (WebCore::FormDataBuilder::FormDataBuilder):
+ (WebCore::FormDataBuilder::~FormDataBuilder):
+ (WebCore::FormDataBuilder::parseEncodingType):
+ (WebCore::FormDataBuilder::parseMethodType):
+ (WebCore::FormDataBuilder::dataEncoding):
+ (WebCore::appendString):
+ (WebCore::FormDataBuilder::beginMultiPartHeader):
+ (WebCore::FormDataBuilder::addBoundaryToMultiPartHeader):
+ (WebCore::FormDataBuilder::addFileNameToMultiPartHeader):
+ (WebCore::FormDataBuilder::addContentTypeToMultiPartHeader):
+ (WebCore::FormDataBuilder::finishMultiPartHeader):
+ (WebCore::FormDataBuilder::clear):
+ (WebCore::FormDataBuilder::addKeyValuePairAsFormData):
+ (WebCore::FormDataBuilder::encodeStringAsFormData):
+ (WebCore::FormDataBuilder::generateUniqueBoundaryString):
+ * platform/network/FormDataBuilder.h: Added.
+ (WebCore::FormDataBuilder::isPostMethod):
+ (WebCore::FormDataBuilder::setIsPostMethod):
+ (WebCore::FormDataBuilder::isMultiPartForm):
+ (WebCore::FormDataBuilder::setIsMultiPartForm):
+ (WebCore::FormDataBuilder::encodingType):
+ (WebCore::FormDataBuilder::setEncodingType):
+ (WebCore::FormDataBuilder::acceptCharset):
+ (WebCore::FormDataBuilder::setAcceptCharset):
+ (WebCore::FormDataBuilder::encodedData):
+ (WebCore::FormDataBuilder::multiPartData):
+
+2008-12-21 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Darin Adler, Nikolas Zimmermann.
+
+ Move the the platform dependent strokeBBox functionality out of RenderPath
+ into Path with strokeBoundingRect.
+
+ RenderPath clean-up for strokeBoundingBox
+ [https://bugs.webkit.org/show_bug.cgi?id=22902]
+
+ * GNUmakefile.am:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/Path.h:
+ * platform/graphics/StrokeStyleApplier.h: Added.
+ (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
+ * platform/graphics/cairo/PathCairo.cpp:
+ (WebCore::Path::strokeBoundingRect):
+ * platform/graphics/cg/PathCG.cpp:
+ (WebCore::createScratchContext):
+ (WebCore::scratchContext):
+ (WebCore::Path::strokeBoundingRect):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::pen):
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::Path::strokeBoundingRect):
+ * rendering/RenderPath.cpp:
+ (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier):
+ (WebCore::StrokeBoundingRectStyleApplier::strokeStyle):
+ (WebCore::RenderPath::relativeBBox):
+ * rendering/RenderPath.h:
+ * svg/graphics/cairo/RenderPathCairo.cpp:
+ * svg/graphics/cg/RenderPathCg.cpp:
+ * svg/graphics/qt/RenderPathQt.cpp:
+
+2008-12-20 David Kilzer <ddkilzer@apple.com>
+
+ Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"
+
+ * html/PreloadScanner.cpp:
+ (WebCore::PreloadScanner::tokenizeCSS):
+ * html/PreloadScanner.h:
+ (WebCore::PreloadScanner::CSSState):
+
+2008-12-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ <rdar://problem/6454076> Random crashes on JS raytracer
+
+ No test, because the crash is not readily reproducible.
+
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::empty):
+ * platform/text/StringImpl.h:
+ Made empty string per-thread.
+
+2008-12-19 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Replace some uses of HardRetain etc with RetainPtr.
+
+ * platform/mac/DragImageMac.mm:
+ * platform/mac/SharedBufferMac.mm:
+ (WebCore::SharedBuffer::createCFData):
+ * rendering/RenderThemeMac.mm:
+ * svg/graphics/cg/SVGResourceFilterCg.mm:
+ (WebCore::SVGResourceFilter::prepareFilter):
+ (WebCore::SVGResourceFilter::applyFilter):
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
+ * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
+ (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
+
+2008-12-19 miggilin <mr.diggilin@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Add Context Menu support to wx bindings.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22675
+
+ * platform/ContextMenu.h:
+ * platform/ContextMenuItem.h:
+ (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
+ * platform/wx/ContextMenuItemWx.cpp: Added.
+ * platform/wx/ContextMenuWx.cpp: Added.
+ * platform/wx/LocalizedStringsWx.cpp:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * webcore-wx.bkl:
+
+
+2008-12-19 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
+ crash occurs at
+ AccessibilityTable::isTableExposableThroughAccessibility() when
+ attempting to create a link in a rich text message
+
+ We need to disable Accessibility Tables until we get this fixed for
+ real to prevent rampant crashing.
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::AccessibilityTable):
+
+2008-12-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=22938
+
+ When the document element is transformed, we need to paint
+ the view background to avoid unpainted areas.
+
+ Test: fast/transforms/transformed-document-element.html
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::paintBoxDecorations):
+
+2008-12-19 Steve Falkenburg <sfalken@apple.com>
+
+ Fix build.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-12-19 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after recent changes.
+
+ * WebCoreSources.bkl:
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::clear):
+ * webcore-base.bkl:
+
+2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Sam Weinig.
+
+ [GTK] Fix make distcheck again
+
+ These files were moved to WebCore/platform/animation
+ and WebCore/platform/graphics/transforms.
+
+ * GNUmakefile.am:
+
+2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22900
+
+ Fix AtomicString usage, so that building works.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+
+2008-12-19 Adam Roben <aroben@apple.com>
+
+ Windows build fix on older versions of CFNetwork after r39393
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::highestSupportedCFURLConnectionClientVersion): Changed
+ preprocessor directives not to leave in unreachable code on old
+ versions of CFNetwork.
+
+2008-12-19 Antti Koivisto <antti@apple.com>
+
+ Comment fix.
+
+ * platform/PurgeableBuffer.h:
+
+2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ [GTK] Build fix by adding the new files.
+
+ * GNUmakefile.am:
+
+2008-12-19 Jade Han <jade.han@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] Allow conversion of JavaScript Number and Boolean types to Qt types
+
+ https://bugs.webkit.org/show_bug.cgi?id=22880
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+
+2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Holger Freyther.
+
+ Implement ImageDecoder::filenameExtension() for Qt
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::filenameExtension):
+ * platform/graphics/qt/ImageDecoderQt.h:
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::filenameExtension):
+
+2008-12-19 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Alder.
+
+ Implement ImageSource::filenameExtension for Cario
+ https://bugs.webkit.org/show_bug.cgi?id=22905
+
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::filenameExtension):
+ * platform/image-decoders/ImageDecoder.h:
+ * platform/image-decoders/bmp/BMPImageDecoder.h:
+ (WebCore::BMPImageDecoder::filenameExtension):
+ * platform/image-decoders/gif/GIFImageDecoder.h:
+ (WebCore::GIFImageDecoder::filenameExtension):
+ * platform/image-decoders/ico/ICOImageDecoder.h:
+ (WebCore::ICOImageDecoder::filenameExtension):
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h:
+ (WebCore::JPEGImageDecoder::filenameExtension):
+ * platform/image-decoders/png/PNGImageDecoder.h:
+ (WebCore::PNGImageDecoder::filenameExtension):
+ * platform/image-decoders/xbm/XBMImageDecoder.h:
+ (WebCore::XBMImageDecoder::filenameExtension):
+
+2008-12-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - avoid using the ResourceHandle-level credential storage, if any,
+ unless the client opts to use it; when use of the credential
+ storage is disallowed, all authentication challenges are sent to
+ the client.
+ - let the FrameLoaderClient decide whether to use the credential
+ storage.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::shouldUseCredentialStorage): Added.
+ Returns false.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::shouldUseCredentialStorage): Added. Calls through
+ to the FrameLoaderClient.
+ * loader/FrameLoader.h: Declared shouldUseCredentialStorage().
+ * loader/FrameLoaderClient.h: Declared shouldUseCredentialStorage().
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::shouldUseCredentialStorage): Added. Calls
+ through to the FrameLoader.
+ * loader/ResourceLoader.h:
+ (WebCore::ResourceLoader::shouldUseCredentialStorage): Implemented this
+ ResourceHandleClient method.
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::shouldUseCredentialStorage): Added.
+ Overrides the ResourceLoader implementation by letting the client
+ supply the return value. If the client does not do this, continues
+ with the ResourceLoader behavior of asking the FrameLoader.
+ * loader/SubresourceLoader.h: Removed an unused #include and declared
+ shouldUseCredentialStorage().
+ * loader/SubresourceLoaderClient.h:
+ (WebCore::SubresourceLoaderClient::getShouldUseCredentialStorage):
+ Added a default implementation which returns false, meaning the client
+ does not wish to decide whether the credential storage should be used.
+ * platform/network/ResourceHandle.h: Removed unused forward declarations.
+ Declared a new member function, shouldUseCredentialStorage(), on Mac and
+ CFNetwork-using builds.
+ * platform/network/ResourceHandleClient.h:
+ (WebCore::ResourceHandleClient::shouldUseCredentialStorage): Added this
+ default implementation that returns false.
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::findCFNetworkModule): Added. Returns a handle to the CFNetwork
+ module.
+ (WebCore::cfNetworkVersion): Added. Returns the high word of the
+ CFNetwork library's product version.
+ (WebCore::highestSupportedCFURLConnectionClientVersion): Added. Returns
+ the highest version of the CFURLConnectionClient structure supported by
+ the CFNetwork library. The only reason to check this at runtime is
+ that WebKit may be linking at runtime against an older version of
+ CFNetwork than the one it was built with, as is the case with nightly
+ builds.
+ (WebCore::shouldUseCredentialStorageCallback): Added this
+ CFURLConnection callback which calls through to
+ ResourceHandle::shouldUseCredentialStorage().
+ (WebCore::ResourceHandle::start): Pass a version 3 CFURLConnectionClient
+ including the shouldUseCredentialStorage callback. At runtime, clamp the
+ client structure version down to the highest supported by CFNetwork.
+ (WebCore::ResourceHandle::shouldUseCredentialStorage): Added. Calls through
+ to the client if there is one. Otherwise returns false.
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::shouldUseCredentialStorage): Ditto.
+ (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
+ Added this delegate method which callls through to
+ ResourceHandle::shouldUseCredentialStorage().
+
+2008-12-18 David Kilzer <ddkilzer@apple.com>
+
+ Reset role to "Private" on 6 header files to fix clean builds after r39378
+
+ Reviewed by BUILD FIX.
+
+ * WebCore.xcodeproj/project.pbxproj: Added back "Private" role
+ that was lost on 6 headers when they were "moved":
+ AffineTransform.h, Animation.h, AnimationList.h,
+ TimingFunction.h, TransformOperation.h and
+ TransformOperations.h.
+
+2008-12-18 Pamela Greene <pam@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Add initializer for m_textDirectionSubmenuInclusionBehavior.
+ https://bugs.webkit.org/show_bug.cgi?id=22926
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize m_textDirectionSubmenuInclusionBehavior
+
+2008-12-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by John Sullivan.
+
+ Add new FrameLoaderClient method to indicate the first visually
+ non-empty layout based on an heuristic. Right now that heuristic
+ is the first layout after an image, text or plugin has been added
+ to the render tree, but I can imagine it becoming much smarter.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::didFirstVisuallyNonEmptyLayout):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameViewPrivate::reset):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::performPostLayoutTasks):
+ (WebCore::FrameView::setIsVisuallyNonEmpty):
+ * page/FrameView.h:
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::RenderImage):
+ * rendering/RenderPartObject.cpp:
+ (WebCore::RenderPartObject::RenderPartObject):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+
+2008-12-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6449841> reduce memory use of ResourceResponseBase by removing two maps
+
+ We were parsing the cache-control and pragma header field values into maps.
+ I changed that so instead we only cache two bits with the data we were actually
+ using. Later we might want to move this responsibility out of this class entirely;
+ we can cache it at the higher level instead.
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::mustRevalidate): Changed to call a specific API to get at
+ the bits in quest instead of a general "cache control directives" API.
+
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::setHTTPHeaderField): Remove the logic for the
+ pragma header field since no one is using this for now.
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives): Eliminated the return
+ value and made this function have side effects only. Changed it so it's the caller's
+ responsibility to check m_haveParsedCacheControl. Set m_cacheControlContainsNoCache
+ and m_cacheControlContainsMustRevalidate rather than keeping a map around.
+
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Added.
+ (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate): Added.
+ (WebCore::ResourceResponseBase::ResourceResponseBase): Updated since I removed
+ m_haveParsedCacheControl and renamed m_haveParsedCacheControlHeader to remove
+ the imprecise use of the term "header".
+
+2008-12-18 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+ Delete 2nd copy of code in these files.
+
+ * platform/animation/Animation.cpp:
+ * platform/animation/Animation.h:
+ * platform/animation/AnimationList.cpp:
+ * platform/animation/AnimationList.h:
+ * platform/animation/TimingFunction.h:
+ * platform/graphics/transforms/AffineTransform.cpp:
+ * platform/graphics/transforms/AffineTransform.h:
+ * platform/graphics/transforms/IdentityTransformOperation.h:
+ * platform/graphics/transforms/MatrixTransformOperation.cpp:
+ * platform/graphics/transforms/MatrixTransformOperation.h:
+ * platform/graphics/transforms/RotateTransformOperation.cpp:
+ * platform/graphics/transforms/RotateTransformOperation.h:
+ * platform/graphics/transforms/ScaleTransformOperation.cpp:
+ * platform/graphics/transforms/ScaleTransformOperation.h:
+ * platform/graphics/transforms/SkewTransformOperation.cpp:
+ * platform/graphics/transforms/SkewTransformOperation.h:
+ * platform/graphics/transforms/TransformOperation.h:
+ * platform/graphics/transforms/TransformOperations.cpp:
+ * platform/graphics/transforms/TransformOperations.h:
+ * platform/graphics/transforms/TranslateTransformOperation.cpp:
+ * platform/graphics/transforms/TranslateTransformOperation.h:
+
+2008-12-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22859
+ Abstract away the use of JSDOMWindow in CachedPage and introduce
+ ScriptCachedPageData abstraction.
+
+ * GNUmakefile.am: Added ScriptCachedPageData to project.
+ * WebCore.pro: Added ScriptCachedPageData to project.
+ * WebCore.vcproj/WebCore.vcproj: Added ScriptCachedPageData to project.
+ * WebCore.xcodeproj/project.pbxproj: Added ScriptCachedPageData to
+ project.
+ * bindings/js/ScriptCachedPageData.cpp: Added.
+ (WebCore::ScriptCachedPageData::ScriptCachedPageData):
+ (WebCore::ScriptCachedPageData::~ScriptCachedPageData):
+ (WebCore::ScriptCachedPageData::restore):
+ (WebCore::ScriptCachedPageData::clear):
+ * bindings/js/ScriptCachedPageData.h: Added.
+ * history/CachedPage.cpp: Replaced JSDOMWindow and ProtectedPtr with
+ ScriptCachedPageData.
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::domWindow):
+ (WebCore::CachedPage::restore):
+ (WebCore::CachedPage::clear):
+ * history/CachedPage.h: Replaced JSDOMWindow and ProtectedPtr with
+ ScriptCachedPageData.
+
+2008-12-18 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22888
+
+ To avoid future dependency issues, all the TransformOperations and Animation related files need to be moved to platform
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/animation: Added.
+ * platform/animation/Animation.cpp: Copied from WebCore/rendering/style/Animation.cpp.
+ * platform/animation/Animation.h: Copied from WebCore/rendering/style/Animation.h.
+ * platform/animation/AnimationList.cpp: Copied from WebCore/rendering/style/AnimationList.cpp.
+ * platform/animation/AnimationList.h: Copied from WebCore/rendering/style/AnimationList.h.
+ * platform/animation/TimingFunction.h: Copied from WebCore/rendering/style/TimingFunction.h.
+ * platform/graphics/AffineTransform.cpp: Removed.
+ * platform/graphics/AffineTransform.h: Removed.
+ * platform/graphics/transforms: Added.
+ * platform/graphics/transforms/AffineTransform.cpp: Copied from WebCore/platform/graphics/AffineTransform.cpp.
+ * platform/graphics/transforms/AffineTransform.h: Copied from WebCore/platform/graphics/AffineTransform.h.
+ * platform/graphics/transforms/IdentityTransformOperation.h: Copied from WebCore/rendering/style/IdentityTransformOperation.h.
+ * platform/graphics/transforms/MatrixTransformOperation.cpp: Copied from WebCore/rendering/style/MatrixTransformOperation.cpp.
+ * platform/graphics/transforms/MatrixTransformOperation.h: Copied from WebCore/rendering/style/MatrixTransformOperation.h.
+ * platform/graphics/transforms/RotateTransformOperation.cpp: Copied from WebCore/rendering/style/RotateTransformOperation.cpp.
+ * platform/graphics/transforms/RotateTransformOperation.h: Copied from WebCore/rendering/style/RotateTransformOperation.h.
+ * platform/graphics/transforms/ScaleTransformOperation.cpp: Copied from WebCore/rendering/style/ScaleTransformOperation.cpp.
+ * platform/graphics/transforms/ScaleTransformOperation.h: Copied from WebCore/rendering/style/ScaleTransformOperation.h.
+ * platform/graphics/transforms/SkewTransformOperation.cpp: Copied from WebCore/rendering/style/SkewTransformOperation.cpp.
+ * platform/graphics/transforms/SkewTransformOperation.h: Copied from WebCore/rendering/style/SkewTransformOperation.h.
+ * platform/graphics/transforms/TransformOperation.h: Copied from WebCore/rendering/style/TransformOperation.h.
+ * platform/graphics/transforms/TransformOperations.cpp: Copied from WebCore/rendering/style/TransformOperations.cpp.
+ * platform/graphics/transforms/TransformOperations.h: Copied from WebCore/rendering/style/TransformOperations.h.
+ * platform/graphics/transforms/TranslateTransformOperation.cpp: Copied from WebCore/rendering/style/TranslateTransformOperation.cpp.
+ * platform/graphics/transforms/TranslateTransformOperation.h: Copied from WebCore/rendering/style/TranslateTransformOperation.h.
+ * rendering/style/Animation.cpp: Removed.
+ * rendering/style/Animation.h: Removed.
+ * rendering/style/AnimationList.cpp: Removed.
+ * rendering/style/AnimationList.h: Removed.
+ * rendering/style/IdentityTransformOperation.h: Removed.
+ * rendering/style/MatrixTransformOperation.cpp: Removed.
+ * rendering/style/MatrixTransformOperation.h: Removed.
+ * rendering/style/RotateTransformOperation.cpp: Removed.
+ * rendering/style/RotateTransformOperation.h: Removed.
+ * rendering/style/ScaleTransformOperation.cpp: Removed.
+ * rendering/style/ScaleTransformOperation.h: Removed.
+ * rendering/style/SkewTransformOperation.cpp: Removed.
+ * rendering/style/SkewTransformOperation.h: Removed.
+ * rendering/style/TimingFunction.h: Removed.
+ * rendering/style/TransformOperation.h: Removed.
+ * rendering/style/TransformOperations.cpp: Removed.
+ * rendering/style/TransformOperations.h: Removed.
+ * rendering/style/TranslateTransformOperation.cpp: Removed.
+ * rendering/style/TranslateTransformOperation.h: Removed.
+
+2008-12-18 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
+ <https://bugs.webkit.org/show_bug.cgi?id=21855>
+ <rdar://problem/6278244>
+
+ If JavaScript is not currently executing, the handleEvent member function
+ of JSAbstractEventListener should set the dynamic global object to the
+ global object of the context in which the event occurred.
+
+ If this is not set, then JavaScriptCore will simply take the global object
+ of the context where the event handler function was created, which may be
+ a different frame. This will cause the popup blocker to incorrectly block
+ windows opened from onclick events inside of an iframe whose handler was
+ created in the outer frame, as it will check the outer frame and see that
+ it is not processing any events.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+
+2008-12-17 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=22570
+
+ Add the ability to compute clip rects independently from
+ caching them on the RenderLayer. When painting reflections, use
+ such temporarily computed clipRects, otherwise the layer may cache
+ clipRects which are invalid, since they have been computed with
+ a rootLayer that is not the one usually used to paint.
+
+ Test: fast/reflections/reflection-overflow-hidden.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::updateClipRects):
+ (WebCore::RenderLayer::calculateClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ * rendering/RenderLayer.h:
+ (WebCore::ClipRects::ClipRects):
+ (WebCore::ClipRects::reset):
+ (WebCore::ClipRects::overflowClipRect):
+ (WebCore::ClipRects::setOverflowClipRect):
+ (WebCore::ClipRects::fixedClipRect):
+ (WebCore::ClipRects::setFixedClipRect):
+ (WebCore::ClipRects::posClipRect):
+ (WebCore::ClipRects::setPosClipRect):
+ (WebCore::ClipRects::setFixed):
+ (WebCore::ClipRects::operator==):
+ (WebCore::ClipRects::operator=):
+ * rendering/RenderReplica.cpp:
+ (WebCore::RenderReplica::paint):
+
+2008-12-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22618
+
+ Fix MinGW QtWebKit linking problems and also make the
+ QtWebKit build system more robust.
+
+ * WebCore.pro:
+
+2008-12-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22866
+
+ wml.css is based on an older copy of html4.css. Synchronize them.
+ Remove all entries, that are irrelevant for WML.
+
+ Fix <do> appearance: should behave like HTMLs <button>.
+
+ * css/wml.css:
+
+2008-12-17 Yury Semikhatsky <yurys@google.com>
+
+ Reviewed by Timothy Hatcher.
+ Landed by Adam Barth.
+
+ Added more checks that WebInspector.panels.{resources,scripts} are
+ defined where they are accessed from other panels and WebInspector
+ (some panels are not yet supported in Chrome).
+
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype.addMessage):
+ (WebInspector.Console.prototype.clearMessages):
+ (WebInspector.Console.prototype.completions):
+ * inspector/front-end/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.get searchableViews):
+ (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource):
+ (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
+ (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype._addBreakpoint):
+ * inspector/front-end/inspector.js:
+ (WebInspector.addResource):
+ (WebInspector.removeResource):
+ (WebInspector.showResourceForURL):
+
+2008-12-17 Cary Clark < caryclark@google.com>
+
+ Reviewed by Darin Adler.
+ Landed by Adam Barth.
+
+ Add ENABLE_TEXT_CARET to permit the ANDROID platform
+ to invalidate and draw the caret in a separate thread.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::clearCaretRectIfNeeded): Body of
+ function does nothing if text caret is disabled.
+ (WebCore::Frame::selectionLayoutChanged): Do nothing
+ if text caret is disabled and the caret only blinked.
+ (WebCore::Frame::caretBlinkTimerFired):
+ (WebCore::Frame::paintCaret):
+ (WebCore::Frame::paintDragCaret): Body of
+ functions does nothing if text caret is disabled.
+
+2008-12-16 Darin Adler <darin@apple.com>
+
+ Reviewed and landed by Cameron Zwarich.
+
+ Change the style of AtomicString::add() to match Identifier:add().
+
+ * platform/text/AtomicString.cpp:
+ (WebCore::AtomicString::add):
+
+2008-12-16 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22827
+ <rdar://problem/6247724> RenderThemeWin buttons have weird heavy text
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::fillFontDescription): Add version that takes a font size.
+ (WebCore::RenderThemeWin::systemFont): Use the default GUI font for control fonts, but specify the size.
+ This will match Firefox.
+
+2008-12-16 Stephanie Lewis <slewis@apple.com>
+
+ Another build fix.
+
+ * platform/text/AtomicString.h:
+ (WebCore::AtomicString::AtomicString):
+
+2008-12-16 Stephanie Lewis <slewis@apple.com>
+
+ Windows Build Fix.
+
+ * platform/text/AtomicString.h:
+ (WebCore::AtomicString::AtomicString):
+ (WebCore::AtomicString::createCFString):
+
+2008-12-16 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22885
+ Fix memory corruption in GIFImageDecoder.cpp with certain GIFs.
+
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::frameComplete):
+
+2008-12-16 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Change HTTPHeaderMap to use an AtomicString as its key.
+ Shaves ~1MB off of the Mozilla Memory Test
+ No functionality difference
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * inspector/InspectorController.cpp:
+ (WebCore::addHeaders):
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::parseHeader):
+ * platform/network/HTTPHeaderMap.h:
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::httpHeaderField):
+ (WebCore::ResourceRequestBase::setHTTPHeaderField):
+ (WebCore::ResourceRequestBase::addHTTPHeaderField):
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::httpHeaderField):
+ (WebCore::ResourceResponseBase::setHTTPHeaderField):
+ * platform/network/ResourceResponseBase.h:
+ * platform/text/StringHash.h:
+ (WebCore::CaseFoldingHash::hash):
+ (WebCore::CaseFoldingHash::equal):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::isSetCookieHeader):
+ (WebCore::XMLHttpRequest::setRequestHeader):
+ (WebCore::XMLHttpRequest::setRequestHeaderInternal):
+ (WebCore::XMLHttpRequest::getRequestHeader):
+ (WebCore::XMLHttpRequest::getResponseHeader):
+ * xml/XMLHttpRequest.h:
+
+2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22876
+
+ Remove legacy randomNumber() functionality from HTMLFormElement, and use the new wtf/RandomNumber.h.
+ Also remove an uneeded QFileInfo include while I'm at it - there is no Qt usage in this file.
+
+ * ForwardingHeaders/wtf/RandomNumber.h: Added.
+ * html/HTMLFormElement.cpp:
+ (WebCore::getUniqueBoundaryString):
+
+2008-12-16 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Qt/Win build fix
+
+ * platform/win/SystemTimeWin.cpp:
+
+2008-12-16 Kalle Vahlman <kalle.vahlman@movial.com>
+
+ Reviewed by Holger Freyther.
+
+ [CURL] memory leak of ResouceHandles
+ http://bugs.webkit.org/show_bug.cgi?id=20777
+
+ Fix ResourceHandle ref management to be consistent and correct.
+ Original patch from Marco Barisione.
+
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::ResourceHandle::start):
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::removeFromCurl):
+ (WebCore::ResourceHandleManager::add):
+ (WebCore::ResourceHandleManager::removeScheduledJob):
+
+2008-12-16 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::clear): Adjust to new signature.
+
+2008-12-15 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Cameron Zwarich.
+
+ <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+
+2008-12-15 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22871
+ <rdar://problem/6417316> RenderThemeWin buttons are too short/thin
+
+ * rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
+ Check if the button's style (not the new inner style) has appearance set to determine whether we should set padding on the inner style.
+
+2008-12-15 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22865
+
+ Add complete WML <table> / <tr> / <td> element support.
+ Proper handling of all table related attributes, including tests.
+
+ Tests: fast/wml/table-element-align-attribute-invalid.wml (variable reference in 'align' attribute, raises error)
+ fast/wml/table-element-columns-attribute-invalid-number.wml (columns='0', raises error)
+ fast/wml/table-element-columns-attribute-invalid.wml (non-numeric 'columns' attribute value, raises error)
+ fast/wml/table-element-columns-attribute-missing.wml (missing 'columns')
+ fast/wml/table-element-columns-attribute.wml (test 'columns' attribute and <td> count mismatches)
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::offsetParent):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::addChild):
+ * wml/WMLTableElement.cpp: Added.
+ (WebCore::WMLTableElement::WMLTableElement):
+ (WebCore::WMLTableElement::~WMLTableElement):
+ (WebCore::WMLTableElement::mapToEntry):
+ (WebCore::WMLTableElement::parseMappedAttribute):
+ (WebCore::WMLTableElement::finishParsingChildren):
+ * wml/WMLTableElement.h: Added.
+ * wml/WMLTagNames.in:
+
+2008-12-15 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/6427048> crash due to infinite recursion after setting window.__proto__ = window
+
+ Test: fast/dom/Window/window-custom-prototype.html
+
+ Replaced toGlobalObject with the more generally useful unwrappedObject.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::unwrappedObject): Added.
+ * bindings/js/JSDOMWindowShell.h: Declared unwrappedObject.
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::unwrappedObject): Ditto.
+
+2008-12-15 Gustavo Noronha Silva <kov@kov.eti.br>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22686
+
+ GTK+ build fix.
+
+ * GNUmakefile.am:
+
+2008-12-15 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22847
+ Geolocation PositionOptions cannot be an arbitrary object.
+
+ Allow the PositionOptions to be a vanilla JS object and parse it
+ appropriately.
+
+ * DerivedSources.make: Remove PositionOptions.
+ * GNUmakefile.am: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions): Added. Extracts the enableHighAccuracy
+ and timeout fields from a vanilla JS object in order to create the
+ PositionOptions object, checking for exceptions as necessary.
+ (WebCore::JSGeolocation::getCurrentPosition): Use createPositionOptions
+ instead of toPositionOptions.
+ (WebCore::JSGeolocation::watchPosition): Ditto.
+ * page/PositionOptions.idl: Removed
+
+2008-12-15 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22108
+ Large animated GIFs weren't always animating. The code that deleted
+ the entire decoder after each frame of a large image was resulting in
+ us forgetting the loop count, breaking animations intermittently.
+
+ Instead of throwing the whole decoder away, we're more careful to just
+ delete frames we don't care about. This additionally addresses
+ problems in the Cairo and Chromium ports with excessive peak memory
+ use and CPU use when decoding large animated GIFs because it leads to
+ much less redecoding (O(n) instead of O(n^2) CPU, and O(1) instead of
+ O(n) memory).
+
+ This change has less impact on the CG decoder, which seems to throw
+ away frames automatically when their external references are dropped;
+ this means the CG decoder didn't suffer from the peak memory usage
+ issue before (and still doesn't), but it also still burns excessive
+ CPU redecoding earlier frames, that in theory it wouldn't need to
+ redecode if it would judiciously save the most recent frames. At
+ least this patch plumbs some useful info to the ImageSource so it can
+ help guide the CG decoder heuristics in the future.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::frameBytes):
+ (WebCore::BitmapImage::destroyDecodedData):
+ (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
+ (WebCore::BitmapImage::destroyMetadataAndNotify):
+ (WebCore::BitmapImage::clearFrame):
+ (WebCore::BitmapImage::cacheFrame):
+ (WebCore::BitmapImage::dataChanged):
+ (WebCore::BitmapImage::startAnimation):
+ (WebCore::BitmapImage::resetAnimation):
+ (WebCore::BitmapImage::internalAdvanceAnimation):
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/GeneratedImage.h:
+ (WebCore::GeneratedImage::destroyDecodedData):
+ * platform/graphics/Image.h:
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::~ImageSource):
+ (WebCore::ImageSource::clear):
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::~ImageSource):
+ (WebCore::ImageSource::clear):
+ * platform/graphics/cg/PDFDocumentImage.h:
+ (WebCore::PDFDocumentImage::destroyDecodedData):
+ * platform/graphics/qt/StillImageQt.h:
+ (WebCore::StillImage::destroyDecodedData):
+ * platform/image-decoders/ImageDecoder.h:
+ (WebCore::RGBA32Buffer::clear):
+ (WebCore::ImageDecoder::clearFrameBufferCache):
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::repetitionCount):
+ (WebCore::GIFImageDecoder::clearFrameBufferCache):
+ (WebCore::GIFImageDecoder::initFrameBuffer):
+ * platform/image-decoders/gif/GIFImageDecoder.h:
+ * platform/image-decoders/gif/GIFImageReader.h:
+ (GIFImageReader::GIFImageReader):
+ * svg/graphics/SVGImage.h:
+ (WebCore::SVGImage::destroyDecodedData):
+
+2008-12-15 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22562: REGRESSION (r37971): events not firing after going back in back/forward cache
+ <https://bugs.webkit.org/show_bug.cgi?id=22562>
+ <rdar://problem/6414593>
+
+ Restore the Frame's DOMWindow to its previous value when going back in
+ the back/forward cache. The fact that it was not getting set before may
+ have always caused some subtle bugs with the back/forward cache, but
+ after r37971, it causes no events to fire after restoring a page.
+
+ Previously, ScriptController::clearScriptObjects() was calling
+ clearPlatformScriptObjects(), which was not actually clearing any
+ objects, only updating them to reflect some change in state. Since the
+ window shell was not updated until after the call to clearScriptObjects(),
+ this didn't actually make that much sense.
+
+ We rename clearPlatformScriptObjects() to reflect its actual purpose and
+ call it after the window shell has been updated rather than before.
+
+ Unfortunately, there is no way to test this with a layout test because
+ it involves the back/forward cache.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::updatePlatformScriptObjects): Renamed from
+ clearPlatformScriptObjects(), because the only nonempty implementation
+ doesn't actually clear any objects, it updates them. Also made public.
+ (WebCore::ScriptController::clearScriptObjects): Remove the call to
+ clearPlatformScriptObjects().
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::updatePlatformScriptObjects):
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::domWindow): Added.
+ * history/CachedPage.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::cancelAndClear): Added call to updatePlatformScriptObjects().
+ (WebCore::FrameLoader::begin): Added call to updatePlatformScriptObjects().
+ (WebCore::FrameLoader::open): Added call to updatePlatformScriptObjects().
+ * page/Frame.cpp:
+ (WebCore::Frame::setDOMWindow): Added.
+ (WebCore::Frame::pageDestroyed): Added call to updatePlatformScriptObjects().
+ * page/Frame.h:
+
+2008-12-15 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
+ https://bugs.webkit.org/show_bug.cgi?id=17998
+
+ - Enable conditional revalidation for reloads by default.
+ - Add a parameter to FrameLoader::reload() for forcing end-to-end reload.
+ - To avoid duplicating state remove m_cachePolicy variables from FrameLoader and DocLoader.
+ Instead synthezise the policy on demand.
+
+ This speeds up reloads and makes them use way less bandwidth.
+
+ * WebCore.base.exp:
+ * loader/CachePolicy.h: Rename CachePolicyRefresh to CachePolicyRevalidate.
+ (WebCore::):
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::DocLoader):
+ (WebCore::DocLoader::checkForReload): Support CachePolicyRevalidate.
+ (WebCore::DocLoader::requestResource):
+ (WebCore::DocLoader::cachePolicy):
+ * loader/DocLoader.h: Get rid of m_cachePolicy member.
+ * loader/FrameLoader.cpp:
+ (WebCore::ScheduledRedirection::ScheduledRedirection):
+ Add parameter to differentiate refresh from other types of redirects.
+ m_cachePolicy was used for signaling this before.
+ (WebCore::isBackForwardLoadType):
+ (WebCore::FrameLoader::FrameLoader):
+ (WebCore::FrameLoader::changeLocation):
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::receivedFirstData):
+ (WebCore::FrameLoader::write):
+ (WebCore::FrameLoader::startIconLoader):
+ (WebCore::FrameLoader::restoreDocumentState):
+ (WebCore::FrameLoader::scheduleHTTPRedirection):
+ (WebCore::FrameLoader::scheduleLocationChange):
+ (WebCore::FrameLoader::scheduleRefresh):
+ (WebCore::FrameLoader::redirectionTimerFired):
+ (WebCore::FrameLoader::canCachePage):
+ (WebCore::FrameLoader::loadURL):
+ (WebCore::FrameLoader::reload):
+ Differentiate between revalidation and reload.
+ No need to use setHTTPHeaderField here, addExtraFieldsToRequest will set the headers.
+ (WebCore::FrameLoader::transitionToCommitted):
+ (WebCore::FrameLoader::cachePolicy): Determine the cache policy based on current load type.
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
+ (WebCore::FrameLoader::addExtraFieldsToRequest): Set Cache-control: no-cache for FrameLoadTypeReloadFromOrigin
+ (WebCore::FrameLoader::shouldScrollToAnchor):
+ (WebCore::FrameLoader::loadItem):
+ (WebCore::FrameLoader::updateHistoryForReload):
+ (WebCore::FrameLoader::updateHistoryForCommit):
+ (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderTypes.h: Add FrameLoadTypeReloadFromOrigin
+ (WebCore::):
+ * loader/NavigationAction.cpp:
+ (WebCore::navigationType): Support FrameLoadTypeReloadFromOrigin
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::servePendingRequests):
+
+2008-12-15 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ Add null checks to PlatformScreenQt
+
+ The other ports do the null checks and JSDOMWindowBase is
+ at least one caller that is passing 0.
+
+ * platform/qt/PlatformScreenQt.cpp:
+ (WebCore::screenDepth):
+ (WebCore::screenDepthPerComponent):
+ (WebCore::screenIsMonochrome):
+ (WebCore::screenRect):
+ (WebCore::screenAvailableRect):
+
+2008-12-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time
+
+ * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
+ Detach the thread. Without this, one page of its stack was never unmmaped, and fragmentation
+ made RegisterFile allocaiton fail after a while.
+
+2008-12-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - half of https://bugs.webkit.org/show_bug.cgi?id=17425
+ eliminate DeprecatedPtrList
+
+ * dom/Document.cpp:
+ (WebCore::Document::removeImage): Change to set slots in the vector
+ to 0 rather than removing items from a list.
+ (WebCore::Document::dispatchImageLoadEventsNow): Rewrite to process
+ the list. Since we now use a "set to zero" design, we don't need to
+ be careful about where the iterator points while iterating the list,
+ instead we just have to skip zeros.
+
+ * dom/Document.h: Use Vector instead of DeprecatedPtrList.
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchGenericEvent): Use a Vector instead
+ of a DeprecatedPtrList for the list of nodes to handle. Also streamlined
+ the logic a bit and used goto in a couple key places.
+
+ * dom/Node.cpp:
+ (WebCore::Node::eventParentNode): Moved this function into this file
+ because it's a virtual function so already can't be inlined. Also updated
+ to return a ContainerNode, so it needs to be in a place where the
+ definition of ContainerNode is visible, not the header file.
+
+ * dom/Node.h: Changed return type of eventParentNode to ContainerNode
+ and moved its definition into the cpp file.
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::PendingCallbacks::~PendingCallbacks): Added a call to
+ deleteAllValues here instead of setAutoDelete in the constructor, since
+ we're using Deque instead of DeprecatedPtrList.
+ (WebCore::PendingCallbacks::callAndRemoveFirstCallback): Changed the
+ code to use an OwnPtr since the deque won't delete the callback object.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use a
+ Vector instead of a DeprecatedPtrList.
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::eventParentNode): Moved this function into this file
+ because it's a virtual function so already can't be inlined. Also updated
+ to return a ContainerNode.
+
+ * svg/SVGElement.h: Changed setShadowParentNode to take a ContainerNode*,
+ made eventParentNode return a ContainerNode*, and made m_shadowParent a
+ ContainerNode*.
+
+2008-12-14 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22857
+
+ Jumps within a WML deck using <go> task elements fail. Manual reloading
+ is necessary to display the page - fix cache-policy in WMLGoElement::executeTask
+ to prevent the problem.
+
+ Refactor setActiveCardInDocument in two new functions: findNamedCardInDocument
+ and determineActiveCard, to fix a side-effect of executing a <go> task:
+ when switching cards within a deck the active card was changed before the load
+ was fired which resulted in a flash effect on the screen, and doing unnecessary work.
+
+ Test: wml/go-task-animation.html
+
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::findNamedCardInDocument):
+ (WebCore::WMLCardElement::determineActiveCard):
+ * wml/WMLCardElement.h:
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing):
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::executeTask):
+ (WebCore::WMLGoElement::prepareGETRequest):
+ * wml/WMLGoElement.h:
+
+2008-12-14 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fixes an issue in cairo. A fully transparent color can cause wrong
+ drawings on canvas' composite.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22846
+ [CAIRO] Canvas: transparent color and composite
+
+ Test: fast/canvas/canvas-transparency-and-composite.html
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+
+2008-12-13 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
+ https://bugs.webkit.org/show_bug.cgi?id=22665
+
+ Remove setCreatedByParser from frame and iframe.
+
+ * html/HTMLElementFactory.cpp:
+ (WebCore::frameConstructor):
+ (WebCore::iframeConstructor):
+ (WebCore::objectConstructor):
+ * html/HTMLFrameElement.cpp:
+ (WebCore::HTMLFrameElement::HTMLFrameElement):
+ * html/HTMLFrameElement.h:
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
+ * html/HTMLFrameElementBase.h:
+ * html/HTMLFrameOwnerElement.cpp:
+ (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
+ * html/HTMLFrameOwnerElement.h:
+ (WebCore::HTMLFrameOwnerElement::createdByParser):
+ * html/HTMLIFrameElement.cpp:
+ (WebCore::HTMLIFrameElement::HTMLIFrameElement):
+ * html/HTMLIFrameElement.h:
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::HTMLPlugInElement):
+ * html/HTMLTagNames.in:
+
+2008-12-13 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22843
+ Auto-generate JSWorkerContext
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/WorkerContext.idl: Added.
+ * page/DOMWindow.idl:
+ Added ExtendsDOMGlobalObject, a new attribute for behaviors common to DOMWindow and
+ WorkerContext.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::initScript):
+ Made JSWorkerContext creation look more like JSDOMWindow creation, to work with generated code.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSWorkerContext.cpp: Removed.
+ * bindings/js/JSWorkerContext.h: Removed.
+ * bindings/js/JSWorkerContextBase.cpp: Copied from WebCore/bindings/js/JSWorkerContext.cpp.
+ (WebCore::JSWorkerContextBase::JSWorkerContextBase):
+ (WebCore::JSWorkerContextBase::~JSWorkerContextBase):
+ (WebCore::JSWorkerContextBase::scriptExecutionContext):
+ (WebCore::getJSWorkerContextBaseTable):
+ (WebCore::):
+ (WebCore::JSWorkerContextBase::put):
+ * bindings/js/JSWorkerContextBase.h: Copied from WebCore/bindings/js/JSWorkerContext.h.
+ * bindings/js/JSWorkerContextCustom.cpp: Added.
+ (WebCore::JSWorkerContext::customGetOwnPropertySlot):
+ (WebCore::JSWorkerContext::mark):
+ (WebCore::JSWorkerContext::self):
+ (WebCore::JSWorkerContext::setSelf):
+ (WebCore::JSWorkerContext::addEventListener):
+ (WebCore::JSWorkerContext::removeEventListener):
+ Moved code around. Note that currently, JSWorkerContextBase lookup table is empty, but we'll
+ need to add some global objects to it in the future, as it is done in JSDOMWindowBase.
+
+ * page/WorkerNavigator.cpp:
+ * page/WorkerNavigator.h:
+ Added ENABLE(WORKERS) ifdefs.
+
+2008-12-13 Darin Adler <darin@apple.com>
+
+ - fix Release build
+
+ * dom/Node.cpp:
+ (WebCore::Node::rareData): Remove inappropriate inline directive.
+
+2008-12-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=18734
+ REGRESSION (r31081): Focus problems in Gmail 2/Plain text message text
+ <rdar://problem/5892415>
+
+ Test: fast/forms/textarea-selection-preservation.html
+
+ The regression reported was caused by the fact that the renderer code had
+ a bug where it would constantly think the newline at the end of text was
+ missing, and so it would replace all the text even though it wasn't changing,
+ which would destroy the selection.
+
+ When writing the regression test I discovered another problem: The value
+ property in HTMLTextAreaElement was intentionally changing the selection
+ to the end of the textarea, but doing that even when the value wasn't changing.
+
+ This patch fixes both and the test checks both.
+
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::setValue): Exit early if the value is
+ not changing.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::text): Add a newline character for each <br>
+ element encountered in the control
+
+2008-12-13 Darin Adler <darin@apple.com>
+
+ - file deletion part of https://bugs.webkit.org/show_bug.cgi?id=17497
+ eliminate DeprecatedValueList
+
+ * GNUmakefile.am: Removed references to deleted files.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * platform/DeprecatedPtrQueue.h: Removed.
+ * platform/DeprecatedValueList.h: Removed.
+ * platform/DeprecatedValueListImpl.cpp: Removed.
+ * platform/DeprecatedValueListImpl.h: Removed.
+
+2008-12-13 Darin Adler <darin@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=17497
+ eliminate DeprecatedValueList
+
+ * css/CSSStyleDeclaration.cpp: Removed unneeded include.
+
+ * dom/Document.cpp:
+ (WebCore::Document::removeAllEventListenersFromAllNodes):
+ Set the removed flag on the window event listeners in case we
+ are in the middle of dispatching events on this window.
+ (WebCore::Document::clear): Ditto.
+ (WebCore::Document::handleWindowEvent): Changed to use a vector
+ instead of a DeprecatedPtrList.
+ (WebCore::Document::windowInlineEventListenerForType): Ditto.
+ (WebCore::Document::removeWindowInlineEventListenerForType): Ditto.
+ Also added a call to setRemoved, which is needed here just as in
+ other functions that remove.
+ (WebCore::Document::removeWindowEventListener): Ditto.
+ (WebCore::Document::hasWindowEventListener): Ditto.
+
+ * dom/Document.h: Changed RegisteredEventListenerList to
+ RegisteredEventListeners.
+
+ * dom/Element.cpp:
+ (WebCore::Element::attach): Use a function to access rare data instead
+ of getting directly at the data field.
+ (WebCore::Element::focus): Ditto.
+ (WebCore::Element::cancelFocusAppearanceUpdate): Ditto.
+
+ * dom/ElementRareData.h: Use "using" to make things that are protected
+ in NodeRareData be public here.
+
+ * dom/EventTarget.h: Removed include of DeprecatedValueList and
+ related declearations that weren't needed. Tweaked the definitions
+ of the forbidEventDispatch functions too.
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::EventTargetNode): Eliminated code that
+ was used to initialized m_regdListeners.
+ (WebCore::EventTargetNode::~EventTargetNode): Elminated delete of
+ m_regdListeners. Changed code to use eventListeners() instead of
+ m_regdListeners.
+ (WebCore::EventTargetNode::eventListeners): Added.
+ (WebCore::EventTargetNode::insertedIntoDocument): Use eventListeners.
+ (WebCore::EventTargetNode::removedFromDocument): Ditto.
+ (WebCore::EventTargetNode::willMoveToNewOwnerDocument): Ditto.
+ (WebCore::EventTargetNode::didMoveToNewOwnerDocument): Ditto.
+ (WebCore::EventTargetNode::addEventListener): Ditto.
+ (WebCore::EventTargetNode::removeEventListener): Ditto.
+ (WebCore::EventTargetNode::removeAllEventListeners): Ditto.
+ Also added code to call setRemoved on all the listeners.
+ (WebCore::EventTargetNode::handleLocalEvents): Ditto.
+ (WebCore::EventTargetNode::dispatchGenericEvent): Fixed indentation.
+ (WebCore::EventTargetNode::removeInlineEventListenerForType): Use
+ the new event listeners vector. Also added missing call to setRemoved.
+ (WebCore::EventTargetNode::inlineEventListenerForType): Ditto.
+
+ * dom/EventTargetNode.h: Added a new RegisteredEventListenerVector
+ type and replaced the old localEventListeners function with a new
+ eventListeners function. Removed m_regdListeners.
+
+ * dom/Node.cpp:
+ (WebCore::Node::childNodes): Removed unneeded std prefix.
+ (WebCore::Node::setFocus): Use function instead of going directly
+ at rare data.
+ (WebCore::Node::rareDataFocused): Ditto.
+ (WebCore::Node::registerDynamicNodeList): Removed unneeded std prefix.
+ (WebCore::Node::getElementsByName): Ditto.
+ (WebCore::Node::getElementsByClassName): Ditto.
+ (WebCore::Node::compareDocumentPosition): Ditto.
+
+ * dom/Node.h: Removed unneeded forward declaration of
+ RegisteredEventListener. This is now in EventTargetNode.
+
+ * dom/NodeRareData.h: Renamed m_focused to m_isFocused and made it
+ private. Made m_needsFocusAppearanceUpdateSoonAfterAttach private.
+ Added listeners and ensureListeners functions as well as isFocused,
+ setFocused, and focus-appearance functions. Made all data members private.
+
+ * dom/RegisteredEventListener.cpp: Removed operator ==.
+ * dom/RegisteredEventListener.h: Removed operator == and !=.
+
+ * svg/SVGElement.cpp:
+ (WebCore::hasLoadListener): Rewrote to work with the vector.
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
+
+2008-12-13 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22824
+
+ Change ENABLE(FONT_FAST_PATH) to USE(FONT_FAST_PATH). With r39206
+ floatWidth always used the complex path causing a regression
+ in the pixel tests.
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::floatWidth): Use the fast path again
+
+2008-12-13 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fixes behavior of gradients on empty path in canvas/Cg
+
+ https://bugs.webkit.org/show_bug.cgi?id=22844
+ [Cg] Canvas fill() draws gradients even without a path
+
+ Test: fast/canvas/canvas-gradient-without-path.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::fill):
+ (WebCore::CanvasRenderingContext2D::stroke):
+
+2008-12-13 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::filenameExtension):
+
+2008-12-12 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
+
+ Provides implementation of image dragging logic for Windows Cairo
+ back-end.
+
+ * platform/win/DragImageCGWin.cpp:
+ (WebCore::deallocContext): Add a generic CGContextRef destructor.
+ * platform/win/DragImageCairoWin.cpp:
+ (WebCore::deallocContext): Add a generic cairo_* destructor.
+ (WebCore::allocImage): New implementation to allocate a Cairo
+ surface of a specified size.
+ (WebCore::createCairoContextFromBitmap): New implementation to
+ create a Cairo surface from a Windows BITMAP.
+ (WebCore::scaleDragImage): Replace stub with implementation to
+ actually create a scaled image.
+ (WebCore::createDragImageFromImage): Replace stub with implementation
+ to actually create an image.
+
+2008-12-12 Dean Jackson <dino@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Expose WebKitAnimationEvent, WebKitTransitionEvent,
+ WebKitCSSTransformValue, WebKitCSSKeyframeRule and
+ WebKitCSSKeyframesRule to Window object.
+ This required generating constructors for the event
+ interfaces.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20560
+
+ * dom/WebKitAnimationEvent.idl:
+ * dom/WebKitTransitionEvent.idl:
+ * page/DOMWindow.idl:
+
+2008-12-12 Dave Moore <davemoore@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22798
+
+ In Font::drawTextUsingSVGFont() a variable of type SVGTextRunWalkerDrawTextData
+ is created on the stack (called data). One of its fields, charsConsumed, is
+ unitialized, leading to random values after calling walk() on the
+ SVGTextRunWalker created with it. I now initialize the variable
+
+ This bug was revealed in our Purify run. I don't know of any specific incorrect
+ behavior caused by it but it would lead to the charsConsumed field having a
+ a wrong value.
+
+ * svg/SVGFont.cpp:
+ (WebCore::Font::drawTextUsingSVGFont):
+
+2008-12-12 Beth Dakin <bdakin@apple.com>
+
+ Rubber Stamped by Steve Falkenburg.
+
+ Build fix.
+
+ * platform/KURL.h:
+
+2008-12-12 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add the ability so that Google-URL can optionally be used in a build
+ of WebKit without changing the shared header. The guts of KURL are
+ optionally ifdefed out, and the replacement code goes in a different
+ header to avoid polluting KURL.h
+
+ * platform/KURL.cpp:
+ * platform/KURL.h:
+ (WebCore::KURL::string):
+ (WebCore::KURL::operator const String&):
+ (WebCore::KURL::operator JSC::UString):
+ (WebCore::KURL::operator NSString*):
+ (WebCore::KURL::parsed):
+ (WebCore::KURL::utf8String):
+ (WebCore::KURL::isNull):
+ (WebCore::KURL::isEmpty):
+ (WebCore::KURL::isValid):
+ (WebCore::KURL::hostStart):
+ (WebCore::KURL::hostEnd):
+ (WebCore::KURL::pathStart):
+ (WebCore::KURL::pathEnd):
+ (WebCore::KURL::pathAfterLastSlash):
+
+2008-12-11 Steve Falkenburg <sfalken@apple.com>
+
+ Delete the previous timer-queue timer in the main thread, just prior to scheduling a new timer.
+ The code previously called DeleteTimerQueueTimer in the timer callback proc.
+
+ The new technique simplifies the code, since we now create and delete timers on the
+ same thread, and don't access the timer queue or timer handles in the callback.
+ This allows us to remove some mutex use, and more importantly, it solves a race
+ condition that was occuring between ChangeTimerQueueTimer and DeleteTimerQueueTimer.
+
+ Since the timer callback isn't passed the timer handle, we were retrieving that handle
+ via a global. If the timer callback code was entered, but then a new timer was immediately
+ scheduled (prior to the callback acquiring the mutex and calling DeleteTimerQueueTimer),
+ there was a small window where the timer could be re-scheduled via ChangeTimerQueueTimer
+ and then immediately deleted once the already running callback acquired the mutex and
+ then called DeleteTimerQueueTimer. This resulted in the newly scheduled timer never firing.
+
+ Reviewed by Oliver Hunt.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::queueTimerProc): Don't delete the timer in the callback.
+ (WebCore::setSharedTimerFireTime): Always delete and create the timer instead of using ChangeTimerQueueTimer.
+ (WebCore::stopSharedTimer): Call DeleteTimerQueueTimer directly.
+
+2008-12-12 Kai Brüning <kai@granus.net>
+
+ Reviewed and tweaked by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=18205
+ DOMNode objects are garbage collected although there are strong references
+ <rdar://problem/6441200>
+
+ Fixes resurrection bug for wrapper objects by using an NSMapTable with zeroing weak
+ memory for the wrapper reference for DOMWrapperCache (DOMInternal.mm),
+ JSWrapperCache (WebScriptObject.mm) and wrapperCache (DOMRGBColor.mm).
+ BUILDING_ON_TIGER is used to create a Leopard-only NSMapTable or an old-style
+ procedural map table for Tiger systems.
+
+ No regression tests yet since we don't currently run any tests in GC mode.
+
+ * bindings/objc/DOMInternal.h: added WebCore::createWrapperCache for use by all three caches
+ * bindings/objc/DOMInternal.mm:
+ (WebCore::createWrapperCache): Contains the compile-time check for map table creation
+ (WebCore::getDOMWrapper): HashMap -> NSMapTable
+ (WebCore::addDOMWrapper): ditto
+ (WebCore::removeDOMWrapper): ditto
+ * bindings/objc/DOMObject.mm: removed [DOMObject finalize]
+ * bindings/objc/DOMRGBColor.mm: removed [DOMRGBColor finalize]
+ (WebCore::getWrapperForRGB): CFMutableDictionaryRef -> NSMapTable
+ (WebCore::setWrapperForRGB): ditto
+ (WebCore::removeWrapperForRGB): ditto
+ * bindings/objc/WebScriptObject.mm:
+ (WebCore::getJSWrapper): HashMap -> NSMapTable
+ (WebCore::addJSWrapper): ditto
+ (WebCore::removeJSWrapper): ditto
+ (-[WebScriptObject finalize]): removed call of removeJSWrapper()
+
+2008-12-12 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22813
+ Remove unused references to JSDOMBinding, CallFrame, and JSLock.
+
+ * dom/Node.cpp: Removed CallFrame and JSLock header includes.
+ * loader/FrameLoader.cpp: Removed JSDOMBinding header include.
+
+2008-12-12 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ Update the WebKit.qrc and add a script to automatically generate the file.
+
+ With the way rcc and qmake work this can not be done at build time
+ as the WebKit.qrc must sit inside the directory that contains the files
+ and at build time we may not change the content of the source directory.
+
+ * inspector/front-end/WebKit.qrc: Updated with new script
+
+2008-12-12 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ REGRESSION: Canvas is broken in high dpi mode
+ <rdar://problem/6432739> <https://bugs.webkit.org/show_bug.cgi?id=22823>
+
+ Simply made sure that we correctly scale the graphics context to
+ account for the difference between logical and buffer resolution.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::createImageBuffer):
+ (WebCore::HTMLCanvasElement::baseTransform):
+
+2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Share PluginView::paintMissingPluginIcon() between ports
+
+ Also, enable this feature for Qt/X11, Qt/Mac and GTK
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::paintMissingPluginIcon):
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::paint):
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::paint):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::paint):
+ * plugins/win/PluginViewWin.cpp:
+
+2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt/Mac] Implement PluginView::updatePluginWidget()
+
+ We should update the window and clip rect regardless of whether or
+ not the plugin has been loaded, for example to ensure that the
+ missing plugin image is placed correctly.
+
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::setNPWindowIfNeeded):
+ (WebCore::PluginView::updatePluginWidget):
+
+2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Oliver Hunt.
+
+ Make PluginView::updatePluginWidget() non-const
+
+ We can do this now since frameRectsChanged() is no longer const. This
+ also allows us to get rid of the mutables in the PluginView.
+
+ * platform/qt/TemporaryLinkStubs.cpp:
+ (PluginView::updatePluginWidget):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/wx/PluginViewWx.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+
+2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Implement ImageSource::filenameExtension() for the Qt port
+
+ We're using QImageReader::imageFormat().toLower() to check
+ that the image format is supported, and if it is we store
+ the resulting extension when creating the ImageDecoderQt.
+
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::create):
+ (WebCore::ImageDecoderQt::ImageDecoderQt):
+ (WebCore::ImageDecoderQt::imageFormat):
+ * platform/graphics/qt/ImageDecoderQt.h:
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::setData):
+ (WebCore::ImageSource::filenameExtension):
+
+2008-12-11 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Geoff Garen
+
+ Account for the size of the response and request headers as well as other overhead
+ when calculating the size a resource takes up in the cache. Halts unbounded
+ growth in the cache. Reduced stress test memory high water marks by > 50%.
+
+ Uses estimates gathered from the stress test to set the overhead size.
+ A version of the patch was created that calculated most of the sizes, but it was
+ decided that the patch was still at a basic level an estimate. What gains it made
+ in accuracy was offset by the complexity involved in creating and updating the
+ estimate.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::resourceAccessed):
+ (WebCore::Cache::TypeStatistic::addResource):
+ (WebCore::Cache::dumpLRULists):
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::overheadSize):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::size):
+
+2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Holger Freyther.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22814
+
+ Add <wml> image element support. Based on HTML/SVGImage{Element/Loader}, with
+ the only difference that WML defines a second source attribute 'localsrc', that
+ takes precedence over the 'src' attribute. If loading the 'localsrc' attribute
+ fails, the user agent should try loading the 'src' attribute. If both fail the
+ 'alt' fallback content will be used - just like in HTML.
+
+ Fixes: fast/wml/img-localsrc.wml (<img> and 'localsrc' attribute)
+ fast/wml/img-src-localsrc-alt.wml ('localsrc'/'src' fallback handling)
+ fast/wml/img-src.wml (<img> and 'src' attribute)
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::altDisplayString):
+ (WebCore::HitTestResult::absoluteImageURL):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::updateAltText):
+ * wml/WMLImageElement.cpp: Added.
+ (WebCore::WMLImageElement::WMLImageElement):
+ (WebCore::WMLImageElement::~WMLImageElement):
+ (WebCore::WMLImageElement::mapToEntry):
+ (WebCore::WMLImageElement::parseMappedAttribute):
+ (WebCore::WMLImageElement::attach):
+ (WebCore::WMLImageElement::createRenderer):
+ (WebCore::WMLImageElement::insertedIntoDocument):
+ (WebCore::WMLImageElement::isURLAttribute):
+ (WebCore::WMLImageElement::imageSourceAttributeName):
+ (WebCore::WMLImageElement::altText):
+ * wml/WMLImageElement.h: Added.
+ (WebCore::WMLImageElement::useFallbackAttribute):
+ (WebCore::WMLImageElement::setUseFallbackAttribute):
+ * wml/WMLImageLoader.cpp: Added.
+ (WebCore::WMLImageLoader::WMLImageLoader):
+ (WebCore::WMLImageLoader::~WMLImageLoader):
+ (WebCore::WMLImageLoader::dispatchLoadEvent):
+ (WebCore::WMLImageLoader::sourceURI):
+ (WebCore::WMLImageLoader::notifyFinished):
+ * wml/WMLImageLoader.h: Added.
+ * wml/WMLTagNames.in:
+
+2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22043
+
+ Do not run into the WebCore::DocumentLoader::updateLoading
+ ASSERT on Gtk+/CURL when trying to load tests from our LayoutTests.
+
+ Do not call setPrimaryLoadComplete when the
+ activeDocumentLoader has already been replaced. This can happen
+ when a script executed from within FramerLoader::didFinishLoading will
+ navigate to another URL.
+
+ The assertion is caused by existing tests (e.g.
+ fast/history/clicked-link-is-visited.html) reproducing this with
+ network backends not equal to curl is tough or maybe not
+ even possible.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::setPrimaryLoadComplete):
+
+2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Eric Seidel.
+
+ - Remove some dead, commented-out code from WMLAElement.
+ - Add missing virtual destructor for <noop>, as suggested by Alexey.
+ - Refactor addHTMLAlignment in a static helper function to share with WML.
+
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::addHTMLAlignment):
+ (WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
+ * html/HTMLElement.h:
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::defaultEventHandler):
+ * wml/WMLNoopElement.cpp:
+ (WebCore::WMLNoopElement::~WMLNoopElement):
+ * wml/WMLNoopElement.h:
+
+2008-12-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/6302405> Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
+ <https://bugs.webkit.org/show_bug.cgi?id=22804>
+
+ This issue was caused by css generated content resulting in non-svg flowboxes
+ being injected into SVG content. As SVG spec does not describe behaviour in
+ this case, and neither Opera nor Firefox displays such generated content, so
+ now we make svg text layout and rendering just ignore any such content.
+
+ Test: svg/css/crash-css-generated-content.xhtml
+
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBox::buildLayoutInformation):
+ (WebCore::SVGRootInlineBox::layoutInlineBoxes):
+ (WebCore::SVGRootInlineBox::buildTextChunks):
+
+2008-12-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Bug 21256: REGRESSION (r36906): horizontally repeating image leaves ghosts when vertical scrolling
+ <https://bugs.webkit.org/show_bug.cgi?id=21256>
+ <rdar://problem/6362978>
+
+ The ScrollView refactoring in r36906 caused the ScrollView and the
+ platform widget to disagree about whether optimizing scrolling via
+ blitting is allowed. The easiest way to fix this is to make ScrollView
+ simply ask the platform widget whether this is safe on platforms that
+ are affected.
+
+ It is not possible to write a layout test for this bug because it
+ involves the back/forward cache.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::setCanBlitOnScroll):
+ (WebCore::ScrollView::canBlitOnScroll):
+ (WebCore::ScrollView::platformSetCanBlitOnScroll):
+ (WebCore::ScrollView::platformCanBlitOnScroll):
+ * platform/ScrollView.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformSetCanBlitOnScroll):
+ (WebCore::ScrollView::platformCanBlitOnScroll):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetCanBlitOnScroll):
+ (WebCore::ScrollView::platformCanBlitOnScroll):
+
+2008-12-11 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22808
+
+ Correct build break due to malformed XML in Visual Studio project
+ following @r39205 change.
+
+ * WebCore.vcproj/WebCore.vcproj: Correct file entry so project loads.
+
+2008-12-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=22738
+
+ This gets rid of the per-animation timers which were used when an animation
+ started, ended and looped. Their job is now done by the main AnimationController's
+ timer. It is now set to fire as needed. For instance, if there is a delay, it will
+ fire after the delay time and then every 30ms to run the animation. The start, loop
+ and end events are generated as needed during the firing of this timer.
+
+ I had to add one more bit of code. When animation timers used to fire the animation events.
+ This would always happen from the RunLoop, so any style changes that happened in the
+ event handler would get picked up on the next updateRendering() call. But now the start
+ event is generated during the styleIsAvailable() call, which is in the middle of the
+ updateRendering() cycle. And calling an event handler in the middle of updateRendering()
+ is not allowed and causes style changes to get missed. We already have a mechanism in
+ AnimationController to defer updateRendering() calls. So I added logic to defer all
+ event handling to there. Now, I put any request for event handling into a list and ask
+ for a deferred updateRendering() call. When that deferred timer fires, I go through that
+ list, send all the events and then call updateRendering().
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::AnimationBase):
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
+ (WebCore::AnimationBase::willNeedService):
+ (WebCore::AnimationBase::goIntoEndingOrLoopingState):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
+ (WebCore::AnimationControllerPrivate::addEventToDispatch):
+ (WebCore::AnimationControllerPrivate::animationTimerFired):
+ (WebCore::AnimationController::addEventToDispatch):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ (WebCore::CompositeAnimationPrivate::willNeedService):
+ (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
+ (WebCore::CompositeAnimation::willNeedService):
+ (WebCore::CompositeAnimation::getAnimationForProperty):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ (WebCore::ImplicitAnimation::onAnimationEnd):
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ * page/animation/KeyframeAnimation.h:
+ (WebCore::KeyframeAnimation::setUnanimatedStyle):
+
+2008-12-11 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build with an empty filenameExtension() implementation.
+
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::filenameExtension):
+
+2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ Fix crash in the cairo implementation of the SVGPaintServer
+
+ For SVGFonts the RenderObject can be zero. The existing SVGFont
+ test cases is exposing this bug. Qt and other ports have fixed
+ this issue by adding null checks as well.
+
+ * svg/graphics/cairo/SVGPaintServerCairo.cpp:
+ (WebCore::SVGPaintServer::renderPath):
+
+2008-12-11 Holger Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20953
+
+ Make the Qt port follow the Win, Mac, Gtk+ port in regard to Font
+ handling. FontQt.cpp from now on is only implementing the complex path. Create
+ FontFallbackListQt.cpp and FontPlatformDataQt.cpp to work within
+ the framework set by the Font code.
+
+ Sharing the Font.cpp implementation allows the Qt port to support
+ the CSS font faces and SVG fonts.
+
+ Split out the Qt4.3 Font handling into FonQt43.cpp to allow to more
+ easily deprecate it.
+
+ This commit is removing a lot of #ifdefs from Font.h as the Qt Font
+ implementation is now in line with the rest of WebCore.
+
+ * WebCore.pro:
+ * platform/graphics/Font.h: Remove #ifdefs
+ (WebCore::Font::letterSpacing):
+ (WebCore::Font::setLetterSpacing):
+ (WebCore::Font::isPlatformFont):
+ * platform/graphics/FontFallbackList.h:
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData):
+ (WebCore::SimpleFontData::platformGlyphInit): There is no GlyphCache
+ on Qt, move the initialisation over.
+ (WebCore::SimpleFontData::~SimpleFontData):
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::getQtFont):
+ * platform/graphics/qt/FontCacheQt.cpp:
+ (WebCore::FontCache::getCachedFontPlatformData): Remove unused parameter
+ (WebCore::FontCache::releaseFontData): Add to build
+ * platform/graphics/qt/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
+ (WebCore::FontCustomPlatformData::fontPlatformData):
+ (WebCore::createFontCustomPlatformData):
+ * platform/graphics/qt/FontCustomPlatformData.h:
+ * platform/graphics/qt/FontFallbackListQt.cpp: Added.
+ (WebCore::FontFallbackList::FontFallbackList):
+ (WebCore::FontFallbackList::invalidate):
+ (WebCore::FontFallbackList::releaseFontData):
+ (WebCore::FontFallbackList::determinePitch):
+ (WebCore::FontFallbackList::fontDataAt):
+ (WebCore::FontFallbackList::fontDataForCharacters):
+ (WebCore::FontFallbackList::setPlatformFont):
+ * platform/graphics/qt/FontPlatformData.h:
+ (WebCore::FontPlatformData::font):
+ (WebCore::FontPlatformData::size):
+ * platform/graphics/qt/FontPlatformDataQt.cpp: Added.
+ (WebCore::FontPlatformData::FontPlatformData):
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ (WebCore::Font::font):
+ * platform/graphics/qt/FontQt43.cpp: Added. Moved Qt4.3 code from FontQt.cpp
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
+ (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
+ (WebCore::GlyphPageTreeNode::pruneTreeFontData):
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ (WebCore::SimpleFontData::determinePitch):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformGlyphInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::adjustButtonStyle): Avoid crashes.
+
+2008-12-11 Holger Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20953
+
+ For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
+ implementation. This is one of the reasons why the Qt port is currently not
+ using WebCore/platform/graphics/Font.cpp. By allowing to not use
+ the simple/fast-path the Qt port will be able to use it.
+
+ Introduce USE(FONT_FAST_PATH) and define it for every port but the
+ Qt one.
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::drawText):
+ (WebCore::Font::floatWidth):
+ (WebCore::Font::selectionRectForText):
+ (WebCore::Font::offsetForPosition):
+ * platform/graphics/Font.h:
+
+2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20953
+
+ Split out the font fast path from Fast.cpp into FontFastPath.cpp. This
+ will allow the Qt port to share most of WebCore::Font
+ implementation but the fast path. Qt does not provide the API to get
+ individual Glyphs making the fast path hard to support.
+
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * platform/graphics/Font.cpp:
+ * platform/graphics/FontFastPath.cpp: Added.
+ (WebCore::Font::glyphDataForCharacter):
+
+2008-12-11 Robert Carr <racarr@svn.gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22560
+
+ Code in PlatformScreenGtk for screenDepth and screenRect can not
+ assume that the platformWindow for the widget has a valid "window"
+ member. For example in the case of, a new browser view opening as a
+ child of a GtkNotebook, but never being switched to, or manually
+ realized. Solve by using the toplevel window of the widget, rather
+ than the widget itself.
+
+ * platform/gtk/PlatformScreenGtk.cpp:
+ (WebCore::screenDepth):
+ (WebCore::screenRect):
+
+2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Darin Adler and Holger Freyther.
+
+ Make Widget::frameRectsChanged() and overrides non-const
+
+ This will hopefully allow us to get rid of some of the mutables in
+ the classes that react to the callback by changing their own state.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::frameRectsChanged):
+ * platform/ScrollView.h:
+ * platform/Widget.h:
+ (WebCore::Widget::frameRectsChanged):
+ * platform/gtk/ScrollbarGtk.cpp: Remove non-const version since
+ this was more complex and did the same thing, changed const of
+ the leftover frameRectsChanged() method.
+ (ScrollbarGtk::frameRectsChanged):
+ * platform/gtk/ScrollbarGtk.h:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::frameRectsChanged):
+ * plugins/PluginView.h:
+
+2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed and implemented with Tor Arne Vestbø.
+
+ Reimplement RenderTheme::caretBlinkInterval for Qt.
+
+ The QApplication::cursorFlashTime is in milliseconds and describes
+ the whole cycle while WebCore expects half a cycle.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::caretBlinkInterval):
+ * platform/qt/RenderThemeQt.h:
+
+2008-12-09 Trenton Schulz <trenton.schulz@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt/Mac] Don't call HIGetScaleFactor() if we're not on Tiger or better
+
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::tigerOrBetter):
+ (WebCore::PluginView::globalMousePosForPlugin):
+
+2008-12-10 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Eric Seidel and George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22799
+
+ Add WML <template> support. The <template> element is specified at deck-level
+ and declares a template for all <card> elements in the document.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * editing/htmlediting.cpp:
+ (WebCore::canHaveChildrenForEditing): Treat <do> just like a <button>.
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::setTemplateElement):
+ (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
+ (WebCore::WMLCardElement::handleDeckLevelTaskOverridesIfNeeded):
+ * wml/WMLCardElement.h:
+ (WebCore::WMLCardElement::templateElement):
+ * wml/WMLDoElement.cpp:
+ (WebCore::WMLDoElement::insertedIntoDocument):
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing):
+ * wml/WMLErrorHandling.cpp:
+ (WebCore::errorMessageForErrorCode):
+ * wml/WMLErrorHandling.h:
+ (WebCore::):
+ * wml/WMLEventHandlingElement.cpp:
+ (WebCore::WMLEventHandlingElement::~WMLEventHandlingElement):
+ * wml/WMLEventHandlingElement.h:
+ (WebCore::WMLEventHandlingElement::doElements):
+ * wml/WMLTagNames.in:
+ * wml/WMLTemplateElement.cpp: Added.
+ (WebCore::WMLTemplateElement::WMLTemplateElement):
+ (WebCore::WMLTemplateElement::~WMLTemplateElement):
+ (WebCore::WMLTemplateElement::parseMappedAttribute):
+ (WebCore::WMLTemplateElement::registerTemplatesInDocument):
+ * wml/WMLTemplateElement.h: Added.
+ * wml/WMLTimerElement.cpp:
+ (WebCore::WMLTimerElement::timerFired):
+
+2008-12-09 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fix memory leak - need to call stopActiveDOMObjects
+ when cached pages get destroyed.
+ https://bugs.webkit.org/show_bug.cgi?id=22753
+
+ * dom/Document.cpp:
+ (WebCore::Document::detach):
+
+2008-12-10 Alice Liu <alice.liu@apple.com>
+
+ Manual test for https://bugs.webkit.org/show_bug.cgi?id=20685
+
+ Reviewed by Darin Adler.
+
+ * manual-tests/drag-image-to-desktop.html: Added.
+
+2008-12-10 Alice Liu <alice.liu@apple.com>
+
+ fixed https://bugs.webkit.org/show_bug.cgi?id=20685
+
+ Reviewed by Darin Adler.
+
+ Manual test case is manual-tests/drag-image-to-desktop.html
+
+ Added new files to projects
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+
+ * page/DragController.cpp:
+ (WebCore::DragController::startDrag):
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedImageMIMETypes):
+ (WebCore::initializeSupportedImageMIMETypesForEncoding):
+
+ These changes add a method to obtain the extension for an image
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::filenameExtension):
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/Image.h:
+ (WebCore::Image::filenameExtension):
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::filenameExtension):
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::filenameExtension):
+
+ These changes added a utility that returns the preferred extension for a UTI
+ * platform/graphics/cg/ImageSourceCG.h: Added.
+ * platform/graphics/cg/ImageSourceCGMac.mm: Added.
+ (WebCore::MIMETypeForImageSourceType):
+ (WebCore::preferredExtensionForImageSourceType):
+ * platform/graphics/cg/ImageSourceCGWin.cpp: Added.
+ (WebCore::MIMETypeForImageSourceType):
+ (WebCore::preferredExtensionForImageSourceType):
+
+ * platform/mac/MIMETypeRegistryMac.mm:
+ moved getMIMETypeForUTI to ImageSourceCGMac.mm
+
+ Ask image for its file extension instead of relying on MIME type and file path
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::createGlobalImageFileDescriptor):
+
+ Remove extraneous code from getPreferredExtensionForMIMEType.
+ Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
+ * platform/win/MIMETypeRegistryWin.cpp:
+ (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
+
+2008-12-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ <rdar://problem/6431224>
+
+ When updating the value of a slider, don't mark the parents
+ as needing layout, because the size of the slider can never
+ change. This fixes full-page repaints in some cases.
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::updateFromElement):
+
+2008-12-10 Simon Fraser <simon.fraser@apple.com>
+
+ Potential build fix. The forward declaration of FloatPoint should
+ be inside the WebCore namespace.
+
+ * platform/graphics/FloatPoint3D.h:
+
+2008-12-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22793
+
+ Cleanup FloatPoint3D: inline the getters and setters,
+ fix a potential divide-by-zero in normalize(), and add
+ a FloatPoint constructor.
+
+ * platform/graphics/FloatPoint3D.cpp:
+ (WebCore::FloatPoint3D::FloatPoint3D):
+ (WebCore::FloatPoint3D::normalize):
+ * platform/graphics/FloatPoint3D.h:
+ (WebCore::FloatPoint3D::x):
+ (WebCore::FloatPoint3D::setX):
+ (WebCore::FloatPoint3D::y):
+ (WebCore::FloatPoint3D::setY):
+ (WebCore::FloatPoint3D::z):
+ (WebCore::FloatPoint3D::setZ):
+
+2008-12-09 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
+ https://bugs.webkit.org/show_bug.cgi?id=22665
+
+ - Removed setCreatedByParser from style and link elements.
+
+ - Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
+
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizer.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::startElementNs):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseStartElement):
+ * html/HTMLElementFactory.cpp:
+ (WebCore::linkConstructor):
+ (WebCore::styleConstructor):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::HTMLLinkElement):
+ * html/HTMLLinkElement.h:
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::HTMLStyleElement):
+ * html/HTMLStyleElement.h:
+ * html/HTMLTagNames.in:
+ * svg/SVGStyleElement.cpp:
+ (WebCore::SVGStyleElement::SVGStyleElement):
+ * svg/SVGStyleElement.h:
+ * svg/svgtags.in:
+
+2008-12-10 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin
+
+ https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/6388378> -
+ Dialog when going back to a page from whence you submitted a form
+
+ http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
+ http requests, which caused the networking layer to have an incomplete set of headers
+ just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
+ us believe we'd be resubmitting the form.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by
+ the Origin header mechanism as discussed in bug 22194, restore the previous behavior of
+ setting all the headers before the networking layer is asked about the cache lookup.
+
+2008-12-10 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Add back ability to end all profiling via console by invoking profileEnd
+ with no arguments.
+
+ * page/Console.cpp:
+ (WebCore::Console::profileEnd): Removed title null-checking and
+ subsequent early exit.
+
+2008-12-10 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Darin Adler.
+
+ KeyframeAnimation::animate() needs to compute the elapsed animation time
+ properly taking into account its paused state.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22773
+
+ Test: animations/animation-drt-api-multiple-keyframes.html
+
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+
+2008-12-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Part of
+ https://bugs.webkit.org/show_bug.cgi?id=22570
+
+ Rename methods on RenderLayer for clarity:
+ clearClipRects -> clearClipRectsIncludingDescendants
+ clearClipRect -> clearClipRects
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::destroy):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::removeOnlyThisLayer):
+ (WebCore::RenderLayer::insertOnlyThisLayer):
+ (WebCore::RenderLayer::clearClipRectsIncludingDescendants):
+ (WebCore::RenderLayer::clearClipRects):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy):
+
+2008-12-10 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix after the script call stack/frame additions.
+
+ * WebCoreSources.bkl:
+
+2008-12-10 Srinivasa Rao M. Hamse <msrinirao@gmail.com>
+
+ Reviewed by Holger Freyther.
+
+ F1-F12 key mappings for WebKit Gtk Port
+
+ * platform/gtk/KeyEventGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+
+2008-12-10 Enrico Ros <enrico.ros@m31.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the Qt build when SVG is disabled. A broken dependancy caused
+ unnecessary rebuilds even with no changes.
+
+ * WebCore.pro: fix a broken build dependancy
+
+2008-12-10 Hironori Bono <hbono@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
+ https://bugs.webkit.org/show_bug.cgi?id=21820
+
+ <rdar://problem/5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
+ <rdar://problem/5702038> Backspace removes Thai Character in wrong sequence
+
+ Tests: editing/deleting/delete-ligature-001.html
+ editing/deleting/delete-ligature-002.html
+ editing/deleting/delete-ligature-003.html
+
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed): Delete only the last character
+ of a ligature which consists of multiple Unicode characters when deleting it with
+ a backspace key.
+
+2008-12-10 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22177
+ Fix the windows build by removing calls to notifyFormStateChanged
+ where they didn't appear in the original reviewed patch.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::type):
+ (WebCore::HTMLInputElement::attach):
+
+2008-12-09 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Add ScriptController::updateSecurityOrigin to notify the bindings
+ that a document's securityOrigin has been updated. This is used by
+ V8 to update its security context.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::updateSecurityOrigin):
+ * bindings/js/ScriptController.h:
+ * dom/Document.cpp:
+ (WebCore::Document::setDomain):
+
+2008-12-09 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Fix a few config issues to let the Chromium Windows WebCore build get further.
+
+ * WebCore.scons:
+
+2008-12-09 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22177
+
+ Add a callback on ChromeClient that the state of form elements on
+ the page has changed. This is to allow clients implementing session
+ saving to know when the current state is dirty.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::notifyFormStateChanged):
+ (WebCore::HTMLInputElement::setInputType):
+ (WebCore::HTMLInputElement::type):
+ (WebCore::HTMLInputElement::attach):
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ (WebCore::HTMLInputElement::setFileListFromRenderer):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setSelectedIndex):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::notifyFormStateChanged):
+ (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
+ (WebCore::HTMLTextAreaElement::updateValue):
+ (WebCore::HTMLTextAreaElement::setValue):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::formStateDidChange):
+ * page/ChromeClient.h:
+
+2008-12-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19762
+
+ Fix intermittent crash in buildbot. The CSSCursorImageValues and
+ SVGCursorElements held onto raw SVGElement pointers without any
+ guarantee that the element is still around.
+
+ We did not fix the design that resulted in this issue, we just fixed
+ the pointer lifetimes.
+
+ * css/CSSCursorImageValue.cpp:
+ (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers.
+ (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer.
+ (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element
+ is destroyed.
+ * css/CSSCursorImageValue.h: Added removeReferencedElement.
+
+ * svg/SVGCursorElement.cpp:
+ (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers.
+ (WebCore::SVGCursorElement::addClient): Set up a back pointer.
+ (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::SVGElement): Initialize back pointers to zero.
+ (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value
+ to remove the element from their sets.
+ * svg/SVGElement.h:
+ (WebCore::SVGElement::setCursorElement): Added.
+ (WebCore::SVGElement::setCursorImageValue): Added.
+
+2008-12-09 David Hyatt <hyatt@apple.com>
+
+ Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
+ frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
+ yet as you switch from page to page (until they are destroyed and recreated).
+
+ Reviewed by Adele
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+
+2008-12-09 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22689
+ Match Firefox button metrics on Windows.
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::addChild):
+ (WebCore::RenderButton::styleDidChange):
+ (WebCore::RenderButton::setupInnerStyle):
+ * rendering/RenderButton.h:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustButtonInnerStyle):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::adjustSliderThumbSize):
+ (WebCore::RenderThemeWin::adjustButtonInnerStyle):
+ * rendering/RenderThemeWin.h:
+
+2008-12-09 Darin Fisher <darin@chromium.org>
+
+ Fixes bustages.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22631
+ Adding missing files from previous commit.
+
+ * bindings/js/ScriptCallFrame.cpp: Added.
+ (WebCore::ScriptCallFrame::ScriptCallFrame):
+ (WebCore::ScriptCallFrame::~ScriptCallFrame):
+ (WebCore::ScriptCallFrame::argumentAt):
+ * bindings/js/ScriptCallFrame.h: Added.
+ (WebCore::ScriptCallFrame::functionName):
+ (WebCore::ScriptCallFrame::sourceURL):
+ (WebCore::ScriptCallFrame::lineNumber):
+ (WebCore::ScriptCallFrame::argumentCount):
+ * bindings/js/ScriptCallStack.cpp: Added.
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::~ScriptCallStack):
+ (WebCore::ScriptCallStack::at):
+ (WebCore::ScriptCallStack::size):
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptCallStack.h: Added.
+ (WebCore::ScriptCallStack::state):
+
+2008-12-09 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22631
+ Streamline Console.cpp, abstract out the use of JSC::ExecState and
+ JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
+ abstractions.
+
+ * GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
+ * WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
+ * WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and
+ ScriptCallStack to project
+ * WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and
+ ScriptCallStack to project
+ * bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
+ * bindings/js/ScriptCallFrame.cpp: Added.
+ (WebCore::ScriptCallFrame::ScriptCallFrame):
+ (WebCore::ScriptCallFrame::~ScriptCallFrame):
+ (WebCore::ScriptCallFrame::argumentAt):
+ * bindings/js/ScriptCallFrame.h: Added.
+ (WebCore::ScriptCallFrame::functionName):
+ (WebCore::ScriptCallFrame::sourceURL):
+ (WebCore::ScriptCallFrame::lineNumber):
+ (WebCore::ScriptCallFrame::argumentCount):
+ * bindings/js/ScriptCallStack.cpp: Added.
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::~ScriptCallStack):
+ (WebCore::ScriptCallStack::at):
+ (WebCore::ScriptCallStack::size):
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptCallStack.h: Added.
+ (WebCore::ScriptCallStack::ScriptCallStack):
+ (WebCore::ScriptCallStack::~ScriptCallStack):
+ (WebCore::ScriptCallStack::state):
+ (WebCore::ScriptCallStack::at):
+ (WebCore::ScriptCallStack::size):
+ (WebCore::ScriptCallStack::initialize):
+ * bindings/js/ScriptString.h: Added missing PlatformString include.
+ (WebCore::ScriptString::ScriptString): Added default constructor.
+ (WebCore::ScriptString::operator==): Added equality operator.
+ (WebCore::ScriptString::operator!=):
+ * bindings/js/ScriptValue.cpp: Added isNull and isUndefined.
+ (WebCore::ScriptValue::isNull):
+ (WebCore::ScriptValue::isUndefined):
+ * bindings/js/ScriptValue.h: Added isNull and isUndefined
+ * bindings/scripts/CodeGeneratorJS.pm: Add handling for
+ CustomArgumentHandling attribute.
+ * inspector/InspectorController.cpp: Refactored to use
+ ScriptCallFrame and ScriptCallStack.
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::InspectorController::addMessageToConsole):
+ (WebCore::InspectorController::startGroup):
+ (WebCore::InspectorController::addScriptConsoleMessage):
+ (WebCore::InspectorController::count):
+ (WebCore::InspectorController::startTiming):
+ (WebCore::InspectorController::stopTiming):
+ * inspector/InspectorController.h: Refactored to use ScriptCallFrame and
+ ScriptCallStack.
+ * inspector/front-end/Console.js: Modified to use argument value itself
+ rather than f.name for stack trace.
+ * page/Console.cpp: Refactored to use ScriptCallFrame and
+ ScriptCallStack.
+ (WebCore::getFirstArgumentAsString):
+ (WebCore::Console::addMessage):
+ (WebCore::Console::debug):
+ (WebCore::Console::error):
+ (WebCore::Console::info):
+ (WebCore::Console::log):
+ (WebCore::Console::dir):
+ (WebCore::Console::dirxml):
+ (WebCore::Console::trace):
+ (WebCore::Console::assertCondition):
+ (WebCore::Console::count):
+ (WebCore::Console::profile):
+ (WebCore::Console::profileEnd):
+ (WebCore::Console::time):
+ (WebCore::Console::timeEnd):
+ (WebCore::Console::group):
+ (WebCore::Console::warn):
+ * page/Console.h:
+ * page/Console.idl: Removed Custom attributes, added
+ CustomArgumentHandling attributes, and tweaked argument defs.
+
+2008-12-09 Darin Adler <darin@apple.com>
+
+ Try to fix non-Mac builds.
+
+ * GNUmakefile.am: Added NavigatorBase.
+ * WebCore.pro: Ditto.
+ * WebCore.scons: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ Unrelated tweak sitting in my tree.
+
+ * bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
+
+2008-12-09 Darin Adler <darin@apple.com>
+
+ Try to fix Tiger build.
+
+ * platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
+
+2008-12-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22719
+ Implement Navigator object in Workers
+
+ Test: fast/workers/worker-navigator.html
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ Added WorkerNavigator sources.
+
+ * bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator):
+ Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec,
+ but it is not the same interface that is available on Windows).
+
+ * dom/Worker.cpp:
+ (WebCore::Worker::notifyFinished):
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::WorkerContext):
+ (WebCore::WorkerContext::navigator):
+ * dom/WorkerContext.h:
+ (WebCore::WorkerContext::create):
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::create):
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::workerThread):
+ * dom/WorkerThread.h:
+ Pass a pre-computed user agent string into worker, because it cannot call a client method
+ directly, and pre-computing is easier than sending a synchronous message to the main thread.
+
+ * page/Navigator.cpp:
+ * page/Navigator.h:
+ * page/NavigatorBase.cpp: Added.
+ * page/NavigatorBase.h: Added.
+ Factor out common (and uncommon, but very similar) functionality into a base class.
+
+ * page/WorkerNavigator.cpp: Added.
+ * page/WorkerNavigator.h: Added.
+ * page/WorkerNavigator.idl: Added.
+ Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
+
+ * platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier):
+ Make networkStateNotifier() static constructor thread safe. The object is created on the
+ thread it is first called from, while callbacks are registered on the main thread. Calls to
+ onLine() from other threads are safe, because it is just loading a boolean.
+
+ * platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
+ Schedule notifications on main event loop, not the current one.
+
+2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Forgot to update Qt/WML build - add some new files to the build.
+
+ * WebCore.pro:
+
+2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22637
+
+ Implement the GET method for WMLGoElement, and some test covering it's behaviour.
+ Update all build systems supporting WML that haven't been updated since a while.
+
+ Add WMLPostField stub implementation, needed for implementing POST method.
+
+ Tests: wml/go-task-get-method-external-deck-with-href.html
+ wml/go-task-get-method-external-deck.html
+ wml/go-task-get-method-same-deck.html
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Document.cpp:
+ (WebCore::Document::resetWMLPageState):
+ * wml/WMLCardElement.cpp:
+ * wml/WMLCardElement.h:
+ * wml/WMLEventHandlingElement.cpp:
+ (WebCore::WMLCardElement::registerDoElement):
+ * wml/WMLEventHandlingElement.h:
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::WMLGoElement):
+ (WebCore::WMLGoElement::registerPostfieldElement):
+ (WebCore::WMLGoElement::parseMappedAttribute):
+ (WebCore::WMLGoElement::executeTask):
+ (WebCore::WMLGoElement::parseContentType):
+ (WebCore::WMLGoElement::preparePOSTRequest):
+ (WebCore::WMLGoElement::prepareGETRequest):
+ * wml/WMLGoElement.h:
+ * wml/WMLPostfieldElement.cpp: Added.
+ (WebCore::WMLPostfieldElement::WMLPostfieldElement):
+ (WebCore::WMLPostfieldElement::parseMappedAttribute):
+ (WebCore::WMLPostfieldElement::insertedIntoDocument):
+ * wml/WMLPostfieldElement.h: Added.
+ (WebCore::WMLPostfieldElement::name):
+ (WebCore::WMLPostfieldElement::value):
+ * wml/WMLTagNames.in:
+
+2008-12-08 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16814
+ Allow ports to disable ActiveX->NPAPI conversion for Media Player.
+ Improve handling of miscellaneous ActiveX objects.
+
+ * rendering/RenderPartObject.cpp:
+ (WebCore::mapClassIdToServiceType):
+ (WebCore::shouldUseChildEmbedOfObject):
+ (WebCore::RenderPartObject::updateWidget):
+
+2008-12-08 Darin Adler <darin@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=22409
+ REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
+
+ Tests: editing/execCommand/enabling-and-selection-2.html
+ editing/execCommand/enabling-and-selection.html
+
+ * editing/EditorCommand.cpp: Updated table to use these functions by their new names.
+ (WebCore::enabledVisibleSelection): Renamed this to reflect its new algorithm.
+ An invisible selection with a position that selects no characters doesn't count
+ as a visible selection.
+ (WebCore::enabledVisibleSelectionAndMark): Ditto.
+
+2008-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Remove duplicate entries from WebCore project.
+
+ Reviewed by Eric Seidel.
+
+ Bug 22555: Sort "children" sections in Xcode project files.
+ <https://bugs.webkit.org/show_bug.cgi?id=22555>
+
+ Recipe for removing duplicates:
+ $ ./WebKitTools/Scripts/sort-Xcode-project-file project.pbxproj
+ $ uniq < project.pbxproj | diff -u project.pbxproj - | patch -p0 project.pbxproj
+
+ * WebCore.xcodeproj/project.pbxproj: Removed duplicates.
+
+2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
+ https://bugs.webkit.org/show_bug.cgi?id=22665
+
+ Remove setCreatedByParser from the script elements (HTML and SVG).
+
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): Removed
+ call to setCreatedByParser for the 2 elements.
+
+ * dom/make_names.pl: Modified to call the constructor with
+ the createByParser parameter if 'constructorNeedsCreatedByParser'
+ is set.
+
+ * html/HTMLElementFactory.cpp:
+ (WebCore::scriptConstructor):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::HTMLScriptElement):
+ * html/HTMLScriptElement.h:
+ * html/HTMLTagNames.in: Added constructorNeedsCreatedByParser
+ to script.
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::SVGScriptElement):
+ * svg/SVGScriptElement.h:
+ * svg/svgtags.in: Added constructorNeedsCreatedByParser
+ to script.
+
+2008-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22555: Sort "children" sections in Xcode project files
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22555>
+
+ Reviewed by Eric Seidel.
+
+ * WebCore.xcodeproj/project.pbxproj: Sorted.
+ * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Sorted.
+
+2008-12-08 Tony Chang <tony@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add a bool to GraphicsContext so that shadows can ignore
+ transformations. This is needed by HTML canvas element
+ where the spec says shadows are applied w/o transformations.
+ https://bugs.webkit.org/show_bug.cgi?id=22580
+
+ No functional changes, thus no tests.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setShadow):
+ (WebCore::CanvasRenderingContext2D::applyShadow):
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::createImageBuffer):
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsContextPrivate.h:
+ (WebCore::GraphicsContextState::GraphicsContextState):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::setPlatformShadow):
+
+2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 17897: Not Rendering Images Imported from XHTML Document
+ <rdar://problem/5827614>
+
+ When we were loading document with XMLHttpRequest that contained images, the images
+ would not be fetched as they would not be displayed. However if we inserted such
+ an image element into a rendered document, we would not fetch the image and thus never
+ display it.
+
+ Now we check if the image has been loaded when we insert an HTMLImageElement into a
+ document.
+ To enable this, the image loader has an error flag. To avoid doing several attempts
+ when we know that the image is in error, we store the failed URL.
+ However Firefox and Opera ignore errors when the 'src' attribute changes and thus
+ we also have an updateFromElementIgnoringPreviousError to match the other browser.
+
+ Tests: http/tests/misc/image-blocked-src-change.html
+ http/tests/misc/image-blocked-src-no-change.html
+ http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
+ http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html
+
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute): Ditto.
+ (WebCore::HTMLImageElement::insertedIntoDocument): Call updateFromElement if we do not have
+ an image.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::setImage): Added an assertion.
+ (WebCore::ImageLoader::updateFromElement): Added a check for load error (to avoid displaying
+ multiple errors in the console for a single image load).
+
+ (WebCore::ImageLoader::updateFromElementIgnoringPreviousError): This method clears previous error
+ before calling updateFromElement.
+
+ (WebCore::ImageLoader::notifyFinished): Added an assertion.
+ * loader/ImageLoader.h:
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::svgAttributeChanged): Changed to call updateFromElementIgnoringPreviousError.
+
+2008-12-08 David Hyatt <hyatt@apple.com>
+
+ Make scrollbar creation virtual on ScrollView so that FrameView can have the capability to create
+ custom CSS scrollbars.
+
+ Reviewed by Eric Seidel
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::setHasVerticalScrollbar):
+ (WebCore::ScrollView::createScrollbar):
+ * platform/ScrollView.h:
+
+2008-12-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - WebCore part of tracking the global history item for a WebView
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set the page's
+ global history item to the current back/forward list item, respecting
+ private browsing mode.
+ (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto in this
+ case.
+ (WebCore::FrameLoader::goToItem): Ditto in this case.
+ (WebCore::FrameLoader::updateHistoryForStandardLoad): If this load
+ creates a new global history item, set the page's global history item
+ to it.
+ (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
+ Ditto.
+ * page/Page.cpp:
+ (WebCore::Page::setGlobalHistoryItem): Added this setter.
+ * page/Page.h: Added a m_globalHistoryItem data member.
+ (WebCore::Page::globalHistoryItem): Added this getter.
+
+2008-12-08 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Kilzer.
+
+ A few stylistic fixes suggested by Dave Kilzer.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::createIdentifier):
+ (WebCore::CSSPrimitiveValue::create):
+
+2008-12-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22737
+ Try debug version when locating CFNetwork
+
+ * platform/network/cf/ResourceRequestCFNet.cpp:
+ (WebCore::findCFNetworkModule):
+ (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
+ (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
+ * platform/network/win/CookieJarCFNetWin.cpp:
+ (WebCore::findCFNetworkModule):
+ (WebCore::findIsHTTPOnlyFunction):
+
+2008-12-08 Aaron Boodman <aa@chromium.org>
+
+ Reviewed by Stephanie Lewis.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22301
+ Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::finishedParsing):
+
+2008-12-08 Trenton Schulz <trenton.schulz@nokia.com>
+
+ Rubber-stamped by Tor Arne Vestbø.
+
+ Fix build warning on Mac
+
+ * platform/text/mac/StringImplMac.mm:
+
+2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData to RegExp
+ constructor.
+
+2008-12-08 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Bug 22398: r39059: Crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler
+ <rdar://problem/6426245> REGRESSION(r39059): Reproducible crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler (22398)
+
+ This regression was caused by r39059 replacing the protector on the active
+ animation with a protector on just the composition. It turns out that both
+ protectors are necessary.
+
+ Test: transitions/transition-duration-cleared-in-transitionend-crash.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::animationTimerCallbackFired):
+
+2008-12-08 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22732
+ Remove unused files PausedTimeouts.h,.cpp
+ The change that deprecated this code was https://bugs.webkit.org/show_bug.cgi?id=22620
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.scons:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ These are build files which had PausedTimeouts referenced.
+
+ * bindings/js/PausedTimeouts.cpp: Removed.
+ * bindings/js/PausedTimeouts.h: Removed.
+ * bindings/js/ScriptController.cpp: Removed '#include'
+ * page/Chrome.cpp: Removed '#include' and unused variable.
+
+2008-12-07 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22594
+
+ Fix issues which break reading inline style for -webkit-transition
+ and -webkit-transform-origin.
+
+ Test: fast/css/transform-inline-style.html
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Add cases
+ for CSSPropertyWebkitTransformOrigin and CSSPropertyWebkitTransition
+ so that these shorthand properties are returned correctly.
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseAnimationProperty): Create CSSPrimitiveValues
+ with the correct CSSValueAll and CSSValueNone identifiers, not the
+ RenderStyle-level cAnimateAll, cAnimateNone.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapAnimationProperty): Special-case CSSValueAll
+ and CSSValueNone values to set cAnimateAll and cAnimateNone transition properties.
+
+2008-12-07 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22717
+ Make CSS values use less memory
+
+ Share CSSPrimitiveValue objects for commonly used values including
+ - idents
+ - colors
+ - small integers
+
+ This reduces the amount CSSPrimitiveValue instances by > 80%.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::createIdentifier):
+ (WebCore::CSSPrimitiveValue::createColor):
+ (WebCore::CSSPrimitiveValue::create):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::create):
+
+2008-12-07 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22717
+ Make CSS values use less memory
+
+ Get CSSValues off from the common StyleBase base class. They don't
+ need a parent pointer or anything else there and there is no real
+ reason to have them in same data structures with other CSSOM objects.
+
+ Disabled (instead of refactoring around the lack of common base) the ability
+ to have style declaration blocks as CSS variable values. They don't exist in
+ the spec so I wasn't sure if they have future or not. It would not be hard to
+ get them back. CSS variables are in any case an experimental feature and
+ not enabled by default.
+
+ * css/CSSInitialValue.h:
+ (WebCore::CSSInitialValue::createExplicit):
+ (WebCore::CSSInitialValue::createImplicit):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::addVariableDeclarationBlock):
+ * css/CSSParser.h:
+ * css/CSSValue.h:
+ (WebCore::CSSValue::~CSSValue):
+ (WebCore::CSSValue::parserValue):
+ * css/CSSVariablesDeclaration.cpp:
+ (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
+ (WebCore::CSSVariablesDeclaration::getVariableValue):
+ (WebCore::CSSVariablesDeclaration::removeVariable):
+ (WebCore::CSSVariablesDeclaration::addParsedVariable):
+ (WebCore::CSSVariablesDeclaration::getParsedVariable):
+ (WebCore::CSSVariablesDeclaration::getParsedVariableDeclarationBlock):
+ * css/CSSVariablesDeclaration.h:
+ (WebCore::CSSVariablesDeclaration::create):
+ * css/StyleBase.h:
+
+2008-12-07 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Add gradient and pattern support for strokeRect on canvas/Cg.
+
+ Canvas strokeRect() doesn't support gradients
+ https://bugs.webkit.org/show_bug.cgi?id=19790
+
+ Test: fast/canvas/canvas-strokeRect.html
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::strokeRect):
+
+2008-12-06 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Add support for setTransform() in canvas.
+
+ <canvas> lacks transform() and setTransform()
+ https://bugs.webkit.org/show_bug.cgi?id=16604
+
+ Test: fast/canvas/canvas-setTransform.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::State::State):
+ (WebCore::CanvasRenderingContext2D::setStrokeStyle):
+ (WebCore::CanvasRenderingContext2D::setFillStyle):
+ (WebCore::CanvasRenderingContext2D::scale):
+ (WebCore::CanvasRenderingContext2D::rotate):
+ (WebCore::CanvasRenderingContext2D::translate):
+ (WebCore::CanvasRenderingContext2D::transform):
+ (WebCore::CanvasRenderingContext2D::setTransform):
+ (WebCore::CanvasRenderingContext2D::beginPath):
+ (WebCore::CanvasRenderingContext2D::closePath):
+ (WebCore::CanvasRenderingContext2D::moveTo):
+ (WebCore::CanvasRenderingContext2D::lineTo):
+ (WebCore::CanvasRenderingContext2D::quadraticCurveTo):
+ (WebCore::CanvasRenderingContext2D::bezierCurveTo):
+ (WebCore::CanvasRenderingContext2D::arcTo):
+ (WebCore::CanvasRenderingContext2D::arc):
+ (WebCore::CanvasRenderingContext2D::rect):
+ (WebCore::CanvasRenderingContext2D::fill):
+ (WebCore::CanvasRenderingContext2D::stroke):
+ (WebCore::CanvasRenderingContext2D::clip):
+ (WebCore::CanvasRenderingContext2D::isPointInPath):
+ (WebCore::CanvasRenderingContext2D::clearRect):
+ (WebCore::CanvasRenderingContext2D::fillRect):
+ (WebCore::CanvasRenderingContext2D::strokeRect):
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ (WebCore::CanvasRenderingContext2D::drawImageFromRect):
+ (WebCore::CanvasRenderingContext2D::willDraw):
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ * html/CanvasRenderingContext2D.h:
+ * html/CanvasRenderingContext2D.idl:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::baseTransform):
+ * html/HTMLCanvasElement.h:
+ * platform/graphics/ImageBuffer.h:
+ (WebCore::ImageBuffer::baseTransform):
+
+2008-12-06 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Also copy m_implicit field. Darin wanted this change commited separately.
+
+ * css/CSSProperty.h:
+ (WebCore::CSSProperty::operator=):
+
+2008-12-06 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22379
+ Make CSSOM use less memory
+
+ Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
+
+ Taught setter functions to use existing slots to avoid memory moves, plus some
+ other optimizations.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
+ (WebCore::CSSMutableStyleDeclaration::operator=):
+ (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
+ (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
+ (WebCore::CSSMutableStyleDeclaration::removeProperty):
+ (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
+ (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
+ (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
+ (WebCore::CSSMutableStyleDeclaration::setProperty):
+ (WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
+ (WebCore::CSSMutableStyleDeclaration::setStringProperty):
+ (WebCore::CSSMutableStyleDeclaration::setImageProperty):
+ (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
+ (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
+ (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
+ (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
+ (WebCore::CSSMutableStyleDeclaration::length):
+ (WebCore::CSSMutableStyleDeclaration::item):
+ (WebCore::CSSMutableStyleDeclaration::cssText):
+ (WebCore::CSSMutableStyleDeclaration::setCssText):
+ (WebCore::CSSMutableStyleDeclaration::merge):
+ (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
+ (WebCore::CSSMutableStyleDeclaration::copy):
+ (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
+ * css/CSSMutableStyleDeclaration.h:
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator*):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator->):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator==):
+ (WebCore::CSSMutableStyleDeclaration::create):
+ (WebCore::CSSMutableStyleDeclaration::begin):
+ (WebCore::CSSMutableStyleDeclaration::end):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator=):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator++):
+ (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
+ * css/CSSProperty.h:
+ (WTF::):
+ * css/CSSStyleDeclaration.cpp:
+ (WebCore::CSSStyleDeclaration::diff):
+ (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
+ (WebCore::CSSStyleSelector::applyDeclarations):
+ * dom/EventTarget.h:
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::StyleChange::init):
+ (WebCore::ApplyStyleCommand::isHTMLStyleNode):
+ (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
+ (WebCore::ApplyStyleCommand::removeCSSStyle):
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectionStartHasStyle):
+ (WebCore::updateState):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::handleStyleSpans):
+ * editing/markup.cpp:
+ (WebCore::appendStartMarkup):
+
+2008-12-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto, Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22088
+
+ Fix logic related to repainting when transform changes:
+ If an object has a layer, and the transform changes, then we need
+ to do a repaintIncludingDescendants(), not just a repaint.
+
+ Test: fast/repaint/transform-repaint-descendants.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+
+2008-12-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=15739
+
+ When painting the selection on a replaced element, paint
+ using local coordinates so that the selection is correctly
+ painted for transformed elements.
+
+ Test: fast/replaced/selection-rect-transform.html
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::paint):
+
+2008-12-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=15671
+
+ Fix caret rendering to behave correctly with transforms:
+ * Rename caretRect() methods to localCaretRect() and
+ absoluteCaretBounds() as appropriate
+ * Fix localCaretRect() methods to return a rect in the
+ appropriate coordinates.
+ * Pass tx, ty down through the paintCaret() methods, after fixing them
+ up to account for differences between contents coords, and renderer-local
+ coords (via RenderBlock::offsetForContents()).
+ * Remove m_caretPositionOnLayout from SelectionController, and instead
+ call invalidateSelection() from RenderLayer::scrollToOffset(), because
+ we can no longer assume simple x/y offsets from scrolling with transforms.
+ * Move the logic to compute which RenderObject actually paints the caret into
+ SelectionController::caretRenderer(), rather than having it in RenderBlock.
+ * SelectionController now computes and caches a local caret rect. For invalidation,
+ it computes the absolute bounds of that (possibly transformed) local rect.
+ The local rect is computed in the coordinate system of the RenderObject that
+ will paint the caret (this may require offsetting from the actual renderer
+ at the start of the selection).
+ * Fix LayoutState(RenderObject* root) to take transforms into account
+ * Make offsetFromContainer() a virtual method on RenderObject, and implement
+ the RenderObject version. It's used to map from selection start renderer
+ to caret renderer.
+
+ Test: fast/transforms/transformed-caret.html
+
+ * WebCore.base.exp:
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::mergeParagraphs):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::SelectionController):
+ (WebCore::absoluteCaretY):
+ (WebCore::SelectionController::modify):
+ (WebCore::SelectionController::xPosForVerticalArrowNavigation):
+ (WebCore::SelectionController::layout):
+ (WebCore::SelectionController::caretRenderer):
+ (WebCore::SelectionController::localCaretRect):
+ (WebCore::SelectionController::absoluteCaretBounds):
+ (WebCore::SelectionController::caretRepaintRect):
+ (WebCore::SelectionController::recomputeCaretRect):
+ (WebCore::SelectionController::invalidateCaretRect):
+ (WebCore::SelectionController::paintCaret):
+ (WebCore::SelectionController::caretRendersInsideNode):
+ * editing/SelectionController.h:
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::localCaretRect):
+ (WebCore::VisiblePosition::absoluteCaretBounds):
+ (WebCore::VisiblePosition::xOffsetForVerticalNavigation):
+ * editing/VisiblePosition.h:
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::isContentEditable):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
+ * page/Frame.cpp:
+ (WebCore::Frame::firstRectForRange):
+ (WebCore::Frame::selectionLayoutChanged):
+ (WebCore::Frame::paintCaret):
+ (WebCore::Frame::paintDragCaret):
+ (WebCore::Frame::revealSelection):
+ (WebCore::Frame::revealCaret):
+ * page/Frame.h:
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintCaret):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::positionForCoordinates):
+ (WebCore::RenderBlock::offsetForContents):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localCaretRect):
+ * rendering/RenderBox.h:
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::localCaretRect):
+ * rendering/RenderFlow.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::localCaretRect):
+ * rendering/RenderObject.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::localCaretRect):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::RenderText):
+ (WebCore::RenderText::localCaretRect):
+ * rendering/RenderText.h:
+
+2008-12-06 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22711: Current svn (build 39065) fails to compile
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22711>
+
+ BUILD FIX for r39065: Forgot parentheses after "document".
+
+ Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
+ <https://bugs.webkit.org/show_bug.cgi?id=22666>
+
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed
+ document to document().
+
+2008-12-06 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22710
+ Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
+
+ * bindings/js/DOMTimer.cpp:
+ (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
+
+2008-12-06 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22666>
+
+ Reviewed by Darin Adler.
+
+ When creating a webarchive from WebCore::LegacyWebArchive::create(),
+ HashSet<String>, Vector<KURL> and Vector<String> were all used to
+ store a list of URLs for resources found in the document. Instead
+ use a single ListHashSet<KURL> to store the list and resolve the
+ relative URLs as they're added. We use a new inline method called
+ WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
+ to prevent "null" KURL objects from crashing in the KURL hashing
+ function.
+
+ * WebCore.base.exp: Changed export of
+ WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL>
+ argument instead of a Vector<KURL>.
+
+ * WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private
+ header for use in WebKit.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from
+ addSubresourceURLStrings(). Changed to use ListHashSet<KURL>
+ instead of HashSet<String>. Cleaned up code.
+ * css/CSSStyleSheet.h:
+ (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
+ * css/StyleSheet.h:
+ (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
+
+ * dom/Node.cpp:
+ (WebCore::Node::getSubresourceURLs): Changed to use
+ ListHashSet<KURL> instead of Vector<KURL>. Cleaned up code.
+ * dom/Node.h:
+ (WebCore::Node::getSubresourceURLs): Ditto.
+ (WebCore::Node::addSubresourceAttributeURLs): Renamed from
+ getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL>
+ instead of Vector<String>.
+ (WebCore::addSubresourceURL): Added. Safely adds new KURL objects
+ to a ListHashSet<KURL> object. A "null" KURL object will cause the
+ hash function to crash since it contains a null StringImpl. Used in
+ Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in
+ the style subsystem.
+
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
+ Renamed from getSubresourceAttributeStrings(). Changed to use
+ ListHashSet<KURL> instead of Vector<String>. Use
+ WebCore::addSubresourceURL() to add new KURL objects.
+ * dom/ProcessingInstruction.h: Ditto.
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLBodyElement.h: Ditto.
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLEmbedElement.h: Ditto.
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLImageElement.h: Ditto.
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLInputElement.h: Ditto.
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLLinkElement.h: Ditto.
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLObjectElement.h: Ditto.
+ * html/HTMLParamElement.cpp:
+ (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLParamElement.h: Ditto.
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLScriptElement.h: Ditto.
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLStyleElement.h: Ditto.
+ * html/HTMLTableCellElement.cpp:
+ (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLTableCellElement.h: Ditto.
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
+ * html/HTMLTableElement.h: Ditto.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Changed from using
+ HashSet<String> to ListHashSet<KURL> for tracking unique
+ subresources. Changed from using Vector<KURL> to ListHashSet<KURL>
+ when calling WebCore::Node::getSubresourceURLs(). Cleaned up code.
+
+ * svg/SVGCursorElement.cpp:
+ (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed
+ from getSubresourceAttributeStrings(). Changed to use
+ ListHashSet<KURL> instead of Vector<String>. Use
+ WebCore::addSubresourceURL() to add new KURL objects.
+ * svg/SVGCursorElement.h: Ditto.
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGFEImageElement.h: Ditto.
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGImageElement.h: Ditto.
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
+ * svg/SVGScriptElement.h: Ditto.
+
+2008-12-05 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Make the page group use the proper link hashing functions rather than
+ calling the string hash functions directly. Add Chromium-specfic ifdefs
+ in the visited link computation functions to allow integration.
+
+ * page/PageGroup.cpp:
+ (WebCore::PageGroup::isLinkVisited):
+ (WebCore::PageGroup::addVisitedLink):
+ * platform/LinkHash.cpp:
+ (WebCore::visitedLinkHash):
+ * platform/LinkHash.h:
+
+2008-12-05 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
+ For iteration and end events, previous fixes to prevent the deletion of
+ Animation objects (ref counting and hanging onto a ref during event callbacks)
+ was sufficient to prevent dangling pointers. But start events are sent in
+ the styleAvailable() call, which iterates over CompositeAnimation objects,
+ which are not ref counted. So that object can get destroyed in the event
+ handler while still active. So I added refcounting for CompositeAnimations.
+
+ Additionally, when am iterating over the CompositingAnimation list, it can
+ be deleted, which mutates the list. So I now make one pass over the list
+ building a vector of CompositeAnimation objects that need to be called and
+ then iterate over that vector to make the actual calls.
+
+ Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
+ the Animation objects it owns, I now keep a ref to the CompositeAnimation
+ in the timer callback for the iteration and end events. That means I no
+ longer need to keep a ref to the Animation objects themselves in that timer
+ callback, since the CompositeAnimation already has one.
+
+ Tests: animations/animation-iteration-event-destroy-renderer.html
+ animations/animation-start-event-destroy-renderer.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::animationTimerCallbackFired):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate):
+ (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
+ (WebCore::AnimationControllerPrivate::clear):
+ (WebCore::AnimationControllerPrivate::styleAvailable):
+ (WebCore::AnimationControllerPrivate::updateAnimationTimer):
+ (WebCore::AnimationControllerPrivate::animationTimerFired):
+ (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
+ (WebCore::AnimationControllerPrivate::suspendAnimations):
+ (WebCore::AnimationControllerPrivate::resumeAnimations):
+ (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
+ (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
+ (WebCore::AnimationController::updateAnimations):
+ (WebCore::AnimationController::setAnimationStartTime):
+ (WebCore::AnimationController::setTransitionStartTime):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::animationController):
+ (WebCore::CompositeAnimationPrivate::isWaitingForStyleAvailable):
+ (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
+ (WebCore::CompositeAnimationPrivate::clearRenderer):
+ (WebCore::CompositeAnimation::clearRenderer):
+ (WebCore::CompositeAnimation::animationController):
+ (WebCore::CompositeAnimation::isWaitingForStyleAvailable):
+ * page/animation/CompositeAnimation.h:
+ (WebCore::CompositeAnimation::create):
+
+2008-12-05 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22609: Provide a build-time choice when generating hash tables for properties of built-in DOM objects
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22609>
+ <rdar://problem/6331749>
+
+ Reviewed by Darin Adler.
+
+ Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
+
+ Added back the code that generates a "compact" hash (instead of a
+ perfect hash) as a build-time option using the
+ ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation): Compute the number of elements that will
+ be stored in each hash table and pass it to GenerateHashTable().
+ (GenerateHashTable): Added new second parameter representing the
+ number of elements to store in the compact hash table. Added back
+ code to compute compact hash tables. Generate both hash table sizes
+ and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
+
+2008-12-05 Brett Wilson <brettw@chromium.org>
+
+ Fix build bustage from previous patch.
+
+ * css/CSSSelector.h:
+
+2008-12-05 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Add a missing include for OwnPtr to make CSSSelector compile without
+ precompiled headers.
+
+ * css/CSSSelector.h:
+
+2008-12-05 Finnur Thorarinsson <finnur.webkit@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22579: Providing a function to ScrollbarClient.h which allows us to get at the tickmarks
+ without relying on high-level WebCore types, as requested by Dave Hyatt.
+
+ No functional changes, thus no test cases.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::getTickmarks):
+ * page/FrameView.h:
+ * platform/ScrollbarClient.h:
+
+2008-12-05 Dean Jackson <dino@apple.com>
+
+ Reviewed by David Hyatt.
+
+ Make sure Window event listeners also tell the
+ Document about the event type, so noisy events
+ will be dispatched even if nothing in the document
+ is listening.
+ https://bugs.webkit.org/show_bug.cgi?id=20572
+
+ * dom/Document.cpp:
+ (WebCore::Document::addWindowEventListener):
+
+2008-12-05 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r39026
+
+ * platform/network/cf/ResourceRequestCFNet.cpp:
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ Add some missing .get()s.
+
+2008-12-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Tiger build fix.
+
+ * platform/network/mac/ResourceRequestMac.mm: Define NSUInteger.
+
+2008-12-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
+ in Safari before opening a mail message in Mail
+
+ * platform/mac/WebCoreObjCExtras.mm:
+ (WebCoreObjCFinalizeOnMainThread):
+ Don't call initializeThreading: we now expect the caller to do it, to simplify keeping
+ Tiger and post-Tiger behavior in line.
+
+ * bindings/objc/DOMRGBColor.mm:
+ (+[DOMRGBColor initialize]):
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebScriptObject initialize]):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (+[AccessibilityObjectWrapper initialize]):
+ * platform/mac/SharedBufferMac.mm:
+ (+[WebCoreSharedBufferData initialize]):
+ Call JSC::initializeThreading();
+
+2008-12-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
+
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/cf/ResourceRequestCFNet.cpp:
+ (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
+ (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
+ (WebCore::setContentDispositionEncodingFallbackArray):
+ (WebCore::copyContentDispositionEncodingFallbackArray):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ * platform/network/mac/ResourceRequestMac.mm:
+ (WebCore::ResourceRequest::doUpdateResourceRequest):
+ (WebCore::ResourceRequest::doUpdatePlatformRequest):
+ Added a way to specify encoding fallback list for Content-Disposition header.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Generate and
+ pass a list of encodings to try when decoding Content-Disposition header, as described
+ in comments.
+
+2008-12-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22672
+ ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout
+
+ Test: http/tests/xmlhttprequest/send-on-abort.html
+
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
+ (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
+ (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
+ (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
+ Add a comment explaining that ActiveDOMObject methods shouldn't execute arbitrary JS.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't dispatch events. This
+ reverts a recent change that made the behavior slightly closer to Firefox - but the
+ compatibility effect should be very minor if any, and Firefox itself behaves inconsistently.
+
+2008-12-05 Tobias König <tobias.koenig@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Record required package dependencies for the Qt build for a correct
+ pkg-config file.
+
+ * WebCore.pro:
+
+2008-12-05 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ [Qt/Mac] Blacklist QuickTime plugin until we support the QuickDraw drawing model
+
+ * plugins/mac/PluginPackageMac.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+ (WebCore::PluginPackage::isPluginBlacklisted):
+
+2008-12-05 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22472
+
+ Revises charset alias map for TextCodecICU.
+ - Uses windows-949 and windows-874 instead of windows-949-2000 and windows-874-2000
+ - Replaces 'windows874' in a couple of place with 'windows-874' (for the canonical name)
+ - Maps 'dos-874' to 'windows-874'. Currently, it's aliases to 'cp874', which is in turn
+ mapped to 'TIS-620'. 'TIS-620' is manually aliased to 'windows-874'. We'd better directly
+ alias 'dos-874' to 'windows-874'.
+ - Replaces 'EUC-CN' with 'GBK' when it's used as the canonical name.
+ Similar to the above case, we're getting rid of indirection that eventually leads to 'GBK' by
+ directly going to 'GBK'.
+ - Adds 'x-uhc' as an alias for 'windows-949'. It's used in some web pages.
+
+ Tests: fast/encoding/char-decoding-mac.html
+ fast/encoding/char-decoding.html
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::registerExtendedEncodingNames):
+
+2008-12-04 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Add a MIME mapping for the .htm extension to wx and GTK ports.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22668
+
+ * platform/gtk/MIMETypeRegistryGtk.cpp:
+ (WebCore::):
+ * platform/wx/MimeTypeRegistryWx.cpp:
+ (WebCore::):
+
+2008-12-04 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Implement basic text paste support in wx and add notImplemented stubs
+ to catch other methods.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22667
+
+ * platform/wx/PasteboardWx.cpp:
+ (WebCore::Pasteboard::canSmartReplace):
+ (WebCore::Pasteboard::plainText):
+ (WebCore::Pasteboard::documentFragment):
+ (WebCore::Pasteboard::writeImage):
+
+2008-12-04 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix for !USE(WXGC) build config.
+
+ * platform/graphics/wx/PathWx.cpp:
+ (WebCore::Path::contains):
+ (WebCore::Path::addLineTo):
+ (WebCore::Path::addQuadCurveTo):
+ (WebCore::Path::addBezierCurveTo):
+ (WebCore::Path::addArcTo):
+ (WebCore::Path::closeSubpath):
+ (WebCore::Path::addArc):
+ (WebCore::Path::addRect):
+ (WebCore::Path::addEllipse):
+ (WebCore::Path::transform):
+ (WebCore::Path::apply):
+ (WebCore::Path::isEmpty):
+
+2008-12-04 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Turn off styled controls until we can implement them properly.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22662
+
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::isControlStyled):
+
+2008-12-04 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ wx implementations for Path API.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22661
+
+ * platform/graphics/wx/PathWx.cpp:
+ (WebCore::Path::~Path):
+ (WebCore::Path::contains):
+ (WebCore::Path::addLineTo):
+ (WebCore::Path::addQuadCurveTo):
+ (WebCore::Path::addBezierCurveTo):
+ (WebCore::Path::addArcTo):
+ (WebCore::Path::closeSubpath):
+ (WebCore::Path::addArc):
+ (WebCore::Path::addRect):
+ (WebCore::Path::addEllipse):
+ (WebCore::Path::transform):
+ (WebCore::Path::isEmpty):
+
+2008-12-04 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 22564: Make HTML elements' constructors take a QualifiedName
+ https://bugs.webkit.org/show_bug.cgi?id=22564
+
+ Updated the remaining constructors.
+
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::constructImage):
+ * dom/Document.cpp:
+ (WebCore::Document::getCSSCanvasElement):
+ * editing/DeleteButton.cpp:
+ (WebCore::DeleteButton::DeleteButton):
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::HTMLAppletElement):
+ * html/HTMLAppletElement.h:
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::HTMLAreaElement):
+ * html/HTMLAreaElement.h:
+ * html/HTMLBaseFontElement.cpp:
+ (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
+ * html/HTMLBaseFontElement.h:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::HTMLCanvasElement):
+ * html/HTMLCanvasElement.h:
+ * html/HTMLElementFactory.cpp:
+ (WebCore::hrConstructor):
+ (WebCore::paragraphConstructor):
+ (WebCore::basefontConstructor):
+ (WebCore::fontConstructor):
+ (WebCore::anchorConstructor):
+ (WebCore::imageConstructor):
+ (WebCore::mapConstructor):
+ (WebCore::areaConstructor):
+ (WebCore::canvasConstructor):
+ (WebCore::appletConstructor):
+ (WebCore::embedConstructor):
+ (WebCore::objectConstructor):
+ (WebCore::paramConstructor):
+ (WebCore::scriptConstructor):
+ (WebCore::tableConstructor):
+ (WebCore::tableCaptionConstructor):
+ (WebCore::tableRowConstructor):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::HTMLEmbedElement):
+ * html/HTMLEmbedElement.h:
+ * html/HTMLFontElement.cpp:
+ (WebCore::HTMLFontElement::HTMLFontElement):
+ * html/HTMLFontElement.h:
+ * html/HTMLHRElement.cpp:
+ (WebCore::HTMLHRElement::HTMLHRElement):
+ * html/HTMLHRElement.h:
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::HTMLImageElement):
+ * html/HTMLImageElement.h:
+ * html/HTMLMapElement.cpp:
+ (WebCore::HTMLMapElement::HTMLMapElement):
+ * html/HTMLMapElement.h:
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::HTMLObjectElement):
+ * html/HTMLObjectElement.h:
+ * html/HTMLParagraphElement.cpp:
+ (WebCore::HTMLParagraphElement::HTMLParagraphElement):
+ * html/HTMLParagraphElement.h:
+ * html/HTMLParamElement.cpp:
+ (WebCore::HTMLParamElement::HTMLParamElement):
+ * html/HTMLParamElement.h:
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError):
+ (WebCore::HTMLParser::mapCreateErrorCheck):
+ (WebCore::HTMLParser::handleIsindex):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::HTMLScriptElement):
+ * html/HTMLScriptElement.h:
+ * html/HTMLTableCaptionElement.cpp:
+ (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
+ * html/HTMLTableCaptionElement.h:
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::HTMLTableElement):
+ (WebCore::HTMLTableElement::createCaption):
+ (WebCore::HTMLTableElement::insertRow):
+ * html/HTMLTableElement.h:
+ * html/HTMLTableRowElement.cpp:
+ (WebCore::HTMLTableRowElement::HTMLTableRowElement):
+ * html/HTMLTableRowElement.h:
+ * html/HTMLTableSectionElement.cpp:
+ (WebCore::HTMLTableSectionElement::insertRow):
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::createContainingTable):
+ (WebCore::HTMLViewSourceDocument::addLine):
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageDocumentElement::ImageDocumentElement):
+
+2008-12-04 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Add file missing from last commit.
+
+ * bindings/js/ScriptState.h: Added.
+
+2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Geoff Garen.
+
+ Implement ScriptState abstraction (initially, a simple typedef)
+ as means of carrying exception information across bindings boundaries
+ and in a script engine-independent way.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::scriptStateFromNode):
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSNodeFilterCondition.h:
+ * bindings/js/ScriptState.h: Added.
+ * dom/NodeFilter.cpp:
+ (WebCore::NodeFilter::acceptNode):
+ * dom/NodeFilter.h:
+ (WebCore::NodeFilter::acceptNode):
+ * dom/NodeFilterCondition.cpp:
+ (WebCore::NodeFilterCondition::acceptNode):
+ * dom/NodeFilterCondition.h:
+ * dom/NodeIterator.cpp:
+ (WebCore::NodeIterator::nextNode):
+ (WebCore::NodeIterator::previousNode):
+ * dom/NodeIterator.h:
+ (WebCore::NodeIterator::nextNode):
+ (WebCore::NodeIterator::previousNode):
+ * dom/Traversal.cpp:
+ (WebCore::Traversal::acceptNode):
+ * dom/Traversal.h:
+ * dom/TreeWalker.cpp:
+ (WebCore::TreeWalker::parentNode):
+ (WebCore::TreeWalker::firstChild):
+ (WebCore::TreeWalker::lastChild):
+ (WebCore::TreeWalker::previousSibling):
+ (WebCore::TreeWalker::nextSibling):
+ (WebCore::TreeWalker::previousNode):
+ (WebCore::TreeWalker::nextNode):
+ * dom/TreeWalker.h:
+ (WebCore::TreeWalker::parentNode):
+ (WebCore::TreeWalker::firstChild):
+ (WebCore::TreeWalker::lastChild):
+ (WebCore::TreeWalker::previousSibling):
+ (WebCore::TreeWalker::nextSibling):
+ (WebCore::TreeWalker::previousNode):
+ (WebCore::TreeWalker::nextNode):
+
+2008-12-04 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed pauseTransitionAtTimeOnElementWithId() in DRT asserting when passed invalid property name
+ and potential similar issue with pauseAnimationAtTimeOnElementWithId().
+
+ https://bugs.webkit.org/show_bug.cgi?id=22641
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
+ (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
+
+2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Remove unused Completion.h include.
+
+ * html/CanvasRenderingContext2D.cpp: Removed Completion.h include.
+
+2008-11-13 David Hyatt <hyatt@apple.com>
+
+ Fix a bug in ScrollView's refactoring. An isVisible check should have been isSelfVisible.
+
+ Reviewed by Darin Adler
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setParentVisible):
+
+2008-12-04 Friedemann Kleint <friedemann.kleint@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix small translation glitch in the Qt file chooser.
+
+ * platform/qt/FileChooserQt.cpp:
+ (WebCore::FileChooser::basenameForWidth):
+
+2008-12-04 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Blacklist Silverlight plugin on Qt/Mac until supported
+
+ Currently the plugin crashes with a corrupted stack trace, possibly
+ related to https://bugs.webkit.org/show_bug.cgi?id=20635
+
+ * plugins/mac/PluginPackageMac.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+ (WebCore::PluginPackage::isPluginBlacklisted):
+
+2008-12-03 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix non-Mac build.
+
+ * page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+
+2008-12-03 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove uses of document() in XMLHttpRequest where simple.
+ https://bugs.webkit.org/show_bug.cgi?id=22619
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::responseXML):
+ Return NULL in the worker case which is according to spec (and avoids using document()).
+
+ (WebCore::XMLHttpRequest::callReadyStateChangeListener):
+ (WebCore::XMLHttpRequest::initSend):
+ Use scriptExecutionContext() instead of document().
+
+2008-12-03 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Make ScriptExecutionContextTaskWorkerTask::performTask a pure virtual function.
+ https://bugs.webkit.org/show_bug.cgi?id=22642
+
+ * dom/Document.cpp:
+ (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
+ (WebCore::ScriptExecutionContextTaskTimer::fired):
+ (WebCore::PerformTaskContext::PerformTaskContext):
+ (WebCore::performTask):
+ (WebCore::Document::postTask):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.cpp:
+ * dom/ScriptExecutionContext.h:
+ * dom/WorkerContext.cpp:
+ (WebCore::ScriptExecutionContextTaskWorkerTask::create):
+ (WebCore::ScriptExecutionContextTaskWorkerTask::ScriptExecutionContextTaskWorkerTask):
+ (WebCore::ScriptExecutionContextTaskWorkerTask::performTask):
+ (WebCore::WorkerContext::postTask):
+ * dom/WorkerContext.h:
+
+2008-12-03 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Using ActiveDOMObject as base class for DOMTimer.
+ https://bugs.webkit.org/show_bug.cgi?id=22620
+
+ Using ActiveDOMObject simplifies the code because ActiveDOMObject
+ is wired for stop/pause/resume on loading/unloading/caching the page etc
+ so the timer-specific code that does the same can be removed.
+ In addition, timers can be now paused/resumed 'in place' which
+ makes it unnecessary to 'serialize' them into special PausedTimeouts
+ instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
+ Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
+ of timeouts and makes it possible to not roundtrip them via PausedTimeouts
+ every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.
+
+ Timeouts are now paused with other ActiveDOMObjects:
+ - before creating CachedPage in FrameLoader::commitProvisionalLoad()
+ - in JavaScriptDebugServer::setJavaScriptPaused
+ - during modal UI operations in Chrome::*
+ this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()
+
+ Timeouts are stopped to prevent future firing from:
+ - FrameLoader::clear()
+ - FrameLoader::frameDetached()
+ this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()
+
+ This is also one of the steps to having timers in Workers. See the plan of
+ the next steps in the bug above.
+
+ * bindings/js/DOMTimer.cpp:
+ (WebCore::DOMTimer::DOMTimer):
+ (WebCore::DOMTimer::fired):
+ (WebCore::DOMTimer::hasPendingActivity):
+ (WebCore::DOMTimer::contextDestroyed):
+ (WebCore::DOMTimer::stop):
+ (WebCore::DOMTimer::suspend):
+ (WebCore::DOMTimer::resume):
+ (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
+
+ * bindings/js/DOMTimer.h:
+ * bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper
+ (WebCore::markActiveObjectsForContext):
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
+ (WebCore::JSDOMWindowBase::clear):
+ (WebCore::JSDOMWindowBase::installTimeout):
+ (WebCore::JSDOMWindowBase::removeTimeout):
+ (WebCore::JSDOMWindowBase::timerFired):
+ (WebCore::JSDOMWindowBase::disconnectFrame):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptController.h:
+
+ * dom/Document.cpp: Document now holds a hash map id->timeout
+ (WebCore::Document::addTimeout):
+ (WebCore::Document::removeTimeout):
+ (WebCore::Document::findTimeout):
+ * dom/Document.h:
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ (WebCore::CachedPage::clear):
+ * history/CachedPage.h:
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
+ (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
+ * inspector/JavaScriptDebugServer.h:
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::commitProvisionalLoad):
+ removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear();
+ I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload'
+ and then calls into client which can be external code and can cause any active object created in onunload
+ to fire. We can stop them all before firing onunload but it does not make a lot of sense.
+ I have a test to go with the next patch which verifies that timers set in onunload do not fire.
+
+ (WebCore::FrameLoader::open):
+ * page/Chrome.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+
+2008-12-03 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
+
+ In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
+ end of pasted content so that users don't get stuck with non-standard pargraph
+ spacing. This content threw off our handling of interchange newlines. Any interchange
+ newline, regardless of it's position in the incoming fragment was considered to be
+ "at the start" of the fragment, and would result in us inserting in a newline before
+ inserted content. This patch makes the checks for interchange newlines more strict,
+ and treats interchange newlines found elsewhere as normal <br>s.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ (WebCore::ReplacementFragment::removeInterchangeNodes):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::init):
+ (WebCore::VisiblePosition::canonicalPosition):
+ * editing/VisiblePosition.h:
+
+2008-12-03 Eric Seidel <eric@webkit.org>
+
+ Rubber-stamped by David Hyatt.
+
+ Bring the WebCore chromium build a couple steps closer to building.
+
+ * WebCore.scons:
+
+2008-12-03 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * WebCoreSources.bkl:
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22636
+
+ Implement WML variable substitution & validation.
+ Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.
+
+ Tests: wml/variable-reference-invalid-character.html
+ wml/variable-reference-valid.html
+
+ * wml/WMLVariables.cpp:
+ (WebCore::isValidFirstVariableNameCharacter):
+ (WebCore::isValidVariableNameCharacter):
+ (WebCore::isValidVariableEscapingModeString):
+ (WebCore::isValidVariableName):
+ (WebCore::containsVariableReference):
+ (WebCore::substituteVariableReferences):
+ * wml/WMLVariables.h:
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Further preparations for WML layout tests.
+ - Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
+ - Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
+ - Add helper method in Document.idl, to reset the WML page state to a well-known default state.
+ (will be used in the upcoming LayoutTests/wml testcases)
+
+ * dom/Document.cpp:
+ (WebCore::Document::resetWMLPageState):
+ * dom/Document.h:
+ * dom/Document.idl:
+ * dom/Text.cpp:
+ (WebCore::Text::insertedIntoDocument):
+ * dom/Text.h:
+ * page/Console.cpp:
+ (WebCore::Console::addMessage):
+ * wml/WMLPageState.h: Readd heper function
+ (WebCore::WMLPageState::hasVariables):
+
+2008-12-03 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Don't leak selectors in case selector list parsing failed.
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::~CSSParser):
+
+2008-12-03 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=22520
+
+ This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
+ This patch fixes the testcase.
+
+ This is another case of animations getting destroyed in the end animation callback and causing dangling
+ pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
+ So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
+ and skip that call.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+
+2008-12-03 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22379
+ Make CSSOM use less memory
+
+ Reduce size of the CSSSelector by one more pointer by using an array
+ instead of a linked list to store them.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::CSSParser):
+ (WebCore::CSSParser::parseSelector):
+ (WebCore::CSSParser::createStyleRule):
+ * css/CSSParser.h:
+ (WebCore::CSSParser::reusableSelectorVector):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::CSSSelector):
+ (WebCore::CSSSelector::~CSSSelector):
+ (WebCore::CSSSelector::isLastInSelectorList):
+ (WebCore::CSSSelector::setLastInSelectorList):
+ * css/CSSStyleRule.cpp:
+ (WebCore::CSSStyleRule::CSSStyleRule):
+ (WebCore::CSSStyleRule::~CSSStyleRule):
+ (WebCore::CSSStyleRule::selectorText):
+ * css/CSSStyleRule.h:
+ (WebCore::CSSStyleRule::adoptSelectorVector):
+ (WebCore::CSSStyleRule::selectorList):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSRuleSet::addRulesFromSheet):
+ * dom/Node.cpp:
+ (WebCore::forEachSelector):
+ (WebCore::selectorNeedsNamespaceResolution):
+ (WebCore::Node::querySelector):
+ (WebCore::Node::querySelectorAll):
+ * dom/SelectorNodeList.cpp:
+ (WebCore::createSelectorNodeList):
+ * dom/SelectorNodeList.h:
+
+2008-12-03 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22630
+ Assertion failure in XMLHttpRequest::contextDestroyed
+
+ Test: http/tests/xmlhttprequest/close-window.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::clear):
+ (WebCore::FrameLoader::commitProvisionalLoad):
+ Move stopping active objects to clear(), so that closing a window is also covered.
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(),
+ because internalAbort() deref()'s.
+
+2008-12-03 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Implement CSS 3 <angle> turn unit and support it
+ in rotations.
+ https://bugs.webkit.org/show_bug.cgi?id=22497
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::validUnit):
+ (WebCore::unitFromString):
+ (WebCore::CSSParser::lex):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+ (WebCore::CSSPrimitiveValue::parserValue):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::createTransformOperations):
+ * css/tokenizer.flex:
+
+2008-12-03 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Make use of the gradient code in GraphicsContext and get rid of most of the
+ platform dependent code.
+
+ SVG should use the new Gradient support on GraphicsContext
+ https://bugs.webkit.org/show_bug.cgi?id=20543
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/FloatSize.h:
+ (WebCore::FloatSize::shrunkTo):
+ * svg/SVGLinearGradientElement.cpp:
+ (WebCore::SVGLinearGradientElement::buildGradient):
+ * svg/SVGRadialGradientElement.cpp:
+ (WebCore::SVGRadialGradientElement::buildGradient):
+ * svg/graphics/SVGPaintServer.h:
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
+ (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
+ (WebCore::SVGPaintServerGradient::gradient):
+ (WebCore::SVGPaintServerGradient::setGradient):
+ (WebCore::findTextRootObject):
+ (WebCore::createMaskAndSwapContextForTextGradient):
+ (WebCore::clipToTextMask):
+ (WebCore::SVGPaintServerGradient::setup):
+ (WebCore::SVGPaintServerGradient::renderPath):
+ (WebCore::SVGPaintServerGradient::teardown):
+ * svg/graphics/SVGPaintServerGradient.h:
+ (WebCore::SVGPaintServerGradient::setGradientStops):
+ (WebCore::SVGPaintServerGradient::gradientStops):
+ * svg/graphics/SVGPaintServerLinearGradient.h:
+ * svg/graphics/SVGPaintServerRadialGradient.h:
+ * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
+ * svg/graphics/cg/SVGPaintServerCg.cpp:
+ * svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.
+
+2008-12-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix formatting.
+
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::createRareData):
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Adam Roben.
+
+ As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.
+
+ * inspector/front-end/Console.js:
+ * page/Console.h:
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Next steps to make LayoutTests work:
+ Never access the main frame from WMLRefreshElement/WMLCardElement, but
+ the current documents frame (WML layout tests will run in an <iframe>)
+
+ Prepare WMLErrorHandling for the case that no tokenizer is available anymore
+ -> report errors through Console::addMessage(), so they get logged in the
+ expected layout test results.
+
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ * wml/WMLErrorHandling.cpp:
+ (WebCore::reportWMLError):
+ (WebCore::errorMessageForErrorCode):
+ * wml/WMLErrorHandling.h:
+ * wml/WMLRefreshElement.cpp:
+ (WebCore::WMLRefreshElement::executeTask):
+ * page/Console.cpp: Handle WMLMessageSource.
+ (WebCore::printMessageSourceAndLevelPrefix):
+ * page/Console.h: Add WMLMessageSource.
+ (WebCore::):
+
+2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Allow passing jsNull and jsUndefined to Qt plugins
+
+ Currently limited to functions with QString and QVariant arguments,
+ and properties of these types. Both jsNull and jsUndefined ends up
+ as default-constructed QStrings and QVariants, which means you can
+ check for isEmpty() and isValid() in the native plugin code.
+
+ Based on patches by Jade Han <jade.han@nokia.com>
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+ (JSC::Bindings::findMethodIndex):
+
+2008-12-03 Trenton Schulz <trenton.schulz@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix the build with Qt for Mac OS X.
+
+ * platform/PurgeableBuffer.h: Use the dummy wrappers for now.
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix error handling in WMLSetvarElement. If an invalid variable reference is contained
+ in the 'name' attribute of <setvar>, a 'WMLErrorInvalidVariableName' error should be
+ reported, instead of 'WMLErrorInvalidVariableReference'.
+
+ * wml/WMLElement.cpp:
+ (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
+ (WebCore::WMLElement::parseValueForbiddingVariableReferences):
+ * wml/WMLElement.h:
+ * wml/WMLSetvarElement.cpp:
+ (WebCore::WMLSetvarElement::parseMappedAttribute):
+ * wml/WMLSetvarElement.h:
+ (WebCore::WMLSetvarElement::name):
+ (WebCore::WMLSetvarElement::value):
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Preparations to get WML layout tests going.
+ Make WMLPageState an OwnPtr to Page, and let Page create it on demand.
+
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ (WebCore::Page::wmlPageState):
+ * page/Page.h:
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::WMLDocument):
+ (WebCore::WMLDocument::finishedParsing):
+ (WebCore::wmlPageStateForDocument):
+ * wml/WMLPageState.h: Don't inherit from RefCounted anymore.
+ (WebCore::WMLPageState::hasVariables): Remove helper function.
+
+2008-12-03 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22627
+ fast/workers/worker-terminate.html fails randomly
+
+ The problem is that worker termination uses script timeouts, so an InterruptedExecutionError
+ is raised, and it sometimes reaches the main thread.
+
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerExceptionTask::create):
+ (WebCore::WorkerExceptionTask::WorkerExceptionTask):
+ (WebCore::WorkerExceptionTask::performTask):
+ (WebCore::WorkerMessagingProxy::postWorkerException):
+ * dom/WorkerMessagingProxy.h:
+ Ignore exceptions that happen in terminated workers.
+
+2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove some unncessary includes.
+
+ * wml/WMLAccessElement.cpp:
+ * wml/WMLDocument.h:
+ * wml/WMLRefreshElement.cpp:
+
+2008-12-03 Alexey Proskuryakov <ap@webkit.org>
+
+ Rubber-stamped by Cameron Zwarich and Adam Roben.
+
+ Fix a typo: m_executionForbidded.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::WorkerScriptController):
+ (WebCore::WorkerScriptController::evaluate):
+ (WebCore::WorkerScriptController::forbidExecution):
+ * bindings/js/WorkerScriptController.h:
+
+2008-12-03 Dean McNamee <deanm@chromium.org>
+
+ Bug 22623: Uninitialized memory access in cache parsing code
+ <https://bugs.webkit.org/show_bug.cgi?id=22623>
+
+ Reviewed by David Kilzer.
+
+ Initialize m_haveParsedCacheControlHeader and m_haveParsedPragmaHeader.
+
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::ResourceResponseBase):
+
+2008-12-03 Antti Koivisto <antti@apple.com>
+
+ Probable build fix.
+
+ * WebCoreSources.bkl:
+
+2008-12-03 Antti Koivisto <antti@apple.com>
+
+ Forgot to commit these.
+
+ * dom/Node.cpp:
+ (WebCore::forEachTagSelector):
+ (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
+ (WebCore::Node::querySelector):
+ * dom/SelectorNodeList.cpp:
+ (WebCore::createSelectorNodeList):
+
+2008-12-03 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein and Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22379
+ Make CSSOM use less memory
+
+ Reduce size of the CSSSelector by 3/8 by moving rarely used fields to a rare data
+ struct. Browsing around with some instrumentation showed that ~0.1% of all selectors
+ encountered had rare data.
+
+ This also eliminates the CSSNthSelector subclass which will make possible to store
+ CSSSelectors in an array instead of a linked list for futher memory savings.
+
+ * css/CSSGrammar.y:
+ * css/CSSNthSelector.cpp: Removed.
+ * css/CSSNthSelector.h: Removed.
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::createFloatingSelector):
+ * css/CSSParser.h:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::specificity):
+ (WebCore::CSSSelector::operator==):
+ (WebCore::CSSSelector::selectorText):
+ (WebCore::CSSSelector::setTagHistory):
+ (WebCore::CSSSelector::attribute):
+ (WebCore::CSSSelector::setAttribute):
+ (WebCore::CSSSelector::setArgument):
+ (WebCore::CSSSelector::setSimpleSelector):
+ (WebCore::CSSSelector::parseNth):
+ (WebCore::CSSSelector::matchNth):
+ (WebCore::CSSSelector::RareData::parseNth):
+ (WebCore::CSSSelector::RareData::matchNth):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::CSSSelector):
+ (WebCore::CSSSelector::~CSSSelector):
+ (WebCore::CSSSelector::tagHistory):
+ (WebCore::CSSSelector::hasAttribute):
+ (WebCore::CSSSelector::argument):
+ (WebCore::CSSSelector::simpleSelector):
+ (WebCore::CSSSelector::RareData::RareData):
+ (WebCore::CSSSelector::createRareData):
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+
+2008-12-03 Jian Li <jianli@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove unneeded included file in WorkerThread.cpp.
+ https://bugs.webkit.org/show_bug.cgi?id=22613
+
+ * dom/WorkerThread.cpp: No need to include JSWorkerContext.h.
+
+2008-12-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22543
+ Consolidate ActiveDOMObject page cache interaction
+
+ Test: http/tests/xmlhttprequest/abort-on-leaving-page.html
+
+ * dom/ActiveDOMObject.cpp:
+ (WebCore::ActiveDOMObject::canSuspend):
+ (WebCore::ActiveDOMObject::suspend):
+ (WebCore::ActiveDOMObject::resume):
+ * dom/ActiveDOMObject.h:
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
+ (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
+ (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
+ * dom/ScriptExecutionContext.h:
+ Added methods for suspending and resuming active objects.
+
+ * dom/Worker.cpp:
+ (WebCore::Worker::canSuspend):
+ (WebCore::Worker::stop):
+ * dom/Worker.h:
+ Workers cannot be suspended yet. This is a change in behavior, as workers used to keep
+ running until their owner was destroyed.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading): No longer call stopActiveDOMObjects() here, because
+ their activity is not necessarily loading.
+ (WebCore::FrameLoader::canCachePage): Can only cache if all active objects can be suspended.
+ Previously, stopLoading() cancelled outstanding XMLHttpRequests, which made the page
+ uncacheable due to no-null main document error.
+ (WebCore::FrameLoader::commitProvisionalLoad): Suspend or stop active objects, depending on
+ whether the document will be cached.
+ (WebCore::FrameLoader::frameDetached): Stop active objects to let them clean up before their
+ context is destroyed.
+
+ * xml/XMLHttpRequest.h: added canSuspend().
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::canSuspend): Only XHRs that are not loading can be suspended.
+ (WebCore::XMLHttpRequest::stop): Call abort() instead of internalAbort() to dispatch events
+ for Firefox compatibility. This is a change in behavior that helps test that requests do
+ get aborted.
+ (WebCore::XMLHttpRequest::contextDestroyed): The request must have been stopped by now, so
+ assert that.
+
+2008-12-02 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 22606: Can <th> serves as the AXTitleUIElement for <td>?
+
+ Test: accessibility/th-as-title-ui.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::isGroup):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isGroup):
+ * page/AccessibilityRenderObject.h:
+ * page/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::rowIndexRange):
+ (WebCore::AccessibilityTableCell::columnIndexRange):
+ (WebCore::AccessibilityTableCell::titleUIElement):
+ * page/AccessibilityTableCell.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2008-12-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=22472
+
+ Override absoluteClippedOverflowRect() in RenderReplaced to return a rect
+ that is large enough to encompass the selection, so that the repainting of
+ selected replaced elements works correctly.
+
+ Test: fast/repaint/selected-replaced.html
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::selectionRect):
+ (WebCore::RenderReplaced::localSelectionRect):
+ (WebCore::RenderReplaced::absoluteClippedOverflowRect):
+ * rendering/RenderReplaced.h:
+
+2008-12-02 Gregory Hughes <ghughes@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 22513: ZOOM: text selection does not send correct zoom bounds
+
+ When zoomed, text selection must send the zoom bounds in flipped
+ screen coordinates.
+
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+ * page/mac/WebCoreViewFactory.h:
+
+2008-12-02 Dean Jackson <dino@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove support for 'now' from CSS (was
+ erroneously added to transition and animation delay)
+ https://bugs.webkit.org/show_bug.cgi?id=22571
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseAnimationDelay):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapAnimationDelay):
+ * css/CSSValueKeywords.in:
+
+2008-12-02 Eric Seidel <eric@webkit.org>
+
+ Build fix, no review.
+
+ Fix the Mac and gtk builds:
+ Don't use a float to hold a double.
+ Remove a now duplicate symbol.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionLayoutChanged):
+ * platform/gtk/TemporaryLinkStubs.cpp:
+
+2008-12-02 Chris Fleizach <cfleizach@apple.com>
+
+ Bug 22596: Some elements don't report AXBlockQuoteLevel
+ https://bugs.webkit.org/show_bug.cgi?id=22596
+
+ Reviewed by John Sullivan.
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (blockquoteLevel):
+ (AXAttributeStringSetBlockquoteLevel):
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+
+2008-12-02 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Correctly handle a theme returning a non-blinking interval. We should
+ not set any timers when the interval is 0 (non-blinking), otherwise we
+ repeatedly set and destroy a blinking timer, causing a paint and timer
+ storm. This is applicable to GTK and Windows, where a user can set a
+ non-blinking caret in their system preferences.
+
+ Renamed caretBlinkFrequency to the more accurate caretBlinkInterval.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionLayoutChanged):
+ * platform/Theme.h:
+ (WebCore::Theme::caretBlinkInterval):
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::caretBlinkInterval):
+ * platform/gtk/RenderThemeGtk.h:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::caretBlinkInterval):
+
+2008-12-02 David Levin <levin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22538
+
+ startsWith uses find which searches through the whole string if no match is found.
+ Using reverseFind with an index of 0 has the benefit of only searching for the match
+ at the beginning of the string. This may only be a small benefit in the overall program,
+ but it may help in some cases when the string is big.
+
+ No observable change in behavior, so no test.
+
+ * platform/text/StringImpl.h:
+ (WebCore::StringImpl::startsWith):
+
+2008-10-29 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Wrap a JSC-only hack in a USE(JSC) block to fix the v8 build.
+ https://bugs.webkit.org/show_bug.cgi?id=21951
+
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::forgetWrapper):
+
+2008-12-02 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Add an ASSERT to try and catch the root cause of:
+ https://bugs.webkit.org/show_bug.cgi?id=22168
+ http://code.google.com/p/chromium/issues/detail?id=4122
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::emitText):
+
+2008-12-02 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Adam Roben.
+
+ Remove some CG-specific code from the Windows Cairo build.
+ https://bugs.webkit.org/show_bug.cgi?id=22586
+
+ No new test cases since this update should create no user-visible
+ changes, and should be fully covered by the existing regression
+ tests.
+
+ * WebCore.vcproj/WebCore.vcproj: Remove FontDatabase from
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::focusRingColor): Add stub method
+ * platform/win/TemporaryLinkStubs.cpp:
+ (WebCore::populateFontDatabase): Add stub method.
+
+2008-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ MinGW compilation fix for PluginPackageWin.cpp
+
+ https://bugs.webkit.org/show_bug.cgi?id=22585
+
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+
+2008-12-02 Adam Roben <aroben@apple.com>
+
+ Build fix for Windows projects with NOMINMAX defined globally
+
+ * platform/win/COMPtr.h: Don't redefine NOMINMAX if it's already
+ defined.
+
+2008-12-02 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Build JavaScriptCore into libQtWebKit.so through a direct build
+ instead of a static library. When linking a static library into
+ a shared library qmake generates an incorrect .prl file, which
+ causes all sorts of different build problems when linking against
+ QtWebKit. Fixing this in qmake requires bigger changes that are
+ currently not possible, so we need to work around this limitation
+ for now. The advantages of the separate build did not outweight the
+ build problems it caused.
+
+ * WebCore.pro: include JavaScriptCore.pri, re-enable prl support
+ and rename the lut generator to domlut to avoid a conflict with
+ JavaScriptCore.pri's lut generator.
+
+2008-12-02 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22588
+ Move securityOrigin() from Document and WorkerContext into ScriptExecutionContext.
+
+ No observable change in behavior, so no test.
+
+ * dom/Document.cpp:
+ (WebCore::Document::open):
+ (WebCore::Document::domain):
+ (WebCore::Document::setDomain):
+ (WebCore::Document::initSecurityContext):
+ (WebCore::Document::setSecurityOrigin):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ScriptExecutionContext::setSecurityOrigin):
+ * dom/ScriptExecutionContext.h:
+ (WebCore::ScriptExecutionContext::securityOrigin):
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::WorkerContext):
+ * dom/WorkerContext.h:
+ These changes are for the move of securityOrigin().
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::createRequest):
+ (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
+ (WebCore::XMLHttpRequest::setRequestHeader):
+ (WebCore::XMLHttpRequest::getAllResponseHeaders):
+ (WebCore::XMLHttpRequest::getResponseHeader):
+ (WebCore::XMLHttpRequest::processSyncLoadResults):
+ (WebCore::XMLHttpRequest::willSendRequest):
+ (WebCore::XMLHttpRequest::accessControlCheck):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ Change XMLHttpRequest to use ScriptExecutionContext instead of Document to access securityOrigin().
+
+2008-12-02 André Pönitz <apoenitz@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Disable the creation of debug information for the Qt build when done
+ inside Qt. With 670 mb it was slowing down gdb start significantly
+ for third-party applications that usually don't need it.
+
+ * WebCore.pro:
+
+2008-12-01 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=13736 REGRESSION
+ (r19811): Using the down arrow in a textarea gets "stuck" at the
+ end of a wrapped line
+ And corresponding: <rdar://problem/5347931>
+
+ The basic problem here is that Position::getInlineBoxAndOffset()
+ failed to look beyond a single renderer. This patch looks for a
+ better match beyond the first renderer when the affinity is
+ downstream and we failed to find a "perfect" match.
+ * dom/Position.cpp:
+ (WebCore::isNonTextLeafChild):
+ (WebCore::searchAheadForBetterMatch):
+ (WebCore::Position::getInlineBoxAndOffset):
+
+ This is a fix I made based on code inspection. It looks like the
+ old code here and skipped over the parent as a possible match.
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::nextInPreOrderAfterChildren):
+
+2008-12-01 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Adam Roben.
+
+ Add WML related files to Visual Studio projects.
+ https://bugs.webkit.org/show_bug.cgi?id=22561
+
+ * WebCore.vcproj/WebCore.vcproj:
+ 1. Add files from the wml directory to the set of windows files.
+ 2. Extend include paths with new wml directory.
+ 3. Add new autogenerated WML files to DerivedSources.
+ 4. Alphabetize preprocesor includes (holdover from earlier debugging).
+
+2008-12-01 Steve Falkenburg <sfalken@apple.com>
+
+ Revise node/selection image fix.
+ Moved updateLayout call so selection rect is fetched after the layout.
+
+ Reviewed by Adam Roben.
+
+ * page/win/FrameCGWin.cpp:
+ (WebCore::imageFromRect):
+ (WebCore::imageFromSelection):
+ (WebCore::Frame::nodeImage):
+
+2008-12-01 Steve Falkenburg <sfalken@apple.com>
+
+ Support needed to implement renderedImage for Windows.
+ https://bugs.webkit.org/show_bug.cgi?25648
+
+ Reviewed by Adam Roben.
+
+ * page/Frame.h:
+ * page/win/FrameCGWin.cpp:
+ (WebCore::imageFromRect):
+ (WebCore::imageFromSelection):
+ (WebCore::Frame::nodeImage):
+ * page/win/FrameCairoWin.cpp:
+ (WebCore::imageFromNode):
+
+2008-12-01 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22581
+
+ Fix the painting of the caps lock indicator for transformed text inputs,
+ by replacing a call to absoluteContentBox() with code that computes the
+ painting rect for the input contents.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::paint):
+
+2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Add two new helper functions to WMLElement, parseValueSubstitutingVariableReferences/parseValueForbiddingVariableReferences.
+
+ Convert all elements to parse their attribute values using these new helper functions. This simplifies the
+ actual attribute parsing code in all WMLElement derived classes, as most WML attribute values either report
+ an error if there's a variable reference used in the attribute value, or if it's invalid.
+
+ Split the WMLErrorInvalidVariableReference error which covered both 'invalid syntax' / 'wrong location'
+ in two seperated error codes: WMLErrorInvalidVariableReference / WMLErrorInvalidVariableReferenceLocation.
+
+ * wml/WMLAccessElement.cpp:
+ (WebCore::WMLAccessElement::parseMappedAttribute):
+ * wml/WMLDoElement.cpp:
+ (WebCore::WMLDoElement::defaultEventHandler):
+ (WebCore::WMLDoElement::parseMappedAttribute):
+ * wml/WMLElement.cpp:
+ (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
+ (WebCore::WMLElement::parseValueForbiddingVariableReferences):
+ * wml/WMLElement.h:
+ * wml/WMLErrorHandling.cpp:
+ (WebCore::reportWMLError):
+ * wml/WMLErrorHandling.h:
+ (WebCore::):
+ * wml/WMLOnEventElement.cpp:
+ (WebCore::WMLOnEventElement::parseMappedAttribute):
+ * wml/WMLPrevElement.cpp:
+ (WebCore::WMLPrevElement::executeTask):
+ * wml/WMLSetvarElement.cpp:
+ (WebCore::WMLSetvarElement::parseMappedAttribute):
+ * wml/WMLTimerElement.cpp:
+ (WebCore::WMLTimerElement::parseMappedAttribute):
+
+2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fix switching active cards within a document. No way to test, until <go> support is implemented.
+
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::showCard):
+ (WebCore::WMLCardElement::hideCard):
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ * wml/WMLCardElement.h:
+
+2008-12-01 David Kilzer <ddkilzer@apple.com>
+
+ Fix logic error in LegacyWebArchive::create() from r38884.
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Only continue if the
+ subresource is actually added.
+
+2008-12-01 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22466>
+ <rdar://problem/6403593>
+
+ Reviewed by Brady Eidson.
+
+ Test: http/tests/webarchive/test-preload-resources.html
+
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create): Check the WebCore cache for
+ resources if DocumentLoader::subresource() doesn't return them.
+ Note that the DocumentLoader::subresource() method returned
+ preloaded resources before r35867, but this caused a regression in
+ Mail.
+
+2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 22564: Make HTML elements' constructors take a QualifiedName
+ https://bugs.webkit.org/show_bug.cgi?id=22564
+
+ - Modified the remaining HTML elements' constructors to take a QualifiedName.
+
+ - Added an assertion that the QualifiedName given corresponds to the element constructed.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::constructAudio):
+ * html/HTMLAudioElement.cpp:
+ (WebCore::HTMLAudioElement::HTMLAudioElement):
+ * html/HTMLAudioElement.h:
+ * html/HTMLBRElement.cpp:
+ (WebCore::HTMLBRElement::HTMLBRElement):
+ * html/HTMLBRElement.h:
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::setInnerText):
+ * html/HTMLElementFactory.cpp:
+ (WebCore::brConstructor):
+ (WebCore::quoteConstructor):
+ (WebCore::marqueeConstructor):
+ (WebCore::audioConstructor):
+ (WebCore::videoConstructor):
+ (WebCore::sourceConstructor):
+ * html/HTMLMarqueeElement.cpp:
+ (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
+ * html/HTMLMarqueeElement.h:
+ * html/HTMLQuoteElement.cpp:
+ (WebCore::HTMLQuoteElement::HTMLQuoteElement):
+ * html/HTMLQuoteElement.h:
+ * html/HTMLSourceElement.cpp:
+ (WebCore::HTMLSourceElement::HTMLSourceElement):
+ * html/HTMLSourceElement.h:
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::HTMLVideoElement):
+ * html/HTMLVideoElement.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::updateFromElement):
+
+2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Antti Koivisto.
+
+ Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
+ https://bugs.webkit.org/show_bug.cgi?id=22441
+
+ Add an assertion to the modified HTML elements' constructor
+ to check that the QualifiedName parameter is the one that
+ matches the Element's.
+
+ * html/HTMLBaseElement.cpp:
+ (WebCore::HTMLBaseElement::HTMLBaseElement):
+ * html/HTMLBlockquoteElement.cpp:
+ (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::HTMLBodyElement):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::HTMLButtonElement):
+ * html/HTMLDListElement.cpp:
+ (WebCore::HTMLDListElement::HTMLDListElement):
+ * html/HTMLDirectoryElement.cpp:
+ (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
+ * html/HTMLDivElement.cpp:
+ (WebCore::HTMLDivElement::HTMLDivElement):
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::HTMLFormElement):
+ * html/HTMLFrameElement.cpp:
+ (WebCore::HTMLFrameElement::HTMLFrameElement):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
+ * html/HTMLHeadElement.cpp:
+ (WebCore::HTMLHeadElement::HTMLHeadElement):
+ * html/HTMLHtmlElement.cpp:
+ (WebCore::HTMLHtmlElement::HTMLHtmlElement):
+ * html/HTMLIFrameElement.cpp:
+ (WebCore::HTMLIFrameElement::HTMLIFrameElement):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::HTMLInputElement):
+ * html/HTMLIsIndexElement.cpp:
+ (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::HTMLKeygenElement):
+ * html/HTMLLIElement.cpp:
+ (WebCore::HTMLLIElement::HTMLLIElement):
+ * html/HTMLLabelElement.cpp:
+ (WebCore::HTMLLabelElement::HTMLLabelElement):
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::HTMLLegendElement):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::HTMLLinkElement):
+ * html/HTMLMenuElement.cpp:
+ (WebCore::HTMLMenuElement::HTMLMenuElement):
+ * html/HTMLMetaElement.cpp:
+ (WebCore::HTMLMetaElement::HTMLMetaElement):
+ * html/HTMLOListElement.cpp:
+ (WebCore::HTMLOListElement::HTMLOListElement):
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::HTMLOptionElement):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::HTMLSelectElement):
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::HTMLStyleElement):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
+ * html/HTMLTitleElement.cpp:
+ (WebCore::HTMLTitleElement::HTMLTitleElement):
+ * html/HTMLUListElement.cpp:
+ (WebCore::HTMLUListElement::HTMLUListElement):
+
+2008-12-01 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22046
+
+ Fixed another case of crashing because the animation object is getting deleted when
+ it's in the middle of a callback. I actually moved where I am retaining the pointer
+ up out of the lower level AnimationBase code and into the timer callback that calls
+ them. So now the pointer is valid throughout the entire sequence of callback code.
+
+ The testcase for https://bugs.webkit.org/show_bug.cgi?id=22052 also exhibits a
+ crash which this patch fixes.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::animationTimerCallbackFired):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
+ (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
+ (WebCore::CompositeAnimationPrivate::styleAvailable):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
+
+2008-12-01 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt/Mac] Initialize NPAPI plugins before getting their entry points
+
+ The old behavior (calling NP_GetEntryPoints before NP_Initialize) was
+ copied from Windows, but caused Silverlight on Mac to crash when loaded.
+
+ Apparently the call order of NP_Initialize and NP_GetEntryPoints is
+ reversed on Mac. See https://bugzilla.mozilla.org/show_bug.cgi?id=344425
+
+ Reported-by: Peter Johnson <peter@zattoo.com>
+
+ * plugins/mac/PluginPackageMac.cpp:
+ (WebCore::PluginPackage::load):
+
+2008-11-30 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by John Sullivan.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22510
+ Crash at WebCore::AccessibilityRenderObject::activeDescendant() on Google Reader with ARIA (22510)
+
+ A nil pointer needed to be checked
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::activeDescendant):
+
+2008-11-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22530
+ Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID
+
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::start): Protect worker startup with a mutex to ensure that this
+ function runs to completion before the thread begins execution.
+ (WebCore::WorkerThread::workerThread): Updated comments.
+ (WebCore::WorkerThread::stop): Ditto.
+ * dom/WorkerThread.h: Renamed m_workerContextMutex to m_threadCreationMutex, because it now
+ protects startup as a whole.
+
+ * storage/DatabaseThread.cpp:
+ * storage/DatabaseThread.h:
+ * storage/LocalStorageThread.cpp:
+ * storage/LocalStorageThread.h:
+ Fixed the same m_threadID problem.
+
+2008-11-29 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove Visual Studio project dependencies on non-redistributable
+ components in the Debug_Cairo and Release_Cairo build targets.
+ See https://bugs.webkit.org/show_bug.cgi?id=22527
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-11-29 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Fix some sorting
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-11-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
+ NULL pointer crash in dispatchEvent(null);
+
+ Test: fast/events/dispatchEvent-crash.html
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::dispatchEvent):
+ * dom/Worker.cpp:
+ (WebCore::Worker::dispatchEvent):
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::dispatchEvent):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::dispatchEvent):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::dispatchEvent):
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::dispatchEvent):
+
+2008-11-29 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=22454
+ <rdar://problem/6405550> REGRESSION (3.2-TOT): Crash below FontFallbackList::fontDataAt on jacobian.org
+
+ Test: http/tests/misc/font-face-in-multiple-segmented-faces.html
+
+ The crash happened because style recalculation was invoked by
+ CSSFontSelector after one CSSSegmentedFontFace had pruned its tables but
+ before another CSSSegmentedFontFace using the same CSSFontFace had done
+ so. The fix is to let all CSSSegmentedFontFaces using the CSSFontFace
+ prune their tables before telling the CSSFontSelector to recalc style.
+
+ * css/CSSFontFace.cpp:
+ (WebCore::CSSFontFace::fontLoaded):
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::fontLoaded):
+ * css/CSSFontSelector.h:
+ * css/CSSSegmentedFontFace.cpp:
+ (WebCore::CSSSegmentedFontFace::fontLoaded):
+
+2008-11-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=14968
+ document.open() erroneously returns void instead of the new Document
+
+ Test: fast/dom/HTMLDocument/document-open-return-value.html
+
+ * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
+ Return the document on which this method was invoked, per HTML5.
+
+2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550
+
+ Add <timer> element support. It provides a way to execute a task with a delay.
+ The user is notified by firing the task associated with the <card>'s ontimer attribute.
+ Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::setIntrinsicEventTimer):
+ (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
+ * wml/WMLCardElement.h:
+ * wml/WMLDoElement.cpp:
+ (WebCore::WMLDoElement::defaultEventHandler):
+ * wml/WMLErrorHandling.cpp:
+ (WebCore::reportWMLError):
+ * wml/WMLPageState.h:
+ (WebCore::WMLPageState::getVariable):
+ * wml/WMLPrevElement.cpp:
+ (WebCore::WMLPrevElement::executeTask):
+ * wml/WMLRefreshElement.cpp:
+ (WebCore::WMLRefreshElement::executeTask):
+ * wml/WMLTagNames.in:
+ * wml/WMLTimerElement.cpp: Added.
+ (WebCore::WMLTimerElement::WMLTimerElement):
+ (WebCore::WMLTimerElement::parseMappedAttribute):
+ (WebCore::WMLTimerElement::insertedIntoDocument):
+ (WebCore::WMLTimerElement::timerFired):
+ (WebCore::WMLTimerElement::start):
+ (WebCore::WMLTimerElement::stop):
+ (WebCore::WMLTimerElement::storeIntervalToPageState):
+ * wml/WMLTimerElement.h: Added.
+
+2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Holger Freyther.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549
+
+ Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
+ Changes numerous of layout tests which contain <do> elements, as they render as buttons now.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::updateFromElement):
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::registerDoElement):
+ * wml/WMLCardElement.h:
+ * wml/WMLDoElement.cpp: Added.
+ (WebCore::WMLDoElement::WMLDoElement):
+ (WebCore::WMLDoElement::defaultEventHandler):
+ (WebCore::WMLDoElement::parseMappedAttribute):
+ (WebCore::WMLDoElement::insertedIntoDocument):
+ (WebCore::WMLDoElement::createRenderer):
+ (WebCore::WMLDoElement::recalcStyle):
+ * wml/WMLDoElement.h: Added.
+ (WebCore::WMLDoElement::registerTask):
+ (WebCore::WMLDoElement::isActive):
+ (WebCore::WMLDoElement::label):
+ (WebCore::WMLDoElement::name):
+ (WebCore::WMLDoElement::setActive):
+ (WebCore::WMLDoElement::setNoop):
+ * wml/WMLNoopElement.cpp:
+ (WebCore::WMLNoopElement::insertedIntoDocument):
+ * wml/WMLTagNames.in:
+ * wml/WMLTaskElement.cpp:
+ (WebCore::WMLTaskElement::insertedIntoDocument):
+
+2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545
+
+ Add onenterforward/onenterbackward/ontimer support for <card> elements.
+
+ No testing possible at the moment because WMLGoElement is not yet implemented.
+ After that we can add tests covering the <card> event handling.
+
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
+ (WebCore::WMLCardElement::parseMappedAttribute):
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ * wml/WMLCardElement.h:
+ (WebCore::WMLCardElement::isNewContext):
+ (WebCore::WMLCardElement::isOrdered):
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing):
+ * wml/WMLIntrinsicEvent.cpp:
+ (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
+ * wml/WMLIntrinsicEvent.h:
+ (WebCore::WMLIntrinsicEvent::create):
+
+2008-11-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Regression seen on QtWebKit - causes a build failure on Win using MinGW
+
+ https://bugs.webkit.org/show_bug.cgi?id=22536
+
+ * WebCore.pro:
+
+2008-11-28 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix compilation and linking on Windows CE.
+
+ Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
+ from the Windows'ish build.
+
+ Link against the newly required mmtimer.
+
+ * WebCore.pro:
+ * plugins/PluginPackage.cpp:
+
+2008-11-28 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ http://bugs.webkit.org/show_bug.cgi?id=22524
+
+ Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
+ of XMLHttpRequest by Workers (on threads).
+
+ No observable change in behavior, so no test.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
+ (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
+ (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
+ (WebCore::PreflightResultCacheItem::allowsRequest):
+ (WebCore::createXMLHttpRequestStaticData):
+ (WebCore::initializeXMLHttpRequestStaticData):
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::isSafeRequestHeader):
+ (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
+ * xml/XMLHttpRequest.h:
+
+2008-11-27 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ r38825, was committed without checking whether anything in WebCore
+ uses JSFunction::m_body. Use the appropriate getters and setters
+ instead.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+
+2008-11-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22529
+ Crashes seen on buildbots due to trying to stop a worker thread twice
+
+ * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
+ Don't try to stop the thread if it's already stopping.
+
+2008-11-27 Kent Hansen <khansen@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Make JavaScript bindings for Qt plugin widgets work again
+ this was a regression; need to handle non-NPAPI plugins as in 4.4.
+
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+
+2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22522
+
+ Catch WML errors (invalid variable name/reference, multiple access elements, etc)
+ while parsing the document, and stop parsing immediately and wrap the document
+ fragment in a XHTML error document, just like it's done from XML parsing errors.
+
+ Until now all card elements were hidden by default (no renderer created), and
+ WMLDocument::finishedParsing() took care of showing the right card (either the first,
+ or any named card in the document, specified by document URL reference). Change this
+ behaviour to support displaying partially parsed WML document fragments: Mark the first
+ WMLCardElement inserted into the document as visible. If the document parsing finishes
+ without problems, WMLDocument::finishedParsing() will be called, which takes care of
+ showing the desired card (common case: first card in the document, which is already
+ visible, so nothing actually has to be done). If an error occours, the document is
+ correctly rendered until the error happened - wrapped in a XHTML document.
+
+ Fixes: fast/wml/err-event-binding-conflict.wml
+ fast/wml/err-invalid-variable-name.wml
+ fast/wml/err-multi-access.wml
+ fast/wml/err-unallowed-task-in-anchor.wml
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLAccessElement.cpp:
+ (WebCore::WMLAccessElement::parseMappedAttribute):
+ (WebCore::WMLAccessElement::insertedIntoDocument):
+ * wml/WMLAccessElement.h:
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::insertedIntoDocument):
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ * wml/WMLCardElement.h:
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing):
+ * wml/WMLErrorHandling.cpp: Added.
+ (WebCore::reportWMLError):
+ * wml/WMLErrorHandling.h: Added.
+ (WebCore::):
+ * wml/WMLIntrinsicEventHandler.cpp:
+ (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
+ * wml/WMLIntrinsicEventHandler.h:
+ * wml/WMLNoopElement.cpp:
+ (WebCore::WMLNoopElement::insertedIntoDocument):
+ * wml/WMLOnEventElement.cpp:
+ (WebCore::WMLOnEventElement::parseMappedAttribute):
+ (WebCore::WMLOnEventElement::registerTask):
+ * wml/WMLPageState.cpp:
+ (WebCore::WMLPageState::setNeedCheckDeckAccess):
+ * wml/WMLPageState.h:
+ * wml/WMLSetvarElement.cpp:
+ (WebCore::WMLSetvarElement::parseMappedAttribute):
+
+2008-11-26 Glenn Wilson <gwilson@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed bug http://bugs.webkit.org/show_bug.cgi?id=21953
+
+ This fixes the crash when the small-caps font variant is used
+ on a lower-case glyph that does not have a corresponding
+ upper-case glyph defined in the set of available fonts.
+
+ This changes Font.cpp to check if the font being used exists before trying to apply the small-caps variant.
+
+ Test: fast/css/small-caps-crash.html
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::glyphDataForCharacter):
+
+2008-11-26 Tony Chang <tony@chromium.org>
+
+ Reviewed by Oliver Hunt.
+
+ Add a new platform specific method cleanupAfterSystemDrag
+ that platforms can ue to clean up drag state after a
+ system drag. Use this method on PLAFORM(MAC).
+ https://bugs.webkit.org/show_bug.cgi?id=21956
+
+ * ChangeLog:
+ * page/DragController.cpp:
+ (WebCore::DragController::doSystemDrag):
+ * page/DragController.h:
+ * page/gtk/DragControllerGtk.cpp:
+ (WebCore::DragController::cleanupAfterSystemDrag):
+ * page/mac/DragControllerMac.mm:
+ (WebCore::DragController::cleanupAfterSystemDrag):
+ * page/qt/DragControllerQt.cpp:
+ (WebCore::DragController::cleanupAfterSystemDrag):
+ * page/win/DragControllerWin.cpp:
+ (WebCore::DragController::cleanupAfterSystemDrag):
+ * page/wx/DragControllerWx.cpp:
+ (WebCore::DragController::cleanupAfterSystemDrag):
+
+2008-11-26 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix path to string logic, correctly taking closed (sub-)paths into account.
+ Code was just broken on cg, observed by Dirk Schulze.
+
+ QPainterPath doesn't seem to expose any functionality to detect closed sub paths,
+ using the elementAt() function. There might be a workaround - Dirk will investigate.
+
+ * platform/graphics/cg/PathCG.cpp:
+ (WebCore::CGPathToCFStringApplierFunction):
+ * platform/graphics/cairo/PathCairo.cpp:
+ (WebCore::Path::debugString):
+
+2008-11-26 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22519
+ Remove unnecessary include.
+
+ * dom/XMLTokenizer.cpp:
+
+2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Oliver Hunt.
+
+ Add <noop> element support, completing the task element support.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLNoopElement.cpp: Added.
+ (WebCore::WMLNoopElement::WMLNoopElement):
+ (WebCore::WMLNoopElement::insertedIntoDocument):
+ * wml/WMLNoopElement.h: Added.
+ * wml/WMLTagNames.in: Reorganize file a bit.
+
+2008-11-26 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
+ https://bugs.webkit.org/show_bug.cgi?id=22441
+
+ Make more HTML elements' constructors take a QualifiedName.
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::createDeletionUI):
+ * html/HTMLBlockquoteElement.cpp:
+ (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
+ * html/HTMLBlockquoteElement.h:
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::HTMLButtonElement):
+ * html/HTMLButtonElement.h:
+ * html/HTMLDListElement.cpp:
+ (WebCore::HTMLDListElement::HTMLDListElement):
+ * html/HTMLDListElement.h:
+ * html/HTMLDirectoryElement.cpp:
+ (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
+ * html/HTMLDirectoryElement.h:
+ * html/HTMLDivElement.cpp:
+ (WebCore::HTMLDivElement::HTMLDivElement):
+ * html/HTMLDivElement.h:
+ * html/HTMLElementFactory.cpp:
+ (WebCore::styleConstructor):
+ (WebCore::titleConstructor):
+ (WebCore::frameConstructor):
+ (WebCore::framesetConstructor):
+ (WebCore::iframeConstructor):
+ (WebCore::formConstructor):
+ (WebCore::buttonConstructor):
+ (WebCore::inputConstructor):
+ (WebCore::isindexConstructor):
+ (WebCore::fieldsetConstructor):
+ (WebCore::keygenConstructor):
+ (WebCore::labelConstructor):
+ (WebCore::legendConstructor):
+ (WebCore::optgroupConstructor):
+ (WebCore::optionConstructor):
+ (WebCore::selectConstructor):
+ (WebCore::textareaConstructor):
+ (WebCore::dlConstructor):
+ (WebCore::ulConstructor):
+ (WebCore::olConstructor):
+ (WebCore::dirConstructor):
+ (WebCore::menuConstructor):
+ (WebCore::liConstructor):
+ (WebCore::blockquoteConstructor):
+ (WebCore::divConstructor):
+ (WebCore::headingConstructor):
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
+ * html/HTMLFieldSetElement.h:
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::HTMLFormElement):
+ * html/HTMLFormElement.h:
+ * html/HTMLFrameElement.cpp:
+ (WebCore::HTMLFrameElement::HTMLFrameElement):
+ * html/HTMLFrameElement.h:
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
+ * html/HTMLFrameSetElement.h:
+ * html/HTMLIFrameElement.cpp:
+ (WebCore::HTMLIFrameElement::HTMLIFrameElement):
+ * html/HTMLIFrameElement.h:
+ * html/HTMLInputElement.cpp:
+ * html/HTMLInputElement.h:
+ * html/HTMLIsIndexElement.cpp:
+ (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
+ * html/HTMLIsIndexElement.h:
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::HTMLKeygenElement):
+ * html/HTMLKeygenElement.h:
+ * html/HTMLLIElement.cpp:
+ (WebCore::HTMLLIElement::HTMLLIElement):
+ * html/HTMLLIElement.h:
+ * html/HTMLLabelElement.cpp:
+ (WebCore::HTMLLabelElement::HTMLLabelElement):
+ * html/HTMLLabelElement.h:
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::HTMLLegendElement):
+ * html/HTMLLegendElement.h:
+ * html/HTMLMenuElement.cpp:
+ (WebCore::HTMLMenuElement::HTMLMenuElement):
+ * html/HTMLMenuElement.h:
+ * html/HTMLOListElement.cpp:
+ (WebCore::HTMLOListElement::HTMLOListElement):
+ * html/HTMLOListElement.h:
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
+ * html/HTMLOptGroupElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::HTMLOptionElement):
+ * html/HTMLOptionElement.h:
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::formCreateErrorCheck):
+ (WebCore::HTMLParser::handleIsindex):
+ * html/HTMLSelectElement.cpp:
+ * html/HTMLSelectElement.h:
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::HTMLStyleElement):
+ * html/HTMLStyleElement.h:
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
+ * html/HTMLTextAreaElement.h:
+ * html/HTMLTitleElement.cpp:
+ (WebCore::HTMLTitleElement::HTMLTitleElement):
+ * html/HTMLTitleElement.h:
+ * html/HTMLUListElement.cpp:
+ (WebCore::HTMLUListElement::HTMLUListElement):
+ * html/HTMLUListElement.h:
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::createContainingTable):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createPanel):
+ (WebCore::RenderMedia::createTimeDisplay):
+ * rendering/RenderSlider.cpp:
+ (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerElement::TextControlInnerElement):
+
+2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix obvious problem in WMLPageState constructor, m_page was not set to the passed Page pointer.
+
+ * wml/WMLPageState.cpp:
+ (WebCore::WMLPageState::WMLPageState):
+
+2008-11-26 Matt Perry <mpcomplete@gmail.com>
+
+ Fix Qt bustage.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=22051
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::extraDefaultStyleSheet):
+
+2008-11-26 Matt Perry <mpcomplete@gmail.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=22051
+ Renderthemes should be able to supply additional CSS rules to the core
+ ones.
+
+ * DerivedSources.make:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::parseUASheet):
+ (WebCore::loadFullDefaultStyle):
+ (WebCore::loadSimpleDefaultStyle):
+ * css/themeWin.css: Added.
+ * css/themeWinQuirks.css: Added.
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::extraDefaultStyleSheet):
+ * platform/qt/RenderThemeQt.h:
+ * rendering/RenderTheme.cpp:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::extraDefaultStyleSheet):
+ (WebCore::RenderTheme::extraQuirksStyleSheet):
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::extraDefaultStyleSheet):
+ (WebCore::RenderThemeWin::extraQuirksStyleSheet):
+ * rendering/RenderThemeWin.h:
+
+2008-11-26 David Kilzer <ddkilzer@apple.com>
+
+ Make CSSStyleSheet::addSubresourceURLStrings() iterative
+
+ Part of the fix for Bug 11850: Webarchive fails to save images referenced in CSS
+ <https://bugs.webkit.org/show_bug.cgi?id=11850>
+
+ Reviewed by Brady Eidson.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::addSubresourceURLStrings): Switch algorithm
+ from recursive to iterative for gathering the list of all CSS
+ stylesheets referenced in @import statements.
+
+2008-11-26 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ Transformations to the context shouldn't transform the currentPath.
+ Fixed this on Qt.
+
+ [QT] GraphicsContext's currenPath can be transformed
+ https://bugs.webkit.org/show_bug.cgi?id=22163
+
+ * platform/graphics/GraphicsContextPrivate.h:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::restorePlatformState):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::translate):
+ (WebCore::GraphicsContext::rotate):
+ (WebCore::GraphicsContext::scale):
+ (WebCore::GraphicsContext::concatCTM):
+
+2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build script minor fixes. Not reviewed.
+
+ * GNUmakefile.am:
+ - Add ScriptInstance.h (introduced in r38774) to
+ the build.
+ - Move WML and GEOLOCATION conditionals before the SVG
+ conditional to be consistent with the style of the script.
+ - Move GeolocationGtk sources to webcoregtk_sources.
+
+2008-11-26 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Darin Adler and Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22469
+
+ Move the class DOMWindowTimer from JSDOMWindowBase into its own file in
+ preparation to making it work for Workers. For now, just move the code and couple
+ of global variables.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::installTimeout):
+ (WebCore::JSDOMWindowBase::pauseTimeouts):
+ (WebCore::JSDOMWindowBase::resumeTimeouts):
+ (WebCore::JSDOMWindowBase::timerFired):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/DOMTimer.cpp: Added.
+ (WebCore::DOMTimer::DOMTimer):
+ (WebCore::DOMTimer::~DOMTimer):
+ (WebCore::DOMTimer::fired):
+ * bindings/js/DOMTimer.h: Added.
+ (WebCore::DOMTimer::timeoutId):
+ (WebCore::DOMTimer::nestingLevel):
+ (WebCore::DOMTimer::setNestingLevel):
+ (WebCore::DOMTimer::action):
+ (WebCore::DOMTimer::takeAction):
+
+2008-11-25 Darin Fisher <darin@chromium.org>
+
+ Fix bustage.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22493
+ Need to expose bridge/*.h to the WebKit build.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-11-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Fix build, by removing some wrong last-minute changes.
+
+ * wml/WMLIntrinsicEvent.cpp:
+ (WebCore::createTaskElement):
+ * wml/WMLOnEventElement.cpp:
+ (WebCore::WMLOnEventElement::registerTask):
+
+2008-11-25 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22493
+ Abstract away JSC:: usage in WebCore/html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::pluginInstance):
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/js/ScriptInstance.h: Added.
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
+ (WebCore::HTMLPlugInElement::getInstance):
+ * html/HTMLPlugInElement.h:
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477
+
+ A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
+ Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.
+
+ Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
+ centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
+ function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
+ <template>/<option> or <card> element.
+
+ Add complete <onevent> support.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ * wml/WMLCardElement.h:
+ (WebCore::WMLCardElement::isVisible):
+ (WebCore::WMLCardElement::setVisible):
+ * wml/WMLElement.h:
+ (WebCore::WMLElement::isWMLTaskElement):
+ * wml/WMLEventHandlingElement.cpp: Added.
+ (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
+ (WebCore::WMLEventHandlingElement::createEventHandlerIfNeeded):
+ * wml/WMLEventHandlingElement.h: Added.
+ (WebCore::WMLEventHandlingElement::isWMLEventHandlingElement):
+ (WebCore::WMLEventHandlingElement::eventHandler):
+ * wml/WMLOnEventElement.cpp: Added.
+ (WebCore::WMLOnEventElement::WMLOnEventElement):
+ (WebCore::WMLOnEventElement::parseMappedAttribute):
+ (WebCore::WMLOnEventElement::registerTask):
+ * wml/WMLOnEventElement.h: Added.
+ * wml/WMLSetvarElement.cpp:
+ (WebCore::WMLSetvarElement::parseMappedAttribute):
+ (WebCore::WMLSetvarElement::insertedIntoDocument):
+ * wml/WMLTagNames.in:
+ * wml/WMLTaskElement.cpp:
+ (WebCore::WMLTaskElement::insertedIntoDocument):
+ * wml/WMLTaskElement.h:
+ (WebCore::WMLTaskElement::isWMLTaskElement):
+
+2008-11-25 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL
+
+ https://bugs.webkit.org/show_bug.cgi?id=22503
+
+ * platform/graphics/mac/FontCustomPlatformData.cpp:
+ (WebCore::createFontCustomPlatformData):
+
+2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
+ https://bugs.webkit.org/show_bug.cgi?id=22441
+
+ Element's other than HTML ones take a QualifiedName in their constructors.
+ To make HTMLElementFactory closer to the other ElementFactory, we need
+ to make them take the same arguments.
+ This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
+ will go into the next patch.
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ * html/HTMLBaseElement.cpp:
+ (WebCore::HTMLBaseElement::HTMLBaseElement):
+ * html/HTMLBaseElement.h:
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::HTMLBodyElement):
+ * html/HTMLBodyElement.h:
+ * html/HTMLElementFactory.cpp:
+ (WebCore::htmlConstructor):
+ (WebCore::headConstructor):
+ (WebCore::bodyConstructor):
+ (WebCore::baseConstructor):
+ (WebCore::linkConstructor):
+ (WebCore::metaConstructor):
+ * html/HTMLHeadElement.cpp:
+ (WebCore::HTMLHeadElement::HTMLHeadElement):
+ * html/HTMLHeadElement.h:
+ * html/HTMLHtmlElement.cpp:
+ (WebCore::HTMLHtmlElement::HTMLHtmlElement):
+ * html/HTMLHtmlElement.h:
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::HTMLLinkElement):
+ * html/HTMLLinkElement.h:
+ * html/HTMLMetaElement.cpp:
+ (WebCore::HTMLMetaElement::HTMLMetaElement):
+ * html/HTMLMetaElement.h:
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError):
+ (WebCore::HTMLParser::headCreateErrorCheck):
+ (WebCore::HTMLParser::createHead):
+ (WebCore::HTMLParser::finished):
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::createContainingTable):
+
+2008-11-25 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
+ I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.
+
+ Tests: animations/empty-keyframes.html
+ animations/fill-unset-properties.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
+
+2008-11-25 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=22046
+
+ Fix a crash when an animation or transition end event handler
+ removes the element upon which the transition/animation is running,
+ by keeping a reference to the AnimationBase object on the stack.
+
+ Tests: animations/transform-animation-event-destroy-element.html
+ transitions/transform-transition-event-destroy-element.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::setChanged):
+ (WebCore::AnimationBase::updateStateMachine):
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::clearRenderer):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::clear):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
+ * page/animation/CompositeAnimation.h:
+
+2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
+
+ Better wx build fix - support PurgeableBuffer on Mac.
+
+ * platform/PurgeableBuffer.h:
+ * webcore-wx.bkl:
+
+2008-11-25 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22022
+
+ Add GeoleocationServiceGtk stubs and integrate it into the buildsystem
+
+ Add stubs for a Gtk Implementation.
+
+ * GNUmakefile.am:
+ * platform/gtk/GeolocationServiceGtk.cpp: Added.
+ (WebCore::GeolocationService::create):
+ (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
+ (WebCore::GeolocationServiceGtk::startUpdating):
+ (WebCore::GeolocationServiceGtk::stopUpdating):
+ (WebCore::GeolocationServiceGtk::suspend):
+ (WebCore::GeolocationServiceGtk::resume):
+ (WebCore::GeolocationServiceGtk::lastPosition):
+ (WebCore::GeolocationServiceGtk::lastError):
+ * platform/gtk/GeolocationServiceGtk.h: Added.
+
+2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix - we don't support PurgeableBuffer on Leopard for now.
+
+ * platform/PurgeableBuffer.h:
+
+2008-11-25 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=22483
+ Assertion failure in CachedResource::makePurgeable during layout tests
+
+ Deleting SVG image can re-enter destroyDecodedData.
+
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::destroyDecodedData):
+
+2008-11-25 David Levin <levin@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22443
+ Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
+ Workers on threads.
+
+ No observable change in behavior, so no test.
+
+ * platform/text/PlatformString.h:
+ * platform/text/String.cpp:
+ (WebCore::String::substringCopy):
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::substringCopy):
+ * platform/text/StringImpl.h:
+ Added the ability to copy a substring.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
+ (WebCore::PreflightResultCache::PreflightResultCache):
+ (WebCore::PreflightResultCacheItem::addToAccessControlAllowList):
+ (WebCore::PreflightResultCacheItem::parseAccessControlAllowList):
+ (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge):
+ (WebCore::PreflightResultCacheItem::parse):
+ (WebCore::PreflightResultCacheItem::allowsRequest):
+ (WebCore::PreflightResultCache::shared):
+ (WebCore::PreflightResultCache::appendEntry):
+ (WebCore::PreflightResultCache::canSkipPreflight):
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ Made the PreflightResultCache threadsafe.
+
+ (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
+ (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
+ Consolidation of duplicate logic.
+
+2008-11-24 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ For Unicode encodings other than UTF-8, use UTF-8 for
+ form submission and URL query part encoding.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=21635
+
+ Tests: http/tests/misc/submit-get-in-utf16be.html
+ http/tests/misc/submit-get-in-utf16le.html
+ http/tests/misc/submit-get-in-utf32be.html
+ http/tests/misc/submit-get-in-utf32le.html
+ http/tests/misc/submit-get-in-utf7.html
+ http/tests/misc/submit-post-in-utf16be.html
+ http/tests/misc/submit-post-in-utf16le.html
+ http/tests/misc/submit-post-in-utf32be.html
+ http/tests/misc/submit-post-in-utf32le.html
+ http/tests/misc/submit-post-in-utf7.html
+ http/tests/misc/url-in-utf16be.html
+ http/tests/misc/url-in-utf16le.html
+ http/tests/misc/url-in-utf32be.html
+ http/tests/misc/url-in-utf32le.html
+ http/tests/misc/url-in-utf7.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::formData):
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::setEncoding):
+ * platform/KURL.cpp:
+ (WebCore::KURL::KURL):
+ * platform/text/TextEncoding.cpp:
+ (WebCore::UTF7Encoding):
+ (WebCore::TextEncoding::isNonByteBasedEncoding):
+ (WebCore::TextEncoding::closestByteBasedEquivalent):
+ (WebCore::TextEncoding::encodingForFormSubmission):
+ * platform/text/TextEncoding.h:
+
+2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
+ https://bugs.webkit.org/show_bug.cgi?id=22441
+
+ - Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
+
+ - Tweaked the generated files to better match our coding style.
+
+ * dom/make_names.pl:
+
+2008-11-24 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
+ REGRESSION(r33544): Palace in the Sky crashes WebKit
+
+ HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
+ there were no scripts left to execute.
+
+ If m_hasScriptsWaitingForStylesheets becomes true during script execution
+ bail out from executing more scripts synchronously.
+
+ Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html
+
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::reset):
+ (WebCore::HTMLTokenizer::notifyFinished):
+
+2008-11-24 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22465
+ Define KURL::copy() and use it in WorkerThread.cpp
+
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::WorkerThread):
+ * platform/KURL.cpp:
+ (WebCore::KURL::copy):
+ * platform/KURL.h:
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Name enum values in a style guide compatible way.
+ Allow WMLIntrinsicEvent inclusion, without needing other includes.
+
+ * wml/WMLIntrinsicEvent.cpp:
+ (WebCore::createTaskElement):
+ * wml/WMLIntrinsicEvent.h:
+ * wml/WMLIntrinsicEventHandler.cpp:
+ * wml/WMLIntrinsicEventHandler.h:
+ (WebCore::):
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Add wmlPageStateForDocument() helper function and use it in some places.
+
+ * wml/WMLAccessElement.cpp:
+ (WebCore::WMLAccessElement::parseMappedAttribute):
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::WMLDocument):
+ (WebCore::WMLDocument::finishedParsing):
+ (WebCore::wmlPageStateForDocument):
+ * wml/WMLDocument.h:
+ * wml/WMLGoElement.cpp:
+ (WebCore::WMLGoElement::executeTask):
+ * wml/WMLPrevElement.cpp:
+ (WebCore::WMLPrevElement::executeTask):
+ * wml/WMLRefreshElement.cpp:
+ (WebCore::WMLRefreshElement::executeTask):
+ * wml/WMLTaskElement.cpp:
+ (WebCore::WMLTaskElement::storeVariableState):
+ * wml/WMLTaskElement.h:
+
+2008-11-24 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Geoff Garen and Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22214
+ Keep dead resources in memory cache in purgeable memory.
+ <rdar://problem/6333088>
+
+ OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
+ areas as less important. Under memory pressure system can steal pages that have
+ been marked purgeable for (hopefully) better uses. This is ideal for caches.
+
+ Only resources larger than 16KB will be moved to the purgeable memory.
+
+ * WebCore.base.exp:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/Cache.cpp:
+ (WebCore::Cache::requestResource):
+ (WebCore::Cache::requestUserCSSStyleSheet):
+ (WebCore::Cache::resourceForURL):
+ (WebCore::Cache::pruneDeadResources):
+ (WebCore::Cache::TypeStatistic::addResource):
+ (WebCore::Cache::getStatistics):
+ (WebCore::Cache::dumpStats):
+ * loader/Cache.h:
+ (WebCore::Cache::TypeStatistic::TypeStatistic):
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::allClientsRemoved):
+ (WebCore::CachedCSSStyleSheet::sheetText):
+ * loader/CachedCSSStyleSheet.h:
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::addClient):
+ (WebCore::CachedImage::image):
+ (WebCore::CachedImage::imageSize):
+ (WebCore::CachedImage::imageRect):
+ (WebCore::CachedImage::destroyDecodedData):
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::addClient):
+ (WebCore::CachedResource::makePurgeable):
+ (WebCore::CachedResource::isPurgeable):
+ (WebCore::CachedResource::wasPurged):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::data):
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::allClientsRemoved):
+ (WebCore::CachedScript::script):
+ (WebCore::CachedScript::destroyDecodedData):
+ * platform/PurgeableBuffer.h: Added.
+ (WebCore::PurgeableBuffer::create):
+ (WebCore::PurgeableBuffer::size):
+ (WebCore::PurgeableBuffer::):
+ (WebCore::PurgeableBuffer::purgePriority):
+ (WebCore::PurgeableBuffer::isPurgeable):
+ (WebCore::PurgeableBuffer::~PurgeableBuffer):
+ (WebCore::PurgeableBuffer::data):
+ (WebCore::PurgeableBuffer::setPurgePriority):
+ (WebCore::PurgeableBuffer::wasPurged):
+ (WebCore::PurgeableBuffer::makePurgeable):
+ * platform/SharedBuffer.cpp:
+ (WebCore::SharedBuffer::~SharedBuffer):
+ (WebCore::SharedBuffer::adoptPurgeableBuffer):
+ (WebCore::SharedBuffer::size):
+ (WebCore::SharedBuffer::data):
+ (WebCore::SharedBuffer::append):
+ (WebCore::SharedBuffer::clear):
+ (WebCore::SharedBuffer::releasePurgeableBuffer):
+ * platform/SharedBuffer.h:
+ (WebCore::SharedBuffer::hasPurgeableBuffer):
+ * platform/cf/SharedBufferCF.cpp:
+ * platform/mac/PurgeableBufferMac.cpp: Added.
+ (WebCore::PurgeableBuffer::PurgeableBuffer):
+ (WebCore::PurgeableBuffer::~PurgeableBuffer):
+ (WebCore::PurgeableBuffer::create):
+ (WebCore::PurgeableBuffer::makePurgeable):
+ (WebCore::PurgeableBuffer::wasPurged):
+ (WebCore::PurgeableBuffer::setPurgePriority):
+ (WebCore::PurgeableBuffer::data):
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos & Eric Seidel.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22430
+
+ Regenerate WML layout test results after implementing WML specific <card> handling:
+ Only the first <card> element should be visible after loading the document, others
+ can be shown by using the <go> task element.
+
+ * dom/Document.h: Make 'finishedParsing()' a virtual function.
+ * wml/WMLCardElement.cpp:
+ (WebCore::WMLCardElement::WMLCardElement):
+ (WebCore::WMLCardElement::~WMLCardElement):
+ (WebCore::WMLCardElement::createRenderer):
+ (WebCore::WMLCardElement::setActiveCardInDocument):
+ (WebCore::WMLCardElement::setVisibility):
+ * wml/WMLCardElement.h:
+ * wml/WMLDocument.cpp:
+ (WebCore::WMLDocument::finishedParsing): Execute WML specific logic after tokenzing.
+ * wml/WMLDocument.h:
+
+2008-11-24 Glenn Wilson <gwilson@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ http://bugs.webkit.org/show_bug.cgi?id=15643
+
+ Added support for clients that wish to disable smart insert/delete
+ and enable the "trailing whitespace selection" work-around.
+
+ Tests: editing/selection/doubleclick-whitespace.html
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectTrailingWhitespaceEnabled):
+ * editing/Editor.h:
+ * editing/Selection.cpp:
+ (WebCore::Selection::includeTrailingWhitespace):
+ * editing/Selection.h:
+ * loader/EmptyClients.h:
+ (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
+ * page/EditorClient.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::selectClosestWordFromMouseEvent):
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Forgot to include WMLPageState.h in last commit.
+
+ * wml/WMLPageState.h:
+ (WebCore::WMLPageState::restrictDeckAccessToDomain):
+ (WebCore::WMLPageState::restrictDeckAccessToPath):
+
+2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Oliver Hunt & Eric Seidel.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22431
+
+ Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLAccessElement.cpp: Added.
+ (WebCore::WMLAccessElement::WMLAccessElement):
+ (WebCore::WMLAccessElement::parseMappedAttribute):
+ * wml/WMLAccessElement.h: Added.
+ * wml/WMLTagNames.in:
+ * wml/WMLPageState.h: Rename functions.
+ (WebCore::WMLPageState::restrictDeckAccessToDomain):
+ (WebCore::WMLPageState::restrictDeckAccessToPath):
+ * wml/WMLVariables.cpp: Add new helper function.
+ (WebCore::valueContainsVariableReference):
+ * wml/WMLVariables.h:
+ (WebCore::):
+
+2008-11-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22470
+ remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL.
+ (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
+ * loader/FrameLoaderClient.h: Remove argument.
+
+2008-11-24 Finnur Thorarinsson <finnur.webkit@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22432
+
+ Add plumbing for tickmark support for the scrollbars. The painting code
+ for the scrollbar just needed to call paintTickmarks at the right time
+ and a default no-op implementation is provided, which the ports will
+ need to override.
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::paintTickmarks):
+
+2008-11-24 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22448
+ Create an abstraction for JSC::SourceCode
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * bindings/js/CachedScriptSourceProvider.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptSourceCode.h: Added.
+ (WebCore::ScriptSourceCode::ScriptSourceCode):
+ (WebCore::ScriptSourceCode::length):
+ (WebCore::ScriptSourceCode::jsSourceCode):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::Workevn ScriptController::evaluate):
+ * bindings/js/WorkerScriptController.h:
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElement::insertedIntoDocument):
+ (WebCore::ScriptElement::childrenChanged):
+ (WebCore::ScriptElementData::evaluateScript):
+ (WebCore::ScriptElementData::notifyFinished):
+ * dom/ScriptElement.h:
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::workerThread):
+ * dom/WorkerThread.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::endElementNs):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseEndElement):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::scriptHandler):
+ (WebCore::HTMLTokenizer::scriptExecution):
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * html/HTMLTokenizer.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeScript):
+ * loader/FrameLoader.h:
+
+2008-11-24 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - finish https://bugs.webkit.org/show_bug.cgi?id=22295
+ track which history items are from page load failures
+
+ * WebCore.base.exp: Exported new function.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
+ * loader/DocumentLoader.h: Ditto.
+
+2008-11-24 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class
+ https://bugs.webkit.org/show_bug.cgi?id=22461
+
+ Changing AccessibilityListBox to use its parent's signature for hit testing
+
+ * page/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::doAccessibilityHitTest):
+ * page/AccessibilityListBox.h:
+
+2008-11-24 Simon Fraser <simon.fraser@apple.com>
+
+ Fix Windows build: selectionRect() -> selectionBounds().
+
+ * page/win/FrameCGWin.cpp:
+ (WebCore::imageFromSelection):
+
+2008-11-24 Glenn Wilson <gwilson@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ http://bugs.webkit.org/show_bug.cgi?id=18703
+ "Changing the 'size' property on a text input does not affect its length"
+
+ Text fields would not repaint themselves after having their "size"
+ attributes modified. This fix tells the object to recalculate its
+ width and repaint itself when its "size" attribute is parsed.
+
+ Test: fast/js/text-field-resize.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+
+2008-11-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ Followup from changes for https://bugs.webkit.org/show_bug.cgi?id=22433
+
+ Make RenderView::selectionRect() private to cause compile-time
+ errors if someone tries to call it.
+
+ * rendering/RenderView.h:
+
+2008-11-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Via: https://bugs.webkit.org/show_bug.cgi?id=22433
+
+ Rename RenderView::selectionRect() to selectionBounds(), to remove
+ longstanding ambiguity with the base class selectionRect() method.
+ Do the same on Frame for consistency with RenderView. Assert
+ that RenderView::selectionRect() is never called.
+
+ * WebCore.base.exp:
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * page/DragController.cpp:
+ (WebCore::dragLocForSelectionDrag):
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionBounds):
+ (WebCore::Frame::revealSelection):
+ * page/Frame.h:
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::selectionImage):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::selectionRect):
+ (WebCore::RenderView::selectionBounds):
+ * rendering/RenderView.h:
+
+2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
+ https://bugs.webkit.org/show_bug.cgi?id=22441
+
+ - Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of
+ an AtomicString.
+
+ - Updated the elements' constructors and the callers to reflect the previous change.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createElement):
+ * html/HTMLDocument.cpp:
+ (WebCore::HTMLDocument::createElement):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::cloneNode):
+ * html/HTMLElementFactory.cpp:
+ (WebCore::htmlConstructor):
+ (WebCore::headConstructor):
+ (WebCore::bodyConstructor):
+ (WebCore::baseConstructor):
+ (WebCore::linkConstructor):
+ (WebCore::metaConstructor):
+ (WebCore::styleConstructor):
+ (WebCore::titleConstructor):
+ (WebCore::frameConstructor):
+ (WebCore::framesetConstructor):
+ (WebCore::iframeConstructor):
+ (WebCore::formConstructor):
+ (WebCore::buttonConstructor):
+ (WebCore::inputConstructor):
+ (WebCore::isindexConstructor):
+ (WebCore::fieldsetConstructor):
+ (WebCore::keygenConstructor):
+ (WebCore::labelConstructor):
+ (WebCore::legendConstructor):
+ (WebCore::optgroupConstructor):
+ (WebCore::optionConstructor):
+ (WebCore::selectConstructor):
+ (WebCore::textareaConstructor):
+ (WebCore::dlConstructor):
+ (WebCore::ulConstructor):
+ (WebCore::olConstructor):
+ (WebCore::dirConstructor):
+ (WebCore::menuConstructor):
+ (WebCore::liConstructor):
+ (WebCore::blockquoteConstructor):
+ (WebCore::divConstructor):
+ (WebCore::headingConstructor):
+ (WebCore::hrConstructor):
+ (WebCore::paragraphConstructor):
+ (WebCore::preConstructor):
+ (WebCore::basefontConstructor):
+ (WebCore::fontConstructor):
+ (WebCore::modConstructor):
+ (WebCore::anchorConstructor):
+ (WebCore::imageConstructor):
+ (WebCore::mapConstructor):
+ (WebCore::areaConstructor):
+ (WebCore::canvasConstructor):
+ (WebCore::appletConstructor):
+ (WebCore::embedConstructor):
+ (WebCore::objectConstructor):
+ (WebCore::paramConstructor):
+ (WebCore::scriptConstructor):
+ (WebCore::tableConstructor):
+ (WebCore::tableCaptionConstructor):
+ (WebCore::tableColConstructor):
+ (WebCore::tableRowConstructor):
+ (WebCore::tableCellConstructor):
+ (WebCore::tableSectionConstructor):
+ (WebCore::brConstructor):
+ (WebCore::quoteConstructor):
+ (WebCore::marqueeConstructor):
+ (WebCore::audioConstructor):
+ (WebCore::videoConstructor):
+ (WebCore::sourceConstructor):
+ (WebCore::HTMLElementFactory::createHTMLElement):
+ * html/HTMLElementFactory.h:
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::getNode):
+
+2008-11-24 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22444
+
+ Correct bad default constructor for Cairo FontPlatformData so that
+ the m_scaledFont member is initialized. Previously this would be
+ set to 0xbaadf00d, which would result in infinite loops while
+ attempting to deal with the font cache.
+
+ * platform/graphics/win/FontPlatformData.h:
+ (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
+
+2008-11-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22455
+ Add support for Worker.terminate()
+
+ Test: fast/workers/worker-terminate.html
+
+ * dom/Worker.idl:
+ * dom/Worker.cpp:
+ * dom/Worker.h:
+ Added terminate().
+
+ * dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked
+ to terminate (this is not mentioned in draft spec, but makes sense anyway).
+ (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was
+ asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount
+ to only track messages that were posted to worker thread, avoiding a leak if the script
+ could not be loaded.
+ (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating.
+ (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for.
+ (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context
+ was destroyed, the worker object may still be alive now, so don't delete self in this case.
+ (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or
+ remember to stop it when it is created.
+ (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity
+ if the thread asked to stop anyway.
+ (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
+
+ * dom/WorkerThread.cpp:
+ * dom/WorkerThread.h:
+ Fixed a race condition in stop().
+
+2008-11-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22439
+ Won't load stylesheets with filenames less than 2 characters long in xhtml.
+
+ Test: http/tests/misc/single-character-pi-stylesheet.xhtml
+
+ * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
+ Fix up the logic.
+
+2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Mark Rowe.
+
+ [Gtk+] Add configure option to enable Web Workers and enable it by default
+
+ Add --enable-workers to the buildsystem (used by build-webkit) add
+ the to be build files to the GNUmakefile.am and change build-webkit
+ to enable Web Workers by default.
+
+ * GNUmakefile.am:
+
+2008-11-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Build fix (for Windows Cairo port?)
+
+ * page/DOMWindow.idl: Use ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as
+ the ENABLE macro is not available in idls.
+
+2008-11-22 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22421
+ Added ScriptValue to Visual Studio and XCode projects.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Holger Freyther.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22426
+
+ Add WMLInstrinsicEvent/EventHandler implementation. Code not yet used.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * wml/WMLIntrinsicEvent.cpp: Added.
+ (WebCore::createTaskElement):
+ (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
+ * wml/WMLIntrinsicEvent.h: Added.
+ (WebCore::WMLIntrinsicEvent::create):
+ (WebCore::WMLIntrinsicEvent::createWithTask):
+ (WebCore::WMLIntrinsicEvent::taskElement):
+ * wml/WMLIntrinsicEventHandler.cpp: Added.
+ (WebCore::WMLIntrinsicEventHandler::WMLIntrinsicEventHandler):
+ (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
+ (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
+ (WebCore::WMLIntrinsicEventHandler::hasIntrinsicEvent):
+ * wml/WMLIntrinsicEventHandler.h: Added.
+ (WebCore::):
+
+2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Holger Freyther.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22423
+
+ Add <go> stub implementation. Add complete <prev>/<refresh> and <setvar> implementation.
+ Activate code handling <setvar> registration in WMLTaskElement.
+
+ * wml/WMLGoElement.cpp: Added.
+ (WebCore::WMLGoElement::WMLGoElement):
+ (WebCore::WMLGoElement::~WMLGoElement):
+ (WebCore::WMLGoElement::parseMappedAttribute):
+ (WebCore::WMLGoElement::executeTask):
+ * wml/WMLGoElement.h: Added.
+ * wml/WMLPrevElement.cpp: Added.
+ (WebCore::WMLPrevElement::WMLPrevElement):
+ (WebCore::WMLPrevElement::~WMLPrevElement):
+ (WebCore::WMLPrevElement::executeTask):
+ * wml/WMLPrevElement.h: Added.
+ * wml/WMLRefreshElement.cpp: Added.
+ (WebCore::WMLRefreshElement::WMLRefreshElement):
+ (WebCore::WMLRefreshElement::~WMLRefreshElement):
+ (WebCore::WMLRefreshElement::executeTask):
+ * wml/WMLRefreshElement.h: Added.
+ * wml/WMLSetvarElement.cpp: Added.
+ (WebCore::WMLSetvarElement::WMLSetvarElement):
+ (WebCore::WMLSetvarElement::~WMLSetvarElement):
+ (WebCore::WMLSetvarElement::parseMappedAttribute):
+ (WebCore::WMLSetvarElement::insertedIntoDocument):
+ (WebCore::WMLSetvarElement::name):
+ (WebCore::WMLSetvarElement::value):
+ * wml/WMLSetvarElement.h: Added.
+ * wml/WMLTagNames.in:
+ * wml/WMLTaskElement.cpp:
+ (WebCore::WMLTaskElement::registerVariableSetter):
+ (WebCore::WMLTaskElement::storeVariableState):
+ * wml/WMLTaskElement.h:
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Forgot to include WMLPageState.* in the last commit.
+
+ * wml/WMLPageState.cpp:
+ (WebCore::WMLPageState::setNeedCheckDeckAccess):
+ * wml/WMLPageState.h:
+ (WebCore::WMLPageState::storeVariables):
+
+2008-11-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22397
+ Worker threads are not destroyed if running a JS loop
+
+ Since the event loop is not ever entered again in this case, the fix necessarily involves
+ some shared data hackery.
+
+ * dom/WorkerThread.cpp: (WebCore::WorkerThread::stop):
+ * dom/WorkerThread.h:
+ Added a stop() method, which asks the thread to exit as soon as possible. In the future, it
+ may need to abort other kinds of synchronous processing, such as importScripts or XHR.
+
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::WorkerScriptController):
+ (WebCore::WorkerScriptController::evaluate):
+ (WebCore::WorkerScriptController::forbidExecution):
+ * bindings/js/WorkerScriptController.h:
+ Added a forbidExecution() method, which interrupts currently running JS, and makes any
+ future calls to evaluate() return immediately.
+
+ * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
+ Call WorkerThread::stop().
+
+2008-11-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Improve wx image drawing performance considerably when using wxGraphicsContext
+ by avoiding unnecessary copies and drawing.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22404
+
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+ (WebCore::BitmapImage::drawPattern):
+
+
+2008-11-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Implementation of AffineTransform::mapRect for wx.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22401
+
+ * platform/graphics/wx/AffineTransformWx.cpp:
+ (WebCore::AffineTransform::mapRect):
+
+2008-11-21 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
+
+ Change link editing behavior to match TextEdit and MS Word when editing before and after
+ a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we
+ used to, so it's difficult to get out of link editing mode):
+ When inserting before or after a link, always insert content outside of the link. This
+ makes it impossible to get stuck in link editing mode, while making it slightly more
+ difficult to edit link labels. WebKit editors that care about this can add UI for editing
+ link labels, like GMail and GoogleDocs have done. We never actually had any bugs complaining
+ about how it was difficult to edit link labels at the start/end, the code was just introduced
+ with another bug fix without much thought.
+
+ Don't remember removed links anymore, no other editor does this and it made it
+ difficult/impossible to get out of link editing mode. This code was added to fix
+ <rdar://problem/4069359>, which is fixed instead by removing the styles from an
+ enclosing anchor element from those styles that we remember when we delete content.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
+ * editing/CompositeEditCommand.h:
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::removeEnclosingAnchorStyle):
+ (WebCore::DeleteSelectionCommand::saveTypingStyleState):
+ (WebCore::DeleteSelectionCommand::doApply):
+ * editing/DeleteSelectionCommand.h:
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply):
+ * editing/Editor.cpp:
+ (WebCore::Editor::appliedEditing):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::prepareForTextInsertion):
+ (WebCore::InsertTextCommand::input):
+ * editing/RemoveFormatCommand.cpp:
+ (WebCore::RemoveFormatCommand::doApply):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setSelection):
+ * editing/SelectionController.h:
+
+2008-11-21 Alice Liu <alice.liu@apple.com>
+
+ Rubber-stamped by Dan Bernstein.
+
+ fixed <rdar://6340771> crashing on print preview
+
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ (WebCore::GraphicsContext::drawWindowsBitmap):
+
+2008-11-21 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22390
+ Abstract away JSC:: usage in WebCore/xml
+
+ * bindings/js/ScriptString.h: Added.
+ (WebCore::ScriptString::ScriptString):
+ (WebCore::ScriptString::operator JSC::UString):
+ (WebCore::ScriptString::isNull):
+ (WebCore::ScriptString::size):
+ (WebCore::ScriptString::operator=):
+ (WebCore::ScriptString::operator+=):
+ * inspector/InspectorController.cpp:
+ (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
+ (WebCore::InspectorResource::setXMLHttpRequestProperties):
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
+ * inspector/InspectorController.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::responseText):
+ (WebCore::XMLHttpRequest::clearResponse):
+ (WebCore::XMLHttpRequest::dropProtection):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ (WebCore::XMLHttpRequest::didReceiveData):
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::setLastSendURL):
+
+2008-11-21 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Destroy script decoded data on a zero-delay timer after
+ decoding. This means we now have no decoded script data
+ at the end of Membuster.
+
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::CachedScript):
+ (WebCore::CachedScript::allClientsRemoved):
+ (WebCore::CachedScript::script):
+ (WebCore::CachedScript::decodedDataDeletionTimerFired):
+ * loader/CachedScript.h:
+
+2008-11-21 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=22159
+
+ RenderBox::absoluteClippedOverflowRect() needs to inflate the rect by
+ maximalOutlineSize(), since a child might have an outline which projects
+ outside the parent overflowRect().
+
+ We also need to ensure that maximalOutlineSize() is updated early in styleDidChange,
+ so that it is valid for these repaints.
+
+ Test: fast/repaint/outline-child-repaint.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::absoluteClippedOverflowRect):
+
+2008-11-21 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk, Qt, and Wx build fix.
+
+ Add LinkHash.cpp in the build scripts.
+ Add LinkHash.h to Gtk's build script.
+
+ LinkHash.cpp/h was introduced in r38661.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCoreSources.bkl:
+
+2008-11-21 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Third step in https://bugs.webkit.org/show_bug.cgi?id=22394
+ Be more eager in destroying script decoded data
+
+ Destroy the decoded data when all clients are removed from a CachedScript.
+
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::allClientsRemoved):
+ * loader/CachedScript.h:
+ (WebCore::CachedScript::allClientsRemoved):
+
+2008-11-21 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ WebKit should be using Device RGB colorspace everywhere for
+ consistency.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22300
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (CreateCGColorIfDifferent):
+ * platform/graphics/mac/ColorMac.h:
+ * platform/graphics/mac/ColorMac.mm:
+ (WebCore::nsColor):
+ (+[WebCoreControlTintObserver controlTintDidChange]):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::convertNSColorToColor):
+ (WebCore::menuBackgroundColor):
+
+2008-11-20 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 22388: Add JSInterfaceName to the .in files
+ https://bugs.webkit.org/show_bug.cgi?id=22388
+
+ Add JSInterfaceName that is similar to interfaceName but
+ for the JS wrappers. JSInterfaceName is always equal to interfaceName
+ unless explicitly set.
+
+ * dom/make_names.pl:
+ * html/HTMLTagNames.in:
+ * svg/svgtags.in:
+
+2008-11-21 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Second step in https://bugs.webkit.org/show_bug.cgi?id=22394
+ Be more eager in destroying script decoded data
+
+ Use a new CachedScriptSourceProvider to keep CachedScripts as
+ CachedScripts, even down into JSC. This has the added benefit
+ of showing the CachedScripts as live in the Caches window.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/CachedScriptSourceProvider.h: Added.
+ (WebCore::CachedScriptSourceProvider::create):
+ (WebCore::CachedScriptSourceProvider::~CachedScriptSourceProvider):
+ (WebCore::CachedScriptSourceProvider::getRange):
+ (WebCore::CachedScriptSourceProvider::data):
+ (WebCore::CachedScriptSourceProvider::length):
+ (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
+ (WebCore::makeSource):
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::notifyFinished):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::notifyFinished):
+
+2008-11-21 Brett Wilson <brettw@chromium.org>
+
+ Fix debug-only build bustage due to a typo in an assert, and add new
+ files to the Windows build.
+
+ * Info.plist:
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/LinkHash.h:
+ (WebCore::LinkHashHash::avoidDeletedValue):
+
+2008-11-20 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22131
+
+ Factor out visited link hashing and types into a new file, LinkHash.
+ This also changes the hash type to 64 bits, but does not actually use
+ the extra bits yet.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
+ (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
+ * css/CSSStyleSelector.h:
+ (WebCore::CSSStyleSelector::visitedStateChanged):
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * page/Page.cpp:
+ (WebCore::Page::visitedStateChanged):
+ * page/Page.h:
+ * page/PageGroup.cpp:
+ (WebCore::PageGroup::isLinkVisited):
+ (WebCore::PageGroup::addVisitedLink):
+ * page/PageGroup.h:
+ * platform/LinkHash.cpp: Added.
+ (WebCore::findSlashDotDotSlash):
+ (WebCore::findSlashSlash):
+ (WebCore::findSlashDotSlash):
+ (WebCore::containsColonSlashSlash):
+ (WebCore::cleanPath):
+ (WebCore::matchLetter):
+ (WebCore::needsTrailingSlash):
+ (WebCore::visitedLinkHash):
+ * platform/LinkHash.h: Added
+ (WebCore::LinkHashHash::hash):
+ (WebCore::LinkHashHash::equal):
+ (WebCore::LinkHashHash::avoidDeletedValue):
+
+2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ No need to use getElementsByTagNameNS() in WML documents. Revert to using getElementByTagName() again.
+
+ * wml/WMLPElement.cpp:
+ (WebCore::WMLPElement::insertedIntoDocument):
+
+2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix some coding style/formatting issues in WMLAElement.
+
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::parseMappedAttribute):
+ (WebCore::WMLAElement::defaultEventHandler):
+ * wml/WMLAElement.h:
+
+2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22399
+
+ Implement <anchor> support for WML, add WMLVariables file containing helper functions
+ for variable support, and a WMLTaskElement base class for WMLPrev/Go/RefreshElement.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::linkAttribute):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::absoluteImageURL):
+ (WebCore::HitTestResult::absoluteLinkURL):
+ (WebCore::HitTestResult::isLiveLink):
+ * wml/WMLAnchorElement.cpp: Added.
+ (WebCore::WMLAnchorElement::WMLAnchorElement):
+ (WebCore::WMLAnchorElement::~WMLAnchorElement):
+ (WebCore::WMLAnchorElement::defaultEventHandler):
+ * wml/WMLAnchorElement.h: Added.
+ (WebCore::WMLAnchorElement::registerTask):
+ * wml/WMLTagNames.in:
+ * wml/WMLTaskElement.cpp: Added.
+ (WebCore::WMLTaskElement::WMLTaskElement):
+ (WebCore::WMLTaskElement::~WMLTaskElement):
+ (WebCore::WMLTaskElement::insertedIntoDocument):
+ (WebCore::WMLTaskElement::addVariableSetter):
+ (WebCore::WMLTaskElement::removeVariableSetter):
+ (WebCore::WMLTaskElement::storeVariableState):
+ * wml/WMLTaskElement.h: Added.
+ * wml/WMLVariables.cpp: Added.
+ (WebCore::isValidVariableCharacter):
+ (WebCore::isValidVariableReferenceCharacter):
+ (WebCore::isValidVariableName):
+ (WebCore::substituteVariableReferences):
+ * wml/WMLVariables.h: Added.
+ (WebCore::):
+
+2008-11-21 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Build fix when building without WORKERS on non-POSIX, non-WINDOWS
+ machine.
+
+ Spotted by Mario Bensi.
+
+ * platform/text/TextCodecICU.cpp:
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ First step in https://bugs.webkit.org/show_bug.cgi?id=22394
+ Be more eager in destroying script decoded data
+
+ Pass data to be used in script execution around as JSC::SourceCode instead
+ of a source, url, and starting line.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/ScriptController.h:
+ * bindings/js/StringSourceProvider.h:
+ (WebCore::makeSource):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ * bindings/js/WorkerScriptController.h:
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElement::insertedIntoDocument):
+ (WebCore::ScriptElement::childrenChanged):
+ (WebCore::ScriptElementData::evaluateScript):
+ (WebCore::ScriptElementData::notifyFinished):
+ * dom/ScriptElement.h:
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::workerThread):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::endElementNs):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseEndElement):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::scriptHandler):
+ (WebCore::HTMLTokenizer::scriptExecution):
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * html/HTMLTokenizer.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeScript):
+ * loader/FrameLoader.h:
+
+2008-11-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22392
+ REGRESION: XMLHttpRequest.responseText does unnecessary trip though WebCore::String
+
+ - Use jsOwnedStringOrNull to avoid conversion to WebCore::String.
+
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::responseText):
+ * xml/XMLHttpRequest.idl:
+
+2008-11-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=19623
+
+ When an non-layer object gained a transform, it would only repaint
+ the bounds of the new layer, which could result in redraw artifacts
+ if the new layer was smaller. So if we're gaining a transform, we
+ repaint.
+
+ Test: fast/repaint/change-transform.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::styleWillChange):
+
+2008-11-20 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6111436> Support upload progress events on Windows
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::didSendBodyData): Added.
+ (WebCore::ResourceHandle::start): Hook up didSendBodyData callback.
+
+2008-11-20 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/2610675> Blank line that is quoted can't be deleted
+
+ If the caret is in an empty quoted paragraph, and either there is nothing before that
+ paragraph, or what is before is unquoted, and the user presses delete, unquote that
+ paragraph.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Added.
+ Removes the line break that holds open an empty paragraph and then attempts to
+ prune the blockquote(s) that held that line break in case they have been emptied
+ out. Places a line break to create in empty unquoted paragraph in place of the
+ quoted one that was removed.
+ * editing/CompositeEditCommand.h:
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::deleteKeyPressed): Call breakOutOfEmptyBlockquotedParagraph.
+ * editing/htmlediting.cpp:
+ (WebCore::highestEnclosingNodeOfType): Added.
+ * editing/htmlediting.h:
+
+2008-11-20 Dean Jackson <dino@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=21247
+
+ Make transition shorthand property accept transition-delay.
+
+ Test: transitions/transition-shorthand-delay.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseTransitionShorthand):
+
+2008-11-20 Dean Jackson <dino@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=22368
+
+ Make sure pauseTransition API takes transition delay into account.
+
+ Test: transitions/transition-drt-api-delay.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::pauseAtTime):
+
+2008-11-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=20368
+
+ Implement getComputedStyle for animation properties. Remove individual
+ computed values for transform-origin-x, transform-origin-y, and just
+ return transform-origin instead. Return "none" for default animation-name,
+ and fix the initial value.
+
+ Tests: animations/computed-style.html
+ transforms/computed-style-origin.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::):
+ (WebCore::getDelayValue):
+ (WebCore::getDurationValue):
+ (WebCore::getTimingFunctionValue):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::initialAnimationName):
+
+2008-11-20 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Preparation for:
+ <rdar://problem/2610675> Blank line that is quoted can't be deleted
+
+ To fix this we need to make changes to the code that creates selections to delete
+ when the user does a backward or forward delete with a caret selection. For certain
+ caret positions, we now want to remove something other than the standard "caret extended
+ backward/forward by one unit". The problem is that there were two pieces of code
+ responsible for doing this, one in Editor::deleteWithDirection, and another inside
+ TypingCommand::deleteKeyPressed. The code in deleteWithDirection is a recent
+ addition (r19172), and adding it there caused regressions because it prevented the
+ code in deleteKeyPressed from ever running. The regressions were never caught because
+ JS deletion uses deleteKeyPressed while manual deletion uses deleteWithDirection.
+
+ This patch removes selection creation code from deleteWithDirection so that deleteKeyPressed
+ can handle it. That required moving code to handle the kill ring down into deleteKeyPressed.
+
+ Follow up patches will fix <rdar://problem/2610675>, and attempt to eliminate the rest of the
+ discrepancies between the behavior of JS deletions and manual deletions, so that we
+ have better test coverage.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::deleteWithDirection): Early return if m_frame->document() is null, instead
+ of checking for that periodically throughout the function. There's really nothing to be done
+ if it's null anyway.
+ Move kill ring code down into deleteKeyPressed.
+ * editing/Editor.h:
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::TypingCommand):
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ (WebCore::TypingCommand::doApply):
+ * editing/TypingCommand.h:
+ (WebCore::TypingCommand::create):
+
+2008-11-20 Darin Adler <darin@apple.com>
+
+ Earlier version reviewed by Justin Garcia.
+
+ - fix <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::handleKeyboardEvent): Remove isContentEditable check -- keyboard events can be
+ handled even when the selection is not in an editable area.
+ (WebCore::Editor::handleInputMethodKeydown): Ditto.
+
+ * editing/EditorCommand.cpp: Changed the enabled rule for operations that change the selection to
+ allow use when there's a selection even if it's not in an editable area. This includes commands
+ like shift-arrow keys to extend the slection, but not commands like arrow keys to move the
+ insertion point.
+
+2008-11-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22380
+ Fix WorkerContext refcounting
+
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::WorkerContext):
+ * dom/WorkerContext.h:
+ (WebCore::WorkerContext::script):
+ (WebCore::WorkerContext::clearScript):
+ Added a method to manually destroy WorkerScriptController.
+
+ * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
+ Destroy WorkerScriptController to release any references to WorkerContext.
+
+2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Last part of bug 21106: .in format discussed changes
+ https://bugs.webkit.org/show_bug.cgi?id=21106
+
+ - Renamed isAudioHack to wrapperOnlyIfMediaIsAvailable as requested.
+
+ - Cleaned up additionnal function parameters that were unneeded.
+
+ * dom/make_names.pl:
+ * html/HTMLTagNames.in:
+
+2008-11-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22383
+ Worker tests spill error messages over to consequent tests
+
+ * dom/Worker.cpp: (WebCore::Worker::Worker):
+ Raise an exception immediately if URL is empty. Dcoument::completeURL() returns document URL
+ in this case, and there is no sense in starting a thread and trying to parse document source
+ as JavaScript.
+
+ * bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
+ Return quickly if toString() raised an exception.
+
+2008-11-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22190
+
+ Fix the painting and event handling in transformed search fields.
+ When painting the cancel and results button parts, get the rect from AppKit
+ relative to the input bounds (rather than in absolute coords), then convert
+ it into the coords of the part's renderer (which is the one that is painting).
+ To do this we need to compute an offset relative to some container, so expose
+ a method on RenderObject for that.
+
+ Also fix the location at which the search popup shows up to take transforms
+ into account, and fix the math that is used to figure out if the search
+ results button, or the cancel button should get the mouse events.
+
+ Test: fast/forms/search-transformed.html
+
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::offsetFromContainer):
+ * rendering/RenderObject.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::forwardEvent):
+ (WebCore::RenderTextControl::showPopup):
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::convertToPaintingRect):
+ (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+
+2008-11-20 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Steps towards making the the Qt port of WebKit compile on Windows CE
+
+ https://bugs.webkit.org/show_bug.cgi?id=20746
+
+ * WebCore.pro: Various fixes to include windows specific build options
+ also in the Windows CE build.
+ * loader/icon/IconDatabase.cpp: Removed unnecessary errno.h inclusion.
+ * platform/FileSystem.h: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::getWindowsContext): SetWorldTransform is
+ not available on CE.
+ * platform/graphics/qt/PathQt.cpp: Added local definition of M_PI.
+ * platform/qt/FileSystemQt.cpp: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
+ * platform/qt/KeyboardCodes.h: Extend #idefs to define the missing OEM
+ constants on CE.
+ * platform/qt/TemporaryLinkStubs.cpp: Added stubs for plugins.
+ * platform/text/RegularExpression.cpp: Removed unused sys/types.h and
+ pcre.h inclusions.
+ * platform/win/SystemTimeWin.cpp:
+ (WebCore::userIdleTime): Don't use GetLastInputInfo on CE, it does not
+ exist.
+
+2008-11-20 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22379
+ Make CSSOM use less memory
+
+ - Shrink CSSProperty by half by using bitfields.
+ - Get rid of m_strictParsing field in StyleBase by moving it up to CSSStyleSheet
+ and CSSMutableStyleDeclaration. This reduces size of many highly popular objects.
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
+ (WebCore::CSSMutableStyleDeclaration::operator=):
+ * css/CSSMutableStyleDeclaration.h:
+ (WebCore::CSSMutableStyleDeclaration::setStrictParsing):
+ (WebCore::CSSMutableStyleDeclaration::useStrictParsing):
+ * css/CSSProperty.h:
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::CSSStyleSheet):
+ * css/CSSStyleSheet.h:
+ (WebCore::CSSStyleSheet::setStrictParsing):
+ (WebCore::CSSStyleSheet::useStrictParsing):
+ * css/StyleBase.h:
+ (WebCore::StyleBase::useStrictParsing):
+ (WebCore::StyleBase::StyleBase):
+
+2008-11-19 Darin Fisher <darin@chromium.org>
+
+ Fix bustage.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22373
+ Ports busted by addition of ScriptValue.{h,cpp}
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::performRequest):
+
+2008-11-19 Darin Fisher <darin@chromium.org>
+
+ Bustage fix.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22373
+ Ports busted by addition of ScriptValue.{h,cpp}
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCoreSources.bkl:
+ * dom/XMLTokenizerQt.cpp:
+ * plugins/PluginView.cpp:
+
+2008-11-19 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Geoff Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22345
+ Define ScriptValue as a thin container for a JSC::Value*.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/ScheduledAction.cpp:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptValue.cpp: Added.
+ (WebCore::ScriptValue::getString):
+ * bindings/js/ScriptValue.h: Added.
+ (WebCore::ScriptValue::ScriptValue):
+ (WebCore::ScriptValue::jsValue):
+ * dom/ScriptElement.cpp:
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizerLibxml2.cpp:
+ * html/HTMLTokenizer.cpp:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeIfJavaScriptURL):
+ (WebCore::FrameLoader::executeScript):
+ * loader/FrameLoader.h:
+
+2008-11-19 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ Fix for <rdar://problem/5472507> Remove color property when a user
+ sets color to black
+
+ This patch prevents us from inserting font nodes during the
+ ApplyStyleCommand if they will not change the computed style of an
+ element.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::fontColorChangesComputedStyle):
+ (WebCore::fontSizeChangesComputedStyle):
+ (WebCore::fontFaceChangesComputedStyle):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+
+2008-11-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=22111
+
+ Fix hit testing in controls on transformed video elements
+ by replacing absoluteBoundingBoxRect().contains() with
+ code that maps the point into local coords, taking
+ transforms into account.
+
+ Test: media/video-controls-transformed.html
+
+ * platform/graphics/MediaPlayer.h:
+ * rendering/RenderMedia.cpp:
+ (WebCore::rendererContainsPoint):
+ (WebCore::RenderMedia::forwardEvent):
+
+2008-11-19 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=22348
+
+ Need to educate style sharing about autofill, so that style does not
+ get shared between input elements that are autofilled, and those
+ that are not. Setting autofill should also do a setChanged on the node.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::canShareStyleWithElement):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * dom/Node.h:
+ (WebCore::Node::isAutofilled):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setAutofilled):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::isAutofilled):
+
+2008-11-19 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22349
+
+ Clear the subresource loader client when the client is removed in
+ response to a 304 (not modified). This prevents an inconsistent state
+ where the loader thinks it's active and the loader::Host doesn't.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didReceiveResponse):
+
+2008-11-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22355
+ Systematize code for replacing global constructors
+
+ Test: fast/workers/worker-replace-global-constructor.html
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (setJSDOMWindowBaseEvent): Changed to put the value as property, matching what generated
+ code for global constructor setters does.
+ (setJSDOMWindowBaseAudio): Ditto.
+ (setJSDOMWindowBaseImage): Ditto.
+ (setJSDOMWindowBaseMessageChannel): Ditto.
+ (setJSDOMWindowBaseOption): Ditto.
+ (setJSDOMWindowBaseWorker): Ditto.
+ (setJSDOMWindowBaseXMLHttpRequest): Ditto.
+ (setJSDOMWindowBaseXSLTProcessor): Ditto.
+ (WebCore::JSDOMWindowBase::put): Removed special cases for global constructors.
+
+ * bindings/js/JSWorkerContext.cpp:
+ (WebCore::JSWorkerContext::getOwnPropertySlot): Look up overrides before own properties,
+ as it is done for Window.
+ (WebCore::setJSWorkerContextMessageEvent): Implemented in the same way as Window global
+ constructors are.
+ (WebCore::setJSWorkerContextWorkerLocation): Ditto.
+
+2008-11-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22341
+ Text codecs should not use static data without locking
+
+ * platform/text/TextCodecICU.cpp:
+ * platform/text/mac/TextCodecMac.cpp:
+ Made cached converters per-thread.
+
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::encodingRegistryMutex): Added a mutex for codec maps access.
+ (WebCore::addToTextCodecMap): Don't use TextEncoding just to canonicalize the name, as it
+ causes a deadlock due to a recursive call into registry.
+ (WebCore::buildBaseTextCodecMaps): Added assertions.
+ (WebCore::newTextCodec): Take a lock to avoid concurrent access to codec maps.
+ (WebCore::atomicCanonicalTextEncodingName): Ditto.
+ (WebCore::noExtendedTextEncodingNameUsed): Added a comment, explaining why locking is not
+ necessary here.
+
+2008-11-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Touch WebCorePrefix.h to force a rebuild, needed because of changed feature defines.
+
+ * WebCorePrefix.h:
+
+2008-11-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22310
+ Worker exceptions should be printed to console
+
+ * dom/Document.cpp: (WebCore::Document::reportException):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+ * dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
+ * dom/WorkerContext.h:
+ Added a reportException() method on ScriptExecutionContext. It forwards the exception info
+ up until it finds a Document context, and then it prints it to console.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent): Don't talk to Console directly, use
+ ScriptExecutionContext::reportException. Also, fixed a bug where Document::updateDocumentsRendering()
+ could be called from workers.
+ (WebCore::JSLazyEventListener::parseCode): Moved variable declaration inside if block for clarity.
+
+ * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
+ Report exceptions to ScriptExecutionContext.
+
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerTask::performTask):
+ (WebCore::WorkerExceptionTask::create):
+ (WebCore::WorkerExceptionTask::WorkerExceptionTask):
+ (WebCore::WorkerExceptionTask::performTask):
+ (WebCore::WorkerMessagingProxy::postWorkerException):
+ * dom/WorkerMessagingProxy.h:
+ Added a task for posting exception information.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::reportException):
+ (WebCore::reportCurrentException):
+ * bindings/js/JSDOMBinding.h:
+ Added helper methods for reporting exceptions via ScriptExecutionContext.
+
+ * page/Console.cpp:
+ * page/Console.h:
+ Removed methods for directly reporting exceptions to console.
+
+ * bindings/js/JSCustomPositionCallback.cpp:
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/objc/WebScriptObject.mm:
+ (WebCore::addExceptionToConsole):
+ Switch to JSDOMBinding methods for reporting exceptions.
+
+2008-11-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=22331
+ <rdar://problem/6381657> REGRESSION: Contextual menu no longer has an "Inspect Element" item
+
+ * platform/ContextMenuItem.h:
+ (WebCore::ContextMenuAction): Reorder this enum to keep it in sync with
+ the one in WebUIDelegate.h.
+
+2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22346
+ PlatformString should also include HashSet.h for non-JSC builds
+
+ * platform/text/PlatformString.h:
+
+2008-11-18 Adele Peterson <adele@apple.com>
+
+ Reviewed by Holger Hans Peter Freyther.
+
+ Flip check added in recent refactoring so the background gets updated when the background color is valid, not invalid.
+
+ * loader/FrameLoaderClient.cpp: (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
+
+2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22343
+ Remove unused runtime/Collector, JSLock includes in Page.cpp
+
+ * page/Page.cpp:
+
+2008-11-18 Ada Chan <adachan@apple.com>
+
+ Bug 22344: Make select popup window opaque
+ https://bugs.webkit.org/show_bug.cgi?id=22344
+
+ Reviewed by Steve Falkenburg.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::show):
+
+2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22342
+ Remove unused JSLock.h include
+
+ * dom/Document.cpp:
+
+2008-11-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Sam Weinig.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22334
+
+ Add WMLBRElement, correcting <br/> behaviour in WML.
+ Enable entity replacment for WML documents.
+ Handle WML specific <p> 'mode' attribute.
+
+ Generate layout tests results for fast/wml.
+
+ Tests cases that pass now:
+ fast/wml/br-element-in-table.wml
+ fast/wml/br-element-in-text.wml
+ fast/wml/case-sensitivity.wml
+ fast/wml/cdata-section.wml
+ fast/wml/comment.wml
+ fast/wml/entity.wml
+ fast/wml/p-align.wml
+ fast/wml/p-mode.wml
+ fast/wml/text-emphasis.wml
+ fast/wml/validate-dtd.wml
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::isWMLDocument):
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * dom/XMLTokenizer.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::internalSubset):
+ (WebCore::getEntityHandler):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parse):
+ * wml/WMLBRElement.cpp: Added.
+ (WebCore::WMLBRElement::WMLBRElement):
+ (WebCore::WMLBRElement::mapToEntry):
+ (WebCore::WMLBRElement::parseMappedAttribute):
+ (WebCore::WMLBRElement::createRenderer):
+ * wml/WMLBRElement.h: Added.
+ * wml/WMLPElement.cpp:
+ (WebCore::WMLPElement::parseMappedAttribute):
+ (WebCore::WMLPElement::insertedIntoDocument):
+ * wml/WMLPElement.h:
+ * wml/WMLTagNames.in:
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Windows build fix.
+
+ * WebCore.vcproj/WebCore.vcproj: Fix relative paths to use $(WebKitOutputDir).
+
+2008-11-18 Darin Adler <darin@apple.com>
+
+ - try to fix Wx build
+
+ * WebCoreSources.bkl: Added FrameLoaderClient.cpp.
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22337
+ Enable workers by default
+
+ Tests: fast/workers/worker-constructor.html
+ fast/workers/worker-event-listener.html
+ fast/workers/worker-gc.html
+ fast/workers/worker-location.html
+
+ * Configurations/WebCore.xcconfig:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.vcproj/build-generated-files.sh:
+ Define ENABLE_WORKERS.
+
+2008-11-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - first cut at https://bugs.webkit.org/show_bug.cgi?id=10957
+ <rdar://problem/5516594> please add support for HTTP-only cookies
+
+ Test: http/tests/xmlhttprequest/get-dangerous-headers.html
+
+ No test for HTTP-only support in JavaScript yet, since the Mac and Win changes
+ require an updated CFNetwork.
+
+ * platform/mac/CookieJar.mm:
+ (WebCore::isHTTPOnly): Added.
+ (WebCore::filterCookies): Added.
+ (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
+ (WebCore::setCookies): Use filterCookies to prevent setting HTTP-only cookies.
+
+ * platform/network/win/CookieJarCFNetWin.cpp:
+ (WebCore::isHTTPOnly): Added.
+ (WebCore::filterCookies): Added.
+ (WebCore::setCookies): Use filterCookies to prevent getting HTTP-only cookies.
+ (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::isSetCookieHeader): Added.
+ (WebCore::XMLHttpRequest::getAllResponseHeaders): Hide Set-Cookie headers from
+ clients that don't have local-resource privileges.
+ (WebCore::XMLHttpRequest::getResponseHeader): Ditto.
+
+ - clean soup-specific details out of shared cookie jar header
+
+ * platform/CookieJar.h: Removed the soup-specific parts of this.
+ * platform/network/soup/CookieJarSoup.cpp: Changed to include
+ CookieJarSoup.h. Tweaked implementation a bit to handle UTF-8 better.
+ * platform/network/soup/CookieJarSoup.h: Added. Has the Soup-specified
+ part of CookieJar.h.
+ * platform/network/soup/ResourceHandleSoup.cpp: Changed to include
+ CookieJarSoup.h.
+
+2008-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=22329
+ Improper bitwise and tests against 0 in Windows context menu code
+
+ Reviewed by John Sullivan.
+
+ * platform/win/ContextMenuItemWin.cpp:
+ (WebCore::ContextMenuItem::type):
+ (WebCore::ContextMenuItem::enabled):
+
+2008-11-18 John Sullivan <sullivan@apple.com>
+
+ Yet more Mac build fixing
+
+ * WebCore.base.exp: Export __ZTVN7WebCore17FrameLoaderClientE
+
+2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ React properly to frame rect changes for QWidget based plugins
+
+ We now set the geometry of the QWidget in frameRectsChanged,
+ intead of setFrameRect, which means we pick up the changes to
+ the frame rect when scrolling. We also set a mask on the
+ widget to keep it from painting over scrollbars and the like
+
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::setFrameRect):
+
+2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Don't mark scrollbars as focused in QtWebKit
+
+ When initing from the widget we also got the focus state,
+ but this does not make sense for scrollbars.
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ More Mac build fixing.
+
+ * WebCore.base.exp: Export FrameLoaderClient destructor.
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Mac build fix.
+
+ * WebCore.xcodeproj/project.pbxproj: Add FrameLoaderClient.cpp for now.
+
+2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22056
+
+ Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
+
+ After Hyatt's work on Widget and ScrollView there is little difference
+ between the implementation of Qt, Gtk+ and Win. In fact any kind of
+ difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
+ port and the Qt port has at least one of them left.
+
+ The only difference between the implementations is in getting the the
+ IntSize for the new FrameView, the background color to be applied and
+ eventually some post processing.
+
+ Unify the implementations by providing a static helper function that
+ takes a Frame, IntSize, color and transparency bit and calling it from
+ the Gtk+, the Qt and the Windows port.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * loader/FrameLoaderClient.cpp: Added.
+ (WebCore::FrameLoaderClient::~FrameLoaderClient):
+ (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
+ * loader/FrameLoaderClient.h:
+
+2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22056
+
+ Move setting the background color and transparency from WebKit/win
+ to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
+ to share this code.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateBackgroundRecursively):
+ * page/FrameView.h:
+
+2008-11-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix the bug where select elements are painted without border.
+ http://trolltech.com/developer/task-tracker/index_html?id=218957&method=entry
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::paintMenuList):
+
+2008-11-18 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix. Not reviewed.
+
+ * GNUmakefile.am: Fix USER_AGENT_STYLESHEETS, wml.css is in css/,
+ not in wml/.
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22308
+ Improve Worker GC behavior
+
+ * dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::hasPendingActivity):
+ * dom/ActiveDOMObject.h:
+ Made hasPendingActivity() virtual, letting Worker add behavior to it.
+
+ * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
+ * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
+ Tell message proxy whether there are active objects in the worker whenever JS execution
+ finishes.
+
+ * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::activeDOMObjects):
+ Added a typedef for activeDOMObjects() return type, necessary to declare iterators.
+
+ * dom/Worker.h:
+ * dom/Worker.cpp: (WebCore::Worker::hasPendingActivity): A Worker is active if it is still
+ loading, or if it has unconfirmed messages, or it the worker thread has pending activity.
+
+ * dom/WorkerContext.h:
+ * dom/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Check all registered
+ active objects for pending activity.
+
+ * dom/WorkerMessagingProxy.cpp:
+ (WebCore::MessageWorkerContextTask::performTask):
+ (WebCore::WorkerThreadActivityReportTask::create):
+ (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask):
+ (WebCore::WorkerThreadActivityReportTask::performTask):
+ (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
+ (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
+ (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
+ (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
+ (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
+ (WebCore::WorkerMessagingProxy::reportWorkerThreadActivity):
+ (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal):
+ (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity):
+ * dom/WorkerMessagingProxy.h:
+ Track outstanding messages, and activity reported by worker thread.
+
+2008-11-18 Alexey Proskuryakov <ap@webkit.org>
+
+ Rubber-stamped by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22306
+ Disable channel messaging support
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseMessageChannel):
+ * page/DOMWindow.idl:
+ Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel
+ constructor is added, it remains enumerable, but undefined.
+
+2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by Mark Rowe.
+
+ Remove WBXML code. MainResourceLoader is not an appropriate location.
+ Revert until we find a better place.
+
+ The mime type which belongs to wmlc should be enabled anyway so WML documents get build.
+ Remove the ENABLE(WBXML) blocks around these types in MIMETypeRegistry / DOMImplementation.
+
+ * WebCore.pro:
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument):
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::addData):
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedNonImageMimeTypes):
+
+2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Not reviewed. Build fix.
+
+ Oops, disable WML by default on Qt.
+
+ * WebCore.pro:
+
+2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
+
+ Reviewed by George Staikos.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=22324 (Add basic subset of WML elements)
+
+ Add first bits of WML support. Only <card> & <p> and <a> elements are supported in this first patch.
+ Support for most other elements will be added step-by-step (merging in small chunks from a big patch).
+
+ WML is not build by default.
+
+ * DerivedSources.make: Handle WMLNames/WMLElementFactory generation.
+ * GNUmakefile.am: Add new files and generator hooks.
+ * WebCore.pro: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * css/CSSStyleSelector.cpp: Load wml.css on demand, just like it's done for SVG.
+ (WebCore::linkAttribute):
+ (WebCore::CSSStyleSelector::styleForElement):c
+ * css/wml.css: Added.
+ * dom/DOMImplementation.cpp: Handle WMLDocument creation
+ (WebCore::DOMImplementation::createDocument):
+ * dom/Document.cpp: Handle WMLElement creation.
+ (WebCore::Document::createElement):
+ * dom/Document.h: Add helper function identifying WML documents.
+ (WebCore::Document::isWMLDocument):
+ * dom/Node.h: Add heper function identifying WML elements.
+ (WebCore::Node::isWMLElement):
+ * dom/XMLTokenizer.cpp: Handle errors in WML documents
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * dom/XMLTokenizerLibxml2.cpp: Add WML DTD checks.
+ (WebCore::XMLTokenizer::internalSubset):
+ * dom/XMLTokenizerQt.cpp: Ditto.
+ (WebCore::):
+ * dom/make_names.pl: Force internal linkage for the "tagConstructor" functions, avoiding SVG<->WML clashes.
+ * history/BackForwardList.cpp: Add WML specific function for clearing the history.
+ (WebCore::BackForwardList::clearWmlPageHistory):
+ * history/BackForwardList.h:
+ * loader/FrameLoader.cpp: Add WML specific 'shouldReload' logic.
+ (WebCore::FrameLoader::FrameLoader):
+ (WebCore::FrameLoader::setForceReloadWmlDeck):
+ (WebCore::FrameLoader::shouldReload):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+ * loader/MainResourceLoader.cpp: Add WBXML support (only enabled on Linux/Qt at the moment)
+ (WebCore::MainResourceLoader::addData):
+ * page/Frame.cpp: Initialize WMLNames.
+ (WebCore::Frame::Frame):
+ * page/Page.cpp: Maintain WMLPageState object per Page.
+ (WebCore::Page::Page):
+ (WebCore::Page::setWMLPageState):
+ (WebCore::Page::wmlPageState):
+ * page/Page.h:
+ * platform/MIMETypeRegistry.cpp: Recognize WML extensions.
+ (WebCore::initializeSupportedNonImageMimeTypes):
+ * platform/gtk/MIMETypeRegistryGtk.cpp: Ditto.
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+ * platform/qt/MIMETypeRegistryQt.cpp: Ditto.
+ (WebCore::):
+ * platform/win/MIMETypeRegistryWin.cpp: Ditto.
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+ * manual-tests/wml: Added.
+ * manual-tests/wml/a-br-element.wml: Added.
+ * manual-tests/wml/a-element.wml: Added.
+ * manual-tests/wml/a-img-element.wml: Added.
+ * manual-tests/wml/access-target.wml: Added.
+ * manual-tests/wml/anchor-br-element.wml: Added.
+ * manual-tests/wml/anchor-element.wml: Added.
+ * manual-tests/wml/anchor-img-element.wml: Added.
+ * manual-tests/wml/card-newcontext-attr.wml: Added.
+ * manual-tests/wml/card-onenterbackward.wml: Added.
+ * manual-tests/wml/card-onenterforward.wml: Added.
+ * manual-tests/wml/card-ontimer.wml: Added.
+ * manual-tests/wml/deck-access-control.wml: Added.
+ * manual-tests/wml/go-element.wml: Added.
+ * manual-tests/wml/input-emptyok.wml: Added.
+ * manual-tests/wml/input-format.wml: Added.
+ * manual-tests/wml/onevent-go.wml: Added.
+ * manual-tests/wml/onevent-noop.wml: Added.
+ * manual-tests/wml/onevent-prev.wml: Added.
+ * manual-tests/wml/onevent-refresh.wml: Added.
+ * manual-tests/wml/onevent-shadow.wml: Added.
+ * manual-tests/wml/postfield-get.wml: Added.
+ * manual-tests/wml/postfield-post.wml: Added.
+ * manual-tests/wml/select-element.wml: Added.
+ * manual-tests/wml/select-onpick-event.wml: Added.
+ * manual-tests/wml/setvar-element.wml: Added.
+ * manual-tests/wml/targetdeck.wml: Added.
+ * manual-tests/wml/task-go-in-anchor.wml: Added.
+ * manual-tests/wml/task-noop-in-do.wml: Added.
+ * manual-tests/wml/task-noop-in-onevent.wml: Added.
+ * manual-tests/wml/task-prev-in-anchor.wml: Added.
+ * manual-tests/wml/task-refresh-in-anchor.wml: Added.
+ * manual-tests/wml/template-go.wml: Added.
+ * manual-tests/wml/template-onevent.wml: Added.
+ * manual-tests/wml/template-ontimer.wml: Added.
+ * manual-tests/wml/timer.wml: Added.
+ * manual-tests/wml/variable-substitution.wml: Added.
+ * wml: Added.
+ * wml/WMLAElement.cpp: Added.
+ (WebCore::WMLAElement::WMLAElement):
+ (WebCore::WMLAElement::parseMappedAttribute):
+ (WebCore::WMLAElement::supportsFocus):
+ (WebCore::WMLAElement::isFocusable):
+ (WebCore::WMLAElement::isMouseFocusable):
+ (WebCore::WMLAElement::isKeyboardFocusable):
+ (WebCore::WMLAElement::defaultEventHandler):
+ (WebCore::WMLAElement::accessKeyAction):
+ (WebCore::WMLAElement::isURLAttribute):
+ (WebCore::WMLAElement::target):
+ * wml/WMLAElement.h: Added.
+ * wml/WMLAttributeNames.in: Added.
+ * wml/WMLCardElement.cpp: Added.
+ (WebCore::WMLCardElement::WMLCardElement):
+ * wml/WMLCardElement.h: Added.
+ * wml/WMLDocument.cpp: Added.
+ (WebCore::WMLDocument::WMLDocument):
+ (WebCore::WMLDocument::~WMLDocument):
+ * wml/WMLDocument.h: Added.
+ (WebCore::WMLDocument::create):
+ (WebCore::WMLDocument::isWMLDocument):
+ * wml/WMLElement.cpp: Added.
+ (WebCore::WMLElement::WMLElement):
+ (WebCore::WMLElement::mapToEntry):
+ (WebCore::WMLElement::parseMappedAttribute):
+ (WebCore::WMLElement::rendererIsNeeded):
+ (WebCore::WMLElement::createRenderer):
+ * wml/WMLElement.h: Added.
+ (WebCore::WMLElement::isWMLElement):
+ * wml/WMLPElement.cpp: Added.
+ (WebCore::WMLPElement::WMLPElement):
+ (WebCore::WMLPElement::mapToEntry):
+ (WebCore::WMLPElement::parseMappedAttribute):
+ * wml/WMLPElement.h: Added.
+ * wml/WMLPageState.cpp: Added.
+ (WebCore::WMLPageState::WMLPageState):
+ (WebCore::WMLPageState::~WMLPageState):
+ (WebCore::WMLPageState::reset):
+ (WebCore::WMLPageState::setNeedCheckDeckAccess):
+ (WebCore::WMLPageState::isDeckAccessible):
+ * wml/WMLPageState.h: Added.
+ (WebCore::WMLPageState::storeVariable):
+ (WebCore::WMLPageState::storeVariables):
+ (WebCore::WMLPageState::getVaribale):
+ (WebCore::WMLPageState::hasVariables):
+ (WebCore::WMLPageState::historyLength):
+ (WebCore::WMLPageState::setHistoryLength):
+ (WebCore::WMLPageState::page):
+ (WebCore::WMLPageState::activeCard):
+ (WebCore::WMLPageState::setActiveCard):
+ (WebCore::WMLPageState::setDeckAccessDomain):
+ (WebCore::WMLPageState::setDeckAccessPath):
+ (WebCore::WMLPageState::hasDeckAccess):
+ * wml/WMLTagNames.in: Added.
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore renames.
+
+ * WebCore.pro:
+ * webcore-base.bkl:
+
+2008-11-17 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/4922709> Copying less than a paragraph of quoted text and pasting it doesn't retain quote level
+
+ There was code to intentionally avoid quoting pasted content if less than a paragraph of
+ it was copied. That was added for <rdar://problem/5006779>, but was unnecessary because
+ that bug was about Paste and Match style for single paragraphs. And quote stripping for
+ Paste and Match style is handled elsewhere.
+
+ * editing/markup.cpp:
+ (WebCore::createMarkup):
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore rename.
+
+ * ForwardingHeaders/interpreter/CallFrame.h: Copied from WebCore/ForwardingHeaders/runtime/ExecState.h.
+ * ForwardingHeaders/runtime/ExecState.h: Removed.
+ * bindings/objc/WebScriptObject.mm:
+ * bridge/c/c_instance.cpp:
+ * bridge/jni/jni_jsobject.mm:
+ * dom/Node.cpp:
+ * dom/NodeFilter.cpp:
+ * dom/NodeIterator.cpp:
+ * dom/TreeWalker.cpp:
+ * inspector/JavaScriptCallFrame.h:
+
+2008-11-17 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Added functionality to AnimationController to allow pausing a running
+ animation or transition at a given time for testing purposes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21261
+
+ Tests: animations/animation-drt-api.html
+ transitions/transition-drt-api.html
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::progress):
+ (WebCore::AnimationBase::pauseAtTime):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
+ (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
+ (WebCore::AnimationController::pauseAnimationAtTime):
+ (WebCore::AnimationController::pauseTransitionAtTime):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::isAnimating):
+ (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
+ (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
+ (WebCore::CompositeAnimation::pauseAnimationAtTime):
+ (WebCore::CompositeAnimation::pauseTransitionAtTime):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore renames.
+
+ * ForwardingHeaders/VM: Removed.
+ * ForwardingHeaders/VM/Machine.h: Removed.
+ * ForwardingHeaders/interpreter: Added.
+ * ForwardingHeaders/interpreter/Interpreter.h: Copied from ForwardingHeaders/VM/Machine.h.
+ * WebCore.pro:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * page/Console.cpp:
+ * webcore-base.bkl:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore renames.
+
+ * ForwardingHeaders/runtime/Interpreter.h: Removed.
+ * WebCore.vcproj/WebCore.vcproj:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/WorkerScriptController.cpp:
+ * bindings/objc/WebScriptObject.mm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/jni/jni_jsobject.mm:
+ * html/CanvasRenderingContext2D.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * page/Console.cpp:
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix wx build.
+
+ * webcore-base.bkl:
+
+2008-11-17 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+ Remove use of static C++ objects that are destroyed at exit time (destructors)
+
+ Find some missing DEFINE_STATIC_LOCAL use cases.
+
+ * bindings/js/JSSVGPODTypeWrapper.h:
+ (WebCore::PODTypeWrapperCacheInfoTraits::emptyValue):
+ (WebCore::JSSVGDynamicPODTypeWrapperCache::dynamicWrapperHashMap):
+ * dom/make_names.pl: Generate code to use DEFINE_STATIC_LOCAL.
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::RoleEntry::): This method is only called once, so the array does not have to be static.
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
+ (WebCore::FontDataCacheKeyTraits::emptyValue):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::initialTransform):
+
+2008-11-17 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * WebCore.pro:
+
+2008-11-16 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22118
+
+ Fix resize corner tracking in transformed elements by using
+ mapping the point into local coords using absoluteToLocal,
+ rather than convertToLayerCoords.
+
+ Test: fast/css/resize-corner-tracking-transformed.html
+
+ * page/EventHandler.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::absoluteToContents):
+ (WebCore::RenderLayer::offsetFromResizeCorner):
+ (WebCore::RenderLayer::isPointInResizeControl):
+ * rendering/RenderLayer.h:
+
+2008-11-16 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Qt build.
+
+ * WebCore.pro:
+
+2008-11-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Use RefPtr and PassRefPtr where appropriate.
+
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::createTemplateDocumentData):
+
+2008-11-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Fix build break for real.
+
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::createTemplateDocumentData):
+
+2008-11-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Fix build break and bug.
+
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::createTemplateDocumentData):
+
+2008-11-16 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+ Remove use of static C++ objects that are destroyed at exit time (destructors)
+
+ Use DEFINE_STATIC_LOCAL for static RetainPtr<T>, RefPtr<T>. Add additional
+ uses of DEFINE_STATIC_LOCAL where appropriate.
+
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::addSharedCellBordersDecl): new the AtomicStrings
+ * loader/CachedImage.cpp:
+ (WebCore::brokenImage):
+ (WebCore::nullImage):
+ * loader/FTPDirectoryDocument.cpp:
+ (WebCore::_createTemplateDocumentData): Created so accessor has one line initialization
+ (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::loadDefaultIconRecord):
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::actionVerb):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::actionVerb):
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::currentEvent):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::paint):
+ * platform/graphics/Image.cpp:
+ (WebCore::Image::nullImage):
+ * platform/graphics/mac/ColorMac.mm:
+ (WebCore::nsColor):
+ * platform/graphics/mac/FontCacheMac.mm: new the Strings
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ * platform/graphics/mac/GraphicsContextMac.mm:
+ (WebCore::_createPatternColor): Created so accessor has one line initialization
+ (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::webFallbackFontFamily):
+ * platform/mac/PasteboardMac.mm:
+ (WebCore::writableTypesForURL):
+ (WebCore::createWritableTypesForImage): Created so accessor has one line initialization
+ (WebCore::writableTypesForImage):
+ (WebCore::stripAttachmentCharacters):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintResizer):
+
+2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Darin Adler.
+
+ Do not spit Curl errors into the stdout as this is used by DRT
+
+ We have failing tests results due the curl errors printed to stdout,
+ move them to stderr to be able to pass those tests.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::startJob):
+
+2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ - fix the Gtk+ build
+
+ * GNUmakefile.am:
+
+2008-11-16 Darin Adler <darin@apple.com>
+
+ - try to fix Qt build
+
+ * WebCore.pro: Add the worker-related source files.
+
+2008-11-16 Darin Adler <darin@apple.com>
+
+ Suggested by Alexey Proskuryakov.
+
+ - fix the GTK build another way
+
+ * GNUmakefile.am: Add the worker-related source files.
+ * bindings/js/JSEventTarget.cpp: Take the #if back out.
+
+2008-11-16 Darin Adler <darin@apple.com>
+
+ - try to fix GTK build
+
+ * bindings/js/JSEventTarget.cpp: Put worker includes inside an #if.
+
+2008-11-16 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22295
+ track which history items are from page load failures
+
+ * history/HistoryItem.cpp: Sort includes, add newly needed ones, and remove
+ no-longer-needed ones.
+ (WebCore::HistoryItem::HistoryItem): Initialize m_lastVisitWasFailure to false.
+ (WebCore::HistoryItem::showTreeWithIndent): Rewrote to avoid appending to a
+ String, since that's not efficient.
+
+ * history/HistoryItem.h: Removed unneeded includes. Added lastVisitWasFailure,
+ setLastVisitWasFailure, and m_lastVisitWasFailure.
+
+ * history/mac/HistoryItemMac.mm: Add newly-needed include
+ (WebCore::HistoryItem::setTransientProperty): Rewrote to avoid keeping a
+ m_transientProperties map around when it is empty.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createHistoryItem): Call setLastVisitWasFailure when
+ the page was unreachable or an HTTP page with a status code that indicates
+ failure.
+
+2008-11-16 Yong Li <yong.li@torchmobile.com>
+
+ Reviewed by Timothy Hatcher.
+ Landed by George Staikos.
+
+ Optimization: don't relayout, repaint, or emit a DOM event if the
+ scroll event didn't scroll anywhere.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset): add early exit
+
+2008-11-16 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22290
+ Remove cross-heap GC and MessagePort multi-threading support
+
+ It is broken (and may not be implementable at all), and no longer needed, as we
+ don't use MessagePorts for communication with workers any more.
+
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ Removed cross-heap GC implementation.
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::hasPendingActivity):
+ * dom/MessagePort.h:
+ Made objects RefCounted instead of ThreadSafeShared, added FIXME comments for code that is
+ unnecessarily complicated for single threaded case.
+
+2008-11-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22266
+ Stop using MessagePort for communication with workers
+
+ The current MessagePort specification is not well suited for being implemented in a
+ multi-threaded or multi-process environment, and this doesn't appear to be easily fixable.
+ This patch implements a simpler Mozilla API for workers instead.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * DerivedSources.make:
+ * bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker):
+ * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed.
+ * bindings/js/JSDedicatedWorkerConstructor.h: Removed.
+ * bindings/js/JSDedicatedWorkerCustom.cpp: Removed.
+ * bindings/js/JSWorkerConstructor.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.cpp.
+ * bindings/js/JSWorkerConstructor.h: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.h.
+ * bindings/js/JSWorkerCustom.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerCustom.cpp.
+ * dom/DedicatedWorker.cpp: Removed.
+ * dom/DedicatedWorker.h: Removed.
+ * dom/DedicatedWorker.idl: Removed.
+ Renamed DedicatedWorker to Worker to match Mozilla and current WHATWG cpec.
+
+ * bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
+ Clear worker exceptions to avoid hitting an assertion.
+
+ * dom/EventTarget.cpp: (WebCore::EventTarget::toWorker):
+ * dom/EventTarget.h:
+ * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
+ WorkerContext is now an EventTarget, too.
+
+ * bindings/js/JSWorkerContext.cpp: Removed onconnect, constructors for MessageChannel and
+ MessagePort. Added postMessage() and onmessage.
+
+ * dom/ScriptExecutionContext.cpp: (WebCore::performTask): Do not reference ScriptExecutionContext
+ when posting a task - this operation is not thread safe. It is also not necessary any more,
+ as the context is kept alive by WorkerMessagingProxy.
+
+ * dom/Worker.cpp: Copied from WebCore/dom/DedicatedWorker.cpp.
+ (WebCore::Worker::Worker): Start loading the script right away - there is no reason to do
+ that on a timer.
+ (WebCore::Worker::~Worker): Notify messaging proxy.
+ (WebCore::Worker::postMessage): Just ask the proxy to post the message.
+ (WebCore::Worker::notifyFinished): Notify messaging proxy when a thread object becomes
+ available. Also, it is now safe to unsetPendingActivity(), making the object collectable.
+ I'm not sure if this is the right lifetime for workers, as unreachable workers with event
+ listeners should probably be kept alive, but it at least lets the object be collected.
+ (WebCore::Worker::addEventListener): Added an EventTarget implementation.
+ (WebCore::Worker::removeEventListener): Added an EventTarget implementation.
+ (WebCore::Worker::dispatchEvent): Added an EventTarget implementation.
+
+ * dom/Worker.h: Copied from WebCore/dom/DedicatedWorker.h.
+ * dom/Worker.idl: Copied from WebCore/dom/DedicatedWorker.idl.
+ Removed onclose, made an EventListener. Actual messaging is now handled by WorkerMessagingProxy.
+
+ * dom/WorkerContext.cpp:
+ (WebCore::WorkerContext::~WorkerContext): Notify messaging proxy that the context was shut
+ down successfully.
+ (WebCore::WorkerContext::postMessage): Added. Post the message via messaging proxy.
+
+ * dom/WorkerContext.h: Added postMessage and onmessage, removed onconnect.
+
+ * dom/WorkerMessagingProxy.cpp: Added.
+ * dom/WorkerMessagingProxy.h: Added.
+ This new class implements actual messaging. It is notified when a Worker is garbage collected,
+ and asks the thread to shut down. It also owns the thread object, and references script
+ execution context, making it safe to post messages to it remotely.
+
+ * dom/WorkerThread.cpp:
+ * dom/WorkerThread.h:
+ Keep a reference to messaging proxy, not to Worker itself. Also, the thread object no longer
+ keeps itself alive - it is now the job of messaging proxy.
+
+2008-11-15 Darin Adler <darin@apple.com>
+
+ Rubber stamped by Geoff Garen.
+
+ - do the long-planned StructureID -> Structure rename
+
+ * ForwardingHeaders/runtime/Structure.h: Copied from WebCore/ForwardingHeaders/runtime/StructureID.h.
+ * ForwardingHeaders/runtime/StructureID.h: Removed.
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::getCachedDOMStructure):
+ (WebCore::cacheDOMStructure):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::DOMObject::DOMObject):
+ (WebCore::getDOMStructure):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell):
+ (WebCore::JSDOMWindowShell::setWindow):
+ * bindings/js/JSDOMWindowShell.h:
+ (WebCore::JSDOMWindowShell::createStructure):
+ * bindings/js/JSDedicatedWorkerConstructor.cpp:
+ (WebCore::JSDedicatedWorkerConstructor::JSDedicatedWorkerConstructor):
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
+ (WebCore::JSHTMLAllCollection::createStructure):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+ (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
+ * bindings/js/JSInspectedObjectWrapper.h:
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::leakInspectorCallbackWrapperStructure):
+ (WebCore::JSInspectorCallbackWrapper::wrap):
+ (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createStructure):
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::createStructure):
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::createStructure):
+ * bindings/js/JSWorkerContext.cpp:
+ (WebCore::createJSWorkerContextStructure):
+ (WebCore::JSWorkerContext::JSWorkerContext):
+ (WebCore::JSWorkerContext::createPrototype):
+ * bindings/js/JSWorkerContext.h:
+ (WebCore::JSWorkerContext::createStructure):
+ (WebCore::JSWorkerContextPrototype::JSWorkerContextPrototype):
+ (WebCore::JSWorkerContextPrototype::createStructure):
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtConnectionObject::execute):
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMethod::createStructure):
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::createStructure):
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createStructure):
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::RuntimeObjectImp):
+ * bridge/runtime_object.h:
+ (JSC::RuntimeObjectImp::createStructure):
+
+2008-11-15 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix just-introduced crash in the svg/custom/svg-fonts-in-html.html test
+
+ This gets rid of the crash. It restores the behavior of the CG case from before Dirk
+ Shulze removed the platorm-dependent code, but perhaps it should be changed further
+ in the future so that the default for no style is "no stroke". I think the patch is
+ fine for fill.
+
+ * svg/graphics/SVGPaintServerSolid.cpp:
+ (WebCore::SVGPaintServerSolid::setup): Added null checks for svgStyle.
+ (WebCore::SVGPaintServerSolid::renderPath): Added null checks for style and svgStyle.
+
+2008-11-15 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Timothy Hatcher.
+
+ Initialize m_networkStateChangedFunction to 0 as otherwise the check for null will fail.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22284
+
+ * platform/network/NetworkStateNotifier.h:
+ (WebCore::NetworkStateNotifier::NetworkStateNotifier):
+
+2008-11-15 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Geoffrey Garen.
+
+ r38426 caused a wrong drawing of a LayoutTest. Use another
+ way to set the color to pass this test again.
+
+ * svg/graphics/SVGPaintServerSolid.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+
+2008-11-15 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Removed platform dependent code on SVGPaintServerSolid.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/graphics/SVGPaintServerSolid.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+ (WebCore::SVGPaintServerSolid::renderPath):
+ * svg/graphics/SVGPaintServerSolid.h:
+ * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp: Removed.
+ * svg/graphics/cg/SVGPaintServerSolidCg.cpp: Removed.
+ * svg/graphics/qt/SVGPaintServerSolidQt.cpp: Removed.
+
+2008-11-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Updated for JavaScriptCore renames.
+
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::mark):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::send):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::evaluate):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject evaluateWebScript:]):
+ * bridge/NP_jsobject.cpp:
+ (_NPN_Evaluate):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::eval):
+ * page/Console.cpp:
+ (WebCore::retrieveLastCaller):
+ (WebCore::Console::trace):
+
+2008-11-14 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+ Remove use of static C++ objects that are destroyed at exit time (destructors)
+
+ Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
+ exit-time destructor. Update code that was changed to fix this issue that ran
+ into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
+ in gcc build 5465). Also typdefs for template types needed to be added in some
+ cases so the type could make it through the macro successfully.
+
+ Basically code of the form:
+ static T m;
+ becomes:
+ DEFINE_STATIC_LOCAL(T, m, ());
+
+ Also any code of the form:
+ static T& m = *new T;
+ also becomes:
+ DEFINE_STATIC_LOCAL(T, m, ());
+
+ * ForwardingHeaders/wtf/StdLibExtras.h: Added.
+ * bindings/js/GCController.cpp:
+ (WebCore::gcController):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::wrapperSet):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::wrappers):
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::wrappers):
+ * bindings/js/JSNavigatorCustom.cpp:
+ (WebCore::needsYouTubeQuirk):
+ * bridge/runtime_root.cpp:
+ (JSC::Bindings::rootObjectSet):
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::initShorthandMap):
+ (WebCore::CSSMutableStyleDeclaration::removeProperty):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::screenEval):
+ (WebCore::printEval):
+ * dom/DOMImplementation.cpp:
+ (WebCore::addString):
+ (WebCore::isSVG10Feature):
+ (WebCore::isSVG11Feature):
+ (WebCore::DOMImplementation::isXMLMIMEType):
+ * dom/Document.cpp:
+ (WebCore::Document::hasPrefixNamespaceMismatch):
+ * dom/ScriptElement.cpp:
+ (WebCore::isSupportedJavaScriptLanguage):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::styleSpanClassString):
+ * editing/HTMLInterchange.cpp:
+ (WebCore::):
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::indentBlockquoteString):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::isInterchangeNewlineNode):
+ (WebCore::isInterchangeConvertedSpaceSpan):
+ * editing/htmlediting.cpp:
+ (WebCore::stringWithRebalancedWhitespace):
+ (WebCore::nonBreakingSpaceString):
+ * editing/markup.cpp:
+ (WebCore::appendAttributeValue):
+ (WebCore::appendEscapedContent):
+ (WebCore::shouldAddNamespaceAttr):
+ (WebCore::appendNamespace):
+ (WebCore::appendStartMarkup):
+ (WebCore::createMarkup):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::type):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::isRecognizedTagName):
+ (WebCore::inlineTagList):
+ (WebCore::blockTagList):
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::type):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::type):
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::type):
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::type):
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::type):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::type):
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::getNode):
+ (WebCore::HTMLParser::isHeaderTag):
+ (WebCore::HTMLParser::isResidualStyleTag):
+ (WebCore::HTMLParser::isAffectedByResidualStyle):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::type):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::type):
+ * inspector/InspectorController.cpp:
+ (WebCore::platform):
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::shared):
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::profileCache):
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::profileNodeCache):
+ * loader/FrameLoader.cpp:
+ (WebCore::localSchemes):
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::cacheStorage):
+ * loader/archive/ArchiveFactory.cpp:
+ (WebCore::archiveMIMETypes):
+ (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::defaultDatabaseFilename):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dragState):
+ * page/Frame.cpp:
+ (WebCore::createRegExpForLabels):
+ (WebCore::keepAliveSet):
+ * page/Page.cpp:
+ (WebCore::Page::groupName):
+ * page/SecurityOrigin.cpp:
+ (WebCore::isDefaultPortForProtocol):
+ (WebCore::SecurityOrigin::databaseIdentifier):
+ * page/mac/FrameMac.mm:
+ (WebCore::regExpForLabels):
+ * platform/KURL.cpp:
+ (WebCore::blankURL):
+ * platform/graphics/FontCache.cpp:
+ (WebCore::alternateFamilyName):
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/mac/CursorMac.mm:
+ (WebCore::leakNamedCursor):
+ (WebCore::pointerCursor):
+ (WebCore::crossCursor):
+ (WebCore::handCursor):
+ (WebCore::moveCursor):
+ (WebCore::verticalTextCursor):
+ (WebCore::cellCursor):
+ (WebCore::contextMenuCursor):
+ (WebCore::aliasCursor):
+ (WebCore::zoomInCursor):
+ (WebCore::zoomOutCursor):
+ (WebCore::copyCursor):
+ (WebCore::noneCursor):
+ (WebCore::progressCursor):
+ (WebCore::noDropCursor):
+ (WebCore::notAllowedCursor):
+ (WebCore::iBeamCursor):
+ (WebCore::waitCursor):
+ (WebCore::helpCursor):
+ (WebCore::eastResizeCursor):
+ (WebCore::northResizeCursor):
+ (WebCore::northEastResizeCursor):
+ (WebCore::northWestResizeCursor):
+ (WebCore::southResizeCursor):
+ (WebCore::southEastResizeCursor):
+ (WebCore::southWestResizeCursor):
+ (WebCore::westResizeCursor):
+ (WebCore::northSouthResizeCursor):
+ (WebCore::eastWestResizeCursor):
+ (WebCore::northEastSouthWestResizeCursor):
+ (WebCore::northWestSouthEastResizeCursor):
+ (WebCore::columnResizeCursor):
+ (WebCore::rowResizeCursor):
+ (WebCore::grabCursor):
+ (WebCore::grabbingCursor):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarTheme::nativeTheme):
+ * platform/mac/ThemeMac.mm:
+ (WebCore::platformTheme):
+ * platform/mac/ThreadCheck.mm:
+ (WebCoreReportThreadViolation):
+ * platform/network/NetworkStateNotifier.cpp:
+ (WebCore::networkStateNotifier):
+ * platform/network/mac/FormDataStreamMac.mm:
+ (WebCore::getStreamFormDataMap):
+ (WebCore::getStreamResourceHandleMap):
+ * platform/network/mac/ResourceResponseMac.mm:
+ (WebCore::ResourceResponse::platformLazyInit):
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::isJapanese):
+ * plugins/PluginMainThreadScheduler.cpp:
+ (WebCore::PluginMainThreadScheduler::scheduler):
+ * rendering/RenderBlock.cpp:
+ (WebCore::continuationOutlineTable):
+ (WebCore::RenderBlock::addContinuationWithOutline):
+ (WebCore::RenderBlock::paintContinuationOutlines):
+ * rendering/RenderCounter.cpp:
+ (WebCore::counterMaps):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::markerText):
+ * rendering/RenderScrollbarTheme.cpp:
+ (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemFont):
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::checkLinesForTextOverflow):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::initialDashboardRegions):
+ (WebCore::RenderStyle::noneDashboardRegions):
+ * storage/Database.cpp:
+ (WebCore::guidMutex):
+ (WebCore::guidToVersionMap):
+ (WebCore::guidToDatabaseMap):
+ (WebCore::Database::databaseInfoTableName):
+ (WebCore::databaseVersionKey):
+ (WebCore::Database::getVersionFromDatabase):
+ (WebCore::Database::setVersionInDatabase):
+ (WebCore::guidForOriginAndName):
+ * storage/DatabaseTracker.cpp:
+ (WebCore::DatabaseTracker::tracker):
+ (WebCore::notificationMutex):
+ (WebCore::notificationQueue):
+ * storage/LocalStorage.cpp:
+ (WebCore::localStorageMap):
+ * svg/SVGAnimateMotionElement.cpp:
+ (WebCore::SVGAnimateMotionElement::rotateMode):
+ * svg/SVGAnimationElement.cpp:
+ (WebCore::SVGAnimationElement::calcMode):
+ (WebCore::SVGAnimationElement::attributeType):
+ (WebCore::SVGAnimationElement::isAdditive):
+ (WebCore::SVGAnimationElement::isAccumulated):
+ * svg/SVGLangSpace.cpp:
+ (WebCore::SVGLangSpace::xmlspace):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::contentScriptType):
+ (WebCore::SVGSVGElement::contentStyleType):
+ * svg/SVGStyleElement.cpp:
+ (WebCore::SVGStyleElement::type):
+ (WebCore::SVGStyleElement::media):
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGTextContentElement::parseMappedAttribute):
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::SVGSMILElement::parseClockValue):
+ (WebCore::SVGSMILElement::restart):
+ (WebCore::SVGSMILElement::fill):
+ (WebCore::SVGSMILElement::repeatCount):
+ (WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
+ * svg/graphics/SVGResource.cpp:
+ (WebCore::clientMap):
+ (WebCore::SVGResource::removeClient):
+ * svg/graphics/SVGResourceMarker.cpp:
+ (WebCore::SVGResourceMarker::draw):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
+ (WebCore::preflightResultCache):
+ (WebCore::appendPreflightResultCacheEntry):
+ (WebCore::isSafeRequestHeader):
+ (WebCore::isOnAccessControlResponseHeaderWhitelist):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ * xml/XPathExpressionNode.cpp:
+ (WebCore::XPath::Expression::evaluationContext):
+ * xml/XPathParser.cpp:
+ (WebCore::XPath::setUpAxisNamesMap):
+ (WebCore::XPath::isAxisName):
+ (WebCore::XPath::isNodeTypeName):
+ * xml/XPathValue.cpp:
+ (WebCore::XPath::Value::toNodeSet):
+
+2008-11-14 Dan Bernstein <mitz@apple.com>
+
+ - attempt to fix the Qt build
+
+ * platform/qt/Localizations.cpp:
+ (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string
+ needs to go somewhere else in addition to here.
+
+2008-11-14 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * platform/wx/LocalizedStringsWx.cpp:
+ (WebCore::contextMenuItemTagTextDirectionMenu):
+
+2008-11-14 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - <rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
+ - WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
+
+ * WebCore.base.exp: Exported
+ WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().
+
+ * editing/ApplyStyleCommand.cpp:
+ (StyleChange::init): Changed to always include the direction property
+ in the result if the unicode-bidi property is included.
+ (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the
+ highest ancestor of the given node that establishes bidi embedding. If
+ that embedding agrees with the given allowed direction, finds the
+ second-highest embedding ancestor. Splits all nodes through that
+ ancestor. If the highest embedding ancestor did not need to be split,
+ it is returned.
+ (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes
+ bidi embedding attributes and styles from all ancestors of the given
+ node up to its enclosing block or the given node.
+ (ApplyStyleCommand::applyInlineStyle): Added code to handle the
+ unicode-bidi property. Applying style the includes this property
+ involves removing all bidi embedding in effect, except for one-level
+ embedding that agrees with the desired embedding, then applying the
+ desired embedding where it is not already in effect.
+ (ApplyStyleCommand::applyInlineStyleToRange): Factored out from
+ applyInlineStyle().
+ (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the
+ "dir" attribute if necessary and the element if it becomes an unstyled
+ style span.
+ (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction
+ property when removing the unicode-bidi property.
+ (ApplyStyleCommand::removeInlineStyle): Added a call to
+ removeHTMLBidiEmbeddingStyle().
+
+ * editing/ApplyStyleCommand.h:
+ * editing/Editor.cpp:
+ (Editor::textDirectionForSelection): Added. Returns the character-level
+ writing direction of the selection if it is uniform and simple (at most
+ one level of embedding).
+ (Editor::hasBidiSelection): Added. Returns true if the selection lies
+ entirely within a single block, and that block has direction:rtl or
+ contains any inline boxes with non-zero bidi embedding level.
+
+ * editing/Editor.h:
+ * editing/EditorCommand.cpp:
+ (stateTextWritingDirection): Added this helper function for deciding
+ the state of Text Direction submenu items.
+ (executeMakeTextWritingDirectionLeftToRight): Added. Applies
+ "unicode-bidi: embed; direction: ltr;".
+ (executeMakeTextWritingDirectionNatural): Added. Applies
+ "unicode-bidi: normal;"
+ (executeMakeTextWritingDirectionRightToLeft): Added. Applies
+ "unicode-bidi: embed; direction: rtl;".
+ (stateTextWritingDirectionLeftToRight): Added.
+ (stateTextWritingDirectionNatural): Added.
+ (stateTextWritingDirectionRightToLeft): Added.
+ (createCommandMap): Added "MakeTextWritingDirectionLeftToRight",
+ "MakeTextWritingDirectionNatural",
+ and "MakeTextWritingDirectionRightToLeft".
+
+ * editing/InsertTextCommand.cpp:
+ (InsertTextCommand::input): Added code to maintain the unicode-bidi
+ and direction properties in the typing style. Even if they have the
+ same values as the computed style at the caret, they need to be included
+ in the typing style so that inserted text will not inherit any nested
+ embedding.
+
+ * page/ContextMenuController.cpp:
+ (ContextMenuController::contextMenuItemSelected): Added calls to
+ the editor for the text direction menu items.
+
+ * page/Frame.cpp
+ (Frame::computeAndSetTypingStyle): Added code to maintain the
+ unicode-bidi and direction properties in the typing style.
+
+ * page/Settings.cpp:
+ (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.
+
+ * page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum,
+ an m_textDirectionSubmenuInclusionBehavior member, and accessors.
+
+ * page/mac/WebCoreViewFactory.h:
+ * platform/ContextMenu.cpp:
+ (WebCore::createAndAppendTextDirectionSubMenu): Added.
+ (ContextMenu::populate): Added the Text Direction submenu item based on
+ the inclusion behavior and the existence of a bidi selection.
+ (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction
+ menu items.
+
+ * platform/ContextMenuItem.h:
+ * platform/LocalizedStrings.h: Declared
+ contextMenuItemTagTextDirectionMenu().
+
+ * platform/mac/LocalizedStringsMac.mm: Defined
+ contextMenuItemTagTextDirectionMenu().
+
+ * rendering/RenderBlock.cpp:
+ (RenderBlock::containsNonZeroBidiLevel): Added.
+ * rendering/RenderBlock.h:
+
+2008-11-14 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22264
+ Need to update to latest Geolocation spec (13 November 2008)
+
+ Update to new error code constants and values.
+
+ * page/Geolocation.cpp: Use new named ErrorCode enums
+ (WebCore::Geolocation::GeoNotifier::timerFired):
+ (WebCore::Geolocation::getCurrentPosition):
+ (WebCore::Geolocation::watchPosition):
+ * page/PositionError.h: Have ErrorCode enum names match new error constant names and values
+ (WebCore::PositionError::):
+ * page/PositionError.idl: Add new named error constants
+
+2008-11-14 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Justin Garcia.
+
+ Fix (again) for <rdar://problem/5089327> Too much indentation when
+ pasting quoted paragraphs
+
+ This patch goes back to Justin's original approach to fix this bug,
+ written in revision 38273. That fix was mostly rolled out by
+ revision 38310 because of styling issues created by the addition of
+ extra blockquote nodes. This patch again goes back to Justin's
+ original fix because of cases we discovered the newer fix could not
+ possibly cover. This version of the patch minimizes the styling
+ issues of extra blockquotes by opting into the merge start code.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to
+ return true when the quoting level of the end of the inserted
+ content matches the quoting level of the end of the existing
+ content.
+ (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls
+ hasMatchingQuoteLevel
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+2008-11-14 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Made SVGResourceClipper platform independent.
+ https://bugs.webkit.org/show_bug.cgi?id=21444
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::clipPath):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::clipPath):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::addPath):
+ (WebCore::GraphicsContext::clipPath):
+ * svg/graphics/SVGResourceClipper.cpp:
+ (WebCore::SVGResourceClipper::applyClip):
+ * svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
+ * svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
+ * svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.
+
+2008-11-14 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
+ * loader/FrameLoader.h:
+
+2008-11-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove unneeded forward declaration.
+
+ * plugins/Plugin.h:
+
+2008-11-14 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22251
+ HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h
+
+ * html/HTMLCanvasElement.cpp:
+
+2008-11-14 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Add new files from the Qt port to the build.
+
+ * WebCore.pro:
+
+2008-11-14 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Made DatabaseTracker::hasEntryForOrigin() public. This allows the Qt
+ port to apply a default quota only if there is no entry in the
+ database for a given origin yet.
+
+ * storage/DatabaseTracker.h:
+
+2008-11-14 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Make it possible to get the cache directory set in the application
+ cache storage.
+
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::ApplicationCacheStorage::cacheDirectory): Added.
+ * loader/appcache/ApplicationCacheStorage.h:
+
+2008-11-14 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages
+
+ When applying block styles, we would add block properties to the body element, and Mail's
+ Make Plain Text feature isn't equipped to remove those. This could have been fixed on our side,
+ but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.
+
+ We have code that puts the paragraphs that we're operating on into blocks of their own before
+ adding or removing block properties from the blocks that enclose them. We need to run this code
+ when the enclosing block is the body element.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents
+ to here.
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity.
+ Added a few comments. Fixed bug by not bailing out when the block about to be used is the body element.
+ * editing/CompositeEditCommand.h:
+
+2008-11-14 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22245: Move wtf/dtoa.h into the WTF namespace
+ <https://bugs.webkit.org/show_bug.cgi?id=22245>
+
+ Move wtf/dtoa.h into the WTF namespace from the JSC namespace.
+
+ * platform/text/String.cpp:
+ (WebCore::charactersToDouble):
+
+2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Make sure Qt scrollbars follow the style with regard to context menus
+
+ * platform/qt/ScrollbarQt.cpp:
+ (WebCore::Scrollbar::contextMenu):
+
+2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Make scrollbar look active when the window is active on Qt/Mac
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+ (WebCore::ScrollbarThemeQt::paint):
+
+2008-11-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Add a basic Scons-based build system for building
+ Chromium-Mac WebCore.
+ https://bugs.webkit.org/show_bug.cgi?id=21991
+
+ The build currently fails due to missing files from our
+ platform directory (platform skia and platform chromium)
+ I will be sending those up shortly in separate patches.
+ I expect it will be a while before our WebCore build links.
+
+ * SConstruct: Added.
+ * WebCore.scons: Added.
+
+2008-11-13 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22248
+ AtomicString.cpp uses JSC types outside of #if USE(JSC)
+
+ * platform/text/AtomicString.cpp:
+ (WebCore::AtomicString::add):
+
+2008-11-13 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18620
+ Long hang under TextIterator::advance() when loading http://www.lsvd.de/
+
+ A huge section at the beginning of this document is invisible. As we iterate through it,
+ we create VisiblePositions unnecessarily.
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition
+ creation if m_node is unrendered or invisible. The answers wouldn't have much meaning
+ and would be wasteful. Also fixed some comments to reflect the fact that this function
+ isn't specifically about emitting a newline.
+
+2008-11-13 Pierre-Olivier Latour <pol@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove unused or unnecessary code from AnimationBase class.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::AnimationBase):
+ (WebCore::AnimationBase::playStatePlaying):
+ * page/animation/AnimationBase.h:
+
+2008-11-12 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore
+
+ Currently only used by QtWebKit. See also:
+
+ https://bugs.webkit.org/show_bug.cgi?id=21427
+
+ * WebCore.pro:
+ * platform/qt/TemporaryLinkStubs.cpp:
+ (PluginView::userAgentStatic):
+ (PluginView::getValueStatic):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::handleEvent):
+ (WebCore::PluginView::setValue):
+ (WebCore::PluginView::PluginView):
+ * plugins/PluginView.h:
+ (WebCore::PluginView::setPlatformPluginWidget):
+ * plugins/mac/PluginPackageMac.cpp: Added.
+ (WebCore::PluginPackage::determineQuirks):
+ (WebCore::readPListFile):
+ (WebCore::stringListFromResourceId):
+ (WebCore::PluginPackage::fetchInfo):
+ (WebCore::PluginPackage::load):
+ (WebCore::PluginPackage::hash):
+ (WebCore::PluginPackage::equal):
+ (WebCore::PluginPackage::compareFileVersion):
+ * plugins/mac/PluginViewMac.cpp: Added.
+ (WebCore::nativeWindowFor):
+ (WebCore::cgHandleFor):
+ (WebCore::topLevelOffsetFor):
+ (WebCore::PluginView::init):
+ (WebCore::PluginView::~PluginView):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::getValueStatic):
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::setParent):
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setFocus):
+ (WebCore::PluginView::setParentVisible):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::setNPWindowIfNeeded):
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::invalidateRect):
+ (WebCore::PluginView::invalidateRegion):
+ (WebCore::PluginView::forceRedraw):
+ (WebCore::PluginView::handleMouseEvent):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::nullEventTimerFired):
+ (WebCore::modifiersForEvent):
+ (WebCore::PluginView::globalMousePosForPlugin):
+ (WebCore::PluginView::dispatchNPEvent):
+ (WebCore::PluginView::userAgent):
+ (WebCore::PluginView::userAgentStatic):
+ (WebCore::PluginView::handlePostReadFile):
+
+2008-11-12 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22200
+ Crash when close event is dispatched to MessagePort due to document destruction
+
+ Test: fast/events/message-port-onclose.html
+
+ * dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed):
+ Don't dispatch close event, even though HTML5 currently says that we should. It is not
+ right for GC to have observable effects.
+
+2008-11-12 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22203
+ Implement Worker messaging
+
+ No test cases included, because this functionality is disabled by default.
+
+ The implementation is known to still have many race condition, but works quite well for
+ testing.
+
+ * WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::markActiveObjectsForContext): Re-worded comments a little.
+ (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was
+ incorrect, changed it to a much simpler (but still incorrect) version.
+
+ * dom/WorkerTask.cpp: Added.
+ (WebCore::WorkerTask::~WorkerTask):
+ * dom/WorkerTask.h: Added.
+ Tasks posted to workers implement this new interface.
+
+ * bindings/js/JSDedicatedWorkerCustom.cpp:
+ (WebCore::JSDedicatedWorker::mark):
+ (WebCore::JSDedicatedWorker::connect):
+ * dom/DedicatedWorker.h:
+ * dom/DedicatedWorker.idl:
+ Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking
+ WHATWG discussions.
+
+ * dom/DedicatedWorker.cpp:
+ (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect()
+ operations.
+ (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer.
+ (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts
+ one to worker. Since message port registration in ScriptExecutionContext is not thread safe,
+ this port starts with a null context pointer.
+ (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately
+ after creation, we have to queue tasks until after a WorkerThread object is created. Then we
+ forward all queued tasks to its queue.
+
+ * dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
+ * dom/EventTarget.h:
+ * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
+ Added cases for WorkerContext, which is now an EventTarget, too.
+
+ * bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
+ * bindings/js/JSWorkerContext.cpp:
+ (WebCore::JSWorkerContext::mark): Mark event listeners.
+ (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID.
+ (WebCore::JSWorkerContext::put): Implemented.
+ (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation.
+ (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto.
+ (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto.
+ (WebCore::jsWorkerContextOnconnect): Added.
+ (WebCore::setJSWorkerContextOnconnect): Added.
+
+ * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
+ Made it actually work by adding necessary setup.
+
+ * bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded):
+ Check the right variable - it is the wrapper that may not be initialized yet.
+
+ * dom/ActiveDOMObject.cpp:
+ (WebCore::ActiveDOMObject::ActiveDOMObject):
+ (WebCore::ActiveDOMObject::~ActiveDOMObject):
+ Assert being called from the correct thread, as active DOM object tracking is not thread safe.
+
+ * dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used
+ for asynchronously executing tasks in context's thread.
+
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task
+ (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer.
+ It was an optimization that couldn't be easily preserved without introducing race conditions
+ in multithreading case.
+ (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask().
+ (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining
+ why it's OK to not ref() ports in a frozen copy.
+ (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called
+ from a wrong thread.
+ (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto.
+ (WebCore::ScriptExecutionContextTaskTimer): Part of
+ ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main
+ thread.
+ (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting
+ to a worker.
+ (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting
+ to main thread from a secondary one.
+ (WebCore::performTask): A helper function for callOnMainThread().
+ (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
+
+ * dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would
+ ref/deref EventData::message from different threads, which is not allowed.
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads.
+ (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now.
+ (WebCore::MessagePort::EventData::EventData): Ditto.
+ (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at
+ first, because we need to create ports for posting to other threads, and it is not possible
+ to register in a context from another thread.
+ (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message
+ receiver's job to set the context.
+ (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any
+ context yet.
+ (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached.
+ (WebCore::MessagePort::contextDestroyed): Assert that we had a context.
+ (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in
+ context.
+ (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual.
+ (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask().
+ (WebCore::MessagePort::queueCloseEvent): Use postTask().
+ (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above,
+ MessagePort cross-heap GC is still quite wrong.
+
+ * dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
+ * dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions
+ now, but there is no harm in tracking it in release builds, too.
+
+ * dom/WorkerThread.cpp:
+ (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create().
+ (WebCore::WorkerThread::workerThread): Implemented a message loop.
+ * dom/WorkerThread.h:
+ (WebCore::WorkerThread::threadID): Also only used for assertions.
+ (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it
+ always sets it to null.
+ (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
+
+2008-11-12 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed Darin Adler.
+
+ use strokeColor.alpha() instead of fillColor.alpha()
+ on GraphicsContext::strokePath()
+
+ [Canvas] Transparent fillStyle stops line rendering
+ https://bugs.webkit.org/show_bug.cgi?id=21888
+
+ Test: fast/canvas/canvas-stroke-empty-fill.html
+
+ * ChangeLog:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::strokePath):
+
+2008-11-12 Stephanie <slewis@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix context leak in XSLStyleSheets.
+ See bug https://bugs.webkit.org/show_bug.cgi?id=15715
+
+ * xml/XSLStyleSheet.cpp:
+ (WebCore::XSLStyleSheet::parseString):
+
+2008-11-12 Alp Toker <alp@nuanti.com>
+
+ autotools: List web worker-related headers needed for a successful
+ build. distcheck is passing again with this change.
+
+ * GNUmakefile.am:
+
+2008-11-12 Alp Toker <alp@nuanti.com>
+
+ autotools build system fix-up only. Add FloatQuad.h to the source
+ lists and sort them.
+
+ * GNUmakefile.am:
+
+2008-11-12 Alp Toker <alp@nuanti.com>
+
+ Build fixes for r38346. FloatQuad.cpp is missing:
+
+ 1) #include "config.h"
+ 2) #include <algorithm> for various mathematical definitions it uses.
+
+ * platform/graphics/FloatQuad.cpp:
+
+2008-11-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22212
+
+ Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
+ it may be the bounding outline box of a transformed element, and fix it
+ to respect transforms by mapping the outline box to an absolute quad and
+ taking the enclosing rect.
+
+ RenderBox::localToAbsoluteQuad() can no longer assert that there is no
+ LayoutState, but LayoutState cannot be used during quad mapping (it knows
+ nothing about transforms).
+
+ Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
+ borderTopExtra() from the object, rather than its container (as localToAbsolute()
+ does).
+
+ Test: fast/repaint/transform-absolute-child.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localToAbsoluteQuad):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ * rendering/RenderForeignObject.cpp:
+ (WebCore::RenderForeignObject::layout):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::setHasVisibleContent):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+ (WebCore::RenderObject::absoluteOutlineBounds):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::layout):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::layout):
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::layout):
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::layout):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::layout):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout):
+ * rendering/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::layout):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::layout):
+
+2008-11-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=21942
+ https://bugs.webkit.org/show_bug.cgi?id=18557
+
+ Add methods which can be used to map renderer-local rectangles
+ to quads in absolute coordinates, taking transforms into account:
+ localToAbsoluteQuad() converts a local rect into an absolute quad.
+ collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()
+ that works with quads.
+ absoluteQuads() is an analogue of absoluteRects(), for quads.
+
+ Use the quad methods to fix the inspector highlight for transformed
+ elements.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * inspector/InspectorController.cpp:
+ (WebCore::drawOutlinedQuad):
+ (WebCore::drawHighlightForBoxes):
+ (WebCore::frameToMainFrameOffset):
+ (WebCore::InspectorController::drawNodeHighlight):
+ * platform/graphics/AffineTransform.cpp:
+ (WebCore::AffineTransform::mapQuad):
+ * platform/graphics/AffineTransform.h:
+ * platform/graphics/FloatQuad.cpp: Added.
+ (WebCore::min4):
+ (WebCore::max4):
+ (WebCore::FloatQuad::boundingBox):
+ * platform/graphics/FloatQuad.h: Added.
+ (WebCore::FloatQuad::FloatQuad):
+ (WebCore::FloatQuad::p1):
+ (WebCore::FloatQuad::p2):
+ (WebCore::FloatQuad::p3):
+ (WebCore::FloatQuad::p4):
+ (WebCore::FloatQuad::setP1):
+ (WebCore::FloatQuad::setP2):
+ (WebCore::FloatQuad::setP3):
+ (WebCore::FloatQuad::setP4):
+ (WebCore::FloatQuad::isEmpty):
+ (WebCore::FloatQuad::enclosingBoundingBox):
+ (WebCore::FloatQuad::move):
+ (WebCore::operator+=):
+ (WebCore::operator-=):
+ (WebCore::operator==):
+ (WebCore::operator!=):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localToAbsoluteQuad):
+ * rendering/RenderBox.h:
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
+ * rendering/RenderContainer.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::absoluteQuads):
+ * rendering/RenderInline.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteBoundingBoxRect):
+ (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
+ (WebCore::RenderObject::absoluteQuads):
+ (WebCore::RenderObject::localToAbsoluteQuad):
+ (WebCore::RenderObject::absoluteContentQuad):
+ * rendering/RenderObject.h:
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::absoluteQuads):
+ * rendering/RenderPath.h:
+ * rendering/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::absoluteQuads):
+ * rendering/RenderSVGContainer.h:
+ * rendering/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::absoluteQuads):
+ * rendering/RenderSVGHiddenContainer.h:
+ * rendering/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::calculateAbsoluteBounds):
+ (WebCore::RenderSVGImage::absoluteQuads):
+ * rendering/RenderSVGImage.h:
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::absoluteQuads):
+ (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
+ * rendering/RenderSVGInlineText.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::absoluteQuads):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderSVGTSpan.cpp:
+ (WebCore::RenderSVGTSpan::absoluteRects):
+ (WebCore::RenderSVGTSpan::absoluteQuads):
+ * rendering/RenderSVGTSpan.h:
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ (WebCore::RenderSVGText::absoluteQuads):
+ * rendering/RenderSVGText.h:
+ * rendering/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::absoluteRects):
+ (WebCore::RenderSVGTextPath::absoluteQuads):
+ * rendering/RenderSVGTextPath.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::localToAbsolute):
+ (WebCore::RenderTableCell::localToAbsoluteQuad):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::absoluteQuads):
+ (WebCore::RenderText::collectAbsoluteLineBoxQuads):
+ * rendering/RenderText.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::localToAbsoluteQuad):
+ (WebCore::RenderView::absoluteQuads):
+ * rendering/RenderView.h:
+
+2008-11-12 Brent Fulgham <bfulgham@gmail.com>
+
+ Fix Bug 22178: Build errors in WebKit Cairo port
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22178>
+
+ Reviewed by Mark Rowe.
+
+ * platform/graphics/cairo/PatternCairo.cpp: Correct build error under
+ Visual Studio.
+ (WebCore::Pattern::createPlatformPattern):
+
+2008-11-12 Adam Roben <aroben@apple.com>
+
+ Fix a typo in the include path for the Release_Cairo configuration
+
+ * WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
+
+2008-11-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=17840
+ Patch 2
+
+ Code cleanup in RenderBox::computeAbsoluteRepaintRect().
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+
+2008-11-12 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=17840
+
+ Fix repainting when the transform on a positioned element changes.
+ In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
+ and being in a positioned container after applying the transform to the local
+ rect.
+
+ Tests: fast/repaint/transform-absolute-in-positioned-container.html
+ fast/repaint/transform-relative-position.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+
+2008-11-12 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/5495723> Selecting and deleting quoted text quotes other text
+ <rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted
+
+ We don't want to merge into a block if it will mean changing the quote level of content after deleting
+ selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
+ that such a selection actually ends at the start of the next paragraph. Instead we want to completely
+ remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
+ for indented paragraphs.
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not
+ try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied
+ so that we remove evidence of the deleted paragraphs' quote level.
+ (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also
+ make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection
+ started on, instead of one higher.
+ * editing/DeleteSelectionCommand.h:
+ * editing/htmlediting.cpp:
+ (WebCore::numEnclosingMailBlockquotes): Added.
+ * editing/htmlediting.h:
+
+2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Move _web_encodingForResource from WebKit into WebCore and change return type
+
+ This change is needed to implement NSAPI in WebCore for Mac, see:
+
+ https://bugs.webkit.org/show_bug.cgi?id=21427
+
+ * WebCore.base.exp:
+ * platform/mac/WebCoreNSStringExtras.h:
+ * platform/mac/WebCoreNSStringExtras.mm:
+ (stringEncodingForResource):
+
+2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
+ WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.
+
+ This change is needed to implement NSAPI in WebCore for Mac, see:
+
+ https://bugs.webkit.org/show_bug.cgi?id=21427
+
+ * WebCore.base.exp:
+ * platform/mac/WebCoreNSStringExtras.h:
+ * platform/mac/WebCoreNSStringExtras.mm:
+ (stringIsCaseInsensitiveEqualToString):
+
+2008-11-11 Stephanie <slewis@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Null check image data before setting it as image source.
+
+ Test: fast/images/image-empty-data.html
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::destroyDecodedData):
+
+2008-11-11 Adele Peterson <adele@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Remove ifdef so future OS versions can use the new delegate method.
+
+ * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
+
+2008-11-11 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Antti Koivisto and Sam Weinig.
+
+ Clean up HTMLTokenizer a litle
+ https://bugs.webkit.org/show_bug.cgi?id=22188
+
+ Rename pendingScripts to m_pendingScripts
+ Rename scriptNode to m_scriptNode make the type specific
+ Rename pendingSrc to m_pendingSrc
+ Rename currentPrependingSrc to m_currentPrependingSrc
+ Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
+ Remove long-since-dead kdDebug and qDebug calls
+ Rename brokenComments to m_brokenComments
+ Remove HTMLTokenizer includes and document the rest
+ Rename src to m_src
+ Rename parser to m_parser and make it an OwnPtr
+ Rename inWrite to m_inWrite and jsProxy to scriptController
+ Rename brokenServer to m_brokenServer
+ Rename buffer to m_buffer and dest to m_dest
+ Rename size to m_bufferSize
+ Rename attrName to m_attrName
+ Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
+ Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
+ Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
+ Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
+ Rename flat to selfClosingTag
+ Rename currToken to m_currentToken
+
+ * css/CSSParser.cpp:
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizerLibxml2.cpp:
+ * html/HTMLDocument.cpp:
+ * html/HTMLElement.cpp:
+ * html/HTMLFormControlElement.cpp:
+ * html/HTMLParser.h:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::Token::addAttribute):
+ (WebCore::HTMLTokenizer::HTMLTokenizer):
+ (WebCore::HTMLTokenizer::reset):
+ (WebCore::HTMLTokenizer::begin):
+ (WebCore::HTMLTokenizer::processListing):
+ (WebCore::HTMLTokenizer::parseSpecial):
+ (WebCore::HTMLTokenizer::scriptHandler):
+ (WebCore::HTMLTokenizer::scriptExecution):
+ (WebCore::HTMLTokenizer::parseComment):
+ (WebCore::HTMLTokenizer::parseServer):
+ (WebCore::HTMLTokenizer::parseProcessingInstruction):
+ (WebCore::HTMLTokenizer::parseText):
+ (WebCore::HTMLTokenizer::parseEntity):
+ (WebCore::HTMLTokenizer::parseTag):
+ (WebCore::HTMLTokenizer::write):
+ (WebCore::HTMLTokenizer::processingData):
+ (WebCore::HTMLTokenizer::end):
+ (WebCore::HTMLTokenizer::finish):
+ (WebCore::HTMLTokenizer::processToken):
+ (WebCore::HTMLTokenizer::processDoctypeToken):
+ (WebCore::HTMLTokenizer::~HTMLTokenizer):
+ (WebCore::HTMLTokenizer::enlargeBuffer):
+ (WebCore::HTMLTokenizer::enlargeScriptBuffer):
+ (WebCore::HTMLTokenizer::notifyFinished):
+ (WebCore::HTMLTokenizer::setSrc):
+ * html/HTMLTokenizer.h:
+ (WebCore::Token::Token):
+ (WebCore::Token::reset):
+ (WebCore::HTMLTokenizer::processingContentWrittenByScript):
+ (WebCore::HTMLTokenizer::htmlParser):
+ (WebCore::HTMLTokenizer::checkBuffer):
+ (WebCore::HTMLTokenizer::checkScriptBuffer):
+ * html/HTMLViewSourceDocument.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::leftRelOffset):
+ (WebCore::RenderBlock::rightRelOffset):
+ (WebCore::RenderBlock::lineWidth):
+ * xml/XSLTProcessor.cpp:
+
+2008-11-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
+ Track CachedScript decoded data
+
+ We now track the decoded size of CachedScripts in the Cache allowing
+ them to accounted for when deciding when to evict data. The decoded
+ data itself can be evicted when Cache pressure gets high enough through
+ CachedScript::destroyDecodedData.
+
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::allClientsRemoved):
+ (WebCore::CachedResource::destroyDecodedData):
+ * loader/CachedScript.cpp:
+ (WebCore::CachedScript::script):
+ (WebCore::CachedScript::data):
+ (WebCore::CachedScript::destroyDecodedData):
+ * loader/CachedScript.h:
+
+2008-11-11 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Remove pointless dependencies on the now-deleted kjs directory and
+ mentions of it in comments that are no longer relevant.
+
+ * WebCore.pro:
+ * webcore-base.bkl:
+
+2008-11-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adam Roben.
+
+ WebCore part of adding a master volume control for media elements in a WebView
+
+ * WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
+ * dom/Document.cpp:
+ (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page
+ when the media volume is changed.
+ (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows
+ elements to register for a callback when the media volume is changed.
+ (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows
+ elements to unregister for the callback.
+ * dom/Document.h:
+ * dom/Element.h:
+ (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to
+ registerForMediaVolumeCallbacks().
+ (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to
+ unregisterForMediaVolumeCallbacks().
+ (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the
+ element's intrinsic volume by the master volume from the page.
+ (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls
+ updateVolume().
+ * html/HTMLMediaElement.h:
+ * page/Page.cpp:
+ (WebCore::Page::Page): Initialize m_mediaVolume to 1.
+ (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on
+ every document in the page when the master volume changes.
+ * page/Page.h:
+ (WebCore::Page::mediaVolume): Added this getter.
+
+2008-11-11 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=22182
+
+ Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
+ is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
+ errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.
+
+ Reviewed by Adele
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::mouseDown):
+
+2008-11-11 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/5089327> Too much indentation when pasting
+ quoted paragraphs
+
+ This patch re-addresses pasting blockquotes into blockquotes. It
+ backs out most of revision 38273. 38273 fixed the bug by inserting
+ the pasted content as a sibling blockquote node to the pre-existing
+ blockquote node. The problem with that is that by default,
+ blockquotes have a giant margin, so visually, this can be weird.
+ This patch instead inserts the pasted content as siblings of the
+ the content already inside the outer blockquote, and then removes
+ the blockquote node from the pasted content itself, so that it
+ doesn't nest itself into the outer blockquote.
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+ Move contains() from Element to Node since there is nothing
+ Element-specific about it.
+ * dom/Element.cpp:
+ * dom/Element.h:
+ * dom/Node.cpp:
+ (WebCore::Node::contains):
+ * dom/Node.h:
+
+2008-11-11 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=17997
+
+ Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
+ is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
+ is a Leopard-only workaround, since the API has been fixed on Snow Leopard.
+
+ Reviewed by John Sullivan
+
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::Image::drawPattern):
+
+2008-11-10 David Hyatt <hyatt@apple.com>
+
+ Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
+ when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
+ how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.
+
+ Reviewed by Adam Roben
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::isControlStyled):
+
+2008-11-11 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22160
+ speculative fix for <rdar://problem/5995450> Nil deref because nextLinePosition
+ (previousLinePosition, too) uses a nil node
+
+ * editing/visible_units.cpp:
+ (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element
+ to check editingIgnoresContent. It makes sense to use the associated DOM node for
+ this, even in cases of anonymous content, and it avoids the case where element() can
+ be 0.
+ (WebCore::previousLinePosition): Ditto.
+
+2008-11-11 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Darin Adler.
+
+ Removed default: in applySpreadMethod. This causes the problems
+ in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
+ or CSS.
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::applySpreadMethod):
+
+2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix crash when rendering the file chooser.
+ Also proper implementation for multi-selected files.
+
+ * platform/qt/FileChooserQt.cpp:
+ (WebCore::FileChooser::basenameForWidth):
+
+2008-11-11 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Oliver Hunt.
+
+ PatternCairo needs to invert the pattern matrix because
+ of transformation from user space to pattern space.
+ Give a identity matrix to pattern for Qt and Cairo. Because the
+ context is transformed already.
+
+ [CAIRO][QT] Canvas transformations applied twice to Patterns
+ https://bugs.webkit.org/show_bug.cgi?id=21555
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ * platform/graphics/cairo/PatternCairo.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+
+2008-11-10 Stephanie Lewis <slewis@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Clear the image source cache even if we haven't decoded any of the image data.
+ We use the image source cache when calculating layout.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::pruneDeadResources):
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::destroyDecodedData):
+
+2008-11-10 Adam Roben <aroben@apple.com>
+
+ Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
+ loading microsoftpdc.com
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22161>
+
+ Reviewed by Dan Bernstein.
+
+ Test: fast/css/outline-invert-assertion.html
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::systemColor): If we can't determine a good
+ Win32 system color to use, defer to RenderTheme instead of asserting.
+ This matches what RenderThemeMac does.
+
+2008-11-10 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
+ into quoted text yields double-quoting
+
+ Don't nest inserted content in Mail blockquotes. Perform a
+ BreakBlockquoteCommand if we're in
+ one and insert the incoming fragment between the split blockquotes.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from ->
+ source and to -> destination.
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+2008-11-10 Adam Roben <aroben@apple.com>
+
+ Fix Bug 22158: Would like to turn on WebCore logging channels via an
+ environment variable
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22158>
+
+ Logging channels can now be enabled by setting the WebCoreLogLevel
+ environment variable to a hexadecimal number.
+
+ Reviewed by Anders Carlsson.
+
+ * WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
+ * platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm.
+ (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel
+ environment variable, parse its value as a hexadecimal number, and
+ turn the channel on/off based on whether the mask bit is set.
+ (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each
+ logging channel in turn.
+
+2008-11-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=22103
+ Changing fonts in preferences does not immediately update WebViews
+
+ This broke when the meaning of FrameView::invalidate changed.
+ I changed setNeedsReapplyStyles to no longer depend on invalidate.
+
+ * dom/Document.cpp: (WebCore::Document::shouldScheduleLayout):
+ Removed the part of this function that duplicated what's already in
+ FrameView::needsLayout, since the copy here left out a few key things.
+ For example, it didn't handle the fact that "needs reapply styles"
+ counts as needing layout.
+
+ * page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called
+ FrameView::invalidate before. There were two things wrong with that.
+ 1) It requested that the entire view repaint even if the style change
+ didn't necessitate that. 2) FrameView::invalidate no longer causes any
+ repainting at all in certain cases, because of Hyatt's changes to how
+ widgets and the host window are involved in the repainting process.
+ So call FrameView::scheduleRelayout instead, which is more precisely
+ what we want and need here.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here
+ so that Document::shouldScheduleLayout doesn't have to replicate the
+ logic that's in needsLayout and can instead rely on the fact that it
+ was already called.
+ (WebCore::FrameView::needsLayout): Tweaked the comments and formatting
+ in this function.
+
+2008-11-10 Darin Adler <darin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - speculative fix for <rdar://problem/5557243> crashes in Safari at
+ WebCore::HTMLSelectElement::updateListBoxSelection + 280
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ Check index against size of vector before indexing into the vector.
+
+2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ Fix QtWebkit build failure on arm.
+
+ pen.widthF() is a qreal, which means it's a float on arm.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::setLineDash):
+
+2008-11-10 Morten Sørvig <msorvig@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Improve mouse wheel scolling on Qt/Cocoa.
+ Cocoa differs from Carbon (and other platforms I think) in that the
+ mouse wheel events we get have a much higher acceleration factor.
+
+ This submit switches over to scroll-per-pixel from scroll-per-line
+ for most of our scrolling views. This matches the native views
+ and works well with the increased acceleration.
+
+ * platform/qt/WheelEventQt.cpp:
+
+2008-11-09 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 19541: Null pointer in showModalDialog()
+ <https://bugs.webkit.org/show_bug.cgi?id=19541>
+
+ Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
+ and JSDOMWindowBase::canShowModalDialogNow()C
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::canShowModalDialog):
+ (WebCore::canShowModalDialogNow):
+
+2008-11-09 Darin Adler <darin@apple.com>
+
+ - try to fix Windows build
+
+ * platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules
+ about needed a separate definition for static const integer data members.
+ Until I get to the bottom of this, put the definitions inside an ifdef.
+
+2008-11-09 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX: Qt build broke after r38235.
+
+ Added HAVE(ACCESSIBILITY) header guards to platform implementation
+ source files.
+
+ * page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY)
+ guards.
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
+ * page/qt/AccessibilityObjectQt.cpp: Ditto.
+ * page/win/AccessibilityObjectWin.cpp: Ditto.
+ * page/wx/AccessibilityObjectWx.cpp: Ditto.
+
+2008-11-09 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22104
+ Javascript URL percent encoding/decoding broken by some characters
+
+ Test: fast/loader/javascript-url-encoding-2.html
+
+ * platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
+
+2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed and tweaked by Darin Adler.
+
+ * platform/graphics/Color.cpp: Added definitions for the static data members
+ in this class. Static data members need a definition, even when they are the
+ simple integer constant kind that can be initialized in the header.
+
+2008-11-08 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=22141
+ REGRESSION: Safari error page is not fully styled when loaded from cache
+
+ Reset text decoder on flush so it does not pass through the BOM when it is reused.
+
+ Test: fast/encoding/css-cached-bom.html
+
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::flush):
+
+2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Mark Rowe.
+
+ Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
+ it was causing these errors to end up in the page's text representation.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::downloadTimerCallback):
+
+2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after addition of JSCore parser and bycompiler dirs.
+
+ * webcore-base.bkl:
+ * webcore-wx.bkl:
+
+2008-11-08 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=21906
+
+ Override addFocusRingRects() in RenderTextControl to avoid
+ the RenderFlow behavior of recursing on descendent renderers.
+ RenderTextControl should only ever need a simple focus rect.
+
+ This fixes focus ring issues with transforms on text controls.
+
+ Test: fast/transforms/transformed-focused-text-input.html
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::addFocusRingRects):
+ * rendering/RenderTextControl.h:
+
+2008-11-08 Dimitri Dupuis-Latour <dupuislatour@apple.com>
+
+ Make sure the icon thumbnail width/height is at least 1px in
+ the Web Inspector's resource panel.
+
+ <rdar://problem/5988888>
+
+ Reviewed by Tim Hatcher.
+
+ * inspector/front-end/inspector.css:
+
+2008-11-08 David Kilzer <ddkilzer@apple.com>
+
+ Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled
+
+ <https://bugs.webkit.org/show_bug.cgi?id=22137>
+
+ Reviewed by Darin Adler.
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ Provide a default implementation when HAVE(ACCESSIBILITY) is false.
+ * page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
+ * page/mac/AccessibilityObjectMac.mm: Ditto.
+ * page/mac/AccessibilityObjectWrapper.mm: Ditto.
+
+2008-11-08 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - WebCore part of adding WebPreferences for controlling databases and local storage
+
+ * WebCore.base.exp: Exported Settings::setDatabasesEnabled() and
+ Settings::setLocalStorageEnabled().
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage
+ is disabled in settings.
+ (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases
+ are disabled in settings.
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize m_databasesEnabled and
+ m_localStorageEnabled.
+ (WebCore::Settings::setDatabasesEnabled): Added.
+ (WebCore::Settings::setLocalStorageEnabled): Added.
+ * page/Settings.h:
+ (WebCore::Settings::databasesEnabled): Added.
+ (WebCore::Settings::localStorageEnabled): Added.
+
+2008-11-07 Alp Toker <alp@nuanti.com>
+
+ Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
+ now require that only their top-level header file is included.
+
+ Patch tested and still builds fine with older GTK+ versions (back to
+ 2.8).
+
+ Future WebKit GTK+ contributions are required to adhere to this
+ policy.
+
+ * platform/gtk/FileSystemGtk.cpp:
+ * platform/gtk/KeyEventGtk.cpp:
+ * platform/gtk/MouseEventGtk.cpp:
+ * platform/gtk/WheelEventGtk.cpp:
+ * platform/gtk/gtkdrawing.h:
+ * plugins/gtk/gtk2xtbin.c:
+ * plugins/gtk/gtk2xtbin.h:
+
+2008-11-07 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker
+
+ Explicitly initialize the NPDrawingModelCoreAnimation.
+
+ * bridge/npapi.h:
+
+2008-11-07 Alp Toker <alp@nuanti.com>
+
+ autotools fix. Always use the configured perl binary (which may be
+ different to the one in $PATH) when generating sources.
+
+ * GNUmakefile.am:
+
+2008-11-07 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ https://bugs.webkit.org/show_bug.cgi?id=22122
+
+ Use a stack-based object to simplify the pushLayoutState/popLayoutState
+ code. LayoutStateMaintainer either pushes in the constructor, or allows
+ an explicit push() later. Both cases require an explicit pop().
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::layout):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::layout):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::layout):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::setCellWidths):
+ (WebCore::RenderTableSection::calcRowHeight):
+ (WebCore::RenderTableSection::layoutRows):
+ * rendering/RenderView.h:
+ (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
+ (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
+ (WebCore::LayoutStateMaintainer::pop):
+ (WebCore::LayoutStateMaintainer::push):
+ (WebCore::LayoutStateMaintainer::didPush):
+
+2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Fix the QtWebKit build on Mac
+
+ * platform/qt/TemporaryLinkStubs.cpp:
+ (PluginView::invalidateRect):
+
+2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Don't allow Phonon's invisible video widget to keep the app running
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
+
+2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Fix valgrind warning about uninitialized lastStop variable.
+
+ * platform/graphics/qt/GradientQt.cpp:
+ (WebCore::Gradient::platformGradient):
+
+2008-11-07 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix layout test brokenness following r38211.
+
+ * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
+ Restore old Shift key behavior. We ignore Shift key state when matching access keys (which
+ matches neither IE nor Firefox), and this patch made WebKit behave like Firefox
+ inadvertently. This may or may not be a good thing, but it's certainly not something that
+ should change by accident.
+
+2008-11-06 Antti Koivisto <antti@apple.com>
+
+ Eh, this trivial last minute change was wrong.
+
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::sheetText):
+
+2008-11-06 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22093
+
+ Delaying the text decoding caused regression since the decoding
+ also determines the encoding in case of @charset rule.
+
+ Decode immediately in data() and keep the decoded string around
+ during the checkNotify().
+
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::sheetText):
+ (WebCore::CachedCSSStyleSheet::data):
+ * loader/CachedCSSStyleSheet.h:
+
+2008-11-06 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22097
+ Expose MessageEvent constructor on WorkerContext
+
+ * bindings/js/JSWorkerContext.cpp:
+ (WebCore::jsWorkerContextMessageEvent):
+ (WebCore::setJSWorkerContextMessageEvent):
+
+2008-11-06 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21107
+ <rdar://problem/6264219> New access key combination conflicts with VoiceOver
+
+ * page/EventHandler.h:
+ * page/gtk/EventHandlerGtk.cpp:
+ (WebCore::EventHandler::accessKeyModifiers):
+ * page/qt/EventHandlerQt.cpp:
+ (WebCore::EventHandler::accessKeyModifiers):
+ * page/win/EventHandlerWin.cpp:
+ (WebCore::EventHandler::accessKeyModifiers):
+ * page/wx/EventHandlerWx.cpp:
+ (WebCore::EventHandler::accessKeyModifiers):
+ Access access key modifiers via a function, not a static variable.
+
+ * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers):
+ Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is
+ less troublesome than one with VO keys.
+
+ * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
+ Also fix an access key matching bug introduced in r32424 - Any superset of specified
+ modifier set invoked access keys. We can use simple equality comparison instead because
+ CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
+
+2008-11-06 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22115
+ NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
+
+ Export _NPN_HasMethod and _NPN_HasProperty.
+
+ * WebCore.NPAPI.exp:
+
+2008-11-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=15678
+
+ Fix transformed menu selects to show the popup in the correct
+ location.
+
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::showPopup):
+
+2008-11-06 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
+
+ Apparently older versions of gcc have issues with this patch.
+ Backing out a second time until the issues are resolved.
+
+2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21106: .in format discussed changes
+ https://bugs.webkit.org/show_bug.cgi?id=21106
+
+ Include the namespace into the interfaceName.
+
+ * dom/make_names.pl: Do not append the namespace when
+ using the interfaceName.
+ * html/HTMLTagNames.in: Added namespace prefix for custom
+ interfaceName.
+ * svg/svgtags.in: Ditto.
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Move the remaining files in the kjs subdirectory of JavaScriptCore to
+ a new parser subdirectory, and remove the kjs subdirectory entirely.
+
+ * ForwardingHeaders/kjs: Removed.
+ * ForwardingHeaders/kjs/Parser.h: Removed.
+ * ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
+ * ForwardingHeaders/kjs/SourceCode.h: Removed.
+ * ForwardingHeaders/kjs/SourceProvider.h: Removed.
+ * ForwardingHeaders/parser: Added.
+ * ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
+ * ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
+ * ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * bindings/js/StringSourceProvider.h:
+ * bindings/js/WorkerScriptController.cpp:
+ * bridge/NP_jsobject.cpp:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/testbindings.pro:
+ * inspector/JavaScriptDebugServer.cpp:
+
+2008-11-06 David Kilzer <ddkilzer@apple.com>
+
+ BUILD WAS NOT BROKEN: Rolling r38189 back in.
+
+ Please perform a clean build if you see crashes.
+
+2008-11-06 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX: Backed out r38189 since it apparently broke the world.
+
+2008-11-06 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
+ https://bugs.webkit.org/show_bug.cgi?id=22112
+
+ Test: accessibility/content-editable.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isReadOnly):
+
+2008-11-06 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alice Liu.
+
+ Fix failed assert at launch caused by unintialized data member on the mac.
+
+ * platform/network/mac/NetworkStateNotifierMac.cpp:
+ (WebCore::NetworkStateNotifier::NetworkStateNotifier):
+
+2008-11-06 Steve Falkenburg <sfalken@apple.com>
+
+ Fix failed assert at launch caused by unintialized data member.
+
+ Reviewed by Maciej Stachowiak.
+
+ * platform/network/win/NetworkStateNotifierWin.cpp:
+ (WebCore::NetworkStateNotifier::NetworkStateNotifier):
+
+2008-11-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Antti Koivisto
+
+ https://bugs.webkit.org/show_bug.cgi?id=22109
+ Make <input type="range"> work correctly with transforms
+
+ Test: fast/forms/slider-transformed.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ Compute a correct local point when the event is retargeted
+ * rendering/RenderSlider.cpp:
+ (WebCore::HTMLSliderThumbElement::defaultEventHandler):
+ Compute m_initialClickPoint in slider-local coords, so that
+ deltas are computed correctly with transforms
+ (WebCore::RenderSlider::mouseEventIsInThumb):
+ Rather than computing an absolute bounds for the thumb,
+ convert the point to local coords and compare it with the border box.
+
+2008-11-06 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
+ https://bugs.webkit.org/show_bug.cgi?id=21810
+
+ * bindings/js/GCController.cpp:
+ (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::wrapperSet): Ditto
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::wrappers): Ditto
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::wrappers): Ditto
+ * bridge/runtime_root.cpp:
+ (JSC::Bindings::rootObjectSet): Ditto
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText): Ditto
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType): Ditto
+ * css/CSSStyleSelector.cpp:
+ (WebCore::screenEval): Ditto
+ (WebCore::printEval): Ditto
+ * dom/DOMImplementation.cpp:
+ (WebCore::isSVG10Feature): Ditto
+ (WebCore::isSVG11Feature): Ditto
+ (WebCore::DOMImplementation::isXMLMIMEType): Ditto
+ * dom/Document.cpp:
+ (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
+ * dom/ScriptElement.cpp:
+ (WebCore::isSupportedJavaScriptLanguage): Ditto
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::styleSpanClassString): Ditto
+ * editing/HTMLInterchange.cpp:
+ (WebCore::): Ditto
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::indentBlockquoteString): Ditto
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::isInterchangeNewlineNode): Ditto
+ (WebCore::isInterchangeConvertedSpaceSpan): Ditto
+ * editing/htmlediting.cpp:
+ (WebCore::stringWithRebalancedWhitespace): Ditto
+ (WebCore::nonBreakingSpaceString): Ditto
+ * editing/markup.cpp:
+ (WebCore::appendAttributeValue): Ditto
+ (WebCore::appendEscapedContent): Ditto
+ (WebCore::shouldAddNamespaceAttr): Ditto
+ (WebCore::appendNamespace): Ditto
+ (WebCore::appendStartMarkup): Ditto
+ (WebCore::createMarkup): Ditto
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::type): Ditto
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::isRecognizedTagName): Ditto
+ (WebCore::inlineTagList): Ditto
+ (WebCore::blockTagList): Ditto
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::type): Ditto
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::type): Ditto
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::type): Ditto
+ * html/HTMLLegendElement.cpp:
+ (WebCore::HTMLLegendElement::type): Ditto
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::type): Ditto
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::type): Ditto
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::getNode): Ditto
+ (WebCore::HTMLParser::isHeaderTag): Ditto
+ (WebCore::HTMLParser::isResidualStyleTag): Ditto
+ (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::type): Ditto
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::type): Ditto
+ * inspector/InspectorController.cpp:
+ (WebCore::platform): Ditto
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::shared): Ditto
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::profileCache): Ditto
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::profileNodeCache): Ditto
+ * loader/FrameLoader.cpp:
+ (WebCore::localSchemes): Ditto
+ * loader/appcache/ApplicationCacheStorage.cpp:
+ (WebCore::cacheStorage): Ditto
+ * loader/archive/ArchiveFactory.cpp:
+ (WebCore::archiveMIMETypes): Ditto
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dragState): Ditto
+ * page/Frame.cpp:
+ (WebCore::createRegExpForLabels): Ditto
+ (WebCore::keepAliveSet): Ditto
+ * page/Page.cpp:
+ (WebCore::Page::groupName): Ditto
+ * page/SecurityOrigin.cpp:
+ (WebCore::isDefaultPortForProtocol): Ditto
+ (WebCore::SecurityOrigin::databaseIdentifier): Ditto
+ * page/mac/FrameMac.mm:
+ (WebCore::regExpForLabels): Ditto
+ * platform/KURL.cpp:
+ (WebCore::blankURL): Ditto
+ * platform/graphics/FontCache.cpp:
+ (WebCore::alternateFamilyName): Ditto
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::getSimilarFontPlatformData): Ditto
+ (WebCore::FontCache::getLastResortFallbackFont): Ditto
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarTheme::nativeTheme): Ditto
+ * platform/mac/ThemeMac.mm:
+ (WebCore::platformTheme): Ditto
+ * platform/mac/ThreadCheck.mm:
+ (WebCoreReportThreadViolation): Ditto
+ * platform/network/NetworkStateNotifier.cpp:
+ (WebCore::networkStateNotifier): Ditto
+ * platform/network/mac/FormDataStreamMac.mm:
+ (WebCore::getStreamFormDataMap): Ditto
+ (WebCore::getStreamResourceHandleMap): Ditto
+ * platform/network/mac/ResourceResponseMac.mm:
+ (WebCore::ResourceResponse::platformLazyInit): Ditto
+ * platform/text/TextEncoding.cpp:
+ (WebCore::TextEncoding::isJapanese): Ditto
+ * rendering/RenderBlock.cpp:
+ (WebCore::continuationOutlineTable): Ditto
+ * rendering/RenderCounter.cpp:
+ (WebCore::counterMaps): Ditto
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::markerText): Ditto
+ * rendering/RenderScrollbarTheme.cpp:
+ (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemFont): Ditto
+ * rendering/bidi.cpp:
+ (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::initialDashboardRegions): Ditto
+ (WebCore::RenderStyle::noneDashboardRegions): Ditto
+ * storage/LocalStorage.cpp:
+ (WebCore::localStorageMap): Ditto
+ * svg/SVGAnimateMotionElement.cpp:
+ (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
+ * svg/SVGAnimationElement.cpp:
+ (WebCore::SVGAnimationElement::calcMode): Ditto
+ (WebCore::SVGAnimationElement::attributeType): Ditto
+ (WebCore::SVGAnimationElement::isAdditive): Ditto
+ (WebCore::SVGAnimationElement::isAccumulated): Ditto
+ * svg/SVGLangSpace.cpp:
+ (WebCore::SVGLangSpace::xmlspace): Ditto
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::contentScriptType): Ditto
+ (WebCore::SVGSVGElement::contentStyleType): Ditto
+ * svg/SVGStyleElement.cpp:
+ (WebCore::SVGStyleElement::type): Ditto
+ (WebCore::SVGStyleElement::media): Ditto
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::SVGSMILElement::parseClockValue): Ditto
+ (WebCore::SVGSMILElement::restart): Ditto
+ (WebCore::SVGSMILElement::fill): Ditto
+ (WebCore::SVGSMILElement::repeatCount): Ditto
+ (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
+ * svg/graphics/SVGResource.cpp:
+ (WebCore::clientMap): Ditto
+ * svg/graphics/SVGResourceMarker.cpp:
+ (WebCore::SVGResourceMarker::draw): Ditto
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::preflightResultCache): Ditto
+ (WebCore::isSafeRequestHeader): Ditto
+ (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
+ * xml/XPathExpressionNode.cpp:
+ (WebCore::XPath::Expression::evaluationContext): Ditto
+ * xml/XPathParser.cpp:
+ (WebCore::XPath::isAxisName): Ditto
+ (WebCore::XPath::isNodeTypeName): Ditto
+ * xml/XPathValue.cpp:
+ (WebCore::XPath::Value::toNodeSet): Ditto
+
+2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Remove a bunch of unused methods in the Qt media element implementation
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
+
+2008-11-05 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=21870
+
+ Implement absoluteToLocal() to convert a point from absolute
+ to local coordinates, optionally taking transforms into account.
+
+ Use this to set offsetX/offsetY in mouse events, thus fixing
+ offsetX/offsetY in events on elements with transforms.
+
+ Test: fast/events/offsetX-offsetY.html
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::absoluteToLocal):
+ (WebCore::RenderBox::offsetFromContainer):
+ * rendering/RenderBox.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteToLocal):
+ * rendering/RenderObject.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::localToAbsolute):
+ (WebCore::RenderTableCell::absoluteToLocal):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::absoluteToLocal):
+ * rendering/RenderView.h:
+
+2008-11-06 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Cameron Zwarich.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22067
+ [GTK] Sun Java plugin segfaults at PluginPackage::createPackage()
+
+ null-check symbols loaded from plugin modules, initialize the function
+ table (like Win already does) and update it with the latest
+ additions. Adjust whitespace for easy diff'ing with the Win port code
+ from which it was forked.
+
+ This fixes crashes with libnspr4.so and any other plugins that don't
+ provide the symbols we expect.
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+ (WebCore::PluginPackage::load):
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Removed dead (and broken) code from an ancient Symbian port.
+
+ * config.h:
+ * platform/text/AtomicString.h:
+ * platform/text/PlatformString.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Use QLibrary as PlatformModule when compiling with Qt for S60.
+
+ * platform/FileSystem.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Compile fix for Symbian.
+ The snprintf function is defined in stdio.h, the inclusion
+ of snprintf.h inside this PLATFORM(SYMBIAN) block does not
+ compile.
+
+ * config.h:
+
+2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Disable webkit plugins for Symbian.
+
+ * WebCore.pro:
+
+2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Fix build break in debug mode when XSLT is not enabled
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::dumpStats):
+
+2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon Hausmann.
+
+ Repaint video on UpdateRequest to prevent recursive painting
+
+ Calling QWidget::render() to update the video generates a paint
+ event that's then picked up by the event filter once more :(
+
+ We're really only interested in updates from Phonon, which we
+ get through the UpdateRequest for each new frame.
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::eventFilter):
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the WebCore build for some platforms by changing build scripts to
+ account for the recent move of the create_hash_table script from the kjs
+ subdirectory of JavaScriptCore to the root directory.
+
+ * WebCore.pro:
+ * make-generated-sources.sh:
+
+2008-11-06 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix a case-sensitivity issue in Mac forwarding headers. Strangely
+ enough, this does not always cause the build to break, even with a
+ case-sensitive filesystem.
+
+ * ForwardingHeaders/runtime/Interpreter.h:
+
+2008-11-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22083
+ MessageEvents cannot be used across threads
+
+ * dom/Event.idl:
+ * dom/MessageEvent.idl:
+ Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables
+ won't work.
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::EventData::EventData):
+ (WebCore::MessagePort::EventData::~EventData):
+ (WebCore::MessagePort::clone):
+ (WebCore::MessagePort::postMessage):
+ (WebCore::MessagePort::startConversation):
+ (WebCore::MessagePort::dispatchMessages):
+ * dom/MessagePort.h:
+ Don't create a MessageEvent until dispatch time - messages can be posted across threads,
+ but MessageEvents are tied to the thread that they were created in.
+
+2008-11-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22066
+ Implement Worker global object
+
+ * DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.
+
+ * WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker
+ support is still disabled by default.
+
+ * bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.
+
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.
+
+ * bindings/js/JSWorkerContext.cpp: Added.
+ * bindings/js/JSWorkerContext.h: Added.
+ * bindings/js/WorkerScriptController.cpp: Added.
+ * bindings/js/WorkerScriptController.h: Added.
+ * dom/WorkerContext.cpp: Added.
+ * dom/WorkerContext.h: Added.
+ Added an implementation of worker contexts.
+
+ * dom/DedicatedWorker.cpp:
+ (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests.
+ (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership
+ and lifetime is not clear at all.
+
+ * dom/WorkerLocation.cpp: Added.
+ * dom/WorkerLocation.h: Added.
+ * dom/WorkerLocation.idl: Added.
+ Added WorkerLocation, which is one of the objects available to workers.
+
+ * dom/WorkerThread.cpp: Added.
+ (WebCore::WorkerThread::WorkerThread):
+ (WebCore::WorkerThread::start):
+ (WebCore::WorkerThread::workerThreadStart):
+ (WebCore::WorkerThread::workerThread):
+ * dom/WorkerThread.h: Added.
+ (WebCore::WorkerThread::create):
+ Run some code in a worker thread (no message loop yet).
+
+2008-11-05 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22093
+ Don't keep decoded stylesheet data in cache
+
+ <rdar://problem/6343588>
+
+ Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
+ performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
+ style sheet data in cache by 2/3 in common case.
+
+ * loader/CachedCSSStyleSheet.cpp:
+ (WebCore::CachedCSSStyleSheet::sheetText):
+ (WebCore::CachedCSSStyleSheet::data):
+ * loader/CachedCSSStyleSheet.h:
+
+2008-11-05 David Kilzer <ddkilzer@apple.com>
+
+ Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21596>
+
+ Reviewed by Antti.
+
+ This patch adds real parsing for Pragma and Cache-Control headers
+ based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
+ new String and StringImpl methods to assist with the parsing.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::dumpStats): Added. Convenience method for dumping
+ stats outside of Safari.
+ * loader/Cache.h: Declared dumpStats().
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::mustRevalidate): Updated to use
+ ResourceResponseBase::cacheControlDirectives() instead of substring
+ matching of the entire Cache-Control header.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didReceiveResponse): Used the local
+ 'resource' variable instead of 'request->cachedResource()'.
+
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::setHTTPHeaderField): Set
+ m_haveParsedCacheControlHeader to false when a "Cache-Control"
+ header is set. Ditto for m_haveParsedPragmaHeader and "Pragma".
+ (WebCore::ResourceResponseBase::parsePragmaDirectives): Added.
+ Provides parsed Pragma header directives.
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added.
+ Provides parsed Cache-Control header directives.
+ (WebCore::isCacheHeaderSeparator): Added. Returns true if a
+ character is a separator character per RFC 2616, Section 2.2, else
+ returns false.
+ (WebCore::isControlCharacter): Added. Returns true if a character
+ is a control character per RFC 2616 Section 2.2, else returns false.
+ (WebCore::trimToNextSeparator): Added. Returns a string truncated
+ at the first separator character per isCacheHeaderSeparator().
+ (WebCore::parseCacheHeader): Added. This is the main parsing
+ routine for both Cache-Control and Pragma headers.
+ (WebCore::parseCacheControlDirectiveValues): Added. This splits
+ certain Cache-Control directive values into a vector of strings.
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed
+ Cache-Control header.
+ (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma
+ header.
+ (WebCore::ResourceResponseBase::parsePragmaDirectives): Added
+ declaration.
+ (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto.
+ (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader):
+ Added. Boolean to describe when the "Cache-Control" header needs to
+ be reparsed.
+ (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added.
+ Boolean to describe when the "Pragma" header needs to be reparsed.
+ (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added.
+ Cached map to hold parsed "Cache-Control" headers.
+ (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added.
+ Cached map to hold parsed "Pragma" headers.
+
+ * platform/text/PlatformString.h:
+ (WebCore::String::find): Added. Returns the first match based on
+ the character-matching function pointer passed in.
+ (WebCore::String::removeCharacters): Added declaration.
+ (WebCore::find): Added. Inline method that takes a character-
+ matching function pointer. Called by StringImpl::find().
+ * platform/text/String.cpp:
+ (WebCore::String::removeCharacters): Added. Calls
+ StringImpl::removeCharacters().
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::removeCharacters): Added. Returns a string
+ with all characters removed that match the character-matching
+ function pointer passed in. If there is no change to the string, it
+ returns itself. Based heavily on StringImpl::simplifyWhitespace().
+ (WebCore::StringImpl::find): Added. Calls WebCore::find().
+ * platform/text/StringImpl.h:
+ (WebCore::FindMatchFunctionPtr): Added. Typedef for a character-
+ matching function pointer.
+ (WebCore::StringImpl::removeCharacters): Added declaration.
+ (WebCore::StringImpl::find): Ditto.
+
+2008-11-05 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break
+
+ As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
+ between two blockquotes. Because the start merge moves the text node into a blockquote, when we
+ determine whether or not we should do the end merge, it incorrectly appears as though the end merge
+ is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
+ before we do the start merge, so that the start merge doesn't effect our decision.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean.
+ (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity.
+ (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
+ * editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculatively fix the Windows build, even though these changes may not
+ actually matter for anything in the build, because the Windows bots are
+ behind.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_class.cpp:
+ * bridge/qt/qt_runtime.h:
+
+2008-11-05 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move more files to the runtime subdirectory of JavaScriptCore.
+
+ * ForwardingHeaders/kjs/collector.h: Removed.
+ * ForwardingHeaders/kjs/completion.h: Removed.
+ * ForwardingHeaders/kjs/identifier.h: Removed.
+ * ForwardingHeaders/kjs/interpreter.h: Removed.
+ * ForwardingHeaders/kjs/lookup.h: Removed.
+ * ForwardingHeaders/kjs/operations.h: Removed.
+ * ForwardingHeaders/kjs/protect.h: Removed.
+ * ForwardingHeaders/kjs/ustring.h: Removed.
+ * ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
+ * ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
+ * ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
+ * ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
+ * ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
+ * ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
+ * ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
+ * ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
+ * bindings/js/GCController.cpp:
+ * bindings/js/JSCustomPositionCallback.h:
+ * bindings/js/JSCustomPositionErrorCallback.h:
+ * bindings/js/JSCustomSQLStatementCallback.h:
+ * bindings/js/JSCustomSQLStatementErrorCallback.h:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h:
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSEventListener.h:
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptController.h:
+ * bindings/objc/WebScriptObject.mm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/c/c_class.cpp:
+ * bridge/jni/jni_class.cpp:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/npruntime.cpp:
+ * bridge/runtime_root.h:
+ * history/CachedPage.h:
+ * html/CanvasRenderingContext2D.cpp:
+ * html/HTMLCanvasElement.cpp:
+ * inspector/InspectorController.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * page/Console.cpp:
+ * page/Page.cpp:
+ * platform/text/AtomicString.cpp:
+ * platform/text/PlatformString.h:
+
+2008-11-05 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=22085
+ The Plugin JS object should expose item() and namedItem() methods to match Firefox
+
+ * bindings/js/JSPluginCustom.cpp:
+ (WebCore::JSPlugin::nameGetter):
+ * plugins/Plugin.cpp:
+ (WebCore::Plugin::namedItem):
+ * plugins/Plugin.h:
+ * plugins/Plugin.idl:
+
+2008-11-05 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21060
+ Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR
+
+ Test: fast/dom/Range/surroundContents-check-boundary-points.html
+
+ * dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.
+
+2008-11-05 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Remove two global destructors from CoreTextController.
+
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
+
+2008-11-05 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ CRASH at Scrollbar::invalidateRect due to null m_client
+ https://bugs.webkit.org/show_bug.cgi?id=22080
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::isWindowActive):
+ (WebCore::Scrollbar::invalidateRect):
+
+2008-11-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=21648
+ navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS
+
+ - Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.
+
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ (WebCore::JSMimeTypeArray::nameGetter):
+ * bindings/js/JSPluginArrayCustom.cpp:
+ (WebCore::JSPluginArray::nameGetter):
+ * page/DOMWindow.idl:
+ * plugins/MimeType.idl:
+ * plugins/MimeTypeArray.cpp:
+ (WebCore::MimeTypeArray::namedItem):
+ * plugins/MimeTypeArray.h:
+ * plugins/MimeTypeArray.idl:
+ * plugins/Plugin.idl:
+ * plugins/PluginArray.cpp:
+ (WebCore::PluginArray::namedItem):
+ * plugins/PluginArray.h:
+ * plugins/PluginArray.idl:
+
+2008-11-05 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+
+ * plugins/PluginPackage.cpp:
+
+2008-11-05 Jeff Cook <cookiecaper@gmail.com>
+
+ Reviewed by Simon Hausmann and Tor Arne.
+
+ Fix crash in the Qt port when unloading swfdec and Flash 10
+ by reordering window destruction and plugin stop.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=20779
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::stop):
+
+2008-11-05 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø
+
+ Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.
+
+ Otherwise Flash refuses to load and function :(
+
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::determineQuirks):
+ * plugins/PluginQuirkSet.h:
+ (WebCore::):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::getValue):
+
+2008-11-05 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Tor Arne Vestbø
+
+ Unify determineQuirks between the Qt and the Gtk PluginPackage.
+ Share the code for parsing the module version from the description.
+ This is currently used to determine Flash based quirks.
+
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::createPackage):
+ (WebCore::PluginPackage::determineQuirks):
+ (WebCore::PluginPackage::determineModuleVersionFromDescription):
+ * plugins/PluginPackage.h:
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore.
+
+ * ForwardingHeaders/kjs/dtoa.h: Removed.
+ * ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
+ * css/CSSParser.cpp:
+ * platform/text/String.cpp:
+ * platform/text/StringImpl.cpp:
+
+2008-11-04 Jonathan Haas <myrdred@gmail.com>
+
+ Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fixed an issue which could cause memory corruption using ToT libxml.
+ See https://bugs.webkit.org/show_bug.cgi?id=15715
+
+ Test: fast/xsl/xslt-nested-stylesheets.xml
+
+ * xml/XSLImportRule.cpp:
+ (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
+ * xml/XSLStyleSheet.cpp:
+ (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet
+ (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary
+ (WebCore::XSLStyleSheet::setParentStyleSheet): Added
+ * xml/XSLStyleSheet.h: Added m_parentStyleSheet member
+
+2008-11-04 Simon Fraser <simon.fraser@apple.com>
+
+ No review.
+
+ Improved buid fix: include MathExtras.h to get roundf on all platforms.
+
+ * platform/graphics/FloatPoint.h:
+
+2008-11-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by John Sullivan
+
+ Add a simple "visited" method to HistoryItem for use by global history
+
+ * WebCore.base.exp:
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::visited): Update the title on the item, set last visited time,
+ and bump the visit count. All things that should happen when a url is visited again!
+ * history/HistoryItem.h:
+
+2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Build fix. Not reviewed.
+
+ * platform/graphics/FloatPoint.h: include math.h.
+ reported by zdobersek in #webkit.
+
+2008-11-04 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Anders Carlsson.
+
+ No need to clobber all ResourceRequest fields in FrameLoader::reload()
+ https://bugs.webkit.org/show_bug.cgi?id=21949
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::reload):
+
+2008-11-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ * storage/Database.cpp:
+ (WebCore::databaseVersionKey): Tweaked formatting.
+
+2008-11-03 Darin Adler <darin@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=22061
+ create script to check for exit-time destructors
+
+ * WebCore.xcodeproj/project.pbxproj: Added a script
+ phase that runs the check-for-exit-time-destructors script.
+
+ * html/HTMLAttributeNames.in: Removed some unused attribute names.
+
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that
+ sets the write-only m_pluginPage.
+ * html/HTMLEmbedElement.h: Ditto.
+
+ * platform/mac/CursorMac.mm:
+ (WebCore::leakNamedCursor): Changed to return a Cursor&.
+ (WebCore::pointerCursor): Changed to leak an object to avoid an
+ exit-time destructor.
+ (WebCore::crossCursor): Ditto.
+ (WebCore::handCursor): Ditto.
+ (WebCore::moveCursor): Ditto.
+ (WebCore::verticalTextCursor): Ditto.
+ (WebCore::cellCursor): Ditto.
+ (WebCore::contextMenuCursor): Ditto.
+ (WebCore::aliasCursor): Ditto.
+ (WebCore::zoomInCursor): Ditto.
+ (WebCore::zoomOutCursor): Ditto.
+ (WebCore::copyCursor): Ditto.
+ (WebCore::noneCursor): Ditto.
+ (WebCore::progressCursor): Ditto.
+ (WebCore::noDropCursor): Ditto.
+ (WebCore::notAllowedCursor): Ditto.
+ (WebCore::iBeamCursor): Ditto.
+ (WebCore::waitCursor): Ditto.
+ (WebCore::helpCursor): Ditto.
+ (WebCore::eastResizeCursor): Ditto.
+ (WebCore::northResizeCursor): Ditto.
+ (WebCore::northEastResizeCursor): Ditto.
+ (WebCore::northWestResizeCursor): Ditto.
+ (WebCore::southResizeCursor): Ditto.
+ (WebCore::southEastResizeCursor): Ditto.
+ (WebCore::southWestResizeCursor): Ditto.
+ (WebCore::westResizeCursor): Ditto.
+ (WebCore::northSouthResizeCursor): Ditto.
+ (WebCore::eastWestResizeCursor): Ditto.
+ (WebCore::northEastSouthWestResizeCursor): Ditto.
+ (WebCore::northWestSouthEastResizeCursor): Ditto.
+ (WebCore::columnResizeCursor): Ditto.
+ (WebCore::rowResizeCursor): Ditto.
+ (WebCore::grabCursor): Ditto.
+ (WebCore::grabbingCursor): Ditto.
+
+ * storage/Database.cpp:
+ (WebCore::guidMutex): Changed to leak an object to avoid an
+ exit-time destructor. Also added a comment explaining why it's
+ thread safe.
+ (WebCore::guidToVersionMap): Ditto.
+ (WebCore::guidToDatabaseMap): Ditto.
+ (WebCore::Database::databaseInfoTableName): Ditto.
+ (WebCore::databaseVersionKey): Ditto.
+ (WebCore::Database::getVersionFromDatabase): Ditto.
+ (WebCore::Database::setVersionInDatabase): Ditto.
+ (WebCore::guidForOriginAndName): Ditto.
+ * storage/DatabaseTracker.cpp:
+ (WebCore::DatabaseTracker::tracker): Ditto.
+ (WebCore::notificationMutex): Ditto.
+ (WebCore::notificationQueue): Ditto.
+ (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.
+
+2008-11-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=21941
+
+ Rename absolutePosition() to localToAbsolute(), and add the ability
+ to optionally take transforms into account (which will eventually be the
+ default behavior).
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getUpperLeftCorner):
+ (WebCore::ContainerNode::getLowerRightCorner):
+ (WebCore::ContainerNode::getRect):
+ * dom/ContainerNode.h:
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::receivedTarget):
+ * dom/Node.cpp:
+ (WebCore::Node::getRect):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::layout):
+ (WebCore::SelectionController::caretRect):
+ * editing/visible_units.cpp:
+ (WebCore::previousLinePosition):
+ (WebCore::nextLinePosition):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::getRect):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::x):
+ (WebCore::HTMLImageElement::y):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * html/HTMLInputElement.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleDrag):
+ * platform/graphics/FloatPoint.h:
+ (WebCore::roundedIntPoint):
+ * platform/graphics/IntSize.h:
+ (WebCore::IntSize::expand):
+ * rendering/LayoutState.cpp:
+ (WebCore::LayoutState::LayoutState):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::paintObject):
+ (WebCore::RenderBlock::selectionGapRects):
+ (WebCore::RenderBlock::fillBlockSelectionGaps):
+ (WebCore::RenderBlock::nodeAtPoint):
+ (WebCore::RenderBlock::positionForCoordinates):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::localToAbsolute):
+ (WebCore::RenderBox::computeAbsoluteRepaintRect):
+ (WebCore::RenderBox::caretRect):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::relativePositionOffset):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addLineBoxRects):
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::absoluteClippedOverflowRect):
+ (WebCore::RenderFlow::caretRect):
+ (WebCore::RenderFlow::addFocusRingRects):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition):
+ (WebCore::RenderLayer::convertToLayerCoords):
+ (WebCore::RenderLayer::addScrolledContentOffset):
+ (WebCore::RenderLayer::subtractScrolledContentOffset):
+ (WebCore::RenderLayer::scrollRectToVisible):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::scrolledContentOffset):
+ (WebCore::RenderLayer::relativePositionOffset):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::panScroll):
+ (WebCore::RenderListBox::scrollToward):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::selectionRect):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::absoluteBoundingBoxRect):
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+ (WebCore::RenderObject::localToAbsolute):
+ (WebCore::RenderObject::addDashboardRegions):
+ (WebCore::RenderObject::absoluteContentBox):
+ (WebCore::RenderObject::absoluteOutlineBox):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::localToAbsoluteForContent):
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::updateWidgetPosition):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::selectionRect):
+ * rendering/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::absoluteRects):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::localToAbsolute):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::addLineBoxRects):
+ (WebCore::RenderText::caretRect):
+ (WebCore::RenderText::selectionRect):
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::updatePlayer):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::localToAbsolute):
+ * rendering/RenderView.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::updateWidgetPosition):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::getScreenCTM):
+
+2008-11-03 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Add methods for getting and setting user data on History Item.
+ This change is limited to QT port only. Tests were added in
+ the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.
+
+ Minor change by Simon: made the functions inline and added a missing
+ const.
+
+ * history/HistoryItem.h:
+
+2008-11-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22030
+ Make EventNames usable from multiple threads
+
+ * platform/text/AtomicString.cpp:
+ (WebCore::stringTable):
+ (WebCore::AtomicString::add):
+ (WebCore::AtomicString::remove):
+ (WebCore::AtomicString::find):
+ (WebCore::AtomicString::init):
+ * platform/text/AtomicString.h:
+ Atomic string table is now per-thread. Individual strings cannot be shared between threads,
+ so global AtomicString constants cannot be used from threads other than the main one.
+
+ * dom/EventNames.cpp:
+ (WebCore::EventNames::EventNames):
+ (WebCore::eventNames):
+ (WebCore::EventNames::init):
+ * dom/EventNames.h:
+ Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
+ eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
+ threads.
+
+ * WebCore.base.exp:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::processingUserGesture):
+ * dom/BeforeTextInsertedEvent.cpp:
+ (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent):
+ * dom/BeforeUnloadEvent.cpp:
+ (WebCore::BeforeUnloadEvent::BeforeUnloadEvent):
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::dispatchModifiedEvent):
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/DedicatedWorker.cpp:
+ (WebCore::DedicatedWorker::dispatchErrorEvent):
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ (WebCore::Document::setFocusedNode):
+ (WebCore::Document::addListenerTypeIfNeeded):
+ (WebCore::Document::removeWindowInlineEventListenerForType):
+ (WebCore::Document::addWindowEventListener):
+ (WebCore::Document::removeWindowEventListener):
+ (WebCore::Document::finishedParsing):
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchGenericEvent):
+ (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
+ (WebCore::EventTargetNode::dispatchWindowEvent):
+ (WebCore::EventTargetNode::dispatchUIEvent):
+ (WebCore::EventTargetNode::dispatchSimulatedClick):
+ (WebCore::EventTargetNode::dispatchMouseEvent):
+ (WebCore::EventTargetNode::dispatchFocusEvent):
+ (WebCore::EventTargetNode::dispatchBlurEvent):
+ (WebCore::EventTargetNode::defaultEventHandler):
+ (WebCore::EventTargetNode::on*): (multiple methods)
+ (WebCore::EventTargetNode::setOn*): (multiple methods)
+ * dom/KeyboardEvent.cpp:
+ (WebCore::eventTypeForKeyboardEventType):
+ (WebCore::KeyboardEvent::keyCode):
+ (WebCore::KeyboardEvent::charCode):
+ * dom/MessageEvent.cpp:
+ (WebCore::MessageEvent::MessageEvent):
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::dispatchMessages):
+ (WebCore::MessagePort::dispatchCloseEvent):
+ * dom/MouseEvent.cpp:
+ (WebCore::MouseEvent::isDragEvent):
+ (WebCore::MouseEvent::toElement):
+ (WebCore::MouseEvent::fromElement):
+ * dom/OverflowEvent.cpp:
+ (WebCore::OverflowEvent::OverflowEvent):
+ * dom/TextEvent.cpp:
+ (WebCore::TextEvent::TextEvent):
+ * dom/WebKitAnimationEvent.cpp:
+ (WebCore::WebKitAnimationEvent::WebKitAnimationEvent):
+ (WebCore::WebKitAnimationEvent::~WebKitAnimationEvent):
+ (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent):
+ (WebCore::WebKitAnimationEvent::animationName):
+ (WebCore::WebKitAnimationEvent::elapsedTime):
+ * dom/WebKitTransitionEvent.cpp:
+ (WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
+ (WebCore::WebKitTransitionEvent::~WebKitTransitionEvent):
+ (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):
+ (WebCore::WebKitTransitionEvent::propertyName):
+ (WebCore::WebKitTransitionEvent::elapsedTime):
+ * dom/WheelEvent.cpp:
+ (WebCore::WheelEvent::WheelEvent):
+ (WebCore::WheelEvent::initWheelEvent):
+ * dom/XMLTokenizerLibxml2.cpp:
+ * dom/XMLTokenizerQt.cpp:
+ * editing/DeleteButton.cpp:
+ (WebCore::DeleteButton::defaultEventHandler):
+ * editing/EditCommand.cpp:
+ * editing/Editor.cpp:
+ (WebCore::Editor::canDHTMLCut):
+ (WebCore::Editor::canDHTMLCopy):
+ (WebCore::Editor::canDHTMLPaste):
+ (WebCore::Editor::tryDHTMLCopy):
+ (WebCore::Editor::tryDHTMLCut):
+ (WebCore::Editor::tryDHTMLPaste):
+ (WebCore::dispatchEditableContentChangedEvents):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::setFocused):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::parseMappedAttribute):
+ (WebCore::HTMLButtonElement::defaultEventHandler):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::parseMappedAttribute):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::onChange):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::handleLocalEvents):
+ (WebCore::HTMLFormElement::prepareSubmit):
+ (WebCore::HTMLFormElement::reset):
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ (WebCore::HTMLInputElement::preDispatchEventHandler):
+ (WebCore::HTMLInputElement::postDispatchEventHandler):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ (WebCore::HTMLInputElement::onSearch):
+ * html/HTMLLabelElement.cpp:
+ (WebCore::HTMLLabelElement::defaultEventHandler):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::load):
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
+ (WebCore::HTMLMediaElement::setReadyState):
+ (WebCore::HTMLMediaElement::progressEventTimerFired):
+ (WebCore::HTMLMediaElement::seek):
+ (WebCore::HTMLMediaElement::setDefaultPlaybackRate):
+ (WebCore::HTMLMediaElement::setPlaybackRate):
+ (WebCore::HTMLMediaElement::play):
+ (WebCore::HTMLMediaElement::pause):
+ (WebCore::HTMLMediaElement::setVolume):
+ (WebCore::HTMLMediaElement::setMuted):
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+ (WebCore::HTMLMediaElement::documentWillBecomeInactive):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLOptionElement.cpp:
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ (WebCore::HTMLScriptElement::dispatchLoadEvent):
+ (WebCore::HTMLScriptElement::dispatchErrorEvent):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ (WebCore::HTMLSelectElement::defaultEventHandler):
+ (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::parseMappedAttribute):
+ (WebCore::HTMLTextAreaElement::defaultEventHandler):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::canCachePage):
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageEventListener::handleEvent):
+ * loader/ImageLoader.cpp:
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::callCheckingListener):
+ (WebCore::DOMApplicationCache::callErrorListener):
+ (WebCore::DOMApplicationCache::callNoUpdateListener):
+ (WebCore::DOMApplicationCache::callDownloadingListener):
+ (WebCore::DOMApplicationCache::callProgressListener):
+ (WebCore::DOMApplicationCache::callUpdateReadyListener):
+ (WebCore::DOMApplicationCache::callCachedListener):
+ * page/AccessibilityObject.cpp:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::handleContextMenuEvent):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::on*): (multiple methods)
+ (WebCore::DOMWindow::setOn*): (multiple methods)
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::updateDragAndDrop):
+ (WebCore::EventHandler::cancelDragAndDrop):
+ (WebCore::EventHandler::performDragAndDrop):
+ (WebCore::EventHandler::updateMouseEventTargetNode):
+ (WebCore::EventHandler::dispatchMouseEvent):
+ (WebCore::EventHandler::sendContextMenuEvent):
+ (WebCore::EventHandler::canMouseDownStartSelect):
+ (WebCore::EventHandler::canMouseDragExtendSelect):
+ (WebCore::EventHandler::defaultKeyboardEventHandler):
+ (WebCore::EventHandler::dragSourceMovedTo):
+ (WebCore::EventHandler::dragSourceEndedAt):
+ (WebCore::EventHandler::handleDrag):
+ (WebCore::EventHandler::handleTextInputEvent):
+ * page/FocusController.cpp:
+ * page/Frame.cpp:
+ (WebCore::Frame::sendResizeEvent):
+ (WebCore::Frame::sendScrollEvent):
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+ (WebCore::AnimationBase::animationTimerCallbackFired):
+ (WebCore::AnimationBase::primeEventTimers):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::onAnimationEnd):
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::onAnimationStart):
+ (WebCore::KeyframeAnimation::onAnimationIteration):
+ (WebCore::KeyframeAnimation::onAnimationEnd):
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ * page/gtk/EventHandlerGtk.cpp:
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::isKeyboardOptionTab):
+ * page/mac/FrameMac.mm:
+ * page/qt/EventHandlerQt.cpp:
+ (WebCore::isKeyboardOptionTab):
+ * plugins/PluginView.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ * plugins/qt/PluginViewQt.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlMuteButtonElement::defaultEventHandler):
+ (WebCore::MediaControlPlayButtonElement::defaultEventHandler):
+ (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
+ (WebCore::MediaControlTimelineElement::defaultEventHandler):
+ (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::userResize):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::valueChanged):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::forwardEvent):
+ * rendering/RenderObject.cpp:
+ * rendering/RenderSlider.cpp:
+ (WebCore::HTMLSliderThumbElement::defaultEventHandler):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::forwardEvent):
+ (WebCore::RenderTextControl::selectionChanged):
+ * rendering/RenderWidget.cpp:
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+ (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
+ (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
+ * storage/LocalStorageArea.cpp:
+ (WebCore::LocalStorageArea::dispatchStorageEvent):
+ * storage/SessionStorageArea.cpp:
+ (WebCore::SessionStorageArea::dispatchStorageEvent):
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+ * svg/SVGDocument.cpp:
+ (WebCore::SVGDocument::dispatchZoomEvent):
+ (WebCore::SVGDocument::dispatchScrollEvent):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::parseMappedAttribute):
+ (WebCore::hasLoadListener):
+ (WebCore::SVGElement::sendSVGLoadEventIfPossible):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::on*): (multiple methods)
+ (WebCore::SVGElementInstance::setOn*): (multiple methods)
+ * svg/SVGImageLoader.cpp:
+ (WebCore::SVGImageLoader::dispatchLoadEvent):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::dispatchErrorEvent):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
+ (WebCore::XMLHttpRequest::dispatchAbortEvent):
+ (WebCore::XMLHttpRequest::dispatchErrorEvent):
+ (WebCore::XMLHttpRequest::dispatchLoadEvent):
+ (WebCore::XMLHttpRequest::dispatchLoadStartEvent):
+ (WebCore::XMLHttpRequest::dispatchProgressEvent):
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
+ (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
+ (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
+ (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
+ (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
+ * xml/XPathResult.cpp:
+ (WebCore::XPathResult::XPathResult):
+ (WebCore::XPathResult::~XPathResult):
+ (WebCore::XPathResult::invalidateIteratorState):
+ Access event names via eventNames() function.
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Delete unused forwarding headers.
+
+ * ForwardingHeaders/kjs/Activation.h: Removed.
+ * ForwardingHeaders/kjs/Register.h: Removed.
+ * ForwardingHeaders/kjs/RegisterID.h: Removed.
+
+2008-11-04 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix stupid typo in previous build fix.
+
+ * bindings/js/JSStorageCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+
+2008-11-03 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the build for all non-Mac platforms.
+
+ * ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
+ * ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
+ * bindings/js/JSStorageCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+
+2008-11-03 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the wxWindows build.
+
+ * bridge/c/c_instance.cpp:
+
+2008-11-03 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Move more files into the runtime subdirectory of JavaScriptCore.
+
+ * ForwardingHeaders/kjs/ArgList.h: Removed.
+ * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
+ * ForwardingHeaders/kjs/ExecState.h: Removed.
+ * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
+ * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
+ * ForwardingHeaders/kjs/JSLock.h: Removed.
+ * ForwardingHeaders/kjs/SymbolTable.h: Removed.
+ * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
+ * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
+ * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
+ * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
+ * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
+ * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
+ * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
+ * bindings/js/GCController.cpp:
+ * bindings/js/JSCustomPositionCallback.cpp:
+ * bindings/js/JSCustomPositionErrorCallback.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.cpp:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSEventCustom.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSNodeFilterCondition.cpp:
+ * bindings/js/ScheduledAction.cpp:
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptControllerMac.mm:
+ * bindings/objc/WebScriptObject.mm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/c/c_class.cpp:
+ * bridge/c/c_instance.cpp:
+ * bridge/c/c_runtime.cpp:
+ * bridge/c/c_utility.cpp:
+ * bridge/jni/jni_class.cpp:
+ * bridge/jni/jni_instance.cpp:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/jni/jni_objc.mm:
+ * bridge/jni/jni_runtime.cpp:
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ * bridge/npruntime.cpp:
+ * bridge/objc/objc_instance.mm:
+ * bridge/objc/objc_runtime.mm:
+ * bridge/objc/objc_utility.mm:
+ * bridge/runtime.cpp:
+ * dom/Document.cpp:
+ * dom/Node.cpp:
+ * dom/NodeFilter.cpp:
+ * dom/NodeIterator.cpp:
+ * dom/TreeWalker.cpp:
+ * history/CachedPage.cpp:
+ * inspector/InspectorController.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptDebugServer.cpp:
+ * inspector/JavaScriptProfileNode.cpp:
+ * loader/FrameLoader.cpp:
+ * loader/icon/IconDatabase.cpp:
+ * page/Console.cpp:
+ * page/Page.cpp:
+ * page/mac/FrameMac.mm:
+ * plugins/PluginView.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ * plugins/qt/PluginViewQt.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ * storage/Database.cpp:
+ * xml/XMLHttpRequest.cpp:
+
+2008-11-03 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove the forwarding header for FunctionCallProfile, because it was
+ renamed to ProfileNode in r33466.
+
+ * ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.
+
+2008-11-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=22026
+
+ When computing the bounds of the transparency layer, we need to
+ map the clipRect through the enclosing transform.
+
+ Test: fast/layers/opacity-transforms.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::transparencyClipBox):
+
+2008-11-03 Kevin Decker <kdecker@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22053
+
+ Added additional support needed for the NPDrawingModelCoreAnimation drawing model.
+
+ * bridge/npapi.h:
+
+2008-11-03 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Alp Toker.
+
+ Update parseDataUrl() function in the libsoup http backend with
+ the one from the curl backend which has recent correctness and crash
+ fixes.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::parseDataUrl):
+
+2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22041
+ Fix CURL crashes on the test suite
+
+ Fix segfault with setDefersLoading(). Do not call into curl when we
+ don't have a CURL handle.
+
+ It is attempted to defer the loading before the load has been
+ started (no curl handle was allocated yet). If that happens then
+ just remember that. ResourceHandleManager::startJob is already taking
+ care of this and in initResourceHandle the the downloading will
+ be paused if needed.
+
+ Fixes fast/loader/simultaneous-reloads-assert.html
+
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::ResourceHandle::setDefersLoading):
+
+2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22041
+ Fix CURL crashes on the test suite
+
+ Do not send "no data" to WebCore in parseDataUrl().
+
+ Fixes assert on fast/tokenizer/image-empty-crash.html
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::parseDataUrl):
+
+2008-11-02 Xan Lopez <xan@gnome.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22009
+ HTML5 Video with GStreamer pulls gnome-vfs without using it
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ Remove gnome-vfs include.
+
+2008-11-01 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Be sure to check the final URLs of requested resources to make sure we
+ don't get fooled by HTTP redirects.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21963
+
+ Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
+ http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
+
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::openFunc):
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::canRequest):
+ (WebCore::DocLoader::requestResource):
+ * loader/DocLoader.h:
+ * xml/XSLTProcessor.cpp:
+ (WebCore::docLoaderFunc):
+
+2008-11-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22001
+ AtomicStringImpl* keys of event listener maps can outlive their strings
+
+ Test: fast/events/destroyed-atomic-string.html
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::addEventListener):
+ (WebCore::MessagePort::removeEventListener):
+ (WebCore::MessagePort::dispatchEvent):
+ * dom/MessagePort.h:
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::addEventListener):
+ (WebCore::DOMApplicationCache::removeEventListener):
+ (WebCore::DOMApplicationCache::dispatchEvent):
+ * loader/appcache/DOMApplicationCache.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::addEventListener):
+ (WebCore::XMLHttpRequest::removeEventListener):
+ (WebCore::XMLHttpRequest::dispatchEvent):
+ * xml/XMLHttpRequest.h:
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::addEventListener):
+ (WebCore::XMLHttpRequestUpload::removeEventListener):
+ (WebCore::XMLHttpRequestUpload::dispatchEvent):
+ * xml/XMLHttpRequestUpload.h:
+ Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
+
+2008-10-31 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21998
+ Use JSDOMGlobalObject in EventListener-related bindings
+
+ * dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
+ bindings for inline event handlers.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ (WebCore::JSEventTargetNode::addEventListener):
+ (WebCore::JSEventTargetNode::removeEventListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::removeEventListener):
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
+
+ * dom/EventTarget.h:
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::scriptExecutionContext):
+ * dom/EventTargetNode.h:
+ * dom/MessagePort.cpp:
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::scriptExecutionContext):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::scriptExecutionContext):
+ * loader/appcache/DOMApplicationCache.h:
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::scriptExecutionContext):
+ * svg/SVGElementInstance.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::scriptExecutionContext):
+ * xml/XMLHttpRequest.h:
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
+ * xml/XMLHttpRequestUpload.h:
+ Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
+ available yet.
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Geoff Garen.
+
+ Rename SourceRange.h to SourceCode.h.
+
+ * ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
+ * ForwardingHeaders/kjs/SourceRange.h: Removed.
+ * bindings/js/StringSourceProvider.h:
+ * bridge/NP_jsobject.cpp:
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
+ <https://bugs.webkit.org/show_bug.cgi?id=22019>
+
+ * WebCore.base.exp:
+ * page/Console.cpp:
+ (WebCore::printToStandardOut):
+ (WebCore::Console::shouldPrintExceptions):
+ (WebCore::Console::setShouldPrintExceptions):
+ * page/Console.h:
+
+2008-10-31 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
+
+ * dom/Document.cpp:
+ (WebCore::Document::cookie): Added checking if cookies are disabled.
+ (WebCore::Document::setCookie): Ditto.
+ * page/Navigator.cpp:
+ (WebCore::Navigator::cookieEnabled): Ditto.
+ * page/Page.cpp:
+ (WebCore::Page::Page): Initialize m_cookieEnabled to true.
+ * page/Page.h:
+ (WebCore::Page::cookieEnabled): Added.
+ (WebCore::Page::setCookieEnabled): Added.
+
+2008-10-31 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
+ https://bugs.webkit.org/show_bug.cgi?id=22008
+
+ * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon):
+ Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
+ * platform/graphics/Icon.h: ditto.
+ * platform/graphics/gtk/IconGtk.cpp:
+ (WebCore::Icon::createIconForFile): ditto.
+ (WebCore::Icon::createIconForFiles): ditto.
+ * platform/graphics/mac/IconMac.mm:
+ (WebCore::Icon::createIconForFile): ditto.
+ (WebCore::Icon::createIconForFiles): ditto.
+ * platform/graphics/qt/IconQt.cpp:
+ (WebCore::Icon::createIconForFile): ditto.
+ (WebCore::Icon::createIconForFiles): ditto.
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (Icon::createIconForFile): ditto.
+ (Icon::createIconForFiles): ditto.
+ * platform/graphics/win/IconWin.cpp:
+ (WebCore::Icon::createIconForFile): ditto.
+ (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
+
+ * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
+ Improve icon creation code to match new code in Icon::createIconForFiles
+
+2008-10-31 Timothy Hatcher <timothy@apple.com>
+
+ Add manual tests that check breakpoints on a blockless body of "for" loops.
+
+ https://bugs.webkit.org/show_bug.cgi?id=22004
+
+ Reviewed by Darin Adler.
+
+ * manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
+ * manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
+
+2008-10-31 Darin Adler <darin@apple.com>
+
+ - fix build
+
+ * platform/win/WCDataObject.cpp: Added missing include of "config.h".
+
+2008-10-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21970
+ Make MessagePort event dispatch work in workers
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
+ (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
+ (WebCore::JSDOMGlobalObject::findJSEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
+ (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
+ (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
+ (WebCore::JSDOMGlobalObject::jsEventListeners):
+ (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
+ (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
+ (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
+ (WebCore::JSDOMGlobalObject::setCurrentEvent):
+ (WebCore::JSDOMGlobalObject::currentEvent):
+ (WebCore::toJSDOMGlobalObject):
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
+ (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
+ (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
+ * bindings/js/JSDOMWindowBase.h:
+ Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
+ (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
+ (WebCore::JSUnprotectedEventListener::globalObject):
+ (WebCore::JSUnprotectedEventListener::clearGlobalObject):
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSEventListener::globalObject):
+ (WebCore::JSEventListener::clearGlobalObject):
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSUnprotectedEventListener::create):
+ (WebCore::JSEventListener::create):
+ (WebCore::JSLazyEventListener::create):
+ Changed to use JSDOMGlobalObject and ScriptExecutionContext.
+
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ (WebCore::JSMessagePort::setOnmessage):
+ (WebCore::JSMessagePort::setOnclose):
+ Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
+ such code, and stop using a custom implementation for JSMessagePort inline event handler
+ getters and setters.
+
+ * dom/Document.cpp:
+ (WebCore::Document::virtualURL):
+ * dom/Document.h:
+ * dom/ScriptExecutionContext.h:
+ Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
+ JSLazyEventListener).
+
+2008-10-31 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Speculative wxWindows build fix.
+
+ * webcore-base.bkl:
+
+2008-10-30 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Jon Homeycutt.
+
+ Explicitly default to building for only the native architecture in debug and release builds.
+
+ * Configurations/DebugRelease.xcconfig:
+
+2008-10-30 Cameron Zwarich <zwarich@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Create a debugger directory in JavaScriptCore and move the relevant
+ files to it.
+
+ * ForwardingHeaders/debugger: Added.
+ * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
+ * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
+ * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
+ * ForwardingHeaders/kjs/debugger.h: Removed.
+ * WebCore.pro:
+ * bindings/js/ScriptController.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptDebugServer.cpp:
+ * inspector/JavaScriptDebugServer.h:
+
+2008-10-30 Tony Chang <tony@chromium.org>
+
+ Fix 2 Windows theme bugs:
+ 1) Checkboxes marked readonly were rendered incorrectly
+ 2) If a button has focus and is pressed, it was rendered
+ as focused rather than pressed.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21859
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::determineState):
+ (WebCore::RenderThemeWin::determineButtonState):
+
+2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
+
+ gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
+ warnings; add some parentheses to disambiguate things. No functional
+ changes, so no tests.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21973
+ Add parentheses to clean up some gcc warnings
+
+ Reviewed by Dan Bernstein.
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::treatAsZeroWidthSpace):
+
+2008-10-30 Aaron Boodman <aa@chromium.org>
+
+ Added an explicit dependency on HashMap.h. It was getting pulled in via
+ <kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.
+
+ Reviewed by Darin Adler.
+
+ * platform/text/PlatformString.h:
+
+2008-10-30 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=21967
+
+ For some platforms the GeolocationService must be suspended and resumed.
+
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners()
+ (WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners
+ (WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners
+ (WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
+ * page/Geolocation.h:
+ (WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
+ * platform/GeolocationService.h:
+ (WebCore::GeolocationService::suspend): empty implementation
+ (WebCore::GeolocationService::resume): empty implementation
+
+2008-10-30 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=21966
+
+ The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
+ http://dev.w3.org/geo/api/spec-source.html
+
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
+ * page/Geoposition.cpp: velocity is now called speed
+ (WebCore::Geoposition::toString):
+ * page/Geoposition.h: velocity is now called speed
+ (WebCore::Geoposition::create):
+ (WebCore::Geoposition::speed):
+ (WebCore::Geoposition::Geoposition):
+ * page/Geoposition.idl: velocity is now called speed
+ * page/PositionOptions.h: timeout is now unsigned
+ (WebCore::PositionOptions::create):
+ (WebCore::PositionOptions::timeout):
+ (WebCore::PositionOptions::setTimeout):
+ (WebCore::PositionOptions::PositionOptions):
+ * page/PositionOptions.idl: timeout is now unsigned long
+
+2008-10-30 Justin Garcia <justin.garcia@apple.com>
+
+ Also handle preserved newlines.
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+
+2008-10-30 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ Don't store the endingSelection() in selection, just call endingSelection() in the few places it's
+ needed. This function is cheap since it just returns a reference to a Selection instead of creating one.
+ Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote),
+ we now use visiblePos (in order to avoid VisiblePosition creation).
+ Set pos after we delete the current selection (if there is one), and be consistent about what we set
+ pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact...
+ ...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is
+ in the first node that we want to move. This fixes the bug, since it lets code that checks for the case
+ where the caret is between text and a br work correctly.
+
+2008-10-30 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Fix the Qt build.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21969
+
+ * inspector/front-end/WebKit.qrc:
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::context):
+ (WebCore::ImageBuffer::image):
+ (WebCore::ImageBuffer::toDataURL):
+
+2008-10-30 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ More preparation for:
+ <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the
+ startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote.
+ This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This
+ doesn't really fix a bug, since we can't really get into a situation where we move to a different
+ topBlockquote, but it simplifies the code.
+
+2008-10-30 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21883
+ [CAIRO] globalAlpha has to be stored and restored
+
+ Cairo's globalAlpha has to be stored and reloaded on calling
+ save() and restore(). We use the power of GraphicsContextState for this.
+
+ * platform/graphics/GraphicsContextPrivate.h:
+ (WebCore::GraphicsContextState::GraphicsContextState):
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::setAlpha):
+ (WebCore::GraphicsContext::getAlpha):
+ * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+ (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
+
+2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Rename "attachedToEventTargetNode" to "isInline".
+
+ Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
+ XMLHttpRequest, MessagePort et al.
+
+ Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
+ attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
+ And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
+ "inlineEventListenerForType", as they work with inline listeners.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::setOnmessage):
+ (WebCore::JSMessagePort::setOnclose):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ Pass a correct value for this argument - callers used to be confused, because they didn't
+ consider themselves event target nodes. This doesn't affect behavior however, as the only
+ difference between inline and non-inline event handlers is that the former treat
+ "return false" as "event.preventDefault()", which is not important to any of these objects.
+
+ * bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
+ Assert that isInline is true instead of checking its value, as the constructor of this class
+ always sets it to true.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
+ (WebCore::JSDOMWindowBase::findJSEventListener):
+ (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
+ (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
+ (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
+ (WebCore::JSDOMWindowBase::jsInlineEventListeners):
+ (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::JSAbstractEventListener::isInline):
+ (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
+ (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSLazyEventListener::parseCode):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSAbstractEventListener::JSAbstractEventListener):
+ (WebCore::JSUnprotectedEventListener::create):
+ (WebCore::JSEventListener::create):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createInlineEventHandler):
+ * bindings/js/ScriptController.h:
+ * dom/Document.cpp:
+ (WebCore::Document::setWindowInlineEventListenerForType):
+ (WebCore::Document::windowInlineEventListenerForType):
+ (WebCore::Document::removeWindowInlineEventListenerForType):
+ (WebCore::Document::createEventListener):
+ (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
+ * dom/Document.h:
+ * dom/EventListener.h:
+ (WebCore::EventListener::isInline):
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::removeInlineEventListenerForType):
+ (WebCore::EventTargetNode::setInlineEventListenerForType):
+ (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute):
+ (WebCore::EventTargetNode::inlineEventListenerForType):
+ (WebCore::EventTargetNode::on*): (many methods)
+ (WebCore::EventTargetNode::setOn*): (many methods)
+ * dom/EventTargetNode.h:
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::parseMappedAttribute):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::parseMappedAttribute):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::parseMappedAttribute):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setInlineEventListenerForType):
+ (WebCore::DOMWindow::inlineEventListenerForType):
+ (WebCore::DOMWindow::on*): (many methods)
+ (WebCore::DOMWindow::setOn*): (many methods)
+ * page/DOMWindow.h:
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::parseMappedAttribute):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::on*): (many methods)
+ (WebCore::SVGElementInstance::setOn*): (many methods)
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+ Rename things, as described above.
+
+2008-10-29 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed and slightly changed by Holger Freyther.
+
+ Added all the files that need to be installed for the Inspector to
+ work.
+
+ * GNUmakefile.am: Invoke the shell to get the files.
+
+2008-10-29 Andrew Scherkus <scherkus@chromium.org>
+
+ Reviewed by Darin Adler
+
+ Add MediaPlayerPrivateChromium to MediaPlayer
+ https://bugs.webkit.org/show_bug.cgi?id=21930
+
+ * platform/graphics/MediaPlayer.cpp:
+
+2008-10-29 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Some preparation for:
+ <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
+
+ Added an early return to avoid a level of if-nesting. No other changes. We probably don't
+ need to rebalance whitespace before the early return but for now don't risk any change in behavior
+ I'll revisit that later.
+
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+
+2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after addition of runtime and ImageBuffer changes.
+
+ * platform/graphics/wx/ImageBufferData.h: Added.
+ * platform/graphics/wx/ImageBufferWx.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::context):
+ * webcore-base.bkl:
+
+2008-10-29 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Adler
+ https://bugs.webkit.org/attachment.cgi?id=24745
+
+ Allow Skia implementations to get text style changed notifications.
+
+ * platform/graphics/GraphicsContext.cpp:
+
+2008-10-29 Timothy Hatcher <timothy@apple.com>
+
+ Add a manual test that checks breakpoints on a blockless body of
+ an "else" statement.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21944
+
+ Reviewed by Maciej Stachowiak.
+
+ * manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
+
+2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21921
+ MessagePort messages are dispatched to documents that are not fully active
+
+ Covered by corrected fast/events/message-port-inactive-document.html
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts
+ that are not fully active.
+
+2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21922
+ Expose MessagePort global constructor
+
+ Covered by existing dumper tests.
+
+ * dom/MessagePort.idl:
+ * page/DOMWindow.idl:
+
+2008-10-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21924
+ HashTable internal index is not always deleted
+
+ * bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
+ Call deleteTable for HashTables that are being deleted.
+
+2008-10-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21923
+ Create an abstraction for script execution context
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Added ScriptExecutionContext.{h,cpp}.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSAudioConstructor.h:
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSImageConstructor.h:
+ * bindings/js/JSOptionConstructor.cpp:
+ (WebCore::JSOptionConstructor::JSOptionConstructor):
+ * bindings/js/JSOptionConstructor.h:
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy.
+ Since these objects can only work within documents now, it is immediately converted back
+ to Document.
+
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
+ (WebCore::JSMessageChannelConstructor::construct):
+ * bindings/js/JSMessageChannelConstructor.h:
+ (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
+ MessageChannel needs to be supported in workers right away, so the constructor operates with
+ it directly.
+
+ * dom/ActiveDOMObject.cpp:
+ (WebCore::ActiveDOMObject::ActiveDOMObject):
+ (WebCore::ActiveDOMObject::~ActiveDOMObject):
+ (WebCore::ActiveDOMObject::contextDestroyed):
+ * dom/ActiveDOMObject.h:
+ (WebCore::ActiveDOMObject::scriptExecutionContext):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::markActiveObjectsForContext):
+ (WebCore::markCrossHeapDependentObjectsForContext):
+ Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort
+ tracking is handled by ScriptExecutionContext.
+
+ * bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
+
+ * bindings/js/JSDOMGlobalObject.h:
+ (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject.
+ Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible
+ to worker context implementation.
+ (WebCore::scriptExecutionContext): Added a pure virtual method to access
+ ScriptExecutionContext, implemented by subclasses.
+
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext):
+ Implement by returning the associated document. Note that this method currently gives bogus
+ results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document
+ that is currently in the frame, not the one associated with this window.
+
+ * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
+
+ * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
+ Call markActiveObjectsForContext() by its new name.
+
+ * dom/DedicatedWorker.cpp:
+ (WebCore::DedicatedWorker::DedicatedWorker):
+ (WebCore::DedicatedWorker::document):
+ * dom/DedicatedWorker.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::document):
+ * xml/XMLHttpRequest.h:
+ Added a document() function that upcasts ScriptExecutionContext, as these objects only work
+ within documents currently (at least for XMLHttpRequest, this will change soon though).
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::~Document):
+ Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code
+ with workers.
+
+ * dom/Document.h:
+ (WebCore::Document::isDocument):
+ (WebCore::Document::refScriptExecutionContext):
+ (WebCore::Document::derefScriptExecutionContext):
+ Inherit from ScriptExecutionContext.
+
+ * dom/MessageChannel.cpp:
+ (WebCore::MessageChannel::MessageChannel):
+ * dom/MessageChannel.h:
+ (WebCore::MessageChannel::create):
+ Use ScriptExecutionContext instead of Document.
+
+ * dom/MessagePort.cpp:
+ (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because
+ MessagePort doesn't ref() itself when posting this event any more (this is a fix for an
+ unrelated issue that was causing random crashes in layout tests).
+ (WebCore::MessagePort::MessagePort):
+ (WebCore::MessagePort::~MessagePort):
+ (WebCore::MessagePort::associatedFrame):
+ (WebCore::MessagePort::clone):
+ (WebCore::MessagePort::postMessage):
+ (WebCore::MessagePort::startConversation):
+ (WebCore::MessagePort::start):
+ (WebCore::MessagePort::contextDestroyed):
+ (WebCore::MessagePort::dispatchMessages):
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::create):
+ (WebCore::MessagePort::scriptExecutionContext):
+ Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort
+ work in worker contexts - we need to also make some its method thread safe for cross-thread
+ messaging, and make event dispatching thread safe.
+
+ * dom/ScriptExecutionContext.cpp: Added.
+ * dom/ScriptExecutionContext.h: Added.
+ ActiveDOMObject and MessagePort tracking is moved from Document.
+ It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow,
+ but as I'm just moving Document code, and it is Document that is the main context object
+ in our implementation currently.
+ Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that
+ seem non-trivial to fix, and isn't really a part of this task.
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ List newly-added ImageBufferData.h in build system.
+
+ * GNUmakefile.am:
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Cameron Zwarich.
+
+ De-list unused WebCore ForwardingHeaders to fix the dist target.
+
+ * GNUmakefile.am:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Attempt to fix the Windows build by generating Forwardingheaders for the
+ runtime directory in JavaScriptCore.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-28 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
+ (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which
+ will probably require a change more complicated than just marking the learned word as
+ misspelled. I'll address it with a separate patch.
+ * editing/EditorCommand.cpp:
+ (WebCore::executeIgnoreSpelling): Added.
+ (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Move ForwardingHeaders to their correct location after the creation of
+ the runtime directory in JavaScriptCore.
+
+ * ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
+ * ForwardingHeaders/kjs/BooleanObject.h: Removed.
+ * ForwardingHeaders/kjs/CallData.h: Removed.
+ * ForwardingHeaders/kjs/ConstructData.h: Removed.
+ * ForwardingHeaders/kjs/DateInstance.h: Removed.
+ * ForwardingHeaders/kjs/Error.h: Removed.
+ * ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
+ * ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
+ * ForwardingHeaders/kjs/InternalFunction.h: Removed.
+ * ForwardingHeaders/kjs/JSArray.h: Removed.
+ * ForwardingHeaders/kjs/JSFunction.h: Removed.
+ * ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
+ * ForwardingHeaders/kjs/JSNumberCell.h: Removed.
+ * ForwardingHeaders/kjs/JSObject.h: Removed.
+ * ForwardingHeaders/kjs/JSString.h: Removed.
+ * ForwardingHeaders/kjs/JSValue.h: Removed.
+ * ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
+ * ForwardingHeaders/kjs/PropertyMap.h: Removed.
+ * ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
+ * ForwardingHeaders/kjs/StringObject.h: Removed.
+ * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
+ * ForwardingHeaders/kjs/StringPrototype.h: Removed.
+ * ForwardingHeaders/kjs/StructureID.h: Removed.
+ * ForwardingHeaders/runtime: Added.
+ * ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
+ * ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
+ * ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
+ * ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
+ * ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
+ * ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
+ * ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
+ * ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
+ * ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
+ * ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
+ * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
+ * ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
+ * ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
+ * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
+ * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
+ * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
+ * ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
+ * ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
+ * ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
+ * ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
+ * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
+ * ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
+ * ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ * bindings/js/JSClipboardCustom.cpp:
+ * bindings/js/JSConsoleCustom.cpp:
+ * bindings/js/JSCustomPositionCallback.h:
+ * bindings/js/JSCustomPositionErrorCallback.h:
+ * bindings/js/JSCustomSQLStatementCallback.h:
+ * bindings/js/JSCustomSQLStatementErrorCallback.h:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h:
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMGlobalObject.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSDatabaseCustom.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventTarget.h:
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ * bindings/js/JSHistoryCustom.cpp:
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ * bindings/js/JSLocationCustom.cpp:
+ * bindings/js/JSNodeFilterCondition.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ * bindings/objc/WebScriptObject.mm:
+ * bindings/objc/WebScriptObjectPrivate.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/c/c_instance.cpp:
+ * bridge/c/c_utility.cpp:
+ * bridge/c/c_utility.h:
+ * bridge/jni/jni_instance.cpp:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/jni/jni_runtime.cpp:
+ * bridge/jni/jni_utility.cpp:
+ * bridge/jni/jni_utility.h:
+ * bridge/objc/objc_instance.mm:
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ * bridge/runtime.h:
+ * bridge/runtime_array.cpp:
+ * bridge/runtime_array.h:
+ * bridge/runtime_method.cpp:
+ * bridge/runtime_method.h:
+ * bridge/runtime_object.cpp:
+ * bridge/runtime_object.h:
+ * bridge/runtime_root.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * inspector/JavaScriptProfile.cpp:
+ * inspector/JavaScriptProfile.h:
+ * inspector/JavaScriptProfileNode.cpp:
+ * inspector/JavaScriptProfileNode.h:
+ * loader/FrameLoader.cpp:
+ * page/Console.cpp:
+ * plugins/PluginView.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ * plugins/qt/PluginViewQt.cpp:
+ * plugins/win/PluginViewWin.cpp:
+
+2008-10-28 Adele Peterson <adele@apple.com>
+
+ Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-28 Adele Peterson <adele@apple.com>
+
+ Windows build fix.
+
+ * platform/graphics/ImageBuffer.h:
+ (WebCore::ImageBuffer::create):
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Roll out a mistaken attempt at fixing the GTK build in r37947.
+
+ * GNUmakefile.am:
+
+2008-10-28 Adele Peterson <adele@apple.com>
+
+ Reviewed by John Sullivan.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
+ "files" string for multifile uploads needs to be localized
+
+ * page/mac/WebCoreViewFactory.h:
+ * platform/LocalizedStrings.h:
+ * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
+ * platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
+ * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
+ * platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
+ * platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
+ * platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
+
+2008-10-28 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21816
+
+ Remove platform ifdefs in ImageBuffer.h by moving platform specific code
+ into a new PlatformImageBuffer class. Move the static create function
+ into the header because it can be cross-platform. Initialization now
+ happens in the cunstructor which sets a flag that create uses to know
+ whether it should return null or not. I also made passing of IntSize
+ more consistent (always by reference).
+
+ This change also changes the ifdefs in GraphicsContext to allow Skia
+ ports to implement text drawing modes.
+
+ * platform/graphics/ImageBuffer.h:
+ (WebCore::ImageBuffer::create):
+ (WebCore::ImageBuffer::size):
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::~ImageBuffer):
+ (WebCore::ImageBuffer::image):
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ * platform/graphics/cairo/ImageBufferData.h:
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::~ImageBuffer):
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ * platform/graphics/cg/ImageBufferData.h:
+ * platform/graphics/qt/ImageBufferData.h:
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBufferData::ImageBufferData):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::~ImageBuffer):
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Fix the GTK build.
+
+ * GNUmakefile.am:
+
+2008-10-28 Cameron Zwarich <zwarich@apple.com>
+
+ Not reviewed.
+
+ Another Qt build fix.
+
+ * WebCore.pro:
+
+2008-10-28 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21932
+ Add non-pointer constant lookups to SoftLinking.h
+
+ * platform/mac/SoftLinking.h:
+
+2008-10-28 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=2192
+ Missing semi-colons in Geoposition.idl
+
+ * page/Geoposition.idl: Add missing semi-colons
+
+2008-10-28 Timothy Hatcher <timothy@apple.com>
+
+ Make the Profiles panel in the Web Inspector have an enable screen.
+ Profiling now needs to be enabled before console.profile() works.
+
+ <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
+ not slow down JavaScript all the time
+
+ Reviewed by Darin Adler and Kevin McCullough.
+
+ * English.lproj/localizedStrings.js: New strings.
+ * WebCore.base.exp: New and changed exports.
+ * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
+ Timer to call InspectorController::startUserInitiatedProfiling.
+ (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
+ that calls InspectorController::startUserInitiatedProfiling.
+ (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
+ and enable the profiler if the profiler was not enabled.
+ (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
+ (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
+ if the skipRecompile argument is false. Call the profilerWasEnabled script function.
+ (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
+ Call the profilerWasEnabled script function.
+ (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
+ so it won't be started later.
+ * inspector/InspectorController.h:
+ (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
+ * inspector/front-end/Images/debuggingButtons.png: Remove.
+ * inspector/front-end/Images/enableButtons.png: Added.
+ * inspector/front-end/Images/profilesSilhouette.png: Added.
+ * inspector/front-end/Images/scriptsSilhouette.png: Added.
+ * inspector/front-end/PanelEnablerView.js: Added.
+ (WebInspector.PanelEnablerView):
+ (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
+ event so listeners can do their thing.
+ (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
+ (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
+ (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
+ (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
+ (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
+ (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
+ (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
+ show/hide other buttons. Also show/hide the PanelEnablerView.
+ (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
+ (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
+ disableProfiler or enableProfiler.
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
+ debuggingButton with the enableToggleButton.
+ (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
+ the enableToggleButton.
+ (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
+ when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
+ with the enableToggleButton.
+ (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
+ (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
+ since reset is called from debuggerWasEnabled and debuggerWasDisabled.
+ * inspector/front-end/View.js: Inherit from WebInspector.Object.
+ * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
+ * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
+ * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
+ * inspector/front-end/inspector.js:
+ (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
+ (WebInspector.profilerWasDisabled): Ditto.
+ * page/Console.cpp:
+ (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
+ (WebCore::Console::info): Ditto.
+ (WebCore::Console::log): Ditto.
+ (WebCore::Console::assertCondition): Ditto.
+ (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
+ (WebCore::Console::count): Ditto.
+ (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
+ (WebCore::Console::profileEnd): Ditto.
+ (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
+ (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
+ Now just sets the member boolean.
+ * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
+
+2008-10-28 Timothy Hatcher <timothy@apple.com>
+
+ Rename a few methods related to attaching and detaching the debugger. Also
+ adds stub methods for enabling and disabling the profiler.
+
+ * Rename attachDebugger to enableDebugger.
+ * Rename detachDebugger to disableDebugger.
+ * Rename the debuggerAttached getter to debuggerEnabled.
+ * Rename the debuggerAttached callback to debuggerWasEnabled.
+ * Rename the debuggerDetached callback to debuggerWasDisabled.
+
+ Reviewed by Darin Adler.
+
+ * WebCore.base.exp:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ (WebCore::InspectorController::close):
+ (WebCore::InspectorController::enableProfiler):
+ (WebCore::InspectorController::disableProfiler):
+ (WebCore::InspectorController::enableDebugger):
+ (WebCore::InspectorController::disableDebugger):
+ (WebCore::InspectorController::pauseInDebugger):
+ (WebCore::InspectorController::resumeDebugger):
+ (WebCore::InspectorController::stepOverStatementInDebugger):
+ (WebCore::InspectorController::stepIntoStatementInDebugger):
+ (WebCore::InspectorController::stepOutOfFunctionInDebugger):
+ * inspector/InspectorController.h:
+ (WebCore::InspectorController::profilerEnabled):
+ (WebCore::InspectorController::debuggerEnabled):
+ * inspector/front-end/BreakpointsSidebarPane.js:
+ (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
+ (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
+ (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
+ * inspector/front-end/Object.js:
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel):
+ (WebInspector.ScriptsPanel.prototype.get statusBarItems):
+ (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
+ (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
+ (WebInspector.ScriptsPanel.prototype.reset):
+ (WebInspector.ScriptsPanel.prototype.canShowResource):
+ (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
+ (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
+ (WebInspector.ScriptsPanel.prototype._toggleDebugging):
+ * inspector/front-end/View.js:
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/inspector.html:
+ * inspector/front-end/inspector.js:
+ (WebInspector.addResource):
+ (WebInspector.debuggerWasEnabled):
+ (WebInspector.debuggerWasDisabled):
+
+2008-10-28 Timothy Hatcher <timothy@apple.com>
+
+ Fix an exception when searching the Resources panel while there
+ and resources queued to be added to the list.
+
+ Reviewed by Kevin McCullough.
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check
+ the _resourcesTreeElement property.
+ (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
+ isn't defined.
+
+ * platform/graphics/gtk/FontGtk.cpp:
+ (WebCore::getDefaultPangoLayout):
+ * platform/graphics/gtk/FontPlatformDataPango.cpp:
+
+2008-10-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21893
+ Character set is incorrect for external scripts in XHTML pages
+
+ <rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/
+
+ Test: fast/encoding/external-script-charset.xhtml
+
+ Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.
+
+ * dom/ScriptElement.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::XMLTokenizer::endElementNs):
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::parseEndElement):
+ * html/HTMLScriptElement.h:
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::scriptCharset):
+ * svg/SVGScriptElement.h:
+
+2008-10-28 Alp Toker <alp@nuanti.com>
+
+ Include copyright license files in the autotools dist target and
+ exclude unused zlib headers.
+
+ Change suggested by Mike Hommey.
+
+ * GNUmakefile.am:
+
+2008-10-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Clear the window shell when destroying a page to allow documents
+ which have no way of being reached anymore, to be torn down.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::pageDestroyed):
+
+2008-10-27 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Update the active state as well as the focused state as both need to be true
+ for the caret to be drawn.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21900
+
+ * WebView.cpp:
+ (wxWebView::OnSetFocus):
+ (wxWebView::OnKillFocus):
+
+2008-10-27 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
+
+ * webcore-wx.bkl:
+
+2008-10-27 Michael Knaup <michael.knaup@mac.com>
+
+ Reviewed and tweaked by Darin Adler.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=8988
+
+ Bug 8988: Add support for Mozilla CSS custom cursors.
+ Added -webkit-grab and -webkit-grabbing cursor suppport
+ for the Mac, dummy implementations for other platforms.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Updated since the
+ -webkit-grabbing cursor is now the last one.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added
+ CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
+
+ * css/CSSValueKeywords.in: Added -webkit-grab and
+ -webkit-grabbing.
+
+ * manual-tests/cursor.html: Added -webkit-zoom-in,
+ webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::selectCursor): Added
+ CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
+
+ * platform/Cursor.h: Added grabCursor and grabbingCursor.
+
+ * platform/gtk/CursorGtk.cpp:
+ (WebCore::grabCursor): Added.
+ (WebCore::grabbingCursor): Added.
+ * platform/mac/CursorMac.mm:
+ (WebCore::grabCursor): Added.
+ (WebCore::grabbingCursor): Added.
+ * platform/qt/CursorQt.cpp:
+ (WebCore::grabCursor): Added.
+ (WebCore::grabbingCursor): Added.
+ * platform/win/CursorWin.cpp:
+ (WebCore::grabCursor): Added.
+ (WebCore::grabbingCursor): Added.
+ * platform/wx/CursorWx.cpp:
+ (WebCore::grabCursor): Added.
+ (WebCore::grabbingCursor): Added.
+
+ * rendering/style/RenderStyleConstants.h:
+ Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
+ Also broke ECursor out into a single constant per line.
+ Also added a couple of comments.
+
+2008-10-27 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ * svg/SVGAnimatedTemplate.h: needed a HashMap define
+
+2008-10-21 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Dave Hyatt.
+
+ Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
+ https://bugs.webkit.org/show_bug.cgi?id=20400
+
+ Test: svg/custom/stop-crash.svg
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderSVGGradientStop.h:
+ (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
+
+2008-10-27 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ No need to call release if the connection is null.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start):
+
+2008-10-27 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin Decker.
+
+ <rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html
+
+ Make sure to null check the NSURLConnection object.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::setDefersLoading):
+
+2008-10-27 Alexey Proskuryakov <ap@webkit.org>
+
+ Fix non-Mac builds.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+ Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
+
+2008-10-26 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21886
+ window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor
+
+ Test: fast/dom/HTMLOptionElement/option-prototype.html
+
+ We now have separate objects for window.Option and window.HTMLOptionElement - the latter
+ "constructor" cannot be used to construct anything. This matches Firefox behavior.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseOption):
+ * bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
+ * bindings/js/JSHTMLOptionElementConstructor.h: Removed.
+ * bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
+ * bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
+ * html/HTMLOptionElement.idl:
+ Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
+
+ * html/HTMLOptionElement.idl: Generate a constructor.
+
+2008-10-25 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Mac debug build on the buildbot.
+
+ * platform/FileChooser.cpp:
+ (WebCore::FileChooserClient::~FileChooserClient):
+ * platform/FileChooser.h: Moved destructor to .cpp file, to avoid a
+ weak exported symbol.
+
+2008-10-25 Jade Han <jade.han@nokia.com>
+
+ Reviewed by Anders.
+
+ Enable custom properties for Qt runtime objects in QtWebKit
+
+ https://bugs.webkit.org/show_bug.cgi?id=21813
+
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::getOwnPropertySlot):
+ (JSC::RuntimeObjectImp::put):
+
+2008-10-24 Sam Weinig <sam@webkit.org>
+
+ Fix windows build.
+
+ * page/Chrome.cpp:
+ * page/Chrome.h:
+
+2008-10-24 Sam Weinig <sam@webkit.org>
+
+ Fix Qt build.
+
+ * platform/qt/FileChooserQt.cpp:
+
+2008-10-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=21759
+ Layering violation: FileChooser should not depend on Document/Frame/Page
+
+ Move file choosing into WebKit ChromeClient.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::runOpenPanel):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::runOpenPanel):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/mac/ChromeMac.mm:
+ * platform/FileChooser.h:
+ * platform/mac/FileChooserMac.mm:
+ * platform/qt/FileChooserQt.cpp:
+ * platform/win/FileChooserWin.cpp:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::click):
+
+2008-10-24 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix - add newIconForFiles stub.
+
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (Icon::newIconForFiles):
+
+2008-10-24 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ Use the CGFont metrics APIs for more accurate measurements, and tweak the y
+ value the text is drawn at (it was a couple pixels off before because wx
+ internally adds to the y value.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21853
+
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (wxFontProperties::wxFontProperties):
+ * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
+ (WebCore::drawTextWithSpacing):
+
+2008-10-24 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Generate missing constructors and add test to prevent missing ones in the future
+ https://bugs.webkit.org/show_bug.cgi?id=21846
+
+ Test: fast/js/global-constructors.html
+
+ * css/CSSStyleSheet.idl:
+ * css/RGBColor.idl:
+ * dom/NodeIterator.idl:
+ * dom/TreeWalker.idl:
+ * xml/XPathExpression.idl:
+
+2008-10-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21836
+ REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
+
+ Test: http/tests/xmlhttprequest/detaching-frame.html
+
+ * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window -
+ even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected
+ when dispatching the same callback that results in this function being called.
+
+2008-10-24 David Kilzer <ddkilzer@apple.com>
+
+ Gtk build fix.
+
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
+
+2008-10-24 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::imageInterpolationQuality):
+
+2008-10-24 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/5440917> Support NPN_Construct
+
+ * WebCore.NPAPI.exp:
+ Export _NPN_Construct.
+
+ * bridge/NP_jsobject.cpp:
+ (_NPN_Construct):
+ Implement this.
+
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::supportsConstruct):
+ (JSC::Bindings::CInstance::invokeConstruct):
+ Have this call the appropriate NPClass method.
+
+ * bridge/npruntime.h:
+ Add NPN_Construct.
+
+ * bridge/npruntime_impl.h:
+ Add _NPN_Construct.
+
+ * bridge/runtime.h:
+ (JSC::Bindings::Instance::supportsConstruct):
+ (JSC::Bindings::Instance::invokeConstruct):
+ New methods.
+
+ * bridge/runtime_object.cpp:
+ (JSC::callRuntimeConstructor):
+ Call the native instance.
+
+ (JSC::RuntimeObjectImp::getConstructData):
+ Implement this.
+
+ * bridge/runtime_object.h:
+ Add new method declarations.
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::load):
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::load):
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::load):
+ Initialize m_pluginFuncs.construct.
+
+2008-10-24 Adele Peterson <adele@apple.com>
+
+ Build fix.
+
+ * platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
+ * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):
+
+2008-10-24 Greg Bolsinga <bolsinga@apple.com>
+
+ Fix GTK build break.
+
+ Reviewed by David Kilzer.
+
+ * GNUmakefile.am: Do not include .idl files whose generated files should not be
+ compiled.
+
+2008-10-24 David Kilzer <ddkilzer@apple.com>
+
+ Wx build fix.
+
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
+
+2008-10-24 Adele Peterson <adele@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
+
+ This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
+ This is consistent with the direction HTML5 will be going in the future.
+
+ The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
+ the individual files in a tooltip for now. Improvements to this control will come later.
+
+ Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
+ These FileList Files can also be sent in an XMLHTTPRequest.
+
+ * manual-tests/post-multi-file-upload.html: Added.
+ * manual-tests/resources/multiFileResources: Added.
+ * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
+ * manual-tests/resources/multiFileResources/testFile1.html: Added.
+ * manual-tests/resources/multiFileResources/testFile2.html: Added.
+ * manual-tests/resources/multiFileResources/testFile3.html: Added.
+
+ * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
+ (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control,
+ but we don't want to break the behavior for existing websites that may rely on this.
+ (WebCore::HTMLInputElement::setValue): ditto.
+ (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
+ (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
+ * html/HTMLInputElement.h:
+
+ * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
+
+ * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
+
+ * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
+ (WebCore::FileChooser::FileChooser):
+ (WebCore::FileChooser::create):
+ (WebCore::FileChooser::clear):
+ (WebCore::FileChooser::chooseFile):
+ (WebCore::FileChooser::chooseFiles):
+ (WebCore::FileChooser::chooseIcon):
+ * platform/FileChooser.h:
+ (WebCore::FileChooser::filePaths):
+ (WebCore::FileChooser::allowsMultipleFiles):
+
+ * platform/graphics/Icon.h:
+ * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
+ * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
+ * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
+ * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
+
+ * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
+ * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
+ * platform/qt/FileChooserQt.cpp:
+ (WebCore::FileChooser::openFileChooser):
+ (WebCore::FileChooser::basenameForWidth):
+ * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
+
+ * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
+ Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel
+ both get called for the same ResourceHandle. This getting called twice has no negative effect.
+
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer.
+ (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added.
+ (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser.
+ (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
+ * rendering/RenderFileUploadControl.h:
+
+2008-10-23 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21844
+ Remove setFocusRingColorChangeFunction.
+
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ * platform/graphics/Color.h:
+ * platform/graphics/mac/ColorMac.mm:
+ (WebCore::focusRingColor):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * platform/graphics/win/ColorSafari.cpp:
+
+2008-10-24 David Kilzer <ddkilzer@apple.com>
+
+ Build fix for Qt.
+
+ Reviewed by Greg.
+
+ * WebCore.pro: Added missing *.idl files.
+
+2008-10-24 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21475
+
+ Provide support for the Geolocation API
+
+ http://dev.w3.org/geo/api/spec-source.html
+
+ Test: geolocation/geolocation-not-implemented.html
+
+ * DerivedSources.make:
+ * GNUmakefile.am: Added Geolocation support
+ * WebCore.pro: Added Geolocation support
+ * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
+ * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
+ * WebCoreSources.bkl: Added Geolocation support
+ * bindings/js/JSCustomPositionCallback.cpp: Added.
+ (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionCallback.h: Added.
+ (WebCore::JSCustomPositionCallback::create):
+ * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
+ (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.h: Added.
+ (WebCore::JSCustomPositionErrorCallback::create):
+ * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
+ (WebCore::markDOMObjectWrapper):
+ * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
+ * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
+ * bindings/js/JSGeolocationCustom.cpp: Added.
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
+ (WebCore::JSNavigator::mark):
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::setUsingGeolocation):
+ (WebCore::Document::usingGeolocation):
+ * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
+ (WebCore::FrameLoader::canCachePage):
+ * page/Geolocation.cpp: Added.
+ (WebCore::Geolocation::GeoNotifier::GeoNotifier):
+ (WebCore::Geolocation::GeoNotifier::timerFired):
+ (WebCore::Geolocation::Geolocation):
+ (WebCore::Geolocation::disconnectFrame):
+ (WebCore::Geolocation::getCurrentPosition):
+ (WebCore::Geolocation::watchPosition):
+ (WebCore::Geolocation::clearWatch):
+ (WebCore::Geolocation::stopUpdatingIfEmpty):
+ (WebCore::Geolocation::sendErrorToOneShots):
+ (WebCore::Geolocation::sendErrorToWatchers):
+ (WebCore::Geolocation::sendPositionToOneShots):
+ (WebCore::Geolocation::sendPositionToWatchers):
+ (WebCore::Geolocation::handleError):
+ (WebCore::Geolocation::geolocationServicePositionChanged):
+ (WebCore::Geolocation::geolocationServiceErrorOccurred):
+ * page/Geolocation.h: Added.
+ (WebCore::Geolocation::create):
+ (WebCore::Geolocation::~Geolocation):
+ (WebCore::Geolocation::lastPosition):
+ (WebCore::Geolocation::GeoNotifier::create):
+ * page/Geolocation.idl: Added.
+ * page/Geoposition.cpp: Added.
+ (WebCore::Geoposition::toString):
+ * page/Geoposition.h: Added.
+ (WebCore::Geoposition::create):
+ (WebCore::Geoposition::latitude):
+ (WebCore::Geoposition::longitude):
+ (WebCore::Geoposition::altitude):
+ (WebCore::Geoposition::accuracy):
+ (WebCore::Geoposition::altitudeAccuracy):
+ (WebCore::Geoposition::heading):
+ (WebCore::Geoposition::velocity):
+ (WebCore::Geoposition::timestamp):
+ (WebCore::Geoposition::Geoposition):
+ * page/Geoposition.idl: Added.
+ * page/Navigator.cpp:
+ (WebCore::Navigator::disconnectFrame): disconnect Geolocation
+ (WebCore::Navigator::geolocation): accessor for Geolocation
+ * page/Navigator.h:
+ (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
+ * page/Navigator.idl: accessor for Geolocation
+ * page/PositionCallback.h: Added.
+ (WebCore::PositionCallback::~PositionCallback):
+ * page/PositionCallback.idl: Added.
+ * page/PositionError.h: Added.
+ (WebCore::PositionError::):
+ (WebCore::PositionError::create):
+ (WebCore::PositionError::code):
+ (WebCore::PositionError::message):
+ (WebCore::PositionError::PositionError):
+ * page/PositionError.idl: Added.
+ * page/PositionErrorCallback.h: Added.
+ (WebCore::PositionErrorCallback::~PositionErrorCallback):
+ * page/PositionErrorCallback.idl: Added.
+ * page/PositionOptions.h: Added.
+ (WebCore::PositionOptions::create):
+ (WebCore::PositionOptions::enableHighAccuracy):
+ (WebCore::PositionOptions::setEnableHighAccuracy):
+ (WebCore::PositionOptions::timeout):
+ (WebCore::PositionOptions::setTimeout):
+ (WebCore::PositionOptions::PositionOptions):
+ * page/PositionOptions.idl: Added.
+ * platform/GeolocationService.cpp: Added.
+ (WebCore::GeolocationService::GeolocationService):
+ (WebCore::GeolocationService::positionChanged):
+ (WebCore::GeolocationService::errorOccurred):
+ * platform/GeolocationService.h: Added.
+ (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
+ (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
+ (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
+ (WebCore::GeolocationService::~GeolocationService):
+
+2008-10-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=21818
+
+ Add HashTraits for AtomicString so that AtomicString can be used as
+ the key for a HashMap or HashSet.
+
+ * GNUmakefile.am: add AtomicStringHash.h
+ * WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
+ * WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
+ * platform/text/AtomicString.h:
+ (WebCore::AtomicString::AtomicString):
+ (WebCore::AtomicString::isHashTableDeletedValue):
+ specialize DefaultHash for AtomicString to use AtomicStringHash
+ * platform/text/AtomicStringHash.h: Added.
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::StringImpl):
+ compute the hash up-front for the empty string
+ * platform/text/StringImpl.h:
+ (WebCore::StringImpl::existingHash):
+ method to get the hash without a test and branch, for callers like
+ AtomicStringHash who can guarantee that the hash has already been computed.
+
+2008-10-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=21857
+
+ Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
+ switch in _wrapCSSRule.
+
+ * bindings/objc/DOMCSS.mm:
+ (+[DOMCSSRule _wrapCSSRule:WebCore::]):
+
+2008-10-24 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * plugins/PluginView.cpp:
+
+2008-10-24 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21851
+ <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height
+
+ Test: fast/replaced/percent-height-in-anonymous-block-widget.html
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::destroy): Copied code added to
+ RenderBox::destroy() in r36513 into this function.
+
+2008-10-24 Timothy Hatcher <timothy@apple.com>
+
+ Add a mechanism to ask the InspectorClient for key/value setting pairs.
+ These settings can be strings, numbers, booleans or string vectors. The
+ settings are also bridged to and from JavaScript.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21856
+
+ Reviewed by Darin Adler.
+
+ * WebCore.base.exp: Expose the String CFStringRef constructor.
+ * inspector/InspectorClient.h:
+ (WebCore::InspectorClient::populateSetting): Added, pure virtual.
+ (WebCore::InspectorClient::storeSetting): Ditto.
+ (WebCore::InspectorClient::removeSetting): Ditto.
+ * inspector/InspectorController.cpp:
+ (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
+ (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
+ (WebCore::InspectorController::InspectorController): Increment a global static
+ to track the number of live InspectorControllers.
+ (WebCore::InspectorController::~InspectorController): Decrement the global static
+ that tracks the number of live InspectorControllers. Delete the setting cache if there
+ are no more live controllers.
+ (WebCore::InspectorController::setting): Check the cache and return the setting from there,
+ otherwise make a new Setting and ask the client to populate it.
+ (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
+ (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
+ to the InspectorController script class.
+ * inspector/InspectorController.h:
+ (WebCore::InspectorController::Setting::Setting):
+ (WebCore::InspectorController::Setting::operator=):
+ (WebCore::InspectorController::Setting::type): Return m_type.
+ (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
+ (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
+ Assert the type is correct.
+ (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
+ Assert the type is correct.
+ (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
+ Assert the type is correct.
+ (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
+ Assert the type is correct.
+ (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
+ field and the type.
+ * loader/EmptyClients.h:
+ (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
+ (WebCore::EmptyInspectorClient::storeSetting): Ditto.
+ (WebCore::EmptyInspectorClient::removeSetting): Ditto.
+
+2008-10-24 Cameron Zwarich <zwarich@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove some C-style casts.
+
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::addViewSourceToken):
+
+2008-10-24 Darin Adler <darin@apple.com>
+
+ - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
+
+ * bindings/js/JSAttrCustom.cpp:
+ * bindings/js/JSCSSRuleCustom.cpp:
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ * bindings/js/JSCSSValueCustom.cpp:
+ * bindings/js/JSCanvasPixelArrayCustom.h:
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ * bindings/js/JSClipboardCustom.cpp:
+ * bindings/js/JSConsoleCustom.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * bindings/js/JSDOMWindowCustom.h:
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSDOMWindowShell.h:
+ * bindings/js/JSDatabaseCustom.cpp:
+ * bindings/js/JSDedicatedWorkerCustom.cpp:
+ * bindings/js/JSDocumentCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/js/JSEventCustom.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventTarget.cpp:
+ * bindings/js/JSEventTarget.h:
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ * bindings/js/JSHTMLAllCollection.h:
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ * bindings/js/JSHTMLSelectElementCustom.h:
+ * bindings/js/JSHistoryCustom.cpp:
+ * bindings/js/JSImageDataCustom.cpp:
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ * bindings/js/JSInspectedObjectWrapper.h:
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ * bindings/js/JSLocationCustom.cpp:
+ * bindings/js/JSMessagePortCustom.cpp:
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ * bindings/js/JSNamedNodesCollection.cpp:
+ * bindings/js/JSNamedNodesCollection.h:
+ * bindings/js/JSNavigatorCustom.cpp:
+ * bindings/js/JSNodeCustom.cpp:
+ * bindings/js/JSNodeFilterCondition.cpp:
+ * bindings/js/JSNodeFilterCondition.h:
+ * bindings/js/JSNodeFilterCustom.cpp:
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ * bindings/js/JSNodeListCustom.cpp:
+ * bindings/js/JSPluginArrayCustom.cpp:
+ * bindings/js/JSPluginCustom.cpp:
+ * bindings/js/JSPluginElementFunctions.cpp:
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ * bindings/js/JSRGBColor.cpp:
+ * bindings/js/JSRGBColor.h:
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ * bindings/js/JSSVGLengthCustom.cpp:
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ * bindings/js/JSSVGPointListCustom.cpp:
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ * bindings/js/JSStorageCustom.cpp:
+ * bindings/js/JSStyleSheetCustom.cpp:
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ * bindings/js/JSTextCustom.cpp:
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ * bindings/js/ScheduledAction.cpp:
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptController.h:
+ * bindings/objc/WebScriptObject.mm:
+ * bindings/objc/WebScriptObjectPrivate.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/c/c_instance.cpp:
+ * bridge/c/c_instance.h:
+ * bridge/c/c_runtime.cpp:
+ * bridge/c/c_runtime.h:
+ * bridge/c/c_utility.cpp:
+ * bridge/c/c_utility.h:
+ * bridge/jni/jni_instance.cpp:
+ * bridge/jni/jni_instance.h:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/jni/jni_objc.mm:
+ * bridge/jni/jni_runtime.cpp:
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ * bridge/jni/jni_utility.h:
+ * bridge/objc/WebScriptObject.h:
+ * bridge/objc/objc_class.h:
+ * bridge/objc/objc_class.mm:
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ * bridge/qt/qt_class.cpp:
+ * bridge/qt/qt_class.h:
+ * bridge/qt/qt_instance.cpp:
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ * bridge/qt/qt_runtime.h:
+ * bridge/runtime.cpp:
+ * bridge/runtime.h:
+ * bridge/runtime_array.cpp:
+ * bridge/runtime_array.h:
+ * bridge/runtime_method.cpp:
+ * bridge/runtime_method.h:
+ * bridge/runtime_object.cpp:
+ * bridge/runtime_object.h:
+ * bridge/testqtbindings.cpp:
+ * inspector/JavaScriptCallFrame.cpp:
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptProfile.cpp:
+ * inspector/JavaScriptProfile.h:
+ * inspector/JavaScriptProfileNode.cpp:
+ * inspector/JavaScriptProfileNode.h:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+ * page/Console.cpp:
+ * page/Console.h:
+ * plugins/MimeTypeArray.h:
+ * plugins/Plugin.h:
+ * plugins/PluginArray.h:
+ * plugins/PluginView.cpp:
+ * xml/XMLHttpRequest.cpp:
+ Use JSValue* instead of JSValuePtr.
+
+2008-10-24 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtField::valueFromInstance):
+
+2008-10-24 David Kilzer <ddkilzer@apple.com>
+
+ Rolled out r37840 and r37841.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSCustomPositionCallback.cpp: Removed.
+ * bindings/js/JSCustomPositionCallback.h: Removed.
+ * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
+ * bindings/js/JSCustomPositionErrorCallback.h: Removed.
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::markDOMObjectWrapper):
+ * bindings/js/JSGeolocationCustom.cpp: Removed.
+ * bindings/js/JSNavigatorCustom.cpp:
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::canCachePage):
+ * page/Geolocation.cpp: Removed.
+ * page/Geolocation.h: Removed.
+ * page/Geolocation.idl: Removed.
+ * page/Geoposition.cpp: Removed.
+ * page/Geoposition.h: Removed.
+ * page/Geoposition.idl: Removed.
+ * page/Navigator.cpp:
+ (WebCore::Navigator::disconnectFrame):
+ * page/Navigator.h:
+ * page/Navigator.idl:
+ * page/PositionCallback.h: Removed.
+ * page/PositionCallback.idl: Removed.
+ * page/PositionError.h: Removed.
+ * page/PositionError.idl: Removed.
+ * page/PositionErrorCallback.h: Removed.
+ * page/PositionErrorCallback.idl: Removed.
+ * page/PositionOptions.h: Removed.
+ * page/PositionOptions.idl: Removed.
+ * platform/GeolocationService.cpp: Removed.
+ * platform/GeolocationService.h: Removed.
+
+2008-10-23 David Kilzer <ddkilzer@apple.com>
+
+ Attempt to fix GTK build.
+
+ * GNUmakefile.am: Added new *.idl files that were missing.
+
+2008-10-23 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21475
+
+ Provide support for the Geolocation API
+
+ http://dev.w3.org/geo/api/spec-source.html
+
+ Test: geolocation/geolocation-not-implemented.html
+
+ * DerivedSources.make:
+ * GNUmakefile.am: Added Geolocation support
+ * WebCore.pro: Added Geolocation support
+ * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
+ * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
+ * WebCoreSources.bkl: Added Geolocation support
+ * bindings/js/JSCustomPositionCallback.cpp: Added.
+ (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
+ (WebCore::JSCustomPositionCallback::handleEvent):
+ * bindings/js/JSCustomPositionCallback.h: Added.
+ (WebCore::JSCustomPositionCallback::create):
+ * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
+ (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
+ (WebCore::JSCustomPositionErrorCallback::handleEvent):
+ * bindings/js/JSCustomPositionErrorCallback.h: Added.
+ (WebCore::JSCustomPositionErrorCallback::create):
+ * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
+ (WebCore::markDOMObjectWrapper):
+ * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
+ * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
+ * bindings/js/JSGeolocationCustom.cpp: Added.
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
+ (WebCore::JSNavigator::mark):
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ * dom/Document.h:
+ (WebCore::Document::setUsingGeolocation):
+ (WebCore::Document::usingGeolocation):
+ * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
+ (WebCore::FrameLoader::canCachePage):
+ * page/Geolocation.cpp: Added.
+ (WebCore::Geolocation::GeoNotifier::GeoNotifier):
+ (WebCore::Geolocation::GeoNotifier::timerFired):
+ (WebCore::Geolocation::Geolocation):
+ (WebCore::Geolocation::disconnectFrame):
+ (WebCore::Geolocation::getCurrentPosition):
+ (WebCore::Geolocation::watchPosition):
+ (WebCore::Geolocation::clearWatch):
+ (WebCore::Geolocation::stopUpdatingIfEmpty):
+ (WebCore::Geolocation::sendErrorToOneShots):
+ (WebCore::Geolocation::sendErrorToWatchers):
+ (WebCore::Geolocation::sendPositionToOneShots):
+ (WebCore::Geolocation::sendPositionToWatchers):
+ (WebCore::Geolocation::handleError):
+ (WebCore::Geolocation::geolocationServicePositionChanged):
+ (WebCore::Geolocation::geolocationServiceErrorOccurred):
+ * page/Geolocation.h: Added.
+ (WebCore::Geolocation::create):
+ (WebCore::Geolocation::~Geolocation):
+ (WebCore::Geolocation::lastPosition):
+ (WebCore::Geolocation::GeoNotifier::create):
+ * page/Geolocation.idl: Added.
+ * page/Geoposition.cpp: Added.
+ (WebCore::Geoposition::toString):
+ * page/Geoposition.h: Added.
+ (WebCore::Geoposition::create):
+ (WebCore::Geoposition::latitude):
+ (WebCore::Geoposition::longitude):
+ (WebCore::Geoposition::altitude):
+ (WebCore::Geoposition::accuracy):
+ (WebCore::Geoposition::altitudeAccuracy):
+ (WebCore::Geoposition::heading):
+ (WebCore::Geoposition::velocity):
+ (WebCore::Geoposition::timestamp):
+ (WebCore::Geoposition::Geoposition):
+ * page/Geoposition.idl: Added.
+ * page/Navigator.cpp:
+ (WebCore::Navigator::disconnectFrame): disconnect Geolocation
+ (WebCore::Navigator::geolocation): accessor for Geolocation
+ * page/Navigator.h:
+ (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
+ * page/Navigator.idl: accessor for Geolocation
+ * page/PositionCallback.h: Added.
+ (WebCore::PositionCallback::~PositionCallback):
+ * page/PositionCallback.idl: Added.
+ * page/PositionError.h: Added.
+ (WebCore::PositionError::):
+ (WebCore::PositionError::create):
+ (WebCore::PositionError::code):
+ (WebCore::PositionError::message):
+ (WebCore::PositionError::PositionError):
+ * page/PositionError.idl: Added.
+ * page/PositionErrorCallback.h: Added.
+ (WebCore::PositionErrorCallback::~PositionErrorCallback):
+ * page/PositionErrorCallback.idl: Added.
+ * page/PositionOptions.h: Added.
+ (WebCore::PositionOptions::create):
+ (WebCore::PositionOptions::enableHighAccuracy):
+ (WebCore::PositionOptions::setEnableHighAccuracy):
+ (WebCore::PositionOptions::timeout):
+ (WebCore::PositionOptions::setTimeout):
+ (WebCore::PositionOptions::PositionOptions):
+ * page/PositionOptions.idl: Added.
+ * platform/GeolocationService.cpp: Added.
+ (WebCore::GeolocationService::GeolocationService):
+ (WebCore::GeolocationService::positionChanged):
+ (WebCore::GeolocationService::errorOccurred):
+ * platform/GeolocationService.h: Added.
+ (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
+ (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
+ (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
+ (WebCore::GeolocationService::~GeolocationService):
+
+2008-10-23 Alp Toker <alp@nuanti.com>
+
+ Fix typo in comment in previous commit. GTK -> GLIB
+
+ * platform/gtk/guriescape.c:
+
+2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21824
+ [GTK] FileSystem abstraction uses features from Glib 2.16
+
+ Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib
+
+ * platform/gtk/guriescape.c:
+ (unescape_character):
+ (_webcore_g_uri_unescape_segment):
+ (_webcore_g_uri_unescape_string):
+ * platform/gtk/guriescape.h:
+
+2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.
+
+ * GNUmakefile.am:
+
+2008-10-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ m_frame null checked but then dereferenced
+ https://bugs.webkit.org/show_bug.cgi?id=21845
+
+ This error was found using a static analysis tool, and so I do not know
+ how to produce a null m_frame on entry to this method. Hence, I have
+ not included a regression test.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::allowDHTMLDrag): Add an early return.
+
+2008-10-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig with no hesitation.
+
+ - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
+ <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
+
+ Test: fast/text/bidi-embedding-pop-and-push-same.html
+
+ * platform/text/BidiResolver.h:
+ (WebCore::BidiResolver::embed): Changed to only add the embedding
+ operation to a vector of pending operations.
+
+ (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
+ code that used to be in the PDF case of embed() here, except the part
+ that sets the context.
+
+ (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
+ code that used to be in the non-PDF case of embed() here, except the
+ part the sets the context.
+
+ (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
+ explicit embedding operations in the vector by creating an updated
+ context and determining the old and new embedding levels. If the levels
+ are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
+ sets the context to the new one.
+
+ (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
+ commitExplicitEmbedding() after calling embed() and after calling
+ increment().
+
+ * rendering/bidi.cpp:
+ (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
+ this function increments the resolver.
+
+ (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
+
+2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix. Not reviewed.
+
+ Add DNSCurl and DNSSoup to the Gtk build
+
+ * GNUmakefile.am:
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
+ (WebCore::prefetchDNS):
+
+2008-10-23 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Un-break the Darwin build.
+
+ * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
+ * platform/graphics/cg/ImageCG.cpp:
+
+2008-10-23 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix forward decls to be struct instead of class.
+ https://bugs.webkit.org/show_bug.cgi?id=21838
+
+ * rendering/style/StyleRareInheritedData.h:
+ * rendering/style/StyleRareNonInheritedData.h:
+
+2008-10-23 Brent Fulgham <bfulgham@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ * platform/network/curl/ResourceRequest.h: A better implementation
+ of CFURLRequest, rather than void*. This gives better compatibility
+ with the WebKit.idl interface.
+ (WebCore::ResourceRequest::cfURLRequest):
+
+2008-10-23 Mike Pinkerton <pinkerton@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
+ ifdefs to reflect that.
+
+ * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
+ * platform/graphics/cg/ImageCG.cpp:
+
+2008-10-23 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21833
+ Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ (WebCore::InspectorController::close):
+ * inspector/InspectorController.h:
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+
+2008-10-23 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21817
+ Bug 21817: Manual profiler tests should be made into layout tests
+
+ -Moving the tests before diffing so that it's clear what changed.
+
+ * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
+ * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
+ * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
+ * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
+ * manual-tests/inspector/profiler-test-apply.html: Removed.
+ * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
+ * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
+ * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
+ * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
+ * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
+ * manual-tests/inspector/profiler-test-constructor.html: Removed.
+ * manual-tests/inspector/profiler-test-dead-time.html: Removed.
+ * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
+ * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
+ * manual-tests/inspector/profiler-test-event-handler.html: Removed.
+ * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
+ * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
+ * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
+ * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
+ * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
+ * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
+ * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
+ * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
+ * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
+ * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
+ * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
+ * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
+ * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
+ * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
+ * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
+ * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
+ * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
+ * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
+ * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
+ * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
+ * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
+ * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
+ * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
+ * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
+ * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
+ * manual-tests/inspector/resources/other-frame.html: Removed.
+ * manual-tests/inspector/resources/other-window.html: Removed.
+ * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
+
+2008-10-23 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21826
+
+ Add accessor for SecurityOrigin::m_domainWasSetInDOM.
+
+ * page/SecurityOrigin.h:
+ (WebCore::SecurityOrigin::domainWasSetInDOM):
+
+2008-10-23 Darin Adler <darin@apple.com>
+
+ - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
+
+ * bindings/js/ScheduledAction.h:
+ * inspector/InspectorController.cpp:
+ ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
+
+2008-10-23 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the Qt build.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtConnectionObject::execute):
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMethod::createStructureID):
+
+2008-10-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21825
+ JSDOMBinding should not blindly cast the global object to JSDOMWindow
+
+ * bindings/js/JSDOMGlobalObject.cpp:
+ * bindings/js/JSDOMGlobalObject.h:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::getCachedDOMStructure):
+ (WebCore::cacheDOMStructure):
+ (WebCore::getCachedDOMConstructor):
+ (WebCore::cacheDOMConstructor):
+ Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::mark):
+ Moved constructor and structure tracking to JSDOMGlobalObject.
+
+2008-10-23 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21787
+
+ Update postMessage to send origin = "null" for non-serializable
+ origins to match latest spec. Merge SecurityOrigin::toString and
+ SecurityOrigin::toHTTPOrigin because they are now the same.
+
+ Test: http/tests/security/postMessage/data-url-sends-null-origin.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::outgoingOrigin):
+ (WebCore::FrameLoader::loadURL):
+ (WebCore::FrameLoader::addHTTPOriginIfNeeded):
+ (WebCore::FrameLoader::loadItem):
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::servePendingRequests):
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::toString):
+ * page/SecurityOrigin.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+
+2008-10-22 David Kilzer <ddkilzer@apple.com>
+
+ Bug 21781: WebCore::Settings should have a maximum decoded image size setting
+
+ <https://bugs.webkit.org/show_bug.cgi?id=21781>
+
+ Reviewed by Antti.
+
+ No tests since there is no change in behavior.
+
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::maximumDecodedImageSize): Added. Returns
+ WebCore::Settings::maximumDecodedImageSize() or 0 on error.
+ (WebCore::CachedImage::data): Flag an error if the image being
+ loaded is too big.
+ * loader/CachedImage.h:
+ (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
+ to the maximum value of size_t.
+ * page/Settings.h:
+ (WebCore::Settings::setMaximumDecodedImageSize): Added method.
+ (WebCore::Settings::maximumDecodedImageSize): Ditto.
+
+2008-10-22 Mike Pinkerton <pinkerton@chromium.org>
+
+ Reviewed by Dan Bernstein.
+ Landed and tweaked a bit by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21809
+
+ Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
+ its use for PLATFORM(CHROMIUM) in the future.
+
+ * platform/graphics/SimpleFontData.h:
+
+2008-10-22 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19974
+ getElementsByClassName not live enough
+
+ Test: fast/dom/getElementsByClassName/015.html
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()
+
+2008-10-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21294
+ Bug 21294: Devirtualize getOwnPropertySlot()
+
+ * bindings/js/JSDOMWindowShell.h:
+ (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
+ for this class rather than sharing nullProtoStructureID, which no longer exists.
+
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
+ HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::createStructureID): Ditto.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
+ constructors, and prototypes in any case where they override getOwnPropertySlot, without
+ HasStandardGetOwnPropertySlot.
+
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
+ without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::createStructureID): Ditto.
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createStructureID): Ditto.
+ * bridge/runtime_object.h:
+ (JSC::RuntimeObjectImp::createStructureID): Ditto.
+
+2008-10-22 Brent Fulgham <bfulgham@gmail.com>
+
+ Bring Windows Cairo Port's font handling in line with CG.
+ http://bugs.webkit.org/show_bug.cgi?id=21812.
+
+ Reviewed by Adam Roben.
+
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::createGDIFont): Remove unnecessary special-case for Cairo
+ TrueType font search. It should match CG in all font selections.
+
+2008-10-22 Brent Fulgham <bfulgham@gmail.com>
+
+ http://bugs.webkit.org/show_bug.cgi?id=21812.
+ Bring Windows Cairo Port's font handling in line with CG.
+
+ Reviewed by David Hyatt.
+
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.
+
+2008-10-22 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Adam Roben
+
+ <rdar://6261773> - autocomplete="off" doesn't work on Windows
+
+ Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
+ statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
+ instead of the much more correct "true."
+
+ In the past we have worked around this by declaring the bitfield member as an unsigned instead
+ of the enum type.
+
+ For more discussion, see http://trac.webkit.org/changeset/25329
+
+ * html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*
+
+2008-10-22 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Oliver Hunt and Tim Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19225
+ Bug 19225: JSProfiler: Create automated profiler tests
+ - This change exports profiles on the console object so that they can be
+ iterated over via JavaScript, and thus can be used in automated tests.
+
+ * bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
+ that JS can use.
+ (WebCore::JSConsole::profiles):
+ * inspector/InspectorController.h: Use the new typedef.
+ (WebCore::InspectorController::profiles):
+ * page/Console.cpp: Keep our own array of profile objects.
+ (WebCore::Console::profileEnd):
+ * page/Console.h: Ditto.
+ (WebCore::Console::profiles):
+ * page/Console.idl: Expose the profiles to JS.
+
+2008-10-22 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21775
+
+ Convert buttons over to use the new Theme API on OS X.
+
+ Reviewed by Adam Roben
+
+ * platform/LengthBox.h:
+ (WebCore::LengthBox::LengthBox):
+ * platform/Theme.cpp:
+ (WebCore::Theme::controlBorder):
+ (WebCore::Theme::controlPadding):
+ * platform/Theme.h:
+ (WebCore::Theme::controlFont):
+ (WebCore::Theme::controlSize):
+ (WebCore::Theme::minControlSize):
+ (WebCore::Theme::controlRequiresPreWhiteSpace):
+ * platform/mac/ThemeMac.h:
+ (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
+ * platform/mac/ThemeMac.mm:
+ (WebCore::checkboxSize):
+ (WebCore::radioSize):
+ (WebCore::buttonSizes):
+ (WebCore::buttonMargins):
+ (WebCore::button):
+ (WebCore::paintButton):
+ (WebCore::ThemeMac::controlFont):
+ (WebCore::ThemeMac::controlSize):
+ (WebCore::ThemeMac::minControlSize):
+ (WebCore::ThemeMac::controlBorder):
+ (WebCore::ThemeMac::controlPadding):
+ (WebCore::ThemeMac::inflateControlPaintRect):
+ (WebCore::ThemeMac::paint):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ (WebCore::RenderTheme::paint):
+ (WebCore::RenderTheme::controlStatesForRenderer):
+ (WebCore::RenderTheme::isDefault):
+ (WebCore::RenderTheme::adjustRadioStyle):
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::setRadioSize):
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect):
+ (WebCore::menuListButtonSizes):
+ (WebCore::RenderThemeMac::adjustMenuListStyle):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::paddingBox):
+ (WebCore::InheritedFlags::setPaddingBox):
+
+2008-10-22 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Make sure that the AtomicString that identifies a set of animation keyframes
+ stays live by keeping a copy in the WebKitCSSKeyframesRule.
+
+ Also call styleSheetChanged() when the keyframes name changes, but
+ add an internal method that doesn't call styleSheetChanged() for use
+ during normal stylesheet parsing.
+
+ Test: animations/change-keyframes-name.html
+
+ * css/CSSGrammar.y:
+ * css/WebKitCSSKeyframesRule.cpp:
+ (WebCore::WebKitCSSKeyframesRule::setName):
+ * css/WebKitCSSKeyframesRule.h:
+ (WebCore::WebKitCSSKeyframesRule::setNameInternal):
+
+2008-10-22 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21791
+ WebCore JS bindings should be able to use non-static hash tables for properties
+
+ Add a map for HashTables to WebCore JS client data.
+
+ This makes property access noticeably slower, so it is an opt-in. For classes that need to be
+ supported in workers in forseeable future this is not critical.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::DOMObjectHashTableMap::get):
+ (WebCore::DOMObjectHashTableMap::mapFor):
+ (WebCore::getHashTableForGlobalData):
+ (WebCore::DOMObjectWrapperMap::mapFor):
+ WebCore client data is now a class that contains both a DOM wrapper map and a property hash
+ table one.
+
+ * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.
+
+ * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
+ JSDOMBinding map to access its property hash tables.
+
+ * dom/MessageChannel.idl:
+ * dom/MessagePort.idl:
+ Added NoStaticTables attribute.
+
+2008-10-22 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Build failure because of missing include
+ https://bugs.webkit.org/show_bug.cgi?id=21765
+
+ Build failure fix for WebKit/GTK+; added missing
+ include (GOwnPtr.h)
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+
+2008-10-22 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Adam Roben.
+
+ Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
+ doesn't initialize values if the requested property doesn't exist, so
+ initialize the values to the documented defaults before calling it
+ where necessary. Additionally, avoid critical warnings by not calling
+ gtk_widget_style_get() when we know the property isn't available.
+
+ Note that this is an imported source file which doesn't follow the
+ WebKit coding style.
+
+ * platform/gtk/gtk2drawing.c:
+ (moz_gtk_init):
+ (moz_gtk_button_get_inner_border):
+ (moz_gtk_combo_box_paint):
+ (moz_gtk_toolbar_separator_paint):
+ (moz_gtk_menu_separator_paint):
+ (moz_gtk_get_widget_border):
+ (moz_gtk_get_tab_scroll_arrow_size):
+ (moz_gtk_get_toolbar_separator_width):
+ (moz_gtk_get_menu_separator_height):
+
+2008-10-22 Alp Toker <alp@nuanti.com>
+
+ Fix build for Cairo 1.2.
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::clipOut):
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::paintMozWidget):
+
+2008-10-22 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ A little more PLATFORM(CHROMIUM) in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=21758
+
+ * page/AccessibilityObject.h:
+ * platform/graphics/Icon.h:
+
+2008-10-21 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Test: fast/events/message-channel-gc-3.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=21769
+ MessagePort should be GC protected if there are messages to be delivered
+
+ * dom/MessagePort.h: Removed pending activity count. Now we track if a close event is
+ pending, and check if the queue is non-empty.
+ (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug
+ fix (below).
+
+ * dom/MessagePort.cpp:
+ (WebCore::CloseMessagePortTimer::fired):
+ (WebCore::MessagePort::MessagePort):
+ (WebCore::MessagePort::queueCloseEvent):
+ (WebCore::MessagePort::dispatchCloseEvent):
+ (WebCore::MessagePort::hasPendingActivity):
+ Track message and close event activity separately.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was
+ causing same-heap ports to never be deleted.
+
+2008-10-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - remove unreachable code
+
+ * platform/text/BidiResolver.h:
+ (WebCore::::embed):
+
+2008-10-21 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
+ REGRESSION(r31030-31055): Choosing "Print window" from frame set
+ prints blank page
+ and corresponding: <rdar://problem/6142398>
+
+ viewHeight() and viewWidth() only return valuable information if we
+ are not printing. Everywhere else in the code, we make sure we are
+ not printing before we call these functions. Adding a check for
+ printing here fixes this bug, and framesets print again.
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::layout):
+
+2008-10-21 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Simon.
+
+ Pixmap in canvas tag was not getting initialized.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=21771
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::create):
+
+2008-10-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Add a comment explaining layoutDelta(), and an assertion
+ that checks that delta changes were correctly paired during layout.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::layout):
+ * rendering/RenderView.h:
+
+2008-10-20 Timothy Hatcher <timothy@apple.com>
+
+ Make auto-complete only suggest properties that are valid syntax
+ when using dot-notation. Also when completing numeric properties,
+ the quotes are omitted inside the brackets.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21760
+ https://bugs.webkit.org/show_bug.cgi?id=21761
+
+ Reviewed by Oliver Hunt.
+
+ * inspector/front-end/Console.js:
+ (WebInspector.Console.prototype.completions): Skip properties that
+ are not valid identifies when using dot-notation. And omit the quotes
+ when completing numbers in bracket-notation.
+
+2008-10-20 Timothy Hatcher <timothy@apple.com>
+
+ Fixes the Profiles panel in the Web Inspector, which was broken by
+ the JSValue base-class changes. Also renames some functions and
+ variables in JavaScriptProfileNode.cpp that where title case.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21764
+
+ Reviewed by Oliver Hunt.
+
+ * inspector/JavaScriptProfile.cpp:
+ (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the
+ returned JSValuePtr will be treated as an object and not a value.
+ * inspector/JavaScriptProfileNode.cpp:
+ (WebCore::toJS): Ditto.
+
+2008-10-20 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::detachFromParent):
+ * loader/FrameLoaderClient.h:
+
+2008-10-20 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=21763
+ REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
+ <rdar://problem/6285025
+
+ If we get 304 response we need to explicitly check if that completes the frame load.
+
+ No test case, simulating the condition is pretty difficult.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didReceiveResponse):
+
+2008-10-20 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Work around <rdar://problem/6301728>.
+
+ Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::didReceiveResponse):
+ (WebCore::MainResourceLoader::didReceiveData):
+ (WebCore::MainResourceLoader::didFinishLoading):
+ (WebCore::MainResourceLoader::didFail):
+
+2008-10-20 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
+ crashes in Safari at com.apple.WebCore
+ WebCore::ScrollView::visibleContentRect const + 153
+
+ d->m_view can be null and is null-checked at other points in the
+ code. The logs indicate that this crash occurs when closing a
+ window containing a PDF, so in case where we crash, the PDF's view
+ is probably already null. So the fix is to simply add a null-check.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::selectionRect):
+
+2008-10-20 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
+ Removed stray increment that would screw up any form with multiple files in it.
+
+2008-10-20 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by David Hyatt.
+
+ Split LengthBox and LengthSize into their own files.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/Length.h:
+ (WebCore::Length::blend):
+ * platform/LengthBox.h: Copied from platform/Length.h.
+ (WebCore::LengthBox::LengthBox):
+ (WebCore::LengthBox::nonZero):
+ * platform/LengthSize.h: Copied from platform/Length.h.
+ (WebCore::LengthSize::LengthSize):
+ (WebCore::LengthSize::setWidth):
+ (WebCore::LengthSize::setHeight):
+ (WebCore::LengthSize::height):
+ * platform/Theme.h:
+ * rendering/style/FillLayer.h:
+ * rendering/style/NinePieceImage.h:
+ (WebCore::NinePieceImage::NinePieceImage):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleDashboardRegion.h:
+ * rendering/style/StyleSurroundData.h:
+ * rendering/style/StyleVisualData.h:
+
+2008-10-20 Dan Bernstein <mitz@apple.com>
+
+ - Mac build fix
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Fix autotools dist build target by listing recently added header
+ files only. Not reviewed.
+
+ * GNUmakefile.am:
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
+ refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
+ originally.
+
+ ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.
+
+ Reviewed by Adam Roben
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/Theme.cpp: Added.
+ (WebCore::Theme::controlSupportsBorder):
+ (WebCore::Theme::controlSupportsPadding):
+ * platform/Theme.h:
+ * platform/mac/ThemeMac.h:
+ * platform/mac/ThemeMac.mm:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ * rendering/RenderTheme.h:
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ Rename LengthBox's members to have m_ in front of them.
+
+ Reviewed by Sam Weinig
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::valueForNinePieceImage):
+ (WebCore::getPositionOffsetValue):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapNinePieceImage):
+ * platform/Length.h:
+ (WebCore::LengthBox::LengthBox):
+ (WebCore::LengthBox::left):
+ (WebCore::LengthBox::right):
+ (WebCore::LengthBox::top):
+ (WebCore::LengthBox::bottom):
+ (WebCore::LengthBox::operator==):
+ (WebCore::LengthBox::nonZero):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::paintNinePieceImage):
+ (WebCore::RenderObject::addDashboardRegions):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::positionedObjectMoved):
+ (WebCore::RenderStyle::setClip):
+ (WebCore::RenderStyle::noneDashboardRegions):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::left):
+ (WebCore::InheritedFlags::right):
+ (WebCore::InheritedFlags::top):
+ (WebCore::InheritedFlags::bottom):
+ (WebCore::InheritedFlags::clipLeft):
+ (WebCore::InheritedFlags::clipRight):
+ (WebCore::InheritedFlags::clipTop):
+ (WebCore::InheritedFlags::clipBottom):
+ (WebCore::InheritedFlags::marginTop):
+ (WebCore::InheritedFlags::marginBottom):
+ (WebCore::InheritedFlags::marginLeft):
+ (WebCore::InheritedFlags::marginRight):
+ (WebCore::InheritedFlags::paddingTop):
+ (WebCore::InheritedFlags::paddingBottom):
+ (WebCore::InheritedFlags::paddingLeft):
+ (WebCore::InheritedFlags::paddingRight):
+ (WebCore::InheritedFlags::setLeft):
+ (WebCore::InheritedFlags::setRight):
+ (WebCore::InheritedFlags::setTop):
+ (WebCore::InheritedFlags::setBottom):
+ (WebCore::InheritedFlags::setDashboardRegion):
+ (WebCore::InheritedFlags::setClipLeft):
+ (WebCore::InheritedFlags::setClipRight):
+ (WebCore::InheritedFlags::setClipTop):
+ (WebCore::InheritedFlags::setClipBottom):
+ (WebCore::InheritedFlags::setMarginTop):
+ (WebCore::InheritedFlags::setMarginBottom):
+ (WebCore::InheritedFlags::setMarginLeft):
+ (WebCore::InheritedFlags::setMarginRight):
+ (WebCore::InheritedFlags::setPaddingTop):
+ (WebCore::InheritedFlags::setPaddingBottom):
+ (WebCore::InheritedFlags::setPaddingLeft):
+ (WebCore::InheritedFlags::setPaddingRight):
+
+2008-10-20 Timothy Hatcher <timothy@apple.com>
+
+ Make the Resource panel perform graph updates atomically, so when resources
+ are added the graph and summary graph update at the same time.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21755
+
+ Reviewed by Kevin McCullough.
+
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime
+ property is undefined, null or 0. This allows callers to check for -1 and not
+ the other values when there is no startTime yet.
+ (WebInspector.Resource.prototype.get responseReceivedTime): Ditto.
+ (WebInspector.Resource.prototype.get endTime): Ditto.
+ (WebInspector.Resource.prototype.get duration): Remove an extra empty line.
+ (WebInspector.Resource.prototype.get latency): Ditto.
+ (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration
+ property is undefined or null. This allows callers to always assume a number.
+ (WebInspector.Resource.prototype.get expectedContentLength): Ditto.
+ (WebInspector.Resource.prototype.get errors): Simplify the case where there is
+ no _errors property yet.
+ (WebInspector.Resource.prototype.set errors): Remove the check if the new value
+ if the same as the previous value, since there is no work to guard.
+ (WebInspector.Resource.prototype.get warnings): Simplify the case where there is
+ no _warnings property yet.
+ (WebInspector.Resource.prototype.set warnings): Remove the check if the new value
+ if the same as the previous value, since there is no work to guard.
+ (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the
+ responseReceivedTime is -1.
+ (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not
+ have a _resourcesTreeElement yet, exclude it from the searchable views.
+ (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources
+ and call refresh to refresh the entire graph.
+ (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel
+ is visible that calls refresh.
+ (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and
+ graph for a resource if it hasn't been created yet. If the boundaries changed during
+ the first stale resource pass, do a full pass of all resources when updating the graphs.
+ (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items.
+ (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and
+ graph, these are now created during the first refresh.
+ (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement.
+ (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto.
+ (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
+ (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just
+ add the resource to the _staleResources and set needsRefresh.
+ (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check
+ _resourcesTreeElement.
+ (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear
+ the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild
+ since the insertBefore call will do it if needed.
+ (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to
+ clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded.
+ (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the
+ timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel,
+ since all the legend items are removed in one pass right before.
+ (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction
+ before the calculator so the correct sortingFunction is there when a refresh happens.
+ (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0
+ when the startTime is -1, since that looks best visually. Also set middle and end
+ to the start and middle (respectfully) when startAtZero. This looks best visually.
+ (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh.
+ (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21733
+
+ Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
+ no attempt is made to re-cache the frame from a non-existent image source.
+
+ Reviewed by Sam Weinig
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+
+2008-10-20 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - make hasARenderedDescendant() have internal linkage
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::hasARenderedDescendant):
+
+2008-10-20 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Jon Honeycutt
+
+ Fix a crash in Accessibility where a table section was being
+ referenced without first checking if it was null
+
+ https://bugs.webkit.org/show_bug.cgi?id=21721
+
+ Test: accessibility/table-nofirstbody.html
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::addChildren):
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.
+
+ Reviewed by Darin Adler
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::repetitionCount):
+ (WebCore::ImageSource::frameDurationAtIndex):
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix the pthread conditionals in the FTP code to correctly define
+ threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
+ build.
+
+ * loader/FTPDirectoryDocument.cpp:
+ * loader/FTPDirectoryParser.cpp:
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21751
+
+ Convert checkboxes and radio buttons on OS X over to the new Theme API.
+
+ Reviewed by Adam Roben
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapFillSize):
+ * platform/Length.h:
+ (WebCore::LengthSize::LengthSize):
+ (WebCore::LengthSize::operator==):
+ (WebCore::LengthSize::width):
+ (WebCore::LengthSize::height):
+ (WebCore::LengthSize::setWidth):
+ (WebCore::LengthSize::setHeight):
+ * platform/Theme.h:
+ (WebCore::Theme::controlSize):
+ (WebCore::Theme::controlSupportsBorder):
+ (WebCore::Theme::controlSupportsPadding):
+ (WebCore::Theme::paint):
+ (WebCore::Theme::inflateControlPaintRect):
+ * platform/ThemeTypes.h:
+ (WebCore::):
+ * platform/mac/ThemeMac.h:
+ * platform/mac/ThemeMac.mm:
+ (WebCore::):
+ (WebCore::controlSizeForFont):
+ (WebCore::sizeFromFont):
+ (WebCore::setControlSize):
+ (WebCore::updateStates):
+ (WebCore::inflateRect):
+ (WebCore::checkboxSizes):
+ (WebCore::checkboxMargins):
+ (WebCore::checkboxSize):
+ (WebCore::checkbox):
+ (WebCore::paintCheckbox):
+ (WebCore::radioSizes):
+ (WebCore::radioMargins):
+ (WebCore::radioSize):
+ (WebCore::radio):
+ (WebCore::paintRadio):
+ (WebCore::ThemeMac::baselinePositionAdjustment):
+ (WebCore::ThemeMac::controlSize):
+ (WebCore::ThemeMac::controlSupportsBorder):
+ (WebCore::ThemeMac::controlSupportsPadding):
+ (WebCore::ThemeMac::inflateControlPaintRect):
+ (WebCore::ThemeMac::paint):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calculateBackgroundSize):
+ * rendering/RenderObject.cpp:
+ (WebCore::mustRepaintFillLayers):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ (WebCore::RenderTheme::paint):
+ (WebCore::RenderTheme::baselinePosition):
+ (WebCore::RenderTheme::adjustRepaintRect):
+ (WebCore::RenderTheme::controlStatesForRenderer):
+ (WebCore::RenderTheme::isFocused):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect):
+ * rendering/style/FillLayer.cpp:
+ (WebCore::FillLayer::operator==):
+
+2008-10-18 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
+ Emit profiling instrumentation only if the Web Inspector's profiling
+ feature is enabled
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::supportsProfiling):
+ * bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying
+ whether a target global object has the Web Inspector's profiling feature
+ enabled.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon):
+ (WebCore::JavaScriptDebugServer::didAddListener):
+ (WebCore::JavaScriptDebugServer::didRemoveListener):
+ * inspector/JavaScriptDebugServer.h: Exported an API for recompiling,
+ used by the Settings object.
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setDeveloperExtrasEnabled):
+ * page/Settings.h: Recompile when the developer menu is enabled/disabled
+ for the first time, to add/remove profiling hooks. In the future, with
+ better Web Inspector UI, we can do this on a page-by-page basis,
+ instead of a global basis.
+
+2008-10-20 David Hyatt <hyatt@apple.com>
+
+ Move Length to platform/.
+
+ Reviewed by Adam Roben
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * platform/Length.cpp: Copied from rendering/Length.cpp.
+ * platform/Length.h: Copied from rendering/Length.h.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ - try to fix Qt build
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls.
+ (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ - try to fix Qt build
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr.
+ (JSC::Bindings::QtField::valueFromInstance): Ditto.
+ * bridge/qt/qt_instance.h: Ditto.
+
+2008-10-20 Darin Adler <darin@apple.com>
+
+ - try to fix Tiger build
+
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted
+ volatile qualifier.
+ (ObjcInstance::invokeDefaultMethod): Ditto.
+ (ObjcInstance::getValueOfUndefinedField): Ditto.
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcField::valueFromInstance): Ditto.
+
+2008-10-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21750
+ Eliminate the notion of "temporary events"
+
+ We mark some events as temporary when dispatching, for the sole reason of
+ manually calling forgetDOMObject when done dispatching.
+
+ There doesn't seem to be any reason to call it manually, as JSEvent destructor
+ will do this automatically right away.
+
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptController.h:
+ Removed ScriptController::finishedWithEvent(), which was called after dispatching
+ a temporary event.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/EventTarget.h:
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchEvent):
+ (WebCore::EventTargetNode::dispatchGenericEvent):
+ (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
+ (WebCore::EventTargetNode::dispatchWindowEvent):
+ (WebCore::EventTargetNode::dispatchUIEvent):
+ (WebCore::EventTargetNode::dispatchKeyEvent):
+ (WebCore::EventTargetNode::dispatchMouseEvent):
+ (WebCore::EventTargetNode::dispatchWheelEvent):
+ (WebCore::EventTargetNode::dispatchWebKitAnimationEvent):
+ (WebCore::EventTargetNode::dispatchWebKitTransitionEvent):
+ (WebCore::EventTargetNode::dispatchEventForType):
+ (WebCore::EventTargetNode::dispatchProgressEvent):
+ (WebCore::EventTargetNode::dispatchStorageEvent):
+ * dom/EventTargetNode.h:
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::dispatchMessages):
+ (WebCore::MessagePort::dispatchCloseEvent):
+ (WebCore::MessagePort::dispatchEvent):
+ * dom/MessagePort.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::dispatchCPPEvent):
+ (WebCore::dispatchEditableContentChangedEvents):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::insertText):
+ * loader/appcache/DOMApplicationCache.cpp:
+ (WebCore::DOMApplicationCache::dispatchEvent):
+ (WebCore::DOMApplicationCache::callListener):
+ * loader/appcache/DOMApplicationCache.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchDragEvent):
+ (WebCore::EventHandler::keyEvent):
+ (WebCore::EventHandler::handleTextInputEvent):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scheduleEvent):
+ (WebCore::FrameView::updateOverflowStatus):
+ (WebCore::FrameView::dispatchScheduledEvents):
+ * page/FrameView.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset):
+ (WebCore::RenderLayer::updateOverflowStatus):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::sendSVGLoadEventIfPossible):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::dispatchEvent):
+ * svg/SVGElementInstance.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::dispatchEvent):
+ (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
+ (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
+ * xml/XMLHttpRequest.h:
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::dispatchEvent):
+ (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
+ * xml/XMLHttpRequestUpload.h:
+ Don't pass the tempEvent boolean around.
+
+2008-10-20 Alp Toker <alp@nuanti.com>
+
+ Remove unused includes only. Partial GTK+/Win build fix.
+
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+
+2008-10-20 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21705
+ Implement Web Workers client-side API
+
+ The implementation is experimental, and disabled by default. It doesn't quite match the
+ published draft, being influenced by further WHATWG discussions.
+
+ This only implements the client-side API, and does not actually create any threads or
+ global contexts yet.
+
+ * DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm
+ still not sure if having separate classes for these helps at all.
+
+ * WebCore.xcodeproj/project.pbxproj: Added new files.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (jsDOMWindowBaseWorker):
+ (WebCore::JSDOMWindowBase::put):
+ (setJSDOMWindowBaseWorker):
+ Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef
+ to match prevailing style.
+
+ * bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
+ * bindings/js/JSDedicatedWorkerConstructor.h: Added.
+ * bindings/js/JSDedicatedWorkerCustom.cpp: Added.
+ The implementation of event listeners are left custom intentionally, for easier implementation
+ of listeners that are not tied to any Document in the future.
+
+ * dom/DedicatedWorker.cpp: Added.
+ * dom/DedicatedWorker.h: Added.
+ * dom/DedicatedWorker.idl: Added.
+ Added an implementation that can only load requested scripts for now.
+
+2008-10-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix assertion seen when opening inspector
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
+ Removed unneeded asObject cast.
+
+2008-10-19 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Timothy Hatcher.
+
+ - remove empty directories and correct the MIME type of inspector images
+
+ * page/inspector: Removed.
+ * page/inspector/Images: Removed.
+
+2008-10-19 Timothy Hatcher <timothy@apple.com>
+
+ Make the Web Inspector Resources panel open quicker and change graphs
+ faster. There was some accidental n^2 logic at fault when updating the
+ graph boundaries.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21742
+
+ Reviewed by Darin Adler.
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.set calculator): Return early for
+ a null calculator. Remove the second argument passed to _refreshAllResources.
+ (WebInspector.ResourcesPanel.prototype.refresh): Call updateBoundaries on
+ the calculator for all the stale resources before calling refreshResource.
+ Pass true for the first argument of refreshResource to skip the boundary update.
+ (WebInspector.ResourcesPanel.prototype._updateGraphBoundariesIfNeeded): Remove
+ the second argument passed to _refreshAllResources.
+ (WebInspector.ResourcesPanel.prototype._refreshAllResourcesSoon): Remove the
+ skipSort argument since every passed true, and it would be bad to pass false.
+ (WebInspector.ResourcesPanel.prototype._refreshAllResources): Ditto. And if
+ skipBoundaryUpdate is false, call updateBoundaries on the calculator for all
+ the resources before calling refreshResource. Pass true for the first argument
+ of refreshResource to skip the boundary update.
+
+2008-10-19 Timothy Hatcher <timothy@apple.com>
+
+ Visually distinguish resources that loaded from the memory cache.
+
+ https://bugs.webkit.org/show_bug.cgi?id=14279
+
+ Reviewed by Dan Bernstein.
+
+ * English.lproj/localizedStrings.js: New string.
+ * inspector/front-end/Images/timelineHollowPillBlue.png: Added.
+ * inspector/front-end/Images/timelineHollowPillGray.png: Added.
+ * inspector/front-end/Images/timelineHollowPillGreen.png: Added.
+ * inspector/front-end/Images/timelineHollowPillOrange.png: Added.
+ * inspector/front-end/Images/timelineHollowPillPurple.png: Added.
+ * inspector/front-end/Images/timelineHollowPillRed.png: Added.
+ * inspector/front-end/Images/timelineHollowPillYellow.png: Added.
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels):
+ Add the "(from cache)" suffix to the tooltip.
+ (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
+ Add the "(from cache)" suffix to the tooltip.
+ (WebInspector.ResourceGraph): Add the "resource-cached" class.
+ * inspector/front-end/inspector.css: New styles to make the timeline
+ bars use the hollow pill images.
+
+2008-10-19 Timothy Hatcher <timothy@apple.com>
+
+ Update the scroll position in the Resources panel when loading
+ a new page or toggling on small resource rows.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20114
+
+ Reviewed by Darin Adler.
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.reset): Scroll to the top,
+ since all the resource are being removed.
+ (WebInspector.ResourcesPanel.prototype.removeResource): Call
+ _adjustScrollPosition in case the view is shorter and needs scrolled.
+ (WebInspector.ResourcesPanel.prototype._toggleLargerResources): Ditto.
+ (WebInspector.ResourcesPanel.prototype._adjustScrollPosition): Check
+ the height of the sidebar against the scrollTop and height of the
+ resourcesContainerElement. If the sidebar is shorter, scroll up
+ so the last resource is at the bottom again.
+
+2008-10-19 Timothy Hatcher <timothy@apple.com>
+
+ Show per resource times and sizes when hovering over the bar graph for a resource.
+
+ https://bugs.webkit.org/show_bug.cgi?id=14300
+ rdar://problem/5712802
+
+ Reviewed by Cameron Zwarich.
+
+ * English.lproj/localizedStrings.js: Add new strings.
+ * inspector/front-end/Images/graphLabelCalloutLeft.png: Added.
+ * inspector/front-end/Images/graphLabelCalloutRight.png: Added.
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.refreshResource): Pass the calculator to the
+ ResourceGraph.refresh function.
+ (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Default implementation
+ returns the formatted value.
+ (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Return discrete values
+ for the latency and download times. Also generate a custom tooltip.
+ (WebInspector.ResourceGraph): Add a mouseover event listener that calls refreshLabelPositions.
+ (WebInspector.ResourceGraph.prototype.refreshLabelPositions): Added. Updates the label positions
+ in case the bar has changed size.
+ (WebInspector.ResourceGraph.prototype.refresh): Set the label text and tooltips.
+ * inspector/front-end/inspector.css: New styles for the labels.
+
+2008-10-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Remove most uses of JSValue, which will be removed in a future patch.
+
+ * bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue
+ and used JSValuePtr instead.
+ * bindings/js/JSEventTarget.h: Ditto.
+ * bindings/js/JSNodeFilterCondition.h: Ditto.
+ * bindings/js/ScheduledAction.h: Ditto.
+ * bindings/js/ScriptController.h: Ditto.
+ * bindings/objc/WebScriptObjectPrivate.h: Ditto.
+ * bridge/c/c_utility.h: Ditto.
+ * bridge/jni/jni_jsobject.h: Ditto.
+ * bridge/jni/jni_utility.h: Ditto.
+ * bridge/objc/WebScriptObject.h: Ditto.
+ * dom/Traversal.h: Ditto.
+ * inspector/InspectorController.cpp: Ditto.
+ * inspector/JavaScriptProfile.h: Ditto.
+ * inspector/JavaScriptProfileNode.h: Ditto.
+ * loader/FrameLoader.h: Ditto.
+ * page/Console.h: Ditto.
+ * plugins/MimeTypeArray.h: Ditto.
+ * plugins/Plugin.h: Ditto.
+ * plugins/PluginArray.h: Ditto.
+ * plugins/PluginView.cpp:
+ (WebCore::getString): Ditto.
+ (WebCore::PluginView::performRequest): Ditto.
+ * plugins/gtk/PluginViewGtk.cpp: Ditto.
+ * plugins/qt/PluginViewQt.cpp: Ditto.
+ * plugins/win/PluginViewWin.cpp: Ditto.
+
+ * bridge/qt/qt_class.cpp:
+ (JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject*
+ instead of JSValue*.
+ * bridge/qt/qt_class.h: Ditto.
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::mark): Ditto.
+ (JSC::Bindings::QtInstance::invokeMethod): Ditto.
+ (JSC::Bindings::QtInstance::defaultValue): Ditto.
+ (JSC::Bindings::QtInstance::stringValue): Ditto.
+ (JSC::Bindings::QtInstance::numberValue): Ditto.
+ (JSC::Bindings::QtInstance::booleanValue): Ditto.
+ (JSC::Bindings::QtInstance::valueOf): Ditto.
+ (JSC::Bindings::QtField::valueFromInstance): Ditto.
+ (JSC::Bindings::QtField::setValueToInstance): Ditto.
+ * bridge/qt/qt_instance.h: Ditto.
+ * bridge/qt/qt_runtime.cpp: Ditto.
+ (JSC::Bindings::valueRealType): Ditto.
+ (JSC::Bindings::convertValueToQVariant): Ditto.
+ (JSC::Bindings::convertQVariantToValue): Ditto.
+ (JSC::Bindings::findMethodIndex): Ditto.
+ (JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
+ (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto.
+ (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
+ (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
+ (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
+ (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
+ (JSC::Bindings::QtArray::setValueAt): Ditto.
+ (JSC::Bindings::QtArray::valueAt): Ditto.
+ * bridge/qt/qt_runtime.h: Ditto.
+
+ * bridge/testqtbindings.cpp:
+ (main): Use JSValuePtr.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Tweak a little more to get closer to where we can make JSValuePtr a class.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject.
+ (WebCore::constructAudio): Ditto.
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.
+
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::toHTMLCanvasStyle): Use asString and asObject.
+ (WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto.
+ (WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto.
+ (WebCore::JSCanvasRenderingContext2D::drawImage): Ditto.
+ (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto.
+ (WebCore::JSCanvasRenderingContext2D::setShadow): Ditto.
+ (WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.
+
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::setDOMException): Use noValue.
+
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::getDOMPrototype): Use asObject.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::showModalDialog): Use noValue.
+ (jsDOMWindowBaseEvent): Use asObject.
+ (jsDOMWindowBaseImage): Ditto.
+ (jsDOMWindowBaseMessageChannel): Ditto.
+ (jsDOMWindowBaseOption): Ditto.
+ (jsDOMWindowBaseXMLHttpRequest): Ditto.
+ (jsDOMWindowBaseAudio): Ditto.
+ (jsDOMWindowBaseXSLTProcessor): Ditto.
+ (WebCore::JSDOMWindowBase::childFrameGetter): Ditto.
+ (WebCore::JSDOMWindowBase::indexGetter): Ditto.
+ (WebCore::JSDOMWindowBase::namedItemGetter): Ditto.
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto.
+ (WebCore::JSDOMWindowBase::findJSEventListener): Ditto.
+ (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto.
+ (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto.
+ (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto.
+ (windowProtoFuncOpen): Use noValue.
+ (WebCore::toJSDOMWindow): Use asObject.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::setTimeoutOrInterval): Use asString.
+ (WebCore::toDOMWindow): Use asObject.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent): Use noValue.
+ (WebCore::JSLazyEventListener::parseCode): Use asObject.
+
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::JSHTMLCollection::nameGetter): Use asObject.
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::nameGetter): Ditto.
+ * bindings/js/JSHTMLElementCustom.cpp:
+ (WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::nameGetter): Ditto.
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ (WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
+ * bindings/js/JSHTMLOptionElementConstructor.cpp:
+ (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
+ (WebCore::constructHTMLOptionElement): Ditto.
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ (WebCore::JSHTMLOptionsCollection::remove): Ditto.
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
+ (WebCore::constructImage): Ditto.
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap): Ditto.
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
+
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.
+
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject.
+ (WebCore::JSMessageChannelConstructor::construct): Ditto.
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ (WebCore::JSMimeTypeArray::nameGetter): Ditto.
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ (WebCore::JSNamedNodeMap::nameGetter): Ditto.
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::lengthGetter): Ditto.
+ (WebCore::JSNamedNodesCollection::indexGetter): Ditto.
+ * bindings/js/JSNodeFilterCustom.cpp:
+ (WebCore::toNodeFilter): Ditto.
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::JSNodeList::nameGetter): Ditto.
+ * bindings/js/JSPluginArrayCustom.cpp:
+ (WebCore::JSPluginArray::nameGetter): Ditto.
+ * bindings/js/JSPluginCustom.cpp:
+ (WebCore::JSPlugin::nameGetter): Ditto.
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::runtimeObjectGetter): Ditto.
+ (WebCore::runtimeObjectPropertyGetter): Ditto.
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto.
+ (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto.
+ (WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
+ * bindings/js/JSRGBColor.cpp:
+ (jsRGBColorRed): Ditto.
+ (jsRGBColorGreen): Ditto.
+ (jsRGBColorBlue): Ditto.
+
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item): Use noValue.
+
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::nameGetter): Use asObject.
+ (WebCore::JSStorage::deleteProperty): Ditto.
+ (WebCore::JSStorage::customPut): Ditto.
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ (WebCore::JSStyleSheetList::nameGetter): Ditto.
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ (WebCore::JSXSLTProcessor::importStylesheet): Ditto.
+ (WebCore::JSXSLTProcessor::transformToFragment): Ditto.
+ (WebCore::JSXSLTProcessor::transformToDocument): Ditto.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate): Use noValue.
+ * bindings/objc/DOMInternal.mm:
+ (-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.
+
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject evaluateWebScript:]): Use JSValuePtr.
+ (-[WebScriptObject valueForKey:]): Ditto.
+ (-[WebScriptObject webScriptValueAtIndex:]): Ditto.
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+ Use asObject and asString.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Use asObject.
+
+ * bridge/c/c_instance.h: Use JSValuePtr.
+ * bridge/c/c_runtime.cpp:
+ (JSC::Bindings::CField::setValueToInstance): Ditto.
+
+ * bridge/c/c_utility.cpp:
+ (JSC::Bindings::convertValueToNPVariant): Use asObject.
+
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::booleanValue): Use JSValuePtr.
+ (JavaInstance::invokeMethod): Ditto. And noValue.
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::getSlot): Ditto.
+ (JavaJSObject::convertValueToJObject): Ditto.
+ * bridge/jni/jni_runtime.cpp:
+ (JavaField::dispatchValueFromInstance): Ditto.
+ (JavaField::valueFromInstance): Ditto.
+ (JavaField::dispatchSetValueToInstance): Ditto.
+ (JavaField::setValueToInstance): Ditto.
+ (JavaArray::setValueAt): Ditto.
+ (JavaArray::valueAt): Ditto.
+ * bridge/jni/jni_runtime.h: Ditto.
+
+ * bridge/jni/jni_utility.cpp:
+ (JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray*
+ instead of a JSValue*.
+ (JSC::Bindings::convertValueToJValue): Use asObject and asArray.
+
+ * bridge/objc/objc_class.h: Use JSValuePtr.
+ * bridge/objc/objc_instance.h: Ditto.
+ * bridge/objc/objc_runtime.h: Ditto.
+
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::callObjCFallbackObject): Use asObject.
+
+ * bridge/objc/objc_utility.h: Use JSValuePtr.
+ * bridge/objc/objc_utility.mm:
+ (JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject.
+ (JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.
+
+ * bridge/runtime.cpp:
+ (JSC::Bindings::Instance::getValueOfField): Use JSValuePtr.
+ (JSC::Bindings::Instance::setValueOfField): Ditto.
+
+ * bridge/runtime_array.cpp:
+ (JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject.
+ (JSC::RuntimeArray::indexGetter): Ditto.
+ * bridge/runtime_array.h: Ditto.
+ * bridge/runtime_method.cpp:
+ (JSC::RuntimeMethod::lengthGetter): Ditto.
+ (JSC::callRuntimeMethod): Ditto.
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto.
+ (JSC::RuntimeObjectImp::fieldGetter): Ditto.
+ (JSC::RuntimeObjectImp::methodGetter): Ditto.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::executeScript): Use noValue.
+
+ * page/Console.cpp:
+ (WebCore::Console::trace): Use asInternalFunction.
+
+2008-10-19 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ - lower the default button repaint frequency
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::styleDidChange): Changed the timer interval from
+ 0.01 to 0.03.
+
+2008-10-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - Windows build fix
+
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::paintMediaFullscreenButton):
+ (WebCore::RenderThemeSafari::paintMediaMuteButton):
+ (WebCore::RenderThemeSafari::paintMediaPlayButton):
+ (WebCore::RenderThemeSafari::paintMediaSeekBackButton):
+ (WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
+ (WebCore::RenderThemeSafari::paintMediaSliderThumb):
+
+2008-10-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736
+ Long-dead decoded image data make up for most of the object cache's memory use over time
+
+ Add a cache setting for how long decoded image data should be allowed to
+ persist in memory after the image has died. By default, this is set to
+ 0, which means "forever".
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
+ * loader/Cache.h:
+ (WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter.
+ (WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::CachedImage): Initialize the decoded data
+ deletion timer.
+ (WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys
+ the decoded image data.
+ (WebCore::CachedImage::addClient): Stop the timer if it is active.
+ (WebCore::CachedImage::allClientsRemoved): Start the decoded data
+ deletion timer.
+ * loader/CachedImage.h:
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21645
+ REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::formData):
+ Fix loop that goes through the FormDataList to go two at a time in a clearer
+ way. My last patch screwed up the way it got form content from the items.
+ This "two at a time" approach is a confusing way to do things, which explains
+ why I got it wrong last time through, but I decided to just fix it locally for
+ now rather than changing the design of FormDataList.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - next step on https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
+ changing JSValuePtr to be a class, and then eventually renaming it
+ to JSValue once that's done.
+
+ * bindings/js/JSAttrCustom.cpp:
+ * bindings/js/JSCSSRuleCustom.cpp:
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ * bindings/js/JSCSSValueCustom.cpp:
+ * bindings/js/JSCanvasPixelArrayCustom.h:
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ * bindings/js/JSClipboardCustom.cpp:
+ * bindings/js/JSConsoleCustom.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.cpp:
+ * bindings/js/JSCustomVoidCallback.h:
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * bindings/js/JSDOMWindowCustom.h:
+ * bindings/js/JSDOMWindowShell.cpp:
+ * bindings/js/JSDOMWindowShell.h:
+ * bindings/js/JSDatabaseCustom.cpp:
+ * bindings/js/JSDocumentCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/js/JSEventCustom.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventTarget.cpp:
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ * bindings/js/JSHTMLAllCollection.h:
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ * bindings/js/JSHTMLSelectElementCustom.h:
+ * bindings/js/JSHistoryCustom.cpp:
+ * bindings/js/JSImageDataCustom.cpp:
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ * bindings/js/JSInspectedObjectWrapper.h:
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ * bindings/js/JSLocationCustom.cpp:
+ * bindings/js/JSMessagePortCustom.cpp:
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ * bindings/js/JSNamedNodesCollection.cpp:
+ * bindings/js/JSNamedNodesCollection.h:
+ * bindings/js/JSNavigatorCustom.cpp:
+ * bindings/js/JSNodeCustom.cpp:
+ * bindings/js/JSNodeFilterCondition.cpp:
+ * bindings/js/JSNodeFilterCustom.cpp:
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ * bindings/js/JSNodeListCustom.cpp:
+ * bindings/js/JSPluginArrayCustom.cpp:
+ * bindings/js/JSPluginCustom.cpp:
+ * bindings/js/JSPluginElementFunctions.cpp:
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ * bindings/js/JSRGBColor.cpp:
+ * bindings/js/JSRGBColor.h:
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ * bindings/js/JSSVGLengthCustom.cpp:
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ * bindings/js/JSSVGPointListCustom.cpp:
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ * bindings/js/JSStorageCustom.cpp:
+ * bindings/js/JSStyleSheetCustom.cpp:
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ * bindings/js/JSTextCustom.cpp:
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ * bindings/js/ScheduledAction.cpp:
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptController.cpp:
+ * bindings/js/ScriptController.h:
+ * bindings/objc/WebScriptObject.mm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/c/c_instance.cpp:
+ * bridge/c/c_instance.h:
+ * bridge/c/c_runtime.cpp:
+ * bridge/c/c_runtime.h:
+ * bridge/c/c_utility.cpp:
+ * bridge/jni/jni_instance.cpp:
+ * bridge/jni/jni_instance.h:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/jni/jni_objc.mm:
+ * bridge/jni/jni_runtime.cpp:
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ * bridge/objc/objc_class.mm:
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ * bridge/runtime.h:
+ * bridge/runtime_array.cpp:
+ * bridge/runtime_array.h:
+ * bridge/runtime_method.cpp:
+ * bridge/runtime_method.h:
+ * bridge/runtime_object.cpp:
+ * bridge/runtime_object.h:
+ * inspector/JavaScriptCallFrame.cpp:
+ * inspector/JavaScriptCallFrame.h:
+ * inspector/JavaScriptProfile.cpp:
+ * inspector/JavaScriptProfileNode.cpp:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+ * page/Console.cpp:
+ * page/Console.h:
+ * plugins/MimeTypeArray.h:
+ * plugins/Plugin.h:
+ * plugins/PluginArray.h:
+ * xml/XMLHttpRequest.cpp:
+ Replace JSValue* with JSValuePtr.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - first step of https://bugs.webkit.org/show_bug.cgi?id=21732
+ improve performance by eliminating JSValue as a base class for JSCell
+
+ Update for change to make PreferredPrimitiveType no longer
+ a member of JSValue.
+
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::defaultValue): Removed JSValue:: prefix.
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::defaultValue): Ditto.
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::defaultValue): Ditto.
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::defaultValue): Ditto.
+ * bridge/runtime.h: Ditto. Also removed typedef.
+
+2008-10-18 Darin Adler <darin@apple.com>
+
+ - try to fix Windows build
+
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::paintCheckbox): Explicitly qualify part name with
+ SafariTheme namespace, since there is now an identically named constant in
+ the ControlPart enum.
+ (WebCore::RenderThemeSafari::paintButton): Ditto.
+ (WebCore::RenderThemeSafari::paintTextField): Ditto.
+ (WebCore::RenderThemeSafari::paintTextArea): Ditto.
+ (WebCore::RenderThemeSafari::paintSearchField): Ditto.
+ (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto.
+ (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto.
+ (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
+
+2008-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Alp Toker.
+
+ [GTK] crash after selecting a file on an <input type=file>
+ https://bugs.webkit.org/show_bug.cgi?id=21385
+
+ Follow Mac and Win's behaviors for Icon::paint
+
+ * platform/graphics/gtk/IconGtk.cpp:
+ (WebCore::Icon::paint): check if painting is enabled before
+ painting the icon
+
+2008-10-18 Zan Dobersek <zandobersek@gmail.com>
+
+ Reviewed by Oliver Hunt.
+
+ Qt port build fix.
+
+ * platform/qt/RenderThemeQt.h:
+
+2008-10-17 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier
+
+ Fix wx port's scrollbar and drawing handling after recent changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21720
+
+ * platform/ScrollView.h:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformVisibleContentRect):
+ (WebCore::ScrollView::platformContentsSize):
+ (WebCore::ScrollView::platformSetContentsSize):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::paint):
+
+2008-10-17 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. EAppearance -> ControlPart.
+
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::isControlStyled):
+ (WebCore::RenderThemeWx::adjustRepaintRect):
+ (WebCore::RenderThemeWx::controlSupportsTints):
+ (WebCore::RenderThemeWx::supportsFocus):
+ (WebCore::RenderThemeWx::paintButton):
+
+2008-10-17 David Hyatt <hyatt@apple.com>
+
+ Eliminate the EAppearance enum in favor of the new ControlPart enum. Cut out the scrollbar
+ values from the enum since they are handled by ScrollbarTheme instead.
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator ControlPart):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * css/CSSValueKeywords.in:
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::supportsFocus):
+ (WebCore::RenderThemeGtk::baselinePosition):
+ (WebCore::setToggleSize):
+ (WebCore::RenderThemeGtk::setCheckboxSize):
+ (WebCore::RenderThemeGtk::setRadioSize):
+ (WebCore::RenderThemeGtk::adjustButtonStyle):
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::baselinePosition):
+ (WebCore::RenderThemeQt::controlSupportsTints):
+ (WebCore::RenderThemeQt::adjustRepaintRect):
+ (WebCore::RenderThemeQt::isControlStyled):
+ (WebCore::computeSizeBasedOnStyle):
+ (WebCore::RenderThemeQt::paintButton):
+ (WebCore::RenderThemeQt::paintTextField):
+ (WebCore::RenderThemeQt::paintMenuList):
+ (WebCore::RenderThemeQt::supportsFocus):
+ (WebCore::RenderThemeQt::applyTheme):
+ (WebCore::RenderThemeQt::adjustSliderThumbSize):
+ * platform/qt/RenderThemeQt.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::createThumbStyle):
+ (WebCore::RenderSlider::layout):
+ (WebCore::RenderSlider::setValueForPosition):
+ (WebCore::RenderSlider::setPositionFromValue):
+ (WebCore::RenderSlider::positionForOffset):
+ (WebCore::RenderSlider::currentPosition):
+ (WebCore::RenderSlider::setCurrentPosition):
+ (WebCore::RenderSlider::trackSize):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ (WebCore::RenderTheme::paint):
+ (WebCore::RenderTheme::paintBorderOnly):
+ (WebCore::RenderTheme::paintDecorations):
+ (WebCore::RenderTheme::isControlContainer):
+ (WebCore::RenderTheme::isControlStyled):
+ (WebCore::RenderTheme::supportsFocusRing):
+ (WebCore::RenderTheme::isDefault):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::isControlStyled):
+ (WebCore::RenderThemeMac::adjustRepaintRect):
+ (WebCore::RenderThemeMac::baselinePosition):
+ (WebCore::RenderThemeMac::controlSupportsTints):
+ (WebCore::RenderThemeMac::adjustButtonStyle):
+ (WebCore::RenderThemeMac::setButtonCellState):
+ (WebCore::RenderThemeMac::popupInternalPaddingLeft):
+ (WebCore::RenderThemeMac::popupInternalPaddingRight):
+ (WebCore::RenderThemeMac::popupInternalPaddingTop):
+ (WebCore::RenderThemeMac::popupInternalPaddingBottom):
+ (WebCore::RenderThemeMac::paintSliderTrack):
+ (WebCore::RenderThemeMac::paintSliderThumb):
+ (WebCore::RenderThemeMac::adjustSliderThumbSize):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::isControlStyled):
+ (WebCore::RenderThemeSafari::adjustRepaintRect):
+ (WebCore::RenderThemeSafari::baselinePosition):
+ (WebCore::RenderThemeSafari::controlSupportsTints):
+ (WebCore::RenderThemeSafari::adjustButtonStyle):
+ (WebCore::RenderThemeSafari::popupInternalPaddingLeft):
+ (WebCore::RenderThemeSafari::popupInternalPaddingRight):
+ (WebCore::RenderThemeSafari::popupInternalPaddingTop):
+ (WebCore::RenderThemeSafari::popupInternalPaddingBottom):
+ (WebCore::RenderThemeSafari::paintSliderTrack):
+ (WebCore::RenderThemeSafari::adjustSliderThumbSize):
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::supportsFocus):
+ (WebCore::RenderThemeWin::determineClassicState):
+ (WebCore::RenderThemeWin::getClassicThemeData):
+ (WebCore::RenderThemeWin::getThemeData):
+ (WebCore::drawControl):
+ (WebCore::RenderThemeWin::paintSliderTrack):
+ (WebCore::RenderThemeWin::adjustSliderThumbSize):
+ * rendering/RenderThemeWin.h:
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::hasAppearance):
+ (WebCore::InheritedFlags::appearance):
+ (WebCore::InheritedFlags::setAppearance):
+ (WebCore::InheritedFlags::initialAppearance):
+ * rendering/style/RenderStyleConstants.h:
+
+2008-10-17 David Hyatt <hyatt@apple.com>
+
+ Beginning of the RenderTheme re-architecture (to share more code). Add the new Theme API header
+ file. Add new USE(NEW_THEME) switch that is enabled on Mac. The Mac theme will be converted first.
+
+ Reviewed by Tim Hatcher
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * config.h:
+ * platform/Theme.h: Added.
+ (WebCore::Theme::Theme):
+ (WebCore::Theme::~Theme):
+ (WebCore::Theme::baselinePositionAdjustment):
+ (WebCore::Theme::controlHasInactiveAppearance):
+ (WebCore::Theme::controlsCanHaveInactiveAppearance):
+ (WebCore::Theme::controlsCanHaveHoveredAppearance):
+ (WebCore::Theme::controlDrawsBorder):
+ (WebCore::Theme::controlDrawsBackground):
+ (WebCore::Theme::controlDrawsFocusOutline):
+ (WebCore::Theme::selectionColor):
+ (WebCore::Theme::textSearchHighlightColor):
+ (WebCore::Theme::systemColor):
+ (WebCore::Theme::systemFont):
+ (WebCore::Theme::caretBlinkFrequency):
+ (WebCore::Theme::themeChanged):
+ (WebCore::Theme::controlSize):
+ (WebCore::Theme::controlFont):
+ (WebCore::Theme::controlPadding):
+ (WebCore::Theme::controlInternalPadding):
+ (WebCore::Theme::controlBorder):
+ (WebCore::Theme::controlBorderRadius):
+ (WebCore::Theme::paint):
+ (WebCore::Theme::inflateControlPaintRect):
+ * platform/ThemeTypes.h: Added.
+ (WebCore::):
+ (WebCore::ControlBox::ControlBox):
+ (WebCore::ControlBox::top):
+ (WebCore::ControlBox::right):
+ (WebCore::ControlBox::bottom):
+ (WebCore::ControlBox::left):
+ * platform/mac/ThemeMac.h: Added.
+ (WebCore::ThemeMac::ThemeMac):
+ (WebCore::ThemeMac::~ThemeMac):
+ * platform/mac/ThemeMac.mm: Added.
+ (WebCore::platformTheme):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::RenderTheme):
+ * rendering/RenderTheme.h:
+
+2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Sam Weinig. Landed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21603
+ [GTK] Minor fixes to GOwnPtr
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::mediaPlayerPrivateErrorCallback):
+
+2008-10-17 Timothy Hatcher <timothy@apple.com>
+
+ Recompile the JavaScript functions when removing any listener, so functions that are
+ not being debugged can resume normal speed again.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21715
+
+ Reviewed by Geoffrey Garen.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::globalExec): Changed an assert into an if check. This assert
+ was firing when closing the window and having the recompile fire after. This was an
+ overzelious assert now.
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::didRemoveListener): Start the recompile timer.
+ (WebCore::JavaScriptDebugServer::didRemoveLastListener): Removed the recompile timer start.
+
+2008-10-17 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a regression where starting a debugging session in
+ another Web Inspector window would not show any scripts.
+ Also only attach the debugger to only the required Pages.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21708
+
+ Reviewed by Darin Adler.
+
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::addListener): Add an assert and
+ remove the call to willAddFirstListener(). Add a call to
+ didAddListener().
+ (WebCore::JavaScriptDebugServer::removeListener): Add an assert
+ and call to didRemoveListener().
+ (WebCore::JavaScriptDebugServer::pageCreated): Attach the debugger
+ if there is a listener interested in the new Page.
+ (WebCore::JavaScriptDebugServer::hasListenersInterestedInPage):
+ Use hasGlobalListeners() instead of isEmpty().
+ (WebCore::JavaScriptDebugServer::sourceParsed): Ditto.
+ (WebCore::JavaScriptDebugServer::didAddListener): Added. Attach the
+ debugger to the page if non-null, or all pages if page is null.
+ (WebCore::JavaScriptDebugServer::didRemoveListener): Added. Detach
+ the debugger only if there are no interested listeners.
+ (WebCore::JavaScriptDebugServer::didRemoveLastListener): Remove the
+ call to Page::setDebuggerForAllPages().
+ * inspector/JavaScriptDebugServer.h:
+ (WebCore::JavaScriptDebugServer::hasGlobalListeners): Added.
+
+2008-10-15 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Have ImageDocument generate its own filename for the title of images
+ without relying on the suggested filename from the network layer, which
+ may be nonexistant or not relevant.
+ https://bugs.webkit.org/show_bug.cgi?id=21565
+
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageTokenizer::finish):
+
+2008-10-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Non-Mac build fix.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+ Added ActiveDOMObject to the build.
+
+2008-10-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21642
+ Abstract out active object tracking
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::markActiveObjectsForDocument):
+ * dom/ActiveDOMObject.cpp: Added.
+ (WebCore::ActiveDOMObject::ActiveDOMObject):
+ (WebCore::ActiveDOMObject::~ActiveDOMObject):
+ (WebCore::ActiveDOMObject::contextDestroyed):
+ (WebCore::ActiveDOMObject::stop):
+ * dom/ActiveDOMObject.h: Added.
+ (WebCore::ActiveDOMObject::document):
+ (WebCore::ActiveDOMObject::hasPendingActivity):
+ (WebCore::ActiveDOMObject::setPendingActivity):
+ (WebCore::ActiveDOMObject::unsetPendingActivity):
+ * dom/Document.cpp:
+ (WebCore::Document::~Document):
+ (WebCore::Document::stopActiveDOMObjects):
+ (WebCore::Document::createdActiveDOMObject):
+ (WebCore::Document::destroyedActiveDOMObject):
+ * dom/Document.h:
+ (WebCore::Document::activeDOMObjects):
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::contextDestroyed):
+ * dom/MessagePort.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::~XMLHttpRequest):
+ (WebCore::XMLHttpRequest::associatedFrame):
+ (WebCore::XMLHttpRequest::responseXML):
+ (WebCore::XMLHttpRequest::callReadyStateChangeListener):
+ (WebCore::XMLHttpRequest::initSend):
+ (WebCore::XMLHttpRequest::send):
+ (WebCore::XMLHttpRequest::createRequest):
+ (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
+ (WebCore::XMLHttpRequest::loadRequestSynchronously):
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::dropProtection):
+ (WebCore::XMLHttpRequest::setRequestHeader):
+ (WebCore::XMLHttpRequest::processSyncLoadResults):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
+ (WebCore::XMLHttpRequest::willSendRequest):
+ (WebCore::XMLHttpRequest::accessControlCheck):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+ (WebCore::XMLHttpRequest::stop):
+ (WebCore::XMLHttpRequest::contextDestroyed):
+ * xml/XMLHttpRequest.h:
+ Move activity tracking to a new ActiveDOMObject class.
+
+2008-10-16 David Hyatt <hyatt@apple.com>
+
+ Simplify styleForRenderer to avoid confusion. Callers in the SVG filter code thought "forRenderer" meant
+ they would be given a style that corresponded to the RenderObject* passed in. This is not what the code
+ did though. This patch removes the renderer argument and the Element subclass shadow implementation
+ so that confusion like this can't occur again.
+
+ Reviewed by Oliver Hunt
+
+ * dom/Element.cpp:
+ * dom/Element.h:
+ * dom/Node.cpp:
+ (WebCore::Node::createRendererIfNeeded):
+ (WebCore::Node::styleForRenderer):
+ * dom/Node.h:
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::attach):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::attach):
+ * svg/SVGClipPathElement.cpp:
+ (WebCore::SVGClipPathElement::canvasResource):
+ * svg/SVGFEDiffuseLightingElement.cpp:
+ (WebCore::SVGFEDiffuseLightingElement::build):
+ * svg/SVGFEFloodElement.cpp:
+ (WebCore::SVGFEFloodElement::build):
+ * svg/SVGFESpecularLightingElement.cpp:
+ (WebCore::SVGFESpecularLightingElement::build):
+ * svg/SVGGradientElement.cpp:
+ (WebCore::SVGGradientElement::buildStops):
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::attachShadowTree):
+
+2008-10-16 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/attachment.cgi?bugid=21647
+
+ Make RenderStyle inherit from RefCounted so that it works with RefPtr. RenderStyle was being malloced
+ out of the RenderArena. Years and years ago (before TCMalloc), the plan was to make RenderStyles and
+ all their associated sub-structs use the arena. However only the RenderStyle itself was ever changed
+ to use the arena.
+
+ At a later point style sharing was implemented, which made using the arena for styles pretty pointless,
+ as the bulk of the styles on a given page are actually shared. Not ever making the sub-structs use the
+ arena also limited the usefulness.
+
+ Now that we have RefPtr/PassRefPtr to eliminate manual ref/deref and now that we use TCMalloc for fast
+ mallocs, there is no reason to keep RenderStyles in the arena. The benefits of being able to eliminate
+ manual ref/deref far outweigh keeping them in the arena.
+
+ Reviewed by Adam Roben
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::CSSStyleSelector):
+ (WebCore::CSSStyleSelector::~CSSStyleSelector):
+ (WebCore::CSSStyleSelector::styleForElement):
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
+ (WebCore::CSSStyleSelector::pseudoStyleForElement):
+ These methods now return a PassRefPtr. They will null out the m_style variable as they hand it back
+ so that it isn't left pointing to the previous style resolve RenderStyle (which is what the old code did).
+
+ (WebCore::CSSStyleSelector::updateFont):
+ (WebCore::CSSStyleSelector::checkSelector):
+ (WebCore::CSSStyleSelector::applyProperty):
+ (WebCore::CSSStyleSelector::mapFillSize):
+ (WebCore::CSSStyleSelector::mapFillXPosition):
+ (WebCore::CSSStyleSelector::mapFillYPosition):
+ * css/CSSStyleSelector.h:
+ (WebCore::CSSStyleSelector::style):
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ * dom/Element.cpp:
+ (WebCore::Element::styleForRenderer):
+ (WebCore::Element::recalcStyle):
+ (WebCore::Element::computedStyle):
+ * dom/Element.h:
+ * dom/ElementRareData.h:
+ (WebCore::ElementRareData::ElementRareData):
+ (WebCore::ElementRareData::resetComputedStyle):
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ (WebCore::Node::createRendererIfNeeded):
+ (WebCore::Node::styleForRenderer):
+ (WebCore::Node::setRenderStyle):
+ * dom/Node.h:
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setFont):
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::attach):
+ (WebCore::HTMLOptGroupElement::detach):
+ (WebCore::HTMLOptGroupElement::setRenderStyle):
+ (WebCore::HTMLOptGroupElement::nonRendererRenderStyle):
+ * html/HTMLOptGroupElement.h:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::attach):
+ (WebCore::HTMLOptionElement::detach):
+ (WebCore::HTMLOptionElement::setRenderStyle):
+ (WebCore::HTMLOptionElement::nonRendererRenderStyle):
+ * html/HTMLOptionElement.h:
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::animate):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationController::updateAnimations):
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
+ (WebCore::CompositeAnimationPrivate::animate):
+ (WebCore::CompositeAnimation::animate):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::ImplicitAnimation):
+ (WebCore::ImplicitAnimation::~ImplicitAnimation):
+ (WebCore::ImplicitAnimation::animate):
+ (WebCore::ImplicitAnimation::reset):
+ (WebCore::ImplicitAnimation::isTargetPropertyEqual):
+ (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
+ * page/animation/ImplicitAnimation.h:
+ (WebCore::ImplicitAnimation::create):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::KeyframeAnimation):
+ (WebCore::KeyframeAnimation::~KeyframeAnimation):
+ (WebCore::KeyframeAnimation::animate):
+ (WebCore::KeyframeAnimation::validateTransformFunctionList):
+ * page/animation/KeyframeAnimation.h:
+ (WebCore::KeyframeAnimation::create):
+ (WebCore::KeyframeAnimation::unanimatedStyle):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
+ (WebCore::MediaControlInputElement::MediaControlInputElement):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleDidChange):
+ (WebCore::RenderBlock::updateFirstLetter):
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::addChild):
+ (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::updateFromElement):
+ (WebCore::RenderFileUploadControl::createButtonStyle):
+ * rendering/RenderFileUploadControl.h:
+ * rendering/RenderFlow.cpp:
+ (WebCore::RenderFlow::createAnonymousFlow):
+ * rendering/RenderFlow.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::addChildToFlow):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateScrollCornerStyle):
+ (WebCore::RenderLayer::updateResizerStyle):
+ (WebCore::RenderLayer::updateReflectionStyle):
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::styleDidChange):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::createPanel):
+ (WebCore::RenderMedia::createTimeDisplay):
+ (WebCore::RenderMedia::changeOpacity):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::selectionBackgroundColor):
+ (WebCore::RenderObject::selectionForegroundColor):
+ (WebCore::RenderObject::createAnonymousBlock):
+ (WebCore::RenderObject::setAnimatableStyle):
+ (WebCore::RenderObject::setStyle):
+ (WebCore::RenderObject::setStyleInternal):
+ (WebCore::RenderObject::arenaDelete):
+ (WebCore::RenderObject::firstLineStyle):
+ (WebCore::RenderObject::getPseudoStyle):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::style):
+ * rendering/RenderSVGBlock.cpp:
+ (WebCore::RenderSVGBlock::setStyle):
+ * rendering/RenderSVGBlock.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::styleDidChange):
+ (WebCore::RenderSlider::createThumbStyle):
+ (WebCore::RenderSlider::updateFromElement):
+ * rendering/RenderSlider.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::addChild):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::addChild):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ (WebCore::RenderTextControl::createInnerBlockStyle):
+ (WebCore::RenderTextControl::createInnerTextStyle):
+ (WebCore::RenderTextControl::createResultsButtonStyle):
+ (WebCore::RenderTextControl::createCancelButtonStyle):
+ (WebCore::RenderTextControl::createSubtreeIfNeeded):
+ (WebCore::RenderTextControl::updatePlaceholderVisibility):
+ * rendering/RenderTextControl.h:
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerElement::attachInnerElement):
+ * rendering/TextControlInnerElements.h:
+ * rendering/style/KeyframeList.cpp:
+ (WebCore::KeyframeList::clear):
+ (WebCore::KeyframeList::operator==):
+ (WebCore::KeyframeList::insert):
+ * rendering/style/KeyframeList.h:
+ (WebCore::KeyframeValue::KeyframeValue):
+ (WebCore::KeyframeValue::~KeyframeValue):
+ (WebCore::KeyframeValue::key):
+ (WebCore::KeyframeValue::style):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::defaultStyle):
+ (WebCore::RenderStyle::create):
+ (WebCore::RenderStyle::createDefaultStyle):
+ (WebCore::RenderStyle::clone):
+ (WebCore::RenderStyle::RenderStyle):
+ (WebCore::RenderStyle::getCachedPseudoStyle):
+ (WebCore::RenderStyle::addCachedPseudoStyle):
+ * rendering/style/RenderStyle.h:
+ (WebCore::):
+ (WebCore::InheritedFlags::operator!=):
+ * svg/SVGClipPathElement.cpp:
+ (WebCore::SVGClipPathElement::canvasResource):
+ * svg/SVGGradientElement.cpp:
+ (WebCore::SVGGradientElement::buildStops):
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::resolveStyle):
+ * svg/SVGStyledElement.h:
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::recalcStyle):
+ (WebCore::SVGUseElement::attachShadowTree):
+
+2008-10-16 Kenneth Russell <kenneth.russell@sun.com>
+
+ Reviewed and landed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21587
+ NPN_PluginThreadAsyncCall does not work properly
+
+ * plugins/PluginMainThreadScheduler.cpp:
+ (WebCore::PluginMainThreadScheduler::dispatchCalls):
+ Make sure to set m_callPending to false once the queue has been cleared.
+
+2008-10-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21609
+ Make MessagePorts protect their peers across heaps
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::MessagePort):
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::setJSWrapperIsKnownToBeInaccessible):
+ (WebCore::MessagePort::jsWrapperIsKnownToBeInaccessible):
+ Track objects whose JS wrappers are no longer reachable in MessagePort. Unfortunately, this
+ means that the implementation object knows about JS bindings - but it is not possible to
+ access JS wrappers from another heap/thread.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::markCrossHeapDependentObjectsForDocument):
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::markCrossHeapDependentObjects):
+ * bindings/js/JSDOMWindowBase.h:
+ Implement cross-heap dependency tracking for entangled MessagePorts. If a wrapper object
+ hasn't been marked normally, it is marked as inaccessible. It is then marked manually,
+ as long as its entangled port is accessible itself.
+
+2008-10-15 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Remove unneeded check of whether a Page defers loading before running it
+ in a modal dialog.
+
+ No test possible.
+
+ Reviewed by Tim Hatcher.
+
+ * page/Chrome.cpp:
+
+2008-10-15 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
+ Start the debugger without reloading the inspected page
+
+ * WebCore.base.exp: New symbols.
+
+ * ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
+ * ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
+ * WebCore.xcodeproj/project.pbxproj: New forwarding headers.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::setWindowVisible):
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ (WebCore::InspectorController::startDebugging):
+ * inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage
+ to startDebugging, and changed its behavior to match.
+
+ * inspector/JavaScriptDebugListener.h:
+ * inspector/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::JavaScriptDebugServer):
+ (WebCore::JavaScriptDebugServer::addListener):
+ (WebCore::JavaScriptDebugServer::removeListener):
+ (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+ (WebCore::JavaScriptDebugServer::willAddFirstListener):
+ (WebCore::JavaScriptDebugServer::didRemoveLastListener):
+ * inspector/JavaScriptDebugServer.h: Refactored the
+ JavaScriptDebugServer to centralize handling of adding the first listener
+ and removing the last. Then, added a feature to recompile all JS functions
+ in these cases. This allows us to dynamically add and remove hooks like
+ the debugger hooks without reloading the page.
+
+ * inspector/front-end/ScriptsPanel.js:
+ * English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage =>
+ startDebugging rename. Removed all UI that claimed that starting the
+ debugger would reload the page.
+
+2008-10-15 Adele Peterson <adele@apple.com>
+
+ Attempt to fix the Tiger build.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+
+2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix attempt.
+
+ Try to fix static/non-static declaration of g_string_append_uri_escape
+ by renaming that string. Another look needs to be taken.
+
+ * platform/gtk/guriescape.c:
+ (_webcore_g_string_append_uri_escaped):
+ (_webcore_g_uri_escape_string):
+
+2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ m_animatingImageType is gone.
+
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+
+2008-10-15 Jeff Cook <cookiecaper@gmail.com>
+
+ Reviewed by Holger Freyther.
+
+ Stop SIGSEGV when leaving a page with a Flash object by reordering
+ window destruction and plugin stop.
+
+ See https://bugs.webkit.org/show_bug.cgi?id=20779
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::stop):
+
+2008-10-15 Adele Peterson <adele@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.
+
+ * platform/network/ResourceHandle.h:
+ * platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::cancel):
+ (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
+ (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
+
+2008-10-15 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ Qt build bustage fix.
+
+ * platform/graphics/qt/StillImageQt.h:
+ (WebCore::StillImage::destroyDecodedData):
+
+2008-10-15 David Hyatt <hyatt@apple.com>
+
+ Make sure scrollbar styles get deleted if they aren't assigned to a renderer.
+
+ Reviewed by Mark Rowe
+
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+
+2008-10-15 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
+ Account for paint and timer lag when animating images. Also pretend
+ that images whose animations were paused (by becoming invisible)
+ continued to animate, by "catching up" to the correct frame when they're
+ shown again.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::destroyDecodedData):
+ (WebCore::BitmapImage::cacheFrame):
+ (WebCore::BitmapImage::frameIsCompleteAtIndex):
+ (WebCore::BitmapImage::frameDurationAtIndex):
+ (WebCore::BitmapImage::frameHasAlphaAtIndex):
+ (WebCore::BitmapImage::repetitionCount):
+ (WebCore::BitmapImage::shouldAnimate):
+ (WebCore::BitmapImage::startAnimation):
+ (WebCore::BitmapImage::resetAnimation):
+ (WebCore::BitmapImage::advanceAnimation):
+ (WebCore::BitmapImage::internalAdvanceAnimation):
+ (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::FrameData::FrameData):
+ (WebCore::BitmapImage::):
+ * platform/graphics/GeneratedImage.h:
+ (WebCore::GeneratedImage::destroyDecodedData):
+ * platform/graphics/Image.h:
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::FrameData::clear):
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::FrameData::clear):
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/cg/PDFDocumentImage.h:
+ (WebCore::PDFDocumentImage::destroyDecodedData):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::FrameData::clear):
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::FrameData::clear):
+ (WebCore::BitmapImage::draw):
+ * svg/graphics/SVGImage.h:
+ (WebCore::SVGImage::destroyDecodedData):
+
+2008-10-14 Maxime Britto <britto@apple.com>
+
+ Reviewed by Darin Adler, tweaked and landed by Beth.
+
+ * WebCore.base.exp: Exposes two functions to be able to create a
+ selection from a point on the screen. Also exposes the new
+ TextIterator::currentNode function.
+ * WebCore/editing/TextIterator.cpp:
+ (TextIterator::currentNode) : New function that returns the current
+ text node or NULL if there is no text node.
+
+2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=21211
+ [CURL] Upload doesn't work because cancel is called
+
+ FormDataStream::read returns 0 when retrieving data from the form
+ fails, but also when there is no more data to send. This means that
+ ResourceHandleManager::cancel is always called even when the data was
+ successfully sent.
+
+ Check if there are more elements in the form before calling
+ FormDataStream::read.
+
+ * platform/network/curl/FormDataStreamCurl.cpp:
+ (WebCore::FormDataStream::hasMoreElements):
+ * platform/network/curl/FormDataStreamCurl.h:
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::readCallback):
+
+2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=20664
+ [GTK] File names are not always encodable in UTF-8
+
+ On Linux file names are just raw data and cannot always be directly
+ encoded in UTF-8 or in any other encodings, so we escape them before
+ storing the file name in a String and unescape them before passing
+ them to native functions handling files.
+
+ * GNUmakefile.am:
+ * platform/FileSystem.h:
+ * platform/gtk/FileChooserGtk.cpp:
+ (WebCore::stringByAdoptingFileSystemRepresentation):
+ (WebCore::FileChooser::basenameForWidth):
+ * platform/gtk/FileSystemGtk.cpp:
+ (WebCore::filenameToString):
+ (WebCore::filenameFromString):
+ (WebCore::filenameForDisplay):
+ (WebCore::fileExists):
+ (WebCore::deleteFile):
+ (WebCore::deleteEmptyDirectory):
+ (WebCore::getFileSize):
+ (WebCore::getFileModificationTime):
+ (WebCore::makeAllDirectories):
+ (WebCore::homeDirectoryPath):
+ (WebCore::pathGetFileName):
+ (WebCore::listDirectory):
+ * platform/gtk/KURLGtk.cpp:
+ (WebCore::KURL::fileSystemPath):
+ * platform/gtk/SharedBufferGtk.cpp:
+ (WebCore::SharedBuffer::createWithContentsOfFile):
+ * platform/gtk/guriescape.c: Added.
+ (is_valid):
+ (gunichar_ok):
+ (g_string_append_uri_escaped):
+ (_webcore_g_uri_escape_string):
+ * platform/gtk/guriescape.h: Added.
+
+2008-10-15 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ - part of https://bugs.webkit.org/show_bug.cgi?id=20543
+ Moved gradient spread method out of SVG into the GraphicsContext.
+
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::spreadMethod):
+ (WebCore::GraphicsContext::setSpreadMethod):
+ * platform/graphics/GraphicsContext.h:
+ (WebCore::):
+ * platform/graphics/GraphicsContextPrivate.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::applySpreadMethod):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::applySpreadMethod):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ * svg/GradientAttributes.h:
+ (WebCore::GradientAttributes::GradientAttributes):
+ (WebCore::GradientAttributes::spreadMethod):
+ (WebCore::GradientAttributes::setSpreadMethod):
+ * svg/SVGGradientElement.cpp:
+ (WebCore::SVGGradientElement::parseMappedAttribute):
+ * svg/SVGGradientElement.h:
+ * svg/SVGLinearGradientElement.cpp:
+ (WebCore::SVGLinearGradientElement::collectGradientProperties):
+ * svg/SVGRadialGradientElement.cpp:
+ (WebCore::SVGRadialGradientElement::collectGradientProperties):
+ * svg/graphics/SVGPaintServerGradient.cpp:
+ (WebCore::operator<<):
+ (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
+ (WebCore::SVGPaintServerGradient::spreadMethod):
+ (WebCore::SVGPaintServerGradient::setGradientSpreadMethod):
+ (WebCore::SVGPaintServerGradient::externalRepresentation):
+ * svg/graphics/SVGPaintServerGradient.h:
+ * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
+ (WebCore::SVGPaintServerGradient::setup):
+ * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
+ (WebCore::SVGPaintServerGradient::setup):
+
+2008-10-09 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ Make pan scrolling a platform configurable option
+ https://bugs.webkit.org/show_bug.cgi?id=21515
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleAutoscroll):
+ (WebCore::EventHandler::autoscrollTimerFired):
+ (WebCore::EventHandler::stopAutoscrollTimer):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::keyEvent):
+
+2008-10-10 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add some PLATFORM(CHROMIUM) ifdefs to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=21511
+
+ * loader/FTPDirectoryDocument.cpp:
+ * loader/FTPDirectoryParser.cpp:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::finishedLoadingDocument):
+ * platform/ContextMenuItem.h:
+ * platform/Cursor.h:
+ * platform/DragData.h:
+ * platform/DragImage.h:
+ * platform/Pasteboard.h:
+ * platform/PlatformKeyboardEvent.h:
+ (WebCore::PlatformKeyboardEvent::isSystemKey):
+ * platform/PlatformMenuDescription.h:
+ * platform/PlatformMouseEvent.h:
+ * platform/PlatformWheelEvent.h:
+ * platform/PopupMenu.h:
+ * platform/ScrollView.h:
+ * platform/Widget.h:
+ * platform/network/NetworkStateNotifier.h:
+
+2008-10-14 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
+ Optimize keyframe style sheet changes by avoiding styleSheetChanged()
+
+ Test: css3/change-keyframes.html
+
+ * css/WebKitCSSKeyframesRule.cpp:
+ (WebCore::WebKitCSSKeyframesRule::append):
+ (WebCore::WebKitCSSKeyframesRule::deleteRule):
+
+2008-10-14 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21595
+
+ Clean up background and overflow propagation from the body to the viewport. Make it match the
+ latest CSS2.1 spec thinking.
+
+ Reviewed by Adam Roben
+
+ Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
+ (available at http://simon.html5.org/test/css/magic-body/).
+
+ * dom/Document.cpp:
+ (WebCore::Document::body):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::layout):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+ (WebCore::RenderBox::paintRootBoxDecorations):
+ (WebCore::RenderBox::paintBoxDecorations):
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+
+2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed and landed by Sam Weinig.
+
+ Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
+ remove NSResolver code, leaving only checking for selectors that need
+ NS resolution and throwing a coresponding error.
+
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSDocumentCustom.cpp:
+ * bindings/js/JSDocumentFragmentCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/js/JSNSResolver.cpp: Removed.
+ * bindings/js/JSNSResolver.h: Removed.
+ * dom/Document.idl:
+ * dom/DocumentFragment.idl:
+ * dom/Element.idl:
+ * dom/NSResolver.h: Removed.
+ * dom/NSResolver.idl: Removed.
+ * dom/Node.h:
+ * dom/Node.cpp:
+ (WebCore::forEachTagSelector):
+ (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
+ (WebCore::selectorNeedsNamespaceResolution):
+ (WebCore::Node::querySelector):
+ (WebCore::Node::querySelectorAll):
+
+2008-10-14 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig (all but the FormDataListItem rename).
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21593
+ Bug 21593: add multiple-file support to HTMLFormElement
+
+ * html/FormDataList.cpp: Removed appendFile since it's now inline.
+ Also took incorrect old copyrights off of this file that are left
+ over from when it was split.
+ * html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and
+ made it a member of FormDataList. Changed it to hold a File object
+ instead of a path. And made its data members private. Changed
+ FormDataList::appendFile accordingly.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::formData): Updated for above changes.
+ Removed the code that special-cases HTMLInputElement, because now
+ the FormDataListItem has everything we need. And if there are
+ multiple files, we'll get multiple list items for them.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::appendFormData): Changed the code for
+ <input type=file> to use File objects instead of path strings and
+ also to append multiple files if the file list has them.
+
+2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix QtWebKit scrollbar painting errors
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::ScrollbarThemeQt::paint):
+ (WebCore::ScrollbarThemeQt::paintScrollCorner):
+
+2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix scrollbar arrows for horizontal scrollbars
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+
+2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Use style-painter to draw scrollbars in ScrollbarThemeQt
+
+ This has the benefit of setting up the painter properly without
+ antialiasing and saving and restoring the brush. It also ensures
+ that we use the style of the QWebView over the QApplication style
+ if possible.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::StylePainter::StylePainter):
+ (WebCore::StylePainter::init):
+ * platform/qt/RenderThemeQt.h:
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::ScrollbarThemeQt::paint):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
+ for how to add support for the rest.
+
+ Reviewed by Oliver Hunt
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::ensurePropertyMap):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::fillOpacity):
+ (WebCore::RenderStyle::setFillOpacity):
+ (WebCore::RenderStyle::strokeOpacity):
+ (WebCore::RenderStyle::setStrokeOpacity):
+ (WebCore::RenderStyle::floodOpacity):
+ (WebCore::RenderStyle::setFloodOpacity):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ <rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.
+
+ Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
+ implements paintTrackBackground so that when the thumb is not present the track still paints.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::paintTrackBackground):
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Fix over-invalidation of native scrollbars.
+
+ Reviewed by Oliver Hunt
+
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::styleChanged):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::styleChanged):
+
+2008-10-13 Alp Toker <alp@nuanti.com>
+
+ Fix autotools dist build target by listing recently added header
+ files only. Not reviewed.
+
+ * GNUmakefile.am:
+
+2008-10-13 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ Don't run a SQLite query on every iteration of the sync thread when the query
+ will touch a large portion of the icon database while performing no useful work.
+
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
+ we modified the database.
+ (WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
+ unless we've been asked to prune any dangling pageURLs that we find.
+
+2008-10-13 Maciej Stachowiak <mjs@apple.com>
+
+ Rubber stamped by Mark Rowe.
+
+ - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
+
+ * Configurations/DebugRelease.xcconfig:
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Make dropdown lists on Windows work with CSS custom scrollbars.
+
+ Reviewed by Adele
+
+ * platform/PopupMenu.h:
+ (WebCore::PopupMenu::scrollbarCornerPresent):
+ * platform/PopupMenuClient.h:
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::show):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::createScrollbar):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::createScrollbar):
+ * rendering/RenderTextControl.h:
+
+2008-10-13 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements
+
+ Links from image maps were not being included in the web area's AXLinkUIElements attribute.
+ The position of image map links was being reported incorrectly and the parent-chain
+ hierarchy for image map links was incorrect because image map links did not have a reference
+ to their parent image.
+
+ Test: accessibility/document-links.html
+
+ * page/AccessibilityImageMapLink.cpp:
+ (WebCore::AccessibilityImageMapLink::parentObject):
+ (WebCore::AccessibilityImageMapLink::actionElement):
+ (WebCore::AccessibilityImageMapLink::elementRect):
+ * page/AccessibilityImageMapLink.h:
+ (WebCore::AccessibilityImageMapLink::setHTMLMapElement):
+ (WebCore::AccessibilityImageMapLink::setParent):
+ * page/AccessibilityObject.cpp:
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
+ (WebCore::AccessibilityRenderObject::getDocumentLinks):
+ (WebCore::AccessibilityRenderObject::addChildren):
+ * page/AccessibilityRenderObject.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
+ the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
+ idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
+
+ Reviewed by Tim Hatcher
+
+ Added scrollbars/listbox-scrollbar-combinations.html
+
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::~RenderListBox):
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::createScrollbar):
+ (WebCore::RenderListBox::destroyScrollbar):
+ (WebCore::RenderListBox::setHasVerticalScrollbar):
+ * rendering/RenderListBox.h:
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ In order to always match the :corner-present pseudo-class properly, delay initial updating of
+ scrollbar styles until the layer has the scrollbars in its member variables.
+
+ Reviewed by Tim Hatcher
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::setHasHorizontalScrollbar):
+ (WebCore::RenderLayer::setHasVerticalScrollbar):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::RenderScrollbar):
+
+2008-10-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
+ 5 false positive StructureID leaks
+
+ In WebCore, we intentionally leak the common JSGlobalData which in turn
+ leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
+ ignore the StructureIDs leaked within.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::commonJSGlobalData):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
+ artwork based on whether there is a scrollbar corner present.
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollbarCornerPresent):
+ * platform/ScrollView.h:
+ * platform/ScrollbarClient.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::cornerRect):
+ (WebCore::scrollCornerRect):
+ (WebCore::resizerCornerRect):
+ (WebCore::RenderLayer::scrollbarCornerPresent):
+ (WebCore::RenderLayer::setHasHorizontalScrollbar):
+ (WebCore::RenderLayer::setHasVerticalScrollbar):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::horizontalScrollbar):
+ (WebCore::RenderLayer::verticalScrollbar):
+ * rendering/RenderListBox.h:
+ (WebCore::RenderListBox::scrollbarCornerPresent):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
+ test case for all this can land).
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::styleChanged):
+ (WebCore::RenderLayer::updateScrollCornerStyle):
+ (WebCore::RenderLayer::updateResizerStyle):
+ * rendering/RenderLayer.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::paint):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::paintIntoRect):
+
+2008-10-13 David Hyatt <hyatt@apple.com>
+
+ Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
+ and invalidate properly as images load, etc.
+
+ Reviewed by Tim Hatcher
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::cornerRect):
+ (WebCore::scrollCornerRect):
+ (WebCore::resizerCornerRect):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::isPointInResizeControl):
+ (WebCore::RenderLayer::hitTestOverflowControls):
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::setRect):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::styleDidChange):
+ (WebCore::RenderScrollbarPart::imageChanged):
+
+2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Darin Adler. Landed by Jan Alonzo.
+
+ WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
+ http://bugs.webkit.org/show_bug.cgi?id=20483
+
+ Start the conversion to use GOwnPtr and fix a memory leak.
+
+ * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::mediaPlayerPrivateErrorCallback):
+
+2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Windows build fix.
+
+ * loader/TextResourceDecoder.cpp:
+
+2008-10-12 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21229
+ Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)
+
+ * platform/network/NetworkStateNotifier.h: Add the #include.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Based on work by Holger Freyther.
+
+ - part of https://bugs.webkit.org/show_bug.cgi?id=20953
+ Split WidthIterator into its own source file.
+
+ * GNUmakefile.am: Added new source files.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Ditto.
+
+ * platform/graphics/Font.cpp: Use WidthIterator from its new place.
+ * platform/graphics/WidthIterator.cpp: Added.
+ * platform/graphics/WidthIterator.h: Added.
+
+2008-10-12 Tony Chang <tony@chromium.org>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21480
+ Remove duplicate definitions of MimeClassInfo and PluginInfo.
+
+ * plugins/PluginInfoStore.cpp: Added an include.
+ * plugins/PluginInfoStore.h: Removed struct declarations.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21563
+ Bug 21563: platform Gradient class should not use the CSS parser
+
+ * platform/graphics/Gradient.cpp: Removed the overload of addColorStop
+ that accepts a CSS color string. That's handled in the DOM now, not here.
+ (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own
+ copy of it here.
+ * platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
+
+2008-10-12 Glenn Wilson <gwilson@google.com>
+
+ Reviewed by Darin Adler.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20461
+
+ Added feature to allow multi-line inputs into text fields.
+ HTMLInputElement would cut the set text at the first 'system' character,
+ so it would truncate at the first carriage return or newline.
+ This fix modifies that behavior to truncate at any non-space system character
+ but changes \r, \n, and \r\n to a single space.
+
+ Tests: editing/pasteboard/paste-multiline-text-input.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::constrainValue):
+
+2008-10-12 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20435
+
+ Added exception codes to canvas gradients to match current specification.
+
+ Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html
+ fast/canvas/linearGradient-infinite-values.html
+ fast/canvas/radialGradient-infinite-values.html
+
+ * html/CanvasGradient.cpp:
+ (WebCore::CanvasGradient::addColorStop):
+ * html/CanvasGradient.h:
+ * html/CanvasGradient.idl:
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::createLinearGradient):
+ (WebCore::CanvasRenderingContext2D::createRadialGradient):
+ * html/CanvasRenderingContext2D.h:
+ * html/CanvasRenderingContext2D.idl:
+
+2008-10-12 Eric Roman <eroman@chromium.org>
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20246
+ Implement RenderThemeWin::systemColor() to match Windows colors.
+
+ Reviewed by David Hyatt.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::cssValueIdToSysColorIndex):
+ (WebCore::RenderThemeWin::systemColor):
+ * rendering/RenderThemeWin.h:
+
+2008-10-12 Aaron Bockover <abockover@novell.com>
+
+ Reviewed by Alp Toker.
+
+ Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
+ plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
+ handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+
+2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
+
+ Reviewed by Oliver Hunt.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=19331
+ <rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()
+
+ * page/DragController.cpp:
+ (WebCore::DragController::startDrag): When a link is dragged without any
+ text selected (note: for this to work, the EditableLinkBehavior setting must be
+ set to 'live' or 'default') and then dropped into an editable html document it
+ will eventually violate an ASSERT in MoveSelectionCommand that requires that there
+ is a selection. To prevent this, expand the selection to the enclosing anchor tag
+ when the drag begins.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21557
+ Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain
+ until we hit an Element. Nowadays, Node::isElementNode() is just as efficient
+ as RenderObject::isText(), and this guarantees that the node can be cast to
+ Element*, which is done just below. The reason this is hit is that RenderLayer
+ can call getPseudoStyle on a RenderView, which has the document as its
+ element() -- and a document is neither a Text node nor an Element. A loose
+ end is that this seems to mean you can't style the scrollbar corner or the
+ resizer on a RenderView. Hyatt may want to look into that later.
+
+2008-10-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21556
+ Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
+
+ Tests: fast/dom/HTMLFontElement/size-attribute.html
+ fast/dom/HTMLInputElement/size-attribute.html
+ fast/dom/HTMLTableElement/cellpadding-attribute.html
+
+ * html/HTMLFontElement.cpp:
+ (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of
+ Unicode::isDigit, since non-ASCII digits are not valid here.
+ * html/HTMLFontElement.h: Tweaked formatting a bit and removed
+ the unneeded destructor declaration.
+ * platform/text/String.cpp:
+ (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead
+ of Unicode::isDigit, since non-ASCII digits are not valid.
+
+2008-10-12 Jungshik Shin <jshin@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Treat x-user-defined as windows-1252 for html files with meta charset
+ declaration to be compatible with Indian web sites.
+ ( https://bugs.webkit.org/show_bug.cgi?id=18270 )
+
+ Test: fast/encoding/charset-xuser-defined.html
+
+ * loader/TextResourceDecoder.cpp:
+ (WebCore::TextResourceDecoder::setEncoding):
+
+2008-10-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Remove unneeded forward declaration.
+
+ * platform/graphics/ImageBuffer.h:
+
+2008-10-12 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
+ Layering violation: String should not be responsible for creating Lengths
+
+ It was a layering violation for String to know haw to parse
+ into Lengths, LengthArrays, and CoordsArrays.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * platform/text/AtomicString.h:
+ (WebCore::AtomicString::percentage):
+ * platform/text/PlatformString.h:
+ * platform/text/String.cpp:
+ * platform/text/StringImpl.cpp:
+ * platform/text/StringImpl.h:
+ * rendering/Length.cpp: Added.
+ (WebCore::parseLength):
+ (WebCore::countCharacter):
+ (WebCore::newCoordsArray):
+ (WebCore::newLengthArray):
+ * rendering/Length.h:
+ (WebCore::LengthSize::LengthSize):
+
+2008-10-12 Brad Garcia <bgarcia@google.com>
+
+ Reviewed by Darin Adler.
+
+ Interpret fractional percentage values for %MultiLength values.
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
+ Test: fast/frames/frame-length-fractional-percentage.html
+
+ * platform/text/StringImpl.cpp:
+ (WebCore::parseLength):
+
+2008-10-12 Timothy Hatcher <timothy@apple.com>
+
+ Remember the expanded state of the rules in the Styles pane. So
+ collapsing a rule will persist across all the elements that have
+ that same rule. The same applies to Computed Style, so the Computed
+ Style rule is now collapsed by default. This should help lessen the
+ confusion on why Computed Style can't be edited (a common confusion.)
+
+ https://bugs.webkit.org/show_bug.cgi?id=21553
+
+ Reviewed by Darin Adler.
+
+ * inspector/front-end/PropertiesSection.js:
+ (WebInspector.PropertiesSection): Set the _expanded property directly,
+ instead of using the setter. Expanded is the default, so no work is needed.
+ This prevents calling StylesSidebarPane.collapse before object initialization
+ is complete.
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object
+ for the expanded state of the StylePropertiesSection. Collapse computed style
+ by default and expand everything else.
+ (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used
+ when remembering expanded state.
+ (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state
+ to true for this identifier in Preferences.styleRulesExpandedState. Don't remember
+ the state if the dontRememberState property is true.
+ (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state
+ to false for this identifier in Preferences.styleRulesExpandedState.
+ * inspector/front-end/inspector.js:
+ (Preferences.styleRulesExpandedState): Initialize to an empty object.
+
+2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Alp Toker.
+
+ [Gtk] Remove libWebCoreJS.la when doing make clean
+ https://bugs.webkit.org/show_bug.cgi?id=21544
+
+ Remove libWebCoreJS.la when doing a clean target
+
+ * GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
+
+2008-10-11 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20592
+ The focus ring is not shown while navigating on some pages
+
+ Fix drawFocusRing() so it doesn't depend on the current graphics
+ state, thus matching other platforms which already work this way.
+
+ This patch provides two code paths: one using straight Cairo and
+ one specialised for the GTK+ port with a more conventional appearance.
+
+ Also change focusRingColor() to return a null color, allowing the
+ focus ring to pick up the style's current color if it isn't overridden
+ with CSS.
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::drawFocusRing):
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ (WebCore::focusRingColor):
+
+2008-10-11 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ - change all internal callers to use Cache::evict() instead of remove()
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::revalidateResource):
+ (WebCore::Cache::revalidationSucceeded):
+ (WebCore::Cache::pruneDeadResources):
+ (WebCore::Cache::setDisabled):
+
+2008-10-11 David Hyatt <hyatt@apple.com>
+
+ Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::invalidatePart):
+
+2008-10-11 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).
+
+ Also fixed resizer positioning problems.
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+ (WebCore::ScrollbarThemeComposite::trackPosition):
+ (WebCore::ScrollbarThemeComposite::trackLength):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
+ * rendering/RenderLayer.cpp:
+ (WebCore::scrollCornerRect):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::isPointInResizeControl):
+ (WebCore::RenderLayer::hitTestOverflowControls):
+ * rendering/RenderScrollbarTheme.cpp:
+ (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
+ * rendering/RenderScrollbarTheme.h:
+
+2008-10-11 Alp Toker <alp@nuanti.com>
+
+ Reviewed by David Hyatt.
+
+ Implement release/retain for Widget GTK+.
+
+ * platform/Widget.cpp:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::releasePlatformWidget):
+ (WebCore::Widget::retainPlatformWidget):
+
+2008-10-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
+ and add a corresponding getter; add the same functions on Windows
+
+ * WebCore.base.exp:
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::setCodePath):
+ (WebCore::codePath):
+ (WebCore::Font::canUseGlyphCache):
+ * platform/graphics/Font.h:
+ * platform/mac/WebCoreTextRenderer.h:
+ * platform/mac/WebCoreTextRenderer.mm:
+ (WebCoreSetAlwaysUsesComplexTextCodePath):
+ (WebCoreAlwaysUsesComplexTextCodePath):
+ * platform/win/WebCoreTextRenderer.cpp:
+ (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
+ (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
+ * platform/win/WebCoreTextRenderer.h:
+
+2008-10-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Stop leaking the event parameter names. The protected strings were showing up
+ in the caches window after one use. No measurable performance loss.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::eventParameterName):
+
+2008-10-11 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Remove unused function getNodeEventListener.
+
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventListener.h:
+
+2008-10-11 David Hyatt <hyatt@apple.com>
+
+ Add support for both positive and negative margins to tracks and track pieces.
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+ (WebCore::ScrollbarThemeComposite::trackPieceRects):
+ (WebCore::ScrollbarThemeComposite::trackPosition):
+ (WebCore::ScrollbarThemeComposite::trackLength):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::trackRect):
+ (WebCore::RenderScrollbar::trackPieceRectWithMargins):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::computeScrollbarWidth):
+ (WebCore::RenderScrollbarPart::computeScrollbarHeight):
+ * rendering/RenderScrollbarTheme.cpp:
+ (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
+ * rendering/RenderScrollbarTheme.h:
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
+ the scrollbar pseudo-elements anyway.
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+
+2008-10-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - separate Cache::remove() into a private method and a public interface,
+ then make Cache::pruneDeadResources() use the private method.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::pruneDeadResources):
+ (WebCore::Cache::evict):
+ * loader/Cache.h:
+ (WebCore::Cache::remove):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
+ now that the track pieces meet under the thumb.
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.
+
+ Reviewed by Tim Hatcher
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::createCustomScrollbar):
+ (WebCore::RenderScrollbar::RenderScrollbar):
+ (WebCore::RenderScrollbar::setParent):
+ (WebCore::RenderScrollbar::updateScrollbarParts):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbar.h:
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Make sure scrollbar background images cause proper part invalidation to occur.
+
+ Reviewed by Tim Hatcher
+
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::setHoveredPart):
+ (WebCore::RenderScrollbar::setPressedPart):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::styleDidChange):
+ (WebCore::RenderScrollbarPart::imageChanged):
+ * rendering/RenderScrollbarPart.h:
+
+2008-10-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=21538
+
+ The blendFunc() for TransformOperations should never mess with the
+ operation lists by replacing some ops with identity, otherwise the lists
+ no longer match and transitions break.
+
+ Test: transitions/matched-transform-functions.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+
+2008-10-10 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler
+
+ https://bugs.webkit.org/show_bug.cgi?id=21537
+
+ Fix re-targetting a running transition; if the target property
+ changes, we do need to make a new ImplicitAnimation.
+
+ Test: transitions/retargetted-transition.html
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+
+2008-10-10 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion.
+
+ When JS is terminated by the user choosing to stop a slow script
+ the exception toString method throws, yet the console logger does
+ not perform exception checks after logging. This leaves an
+ exception on the Machine, which in turn results in an assertion
+ failure next time we attempt to enter JS. The solution is just to
+ clear the exception state after attempting to record the exception.
+
+ * page/Console.cpp:
+ (WebCore::Console::reportException):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
+ when looking for pseudo styles.
+
+ Reviewed by Tim Hatcher
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::styleChanged):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Add the ability to style the scroll corner and the resizer from CSS.
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::RenderLayer):
+ (WebCore::RenderLayer::~RenderLayer):
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ (WebCore::RenderLayer::paintResizer):
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ (WebCore::RenderScrollbar::paintPart):
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::RenderScrollbarPart):
+ (WebCore::RenderScrollbarPart::paintIntoRect):
+ * rendering/RenderScrollbarPart.h:
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Make CSS scrollbars respect the OS setting regarding where buttons should be placed.
+
+ Reviewed by Sam Weinig
+
+ No test case possible, since the OS setting can vary.
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::styleChanged):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
+ (WebCore::ScrollbarThemeMac::preferencesChanged):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::invalidateScrollbarRect):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::styleChanged):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderScrollbarTheme.h:
+ (WebCore::RenderScrollbarTheme::buttonsPlacement):
+
+2008-10-10 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a regression with input search fields, where the placeholder text
+ would not be updated when the value of the placeholder attribute changed.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21521
+
+ Reviewed by Adele Peterson.
+
+ Test: fast/forms/search-placeholder-value-changed.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
+ placeholderValueChanged parameter of updatePlaceholderVisibility.
+ (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
+ for placeholderValueChanged that informs the method that the value changed.
+ * html/HTMLInputElement.h: Add the placeholderValueChanged to the
+ updatePlaceholderVisibility method. Made it default to false.
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Allow the track part to have negative margins so that it can slightly overlap buttons. This
+ is necessary to emulate the Aqua look in CSS.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::setHoveredPart):
+ (WebCore::RenderScrollbar::trackRect):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::computeScrollbarWidth):
+ (WebCore::RenderScrollbarPart::computeScrollbarHeight):
+ * rendering/RenderScrollbarTheme.cpp:
+ (WebCore::RenderScrollbarTheme::backButtonRect):
+ (WebCore::RenderScrollbarTheme::forwardButtonRect):
+ (WebCore::RenderScrollbarTheme::trackRect):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21527
+
+ Make CSS scrollbars support :not, :hover and :active.
+
+ Reviewed by Adam Roben
+
+ Added WebCore/manual-tests/scrollbar-hover-active.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::autoscrollPressedPart):
+ (WebCore::Scrollbar::startTimerIfNeeded):
+ (WebCore::Scrollbar::setHoveredPart):
+ (WebCore::Scrollbar::setPressedPart):
+ (WebCore::Scrollbar::mouseMoved):
+ (WebCore::Scrollbar::mouseExited):
+ (WebCore::Scrollbar::mouseUp):
+ (WebCore::Scrollbar::mouseDown):
+ * platform/Scrollbar.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::setHoveredPart):
+ (WebCore::RenderScrollbar::setPressedPart):
+ (WebCore::RenderScrollbar::updateScrollbarParts):
+ (WebCore::pseudoForScrollbarPart):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbar.h:
+
+2008-10-10 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
+ CSS transition with duration=0 and delay=0 doesn't override ongoing transition
+
+ Test: transitions/interrupt-zero-duration.html
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+
+2008-10-10 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Add new scrollbar-related sources.
+
+ * WebCoreSources.bkl:
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21522
+
+ Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
+ created. (Just :hover/:active left to finish it up.)
+
+ Reviewed by Adam Roben
+
+ Added scrollbars/scrollbar-buttons.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
+ back/forward to decrement/increment. Adding start/end pseudoclasses.
+
+ Reviewed by Eric Seidel
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+
+2008-10-10 David Hyatt <hyatt@apple.com>
+
+ Switch window-active to window-inactive, since that will work better as far as degrading in other
+ browsers.
+
+ Reviewed by Tim Hatcher
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+
+2008-10-09 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21310
+
+ Redesigned how animation events are sent in order to get rid of
+ AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
+ are now ref counted. While calling the event handler, I keep a
+ reference to this class to avoid it getting destroyed out from under me.
+
+ I also moved most of the functionality of CompositeAnimation to
+ and internal class (CompositeAnimationPrivate) to reduce the exposure
+ of the internals of the various animation classes.
+
+ We have several transition and animation LayoutTests which verify that
+ this fix works as expected and continues to avoid crashes.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::AnimationBase):
+ * page/animation/AnimationBase.h:
+ (WebCore::AnimationBase::cancelTimers):
+ (WebCore::AnimationBase::waitingForStyleAvailable):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
+ (WebCore::CompositeAnimationPrivate::suspended):
+ (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
+ (WebCore::CompositeAnimationPrivate::updateTransitions):
+ (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
+ (WebCore::CompositeAnimationPrivate::animate):
+ (WebCore::CompositeAnimationPrivate::setAnimating):
+ (WebCore::CompositeAnimationPrivate::animating):
+ (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
+ (WebCore::CompositeAnimationPrivate::resetTransitions):
+ (WebCore::CompositeAnimationPrivate::resetAnimations):
+ (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
+ (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
+ (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
+ (WebCore::CompositeAnimationPrivate::suspendAnimations):
+ (WebCore::CompositeAnimationPrivate::resumeAnimations):
+ (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
+ (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
+ (WebCore::compareAnimationIndices):
+ (WebCore::CompositeAnimationPrivate::styleAvailable):
+ (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
+ (WebCore::CompositeAnimationPrivate::setWaitingForStyleAvailable):
+ (WebCore::CompositeAnimation::CompositeAnimation):
+ (WebCore::CompositeAnimation::~CompositeAnimation):
+ (WebCore::CompositeAnimation::animate):
+ (WebCore::CompositeAnimation::animating):
+ (WebCore::CompositeAnimation::setWaitingForStyleAvailable):
+ (WebCore::CompositeAnimation::resetTransitions):
+ (WebCore::CompositeAnimation::suspendAnimations):
+ (WebCore::CompositeAnimation::resumeAnimations):
+ (WebCore::CompositeAnimation::suspended):
+ (WebCore::CompositeAnimation::styleAvailable):
+ (WebCore::CompositeAnimation::setAnimating):
+ (WebCore::CompositeAnimation::isAnimatingProperty):
+ (WebCore::CompositeAnimation::setAnimationStartTime):
+ (WebCore::CompositeAnimation::setTransitionStartTime):
+ (WebCore::CompositeAnimation::overrideImplicitAnimations):
+ (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ * page/animation/ImplicitAnimation.h:
+ (WebCore::ImplicitAnimation::create):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ * page/animation/KeyframeAnimation.h:
+ (WebCore::KeyframeAnimation::create):
+
+2008-10-09 David Hyatt <hyatt@apple.com>
+
+ Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
+ is active as well.
+
+ Reviewed by Tim Hatcher
+
+ Added scrollbars/scrollbar-orientation.html
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::isWindowActive):
+ * platform/Scrollbar.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::paint):
+ (WebCore::RenderScrollbar::partForStyleResolve):
+ * rendering/RenderScrollbar.h:
+
+2008-10-09 David Hyatt <hyatt@apple.com>
+
+ Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
+ :enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.
+
+ Reviewed by Tim Hatcher
+
+ Added scrollbars/disabled-scrollbar.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
+ * css/CSSStyleSelector.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::getPseudoStyle):
+ * rendering/RenderObject.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::setEnabled):
+ (WebCore::RenderScrollbar::scrollbarForStyleResolve):
+ (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
+ (WebCore::RenderScrollbar::paintPart):
+ * rendering/RenderScrollbar.h:
+
+2008-10-09 Eric Carlson <eric.carlson@apple.com>
+
+ Media controls should not show when element is not visible
+
+ https://bugs.webkit.org/show_bug.cgi?id=21155
+
+ Reviewed by Adele Peterson.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
+ in sync with visibility changes
+ * html/HTMLMediaElement.h:
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
+ (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
+ if element is visible or not. Don't animate controller visibility when change triggered by
+ showing or hiding media element.
+ * rendering/RenderMedia.h: declare m_previousVisible
+
+2008-10-09 Timothy Hatcher <timothy@apple.com>
+
+ Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
+ availability macros and version macros.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21496
+ rdar://problem/6259225
+
+ Reviewed by Sam Weinig.
+
+ * bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
+ * bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
+ and add an #if around the enum.
+ * bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
+ comment to match the other headers.
+ * bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
+ * bindings/objc/DOMObject.h: Add a version #if around class interface.
+ * bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
+ and add a version #if around the enum.
+ * bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
+ * bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
+ * bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
+ when they where added to WebKit. Also annotate individual methods that are
+ deprecated or where added after the class was added to WebKit.
+ * bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
+ since this header is included by most DOM headers. Annotate the JSObject method.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (ReadPublicInterfaces): Parse out the availability macro for each function/property.
+ And parse out the availability version for the class/protocol. Default to
+ WEBKIT_VERSION_LATEST if the class is new.
+ (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
+ interface availability version check if the class has a required version. Create
+ a public interface key (used to lookup in $publicInterfaces) and make a declaration
+ suffix that includes the availability macro (if needed). Use the "available in 1.3
+ and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
+ the default availability macro for old style methods. Tweak line breaks in the generated
+ headers to look good and not have too many extra lines.
+
+2008-10-09 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=20947
+
+ Refactor setStyle() methods into styleWillChange()
+ and styleDidChange(), so most of the setStyle() overrides can
+ be removed.
+
+ * rendering/RenderBR.cpp:
+ (WebCore::RenderBR::styleDidChange):
+ * rendering/RenderBR.h:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::styleWillChange):
+ (WebCore::RenderBlock::styleDidChange):
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::~RenderBox):
+ (WebCore::RenderBox::destroy):
+ (WebCore::RenderBox::styleWillChange):
+ (WebCore::RenderBox::styleDidChange):
+ * rendering/RenderBox.h:
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::styleWillChange):
+ (WebCore::RenderButton::styleDidChange):
+ * rendering/RenderButton.h:
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::styleDidChange):
+ * rendering/RenderFieldset.h:
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::styleDidChange):
+ * rendering/RenderFileUploadControl.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::styleDidChange):
+ * rendering/RenderInline.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::styleDidChange):
+ * rendering/RenderListBox.h:
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::styleDidChange):
+ * rendering/RenderListItem.h:
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::styleWillChange):
+ (WebCore::RenderListMarker::styleDidChange):
+ * rendering/RenderListMarker.h:
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::styleDidChange):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setStyle):
+ (WebCore::RenderObject::setStyleInternal):
+ (WebCore::RenderObject::styleWillChange):
+ (WebCore::RenderObject::styleDidChange):
+ * rendering/RenderObject.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::styleDidChange):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGGradientStop.cpp:
+ (WebCore::RenderSVGGradientStop::styleDidChange):
+ * rendering/RenderSVGGradientStop.h:
+ * rendering/RenderScrollbarPart.cpp:
+ (WebCore::RenderScrollbarPart::styleDidChange):
+ * rendering/RenderScrollbarPart.h:
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::styleDidChange):
+ * rendering/RenderSlider.h:
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::styleDidChange):
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::styleWillChange):
+ (WebCore::RenderTableCell::styleDidChange):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::styleWillChange):
+ * rendering/RenderTableRow.h:
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::styleDidChange):
+ * rendering/RenderText.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ * rendering/RenderTextControl.h:
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::styleDidChange):
+ * rendering/RenderWidget.h:
+
+2008-10-09 David Hyatt <hyatt@apple.com>
+
+ Make sure to destroy a custom scrollbar's RenderObjects before the arena goes away. When our widget
+ parent is nulled out is a good time.
+
+ Reviewed by Oliver Hunt
+
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::~RenderScrollbar):
+ (WebCore::RenderScrollbar::setParent):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ * rendering/RenderScrollbar.h:
+
+2008-10-09 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21446
+
+ This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
+ orientation and back vs. forward on the buttons, but it's a start.
+
+ Reviewed by Oliver Hunt
+
+ Added scrollbars/basic-scrollbar.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * platform/ScrollTypes.h:
+ (WebCore::):
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::styleChanged):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
+ (WebCore::ScrollbarThemeComposite::paintTrackBackground):
+ (WebCore::ScrollbarThemeComposite::paintTrackPiece):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarThemeSafari::paintTrackBackground):
+ * platform/win/ScrollbarThemeSafari.h:
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::paintTrack):
+ * platform/win/ScrollbarThemeWin.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderScrollbar.cpp: Added.
+ (WebCore::RenderScrollbar::createCustomScrollbar):
+ (WebCore::RenderScrollbar::RenderScrollbar):
+ (WebCore::RenderScrollbar::~RenderScrollbar):
+ (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
+ (WebCore::RenderScrollbar::updateScrollbarParts):
+ (WebCore::RenderScrollbar::updateScrollbarPart):
+ (WebCore::RenderScrollbar::paintPart):
+ (WebCore::RenderScrollbar::buttonRect):
+ (WebCore::RenderScrollbar::minimumThumbLength):
+ * rendering/RenderScrollbar.h: Added.
+ (WebCore::RenderScrollbar::styleChanged):
+ (WebCore::RenderScrollbar::owningRenderer):
+ * rendering/RenderScrollbarPart.cpp: Added.
+ (WebCore::RenderScrollbarPart::RenderScrollbarPart):
+ (WebCore::RenderScrollbarPart::~RenderScrollbarPart):
+ (WebCore::RenderScrollbarPart::layout):
+ (WebCore::RenderScrollbarPart::layoutHorizontalPart):
+ (WebCore::RenderScrollbarPart::layoutVerticalPart):
+ (WebCore::calcScrollbarThicknessUsing):
+ (WebCore::RenderScrollbarPart::computeScrollbarWidth):
+ (WebCore::RenderScrollbarPart::computeScrollbarHeight):
+ (WebCore::RenderScrollbarPart::calcPrefWidths):
+ (WebCore::RenderScrollbarPart::setStyle):
+ * rendering/RenderScrollbarPart.h: Added.
+ (WebCore::RenderScrollbarPart::renderName):
+ (WebCore::RenderScrollbarPart::requiresLayer):
+ * rendering/RenderScrollbarTheme.cpp: Added.
+ (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
+ (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
+ (WebCore::RenderScrollbarTheme::hasButtons):
+ (WebCore::RenderScrollbarTheme::hasThumb):
+ (WebCore::RenderScrollbarTheme::minimumThumbLength):
+ (WebCore::RenderScrollbarTheme::backButtonRect):
+ (WebCore::RenderScrollbarTheme::forwardButtonRect):
+ (WebCore::RenderScrollbarTheme::trackRect):
+ (WebCore::RenderScrollbarTheme::paintScrollCorner):
+ (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
+ (WebCore::RenderScrollbarTheme::paintTrackBackground):
+ (WebCore::RenderScrollbarTheme::paintTrackPiece):
+ (WebCore::RenderScrollbarTheme::paintButton):
+ (WebCore::RenderScrollbarTheme::paintThumb):
+ * rendering/RenderScrollbarTheme.h: Added.
+ (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
+ (WebCore::RenderScrollbarTheme::scrollbarThickness):
+ (WebCore::RenderScrollbarTheme::buttonsPlacement):
+ (WebCore::RenderScrollbarTheme::supportsControlTints):
+ (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
+ (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
+ (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
+ (WebCore::RenderScrollbarTheme::registerScrollbar):
+ (WebCore::RenderScrollbarTheme::unregisterScrollbar):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::):
+
+2008-10-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix Canvex DOOM Game
+ Gradient clips were not getting cleared after filling the
+ gradient, this was causing nothing to draw in Canvex
+ https://bugs.webkit.org/show_bug.cgi?id=21498
+
+ Tests forthcoming.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+
+2008-10-09 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix transformed patterns
+ https://bugs.webkit.org/show_bug.cgi?id=21498
+
+ Test: fast/canvas/patternfill-repeat.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::setStrokePattern):
+ (WebCore::GraphicsContext::setFillPattern):
+ (WebCore::GraphicsContext::setStrokeGradient):
+ (WebCore::GraphicsContext::setFillGradient):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::applyStrokePattern):
+ (WebCore::applyFillPattern):
+ (WebCore::GraphicsContext::drawPath):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+
+2008-10-09 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes.
+
+ * platform/wx/WidgetWx.cpp:
+ * plugins/wx/PluginViewWx.cpp:
+ (WebCore::PluginView::invalidateRect):
+ * webcore-base.bkl:
+
+2008-10-09 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
+ Animations assert when navigating from page
+
+ Changed assertions to test the right flag for the paused state
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+
+2008-10-09 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fixed > 180 degree rotation bug
+ Ensure that validateTransformFunctionList() is called after updating keyframe styles
+
+ https://bugs.webkit.org/show_bug.cgi?id=21420
+
+ Test: animations/big-rotation.html
+
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::KeyframeAnimation):
+
+2008-10-09 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders
+
+ <rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things
+
+ The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion
+ (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page,
+ so perform a second null check on the page. Bail if it has been cleared.
+
+2008-10-09 Alp Toker <alp@nuanti.com>
+
+ Build fix for recent DOM generation Makefile changes when custom
+ CFLAGS/CXXFLAGS are passed in.
+
+ * GNUmakefile.am:
+
+2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21390
+ [Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformRemoveChild):
+
+2008-10-09 Darin Adler <darin@apple.com>
+
+ - try to fix Qt build
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
+
+2008-10-08 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver Hunt & Sam Weinig.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)
+
+ Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
+ Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
+ use tree is rebuild.
+
+ Make SVGElementInstance a real EventTarget, as the SVG specification demands.
+ When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
+ is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
+ share an event listener list. Every event listener change on the SVGElementInstance object is forwared
+ to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
+ Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
+ to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
+ Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.
+
+ Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
+ see resources/use-instanceRoot-event-bubbling.js for details.
+
+ Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
+ svg/custom/use-elementInstance-methods.svg (reenabled)
+ svg/custom/use-setAttribute-crash.svg (covers bug 20550)
+ svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
+ svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
+ svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSLazyEventListener::wasCreatedFromMarkup):
+ * bindings/js/JSEventTarget.cpp:
+ * bindings/js/JSEventTargetSVGElementInstance.cpp: Removed.
+ * bindings/js/JSEventTargetSVGElementInstance.h: Removed.
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::JSSVGElementInstance::addEventListener):
+ (WebCore::JSSVGElementInstance::removeEventListener):
+ (WebCore::JSSVGElementInstance::pushEventHandlerScope):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * dom/EventListener.h:
+ (WebCore::EventListener::wasCreatedFromMarkup):
+ * dom/EventTargetNode.cpp:
+ (WebCore::updateSVGElementInstancesAfterEventListenerChange):
+ (WebCore::EventTargetNode::addEventListener):
+ (WebCore::EventTargetNode::removeEventListener):
+ (WebCore::eventTargetAsSVGElementInstance):
+ (WebCore::eventTargetRespectingSVGTargetRules):
+ (WebCore::EventTargetNode::dispatchEvent):
+ (WebCore::EventTargetNode::dispatchGenericEvent):
+ (WebCore::EventTargetNode::removeEventListenerForType):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::clear):
+ (WebCore::instanceAssociatedWithShadowTreeElement):
+ (WebCore::EventHandler::updateMouseEventTargetNode):
+ * page/EventHandler.h:
+ * svg/EventTargetSVGElementInstance.cpp: Removed.
+ * svg/EventTargetSVGElementInstance.h: Removed.
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::SVGElementInstance):
+ (WebCore::SVGElementInstance::~SVGElementInstance):
+ (WebCore::SVGElementInstance::childNodes):
+ (WebCore::SVGElementInstance::setShadowTreeElement):
+ (WebCore::SVGElementInstance::forgetWrapper):
+ (WebCore::SVGElementInstance::appendChild):
+ (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
+ (WebCore::SVGElementInstance::setNeedsUpdate):
+ (WebCore::SVGElementInstance::associatedFrame):
+ (WebCore::SVGElementInstance::addEventListener):
+ (WebCore::SVGElementInstance::removeEventListener):
+ (WebCore::SVGElementInstance::dispatchEvent):
+ (WebCore::SVGElementInstance::onabort):
+ (WebCore::SVGElementInstance::setOnabort):
+ (WebCore::SVGElementInstance::onblur):
+ (WebCore::SVGElementInstance::setOnblur):
+ (WebCore::SVGElementInstance::onchange):
+ (WebCore::SVGElementInstance::setOnchange):
+ (WebCore::SVGElementInstance::onclick):
+ (WebCore::SVGElementInstance::setOnclick):
+ (WebCore::SVGElementInstance::oncontextmenu):
+ (WebCore::SVGElementInstance::setOncontextmenu):
+ (WebCore::SVGElementInstance::ondblclick):
+ (WebCore::SVGElementInstance::setOndblclick):
+ (WebCore::SVGElementInstance::onerror):
+ (WebCore::SVGElementInstance::setOnerror):
+ (WebCore::SVGElementInstance::onfocus):
+ (WebCore::SVGElementInstance::setOnfocus):
+ (WebCore::SVGElementInstance::oninput):
+ (WebCore::SVGElementInstance::setOninput):
+ (WebCore::SVGElementInstance::onkeydown):
+ (WebCore::SVGElementInstance::setOnkeydown):
+ (WebCore::SVGElementInstance::onkeypress):
+ (WebCore::SVGElementInstance::setOnkeypress):
+ (WebCore::SVGElementInstance::onkeyup):
+ (WebCore::SVGElementInstance::setOnkeyup):
+ (WebCore::SVGElementInstance::onload):
+ (WebCore::SVGElementInstance::setOnload):
+ (WebCore::SVGElementInstance::onmousedown):
+ (WebCore::SVGElementInstance::setOnmousedown):
+ (WebCore::SVGElementInstance::onmousemove):
+ (WebCore::SVGElementInstance::setOnmousemove):
+ (WebCore::SVGElementInstance::onmouseout):
+ (WebCore::SVGElementInstance::setOnmouseout):
+ (WebCore::SVGElementInstance::onmouseover):
+ (WebCore::SVGElementInstance::setOnmouseover):
+ (WebCore::SVGElementInstance::onmouseup):
+ (WebCore::SVGElementInstance::setOnmouseup):
+ (WebCore::SVGElementInstance::onmousewheel):
+ (WebCore::SVGElementInstance::setOnmousewheel):
+ (WebCore::SVGElementInstance::onbeforecut):
+ (WebCore::SVGElementInstance::setOnbeforecut):
+ (WebCore::SVGElementInstance::oncut):
+ (WebCore::SVGElementInstance::setOncut):
+ (WebCore::SVGElementInstance::onbeforecopy):
+ (WebCore::SVGElementInstance::setOnbeforecopy):
+ (WebCore::SVGElementInstance::oncopy):
+ (WebCore::SVGElementInstance::setOncopy):
+ (WebCore::SVGElementInstance::onbeforepaste):
+ (WebCore::SVGElementInstance::setOnbeforepaste):
+ (WebCore::SVGElementInstance::onpaste):
+ (WebCore::SVGElementInstance::setOnpaste):
+ (WebCore::SVGElementInstance::ondragenter):
+ (WebCore::SVGElementInstance::setOndragenter):
+ (WebCore::SVGElementInstance::ondragover):
+ (WebCore::SVGElementInstance::setOndragover):
+ (WebCore::SVGElementInstance::ondragleave):
+ (WebCore::SVGElementInstance::setOndragleave):
+ (WebCore::SVGElementInstance::ondrop):
+ (WebCore::SVGElementInstance::setOndrop):
+ (WebCore::SVGElementInstance::ondragstart):
+ (WebCore::SVGElementInstance::setOndragstart):
+ (WebCore::SVGElementInstance::ondrag):
+ (WebCore::SVGElementInstance::setOndrag):
+ (WebCore::SVGElementInstance::ondragend):
+ (WebCore::SVGElementInstance::setOndragend):
+ (WebCore::SVGElementInstance::onreset):
+ (WebCore::SVGElementInstance::setOnreset):
+ (WebCore::SVGElementInstance::onresize):
+ (WebCore::SVGElementInstance::setOnresize):
+ (WebCore::SVGElementInstance::onscroll):
+ (WebCore::SVGElementInstance::setOnscroll):
+ (WebCore::SVGElementInstance::onsearch):
+ (WebCore::SVGElementInstance::setOnsearch):
+ (WebCore::SVGElementInstance::onselect):
+ (WebCore::SVGElementInstance::setOnselect):
+ (WebCore::SVGElementInstance::onselectstart):
+ (WebCore::SVGElementInstance::setOnselectstart):
+ (WebCore::SVGElementInstance::onsubmit):
+ (WebCore::SVGElementInstance::setOnsubmit):
+ (WebCore::SVGElementInstance::onunload):
+ (WebCore::SVGElementInstance::setOnunload):
+ * svg/SVGElementInstance.h:
+ (WebCore::SVGElementInstance::needsUpdate):
+ (WebCore::SVGElementInstance::toNode):
+ (WebCore::SVGElementInstance::toSVGElementInstance):
+ (WebCore::SVGElementInstance::correspondingElement):
+ (WebCore::SVGElementInstance::correspondingUseElement):
+ (WebCore::SVGElementInstance::shadowTreeElement):
+ (WebCore::SVGElementInstance::parentNode):
+ (WebCore::SVGElementInstance::previousSibling):
+ (WebCore::SVGElementInstance::nextSibling):
+ (WebCore::SVGElementInstance::firstChild):
+ (WebCore::SVGElementInstance::lastChild):
+ (WebCore::SVGElementInstance::ownerDocument):
+ (WebCore::SVGElementInstance::hasChildNodes):
+ (WebCore::SVGElementInstance::setFirstChild):
+ (WebCore::SVGElementInstance::setLastChild):
+ (WebCore::SVGElementInstance::setNextSibling):
+ (WebCore::SVGElementInstance::setPreviousSibling):
+ (WebCore::SVGElementInstance::refEventTarget):
+ (WebCore::SVGElementInstance::derefEventTarget):
+ * svg/SVGElementInstance.idl:
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::svgAttributeChanged):
+ (WebCore::SVGStyledElement::childrenChanged):
+ * svg/SVGUseElement.cpp:
+ (WebCore::SVGUseElement::svgAttributeChanged):
+ (WebCore::shadowTreeContainsChangedNodes):
+ (WebCore::SVGUseElement::recalcStyle):
+ (WebCore::dumpInstanceTree):
+ (WebCore::SVGUseElement::buildPendingResource):
+ (WebCore::SVGUseElement::buildInstanceTree):
+ (WebCore::SVGUseElement::transferEventListenersToShadowTree):
+ * svg/SVGUseElement.h:
+
+2008-10-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
+ REGRESSION (r36977): getRGBColorValue().red returning incorrect value
+
+ Update JSRGBColor to use the new static function per getter approach.
+
+ Test: fast/dom/css-RGBValue.html
+
+ * bindings/js/JSRGBColor.cpp:
+ (WebCore::):
+ (jsRGBColorRed):
+ (jsRGBColorGreen):
+ (jsRGBColorBlue):
+ * bindings/js/JSRGBColor.h:
+
+2008-10-08 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
+
+ svgElement.className.baseValue = "foo" does not work
+ https://bugs.webkit.org/show_bug.cgi?id=20651
+
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::classAttributeChanged):
+ (WebCore::StyledElement::parseMappedAttribute):
+ * dom/StyledElement.h:
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::svgAttributeChanged):
+
+2008-10-08 Anthony Ricaud <rik24d@gmail.com>
+
+ Make the toolbar label text-shadow not disappear when clicking on the
+ search result count or around the search field.
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/front-end/inspector.css:
+ (.toolbar-item:active .toolbar-label): Make this rule also require the
+ toggleable class with the toolbar-item class.
+
+2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Updated the qrc file for the Web Inspector to contain the current set
+ of images.
+
+ * inspector/front-end/WebKit.qrc:
+
+2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix the linking of applications against WebKit on Qt/Windows.
+
+ The prl files that qmake creates are buggy on Unix, but we they're
+ fine on Windows and we have to have them there in order to get the
+ dependencies correct.
+
+ * WebCore.pro:
+
+2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Speed up rectangle filling by not re-creating a QBrush all the time.
+
+ This triggers faster path in QPainter where the brush is reused.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
+ (WebCore::GraphicsContext::fillRect):
+
+2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon.
+
+ Fixes: Encoding of Qt URLs
+
+ This encoding was added by Simon and I because QUrl's
+ tolerant parser wasn't tolerant enough. Now it is, so we don't need
+ this anymore.
+
+ * platform/qt/KURLQt.cpp:
+ (WebCore::KURL::operator QUrl):
+
+2008-10-08 Marius Storm-Olsen <marius@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fixes dependencies in qmake generated visual studio projects.
+
+ Only add debug lib name if we're in the debug build_pass, else the release version.
+ The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.
+
+ * WebCore.pro:
+
+2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation errors on VS2008 64Bit
+
+ * platform/text/TextStream.cpp:
+ (WebCore::TextStream::operator<<):
+ * platform/text/TextStream.h:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::init):
+
+2008-10-07 Alp Toker <alp@nuanti.com>
+
+ GTK+ build fix for older automake versions (1.7). Discussed in bug
+ #21392.
+
+ * GNUmakefile.am:
+
+2008-10-07 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ <rdar://problem/6273887> Crash in ApplicationCacheGroup
+
+ Make sure to stop loading even before a cache update is in progress so that the
+ manifest load will be stopped.
+
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
+ (WebCore::ApplicationCacheGroup::stopLoading):
+ (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
+
+2008-10-07 Timothy Hatcher <timothy@apple.com>
+
+ Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21433
+
+ Reviewed by Sam Weinig.
+
+ * WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
+ * bindings/objc/DOM.mm: Remove previous category implementations
+ on DOMDocument for createNodeIterator: and createTreeWalker:. Also
+ moves ObjCNodeFilterCondition to its own file.
+ * bindings/objc/DOMTraversal.h: Remove the category methods that added
+ createNodeIterator: and createTreeWalker: to DOMDocument. This is fine
+ to do since DOmDocument.h is included still, and has these methods.
+ * bindings/objc/DOMUtility.mm:
+ (JSC::createDOMWrapper): Remove special case for JSNodeIterator and
+ JSTreeWalker now that the ObjC binding conforms to the standard wrap.
+ * bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm.
+ (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm.
+ (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
+ * bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm.
+ (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
+ * bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and
+ createTreeWalker: methods to DOMDocument.
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (GetObjCTypeGetter): Add a case for NodeFilter.
+ (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter.
+ (GenerateImplementation): Remove existing NodeFilter special case that
+ used the m_filter member variable. Add a new special getter for protocol
+ types that aren't EventTarget, so the right class is used for NodeFilter.
+ Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
+ * dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the
+ OldStyleObjC extended attribute to createNodeIterator and createTreeWalker.
+ Rename the entityReferenceExpansion parameter to expandEntityReferences to
+ match the previous ObjC API.
+ * dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The
+ m_filter member variable was never used in practice, it was always nil!
+ We can remove it and not pad the object because this can't be subclassed.
+ * dom/TreeWalker.idl: Ditto.
+
+2008-10-07 Timothy Hatcher <timothy@apple.com>
+
+ Auto-generate the DOMEventTarget protocol implementation for
+ DOMNode and DOMSVGElementInstance.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21432
+
+ Reviewed by Darin Adler.
+
+ * WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
+ * bindings/objc/DOM.mm: Remove many unneeded header includes. Move
+ ObjCEventListener to it's own file. Remove the manual impelmentations
+ of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
+ * bindings/objc/DOMEvents.h: Remove the categories that defined
+ DOMEventTarget for DOMNode and DOMSVGElementInstance.
+ * bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
+ * bindings/objc/ObjCEventListener.mm: Split out from DOM.mm.
+ (WebCore::ObjCEventListener::find): Moved from DOM.mm.
+ (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the
+ callers from doing a manual deref.
+ (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm.
+ (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr.
+ (AddIncludesForType): Include ObjCEventListener.h for EventListener.
+ And include EventTargetSVGElementInstance.h for SVGElementInstance.
+ (GenerateHeader): Remove the check for multiple parents.
+ (GenerateImplementation): Remove the check for multiple parents. Remove
+ the @deprecatedFunctions array since deprecated methods get generated
+ into the main @interface now to work with protocols. Add support
+ for the EventTargetNodeCast extended attribute. Add support for
+ EventListener parameters.
+ * dom/Node.idl: Define superclasses for ObjC so the implementation
+ and interface implement the DOMEventTarget protocol. Explicitly
+ specify Object as a superclass to use DOMEventTarget. Object will turn
+ into DOMObject. This is needed to take the code generator down the right
+ path of multiple super-classes as protocols. It is ObjC only for legacy
+ reasons. The event target methods are normally on NodeEventTarget, a
+ subclass of Node. But the ObjC API has never has this subclass and
+ they are on DOMNode.
+ * svg/SVGElementInstance.idl: Ditto.
+
+2008-10-07 David Hyatt <hyatt@apple.com>
+
+ Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.
+
+ The new pseudo-elements are:
+ scrollbar
+ scrollbar-button
+ scrollbar-corner
+ scrollbar-thumb
+ scrollbar-track
+
+ These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
+ the following new pseudo-classes:
+ scrollbar-active
+ scrollbar-back
+ scrollbar-forward
+ scrollbar-horizontal
+ scrollbar-vertical
+
+ Reviewed by Adele
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+
+2008-10-06 Timothy Hatcher <timothy@apple.com>
+
+ Add support to the Resources panel for queries like "#123", "foo #123",
+ "line: 123" and "foo line: 123". These will match the query limiting
+ the search only to the line specified. If only a line is specified,
+ the whole line is matched.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21422
+
+ Reviewed by Darin Adler.
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last
+ row if the index is greater than the rows collection. Let it return
+ undefined by indexing out-of-bounds.
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype.performSearch): Add support for
+ queries like "#123", "foo #123", "line: 123" and "foo line: 123".
+ Also match the whole query to the whole document in case there are
+ colors like "#333".
+
+2008-10-07 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21392
+ [GTK] Auto-generate JS DOM binding sources list
+
+ Remove the huge lists of generated DOM binding sources and headers in
+ the build system. These are difficult to maintain and can be derived
+ automatically.
+
+ The new strategy is to re-use the existing lists of IDL sources (which
+ are needed for dist support anyway). This will also ease the addition
+ of new language bindings.
+
+ * GNUmakefile.am:
+
+2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Don't attempt to paint when updating control tints
+
+ We don't have a valid PlatformGraphicsContext so schedule
+ the dirty scrollbar/scrollview area for repaint instead.
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::ScrollbarThemeQt::paint):
+ (WebCore::ScrollbarThemeQt::paintScrollCorner):
+
+2008-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ [qt] Build fix after Scrollbar.h and Widget.h changes.
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::init):
+
+2008-10-06 David Hyatt <hyatt@apple.com>
+
+ Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::hasWebView):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadWithDocumentLoader):
+ (WebCore::FrameLoader::transitionToCommitted):
+ * loader/FrameLoaderClient.h:
+ * page/FocusController.cpp:
+ (WebCore::FocusController::setActive):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView):
+ (WebCore::FrameView::init):
+ (WebCore::FrameView::layoutIfNeededRecursive):
+ * page/FrameView.h:
+
+2008-10-06 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * bindings/objc/DOMEvents.h:
+
+2008-10-06 Mark Mentovai <mark@moxienet.com>
+
+ Reviewed by Tim Hatcher.
+
+ Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
+ Platform.h is not available, in preference to #ifdef ENABLE_feature.
+ #ifdef is wrong now that features are disabled by #defining
+ ENABLE_feature to 0.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21338
+
+ * bindings/objc/DOMEvents.h:
+ * bindings/objc/PublicDOMInterfaces.h:
+ * dom/Document.idl:
+ * page/DOMWindow.idl:
+ * svg/svgtags.in:
+
+2008-10-06 Mark Mentovai <mark@moxienet.com>
+
+ Reviewed by Sam Weinig.
+
+ * platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h>
+ to get the declaration for isMainThread().
+
+2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Tim Hatcher.
+
+ WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
+ to reflect that.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/mac/WebCoreObjCExtras.c: Removed.
+ * platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
+
+2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Added C++ forward declaration for the NSURLAuthenticationChallenge class
+ so that the m_currentMacChallenge variable doesn't cause a
+ compilation error when ResourceHandleInternal.h is included from a C++ file.
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=21411
+
+ * platform/network/ResourceHandleInternal.h:
+
+2008-10-06 Steve Falkenburg <sfalken@apple.com>
+
+ Windows build fix.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-06 Steve Falkenburg <sfalken@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21416
+ Add missing null checks identified by Application Verifier.
+
+ Reviewed by Darin Adler.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::clearTimer):
+
+2008-10-06 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Removed accidentally left in debugging statement.
+
+ * inspector/front-end/inspector.js:
+
+2008-10-06 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher and Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21412
+ Bug 21412: Refactor user initiated profile count to be more stable
+
+ * inspector/InspectorController.cpp: Keep track of the user-initiated
+ profiles here now.
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::startUserInitiatedProfiling):
+ (WebCore::InspectorController::stopUserInitiatedProfiling):
+ * inspector/InspectorController.h:
+ The front end will now need to check for the existence of the user-
+ initiated profile title and use its count instead of keeping its own.
+ * inspector/front-end/ProfilesPanel.js:
+
+2008-10-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - separate GDI text drawing into its own function
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::drawGDIGlyphs):
+ (WebCore::Font::drawGlyphs):
+
+2008-10-03 Steve Falkenburg <sfalken@apple.com>
+
+ <rdar://problem/6249833> Fix default button appearance
+
+ Reviewed by Adele Peterson.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::supportsFocus):
+ (WebCore::RenderThemeWin::determineClassicState):
+ (WebCore::RenderThemeWin::determineButtonState):
+ (WebCore::RenderThemeWin::getClassicThemeData):
+ (WebCore::RenderThemeWin::getThemeData):
+ (WebCore::drawControl):
+ * rendering/RenderThemeWin.h:
+
+2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Add native virtual keycode to PlatformKeyboardEvent
+
+ * platform/PlatformKeyboardEvent.h:
+ * platform/gtk/KeyEventGtk.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/mac/KeyEventMac.mm:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/win/KeyEventWin.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+ * platform/wx/KeyboardEventWx.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
+2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac
+
+ * platform/text/PlatformString.h:
+ * platform/text/StringImpl.h:
+ * platform/text/cf/StringCF.cpp:
+ * platform/text/cf/StringImplCF.cpp:
+
+2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Use bundles on QtWebKit/Mac for platform modules
+
+ * platform/FileSystem.h:
+ * platform/qt/FileSystemQt.cpp:
+ (WebCore::unloadModule):
+
+2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Build fix for MinGW.
+
+ * platform/win/SystemTimeWin.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::invalidateRect):
+
+2008-10-06 Adam Roben <aroben@apple.com>
+
+ Mimic the inspector/ directory structure in WebCore.vcproj
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-06 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Update the Include path for all
+ configurations to include WebCore/inspector.
+
+2008-10-04 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ SVG should support ascent and descent properties <font-face> instead of <font>!
+ https://bugs.webkit.org/show_bug.cgi?id=21365
+
+ Tested by many many existing SVG tests.
+
+ * svg/SVGFontFaceElement.cpp:
+ (WebCore::SVGFontFaceElement::ascent):
+ (WebCore::SVGFontFaceElement::descent):
+
+2008-10-05 Darin Fisher <darin@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ REGRESSION: crash in ScriptElement::notifyFinished
+ Fixes https://bugs.webkit.org/show_bug.cgi?id=21329
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to
+ ensure that the ScriptElementData object is not destroyed prematurely.
+
+2008-10-05 Chris Lord <chris@openedhand.com>
+
+ Reviewed by Alp Toker. Landed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20624
+ WebKit-gtk uses deprecated GtkType/GtkObject
+
+ * plugins/gtk/gtk2xtbin.c:
+ (gtk_xtbin_get_type):
+ * plugins/gtk/gtk2xtbin.h:
+
+2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
+
+ Reviewed by David Hyatt.
+
+ GTK_WINDOW_HWND not GTK_WINDOWING_HWND
+ https://bugs.webkit.org/show_bug.cgi?id=20725
+
+ Updated to ToT by Jan Alonzo.
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::getValue):
+
+2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Invalid cast from GdkWindow to GtkWidget
+ https://bugs.webkit.org/show_bug.cgi?id=21391
+
+ Fix a misplaced closing parenthesis to actually cast the widget, not the window
+
+ * platform/gtk/PlatformScreenGtk.cpp:
+ (WebCore::screenDepth):
+
+2008-10-05 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Alder.
+
+ Attach the Origin header to POST requests to help defend against
+ cross-site request forgery.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20792
+
+ Collin Jackson <collinj@webkit.org> also contributed to this patch.
+
+ Tests: http/tests/security/originHeader/origin-header-for-data.html
+ http/tests/security/originHeader/origin-header-for-empty.html
+ http/tests/security/originHeader/origin-header-for-get.html
+ http/tests/security/originHeader/origin-header-for-https.html
+ http/tests/security/originHeader/origin-header-for-post.html
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::createWindow):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createWindow):
+ (WebCore::FrameLoader::urlSelected):
+ (WebCore::FrameLoader::submitForm):
+ (WebCore::FrameLoader::outgoingOrigin):
+ (WebCore::FrameLoader::loadURL):
+ (WebCore::FrameLoader::addExtraFieldsToRequest):
+ (WebCore::FrameLoader::loadPostRequest):
+ (WebCore::FrameLoader::loadResourceSynchronously):
+ (WebCore::FrameLoader::loadItem):
+ * loader/FrameLoader.h:
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::create):
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::servePendingRequests):
+ * platform/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::toHTTPOrigin):
+ * platform/SecurityOrigin.h:
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::httpOrigin):
+ (WebCore::ResourceRequestBase::setHTTPOrigin):
+ (WebCore::ResourceRequestBase::clearHTTPOrigin):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+ (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
+ (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
+
+2008-10-04 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
+ <https://bugs.webkit.org/show_bug.cgi?id=21381>
+
+ If we hit a parsing boundary (end of a packet, etc) in the middle of a
+ <script> element when we are doing an incremental parse, we exit the
+ parser, and reenter later when more data is available. During this
+ reentry we incorrectly reset the scriptStartLineno to the current line
+ in the parser, which is now part way through the script element.
+
+ The solution is to track whether we are entering or reentering the parsing
+ of a script element. We do this simply by 0 checking scriptStartLineno,
+ and resetting it after we complete parsing of each script element.
+
+ Test: http/tests/incremental/pause-in-script-element.pl
+
+ * ChangeLog:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::parseSpecial):
+ (WebCore::HTMLTokenizer::scriptHandler):
+
+2008-10-04 Alp Toker <alp@nuanti.com>
+
+ Reviewed by David Hyatt. Landed by Jan Alonzo.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20924
+ [Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3
+
+ https://bugs.webkit.org/show_bug.cgi?id=19578
+ [CURL] problem in parseDataUrl
+
+ De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
+ This patch also fixes encoding support in escaped (non-Base64) data
+ URLs. All manual data URL tests now pass in both GLib and non-GLib
+ code paths.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::parseDataUrl):
+
+2008-10-04 Timothy Hatcher <timothy@apple.com>
+
+ Makes breakpoints and debugging code during page load work in the
+ Web Inspector's debugger. Specifically, this makes the source
+ code for loading resources show up in the Scripts panel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19053
+ rdar://problem/5933408
+
+ Reviewed by Mark Rowe.
+
+ * WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
+ not using tabs and a tab width of 8.
+ * inspector/InspectorController.cpp:
+ (WebCore::addResourceSourceToFrame): Return a bool to report if the
+ source was added successfully or not.
+ (WebCore::addSourceToFrame): Ditto.
+ * inspector/front-end/ScriptView.js:
+ (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
+ Return early if the InspectorController.addSourceToFrame fails.
+ Moved the delete of the _frameNeedsSetup property after that call so
+ if the source wasn't added it will be attempted again.
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype.detach): Move a comment.
+ (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
+ Don't check if the resource is finished or failed, just attempt
+ to add the source to the frame. WebCore has the source, but the
+ finished property hasn't been set yet. Return early if the
+ InspectorController.addSourceToFrame fails. Moved the delete
+ of the _frameNeedsSetup property after that call so if the source
+ wasn't added it will be attempted again.
+ (WebInspector.SourceView.prototype._resourceLoadingFinished):
+ Clear the _frameNeedsSetup and _sourceFrameSetup properties so
+ the source frame will we populated again now that the resource
+ load has finished.
+ * manual-tests/inspector/debugger-pause-during-load.html: Added.
+
+2008-10-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-10-04 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21373
+
+ Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
+ is still present.
+
+ Reviewed by Mark Rowe
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::~FrameView):
+
+2008-10-04 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Avoid copying a Vector when using getSupportedKeySizes.
+
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::HTMLKeygenElement):
+ * platform/SSLKeyGenerator.h:
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ (WebCore::getSupportedKeySizes):
+ * platform/mac/SSLKeyGeneratorMac.mm:
+ (WebCore::getSupportedKeySizes):
+ * platform/qt/TemporaryLinkStubs.cpp:
+ (WebCore::getSupportedKeySizes):
+ * platform/win/TemporaryLinkStubs.cpp:
+ (WebCore::getSupportedKeySizes):
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (WebCore::getSupportedKeySizes):
+
+2008-10-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - prepare for https://bugs.webkit.org/show_bug.cgi?id=21295
+ Bug 21295: Replace ExecState with a call frame Register pointer
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
+ Remove bogus "const".
+ * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
+
+2008-10-04 David Hyatt <hyatt@apple.com>
+
+ Make PopupMenuClient obey the platform abstraction. Remove any connection to Document and RenderStyle.
+
+ Reviewed by Darin Adler
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/PopupMenuClient.h:
+ * platform/gtk/PopupMenuGtk.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/mac/PopupMenuMac.mm:
+ (WebCore::PopupMenu::populate):
+ (WebCore::PopupMenu::show):
+ * platform/qt/PopupMenuQt.cpp:
+ (WebCore::PopupMenu::populate):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::calculatePositionAndSize):
+ (WebCore::PopupMenu::paint):
+ (WebCore::PopupWndProc):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::itemStyle):
+ (WebCore::RenderMenuList::menuStyle):
+ (WebCore::RenderMenuList::hostWindow):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::itemStyle):
+ (WebCore::RenderTextControl::menuStyle):
+ (WebCore::RenderTextControl::hostWindow):
+ * rendering/RenderTextControl.h:
+
+2008-10-04 Matt Lilek <webkit@mattlilek.com>
+
+ Build fix - restore Private role to headers that had it before the move.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-10-04 Darin Adler <darin@apple.com>
+
+ - try to fix build
+
+ * DerivedSources.make: Add new inspector directory to VPATH.
+ * GNUmakefile.am: Add new inspector directory to includes.
+ Re-sort the IDL_BINDINGS list. Add new inspector directory
+ to VPATH.
+
+2008-10-04 Matt Lilek <webkit@mattlilek.com>
+
+ Not reviewed, attempt to fix Gtk build.
+
+ * GNUmakefile.am:
+
+2008-10-03 Timothy Hatcher <timothy@apple.com>
+
+ Move the Web Inspector files into a top-level "inspector" folder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21359
+
+ Reviewed by Dave Hyatt.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
+ * inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
+ * inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
+ * inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
+ * inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
+ * inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
+ * inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
+ * inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
+ * inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
+ * inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
+ * inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
+ * inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
+ * inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
+ * inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
+ * inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
+ * inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
+ * inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
+ * inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
+ * inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
+ * inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
+ * inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
+ * inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
+ * inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
+ * inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
+ * inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
+ * inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
+ * inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
+ * inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
+ * inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
+ * inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
+ * inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
+ * inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
+ * inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
+ * inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
+ * inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
+ * inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
+ * inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
+ * inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
+ * inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
+ * inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
+ * inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
+ * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
+ * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
+ * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
+ * inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
+ * inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
+ * inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
+ * inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
+ * inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
+ * inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
+ * inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
+ * inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
+ * inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
+ * inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
+ * inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
+ * inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
+ * inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
+ * inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
+ * inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
+ * inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
+ * inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
+ * inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
+ * inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
+ * inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
+ * inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
+ * inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
+ * inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
+ * inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
+ * inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
+ * inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
+ * inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
+ * inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
+ * inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
+ * inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
+ * inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
+ * inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
+ * inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
+ * inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
+ * inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
+ * inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
+ * inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
+ * inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
+ * inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
+ * inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
+ * inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
+ * inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
+ * inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
+ * inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
+ * inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
+ * inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
+ * inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
+ * inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
+ * inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
+ * inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
+ * inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
+ * inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
+ * inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
+ * inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
+ * inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
+ * inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
+ * inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
+ * inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
+ * inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
+ * inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
+ * inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
+ * inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
+ * inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
+ * inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
+ * inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
+ * inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
+ * inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
+ * inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
+ * inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
+ * inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
+ * inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
+ * inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
+ * inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
+ * inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
+ * inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
+ * inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
+ * inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
+ * inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
+ * inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
+ * inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
+ * inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
+ * inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
+ * inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
+ * inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
+ * inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
+ * inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
+ * inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
+ * inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
+ * inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
+ * inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
+ * inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
+ * inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
+ * inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
+ * inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
+ * inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
+ * inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
+ * inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
+ * inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
+ * inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
+ * inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
+ * inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
+ * inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
+ * inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
+ * inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
+ * inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
+ * inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
+ * inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
+
+2008-10-03 Timothy Hatcher <timothy@apple.com>
+
+ Adds support to the Web Inspector's Elements panel for fast tag name,
+ class name, id and attribute name searching. The panel first tries
+ using getElementById, getElementsByClassName and getElementsByTagName
+ with the search query. Then does a slower search using XPath for partial
+ matches, text and comment matches.
+
+ Adds support for search queries like "<div>", "<h" and "frame>".
+ These forms limit the search to tag names, text and comment matches.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21353
+
+ Reviewed by Maciej Stachowiak.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax
+ support. Add new search functions that try exact matches first.
+
+2008-10-03 Timothy Hatcher <timothy@apple.com>
+
+ Changes how searching works in the Web Inspector's Elements
+ panel. The search tasks are divided into chunks that are small
+ units of work that are performed at a time interval. This
+ change also prevents queries that will select all elements,
+ since that isn't useful.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21285
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.searchCancled):
+ Remove the searchResultsProperty form results since there might
+ be an unfinished search.
+ (WebInspector.ElementsPanel.prototype.performSearch): Divide the
+ documents and search functions into chunks that are performed on
+ a interval of 25ms. Prevent searches for "//*" and "*".
+
+2008-10-03 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - "this" object in methods called on primitives should be wrapper object
+ https://bugs.webkit.org/show_bug.cgi?id=21362
+
+ Updated so toThis conversion for the split window is handled properly.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2008-10-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David "The Motivator" Hyatt.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
+ Move SecurityOrigin out of platform/ to page/.
+
+ It was a layering violation for SecurityOrigin to be in platform
+ as it depended on FrameLoader.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
+ * page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
+ * page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
+ * platform/SecurityOrigin.cpp: Removed.
+ * platform/SecurityOrigin.h: Removed.
+ * platform/SecurityOriginHash.h: Removed.
+
+2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Alp Toker.
+
+ http://bugs.webkit.org/show_bug.cgi?id=18832
+ [curl] file upload does not work
+
+ The curl_off_t integer type has a different size depending if large
+ file support is enabled or not. There is no different public API for
+ the two cases, so the same function accepts a different type based on
+ a compilation option the could be different in WebKit and libcurl.
+ To fix the bug we query libcurl at runtime for large file support and
+ pass the right type based on that.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::setupPOST):
+
+2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by David Hyatt.
+
+ Gtk build fixes.
+
+ * platform/gtk/FileChooserGtk.cpp:
+ (WebCore::FileChooser::openFileChooser):
+ * platform/gtk/PlatformScreenGtk.cpp:
+ (WebCore::screenDepth):
+ (WebCore::screenDepthPerComponent):
+ (WebCore::screenAvailableRect):
+ * platform/gtk/PopupMenuGtk.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformAddChild):
+ (WebCore::ScrollView::platformRemoveChild):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::setCursor):
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::forceRedraw):
+ (WebCore::PluginView::init):
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Fix Qt bustage from missing include.
+
+ * platform/qt/PlatformScreenQt.cpp:
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Fix Windows scrollbar bustage in popup menus.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupWndProc):
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Fix Windows bustage.
+
+ * platform/win/FileChooserWin.cpp:
+ (WebCore::FileChooser::openFileChooser):
+ * platform/win/PlatformScreenWin.cpp:
+ (WebCore::monitorInfoForWidget):
+ * platform/win/WidgetWin.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::forceRedraw):
+ (WebCore::PluginView::init):
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ * bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure
+ seen on some machines but not others by adding an include.
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ - Qt build fix
+
+ * bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and
+ execute functions. Declarations for these relied on the CodeType
+ enumeration, which used to be in ExecState.h; but the functions
+ aren't needed at all.
+ * bridge/qt/qt_runtime.h: Ditto.
+
+2008-10-03 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
+ Turn ExecState into a call frame pointer.
+
+ Remove m_globalObject and m_globalData from ExecState.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
+ Removed an argument now that JSGlobalObject doesn't need it any more.
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from
+ the JSDOMWindowBaseData constructor, and added the this argument to the
+ JSGlobalObject constructor. This is because a couple key bits of
+ initialization moved from the data constructor to the JSGlobalObject
+ constructor.
+ * bindings/js/JSDOMWindowBase.h: Ditto.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
+ * bridge/runtime_method.cpp:
+ (JSC::RuntimeMethod::RuntimeMethod):
+ Pass JSGlobalData* instead of ExecState* to the InternalFunction
+ constructor.
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Fix Windows/Qt build bustage.
+
+ Reviewed by ggaren
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::platformWindow):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::platformWindow):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * platform/HostWindow.h:
+ * platform/qt/PlatformScreenQt.cpp:
+ (WebCore::screenDepth):
+ (WebCore::screenDepthPerComponent):
+ (WebCore::screenIsMonochrome):
+ (WebCore::screenRect):
+ (WebCore::screenAvailableRect):
+ * platform/qt/PopupMenuQt.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::show):
+ (WebCore::PopupMenu::calculatePositionAndSize):
+ (WebCore::PopupWndProc):
+
+2008-10-03 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Make setStyle() take a const RenderStyle, to ensure that an
+ earlier RenderStyle::diff() remains valid.
+
+ * rendering/RenderBR.cpp:
+ * rendering/RenderBR.h:
+ * rendering/RenderBlock.cpp:
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ * rendering/RenderBox.h:
+ * rendering/RenderButton.cpp:
+ * rendering/RenderButton.h:
+ * rendering/RenderFieldset.cpp:
+ * rendering/RenderFieldset.h:
+ * rendering/RenderFileUploadControl.cpp:
+ * rendering/RenderFileUploadControl.h:
+ * rendering/RenderInline.cpp:
+ * rendering/RenderInline.h:
+ * rendering/RenderListBox.cpp:
+ * rendering/RenderListBox.h:
+ * rendering/RenderListItem.cpp:
+ * rendering/RenderListItem.h:
+ * rendering/RenderListMarker.cpp:
+ * rendering/RenderListMarker.h:
+ * rendering/RenderMenuList.cpp:
+ * rendering/RenderMenuList.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setStyle):
+ * rendering/RenderObject.h:
+ * rendering/RenderReplaced.cpp:
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGBlock.cpp:
+ (WebCore::RenderSVGBlock::setStyle):
+ * rendering/RenderSVGBlock.h:
+ * rendering/RenderSVGGradientStop.cpp:
+ * rendering/RenderSVGGradientStop.h:
+ * rendering/RenderSlider.cpp:
+ * rendering/RenderSlider.h:
+ * rendering/RenderTable.cpp:
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ * rendering/RenderTableCell.h:
+ * rendering/RenderTableRow.cpp:
+ * rendering/RenderTableRow.h:
+ * rendering/RenderText.cpp:
+ * rendering/RenderText.h:
+ * rendering/RenderTextControl.cpp:
+ * rendering/RenderTextControl.h:
+ * rendering/RenderWidget.cpp:
+ * rendering/RenderWidget.h:
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::isDisplayReplacedType):
+ (WebCore::RenderStyle::isDisplayInlineType):
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
+ event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
+ method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
+ that will work properly for hit testing. This patch just stubs out that method to return the same
+ event untransformed.
+
+ Reviewed by Darin Adler
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * page/gtk/EventHandlerGtk.cpp:
+ * page/mac/EventHandlerMac.mm:
+ * page/qt/EventHandlerQt.cpp:
+ * page/win/EventHandlerWin.cpp:
+ * page/wx/EventHandlerWx.cpp:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::mouseMoved):
+ (WebCore::Scrollbar::mouseExited):
+ (WebCore::Scrollbar::mouseUp):
+ (WebCore::Scrollbar::mouseDown):
+ (WebCore::Scrollbar::transformEvent):
+ * platform/Scrollbar.h:
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21340
+
+ Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
+
+ Reviewed by Dan Bernstein & Darin Adler
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::addChild):
+ * platform/Widget.cpp:
+ (WebCore::Widget::init):
+ * platform/Widget.h:
+ * platform/mac/WidgetMac.mm:
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::show):
+
+2008-10-03 Adele Peterson <adele@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily):
+ Return early if settings is nil.
+
+2008-10-03 Rob Buis <buis@kde.org>
+
+ Reviewed by Darin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20134
+ REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
+
+ Make sure the input element gets the right default value when no value is set.
+
+ Test: fast/forms/range-default-value.html
+
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::setPositionFromValue):
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
+ destructor that calls them, switch to having a cross-platform constructor/destructor that calls
+ platform-specific init/destroy methods.
+
+ With this change, ScrollViewWin.cpp can be removed from the build (yay!).
+
+ Reviewed by Darin Adler
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+ (WebCore::ScrollView::platformInit):
+ (WebCore::ScrollView::platformDestroy):
+ (WebCore::ScrollView::platformAddChild):
+ (WebCore::ScrollView::platformRemoveChild):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformInit):
+ (WebCore::ScrollView::platformDestroy):
+ * platform/mac/ScrollViewMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::platformInit):
+ (WebCore::ScrollView::platformDestroy):
+ * platform/win/ScrollViewWin.cpp: Removed.
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformInit):
+ (WebCore::ScrollView::platformDestroy):
+ (WebCore::ScrollView::setPlatformWidget):
+
+2008-10-03 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/6012018>
+ https://bugs.webkit.org/show_bug.cgi?id=21335
+ CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8
+
+ * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
+
+2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Build fix.
+
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::invalidateRect):
+
+2008-10-03 Alp Toker <alp@nuanti.com>
+
+ Remove some left-over GTK+ includes. No change in functionality.
+
+ * platform/Cursor.h:
+ * platform/graphics/Icon.h:
+ * platform/gtk/RenderThemeGtk.h:
+
+2008-10-03 Alp Toker <alp@nuanti.com>
+
+ Build fix for trailing comment after #endif
+
+ * dom/ElementRareData.h:
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Remove addToDirtyRegion.
+
+ Reviewed by Oliver Hunt
+
+ * page/Chrome.cpp:
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+
+2008-10-03 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - fix a CachedResource leak introduced in r37176
+
+ Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
+ afterwards bail out of the outer pruneDeadResources().
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::Cache):
+ (WebCore::Cache::pruneDeadResources):
+ (WebCore::Cache::remove):
+ * loader/Cache.h:
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21330
+
+ Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
+ scrollbars.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::setHasVerticalScrollbar):
+ (WebCore::ScrollView::platformHasHorizontalAdjustment):
+ (WebCore::ScrollView::platformHasVerticalAdjustment):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::adjustmentChanged):
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+ (WebCore::ScrollView::setGtkAdjustments):
+ (WebCore::ScrollView::platformHandleHorizontalAdjustment):
+ (WebCore::ScrollView::platformHandleVerticalAdjustment):
+
+2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21106: .in format discussed changes
+ https://bugs.webkit.org/show_bug.cgi?id=21106
+
+ Change "upperCase" to "interfaceName" per-tag parameter as
+ discussed on the mailing list. Removed the per-attribute version
+ as it was not used.
+
+ Also add the "Element" suffix to all interfaceName parameter to match
+ the class name (and thus remove it from make_names.pl).
+
+ * dom/make_names.pl:
+ * html/HTMLTagNames.in:
+ * svg/svgtags.in:
+
+2008-10-03 David Hyatt <hyatt@apple.com>
+
+ Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
+ Hopefully this is a temporary hack that could eventually be removed.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::rootPreventsBlitting):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+ (WebCore::ScrollView::platformAddChild):
+ (WebCore::ScrollView::platformRemoveChild):
+
+2008-10-02 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21328
+
+ Make widget invalidation more cross-platform.
+
+ (1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
+
+ (2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
+ This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
+
+ (3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
+
+ (4) FrameViews now do a repaintRectangle on their owner element's renderer.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::invalidateRect):
+ (WebCore::FrameView::invalidateScrollbarRect):
+ * page/FrameView.h:
+ * platform/PopupMenu.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+ * platform/ScrollView.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::setEnabled):
+ (WebCore::Scrollbar::invalidateRect):
+ * platform/Scrollbar.h:
+ * platform/ScrollbarClient.h:
+ * platform/Widget.h:
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/mac/WidgetMac.mm:
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::invalidateScrollbarRect):
+ * platform/win/WidgetWin.cpp:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::invalidateTimerFired):
+ (WebCore::PluginView::invalidateWindowlessPluginRect):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::invalidateRect):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::invalidateRect):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::invalidateRect):
+ (WebCore::PluginView::invalidateRegion):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::invalidateScrollbarRect):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintObject):
+ (WebCore::RenderListBox::paintScrollbar):
+ (WebCore::RenderListBox::invalidateScrollbarRect):
+ * rendering/RenderListBox.h:
+
+2008-10-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen and Sam Weinig.
+
+ - fix SVGFontFaceElement leaks seen in Acid3
+ - make font-face elements take effect only when they are in the document tree
+
+ Test: svg/custom/font-face-not-in-document.svg
+
+ * svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a
+ RefPtr to a plain pointer to break a ref cycle.
+ (WebCore::SVGFontData::svgFontFaceElement):
+
+ * svg/SVGFontFaceElement.cpp: Changed to insert and remove the
+ @font-face rule from the document's mapped element sheet when the
+ element is inserted and removed from the document, and to update it
+ only when the element is in the document.
+ (WebCore::SVGFontFaceElement::SVGFontFaceElement):
+ (WebCore::SVGFontFaceElement::parseMappedAttribute):
+ (WebCore::SVGFontFaceElement::rebuildFontFace):
+ (WebCore::SVGFontFaceElement::insertedIntoDocument):
+ (WebCore::SVGFontFaceElement::removedFromDocument):
+ (WebCore::SVGFontFaceElement::childrenChanged):
+ (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
+ * svg/SVGFontFaceElement.h:
+
+2008-10-01 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Fix RenderFileUploadControl::setStyle() and
+ RenderMenuList::setStyle() to not touch the style; replace
+ with html4.css and CSSStyleSelector changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21287
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * css/html4.css:
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::setStyle):
+ * rendering/RenderFileUploadControl.cpp:
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::setStyle):
+
+2008-10-01 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Clean up code that changes the RenderStyle passed in to
+ table renderer setStyle() methods.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21287
+
+ Tests: fast/table/floating-th.html
+ fast/table/table-display-types-strict.html
+ fast/table/table-display-types.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::setStyle):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::setStyle):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::setStyle):
+
+2008-10-02 Darin Adler <darin@apple.com>
+
+ - fix build
+
+ * bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too.
+ Not just locally in my generated file!
+
+2008-10-02 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
+ REGRESSION: <input> color specified in inline style applies to placeholder
+
+ I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
+ is more appropriate. This change adds "-webkit-input-placeholder".
+
+ * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
+ Added definition for "-webkit-input-placeholder" pseudo element.
+ * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
+ * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ Added case for PseudoInputPlaceholder.
+ * css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
+ * rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
+ (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
+ (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
+ setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
+ (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
+ the text will be updated correctly.
+ * rendering/RenderTextControl.h:
+
+2008-10-02 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21280
+ <rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables
+
+ Updated AXTable detection to be more robust to false-positives. Specifically, added checks
+ to ensure that there is more than one valid table cell, and that at least half of the cells
+ have borders or have specific background colors. Modified the table detection layout test
+ to test for the tables mentioned in the bug
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+
+2008-10-02 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21321
+ Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
+
+ * bindings/js/GCController.cpp:
+ (WebCore::collect): Use heap. instead of heap-> to work with the heap.
+ (WebCore::GCController::gcTimerFired): Ditto.
+ (WebCore::GCController::garbageCollectNow): Ditto.
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::operator new): Ditto.
+ * storage/Database.cpp:
+ (WebCore::Database::Database): Ditto.
+
+2008-10-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ - fix a Database leak that resulted in Document leaks
+
+ * storage/Database.cpp:
+ (WebCore::Database::openDatabase): Account for the fact that RefCounted
+ objects start out with a ref count of 1.
+
+2008-10-02 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mr. Geoffrey Garen.
+
+ Always mark your parent before marking members.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::mark):
+
+2008-10-02 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21314
+
+ Make scrollBackingStore cross-platform.
+
+ Reviewed by Sam Weinig
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::repaint):
+ (WebCore::EmptyChromeClient::scroll):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::repaint):
+ (WebCore::Chrome::scroll):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleAutoscroll):
+ * platform/HostWindow.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollContents):
+ (WebCore::ScrollView::addPanScrollIcon):
+ (WebCore::ScrollView::removePanScrollIcon):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::~ScrollView):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+
+2008-10-02 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after Frame/ScrollView changes.
+
+ * WebCoreSources.bkl:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformContentsToScreen):
+ (WebCore::ScrollView::platformScreenToContents):
+ (WebCore::ScrollView::platformIsOffscreen):
+
+2008-10-02 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=21292
+
+ Revert the changes to enclosingIntRect made in r12530 since the new code
+ doesn't round correctly.
+
+ * ChangeLog:
+ * platform/graphics/FloatRect.cpp:
+ (WebCore::enclosingIntRect):
+
+2008-10-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson and Eric Seidel.
+
+ - fix HTMLCanvaseElement leak from -webkit-canvas() values
+
+ Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
+ pointer, as the document owns the canvas elements. Added code to release
+ those elements in Document::removedLastRef() because they reference
+ the document.
+
+ * css/CSSCanvasValue.cpp:
+ (WebCore::CSSCanvasValue::element):
+ * css/CSSCanvasValue.h:
+ (WebCore::CSSCanvasValue::CSSCanvasValue):
+ * dom/Document.cpp:
+ (WebCore::Document::removedLastRef):
+
+2008-10-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Build fix for platforms that don't implement WTF::ThreadSpecific.
+
+ * bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet):
+ Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this
+ code is only needed for JS bindings in worker threads.
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21298
+
+ Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
+ will make that cross-platform.
+
+ The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
+ multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
+ windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
+
+ Reviewed by Sam Weinig
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::windowClipRect):
+ (WebCore::FrameView::isActive):
+ * page/FrameView.h:
+ (WebCore::FrameView::visibleContentsResized):
+ * platform/PopupMenu.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::init):
+ (WebCore::ScrollView::destroy):
+ (WebCore::ScrollView::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::setHasVerticalScrollbar):
+ (WebCore::ScrollView::valueChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollContents):
+ (WebCore::ScrollView::platformHandleHorizontalAdjustment):
+ (WebCore::ScrollView::platformHandleVerticalAdjustment):
+ * platform/ScrollView.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::windowClipRect):
+ * platform/ScrollbarClient.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::platformHandleHorizontalAdjustment):
+ (WebCore::ScrollView::platformHandleVerticalAdjustment):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::scrollContents):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::windowClipRect):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::scrollContents):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::windowClipRect):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::panScroll):
+ (WebCore::RenderListBox::windowClipRect):
+ * rendering/RenderListBox.h:
+
+2008-10-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21304
+ Stop using a static wrapper map for WebCore JS bindings
+
+ The static domObjects map was not thread safe.
+
+ * dom/Document.h:
+ (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message
+ ports.
+ (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createdXMLHttpRequest):
+ (WebCore::Document::destroyedXMLHttpRequest):
+ Moved XMLHttpRequest tracking from a global map to Document.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * webcore-base.bkl:
+ * bindings/DOMProtect.cpp: Removed.
+ * bindings/DOMProtect.h: Removed.
+ Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference,
+ so they can no longer protect bindings objects.
+
+ * dom/MessagePort.cpp:
+ (WebCore::CloseMessagePortTimer::CloseMessagePortTimer):
+ (WebCore::CloseMessagePortTimer::fired):
+ (WebCore::MessagePort::MessagePort):
+ (WebCore::MessagePort::queueCloseEvent):
+ (WebCore::MessagePort::setPendingActivity):
+ (WebCore::MessagePort::unsetPendingActivity):
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::hasPendingActivity):
+ MessagePort now counts outstanding async events, so JSDocument::mark can decide whether
+ to protect it.
+
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::hasPendingActivity):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::~XMLHttpRequest):
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::dropProtection):
+ (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
+ (WebCore::XMLHttpRequest::cancelRequests):
+ (WebCore::XMLHttpRequest::detachRequests):
+ (WebCore::XMLHttpRequest::setPendingActivity):
+ (WebCore::XMLHttpRequest::unsetPendingActivity):
+ Moved XMLHttpRequest tracking from a global map to Document.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::wrapperSet):
+ (WebCore::DOMObjectWrapperMap::mapFor):
+ (WebCore::DOMObjectWrapperMap::get):
+ (WebCore::DOMObjectWrapperMap::set):
+ (WebCore::DOMObjectWrapperMap::remove):
+ (WebCore::getCachedDOMObjectWrapper):
+ (WebCore::cacheDOMObjectWrapper):
+ (WebCore::forgetDOMObject):
+ (WebCore::getCachedDOMNodeWrapper):
+ (WebCore::forgetDOMNode):
+ (WebCore::cacheDOMNodeWrapper):
+ (WebCore::markActiveObjectsForDocument):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::createDOMObjectWrapper):
+ (WebCore::getDOMObjectWrapper):
+ Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet
+ to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug).
+ WebCore objects can never migrate between threads.
+
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::mark):
+ Call markActiveObjectsForDocument() from JSDOMBinding.
+
+ * bindings/js/JSCSSRuleCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::markDOMObjectWrapper):
+ (WebCore::JSDOMWindow::mark):
+ * bindings/js/JSEventCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSEventTarget.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSMessageChannelCustom.cpp:
+ (WebCore::JSMessageChannel::mark):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::mark):
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSStyleSheetCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::finishedWithEvent):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ Pass a JSGlobalData reference to functions that track JS wrapper objects.
+
+2008-10-02 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * page/JavaScriptCallFrame.idl:
+
+2008-10-02 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by NOBODY (Build fix).
+
+ Add new file to project files
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-02 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix some more builds.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+
+2008-10-02 Geoffrey Garen <ggaren@apple.com>
+
+ Not reviewed.
+
+ Try to fix Windows build.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-10-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler and Cameron Zwarich.
+
+ Updated for JavaScriptCore API changes: use a SourceCode instead of
+ broken out parameters; treat sourceId as intptr_t.
+
+ * ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::send):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ * bindings/js/StringSourceProvider.h:
+ (WebCore::StringSourceProvider::create):
+ (WebCore::StringSourceProvider::StringSourceProvider):
+
+ (WebCore::makeSource): Added a makeSource function for convenience.
+
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject evaluateWebScript:]):
+ * bridge/NP_jsobject.cpp:
+ (_NPN_Evaluate):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::eval):
+ (JavaJSObject::getMember):
+ (JavaJSObject::setMember):
+ (JavaJSObject::removeMember):
+
+ * bridge/jni/jni_runtime.h:
+ (JSC::Bindings::JavaString::operator UString): Replaced the explicit
+ ustring() function with an implicit operator because this class already
+ holds a UString::rep.
+
+ * page/Console.cpp:
+ (WebCore::retrieveLastCaller):
+ (WebCore::Console::trace):
+ * page/InspectorController.cpp:
+ (WebCore::jsStringRef):
+ (WebCore::InspectorController::addBreakpoint):
+ (WebCore::InspectorController::removeBreakpoint):
+ (WebCore::InspectorController::didParseSource):
+ (WebCore::InspectorController::failedToParseSource):
+ * page/InspectorController.h:
+ * page/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
+ * page/JavaScriptCallFrame.h:
+ (WebCore::JavaScriptCallFrame::create):
+ (WebCore::JavaScriptCallFrame::sourceIdentifier):
+ (WebCore::JavaScriptCallFrame::update):
+ * page/JavaScriptDebugListener.h:
+ * page/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::addBreakpoint):
+ (WebCore::JavaScriptDebugServer::removeBreakpoint):
+ (WebCore::JavaScriptDebugServer::hasBreakpoint):
+ (WebCore::dispatchDidParseSource):
+ (WebCore::dispatchFailedToParseSource):
+ (WebCore::JavaScriptDebugServer::sourceParsed):
+ (WebCore::JavaScriptDebugServer::callEvent):
+ (WebCore::JavaScriptDebugServer::atStatement):
+ (WebCore::JavaScriptDebugServer::returnEvent):
+ (WebCore::JavaScriptDebugServer::exception):
+ (WebCore::JavaScriptDebugServer::willExecuteProgram):
+ (WebCore::JavaScriptDebugServer::didExecuteProgram):
+ (WebCore::JavaScriptDebugServer::didReachBreakpoint):
+ * page/JavaScriptDebugServer.h:
+ * page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and
+ sourceIdentifier to sourceID.
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ - fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html
+
+ Broke a ref cycle by changing the m_svgFontFaceElement members of
+ CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
+ pointers. Also made sure that the @font-face rule added by
+ SVGFontFaceElement to the document's mapped element sheet is removed
+ when the font-face element is deleted or moved to another document.
+
+ * css/CSSFontFaceSource.cpp:
+ (WebCore::CSSFontFaceSource::CSSFontFaceSource):
+ (WebCore::CSSFontFaceSource::getFontData):
+ * css/CSSFontFaceSource.h:
+ (WebCore::CSSFontFaceSource::svgFontFaceElement):
+ * css/CSSFontFaceSrcValue.h:
+ (WebCore::CSSFontFaceSrcValue::svgFontFaceElement):
+ (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
+ * svg/SVGFontFaceElement.cpp:
+ (WebCore::SVGFontFaceElement::~SVGFontFaceElement):
+ (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument):
+ (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument):
+ (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
+ * svg/SVGFontFaceElement.h:
+
+2008-10-01 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20315: Memory leak with Canvas getImageData
+ <https://bugs.webkit.org/show_bug.cgi?id=20315>
+
+ This wasn't a leak, the issue was that we were reporting the cost
+ of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
+ and we should have been reporting the cost when we create the
+ JSImageData wrapper.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed.
+ This was only needed to report the extra memory cost
+ of the CPA.
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+ We need a custom toJS function now so that we can report
+ the extra memory cost.
+ * bindings/scripts/CodeGeneratorJS.pm:
+ Need to replace the reference to CanvasPixelArray with ImageData
+ to be able to create the custom toJS implementation.
+ * html/CanvasPixelArray.idl:
+ * html/ImageData.idl:
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21293
+ REGRESSION: Crash beneath RenderSVGViewportContainer::viewportTransform() during SVGSVGElement destruction
+
+ * svg/SVGMarkerElement.cpp:
+ (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so
+ that renderer destruction happens before the SVGMarkerElement is
+ destroyed.
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
+
+2008-10-01 Evan Martin <evan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20669
+
+ * css/makeprop.pl:
+ Die if gperf fails.
+
+2008-10-01 Evan Martin <evan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ * loader/icon/IconDatabase.h:
+ IconDatabase uses HashMap, so it needs to #include the header.
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::remove): Disable pruning temporarily during
+ CachedResource deletion.
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
+
+ * svg/SVGFontFaceElement.cpp:
+ (WebCore::SVGFontFaceElement::rebuildFontFace):
+ * svg/SVGFontFaceElement.h:
+ (WebCore::SVGFontFaceElement::associatedFontElement):
+
+2008-10-01 Brett Wilson <brettw@chromium.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Document the rounding behavior of the mapRect(IntRect) function in
+ AffineTransform.h.
+
+ * platform/graphics/AffineTransform.h:
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ Move prohibitsScrolling from the Frame to the ScrollView.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * page/Frame.cpp:
+ (WebCore::FramePrivate::FramePrivate):
+ * page/Frame.h:
+ * page/FramePrivate.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollRectIntoViewRecursively):
+ (WebCore::FrameView::setScrollPosition):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::init):
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+ (WebCore::ScrollView::setScrollPosition):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::setProhibitsScrolling):
+ (WebCore::ScrollView::prohibitsScrolling):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2008-10-01 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
+ that we do during the loadRequestAsynchronously of the preflight request with a deref and
+ GC unprotect.
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
+ clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.
+
+ Reviewed by Tim Hatcher
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setCanHaveScrollbars):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setCanHaveScrollbars):
+ (WebCore::ScrollView::wheelEvent):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::canHaveScrollbars):
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix some CachedResource leaks seen on buildbot
+
+ The issue here was that emptying the cache was a no-op when it only
+ contained resources with no data. Changed to go after those
+ resources when the desired cache capacity is zero.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::pruneLiveResources):
+ (WebCore::Cache::pruneDeadResources):
+ * loader/Cache.h:
+ (WebCore::Cache::prune):
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
+ HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)
+
+ Reviewed by Adam Roben
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::isOffscreen):
+ (WebCore::ScrollView::platformIsOffscreen):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformIsOffscreen):
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ Make show/hide/setParentVisible cross-platform on ScrollView.
+
+ Reviewed by Adam Roben
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setParentVisible):
+ (WebCore::ScrollView::show):
+ (WebCore::ScrollView::hide):
+ * platform/ScrollView.h:
+ * platform/win/ScrollViewWin.cpp:
+
+2008-10-01 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21284
+ Bug 21284: Max height affects max width
+ - Looks like a cut and paste bug
+ - Added layout test fast/css/max-height-and-max-width.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21282
+
+ Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.
+
+ Reviewed by Adam Roben
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::screenToWindow):
+ (WebCore::EmptyChromeClient::windowToScreen):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::screenToWindow):
+ (WebCore::Chrome::windowToScreen):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * platform/HostWindow.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::contentsToScreen):
+ (WebCore::ScrollView::screenToContents):
+ (WebCore::ScrollView::platformContentsToScreen):
+ (WebCore::ScrollView::platformScreenToContents):
+ * platform/ScrollView.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformContentsToScreen):
+ (WebCore::ScrollView::platformScreenToContents):
+ * platform/win/ScrollViewWin.cpp:
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
+
+ Test: fast/parser/residual-style-close-across-removed-block.html
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed
+ an assertion that turned out to be wrong in this case, and changed to
+ terminate the algorithm at the first empty block.
+
+2008-10-01 David Hyatt <hyatt@apple.com>
+
+ Make setFrameRect on ScrollView cross-platform.
+
+ Reviewed by Sam Weinig
+
+ * page/FrameView.h:
+ (WebCore::FrameView::contentsResized):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setFrameRect):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+
+2008-10-01 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
+ to JSDOMWindow from JSDOMWindowBase.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::removeTimeout):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::setTimeoutOrInterval):
+ (WebCore::JSDOMWindow::setTimeout):
+ (WebCore::JSDOMWindow::clearTimeout):
+ (WebCore::JSDOMWindow::setInterval):
+ (WebCore::JSDOMWindow::clearInterval):
+ (WebCore::JSDOMWindow::atob):
+ (WebCore::JSDOMWindow::btoa):
+ * page/DOMWindow.idl:
+
+2008-10-01 Dan Bernstein <mitz@apple.com>
+
+ - Mac build fix
+
+ * WebCore.base.exp:
+
+2008-10-01 Timothy Hatcher <timothy@apple.com>
+
+ Prevent stealing focus from the search field when focusing a DOM node.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21275
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged):
+ Don't steal focus if the current focus element is the search field.
+
+2008-09-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.
+
+ Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
+ Autogenerate JS event listeners
+
+ - Generate getting/setting of EventListeners.
+
+ - Adding a new named EventListener now has the same process as adding any other DOM
+ attribute. (Add a method with the same name in the c++ file).
+
+ (The EventListeners for MessagePort have been intentionally left custom so that we
+ can continue to experiment with making those EventListeners work in a frame-less world.)
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
+ * bindings/js/JSDOMWindowCustom.cpp: ditto.
+ * bindings/js/JSEventTargetNodeCustom.cpp: ditto.
+ * bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
+ * bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener
+ getter/setters
+ * dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
+ * dom/EventTargetNode.h: ditto.
+ * dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator
+ will use JSEventListerner instead of JSUnprotectedEventListener.
+ * loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
+ * page/DOMWindow.cpp: Add getter/setters for named EventListener
+ * page/DOMWindow.h: ditto.
+ * page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator
+ will use JSEventListerner instead of JSUnprotectedEventListener.
+ * xml/XMLHttpRequest.idl: Remove custom attributes.
+ * xml/XMLHttpRequestUpload.idl: ditto.
+
+2008-09-30 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Add a leak counter for CachedResources since we've had two recent leaks involving them.
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::CachedResource):
+ (WebCore::CachedResource::~CachedResource):
+
+2008-09-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21127
+ <rdar://problem/6259134> REGRESSION: CFF format fonts fail to load
+
+ If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
+ the font name in memory.
+
+ * WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to
+ OpenTypeUtilities.*.
+
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call
+ to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is
+ used.
+ (WebCore::FontCustomPlatformData::fontPlatformData): Added a code path
+ for fonts loaded using AddFontMemResourceEx.
+ (WebCore::createFontCustomPlatformData): Added a call to
+ renameAndActivateFont() if TTLoadEmbeddedFont fails. If
+ TTLoadEmbeddedFont succeeds, set the font name to the null string, as
+ fontPlatformData() will retrieve the name from the font reference.
+
+ * platform/graphics/win/FontCustomPlatformData.h:
+ (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
+ font name member.
+
+ * platform/graphics/win/GetEOTHeader.cpp: Renamed.
+ * platform/graphics/win/GetEOTHeader.h: Renamed.
+
+ * platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp.
+ (WebCore::BigEndianUShort::BigEndianUShort): Added a constructor.
+ (WebCore::BigEndianULong::BigEndianULong): Ditto.
+ (WebCore::renameAndActivateFont): Added. Creates an in-memory copy of
+ the font data and modifies it to have the given name, then activates
+ it using AddFontMemResourceEx.
+
+ * platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
+
+2008-09-30 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix many leaks seen on fast/backgrounds/svg-as-mask.html.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
+ with calls to removeClient when we're being destroyed.
+
+2008-09-30 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21243
+
+ Fix loopstart and loopend default values.
+
+ Tests: media/loopend-limits.html
+ media/loopstart-limits.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value
+ (WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value
+
+2008-09-30 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.
+
+ * WebCoreSources.bkl:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
+
+2008-09-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix HTMLViewSourceDocument leaks by breaking a ref cycle which
+ was fixed in r17249 and re-introduced in r31435.
+
+ * html/HTMLViewSourceDocument.cpp:
+ (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
+ (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
+ (WebCore::HTMLViewSourceDocument::addLine):
+ (WebCore::HTMLViewSourceDocument::addLink):
+ * html/HTMLViewSourceDocument.h:
+
+2008-09-30 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ More for https://bugs.webkit.org/show_bug.cgi?id=21122
+ Autogenerate JS event listeners
+
+ - Make EventListener getter/setters names in c++ files match those in
+ JS (ie. onLoadListener -> onload).
+ - Add standard way to access the frame associated with the EventTarget
+ for EventListener lookup.
+ - Autogenerate dispatchEvent, it wasn't doing anything custom.
+
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::mark):
+ (WebCore::JSDOMApplicationCache::addEventListener):
+ (WebCore::JSDOMApplicationCache::removeEventListener):
+ (WebCore::JSDOMApplicationCache::setOnchecking):
+ (WebCore::JSDOMApplicationCache::onchecking):
+ (WebCore::JSDOMApplicationCache::setOnerror):
+ (WebCore::JSDOMApplicationCache::onerror):
+ (WebCore::JSDOMApplicationCache::setOnnoupdate):
+ (WebCore::JSDOMApplicationCache::onnoupdate):
+ (WebCore::JSDOMApplicationCache::setOndownloading):
+ (WebCore::JSDOMApplicationCache::ondownloading):
+ (WebCore::JSDOMApplicationCache::setOnprogress):
+ (WebCore::JSDOMApplicationCache::onprogress):
+ (WebCore::JSDOMApplicationCache::setOnupdateready):
+ (WebCore::JSDOMApplicationCache::onupdateready):
+ (WebCore::JSDOMApplicationCache::setOncached):
+ (WebCore::JSDOMApplicationCache::oncached):
+ * bindings/js/JSEventTargetNodeCustom.cpp:
+ (WebCore::JSEventTargetNode::addEventListener):
+ (WebCore::JSEventTargetNode::removeEventListener):
+ (WebCore::JSEventTargetNode::getListener):
+ (WebCore::JSEventTargetNode::setListener):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::mark):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ (WebCore::JSMessagePort::setOnmessage):
+ (WebCore::JSMessagePort::onmessage):
+ (WebCore::JSMessagePort::setOnclose):
+ (WebCore::JSMessagePort::onclose):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark):
+ (WebCore::JSXMLHttpRequest::onreadystatechange):
+ (WebCore::JSXMLHttpRequest::setOnreadystatechange):
+ (WebCore::JSXMLHttpRequest::onabort):
+ (WebCore::JSXMLHttpRequest::setOnabort):
+ (WebCore::JSXMLHttpRequest::onerror):
+ (WebCore::JSXMLHttpRequest::setOnerror):
+ (WebCore::JSXMLHttpRequest::onload):
+ (WebCore::JSXMLHttpRequest::setOnload):
+ (WebCore::JSXMLHttpRequest::onloadstart):
+ (WebCore::JSXMLHttpRequest::setOnloadstart):
+ (WebCore::JSXMLHttpRequest::onprogress):
+ (WebCore::JSXMLHttpRequest::setOnprogress):
+ (WebCore::JSXMLHttpRequest::addEventListener):
+ (WebCore::JSXMLHttpRequest::removeEventListener):
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark):
+ (WebCore::JSXMLHttpRequestUpload::onabort):
+ (WebCore::JSXMLHttpRequestUpload::setOnabort):
+ (WebCore::JSXMLHttpRequestUpload::onerror):
+ (WebCore::JSXMLHttpRequestUpload::setOnerror):
+ (WebCore::JSXMLHttpRequestUpload::onload):
+ (WebCore::JSXMLHttpRequestUpload::setOnload):
+ (WebCore::JSXMLHttpRequestUpload::onloadstart):
+ (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
+ (WebCore::JSXMLHttpRequestUpload::onprogress):
+ (WebCore::JSXMLHttpRequestUpload::setOnprogress):
+ (WebCore::JSXMLHttpRequestUpload::addEventListener):
+ (WebCore::JSXMLHttpRequestUpload::removeEventListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/EventTarget.h:
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::associatedFrame):
+ * dom/EventTargetNode.h:
+ * dom/EventTargetNode.idl:
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::associatedFrame):
+ * dom/MessagePort.h:
+ (WebCore::MessagePort::setOnmessage):
+ (WebCore::MessagePort::onmessage):
+ (WebCore::MessagePort::setOnclose):
+ (WebCore::MessagePort::onclose):
+ * dom/MessagePort.idl:
+ * loader/appcache/DOMApplicationCache.h:
+ (WebCore::DOMApplicationCache::setOnchecking):
+ (WebCore::DOMApplicationCache::onchecking):
+ (WebCore::DOMApplicationCache::setOnerror):
+ (WebCore::DOMApplicationCache::onerror):
+ (WebCore::DOMApplicationCache::setOnnoupdate):
+ (WebCore::DOMApplicationCache::onnoupdate):
+ (WebCore::DOMApplicationCache::setOndownloading):
+ (WebCore::DOMApplicationCache::ondownloading):
+ (WebCore::DOMApplicationCache::setOnprogress):
+ (WebCore::DOMApplicationCache::onprogress):
+ (WebCore::DOMApplicationCache::setOnupdateready):
+ (WebCore::DOMApplicationCache::onupdateready):
+ (WebCore::DOMApplicationCache::setOncached):
+ (WebCore::DOMApplicationCache::oncached):
+ (WebCore::DOMApplicationCache::associatedFrame):
+ * loader/appcache/DOMApplicationCache.idl:
+ * svg/EventTargetSVGElementInstance.cpp:
+ (WebCore::EventTargetSVGElementInstance::associatedFrame):
+ (WebCore::EventTargetSVGElementInstance::addEventListener):
+ (WebCore::EventTargetSVGElementInstance::removeEventListener):
+ (WebCore::EventTargetSVGElementInstance::dispatchEvent):
+ * svg/EventTargetSVGElementInstance.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::associatedFrame):
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::setOnreadystatechange):
+ (WebCore::XMLHttpRequest::onreadystatechange):
+ (WebCore::XMLHttpRequest::setOnabort):
+ (WebCore::XMLHttpRequest::onabort):
+ (WebCore::XMLHttpRequest::setOnerror):
+ (WebCore::XMLHttpRequest::onerror):
+ (WebCore::XMLHttpRequest::setOnload):
+ (WebCore::XMLHttpRequest::onload):
+ (WebCore::XMLHttpRequest::setOnloadstart):
+ (WebCore::XMLHttpRequest::onloadstart):
+ (WebCore::XMLHttpRequest::setOnprogress):
+ (WebCore::XMLHttpRequest::onprogress):
+ * xml/XMLHttpRequest.idl:
+ * xml/XMLHttpRequestUpload.cpp:
+ (WebCore::XMLHttpRequestUpload::associatedFrame):
+ * xml/XMLHttpRequestUpload.h:
+ (WebCore::XMLHttpRequestUpload::setOnabort):
+ (WebCore::XMLHttpRequestUpload::onabort):
+ (WebCore::XMLHttpRequestUpload::setOnerror):
+ (WebCore::XMLHttpRequestUpload::onerror):
+ (WebCore::XMLHttpRequestUpload::setOnload):
+ (WebCore::XMLHttpRequestUpload::onload):
+ (WebCore::XMLHttpRequestUpload::setOnloadstart):
+ (WebCore::XMLHttpRequestUpload::onloadstart):
+ (WebCore::XMLHttpRequestUpload::setOnprogress):
+ (WebCore::XMLHttpRequestUpload::onprogress):
+ * xml/XMLHttpRequestUpload.idl:
+
+2008-09-30 Darin Adler <darin@apple.com>
+
+ - roll out assertion breaking regression tests
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion
+ that fires in regression tests. Hyatt can add it back later. The assertion
+ fires in the regression test because of layout that triggers repaint occuring
+ during the process of removing a frame.
+
+2008-09-30 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
+ <rdar://problem/6222134> add a way to set color for input placeholder text
+
+ Test: fast/forms/placeholder-pseudo-style.html
+
+ This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
+ input elements when they are displaying the placeholder text.
+
+ * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
+ * css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
+ * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
+ * css/html4.css: Add rule to make placeholder text default to darkGray.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
+ (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
+ (WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
+ (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
+ (WebCore::HTMLInputElement::setValue): ditto.
+ (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
+ (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
+ This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
+ renderer will just ask the node if it should draw the placeholder.
+ * html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color,
+ just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast.
+ If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
+ (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
+ This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
+ is called directly from updateFromElement. updateFromElement will immediately update the text displayed.
+ (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
+ (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
+ * rendering/RenderTextControl.h:
+
+2008-09-30 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
+ by failed allocation due to invalid counter/attr
+ and corresponding: <rdar://problem/6152371>
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseCounterContent): The spec indicates that
+ only identifiers should be accepted here.
+
+2008-09-30 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 21255: console.profileEnd() without a console.profile() crashes the
+ web inspector
+
+ * page/Console.cpp:
+ (WebCore::Console::profileEnd):
+
+2008-09-30 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Bug 21252: calling console.profile() with a title that is 2 chars or
+ shorter does not linkify it
+
+ - Previously we tried to not linkify very short URLs but since profile
+ titles can be any length this is not always true.
+
+ * page/inspector/inspector.js:
+
+2008-09-30 Dave Hyatt <hyatt@apple.com>
+
+ Remove the update() method on ScrollView. This method was only called in one place, and its purpose
+ was to cause a display/flush to happen. Here is a breakdown of the method use on each platform:
+ (1) Not used on Mac
+ (2) Used on Windows
+ (3) Used on Qt, but implemented incorrectly to cause a full repaint for no reason.
+ (4) Used on Gtk, but implemented incorrectly to cause a full repaint for no reason.
+ (5) Used on wx, but probably not needed (since wx has platform widgets like Mac).
+
+ There is now a paint method on HostWindow that does an immediate mode repaint of an empty rect to
+ cause the display/flush to happen if needed (thus saving an extra method on ChromeClient).
+ With the changes to this method, the new behavior is as follows:
+ (1) Not used on Mac
+ (2) Used on Windows
+ (3) Nothing happens on Qt, but only because they have not implemented immediate mode updating.
+ (4) Gtk now behaves like Windows and will process updates but not do any incorrect additional invalidation.
+ (5) Not used on wx
+
+ This method was originally added for Windows. It's not clear the display/flush is really even necessary on the other
+ platforms. At the very least stopping unnecessary full invalidations on Qt/Gtk is a good thing. :)
+
+ Reviewed by Sam Weinig
+
+ * ChangeLog:
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ * platform/HostWindow.h:
+ (WebCore::HostWindow::paint):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-09-30 Timothy Hatcher <timothy@apple.com>
+
+ Focus the DOM tree in the Web Inspector when a node is inspected.
+ So when the search field has focus, the focus moves to the tree,
+ allowing the arrow keys work. This can happen when using the new
+ find in page feature.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21251
+
+ Reviewed by Geoff Garen.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel): Set currentFocusElement to
+ the main-panels element if the panel is visible.
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
+ Remove a set of currentFocusElement since this moved.
+ * page/inspector/inspector.js:
+ (WebInspector.set currentFocusElement): Always focus the element.
+ This ensures that when focus changes in the page and we don't
+ catch it, we will still focus the elements even if we think it
+ was already focused.
+
+2008-09-30 Timothy Hatcher <timothy@apple.com>
+
+ Make the Web Inspector's toolbar icons darker when the mouse is
+ pressed on them. This matches the standard NSToolbar look.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21249
+ rdar://problem/6033752
+
+ Reviewed by Adam Roben.
+
+ * page/inspector/Images/databasesIcon.png:
+ * page/inspector/Images/elementsIcon.png:
+ * page/inspector/Images/profilesIcon.png:
+ * page/inspector/Images/resourcesIcon.png:
+ * page/inspector/Images/scriptsIcon.png:
+ * page/inspector/Panel.js:
+ * page/inspector/inspector.css:
+
+2008-09-30 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Bug 21139: Profiler log message is wrong
+ - Correctly fix =(
+ Don't call _format twice.
+
+ * page/Page.h:
+ * page/inspector/Console.js:
+ * page/inspector/ProfilesPanel.js:
+ * page/inspector/inspector.js:
+
+2008-09-30 Dave Hyatt <hyatt@apple.com>
+
+ http://bugs.webkit.org/show_bug.cgi?id=21250
+
+ Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
+ repaints up through the ChromeClient.
+
+ Reviewed by Darin Adler
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::repaint):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::repaint):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::hostWindow):
+ (WebCore::FrameView::repaintContentRectangle):
+ * page/FrameView.h:
+ * platform/HostWindow.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::repaintContentRectangle):
+ (WebCore::ScrollView::platformRepaintContentRectangle):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformRepaintContentRectangle):
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformRepaintContentRectangle):
+
+2008-09-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Non-Mac build fixes.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCoreSources.bkl:
+ * webcore-base.bkl:
+ Added DOMProtect.{cpp,h}.
+
+2008-09-39 Kevin Decker <kdecker@apple.com>
+
+ Reviewed by John Sullivan.
+
+ * bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way
+ for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
+
+2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21106: .in format discussed changes
+ https://bugs.webkit.org/show_bug.cgi?id=21106
+
+ - Removed "cppNamespace" global parameter and hard-coded "WebCore" as it
+ is the only namespace used.
+
+ - Removed "generateFactory" and "generateWrapperFactory" parameters and
+ re-introduced the command line options.
+
+ - Cleaned up the output of make_names.pl (removed unneeded new line).
+
+ * DerivedSources.make: Added factories command line options.
+ * GNUmakefile.am: Ditto.
+ * WebCore.pro: Ditto and removed some arguments that were migrated to
+ the .in files.
+
+ * dom/make_names.pl: Clean up (see above).
+
+ * html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory"
+ and "generateWrapperFactory" occurences.
+ * html/HTMLTagNames.in: Ditto.
+ * svg/svgattrs.in: Ditto.
+ * svg/svgtags.in: Ditto.
+ * svg/xlinkattrs.in: Ditto.
+ * xml/xmlattrs.in: Ditto.
+
+2008-09-29 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by John Sullivan.
+
+ <rdar://problem/6255456> AX: <file> input button shouldn't have children exposed
+ Make sure that certain types of elements do not return children and, moreover, do not waste their
+ energy trying to return children
+
+ Test: accessibility/nochildren-elements.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::canHaveChildren):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::canHaveChildren):
+ (WebCore::AccessibilityRenderObject::addChildren):
+ * page/AccessibilityRenderObject.h:
+
+2008-09-30 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21213
+ MessagePort crash when GC collects an object with a pending close event
+
+ Test: fast/events/message-channel-gc-2.html
+ fast/events/message-channel-listener-circular-ownership.html
+
+ * bindings/DOMProtect.cpp: Added.
+ (WebCore::gcProtectDOMObject):
+ (WebCore::gcUnprotectDOMObject):
+ * bindings/DOMProtect.h: Added.
+ Added an abstraction for GC protection to avoid the need to call JS bindings code from
+ DOM objects directly.
+
+ * dom/MessagePort.cpp:
+ (WebCore::CloseMessagePortTimer::fired):
+ (WebCore::MessagePort::queueCloseEvent):
+ GC protect MessagePort wrapper while there is a pending close event.
+ This may be necessary for message events, too, but that case is not a crasher, and actually
+ behaves to the letter of the current HTML5 text, so I'll consider it later.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::dropProtection):
+ Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
+
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ (WebCore::JSMessagePort::setOnmessage):
+ (WebCore::JSMessagePort::setOnclose):
+ Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not
+ know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
+
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark):
+ While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not
+ from XMLHttpRequest.
+
+2008-09-30 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * DerivedSources.cpp: Add JSEventTargetNode.cpp.
+
+2008-09-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Tim Hatcher.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
+ Autogenerate JS event listeners
+
+ - Generate EventTargetNode.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventTarget.cpp: Added.
+ (WebCore::toJS):
+ * bindings/js/JSEventTarget.h: Added.
+ * bindings/js/JSEventTargetBase.cpp: Removed.
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetNode.cpp: Removed.
+ * bindings/js/JSEventTargetNode.h: Removed.
+ * bindings/js/JSEventTargetNodeCustom.cpp: Added.
+ (WebCore::JSEventTargetNode::addEventListener):
+ (WebCore::JSEventTargetNode::removeEventListener):
+ (WebCore::JSEventTargetNode::dispatchEvent):
+ (WebCore::JSEventTargetNode::getListener):
+ (WebCore::JSEventTargetNode::setListener):
+ (WebCore::JSEventTargetNode::pushEventHandlerScope):
+ * bindings/js/JSEventTargetSVGElementInstance.cpp:
+ (WebCore::):
+ (WebCore::JSEventTargetSVGElementInstancePrototype::self):
+ (WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot):
+ (jsEventTargetAddEventListener):
+ (jsEventTargetRemoveEventListener):
+ (jsEventTargetDispatchEvent):
+ * bindings/js/JSEventTargetSVGElementInstance.h:
+ (WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype):
+ (WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * dom/EventTargetNode.idl: Added.
+
+2008-09-29 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21214
+ work on getting rid of ExecState
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument
+ for base class constructor.
+
+2008-09-29 David Hyatt <hyatt@apple.com>
+
+ Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
+ now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
+ and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
+ (Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Chrome.h:
+ * platform/HostWindow.h: Added.
+ (WebCore::HostWindow::HostWindow):
+ (WebCore::HostWindow::~HostWindow):
+
+2008-09-29 Kevin Decker <kdecker@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ * bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
+ 2000.
+
+2008-09-29 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adam Roben.
+
+ - WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added.
+ (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being
+ unloaded, to avoid calling uxtheme.dll functions after that library has
+ been unloaded.
+ * rendering/RenderThemeWin.h:
+
+2008-09-29 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by John Sullivan
+
+ <rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas
+
+ Sends AXLoadComplete only when the top level web area is finished loading
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+
+2008-09-29 Timothy Hatcher <timothy@apple.com>
+
+ Makes the node highlight always show up when hovering a node in
+ the Web Inspector now that the highlight does not scroll to reveal
+ the node. Also adds a hover effect in the inspector when hovering
+ causes a highlight in the page. This ties the user hovering action
+ to the highlight so it is clear what causes the highlight to appear.
+
+ Also the highlight now temporarily shows up for 2 seconds after
+ selecting a node in the DOM tree. So arrowing around in the tree
+ will show the node on the page, providing feedback to the user.
+
+ Plus fixes an issue where quickly moving away from hovering
+ a node would keep showing the page highlight. This was happening
+ in breadcrumbs and the DOM tree.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21220
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype._mouseOverNode): Added. Used for
+ hovering DOM nodes in the console.
+ (WebInspector.Console.prototype._mouseOutOfNode): Ditto.
+ (WebInspector.Console.prototype._formatnode): Use the new event
+ listeners and add a class name to the anchor element.
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel): Add new event listeners to the
+ crumbs element to do the node hovering highlight.
+ (WebInspector.ElementsPanel.prototype.hide):
+ (WebInspector.ElementsPanel.prototype.reset):
+ (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
+ (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
+ * page/inspector/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
+ Show the node hishlight for 2 seconds then restore the highlight
+ to the current hovered node.
+ (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the
+ hovered node and set the hovered state on the tree element.
+ (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the
+ hovered node to null and removed the hovered state from the previous
+ hovered tree element.
+ (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds
+ the hovered class to the list item.
+ (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
+ * page/inspector/inspector.css:
+ * page/inspector/inspector.js:
+ (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon
+ based on the showingDOMNodeHighlight property of 50ms or 500ms. This
+ causes the highlight to change sooner if there is one already showing
+ and appear later if there isn't one showing. This is like tooltips,
+ hovering a node for 500ms will cause highlight then mousing between nodes
+ will keep the highlight and change to the new node.
+ (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and
+ always reset the timeout so continuous mousing does not keep flasshing
+ the highlight on the screen.
+ (WebInspector._updateHoverHighlight): Removed the alt key check and added
+ the showingDOMNodeHighlight property.
+ (WebInspector.documentKeyDown): Removed the alt key check.
+ (WebInspector.documentKeyUp): Ditto.
+ (WebInspector.reset): Clear the hoveredDOMNode.
+
+2008-09-29 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Anders Carlsson
+
+ Fix RenderStyle leak in animation code, and assert that
+ keyframe resolution in CSSStyleSelector is not going to clobber
+ m_style.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::~KeyframeAnimation):
+
+2008-09-29 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
+ Rewrite keyframe resolution to be like styleForElement()
+
+ Test: animations/lineheight-animation.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::addKeyframeStyle):
+ (WebCore::CSSStyleSelector::~CSSStyleSelector):
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
+ (WebCore::CSSRuleSet::addRulesFromSheet):
+ (WebCore::CSSStyleSelector::mapAnimationName):
+ * css/CSSStyleSelector.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::KeyframeAnimation):
+ (WebCore::KeyframeAnimation::animate):
+ (WebCore::KeyframeAnimation::hasAnimationForProperty):
+ (WebCore::KeyframeAnimation::sendAnimationEvent):
+ (WebCore::KeyframeAnimation::overrideAnimations):
+ (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
+ (WebCore::KeyframeAnimation::affectsProperty):
+ (WebCore::KeyframeAnimation::validateTransformFunctionList):
+ * page/animation/KeyframeAnimation.h:
+ * rendering/style/Animation.cpp:
+ (WebCore::Animation::animationsMatch):
+ * rendering/style/Animation.h:
+ * rendering/style/KeyframeList.cpp:
+ (WebCore::KeyframeList::~KeyframeList):
+ (WebCore::KeyframeList::clear):
+ (WebCore::KeyframeList::insert):
+ * rendering/style/KeyframeList.h:
+ (WebCore::KeyframeValue::KeyframeValue):
+ (WebCore::KeyframeList::KeyframeList):
+ (WebCore::KeyframeList::operator!=):
+ (WebCore::KeyframeList::animationName):
+ (WebCore::KeyframeList::addProperty):
+ (WebCore::KeyframeList::containsProperty):
+ (WebCore::KeyframeList::beginProperties):
+ (WebCore::KeyframeList::endProperties):
+ (WebCore::KeyframeList::isEmpty):
+ (WebCore::KeyframeList::size):
+ (WebCore::KeyframeList::beginKeyframes):
+ (WebCore::KeyframeList::endKeyframes):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ * rendering/style/StyleRareNonInheritedData.h:
+
+2008-09-29 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Clean up fix in PropertyWrapperGetter::equals
+ https://bugs.webkit.org/show_bug.cgi?id=21011
+
+ Test: transitions/override-transition-crash.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::PropertyWrapperGetter::equals):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+
+2008-09-29 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Eric Seidel
+
+ https://bugs.webkit.org/show_bug.cgi?id=21001
+ Starting transition after animation, when animation
+ is finished, transition is wrong.
+
+ Test: animations/transition-and-animation-2.html
+
+ * page/animation/AnimationBase.h:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ (WebCore::CompositeAnimation::resetTransitions):
+ (WebCore::CompositeAnimation::cleanupFinishedAnimations):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::ImplicitAnimation):
+ (WebCore::ImplicitAnimation::~ImplicitAnimation):
+ (WebCore::ImplicitAnimation::animate):
+ (WebCore::ImplicitAnimation::reset):
+ * page/animation/ImplicitAnimation.h:
+
+2008-09-29 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=20921
+ -webkit-animation-timing-function: inside of keyframes is ignored
+
+ Test: animations/keyframe-timing-functions.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::progress):
+ * page/animation/AnimationBase.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+
+2008-09-29 Dan Bernstein <mitz@apple.com>
+
+ - Windows build fix
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::platformScroll):
+
+2008-09-29 Dan Bernstein <mitz@apple.com>
+
+ - another attempt at a Windows build fix
+
+ * platform/ScrollView.cpp:
+ (WebCore::platformScroll):
+
+2008-09-29 Dan Bernstein <mitz@apple.com>
+
+ - Windows build fix
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::platformSetScrollPosition):
+
+2008-09-29 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21218
+
+ Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
+ It's silly that the code was this fragile, but for now just put the check back in.
+
+ Reviewed by Dan Bernstein
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setScrollbarModes):
+
+2008-09-29 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21216
+
+ Make setScrollPosition and scroll() cross-platform.
+
+ Reviewed by Anders
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setScrollPosition):
+ (WebCore::ScrollView::scroll):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformSetScrollPosition):
+ (WebCore::ScrollView::platformScroll):
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetScrollPosition):
+ (WebCore::ScrollView::platformScroll):
+
+2008-09-29 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Oliver.
+
+ Bug 21139: Profiler log message is wrong
+ - Because _format was called twice the number in the log was incremented
+ too many times, but we were passing it around in the link the whole time
+
+ * page/inspector/ProfilesPanel.js:
+ * page/inspector/inspector.js:
+
+2008-09-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Cameron Zwarich.
+
+ Autogenerate EventListeners, addEventListener and removeEventListener
+ for JSDOMWindow.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::onwebkitanimationstart):
+ (WebCore::JSDOMWindow::setOnwebkitanimationstart):
+ (WebCore::JSDOMWindow::onwebkitanimationiteration):
+ (WebCore::JSDOMWindow::setOnwebkitanimationiteration):
+ (WebCore::JSDOMWindow::onwebkitanimationend):
+ (WebCore::JSDOMWindow::setOnwebkitanimationend):
+ (WebCore::JSDOMWindow::onwebkittransitionend):
+ (WebCore::JSDOMWindow::setOnwebkittransitionend):
+ (WebCore::JSDOMWindow::addEventListener):
+ (WebCore::JSDOMWindow::removeEventListener):
+ (WebCore::JSDOMWindow::setListener):
+ (WebCore::JSDOMWindow::getListener):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * page/DOMWindow.idl:
+
+2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
+
+ Reviewed by Simon.
+
+ Changed copyright from Trolltech ASA to Nokia.
+
+ Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
+
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ * bindings/js/JSNavigatorCustom.cpp:
+ * bindings/js/JSPluginArrayCustom.cpp:
+ * bindings/js/JSPluginCustom.cpp:
+ * bindings/js/ScriptControllerMac.mm:
+ * bindings/js/ScriptControllerQt.cpp:
+ * bridge/qt/qt_class.cpp:
+ * bridge/qt/qt_class.h:
+ * bridge/qt/qt_instance.cpp:
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ * bridge/qt/qt_runtime.h:
+ * bridge/testqtbindings.cpp:
+ * css/makegrammar.pl:
+ * css/makeprop.pl:
+ * css/makevalues.pl:
+ * dom/Node.cpp:
+ * dom/TagNodeList.cpp:
+ * dom/TagNodeList.h:
+ * dom/XMLTokenizer.cpp:
+ * dom/XMLTokenizer.h:
+ * dom/XMLTokenizerLibxml2.cpp:
+ * dom/XMLTokenizerQt.cpp:
+ * editing/Editor.cpp:
+ * editing/EditorCommand.cpp:
+ * html/CanvasRenderingContext2D.cpp:
+ * html/CanvasStyle.cpp:
+ * html/HTMLAppletElement.cpp:
+ * html/HTMLEmbedElement.cpp:
+ * html/HTMLObjectElement.cpp:
+ * loader/FrameLoader.cpp:
+ * page/Chrome.cpp:
+ * page/EditorClient.h:
+ * page/Frame.cpp:
+ * page/Frame.h:
+ * page/FramePrivate.h:
+ * page/Navigator.cpp:
+ * page/Navigator.h:
+ * page/Navigator.idl:
+ * page/mac/FrameMac.mm:
+ * page/qt/EventHandlerQt.cpp:
+ * platform/graphics/qt/FontCacheQt.cpp:
+ * platform/graphics/qt/FontCustomPlatformData.cpp:
+ * platform/graphics/qt/FontCustomPlatformData.h:
+ * platform/graphics/qt/FontPlatformData.h:
+ * platform/graphics/qt/FontQt.cpp:
+ * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ * platform/graphics/qt/ImageDecoderQt.h:
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
+ * platform/graphics/qt/SimpleFontDataQt.cpp:
+ * platform/gtk/MIMETypeRegistryGtk.cpp:
+ * platform/mac/MIMETypeRegistryMac.mm:
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ * platform/network/qt/QNetworkReplyHandler.h:
+ * platform/network/qt/ResourceHandleQt.cpp:
+ * platform/network/qt/ResourceRequestQt.cpp:
+ * platform/qt/ClipboardQt.cpp:
+ * platform/qt/EventLoopQt.cpp:
+ * platform/qt/KURLQt.cpp:
+ * platform/qt/LoggingQt.cpp:
+ * platform/qt/MIMETypeRegistryQt.cpp:
+ * platform/qt/PasteboardQt.cpp:
+ * platform/qt/PlatformScreenQt.cpp:
+ * platform/qt/PopupMenuQt.cpp:
+ * platform/qt/QWebPopup.cpp:
+ * platform/qt/QWebPopup.h:
+ * platform/qt/RenderThemeQt.cpp:
+ * platform/qt/ScrollbarQt.cpp:
+ * platform/qt/ScrollbarThemeQt.cpp:
+ * platform/qt/WheelEventQt.cpp:
+ * platform/qt/html4-adjustments-qt.css:
+ * platform/wx/MimeTypeRegistryWx.cpp:
+ * plugins/MimeType.cpp:
+ * plugins/MimeType.h:
+ * plugins/MimeType.idl:
+ * plugins/MimeTypeArray.cpp:
+ * plugins/MimeTypeArray.h:
+ * plugins/MimeTypeArray.idl:
+ * plugins/Plugin.cpp:
+ * plugins/Plugin.h:
+ * plugins/Plugin.idl:
+ * plugins/PluginArray.cpp:
+ * plugins/PluginArray.h:
+ * plugins/PluginArray.idl:
+ * plugins/PluginData.cpp:
+ * plugins/PluginData.h:
+ * plugins/gtk/PluginDataGtk.cpp:
+ * plugins/mac/PluginDataMac.mm:
+ * plugins/qt/PluginDataQt.cpp:
+ * plugins/win/PluginDataWin.cpp:
+ * rendering/RenderTableCol.cpp:
+ * rendering/RenderTableCol.h:
+
+2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>
+
+ Reviewed by Simon
+
+ Fix compilation with gcc 4.3
+
+ gcc 4.3 is stricter and ctype.h isn't getting included
+ automatically here by dependencies. So do it directly.
+
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+
+2008-09-29 Morten Sørvig <msorvig@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation with Qt/Mac without plugins.
+
+ * platform/qt/TemporaryLinkStubs.cpp:
+
+2008-09-29 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
+ In the few places that we call .upper() in WebCore the strings represent things like
+ tag and attribute names, which are nearly always going to be ASCII.
+
+ * platform/text/StringImpl.cpp:
+ (WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
+ in to Unicode::toLower the second time.
+ (WebCore::StringImpl::upper):
+
+2008-09-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
+ rather than String::operator+=.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+
+2008-09-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Speed up computedStyle.getPropertyValue('color') by 4.5x.
+
+ Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
+ as it avoids many memory reallocations.
+
+ This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
+ by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
+ unrelated properties on an element.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
+ and use appendNumber rather than the String::number in order to cut down on memory allocations.
+ * platform/text/PlatformString.h:
+ (WebCore::appendNumber): A helper function for formatting an unsigned character as a number
+ into a Vector<UChar>.
+
+2008-09-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Remove spurious call to lower().
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::MediaQueryEvaluator):
+
+2008-09-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Use a CaseFoldingHash instead of calling lower on family strings.
+
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::addFontFaceRule):
+ (WebCore::CSSFontSelector::getFontData):
+ * css/CSSFontSelector.h:
+
+2008-09-28 Timothy Hatcher <timothy@apple.com>
+
+ Remove the scrollIntoViewIfNeeded() call when drawing the
+ Inspector node highlight.
+
+ <rdar://problem/6115804> Don't scroll when highlighting (21000)
+ https://bugs.webkit.org/show_bug.cgi?id=21000
+
+ Reviewed by Dan Bernstein.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::drawNodeHighlight):
+
+2008-09-28 David Hyatt <hyatt@apple.com>
+
+ Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
+ changed.
+
+ Reviewed by Dan Bernstein
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
+
+2008-09-28 Timothy Hatcher <timothy@apple.com>
+
+ Clear the current search results in the Inspector when
+ the search query is less than 3 characters long. Incremental
+ searches only occur for 3 characters or longer, but deleting
+ under this limit would not clear the results unless the whole
+ query was deleted.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21196
+
+ Reviewed by Dan Bernstein.
+
+ * page/inspector/inspector.js:
+ (WebInspector.performSearch): Check for short queries in the
+ if statement that triggers the clear.
+
+2008-09-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
+
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and
+ overlayLength parameters.
+ (WebCore::EOTStream::read): Added code to overlay the
+ m_overlayLength bytes starting at m_overlayDst with the same number of
+ bytes from m_overlaySrc.
+ (WebCore::createFontCustomPlatformData): Changed to get overlay
+ parameters from getEOTHeader.
+ * platform/graphics/win/GetEOTHeader.cpp:
+ (WebCore::getEOTHeader): Added code to specify overlaying of the
+ family name with the prefix of the full name if they differ, because
+ that such a difference causes TTLoadEmbeddedFont to fail.
+ * platform/graphics/win/GetEOTHeader.h:
+
+2008-09-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20366
+ Reproducible test failure for editing/undo/undo-iframe-location-change.html
+
+ * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
+
+2008-09-28 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig (except for a few comment and header tweaks).
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21158
+ reduce use of virtual functions in Node for speed
+
+ Speeds up Dromaeo a bit less than 1%.
+
+ * bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of
+ Node.h now that some inlines are in there.
+
+ * dom/Attr.h: Override both the virtual and non-virtual name functions.
+
+ * dom/ChildNodeList.cpp:
+ (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
+ * dom/ChildNodeList.h: Ditto.
+ * dom/ClassNodeList.cpp:
+ (WebCore::ClassNodeList::nodeMatches): Ditto.
+ * dom/ClassNodeList.h: Ditto.
+
+ * dom/Document.h: Put the Node::isDocumentNode() function's inline
+ definition here where it can see the Document class definition.
+
+ * dom/DynamicNodeList.cpp:
+ (WebCore::DynamicNodeList::length): Changed to pass an Element.
+ (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto.
+ (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto.
+ (WebCore::DynamicNodeList::itemWithName): Ditto.
+ * dom/DynamicNodeList.h: Ditto.
+
+ * dom/Element.cpp: Removed virtualHasTagName.
+ * dom/Element.h: Made localName, prefix, namespaceURI, and
+ styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName,
+ virtualNamespaceURI, and removed virtualHasTagName. Put the
+ Node::hasTagName, Node::hasAttributes, and Node::attributes
+ functions' inline definitions here where they can see the Element
+ class definition.
+
+ * dom/NameNodeList.cpp:
+ (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
+ * dom/NameNodeList.h: Ditto.
+
+ * dom/Node.cpp:
+ (WebCore::Node::virtualPrefix): Renamed from prefix.
+ (WebCore::Node::virtualLocalName): Renamed from localName.
+ (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI.
+ (WebCore::Node::styleForRenderer): Handle the Element case here.
+
+ * dom/Node.h: Removed definition of hasTagName that calls virtual,
+ since we now have a non-virtual version. Made hasAttributes,
+ attributes, remove, localName, namespaceURI, prefix, isDocumentNode,
+ and styleForRenderer non-virtual. Added virtualPrefix,
+ virtualLocalName, and virtualNamespaceURI. Removed isMalformed
+ and setMalformed, which are used only on HTMLFormElement objects.
+
+ * dom/TagNodeList.cpp:
+ (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
+ * dom/TagNodeList.h: Ditto.
+
+ * html/HTMLAnchorElement.cpp: Added a comment.
+ * html/HTMLFormControlElement.cpp: Ditto.
+
+ * html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex
+ function. Marked tabIndex function virtual explicitly for clarity.
+
+ * html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex
+ function. Marked isFocusable function virtual explicitly for clarity.
+
+ * html/HTMLElement.h: Marked tabIndex function virtual explicitly for
+ clarity.
+ * html/HTMLFormControlElement.h: Ditto.
+
+ * html/HTMLFormElement.h: Made isMalformed non-virtual.
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement
+ pointer to call localName since that one does not need to call a virtual
+ function.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before
+ calling isMalformed. We already did a tag name check so we know it's
+ an HTMLFormELement.
+
+ * xml/XPathUtil.cpp:
+ (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls
+ to nodeType(), since it's a virtual function.
+
+2008-09-28 David Hyatt <hyatt@apple.com>
+
+ Make frameRectsChanged() cross-platform on ScrollView.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::frameRectsChanged):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-09-28 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21141: REGRESSION: Exception messages for user entered commands are poor
+ <https://bugs.webkit.org/show_bug.cgi?id=21141>
+
+ The bug repsonsible for this was the the JSInspectedObjectWrapper instances
+ were not initialising their StructureID's to indicate that the wrapper
+ overrides hasInstance, etc. The solution is simply to use the createStructureID
+ helper on JSQuarantinedObjectWrapper to create a correct StructureID.
+
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+
+2008-09-28 David Hyatt <hyatt@apple.com>
+
+ Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
+ terms of lines.
+
+ Reviewed by Oliver Hunt
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchWheelEvent):
+
+2008-09-28 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21191
+
+ Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
+ on ScrollView to be cross-platform.
+
+ Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
+ events are now pixel wheel events.
+
+ Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
+ (1) Page scrolling has been corrected to be properly detected (on Windows
+ page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
+ old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
+ you could page scroll horizontally.
+ (2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
+ This caused the scroll amount for page scrolling to be way too large on layers.
+
+ Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.
+
+ Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
+ for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).
+
+ Reviewed by Oliver Hunt
+
+ * editing/EditorCommand.cpp:
+ (WebCore::verticalScrollDistance):
+ * page/EventHandler.cpp:
+ (WebCore::scrollAndAcceptEvent):
+ (WebCore::EventHandler::handleWheelEvent):
+ * platform/PlatformWheelEvent.h:
+ (WebCore::):
+ (WebCore::PlatformWheelEvent::pos):
+ (WebCore::PlatformWheelEvent::globalPos):
+ (WebCore::PlatformWheelEvent::deltaX):
+ (WebCore::PlatformWheelEvent::deltaY):
+ (WebCore::PlatformWheelEvent::granularity):
+ (WebCore::PlatformWheelEvent::x):
+ (WebCore::PlatformWheelEvent::globalX):
+ (WebCore::PlatformWheelEvent::ignore):
+ (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
+ (WebCore::PlatformWheelEvent::verticalLineMultiplier):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/Scrollbar.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/gtk/WheelEventGtk.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/mac/ScrollViewMac.mm:
+ * platform/mac/WheelEventMac.mm:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/qt/WheelEventQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/win/WheelEventWin.cpp:
+ (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
+ (WebCore::PlatformWheelEvent::verticalLineMultiplier):
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
+ (WebCore::ScrollView::wheelEvent):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+
+2008-09-27 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ fix https://bugs.webkit.org/show_bug.cgi?id=20994
+ <rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned
+
+ HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
+ all unsigned media attributes from string with toUInt() instead of toInt().
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().
+
+ * html/HTMLVideoElement.cpp:
+ (WebCore::HTMLVideoElement::videoWidth):
+ (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl.
+ (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return
+ unsigned value.
+ (WebCore::HTMLVideoElement::height): Ditto.
+ (WebCore::HTMLVideoElement::setWidth): take unsigned value.
+ (WebCore::HTMLVideoElement::setHeight): Ditto.
+
+ * html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.
+
+ * html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.
+
+2008-09-27 Timothy Hatcher <timothy@apple.com>
+
+ Fixes an exception when typing a command in the Console.
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype.addMessage): Null check
+ this.previosMessage.
+
+2008-09-27 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where the Profiles panel sidebar would be empty
+ after closing and reopening the Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21179
+
+ Reviewed by Sam Weinig.
+
+ * page/inspector/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.reset): Don't call
+ populateInterface, it is called automatically.
+ (WebInspector.ProfilesPanel.prototype._populateProfiles):
+ Return early if the sidebar is already populated.
+
+2008-09-27 Dave Hyatt <hyatt@apple.com>
+
+ Bug 21190. The line scroll amount on Windows is way too small. A patch for bug 17589 for wheel sensitivity
+ incorrectly applied the tinier wheel step delta (unmultiplied) to line scrolling. Line scrolling with the
+ scrollbar has nothing to do with mouse wheeling. This patch reverts the scrollbars to use the same line
+ step as other platforms while leaving the wheel delta alone for use with wheel scrolling.
+
+ There was a lot wrong with 17589, so more patches will be coming to deal with the fallout of this patch
+ (which should never have landed in the first place).
+
+ Reviewed by Tim Hatcher, Sam Weinig
+
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::adjustDeltaForPageScrollMode):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::wheelEvent):
+
+2008-09-27 David Hyatt <hyatt@apple.com>
+
+ Make the scrollbarUnderMouse method cross-platform.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Gtk+ build fix.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+
+2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20287
+ [Gtk] disable plugins for gtk/directfb target
+
+ Introduce WTF_PLATFORM_X11 for X11 builds.
+ Also use target-specific packages when building the port
+
+ * platform/gtk/PlatformScreenGtk.cpp:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::getValueStatic):
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::init):
+
+2008-09-27 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21188
+
+ Make scrollbar suppression and resizer avoidance cross-platform.
+
+ Reviewed by Anders
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::transitionToCommitted):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::resetScrollbars):
+ (WebCore::FrameView::clear):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::restoreScrollbar):
+ (WebCore::FrameView::windowResizerRect):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::init):
+ (WebCore::ScrollView::resizerOverlapsContent):
+ (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
+ (WebCore::ScrollView::setParent):
+ (WebCore::ScrollView::setScrollbarsSuppressed):
+ (WebCore::ScrollView::platformSetScrollbarsSuppressed):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::scrollbarsSuppressed):
+ (WebCore::ScrollView::windowResizerRect):
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::setFrameRect):
+ (WebCore::Scrollbar::setParent):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::paint):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+ (WebCore::ScrollView::platformSetScrollbarsSuppressed):
+ (WebCore::ScrollView::setScrollPosition):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::frameRectsChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::paint):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::paint):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+
+2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber-stamped by Anders Carlsson.
+
+ Compile fix.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::load):
+
+2008-09-27 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
+ Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html
+
+ Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.
+
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::~CachedResource):
+
+2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [qt] Use QImageReader to figure out which image formats are supported
+ - Qt can have many different plugins for different image formats. Instead
+ of checking only for a few in WebCore use Qt to determine if this data
+ can be treated as an image.
+
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::canHandleImage):
+ (WebCore::createDecoder):
+
+2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
+
+
+ [qt] Clean the pattern code
+ - Use save/restore on the painter after manipulating the
+ pen/brush
+ - Make the context and object null checking consistent. CG is using
+ the object unconditionally so the Qt webkit platform can do the
+ same.
+ - Move code below the early exit. Only use the m_ownerElement before
+ the early exit as the CG code is doing it.
+
+ * svg/graphics/SVGPaintServerPattern.h:
+ * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+ (WebCore::SVGPaintServerPattern::teardown):
+
+2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
+
+ Added support for console.trace.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19157
+
+ Reviewed by Kevin McCullough and Tim Hatcher.
+
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::trace):
+ * page/Console.cpp:
+ (WebCore::Console::trace): Calls Machine::retrieveCaller to
+ get a stack trace.
+ * page/Console.h:
+ (WebCore::): Added TraceMessageLevel.
+ * page/Console.idl: Added console.trace.
+ * page/inspector/Console.js:
+ (ConsoleMessage): Added case for TraceMessageLevel.
+
+2008-09-27 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21178
+ <rdar://problem/6248651>
+
+ Check if the plug-in is allowed to load the resource. This matches Firefox.
+
+ Test: http/tests/plugins/local-geturl-from-remote.html
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::load):
+
+2008-09-22 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Added SVG pattern support to Qt.
+
+ [Qt] SVG patterns are missing
+ https://bugs.webkit.org/show_bug.cgi?id=20973
+
+ * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+
+2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
+
+ Fixed a bug in the JS syntax highlighter with multiple line tokens.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21171
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/SourceFrame.js:
+ (syntaxHighlightJavascriptLine): Initialize previousMatchLength.
+
+2008-09-27 Timothy Hatcher <timothy@apple.com>
+
+ Change searching in the Profiles panel to not match the
+ Self and Total columns when there are no units. The only
+ column that is matched for unitless number searches is
+ now the Calls column.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21169
+
+ Reviewed by Sam Weinig.
+
+ * page/inspector/ProfileView.js:
+ (WebInspector.ProfileView.prototype.performSearch):
+
+2008-09-27 David Hyatt <hyatt@apple.com>
+
+ Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollView.h:
+ * platform/Widget.h:
+ (WebCore::Widget::boundsRect):
+ (WebCore::Widget::invalidate):
+ (WebCore::Widget::frameRectsChanged):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollViewScrollbar::frameRectsChanged):
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::frameRectsChanged):
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::setFrameRect):
+ (ScrollbarGtk::frameRectsChanged):
+ * platform/gtk/ScrollbarGtk.h:
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::frameRectsChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::frameRectsChanged):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::frameRectsChanged):
+ * plugins/PluginView.h:
+
+2008-09-27 Simon Hausmann <hausmann@webkit.org>
+
+ Refix the previous build fix to compile on non-Qt platforms, too.
+
+ * WebCore.pro: Don't pass -i to create_hashtable, added missing -n
+ WebCore to generate the PrototypeTable in the WebCore namespace
+ * bindings/js/JSEventTargetBase.h: Revert previous fix, the Prototype
+ table remains in the Webcore namespace
+ (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
+
+2008-09-27 Simon Hausmann <hausmann@webkit.org>
+
+ Fix compilation with gcc 4.3 (probably > 4.0)
+
+ * bindings/js/JSDOMWindowBase.cpp: Don't define static property
+ get/put functions inside the WebCore namespace.
+ * bindings/js/JSEventTargetBase.cpp: Ditto.
+ * bindings/js/JSEventTargetNode.cpp: Ditto.
+ * bindings/js/JSEventTargetSVGElementInstance.cpp: Ditto.
+ * bindings/js/JSEventTargetBase.h: Forward declare
+ JSEventTargetPrototypeTable in the JSC namespace as the lut.h file
+ defines it in the JSC namespace.
+ (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): Add JSC::
+ prefix for PrototypeTable symbol.
+
+2008-09-27 David Hyatt <hyatt@apple.com>
+
+ Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.
+
+ Reviewed by Dan Bernstein
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::FrameView):
+ (WebCore::FrameView::updateControlTints):
+ * platform/ScrollView.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::paint):
+ (WebCore::Scrollbar::setFrameRect):
+ * platform/Scrollbar.h:
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/Widget.h:
+ (WebCore::Widget::x):
+ (WebCore::Widget::y):
+ (WebCore::Widget::width):
+ (WebCore::Widget::height):
+ (WebCore::Widget::size):
+ (WebCore::Widget::pos):
+ (WebCore::Widget::resize):
+ (WebCore::Widget::move):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollViewScrollbar::geometryChanged):
+ (WebCore::ScrollView::update):
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::paint):
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::setFrameRect):
+ (ScrollbarGtk::geometryChanged):
+ * platform/gtk/ScrollbarGtk.h:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::trackRect):
+ (WebCore::ScrollbarThemeMac::paint):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::paint):
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::invalidateItem):
+ (WebCore::PopupMenu::valueChanged):
+ (WebCore::PopupWndProc):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::setFrameRect):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::paint):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarThemeSafari::trackRect):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::frameRect):
+ (WebCore::Widget::setFrameRect):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::setFrameRect):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::init):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::init):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ (WebCore::PluginView::paintMissingPluginIcon):
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::init):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::positionOverflowControls):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintScrollbar):
+ * rendering/RenderPart.cpp:
+ (WebCore::RenderPart::updateWidgetPosition):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::setWidgetGeometry):
+ (WebCore::RenderWidget::updateWidgetPosition):
+
+2008-09-27 David Hyatt <hyatt@apple.com>
+
+ <rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF
+
+ This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
+ access an actual member variable.
+
+ Reviewed by Dan Bernstein
+
+ * page/FocusController.cpp:
+ (WebCore::FocusController::setFocusedFrame):
+
+2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Attempt to fix QT Build. Not reviewed.
+
+ * WebCore.pro: add -n WebCore parameter to create_hash_table
+
+2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
+
+ Reviewed by Eric Seidel.
+
+ http://bugs.webkit.org/show_bug.cgi?id=18905
+ [GTK] Fix build with older pango (1.14.8)
+
+ * platform/graphics/gtk/FontGtk.cpp:
+ * platform/gtk/Language.cpp:
+ (_pango_get_lc_ctype):
+ (pango_language_get_default):
+
+2008-09-26 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21168
+
+ Make contentsToWindow/windowToContents cross-platform.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::windowToContents):
+ (WebCore::ScrollView::contentsToWindow):
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-09-26 Sam Weinig <sam@webkit.org>
+
+ GTK build fix.
+
+ * GNUmakefile.am:
+
+2008-09-26 David Hyatt <hyatt@apple.com>
+
+ Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
+ offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
+ more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.
+
+ Reviewed by Oliver Hunt
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::repaintContentRectangle):
+ * page/FrameView.h:
+ * platform/ScrollView.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::isOffscreen):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::updateContents):
+ (WebCore::ScrollView::isOffscreen):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::isOffscreen):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::isOffscreen):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::isOffscreen):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::willRenderImage):
+
+2008-09-26 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21164
+
+ Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setAllowsScrolling):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setAllowsScrolling):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::allowsScrolling):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::wheelEvent):
+
+2008-09-26 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after Widget/ScrollView changes.
+
+ * platform/wx/PopupMenuWx.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetContentsSize):
+ (WebCore::ScrollView::platformSetScrollbarModes):
+ (WebCore::ScrollView::wheelEvent):
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::containingWindow):
+
+2008-09-26 Timothy Hatcher <timothy@apple.com>
+
+ Allow searching for paths by always performing the
+ three search methods in the Elements panel and not
+ assume a search with a "/" is a XPath query.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21159
+
+ Reviewed by Geoff Garen.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.performSearch):
+
+2008-09-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
+ Speedup static property get/put
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::getDOMConstructor):
+ (WebCore::jsDOMWindowBaseCrypto):
+ (WebCore::jsDOMWindowBaseEvent):
+ (WebCore::jsDOMWindowBaseImage):
+ (WebCore::jsDOMWindowBaseMessageChannel):
+ (WebCore::jsDOMWindowBaseOption):
+ (WebCore::jsDOMWindowBaseXMLHttpRequest):
+ (WebCore::jsDOMWindowBaseAudio):
+ (WebCore::jsDOMWindowBaseXSLTProcessor):
+ (WebCore::jsDOMWindowBaseOnabort):
+ (WebCore::jsDOMWindowBaseOnblur):
+ (WebCore::jsDOMWindowBaseOnchange):
+ (WebCore::jsDOMWindowBaseOnclick):
+ (WebCore::jsDOMWindowBaseOndblclick):
+ (WebCore::jsDOMWindowBaseOnerror):
+ (WebCore::jsDOMWindowBaseOnfocus):
+ (WebCore::jsDOMWindowBaseOnkeydown):
+ (WebCore::jsDOMWindowBaseOnkeypress):
+ (WebCore::jsDOMWindowBaseOnkeyup):
+ (WebCore::jsDOMWindowBaseOnload):
+ (WebCore::jsDOMWindowBaseOnmousedown):
+ (WebCore::jsDOMWindowBaseOnmousemove):
+ (WebCore::jsDOMWindowBaseOnmouseout):
+ (WebCore::jsDOMWindowBaseOnmouseover):
+ (WebCore::jsDOMWindowBaseOnmouseup):
+ (WebCore::jsDOMWindowBaseOnMouseWheel):
+ (WebCore::jsDOMWindowBaseOnreset):
+ (WebCore::jsDOMWindowBaseOnresize):
+ (WebCore::jsDOMWindowBaseOnscroll):
+ (WebCore::jsDOMWindowBaseOnsearch):
+ (WebCore::jsDOMWindowBaseOnselect):
+ (WebCore::jsDOMWindowBaseOnsubmit):
+ (WebCore::jsDOMWindowBaseOnbeforeunload):
+ (WebCore::jsDOMWindowBaseOnunload):
+ (WebCore::jsDOMWindowBaseOnWebKitAnimationStart):
+ (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration):
+ (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd):
+ (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd):
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+ (WebCore::JSDOMWindowBase::put):
+ (WebCore::setJSDOMWindowBaseOnabort):
+ (WebCore::setJSDOMWindowBaseOnblur):
+ (WebCore::setJSDOMWindowBaseOnchange):
+ (WebCore::setJSDOMWindowBaseOnclick):
+ (WebCore::setJSDOMWindowBaseOndblclick):
+ (WebCore::setJSDOMWindowBaseOnerror):
+ (WebCore::setJSDOMWindowBaseOnfocus):
+ (WebCore::setJSDOMWindowBaseOnkeydown):
+ (WebCore::setJSDOMWindowBaseOnkeypress):
+ (WebCore::setJSDOMWindowBaseOnkeyup):
+ (WebCore::setJSDOMWindowBaseOnload):
+ (WebCore::setJSDOMWindowBaseOnmousedown):
+ (WebCore::setJSDOMWindowBaseOnmousemove):
+ (WebCore::setJSDOMWindowBaseOnmouseout):
+ (WebCore::setJSDOMWindowBaseOnmouseover):
+ (WebCore::setJSDOMWindowBaseOnmouseup):
+ (WebCore::setJSDOMWindowBaseOnMouseWheel):
+ (WebCore::setJSDOMWindowBaseOnreset):
+ (WebCore::setJSDOMWindowBaseOnresize):
+ (WebCore::setJSDOMWindowBaseOnscroll):
+ (WebCore::setJSDOMWindowBaseOnsearch):
+ (WebCore::setJSDOMWindowBaseOnselect):
+ (WebCore::setJSDOMWindowBaseOnsubmit):
+ (WebCore::setJSDOMWindowBaseOnbeforeunload):
+ (WebCore::setJSDOMWindowBaseOnunload):
+ (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart):
+ (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration):
+ (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd):
+ (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd):
+ (WebCore::setJSDOMWindowBaseEvent):
+ (WebCore::setJSDOMWindowBaseAudio):
+ (WebCore::setJSDOMWindowBaseImage):
+ (WebCore::setJSDOMWindowBaseMessageChannel):
+ (WebCore::setJSDOMWindowBaseOption):
+ (WebCore::setJSDOMWindowBaseXMLHttpRequest):
+ (WebCore::setJSDOMWindowBaseXSLTProcessor):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::nonCachingStaticCloseFunctionGetter):
+ (WebCore::nonCachingStaticBlurFunctionGetter):
+ (WebCore::nonCachingStaticFocusFunctionGetter):
+ (WebCore::nonCachingStaticPostMessageFunctionGetter):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customGetOwnPropertySlot):
+ * bindings/js/JSEventTargetBase.cpp:
+ * bindings/js/JSEventTargetBase.h:
+ (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
+ (WebCore::JSEventTargetBasePrototype::classInfo):
+ * bindings/js/JSEventTargetNode.cpp:
+ (WebCore::):
+ (WebCore::JSEventTargetNode::getOwnPropertySlot):
+ (WebCore::JSEventTargetNode::put):
+ * bindings/js/JSEventTargetNode.h:
+ (WebCore::JSEventTargetNode::classInfo):
+ (WebCore::JSEventTargetNode::prototypeClassName):
+ * bindings/js/JSEventTargetSVGElementInstance.cpp:
+ (WebCore::):
+ (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
+ (WebCore::JSEventTargetSVGElementInstance::put):
+ * bindings/js/JSEventTargetSVGElementInstance.h:
+ (WebCore::JSEventTargetSVGElementInstance::classInfo):
+ (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
+ * bindings/js/JSHTMLInputElementCustom.cpp:
+ (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::nonCachingStaticBackFunctionGetter):
+ (WebCore::nonCachingStaticForwardFunctionGetter):
+ (WebCore::nonCachingStaticGoFunctionGetter):
+ (WebCore::JSHistory::customGetOwnPropertySlot):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::nonCachingStaticReplaceFunctionGetter):
+ (WebCore::nonCachingStaticReloadFunctionGetter):
+ (WebCore::nonCachingStaticAssignFunctionGetter):
+ (WebCore::JSLocation::customGetOwnPropertySlot):
+ (WebCore::JSLocation::customPut):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2008-09-26 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21149
+
+ Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
+ Eliminate the unused isScrollable() method.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::resetScrollbars):
+ (WebCore::FrameView::initScrollbars):
+ (WebCore::FrameView::layout):
+ * page/FrameView.h:
+ * page/mac/WebCoreFrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::init):
+ (WebCore::ScrollView::setScrollbarModes):
+ (WebCore::ScrollView::scrollbarModes):
+ (WebCore::ScrollView::platformSetScrollbarModes):
+ (WebCore::ScrollView::platformScrollbarModes):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ (WebCore::ScrollView::setHorizontalScrollbarMode):
+ (WebCore::ScrollView::setVerticalScrollbarMode):
+ (WebCore::ScrollView::horizontalScrollbarMode):
+ (WebCore::ScrollView::verticalScrollbarMode):
+ (WebCore::ScrollView::convertSelfToChild):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ (WebCore::ScrollView::paint):
+ (WebCore::ScrollView::scroll):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformSetScrollbarModes):
+ (WebCore::ScrollView::platformScrollbarModes):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ (WebCore::ScrollView::invalidateScrollbars):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::paint):
+ (WebCore::ScrollView::scroll):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
+ (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
+ (WebCore::ScrollView::suppressScrollbars):
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::paint):
+ (WebCore::ScrollView::scroll):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetScrollbarModes):
+ (WebCore::ScrollView::platformScrollbarModes):
+
+2008-09-26 David Kilzer <ddkilzer@apple.com>
+
+ Fix Mac build with XPATH and XSLT disabled
+
+ Reviewed by Alexey.
+
+ * bindings/objc/DOMUtility.mm:
+ (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
+ * dom/XMLTokenizerLibxml2.cpp:
+ (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to
+ prevent an unused code warning.
+
+2008-09-26 Kevin McCullough <kmccullough@apple.com>
+
+ Rubber stamped by Tim Hatcher.
+
+ Bug 21098: Crashing under Console::log
+ - Speculative ASSERT to help find the problem.
+
+ * page/InspectorController.cpp:
+ (WebCore::ConsoleMessage::isEqual):
+
+2008-09-26 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ [gtk+] Build fix for the latest ScrollView changes
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+
+2008-09-26 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where the console message repeat count would be wrong
+ when typing commands in between repeated messages.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21145
+
+ Reviewed by Kevin McCullough.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel.
+ (WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype.addMessage): Remember the original repeat count
+ for each message as totalRepeatCount, since we now modify repeatCount to mean
+ repeats since previous console command. If repeatCountBeforeCommand is a number,
+ subtract that value from the repeatCount.
+ (WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand
+ and commandSincePreviousMessage properties.
+
+2008-09-26 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Antti
+
+ https://bugs.webkit.org/show_bug.cgi?id=21116
+ <rdar://problem/5726325> Audio from <video> can still be heard after navigating
+ back to page with <video>, then closing tab
+
+ Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
+ documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
+ deletion.
+
+ * dom/Document.cpp:
+ (WebCore::Document::documentWillBecomeInactive):
+ (WebCore::Document::documentDidBecomeActive):
+ (WebCore::Document::registerForDocumentActivationCallbacks):
+ (WebCore::Document::unregisterForDocumentActivationCallbacks):
+ * dom/Document.h:
+ * dom/Element.h:
+ (WebCore::Element::documentWillBecomeInactive):
+ (WebCore::Element::documentDidBecomeActive):
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::~HTMLFormElement):
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ (WebCore::HTMLFormElement::documentDidBecomeActive):
+ (WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
+ (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
+ * html/HTMLFormElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::~HTMLInputElement):
+ (WebCore::HTMLInputElement::setInputType):
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::needsActivationCallback):
+ (WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded):
+ (WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded):
+ (WebCore::HTMLInputElement::documentDidBecomeActive):
+ (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
+ (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
+ * html/HTMLInputElement.h:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement):
+ (WebCore::HTMLMediaElement::~HTMLMediaElement):
+ (WebCore::HTMLMediaElement::documentWillBecomeInactive):
+ (WebCore::HTMLMediaElement::documentDidBecomeActive):
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::inActiveDocument):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::opened):
+ * page/Page.cpp:
+ (WebCore::Page::~Page):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::updateControls):
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::updatePlayer):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::SVGSVGElement):
+ (WebCore::SVGSVGElement::~SVGSVGElement):
+ (WebCore::SVGSVGElement::documentWillBecomeInactive):
+ (WebCore::SVGSVGElement::documentDidBecomeActive):
+ * svg/SVGSVGElement.h:
+
+2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon
+
+ Fix the build inside Qt, don't create faulty prl files for now.
+
+ * WebCore.pro:
+
+2008-09-26 Simon Hausmann <hausmann@webkit.org>
+
+ Fix compilation on Qt/Windows
+
+ * Add WebCore/ to the include path so that config.h is found that enables JSC
+ * Link against winmm for the multimedia timer functions
+ * Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/
+ subdirectory
+ * In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port
+ but set m_window directly as setPlatformWidget takes a QWidget*.
+
+ * WebCore.pro:
+ * platform/win/SystemTimeWin.cpp:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::init):
+
+2008-09-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
+ <https://bugs.webkit.org/show_bug.cgi?id=21054>
+
+ This performance regression is actually just a symptom of a correctness
+ bug. The constructor objects for a number of properties that have security
+ checks on access were returning new objects each time. The most obvious
+ symptom of this bug is that window.Image != window.Image, etc.
+
+ The solution to this is to make sure we cache these constructors
+ in the same way as all the other DOM constructors. To achieve this
+ without causing any refcount cycles it is necessary to replace the
+ refcounted document pointer in the Image, MessageChannel, Option,
+ XMLHttpRequest, and Audio constructor objects with a reference to
+ the document's JS wrapper.
+
+ Tests: fast/dom/constructors-cached-navigate.html
+ fast/dom/constructors-cached.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::mark):
+ * bindings/js/JSAudioConstructor.h:
+ (WebCore::JSAudioConstructor::document):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::getDOMConstructor):
+ (WebCore::JSDOMWindowBase::getValueProperty):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSHTMLOptionElementConstructor.cpp:
+ (WebCore::JSHTMLOptionElementConstructor::mark):
+ * bindings/js/JSHTMLOptionElementConstructor.h:
+ (WebCore::JSHTMLOptionElementConstructor::document):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::mark):
+ * bindings/js/JSImageConstructor.h:
+ (WebCore::JSImageConstructor::document):
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::mark):
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ (WebCore::JSXMLHttpRequestConstructor::document):
+
+2008-09-26 Simon Hausmann <hausmann@webkit.org>
+
+ Unreviewed one-liner build fix for the Qt/Windows build.
+
+ The build requires NPAPI support to be enabled, fix the condition in
+ the .pro file for that.
+
+ * WebCore.pro:
+
+2008-09-26 Trenton Schulz <twschulz@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation with the Qt/Cocoa port.
+
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2008-09-26 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Holger.
+
+ Fix compilation with VC9SP1, work around bug in TR1 library by
+ disabling it.
+
+ * WebCore.pro:
+
+2008-09-26 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Holger.
+
+ Fix an lupdate() warning.
+
+ Don't use tr() in a class that is not a QObject, use
+ QCoreApplication::translate() directly.
+
+ * platform/qt/ScrollbarQt.cpp:
+ (WebCore::Scrollbar::handleContextMenuEvent):
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ Remove the scrollTo() method from FrameView, since it is not used by anyone.
+
+ Reviewed by Oliver Hunt
+
+ * page/FrameView.cpp:
+ * page/FrameView.h:
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ Make scrollRectIntoViewRecursively cross-platform.
+
+ Reviewed by Oliver Hunt
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21133
+
+ Rename resizeContents method on ScrollView to setContentsSize (to match contentsSize()). Make it
+ cross-platform.
+
+ Reviewed by Oliver Hunt
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::begin):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::adjustViewSize):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::setContentsSize):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/gtk/ScrollViewGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformSetContentsSize):
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformSetContentsSize):
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21132
+
+ Clean up the methods that actually do the scrolling in ScrollView.
+
+ Reviewed by Oliver Hunt
+
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::setScrollLeft):
+ (WebCore::HTMLBodyElement::setScrollTop):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::restoreScrollPositionAndViewState):
+ * loader/ImageDocument.cpp:
+ (WebCore::ImageDocument::imageClicked):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::scrollBy):
+ (WebCore::DOMWindow::scrollTo):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollTo):
+ (WebCore::FrameView::setScrollPosition):
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::maximumScrollPosition):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::contentsWidth):
+ (WebCore::ScrollView::contentsHeight):
+ (WebCore::ScrollView::scrollBy):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::setScrollPosition):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::setScrollPosition):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::setScrollPosition):
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::setScrollPosition):
+ (WebCore::ScrollView::scrollRectIntoViewRecursively):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::setScrollPosition):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollByRecursively):
+ (WebCore::RenderLayer::scrollRectToVisible):
+
+2008-09-25 Dan Bernstein <mitz@apple.com>
+
+ - attempted Windows build fix
+
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::setContentsPos):
+ (WebCore::ScrollView::paint):
+
+2008-09-25 Timothy Hatcher <timothy@apple.com>
+
+ Revert the padding changes done in r36905 to prevent the
+ scrollbar from overlapping the URLs in the Console.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21126
+
+ * page/inspector/inspector.css:
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21129
+
+ Refactor contents size and scroll offset to be cross-platform. Reduce further the number
+ of platform-specific methods required of ScrollView implementations.
+
+ Reviewed by Tim Hatcher
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::contentsX):
+ (WebCore::contentsY):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::scrollLeft):
+ (WebCore::HTMLBodyElement::setScrollLeft):
+ (WebCore::HTMLBodyElement::scrollTop):
+ (WebCore::HTMLBodyElement::setScrollTop):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::scrollX):
+ (WebCore::DOMWindow::scrollY):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollTo):
+ (WebCore::FrameView::windowClipRect):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::visibleContentRect):
+ (WebCore::ScrollView::contentsSize):
+ (WebCore::ScrollView::platformContentsSize):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::scrollPosition):
+ (WebCore::ScrollView::scrollOffset):
+ (WebCore::ScrollView::scrollX):
+ (WebCore::ScrollView::scrollY):
+ (WebCore::ScrollView::contentsWidth):
+ (WebCore::ScrollView::contentsHeight):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
+ (WebCore::ScrollView::setGtkAdjustments):
+ (WebCore::ScrollView::resizeContents):
+ (WebCore::ScrollView::contentsWidth):
+ (WebCore::ScrollView::contentsHeight):
+ (WebCore::ScrollView::scrollOffset):
+ (WebCore::ScrollView::maximumScroll):
+ (WebCore::ScrollView::scrollBy):
+ (WebCore::ScrollView::suppressScrollbars):
+ (WebCore::ScrollView::setHScrollbarMode):
+ (WebCore::ScrollView::setVScrollbarMode):
+ (WebCore::ScrollView::setScrollbarsMode):
+ (WebCore::ScrollView::setFrameGeometry):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::platformContentsSize):
+ (WebCore::ScrollView::scrollBy):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertFromContainingWindow):
+ (WebCore::Widget::convertToContainingWindow):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::resizeContents):
+ (WebCore::ScrollView::setFrameGeometry):
+ (WebCore::ScrollView::scrollOffset):
+ (WebCore::ScrollView::maximumScroll):
+ (WebCore::ScrollView::scrollBy):
+ (WebCore::ScrollView::setHScrollbarMode):
+ (WebCore::ScrollView::setVScrollbarMode):
+ (WebCore::ScrollView::setScrollbarsMode):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
+ (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
+ (WebCore::ScrollView::resizeContents):
+ (WebCore::ScrollView::setFrameGeometry):
+ (WebCore::ScrollView::scrollOffset):
+ (WebCore::ScrollView::maximumScroll):
+ (WebCore::ScrollView::scrollBy):
+ (WebCore::ScrollView::setHScrollbarMode):
+ (WebCore::ScrollView::setVScrollbarMode):
+ (WebCore::ScrollView::setScrollbarsMode):
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformVisibleContentRect):
+ (WebCore::ScrollView::platformContentsSize):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::nodeAtPoint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollRectToVisible):
+ (WebCore::RenderLayer::calculateClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::absolutePosition):
+ (WebCore::RenderView::computeAbsoluteRepaintRect):
+
+2008-09-25 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.
+
+ * dom/Element.cpp:
+ (WebCore::Element::rareData):
+ * dom/Element.h:
+ * dom/Node.cpp:
+ (WebCore::Node::rareData):
+ * dom/Node.h:
+
+2008-09-25 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20980
+ Split off uncommonly used data from Node similar to ElementRareData
+
+ Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
+ which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
+ for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.
+
+ * WebCore.base.exp:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
+ * dom/ContainerNode.cpp: Set isContainer to true
+ (WebCore::ContainerNode::ContainerNode):
+ * dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h
+ (WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container
+ (WebCore::Node::containerChildNode): ditto
+ (WebCore::Node::containerFirstChild): ditto
+ (WebCore::Node::containerLastChild): ditto
+ * dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h
+ (WebCore::Element::Element):
+ (WebCore::Element::~Element):
+ (WebCore::Element::rareData):
+ (WebCore::Element::ensureRareData): Renamed from createRareData
+ (WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type
+ (WebCore::Element::attach): Check hasRareData rather than null-checking rareData()
+ (WebCore::Element::detach): ditto
+ (WebCore::Element::recalcStyle): ditto
+ (WebCore::Element::focus):
+ (WebCore::Element::minimumSizeForResizing): ditto
+ (WebCore::Element::setMinimumSizeForResizing): ditto
+ (WebCore::Element::computedStyle):
+ (WebCore::Element::cancelFocusAppearanceUpdate): ditto
+ * dom/Element.h:
+ * dom/ElementRareData.h: Added; everything copied from Element.cpp
+ (WebCore::defaultMinimumSizeForResizing):
+ (WebCore::ElementRareData::ElementRareData):
+ (WebCore::ElementRareData::resetComputedStyle):
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
+ * dom/EventTargetNode.h:
+ * dom/Node.cpp:
+ (WebCore::Node::Node):
+ (WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData
+ (WebCore::Node::rareData):
+ (WebCore::Node::ensureRareData):
+ (WebCore::Node::createRareData):
+ (WebCore::Node::tabIndex): nonzero tab indexes are now in rareData
+ (WebCore::Node::setTabIndexExplicitly):
+ (WebCore::Node::childNodes): NodeLists are now in rareData
+ (WebCore::Node::setFocus):
+ (WebCore::Node::rareDataFocused):
+ (WebCore::Node::isFocusable):
+ (WebCore::Node::isKeyboardFocusable):
+ (WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData
+ (WebCore::Node::unregisterDynamicNodeList): ditto
+ (WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto
+ (WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto
+ (WebCore::Node::getElementsByName): ditto
+ (WebCore::Node::getElementsByClassName): ditto
+ * dom/Node.h:
+ (WebCore::Node::firstChild): Use isContainerNode() to devirtualize
+ (WebCore::Node::lastChild): ditto
+ (WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container
+ (WebCore::Node::focused): focus is in rareData if set
+ (WebCore::Node::childTypeAllowed):
+ (WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize
+ (WebCore::Node::childNode): ditto
+ (WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
+ * dom/NodeRareData.h: Added. Most of this is just properties moved from Node
+ (WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :(
+ (WebCore::NodeRareData::NodeRareData):
+ (WebCore::NodeRareData::rareDataMap):
+ (WebCore::NodeRareData::rareDataFromMap):
+ (WebCore::NodeRareData::clearNodeLists):
+ (WebCore::NodeRareData::setNodeLists):
+ (WebCore::NodeRareData::nodeLists):
+ (WebCore::NodeRareData::tabIndex):
+ (WebCore::NodeRareData::setTabIndex):
+ (WebCore::NodeRareData::tabIndexSetExplicitly):
+ * dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
+ * xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
+
+2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [qt] ImageBuffer::toDataURL implementation
+
+ There needs to be a Qt specific test result for the above mentioned
+ implementation.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::toDataURL):
+
+2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [qt] Implement SharedBuffer for Qt.
+
+ * WebCore.pro:
+ * platform/qt/SharedBufferQt.cpp: Added.
+ (WebCore::SharedBuffer::createWithContentsOfFile):
+ * platform/qt/TemporaryLinkStubs.cpp:
+
+2008-09-25 Feng Qian <feng@chromium.org>
+
+ Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
+ <rdar://problem/6243032>
+
+ Reviewed by Dave Hyatt.
+
+ Test: fast/dom/attribute-downcast-right.html
+
+ Add isMappedAttribute function to Attribute for checking if an object
+ is an instance of MappedAttribute. Removed attributeItem,
+ getAttributeItem functions from NamedMappedAttrMap, and callers
+ expecting MappedAttribute have to check isMappedAttribute before
+ downcasting the return value to MappedAttribute.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::styleForElement):
+ * dom/Attribute.h:
+ (WebCore::Attribute::isMappedAttribute):
+ * dom/MappedAttribute.h:
+ (WebCore::MappedAttribute::isMappedAttribute):
+ * dom/NamedMappedAttrMap.cpp:
+ (WebCore::NamedMappedAttrMap::declCount):
+ (WebCore::NamedMappedAttrMap::mapsEquivalent):
+ * dom/NamedMappedAttrMap.h:
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::attributeChanged):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setInputType):
+ * svg/SVGForeignObjectElement.cpp:
+ (WebCore::addCSSPropertyAndNotifyAttributeMap):
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::getPresentationAttribute):
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21120
+
+ Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
+ to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
+ didn't want to mix that change in with this patch).
+
+ Reviewed by Sam Weinig
+
+ * page/Frame.cpp:
+ (WebCore::Frame::markAllMatchesForText):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::windowClipRect):
+ (WebCore::FrameView::updateControlTints):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::visibleContentRect):
+ (WebCore::ScrollView::platformVisibleContentRect):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::visibleWidth):
+ (WebCore::ScrollView::visibleHeight):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ (WebCore::ScrollView::platformVisibleContentRect):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::platformVisibleContentRect):
+ (WebCore::ScrollView::horizontalScrollbar):
+ (WebCore::ScrollView::verticalScrollbar):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollRectToVisible):
+ (WebCore::frameVisibleRect):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::viewRect):
+
+2008-09-25 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Timothy Hatcher
+
+ https://bugs.webkit.org/show_bug.cgi?id=21052
+ Generalize id selector special case for querySelectorAll
+
+ By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
+ Changes results on http://native.khan.mozilla.org
+ from
+ #title: 2ms
+ h1#title: 55ms
+ div #title: 55ms
+
+ to:
+ #title: 1ms
+ h1#title: 2ms
+ div #title: 5ms
+
+ * dom/Node.cpp:
+ (WebCore::Node::querySelector):
+ * dom/SelectorNodeList.cpp:
+ (WebCore::createSelectorNodeList):
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21118
+
+ Make the concept of whether you can blit on scroll cross-platform on ScrollView.
+
+ Reviewed by Sam Weinig
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::clear):
+ (WebCore::FrameView::layout):
+ (WebCore::FrameView::setUseSlowRepaints):
+ (WebCore::FrameView::addSlowRepaintObject):
+ (WebCore::FrameView::removeSlowRepaintObject):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::init):
+ (WebCore::ScrollView::addChild):
+ (WebCore::ScrollView::removeChild):
+ (WebCore::ScrollView::setCanBlitOnScroll):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::canBlitOnScroll):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::ScrollView):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::platformAddChild):
+ (WebCore::ScrollView::platformRemoveChild):
+ (WebCore::ScrollView::platformSetCanBlitOnScroll):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::ScrollView):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::ScrollView):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::scrollBy):
+
+2008-09-25 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Bug 21109: Console should right-align urls
+
+ * page/inspector/Console.js: Re-order the message elements so that when
+ it overflows it doesn't get mixed in with the next message.
+ * page/inspector/inspector.css:
+
+2008-09-25 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21113
+
+ Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.
+
+ Reviewed by Darin Adler
+
+ * css/CSSImportRule.cpp:
+ (WebCore::CSSImportRule::insertedIntoParent):
+ * css/CSSRule.cpp:
+ (WebCore::CSSRule::parentStyleSheet):
+ (WebCore::CSSRule::parentRule):
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::CSSStyleSheet):
+ * css/CSSStyleSheet.h:
+
+2008-09-25 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21115
+ <rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips
+ bundled documents
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::formData): Use files() instead of value()
+ to get the path, since value() now returns just the basename.
+
+2008-09-25 Brady Eidson <beidson@apple.com>
+
+ Rubberstamped by Mark Rowe
+
+ Roll out 36771 as it caused <rdar://problem/6246554>
+ "nytimes.com doesn't display after returning to it with back/forward"
+
+ * css/CSSImportRule.cpp:
+ (WebCore::CSSImportRule::insertedIntoParent):
+ * css/CSSRule.cpp:
+ (WebCore::CSSRule::parentStyleSheet):
+ (WebCore::CSSRule::parentRule):
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::CSSStyleSheet):
+ (WebCore::CSSStyleSheet::docLoader):
+ * css/CSSStyleSheet.h:
+ (WebCore::CSSStyleSheet::doc):
+
+2008-09-25 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.
+
+2008-09-25 Dan Bernstein <mitz@apple.com>
+
+ - Windows build fix
+
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::addChildPlatformWidget):
+ (WebCore::ScrollView::removeChildPlatformWidget):
+
+2008-09-25 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a leak of ConsoleMessage seen when repeated console
+ messages occur.
+
+ Reviewed by Mark Rowe.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::addConsoleMessage): Delete the repeat
+ since we don't add it to m_consoleMessages.
+
+2008-09-25 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Bug 21105: XHRs logged in the console may show the wrong URL for the
+ source
+ - Get the url at the time of the send() and pass it on to the XHR.
+
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::send):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::setLastSendURL):
+
+2008-09-25 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff and Tim.
+
+ Bug 20322: XHRs logged in the console do not have line numbers
+ - Get the line number at the time of the send and pass it on to the XHR.
+
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::send):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::XMLHttpRequest):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ * xml/XMLHttpRequest.h:
+ (WebCore::XMLHttpRequest::setLastSendLineNumber):
+
+2008-09-25 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ <rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
+ https://bugs.webkit.org/show_bug.cgi?id=21003
+
+ * dom/EventNames.h: remove "begin" event
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"
+
+2008-09-25 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21097
+ Calling a MessageChannel constructor from a destroyed document results in a crash
+
+ Test: fast/events/message-port-constructor-for-deleted-document.html
+
+ * bindings/js/JSMessageChannelConstructor.cpp:
+ (WebCore::JSMessageChannelConstructor::construct):
+ * bindings/js/JSMessageChannelConstructor.h:
+ Made m_document a RefPtr.
+
+2008-09-24 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20879
+ Implement HTML5 channel messaging
+
+ Tests: fast/events/message-channel-gc.html
+ fast/events/message-port-deleted-document.html
+ fast/events/message-port-deleted-frame.html
+ fast/events/message-port-inactive-document.html
+ fast/events/message-port.html
+ http/tests/security/MessagePort/event-listener-context.html
+
+ * Configurations/WebCore.xcconfig:
+ Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.
+
+ * DerivedSources.make:
+ Added MessageChannel and MessagePort.
+
+ * WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be
+ turmed off anyway. Added new files.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Added new files.
+
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
+ Added suport for window.MessageChannel constructor.
+
+ * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::postMessage):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+ Added support for three-argument postMessage (that posts a MessagePort).
+
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::toMessagePort):
+ * dom/EventTarget.h:
+ * bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another
+ EventTarget variant.
+
+ * bindings/js/JSMessageChannelConstructor.h:
+ * bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could
+ take a browsing context (document) parameter.
+
+ * bindings/js/JSMessageChannelCustom.cpp: Added.
+ (WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark
+ port1 and port2 that it owns.
+
+ * bindings/js/JSMessagePortCustom.cpp: Added.
+ (WebCore::JSMessagePort::startConversation):
+ (WebCore::JSMessagePort::addEventListener):
+ (WebCore::JSMessagePort::removeEventListener):
+ (WebCore::JSMessagePort::dispatchEvent):
+ (WebCore::JSMessagePort::setOnmessage):
+ (WebCore::JSMessagePort::onmessage):
+ (WebCore::JSMessagePort::setOnclose):
+ (WebCore::JSMessagePort::onclose):
+ (WebCore::JSMessagePort::mark):
+ * dom/MessagePort.cpp: Added.
+ * dom/MessagePort.h: Added.
+ * dom/MessagePort.idl: Added.
+ Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works
+ with Documents as contexts, but in the future, it will be used for communication with worker
+ threads.
+
+ * bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not
+ really have Obj-C bindings, as they are far from being final, but a MessagePort stub is
+ needed for MessageEvent.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.
+
+ * dom/Document.cpp:
+ (WebCore::MessagePortTimer::MessagePortTimer):
+ (WebCore::MessagePortTimer::fired):
+ (WebCore::Document::processMessagePortMessagesSoon):
+ (WebCore::Document::~Document):
+ (WebCore::Document::dispatchMessagePortEvents):
+ (WebCore::Document::createdMessagePort):
+ (WebCore::Document::destroyedMessagePort):
+ * dom/Document.h:
+ Document keeps track of all MessagePort objects that were created when it was fully active
+ in its context.
+
+ * dom/EventNames.h: Added closeEvent.
+
+ * dom/MessageChannel.cpp: Added.
+ (WebCore::MessageChannel::MessageChannel):
+ (WebCore::MessageChannel::~MessageChannel):
+ * dom/MessageChannel.h: Added.
+ (WebCore::MessageChannel::create):
+ (WebCore::MessageChannel::port1):
+ (WebCore::MessageChannel::port2):
+ * dom/MessageChannel.idl: Added.
+ Addded JSMessageChannel implementation.
+
+ * dom/MessageEvent.cpp:
+ (WebCore::MessageEvent::MessageEvent):
+ (WebCore::MessageEvent::initMessageEvent):
+ * dom/MessageEvent.h:
+ (WebCore::MessageEvent::create):
+ (WebCore::MessageEvent::messagePort):
+ * dom/MessageEvent.idl:
+ MessageEvent has a MessagePort member now, making it possible to pass ports across
+ documents.
+
+2008-09-25 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Eric Seidel
+
+ fix https://bugs.webkit.org/show_bug.cgi?id=21091
+ Regression: querySelector matches tag names case sensitively
+
+ Tests: fast/dom/SelectorAPI/caseTag.html
+ fast/dom/SelectorAPI/caseTagX.xhtml
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
+ * css/CSSParser.h:
+ * dom/Node.cpp:
+ (WebCore::Node::querySelector):
+ (WebCore::Node::querySelectorAll):
+
+2008-09-24 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21084
+
+ Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
+ functionality. Add platform stubs for connecting/disconnecting the platform widgets.
+
+ Reviewed by Sam Weinig
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::children):
+ * platform/Widget.h:
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::addChildPlatformWidget):
+ (WebCore::ScrollView::removeChildPlatformWidget):
+ (WebCore::ScrollView::geometryChanged):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::addChildPlatformWidget):
+ (WebCore::ScrollView::removeChildPlatformWidget):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::geometryChanged):
+ (WebCore::ScrollView::addChildPlatformWidget):
+ (WebCore::ScrollView::removeChildPlatformWidget):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::geometryChanged):
+ (WebCore::ScrollView::setParentVisible):
+ (WebCore::ScrollView::show):
+ (WebCore::ScrollView::hide):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::addChildPlatformWidget):
+ (WebCore::ScrollView::removeChildPlatformWidget):
+
+2008-09-25 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21024
+ <rdar://problem/6240821> Scrollbar not painted until hovered
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with
+ this method, which sets both the location and the size.
+ (WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget
+ with a call to the new method setWidgetGeometry. Positioning the
+ widget correctly ensures that the scroll bars invalidate correctly when
+ they are created and resized.
+ * rendering/RenderWidget.h:
+
+2008-09-24 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ - create a "style" subfolder under "rendering" and move style files to that folder
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-09-24 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove staticFunctionGetter. There is only one remaining user of
+ staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::getOwnPropertySlot):
+
+2008-09-24 Jeremy Moskovich <jeremy@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Test: editing/spelling/inline_spelling_markers.html
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20092
+ Spelling markers positioned incorrectly in RTL text
+
+ Measure spelling markers with selectionRectForText() to fix RTL.
+
+ This patch also fixes hit-testing for spelling marker tool tips,
+ which used to work only on the first line.
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+
+2008-09-24 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21074
+
+ Make sure the viewless scrollbar knows how to paint properly when transformed.
+
+ Reviewed by Sam Weinig
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
+ (WebCore::ScrollbarThemeMac::paint):
+
+2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Not reviewed. Try to fix win build.
+
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ (WebCore::toJS):
+ * dom/ContainerNodeAlgorithms.h:
+ (WebCore::removeAllChildrenInContainer):
+ (WebCore::appendChildToContainer):
+ (WebCore::Private::addChildNodesToDeletionQueue):
+
+2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver.
+
+ Add ContainerNodeAlgorithms.h, as central place to share algorithms
+ operating on TreeShared-derived classes with a Node-style interface.
+
+ This allows SVGElementInstance & ContainerNode to share code.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::removeAllChildren):
+ (WebCore::ContainerNode::addChild):
+ * dom/ContainerNode.h:
+ * dom/ContainerNodeAlgorithms.h: Added.
+ (WebCore::removeAllChildrenInContainer):
+ (WebCore::appendChildToContainer):
+ (WebCore::Private::NodeRemovalDispatcher::dispatch):
+ (WebCore::Private::addChildNodesToDeletionQueue):
+
+2008-09-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Wrap up dirtying the z-order list of the stacking context
+ RenderLayer into a method.
+ https://bugs.webkit.org/show_bug.cgi?id=21072
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::setHasVisibleContent):
+ (WebCore::RenderLayer::addChild):
+ (WebCore::RenderLayer::removeChild):
+ (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
+ (WebCore::RenderLayer::styleChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::setStyle):
+
+2008-09-24 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ Bug 21070: REGRESSION Repeated messages with arguments are not repeated
+ or displayed multiple times
+ - The Insepctor Controller was comparing JSValue pointers so thought the
+ message was not a repeat, but the JS of the inspector compared the
+ strings and so knew it was the same message and so overwrote the old
+ message.
+
+ * page/InspectorController.cpp:
+ (WebCore::ConsoleMessage::isEqual):
+ (WebCore::InspectorController::addMessageToConsole):
+ (WebCore::InspectorController::addConsoleMessage):
+ (WebCore::InspectorController::startGroup):
+ (WebCore::InspectorController::endGroup):
+ * page/InspectorController.h:
+
+2008-09-24 David Hyatt <hyatt@apple.com>
+
+ Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
+ arrow placement preference and the thumb jump preference).
+
+ Reviewed by Adam Roben
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::~Scrollbar):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::registerScrollbar):
+ (WebCore::ScrollbarTheme::unregisterScrollbar):
+ * platform/mac/ScrollbarThemeMac.h:
+ * platform/mac/ScrollbarThemeMac.mm:
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
+ (+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
+ (+[ScrollbarPrefsObserver registerAsObserver]):
+ (WebCore::ScrollbarThemeMac::registerScrollbar):
+ (WebCore::ScrollbarThemeMac::unregisterScrollbar):
+ (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
+ (WebCore::ScrollbarThemeMac::preferencesChanged):
+
+2008-09-24 Rob Buis <buis@kde.org>
+
+ Reviewed by Darin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20557
+ getScreenCTM() returns wrong values
+
+ Use the absolute position of the svg root when
+ determining the screen ctm.
+
+ Test: svg/custom/getscreenctm-in-mixed-content2.xhtml
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::getScreenCTM):
+
+2008-09-24 David Hyatt <hyatt@apple.com>
+
+ Turn off support for CSS variables.
+
+ * ChangeLog:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::createVariablesRule):
+ (WebCore::CSSParser::addVariable):
+ (WebCore::CSSParser::addVariableDeclarationBlock):
+
+2008-09-24 David Hyatt <hyatt@apple.com>
+
+ Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).
+
+ * css/CSSGrammar.y:
+ * css/CSSParserValues.cpp:
+ (WebCore::CSSParserValue::isVariable):
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cleanup):
+ (WebCore::CSSPrimitiveValue::getStringValue):
+ (WebCore::CSSPrimitiveValue::cssText):
+ (WebCore::CSSPrimitiveValue::parserValue):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::):
+ (WebCore::CSSPrimitiveValue::isVariable):
+
+2008-09-24 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a regression where the "incorrect MIME-type" warning would not
+ show up correctly in the Console or the resources sidebar.
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/Resource.js:
+ (WebInspector.Resource.prototype._addTip): Add the repeat count argument
+ to the WebInspector.ConsoleMessage constructor call.
+ (WebInspector.Resource.prototype._checkWarning): Ditto.
+
+2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Remove deprecated JS Qt bindings object call/construct code and fix autotests
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::QtInstance):
+ * bridge/qt/qt_instance.h:
+
+2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>
+
+ Reviewed by Alp Toker. Landed by Jan Alonzo.
+
+ Bug 20883: [CURL] Add deferred loading
+ https://bugs.webkit.org/show_bug.cgi?id=20883
+
+ Implement deferred loading for the libcURL backend using curl_easy_pause.
+ As the method was introduced in version 7.18.0, all the code checks for libcURL
+ version.
+
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::ResourceHandle::setDefersLoading):
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::writeCallback): Add an assertion that deferred loading is not
+ activated.
+ (WebCore::headerCallback): Ditto.
+ (WebCore::readCallback): Ditto.
+ (WebCore::ResourceHandleManager::dispatchSynchronousJob): Force
+ defersLoading to be false in order to avoid triggering an assertion.
+ (WebCore::ResourceHandleManager::initializeHandle): If deferred loading is
+ activated, pause the easy handle.
+
+2008-09-23 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Inspector search field style tweaks.
+
+ * page/inspector/inspector.css:
+
+2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=21046 (Several LayoutTests crash)
+
+ Fix missing negation in EventTargetNode::insertedIntoDocument.
+ Made handleLocalEvents() virtual again, HTMLFormElement overrides it.
+ Remove code, that wasn't supposed to go in in dispatchGenericEvent().
+
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::insertedIntoDocument):
+ (WebCore::EventTargetNode::dispatchGenericEvent):
+ * dom/EventTargetNode.h:
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Adds search support to the Profiles panel.
+
+ The Profiles panel supports a few types of queries:
+ * Standard string matching for function names and file URLs.
+ * Greater than and less than search for numeric columns.
+ So a query of ">24" will match all rows that have calls
+ greater than 24. Or "<=42" will match all 42 or less.
+ * Percent and time units. Adding a unit of "s", "ms" or "%"
+ is supported and will match only the Self and Total columns.
+ So a query of ">1.25s" will match all rows that took longer
+ than 1.25 seconds.
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ProfileView.js:
+ (WebInspector.ProfileView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
+ it will start at the first result.
+ (WebInspector.ProfileView.prototype.refreshShowAsPercents): Moved from the bottom of the file.
+ (WebInspector.ProfileView.prototype.searchCanceled): Clear the search properties and refresh highlighted
+ data grid nodes.
+ (WebInspector.ProfileView.prototype.performSearch): Search the profile nodes.
+ (WebInspector.ProfileView.prototype.jumpToFirstSearchResult): Does what the function says. Calls _jumpToSearchResult.
+ (WebInspector.ProfileView.prototype.jumpToLastSearchResult): Ditto.
+ (WebInspector.ProfileView.prototype.jumpToNextSearchResult): Ditto.
+ (WebInspector.ProfileView.prototype.jumpToPreviousSearchResult): Ditto.
+ (WebInspector.ProfileView.prototype.showingFirstSearchResult): Does what the function says.
+ (WebInspector.ProfileView.prototype.showingLastSearchResult): Ditto.
+ (WebInspector.ProfileView.prototype._jumpToSearchResult): Select and reveal the profile node.
+ Expand all the ancestors first so the profile node will have a DataGridNode.
+ (WebInspector.ProfileView.prototype._changeView): Perform the search again on the new tree.
+ (WebInspector.ProfileDataGridNode.prototype.createCell): Add the highlight class to cells that
+ have search matches.
+ * page/inspector/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
+ (WebInspector.ProfilesPanel.prototype.showProfile): Use profileViewForProfile.
+ (WebInspector.ProfilesPanel.prototype.showView): Call showProfile. Used by Panel to show a view.
+ (WebInspector.ProfilesPanel.prototype.profileViewForProfile): Create the ProfileView if needed.
+ (WebInspector.ProfilesPanel.prototype.closeVisibleView): Renamed visibleProfileView to visibleView.
+ (WebInspector.ProfilesPanel.prototype.get searchableViews): Return all the views.
+ (WebInspector.ProfilesPanel.prototype.searchMatchFound): Update the sidebar search matches.
+ (WebInspector.ProfilesPanel.prototype.searchCanceled): Clear all the sidebar search matches.
+ (WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches): Set the class and bubbleText.
+ * page/inspector/inspector.css: New style rules for the cell highlight color.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Adds search support to the Resources and Scripts panels.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/Images/searchSmallBlue.png: Added.
+ * page/inspector/Images/searchSmallBrightBlue.png: Added.
+ * page/inspector/Images/searchSmallGray.png: Added.
+ * page/inspector/Images/searchSmallWhite.png: Added.
+ * page/inspector/ResourceView.js:
+ (WebInspector.ResourceView.prototype.attach): Attempt to attach to "resource-views"
+ or "script-resource-views" since one might not be created yet.
+ * page/inspector/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.show): Hide any views that are visible that
+ are not this panel's current visible view. This can happen when a ResourceView is
+ visible in the Scripts panel then switched to the this panel.
+ (WebInspector.ResourcesPanel.prototype.get searchableViews): Return all views, with the
+ visibleView first.
+ (WebInspector.ResourcesPanel.prototype.searchResultsSortFunction): Return a sort function
+ that uses the current graph search function. So cycling through results will be in the order
+ things appear in the sidebar.
+ (WebInspector.ResourcesPanel.prototype.searchMatchFound): Update the search matches on the
+ resource's sidebar tree element.
+ (WebInspector.ResourcesPanel.prototype.searchCanceled): Restore the error and warning bubbles
+ in the sidebar. Calls the Panel prototype's searchCanceled.
+ (WebInspector.ResourcesPanel.prototype.performSearch): Hide all the error and warning bubbles
+ in the sidebar. Calls the Panel prototype's performSearch.
+ (WebInspector.ResourcesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
+ (WebInspector.ResourcesPanel.prototype.addMessageToResource): Don't call updateErrorsAndWarnings
+ if there is a current search query.
+ (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
+ (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Ditto.
+ (WebInspector.ResourcesPanel.prototype.showView): Call showResource. Used by Panel to show a view.
+ (WebInspector.ResourceSidebarTreeElement.prototype.resetBubble): Clear all the classes and content.
+ (WebInspector.ResourceSidebarTreeElement.prototype.set searchMatches): Set the bubbleText and class.
+ (WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings): Call resetBubble.
+ * page/inspector/ScriptView.js:
+ (WebInspector.ScriptView): Set _sourceFrameSetup to flase.
+ (WebInspector.ScriptView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
+ it will start at the first result.
+ (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Add an event listener for "syntax
+ highlighting complete".
+ (WebInspector.ScriptView.prototype): Share many methods with SourceView.
+ * page/inspector/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.show): Hide any views that are visible that are not this
+ This can happen when a ResourceView is visible in the Resources panel then switched to the this panel.
+ (WebInspector.ScriptsPanel.prototype.get searchableViews): Return all views, with the visibleView first.
+ (WebInspector.ScriptsPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
+ (WebInspector.ScriptsPanel.prototype.showView): Call _showScriptOrResource. Used by Panel to show a view.
+ (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource): Added helper.
+ * page/inspector/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Dispatch a "syntax highlighting complete" event.
+ * page/inspector/SourceView.js:
+ (WebInspector.SourceView.prototype.hide):
+ (WebInspector.SourceView.prototype.detach):
+ (WebInspector.SourceView.prototype._resourceLoadingFinished): Moved from the bottom of the file.
+ (WebInspector.SourceView.prototype._addBreakpoint): Ditto.
+ (WebInspector.SourceView.prototype.searchCanceled): Delete search properties.
+ (WebInspector.SourceView.prototype.performSearch): Search the frame if it is loaded, otherwise
+ store the worker function as _delayedFindSearchMatches and call it later in _sourceFrameSetupFinished.
+ (WebInspector.SourceView.prototype.jumpToFirstSearchResult):
+ (WebInspector.SourceView.prototype.jumpToLastSearchResult):
+ (WebInspector.SourceView.prototype.jumpToNextSearchResult):
+ (WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
+ (WebInspector.SourceView.prototype.showingFirstSearchResult):
+ (WebInspector.SourceView.prototype.showingLastSearchResult):
+ (WebInspector.SourceView.prototype._jumpToSearchResult): Selects the found Range.
+ (WebInspector.SourceView.prototype._sourceFrameSetupFinished): Calls _delayedFindSearchMatches.
+ (WebInspector.SourceView.prototype._syntaxHighlightingComplete): Call _sourceFrameSetupFinished.
+ * page/inspector/inspector.css:
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Rename some properties of ResourcesPanel and ScriptsPanel to be the same,
+ so future code can be shared.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ResourcesPanel.js: Renamed resourceViews to viewsContainerElement.
+ And visibleResourceView to visibleView.
+ * page/inspector/ScriptsPanel.js: Renamed scriptResourceViews to viewsContainerElement.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Highlight all matched search results in the Elements panel DOM tree.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.searchCanceled): Clear the highlight
+ on all previous search results.
+ (WebInspector.ElementsPanel.prototype.performSearch): Set the hihglight
+ on all new search results.
+ * page/inspector/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeElement): Delay setting the title until onattach.
+ (WebInspector.ElementsTreeElement.prototype.get/set highlighted): Sets or removes
+ the highlighted class on the listItemElement.
+ (WebInspector.ElementsTreeElement.prototype.onattach): Set the highlighted class
+ if needed. Calls _updateTitle.
+ (WebInspector.ElementsTreeElement.prototype._updateTitle): Adds a span with the highlight
+ class so it can be styled when the highlighted class is present.
+ * page/inspector/inspector.css: New style rules for the hihglight.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Add search support to the Elements panel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.searchCanceled): Call updateSearchMatchesCount
+ with a 0 match count to rest. Reset the other search properties.
+ (WebInspector.ElementsPanel.prototype.performSearch): Evaluates the search as an XPath
+ query and a CSS selector on all the Documents in the page. Remembers the found nodes
+ and avoids duplicates. Focuses the first result.
+ (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): Focuses the next result.
+ (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): Focuses the previous result.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Add support to Panel that allows easy searching of sub-views.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/Panel.js:
+ (WebInspector.Panel.prototype.searchCanceled): Call searchCanceled on all the
+ views in the search results and delete the currentQuery property. Call
+ WebInspector.updateSearchMatchesCount wit ha 0 match count to rest. Reset the
+ other search properties.
+ (WebInspector.Panel.prototype.performSearch): Call searchCanceled since it will
+ reset everything we need before doing a new search. Get an array of searchableViews
+ from the panel, implemented by sub-classes. Iterate over the views one-by-one
+ with an interval to prevent blocking the UI for large lists of searchableViews.
+ This keeps the interface really responsive. Pass a finishedCallback function to
+ the performSearch on each view so it can notify the panel of results.
+ (WebInspector.Panel.prototype.jumpToNextSearchResult): Finds the index in the
+ searchResults of the visibleView, so we know where in the results we are.
+ This is done every time incase the user manually navigates to a new view.
+ If the view is showing the last result, jump to the next view and show it's
+ first result. Otherwise jump to the next result in the current view.
+ (WebInspector.Panel.prototype.jumpToPreviousSearchResult): Ditto, but in reverse.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Add support for asking the current panel to perform a search, find next/previous and clear.
+ A search is performed on the new new current panel when switching between panels. The search
+ label/placeholder in the toolbar now includes the panel name to make it clear that panel will
+ be searched. The search field contents are selected when Command/Control-F or Enter/Return
+ is pressed, so the user can easily type an entirely new query. The search match count shows
+ up in the toolbar next to the search field.
+
+ Also changed:
+ * Rename lastQuery to currentQuery since it better matches the truth.
+ * Set the search field "results" attribute to zero since results arn't saved for
+ how we use the search field.
+ * Make repeated presses of the Return key jump to the next search result instead
+ of doing nothing.
+ * Increased the search field width.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * English.lproj/localizedStrings.js: New strings.
+ * page/inspector/inspector.css: New styles.
+ * page/inspector/inspector.html: Add the search-results-matches element. Add the
+ incremental attribute to the search field and set the results attribute to zero.
+ * page/inspector/inspector.js:
+ (WebInspector.set currentPanel): perform the search on the new panel.
+ (WebInspector.loaded): Change the event listeners and remove code that changes
+ the search label text.
+ (WebInspector.documentKeyDown): Add support for Command/Control-G and
+ Command/Control-Shift-G. To jump to the next and previous search results.
+ (WebInspector.updateSearchLabel): Added. Update the search placeholder/label.
+ This does different things depending on the attached state.
+ (WebInspector.searchKeyDown): Call preventDefault since this was the Enter key.
+ This prevents a "search" event from firing for key down. We handle the Enter key
+ on key up in searchKeyUp. This stops performSearch from being called twice in a row.
+ (WebInspector.searchKeyUp): Calls performSearch when it is the Enter key.
+ (WebInspector.performSearch): Delete the currentQuery property and call searchCanceled
+ on all the panels. Call jumpToNextSearchResult when this is the same query or a forced search.
+ Call updateSearchMatchesCount to reset the matches count in the toolbar.
+ (WebInspector.updateSearchMatchesCount): Added. Updates the matches count in the toolbar.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Remove the previous Inspector search code to make room for the new stuff.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21005
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/inspector.css:
+ * page/inspector/inspector.html:
+ * page/inspector/inspector.js:
+ (WebInspector.get/set showingSearchResults): Removed.
+ (WebInspector.searchResultsKeyDown): Removed.
+ (WebInspector.searchResultsResizerDragStart): Removed.
+ (WebInspector.searchResultsResizerDragEnd): Removed.
+ (WebInspector.searchResultsResizerDrag): Removed.
+ (WebInspector.performSearch): Removed searching parts.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Use the Array.remove helper function in more places.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21037
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ResourceCategory.js:
+ (WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
+ * page/inspector/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
+ * page/inspector/inspector.js:
+ (WebInspector.removeResource): Ditto.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where inspecting a node after reloading the page
+ would not reveal the node in the DOM tree. The TreeOutline
+ was not being told to forget decendants of a removed child.
+ So old TreeElements would be found that are not in the tree.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21036
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/treeoutline.js:
+ (TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive
+ in addition to _forgetTreeElement.
+ (TreeOutline._removeChildren): Call _forgetChildrenRecursive
+ in addition to _forgetTreeElement.
+ (TreeOutline._rememberTreeElement): Use Array.indexOf to quickly
+ search for known elements.
+ (TreeOutline._forgetTreeElement): Use Array.remove to remove elements.
+ (TreeOutline._forgetChildrenRecursive): Recursively traverse the
+ descendants and call _forgetTreeElement.
+ * page/inspector/utilities.js:
+ (Array.prototype.remove): Speed up this function by using Array.indexOf
+ when onlyFirst is true.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where inspecting some short text nodes does
+ not reveal them in the Elements panel DOM tree.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21035
+
+ Reviewed by Oliver Hunt.
+
+ * page/inspector/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
+ The revealAndSelectNode() method might find a different element
+ if there is inlined text, and the select() call would change the
+ focusedDOMNode and reenter this setter. So to avoid calling
+ focusedNodeChanged() twice, first check if _focusedDOMNode is
+ the same node as the one passed in.
+ (WebInspector.ElementsTreeOutline.prototype.update): Remove use of
+ this.treeOutline, since this is the TreeOutline.
+ (WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added.
+ Provides default functions for isAncestor, getParet and equal.
+ Calls the base protoype's findTreeElement. If that returns null
+ and the node is a text node, try finding it's parent.
+ (WebInspector.ElementsTreeOutline.prototype.revealNode): Removed.
+ Renamed to revealAndSelectNode.
+ (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
+ Selects and reveals the node passed in. Use the simple findTreeElement.
+ (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
+ Remove use of this.treeOutline, since this is the TreeOutline.
+
+2008-09-23 Timothy Hatcher <timothy@apple.com>
+
+ Fixes an exception that happened when removing a Resource
+ from the ResourcesPanel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21034
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ResourcesPanel.js:
+ (WebInspctor.ResourcesPanel.prototype.removeResource):
+ Remove the graphElement.
+
+2008-09-23 Kevin McCullough <kmccullough@apple.com>
+
+ Fixed "Time" to "Tim"
+
+ * ChangeLog:
+
+2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver.
+
+ Move mapInstanceToElement/removeInstanceMapping/instancesForElement
+ from SVGDocumentExtensions to SVGElement. It's more useful to store
+ the list of SVGElementInstances per SVGElement, instead of using
+ a document-wide hash for this purpose.
+
+ * svg/SVGAnimateMotionElement.cpp:
+ (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
+ * svg/SVGAnimateTransformElement.cpp:
+ (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
+ * svg/SVGAnimationElement.cpp:
+ (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
+ * svg/SVGDocumentExtensions.cpp:
+ (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
+ * svg/SVGDocumentExtensions.h:
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::mapInstanceToElement):
+ (WebCore::SVGElement::removeInstanceMapping):
+ (WebCore::SVGElement::instancesForElement):
+ * svg/SVGElement.h:
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::SVGElementInstance):
+ (WebCore::SVGElementInstance::~SVGElementInstance):
+ (WebCore::SVGElementInstance::updateAllInstancesOfElement):
+ * svg/SVGElementInstance.h:
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::svgAttributeChanged):
+ (WebCore::SVGStyledElement::childrenChanged):
+ * svg/SVGStyledElement.h:
+
+2008-09-23 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * WebCoreSources.bkl:
+
+2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Rubber stamped by Sam.
+
+ Move code from EventTarget to EventTargetNode.
+
+ I refactored most parts to live in EventTarget, a year ago,
+ though the implementation of EventTargetSVGElementInstance is
+ done in another way, that obsoletes this.
+
+ * dom/Document.cpp:
+ (WebCore::Document::addListenerTypeIfNeeded):
+ * dom/Document.h:
+ * dom/EventTarget.cpp:
+ * dom/EventTarget.h:
+ (WebCore::allowEventDispatch):
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::insertedIntoDocument):
+ (WebCore::EventTargetNode::removedFromDocument):
+ (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
+ (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
+ (WebCore::EventTargetNode::addEventListener):
+ (WebCore::EventTargetNode::removeEventListener):
+ (WebCore::EventTargetNode::removeAllEventListeners):
+ (WebCore::EventTargetNode::handleLocalEvents):
+ (WebCore::setCurrentEventTargetRespectingSVGTargetRules):
+ (WebCore::EventTargetNode::dispatchEvent):
+ (WebCore::EventTargetNode::dispatchGenericEvent):
+ (WebCore::EventTargetNode::dispatchWindowEvent):
+ (WebCore::EventTargetNode::removeEventListenerForType):
+ * dom/EventTargetNode.h:
+ * svg/EventTargetSVGElementInstance.cpp:
+ (WebCore::EventTargetSVGElementInstance::dispatchEvent):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::sendSVGLoadEventIfPossible):
+ * svg/SVGElement.h:
+ (WebCore::SVGElement::supplementalTransform):
+
+2008-09-23 Dave Hyatt <hyatt@apple.com>
+
+ Fix for bug 21012. The Aqua scrollbar was returning the wrong track rect on Windows Aqua theme. Make
+ sure to not accidentally fall into the vertical scrollbar case for horizontal scrollbars. :)
+
+ Reviewed by Sam Weinig
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::trackRect):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeSafari::trackRect):
+
+2008-09-23 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
+ link at gmail does not support AXPress action
+ and corresponding: <rdar://problem/6216178>
+
+ I fixed this bug by making AccessibilityObject::anchorElement
+ support ARIA links.
+
+ * page/AccessibilityImageMapLink.cpp:
+ (WebCore::AccessibilityImageMapLink::anchorElement):
+ * page/AccessibilityImageMapLink.h:
+ * page/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::anchorElement):
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::isNativeAnchor):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isNativeAnchor):
+ (WebCore::AccessibilityRenderObject::anchorElement):
+ (WebCore::AccessibilityRenderObject::internalLinkElement):
+ (WebCore::AccessibilityRenderObject::url):
+ * page/AccessibilityRenderObject.h:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (AXLinkElementForNode):
+
+2008-09-23 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim and Oliver.
+
+ Bug 20949: Catch repeated messages in Inspector Controller to limit
+ memory usage
+ - Store the repeat count in the Console Message object, in the
+ Inspector Controller and JS ConsoleMessage object.
+
+ * page/InspectorController.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::ConsoleMessage::operator==):
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::addConsoleMessage):
+ (WebCore::InspectorController::addScriptConsoleMessage):
+ * page/InspectorController.h:
+ * page/inspector/Console.js:
+ * page/inspector/Resource.js:
+ * page/inspector/ResourcesPanel.js:
+ * page/inspector/SourceFrame.js:
+
+2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric.
+
+ Working on proper EventTarget support for SVGElementInstance.
+
+ Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
+ Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.
+
+ Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
+ implementation. Let it use TreeShared directly.
+
+ It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
+ The transition to EventTargetSVGElementInstance will be done in a few individual patches.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSEventTargetBase.cpp:
+ (WebCore::retrieveEventTargetAndCorrespondingNode):
+ (WebCore::toJS):
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetSVGElementInstance.cpp: Added.
+ (WebCore::):
+ (WebCore::JSEventTargetSVGElementInstance::JSEventTargetSVGElementInstance):
+ (WebCore::JSEventTargetSVGElementInstance::createPrototype):
+ (WebCore::JSEventTargetSVGElementInstance::setListener):
+ (WebCore::JSEventTargetSVGElementInstance::getListener):
+ (WebCore::toEventTargetSVGElementInstance):
+ * bindings/js/JSEventTargetSVGElementInstance.h: Added.
+ (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
+ (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
+ (WebCore::JSEventTargetSVGElementInstance::getValueProperty):
+ (WebCore::JSEventTargetSVGElementInstance::put):
+ (WebCore::JSEventTargetSVGElementInstance::putValueProperty):
+ * bindings/js/JSSVGElementInstanceCustom.cpp: Added.
+ (WebCore::toJS):
+ * bindings/objc/DOM.mm:
+ (+[DOMNode _wrapEventTarget:WebCore::]):
+ (-[DOMSVGElementInstance _initWithSVGElementInstance:WebCore::]):
+ (+[DOMSVGElementInstance _wrapSVGElementInstance:WebCore::]):
+ (+[DOMSVGElementInstance _wrapEventTarget:WebCore::]):
+ (-[DOMSVGElementInstance WebCore::]):
+ (-[DOMSVGElementInstance addEventListener:listener:useCapture:]):
+ (-[DOMSVGElementInstance addEventListener:::]):
+ (-[DOMSVGElementInstance removeEventListener:listener:useCapture:]):
+ (-[DOMSVGElementInstance removeEventListener:::]):
+ (-[DOMSVGElementInstance dispatchEvent:]):
+ * bindings/objc/DOMEvents.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * svg/EventTargetSVGElementInstance.cpp: Added.
+ (WebCore::EventTargetSVGElementInstance::EventTargetSVGElementInstance):
+ (WebCore::EventTargetSVGElementInstance::~EventTargetSVGElementInstance):
+ (WebCore::EventTargetSVGElementInstance::addEventListener):
+ (WebCore::EventTargetSVGElementInstance::removeEventListener):
+ (WebCore::EventTargetSVGElementInstance::dispatchEvent):
+ * svg/EventTargetSVGElementInstance.h: Added.
+ (WebCore::EventTargetSVGElementInstance::isEventTargetSVGElementInstance):
+ (WebCore::EventTargetSVGElementInstance::toNode):
+ (WebCore::EventTargetSVGElementInstance::toSVGElementInstance):
+ (WebCore::EventTargetSVGElementInstance::refEventTarget):
+ (WebCore::EventTargetSVGElementInstance::derefEventTarget):
+ (WebCore::EventTargetSVGElementInstanceCast):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::dispatchEvent):
+ * svg/SVGElementInstance.cpp:
+ (WebCore::SVGElementInstance::SVGElementInstance):
+ (WebCore::SVGElementInstance::~SVGElementInstance):
+ * svg/SVGElementInstance.h:
+ (WebCore::SVGElementInstance::isEventTargetSVGElementInstance):
+ * svg/SVGElementInstance.idl:
+
+2008-09-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=21040
+ Pass NULL instead of the identity matrix to CTFontCreateWithGraphicsFont()
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::getCTFont):
+
+2008-09-23 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21039
+
+ Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollView.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::setFrameGeometry):
+ * platform/Scrollbar.h:
+ * platform/Widget.cpp:
+ (WebCore::Widget::convertFromContainingWindow):
+ * platform/Widget.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::ScrollView):
+ (WebCore::ScrollView::~ScrollView):
+ (WebCore::ScrollView::windowResizerRect):
+ (WebCore::ScrollView::resizerOverlapsContent):
+ (WebCore::ScrollView::adjustOverlappingScrollbarCount):
+ (WebCore::ScrollView::setParent):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertFromContainingWindow):
+
+2008-09-23 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Darin Adler. Landed by Jan Alonzo.
+
+ Added support for getImageData() and putImageData()
+ to Cairo.
+
+ [CAIRO] needs getImageData and putImageData support
+ https://bugs.webkit.org/show_bug.cgi?id=20838
+
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+
+2008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=18987
+ [GTK] Implement SharedBuffer::createWithContentsOfFile and
+ KURL::fileSystemPath
+
+ * GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
+ * platform/gtk/KURLGtk.cpp: Added.
+ (WebCore::KURL::fileSystemPath): Implemented.
+ * platform/gtk/SharedBufferGtk.cpp: Added.
+ (WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
+ * platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
+
+2008-09-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Oliver Hunt, okayed by Darin Adler.
+
+ <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
+
+2008-09-23 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=21023
+ Don't use TEC for encodings supported by ICU
+
+ * platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic,
+ x-mac-greek, and x-mac-turkish.
+
+ * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
+ Register aliases for these encodings that are not registered automatically; updated comments.
+
+2008-09-23 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin.
+
+ - speed up instanceof some more
+ https://bugs.webkit.org/show_bug.cgi?id=20818
+
+ ~2% speedup on EarleyBoyer
+
+ (WebCore updates.)
+
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::createStructureID):
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21008
+ getting pixels by index from CanvasPixelArray is unnecessarily slow
+
+ * GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+
+ * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and
+ indexSetter. These are now both inlined, so in the header.
+ * bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex
+ function is what's used for HasCustomIndexGetter. Also moved the
+ indexSetter function here.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter
+ to use a getByIndex member function rather than an indexGetter static
+ member function in a property slot. This lets us avoid the property
+ slot mechanism's rule where it turns numeric property names into
+ strings in the identifier table, which is good because that's slow.
+ Also added a new property CustomHeader that allows IDL files to
+ introduce headers to be included -- useful when we have functions
+ that we want to inline into the binding.
+
+ * html/CanvasPixelArray.idl: Added CustomHeader attribute.
+
+2008-09-23 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Another blind stab in the dark.
+
+ * svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
+
+2008-09-23 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Third time's the charm, eh? My local build is sadly still not done...
+
+ * platform/graphics/AffineTransform.cpp: remove extra &
+ * platform/graphics/AffineTransform.h: remove extra &
+
+2008-09-22 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ * platform/graphics/AffineTransform.cpp: remove extra ;
+
+2008-09-22 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Speculative fix for the build while I wait for my compile to finish.
+
+ * platform/graphics/AffineTransform.cpp:
+
+2008-09-22 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by eseidel. Landed by eseidel.
+
+ Moved makeMapBetweenRects from SVG/CG to AffineTransform
+ Make SVGResourceClipper::applyClip more cross-platform
+
+ * platform/graphics/AffineTransform.cpp:
+ * platform/graphics/AffineTransform.h:
+ * svg/graphics/cg/CgSupport.cpp:
+ * svg/graphics/cg/CgSupport.h:
+ * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
+ (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
+ * svg/graphics/cg/SVGResourceClipperCg.cpp:
+ (WebCore::SVGResourceClipper::applyClip):
+
+2008-09-22 Alp Toker <alp@nuanti.com>
+
+ Reviewed by David Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16331
+ [Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed
+
+ Obey GTK+ focusing conventions for controls and anchor elements.
+
+ It could be interesting to push these decisions up to Settings or
+ ChromeClient some day but this gets things working.
+
+ Right and middle click events still need some work to match GTK+
+ conventions.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isMouseFocusable):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::isMouseFocusable):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::sendContextMenuEvent):
+
+2008-09-22 Darin Adler <darin@apple.com>
+
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
+
+2008-09-22 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
+ Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
+ and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
+ class!
+
+ - selectionStart, selectionEnd and setSelectionRange now are visible in iteration of
+ non-selectable input types, but return undefined when accessed.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * bindings/js/JSHTMLInputElementBase.cpp: Removed.
+ * bindings/js/JSHTMLInputElementBase.h: Removed.
+ * bindings/js/JSHTMLInputElementCustom.cpp: Added.
+ (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
+ (WebCore::JSHTMLInputElement::selectionStart):
+ (WebCore::JSHTMLInputElement::selectionEnd):
+ * bindings/js/JSHTMLInputElementCustom.h: Added.
+ * html/HTMLInputElement.idl:
+
+2008-09-22 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message
+
+ Not testable in DumpRenderTree or in Safari
+
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the
+ case that the selection start node is a block.
+
+2008-09-22 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21007
+
+ Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.
+
+ Reviewed by Sam Weinig
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+
+2008-09-22 Eric Seidel <eric@webkit.org>
+
+ No review, rollback only.
+
+ Roll out Peter's change (per his request)
+ http://trac.webkit.org/changeset/36069
+ https://bugs.webkit.org/show_bug.cgi?id=19663
+ This change has been the source of numerous regressions
+ (several of which were latent bugs revealed by this change,
+ others were bugs in this change)
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::startAnimation):
+ (WebCore::BitmapImage::advanceAnimation):
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+
+2008-09-22 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/5158514> Switch the complex text code path to Core Text
+
+ Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html
+ platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html
+
+ * config.h: Use Core Text if not building for Leopard or Tiger.
+
+2008-09-22 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=21006
+
+ Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
+ switched on. There are still a few more refinements to make to the rendering and behavior.
+
+ Reviewed by Darin Adler
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::paintTrack):
+ (WebCore::ScrollbarThemeComposite::paintButton):
+ (WebCore::ScrollbarThemeComposite::paintThumb):
+ * platform/mac/ScrollbarThemeMac.h:
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::backButtonRect):
+ (WebCore::ScrollbarThemeMac::forwardButtonRect):
+ (WebCore::scrollbarPartToHIPressedState):
+ (WebCore::ScrollbarThemeMac::paint):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::invalidateRect):
+
+2008-09-22 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig
+
+ transition end event when -webkit-transition-property: all puts wrong
+ propertyName in event
+ https://bugs.webkit.org/show_bug.cgi?id=20903
+
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+
+2008-09-22 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell
+
+ Test: accessibility/table-one-cell.html
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+
+2008-09-22 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly
+
+ Test: accessibility/textarea-selected-text-range.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::setSelectedTextRange):
+
+2008-09-22 David Hyatt <hyatt@apple.com>
+
+ Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
+ properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
+ parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
+ rule.
+
+ Reviewed by Sam Weinig
+
+ Added fast/css/nested-rule-parent-sheet.html
+
+ * css/CSSImportRule.cpp:
+ (WebCore::CSSImportRule::insertedIntoParent):
+ * css/CSSRule.cpp:
+ (WebCore::CSSRule::parentStyleSheet):
+ (WebCore::CSSRule::parentRule):
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::CSSStyleSheet):
+ * css/CSSStyleSheet.h:
+
+2008-09-22 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=21002
+ Make the ATSUI code path respect spacingDisabled()
+
+ Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text
+
+ * platform/graphics/mac/FontMacATSUI.mm:
+ (WebCore::overrideLayoutOperation):
+
+2008-09-22 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
+
+ Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
+
+ 2.2% speedup on EarleyBoyer benchmark.
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::createStructureID):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2008-09-22 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
+
+2008-09-22 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Based on initial work by Darin Adler.
+
+ - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
+ - use this to JIT inline code for eq_null and neq_null
+ https://bugs.webkit.org/show_bug.cgi?id=20823
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCore.vcproj/WebCore.vcproj:
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter):
+ * bindings/js/JSHTMLAllCollection.cpp: Added.
+ (WebCore::):
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::createStructureID):
+ (WebCore::JSHTMLAllCollection::toBoolean):
+
+2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix the QtWebKit build
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtRuntimeObjectImp::construct):
+ * bridge/qt/qt_runtime.cpp:
+
+2008-09-22 Alp Toker <alp@nuanti.com>
+
+ Suggested by David Hyatt.
+
+ Build fix: ScrollView::update() is still used by Document.cpp on !MAC
+ so make it public.
+
+ * platform/ScrollView.h:
+
+2008-09-22 David Hyatt <hyatt@apple.com>
+
+ Fix a regression in Windows scrollbar painting. (Also fix the same
+ bug in my new viewless Mac scrollbar painting code). The track rect
+ was being improperly inflated when painting resulting in the scrollbar
+ being too tall and painting in the border of overflow sections.
+
+ Reviewed by Oliver Hunt
+
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::trackRect):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarThemeSafari::trackRect):
+
+2008-09-22 David Hyatt <hyatt@apple.com>
+
+ Fix a hit testing bug where events are mistakenly passed to subframes
+ if the mouse is over the border or padding area of the frame. Add
+ a boolean flag, isOverWidget(), to hit test results so that EventHandler
+ can check it to tell if the mouse is really over the content box of a
+ RenderWidget and not just in the border/padding area.
+
+ This is not testable, since the old code properly recovered when it detected
+ that the mouse was outside the bounds of the view, but this prevents
+ the extra passdown from even occurring (and is basically a nice cleanup).
+
+ Reviewed by Oliver Hunt
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ (WebCore::subframeForHitTestResult):
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::handleWheelEvent):
+ * page/MouseEventWithHitTestResults.h:
+ (WebCore::MouseEventWithHitTestResults::isOverWidget):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::HitTestResult):
+ (WebCore::HitTestResult::operator=):
+ * rendering/HitTestResult.h:
+ (WebCore::HitTestResult::isOverWidget):
+ (WebCore::HitTestResult::setIsOverWidget):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::nodeAtPoint):
+ * rendering/RenderWidget.h:
+
+2008-09-21 David Hyatt <hyatt@apple.com>
+
+ Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
+ both it and ScrollView's updateContents method be off-limits to everyone in
+ WebCore except for RenderView.
+
+ Make repaintViewRectangle the only possible method for WebCore code to do
+ an invalidation. This ensures that all invalidates triggered by WebCore
+ cross-platform code that cross ownerElement() boundaries are transform-aware.
+
+ Make sure that iframes/frames contained inside objects that have transforms
+ or reflections are not allowed to blit (this was already true for transparency).
+
+ It is not possible to make a test for any of this, since iframe scrolling
+ still doesn't work on Mac (since the invalidates are not being done
+ through WebCore's cross-platform invalidation code but are instead going
+ through NSScrollView's setNeedsDisplay still).
+
+ Reviewed by Oliver Hunt
+
+ * editing/SelectionController.cpp:
+ (WebCore::SelectionController::recomputeCaretRect):
+ (WebCore::SelectionController::invalidateCaretRect):
+ (WebCore::SelectionController::focusedOrActiveStateChanged):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::endDeferredRepaints):
+ * page/FrameView.h:
+ * platform/ScrollView.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintFillLayerExtended):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::enclosingPositionedAncestor):
+ (WebCore::RenderLayer::requiresSlowRepaints):
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::hasTransform):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::paintBoxDecorations):
+ (WebCore::RenderView::repaintViewRectangle):
+ (WebCore::RenderView::setSelection):
+
+2008-09-21 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin.
+
+ - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
+ https://bugs.webkit.org/show_bug.cgi?id=20981
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor):
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::createDOMStructure):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::getDOMStructure):
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell):
+ (WebCore::JSDOMWindowShell::setWindow):
+ * bindings/js/JSEventTargetNode.cpp:
+ (WebCore::JSEventTargetNode::createPrototype):
+ * bindings/js/JSHTMLOptionElementConstructor.cpp:
+ (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor):
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2008-09-21 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - fix problem Maciej noticed where every JSNamedNodesCollection
+ gets its own StructureID
+
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use
+ getDOMStructure to get the structure.
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::createPrototype): Return the
+ object prototype.
+
+2008-09-20 David Hyatt <hyatt@apple.com>
+
+ Make sure transformed scrollbars in overflow sections position
+ properly. This patch mimics the same behavior that works for
+ iframes, namely making sure that the same code that dynamically
+ adjusts iframe widget positions at paint time for fixed positioning
+ and transforms also applies to scrollbars. (This is as simple as passing
+ in the current translation factor at paint time rather than crawling
+ up the layer tree to compute a "false" absolute position.)
+
+ An existing transform test covers this (although only a pixel result
+ reveals the correct rendering).
+
+ Reviewed by Darin Adler
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::positionOverflowControls):
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintLayer):
+ * rendering/RenderLayer.h:
+
+2008-09-21 Steve Falkenburg <sfalken@apple.com>
+
+ Removed unnecessary nested timer check.
+
+ Rubber-stamped by Dan Bernstein.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::TimerWindowWndProc):
+
+2008-09-21 Steve Falkenburg <sfalken@apple.com>
+
+ Improve timer resolution on WinXP.
+ https://bugs.webkit.org/show_bug.cgi?id=20979
+
+ Removed last-chance timer. It should not be necessary.
+ Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
+ Remove Vista checks. We now run the same code on both XP and Vista.
+
+ Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
+ The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).
+
+ Reviewed by Maciej Stachowiak.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::):
+ (WebCore::TimerWindowWndProc):
+ (WebCore::setSharedTimerFireTime):
+ * platform/win/SystemTimeWin.cpp:
+ (WebCore::currentTime):
+
+2008-09-21 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by eseidel. Landed by eseidel.
+
+ All platforms use the DashArray in the GraphicsContext.
+
+ * svg/graphics/SVGPaintServer.h:
+ * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
+ (WebCore::SVGPaintServerGradient::setup):
+ * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+ * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+ * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
+ (WebCore::SVGPaintServerGradient::setup):
+ * svg/graphics/qt/SVGPaintServerQt.cpp:
+ * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+
+2008-09-21 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by eseidel. Landed by eseidel.
+
+ Moved DashArray to GraphicsContext.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/DashArray.h: Added.
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::setLineDash):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::setLineDash):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::setLineDash):
+ * svg/graphics/SVGPaintServer.cpp:
+ (WebCore::applyStrokeStyleToContext):
+ * svg/graphics/SVGPaintServer.h:
+ * svg/graphics/cg/CgSupport.cpp:
+ * svg/graphics/cg/CgSupport.h:
+
+2008-09-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - fix linker warnings
+
+ * WebCore.base.exp:
+
+2008-09-20 Darin Adler <darin@apple.com>
+
+ - another try at fixing Qt
+
+ * bridge/qt/qt_runtime.cpp: "using namespce WebCore"
+
+2008-09-20 Darin Adler <darin@apple.com>
+
+ - blind attempt to fix Qt build
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue): Use regExpStructure instead
+ of regExpPrototype to make a RegExpObject. There should really be
+ some sort of public helper function for this. Same thing for
+ DateInstance and dateStructure. For JSObject, use constructEmptyObject.
+ (JSC::Bindings::):
+ (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure.
+ It is not correct to do this inside the constructor because it could
+ cause a garbage collect while the QtRuntimeMethod object is half-
+ allocated, which could lead to a crash; note that RuntimeMethod,
+ QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
+ * bridge/qt/qt_runtime.h: Add s_info and createPrototype.
+
+2008-09-20 Collin Jackson <collinj@webkit.org>
+
+ Prefetch DNS for hyperlinks that the user mouses over.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20931
+
+ Reviewed by Sam Weinig.
+
+ * page/Chrome.cpp:
+ (WebCore::Chrome::mouseDidMoveOverElement):
+
+2008-09-20 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - finish https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure
+ ID. Note that this makes a new structure every time -- we could
+ optimize this slightly be caching and reusing a single one.
+
+ * bridge/runtime_method.cpp:
+ (JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using
+ getDOMStructure.
+ * bridge/runtime_method.h:
+ (JSC::RuntimeMethod::createPrototype): Added createPrototype so
+ getDOMStructure will work.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to
+ 0; needed in case garbage collection happens while creating the
+ JSDOMWindow.
+
+2008-09-20 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20950
+ <rdar://problem/6234059> Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc
+
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to
+ not include the first character in the extraCharsAvailable count.
+
+2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix memory leak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20505
+
+ * platform/wx/wxcode/mac/carbon/fontprops.cpp:
+ (GetTextExtent):
+
+2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.
+
+ * WebCoreSources.bkl:
+ * platform/ScrollView.h:
+ * platform/wx/PopupMenuWx.cpp:
+ (WebCore::PopupMenu::show):
+ * platform/wx/RenderThemeWx.cpp:
+ (WebCore::RenderThemeWx::paintButton):
+ (WebCore::RenderThemeWx::paintTextField):
+ (WebCore::RenderThemeWx::paintMenuList):
+ (WebCore::RenderThemeWx::paintMenuListButton):
+ * platform/wx/ScrollViewWx.cpp:
+ (WebCore::ScrollView::setPlatformWidget):
+ (WebCore::ScrollView::updateContents):
+ (WebCore::ScrollView::update):
+ (WebCore::ScrollView::visibleWidth):
+ (WebCore::ScrollView::visibleHeight):
+ (WebCore::ScrollView::scrollBy):
+ (WebCore::ScrollView::resizeContents):
+ (WebCore::ScrollView::contentsWidth):
+ (WebCore::ScrollView::contentsHeight):
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ (WebCore::ScrollView::adjustScrollbars):
+ (WebCore::ScrollView::inWindow):
+ (WebCore::ScrollView::removeChild):
+ * platform/wx/WidgetWx.cpp:
+ * plugins/wx/PluginViewWx.cpp:
+ (WebCore::PluginView::setParentVisible):
+ (WebCore::PluginView::updatePluginWidget):
+
+2008-09-20 Timothy Hatcher <timothy@apple.com>
+
+ Fix the new Node Search button image to not be blurry.
+
+ * page/inspector/Images/nodeSearchButtons.png:
+
+2008-09-20 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Cut down some of the inspector javascript -> InspectorController glue code
+ with two new macros. Also rearrange the exposed function list to be grouped
+ by implementation and to all explicitly use the WebCore namespace.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+
+2008-09-20 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Fix regression from my previous patch where the breadcrumbs bar was not displayed.
+
+ * page/inspector/inspector.css:
+
+2008-09-20 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric.
+
+ Refactor HTMLImageLoader/SVGImageLoader code.
+ Move html/HTMLImageLoader.* to loader/ImageLoader.*
+
+ Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
+ SVGImageLoader used to inherit from HTMLImageLoader which is awkward.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/Document.cpp:
+ (WebCore::Document::dispatchImageLoadEventSoon):
+ (WebCore::Document::removeImage):
+ (WebCore::Document::dispatchImageLoadEventsNow):
+ * dom/Document.h:
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::HTMLImageLoader):
+ (WebCore::HTMLImageLoader::~HTMLImageLoader):
+ (WebCore::HTMLImageLoader::sourceURI):
+ (WebCore::HTMLImageLoader::notifyFinished):
+ * html/HTMLImageLoader.h:
+ * loader/DocLoader.h:
+ * loader/ImageLoader.cpp: Copied from html/HTMLImageLoader.cpp.
+ (WebCore::ImageLoader::ImageLoader):
+ (WebCore::ImageLoader::~ImageLoader):
+ (WebCore::ImageLoader::setImage):
+ (WebCore::ImageLoader::setLoadingImage):
+ (WebCore::ImageLoader::updateFromElement):
+ (WebCore::ImageLoader::notifyFinished):
+ * loader/ImageLoader.h: Copied from html/HTMLImageLoader.h.
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::attach):
+ (WebCore::SVGImageElement::insertedIntoDocument):
+ (WebCore::SVGImageElement::imageSourceAttributeName):
+ * svg/SVGImageElement.h:
+ * svg/SVGImageLoader.cpp:
+ (WebCore::SVGImageLoader::SVGImageLoader):
+ (WebCore::SVGImageLoader::dispatchLoadEvent):
+ (WebCore::SVGImageLoader::sourceURI):
+ * svg/SVGImageLoader.h:
+
+2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ [qtwebkit] ScrollBar build fix after r36684.
+ BackButtonPart was split into Start and End Part
+ ForwardButtonPart was split into Start and End Part
+
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::scPart):
+ (WebCore::scrollbarPart):
+ (WebCore::styleOptionSlider):
+
+2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ [qtwebkit] Make qt_instance.cpp compile.
+ Revision of 36675 introduced getDOMStructure to give unique
+ structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
+ the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getRuntimeObject):
+
+2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ [svg] Change SVGLocatable to deal with a plain SVGElement
+ There is no requirement in the code that we have to have a
+ SVGStyledElement. Remove that artificial limitation and compile
+ with SVGElement.
+
+ * svg/SVGLocatable.cpp:
+ * svg/SVGLocatable.h:
+
+2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ [svg] Use OwnPtr for the SVGExtensions to avoid custom lifetime
+ management.
+
+ * dom/Document.cpp:
+ (WebCore::Document::~Document):
+ (WebCore::Document::svgExtensions):
+ (WebCore::Document::accessSVGExtensions):
+ * dom/Document.h:
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Fix for crash in updateTransitions. Make sure to test for a style
+ being null when comparing two RenderStyles.
+
+ Reviewed by Oliver Hunt
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::PropertyWrapperGetter::equals):
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=20954
+
+ Roll out r36628 since it has caused horrible regressions with
+ animated GIF CPU usage.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::cacheFrame):
+ (WebCore::BitmapImage::startAnimation):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::FrameData::FrameData):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::FrameData::clear):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::FrameData::clear):
+
+2008-09-20 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20913
+ Avoid redudant includes
+
+ Document.h is included excessively such that a modification to Document.h (or
+ any of the header it includes itself) triggers a rebuild of many files
+ including the whole of SVG and a lot of the JS bindings.
+
+ Some of these includes can be avoided by only including Document.h where
+ necessary.
+
+ * bindings/js/JSAttrCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/js/JSEventTargetBase.cpp:
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSEventTargetNode.cpp:
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * css/CSSCursorImageValue.cpp:
+ * css/SVGCSSStyleSelector.cpp:
+ * dom/make_names.pl:
+ * svg/SVGAnimateElement.h:
+ * svg/SVGAnimatedProperty.h:
+ (WebCore::::baseValue):
+ (WebCore::::setBaseValue):
+ (WebCore::::startAnimation):
+ (WebCore::::stopAnimation):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::accessDocumentSVGExtensions):
+ * svg/SVGElement.h:
+ * svg/SVGElementInstance.cpp:
+ * svg/SVGFitToViewBox.cpp:
+ * svg/SVGFontElement.cpp:
+ * svg/SVGFontFaceElement.cpp:
+ * svg/SVGLinearGradientElement.cpp:
+ * svg/SVGMPathElement.cpp:
+ * svg/SVGViewSpec.cpp:
+
+2008-09-19 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Antti & Eric.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
+
+ Finish HTMLScriptElement / SVGScriptElement unification.
+ SVG <script> support is complete now, full SVGLoad event
+ respecting the influence of the externalResourcesRequired attribute
+ as well as SVGError event support. All other features shared with HTML.
+
+ Tests: fast/dom/HTMLScriptElement/script-reexecution.html
+ svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
+ svg/dom/SVGScriptElement/script-load-and-error-events.svg
+ svg/dom/SVGScriptElement/script-reexecution.svg
+ svg/dom/SVGScriptElement/script-set-href.svg
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElementData::ScriptElementData):
+ (WebCore::ScriptElementData::requestScript):
+ * dom/ScriptElement.h:
+ (WebCore::ScriptElementData::haveFiredLoadEvent):
+ (WebCore::ScriptElementData::setHaveFiredLoadEvent):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::dispatchLoadEvent):
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::setCreatedByParser):
+ (WebCore::SVGScriptElement::parseMappedAttribute):
+ (WebCore::SVGScriptElement::svgAttributeChanged):
+ (WebCore::SVGScriptElement::insertedIntoDocument):
+ (WebCore::SVGScriptElement::removedFromDocument):
+ (WebCore::SVGScriptElement::childrenChanged):
+ (WebCore::SVGScriptElement::isURLAttribute):
+ (WebCore::SVGScriptElement::finishParsingChildren):
+ (WebCore::SVGScriptElement::type):
+ (WebCore::SVGScriptElement::setType):
+ (WebCore::SVGScriptElement::haveLoadedRequiredResources):
+ (WebCore::SVGScriptElement::dispatchLoadEvent):
+ (WebCore::SVGScriptElement::dispatchErrorEvent):
+ * svg/SVGScriptElement.h:
+
+2008-09-19 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20951
+ Typo in Position::getInlineBoxAndOffset()
+ and add an assertion
+
+ Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
+
+ * dom/Position.cpp:
+ (WebCore::Position::getInlineBoxAndOffset):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::positionForOffset):
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Add support for hit testing of all five possible scrollbar button placements.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::):
+ (WebCore::ScrollbarThemeMac::backButtonRect):
+ (WebCore::ScrollbarThemeMac::forwardButtonRect):
+ (WebCore::ScrollbarThemeMac::trackRect):
+ (WebCore::ScrollbarThemeMac::paintButton):
+
+2008-09-19 Darin Adler <darin@apple.com>
+
+ - try to fix Qt build
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
+ (JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
+ * bridge/runtime_object.h: Ditto.
+
+2008-09-19 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Transition starts running when it shouldn't
+ https://bugs.webkit.org/show_bug.cgi?id=20892
+
+ When there is a transition and an animation on the
+ same element, make sure the animation wins.
+
+ The fix is to save the unanimated style when an animation is started.
+ Then, when starting a transition, check to see if there is a current
+ animation on the same prop. If so, use the unanimated style as the
+ fromStyle rather than the current style.
+
+ Test: animations/transition-and-animation-1.html
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ (WebCore::CompositeAnimation::animate):
+ (WebCore::CompositeAnimation::getAnimationForProperty):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::reset):
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::hasAnimationForProperty):
+ * page/animation/KeyframeAnimation.h:
+ (WebCore::KeyframeAnimation::KeyframeAnimation):
+ (WebCore::KeyframeAnimation::unanimatedStyle):
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Add support for painting/hit testing of four possible scrollbar buttons.
+ The Windows themes simply ignore the two parts that they will never
+ show. The Mac theme also ignores the other two buttons for now.
+
+ The cross-platform base for all three themes, ScrollbarThemeComposite,
+ has all the proper support though.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ (WebCore::ScrollbarThemeComposite::invalidatePart):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/mac/ScrollbarThemeMac.h:
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::backButtonRect):
+ (WebCore::ScrollbarThemeMac::forwardButtonRect):
+ (WebCore::ScrollbarThemeMac::paintButton):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarThemeSafari::backButtonRect):
+ (WebCore::ScrollbarThemeSafari::forwardButtonRect):
+ (WebCore::ScrollbarThemeSafari::paintButton):
+ * platform/win/ScrollbarThemeSafari.h:
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::backButtonRect):
+ (WebCore::ScrollbarThemeWin::forwardButtonRect):
+ (WebCore::ScrollbarThemeWin::paintButton):
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-09-19 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Bug 17772: Inspector should support point-and-click to select a node to inspect
+ https://bugs.webkit.org/show_bug.cgi?id=17772
+ <rdar://problem/5792395>
+
+ * English.lproj/localizedStrings.js:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::mouseDidMoveOverElement):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+ * page/InspectorController.cpp:
+ (WebCore::toggleNodeSearch):
+ (WebCore::searchingForNode):
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::toggleSearchForNodeInPage):
+ (WebCore::InspectorController::mouseDidMoveOverElement):
+ (WebCore::InspectorController::handleMousePressOnNode):
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ * page/InspectorController.h:
+ (WebCore::InspectorController::searchingForNodeInPage):
+ * page/inspector/ElementsPanel.js:
+ * page/inspector/Images/nodeSearchButtons.png: Added.
+ * page/inspector/inspector.css:
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Add new scrollbar parts to be able to represent back and forward buttons
+ at either end of the scrollbar. The current scrollbar still just draws
+ a single button at either end, but the parts now exist.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollTypes.h:
+ (WebCore::):
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::autoscrollTimerFired):
+ (WebCore::Scrollbar::pressedPartScrollDirection):
+ (WebCore::Scrollbar::pressedPartScrollGranularity):
+ (WebCore::Scrollbar::handleMouseMoveEvent):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::buttonsPlacement):
+ (WebCore::ScrollbarTheme::invalidateParts):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ (WebCore::ScrollbarThemeComposite::invalidatePart):
+ * platform/ScrollbarThemeComposite.h:
+
+2008-09-19 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for <rdar://problem/6231308> crash in AutoTableLayout
+
+ The code assumes later on that a TableSection's grid's row vector
+ will never be empty. So make 1 the minimum number of columns.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::ensureRows):
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Add a new ScrollbarButtonsPlacement type for specifying where
+ the button arrows are in a scrollbar.
+
+ Read in the placement settings for Mac. Nothing is done with the
+ setting yet.
+
+ Add a new buttonsPlacement() method to ScrollbarTheme composite
+ so that the arrow settings can be obtained.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollTypes.h:
+ (WebCore::):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::buttonsPlacement):
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::updateArrowPlacement):
+ (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
+
+2008-09-19 Steve Falkenburg <sfalken@apple.com>
+
+ Roll out r36626. It is causing variance in SunSpider numbers on XP.
+
+ Rubber stamped by Mark Rowe.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::isRunningOnVistaOrLater):
+ (WebCore::setSharedTimerFireTime):
+
+2008-09-19 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20942
+ Bug 20942: Repeated messages in resources don't collapse
+ - Now repeated messages in a resource's view are collapsed and a message
+ says how many were repeated.
+
+ * English.lproj/localizedStrings.js:
+ * manual-tests/inspector/multiple-console-messages.html:
+ * page/inspector/Console.js: Send all the messages to the resource's
+ view before possibly returning early if the message is a repeat.
+ * page/inspector/SourceFrame.js: Add the text about the message being
+ repeated, if it is, and increment it when necessary.
+
+2008-09-19 Chris Fleizach <cfleizach@apple.com>
+
+ Removed unnecessary #if
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Read in prefs for the scroll delay repeat values for buttons. Also
+ honor the option-click pref for jumping to the thumb when clicking in
+ the track.
+
+ Reviewed by Sam Weinig
+
+ * platform/mac/ScrollbarThemeMac.h:
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
+ (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
+ (WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
+ (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
+ Set the initial button repeat delay to 0.5 for Mac.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/mac/ScrollbarThemeMac.cpp: Removed.
+ * platform/mac/ScrollbarThemeMac.h:
+ (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
+ * platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
+
+2008-09-19 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ + Fixed all cases where we were using a shared structure for multiple
+ C++ classes in WebCore. This still has to be done in JavaScriptCore.
+
+ + Got rid of cacheGlobalObject.
+
+ + Improved use of PassRefPtr in bindings code.
+
+ + Removed a couple cases where we were potentially allocating prototypes
+ inside a JSObject's construction process -- this can lead to trouble if
+ we do a garbage collection while an object is only partly constructed.
+
+ * bindings/js/JSAudioConstructor.cpp:
+ (WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
+ so we don't implicitly share the structure with other objects that use the object
+ prototype.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
+ don't need cacheGlobalObject any more.
+ (WebCore::cacheDOMConstructor): Ditto.
+
+ * bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
+ Added functions and a function template for getting cached DOM constructors.
+ Removed cacheGlobalObject function template.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
+ we're taking ownership.
+ * bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
+ we're taking ownership. Added constructor map.
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::mark): Mark the constructors in the map.
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
+ we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
+ this is now done in only that one place.
+ (WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
+ the passed-in DOMWindow. Code was moved here and changed to allocate unique
+ structures for both the window prototype and the window.
+ * bindings/js/JSDOMWindowShell.h: Ditto.
+
+ * bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
+ have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
+ private/friend in JSEventTargetBase. Removed comments referring to defunct
+ macros. Changed JSEventTargetBasePrototype to get the prototype with the new
+ rather than its own copy of cacheGlobalObject (I missed this during pass 1).
+ Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
+
+ * bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
+ for caching structures and prototypes.
+ (WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
+ (WebCore::JSEventTargetNode::createPrototype): Added.
+ * bindings/js/JSEventTargetNode.h: Updated for above changes.
+
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::getNamedItems): Pass ExecState instead of prototype.
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ (WebCore::JSHTMLFormElement::nameGetter): Ditto.
+ * bindings/js/JSHTMLInputElementBase.cpp:
+ (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
+ * bindings/js/JSHTMLInputElementBase.h: Ditto.
+ * bindings/js/JSHTMLOptionElementConstructor.cpp:
+ (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
+ Create a unique structure instead of sharing.
+ * bindings/js/JSImageConstructor.cpp:
+ (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
+
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
+ a prototype rather than a structure. Made the use of inheritorID() here
+ explicit.
+ * bindings/js/JSInspectedObjectWrapper.h: Ditto.
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
+ * bindings/js/JSInspectorCallbackWrapper.h: Ditto.
+
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
+ take an ExecState argument instead of a prototype. Create a unique
+ StructureID instead of sharing.
+ * bindings/js/JSNamedNodesCollection.h: Ditto.
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
+ constructor that takes a prototype instead of a structure.
+ * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
+
+ * bindings/js/JSRGBColor.cpp:
+ (WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
+ prototype; create a unique structure.
+ (WebCore::getJSRGBColor): Ditto.
+ * bindings/js/JSRGBColor.h: Ditto.
+
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ (WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
+ of explicit coding the idiom for making a new object.
+
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
+ Create a unique structure instead of the shared one.
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
+ Ditto.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::clearWindowShell): Let the window shell's
+ setWindow function create the JSDOMWindow instead of doing it here.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
+ the structure and the wrapped object when creating wrappers.
+ Simplified some of the special cases for DOMWindow so they are
+ different only in ways the need to be. Eliminated the
+ JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
+ functions. Moved responsibility for creating the structure and
+ parent prototype out of the prototype constructor into the
+ createPrototype function. Removed the unused "DoNotCache" flag for
+ objects other than DOMWindow. Use getDOMConstructor instead of
+ cacheGlobalObject for constructors. Make each constructor have
+ a unique structure ID.
+
+ * bridge/objc/objc_runtime.h: Added createPrototype and changed the
+ name of the info member to s_info so we can use the standard DOM
+ binding macros to handl the prototype.
+ * bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
+ (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
+ Create a unique structure using getDOMStructure.
+
+ * bridge/runtime_array.cpp: Fixed namespacing a bit.
+ (JSC::RuntimeArray::RuntimeArray): Create a unique structure using
+ getDOMStructure.
+ * bridge/runtime_array.h: Added createPrototype so getDOMStructure
+ will work.
+
+ * bridge/runtime_object.cpp:
+ (JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
+ getDOMStructure.
+ * bridge/runtime_object.h: Added createPrototype so getDOMStructure
+ will work.
+
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::restore): Let the window shell's
+ setWindow function create the JSDOMWindow instead of doing it here.
+
+ * page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
+
+2008-09-19 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ This optimization was suggested by Daniel Fenwick
+
+ - speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
+
+ Specifying LTR paragraph directionality when measuring runs of RTL text
+ resulted in typically two CTRuns being generated for every run instead
+ of one, due to the leading space being reordered to the left.
+
+ * platform/graphics/SimpleFontData.h: Removed the ltr parameter to
+ getCFStringAttributes() and changed m_CFStringAttributes from an array
+ to a single value.
+ * platform/graphics/mac/CoreTextController.cpp:
+ (WebCore::CoreTextController::CoreTextController): Added a
+ mayUseNaturalWritingDirection parameter.
+ (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
+ to force the bidi embedding level whenever
+ m_mayUseNaturalWritingDirectrion is false. Since this is now a common
+ case, made the typesetter options dictionaries static.
+ * platform/graphics/mac/CoreTextController.h:
+ * platform/graphics/mac/FontMacCoreText.cpp:
+ (WebCore::Font::selectionRectForComplexText): Renamed a local variable.
+ (WebCore::Font::floatWidthForComplexText): Changed to allow the
+ CoreTextController to not set the writing direction.
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
+ parameter and the paragraph style attribute.
+
+2008-09-19 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig
+
+ https://bugs.webkit.org/show_bug.cgi?id=20941
+
+ Incorrect height calculation for replaced element inside nested
+ positioned elements (where the inner has a percentage height and
+ the outer implicitly has a fixed height because of explicit top/bottom
+ values).
+
+ Added fast/block/positioning/replaced-inside-top-bottom.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::availableHeightUsing):
+
+2008-09-19 Chris Fleizach <cfleizach@apple.com>
+
+ Fix Tiger bustage
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+
+2008-09-18 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6211041> Expose legend tag in accessibility
+
+ Exposes the legend tag as the titleUIElement of a fieldset
+
+ Test: accessibility/legend.html
+
+ * page/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::isFieldset):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isFieldset):
+ (WebCore::AccessibilityRenderObject::titleUIElement):
+ * page/AccessibilityRenderObject.h:
+ * rendering/RenderFieldset.h:
+
+2008-09-19 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
+
+ Implement a few AX API methods that will be called by AppKit, which will
+ speed up access to accessibility objects
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
+ (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
+
+2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [qtwebkit] Set the m_should* flags to their proper value on entry
+ With plugins it was possible that we finished a job twice. This was
+ some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
+ setting the flag to (m_loadMode == LoadDeferred) they will always have
+ the right value and we will not send responses twice.
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+
+2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon Hausmann.
+
+ [qtwebkit] Pass test 70 of acid3. Handle text decoding errors
+ Handle text decoding errors before instructing the parser to parse. We
+ have converted the text to QString and all encoding errors are gone and
+ the parser will not be able to detect them. So handle them before parsing.
+
+ * dom/XMLTokenizerQt.cpp:
+ (WebCore::XMLTokenizer::doWrite):
+
+2008-09-18 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
+ make each distinct C++ class get a distinct JSC::Structure
+
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
+ instead of DOMExceptionTranslator.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::getCachedDOMObjectWrapper): Updated function name.
+ (WebCore::cacheDOMObjectWrapper): Ditto.
+ (WebCore::forgetDOMObject): Ditto.
+ (WebCore::getCachedDOMNodeWrapper): Ditto.
+ (WebCore::forgetDOMNode): Ditto.
+ (WebCore::cacheDOMNodeWrapper): Ditto.
+ (WebCore::forgetAllDOMNodesForDocument): Ditto.
+ (WebCore::markDOMNodesForDocument): Ditto.
+ (WebCore::updateDOMNodeDocument): Ditto.
+ (WebCore::getCachedDOMStructure): Added.
+ (WebCore::createDOMStructure): Ditto.
+
+ * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
+ class and replace the static member functions with non-member
+ functions. Added many other functions for getting at structures,
+ prototypes, wrappers, and creating them. Also moved the
+ cacheGlobalObject function here from JavaScriptCore; eventually
+ I'll remove that once I get rid of the remaining callers. Also
+ removed the DOMExceptionTranslator class.
+
+ * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
+ and put one of those maps in each window.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::markDOMObjectWrapper): Updated for function name change.
+ (WebCore::JSDOMWindow::mark): Added code to mark all the structures
+ in the structure map.
+
+ * bindings/js/JSEventTargetNode.cpp:
+ (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
+ a structure instead of a prototype.
+ * bindings/js/JSEventTargetNode.h: Ditto.
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
+
+ * bindings/js/JSHTMLInputElementBase.cpp:
+ (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
+ use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
+ structure instead of a prototype.
+ * bindings/js/JSHTMLInputElementBase.h: Removed use of the
+ JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
+ to take a structure instead of a prototype. Created a dummy prototype
+ class that causes the HTMLInputElement prototype to have the
+ HTMLElement prototype.
+
+ * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
+ structures instead of prototypes. Changed the prototype self function
+ to use the getDOMPrototype function -- later we can eliminate it and
+ have callers invoke getDOMPrototype directly instead. Updated other
+ functions that have name changes. Added code to generate the
+ createPrototype member function. Changed use of cacheGlobalObject to
+ get it from the WebCore namespace instead of the JSC namespace.
+ Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
+
+ * dom/Document.cpp:
+ (WebCore::Document::~Document): Updated for name change and also
+ removed unnecessary JSLock use -- there's no need to lock around this.
+ * dom/Node.cpp:
+ (WebCore::Node::setDocument): Ditto.
+
+ * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
+ instead of calling new directly.
+
+ * bindings/js/JSCSSRuleCustom.cpp:
+ (WebCore::toJS): Updated for function name changes and used the
+ CREATE_DOM_OBJECT_WRAPPER macro.
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSCanvasPixelArrayCustom.cpp:
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::mark): Ditto.
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSElementCustom.cpp:
+ (WebCore::toJSNewlyCreated): Ditto.
+ * bindings/js/JSEventCustom.cpp:
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSEventTargetBase.cpp:
+ (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
+ of DOMExceptionTranslator.
+ (WebCore::toJS): Updated for function name changes and used the
+ CREATE_DOM_OBJECT_WRAPPER macro.
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::mark): Ditto.
+ (WebCore::createWrapper): Ditto.
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ (WebCore::toJS): Ditto.
+ * bindings/js/JSStyleSheetCustom.cpp:
+ (WebCore::toJS): Ditto.
+ (WebCore::JSStyleSheet::mark): Ditto.
+ * bindings/js/JSTextCustom.cpp:
+ (WebCore::toJSNewlyCreated): Ditto.
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ (WebCore::constructXMLHttpRequest): Ditto.
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::mark): Ditto.
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ (WebCore::constructXSLTProcessor): Ditto.
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::finishedWithEvent): Ditto.
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
+ (WebCore::XMLHttpRequest::dropProtection): Ditto.
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ This patch gets a viewless scrollbar working on Mac. It is turned off
+ by default. Hit testing works. For now the scrollbar just paints ugly
+ debug rects in the place of the buttons, track and thumb. It does match
+ Aqua metrics though.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paint):
+ (WebCore::ScrollbarThemeComposite::trackPosition):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::addChild):
+ * platform/mac/ScrollbarThemeMac.cpp:
+ (WebCore::):
+ (WebCore::ScrollbarThemeMac::hasButtons):
+ (WebCore::ScrollbarThemeMac::hasThumb):
+ (WebCore::buttonRepaintRect):
+ (WebCore::ScrollbarThemeMac::backButtonRect):
+ (WebCore::ScrollbarThemeMac::forwardButtonRect):
+ (WebCore::trackRepaintRect):
+ (WebCore::ScrollbarThemeMac::trackRect):
+ (WebCore::ScrollbarThemeMac::minimumThumbLength):
+ (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
+ (WebCore::ScrollbarThemeMac::paintTrack):
+ (WebCore::ScrollbarThemeMac::paintButton):
+ (WebCore::ScrollbarThemeMac::paintThumb):
+ * platform/mac/ScrollbarThemeMac.h:
+ (WebCore::ScrollbarThemeMac::supportsControlTints):
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::ScrollbarThemeQt::trackPosition):
+
+2008-09-18 Collin Jackson <collinj@webkit.org>
+
+ Build fix; added missing header file to GNUmakefile.am
+
+ * GNUmakefile.am:
+
+2008-09-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David "the Hair" Hyatt.
+
+ Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/DataRef.h: Removed.
+ * rendering/SVGRenderStyle.cpp: Removed.
+ * rendering/SVGRenderStyle.h: Removed.
+ * rendering/SVGRenderStyleDefs.cpp: Removed.
+ * rendering/SVGRenderStyleDefs.h: Removed.
+ * rendering/style/DataRef.h: Copied from rendering/DataRef.h.
+ * rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
+ * rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
+ * rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
+ * rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
+
+2008-09-18 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Add a means of clearing a FrameTree's name.
+
+ * WebCore.base.exp:
+ * page/FrameTree.cpp:
+ (WebCore::FrameTree::clearName):
+ * page/FrameTree.h:
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Eliminate addToSuperview from Widget, since it was only called
+ by ScrollViewMac's addChild method. Just shift the original body
+ of addToSuperView into addChild.
+
+ Reviewed by Sam Weinig
+
+ * platform/Widget.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::addChild):
+ * platform/mac/WidgetMac.mm:
+
+2008-09-18 Collin Jackson <collinj@webkit.org>
+
+ Reviewed by Antti Koivisto and Mark Rowe.
+
+ Test: http/tests/misc/dns-prefetch-control.html
+
+ https://bugs.webkit.org/show_bug.cgi?id=20690
+
+ Invoke WebCore::prefetchDNS() on host names that appear in
+ in the href of hyperlinks and <link rel="dns-prefetch">. This
+ can be used to implement DNS prefetching.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::processHttpEquiv):
+ (WebCore::Document::setSecurityOrigin):
+ (WebCore::Document::initDNSPrefetch):
+ (WebCore::Document::parseDNSPrefetchControlHeader):
+ * dom/Document.h:
+ (WebCore::Document::isDNSPrefetchEnabled):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::parseMappedAttribute):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::HTMLLinkElement):
+ (WebCore::HTMLLinkElement::parseMappedAttribute):
+ (WebCore::HTMLLinkElement::tokenizeRelAttribute):
+ (WebCore::HTMLLinkElement::process):
+ * html/HTMLLinkElement.h:
+ * html/PreloadScanner.cpp:
+ (WebCore::PreloadScanner::processAttribute):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::begin):
+ * platform/gtk/TemporaryLinkStubs.cpp:
+ (WebCore::prefetchDNS):
+ * platform/network/DNS.h: Added.
+ * platform/network/cf/DNSCFNet.cpp: Added.
+ (WebCore::prefetchDNS):
+ * platform/qt/TemporaryLinkStubs.cpp:
+ (WebCore::prefetchDNS):
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (WebCore::prefetchDNS):
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Eliminate the convertToScreenCoordinate method on Widget, since
+ ScrollView has redundant methods that already do the same thing.
+
+ Reviewed by Sam Weinig
+
+ * editing/mac/SelectionControllerMac.mm:
+ (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+ * platform/Widget.h:
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::containingWindow):
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Move to only one constructor for Widgets. Rename data to m_data and make
+ it have an #ifdef only for platforms that have platform-specific data (Mac
+ and Gtk).
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * platform/Widget.cpp:
+ (WebCore::Widget::init):
+ * platform/Widget.h:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::cursor):
+ (WebCore::Widget::setCursor):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::addToSuperview):
+ (WebCore::Widget::removeFromSuperview):
+ (WebCore::Widget::beforeMouseDown):
+ (WebCore::Widget::afterMouseDown):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::Widget):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::Widget):
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
+ was no reason for it to be on Widget. This change eliminates Qt ifdefs
+ from Widget.
+
+ Reviewed by Sam Weinig
+
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ (WebCore::WidgetPrivate::~WidgetPrivate):
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView):
+ * plugins/PluginView.h:
+ (WebCore::PluginView::isNPAPIPlugin):
+ (WebCore::PluginView::setIsNPAPIPlugin):
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Make geometryChanged() cross-platform on Widget. GTK and WIN platform
+ ifdefs are now gone from Widget!
+
+ Reviewed by Sam Weinig
+
+ * platform/Widget.h:
+ (WebCore::Widget::geometryChanged):
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/qt/WidgetQt.cpp:
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Consolidate convertTo/FromContainingWindow methods so that all platforms
+ but Mac share the same code.
+
+ Move convertSelfToChild and convertChildToSelf to ScrollView, since
+ Widget should know nothing about children. Make the methods cross-platform
+ on ScrollView.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::convertChildToSelf):
+ (WebCore::ScrollView::convertSelfToChild):
+ * platform/Widget.cpp:
+ (WebCore::Widget::convertToContainingWindow):
+ (WebCore::Widget::convertFromContainingWindow):
+ * platform/Widget.h:
+ (WebCore::Widget::geometryChanged):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ * platform/mac/WidgetMac.mm:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ * platform/qt/WidgetQt.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::isScrollViewScrollbar):
+ * platform/win/WidgetWin.cpp:
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Make the conversion methods that go to and from some containingWindow
+ cross-platform. Implement them on Mac.
+
+ Reviewed by Sam Weinig
+
+ * platform/Widget.h:
+ (WebCore::Widget::setContainingWindow):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertFromContainingWindow):
+ (WebCore::Widget::convertToContainingWindow):
+
+2008-09-18 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by David "Yeah-yeah" Hyatt.
+
+ Cleanup RenderStyle.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/style/CounterContent.h:
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+
+2008-09-18 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig
+
+ Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
+ Now TransformOperations and AnimationList no longer
+ inherit from Vector<> but rather have API to access.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::computedTransform):
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::createTransformOperations):
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ (WebCore::CompositeAnimation::animate):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::validateTransformFunctionList):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::validateTransformFunctionList):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateReflectionStyle):
+ * rendering/style/AnimationList.cpp:
+ (WebCore::AnimationList::operator==):
+ * rendering/style/AnimationList.h:
+ (WebCore::AnimationList::operator!=):
+ (WebCore::AnimationList::size):
+ (WebCore::AnimationList::isEmpty):
+ (WebCore::AnimationList::resize):
+ (WebCore::AnimationList::remove):
+ (WebCore::AnimationList::append):
+ (WebCore::AnimationList::animation):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::StyleRareNonInheritedData::updateKeyframes):
+ (WebCore::RenderStyle::applyTransform):
+ (WebCore::RenderStyle::adjustAnimations):
+ (WebCore::RenderStyle::adjustTransitions):
+ (WebCore::RenderStyle::transitionForProperty):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::hasTransform):
+ * rendering/style/TransformOperations.cpp:
+ (WebCore::TransformOperations::TransformOperations):
+ (WebCore::TransformOperations::operator==):
+ * rendering/style/TransformOperations.h:
+ (WebCore::TransformOperations::apply):
+ (WebCore::TransformOperations::operations):
+
+2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Build fix.
+
+ [qt] Build fixes after the Widget/ScrollView cleanup
+ topLevel() is now root()
+
+
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
+ (WebCore::ScrollView::addChild):
+ (WebCore::ScrollView::removeChild):
+
+2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20437
+
+ XMLTokenizer.cpp used to contain two different implementations. One was using
+ libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
+ separating the two implementations from each other.
+ Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
+ was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
+ XMLTokenizerLibxml2.cpp. There should be no functional changes.
+
+ Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
+ to work.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::isScriptElement):
+ (WebCore::castToScriptElement):
+ (WebCore::XMLTokenizer::setCurrentNode):
+ (WebCore::XMLTokenizer::write):
+ (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
+ (WebCore::XMLTokenizer::enterText):
+ (WebCore::toString):
+ (WebCore::XMLTokenizer::exitText):
+ (WebCore::XMLTokenizer::end):
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * dom/XMLTokenizer.h:
+ (WebCore::XMLTokenizer::wellFormed):
+ * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
+ (WebCore::createMemoryParser):
+ (WebCore::XMLTokenizer::XMLTokenizer):
+ (WebCore::XMLTokenizer::~XMLTokenizer):
+ (WebCore::XMLTokenizer::doWrite):
+ (WebCore::ignorableWhitespaceHandler):
+ (WebCore::XMLTokenizer::initializeParserContext):
+ (WebCore::XMLTokenizer::doEnd):
+ (WebCore::XMLTokenizer::lineNumber):
+ (WebCore::XMLTokenizer::columnNumber):
+ (WebCore::XMLTokenizer::stopParsing):
+ (WebCore::XMLTokenizer::resumeParsing):
+ (WebCore::parseXMLDocumentFragment):
+ (WebCore::attributesStartElementNsHandler):
+ (WebCore::parseAttributes):
+ * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
+ (WebCore::EntityResolver::resolveUndeclaredEntity):
+ (WebCore::XMLTokenizer::XMLTokenizer):
+ (WebCore::XMLTokenizer::~XMLTokenizer):
+ (WebCore::XMLTokenizer::doWrite):
+ (WebCore::XMLTokenizer::initializeParserContext):
+ (WebCore::XMLTokenizer::doEnd):
+ (WebCore::XMLTokenizer::lineNumber):
+ (WebCore::XMLTokenizer::columnNumber):
+ (WebCore::XMLTokenizer::stopParsing):
+ (WebCore::XMLTokenizer::resumeParsing):
+ (WebCore::parseXMLDocumentFragment):
+ (WebCore::attributesStartElementNsHandler):
+ (WebCore::parseAttributes):
+ (WebCore::):
+
+2008-09-18 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ Build fix for non-Mac builds.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+
+2008-09-18 Peter Kasting <pkasting@google.com>
+
+ Reviewed by hyatt. Landed by eseidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20745
+ Animated GIFs do not animate properly with (at least) CG.
+
+ * WebCore\platform\graphics\BitmapImage.cpp:
+ * WebCore\platform\graphics\BitmapImage.h:
+ * WebCore\platform\graphics\cairo\ImageCairo.cpp:
+ * WebCore\platform\graphics\cg\ImageCG.cpp:
+ * WebCore\platform\graphics\qt\ImageQt.cpp:
+ * WebCore\platform\graphics\wx\ImageWx.cpp:
+
+2008-09-18 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin
+
+ <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
+ role specifies otherwise
+
+ If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
+
+ Test: accessibility/table-with-aria-role.html
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+ (WebCore::AccessibilityTable::addChildren):
+ (WebCore::AccessibilityTable::roleValue):
+ (WebCore::AccessibilityTable::accessibilityIsIgnored):
+ (WebCore::AccessibilityTable::title):
+ * page/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
+ (WebCore::AccessibilityTableCell::isTableCell):
+ (WebCore::AccessibilityTableCell::roleValue):
+ * page/AccessibilityTableCell.h:
+ * page/AccessibilityTableRow.cpp:
+ (WebCore::AccessibilityTableRow::roleValue):
+ (WebCore::AccessibilityTableRow::isTableRow):
+ (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
+ * page/AccessibilityTableRow.h:
+
+2008-09-18 Steve Falkenburg <sfalken@apple.com>
+
+ Use higher-resolution timers on all variants of Windows.
+
+ Reviewed by Darin Adler.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::setSharedTimerFireTime):
+
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Make containingWindow() and setContainingWindow() cross-platform.
+ Add a root() function cross-platform so Qt doesn't have to
+ define its own.
+
+ Reviewed by Darin Adler
+
+ * platform/Widget.cpp:
+ (WebCore::Widget::root):
+ * platform/Widget.h:
+ (WebCore::Widget::setContainingWindow):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::containingWindow):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::addChild):
+ (WebCore::ScrollView::removeChild):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::containingWindow):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::invalidateRect):
+ (WebCore::Widget::containingWindow):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::containingWindow):
+
+2008-09-18 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
+ parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
+ dashboard-region=
+ and corresponding: <rdar://problem/6174100>
+
+ This patch makes CSSParserValue::createCSSValue handle unknown
+ identifiers.
+
+ * css/CSSParserValues.cpp:
+ (WebCore::CSSParserValue::createCSSValue): If we have an identifier
+ with no id (an unknown identifier) create a CSSPrimitiveValue of
+ type CSS_PARSER_IDENTIFIER
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::cssText):
+ (WebCore::CSSPrimitiveValue::parserValue):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::):
+
+2008-09-18 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by David "I'd prefer not" Hyatt.
+
+ More the remaining class out of RenderStyle.h/cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::CursorData::CursorData):
+ (WebCore::CursorData::operator==):
+ (WebCore::CursorData::operator!=):
+ * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::CursorList::operator[]):
+ (WebCore::CursorList::CursorList):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::deref):
+ (WebCore::RenderStyle::hasOneRef):
+ (WebCore::RenderStyle::InheritedFlags::operator!=):
+ (WebCore::RenderStyle::NonInheritedFlags::operator!=):
+ (WebCore::RenderStyle::hasBackground):
+ (WebCore::RenderStyle::outlineWidth):
+ (WebCore::RenderStyle::autoWrap):
+ (WebCore::RenderStyle::preserveNewline):
+ (WebCore::RenderStyle::collapseWhiteSpace):
+ (WebCore::RenderStyle::isCollapsibleWhiteSpace):
+ (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
+ (WebCore::RenderStyle::breakWords):
+ (WebCore::RenderStyle::outlineOffset):
+ (WebCore::RenderStyle::setLeft):
+ (WebCore::RenderStyle::setRight):
+ (WebCore::RenderStyle::setTop):
+ (WebCore::RenderStyle::setBottom):
+ (WebCore::RenderStyle::setDashboardRegion):
+ (WebCore::RenderStyle::setBackgroundColor):
+ (WebCore::RenderStyle::setBorderImage):
+ (WebCore::RenderStyle::setBorderRadius):
+ (WebCore::RenderStyle::setFontDescription):
+ (WebCore::RenderStyle::adjustBackgroundLayers):
+ (WebCore::RenderStyle::adjustMaskLayers):
+ (WebCore::RenderStyle::deleteBindingURIs):
+ (WebCore::RenderStyle::inheritBindingURIs):
+ (WebCore::RenderStyle::isDisplayReplacedType):
+ (WebCore::RenderStyle::isDisplayInlineType):
+ (WebCore::RenderStyle::isOriginalDisplayInlineType):
+ * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleInheritedData::operator!=):
+ * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleRareInheritedData::operator!=):
+ * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
+ * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Move the concept of suppression invalidation on Widgets to Scrollbar
+ instead. Since this is only used by Scrollbars, there is no need for
+ it to be on Widget.
+
+ Reviewed by Sam Weinig
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::invalidateRect):
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::suppressInvalidation):
+ (WebCore::Scrollbar::setSuppressInvalidation):
+ * platform/Widget.h:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::invalidateRect):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ (WebCore::Widget::invalidateRect):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::invalidateRect):
+
+2008-09-18 David Hyatt <hyatt@apple.com>
+
+ Make invalidate() on Widget non-virtual and make it just call
+ invalidateRect() on the boundsGeometry() of the Widget.
+
+ Reviewed by Dan Bernstein
+
+ * platform/Widget.h:
+ (WebCore::Widget::boundsGeometry):
+ (WebCore::Widget::invalidate):
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/mac/WidgetMac.mm:
+ * platform/qt/WidgetQt.cpp:
+ * platform/win/WidgetWin.cpp:
+ * platform/wx/WidgetWx.cpp:
+
+2008-09-18 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped in exile by David Hyatt.
+
+ Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
+ KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
+ RenderStyle.h/cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * css/CSSStyleSelector.cpp:
+ * css/CSSStyleSelector.h:
+ * page/animation/CompositeAnimation.cpp:
+ * page/animation/KeyframeAnimation.cpp:
+ * page/animation/KeyframeAnimation.h:
+ * rendering/RenderCounter.h:
+ * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ (WebCore::Animation::~Animation):
+ (WebCore::Animation::animationsMatch):
+ (WebCore::Animation::keyframeList):
+ (WebCore::Animation::setAnimationKeyframe):
+ * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
+ * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
+ * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::BindingURI::operator!=):
+ * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::ContentData::ContentData):
+ (WebCore::ContentData::~ContentData):
+ * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::CounterContent::CounterContent):
+ * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::CounterDirectives::CounterDirectives):
+ * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
+ (WebCore::KeyframeList::insert):
+ * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::KeyframeValue::KeyframeValue):
+ (WebCore::KeyframeList::create):
+ (WebCore::KeyframeList::KeyframeList):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::ShadowData::ShadowData):
+ (WebCore::ShadowData::~ShadowData):
+ (WebCore::ShadowData::operator!=):
+ * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleFlexibleBoxData::operator!=):
+ * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::TimingFunction::TimingFunction):
+ (WebCore::TimingFunction::operator==):
+
+2008-09-18 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix RenderStyle leaks.
+
+ * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
+
+2008-09-18 Kevin McCullough <kmccullough@apple.com>
+
+ Accidentally checked in code.
+
+ * html/HTMLElementFactory.cpp:
+ (WebCore::frameConstructor):
+ (WebCore::iframeConstructor):
+
+2008-09-18 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/5722310> gracefully handle too many console messages
+ (20904)
+ - Keep track of the most previous message and then compare it to the
+ subsequent messages as they come in. If there are multiple of the same
+ message create a count that indicates the current number.
+
+ * manual-tests/inspector/multiple-console-messages.html: Added.
+ * page/inspector/Console.js:
+ * page/inspector/inspector.css:
+
+2008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
+
+ Reviewed by Alp Toker
+
+ https://bugs.webkit.org/show_bug.cgi?id=20830
+ [GTK] Don't use deprecated pango API
+
+ Replace deprecated pango functions with non-deprecated ones for newer
+ versions of pango
+
+ * platform/graphics/gtk/FontGtk.cpp:
+ (WebCore::getDefaultPangoLayout):
+ * platform/graphics/gtk/FontPlatformDataPango.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+
+2008-09-18 Alp Toker <alp@nuanti.com>
+
+ Build fix for r36587. Add new sources (and sort the lists).
+
+ * GNUmakefile.am:
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Fix Windows build.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Switch back to having frameGeometry be virtual in order to keep Mac
+ the way it used to be.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * platform/Widget.cpp:
+ (WebCore::Widget::setParent):
+ * platform/Widget.h:
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFrameGeometry):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFrameGeometry):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFrameGeometry):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFrameGeometry):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFrameGeometry):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::setFrameGeometry):
+ (WebCore::PluginView::geometryChanged):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::updatePluginWidget):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix assertion in DOMWindow::adjustWindowRect where we were passing
+ in garbage values and were getting lucky that they were a not Nan.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::windowProtoFuncOpen):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Fix gtk build.
+
+ * rendering/style/MatrixTransformOperation.cpp:
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped with love by David Hyatt.
+
+ Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
+ ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
+ TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * css/CSSStyleSelector.cpp:
+ * page/animation/AnimationBase.cpp:
+ (WebCore::solveEpsilon):
+ * rendering/RenderLayer.cpp:
+ * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::MatrixTransformOperation::MatrixTransformOperation):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::RotateTransformOperation::RotateTransformOperation):
+ * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::ScaleTransformOperation::ScaleTransformOperation):
+ * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::SkewTransformOperation::SkewTransformOperation):
+ * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleTransformData::operator!=):
+ * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::TransformOperation::):
+ * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
+ (WebCore::TransformOperations::TransformOperations):
+ * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::TransformOperations::operator!=):
+ * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::TranslateTransformOperation::TranslateTransformOperation):
+
+2008-09-17 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ (1) Inline a bunch of methods for accessing frame geometry.
+ (2) Make sure frameGeometry() works even when you have no underlying
+ native widget.
+ (3) Cache a frame geometry rect cross-platform (even for widgets that
+ have underlying native widgets.
+ (4) PluginView's updateWindow call is now a virtual function on Widget.
+
+ Reviewed by Sam Weinig
+
+ * ChangeLog:
+ * WebCore.base.exp:
+ * platform/Widget.cpp:
+ (WebCore::Widget::setFrameGeometry):
+ * platform/Widget.h:
+ (WebCore::Widget::x):
+ (WebCore::Widget::y):
+ (WebCore::Widget::width):
+ (WebCore::Widget::height):
+ (WebCore::Widget::size):
+ (WebCore::Widget::pos):
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::resize):
+ (WebCore::Widget::move):
+ (WebCore::Widget::isFrameView):
+ (WebCore::Widget::windowClipRect):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::~Widget):
+ (WebCore::Widget::updatePlatformWidgetFrameGeometry):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::updatePlatformWidgetFrameGeometry):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::setFrameGeometry):
+ (WebCore::PluginView::geometryChanged):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
+ * plugins/wx/PluginViewWx.cpp:
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David "Waterman" Hyatt.
+
+ Fix a leak of NSViews in WidgetMac.mm.
+
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::~Widget):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by David Waterman Hyatt.
+
+ Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
+ StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::FillLayer::operator!=):
+ (WebCore::FillLayer::hasImage):
+ (WebCore::FillLayer::hasFixedImage):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ (WebCore::StyleBackgroundData::StyleBackgroundData):
+ * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleBackgroundData::~StyleBackgroundData):
+ (WebCore::StyleBackgroundData::operator!=):
+ * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleBoxData::operator!=):
+ * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleDashboardRegion::operator!=):
+ * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleMarqueeData::operator!=):
+ * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleMultiColData::operator!=):
+ (WebCore::StyleMultiColData::ruleWidth):
+ * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleVisualData::operator==):
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Remove WidgetClient from Widget.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/Widget.h:
+ (WebCore::Widget::setClient):
+ (WebCore::Widget::client):
+ * platform/WidgetClient.h: Removed.
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::Widget):
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Remove isEnabled/setEnabled from Widget. The concept of being enabled now
+ only applies to Scrollbars so the method has been moved there and made
+ cross-platform. Scrollbar subclasses that have a corresponding native
+ widget can subclass setEnabled to change the enabled state of the native
+ widget.
+
+ Reviewed by Sam Weinig & Darin Adler
+
+ * WebCore.base.exp:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ * platform/Scrollbar.h:
+ (WebCore::Scrollbar::enabled):
+ (WebCore::Scrollbar::setEnabled):
+ * platform/Widget.h:
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::setEnabled):
+ * platform/gtk/ScrollbarGtk.h:
+ * platform/gtk/WidgetGtk.cpp:
+ * platform/mac/ScrollbarMac.h:
+ * platform/mac/ScrollbarMac.mm:
+ (WebCore::ScrollbarMac::scrollbarHit):
+ (WebCore::ScrollbarMac::setEnabled):
+ * platform/mac/WidgetMac.mm:
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ * platform/wx/WidgetWx.cpp:
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by David Hyatt.
+
+ Split all RenderStyle enums into their own file.
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/style/BorderValue.h:
+ * rendering/style/CollapsedBorderValue.h:
+ * rendering/style/RenderStyle.h:
+ * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::):
+ * rendering/style/StyleCachedImage.h:
+ * rendering/style/StyleGeneratedImage.h:
+ * rendering/style/StyleImage.h:
+
+2008-09-17 Steve Falkenburg <sfalken@apple.com>
+
+ Add back isFrameView check to fix failed assertion during scroll bar teardown.
+
+ Reviewed by Dave Hyatt.
+
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::setParent):
+
+2008-09-17 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Mac build fix
+
+ * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
+
+2008-09-17 Steve Falkenburg <sfalken@apple.com>
+
+ Fix build.
+
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::setParentVisible):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::init):
+
+2008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
+ [QtWebKit] Implement error handling in TextCodecQt::decode
+ Use the QTextCodec parsing state to set the sawError out variable. This
+ is needed to pass Test 70 of acid3. The test case for this bug is
+ fast/encoding/invalid-xml.html that is now partially passed. To pass
+ it completely the Qt text codecs need to be adjusted to have proper
+ error handling.
+
+ * platform/text/qt/TextCodecQt.cpp:
+ (WebCore::TextCodecQt::decode):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Dave Hyatt.
+
+ Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
+ out of RenderStyle.h/cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::BorderData::hasBorderRadius):
+ (WebCore::BorderData::borderLeftWidth):
+ (WebCore::BorderData::borderRightWidth):
+ (WebCore::BorderData::borderTopWidth):
+ (WebCore::BorderData::borderBottomWidth):
+ (WebCore::BorderData::operator!=):
+ * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::):
+ (WebCore::BorderValue::BorderValue):
+ (WebCore::BorderValue::nonZero):
+ (WebCore::BorderValue::isTransparent):
+ (WebCore::BorderValue::isVisible):
+ * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::):
+ (WebCore::CollapsedBorderValue::CollapsedBorderValue):
+ (WebCore::CollapsedBorderValue::operator==):
+ * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::OutlineValue::OutlineValue):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
+ * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
+ (WebCore::StyleSurroundData::operator!=):
+
+2008-09-17 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ This is a better fix for: Invalid CSS code crashes Safari
+ https://bugs.webkit.org/show_bug.cgi?id=20512
+
+ The spec indicates that the only valid input for a counter is a
+ number or an identifier. So that is exactly what we allow.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseCounterContent):
+
+2008-09-17 Alp Toker <alp@nuanti.com>
+
+ GTK+ build fix. Adapt to use PlatformWidget functions.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollViewScrollbar::geometryChanged):
+ (WebCore::ScrollView::addChild):
+ (WebCore::ScrollView::removeChild):
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::ScrollbarGtk):
+ (ScrollbarGtk::~ScrollbarGtk):
+ (ScrollbarGtk::geometryChanged):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ Patch for <rdar://problem/6133884>
+ Calling window.resizeTo() on a subframe shouldn't change the window size
+
+ Test: fast/dom/Window/window-resize-and-move-sub-frame.html
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::moveBy):
+ (WebCore::DOMWindow::moveTo):
+ (WebCore::DOMWindow::resizeBy):
+ (WebCore::DOMWindow::resizeTo):
+
+2008-09-17 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
+ code crashes Safari
+ and corresponding: <rdar://problem/6173832>
+
+ Reading through the spec, it seems like a function is not valid
+ input for a counter. So this patch checks for that and bails in the
+ case of invalid input.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseCounterContent):
+
+2008-09-17 Greg Bolsinga <bolsinga@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ Fix <rdar://problem/6227089>
+ Crash in WebCore::Frame::setNeedsReapplyStyles()
+
+ View is null checked elsewhere too.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setNeedsReapplyStyles):
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Make the notion of having a native widget backing a Widget cross-platform.
+ The PlatformWidget abstraction (which already existed) is used for this.
+ Windows = HWND
+ Qt = QWidget
+ Mac = NSView
+ wx = wxWindow
+ Gtk = GtkWidget
+
+ There are new cross-platform methods that replace all of the unique
+ platform-specific methods.
+ platformWidget()
+ setPlatformWidget()
+
+ For plugins, on every platform except Qt on Windows, the plugin's native
+ widget is now stored in the Widget base class. Since Qt on Windows uses
+ HWNDs for plugins instead of QWidget, it is the only platform to keep the
+ m_window variable in PluginView.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper attachmentView]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passMouseDownEventToWidget):
+ (WebCore::EventHandler::mouseDownViewIfStillGood):
+ (WebCore::EventHandler::passWheelEventToWidget):
+ (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
+ * platform/Widget.cpp:
+ (WebCore::Widget::init):
+ (WebCore::Widget::setParent):
+ (WebCore::Widget::releasePlatformWidget):
+ (WebCore::Widget::retainPlatformWidget):
+ * platform/Widget.h:
+ (WebCore::Widget::platformWidget):
+ (WebCore::Widget::setPlatformWidget):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::setFocus):
+ (WebCore::gdkDrawable):
+ (WebCore::Widget::setCursor):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ (WebCore::Widget::setEnabled):
+ (WebCore::Widget::isEnabled):
+ (WebCore::Widget::paint):
+ * platform/mac/PlatformScreenMac.mm:
+ (WebCore::screenRect):
+ (WebCore::screenAvailableRect):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::scrollView):
+ (WebCore::ScrollView::update):
+ (WebCore::ScrollView::inWindow):
+ * platform/mac/ScrollbarMac.mm:
+ (WebCore::ScrollbarMac::ScrollbarMac):
+ (WebCore::ScrollbarMac::~ScrollbarMac):
+ (WebCore::ScrollbarMac::updateThumbPosition):
+ (WebCore::ScrollbarMac::updateThumbProportion):
+ (WebCore::ScrollbarMac::scrollbarHit):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::setEnabled):
+ (WebCore::Widget::isEnabled):
+ (WebCore::Widget::setFocus):
+ (WebCore::Widget::getOuterView):
+ (WebCore::Widget::paint):
+ (WebCore::Widget::invalidate):
+ (WebCore::Widget::invalidateRect):
+ (WebCore::Widget::setIsSelected):
+ (WebCore::Widget::releasePlatformWidget):
+ (WebCore::Widget::retainPlatformWidget):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::setFrameGeometry):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ (WebCore::Widget::isEnabled):
+ (WebCore::Widget::setEnabled):
+ (WebCore::Widget::invalidateRect):
+ (WebCore::Widget::containingWindow):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::frameGeometry):
+ (WebCore::Widget::setFocus):
+ (WebCore::Widget::setCursor):
+ (WebCore::Widget::show):
+ (WebCore::Widget::hide):
+ (WebCore::Widget::setFrameGeometry):
+ (WebCore::Widget::setEnabled):
+ (WebCore::Widget::isEnabled):
+ (WebCore::Widget::invalidate):
+ (WebCore::Widget::invalidateRect):
+ (WebCore::Widget::paint):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView):
+ * plugins/PluginView.h:
+ (WebCore::PluginView::platformPluginWidget):
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updateWindow):
+ (WebCore::PluginView::setFocus):
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::setParentVisible):
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::forceRedraw):
+ (WebCore::PluginView::init):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::updateWindow):
+ (WebCore::PluginView::setFocus):
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::setParentVisible):
+ (WebCore::PluginView::getValue):
+ (WebCore::PluginView::~PluginView):
+ (WebCore::PluginView::init):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::updateWindow):
+ (WebCore::PluginView::setFocus):
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::setParent):
+ (WebCore::PluginView::setParentVisible):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::invalidateRect):
+ (WebCore::PluginView::forceRedraw):
+ (WebCore::PluginView::~PluginView):
+ (WebCore::PluginView::init):
+
+2008-09-17 Sam Weinig <sam@webkit.org>
+
+ Fix assert.
+
+ * platform/Widget.cpp:
+ (WebCore::Widget::setParent):
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Beginnings of Widget refactoring (in order to make the mixing of
+ widgets with and without corresponding native widgets more cross-platform).
+
+ This first patch makes the concept of a parent ScrollView cross-platform.
+
+ Note the similarity of the show/hide methods on the three PluginViews. This
+ will be refactored better in a later patch so that they can all share
+ a base class Widget show/hide method. For now the changes were made
+ simply to be able to bring WidgetWin's setParent method up into Widget.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.base.exp:
+ * platform/ScrollView.h:
+ * platform/Widget.cpp:
+ (WebCore::Widget::init):
+ (WebCore::Widget::setParent):
+ * platform/Widget.h:
+ (WebCore::Widget::isSelfVisible):
+ (WebCore::Widget::isParentVisible):
+ (WebCore::Widget::isVisible):
+ (WebCore::Widget::setParentVisible):
+ (WebCore::Widget::isPluginView):
+ (WebCore::Widget::parent):
+ (WebCore::Widget::handleEvent):
+ (WebCore::Widget::geometryChanged):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::Widget):
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::addChild):
+ (WebCore::ScrollView::removeChild):
+ * platform/mac/ScrollbarMac.mm:
+ (WebCore::ScrollbarMac::~ScrollbarMac):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::~Widget):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::WidgetPrivate::WidgetPrivate):
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::topLevel):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
+ (WebCore::ScrollView::setAncestorVisible):
+ (WebCore::ScrollView::show):
+ (WebCore::ScrollView::hide):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::Widget):
+ (WebCore::Widget::setParent):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::Widget):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParentVisible):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParentVisible):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::show):
+ (WebCore::PluginView::hide):
+ (WebCore::PluginView::setParentVisible):
+
+2008-09-17 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
+
+2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Fix the QtWebKit/Mac build
+
+ * platform/qt/ScrollViewQt.cpp: add include
+
+2008-09-17 David Hyatt <hyatt@apple.com>
+
+ Add a #define to control whether or not to use an NSScroller on Mac.
+ This ifdef will allow the new NSView-less NSScroller on Mac to be
+ developed side by side with the current one.
+
+ The new scroller paints a debug red if turned on (although due to
+ Widget issues you won't see anything paint yet).
+
+ Reviewed by olliej
+
+ * platform/Scrollbar.cpp:
+ * platform/Scrollbar.h:
+ * platform/mac/ScrollbarMac.h:
+ * platform/mac/ScrollbarMac.mm:
+ * platform/mac/ScrollbarThemeMac.cpp:
+ (WebCore::ScrollbarThemeMac::paint):
+ * platform/mac/ScrollbarThemeMac.h:
+
+2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Alp Toker.
+
+ http://bugs.webkit.org/show_bug.cgi?id=20854
+ [GTK] Windows can be not realized in ScrollView::update
+
+ Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::update):
+
+2008-09-16 Alp Toker <alp@nuanti.com>
+
+ Suggested by Dave Hyatt.
+
+ Build fix and cleanup. Rename ScrollBar to Scrollbar.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * editing/EditorCommand.cpp:
+ * page/EventHandler.cpp:
+ * page/gtk/EventHandlerGtk.cpp:
+ * page/mac/EventHandlerMac.mm:
+ * page/mac/FrameMac.mm:
+ * page/qt/EventHandlerQt.cpp:
+ * page/wx/EventHandlerWx.cpp:
+ * platform/PopupMenu.h:
+ * platform/ScrollBar.cpp: Removed.
+ * platform/ScrollBar.h: Removed.
+ * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
+ * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
+ * platform/gtk/ScrollbarGtk.cpp:
+ (ScrollbarGtk::ScrollbarGtk):
+ * platform/gtk/ScrollbarGtk.h:
+ * platform/mac/ScrollbarMac.h:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/qt/ScrollbarQt.cpp:
+ * platform/qt/ScrollbarThemeQt.cpp:
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PopupMenuWin.cpp:
+ * platform/win/ScrollViewWin.cpp:
+ * platform/win/ScrollbarThemeWin.cpp:
+ * platform/wx/ScrollViewWx.cpp:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ * rendering/HitTestResult.cpp:
+ * rendering/RenderLayer.cpp:
+ * rendering/RenderTextControl.cpp:
+
+2008-09-16 David Hyatt <hyatt@apple.com>
+
+ Fix Qt build bustage by making moveThumb a member of Scrollbar so that
+ it can be called from ScrollbarQt.
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::moveThumb):
+ (WebCore::Scrollbar::handleMouseMoveEvent):
+ (WebCore::Scrollbar::handleMousePressEvent):
+ * platform/ScrollBar.h:
+ * platform/qt/ScrollViewQt.cpp:
+ * platform/qt/ScrollbarQt.cpp:
+ (WebCore::Scrollbar::handleContextMenuEvent):
+
+2008-09-16 David Hyatt <hyatt@apple.com>
+
+ Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
+ native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
+ now just use Scrollbar.
+
+ Reviewed by Sam Weinig
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/mac/FrameMac.mm:
+ * platform/PopupMenu.h:
+ (WebCore::PopupMenu::scrollbar):
+ * platform/ScrollBar.cpp:
+ (WebCore::createNativeScrollbar):
+ * platform/ScrollBar.h:
+ * platform/gtk/PlatformScrollBar.h: Removed.
+ * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
+ * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
+ (gtkScrollEventCallback):
+ (ScrollbarGtk::ScrollbarGtk):
+ (ScrollbarGtk::~ScrollbarGtk):
+ (ScrollbarGtk::updateThumbPosition):
+ (ScrollbarGtk::updateThumbProportion):
+ (ScrollbarGtk::setFrameGeometry):
+ (ScrollbarGtk::geometryChanged):
+ (ScrollbarGtk::gtkValueChanged):
+ * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
+ * platform/mac/PlatformScrollBar.h: Removed.
+ * platform/mac/PlatformScrollBarMac.mm: Removed.
+ * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
+ * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
+ (-[WebCoreScrollBar initWithScrollbarMac:]):
+ (-[WebCoreScrollBar detachScrollbarMac]):
+ (WebCore::Scrollbar::createNativeScrollbar):
+ (WebCore::ScrollbarMac::ScrollbarMac):
+ (WebCore::ScrollbarMac::~ScrollbarMac):
+ (WebCore::ScrollbarMac::updateThumbPosition):
+ (WebCore::ScrollbarMac::updateThumbProportion):
+ (WebCore::ScrollbarMac::scrollbarHit):
+ * platform/qt/PlatformScrollBar.h: Removed.
+ * platform/qt/PlatformScrollBarQt.cpp: Removed.
+ * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
+ (WebCore::Scrollbar::handleContextMenuEvent):
+ * rendering/HitTestResult.cpp:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::destroyScrollbar):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::~RenderListBox):
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::isPointInOverflowControl):
+ * rendering/RenderObject.h:
+ * rendering/RenderTextControl.cpp:
+
+2008-09-16 David Hyatt <hyatt@apple.com>
+
+ Make the scrollbar resizer-dodging logic cross-platform in the
+ Scrollbar class.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::setFrameGeometry):
+ (WebCore::Scrollbar::setParent):
+ (WebCore::Scrollbar::windowClipRect):
+ * platform/ScrollBar.h:
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::windowResizerRect):
+ (WebCore::ScrollView::resizerOverlapsContent):
+ (WebCore::ScrollView::adjustOverlappingScrollbarCount):
+ * platform/Widget.h:
+ (WebCore::Widget::setParent):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertToContainingWindow):
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarWin.cpp:
+
+2008-09-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=15129
+ <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
+
+ Covered by fast/repaint/4776765.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
+ did not have layout in the beginning.
+ (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
+ layout in the beginning, repaint it in its new position, to compensate
+ for the above (regardless of whether it "moved").
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
+ about generalizing this fix in the future.
+
+2008-09-16 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=15384
+ Div does not notice when grandparent changes height
+
+ Test: fast/block/basic/quirk-percent-height-grandchild.html
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20714
+ Resizing Gmail inbox vertically results in whitespace at the bottom of the window
+
+ Test: fast/replaced/percent-height-in-anonymous-block.html
+
+ Added a two-way mapping between boxes with percentage heights and
+ their non-parent ancestors up to the one the height is computed relative
+ to. In quirks mode (the first bug), this can be any number of containing
+ block with auto height. In strict mode (the second bug) this can be
+ the containing block of an anonymous block containing a replaced
+ element.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
+ mapping to/from this block to percentage-height descendants.
+ (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
+ percentage-height descendants (and their containing block ancestry chain
+ up to this block) for layout. This ensures that those descendants whose
+ height depends on the height of this block (or an ancestor) are updated.
+ (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
+ a two-way mapping between this block and the given box.
+ (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
+ all the mapping to/from this box.
+ * rendering/RenderBlock.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::setStyle): Added calls to
+ removePercentHeightDescendant() when style changes and the box
+ previously had a percentage height. An exception is when the style
+ change does not require layout, in which case the box still has
+ a percentage height and the mappings are valid. In all other cases,
+ any required mappings will be (re-)established during layout.
+ (WebCore::RenderBox::destroy): Added a call to
+ removePercentHeightDescendant.
+ (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
+ mode, if a higher-than-parent containing block is affecting the box's
+ height, creates a mapping between the box and that block.
+ (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
+ anonymous containing blocks, if any, and when that happens, use
+ addPercentHeightDescendant() to ensure that the non-anonymous block
+ is aware of the dependent percent-height box.
+
+2008-09-16 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Oliver Hunt and Alp Toker.
+
+ Implemented toDataURL in Cairo. Only PNG support
+ at the moment.
+
+ Qt, Cairo and wx require toDataURL implementations
+ https://bugs.webkit.org/show_bug.cgi?id=17719
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedImageMIMETypesForEncoding):
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::writeFunction):
+ (WebCore::ImageBuffer::toDataURL):
+
+2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Hide unused media element controls in the QtWebKit port
+
+ * platform/qt/html4-adjustments-qt.css
+
+2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation of the Qt scrollbar code.
+
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::scPart):
+ (WebCore::styleOptionSlider):
+ (WebCore::thumbLength):
+ (WebCore::pixelPosToRangeValue):
+ (WebCore::PlatformScrollbar::handleContextMenuEvent):
+
+2008-09-16 Adam Treat <treat@kde.org>
+
+ Reviewed by Anders Carlsson.
+
+ Prevent accesses off of the end of the buffer introduced in r36450
+ and when checking for descriptions of mime. Also, coding style fix.
+
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+
+2008-09-15 Rob Buis <buis@kde.org>
+
+ Reviewed by Eric.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20634
+ SVG transform attribute is ignored by <use> in <clipPath>
+
+ Transform the paths with the local transform when part
+ of a clip path.
+
+ Test: svg/custom/use-clipped-transform.svg
+
+ * svg/SVGClipPathElement.cpp:
+ (WebCore::SVGClipPathElement::canvasResource):
+ * svg/SVGStyledTransformableElement.cpp:
+ (WebCore::SVGStyledTransformableElement::toClipPath):
+ * svg/SVGStyledTransformableElement.h:
+
+2008-09-15 Dave Hyatt <hyatt@apple.com>
+
+ Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
+ to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::thumbUnderMouse):
+ (WebCore::Scrollbar::autoscrollPressedPart):
+ (WebCore::Scrollbar::startTimerIfNeeded):
+ (WebCore::moveThumb):
+ (WebCore::Scrollbar::handleMouseMoveEvent):
+ (WebCore::Scrollbar::handleMousePressEvent):
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::pressedPos):
+ (WebCore::Scrollbar::pixelStep):
+ (WebCore::Scrollbar::setPressedPos):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::thumbPosition):
+ (WebCore::ScrollbarTheme::thumbLength):
+ (WebCore::ScrollbarTheme::trackPosition):
+ (WebCore::ScrollbarTheme::trackLength):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::trackPosition):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::):
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+ (WebCore::ScrollbarThemeQt::hitTest):
+ (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
+ (WebCore::ScrollbarThemeQt::invalidatePart):
+ (WebCore::ScrollbarThemeQt::thumbPosition):
+ (WebCore::):
+ * platform/qt/ScrollbarThemeQt.h:
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
+ * platform/win/ScrollbarThemeSafari.h:
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-09-15 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20180
+
+ Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
+
+ * GNUmakefile.am: Add CSSNthSelector
+ * WebCore.pro: Add CSSNthSelector
+ * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
+ * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
+ * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
+ * css/CSSNthSelector.cpp: Added.
+ (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
+ (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
+ * css/CSSNthSelector.h: Added.
+ (WebCore::CSSNthSelector::CSSNthSelector):
+ (WebCore::CSSNthSelector::~CSSNthSelector):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::createFloatingNthSelector):
+ * css/CSSParser.h:
+ * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
+ (WebCore::CSSSelector::CSSSelector):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
+
+2008-09-15 Matt Lilek <webkit@mattlilek.com>
+
+ Reviewed by Tim Hatcher.
+
+ Clean up some inspector JS callbacks to remove an extra return.
+
+ * page/InspectorController.cpp:
+ (WebCore::hideDOMNodeHighlight):
+ (WebCore::loaded):
+ (WebCore::unloading):
+ (WebCore::attach):
+ (WebCore::detach):
+ (WebCore::startDebuggingAndReloadInspectedPage):
+ (WebCore::stopDebugging):
+ (WebCore::debuggerAttached):
+ (WebCore::pauseOnExceptions):
+ (WebCore::pauseInDebugger):
+ (WebCore::resumeDebugger):
+ (WebCore::stepOverStatementInDebugger):
+ (WebCore::stepIntoStatementInDebugger):
+ (WebCore::stepOutOfFunctionInDebugger):
+ (WebCore::isWindowVisible):
+ (WebCore::closeWindow):
+
+2008-09-15 Dave Hyatt <hyatt@apple.com>
+
+ Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
+ now share most of their code.
+
+ Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
+ also is never used in our code anyway.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/ScrollTypes.h:
+ (WebCore::):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::splitTrack):
+ (WebCore::ScrollbarThemeComposite::thumbLength):
+ (WebCore::ScrollbarThemeComposite::minimumThumbLength):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/mac/PlatformScrollBarMac.mm:
+ (NSControlSizeForScrollBarControlSize):
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp: Removed.
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ * platform/win/ScrollbarThemeSafari.cpp:
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::):
+ (WebCore::scrollbarControlStateFromThemeState):
+ (WebCore::ScrollbarThemeSafari::hasButtons):
+ (WebCore::ScrollbarThemeSafari::hasThumb):
+ (WebCore::buttonRepaintRect):
+ (WebCore::ScrollbarThemeSafari::backButtonRect):
+ (WebCore::ScrollbarThemeSafari::forwardButtonRect):
+ (WebCore::trackRepaintRect):
+ (WebCore::ScrollbarThemeSafari::trackRect):
+ (WebCore::ScrollbarThemeSafari::minimumThumbLength):
+ (WebCore::ScrollbarThemeSafari::paintTrack):
+ (WebCore::ScrollbarThemeSafari::paintButton):
+ (WebCore::ScrollbarThemeSafari::paintThumb):
+ * platform/win/ScrollbarThemeSafari.h:
+ * platform/win/ScrollbarThemeWin.cpp:
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-09-15 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler, Beth Dakin
+
+ <rdar://problem/4003789> Expose lists as AXList
+ <rdar://problem/5707399> VO: Definition lists not announced in Safari
+
+ Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
+ AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
+ Inside the definition list, each <dt> "term" has an accessibility description ("term"),
+ as does each <dd> tag ("definition")
+
+ Test: accessibility/lists.html
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * page/AXObjectCache.cpp:
+ * page/AccessibilityList.cpp: Added.
+ * page/AccessibilityList.h: Added.
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ * page/AccessibilityTable.cpp:
+ * page/mac/AccessibilityObjectWrapper.mm:
+ * page/mac/WebCoreViewFactory.h:
+ * platform/LocalizedStrings.h:
+ * platform/mac/LocalizedStringsMac.mm:
+ * platform/qt/Localizations.cpp:
+
+2008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
+ Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
+
+ Several renames:
+ dispatchHTMLEvent -> dispatchEventForType
+ setHTMLEventListener -> setEventListenerForType
+ getHTMLEventListener -> eventListenerForType
+ removeHTMLEventListener -> removeEventListenerForType
+ isHTMLEventListener -> isAttachedToEventTargetNode
+ ...
+
+ Similar renames for the dispatch/get/set/*Window*Event functions.
+ Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
+
+ Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
+ as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
+
+ setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
+ SVG is able to use the code as well now. This affects most files in html/.
+
+ No functional changes.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
+ (WebCore::JSDOMWindowBase::setListener):
+ (WebCore::JSDOMWindowBase::getListener):
+ (WebCore::JSDOMWindowBase::findJSEventListener):
+ (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
+ (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
+ (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
+ (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
+ (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
+ (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
+ (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
+ (WebCore::JSEventListener::JSEventListener):
+ (WebCore::JSEventListener::~JSEventListener):
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ (WebCore::eventParameterName):
+ (WebCore::JSLazyEventListener::parseCode):
+ (WebCore::getNodeEventListener):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSAbstractEventListener::JSAbstractEventListener):
+ (WebCore::JSUnprotectedEventListener::create):
+ (WebCore::JSEventListener::create):
+ (WebCore::JSLazyEventListener::):
+ (WebCore::JSLazyEventListener::create):
+ * bindings/js/JSEventTargetNode.cpp:
+ (WebCore::JSEventTargetNode::setListener):
+ (WebCore::JSEventTargetNode::getListener):
+ * bindings/js/JSSVGLazyEventListener.cpp: Removed.
+ * bindings/js/JSSVGLazyEventListener.h: Removed.
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createHTMLEventHandler):
+ (WebCore::ScriptController::createSVGEventHandler):
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ (WebCore::Document::handleWindowEvent):
+ (WebCore::Document::setWindowEventListenerForType):
+ (WebCore::Document::windowEventListenerForType):
+ (WebCore::Document::removeWindowEventListenerForType):
+ (WebCore::Document::addWindowEventListener):
+ (WebCore::Document::hasWindowEventListener):
+ (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
+ (WebCore::Document::createEventListener):
+ (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
+ * dom/Document.h:
+ * dom/EventListener.h:
+ (WebCore::EventListener::isAttachedToEventTargetNode):
+ * dom/EventTargetNode.cpp:
+ (WebCore::EventTargetNode::dispatchFocusEvent):
+ (WebCore::EventTargetNode::dispatchBlurEvent):
+ (WebCore::EventTargetNode::dispatchEventForType):
+ (WebCore::EventTargetNode::removeEventListenerForType):
+ (WebCore::EventTargetNode::setEventListenerForType):
+ (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
+ (WebCore::EventTargetNode::eventListenerForType):
+ * dom/EventTargetNode.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::notifyFinished):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::parseMappedAttribute):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::parseMappedAttribute):
+ (WebCore::HTMLElement::checkDTD):
+ * html/HTMLElement.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::onChange):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::prepareSubmit):
+ (WebCore::HTMLFormElement::reset):
+ (WebCore::HTMLFormElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ (WebCore::HTMLInputElement::onSearch):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::asyncEventTimerFired):
+ (WebCore::HTMLMediaElement::load):
+ (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
+ (WebCore::HTMLMediaElement::setReadyState):
+ (WebCore::HTMLMediaElement::seek):
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+ (WebCore::HTMLMediaElement::willSaveToCache):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ (WebCore::HTMLScriptElement::dispatchLoadEvent):
+ (WebCore::HTMLScriptElement::dispatchErrorEvent):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::parseMappedAttribute):
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::mouseButtonListener):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::canMouseDownStartSelect):
+ (WebCore::EventHandler::canMouseDragExtendSelect):
+ * page/Frame.cpp:
+ (WebCore::Frame::sendScrollEvent):
+ * page/Page.cpp:
+ (WebCore::networkStateChanged):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::valueChanged):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::selectionChanged):
+ * svg/SVGDocumentExtensions.cpp:
+ * svg/SVGDocumentExtensions.h:
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::parseMappedAttribute):
+ (WebCore::SVGElement::finishParsingChildren):
+ * svg/SVGElement.h:
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::parseMappedAttribute):
+ * svg/SVGSVGElement.h:
+
+2008-09-15 Dave Hyatt <hyatt@apple.com>
+
+ Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
+ need to be converted.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::updateThumbPosition):
+ (WebCore::Scrollbar::updateThumbProportion):
+ (WebCore::Scrollbar::autoscrollPressedPart):
+ (WebCore::Scrollbar::startTimerIfNeeded):
+ * platform/ScrollBar.h:
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::invalidateParts):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::hitTest):
+ (WebCore::ScrollbarThemeComposite::invalidatePart):
+ (WebCore::ScrollbarThemeComposite::thumbPosition):
+ (WebCore::ScrollbarThemeComposite::thumbLength):
+ (WebCore::ScrollbarThemeComposite::trackLength):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+
+2008-09-15 David Smith <catfish.man@gmail.com>
+
+ "Just do it"'d by Mark Rowe
+
+ https://bugs.webkit.org/show_bug.cgi?id=20856
+ Add missing license header
+
+ * dom/NodeRenderStyle.h:
+
+2008-09-15 Dean Jackson <dino@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Add default constructor for ShadowData
+ https://bugs.webkit.org/show_bug.cgi?id=20757
+
+ Test: transitions/shadow.html
+
+ * rendering/style/RenderStyle.h:
+
+2008-09-15 Dean Jackson <dino@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ RenderStyle should update keyframes.
+ http://bugs.webkit.org/show_bug.cgi?id=20756
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::StyleRareNonInheritedData::updateKeyframes):
+
+2008-09-15 Dean Jackson <dino@apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ Unnecessary ASSERT in ImplicitAnimation destructor.
+ https://bugs.webkit.org/show_bug.cgi?id=20817
+
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::~ImplicitAnimation):
+
+2008-09-15 Adam Treat <treat@kde.org>
+
+ Reviewed by Simon.
+
+ Fix plugin extension info. It was returning the mimetype where the
+ extension was given.
+
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+
+2008-09-15 Dean Jackson <dino@apple.com>
+
+ Reviewed by Tim Hatcher
+
+ Coding style violation!!!! Cleanup AnimationBase.cpp
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::blendFunc):
+
+2008-09-15 David Hyatt <hyatt@apple.com>
+
+ Move all hit testing code for scrollbars into the base class. Refactor
+ it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
+ functions.
+
+ No platform is using this code yet. Although it has been moved and compiles
+ (even on Mac), it is not being used on any platform.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::autoscrollPressedPart):
+ (WebCore::Scrollbar::startTimerIfNeeded):
+ (WebCore::Scrollbar::handleMouseMoveEvent):
+ (WebCore::Scrollbar::handleMouseOutEvent):
+ (WebCore::Scrollbar::handleMouseReleaseEvent):
+ (WebCore::Scrollbar::handleMousePressEvent):
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::handleContextMenuEvent):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::hitTest):
+ (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
+ (WebCore::ScrollbarTheme::invalidatePart):
+ (WebCore::ScrollbarTheme::shouldCenterOnThumb):
+ (WebCore::ScrollbarTheme::centerOnThumb):
+ (WebCore::ScrollbarTheme::thumbPosition):
+ (WebCore::ScrollbarTheme::thumbLength):
+ (WebCore::ScrollbarTheme::trackLength):
+ (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
+ (WebCore::ScrollbarTheme::autoscrollTimerDelay):
+ * platform/Widget.h:
+ (WebCore::Widget::parent):
+ * platform/mac/PlatformScrollBar.h:
+ (WebCore::PlatformScrollbar::handleMouseMoveEvent):
+ (WebCore::PlatformScrollbar::handleMouseOutEvent):
+ (WebCore::PlatformScrollbar::handleMousePressEvent):
+ (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::convertFromContainingWindow):
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-09-15 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
+
+ Cache the next breakable position for text nodes in InlineIterator.
+
+ * rendering/bidi.cpp:
+ (WebCore::InlineIterator::InlineIterator):
+ (WebCore::InlineIterator::increment):
+ (WebCore::RenderBlock::findNextLineBreak):
+
+2008-09-15 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein
+
+ Fix assertion and integral pixel issue when creating subimages.
+ https://bugs.webkit.org/show_bug.cgi?id=20786
+
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw):
+
+2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Implment seek() and clean up and improve debugging output
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (debugMediaObject):
+ (WebCore::MediaPlayerPrivate::seek):
+ (WebCore::MediaPlayerPrivate::setVolume):
+ (WebCore::MediaPlayerPrivate::setMuted):
+ (WebCore::MediaPlayerPrivate::updateStates):
+ (WebCore::MediaPlayerPrivate::naturalSize):
+ (WebCore::MediaPlayerPrivate::paint):
+ (WebCore::MediaPlayerPrivate::stateChanged):
+ (WebCore::MediaPlayerPrivate::tick):
+
+2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
+ Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
+
+ m_mediaObject, m_audioOutput, m_videoWidget get created in the
+ c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
+ only check if we use the MediaPlayerPrivate after it has been deleted.
+
+ Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::play):
+ (WebCore::MediaPlayerPrivate::setVolume):
+ (WebCore::MediaPlayerPrivate::updateStates):
+
+2008-09-15 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Maciej.
+
+ <rdar://problem/6163988>
+ https://bugs.webkit.org/show_bug.cgi?id=20457
+ Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
+
+ Check the width and height and throw an exception if any of them are 0.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::createPattern):
+
+2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Render media element controls with antialiasing enabled
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::paintMediaMuteButton):
+ (WebCore::RenderThemeQt::paintMediaPlayButton):
+ (WebCore::RenderThemeQt::paintMediaSliderTrack):
+ (WebCore::RenderThemeQt::paintMediaSliderThumb):
+
+2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
+
+ Reviewed by Simon.
+
+ Upon non fatal error, switch to the pause state (so that playback can continue)
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
+ (WebCore::MediaPlayerPrivate::updateStates):
+
+2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
+
+ * WebCore.pro:
+
+2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Make QtInstance::create() private and fix caching
+
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getQtInstance):
+ (JSC::Bindings::QtInstance::getRuntimeObject):
+ * bridge/qt/qt_instance.h:
+ (JSC::Bindings::QtInstance::create):
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue):
+ (JSC::Bindings::QtConnectionObject::execute):
+
+2008-09-15 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20180
+
+ >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
+ With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
+ querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::CSSStyleSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
+ * css/CSSStyleSelector.h:
+
+2008-09-14 Dave Hyatt <hyatt@apple.com>
+
+ Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
+ is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::client):
+ (WebCore::Scrollbar::currentPos):
+ (WebCore::Scrollbar::totalSize):
+ * platform/ScrollbarTheme.h:
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::pageForScrollView):
+ (WebCore::ScrollbarThemeComposite::paint):
+ * platform/ScrollbarThemeComposite.h:
+ (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ * platform/win/PlatformScrollBarWin.cpp:
+ * platform/win/ScrollbarThemeSafari.h:
+ (WebCore::ScrollbarThemeSafari::hasButtons):
+ (WebCore::ScrollbarThemeSafari::hasThumb):
+ (WebCore::ScrollbarThemeSafari::backButtonRect):
+ (WebCore::ScrollbarThemeSafari::forwardButtonRect):
+ (WebCore::ScrollbarThemeSafari::trackRect):
+ (WebCore::ScrollbarThemeSafari::splitTrack):
+ (WebCore::ScrollbarThemeSafari::paintTrack):
+ (WebCore::ScrollbarThemeSafari::paintButton):
+ (WebCore::ScrollbarThemeSafari::paintThumb):
+ * platform/win/ScrollbarThemeWin.cpp:
+ (WebCore::isRunningOnVistaOrLater):
+ (WebCore::checkAndInitScrollbarTheme):
+ (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
+ (WebCore::ScrollbarThemeWin::themeChanged):
+ (WebCore::ScrollbarThemeWin::hasThumb):
+ (WebCore::ScrollbarThemeWin::backButtonRect):
+ (WebCore::ScrollbarThemeWin::forwardButtonRect):
+ (WebCore::ScrollbarThemeWin::trackRect):
+ (WebCore::ScrollbarThemeWin::splitTrack):
+ (WebCore::ScrollbarThemeWin::paintTrack):
+ (WebCore::ScrollbarThemeWin::paintButton):
+ (WebCore::gripperRect):
+ (WebCore::paintGripper):
+ (WebCore::ScrollbarThemeWin::paintThumb):
+ (WebCore::ScrollbarThemeWin::thumbPosition):
+ (WebCore::ScrollbarThemeWin::thumbLength):
+ (WebCore::ScrollbarThemeWin::trackLength):
+ * platform/win/ScrollbarThemeWin.h:
+ (WebCore::ScrollbarThemeWin::hasButtons):
+ (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
+
+2008-09-14 Anthony Ricaud <rik24d@gmail.com>
+
+ Moving all resource graphs under the same container for future scalable feature.
+ This is a speedup on resize but maybe a loss on changing the sorting function.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20555
+
+ Reviewed by Timothy Hatcher.
+
+ * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
+ Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
+ * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
+
+2008-09-14 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20738
+ compareBoundaryPoints gives incorrect results
+
+ Test: fast/dom/Range/compareBoundaryPoints-2.html
+
+ * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
+ and END_TO_START.
+ * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
+
+2008-09-14 Maciej Stachowiak <mjs@apple.com>
+
+ Unreviewed build fix.
+
+ Trying again.
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::hasInstance):
+
+2008-09-14 Maciej Stachowiak <mjs@apple.com>
+
+ Unreviewed build fix.
+
+ Blind attempt to fix build. Correct parameters for hasInstance.
+
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::hasInstance):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+
+2008-09-14 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Sam Weinig.
+
+ - revert <http://trac.webkit.org/changeset/36382> because it exposed
+ <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
+ on Tiger.
+
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::getFontDataForCharacters):
+ (WebCore::FontCache::getLastResortFallbackFont):
+
+2008-09-14 Dave Hyatt <hyatt@apple.com>
+
+ Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
+ ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
+ theme.
+
+ Reviewed by Sam Weinig
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/win/ScrollbarThemeSafari.h:
+ * platform/win/ScrollbarThemeWin.h:
+
+2008-09-14 Alp Toker <alp@nuanti.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=20320
+ [GTK] A white rectangle is visible behind widgets with rounded corners
+
+ Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
+ style exempt).
+
+ Requested by Michael Monreal.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::RenderThemeGtk):
+ * platform/gtk/gtk2drawing.c:
+ (moz_gtk_set_widget_name):
+ (ensure_window_widget):
+ (setup_widget_prototype):
+ (ensure_button_arrow_widget):
+ (moz_gtk_get_combo_box_inner_button):
+ (moz_gtk_get_combo_box_button_inner_widgets):
+ (ensure_combo_box_widgets):
+ (moz_gtk_get_combo_box_entry_inner_widgets):
+ (moz_gtk_get_combo_box_entry_arrow):
+ (ensure_combo_box_entry_widgets):
+ (ensure_toolbar_widget):
+ (ensure_tooltip_widget):
+ (ensure_menu_bar_widget):
+ (ensure_menu_bar_item_widget):
+ (ensure_menu_popup_widget):
+ (ensure_menu_item_widget):
+ (ensure_image_menu_item_widget):
+ (ensure_menu_separator_widget):
+ (ensure_check_menu_item_widget):
+ (ensure_tree_header_cell_widget):
+ (ensure_scrolled_window_widget):
+ (moz_gtk_button_paint):
+ (moz_gtk_init):
+ (moz_gtk_button_get_inner_border):
+ (moz_gtk_toggle_paint):
+ (calculate_button_inner_rect):
+ (calculate_arrow_rect):
+ (moz_gtk_scrollbar_button_paint):
+ (moz_gtk_scrollbar_thumb_paint):
+ (moz_gtk_caret_paint):
+ (moz_gtk_entry_paint):
+ (moz_gtk_treeview_paint):
+ (moz_gtk_tree_header_cell_paint):
+ (moz_gtk_combo_box_paint):
+ (moz_gtk_downarrow_paint):
+ (moz_gtk_combo_box_entry_button_paint):
+ (moz_gtk_toolbar_paint):
+ (moz_gtk_tab_scroll_arrow_paint):
+ (moz_gtk_menu_bar_paint):
+ (moz_gtk_menu_item_paint):
+ (moz_gtk_get_widget_border):
+ (moz_gtk_get_combo_box_entry_button_size):
+ (moz_gtk_get_tab_scroll_arrow_size):
+ (moz_gtk_get_downarrow_size):
+ (moz_gtk_images_in_menus):
+ (moz_gtk_widget_paint):
+ (moz_gtk_shutdown):
+ * platform/gtk/gtkdrawing.h:
+
+2008-09-14 David Hyatt <hyatt@apple.com>
+
+ Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
+ painting. Mac and Gtk themes don't do anything and just let the
+ underlying widget paint. Qt now uses the theme to paint. wx doesn't
+ do anything yet.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::paint):
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::value):
+ (WebCore::Scrollbar::visibleSize):
+ (WebCore::Scrollbar::maximum):
+ (WebCore::Scrollbar::lineStep):
+ (WebCore::Scrollbar::pageStep):
+ (WebCore::Scrollbar::pixelStep):
+ (WebCore::Scrollbar::pressedPart):
+ (WebCore::Scrollbar::hoveredPart):
+ (WebCore::Scrollbar::theme):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::paint):
+ (WebCore::ScrollbarTheme::scrollbarThickness):
+ (WebCore::ScrollbarTheme::supportsControlTints):
+ (WebCore::ScrollbarTheme::themeChanged):
+ * platform/gtk/PlatformScrollBar.h:
+ * platform/gtk/PlatformScrollBarGtk.cpp:
+ * platform/mac/PlatformScrollBar.h:
+ * platform/mac/PlatformScrollBarMac.mm:
+ * platform/qt/PlatformScrollBar.h:
+ * platform/qt/PlatformScrollBarQt.cpp:
+ * platform/qt/ScrollbarThemeQt.cpp:
+ (WebCore::styleOptionSlider):
+ * platform/qt/ScrollbarThemeQt.h:
+ (WebCore::ScrollbarThemeQt::paint):
+ * platform/win/PlatformScrollBarSafari.cpp:
+ (WebCore::PlatformScrollbar::paint):
+ * platform/win/ScrollbarThemeSafari.h:
+ (WebCore::ScrollbarThemeSafari::supportsControlTints):
+ * platform/wx/PlatformScrollBar.h:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (PlatformScrollbar::~PlatformScrollbar):
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Qt build fix.
+
+ * platform/qt/PlatformScrollBarQt.cpp:
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Remove extraneous semicolons.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::tokenizeRelAttribute):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::charsetAttributeValue):
+ (WebCore::HTMLScriptElement::typeAttributeValue):
+ * platform/graphics/qt/GradientQt.cpp:
+ (WebCore::Gradient::platformGradient):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paintEllipsisBoxes):
+ * svg/SVGPathSegList.cpp:
+ (WebCore::SVGPathSegList::toPathData):
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Qt build fix.
+
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2008-09-14 Sam Weinig <sam@webkit.org>
+
+ Qt build fix.
+
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::PlatformScrollbar::paint):
+
+2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Gtk build fix, not reviewed.
+
+ * platform/gtk/PlatformScrollBarGtk.cpp:
+ (PlatformScrollbar::PlatformScrollbar):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+
+2008-09-13 Dave Hyatt <hyatt@apple.com>
+
+ Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
+ to set the dimensions of a scrollbar.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.h:
+ * platform/gtk/PlatformScrollBar.h:
+ * platform/gtk/PlatformScrollBarGtk.cpp:
+ (PlatformScrollbar::setFrameGeometry):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/mac/PlatformScrollBarMac.mm:
+ * platform/qt/PlatformScrollBarQt.cpp:
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::PlatformScrollbar::setFrameGeometry):
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::PlatformScrollbar::setFrameGeometry):
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupWndProc):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ * platform/wx/PlatformScrollBar.h:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (PlatformScrollbar::updateThumbProportion):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::positionOverflowControls):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintScrollbar):
+
+2008-09-13 Dave Hyatt <hyatt@apple.com>
+
+ Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.h:
+ * platform/gtk/PlatformScrollBar.h:
+ * platform/gtk/PlatformScrollBarGtk.cpp:
+ * platform/mac/PlatformScrollBar.h:
+ * platform/mac/PlatformScrollBarMac.mm:
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ * platform/win/PlatformScrollBarWin.cpp:
+ * platform/wx/PlatformScrollBar.h:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (PlatformScrollbar::~PlatformScrollbar):
+
+2008-09-13 Dave Hyatt <hyatt@apple.com>
+
+ Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
+ all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.h:
+ * platform/gtk/PlatformScrollBar.h:
+ * platform/gtk/PlatformScrollBarGtk.cpp:
+ * platform/mac/PlatformScrollBar.h:
+ * platform/mac/PlatformScrollBarMac.mm:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ * platform/win/PlatformScrollBarWin.cpp:
+ * platform/wx/PlatformScrollBar.h:
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (PlatformScrollbar::~PlatformScrollbar):
+
+2008-09-13 Dave Hyatt <hyatt@apple.com>
+
+ Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::~Scrollbar):
+ * platform/ScrollBar.h:
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::PlatformScrollbar::~PlatformScrollbar):
+ * platform/win/PlatformScrollBarSafari.cpp:
+ (WebCore::PlatformScrollbar::~PlatformScrollbar):
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::PlatformScrollbar::~PlatformScrollbar):
+
+2008-09-13 David Hyatt <hyatt@apple.com>
+
+ Move maximum() from Qt's PlatformScrollbar to be a cross-platform
+ function on Scrollbar. Fixes Qt build bustage.
+
+ Reviewed by Sam Weinig
+
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::orientation):
+ (WebCore::Scrollbar::value):
+ (WebCore::Scrollbar::maximum):
+ * platform/qt/PlatformScrollBar.h:
+
+2008-09-13 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - use the LastResort font for missing glyphs instead of showing the
+ primary font's missing glyph
+
+ Test: platform/mac/fast/text/last-resort-font.html
+
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::getFontDataForCharacters): Changed to return the
+ last resort font if a substitute font cannot be found.
+ (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
+ comment (the user's preferred standard font is included in the search
+ thanks to code in FontCache::getFontData()) and changed to return the
+ LastResort font.
+
+2008-09-13 Dave Hyatt <hyatt@apple.com>
+
+ This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
+ scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
+ patches will move rendering and hit testing functionality into this class.
+
+ Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
+ implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
+
+ Reviewed by Sam Weinig
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ * platform/ScrollBar.h:
+ * platform/ScrollbarTheme.h: Added.
+ (WebCore::ScrollbarTheme::~ScrollbarTheme):
+ (WebCore::ScrollbarTheme::scrollbarThickness):
+ (WebCore::ScrollbarTheme::themeChanged):
+ * platform/gtk/ScrollbarThemeGtk.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
+ (WebCore::ScrollbarThemeGtk::scrollbarThickness):
+ * platform/gtk/ScrollbarThemeGtk.h: Added.
+ * platform/mac/PlatformScrollBar.h:
+ * platform/mac/ScrollbarThemeMac.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::):
+ (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
+ (WebCore::ScrollbarThemeMac::scrollbarThickness):
+ * platform/mac/ScrollbarThemeMac.h: Added.
+ * platform/qt/PlatformScrollBarQt.cpp:
+ * platform/qt/ScrollbarThemeQt.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
+ (WebCore::ScrollbarThemeQt::scrollbarThickness):
+ * platform/qt/ScrollbarThemeQt.h: Added.
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ * platform/win/PlatformScrollBarWin.cpp:
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenu::calculatePositionAndSize):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::themeChanged):
+ * platform/win/ScrollbarThemeSafari.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::):
+ (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
+ (WebCore::ScrollbarThemeSafari::scrollbarThickness):
+ * platform/win/ScrollbarThemeSafari.h: Added.
+ * platform/win/ScrollbarThemeWin.cpp: Added.
+ (WebCore::ScrollbarTheme::nativeTheme):
+ (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
+ (WebCore::ScrollbarThemeWin::scrollbarThickness):
+ (WebCore::ScrollbarThemeWin::themeChanged):
+ * platform/win/ScrollbarThemeWin.h: Added.
+ * platform/wx/TemporaryLinkStubs.cpp:
+ (ScrollbarTheme::nativeTheme):
+ * rendering/RenderLayer.cpp:
+ (WebCore::scrollCornerRect):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::calcPrefWidths):
+
+2008-09-13 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2008-09-13 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
+
+ No regression test because the back/forward cache is disabled in DumpRenderTree
+
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::invalidateCounters): Bail out if the document
+ is being destroyed.
+
+2008-09-13 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes for new methods recently introduced.
+
+ * platform/graphics/wx/AffineTransformWx.cpp:
+ (WebCore::AffineTransform::AffineTransform):
+ (WebCore::AffineTransform::setMatrix):
+ (WebCore::AffineTransform::setA):
+ (WebCore::AffineTransform::setB):
+ (WebCore::AffineTransform::setC):
+ (WebCore::AffineTransform::setD):
+ (WebCore::AffineTransform::setE):
+ (WebCore::AffineTransform::setF):
+ * platform/wx/LocalizedStringsWx.cpp:
+ (WebCore::AXDefinitionListTermText):
+ (WebCore::AXDefinitionListDefinitionText):
+
+2008-09-12 Dave Hyatt <hyatt@apple.com>
+
+ Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
+ up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
+ "PlatformScrollbar."
+
+ Reviewed by Sam Weinig
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * editing/EditorCommand.cpp:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::selectCursor):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::handleMouseMoveEvent):
+ * page/EventHandler.h:
+ * page/MouseEventWithHitTestResults.cpp:
+ (WebCore::MouseEventWithHitTestResults::scrollbar):
+ * page/MouseEventWithHitTestResults.h:
+ * page/gtk/EventHandlerGtk.cpp:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * page/qt/EventHandlerQt.cpp:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * page/win/EventHandlerWin.cpp:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * page/wx/EventHandlerWx.cpp:
+ (WebCore::EventHandler::passMousePressEventToScrollbar):
+ * platform/PopupMenu.h:
+ * platform/ScrollBar.cpp:
+ (WebCore::Scrollbar::Scrollbar):
+ (WebCore::Scrollbar::autoscrollTimerFired):
+ (WebCore::Scrollbar::autoscrollPressedPart):
+ (WebCore::Scrollbar::startTimerIfNeeded):
+ (WebCore::Scrollbar::stopTimerIfNeeded):
+ (WebCore::Scrollbar::pressedPartScrollDirection):
+ (WebCore::Scrollbar::pressedPartScrollGranularity):
+ * platform/ScrollBar.h:
+ (WebCore::Scrollbar::handleMousePressEvent):
+ (WebCore::Scrollbar::invalidatePart):
+ (WebCore::Scrollbar::thumbUnderMouse):
+ * platform/ScrollView.h:
+ * platform/ScrollbarClient.h: Added.
+ (WebCore::ScrollbarClient::~ScrollbarClient):
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ * platform/qt/PlatformScrollBar.h:
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::scrollbarPart):
+ (WebCore::PlatformScrollbar::handleMouseMoveEvent):
+ (WebCore::PlatformScrollbar::handleMouseOutEvent):
+ (WebCore::PlatformScrollbar::handleMousePressEvent):
+ (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
+ * platform/qt/ScrollViewQt.cpp:
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ (WebCore::ScrollView::wheelEvent):
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBarSafari.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::scrollbarUnderMouse):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::setScrollbar):
+ * rendering/HitTestResult.h:
+ (WebCore::HitTestResult::scrollbar):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestOverflowControls):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.h:
+
+2008-09-12 Steve Falkenburg <sfalken@apple.com>
+
+ Fix Mac build.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::getTransformOperationType):
+
+2008-09-12 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Make transform animation behavior match spec
+ https://bugs.webkit.org/show_bug.cgi?id=20770
+
+ Tests: transitions/transform-op-list-match.html
+ transitions/transform-op-list-no-match.html
+
+ * css/CSSStyleSelector.cpp:
+ * css/CSSStyleSelector.h:
+ * page/animation/AnimationBase.cpp:
+ * page/animation/AnimationBase.h:
+ * page/animation/ImplicitAnimation.cpp:
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ * page/animation/KeyframeAnimation.h:
+ * rendering/RenderLayer.cpp:
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+
+2008-09-12 Ojan Vafai <ojan@chromium.org>
+
+ Properly escape contents of links added to the inspector.
+ For now, just build the link with the DOM and get the
+ outerHTML. Eventually, we probably just want to do
+ this entirely with the DOM.
+
+ Reviewed by Timothy Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20684
+
+ * manual-tests/inspector/escape-links.html: Added.
+ * page/inspector/StylesSidebarPane.js:
+ * page/inspector/inspector.js:
+ * page/inspector/utilities.js:
+
+2008-09-12 Adele Peterson <adele@apple.com>
+
+ Reviewed by John Sullivan and Kevin McCullough.
+
+ Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
+
+ * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
+ Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
+ cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
+
+2008-09-12 Kevin McCullough <kmccullough@apple.com>
+
+ RS by Tim .
+
+ Re-introducing the code since it was not the cause of the crash.
+ See r36343.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::canBeProgramaticallyScrolled):
+ * rendering/RenderObject.h:
+
+2008-09-12 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ When changing one animation in a list, don't reset other animations
+ https://bugs.webkit.org/show_bug.cgi?id=20675
+
+ Test: animations/change-one-anim.html
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::getNumProperties):
+ * page/animation/AnimationBase.h:
+ * page/animation/AnimationController.cpp:
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ * page/animation/KeyframeAnimation.cpp:
+ * page/animation/KeyframeAnimation.h:
+ (WebCore::KeyframeAnimation::setIndex):
+
+2008-09-12 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Mitz Pettel
+
+ Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
+ Subresources can never be created from nil data, but there is always a MainResource, whether
+ or not there's any data. So in the case where the main resource has no data, fake it for the
+ sake of creating the ArchiveResource.
+
+2008-09-12 Dave Hyatt <hyatt@apple.com>
+
+ Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
+ scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
+ Remove all the isWidget and hasPlatformScrollbars guards.
+
+ Reviewed by Tim Hatcher
+
+ * platform/ScrollBar.h:
+ * platform/gtk/PlatformScrollBar.h:
+ * platform/mac/PlatformScrollBar.h:
+ * platform/qt/PlatformScrollBar.h:
+ * platform/win/PlatformScrollBar.h:
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
+ (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
+ * platform/wx/PlatformScrollBar.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::horizontalScrollbarWidget):
+ (WebCore::RenderLayer::verticalScrollbarWidget):
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::destroyScrollbar):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::~RenderListBox):
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::isPointInOverflowControl):
+
+2008-09-12 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
+
+ * page/animation/AnimationController.cpp:
+ * page/animation/AnimationController.h:
+ * page/animation/CompositeAnimation.cpp:
+ * page/animation/CompositeAnimation.h:
+ * page/animation/ImplicitAnimation.cpp:
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ * page/animation/KeyframeAnimation.h:
+
+2008-09-11 Timothy Hatcher <timothy@apple.com>
+
+ Add a renderedImage method to DOMNode to get an image
+ of the rendering for the node and it's descendants.
+
+ <rdar://problem/5849349> Would like API to create
+ an image for a DOM node
+
+ Reviewed by Oliver Hunt.
+
+ * bindings/objc/DOM.mm:
+ (-[DOMNode renderedImage]): Call Frame::nodeImage.
+ * bindings/objc/DOMPrivate.h:
+ * page/Frame.h:
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::nodeImage):
+
+2008-09-08 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Need to support comma separated list of key times in keyframes selectors
+ https://bugs.webkit.org/show_bug.cgi?id=20680
+
+ Test: animations/keyframes-comma-separated.html
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::createKeyframeRule):
+ * css/CSSParser.h:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::addKeyframeStyle):
+ * css/WebKitCSSKeyframeRule.cpp:
+ (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
+ (WebCore::WebKitCSSKeyframeRule::cssText):
+ (WebCore::WebKitCSSKeyframeRule::parseKeyString):
+ * css/WebKitCSSKeyframeRule.h:
+ (WebCore::WebKitCSSKeyframeRule::keyText):
+ (WebCore::WebKitCSSKeyframeRule::setKeyText):
+ (WebCore::WebKitCSSKeyframeRule::getKeys):
+ * css/WebKitCSSKeyframesRule.cpp:
+ (WebCore::WebKitCSSKeyframesRule::append):
+ (WebCore::WebKitCSSKeyframesRule::insertRule):
+ (WebCore::WebKitCSSKeyframesRule::deleteRule):
+ (WebCore::WebKitCSSKeyframesRule::findRule):
+ (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
+ * css/WebKitCSSKeyframesRule.h:
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::blendProperties):
+
+2008-09-11 Kevin McCullough <kmccullough@apple.com>
+
+ RS by Tim.
+
+ Reverting because this caused a crash.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::canBeProgramaticallyScrolled):
+ (WebCore::RenderObject::hasScrollableView):
+ * rendering/RenderObject.h:
+
+2008-09-11 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix assertion on transition property "none"
+ https://bugs.webkit.org/show_bug.cgi?id=20751
+
+ Test: transitions/transition-end-event-set-none.html
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateTransitions):
+
+2008-09-11 David Smith <catfish.man@gmail.com>
+
+ Rubber-stamped by mitzpettel.
+
+ Remove an accidentally added extra file.
+
+ * WebCore: Removed.
+
+2008-09-11 David Smith <catfish.man@gmail.com>
+
+ Reviewed by Darin
+
+ https://bugs.webkit.org/show_bug.cgi?id=20180
+
+ This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
+
+ * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
+ * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
+ * dom/Element.cpp: include NodeRenderStyle.h
+ * dom/Node.cpp: Remove the definition of renderStyle()
+ (WebCore::Node::nonRendererRenderStyle):
+ * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
+ * dom/NodeRenderStyle.h: Added.
+ (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
+ * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
+ * html/HTMLOptGroupElement.h:
+ (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
+ * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
+ * html/HTMLOptionElement.h:
+ (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
+ * rendering/RenderListBox.cpp: include NodeRenderStyle.h
+ * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
+ * svg/SVGUseElement.cpp: include NodeRenderStyle.h
+
+2008-09-11 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Adele and Tim.
+
+ <rdar://problem/6100597> REGRESSION: clicking on search results in Web
+ Inspector does not scroll to the line of the results (20167)
+ - This was put in by Max to fix auto scrolling but is not correct for
+ the whole web: rdar://problem/6213098
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::canBeProgramaticallyScrolled):
+ * rendering/RenderObject.h:
+
+2008-09-11 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin
+
+ <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
+
+ Test: accessibility/frame-with-title.html
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityDescription):
+
+2008-09-11 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Simon.
+
+ Fixed stroke() and strokeRect() to support gradients
+ and patterns on Qt.
+
+ [Qt] Canvas stroke don't work for gradients and patterns
+ [https://bugs.webkit.org/show_bug.cgi?id=20749]
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+
+2008-09-11 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Simon.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20729
+
+ Fixed canvas gradients for Qt
+
+ [Qt] Canvas gradients don't work as expected
+ [https://bugs.webkit.org/show_bug.cgi?id=20729]
+
+ * platform/graphics/qt/GradientQt.cpp:
+ (WebCore::Gradient::platformGradient):
+
+2008-09-11 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Simon.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20568
+
+ Add support for patterns to Qt.
+
+ * platform/graphics/qt/PatternQt.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+
+2008-09-10 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - clean up AnimationBase
+
+ * page/animation/AnimationBase.cpp:
+ * page/animation/AnimationBase.h:
+ * page/animation/CompositeAnimation.cpp:
+ * page/animation/ImplicitAnimation.cpp:
+ * page/animation/ImplicitAnimation.h:
+ * page/animation/KeyframeAnimation.cpp:
+ * page/animation/KeyframeAnimation.h:
+
+2008-09-10 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20741
+ REGRESSION: ISO-8859-8-I encoding is registered incorrectly
+
+ Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
+ check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
+ tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
+
+ I also found and fixed a potential crasher for non-Mac ports.
+
+ Tests: fast/encoding/hebrew/8859-8-e.html
+ fast/encoding/hebrew/8859-8-i.html
+ fast/encoding/hebrew/8859-8.html
+ fast/encoding/hebrew/csISO88598I.html
+ fast/encoding/hebrew/hebrew.html
+ fast/encoding/hebrew/iso-ir-138.html
+ fast/encoding/hebrew/logical.html
+
+ * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
+ (case-insensitively, because different versions of ICU report this MIME name in different
+ case).
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
+ (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
+ There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
+ with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
+ we also support these via TEC (which we should stop doing), but on Windows, this would
+ likely crash.
+
+2008-09-09 Dave Hyatt <hyatt@apple.com
+
+ Resurrect PlatformScrollbarWin.
+
+ Reviewed by Adam Roben
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * platform/win/PlatformScrollBarWin.cpp:
+ (WebCore::isRunningOnVistaOrLater):
+ (WebCore::checkAndInitScrollbarTheme):
+ (WebCore::PlatformScrollbar::PlatformScrollbar):
+ (WebCore::PlatformScrollbar::invalidateTrack):
+ (WebCore::PlatformScrollbar::invalidatePart):
+ (WebCore::PlatformScrollbar::paint):
+ (WebCore::PlatformScrollbar::hasButtons):
+ (WebCore::PlatformScrollbar::hasThumb):
+ (WebCore::PlatformScrollbar::backButtonRect):
+ (WebCore::PlatformScrollbar::forwardButtonRect):
+ (WebCore::PlatformScrollbar::trackRect):
+ (WebCore::PlatformScrollbar::gripperRect):
+ (WebCore::PlatformScrollbar::thumbLength):
+ (WebCore::PlatformScrollbar::paintButton):
+ (WebCore::PlatformScrollbar::paintTrack):
+ (WebCore::PlatformScrollbar::paintThumb):
+ (WebCore::PlatformScrollbar::paintGripper):
+ (WebCore::PlatformScrollbar::hitTest):
+ (WebCore::PlatformScrollbar::handleMouseMoveEvent):
+ (WebCore::PlatformScrollbar::handleMouseOutEvent):
+ (WebCore::PlatformScrollbar::themeChanged):
+
+2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20759: Remove MacroAssembler
+ <https://bugs.webkit.org/show_bug.cgi?id=20759>
+
+ Make the necessary changes to ForwardingHeaders to remove
+ MacroAssembler.
+
+ * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
+ * ForwardingHeaders/masm/MacroAssembler.h: Removed.
+ * ForwardingHeaders/masm/X86Assembler.h: Added.
+
+2008-09-09 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=16792
+ [GTK] Fails to render Japanese/Chinese text with simple path
+
+ https://bugs.webkit.org/show_bug.cgi?id=16942
+ [GTK] Oddities in font selection and fall back
+
+ https://bugs.webkit.org/show_bug.cgi?id=16862
+ [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
+
+ GTK+ font fixes and enhancements.
+
+ Implement font fallback for the simple FontConfig-based text path and
+ improve the Pango-based complex text path to make use of requested
+ font properties and available font selection.
+
+ Add text shadow support to the complex path.
+
+ * platform/graphics/gtk/FontCacheGtk.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ * platform/graphics/gtk/FontGtk.cpp:
+ (WebCore::setPangoAttributes):
+ (WebCore::Font::drawComplexText):
+ (WebCore::getDefaultPangoLayout):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ * platform/graphics/gtk/FontPlatformData.h:
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::hash):
+ * platform/graphics/gtk/FontPlatformDataGtk.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ * platform/graphics/gtk/SimpleFontDataGtk.cpp:
+ (WebCore::SimpleFontData::platformDestroy):
+
+2008-09-09 Dave Hyatt <hyatt@apple.com>
+
+ Make the Windows classic case work again. Overlap in slider constants and other constants broke
+ the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
+ value to make sure it's really a slider thumb to resolve this conflict.
+
+ Reviewed by Adam Roben
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::drawControl):
+
+2008-09-05 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Need to handle the case when 0% or 100% keyframe is omitted
+ https://bugs.webkit.org/show_bug.cgi?id=20679
+
+ Tests: animations/keyframes-from-missing.html
+ animations/keyframes-to-missing.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::addKeyframeStyle):
+
+2008-09-09 Dave Hyatt <hyatt@apple.com>
+
+ Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
+ RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
+ merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
+ what changes have been made as compared with the old RenderThemeWin).
+
+ Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
+ text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
+ vs. printer advancement rounding).
+
+ Reviewed by Adam/Sam
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * platform/graphics/Icon.h:
+ (WebCore::Icon::create):
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::RenderThemeWin):
+ (WebCore::RenderThemeWin::~RenderThemeWin):
+ (WebCore::RenderThemeWin::buttonTheme):
+ (WebCore::RenderThemeWin::textFieldTheme):
+ (WebCore::RenderThemeWin::menuListTheme):
+ (WebCore::RenderThemeWin::sliderTheme):
+ (WebCore::RenderThemeWin::close):
+ (WebCore::RenderThemeWin::themeChanged):
+ (WebCore::RenderThemeWin::supportsHover):
+ (WebCore::fillFontDescription):
+ (WebCore::RenderThemeWin::systemFont):
+ (WebCore::RenderThemeWin::supportsFocus):
+ (WebCore::RenderThemeWin::determineClassicState):
+ (WebCore::RenderThemeWin::determineState):
+ (WebCore::RenderThemeWin::determineSliderThumbState):
+ (WebCore::RenderThemeWin::getClassicThemeData):
+ (WebCore::RenderThemeWin::getThemeData):
+ (WebCore::drawControl):
+ (WebCore::RenderThemeWin::paintButton):
+ (WebCore::RenderThemeWin::paintTextField):
+ (WebCore::RenderThemeWin::paintMenuList):
+ (WebCore::RenderThemeWin::adjustMenuListStyle):
+ (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
+ (WebCore::RenderThemeWin::paintMenuListButton):
+ (WebCore::RenderThemeWin::paintSliderTrack):
+ (WebCore::RenderThemeWin::paintSliderThumb):
+ (WebCore::RenderThemeWin::adjustSliderThumbSize):
+ (WebCore::RenderThemeWin::paintSearchField):
+ (WebCore::RenderThemeWin::adjustSearchFieldStyle):
+ (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
+ (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
+ (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
+ (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
+ * rendering/RenderThemeWin.h:
+ (WebCore::ThemeData::ThemeData):
+ (WebCore::RenderThemeWin::paintSearchFieldDecoration):
+ (WebCore::RenderThemeWin::adjustButtonStyle):
+ (WebCore::RenderThemeWin::adjustTextFieldStyle):
+ (WebCore::RenderThemeWin::adjustTextAreaStyle):
+
+2008-09-09 Dean Jackson <dino@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Document::createEvent missing cases for animation and
+ transition events.
+ https://bugs.webkit.org/show_bug.cgi?id=20734
+
+ Test: transitions/transition-end-event-create.html
+ Test: animations/animation-events-create.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::createEvent):
+ - add the two cases
+
+2008-09-09 Dan Bernstein <mitz@apple.com>
+
+ - Tiger build fix
+
+ * WebCore.Tiger.exp:
+ * WebCore.base.exp:
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm:
+
+2008-09-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
+
+ * WebCore.Tiger.exp:
+ * WebCore.base.exp:
+ * platform/graphics/SimpleFontData.h:
+ * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
+ (WebCore::GlyphPage::fill):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::initFontData):
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ * platform/mac/WebCoreSystemInterface.h:
+ * platform/mac/WebCoreSystemInterface.mm:
+
+2008-09-09 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
+ breakpoints inside eval.
+
+ * page/inspector/inspector.js:
+
+2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compilation of the Qt port with disabled plugins on Windows
+
+ * WebCore.pro:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::PluginView):
+ * plugins/PluginView.h:
+
+2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Try MIME charset names before trying IANA names
+ ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
+
+ With this change, shorter and more widely used names (preferred MIME
+ names) are returned by document.charset, document.characterSet,
+ document.inputEncoding rather than IANA names. This helps
+ fixing bug 18085 in addition to web developers who are more familiar
+ with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
+ returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
+ ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
+ Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
+ used, the former is still recognized as aliases to the latter so that
+ there's very little, if any, to worry about.
+
+ * platform/text/TextCodecICU.cpp:
+ (WebCore::TextCodecICU::registerExtendedEncodingNames):
+
+2008-09-08 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak and Oliver Hunt.
+
+ Add forwarding headers.
+
+ * ForwardingHeaders/wtf/HashFunctions.h: Added.
+
+2008-09-05 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Update grammar so that we can add a keyframe rule via the DOM.
+ https://bugs.webkit.org/show_bug.cgi?id=20613
+
+ * css/CSSGrammar.y:
+ * css/tokenizer.flex:
+
+2008-09-08 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Allow <br> for simple UA stylesheet. Editing code generates them. It does not
+ actually show up in any of the default stylesheets.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::elementCanUseSimpleDefaultStyle):
+
+2008-09-08 Dimitri Glazkov <dglazkov@google.com>
+
+ Reviewed by Dan Bernstein.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=20237
+ Zero width and space characters are displayed incorrectly if not contained in a fallback font
+
+ Adds an extra check for Object Replacement Character (U+FFFC) to address
+ the issue with fast/text/zero-width-characters.html test when run
+ with Windows system default fonts.
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::treatAsZeroWidthSpace):
+
+2008-09-08 Dean Jackson <dino@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Code style issue I forgot to fix from previous commit.
+
+ * platform/graphics/AffineTransform.cpp:
+ (WebCore::AffineTransform::blend):
+
+2008-09-08 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Sam Weinig
+
+ - Animation of -webkit-transform matrix() function should not do linear interpolation
+ https://bugs.webkit.org/show_bug.cgi?id=20667
+
+ Test: animations/matrix-anim.html
+
+ * ChangeLog:
+ * platform/graphics/AffineTransform.cpp:
+ (WebCore::affineTransformDecompose):
+ (WebCore::affineTransformCompose):
+ (WebCore::AffineTransform::blend):
+ * platform/graphics/AffineTransform.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::MatrixTransformOperation::blend):
+
+2008-09-08 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20668
+ multipart/form-data does not always include Content-type for submitted files
+
+ Cannot be tested with DRT or manual tests.
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
+ (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
+ unknown extensions, not just missing ones.
+
+2008-09-08 Simon Hausmann <hausmann@webkit.org>
+
+ Build fix for the Qt/Windows build, define USE_JSC to
+ enable the WebCore::String -> JSC::UString operator that
+ MSVC insists on seeing
+
+ * WebCore.pro:
+
+2008-09-08 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Maciej.
+
+ <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
+
+ In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
+ page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
+
+ Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
+
+ * bindings/js/JSDOMWindowBase.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::commitProvisionalLoad):
+
+2008-09-07 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Don't leak the simple stylesheet.
+ Also call RenderTheme::adjustDefaultStyleSheet() in right place.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::loadFullDefaultStyle):
+ (WebCore::loadSimpleDefaultStyle):
+ (WebCore::CSSStyleSelector::styleForElement):
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Oliver Hunt.
+
+ Bug 20711: Change KJS prefix on preprocessor macros to JSC
+ <https://bugs.webkit.org/show_bug.cgi?id=20711>
+
+ * bindings/js/JSEventTargetBase.h:
+ * bindings/js/JSHTMLInputElementBase.cpp:
+ * bindings/js/JSHTMLInputElementBase.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Reviewed by Maciej Stachowiak.
+
+ Bug 20704: Replace the KJS namespace
+ <https://bugs.webkit.org/show_bug.cgi?id=20704>
+
+ Rename the KJS namespace to JSC. There are still some uses of KJS in the
+ names of JNI functions, and I will check if these are safe to change
+ as well.
+
+ * WebCore.base.exp:
+ * bindings/js/GCController.cpp:
+ * bindings/js/JSAttrCustom.cpp:
+ * bindings/js/JSAudioConstructor.cpp:
+ * bindings/js/JSAudioConstructor.h:
+ (WebCore::JSAudioConstructor::classInfo):
+ * bindings/js/JSCSSRuleCustom.cpp:
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp:
+ * bindings/js/JSCSSValueCustom.cpp:
+ * bindings/js/JSCanvasPixelArrayCustom.cpp:
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ * bindings/js/JSClipboardCustom.cpp:
+ * bindings/js/JSConsoleCustom.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementCallback.h:
+ (WebCore::JSCustomSQLStatementCallback::create):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.h:
+ (WebCore::JSCustomSQLStatementErrorCallback::create):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.h:
+ (WebCore::JSCustomSQLTransactionCallback::create):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h:
+ (WebCore::JSCustomSQLTransactionErrorCallback::create):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.h:
+ (WebCore::JSCustomVoidCallback::create):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::create):
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ (WebCore::JSDOMApplicationCache::dispatchEvent):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::jsOwnedStringOrNull):
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::DOMObject::DOMObject):
+ (WebCore::cacheDOMObject):
+ (WebCore::cacheSVGDOMObject):
+ (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
+ (WebCore::toJS):
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ (WebCore::JSDOMWindowBase::classInfo):
+ (WebCore::JSDOMWindowBase::d):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::getPropertyAttributes):
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::asJSDOMWindow):
+ (WebCore::JSDOMWindow::customGetOwnPropertySlot):
+ (WebCore::JSDOMWindow::customPut):
+ (WebCore::JSDOMWindowBase::allowsAccessFrom):
+ (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::getPropertyAttributes):
+ * bindings/js/JSDOMWindowShell.h:
+ (WebCore::JSDOMWindowShell::classInfo):
+ * bindings/js/JSDatabaseCustom.cpp:
+ * bindings/js/JSDocumentCustom.cpp:
+ * bindings/js/JSDocumentFragmentCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/js/JSEventCustom.cpp:
+ * bindings/js/JSEventListener.cpp:
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSUnprotectedEventListener::create):
+ (WebCore::JSEventListener::create):
+ * bindings/js/JSEventTargetBase.cpp:
+ * bindings/js/JSEventTargetBase.h:
+ (WebCore::JSEventTargetBase::getValueProperty):
+ (WebCore::JSEventTargetBase::putValueProperty):
+ (WebCore::JSEventTargetBase::getOwnPropertySlot):
+ (WebCore::JSEventTargetBase::put):
+ (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
+ (WebCore::JSEventTargetPrototype::self):
+ (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
+ (WebCore::JSEventTargetPrototype::classInfo):
+ * bindings/js/JSEventTargetNode.cpp:
+ * bindings/js/JSEventTargetNode.h:
+ (WebCore::JSEventTargetNode::getOwnPropertySlot):
+ (WebCore::JSEventTargetNode::getValueProperty):
+ (WebCore::JSEventTargetNode::put):
+ (WebCore::JSEventTargetNode::putValueProperty):
+ * bindings/js/JSHTMLAllCollection.h:
+ (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
+ (WebCore::JSHTMLAllCollection::toBoolean):
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ * bindings/js/JSHTMLCollectionCustom.cpp:
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ * bindings/js/JSHTMLElementCustom.cpp:
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ * bindings/js/JSHTMLFrameSetElementCustom.cpp:
+ * bindings/js/JSHTMLIFrameElementCustom.cpp:
+ * bindings/js/JSHTMLInputElementBase.cpp:
+ (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
+ (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
+ * bindings/js/JSHTMLInputElementBase.h:
+ (WebCore::JSHTMLInputElementBase::classInfo):
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ * bindings/js/JSHTMLOptionElementConstructor.cpp:
+ * bindings/js/JSHTMLOptionElementConstructor.h:
+ (WebCore::JSHTMLOptionElementConstructor::classInfo):
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ * bindings/js/JSHTMLSelectElementCustom.cpp:
+ (WebCore::selectIndexSetter):
+ (WebCore::JSHTMLSelectElement::indexSetter):
+ * bindings/js/JSHTMLSelectElementCustom.h:
+ * bindings/js/JSHistoryCustom.cpp:
+ * bindings/js/JSImageConstructor.cpp:
+ * bindings/js/JSImageConstructor.h:
+ (WebCore::JSImageConstructor::classInfo):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ * bindings/js/JSInspectedObjectWrapper.h:
+ (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
+ (WebCore::JSInspectedObjectWrapper::classInfo):
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ (WebCore::JSInspectorCallbackWrapper::classInfo):
+ (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ * bindings/js/JSLocationCustom.cpp:
+ * bindings/js/JSMimeTypeArrayCustom.cpp:
+ * bindings/js/JSNSResolver.cpp:
+ * bindings/js/JSNSResolver.h:
+ (WebCore::JSNSResolver::create):
+ * bindings/js/JSNamedNodeMapCustom.cpp:
+ * bindings/js/JSNamedNodesCollection.cpp:
+ (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
+ * bindings/js/JSNamedNodesCollection.h:
+ (WebCore::JSNamedNodesCollection::classInfo):
+ * bindings/js/JSNavigatorCustom.cpp:
+ * bindings/js/JSNodeCustom.cpp:
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/JSNodeFilterCondition.h:
+ (WebCore::JSNodeFilterCondition::create):
+ * bindings/js/JSNodeFilterCustom.cpp:
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ * bindings/js/JSNodeListCustom.cpp:
+ * bindings/js/JSPluginArrayCustom.cpp:
+ * bindings/js/JSPluginCustom.cpp:
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::getRuntimeObject):
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::construct):
+ (WebCore::JSQuarantinedObjectWrapper::call):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
+ (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
+ (WebCore::JSQuarantinedObjectWrapper::className):
+ * bindings/js/JSRGBColor.cpp:
+ * bindings/js/JSRGBColor.h:
+ (WebCore::JSRGBColor::classInfo):
+ * bindings/js/JSSQLResultSetRowListCustom.cpp:
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ * bindings/js/JSSVGLazyEventListener.cpp:
+ * bindings/js/JSSVGLazyEventListener.h:
+ * bindings/js/JSSVGLengthCustom.cpp:
+ * bindings/js/JSSVGMatrixCustom.cpp:
+ (WebCore::JSSVGMatrix::inverse):
+ (WebCore::JSSVGMatrix::rotateFromVector):
+ * bindings/js/JSSVGPathSegCustom.cpp:
+ * bindings/js/JSSVGPathSegListCustom.cpp:
+ (WebCore::JSSVGPathSegList::initialize):
+ (WebCore::JSSVGPathSegList::getItem):
+ (WebCore::JSSVGPathSegList::insertItemBefore):
+ (WebCore::JSSVGPathSegList::replaceItem):
+ (WebCore::JSSVGPathSegList::removeItem):
+ (WebCore::JSSVGPathSegList::appendItem):
+ * bindings/js/JSSVGPointListCustom.cpp:
+ * bindings/js/JSSVGTransformListCustom.cpp:
+ * bindings/js/JSStorageCustom.cpp:
+ * bindings/js/JSStyleSheetCustom.cpp:
+ * bindings/js/JSStyleSheetListCustom.cpp:
+ * bindings/js/JSTextCustom.cpp:
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ * bindings/js/JSXMLHttpRequestConstructor.cpp:
+ * bindings/js/JSXMLHttpRequestConstructor.h:
+ (WebCore::JSXMLHttpRequestConstructor::classInfo):
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ * bindings/js/JSXSLTProcessorConstructor.cpp:
+ * bindings/js/JSXSLTProcessorConstructor.h:
+ (WebCore::JSXSLTProcessorConstructor::classInfo):
+ * bindings/js/JSXSLTProcessorCustom.cpp:
+ * bindings/js/ScheduledAction.cpp:
+ * bindings/js/ScheduledAction.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::attachDebugger):
+ (WebCore::ScriptController::windowScriptNPObject):
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptControllerGtk.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ (WebCore::ScriptController::windowScriptObject):
+ (WebCore::ScriptController::clearPlatformScriptObjects):
+ (WebCore::updateRenderingForBindings):
+ (WebCore::ScriptController::initJavaJSBindings):
+ * bindings/js/ScriptControllerQt.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/js/ScriptControllerWin.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/js/ScriptControllerWx.cpp:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/js/StringSourceProvider.h:
+ (WebCore::StringSourceProvider::getRange):
+ * bindings/objc/DOM.mm:
+ (-[DOMNode JSC::Bindings::]):
+ * bindings/objc/DOMInternal.h:
+ * bindings/objc/DOMInternal.mm:
+ (-[WebScriptObject _initializeScriptDOMNodeImp]):
+ * bindings/objc/DOMUtility.mm:
+ (JSC::createDOMWrapper):
+ (WebCore::createDOMWrapper):
+ * bindings/objc/WebScriptObject.mm:
+ (WebCore::createJSWrapper):
+ (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
+ * bindings/objc/WebScriptObjectPrivate.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ * bridge/NP_jsobject.h:
+ * bridge/c/c_class.cpp:
+ * bridge/c/c_class.h:
+ * bridge/c/c_instance.cpp:
+ * bridge/c/c_instance.h:
+ * bridge/c/c_runtime.cpp:
+ * bridge/c/c_runtime.h:
+ * bridge/c/c_utility.cpp:
+ * bridge/c/c_utility.h:
+ * bridge/jni/jni_class.cpp:
+ * bridge/jni/jni_class.h:
+ * bridge/jni/jni_instance.cpp:
+ * bridge/jni/jni_instance.h:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::convertJObjectToValue):
+ * bridge/jni/jni_objc.mm:
+ (JSC::Bindings::dispatchJNICall):
+ * bridge/jni/jni_runtime.cpp:
+ * bridge/jni/jni_runtime.h:
+ * bridge/jni/jni_utility.cpp:
+ * bridge/jni/jni_utility.h:
+ * bridge/npruntime.cpp:
+ (_NPN_GetStringIdentifier):
+ * bridge/objc/WebScriptObject.h:
+ * bridge/objc/objc_class.h:
+ * bridge/objc/objc_class.mm:
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ * bridge/objc/objc_utility.h:
+ * bridge/objc/objc_utility.mm:
+ * bridge/qt/qt_class.cpp:
+ * bridge/qt/qt_class.h:
+ * bridge/qt/qt_instance.cpp:
+ * bridge/qt/qt_instance.h:
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertQVariantToValue):
+ (JSC::Bindings::):
+ * bridge/qt/qt_runtime.h:
+ * bridge/runtime.cpp:
+ * bridge/runtime.h:
+ * bridge/runtime_array.cpp:
+ * bridge/runtime_array.h:
+ * bridge/runtime_method.cpp:
+ * bridge/runtime_method.h:
+ * bridge/runtime_object.cpp:
+ * bridge/runtime_object.h:
+ * bridge/runtime_root.cpp:
+ (JSC::Bindings::RootObject::invalidate):
+ (JSC::Bindings::RootObject::gcProtect):
+ (JSC::Bindings::RootObject::gcUnprotect):
+ * bridge/runtime_root.h:
+ * bridge/testbindings.cpp:
+ * bridge/testbindings.mm:
+ * bridge/testqtbindings.cpp:
+ * dom/Document.cpp:
+ (WebCore::Document::~Document):
+ * dom/NSResolver.h:
+ * dom/Node.cpp:
+ (WebCore::Node::setDocument):
+ (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
+ (WebCore::resolveNamespacesForSelector):
+ (WebCore::Node::querySelector):
+ (WebCore::Node::querySelectorAll):
+ * dom/Node.h:
+ * dom/NodeFilter.cpp:
+ * dom/NodeFilter.h:
+ * dom/NodeFilterCondition.cpp:
+ * dom/NodeFilterCondition.h:
+ * dom/NodeIterator.cpp:
+ * dom/NodeIterator.h:
+ * dom/Traversal.cpp:
+ * dom/Traversal.h:
+ * dom/TreeWalker.cpp:
+ * dom/TreeWalker.h:
+ * dom/make_names.pl:
+ * history/CachedPage.cpp:
+ * history/CachedPage.h:
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::getInstance):
+ * html/HTMLPlugInElement.h:
+ * loader/FrameLoader.cpp:
+ * loader/FrameLoader.h:
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::iconDatabase):
+ * page/Console.cpp:
+ * page/Console.h:
+ * page/InspectorController.cpp:
+ (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
+ (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
+ (WebCore::InspectorResource::setXMLHttpRequestProperties):
+ (WebCore::InspectorResource::sourceString):
+ (WebCore::getResourceDocumentNode):
+ (WebCore::search):
+ (WebCore::InspectorController::focusNode):
+ (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
+ (WebCore::InspectorController::addDatabaseScriptResource):
+ (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
+ * page/InspectorController.h:
+ (WebCore::InspectorController::profiles):
+ * page/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::scopeChain):
+ * page/JavaScriptCallFrame.h:
+ (WebCore::JavaScriptCallFrame::create):
+ (WebCore::JavaScriptCallFrame::update):
+ * page/JavaScriptDebugListener.h:
+ * page/JavaScriptDebugServer.cpp:
+ (WebCore::dispatchDidParseSource):
+ * page/JavaScriptDebugServer.h:
+ * page/JavaScriptProfile.cpp:
+ * page/JavaScriptProfile.h:
+ * page/JavaScriptProfileNode.cpp:
+ (WebCore::getTotalTime):
+ (WebCore::getSelfTime):
+ (WebCore::getTotalPercent):
+ (WebCore::getSelfPercent):
+ (WebCore::getNumberOfCalls):
+ (WebCore::getChildren):
+ (WebCore::getVisible):
+ * page/JavaScriptProfileNode.h:
+ * page/Page.cpp:
+ (WebCore::Page::setDebuggerForAllPages):
+ (WebCore::Page::setDebugger):
+ * page/Page.h:
+ (WebCore::Page::debugger):
+ * page/mac/FrameMac.mm:
+ * platform/KURL.h:
+ (WebCore::KURL::operator JSC::UString):
+ * platform/text/AtomicString.cpp:
+ (WebCore::AtomicString::add):
+ (WebCore::AtomicString::find):
+ * platform/text/AtomicString.h:
+ (WebCore::AtomicString::AtomicString):
+ * platform/text/PlatformString.h:
+ * platform/text/String.cpp:
+ (WebCore::charactersToDouble):
+ * platform/win/BString.cpp:
+ * platform/win/BString.h:
+ * plugins/MimeTypeArray.h:
+ * plugins/Plugin.h:
+ * plugins/PluginArray.h:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::start):
+ (WebCore::PluginView::performRequest):
+ (WebCore::PluginView::bindingInstance):
+ * plugins/PluginView.h:
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::init):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::init):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::dispatchNPEvent):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ * storage/Database.cpp:
+ (WebCore::Database::Database):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::responseText):
+ (WebCore::XMLHttpRequest::loadRequestAsynchronously):
+ (WebCore::XMLHttpRequest::clearResponse):
+ (WebCore::XMLHttpRequest::dropProtection):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ (WebCore::XMLHttpRequest::didReceiveData):
+ * xml/XMLHttpRequest.h:
+
+2008-09-07 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Adopt opener restriction on frame navigation.
+ https://bugs.webkit.org/show_bug.cgi?id=20642
+
+ This restriction helps prevent an attacker from navigating top-level
+ windows that were created by another web site.
+
+ Tests: http/tests/security/frameNavigation/not-opener.html
+ http/tests/security/frameNavigation/opener.html
+
+ * loader/FrameLoader.cpp:
+ (WebCore::canAccessAncestor):
+ (WebCore::FrameLoader::shouldAllowNavigation):
+
+2008-09-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - use the correct sign for vertical offsets of combining marks
+
+ * platform/graphics/win/UniscribeController.cpp:
+ (WebCore::UniscribeController::shapeAndPlaceItem):
+
+2008-09-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - add the combining mark offsets in two places where I forgot them
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::Font::drawGlyphs):
+
+2008-09-07 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - correct glyph advances in complex text using web fonts rendered with
+ Core Graphics
+
+ * platform/graphics/win/FontCustomPlatformData.cpp:
+ (WebCore::FontCustomPlatformData::fontPlatformData):
+
+2008-09-07 Keishi Hattori <casey.hattori@gmail.com>
+
+ Adds console.dirxml support to the Web Inspector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19156
+
+ Reviewed by Timothy Hatcher.
+
+ * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::dirxml):
+ * page/Console.cpp:
+ (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
+ * page/Console.h:
+ (WebCore::): Added NodeMessageLevel.
+ * page/Console.idl: Added console.dirxml.
+ * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
+ * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
+ in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
+ * page/inspector/ElementsTreeOutline.js: Added.
+ (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
+ (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
+ * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
+ * page/inspector/inspector.css:
+ * page/inspector/inspector.html: Added ElementsTreeOutline.js.
+ * page/inspector/inspector.js: Moved hover related methods to WebInspector.
+ (WebInspector.altKeyDown):
+ (WebInspector.forceHoverHighlight):
+ (WebInspector.hoveredDOMNode):
+ (WebInspector._updateHoverHighlightSoon):
+ (WebInspector._updateHoverHighlight):
+ (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
+ (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
+ * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
+ isAncestorIncludingParentFrames.
+
+2008-09-06 Mark Rowe <mrowe@apple.com>
+
+ Qt build fix.
+
+ * bridge/qt/qt_runtime.cpp:
+ (KJS::Bindings::convertQVariantToValue):
+
+=== End merge of squirrelfish-extreme ===
+
+2008-09-05 Oliver Hunt <oliver@apple.com>
+
+ Start bringing up SFX on windows.
+
+ Reviewed by Mark Rowe and Sam Weinig
+
+ Start doing the work to bring up SFX on windows. Initially
+ just working on WREC, as it does not make any calls so reduces
+ the amount of code that needs to be corrected.
+
+ Add forwarding headers
+
+ * ChangeLog:
+ * ForwardingHeaders/masm/MacroAssembler.h: Added.
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-08-27 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Fix the build of the full WebKit stack.
+
+ Add forwarding headers.
+
+ * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
+ * ForwardingHeaders/wrec/WREC.h: Added.
+
+=== Start merge of squirrelfish-extreme ===
+
+2008-09-06 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ <rdar://problem/6187043>
+ Don't parse full HTML user agent style sheet unless it is actually needed
+ <rdar://problem/6131889>
+ WebView is significantly more expensive to create recently
+
+ Parsing the html4.css takes significant amount of time and memory (~50kb) on application
+ startup. Some clients may never use most of the rules.
+
+ With this patch we use simplified UA stylesheet until we hit something it can't handle.
+ This avoids full stylesheet parsing on application startup (due to empty document construction)
+ and also makes it possible for clients with very simple demands (divs and spans only) never to load
+ the full style.
+
+ It also delays view source style parsing until it is used.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::elementCanUseSimpleDefaultStyle):
+ (WebCore::CSSStyleSelector::CSSStyleSelector):
+ (WebCore::loadFullDefaultStyle):
+ (WebCore::loadSimpleDefaultStyle):
+ (WebCore::loadViewSourceStyle):
+ (WebCore::CSSStyleSelector::matchUARules):
+ (WebCore::CSSStyleSelector::styleForElement):
+
+2008-09-06 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix.
+
+ * WebCoreSources.bkl:
+
+2008-09-06 Antti Koivisto <antti@apple.com>
+
+ Reverting r35953 which was causing problems on Windows which relies on
+ WebCore timers in nested event loops. r36132 did alternative fix.
+
+ * page/Chrome.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+
+2008-09-06 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix <rdar://problem/6201644>
+ https://bugs.webkit.org/show_bug.cgi?id=20493
+ Crash after OK in dialog box and reloading page in secure mode
+
+ Limited loader only fix since the general timer fix is causing problems on Windows.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::servePendingRequests):
+ (WebCore::Loader::Host::Host):
+ (WebCore::Loader::Host::didFinishLoading):
+ (WebCore::Loader::Host::didFail):
+ (WebCore::Loader::Host::didReceiveData):
+ * loader/loader.h:
+ (WebCore::Loader::Host::processingResource):
+
+2008-09-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ The initial Core Text adoption prototype was made by Daniel Fenwick.
+
+ - <rdar://problem/5158514> Add a Core Text-based complex text code path
+
+ Currently the Core Text code path is not used in any configuration.
+
+ * WebCore.xcodeproj/project.pbxproj: Added files.
+ * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
+ * platform/graphics/Font.cpp:
+ (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
+ of the loop.
+ * platform/graphics/GlyphBuffer.h:
+ (WebCore::GlyphBuffer::add): Added this version that takes an advance.
+ * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
+ Added getCTFont() and getCFStringAttributes() and corresponding data
+ members for Core Text.
+ * platform/graphics/mac/CoreTextController.cpp: Added.
+ (WebCore::roundCGFloat): Helper function.
+ (WebCore::ceilCGFloat): Helper function.
+ (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
+ (WebCore::CoreTextController::CoreTextController):
+ (WebCore::CoreTextController::offsetForPosition):
+ (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
+ run into subruns as necessary such that each subrun can be rendered with
+ a single font. Also separates out soft hyphens and replaces them with
+ real hyphens, because Core Text does not emit a glyph for soft hyphens.
+ Then calls collectCoreTextRunsForCharacters() on each subrun.
+ (WebCore::CoreTextController::advance):
+ (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
+ a CTLine from the given subrun and collects its CoreTextRuns.
+ (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
+ rounding hacks, letter- and word-spacing and glyph substitutions and
+ stores the resulting adjusted glyphs and advances.
+ * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
+ (WebCore::CoreTextController::totalWidth):
+ (WebCore::CoreTextController::finalRoundingWidth):
+ (WebCore::CoreTextController::CoreTextRun::ctRun):
+ (WebCore::CoreTextController::CoreTextRun::glyphCount):
+ (WebCore::CoreTextController::CoreTextRun::fontData):
+ (WebCore::CoreTextController::CoreTextRun::characters):
+ (WebCore::CoreTextController::CoreTextRun::stringLocation):
+ (WebCore::CoreTextController::CoreTextRun::stringLength):
+ (WebCore::CoreTextController::CoreTextRun::indexAt):
+ * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
+ FontMacATSUI.mm.
+ * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
+ (WebCore::disableLigatures): Changed to call
+ FontPlatformData::allowsLigatures().
+ (WebCore::overrideLayoutOperation): Changed to call
+ FontPlatformData::roundsGlyphAdvances().
+ * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
+ (WebCore::Font::selectionRectForComplexText): Changed to use
+ totalWidth() instead of advancing to the end and using runWidthSoFar().
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText): Ditto.
+ (WebCore::Font::offsetForPositionForComplexText):
+ * platform/graphics/mac/FontPlatformData.h:
+ * platform/graphics/mac/FontPlatformDataMac.mm:
+ (WebCore::FontPlatformData::setFont):
+ (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
+ AppKit rendering mode.
+ (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
+ heuristic that allows ligatures in fonts that do not have a glyph for
+ 'a', based on the assumption that such fonts are only used in complex
+ text.
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::platformDestroy):
+ (WebCore::SimpleFontData::getCTFont): Added.
+ (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
+ returns an attributes dictionary.
+ * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
+ * platform/text/mac/ShapeArabic.h: Ditto.
+
+2008-09-06 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - make combining mark offsets work in CG text on Windows
+
+ * platform/graphics/win/FontCGWin.cpp:
+ (WebCore::Font::drawGlyphs): The old code tried to translate the text
+ matrix, but failed for two reasons: it did not actually change the
+ matrix, and even if it did, CGContextSetTextPosition overwrites the
+ translation values in the text matrix. Instead, just added the
+ translation to the anchor point.
+
+2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
+
+ Reviewed by Alp Toker.
+
+ https://bugs.webkit.org/show_bug.cgi?id=18346
+ [GTK] Remove build warnings
+
+ Applied some casts, and removed an unused typedef to make the
+ compiler happy, printing less warnings when building.
+
+ * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::containsCharacters):
+ * platform/graphics/gtk/VideoSinkGStreamer.cpp:
+ (webkit_video_sink_set_caps):
+ * platform/network/soup/ResourceHandleSoup.cpp:
+
+2008-09-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Build fix for WebKitWin and Chromium
+
+ * platform/FileSystem.h:
+
+2008-09-05 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Try to make Chromium compile with ToT:
+ - Wrap a few places which depend on KJS:: in #if USE(JSC)
+ - Include some windows forward declarations
+
+ * dom/Node.h:
+ * page/Console.h:
+ * page/animation/CompositeAnimation.h:
+ * platform/FileSystem.h:
+ * platform/graphics/Image.h:
+ * platform/text/AtomicString.h:
+ * platform/text/String.cpp:
+ * rendering/style/RenderStyle.h:
+
+2008-09-05 Dave Hyatt <hyatt@apple.com>
+
+ Add support for runtime switchability of the Aqua look and the native look on Windows.
+ Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
+
+ Reviewed by Adam Roben
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * page/Settings.cpp:
+ (WebCore::Settings::setShouldPaintNativeControls):
+ * page/Settings.h:
+ (WebCore::Settings::shouldPaintNativeControls):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::theme):
+ * rendering/RenderThemeWin.cpp:
+
+2008-09-05 Antti Koivisto <antti@apple.com>
+
+ Qt build fix.
+
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::build):
+
+2008-09-05 Dirk Schulze <vbs85@gmx.de>
+
+ Gtk build fix
+
+ * GNUmakefile.am:
+
+2008-09-05 Antti Koivisto <antti@apple.com>
+
+ Another build fix.
+
+ * svg/SVGFEImageElement.cpp:
+ (WebCore::SVGFEImageElement::notifyFinished):
+
+2008-09-05 Antti Koivisto <antti@apple.com>
+
+ Build fixes.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * svg/graphics/filters/SVGFEImage.cpp:
+ (WebCore::FEImage::cachedImage):
+
+2008-09-05 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
+ When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
+
+ Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
+ not yet enable it for the biggest use case, reloading. However it is good for general browsing as
+ well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
+ we avoid re-decoding resources, especially images.
+
+ To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
+ CacheControl: max-age=0 header. That would be added in reload case.
+
+ The approach for revalidation is to kick the original resource out from the memory cache
+ and create a new CachedResource that represents the revalidation request. In case
+ we get 304 back for the request we put the original resource back to the cache, update
+ its expiration date and switch the clients registered to revalidation resource to be
+ clients of the original resource.
+
+ All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
+ This allows updating the handles to point to the original resource when the revalidation succeeds. It
+ also acts as refcounting smart pointer.
+
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSFontFaceSource.h:
+ * css/CSSImportRule.h:
+ * dom/Clipboard.h:
+ (WebCore::Clipboard::dragImage):
+ * dom/ProcessingInstruction.h:
+ * dom/ScriptElement.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::isWaitingForScripts):
+ * dom/XMLTokenizer.h:
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::setImage):
+ (WebCore::HTMLImageLoader::updateFromElement):
+ (WebCore::HTMLImageLoader::notifyFinished):
+ * html/HTMLImageLoader.h:
+ (WebCore::HTMLImageLoader::image):
+ * html/HTMLLinkElement.h:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::reset):
+ (WebCore::HTMLTokenizer::scriptHandler):
+ (WebCore::HTMLTokenizer::notifyFinished):
+ * html/HTMLTokenizer.h:
+ * loader/Cache.cpp:
+ (WebCore::Cache::revalidateResource):
+ (WebCore::Cache::revalidationSucceeded):
+ (WebCore::Cache::revalidationFailed):
+ * loader/Cache.h:
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::CachedResource):
+ (WebCore::CachedResource::~CachedResource):
+ (WebCore::CachedResource::isExpired):
+ (WebCore::CachedResource::setResponse):
+ (WebCore::CachedResource::deleteIfPossible):
+ (WebCore::CachedResource::setResourceToRevalidate):
+ (WebCore::CachedResource::clearResourceToRevalidate):
+ (WebCore::CachedResource::switchClientsToRevalidatedResource):
+ (WebCore::CachedResource::canUseCacheValidator):
+ (WebCore::CachedResource::mustRevalidate):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::canDelete):
+ (WebCore::CachedResource::registerHandle):
+ (WebCore::CachedResource::unregisterHandle):
+ (WebCore::CachedResource::isCacheValidator):
+ (WebCore::CachedResource::resourceToRevalidate):
+ (WebCore::CachedResource::setExpirationDate):
+ * loader/CachedResourceHandle.cpp: Added.
+ (WebCore::CachedResourceHandleBase::setResource):
+ * loader/CachedResourceHandle.h: Added.
+ (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
+ (WebCore::CachedResourceHandleBase::get):
+ (WebCore::CachedResourceHandleBase::operator!):
+ (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
+ (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
+ (WebCore::CachedResourceHandleBase::operator=):
+ (WebCore::CachedResourceHandle::CachedResourceHandle):
+ (WebCore::CachedResourceHandle::get):
+ (WebCore::CachedResourceHandle::operator->):
+ (WebCore::CachedResourceHandle::operator=):
+ (WebCore::CachedResourceHandle::operator==):
+ (WebCore::CachedResourceHandle::operator!=):
+ (WebCore::operator==):
+ (WebCore::operator!=):
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::checkForReload):
+ * loader/UserStyleSheetLoader.h:
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::servePendingRequests):
+ (WebCore::Loader::Host::didFinishLoading):
+ (WebCore::Loader::Host::didFail):
+ (WebCore::Loader::Host::didReceiveResponse):
+ (WebCore::Loader::Host::didReceiveData):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::selectCursor):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::setCachedImage):
+ (WebCore::RenderImage::imageChanged):
+ * rendering/RenderImage.h:
+ (WebCore::RenderImage::cachedImage):
+ (WebCore::RenderImage::imagePtr):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleCachedImage.h:
+ (WebCore::StyleCachedImage::data):
+ (WebCore::StyleCachedImage::cachedImage):
+ * svg/SVGFEImageElement.h:
+ * svg/graphics/filters/SVGFEImage.h:
+ * xml/XSLImportRule.h:
+
+2008-09-04 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Mitz
+
+ <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
+
+ A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
+ to model default NSURLRequest behavior in a cross-platform manner.
+
+ Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
+ client that wished to enforce a much larger default timeout using NSURLRequest API.
+
+ Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
+ behavior on the web and this restores previous Safari/WebKit behavior.
+
+ It would be easy to write a layout test for this, but to be effective it would have
+ to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
+
+ * manual-tests/timeout-test.html: Added.
+ * manual-tests/timeout-test.php: Added.
+
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
+ and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
+ * platform/network/mac/ResourceRequestMac.mm:
+ (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
+ "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
+ WebKit applications to enforce their own default timeout.
+
+2008-09-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
+
+ Test: fast/repaint/button-spurious-layout-hint.html
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::setStyle): Reset the inner block's style box
+ flex to 0 to avoid getting a spurious layout hint.
+
+2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes.
+
+ * WebCoreSources.bkl:
+ * bindings/js/ScriptControllerWx.cpp: Added.
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * page/wx/AccessibilityObjectWx.cpp: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+ * webcore-base.bkl:
+ * webcore-wx.bkl:
+
+2008-09-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
+ and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
+ require a different approach
+
+ * css/CSSGrammar.y:
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
+ Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
+
+ * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
+ * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
+ for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
+
+2008-09-04 Mark Rowe <mrowe@apple.com>
+
+ Mac build fix.
+
+ * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
+
+2008-09-04 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
+
+2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Eric Seidel.
+
+ http://bugs.webkit.org/show_bug.cgi?id=20380
+ [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
+
+ * config.h: Include the configuration header generated by autotools if
+ available.
+
+2008-09-04 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Dave Hyatt.
+
+ - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
+
+ * loader/CachedFont.cpp:
+ (WebCore::CachedFont::allClientsRemoved):
+ * loader/CachedFont.h:
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::allClientsRemoved):
+ * loader/CachedImage.h:
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::removeClient):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::allClientsRemoved):
+
+2008-09-04 Adam Roben <aroben@apple.com>
+
+ Windows build fix after r36071
+
+ We were getting these errors:
+
+ error C2356: initialization segment must not change during translation
+ unit
+
+ This was happening because multiple files #included by
+ DerivedSources.cpp were themselves #including StaticConstructors.h. I
+ fixed the error by adding header guards to StaticConstructors.h so its
+ contents will only be included once.
+
+ But it's also not a good idea for StaticConstructors.h to end up in
+ DerivedSources.cpp, since it ends up "polluting" all the source files
+ we have in there. So I removed all the files that include
+ StaticConstructors.h and added some preprocessor directives to
+ DerivedSources.cpp to catch this error in the future.
+
+ * DerivedSources.cpp: Removed the *Names.cpp files, which include
+ StaticConstructors.h, and added some preprocessor directives to make
+ sure we don't end up accidentally including StaticConstructors.h in
+ the future.
+ * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
+ * platform/StaticConstructors.h: Added header guards.
+
+2008-09-04 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * platform/graphics/win/FontPlatformData.h: Added a missing #include
+ of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
+ * platform/text/PlatformString.h: Added a missing #include of
+ PassRefPtr.h.
+
+2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix the QtWebKit build to match changes in r36016
+
+ * WebCore.pro:
+ * bridge/qt/qt_instance.cpp:
+ (KJS::Bindings::QtInstance::getRuntimeObject):
+ * bridge/qt/qt_runtime.cpp:
+ (KJS::Bindings::convertQVariantToValue):
+ (KJS::Bindings::QtConnectionObject::execute):
+
+2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
+
+ Reviewed by Simon.
+
+ Re-enable support for user stylesheets in QtWebKit
+
+ QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
+ code path, which allows us to keep API support for
+ loading user style sheets from remote URLs.
+
+ As part of the change UserStyleSheetLoader.cpp/h was
+ moved from WebCore/loader/mac to WebCore/loader.
+
+ * WebCore.pro:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/Document.h:
+ * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
+ (UserStyleSheetLoader::UserStyleSheetLoader):
+ (UserStyleSheetLoader::~UserStyleSheetLoader):
+ * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
+ * page/qt/FrameQt.cpp:
+ (WebCore::Frame::setUserStyleSheetLocation):
+ (WebCore::Frame::setUserStyleSheet):
+
+2008-09-04 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Eric.
+
+ Remove left-over QT and CAIRO platform checks.
+
+ * html/CanvasRenderingContext2D.cpp:
+
+2008-09-04 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix leak of TextMetrics due to over-ref as see on buildbot.
+
+ * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
+
+2008-09-04 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=19717
+ <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
+ positioned movement only case, call
+ tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
+ layout if that fails.
+ (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
+ layoutDoingPositionedMovementOnly to this, and made this function
+ check if the width changed. If it did, return, leaving the object
+ dirty. The caller can then call layout(). The width can change even
+ in the "positioned movement only" case if the object is shrink-to-fit
+ and the available width constraint is met. (This was the case in the
+ bug).
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
+ Renamed layoutDoingPositionedMovementOnly() to this.
+
+2008-09-03 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Attempt to fix the Qt build.
+
+ * WebCore.pro: add page/animation to include path
+
+2008-09-03 Mark Rowe <mrowe@apple.com>
+
+ Mac build fix. Correctly detect whether dashboard support is enabled.
+
+ * DerivedSources.make:
+
+2008-09-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam.
+
+ Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
+
+ * Configurations/WebCore.xcconfig: add missing ENABLE_*
+ * config.h: add rules for V8_BINDINGS
+
+2008-09-03 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20620
+
+ Add #if USE(JSC) around KJS dependencies
+ Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
+ 1. Most platforms have it on anyway
+ 2. V8 is going to want to share some of that code
+ 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
+
+ * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
+ * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
+ * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
+ * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
+ * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
+ * platform/text/AtomicString.cpp: add USE(JSC)
+ * platform/text/AtomicString.h: add USE(JSC)
+ * platform/text/PlatformString.h: add USE(JSC)
+ * platform/text/String.cpp: add USE(JSC)
+ * platform/text/StringImpl.cpp: add USE(JSC)
+ * platform/text/StringImpl.h: add USE(JSC)
+
+2008-09-03 Dean McNamee <deanm@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20511
+ Bug 20511: Remove static initializers on Windows
+
+ Avoid static initializers on Windows by forcing Visual C++ to put
+ all static initializers in a code segment that is never executed.
+
+ * config.h:
+ * css/MediaFeatureNames.cpp:
+ * dom/EventNames.cpp:
+ * dom/QualifiedName.cpp:
+ * dom/make_names.pl:
+ * platform/StaticConstructors.h:
+ * platform/text/AtomicString.cpp:
+
+2008-09-03 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Dave Hyatt.
+
+ Make FontCairo draw TextStroke and TextFill separately.
+
+ [CAIRO] draw TextFill and TextStroke separately.
+ [https://bugs.webkit.org/show_bug.cgi?id=20631]
+
+ * platform/graphics/cairo/FontCairo.cpp:
+ (WebCore::Font::drawGlyphs):
+
+2008-09-03 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19663
+ Account for paint and timer lag when animating images. Also pretend
+ that images whose animations were paused (by becoming invisible)
+ continued to animate, by "catching up" to the correct frame when they're
+ shown again.
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage):
+ (WebCore::BitmapImage::startAnimation):
+ (WebCore::BitmapImage::advanceAnimation):
+ (WebCore::BitmapImage::internalAdvanceAnimation):
+ (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/qt/ImageQt.cpp:
+ (WebCore::BitmapImage::draw):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::BitmapImage::draw):
+
+2008-09-03 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ Remove the rest of the "zombie" code from the profiler.
+ - There is no longer a need for the ProfilerClient callback mechanism.
+
+ * page/Console.cpp:
+ (WebCore::Console::Console):
+ (WebCore::Console::profile):
+ (WebCore::Console::profileEnd): Move the variables from the header to
+ here since we don't have to wait for a callback to use them.
+ * page/Console.h:
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::startUserInitiatedProfiling):
+ (WebCore::InspectorController::stopUserInitiatedProfiling):
+ * page/InspectorController.h:
+
+2008-09-03 Ada Chan <adachan@apple.com>
+
+ Windows build fix.
+
+ * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
+
+2008-09-01 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20594
+ Add DOM interfaces for WebKitCSSKeyframeRule
+ and WebKitCSSKeyframesRule.
+
+ TEST: LayoutTests/css3/keyframes-rule.html
+
+ * css/WebKitCSSKeyframeRule.idl: Added
+ * css/WebKitCSSKeyframesRule.idl: Added
+
+ * bindings/js/JSCSSRuleCustom.cpp:
+ (WebCore::toJS):
+ Add return of new JS Keyframe rules
+ * bindings/objc/DOMInternal.h:
+ Include new internal header
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Build configs for new files
+
+2008-09-03 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
+ * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
+ convenience/consistency.
+
+2008-09-03 Adele Peterson <adele@apple.com>
+
+ Build fix.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-09-03 David Hyatt <hyatt@apple.com>
+
+ Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
+
+ Reviewed by Darin (ages ago)
+
+ Added fast/block/float/clamped-right-float.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::positionNewFloats):
+
+2008-09-02 David Hyatt <hyatt@apple.com>
+
+ Add support for canvas text drawing APIs.
+
+ Reviewed by olliej
+
+ Tests added as fast/canvas/canvas-text-*.html
+
+ * DerivedSources.make:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::JSCanvasRenderingContext2D::fillText):
+ (WebCore::JSCanvasRenderingContext2D::strokeText):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::initForStyleResolve):
+ (WebCore::CSSStyleSelector::applyPropertyToStyle):
+ * css/CSSStyleSelector.h:
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::State::State):
+ (WebCore::CanvasRenderingContext2D::font):
+ (WebCore::CanvasRenderingContext2D::setFont):
+ (WebCore::CanvasRenderingContext2D::textAlign):
+ (WebCore::CanvasRenderingContext2D::setTextAlign):
+ (WebCore::CanvasRenderingContext2D::textBaseline):
+ (WebCore::CanvasRenderingContext2D::setTextBaseline):
+ (WebCore::CanvasRenderingContext2D::fillText):
+ (WebCore::CanvasRenderingContext2D::strokeText):
+ (WebCore::CanvasRenderingContext2D::measureText):
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ (WebCore::CanvasRenderingContext2D::accessFont):
+ * html/CanvasRenderingContext2D.h:
+ * html/CanvasRenderingContext2D.idl:
+ * html/TextMetrics.h: Added.
+ (WebCore::TextMetrics::create):
+ (WebCore::TextMetrics::width):
+ (WebCore::TextMetrics::setWidth):
+ (WebCore::TextMetrics::TextMetrics):
+ * html/TextMetrics.idl: Added.
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::lineGap):
+ * platform/graphics/Font.h:
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::drawBidiText):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsTypes.cpp:
+ (WebCore::textAlignName):
+ (WebCore::parseTextAlign):
+ (WebCore::textBaselineName):
+ (WebCore::parseTextBaseline):
+ * platform/graphics/GraphicsTypes.h:
+ (WebCore::):
+
+2008-09-03 John Sullivan <sullivan@apple.com>
+
+ Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
+
+ Fixed by Darin, reviewed by me
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::propertiesEqual):
+ added ensurePropertyMap() to this static function
+ (WebCore::AnimationBase::getPropertyAtIndex):
+ ditto
+ (WebCore::AnimationBase::getNumProperties):
+ ditto
+
+2008-09-03 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Darin and Tim.
+
+ Remove most of the "zombie" mode from the profiler. Next we will need
+ to remove the client callback mechanism in profiles.
+ - These changes are a result of changes to JSCore.
+
+ * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
+ * page/Console.cpp:
+ (WebCore::retrieveLastCaller):
+ (WebCore::Console::profileEnd):
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::stopUserInitiatedProfiling):
+
+2008-09-03 Adele Peterson <adele@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Test: fast/forms/search-display-none-cancel-button.html
+
+ Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
+
+ * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
+ (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
+ (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
+ (WebCore::RenderTextControl::createSubtreeIfNeeded):
+ Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
+ (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
+ (WebCore::RenderTextControl::subtreeHasChanged): ditto.
+ (WebCore::RenderTextControl::calcHeight): ditto.
+ (WebCore::RenderTextControl::nodeAtPoint): ditto.
+ (WebCore::RenderTextControl::layout): ditto.
+ (WebCore::RenderTextControl::calcPrefWidths): ditto.
+ (WebCore::RenderTextControl::clientPaddingLeft): ditto.
+ (WebCore::RenderTextControl::clientPaddingRight): ditto.
+
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
+ (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
+ (WebCore::TextControlInnerElement::attachInnerElement): Added.
+ This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
+ (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
+ * rendering/TextControlInnerElements.h:
+
+2008-08-28 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej.
+
+ Elminate SQLiteAuthorizer class.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCore.vcproj/WebCore.vcproj:
+ * GNUmakefile.am
+ Removed SQLiteAuthorizer.h.
+
+ * platform/sql/SQLiteAuthorizer.cpp:
+ * platform/sql/SQLiteAuthorizer.h: Removed.
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::authorizerFunction):
+ (WebCore::SQLiteDatabase::setAuthorizer):
+ * platform/sql/SQLiteDatabase.h:
+ * storage/DatabaseAuthorizer.h:
+ (WebCore::DatabaseAuthorizer::create):
+ (WebCore::DatabaseAuthorizer::createView):
+ (WebCore::DatabaseAuthorizer::createTempView):
+ (WebCore::DatabaseAuthorizer::dropView):
+ (WebCore::DatabaseAuthorizer::dropTempView):
+ (WebCore::DatabaseAuthorizer::allowSelect):
+ (WebCore::DatabaseAuthorizer::allowReindex):
+ Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
+
+2008-09-03 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Mark Rowe.
+
+ WebKitGtk build fix.
+
+ * GNUmakefile.am:
+ * page/animation/AnimationController.h:
+
+2008-09-02 Robert Blaut <webkit@blaut.biz>
+
+ Reviewed by Geoff Garen.
+
+ Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
+ Misplaced elements should not close DL lists.
+
+ Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleError):
+
+2008-09-02 Glenn Wilson <wilsong@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
+ Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
+
+ We would inappropriately interpret and apply an invalid CSS "color" property
+ when the value is a predefined color preceded by a '#' symbol. For example,
+ style="color:#gray;" would apply the color gray when it should not.
+
+ In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
+ This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
+ interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
+ an ignorable token.
+
+ To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
+ '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
+ CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
+
+ Test: css1/color_and_background/invalid_color.html
+
+ * css/CSSGrammar.y:
+
+2008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
+ Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
+
+ Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
+
+ Test: css3/khtml-background-size-0x0-bmp.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+
+2008-09-02 Glenn Wilson <wilsong@gmail.com>
+
+ Reviewed by Eric Seidel.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20397
+ Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
+
+ The function checkForOrphanedUnits() would change the length of a list whose size was
+ was already determined before the call to checkForOrphanedUnits was made. Later in
+ the caller, the old size was being used for boundary management.
+
+ This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
+ calling function, before the size of the list is determined.
+
+ Test: fast/css/orphaned_units_crash.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
+
+2008-09-02 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Darin Adler.
+
+ Fallback on invalid fill or stroke styles in Canvas was
+ transparent black. Changed it to last valid style.
+
+ Canvas fillStyle() and strokeStyle() needs fallback
+ https://bugs.webkit.org/show_bug.cgi?id=20474
+
+ Tests: fast/canvas/canvas-invalid-fillstyle.html
+ fast/canvas/canvas-invalid-strokestyle.html
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+
+2008-09-02 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Darin Adler.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20468
+ Updated drawImage() in canvas to match the current specification.
+
+ Test: fast/canvas/drawImage-with-negative-source-destination.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::normalizeRect):
+ (WebCore::CanvasRenderingContext2D::drawImage):
+
+2008-08-26 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/5768210> Switch back to the system version of SQLite
+
+ Use the system version of SQLite when it is new enough to provide the functionality
+ that WebCore requires.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ * Configurations/WebCore.xcconfig:
+
+2008-09-02 Dan Bernstein <mitz@apple.com>
+
+ - build fix
+
+ * page/animation/AnimationBase.h:
+
+2008-09-02 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ AnimationController.cpp should be split into separate files
+ https://bugs.webkit.org/show_bug.cgi?id=20604
+
+ Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
+ recommendation of Dave Hyatt.
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Build files.
+
+ * page/AnimationController.cpp: Removed.
+ * page/AnimationController.h: Removed.
+ * page/animation: Added.
+ * page/animation/AnimationBase.cpp: Added.
+ * page/animation/AnimationBase.h: Added.
+ * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
+ * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
+ * page/animation/CompositeAnimation.cpp: Added.
+ * page/animation/CompositeAnimation.h: Added.
+ * page/animation/ImplicitAnimation.cpp: Added.
+ * page/animation/ImplicitAnimation.h: Added.
+ * page/animation/KeyframeAnimation.cpp: Added.
+ * page/animation/KeyframeAnimation.h: Added.
+
+2008-09-02 Dan Bernstein <mitz@apple.com>
+
+ - release build fix
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::calculateDrawingMode):
+
+2008-09-02 Timothy Hatcher <timothy@apple.com>
+
+ Make console functions log the correct resource URL and
+ line number for where the call originated.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17234
+ <rdar://problem/5732837>
+
+ Reviewed by Kevin McCullough.
+
+ Test: manual-tests/inspector/console-call-line-numbers.html
+
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::count): Call the impl.
+ (WebCore::JSConsole::timeEnd): Ditto.
+ * manual-tests/inspector/console-call-line-numbers.html: Added.
+ * manual-tests/inspector/resources/script-console-calls.js: Added.
+ * page/Console.cpp:
+ (WebCore::retrieveLastCaller): Helper to get the URL and line.
+ (WebCore::Console::error): Call retrieveLastCaller to get the URL and
+ line number to pass to addMessageToConsole.
+ (WebCore::Console::info): Ditto.
+ (WebCore::Console::log): Ditto.
+ (WebCore::Console::assertCondition): Ditto.
+ (WebCore::Console::count): Ditto.
+ (WebCore::Console::timeEnd): Ditto.
+ (WebCore::Console::warn): Ditto.
+ * page/Console.h:
+ * page/Console.idl: Make count and timeEnd custom.
+
+2008-09-02 Timothy Hatcher <timothy@apple.com>
+
+ Removed IDL files from WebCore's framework resources.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-09-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
+
+ * html/HTMLParser.cpp:
+ (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
+ cap on the number of consecutive identical residual style tags to
+ reopen.
+ (WebCore::HTMLParser::popBlock): Ditto.
+
+2008-09-02 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ A little database quota management cleanup.
+
+ * storage/OriginQuotaManager.cpp:
+ (WebCore::OriginQuotaManager::OriginQuotaManager):
+ (WebCore::OriginQuotaManager::lock):
+ (WebCore::OriginQuotaManager::unlock):
+ (WebCore::OriginQuotaManager::trackOrigin):
+ (WebCore::OriginQuotaManager::tracksOrigin):
+ (WebCore::OriginQuotaManager::addDatabase):
+ (WebCore::OriginQuotaManager::removeDatabase):
+ (WebCore::OriginQuotaManager::removeOrigin):
+ (WebCore::OriginQuotaManager::markDatabase):
+ (WebCore::OriginQuotaManager::diskUsage):
+ * storage/OriginQuotaManager.h:
+ Changed to assert that a lock is taken more directly and reliably. Removed comments about
+ main/background threads, as this is likely to stop being true with synchronous Database calls
+ being made on worker threads.
+
+ * storage/OriginUsageRecord.cpp:
+ (WebCore::OriginUsageRecord::OriginUsageRecord):
+ (WebCore::OriginUsageRecord::addDatabase):
+ (WebCore::OriginUsageRecord::removeDatabase):
+ (WebCore::OriginUsageRecord::markDatabase):
+ (WebCore::OriginUsageRecord::diskUsage):
+ * storage/OriginUsageRecord.h:
+ (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
+ Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
+ can be replaced with a single boolean for OriginUsageRecord.
+ Added assertions for string parameters being unshared.
+
+
+2008-09-01 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19760
+
+ Make granting LoadLocalResources conditional on a policy.
+
+ * WebCore.base.exp:
+ * dom/Document.cpp:
+ (WebCore::Document::initSecurityContext):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::setLocalLoadPolicy):
+ (WebCore::FrameLoader::restrictAccessToLocal):
+ * loader/FrameLoader.h:
+ (WebCore::FrameLoader::):
+ * platform/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::grantLoadLocalResources):
+ * platform/SecurityOrigin.h:
+
+2008-09-01 Dean Jackson <dino@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20571
+ Make sure Window object can assign Animation/Transition event
+ listeners via attributes.
+
+ Also added a bunch of transition event tests, although
+ only transition-end-event-window is directly relevant to this patch.
+
+ (WebCore::JSDOMWindowBase::put):
+
+ Tests: transitions/transition-end-event-all-properties.html
+ transitions/transition-end-event-attributes.html
+ transitions/transition-end-event-container.html
+ transitions/transition-end-event-left.html
+ transitions/transition-end-event-multiple-01.html
+ transitions/transition-end-event-multiple-02.html
+ transitions/transition-end-event-multiple-03.html
+ transitions/transition-end-event-multiple-04.html
+ transitions/transition-end-event-nested.html
+ transitions/transition-end-event-transform.html
+ transitions/transition-end-event-window.html
+
+2008-09-01 Dean Jackson <dino@apple.com>
+
+ Reviewed by Sam Weinig
+
+ Code styling cleanup.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::getValueProperty):
+ (WebCore::JSDOMWindowBase::put):
+
+2008-09-01 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Darin Adler.
+
+ First cut at inline caching for access to vanilla JavaScript properties.
+
+ Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
+ to WebCore classes, and PutPropertySlot& arguments to put functions.
+
+ (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
+ inline caching for global properties, so global assignment can be optimized.
+
+ * ForwardingHeaders/kjs/StructureID.h: Added.
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::DOMObject::DOMObject):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::put):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSDOMWindowCustom.h:
+ (WebCore::JSDOMWindow::customPut):
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell):
+ (WebCore::JSDOMWindowShell::put):
+ * bindings/js/JSDOMWindowShell.h:
+ * bindings/js/JSEventTargetBase.h:
+ (WebCore::JSEventTargetBase::put):
+ * bindings/js/JSEventTargetNode.h:
+ (WebCore::JSEventTargetNode::put):
+ * bindings/js/JSHTMLAppletElementCustom.cpp:
+ (WebCore::JSHTMLAppletElement::customPut):
+ * bindings/js/JSHTMLEmbedElementCustom.cpp:
+ (WebCore::JSHTMLEmbedElement::customPut):
+ * bindings/js/JSHTMLInputElementBase.cpp:
+ (WebCore::JSHTMLInputElementBase::put):
+ * bindings/js/JSHTMLInputElementBase.h:
+ * bindings/js/JSHTMLObjectElementCustom.cpp:
+ (WebCore::JSHTMLObjectElement::customPut):
+ * bindings/js/JSHistoryCustom.cpp:
+ (WebCore::JSHistory::customPut):
+ * bindings/js/JSInspectedObjectWrapper.cpp:
+ (WebCore::JSInspectedObjectWrapper::wrap):
+ (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
+ * bindings/js/JSInspectedObjectWrapper.h:
+ * bindings/js/JSInspectorCallbackWrapper.cpp:
+ (WebCore::JSInspectorCallbackWrapper::wrap):
+ (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
+ * bindings/js/JSInspectorCallbackWrapper.h:
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::customPut):
+ * bindings/js/JSPluginElementFunctions.cpp:
+ (WebCore::runtimeObjectCustomPut):
+ * bindings/js/JSPluginElementFunctions.h:
+ * bindings/js/JSQuarantinedObjectWrapper.cpp:
+ (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
+ (WebCore::JSQuarantinedObjectWrapper::put):
+ * bindings/js/JSQuarantinedObjectWrapper.h:
+ * bindings/js/JSStorageCustom.cpp:
+ (WebCore::JSStorage::customPut):
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject setValue:forKey:]):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bridge/NP_jsobject.cpp:
+ (_NPN_SetProperty):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::setMember):
+ * bridge/objc/objc_class.mm:
+ (KJS::Bindings::ObjcClass::fallbackObject):
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
+ (ObjcFallbackObjectImp::put):
+ * bridge/runtime.cpp:
+ (KJS::Bindings::Instance::createRuntimeObject):
+ * bridge/runtime_array.cpp:
+ (RuntimeArray::put):
+ * bridge/runtime_array.h:
+ * bridge/runtime_object.cpp:
+ (RuntimeObjectImp::RuntimeObjectImp):
+ (RuntimeObjectImp::put):
+ * bridge/runtime_object.h:
+
+2008-09-01 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Fixed border-radius for Cairo.
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::strokeArc):
+
+2008-09-01 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Added canvas's globalAlpha to cairo.
+
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::setAlpha):
+ (WebCore::GraphicsContext::getAlpha):
+ * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+ (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::BitmapImage::draw):
+
+2008-08-31 Simon Hausmann <hausmann@webkit.org>
+
+ Unreviewed Qt build fix.
+
+ * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
+ the .h file
+
+2008-08-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej.
+
+ - adopt some new JavaScriptCore functions where appropriate
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
+ (WebCore::windowProtoFuncBToA): Ditto.
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSLazyEventListener::eventParameterName): Adopted
+ jsNontrivialString.
+ * bindings/js/JSSVGLazyEventListener.cpp:
+ (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
+
+2008-08-29 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders' rubberstamp
+
+ Style cleanup to match MediaTokenizer::writeRawData()
+
+ * loader/PluginDocument.cpp:
+ (WebCore::PluginTokenizer::writeRawData):
+
+2008-08-29 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders
+
+ https://bugs.webkit.org/show_bug.cgi?id=20556
+ <rdar://problem/6181817> REGRESSION (r35946): media/video-click-dlbclick-standalone.html [sic] fails because load never fires
+
+ Fix regression I introducted in 35946
+ Already covered by media/video-click-dlbclick-standalone.html
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
+ (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
+ an ASSERT signifying that this method should only be called once, to more closely follow the
+ PluginDocument case.
+
+2008-08-29 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for <rdar://problem/6181588>
+
+ This patch makes hit testing take into account the new concept of a
+ disconnected frame, in which some of the content may not be
+ visible. The current hit testing mechanism starts at a target frame
+ and drills down for a HitTestResult. In some cases, drilling down
+ will find a non-visible result. When this happens, we need to try
+ again, starting at a higher level -- namely, starting at the main
+ frame.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::insideVisibleArea): New function that tests if a
+ point is inside the visible area for a disconnected frame.
+ * editing/Editor.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+
+2008-08-29 Adele Peterson <adele@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/HTMLTextFieldInnerElement.cpp: Removed.
+ * html/HTMLTextFieldInnerElement.h: Removed.
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::createSubtreeIfNeeded):
+ * rendering/RenderTextControl.h:
+ * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
+ (WebCore::TextControlInnerElement::TextControlInnerElement):
+ (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+ (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
+ (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
+ (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
+ (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
+ * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
+
+2008-08-29 Eric Seidel <eric@webkit.org>
+
+ Rubber-stamped by aroben.
+
+ Add GraphicsContext.h include to GraphcisContextPrivate.h
+
+ GraphicsContextPrivate uses StrokeStyle which is defined
+ in GraphicsContext.h but it doesn't include that header.
+ CoreGraphics build doesn't fail here due to the order
+ it happens to include files.
+
+ * platform/graphics/GraphicsContextPrivate.h:
+
+2008-08-29 Eric Seidel <eric@webkit.org>
+
+ Reviewed by hyatt.
+
+ Fix GeneratedImage to respect Image's refcounting
+ Fixing potential crashers (future if not current)
+ https://bugs.webkit.org/show_bug.cgi?id=20567
+
+ I don't know if it's possible to make the current code
+ crash, thus I've not made a test.
+
+ * css/CSSGradientValue.cpp:
+ (WebCore::CSSGradientValue::image):
+ * css/CSSImageGeneratorValue.cpp:
+ (WebCore::CSSImageGeneratorValue::removeClient):
+ (WebCore::CSSImageGeneratorValue::getImage):
+ * css/CSSImageGeneratorValue.h:
+ * platform/graphics/GeneratedImage.h:
+ (WebCore::GeneratedImage::GeneratedImage):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::setContent):
+ * rendering/style/RenderStyle.h:
+
+2008-08-29 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele.
+
+ Fix for <rdar://problem/6093767>
+ https://bugs.webkit.org/show_bug.cgi?id=20526
+
+ Don't allow video to render until unsupported track types have been disabled.
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWinPrivate::task):
+ (QTMovieWinPrivate::drawingComplete):
+ (QTMovieWinPrivate::clearGWorld):
+
+2008-08-29 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
+ <rdar://problem/6169301>
+
+ Return the size of the movie data instead of 1000.
+
+ Test: media/progress-event-total.html
+
+ * platform/graphics/win/QTMovieWin.cpp:
+ (QTMovieWin::dataSize):
+
+2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Eric Seidel.
+
+ [janitor/qt] Start replacing port specific getters with the generic native getter
+ To get the native presentation of an image we currently have platform
+ specific #ifdef's and a generic getter using NativeImagePtr. This patch
+ extends this to the ImageBuffer and updates the Qt platform to get rid
+ of the special #ifdefs.
+
+ https://bugs.webkit.org/attachment.cgi?id=22861
+
+ * platform/graphics/BitmapImage.h:
+ * platform/graphics/Image.h:
+ * platform/graphics/qt/ImageQt.cpp:
+ * platform/graphics/qt/StillImageQt.cpp:
+ * platform/graphics/qt/StillImageQt.h:
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::createDragImage):
+ (WebCore::ClipboardQt::declareAndWriteDragImage):
+ * platform/qt/CursorQt.cpp:
+ * platform/qt/PasteboardQt.cpp:
+ (WebCore::Pasteboard::writeImage):
+
+2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
+ [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
+
+ * svg/graphics/qt/SVGPaintServerQt.cpp:
+ (WebCore::SVGPaintServer::renderPath):
+ * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+
+2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
+ [network/qt] Implement defering of loading ResourceHandle's
+ This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
+ implementation is simply not forwarding anything to the
+ ResourceHandleClient until we are allowed to. This might lead to a deadlock
+ in Qt as we do not empty the QNetworkReply input buffer and wait until we
+ are allowed to read. If that happens we are forced to buffer the data
+ within QNetworkReplyHandler, for now this is not done.
+
+ Manual test:
+ - Open http://acid3.acidtests.org
+ - Wait for the test to complete
+ - Click on the Reference Rendering link
+ - Be fast and see the results of acid3
+ => assert
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
+ (WebCore::QNetworkReplyHandler::setLoadMode):
+ (WebCore::QNetworkReplyHandler::finish):
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+ (WebCore::QNetworkReplyHandler::forwardData):
+ (WebCore::QNetworkReplyHandler::start):
+ (WebCore::QNetworkReplyHandler::resetState):
+ (WebCore::QNetworkReplyHandler::sendQueuedItems):
+ * platform/network/qt/QNetworkReplyHandler.h:
+ (WebCore::QNetworkReplyHandler::):
+ * platform/network/qt/ResourceHandleQt.cpp:
+ (WebCore::ResourceHandle::start):
+ (WebCore::ResourceHandle::loadResourceSynchronously):
+ (WebCore::ResourceHandle::setDefersLoading):
+
+2008-08-29 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Holger.
+
+ Don't crash when drawing patterns with the HTML canvas. Patterns
+ remain unimplemented but at least they don't crash anymore. This is
+ done by changing the PlatformPatternPtr to be a brush for the Qt
+ platform.
+
+ * platform/graphics/Pattern.h:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ * platform/graphics/qt/PatternQt.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+
+2008-08-29 Simon Hausmann <hausmann@webkit.org>
+
+ Fix the Qt build, fontSelector() is not used by the Qt port yet
+ and we just return 0 in Font::fontSelector().
+
+ * platform/graphics/Font.h:
+
+2008-08-28 Alp Toker <alp@nuanti.com>
+
+ GTK+ dist/build fix. List newly added header files.
+
+ * GNUmakefile.am:
+
+2008-08-28 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Various WebKitCSSTransformValue-related fixes
+ https://bugs.webkit.org/show_bug.cgi?id=20562
+
+ Test: css3/transform-value-types.html
+
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::toJS):
+ * css/CSSValue.h:
+ * css/WebKitCSSTransformValue.cpp:
+ (WebCore::WebKitCSSTransformValue::cssText):
+ * css/WebKitCSSTransformValue.h:
+ (WebCore::WebKitCSSTransformValue::):
+ * css/WebKitCSSTransformValue.idl:
+
+2008-08-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Steve Falkenburg.
+
+ - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::TimerWindowWndProc):
+
+2008-08-28 David Hyatt <hyatt@apple.com>
+
+ RenderStyle cleanup.
+
+ Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
+
+ Reviewed by Adam
+
+ * css/CSSImageGeneratorValue.cpp:
+ * css/CSSImageValue.cpp:
+ * css/CSSStyleSelector.cpp:
+ * rendering/RenderImageGeneratedContent.cpp:
+ * rendering/style/NinePieceImage.cpp: Added.
+ * rendering/style/NinePieceImage.h: Added.
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::FillLayer::operator==):
+ (WebCore::FillLayer::containsImage):
+ (WebCore::StyleInheritedData::operator==):
+ (WebCore::RenderStyle::contentDataEquivalent):
+ * rendering/style/RenderStyle.h:
+ * rendering/style/StyleCachedImage.cpp: Added.
+ * rendering/style/StyleCachedImage.h: Added.
+ * rendering/style/StyleGeneratedImage.cpp: Added.
+ * rendering/style/StyleGeneratedImage.h: Added.
+ * rendering/style/StyleImage.h: Added.
+
+2008-08-28 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Make all the 'isFoo()' methods on CSSValue const,
+ and fix the subclasses.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20561
+
+ * css/CSSTimingFunctionValue.h:
+ * css/CSSValue.h:
+ (WebCore::CSSValue::isFontValue):
+ (WebCore::CSSValue::isImageGeneratorValue):
+ (WebCore::CSSValue::isImageValue):
+ (WebCore::CSSValue::isImplicitInitialValue):
+ * css/CSSValueList.h:
+ * css/FontValue.h:
+
+2008-08-28 David Hyatt <hyatt@apple.com>
+
+ The great RenderStyle cleanup begins!
+
+ Move LengthBox and LengthSize out of RenderStyle and into Length.
+
+ Reviewed by Adam
+
+ * rendering/Length.h:
+ (WebCore::):
+ (WebCore::Length::Length):
+ (WebCore::Length::operator==):
+ (WebCore::Length::operator!=):
+ (WebCore::Length::value):
+ (WebCore::Length::rawValue):
+ (WebCore::Length::percent):
+ (WebCore::Length::type):
+ (WebCore::Length::quirk):
+ (WebCore::Length::setValue):
+ (WebCore::Length::setRawValue):
+ (WebCore::Length::calcValue):
+ (WebCore::Length::calcMinValue):
+ (WebCore::Length::calcFloatValue):
+ (WebCore::Length::isUndefined):
+ (WebCore::Length::isZero):
+ (WebCore::Length::isPositive):
+ (WebCore::Length::isNegative):
+ (WebCore::Length::isAuto):
+ (WebCore::Length::isRelative):
+ (WebCore::Length::isPercent):
+ (WebCore::Length::isFixed):
+ (WebCore::Length::isStatic):
+ (WebCore::Length::isIntrinsicOrAuto):
+ (WebCore::Length::blend):
+ (WebCore::LengthBox::LengthBox):
+ (WebCore::LengthBox::operator=):
+ (WebCore::LengthBox::operator==):
+ (WebCore::LengthBox::operator!=):
+ (WebCore::LengthBox::nonZero):
+ (WebCore::LengthSize::LengthSize):
+ * rendering/style/RenderStyle.h:
+
+2008-08-28 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin
+
+ https://bugs.webkit.org/show_bug.cgi?id=18091
+
+ font-size should be animatable using -webkit-transition.
+
+ * page/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::ensurePropertyMap):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::setFontSize):
+
+2008-08-28 Brad Garcia <bgarcia@google.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20549
+ Correctly determine when cursor is over a resizable border within
+ a nested frameset.
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::canResizeRow):
+ (WebCore::RenderFrameSet::canResizeColumn):
+
+2008-08-28 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
+ https://bugs.webkit.org/show_bug.cgi?id=20552
+
+ Test: animations/animation-css-rule-types.html
+
+ * css/CSSRule.idl:
+
+2008-08-28 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Kevin and Darin.
+
+ <rdar://problem/6182541>
+ https://bugs.webkit.org/show_bug.cgi?id=20202
+ Missing http status line from the http headers.
+
+ Add a status line to the header string.
+
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::startStream):
+
+2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber-stamped by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17261
+
+ Make it possible to theme the default Url icon and enable this for
+ the Qt port. To have a minimal usage of #ifdef in the code the setting
+ of the icon was moved to a new method which comes in two flavors.
+
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::loadDefaultIconRecord): Load or set the default icon
+ (WebCore::IconDatabase::defaultIcon):
+
+2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed compile fix
+
+ * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
+
+2008-08-28 Adam Roben <aroben@apple.com>
+
+ Windows (and others?) build fix
+
+ * page/Chrome.cpp: Added a missing #include.
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
+
+2008-08-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Qt and Cairo support from krit (and blind stab @ wx compile support)
+ https://bugs.webkit.org/show_bug.cgi?id=20373
+
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::drawPath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::setPlatformFillColor):
+ (WebCore::GraphicsContext::setPlatformStrokeColor):
+ (WebCore::GraphicsContext::setPlatformStrokeStyle):
+ (WebCore::GraphicsContext::strokeRect):
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::imageInterpolationQuality):
+ (WebCore::GraphicsContext::setPlatformFillPattern):
+ (WebCore::GraphicsContext::setPlatformStrokePattern):
+ (WebCore::GraphicsContext::setPlatformFillGradient):
+ (WebCore::GraphicsContext::setPlatformStrokeGradient):
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokeRect):
+ (WebCore::GraphicsContext::clipToImageBuffer):
+ (WebCore::GraphicsContext::setPlatformFillPattern):
+ (WebCore::GraphicsContext::setPlatformStrokePattern):
+ (WebCore::GraphicsContext::setPlatformFillGradient):
+ (WebCore::GraphicsContext::setPlatformStrokeGradient):
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::imageInterpolationQuality):
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+ (WebCore::GraphicsContext::clipToImageBuffer):
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::imageInterpolationQuality):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::drawPath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::setPlatformFillPattern):
+ (WebCore::GraphicsContext::setPlatformStrokePattern):
+ (WebCore::GraphicsContext::setPlatformFillGradient):
+
+2008-08-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
+ https://bugs.webkit.org/show_bug.cgi?id=20373
+
+ Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
+
+ Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
+ have to store large Gradient objects in the GraphicsContextState
+
+ Made Pattern RefCounted for the same reason.
+
+ Many updates to GraphicsContext to support easier drawing with
+ Patterns and Gradients.
+
+ * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::toJS):
+ * css/CSSGradientValue.cpp:
+ (WebCore::CSSGradientValue::createGradient):
+ * css/CSSGradientValue.h:
+ * html/CanvasGradient.cpp:
+ (WebCore::CanvasGradient::CanvasGradient):
+ * html/CanvasGradient.h:
+ (WebCore::CanvasGradient::gradient):
+ (WebCore::CanvasGradient::addColorStop):
+ (WebCore::CanvasGradient::getColor):
+ * html/CanvasPattern.cpp:
+ * html/CanvasPattern.h:
+ (WebCore::CanvasPattern::pattern):
+ (WebCore::CanvasPattern::originClean):
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::State::State):
+ (WebCore::CanvasRenderingContext2D::setStrokeStyle):
+ (WebCore::CanvasRenderingContext2D::setFillStyle):
+ (WebCore::CanvasRenderingContext2D::fill):
+ (WebCore::CanvasRenderingContext2D::stroke):
+ (WebCore::CanvasRenderingContext2D::fillRect):
+ (WebCore::CanvasRenderingContext2D::strokeRect):
+ * html/CanvasRenderingContext2D.h:
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+ * html/CanvasStyle.h:
+ * platform/graphics/GeneratedImage.h:
+ (WebCore::GeneratedImage::GeneratedImage):
+ * platform/graphics/Generator.h:
+ * platform/graphics/Gradient.h:
+ (WebCore::Gradient::create):
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::fillRule):
+ (WebCore::GraphicsContext::setFillRule):
+ (WebCore::GraphicsContext::setStrokePattern):
+ (WebCore::GraphicsContext::setFillPattern):
+ (WebCore::GraphicsContext::setStrokeGradient):
+ (WebCore::GraphicsContext::setFillGradient):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/GraphicsContextPrivate.h:
+ (WebCore::):
+ (WebCore::GraphicsContextState::GraphicsContextState):
+ * platform/graphics/GraphicsTypes.h:
+ * platform/graphics/Path.h:
+ * platform/graphics/Pattern.h:
+ (WebCore::Pattern::create):
+ (WebCore::Pattern::tileImage):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::drawEllipse):
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::calculateDrawingMode):
+ (WebCore::GraphicsContext::drawPath):
+ (WebCore::fillPathWithFillRule):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::fillRoundedRect):
+ (WebCore::GraphicsContext::setPlatformStrokePattern):
+ (WebCore::GraphicsContext::setPlatformFillPattern):
+ (WebCore::GraphicsContext::setPlatformStrokeGradient):
+ (WebCore::GraphicsContext::setPlatformFillGradient):
+
+2008-08-20 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Darin and Alexey.
+
+ Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
+ with timeouts paused.
+ https://bugs.webkit.org/show_bug.cgi?id=20469
+
+ I attempted to clean up the memory management of PausedTimeouts, I'm not
+ sure the solution I came up with is "cleaner", but it's in some ways
+ "safer", since it no longer uses raw pointers and manual new/delete.
+
+ This also now prevents CachedPage from needlessly creating Window
+ objects when caching pages which didn't already have one. :)
+
+ I also made Chrome.cpp no longer depend on the JavaScript bindings
+ (aka JSDOMWindowBase.h), since there was no real reason for it to.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::pauseTimeouts):
+ (WebCore::JSDOMWindowBase::resumeTimeouts):
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::pauseTimeouts):
+ (WebCore::ScriptController::resumeTimeouts):
+ * bindings/js/ScriptController.h:
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ * page/Chrome.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+ * page/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
+ (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
+
+2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed compile fix
+
+ Add the stub for the Qt port.
+
+ * WebCore.pro:
+ * page/qt/AccessibilityObjectQt.cpp: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+
+2008-08-27 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Eric.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20551
+ [GTK] search popup crash
+
+ * platform/gtk/SearchPopupMenuGtk.cpp:
+ (WebCore::SearchPopupMenu::enabled):
+ Fix a search popup crasher by disabling the history popup since we
+ don't support this feature yet in the GTK+ port.
+
+2008-08-27 Alp Toker <alp@nuanti.com>
+
+ Reviewed by Eric.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20551
+ [GTK] curl crashers
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::ResourceHandleManager::startScheduledJobs):
+ Remove the resource handle from the pending list before starting the
+ job, not afterwards. Fixes crashers in the test suite.
+
+ Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
+ Test: fast/encoding/char-encoding.html
+
+2008-08-27 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by eseidel.
+
+ Fix canvas drawImage to support composite operations.
+ Composite had no effect on canvas elements like these:
+ http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
+
+ [CAIRO] Canvas composite don't work on canvas-elements.
+ https://bugs.webkit.org/show_bug.cgi?id=20548
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
+
+2008-08-27 Mario Bensi <mbensi@pleyo.com>
+
+ Reviewed by Eric Seidel.
+
+ Fix the data content of an image with a base64.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::parseDataUrl): Remove the String and use only the data
+ Vector because the data.latin1().data() convert the data content and
+ the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
+ not drawn correctly.
+
+2008-08-27 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Eric Seidel.
+
+ Crash after OK in dialog box and reloading page in secure mode
+ https://bugs.webkit.org/show_bug.cgi?id=20493
+
+ The new run loop spawned by a modal dialog causes a timer in the loader to run
+ synchronously inside didFinishLoading() deleting "this" object.
+
+ Defer all WebCore timers when a modal dialog is up. They are not
+ safe to execute.
+
+ * page/Chrome.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
+
+2008-08-27 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Memory leaks when animating transforms
+ https://bugs.webkit.org/show_bug.cgi?id=20532
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::ScaleTransformOperation::blend):
+ (WebCore::RotateTransformOperation::blend):
+ (WebCore::SkewTransformOperation::blend):
+ (WebCore::TranslateTransformOperation::blend):
+ (WebCore::MatrixTransformOperation::blend):
+ * rendering/style/RenderStyle.h:
+
+2008-08-27 Timothy Hatcher <timothy@apple.com>
+
+ Add support for support for -webkit-appearance: default-button on the Mac platform.
+
+ <rdar://problem/6173530>
+
+ Reviewed by Dave Hyatt.
+
+ * WebCore.base.exp: Export new symbols.
+ * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
+ * platform/mac/WebCoreSystemInterface.mm: Ditto.
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
+ (WebCore::RenderButton::setStyle): Ditto.
+ * rendering/RenderButton.h: Ditto.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
+ (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
+ key if the button is default, otherwise reset the key equivalent.
+ (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
+ on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
+ the window's previous default button cell when finished.
+
+2008-08-26 David Hyatt <hyatt@apple.com>
+
+ First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
+
+ Reviewed by weinig
+
+ Added fast/forms/zoomed-controls.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::addIntrinsicMargins):
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::calcPrefWidths):
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect):
+ (WebCore::RenderThemeMac::inflateRect):
+ (WebCore::RenderThemeMac::baselinePosition):
+ (WebCore::RenderThemeMac::setControlSize):
+ (WebCore::RenderThemeMac::sizeForFont):
+ (WebCore::RenderThemeMac::sizeForSystemFont):
+ (WebCore::RenderThemeMac::setFontFromControlSize):
+ (WebCore::RenderThemeMac::paintCheckbox):
+ (WebCore::RenderThemeMac::setCheckboxCellState):
+ (WebCore::RenderThemeMac::paintRadio):
+ (WebCore::RenderThemeMac::setRadioCellState):
+ (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
+ (WebCore::RenderThemeMac::adjustButtonStyle):
+ (WebCore::RenderThemeMac::setButtonCellState):
+ (WebCore::RenderThemeMac::paintButton):
+ (WebCore::RenderThemeMac::paintMenuList):
+ (WebCore::RenderThemeMac::paintMenuListButton):
+ (WebCore::RenderThemeMac::popupInternalPaddingLeft):
+ (WebCore::RenderThemeMac::popupInternalPaddingRight):
+ (WebCore::RenderThemeMac::popupInternalPaddingTop):
+ (WebCore::RenderThemeMac::popupInternalPaddingBottom):
+ (WebCore::RenderThemeMac::setPopupButtonCellState):
+ (WebCore::RenderThemeMac::paintSliderTrack):
+ (WebCore::RenderThemeMac::paintSliderThumb):
+ (WebCore::RenderThemeMac::adjustSliderThumbSize):
+ (WebCore::RenderThemeMac::paintSearchField):
+ (WebCore::RenderThemeMac::adjustSearchFieldStyle):
+ (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+
+2008-08-27 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders
+
+ <rdar://problem/6134133> - Crash when loading large movie as a standalone document
+
+ We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
+ to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
+ away the virtual address space and a crash.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
+ * loader/FrameLoaderClient.h: Added client method to get platform specific error for
+ "plugin will handle load"
+
+ * loader/MediaDocument.cpp:
+ (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
+ and cancel the WebCore-managed load
+ (WebCore::MediaTokenizer::writeRawData):
+ (WebCore::MediaTokenizer::finish):
+
+2008-08-26 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Linear timing functions should have control points 0, 0, 1, 1.
+ https://bugs.webkit.org/show_bug.cgi?id=20535
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
+ * rendering/style/RenderStyle.h:
+
+2008-08-27 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Fix file extension.
+
+2008-08-26 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
+
+ Added platform-specific accessibilityIgnoreAttachment, which allows the platform
+ to determine if an attachment is ignored through accessibility. Added equivalent
+ methods in Gtk, Win and Mac
+
+ Test: accessibility/plugin.html
+
+ * GNUmakefile.am:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/AccessibilityObject.h:
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ * page/gtk/AccessibilityObjectAtk.cpp: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ * page/mac/AccessibilityObjectMac.mm: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+ * page/mac/AccessibilityObjectWrapper.h:
+ * page/win/AccessibilityObjectWin.cpp: Added.
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+
+2008-08-26 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
+
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
+ (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
+
+2008-08-26 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
+
+ Tests: accessibility/table-notbody.html
+
+ * page/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Beth Dakin.
+
+ Fix typo.
+
+ * dom/DOMCoreException.h:
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20479
+ <rdar://problem/6167660>
+ Take image redirects into account when tainting the canvas.
+
+ Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ (WebCore::CanvasRenderingContext2D::drawImageFromRect):
+
+2008-08-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Change canvas tainting logic to ask the image if it contains
+ any resources outside of its own origin. Since there is no
+ way to determine if SVG images contain any resources outside its
+ origin, we always assume it does.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ (WebCore::CanvasRenderingContext2D::drawImageFromRect):
+ * platform/graphics/BitmapImage.h:
+ (WebCore::BitmapImage::hasSingleSecurityOrigin):
+ * platform/graphics/GeneratedImage.h:
+ (WebCore::GeneratedImage::hasSingleSecurityOrigin):
+ * platform/graphics/Image.h:
+ (WebCore::Image::hasSingleSecurityOrigin):
+ * platform/graphics/cg/PDFDocumentImage.h:
+ (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
+ * svg/graphics/SVGImage.h:
+
+2008-08-26 Maxime Britto <britto@apple.com>
+
+ Reviewed by Adele.
+
+ <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
+ This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
+ This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
+ * page/EventHandler.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
+ (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
+ * rendering/RenderLayer.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
+ (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
+ (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
+
+2008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
+ https://bugs.webkit.org/show_bug.cgi?id=20247
+
+ <rdar://problem/6118218>
+
+ Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
+ check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
+ (case insensitive for HTML elements).
+
+ Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::getAttribute):
+ * dom/NamedAttrMap.cpp:
+ (WebCore::NamedAttrMap::getNamedItem):
+ (WebCore::NamedAttrMap::getAttributeItem):
+ * dom/NamedAttrMap.h:
+
+2008-08-25 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
+ <rdar://problem/6174096>
+ Treat SVG images as dirty when drawing to a canvas.
+
+ Test: http/tests/security/canvas-remote-read-svg-image.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ (WebCore::CanvasRenderingContext2D::drawImageFromRect):
+ * platform/graphics/Image.h:
+ (WebCore::Image::isSVGImage):
+ * svg/graphics/SVGImage.h:
+ (WebCore::SVGImage::isSVGImage):
+
+2008-08-25 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20377
+ Leak in XMLHttpRequest.
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
+
+2008-08-25 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders
+
+ Speculative fix for <rdar://problem/6173217>
+
+ Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
+ Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
+ the first null check invalid.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopAllLoaders):
+
+
+2008-08-25 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
+ there is no profile, can cause crash
+
+ * page/inspector/ProfilesPanel.js:
+
+2008-08-25 Dean Jackson <dino@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Make sure 'inherit' is handled by transition property.
+ https://bugs.webkit.org/show_bug.cgi?id=20513
+
+ Test: transitions/inherit.html
+ Test: transitions/inherit-other-props.html
+
+ * css/CSSStyleSelector.cpp:
+ fix macro to check existence of list before getting size
+
+2008-08-25 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Mark.
+
+ <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
+
+ Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
+ (safely) that any class that needs finalization on the main thread will also need to be deallocated
+ on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
+ calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
+
+ * platform/mac/WebCoreObjCExtras.c:
+ (WebCoreObjCFinalizeOnMainThread):
+
+2008-08-25 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Rename CachedResource::referenced() to CachedResource::hasClients() to
+ match previous ref() -> addClient() rename.
+
+ * loader/Cache.cpp:
+ (WebCore::Cache::pruneLiveResources):
+ (WebCore::Cache::pruneDeadResources):
+ (WebCore::Cache::remove):
+ (WebCore::Cache::getStatistics):
+ (WebCore::Cache::dumpLRULists):
+ * loader/CachedResource.cpp:
+ (WebCore::CachedResource::addClient):
+ (WebCore::CachedResource::removeClient):
+ (WebCore::CachedResource::setDecodedSize):
+ (WebCore::CachedResource::setEncodedSize):
+ * loader/CachedResource.h:
+ (WebCore::CachedResource::hasClients):
+ (WebCore::CachedResource::canDelete):
+
+2008-08-25 Anthony Ricaud <rik24d@gmail.com>
+
+ Add a missing Inspector localized string for "other".
+
+ https://bugs.webkit.org/show_bug.cgi?id=20509
+
+ Reviewed by Tim Hatcher.
+
+ * English.lproj/localizedStrings.js:
+
+2008-08-22 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff, Mark and Tim.
+
+ <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
+ in the console said what file and line number they came from
+ - Lay the foundation for getting line numbers and other data from the
+ JavaScript engine.
+
+ * ForwardingHeaders/VM: Added.
+ * ForwardingHeaders/VM/Machine.h: Added.
+ * page/Console.cpp: Gather the line number and file information when
+ profileEnd has been called, but don't use it until didFinishProfiling is
+ called. We won't need to wait once we remove the profiler "zombie" mode
+ which this patch helps pave the foundation for.
+ (WebCore::Console::Console):
+ (WebCore::Console::profileEnd):
+ (WebCore::Console::finishedProfiling):
+ * page/Console.h:
+ * page/InspectorController.cpp: Modify calls to
+ addProfileMessageToConsole to satisfy the new arguments it takes.
+ (WebCore::InspectorController::finishedProfiling):
+ (WebCore::InspectorController::addProfile):
+ (WebCore::InspectorController::addProfileMessageToConsole):
+ (WebCore::InspectorController::finishedProfiling):
+ * page/InspectorController.h:
+
+2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
+ [inspector] Update the WebKit.qrc Qt resources file
+ Catchup with the changes in the directory.
+
+ * page/inspector/WebKit.qrc:
+
+2008-08-25 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Simon.
+
+ Transformed the radian to degree, to get rotate()
+ in canvas work as expected.
+
+ [Qt] Canvas.rotate() doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=20496
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::rotate):
+
+2008-08-24 Steve Falkenburg <sfalken@apple.com>
+
+ Add a "last chance" WM_TIMER to the Windows shared timer.
+
+ The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
+ Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
+ timers if a timer with an earlier expiration is already pending. This results in no timers
+ firing from that point on.
+
+ We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
+ buggy window message hook.
+
+ This timer will start when the first WM_TIMER is scheduled, and will
+ fire every 5 seconds thereafter, causing any lost timers to be fired.
+
+ Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
+ and prevents the WebFrame leak.
+
+ Reviewed by Darin Adler, Geoff Garen.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::):
+ (WebCore::TimerWindowWndProc):
+ (WebCore::setSharedTimerFireTime):
+
+2008-08-24 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
+
+ Test: fast/css/font-property-priority.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
+ to the font-property-parsing functions.
+ (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
+ changed to use it rather than the m_important member.
+ (WebCore::CSSParser::parseFontVariant): Ditto.
+ (WebCore::CSSParser::parseFontWeight): Ditto.
+ * css/CSSParser.h:
+
+2008-08-24 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where the Inspector's UI would not animate or
+ fully function because JavaScript timeouts, intervals and
+ CSS animation timers where not firing while paused at a
+ a breakpoint in the inspected page.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20042
+
+ Reviewed by Darin Adler.
+
+ Test: manual-tests/inspector/forzen-ui-while-paused.html
+
+ * page/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::pauseIfNeeded):
+ Add a call to TimerBase::fireTimersInNestedEventLoop before
+ spinning the EventLoop.
+
+2008-08-24 Rob Buis <buis@kde.org>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20324
+ A change in SVG Glyph wont show up
+
+ Invalidate the glyph cache when the d attribute is set.
+
+ Test: svg/custom/glyph-setting-d-attribute.svg
+
+ * svg/SVGGlyphElement.cpp:
+ (WebCore::SVGGlyphElement::invalidateGlyphCache):
+ (WebCore::SVGGlyphElement::parseMappedAttribute):
+ (WebCore::SVGGlyphElement::insertedIntoDocument):
+ (WebCore::SVGGlyphElement::removedFromDocument):
+ * svg/SVGGlyphElement.h:
+
+2008-08-24 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=13864
+ <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
+ beginWS and endWS before the early return to ensure that they are
+ initialized in that case.
+
+2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Rubber-stamped by Mark Rowe.
+
+ Remove modelines.
+
+ * WebCore.pro:
+ * bridge/testbindings.cpp:
+ * dom/DocPtr.h:
+ * loader/SubstituteData.h:
+ * page/Chrome.cpp:
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/Frame.h:
+ * page/FrameLoadRequest.h:
+ * page/FrameTree.cpp:
+ * page/FrameTree.h:
+ * page/Page.h:
+ * page/mac/ChromeMac.mm:
+ * platform/network/HTTPHeaderMap.h:
+ * platform/network/ResourceErrorBase.cpp:
+ * platform/network/ResourceErrorBase.h:
+ * platform/network/ResourceHandleInternal.h:
+ * platform/network/ResourceRequestBase.cpp:
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/ResourceResponseBase.cpp:
+ * platform/network/ResourceResponseBase.h:
+ * platform/network/cf/ResourceError.h:
+ * platform/network/cf/ResourceRequest.h:
+ * platform/network/cf/ResourceRequestCFNet.h:
+ * platform/network/cf/ResourceResponse.h:
+ * platform/network/cf/ResourceResponseCFNet.h:
+ * platform/network/curl/ResourceError.h:
+ * platform/network/curl/ResourceRequest.h:
+ * platform/network/curl/ResourceResponse.h:
+ * platform/network/mac/ResourceError.h:
+ * platform/network/mac/ResourceErrorMac.mm:
+ * platform/network/mac/ResourceRequest.h:
+ * platform/network/mac/ResourceRequestMac.mm:
+ * platform/network/mac/ResourceResponse.h:
+ * platform/network/mac/ResourceResponseMac.mm:
+ * platform/network/qt/ResourceError.h:
+ * platform/network/qt/ResourceRequest.h:
+ * platform/network/qt/ResourceResponse.h:
+ * platform/network/soup/CookieJarSoup.cpp:
+ * platform/network/soup/ResourceError.h:
+ * platform/network/soup/ResourceRequest.h:
+ * platform/network/soup/ResourceResponse.h:
+
+2008-08-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
+
+ Test: fast/table/vertical-align-baseline.html
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
+ baseline of the first table row, if there is one, -1 otherwise.
+ * rendering/RenderTable.h:
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::baselinePosition): Changed to follow the
+ CSS2.1 definition of the baseline of a table cell.
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
+ the baseline of the first row in the section.
+ * rendering/RenderTableSection.h:
+
+2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Add SPI to make a Windows WebView transparent.
+
+ Reviewed by Dan Bernstein.
+
+ * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
+ determines whether the created context has an alpha channel.
+ * platform/graphics/win/GraphicsContextCGWin.cpp:
+ (WebCore::CGContextWithHDC):
+
+2008-08-22 Timothy Hatcher <timothy@apple.com>
+
+ Rolls out r35834 because it caused a regression in the Inspector's
+ Console where some expressions always threw a syntax error.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20487
+
+ * page/inspector/Console.js:
+ (Console.prototype._evalInInspectedWindow): Removes parenthesis
+ around the expression.
+
+2008-08-22 Timothy Hatcher <timothy@apple.com>
+
+ Makes getStyleProperty return a value for the overflow property
+ when overflow-x and overflow-y are equal.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20485
+
+ Reviewed by Dan Bernstein.
+
+ Test: fast/css/overflow-property.html
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
+
+2008-08-22 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where while editing in the Inspector the
+ sidebar scroll position would jump to the top.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20484
+
+ Reviewed by Darin Adler.
+
+ * page/inspector/treeoutline.js:
+ (TreeOutline._removeChildren): Remove the offsetTop call that
+ was forcing a layout, since layout causes scroll positions
+ to be clamped to the new scrollHeight/Width. Layout will happen
+ normally when needed.
+
+2008-08-22 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix. Add AccessibilityTable sources.
+
+ * WebCoreSources.bkl:
+
+2008-08-21 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Jon Honeycutt and Alexey Proskuryakov.
+
+ - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
+
+ Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
+ ascent and 100% to its reported descent.
+
+2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20267
+ [GTK] Crash on some pages due to a plugin
+
+ Fix handling of badly formatted and empty plugin mime descriptions
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::fetchInfo):
+
+2008-08-21 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Follow other ports (and IE) in ImageSourceWx.cpp never to return an
+ animated GIF frame duration of less than 50ms.
+
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::frameDurationAtIndex):
+
+2008-08-21 Maxime Britto <britto@apple.com>
+
+ Reviewed by Kevin McCullough.
+
+ Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
+ https://bugs.webkit.org/show_bug.cgi?id=20451
+
+ rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
+ When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
+ This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
+
+ (WebCore::EventHandler::handleMousePressEvent): ditto
+
+2008-08-21 Anthony Ricaud <rik24d@gmail.com>
+
+ Small optimization for when the dividers in the Inspector's
+ Resources panel are updated.
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/ResourcesPanel.js:
+ (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
+ Combind a for loop and clone the divider element.
+
+2008-08-21 Chris Marrin <cmarrin@apple.com>
+
+ Allow 0 (without units) for Time eg. duration
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
+
+ Reviewed by Dave Hyatt.
+
+ Test: css1/units/zero-duration-without-units.html
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::validUnit):
+
+2008-08-21 Timothy Hatcher <timothy@apple.com>
+
+ Make deleting all text while editing a DOM attribute in
+ the Inspector delete the attribute. This also fixes
+ an exception that would happen before.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20472
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
+ Don't check for hasAttributes on the parseElement, continuing
+ through the function will correctly remove the attribute.
+ If the parseElement is null, call _editingCancelled not
+ editingCancelled, this fixes an exception.
+
+2008-08-21 Timothy Hatcher <timothy@apple.com>
+
+ Update the Inspector's Metrics pane when editing in
+ the Styles pane. This makes sure the metrics shown
+ always match what the Styles pane shows.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20470
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel): Add event listeners for
+ the "style edited" and "style property toggled" events,
+ so the Metrics pane is updated.
+ (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
+ Update the Metrics pane.
+ * page/inspector/StylesSidebarPane.js:
+ (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
+ Dispatch the "style property toggled" event.
+ (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
+ Dispatch the "style edited" event when the CSS text is restored.
+ (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
+ Dispatch the "style edited" event.
+
+2008-08-21 Timothy Hatcher <timothy@apple.com>
+
+ Make the Inspector's Metrics sidebar pane editable.
+
+ https://bugs.webkit.org/show_bug.cgi?id=17218
+ rdar://problem/5732818
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ElementsPanel.js:
+ (WebInspector.ElementsPanel): Add an event listener for
+ the "metrics edited" event, so the Styles pane is updated.
+ * page/inspector/MetricsSidebarPane.js:
+ (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
+ so future updates work. Add a double click event listener for the
+ metric values to start editing.
+ (WebInspector.MetricsSidebarPane.prototype.startEditing):
+ Call WebInspector.startEditing with some context.
+ (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
+ (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
+ Set the user input on the elements inline style. Fire the
+ "metrics edited" event.
+
+2008-08-21 Steve Falkenburg <sfalken@apple.com>
+
+ Fix a race condition in Windows timer code.
+ Timer function could end up being called with a 0 timer, leading to a Windows exception.
+
+ Don't post a timer message if one is already pending.
+
+ Reviewed by Ada Chan.
+
+ * platform/win/SharedTimerWin.cpp:
+ (WebCore::TimerWindowWndProc):
+ (WebCore::clearTimer):
+ (WebCore::queueTimerProc):
+ (WebCore::setSharedTimerFireTime):
+
+2008-08-21 Anthony Ricaud <rik24d@gmail.com>
+
+ After trying to add the expression, try again with quotes for
+ easier edition.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20466
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/ObjectPropertiesSection.js: Added an
+ evaluateExpression function.
+
+2008-08-21 Anthony Ricaud <rik24d@gmail.com>
+
+ Perform Inspector searches on search event to clear results when
+ clicking the cross to empty it. Delete the lastQuery when the field
+ is emptied in order to perform the search if exactly the same query
+ is entered next.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20462
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/inspector.js:
+
+2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Mark Rowe.
+
+ http://bugs.webkit.org/show_bug.cgi?id=19656
+ [SOUP] The gio code should call didFail() instead of
+ didFinishLoading() in case of error
+
+ In case of error call didFail() instead of didReceiveResponse() and
+ didFinishLoading().
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::networkErrorForFile):
+ (WebCore::readCallback):
+ (WebCore::openCallback):
+ (WebCore::queryInfoCallback):
+
+2008-08-20 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Jon Honeycutt.
+
+ Fix build failure.
+
+ * bridge/c/c_instance.cpp:
+ (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
+ as that is what NPEnumerationFunctionPtr is declared as accepting.
+
+2008-08-20 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
+
+ * platform/graphics/GraphicsContext.h:
+ (WebCore::):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::setImageInterpolationQuality):
+ (WebCore::GraphicsContext::imageInterpolationQuality):
+
+2008-08-20 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by John Sullivan.
+
+ - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
+ rename related methods and variables accordingly.
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameViewPrivate::FrameViewPrivate):
+ (WebCore::FrameView::shouldUpdateWhileOffscreen):
+ (WebCore::FrameView::setShouldUpdateWhileOffscreen):
+ * page/FrameView.h:
+ * platform/ScrollView.h:
+ * platform/mac/ScrollViewMac.mm:
+ (WebCore::ScrollView::updateContents):
+
+2008-08-20 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Mitzpettel
+
+ <rdar://problem/6153432> - Many images broken in Mail
+
+ This can be traced back to the preload scanner. With that change, CachedResources are created a lot
+ sooner than before and confuse the WebArchive machinery.
+
+ When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
+ such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
+ machinery and nothing is known about where the data will eventually come from.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
+ CachedResource::PreloadReferenced.
+
+2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Unreviewed compile fix
+
+ Catch up with the JSValue::type elimination.
+
+ * bridge/qt/qt_instance.cpp:
+ (KJS::Bindings::QtRuntimeObjectImp::construct):
+ (KJS::Bindings::QtInstance::defaultValue):
+ * bridge/qt/qt_runtime.cpp:
+ (KJS::Bindings::QtRuntimeConnectionMethod::call):
+
+2008-08-20 Chris Teague <chris.teague@gmail.com>
+
+ Reviewed by Mark Rowe.
+
+ Fix https://bugs.webkit.org/show_bug.cgi?id=20449
+ Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
+
+ * ChangeLog:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
+
+2008-08-20 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ getComputedStyle() for webkitTransform should return a transform
+ that does not have the transform origin baked into it.
+ https://bugs.webkit.org/show_bug.cgi?id=20464
+
+ Test: fast/css/getComputedStyle-transform.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::computedTransform):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::applyTransform):
+ * rendering/style/RenderStyle.h:
+
+2008-08-20 Josh Aas <joshmoz@gmail.com>
+
+ Reviewed and landed by Anders.
+
+ <rdar://problem/6163636>
+ rename NPCocoaEvent's "event" struct to "data" (20446)
+
+ * bridge/npapi.h:
+ (_NPCocoaEvent::):
+
+2008-08-20 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/6145626>
+ This patch fixes a number of remaining problems getting
+ disconnected frames to work correctly with markAllMatchesForText()
+ and findString(). Details inline.
+
+ This was a static helper function in Frame, but this patch requires
+ the same functionality in Editor, so I just added it as a function
+ on Node.
+ * dom/Node.cpp:
+ (WebCore::Node::isInShadowTree):
+ * dom/Node.h:
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::insideVisibleArea): Returns false if
+ excludeFromTextSearch() is true.
+
+ In a normal (non-disconnected) frame, findString returns a range of
+ the document node if the text is not found in the frame. I changed
+ firstVisibleRange and lastVisibleRange to match that behavior when
+ the text is not found
+ (WebCore::Editor::firstVisibleRange):
+ (WebCore::Editor::lastVisibleRange):
+
+ Here are the bulk of the changes in the patch. A lot of text was
+ not being found in disconnected frames because I failed to account
+ for all of the possible problems associated with shadow trees. That
+ is fixed here.
+ (WebCore::Editor::nextVisibleRange):
+ * editing/Editor.h:
+
+ excludeFromTextSearch() is new. It allows a WebKit client to mark a
+ frame as not-text-searchable through SPI.
+ * WebCore.base.exp:
+ * page/Frame.cpp:
+ (WebCore::Frame::excludeFromTextSearch):
+ (WebCore::Frame::setExcludeFromTextSearch):
+ (WebCore::FramePrivate::FramePrivate):
+ * page/Frame.h:
+ * page/FramePrivate.h:
+
+ (WebCore::Frame::findString):
+ (WebCore::Frame::markAllMatchesForText): I kept running into an
+ assertion failure in paining code because of the forced paint on
+ empty visible rects.
+
+2008-08-20 Timothy Hatcher <timothy@apple.com>
+
+ Adds a positon box to the Inspector's Metrics sidebar
+ pane. When an element is not statically positioned, there
+ is now a position box that show top, right, bottom and
+ left computed values.
+
+ Reviewed by Kevin McCullough.
+
+ * English.lproj/localizedStrings.js: Updated the strings.
+ * page/inspector/MetricsSidebarPane.js:
+ (WebInspector.MetricsSidebarPane.prototype.update):
+ Renamed the boxPartValue function to createBoxPartElement
+ and made it create the entire element. Made it understand
+ how to get position style properties. Don't use the figure dash
+ when 0px is used for positions, since the 0 is meaningful there.
+ Instead use the figure dash when a position is auto.
+ * page/inspector/inspector.css: Added a new rule for position.
+
+2008-08-20 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin
+
+ Qt build fix
+
+ * WebCore.pro:
+
+2008-08-20 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ - avoid using a deprecated NSScroller method on Leopard
+
+ * platform/mac/PlatformScrollBarMac.mm:
+ (WebCore::PlatformScrollbar::updateThumbPosition):
+ (WebCore::PlatformScrollbar::updateThumbProportion):
+
+2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ Gtk build fix
+
+ * GNUmakefile.am:
+ * page/AccessibilityTable.cpp: Change nil to 0
+ (WebCore::AccessibilityTable::cellForColumnAndRow):
+
+2008-08-19 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
+
+ * ForwardingHeaders/kjs/JSLock.h: Added.
+ * WebCore.vcproj/WebCore.vcproj:
+ * bindings/js/GCController.cpp:
+ (WebCore::collect):
+ (WebCore::GCController::gcTimerFired):
+ (WebCore::GCController::garbageCollectNow):
+ * bindings/js/JSCustomSQLStatementCallback.cpp:
+ (WebCore::JSCustomSQLStatementCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionCallback.cpp:
+ (WebCore::JSCustomSQLTransactionCallback::handleEvent):
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
+ (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
+ * bindings/js/JSCustomVoidCallback.cpp:
+ (WebCore::JSCustomVoidCallback::handleEvent):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::DOMWindowTimer::~DOMWindowTimer):
+ (WebCore::JSDOMWindowBase::clear):
+ (WebCore::JSDOMWindowBase::timerFired):
+ * bindings/js/JSEventCustom.cpp:
+ (WebCore::toJS):
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSAbstractEventListener::handleEvent):
+ * bindings/js/JSNSResolver.cpp:
+ (WebCore::JSNSResolver::lookupNamespaceURI):
+ * bindings/js/JSNodeFilterCondition.cpp:
+ (WebCore::JSNodeFilterCondition::acceptNode):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::evaluate):
+ (WebCore::ScriptController::clearWindowShell):
+ (WebCore::ScriptController::createHTMLEventHandler):
+ (WebCore::ScriptController::createSVGEventHandler):
+ (WebCore::ScriptController::initScript):
+ (WebCore::ScriptController::updateDocument):
+ (WebCore::ScriptController::bindingRootObject):
+ (WebCore::ScriptController::windowScriptNPObject):
+ (WebCore::ScriptController::createScriptObjectForPluginElement):
+ (WebCore::ScriptController::clearScriptObjects):
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::windowScriptObject):
+ * bindings/objc/WebScriptObject.mm:
+ (_didExecute):
+ (-[WebScriptObject callWebScriptMethod:withArguments:]):
+ (-[WebScriptObject evaluateWebScript:]):
+ (-[WebScriptObject setValue:forKey:]):
+ (-[WebScriptObject valueForKey:]):
+ (-[WebScriptObject removeWebScriptKey:]):
+ (-[WebScriptObject stringRepresentation]):
+ (-[WebScriptObject webScriptValueAtIndex:]):
+ (-[WebScriptObject setWebScriptValueAtIndex:value:]):
+ (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
+ * bridge/NP_jsobject.cpp:
+ (_NPN_InvokeDefault):
+ (_NPN_Invoke):
+ (_NPN_Evaluate):
+ (_NPN_GetProperty):
+ (_NPN_SetProperty):
+ (_NPN_RemoveProperty):
+ (_NPN_HasProperty):
+ (_NPN_HasMethod):
+ (_NPN_Enumerate):
+ * bridge/c/c_class.cpp:
+ (KJS::Bindings::CClass::~CClass):
+ (KJS::Bindings::CClass::methodsNamed):
+ (KJS::Bindings::CClass::fieldNamed):
+ * bridge/c/c_instance.cpp:
+ (KJS::Bindings::CInstance::invokeMethod):
+ (KJS::Bindings::CInstance::invokeDefaultMethod):
+ (KJS::Bindings::CInstance::getPropertyNames):
+ * bridge/c/c_runtime.cpp:
+ (KJS::Bindings::CField::valueFromInstance):
+ (KJS::Bindings::CField::setValueToInstance):
+ * bridge/c/c_utility.cpp:
+ (KJS::Bindings::convertValueToNPVariant):
+ (KJS::Bindings::convertNPVariantToValue):
+ * bridge/jni/jni_class.cpp:
+ (JavaClass::JavaClass):
+ (JavaClass::~JavaClass):
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::stringValue):
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::call):
+ (JavaJSObject::eval):
+ (JavaJSObject::getMember):
+ (JavaJSObject::setMember):
+ (JavaJSObject::removeMember):
+ (JavaJSObject::getSlot):
+ (JavaJSObject::setSlot):
+ (JavaJSObject::toString):
+ (JavaJSObject::convertValueToJObject):
+ (JavaJSObject::convertJObjectToValue):
+ * bridge/jni/jni_objc.mm:
+ (KJS::Bindings::dispatchJNICall):
+ * bridge/jni/jni_runtime.cpp:
+ (appendClassName):
+ (JavaMethod::signature):
+ * bridge/jni/jni_runtime.h:
+ (KJS::Bindings::JavaString::JavaString):
+ (KJS::Bindings::JavaString::_commonInit):
+ (KJS::Bindings::JavaString::~JavaString):
+ (KJS::Bindings::JavaString::UTF8String):
+ * bridge/jni/jni_utility.cpp:
+ (KJS::Bindings::convertValueToJValue):
+ * bridge/npruntime.cpp:
+ (_NPN_GetStringIdentifier):
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::moveGlobalExceptionToExecState):
+ (ObjcInstance::invokeMethod):
+ (ObjcInstance::invokeDefaultMethod):
+ (ObjcInstance::setValueOfUndefinedField):
+ (ObjcInstance::getValueOfUndefinedField):
+ * bridge/objc/objc_runtime.mm:
+ (ObjcField::valueFromInstance):
+ (ObjcField::setValueToInstance):
+ * bridge/objc/objc_utility.mm:
+ (KJS::Bindings::convertValueToObjcValue):
+ (KJS::Bindings::convertNSStringToString):
+ (KJS::Bindings::convertObjcValueToValue):
+ * bridge/qt/qt_instance.cpp:
+ (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
+ (KJS::Bindings::QtInstance::~QtInstance):
+ (KJS::Bindings::QtInstance::getQtInstance):
+ (KJS::Bindings::QtInstance::getRuntimeObject):
+ * bridge/qt/qt_runtime.cpp:
+ (KJS::Bindings::convertValueToQVariant):
+ (KJS::Bindings::convertQVariantToValue):
+ (KJS::Bindings::QtRuntimeMetaMethod::call):
+ (KJS::Bindings::QtRuntimeConnectionMethod::call):
+ (KJS::Bindings::QtConnectionObject::QtConnectionObject):
+ (KJS::Bindings::QtConnectionObject::execute):
+ * bridge/runtime.cpp:
+ (KJS::Bindings::Instance::createRuntimeObject):
+ * bridge/testbindings.cpp:
+ (main):
+ * bridge/testbindings.mm:
+ (main):
+ * bridge/testqtbindings.cpp:
+ (main):
+ * dom/Document.cpp:
+ (WebCore::Document::~Document):
+ * dom/Node.cpp:
+ (WebCore::Node::setDocument):
+ * history/CachedPage.cpp:
+ (WebCore::CachedPage::CachedPage):
+ (WebCore::CachedPage::restore):
+ (WebCore::CachedPage::clear):
+ * loader/FrameLoader.cpp:
+ (WebCore::getString):
+ * page/InspectorController.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
+ (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
+ (WebCore::getResourceDocumentNode):
+ (WebCore::search):
+ (WebCore::inspectedWindow):
+ (WebCore::wrapCallback):
+ (WebCore::currentCallFrame):
+ (WebCore::profiles):
+ (WebCore::InspectorController::focusNode):
+ (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
+ (WebCore::InspectorController::addDatabaseScriptResource):
+ (WebCore::InspectorController::addScriptProfile):
+ * page/JavaScriptCallFrame.cpp:
+ (WebCore::JavaScriptCallFrame::evaluate):
+ * page/JavaScriptProfileNode.cpp:
+ (WebCore::getTotalTime):
+ (WebCore::getSelfTime):
+ (WebCore::getTotalPercent):
+ (WebCore::getSelfPercent):
+ (WebCore::getNumberOfCalls):
+ (WebCore::getChildren):
+ (WebCore::getVisible):
+ * page/Page.cpp:
+ * page/mac/FrameMac.mm:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::start):
+ (WebCore::getString):
+ (WebCore::PluginView::performRequest):
+ (WebCore::PluginView::bindingInstance):
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::paint):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::init):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ (WebCore::PluginView::init):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::dispatchNPEvent):
+ (WebCore::PluginView::handleKeyboardEvent):
+ (WebCore::PluginView::handleMouseEvent):
+ (WebCore::PluginView::setNPWindowRect):
+ (WebCore::PluginView::stop):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::clearResponse):
+ (WebCore::XMLHttpRequest::didFinishLoading):
+ (WebCore::XMLHttpRequest::didReceiveData):
+
+2008-08-19 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ Add the beginnings of Skia graphics support to WebCore
+ as I try to begin the long process of un-forking the changes
+ needed to WebCore to make Andriod's WebCore build.
+
+ I'll follow this up with actual *Skia.cpp files in a separate patch.
+
+ * platform/graphics/AffineTransform.h:
+ * platform/graphics/FloatPoint.h:
+ * platform/graphics/FloatRect.h:
+ * platform/graphics/Gradient.h:
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/Image.h:
+ * platform/graphics/ImageBuffer.h:
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/IntPoint.h:
+ * platform/graphics/IntRect.h:
+ * platform/graphics/Path.h:
+ * platform/graphics/Pattern.h:
+ * svg/graphics/SVGPaintServerPattern.h:
+ * svg/graphics/SVGPaintServerSolid.h:
+
+2008-08-19 Steve Falkenburg <sfalken@apple.com>
+
+ Fix Windows build more.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2008-08-19 Steve Falkenburg <sfalken@apple.com>
+
+ Fix Windows build.
+
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+
+2008-08-19 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ <rdar://problem/4003764> Expose tables as AXTables
+
+ Tests: accessibility/table-attributes.html
+ accessibility/table-cell-spans.html
+ accessibility/table-cells.html
+ accessibility/table-detection.html
+ accessibility/table-sections.html
+ accessibility/table-with-rules.html
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::get):
+ * page/AccessibilityObject.h:
+ (WebCore::):
+ (WebCore::AccessibilityObject::isDataTable):
+ (WebCore::AccessibilityObject::isTableRow):
+ (WebCore::AccessibilityObject::isTableColumn):
+ (WebCore::AccessibilityObject::isTableCell):
+ * page/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
+ * page/AccessibilityTable.cpp: Added.
+ (WebCore::AccessibilityTable::AccessibilityTable):
+ (WebCore::AccessibilityTable::~AccessibilityTable):
+ (WebCore::AccessibilityTable::create):
+ (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+ (WebCore::AccessibilityTable::clearChildren):
+ (WebCore::AccessibilityTable::addChildren):
+ (WebCore::AccessibilityTable::headerContainer):
+ (WebCore::AccessibilityTable::columns):
+ (WebCore::AccessibilityTable::rows):
+ (WebCore::AccessibilityTable::rowHeaders):
+ (WebCore::AccessibilityTable::columnHeaders):
+ (WebCore::AccessibilityTable::cells):
+ (WebCore::AccessibilityTable::columnCount):
+ (WebCore::AccessibilityTable::rowCount):
+ (WebCore::AccessibilityTable::cellForColumnAndRow):
+ (WebCore::AccessibilityTable::roleValue):
+ (WebCore::AccessibilityTable::accessibilityIsIgnored):
+ (WebCore::AccessibilityTable::title):
+ (WebCore::AccessibilityTable::isDataTable):
+ * page/AccessibilityTable.h: Added.
+ * page/AccessibilityTableCell.cpp: Added.
+ (WebCore::AccessibilityTableCell::AccessibilityTableCell):
+ (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
+ (WebCore::AccessibilityTableCell::create):
+ (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
+ (WebCore::AccessibilityTableCell::rowIndexRange):
+ (WebCore::AccessibilityTableCell::columnIndexRange):
+ * page/AccessibilityTableCell.h: Added.
+ (WebCore::AccessibilityTableCell::isTableCell):
+ (WebCore::AccessibilityTableCell::roleValue):
+ * page/AccessibilityTableColumn.cpp: Added.
+ (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
+ (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
+ (WebCore::AccessibilityTableColumn::create):
+ (WebCore::AccessibilityTableColumn::setParentTable):
+ (WebCore::AccessibilityTableColumn::elementRect):
+ (WebCore::AccessibilityTableColumn::size):
+ (WebCore::AccessibilityTableColumn::children):
+ (WebCore::AccessibilityTableColumn::headerObject):
+ (WebCore::AccessibilityTableColumn::headerObjectForSection):
+ (WebCore::AccessibilityTableColumn::addChildren):
+ * page/AccessibilityTableColumn.h: Added.
+ (WebCore::AccessibilityTableColumn::parentObject):
+ (WebCore::AccessibilityTableColumn::roleValue):
+ (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
+ (WebCore::AccessibilityTableColumn::isTableColumn):
+ (WebCore::AccessibilityTableColumn::setColumnIndex):
+ (WebCore::AccessibilityTableColumn::columnIndex):
+ * page/AccessibilityTableHeaderContainer.cpp: Added.
+ (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
+ (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
+ (WebCore::AccessibilityTableHeaderContainer::create):
+ (WebCore::AccessibilityTableHeaderContainer::children):
+ (WebCore::AccessibilityTableHeaderContainer::elementRect):
+ (WebCore::AccessibilityTableHeaderContainer::size):
+ (WebCore::AccessibilityTableHeaderContainer::addChildren):
+ * page/AccessibilityTableHeaderContainer.h: Added.
+ (WebCore::AccessibilityTableHeaderContainer::roleValue):
+ (WebCore::AccessibilityTableHeaderContainer::setParentTable):
+ (WebCore::AccessibilityTableHeaderContainer::parentObject):
+ (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
+ * page/AccessibilityTableRow.cpp: Added.
+ (WebCore::AccessibilityTableRow::AccessibilityTableRow):
+ (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
+ (WebCore::AccessibilityTableRow::create):
+ (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
+ (WebCore::AccessibilityTableRow::headerObject):
+ * page/AccessibilityTableRow.h: Added.
+ (WebCore::AccessibilityTableRow::isTableRow):
+ (WebCore::AccessibilityTableRow::roleValue):
+ (WebCore::AccessibilityTableRow::setRowIndex):
+ (WebCore::AccessibilityTableRow::rowIndex):
+ * page/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
+ (RoleEntry::):
+ (-[AccessibilityObjectWrapper roleDescription]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+ (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
+
+2008-08-19 Steve Falkenburg <sfalken@apple.com>
+
+ Build fix.
+ Add buildfailed support to stop builds early (preventing inaccurate error messages).
+ Add missing post-build rule to Release.
+
+ * WebCore.vcproj/QTMovieWin.vcproj:
+
+2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
+
+ Added support for console.count in the inspector.
+
+ Reviewed by Geoff Garen.
+
+ * page/Console.cpp:
+ (WebCore::Console::count):
+ * page/Console.h:
+ * page/Console.idl: Added console.count.
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad): Clears m_counts.
+ (WebCore::InspectorController::count): Updates the count number
+ sing "title@source:line" as the identifier, and adds a
+ message to the console.
+ * page/InspectorController.h: Added m_counts.
+
+2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
+
+ Clear console.time timers when changing page.
+
+ Reviewed by Geoff Garen.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
+
+2008-08-19 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele.
+
+ Fix for <rdar://problem/6154695> Full-page movies flicker while playing
+ https://bugs.webkit.org/show_bug.cgi?id=20404
+
+ Ignore setVisible() when visibility doesn't change.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
+ (WebCore::MediaPlayerPrivate::setVisible):
+
+2008-08-19 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug in the Profile view where switching sort order, then
+ switching from heavy to tree mode would show the tree in the
+ previous sort order.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20441
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ProfileView.js:
+ (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
+ on the next profile before assigning it to this.profile.
+ (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
+ (WebInspector.ProfileView.prototype._sortProfile): Moves from
+ _sortData and takes a profile argument. If the profile passed in
+ matches the this.profile, then call refresh.
+
+2008-08-18 Timothy Hatcher <timothy@apple.com>
+
+ Changed the default sort order now that heavy view is the default.
+ Also fixes a bug where the heavy profile was not sorted at first.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20440
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ProfileView.js:
+ (WebInspector.ProfileView): Changed the default sort column. Also assign
+ heavyProfile to profile, so the sortSelfTimeDescending call happens
+ on the heavy profile before assigning to this.profile.
+
+2008-08-18 Timothy Hatcher <timothy@apple.com>
+
+ Add support for editing DOM properties and scope variables by double
+ clicking a property to enter edit mode.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20415
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertiesSection): Set editable to true by default.
+ (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
+ Factored out code into update, and calls update.
+ (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
+ Call removeChildren since this method can be called multiple times now.
+ (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
+ gets made later in onattach.
+ (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
+ if shouldRefreshChildren is true. Call removeChildren since this method can be
+ called multiple times now.
+ (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
+ (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
+ (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
+ this element (code moved from the constructor.)
+ (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
+ sibling property elements.
+ (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
+ WebInspector.startEditing after rememebring some context.
+ (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
+ for the list element, since it might have scrolled during editing.
+ (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
+ then restore the state from the context. Then call update to restore the title.
+ (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
+ if the user input and the previous input are the same. Call editingEnded, then call applyExpression
+ to commit the user input.
+ (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
+ and stores the result on the object for the property name of this element. If the expression is
+ empty, delete the property and remove the tree element.
+ * page/inspector/ScopeChainSidebarPane.js:
+ (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
+ property on each ObjectPropertiesSection.
+ (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
+ since it is now implemented.
+ * page/inspector/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
+ that defaults to true if omitted. It specifies whether to call update on the scope chain.
+ * page/inspector/inspector.css: New styles.
+ * page/inspector/treeoutline.js:
+ (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
+ change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
+
+2008-08-18 Timothy Hatcher <timothy@apple.com>
+
+ Surround the expression to be evaluated in parenthesis so the
+ result of the eval is the result of the whole expression not
+ the last potential sub-expression. So evaluating {x: 123}
+ will show the Object not 123.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20428
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/Console.js:
+ (Console.prototype._evalInInspectedWindow): Add parenthesis
+ around the expression. And add couple comments.
+
+2008-08-19 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff.
+
+ -Implement a page() function to extract a common code pattern.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Console.cpp:
+ (WebCore::Console::addMessage):
+ (WebCore::Console::error):
+ (WebCore::Console::info):
+ (WebCore::Console::log):
+ (WebCore::Console::dir):
+ (WebCore::Console::assertCondition):
+ (WebCore::Console::time):
+ (WebCore::Console::timeEnd):
+ (WebCore::Console::group):
+ (WebCore::Console::groupEnd):
+ (WebCore::Console::finishedProfiling):
+ (WebCore::Console::warn):
+ (WebCore::Console::framePage):
+ * page/Console.h:
+
+2008-08-12 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoff.
+
+ - eliminate JSValue::type()
+
+ * bridge/c/c_instance.cpp:
+ (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
+ argument instead of JSType argument. Removed unneeded code to handle
+ boolean, since that's never passed.
+ * bridge/c/c_instance.h: Ditto.
+
+ * bridge/c/c_utility.cpp:
+ (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
+ instead of JSValue::type(). Removed unneeded code to handle
+ "unspecified".
+
+ * bridge/jni/jni_instance.cpp:
+ (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
+ instead of JSType argument. Removed unneeded code to handle boolean.
+ * bridge/jni/jni_instance.h: Ditto.
+
+ * bridge/jni/jni_jsobject.mm:
+ (JavaJSObject::convertValueToJObject): Use JSValue::is functions
+ instead of JSValue::type().
+
+ * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
+ instead of JSType argument. Removed unused argument.
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
+ (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
+ instead of JSType argument. Removed unneeded code to handle boolean
+ and another dead code path for unknown types.
+
+ * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
+ instead of JSType argument. Removed override of type() that caused
+ the fallback object to return "UndefinedType" when there is no
+ invokeUndefinedMethodFromWebScript:withArguments: method defined.
+ That didn't accomplish much, since most checks for undefined don't
+ ever call type().
+ * bridge/objc/objc_runtime.mm:
+ (ObjcFallbackObjectImp::defaultValue): Ditto.
+
+ * bridge/qt/qt_instance.cpp:
+ (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
+ argument instead of JSType argument. Removed unneeded code to handle
+ boolean.
+ * bridge/qt/qt_instance.h: Ditto.
+
+ * bridge/runtime.h:
+ (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
+ unsed argument.
+ * bridge/runtime_object.cpp:
+ (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
+ argument instead of JSType argument.
+ * bridge/runtime_object.h: Ditto.
+
+2008-08-18 Maxime Britto <britto@apple.com>
+
+ Reviewed by Adele.
+
+ <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
+ Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
+ We shouldn't be able to create another window while we are in pan scrolling.
+ Other browsers behaviors :
+ FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
+ IE7 : Keys are not disabled but stops immediately the panning.
+ This patch matches FF3 behavior by disabling every key but the esc key.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
+ (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
+
+2008-08-18 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
+
+ Test: fast/replaced/max-width-percent.html
+
+ Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
+ When false, max-width is not factored into the
+ calculation.
+ Changed RenderReplaced and subclasses' calcPrefWidths() to call
+ calcReplacedWidth(false) and then apply max-width only if it has a
+ fixed, positive value.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcReplacedWidth):
+ * rendering/RenderBox.h:
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::calcReplacedWidth):
+ (WebCore::RenderImage::calcPrefWidths):
+ * rendering/RenderImage.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::calcPrefWidths):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::calcPrefWidths):
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::calcReplacedWidth):
+ (WebCore::RenderVideo::calcPrefWidths):
+ * rendering/RenderVideo.h:
+
+2008-08-18 Daniel Macks <dmacks@netspace.org>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20410
+ More portable/self-documenting replacement for SIZE_MAX.
+
+ * platform/network/curl/FormDataStreamCurl.cpp:
+ (WebCore::FormDataStream::read):
+
+2008-08-18 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ Need to make sure we have an Animation in the AnimationList
+ before setting the initial value.
+ https://bugs.webkit.org/show_bug.cgi?id=20408
+
+ Test: fast/css/transition_shorthand_parsing.html
+
+ * css/CSSStyleSelector.cpp:
+
+2008-08-18 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
+ is another profile.
+
+ * page/inspector/ProfilesPanel.js:
+
+2008-08-18 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Geoff.
+
+ <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
+ all console messages
+
+ * page/inspector/Console.js:
+
+2008-08-18 Dirk Schulze <vbs85@gmx.de>
+
+ Reviewed by Eric Seidel.
+
+ Fixed Canvas for Cairo. Stroke and fill colors didn't work after
+ the canvas clean up.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20405
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::fill):
+ (WebCore::CanvasRenderingContext2D::stroke):
+ (WebCore::CanvasRenderingContext2D::fillRect):
+
+2008-08-17 Timothy Hatcher <timothy@apple.com>
+
+ Complete in scope variables in the Console when paused.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19115
+
+ Reviewed by Geoffrey Garen.
+
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype.completions): If the expressionString
+ is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
+ to get an object that declares all the in scope variables. That way
+ "top level" expressions are completed.
+ * page/inspector/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
+ Return an object that has all the variables that are in scope for the
+ selected call frame. The value of each property is just true.
+ The return object is useful for quick lookups or auto completion.
+
+2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
+
+ Not reviewed.
+
+ Speculative Qt build fix.
+
+ * bridge/qt/qt_runtime.cpp:
+ (KJS::Bindings::convertValueToQVariant):
+ (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
+
+2008-08-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Updated project files to XCode 3.1.
+
+ * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
+
+2008-08-17 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Cameron Zwarich.
+
+ Made room for a free word in JSCell.
+
+ Changed JSDOMWindowBase to store its auxiliary data in a subclass of
+ JSGlobalData, so the two could share a pointer.
+
+ Added a bunch of ASSERTs, to help catch over-sized objects.
+
+2008-08-15 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Disable dead code stripping in debug builds.
+
+ * Configurations/Base.xcconfig:
+ * WebCore.xcodeproj/project.pbxproj:
+
+2008-08-15 Mark Rowe <mrowe@apple.com>
+
+ Rubber-stamped by Geoff Garen.
+
+ <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
+
+ * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
+ between the Debug configuration and debug Production variant.
+ * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
+
+2008-08-15 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Anders.
+
+ Don't start preloading body resources before the head is complete. This prevents
+ body preloads from slowing down initial display when there is limited amount
+ of bandwidth available.
+
+ Works by queuing up found body preloads to DocLoader and only issuing them
+ after document has rendering.
+
+ With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
+ without affecting complete load time.
+
+ * html/PreloadScanner.cpp:
+ (WebCore::PreloadScanner::PreloadScanner):
+ (WebCore::PreloadScanner::scanningBody):
+ (WebCore::PreloadScanner::emitTag):
+ (WebCore::PreloadScanner::emitCSSRule):
+ * html/PreloadScanner.h:
+ * loader/DocLoader.cpp:
+ (WebCore::DocLoader::preload):
+ (WebCore::DocLoader::checkForPendingPreloads):
+ (WebCore::DocLoader::requestPreload):
+ * loader/DocLoader.h:
+ * loader/loader.cpp:
+ (WebCore::Loader::Host::didFinishLoading):
+ (WebCore::Loader::Host::didFail):
+
+2008-08-15 Ada Chan <adachan@apple.com>
+
+ Use item's computed style if the render style is 0 before falling back to the <select>'s style.
+ This way style set on an <hr> within a <select> will be honored.
+
+ Reviewed by Dave Hyatt and Dan Bernstein.
+
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::itemStyle):
+
+2008-08-15 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Oliver.
+
+ Some loader performance tweaks:
+ - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
+ Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
+ to not delay rendering.
+ - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
+ can take long time when latency is high so it is good to get started early.
+ - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
+ load queues. Issue remaining loads to the network layer.
+
+ * loader/loader.cpp:
+ (WebCore::Loader::determinePriority):
+ (WebCore::Loader::load):
+ (WebCore::Loader::Host::servePendingRequests):
+ * loader/loader.h:
+
+2008-08-15 Timothy Hatcher <timothy@apple.com>
+
+ Detach the script debugger when the Web Inspector's window closes.
+ This has always been the intended design, but never fully implemented.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20402
+
+ Reviewed by Adam Roben.
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
+ if the window is no longer visible.
+
+2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fixes: compile with QT_NO_CONTEXTMENU
+
+ * platform/qt/PlatformMouseEventQt.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/qt/PlatformScrollBarQt.cpp:
+ (WebCore::PlatformScrollbar::handleMouseMoveEvent):
+ (WebCore::PlatformScrollbar::handleContextMenuEvent):
+
+2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fixes: compile with QT_NO_WHEELEVENT
+
+ * platform/qt/WheelEventQt.cpp:
+ (WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
+2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
+
+ Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
+
+ https://bugs.webkit.org/show_bug.cgi?id=20210
+
+ Reviewed by Tim Hatcher.
+
+ * page/Console.cpp:
+ (WebCore::Console::group):
+ (WebCore::Console::groupEnd):
+ * page/Console.h:
+ (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::startGroup): Increments group level by
+ one and adds console message with StartGroupMessaageLevel.
+ (WebCore::InspectorController::endGroup): Decrements group level by one
+ and adds console message with EndGroupMessaageLevel.
+ * page/InspectorController.h:
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
+ if the message is StartGroupMessaageLevel.
+ (WebInspector.ConsoleMessage.prototype.toMessageElement):
+ (WebInspector.ConsoleGroup.prototype.addMessage):
+ * page/inspector/inspector.js:
+
+2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
+
+ Adds support for console.dir to the Inspector
+
+ https://bugs.webkit.org/show_bug.cgi?id=19155
+
+ Reviewed by Tim Hatcher.
+
+ * bindings/js/JSConsoleCustom.cpp:
+ (WebCore::JSConsole::dir):
+ * page/Console.cpp:
+ (WebCore::Console::dir):
+ * page/Console.h: Added ObjectMessageLevel.
+ * page/Console.idl: Added console.dir.
+ * page/inspector/Console.js:
+ (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
+ ObjectPropertiesSection if the MessageLevel is Object.
+ * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
+ used on primitive data types.
+ * page/inspector/inspector.css:
+
+2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
+
+ Adds support for clear() in the Inspector console.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19873
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/Console.js:
+
+2008-08-15 Anthony Ricaud <rik24d@gmail.com>
+
+ Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
+
+ Platform distinction and modifier key matching adjusted
+ by Daniel Jalkut <jalkut@red-sweater.com>
+
+ Bug 16313: text search (find) keybindings should work in the Web Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=16313
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/inspector.js: Added a case for the F key
+
+2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
+
+ Fix for error when the string doesn't contain a webkit-profile link.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20399
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/inspector.js:
+
+2008-08-15 Timothy Hatcher <timothy@apple.com>
+
+ Fixes two bugs where JavaScript could be executed from the page
+ while the debugger is paused.
+
+ The first issue was JSLazyEventListener not checking the paused
+ state before parsing the code.
+
+ The second issue was with the PageGroup version of
+ JavaScriptDebugServer::setJavaScriptPaused always passing false
+ to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
+ and not the paused argument.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20284
+
+ Reviewed by Adam Roben.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSLazyEventListener::parseCode): Check the paused
+ state of the ScriptController. Return early if paused.
+ * manual-tests/inspector/debugger-execution-while-paused.html: Added.
+ * page/JavaScriptDebugServer.cpp:
+ (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
+ Pass the paused argument to the Page version of setJavaScriptPaused.
+
+2008-08-15 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Geoff Garen.
+
+ JSStringRef is created context-free, but can get linked to one via an identifier table,
+ breaking an implicit API contract.
+
+ * page/InspectorController.cpp:
+ (WebCore::jsStringRef):
+ (WebCore::InspectorController::didParseSource):
+ (WebCore::InspectorController::failedToParseSource):
+ * page/JavaScriptProfile.cpp:
+ (WebCore::getTitleCallback):
+ Updated for JavaScriptCore changes.
+
+2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
+ an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
+
+ * platform/graphics/AffineTransform.h:
+
+2008-08-14 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
+ <video> elements on Windows never becomes visible when a page is restored from the cache
+
+ Always pass "set" calls down to MediaPlayerPrivate instead of only when the
+ value is different from the cached value. Let the implementation decide when
+ to avoid work because nothing has changed.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::setVolume):
+ (WebCore::MediaPlayer::setRate):
+ (WebCore::MediaPlayer::setRect):
+ (WebCore::MediaPlayer::setVisible):
+
+2008-08-14 Keishi Hattori <casey.hattori@gmail.com>
+
+ Make Firebug command line API respect predefined variables.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20385
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/Console.js:
+
+2008-08-14 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Geoffrey Garen and Timothy Hatcher.
+
+ Allow programatically setting the HTMLTokenizers time delay and chunk size
+ which are used for determining how aggressively we yield.
+
+ * WebCore.base.exp:
+ * html/HTMLTokenizer.cpp:
+ (WebCore::HTMLTokenizer::begin):
+ (WebCore::HTMLTokenizer::continueProcessing):
+ * html/HTMLTokenizer.h:
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
+ (WebCore::Page::setCustomHTMLTokenizerChunkSize):
+ * page/Page.h:
+ (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
+ (WebCore::Page::customHTMLTokenizerTimeDelay):
+ (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
+ (WebCore::Page::customHTMLTokenizerChunkSize):
+
+2008-08-14 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Beth.
+
+ Move us one step closer to cross-platform svg/graphics code
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/CanvasStyle.cpp:
+ * platform/graphics/Color.cpp:
+ (WebCore::colorWithOverrideAlpha):
+ * platform/graphics/Color.h:
+ * svg/graphics/cg/CgSupport.cpp:
+ (WebCore::applyStrokeStyleToContext):
+ (WebCore::strokeBoundingBox):
+ * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
+ (WebCore::SVGPaintServerSolid::setup):
+
+2008-08-14 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Alexey.
+
+ Remove un-need includes from HTMLCanvas and use the
+ Gradient platform abstraction in one place in CanvasStyle
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::fillRect):
+ * html/CanvasStyle.cpp:
+ * html/HTMLCanvasElement.cpp:
+
+2008-08-14 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Alexey.
+
+ Clean up GlyphBuffer.h, removing more #ifdefs
+
+ * platform/graphics/GlyphBuffer.h:
+ (WebCore::GlyphBuffer::glyphAt):
+ (WebCore::GlyphBuffer::advanceAt):
+ (WebCore::GlyphBuffer::add):
+
+2008-08-14 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam.
+
+ Clean up AffineTransform.h, removing #ifdefs
+
+ * platform/graphics/AffineTransform.h:
+ * platform/graphics/cairo/AffineTransformCairo.cpp:
+ * platform/graphics/cg/AffineTransformCG.cpp:
+ * platform/graphics/qt/AffineTransformQt.cpp:
+ * platform/graphics/wx/AffineTransformWx.cpp:
+
+2008-08-14 Dan Bernstein <mitz@apple.com>
+
+ - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
+
+ * platform/graphics/cairo/ImageSourceCairo.cpp:
+ (WebCore::ImageSource::frameSizeAtIndex):
+ * platform/graphics/qt/ImageSourceQt.cpp:
+ (WebCore::ImageSource::frameSizeAtIndex):
+ * platform/graphics/wx/ImageSourceWx.cpp:
+ (WebCore::ImageSource::frameSizeAtIndex):
+
+2008-08-14 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Brady Eidson.
+
+ - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::BitmapImage): Added initialization of
+ m_hasUniformFrameSize.
+ (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
+ cached frame for use in decoded size computation and for setting
+ m_hasUniformFrameSize.
+ (WebCore::BitmapImage::currentFrameSize): Added.
+ (WebCore::BitmapImage::dataChanged): Added code to reset
+ m_hasUniformFrameSize.
+ * platform/graphics/BitmapImage.h: Added currentFrameSize() and
+ m_hasUniformFrameSize.
+ * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
+ * platform/graphics/cg/ImageCG.cpp:
+ (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
+ fixes the bug, which resulted from assuming that the frame being drawn
+ was the same size as the first frame.
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
+ changed to get the size of the frame at the given index.
+ (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
+
+2008-08-13 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Eric Seidel
+
+ Fix @font-face inside @media rule crash.
+ https://bugs.webkit.org/show_bug.cgi?id=20367
+
+ Test: fast/css/font-face-in-media-rule.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSRuleSet::addRulesFromSheet):
+
+2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fixes after recent changes to Canvas and Image classes.
+
+ * platform/graphics/Pattern.h:
+ * platform/graphics/wx/GradientWx.cpp:
+ (WebCore::Gradient::fill):
+ * platform/graphics/wx/GraphicsContextWx.cpp:
+ (WebCore::GraphicsContext::applyFillPattern):
+ (WebCore::GraphicsContext::applyStrokePattern):
+ * platform/graphics/wx/ImageBufferWx.cpp:
+ (WebCore::ImageBuffer::image):
+ * platform/graphics/wx/ImageWx.cpp:
+ (WebCore::Image::loadPlatformResource):
+
+2008-08-14 Maxime Britto <britto@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ rdar://6102511
+ When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
+ IE and FF are both preventing the keyboard event to interact with the page while scrolling.
+ Some differences exist between them concerning the kind of key which is pressed :
+ IE7 : every key leads to a stop of the panning
+ FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
+ For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
+
+2008-08-14 Christian Dywan <christian@twotoasts.de>
+
+ Gtk+/ Cairo build fix, patch by Dirk Schulze.
+
+ * html/CanvasStyle.cpp:
+ * platform/graphics/cairo/PatternCairo.cpp:
+ (WebCore::Pattern::createPlatformPattern):
+ * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
+
+2008-08-14 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ <rdar://problem/6115819> Notify of profile in console
+
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::addProfile):
+ (WebCore::InspectorController::addProfileMessageToConsole): Called by
+ addProfile this is the function that adds a message to the console that
+ a profile finished.
+ * page/InspectorController.h:
+ * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
+ the console log to the profile in the web inspector.
+ (WebCore::getUniqueIdCallback):
+ (WebCore::ProfileClass):
+ * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
+ Id to bring up the requested profile. Also select and reveal the
+ profile in the profile panel. And created displayTitleForProfileLink()
+ which formats a title taking into account if it's user initiated or if
+ there are multiples. Lasty, I put the user initiated profile in a
+ variable.
+ * page/inspector/inspector.js: Make the profile title be a clickable
+ link that will take the user to the identified profile. Also expose
+ the count of user initiated profiles so they can be displayed in the
+ console with the correct count.
+
+2008-08-14 Timothy Hatcher <timothy@apple.com>
+
+ Avoid formating ConsoleMessages twice unless the message will be
+ displayed in bubbles of a SourceFrame.
+
+ Reviewed by Kevin McCullough.
+
+ * page/inspector/Console.js:
+ (WebInspector.ConsoleMessage): Only format the plain text message
+ if the URL and line are valid and the level is error or warning.
+ (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
+ Helper to test for error or warning level.
+ * page/inspector/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.addMessage): Don't add the
+ message if there is no message or valid line or if the msg
+ isn't an error or warning.
+
+2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ partial Gtk build fix, not reviewed
+
+ * platform/graphics/cairo/PatternCairo.cpp:
+
+2008-08-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix style issue.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::pickMedia):
+
+2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Build fix for Cairo, not reviewed. (exposed by gtk build slave)
+ Continue Erics build fixes, after the Image cleanup.
+
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::image):
+
+2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Build fix for Qt, not reviewed.
+ Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
+
+ * dom/XMLTokenizer.cpp:
+ (WebCore::eventuallyMarkAsParserCreated): Was erre
+
+2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Build fix, not reviewed.
+ Add ScriptElement.cpp to Gtk build.
+
+ * GNUmakefile.am:
+
+2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Eric.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
+
+ Refactor HTMLScriptElement's code into a common base class: ScriptElement.
+ SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
+
+ This resolves code duplications and allows us to completly replace the old
+ SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
+
+ As ScriptElement, doesn't actually inherit from Element, we may want to rename
+ it, though StyleElement uses the same naming convention, so I left it as is for now.
+ Eventually we'll rename both files in future.
+
+ No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
+
+ * WebCore.pro: Add new ScriptElement.cpp to build.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * WebCoreSources.bkl: Dutto.
+ * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
+ (WebCore::ScriptElement::insertedIntoDocument):
+ (WebCore::ScriptElement::removedFromDocument):
+ (WebCore::ScriptElement::childrenChanged):
+ (WebCore::ScriptElement::finishParsingChildren):
+ (WebCore::ScriptElement::handleSourceAttribute):
+ (WebCore::isSupportedJavaScriptLanguage):
+ (WebCore::ScriptElementData::ScriptElementData):
+ (WebCore::ScriptElementData::~ScriptElementData):
+ (WebCore::ScriptElementData::requestScript):
+ (WebCore::ScriptElementData::evaluateScript):
+ (WebCore::ScriptElementData::stopLoadRequest):
+ (WebCore::ScriptElementData::notifyFinished):
+ (WebCore::ScriptElementData::ignoresLoadRequest):
+ (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
+ (WebCore::ScriptElementData::scriptCharset):
+ (WebCore::ScriptElementData::scriptContent):
+ * dom/ScriptElement.h: Added.
+ (WebCore::ScriptElement::ScriptElement):
+ (WebCore::ScriptElement::~ScriptElement):
+ (WebCore::ScriptElementData::element):
+ (WebCore::ScriptElementData::createdByParser):
+ (WebCore::ScriptElementData::setCreatedByParser):
+ * dom/XMLTokenizer.cpp:
+ (WebCore::isScriptElement):
+ (WebCore::castToScriptElement):
+ (WebCore::eventuallyMarkAsParserCreated):
+ (WebCore::XMLTokenizer::startElementNs):
+ (WebCore::XMLTokenizer::endElementNs):
+ (WebCore::createXHTMLParserErrorHeader):
+ (WebCore::XMLTokenizer::insertErrorMessageBlock):
+ * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
+ (WebCore::HTMLScriptElement::HTMLScriptElement):
+ (WebCore::HTMLScriptElement::~HTMLScriptElement):
+ (WebCore::HTMLScriptElement::isURLAttribute):
+ (WebCore::HTMLScriptElement::setCreatedByParser):
+ (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
+ (WebCore::HTMLScriptElement::childrenChanged):
+ (WebCore::HTMLScriptElement::parseMappedAttribute):
+ (WebCore::HTMLScriptElement::finishParsingChildren):
+ (WebCore::HTMLScriptElement::insertedIntoDocument):
+ (WebCore::HTMLScriptElement::removedFromDocument):
+ (WebCore::HTMLScriptElement::text):
+ (WebCore::HTMLScriptElement::setText):
+ (WebCore::HTMLScriptElement::setHtmlFor):
+ (WebCore::HTMLScriptElement::setEvent):
+ (WebCore::HTMLScriptElement::charset):
+ (WebCore::HTMLScriptElement::src):
+ (WebCore::HTMLScriptElement::type):
+ (WebCore::HTMLScriptElement::scriptCharset):
+ (WebCore::HTMLScriptElement::scriptContent):
+ (WebCore::HTMLScriptElement::sourceAttributeValue):
+ (WebCore::HTMLScriptElement::charsetAttributeValue):
+ (WebCore::HTMLScriptElement::typeAttributeValue):
+ (WebCore::HTMLScriptElement::languageAttributeValue):
+ (WebCore::HTMLScriptElement::dispatchLoadEvent):
+ (WebCore::HTMLScriptElement::dispatchErrorEvent):
+ * html/HTMLScriptElement.h:
+ * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::SVGScriptElement):
+ (WebCore::SVGScriptElement::scriptContent):
+ (WebCore::SVGScriptElement::sourceAttributeValue):
+ (WebCore::SVGScriptElement::charsetAttributeValue):
+ (WebCore::SVGScriptElement::typeAttributeValue):
+ (WebCore::SVGScriptElement::languageAttributeValue):
+ (WebCore::SVGScriptElement::dispatchLoadEvent):
+ (WebCore::SVGScriptElement::dispatchErrorEvent):
+ * svg/SVGScriptElement.h:
+ (WebCore::SVGScriptElement::setCreatedByParser):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix the Gtk build, no review.
+
+ I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
+
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ * platform/graphics/qt/GradientQt.cpp:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::paintMozWidget):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Yet another attempt to fix the Qt build, no review.
+
+ * platform/graphics/qt/GradientQt.cpp:
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContext::applyStrokePattern):
+ (WebCore::GraphicsContext::applyFillPattern):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix the Windows build, no review.
+
+ * platform/win/CursorWin.cpp:
+ (WebCore::loadCursorByName):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::paint):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix the Windows build, no review.
+
+ * platform/win/CursorWin.cpp:
+ (WebCore::loadCursorByName):
+ * platform/win/ScrollViewWin.cpp:
+ (WebCore::ScrollView::paint):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix the Qt build, no review.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::image):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Attempt to fix the Windows build, no review.
+
+ * platform/graphics/win/ImageWin.cpp:
+ (WebCore::Image::loadPlatformResource):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::paintMissingPluginIcon):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Another attempt to fix the Qt build, no review.
+
+ * platform/graphics/qt/ImageQt.cpp:
+ * platform/graphics/qt/StillImageQt.h:
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ No review, build fix only.
+
+ Fix mac build, due to change in new code since my patch was written.
+
+ * svg/graphics/cg/SVGResourceMaskerCg.mm:
+ (WebCore::SVGResourceMasker::applyMask):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ Attempt to fix the Qt build.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ * platform/graphics/qt/StillImageQt.h:
+ (WebCore::StillImage::create):
+ (WebCore::StillImage::destroyDecodedData):
+ (WebCore::StillImage::decodedSize):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Build fix only, no review.
+
+ Attempt to fix the Qt build.
+
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Sam.
+
+ Match HTML5 spec by throwing INVALID_STATE_ERR when
+ createPattern is called and the HTMLImageElement is not
+ yet done loading the image (!isComplete)
+ https://bugs.webkit.org/show_bug.cgi?id=20351
+
+ Test: http/misc/canvas-pattern-from-incremental-image.html
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::createPattern):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Niko.
+
+ Split out a Pattern class from CanvasPattern
+ and remove all the Pattern-related #ifdefs
+ (This will break non-mac platforms! I will fix them.)
+ https://bugs.webkit.org/show_bug.cgi?id=20351
+
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ * html/CanvasPattern.cpp:
+ (WebCore::CanvasPattern::parseRepetitionType):
+ (WebCore::CanvasPattern::CanvasPattern):
+ * html/CanvasPattern.h:
+ (WebCore::CanvasPattern::create):
+ (WebCore::CanvasPattern::pattern):
+ (WebCore::CanvasPattern::originClean):
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::createPattern):
+ (WebCore::CanvasRenderingContext2D::applyStrokePattern):
+ (WebCore::CanvasRenderingContext2D::applyFillPattern):
+ * html/CanvasRenderingContext2D.h:
+ * html/HTMLCanvasElement.cpp:
+ * html/HTMLCanvasElement.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::createHistoryItem):
+ * platform/graphics/GraphicsContext.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ (WebCore::GraphicsContext::applyStrokePattern):
+ (WebCore::GraphicsContext::applyFillPattern):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::clipToImageBuffer):
+ (WebCore::GraphicsContext::applyStrokePattern):
+ (WebCore::GraphicsContext::applyFillPattern):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Niko.
+
+ Make Images RefCounted (and clean up callers)
+ https://bugs.webkit.org/show_bug.cgi?id=20351
+
+ * editing/DeleteButtonController.cpp:
+ (WebCore::DeleteButtonController::createDeletionUI):
+ * loader/CachedImage.cpp:
+ (WebCore::CachedImage::CachedImage):
+ (WebCore::brokenImage):
+ (WebCore::nullImage):
+ (WebCore::CachedImage::image):
+ (WebCore::CachedImage::notifyObservers):
+ (WebCore::CachedImage::createImage):
+ * loader/CachedImage.h:
+ * loader/icon/IconRecord.cpp:
+ (WebCore::IconRecord::setImageData):
+ (WebCore::IconRecord::loadImageFromResource):
+ * loader/icon/IconRecord.h:
+ * platform/graphics/BitmapImage.h:
+ (WebCore::BitmapImage::create):
+ * platform/graphics/GeneratedImage.h:
+ * platform/graphics/Gradient.cpp:
+ * platform/graphics/Gradient.h:
+ * platform/graphics/Image.cpp:
+ (WebCore::Image::nullImage):
+ * platform/graphics/Image.h:
+ * platform/graphics/ImageBuffer.h:
+ * platform/graphics/cairo/ImageBufferCairo.cpp:
+ (WebCore::ImageBuffer::image):
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::image):
+ (WebCore::ImageBuffer::getImageData):
+ (WebCore::ImageBuffer::putImageData):
+ * platform/graphics/cg/PDFDocumentImage.h:
+ (WebCore::PDFDocumentImage::create):
+ (WebCore::PDFDocumentImage::destroyDecodedData):
+ (WebCore::PDFDocumentImage::decodedSize):
+ * platform/graphics/gtk/ImageGtk.cpp:
+ (WebCore::Image::loadPlatformResource):
+ * platform/graphics/mac/ImageMac.mm:
+ (WebCore::Image::loadPlatformResource):
+ * rendering/RenderImage.cpp:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintOverflowControls):
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::nativeImageForCurrentFrame):
+ * svg/graphics/SVGImage.h:
+ (WebCore::SVGImage::create):
+ (WebCore::SVGImage::destroyDecodedData):
+ (WebCore::SVGImage::decodedSize):
+ (WebCore::SVGImage::frameAtIndex):
+ * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
+ (WebCore::SVGPaintServerPattern::setup):
+ * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
+ (WebCore::SVGResourceMasker::applyMask):
+ * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
+ (WebCore::patternCallback):
+ * svg/graphics/cg/SVGResourceMaskerCg.mm:
+ (WebCore::SVGResourceMasker::applyMask):
+
+2008-08-13 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Niko.
+
+ Remove #ifdefs from CanvasStyle by using platform/Color.h
+ https://bugs.webkit.org/show_bug.cgi?id=20351
+
+ There are some down-sides to this commit.
+ This commit limits us to 255 levels of grey for calls like:
+ context.setStrokeStyle(.37, 1.0)
+ previously CG might have used up to 32bits to store the grey level
+ Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
+
+ Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
+ to RGBA32 (like all the rest of colors in WebCore), thus:
+ context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
+ context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
+
+ If this is a problem for Dashboard, we can either roll out this commit
+ or add a beefier Color abstraction, which can be used internally by GraphicsContext
+ when keeping state, and then GraphicsContext can grow some additional set* routines
+ for setting the a grey/float/whatever fill and stroke.
+
+ * html/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setFillStyle):
+ * html/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::CanvasStyle):
+ (WebCore::colorWithOverrideAlpha):
+ (WebCore::CanvasStyle::applyStrokeColor):
+ (WebCore::CanvasStyle::applyFillColor):
+ * html/CanvasStyle.h:
+ * platform/graphics/Color.cpp:
+ (WebCore::colorFloatToRGBAByte):
+ (WebCore::makeRGBA32FromFloats):
+ * platform/graphics/Color.h:
+
+2008-08-13 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Fix for <rdar://problem/6137931>
+ https://bugs.webkit.org/show_bug.cgi?id=20360
+ Remove all parameters from the MIME type before checking with the MIME type registry
+
+ Tests: media/video-source-type-params.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
+ to isSupportedMediaMIMEType()
+
+2008-08-13 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Fix for <rdar://problem/6141345>
+
+ This patch refines findString and markAllMatchesForText functions'
+ interactions with disconnected frames. They no longer rely on
+ knowing where a range is relative to the visible region and work
+ with disconnected frames that contain frames.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
+ the visiblity enum.
+ (WebCore::Editor::firstVisibleRange): This now returns the very
+ first visible range in the document. It's no longer dependent on
+ searching forward.
+ (WebCore::Editor::lastVisibleRange): This now returns the very last
+ visible range in the document. It's no longer dependent on
+ searching backwards.
+ (WebCore::Editor::nextVisibleRange): This returns the next visible
+ range in the appropriate direction from the current range.
+ * editing/Editor.h:
+ * page/Frame.cpp:
+ (WebCore::Frame::findString):
+ (WebCore::Frame::markAllMatchesForText):
+
+2008-08-13 Kevin Ollivier <kevino@theolliviers.com>
+
+ wx build fix for case-sensitive platforms, like Linux.
+
+ * WebCoreSources.bkl:
+
+2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=16881
+ [GTK] PlatformScreenGtk is unimplemented
+
+ Original patch by Christian Dywan.
+
+ * platform/gtk/PlatformScreenGtk.cpp:
+ (WebCore::screenDepth):
+ (WebCore::screenDepthPerComponent):
+ (WebCore::screenIsMonochrome):
+ (WebCore::screenRect):
+ (WebCore::screenAvailableRect):
+
+2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ http://bugs.webkit.org/show_bug.cgi?id=20318
+ SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
+
+ g_idle_add is the same as g_idle_add_full with a priority of
+ G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
+
+ * platform/gtk/SharedTimerGtk.cpp:
+ (WebCore::setSharedTimerFireTime):
+
+2008-08-13 Timothy Hatcher <timothy@apple.com>
+
+ Changed the InspectorController so it can be notified when the
+ attached state of the Inspector changes in WebKit.
+
+ Reviewed by Kevin McCullough.
+
+ * WebCore.base.exp: Updated the symbol for setWindowVisible.
+ * page/InspectorController.cpp:
+ (WebCore::InspectorController::setWindowVisible): Added an attached argument,
+ that defaults to false.Call setAttachedWindow with the attached argument.
+ (WebCore::InspectorController::setAttachedWindow): Call the script version
+ of setAttachedWindow.
+ * page/InspectorController.h:
+ * page/inspector/inspector.js:
+ (WebInspector.setAttachedWindow): Set the attached property.
+
+2008-08-12 Timothy Hatcher <timothy@apple.com>
+
+ Added a close button to the Inspector's toolbar when docked.
+
+ https://bugs.webkit.org/show_bug.cgi?id=14270
+
+ Reviewed by Kevin McCullough.
+
+ * page/InspectorController.cpp:
+ (WebCore::closeWindow): Call InspectorController::closeWindow.
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ Added closeWindow to the script class.
+ * page/InspectorController.h:
+ * page/inspector/Images/closeButtons.png: Added.
+ * page/inspector/inspector.css: Added and changed styles.
+ * page/inspector/inspector.html: Added the close button.
+ * page/inspector/inspector.js:
+ (WebInspector.loaded): Added click event listener to the close button.
+ (WebInspector.close): Call InspectorController.closeWindow.
+
+2008-08-12 Timothy Hatcher <timothy@apple.com>
+
+ Make the docked Web Inspector resizable. This is the cross platform
+ portion of the code. Each InspectorClient needs to implement the
+ real resize code.
+
+ https://bugs.webkit.org/show_bug.cgi?id=14282
+
+ Reviewed by Kevin McCullough.
+
+ * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
+ * page/InspectorClient.h: Added setAttachedWindowHeight.
+ * page/InspectorController.cpp:
+ (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
+ on the InspectorController.
+ (WebCore::InspectorController::setAttachedWindowHeight): Call
+ setAttachedWindowHeight on the client.
+ (WebCore::InspectorController::windowScriptObjectAvailable):
+ Added setAttachedWindowHeight to the script class.
+ * page/InspectorController.h:
+ * page/inspector/inspector.css: Make the cursor on the toolbar be
+ row-resize when docked.
+ * page/inspector/inspector.js:
+ (WebInspector.loaded): Always add the toolbarDragStart event listener.
+ (WebInspector.toolbarDragStart): Return early if we are not attached
+ and not on Leopard. Call WebInspector.elementDragStart.
+ (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
+ (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
+ otherwise call moveByUnrestricted.
+
+2008-08-13 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Holger.
+
+ Initialize m_zoomsTextOnly in the Settings constructor.
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+
+2008-08-13 Brad Hughes <bhughes@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
+
+ The latest upgrade of the intel compiler allows us to compile all of
+ Qt with optimizations enabled (yay!).
+
+ * WebCore.pro:
+
+2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix QtWebKit not displaying content on 403 HTTP responses
+
+ Just like with 404 responses also display content with 403, as
+ used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::finish):
+
+2008-08-13 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Holger.
+
+ Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
+
+ Make the formatting of String::format() locale independent through the use of QString::vsprintf.
+
+ * platform/text/String.cpp:
+ (WebCore::String::format):
+
+2008-08-13 Simon Hausmann <hausmann@webkit.org>
+
+ Reviewed by Lars.
+
+ Fix QWebFrame::setHtml() not setting the new contents immediately.
+
+ Added a setter to the DocumentLoader to toggle the deferred loading of the main
+ resource when it comes from substitute data.
+
+ Disable deferred loading of the main resource when we have valid substitute data,
+ as used by QWebFrame::setHtml.
+
+ * loader/DocumentLoader.h:
+
+2008-08-13 Mark Rowe <mrowe@apple.com>
+
+ Speculative GTK build fix.
+
+ * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
+
+2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
+
+ Reviewed by Simon.
+
+ Fix encoding of [ and ] in the host part of the URL
+
+ Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
+ add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
+ doesn't encode [ and ] when they are found in the host part. That is, the
+ following URL:
+ http://[::1]/
+ is valid and should not be reencoded to:
+ http://%5b::1%5d/
+
+ * platform/qt/KURLQt.cpp:
+ (WebCore::KURL::operator QUrl):
+
+2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
+ Broken HTML object elements cause de-reference of pointer to freed memory.
+ If we fail to load an image for an object tag and we no longer believe the object tag points at
+ an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
+ fall back content.
+
+ Reviewed by Dave Hyatt and Alexey Proskuryakov.
+
+ Test: http/tests/misc/object-image-error-with-onload.html
+
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::renderFallbackContent):
+ * page/Frame.cpp:
+ (WebCore::Frame::Frame):
+
+2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Dave.
+
+ Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
+ Masks are translated, and the mask images are swapped on the y-axis.
+
+ Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
+ is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
+
+ Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
+ the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
+
+ * svg/graphics/cg/SVGResourceMaskerCg.mm:
+ (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
+
+2008-08-12 Dan Bernstein <mitz@apple.com>
+
+ - WebCore part of <rdar://problem/6121636>
+ Make fast*alloc() abort() on failure and add "try" variants that
+ return NULL on failure.
+
+ Reviewed by Darin Adler.
+
+ * platform/Arena.cpp:
+ (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
+ result.
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
+
+2008-08-12 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix https://bugs.webkit.org/show_bug.cgi?id=19348
+ <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
+
+ Test: fast/frames/frameset-style-recalc.html
+
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
+ class implementation after marking for layout.
+
+2008-08-12 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by John Sullivan.
+
+ - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
+
+ * WebCore.base.exp:
+ * page/FrameView.cpp:
+ (WebCore::FrameViewPrivate::FrameViewPrivate):
+ (WebCore::FrameView::shouldUpdateWhileHidden):
+ (WebCore::FrameView::setShouldUpdateWhileHidden):
+ * page/FrameView.h:
+ * page/Settings.cpp:
+ * page/Settings.h:
+
+2008-08-12 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * bindings/js/JSSVGPODTypeWrapper.h: Align
+ JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
+ members on 16-byte boundaries to avoid an alignment warning.
+
+2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver.
+
+ Add new dynamice-update layout tests covering SVGMarkerElement.
+ Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
+ Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
+
+ Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
+ svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
+ svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
+ svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
+ svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
+ svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
+ svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
+
+ * svg/SVGMarkerElement.cpp:
+ (WebCore::SVGMarkerElement::SVGMarkerElement):
+ (WebCore::SVGMarkerElement::parseMappedAttribute):
+ (WebCore::SVGMarkerElement::svgAttributeChanged):
+ (WebCore::SVGMarkerElement::childrenChanged):
+ (WebCore::SVGMarkerElement::setOrientToAuto):
+ (WebCore::SVGMarkerElement::setOrientToAngle):
+ (WebCore::SVGMarkerElement::canvasResource):
+
+2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Oliver.
+
+ Add new dynamic-update layout tests covering SVGImageElement.
+ Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
+
+ Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
+ svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
+ svg/dynamic-updates/SVGImageElement-dom-width-attr.html
+ svg/dynamic-updates/SVGImageElement-dom-x-attr.html
+ svg/dynamic-updates/SVGImageElement-dom-y-attr.html
+ svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
+ svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
+ svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
+ svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
+ svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
+
+ * svg/SVGImageElement.cpp:
+ (WebCore::SVGImageElement::svgAttributeChanged):
+
+2008-08-11 Anthony Ricaud <rik24d@gmail.com>
+
+ Changed Option/Alt-Up or Down in CSS editing when the value is
+ near zero to jump to the next integer.
+
+ Reviewed by Tim Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20326
+
+ * page/inspector/StylesSidebarPane.js:
+
+2008-08-11 Anthony Ricaud <rik24d@gmail.com>
+
+ Changed the line highlight transition for an easier animation.
+
+ Reviewed by Tim Hatcher.
+
+ * page/inspector/SourceFrame.js:
+
+2008-08-11 Keishi Hattori <casey.hattori@gmail.com>
+
+ Added support for some Firebug Command Line APIs.
+
+ Reviewed by Tim Hatcher.
+
+ https://bugs.webkit.org/show_bug.cgi?id=19867
+ https://bugs.webkit.org/show_bug.cgi?id=19868
+ https://bugs.webkit.org/show_bug.cgi?id=19869
+ https://bugs.webkit.org/show_bug.cgi?id=19875
+ https://bugs.webkit.org/show_bug.cgi?id=19876
+ https://bugs.webkit.org/show_bug.cgi?id=19880
+
+ * page/inspector/Console.js:
+ (WebInspector.Console.prototype._evalInInspectedWindow):
+ Create an object on the inspected window that holds the console
+ command line API functions. This object is used in a with statement
+ around the typed expression.
+
+2008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
+
+ Reviewed by Antti.
+
+ Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
+
+ JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
+ failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
+
+ Added tests: svg/custom/svg-modify-currentTranslate.html
+ svg/custom/tearoffs-with-tearoffs.html
+ svg/custom/immutable-properties.html
+
+ Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
+
+ * bindings/js/JSSVGPODTypeWrapper.h:
+ (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
+ (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
+ (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
+ (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
+ (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
+ (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
+ (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
+ (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
+ * bindings/scripts/CodeGenerator.pm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
+ * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
+
+2008-08-11 Brady Eidson <beidson@apple.com>
+
+ Reviewed by John and Anders
+
+ Fix for <rdar://problem/6141797>
+
+ When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
+ would never have nil data.
+
+ When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
+ semantics with some WebKit applications.
+
+ The guarantee was a good one and should be restored.
+
+ Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
+ creates an empty data object in the case of null data for its own purposes.
+
+ * loader/SubstituteResource.h:
+ (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
+ well help any future subclassers not make this mistake.
+
+ * loader/archive/ArchiveResource.cpp:
+ (WebCore::ArchiveResource::create): Return 0 if the data is null.
+
+2008-08-11 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dave Hyatt
+
+ https://bugs.webkit.org/show_bug.cgi?id=20328
+ Fix a problem when an 'all' transition transition with more than
+ one property changing is interrupted, and did some AnimationController
+ cleanup.
+
+ Test: transitions/interrupted-all-transition.html
+
+ * page/AnimationController.cpp:
+ (WebCore::ImplicitAnimation::ImplicitAnimation):
+ (WebCore::AnimationControllerPrivate::blendProperties):
+ (WebCore::CompositeAnimation::updateTransitions):
+ (WebCore::CompositeAnimation::cleanupFinishedAnimations):
+ (WebCore::CompositeAnimation::setTransitionStartTime):
+ (WebCore::CompositeAnimation::overrideImplicitAnimations):
+ (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
+ (WebCore::ImplicitAnimation::animate):
+ (WebCore::ImplicitAnimation::onAnimationEnd):
+ (WebCore::ImplicitAnimation::sendTransitionEvent):
+ (WebCore::ImplicitAnimation::affectsProperty):
+ (WebCore::KeyframeAnimation::endAnimation):
+ (WebCore::KeyframeAnimation::onAnimationEnd):
+
+2008-08-11 Kevin McCullough <kmccullough@apple.com>
+
+ Reviewed by Tim.
+
+ - Because console messages have group levels now, newly created messages
+ that do not specify the level lose their message since the number of
+ arguments is wrong.
+
+ * page/inspector/Console.js:
+ * page/inspector/Resource.js:
+
+2008-08-11 Alp Toker <alp@nuanti.com>
+
+ Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
+ the opportunity to sort the sources lists.
+
+ * GNUmakefile.am:
+
+2008-08-11 Timothy Hatcher <timothy@apple.com>
+
+ Speed up the the JavaScript syntax highlighter by generating
+ the finders only once per script instead of per line.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20346
+
+ Reviewed by Adam Roben.
+
+ * page/inspector/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
+ Removed, factored into syntaxHighlightJavascript as an inline function.
+ (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
+ Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
+ Generate the finders before iterating the lines.
+
+2008-08-11 Adam Roben <aroben@apple.com>
+
+ Windows build fix
+
+ * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
+ JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
+ too.
+
+2008-08-11 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
+
+ Test: fast/css/counters/invalidate-cached-counter-node.html
+
+ * rendering/RenderContainer.cpp:
+ (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
+ RenderCounters in :before and :after content.
+ * rendering/RenderContainer.h:
+ * rendering/RenderCounter.cpp:
+ (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
+ to match the RenderObject method.
+ (WebCore::RenderCounter::invalidate): Added. Resets the cached
+ CounterNode and invalidates the object's layout and preferred widths.
+ (WebCore::destroyCounterNodeChildren): Added a call to
+ invalidateCounters().
+ * rendering/RenderCounter.h:
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::invalidateCounters):
+
+2008-08-11 Dean Jackson <dino@apple.com>
+
+ Implement CSS Animation and Transition Events
+ https://bugs.webkit.org/show_bug.cgi?id=20337
+
+ Implement the events defined in the CSS Animations
+ and Transitions specifications so code can react
+ to animations and transitions.
+
+ Reviewed by Tim Hatcher and Dave Hyatt.
+
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * WebCoreSources.bkl:
+ Build configs for new files
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ * bindings/js/JSDOMWindowBase.h:
+ * bindings/js/JSEventCustom.cpp:
+ * dom/Document.h:
+ * dom/Event.cpp:
+ * dom/Event.h:
+ * dom/EventTarget.cpp:
+ * dom/EventTargetNode.cpp:
+ * dom/EventTargetNode.h:
+ * html/HTMLElement.cpp:
+ * page/AnimationController.cpp:
+ do all the new event stuff
+
+ * html/HTMLAttributeNames.in:
+ the onwebkitanimation* and onwebkittransitionend attrs
+
+ * dom/WebKitAnimationEvent.cpp: Added.
+ * dom/WebKitAnimationEvent.h: Added.
+ * dom/WebKitAnimationEvent.idl: Added.
+ * dom/WebKitTransitionEvent.cpp: Added.
+ * dom/WebKitTransitionEvent.h: Added.
+ * dom/WebKitTransitionEvent.idl: Added.
+ New files for the events
+
+ * manual-tests/transition-events.html: Added.
+ New testfile
+
+2008-08-11 Adam Roben <aroben@apple.com>
+
+ Add a ForwardingHeader for wtf/NotFound.h
+
+ Rubberstamped by Darin Adler.
+
+ * ForwardingHeaders/wtf/NotFound.h: Added.
+
+2008-08-11 Timothy Hatcher <timothy@apple.com>
+
+ Fixes a bug where error bubbles in JavaScript resources would
+ be clobbered by the syntax highlighter.
+
+ https://bugs.webkit.org/show_bug.cgi?id=20345
+
+ Reviewed by Adam Roben.
+
+ * manual-tests/inspector/resources/script-error.js: Added.
+ * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
+ * page/inspector/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._addMessageToSource):
+ Check the nodeType and not the nodeName, this is less fragile.
+ (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
+ Check if the lastChild is an error bubble, if so remove it before
+ getting the line's textContent. Add the error bubble back at the end.
+
+== Rolled over to ChangeLog-2008-08-10 ==
diff --git a/src/3rdparty/webkit/WebCore/DerivedSources.cpp b/src/3rdparty/webkit/WebCore/DerivedSources.cpp
index 3b8eeb1..3075a4b 100644
--- a/src/3rdparty/webkit/WebCore/DerivedSources.cpp
+++ b/src/3rdparty/webkit/WebCore/DerivedSources.cpp
@@ -54,6 +54,8 @@
#include "JSCSSVariablesDeclaration.cpp"
#include "JSCSSVariablesRule.cpp"
#include "JSDatabase.cpp"
+#include "JSDataGridColumn.cpp"
+#include "JSDataGridColumnList.cpp"
#include "JSDocument.cpp"
#include "JSDocumentFragment.cpp"
#include "JSDocumentType.cpp"
@@ -62,7 +64,6 @@
#include "JSDOMImplementation.cpp"
#include "JSDOMParser.cpp"
#include "JSDOMSelection.cpp"
-#include "JSDOMStringList.cpp"
#include "JSDOMWindow.cpp"
#include "JSElement.cpp"
#include "JSEntity.cpp"
@@ -84,6 +85,10 @@
#include "JSHTMLButtonElement.cpp"
#include "JSHTMLCanvasElement.cpp"
#include "JSHTMLCollection.cpp"
+#include "JSHTMLDataGridElement.cpp"
+#include "JSHTMLDataGridCellElement.cpp"
+#include "JSHTMLDataGridColElement.cpp"
+#include "JSHTMLDataGridRowElement.cpp"
#include "JSHTMLDirectoryElement.cpp"
#include "JSHTMLDivElement.cpp"
#include "JSHTMLDListElement.cpp"
diff --git a/src/3rdparty/webkit/WebCore/ForwardingHeaders/runtime/DateMath.h b/src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/DateMath.h
index 4135742..4135742 100644
--- a/src/3rdparty/webkit/WebCore/ForwardingHeaders/runtime/DateMath.h
+++ b/src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/DateMath.h
diff --git a/src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/FastAllocBase.h b/src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/FastAllocBase.h
new file mode 100644
index 0000000..6e50bd8
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/ForwardingHeaders/wtf/FastAllocBase.h
@@ -0,0 +1,4 @@
+#ifndef WebCore_FWD_FastAllocBase_h
+#define WebCore_FWD_FastAllocBase_h
+#include <JavaScriptCore/FastAllocBase.h>
+#endif
diff --git a/src/3rdparty/webkit/WebCore/WebCore.pro b/src/3rdparty/webkit/WebCore/WebCore.pro
index 28ff4ae..486c9d0 100644
--- a/src/3rdparty/webkit/WebCore/WebCore.pro
+++ b/src/3rdparty/webkit/WebCore/WebCore.pro
@@ -39,6 +39,10 @@ include($$OUTPUT_DIR/config.pri)
CONFIG -= warn_on
*-g++*:QMAKE_CXXFLAGS += -Wreturn-type -fno-strict-aliasing
+# Disable a few warnings on Windows. The warnings are also
+# disabled in WebKitLibraries/win/tools/vsprops/common.vsprops
+win32-*: QMAKE_CXXFLAGS += -wd4291 -wd4344
+
unix:!mac:*-g++*:QMAKE_CXXFLAGS += -ffunction-sections -fdata-sections
unix:!mac:*-g++*:QMAKE_LFLAGS += -Wl,--gc-sections
@@ -144,6 +148,12 @@ contains(DEFINES, ENABLE_SINGLE_THREADED=1) {
DEFINES += WTF_USE_JAVASCRIPTCORE_BINDINGS=1 WTF_CHANGES=1
+# Used to compute defaults for the build-webkit script
+CONFIG(compute_defaults) {
+ message($$DEFINES)
+ error("Done computing defaults")
+}
+
# Ensure that we pick up WebCore's config.h over JavaScriptCore's
INCLUDEPATH = $$PWD $$INCLUDEPATH
@@ -183,6 +193,7 @@ INCLUDEPATH += $$PWD/accessibility \
$$PWD/loader/icon \
$$PWD/css \
$$PWD/dom \
+ $$PWD/dom/default \
$$PWD/page \
$$PWD/page/animation \
$$PWD/editing \
@@ -284,7 +295,6 @@ IDL_BINDINGS += \
dom/DocumentType.idl \
dom/DOMCoreException.idl \
dom/DOMImplementation.idl \
- dom/DOMStringList.idl \
dom/Element.idl \
dom/Entity.idl \
dom/EntityReference.idl \
@@ -319,6 +329,8 @@ IDL_BINDINGS += \
html/CanvasGradient.idl \
html/CanvasPattern.idl \
html/CanvasRenderingContext2D.idl \
+ html/DataGridColumn.idl \
+ html/DataGridColumnList.idl \
html/File.idl \
html/FileList.idl \
html/HTMLAudioElement.idl \
@@ -333,6 +345,10 @@ IDL_BINDINGS += \
html/HTMLButtonElement.idl \
html/HTMLCanvasElement.idl \
html/HTMLCollection.idl \
+ html/HTMLDataGridElement.idl \
+ html/HTMLDataGridCellElement.idl \
+ html/HTMLDataGridColElement.idl \
+ html/HTMLDataGridRowElement.idl \
html/HTMLDirectoryElement.idl \
html/HTMLDivElement.idl \
html/HTMLDListElement.idl \
@@ -445,10 +461,11 @@ SOURCES += \
bindings/js/JSCustomPositionErrorCallback.cpp \
bindings/js/JSCustomVoidCallback.cpp \
bindings/js/JSCustomXPathNSResolver.cpp \
+ bindings/js/JSDataGridColumnListCustom.cpp \
+ bindings/js/JSDataGridDataSource.cpp \
bindings/js/JSDocumentCustom.cpp \
bindings/js/JSDocumentFragmentCustom.cpp \
bindings/js/JSDOMGlobalObject.cpp \
- bindings/js/JSDOMStringListCustom.cpp \
bindings/js/JSDOMWindowBase.cpp \
bindings/js/JSDOMWindowCustom.cpp \
bindings/js/JSDOMWindowShell.cpp \
@@ -460,6 +477,7 @@ SOURCES += \
bindings/js/JSHistoryCustom.cpp \
bindings/js/JSHTMLAppletElementCustom.cpp \
bindings/js/JSHTMLCollectionCustom.cpp \
+ bindings/js/JSHTMLDataGridElementCustom.cpp \
bindings/js/JSHTMLDocumentCustom.cpp \
bindings/js/JSHTMLElementCustom.cpp \
bindings/js/JSHTMLEmbedElementCustom.cpp \
@@ -610,7 +628,6 @@ SOURCES += \
dom/DocumentFragment.cpp \
dom/DocumentType.cpp \
dom/DOMImplementation.cpp \
- dom/DOMStringList.cpp \
dom/DynamicNodeList.cpp \
dom/EditingText.cpp \
dom/Element.cpp \
@@ -627,6 +644,7 @@ SOURCES += \
dom/MessageChannel.cpp \
dom/MessageEvent.cpp \
dom/MessagePort.cpp \
+ dom/MessagePortChannel.cpp \
dom/MouseEvent.cpp \
dom/MouseRelatedEvent.cpp \
dom/MutationEvent.cpp \
@@ -653,7 +671,6 @@ SOURCES += \
dom/SelectElement.cpp \
dom/SelectorNodeList.cpp \
dom/StaticNodeList.cpp \
- dom/StaticStringList.cpp \
dom/StyledElement.cpp \
dom/StyleElement.cpp \
dom/TagNodeList.cpp \
@@ -669,6 +686,7 @@ SOURCES += \
dom/XMLTokenizer.cpp \
dom/XMLTokenizerQt.cpp \
dom/XMLTokenizerScope.cpp \
+ dom/default/PlatformMessagePortChannel.cpp \
editing/AppendNodeCommand.cpp \
editing/ApplyStyleCommand.cpp \
editing/BreakBlockquoteCommand.cpp \
@@ -720,6 +738,7 @@ SOURCES += \
history/CachedFrame.cpp \
history/CachedPage.cpp \
history/HistoryItem.cpp \
+ history/qt/HistoryItemQt.cpp \
history/PageCache.cpp \
html/CanvasGradient.cpp \
html/CanvasPattern.cpp \
@@ -727,6 +746,8 @@ SOURCES += \
html/CanvasRenderingContext2D.cpp \
html/CanvasStyle.cpp \
html/CollectionCache.cpp \
+ html/DataGridColumn.cpp \
+ html/DataGridColumnList.cpp \
html/File.cpp \
html/FileList.cpp \
html/FormDataList.cpp \
@@ -741,6 +762,10 @@ SOURCES += \
html/HTMLButtonElement.cpp \
html/HTMLCanvasElement.cpp \
html/HTMLCollection.cpp \
+ html/HTMLDataGridElement.cpp \
+ html/HTMLDataGridCellElement.cpp \
+ html/HTMLDataGridColElement.cpp \
+ html/HTMLDataGridRowElement.cpp \
html/HTMLDirectoryElement.cpp \
html/HTMLDivElement.cpp \
html/HTMLDListElement.cpp \
@@ -814,7 +839,7 @@ SOURCES += \
inspector/InspectorController.cpp \
inspector/InspectorFrontend.cpp \
inspector/InspectorResource.cpp \
- inspector/JSONObject.cpp \
+ inspector/InspectorJSONObject.cpp \
loader/archive/ArchiveFactory.cpp \
loader/archive/ArchiveResource.cpp \
loader/archive/ArchiveResourceCollection.cpp \
@@ -887,6 +912,7 @@ SOURCES += \
page/Screen.cpp \
page/Settings.cpp \
page/WindowFeatures.cpp \
+ page/XSSAuditor.cpp \
plugins/PluginData.cpp \
plugins/PluginArray.cpp \
plugins/Plugin.cpp \
@@ -1004,6 +1030,7 @@ SOURCES += \
rendering/RenderBR.cpp \
rendering/RenderButton.cpp \
rendering/RenderCounter.cpp \
+ rendering/RenderDataGrid.cpp \
rendering/RenderFieldset.cpp \
rendering/RenderFileUploadControl.cpp \
rendering/RenderFlexibleBox.cpp \
@@ -1337,23 +1364,27 @@ contains(DEFINES, ENABLE_DOM_STORAGE=1) {
FEATURE_DEFINES_JAVASCRIPT += ENABLE_DOM_STORAGE=1
HEADERS += \
+ storage/LocalStorageTask.h \
+ storage/LocalStorageThread.h \
storage/Storage.h \
+ storage/StorageArea.h \
+ storage/StorageAreaSync.h \
storage/StorageEvent.h \
- storage/SessionStorage.h \
- storage/SessionStorageArea.h
+ storage/StorageMap.h \
+ storage/StorageNamespace.h \
+ storage/StorageSyncManager.h
SOURCES += \
- storage/LocalStorage.cpp \
- storage/LocalStorageArea.cpp \
+ bindings/js/JSStorageCustom.cpp \
storage/LocalStorageTask.cpp \
storage/LocalStorageThread.cpp \
storage/Storage.cpp \
storage/StorageArea.cpp \
- storage/StorageMap.cpp \
+ storage/StorageAreaSync.cpp \
storage/StorageEvent.cpp \
- storage/SessionStorage.cpp \
- storage/SessionStorageArea.cpp \
- bindings/js/JSStorageCustom.cpp
+ storage/StorageMap.cpp \
+ storage/StorageNamespace.cpp \
+ storage/StorageSyncManager.cpp
IDL_BINDINGS += \
storage/Storage.idl \
@@ -1393,7 +1424,7 @@ contains(DEFINES, ENABLE_WORKERS=1) {
workers/WorkerMessagingProxy.cpp \
workers/WorkerRunLoop.cpp \
workers/WorkerThread.cpp \
- workers/WorkerImportScriptsClient.cpp
+ workers/WorkerScriptLoader.cpp
}
contains(DEFINES, ENABLE_VIDEO=1) {
@@ -2163,26 +2194,31 @@ HEADERS += $$WEBKIT_API_HEADERS
QMAKE_PKGCONFIG_INSTALL_REPLACE += lib_replace
}
- mac:!static:contains(QT_CONFIG, qt_framework):!CONFIG(webkit_no_framework) {
- !build_pass {
- message("Building QtWebKit as a framework, as that's how Qt was built. You can")
- message("override this by passing CONFIG+=webkit_no_framework to build-webkit.")
- } else {
- debug_and_release:CONFIG(debug, debug|release) {
- TARGET = $$qtLibraryTarget($$TARGET)
+ mac {
+ !static:contains(QT_CONFIG, qt_framework):!CONFIG(webkit_no_framework) {
+ !build_pass {
+ message("Building QtWebKit as a framework, as that's how Qt was built. You can")
+ message("override this by passing CONFIG+=webkit_no_framework to build-webkit.")
+ } else {
+ debug_and_release:CONFIG(debug, debug|release) {
+ TARGET = $$qtLibraryTarget($$TARGET)
+ }
}
+
+ CONFIG += lib_bundle qt_no_framework_direct_includes qt_framework
+ FRAMEWORK_HEADERS.version = Versions
+ FRAMEWORK_HEADERS.files = $$WEBKIT_API_HEADERS
+ FRAMEWORK_HEADERS.path = Headers
+ QMAKE_BUNDLE_DATA += FRAMEWORK_HEADERS
}
- CONFIG += lib_bundle qt_no_framework_direct_includes qt_framework
- FRAMEWORK_HEADERS.version = Versions
- FRAMEWORK_HEADERS.files = $$WEBKIT_API_HEADERS
- FRAMEWORK_HEADERS.path = Headers
- QMAKE_BUNDLE_DATA += FRAMEWORK_HEADERS
+ QMAKE_LFLAGS_SONAME = "$${QMAKE_LFLAGS_SONAME}$${DESTDIR}$${QMAKE_DIR_SEP}"
}
}
CONFIG(QTDIR_build):isEqual(QT_MAJOR_VERSION, 4):greaterThan(QT_MINOR_VERSION, 4) {
# start with 4.5
+ # Remove the following 2 lines if you want debug information in WebCore
CONFIG -= separate_debug_info
CONFIG += no_debug_info
}
diff --git a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.cpp b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.cpp
index dccff82..a6cd62d 100644
--- a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.cpp
+++ b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.cpp
@@ -298,7 +298,22 @@ bool AccessibilityObject::press() const
actionElem->accessKeyAction(true);
return true;
}
-
+
+String AccessibilityObject::language() const
+{
+ AccessibilityObject* parent = parentObject();
+
+ // as a last resort, fall back to the content language specified in the meta tag
+ if (!parent) {
+ Document* doc = document();
+ if (doc)
+ return doc->contentLanguage();
+ return String();
+ }
+
+ return parent->language();
+}
+
AXObjectCache* AccessibilityObject::axObjectCache() const
{
return 0;
diff --git a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.h b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.h
index f71be99..8939092 100644
--- a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.h
+++ b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityObject.h
@@ -311,7 +311,8 @@ public:
virtual Document* document() const { return 0; }
virtual FrameView* topDocumentFrameView() const { return 0; }
virtual FrameView* documentFrameView() const;
-
+ virtual String language() const;
+
void setAXObjectID(unsigned);
virtual void setFocused(bool);
virtual void setSelectedText(const String&);
diff --git a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.cpp b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.cpp
index 8c522a1..9c10267 100644
--- a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.cpp
+++ b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.cpp
@@ -656,6 +656,25 @@ String AccessibilityRenderObject::helpText() const
return String();
}
+
+String AccessibilityRenderObject::language() const
+{
+ if (!m_renderer)
+ return String();
+
+ // Defer to parent if this element doesn't have a language set
+ Node* node = m_renderer->node();
+ if (!node)
+ return AccessibilityObject::language();
+
+ if (!node->isElementNode())
+ return AccessibilityObject::language();
+
+ String language = static_cast<Element*>(node)->getAttribute(langAttr);
+ if (language.isEmpty())
+ return AccessibilityObject::language();
+ return language;
+}
String AccessibilityRenderObject::textUnderElement() const
{
@@ -1008,7 +1027,7 @@ IntRect AccessibilityRenderObject::boundingBoxRect() const
IntRect r = quads[i].enclosingBoundingBox();
if (!r.isEmpty()) {
if (obj->style()->hasAppearance())
- theme()->adjustRepaintRect(obj, r);
+ obj->theme()->adjustRepaintRect(obj, r);
result.unite(r);
}
}
@@ -1167,12 +1186,31 @@ AccessibilityObject* AccessibilityRenderObject::titleUIElement() const
return 0;
}
+bool AccessibilityRenderObject::ariaIsHidden() const
+{
+ if (equalIgnoringCase(getAttribute(aria_hiddenAttr).string(), "true"))
+ return true;
+
+ // aria-hidden hides this object and any children
+ AccessibilityObject* object = parentObject();
+ while (object) {
+ if (object->isAccessibilityRenderObject() && equalIgnoringCase(static_cast<AccessibilityRenderObject*>(object)->getAttribute(aria_hiddenAttr).string(), "true"))
+ return true;
+ object = object->parentObject();
+ }
+
+ return false;
+}
+
bool AccessibilityRenderObject::accessibilityIsIgnored() const
{
// ignore invisible element
if (!m_renderer || m_renderer->style()->visibility() != VISIBLE)
return true;
+ if (ariaIsHidden())
+ return true;
+
if (isPresentationalChildOfAriaRole())
return true;
@@ -1512,6 +1550,10 @@ void AccessibilityRenderObject::setValue(const String& string)
bool AccessibilityRenderObject::isEnabled() const
{
ASSERT(m_renderer);
+
+ if (equalIgnoringCase(getAttribute(aria_disabledAttr).string(), "true"))
+ return false;
+
Node* node = m_renderer->node();
if (!node || !node->isElementNode())
return true;
@@ -1993,7 +2035,7 @@ AccessibilityObject* AccessibilityRenderObject::doAccessibilityHitTest(const Int
if (!obj)
return 0;
- AccessibilityObject *result = obj->document()->axObjectCache()->getOrCreate(obj);
+ AccessibilityObject* result = obj->document()->axObjectCache()->getOrCreate(obj);
if (obj->isListBox())
return static_cast<AccessibilityListBox*>(result)->doAccessibilityHitTest(point);
@@ -2112,13 +2154,12 @@ AccessibilityObject* AccessibilityRenderObject::observableObject() const
typedef HashMap<String, AccessibilityRole, CaseFoldingHash> ARIARoleMap;
+struct RoleEntry {
+ String ariaRole;
+ AccessibilityRole webcoreRole;
+};
static const ARIARoleMap& createARIARoleMap()
{
- struct RoleEntry {
- String ariaRole;
- AccessibilityRole webcoreRole;
- };
-
const RoleEntry roles[] = {
{ "button", ButtonRole },
{ "checkbox", CheckBoxRole },
@@ -2323,6 +2364,9 @@ bool AccessibilityRenderObject::canSetFocusAttribute() const
bool AccessibilityRenderObject::canSetValueAttribute() const
{
+ if (equalIgnoringCase(getAttribute(aria_readonlyAttr).string(), "true"))
+ return false;
+
if (isWebArea())
return !isReadOnly();
diff --git a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.h b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.h
index 3fa88a2..4fa325f 100644
--- a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.h
+++ b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityRenderObject.h
@@ -177,6 +177,7 @@ public:
virtual Widget* widgetForAttachmentView() const;
virtual void getDocumentLinks(AccessibilityChildrenVector&);
virtual FrameView* documentFrameView() const;
+ virtual String language() const;
virtual const AccessibilityChildrenVector& children();
@@ -226,6 +227,7 @@ protected:
private:
void ariaListboxSelectedChildren(AccessibilityChildrenVector&);
void ariaListboxVisibleChildren(AccessibilityChildrenVector&);
+ bool ariaIsHidden() const;
Element* menuElementForMenuButton() const;
Element* menuItemElementForMenu() const;
diff --git a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityTableCell.cpp b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityTableCell.cpp
index 4d7cf5a..7ac3937 100644
--- a/src/3rdparty/webkit/WebCore/accessibility/AccessibilityTableCell.cpp
+++ b/src/3rdparty/webkit/WebCore/accessibility/AccessibilityTableCell.cpp
@@ -134,6 +134,12 @@ AccessibilityObject* AccessibilityTableCell::titleUIElement() const
// case when the table is not appearing as an AXTable.)
if (isTableCell() || !m_renderer || !m_renderer->isTableCell())
return 0;
+
+ // Table cells that are th cannot have title ui elements, since by definition
+ // they are title ui elements
+ Node* node = m_renderer->node();
+ if (node && node->hasTagName(thTag))
+ return 0;
RenderTableCell* renderCell = static_cast<RenderTableCell*>(m_renderer);
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
index b07f201..280ec93 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
@@ -125,7 +125,7 @@ bool JSCSSStyleDeclaration::canGetItemsForName(ExecState*, CSSStyleDeclaration*,
return isCSSPropertyName(propertyName);
}
-// FIXME: You can get these properties, and set them (see customPut below),
+// FIXME: You can get these properties, and set them (see putDelegate below),
// but you should also be able to enumerate them.
JSValue JSCSSStyleDeclaration::nameGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
{
@@ -156,7 +156,7 @@ JSValue JSCSSStyleDeclaration::nameGetter(ExecState* exec, const Identifier& pro
}
-bool JSCSSStyleDeclaration::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot&)
+bool JSCSSStyleDeclaration::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot&)
{
if (!isCSSPropertyName(propertyName))
return false;
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
index 76db871..398a679 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -28,11 +28,13 @@
#include "FloatRect.h"
#include "HTMLCanvasElement.h"
#include "HTMLImageElement.h"
+#include "HTMLVideoElement.h"
#include "ImageData.h"
#include "JSCanvasGradient.h"
#include "JSCanvasPattern.h"
#include "JSHTMLCanvasElement.h"
#include "JSHTMLImageElement.h"
+#include "JSHTMLVideoElement.h"
#include "JSImageData.h"
#include <runtime/Error.h>
@@ -230,6 +232,29 @@ JSValue JSCanvasRenderingContext2D::drawImage(ExecState* exec, const ArgList& ar
default:
return throwError(exec, SyntaxError);
}
+#if ENABLE(VIDEO)
+ } else if (o->inherits(&JSHTMLVideoElement::s_info)) {
+ HTMLVideoElement* video = static_cast<HTMLVideoElement*>(static_cast<JSHTMLElement*>(o)->impl());
+ switch (args.size()) {
+ case 3:
+ context->drawImage(video, args.at(1).toFloat(exec), args.at(2).toFloat(exec));
+ break;
+ case 5:
+ context->drawImage(video, args.at(1).toFloat(exec), args.at(2).toFloat(exec),
+ args.at(3).toFloat(exec), args.at(4).toFloat(exec), ec);
+ setDOMException(exec, ec);
+ break;
+ case 9:
+ context->drawImage(video, FloatRect(args.at(1).toFloat(exec), args.at(2).toFloat(exec),
+ args.at(3).toFloat(exec), args.at(4).toFloat(exec)),
+ FloatRect(args.at(5).toFloat(exec), args.at(6).toFloat(exec),
+ args.at(7).toFloat(exec), args.at(8).toFloat(exec)), ec);
+ setDOMException(exec, ec);
+ break;
+ default:
+ return throwError(exec, SyntaxError);
+ }
+#endif
} else {
setDOMException(exec, TYPE_MISMATCH_ERR);
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMBinding.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMBinding.cpp
index 4f58797..55f0e91 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMBinding.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMBinding.cpp
@@ -325,10 +325,10 @@ void markActiveObjectsForContext(JSGlobalData& globalData, ScriptExecutionContex
const HashSet<MessagePort*>& messagePorts = scriptExecutionContext->messagePorts();
HashSet<MessagePort*>::const_iterator portsEnd = messagePorts.end();
for (HashSet<MessagePort*>::const_iterator iter = messagePorts.begin(); iter != portsEnd; ++iter) {
- if ((*iter)->hasPendingActivity()) {
+ // If the message port is remotely entangled, then always mark it as in-use because we can't determine reachability across threads.
+ if (!(*iter)->locallyEntangledPort() || (*iter)->hasPendingActivity()) {
DOMObject* wrapper = getCachedDOMObjectWrapper(globalData, *iter);
- // A port with pending activity must have a wrapper to mark its listeners, so no null check.
- if (!wrapper->marked())
+ if (wrapper && !wrapper->marked())
wrapper->mark();
}
}
@@ -545,7 +545,7 @@ KURL completeURL(ExecState* exec, const String& relativeURL)
JSValue objectToStringFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 0, propertyName, objectProtoFuncToString);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 0, propertyName, objectProtoFuncToString);
}
Structure* getCachedDOMStructure(JSDOMGlobalObject* globalObject, const ClassInfo* classInfo)
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.cpp
index 4fd1139..0eefebe 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.cpp
@@ -26,13 +26,9 @@
#include "CString.h"
#include "Console.h"
#include "DOMWindow.h"
-#include "Element.h"
#include "Frame.h"
-#include "HTMLCollection.h"
-#include "HTMLDocument.h"
#include "InspectorController.h"
#include "JSDOMWindowCustom.h"
-#include "JSHTMLCollection.h"
#include "JSNode.h"
#include "Logging.h"
#include "Page.h"
@@ -75,88 +71,6 @@ ScriptExecutionContext* JSDOMWindowBase::scriptExecutionContext() const
return d()->impl->document();
}
-JSValue JSDOMWindowBase::childFrameGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
-{
- return toJS(exec, static_cast<JSDOMWindowBase*>(asObject(slot.slotBase()))->impl()->frame()->tree()->child(AtomicString(propertyName))->domWindow());
-}
-
-JSValue JSDOMWindowBase::indexGetter(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- return toJS(exec, static_cast<JSDOMWindowBase*>(asObject(slot.slotBase()))->impl()->frame()->tree()->child(slot.index())->domWindow());
-}
-
-JSValue JSDOMWindowBase::namedItemGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
-{
- JSDOMWindowBase* thisObj = static_cast<JSDOMWindowBase*>(asObject(slot.slotBase()));
- Document* doc = thisObj->impl()->frame()->document();
- ASSERT(thisObj->allowsAccessFrom(exec));
- ASSERT(doc);
- ASSERT(doc->isHTMLDocument());
-
- RefPtr<HTMLCollection> collection = doc->windowNamedItems(propertyName);
- if (collection->length() == 1)
- return toJS(exec, collection->firstItem());
- return toJS(exec, collection.get());
-}
-
-bool JSDOMWindowBase::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
-{
- // Check for child frames by name before built-in properties to
- // match Mozilla. This does not match IE, but some sites end up
- // naming frames things that conflict with window properties that
- // are in Moz but not IE. Since we have some of these, we have to do
- // it the Moz way.
- if (impl()->frame()->tree()->child(propertyName)) {
- slot.setCustom(this, childFrameGetter);
- return true;
- }
-
- // Do prototype lookup early so that functions and attributes in the prototype can have
- // precedence over the index and name getters.
- JSValue proto = prototype();
- if (proto.isObject()) {
- if (asObject(proto)->getPropertySlot(exec, propertyName, slot)) {
- if (!allowsAccessFrom(exec))
- slot.setUndefined();
- return true;
- }
- }
-
- // FIXME: Search the whole frame hierachy somewhere around here.
- // We need to test the correct priority order.
-
- // allow window[1] or parent[1] etc. (#56983)
- bool ok;
- unsigned i = propertyName.toArrayIndex(&ok);
- if (ok && i < impl()->frame()->tree()->childCount()) {
- slot.setCustomIndex(this, i, indexGetter);
- return true;
- }
-
- if (!allowsAccessFrom(exec)) {
- slot.setUndefined();
- return true;
- }
-
- // Allow shortcuts like 'Image1' instead of document.images.Image1
- Document* document = impl()->frame()->document();
- if (document->isHTMLDocument()) {
- AtomicStringImpl* atomicPropertyName = AtomicString::find(propertyName);
- if (atomicPropertyName && (static_cast<HTMLDocument*>(document)->hasNamedItem(atomicPropertyName) || document->hasElementWithId(atomicPropertyName))) {
- slot.setCustom(this, namedItemGetter);
- return true;
- }
- }
-
- return Base::getOwnPropertySlot(exec, propertyName, slot);
-}
-
-void JSDOMWindowBase::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
-{
- if (allowsAccessFrom(exec))
- Base::put(exec, propertyName, value, slot);
-}
-
String JSDOMWindowBase::crossDomainAccessErrorMessage(const JSGlobalObject* other) const
{
KURL originURL = asJSDOMWindow(other)->impl()->url();
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.h b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.h
index 6d93196..113344f 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.h
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowBase.h
@@ -40,7 +40,6 @@ namespace WebCore {
class JSDOMWindowBasePrivate;
- // This is the only WebCore JS binding which does not inherit from DOMObject
class JSDOMWindowBase : public JSDOMGlobalObject {
typedef JSDOMGlobalObject Base;
protected:
@@ -52,9 +51,6 @@ namespace WebCore {
DOMWindow* impl() const { return d()->impl.get(); }
virtual ScriptExecutionContext* scriptExecutionContext() const;
- virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
- virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
-
// Called just before removing this window from the JSDOMWindowShell.
void willRemoveFromWindowShell();
@@ -62,15 +58,12 @@ namespace WebCore {
static const JSC::ClassInfo s_info;
virtual JSC::ExecState* globalExec();
-
virtual bool supportsProfiling() const;
-
virtual bool shouldInterruptScript() const;
bool allowsAccessFrom(JSC::ExecState*) const;
bool allowsAccessFromNoErrorMessage(JSC::ExecState*) const;
bool allowsAccessFrom(JSC::ExecState*, String& message) const;
-
void printErrorMessage(const String&) const;
// Don't call this version of allowsAccessFrom -- it's a slightly incorrect implementation used only by WebScriptObject
@@ -89,10 +82,6 @@ namespace WebCore {
JSDOMWindowShell* shell;
};
- static JSC::JSValue childFrameGetter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
- static JSC::JSValue indexGetter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
- static JSC::JSValue namedItemGetter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-
bool allowsAccessFromPrivate(const JSC::JSGlobalObject*) const;
String crossDomainAccessErrorMessage(const JSC::JSGlobalObject*) const;
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.cpp
index b8c30c7..22013eb 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.cpp
@@ -31,11 +31,14 @@
#include "FrameLoader.h"
#include "FrameTree.h"
#include "FrameView.h"
+#include "HTMLCollection.h"
+#include "HTMLDocument.h"
#include "History.h"
#include "JSAudioConstructor.h"
#include "JSDOMWindowShell.h"
#include "JSEvent.h"
#include "JSEventListener.h"
+#include "JSHTMLCollection.h"
#include "JSHistory.h"
#include "JSImageConstructor.h"
#include "JSLocation.h"
@@ -58,6 +61,7 @@
#include "Settings.h"
#include "WindowFeatures.h"
#include <runtime/JSObject.h>
+#include <runtime/PrototypeFunction.h>
using namespace JSC;
@@ -92,6 +96,199 @@ void JSDOMWindow::mark()
#endif
}
+template<NativeFunction nativeFunction, int length>
+JSValue nonCachingStaticFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
+{
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), length, propertyName, nativeFunction);
+}
+
+static JSValue childFrameGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
+{
+ return toJS(exec, static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->impl()->frame()->tree()->child(AtomicString(propertyName))->domWindow());
+}
+
+static JSValue indexGetter(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return toJS(exec, static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->impl()->frame()->tree()->child(slot.index())->domWindow());
+}
+
+static JSValue namedItemGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
+{
+ JSDOMWindowBase* thisObj = static_cast<JSDOMWindow*>(asObject(slot.slotBase()));
+ Document* document = thisObj->impl()->frame()->document();
+
+ ASSERT(thisObj->allowsAccessFrom(exec));
+ ASSERT(document);
+ ASSERT(document->isHTMLDocument());
+
+ RefPtr<HTMLCollection> collection = document->windowNamedItems(propertyName);
+ if (collection->length() == 1)
+ return toJS(exec, collection->firstItem());
+ return toJS(exec, collection.get());
+}
+
+bool JSDOMWindow::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ // When accessing a Window cross-domain, functions are always the native built-in ones, and they
+ // are not affected by properties changed on the Window or anything in its prototype chain.
+ // This is consistent with the behavior of Firefox.
+
+ const HashEntry* entry;
+
+ // We don't want any properties other than "close" and "closed" on a closed window.
+ if (!impl()->frame()) {
+ // The following code is safe for cross-domain and same domain use.
+ // It ignores any custom properties that might be set on the DOMWindow (including a custom prototype).
+ entry = s_info.propHashTable(exec)->entry(exec, propertyName);
+ if (entry && !(entry->attributes() & Function) && entry->propertyGetter() == jsDOMWindowClosed) {
+ slot.setCustom(this, entry->propertyGetter());
+ return true;
+ }
+ entry = JSDOMWindowPrototype::s_info.propHashTable(exec)->entry(exec, propertyName);
+ if (entry && (entry->attributes() & Function) && entry->function() == jsDOMWindowPrototypeFunctionClose) {
+ slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionClose, 0>);
+ return true;
+ }
+
+ // FIXME: We should have a message here that explains why the property access/function call was
+ // not allowed.
+ slot.setUndefined();
+ return true;
+ }
+
+ // We need to check for cross-domain access here without printing the generic warning message
+ // because we always allow access to some function, just different ones depending whether access
+ // is allowed.
+ String errorMessage;
+ bool allowsAccess = allowsAccessFrom(exec, errorMessage);
+
+ // Look for overrides before looking at any of our own properties, but ignore overrides completely
+ // if this is cross-domain access.
+ if (allowsAccess && JSGlobalObject::getOwnPropertySlot(exec, propertyName, slot))
+ return true;
+
+ // We need this code here because otherwise JSDOMWindowBase will stop the search before we even get to the
+ // prototype due to the blanket same origin (allowsAccessFrom) check at the end of getOwnPropertySlot.
+ // Also, it's important to get the implementation straight out of the DOMWindow prototype regardless of
+ // what prototype is actually set on this object.
+ entry = JSDOMWindowPrototype::s_info.propHashTable(exec)->entry(exec, propertyName);
+ if (entry) {
+ if (entry->attributes() & Function) {
+ if (entry->function() == jsDOMWindowPrototypeFunctionBlur) {
+ if (!allowsAccess) {
+ slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionBlur, 0>);
+ return true;
+ }
+ } else if (entry->function() == jsDOMWindowPrototypeFunctionClose) {
+ if (!allowsAccess) {
+ slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionClose, 0>);
+ return true;
+ }
+ } else if (entry->function() == jsDOMWindowPrototypeFunctionFocus) {
+ if (!allowsAccess) {
+ slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionFocus, 0>);
+ return true;
+ }
+ } else if (entry->function() == jsDOMWindowPrototypeFunctionPostMessage) {
+ if (!allowsAccess) {
+ slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionPostMessage, 2>);
+ return true;
+ }
+ } else if (entry->function() == jsDOMWindowPrototypeFunctionShowModalDialog) {
+ if (!DOMWindow::canShowModalDialog(impl()->frame())) {
+ slot.setUndefined();
+ return true;
+ }
+ }
+ }
+ } else {
+ // Allow access to toString() cross-domain, but always Object.prototype.toString.
+ if (propertyName == exec->propertyNames().toString) {
+ if (!allowsAccess) {
+ slot.setCustom(this, objectToStringFunctionGetter);
+ return true;
+ }
+ }
+ }
+
+ entry = JSDOMWindow::s_info.propHashTable(exec)->entry(exec, propertyName);
+ if (entry) {
+ slot.setCustom(this, entry->propertyGetter());
+ return true;
+ }
+
+ // Check for child frames by name before built-in properties to
+ // match Mozilla. This does not match IE, but some sites end up
+ // naming frames things that conflict with window properties that
+ // are in Moz but not IE. Since we have some of these, we have to do
+ // it the Moz way.
+ if (impl()->frame()->tree()->child(propertyName)) {
+ slot.setCustom(this, childFrameGetter);
+ return true;
+ }
+
+ // Do prototype lookup early so that functions and attributes in the prototype can have
+ // precedence over the index and name getters.
+ JSValue proto = prototype();
+ if (proto.isObject()) {
+ if (asObject(proto)->getPropertySlot(exec, propertyName, slot)) {
+ if (!allowsAccess) {
+ printErrorMessage(errorMessage);
+ slot.setUndefined();
+ }
+ return true;
+ }
+ }
+
+ // FIXME: Search the whole frame hierachy somewhere around here.
+ // We need to test the correct priority order.
+
+ // allow window[1] or parent[1] etc. (#56983)
+ bool ok;
+ unsigned i = propertyName.toArrayIndex(&ok);
+ if (ok && i < impl()->frame()->tree()->childCount()) {
+ slot.setCustomIndex(this, i, indexGetter);
+ return true;
+ }
+
+ if (!allowsAccess) {
+ printErrorMessage(errorMessage);
+ slot.setUndefined();
+ return true;
+ }
+
+ // Allow shortcuts like 'Image1' instead of document.images.Image1
+ Document* document = impl()->frame()->document();
+ if (document->isHTMLDocument()) {
+ AtomicStringImpl* atomicPropertyName = AtomicString::find(propertyName);
+ if (atomicPropertyName && (static_cast<HTMLDocument*>(document)->hasNamedItem(atomicPropertyName) || document->hasElementWithId(atomicPropertyName))) {
+ slot.setCustom(this, namedItemGetter);
+ return true;
+ }
+ }
+
+ return Base::getOwnPropertySlot(exec, propertyName, slot);
+}
+
+void JSDOMWindow::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ if (!impl()->frame())
+ return;
+
+ // Optimization: access JavaScript global variables directly before involving the DOM.
+ if (JSGlobalObject::hasOwnPropertyForWrite(exec, propertyName)) {
+ if (allowsAccessFrom(exec))
+ JSGlobalObject::put(exec, propertyName, value, slot);
+ return;
+ }
+
+ if (lookupPut<JSDOMWindow>(exec, propertyName, value, s_info.propHashTable(exec), this))
+ return;
+
+ if (allowsAccessFrom(exec))
+ Base::put(exec, propertyName, value, slot);
+}
+
bool JSDOMWindow::deleteProperty(ExecState* exec, const Identifier& propertyName)
{
// Only allow deleting properties by frames in the same origin.
@@ -100,15 +297,15 @@ bool JSDOMWindow::deleteProperty(ExecState* exec, const Identifier& propertyName
return Base::deleteProperty(exec, propertyName);
}
-bool JSDOMWindow::customGetPropertyNames(ExecState* exec, PropertyNameArray&)
+void JSDOMWindow::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
{
// Only allow the window to enumerated by frames in the same origin.
if (!allowsAccessFrom(exec))
- return true;
- return false;
+ return;
+ Base::getPropertyNames(exec, propertyNames);
}
-bool JSDOMWindow::getPropertyAttributes(JSC::ExecState* exec, const Identifier& propertyName, unsigned& attributes) const
+bool JSDOMWindow::getPropertyAttributes(ExecState* exec, const Identifier& propertyName, unsigned& attributes) const
{
// Only allow getting property attributes properties by frames in the same origin.
if (!allowsAccessFrom(exec))
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.h b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.h
index 52ef4a0..a0e1b8f 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.h
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDOMWindowCustom.h
@@ -21,7 +21,6 @@
#include "JSDOMWindow.h"
#include "JSDOMWindowShell.h"
-#include <runtime/PrototypeFunction.h>
#include <wtf/AlwaysInline.h>
namespace WebCore {
@@ -36,121 +35,6 @@ inline const JSDOMWindow* asJSDOMWindow(const JSC::JSGlobalObject* globalObject)
return static_cast<const JSDOMWindow*>(globalObject);
}
-template<JSC::NativeFunction nativeFunction, int length>
-JSC::JSValue nonCachingStaticFunctionGetter(JSC::ExecState* exec, const JSC::Identifier& propertyName, const JSC::PropertySlot&)
-{
- return new (exec) JSC::PrototypeFunction(exec, length, propertyName, nativeFunction);
-}
-
-ALWAYS_INLINE bool JSDOMWindow::customGetOwnPropertySlot(JSC::ExecState* exec, const JSC::Identifier& propertyName, JSC::PropertySlot& slot)
-{
- // When accessing a Window cross-domain, functions are always the native built-in ones, and they
- // are not affected by properties changed on the Window or anything in its prototype chain.
- // This is consistent with the behavior of Firefox.
-
- const JSC::HashEntry* entry;
-
- // We don't want any properties other than "close" and "closed" on a closed window.
- if (!impl()->frame()) {
- // The following code is safe for cross-domain and same domain use.
- // It ignores any custom properties that might be set on the DOMWindow (including a custom prototype).
- entry = s_info.propHashTable(exec)->entry(exec, propertyName);
- if (entry && !(entry->attributes() & JSC::Function) && entry->propertyGetter() == jsDOMWindowClosed) {
- slot.setCustom(this, entry->propertyGetter());
- return true;
- }
- entry = JSDOMWindowPrototype::s_info.propHashTable(exec)->entry(exec, propertyName);
- if (entry && (entry->attributes() & JSC::Function) && entry->function() == jsDOMWindowPrototypeFunctionClose) {
- slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionClose, 0>);
- return true;
- }
-
- // FIXME: We should have a message here that explains why the property access/function call was
- // not allowed.
- slot.setUndefined();
- return true;
- }
-
- // We need to check for cross-domain access here without printing the generic warning message
- // because we always allow access to some function, just different ones depending whether access
- // is allowed.
- bool allowsAccess = allowsAccessFromNoErrorMessage(exec);
-
- // Look for overrides before looking at any of our own properties, but ignore overrides completely
- // if this is cross-domain access.
- if (allowsAccess && JSGlobalObject::getOwnPropertySlot(exec, propertyName, slot))
- return true;
-
- // We need this code here because otherwise JSC::Window will stop the search before we even get to the
- // prototype due to the blanket same origin (allowsAccessFrom) check at the end of getOwnPropertySlot.
- // Also, it's important to get the implementation straight out of the DOMWindow prototype regardless of
- // what prototype is actually set on this object.
- entry = JSDOMWindowPrototype::s_info.propHashTable(exec)->entry(exec, propertyName);
- if (entry) {
- if (entry->attributes() & JSC::Function) {
- if (entry->function() == jsDOMWindowPrototypeFunctionBlur) {
- if (!allowsAccess) {
- slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionBlur, 0>);
- return true;
- }
- } else if (entry->function() == jsDOMWindowPrototypeFunctionClose) {
- if (!allowsAccess) {
- slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionClose, 0>);
- return true;
- }
- } else if (entry->function() == jsDOMWindowPrototypeFunctionFocus) {
- if (!allowsAccess) {
- slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionFocus, 0>);
- return true;
- }
- } else if (entry->function() == jsDOMWindowPrototypeFunctionPostMessage) {
- if (!allowsAccess) {
- slot.setCustom(this, nonCachingStaticFunctionGetter<jsDOMWindowPrototypeFunctionPostMessage, 2>);
- return true;
- }
- } else if (entry->function() == jsDOMWindowPrototypeFunctionShowModalDialog) {
- if (!DOMWindow::canShowModalDialog(impl()->frame())) {
- slot.setUndefined();
- return true;
- }
- }
- }
- } else {
- // Allow access to toString() cross-domain, but always Object.prototype.toString.
- if (propertyName == exec->propertyNames().toString) {
- if (!allowsAccess) {
- slot.setCustom(this, objectToStringFunctionGetter);
- return true;
- }
- }
- }
-
- return false;
-}
-
-inline bool JSDOMWindow::customPut(JSC::ExecState* exec, const JSC::Identifier& propertyName, JSC::JSValue value, JSC::PutPropertySlot& slot)
-{
- if (!impl()->frame())
- return true;
-
- // Optimization: access JavaScript global variables directly before involving the DOM.
- JSC::PropertySlot getSlot;
- bool slotIsWriteable;
- if (JSGlobalObject::getOwnPropertySlot(exec, propertyName, getSlot, slotIsWriteable)) {
- if (allowsAccessFrom(exec)) {
- if (slotIsWriteable) {
- getSlot.putValue(value);
- if (getSlot.isCacheable())
- slot.setExistingProperty(this, getSlot.cachedOffset());
- } else
- JSGlobalObject::put(exec, propertyName, value, slot);
- }
- return true;
- }
-
- return false;
-}
-
inline bool JSDOMWindowBase::allowsAccessFrom(const JSGlobalObject* other) const
{
if (allowsAccessFromPrivate(other))
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridColumnListCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridColumnListCustom.cpp
new file mode 100644
index 0000000..af49df4
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridColumnListCustom.cpp
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSDataGridColumnList.h"
+
+#include "AtomicString.h"
+#include "DataGridColumn.h"
+#include "DataGridColumnList.h"
+#include "JSDataGridColumn.h"
+
+using namespace JSC;
+
+namespace WebCore {
+
+bool JSDataGridColumnList::canGetItemsForName(ExecState*, DataGridColumnList* impl, const Identifier& propertyName)
+{
+ return impl->itemWithName(propertyName);
+}
+
+JSValue JSDataGridColumnList::nameGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
+{
+ JSDataGridColumnList* thisObj = static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()));
+ return toJS(exec, thisObj->impl()->itemWithName(propertyName));
+}
+
+} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.cpp
new file mode 100644
index 0000000..e75b10b
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.cpp
@@ -0,0 +1,80 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSDataGridDataSource.h"
+
+#include "Document.h"
+#include "Frame.h"
+#include "HTMLDataGridElement.h"
+#include "JSHTMLDataGridElement.h"
+#include "JSDOMWindowBase.h"
+#include <runtime/JSLock.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+JSDataGridDataSource::JSDataGridDataSource(JSC::JSValue dataSource, Frame* frame)
+ : m_dataSource(dataSource)
+ , m_frame(frame)
+{
+}
+
+JSDataGridDataSource::~JSDataGridDataSource()
+{
+}
+
+void JSDataGridDataSource::initialize(HTMLDataGridElement* datagrid)
+{
+ if (!m_frame->script()->isEnabled())
+ return;
+
+ JSLock lock(false);
+ RefPtr<JSDataGridDataSource> protect(this);
+
+ ExecState* exec = m_frame->script()->globalObject()->globalExec();
+
+ if (!jsDataSource().isObject())
+ return;
+
+ JSValue initializeFunction = jsDataSource().get(exec, Identifier(exec, "initialize"));
+ CallData callData;
+ CallType callType = initializeFunction.getCallData(callData);
+ if (callType == CallTypeNone)
+ return;
+
+ MarkedArgumentBuffer args;
+ args.append(toJS(exec, datagrid));
+
+ JSDOMWindowBase::commonJSGlobalData()->timeoutChecker.start();
+ call(exec, initializeFunction, callType, callData, m_dataSource, args);
+ JSDOMWindowBase::commonJSGlobalData()->timeoutChecker.stop();
+
+ if (exec->hadException())
+ reportCurrentException(exec);
+}
+
+} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.h b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.h
new file mode 100644
index 0000000..2537b00
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSDataGridDataSource.h
@@ -0,0 +1,75 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef JSDataGridDataSource_h
+#define JSDataGridDataSource_h
+
+#include "DataGridDataSource.h"
+#include <runtime/JSValue.h>
+#include <runtime/Protect.h>
+#include <wtf/PassRefPtr.h>
+#include <wtf/RefPtr.h>
+
+namespace WebCore {
+
+class Frame;
+class HTMLDataGridElement;
+
+class JSDataGridDataSource : public DataGridDataSource {
+public:
+ static PassRefPtr<JSDataGridDataSource> create(JSC::JSValue dataSource, Frame* frame)
+ {
+ return adoptRef(new JSDataGridDataSource(dataSource, frame));
+ }
+
+ virtual ~JSDataGridDataSource();
+
+ virtual bool isJSDataGridDataSource() const { return true; }
+ JSC::JSValue jsDataSource() const { return m_dataSource.get(); }
+
+ virtual void initialize(HTMLDataGridElement*);
+
+private:
+ JSDataGridDataSource(JSC::JSValue, Frame*);
+
+ JSC::ProtectedJSValue m_dataSource;
+ RefPtr<Frame> m_frame;
+};
+
+inline JSDataGridDataSource* asJSDataGridDataSource(DataGridDataSource* dataSource)
+{
+ ASSERT(dataSource->isJSDataGridDataSource());
+ return static_cast<JSDataGridDataSource*>(dataSource);
+}
+
+inline const JSDataGridDataSource* asJSDataGridDataSource(const DataGridDataSource* dataSource)
+{
+ ASSERT(dataSource->isJSDataGridDataSource());
+ return static_cast<const JSDataGridDataSource*>(dataSource);
+}
+
+} // namespace WebCore
+
+#endif // JSDataGridDataSource_h
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLAppletElementCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLAppletElementCustom.cpp
index de6565d..37561af 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLAppletElementCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLAppletElementCustom.cpp
@@ -33,12 +33,12 @@ namespace WebCore {
using namespace JSC;
-bool JSHTMLAppletElement::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSHTMLAppletElement::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
return runtimeObjectCustomGetOwnPropertySlot(exec, propertyName, slot, this);
}
-bool JSHTMLAppletElement::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+bool JSHTMLAppletElement::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
return runtimeObjectCustomPut(exec, propertyName, value, impl(), slot);
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLDataGridElementCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLDataGridElementCustom.cpp
new file mode 100644
index 0000000..5aa0904
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLDataGridElementCustom.cpp
@@ -0,0 +1,50 @@
+/*
+ * Copyright (C) 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSHTMLDataGridElement.h"
+
+#include "Document.h"
+#include "HTMLDataGridElement.h"
+#include "JSDataGridDataSource.h"
+
+using namespace JSC;
+
+namespace WebCore {
+
+JSValue JSHTMLDataGridElement::dataSource(ExecState*) const
+{
+ DataGridDataSource* dataSource = static_cast<HTMLDataGridElement*>(impl())->dataSource();
+ if (dataSource && dataSource->isJSDataGridDataSource())
+ return asJSDataGridDataSource(dataSource)->jsDataSource();
+ return jsNull();
+}
+
+void JSHTMLDataGridElement::setDataSource(ExecState*, JSValue value)
+{
+ static_cast<HTMLDataGridElement*>(impl())->setDataSource(JSDataGridDataSource::create(value, impl()->document()->frame()));
+}
+
+} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLEmbedElementCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLEmbedElementCustom.cpp
index 19aae86..2570bc6 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLEmbedElementCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLEmbedElementCustom.cpp
@@ -33,12 +33,12 @@ namespace WebCore {
using namespace JSC;
-bool JSHTMLEmbedElement::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSHTMLEmbedElement::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
return runtimeObjectCustomGetOwnPropertySlot(exec, propertyName, slot, this);
}
-bool JSHTMLEmbedElement::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+bool JSHTMLEmbedElement::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
return runtimeObjectCustomPut(exec, propertyName, value, impl(), slot);
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLObjectElementCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLObjectElementCustom.cpp
index f7f12b9..a99e46c 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLObjectElementCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSHTMLObjectElementCustom.cpp
@@ -33,12 +33,12 @@ namespace WebCore {
using namespace JSC;
-bool JSHTMLObjectElement::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSHTMLObjectElement::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
return runtimeObjectCustomGetOwnPropertySlot(exec, propertyName, slot, this);
}
-bool JSHTMLObjectElement::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+bool JSHTMLObjectElement::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
return runtimeObjectCustomPut(exec, propertyName, value, impl(), slot);
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSHistoryCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSHistoryCustom.cpp
index 998a364..a3b15e1 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSHistoryCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSHistoryCustom.cpp
@@ -39,23 +39,23 @@ namespace WebCore {
static JSValue nonCachingStaticBackFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 0, propertyName, jsHistoryPrototypeFunctionBack);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 0, propertyName, jsHistoryPrototypeFunctionBack);
}
static JSValue nonCachingStaticForwardFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 0, propertyName, jsHistoryPrototypeFunctionForward);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 0, propertyName, jsHistoryPrototypeFunctionForward);
}
static JSValue nonCachingStaticGoFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 1, propertyName, jsHistoryPrototypeFunctionGo);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 1, propertyName, jsHistoryPrototypeFunctionGo);
}
-bool JSHistory::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSHistory::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
// When accessing History cross-domain, functions are always the native built-in ones.
- // See JSDOMWindow::customGetOwnPropertySlot for additional details.
+ // See JSDOMWindow::getOwnPropertySlotDelegate for additional details.
// Our custom code is only needed to implement the Window cross-domain scheme, so if access is
// allowed, return false so the normal lookup will take place.
@@ -92,7 +92,7 @@ bool JSHistory::customGetOwnPropertySlot(ExecState* exec, const Identifier& prop
return true;
}
-bool JSHistory::customPut(ExecState* exec, const Identifier&, JSValue, PutPropertySlot&)
+bool JSHistory::putDelegate(ExecState* exec, const Identifier&, JSValue, PutPropertySlot&)
{
// Only allow putting by frames in the same origin.
if (!allowsAccessFromFrame(exec, impl()->frame()))
@@ -108,12 +108,12 @@ bool JSHistory::deleteProperty(ExecState* exec, const Identifier& propertyName)
return Base::deleteProperty(exec, propertyName);
}
-bool JSHistory::customGetPropertyNames(ExecState* exec, PropertyNameArray&)
+void JSHistory::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
{
// Only allow the history object to enumerated by frames in the same origin.
if (!allowsAccessFromFrame(exec, impl()->frame()))
- return true;
- return false;
+ return;
+ Base::getPropertyNames(exec, propertyNames);
}
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSLocationCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSLocationCustom.cpp
index 9c5a834..e4f1653 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSLocationCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSLocationCustom.cpp
@@ -39,20 +39,20 @@ namespace WebCore {
static JSValue nonCachingStaticReplaceFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 1, propertyName, jsLocationPrototypeFunctionReplace);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 1, propertyName, jsLocationPrototypeFunctionReplace);
}
static JSValue nonCachingStaticReloadFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 0, propertyName, jsLocationPrototypeFunctionReload);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 0, propertyName, jsLocationPrototypeFunctionReload);
}
static JSValue nonCachingStaticAssignFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot&)
{
- return new (exec) PrototypeFunction(exec, 1, propertyName, jsLocationPrototypeFunctionAssign);
+ return new (exec) NativeFunctionWrapper(exec, exec->lexicalGlobalObject()->prototypeFunctionStructure(), 1, propertyName, jsLocationPrototypeFunctionAssign);
}
-bool JSLocation::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSLocation::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
Frame* frame = impl()->frame();
if (!frame) {
@@ -61,7 +61,7 @@ bool JSLocation::customGetOwnPropertySlot(ExecState* exec, const Identifier& pro
}
// When accessing Location cross-domain, functions are always the native built-in ones.
- // See JSDOMWindow::customGetOwnPropertySlot for additional details.
+ // See JSDOMWindow::getOwnPropertySlotDelegate for additional details.
// Our custom code is only needed to implement the Window cross-domain scheme, so if access is
// allowed, return false so the normal lookup will take place.
@@ -93,7 +93,7 @@ bool JSLocation::customGetOwnPropertySlot(ExecState* exec, const Identifier& pro
return true;
}
-bool JSLocation::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+bool JSLocation::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
Frame* frame = impl()->frame();
if (!frame)
@@ -128,12 +128,12 @@ bool JSLocation::deleteProperty(ExecState* exec, const Identifier& propertyName)
return Base::deleteProperty(exec, propertyName);
}
-bool JSLocation::customGetPropertyNames(ExecState* exec, PropertyNameArray&)
+void JSLocation::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
{
// Only allow the location object to enumerated by frames in the same origin.
if (!allowsAccessFromFrame(exec, impl()->frame()))
- return true;
- return false;
+ return;
+ Base::getPropertyNames(exec, propertyNames);
}
void JSLocation::defineGetter(ExecState* exec, const Identifier& propertyName, JSObject* getterFunction)
@@ -311,7 +311,7 @@ JSValue JSLocation::toString(ExecState* exec, const ArgList&)
return jsString(exec, impl()->toString());
}
-bool JSLocationPrototype::customPut(ExecState* exec, const Identifier& propertyName, JSValue, PutPropertySlot&)
+bool JSLocationPrototype::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue, PutPropertySlot&)
{
return (propertyName == exec->propertyNames().toString || propertyName == exec->propertyNames().valueOf);
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSMessagePortCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSMessagePortCustom.cpp
index f4809ae..bfac375 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSMessagePortCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSMessagePortCustom.cpp
@@ -43,9 +43,9 @@ void JSMessagePort::mark()
DOMObject::mark();
markIfNotNull(m_impl->onmessage());
- markIfNotNull(m_impl->onclose());
- if (MessagePortProxy* entangledPort = m_impl->entangledPort()) {
+ // If we have a locally entangled port, we can directly mark it as reachable. Ports that are remotely entangled are marked in-use by markActiveObjectsForContext().
+ if (MessagePort* entangledPort = m_impl->locallyEntangledPort()) {
DOMObject* wrapper = getCachedDOMObjectWrapper(*Heap::heap(this)->globalData(), entangledPort);
if (wrapper && !wrapper->marked())
wrapper->mark();
@@ -60,14 +60,6 @@ void JSMessagePort::mark()
}
}
-JSValue JSMessagePort::startConversation(ExecState* exec, const ArgList& args)
-{
- JSDOMGlobalObject* globalObject = static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject());
- const UString& message = args.at(0).toString(exec);
-
- return toJS(exec, impl()->startConversation(globalObject->scriptExecutionContext(), message).get());
-}
-
JSValue JSMessagePort::addEventListener(ExecState* exec, const ArgList& args)
{
JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(impl()->scriptExecutionContext());
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSStorageCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSStorageCustom.cpp
index bc43d79..2d2d0f8 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSStorageCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSStorageCustom.cpp
@@ -64,17 +64,17 @@ bool JSStorage::deleteProperty(ExecState* exec, const Identifier& propertyName)
return true;
}
-bool JSStorage::customGetPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
+void JSStorage::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
{
ExceptionCode ec;
unsigned length = m_impl->length();
for (unsigned i = 0; i < length; ++i)
propertyNames.add(Identifier(exec, m_impl->key(i, ec)));
- return false;
+ Base::getPropertyNames(exec, propertyNames);
}
-bool JSStorage::customPut(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot&)
+bool JSStorage::putDelegate(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot&)
{
// Only perform the custom put if the object doesn't have a native property by this name.
// Since hasProperty() would end up calling canGetItemsForName() and be fooled, we need to check
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/JSWorkerContextCustom.cpp b/src/3rdparty/webkit/WebCore/bindings/js/JSWorkerContextCustom.cpp
index 6824914..14bbe19 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/JSWorkerContextCustom.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/JSWorkerContextCustom.cpp
@@ -66,7 +66,7 @@ void JSWorkerContext::mark()
}
}
-bool JSWorkerContext::customGetOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+bool JSWorkerContext::getOwnPropertySlotDelegate(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
// Look for overrides before looking at any of our own properties.
if (JSGlobalObject::getOwnPropertySlot(exec, propertyName, slot))
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.cpp b/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.cpp
index e570293..3e59df9 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.cpp
@@ -33,6 +33,7 @@
#include "ScriptSourceCode.h"
#include "ScriptValue.h"
#include "Settings.h"
+#include "XSSAuditor.h"
#include "npruntime_impl.h"
#include "runtime_root.h"
#include <debugger/Debugger.h>
@@ -55,6 +56,7 @@ ScriptController::ScriptController(Frame* frame)
#if PLATFORM(MAC)
, m_windowScriptObject(0)
#endif
+ , m_XSSAuditor(new XSSAuditor(frame))
{
#if PLATFORM(MAC) && ENABLE(MAC_JAVA_BRIDGE)
static bool initializedJavaJSBindings;
@@ -79,9 +81,14 @@ ScriptController::~ScriptController()
ScriptValue ScriptController::evaluate(const ScriptSourceCode& sourceCode)
{
+ if (!m_XSSAuditor->canEvaluate(sourceCode.source())) {
+ // This script is not safe to be evaluated.
+ return JSValue();
+ }
+
// evaluate code. Returns the JS return value or 0
// if there was none, an error occured or the type couldn't be converted.
-
+
const SourceCode& jsSourceCode = sourceCode.jsSourceCode();
initScriptIfNeeded();
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.h b/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.h
index f700cd9..4528495 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.h
+++ b/src/3rdparty/webkit/WebCore/bindings/js/ScriptController.h
@@ -58,6 +58,7 @@ class ScriptSourceCode;
class ScriptValue;
class String;
class Widget;
+class XSSAuditor;
typedef HashMap<void*, RefPtr<JSC::Bindings::RootObject> > RootObjectMap;
@@ -132,6 +133,8 @@ public:
NPObject* createScriptObjectForPluginElement(HTMLPlugInElement*);
NPObject* windowScriptNPObject();
#endif
+
+ XSSAuditor* xssAuditor() { return m_XSSAuditor.get(); }
private:
void initScriptIfNeeded()
@@ -164,6 +167,9 @@ private:
#if PLATFORM(MAC)
RetainPtr<WebScriptObject> m_windowScriptObject;
#endif
+
+ // The XSSAuditor associated with this ScriptController.
+ OwnPtr<XSSAuditor> m_XSSAuditor;
};
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/ScriptEventListener.cpp b/src/3rdparty/webkit/WebCore/bindings/js/ScriptEventListener.cpp
index 0ce7bca..e5be1d6 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/ScriptEventListener.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/ScriptEventListener.cpp
@@ -35,6 +35,7 @@
#include "Document.h"
#include "JSNode.h"
#include "Frame.h"
+#include "XSSAuditor.h"
#include <runtime/JSLock.h>
@@ -61,6 +62,11 @@ PassRefPtr<JSLazyEventListener> createAttributeEventListener(Node* node, Attribu
if (!scriptController->isEnabled())
return 0;
+ if (!scriptController->xssAuditor()->canCreateInlineEventListener(attr->localName().string(), attr->value())) {
+ // This script is not safe to execute.
+ return 0;
+ }
+
JSDOMWindow* globalObject = scriptController->globalObject();
// Ensure that 'node' has a JavaScript wrapper to mark the event listener we're creating.
@@ -80,6 +86,11 @@ PassRefPtr<JSLazyEventListener> createAttributeEventListener(Frame* frame, Attri
ScriptController* scriptController = frame->script();
if (!scriptController->isEnabled())
return 0;
+
+ if (!scriptController->xssAuditor()->canCreateInlineEventListener(attr->localName().string(), attr->value())) {
+ // This script is not safe to execute.
+ return 0;
+ }
// 'globalObject' is the JavaScript wrapper that will mark the event listener we're creating.
JSDOMWindow* globalObject = scriptController->globalObject();
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/ScriptSourceCode.h b/src/3rdparty/webkit/WebCore/bindings/js/ScriptSourceCode.h
index 4a2403d..0a16265 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/ScriptSourceCode.h
+++ b/src/3rdparty/webkit/WebCore/bindings/js/ScriptSourceCode.h
@@ -53,6 +53,8 @@ public:
const JSC::SourceCode& jsSourceCode() const { return m_code; }
+ const String& source() const { return static_cast<StringSourceProvider*>(m_code.provider())->source(); }
+
private:
JSC::SourceCode m_code;
};
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/StringSourceProvider.h b/src/3rdparty/webkit/WebCore/bindings/js/StringSourceProvider.h
index ab37a56..89dfa67 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/StringSourceProvider.h
+++ b/src/3rdparty/webkit/WebCore/bindings/js/StringSourceProvider.h
@@ -40,6 +40,7 @@ namespace WebCore {
JSC::UString getRange(int start, int end) const { return JSC::UString(m_source.characters() + start, end - start); }
const UChar* data() const { return m_source.characters(); }
int length() const { return m_source.length(); }
+ const String& source() const { return m_source; }
private:
StringSourceProvider(const String& source, const String& url)
diff --git a/src/3rdparty/webkit/WebCore/bindings/js/WorkerScriptController.cpp b/src/3rdparty/webkit/WebCore/bindings/js/WorkerScriptController.cpp
index dd391bc..bcf107b 100644
--- a/src/3rdparty/webkit/WebCore/bindings/js/WorkerScriptController.cpp
+++ b/src/3rdparty/webkit/WebCore/bindings/js/WorkerScriptController.cpp
@@ -110,7 +110,7 @@ ScriptValue WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode,
Completion comp = JSC::evaluate(exec, exec->dynamicGlobalObject()->globalScopeChain(), sourceCode.jsSourceCode(), m_workerContextWrapper);
m_workerContextWrapper->globalData()->timeoutChecker.stop();
- m_workerContext->thread()->workerObjectProxy()->reportPendingActivity(m_workerContext->hasPendingActivity());
+ m_workerContext->thread()->workerObjectProxy().reportPendingActivity(m_workerContext->hasPendingActivity());
if (comp.complType() == Normal || comp.complType() == ReturnValue)
return comp.value();
diff --git a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGenerator.pm b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGenerator.pm
index d217c37..fe145f4 100644
--- a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGenerator.pm
+++ b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGenerator.pm
@@ -116,6 +116,41 @@ sub ProcessDocument
$codeGenerator->finish();
}
+# Necessary for V8 bindings to determine whether an interface is descendant from Node.
+# Node descendants are treated differently by DOMMap and this allows inferring the
+# type statically. See more at the original change: http://codereview.chromium.org/3195.
+# FIXME: Figure out a way to eliminate this JS bindings dichotomy.
+sub FindParentsRecursively
+{
+ my $object = shift;
+ my $dataNode = shift;
+ my @parents = ($dataNode->name);
+ foreach (@{$dataNode->parents}) {
+ my $interface = $object->StripModule($_);
+
+ $endCondition = 0;
+ $foundFilename = "";
+ foreach (@{$useDirectories}) {
+ $object->ScanDirectory("$interface.idl", $_, $_, 0) if ($foundFilename eq "");
+ }
+
+ if ($foundFilename ne "") {
+ print " | |> Parsing parent IDL \"$foundFilename\" for interface \"$interface\"\n" if $verbose;
+
+ # Step #2: Parse the found IDL file (in quiet mode).
+ my $parser = IDLParser->new(1);
+ my $document = $parser->Parse($foundFilename, $defines, $preprocessor, 1);
+
+ foreach my $class (@{$document->classes}) {
+ @parents = (@parents, FindParentsRecursively($object, $class));
+ }
+ } else {
+ die("Could NOT find specified parent interface \"$interface\"!\n")
+ }
+ }
+ return @parents;
+}
+
sub AddMethodsConstantsAndAttributesFromParentClasses
{
# For the passed interface, recursively parse all parent
diff --git a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorJS.pm b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorJS.pm
index 4563018..4f9aa1a 100644
--- a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorJS.pm
+++ b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorJS.pm
@@ -34,7 +34,6 @@ my %headerIncludes = ();
my @implContentHeader = ();
my @implContent = ();
my %implIncludes = ();
-my %implKJSIncludes = ();
# Default .h template
my $headerTemplate = << "EOF";
@@ -220,7 +219,7 @@ sub AddClassForwardIfNeeded
{
my $implClassName = shift;
- # SVGAnimatedLength/Number/etc.. are typedefs to SVGAnimtatedTemplate, so don't use class forwards for them!
+ # SVGAnimatedLength/Number/etc. are typedefs to SVGAnimatedTemplate, so don't use class forwards for them!
push(@headerContent, "class $implClassName;\n\n") unless $codeGenerator->IsSVGAnimatedType($implClassName);
}
@@ -328,8 +327,8 @@ sub GenerateGetOwnPropertySlotBody
&$manualLookupGetterGeneration();
}
- if ($dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
- push(@getOwnPropertySlotImpl, " if (customGetOwnPropertySlot(exec, propertyName, slot))\n");
+ if ($dataNode->extendedAttributes->{"DelegatingGetOwnPropertySlot"}) {
+ push(@getOwnPropertySlotImpl, " if (getOwnPropertySlotDelegate(exec, propertyName, slot))\n");
push(@getOwnPropertySlotImpl, " return true;\n");
}
@@ -378,36 +377,38 @@ sub GenerateHeader
my $conditionalString;
if ($conditional) {
$conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
- push(@headerContentHeader, "\n#if ${conditionalString}\n\n");
+ push(@headerContentHeader, "#if ${conditionalString}\n\n");
}
if ($hasParent) {
- push(@headerContentHeader, "#include \"$parentClassName.h\"\n");
+ $headerIncludes{"$parentClassName.h"} = 1;
} else {
- push(@headerContentHeader, "#include \"JSDOMBinding.h\"\n");
- push(@headerContentHeader, "#include <runtime/JSGlobalObject.h>\n");
- push(@headerContentHeader, "#include <runtime/ObjectPrototype.h>\n");
+ $headerIncludes{"JSDOMBinding.h"} = 1;
+ $headerIncludes{"<runtime/JSGlobalObject.h>"} = 1;
+ $headerIncludes{"<runtime/ObjectPrototype.h>"} = 1;
}
if ($dataNode->extendedAttributes->{"CustomCall"}) {
- push(@headerContentHeader, "#include <runtime/CallData.h>\n");
+ $headerIncludes{"<runtime/CallData.h>"} = 1;
}
if ($dataNode->extendedAttributes->{"InlineGetOwnPropertySlot"}) {
- push(@headerContentHeader, "#include <runtime/Lookup.h>\n");
- push(@headerContentHeader, "#include <wtf/AlwaysInline.h>\n");
+ $headerIncludes{"<runtime/Lookup.h>"} = 1;
+ $headerIncludes{"<wtf/AlwaysInline.h>"} = 1;
}
if ($hasParent && $dataNode->extendedAttributes->{"GenerateNativeConverter"}) {
- push(@headerContentHeader, "#include \"${implClassName}.h\"");
+ $headerIncludes{"$implClassName.h"} = 1;
}
+ $headerIncludes{"SVGElement.h"} = 1 if $className =~ /^JSSVG/;
+
# Get correct pass/store types respecting PODType flag
my $podType = $dataNode->extendedAttributes->{"PODType"};
my $implType = $podType ? "JSSVGPODTypeWrapper<$podType> " : $implClassName;
- push(@headerContentHeader, "#include \"$podType.h\"\n") if $podType and $podType ne "float";
+ $headerIncludes{"$podType.h"} = 1 if $podType and $podType ne "float";
- push(@headerContentHeader, "#include \"JSSVGPODTypeWrapper.h\"\n") if $podType;
+ $headerIncludes{"JSSVGPODTypeWrapper.h"} = 1 if $podType;
my $numConstants = @{$dataNode->constants};
my $numAttributes = @{$dataNode->attributes};
@@ -439,13 +440,14 @@ sub GenerateHeader
# Prototype
push(@headerContent, " static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);\n") unless ($dataNode->extendedAttributes->{"ExtendsDOMGlobalObject"});
- $implIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"} || $dataNode->extendedAttributes->{"CustomPutFunction"};
+ $implIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"} || $dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"DelegatingPutFunction"};
my $hasGetter = $numAttributes > 0
|| $dataNode->extendedAttributes->{"GenerateConstructor"}
|| $dataNode->extendedAttributes->{"HasIndexGetter"}
|| $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
+ || $dataNode->extendedAttributes->{"DelegatingGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"HasNameGetter"}
|| $dataNode->extendedAttributes->{"HasOverridingNameGetter"};
@@ -453,7 +455,7 @@ sub GenerateHeader
if ($hasGetter) {
push(@headerContent, " virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);\n");
push(@headerContent, " virtual bool getOwnPropertySlot(JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);\n") if ($dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}) && !$dataNode->extendedAttributes->{"HasOverridingNameGetter"};
- push(@headerContent, " bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
+ push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingGetOwnPropertySlot"};
}
# Check if we have any writable properties
@@ -466,13 +468,14 @@ sub GenerateHeader
my $hasSetter = $hasReadWriteProperties
|| $dataNode->extendedAttributes->{"CustomPutFunction"}
+ || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
|| $dataNode->extendedAttributes->{"HasCustomIndexSetter"};
# Getters
if ($hasSetter) {
push(@headerContent, " virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
push(@headerContent, " virtual void put(JSC::ExecState*, unsigned propertyName, JSC::JSValue);\n") if $dataNode->extendedAttributes->{"HasCustomIndexSetter"};
- push(@headerContent, " bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomPutFunction"};
+ push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingPutFunction"};
}
# Class info
@@ -508,7 +511,6 @@ sub GenerateHeader
# Custom getPropertyNames function
push(@headerContent, " virtual void getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);\n") if ($dataNode->extendedAttributes->{"CustomGetPropertyNames"} || $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"});
- push(@headerContent, " bool customGetPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);\n") if $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
# Custom getPropertyAttributes function
push(@headerContent, " virtual bool getPropertyAttributes(JSC::ExecState*, const JSC::Identifier&, unsigned& attributes) const;\n") if $dataNode->extendedAttributes->{"CustomGetPropertyAttributes"};
@@ -620,7 +622,7 @@ sub GenerateHeader
push(@headerContent, "};\n\n");
- if ($dataNode->extendedAttributes->{"InlineGetOwnPropertySlot"}) {
+ if ($dataNode->extendedAttributes->{"InlineGetOwnPropertySlot"} && !$dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
push(@headerContent, "ALWAYS_INLINE bool ${className}::getOwnPropertySlot(JSC::ExecState* exec, const JSC::Identifier& propertyName, JSC::PropertySlot& slot)\n");
push(@headerContent, "{\n");
push(@headerContent, GenerateGetOwnPropertySlotBody($dataNode, $interfaceName, $className, $implClassName, $numAttributes > 0, 1));
@@ -664,9 +666,9 @@ sub GenerateHeader
}
push(@headerContent, " virtual const JSC::ClassInfo* classInfo() const { return &s_info; }\n");
push(@headerContent, " static const JSC::ClassInfo s_info;\n");
- if ($numFunctions > 0 || $numConstants > 0 || $dataNode->extendedAttributes->{"CustomPrototypeGetOwnPropertySlot"}) {
+ if ($numFunctions > 0 || $numConstants > 0 || $dataNode->extendedAttributes->{"DelegatingPrototypeGetOwnPropertySlot"}) {
push(@headerContent, " virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n");
- push(@headerContent, " bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomPrototypeGetOwnPropertySlot"};
+ push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingPrototypeGetOwnPropertySlot"};
push(@headerContent,
" static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)\n" .
@@ -674,9 +676,9 @@ sub GenerateHeader
" return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));\n" .
" }\n");
}
- if ($dataNode->extendedAttributes->{"CustomPrototypePutFunction"}) {
+ if ($dataNode->extendedAttributes->{"DelegatingPrototypePutFunction"}) {
push(@headerContent, " virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
- push(@headerContent, " bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n");
+ push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n");
}
# Custom defineGetter function
@@ -741,25 +743,19 @@ sub GenerateImplementation
# - Add default header template
@implContentHeader = split("\r", $headerTemplate);
- push(@implContentHeader, "\n#include \"config.h\"\n\n");
+
+ push(@implContentHeader, "\n#include \"config.h\"\n");
my $conditionalString;
if ($conditional) {
$conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
push(@implContentHeader, "\n#if ${conditionalString}\n\n");
}
-
- if ($className =~ /^JSSVG/) {
- push(@implContentHeader, "#include \"SVGElement.h\"\n");
-
- if ($className =~ /^JSSVGAnimated/) {
- AddIncludesForSVGAnimatedType($interfaceName);
- }
- }
-
push(@implContentHeader, "#include \"$className.h\"\n\n");
- push(@implContentHeader, "#include <wtf/GetPtr.h>\n\n");
- push(@implContentHeader, "#include <runtime/PropertyNameArray.h>\n") if $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"};
+ AddIncludesForSVGAnimatedType($interfaceName) if $className =~ /^JSSVGAnimated/;
+
+ $implIncludes{"<wtf/GetPtr.h>"} = 1;
+ $implIncludes{"<runtime/PropertyNameArray.h>"} = 1 if $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"};
AddIncludesForType($interfaceName);
@@ -924,12 +920,12 @@ sub GenerateImplementation
push(@implContent, " return getDOMPrototype<${className}>(exec, globalObject);\n");
push(@implContent, "}\n\n");
}
- if ($numConstants > 0 || $numFunctions > 0 || $dataNode->extendedAttributes->{"CustomPrototypeGetOwnPropertySlot"}) {
+ if ($numConstants > 0 || $numFunctions > 0 || $dataNode->extendedAttributes->{"DelegatingPrototypeGetOwnPropertySlot"}) {
push(@implContent, "bool ${className}Prototype::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)\n");
push(@implContent, "{\n");
- if ($dataNode->extendedAttributes->{"CustomPrototypeGetOwnPropertySlot"}) {
- push(@implContent, " if (customGetOwnPropertySlot(exec, propertyName, slot))\n");
+ if ($dataNode->extendedAttributes->{"DelegatingPrototypeGetOwnPropertySlot"}) {
+ push(@implContent, " if (getOwnPropertySlotDelegate(exec, propertyName, slot))\n");
push(@implContent, " return true;\n");
}
@@ -945,10 +941,10 @@ sub GenerateImplementation
push(@implContent, "}\n\n");
}
- if ($dataNode->extendedAttributes->{"CustomPrototypePutFunction"}) {
+ if ($dataNode->extendedAttributes->{"DelegatingPrototypePutFunction"}) {
push(@implContent, "void ${className}Prototype::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)\n");
push(@implContent, "{\n");
- push(@implContent, " if (customPut(exec, propertyName, value, slot))\n");
+ push(@implContent, " if (putDelegate(exec, propertyName, value, slot))\n");
push(@implContent, " return;\n");
push(@implContent, " Base::put(exec, propertyName, value, slot);\n");
push(@implContent, "}\n\n");
@@ -1063,13 +1059,14 @@ sub GenerateImplementation
|| $dataNode->extendedAttributes->{"GenerateConstructor"}
|| $dataNode->extendedAttributes->{"HasIndexGetter"}
|| $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
+ || $dataNode->extendedAttributes->{"DelegatingGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"HasNameGetter"}
|| $dataNode->extendedAttributes->{"HasOverridingNameGetter"};
# Attributes
if ($hasGetter) {
- if (!$dataNode->extendedAttributes->{"InlineGetOwnPropertySlot"}) {
+ if (!$dataNode->extendedAttributes->{"InlineGetOwnPropertySlot"} && !$dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
push(@implContent, "bool ${className}::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)\n");
push(@implContent, "{\n");
push(@implContent, GenerateGetOwnPropertySlotBody($dataNode, $interfaceName, $className, $implClassName, $numAttributes > 0, 0));
@@ -1156,7 +1153,18 @@ sub GenerateImplementation
}
} else {
push(@implContent, " $implClassName* imp = static_cast<$implClassName*>(static_cast<$className*>(asObject(slot.slotBase()))->impl());\n");
- my $jsType = NativeToJSValue($attribute->signature, 0, $implClassName, $implClassNameForValueConversion, "imp->$implGetterFunctionName()", "static_cast<$className*>(asObject(slot.slotBase()))");
+ my $value;
+ my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
+ my $reflectURL = $attribute->signature->extendedAttributes->{"ReflectURL"};
+ if ($reflect || $reflectURL) {
+ $implIncludes{"HTMLNames.h"} = 1;
+ my $contentAttributeName = (($reflect || $reflectURL) eq "1") ? $name : ($reflect || $reflectURL);
+ my $getAttributeFunctionName = $reflectURL ? "getURLAttribute" : "getAttribute";
+ $value = "imp->$getAttributeFunctionName(HTMLNames::${contentAttributeName}Attr)"
+ } else {
+ $value = "imp->$implGetterFunctionName()";
+ }
+ my $jsType = NativeToJSValue($attribute->signature, 0, $implClassName, $implClassNameForValueConversion, $value, "static_cast<$className*>(asObject(slot.slotBase()))");
if ($codeGenerator->IsSVGAnimatedType($type)) {
push(@implContent, " RefPtr<$type> obj = $jsType;\n");
push(@implContent, " return toJS(exec, obj.get(), imp);\n");
@@ -1205,31 +1213,33 @@ sub GenerateImplementation
}
my $hasSetter = $hasReadWriteProperties
- || $dataNode->extendedAttributes->{"CustomPutFunction"}
+ || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
|| $dataNode->extendedAttributes->{"HasCustomIndexSetter"};
if ($hasSetter) {
- push(@implContent, "void ${className}::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)\n");
- push(@implContent, "{\n");
- if ($dataNode->extendedAttributes->{"HasCustomIndexSetter"}) {
- push(@implContent, " bool ok;\n");
- push(@implContent, " unsigned index = propertyName.toUInt32(&ok, false);\n");
- push(@implContent, " if (ok) {\n");
- push(@implContent, " indexSetter(exec, index, value);\n");
- push(@implContent, " return;\n");
- push(@implContent, " }\n");
- }
- if ($dataNode->extendedAttributes->{"CustomPutFunction"}) {
- push(@implContent, " if (customPut(exec, propertyName, value, slot))\n");
- push(@implContent, " return;\n");
- }
+ if (!$dataNode->extendedAttributes->{"CustomPutFunction"}) {
+ push(@implContent, "void ${className}::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)\n");
+ push(@implContent, "{\n");
+ if ($dataNode->extendedAttributes->{"HasCustomIndexSetter"}) {
+ push(@implContent, " bool ok;\n");
+ push(@implContent, " unsigned index = propertyName.toUInt32(&ok, false);\n");
+ push(@implContent, " if (ok) {\n");
+ push(@implContent, " indexSetter(exec, index, value);\n");
+ push(@implContent, " return;\n");
+ push(@implContent, " }\n");
+ }
+ if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+ push(@implContent, " if (putDelegate(exec, propertyName, value, slot))\n");
+ push(@implContent, " return;\n");
+ }
- if ($hasReadWriteProperties) {
- push(@implContent, " lookupPut<$className, Base>(exec, propertyName, value, " . hashTableAccessor($dataNode->extendedAttributes->{"NoStaticTables"}, $className) . ", this, slot);\n");
- } else {
- push(@implContent, " Base::put(exec, propertyName, value, slot);\n");
+ if ($hasReadWriteProperties) {
+ push(@implContent, " lookupPut<$className, Base>(exec, propertyName, value, " . hashTableAccessor($dataNode->extendedAttributes->{"NoStaticTables"}, $className) . ", this, slot);\n");
+ } else {
+ push(@implContent, " Base::put(exec, propertyName, value, slot);\n");
+ }
+ push(@implContent, "}\n\n");
}
- push(@implContent, "}\n\n");
if ($dataNode->extendedAttributes->{"HasCustomIndexSetter"}) {
push(@implContent, "void ${className}::put(ExecState* exec, unsigned propertyName, JSValue value)\n");
@@ -1295,8 +1305,17 @@ sub GenerateImplementation
push(@implContent, " static_cast<$className*>(thisObject)->impl()->commitChange(imp, static_cast<$className*>(thisObject)->context());\n");
} else {
push(@implContent, " $implClassName* imp = static_cast<$implClassName*>(static_cast<$className*>(thisObject)->impl());\n");
+ my $nativeValue = JSValueToNative($attribute->signature, "value");
push(@implContent, " ExceptionCode ec = 0;\n") if @{$attribute->setterExceptions};
- push(@implContent, " imp->set$implSetterFunctionName(" . JSValueToNative($attribute->signature, "value"));
+ my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
+ my $reflectURL = $attribute->signature->extendedAttributes->{"ReflectURL"};
+ if ($reflect || $reflectURL) {
+ $implIncludes{"HTMLNames.h"} = 1;
+ my $contentAttributeName = (($reflect || $reflectURL) eq "1") ? $name : ($reflect || $reflectURL);
+ push(@implContent, " imp->setAttribute(HTMLNames::${contentAttributeName}Attr, $nativeValue");
+ } else {
+ push(@implContent, " imp->set$implSetterFunctionName($nativeValue");
+ }
push(@implContent, ", ec") if @{$attribute->setterExceptions};
push(@implContent, ");\n");
push(@implContent, " setDOMException(exec, ec);\n") if @{$attribute->setterExceptions};
@@ -1315,13 +1334,9 @@ sub GenerateImplementation
}
}
- if ($dataNode->extendedAttributes->{"CustomGetPropertyNames"} || $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}) {
+ if (($dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}) && !$dataNode->extendedAttributes->{"CustomGetPropertyNames"}) {
push(@implContent, "void ${className}::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)\n");
push(@implContent, "{\n");
- if ($dataNode->extendedAttributes->{"CustomGetPropertyNames"}) {
- push(@implContent, " if (customGetPropertyNames(exec, propertyNames))\n");
- push(@implContent, " return;\n");
- }
if ($dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}) {
push(@implContent, " for (unsigned i = 0; i < static_cast<${implClassName}*>(impl())->length(); ++i)\n");
push(@implContent, " propertyNames.add(Identifier::from(exec, i));\n");
@@ -1348,7 +1363,7 @@ sub GenerateImplementation
push(@implContent, "{\n");
push(@implContent, " UNUSED_PARAM(args);\n");
- $implKJSInclude{"Error.h"} = 1;
+ $implIncludes{"<runtime/Error.h>"} = 1;
if ($interfaceName eq "DOMWindow") {
push(@implContent, " $className* castedThisObj = toJSDOMWindow(thisValue.toThisObject(exec));\n");
@@ -1664,7 +1679,7 @@ sub NativeToJSValue
return "jsBoolean($value)" if $type eq "boolean";
if ($codeGenerator->IsPrimitiveType($type) or $type eq "SVGPaintType" or $type eq "DOMTimeStamp") {
- $implKJSInclude{"JSNumberCell.h"} = 1;
+ $implIncludes{"<runtime/JSNumberCell.h>"} = 1;
return "jsNumber(exec, $value)";
}
@@ -1678,7 +1693,7 @@ sub NativeToJSValue
die "Unknown value for ConvertNullStringTo extended attribute";
}
- $implKJSInclude{"JSString.h"} = 1;
+ $implIncludes{"<runtime/JSString.h>"} = 1;
return "jsString(exec, $value)";
}
@@ -1964,17 +1979,17 @@ sub WriteData
# Write content to file.
print $IMPL @implContentHeader;
- foreach my $implInclude (sort keys(%implIncludes)) {
- my $checkType = $implInclude;
+ my @includes = ();
+ foreach my $include (keys %implIncludes) {
+ my $checkType = $include;
$checkType =~ s/\.h//;
+ next if $codeGenerator->IsSVGAnimatedType($checkType);
- print $IMPL "#include \"$implInclude\"\n" unless $codeGenerator->IsSVGAnimatedType($checkType);
+ $include = "\"$include\"" unless $include =~ /^["<]/; # "
+ push @includes, $include;
}
-
- print $IMPL "\n";
-
- foreach my $implKJSInclude (sort keys(%implKJSInclude)) {
- print $IMPL "#include <runtime/$implKJSInclude>\n";
+ foreach my $include (sort @includes) {
+ print $IMPL "#include $include\n";
}
print $IMPL @implContent;
@@ -1984,15 +1999,19 @@ sub WriteData
@implContentHeader = ();
@implContent = ();
%implIncludes = ();
- %implKJSIncludes = ();
}
if (defined($HEADER)) {
# Write content to file.
print $HEADER @headerContentHeader;
- foreach my $headerInclude (sort keys(%headerIncludes)) {
- print $HEADER "#include \"$headerInclude\"\n";
+ my @includes = ();
+ foreach my $include (keys %headerIncludes) {
+ $include = "\"$include\"" unless $include =~ /^["<]/; # "
+ push @includes, $include;
+ }
+ foreach my $include (sort @includes) {
+ print $HEADER "#include $include\n";
}
print $HEADER @headerContent;
@@ -2057,7 +2076,7 @@ bool ${className}Constructor::getOwnPropertySlot(ExecState* exec, const Identifi
EOF
- $implKJSInclude{"JSNumberCell.h"} = 1;
+ $implJSCInclude{"JSNumberCell.h"} = 1;
return $implContent;
}
diff --git a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorObjC.pm b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorObjC.pm
index fc265f9..10628b4 100644
--- a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorObjC.pm
+++ b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorObjC.pm
@@ -1129,7 +1129,17 @@ sub GenerateImplementation
# - GETTER
my $getterSig = "- ($attributeType)$attributeInterfaceName\n";
my $hasGetterException = @{$attribute->getterExceptions};
- my $getterContentHead = "IMPL->" . $codeGenerator->WK_lcfirst($attributeName) . "(";
+ my $getterContentHead;
+ my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
+ my $reflectURL = $attribute->signature->extendedAttributes->{"ReflectURL"};
+ if ($reflect || $reflectURL) {
+ $implIncludes{"HTMLNames.h"} = 1;
+ my $contentAttributeName = (($reflect || $reflectURL) eq "1") ? $attributeName : ($reflect || $reflectURL);
+ my $getAttributeFunctionName = $reflectURL ? "getURLAttribute" : "getAttribute";
+ $getterContentHead = "IMPL->${getAttributeFunctionName}(WebCore::HTMLNames::${contentAttributeName}Attr";
+ } else {
+ $getterContentHead = "IMPL->" . $codeGenerator->WK_lcfirst($attributeName) . "(";
+ }
my $getterContentTail = ")";
# Special case for DOMSVGNumber
@@ -1226,7 +1236,7 @@ sub GenerateImplementation
# Exception handling
my $hasSetterException = @{$attribute->setterExceptions};
- $attributeName = "set" . $codeGenerator->WK_ucfirst($attributeName);
+ my $coreSetterName = "set" . $codeGenerator->WK_ucfirst($attributeName);
my $setterName = "set" . ucfirst($attributeInterfaceName);
my $argName = "new" . ucfirst($attributeInterfaceName);
my $arg = GetObjCTypeGetter($argName, $idlType);
@@ -1252,14 +1262,22 @@ sub GenerateImplementation
if ($podType eq "float") {
push(@implContent, " *IMPL = $arg;\n");
} else {
- push(@implContent, " IMPL->$attributeName($arg);\n");
+ push(@implContent, " IMPL->$coreSetterName($arg);\n");
}
} elsif ($hasSetterException) {
push(@implContent, " $exceptionInit\n");
- push(@implContent, " IMPL->$attributeName($arg, ec);\n");
+ push(@implContent, " IMPL->$coreSetterName($arg, ec);\n");
push(@implContent, " $exceptionRaiseOnError\n");
} else {
- push(@implContent, " IMPL->$attributeName($arg);\n");
+ my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
+ my $reflectURL = $attribute->signature->extendedAttributes->{"ReflectURL"};
+ if ($reflect || $reflectURL) {
+ $implIncludes{"HTMLNames.h"} = 1;
+ my $contentAttributeName = (($reflect || $reflectURL) eq "1") ? $attributeName : ($reflect || $reflectURL);
+ push(@implContent, " IMPL->setAttribute(WebCore::HTMLNames::${contentAttributeName}Attr, $arg);\n");
+ } else {
+ push(@implContent, " IMPL->$coreSetterName($arg);\n");
+ }
}
push(@implContent, "}\n\n");
diff --git a/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorV8.pm b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorV8.pm
new file mode 100644
index 0000000..088668e
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/bindings/scripts/CodeGeneratorV8.pm
@@ -0,0 +1,2191 @@
+
+# Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
+# Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
+# Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
+# Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
+# Copyright (C) 2006 Apple Computer, Inc.
+# Copyright (C) 2007, 2008, 2009 Google Inc.
+#
+# This file is part of the KDE project
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Library General Public
+# License as published by the Free Software Foundation; either
+# version 2 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# Library General Public License for more details.
+#
+# You should have received a copy of the GNU Library General Public License
+# aint with this library; see the file COPYING.LIB. If not, write to
+# the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+# Boston, MA 02111-1307, USA.
+#
+
+package CodeGeneratorV8;
+
+use File::stat;
+
+my $module = "";
+my $outputDir = "";
+
+my @headerContent = ();
+my @implContentHeader = ();
+my @implFixedHeader = ();
+my @implContent = ();
+my @implContentDecls = ();
+my %implIncludes = ();
+
+my @allParents = ();
+
+# Default .h template
+my $headerTemplate = << "EOF";
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA.
+*/
+EOF
+
+# Default constructor
+sub new
+{
+ my $object = shift;
+ my $reference = { };
+
+ $codeGenerator = shift;
+ $outputDir = shift;
+
+ bless($reference, $object);
+ return $reference;
+}
+
+sub finish
+{
+ my $object = shift;
+
+ # Commit changes!
+ $object->WriteData();
+}
+
+sub leftShift($$) {
+ my ($value, $distance) = @_;
+ return (($value << $distance) & 0xFFFFFFFF);
+}
+
+# Uppercase the first letter, while respecting WebKit style guidelines.
+# E.g., xmlEncoding becomes XMLEncoding, but xmlllang becomes Xmllang.
+sub WK_ucfirst
+{
+ my $param = shift;
+ my $ret = ucfirst($param);
+ $ret =~ s/Xml/XML/ if $ret =~ /^Xml[^a-z]/;
+ return $ret;
+}
+
+# Lowercase the first letter while respecting WebKit style guidelines.
+# URL becomes url, but SetURL becomes setURL.
+sub WK_lcfirst
+{
+ my $param = shift;
+ my $ret = lcfirst($param);
+ $ret =~ s/uRL/url/;
+ return $ret;
+}
+
+# Workaround for V8 bindings difference where RGBColor is not a POD type.
+sub IsPodType
+{
+ my $type = shift;
+ return 0 if $type eq "RGBColor";
+ return $codeGenerator->IsPodType($type);
+}
+
+# Params: 'domClass' struct
+sub GenerateInterface
+{
+ my $object = shift;
+ my $dataNode = shift;
+ my $defines = shift;
+
+ # Start actual generation
+ $object->GenerateHeader($dataNode);
+ $object->GenerateImplementation($dataNode);
+
+ my $name = $dataNode->name;
+
+ # Open files for writing
+ my $headerFileName = "$outputDir/V8$name.h";
+ my $implFileName = "$outputDir/V8$name.cpp";
+
+ open($IMPL, ">$implFileName") || die "Couldn't open file $implFileName";
+ open($HEADER, ">$headerFileName") || die "Couldn't open file $headerFileName";
+}
+
+# Params: 'idlDocument' struct
+sub GenerateModule
+{
+ my $object = shift;
+ my $dataNode = shift;
+
+ $module = $dataNode->module;
+}
+
+sub GetLegacyHeaderIncludes
+{
+ my $legacyParent = shift;
+
+ die "Don't know what headers to include for module $module";
+}
+
+sub AvoidInclusionOfType
+{
+ my $type = shift;
+
+ # Special case: SVGRect.h / SVGPoint.h / SVGNumber.h / SVGMatrix.h do not exist.
+ return 1 if $type eq "SVGRect" or $type eq "SVGPoint" or $type eq "SVGNumber" or $type eq "SVGMatrix";
+ return 0;
+}
+
+sub UsesManualToJSImplementation
+{
+ my $type = shift;
+
+ return 1 if $type eq "SVGPathSeg";
+ return 0;
+}
+
+sub AddIncludesForType
+{
+ my $type = $codeGenerator->StripModule(shift);
+
+ # When we're finished with the one-file-per-class
+ # reorganization, we won't need these special cases.
+ if ($codeGenerator->IsPrimitiveType($type) or AvoidInclusionOfType($type)) {
+ } elsif ($type =~ /SVGPathSeg/) {
+ $joinedName = $type;
+ $joinedName =~ s/Abs|Rel//;
+ $implIncludes{"${joinedName}.h"} = 1;
+ } else {
+ # default, include the same named file
+ $implIncludes{GetImplementationFileName(${type})} = 1;
+ }
+
+ # additional includes (things needed to compile the bindings but not the header)
+
+ if ($type eq "CanvasRenderingContext2D") {
+ $implIncludes{"CanvasGradient.h"} = 1;
+ $implIncludes{"CanvasPattern.h"} = 1;
+ $implIncludes{"CanvasStyle.h"} = 1;
+ }
+
+ if ($type eq "CanvasGradient" or $type eq "XPathNSResolver") {
+ $implIncludes{"PlatformString.h"} = 1;
+ }
+
+ if ($type eq "CSSStyleDeclaration") {
+ $implIncludes{"CSSMutableStyleDeclaration.h"} = 1;
+ }
+
+ if ($type eq "Plugin" or $type eq "PluginArray" or $type eq "MimeTypeArray") {
+ # So we can get String -> AtomicString conversion for namedItem().
+ $implIncludes{"AtomicString.h"} = 1;
+ }
+}
+
+sub AddIncludesForSVGAnimatedType
+{
+ my $type = shift;
+ $type =~ s/SVGAnimated//;
+
+ if ($type eq "Point" or $type eq "Rect") {
+ $implIncludes{"Float$type.h"} = 1;
+ } elsif ($type eq "String") {
+ $implIncludes{"PlatformString.h"} = 1;
+ }
+
+ $implIncludes{"SVGAnimatedTemplate.h"} = 1;
+}
+
+sub AddClassForwardIfNeeded
+{
+ my $implClassName = shift;
+
+ # SVGAnimatedLength/Number/etc.. are typedefs to SVGAnimtatedTemplate, so don't use class forwards for them!
+ push(@headerContent, "class $implClassName;\n\n") unless $codeGenerator->IsSVGAnimatedType($implClassName);
+}
+
+sub GetImplementationFileName
+{
+ my $iface = shift;
+ return "HTMLCollection.h" if $iface eq "UndetectableHTMLCollection";
+ return "Event.h" if $iface eq "DOMTimeStamp";
+ return "NamedAttrMap.h" if $iface eq "NamedNodeMap";
+ return "NameNodeList.h" if $iface eq "NodeList";
+ return "XMLHttpRequest.h" if $iface eq "XMLHttpRequest";
+
+ return "${iface}.h";
+}
+
+sub GenerateHeader
+{
+ my $object = shift;
+ my $dataNode = shift;
+
+ my $interfaceName = $dataNode->name;
+ my $className = "V8$interfaceName";
+ my $implClassName = $interfaceName;
+
+ # Copy contents of parent classes except the first parent or if it is
+ # EventTarget.
+ $codeGenerator->AddMethodsConstantsAndAttributesFromParentClasses($dataNode);
+
+ my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+ my $conditional = $dataNode->extendedAttributes->{"Conditional"};
+
+ # - Add default header template
+ @headerContent = split("\r", $headerTemplate);
+
+ my $conditionalString;
+ if ($conditional) {
+ $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
+ push(@headerContent, "\n#if ${conditionalString}\n\n");
+ }
+
+ push(@headerContent, "\n#ifndef $className" . "_H");
+ push(@headerContent, "\n#define $className" . "_H\n\n");
+
+ # Get correct pass/store types respecting PODType flag
+ my $podType = $dataNode->extendedAttributes->{"PODType"};
+ my $passType = $podType ? "JSSVGPODTypeWrapper<$podType>*" : "$implClassName*";
+
+ push(@headerContent, "#include \"$podType.h\"\n") if $podType and ($podType ne "double" and $podType ne "float" and $podType ne "RGBA32");
+
+ push(@headerContent, "#include <v8.h>\n");
+ push(@headerContent, "#include <wtf/HashMap.h>\n");
+ push(@headerContent, "#include \"StringHash.h\"\n");
+
+ push(@headerContent, "\nnamespace WebCore {\n\n");
+ push(@headerContent, "class V8ClassIndex;\n");
+ push(@headerContent, "\nclass $className {\n");
+ push(@headerContent, <<END);
+
+ public:
+ static bool HasInstance(v8::Handle<v8::Value> value);
+ static v8::Persistent<v8::FunctionTemplate> GetRawTemplate();
+END
+
+ if ($implClassName eq "DOMWindow") {
+ push(@headerContent, <<END);
+ static v8::Persistent<v8::ObjectTemplate> GetShadowObjectTemplate();
+END
+ }
+
+ push(@headerContent, <<END);
+
+ private:
+ static v8::Persistent<v8::FunctionTemplate> GetTemplate();
+
+ friend class V8ClassIndex;
+};
+
+END
+
+ push(@headerContent, "}\n\n");
+ push(@headerContent, "#endif // $className" . "_H\n");
+
+ push(@headerContent, "#endif // ${conditionalString}\n\n") if $conditional;
+}
+
+
+sub GenerateSetDOMException
+{
+ my $indent = shift;
+ my $result = "";
+
+ $result .= $indent . "if (ec) {\n";
+ $result .= $indent . " V8Proxy::setDOMException(ec);\n";
+ $result .= $indent . " return v8::Handle<v8::Value>();\n";
+ $result .= $indent . "}\n";
+
+ return $result;
+}
+
+sub IsNodeSubType
+{
+ my $dataNode = shift;
+ return 1 if ($dataNode->name eq "Node");
+ foreach (@allParents) {
+ my $parent = $codeGenerator->StripModule($_);
+ return 1 if $parent eq "Node";
+ }
+ return 0;
+}
+
+sub HolderToNative
+{
+ my $dataNode = shift;
+ my $implClassName = shift;
+ my $classIndex = shift;
+
+ if (IsNodeSubType($dataNode)) {
+ push(@implContentDecls, <<END);
+ $implClassName* imp = V8Proxy::convertDOMWrapperToNode<$implClassName>(holder);
+END
+
+ } else {
+ push(@implContentDecls, <<END);
+ $implClassName* imp = V8Proxy::convertToNativeObject<$implClassName>(V8ClassIndex::$classIndex, holder);
+END
+
+ }
+}
+
+sub GenerateDomainSafeFunctionGetter
+{
+ my $function = shift;
+ my $dataNode = shift;
+ my $classIndex = shift;
+ my $implClassName = shift;
+
+ my $className = "V8" . $dataNode->name;
+ my $funcName = $function->signature->name;
+
+ my $signature = "v8::Signature::New(" . $className . "::GetRawTemplate())";
+ if ($function->signature->extendedAttributes->{"V8DoNotCheckSignature"}) {
+ $signature = "v8::Local<v8::Signature>()";
+ }
+
+ my $newTemplateString = GenerateNewFunctionTemplate($function, $dataNode, $signature);
+
+ $implIncludes{"V8Proxy.h"} = 1;
+
+ push(@implContentDecls, <<END);
+ static v8::Handle<v8::Value> ${funcName}AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) {
+ INC_STATS(\"DOM.$implClassName.$funcName._get\");
+ static v8::Persistent<v8::FunctionTemplate> private_template =
+ v8::Persistent<v8::FunctionTemplate>::New($newTemplateString);
+ v8::Handle<v8::Object> holder = V8Proxy::lookupDOMWrapper(V8ClassIndex::$classIndex, info.This());
+ if (holder.IsEmpty()) {
+ // can only reach here by 'object.__proto__.func', and it should passed
+ // domain security check already
+
+ return private_template->GetFunction();
+ }
+END
+
+ HolderToNative($dataNode, $implClassName, $classIndex);
+
+ push(@implContentDecls, <<END);
+ if (!V8Proxy::canAccessFrame(imp->frame(), false)) {
+ static v8::Persistent<v8::FunctionTemplate> shared_template =
+ v8::Persistent<v8::FunctionTemplate>::New($newTemplateString);
+ return shared_template->GetFunction();
+
+ } else {
+ return private_template->GetFunction();
+ }
+ }
+
+END
+}
+
+sub GenerateConstructorGetter
+{
+ my $implClassName = shift;
+ my $classIndex = shift;
+
+ push(@implContentDecls, <<END);
+ static v8::Handle<v8::Value> ${implClassName}ConstructorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) {
+ INC_STATS(\"DOM.$implClassName.constructors._get\");
+ v8::Handle<v8::Value> data = info.Data();
+ ASSERT(data->IsNumber());
+ V8ClassIndex::V8WrapperType type = V8ClassIndex::FromInt(data->Int32Value());
+END
+
+ if ($classIndex eq "DOMWINDOW") {
+ push(@implContentDecls, <<END);
+ DOMWindow* window = V8Proxy::convertToNativeObject<DOMWindow>(V8ClassIndex::DOMWINDOW, info.Holder());
+ Frame* frame = window->frame();
+ if (frame) {
+ // Get the proxy corresponding to the DOMWindow if possible to
+ // make sure that the constructor function is constructed in the
+ // context of the DOMWindow and not in the context of the caller.
+ return V8Proxy::retrieve(frame)->getConstructor(type);
+ }
+END
+ }
+
+ if ($classIndex eq "WORKERCONTEXT") {
+ $implIncludes{"WorkerContextExecutionProxy.h"} = 1;
+ push(@implContentDecls, <<END);
+ return WorkerContextExecutionProxy::retrieve()->GetConstructor(type);
+END
+ } else {
+ push(@implContentDecls, " return v8::Undefined();");
+ }
+
+ push(@implContentDecls, <<END);
+
+ }
+
+END
+}
+
+sub GenerateNormalAttrGetter
+{
+ my $attribute = shift;
+ my $dataNode = shift;
+ my $classIndex = shift;
+ my $implClassName = shift;
+
+ my $attrExt = $attribute->signature->extendedAttributes;
+
+ my $attrName = $attribute->signature->name;
+ $implIncludes{"V8Proxy.h"} = 1;
+
+ my $attrType = $codeGenerator->StripModule($attribute->signature->type);
+ my $attrIsPodType = IsPodType($attrType);
+
+ my $nativeType = GetNativeTypeFromSignature($attribute->signature, 0);
+ my $isPodType = IsPodType($implClassName);
+ my $skipContext = 0;
+
+
+ if ($isPodType) {
+ $implClassName = GetNativeType($implClassName);
+ $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
+ }
+
+ # Special case: SVGZoomEvent's attributes are all read-only
+ if ($implClassName eq "SVGZoomEvent") {
+ $attrIsPodType = 0;
+ $skipContext = 1;
+ }
+
+ # Special case: SVGSVGEelement::viewport is read-only
+ if (($implClassName eq "SVGSVGElement") and ($attrName eq "viewport")) {
+ $attrIsPodType = 0;
+ $skipContext = 1;
+ }
+
+ # Special case for SVGColor
+ if (($implClassName eq "SVGColor") and ($attrName eq "rgbColor")) {
+ $attrIsPodType = 0;
+ }
+
+ my $getterStringUsesImp = $implClassName ne "double";
+
+ # Getter
+ push(@implContentDecls, <<END);
+ static v8::Handle<v8::Value> ${attrName}AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) {
+ INC_STATS(\"DOM.$implClassName.$attrName._get\");
+END
+
+ if ($isPodType) {
+ push(@implContentDecls, <<END);
+ V8SVGPODTypeWrapper<$implClassName>* imp_wrapper = V8Proxy::convertToNativeObject<V8SVGPODTypeWrapper<$implClassName> >(V8ClassIndex::$classIndex, info.Holder());
+ $implClassName imp_instance = *imp_wrapper;
+END
+ if ($getterStringUsesImp) {
+ push(@implContentDecls, <<END);
+ $implClassName* imp = &imp_instance;
+END
+ }
+
+ } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8DisallowShadowing"}) {
+ # perform lookup first
+ push(@implContentDecls, <<END);
+ v8::Handle<v8::Object> holder = V8Proxy::lookupDOMWrapper(V8ClassIndex::$classIndex, info.This());
+ if (holder.IsEmpty()) return v8::Undefined();
+END
+ HolderToNative($dataNode, $implClassName, $classIndex);
+ } else {
+ push(@implContentDecls, <<END);
+ v8::Handle<v8::Object> holder = info.Holder();
+END
+ HolderToNative($dataNode, $implClassName, $classIndex);
+ }
+
+ # Generate security checks if necessary
+ if ($attribute->signature->extendedAttributes->{"CheckNodeSecurity"}) {
+ push(@implContentDecls, " if (!V8Proxy::checkNodeSecurity(imp->$attrName())) return v8::Undefined();\n\n");
+ } elsif ($attribute->signature->extendedAttributes->{"CheckFrameSecurity"}) {
+ push(@implContentDecls, " if (!V8Proxy::checkNodeSecurity(imp->contentDocument())) return v8::Undefined();\n\n");
+ }
+
+ my $useExceptions = 1 if @{$attribute->getterExceptions} and !($isPodType);
+ if ($useExceptions) {
+ $implIncludes{"ExceptionCode.h"} = 1;
+ push(@implContentDecls, " ExceptionCode ec = 0;\n");
+ }
+
+ if ($attribute->signature->extendedAttributes->{"v8referenceattr"}) {
+ $attrName = $attribute->signature->extendedAttributes->{"v8referenceattr"};
+ }
+
+ my $getterFunc = WK_lcfirst($attrName);
+ $getterFunc .= "Animated" if $codeGenerator->IsSVGAnimatedType($attribute->signature->type);
+
+ my $returnType = $codeGenerator->StripModule($attribute->signature->type);
+
+ my $getterString;
+ if ($getterStringUsesImp) {
+ $getterString = "imp->$getterFunc(";
+ $getterString .= "ec" if $useExceptions;
+ $getterString .= ")";
+ if (IsRefPtrType($returnType)) {
+ $implIncludes{"wtf/GetPtr.h"} = 1;
+ $getterString = "WTF::getPtr(" . $getterString . ")";
+ }
+ if ($nativeType eq "int" and
+ $attribute->signature->extendedAttributes->{"ConvertFromString"}) {
+ $getterString .= ".toInt()";
+ }
+ } else {
+ $getterString = "imp_instance";
+ }
+ if ($nativeType eq "String") {
+ $getterString = "ToString($getterString)";
+ }
+
+ my $result;
+ my $wrapper;
+
+ if ($attrIsPodType) {
+ $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
+
+ my $getter = $getterString;
+ $getter =~ s/imp->//;
+ $getter =~ s/\(\)//;
+ my $setter = "set" . WK_ucfirst($getter);
+
+ my $implClassIsAnimatedType = $codeGenerator->IsSVGAnimatedType($implClassName);
+ if (not $implClassIsAnimatedType
+ and $codeGenerator->IsPodTypeWithWriteableProperties($attrType)
+ and not defined $attribute->signature->extendedAttributes->{"Immutable"}) {
+ if (IsPodType($implClassName)) {
+ $wrapper = "new V8SVGStaticPODTypeWrapperWithPODTypeParent<$nativeType, $implClassName>($getterString, imp_wrapper)";
+ } else {
+ $wrapper = "new V8SVGStaticPODTypeWrapperWithParent<$nativeType, $implClassName>(imp, &${implClassName}::$getter, &${implClassName}::$setter)";
+ }
+ } else {
+ if ($implClassIsAnimatedType) {
+ $wrapper = "V8SVGDynamicPODTypeWrapperCache<$nativeType, $implClassName>::lookupOrCreateWrapper(imp, &${implClassName}::$getter, &${implClassName}::$setter)";
+ } else {
+ $wrapper = GenerateSVGStaticPodTypeWrapper($returnType, $getterString);
+ }
+ }
+
+ push(@implContentDecls, " void* wrapper = $wrapper;\n");
+ } elsif ($nativeType ne "RGBColor") {
+ push(@implContentDecls, " $nativeType v = ");
+
+ push(@implContentDecls, "$getterString;\n");
+
+ if ($useExceptions) {
+ push(@implContentDecls, GenerateSetDOMException(" "));
+ }
+
+ $result = "v";
+ if (IsRefPtrType($returnType)) {
+ $result = "WTF::getPtr(" . $result . ")";
+ }
+ } else {
+ # Special case: RGBColor is noncopyable
+ $result = $getterString;
+ }
+
+
+ if (IsSVGTypeNeedingContextParameter($attrType) && !$skipContext) {
+ my $resultObject = $result;
+ if ($attrIsPodType) {
+ $resultObject = "wrapper";
+ }
+
+ push(@implContentDecls, GenerateSVGContextAssignment($implClassName, $resultObject, " "));
+ }
+
+ if ($attrIsPodType) {
+ my $classIndex = uc($attrType);
+ push(@implContentDecls, " return V8Proxy::convertToV8Object(V8ClassIndex::$classIndex, wrapper);\n");
+ } else {
+ push(@implContentDecls, " return ".NativeToJSValue($attribute->signature, $result).";\n");
+ }
+
+ push(@implContentDecls, " }\n\n"); # end of getter
+}
+
+
+sub GenerateReplaceableAttrSetter
+{
+ my $implClassName = shift;
+
+ $implIncludes{"V8Proxy.h"} = 1;
+
+ push(@implContentDecls,
+ " static void ${attrName}AttrSetter(v8::Local<v8::String> name," .
+ " v8::Local<v8::Value> value, const v8::AccessorInfo& info) {\n");
+
+ push(@implContentDecls, " INC_STATS(\"DOM.$implClassName.$attrName._set\");\n");
+
+ push(@implContentDecls, " v8::Local<v8::String> ${attrName}_string = v8::String::New(\"${attrName}\");\n");
+ push(@implContentDecls, " info.Holder()->Delete(${attrName}_string);\n");
+ push(@implContentDecls, " info.This()->Set(${attrName}_string, value);\n");
+ push(@implContentDecls, " }\n\n");
+}
+
+
+sub GenerateNormalAttrSetter
+{
+ my $attribute = shift;
+ my $dataNode = shift;
+ my $classIndex = shift;
+ my $implClassName = shift;
+
+ my $attrExt = $attribute->signature->extendedAttributes;
+
+ $implIncludes{"V8Proxy.h"} = 1;
+
+ push(@implContentDecls,
+ " static void ${attrName}AttrSetter(v8::Local<v8::String> name," .
+ " v8::Local<v8::Value> value, const v8::AccessorInfo& info) {\n");
+
+ push(@implContentDecls, " INC_STATS(\"DOM.$implClassName.$attrName._set\");\n");
+
+ my $isPodType = IsPodType($implClassName);
+
+ if ($isPodType) {
+ $implClassName = GetNativeType($implClassName);
+ $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
+ push(@implContentDecls, " V8SVGPODTypeWrapper<$implClassName>* wrapper = V8Proxy::convertToNativeObject<V8SVGPODTypeWrapper<$implClassName> >(V8ClassIndex::$classIndex, info.Holder());\n");
+ push(@implContentDecls, " $implClassName imp_instance = *wrapper;\n");
+ push(@implContentDecls, " $implClassName* imp = &imp_instance;\n");
+
+ } elsif ($attrExt->{"v8OnProto"}) {
+ # perform lookup first
+ push(@implContentDecls, <<END);
+ v8::Handle<v8::Object> holder = V8Proxy::lookupDOMWrapper(V8ClassIndex::$classIndex, info.This());
+ if (holder.IsEmpty()) return v8::Undefined();
+END
+ HolderToNative($dataNode, $implClassName, $classIndex);
+ } else {
+ push(@implContentDecls, <<END);
+ v8::Handle<v8::Object> holder = info.Holder();
+END
+ HolderToNative($dataNode, $implClassName, $classIndex);
+ }
+
+ my $nativeType = GetNativeTypeFromSignature($attribute->signature, 0);
+ push(@implContentDecls, " $nativeType v = " . JSValueToNative($attribute->signature, "value") . ";\n");
+
+ my $result = "";
+ if ($nativeType eq "int" and $attribute->signature->extendedAttributes->{"ConvertFromString"}) {
+ $result .= "WebCore::String::number(";
+ }
+ $result .= "v";
+ if ($nativeType eq "int" and $attribute->signature->extendedAttributes->{"ConvertFromString"}) {
+ $result .= ")";
+ }
+ my $returnType = $codeGenerator->StripModule($attribute->signature->type);
+ if (IsRefPtrType($returnType)) {
+ $result = "WTF::getPtr(" . $result . ")";
+ }
+
+ my $useExceptions = 1 if @{$attribute->setterExceptions} and !($isPodType);
+
+ if ($useExceptions) {
+ $implIncludes{"ExceptionCode.h"} = 1;
+ push(@implContentDecls, " ExceptionCode ec = 0;\n");
+ }
+
+ if ($implClassName eq "double") {
+ push(@implContentDecls, " *imp = $result;\n");
+ } else {
+ push(@implContentDecls, " imp->set" . WK_ucfirst($attrName) . "(" . $result);
+ push(@implContentDecls, ", ec") if $useExceptions;
+ push(@implContentDecls, ");\n");
+ }
+
+ if ($useExceptions) {
+ push(@implContentDecls, " V8Proxy::setDOMException(ec);\n");
+ }
+
+ if ($isPodType) {
+ push(@implContentDecls, " wrapper->commitChange(*imp, V8Proxy::svgContext(wrapper));\n");
+ } elsif (IsSVGTypeNeedingContextParameter($implClassName)) {
+ $implIncludes{"SVGElement.h"} = 1;
+
+ my $currentObject = "imp";
+ if ($isPodType) {
+ $currentObject = "wrapper";
+ }
+
+ push(@implContentDecls, " if (SVGElement* context = V8Proxy::svgContext($currentObject)) {\n");
+ push(@implContentDecls, " context->svgAttributeChanged(imp->associatedAttributeName());\n");
+ push(@implContentDecls, " }\n");
+ }
+
+ push(@implContentDecls, " return;\n");
+ push(@implContentDecls, " }\n\n"); # end of setter
+}
+
+sub GenerateNewFunctionTemplate
+{
+ $function = shift;
+ $dataNode = shift;
+ $signature = shift;
+
+ my $interfaceName = $dataNode->name;
+ my $name = $function->signature->name;
+
+ if ($function->signature->extendedAttributes->{"Custom"} ||
+ $function->signature->extendedAttributes->{"V8Custom"}) {
+ if ($function->signature->extendedAttributes->{"Custom"} &&
+ $function->signature->extendedAttributes->{"V8Custom"}) {
+ die "Custom and V8Custom should be mutually exclusive!"
+ }
+ my $customFunc = $function->signature->extendedAttributes->{"Custom"} ||
+ $function->signature->extendedAttributes->{"V8Custom"};
+ if ($customFunc eq 1) {
+ $customFunc = $interfaceName . WK_ucfirst($name);
+ }
+ return "v8::FunctionTemplate::New(V8Custom::v8${customFunc}Callback, v8::Handle<v8::Value>(), $signature)";
+ } else {
+ return "v8::FunctionTemplate::New(${interfaceName}Internal::${name}Callback, v8::Handle<v8::Value>(), $signature)";
+ }
+}
+
+sub GenerateFunctionCallback
+{
+ my $function = shift;
+ my $dataNode = shift;
+ my $classIndex = shift;
+ my $implClassName = shift;
+
+ my $interfaceName = $dataNode->name;
+ my $name = $function->signature->name;
+
+ push(@implContentDecls,
+" static v8::Handle<v8::Value> ${name}Callback(const v8::Arguments& args) {\n" .
+" INC_STATS(\"DOM.$implClassName.$name\");\n");
+
+ my $numParameters = @{$function->parameters};
+
+ if ($function->signature->extendedAttributes->{"RequiresAllArguments"}) {
+ push(@implContentDecls,
+ " if (args.Length() < $numParameters) return v8::Undefined();\n");
+ }
+
+ if (IsPodType($implClassName)) {
+ my $nativeClassName = GetNativeType($implClassName);
+ push(@implContentDecls, " V8SVGPODTypeWrapper<$nativeClassName>* imp_wrapper = V8Proxy::convertToNativeObject<V8SVGPODTypeWrapper<$nativeClassName> >(V8ClassIndex::$classIndex, args.Holder());\n");
+ push(@implContentDecls, " $nativeClassName imp_instance = *imp_wrapper;\n");
+ push(@implContentDecls, " $nativeClassName* imp = &imp_instance;\n");
+ } else {
+ push(@implContentDecls, <<END);
+ v8::Handle<v8::Value> holder = args.Holder();
+END
+ HolderToNative($dataNode, $implClassName, $classIndex);
+ }
+
+ # Check domain security if needed
+ if (($dataNode->extendedAttributes->{"CheckDomainSecurity"}
+ || $interfaceName eq "DOMWindow")
+ && !$function->signature->extendedAttributes->{"DoNotCheckDomainSecurity"}) {
+ # We have not find real use cases yet.
+ push(@implContentDecls,
+" if (!V8Proxy::canAccessFrame(imp->frame(), true)) {\n".
+" return v8::Undefined();\n" .
+" }\n");
+ }
+
+
+ if (@{$function->raisesExceptions}) {
+ $implIncludes{"ExceptionCode.h"} = 1;
+ push(@implContentDecls, " ExceptionCode ec = 0;\n");
+ }
+
+ if ($function->signature->extendedAttributes->{"CustomArgumentHandling"}) {
+ push(@implContentDecls, " ScriptCallStack callStack(args, $numParameters);\n");
+ $implIncludes{"ScriptCallStack.h"} = 1;
+ }
+
+ my $paramIndex = 0;
+ foreach my $parameter (@{$function->parameters}) {
+ TranslateParameter($parameter);
+
+ my $parameterName = $parameter->name;
+
+ if ($parameter->extendedAttributes->{"Optional"}) {
+ # Generate early call if there are not enough parameters.
+ push(@implContentDecls, " if (args.Length() <= $paramIndex) {\n");
+ my $functionCall = GenerateFunctionCallString($function, $paramIndex, " " x 2, $implClassName);
+ push(@implContentDecls, $functionCall);
+ push(@implContentDecls, " }\n");
+ }
+
+ if (BasicTypeCanFailConversion($parameter)) {
+ push(@implContentDecls, " bool ${parameterName}Ok;\n");
+ }
+
+ push(@implContentDecls, " " . GetNativeTypeFromSignature($parameter, 1) . " $parameterName = ");
+ push(@implContentDecls, JSValueToNative($parameter, "args[$paramIndex]",
+ BasicTypeCanFailConversion($parameter) ? "${parameterName}Ok" : undef) . ";\n");
+
+ if (TypeCanFailConversion($parameter)) {
+ $implIncludes{"ExceptionCode.h"} = 1;
+ push(@implContentDecls,
+" if (!$parameterName" . (BasicTypeCanFailConversion($parameter) ? "Ok" : "") . ") {\n" .
+" V8Proxy::setDOMException(TYPE_MISMATCH_ERR);\n" .
+" return v8::Handle<v8::Value>();\n" .
+" }\n");
+ }
+
+ if ($parameter->extendedAttributes->{"IsIndex"}) {
+ $implIncludes{"ExceptionCode.h"} = 1;
+ push(@implContentDecls,
+" if ($parameterName < 0) {\n" .
+" V8Proxy::setDOMException(INDEX_SIZE_ERR);\n" .
+" return v8::Handle<v8::Value>();\n" .
+" }\n");
+ }
+
+ $paramIndex++;
+ }
+
+ # Build the function call string.
+ my $callString = GenerateFunctionCallString($function, $paramIndex, " ", $implClassName);
+ push(@implContentDecls, "$callString");
+ push(@implContentDecls, " }\n\n");
+}
+
+sub GenerateBatchedAttributeData
+{
+ my $interfaceName = shift;
+ my $attributes = shift;
+
+ foreach my $attribute (@$attributes) {
+ my $attrName = $attribute->signature->name;
+ my $attrExt = $attribute->signature->extendedAttributes;
+
+ my $accessControl = "v8::DEFAULT";
+ if ($attrExt->{"DoNotCheckDomainSecurityOnGet"}) {
+ $accessControl = "v8::ALL_CAN_READ";
+ } elsif ($attrExt->{"DoNotCheckDomainSecurityOnSet"}) {
+ $accessControl = "v8::ALL_CAN_WRITE";
+ } elsif ($attrExt->{"DoNotCheckDomainSecurity"}) {
+ $accessControl = "v8::ALL_CAN_READ";
+ if (!($attribute->type =~ /^readonly/) && !($attrExt->{"V8ReadOnly"})) {
+ $accessControl .= "|v8::ALL_CAN_WRITE";
+ }
+ }
+ if ($attrExt->{"V8DisallowShadowing"}) {
+ $accessControl .= "|v8::PROHIBITS_OVERWRITING";
+ }
+ $accessControl = "static_cast<v8::AccessControl>(" . $accessControl . ")";
+
+ my $customAccessor =
+ $attrExt->{"Custom"} ||
+ $attrExt->{"CustomSetter"} ||
+ $attrExt->{"CustomGetter"} ||
+ $attrExt->{"V8Custom"} ||
+ $attrExt->{"V8CustomSetter"} ||
+ $attrExt->{"V8CustomGetter"} ||
+ "";
+ if ($customAccessor eq 1) {
+ # use the naming convension, interface + (capitalize) attr name
+ $customAccessor = $interfaceName . WK_ucfirst($attrName);
+ }
+
+ my $getter;
+ my $setter;
+ my $propAttr = "v8::None";
+ my $hasCustomSetter = 0;
+
+ # Check attributes.
+ if ($attrExt->{"DontEnum"}) {
+ $propAttr .= "|v8::DontEnum";
+ }
+ if ($attrExt->{"V8DisallowShadowing"}) {
+ $propAttr .= "|v8::DontDelete";
+ }
+
+ my $on_proto = "0 /* on instance */";
+ my $data = "V8ClassIndex::INVALID_CLASS_INDEX /* no data */";
+
+ # Constructor
+ if ($attribute->signature->type =~ /Constructor$/) {
+ my $constructorType = $codeGenerator->StripModule($attribute->signature->type);
+ $constructorType =~ s/Constructor$//;
+ my $constructorIndex = uc($constructorType);
+ $data = "V8ClassIndex::${constructorIndex}";
+ $getter = "${interfaceName}Internal::${interfaceName}ConstructorGetter";
+ $setter = "0";
+ $propAttr = "v8::ReadOnly";
+
+ # EventListeners
+ } elsif ($attribute->signature->type eq "EventListener") {
+ if ($interfaceName eq "DOMWindow") {
+ $getter = "V8Custom::v8DOMWindowEventHandlerAccessorGetter";
+ $setter = "V8Custom::v8DOMWindowEventHandlerAccessorSetter";
+ } elsif ($interfaceName eq "Element" || $interfaceName eq "Document" || $interfaceName eq "HTMLBodyElement" || $interfaceName eq "SVGElementInstance" || $interfaceName eq "HTMLFrameSetElement") {
+ $getter = "V8Custom::v8ElementEventHandlerAccessorGetter";
+ $setter = "V8Custom::v8ElementEventHandlerAccessorSetter";
+ } else {
+ $getter = "V8Custom::v8${customAccessor}AccessorGetter";
+ if ($interfaceName eq "WorkerContext" and $attrName eq "self") {
+ $setter = "0";
+ $propAttr = "v8::ReadOnly";
+ } else {
+ $setter = "V8Custom::v8${customAccessor}AccessorSetter";
+ }
+ }
+
+ # Custom Getter and Setter
+ } elsif ($attrExt->{"Custom"} || $attrExt->{"V8Custom"}) {
+ $getter = "V8Custom::v8${customAccessor}AccessorGetter";
+ if ($interfaceName eq "WorkerContext" and $attrName eq "self") {
+ $setter = "0";
+ $propAttr = "v8::ReadOnly";
+ } else {
+ $hasCustomSetter = 1;
+ $setter = "V8Custom::v8${customAccessor}AccessorSetter";
+ }
+
+ # Custom Setter
+ } elsif ($attrExt->{"CustomSetter"} || $attrExt->{"V8CustomSetter"}) {
+ $hasCustomSetter = 1;
+ $getter = "${interfaceName}Internal::${attrName}AttrGetter";
+ $setter = "V8Custom::v8${customAccessor}AccessorSetter";
+
+ # Custom Getter
+ } elsif ($attrExt->{"CustomGetter"}) {
+ $getter = "V8Custom::v8${customAccessor}AccessorGetter";
+ $setter = "${interfaceName}Internal::${attrName}AttrSetter";
+
+ # Replaceable
+ } elsif ($attrExt->{"Replaceable"}) {
+ # Replaceable accessor is put on instance template with ReadOnly attribute.
+ $getter = "${interfaceName}Internal::${attrName}AttrGetter";
+ $setter = "0";
+
+ # Mark to avoid duplicate v8::ReadOnly flags in output.
+ $hasCustomSetter = 1;
+
+ # Handle the special case of window.top being marked upstream as Replaceable.
+ # FIXME: Investigate why [Replaceable] is not marked as ReadOnly
+ # upstream and reach parity.
+ if (!($interfaceName eq "DOMWindow" and $attrName eq "top")) {
+ $propAttr .= "|v8::ReadOnly";
+ }
+
+ # Normal
+ } else {
+ $getter = "${interfaceName}Internal::${attrName}AttrGetter";
+ $setter = "${interfaceName}Internal::${attrName}AttrSetter";
+ }
+
+ if ($attrExt->{"Replaceable"} && !$hasCustomSetter) {
+ $setter = "0";
+ $propAttr .= "|v8::ReadOnly";
+ }
+
+ # Read only attributes
+ if ($attribute->type =~ /^readonly/ || $attrExt->{"V8ReadOnly"}) {
+ $setter = "0";
+ }
+
+ # An accessor can be installed on the proto
+ if ($attrExt->{"v8OnProto"}) {
+ $on_proto = "1 /* on proto */";
+ }
+
+ my $commentInfo = "Attribute '$attrName' (Type: '" . $attribute->type .
+ "' ExtAttr: '" . join(' ', keys(%{$attrExt})) . "')";
+ push(@implContent, <<END);
+ // $commentInfo
+ { "$attrName",
+ $getter,
+ $setter,
+ $data,
+ $accessControl,
+ static_cast<v8::PropertyAttribute>($propAttr),
+ $on_proto },
+END
+ }
+}
+
+
+sub GenerateImplementation
+{
+ my $object = shift;
+ my $dataNode = shift;
+ my $interfaceName = $dataNode->name;
+ my $className = "V8$interfaceName";
+ my $implClassName = $interfaceName;
+ my $classIndex = uc($codeGenerator->StripModule($interfaceName));
+
+ my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+ my $conditional = $dataNode->extendedAttributes->{"Conditional"};
+
+ @allParents = $codeGenerator->FindParentsRecursively($dataNode);
+
+ # - Add default header template
+ @implContentHeader = split("\r", $headerTemplate);
+
+ push(@implFixedHeader,
+ "#include \"config.h\"\n" .
+ "#include \"V8Proxy.h\"\n" .
+ "#include \"v8_binding.h\"\n\n" .
+ "#undef LOG\n\n");
+
+ my $conditionalString;
+ if ($conditional) {
+ $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
+ push(@implFixedHeader, "\n#if ${conditionalString}\n\n");
+ }
+
+ if ($className =~ /^V8SVGAnimated/) {
+ AddIncludesForSVGAnimatedType($interfaceName);
+ }
+
+ $implIncludes{"${className}.h"} = 1;
+
+ AddIncludesForType($interfaceName);
+ $implIncludes{"V8Proxy.h"} = 1;
+
+ push(@implContentDecls, "namespace WebCore {\n");
+ push(@implContentDecls, "namespace ${interfaceName}Internal {\n\n");
+ push(@implContentDecls, "template <typename T> void V8_USE(T) { }\n\n");
+
+ my $hasConstructors = 0;
+
+ # Generate property accessors for attributes.
+ for ($index = 0; $index < @{$dataNode->attributes}; $index++) {
+ $attribute = @{$dataNode->attributes}[$index];
+ $attrName = $attribute->signature->name;
+ $attrType = $attribute->signature->type;
+
+ # Generate special code for the constructor attributes.
+ if ($attrType =~ /Constructor$/) {
+ $hasConstructors = 1;
+ next;
+ }
+
+ # Make EventListeners always custom.
+ # FIXME: make the perl code capable of generating the
+ # event setters/getters. For now, WebKit has started removing the
+ # [Custom] attribute, so just automatically insert it to avoid forking
+ # other files. This should be okay because we can't generate stubs
+ # for any event getter/setters anyway.
+ if ($attrType eq "EventListener") {
+ $attribute->signature->extendedAttributes->{"Custom"} = 1;
+ $implIncludes{"V8CustomBinding.h"} = 1;
+ next;
+ }
+
+ # Do not generate accessor if this is a custom attribute. The
+ # call will be forwarded to a hand-written accessor
+ # implementation.
+ if ($attribute->signature->extendedAttributes->{"Custom"} ||
+ $attribute->signature->extendedAttributes->{"V8Custom"}) {
+ $implIncludes{"V8CustomBinding.h"} = 1;
+ next;
+ }
+
+ # Generate the accessor.
+ if ($attribute->signature->extendedAttributes->{"CustomGetter"}) {
+ $implIncludes{"V8CustomBinding.h"} = 1;
+ } else {
+ GenerateNormalAttrGetter($attribute, $dataNode, $classIndex, $implClassName);
+ }
+ if ($attribute->signature->extendedAttributes->{"CustomSetter"} ||
+ $attribute->signature->extendedAttributes->{"V8CustomSetter"}) {
+ $implIncludes{"V8CustomBinding.h"} = 1;
+ } elsif ($attribute->signature->extendedAttributes->{"Replaceable"}) {
+ $dataNode->extendedAttributes->{"ExtendsDOMGlobalObject"} || die "Replaceable attribute can only be used in interface that defines ExtendsDOMGlobalObject attribute!";
+ # GenerateReplaceableAttrSetter($implClassName);
+ } elsif ($attribute->type !~ /^readonly/ && !$attribute->signature->extendedAttributes->{"V8ReadOnly"}) {
+ GenerateNormalAttrSetter($attribute, $dataNode, $classIndex, $implClassName);
+ }
+ }
+
+ if ($hasConstructors) {
+ GenerateConstructorGetter($implClassName, $classIndex);
+ }
+
+ # Generate methods for functions.
+ foreach my $function (@{$dataNode->functions}) {
+ # hack for addEventListener/RemoveEventListener
+ # FIXME: avoid naming conflict
+ if ($function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"V8Custom"}) {
+ $implIncludes{"V8CustomBinding.h"} = 1;
+ } else {
+ GenerateFunctionCallback($function, $dataNode, $classIndex, $implClassName);
+ }
+
+ # If the function does not need domain security check, we need to
+ # generate an access getter that returns different function objects
+ # for different calling context.
+ if (($dataNode->extendedAttributes->{"CheckDomainSecurity"} || ($interfaceName eq "DOMWindow")) && $function->signature->extendedAttributes->{"DoNotCheckDomainSecurity"}) {
+ GenerateDomainSafeFunctionGetter($function, $dataNode, $classIndex, $implClassName);
+ }
+ }
+
+ # Attributes
+ my $attributes = $dataNode->attributes;
+
+ # For the DOMWindow interface we partition the attributes into the
+ # ones that disallows shadowing and the rest.
+ my @disallows_shadowing;
+ my @normal;
+ if ($interfaceName eq "DOMWindow") {
+ foreach my $attribute (@$attributes) {
+ if ($attribute->signature->extendedAttributes->{"V8DisallowShadowing"}) {
+ push(@disallows_shadowing, $attribute);
+ } else {
+ push(@normal, $attribute);
+ }
+ }
+ # Put the attributes that disallow shadowing on the shadow object.
+ $attributes = \@normal;
+ push(@implContent, "static const BatchedAttribute shadow_attrs[] = {\n");
+ GenerateBatchedAttributeData($interfaceName, \@disallows_shadowing);
+ push(@implContent, "};\n");
+ }
+
+ my $has_attributes = 0;
+ if (@$attributes) {
+ $has_attributes = 1;
+ push(@implContent, "static const BatchedAttribute attrs[] = {\n");
+ GenerateBatchedAttributeData($interfaceName, $attributes);
+ push(@implContent, "};\n");
+ }
+
+ # Setup constants
+ my $has_constants = 0;
+ if (@{$dataNode->constants}) {
+ $has_constants = 1;
+ push(@implContent, "static const BatchedConstant consts[] = {\n");
+ }
+ foreach my $constant (@{$dataNode->constants}) {
+ my $name = $constant->name;
+ my $value = $constant->value;
+ # FIXME: we need the static_cast here only because of one constant, NodeFilter.idl
+ # defines "const unsigned long SHOW_ALL = 0xFFFFFFFF". It would be better if we
+ # handled this here, and converted it to a -1 constant in the c++ output.
+ push(@implContent, <<END);
+ { "${name}", static_cast<signed int>($value) },
+END
+ }
+ if ($has_constants) {
+ push(@implContent, "};\n");
+ }
+
+ push(@implContentDecls, "} // namespace ${interfaceName}Internal\n\n");
+
+ my $access_check = "/* no access check */";
+ if ($dataNode->extendedAttributes->{"CheckDomainSecurity"} && !($interfaceName eq "DOMWindow")) {
+ $access_check = "instance->SetAccessCheckCallbacks(V8Custom::v8${interfaceName}NamedSecurityCheck, V8Custom::v8${interfaceName}IndexedSecurityCheck, v8::Integer::New(V8ClassIndex::ToInt(V8ClassIndex::${classIndex})));";
+ }
+
+ # For the DOMWindow interface, generate the shadow object template
+ # configuration method.
+ if ($implClassName eq "DOMWindow") {
+ push(@implContent, <<END);
+static v8::Persistent<v8::ObjectTemplate> ConfigureShadowObjectTemplate(v8::Persistent<v8::ObjectTemplate> templ) {
+ batchConfigureAttributes(templ,
+ v8::Handle<v8::ObjectTemplate>(),
+ shadow_attrs,
+ sizeof(shadow_attrs)/sizeof(*shadow_attrs));
+ return templ;
+}
+END
+ }
+
+ # Generate the template configuration method
+ push(@implContent, <<END);
+static v8::Persistent<v8::FunctionTemplate> Configure${className}Template(v8::Persistent<v8::FunctionTemplate> desc) {
+ v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
+ instance->SetInternalFieldCount(2);
+ v8::Local<v8::Signature> default_signature = v8::Signature::New(desc);
+ v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();
+ $access_check
+END
+
+
+ # Set up our attributes if we have them
+ if ($has_attributes) {
+ push(@implContent, <<END);
+ batchConfigureAttributes(instance, proto, attrs, sizeof(attrs)/sizeof(*attrs));
+END
+ }
+
+ # Define our functions with Set() or SetAccessor()
+ foreach my $function (@{$dataNode->functions}) {
+ my $attrExt = $function->signature->extendedAttributes;
+ my $name = $function->signature->name;
+
+ my $property_attributes = "v8::DontDelete";
+ if ($attrExt->{"DontEnum"}) {
+ $property_attributes .= "|v8::DontEnum";
+ }
+ if ($attrExt->{"V8ReadOnly"}) {
+ $property_attributes .= "|v8::ReadOnly";
+ }
+
+ my $commentInfo = "Function '$name' (ExtAttr: '" . join(' ', keys(%{$attrExt})) . "')";
+
+ my $template = "proto";
+ if ($attrExt->{"V8OnInstance"}) {
+ $template = "instance";
+ }
+
+ if ($attrExt->{"DoNotCheckDomainSecurity"} &&
+ ($dataNode->extendedAttributes->{"CheckDomainSecurity"} || $interfaceName eq "DOMWindow")) {
+ # Mark the accessor as ReadOnly and set it on the proto object so
+ # it can be shadowed. This is really a hack to make it work.
+ # There are several sceneria to call into the accessor:
+ # 1) from the same domain: "window.open":
+ # the accessor finds the DOM wrapper in the proto chain;
+ # 2) from the same domain: "window.__proto__.open":
+ # the accessor will NOT find a DOM wrapper in the prototype chain
+ # 3) from another domain: "window.open":
+ # the access find the DOM wrapper in the prototype chain
+ # "window.__proto__.open" from another domain will fail when
+ # accessing '__proto__'
+ #
+ # The solution is very hacky and fragile, it really needs to be replaced
+ # by a better solution.
+ $property_attributes .= "|v8::ReadOnly";
+ push(@implContent, <<END);
+
+ // $commentInfo
+ $template->SetAccessor(
+ v8::String::New("$name"),
+ ${interfaceName}Internal::${name}AttrGetter,
+ 0,
+ v8::Handle<v8::Value>(),
+ v8::ALL_CAN_READ,
+ static_cast<v8::PropertyAttribute>($property_attributes));
+END
+ next;
+ }
+
+ my $signature = "default_signature";
+ if ($attrExt->{"V8DoNotCheckSignature"}){
+ $signature = "v8::Local<v8::Signature>()";
+ }
+
+ if (RequiresCustomSignature($function)) {
+ $signature = "${name}_signature";
+ push(@implContent, "\n // Custom Signature '$name'\n", CreateCustomSignature($function));
+ }
+
+ # Normal function call is a template
+ my $templateFunction = GenerateNewFunctionTemplate($function, $dataNode, $signature);
+
+
+ push(@implContent, <<END);
+
+ // $commentInfo
+ ${template}->Set(
+ v8::String::New("$name"),
+ $templateFunction,
+ static_cast<v8::PropertyAttribute>($property_attributes));
+END
+ }
+
+ # set the super descriptor
+ foreach (@{$dataNode->parents}) {
+ my $parent = $codeGenerator->StripModule($_);
+ if ($parent eq "EventTarget") { next; }
+ $implIncludes{"V8${parent}.h"} = 1;
+ my $parentClassIndex = uc($codeGenerator->StripModule($parent));
+ push(@implContent, " desc->Inherit(V8Proxy::getTemplate(V8ClassIndex::${parentClassIndex}));\n");
+ last;
+ }
+
+ # Set the class name. This is used when printing objects.
+ push(@implContent, " desc->SetClassName(v8::String::New(\"" . GetClassName(${interfaceName}) . "\"));\n");
+
+ if ($has_constants) {
+ push(@implContent, <<END);
+ batchConfigureConstants(desc, proto, consts, sizeof(consts)/sizeof(*consts));
+END
+ }
+
+ push(@implContent, <<END);
+ return desc;
+}
+
+v8::Persistent<v8::FunctionTemplate> ${className}::GetRawTemplate() {
+ static v8::Persistent<v8::FunctionTemplate> ${className}_raw_cache_;
+ if (${className}_raw_cache_.IsEmpty()) {
+ v8::HandleScope scope;
+ v8::Local<v8::FunctionTemplate> result = v8::FunctionTemplate::New(V8Proxy::checkNewLegal);
+ ${className}_raw_cache_ = v8::Persistent<v8::FunctionTemplate>::New(result);
+ }
+ return ${className}_raw_cache_;
+}
+
+v8::Persistent<v8::FunctionTemplate> ${className}::GetTemplate() {
+ static v8::Persistent<v8::FunctionTemplate> ${className}_cache_;
+ if (${className}_cache_.IsEmpty())
+ ${className}_cache_ = Configure${className}Template(GetRawTemplate());
+ return ${className}_cache_;
+}
+
+bool ${className}::HasInstance(v8::Handle<v8::Value> value) {
+ return GetRawTemplate()->HasInstance(value);
+}
+
+END
+
+ if ($implClassName eq "DOMWindow") {
+ push(@implContent, <<END);
+v8::Persistent<v8::ObjectTemplate> V8DOMWindow::GetShadowObjectTemplate() {
+ static v8::Persistent<v8::ObjectTemplate> V8DOMWindowShadowObject_cache_;
+ if (V8DOMWindowShadowObject_cache_.IsEmpty()) {
+ V8DOMWindowShadowObject_cache_ = v8::Persistent<v8::ObjectTemplate>::New(v8::ObjectTemplate::New());
+ ConfigureShadowObjectTemplate(V8DOMWindowShadowObject_cache_);
+ }
+ return V8DOMWindowShadowObject_cache_;
+}
+END
+ }
+
+ push(@implContent, <<END);
+} // namespace WebCore
+END
+
+ push(@implContent, "\n#endif // ${conditionalString}\n") if $conditional;
+}
+
+
+sub GenerateFunctionCallString()
+{
+ my $function = shift;
+ my $numberOfParameters = shift;
+ my $indent = shift;
+ my $implClassName = shift;
+
+ my $name = $function->signature->name;
+ my $isPodType = IsPodType($implClassName);
+ my $returnType = $codeGenerator->StripModule($function->signature->type);
+ my $returnsPodType = IsPodType($returnType);
+ my $nativeReturnType = GetNativeType($returnType, 0);
+ my $result = "";
+
+ # Special case: SVG matrix transform methods should not mutate
+ # the matrix but return a copy
+ my $copyFirst = 0;
+ if ($implClassName eq "SVGMatrix" && $function->signature->type eq "SVGMatrix") {
+ $copyFirst = 1;
+ }
+
+ if ($function->signature->extendedAttributes->{"v8implname"}) {
+ $name = $function->signature->extendedAttributes->{"v8implname"};
+ }
+
+ if ($function->signature->extendedAttributes->{"ImplementationFunction"}) {
+ $name = $function->signature->extendedAttributes->{"ImplementationFunction"};
+ }
+
+ my $functionString = "imp->${name}(";
+
+ if ($copyFirst) {
+ $functionString = "result.${name}(";
+ }
+
+ my $returnsListItemPodType = 0;
+ # SVG lists functions that return POD types require special handling
+ if (IsSVGListTypeNeedingSpecialHandling($implClassName) && IsSVGListMethod($name) && $returnsPodType) {
+ $returnsListItemPodType = 1;
+ $result .= $indent . "SVGList<RefPtr<SVGPODListItem<$nativeReturnType> > >* listImp = imp;\n";
+ $functionString = "listImp->${name}(";
+ }
+
+ my $first = 1;
+ my $index = 0;
+ my $nodeToReturn = 0;
+
+ foreach my $parameter (@{$function->parameters}) {
+ if ($index eq $numberOfParameters) {
+ last;
+ }
+ if ($first) { $first = 0; }
+ else { $functionString .= ", "; }
+ my $paramName = $parameter->name;
+ my $paramType = $parameter->type;
+
+ # This is a bit of a hack... we need to convert parameters to methods on SVG lists
+ # of POD types which are items in the list to appropriate SVGList<> instances
+ if ($returnsListItemPodType && $paramType . "List" eq $implClassName) {
+ $paramName = "SVGPODListItem<" . GetNativeType($paramType, 1) . ">::copy($paramName)";
+ }
+
+ if ($parameter->type eq "NodeFilter") {
+ $functionString .= "$paramName.get()";
+ } else {
+ $functionString .= $paramName;
+ }
+
+ if ($parameter->extendedAttributes->{"Return"}) {
+ $nodeToReturn = $parameter->name;
+ }
+ $index++;
+ }
+
+ if ($function->signature->extendedAttributes->{"CustomArgumentHandling"}) {
+ $functionString .= ", " if not $first;
+ $functionString .= "&callStack";
+ if ($first) { $first = 0; }
+ }
+
+ if (@{$function->raisesExceptions}) {
+ $functionString .= ", " if not $first;
+ $functionString .= "ec";
+ }
+ $functionString .= ")";
+
+ if ((IsRefPtrType($returnType) || $returnsListItemPodType) && !$nodeToReturn) {
+ # We don't use getPtr when $nodeToReturn because that situation is
+ # special-cased below to return a bool.
+ $implIncludes{"wtf/GetPtr.h"} = 1;
+ $functionString = "WTF::getPtr(" . $functionString . ")";
+ }
+
+ if ($nodeToReturn) {
+ # Special case for insertBefore, replaceChild, removeChild and
+ # appendChild functions from Node.
+ $result .= $indent . "bool success = $functionString;\n";
+ if (@{$function->raisesExceptions}) {
+ $result .= GenerateSetDOMException($indent);
+ }
+ $result .= $indent . "if (success)\n";
+ $result .= $indent . " " .
+ "return V8Proxy::convertNodeToV8Object($nodeToReturn);\n";
+ $result .= $indent . "return v8::Null();\n";
+ return $result;
+ } elsif ($returnType eq "void") {
+ $result .= $indent . "$functionString;\n";
+ } elsif ($copyFirst) {
+ $result .=
+ $indent . GetNativeType($returnType, 0) . " result = *imp;\n" .
+ $indent . "$functionString;\n";
+ } elsif ($returnsListItemPodType) {
+ $result .= $indent . "RefPtr<SVGPODListItem<$nativeReturnType> > result = $functionString;\n";
+ } else {
+ $result .= $indent . $nativeReturnType . " result = $functionString;\n";
+ }
+
+ if (@{$function->raisesExceptions}) {
+ $result .= GenerateSetDOMException($indent);
+ }
+
+ my $return = "result";
+ if (IsRefPtrType($returnType) || $returnsListItemPodType) {
+ $implIncludes{"wtf/GetPtr.h"} = 1;
+ $return = "WTF::getPtr(" . $return . ")";
+ }
+
+ # If the return type is a POD type, separate out the wrapper generation
+ if ($returnsListItemPodType) {
+ $result .= $indent . "V8SVGPODTypeWrapper<" . $nativeReturnType . ">* wrapper = new ";
+ $result .= "V8SVGPODTypeWrapperCreatorForList<" . $nativeReturnType . ">($return, imp->associatedAttributeName());\n";
+ $return = "wrapper";
+ } elsif ($returnsPodType) {
+ $result .= $indent . "V8SVGPODTypeWrapper<" . $nativeReturnType . ">* wrapper = ";
+ $result .= GenerateSVGStaticPodTypeWrapper($returnType, $return) . ";\n";
+ $return = "wrapper";
+ }
+
+ my $generatedSVGContextRetrieval = 0;
+ # If the return type needs an SVG context, output it
+ if (IsSVGTypeNeedingContextParameter($returnType)) {
+ $result .= GenerateSVGContextAssignment($implClassName, $return, $indent);
+ $generatedSVGContextRetrieval = 1;
+ }
+
+ if (IsSVGTypeNeedingContextParameter($implClassName) && $implClassName =~ /List$/ && IsSVGListMutator($name)) {
+ if (!$generatedSVGContextRetrieval) {
+ $result .= GenerateSVGContextRetrieval($implClassName, $indent);
+ $generatedSVGContextRetrieval = 1;
+ }
+
+ $result .= $indent . "context->svgAttributeChanged(imp->associatedAttributeName());\n";
+ $implIncludes{"SVGElement.h"} = 1;
+ }
+
+ # If the implementing class is a POD type, commit changes
+ if ($isPodType) {
+ if (!$generatedSVGContextRetrieval) {
+ $result .= GenerateSVGContextRetrieval($implClassName, $indent);
+ $generatedSVGContextRetrieval = 1;
+ }
+
+ $result .= $indent . "imp_wrapper->commitChange(imp_instance, context);\n";
+ }
+
+ if ($returnsPodType) {
+ my $classIndex = uc($returnType);
+ $result .= $indent . "return V8Proxy::convertToV8Object(V8ClassIndex::$classIndex, wrapper);\n";
+ } else {
+ $result .= $indent . "return " . NativeToJSValue($function->signature, $return) . ";\n";
+ }
+
+ return $result;
+}
+
+
+# Get the class name used for printing javascript DOM-object wrappers.
+sub GetClassName
+{
+ my $type = shift;
+ return "HTMLCollection" if $type eq "UndetectableHTMLCollection";
+ return $type;
+}
+
+
+sub GetNativeTypeFromSignature
+{
+ my $signature = shift;
+ my $isParameter = shift;
+
+ my $type = $codeGenerator->StripModule($signature->type);
+
+ return GetNativeType($type, $isParameter);
+}
+
+sub IsRefPtrType
+{
+ my $type = shift;
+ return 1 if $type eq "Attr";
+ return 1 if $type eq "CanvasGradient";
+ return 1 if $type eq "ClientRect";
+ return 1 if $type eq "ClientRectList";
+ return 1 if $type eq "CDATASection";
+ return 1 if $type eq "Comment";
+ return 1 if $type eq "CSSRule";
+ return 1 if $type eq "CSSStyleRule";
+ return 1 if $type eq "CSSCharsetRule";
+ return 1 if $type eq "CSSImportRule";
+ return 1 if $type eq "CSSMediaRule";
+ return 1 if $type eq "CSSFontFaceRule";
+ return 1 if $type eq "CSSPageRule";
+ return 1 if $type eq "CSSPrimitiveValue";
+ return 1 if $type eq "CSSStyleSheet";
+ return 1 if $type eq "CSSStyleDeclaration";
+ return 1 if $type eq "CSSValue";
+ return 1 if $type eq "CSSRuleList";
+ return 1 if $type eq "Database";
+ return 1 if $type eq "Document";
+ return 1 if $type eq "DocumentFragment";
+ return 1 if $type eq "DocumentType";
+ return 1 if $type eq "Element";
+ return 1 if $type eq "EntityReference";
+ return 1 if $type eq "Event";
+ return 1 if $type eq "FileList";
+ return 1 if $type eq "HTMLCollection";
+ return 1 if $type eq "HTMLDocument";
+ return 1 if $type eq "HTMLElement";
+ return 1 if $type eq "HTMLOptionsCollection";
+ return 1 if $type eq "ImageData";
+ return 1 if $type eq "MediaError";
+ return 1 if $type eq "MimeType";
+ return 1 if $type eq "Node";
+ return 1 if $type eq "NodeList";
+ return 1 if $type eq "NodeFilter";
+ return 1 if $type eq "NodeIterator";
+ return 1 if $type eq "NSResolver";
+ return 1 if $type eq "Plugin";
+ return 1 if $type eq "ProcessingInstruction";
+ return 1 if $type eq "Range";
+ return 1 if $type eq "Text";
+ return 1 if $type eq "TextMetrics";
+ return 1 if $type eq "TimeRanges";
+ return 1 if $type eq "TreeWalker";
+ return 1 if $type eq "WebKitCSSMatrix";
+ return 1 if $type eq "WebKitPoint";
+ return 1 if $type eq "XPathExpression";
+ return 1 if $type eq "XPathNSResolver";
+ return 1 if $type eq "XPathResult";
+
+ return 1 if $type eq "SVGAngle";
+ return 1 if $type eq "SVGElementInstance";
+ return 1 if $type eq "SVGElementInstanceList";
+ return 1 if $type =~ /^SVGPathSeg/;
+
+ return 1 if $type =~ /^SVGAnimated/;
+
+ return 0;
+}
+
+sub IsVideoClassName
+{
+ my $class = shift;
+ return 1 if $class eq "V8HTMLAudioElement";
+ return 1 if $class eq "V8HTMLMediaElement";
+ return 1 if $class eq "V8HTMLSourceElement";
+ return 1 if $class eq "V8HTMLVideoElement";
+ return 1 if $class eq "V8MediaError";
+ return 1 if $class eq "V8TimeRanges";
+
+ return 0;
+}
+
+sub IsWorkerClassName
+{
+ my $class = shift;
+ return 1 if $class eq "V8Worker";
+ return 1 if $class eq "V8WorkerContext";
+ return 1 if $class eq "V8WorkerLocation";
+ return 1 if $class eq "V8WorkerNavigator";
+
+ return 0;
+}
+
+sub GetNativeType
+{
+ my $type = shift;
+ my $isParameter = shift;
+
+ if ($type eq "float" or $type eq "AtomicString" or $type eq "double") {
+ return $type;
+ }
+
+ return "int" if $type eq "int";
+ return "int" if $type eq "short" or $type eq "unsigned short";
+ return "int" if $type eq "long" or $type eq "unsigned long";
+ return "unsigned long long" if $type eq "unsigned long long";
+ return "bool" if $type eq "boolean";
+ return "String" if $type eq "DOMString";
+ return "Range::CompareHow" if $type eq "CompareHow";
+ return "FloatRect" if $type eq "SVGRect";
+ return "FloatPoint" if $type eq "SVGPoint";
+ return "TransformationMatrix" if $type eq "SVGMatrix";
+ return "SVGTransform" if $type eq "SVGTransform";
+ return "SVGLength" if $type eq "SVGLength";
+ return "double" if $type eq "SVGNumber";
+ return "SVGPaint::SVGPaintType" if $type eq "SVGPaintType";
+ return "DOMTimeStamp" if $type eq "DOMTimeStamp";
+ return "unsigned" if $type eq "unsigned int";
+ return "unsigned" if $type eq "RGBColor";
+ return "Node*" if $type eq "EventTarget" and $isParameter;
+
+ return "String" if $type eq "DOMUserData"; # FIXME: Temporary hack?
+
+ # temporary hack
+ return "RefPtr<NodeFilter>" if $type eq "NodeFilter";
+
+ return "RefPtr<${type}>" if IsRefPtrType($type) and not $isParameter;
+
+ # Default, assume native type is a pointer with same type name as idl type
+ return "${type}*";
+}
+
+
+my %typeCanFailConversion = (
+ "AtomicString" => 0,
+ "Attr" => 1,
+ "CompareHow" => 0,
+ "DataGridColumn" => 0,
+ "DOMString" => 0,
+ "DOMWindow" => 0,
+ "DocumentType" => 0,
+ "Element" => 0,
+ "Event" => 0,
+ "EventListener" => 0,
+ "EventTarget" => 0,
+ "HTMLElement" => 0,
+ "HTMLOptionElement" => 0,
+ "Node" => 0,
+ "NodeFilter" => 0,
+ "MessagePort" => 0,
+ "NSResolver" => 0,
+ "Range" => 0,
+ "SQLResultSet" => 0,
+ "Storage" => 0,
+ "SVGAngle" => 0,
+ "SVGElement" => 0,
+ "SVGLength" => 1,
+ "SVGMatrix" => 1,
+ "SVGNumber" => 0,
+ "SVGPaintType" => 0,
+ "SVGPathSeg" => 0,
+ "SVGPoint" => 1,
+ "SVGRect" => 1,
+ "SVGTransform" => 1,
+ "VoidCallback" => 1,
+ "WebKitCSSMatrix" => 0,
+ "WebKitPoint" => 0,
+ "XPathEvaluator" => 0,
+ "XPathNSResolver" => 0,
+ "XPathResult" => 0,
+ "boolean" => 0,
+ "double" => 0,
+ "float" => 0,
+ "long" => 0,
+ "unsigned long" => 0,
+ "unsigned short" => 0,
+);
+
+
+sub TranslateParameter
+{
+ my $signature = shift;
+
+ # The IDL uses some pseudo-types which don't really exist.
+ if ($signature->type eq "TimeoutHandler") {
+ $signature->type("DOMString");
+ }
+}
+
+sub BasicTypeCanFailConversion
+{
+ my $signature = shift;
+ my $type = $codeGenerator->StripModule($signature->type);
+
+ return 1 if $type eq "SVGLength";
+ return 1 if $type eq "SVGMatrix";
+ return 1 if $type eq "SVGPoint";
+ return 1 if $type eq "SVGRect";
+ return 1 if $type eq "SVGTransform";
+ return 0;
+}
+
+sub TypeCanFailConversion
+{
+ my $signature = shift;
+
+ my $type = $codeGenerator->StripModule($signature->type);
+
+ $implIncludes{"ExceptionCode.h"} = 1 if $type eq "Attr";
+
+ return $typeCanFailConversion{$type} if exists $typeCanFailConversion{$type};
+
+ die "Don't know whether a JS value can fail conversion to type $type.";
+}
+
+sub JSValueToNative
+{
+ my $signature = shift;
+ my $value = shift;
+ my $okParam = shift;
+ my $maybeOkParam = $okParam ? ", ${okParam}" : "";
+
+ my $type = $codeGenerator->StripModule($signature->type);
+
+ return "$value" if $type eq "JSObject";
+ return "$value->BooleanValue()" if $type eq "boolean";
+ return "static_cast<$type>($value->NumberValue())" if $type eq "float" or $type eq "double";
+ return "$value->NumberValue()" if $type eq "SVGNumber";
+
+ return "ToInt32($value${maybeOkParam})" if $type eq "unsigned long" or $type eq "unsigned short" or $type eq "long";
+ return "static_cast<Range::CompareHow>($value->Int32Value())" if $type eq "CompareHow";
+ return "static_cast<SVGPaint::SVGPaintType>($value->ToInt32()->Int32Value())" if $type eq "SVGPaintType";
+
+ return "ToWebCoreString($value)" if $type eq "AtomicString" or $type eq "DOMUserData";
+ if ($type eq "DOMString") {
+ return "valueToStringWithNullCheck($value)" if $signature->extendedAttributes->{"ConvertNullToNullString"};
+ return "valueToStringWithNullOrUndefinedCheck($value)" if $signature->extendedAttributes->{"ConvertUndefinedOrNullToNullString"};
+ return "ToWebCoreString($value)";
+ }
+
+ if ($type eq "NodeFilter") {
+ return "V8Proxy::wrapNativeNodeFilter($value)";
+ }
+
+ if ($type eq "SVGRect") {
+ $implIncludes{"FloatRect.h"} = 1;
+ }
+
+ if ($type eq "SVGPoint") {
+ $implIncludes{"FloatPoint.h"} = 1;
+ }
+
+ # Default, assume autogenerated type conversion routines
+ $implIncludes{"V8Proxy.h"} = 1;
+ if ($type eq "EventTarget") {
+ $implIncludes{"V8Node.h"} = 1;
+
+ # EventTarget is not in DOM hierarchy, but all Nodes are EventTarget.
+ return "V8Node::HasInstance($value) ? V8Proxy::convertDOMWrapperToNode<Node>($value) : 0";
+ }
+
+ AddIncludesForType($type);
+ # $implIncludes{"$type.h"} = 1 unless AvoidInclusionOfType($type);
+
+ if (IsDOMNodeType($type)) {
+ $implIncludes{"V8${type}.h"} = 1;
+
+ # Perform type checks on the parameter, if it is expected Node type,
+ # return NULL.
+ return "V8${type}::HasInstance($value) ? V8Proxy::convertDOMWrapperToNode<${type}>($value) : 0";
+ } else {
+ # TODO: Temporary to avoid Window name conflict.
+ my $classIndex = uc($type);
+ my $implClassName = ${type};
+
+ $implIncludes{"V8$type.h"} = 1;
+
+ if (IsPodType($type)) {
+ my $nativeType = GetNativeType($type);
+ $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
+
+ return "V8SVGPODTypeUtil::ToSVGPODType<${nativeType}>(V8ClassIndex::${classIndex}, $value${maybeOkParam})"
+ }
+
+ $implIncludes{"V8${type}.h"} = 1;
+
+ # Perform type checks on the parameter, if it is expected Node type,
+ # return NULL.
+ return "V8${type}::HasInstance($value) ? V8Proxy::convertToNativeObject<${implClassName}>(V8ClassIndex::${classIndex}, $value) : 0";
+ }
+}
+
+
+sub GetV8HeaderName
+{
+ my $type = shift;
+ return "V8" . GetImplementationFileName($type);
+}
+
+
+sub CreateCustomSignature
+{
+ my $function = shift;
+ my $count = @{$function->parameters};
+ my $name = $function->signature->name;
+ my $result = " const int ${name}_argc = ${count};\n" .
+ " v8::Handle<v8::FunctionTemplate> ${name}_argv[${name}_argc] = { ";
+ my $first = 1;
+ foreach my $parameter (@{$function->parameters}) {
+ if ($first) { $first = 0; }
+ else { $result .= ", "; }
+ if (IsWrapperType($parameter->type)) {
+ my $type = $parameter->type;
+ my $header = GetV8HeaderName($type);
+ $implIncludes{$header} = 1;
+ $result .= "V8${type}::GetRawTemplate()";
+ } else {
+ $result .= "v8::Handle<v8::FunctionTemplate>()";
+ }
+ }
+ $result .= " };\n";
+ $result .= " v8::Handle<v8::Signature> ${name}_signature = v8::Signature::New(desc, ${name}_argc, ${name}_argv);\n";
+ return $result;
+}
+
+
+sub RequiresCustomSignature
+{
+ my $function = shift;
+ # No signature needed for Custom function
+ if ($function->signature->extendedAttributes->{"Custom"} ||
+ $function->signature->extendedAttributes->{"V8Custom"}) {
+ return 0;
+ }
+
+ foreach my $parameter (@{$function->parameters}) {
+ if (IsWrapperType($parameter->type)) {
+ return 1;
+ }
+ }
+ return 0;
+}
+
+
+my %non_wrapper_types = (
+ 'float' => 1,
+ 'AtomicString' => 1,
+ 'double' => 1,
+ 'short' => 1,
+ 'unsigned short' => 1,
+ 'long' => 1,
+ 'unsigned long' => 1,
+ 'boolean' => 1,
+ 'DOMString' => 1,
+ 'CompareHow' => 1,
+ 'SVGRect' => 1,
+ 'SVGPoint' => 1,
+ 'SVGMatrix' => 1,
+ 'SVGTransform' => 1,
+ 'SVGLength' => 1,
+ 'SVGNumber' => 1,
+ 'SVGPaintType' => 1,
+ 'DOMTimeStamp' => 1,
+ 'JSObject' => 1,
+ 'EventTarget' => 1,
+ 'NodeFilter' => 1,
+ 'EventListener' => 1
+);
+
+
+sub IsWrapperType
+{
+ my $type = $codeGenerator->StripModule(shift);
+ return !($non_wrapper_types{$type});
+}
+
+sub IsDOMNodeType
+{
+ my $type = shift;
+
+ return 1 if $type eq 'Attr';
+ return 1 if $type eq 'CDATASection';
+ return 1 if $type eq 'Comment';
+ return 1 if $type eq 'Document';
+ return 1 if $type eq 'DocumentFragment';
+ return 1 if $type eq 'DocumentType';
+ return 1 if $type eq 'Element';
+ return 1 if $type eq 'EntityReference';
+ return 1 if $type eq 'HTMLCanvasElement';
+ return 1 if $type eq 'HTMLDocument';
+ return 1 if $type eq 'HTMLElement';
+ return 1 if $type eq 'HTMLFormElement';
+ return 1 if $type eq 'HTMLTableCaptionElement';
+ return 1 if $type eq 'HTMLTableSectionElement';
+ return 1 if $type eq 'Node';
+ return 1 if $type eq 'ProcessingInstruction';
+ return 1 if $type eq 'SVGElement';
+ return 1 if $type eq 'SVGDocument';
+ return 1 if $type eq 'SVGSVGElement';
+ return 1 if $type eq 'SVGUseElement';
+ return 1 if $type eq 'Text';
+
+ return 0;
+}
+
+
+sub NativeToJSValue
+{
+ my $signature = shift;
+ my $value = shift;
+ my $type = $codeGenerator->StripModule($signature->type);
+ my $className= "V8$type";
+
+ return "v8::Date::New(static_cast<double>($value))" if $type eq "DOMTimeStamp";
+ return "$value ? v8::True() : v8::False()" if $type eq "boolean";
+ return "v8::Undefined()" if $type eq "void";
+
+ # For all the types where we use 'int' as the representation type,
+ # we use Integer::New which has a fast Smi conversion check.
+ return "v8::Integer::New($value)" if GetNativeType($type) eq "int";
+
+ return "v8::Number::New($value)" if $codeGenerator->IsPrimitiveType($type) or $type eq "SVGPaintType";
+
+ if ($codeGenerator->IsStringType($type)) {
+ my $conv = $signature->extendedAttributes->{"ConvertNullStringTo"};
+ if (defined $conv) {
+ return "v8StringOrNull($value)" if $conv eq "Null";
+ return "v8StringOrUndefined($value)" if $conv eq "Undefined";
+ return "v8StringOrFalse($value)" if $conv eq "False";
+
+ die "Unknown value for ConvertNullStringTo extended attribute";
+ }
+ return "v8String($value)";
+ }
+
+ # V8 specific.
+ my $implClassName = $type;
+ AddIncludesForType($type);
+ # $implIncludes{GetImplementationFileName($type)} = 1 unless AvoidInclusionOfType($type);
+
+ # special case for non-DOM node interfaces
+ if (IsDOMNodeType($type)) {
+ return "V8Proxy::convertNodeToV8Object($value)";
+ }
+
+ if ($type eq "EventTarget" or $type eq "SVGElementInstance") {
+ return "V8Proxy::convertEventTargetToV8Object($value)";
+ }
+
+ if ($type eq "Event") {
+ return "V8Proxy::convertEventToV8Object($value)";
+ }
+
+ if ($type eq "EventListener") {
+ return "V8Proxy::convertEventListenerToV8Object($value)";
+ }
+
+ if ($type eq "RGBColor") {
+ return "V8Proxy::convertToV8Object(V8ClassIndex::RGBCOLOR, new RGBColor($value))";
+ }
+
+ if ($type eq "WorkerContext" or $type eq "WorkerLocation" or $type eq "WorkerNavigator") {
+ $implIncludes{"WorkerContextExecutionProxy.h"} = 1;
+ my $classIndex = uc($type);
+
+ return "WorkerContextExecutionProxy::ToV8Object(V8ClassIndex::$classIndex, $value)";
+ }
+
+ else {
+ $implIncludes{"wtf/RefCounted.h"} = 1;
+ $implIncludes{"wtf/RefPtr.h"} = 1;
+ my $classIndex = uc($type);
+
+ if (IsPodType($type)) {
+ $value = GenerateSVGStaticPodTypeWrapper($type, $value);
+ }
+
+ return "V8Proxy::convertToV8Object(V8ClassIndex::$classIndex, $value)";
+ }
+}
+
+sub GenerateSVGStaticPodTypeWrapper {
+ my $type = shift;
+ my $value = shift;
+
+ $implIncludes{"V8$type.h"}=1;
+ $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
+
+ my $nativeType = GetNativeType($type);
+ return "new V8SVGStaticPODTypeWrapper<$nativeType>($value)";
+}
+
+# Internal helper
+sub WriteData
+{
+ if (defined($IMPL)) {
+ # Write content to file.
+ print $IMPL @implContentHeader;
+
+ print $IMPL @implFixedHeader;
+
+ foreach my $implInclude (sort keys(%implIncludes)) {
+ my $checkType = $implInclude;
+ $checkType =~ s/\.h//;
+
+ print $IMPL "#include \"$implInclude\"\n" unless $codeGenerator->IsSVGAnimatedType($checkType);
+ }
+
+ print $IMPL "\n";
+ print $IMPL @implContentDecls;
+ print $IMPL @implContent;
+ close($IMPL);
+ undef($IMPL);
+
+ %implIncludes = ();
+ @implFixedHeader = ();
+ @implHeaderContent = ();
+ @implContentDecls = ();
+ @implContent = ();
+ }
+
+ if (defined($HEADER)) {
+ # Write content to file.
+ print $HEADER @headerContent;
+ close($HEADER);
+ undef($HEADER);
+
+ @headerContent = ();
+ }
+}
+
+sub IsSVGTypeNeedingContextParameter
+{
+ my $implClassName = shift;
+
+ if ($implClassName =~ /SVG/ and not $implClassName =~ /Element/) {
+ return 1 unless $implClassName =~ /SVGPaint/ or $implClassName =~ /SVGColor/ or $implClassName =~ /SVGDocument/;
+ }
+
+ return 0;
+}
+
+sub GenerateSVGContextAssignment
+{
+ my $srcType = shift;
+ my $value = shift;
+ my $indent = shift;
+
+ $result = GenerateSVGContextRetrieval($srcType, $indent);
+ $result .= $indent . "V8Proxy::setSVGContext($value, context);\n";
+
+ return $result;
+}
+
+sub GenerateSVGContextRetrieval
+{
+ my $srcType = shift;
+ my $indent = shift;
+
+ my $srcIsPodType = IsPodType($srcType);
+
+ my $srcObject = "imp";
+ if ($srcIsPodType) {
+ $srcObject = "imp_wrapper";
+ }
+
+ my $contextDecl;
+
+ if (IsSVGTypeNeedingContextParameter($srcType)) {
+ $contextDecl = "V8Proxy::svgContext($srcObject)";
+ } else {
+ $contextDecl = $srcObject;
+ }
+
+ return $indent . "SVGElement* context = $contextDecl;\n";
+}
+
+sub IsSVGListMutator
+{
+ my $functionName = shift;
+
+ return 1 if $functionName eq "clear";
+ return 1 if $functionName eq "initialize";
+ return 1 if $functionName eq "insertItemBefore";
+ return 1 if $functionName eq "replaceItem";
+ return 1 if $functionName eq "removeItem";
+ return 1 if $functionName eq "appendItem";
+
+ return 0;
+}
+
+sub IsSVGListMethod
+{
+ my $functionName = shift;
+
+ return 1 if $functionName eq "getFirst";
+ return 1 if $functionName eq "getLast";
+ return 1 if $functionName eq "getItem";
+
+ return IsSVGListMutator($functionName);
+}
+
+sub IsSVGListTypeNeedingSpecialHandling
+{
+ my $className = shift;
+
+ return 1 if $className eq "SVGPointList";
+ return 1 if $className eq "SVGTransformList";
+
+ return 0;
+}
+
+sub DebugPrint
+{
+ my $output = shift;
+
+ print $output;
+ print "\n";
+}
diff --git a/src/3rdparty/webkit/WebCore/bindings/scripts/IDLParser.pm b/src/3rdparty/webkit/WebCore/bindings/scripts/IDLParser.pm
index de7cf9c..c4cb041 100644
--- a/src/3rdparty/webkit/WebCore/bindings/scripts/IDLParser.pm
+++ b/src/3rdparty/webkit/WebCore/bindings/scripts/IDLParser.pm
@@ -41,6 +41,7 @@ my $preservedParseMode = MODE_UNDEF;
my $beQuiet; # Should not display anything on STDOUT?
my $document = 0; # Will hold the resulting 'idlDocument'
+my $parentsOnly = 0; # If 1, parse only enough to populate parents list
# Default Constructor
sub new
@@ -62,6 +63,7 @@ sub Parse
my $fileName = shift;
my $defines = shift;
my $preprocessor = shift;
+ $parentsOnly = shift;
if (!$preprocessor) {
$preprocessor = "/usr/bin/gcc -E -P -x c++";
@@ -240,6 +242,8 @@ sub ParseInterface
push(@$arrayRef, $line);
}
+ return if $parentsOnly;
+
$interfaceData =~ s/[\n\r]/ /g;
my @interfaceMethods = split(/;/, $interfaceData);
diff --git a/src/3rdparty/webkit/WebCore/bridge/qt/qt_runtime.cpp b/src/3rdparty/webkit/WebCore/bridge/qt/qt_runtime.cpp
index e50e120..161e570 100644
--- a/src/3rdparty/webkit/WebCore/bridge/qt/qt_runtime.cpp
+++ b/src/3rdparty/webkit/WebCore/bridge/qt/qt_runtime.cpp
@@ -456,7 +456,7 @@ QVariant convertValueToQVariant(ExecState* exec, JSValue value, QMetaType::Type
case QMetaType::QTime:
if (type == Date) {
DateInstance* date = static_cast<DateInstance*>(object);
- GregorianDateTime gdt;
+ WTF::GregorianDateTime gdt;
date->getUTCTime(gdt);
if (hint == QMetaType::QDateTime) {
ret = QDateTime(QDate(gdt.year + 1900, gdt.month + 1, gdt.monthDay), QTime(gdt.hour, gdt.minute, gdt.second), Qt::UTC);
@@ -470,7 +470,7 @@ QVariant convertValueToQVariant(ExecState* exec, JSValue value, QMetaType::Type
}
} else if (type == Number) {
double b = value.toNumber(exec);
- GregorianDateTime gdt;
+ WTF::GregorianDateTime gdt;
msToGregorianDateTime(b, true, gdt);
if (hint == QMetaType::QDateTime) {
ret = QDateTime(QDate(gdt.year + 1900, gdt.month + 1, gdt.monthDay), QTime(gdt.hour, gdt.minute, gdt.second), Qt::UTC);
@@ -823,7 +823,7 @@ JSValue convertQVariantToValue(ExecState* exec, PassRefPtr<RootObject> root, con
}
// Dates specified this way are in local time (we convert DateTimes above)
- GregorianDateTime dt;
+ WTF::GregorianDateTime dt;
dt.year = date.year() - 1900;
dt.month = date.month() - 1;
dt.monthDay = date.day();
@@ -831,7 +831,7 @@ JSValue convertQVariantToValue(ExecState* exec, PassRefPtr<RootObject> root, con
dt.minute = time.minute();
dt.second = time.second();
dt.isDST = -1;
- double ms = JSC::gregorianDateTimeToMS(dt, time.msec(), /*inputIsUTC*/ false);
+ double ms = WTF::gregorianDateTimeToMS(dt, time.msec(), /*inputIsUTC*/ false);
DateInstance* instance = new (exec) DateInstance(exec->lexicalGlobalObject()->dateStructure());
instance->setInternalValue(jsNumber(exec, trunc(ms)));
diff --git a/src/3rdparty/webkit/WebCore/config.h b/src/3rdparty/webkit/WebCore/config.h
index 9714643..0700adf 100644
--- a/src/3rdparty/webkit/WebCore/config.h
+++ b/src/3rdparty/webkit/WebCore/config.h
@@ -127,11 +127,6 @@
// New theme
#define WTF_USE_NEW_THEME 1
-
-// Accelerated compositing
-#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
-#define WTF_USE_ACCELERATED_COMPOSITING 0
-#endif
#endif // PLATFORM(MAC)
#if PLATFORM(SYMBIAN)
diff --git a/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.cpp b/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.cpp
index 96aa0d7..b721f70 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.cpp
+++ b/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.cpp
@@ -28,6 +28,7 @@
#include "CSSMutableStyleDeclaration.h"
#include "CSSPrimitiveValue.h"
#include "CSSPrimitiveValueMappings.h"
+#include "CSSProperty.h"
#include "CSSPropertyNames.h"
#include "CSSReflectValue.h"
#include "CSSTimingFunctionValue.h"
@@ -1475,6 +1476,22 @@ void CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom(CSSMut
declaration->removePropertiesInSet(inheritableProperties, numInheritableProperties);
}
+bool CSSComputedStyleDeclaration::cssPropertyMatches(const CSSProperty* property) const
+{
+ if (property->id() == CSSPropertyFontSize && property->value()->isPrimitiveValue() && m_node) {
+ m_node->document()->updateLayoutIgnorePendingStylesheets();
+ RenderStyle* style = m_node->computedStyle();
+ if (style && style->fontDescription().keywordSize()) {
+ int sizeValue = cssIdentifierForFontSizeKeyword(style->fontDescription().keywordSize());
+ CSSPrimitiveValue* primitiveValue = static_cast<CSSPrimitiveValue*>(property->value());
+ if (primitiveValue->primitiveType() == CSSPrimitiveValue::CSS_IDENT && primitiveValue->getIdent() == sizeValue)
+ return true;
+ }
+ }
+
+ return CSSStyleDeclaration::cssPropertyMatches(property);
+}
+
PassRefPtr<CSSMutableStyleDeclaration> CSSComputedStyleDeclaration::copyInheritableProperties() const
{
RefPtr<CSSMutableStyleDeclaration> style = copyPropertiesInSet(inheritableProperties, numInheritableProperties);
diff --git a/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.h b/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.h
index 23244e2..6f81b0e 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.h
+++ b/src/3rdparty/webkit/WebCore/css/CSSComputedStyleDeclaration.h
@@ -59,6 +59,9 @@ public:
static void removeComputedInheritablePropertiesFrom(CSSMutableStyleDeclaration*);
+protected:
+ virtual bool cssPropertyMatches(const CSSProperty*) const;
+
private:
CSSComputedStyleDeclaration(PassRefPtr<Node>);
diff --git a/src/3rdparty/webkit/WebCore/css/CSSPrimitiveValue.h b/src/3rdparty/webkit/WebCore/css/CSSPrimitiveValue.h
index ece9fc5..8abeb4d 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSPrimitiveValue.h
+++ b/src/3rdparty/webkit/WebCore/css/CSSPrimitiveValue.h
@@ -157,7 +157,7 @@ public:
DashboardRegion* getDashboardRegionValue() const { return m_type != CSS_DASHBOARD_REGION ? 0 : m_value.region; }
int getIdent();
- template<typename T> operator T() const; // Defined in CSSPrimitiveValueMappings.h
+ template<typename T> inline operator T() const; // Defined in CSSPrimitiveValueMappings.h
virtual bool parseString(const String&, bool = false);
virtual String cssText() const;
diff --git a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.cpp b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.cpp
index a35f817..404a978 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.cpp
+++ b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.cpp
@@ -118,6 +118,12 @@ CSSRule* CSSStyleDeclaration::parentRule() const
return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0;
}
+bool CSSStyleDeclaration::cssPropertyMatches(const CSSProperty* property) const
+{
+ RefPtr<CSSValue> value = getPropertyCSSValue(property->id());
+ return value && value->cssText() == property->value()->cssText();
+}
+
void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const
{
if (!style)
@@ -128,8 +134,7 @@ void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const
CSSMutableStyleDeclaration::const_iterator end = style->end();
for (CSSMutableStyleDeclaration::const_iterator it = style->begin(); it != end; ++it) {
const CSSProperty& property = *it;
- RefPtr<CSSValue> value = getPropertyCSSValue(property.id());
- if (value && (value->cssText() == property.value()->cssText()))
+ if (cssPropertyMatches(&property))
propertiesToRemove.append(property.id());
}
}
diff --git a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.h b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.h
index ef4cc21..18493df 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.h
+++ b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.h
@@ -27,6 +27,7 @@
namespace WebCore {
class CSSMutableStyleDeclaration;
+class CSSProperty;
class CSSRule;
class CSSValue;
@@ -72,6 +73,9 @@ public:
protected:
CSSStyleDeclaration(CSSRule* parentRule = 0);
+
+ virtual bool cssPropertyMatches(const CSSProperty*) const;
+
};
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.idl b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.idl
index 60020d9..f7ce37f 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.idl
+++ b/src/3rdparty/webkit/WebCore/css/CSSStyleDeclaration.idl
@@ -23,7 +23,7 @@ module css {
// Introduced in DOM Level 2:
interface [
GenerateConstructor,
- CustomPutFunction,
+ DelegatingPutFunction,
HasNameGetter,
HasIndexGetter,
InterfaceUUID=9989b2c3-a2b6-449b-abf9-c60d2260b1d7,
diff --git a/src/3rdparty/webkit/WebCore/css/CSSStyleSelector.cpp b/src/3rdparty/webkit/WebCore/css/CSSStyleSelector.cpp
index fbc8be3..ce4c343 100644
--- a/src/3rdparty/webkit/WebCore/css/CSSStyleSelector.cpp
+++ b/src/3rdparty/webkit/WebCore/css/CSSStyleSelector.cpp
@@ -526,13 +526,13 @@ static void loadFullDefaultStyle()
}
// Strict-mode rules.
- String defaultRules = String(html4UserAgentStyleSheet, sizeof(html4UserAgentStyleSheet)) + theme()->extraDefaultStyleSheet();
+ String defaultRules = String(html4UserAgentStyleSheet, sizeof(html4UserAgentStyleSheet)) + RenderTheme::defaultTheme()->extraDefaultStyleSheet();
CSSStyleSheet* defaultSheet = parseUASheet(defaultRules);
defaultStyle->addRulesFromSheet(defaultSheet, screenEval());
defaultPrintStyle->addRulesFromSheet(defaultSheet, printEval());
// Quirks-mode rules.
- String quirksRules = String(quirksUserAgentStyleSheet, sizeof(quirksUserAgentStyleSheet)) + theme()->extraQuirksStyleSheet();
+ String quirksRules = String(quirksUserAgentStyleSheet, sizeof(quirksUserAgentStyleSheet)) + RenderTheme::defaultTheme()->extraQuirksStyleSheet();
CSSStyleSheet* quirksSheet = parseUASheet(quirksRules);
defaultQuirksStyle->addRulesFromSheet(quirksSheet, screenEval());
}
@@ -1138,7 +1138,7 @@ PassRefPtr<RenderStyle> CSSStyleSelector::styleForElement(Element* e, RenderStyl
static bool loadedMediaStyleSheet;
if (!loadedMediaStyleSheet && (e->hasTagName(videoTag) || e->hasTagName(audioTag))) {
loadedMediaStyleSheet = true;
- String mediaRules = String(mediaControlsUserAgentStyleSheet, sizeof(mediaControlsUserAgentStyleSheet)) + theme()->extraMediaControlsStyleSheet();
+ String mediaRules = String(mediaControlsUserAgentStyleSheet, sizeof(mediaControlsUserAgentStyleSheet)) + RenderTheme::defaultTheme()->extraMediaControlsStyleSheet();
CSSStyleSheet* mediaControlsSheet = parseUASheet(mediaRules);
defaultStyle->addRulesFromSheet(mediaControlsSheet, screenEval());
defaultPrintStyle->addRulesFromSheet(mediaControlsSheet, printEval());
@@ -1520,7 +1520,7 @@ void CSSStyleSelector::adjustRenderStyle(RenderStyle* style, Element *e)
// Button, legend, input, select and textarea all consider width values of 'auto' to be 'intrinsic'.
// This will be important when we use block flows for all form controls.
if (e && (e->hasTagName(legendTag) || e->hasTagName(buttonTag) || e->hasTagName(inputTag) ||
- e->hasTagName(selectTag) || e->hasTagName(textareaTag)
+ e->hasTagName(selectTag) || e->hasTagName(textareaTag) || e->hasTagName(datagridTag)
#if ENABLE(WML)
|| e->hasTagName(WMLNames::insertedLegendTag)
|| e->hasTagName(WMLNames::inputTag)
@@ -1589,7 +1589,7 @@ void CSSStyleSelector::adjustRenderStyle(RenderStyle* style, Element *e)
// Let the theme also have a crack at adjusting the style.
if (style->hasAppearance())
- theme()->adjustStyle(this, style, e, m_hasUAAppearance, m_borderData, m_backgroundData, m_backgroundColor);
+ RenderTheme::defaultTheme()->adjustStyle(this, style, e, m_hasUAAppearance, m_borderData, m_backgroundData, m_backgroundColor);
#if ENABLE(SVG)
if (e && e->isSVGElement()) {
@@ -4292,7 +4292,7 @@ void CSSStyleSelector::applyProperty(int id, CSSValue *value)
m_lineHeightValue = 0;
FontDescription fontDescription;
- theme()->systemFont(primitiveValue->getIdent(), fontDescription);
+ RenderTheme::defaultTheme()->systemFont(primitiveValue->getIdent(), fontDescription);
// Double-check and see if the theme did anything. If not, don't bother updating the font.
if (fontDescription.isAbsoluteSize()) {
@@ -5695,7 +5695,7 @@ static Color colorForCSSValue(int cssValueId)
if (col->cssValueId == cssValueId)
return col->color;
}
- return theme()->systemColor(cssValueId);
+ return RenderTheme::defaultTheme()->systemColor(cssValueId);
}
Color CSSStyleSelector::getColorFromPrimitiveValue(CSSPrimitiveValue* primitiveValue)
@@ -5718,7 +5718,7 @@ Color CSSStyleSelector::getColorFromPrimitiveValue(CSSPrimitiveValue* primitiveV
} else if (ident == CSSValueWebkitActivelink)
col = m_element->document()->activeLinkColor();
else if (ident == CSSValueWebkitFocusRingColor)
- col = focusRingColor();
+ col = RenderTheme::defaultTheme()->focusRingColor();
else if (ident == CSSValueCurrentcolor)
col = m_style->color();
else
diff --git a/src/3rdparty/webkit/WebCore/css/html4.css b/src/3rdparty/webkit/WebCore/css/html4.css
index 3e4d111..dc1f608 100644
--- a/src/3rdparty/webkit/WebCore/css/html4.css
+++ b/src/3rdparty/webkit/WebCore/css/html4.css
@@ -297,7 +297,7 @@ button {
-webkit-appearance: button;
}
-input, textarea, keygen, select, button, isindex {
+input, textarea, keygen, select, button, isindex, datagrid {
margin: 0__qem;
font: -webkit-small-control;
color: initial;
@@ -421,7 +421,9 @@ input[type="range"]::-webkit-slider-thumb {
-webkit-appearance: sliderthumb-horizontal;
}
-input[type="button"]:disabled, input[type="submit"]:disabled, input[type="reset"]:disabled, input[type="file"]:disabled::-webkit-file-upload-button, button:disabled, select:disabled, keygen:disabled, optgroup:disabled, option:disabled {
+input[type="button"]:disabled, input[type="submit"]:disabled, input[type="reset"]:disabled,
+input[type="file"]:disabled::-webkit-file-upload-button, button:disabled,
+select:disabled, keygen:disabled, optgroup:disabled, option:disabled, datagrid:disabled {
color: GrayText
}
@@ -487,6 +489,20 @@ option {
font-weight: normal;
}
+/* datagrid */
+
+datagrid {
+ height: 150px; /* We don't use width:300px in CSS, since we want width:intrinsic and width:min-intrinsic to reset to 300 properly. */
+ -webkit-appearance: datagrid;
+ -webkit-box-sizing: border-box;
+ -webkit-rtl-ordering: logical;
+ color: black;
+ background-color: white;
+ cursor: default;
+ border: 1px inset gray;
+ white-space: initial;
+}
+
/* inline elements */
u, ins {
diff --git a/src/3rdparty/webkit/WebCore/css/mediaControls.css b/src/3rdparty/webkit/WebCore/css/mediaControls.css
index b94abbf..668458c 100644
--- a/src/3rdparty/webkit/WebCore/css/mediaControls.css
+++ b/src/3rdparty/webkit/WebCore/css/mediaControls.css
@@ -30,12 +30,16 @@ audio {
}
audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
+ display: -webkit-box;
+ -webkit-box-orient: horizontal;
+ -webkit-user-select: none;
position: absolute;
bottom: 0;
width: 100%;
- height: 100%;
- -webkit-user-select: none;
z-index: 0;
+ overflow: hidden;
+ height: 16px;
+ text-align: right;
}
video:-webkit-full-page-media::-webkit-media-controls-panel {
@@ -44,32 +48,26 @@ video:-webkit-full-page-media::-webkit-media-controls-panel {
audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button {
-webkit-appearance: media-mute-button;
- position: absolute;
- top: auto;
- bottom: 0;
- left: 0;
- width: 17px;
+ display: -webkit-box;
+ width: 16px;
height: 16px;
}
audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button {
-webkit-appearance: media-play-button;
- position: absolute;
- top: auto;
- bottom: 0;
- left: 16px;
- width: 17px;
+ display: -webkit-box;
+ width: 16px;
height: 16px;
}
audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container {
+ -webkit-appearance: media-timeline-container;
+ display: -webkit-box;
+ -webkit-box-orient: horizontal;
+ -webkit-box-align: center;
+ -webkit-box-pack: end;
+ -webkit-box-flex: 1;
-webkit-user-select: none;
- position: absolute;
- padding: 0px 16px 0px 0px;
- top: auto;
- bottom: 0;
- left: 32px;
- right: 32px;
height: 16px;
}
@@ -83,35 +81,27 @@ audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-contr
audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline {
-webkit-appearance: media-slider;
- position: absolute;
- top: auto;
- bottom: 0;
- left: 0px;
- right: 0px;
+ display: -webkit-box;
+ -webkit-box-flex: 1;
height: 16px;
padding: 0px 2px;
}
audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button {
-webkit-appearance: media-seek-back-button;
- position: absolute;
- top: auto;
- bottom: 0;
- right: 16px;
- width: 17px;
+ display: -webkit-box;
+ width: 16px;
height: 16px;
}
audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button {
-webkit-appearance: media-seek-forward-button;
- position: absolute;
- top: auto;
- bottom: 0;
- right: 0;
- width: 17px;
+ display: -webkit-box;
+ width: 16px;
height: 16px;
}
audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button {
display: none;
}
+
diff --git a/src/3rdparty/webkit/WebCore/css/mediaControlsQT.css b/src/3rdparty/webkit/WebCore/css/mediaControlsQT.css
index 918c9bf..900dcf2 100644
--- a/src/3rdparty/webkit/WebCore/css/mediaControlsQT.css
+++ b/src/3rdparty/webkit/WebCore/css/mediaControlsQT.css
@@ -22,7 +22,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-/* alternate media controls */
+/* alternate media controls - Extend mediaControls.css */
audio {
width: 200px;
@@ -30,47 +30,26 @@ audio {
}
audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
- -webkit-user-select: none;
- position: absolute;
- bottom: 0;
- width: 100%;
- height: 100%;
- z-index: 0;
+ /* In mediaControls.css */
+ height: 25px;
}
video:-webkit-full-page-media::-webkit-media-controls-panel {
- bottom: -16px;
+ bottom: -25px;
}
audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button {
- -webkit-appearance: media-mute-button;
- position: absolute;
- top: auto;
- bottom: 0;
- right: 0;
- left: auto;
+ -webkit-box-ordinal-group: 2; /* At the end of the controller bar */
width: 30px;
height: 25px;
}
audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button {
- -webkit-appearance: media-play-button;
- position: absolute;
- top: auto;
- bottom: 0;
- left: 0px;
width: 30px;
height: 25px;
}
audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container {
- -webkit-appearance: media-timeline-container;
- -webkit-user-select: none;
- position: absolute;
- top: auto;
- bottom: 0;
- left: 30px;
- right: 30px;
height: 25px;
}
@@ -78,17 +57,13 @@ audio::-webkit-media-controls-current-time-display, video::-webkit-media-control
-webkit-appearance: media-current-time-display;
-webkit-user-select: none;
display: inline-block;
- position: absolute;
cursor: default;
font: -webkit-small-control;
font-size: .09em;
text-align: center;
overflow: hidden;
line-height: 13px;
- top: auto;
- bottom: 6px;
- left: 0px;
- height: 13px;
+ height: 14px;
width: 45px;
}
@@ -96,36 +71,28 @@ audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-contr
-webkit-appearance: media-time-remaining-display;
-webkit-user-select: none;
display: inline-block;
- position: absolute;
cursor: default;
font: -webkit-small-control;
font-size: .09em;
text-align: center;
overflow: hidden;
line-height: 13px;
- top: auto;
- bottom: 6px;
- right: 0px;
- height: 13px;
+ height: 14px;
width: 45px;
}
audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline {
- -webkit-appearance: media-slider;
- position: absolute;
- top: auto;
- bottom: 6px;
- left: 45px;
- right: 45px;
height: 13px;
}
audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button {
display: none;
+ width: 0px;
}
audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button {
display: none;
+ width: 0px;
}
audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button {
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePortProxy.h b/src/3rdparty/webkit/WebCore/css/themeChromiumLinux.css
index 9e768ce..f8210c3 100644
--- a/src/3rdparty/webkit/WebCore/dom/MessagePortProxy.h
+++ b/src/3rdparty/webkit/WebCore/css/themeChromiumLinux.css
@@ -28,27 +28,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef MessagePortProxy_h
-#define MessagePortProxy_h
+/* These styles override other user-agent styles for Chromium on Linux. */
-#include <wtf/PassRefPtr.h>
-#include <wtf/RefCounted.h>
-
-namespace WebCore {
-
- class MessagePort;
- class String;
-
- class MessagePortProxy : public RefCounted<MessagePortProxy> {
- public:
- virtual ~MessagePortProxy() { }
-
- virtual void entangle(MessagePortProxy*) = 0;
- virtual void unentangle() = 0;
- virtual void deliverMessage(const String& message, PassRefPtr<MessagePort>) = 0;
- virtual void queueCloseEvent() = 0;
- };
-
-} // namespace WebCore
-
-#endif // MessagePortProxy_h
+select {
+ background-color: #dddddd;
+ border: 0px;
+}
diff --git a/src/3rdparty/webkit/WebCore/css/view-source.css b/src/3rdparty/webkit/WebCore/css/view-source.css
index 20722ee..f898565 100644
--- a/src/3rdparty/webkit/WebCore/css/view-source.css
+++ b/src/3rdparty/webkit/WebCore/css/view-source.css
@@ -33,8 +33,8 @@ table {
white-space: pre-wrap !important;
margin: 0;
word-break: break-word;
- font-size: 10px;
- font-family: Monaco, Lucida Console, monospace;
+ font-size: initial;
+ font-family: monospace;
}
td {
diff --git a/src/3rdparty/webkit/WebCore/dom/Clipboard.h b/src/3rdparty/webkit/WebCore/dom/Clipboard.h
index 59ae026..0fea604 100644
--- a/src/3rdparty/webkit/WebCore/dom/Clipboard.h
+++ b/src/3rdparty/webkit/WebCore/dom/Clipboard.h
@@ -33,6 +33,8 @@
namespace WebCore {
+ class FileList;
+
// State available during IE's events for drag and drop and copy/paste
class Clipboard : public RefCounted<Clipboard> {
public:
@@ -53,11 +55,12 @@ namespace WebCore {
// extensions beyond IE's API
virtual HashSet<String> types() const = 0;
-
+ virtual PassRefPtr<FileList> files() const = 0;
+
IntPoint dragLocation() const { return m_dragLoc; }
CachedImage* dragImage() const { return m_dragImage.get(); }
virtual void setDragImage(CachedImage*, const IntPoint&) = 0;
- Node* dragImageElement() { return m_dragImageElement.get(); }
+ Node* dragImageElement() const { return m_dragImageElement.get(); }
virtual void setDragImageElement(Node*, const IntPoint&) = 0;
virtual DragImageRef createDragImage(IntPoint& dragLocation) const = 0;
diff --git a/src/3rdparty/webkit/WebCore/dom/Clipboard.idl b/src/3rdparty/webkit/WebCore/dom/Clipboard.idl
index 6fe83f7..dc8677e 100644
--- a/src/3rdparty/webkit/WebCore/dom/Clipboard.idl
+++ b/src/3rdparty/webkit/WebCore/dom/Clipboard.idl
@@ -34,6 +34,7 @@ module core {
attribute [ConvertNullStringTo=Undefined] DOMString dropEffect;
attribute [ConvertNullStringTo=Undefined] DOMString effectAllowed;
readonly attribute [CustomGetter] Array types;
+ readonly attribute FileList files;
[Custom] void clearData(in [Optional] DOMString type)
raises(DOMException);
diff --git a/src/3rdparty/webkit/WebCore/dom/ContainerNode.cpp b/src/3rdparty/webkit/WebCore/dom/ContainerNode.cpp
index 2573908..20cc7a3 100644
--- a/src/3rdparty/webkit/WebCore/dom/ContainerNode.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/ContainerNode.cpp
@@ -798,7 +798,7 @@ void ContainerNode::setActive(bool down, bool pause)
if (reactsToPress)
setNeedsStyleRecalc();
if (renderer() && renderer()->style()->hasAppearance()) {
- if (theme()->stateChanged(renderer(), PressedState))
+ if (renderer()->theme()->stateChanged(renderer(), PressedState))
reactsToPress = true;
}
if (reactsToPress && pause) {
@@ -840,7 +840,7 @@ void ContainerNode::setHovered(bool over)
if (renderer()->style()->affectedByHoverRules())
setNeedsStyleRecalc();
if (renderer() && renderer()->style()->hasAppearance())
- theme()->stateChanged(renderer(), HoverState);
+ renderer()->theme()->stateChanged(renderer(), HoverState);
}
}
diff --git a/src/3rdparty/webkit/WebCore/dom/DOMImplementation.cpp b/src/3rdparty/webkit/WebCore/dom/DOMImplementation.cpp
index 783c629..065f708 100644
--- a/src/3rdparty/webkit/WebCore/dom/DOMImplementation.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/DOMImplementation.cpp
@@ -314,14 +314,8 @@ PassRefPtr<HTMLDocument> DOMImplementation::createHTMLDocument(const String& tit
PassRefPtr<Document> DOMImplementation::createDocument(const String& type, Frame* frame, bool inViewSourceMode)
{
- if (inViewSourceMode) {
- if (type == "text/html" || type == "application/xhtml+xml" || type == "image/svg+xml" || isTextMIMEType(type) || isXMLMIMEType(type)
-#if ENABLE(XHTMLMP)
- || type == "application/vnd.wap.xhtml+xml"
-#endif
- )
- return HTMLViewSourceDocument::create(frame, type);
- }
+ if (inViewSourceMode)
+ return HTMLViewSourceDocument::create(frame, type);
// Plugins cannot take HTML and XHTML from us, and we don't even need to initialize the plugin database for those.
if (type == "text/html")
diff --git a/src/3rdparty/webkit/WebCore/dom/Document.cpp b/src/3rdparty/webkit/WebCore/dom/Document.cpp
index 75c0ba0..3d01c80 100644
--- a/src/3rdparty/webkit/WebCore/dom/Document.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/Document.cpp
@@ -5,7 +5,7 @@
* (C) 2006 Alexey Proskuryakov (ap@webkit.org)
* Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
* Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
- * Copyright (C) 2008 David Levin (levin@chromium.org)
+ * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -1338,6 +1338,12 @@ void Document::detach()
// in order to stop media elements
documentWillBecomeInactive();
+ if (m_frame) {
+ FrameView* view = m_frame->view();
+ if (view)
+ view->detachCustomScrollbars();
+ }
+
// indicate destruction mode, i.e. attached() but renderer == 0
setRenderer(0);
@@ -1477,7 +1483,7 @@ void Document::open(Document* ownerDocument)
if (m_frame->loader()->state() == FrameStateProvisional)
m_frame->loader()->stopAllLoaders();
}
-
+
implicitOpen();
if (m_frame)
@@ -1505,6 +1511,9 @@ void Document::implicitOpen()
m_tokenizer = createTokenizer();
setParsing(true);
+ if (m_frame)
+ m_tokenizer->setXSSAuditor(m_frame->script()->xssAuditor());
+
// If we reload, the animation controller sticks around and has
// a stale animation time. We need to update it here.
if (m_frame && m_frame->animation())
@@ -2531,7 +2540,7 @@ bool Document::setFocusedNode(PassRefPtr<Node> newFocusedNode)
focusChangeBlocked = true;
newFocusedNode = 0;
}
- oldFocusedNode->dispatchUIEvent(eventNames().DOMFocusOutEvent);
+ oldFocusedNode->dispatchUIEvent(eventNames().DOMFocusOutEvent, 0, 0);
if (m_focusedNode) {
// handler shifted focus
focusChangeBlocked = true;
@@ -2561,7 +2570,7 @@ bool Document::setFocusedNode(PassRefPtr<Node> newFocusedNode)
focusChangeBlocked = true;
goto SetFocusedNodeDone;
}
- m_focusedNode->dispatchUIEvent(eventNames().DOMFocusInEvent);
+ m_focusedNode->dispatchUIEvent(eventNames().DOMFocusInEvent, 0, 0);
if (m_focusedNode != newFocusedNode) {
// handler shifted focus
focusChangeBlocked = true;
@@ -2739,6 +2748,14 @@ void Document::setWindowAttributeEventListener(const AtomicString& eventType, Pa
domWindow->setAttributeEventListener(eventType, listener);
}
+EventListener* Document::getWindowAttributeEventListener(const AtomicString& eventType)
+{
+ DOMWindow* domWindow = this->domWindow();
+ if (!domWindow)
+ return 0;
+ return domWindow->getAttributeEventListener(eventType);
+}
+
void Document::dispatchWindowEvent(PassRefPtr<Event> event)
{
ASSERT(!eventDispatchForbidden());
@@ -4287,7 +4304,8 @@ void Document::attachRange(Range* range)
void Document::detachRange(Range* range)
{
- ASSERT(m_ranges.contains(range));
+ // We don't ASSERT m_ranges.contains(range) to allow us to call this
+ // unconditionally to fix: https://bugs.webkit.org/show_bug.cgi?id=26044
m_ranges.remove(range);
}
diff --git a/src/3rdparty/webkit/WebCore/dom/Document.h b/src/3rdparty/webkit/WebCore/dom/Document.h
index 2747d09..92865f4 100644
--- a/src/3rdparty/webkit/WebCore/dom/Document.h
+++ b/src/3rdparty/webkit/WebCore/dom/Document.h
@@ -566,6 +566,7 @@ public:
// Helper functions for forwarding DOMWindow event related tasks to the DOMWindow if it exists.
void setWindowAttributeEventListener(const AtomicString& eventType, PassRefPtr<EventListener>);
+ EventListener* getWindowAttributeEventListener(const AtomicString& eventType);
void dispatchWindowEvent(PassRefPtr<Event>);
void dispatchWindowEvent(const AtomicString& eventType, bool canBubbleArg, bool cancelableArg);
void dispatchLoadEvent();
diff --git a/src/3rdparty/webkit/WebCore/dom/Document.idl b/src/3rdparty/webkit/WebCore/dom/Document.idl
index 232ceb4..ac6dd0e 100644
--- a/src/3rdparty/webkit/WebCore/dom/Document.idl
+++ b/src/3rdparty/webkit/WebCore/dom/Document.idl
@@ -244,6 +244,78 @@ module core {
void resetWMLPageState();
void initializeWMLPageState();
#endif
+
+#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
+#if !defined(LANGUAGE_COM) || !LANGUAGE_COM
+ // Event handler DOM attributes
+ attribute [DontEnum] EventListener onabort;
+ attribute [DontEnum] EventListener onblur;
+ attribute [DontEnum] EventListener onchange;
+ attribute [DontEnum] EventListener onclick;
+ attribute [DontEnum] EventListener oncontextmenu;
+ attribute [DontEnum] EventListener ondblclick;
+ attribute [DontEnum] EventListener ondrag;
+ attribute [DontEnum] EventListener ondragend;
+ attribute [DontEnum] EventListener ondragenter;
+ attribute [DontEnum] EventListener ondragleave;
+ attribute [DontEnum] EventListener ondragover;
+ attribute [DontEnum] EventListener ondragstart;
+ attribute [DontEnum] EventListener ondrop;
+ attribute [DontEnum] EventListener onerror;
+ attribute [DontEnum] EventListener onfocus;
+ attribute [DontEnum] EventListener oninput;
+ attribute [DontEnum] EventListener onkeydown;
+ attribute [DontEnum] EventListener onkeypress;
+ attribute [DontEnum] EventListener onkeyup;
+ attribute [DontEnum] EventListener onload;
+ attribute [DontEnum] EventListener onmousedown;
+ attribute [DontEnum] EventListener onmousemove;
+ attribute [DontEnum] EventListener onmouseout;
+ attribute [DontEnum] EventListener onmouseover;
+ attribute [DontEnum] EventListener onmouseup;
+ attribute [DontEnum] EventListener onmousewheel;
+ attribute [DontEnum] EventListener onscroll;
+ attribute [DontEnum] EventListener onselect;
+ attribute [DontEnum] EventListener onsubmit;
+
+ // attribute [DontEnum] EventListener oncanplay;
+ // attribute [DontEnum] EventListener oncanplaythrough;
+ // attribute [DontEnum] EventListener ondurationchange;
+ // attribute [DontEnum] EventListener onemptied;
+ // attribute [DontEnum] EventListener onended;
+ // attribute [DontEnum] EventListener onformchange;
+ // attribute [DontEnum] EventListener onforminput;
+ // attribute [DontEnum] EventListener oninvalid;
+ // attribute [DontEnum] EventListener onloadeddata;
+ // attribute [DontEnum] EventListener onloadedmetadata;
+ // attribute [DontEnum] EventListener onloadstart;
+ // attribute [DontEnum] EventListener onpause;
+ // attribute [DontEnum] EventListener onplay;
+ // attribute [DontEnum] EventListener onplaying;
+ // attribute [DontEnum] EventListener onprogress;
+ // attribute [DontEnum] EventListener onratechange;
+ // attribute [DontEnum] EventListener onreadystatechange;
+ // attribute [DontEnum] EventListener onseeked;
+ // attribute [DontEnum] EventListener onseeking;
+ // attribute [DontEnum] EventListener onshow;
+ // attribute [DontEnum] EventListener onstalled;
+ // attribute [DontEnum] EventListener onsuspend;
+ // attribute [DontEnum] EventListener ontimeupdate;
+ // attribute [DontEnum] EventListener onvolumechange;
+ // attribute [DontEnum] EventListener onwaiting;
+
+ // WebKit extensions
+ attribute [DontEnum] EventListener onbeforecut;
+ attribute [DontEnum] EventListener oncut;
+ attribute [DontEnum] EventListener onbeforecopy;
+ attribute [DontEnum] EventListener oncopy;
+ attribute [DontEnum] EventListener onbeforepaste;
+ attribute [DontEnum] EventListener onpaste;
+ attribute [DontEnum] EventListener onreset;
+ attribute [DontEnum] EventListener onsearch;
+ attribute [DontEnum] EventListener onselectstart;
+#endif
+#endif
};
}
diff --git a/src/3rdparty/webkit/WebCore/dom/Element.cpp b/src/3rdparty/webkit/WebCore/dom/Element.cpp
index 4cf49bb..d858888 100644
--- a/src/3rdparty/webkit/WebCore/dom/Element.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/Element.cpp
@@ -1341,4 +1341,15 @@ unsigned Element::childElementCount() const
return count;
}
+KURL Element::getURLAttribute(const QualifiedName& name) const
+{
+#ifndef NDEBUG
+ if (namedAttrMap) {
+ if (Attribute* attribute = namedAttrMap->getAttributeItem(name))
+ ASSERT(isURLAttribute(attribute));
+ }
+#endif
+ return document()->completeURL(getAttribute(name));
+}
+
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/Element.h b/src/3rdparty/webkit/WebCore/dom/Element.h
index 5e95abd..dfa2c0e 100644
--- a/src/3rdparty/webkit/WebCore/dom/Element.h
+++ b/src/3rdparty/webkit/WebCore/dom/Element.h
@@ -61,7 +61,7 @@ public:
void setAttribute(const AtomicString& name, const AtomicString& value, ExceptionCode&);
void setAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, const AtomicString& value, ExceptionCode&);
- void scrollIntoView (bool alignToTop = true);
+ void scrollIntoView(bool alignToTop = true);
void scrollIntoViewIfNeeded(bool centerIfNeeded = true);
void scrollByUnits(int units, ScrollGranularity);
@@ -158,6 +158,7 @@ public:
virtual void accessKeyAction(bool /*sendToAnyEvent*/) { }
virtual bool isURLAttribute(Attribute*) const;
+ KURL getURLAttribute(const QualifiedName&) const;
virtual const QualifiedName& imageSourceAttributeName() const;
virtual String target() const { return String(); }
diff --git a/src/3rdparty/webkit/WebCore/dom/Element.idl b/src/3rdparty/webkit/WebCore/dom/Element.idl
index 6e16bfe..53711e9 100644
--- a/src/3rdparty/webkit/WebCore/dom/Element.idl
+++ b/src/3rdparty/webkit/WebCore/dom/Element.idl
@@ -129,6 +129,77 @@ module core {
readonly attribute DOMString innerText;
#endif
+#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
+#if !defined(LANGUAGE_COM) || !LANGUAGE_COM
+ // Event handler DOM attributes
+ attribute [DontEnum] EventListener onabort;
+ attribute [DontEnum] EventListener onblur;
+ attribute [DontEnum] EventListener onchange;
+ attribute [DontEnum] EventListener onclick;
+ attribute [DontEnum] EventListener oncontextmenu;
+ attribute [DontEnum] EventListener ondblclick;
+ attribute [DontEnum] EventListener ondrag;
+ attribute [DontEnum] EventListener ondragend;
+ attribute [DontEnum] EventListener ondragenter;
+ attribute [DontEnum] EventListener ondragleave;
+ attribute [DontEnum] EventListener ondragover;
+ attribute [DontEnum] EventListener ondragstart;
+ attribute [DontEnum] EventListener ondrop;
+ attribute [DontEnum] EventListener onerror;
+ attribute [DontEnum] EventListener onfocus;
+ attribute [DontEnum] EventListener oninput;
+ attribute [DontEnum] EventListener onkeydown;
+ attribute [DontEnum] EventListener onkeypress;
+ attribute [DontEnum] EventListener onkeyup;
+ attribute [DontEnum] EventListener onload;
+ attribute [DontEnum] EventListener onmousedown;
+ attribute [DontEnum] EventListener onmousemove;
+ attribute [DontEnum] EventListener onmouseout;
+ attribute [DontEnum] EventListener onmouseover;
+ attribute [DontEnum] EventListener onmouseup;
+ attribute [DontEnum] EventListener onmousewheel;
+ attribute [DontEnum] EventListener onscroll;
+ attribute [DontEnum] EventListener onselect;
+ attribute [DontEnum] EventListener onsubmit;
+
+ // attribute [DontEnum] EventListener oncanplay;
+ // attribute [DontEnum] EventListener oncanplaythrough;
+ // attribute [DontEnum] EventListener ondurationchange;
+ // attribute [DontEnum] EventListener onemptied;
+ // attribute [DontEnum] EventListener onended;
+ // attribute [DontEnum] EventListener onformchange;
+ // attribute [DontEnum] EventListener onforminput;
+ // attribute [DontEnum] EventListener oninvalid;
+ // attribute [DontEnum] EventListener onloadeddata;
+ // attribute [DontEnum] EventListener onloadedmetadata;
+ // attribute [DontEnum] EventListener onloadstart;
+ // attribute [DontEnum] EventListener onpause;
+ // attribute [DontEnum] EventListener onplay;
+ // attribute [DontEnum] EventListener onplaying;
+ // attribute [DontEnum] EventListener onprogress;
+ // attribute [DontEnum] EventListener onratechange;
+ // attribute [DontEnum] EventListener onreadystatechange;
+ // attribute [DontEnum] EventListener onseeked;
+ // attribute [DontEnum] EventListener onseeking;
+ // attribute [DontEnum] EventListener onshow;
+ // attribute [DontEnum] EventListener onstalled;
+ // attribute [DontEnum] EventListener onsuspend;
+ // attribute [DontEnum] EventListener ontimeupdate;
+ // attribute [DontEnum] EventListener onvolumechange;
+ // attribute [DontEnum] EventListener onwaiting;
+
+ // WebKit extensions
+ attribute [DontEnum] EventListener onbeforecut;
+ attribute [DontEnum] EventListener oncut;
+ attribute [DontEnum] EventListener onbeforecopy;
+ attribute [DontEnum] EventListener oncopy;
+ attribute [DontEnum] EventListener onbeforepaste;
+ attribute [DontEnum] EventListener onpaste;
+ attribute [DontEnum] EventListener onreset;
+ attribute [DontEnum] EventListener onsearch;
+ attribute [DontEnum] EventListener onselectstart;
+#endif
+#endif
};
}
diff --git a/src/3rdparty/webkit/WebCore/dom/MessageChannel.cpp b/src/3rdparty/webkit/WebCore/dom/MessageChannel.cpp
index 3a90913..ac0a4ab 100644
--- a/src/3rdparty/webkit/WebCore/dom/MessageChannel.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/MessageChannel.cpp
@@ -28,14 +28,15 @@
#include "MessageChannel.h"
#include "MessagePort.h"
+#include "PlatformMessagePortChannel.h"
namespace WebCore {
MessageChannel::MessageChannel(ScriptExecutionContext* context)
- : m_port1(MessagePort::create(context))
- , m_port2(MessagePort::create(context))
+ : m_port1(MessagePort::create(*context))
+ , m_port2(MessagePort::create(*context))
{
- MessagePort::entangle(m_port1.get(), m_port2.get());
+ PlatformMessagePortChannel::createChannel(m_port1.get(), m_port2.get());
}
MessageChannel::~MessageChannel()
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePort.cpp b/src/3rdparty/webkit/WebCore/dom/MessagePort.cpp
index efd89e7..9f3e4d2 100644
--- a/src/3rdparty/webkit/WebCore/dom/MessagePort.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/MessagePort.cpp
@@ -38,89 +38,23 @@
namespace WebCore {
-class MessagePortCloseEventTask : public ScriptExecutionContext::Task {
-public:
- static PassRefPtr<MessagePortCloseEventTask> create(PassRefPtr<MessagePort> port)
- {
- return adoptRef(new MessagePortCloseEventTask(port));
- }
-
-private:
- MessagePortCloseEventTask(PassRefPtr<MessagePort> port)
- : m_port(port)
- {
- ASSERT(m_port);
- }
-
- virtual void performTask(ScriptExecutionContext* unusedContext)
- {
- ASSERT_UNUSED(unusedContext, unusedContext == m_port->scriptExecutionContext());
- ASSERT(!m_port->active());
-
- // Closing may destroy the port, dispatch any remaining messages now.
- if (m_port->queueIsOpen())
- m_port->dispatchMessages();
-
- m_port->dispatchCloseEvent();
- }
-
- RefPtr<MessagePort> m_port;
-};
-
-PassRefPtr<MessagePort::EventData> MessagePort::EventData::create(const String& message, PassRefPtr<MessagePort> port)
-{
- return adoptRef(new EventData(message, port));
-}
-
-MessagePort::EventData::EventData(const String& message, PassRefPtr<MessagePort> messagePort)
- : message(message.copy())
- , messagePort(messagePort)
-{
-}
-
-MessagePort::EventData::~EventData()
+MessagePort::MessagePort(ScriptExecutionContext& scriptExecutionContext)
+ : m_entangledChannel(0)
+ , m_started(false)
+ , m_scriptExecutionContext(&scriptExecutionContext)
{
-}
+ m_scriptExecutionContext->createdMessagePort(this);
-MessagePort::MessagePort(ScriptExecutionContext* scriptExecutionContext)
- : m_entangledPort(0)
- , m_queueIsOpen(false)
- , m_scriptExecutionContext(scriptExecutionContext)
- , m_pendingCloseEvent(false)
-{
- if (scriptExecutionContext)
- scriptExecutionContext->createdMessagePort(this);
+ // Don't need to call processMessagePortMessagesSoon() here, because the port will not be opened until start() is invoked.
}
MessagePort::~MessagePort()
{
- if (m_entangledPort)
- unentangle();
-
+ close();
if (m_scriptExecutionContext)
m_scriptExecutionContext->destroyedMessagePort(this);
}
-PassRefPtr<MessagePort> MessagePort::clone(ExceptionCode& ec)
-{
- if (!m_entangledPort) {
- ec = INVALID_STATE_ERR;
- return 0;
- }
-
- RefPtr<MessagePortProxy> remotePort = m_entangledPort;
- RefPtr<MessagePort> newPort = MessagePort::create(0);
-
- // Move all the events in the port message queue of original port to the port message queue of new port, if any, leaving the new port's port message queue in its initial closed state.
- // If events are posted (e.g. from a worker thread) while this code is executing, there is no guarantee whether they end up in the original or new port's message queue.
- RefPtr<EventData> eventData;
- while (m_messageQueue.tryGetMessage(eventData))
- newPort->m_messageQueue.append(eventData);
-
- entangle(remotePort.get(), newPort.get()); // The port object will be unentangled.
- return newPort;
-}
-
void MessagePort::postMessage(const String& message, ExceptionCode& ec)
{
postMessage(message, 0, ec);
@@ -128,112 +62,86 @@ void MessagePort::postMessage(const String& message, ExceptionCode& ec)
void MessagePort::postMessage(const String& message, MessagePort* dataPort, ExceptionCode& ec)
{
- if (!m_entangledPort || !m_scriptExecutionContext)
+ if (!m_entangledChannel)
return;
+ ASSERT(m_scriptExecutionContext);
- RefPtr<MessagePort> newMessagePort;
+ OwnPtr<MessagePortChannel> channel;
if (dataPort) {
- if (dataPort == this || dataPort == m_entangledPort) {
- ec = INVALID_ACCESS_ERR;
+ if (dataPort == this || m_entangledChannel->isConnectedTo(dataPort)) {
+ ec = INVALID_STATE_ERR;
return;
}
- ec = 0;
- newMessagePort = dataPort->clone(ec);
+ channel = dataPort->disentangle(ec);
if (ec)
return;
}
-
- m_entangledPort->deliverMessage(message, newMessagePort);
+ m_entangledChannel->postMessageToRemote(MessagePortChannel::EventData::create(message, channel.release()));
}
-void MessagePort::deliverMessage(const String& message, PassRefPtr<MessagePort> dataPort)
+PassOwnPtr<MessagePortChannel> MessagePort::disentangle(ExceptionCode& ec)
{
- m_messageQueue.append(EventData::create(message, dataPort));
- if (m_queueIsOpen && m_scriptExecutionContext)
- m_scriptExecutionContext->processMessagePortMessagesSoon();
+ if (!m_entangledChannel)
+ ec = INVALID_STATE_ERR;
+ else {
+ m_entangledChannel->disentangle();
+
+ // We can't receive any messages or generate any events, so remove ourselves from the list of active ports.
+ ASSERT(m_scriptExecutionContext);
+ m_scriptExecutionContext->destroyedMessagePort(this);
+ m_scriptExecutionContext = 0;
+ }
+ return m_entangledChannel.release();
}
-PassRefPtr<MessagePort> MessagePort::startConversation(ScriptExecutionContext* scriptExecutionContext, const String& message)
+// Invoked to notify us that there are messages available for this port.
+// This code may be called from another thread, and so should not call any non-threadsafe APIs (i.e. should not call into the entangled channel or access mutable variables).
+void MessagePort::messageAvailable()
{
- RefPtr<MessagePort> port1 = MessagePort::create(scriptExecutionContext);
- if (!m_entangledPort || !m_scriptExecutionContext)
- return port1;
- RefPtr<MessagePort> port2 = MessagePort::create(0);
-
- entangle(port1.get(), port2.get());
-
- m_entangledPort->deliverMessage(message, port2);
- return port1;
+ ASSERT(m_scriptExecutionContext);
+ m_scriptExecutionContext->processMessagePortMessagesSoon();
}
void MessagePort::start()
{
- if (m_queueIsOpen || !m_scriptExecutionContext)
+ // Do nothing if we've been cloned
+ if (!m_entangledChannel)
+ return;
+
+ ASSERT(m_scriptExecutionContext);
+ if (m_started)
return;
- m_queueIsOpen = true;
+ m_started = true;
m_scriptExecutionContext->processMessagePortMessagesSoon();
}
void MessagePort::close()
{
- if (!m_entangledPort)
+ if (!m_entangledChannel)
return;
-
- MessagePortProxy* otherPort = m_entangledPort;
- unentangle();
-
- queueCloseEvent();
- otherPort->queueCloseEvent();
-}
-
-void MessagePort::entangle(MessagePortProxy* port1, MessagePortProxy* port2)
-{
- port1->entangle(port2);
- port2->entangle(port1);
+ m_entangledChannel->close();
}
-void MessagePort::entangle(MessagePortProxy* remote)
+void MessagePort::entangle(PassOwnPtr<MessagePortChannel> remote)
{
- // Unentangle from our current port first.
- if (m_entangledPort) {
- ASSERT(m_entangledPort != remote);
- unentangle();
- }
- m_entangledPort = remote;
-}
+ // Only invoked to set our initial entanglement.
+ ASSERT(!m_entangledChannel);
+ ASSERT(m_scriptExecutionContext);
-void MessagePort::unentangle()
-{
- // Unentangle our end before unentangling the other end.
- if (m_entangledPort) {
- MessagePortProxy* remote = m_entangledPort;
- m_entangledPort = 0;
- remote->unentangle();
- }
+ // Don't entangle the ports if the channel is closed.
+ if (remote->entangleIfOpen(this))
+ m_entangledChannel = remote;
}
void MessagePort::contextDestroyed()
{
ASSERT(m_scriptExecutionContext);
-
- if (m_entangledPort)
- unentangle();
-
+ // Must close port before blowing away the cached context, to ensure that we get no more calls to messageAvailable().
+ close();
m_scriptExecutionContext = 0;
}
-void MessagePort::attachToContext(ScriptExecutionContext* scriptExecutionContext)
-{
- ASSERT(!m_scriptExecutionContext);
- ASSERT(!m_queueIsOpen);
-
- m_scriptExecutionContext = scriptExecutionContext;
- m_scriptExecutionContext->createdMessagePort(this);
-
- // FIXME: Need to call processMessagePortMessagesSoon()?
-}
-
ScriptExecutionContext* MessagePort::scriptExecutionContext() const
{
return m_scriptExecutionContext;
@@ -242,17 +150,19 @@ ScriptExecutionContext* MessagePort::scriptExecutionContext() const
void MessagePort::dispatchMessages()
{
// Messages for contexts that are not fully active get dispatched too, but JSAbstractEventListener::handleEvent() doesn't call handlers for these.
- // FIXME: Such messages should be dispatched if the document returns from page cache. They are only allowed to be lost if the document is discarded.
- ASSERT(queueIsOpen());
-
- RefPtr<EventData> eventData;
- while (m_messageQueue.tryGetMessage(eventData)) {
-
- ASSERT(!eventData->messagePort || !eventData->messagePort->m_scriptExecutionContext);
- if (eventData->messagePort)
- eventData->messagePort->attachToContext(m_scriptExecutionContext);
-
- RefPtr<Event> evt = MessageEvent::create(eventData->message, "", "", 0, eventData->messagePort);
+ // The HTML5 spec specifies that any messages sent to a document that is not fully active should be dropped, so this behavior is OK.
+ ASSERT(started());
+
+ OwnPtr<MessagePortChannel::EventData> eventData;
+ while (m_entangledChannel && m_entangledChannel->tryGetMessageFromRemote(eventData)) {
+ RefPtr<MessagePort> port;
+ OwnPtr<MessagePortChannel> channel = eventData->channel();
+ if (channel) {
+ // The remote side sent over a MessagePortChannel, so create a MessagePort to wrap it.
+ port = MessagePort::create(*m_scriptExecutionContext);
+ port->entangle(channel.release());
+ }
+ RefPtr<Event> evt = MessageEvent::create(eventData->message(), "", "", 0, port.release());
if (m_onMessageListener) {
evt->setTarget(this);
@@ -266,31 +176,6 @@ void MessagePort::dispatchMessages()
}
}
-void MessagePort::queueCloseEvent()
-{
- ASSERT(!m_pendingCloseEvent);
- m_pendingCloseEvent = true;
-
- m_scriptExecutionContext->postTask(MessagePortCloseEventTask::create(this));
-}
-
-void MessagePort::dispatchCloseEvent()
-{
- ASSERT(m_pendingCloseEvent);
- m_pendingCloseEvent = false;
-
- RefPtr<Event> evt = Event::create(eventNames().closeEvent, false, true);
- if (m_onCloseListener) {
- evt->setTarget(this);
- evt->setCurrentTarget(this);
- m_onCloseListener->handleEvent(evt.get(), false);
- }
-
- ExceptionCode ec = 0;
- dispatchEvent(evt.release(), ec);
- ASSERT(!ec);
-}
-
void MessagePort::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> eventListener, bool)
{
EventListenersMap::iterator iter = m_eventListeners.find(eventType);
@@ -342,9 +227,22 @@ bool MessagePort::dispatchEvent(PassRefPtr<Event> event, ExceptionCode& ec)
return !event->defaultPrevented();
}
+void MessagePort::setOnmessage(PassRefPtr<EventListener> eventListener)
+{
+ m_onMessageListener = eventListener;
+ start();
+}
+
bool MessagePort::hasPendingActivity()
{
- return m_pendingCloseEvent || (m_queueIsOpen && !m_messageQueue.isEmpty());
+ // The spec says that entangled message ports should always be treated as if they have a strong reference.
+ // We'll also stipulate that the queue needs to be open (if the app drops its reference to the port before start()-ing it, then it's not really entangled as it's unreachable).
+ return m_started && m_entangledChannel && m_entangledChannel->hasPendingActivity();
+}
+
+MessagePort* MessagePort::locallyEntangledPort()
+{
+ return m_entangledChannel ? m_entangledChannel->locallyEntangledPort(m_scriptExecutionContext) : 0;
}
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePort.h b/src/3rdparty/webkit/WebCore/dom/MessagePort.h
index 054ae41..f416b9b 100644
--- a/src/3rdparty/webkit/WebCore/dom/MessagePort.h
+++ b/src/3rdparty/webkit/WebCore/dom/MessagePort.h
@@ -30,10 +30,11 @@
#include "AtomicStringHash.h"
#include "EventListener.h"
#include "EventTarget.h"
-#include "MessagePortProxy.h"
+#include "MessagePortChannel.h"
#include <wtf/HashMap.h>
-#include <wtf/MessageQueue.h>
+#include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
#include <wtf/PassRefPtr.h>
#include <wtf/RefPtr.h>
#include <wtf/Vector.h>
@@ -45,35 +46,25 @@ namespace WebCore {
class Frame;
class ScriptExecutionContext;
class String;
- class WorkerContext;
- class MessagePort : public MessagePortProxy, public EventTarget {
+ class MessagePort : public RefCounted<MessagePort>, public EventTarget {
public:
- static PassRefPtr<MessagePort> create(ScriptExecutionContext* scriptExecutionContext) { return adoptRef(new MessagePort(scriptExecutionContext)); }
+ static PassRefPtr<MessagePort> create(ScriptExecutionContext& scriptExecutionContext) { return adoptRef(new MessagePort(scriptExecutionContext)); }
~MessagePort();
- PassRefPtr<MessagePort> clone(ExceptionCode&); // Returns a port that isn't attached to any context.
-
- bool active() const { return m_entangledPort; }
void postMessage(const String& message, ExceptionCode&);
void postMessage(const String& message, MessagePort*, ExceptionCode&);
- PassRefPtr<MessagePort> startConversation(ScriptExecutionContext*, const String& message);
void start();
void close();
- // Implementations of MessagePortProxy APIs
- virtual void entangle(MessagePortProxy*);
- virtual void unentangle();
- virtual void deliverMessage(const String& message, PassRefPtr<MessagePort>);
- virtual void queueCloseEvent();
-
- bool queueIsOpen() const { return m_queueIsOpen; }
+ void entangle(PassOwnPtr<MessagePortChannel>);
+ PassOwnPtr<MessagePortChannel> disentangle(ExceptionCode&);
- MessagePortProxy* entangledPort() { return m_entangledPort; }
- static void entangle(MessagePortProxy*, MessagePortProxy*);
+ void messageAvailable();
+ bool started() const { return m_started; }
void contextDestroyed();
- void attachToContext(ScriptExecutionContext*);
+
virtual ScriptExecutionContext* scriptExecutionContext() const;
virtual MessagePort* toMessagePort() { return this; }
@@ -88,52 +79,35 @@ namespace WebCore {
typedef HashMap<AtomicString, ListenerVector> EventListenersMap;
EventListenersMap& eventListeners() { return m_eventListeners; }
- using RefCounted<MessagePortProxy>::ref;
- using RefCounted<MessagePortProxy>::deref;
+ using RefCounted<MessagePort>::ref;
+ using RefCounted<MessagePort>::deref;
bool hasPendingActivity();
- // FIXME: Per current spec, setting onmessage should automagically start the port (unlike addEventListener("message", ...)).
- void setOnmessage(PassRefPtr<EventListener> eventListener) { m_onMessageListener = eventListener; }
+ void setOnmessage(PassRefPtr<EventListener>);
EventListener* onmessage() const { return m_onMessageListener.get(); }
- void setOnclose(PassRefPtr<EventListener> eventListener) { m_onCloseListener = eventListener; }
- EventListener* onclose() const { return m_onCloseListener.get(); }
+ // Returns null if there is no entangled port, or if the entangled port is run by a different thread.
+ // Returns null otherwise.
+ // NOTE: This is used solely to enable a GC optimization. Some platforms may not be able to determine ownership of the remote port (since it may live cross-process) - those platforms may always return null.
+ MessagePort* locallyEntangledPort();
+ bool isEntangled() { return m_entangledChannel; }
private:
- friend class MessagePortCloseEventTask;
-
- MessagePort(ScriptExecutionContext*);
+ MessagePort(ScriptExecutionContext&);
virtual void refEventTarget() { ref(); }
virtual void derefEventTarget() { deref(); }
- void dispatchCloseEvent();
+ OwnPtr<MessagePortChannel> m_entangledChannel;
- MessagePortProxy* m_entangledPort;
-
- // FIXME: EventData is necessary to pass messages to other threads. In single threaded case, we can just queue a created event.
- struct EventData : public RefCounted<EventData> {
- static PassRefPtr<EventData> create(const String& message, PassRefPtr<MessagePort>);
- ~EventData();
-
- String message;
- RefPtr<MessagePort> messagePort;
-
- private:
- EventData(const String& message, PassRefPtr<MessagePort>);
- };
- MessageQueue<RefPtr<EventData> > m_messageQueue; // FIXME: No need to use MessageQueue in single threaded case.
- bool m_queueIsOpen;
+ bool m_started;
ScriptExecutionContext* m_scriptExecutionContext;
RefPtr<EventListener> m_onMessageListener;
- RefPtr<EventListener> m_onCloseListener;
EventListenersMap m_eventListeners;
-
- bool m_pendingCloseEvent; // The port is GC protected while waiting for a close event to be dispatched.
};
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePort.idl b/src/3rdparty/webkit/WebCore/dom/MessagePort.idl
index 03c6bab..e5f9ad1 100644
--- a/src/3rdparty/webkit/WebCore/dom/MessagePort.idl
+++ b/src/3rdparty/webkit/WebCore/dom/MessagePort.idl
@@ -34,16 +34,13 @@ module events {
// We need to have something as an ObjC binding, because MessagePort is used in MessageEvent, which already has one,
// but we don't want to actually expose the API while it is in flux.
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
- readonly attribute boolean active;
void postMessage(in DOMString message, in [Optional] MessagePort messagePort)
raises(DOMException);
- [Custom] MessagePort startConversation(in DOMString message);
void start();
void close();
// event handler attributes
attribute EventListener onmessage;
- attribute EventListener onclose;
// EventTarget interface
[Custom] void addEventListener(in DOMString type,
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.cpp b/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.cpp
new file mode 100644
index 0000000..768d4f4
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.cpp
@@ -0,0 +1,64 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+#include "config.h"
+#include "MessagePortChannel.h"
+
+#include "PlatformMessagePortChannel.h"
+
+namespace WebCore {
+
+PassOwnPtr<MessagePortChannel> MessagePortChannel::create(PassRefPtr<PlatformMessagePortChannel> channel)
+{
+ return new MessagePortChannel(channel);
+}
+
+PassOwnPtr<MessagePortChannel::EventData> MessagePortChannel::EventData::create(const String& message, PassOwnPtr<MessagePortChannel> channel)
+{
+ return new EventData(message, channel);
+}
+
+MessagePortChannel::EventData::EventData(const String& message, PassOwnPtr<MessagePortChannel> channel)
+ : m_message(message.copy())
+ , m_channel(channel)
+{
+}
+
+MessagePortChannel::MessagePortChannel(PassRefPtr<PlatformMessagePortChannel> channel)
+ : m_channel(channel)
+{
+}
+
+MessagePortChannel::~MessagePortChannel()
+{
+ // Make sure we close our platform channel when the base is freed, to keep the channel objects from leaking.
+ m_channel->close();
+}
+
+} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.h b/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.h
new file mode 100644
index 0000000..15b3d16
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/dom/MessagePortChannel.h
@@ -0,0 +1,103 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef MessagePortChannel_h
+#define MessagePortChannel_h
+
+#include "PlatformString.h"
+
+#include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
+#include <wtf/PassRefPtr.h>
+#include <wtf/RefCounted.h>
+#include <wtf/RefPtr.h>
+
+namespace WebCore {
+
+ class MessagePort;
+ class PlatformMessagePortChannel;
+ class ScriptExecutionContext;
+ class String;
+
+ // MessagePortChannel is a platform-independent interface to the remote side of a message channel.
+ // It acts as a wrapper around the platform-dependent PlatformMessagePortChannel implementation which ensures that the platform-dependent close() method is invoked before destruction.
+ class MessagePortChannel : Noncopyable {
+ public:
+ // Creates a new wrapper for the passed channel.
+ static PassOwnPtr<MessagePortChannel> create(PassRefPtr<PlatformMessagePortChannel>);
+
+ // Entangles the channel with a port (called when a port has been cloned, after the clone has been marshalled to its new owning thread and is ready to receive messages).
+ // Returns false if the entanglement failed because the port was closed.
+ bool entangleIfOpen(MessagePort*);
+
+ // Disentangles the channel from a given port so it no longer forwards messages to the port. Called when the port is being cloned and no new owning thread has yet been established.
+ void disentangle();
+
+ // Closes the port (ensures that no further messages can be added to either queue).
+ void close();
+
+ // Used by MessagePort.postMessage() to prevent callers from passing a port's own entangled port.
+ bool isConnectedTo(MessagePort*);
+
+ // Returns true if the proxy currently contains messages for this port.
+ bool hasPendingActivity();
+
+ class EventData {
+ public:
+ static PassOwnPtr<EventData> create(const String&, PassOwnPtr<MessagePortChannel>);
+
+ const String& message() { return m_message; }
+ PassOwnPtr<MessagePortChannel> channel() { return m_channel.release(); }
+
+ private:
+ EventData(const String& message, PassOwnPtr<MessagePortChannel>);
+ String m_message;
+ OwnPtr<MessagePortChannel> m_channel;
+ };
+
+ // Sends a message and optional cloned port to the remote port.
+ void postMessageToRemote(PassOwnPtr<EventData>);
+
+ // Extracts a message from the message queue for this port.
+ bool tryGetMessageFromRemote(OwnPtr<EventData>&);
+
+ // Returns the entangled port if run by the same thread (see MessagePort::locallyEntangledPort() for more details).
+ MessagePort* locallyEntangledPort(const ScriptExecutionContext*);
+
+ ~MessagePortChannel();
+
+ private:
+ MessagePortChannel(PassRefPtr<PlatformMessagePortChannel>);
+ RefPtr<PlatformMessagePortChannel> m_channel;
+ };
+
+} // namespace WebCore
+
+#endif // MessagePortChannel_h
diff --git a/src/3rdparty/webkit/WebCore/dom/Node.cpp b/src/3rdparty/webkit/WebCore/dom/Node.cpp
index cd554df..3ddf4c0 100644
--- a/src/3rdparty/webkit/WebCore/dom/Node.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/Node.cpp
@@ -282,7 +282,7 @@ void Node::stopIgnoringLeaks()
#endif
}
-Node::StyleChange Node::diff( RenderStyle *s1, RenderStyle *s2 )
+Node::StyleChange Node::diff(const RenderStyle* s1, const RenderStyle* s2)
{
// FIXME: The behavior of this function is just totally wrong. It doesn't handle
// explicit inheritance of non-inherited properties and so you end up not re-resolving
@@ -302,6 +302,12 @@ Node::StyleChange Node::diff( RenderStyle *s1, RenderStyle *s2 )
else if (s1->inheritedNotEqual(s2))
ch = Inherit;
+ // For nth-child and other positional rules, treat styles as different if they have
+ // changed positionally in the DOM. This way subsequent sibling resolutions won't be confused
+ // by the wrong child index and evaluate to incorrect results.
+ if (ch == NoChange && s1->childIndex() != s2->childIndex())
+ ch = NoInherit;
+
// If the pseudoStyles have changed, we want any StyleChange that is not NoChange
// because setStyle will do the right thing with anything else.
if (ch == NoChange && s1->hasPseudoStyle(BEFORE)) {
@@ -1353,6 +1359,14 @@ bool Node::canStartSelection() const
{
if (isContentEditable())
return true;
+
+ if (renderer()) {
+ RenderStyle* style = renderer()->style();
+ // We allow selections to begin within an element that has -webkit-user-select: none set,
+ // but if the element is draggable then dragging should take priority over selection.
+ if (style->userDrag() == DRAG_ELEMENT && style->userSelect() == SELECT_NONE)
+ return false;
+ }
return parent() ? parent()->canStartSelection() : true;
}
@@ -2478,7 +2492,7 @@ bool Node::dispatchGenericEvent(PassRefPtr<Event> prpEvent)
event->setEventPhase(Event::CAPTURING_PHASE);
if (targetForWindowEvents) {
- event->setCurrentTarget(targetForWindowEvents->document()); // FIXME: targetForWindowEvents should be the event target.
+ event->setCurrentTarget(targetForWindowEvents);
targetForWindowEvents->handleEvent(event.get(), true);
if (event->propagationStopped())
goto doneDispatching;
@@ -2516,7 +2530,7 @@ bool Node::dispatchGenericEvent(PassRefPtr<Event> prpEvent)
goto doneDispatching;
}
if (targetForWindowEvents) {
- event->setCurrentTarget(targetForWindowEvents->document()); // FIXME: targetForWindowEvents should be the event target.
+ event->setCurrentTarget(targetForWindowEvents);
targetForWindowEvents->handleEvent(event.get(), false);
if (event->propagationStopped() || event->cancelBubble())
goto doneDispatching;
@@ -2619,7 +2633,7 @@ bool Node::dispatchMouseEvent(const PlatformMouseEvent& event, const AtomicStrin
return dispatchMouseEvent(eventType, button, detail,
contentsPos.x(), contentsPos.y(), event.globalX(), event.globalY(),
event.ctrlKey(), event.altKey(), event.shiftKey(), event.metaKey(),
- false, relatedTarget);
+ false, relatedTarget, 0);
}
void Node::dispatchSimulatedMouseEvent(const AtomicString& eventType,
@@ -3083,66 +3097,6 @@ void Node::setOnmousewheel(PassRefPtr<EventListener> eventListener)
setAttributeEventListener(eventNames().mousewheelEvent, eventListener);
}
-EventListener* Node::onbeforecut() const
-{
- return getAttributeEventListener(eventNames().beforecutEvent);
-}
-
-void Node::setOnbeforecut(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().beforecutEvent, eventListener);
-}
-
-EventListener* Node::oncut() const
-{
- return getAttributeEventListener(eventNames().cutEvent);
-}
-
-void Node::setOncut(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().cutEvent, eventListener);
-}
-
-EventListener* Node::onbeforecopy() const
-{
- return getAttributeEventListener(eventNames().beforecopyEvent);
-}
-
-void Node::setOnbeforecopy(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().beforecopyEvent, eventListener);
-}
-
-EventListener* Node::oncopy() const
-{
- return getAttributeEventListener(eventNames().copyEvent);
-}
-
-void Node::setOncopy(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().copyEvent, eventListener);
-}
-
-EventListener* Node::onbeforepaste() const
-{
- return getAttributeEventListener(eventNames().beforepasteEvent);
-}
-
-void Node::setOnbeforepaste(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().beforepasteEvent, eventListener);
-}
-
-EventListener* Node::onpaste() const
-{
- return getAttributeEventListener(eventNames().pasteEvent);
-}
-
-void Node::setOnpaste(PassRefPtr<EventListener> eventListener)
-{
- setAttributeEventListener(eventNames().pasteEvent, eventListener);
-}
-
EventListener* Node::ondragenter() const
{
return getAttributeEventListener(eventNames().dragenterEvent);
@@ -3213,84 +3167,124 @@ void Node::setOndragend(PassRefPtr<EventListener> eventListener)
setAttributeEventListener(eventNames().dragendEvent, eventListener);
}
-EventListener* Node::onreset() const
+EventListener* Node::onscroll() const
{
- return getAttributeEventListener(eventNames().resetEvent);
+ return getAttributeEventListener(eventNames().scrollEvent);
}
-void Node::setOnreset(PassRefPtr<EventListener> eventListener)
+void Node::setOnscroll(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().resetEvent, eventListener);
+ setAttributeEventListener(eventNames().scrollEvent, eventListener);
}
-EventListener* Node::onresize() const
+EventListener* Node::onselect() const
{
- return getAttributeEventListener(eventNames().resizeEvent);
+ return getAttributeEventListener(eventNames().selectEvent);
}
-void Node::setOnresize(PassRefPtr<EventListener> eventListener)
+void Node::setOnselect(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().resizeEvent, eventListener);
+ setAttributeEventListener(eventNames().selectEvent, eventListener);
}
-EventListener* Node::onscroll() const
+EventListener* Node::onsubmit() const
{
- return getAttributeEventListener(eventNames().scrollEvent);
+ return getAttributeEventListener(eventNames().submitEvent);
}
-void Node::setOnscroll(PassRefPtr<EventListener> eventListener)
+void Node::setOnsubmit(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().scrollEvent, eventListener);
+ setAttributeEventListener(eventNames().submitEvent, eventListener);
}
-EventListener* Node::onsearch() const
+EventListener* Node::onbeforecut() const
{
- return getAttributeEventListener(eventNames().searchEvent);
+ return getAttributeEventListener(eventNames().beforecutEvent);
}
-void Node::setOnsearch(PassRefPtr<EventListener> eventListener)
+void Node::setOnbeforecut(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().searchEvent, eventListener);
+ setAttributeEventListener(eventNames().beforecutEvent, eventListener);
}
-EventListener* Node::onselect() const
+EventListener* Node::oncut() const
{
- return getAttributeEventListener(eventNames().selectEvent);
+ return getAttributeEventListener(eventNames().cutEvent);
}
-void Node::setOnselect(PassRefPtr<EventListener> eventListener)
+void Node::setOncut(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().selectEvent, eventListener);
+ setAttributeEventListener(eventNames().cutEvent, eventListener);
}
-EventListener* Node::onselectstart() const
+EventListener* Node::onbeforecopy() const
{
- return getAttributeEventListener(eventNames().selectstartEvent);
+ return getAttributeEventListener(eventNames().beforecopyEvent);
}
-void Node::setOnselectstart(PassRefPtr<EventListener> eventListener)
+void Node::setOnbeforecopy(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().selectstartEvent, eventListener);
+ setAttributeEventListener(eventNames().beforecopyEvent, eventListener);
}
-EventListener* Node::onsubmit() const
+EventListener* Node::oncopy() const
{
- return getAttributeEventListener(eventNames().submitEvent);
+ return getAttributeEventListener(eventNames().copyEvent);
}
-void Node::setOnsubmit(PassRefPtr<EventListener> eventListener)
+void Node::setOncopy(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().submitEvent, eventListener);
+ setAttributeEventListener(eventNames().copyEvent, eventListener);
+}
+
+EventListener* Node::onbeforepaste() const
+{
+ return getAttributeEventListener(eventNames().beforepasteEvent);
+}
+
+void Node::setOnbeforepaste(PassRefPtr<EventListener> eventListener)
+{
+ setAttributeEventListener(eventNames().beforepasteEvent, eventListener);
+}
+
+EventListener* Node::onpaste() const
+{
+ return getAttributeEventListener(eventNames().pasteEvent);
+}
+
+void Node::setOnpaste(PassRefPtr<EventListener> eventListener)
+{
+ setAttributeEventListener(eventNames().pasteEvent, eventListener);
+}
+
+EventListener* Node::onreset() const
+{
+ return getAttributeEventListener(eventNames().resetEvent);
+}
+
+void Node::setOnreset(PassRefPtr<EventListener> eventListener)
+{
+ setAttributeEventListener(eventNames().resetEvent, eventListener);
+}
+
+EventListener* Node::onsearch() const
+{
+ return getAttributeEventListener(eventNames().searchEvent);
+}
+
+void Node::setOnsearch(PassRefPtr<EventListener> eventListener)
+{
+ setAttributeEventListener(eventNames().searchEvent, eventListener);
}
-EventListener* Node::onunload() const
+EventListener* Node::onselectstart() const
{
- return getAttributeEventListener(eventNames().unloadEvent);
+ return getAttributeEventListener(eventNames().selectstartEvent);
}
-void Node::setOnunload(PassRefPtr<EventListener> eventListener)
+void Node::setOnselectstart(PassRefPtr<EventListener> eventListener)
{
- setAttributeEventListener(eventNames().unloadEvent, eventListener);
+ setAttributeEventListener(eventNames().selectstartEvent, eventListener);
}
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/Node.h b/src/3rdparty/webkit/WebCore/dom/Node.h
index 8313ca8..ab743f4 100644
--- a/src/3rdparty/webkit/WebCore/dom/Node.h
+++ b/src/3rdparty/webkit/WebCore/dom/Node.h
@@ -106,7 +106,7 @@ public:
static void dumpStatistics();
enum StyleChange { NoChange, NoInherit, Inherit, Detach, Force };
- static StyleChange diff(RenderStyle*, RenderStyle*);
+ static StyleChange diff(const RenderStyle*, const RenderStyle*);
Node(Document*, bool isElement = false, bool isContainer = false, bool isText = false);
virtual ~Node();
@@ -531,7 +531,7 @@ public:
void removeAllEventListeners() { if (hasRareData()) removeAllEventListenersSlowCase(); }
void dispatchSubtreeModifiedEvent();
- void dispatchUIEvent(const AtomicString& eventType, int detail = 0, PassRefPtr<Event> underlyingEvent = 0);
+ void dispatchUIEvent(const AtomicString& eventType, int detail, PassRefPtr<Event> underlyingEvent);
bool dispatchKeyEvent(const PlatformKeyboardEvent&);
void dispatchWheelEvent(PlatformWheelEvent&);
bool dispatchMouseEvent(const PlatformMouseEvent&, const AtomicString& eventType,
@@ -539,8 +539,8 @@ public:
bool dispatchMouseEvent(const AtomicString& eventType, int button, int clickCount,
int pageX, int pageY, int screenX, int screenY,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey,
- bool isSimulated = false, Node* relatedTarget = 0, PassRefPtr<Event> underlyingEvent = 0);
- void dispatchSimulatedMouseEvent(const AtomicString& eventType, PassRefPtr<Event> underlyingEvent = 0);
+ bool isSimulated, Node* relatedTarget, PassRefPtr<Event> underlyingEvent);
+ void dispatchSimulatedMouseEvent(const AtomicString& eventType, PassRefPtr<Event> underlyingEvent);
void dispatchSimulatedClick(PassRefPtr<Event> underlyingEvent, bool sendMouseEvents = false, bool showPressedLook = true);
void dispatchProgressEvent(const AtomicString& eventType, bool lengthComputableArg, unsigned loadedArg, unsigned totalArg);
void dispatchWebKitAnimationEvent(const AtomicString& eventType, const String& animationName, double elapsedTime);
@@ -567,10 +567,19 @@ public:
const RegisteredEventListenerVector& eventListeners() const;
+ // These 4 attribute event handler attributes are overrided by HTMLBodyElement
+ // and HTMLFrameSetElement to forward to the DOMWindow.
+ virtual EventListener* onblur() const;
+ virtual void setOnblur(PassRefPtr<EventListener>);
+ virtual EventListener* onerror() const;
+ virtual void setOnerror(PassRefPtr<EventListener>);
+ virtual EventListener* onfocus() const;
+ virtual void setOnfocus(PassRefPtr<EventListener>);
+ virtual EventListener* onload() const;
+ virtual void setOnload(PassRefPtr<EventListener>);
+
EventListener* onabort() const;
void setOnabort(PassRefPtr<EventListener>);
- EventListener* onblur() const;
- void setOnblur(PassRefPtr<EventListener>);
EventListener* onchange() const;
void setOnchange(PassRefPtr<EventListener>);
EventListener* onclick() const;
@@ -579,10 +588,6 @@ public:
void setOncontextmenu(PassRefPtr<EventListener>);
EventListener* ondblclick() const;
void setOndblclick(PassRefPtr<EventListener>);
- EventListener* onerror() const;
- void setOnerror(PassRefPtr<EventListener>);
- EventListener* onfocus() const;
- void setOnfocus(PassRefPtr<EventListener>);
EventListener* oninput() const;
void setOninput(PassRefPtr<EventListener>);
EventListener* onkeydown() const;
@@ -591,8 +596,6 @@ public:
void setOnkeypress(PassRefPtr<EventListener>);
EventListener* onkeyup() const;
void setOnkeyup(PassRefPtr<EventListener>);
- EventListener* onload() const;
- void setOnload(PassRefPtr<EventListener>);
EventListener* onmousedown() const;
void setOnmousedown(PassRefPtr<EventListener>);
EventListener* onmousemove() const;
@@ -605,18 +608,6 @@ public:
void setOnmouseup(PassRefPtr<EventListener>);
EventListener* onmousewheel() const;
void setOnmousewheel(PassRefPtr<EventListener>);
- EventListener* onbeforecut() const;
- void setOnbeforecut(PassRefPtr<EventListener>);
- EventListener* oncut() const;
- void setOncut(PassRefPtr<EventListener>);
- EventListener* onbeforecopy() const;
- void setOnbeforecopy(PassRefPtr<EventListener>);
- EventListener* oncopy() const;
- void setOncopy(PassRefPtr<EventListener>);
- EventListener* onbeforepaste() const;
- void setOnbeforepaste(PassRefPtr<EventListener>);
- EventListener* onpaste() const;
- void setOnpaste(PassRefPtr<EventListener>);
EventListener* ondragenter() const;
void setOndragenter(PassRefPtr<EventListener>);
EventListener* ondragover() const;
@@ -631,22 +622,32 @@ public:
void setOndrag(PassRefPtr<EventListener>);
EventListener* ondragend() const;
void setOndragend(PassRefPtr<EventListener>);
- EventListener* onreset() const;
- void setOnreset(PassRefPtr<EventListener>);
- EventListener* onresize() const;
- void setOnresize(PassRefPtr<EventListener>);
EventListener* onscroll() const;
void setOnscroll(PassRefPtr<EventListener>);
- EventListener* onsearch() const;
- void setOnsearch(PassRefPtr<EventListener>);
EventListener* onselect() const;
void setOnselect(PassRefPtr<EventListener>);
- EventListener* onselectstart() const;
- void setOnselectstart(PassRefPtr<EventListener>);
EventListener* onsubmit() const;
void setOnsubmit(PassRefPtr<EventListener>);
- EventListener* onunload() const;
- void setOnunload(PassRefPtr<EventListener>);
+
+ // WebKit extensions
+ EventListener* onbeforecut() const;
+ void setOnbeforecut(PassRefPtr<EventListener>);
+ EventListener* oncut() const;
+ void setOncut(PassRefPtr<EventListener>);
+ EventListener* onbeforecopy() const;
+ void setOnbeforecopy(PassRefPtr<EventListener>);
+ EventListener* oncopy() const;
+ void setOncopy(PassRefPtr<EventListener>);
+ EventListener* onbeforepaste() const;
+ void setOnbeforepaste(PassRefPtr<EventListener>);
+ EventListener* onpaste() const;
+ void setOnpaste(PassRefPtr<EventListener>);
+ EventListener* onreset() const;
+ void setOnreset(PassRefPtr<EventListener>);
+ EventListener* onsearch() const;
+ void setOnsearch(PassRefPtr<EventListener>);
+ EventListener* onselectstart() const;
+ void setOnselectstart(PassRefPtr<EventListener>);
using TreeShared<Node>::ref;
using TreeShared<Node>::deref;
diff --git a/src/3rdparty/webkit/WebCore/dom/Node.idl b/src/3rdparty/webkit/WebCore/dom/Node.idl
index 45d325a..bcfb226 100644
--- a/src/3rdparty/webkit/WebCore/dom/Node.idl
+++ b/src/3rdparty/webkit/WebCore/dom/Node.idl
@@ -135,47 +135,6 @@ module core {
#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
#if !defined(LANGUAGE_COM) || !LANGUAGE_COM
- attribute [DontEnum] EventListener onabort;
- attribute [DontEnum] EventListener onblur;
- attribute [DontEnum] EventListener onchange;
- attribute [DontEnum] EventListener onclick;
- attribute [DontEnum] EventListener oncontextmenu;
- attribute [DontEnum] EventListener ondblclick;
- attribute [DontEnum] EventListener onerror;
- attribute [DontEnum] EventListener onfocus;
- attribute [DontEnum] EventListener oninput;
- attribute [DontEnum] EventListener onkeydown;
- attribute [DontEnum] EventListener onkeypress;
- attribute [DontEnum] EventListener onkeyup;
- attribute [DontEnum] EventListener onload;
- attribute [DontEnum] EventListener onmousedown;
- attribute [DontEnum] EventListener onmousemove;
- attribute [DontEnum] EventListener onmouseout;
- attribute [DontEnum] EventListener onmouseover;
- attribute [DontEnum] EventListener onmouseup;
- attribute [DontEnum] EventListener onmousewheel;
- attribute [DontEnum] EventListener onbeforecut;
- attribute [DontEnum] EventListener oncut;
- attribute [DontEnum] EventListener onbeforecopy;
- attribute [DontEnum] EventListener oncopy;
- attribute [DontEnum] EventListener onbeforepaste;
- attribute [DontEnum] EventListener onpaste;
- attribute [DontEnum] EventListener ondragenter;
- attribute [DontEnum] EventListener ondragover;
- attribute [DontEnum] EventListener ondragleave;
- attribute [DontEnum] EventListener ondrop;
- attribute [DontEnum] EventListener ondragstart;
- attribute [DontEnum] EventListener ondrag;
- attribute [DontEnum] EventListener ondragend;
- attribute [DontEnum] EventListener onreset;
- attribute [DontEnum] EventListener onresize;
- attribute [DontEnum] EventListener onscroll;
- attribute [DontEnum] EventListener onsearch;
- attribute [DontEnum] EventListener onselect;
- attribute [DontEnum] EventListener onselectstart;
- attribute [DontEnum] EventListener onsubmit;
- attribute [DontEnum] EventListener onunload;
-
[Custom] void addEventListener(in DOMString type,
in EventListener listener,
in boolean useCapture);
diff --git a/src/3rdparty/webkit/WebCore/dom/Position.cpp b/src/3rdparty/webkit/WebCore/dom/Position.cpp
index 0dd48d4..3b4c3e8 100644
--- a/src/3rdparty/webkit/WebCore/dom/Position.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/Position.cpp
@@ -922,18 +922,18 @@ static bool isNonTextLeafChild(RenderObject* object)
static InlineTextBox* searchAheadForBetterMatch(RenderObject* renderer)
{
- InlineTextBox* match = 0;
- int minOffset = INT_MAX;
RenderBlock* container = renderer->containingBlock();
RenderObject* next = renderer;
while ((next = next->nextInPreOrder(container))) {
if (next->isRenderBlock())
- break;
+ return 0;
if (next->isBR())
- break;
+ return 0;
if (isNonTextLeafChild(next))
- break;
+ return 0;
if (next->isText()) {
+ InlineTextBox* match = 0;
+ int minOffset = INT_MAX;
for (InlineTextBox* box = toRenderText(next)->firstTextBox(); box; box = box->nextTextBox()) {
int caretMinOffset = box->caretMinOffset();
if (caretMinOffset < minOffset) {
@@ -941,9 +941,11 @@ static InlineTextBox* searchAheadForBetterMatch(RenderObject* renderer)
minOffset = caretMinOffset;
}
}
+ if (match)
+ return match;
}
}
- return match;
+ return 0;
}
void Position::getInlineBoxAndOffset(EAffinity affinity, TextDirection primaryDirection, InlineBox*& inlineBox, int& caretOffset) const
diff --git a/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp b/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp
index 906902a..879bf62 100644
--- a/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/ProcessingInstruction.cpp
@@ -258,8 +258,7 @@ void ProcessingInstruction::removedFromDocument()
{
ContainerNode::removedFromDocument();
- if (document()->renderer())
- document()->removeStyleSheetCandidateNode(this);
+ document()->removeStyleSheetCandidateNode(this);
// FIXME: It's terrible to do a synchronous update of the style selector just because a <style> or <link> element got removed.
if (m_cachedSheet)
diff --git a/src/3rdparty/webkit/WebCore/dom/Range.cpp b/src/3rdparty/webkit/WebCore/dom/Range.cpp
index 8a3ca8f..4fb1164 100644
--- a/src/3rdparty/webkit/WebCore/dom/Range.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/Range.cpp
@@ -95,8 +95,8 @@ PassRefPtr<Range> Range::create(PassRefPtr<Document> ownerDocument, const Positi
Range::~Range()
{
- if (m_start.container())
- m_ownerDocument->detachRange(this);
+ // Always detach (even if we've already detached) to fix https://bugs.webkit.org/show_bug.cgi?id=26044
+ m_ownerDocument->detachRange(this);
#ifndef NDEBUG
rangeCounter.decrement();
@@ -379,7 +379,6 @@ Range::CompareResults Range::compareNode(Node* refNode, ExceptionCode& ec)
}
}
-
short Range::compareBoundaryPoints(CompareHow how, const Range* sourceRange, ExceptionCode& ec) const
{
if (!m_start.container()) {
@@ -1070,6 +1069,7 @@ PassRefPtr<DocumentFragment> Range::createContextualFragment(const String& marku
void Range::detach(ExceptionCode& ec)
{
+ // Check first to see if we've already detached:
if (!m_start.container()) {
ec = INVALID_STATE_ERR;
return;
diff --git a/src/3rdparty/webkit/WebCore/dom/RangeBoundaryPoint.h b/src/3rdparty/webkit/WebCore/dom/RangeBoundaryPoint.h
index 2fda51f..1bbbe1a 100644
--- a/src/3rdparty/webkit/WebCore/dom/RangeBoundaryPoint.h
+++ b/src/3rdparty/webkit/WebCore/dom/RangeBoundaryPoint.h
@@ -33,7 +33,6 @@ namespace WebCore {
class RangeBoundaryPoint {
public:
- RangeBoundaryPoint();
explicit RangeBoundaryPoint(PassRefPtr<Node> container);
const Position toPosition() const;
@@ -63,17 +62,12 @@ private:
Node* m_childBeforeBoundary;
};
-inline RangeBoundaryPoint::RangeBoundaryPoint()
- : m_offsetInContainer(0)
- , m_childBeforeBoundary(0)
-{
-}
-
inline RangeBoundaryPoint::RangeBoundaryPoint(PassRefPtr<Node> container)
: m_containerNode(container)
, m_offsetInContainer(0)
, m_childBeforeBoundary(0)
{
+ ASSERT(m_containerNode);
}
inline Node* RangeBoundaryPoint::container() const
@@ -116,6 +110,7 @@ inline void RangeBoundaryPoint::clear()
inline void RangeBoundaryPoint::set(PassRefPtr<Node> container, int offset, Node* childBefore)
{
+ ASSERT(container);
ASSERT(offset >= 0);
ASSERT(childBefore == (offset ? container->childNode(offset - 1) : 0));
m_containerNode = container;
diff --git a/src/3rdparty/webkit/WebCore/dom/ScriptElement.cpp b/src/3rdparty/webkit/WebCore/dom/ScriptElement.cpp
index 55b15e5..fe38b46 100644
--- a/src/3rdparty/webkit/WebCore/dom/ScriptElement.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/ScriptElement.cpp
@@ -201,13 +201,14 @@ void ScriptElementData::execute(CachedScript* cachedScript)
evaluateScript(ScriptSourceCode(cachedScript));
m_scriptElement->dispatchLoadEvent();
}
+ cachedScript->removeClient(this);
}
void ScriptElementData::notifyFinished(CachedResource* o)
{
ASSERT_UNUSED(o, o == m_cachedScript);
m_element->document()->executeScriptSoon(this, m_cachedScript);
- stopLoadRequest();
+ m_cachedScript = 0;
}
bool ScriptElementData::ignoresLoadRequest() const
diff --git a/src/3rdparty/webkit/WebCore/dom/ScriptExecutionContext.cpp b/src/3rdparty/webkit/WebCore/dom/ScriptExecutionContext.cpp
index c518734..45d4e23 100644
--- a/src/3rdparty/webkit/WebCore/dom/ScriptExecutionContext.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/ScriptExecutionContext.cpp
@@ -88,7 +88,7 @@ void ScriptExecutionContext::dispatchMessagePortEvents()
MessagePort* port = ports[i];
// The port may be destroyed, and another one created at the same address, but this is safe, as the worst that can happen
// as a result is that dispatchMessages() will be called needlessly.
- if (m_messagePorts.contains(port) && port->queueIsOpen())
+ if (m_messagePorts.contains(port) && port->started())
port->dispatchMessages();
}
}
diff --git a/src/3rdparty/webkit/WebCore/dom/SelectElement.cpp b/src/3rdparty/webkit/WebCore/dom/SelectElement.cpp
index ff8f1c3..1831f3a 100644
--- a/src/3rdparty/webkit/WebCore/dom/SelectElement.cpp
+++ b/src/3rdparty/webkit/WebCore/dom/SelectElement.cpp
@@ -198,8 +198,9 @@ void SelectElement::menuListOnChange(SelectElementData& data, Element* element)
ASSERT(data.usesMenuList());
int selected = selectedIndex(data, element);
- if (data.lastOnChangeIndex() != selected) {
+ if (data.lastOnChangeIndex() != selected && data.userDrivenChange()) {
data.setLastOnChangeIndex(selected);
+ data.setUserDrivenChange(false);
element->dispatchFormControlChangeEvent();
}
}
@@ -309,7 +310,7 @@ int SelectElement::selectedIndex(const SelectElementData& data, const Element* e
return -1;
}
-void SelectElement::setSelectedIndex(SelectElementData& data, Element* element, int optionIndex, bool deselect, bool fireOnChange)
+void SelectElement::setSelectedIndex(SelectElementData& data, Element* element, int optionIndex, bool deselect, bool fireOnChangeNow, bool userDrivenChange)
{
const Vector<Element*>& items = data.listItems(element);
int listIndex = optionToListIndex(data, element, optionIndex);
@@ -335,9 +336,12 @@ void SelectElement::setSelectedIndex(SelectElementData& data, Element* element,
scrollToSelection(data, element);
- // This only gets called with fireOnChange for menu lists.
- if (fireOnChange && data.usesMenuList())
- menuListOnChange(data, element);
+ // This only gets called with fireOnChangeNow for menu lists.
+ if (data.usesMenuList()) {
+ data.setUserDrivenChange(userDrivenChange);
+ if (fireOnChangeNow)
+ menuListOnChange(data, element);
+ }
if (Frame* frame = element->document()->frame())
frame->page()->chrome()->client()->formStateDidChange(element);
diff --git a/src/3rdparty/webkit/WebCore/dom/SelectElement.h b/src/3rdparty/webkit/WebCore/dom/SelectElement.h
index bad9b79..29187ae 100644
--- a/src/3rdparty/webkit/WebCore/dom/SelectElement.h
+++ b/src/3rdparty/webkit/WebCore/dom/SelectElement.h
@@ -57,7 +57,8 @@ public:
virtual int optionToListIndex(int optionIndex) const = 0;
virtual int selectedIndex() const = 0;
- virtual void setSelectedIndex(int index, bool deselect = true, bool fireOnChange = false) = 0;
+ virtual void setSelectedIndex(int index, bool deselect = true) = 0;
+ virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false) = 0;
protected:
virtual ~SelectElement() { }
@@ -78,7 +79,7 @@ protected:
static void setRecalcListItems(SelectElementData&, Element*);
static void recalcListItems(SelectElementData&, const Element*, bool updateSelectedStates = true);
static int selectedIndex(const SelectElementData&, const Element*);
- static void setSelectedIndex(SelectElementData&, Element*, int optionIndex, bool deselect = true, bool fireOnChange = false);
+ static void setSelectedIndex(SelectElementData&, Element*, int optionIndex, bool deselect = true, bool fireOnChangeNow = false, bool userDrivenChange = true);
static int optionToListIndex(const SelectElementData&, const Element*, int optionIndex);
static int listToOptionIndex(const SelectElementData&, const Element*, int listIndex);
static void dispatchFocusEvent(SelectElementData&, Element*);
@@ -117,6 +118,9 @@ public:
int lastOnChangeIndex() const { return m_lastOnChangeIndex; }
void setLastOnChangeIndex(int value) { m_lastOnChangeIndex = value; }
+ bool userDrivenChange() const { return m_userDrivenChange; }
+ void setUserDrivenChange(bool value) { m_userDrivenChange = value; }
+
Vector<bool>& lastOnChangeSelection() { return m_lastOnChangeSelection; }
bool activeSelectionState() const { return m_activeSelectionState; }
@@ -154,6 +158,7 @@ private:
int m_lastOnChangeIndex;
Vector<bool> m_lastOnChangeSelection;
+ bool m_userDrivenChange;
bool m_activeSelectionState;
int m_activeSelectionAnchorIndex;
diff --git a/src/3rdparty/webkit/WebCore/dom/Tokenizer.h b/src/3rdparty/webkit/WebCore/dom/Tokenizer.h
index f9c6dc4..ea303f9 100644
--- a/src/3rdparty/webkit/WebCore/dom/Tokenizer.h
+++ b/src/3rdparty/webkit/WebCore/dom/Tokenizer.h
@@ -28,6 +28,7 @@
namespace WebCore {
class SegmentedString;
+ class XSSAuditor;
class Tokenizer {
public:
@@ -58,11 +59,15 @@ namespace WebCore {
virtual void executeScriptsWaitingForStylesheets() {}
virtual bool isHTMLTokenizer() const { return false; }
+
+ XSSAuditor* xssAuditor() const { return m_XSSAuditor; }
+ void setXSSAuditor(XSSAuditor* auditor) { m_XSSAuditor = auditor; }
protected:
Tokenizer(bool viewSourceMode = false)
: m_parserStopped(false)
, m_inViewSourceMode(viewSourceMode)
+ , m_XSSAuditor(0)
{
}
@@ -71,6 +76,9 @@ namespace WebCore {
// even when it has buffered data.
bool m_parserStopped;
bool m_inViewSourceMode;
+
+ // The XSSAuditor associated with this tokenizer.
+ XSSAuditor* m_XSSAuditor;
};
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.cpp b/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.cpp
new file mode 100644
index 0000000..80ab7c8
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.cpp
@@ -0,0 +1,222 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "PlatformMessagePortChannel.h"
+
+#include "MessagePort.h"
+#include "ScriptExecutionContext.h"
+
+namespace WebCore {
+
+// MessagePortChannel implementations - just delegate to the PlatformMessagePortChannel.
+bool MessagePortChannel::entangleIfOpen(MessagePort* port)
+{
+ return m_channel->entangleIfOpen(port);
+}
+
+void MessagePortChannel::disentangle()
+{
+ m_channel->disentangle();
+}
+
+void MessagePortChannel::postMessageToRemote(PassOwnPtr<MessagePortChannel::EventData> message)
+{
+ m_channel->postMessageToRemote(message);
+}
+
+bool MessagePortChannel::tryGetMessageFromRemote(OwnPtr<MessagePortChannel::EventData>& result)
+{
+ return m_channel->tryGetMessageFromRemote(result);
+}
+
+void MessagePortChannel::close()
+{
+ m_channel->close();
+}
+
+bool MessagePortChannel::isConnectedTo(MessagePort* port)
+{
+ return m_channel->isConnectedTo(port);
+}
+
+bool MessagePortChannel::hasPendingActivity()
+{
+ return m_channel->hasPendingActivity();
+}
+
+MessagePort* MessagePortChannel::locallyEntangledPort(const ScriptExecutionContext* context)
+{
+ return m_channel->locallyEntangledPort(context);
+}
+
+PassRefPtr<PlatformMessagePortChannel> PlatformMessagePortChannel::create(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing)
+{
+ return adoptRef(new PlatformMessagePortChannel(incoming, outgoing));
+}
+
+PlatformMessagePortChannel::PlatformMessagePortChannel(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing)
+ : m_entangledChannel(0)
+ , m_incomingQueue(incoming)
+ , m_outgoingQueue(outgoing)
+ , m_remotePort(0)
+{
+}
+
+PlatformMessagePortChannel::~PlatformMessagePortChannel()
+{
+}
+
+void PlatformMessagePortChannel::createChannel(PassRefPtr<MessagePort> port1, PassRefPtr<MessagePort> port2)
+{
+ // Create incoming/outgoing queues.
+ RefPtr<PlatformMessagePortChannel::MessagePortQueue> queue1 = PlatformMessagePortChannel::MessagePortQueue::create();
+ RefPtr<PlatformMessagePortChannel::MessagePortQueue> queue2 = PlatformMessagePortChannel::MessagePortQueue::create();
+
+ // Create proxies for each endpoint.
+ RefPtr<PlatformMessagePortChannel> channel1 = PlatformMessagePortChannel::create(queue1, queue2);
+ RefPtr<PlatformMessagePortChannel> channel2 = PlatformMessagePortChannel::create(queue2, queue1);
+
+ // Entangle the two endpoints.
+ channel1->setEntangledChannel(channel2);
+ channel2->setEntangledChannel(channel1);
+
+ // Now entangle the proxies with the appropriate local ports.
+ port1->entangle(MessagePortChannel::create(channel2));
+ port2->entangle(MessagePortChannel::create(channel1));
+}
+
+bool PlatformMessagePortChannel::entangleIfOpen(MessagePort* port)
+{
+ // We can't call member functions on our remote pair while holding our mutex or we'll deadlock, but we need to guard against the remote port getting closed/freed, so create a standalone reference.
+ RefPtr<PlatformMessagePortChannel> remote = entangledChannel();
+ if (!remote)
+ return false;
+ remote->setRemotePort(port);
+ return true;
+}
+
+void PlatformMessagePortChannel::disentangle()
+{
+ RefPtr<PlatformMessagePortChannel> remote = entangledChannel();
+ if (remote)
+ remote->setRemotePort(0);
+}
+
+void PlatformMessagePortChannel::setRemotePort(MessagePort* port)
+{
+ MutexLocker lock(m_mutex);
+ // Should never set port if it is already set.
+ ASSERT(!port || !m_remotePort);
+ m_remotePort = port;
+}
+
+MessagePort* PlatformMessagePortChannel::remotePort()
+{
+ MutexLocker lock(m_mutex);
+ return m_remotePort;
+}
+
+PassRefPtr<PlatformMessagePortChannel> PlatformMessagePortChannel::entangledChannel()
+{
+ MutexLocker lock(m_mutex);
+ return m_entangledChannel;
+}
+
+void PlatformMessagePortChannel::setEntangledChannel(PassRefPtr<PlatformMessagePortChannel> remote)
+{
+ MutexLocker lock(m_mutex);
+ // Should only be set as part of initial creation/entanglement.
+ if (remote)
+ ASSERT(!m_entangledChannel.get());
+ m_entangledChannel = remote;
+}
+
+void PlatformMessagePortChannel::postMessageToRemote(PassOwnPtr<MessagePortChannel::EventData> message)
+{
+ MutexLocker lock(m_mutex);
+ if (!m_outgoingQueue)
+ return;
+ bool wasEmpty = m_outgoingQueue->appendAndCheckEmpty(message);
+ if (wasEmpty && m_remotePort)
+ m_remotePort->messageAvailable();
+}
+
+bool PlatformMessagePortChannel::tryGetMessageFromRemote(OwnPtr<MessagePortChannel::EventData>& result)
+{
+ MutexLocker lock(m_mutex);
+ return m_incomingQueue->tryGetMessage(result);
+}
+
+bool PlatformMessagePortChannel::isConnectedTo(MessagePort* port)
+{
+ MutexLocker lock(m_mutex);
+ return m_remotePort == port;
+}
+
+// Closes the port so no further messages can be sent from either end.
+void PlatformMessagePortChannel::close()
+{
+ RefPtr<PlatformMessagePortChannel> remote = entangledChannel();
+ if (!remote)
+ return;
+ closeInternal();
+ remote->closeInternal();
+}
+
+void PlatformMessagePortChannel::closeInternal()
+{
+ MutexLocker lock(m_mutex);
+ // Disentangle ourselves from the other end. We still maintain a reference to our incoming queue, since previously-existing messages should still be delivered.
+ m_remotePort = 0;
+ m_entangledChannel = 0;
+ m_outgoingQueue = 0;
+}
+
+bool PlatformMessagePortChannel::hasPendingActivity()
+{
+ MutexLocker lock(m_mutex);
+ return !m_incomingQueue->isEmpty();
+}
+
+MessagePort* PlatformMessagePortChannel::locallyEntangledPort(const ScriptExecutionContext* context)
+{
+ MutexLocker lock(m_mutex);
+ // See if both contexts are run by the same thread (are the same context, or are both documents).
+ if (m_remotePort) {
+ // The remote port's ScriptExecutionContext is guaranteed not to change here - MessagePort::contextDestroyed() will close the port before the context goes away, and close() will block because we are holding the mutex.
+ ScriptExecutionContext* remoteContext = m_remotePort->scriptExecutionContext();
+ if (remoteContext == context || (remoteContext && remoteContext->isDocument() && context->isDocument()))
+ return m_remotePort;
+ }
+ return 0;
+}
+
+} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.h b/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.h
new file mode 100644
index 0000000..0ce2d13
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/dom/default/PlatformMessagePortChannel.h
@@ -0,0 +1,129 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef PlatformMessagePortChannel_h
+#define PlatformMessagePortChannel_h
+
+#include "MessagePortChannel.h"
+
+#include <wtf/MessageQueue.h>
+#include <wtf/PassRefPtr.h>
+#include <wtf/Threading.h>
+
+namespace WebCore {
+
+ class MessagePort;
+
+ // PlatformMessagePortChannel is a platform-dependent interface to the remote side of a message channel.
+ // This default implementation supports multiple threads running within a single process. Implementations for multi-process platforms should define these public APIs in their own platform-specific PlatformMessagePortChannel file.
+ // The goal of this implementation is to eliminate contention except when cloning or closing the port, so each side of the channel has its own separate mutex.
+ class PlatformMessagePortChannel : public ThreadSafeShared<PlatformMessagePortChannel> {
+ public:
+ static void createChannel(PassRefPtr<MessagePort>, PassRefPtr<MessagePort>);
+
+ // APIs delegated from MessagePortChannel.h
+ bool entangleIfOpen(MessagePort*);
+ void disentangle();
+ void postMessageToRemote(PassOwnPtr<MessagePortChannel::EventData>);
+ bool tryGetMessageFromRemote(OwnPtr<MessagePortChannel::EventData>&);
+ void close();
+ bool isConnectedTo(MessagePort*);
+ bool hasPendingActivity();
+ MessagePort* locallyEntangledPort(const ScriptExecutionContext*);
+
+ // Wrapper for MessageQueue that allows us to do thread safe sharing by two proxies.
+ class MessagePortQueue : public ThreadSafeShared<MessagePortQueue> {
+ public:
+ static PassRefPtr<MessagePortQueue> create() { return adoptRef(new MessagePortQueue()); }
+
+ bool tryGetMessage(OwnPtr<MessagePortChannel::EventData>& message)
+ {
+ MessagePortChannel::EventData* holder = 0;
+ bool messageAvailable = m_queue.tryGetMessage(holder);
+ if (messageAvailable)
+ message.set(holder);
+ return messageAvailable;
+ }
+
+ bool appendAndCheckEmpty(PassOwnPtr<MessagePortChannel::EventData> message)
+ {
+ return m_queue.appendAndCheckEmpty(message.release());
+ }
+
+ bool isEmpty()
+ {
+ return m_queue.isEmpty();
+ }
+
+ ~MessagePortQueue()
+ {
+ // Manually free any items left in the queue, since we can't use OwnPtr internally.
+ MessagePortChannel::EventData* data = 0;
+ while (m_queue.tryGetMessage(data))
+ delete data;
+ }
+ private:
+ MessagePortQueue() { }
+
+ // OwnPtr is Noncopyable, so we can't use it as the template type in a MessageQueue. So we just store a pointer to EventData and manually free it in the destructor.
+ // FIXME: Use a lock-free queue implementation to completely eliminate contention when sending/receiving messages.
+ MessageQueue<MessagePortChannel::EventData*> m_queue;
+ };
+
+ ~PlatformMessagePortChannel();
+
+ private:
+ static PassRefPtr<PlatformMessagePortChannel> create(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing);
+ PlatformMessagePortChannel(PassRefPtr<MessagePortQueue> incoming, PassRefPtr<MessagePortQueue> outgoing);
+
+ PassRefPtr<PlatformMessagePortChannel> entangledChannel();
+ void setEntangledChannel(PassRefPtr<PlatformMessagePortChannel>);
+
+ void setRemotePort(MessagePort*);
+ MessagePort* remotePort();
+ void closeInternal();
+
+ // Mutex used to ensure exclusive access to the object internals.
+ Mutex m_mutex;
+
+ // Pointer to our entangled pair - cleared when close() is called.
+ RefPtr<PlatformMessagePortChannel> m_entangledChannel;
+
+ // Reference to the message queue for the (local) entangled port.
+ RefPtr<MessagePortQueue> m_incomingQueue;
+ RefPtr<MessagePortQueue> m_outgoingQueue;
+
+ // The port we are connected to (the remote port) - this is the port that is notified when new messages arrive.
+ MessagePort* m_remotePort;
+ };
+
+} // namespace WebCore
+
+#endif // PlatformMessagePortChannel_h
diff --git a/src/3rdparty/webkit/WebCore/editing/BreakBlockquoteCommand.cpp b/src/3rdparty/webkit/WebCore/editing/BreakBlockquoteCommand.cpp
index e3d66ba..4f3949d 100644
--- a/src/3rdparty/webkit/WebCore/editing/BreakBlockquoteCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/BreakBlockquoteCommand.cpp
@@ -67,9 +67,11 @@ void BreakBlockquoteCommand::doApply()
RefPtr<Element> breakNode = createBreakElement(document());
+ bool isLastVisPosInNode = isLastVisiblePositionInNode(visiblePos, topBlockquote);
+
// If the position is at the beginning of the top quoted content, we don't need to break the quote.
- // Instead, insert the break before the blockquote.
- if (isFirstVisiblePositionInNode(visiblePos, topBlockquote)) {
+ // Instead, insert the break before the blockquote, unless the position is as the end of the the quoted content.
+ if (isFirstVisiblePositionInNode(visiblePos, topBlockquote) && !isLastVisPosInNode) {
insertNodeBefore(breakNode.get(), topBlockquote);
setEndingSelection(VisibleSelection(Position(breakNode.get(), 0), DOWNSTREAM));
rebalanceWhitespace();
@@ -78,9 +80,9 @@ void BreakBlockquoteCommand::doApply()
// Insert a break after the top blockquote.
insertNodeAfter(breakNode.get(), topBlockquote);
-
+
// If we're inserting the break at the end of the quoted content, we don't need to break the quote.
- if (isLastVisiblePositionInNode(visiblePos, topBlockquote)) {
+ if (isLastVisPosInNode) {
setEndingSelection(VisibleSelection(Position(breakNode.get(), 0), DOWNSTREAM));
rebalanceWhitespace();
return;
diff --git a/src/3rdparty/webkit/WebCore/editing/CompositeEditCommand.cpp b/src/3rdparty/webkit/WebCore/editing/CompositeEditCommand.cpp
index 89a0f8a..8e4f950 100644
--- a/src/3rdparty/webkit/WebCore/editing/CompositeEditCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/CompositeEditCommand.cpp
@@ -988,6 +988,10 @@ Position CompositeEditCommand::positionAvoidingSpecialElementBoundary(const Posi
VisiblePosition visiblePos(original);
Node* enclosingAnchor = enclosingAnchorElement(original);
Position result = original;
+
+ if (!enclosingAnchor)
+ return result;
+
// Don't avoid block level anchors, because that would insert content into the wrong paragraph.
if (enclosingAnchor && !isBlock(enclosingAnchor)) {
VisiblePosition firstInAnchor(firstDeepEditingPositionForNode(enclosingAnchor));
@@ -1020,6 +1024,9 @@ Position CompositeEditCommand::positionAvoidingSpecialElementBoundary(const Posi
pushAnchorElementDown(enclosingAnchor);
enclosingAnchor = enclosingAnchorElement(original);
}
+ if (!enclosingAnchor)
+ return original;
+
result = positionBeforeNode(enclosingAnchor);
}
}
diff --git a/src/3rdparty/webkit/WebCore/editing/Editor.cpp b/src/3rdparty/webkit/WebCore/editing/Editor.cpp
index 2c303f9..2ad5cce 100644
--- a/src/3rdparty/webkit/WebCore/editing/Editor.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/Editor.cpp
@@ -340,9 +340,10 @@ bool Editor::tryDHTMLCopy()
if (m_frame->selection()->isInPasswordField())
return false;
- // Must be done before oncopy adds types and data to the pboard,
- // also done for security, as it erases data from the last copy/paste.
- Pasteboard::generalPasteboard()->clear();
+ if (canCopy())
+ // Must be done before oncopy adds types and data to the pboard,
+ // also done for security, as it erases data from the last copy/paste.
+ Pasteboard::generalPasteboard()->clear();
return !dispatchCPPEvent(eventNames().copyEvent, ClipboardWritable);
}
@@ -351,10 +352,11 @@ bool Editor::tryDHTMLCut()
{
if (m_frame->selection()->isInPasswordField())
return false;
-
- // Must be done before oncut adds types and data to the pboard,
- // also done for security, as it erases data from the last copy/paste.
- Pasteboard::generalPasteboard()->clear();
+
+ if (canCut())
+ // Must be done before oncut adds types and data to the pboard,
+ // also done for security, as it erases data from the last copy/paste.
+ Pasteboard::generalPasteboard()->clear();
return !dispatchCPPEvent(eventNames().cutEvent, ClipboardWritable);
}
@@ -2204,7 +2206,7 @@ void Editor::markMisspellingsAfterTypingToPosition(const VisiblePosition &p)
if (!frame()->editor()->shouldInsertText(autocorrectedString, misspellingRange.get(), EditorInsertActionTyped))
return;
- frame()->editor()->replaceSelectionWithText(autocorrectedString, false, true);
+ frame()->editor()->replaceSelectionWithText(autocorrectedString, false, false);
// Reset the charet one character further.
frame()->selection()->moveTo(frame()->selection()->end());
diff --git a/src/3rdparty/webkit/WebCore/editing/EditorCommand.cpp b/src/3rdparty/webkit/WebCore/editing/EditorCommand.cpp
index 5a189d4..ab62c09 100644
--- a/src/3rdparty/webkit/WebCore/editing/EditorCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/EditorCommand.cpp
@@ -1247,10 +1247,9 @@ static String valueForeColor(Frame* frame, Event*)
// Map of functions
+struct CommandEntry { const char* name; EditorInternalCommand command; };
static const CommandMap& createCommandMap()
{
- struct CommandEntry { const char* name; EditorInternalCommand command; };
-
static const CommandEntry commands[] = {
{ "AlignCenter", { executeJustifyCenter, supportedFromMenuOrKeyBinding, enabledInRichlyEditableText, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
{ "AlignJustified", { executeJustifyFull, supportedFromMenuOrKeyBinding, enabledInRichlyEditableText, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
diff --git a/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.cpp b/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.cpp
index 0f9b106..3922367 100644
--- a/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.cpp
@@ -78,7 +78,7 @@ IndentOutdentCommand::IndentOutdentCommand(Document* document, EIndentType typeO
// This function is a workaround for moveParagraph's tendency to strip blockquotes. It updates lastBlockquote to point to the
// correct level for the current paragraph, and returns a pointer to a placeholder br where the insertion should be performed.
-PassRefPtr<Element> IndentOutdentCommand::prepareBlockquoteLevelForInsertion(VisiblePosition& currentParagraph, RefPtr<Element>& lastBlockquote)
+PassRefPtr<Element> IndentOutdentCommand::prepareBlockquoteLevelForInsertion(const VisiblePosition& currentParagraph, RefPtr<Element>& lastBlockquote)
{
int currentBlockquoteLevel = 0;
int lastBlockquoteLevel = 0;
@@ -107,6 +107,62 @@ PassRefPtr<Element> IndentOutdentCommand::prepareBlockquoteLevelForInsertion(Vis
return placeholder.release();
}
+bool IndentOutdentCommand::tryIndentingAsListItem(const VisiblePosition& endOfCurrentParagraph)
+{
+ // If our selection is not inside a list, bail out.
+ Node* lastNodeInSelectedParagraph = endOfCurrentParagraph.deepEquivalent().node();
+ RefPtr<Element> listNode = enclosingList(lastNodeInSelectedParagraph);
+ if (!listNode)
+ return false;
+
+ HTMLElement* selectedListItem = enclosingListChild(lastNodeInSelectedParagraph);
+
+ // FIXME: previousElementSibling does not ignore non-rendered content like <span></span>. Should we?
+ Element* previousList = selectedListItem->previousElementSibling();
+ Element* nextList = selectedListItem->nextElementSibling();
+
+ RefPtr<Element> newList = document()->createElement(listNode->tagQName(), false);
+ RefPtr<Element> newListItem = selectedListItem->cloneElementWithoutChildren();
+ RefPtr<Element> placeholder = createBreakElement(document());
+ insertNodeBefore(newList, selectedListItem);
+ appendNode(newListItem, newList);
+ appendNode(placeholder, newListItem);
+
+ moveParagraph(startOfParagraph(endOfCurrentParagraph), endOfCurrentParagraph, VisiblePosition(Position(placeholder, 0)), true);
+
+ if (canMergeLists(previousList, newList.get()))
+ mergeIdenticalElements(previousList, newList);
+ if (canMergeLists(newList.get(), nextList))
+ mergeIdenticalElements(newList, nextList);
+
+ return true;
+}
+
+void IndentOutdentCommand::indentIntoBlockquote(const VisiblePosition& endOfCurrentParagraph, const VisiblePosition& endOfNextParagraph, RefPtr<Element>& targetBlockquote)
+{
+ Node* enclosingCell = 0;
+
+ if (!targetBlockquote) {
+ // Create a new blockquote and insert it as a child of the root editable element. We accomplish
+ // this by splitting all parents of the current paragraph up to that point.
+ targetBlockquote = createIndentBlockquoteElement(document());
+ Position start = startOfParagraph(endOfCurrentParagraph).deepEquivalent();
+ enclosingCell = enclosingNodeOfType(start, &isTableCell);
+ Node* nodeToSplitTo = enclosingCell ? enclosingCell : editableRootForPosition(start);
+ RefPtr<Node> startOfNewBlock = splitTreeToNode(start.node(), nodeToSplitTo);
+ insertNodeBefore(targetBlockquote, startOfNewBlock);
+ }
+
+ RefPtr<Element> insertionPoint = prepareBlockquoteLevelForInsertion(endOfCurrentParagraph, targetBlockquote);
+
+ // Don't put the next paragraph in the blockquote we just created for this paragraph unless
+ // the next paragraph is in the same cell.
+ if (enclosingCell && enclosingCell != enclosingNodeOfType(endOfNextParagraph.deepEquivalent(), &isTableCell))
+ targetBlockquote = 0;
+
+ moveParagraph(startOfParagraph(endOfCurrentParagraph), endOfCurrentParagraph, VisiblePosition(Position(insertionPoint, 0)), true);
+}
+
void IndentOutdentCommand::indentRegion()
{
VisibleSelection selection = selectionForParagraphIteration(endingSelection());
@@ -117,7 +173,7 @@ void IndentOutdentCommand::indentRegion()
ASSERT(!startOfSelection.isNull());
ASSERT(!endOfSelection.isNull());
-
+
// Special case empty root editable elements because there's nothing to split
// and there's nothing to move.
Position start = startOfSelection.deepEquivalent().downstream();
@@ -129,58 +185,21 @@ void IndentOutdentCommand::indentRegion()
setEndingSelection(VisibleSelection(Position(placeholder.get(), 0), DOWNSTREAM));
return;
}
-
- RefPtr<Element> previousListNode;
- RefPtr<Element> newListNode;
- RefPtr<Element> newBlockquote;
+
+ RefPtr<Element> blockquoteForNextIndent;
VisiblePosition endOfCurrentParagraph = endOfParagraph(startOfSelection);
VisiblePosition endAfterSelection = endOfParagraph(endOfParagraph(endOfSelection).next());
while (endOfCurrentParagraph != endAfterSelection) {
// Iterate across the selected paragraphs...
VisiblePosition endOfNextParagraph = endOfParagraph(endOfCurrentParagraph.next());
- RefPtr<Element> listNode = enclosingList(endOfCurrentParagraph.deepEquivalent().node());
- RefPtr<Element> insertionPoint;
- if (listNode) {
- RefPtr<Element> placeholder = createBreakElement(document());
- insertionPoint = placeholder;
- newBlockquote = 0;
- RefPtr<Element> listItem = createListItemElement(document());
- if (listNode == previousListNode) {
- // The previous paragraph was inside the same list, so add this list item to the list we already created
- appendNode(listItem, newListNode);
- appendNode(placeholder, listItem);
- } else {
- // Clone the list element, insert it before the current paragraph, and move the paragraph into it.
- RefPtr<Element> clonedList = listNode->cloneElementWithoutChildren();
- insertNodeBefore(clonedList, enclosingListChild(endOfCurrentParagraph.deepEquivalent().node()));
- appendNode(listItem, clonedList);
- appendNode(placeholder, listItem);
- newListNode = clonedList;
- previousListNode = listNode;
- }
- } else if (newBlockquote)
- // The previous paragraph was put into a new blockquote, so move this paragraph there as well
- insertionPoint = prepareBlockquoteLevelForInsertion(endOfCurrentParagraph, newBlockquote);
- else {
- // Create a new blockquote and insert it as a child of the root editable element. We accomplish
- // this by splitting all parents of the current paragraph up to that point.
- RefPtr<Element> blockquote = createIndentBlockquoteElement(document());
- Position start = startOfParagraph(endOfCurrentParagraph).deepEquivalent();
-
- Node* enclosingCell = enclosingNodeOfType(start, &isTableCell);
- Node* nodeToSplitTo = enclosingCell ? enclosingCell : editableRootForPosition(start);
- RefPtr<Node> startOfNewBlock = splitTreeToNode(start.node(), nodeToSplitTo);
- insertNodeBefore(blockquote, startOfNewBlock);
- newBlockquote = blockquote;
- insertionPoint = prepareBlockquoteLevelForInsertion(endOfCurrentParagraph, newBlockquote);
- // Don't put the next paragraph in the blockquote we just created for this paragraph unless
- // the next paragraph is in the same cell.
- if (enclosingCell && enclosingCell != enclosingNodeOfType(endOfNextParagraph.deepEquivalent(), &isTableCell))
- newBlockquote = 0;
- }
- moveParagraph(startOfParagraph(endOfCurrentParagraph), endOfCurrentParagraph, VisiblePosition(Position(insertionPoint, 0)), true);
- // moveParagraph should not destroy content that contains endOfNextParagraph, but if it does, return here
- // to avoid a crash.
+ if (tryIndentingAsListItem(endOfCurrentParagraph))
+ blockquoteForNextIndent = 0;
+ else
+ indentIntoBlockquote(endOfCurrentParagraph, endOfNextParagraph, blockquoteForNextIndent);
+ // blockquoteForNextIndent maybe updated
+ // this is due to the way prepareBlockquoteLevelForInsertion was designed.
+ // Sanity check: Make sure our moveParagraph calls didn't remove endOfNextParagraph.deepEquivalent().node()
+ // If somehow we did, return to prevent crashes.
if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.deepEquivalent().node()->inDocument()) {
ASSERT_NOT_REACHED();
return;
diff --git a/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.h b/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.h
index bb1a1d2..419f832f 100644
--- a/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.h
+++ b/src/3rdparty/webkit/WebCore/editing/IndentOutdentCommand.h
@@ -49,7 +49,9 @@ private:
void indentRegion();
void outdentRegion();
void outdentParagraph();
- PassRefPtr<Element> prepareBlockquoteLevelForInsertion(VisiblePosition&, RefPtr<Element>&);
+ PassRefPtr<Element> prepareBlockquoteLevelForInsertion(const VisiblePosition&, RefPtr<Element>&);
+ bool tryIndentingAsListItem(const VisiblePosition&);
+ void indentIntoBlockquote(const VisiblePosition&, const VisiblePosition&, RefPtr<Element>&);
EIndentType m_typeOfAction;
int m_marginInPixels;
diff --git a/src/3rdparty/webkit/WebCore/editing/InsertParagraphSeparatorCommand.cpp b/src/3rdparty/webkit/WebCore/editing/InsertParagraphSeparatorCommand.cpp
index 734d8fc..7d6e5c4 100644
--- a/src/3rdparty/webkit/WebCore/editing/InsertParagraphSeparatorCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/InsertParagraphSeparatorCommand.cpp
@@ -170,6 +170,7 @@ void InsertParagraphSeparatorCommand::doApply()
// Handle case when position is in the last visible position in its block,
// including when the block is empty.
if (isLastInBlock) {
+ bool shouldApplyStyleAfterInsertion = true;
if (nestNewBlock) {
if (isFirstInBlock && !lineBreakExistsAtVisiblePosition(visiblePos)) {
// The block is empty. Create an empty block to
@@ -182,13 +183,18 @@ void InsertParagraphSeparatorCommand::doApply()
} else {
// We can get here if we pasted a copied portion of a blockquote with a newline at the end and are trying to paste it
// into an unquoted area. We then don't want the newline within the blockquote or else it will also be quoted.
- Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote);
- insertNodeAfter(blockToInsert, highestBlockquote ? highestBlockquote : startBlock);
+ if (Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote)) {
+ startBlock = static_cast<Element*>(highestBlockquote);
+ // When inserting the newline after the blockquote, we don't want to apply the original style after the insertion
+ shouldApplyStyleAfterInsertion = false;
+ }
+ insertNodeAfter(blockToInsert, startBlock);
}
appendBlockPlaceholder(blockToInsert);
setEndingSelection(VisibleSelection(Position(blockToInsert.get(), 0), DOWNSTREAM));
- applyStyleAfterInsertion(startBlock);
+ if (shouldApplyStyleAfterInsertion)
+ applyStyleAfterInsertion(startBlock);
return;
}
diff --git a/src/3rdparty/webkit/WebCore/editing/InsertTextCommand.cpp b/src/3rdparty/webkit/WebCore/editing/InsertTextCommand.cpp
index bf6fd19..6b0af9b 100644
--- a/src/3rdparty/webkit/WebCore/editing/InsertTextCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/InsertTextCommand.cpp
@@ -106,22 +106,14 @@ bool InsertTextCommand::performTrivialReplace(const String& text, bool selectIns
return true;
}
-void InsertTextCommand::input(const String& originalText, bool selectInsertedText)
+void InsertTextCommand::input(const String& text, bool selectInsertedText)
{
- String text = originalText;
ASSERT(text.find('\n') == -1);
if (endingSelection().isNone())
return;
-
- if (RenderObject* renderer = endingSelection().start().node()->renderer())
- if (renderer->style()->collapseWhiteSpace())
- // Turn all spaces into non breaking spaces, to make sure that they are treated
- // literally, and aren't collapsed after insertion. They will be rebalanced
- // (turned into a sequence of regular and non breaking spaces) below.
- text.replace(' ', noBreakSpace);
-
+
// Delete the current selection.
// FIXME: This delete operation blows away the typing style.
if (endingSelection().isRange()) {
@@ -129,7 +121,7 @@ void InsertTextCommand::input(const String& originalText, bool selectInsertedTex
return;
deleteSelection(false, true, true, false);
}
-
+
Position startPosition(endingSelection().start());
Position placeholder;
@@ -184,7 +176,7 @@ void InsertTextCommand::input(const String& originalText, bool selectInsertedTex
// The insertion may require adjusting adjacent whitespace, if it is present.
rebalanceWhitespaceAt(endPosition);
// Rebalancing on both sides isn't necessary if we've inserted a space.
- if (originalText != " ")
+ if (text != " ")
rebalanceWhitespaceAt(startPosition);
m_charactersAdded += text.length();
diff --git a/src/3rdparty/webkit/WebCore/editing/SelectionController.cpp b/src/3rdparty/webkit/WebCore/editing/SelectionController.cpp
index d0427c0..9bb68ad 100644
--- a/src/3rdparty/webkit/WebCore/editing/SelectionController.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/SelectionController.cpp
@@ -1267,7 +1267,7 @@ void SelectionController::focusedOrActiveStateChanged()
node->setNeedsStyleRecalc();
if (RenderObject* renderer = node->renderer())
if (renderer && renderer->style()->hasAppearance())
- theme()->stateChanged(renderer, FocusState);
+ renderer->theme()->stateChanged(renderer, FocusState);
}
// Secure keyboard entry is set by the active frame.
diff --git a/src/3rdparty/webkit/WebCore/editing/TextIterator.cpp b/src/3rdparty/webkit/WebCore/editing/TextIterator.cpp
index b311853..aee34df 100644
--- a/src/3rdparty/webkit/WebCore/editing/TextIterator.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/TextIterator.cpp
@@ -97,6 +97,118 @@ private:
// --------
+static const unsigned bitsInWord = sizeof(unsigned) * 8;
+static const unsigned bitInWordMask = bitsInWord - 1;
+
+BitStack::BitStack()
+ : m_size(0)
+{
+}
+
+void BitStack::push(bool bit)
+{
+ unsigned index = m_size / bitsInWord;
+ unsigned shift = m_size & bitInWordMask;
+ if (!shift && index == m_words.size()) {
+ m_words.grow(index + 1);
+ m_words[index] = 0;
+ }
+ unsigned& word = m_words[index];
+ unsigned mask = 1U << shift;
+ if (bit)
+ word |= mask;
+ else
+ word &= ~mask;
+ ++m_size;
+}
+
+void BitStack::pop()
+{
+ if (m_size)
+ --m_size;
+}
+
+bool BitStack::top() const
+{
+ if (!m_size)
+ return false;
+ unsigned shift = (m_size - 1) & bitInWordMask;
+ return m_words.last() & (1U << shift);
+}
+
+unsigned BitStack::size() const
+{
+ return m_size;
+}
+
+// --------
+
+static inline Node* parentOrShadowParent(Node* node)
+{
+ if (Node* parent = node->parentNode())
+ return parent;
+ return node->shadowParentNode();
+}
+
+#ifndef NDEBUG
+
+static unsigned depthCrossingShadowBoundaries(Node* node)
+{
+ unsigned depth = 0;
+ for (Node* parent = parentOrShadowParent(node); parent; parent = parentOrShadowParent(parent))
+ ++depth;
+ return depth;
+}
+
+#endif
+
+static inline bool fullyClipsContents(Node* node)
+{
+ RenderObject* renderer = node->renderer();
+ if (!renderer || !renderer->isBox())
+ return false;
+ RenderStyle* style = renderer->style();
+ if (style->overflowX() == OVISIBLE && style->overflowY() == OVISIBLE)
+ return false;
+ return toRenderBox(renderer)->size().isEmpty();
+}
+
+static inline bool ignoresContainerClip(Node* node)
+{
+ RenderObject* renderer = node->renderer();
+ if (!renderer || renderer->isText())
+ return false;
+ EPosition position = renderer->style()->position();
+ return position == AbsolutePosition || position == FixedPosition;
+}
+
+static void pushFullyClippedState(BitStack& stack, Node* node)
+{
+ ASSERT(stack.size() == depthCrossingShadowBoundaries(node));
+
+ // Push true if this node full clips its contents, or if a parent already has fully
+ // clipped and this is not a node that ignores its container's clip.
+ stack.push(fullyClipsContents(node) || stack.top() && !ignoresContainerClip(node));
+}
+
+static void setUpFullyClippedStack(BitStack& stack, Node* node)
+{
+ // Put the nodes in a vector so we can iterate in reverse order.
+ Vector<Node*, 100> ancestry;
+ for (Node* parent = parentOrShadowParent(node); parent; parent = parentOrShadowParent(parent))
+ ancestry.append(parent);
+
+ // Call pushFullyClippedState on each node starting with the earliest ancestor.
+ size_t size = ancestry.size();
+ for (size_t i = 0; i < size; ++i)
+ pushFullyClippedState(stack, ancestry[size - i - 1]);
+ pushFullyClippedState(stack, node);
+
+ ASSERT(stack.size() == 1 + depthCrossingShadowBoundaries(node));
+}
+
+// --------
+
TextIterator::TextIterator()
: m_startContainer(0)
, m_startOffset(0)
@@ -112,8 +224,7 @@ TextIterator::TextIterator()
}
TextIterator::TextIterator(const Range* r, bool emitCharactersBetweenAllVisiblePositions, bool enterTextControls)
- : m_inShadowContent(false)
- , m_startContainer(0)
+ : m_startContainer(0)
, m_startOffset(0)
, m_endContainer(0)
, m_endOffset(0)
@@ -144,17 +255,11 @@ TextIterator::TextIterator(const Range* r, bool emitCharactersBetweenAllVisibleP
m_endContainer = endContainer;
m_endOffset = endOffset;
- for (Node* n = startContainer; n; n = n->parentNode()) {
- if (n->isShadowNode()) {
- m_inShadowContent = true;
- break;
- }
- }
-
// set up the current node for processing
m_node = r->firstNode();
- if (m_node == 0)
+ if (!m_node)
return;
+ setUpFullyClippedStack(m_fullyClippedStack, m_node);
m_offset = m_node == m_startContainer ? m_startOffset : 0;
m_handledNode = false;
m_handledChildren = false;
@@ -219,7 +324,7 @@ void TextIterator::advance()
return;
}
- RenderObject *renderer = m_node->renderer();
+ RenderObject* renderer = m_node->renderer();
if (!renderer) {
m_handledNode = true;
m_handledChildren = true;
@@ -241,27 +346,20 @@ void TextIterator::advance()
// find a new current node to handle in depth-first manner,
// calling exitNode() as we come back thru a parent node
- Node *next = m_handledChildren ? 0 : m_node->firstChild();
+ Node* next = m_handledChildren ? 0 : m_node->firstChild();
m_offset = 0;
if (!next) {
next = m_node->nextSibling();
if (!next) {
bool pastEnd = m_node->traverseNextNode() == m_pastEndNode;
- Node* parentNode = m_node->parentNode();
- if (!parentNode && m_inShadowContent) {
- m_inShadowContent = false;
- parentNode = m_node->shadowParentNode();
- }
+ Node* parentNode = parentOrShadowParent(m_node);
while (!next && parentNode) {
if ((pastEnd && parentNode == m_endContainer) || m_endContainer->isDescendantOf(parentNode))
return;
bool haveRenderer = m_node->renderer();
m_node = parentNode;
- parentNode = m_node->parentNode();
- if (!parentNode && m_inShadowContent) {
- m_inShadowContent = false;
- parentNode = m_node->shadowParentNode();
- }
+ m_fullyClippedStack.pop();
+ parentNode = parentOrShadowParent(m_node);
if (haveRenderer)
exitNode();
if (m_positionNode) {
@@ -272,10 +370,13 @@ void TextIterator::advance()
next = m_node->nextSibling();
}
}
+ m_fullyClippedStack.pop();
}
// set the new current node
m_node = next;
+ if (m_node)
+ pushFullyClippedState(m_fullyClippedStack, m_node);
m_handledNode = false;
m_handledChildren = false;
@@ -285,13 +386,16 @@ void TextIterator::advance()
}
}
-static inline bool compareBoxStart(const InlineTextBox *first, const InlineTextBox *second)
+static inline bool compareBoxStart(const InlineTextBox* first, const InlineTextBox* second)
{
return first->start() < second->start();
}
bool TextIterator::handleTextNode()
{
+ if (m_fullyClippedStack.top())
+ return false;
+
RenderText* renderer = toRenderText(m_node->renderer());
if (renderer->style()->visibility() != VISIBLE)
return false;
@@ -325,7 +429,7 @@ bool TextIterator::handleTextNode()
// Used when text boxes are out of order (Hebrew/Arabic w/ embeded LTR text)
if (renderer->containsReversedText()) {
m_sortedTextBoxes.clear();
- for (InlineTextBox * textBox = renderer->firstTextBox(); textBox; textBox = textBox->nextTextBox()) {
+ for (InlineTextBox* textBox = renderer->firstTextBox(); textBox; textBox = textBox->nextTextBox()) {
m_sortedTextBoxes.append(textBox);
}
std::sort(m_sortedTextBoxes.begin(), m_sortedTextBoxes.end(), compareBoxStart);
@@ -339,7 +443,7 @@ bool TextIterator::handleTextNode()
void TextIterator::handleTextBox()
{
- RenderText *renderer = toRenderText(m_node->renderer());
+ RenderText* renderer = toRenderText(m_node->renderer());
String str = renderer->text();
int start = m_offset;
int end = (m_node == m_endContainer) ? m_endOffset : INT_MAX;
@@ -348,7 +452,7 @@ void TextIterator::handleTextBox()
int runStart = max(textBoxStart, start);
// Check for collapsed space at the start of this run.
- InlineTextBox *firstTextBox = renderer->containsReversedText() ? m_sortedTextBoxes[0] : renderer->firstTextBox();
+ InlineTextBox* firstTextBox = renderer->containsReversedText() ? m_sortedTextBoxes[0] : renderer->firstTextBox();
bool needSpace = m_lastTextNodeEndedWithCollapsedSpace
|| (m_textBox == firstTextBox && textBoxStart == runStart && runStart > 0);
if (needSpace && !isCollapsibleWhitespace(m_lastCharacter) && m_lastCharacter) {
@@ -365,7 +469,7 @@ void TextIterator::handleTextBox()
int runEnd = min(textBoxEnd, end);
// Determine what the next text box will be, but don't advance yet
- InlineTextBox *nextTextBox = 0;
+ InlineTextBox* nextTextBox = 0;
if (renderer->containsReversedText()) {
if (m_sortedTextBoxesPosition + 1 < m_sortedTextBoxes.size())
nextTextBox = m_sortedTextBoxes[m_sortedTextBoxesPosition + 1];
@@ -411,6 +515,9 @@ void TextIterator::handleTextBox()
bool TextIterator::handleReplacedElement()
{
+ if (m_fullyClippedStack.top())
+ return false;
+
RenderObject* renderer = m_node->renderer();
if (renderer->style()->visibility() != VISIBLE)
return false;
@@ -421,10 +528,12 @@ bool TextIterator::handleReplacedElement()
}
if (m_enterTextControls && renderer->isTextControl()) {
- m_node = toRenderTextControl(renderer)->innerTextElement();
- m_offset = 0;
- m_inShadowContent = true;
- return false;
+ if (HTMLElement* innerTextElement = toRenderTextControl(renderer)->innerTextElement()) {
+ m_node = innerTextElement->shadowTreeRootNode();
+ pushFullyClippedState(m_fullyClippedStack, m_node);
+ m_offset = 0;
+ return false;
+ }
}
m_haveEmitted = true;
@@ -698,7 +807,7 @@ void TextIterator::exitNode()
emitCharacter(' ', baseNode->parentNode(), baseNode, 1, 1);
}
-void TextIterator::emitCharacter(UChar c, Node *textNode, Node *offsetBaseNode, int textStartOffset, int textEndOffset)
+void TextIterator::emitCharacter(UChar c, Node* textNode, Node* offsetBaseNode, int textStartOffset, int textEndOffset)
{
m_haveEmitted = true;
@@ -778,7 +887,7 @@ SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator() : m_positionN
{
}
-SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator(const Range *r)
+SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator(const Range* r)
{
m_positionNode = 0;
@@ -806,6 +915,7 @@ SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator(const Range *r)
}
m_node = endNode;
+ setUpFullyClippedStack(m_fullyClippedStack, m_node);
m_offset = endOffset;
m_handledNode = false;
m_handledChildren = endOffset == 0;
@@ -845,7 +955,7 @@ void SimplifiedBackwardsTextIterator::advance()
while (m_node && m_node != m_pastStartNode) {
// Don't handle node if we start iterating at [node, 0].
if (!m_handledNode && !(m_node == m_endNode && m_endOffset == 0)) {
- RenderObject *renderer = m_node->renderer();
+ RenderObject* renderer = m_node->renderer();
if (renderer && renderer->isText() && m_node->nodeType() == Node::TEXT_NODE) {
// FIXME: What about CDATA_SECTION_NODE?
if (renderer->style()->visibility() == VISIBLE && m_offset > 0)
@@ -877,9 +987,11 @@ void SimplifiedBackwardsTextIterator::advance()
// Exit all other containers.
next = m_node->previousSibling();
while (!next) {
- if (!m_node->parentNode())
+ Node* parentNode = parentOrShadowParent(m_node);
+ if (!parentNode)
break;
- m_node = m_node->parentNode();
+ m_node = parentNode;
+ m_fullyClippedStack.pop();
exitNode();
if (m_positionNode) {
m_handledNode = true;
@@ -888,9 +1000,12 @@ void SimplifiedBackwardsTextIterator::advance()
}
next = m_node->previousSibling();
}
+ m_fullyClippedStack.pop();
}
m_node = next;
+ if (m_node)
+ pushFullyClippedState(m_fullyClippedStack, m_node);
m_offset = m_node ? caretMaxOffset(m_node) : 0;
m_handledNode = false;
m_handledChildren = false;
@@ -904,7 +1019,7 @@ bool SimplifiedBackwardsTextIterator::handleTextNode()
{
m_lastTextNode = m_node;
- RenderText *renderer = toRenderText(m_node->renderer());
+ RenderText* renderer = toRenderText(m_node->renderer());
String str = renderer->text();
if (!renderer->firstTextBox() && str.length() > 0)
@@ -960,7 +1075,7 @@ void SimplifiedBackwardsTextIterator::exitNode()
emitCharacter('\n', m_node, 0, 0);
}
-void SimplifiedBackwardsTextIterator::emitCharacter(UChar c, Node *node, int startOffset, int endOffset)
+void SimplifiedBackwardsTextIterator::emitCharacter(UChar c, Node* node, int startOffset, int endOffset)
{
m_singleCharacterBuffer = c;
m_positionNode = node;
@@ -988,7 +1103,7 @@ CharacterIterator::CharacterIterator()
{
}
-CharacterIterator::CharacterIterator(const Range *r, bool emitCharactersBetweenAllVisiblePositions, bool enterTextControls)
+CharacterIterator::CharacterIterator(const Range* r, bool emitCharactersBetweenAllVisiblePositions, bool enterTextControls)
: m_offset(0)
, m_runOffset(0)
, m_atBreak(true)
@@ -1167,15 +1282,17 @@ void BackwardsCharacterIterator::advance(int count)
// --------
WordAwareIterator::WordAwareIterator()
-: m_previousText(0), m_didLookAhead(false)
+ : m_previousText(0)
+ , m_didLookAhead(false)
{
}
-WordAwareIterator::WordAwareIterator(const Range *r)
-: m_previousText(0), m_didLookAhead(false), m_textIterator(r)
+WordAwareIterator::WordAwareIterator(const Range* r)
+ : m_previousText(0)
+ , m_didLookAhead(true) // so we consider the first chunk from the text iterator
+ , m_textIterator(r)
{
- m_didLookAhead = true; // so we consider the first chunk from the text iterator
- advance(); // get in position over the first chunk of text
+ advance(); // get in position over the first chunk of text
}
// We're always in one of these modes:
@@ -1185,7 +1302,7 @@ WordAwareIterator::WordAwareIterator(const Range *r)
// (we looked ahead to the next chunk and found a word boundary)
// - We built up our own chunk of text from many chunks from the text iterator
-// FIXME: Perf could be bad for huge spans next to each other that don't fall on word boundaries
+// FIXME: Performance could be bad for huge spans next to each other that don't fall on word boundaries.
void WordAwareIterator::advance()
{
@@ -1507,7 +1624,7 @@ size_t SearchBuffer::length() const
// --------
-int TextIterator::rangeLength(const Range *r, bool forSelectionPreservation)
+int TextIterator::rangeLength(const Range* r, bool forSelectionPreservation)
{
int length = 0;
for (TextIterator it(r, forSelectionPreservation); !it.atEnd(); it.advance())
@@ -1522,7 +1639,7 @@ PassRefPtr<Range> TextIterator::subrange(Range* entireRange, int characterOffset
return characterSubrange(entireRangeIterator, characterOffset, characterCount);
}
-PassRefPtr<Range> TextIterator::rangeFromLocationAndLength(Element *scope, int rangeLocation, int rangeLength, bool forSelectionPreservation)
+PassRefPtr<Range> TextIterator::rangeFromLocationAndLength(Element* scope, int rangeLocation, int rangeLength, bool forSelectionPreservation)
{
RefPtr<Range> resultRange = scope->document()->createRange();
diff --git a/src/3rdparty/webkit/WebCore/editing/TextIterator.h b/src/3rdparty/webkit/WebCore/editing/TextIterator.h
index f00bea4..44af3e5a 100644
--- a/src/3rdparty/webkit/WebCore/editing/TextIterator.h
+++ b/src/3rdparty/webkit/WebCore/editing/TextIterator.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2004, 2006 Apple Computer, Inc. All rights reserved.
+ * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -49,6 +49,21 @@ String plainText(const Range*);
UChar* plainTextToMallocAllocatedBuffer(const Range*, unsigned& bufferLength, bool isDisplayString);
PassRefPtr<Range> findPlainText(const Range*, const String&, bool forward, bool caseSensitive);
+class BitStack {
+public:
+ BitStack();
+
+ void push(bool);
+ void pop();
+
+ bool top() const;
+ unsigned size() const;
+
+private:
+ unsigned m_size;
+ Vector<unsigned, 1> m_words;
+};
+
// Iterates through the DOM range, returning all the text, and 0-length boundaries
// at points where replaced elements break up the text flow. The text comes back in
// chunks so as to optimize for performance of the iteration.
@@ -80,27 +95,27 @@ private:
bool handleReplacedElement();
bool handleNonTextNode();
void handleTextBox();
- void emitCharacter(UChar, Node *textNode, Node *offsetBaseNode, int textStartOffset, int textEndOffset);
- void emitText(Node *textNode, int textStartOffset, int textEndOffset);
+ void emitCharacter(UChar, Node* textNode, Node* offsetBaseNode, int textStartOffset, int textEndOffset);
+ void emitText(Node* textNode, int textStartOffset, int textEndOffset);
// Current position, not necessarily of the text being returned, but position
// as we walk through the DOM tree.
- Node *m_node;
+ Node* m_node;
int m_offset;
bool m_handledNode;
bool m_handledChildren;
- bool m_inShadowContent;
+ BitStack m_fullyClippedStack;
// The range.
- Node *m_startContainer;
+ Node* m_startContainer;
int m_startOffset;
- Node *m_endContainer;
+ Node* m_endContainer;
int m_endOffset;
- Node *m_pastEndNode;
+ Node* m_pastEndNode;
// The current text and its position, in the form to be returned from the iterator.
- Node *m_positionNode;
- mutable Node *m_positionOffsetBaseNode;
+ Node* m_positionNode;
+ mutable Node* m_positionOffsetBaseNode;
mutable int m_positionStartOffset;
mutable int m_positionEndOffset;
const UChar* m_textCharacters;
@@ -109,10 +124,10 @@ private:
// Used when there is still some pending text from the current node; when these
// are false and 0, we go back to normal iterating.
bool m_needAnotherNewline;
- InlineTextBox *m_textBox;
+ InlineTextBox* m_textBox;
// Used to do the whitespace collapsing logic.
- Node *m_lastTextNode;
+ Node* m_lastTextNode;
bool m_lastTextNodeEndedWithCollapsedSpace;
UChar m_lastCharacter;
@@ -135,12 +150,12 @@ private:
};
// Iterates through the DOM range, returning all the text, and 0-length boundaries
-// at points where replaced elements break up the text flow. The text comes back in
+// at points where replaced elements break up the text flow. The text comes back in
// chunks so as to optimize for performance of the iteration.
class SimplifiedBackwardsTextIterator {
public:
SimplifiedBackwardsTextIterator();
- explicit SimplifiedBackwardsTextIterator(const Range *);
+ explicit SimplifiedBackwardsTextIterator(const Range*);
bool atEnd() const { return !m_positionNode; }
void advance();
@@ -155,7 +170,7 @@ private:
bool handleTextNode();
bool handleReplacedElement();
bool handleNonTextNode();
- void emitCharacter(UChar, Node *Node, int startOffset, int endOffset);
+ void emitCharacter(UChar, Node*, int startOffset, int endOffset);
// Current position, not necessarily of the text being returned, but position
// as we walk through the DOM tree.
@@ -163,7 +178,8 @@ private:
int m_offset;
bool m_handledNode;
bool m_handledChildren;
-
+ BitStack m_fullyClippedStack;
+
// End of the range.
Node* m_startNode;
int m_startOffset;
@@ -194,7 +210,7 @@ private:
class CharacterIterator {
public:
CharacterIterator();
- explicit CharacterIterator(const Range* r, bool emitCharactersBetweenAllVisiblePositions = false, bool enterTextControls = false);
+ explicit CharacterIterator(const Range*, bool emitCharactersBetweenAllVisiblePositions = false, bool enterTextControls = false);
void advance(int numCharacters);
@@ -240,7 +256,7 @@ private:
class WordAwareIterator {
public:
WordAwareIterator();
- explicit WordAwareIterator(const Range *r);
+ explicit WordAwareIterator(const Range*);
bool atEnd() const { return !m_didLookAhead && m_textIterator.atEnd(); }
void advance();
diff --git a/src/3rdparty/webkit/WebCore/editing/TypingCommand.cpp b/src/3rdparty/webkit/WebCore/editing/TypingCommand.cpp
index 5ce4e56..f5901d7 100644
--- a/src/3rdparty/webkit/WebCore/editing/TypingCommand.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/TypingCommand.cpp
@@ -58,6 +58,7 @@ TypingCommand::TypingCommand(Document *document, ETypingCommand commandType, con
m_killRing(killRing),
m_openedByBackwardDelete(false)
{
+ updatePreservesTypingStyle(m_commandType);
}
void TypingCommand::deleteSelection(Document* document, bool smartDelete)
@@ -309,8 +310,10 @@ void TypingCommand::markMisspellingsAfterTyping()
}
}
-void TypingCommand::typingAddedToOpenCommand()
+void TypingCommand::typingAddedToOpenCommand(ETypingCommand commandTypeForAddedTyping)
{
+ updatePreservesTypingStyle(commandTypeForAddedTyping);
+
#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
document()->frame()->editor()->appliedEditing(this);
// Since the spellchecking code may also perform corrections and other replacements, it should happen after the typing changes.
@@ -360,19 +363,19 @@ void TypingCommand::insertTextRunWithoutNewlines(const String &text, bool select
applyCommandToComposite(command);
}
command->input(text, selectInsertedText);
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(InsertText);
}
void TypingCommand::insertLineBreak()
{
applyCommandToComposite(InsertLineBreakCommand::create(document()));
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(InsertLineBreak);
}
void TypingCommand::insertParagraphSeparator()
{
applyCommandToComposite(InsertParagraphSeparatorCommand::create(document()));
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(InsertParagraphSeparator);
}
void TypingCommand::insertParagraphSeparatorInQuotedContent()
@@ -385,7 +388,7 @@ void TypingCommand::insertParagraphSeparatorInQuotedContent()
}
applyCommandToComposite(BreakBlockquoteCommand::create(document()));
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(InsertParagraphSeparatorInQuotedContent);
}
bool TypingCommand::makeEditableRootEmpty()
@@ -423,7 +426,7 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity, bool killRing)
// After breaking out of an empty mail blockquote, we still want continue with the deletion
// so actual content will get deleted, and not just the quote style.
if (breakOutOfEmptyMailBlockquotedParagraph())
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteKey);
m_smartDelete = false;
@@ -436,12 +439,12 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity, bool killRing)
if (endingSelection().visibleStart().previous(true).isNull()) {
// When the caret is at the start of the editable area in an empty list item, break out of the list item.
if (breakOutOfEmptyListItem()) {
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteKey);
return;
}
// When there are no visible positions in the editing root, delete its entire contents.
if (endingSelection().visibleStart().next(true).isNull() && makeEditableRootEmpty()) {
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteKey);
return;
}
}
@@ -457,7 +460,7 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity, bool killRing)
// If the caret is just after a table, select the table and don't delete anything.
} else if (Node* table = isFirstPositionAfterTable(visibleStart)) {
setEndingSelection(VisibleSelection(Position(table, 0), endingSelection().start(), DOWNSTREAM));
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteKey);
return;
}
@@ -498,7 +501,7 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity, bool killRing)
setStartingSelection(selectionAfterUndo);
CompositeEditCommand::deleteSelection(selectionToDelete, m_smartDelete);
setSmartDelete(false);
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteKey);
}
void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool killRing)
@@ -530,7 +533,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki
// When deleting tables: Select the table first, then perform the deletion
if (downstreamEnd.node() && downstreamEnd.node()->renderer() && downstreamEnd.node()->renderer()->isTable() && downstreamEnd.deprecatedEditingOffset() == 0) {
setEndingSelection(VisibleSelection(endingSelection().end(), lastDeepEditingPositionForNode(downstreamEnd.node()), DOWNSTREAM));
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(ForwardDeleteKey);
return;
}
@@ -578,30 +581,32 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki
setStartingSelection(selectionAfterUndo);
CompositeEditCommand::deleteSelection(selectionToDelete, m_smartDelete);
setSmartDelete(false);
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(ForwardDeleteKey);
}
void TypingCommand::deleteSelection(bool smartDelete)
{
CompositeEditCommand::deleteSelection(smartDelete);
- typingAddedToOpenCommand();
+ typingAddedToOpenCommand(DeleteSelection);
}
-bool TypingCommand::preservesTypingStyle() const
+void TypingCommand::updatePreservesTypingStyle(ETypingCommand commandType)
{
- switch (m_commandType) {
+ switch (commandType) {
case DeleteSelection:
case DeleteKey:
case ForwardDeleteKey:
case InsertParagraphSeparator:
case InsertLineBreak:
- return true;
+ m_preservesTypingStyle = true;
+ return;
case InsertParagraphSeparatorInQuotedContent:
case InsertText:
- return false;
+ m_preservesTypingStyle = false;
+ return;
}
ASSERT_NOT_REACHED();
- return false;
+ m_preservesTypingStyle = false;
}
bool TypingCommand::isTypingCommand() const
diff --git a/src/3rdparty/webkit/WebCore/editing/TypingCommand.h b/src/3rdparty/webkit/WebCore/editing/TypingCommand.h
index 2c52447..7c89a7c 100644
--- a/src/3rdparty/webkit/WebCore/editing/TypingCommand.h
+++ b/src/3rdparty/webkit/WebCore/editing/TypingCommand.h
@@ -79,10 +79,11 @@ private:
virtual void doApply();
virtual EditAction editingAction() const;
virtual bool isTypingCommand() const;
- virtual bool preservesTypingStyle() const;
+ virtual bool preservesTypingStyle() const { return m_preservesTypingStyle; }
+ void updatePreservesTypingStyle(ETypingCommand);
void markMisspellingsAfterTyping();
- void typingAddedToOpenCommand();
+ void typingAddedToOpenCommand(ETypingCommand);
bool makeEditableRootEmpty();
ETypingCommand m_commandType;
@@ -92,6 +93,7 @@ private:
bool m_smartDelete;
TextGranularity m_granularity;
bool m_killRing;
+ bool m_preservesTypingStyle;
// Undoing a series of backward deletes will restore a selection around all of the
// characters that were deleted, but only if the typing command being undone
diff --git a/src/3rdparty/webkit/WebCore/editing/gtk/SelectionControllerGtk.cpp b/src/3rdparty/webkit/WebCore/editing/gtk/SelectionControllerGtk.cpp
index 52fbbab..c21c45a 100644
--- a/src/3rdparty/webkit/WebCore/editing/gtk/SelectionControllerGtk.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/gtk/SelectionControllerGtk.cpp
@@ -34,7 +34,7 @@ void SelectionController::notifyAccessibilityForSelectionChange()
AccessibilityObject* accessibilityObject = m_frame->document()->axObjectCache()->getOrCreate(focusedNode);
AtkObject* wrapper = accessibilityObject->wrapper();
if (ATK_IS_TEXT(wrapper)) {
- g_signal_emit_by_name(wrapper, "text-caret-moved", m_sel.start().offsetInContainerNode());
+ g_signal_emit_by_name(wrapper, "text-caret-moved", m_sel.start().computeOffsetInContainerNode());
if (m_sel.isRange())
g_signal_emit_by_name(wrapper, "text-selection-changed");
diff --git a/src/3rdparty/webkit/WebCore/editing/htmlediting.cpp b/src/3rdparty/webkit/WebCore/editing/htmlediting.cpp
index 7b51295..c0bf009 100644
--- a/src/3rdparty/webkit/WebCore/editing/htmlediting.cpp
+++ b/src/3rdparty/webkit/WebCore/editing/htmlediting.cpp
@@ -84,6 +84,7 @@ bool canHaveChildrenForEditing(const Node* node)
!node->hasTagName(embedTag) &&
!node->hasTagName(appletTag) &&
!node->hasTagName(selectTag) &&
+ !node->hasTagName(datagridTag) &&
#if ENABLE(WML)
!node->hasTagName(WMLNames::doTag) &&
#endif
@@ -664,7 +665,7 @@ HTMLElement* enclosingList(Node* node)
return 0;
}
-Node* enclosingListChild(Node *node)
+HTMLElement* enclosingListChild(Node *node)
{
if (!node)
return 0;
@@ -675,7 +676,7 @@ Node* enclosingListChild(Node *node)
// FIXME: This function is inappropriately named if it starts with node instead of node->parentNode()
for (Node* n = node; n && n->parentNode(); n = n->parentNode()) {
if (n->hasTagName(liTag) || isListElement(n->parentNode()))
- return n;
+ return static_cast<HTMLElement*>(n);
if (n == root || isTableCell(n))
return 0;
}
@@ -737,6 +738,18 @@ HTMLElement* outermostEnclosingList(Node* node)
return list;
}
+bool canMergeLists(Element* firstList, Element* secondList)
+{
+ if (!firstList || !secondList)
+ return false;
+
+ return firstList->hasTagName(secondList->tagQName())// make sure the list types match (ol vs. ul)
+ && isContentEditable(firstList) && isContentEditable(secondList)// both lists are editable
+ && firstList->rootEditableElement() == secondList->rootEditableElement()// don't cross editing boundaries
+ && isVisibilyAdjacent(positionAfterNode(firstList), positionBeforeNode(secondList));
+ // Make sure there is no visible content between this li and the previous list
+}
+
Node* highestAncestor(Node* node)
{
ASSERT(node);
@@ -970,6 +983,11 @@ int indexForVisiblePosition(VisiblePosition& visiblePosition)
return TextIterator::rangeLength(range.get(), true);
}
+bool isVisibilyAdjacent(const Position& first, const Position& second)
+{
+ return VisiblePosition(first) == VisiblePosition(second.upstream());
+}
+
PassRefPtr<Range> avoidIntersectionWithNode(const Range* range, Node* node)
{
if (!range)
diff --git a/src/3rdparty/webkit/WebCore/editing/htmlediting.h b/src/3rdparty/webkit/WebCore/editing/htmlediting.h
index 374b512..25ff847 100644
--- a/src/3rdparty/webkit/WebCore/editing/htmlediting.h
+++ b/src/3rdparty/webkit/WebCore/editing/htmlediting.h
@@ -123,7 +123,8 @@ Node* enclosingAnchorElement(const Position&);
bool isListElement(Node*);
HTMLElement* enclosingList(Node*);
HTMLElement* outermostEnclosingList(Node*);
-Node* enclosingListChild(Node*);
+HTMLElement* enclosingListChild(Node*);
+bool canMergeLists(Element* firstList, Element* secondList);
Node* highestAncestor(Node*);
bool isTableElement(Node*);
bool isTableCell(const Node*);
@@ -134,7 +135,7 @@ bool lineBreakExistsAtVisiblePosition(const VisiblePosition&);
VisibleSelection selectionForParagraphIteration(const VisibleSelection&);
int indexForVisiblePosition(VisiblePosition&);
-
+bool isVisibilyAdjacent(const Position& first, const Position& second);
}
#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/CSSGrammar.cpp b/src/3rdparty/webkit/WebCore/generated/CSSGrammar.cpp
index 1c2da06..4c85bee 100644
--- a/src/3rdparty/webkit/WebCore/generated/CSSGrammar.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/CSSGrammar.cpp
@@ -1,23 +1,24 @@
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton implementation for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -28,7 +29,7 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
@@ -46,7 +47,7 @@
#define YYBISON 1
/* Bison version. */
-#define YYBISON_VERSION "2.4.1"
+#define YYBISON_VERSION "2.3"
/* Skeleton name. */
#define YYSKELETON_NAME "yacc.c"
@@ -54,28 +55,159 @@
/* Pure parsers. */
#define YYPURE 1
-/* Push parsers. */
-#define YYPUSH 0
-
-/* Pull parsers. */
-#define YYPULL 1
-
/* Using locations. */
#define YYLSP_NEEDED 0
/* Substitute the variable and function names. */
-#define yyparse cssyyparse
-#define yylex cssyylex
-#define yyerror cssyyerror
-#define yylval cssyylval
-#define yychar cssyychar
-#define yydebug cssyydebug
-#define yynerrs cssyynerrs
+#define yyparse cssyyparse
+#define yylex cssyylex
+#define yyerror cssyyerror
+#define yylval cssyylval
+#define yychar cssyychar
+#define yydebug cssyydebug
+#define yynerrs cssyynerrs
-/* Copy the first part of user declarations. */
+/* Tokens. */
+#ifndef YYTOKENTYPE
+# define YYTOKENTYPE
+ /* Put the tokens into the symbol table, so that GDB and other debuggers
+ know about them. */
+ enum yytokentype {
+ TOKEN_EOF = 0,
+ LOWEST_PREC = 258,
+ UNIMPORTANT_TOK = 259,
+ WHITESPACE = 260,
+ SGML_CD = 261,
+ INCLUDES = 262,
+ DASHMATCH = 263,
+ BEGINSWITH = 264,
+ ENDSWITH = 265,
+ CONTAINS = 266,
+ STRING = 267,
+ IDENT = 268,
+ NTH = 269,
+ HEX = 270,
+ IDSEL = 271,
+ IMPORT_SYM = 272,
+ PAGE_SYM = 273,
+ MEDIA_SYM = 274,
+ FONT_FACE_SYM = 275,
+ CHARSET_SYM = 276,
+ NAMESPACE_SYM = 277,
+ WEBKIT_RULE_SYM = 278,
+ WEBKIT_DECLS_SYM = 279,
+ WEBKIT_KEYFRAME_RULE_SYM = 280,
+ WEBKIT_KEYFRAMES_SYM = 281,
+ WEBKIT_VALUE_SYM = 282,
+ WEBKIT_MEDIAQUERY_SYM = 283,
+ WEBKIT_SELECTOR_SYM = 284,
+ WEBKIT_VARIABLES_SYM = 285,
+ WEBKIT_DEFINE_SYM = 286,
+ VARIABLES_FOR = 287,
+ WEBKIT_VARIABLES_DECLS_SYM = 288,
+ ATKEYWORD = 289,
+ IMPORTANT_SYM = 290,
+ MEDIA_ONLY = 291,
+ MEDIA_NOT = 292,
+ MEDIA_AND = 293,
+ QEMS = 294,
+ EMS = 295,
+ EXS = 296,
+ PXS = 297,
+ CMS = 298,
+ MMS = 299,
+ INS = 300,
+ PTS = 301,
+ PCS = 302,
+ DEGS = 303,
+ RADS = 304,
+ GRADS = 305,
+ TURNS = 306,
+ MSECS = 307,
+ SECS = 308,
+ HERZ = 309,
+ KHERZ = 310,
+ DIMEN = 311,
+ PERCENTAGE = 312,
+ FLOATTOKEN = 313,
+ INTEGER = 314,
+ URI = 315,
+ FUNCTION = 316,
+ NOTFUNCTION = 317,
+ UNICODERANGE = 318,
+ VARCALL = 319
+ };
+#endif
+/* Tokens. */
+#define TOKEN_EOF 0
+#define LOWEST_PREC 258
+#define UNIMPORTANT_TOK 259
+#define WHITESPACE 260
+#define SGML_CD 261
+#define INCLUDES 262
+#define DASHMATCH 263
+#define BEGINSWITH 264
+#define ENDSWITH 265
+#define CONTAINS 266
+#define STRING 267
+#define IDENT 268
+#define NTH 269
+#define HEX 270
+#define IDSEL 271
+#define IMPORT_SYM 272
+#define PAGE_SYM 273
+#define MEDIA_SYM 274
+#define FONT_FACE_SYM 275
+#define CHARSET_SYM 276
+#define NAMESPACE_SYM 277
+#define WEBKIT_RULE_SYM 278
+#define WEBKIT_DECLS_SYM 279
+#define WEBKIT_KEYFRAME_RULE_SYM 280
+#define WEBKIT_KEYFRAMES_SYM 281
+#define WEBKIT_VALUE_SYM 282
+#define WEBKIT_MEDIAQUERY_SYM 283
+#define WEBKIT_SELECTOR_SYM 284
+#define WEBKIT_VARIABLES_SYM 285
+#define WEBKIT_DEFINE_SYM 286
+#define VARIABLES_FOR 287
+#define WEBKIT_VARIABLES_DECLS_SYM 288
+#define ATKEYWORD 289
+#define IMPORTANT_SYM 290
+#define MEDIA_ONLY 291
+#define MEDIA_NOT 292
+#define MEDIA_AND 293
+#define QEMS 294
+#define EMS 295
+#define EXS 296
+#define PXS 297
+#define CMS 298
+#define MMS 299
+#define INS 300
+#define PTS 301
+#define PCS 302
+#define DEGS 303
+#define RADS 304
+#define GRADS 305
+#define TURNS 306
+#define MSECS 307
+#define SECS 308
+#define HERZ 309
+#define KHERZ 310
+#define DIMEN 311
+#define PERCENTAGE 312
+#define FLOATTOKEN 313
+#define INTEGER 314
+#define URI 315
+#define FUNCTION 316
+#define NOTFUNCTION 317
+#define UNICODERANGE 318
+#define VARCALL 319
-/* Line 189 of yacc.c */
+
+
+
+/* Copy the first part of user declarations. */
#line 1 "../css/CSSGrammar.y"
@@ -132,9 +264,6 @@ using namespace HTMLNames;
-/* Line 189 of yacc.c */
-#line 137 "WebCore/tmp/../generated/CSSGrammar.tab.c"
-
/* Enabling traces. */
#ifndef YYDEBUG
# define YYDEBUG 0
@@ -153,88 +282,10 @@ using namespace HTMLNames;
# define YYTOKEN_TABLE 0
#endif
-
-/* Tokens. */
-#ifndef YYTOKENTYPE
-# define YYTOKENTYPE
- /* Put the tokens into the symbol table, so that GDB and other debuggers
- know about them. */
- enum yytokentype {
- TOKEN_EOF = 0,
- LOWEST_PREC = 258,
- UNIMPORTANT_TOK = 259,
- WHITESPACE = 260,
- SGML_CD = 261,
- INCLUDES = 262,
- DASHMATCH = 263,
- BEGINSWITH = 264,
- ENDSWITH = 265,
- CONTAINS = 266,
- STRING = 267,
- IDENT = 268,
- NTH = 269,
- HEX = 270,
- IDSEL = 271,
- IMPORT_SYM = 272,
- PAGE_SYM = 273,
- MEDIA_SYM = 274,
- FONT_FACE_SYM = 275,
- CHARSET_SYM = 276,
- NAMESPACE_SYM = 277,
- WEBKIT_RULE_SYM = 278,
- WEBKIT_DECLS_SYM = 279,
- WEBKIT_KEYFRAME_RULE_SYM = 280,
- WEBKIT_KEYFRAMES_SYM = 281,
- WEBKIT_VALUE_SYM = 282,
- WEBKIT_MEDIAQUERY_SYM = 283,
- WEBKIT_SELECTOR_SYM = 284,
- WEBKIT_VARIABLES_SYM = 285,
- WEBKIT_DEFINE_SYM = 286,
- VARIABLES_FOR = 287,
- WEBKIT_VARIABLES_DECLS_SYM = 288,
- ATKEYWORD = 289,
- IMPORTANT_SYM = 290,
- MEDIA_ONLY = 291,
- MEDIA_NOT = 292,
- MEDIA_AND = 293,
- QEMS = 294,
- EMS = 295,
- EXS = 296,
- PXS = 297,
- CMS = 298,
- MMS = 299,
- INS = 300,
- PTS = 301,
- PCS = 302,
- DEGS = 303,
- RADS = 304,
- GRADS = 305,
- TURNS = 306,
- MSECS = 307,
- SECS = 308,
- HERZ = 309,
- KHERZ = 310,
- DIMEN = 311,
- PERCENTAGE = 312,
- FLOATTOKEN = 313,
- INTEGER = 314,
- URI = 315,
- FUNCTION = 316,
- NOTFUNCTION = 317,
- UNICODERANGE = 318,
- VARCALL = 319
- };
-#endif
-
-
-
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 214 of yacc.c */
#line 58 "../css/CSSGrammar.y"
-
+{
bool boolean;
char character;
int integer;
@@ -256,21 +307,18 @@ typedef union YYSTYPE
WebKitCSSKeyframeRule* keyframeRule;
WebKitCSSKeyframesRule* keyframesRule;
float val;
-
-
-
-/* Line 214 of yacc.c */
-#line 264 "WebCore/tmp/../generated/CSSGrammar.tab.c"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 187 of yacc.c. */
+#line 313 "WebCore/tmp/../generated/CSSGrammar.tab.c"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
-/* Copy the second part of user declarations. */
-/* Line 264 of yacc.c */
+/* Copy the second part of user declarations. */
#line 82 "../css/CSSGrammar.y"
@@ -286,8 +334,8 @@ static int cssyylex(YYSTYPE* yylval, void* parser)
-/* Line 264 of yacc.c */
-#line 291 "WebCore/tmp/../generated/CSSGrammar.tab.c"
+/* Line 216 of yacc.c. */
+#line 339 "WebCore/tmp/../generated/CSSGrammar.tab.c"
#ifdef short
# undef short
@@ -362,14 +410,14 @@ typedef short int yytype_int16;
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static int
-YYID (int yyi)
+YYID (int i)
#else
static int
-YYID (yyi)
- int yyi;
+YYID (i)
+ int i;
#endif
{
- return yyi;
+ return i;
}
#endif
@@ -450,9 +498,9 @@ void free (void *); /* INFRINGES ON USER NAME SPACE */
/* A type that is properly aligned for any stack member. */
union yyalloc
{
- yytype_int16 yyss_alloc;
- YYSTYPE yyvs_alloc;
-};
+ yytype_int16 yyss;
+ YYSTYPE yyvs;
+ };
/* The size of the maximum gap between one aligned stack and the next. */
# define YYSTACK_GAP_MAXIMUM (sizeof (union yyalloc) - 1)
@@ -486,12 +534,12 @@ union yyalloc
elements in the stack, and YYPTR gives the new location of the
stack. Advance YYPTR to a properly aligned location for the next
stack. */
-# define YYSTACK_RELOCATE(Stack_alloc, Stack) \
+# define YYSTACK_RELOCATE(Stack) \
do \
{ \
YYSIZE_T yynewbytes; \
- YYCOPY (&yyptr->Stack_alloc, Stack, yysize); \
- Stack = &yyptr->Stack_alloc; \
+ YYCOPY (&yyptr->Stack, Stack, yysize); \
+ Stack = &yyptr->Stack; \
yynewbytes = yystacksize * sizeof (*Stack) + YYSTACK_GAP_MAXIMUM; \
yyptr += yynewbytes / sizeof (*yyptr); \
} \
@@ -1510,20 +1558,17 @@ yy_symbol_print (yyoutput, yytype, yyvaluep)
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static void
-yy_stack_print (yytype_int16 *yybottom, yytype_int16 *yytop)
+yy_stack_print (yytype_int16 *bottom, yytype_int16 *top)
#else
static void
-yy_stack_print (yybottom, yytop)
- yytype_int16 *yybottom;
- yytype_int16 *yytop;
+yy_stack_print (bottom, top)
+ yytype_int16 *bottom;
+ yytype_int16 *top;
#endif
{
YYFPRINTF (stderr, "Stack now");
- for (; yybottom <= yytop; yybottom++)
- {
- int yybot = *yybottom;
- YYFPRINTF (stderr, " %d", yybot);
- }
+ for (; bottom <= top; ++bottom)
+ YYFPRINTF (stderr, " %d", *bottom);
YYFPRINTF (stderr, "\n");
}
@@ -1557,11 +1602,11 @@ yy_reduce_print (yyvsp, yyrule)
/* The symbols being reduced. */
for (yyi = 0; yyi < yynrhs; yyi++)
{
- YYFPRINTF (stderr, " $%d = ", yyi + 1);
+ fprintf (stderr, " $%d = ", yyi + 1);
yy_symbol_print (stderr, yyrhs[yyprhs[yyrule] + yyi],
&(yyvsp[(yyi + 1) - (yynrhs)])
);
- YYFPRINTF (stderr, "\n");
+ fprintf (stderr, "\n");
}
}
@@ -1841,8 +1886,10 @@ yydestruct (yymsg, yytype, yyvaluep)
break;
}
}
+
/* Prevent warnings from -Wmissing-prototypes. */
+
#ifdef YYPARSE_PARAM
#if defined __STDC__ || defined __cplusplus
int yyparse (void *YYPARSE_PARAM);
@@ -1861,9 +1908,10 @@ int yyparse ();
-/*-------------------------.
-| yyparse or yypush_parse. |
-`-------------------------*/
+
+/*----------.
+| yyparse. |
+`----------*/
#ifdef YYPARSE_PARAM
#if (defined __STDC__ || defined __C99__FUNC__ \
@@ -1887,46 +1935,22 @@ yyparse ()
#endif
#endif
{
-/* The lookahead symbol. */
+ /* The look-ahead symbol. */
int yychar;
-/* The semantic value of the lookahead symbol. */
+/* The semantic value of the look-ahead symbol. */
YYSTYPE yylval;
- /* Number of syntax errors so far. */
- int yynerrs;
-
- int yystate;
- /* Number of tokens to shift before error messages enabled. */
- int yyerrstatus;
-
- /* The stacks and their tools:
- `yyss': related to states.
- `yyvs': related to semantic values.
-
- Refer to the stacks thru separate pointers, to allow yyoverflow
- to reallocate them elsewhere. */
-
- /* The state stack. */
- yytype_int16 yyssa[YYINITDEPTH];
- yytype_int16 *yyss;
- yytype_int16 *yyssp;
-
- /* The semantic value stack. */
- YYSTYPE yyvsa[YYINITDEPTH];
- YYSTYPE *yyvs;
- YYSTYPE *yyvsp;
-
- YYSIZE_T yystacksize;
+/* Number of syntax errors so far. */
+int yynerrs;
+ int yystate;
int yyn;
int yyresult;
- /* Lookahead token as an internal (translated) token number. */
- int yytoken;
- /* The variables used to return semantic value and location from the
- action routines. */
- YYSTYPE yyval;
-
+ /* Number of tokens to shift before error messages enabled. */
+ int yyerrstatus;
+ /* Look-ahead token as an internal (translated) token number. */
+ int yytoken = 0;
#if YYERROR_VERBOSE
/* Buffer for error messages, and its allocated size. */
char yymsgbuf[128];
@@ -1934,28 +1958,51 @@ YYSTYPE yylval;
YYSIZE_T yymsg_alloc = sizeof yymsgbuf;
#endif
+ /* Three stacks and their tools:
+ `yyss': related to states,
+ `yyvs': related to semantic values,
+ `yyls': related to locations.
+
+ Refer to the stacks thru separate pointers, to allow yyoverflow
+ to reallocate them elsewhere. */
+
+ /* The state stack. */
+ yytype_int16 yyssa[YYINITDEPTH];
+ yytype_int16 *yyss = yyssa;
+ yytype_int16 *yyssp;
+
+ /* The semantic value stack. */
+ YYSTYPE yyvsa[YYINITDEPTH];
+ YYSTYPE *yyvs = yyvsa;
+ YYSTYPE *yyvsp;
+
+
+
#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N))
+ YYSIZE_T yystacksize = YYINITDEPTH;
+
+ /* The variables used to return semantic value and location from the
+ action routines. */
+ YYSTYPE yyval;
+
+
/* The number of symbols on the RHS of the reduced rule.
Keep to zero when no symbol should be popped. */
int yylen = 0;
- yytoken = 0;
- yyss = yyssa;
- yyvs = yyvsa;
- yystacksize = YYINITDEPTH;
-
YYDPRINTF ((stderr, "Starting parse\n"));
yystate = 0;
yyerrstatus = 0;
yynerrs = 0;
- yychar = YYEMPTY; /* Cause a token to be read. */
+ yychar = YYEMPTY; /* Cause a token to be read. */
/* Initialize stack pointers.
Waste one element of value and location stack
so that they stay on the same level as the state stack.
The wasted elements are never initialized. */
+
yyssp = yyss;
yyvsp = yyvs;
@@ -1985,6 +2032,7 @@ YYSTYPE yylval;
YYSTYPE *yyvs1 = yyvs;
yytype_int16 *yyss1 = yyss;
+
/* Each stack pointer address is followed by the size of the
data in use in that stack, in bytes. This used to be a
conditional around just the two extra args, but that might
@@ -1992,6 +2040,7 @@ YYSTYPE yylval;
yyoverflow (YY_("memory exhausted"),
&yyss1, yysize * sizeof (*yyssp),
&yyvs1, yysize * sizeof (*yyvsp),
+
&yystacksize);
yyss = yyss1;
@@ -2014,8 +2063,9 @@ YYSTYPE yylval;
(union yyalloc *) YYSTACK_ALLOC (YYSTACK_BYTES (yystacksize));
if (! yyptr)
goto yyexhaustedlab;
- YYSTACK_RELOCATE (yyss_alloc, yyss);
- YYSTACK_RELOCATE (yyvs_alloc, yyvs);
+ YYSTACK_RELOCATE (yyss);
+ YYSTACK_RELOCATE (yyvs);
+
# undef YYSTACK_RELOCATE
if (yyss1 != yyssa)
YYSTACK_FREE (yyss1);
@@ -2026,6 +2076,7 @@ YYSTYPE yylval;
yyssp = yyss + yysize - 1;
yyvsp = yyvs + yysize - 1;
+
YYDPRINTF ((stderr, "Stack size increased to %lu\n",
(unsigned long int) yystacksize));
@@ -2035,9 +2086,6 @@ YYSTYPE yylval;
YYDPRINTF ((stderr, "Entering state %d\n", yystate));
- if (yystate == YYFINAL)
- YYACCEPT;
-
goto yybackup;
/*-----------.
@@ -2046,16 +2094,16 @@ YYSTYPE yylval;
yybackup:
/* Do appropriate processing given the current state. Read a
- lookahead token if we need one and don't already have one. */
+ look-ahead token if we need one and don't already have one. */
- /* First try to decide what to do without reference to lookahead token. */
+ /* First try to decide what to do without reference to look-ahead token. */
yyn = yypact[yystate];
if (yyn == YYPACT_NINF)
goto yydefault;
- /* Not known => get a lookahead token if don't already have one. */
+ /* Not known => get a look-ahead token if don't already have one. */
- /* YYCHAR is either YYEMPTY or YYEOF or a valid lookahead symbol. */
+ /* YYCHAR is either YYEMPTY or YYEOF or a valid look-ahead symbol. */
if (yychar == YYEMPTY)
{
YYDPRINTF ((stderr, "Reading a token: "));
@@ -2087,16 +2135,20 @@ yybackup:
goto yyreduce;
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
/* Count tokens shifted since error; after three, turn off error
status. */
if (yyerrstatus)
yyerrstatus--;
- /* Shift the lookahead token. */
+ /* Shift the look-ahead token. */
YY_SYMBOL_PRINT ("Shifting", yytoken, &yylval, &yylloc);
- /* Discard the shifted token. */
- yychar = YYEMPTY;
+ /* Discard the shifted token unless it is eof. */
+ if (yychar != YYEOF)
+ yychar = YYEMPTY;
yystate = yyn;
*++yyvsp = yylval;
@@ -2136,8 +2188,6 @@ yyreduce:
switch (yyn)
{
case 12:
-
-/* Line 1455 of yacc.c */
#line 282 "../css/CSSGrammar.y"
{
static_cast<CSSParser*>(parser)->m_rule = (yyvsp[(4) - (6)].rule);
@@ -2145,8 +2195,6 @@ yyreduce:
break;
case 13:
-
-/* Line 1455 of yacc.c */
#line 288 "../css/CSSGrammar.y"
{
static_cast<CSSParser*>(parser)->m_keyframe = (yyvsp[(4) - (6)].keyframeRule);
@@ -2154,8 +2202,6 @@ yyreduce:
break;
case 14:
-
-/* Line 1455 of yacc.c */
#line 294 "../css/CSSGrammar.y"
{
/* can be empty */
@@ -2163,8 +2209,6 @@ yyreduce:
break;
case 15:
-
-/* Line 1455 of yacc.c */
#line 300 "../css/CSSGrammar.y"
{
/* can be empty */
@@ -2172,8 +2216,6 @@ yyreduce:
break;
case 16:
-
-/* Line 1455 of yacc.c */
#line 306 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2189,8 +2231,6 @@ yyreduce:
break;
case 17:
-
-/* Line 1455 of yacc.c */
#line 320 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2199,8 +2239,6 @@ yyreduce:
break;
case 18:
-
-/* Line 1455 of yacc.c */
#line 327 "../css/CSSGrammar.y"
{
if ((yyvsp[(4) - (5)].selectorList)) {
@@ -2212,16 +2250,12 @@ yyreduce:
break;
case 25:
-
-/* Line 1455 of yacc.c */
#line 349 "../css/CSSGrammar.y"
{
;}
break;
case 28:
-
-/* Line 1455 of yacc.c */
#line 359 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2232,24 +2266,18 @@ yyreduce:
break;
case 29:
-
-/* Line 1455 of yacc.c */
#line 365 "../css/CSSGrammar.y"
{
;}
break;
case 30:
-
-/* Line 1455 of yacc.c */
#line 367 "../css/CSSGrammar.y"
{
;}
break;
case 32:
-
-/* Line 1455 of yacc.c */
#line 373 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2259,16 +2287,12 @@ yyreduce:
break;
case 33:
-
-/* Line 1455 of yacc.c */
#line 378 "../css/CSSGrammar.y"
{
;}
break;
case 35:
-
-/* Line 1455 of yacc.c */
#line 384 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2278,8 +2302,6 @@ yyreduce:
break;
case 39:
-
-/* Line 1455 of yacc.c */
#line 398 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2289,15 +2311,11 @@ yyreduce:
break;
case 49:
-
-/* Line 1455 of yacc.c */
#line 421 "../css/CSSGrammar.y"
{ (yyval.ruleList) = 0; ;}
break;
case 50:
-
-/* Line 1455 of yacc.c */
#line 422 "../css/CSSGrammar.y"
{
(yyval.ruleList) = (yyvsp[(1) - (3)].ruleList);
@@ -2310,8 +2328,6 @@ yyreduce:
break;
case 60:
-
-/* Line 1455 of yacc.c */
#line 449 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createImportRule((yyvsp[(3) - (6)].string), (yyvsp[(5) - (6)].mediaList));
@@ -2319,8 +2335,6 @@ yyreduce:
break;
case 61:
-
-/* Line 1455 of yacc.c */
#line 452 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2328,8 +2342,6 @@ yyreduce:
break;
case 62:
-
-/* Line 1455 of yacc.c */
#line 455 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2337,8 +2349,6 @@ yyreduce:
break;
case 63:
-
-/* Line 1455 of yacc.c */
#line 458 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2346,8 +2356,6 @@ yyreduce:
break;
case 64:
-
-/* Line 1455 of yacc.c */
#line 464 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createVariablesRule((yyvsp[(3) - (7)].mediaList), true);
@@ -2355,8 +2363,6 @@ yyreduce:
break;
case 65:
-
-/* Line 1455 of yacc.c */
#line 468 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createVariablesRule((yyvsp[(3) - (7)].mediaList), false);
@@ -2364,8 +2370,6 @@ yyreduce:
break;
case 66:
-
-/* Line 1455 of yacc.c */
#line 474 "../css/CSSGrammar.y"
{
(yyval.mediaList) = static_cast<CSSParser*>(parser)->createMediaList();
@@ -2373,8 +2377,6 @@ yyreduce:
break;
case 67:
-
-/* Line 1455 of yacc.c */
#line 478 "../css/CSSGrammar.y"
{
(yyval.mediaList) = (yyvsp[(3) - (3)].mediaList);
@@ -2382,8 +2384,6 @@ yyreduce:
break;
case 68:
-
-/* Line 1455 of yacc.c */
#line 484 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (1)].boolean);
@@ -2391,8 +2391,6 @@ yyreduce:
break;
case 69:
-
-/* Line 1455 of yacc.c */
#line 487 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (2)].boolean);
@@ -2402,8 +2400,6 @@ yyreduce:
break;
case 70:
-
-/* Line 1455 of yacc.c */
#line 492 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (1)].boolean);
@@ -2411,8 +2407,6 @@ yyreduce:
break;
case 71:
-
-/* Line 1455 of yacc.c */
#line 495 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2420,8 +2414,6 @@ yyreduce:
break;
case 72:
-
-/* Line 1455 of yacc.c */
#line 498 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2429,8 +2421,6 @@ yyreduce:
break;
case 73:
-
-/* Line 1455 of yacc.c */
#line 501 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (2)].boolean);
@@ -2438,8 +2428,6 @@ yyreduce:
break;
case 74:
-
-/* Line 1455 of yacc.c */
#line 507 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (3)].boolean);
@@ -2447,8 +2435,6 @@ yyreduce:
break;
case 75:
-
-/* Line 1455 of yacc.c */
#line 510 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2456,8 +2442,6 @@ yyreduce:
break;
case 76:
-
-/* Line 1455 of yacc.c */
#line 513 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2465,8 +2449,6 @@ yyreduce:
break;
case 77:
-
-/* Line 1455 of yacc.c */
#line 516 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2474,8 +2456,6 @@ yyreduce:
break;
case 78:
-
-/* Line 1455 of yacc.c */
#line 519 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (4)].boolean);
@@ -2485,8 +2465,6 @@ yyreduce:
break;
case 79:
-
-/* Line 1455 of yacc.c */
#line 524 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (4)].boolean);
@@ -2494,8 +2472,6 @@ yyreduce:
break;
case 80:
-
-/* Line 1455 of yacc.c */
#line 527 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (6)].boolean);
@@ -2503,8 +2479,6 @@ yyreduce:
break;
case 81:
-
-/* Line 1455 of yacc.c */
#line 533 "../css/CSSGrammar.y"
{
(yyval.boolean) = static_cast<CSSParser*>(parser)->addVariable((yyvsp[(1) - (4)].string), (yyvsp[(4) - (4)].valueList));
@@ -2512,8 +2486,6 @@ yyreduce:
break;
case 82:
-
-/* Line 1455 of yacc.c */
#line 537 "../css/CSSGrammar.y"
{
(yyval.boolean) = static_cast<CSSParser*>(parser)->addVariableDeclarationBlock((yyvsp[(1) - (7)].string));
@@ -2521,8 +2493,6 @@ yyreduce:
break;
case 83:
-
-/* Line 1455 of yacc.c */
#line 541 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2530,8 +2500,6 @@ yyreduce:
break;
case 84:
-
-/* Line 1455 of yacc.c */
#line 545 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -2539,8 +2507,6 @@ yyreduce:
break;
case 85:
-
-/* Line 1455 of yacc.c */
#line 549 "../css/CSSGrammar.y"
{
/* @variables { varname: } Just reduce away this variable with no value. */
@@ -2549,8 +2515,6 @@ yyreduce:
break;
case 86:
-
-/* Line 1455 of yacc.c */
#line 554 "../css/CSSGrammar.y"
{
/* if we come across rules with invalid values like this case: @variables { varname: *; }, just discard the property/value pair */
@@ -2559,8 +2523,6 @@ yyreduce:
break;
case 87:
-
-/* Line 1455 of yacc.c */
#line 561 "../css/CSSGrammar.y"
{
(yyval.string) = (yyvsp[(1) - (2)].string);
@@ -2568,8 +2530,6 @@ yyreduce:
break;
case 88:
-
-/* Line 1455 of yacc.c */
#line 567 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2579,22 +2539,16 @@ yyreduce:
break;
case 91:
-
-/* Line 1455 of yacc.c */
#line 577 "../css/CSSGrammar.y"
{ (yyval.string).characters = 0; ;}
break;
case 92:
-
-/* Line 1455 of yacc.c */
#line 578 "../css/CSSGrammar.y"
{ (yyval.string) = (yyvsp[(1) - (2)].string); ;}
break;
case 95:
-
-/* Line 1455 of yacc.c */
#line 587 "../css/CSSGrammar.y"
{
(yyval.string) = (yyvsp[(1) - (2)].string);
@@ -2602,8 +2556,6 @@ yyreduce:
break;
case 96:
-
-/* Line 1455 of yacc.c */
#line 593 "../css/CSSGrammar.y"
{
(yyval.valueList) = 0;
@@ -2611,8 +2563,6 @@ yyreduce:
break;
case 97:
-
-/* Line 1455 of yacc.c */
#line 596 "../css/CSSGrammar.y"
{
(yyval.valueList) = (yyvsp[(3) - (4)].valueList);
@@ -2620,8 +2570,6 @@ yyreduce:
break;
case 98:
-
-/* Line 1455 of yacc.c */
#line 602 "../css/CSSGrammar.y"
{
(yyvsp[(3) - (7)].string).lower();
@@ -2630,8 +2578,6 @@ yyreduce:
break;
case 99:
-
-/* Line 1455 of yacc.c */
#line 609 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2641,8 +2587,6 @@ yyreduce:
break;
case 100:
-
-/* Line 1455 of yacc.c */
#line 614 "../css/CSSGrammar.y"
{
(yyval.mediaQueryExpList) = (yyvsp[(1) - (5)].mediaQueryExpList);
@@ -2651,8 +2595,6 @@ yyreduce:
break;
case 101:
-
-/* Line 1455 of yacc.c */
#line 621 "../css/CSSGrammar.y"
{
(yyval.mediaQueryExpList) = static_cast<CSSParser*>(parser)->createFloatingMediaQueryExpList();
@@ -2660,8 +2602,6 @@ yyreduce:
break;
case 102:
-
-/* Line 1455 of yacc.c */
#line 624 "../css/CSSGrammar.y"
{
(yyval.mediaQueryExpList) = (yyvsp[(3) - (3)].mediaQueryExpList);
@@ -2669,8 +2609,6 @@ yyreduce:
break;
case 103:
-
-/* Line 1455 of yacc.c */
#line 630 "../css/CSSGrammar.y"
{
(yyval.mediaQueryRestrictor) = MediaQuery::None;
@@ -2678,8 +2616,6 @@ yyreduce:
break;
case 104:
-
-/* Line 1455 of yacc.c */
#line 633 "../css/CSSGrammar.y"
{
(yyval.mediaQueryRestrictor) = MediaQuery::Only;
@@ -2687,8 +2623,6 @@ yyreduce:
break;
case 105:
-
-/* Line 1455 of yacc.c */
#line 636 "../css/CSSGrammar.y"
{
(yyval.mediaQueryRestrictor) = MediaQuery::Not;
@@ -2696,8 +2630,6 @@ yyreduce:
break;
case 106:
-
-/* Line 1455 of yacc.c */
#line 642 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2706,8 +2638,6 @@ yyreduce:
break;
case 107:
-
-/* Line 1455 of yacc.c */
#line 647 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2717,8 +2647,6 @@ yyreduce:
break;
case 108:
-
-/* Line 1455 of yacc.c */
#line 655 "../css/CSSGrammar.y"
{
(yyval.mediaList) = static_cast<CSSParser*>(parser)->createMediaList();
@@ -2726,8 +2654,6 @@ yyreduce:
break;
case 110:
-
-/* Line 1455 of yacc.c */
#line 662 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2737,8 +2663,6 @@ yyreduce:
break;
case 111:
-
-/* Line 1455 of yacc.c */
#line 667 "../css/CSSGrammar.y"
{
(yyval.mediaList) = (yyvsp[(1) - (4)].mediaList);
@@ -2748,8 +2672,6 @@ yyreduce:
break;
case 112:
-
-/* Line 1455 of yacc.c */
#line 672 "../css/CSSGrammar.y"
{
(yyval.mediaList) = 0;
@@ -2757,8 +2679,6 @@ yyreduce:
break;
case 113:
-
-/* Line 1455 of yacc.c */
#line 678 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createMediaRule((yyvsp[(3) - (7)].mediaList), (yyvsp[(6) - (7)].ruleList));
@@ -2766,8 +2686,6 @@ yyreduce:
break;
case 114:
-
-/* Line 1455 of yacc.c */
#line 681 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createMediaRule(0, (yyvsp[(5) - (6)].ruleList));
@@ -2775,8 +2693,6 @@ yyreduce:
break;
case 115:
-
-/* Line 1455 of yacc.c */
#line 687 "../css/CSSGrammar.y"
{
(yyval.string) = (yyvsp[(1) - (2)].string);
@@ -2784,8 +2700,6 @@ yyreduce:
break;
case 116:
-
-/* Line 1455 of yacc.c */
#line 693 "../css/CSSGrammar.y"
{
(yyval.rule) = (yyvsp[(7) - (8)].keyframesRule);
@@ -2794,15 +2708,11 @@ yyreduce:
break;
case 119:
-
-/* Line 1455 of yacc.c */
#line 705 "../css/CSSGrammar.y"
{ (yyval.keyframesRule) = static_cast<CSSParser*>(parser)->createKeyframesRule(); ;}
break;
case 120:
-
-/* Line 1455 of yacc.c */
#line 706 "../css/CSSGrammar.y"
{
(yyval.keyframesRule) = (yyvsp[(1) - (3)].keyframesRule);
@@ -2812,8 +2722,6 @@ yyreduce:
break;
case 121:
-
-/* Line 1455 of yacc.c */
#line 714 "../css/CSSGrammar.y"
{
(yyval.keyframeRule) = static_cast<CSSParser*>(parser)->createKeyframeRule((yyvsp[(1) - (6)].valueList));
@@ -2821,8 +2729,6 @@ yyreduce:
break;
case 122:
-
-/* Line 1455 of yacc.c */
#line 720 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2832,8 +2738,6 @@ yyreduce:
break;
case 123:
-
-/* Line 1455 of yacc.c */
#line 725 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -2844,15 +2748,11 @@ yyreduce:
break;
case 124:
-
-/* Line 1455 of yacc.c */
#line 734 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).isInt = false; (yyval.value).fValue = (yyvsp[(1) - (1)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_NUMBER; ;}
break;
case 125:
-
-/* Line 1455 of yacc.c */
#line 735 "../css/CSSGrammar.y"
{
(yyval.value).id = 0; (yyval.value).isInt = false; (yyval.value).unit = CSSPrimitiveValue::CSS_NUMBER;
@@ -2867,8 +2767,6 @@ yyreduce:
break;
case 126:
-
-/* Line 1455 of yacc.c */
#line 759 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2876,8 +2774,6 @@ yyreduce:
break;
case 127:
-
-/* Line 1455 of yacc.c */
#line 762 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2885,8 +2781,6 @@ yyreduce:
break;
case 128:
-
-/* Line 1455 of yacc.c */
#line 769 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createFontFaceRule();
@@ -2894,8 +2788,6 @@ yyreduce:
break;
case 129:
-
-/* Line 1455 of yacc.c */
#line 772 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2903,8 +2795,6 @@ yyreduce:
break;
case 130:
-
-/* Line 1455 of yacc.c */
#line 775 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -2912,43 +2802,31 @@ yyreduce:
break;
case 131:
-
-/* Line 1455 of yacc.c */
#line 781 "../css/CSSGrammar.y"
{ (yyval.relation) = CSSSelector::DirectAdjacent; ;}
break;
case 132:
-
-/* Line 1455 of yacc.c */
#line 782 "../css/CSSGrammar.y"
{ (yyval.relation) = CSSSelector::IndirectAdjacent; ;}
break;
case 133:
-
-/* Line 1455 of yacc.c */
#line 783 "../css/CSSGrammar.y"
{ (yyval.relation) = CSSSelector::Child; ;}
break;
case 134:
-
-/* Line 1455 of yacc.c */
#line 787 "../css/CSSGrammar.y"
{ (yyval.integer) = -1; ;}
break;
case 135:
-
-/* Line 1455 of yacc.c */
#line 788 "../css/CSSGrammar.y"
{ (yyval.integer) = 1; ;}
break;
case 136:
-
-/* Line 1455 of yacc.c */
#line 792 "../css/CSSGrammar.y"
{
(yyval.rule) = static_cast<CSSParser*>(parser)->createStyleRule((yyvsp[(1) - (5)].selectorList));
@@ -2956,8 +2834,6 @@ yyreduce:
break;
case 137:
-
-/* Line 1455 of yacc.c */
#line 798 "../css/CSSGrammar.y"
{
if ((yyvsp[(1) - (1)].selector)) {
@@ -2971,8 +2847,6 @@ yyreduce:
break;
case 138:
-
-/* Line 1455 of yacc.c */
#line 807 "../css/CSSGrammar.y"
{
if ((yyvsp[(1) - (4)].selectorList) && (yyvsp[(4) - (4)].selector)) {
@@ -2985,8 +2859,6 @@ yyreduce:
break;
case 139:
-
-/* Line 1455 of yacc.c */
#line 815 "../css/CSSGrammar.y"
{
(yyval.selectorList) = 0;
@@ -2994,8 +2866,6 @@ yyreduce:
break;
case 140:
-
-/* Line 1455 of yacc.c */
#line 821 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(1) - (2)].selector);
@@ -3003,8 +2873,6 @@ yyreduce:
break;
case 141:
-
-/* Line 1455 of yacc.c */
#line 827 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(1) - (1)].selector);
@@ -3012,8 +2880,6 @@ yyreduce:
break;
case 142:
-
-/* Line 1455 of yacc.c */
#line 831 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(1) - (1)].selector);
@@ -3021,8 +2887,6 @@ yyreduce:
break;
case 143:
-
-/* Line 1455 of yacc.c */
#line 835 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(2) - (2)].selector);
@@ -3042,8 +2906,6 @@ yyreduce:
break;
case 144:
-
-/* Line 1455 of yacc.c */
#line 850 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(3) - (3)].selector);
@@ -3068,8 +2930,6 @@ yyreduce:
break;
case 145:
-
-/* Line 1455 of yacc.c */
#line 870 "../css/CSSGrammar.y"
{
(yyval.selector) = 0;
@@ -3077,29 +2937,21 @@ yyreduce:
break;
case 146:
-
-/* Line 1455 of yacc.c */
#line 876 "../css/CSSGrammar.y"
{ (yyval.string).characters = 0; (yyval.string).length = 0; ;}
break;
case 147:
-
-/* Line 1455 of yacc.c */
#line 877 "../css/CSSGrammar.y"
{ static UChar star = '*'; (yyval.string).characters = &star; (yyval.string).length = 1; ;}
break;
case 148:
-
-/* Line 1455 of yacc.c */
#line 878 "../css/CSSGrammar.y"
{ (yyval.string) = (yyvsp[(1) - (2)].string); ;}
break;
case 149:
-
-/* Line 1455 of yacc.c */
#line 882 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3109,8 +2961,6 @@ yyreduce:
break;
case 150:
-
-/* Line 1455 of yacc.c */
#line 887 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(2) - (2)].selector);
@@ -3122,8 +2972,6 @@ yyreduce:
break;
case 151:
-
-/* Line 1455 of yacc.c */
#line 894 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(1) - (1)].selector);
@@ -3134,8 +2982,6 @@ yyreduce:
break;
case 152:
-
-/* Line 1455 of yacc.c */
#line 900 "../css/CSSGrammar.y"
{
AtomicString namespacePrefix = (yyvsp[(1) - (2)].string);
@@ -3150,8 +2996,6 @@ yyreduce:
break;
case 153:
-
-/* Line 1455 of yacc.c */
#line 910 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(3) - (3)].selector);
@@ -3168,8 +3012,6 @@ yyreduce:
break;
case 154:
-
-/* Line 1455 of yacc.c */
#line 922 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(2) - (2)].selector);
@@ -3184,8 +3026,6 @@ yyreduce:
break;
case 155:
-
-/* Line 1455 of yacc.c */
#line 935 "../css/CSSGrammar.y"
{
CSSParserString& str = (yyvsp[(1) - (1)].string);
@@ -3198,8 +3038,6 @@ yyreduce:
break;
case 156:
-
-/* Line 1455 of yacc.c */
#line 943 "../css/CSSGrammar.y"
{
static UChar star = '*';
@@ -3209,8 +3047,6 @@ yyreduce:
break;
case 157:
-
-/* Line 1455 of yacc.c */
#line 951 "../css/CSSGrammar.y"
{
(yyval.selector) = (yyvsp[(1) - (1)].selector);
@@ -3218,8 +3054,6 @@ yyreduce:
break;
case 158:
-
-/* Line 1455 of yacc.c */
#line 954 "../css/CSSGrammar.y"
{
if (!(yyvsp[(2) - (2)].selector))
@@ -3237,8 +3071,6 @@ yyreduce:
break;
case 159:
-
-/* Line 1455 of yacc.c */
#line 967 "../css/CSSGrammar.y"
{
(yyval.selector) = 0;
@@ -3246,8 +3078,6 @@ yyreduce:
break;
case 160:
-
-/* Line 1455 of yacc.c */
#line 973 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3260,8 +3090,6 @@ yyreduce:
break;
case 161:
-
-/* Line 1455 of yacc.c */
#line 981 "../css/CSSGrammar.y"
{
if ((yyvsp[(1) - (1)].string).characters[0] >= '0' && (yyvsp[(1) - (1)].string).characters[0] <= '9') {
@@ -3278,8 +3106,6 @@ yyreduce:
break;
case 165:
-
-/* Line 1455 of yacc.c */
#line 999 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3292,8 +3118,6 @@ yyreduce:
break;
case 166:
-
-/* Line 1455 of yacc.c */
#line 1010 "../css/CSSGrammar.y"
{
CSSParserString& str = (yyvsp[(1) - (2)].string);
@@ -3306,8 +3130,6 @@ yyreduce:
break;
case 167:
-
-/* Line 1455 of yacc.c */
#line 1021 "../css/CSSGrammar.y"
{
(yyval.selector) = static_cast<CSSParser*>(parser)->createFloatingSelector();
@@ -3317,8 +3139,6 @@ yyreduce:
break;
case 168:
-
-/* Line 1455 of yacc.c */
#line 1026 "../css/CSSGrammar.y"
{
(yyval.selector) = static_cast<CSSParser*>(parser)->createFloatingSelector();
@@ -3329,8 +3149,6 @@ yyreduce:
break;
case 169:
-
-/* Line 1455 of yacc.c */
#line 1032 "../css/CSSGrammar.y"
{
AtomicString namespacePrefix = (yyvsp[(3) - (5)].string);
@@ -3343,8 +3161,6 @@ yyreduce:
break;
case 170:
-
-/* Line 1455 of yacc.c */
#line 1040 "../css/CSSGrammar.y"
{
AtomicString namespacePrefix = (yyvsp[(3) - (9)].string);
@@ -3358,8 +3174,6 @@ yyreduce:
break;
case 171:
-
-/* Line 1455 of yacc.c */
#line 1052 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::Exact;
@@ -3367,8 +3181,6 @@ yyreduce:
break;
case 172:
-
-/* Line 1455 of yacc.c */
#line 1055 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::List;
@@ -3376,8 +3188,6 @@ yyreduce:
break;
case 173:
-
-/* Line 1455 of yacc.c */
#line 1058 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::Hyphen;
@@ -3385,8 +3195,6 @@ yyreduce:
break;
case 174:
-
-/* Line 1455 of yacc.c */
#line 1061 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::Begin;
@@ -3394,8 +3202,6 @@ yyreduce:
break;
case 175:
-
-/* Line 1455 of yacc.c */
#line 1064 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::End;
@@ -3403,8 +3209,6 @@ yyreduce:
break;
case 176:
-
-/* Line 1455 of yacc.c */
#line 1067 "../css/CSSGrammar.y"
{
(yyval.integer) = CSSSelector::Contain;
@@ -3412,8 +3216,6 @@ yyreduce:
break;
case 179:
-
-/* Line 1455 of yacc.c */
#line 1078 "../css/CSSGrammar.y"
{
(yyval.selector) = static_cast<CSSParser*>(parser)->createFloatingSelector();
@@ -3448,8 +3250,6 @@ yyreduce:
break;
case 180:
-
-/* Line 1455 of yacc.c */
#line 1108 "../css/CSSGrammar.y"
{
(yyval.selector) = static_cast<CSSParser*>(parser)->createFloatingSelector();
@@ -3473,8 +3273,6 @@ yyreduce:
break;
case 181:
-
-/* Line 1455 of yacc.c */
#line 1128 "../css/CSSGrammar.y"
{
CSSParser *p = static_cast<CSSParser*>(parser);
@@ -3496,8 +3294,6 @@ yyreduce:
break;
case 182:
-
-/* Line 1455 of yacc.c */
#line 1146 "../css/CSSGrammar.y"
{
CSSParser *p = static_cast<CSSParser*>(parser);
@@ -3519,8 +3315,6 @@ yyreduce:
break;
case 183:
-
-/* Line 1455 of yacc.c */
#line 1164 "../css/CSSGrammar.y"
{
CSSParser *p = static_cast<CSSParser*>(parser);
@@ -3543,8 +3337,6 @@ yyreduce:
break;
case 184:
-
-/* Line 1455 of yacc.c */
#line 1183 "../css/CSSGrammar.y"
{
if (!(yyvsp[(4) - (6)].selector) || (yyvsp[(4) - (6)].selector)->simpleSelector() || (yyvsp[(4) - (6)].selector)->tagHistory())
@@ -3561,8 +3353,6 @@ yyreduce:
break;
case 185:
-
-/* Line 1455 of yacc.c */
#line 1198 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (1)].boolean);
@@ -3570,8 +3360,6 @@ yyreduce:
break;
case 186:
-
-/* Line 1455 of yacc.c */
#line 1201 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (2)].boolean);
@@ -3581,8 +3369,6 @@ yyreduce:
break;
case 187:
-
-/* Line 1455 of yacc.c */
#line 1206 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (1)].boolean);
@@ -3590,8 +3376,6 @@ yyreduce:
break;
case 188:
-
-/* Line 1455 of yacc.c */
#line 1209 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3599,8 +3383,6 @@ yyreduce:
break;
case 189:
-
-/* Line 1455 of yacc.c */
#line 1212 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3608,8 +3390,6 @@ yyreduce:
break;
case 190:
-
-/* Line 1455 of yacc.c */
#line 1215 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (2)].boolean);
@@ -3617,8 +3397,6 @@ yyreduce:
break;
case 191:
-
-/* Line 1455 of yacc.c */
#line 1218 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (2)].boolean);
@@ -3626,8 +3404,6 @@ yyreduce:
break;
case 192:
-
-/* Line 1455 of yacc.c */
#line 1224 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (3)].boolean);
@@ -3635,8 +3411,6 @@ yyreduce:
break;
case 193:
-
-/* Line 1455 of yacc.c */
#line 1227 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3644,8 +3418,6 @@ yyreduce:
break;
case 194:
-
-/* Line 1455 of yacc.c */
#line 1230 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3653,8 +3425,6 @@ yyreduce:
break;
case 195:
-
-/* Line 1455 of yacc.c */
#line 1233 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3662,8 +3432,6 @@ yyreduce:
break;
case 196:
-
-/* Line 1455 of yacc.c */
#line 1236 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (4)].boolean);
@@ -3673,8 +3441,6 @@ yyreduce:
break;
case 197:
-
-/* Line 1455 of yacc.c */
#line 1241 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (4)].boolean);
@@ -3682,8 +3448,6 @@ yyreduce:
break;
case 198:
-
-/* Line 1455 of yacc.c */
#line 1244 "../css/CSSGrammar.y"
{
(yyval.boolean) = (yyvsp[(1) - (6)].boolean);
@@ -3691,8 +3455,6 @@ yyreduce:
break;
case 199:
-
-/* Line 1455 of yacc.c */
#line 1250 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3710,8 +3472,6 @@ yyreduce:
break;
case 200:
-
-/* Line 1455 of yacc.c */
#line 1264 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3727,8 +3487,6 @@ yyreduce:
break;
case 201:
-
-/* Line 1455 of yacc.c */
#line 1276 "../css/CSSGrammar.y"
{
(yyval.boolean) = false;
@@ -3736,8 +3494,6 @@ yyreduce:
break;
case 202:
-
-/* Line 1455 of yacc.c */
#line 1280 "../css/CSSGrammar.y"
{
/* The default movable type template has letter-spacing: .none; Handle this by looking for
@@ -3748,8 +3504,6 @@ yyreduce:
break;
case 203:
-
-/* Line 1455 of yacc.c */
#line 1287 "../css/CSSGrammar.y"
{
/* When we encounter something like p {color: red !important fail;} we should drop the declaration */
@@ -3758,8 +3512,6 @@ yyreduce:
break;
case 204:
-
-/* Line 1455 of yacc.c */
#line 1292 "../css/CSSGrammar.y"
{
/* Handle this case: div { text-align: center; !important } Just reduce away the stray !important. */
@@ -3768,8 +3520,6 @@ yyreduce:
break;
case 205:
-
-/* Line 1455 of yacc.c */
#line 1297 "../css/CSSGrammar.y"
{
/* div { font-family: } Just reduce away this property with no value. */
@@ -3778,8 +3528,6 @@ yyreduce:
break;
case 206:
-
-/* Line 1455 of yacc.c */
#line 1302 "../css/CSSGrammar.y"
{
/* if we come across rules with invalid values like this case: p { weight: *; }, just discard the rule */
@@ -3788,8 +3536,6 @@ yyreduce:
break;
case 207:
-
-/* Line 1455 of yacc.c */
#line 1307 "../css/CSSGrammar.y"
{
/* if we come across: div { color{;color:maroon} }, ignore everything within curly brackets */
@@ -3798,8 +3544,6 @@ yyreduce:
break;
case 208:
-
-/* Line 1455 of yacc.c */
#line 1314 "../css/CSSGrammar.y"
{
(yyval.integer) = cssPropertyID((yyvsp[(1) - (2)].string));
@@ -3807,22 +3551,16 @@ yyreduce:
break;
case 209:
-
-/* Line 1455 of yacc.c */
#line 1320 "../css/CSSGrammar.y"
{ (yyval.boolean) = true; ;}
break;
case 210:
-
-/* Line 1455 of yacc.c */
#line 1321 "../css/CSSGrammar.y"
{ (yyval.boolean) = false; ;}
break;
case 211:
-
-/* Line 1455 of yacc.c */
#line 1325 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3832,8 +3570,6 @@ yyreduce:
break;
case 212:
-
-/* Line 1455 of yacc.c */
#line 1330 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -3852,8 +3588,6 @@ yyreduce:
break;
case 213:
-
-/* Line 1455 of yacc.c */
#line 1344 "../css/CSSGrammar.y"
{
(yyval.valueList) = 0;
@@ -3861,8 +3595,6 @@ yyreduce:
break;
case 214:
-
-/* Line 1455 of yacc.c */
#line 1350 "../css/CSSGrammar.y"
{
(yyval.character) = '/';
@@ -3870,8 +3602,6 @@ yyreduce:
break;
case 215:
-
-/* Line 1455 of yacc.c */
#line 1353 "../css/CSSGrammar.y"
{
(yyval.character) = ',';
@@ -3879,8 +3609,6 @@ yyreduce:
break;
case 216:
-
-/* Line 1455 of yacc.c */
#line 1356 "../css/CSSGrammar.y"
{
(yyval.character) = 0;
@@ -3888,29 +3616,21 @@ yyreduce:
break;
case 217:
-
-/* Line 1455 of yacc.c */
#line 1362 "../css/CSSGrammar.y"
{ (yyval.value) = (yyvsp[(1) - (1)].value); ;}
break;
case 218:
-
-/* Line 1455 of yacc.c */
#line 1363 "../css/CSSGrammar.y"
{ (yyval.value) = (yyvsp[(2) - (2)].value); (yyval.value).fValue *= (yyvsp[(1) - (2)].integer); ;}
break;
case 219:
-
-/* Line 1455 of yacc.c */
#line 1364 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(1) - (2)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_STRING; ;}
break;
case 220:
-
-/* Line 1455 of yacc.c */
#line 1365 "../css/CSSGrammar.y"
{
(yyval.value).id = cssValueKeywordID((yyvsp[(1) - (2)].string));
@@ -3920,50 +3640,36 @@ yyreduce:
break;
case 221:
-
-/* Line 1455 of yacc.c */
#line 1371 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(1) - (2)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_DIMENSION; ;}
break;
case 222:
-
-/* Line 1455 of yacc.c */
#line 1372 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(2) - (3)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_DIMENSION; ;}
break;
case 223:
-
-/* Line 1455 of yacc.c */
#line 1373 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(1) - (2)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_URI; ;}
break;
case 224:
-
-/* Line 1455 of yacc.c */
#line 1374 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(1) - (2)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_UNICODE_RANGE; ;}
break;
case 225:
-
-/* Line 1455 of yacc.c */
#line 1375 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = (yyvsp[(1) - (1)].string); (yyval.value).unit = CSSPrimitiveValue::CSS_PARSER_HEXCOLOR; ;}
break;
case 226:
-
-/* Line 1455 of yacc.c */
#line 1376 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).string = CSSParserString(); (yyval.value).unit = CSSPrimitiveValue::CSS_PARSER_HEXCOLOR; ;}
break;
case 227:
-
-/* Line 1455 of yacc.c */
#line 1378 "../css/CSSGrammar.y"
{
(yyval.value) = (yyvsp[(1) - (1)].value);
@@ -3971,8 +3677,6 @@ yyreduce:
break;
case 228:
-
-/* Line 1455 of yacc.c */
#line 1381 "../css/CSSGrammar.y"
{
(yyval.value) = (yyvsp[(1) - (2)].value);
@@ -3980,8 +3684,6 @@ yyreduce:
break;
case 229:
-
-/* Line 1455 of yacc.c */
#line 1384 "../css/CSSGrammar.y"
{ /* Handle width: %; */
(yyval.value).id = 0; (yyval.value).unit = 0;
@@ -3989,148 +3691,106 @@ yyreduce:
break;
case 230:
-
-/* Line 1455 of yacc.c */
#line 1390 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).isInt = true; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_NUMBER; ;}
break;
case 231:
-
-/* Line 1455 of yacc.c */
#line 1391 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).isInt = false; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_NUMBER; ;}
break;
case 232:
-
-/* Line 1455 of yacc.c */
#line 1392 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_PERCENTAGE; ;}
break;
case 233:
-
-/* Line 1455 of yacc.c */
#line 1393 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_PX; ;}
break;
case 234:
-
-/* Line 1455 of yacc.c */
#line 1394 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_CM; ;}
break;
case 235:
-
-/* Line 1455 of yacc.c */
#line 1395 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_MM; ;}
break;
case 236:
-
-/* Line 1455 of yacc.c */
#line 1396 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_IN; ;}
break;
case 237:
-
-/* Line 1455 of yacc.c */
#line 1397 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_PT; ;}
break;
case 238:
-
-/* Line 1455 of yacc.c */
#line 1398 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_PC; ;}
break;
case 239:
-
-/* Line 1455 of yacc.c */
#line 1399 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_DEG; ;}
break;
case 240:
-
-/* Line 1455 of yacc.c */
#line 1400 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_RAD; ;}
break;
case 241:
-
-/* Line 1455 of yacc.c */
#line 1401 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_GRAD; ;}
break;
case 242:
-
-/* Line 1455 of yacc.c */
#line 1402 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_TURN; ;}
break;
case 243:
-
-/* Line 1455 of yacc.c */
#line 1403 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_MS; ;}
break;
case 244:
-
-/* Line 1455 of yacc.c */
#line 1404 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_S; ;}
break;
case 245:
-
-/* Line 1455 of yacc.c */
#line 1405 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_HZ; ;}
break;
case 246:
-
-/* Line 1455 of yacc.c */
#line 1406 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_KHZ; ;}
break;
case 247:
-
-/* Line 1455 of yacc.c */
#line 1407 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_EMS; ;}
break;
case 248:
-
-/* Line 1455 of yacc.c */
#line 1408 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSParserValue::Q_EMS; ;}
break;
case 249:
-
-/* Line 1455 of yacc.c */
#line 1409 "../css/CSSGrammar.y"
{ (yyval.value).id = 0; (yyval.value).fValue = (yyvsp[(1) - (2)].number); (yyval.value).unit = CSSPrimitiveValue::CSS_EXS; ;}
break;
case 250:
-
-/* Line 1455 of yacc.c */
#line 1413 "../css/CSSGrammar.y"
{
(yyval.value).id = 0;
@@ -4140,8 +3800,6 @@ yyreduce:
break;
case 251:
-
-/* Line 1455 of yacc.c */
#line 1421 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -4155,8 +3813,6 @@ yyreduce:
break;
case 252:
-
-/* Line 1455 of yacc.c */
#line 1430 "../css/CSSGrammar.y"
{
CSSParser* p = static_cast<CSSParser*>(parser);
@@ -4170,22 +3826,16 @@ yyreduce:
break;
case 253:
-
-/* Line 1455 of yacc.c */
#line 1446 "../css/CSSGrammar.y"
{ (yyval.string) = (yyvsp[(1) - (2)].string); ;}
break;
case 254:
-
-/* Line 1455 of yacc.c */
#line 1447 "../css/CSSGrammar.y"
{ (yyval.string) = (yyvsp[(1) - (2)].string); ;}
break;
case 255:
-
-/* Line 1455 of yacc.c */
#line 1454 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4193,8 +3843,6 @@ yyreduce:
break;
case 256:
-
-/* Line 1455 of yacc.c */
#line 1457 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4202,8 +3850,6 @@ yyreduce:
break;
case 257:
-
-/* Line 1455 of yacc.c */
#line 1463 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4211,8 +3857,6 @@ yyreduce:
break;
case 258:
-
-/* Line 1455 of yacc.c */
#line 1466 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4220,8 +3864,6 @@ yyreduce:
break;
case 261:
-
-/* Line 1455 of yacc.c */
#line 1477 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4229,8 +3871,6 @@ yyreduce:
break;
case 262:
-
-/* Line 1455 of yacc.c */
#line 1483 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4238,8 +3878,6 @@ yyreduce:
break;
case 263:
-
-/* Line 1455 of yacc.c */
#line 1489 "../css/CSSGrammar.y"
{
(yyval.rule) = 0;
@@ -4247,9 +3885,8 @@ yyreduce:
break;
-
-/* Line 1455 of yacc.c */
-#line 4253 "WebCore/tmp/../generated/CSSGrammar.tab.c"
+/* Line 1267 of yacc.c. */
+#line 3890 "WebCore/tmp/../generated/CSSGrammar.tab.c"
default: break;
}
YY_SYMBOL_PRINT ("-> $$ =", yyr1[yyn], &yyval, &yyloc);
@@ -4260,6 +3897,7 @@ yyreduce:
*++yyvsp = yyval;
+
/* Now `shift' the result of the reduction. Determine what state
that goes to, based on the state we popped back to and the rule
number reduced by. */
@@ -4324,7 +3962,7 @@ yyerrlab:
if (yyerrstatus == 3)
{
- /* If just tried and failed to reuse lookahead token after an
+ /* If just tried and failed to reuse look-ahead token after an
error, discard it. */
if (yychar <= YYEOF)
@@ -4341,7 +3979,7 @@ yyerrlab:
}
}
- /* Else will try to reuse lookahead token after shifting the error
+ /* Else will try to reuse look-ahead token after shifting the error
token. */
goto yyerrlab1;
@@ -4398,6 +4036,9 @@ yyerrlab1:
YY_STACK_PRINT (yyss, yyssp);
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
*++yyvsp = yylval;
@@ -4422,7 +4063,7 @@ yyabortlab:
yyresult = 1;
goto yyreturn;
-#if !defined(yyoverflow) || YYERROR_VERBOSE
+#ifndef yyoverflow
/*-------------------------------------------------.
| yyexhaustedlab -- memory exhaustion comes here. |
`-------------------------------------------------*/
@@ -4433,7 +4074,7 @@ yyexhaustedlab:
#endif
yyreturn:
- if (yychar != YYEMPTY)
+ if (yychar != YYEOF && yychar != YYEMPTY)
yydestruct ("Cleanup: discarding lookahead",
yytoken, &yylval);
/* Do not reclaim the symbols of the rule which action triggered
@@ -4459,8 +4100,6 @@ yyreturn:
}
-
-/* Line 1675 of yacc.c */
#line 1516 "../css/CSSGrammar.y"
diff --git a/src/3rdparty/webkit/WebCore/generated/CSSGrammar.h b/src/3rdparty/webkit/WebCore/generated/CSSGrammar.h
index 4223680..61ba1f5 100644
--- a/src/3rdparty/webkit/WebCore/generated/CSSGrammar.h
+++ b/src/3rdparty/webkit/WebCore/generated/CSSGrammar.h
@@ -1,25 +1,26 @@
#ifndef CSSGRAMMAR_H
#define CSSGRAMMAR_H
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton interface for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -30,11 +31,10 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
-
/* Tokens. */
#ifndef YYTOKENTYPE
# define YYTOKENTYPE
@@ -106,16 +106,78 @@
VARCALL = 319
};
#endif
+/* Tokens. */
+#define TOKEN_EOF 0
+#define LOWEST_PREC 258
+#define UNIMPORTANT_TOK 259
+#define WHITESPACE 260
+#define SGML_CD 261
+#define INCLUDES 262
+#define DASHMATCH 263
+#define BEGINSWITH 264
+#define ENDSWITH 265
+#define CONTAINS 266
+#define STRING 267
+#define IDENT 268
+#define NTH 269
+#define HEX 270
+#define IDSEL 271
+#define IMPORT_SYM 272
+#define PAGE_SYM 273
+#define MEDIA_SYM 274
+#define FONT_FACE_SYM 275
+#define CHARSET_SYM 276
+#define NAMESPACE_SYM 277
+#define WEBKIT_RULE_SYM 278
+#define WEBKIT_DECLS_SYM 279
+#define WEBKIT_KEYFRAME_RULE_SYM 280
+#define WEBKIT_KEYFRAMES_SYM 281
+#define WEBKIT_VALUE_SYM 282
+#define WEBKIT_MEDIAQUERY_SYM 283
+#define WEBKIT_SELECTOR_SYM 284
+#define WEBKIT_VARIABLES_SYM 285
+#define WEBKIT_DEFINE_SYM 286
+#define VARIABLES_FOR 287
+#define WEBKIT_VARIABLES_DECLS_SYM 288
+#define ATKEYWORD 289
+#define IMPORTANT_SYM 290
+#define MEDIA_ONLY 291
+#define MEDIA_NOT 292
+#define MEDIA_AND 293
+#define QEMS 294
+#define EMS 295
+#define EXS 296
+#define PXS 297
+#define CMS 298
+#define MMS 299
+#define INS 300
+#define PTS 301
+#define PCS 302
+#define DEGS 303
+#define RADS 304
+#define GRADS 305
+#define TURNS 306
+#define MSECS 307
+#define SECS 308
+#define HERZ 309
+#define KHERZ 310
+#define DIMEN 311
+#define PERCENTAGE 312
+#define FLOATTOKEN 313
+#define INTEGER 314
+#define URI 315
+#define FUNCTION 316
+#define NOTFUNCTION 317
+#define UNICODERANGE 318
+#define VARCALL 319
+
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 1676 of yacc.c */
#line 58 "../css/CSSGrammar.y"
-
+{
bool boolean;
char character;
int integer;
@@ -137,18 +199,15 @@ typedef union YYSTYPE
WebKitCSSKeyframeRule* keyframeRule;
WebKitCSSKeyframesRule* keyframesRule;
float val;
-
-
-
-/* Line 1676 of yacc.c */
-#line 143 "WebCore/tmp/../generated/CSSGrammar.tab.h"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 1489 of yacc.c. */
+#line 203 "WebCore/tmp/../generated/CSSGrammar.tab.h"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
-
#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/DatePrototype.lut.h b/src/3rdparty/webkit/WebCore/generated/DatePrototype.lut.h
index 80dc604..3016f9e 100644
--- a/src/3rdparty/webkit/WebCore/generated/DatePrototype.lut.h
+++ b/src/3rdparty/webkit/WebCore/generated/DatePrototype.lut.h
@@ -4,8 +4,9 @@
namespace JSC {
-static const struct HashTableValue dateTableValues[45] = {
+static const struct HashTableValue dateTableValues[47] = {
{ "toString", DontEnum|Function, (intptr_t)dateProtoFuncToString, (intptr_t)0 },
+ { "toISOString", DontEnum|Function, (intptr_t)dateProtoFuncToISOString, (intptr_t)0 },
{ "toUTCString", DontEnum|Function, (intptr_t)dateProtoFuncToUTCString, (intptr_t)0 },
{ "toDateString", DontEnum|Function, (intptr_t)dateProtoFuncToDateString, (intptr_t)0 },
{ "toTimeString", DontEnum|Function, (intptr_t)dateProtoFuncToTimeString, (intptr_t)0 },
@@ -49,6 +50,7 @@ static const struct HashTableValue dateTableValues[45] = {
{ "setUTCFullYear", DontEnum|Function, (intptr_t)dateProtoFuncSetUTCFullYear, (intptr_t)3 },
{ "setYear", DontEnum|Function, (intptr_t)dateProtoFuncSetYear, (intptr_t)1 },
{ "getYear", DontEnum|Function, (intptr_t)dateProtoFuncGetYear, (intptr_t)0 },
+ { "toJSON", DontEnum|Function, (intptr_t)dateProtoFuncToJSON, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
diff --git a/src/3rdparty/webkit/WebCore/generated/Grammar.cpp b/src/3rdparty/webkit/WebCore/generated/Grammar.cpp
index c186e47..4ad3078 100644
--- a/src/3rdparty/webkit/WebCore/generated/Grammar.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/Grammar.cpp
@@ -1,23 +1,24 @@
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton implementation for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -28,7 +29,7 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
@@ -46,7 +47,7 @@
#define YYBISON 1
/* Bison version. */
-#define YYBISON_VERSION "2.4.1"
+#define YYBISON_VERSION "2.3"
/* Skeleton name. */
#define YYSKELETON_NAME "yacc.c"
@@ -54,28 +55,159 @@
/* Pure parsers. */
#define YYPURE 1
-/* Push parsers. */
-#define YYPUSH 0
-
-/* Pull parsers. */
-#define YYPULL 1
-
/* Using locations. */
#define YYLSP_NEEDED 1
/* Substitute the variable and function names. */
-#define yyparse jscyyparse
-#define yylex jscyylex
-#define yyerror jscyyerror
-#define yylval jscyylval
-#define yychar jscyychar
-#define yydebug jscyydebug
-#define yynerrs jscyynerrs
-#define yylloc jscyylloc
+#define yyparse jscyyparse
+#define yylex jscyylex
+#define yyerror jscyyerror
+#define yylval jscyylval
+#define yychar jscyychar
+#define yydebug jscyydebug
+#define yynerrs jscyynerrs
+#define yylloc jscyylloc
+
+/* Tokens. */
+#ifndef YYTOKENTYPE
+# define YYTOKENTYPE
+ /* Put the tokens into the symbol table, so that GDB and other debuggers
+ know about them. */
+ enum yytokentype {
+ NULLTOKEN = 258,
+ TRUETOKEN = 259,
+ FALSETOKEN = 260,
+ BREAK = 261,
+ CASE = 262,
+ DEFAULT = 263,
+ FOR = 264,
+ NEW = 265,
+ VAR = 266,
+ CONSTTOKEN = 267,
+ CONTINUE = 268,
+ FUNCTION = 269,
+ RETURN = 270,
+ VOIDTOKEN = 271,
+ DELETETOKEN = 272,
+ IF = 273,
+ THISTOKEN = 274,
+ DO = 275,
+ WHILE = 276,
+ INTOKEN = 277,
+ INSTANCEOF = 278,
+ TYPEOF = 279,
+ SWITCH = 280,
+ WITH = 281,
+ RESERVED = 282,
+ THROW = 283,
+ TRY = 284,
+ CATCH = 285,
+ FINALLY = 286,
+ DEBUGGER = 287,
+ IF_WITHOUT_ELSE = 288,
+ ELSE = 289,
+ EQEQ = 290,
+ NE = 291,
+ STREQ = 292,
+ STRNEQ = 293,
+ LE = 294,
+ GE = 295,
+ OR = 296,
+ AND = 297,
+ PLUSPLUS = 298,
+ MINUSMINUS = 299,
+ LSHIFT = 300,
+ RSHIFT = 301,
+ URSHIFT = 302,
+ PLUSEQUAL = 303,
+ MINUSEQUAL = 304,
+ MULTEQUAL = 305,
+ DIVEQUAL = 306,
+ LSHIFTEQUAL = 307,
+ RSHIFTEQUAL = 308,
+ URSHIFTEQUAL = 309,
+ ANDEQUAL = 310,
+ MODEQUAL = 311,
+ XOREQUAL = 312,
+ OREQUAL = 313,
+ OPENBRACE = 314,
+ CLOSEBRACE = 315,
+ NUMBER = 316,
+ IDENT = 317,
+ STRING = 318,
+ AUTOPLUSPLUS = 319,
+ AUTOMINUSMINUS = 320
+ };
+#endif
+/* Tokens. */
+#define NULLTOKEN 258
+#define TRUETOKEN 259
+#define FALSETOKEN 260
+#define BREAK 261
+#define CASE 262
+#define DEFAULT 263
+#define FOR 264
+#define NEW 265
+#define VAR 266
+#define CONSTTOKEN 267
+#define CONTINUE 268
+#define FUNCTION 269
+#define RETURN 270
+#define VOIDTOKEN 271
+#define DELETETOKEN 272
+#define IF 273
+#define THISTOKEN 274
+#define DO 275
+#define WHILE 276
+#define INTOKEN 277
+#define INSTANCEOF 278
+#define TYPEOF 279
+#define SWITCH 280
+#define WITH 281
+#define RESERVED 282
+#define THROW 283
+#define TRY 284
+#define CATCH 285
+#define FINALLY 286
+#define DEBUGGER 287
+#define IF_WITHOUT_ELSE 288
+#define ELSE 289
+#define EQEQ 290
+#define NE 291
+#define STREQ 292
+#define STRNEQ 293
+#define LE 294
+#define GE 295
+#define OR 296
+#define AND 297
+#define PLUSPLUS 298
+#define MINUSMINUS 299
+#define LSHIFT 300
+#define RSHIFT 301
+#define URSHIFT 302
+#define PLUSEQUAL 303
+#define MINUSEQUAL 304
+#define MULTEQUAL 305
+#define DIVEQUAL 306
+#define LSHIFTEQUAL 307
+#define RSHIFTEQUAL 308
+#define URSHIFTEQUAL 309
+#define ANDEQUAL 310
+#define MODEQUAL 311
+#define XOREQUAL 312
+#define OREQUAL 313
+#define OPENBRACE 314
+#define CLOSEBRACE 315
+#define NUMBER 316
+#define IDENT 317
+#define STRING 318
+#define AUTOPLUSPLUS 319
+#define AUTOMINUSMINUS 320
+
-/* Copy the first part of user declarations. */
-/* Line 189 of yacc.c */
+
+/* Copy the first part of user declarations. */
#line 3 "../../JavaScriptCore/parser/Grammar.y"
@@ -157,7 +289,7 @@ static ExpressionNode* makeSubNode(void*, ExpressionNode*, ExpressionNode*, bool
static ExpressionNode* makeLeftShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static ExpressionNode* makeRightShiftNode(void*, ExpressionNode*, ExpressionNode*, bool rightHasAssignments);
static StatementNode* makeVarStatementNode(void*, ExpressionNode*);
-static ExpressionNode* combineVarInitializers(void*, ExpressionNode* list, AssignResolveNode* init);
+static ExpressionNode* combineCommaNodes(void*, ExpressionNode* list, ExpressionNode* init);
#if COMPILER(MSVC)
@@ -231,9 +363,6 @@ static inline void appendToVarDeclarationList(void* globalPtr, ParserArenaData<D
-/* Line 189 of yacc.c */
-#line 236 "WebCore/tmp/../generated/Grammar.tab.c"
-
/* Enabling traces. */
#ifndef YYDEBUG
# define YYDEBUG 0
@@ -252,88 +381,10 @@ static inline void appendToVarDeclarationList(void* globalPtr, ParserArenaData<D
# define YYTOKEN_TABLE 0
#endif
-
-/* Tokens. */
-#ifndef YYTOKENTYPE
-# define YYTOKENTYPE
- /* Put the tokens into the symbol table, so that GDB and other debuggers
- know about them. */
- enum yytokentype {
- NULLTOKEN = 258,
- TRUETOKEN = 259,
- FALSETOKEN = 260,
- BREAK = 261,
- CASE = 262,
- DEFAULT = 263,
- FOR = 264,
- NEW = 265,
- VAR = 266,
- CONSTTOKEN = 267,
- CONTINUE = 268,
- FUNCTION = 269,
- RETURN = 270,
- VOIDTOKEN = 271,
- DELETETOKEN = 272,
- IF = 273,
- THISTOKEN = 274,
- DO = 275,
- WHILE = 276,
- INTOKEN = 277,
- INSTANCEOF = 278,
- TYPEOF = 279,
- SWITCH = 280,
- WITH = 281,
- RESERVED = 282,
- THROW = 283,
- TRY = 284,
- CATCH = 285,
- FINALLY = 286,
- DEBUGGER = 287,
- IF_WITHOUT_ELSE = 288,
- ELSE = 289,
- EQEQ = 290,
- NE = 291,
- STREQ = 292,
- STRNEQ = 293,
- LE = 294,
- GE = 295,
- OR = 296,
- AND = 297,
- PLUSPLUS = 298,
- MINUSMINUS = 299,
- LSHIFT = 300,
- RSHIFT = 301,
- URSHIFT = 302,
- PLUSEQUAL = 303,
- MINUSEQUAL = 304,
- MULTEQUAL = 305,
- DIVEQUAL = 306,
- LSHIFTEQUAL = 307,
- RSHIFTEQUAL = 308,
- URSHIFTEQUAL = 309,
- ANDEQUAL = 310,
- MODEQUAL = 311,
- XOREQUAL = 312,
- OREQUAL = 313,
- OPENBRACE = 314,
- CLOSEBRACE = 315,
- NUMBER = 316,
- IDENT = 317,
- STRING = 318,
- AUTOPLUSPLUS = 319,
- AUTOMINUSMINUS = 320
- };
-#endif
-
-
-
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 214 of yacc.c */
#line 157 "../../JavaScriptCore/parser/Grammar.y"
-
+{
int intValue;
double doubleValue;
Identifier* ident;
@@ -363,15 +414,13 @@ typedef union YYSTYPE
ParameterListInfo parameterList;
Operator op;
-
-
-
-/* Line 214 of yacc.c */
-#line 371 "WebCore/tmp/../generated/Grammar.tab.c"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 187 of yacc.c. */
+#line 420 "WebCore/tmp/../generated/Grammar.tab.c"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
#if ! defined YYLTYPE && ! defined YYLTYPE_IS_DECLARED
@@ -391,8 +440,8 @@ typedef struct YYLTYPE
/* Copy the second part of user declarations. */
-/* Line 264 of yacc.c */
-#line 396 "WebCore/tmp/../generated/Grammar.tab.c"
+/* Line 216 of yacc.c. */
+#line 445 "WebCore/tmp/../generated/Grammar.tab.c"
#ifdef short
# undef short
@@ -467,14 +516,14 @@ typedef short int yytype_int16;
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static int
-YYID (int yyi)
+YYID (int i)
#else
static int
-YYID (yyi)
- int yyi;
+YYID (i)
+ int i;
#endif
{
- return yyi;
+ return i;
}
#endif
@@ -556,9 +605,9 @@ void free (void *); /* INFRINGES ON USER NAME SPACE */
/* A type that is properly aligned for any stack member. */
union yyalloc
{
- yytype_int16 yyss_alloc;
- YYSTYPE yyvs_alloc;
- YYLTYPE yyls_alloc;
+ yytype_int16 yyss;
+ YYSTYPE yyvs;
+ YYLTYPE yyls;
};
/* The size of the maximum gap between one aligned stack and the next. */
@@ -593,12 +642,12 @@ union yyalloc
elements in the stack, and YYPTR gives the new location of the
stack. Advance YYPTR to a properly aligned location for the next
stack. */
-# define YYSTACK_RELOCATE(Stack_alloc, Stack) \
+# define YYSTACK_RELOCATE(Stack) \
do \
{ \
YYSIZE_T yynewbytes; \
- YYCOPY (&yyptr->Stack_alloc, Stack, yysize); \
- Stack = &yyptr->Stack_alloc; \
+ YYCOPY (&yyptr->Stack, Stack, yysize); \
+ Stack = &yyptr->Stack; \
yynewbytes = yystacksize * sizeof (*Stack) + YYSTACK_GAP_MAXIMUM; \
yyptr += yynewbytes / sizeof (*yyptr); \
} \
@@ -2312,20 +2361,17 @@ yy_symbol_print (yyoutput, yytype, yyvaluep, yylocationp)
#if (defined __STDC__ || defined __C99__FUNC__ \
|| defined __cplusplus || defined _MSC_VER)
static void
-yy_stack_print (yytype_int16 *yybottom, yytype_int16 *yytop)
+yy_stack_print (yytype_int16 *bottom, yytype_int16 *top)
#else
static void
-yy_stack_print (yybottom, yytop)
- yytype_int16 *yybottom;
- yytype_int16 *yytop;
+yy_stack_print (bottom, top)
+ yytype_int16 *bottom;
+ yytype_int16 *top;
#endif
{
YYFPRINTF (stderr, "Stack now");
- for (; yybottom <= yytop; yybottom++)
- {
- int yybot = *yybottom;
- YYFPRINTF (stderr, " %d", yybot);
- }
+ for (; bottom <= top; ++bottom)
+ YYFPRINTF (stderr, " %d", *bottom);
YYFPRINTF (stderr, "\n");
}
@@ -2360,11 +2406,11 @@ yy_reduce_print (yyvsp, yylsp, yyrule)
/* The symbols being reduced. */
for (yyi = 0; yyi < yynrhs; yyi++)
{
- YYFPRINTF (stderr, " $%d = ", yyi + 1);
+ fprintf (stderr, " $%d = ", yyi + 1);
yy_symbol_print (stderr, yyrhs[yyprhs[yyrule] + yyi],
&(yyvsp[(yyi + 1) - (yynrhs)])
, &(yylsp[(yyi + 1) - (yynrhs)]) );
- YYFPRINTF (stderr, "\n");
+ fprintf (stderr, "\n");
}
}
@@ -2646,8 +2692,10 @@ yydestruct (yymsg, yytype, yyvaluep, yylocationp)
break;
}
}
+
/* Prevent warnings from -Wmissing-prototypes. */
+
#ifdef YYPARSE_PARAM
#if defined __STDC__ || defined __cplusplus
int yyparse (void *YYPARSE_PARAM);
@@ -2666,9 +2714,10 @@ int yyparse ();
-/*-------------------------.
-| yyparse or yypush_parse. |
-`-------------------------*/
+
+/*----------.
+| yyparse. |
+`----------*/
#ifdef YYPARSE_PARAM
#if (defined __STDC__ || defined __C99__FUNC__ \
@@ -2692,97 +2741,88 @@ yyparse ()
#endif
#endif
{
-/* The lookahead symbol. */
+ /* The look-ahead symbol. */
int yychar;
-/* The semantic value of the lookahead symbol. */
+/* The semantic value of the look-ahead symbol. */
YYSTYPE yylval;
-/* Location data for the lookahead symbol. */
+/* Number of syntax errors so far. */
+int yynerrs;
+/* Location data for the look-ahead symbol. */
YYLTYPE yylloc;
- /* Number of syntax errors so far. */
- int yynerrs;
-
- int yystate;
- /* Number of tokens to shift before error messages enabled. */
- int yyerrstatus;
+ int yystate;
+ int yyn;
+ int yyresult;
+ /* Number of tokens to shift before error messages enabled. */
+ int yyerrstatus;
+ /* Look-ahead token as an internal (translated) token number. */
+ int yytoken = 0;
+#if YYERROR_VERBOSE
+ /* Buffer for error messages, and its allocated size. */
+ char yymsgbuf[128];
+ char *yymsg = yymsgbuf;
+ YYSIZE_T yymsg_alloc = sizeof yymsgbuf;
+#endif
- /* The stacks and their tools:
- `yyss': related to states.
- `yyvs': related to semantic values.
- `yyls': related to locations.
+ /* Three stacks and their tools:
+ `yyss': related to states,
+ `yyvs': related to semantic values,
+ `yyls': related to locations.
- Refer to the stacks thru separate pointers, to allow yyoverflow
- to reallocate them elsewhere. */
+ Refer to the stacks thru separate pointers, to allow yyoverflow
+ to reallocate them elsewhere. */
- /* The state stack. */
- yytype_int16 yyssa[YYINITDEPTH];
- yytype_int16 *yyss;
- yytype_int16 *yyssp;
+ /* The state stack. */
+ yytype_int16 yyssa[YYINITDEPTH];
+ yytype_int16 *yyss = yyssa;
+ yytype_int16 *yyssp;
- /* The semantic value stack. */
- YYSTYPE yyvsa[YYINITDEPTH];
- YYSTYPE *yyvs;
- YYSTYPE *yyvsp;
+ /* The semantic value stack. */
+ YYSTYPE yyvsa[YYINITDEPTH];
+ YYSTYPE *yyvs = yyvsa;
+ YYSTYPE *yyvsp;
- /* The location stack. */
- YYLTYPE yylsa[YYINITDEPTH];
- YYLTYPE *yyls;
- YYLTYPE *yylsp;
+ /* The location stack. */
+ YYLTYPE yylsa[YYINITDEPTH];
+ YYLTYPE *yyls = yylsa;
+ YYLTYPE *yylsp;
+ /* The locations where the error started and ended. */
+ YYLTYPE yyerror_range[2];
- /* The locations where the error started and ended. */
- YYLTYPE yyerror_range[2];
+#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N), yylsp -= (N))
- YYSIZE_T yystacksize;
+ YYSIZE_T yystacksize = YYINITDEPTH;
- int yyn;
- int yyresult;
- /* Lookahead token as an internal (translated) token number. */
- int yytoken;
/* The variables used to return semantic value and location from the
action routines. */
YYSTYPE yyval;
YYLTYPE yyloc;
-#if YYERROR_VERBOSE
- /* Buffer for error messages, and its allocated size. */
- char yymsgbuf[128];
- char *yymsg = yymsgbuf;
- YYSIZE_T yymsg_alloc = sizeof yymsgbuf;
-#endif
-
-#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N), yylsp -= (N))
-
/* The number of symbols on the RHS of the reduced rule.
Keep to zero when no symbol should be popped. */
int yylen = 0;
- yytoken = 0;
- yyss = yyssa;
- yyvs = yyvsa;
- yyls = yylsa;
- yystacksize = YYINITDEPTH;
-
YYDPRINTF ((stderr, "Starting parse\n"));
yystate = 0;
yyerrstatus = 0;
yynerrs = 0;
- yychar = YYEMPTY; /* Cause a token to be read. */
+ yychar = YYEMPTY; /* Cause a token to be read. */
/* Initialize stack pointers.
Waste one element of value and location stack
so that they stay on the same level as the state stack.
The wasted elements are never initialized. */
+
yyssp = yyss;
yyvsp = yyvs;
yylsp = yyls;
-
#if YYLTYPE_IS_TRIVIAL
/* Initialize the default location before parsing starts. */
yylloc.first_line = yylloc.last_line = 1;
- yylloc.first_column = yylloc.last_column = 1;
+ yylloc.first_column = yylloc.last_column = 0;
#endif
goto yysetstate;
@@ -2821,7 +2861,6 @@ YYLTYPE yylloc;
&yyvs1, yysize * sizeof (*yyvsp),
&yyls1, yysize * sizeof (*yylsp),
&yystacksize);
-
yyls = yyls1;
yyss = yyss1;
yyvs = yyvs1;
@@ -2843,9 +2882,9 @@ YYLTYPE yylloc;
(union yyalloc *) YYSTACK_ALLOC (YYSTACK_BYTES (yystacksize));
if (! yyptr)
goto yyexhaustedlab;
- YYSTACK_RELOCATE (yyss_alloc, yyss);
- YYSTACK_RELOCATE (yyvs_alloc, yyvs);
- YYSTACK_RELOCATE (yyls_alloc, yyls);
+ YYSTACK_RELOCATE (yyss);
+ YYSTACK_RELOCATE (yyvs);
+ YYSTACK_RELOCATE (yyls);
# undef YYSTACK_RELOCATE
if (yyss1 != yyssa)
YYSTACK_FREE (yyss1);
@@ -2866,9 +2905,6 @@ YYLTYPE yylloc;
YYDPRINTF ((stderr, "Entering state %d\n", yystate));
- if (yystate == YYFINAL)
- YYACCEPT;
-
goto yybackup;
/*-----------.
@@ -2877,16 +2913,16 @@ YYLTYPE yylloc;
yybackup:
/* Do appropriate processing given the current state. Read a
- lookahead token if we need one and don't already have one. */
+ look-ahead token if we need one and don't already have one. */
- /* First try to decide what to do without reference to lookahead token. */
+ /* First try to decide what to do without reference to look-ahead token. */
yyn = yypact[yystate];
if (yyn == YYPACT_NINF)
goto yydefault;
- /* Not known => get a lookahead token if don't already have one. */
+ /* Not known => get a look-ahead token if don't already have one. */
- /* YYCHAR is either YYEMPTY or YYEOF or a valid lookahead symbol. */
+ /* YYCHAR is either YYEMPTY or YYEOF or a valid look-ahead symbol. */
if (yychar == YYEMPTY)
{
YYDPRINTF ((stderr, "Reading a token: "));
@@ -2918,16 +2954,20 @@ yybackup:
goto yyreduce;
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
/* Count tokens shifted since error; after three, turn off error
status. */
if (yyerrstatus)
yyerrstatus--;
- /* Shift the lookahead token. */
+ /* Shift the look-ahead token. */
YY_SYMBOL_PRINT ("Shifting", yytoken, &yylval, &yylloc);
- /* Discard the shifted token. */
- yychar = YYEMPTY;
+ /* Discard the shifted token unless it is eof. */
+ if (yychar != YYEOF)
+ yychar = YYEMPTY;
yystate = yyn;
*++yyvsp = yylval;
@@ -2968,43 +3008,31 @@ yyreduce:
switch (yyn)
{
case 2:
-
-/* Line 1455 of yacc.c */
#line 290 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NullNode(GLOBAL_DATA), 0, 1); ;}
break;
case 3:
-
-/* Line 1455 of yacc.c */
#line 291 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BooleanNode(GLOBAL_DATA, true), 0, 1); ;}
break;
case 4:
-
-/* Line 1455 of yacc.c */
#line 292 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BooleanNode(GLOBAL_DATA, false), 0, 1); ;}
break;
case 5:
-
-/* Line 1455 of yacc.c */
#line 293 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeNumberNode(GLOBAL_DATA, (yyvsp[(1) - (1)].doubleValue)), 0, 1); ;}
break;
case 6:
-
-/* Line 1455 of yacc.c */
#line 294 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StringNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident)), 0, 1); ;}
break;
case 7:
-
-/* Line 1455 of yacc.c */
#line 295 "../../JavaScriptCore/parser/Grammar.y"
{
Lexer& l = *LEXER;
@@ -3018,8 +3046,6 @@ yyreduce:
break;
case 8:
-
-/* Line 1455 of yacc.c */
#line 304 "../../JavaScriptCore/parser/Grammar.y"
{
Lexer& l = *LEXER;
@@ -3033,36 +3059,26 @@ yyreduce:
break;
case 9:
-
-/* Line 1455 of yacc.c */
#line 316 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 10:
-
-/* Line 1455 of yacc.c */
#line 317 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 11:
-
-/* Line 1455 of yacc.c */
#line 318 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(new (GLOBAL_DATA) PropertyNode(GLOBAL_DATA, Identifier(GLOBAL_DATA, UString::from((yyvsp[(1) - (3)].doubleValue))), (yyvsp[(3) - (3)].expressionNode).m_node, PropertyNode::Constant), (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 12:
-
-/* Line 1455 of yacc.c */
#line 319 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyNode) = createNodeInfo<PropertyNode*>(makeGetterOrSetterPropertyNode(globalPtr, *(yyvsp[(1) - (7)].ident), *(yyvsp[(2) - (7)].ident), 0, (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); if (!(yyval.propertyNode).m_node) YYABORT; ;}
break;
case 13:
-
-/* Line 1455 of yacc.c */
#line 321 "../../JavaScriptCore/parser/Grammar.y"
{
(yyval.propertyNode) = createNodeInfo<PropertyNode*>(makeGetterOrSetterPropertyNode(globalPtr, *(yyvsp[(1) - (8)].ident), *(yyvsp[(2) - (8)].ident), (yyvsp[(4) - (8)].parameterList).m_node.head, (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line)), (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -3075,8 +3091,6 @@ yyreduce:
break;
case 14:
-
-/* Line 1455 of yacc.c */
#line 332 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyList).m_node.head = new (GLOBAL_DATA) PropertyListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].propertyNode).m_node);
(yyval.propertyList).m_node.tail = (yyval.propertyList).m_node.head;
@@ -3085,8 +3099,6 @@ yyreduce:
break;
case 15:
-
-/* Line 1455 of yacc.c */
#line 336 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.propertyList).m_node.head = (yyvsp[(1) - (3)].propertyList).m_node.head;
(yyval.propertyList).m_node.tail = new (GLOBAL_DATA) PropertyListNode(GLOBAL_DATA, (yyvsp[(3) - (3)].propertyNode).m_node, (yyvsp[(1) - (3)].propertyList).m_node.tail);
@@ -3095,71 +3107,51 @@ yyreduce:
break;
case 17:
-
-/* Line 1455 of yacc.c */
#line 344 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA), 0, 0); ;}
break;
case 18:
-
-/* Line 1455 of yacc.c */
#line 345 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA, (yyvsp[(2) - (3)].propertyList).m_node.head), (yyvsp[(2) - (3)].propertyList).m_features, (yyvsp[(2) - (3)].propertyList).m_numConstants); ;}
break;
case 19:
-
-/* Line 1455 of yacc.c */
#line 347 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ObjectLiteralNode(GLOBAL_DATA, (yyvsp[(2) - (4)].propertyList).m_node.head), (yyvsp[(2) - (4)].propertyList).m_features, (yyvsp[(2) - (4)].propertyList).m_numConstants); ;}
break;
case 20:
-
-/* Line 1455 of yacc.c */
#line 351 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ThisNode(GLOBAL_DATA), ThisFeature, 0); ;}
break;
case 23:
-
-/* Line 1455 of yacc.c */
#line 354 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident), (yylsp[(1) - (1)]).first_column), (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0, 0); ;}
break;
case 24:
-
-/* Line 1455 of yacc.c */
#line 355 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (3)].expressionNode); ;}
break;
case 25:
-
-/* Line 1455 of yacc.c */
#line 359 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(2) - (3)].intValue)), 0, (yyvsp[(2) - (3)].intValue) ? 1 : 0); ;}
break;
case 26:
-
-/* Line 1455 of yacc.c */
#line 360 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(2) - (3)].elementList).m_node.head), (yyvsp[(2) - (3)].elementList).m_features, (yyvsp[(2) - (3)].elementList).m_numConstants); ;}
break;
case 27:
-
-/* Line 1455 of yacc.c */
#line 361 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ArrayNode(GLOBAL_DATA, (yyvsp[(4) - (5)].intValue), (yyvsp[(2) - (5)].elementList).m_node.head), (yyvsp[(2) - (5)].elementList).m_features, (yyvsp[(4) - (5)].intValue) ? (yyvsp[(2) - (5)].elementList).m_numConstants + 1 : (yyvsp[(2) - (5)].elementList).m_numConstants); ;}
break;
case 28:
-
-/* Line 1455 of yacc.c */
#line 365 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.elementList).m_node.head = new (GLOBAL_DATA) ElementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].intValue), (yyvsp[(2) - (2)].expressionNode).m_node);
(yyval.elementList).m_node.tail = (yyval.elementList).m_node.head;
@@ -3168,8 +3160,6 @@ yyreduce:
break;
case 29:
-
-/* Line 1455 of yacc.c */
#line 370 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.elementList).m_node.head = (yyvsp[(1) - (4)].elementList).m_node.head;
(yyval.elementList).m_node.tail = new (GLOBAL_DATA) ElementNode(GLOBAL_DATA, (yyvsp[(1) - (4)].elementList).m_node.tail, (yyvsp[(3) - (4)].intValue), (yyvsp[(4) - (4)].expressionNode).m_node);
@@ -3178,36 +3168,26 @@ yyreduce:
break;
case 30:
-
-/* Line 1455 of yacc.c */
#line 377 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.intValue) = 0; ;}
break;
case 32:
-
-/* Line 1455 of yacc.c */
#line 382 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.intValue) = 1; ;}
break;
case 33:
-
-/* Line 1455 of yacc.c */
#line 383 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.intValue) = (yyvsp[(1) - (2)].intValue) + 1; ;}
break;
case 35:
-
-/* Line 1455 of yacc.c */
#line 388 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>((yyvsp[(1) - (1)].funcExprNode).m_node, (yyvsp[(1) - (1)].funcExprNode).m_features, (yyvsp[(1) - (1)].funcExprNode).m_numConstants); ;}
break;
case 36:
-
-/* Line 1455 of yacc.c */
#line 389 "../../JavaScriptCore/parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3216,8 +3196,6 @@ yyreduce:
break;
case 37:
-
-/* Line 1455 of yacc.c */
#line 393 "../../JavaScriptCore/parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3226,8 +3204,6 @@ yyreduce:
break;
case 38:
-
-/* Line 1455 of yacc.c */
#line 397 "../../JavaScriptCore/parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].argumentsNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3236,8 +3212,6 @@ yyreduce:
break;
case 40:
-
-/* Line 1455 of yacc.c */
#line 405 "../../JavaScriptCore/parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3246,8 +3220,6 @@ yyreduce:
break;
case 41:
-
-/* Line 1455 of yacc.c */
#line 409 "../../JavaScriptCore/parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3256,8 +3228,6 @@ yyreduce:
break;
case 42:
-
-/* Line 1455 of yacc.c */
#line 413 "../../JavaScriptCore/parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].argumentsNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3266,8 +3236,6 @@ yyreduce:
break;
case 44:
-
-/* Line 1455 of yacc.c */
#line 421 "../../JavaScriptCore/parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column);
@@ -3276,8 +3244,6 @@ yyreduce:
break;
case 46:
-
-/* Line 1455 of yacc.c */
#line 429 "../../JavaScriptCore/parser/Grammar.y"
{ NewExprNode* node = new (GLOBAL_DATA) NewExprNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column);
@@ -3286,22 +3252,16 @@ yyreduce:
break;
case 47:
-
-/* Line 1455 of yacc.c */
#line 436 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 48:
-
-/* Line 1455 of yacc.c */
#line 437 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 49:
-
-/* Line 1455 of yacc.c */
#line 438 "../../JavaScriptCore/parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3310,8 +3270,6 @@ yyreduce:
break;
case 50:
-
-/* Line 1455 of yacc.c */
#line 442 "../../JavaScriptCore/parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3319,22 +3277,16 @@ yyreduce:
break;
case 51:
-
-/* Line 1455 of yacc.c */
#line 448 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 52:
-
-/* Line 1455 of yacc.c */
#line 449 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = makeFunctionCallNode(globalPtr, (yyvsp[(1) - (2)].expressionNode), (yyvsp[(2) - (2)].argumentsNode), (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column); ;}
break;
case 53:
-
-/* Line 1455 of yacc.c */
#line 450 "../../JavaScriptCore/parser/Grammar.y"
{ BracketAccessorNode* node = new (GLOBAL_DATA) BracketAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_node, (yyvsp[(3) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (4)]).first_column, (yylsp[(1) - (4)]).last_column, (yylsp[(4) - (4)]).last_column);
@@ -3343,8 +3295,6 @@ yyreduce:
break;
case 54:
-
-/* Line 1455 of yacc.c */
#line 454 "../../JavaScriptCore/parser/Grammar.y"
{ DotAccessorNode* node = new (GLOBAL_DATA) DotAccessorNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, *(yyvsp[(3) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(1) - (3)]).last_column, (yylsp[(3) - (3)]).last_column);
@@ -3353,22 +3303,16 @@ yyreduce:
break;
case 55:
-
-/* Line 1455 of yacc.c */
#line 461 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.argumentsNode) = createNodeInfo<ArgumentsNode*>(new (GLOBAL_DATA) ArgumentsNode(GLOBAL_DATA), 0, 0); ;}
break;
case 56:
-
-/* Line 1455 of yacc.c */
#line 462 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.argumentsNode) = createNodeInfo<ArgumentsNode*>(new (GLOBAL_DATA) ArgumentsNode(GLOBAL_DATA, (yyvsp[(2) - (3)].argumentList).m_node.head), (yyvsp[(2) - (3)].argumentList).m_features, (yyvsp[(2) - (3)].argumentList).m_numConstants); ;}
break;
case 57:
-
-/* Line 1455 of yacc.c */
#line 466 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.argumentList).m_node.head = new (GLOBAL_DATA) ArgumentListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].expressionNode).m_node);
(yyval.argumentList).m_node.tail = (yyval.argumentList).m_node.head;
@@ -3377,8 +3321,6 @@ yyreduce:
break;
case 58:
-
-/* Line 1455 of yacc.c */
#line 470 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.argumentList).m_node.head = (yyvsp[(1) - (3)].argumentList).m_node.head;
(yyval.argumentList).m_node.tail = new (GLOBAL_DATA) ArgumentListNode(GLOBAL_DATA, (yyvsp[(1) - (3)].argumentList).m_node.tail, (yyvsp[(3) - (3)].expressionNode).m_node);
@@ -3387,253 +3329,181 @@ yyreduce:
break;
case 64:
-
-/* Line 1455 of yacc.c */
#line 488 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 65:
-
-/* Line 1455 of yacc.c */
#line 489 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 67:
-
-/* Line 1455 of yacc.c */
#line 494 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 68:
-
-/* Line 1455 of yacc.c */
#line 495 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePostfixNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(1) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (2)].expressionNode).m_numConstants); ;}
break;
case 69:
-
-/* Line 1455 of yacc.c */
#line 499 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDeleteNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).last_column, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 70:
-
-/* Line 1455 of yacc.c */
#line 500 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) VoidNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants + 1); ;}
break;
case 71:
-
-/* Line 1455 of yacc.c */
#line 501 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeTypeOfNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 72:
-
-/* Line 1455 of yacc.c */
#line 502 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 73:
-
-/* Line 1455 of yacc.c */
#line 503 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpPlusPlus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 74:
-
-/* Line 1455 of yacc.c */
#line 504 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 75:
-
-/* Line 1455 of yacc.c */
#line 505 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makePrefixNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node, OpMinusMinus, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column), (yyvsp[(2) - (2)].expressionNode).m_features | AssignFeature, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 76:
-
-/* Line 1455 of yacc.c */
#line 506 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnaryPlusNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 77:
-
-/* Line 1455 of yacc.c */
#line 507 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeNegateNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 78:
-
-/* Line 1455 of yacc.c */
#line 508 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeBitwiseNotNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 79:
-
-/* Line 1455 of yacc.c */
#line 509 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalNotNode(GLOBAL_DATA, (yyvsp[(2) - (2)].expressionNode).m_node), (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 85:
-
-/* Line 1455 of yacc.c */
#line 523 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeMultNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 86:
-
-/* Line 1455 of yacc.c */
#line 524 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDivNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 87:
-
-/* Line 1455 of yacc.c */
#line 525 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ModNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 89:
-
-/* Line 1455 of yacc.c */
#line 531 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeMultNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 90:
-
-/* Line 1455 of yacc.c */
#line 533 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeDivNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 91:
-
-/* Line 1455 of yacc.c */
#line 535 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ModNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 93:
-
-/* Line 1455 of yacc.c */
#line 540 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAddNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 94:
-
-/* Line 1455 of yacc.c */
#line 541 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeSubNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 96:
-
-/* Line 1455 of yacc.c */
#line 547 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAddNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 97:
-
-/* Line 1455 of yacc.c */
#line 549 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeSubNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 99:
-
-/* Line 1455 of yacc.c */
#line 554 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeLeftShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 100:
-
-/* Line 1455 of yacc.c */
#line 555 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 101:
-
-/* Line 1455 of yacc.c */
#line 556 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnsignedRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 103:
-
-/* Line 1455 of yacc.c */
#line 561 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeLeftShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 104:
-
-/* Line 1455 of yacc.c */
#line 562 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 105:
-
-/* Line 1455 of yacc.c */
#line 563 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) UnsignedRightShiftNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 107:
-
-/* Line 1455 of yacc.c */
#line 568 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 108:
-
-/* Line 1455 of yacc.c */
#line 569 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 109:
-
-/* Line 1455 of yacc.c */
#line 570 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 110:
-
-/* Line 1455 of yacc.c */
#line 571 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 111:
-
-/* Line 1455 of yacc.c */
#line 572 "../../JavaScriptCore/parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3641,8 +3511,6 @@ yyreduce:
break;
case 112:
-
-/* Line 1455 of yacc.c */
#line 575 "../../JavaScriptCore/parser/Grammar.y"
{ InNode* node = new (GLOBAL_DATA) InNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3650,36 +3518,26 @@ yyreduce:
break;
case 114:
-
-/* Line 1455 of yacc.c */
#line 582 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 115:
-
-/* Line 1455 of yacc.c */
#line 583 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 116:
-
-/* Line 1455 of yacc.c */
#line 584 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 117:
-
-/* Line 1455 of yacc.c */
#line 585 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 118:
-
-/* Line 1455 of yacc.c */
#line 587 "../../JavaScriptCore/parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3687,36 +3545,26 @@ yyreduce:
break;
case 120:
-
-/* Line 1455 of yacc.c */
#line 594 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 121:
-
-/* Line 1455 of yacc.c */
#line 595 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 122:
-
-/* Line 1455 of yacc.c */
#line 596 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LessEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 123:
-
-/* Line 1455 of yacc.c */
#line 597 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) GreaterEqNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 124:
-
-/* Line 1455 of yacc.c */
#line 599 "../../JavaScriptCore/parser/Grammar.y"
{ InstanceOfNode* node = new (GLOBAL_DATA) InstanceOfNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3724,8 +3572,6 @@ yyreduce:
break;
case 125:
-
-/* Line 1455 of yacc.c */
#line 603 "../../JavaScriptCore/parser/Grammar.y"
{ InNode* node = new (GLOBAL_DATA) InNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(3) - (3)]).first_column, (yylsp[(3) - (3)]).last_column);
@@ -3733,218 +3579,156 @@ yyreduce:
break;
case 127:
-
-/* Line 1455 of yacc.c */
#line 610 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 128:
-
-/* Line 1455 of yacc.c */
#line 611 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 129:
-
-/* Line 1455 of yacc.c */
#line 612 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 130:
-
-/* Line 1455 of yacc.c */
#line 613 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 132:
-
-/* Line 1455 of yacc.c */
#line 619 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 133:
-
-/* Line 1455 of yacc.c */
#line 621 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 134:
-
-/* Line 1455 of yacc.c */
#line 623 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 135:
-
-/* Line 1455 of yacc.c */
#line 625 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 137:
-
-/* Line 1455 of yacc.c */
#line 631 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) EqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 138:
-
-/* Line 1455 of yacc.c */
#line 632 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 139:
-
-/* Line 1455 of yacc.c */
#line 634 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) StrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 140:
-
-/* Line 1455 of yacc.c */
#line 636 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) NotStrictEqualNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 142:
-
-/* Line 1455 of yacc.c */
#line 641 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 144:
-
-/* Line 1455 of yacc.c */
#line 647 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 146:
-
-/* Line 1455 of yacc.c */
#line 652 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitAndNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 148:
-
-/* Line 1455 of yacc.c */
#line 657 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 150:
-
-/* Line 1455 of yacc.c */
#line 663 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 152:
-
-/* Line 1455 of yacc.c */
#line 669 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitXOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 154:
-
-/* Line 1455 of yacc.c */
#line 674 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 156:
-
-/* Line 1455 of yacc.c */
#line 680 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 158:
-
-/* Line 1455 of yacc.c */
#line 686 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) BitOrNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 160:
-
-/* Line 1455 of yacc.c */
#line 691 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 162:
-
-/* Line 1455 of yacc.c */
#line 697 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 164:
-
-/* Line 1455 of yacc.c */
#line 703 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalAnd), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 166:
-
-/* Line 1455 of yacc.c */
#line 708 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 168:
-
-/* Line 1455 of yacc.c */
#line 714 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 170:
-
-/* Line 1455 of yacc.c */
#line 719 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) LogicalOpNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node, OpLogicalOr), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 172:
-
-/* Line 1455 of yacc.c */
#line 725 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 174:
-
-/* Line 1455 of yacc.c */
#line 731 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 176:
-
-/* Line 1455 of yacc.c */
#line 737 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) ConditionalNode(GLOBAL_DATA, (yyvsp[(1) - (5)].expressionNode).m_node, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].expressionNode).m_node), (yyvsp[(1) - (5)].expressionNode).m_features | (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].expressionNode).m_features, (yyvsp[(1) - (5)].expressionNode).m_numConstants + (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].expressionNode).m_numConstants); ;}
break;
case 178:
-
-/* Line 1455 of yacc.c */
#line 743 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3952,8 +3736,6 @@ yyreduce:
break;
case 180:
-
-/* Line 1455 of yacc.c */
#line 751 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3961,8 +3743,6 @@ yyreduce:
break;
case 182:
-
-/* Line 1455 of yacc.c */
#line 759 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(makeAssignNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(2) - (3)].op), (yyvsp[(3) - (3)].expressionNode).m_node, (yyvsp[(1) - (3)].expressionNode).m_features & AssignFeature, (yyvsp[(3) - (3)].expressionNode).m_features & AssignFeature,
(yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).first_column + 1, (yylsp[(3) - (3)]).last_column), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features | AssignFeature, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants);
@@ -3970,137 +3750,99 @@ yyreduce:
break;
case 183:
-
-/* Line 1455 of yacc.c */
#line 765 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpEqual; ;}
break;
case 184:
-
-/* Line 1455 of yacc.c */
#line 766 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpPlusEq; ;}
break;
case 185:
-
-/* Line 1455 of yacc.c */
#line 767 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpMinusEq; ;}
break;
case 186:
-
-/* Line 1455 of yacc.c */
#line 768 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpMultEq; ;}
break;
case 187:
-
-/* Line 1455 of yacc.c */
#line 769 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpDivEq; ;}
break;
case 188:
-
-/* Line 1455 of yacc.c */
#line 770 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpLShift; ;}
break;
case 189:
-
-/* Line 1455 of yacc.c */
#line 771 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpRShift; ;}
break;
case 190:
-
-/* Line 1455 of yacc.c */
#line 772 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpURShift; ;}
break;
case 191:
-
-/* Line 1455 of yacc.c */
#line 773 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpAndEq; ;}
break;
case 192:
-
-/* Line 1455 of yacc.c */
#line 774 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpXOrEq; ;}
break;
case 193:
-
-/* Line 1455 of yacc.c */
#line 775 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpOrEq; ;}
break;
case 194:
-
-/* Line 1455 of yacc.c */
#line 776 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.op) = OpModEq; ;}
break;
case 196:
-
-/* Line 1455 of yacc.c */
#line 781 "../../JavaScriptCore/parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 198:
-
-/* Line 1455 of yacc.c */
#line 786 "../../JavaScriptCore/parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 200:
-
-/* Line 1455 of yacc.c */
#line 791 "../../JavaScriptCore/parser/Grammar.y"
- { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
+ { (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (3)].expressionNode).m_node, (yyvsp[(3) - (3)].expressionNode).m_node), (yyvsp[(1) - (3)].expressionNode).m_features | (yyvsp[(3) - (3)].expressionNode).m_features, (yyvsp[(1) - (3)].expressionNode).m_numConstants + (yyvsp[(3) - (3)].expressionNode).m_numConstants); ;}
break;
case 218:
-
-/* Line 1455 of yacc.c */
#line 815 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) BlockNode(GLOBAL_DATA, 0), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 219:
-
-/* Line 1455 of yacc.c */
#line 817 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) BlockNode(GLOBAL_DATA, (yyvsp[(2) - (3)].sourceElements).m_node), (yyvsp[(2) - (3)].sourceElements).m_varDeclarations, (yyvsp[(2) - (3)].sourceElements).m_funcDeclarations, (yyvsp[(2) - (3)].sourceElements).m_features, (yyvsp[(2) - (3)].sourceElements).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 220:
-
-/* Line 1455 of yacc.c */
#line 822 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(makeVarStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].varDeclList).m_node), (yyvsp[(2) - (3)].varDeclList).m_varDeclarations, (yyvsp[(2) - (3)].varDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].varDeclList).m_features, (yyvsp[(2) - (3)].varDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 221:
-
-/* Line 1455 of yacc.c */
#line 824 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(makeVarStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].varDeclList).m_node), (yyvsp[(2) - (3)].varDeclList).m_varDeclarations, (yyvsp[(2) - (3)].varDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].varDeclList).m_features, (yyvsp[(2) - (3)].varDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(2) - (3)]));
@@ -4108,8 +3850,6 @@ yyreduce:
break;
case 222:
-
-/* Line 1455 of yacc.c */
#line 830 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.varDeclList).m_node = 0;
(yyval.varDeclList).m_varDeclarations = new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::VarStack>;
@@ -4121,8 +3861,6 @@ yyreduce:
break;
case 223:
-
-/* Line 1455 of yacc.c */
#line 837 "../../JavaScriptCore/parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node, (yyvsp[(2) - (2)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column);
@@ -4136,8 +3874,6 @@ yyreduce:
break;
case 224:
-
-/* Line 1455 of yacc.c */
#line 847 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.varDeclList).m_node = (yyvsp[(1) - (3)].varDeclList).m_node;
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (3)].varDeclList).m_varDeclarations;
@@ -4149,12 +3885,10 @@ yyreduce:
break;
case 225:
-
-/* Line 1455 of yacc.c */
#line 855 "../../JavaScriptCore/parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(3) - (4)].ident), (yyvsp[(4) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(3) - (4)]).first_column, (yylsp[(4) - (4)]).first_column + 1, (yylsp[(4) - (4)]).last_column);
- (yyval.varDeclList).m_node = combineVarInitializers(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
+ (yyval.varDeclList).m_node = combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (4)].varDeclList).m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, (yyval.varDeclList).m_varDeclarations, *(yyvsp[(3) - (4)].ident), DeclarationStacks::HasInitializer);
(yyval.varDeclList).m_funcDeclarations = 0;
@@ -4164,8 +3898,6 @@ yyreduce:
break;
case 226:
-
-/* Line 1455 of yacc.c */
#line 867 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.varDeclList).m_node = 0;
(yyval.varDeclList).m_varDeclarations = new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::VarStack>;
@@ -4177,8 +3909,6 @@ yyreduce:
break;
case 227:
-
-/* Line 1455 of yacc.c */
#line 874 "../../JavaScriptCore/parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node, (yyvsp[(2) - (2)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(2) - (2)]).first_column + 1, (yylsp[(2) - (2)]).last_column);
@@ -4192,8 +3922,6 @@ yyreduce:
break;
case 228:
-
-/* Line 1455 of yacc.c */
#line 884 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.varDeclList).m_node = (yyvsp[(1) - (3)].varDeclList).m_node;
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (3)].varDeclList).m_varDeclarations;
@@ -4205,12 +3933,10 @@ yyreduce:
break;
case 229:
-
-/* Line 1455 of yacc.c */
#line 892 "../../JavaScriptCore/parser/Grammar.y"
{ AssignResolveNode* node = new (GLOBAL_DATA) AssignResolveNode(GLOBAL_DATA, *(yyvsp[(3) - (4)].ident), (yyvsp[(4) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].expressionNode).m_features & AssignFeature);
SET_EXCEPTION_LOCATION(node, (yylsp[(3) - (4)]).first_column, (yylsp[(4) - (4)]).first_column + 1, (yylsp[(4) - (4)]).last_column);
- (yyval.varDeclList).m_node = combineVarInitializers(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
+ (yyval.varDeclList).m_node = combineCommaNodes(GLOBAL_DATA, (yyvsp[(1) - (4)].varDeclList).m_node, node);
(yyval.varDeclList).m_varDeclarations = (yyvsp[(1) - (4)].varDeclList).m_varDeclarations;
appendToVarDeclarationList(GLOBAL_DATA, (yyval.varDeclList).m_varDeclarations, *(yyvsp[(3) - (4)].ident), DeclarationStacks::HasInitializer);
(yyval.varDeclList).m_funcDeclarations = 0;
@@ -4220,24 +3946,18 @@ yyreduce:
break;
case 230:
-
-/* Line 1455 of yacc.c */
#line 904 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ConstStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].constDeclList).m_node.head), (yyvsp[(2) - (3)].constDeclList).m_varDeclarations, (yyvsp[(2) - (3)].constDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].constDeclList).m_features, (yyvsp[(2) - (3)].constDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(3) - (3)])); ;}
break;
case 231:
-
-/* Line 1455 of yacc.c */
#line 907 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ConstStatementNode(GLOBAL_DATA, (yyvsp[(2) - (3)].constDeclList).m_node.head), (yyvsp[(2) - (3)].constDeclList).m_varDeclarations, (yyvsp[(2) - (3)].constDeclList).m_funcDeclarations, (yyvsp[(2) - (3)].constDeclList).m_features, (yyvsp[(2) - (3)].constDeclList).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (3)]), (yylsp[(2) - (3)])); AUTO_SEMICOLON; ;}
break;
case 232:
-
-/* Line 1455 of yacc.c */
#line 912 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.constDeclList).m_node.head = (yyvsp[(1) - (1)].constDeclNode).m_node;
(yyval.constDeclList).m_node.tail = (yyval.constDeclList).m_node.head;
@@ -4250,8 +3970,6 @@ yyreduce:
break;
case 233:
-
-/* Line 1455 of yacc.c */
#line 921 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.constDeclList).m_node.head = (yyvsp[(1) - (3)].constDeclList).m_node.head;
(yyvsp[(1) - (3)].constDeclList).m_node.tail->m_next = (yyvsp[(3) - (3)].constDeclNode).m_node;
@@ -4264,67 +3982,49 @@ yyreduce:
break;
case 234:
-
-/* Line 1455 of yacc.c */
#line 932 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.constDeclNode) = createNodeInfo<ConstDeclNode*>(new (GLOBAL_DATA) ConstDeclNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident), 0), (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0, 0); ;}
break;
case 235:
-
-/* Line 1455 of yacc.c */
#line 933 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.constDeclNode) = createNodeInfo<ConstDeclNode*>(new (GLOBAL_DATA) ConstDeclNode(GLOBAL_DATA, *(yyvsp[(1) - (2)].ident), (yyvsp[(2) - (2)].expressionNode).m_node), ((*(yyvsp[(1) - (2)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | (yyvsp[(2) - (2)].expressionNode).m_features, (yyvsp[(2) - (2)].expressionNode).m_numConstants); ;}
break;
case 236:
-
-/* Line 1455 of yacc.c */
#line 937 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (2)].expressionNode); ;}
break;
case 237:
-
-/* Line 1455 of yacc.c */
#line 941 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = (yyvsp[(2) - (2)].expressionNode); ;}
break;
case 238:
-
-/* Line 1455 of yacc.c */
#line 945 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) EmptyStatementNode(GLOBAL_DATA), 0, 0, 0, 0); ;}
break;
case 239:
-
-/* Line 1455 of yacc.c */
#line 949 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ExprStatementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node), 0, 0, (yyvsp[(1) - (2)].expressionNode).m_features, (yyvsp[(1) - (2)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 240:
-
-/* Line 1455 of yacc.c */
#line 951 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ExprStatementNode(GLOBAL_DATA, (yyvsp[(1) - (2)].expressionNode).m_node), 0, 0, (yyvsp[(1) - (2)].expressionNode).m_features, (yyvsp[(1) - (2)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(1) - (2)])); AUTO_SEMICOLON; ;}
break;
case 241:
-
-/* Line 1455 of yacc.c */
#line 957 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) IfNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node), (yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (5)]), (yylsp[(4) - (5)])); ;}
break;
case 242:
-
-/* Line 1455 of yacc.c */
#line 960 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) IfElseNode(GLOBAL_DATA, (yyvsp[(3) - (7)].expressionNode).m_node, (yyvsp[(5) - (7)].statementNode).m_node, (yyvsp[(7) - (7)].statementNode).m_node),
mergeDeclarationLists((yyvsp[(5) - (7)].statementNode).m_varDeclarations, (yyvsp[(7) - (7)].statementNode).m_varDeclarations),
@@ -4335,32 +4035,24 @@ yyreduce:
break;
case 243:
-
-/* Line 1455 of yacc.c */
#line 969 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DoWhileNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node), (yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(2) - (7)].statementNode).m_funcDeclarations, (yyvsp[(2) - (7)].statementNode).m_features | (yyvsp[(5) - (7)].expressionNode).m_features, (yyvsp[(2) - (7)].statementNode).m_numConstants + (yyvsp[(5) - (7)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (7)]), (yylsp[(3) - (7)])); ;}
break;
case 244:
-
-/* Line 1455 of yacc.c */
#line 971 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DoWhileNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node), (yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(2) - (7)].statementNode).m_funcDeclarations, (yyvsp[(2) - (7)].statementNode).m_features | (yyvsp[(5) - (7)].expressionNode).m_features, (yyvsp[(2) - (7)].statementNode).m_numConstants + (yyvsp[(5) - (7)].expressionNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (7)]), (yylsp[(3) - (7)])); ;}
break;
case 245:
-
-/* Line 1455 of yacc.c */
#line 973 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) WhileNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node), (yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (5)]), (yylsp[(4) - (5)])); ;}
break;
case 246:
-
-/* Line 1455 of yacc.c */
#line 976 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ForNode(GLOBAL_DATA, (yyvsp[(3) - (9)].expressionNode).m_node, (yyvsp[(5) - (9)].expressionNode).m_node, (yyvsp[(7) - (9)].expressionNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node, false), (yyvsp[(9) - (9)].statementNode).m_varDeclarations, (yyvsp[(9) - (9)].statementNode).m_funcDeclarations,
(yyvsp[(3) - (9)].expressionNode).m_features | (yyvsp[(5) - (9)].expressionNode).m_features | (yyvsp[(7) - (9)].expressionNode).m_features | (yyvsp[(9) - (9)].statementNode).m_features,
@@ -4370,8 +4062,6 @@ yyreduce:
break;
case 247:
-
-/* Line 1455 of yacc.c */
#line 982 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) ForNode(GLOBAL_DATA, (yyvsp[(4) - (10)].varDeclList).m_node, (yyvsp[(6) - (10)].expressionNode).m_node, (yyvsp[(8) - (10)].expressionNode).m_node, (yyvsp[(10) - (10)].statementNode).m_node, true),
mergeDeclarationLists((yyvsp[(4) - (10)].varDeclList).m_varDeclarations, (yyvsp[(10) - (10)].statementNode).m_varDeclarations),
@@ -4382,8 +4072,6 @@ yyreduce:
break;
case 248:
-
-/* Line 1455 of yacc.c */
#line 989 "../../JavaScriptCore/parser/Grammar.y"
{
ForInNode* node = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, (yyvsp[(3) - (7)].expressionNode).m_node, (yyvsp[(5) - (7)].expressionNode).m_node, (yyvsp[(7) - (7)].statementNode).m_node);
@@ -4396,8 +4084,6 @@ yyreduce:
break;
case 249:
-
-/* Line 1455 of yacc.c */
#line 998 "../../JavaScriptCore/parser/Grammar.y"
{ ForInNode *forIn = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, *(yyvsp[(4) - (8)].ident), 0, (yyvsp[(6) - (8)].expressionNode).m_node, (yyvsp[(8) - (8)].statementNode).m_node, (yylsp[(5) - (8)]).first_column, (yylsp[(5) - (8)]).first_column - (yylsp[(4) - (8)]).first_column, (yylsp[(6) - (8)]).last_column - (yylsp[(5) - (8)]).first_column);
SET_EXCEPTION_LOCATION(forIn, (yylsp[(4) - (8)]).first_column, (yylsp[(5) - (8)]).first_column + 1, (yylsp[(6) - (8)]).last_column);
@@ -4407,8 +4093,6 @@ yyreduce:
break;
case 250:
-
-/* Line 1455 of yacc.c */
#line 1004 "../../JavaScriptCore/parser/Grammar.y"
{ ForInNode *forIn = new (GLOBAL_DATA) ForInNode(GLOBAL_DATA, *(yyvsp[(4) - (9)].ident), (yyvsp[(5) - (9)].expressionNode).m_node, (yyvsp[(7) - (9)].expressionNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node, (yylsp[(5) - (9)]).first_column, (yylsp[(5) - (9)]).first_column - (yylsp[(4) - (9)]).first_column, (yylsp[(5) - (9)]).last_column - (yylsp[(5) - (9)]).first_column);
SET_EXCEPTION_LOCATION(forIn, (yylsp[(4) - (9)]).first_column, (yylsp[(6) - (9)]).first_column + 1, (yylsp[(7) - (9)]).last_column);
@@ -4420,22 +4104,16 @@ yyreduce:
break;
case 251:
-
-/* Line 1455 of yacc.c */
#line 1014 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(0, 0, 0); ;}
break;
case 253:
-
-/* Line 1455 of yacc.c */
#line 1019 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.expressionNode) = createNodeInfo<ExpressionNode*>(0, 0, 0); ;}
break;
case 255:
-
-/* Line 1455 of yacc.c */
#line 1024 "../../JavaScriptCore/parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4444,8 +4122,6 @@ yyreduce:
break;
case 256:
-
-/* Line 1455 of yacc.c */
#line 1028 "../../JavaScriptCore/parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4454,8 +4130,6 @@ yyreduce:
break;
case 257:
-
-/* Line 1455 of yacc.c */
#line 1032 "../../JavaScriptCore/parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4464,8 +4138,6 @@ yyreduce:
break;
case 258:
-
-/* Line 1455 of yacc.c */
#line 1036 "../../JavaScriptCore/parser/Grammar.y"
{ ContinueNode* node = new (GLOBAL_DATA) ContinueNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4474,8 +4146,6 @@ yyreduce:
break;
case 259:
-
-/* Line 1455 of yacc.c */
#line 1043 "../../JavaScriptCore/parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4483,8 +4153,6 @@ yyreduce:
break;
case 260:
-
-/* Line 1455 of yacc.c */
#line 1046 "../../JavaScriptCore/parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4492,8 +4160,6 @@ yyreduce:
break;
case 261:
-
-/* Line 1455 of yacc.c */
#line 1049 "../../JavaScriptCore/parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4501,8 +4167,6 @@ yyreduce:
break;
case 262:
-
-/* Line 1455 of yacc.c */
#line 1052 "../../JavaScriptCore/parser/Grammar.y"
{ BreakNode* node = new (GLOBAL_DATA) BreakNode(GLOBAL_DATA, *(yyvsp[(2) - (3)].ident));
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4510,8 +4174,6 @@ yyreduce:
break;
case 263:
-
-/* Line 1455 of yacc.c */
#line 1058 "../../JavaScriptCore/parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, 0);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4519,8 +4181,6 @@ yyreduce:
break;
case 264:
-
-/* Line 1455 of yacc.c */
#line 1061 "../../JavaScriptCore/parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, 0);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (2)]).first_column, (yylsp[(1) - (2)]).last_column, (yylsp[(1) - (2)]).last_column);
@@ -4528,8 +4188,6 @@ yyreduce:
break;
case 265:
-
-/* Line 1455 of yacc.c */
#line 1064 "../../JavaScriptCore/parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4537,8 +4195,6 @@ yyreduce:
break;
case 266:
-
-/* Line 1455 of yacc.c */
#line 1067 "../../JavaScriptCore/parser/Grammar.y"
{ ReturnNode* node = new (GLOBAL_DATA) ReturnNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4546,8 +4202,6 @@ yyreduce:
break;
case 267:
-
-/* Line 1455 of yacc.c */
#line 1073 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) WithNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].statementNode).m_node, (yylsp[(3) - (5)]).last_column, (yylsp[(3) - (5)]).last_column - (yylsp[(3) - (5)]).first_column),
(yyvsp[(5) - (5)].statementNode).m_varDeclarations, (yyvsp[(5) - (5)].statementNode).m_funcDeclarations, (yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].statementNode).m_features | WithFeature, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].statementNode).m_numConstants);
@@ -4555,8 +4209,6 @@ yyreduce:
break;
case 268:
-
-/* Line 1455 of yacc.c */
#line 1079 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) SwitchNode(GLOBAL_DATA, (yyvsp[(3) - (5)].expressionNode).m_node, (yyvsp[(5) - (5)].caseBlockNode).m_node), (yyvsp[(5) - (5)].caseBlockNode).m_varDeclarations, (yyvsp[(5) - (5)].caseBlockNode).m_funcDeclarations,
(yyvsp[(3) - (5)].expressionNode).m_features | (yyvsp[(5) - (5)].caseBlockNode).m_features, (yyvsp[(3) - (5)].expressionNode).m_numConstants + (yyvsp[(5) - (5)].caseBlockNode).m_numConstants);
@@ -4564,15 +4216,11 @@ yyreduce:
break;
case 269:
-
-/* Line 1455 of yacc.c */
#line 1085 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseBlockNode) = createNodeDeclarationInfo<CaseBlockNode*>(new (GLOBAL_DATA) CaseBlockNode(GLOBAL_DATA, (yyvsp[(2) - (3)].clauseList).m_node.head, 0, 0), (yyvsp[(2) - (3)].clauseList).m_varDeclarations, (yyvsp[(2) - (3)].clauseList).m_funcDeclarations, (yyvsp[(2) - (3)].clauseList).m_features, (yyvsp[(2) - (3)].clauseList).m_numConstants); ;}
break;
case 270:
-
-/* Line 1455 of yacc.c */
#line 1087 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseBlockNode) = createNodeDeclarationInfo<CaseBlockNode*>(new (GLOBAL_DATA) CaseBlockNode(GLOBAL_DATA, (yyvsp[(2) - (5)].clauseList).m_node.head, (yyvsp[(3) - (5)].caseClauseNode).m_node, (yyvsp[(4) - (5)].clauseList).m_node.head),
mergeDeclarationLists(mergeDeclarationLists((yyvsp[(2) - (5)].clauseList).m_varDeclarations, (yyvsp[(3) - (5)].caseClauseNode).m_varDeclarations), (yyvsp[(4) - (5)].clauseList).m_varDeclarations),
@@ -4582,15 +4230,11 @@ yyreduce:
break;
case 271:
-
-/* Line 1455 of yacc.c */
#line 1095 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.clauseList).m_node.head = 0; (yyval.clauseList).m_node.tail = 0; (yyval.clauseList).m_varDeclarations = 0; (yyval.clauseList).m_funcDeclarations = 0; (yyval.clauseList).m_features = 0; (yyval.clauseList).m_numConstants = 0; ;}
break;
case 273:
-
-/* Line 1455 of yacc.c */
#line 1100 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.clauseList).m_node.head = new (GLOBAL_DATA) ClauseListNode(GLOBAL_DATA, (yyvsp[(1) - (1)].caseClauseNode).m_node);
(yyval.clauseList).m_node.tail = (yyval.clauseList).m_node.head;
@@ -4601,8 +4245,6 @@ yyreduce:
break;
case 274:
-
-/* Line 1455 of yacc.c */
#line 1106 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.clauseList).m_node.head = (yyvsp[(1) - (2)].clauseList).m_node.head;
(yyval.clauseList).m_node.tail = new (GLOBAL_DATA) ClauseListNode(GLOBAL_DATA, (yyvsp[(1) - (2)].clauseList).m_node.tail, (yyvsp[(2) - (2)].caseClauseNode).m_node);
@@ -4614,36 +4256,26 @@ yyreduce:
break;
case 275:
-
-/* Line 1455 of yacc.c */
#line 1116 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node), 0, 0, (yyvsp[(2) - (3)].expressionNode).m_features, (yyvsp[(2) - (3)].expressionNode).m_numConstants); ;}
break;
case 276:
-
-/* Line 1455 of yacc.c */
#line 1117 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, (yyvsp[(2) - (4)].expressionNode).m_node, (yyvsp[(4) - (4)].sourceElements).m_node), (yyvsp[(4) - (4)].sourceElements).m_varDeclarations, (yyvsp[(4) - (4)].sourceElements).m_funcDeclarations, (yyvsp[(2) - (4)].expressionNode).m_features | (yyvsp[(4) - (4)].sourceElements).m_features, (yyvsp[(2) - (4)].expressionNode).m_numConstants + (yyvsp[(4) - (4)].sourceElements).m_numConstants); ;}
break;
case 277:
-
-/* Line 1455 of yacc.c */
#line 1121 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, 0), 0, 0, 0, 0); ;}
break;
case 278:
-
-/* Line 1455 of yacc.c */
#line 1122 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.caseClauseNode) = createNodeDeclarationInfo<CaseClauseNode*>(new (GLOBAL_DATA) CaseClauseNode(GLOBAL_DATA, 0, (yyvsp[(3) - (3)].sourceElements).m_node), (yyvsp[(3) - (3)].sourceElements).m_varDeclarations, (yyvsp[(3) - (3)].sourceElements).m_funcDeclarations, (yyvsp[(3) - (3)].sourceElements).m_features, (yyvsp[(3) - (3)].sourceElements).m_numConstants); ;}
break;
case 279:
-
-/* Line 1455 of yacc.c */
#line 1126 "../../JavaScriptCore/parser/Grammar.y"
{ LabelNode* node = new (GLOBAL_DATA) LabelNode(GLOBAL_DATA, *(yyvsp[(1) - (3)].ident), (yyvsp[(3) - (3)].statementNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4651,8 +4283,6 @@ yyreduce:
break;
case 280:
-
-/* Line 1455 of yacc.c */
#line 1132 "../../JavaScriptCore/parser/Grammar.y"
{ ThrowNode* node = new (GLOBAL_DATA) ThrowNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4661,8 +4291,6 @@ yyreduce:
break;
case 281:
-
-/* Line 1455 of yacc.c */
#line 1136 "../../JavaScriptCore/parser/Grammar.y"
{ ThrowNode* node = new (GLOBAL_DATA) ThrowNode(GLOBAL_DATA, (yyvsp[(2) - (3)].expressionNode).m_node);
SET_EXCEPTION_LOCATION(node, (yylsp[(1) - (3)]).first_column, (yylsp[(2) - (3)]).last_column, (yylsp[(2) - (3)]).last_column);
@@ -4671,8 +4299,6 @@ yyreduce:
break;
case 282:
-
-/* Line 1455 of yacc.c */
#line 1143 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (4)].statementNode).m_node, GLOBAL_DATA->propertyNames->nullIdentifier, false, 0, (yyvsp[(4) - (4)].statementNode).m_node),
mergeDeclarationLists((yyvsp[(2) - (4)].statementNode).m_varDeclarations, (yyvsp[(4) - (4)].statementNode).m_varDeclarations),
@@ -4683,8 +4309,6 @@ yyreduce:
break;
case 283:
-
-/* Line 1455 of yacc.c */
#line 1149 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (7)].statementNode).m_node, *(yyvsp[(5) - (7)].ident), ((yyvsp[(7) - (7)].statementNode).m_features & EvalFeature) != 0, (yyvsp[(7) - (7)].statementNode).m_node, 0),
mergeDeclarationLists((yyvsp[(2) - (7)].statementNode).m_varDeclarations, (yyvsp[(7) - (7)].statementNode).m_varDeclarations),
@@ -4695,8 +4319,6 @@ yyreduce:
break;
case 284:
-
-/* Line 1455 of yacc.c */
#line 1156 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) TryNode(GLOBAL_DATA, (yyvsp[(2) - (9)].statementNode).m_node, *(yyvsp[(5) - (9)].ident), ((yyvsp[(7) - (9)].statementNode).m_features & EvalFeature) != 0, (yyvsp[(7) - (9)].statementNode).m_node, (yyvsp[(9) - (9)].statementNode).m_node),
mergeDeclarationLists(mergeDeclarationLists((yyvsp[(2) - (9)].statementNode).m_varDeclarations, (yyvsp[(7) - (9)].statementNode).m_varDeclarations), (yyvsp[(9) - (9)].statementNode).m_varDeclarations),
@@ -4707,31 +4329,23 @@ yyreduce:
break;
case 285:
-
-/* Line 1455 of yacc.c */
#line 1165 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DebuggerStatementNode(GLOBAL_DATA), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(2) - (2)])); ;}
break;
case 286:
-
-/* Line 1455 of yacc.c */
#line 1167 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new (GLOBAL_DATA) DebuggerStatementNode(GLOBAL_DATA), 0, 0, 0, 0);
DBG((yyval.statementNode).m_node, (yylsp[(1) - (2)]), (yylsp[(1) - (2)])); AUTO_SEMICOLON; ;}
break;
case 287:
-
-/* Line 1455 of yacc.c */
#line 1172 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new FuncDeclNode(GLOBAL_DATA, *(yyvsp[(2) - (7)].ident), (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), 0, new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::FunctionStack>, ((*(yyvsp[(2) - (7)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); (yyval.statementNode).m_funcDeclarations->data.append(static_cast<FuncDeclNode*>((yyval.statementNode).m_node)); ;}
break;
case 288:
-
-/* Line 1455 of yacc.c */
#line 1174 "../../JavaScriptCore/parser/Grammar.y"
{
(yyval.statementNode) = createNodeDeclarationInfo<StatementNode*>(new FuncDeclNode(GLOBAL_DATA, *(yyvsp[(2) - (8)].ident), (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line), (yyvsp[(4) - (8)].parameterList).m_node.head), 0, new (GLOBAL_DATA) ParserArenaData<DeclarationStacks::FunctionStack>, ((*(yyvsp[(2) - (8)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0) | (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -4743,15 +4357,11 @@ yyreduce:
break;
case 289:
-
-/* Line 1455 of yacc.c */
#line 1184 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, GLOBAL_DATA->propertyNames->nullIdentifier, (yyvsp[(5) - (6)].functionBodyNode), LEXER->sourceCode((yyvsp[(4) - (6)].intValue), (yyvsp[(6) - (6)].intValue), (yylsp[(4) - (6)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(5) - (6)].functionBodyNode), (yylsp[(4) - (6)]), (yylsp[(6) - (6)])); ;}
break;
case 290:
-
-/* Line 1455 of yacc.c */
#line 1186 "../../JavaScriptCore/parser/Grammar.y"
{
(yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, GLOBAL_DATA->propertyNames->nullIdentifier, (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line), (yyvsp[(3) - (7)].parameterList).m_node.head), (yyvsp[(3) - (7)].parameterList).m_features | ClosureFeature, 0);
@@ -4762,15 +4372,11 @@ yyreduce:
break;
case 291:
-
-/* Line 1455 of yacc.c */
#line 1192 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, *(yyvsp[(2) - (7)].ident), (yyvsp[(6) - (7)].functionBodyNode), LEXER->sourceCode((yyvsp[(5) - (7)].intValue), (yyvsp[(7) - (7)].intValue), (yylsp[(5) - (7)]).first_line)), ClosureFeature, 0); DBG((yyvsp[(6) - (7)].functionBodyNode), (yylsp[(5) - (7)]), (yylsp[(7) - (7)])); ;}
break;
case 292:
-
-/* Line 1455 of yacc.c */
#line 1194 "../../JavaScriptCore/parser/Grammar.y"
{
(yyval.funcExprNode) = createNodeInfo(new FuncExprNode(GLOBAL_DATA, *(yyvsp[(2) - (8)].ident), (yyvsp[(7) - (8)].functionBodyNode), LEXER->sourceCode((yyvsp[(6) - (8)].intValue), (yyvsp[(8) - (8)].intValue), (yylsp[(6) - (8)]).first_line), (yyvsp[(4) - (8)].parameterList).m_node.head), (yyvsp[(4) - (8)].parameterList).m_features | ClosureFeature, 0);
@@ -4781,8 +4387,6 @@ yyreduce:
break;
case 293:
-
-/* Line 1455 of yacc.c */
#line 1203 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.parameterList).m_node.head = new (GLOBAL_DATA) ParameterNode(GLOBAL_DATA, *(yyvsp[(1) - (1)].ident));
(yyval.parameterList).m_features = (*(yyvsp[(1) - (1)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0;
@@ -4790,8 +4394,6 @@ yyreduce:
break;
case 294:
-
-/* Line 1455 of yacc.c */
#line 1206 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.parameterList).m_node.head = (yyvsp[(1) - (3)].parameterList).m_node.head;
(yyval.parameterList).m_features = (yyvsp[(1) - (3)].parameterList).m_features | ((*(yyvsp[(3) - (3)].ident) == GLOBAL_DATA->propertyNames->arguments) ? ArgumentsFeature : 0);
@@ -4799,37 +4401,27 @@ yyreduce:
break;
case 295:
-
-/* Line 1455 of yacc.c */
#line 1212 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.functionBodyNode) = FunctionBodyNode::create(GLOBAL_DATA); ;}
break;
case 296:
-
-/* Line 1455 of yacc.c */
#line 1213 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.functionBodyNode) = FunctionBodyNode::create(GLOBAL_DATA); ;}
break;
case 297:
-
-/* Line 1455 of yacc.c */
#line 1217 "../../JavaScriptCore/parser/Grammar.y"
{ GLOBAL_DATA->parser->didFinishParsing(new (GLOBAL_DATA) SourceElements(GLOBAL_DATA), 0, 0, NoFeatures, (yylsp[(0) - (0)]).last_line, 0); ;}
break;
case 298:
-
-/* Line 1455 of yacc.c */
#line 1218 "../../JavaScriptCore/parser/Grammar.y"
{ GLOBAL_DATA->parser->didFinishParsing((yyvsp[(1) - (1)].sourceElements).m_node, (yyvsp[(1) - (1)].sourceElements).m_varDeclarations, (yyvsp[(1) - (1)].sourceElements).m_funcDeclarations, (yyvsp[(1) - (1)].sourceElements).m_features,
(yylsp[(1) - (1)]).last_line, (yyvsp[(1) - (1)].sourceElements).m_numConstants); ;}
break;
case 299:
-
-/* Line 1455 of yacc.c */
#line 1223 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.sourceElements).m_node = new (GLOBAL_DATA) SourceElements(GLOBAL_DATA);
(yyval.sourceElements).m_node->append((yyvsp[(1) - (1)].statementNode).m_node);
@@ -4841,8 +4433,6 @@ yyreduce:
break;
case 300:
-
-/* Line 1455 of yacc.c */
#line 1230 "../../JavaScriptCore/parser/Grammar.y"
{ (yyval.sourceElements).m_node->append((yyvsp[(2) - (2)].statementNode).m_node);
(yyval.sourceElements).m_varDeclarations = mergeDeclarationLists((yyvsp[(1) - (2)].sourceElements).m_varDeclarations, (yyvsp[(2) - (2)].statementNode).m_varDeclarations);
@@ -4853,261 +4443,188 @@ yyreduce:
break;
case 304:
-
-/* Line 1455 of yacc.c */
#line 1244 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 305:
-
-/* Line 1455 of yacc.c */
#line 1245 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 306:
-
-/* Line 1455 of yacc.c */
#line 1246 "../../JavaScriptCore/parser/Grammar.y"
{ Lexer& l = *LEXER; if (!l.scanRegExp()) YYABORT; ;}
break;
case 307:
-
-/* Line 1455 of yacc.c */
#line 1247 "../../JavaScriptCore/parser/Grammar.y"
{ Lexer& l = *LEXER; if (!l.scanRegExp()) YYABORT; ;}
break;
case 308:
-
-/* Line 1455 of yacc.c */
#line 1251 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 309:
-
-/* Line 1455 of yacc.c */
#line 1252 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 310:
-
-/* Line 1455 of yacc.c */
#line 1253 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 311:
-
-/* Line 1455 of yacc.c */
#line 1254 "../../JavaScriptCore/parser/Grammar.y"
{ if (*(yyvsp[(1) - (7)].ident) != "get" && *(yyvsp[(1) - (7)].ident) != "set") YYABORT; ;}
break;
case 312:
-
-/* Line 1455 of yacc.c */
#line 1255 "../../JavaScriptCore/parser/Grammar.y"
{ if (*(yyvsp[(1) - (8)].ident) != "get" && *(yyvsp[(1) - (8)].ident) != "set") YYABORT; ;}
break;
case 316:
-
-/* Line 1455 of yacc.c */
#line 1265 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 317:
-
-/* Line 1455 of yacc.c */
#line 1266 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 318:
-
-/* Line 1455 of yacc.c */
#line 1268 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 322:
-
-/* Line 1455 of yacc.c */
#line 1275 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 517:
-
-/* Line 1455 of yacc.c */
#line 1643 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 518:
-
-/* Line 1455 of yacc.c */
#line 1644 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 520:
-
-/* Line 1455 of yacc.c */
#line 1649 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 521:
-
-/* Line 1455 of yacc.c */
#line 1653 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 522:
-
-/* Line 1455 of yacc.c */
#line 1654 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 525:
-
-/* Line 1455 of yacc.c */
#line 1660 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 526:
-
-/* Line 1455 of yacc.c */
#line 1661 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 530:
-
-/* Line 1455 of yacc.c */
#line 1668 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 533:
-
-/* Line 1455 of yacc.c */
#line 1677 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 534:
-
-/* Line 1455 of yacc.c */
#line 1678 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 539:
-
-/* Line 1455 of yacc.c */
#line 1695 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 555:
-
-/* Line 1455 of yacc.c */
#line 1726 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 557:
-
-/* Line 1455 of yacc.c */
#line 1728 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 559:
-
-/* Line 1455 of yacc.c */
#line 1733 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 561:
-
-/* Line 1455 of yacc.c */
#line 1735 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 563:
-
-/* Line 1455 of yacc.c */
#line 1740 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 565:
-
-/* Line 1455 of yacc.c */
#line 1742 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 568:
-
-/* Line 1455 of yacc.c */
#line 1754 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 569:
-
-/* Line 1455 of yacc.c */
#line 1755 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 578:
-
-/* Line 1455 of yacc.c */
#line 1779 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
case 580:
-
-/* Line 1455 of yacc.c */
#line 1784 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 585:
-
-/* Line 1455 of yacc.c */
#line 1795 "../../JavaScriptCore/parser/Grammar.y"
{ AUTO_SEMICOLON; ;}
break;
case 592:
-
-/* Line 1455 of yacc.c */
#line 1811 "../../JavaScriptCore/parser/Grammar.y"
{ ;}
break;
-
-/* Line 1455 of yacc.c */
-#line 5111 "WebCore/tmp/../generated/Grammar.tab.c"
+/* Line 1267 of yacc.c. */
+#line 4628 "WebCore/tmp/../generated/Grammar.tab.c"
default: break;
}
YY_SYMBOL_PRINT ("-> $$ =", yyr1[yyn], &yyval, &yyloc);
@@ -5183,7 +4700,7 @@ yyerrlab:
if (yyerrstatus == 3)
{
- /* If just tried and failed to reuse lookahead token after an
+ /* If just tried and failed to reuse look-ahead token after an
error, discard it. */
if (yychar <= YYEOF)
@@ -5200,7 +4717,7 @@ yyerrlab:
}
}
- /* Else will try to reuse lookahead token after shifting the error
+ /* Else will try to reuse look-ahead token after shifting the error
token. */
goto yyerrlab1;
@@ -5258,11 +4775,14 @@ yyerrlab1:
YY_STACK_PRINT (yyss, yyssp);
}
+ if (yyn == YYFINAL)
+ YYACCEPT;
+
*++yyvsp = yylval;
yyerror_range[1] = yylloc;
/* Using YYLLOC is tempting, but would change the location of
- the lookahead. YYLOC is available though. */
+ the look-ahead. YYLOC is available though. */
YYLLOC_DEFAULT (yyloc, (yyerror_range - 1), 2);
*++yylsp = yyloc;
@@ -5287,7 +4807,7 @@ yyabortlab:
yyresult = 1;
goto yyreturn;
-#if !defined(yyoverflow) || YYERROR_VERBOSE
+#ifndef yyoverflow
/*-------------------------------------------------.
| yyexhaustedlab -- memory exhaustion comes here. |
`-------------------------------------------------*/
@@ -5298,7 +4818,7 @@ yyexhaustedlab:
#endif
yyreturn:
- if (yychar != YYEMPTY)
+ if (yychar != YYEOF && yychar != YYEMPTY)
yydestruct ("Cleanup: discarding lookahead",
yytoken, &yylval, &yylloc);
/* Do not reclaim the symbols of the rule which action triggered
@@ -5324,8 +4844,6 @@ yyreturn:
}
-
-/* Line 1675 of yacc.c */
#line 1827 "../../JavaScriptCore/parser/Grammar.y"
@@ -5574,10 +5092,14 @@ static bool allowAutomaticSemicolon(Lexer& lexer, int yychar)
return yychar == CLOSEBRACE || yychar == 0 || lexer.prevTerminator();
}
-static ExpressionNode* combineVarInitializers(void* globalPtr, ExpressionNode* list, AssignResolveNode* init)
+static ExpressionNode* combineCommaNodes(void* globalPtr, ExpressionNode* list, ExpressionNode* init)
{
if (!list)
return init;
+ if (list->isCommaNode()) {
+ static_cast<CommaNode*>(list)->append(init);
+ return list;
+ }
return new (GLOBAL_DATA) CommaNode(GLOBAL_DATA, list, init);
}
diff --git a/src/3rdparty/webkit/WebCore/generated/Grammar.h b/src/3rdparty/webkit/WebCore/generated/Grammar.h
index 34b0b37..4188cd8 100644
--- a/src/3rdparty/webkit/WebCore/generated/Grammar.h
+++ b/src/3rdparty/webkit/WebCore/generated/Grammar.h
@@ -1,23 +1,24 @@
-
-/* A Bison parser, made by GNU Bison 2.4.1. */
+/* A Bison parser, made by GNU Bison 2.3. */
/* Skeleton interface for Bison's Yacc-like parsers in C
-
- Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
+
+ Copyright (C) 1984, 1989, 1990, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
-
- This program is free software: you can redistribute it and/or modify
+
+ This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA. */
/* As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
@@ -28,11 +29,10 @@
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
-
+
This special exception was added by the Free Software Foundation in
version 2.2 of Bison. */
-
/* Tokens. */
#ifndef YYTOKENTYPE
# define YYTOKENTYPE
@@ -104,16 +104,78 @@
AUTOMINUSMINUS = 320
};
#endif
+/* Tokens. */
+#define NULLTOKEN 258
+#define TRUETOKEN 259
+#define FALSETOKEN 260
+#define BREAK 261
+#define CASE 262
+#define DEFAULT 263
+#define FOR 264
+#define NEW 265
+#define VAR 266
+#define CONSTTOKEN 267
+#define CONTINUE 268
+#define FUNCTION 269
+#define RETURN 270
+#define VOIDTOKEN 271
+#define DELETETOKEN 272
+#define IF 273
+#define THISTOKEN 274
+#define DO 275
+#define WHILE 276
+#define INTOKEN 277
+#define INSTANCEOF 278
+#define TYPEOF 279
+#define SWITCH 280
+#define WITH 281
+#define RESERVED 282
+#define THROW 283
+#define TRY 284
+#define CATCH 285
+#define FINALLY 286
+#define DEBUGGER 287
+#define IF_WITHOUT_ELSE 288
+#define ELSE 289
+#define EQEQ 290
+#define NE 291
+#define STREQ 292
+#define STRNEQ 293
+#define LE 294
+#define GE 295
+#define OR 296
+#define AND 297
+#define PLUSPLUS 298
+#define MINUSMINUS 299
+#define LSHIFT 300
+#define RSHIFT 301
+#define URSHIFT 302
+#define PLUSEQUAL 303
+#define MINUSEQUAL 304
+#define MULTEQUAL 305
+#define DIVEQUAL 306
+#define LSHIFTEQUAL 307
+#define RSHIFTEQUAL 308
+#define URSHIFTEQUAL 309
+#define ANDEQUAL 310
+#define MODEQUAL 311
+#define XOREQUAL 312
+#define OREQUAL 313
+#define OPENBRACE 314
+#define CLOSEBRACE 315
+#define NUMBER 316
+#define IDENT 317
+#define STRING 318
+#define AUTOPLUSPLUS 319
+#define AUTOMINUSMINUS 320
+
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE
-{
-
-/* Line 1676 of yacc.c */
#line 157 "../../JavaScriptCore/parser/Grammar.y"
-
+{
int intValue;
double doubleValue;
Identifier* ident;
@@ -143,15 +205,13 @@ typedef union YYSTYPE
ParameterListInfo parameterList;
Operator op;
-
-
-
-/* Line 1676 of yacc.c */
-#line 151 "WebCore/tmp/../generated/Grammar.tab.h"
-} YYSTYPE;
-# define YYSTYPE_IS_TRIVIAL 1
+}
+/* Line 1489 of yacc.c. */
+#line 211 "WebCore/tmp/../generated/Grammar.tab.h"
+ YYSTYPE;
# define yystype YYSTYPE /* obsolescent; will be withdrawn */
# define YYSTYPE_IS_DECLARED 1
+# define YYSTYPE_IS_TRIVIAL 1
#endif
@@ -170,4 +230,3 @@ typedef struct YYLTYPE
#endif
-
diff --git a/src/3rdparty/webkit/WebCore/generated/HTMLElementFactory.cpp b/src/3rdparty/webkit/WebCore/generated/HTMLElementFactory.cpp
index 590c238..d14bc93 100644
--- a/src/3rdparty/webkit/WebCore/generated/HTMLElementFactory.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/HTMLElementFactory.cpp
@@ -51,10 +51,14 @@
#include "HTMLCanvasElement.h"
#include "HTMLTableCaptionElement.h"
#include "HTMLTableColElement.h"
+#include "HTMLDataGridElement.h"
+#include "HTMLDataGridCellElement.h"
+#include "HTMLDataGridColElement.h"
#include "HTMLModElement.h"
#include "HTMLDirectoryElement.h"
#include "HTMLDivElement.h"
#include "HTMLDListElement.h"
+#include "HTMLDataGridRowElement.h"
#include "HTMLEmbedElement.h"
#include "HTMLFieldSetElement.h"
#include "HTMLFontElement.h"
@@ -180,6 +184,21 @@ static PassRefPtr<HTMLElement> tablecolConstructor(const QualifiedName& tagName,
return new HTMLTableColElement(tagName, doc);
}
+static PassRefPtr<HTMLElement> datagridConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
+{
+ return new HTMLDataGridElement(tagName, doc);
+}
+
+static PassRefPtr<HTMLElement> datagridcellConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
+{
+ return new HTMLDataGridCellElement(tagName, doc);
+}
+
+static PassRefPtr<HTMLElement> datagridcolConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
+{
+ return new HTMLDataGridColElement(tagName, doc);
+}
+
static PassRefPtr<HTMLElement> modConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
{
return new HTMLModElement(tagName, doc);
@@ -200,6 +219,11 @@ static PassRefPtr<HTMLElement> dlistConstructor(const QualifiedName& tagName, Do
return new HTMLDListElement(tagName, doc);
}
+static PassRefPtr<HTMLElement> datagridrowConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
+{
+ return new HTMLDataGridRowElement(tagName, doc);
+}
+
static PassRefPtr<HTMLElement> embedConstructor(const QualifiedName& tagName, Document* doc, HTMLFormElement*, bool)
{
return new HTMLEmbedElement(tagName, doc);
@@ -462,10 +486,14 @@ static inline void createFunctionMapIfNecessary()
addTag(captionTag, tablecaptionConstructor);
addTag(colTag, tablecolConstructor);
addTag(colgroupTag, tablecolConstructor);
+ addTag(datagridTag, datagridConstructor);
+ addTag(dcellTag, datagridcellConstructor);
+ addTag(dcolTag, datagridcolConstructor);
addTag(delTag, modConstructor);
addTag(dirTag, directoryConstructor);
addTag(divTag, divConstructor);
addTag(dlTag, dlistConstructor);
+ addTag(drowTag, datagridrowConstructor);
addTag(embedTag, embedConstructor);
addTag(fieldsetTag, fieldsetConstructor);
addTag(fontTag, fontConstructor);
diff --git a/src/3rdparty/webkit/WebCore/generated/HTMLNames.cpp b/src/3rdparty/webkit/WebCore/generated/HTMLNames.cpp
index 84c48c0..4e23159 100644
--- a/src/3rdparty/webkit/WebCore/generated/HTMLNames.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/HTMLNames.cpp
@@ -68,12 +68,16 @@ DEFINE_GLOBAL(QualifiedName, citeTag, nullAtom, "cite", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, codeTag, nullAtom, "code", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, colTag, nullAtom, "col", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, colgroupTag, nullAtom, "colgroup", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, datagridTag, nullAtom, "datagrid", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, dcellTag, nullAtom, "dcell", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, dcolTag, nullAtom, "dcol", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, ddTag, nullAtom, "dd", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, delTag, nullAtom, "del", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, dfnTag, nullAtom, "dfn", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, dirTag, nullAtom, "dir", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, divTag, nullAtom, "div", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, dlTag, nullAtom, "dl", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, drowTag, nullAtom, "drow", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, dtTag, nullAtom, "dt", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, emTag, nullAtom, "em", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, embedTag, nullAtom, "embed", xhtmlNamespaceURI);
@@ -180,12 +184,16 @@ WebCore::QualifiedName** getHTMLTags(size_t* size)
(WebCore::QualifiedName*)&codeTag,
(WebCore::QualifiedName*)&colTag,
(WebCore::QualifiedName*)&colgroupTag,
+ (WebCore::QualifiedName*)&datagridTag,
+ (WebCore::QualifiedName*)&dcellTag,
+ (WebCore::QualifiedName*)&dcolTag,
(WebCore::QualifiedName*)&ddTag,
(WebCore::QualifiedName*)&delTag,
(WebCore::QualifiedName*)&dfnTag,
(WebCore::QualifiedName*)&dirTag,
(WebCore::QualifiedName*)&divTag,
(WebCore::QualifiedName*)&dlTag,
+ (WebCore::QualifiedName*)&drowTag,
(WebCore::QualifiedName*)&dtTag,
(WebCore::QualifiedName*)&emTag,
(WebCore::QualifiedName*)&embedTag,
@@ -265,7 +273,7 @@ WebCore::QualifiedName** getHTMLTags(size_t* size)
(WebCore::QualifiedName*)&wbrTag,
(WebCore::QualifiedName*)&xmpTag,
};
- *size = 107;
+ *size = 111;
return HTMLTags;
}
@@ -282,10 +290,13 @@ DEFINE_GLOBAL(QualifiedName, archiveAttr, nullAtom, "archive", xhtmlNamespaceURI
DEFINE_GLOBAL(QualifiedName, aria_activedescendantAttr, nullAtom, "aria_activedescendant", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_checkedAttr, nullAtom, "aria_checked", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_describedbyAttr, nullAtom, "aria_describedby", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, aria_disabledAttr, nullAtom, "aria_disabled", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, aria_hiddenAttr, nullAtom, "aria_hidden", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_labeledbyAttr, nullAtom, "aria_labeledby", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_labelledbyAttr, nullAtom, "aria_labelledby", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_levelAttr, nullAtom, "aria_level", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_pressedAttr, nullAtom, "aria_pressed", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, aria_readonlyAttr, nullAtom, "aria_readonly", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_valuemaxAttr, nullAtom, "aria_valuemax", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_valueminAttr, nullAtom, "aria_valuemin", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, aria_valuenowAttr, nullAtom, "aria_valuenow", xhtmlNamespaceURI);
@@ -334,7 +345,9 @@ DEFINE_GLOBAL(QualifiedName, directionAttr, nullAtom, "direction", xhtmlNamespac
DEFINE_GLOBAL(QualifiedName, disabledAttr, nullAtom, "disabled", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, enctypeAttr, nullAtom, "enctype", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, endAttr, nullAtom, "end", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, expandedAttr, nullAtom, "expanded", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, faceAttr, nullAtom, "face", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, focusedAttr, nullAtom, "focused", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, forAttr, nullAtom, "for", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, frameAttr, nullAtom, "frame", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, frameborderAttr, nullAtom, "frameborder", xhtmlNamespaceURI);
@@ -347,6 +360,7 @@ DEFINE_GLOBAL(QualifiedName, hspaceAttr, nullAtom, "hspace", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, http_equivAttr, nullAtom, "http_equiv", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, idAttr, nullAtom, "id", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, incrementalAttr, nullAtom, "incremental", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, indeterminateAttr, nullAtom, "indeterminate", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, ismapAttr, nullAtom, "ismap", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, keytypeAttr, nullAtom, "keytype", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, labelAttr, nullAtom, "label", xhtmlNamespaceURI);
@@ -381,6 +395,8 @@ DEFINE_GLOBAL(QualifiedName, onbeforecutAttr, nullAtom, "onbeforecut", xhtmlName
DEFINE_GLOBAL(QualifiedName, onbeforepasteAttr, nullAtom, "onbeforepaste", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onbeforeunloadAttr, nullAtom, "onbeforeunload", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onblurAttr, nullAtom, "onblur", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, oncanplayAttr, nullAtom, "oncanplay", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, oncanplaythroughAttr, nullAtom, "oncanplaythrough", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onchangeAttr, nullAtom, "onchange", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onclickAttr, nullAtom, "onclick", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, oncontextmenuAttr, nullAtom, "oncontextmenu", xhtmlNamespaceURI);
@@ -394,6 +410,9 @@ DEFINE_GLOBAL(QualifiedName, ondragleaveAttr, nullAtom, "ondragleave", xhtmlName
DEFINE_GLOBAL(QualifiedName, ondragoverAttr, nullAtom, "ondragover", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, ondragstartAttr, nullAtom, "ondragstart", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, ondropAttr, nullAtom, "ondrop", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, ondurationchangeAttr, nullAtom, "ondurationchange", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onemptiedAttr, nullAtom, "onemptied", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onendedAttr, nullAtom, "onended", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onerrorAttr, nullAtom, "onerror", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onfocusAttr, nullAtom, "onfocus", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, oninputAttr, nullAtom, "oninput", xhtmlNamespaceURI);
@@ -401,6 +420,9 @@ DEFINE_GLOBAL(QualifiedName, onkeydownAttr, nullAtom, "onkeydown", xhtmlNamespac
DEFINE_GLOBAL(QualifiedName, onkeypressAttr, nullAtom, "onkeypress", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onkeyupAttr, nullAtom, "onkeyup", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onloadAttr, nullAtom, "onload", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onloadeddataAttr, nullAtom, "onloadeddata", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onloadedmetadataAttr, nullAtom, "onloadedmetadata", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onloadstartAttr, nullAtom, "onloadstart", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onmousedownAttr, nullAtom, "onmousedown", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onmousemoveAttr, nullAtom, "onmousemove", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onmouseoutAttr, nullAtom, "onmouseout", xhtmlNamespaceURI);
@@ -410,15 +432,27 @@ DEFINE_GLOBAL(QualifiedName, onmousewheelAttr, nullAtom, "onmousewheel", xhtmlNa
DEFINE_GLOBAL(QualifiedName, onofflineAttr, nullAtom, "onoffline", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, ononlineAttr, nullAtom, "ononline", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onpasteAttr, nullAtom, "onpaste", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onpauseAttr, nullAtom, "onpause", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onplayAttr, nullAtom, "onplay", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onplayingAttr, nullAtom, "onplaying", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onprogressAttr, nullAtom, "onprogress", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onratechangeAttr, nullAtom, "onratechange", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onresetAttr, nullAtom, "onreset", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onresizeAttr, nullAtom, "onresize", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onscrollAttr, nullAtom, "onscroll", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onsearchAttr, nullAtom, "onsearch", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onseekedAttr, nullAtom, "onseeked", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onseekingAttr, nullAtom, "onseeking", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onselectAttr, nullAtom, "onselect", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onselectstartAttr, nullAtom, "onselectstart", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onstalledAttr, nullAtom, "onstalled", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onstorageAttr, nullAtom, "onstorage", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onsubmitAttr, nullAtom, "onsubmit", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onsuspendAttr, nullAtom, "onsuspend", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, ontimeupdateAttr, nullAtom, "ontimeupdate", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onunloadAttr, nullAtom, "onunload", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onvolumechangeAttr, nullAtom, "onvolumechange", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, onwaitingAttr, nullAtom, "onwaiting", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onwebkitanimationendAttr, nullAtom, "onwebkitanimationend", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onwebkitanimationiterationAttr, nullAtom, "onwebkitanimationiteration", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, onwebkitanimationstartAttr, nullAtom, "onwebkitanimationstart", xhtmlNamespaceURI);
@@ -428,7 +462,9 @@ DEFINE_GLOBAL(QualifiedName, playcountAttr, nullAtom, "playcount", xhtmlNamespac
DEFINE_GLOBAL(QualifiedName, pluginurlAttr, nullAtom, "pluginurl", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, posterAttr, nullAtom, "poster", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, precisionAttr, nullAtom, "precision", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, primaryAttr, nullAtom, "primary", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, profileAttr, nullAtom, "profile", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, progressAttr, nullAtom, "progress", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, promptAttr, nullAtom, "prompt", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, readonlyAttr, nullAtom, "readonly", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, relAttr, nullAtom, "rel", xhtmlNamespaceURI);
@@ -446,6 +482,8 @@ DEFINE_GLOBAL(QualifiedName, scrollingAttr, nullAtom, "scrolling", xhtmlNamespac
DEFINE_GLOBAL(QualifiedName, selectedAttr, nullAtom, "selected", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, shapeAttr, nullAtom, "shape", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, sizeAttr, nullAtom, "size", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, sortableAttr, nullAtom, "sortable", xhtmlNamespaceURI);
+DEFINE_GLOBAL(QualifiedName, sortdirectionAttr, nullAtom, "sortdirection", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, spanAttr, nullAtom, "span", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, spellcheckAttr, nullAtom, "spellcheck", xhtmlNamespaceURI);
DEFINE_GLOBAL(QualifiedName, srcAttr, nullAtom, "src", xhtmlNamespaceURI);
@@ -489,10 +527,13 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&aria_activedescendantAttr,
(WebCore::QualifiedName*)&aria_checkedAttr,
(WebCore::QualifiedName*)&aria_describedbyAttr,
+ (WebCore::QualifiedName*)&aria_disabledAttr,
+ (WebCore::QualifiedName*)&aria_hiddenAttr,
(WebCore::QualifiedName*)&aria_labeledbyAttr,
(WebCore::QualifiedName*)&aria_labelledbyAttr,
(WebCore::QualifiedName*)&aria_levelAttr,
(WebCore::QualifiedName*)&aria_pressedAttr,
+ (WebCore::QualifiedName*)&aria_readonlyAttr,
(WebCore::QualifiedName*)&aria_valuemaxAttr,
(WebCore::QualifiedName*)&aria_valueminAttr,
(WebCore::QualifiedName*)&aria_valuenowAttr,
@@ -541,7 +582,9 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&disabledAttr,
(WebCore::QualifiedName*)&enctypeAttr,
(WebCore::QualifiedName*)&endAttr,
+ (WebCore::QualifiedName*)&expandedAttr,
(WebCore::QualifiedName*)&faceAttr,
+ (WebCore::QualifiedName*)&focusedAttr,
(WebCore::QualifiedName*)&forAttr,
(WebCore::QualifiedName*)&frameAttr,
(WebCore::QualifiedName*)&frameborderAttr,
@@ -554,6 +597,7 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&http_equivAttr,
(WebCore::QualifiedName*)&idAttr,
(WebCore::QualifiedName*)&incrementalAttr,
+ (WebCore::QualifiedName*)&indeterminateAttr,
(WebCore::QualifiedName*)&ismapAttr,
(WebCore::QualifiedName*)&keytypeAttr,
(WebCore::QualifiedName*)&labelAttr,
@@ -588,6 +632,8 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&onbeforepasteAttr,
(WebCore::QualifiedName*)&onbeforeunloadAttr,
(WebCore::QualifiedName*)&onblurAttr,
+ (WebCore::QualifiedName*)&oncanplayAttr,
+ (WebCore::QualifiedName*)&oncanplaythroughAttr,
(WebCore::QualifiedName*)&onchangeAttr,
(WebCore::QualifiedName*)&onclickAttr,
(WebCore::QualifiedName*)&oncontextmenuAttr,
@@ -601,6 +647,9 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&ondragoverAttr,
(WebCore::QualifiedName*)&ondragstartAttr,
(WebCore::QualifiedName*)&ondropAttr,
+ (WebCore::QualifiedName*)&ondurationchangeAttr,
+ (WebCore::QualifiedName*)&onemptiedAttr,
+ (WebCore::QualifiedName*)&onendedAttr,
(WebCore::QualifiedName*)&onerrorAttr,
(WebCore::QualifiedName*)&onfocusAttr,
(WebCore::QualifiedName*)&oninputAttr,
@@ -608,6 +657,9 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&onkeypressAttr,
(WebCore::QualifiedName*)&onkeyupAttr,
(WebCore::QualifiedName*)&onloadAttr,
+ (WebCore::QualifiedName*)&onloadeddataAttr,
+ (WebCore::QualifiedName*)&onloadedmetadataAttr,
+ (WebCore::QualifiedName*)&onloadstartAttr,
(WebCore::QualifiedName*)&onmousedownAttr,
(WebCore::QualifiedName*)&onmousemoveAttr,
(WebCore::QualifiedName*)&onmouseoutAttr,
@@ -617,15 +669,27 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&onofflineAttr,
(WebCore::QualifiedName*)&ononlineAttr,
(WebCore::QualifiedName*)&onpasteAttr,
+ (WebCore::QualifiedName*)&onpauseAttr,
+ (WebCore::QualifiedName*)&onplayAttr,
+ (WebCore::QualifiedName*)&onplayingAttr,
+ (WebCore::QualifiedName*)&onprogressAttr,
+ (WebCore::QualifiedName*)&onratechangeAttr,
(WebCore::QualifiedName*)&onresetAttr,
(WebCore::QualifiedName*)&onresizeAttr,
(WebCore::QualifiedName*)&onscrollAttr,
(WebCore::QualifiedName*)&onsearchAttr,
+ (WebCore::QualifiedName*)&onseekedAttr,
+ (WebCore::QualifiedName*)&onseekingAttr,
(WebCore::QualifiedName*)&onselectAttr,
(WebCore::QualifiedName*)&onselectstartAttr,
+ (WebCore::QualifiedName*)&onstalledAttr,
(WebCore::QualifiedName*)&onstorageAttr,
(WebCore::QualifiedName*)&onsubmitAttr,
+ (WebCore::QualifiedName*)&onsuspendAttr,
+ (WebCore::QualifiedName*)&ontimeupdateAttr,
(WebCore::QualifiedName*)&onunloadAttr,
+ (WebCore::QualifiedName*)&onvolumechangeAttr,
+ (WebCore::QualifiedName*)&onwaitingAttr,
(WebCore::QualifiedName*)&onwebkitanimationendAttr,
(WebCore::QualifiedName*)&onwebkitanimationiterationAttr,
(WebCore::QualifiedName*)&onwebkitanimationstartAttr,
@@ -635,7 +699,9 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&pluginurlAttr,
(WebCore::QualifiedName*)&posterAttr,
(WebCore::QualifiedName*)&precisionAttr,
+ (WebCore::QualifiedName*)&primaryAttr,
(WebCore::QualifiedName*)&profileAttr,
+ (WebCore::QualifiedName*)&progressAttr,
(WebCore::QualifiedName*)&promptAttr,
(WebCore::QualifiedName*)&readonlyAttr,
(WebCore::QualifiedName*)&relAttr,
@@ -653,6 +719,8 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&selectedAttr,
(WebCore::QualifiedName*)&shapeAttr,
(WebCore::QualifiedName*)&sizeAttr,
+ (WebCore::QualifiedName*)&sortableAttr,
+ (WebCore::QualifiedName*)&sortdirectionAttr,
(WebCore::QualifiedName*)&spanAttr,
(WebCore::QualifiedName*)&spellcheckAttr,
(WebCore::QualifiedName*)&srcAttr,
@@ -680,7 +748,7 @@ WebCore::QualifiedName** getHTMLAttrs(size_t* size)
(WebCore::QualifiedName*)&widthAttr,
(WebCore::QualifiedName*)&wrapAttr,
};
- *size = 202;
+ *size = 232;
return HTMLAttr;
}
@@ -728,12 +796,16 @@ void init()
const char *codeTagString = "code";
const char *colTagString = "col";
const char *colgroupTagString = "colgroup";
+ const char *datagridTagString = "datagrid";
+ const char *dcellTagString = "dcell";
+ const char *dcolTagString = "dcol";
const char *ddTagString = "dd";
const char *delTagString = "del";
const char *dfnTagString = "dfn";
const char *dirTagString = "dir";
const char *divTagString = "div";
const char *dlTagString = "dl";
+ const char *drowTagString = "drow";
const char *dtTagString = "dt";
const char *emTagString = "em";
const char *embedTagString = "embed";
@@ -835,12 +907,16 @@ void init()
new ((void*)&codeTag) QualifiedName(nullAtom, codeTagString, xhtmlNS);
new ((void*)&colTag) QualifiedName(nullAtom, colTagString, xhtmlNS);
new ((void*)&colgroupTag) QualifiedName(nullAtom, colgroupTagString, xhtmlNS);
+ new ((void*)&datagridTag) QualifiedName(nullAtom, datagridTagString, xhtmlNS);
+ new ((void*)&dcellTag) QualifiedName(nullAtom, dcellTagString, xhtmlNS);
+ new ((void*)&dcolTag) QualifiedName(nullAtom, dcolTagString, xhtmlNS);
new ((void*)&ddTag) QualifiedName(nullAtom, ddTagString, xhtmlNS);
new ((void*)&delTag) QualifiedName(nullAtom, delTagString, xhtmlNS);
new ((void*)&dfnTag) QualifiedName(nullAtom, dfnTagString, xhtmlNS);
new ((void*)&dirTag) QualifiedName(nullAtom, dirTagString, xhtmlNS);
new ((void*)&divTag) QualifiedName(nullAtom, divTagString, xhtmlNS);
new ((void*)&dlTag) QualifiedName(nullAtom, dlTagString, xhtmlNS);
+ new ((void*)&drowTag) QualifiedName(nullAtom, drowTagString, xhtmlNS);
new ((void*)&dtTag) QualifiedName(nullAtom, dtTagString, xhtmlNS);
new ((void*)&emTag) QualifiedName(nullAtom, emTagString, xhtmlNS);
new ((void*)&embedTag) QualifiedName(nullAtom, embedTagString, xhtmlNS);
@@ -932,10 +1008,13 @@ void init()
const char *aria_activedescendantAttrString = "aria-activedescendant";
const char *aria_checkedAttrString = "aria-checked";
const char *aria_describedbyAttrString = "aria-describedby";
+ const char *aria_disabledAttrString = "aria-disabled";
+ const char *aria_hiddenAttrString = "aria-hidden";
const char *aria_labeledbyAttrString = "aria-labeledby";
const char *aria_labelledbyAttrString = "aria-labelledby";
const char *aria_levelAttrString = "aria-level";
const char *aria_pressedAttrString = "aria-pressed";
+ const char *aria_readonlyAttrString = "aria-readonly";
const char *aria_valuemaxAttrString = "aria-valuemax";
const char *aria_valueminAttrString = "aria-valuemin";
const char *aria_valuenowAttrString = "aria-valuenow";
@@ -983,7 +1062,9 @@ void init()
const char *disabledAttrString = "disabled";
const char *enctypeAttrString = "enctype";
const char *endAttrString = "end";
+ const char *expandedAttrString = "expanded";
const char *faceAttrString = "face";
+ const char *focusedAttrString = "focused";
const char *forAttrString = "for";
const char *frameAttrString = "frame";
const char *frameborderAttrString = "frameborder";
@@ -996,6 +1077,7 @@ void init()
const char *http_equivAttrString = "http-equiv";
const char *idAttrString = "id";
const char *incrementalAttrString = "incremental";
+ const char *indeterminateAttrString = "indeterminate";
const char *ismapAttrString = "ismap";
const char *keytypeAttrString = "keytype";
const char *labelAttrString = "label";
@@ -1030,6 +1112,8 @@ void init()
const char *onbeforepasteAttrString = "onbeforepaste";
const char *onbeforeunloadAttrString = "onbeforeunload";
const char *onblurAttrString = "onblur";
+ const char *oncanplayAttrString = "oncanplay";
+ const char *oncanplaythroughAttrString = "oncanplaythrough";
const char *onchangeAttrString = "onchange";
const char *onclickAttrString = "onclick";
const char *oncontextmenuAttrString = "oncontextmenu";
@@ -1043,6 +1127,9 @@ void init()
const char *ondragoverAttrString = "ondragover";
const char *ondragstartAttrString = "ondragstart";
const char *ondropAttrString = "ondrop";
+ const char *ondurationchangeAttrString = "ondurationchange";
+ const char *onemptiedAttrString = "onemptied";
+ const char *onendedAttrString = "onended";
const char *onerrorAttrString = "onerror";
const char *onfocusAttrString = "onfocus";
const char *oninputAttrString = "oninput";
@@ -1050,6 +1137,9 @@ void init()
const char *onkeypressAttrString = "onkeypress";
const char *onkeyupAttrString = "onkeyup";
const char *onloadAttrString = "onload";
+ const char *onloadeddataAttrString = "onloadeddata";
+ const char *onloadedmetadataAttrString = "onloadedmetadata";
+ const char *onloadstartAttrString = "onloadstart";
const char *onmousedownAttrString = "onmousedown";
const char *onmousemoveAttrString = "onmousemove";
const char *onmouseoutAttrString = "onmouseout";
@@ -1059,15 +1149,27 @@ void init()
const char *onofflineAttrString = "onoffline";
const char *ononlineAttrString = "ononline";
const char *onpasteAttrString = "onpaste";
+ const char *onpauseAttrString = "onpause";
+ const char *onplayAttrString = "onplay";
+ const char *onplayingAttrString = "onplaying";
+ const char *onprogressAttrString = "onprogress";
+ const char *onratechangeAttrString = "onratechange";
const char *onresetAttrString = "onreset";
const char *onresizeAttrString = "onresize";
const char *onscrollAttrString = "onscroll";
const char *onsearchAttrString = "onsearch";
+ const char *onseekedAttrString = "onseeked";
+ const char *onseekingAttrString = "onseeking";
const char *onselectAttrString = "onselect";
const char *onselectstartAttrString = "onselectstart";
+ const char *onstalledAttrString = "onstalled";
const char *onstorageAttrString = "onstorage";
const char *onsubmitAttrString = "onsubmit";
+ const char *onsuspendAttrString = "onsuspend";
+ const char *ontimeupdateAttrString = "ontimeupdate";
const char *onunloadAttrString = "onunload";
+ const char *onvolumechangeAttrString = "onvolumechange";
+ const char *onwaitingAttrString = "onwaiting";
const char *onwebkitanimationendAttrString = "onwebkitanimationend";
const char *onwebkitanimationiterationAttrString = "onwebkitanimationiteration";
const char *onwebkitanimationstartAttrString = "onwebkitanimationstart";
@@ -1077,7 +1179,9 @@ void init()
const char *pluginurlAttrString = "pluginurl";
const char *posterAttrString = "poster";
const char *precisionAttrString = "precision";
+ const char *primaryAttrString = "primary";
const char *profileAttrString = "profile";
+ const char *progressAttrString = "progress";
const char *promptAttrString = "prompt";
const char *readonlyAttrString = "readonly";
const char *relAttrString = "rel";
@@ -1095,6 +1199,8 @@ void init()
const char *selectedAttrString = "selected";
const char *shapeAttrString = "shape";
const char *sizeAttrString = "size";
+ const char *sortableAttrString = "sortable";
+ const char *sortdirectionAttrString = "sortdirection";
const char *spanAttrString = "span";
const char *spellcheckAttrString = "spellcheck";
const char *srcAttrString = "src";
@@ -1133,10 +1239,13 @@ void init()
new ((void*)&aria_activedescendantAttr) QualifiedName(nullAtom, aria_activedescendantAttrString, nullAtom);
new ((void*)&aria_checkedAttr) QualifiedName(nullAtom, aria_checkedAttrString, nullAtom);
new ((void*)&aria_describedbyAttr) QualifiedName(nullAtom, aria_describedbyAttrString, nullAtom);
+ new ((void*)&aria_disabledAttr) QualifiedName(nullAtom, aria_disabledAttrString, nullAtom);
+ new ((void*)&aria_hiddenAttr) QualifiedName(nullAtom, aria_hiddenAttrString, nullAtom);
new ((void*)&aria_labeledbyAttr) QualifiedName(nullAtom, aria_labeledbyAttrString, nullAtom);
new ((void*)&aria_labelledbyAttr) QualifiedName(nullAtom, aria_labelledbyAttrString, nullAtom);
new ((void*)&aria_levelAttr) QualifiedName(nullAtom, aria_levelAttrString, nullAtom);
new ((void*)&aria_pressedAttr) QualifiedName(nullAtom, aria_pressedAttrString, nullAtom);
+ new ((void*)&aria_readonlyAttr) QualifiedName(nullAtom, aria_readonlyAttrString, nullAtom);
new ((void*)&aria_valuemaxAttr) QualifiedName(nullAtom, aria_valuemaxAttrString, nullAtom);
new ((void*)&aria_valueminAttr) QualifiedName(nullAtom, aria_valueminAttrString, nullAtom);
new ((void*)&aria_valuenowAttr) QualifiedName(nullAtom, aria_valuenowAttrString, nullAtom);
@@ -1185,7 +1294,9 @@ void init()
new ((void*)&disabledAttr) QualifiedName(nullAtom, disabledAttrString, nullAtom);
new ((void*)&enctypeAttr) QualifiedName(nullAtom, enctypeAttrString, nullAtom);
new ((void*)&endAttr) QualifiedName(nullAtom, endAttrString, nullAtom);
+ new ((void*)&expandedAttr) QualifiedName(nullAtom, expandedAttrString, nullAtom);
new ((void*)&faceAttr) QualifiedName(nullAtom, faceAttrString, nullAtom);
+ new ((void*)&focusedAttr) QualifiedName(nullAtom, focusedAttrString, nullAtom);
new ((void*)&forAttr) QualifiedName(nullAtom, forAttrString, nullAtom);
new ((void*)&frameAttr) QualifiedName(nullAtom, frameAttrString, nullAtom);
new ((void*)&frameborderAttr) QualifiedName(nullAtom, frameborderAttrString, nullAtom);
@@ -1198,6 +1309,7 @@ void init()
new ((void*)&http_equivAttr) QualifiedName(nullAtom, http_equivAttrString, nullAtom);
new ((void*)&idAttr) QualifiedName(nullAtom, idAttrString, nullAtom);
new ((void*)&incrementalAttr) QualifiedName(nullAtom, incrementalAttrString, nullAtom);
+ new ((void*)&indeterminateAttr) QualifiedName(nullAtom, indeterminateAttrString, nullAtom);
new ((void*)&ismapAttr) QualifiedName(nullAtom, ismapAttrString, nullAtom);
new ((void*)&keytypeAttr) QualifiedName(nullAtom, keytypeAttrString, nullAtom);
new ((void*)&labelAttr) QualifiedName(nullAtom, labelAttrString, nullAtom);
@@ -1232,6 +1344,8 @@ void init()
new ((void*)&onbeforepasteAttr) QualifiedName(nullAtom, onbeforepasteAttrString, nullAtom);
new ((void*)&onbeforeunloadAttr) QualifiedName(nullAtom, onbeforeunloadAttrString, nullAtom);
new ((void*)&onblurAttr) QualifiedName(nullAtom, onblurAttrString, nullAtom);
+ new ((void*)&oncanplayAttr) QualifiedName(nullAtom, oncanplayAttrString, nullAtom);
+ new ((void*)&oncanplaythroughAttr) QualifiedName(nullAtom, oncanplaythroughAttrString, nullAtom);
new ((void*)&onchangeAttr) QualifiedName(nullAtom, onchangeAttrString, nullAtom);
new ((void*)&onclickAttr) QualifiedName(nullAtom, onclickAttrString, nullAtom);
new ((void*)&oncontextmenuAttr) QualifiedName(nullAtom, oncontextmenuAttrString, nullAtom);
@@ -1245,6 +1359,9 @@ void init()
new ((void*)&ondragoverAttr) QualifiedName(nullAtom, ondragoverAttrString, nullAtom);
new ((void*)&ondragstartAttr) QualifiedName(nullAtom, ondragstartAttrString, nullAtom);
new ((void*)&ondropAttr) QualifiedName(nullAtom, ondropAttrString, nullAtom);
+ new ((void*)&ondurationchangeAttr) QualifiedName(nullAtom, ondurationchangeAttrString, nullAtom);
+ new ((void*)&onemptiedAttr) QualifiedName(nullAtom, onemptiedAttrString, nullAtom);
+ new ((void*)&onendedAttr) QualifiedName(nullAtom, onendedAttrString, nullAtom);
new ((void*)&onerrorAttr) QualifiedName(nullAtom, onerrorAttrString, nullAtom);
new ((void*)&onfocusAttr) QualifiedName(nullAtom, onfocusAttrString, nullAtom);
new ((void*)&oninputAttr) QualifiedName(nullAtom, oninputAttrString, nullAtom);
@@ -1252,6 +1369,9 @@ void init()
new ((void*)&onkeypressAttr) QualifiedName(nullAtom, onkeypressAttrString, nullAtom);
new ((void*)&onkeyupAttr) QualifiedName(nullAtom, onkeyupAttrString, nullAtom);
new ((void*)&onloadAttr) QualifiedName(nullAtom, onloadAttrString, nullAtom);
+ new ((void*)&onloadeddataAttr) QualifiedName(nullAtom, onloadeddataAttrString, nullAtom);
+ new ((void*)&onloadedmetadataAttr) QualifiedName(nullAtom, onloadedmetadataAttrString, nullAtom);
+ new ((void*)&onloadstartAttr) QualifiedName(nullAtom, onloadstartAttrString, nullAtom);
new ((void*)&onmousedownAttr) QualifiedName(nullAtom, onmousedownAttrString, nullAtom);
new ((void*)&onmousemoveAttr) QualifiedName(nullAtom, onmousemoveAttrString, nullAtom);
new ((void*)&onmouseoutAttr) QualifiedName(nullAtom, onmouseoutAttrString, nullAtom);
@@ -1261,15 +1381,27 @@ void init()
new ((void*)&onofflineAttr) QualifiedName(nullAtom, onofflineAttrString, nullAtom);
new ((void*)&ononlineAttr) QualifiedName(nullAtom, ononlineAttrString, nullAtom);
new ((void*)&onpasteAttr) QualifiedName(nullAtom, onpasteAttrString, nullAtom);
+ new ((void*)&onpauseAttr) QualifiedName(nullAtom, onpauseAttrString, nullAtom);
+ new ((void*)&onplayAttr) QualifiedName(nullAtom, onplayAttrString, nullAtom);
+ new ((void*)&onplayingAttr) QualifiedName(nullAtom, onplayingAttrString, nullAtom);
+ new ((void*)&onprogressAttr) QualifiedName(nullAtom, onprogressAttrString, nullAtom);
+ new ((void*)&onratechangeAttr) QualifiedName(nullAtom, onratechangeAttrString, nullAtom);
new ((void*)&onresetAttr) QualifiedName(nullAtom, onresetAttrString, nullAtom);
new ((void*)&onresizeAttr) QualifiedName(nullAtom, onresizeAttrString, nullAtom);
new ((void*)&onscrollAttr) QualifiedName(nullAtom, onscrollAttrString, nullAtom);
new ((void*)&onsearchAttr) QualifiedName(nullAtom, onsearchAttrString, nullAtom);
+ new ((void*)&onseekedAttr) QualifiedName(nullAtom, onseekedAttrString, nullAtom);
+ new ((void*)&onseekingAttr) QualifiedName(nullAtom, onseekingAttrString, nullAtom);
new ((void*)&onselectAttr) QualifiedName(nullAtom, onselectAttrString, nullAtom);
new ((void*)&onselectstartAttr) QualifiedName(nullAtom, onselectstartAttrString, nullAtom);
+ new ((void*)&onstalledAttr) QualifiedName(nullAtom, onstalledAttrString, nullAtom);
new ((void*)&onstorageAttr) QualifiedName(nullAtom, onstorageAttrString, nullAtom);
new ((void*)&onsubmitAttr) QualifiedName(nullAtom, onsubmitAttrString, nullAtom);
+ new ((void*)&onsuspendAttr) QualifiedName(nullAtom, onsuspendAttrString, nullAtom);
+ new ((void*)&ontimeupdateAttr) QualifiedName(nullAtom, ontimeupdateAttrString, nullAtom);
new ((void*)&onunloadAttr) QualifiedName(nullAtom, onunloadAttrString, nullAtom);
+ new ((void*)&onvolumechangeAttr) QualifiedName(nullAtom, onvolumechangeAttrString, nullAtom);
+ new ((void*)&onwaitingAttr) QualifiedName(nullAtom, onwaitingAttrString, nullAtom);
new ((void*)&onwebkitanimationendAttr) QualifiedName(nullAtom, onwebkitanimationendAttrString, nullAtom);
new ((void*)&onwebkitanimationiterationAttr) QualifiedName(nullAtom, onwebkitanimationiterationAttrString, nullAtom);
new ((void*)&onwebkitanimationstartAttr) QualifiedName(nullAtom, onwebkitanimationstartAttrString, nullAtom);
@@ -1279,7 +1411,9 @@ void init()
new ((void*)&pluginurlAttr) QualifiedName(nullAtom, pluginurlAttrString, nullAtom);
new ((void*)&posterAttr) QualifiedName(nullAtom, posterAttrString, nullAtom);
new ((void*)&precisionAttr) QualifiedName(nullAtom, precisionAttrString, nullAtom);
+ new ((void*)&primaryAttr) QualifiedName(nullAtom, primaryAttrString, nullAtom);
new ((void*)&profileAttr) QualifiedName(nullAtom, profileAttrString, nullAtom);
+ new ((void*)&progressAttr) QualifiedName(nullAtom, progressAttrString, nullAtom);
new ((void*)&promptAttr) QualifiedName(nullAtom, promptAttrString, nullAtom);
new ((void*)&readonlyAttr) QualifiedName(nullAtom, readonlyAttrString, nullAtom);
new ((void*)&relAttr) QualifiedName(nullAtom, relAttrString, nullAtom);
@@ -1297,6 +1431,8 @@ void init()
new ((void*)&selectedAttr) QualifiedName(nullAtom, selectedAttrString, nullAtom);
new ((void*)&shapeAttr) QualifiedName(nullAtom, shapeAttrString, nullAtom);
new ((void*)&sizeAttr) QualifiedName(nullAtom, sizeAttrString, nullAtom);
+ new ((void*)&sortableAttr) QualifiedName(nullAtom, sortableAttrString, nullAtom);
+ new ((void*)&sortdirectionAttr) QualifiedName(nullAtom, sortdirectionAttrString, nullAtom);
new ((void*)&spanAttr) QualifiedName(nullAtom, spanAttrString, nullAtom);
new ((void*)&spellcheckAttr) QualifiedName(nullAtom, spellcheckAttrString, nullAtom);
new ((void*)&srcAttr) QualifiedName(nullAtom, srcAttrString, nullAtom);
diff --git a/src/3rdparty/webkit/WebCore/generated/HTMLNames.h b/src/3rdparty/webkit/WebCore/generated/HTMLNames.h
index 939c8ec..fba6088 100644
--- a/src/3rdparty/webkit/WebCore/generated/HTMLNames.h
+++ b/src/3rdparty/webkit/WebCore/generated/HTMLNames.h
@@ -64,12 +64,16 @@ extern const WebCore::QualifiedName citeTag;
extern const WebCore::QualifiedName codeTag;
extern const WebCore::QualifiedName colTag;
extern const WebCore::QualifiedName colgroupTag;
+extern const WebCore::QualifiedName datagridTag;
+extern const WebCore::QualifiedName dcellTag;
+extern const WebCore::QualifiedName dcolTag;
extern const WebCore::QualifiedName ddTag;
extern const WebCore::QualifiedName delTag;
extern const WebCore::QualifiedName dfnTag;
extern const WebCore::QualifiedName dirTag;
extern const WebCore::QualifiedName divTag;
extern const WebCore::QualifiedName dlTag;
+extern const WebCore::QualifiedName drowTag;
extern const WebCore::QualifiedName dtTag;
extern const WebCore::QualifiedName emTag;
extern const WebCore::QualifiedName embedTag;
@@ -161,10 +165,13 @@ extern const WebCore::QualifiedName archiveAttr;
extern const WebCore::QualifiedName aria_activedescendantAttr;
extern const WebCore::QualifiedName aria_checkedAttr;
extern const WebCore::QualifiedName aria_describedbyAttr;
+extern const WebCore::QualifiedName aria_disabledAttr;
+extern const WebCore::QualifiedName aria_hiddenAttr;
extern const WebCore::QualifiedName aria_labeledbyAttr;
extern const WebCore::QualifiedName aria_labelledbyAttr;
extern const WebCore::QualifiedName aria_levelAttr;
extern const WebCore::QualifiedName aria_pressedAttr;
+extern const WebCore::QualifiedName aria_readonlyAttr;
extern const WebCore::QualifiedName aria_valuemaxAttr;
extern const WebCore::QualifiedName aria_valueminAttr;
extern const WebCore::QualifiedName aria_valuenowAttr;
@@ -214,7 +221,9 @@ extern const WebCore::QualifiedName directionAttr;
extern const WebCore::QualifiedName disabledAttr;
extern const WebCore::QualifiedName enctypeAttr;
extern const WebCore::QualifiedName endAttr;
+extern const WebCore::QualifiedName expandedAttr;
extern const WebCore::QualifiedName faceAttr;
+extern const WebCore::QualifiedName focusedAttr;
extern const WebCore::QualifiedName forAttr;
extern const WebCore::QualifiedName frameAttr;
extern const WebCore::QualifiedName frameborderAttr;
@@ -227,6 +236,7 @@ extern const WebCore::QualifiedName hspaceAttr;
extern const WebCore::QualifiedName http_equivAttr;
extern const WebCore::QualifiedName idAttr;
extern const WebCore::QualifiedName incrementalAttr;
+extern const WebCore::QualifiedName indeterminateAttr;
extern const WebCore::QualifiedName ismapAttr;
extern const WebCore::QualifiedName keytypeAttr;
extern const WebCore::QualifiedName labelAttr;
@@ -261,6 +271,8 @@ extern const WebCore::QualifiedName onbeforecutAttr;
extern const WebCore::QualifiedName onbeforepasteAttr;
extern const WebCore::QualifiedName onbeforeunloadAttr;
extern const WebCore::QualifiedName onblurAttr;
+extern const WebCore::QualifiedName oncanplayAttr;
+extern const WebCore::QualifiedName oncanplaythroughAttr;
extern const WebCore::QualifiedName onchangeAttr;
extern const WebCore::QualifiedName onclickAttr;
extern const WebCore::QualifiedName oncontextmenuAttr;
@@ -274,6 +286,9 @@ extern const WebCore::QualifiedName ondragleaveAttr;
extern const WebCore::QualifiedName ondragoverAttr;
extern const WebCore::QualifiedName ondragstartAttr;
extern const WebCore::QualifiedName ondropAttr;
+extern const WebCore::QualifiedName ondurationchangeAttr;
+extern const WebCore::QualifiedName onemptiedAttr;
+extern const WebCore::QualifiedName onendedAttr;
extern const WebCore::QualifiedName onerrorAttr;
extern const WebCore::QualifiedName onfocusAttr;
extern const WebCore::QualifiedName oninputAttr;
@@ -281,6 +296,9 @@ extern const WebCore::QualifiedName onkeydownAttr;
extern const WebCore::QualifiedName onkeypressAttr;
extern const WebCore::QualifiedName onkeyupAttr;
extern const WebCore::QualifiedName onloadAttr;
+extern const WebCore::QualifiedName onloadeddataAttr;
+extern const WebCore::QualifiedName onloadedmetadataAttr;
+extern const WebCore::QualifiedName onloadstartAttr;
extern const WebCore::QualifiedName onmousedownAttr;
extern const WebCore::QualifiedName onmousemoveAttr;
extern const WebCore::QualifiedName onmouseoutAttr;
@@ -290,15 +308,27 @@ extern const WebCore::QualifiedName onmousewheelAttr;
extern const WebCore::QualifiedName onofflineAttr;
extern const WebCore::QualifiedName ononlineAttr;
extern const WebCore::QualifiedName onpasteAttr;
+extern const WebCore::QualifiedName onpauseAttr;
+extern const WebCore::QualifiedName onplayAttr;
+extern const WebCore::QualifiedName onplayingAttr;
+extern const WebCore::QualifiedName onprogressAttr;
+extern const WebCore::QualifiedName onratechangeAttr;
extern const WebCore::QualifiedName onresetAttr;
extern const WebCore::QualifiedName onresizeAttr;
extern const WebCore::QualifiedName onscrollAttr;
extern const WebCore::QualifiedName onsearchAttr;
+extern const WebCore::QualifiedName onseekedAttr;
+extern const WebCore::QualifiedName onseekingAttr;
extern const WebCore::QualifiedName onselectAttr;
extern const WebCore::QualifiedName onselectstartAttr;
+extern const WebCore::QualifiedName onstalledAttr;
extern const WebCore::QualifiedName onstorageAttr;
extern const WebCore::QualifiedName onsubmitAttr;
+extern const WebCore::QualifiedName onsuspendAttr;
+extern const WebCore::QualifiedName ontimeupdateAttr;
extern const WebCore::QualifiedName onunloadAttr;
+extern const WebCore::QualifiedName onvolumechangeAttr;
+extern const WebCore::QualifiedName onwaitingAttr;
extern const WebCore::QualifiedName onwebkitanimationendAttr;
extern const WebCore::QualifiedName onwebkitanimationiterationAttr;
extern const WebCore::QualifiedName onwebkitanimationstartAttr;
@@ -308,7 +338,9 @@ extern const WebCore::QualifiedName playcountAttr;
extern const WebCore::QualifiedName pluginurlAttr;
extern const WebCore::QualifiedName posterAttr;
extern const WebCore::QualifiedName precisionAttr;
+extern const WebCore::QualifiedName primaryAttr;
extern const WebCore::QualifiedName profileAttr;
+extern const WebCore::QualifiedName progressAttr;
extern const WebCore::QualifiedName promptAttr;
extern const WebCore::QualifiedName readonlyAttr;
extern const WebCore::QualifiedName relAttr;
@@ -326,6 +358,8 @@ extern const WebCore::QualifiedName scrollingAttr;
extern const WebCore::QualifiedName selectedAttr;
extern const WebCore::QualifiedName shapeAttr;
extern const WebCore::QualifiedName sizeAttr;
+extern const WebCore::QualifiedName sortableAttr;
+extern const WebCore::QualifiedName sortdirectionAttr;
extern const WebCore::QualifiedName spanAttr;
extern const WebCore::QualifiedName spellcheckAttr;
extern const WebCore::QualifiedName srcAttr;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSAttr.cpp b/src/3rdparty/webkit/WebCore/generated/JSAttr.cpp
index 00b9a5f..bf9bea5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSAttr.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSAttr.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSAttr.h"
-#include <wtf/GetPtr.h>
-
#include "Attr.h"
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
@@ -31,8 +28,7 @@
#include "JSCSSStyleDeclaration.h"
#include "JSElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSAttr.h b/src/3rdparty/webkit/WebCore/generated/JSAttr.h
index 37f0193..4d13aa8 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSAttr.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSAttr.h
@@ -21,8 +21,9 @@
#ifndef JSAttr_h
#define JSAttr_h
-#include "JSNode.h"
#include "Attr.h"
+#include "JSNode.h"
+
namespace WebCore {
class Attr;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSBarInfo.cpp b/src/3rdparty/webkit/WebCore/generated/JSBarInfo.cpp
index 89860d2..25aede5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSBarInfo.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSBarInfo.cpp
@@ -19,13 +19,10 @@
*/
#include "config.h"
-
#include "JSBarInfo.h"
-#include <wtf/GetPtr.h>
-
#include "BarInfo.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCDATASection.cpp b/src/3rdparty/webkit/WebCore/generated/JSCDATASection.cpp
index 1699401..f89540d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCDATASection.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCDATASection.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSCDATASection.h"
-#include <wtf/GetPtr.h>
-
#include "CDATASection.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSCharsetRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSCharsetRule.cpp
index 9015d1e..15cabbf 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSCharsetRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSCharsetRule.cpp
@@ -19,15 +19,11 @@
*/
#include "config.h"
-
#include "JSCSSCharsetRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSCharsetRule.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSFontFaceRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSFontFaceRule.cpp
index 1490ac6..ab3b3a5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSFontFaceRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSFontFaceRule.cpp
@@ -19,17 +19,13 @@
*/
#include "config.h"
-
#include "JSCSSFontFaceRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSFontFaceRule.h"
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "JSCSSStyleDeclaration.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSImportRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSImportRule.cpp
index 412dac1..4dc5151 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSImportRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSImportRule.cpp
@@ -19,19 +19,15 @@
*/
#include "config.h"
-
#include "JSCSSImportRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSImportRule.h"
#include "CSSStyleSheet.h"
#include "JSCSSStyleSheet.h"
#include "JSMediaList.h"
#include "KURL.h"
#include "MediaList.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSMediaRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSMediaRule.cpp
index c8f3e09..35589af 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSMediaRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSMediaRule.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSCSSMediaRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMediaRule.h"
#include "CSSRuleList.h"
#include "JSCSSRuleList.h"
#include "JSMediaList.h"
#include "MediaList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSPageRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSPageRule.cpp
index f5428c3..6869a49 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSPageRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSPageRule.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSCSSPageRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSPageRule.h"
#include "CSSStyleDeclaration.h"
#include "JSCSSStyleDeclaration.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSPrimitiveValue.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSPrimitiveValue.cpp
index bf64f16..61a39ec 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSPrimitiveValue.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSPrimitiveValue.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSCSSPrimitiveValue.h"
-#include <wtf/GetPtr.h>
-
#include "CSSPrimitiveValue.h"
#include "Counter.h"
#include "JSCounter.h"
@@ -31,10 +28,10 @@
#include "JSRect.h"
#include "KURL.h"
#include "Rect.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSRule.cpp
index 47bb5cc..31a4dc3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSRule.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSCSSRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSRule.h"
#include "CSSStyleSheet.h"
#include "JSCSSRule.h"
#include "JSCSSStyleSheet.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSRuleList.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSRuleList.cpp
index 5b8c7aa..19e9d14 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSRuleList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSRuleList.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSCSSRuleList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "CSSRule.h"
#include "CSSRuleList.h"
#include "JSCSSRule.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.cpp
index 0a4a1a0..cf7ceed 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.cpp
@@ -19,12 +19,8 @@
*/
#include "config.h"
-
#include "JSCSSStyleDeclaration.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "CSSRule.h"
#include "CSSStyleDeclaration.h"
@@ -33,9 +29,10 @@
#include "JSCSSStyleDeclarationCustom.h"
#include "JSCSSValue.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -207,7 +204,7 @@ JSValue jsCSSStyleDeclarationConstructor(ExecState* exec, const Identifier&, con
}
void JSCSSStyleDeclaration::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
lookupPut<JSCSSStyleDeclaration, Base>(exec, propertyName, value, &JSCSSStyleDeclarationTable, this, slot);
}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.h b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.h
index 704048e..df64dde 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleDeclaration.h
@@ -38,7 +38,7 @@ public:
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
virtual bool getOwnPropertySlot(JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleRule.cpp
index 51179c0..1d92b22 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleRule.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSCSSStyleRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSStyleRule.h"
#include "JSCSSStyleDeclaration.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleSheet.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleSheet.cpp
index 6a3f2f2..f697203 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSStyleSheet.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSStyleSheet.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSCSSStyleSheet.h"
-#include <wtf/GetPtr.h>
-
#include "CSSRule.h"
#include "CSSRuleList.h"
#include "CSSStyleSheet.h"
#include "JSCSSRule.h"
#include "JSCSSRuleList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSValue.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSValue.cpp
index da216fd..87aff14 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSValue.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSValue.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSCSSValue.h"
-#include <wtf/GetPtr.h>
-
#include "CSSValue.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSValueList.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSValueList.cpp
index 5a00968..98721ec 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSValueList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSValueList.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSCSSValueList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "CSSValue.h"
#include "CSSValueList.h"
#include "JSCSSValue.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesDeclaration.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesDeclaration.cpp
index 24ff9bc..3c8c75a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesDeclaration.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesDeclaration.cpp
@@ -19,20 +19,17 @@
*/
#include "config.h"
-
#include "JSCSSVariablesDeclaration.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "CSSRule.h"
#include "CSSVariablesDeclaration.h"
#include "JSCSSRule.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesRule.cpp b/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesRule.cpp
index 7a4753f..ed3050d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesRule.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCSSVariablesRule.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSCSSVariablesRule.h"
-#include <wtf/GetPtr.h>
-
#include "CSSVariablesDeclaration.h"
#include "CSSVariablesRule.h"
#include "JSCSSVariablesDeclaration.h"
#include "JSMediaList.h"
#include "MediaList.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCanvasGradient.cpp b/src/3rdparty/webkit/WebCore/generated/JSCanvasGradient.cpp
index daf71ea..7801622 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCanvasGradient.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCanvasGradient.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSCanvasGradient.h"
-#include <wtf/GetPtr.h>
-
#include "CanvasGradient.h"
#include "PlatformString.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCanvasPattern.cpp b/src/3rdparty/webkit/WebCore/generated/JSCanvasPattern.cpp
index 9b3ec21..14dc535 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCanvasPattern.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCanvasPattern.cpp
@@ -19,13 +19,10 @@
*/
#include "config.h"
-
#include "JSCanvasPattern.h"
-#include <wtf/GetPtr.h>
-
#include "CanvasPattern.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCanvasRenderingContext2D.cpp b/src/3rdparty/webkit/WebCore/generated/JSCanvasRenderingContext2D.cpp
index 9fb681d..2f318c1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCanvasRenderingContext2D.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCanvasRenderingContext2D.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSCanvasRenderingContext2D.h"
-#include <wtf/GetPtr.h>
-
#include "CanvasGradient.h"
#include "CanvasPattern.h"
#include "CanvasRenderingContext2D.h"
@@ -37,10 +34,10 @@
#include "KURL.h"
#include "PlatformString.h"
#include "TextMetrics.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCharacterData.cpp b/src/3rdparty/webkit/WebCore/generated/JSCharacterData.cpp
index 4e5d2db..a860721 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCharacterData.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCharacterData.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSCharacterData.h"
-#include <wtf/GetPtr.h>
-
#include "CharacterData.h"
#include "ExceptionCode.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSClientRect.cpp b/src/3rdparty/webkit/WebCore/generated/JSClientRect.cpp
index 8aa1b8e..4db0efb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSClientRect.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSClientRect.cpp
@@ -19,14 +19,11 @@
*/
#include "config.h"
-
#include "JSClientRect.h"
-#include <wtf/GetPtr.h>
-
#include "ClientRect.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSClientRectList.cpp b/src/3rdparty/webkit/WebCore/generated/JSClientRectList.cpp
index e1316b7..97eff69 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSClientRectList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSClientRectList.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSClientRectList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "ClientRect.h"
#include "ClientRectList.h"
#include "ExceptionCode.h"
#include "JSClientRect.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSClipboard.cpp b/src/3rdparty/webkit/WebCore/generated/JSClipboard.cpp
index 115b5de..19c40b7 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSClipboard.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSClipboard.cpp
@@ -19,16 +19,14 @@
*/
#include "config.h"
-
#include "JSClipboard.h"
-#include <wtf/GetPtr.h>
-
#include "Clipboard.h"
+#include "FileList.h"
+#include "JSFileList.h"
#include "KURL.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -38,20 +36,21 @@ ASSERT_CLASS_FITS_IN_CELL(JSClipboard);
/* Hash table */
-static const HashTableValue JSClipboardTableValues[5] =
+static const HashTableValue JSClipboardTableValues[6] =
{
{ "dropEffect", DontDelete, (intptr_t)jsClipboardDropEffect, (intptr_t)setJSClipboardDropEffect },
{ "effectAllowed", DontDelete, (intptr_t)jsClipboardEffectAllowed, (intptr_t)setJSClipboardEffectAllowed },
{ "types", DontDelete|ReadOnly, (intptr_t)jsClipboardTypes, (intptr_t)0 },
+ { "files", DontDelete|ReadOnly, (intptr_t)jsClipboardFiles, (intptr_t)0 },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsClipboardConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
static const HashTable JSClipboardTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 15, JSClipboardTableValues, 0 };
+ { 63, JSClipboardTableValues, 0 };
#else
- { 10, 7, JSClipboardTableValues, 0 };
+ { 17, 15, JSClipboardTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -164,6 +163,13 @@ JSValue jsClipboardTypes(ExecState* exec, const Identifier&, const PropertySlot&
return static_cast<JSClipboard*>(asObject(slot.slotBase()))->types(exec);
}
+JSValue jsClipboardFiles(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Clipboard* imp = static_cast<Clipboard*>(static_cast<JSClipboard*>(asObject(slot.slotBase()))->impl());
+ return toJS(exec, WTF::getPtr(imp->files()));
+}
+
JSValue jsClipboardConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSClipboard*>(asObject(slot.slotBase()))->getConstructor(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSClipboard.h b/src/3rdparty/webkit/WebCore/generated/JSClipboard.h
index a9d51ab..a6fbe3b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSClipboard.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSClipboard.h
@@ -91,6 +91,7 @@ void setJSClipboardDropEffect(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsClipboardEffectAllowed(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSClipboardEffectAllowed(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsClipboardTypes(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsClipboardFiles(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
JSC::JSValue jsClipboardConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSComment.cpp b/src/3rdparty/webkit/WebCore/generated/JSComment.cpp
index bb7a0fa..7905094 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSComment.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSComment.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSComment.h"
-#include <wtf/GetPtr.h>
-
#include "Comment.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSConsole.cpp b/src/3rdparty/webkit/WebCore/generated/JSConsole.cpp
index 7ae8c6e..24e5ef3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSConsole.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSConsole.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSConsole.h"
-#include <wtf/GetPtr.h>
-
#include "Console.h"
#include "ScriptCallStack.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCoordinates.cpp b/src/3rdparty/webkit/WebCore/generated/JSCoordinates.cpp
index 12525b9..0db560b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCoordinates.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCoordinates.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSCoordinates.h"
-#include <wtf/GetPtr.h>
-
#include "Coordinates.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSCounter.cpp b/src/3rdparty/webkit/WebCore/generated/JSCounter.cpp
index da87cd9..03a3eb3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSCounter.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSCounter.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSCounter.h"
-#include <wtf/GetPtr.h>
-
#include "Counter.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.cpp
index 8b0a79e..0d7202b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.cpp
@@ -20,13 +20,10 @@
#include "config.h"
-
#if ENABLE(OFFLINE_WEB_APPLICATIONS)
#include "JSDOMApplicationCache.h"
-#include <wtf/GetPtr.h>
-
#include "DOMApplicationCache.h"
#include "Event.h"
#include "EventListener.h"
@@ -34,9 +31,9 @@
#include "JSDOMGlobalObject.h"
#include "JSEvent.h"
#include "JSEventListener.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.h b/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.h
index 29f0c64..7a6ea14 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMApplicationCache.h
@@ -21,7 +21,6 @@
#ifndef JSDOMApplicationCache_h
#define JSDOMApplicationCache_h
-
#if ENABLE(OFFLINE_WEB_APPLICATIONS)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMCoreException.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMCoreException.cpp
index 9cbb539..3b45220 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMCoreException.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMCoreException.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSDOMCoreException.h"
-#include <wtf/GetPtr.h>
-
#include "DOMCoreException.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMImplementation.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMImplementation.cpp
index f676df6..1e2f950 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMImplementation.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMImplementation.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSDOMImplementation.h"
-#include <wtf/GetPtr.h>
-
#include "CSSStyleSheet.h"
#include "DOMImplementation.h"
#include "Document.h"
@@ -34,9 +31,8 @@
#include "JSDocumentType.h"
#include "JSHTMLDocument.h"
#include "NodeFilter.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMParser.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMParser.cpp
index 7050472..ffb4f70 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMParser.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMParser.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSDOMParser.h"
-#include <wtf/GetPtr.h>
-
#include "DOMParser.h"
#include "Document.h"
#include "JSDocument.h"
#include "NodeFilter.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMSelection.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMSelection.cpp
index 6ea1bad..422c410 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMSelection.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMSelection.cpp
@@ -19,21 +19,18 @@
*/
#include "config.h"
-
#include "JSDOMSelection.h"
-#include <wtf/GetPtr.h>
-
#include "DOMSelection.h"
#include "JSNode.h"
#include "JSRange.h"
#include "KURL.h"
#include "Node.h"
#include "Range.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMStringList.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMStringList.cpp
deleted file mode 100644
index 9be9b78..0000000
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMStringList.cpp
+++ /dev/null
@@ -1,214 +0,0 @@
-/*
- This file is part of the WebKit open source project.
- This file has been generated by generate-bindings.pl. DO NOT MODIFY!
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Library General Public
- License as published by the Free Software Foundation; either
- version 2 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Library General Public License for more details.
-
- You should have received a copy of the GNU Library General Public License
- along with this library; see the file COPYING.LIB. If not, write to
- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- Boston, MA 02110-1301, USA.
-*/
-
-#include "config.h"
-
-#include "JSDOMStringList.h"
-
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
-#include "DOMStringList.h"
-
-#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
-
-using namespace JSC;
-
-namespace WebCore {
-
-ASSERT_CLASS_FITS_IN_CELL(JSDOMStringList);
-
-/* Hash table */
-
-static const HashTableValue JSDOMStringListTableValues[3] =
-{
- { "length", DontDelete|ReadOnly, (intptr_t)jsDOMStringListLength, (intptr_t)0 },
- { "constructor", DontEnum|ReadOnly, (intptr_t)jsDOMStringListConstructor, (intptr_t)0 },
- { 0, 0, 0, 0 }
-};
-
-static const HashTable JSDOMStringListTable =
-#if ENABLE(PERFECT_HASH_SIZE)
- { 15, JSDOMStringListTableValues, 0 };
-#else
- { 5, 3, JSDOMStringListTableValues, 0 };
-#endif
-
-/* Hash table for constructor */
-
-static const HashTableValue JSDOMStringListConstructorTableValues[1] =
-{
- { 0, 0, 0, 0 }
-};
-
-static const HashTable JSDOMStringListConstructorTable =
-#if ENABLE(PERFECT_HASH_SIZE)
- { 0, JSDOMStringListConstructorTableValues, 0 };
-#else
- { 1, 0, JSDOMStringListConstructorTableValues, 0 };
-#endif
-
-class JSDOMStringListConstructor : public DOMObject {
-public:
- JSDOMStringListConstructor(ExecState* exec)
- : DOMObject(JSDOMStringListConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
- {
- putDirect(exec->propertyNames().prototype, JSDOMStringListPrototype::self(exec, exec->lexicalGlobalObject()), None);
- }
- virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
- virtual const ClassInfo* classInfo() const { return &s_info; }
- static const ClassInfo s_info;
-
- static PassRefPtr<Structure> createStructure(JSValue proto)
- {
- return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
- }
-};
-
-const ClassInfo JSDOMStringListConstructor::s_info = { "DOMStringListConstructor", 0, &JSDOMStringListConstructorTable, 0 };
-
-bool JSDOMStringListConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
-{
- return getStaticValueSlot<JSDOMStringListConstructor, DOMObject>(exec, &JSDOMStringListConstructorTable, this, propertyName, slot);
-}
-
-/* Hash table for prototype */
-
-static const HashTableValue JSDOMStringListPrototypeTableValues[3] =
-{
- { "item", DontDelete|Function, (intptr_t)jsDOMStringListPrototypeFunctionItem, (intptr_t)1 },
- { "contains", DontDelete|Function, (intptr_t)jsDOMStringListPrototypeFunctionContains, (intptr_t)1 },
- { 0, 0, 0, 0 }
-};
-
-static const HashTable JSDOMStringListPrototypeTable =
-#if ENABLE(PERFECT_HASH_SIZE)
- { 1, JSDOMStringListPrototypeTableValues, 0 };
-#else
- { 4, 3, JSDOMStringListPrototypeTableValues, 0 };
-#endif
-
-const ClassInfo JSDOMStringListPrototype::s_info = { "DOMStringListPrototype", 0, &JSDOMStringListPrototypeTable, 0 };
-
-JSObject* JSDOMStringListPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
-{
- return getDOMPrototype<JSDOMStringList>(exec, globalObject);
-}
-
-bool JSDOMStringListPrototype::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
-{
- return getStaticFunctionSlot<JSObject>(exec, &JSDOMStringListPrototypeTable, this, propertyName, slot);
-}
-
-const ClassInfo JSDOMStringList::s_info = { "DOMStringList", 0, &JSDOMStringListTable, 0 };
-
-JSDOMStringList::JSDOMStringList(PassRefPtr<Structure> structure, PassRefPtr<DOMStringList> impl)
- : DOMObject(structure)
- , m_impl(impl)
-{
-}
-
-JSDOMStringList::~JSDOMStringList()
-{
- forgetDOMObject(*Heap::heap(this)->globalData(), m_impl.get());
-}
-
-JSObject* JSDOMStringList::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
-{
- return new (exec) JSDOMStringListPrototype(JSDOMStringListPrototype::createStructure(globalObject->objectPrototype()));
-}
-
-bool JSDOMStringList::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
-{
- bool ok;
- unsigned index = propertyName.toUInt32(&ok, false);
- if (ok && index < static_cast<DOMStringList*>(impl())->length()) {
- slot.setValue(getByIndex(exec, index));
- return true;
- }
- return getStaticValueSlot<JSDOMStringList, Base>(exec, &JSDOMStringListTable, this, propertyName, slot);
-}
-
-bool JSDOMStringList::getOwnPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
-{
- if (propertyName < static_cast<DOMStringList*>(impl())->length()) {
- slot.setValue(getByIndex(exec, propertyName));
- return true;
- }
- return getOwnPropertySlot(exec, Identifier::from(exec, propertyName), slot);
-}
-
-JSValue jsDOMStringListLength(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- DOMStringList* imp = static_cast<DOMStringList*>(static_cast<JSDOMStringList*>(asObject(slot.slotBase()))->impl());
- return jsNumber(exec, imp->length());
-}
-
-JSValue jsDOMStringListConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- return static_cast<JSDOMStringList*>(asObject(slot.slotBase()))->getConstructor(exec);
-}
-void JSDOMStringList::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
-{
- for (unsigned i = 0; i < static_cast<DOMStringList*>(impl())->length(); ++i)
- propertyNames.add(Identifier::from(exec, i));
- Base::getPropertyNames(exec, propertyNames);
-}
-
-JSValue JSDOMStringList::getConstructor(ExecState* exec)
-{
- return getDOMConstructor<JSDOMStringListConstructor>(exec);
-}
-
-JSValue JSC_HOST_CALL jsDOMStringListPrototypeFunctionItem(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
-{
- UNUSED_PARAM(args);
- if (!thisValue.isObject(&JSDOMStringList::s_info))
- return throwError(exec, TypeError);
- JSDOMStringList* castedThisObj = static_cast<JSDOMStringList*>(asObject(thisValue));
- return castedThisObj->item(exec, args);
-}
-
-JSValue JSC_HOST_CALL jsDOMStringListPrototypeFunctionContains(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
-{
- UNUSED_PARAM(args);
- if (!thisValue.isObject(&JSDOMStringList::s_info))
- return throwError(exec, TypeError);
- JSDOMStringList* castedThisObj = static_cast<JSDOMStringList*>(asObject(thisValue));
- DOMStringList* imp = static_cast<DOMStringList*>(castedThisObj->impl());
- const UString& str = args.at(0).toString(exec);
-
-
- JSC::JSValue result = jsBoolean(imp->contains(str));
- return result;
-}
-
-JSC::JSValue toJS(JSC::ExecState* exec, DOMStringList* object)
-{
- return getDOMObjectWrapper<JSDOMStringList>(exec, object);
-}
-DOMStringList* toDOMStringList(JSC::JSValue value)
-{
- return value.isObject(&JSDOMStringList::s_info) ? static_cast<JSDOMStringList*>(asObject(value))->impl() : 0;
-}
-
-}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp b/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp
index bf0809b..d9c3ed9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSDOMWindow.h"
-#include <wtf/GetPtr.h>
-
#include "BarInfo.h"
#include "CSSMutableStyleDeclaration.h"
#include "CSSRuleList.h"
@@ -69,7 +66,6 @@
#include "JSDOMImplementation.h"
#include "JSDOMParser.h"
#include "JSDOMSelection.h"
-#include "JSDOMStringList.h"
#include "JSDOMWindow.h"
#include "JSDOMWindowCustom.h"
#include "JSDOMWindowShell.h"
@@ -98,6 +94,8 @@
#include "JSHTMLCanvasElement.h"
#include "JSHTMLCollection.h"
#include "JSHTMLDListElement.h"
+#include "JSHTMLDataGridColElement.h"
+#include "JSHTMLDataGridElement.h"
#include "JSHTMLDirectoryElement.h"
#include "JSHTMLDivElement.h"
#include "JSHTMLDocument.h"
@@ -214,10 +212,10 @@
#include "Screen.h"
#include "Storage.h"
#include "WebKitPoint.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -227,7 +225,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSDOMWindow);
/* Hash table */
-static const HashTableValue JSDOMWindowTableValues[271] =
+static const HashTableValue JSDOMWindowTableValues[272] =
{
{ "screen", DontDelete|ReadOnly, (intptr_t)jsDOMWindowScreen, (intptr_t)0 },
{ "history", DontDelete|ReadOnly, (intptr_t)jsDOMWindowHistory, (intptr_t)0 },
@@ -358,7 +356,6 @@ static const HashTableValue JSDOMWindowTableValues[271] =
{ "Rect", DontDelete, (intptr_t)jsDOMWindowRectConstructor, (intptr_t)setJSDOMWindowRectConstructor },
{ "StyleSheetList", DontDelete, (intptr_t)jsDOMWindowStyleSheetListConstructor, (intptr_t)setJSDOMWindowStyleSheetListConstructor },
{ "DOMException", DontDelete, (intptr_t)jsDOMWindowDOMExceptionConstructor, (intptr_t)setJSDOMWindowDOMExceptionConstructor },
- { "DOMStringList", DontDelete, (intptr_t)jsDOMWindowDOMStringListConstructor, (intptr_t)setJSDOMWindowDOMStringListConstructor },
{ "DOMImplementation", DontDelete, (intptr_t)jsDOMWindowDOMImplementationConstructor, (intptr_t)setJSDOMWindowDOMImplementationConstructor },
{ "DocumentFragment", DontDelete, (intptr_t)jsDOMWindowDocumentFragmentConstructor, (intptr_t)setJSDOMWindowDocumentFragmentConstructor },
{ "Document", DontDelete, (intptr_t)jsDOMWindowDocumentConstructor, (intptr_t)setJSDOMWindowDocumentConstructor },
@@ -388,6 +385,8 @@ static const HashTableValue JSDOMWindowTableValues[271] =
{ "HTMLBodyElement", DontDelete, (intptr_t)jsDOMWindowHTMLBodyElementConstructor, (intptr_t)setJSDOMWindowHTMLBodyElementConstructor },
{ "HTMLButtonElement", DontDelete, (intptr_t)jsDOMWindowHTMLButtonElementConstructor, (intptr_t)setJSDOMWindowHTMLButtonElementConstructor },
{ "HTMLCanvasElement", DontDelete, (intptr_t)jsDOMWindowHTMLCanvasElementConstructor, (intptr_t)setJSDOMWindowHTMLCanvasElementConstructor },
+ { "HTMLDataGridElement", DontDelete, (intptr_t)jsDOMWindowHTMLDataGridElementConstructor, (intptr_t)setJSDOMWindowHTMLDataGridElementConstructor },
+ { "HTMLDataGridColElement", DontDelete, (intptr_t)jsDOMWindowHTMLDataGridColElementConstructor, (intptr_t)setJSDOMWindowHTMLDataGridColElementConstructor },
{ "HTMLDListElement", DontDelete, (intptr_t)jsDOMWindowHTMLDListElementConstructor, (intptr_t)setJSDOMWindowHTMLDListElementConstructor },
{ "HTMLDirectoryElement", DontDelete, (intptr_t)jsDOMWindowHTMLDirectoryElementConstructor, (intptr_t)setJSDOMWindowHTMLDirectoryElementConstructor },
{ "HTMLDivElement", DontDelete, (intptr_t)jsDOMWindowHTMLDivElementConstructor, (intptr_t)setJSDOMWindowHTMLDivElementConstructor },
@@ -593,13 +592,6 @@ JSDOMWindow::~JSDOMWindow()
invalidateEventListeners(impl()->eventListeners());
}
-bool JSDOMWindow::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
-{
- if (customGetOwnPropertySlot(exec, propertyName, slot))
- return true;
- return getStaticValueSlot<JSDOMWindow, Base>(exec, &JSDOMWindowTable, this, propertyName, slot);
-}
-
JSValue jsDOMWindowScreen(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
@@ -1958,14 +1950,6 @@ JSValue jsDOMWindowDOMExceptionConstructor(ExecState* exec, const Identifier&, c
return JSDOMCoreException::getConstructor(exec);
}
-JSValue jsDOMWindowDOMStringListConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
- return jsUndefined();
- UNUSED_PARAM(slot);
- return JSDOMStringList::getConstructor(exec);
-}
-
JSValue jsDOMWindowDOMImplementationConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
@@ -2198,6 +2182,22 @@ JSValue jsDOMWindowHTMLCanvasElementConstructor(ExecState* exec, const Identifie
return JSHTMLCanvasElement::getConstructor(exec);
}
+JSValue jsDOMWindowHTMLDataGridElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
+ return jsUndefined();
+ UNUSED_PARAM(slot);
+ return JSHTMLDataGridElement::getConstructor(exec);
+}
+
+JSValue jsDOMWindowHTMLDataGridColElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
+ return jsUndefined();
+ UNUSED_PARAM(slot);
+ return JSHTMLDataGridColElement::getConstructor(exec);
+}
+
JSValue jsDOMWindowHTMLDListElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
if (!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
@@ -3089,13 +3089,6 @@ JSValue jsDOMWindowSVGUnitTypesConstructor(ExecState* exec, const Identifier&, c
return JSSVGUnitTypes::getConstructor(exec);
}
-void JSDOMWindow::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
-{
- if (customPut(exec, propertyName, value, slot))
- return;
- lookupPut<JSDOMWindow, Base>(exec, propertyName, value, &JSDOMWindowTable, this, slot);
-}
-
void setJSDOMWindowLocationbar(ExecState* exec, JSObject* thisObject, JSValue value)
{
if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
@@ -3327,12 +3320,16 @@ void setJSDOMWindowOpener(ExecState* exec, JSObject* thisObject, JSValue value)
void setJSDOMWindowParent(ExecState* exec, JSObject* thisObject, JSValue value)
{
+ if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
+ return;
// Shadowing a built-in object
static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "parent"), value);
}
void setJSDOMWindowTop(ExecState* exec, JSObject* thisObject, JSValue value)
{
+ if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
+ return;
// Shadowing a built-in object
static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "top"), value);
}
@@ -4149,14 +4146,6 @@ void setJSDOMWindowDOMExceptionConstructor(ExecState* exec, JSObject* thisObject
static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "DOMException"), value);
}
-void setJSDOMWindowDOMStringListConstructor(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
- return;
- // Shadowing a built-in constructor
- static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "DOMStringList"), value);
-}
-
void setJSDOMWindowDOMImplementationConstructor(ExecState* exec, JSObject* thisObject, JSValue value)
{
if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
@@ -4389,6 +4378,22 @@ void setJSDOMWindowHTMLCanvasElementConstructor(ExecState* exec, JSObject* thisO
static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "HTMLCanvasElement"), value);
}
+void setJSDOMWindowHTMLDataGridElementConstructor(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
+ return;
+ // Shadowing a built-in constructor
+ static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "HTMLDataGridElement"), value);
+}
+
+void setJSDOMWindowHTMLDataGridColElementConstructor(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
+ return;
+ // Shadowing a built-in constructor
+ static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "HTMLDataGridColElement"), value);
+}
+
void setJSDOMWindowHTMLDListElementConstructor(ExecState* exec, JSObject* thisObject, JSValue value)
{
if (!static_cast<JSDOMWindow*>(thisObject)->allowsAccessFrom(exec))
@@ -5277,13 +5282,6 @@ void setJSDOMWindowSVGUnitTypesConstructor(ExecState* exec, JSObject* thisObject
static_cast<JSDOMWindow*>(thisObject)->putDirect(Identifier(exec, "SVGUnitTypes"), value);
}
-void JSDOMWindow::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
-{
- if (customGetPropertyNames(exec, propertyNames))
- return;
- Base::getPropertyNames(exec, propertyNames);
-}
-
JSValue JSC_HOST_CALL jsDOMWindowPrototypeFunctionGetSelection(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
{
UNUSED_PARAM(args);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.h b/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.h
index ccab201..869e598 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDOMWindow.h
@@ -21,8 +21,9 @@
#ifndef JSDOMWindow_h
#define JSDOMWindow_h
-#include "JSDOMWindowBase.h"
#include "DOMWindow.h"
+#include "JSDOMWindowBase.h"
+
namespace WebCore {
class DOMWindow;
@@ -35,9 +36,7 @@ public:
JSDOMWindow(PassRefPtr<JSC::Structure>, PassRefPtr<DOMWindow>, JSDOMWindowShell*);
virtual ~JSDOMWindow();
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
@@ -50,7 +49,6 @@ public:
virtual bool deleteProperty(JSC::ExecState*, const JSC::Identifier&);
virtual void getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
- bool customGetPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
virtual bool getPropertyAttributes(JSC::ExecState*, const JSC::Identifier&, unsigned& attributes) const;
virtual void defineGetter(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSObject* getterFunction);
virtual void defineSetter(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSObject* setterFunction);
@@ -389,8 +387,6 @@ JSC::JSValue jsDOMWindowStyleSheetListConstructor(JSC::ExecState*, const JSC::Id
void setJSDOMWindowStyleSheetListConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowDOMExceptionConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSDOMWindowDOMExceptionConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsDOMWindowDOMStringListConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSDOMWindowDOMStringListConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowDOMImplementationConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSDOMWindowDOMImplementationConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowDocumentFragmentConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
@@ -449,6 +445,10 @@ JSC::JSValue jsDOMWindowHTMLButtonElementConstructor(JSC::ExecState*, const JSC:
void setJSDOMWindowHTMLButtonElementConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowHTMLCanvasElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSDOMWindowHTMLCanvasElementConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDOMWindowHTMLDataGridElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDOMWindowHTMLDataGridElementConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDOMWindowHTMLDataGridColElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDOMWindowHTMLDataGridColElementConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowHTMLDListElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSDOMWindowHTMLDListElementConstructor(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDOMWindowHTMLDirectoryElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.cpp b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.cpp
new file mode 100644
index 0000000..105b916
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.cpp
@@ -0,0 +1,289 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSDataGridColumn.h"
+
+#include "DataGridColumn.h"
+#include "KURL.h"
+#include <runtime/JSNumberCell.h>
+#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSDataGridColumn);
+
+/* Hash table */
+
+static const HashTableValue JSDataGridColumnTableValues[8] =
+{
+ { "id", DontDelete, (intptr_t)jsDataGridColumnId, (intptr_t)setJSDataGridColumnId },
+ { "label", DontDelete, (intptr_t)jsDataGridColumnLabel, (intptr_t)setJSDataGridColumnLabel },
+ { "type", DontDelete, (intptr_t)jsDataGridColumnType, (intptr_t)setJSDataGridColumnType },
+ { "sortable", DontDelete, (intptr_t)jsDataGridColumnSortable, (intptr_t)setJSDataGridColumnSortable },
+ { "sortDirection", DontDelete, (intptr_t)jsDataGridColumnSortDirection, (intptr_t)setJSDataGridColumnSortDirection },
+ { "primary", DontDelete, (intptr_t)jsDataGridColumnPrimary, (intptr_t)setJSDataGridColumnPrimary },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsDataGridColumnConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 63, JSDataGridColumnTableValues, 0 };
+#else
+ { 17, 15, JSDataGridColumnTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSDataGridColumnConstructorTableValues[7] =
+{
+ { "NEVER_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnNEVER_SORTED, (intptr_t)0 },
+ { "ALWAYS_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnALWAYS_SORTED, (intptr_t)0 },
+ { "SOMETIMES_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSOMETIMES_SORTED, (intptr_t)0 },
+ { "NATURAL_SORT", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnNATURAL_SORT, (intptr_t)0 },
+ { "SORT_ASCENDING", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSORT_ASCENDING, (intptr_t)0 },
+ { "SORC_DESCENDING", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSORC_DESCENDING, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 31, JSDataGridColumnConstructorTableValues, 0 };
+#else
+ { 17, 15, JSDataGridColumnConstructorTableValues, 0 };
+#endif
+
+class JSDataGridColumnConstructor : public DOMObject {
+public:
+ JSDataGridColumnConstructor(ExecState* exec)
+ : DOMObject(JSDataGridColumnConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSDataGridColumnPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSDataGridColumnConstructor::s_info = { "DataGridColumnConstructor", 0, &JSDataGridColumnConstructorTable, 0 };
+
+bool JSDataGridColumnConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSDataGridColumnConstructor, DOMObject>(exec, &JSDataGridColumnConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSDataGridColumnPrototypeTableValues[7] =
+{
+ { "NEVER_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnNEVER_SORTED, (intptr_t)0 },
+ { "ALWAYS_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnALWAYS_SORTED, (intptr_t)0 },
+ { "SOMETIMES_SORTED", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSOMETIMES_SORTED, (intptr_t)0 },
+ { "NATURAL_SORT", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnNATURAL_SORT, (intptr_t)0 },
+ { "SORT_ASCENDING", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSORT_ASCENDING, (intptr_t)0 },
+ { "SORC_DESCENDING", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnSORC_DESCENDING, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 31, JSDataGridColumnPrototypeTableValues, 0 };
+#else
+ { 17, 15, JSDataGridColumnPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSDataGridColumnPrototype::s_info = { "DataGridColumnPrototype", 0, &JSDataGridColumnPrototypeTable, 0 };
+
+JSObject* JSDataGridColumnPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSDataGridColumn>(exec, globalObject);
+}
+
+bool JSDataGridColumnPrototype::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSDataGridColumnPrototype, JSObject>(exec, &JSDataGridColumnPrototypeTable, this, propertyName, slot);
+}
+
+const ClassInfo JSDataGridColumn::s_info = { "DataGridColumn", 0, &JSDataGridColumnTable, 0 };
+
+JSDataGridColumn::JSDataGridColumn(PassRefPtr<Structure> structure, PassRefPtr<DataGridColumn> impl)
+ : DOMObject(structure)
+ , m_impl(impl)
+{
+}
+
+JSDataGridColumn::~JSDataGridColumn()
+{
+ forgetDOMObject(*Heap::heap(this)->globalData(), m_impl.get());
+}
+
+JSObject* JSDataGridColumn::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSDataGridColumnPrototype(JSDataGridColumnPrototype::createStructure(globalObject->objectPrototype()));
+}
+
+bool JSDataGridColumn::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSDataGridColumn, Base>(exec, &JSDataGridColumnTable, this, propertyName, slot);
+}
+
+JSValue jsDataGridColumnId(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->id());
+}
+
+JSValue jsDataGridColumnLabel(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->label());
+}
+
+JSValue jsDataGridColumnType(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->type());
+}
+
+JSValue jsDataGridColumnSortable(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->sortable());
+}
+
+JSValue jsDataGridColumnSortDirection(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->sortDirection());
+}
+
+JSValue jsDataGridColumnPrimary(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->primary());
+}
+
+JSValue jsDataGridColumnConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSDataGridColumn*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSDataGridColumn::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ lookupPut<JSDataGridColumn, Base>(exec, propertyName, value, &JSDataGridColumnTable, this, slot);
+}
+
+void setJSDataGridColumnId(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setId(value.toString(exec));
+}
+
+void setJSDataGridColumnLabel(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setLabel(value.toString(exec));
+}
+
+void setJSDataGridColumnType(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setType(value.toString(exec));
+}
+
+void setJSDataGridColumnSortable(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setSortable(value.toInt32(exec));
+}
+
+void setJSDataGridColumnSortDirection(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setSortDirection(value.toInt32(exec));
+}
+
+void setJSDataGridColumnPrimary(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ DataGridColumn* imp = static_cast<DataGridColumn*>(static_cast<JSDataGridColumn*>(thisObject)->impl());
+ imp->setPrimary(value.toBoolean(exec));
+}
+
+JSValue JSDataGridColumn::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSDataGridColumnConstructor>(exec);
+}
+
+// Constant getters
+
+JSValue jsDataGridColumnNEVER_SORTED(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(0));
+}
+
+JSValue jsDataGridColumnALWAYS_SORTED(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(1));
+}
+
+JSValue jsDataGridColumnSOMETIMES_SORTED(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(2));
+}
+
+JSValue jsDataGridColumnNATURAL_SORT(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(0));
+}
+
+JSValue jsDataGridColumnSORT_ASCENDING(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(1));
+}
+
+JSValue jsDataGridColumnSORC_DESCENDING(ExecState* exec, const Identifier&, const PropertySlot&)
+{
+ return jsNumber(exec, static_cast<int>(2));
+}
+
+JSC::JSValue toJS(JSC::ExecState* exec, DataGridColumn* object)
+{
+ return getDOMObjectWrapper<JSDataGridColumn>(exec, object);
+}
+DataGridColumn* toDataGridColumn(JSC::JSValue value)
+{
+ return value.isObject(&JSDataGridColumn::s_info) ? static_cast<JSDataGridColumn*>(asObject(value))->impl() : 0;
+}
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.h b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.h
new file mode 100644
index 0000000..331ad9d
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumn.h
@@ -0,0 +1,98 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#ifndef JSDataGridColumn_h
+#define JSDataGridColumn_h
+
+#include "JSDOMBinding.h"
+#include <runtime/JSGlobalObject.h>
+#include <runtime/ObjectPrototype.h>
+
+namespace WebCore {
+
+class DataGridColumn;
+
+class JSDataGridColumn : public DOMObject {
+ typedef DOMObject Base;
+public:
+ JSDataGridColumn(PassRefPtr<JSC::Structure>, PassRefPtr<DataGridColumn>);
+ virtual ~JSDataGridColumn();
+ static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
+ virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+
+ static JSC::JSValue getConstructor(JSC::ExecState*);
+ DataGridColumn* impl() const { return m_impl.get(); }
+
+private:
+ RefPtr<DataGridColumn> m_impl;
+};
+
+JSC::JSValue toJS(JSC::ExecState*, DataGridColumn*);
+DataGridColumn* toDataGridColumn(JSC::JSValue);
+
+class JSDataGridColumnPrototype : public JSC::JSObject {
+ typedef JSC::JSObject Base;
+public:
+ static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+ JSDataGridColumnPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+};
+
+// Attributes
+
+JSC::JSValue jsDataGridColumnId(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnId(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnLabel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnLabel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnType(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnType(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnSortable(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnSortable(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnSortDirection(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnSortDirection(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnPrimary(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDataGridColumnPrimary(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDataGridColumnConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+// Constants
+
+JSC::JSValue jsDataGridColumnNEVER_SORTED(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnALWAYS_SORTED(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnSOMETIMES_SORTED(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnNATURAL_SORT(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnSORT_ASCENDING(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnSORC_DESCENDING(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+
+} // namespace WebCore
+
+#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.cpp b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.cpp
new file mode 100644
index 0000000..276878e
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.cpp
@@ -0,0 +1,301 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSDataGridColumnList.h"
+
+#include "AtomicString.h"
+#include "DataGridColumn.h"
+#include "DataGridColumnList.h"
+#include "ExceptionCode.h"
+#include "JSDataGridColumn.h"
+#include <runtime/Error.h>
+#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSDataGridColumnList);
+
+/* Hash table */
+
+static const HashTableValue JSDataGridColumnListTableValues[5] =
+{
+ { "length", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnListLength, (intptr_t)0 },
+ { "sortColumn", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnListSortColumn, (intptr_t)0 },
+ { "primaryColumn", DontDelete|ReadOnly, (intptr_t)jsDataGridColumnListPrimaryColumn, (intptr_t)0 },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsDataGridColumnListConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnListTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 15, JSDataGridColumnListTableValues, 0 };
+#else
+ { 10, 7, JSDataGridColumnListTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSDataGridColumnListConstructorTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnListConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSDataGridColumnListConstructorTableValues, 0 };
+#else
+ { 1, 0, JSDataGridColumnListConstructorTableValues, 0 };
+#endif
+
+class JSDataGridColumnListConstructor : public DOMObject {
+public:
+ JSDataGridColumnListConstructor(ExecState* exec)
+ : DOMObject(JSDataGridColumnListConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSDataGridColumnListPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSDataGridColumnListConstructor::s_info = { "DataGridColumnListConstructor", 0, &JSDataGridColumnListConstructorTable, 0 };
+
+bool JSDataGridColumnListConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSDataGridColumnListConstructor, DOMObject>(exec, &JSDataGridColumnListConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSDataGridColumnListPrototypeTableValues[6] =
+{
+ { "item", DontDelete|Function, (intptr_t)jsDataGridColumnListPrototypeFunctionItem, (intptr_t)1 },
+ { "add", DontDelete|Function, (intptr_t)jsDataGridColumnListPrototypeFunctionAdd, (intptr_t)5 },
+ { "remove", DontDelete|Function, (intptr_t)jsDataGridColumnListPrototypeFunctionRemove, (intptr_t)1 },
+ { "move", DontDelete|Function, (intptr_t)jsDataGridColumnListPrototypeFunctionMove, (intptr_t)2 },
+ { "clear", DontDelete|Function, (intptr_t)jsDataGridColumnListPrototypeFunctionClear, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSDataGridColumnListPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 31, JSDataGridColumnListPrototypeTableValues, 0 };
+#else
+ { 17, 15, JSDataGridColumnListPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSDataGridColumnListPrototype::s_info = { "DataGridColumnListPrototype", 0, &JSDataGridColumnListPrototypeTable, 0 };
+
+JSObject* JSDataGridColumnListPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSDataGridColumnList>(exec, globalObject);
+}
+
+bool JSDataGridColumnListPrototype::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticFunctionSlot<JSObject>(exec, &JSDataGridColumnListPrototypeTable, this, propertyName, slot);
+}
+
+const ClassInfo JSDataGridColumnList::s_info = { "DataGridColumnList", 0, &JSDataGridColumnListTable, 0 };
+
+JSDataGridColumnList::JSDataGridColumnList(PassRefPtr<Structure> structure, PassRefPtr<DataGridColumnList> impl)
+ : DOMObject(structure)
+ , m_impl(impl)
+{
+}
+
+JSDataGridColumnList::~JSDataGridColumnList()
+{
+ forgetDOMObject(*Heap::heap(this)->globalData(), m_impl.get());
+}
+
+JSObject* JSDataGridColumnList::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSDataGridColumnListPrototype(JSDataGridColumnListPrototype::createStructure(globalObject->objectPrototype()));
+}
+
+bool JSDataGridColumnList::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ const HashEntry* entry = JSDataGridColumnListTable.entry(exec, propertyName);
+ if (entry) {
+ slot.setCustom(this, entry->propertyGetter());
+ return true;
+ }
+ bool ok;
+ unsigned index = propertyName.toUInt32(&ok, false);
+ if (ok && index < static_cast<DataGridColumnList*>(impl())->length()) {
+ slot.setCustomIndex(this, index, indexGetter);
+ return true;
+ }
+ if (canGetItemsForName(exec, static_cast<DataGridColumnList*>(impl()), propertyName)) {
+ slot.setCustom(this, nameGetter);
+ return true;
+ }
+ return getStaticValueSlot<JSDataGridColumnList, Base>(exec, &JSDataGridColumnListTable, this, propertyName, slot);
+}
+
+bool JSDataGridColumnList::getOwnPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
+{
+ if (propertyName < static_cast<DataGridColumnList*>(impl())->length()) {
+ slot.setCustomIndex(this, propertyName, indexGetter);
+ return true;
+ }
+ return getOwnPropertySlot(exec, Identifier::from(exec, propertyName), slot);
+}
+
+JSValue jsDataGridColumnListLength(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->length());
+}
+
+JSValue jsDataGridColumnListSortColumn(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()))->impl());
+ return toJS(exec, WTF::getPtr(imp->sortColumn()));
+}
+
+JSValue jsDataGridColumnListPrimaryColumn(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()))->impl());
+ return toJS(exec, WTF::getPtr(imp->primaryColumn()));
+}
+
+JSValue jsDataGridColumnListConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSDataGridColumnList::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
+{
+ for (unsigned i = 0; i < static_cast<DataGridColumnList*>(impl())->length(); ++i)
+ propertyNames.add(Identifier::from(exec, i));
+ Base::getPropertyNames(exec, propertyNames);
+}
+
+JSValue JSDataGridColumnList::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSDataGridColumnListConstructor>(exec);
+}
+
+JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionItem(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
+{
+ UNUSED_PARAM(args);
+ if (!thisValue.isObject(&JSDataGridColumnList::s_info))
+ return throwError(exec, TypeError);
+ JSDataGridColumnList* castedThisObj = static_cast<JSDataGridColumnList*>(asObject(thisValue));
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(castedThisObj->impl());
+ int index = args.at(0).toInt32(exec);
+ if (index < 0) {
+ setDOMException(exec, INDEX_SIZE_ERR);
+ return jsUndefined();
+ }
+
+
+ JSC::JSValue result = toJS(exec, WTF::getPtr(imp->item(index)));
+ return result;
+}
+
+JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionAdd(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
+{
+ UNUSED_PARAM(args);
+ if (!thisValue.isObject(&JSDataGridColumnList::s_info))
+ return throwError(exec, TypeError);
+ JSDataGridColumnList* castedThisObj = static_cast<JSDataGridColumnList*>(asObject(thisValue));
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(castedThisObj->impl());
+ const UString& id = args.at(0).toString(exec);
+ const UString& label = args.at(1).toString(exec);
+ const UString& type = args.at(2).toString(exec);
+ bool primary = args.at(3).toBoolean(exec);
+ unsigned short sortable = args.at(4).toInt32(exec);
+
+
+ JSC::JSValue result = toJS(exec, WTF::getPtr(imp->add(id, label, type, primary, sortable)));
+ return result;
+}
+
+JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionRemove(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
+{
+ UNUSED_PARAM(args);
+ if (!thisValue.isObject(&JSDataGridColumnList::s_info))
+ return throwError(exec, TypeError);
+ JSDataGridColumnList* castedThisObj = static_cast<JSDataGridColumnList*>(asObject(thisValue));
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(castedThisObj->impl());
+ DataGridColumn* column = toDataGridColumn(args.at(0));
+
+ imp->remove(column);
+ return jsUndefined();
+}
+
+JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionMove(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
+{
+ UNUSED_PARAM(args);
+ if (!thisValue.isObject(&JSDataGridColumnList::s_info))
+ return throwError(exec, TypeError);
+ JSDataGridColumnList* castedThisObj = static_cast<JSDataGridColumnList*>(asObject(thisValue));
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(castedThisObj->impl());
+ DataGridColumn* column = toDataGridColumn(args.at(0));
+ unsigned index = args.at(1).toInt32(exec);
+
+ imp->move(column, index);
+ return jsUndefined();
+}
+
+JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionClear(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
+{
+ UNUSED_PARAM(args);
+ if (!thisValue.isObject(&JSDataGridColumnList::s_info))
+ return throwError(exec, TypeError);
+ JSDataGridColumnList* castedThisObj = static_cast<JSDataGridColumnList*>(asObject(thisValue));
+ DataGridColumnList* imp = static_cast<DataGridColumnList*>(castedThisObj->impl());
+
+ imp->clear();
+ return jsUndefined();
+}
+
+
+JSValue JSDataGridColumnList::indexGetter(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ JSDataGridColumnList* thisObj = static_cast<JSDataGridColumnList*>(asObject(slot.slotBase()));
+ return toJS(exec, static_cast<DataGridColumnList*>(thisObj->impl())->item(slot.index()));
+}
+JSC::JSValue toJS(JSC::ExecState* exec, DataGridColumnList* object)
+{
+ return getDOMObjectWrapper<JSDataGridColumnList>(exec, object);
+}
+DataGridColumnList* toDataGridColumnList(JSC::JSValue value)
+{
+ return value.isObject(&JSDataGridColumnList::s_info) ? static_cast<JSDataGridColumnList*>(asObject(value))->impl() : 0;
+}
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDOMStringList.h b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.h
index 4d222c8..879daf9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDOMStringList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDataGridColumnList.h
@@ -18,8 +18,8 @@
Boston, MA 02110-1301, USA.
*/
-#ifndef JSDOMStringList_h
-#define JSDOMStringList_h
+#ifndef JSDataGridColumnList_h
+#define JSDataGridColumnList_h
#include "JSDOMBinding.h"
#include <runtime/JSGlobalObject.h>
@@ -27,13 +27,13 @@
namespace WebCore {
-class DOMStringList;
+class DataGridColumnList;
-class JSDOMStringList : public DOMObject {
+class JSDataGridColumnList : public DOMObject {
typedef DOMObject Base;
public:
- JSDOMStringList(PassRefPtr<JSC::Structure>, PassRefPtr<DOMStringList>);
- virtual ~JSDOMStringList();
+ JSDataGridColumnList(PassRefPtr<JSC::Structure>, PassRefPtr<DataGridColumnList>);
+ virtual ~JSDataGridColumnList();
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
virtual bool getOwnPropertySlot(JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);
@@ -47,20 +47,20 @@ public:
virtual void getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
static JSC::JSValue getConstructor(JSC::ExecState*);
+ DataGridColumnList* impl() const { return m_impl.get(); }
- // Custom functions
- JSC::JSValue item(JSC::ExecState*, const JSC::ArgList&);
- DOMStringList* impl() const { return m_impl.get(); }
-
private:
- RefPtr<DOMStringList> m_impl;
- JSC::JSValue getByIndex(JSC::ExecState*, unsigned index);
+ RefPtr<DataGridColumnList> m_impl;
+ static JSC::JSValue indexGetter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+private:
+ static bool canGetItemsForName(JSC::ExecState*, DataGridColumnList*, const JSC::Identifier&);
+ static JSC::JSValue nameGetter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
};
-JSC::JSValue toJS(JSC::ExecState*, DOMStringList*);
-DOMStringList* toDOMStringList(JSC::JSValue);
+JSC::JSValue toJS(JSC::ExecState*, DataGridColumnList*);
+DataGridColumnList* toDataGridColumnList(JSC::JSValue);
-class JSDOMStringListPrototype : public JSC::JSObject {
+class JSDataGridColumnListPrototype : public JSC::JSObject {
typedef JSC::JSObject Base;
public:
static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
@@ -71,17 +71,22 @@ public:
{
return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
}
- JSDOMStringListPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+ JSDataGridColumnListPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
};
// Functions
-JSC::JSValue JSC_HOST_CALL jsDOMStringListPrototypeFunctionItem(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
-JSC::JSValue JSC_HOST_CALL jsDOMStringListPrototypeFunctionContains(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
+JSC::JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionItem(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
+JSC::JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionAdd(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
+JSC::JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionRemove(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
+JSC::JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionMove(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
+JSC::JSValue JSC_HOST_CALL jsDataGridColumnListPrototypeFunctionClear(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
// Attributes
-JSC::JSValue jsDOMStringListLength(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-JSC::JSValue jsDOMStringListConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnListLength(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnListSortColumn(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnListPrimaryColumn(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsDataGridColumnListConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDatabase.cpp b/src/3rdparty/webkit/WebCore/generated/JSDatabase.cpp
index 76f3fc4..490b081 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDatabase.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDatabase.cpp
@@ -20,18 +20,15 @@
#include "config.h"
-
#if ENABLE(DATABASE)
#include "JSDatabase.h"
-#include <wtf/GetPtr.h>
-
#include "Database.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDatabase.h b/src/3rdparty/webkit/WebCore/generated/JSDatabase.h
index d9eee58..94b60be 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDatabase.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDatabase.h
@@ -21,7 +21,6 @@
#ifndef JSDatabase_h
#define JSDatabase_h
-
#if ENABLE(DATABASE)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDocument.cpp b/src/3rdparty/webkit/WebCore/generated/JSDocument.cpp
index 545a048..2c59f13 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDocument.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDocument.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSDocument.h"
-#include <wtf/GetPtr.h>
-
#include "Attr.h"
#include "CDATASection.h"
#include "CSSMutableStyleDeclaration.h"
@@ -38,6 +35,8 @@
#include "Element.h"
#include "EntityReference.h"
#include "Event.h"
+#include "EventListener.h"
+#include "Frame.h"
#include "HTMLCollection.h"
#include "HTMLElement.h"
#include "JSAttr.h"
@@ -46,6 +45,7 @@
#include "JSCanvasRenderingContext2D.h"
#include "JSComment.h"
#include "JSCustomXPathNSResolver.h"
+#include "JSDOMGlobalObject.h"
#include "JSDOMImplementation.h"
#include "JSDOMSelection.h"
#include "JSDOMWindow.h"
@@ -54,6 +54,7 @@
#include "JSElement.h"
#include "JSEntityReference.h"
#include "JSEvent.h"
+#include "JSEventListener.h"
#include "JSHTMLCollection.h"
#include "JSHTMLElement.h"
#include "JSNode.h"
@@ -83,10 +84,9 @@
#include "XPathExpression.h"
#include "XPathNSResolver.h"
#include "XPathResult.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -96,7 +96,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSDocument);
/* Hash table */
-static const HashTableValue JSDocumentTableValues[31] =
+static const HashTableValue JSDocumentTableValues[69] =
{
{ "doctype", DontDelete|ReadOnly, (intptr_t)jsDocumentDoctype, (intptr_t)0 },
{ "implementation", DontDelete|ReadOnly, (intptr_t)jsDocumentImplementation, (intptr_t)0 },
@@ -127,15 +127,53 @@ static const HashTableValue JSDocumentTableValues[31] =
{ "characterSet", DontDelete|ReadOnly, (intptr_t)jsDocumentCharacterSet, (intptr_t)0 },
{ "preferredStylesheetSet", DontDelete|ReadOnly, (intptr_t)jsDocumentPreferredStylesheetSet, (intptr_t)0 },
{ "selectedStylesheetSet", DontDelete, (intptr_t)jsDocumentSelectedStylesheetSet, (intptr_t)setJSDocumentSelectedStylesheetSet },
+ { "onabort", DontDelete|DontEnum, (intptr_t)jsDocumentOnabort, (intptr_t)setJSDocumentOnabort },
+ { "onblur", DontDelete|DontEnum, (intptr_t)jsDocumentOnblur, (intptr_t)setJSDocumentOnblur },
+ { "onchange", DontDelete|DontEnum, (intptr_t)jsDocumentOnchange, (intptr_t)setJSDocumentOnchange },
+ { "onclick", DontDelete|DontEnum, (intptr_t)jsDocumentOnclick, (intptr_t)setJSDocumentOnclick },
+ { "oncontextmenu", DontDelete|DontEnum, (intptr_t)jsDocumentOncontextmenu, (intptr_t)setJSDocumentOncontextmenu },
+ { "ondblclick", DontDelete|DontEnum, (intptr_t)jsDocumentOndblclick, (intptr_t)setJSDocumentOndblclick },
+ { "ondrag", DontDelete|DontEnum, (intptr_t)jsDocumentOndrag, (intptr_t)setJSDocumentOndrag },
+ { "ondragend", DontDelete|DontEnum, (intptr_t)jsDocumentOndragend, (intptr_t)setJSDocumentOndragend },
+ { "ondragenter", DontDelete|DontEnum, (intptr_t)jsDocumentOndragenter, (intptr_t)setJSDocumentOndragenter },
+ { "ondragleave", DontDelete|DontEnum, (intptr_t)jsDocumentOndragleave, (intptr_t)setJSDocumentOndragleave },
+ { "ondragover", DontDelete|DontEnum, (intptr_t)jsDocumentOndragover, (intptr_t)setJSDocumentOndragover },
+ { "ondragstart", DontDelete|DontEnum, (intptr_t)jsDocumentOndragstart, (intptr_t)setJSDocumentOndragstart },
+ { "ondrop", DontDelete|DontEnum, (intptr_t)jsDocumentOndrop, (intptr_t)setJSDocumentOndrop },
+ { "onerror", DontDelete|DontEnum, (intptr_t)jsDocumentOnerror, (intptr_t)setJSDocumentOnerror },
+ { "onfocus", DontDelete|DontEnum, (intptr_t)jsDocumentOnfocus, (intptr_t)setJSDocumentOnfocus },
+ { "oninput", DontDelete|DontEnum, (intptr_t)jsDocumentOninput, (intptr_t)setJSDocumentOninput },
+ { "onkeydown", DontDelete|DontEnum, (intptr_t)jsDocumentOnkeydown, (intptr_t)setJSDocumentOnkeydown },
+ { "onkeypress", DontDelete|DontEnum, (intptr_t)jsDocumentOnkeypress, (intptr_t)setJSDocumentOnkeypress },
+ { "onkeyup", DontDelete|DontEnum, (intptr_t)jsDocumentOnkeyup, (intptr_t)setJSDocumentOnkeyup },
+ { "onload", DontDelete|DontEnum, (intptr_t)jsDocumentOnload, (intptr_t)setJSDocumentOnload },
+ { "onmousedown", DontDelete|DontEnum, (intptr_t)jsDocumentOnmousedown, (intptr_t)setJSDocumentOnmousedown },
+ { "onmousemove", DontDelete|DontEnum, (intptr_t)jsDocumentOnmousemove, (intptr_t)setJSDocumentOnmousemove },
+ { "onmouseout", DontDelete|DontEnum, (intptr_t)jsDocumentOnmouseout, (intptr_t)setJSDocumentOnmouseout },
+ { "onmouseover", DontDelete|DontEnum, (intptr_t)jsDocumentOnmouseover, (intptr_t)setJSDocumentOnmouseover },
+ { "onmouseup", DontDelete|DontEnum, (intptr_t)jsDocumentOnmouseup, (intptr_t)setJSDocumentOnmouseup },
+ { "onmousewheel", DontDelete|DontEnum, (intptr_t)jsDocumentOnmousewheel, (intptr_t)setJSDocumentOnmousewheel },
+ { "onscroll", DontDelete|DontEnum, (intptr_t)jsDocumentOnscroll, (intptr_t)setJSDocumentOnscroll },
+ { "onselect", DontDelete|DontEnum, (intptr_t)jsDocumentOnselect, (intptr_t)setJSDocumentOnselect },
+ { "onsubmit", DontDelete|DontEnum, (intptr_t)jsDocumentOnsubmit, (intptr_t)setJSDocumentOnsubmit },
+ { "onbeforecut", DontDelete|DontEnum, (intptr_t)jsDocumentOnbeforecut, (intptr_t)setJSDocumentOnbeforecut },
+ { "oncut", DontDelete|DontEnum, (intptr_t)jsDocumentOncut, (intptr_t)setJSDocumentOncut },
+ { "onbeforecopy", DontDelete|DontEnum, (intptr_t)jsDocumentOnbeforecopy, (intptr_t)setJSDocumentOnbeforecopy },
+ { "oncopy", DontDelete|DontEnum, (intptr_t)jsDocumentOncopy, (intptr_t)setJSDocumentOncopy },
+ { "onbeforepaste", DontDelete|DontEnum, (intptr_t)jsDocumentOnbeforepaste, (intptr_t)setJSDocumentOnbeforepaste },
+ { "onpaste", DontDelete|DontEnum, (intptr_t)jsDocumentOnpaste, (intptr_t)setJSDocumentOnpaste },
+ { "onreset", DontDelete|DontEnum, (intptr_t)jsDocumentOnreset, (intptr_t)setJSDocumentOnreset },
+ { "onsearch", DontDelete|DontEnum, (intptr_t)jsDocumentOnsearch, (intptr_t)setJSDocumentOnsearch },
+ { "onselectstart", DontDelete|DontEnum, (intptr_t)jsDocumentOnselectstart, (intptr_t)setJSDocumentOnselectstart },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsDocumentConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
static const HashTable JSDocumentTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 255, JSDocumentTableValues, 0 };
+ { 2047, JSDocumentTableValues, 0 };
#else
- { 71, 63, JSDocumentTableValues, 0 };
+ { 259, 255, JSDocumentTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -456,6 +494,424 @@ JSValue jsDocumentSelectedStylesheetSet(ExecState* exec, const Identifier&, cons
return jsStringOrNull(exec, imp->selectedStylesheetSet());
}
+JSValue jsDocumentOnabort(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onabort()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnblur(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onblur()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnchange(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onchange()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onclick()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOncontextmenu(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncontextmenu()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndblclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondblclick()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndrag(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondrag()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndragend(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragend()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndragenter(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragenter()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndragleave(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragleave()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndragover(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragover()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndragstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragstart()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOndrop(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondrop()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnerror(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onerror()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnfocus(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onfocus()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOninput(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oninput()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnkeydown(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeydown()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnkeypress(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeypress()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnkeyup(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeyup()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmousedown(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousedown()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmousemove(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousemove()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmouseout(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseout()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmouseover(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseover()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmouseup(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseup()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnmousewheel(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousewheel()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnscroll(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onscroll()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnselect(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onselect()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnsubmit(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onsubmit()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnbeforecut(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforecut()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOncut(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncut()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnbeforecopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforecopy()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOncopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncopy()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnbeforepaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforepaste()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnpaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onpaste()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnreset(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onreset()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnsearch(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onsearch()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsDocumentOnselectstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onselectstart()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
JSValue jsDocumentConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSDocument*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -530,6 +986,386 @@ void setJSDocumentSelectedStylesheetSet(ExecState* exec, JSObject* thisObject, J
imp->setSelectedStylesheetSet(valueToStringWithNullCheck(exec, value));
}
+void setJSDocumentOnabort(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnabort(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnblur(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnblur(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnchange(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnchange(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnclick(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnclick(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOncontextmenu(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncontextmenu(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndblclick(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndblclick(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndrag(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndrag(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndragend(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragend(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndragenter(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragenter(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndragleave(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragleave(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndragover(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragover(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndragstart(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragstart(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOndrop(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndrop(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnerror(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnerror(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnfocus(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnfocus(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOninput(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOninput(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnkeydown(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeydown(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnkeypress(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeypress(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnkeyup(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeyup(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnload(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmousedown(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousedown(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmousemove(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousemove(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmouseout(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseout(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmouseover(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseover(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmouseup(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseup(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnmousewheel(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousewheel(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnscroll(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnscroll(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnselect(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnselect(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnsubmit(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnsubmit(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnbeforecut(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforecut(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOncut(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncut(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnbeforecopy(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforecopy(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOncopy(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncopy(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnbeforepaste(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforepaste(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnpaste(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnpaste(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnreset(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnreset(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnsearch(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnsearch(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSDocumentOnselectstart(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Document* imp = static_cast<Document*>(static_cast<JSDocument*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnselectstart(globalObject->createJSAttributeEventListener(value));
+}
+
JSValue JSDocument::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSDocumentConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDocument.h b/src/3rdparty/webkit/WebCore/generated/JSDocument.h
index da6442f..c2032ea 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDocument.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDocument.h
@@ -21,10 +21,11 @@
#ifndef JSDocument_h
#define JSDocument_h
+#include "Document.h"
#include "JSNode.h"
#include <runtime/Lookup.h>
#include <wtf/AlwaysInline.h>
-#include "Document.h"
+
namespace WebCore {
class Document;
@@ -159,6 +160,82 @@ JSC::JSValue jsDocumentCharacterSet(JSC::ExecState*, const JSC::Identifier&, con
JSC::JSValue jsDocumentPreferredStylesheetSet(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
JSC::JSValue jsDocumentSelectedStylesheetSet(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSDocumentSelectedStylesheetSet(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnabort(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnabort(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnblur(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnblur(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnchange(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnchange(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOncontextmenu(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOncontextmenu(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndblclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndblclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndrag(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndrag(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndragend(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndragend(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndragenter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndragenter(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndragleave(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndragleave(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndragover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndragover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndragstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndragstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOndrop(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOndrop(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnerror(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnerror(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnfocus(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnfocus(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOninput(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOninput(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnkeydown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnkeydown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnkeypress(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnkeypress(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnkeyup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnkeyup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmousedown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmousedown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmousemove(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmousemove(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmouseout(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmouseout(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmouseover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmouseover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmouseup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmouseup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnmousewheel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnmousewheel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnscroll(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnscroll(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnselect(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnselect(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnsubmit(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnsubmit(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnbeforecut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnbeforecut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOncut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOncut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnbeforecopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnbeforecopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOncopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOncopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnbeforepaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnbeforepaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnpaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnpaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnreset(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnreset(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnsearch(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnsearch(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsDocumentOnselectstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSDocumentOnselectstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsDocumentConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDocumentFragment.cpp b/src/3rdparty/webkit/WebCore/generated/JSDocumentFragment.cpp
index f5e7a5d..865efd2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDocumentFragment.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDocumentFragment.cpp
@@ -19,20 +19,16 @@
*/
#include "config.h"
-
#include "JSDocumentFragment.h"
-#include <wtf/GetPtr.h>
-
#include "DocumentFragment.h"
#include "Element.h"
#include "JSElement.h"
#include "JSNodeList.h"
#include "NameNodeList.h"
#include "NodeList.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDocumentType.cpp b/src/3rdparty/webkit/WebCore/generated/JSDocumentType.cpp
index 9777374..43e7a8c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDocumentType.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSDocumentType.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSDocumentType.h"
-#include <wtf/GetPtr.h>
-
#include "DocumentType.h"
#include "JSNamedNodeMap.h"
#include "KURL.h"
#include "NamedNodeMap.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSDocumentType.h b/src/3rdparty/webkit/WebCore/generated/JSDocumentType.h
index 1fb4e3e..10a5530 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSDocumentType.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSDocumentType.h
@@ -21,8 +21,9 @@
#ifndef JSDocumentType_h
#define JSDocumentType_h
-#include "JSNode.h"
#include "DocumentType.h"
+#include "JSNode.h"
+
namespace WebCore {
class DocumentType;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSElement.cpp
index 1bddbba..afa1d93 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSElement.cpp
@@ -19,30 +19,31 @@
*/
#include "config.h"
-
#include "JSElement.h"
-#include <wtf/GetPtr.h>
-
#include "Attr.h"
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "ClientRect.h"
#include "ClientRectList.h"
#include "Element.h"
+#include "EventListener.h"
+#include "Frame.h"
#include "JSAttr.h"
#include "JSCSSStyleDeclaration.h"
#include "JSClientRect.h"
#include "JSClientRectList.h"
+#include "JSDOMGlobalObject.h"
#include "JSElement.h"
+#include "JSEventListener.h"
#include "JSNodeList.h"
#include "KURL.h"
#include "NameNodeList.h"
#include "NodeList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -52,7 +53,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSElement);
/* Hash table */
-static const HashTableValue JSElementTableValues[22] =
+static const HashTableValue JSElementTableValues[60] =
{
{ "tagName", DontDelete|ReadOnly, (intptr_t)jsElementTagName, (intptr_t)0 },
{ "style", DontDelete|ReadOnly, (intptr_t)jsElementStyle, (intptr_t)0 },
@@ -74,6 +75,44 @@ static const HashTableValue JSElementTableValues[22] =
{ "previousElementSibling", DontDelete|ReadOnly, (intptr_t)jsElementPreviousElementSibling, (intptr_t)0 },
{ "nextElementSibling", DontDelete|ReadOnly, (intptr_t)jsElementNextElementSibling, (intptr_t)0 },
{ "childElementCount", DontDelete|ReadOnly, (intptr_t)jsElementChildElementCount, (intptr_t)0 },
+ { "onabort", DontDelete|DontEnum, (intptr_t)jsElementOnabort, (intptr_t)setJSElementOnabort },
+ { "onblur", DontDelete|DontEnum, (intptr_t)jsElementOnblur, (intptr_t)setJSElementOnblur },
+ { "onchange", DontDelete|DontEnum, (intptr_t)jsElementOnchange, (intptr_t)setJSElementOnchange },
+ { "onclick", DontDelete|DontEnum, (intptr_t)jsElementOnclick, (intptr_t)setJSElementOnclick },
+ { "oncontextmenu", DontDelete|DontEnum, (intptr_t)jsElementOncontextmenu, (intptr_t)setJSElementOncontextmenu },
+ { "ondblclick", DontDelete|DontEnum, (intptr_t)jsElementOndblclick, (intptr_t)setJSElementOndblclick },
+ { "ondrag", DontDelete|DontEnum, (intptr_t)jsElementOndrag, (intptr_t)setJSElementOndrag },
+ { "ondragend", DontDelete|DontEnum, (intptr_t)jsElementOndragend, (intptr_t)setJSElementOndragend },
+ { "ondragenter", DontDelete|DontEnum, (intptr_t)jsElementOndragenter, (intptr_t)setJSElementOndragenter },
+ { "ondragleave", DontDelete|DontEnum, (intptr_t)jsElementOndragleave, (intptr_t)setJSElementOndragleave },
+ { "ondragover", DontDelete|DontEnum, (intptr_t)jsElementOndragover, (intptr_t)setJSElementOndragover },
+ { "ondragstart", DontDelete|DontEnum, (intptr_t)jsElementOndragstart, (intptr_t)setJSElementOndragstart },
+ { "ondrop", DontDelete|DontEnum, (intptr_t)jsElementOndrop, (intptr_t)setJSElementOndrop },
+ { "onerror", DontDelete|DontEnum, (intptr_t)jsElementOnerror, (intptr_t)setJSElementOnerror },
+ { "onfocus", DontDelete|DontEnum, (intptr_t)jsElementOnfocus, (intptr_t)setJSElementOnfocus },
+ { "oninput", DontDelete|DontEnum, (intptr_t)jsElementOninput, (intptr_t)setJSElementOninput },
+ { "onkeydown", DontDelete|DontEnum, (intptr_t)jsElementOnkeydown, (intptr_t)setJSElementOnkeydown },
+ { "onkeypress", DontDelete|DontEnum, (intptr_t)jsElementOnkeypress, (intptr_t)setJSElementOnkeypress },
+ { "onkeyup", DontDelete|DontEnum, (intptr_t)jsElementOnkeyup, (intptr_t)setJSElementOnkeyup },
+ { "onload", DontDelete|DontEnum, (intptr_t)jsElementOnload, (intptr_t)setJSElementOnload },
+ { "onmousedown", DontDelete|DontEnum, (intptr_t)jsElementOnmousedown, (intptr_t)setJSElementOnmousedown },
+ { "onmousemove", DontDelete|DontEnum, (intptr_t)jsElementOnmousemove, (intptr_t)setJSElementOnmousemove },
+ { "onmouseout", DontDelete|DontEnum, (intptr_t)jsElementOnmouseout, (intptr_t)setJSElementOnmouseout },
+ { "onmouseover", DontDelete|DontEnum, (intptr_t)jsElementOnmouseover, (intptr_t)setJSElementOnmouseover },
+ { "onmouseup", DontDelete|DontEnum, (intptr_t)jsElementOnmouseup, (intptr_t)setJSElementOnmouseup },
+ { "onmousewheel", DontDelete|DontEnum, (intptr_t)jsElementOnmousewheel, (intptr_t)setJSElementOnmousewheel },
+ { "onscroll", DontDelete|DontEnum, (intptr_t)jsElementOnscroll, (intptr_t)setJSElementOnscroll },
+ { "onselect", DontDelete|DontEnum, (intptr_t)jsElementOnselect, (intptr_t)setJSElementOnselect },
+ { "onsubmit", DontDelete|DontEnum, (intptr_t)jsElementOnsubmit, (intptr_t)setJSElementOnsubmit },
+ { "onbeforecut", DontDelete|DontEnum, (intptr_t)jsElementOnbeforecut, (intptr_t)setJSElementOnbeforecut },
+ { "oncut", DontDelete|DontEnum, (intptr_t)jsElementOncut, (intptr_t)setJSElementOncut },
+ { "onbeforecopy", DontDelete|DontEnum, (intptr_t)jsElementOnbeforecopy, (intptr_t)setJSElementOnbeforecopy },
+ { "oncopy", DontDelete|DontEnum, (intptr_t)jsElementOncopy, (intptr_t)setJSElementOncopy },
+ { "onbeforepaste", DontDelete|DontEnum, (intptr_t)jsElementOnbeforepaste, (intptr_t)setJSElementOnbeforepaste },
+ { "onpaste", DontDelete|DontEnum, (intptr_t)jsElementOnpaste, (intptr_t)setJSElementOnpaste },
+ { "onreset", DontDelete|DontEnum, (intptr_t)jsElementOnreset, (intptr_t)setJSElementOnreset },
+ { "onsearch", DontDelete|DontEnum, (intptr_t)jsElementOnsearch, (intptr_t)setJSElementOnsearch },
+ { "onselectstart", DontDelete|DontEnum, (intptr_t)jsElementOnselectstart, (intptr_t)setJSElementOnselectstart },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsElementConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
@@ -82,7 +121,7 @@ static const HashTable JSElementTable =
#if ENABLE(PERFECT_HASH_SIZE)
{ 8191, JSElementTableValues, 0 };
#else
- { 68, 63, JSElementTableValues, 0 };
+ { 141, 127, JSElementTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -328,6 +367,424 @@ JSValue jsElementChildElementCount(ExecState* exec, const Identifier&, const Pro
return jsNumber(exec, imp->childElementCount());
}
+JSValue jsElementOnabort(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onabort()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnblur(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onblur()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnchange(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onchange()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onclick()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOncontextmenu(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncontextmenu()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndblclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondblclick()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndrag(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondrag()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndragend(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragend()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndragenter(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragenter()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndragleave(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragleave()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndragover(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragover()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndragstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondragstart()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOndrop(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ondrop()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnerror(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onerror()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnfocus(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onfocus()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOninput(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oninput()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnkeydown(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeydown()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnkeypress(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeypress()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnkeyup(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onkeyup()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmousedown(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousedown()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmousemove(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousemove()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmouseout(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseout()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmouseover(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseover()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmouseup(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmouseup()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnmousewheel(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmousewheel()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnscroll(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onscroll()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnselect(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onselect()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnsubmit(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onsubmit()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnbeforecut(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforecut()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOncut(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncut()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnbeforecopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforecopy()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOncopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->oncopy()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnbeforepaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforepaste()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnpaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onpaste()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnreset(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onreset()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnsearch(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onsearch()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsElementOnselectstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onselectstart()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
JSValue jsElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSElement*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -349,6 +806,386 @@ void setJSElementScrollTop(ExecState* exec, JSObject* thisObject, JSValue value)
imp->setScrollTop(value.toInt32(exec));
}
+void setJSElementOnabort(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnabort(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnblur(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnblur(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnchange(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnchange(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnclick(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnclick(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOncontextmenu(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncontextmenu(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndblclick(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndblclick(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndrag(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndrag(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndragend(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragend(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndragenter(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragenter(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndragleave(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragleave(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndragover(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragover(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndragstart(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndragstart(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOndrop(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOndrop(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnerror(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnerror(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnfocus(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnfocus(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOninput(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOninput(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnkeydown(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeydown(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnkeypress(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeypress(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnkeyup(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnkeyup(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnload(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmousedown(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousedown(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmousemove(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousemove(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmouseout(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseout(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmouseover(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseover(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmouseup(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmouseup(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnmousewheel(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmousewheel(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnscroll(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnscroll(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnselect(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnselect(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnsubmit(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnsubmit(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnbeforecut(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforecut(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOncut(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncut(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnbeforecopy(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforecopy(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOncopy(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOncopy(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnbeforepaste(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforepaste(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnpaste(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnpaste(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnreset(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnreset(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnsearch(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnsearch(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSElementOnselectstart(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ Element* imp = static_cast<Element*>(static_cast<JSElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnselectstart(globalObject->createJSAttributeEventListener(value));
+}
+
JSValue JSElement::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSElementConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSElement.h b/src/3rdparty/webkit/WebCore/generated/JSElement.h
index aecee1d..36c81ac 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSElement.h
@@ -21,10 +21,11 @@
#ifndef JSElement_h
#define JSElement_h
+#include "Element.h"
#include "JSNode.h"
#include <runtime/Lookup.h>
#include <wtf/AlwaysInline.h>
-#include "Element.h"
+
namespace WebCore {
class Element;
@@ -132,6 +133,82 @@ JSC::JSValue jsElementLastElementChild(JSC::ExecState*, const JSC::Identifier&,
JSC::JSValue jsElementPreviousElementSibling(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
JSC::JSValue jsElementNextElementSibling(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
JSC::JSValue jsElementChildElementCount(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsElementOnabort(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnabort(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnblur(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnblur(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnchange(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnchange(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOncontextmenu(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOncontextmenu(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndblclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndblclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndrag(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndrag(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndragend(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndragend(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndragenter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndragenter(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndragleave(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndragleave(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndragover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndragover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndragstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndragstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOndrop(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOndrop(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnerror(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnerror(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnfocus(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnfocus(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOninput(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOninput(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnkeydown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnkeydown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnkeypress(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnkeypress(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnkeyup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnkeyup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmousedown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmousedown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmousemove(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmousemove(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmouseout(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmouseout(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmouseover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmouseover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmouseup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmouseup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnmousewheel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnmousewheel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnscroll(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnscroll(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnselect(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnselect(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnsubmit(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnsubmit(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnbeforecut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnbeforecut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOncut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOncut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnbeforecopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnbeforecopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOncopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOncopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnbeforepaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnbeforepaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnpaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnpaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnreset(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnreset(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnsearch(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnsearch(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsElementOnselectstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSElementOnselectstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSEntity.cpp b/src/3rdparty/webkit/WebCore/generated/JSEntity.cpp
index c9f355a..be4eed5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSEntity.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSEntity.cpp
@@ -19,15 +19,11 @@
*/
#include "config.h"
-
#include "JSEntity.h"
-#include <wtf/GetPtr.h>
-
#include "Entity.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSEntityReference.cpp b/src/3rdparty/webkit/WebCore/generated/JSEntityReference.cpp
index 88450e7..dc12c48 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSEntityReference.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSEntityReference.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSEntityReference.h"
-#include <wtf/GetPtr.h>
-
#include "EntityReference.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSEvent.cpp
index fa1feac..f00e179 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSEvent.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSEvent.h"
-#include <wtf/GetPtr.h>
-
#include "Event.h"
#include "EventTarget.h"
#include "JSEventTarget.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSEventException.cpp b/src/3rdparty/webkit/WebCore/generated/JSEventException.cpp
index 38cd551..2adb70a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSEventException.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSEventException.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSEventException.h"
-#include <wtf/GetPtr.h>
-
#include "EventException.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSFile.cpp b/src/3rdparty/webkit/WebCore/generated/JSFile.cpp
index 01c6a2c..d25dfc6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSFile.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSFile.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSFile.h"
-#include <wtf/GetPtr.h>
-
#include "File.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSFileList.cpp b/src/3rdparty/webkit/WebCore/generated/JSFileList.cpp
index 7b84c66..cd165c1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSFileList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSFileList.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSFileList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "ExceptionCode.h"
#include "File.h"
#include "FileList.h"
#include "JSFile.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSGeolocation.cpp b/src/3rdparty/webkit/WebCore/generated/JSGeolocation.cpp
index 928e576..a75348b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSGeolocation.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSGeolocation.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSGeolocation.h"
-#include <wtf/GetPtr.h>
-
#include "Geolocation.h"
#include "Geoposition.h"
#include "JSGeoposition.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSGeoposition.cpp b/src/3rdparty/webkit/WebCore/generated/JSGeoposition.cpp
index 5d13cc6..35399cf 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSGeoposition.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSGeoposition.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSGeoposition.h"
-#include <wtf/GetPtr.h>
-
#include "Coordinates.h"
#include "Geoposition.h"
#include "JSCoordinates.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAnchorElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLAnchorElement.cpp
index 6d2996a..c422551 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAnchorElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAnchorElement.cpp
@@ -19,17 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLAnchorElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLAnchorElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.cpp
index 9742177..787c2c7 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLAppletElement.h"
-#include <wtf/GetPtr.h>
-
#include "AtomicString.h"
#include "HTMLAppletElement.h"
#include "JSHTMLAppletElementCustom.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -141,7 +137,7 @@ bool JSHTMLAppletElement::getOwnPropertySlot(ExecState* exec, const Identifier&
slot.setCustom(this, nameGetter);
return true;
}
- if (customGetOwnPropertySlot(exec, propertyName, slot))
+ if (getOwnPropertySlotDelegate(exec, propertyName, slot))
return true;
return getStaticValueSlot<JSHTMLAppletElement, Base>(exec, &JSHTMLAppletElementTable, this, propertyName, slot);
}
@@ -229,7 +225,7 @@ JSValue jsHTMLAppletElementConstructor(ExecState* exec, const Identifier&, const
}
void JSHTMLAppletElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
lookupPut<JSHTMLAppletElement, Base>(exec, propertyName, value, &JSHTMLAppletElementTable, this, slot);
}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.h
index 754c490..0ebfc7b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAppletElement.h
@@ -34,9 +34,9 @@ public:
JSHTMLAppletElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLAppletElement>);
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAreaElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLAreaElement.cpp
index be38c8d..1d40591 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAreaElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAreaElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLAreaElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLAreaElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.cpp
index b2577a4..00db209 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(VIDEO)
#include "JSHTMLAudioElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLAudioElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.h
index 402fc67..cea0209 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLAudioElement.h
@@ -21,7 +21,6 @@
#ifndef JSHTMLAudioElement_h
#define JSHTMLAudioElement_h
-
#if ENABLE(VIDEO)
#include "JSHTMLMediaElement.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBRElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLBRElement.cpp
index ce47923..aff5b90 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBRElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBRElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLBRElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLBRElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseElement.cpp
index 9867a20..d0c6502 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLBaseElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLBaseElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseFontElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseFontElement.cpp
index aef713e..24288a2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseFontElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBaseFontElement.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLBaseFontElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLBaseFontElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBlockquoteElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLBlockquoteElement.cpp
index 590ebe7..aa108aa 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBlockquoteElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBlockquoteElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLBlockquoteElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLBlockquoteElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.cpp
index 2759643..6da9517 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.cpp
@@ -19,16 +19,16 @@
*/
#include "config.h"
-
#include "JSHTMLBodyElement.h"
-#include <wtf/GetPtr.h>
-
+#include "EventListener.h"
+#include "Frame.h"
#include "HTMLBodyElement.h"
+#include "JSDOMGlobalObject.h"
+#include "JSEventListener.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -38,7 +38,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSHTMLBodyElement);
/* Hash table */
-static const HashTableValue JSHTMLBodyElementTableValues[8] =
+static const HashTableValue JSHTMLBodyElementTableValues[15] =
{
{ "aLink", DontDelete, (intptr_t)jsHTMLBodyElementALink, (intptr_t)setJSHTMLBodyElementALink },
{ "background", DontDelete, (intptr_t)jsHTMLBodyElementBackground, (intptr_t)setJSHTMLBodyElementBackground },
@@ -46,15 +46,22 @@ static const HashTableValue JSHTMLBodyElementTableValues[8] =
{ "link", DontDelete, (intptr_t)jsHTMLBodyElementLink, (intptr_t)setJSHTMLBodyElementLink },
{ "text", DontDelete, (intptr_t)jsHTMLBodyElementText, (intptr_t)setJSHTMLBodyElementText },
{ "vLink", DontDelete, (intptr_t)jsHTMLBodyElementVLink, (intptr_t)setJSHTMLBodyElementVLink },
+ { "onbeforeunload", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnbeforeunload, (intptr_t)setJSHTMLBodyElementOnbeforeunload },
+ { "onmessage", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnmessage, (intptr_t)setJSHTMLBodyElementOnmessage },
+ { "onoffline", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnoffline, (intptr_t)setJSHTMLBodyElementOnoffline },
+ { "ononline", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnonline, (intptr_t)setJSHTMLBodyElementOnonline },
+ { "onresize", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnresize, (intptr_t)setJSHTMLBodyElementOnresize },
+ { "onstorage", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnstorage, (intptr_t)setJSHTMLBodyElementOnstorage },
+ { "onunload", DontDelete|DontEnum, (intptr_t)jsHTMLBodyElementOnunload, (intptr_t)setJSHTMLBodyElementOnunload },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLBodyElementConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
static const HashTable JSHTMLBodyElementTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 31, JSHTMLBodyElementTableValues, 0 };
+ { 63, JSHTMLBodyElementTableValues, 0 };
#else
- { 17, 15, JSHTMLBodyElementTableValues, 0 };
+ { 34, 31, JSHTMLBodyElementTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -175,6 +182,83 @@ JSValue jsHTMLBodyElementVLink(ExecState* exec, const Identifier&, const Propert
return jsString(exec, imp->vLink());
}
+JSValue jsHTMLBodyElementOnbeforeunload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforeunload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnmessage(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmessage()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnoffline(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onoffline()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnonline(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ononline()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnresize(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onresize()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnstorage(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onstorage()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLBodyElementOnunload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onunload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
JSValue jsHTMLBodyElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSHTMLBodyElement*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -220,6 +304,76 @@ void setJSHTMLBodyElementVLink(ExecState* exec, JSObject* thisObject, JSValue va
imp->setVLink(valueToStringWithNullCheck(exec, value));
}
+void setJSHTMLBodyElementOnbeforeunload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforeunload(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnmessage(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmessage(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnoffline(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnoffline(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnonline(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnonline(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnresize(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnresize(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnstorage(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnstorage(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLBodyElementOnunload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLBodyElement* imp = static_cast<HTMLBodyElement*>(static_cast<JSHTMLBodyElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnunload(globalObject->createJSAttributeEventListener(value));
+}
+
JSValue JSHTMLBodyElement::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSHTMLBodyElementConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.h
index b0a635d..caabc5b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLBodyElement.h
@@ -69,6 +69,20 @@ JSC::JSValue jsHTMLBodyElementText(JSC::ExecState*, const JSC::Identifier&, cons
void setJSHTMLBodyElementText(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLBodyElementVLink(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSHTMLBodyElementVLink(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnbeforeunload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnbeforeunload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnmessage(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnmessage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnoffline(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnoffline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnonline(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnonline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnresize(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnresize(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnstorage(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnstorage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLBodyElementOnunload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLBodyElementOnunload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLBodyElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLButtonElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLButtonElement.cpp
index 22a2479..96f463b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLButtonElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLButtonElement.cpp
@@ -19,19 +19,15 @@
*/
#include "config.h"
-
#include "JSHTMLButtonElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLButtonElement.h"
#include "HTMLFormElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLCanvasElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLCanvasElement.cpp
index 82835ed..b90cbea 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLCanvasElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLCanvasElement.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSHTMLCanvasElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLCanvasElement.h"
#include "JSCanvasRenderingContext2D.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.cpp
index 3d2f98a..7ff47ac 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.cpp
@@ -19,12 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLCollection.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "HTMLCollection.h"
#include "JSNode.h"
@@ -32,9 +28,10 @@
#include "NameNodeList.h"
#include "Node.h"
#include "NodeList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.h
index f88b6b4..44d977e 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLCollection.h
@@ -22,9 +22,9 @@
#define JSHTMLCollection_h
#include "JSDOMBinding.h"
+#include <runtime/CallData.h>
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
-#include <runtime/CallData.h>
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDListElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDListElement.cpp
index 1cdc097..e65bb1f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLDListElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDListElement.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSHTMLDListElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLDListElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.cpp
new file mode 100644
index 0000000..e0f8624
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.cpp
@@ -0,0 +1,212 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSHTMLDataGridCellElement.h"
+
+#include "HTMLDataGridCellElement.h"
+#include "KURL.h"
+#include <runtime/JSNumberCell.h>
+#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSHTMLDataGridCellElement);
+
+/* Hash table */
+
+static const HashTableValue JSHTMLDataGridCellElementTableValues[7] =
+{
+ { "label", DontDelete, (intptr_t)jsHTMLDataGridCellElementLabel, (intptr_t)setJSHTMLDataGridCellElementLabel },
+ { "focused", DontDelete, (intptr_t)jsHTMLDataGridCellElementFocused, (intptr_t)setJSHTMLDataGridCellElementFocused },
+ { "checked", DontDelete, (intptr_t)jsHTMLDataGridCellElementChecked, (intptr_t)setJSHTMLDataGridCellElementChecked },
+ { "indeterminate", DontDelete, (intptr_t)jsHTMLDataGridCellElementIndeterminate, (intptr_t)setJSHTMLDataGridCellElementIndeterminate },
+ { "progress", DontDelete, (intptr_t)jsHTMLDataGridCellElementProgress, (intptr_t)setJSHTMLDataGridCellElementProgress },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLDataGridCellElementConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridCellElementTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 63, JSHTMLDataGridCellElementTableValues, 0 };
+#else
+ { 17, 15, JSHTMLDataGridCellElementTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSHTMLDataGridCellElementConstructorTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridCellElementConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridCellElementConstructorTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridCellElementConstructorTableValues, 0 };
+#endif
+
+class JSHTMLDataGridCellElementConstructor : public DOMObject {
+public:
+ JSHTMLDataGridCellElementConstructor(ExecState* exec)
+ : DOMObject(JSHTMLDataGridCellElementConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSHTMLDataGridCellElementPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSHTMLDataGridCellElementConstructor::s_info = { "HTMLDataGridCellElementConstructor", 0, &JSHTMLDataGridCellElementConstructorTable, 0 };
+
+bool JSHTMLDataGridCellElementConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridCellElementConstructor, DOMObject>(exec, &JSHTMLDataGridCellElementConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSHTMLDataGridCellElementPrototypeTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridCellElementPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridCellElementPrototypeTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridCellElementPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSHTMLDataGridCellElementPrototype::s_info = { "HTMLDataGridCellElementPrototype", 0, &JSHTMLDataGridCellElementPrototypeTable, 0 };
+
+JSObject* JSHTMLDataGridCellElementPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSHTMLDataGridCellElement>(exec, globalObject);
+}
+
+const ClassInfo JSHTMLDataGridCellElement::s_info = { "HTMLDataGridCellElement", &JSHTMLElement::s_info, &JSHTMLDataGridCellElementTable, 0 };
+
+JSHTMLDataGridCellElement::JSHTMLDataGridCellElement(PassRefPtr<Structure> structure, PassRefPtr<HTMLDataGridCellElement> impl)
+ : JSHTMLElement(structure, impl)
+{
+}
+
+JSObject* JSHTMLDataGridCellElement::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSHTMLDataGridCellElementPrototype(JSHTMLDataGridCellElementPrototype::createStructure(JSHTMLElementPrototype::self(exec, globalObject)));
+}
+
+bool JSHTMLDataGridCellElement::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridCellElement, Base>(exec, &JSHTMLDataGridCellElementTable, this, propertyName, slot);
+}
+
+JSValue jsHTMLDataGridCellElementLabel(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->label());
+}
+
+JSValue jsHTMLDataGridCellElementFocused(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->focused());
+}
+
+JSValue jsHTMLDataGridCellElementChecked(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->checked());
+}
+
+JSValue jsHTMLDataGridCellElementIndeterminate(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->indeterminate());
+}
+
+JSValue jsHTMLDataGridCellElementProgress(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->progress());
+}
+
+JSValue jsHTMLDataGridCellElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSHTMLDataGridCellElement*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSHTMLDataGridCellElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ lookupPut<JSHTMLDataGridCellElement, Base>(exec, propertyName, value, &JSHTMLDataGridCellElementTable, this, slot);
+}
+
+void setJSHTMLDataGridCellElementLabel(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(thisObject)->impl());
+ imp->setLabel(value.toString(exec));
+}
+
+void setJSHTMLDataGridCellElementFocused(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(thisObject)->impl());
+ imp->setFocused(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridCellElementChecked(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(thisObject)->impl());
+ imp->setChecked(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridCellElementIndeterminate(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(thisObject)->impl());
+ imp->setIndeterminate(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridCellElementProgress(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridCellElement* imp = static_cast<HTMLDataGridCellElement*>(static_cast<JSHTMLDataGridCellElement*>(thisObject)->impl());
+ imp->setProgress(value.toFloat(exec));
+}
+
+JSValue JSHTMLDataGridCellElement::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSHTMLDataGridCellElementConstructor>(exec);
+}
+
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.h
new file mode 100644
index 0000000..a0b8815
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridCellElement.h
@@ -0,0 +1,74 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#ifndef JSHTMLDataGridCellElement_h
+#define JSHTMLDataGridCellElement_h
+
+#include "JSHTMLElement.h"
+
+namespace WebCore {
+
+class HTMLDataGridCellElement;
+
+class JSHTMLDataGridCellElement : public JSHTMLElement {
+ typedef JSHTMLElement Base;
+public:
+ JSHTMLDataGridCellElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLDataGridCellElement>);
+ static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
+ virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+
+ static JSC::JSValue getConstructor(JSC::ExecState*);
+};
+
+
+class JSHTMLDataGridCellElementPrototype : public JSC::JSObject {
+ typedef JSC::JSObject Base;
+public:
+ static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+ JSHTMLDataGridCellElementPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+};
+
+// Attributes
+
+JSC::JSValue jsHTMLDataGridCellElementLabel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridCellElementLabel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridCellElementFocused(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridCellElementFocused(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridCellElementChecked(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridCellElementChecked(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridCellElementIndeterminate(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridCellElementIndeterminate(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridCellElementProgress(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridCellElementProgress(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridCellElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+
+} // namespace WebCore
+
+#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.cpp
new file mode 100644
index 0000000..a608a1f
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.cpp
@@ -0,0 +1,212 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSHTMLDataGridColElement.h"
+
+#include "HTMLDataGridColElement.h"
+#include "KURL.h"
+#include <runtime/JSNumberCell.h>
+#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSHTMLDataGridColElement);
+
+/* Hash table */
+
+static const HashTableValue JSHTMLDataGridColElementTableValues[7] =
+{
+ { "label", DontDelete, (intptr_t)jsHTMLDataGridColElementLabel, (intptr_t)setJSHTMLDataGridColElementLabel },
+ { "type", DontDelete, (intptr_t)jsHTMLDataGridColElementType, (intptr_t)setJSHTMLDataGridColElementType },
+ { "sortable", DontDelete, (intptr_t)jsHTMLDataGridColElementSortable, (intptr_t)setJSHTMLDataGridColElementSortable },
+ { "sortDirection", DontDelete, (intptr_t)jsHTMLDataGridColElementSortDirection, (intptr_t)setJSHTMLDataGridColElementSortDirection },
+ { "primary", DontDelete, (intptr_t)jsHTMLDataGridColElementPrimary, (intptr_t)setJSHTMLDataGridColElementPrimary },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLDataGridColElementConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridColElementTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 63, JSHTMLDataGridColElementTableValues, 0 };
+#else
+ { 17, 15, JSHTMLDataGridColElementTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSHTMLDataGridColElementConstructorTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridColElementConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridColElementConstructorTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridColElementConstructorTableValues, 0 };
+#endif
+
+class JSHTMLDataGridColElementConstructor : public DOMObject {
+public:
+ JSHTMLDataGridColElementConstructor(ExecState* exec)
+ : DOMObject(JSHTMLDataGridColElementConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSHTMLDataGridColElementPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSHTMLDataGridColElementConstructor::s_info = { "HTMLDataGridColElementConstructor", 0, &JSHTMLDataGridColElementConstructorTable, 0 };
+
+bool JSHTMLDataGridColElementConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridColElementConstructor, DOMObject>(exec, &JSHTMLDataGridColElementConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSHTMLDataGridColElementPrototypeTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridColElementPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridColElementPrototypeTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridColElementPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSHTMLDataGridColElementPrototype::s_info = { "HTMLDataGridColElementPrototype", 0, &JSHTMLDataGridColElementPrototypeTable, 0 };
+
+JSObject* JSHTMLDataGridColElementPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSHTMLDataGridColElement>(exec, globalObject);
+}
+
+const ClassInfo JSHTMLDataGridColElement::s_info = { "HTMLDataGridColElement", &JSHTMLElement::s_info, &JSHTMLDataGridColElementTable, 0 };
+
+JSHTMLDataGridColElement::JSHTMLDataGridColElement(PassRefPtr<Structure> structure, PassRefPtr<HTMLDataGridColElement> impl)
+ : JSHTMLElement(structure, impl)
+{
+}
+
+JSObject* JSHTMLDataGridColElement::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSHTMLDataGridColElementPrototype(JSHTMLDataGridColElementPrototype::createStructure(JSHTMLElementPrototype::self(exec, globalObject)));
+}
+
+bool JSHTMLDataGridColElement::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridColElement, Base>(exec, &JSHTMLDataGridColElementTable, this, propertyName, slot);
+}
+
+JSValue jsHTMLDataGridColElementLabel(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->label());
+}
+
+JSValue jsHTMLDataGridColElementType(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->impl());
+ return jsString(exec, imp->type());
+}
+
+JSValue jsHTMLDataGridColElementSortable(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->sortable());
+}
+
+JSValue jsHTMLDataGridColElementSortDirection(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->impl());
+ return jsNumber(exec, imp->sortDirection());
+}
+
+JSValue jsHTMLDataGridColElementPrimary(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->primary());
+}
+
+JSValue jsHTMLDataGridColElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSHTMLDataGridColElement*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSHTMLDataGridColElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ lookupPut<JSHTMLDataGridColElement, Base>(exec, propertyName, value, &JSHTMLDataGridColElementTable, this, slot);
+}
+
+void setJSHTMLDataGridColElementLabel(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(thisObject)->impl());
+ imp->setLabel(value.toString(exec));
+}
+
+void setJSHTMLDataGridColElementType(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(thisObject)->impl());
+ imp->setType(value.toString(exec));
+}
+
+void setJSHTMLDataGridColElementSortable(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(thisObject)->impl());
+ imp->setSortable(value.toInt32(exec));
+}
+
+void setJSHTMLDataGridColElementSortDirection(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(thisObject)->impl());
+ imp->setSortDirection(value.toInt32(exec));
+}
+
+void setJSHTMLDataGridColElementPrimary(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridColElement* imp = static_cast<HTMLDataGridColElement*>(static_cast<JSHTMLDataGridColElement*>(thisObject)->impl());
+ imp->setPrimary(value.toBoolean(exec));
+}
+
+JSValue JSHTMLDataGridColElement::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSHTMLDataGridColElementConstructor>(exec);
+}
+
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.h
new file mode 100644
index 0000000..24efd48
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridColElement.h
@@ -0,0 +1,74 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#ifndef JSHTMLDataGridColElement_h
+#define JSHTMLDataGridColElement_h
+
+#include "JSHTMLElement.h"
+
+namespace WebCore {
+
+class HTMLDataGridColElement;
+
+class JSHTMLDataGridColElement : public JSHTMLElement {
+ typedef JSHTMLElement Base;
+public:
+ JSHTMLDataGridColElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLDataGridColElement>);
+ static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
+ virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+
+ static JSC::JSValue getConstructor(JSC::ExecState*);
+};
+
+
+class JSHTMLDataGridColElementPrototype : public JSC::JSObject {
+ typedef JSC::JSObject Base;
+public:
+ static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+ JSHTMLDataGridColElementPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+};
+
+// Attributes
+
+JSC::JSValue jsHTMLDataGridColElementLabel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridColElementLabel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridColElementType(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridColElementType(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridColElementSortable(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridColElementSortable(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridColElementSortDirection(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridColElementSortDirection(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridColElementPrimary(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridColElementPrimary(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridColElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+
+} // namespace WebCore
+
+#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.cpp
new file mode 100644
index 0000000..ea4237c
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.cpp
@@ -0,0 +1,202 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSHTMLDataGridElement.h"
+
+#include "DataGridColumnList.h"
+#include "HTMLDataGridElement.h"
+#include "JSDataGridColumnList.h"
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSHTMLDataGridElement);
+
+/* Hash table */
+
+static const HashTableValue JSHTMLDataGridElementTableValues[7] =
+{
+ { "dataSource", DontDelete, (intptr_t)jsHTMLDataGridElementDataSource, (intptr_t)setJSHTMLDataGridElementDataSource },
+ { "columns", DontDelete|ReadOnly, (intptr_t)jsHTMLDataGridElementColumns, (intptr_t)0 },
+ { "autofocus", DontDelete, (intptr_t)jsHTMLDataGridElementAutofocus, (intptr_t)setJSHTMLDataGridElementAutofocus },
+ { "disabled", DontDelete, (intptr_t)jsHTMLDataGridElementDisabled, (intptr_t)setJSHTMLDataGridElementDisabled },
+ { "multiple", DontDelete, (intptr_t)jsHTMLDataGridElementMultiple, (intptr_t)setJSHTMLDataGridElementMultiple },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLDataGridElementConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridElementTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 63, JSHTMLDataGridElementTableValues, 0 };
+#else
+ { 18, 15, JSHTMLDataGridElementTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSHTMLDataGridElementConstructorTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridElementConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridElementConstructorTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridElementConstructorTableValues, 0 };
+#endif
+
+class JSHTMLDataGridElementConstructor : public DOMObject {
+public:
+ JSHTMLDataGridElementConstructor(ExecState* exec)
+ : DOMObject(JSHTMLDataGridElementConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSHTMLDataGridElementPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSHTMLDataGridElementConstructor::s_info = { "HTMLDataGridElementConstructor", 0, &JSHTMLDataGridElementConstructorTable, 0 };
+
+bool JSHTMLDataGridElementConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridElementConstructor, DOMObject>(exec, &JSHTMLDataGridElementConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSHTMLDataGridElementPrototypeTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridElementPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridElementPrototypeTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridElementPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSHTMLDataGridElementPrototype::s_info = { "HTMLDataGridElementPrototype", 0, &JSHTMLDataGridElementPrototypeTable, 0 };
+
+JSObject* JSHTMLDataGridElementPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSHTMLDataGridElement>(exec, globalObject);
+}
+
+const ClassInfo JSHTMLDataGridElement::s_info = { "HTMLDataGridElement", &JSHTMLElement::s_info, &JSHTMLDataGridElementTable, 0 };
+
+JSHTMLDataGridElement::JSHTMLDataGridElement(PassRefPtr<Structure> structure, PassRefPtr<HTMLDataGridElement> impl)
+ : JSHTMLElement(structure, impl)
+{
+}
+
+JSObject* JSHTMLDataGridElement::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSHTMLDataGridElementPrototype(JSHTMLDataGridElementPrototype::createStructure(JSHTMLElementPrototype::self(exec, globalObject)));
+}
+
+bool JSHTMLDataGridElement::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridElement, Base>(exec, &JSHTMLDataGridElementTable, this, propertyName, slot);
+}
+
+JSValue jsHTMLDataGridElementDataSource(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->dataSource(exec);
+}
+
+JSValue jsHTMLDataGridElementColumns(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->impl());
+ return toJS(exec, WTF::getPtr(imp->columns()));
+}
+
+JSValue jsHTMLDataGridElementAutofocus(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->autofocus());
+}
+
+JSValue jsHTMLDataGridElementDisabled(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->disabled());
+}
+
+JSValue jsHTMLDataGridElementMultiple(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->multiple());
+}
+
+JSValue jsHTMLDataGridElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSHTMLDataGridElement*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSHTMLDataGridElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ lookupPut<JSHTMLDataGridElement, Base>(exec, propertyName, value, &JSHTMLDataGridElementTable, this, slot);
+}
+
+void setJSHTMLDataGridElementDataSource(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ static_cast<JSHTMLDataGridElement*>(thisObject)->setDataSource(exec, value);
+}
+
+void setJSHTMLDataGridElementAutofocus(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(thisObject)->impl());
+ imp->setAutofocus(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridElementDisabled(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(thisObject)->impl());
+ imp->setDisabled(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridElementMultiple(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridElement* imp = static_cast<HTMLDataGridElement*>(static_cast<JSHTMLDataGridElement*>(thisObject)->impl());
+ imp->setMultiple(value.toBoolean(exec));
+}
+
+JSValue JSHTMLDataGridElement::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSHTMLDataGridElementConstructor>(exec);
+}
+
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.h
new file mode 100644
index 0000000..ee6c8d8
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridElement.h
@@ -0,0 +1,77 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#ifndef JSHTMLDataGridElement_h
+#define JSHTMLDataGridElement_h
+
+#include "JSHTMLElement.h"
+
+namespace WebCore {
+
+class HTMLDataGridElement;
+
+class JSHTMLDataGridElement : public JSHTMLElement {
+ typedef JSHTMLElement Base;
+public:
+ JSHTMLDataGridElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLDataGridElement>);
+ static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
+ virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+
+ static JSC::JSValue getConstructor(JSC::ExecState*);
+
+ // Custom attributes
+ JSC::JSValue dataSource(JSC::ExecState*) const;
+ void setDataSource(JSC::ExecState*, JSC::JSValue);
+};
+
+
+class JSHTMLDataGridElementPrototype : public JSC::JSObject {
+ typedef JSC::JSObject Base;
+public:
+ static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+ JSHTMLDataGridElementPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+};
+
+// Attributes
+
+JSC::JSValue jsHTMLDataGridElementDataSource(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridElementDataSource(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridElementColumns(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+JSC::JSValue jsHTMLDataGridElementAutofocus(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridElementAutofocus(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridElementDisabled(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridElementDisabled(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridElementMultiple(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridElementMultiple(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+
+} // namespace WebCore
+
+#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.cpp
new file mode 100644
index 0000000..938ff16
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.cpp
@@ -0,0 +1,181 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "config.h"
+#include "JSHTMLDataGridRowElement.h"
+
+#include "HTMLDataGridRowElement.h"
+#include <wtf/GetPtr.h>
+
+using namespace JSC;
+
+namespace WebCore {
+
+ASSERT_CLASS_FITS_IN_CELL(JSHTMLDataGridRowElement);
+
+/* Hash table */
+
+static const HashTableValue JSHTMLDataGridRowElementTableValues[5] =
+{
+ { "selected", DontDelete, (intptr_t)jsHTMLDataGridRowElementSelected, (intptr_t)setJSHTMLDataGridRowElementSelected },
+ { "focused", DontDelete, (intptr_t)jsHTMLDataGridRowElementFocused, (intptr_t)setJSHTMLDataGridRowElementFocused },
+ { "expanded", DontDelete, (intptr_t)jsHTMLDataGridRowElementExpanded, (intptr_t)setJSHTMLDataGridRowElementExpanded },
+ { "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLDataGridRowElementConstructor, (intptr_t)0 },
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridRowElementTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 127, JSHTMLDataGridRowElementTableValues, 0 };
+#else
+ { 10, 7, JSHTMLDataGridRowElementTableValues, 0 };
+#endif
+
+/* Hash table for constructor */
+
+static const HashTableValue JSHTMLDataGridRowElementConstructorTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridRowElementConstructorTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridRowElementConstructorTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridRowElementConstructorTableValues, 0 };
+#endif
+
+class JSHTMLDataGridRowElementConstructor : public DOMObject {
+public:
+ JSHTMLDataGridRowElementConstructor(ExecState* exec)
+ : DOMObject(JSHTMLDataGridRowElementConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
+ {
+ putDirect(exec->propertyNames().prototype, JSHTMLDataGridRowElementPrototype::self(exec, exec->lexicalGlobalObject()), None);
+ }
+ virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
+ virtual const ClassInfo* classInfo() const { return &s_info; }
+ static const ClassInfo s_info;
+
+ static PassRefPtr<Structure> createStructure(JSValue proto)
+ {
+ return Structure::create(proto, TypeInfo(ObjectType, ImplementsHasInstance));
+ }
+};
+
+const ClassInfo JSHTMLDataGridRowElementConstructor::s_info = { "HTMLDataGridRowElementConstructor", 0, &JSHTMLDataGridRowElementConstructorTable, 0 };
+
+bool JSHTMLDataGridRowElementConstructor::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridRowElementConstructor, DOMObject>(exec, &JSHTMLDataGridRowElementConstructorTable, this, propertyName, slot);
+}
+
+/* Hash table for prototype */
+
+static const HashTableValue JSHTMLDataGridRowElementPrototypeTableValues[1] =
+{
+ { 0, 0, 0, 0 }
+};
+
+static const HashTable JSHTMLDataGridRowElementPrototypeTable =
+#if ENABLE(PERFECT_HASH_SIZE)
+ { 0, JSHTMLDataGridRowElementPrototypeTableValues, 0 };
+#else
+ { 1, 0, JSHTMLDataGridRowElementPrototypeTableValues, 0 };
+#endif
+
+const ClassInfo JSHTMLDataGridRowElementPrototype::s_info = { "HTMLDataGridRowElementPrototype", 0, &JSHTMLDataGridRowElementPrototypeTable, 0 };
+
+JSObject* JSHTMLDataGridRowElementPrototype::self(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return getDOMPrototype<JSHTMLDataGridRowElement>(exec, globalObject);
+}
+
+const ClassInfo JSHTMLDataGridRowElement::s_info = { "HTMLDataGridRowElement", &JSHTMLElement::s_info, &JSHTMLDataGridRowElementTable, 0 };
+
+JSHTMLDataGridRowElement::JSHTMLDataGridRowElement(PassRefPtr<Structure> structure, PassRefPtr<HTMLDataGridRowElement> impl)
+ : JSHTMLElement(structure, impl)
+{
+}
+
+JSObject* JSHTMLDataGridRowElement::createPrototype(ExecState* exec, JSGlobalObject* globalObject)
+{
+ return new (exec) JSHTMLDataGridRowElementPrototype(JSHTMLDataGridRowElementPrototype::createStructure(JSHTMLElementPrototype::self(exec, globalObject)));
+}
+
+bool JSHTMLDataGridRowElement::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+{
+ return getStaticValueSlot<JSHTMLDataGridRowElement, Base>(exec, &JSHTMLDataGridRowElementTable, this, propertyName, slot);
+}
+
+JSValue jsHTMLDataGridRowElementSelected(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->selected());
+}
+
+JSValue jsHTMLDataGridRowElementFocused(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->focused());
+}
+
+JSValue jsHTMLDataGridRowElementExpanded(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->expanded());
+}
+
+JSValue jsHTMLDataGridRowElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ return static_cast<JSHTMLDataGridRowElement*>(asObject(slot.slotBase()))->getConstructor(exec);
+}
+void JSHTMLDataGridRowElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
+{
+ lookupPut<JSHTMLDataGridRowElement, Base>(exec, propertyName, value, &JSHTMLDataGridRowElementTable, this, slot);
+}
+
+void setJSHTMLDataGridRowElementSelected(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(thisObject)->impl());
+ imp->setSelected(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridRowElementFocused(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(thisObject)->impl());
+ imp->setFocused(value.toBoolean(exec));
+}
+
+void setJSHTMLDataGridRowElementExpanded(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLDataGridRowElement* imp = static_cast<HTMLDataGridRowElement*>(static_cast<JSHTMLDataGridRowElement*>(thisObject)->impl());
+ imp->setExpanded(value.toBoolean(exec));
+}
+
+JSValue JSHTMLDataGridRowElement::getConstructor(ExecState* exec)
+{
+ return getDOMConstructor<JSHTMLDataGridRowElementConstructor>(exec);
+}
+
+
+}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.h
new file mode 100644
index 0000000..562b5f7
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDataGridRowElement.h
@@ -0,0 +1,70 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#ifndef JSHTMLDataGridRowElement_h
+#define JSHTMLDataGridRowElement_h
+
+#include "JSHTMLElement.h"
+
+namespace WebCore {
+
+class HTMLDataGridRowElement;
+
+class JSHTMLDataGridRowElement : public JSHTMLElement {
+ typedef JSHTMLElement Base;
+public:
+ JSHTMLDataGridRowElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLDataGridRowElement>);
+ static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
+ virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+
+ static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype)
+ {
+ return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
+ }
+
+ static JSC::JSValue getConstructor(JSC::ExecState*);
+};
+
+
+class JSHTMLDataGridRowElementPrototype : public JSC::JSObject {
+ typedef JSC::JSObject Base;
+public:
+ static JSC::JSObject* self(JSC::ExecState*, JSC::JSGlobalObject*);
+ virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
+ static const JSC::ClassInfo s_info;
+ JSHTMLDataGridRowElementPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
+};
+
+// Attributes
+
+JSC::JSValue jsHTMLDataGridRowElementSelected(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridRowElementSelected(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridRowElementFocused(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridRowElementFocused(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridRowElementExpanded(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLDataGridRowElementExpanded(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLDataGridRowElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+
+} // namespace WebCore
+
+#endif
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDirectoryElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDirectoryElement.cpp
index 42e0449..711057b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLDirectoryElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDirectoryElement.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSHTMLDirectoryElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLDirectoryElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDivElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDivElement.cpp
index e731da9..43da933 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLDivElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDivElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLDivElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLDivElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLDocument.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLDocument.cpp
index 9dfbacd..1182aee 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLDocument.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLDocument.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLDocument.h"
-#include <wtf/GetPtr.h>
-
#include "AtomicString.h"
#include "Element.h"
#include "HTMLCollection.h"
@@ -31,10 +28,10 @@
#include "JSElement.h"
#include "JSHTMLCollection.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.cpp
index 6453394..ce77377 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.cpp
@@ -19,21 +19,19 @@
*/
#include "config.h"
-
#include "JSHTMLElement.h"
-#include <wtf/GetPtr.h>
-
#include "Element.h"
#include "HTMLCollection.h"
#include "HTMLElement.h"
+#include "HTMLNames.h"
#include "JSElement.h"
#include "JSHTMLCollection.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -157,35 +155,35 @@ JSValue jsHTMLElementId(ExecState* exec, const Identifier&, const PropertySlot&
{
UNUSED_PARAM(exec);
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->id());
+ return jsString(exec, imp->getAttribute(HTMLNames::idAttr));
}
JSValue jsHTMLElementTitle(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->title());
+ return jsString(exec, imp->getAttribute(HTMLNames::titleAttr));
}
JSValue jsHTMLElementLang(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->lang());
+ return jsString(exec, imp->getAttribute(HTMLNames::langAttr));
}
JSValue jsHTMLElementDir(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->dir());
+ return jsString(exec, imp->getAttribute(HTMLNames::dirAttr));
}
JSValue jsHTMLElementClassName(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->className());
+ return jsString(exec, imp->getAttribute(HTMLNames::classAttr));
}
JSValue jsHTMLElementTabIndex(ExecState* exec, const Identifier&, const PropertySlot& slot)
@@ -256,31 +254,31 @@ void JSHTMLElement::put(ExecState* exec, const Identifier& propertyName, JSValue
void setJSHTMLElementId(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(thisObject)->impl());
- imp->setId(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::idAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLElementTitle(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(thisObject)->impl());
- imp->setTitle(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::titleAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLElementLang(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(thisObject)->impl());
- imp->setLang(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::langAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLElementDir(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(thisObject)->impl());
- imp->setDir(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::dirAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLElementClassName(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLElement* imp = static_cast<HTMLElement*>(static_cast<JSHTMLElement*>(thisObject)->impl());
- imp->setClassName(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::classAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLElementTabIndex(ExecState* exec, JSObject* thisObject, JSValue value)
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.h
index dda203f..d4ca1f3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLElement.h
@@ -21,8 +21,9 @@
#ifndef JSHTMLElement_h
#define JSHTMLElement_h
-#include "JSElement.h"
#include "HTMLElement.h"
+#include "JSElement.h"
+
namespace WebCore {
class HTMLElement;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLElementWrapperFactory.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLElementWrapperFactory.cpp
index 41b7998..7d66f62 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLElementWrapperFactory.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLElementWrapperFactory.cpp
@@ -43,10 +43,14 @@
#include "JSHTMLCanvasElement.h"
#include "JSHTMLTableCaptionElement.h"
#include "JSHTMLTableColElement.h"
+#include "JSHTMLDataGridElement.h"
+#include "JSHTMLDataGridCellElement.h"
+#include "JSHTMLDataGridColElement.h"
#include "JSHTMLModElement.h"
#include "JSHTMLDirectoryElement.h"
#include "JSHTMLDivElement.h"
#include "JSHTMLDListElement.h"
+#include "JSHTMLDataGridRowElement.h"
#include "JSHTMLEmbedElement.h"
#include "JSHTMLFieldSetElement.h"
#include "JSHTMLFontElement.h"
@@ -106,10 +110,14 @@
#include "HTMLCanvasElement.h"
#include "HTMLTableCaptionElement.h"
#include "HTMLTableColElement.h"
+#include "HTMLDataGridElement.h"
+#include "HTMLDataGridCellElement.h"
+#include "HTMLDataGridColElement.h"
#include "HTMLModElement.h"
#include "HTMLDirectoryElement.h"
#include "HTMLDivElement.h"
#include "HTMLDListElement.h"
+#include "HTMLDataGridRowElement.h"
#include "HTMLEmbedElement.h"
#include "HTMLFieldSetElement.h"
#include "HTMLFontElement.h"
@@ -235,6 +243,21 @@ static JSNode* createHTMLTableColElementWrapper(ExecState* exec, PassRefPtr<HTML
return CREATE_DOM_NODE_WRAPPER(exec, HTMLTableColElement, element.get());
}
+static JSNode* createHTMLDataGridElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
+{
+ return CREATE_DOM_NODE_WRAPPER(exec, HTMLDataGridElement, element.get());
+}
+
+static JSNode* createHTMLDataGridCellElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
+{
+ return CREATE_DOM_NODE_WRAPPER(exec, HTMLDataGridCellElement, element.get());
+}
+
+static JSNode* createHTMLDataGridColElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
+{
+ return CREATE_DOM_NODE_WRAPPER(exec, HTMLDataGridColElement, element.get());
+}
+
static JSNode* createHTMLModElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
{
return CREATE_DOM_NODE_WRAPPER(exec, HTMLModElement, element.get());
@@ -255,6 +278,11 @@ static JSNode* createHTMLDListElementWrapper(ExecState* exec, PassRefPtr<HTMLEle
return CREATE_DOM_NODE_WRAPPER(exec, HTMLDListElement, element.get());
}
+static JSNode* createHTMLDataGridRowElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
+{
+ return CREATE_DOM_NODE_WRAPPER(exec, HTMLDataGridRowElement, element.get());
+}
+
static JSNode* createHTMLEmbedElementWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
{
return CREATE_DOM_NODE_WRAPPER(exec, HTMLEmbedElement, element.get());
@@ -498,10 +526,14 @@ JSNode* createJSHTMLWrapper(ExecState* exec, PassRefPtr<HTMLElement> element)
map.set(captionTag.localName().impl(), createHTMLTableCaptionElementWrapper);
map.set(colTag.localName().impl(), createHTMLTableColElementWrapper);
map.set(colgroupTag.localName().impl(), createHTMLTableColElementWrapper);
+ map.set(datagridTag.localName().impl(), createHTMLDataGridElementWrapper);
+ map.set(dcellTag.localName().impl(), createHTMLDataGridCellElementWrapper);
+ map.set(dcolTag.localName().impl(), createHTMLDataGridColElementWrapper);
map.set(delTag.localName().impl(), createHTMLModElementWrapper);
map.set(dirTag.localName().impl(), createHTMLDirectoryElementWrapper);
map.set(divTag.localName().impl(), createHTMLDivElementWrapper);
map.set(dlTag.localName().impl(), createHTMLDListElementWrapper);
+ map.set(drowTag.localName().impl(), createHTMLDataGridRowElementWrapper);
map.set(embedTag.localName().impl(), createHTMLEmbedElementWrapper);
map.set(fieldsetTag.localName().impl(), createHTMLFieldSetElementWrapper);
map.set(fontTag.localName().impl(), createHTMLFontElementWrapper);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.cpp
index ec19e83..107a225 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLEmbedElement.h"
-#include <wtf/GetPtr.h>
-
#include "AtomicString.h"
#include "HTMLEmbedElement.h"
#include "JSDOMBinding.h"
@@ -31,10 +28,9 @@
#include "JSSVGDocument.h"
#include "KURL.h"
#include "SVGDocument.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -146,7 +142,7 @@ bool JSHTMLEmbedElement::getOwnPropertySlot(ExecState* exec, const Identifier& p
slot.setCustom(this, nameGetter);
return true;
}
- if (customGetOwnPropertySlot(exec, propertyName, slot))
+ if (getOwnPropertySlotDelegate(exec, propertyName, slot))
return true;
return getStaticValueSlot<JSHTMLEmbedElement, Base>(exec, &JSHTMLEmbedElementTable, this, propertyName, slot);
}
@@ -199,7 +195,7 @@ JSValue jsHTMLEmbedElementConstructor(ExecState* exec, const Identifier&, const
}
void JSHTMLEmbedElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
lookupPut<JSHTMLEmbedElement, Base>(exec, propertyName, value, &JSHTMLEmbedElementTable, this, slot);
}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.h
index defb587..2538ee3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLEmbedElement.h
@@ -34,9 +34,9 @@ public:
JSHTMLEmbedElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLEmbedElement>);
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFieldSetElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLFieldSetElement.cpp
index c1acb4e..27a1ebb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFieldSetElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFieldSetElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLFieldSetElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFieldSetElement.h"
#include "HTMLFormElement.h"
#include "JSHTMLFormElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFontElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLFontElement.cpp
index 9d9a493..0bff1ee 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFontElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFontElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLFontElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFontElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFormElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLFormElement.cpp
index d172404..de495a5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFormElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFormElement.cpp
@@ -19,21 +19,18 @@
*/
#include "config.h"
-
#include "JSHTMLFormElement.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "HTMLCollection.h"
#include "HTMLFormElement.h"
#include "JSHTMLCollection.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameElement.cpp
index bf6fb63..a5bff3e 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameElement.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLFrameElement.h"
-#include <wtf/GetPtr.h>
-
#include "DOMWindow.h"
#include "Document.h"
#include "HTMLFrameElement.h"
@@ -33,10 +30,10 @@
#include "JSSVGDocument.h"
#include "KURL.h"
#include "SVGDocument.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.cpp
index e53caa6..7abfddd 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.cpp
@@ -19,17 +19,17 @@
*/
#include "config.h"
-
#include "JSHTMLFrameSetElement.h"
-#include <wtf/GetPtr.h>
-
#include "AtomicString.h"
+#include "EventListener.h"
+#include "Frame.h"
#include "HTMLFrameSetElement.h"
+#include "JSDOMGlobalObject.h"
+#include "JSEventListener.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -39,19 +39,26 @@ ASSERT_CLASS_FITS_IN_CELL(JSHTMLFrameSetElement);
/* Hash table */
-static const HashTableValue JSHTMLFrameSetElementTableValues[4] =
+static const HashTableValue JSHTMLFrameSetElementTableValues[11] =
{
{ "cols", DontDelete, (intptr_t)jsHTMLFrameSetElementCols, (intptr_t)setJSHTMLFrameSetElementCols },
{ "rows", DontDelete, (intptr_t)jsHTMLFrameSetElementRows, (intptr_t)setJSHTMLFrameSetElementRows },
+ { "onbeforeunload", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnbeforeunload, (intptr_t)setJSHTMLFrameSetElementOnbeforeunload },
+ { "onmessage", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnmessage, (intptr_t)setJSHTMLFrameSetElementOnmessage },
+ { "onoffline", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnoffline, (intptr_t)setJSHTMLFrameSetElementOnoffline },
+ { "ononline", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnonline, (intptr_t)setJSHTMLFrameSetElementOnonline },
+ { "onresize", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnresize, (intptr_t)setJSHTMLFrameSetElementOnresize },
+ { "onstorage", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnstorage, (intptr_t)setJSHTMLFrameSetElementOnstorage },
+ { "onunload", DontDelete|DontEnum, (intptr_t)jsHTMLFrameSetElementOnunload, (intptr_t)setJSHTMLFrameSetElementOnunload },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLFrameSetElementConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
static const HashTable JSHTMLFrameSetElementTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 7, JSHTMLFrameSetElementTableValues, 0 };
+ { 31, JSHTMLFrameSetElementTableValues, 0 };
#else
- { 8, 7, JSHTMLFrameSetElementTableValues, 0 };
+ { 32, 31, JSHTMLFrameSetElementTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -148,6 +155,83 @@ JSValue jsHTMLFrameSetElementRows(ExecState* exec, const Identifier&, const Prop
return jsString(exec, imp->rows());
}
+JSValue jsHTMLFrameSetElementOnbeforeunload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onbeforeunload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnmessage(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onmessage()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnoffline(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onoffline()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnonline(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->ononline()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnresize(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onresize()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnstorage(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onstorage()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
+JSValue jsHTMLFrameSetElementOnunload(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->impl());
+ if (EventListener* listener = imp->onunload()) {
+ if (JSObject* jsFunction = listener->jsFunction())
+ return jsFunction;
+ }
+ return jsNull();
+}
+
JSValue jsHTMLFrameSetElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSHTMLFrameSetElement*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -169,6 +253,76 @@ void setJSHTMLFrameSetElementRows(ExecState* exec, JSObject* thisObject, JSValue
imp->setRows(valueToStringWithNullCheck(exec, value));
}
+void setJSHTMLFrameSetElementOnbeforeunload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnbeforeunload(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnmessage(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnmessage(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnoffline(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnoffline(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnonline(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnonline(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnresize(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnresize(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnstorage(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnstorage(globalObject->createJSAttributeEventListener(value));
+}
+
+void setJSHTMLFrameSetElementOnunload(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ UNUSED_PARAM(exec);
+ HTMLFrameSetElement* imp = static_cast<HTMLFrameSetElement*>(static_cast<JSHTMLFrameSetElement*>(thisObject)->impl());
+ JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
+ if (!globalObject)
+ return;
+ imp->setOnunload(globalObject->createJSAttributeEventListener(value));
+}
+
JSValue JSHTMLFrameSetElement::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSHTMLFrameSetElementConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.h
index ddf3e50..c4528e5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLFrameSetElement.h
@@ -64,6 +64,20 @@ JSC::JSValue jsHTMLFrameSetElementCols(JSC::ExecState*, const JSC::Identifier&,
void setJSHTMLFrameSetElementCols(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLFrameSetElementRows(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSHTMLFrameSetElementRows(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnbeforeunload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnbeforeunload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnmessage(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnmessage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnoffline(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnoffline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnonline(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnonline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnresize(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnresize(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnstorage(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnstorage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLFrameSetElementOnunload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLFrameSetElementOnunload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLFrameSetElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLHRElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLHRElement.cpp
index 15defbc..8ec45b5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLHRElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLHRElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLHRElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLHRElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadElement.cpp
index 859dfbe..a2ec868 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLHeadElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLHeadElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadingElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadingElement.cpp
index 28fe537..5a5b8b2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadingElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLHeadingElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLHeadingElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLHeadingElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLHtmlElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLHtmlElement.cpp
index 18dc8eb..95ab223 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLHtmlElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLHtmlElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLHtmlElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLHtmlElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLIFrameElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLIFrameElement.cpp
index e60f814..068dfc2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLIFrameElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLIFrameElement.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLIFrameElement.h"
-#include <wtf/GetPtr.h>
-
#include "DOMWindow.h"
#include "Document.h"
#include "HTMLIFrameElement.h"
@@ -33,10 +30,9 @@
#include "JSSVGDocument.h"
#include "KURL.h"
#include "SVGDocument.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLImageElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLImageElement.cpp
index 2d985ee..a0259bb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLImageElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLImageElement.cpp
@@ -19,16 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLImageElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLImageElement.h"
+#include "HTMLNames.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -149,28 +147,28 @@ JSValue jsHTMLImageElementName(ExecState* exec, const Identifier&, const Propert
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->name());
+ return jsString(exec, imp->getAttribute(HTMLNames::nameAttr));
}
JSValue jsHTMLImageElementAlign(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->align());
+ return jsString(exec, imp->getAttribute(HTMLNames::alignAttr));
}
JSValue jsHTMLImageElementAlt(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->alt());
+ return jsString(exec, imp->getAttribute(HTMLNames::altAttr));
}
JSValue jsHTMLImageElementBorder(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->border());
+ return jsString(exec, imp->getAttribute(HTMLNames::borderAttr));
}
JSValue jsHTMLImageElementHeight(ExecState* exec, const Identifier&, const PropertySlot& slot)
@@ -198,21 +196,21 @@ JSValue jsHTMLImageElementLongDesc(ExecState* exec, const Identifier&, const Pro
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->longDesc());
+ return jsString(exec, imp->getURLAttribute(HTMLNames::longdescAttr));
}
JSValue jsHTMLImageElementSrc(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->src());
+ return jsString(exec, imp->getURLAttribute(HTMLNames::srcAttr));
}
JSValue jsHTMLImageElementUseMap(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->useMap());
+ return jsString(exec, imp->getAttribute(HTMLNames::usemapAttr));
}
JSValue jsHTMLImageElementVspace(ExecState* exec, const Identifier&, const PropertySlot& slot)
@@ -240,7 +238,7 @@ JSValue jsHTMLImageElementLowsrc(ExecState* exec, const Identifier&, const Prope
{
UNUSED_PARAM(exec);
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(asObject(slot.slotBase()))->impl());
- return jsString(exec, imp->lowsrc());
+ return jsString(exec, imp->getURLAttribute(HTMLNames::lowsrcAttr));
}
JSValue jsHTMLImageElementNaturalHeight(ExecState* exec, const Identifier&, const PropertySlot& slot)
@@ -283,25 +281,25 @@ void JSHTMLImageElement::put(ExecState* exec, const Identifier& propertyName, JS
void setJSHTMLImageElementName(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setName(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::nameAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementAlign(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setAlign(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::alignAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementAlt(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setAlt(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::altAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementBorder(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setBorder(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::borderAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementHeight(ExecState* exec, JSObject* thisObject, JSValue value)
@@ -325,19 +323,19 @@ void setJSHTMLImageElementIsMap(ExecState* exec, JSObject* thisObject, JSValue v
void setJSHTMLImageElementLongDesc(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setLongDesc(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::longdescAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementSrc(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setSrc(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::srcAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementUseMap(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setUseMap(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::usemapAttr, valueToStringWithNullCheck(exec, value));
}
void setJSHTMLImageElementVspace(ExecState* exec, JSObject* thisObject, JSValue value)
@@ -355,7 +353,7 @@ void setJSHTMLImageElementWidth(ExecState* exec, JSObject* thisObject, JSValue v
void setJSHTMLImageElementLowsrc(ExecState* exec, JSObject* thisObject, JSValue value)
{
HTMLImageElement* imp = static_cast<HTMLImageElement*>(static_cast<JSHTMLImageElement*>(thisObject)->impl());
- imp->setLowsrc(valueToStringWithNullCheck(exec, value));
+ imp->setAttribute(HTMLNames::lowsrcAttr, valueToStringWithNullCheck(exec, value));
}
JSValue JSHTMLImageElement::getConstructor(ExecState* exec)
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLInputElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLInputElement.cpp
index 5b241b3..720249a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLInputElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLInputElement.cpp
@@ -19,21 +19,18 @@
*/
#include "config.h"
-
#include "JSHTMLInputElement.h"
-#include <wtf/GetPtr.h>
-
#include "FileList.h"
#include "HTMLFormElement.h"
#include "HTMLInputElement.h"
#include "JSFileList.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLIsIndexElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLIsIndexElement.cpp
index f8dee4f..d23f3f1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLIsIndexElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLIsIndexElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLIsIndexElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFormElement.h"
#include "HTMLIsIndexElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLLIElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLLIElement.cpp
index 8d3a2b8..35f00d2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLLIElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLLIElement.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLLIElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLLIElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLLabelElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLLabelElement.cpp
index 90a93b3..24d1f57 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLLabelElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLLabelElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLLabelElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFormElement.h"
#include "HTMLLabelElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLLegendElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLLegendElement.cpp
index 73dcc8a..b52f3e9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLLegendElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLLegendElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLLegendElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFormElement.h"
#include "HTMLLegendElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLLinkElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLLinkElement.cpp
index 237769d..c40004e 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLLinkElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLLinkElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLLinkElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLLinkElement.h"
#include "JSStyleSheet.h"
#include "KURL.h"
#include "StyleSheet.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMapElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLMapElement.cpp
index 9fa0d2f..458c3f1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMapElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMapElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLMapElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLCollection.h"
#include "HTMLMapElement.h"
#include "JSHTMLCollection.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMarqueeElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLMarqueeElement.cpp
index faa05e0..90f090f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMarqueeElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMarqueeElement.cpp
@@ -19,15 +19,11 @@
*/
#include "config.h"
-
#include "JSHTMLMarqueeElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLMarqueeElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.cpp
index 5f435f7..1f04d40 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.cpp
@@ -20,23 +20,20 @@
#include "config.h"
-
#if ENABLE(VIDEO)
#include "JSHTMLMediaElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLMediaElement.h"
#include "JSMediaError.h"
#include "JSTimeRanges.h"
#include "KURL.h"
#include "MediaError.h"
#include "TimeRanges.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -46,7 +43,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSHTMLMediaElement);
/* Hash table */
-static const HashTableValue JSHTMLMediaElementTableValues[24] =
+static const HashTableValue JSHTMLMediaElementTableValues[25] =
{
{ "error", DontDelete|ReadOnly, (intptr_t)jsHTMLMediaElementError, (intptr_t)0 },
{ "src", DontDelete, (intptr_t)jsHTMLMediaElementSrc, (intptr_t)setJSHTMLMediaElementSrc },
@@ -70,6 +67,7 @@ static const HashTableValue JSHTMLMediaElementTableValues[24] =
{ "controls", DontDelete, (intptr_t)jsHTMLMediaElementControls, (intptr_t)setJSHTMLMediaElementControls },
{ "volume", DontDelete, (intptr_t)jsHTMLMediaElementVolume, (intptr_t)setJSHTMLMediaElementVolume },
{ "muted", DontDelete, (intptr_t)jsHTMLMediaElementMuted, (intptr_t)setJSHTMLMediaElementMuted },
+ { "webkitPreservesPitch", DontDelete, (intptr_t)jsHTMLMediaElementWebkitPreservesPitch, (intptr_t)setJSHTMLMediaElementWebkitPreservesPitch },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsHTMLMediaElementConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
@@ -78,7 +76,7 @@ static const HashTable JSHTMLMediaElementTable =
#if ENABLE(PERFECT_HASH_SIZE)
{ 1023, JSHTMLMediaElementTableValues, 0 };
#else
- { 67, 63, JSHTMLMediaElementTableValues, 0 };
+ { 68, 63, JSHTMLMediaElementTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -340,6 +338,13 @@ JSValue jsHTMLMediaElementMuted(ExecState* exec, const Identifier&, const Proper
return jsBoolean(imp->muted());
}
+JSValue jsHTMLMediaElementWebkitPreservesPitch(ExecState* exec, const Identifier&, const PropertySlot& slot)
+{
+ UNUSED_PARAM(exec);
+ HTMLMediaElement* imp = static_cast<HTMLMediaElement*>(static_cast<JSHTMLMediaElement*>(asObject(slot.slotBase()))->impl());
+ return jsBoolean(imp->webkitPreservesPitch());
+}
+
JSValue jsHTMLMediaElementConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSHTMLMediaElement*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -413,6 +418,12 @@ void setJSHTMLMediaElementMuted(ExecState* exec, JSObject* thisObject, JSValue v
imp->setMuted(value.toBoolean(exec));
}
+void setJSHTMLMediaElementWebkitPreservesPitch(ExecState* exec, JSObject* thisObject, JSValue value)
+{
+ HTMLMediaElement* imp = static_cast<HTMLMediaElement*>(static_cast<JSHTMLMediaElement*>(thisObject)->impl());
+ imp->setWebkitPreservesPitch(value.toBoolean(exec));
+}
+
JSValue JSHTMLMediaElement::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSHTMLMediaElementConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.h
index 6ba7694..c0fb829 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMediaElement.h
@@ -21,7 +21,6 @@
#ifndef JSHTMLMediaElement_h
#define JSHTMLMediaElement_h
-
#if ENABLE(VIDEO)
#include "JSHTMLElement.h"
@@ -103,6 +102,8 @@ JSC::JSValue jsHTMLMediaElementVolume(JSC::ExecState*, const JSC::Identifier&, c
void setJSHTMLMediaElementVolume(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLMediaElementMuted(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSHTMLMediaElementMuted(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
+JSC::JSValue jsHTMLMediaElementWebkitPreservesPitch(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
+void setJSHTMLMediaElementWebkitPreservesPitch(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsHTMLMediaElementConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
// Constants
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMenuElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLMenuElement.cpp
index f0ef5a0..35ce014 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMenuElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMenuElement.cpp
@@ -19,14 +19,10 @@
*/
#include "config.h"
-
#include "JSHTMLMenuElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLMenuElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLMetaElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLMetaElement.cpp
index 26c4ed5..213c2bf 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLMetaElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLMetaElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLMetaElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLMetaElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLModElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLModElement.cpp
index 7eff2e3..b55516c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLModElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLModElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLModElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLModElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOListElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLOListElement.cpp
index 1f43d6d..70fe0b4 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOListElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOListElement.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLOListElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLOListElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.cpp
index e7e4129..c50e27a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLObjectElement.h"
-#include <wtf/GetPtr.h>
-
#include "AtomicString.h"
#include "Document.h"
#include "HTMLFormElement.h"
@@ -35,10 +32,10 @@
#include "JSSVGDocument.h"
#include "KURL.h"
#include "SVGDocument.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -162,7 +159,7 @@ bool JSHTMLObjectElement::getOwnPropertySlot(ExecState* exec, const Identifier&
slot.setCustom(this, nameGetter);
return true;
}
- if (customGetOwnPropertySlot(exec, propertyName, slot))
+ if (getOwnPropertySlotDelegate(exec, propertyName, slot))
return true;
return getStaticValueSlot<JSHTMLObjectElement, Base>(exec, &JSHTMLObjectElementTable, this, propertyName, slot);
}
@@ -298,7 +295,7 @@ JSValue jsHTMLObjectElementConstructor(ExecState* exec, const Identifier&, const
}
void JSHTMLObjectElement::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
lookupPut<JSHTMLObjectElement, Base>(exec, propertyName, value, &JSHTMLObjectElementTable, this, slot);
}
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.h
index 50a9b27..5e9d01c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLObjectElement.h
@@ -34,9 +34,9 @@ public:
JSHTMLObjectElement(PassRefPtr<JSC::Structure>, PassRefPtr<HTMLObjectElement>);
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptGroupElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptGroupElement.cpp
index 10abc77..69506b0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptGroupElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptGroupElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLOptGroupElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLOptGroupElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.cpp
index 7d5bfae..ee1283d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSHTMLOptionElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFormElement.h"
#include "HTMLOptionElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.h
index 9472282..d9bd338 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionElement.h
@@ -21,8 +21,9 @@
#ifndef JSHTMLOptionElement_h
#define JSHTMLOptionElement_h
-#include "JSHTMLElement.h"
#include "HTMLOptionElement.h"
+#include "JSHTMLElement.h"
+
namespace WebCore {
class HTMLOptionElement;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.cpp
index 3229229..578ab90 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLOptionsCollection.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLOptionsCollection.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.h
index d2aa15e..40d89f6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLOptionsCollection.h
@@ -21,8 +21,9 @@
#ifndef JSHTMLOptionsCollection_h
#define JSHTMLOptionsCollection_h
-#include "JSHTMLCollection.h"
#include "HTMLOptionsCollection.h"
+#include "JSHTMLCollection.h"
+
namespace WebCore {
class HTMLOptionsCollection;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLParagraphElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLParagraphElement.cpp
index 0d745de..ba47a53 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLParagraphElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLParagraphElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLParagraphElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLParagraphElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLParamElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLParamElement.cpp
index 8f7248d..b4c9348 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLParamElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLParamElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLParamElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLParamElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLPreElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLPreElement.cpp
index 0387798..8aac7c1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLPreElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLPreElement.cpp
@@ -19,14 +19,11 @@
*/
#include "config.h"
-
#include "JSHTMLPreElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLPreElement.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLQuoteElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLQuoteElement.cpp
index 4eede33..dd831c0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLQuoteElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLQuoteElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLQuoteElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLQuoteElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLScriptElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLScriptElement.cpp
index a3174e4..ab7bc3d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLScriptElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLScriptElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLScriptElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLScriptElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLSelectElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLSelectElement.cpp
index aa8d776..8a61381 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLSelectElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLSelectElement.cpp
@@ -19,12 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLSelectElement.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "ExceptionCode.h"
#include "HTMLFormElement.h"
#include "HTMLOptionsCollection.h"
@@ -35,10 +31,11 @@
#include "JSNode.h"
#include "KURL.h"
#include "Node.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.cpp
index 1a6c7fc..b9f65ad 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.cpp
@@ -20,18 +20,14 @@
#include "config.h"
-
#if ENABLE(VIDEO)
#include "JSHTMLSourceElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLSourceElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.h
index 96b5168..18ece59 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLSourceElement.h
@@ -21,7 +21,6 @@
#ifndef JSHTMLSourceElement_h
#define JSHTMLSourceElement_h
-
#if ENABLE(VIDEO)
#include "JSHTMLElement.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLStyleElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLStyleElement.cpp
index c96ae68..5b31c04 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLStyleElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLStyleElement.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSHTMLStyleElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLStyleElement.h"
#include "JSStyleSheet.h"
#include "KURL.h"
#include "StyleSheet.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.cpp
index 3cc6dba..51b8dbe 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLTableCaptionElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLTableCaptionElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.h
index 5182e84..bc37fd4 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCaptionElement.h
@@ -21,8 +21,9 @@
#ifndef JSHTMLTableCaptionElement_h
#define JSHTMLTableCaptionElement_h
-#include "JSHTMLElement.h"
#include "HTMLTableCaptionElement.h"
+#include "JSHTMLElement.h"
+
namespace WebCore {
class HTMLTableCaptionElement;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCellElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCellElement.cpp
index 0609f0d..cb81f6d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCellElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableCellElement.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLTableCellElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLTableCellElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableColElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableColElement.cpp
index 9e4996c..470cd02 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableColElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableColElement.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHTMLTableColElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLTableColElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableElement.cpp
index 13e9d57..96b92e0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableElement.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSHTMLTableElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLCollection.h"
#include "HTMLElement.h"
#include "HTMLTableCaptionElement.h"
@@ -34,10 +31,9 @@
#include "JSHTMLTableCaptionElement.h"
#include "JSHTMLTableSectionElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableRowElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableRowElement.cpp
index d6f1d8f..c384613 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableRowElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableRowElement.cpp
@@ -19,21 +19,18 @@
*/
#include "config.h"
-
#include "JSHTMLTableRowElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLCollection.h"
#include "HTMLElement.h"
#include "HTMLTableRowElement.h"
#include "JSHTMLCollection.h"
#include "JSHTMLElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.cpp
index ddb9e2e..8e8ce54 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.cpp
@@ -19,21 +19,17 @@
*/
#include "config.h"
-
#include "JSHTMLTableSectionElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLCollection.h"
#include "HTMLElement.h"
#include "HTMLTableSectionElement.h"
#include "JSHTMLCollection.h"
#include "JSHTMLElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.h
index 1d3b1f8..672165f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTableSectionElement.h
@@ -21,8 +21,9 @@
#ifndef JSHTMLTableSectionElement_h
#define JSHTMLTableSectionElement_h
-#include "JSHTMLElement.h"
#include "HTMLTableSectionElement.h"
+#include "JSHTMLElement.h"
+
namespace WebCore {
class HTMLTableSectionElement;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTextAreaElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTextAreaElement.cpp
index 650aaad..6d845f9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTextAreaElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTextAreaElement.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSHTMLTextAreaElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLFormElement.h"
#include "HTMLTextAreaElement.h"
#include "JSHTMLFormElement.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLTitleElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLTitleElement.cpp
index 2834552..82a61ad 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLTitleElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLTitleElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLTitleElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLTitleElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLUListElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLUListElement.cpp
index d33549a..522ff7f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLUListElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLUListElement.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSHTMLUListElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLUListElement.h"
#include "KURL.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.cpp
index e345647..c097281 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.cpp
@@ -20,18 +20,15 @@
#include "config.h"
-
#if ENABLE(VIDEO)
#include "JSHTMLVideoElement.h"
-#include <wtf/GetPtr.h>
-
#include "HTMLVideoElement.h"
#include "KURL.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.h b/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.h
index 9d7577f..3e3b8c2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHTMLVideoElement.h
@@ -21,7 +21,6 @@
#ifndef JSHTMLVideoElement_h
#define JSHTMLVideoElement_h
-
#if ENABLE(VIDEO)
#include "JSHTMLMediaElement.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHistory.cpp b/src/3rdparty/webkit/WebCore/generated/JSHistory.cpp
index 015482f..55e22af 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHistory.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSHistory.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSHistory.h"
-#include <wtf/GetPtr.h>
-
#include "History.h"
#include "JSHistoryCustom.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -100,7 +97,7 @@ JSObject* JSHistory::createPrototype(ExecState* exec, JSGlobalObject* globalObje
bool JSHistory::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
- if (customGetOwnPropertySlot(exec, propertyName, slot))
+ if (getOwnPropertySlotDelegate(exec, propertyName, slot))
return true;
return getStaticValueSlot<JSHistory, Base>(exec, &JSHistoryTable, this, propertyName, slot);
}
@@ -114,18 +111,11 @@ JSValue jsHistoryLength(ExecState* exec, const Identifier&, const PropertySlot&
void JSHistory::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
Base::put(exec, propertyName, value, slot);
}
-void JSHistory::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
-{
- if (customGetPropertyNames(exec, propertyNames))
- return;
- Base::getPropertyNames(exec, propertyNames);
-}
-
JSValue JSC_HOST_CALL jsHistoryPrototypeFunctionBack(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
{
UNUSED_PARAM(args);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSHistory.h b/src/3rdparty/webkit/WebCore/generated/JSHistory.h
index f10e463..e81255a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSHistory.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSHistory.h
@@ -36,9 +36,9 @@ public:
virtual ~JSHistory();
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
@@ -49,7 +49,6 @@ public:
virtual bool deleteProperty(JSC::ExecState*, const JSC::Identifier&);
virtual void getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
- bool customGetPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
History* impl() const { return m_impl.get(); }
private:
diff --git a/src/3rdparty/webkit/WebCore/generated/JSImageData.cpp b/src/3rdparty/webkit/WebCore/generated/JSImageData.cpp
index 17bd1fb..a965375 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSImageData.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSImageData.cpp
@@ -19,14 +19,11 @@
*/
#include "config.h"
-
#include "JSImageData.h"
-#include <wtf/GetPtr.h>
-
#include "ImageData.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSInspectorController.cpp b/src/3rdparty/webkit/WebCore/generated/JSInspectorController.cpp
index 41cafef..a0dac40 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSInspectorController.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSInspectorController.cpp
@@ -19,20 +19,16 @@
*/
#include "config.h"
-
#include "JSInspectorController.h"
-#include <wtf/GetPtr.h>
-
#include "DOMWindow.h"
#include "InspectorController.h"
#include "JSNode.h"
#include "KURL.h"
#include "Node.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -731,7 +727,7 @@ JSValue JSC_HOST_CALL jsInspectorControllerPrototypeFunctionAddBreakpoint(ExecSt
return throwError(exec, TypeError);
JSInspectorController* castedThisObj = static_cast<JSInspectorController*>(asObject(thisValue));
InspectorController* imp = static_cast<InspectorController*>(castedThisObj->impl());
- unsigned sourceID = args.at(0).toInt32(exec);
+ const UString& sourceID = args.at(0).toString(exec);
unsigned lineNumber = args.at(1).toInt32(exec);
imp->addBreakpoint(sourceID, lineNumber);
@@ -745,7 +741,7 @@ JSValue JSC_HOST_CALL jsInspectorControllerPrototypeFunctionRemoveBreakpoint(Exe
return throwError(exec, TypeError);
JSInspectorController* castedThisObj = static_cast<JSInspectorController*>(asObject(thisValue));
InspectorController* imp = static_cast<InspectorController*>(castedThisObj->impl());
- unsigned sourceID = args.at(0).toInt32(exec);
+ const UString& sourceID = args.at(0).toString(exec);
unsigned lineNumber = args.at(1).toInt32(exec);
imp->removeBreakpoint(sourceID, lineNumber);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.cpp b/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.cpp
index 924753a..c8a3f3d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.cpp
@@ -20,20 +20,17 @@
#include "config.h"
-
#if ENABLE(JAVASCRIPT_DEBUGGER)
#include "JSJavaScriptCallFrame.h"
-#include <wtf/GetPtr.h>
-
#include "JSJavaScriptCallFrame.h"
#include "JavaScriptCallFrame.h"
#include "KURL.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.h b/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.h
index 12a5810..166ee60 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSJavaScriptCallFrame.h
@@ -21,7 +21,6 @@
#ifndef JSJavaScriptCallFrame_h
#define JSJavaScriptCallFrame_h
-
#if ENABLE(JAVASCRIPT_DEBUGGER)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSKeyboardEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSKeyboardEvent.cpp
index 107023b..750d1be 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSKeyboardEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSKeyboardEvent.cpp
@@ -19,18 +19,15 @@
*/
#include "config.h"
-
#include "JSKeyboardEvent.h"
-#include <wtf/GetPtr.h>
-
#include "JSDOMWindow.h"
#include "KURL.h"
#include "KeyboardEvent.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSLocation.cpp b/src/3rdparty/webkit/WebCore/generated/JSLocation.cpp
index 2f09ac8..a1c76be 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSLocation.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSLocation.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSLocation.h"
-#include <wtf/GetPtr.h>
-
#include "JSLocationCustom.h"
#include "KURL.h"
#include "Location.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -91,7 +88,7 @@ bool JSLocationPrototype::getOwnPropertySlot(ExecState* exec, const Identifier&
void JSLocationPrototype::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
Base::put(exec, propertyName, value, slot);
}
@@ -116,7 +113,7 @@ JSObject* JSLocation::createPrototype(ExecState* exec, JSGlobalObject* globalObj
bool JSLocation::getOwnPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
- if (customGetOwnPropertySlot(exec, propertyName, slot))
+ if (getOwnPropertySlotDelegate(exec, propertyName, slot))
return true;
return getStaticValueSlot<JSLocation, Base>(exec, &JSLocationTable, this, propertyName, slot);
}
@@ -179,7 +176,7 @@ JSValue jsLocationHash(ExecState* exec, const Identifier&, const PropertySlot& s
void JSLocation::put(ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
- if (customPut(exec, propertyName, value, slot))
+ if (putDelegate(exec, propertyName, value, slot))
return;
lookupPut<JSLocation, Base>(exec, propertyName, value, &JSLocationTable, this, slot);
}
@@ -224,13 +221,6 @@ void setJSLocationHash(ExecState* exec, JSObject* thisObject, JSValue value)
static_cast<JSLocation*>(thisObject)->setHash(exec, value);
}
-void JSLocation::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
-{
- if (customGetPropertyNames(exec, propertyNames))
- return;
- Base::getPropertyNames(exec, propertyNames);
-}
-
JSValue JSC_HOST_CALL jsLocationPrototypeFunctionAssign(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
{
UNUSED_PARAM(args);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSLocation.h b/src/3rdparty/webkit/WebCore/generated/JSLocation.h
index 7d83575..81cb7a3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSLocation.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSLocation.h
@@ -36,9 +36,9 @@ public:
virtual ~JSLocation();
static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);
virtual bool getOwnPropertySlot(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);
- bool customGetOwnPropertySlot(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
+ bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual const JSC::ClassInfo* classInfo() const { return &s_info; }
static const JSC::ClassInfo s_info;
@@ -49,7 +49,6 @@ public:
virtual bool deleteProperty(JSC::ExecState*, const JSC::Identifier&);
virtual void getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
- bool customGetPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&);
virtual void defineGetter(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSObject* getterFunction);
// Custom attributes
@@ -88,7 +87,7 @@ public:
return JSC::Structure::create(prototype, JSC::TypeInfo(JSC::ObjectType));
}
virtual void put(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);
- bool customPut(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
+ bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);
virtual void defineGetter(JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSObject* getterFunction);
JSLocationPrototype(PassRefPtr<JSC::Structure> structure) : JSC::JSObject(structure) { }
};
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMediaError.cpp b/src/3rdparty/webkit/WebCore/generated/JSMediaError.cpp
index 107d706..490e06c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMediaError.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMediaError.cpp
@@ -20,16 +20,13 @@
#include "config.h"
-
#if ENABLE(VIDEO)
#include "JSMediaError.h"
-#include <wtf/GetPtr.h>
-
#include "MediaError.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMediaError.h b/src/3rdparty/webkit/WebCore/generated/JSMediaError.h
index eab4bf7..54f58a7 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMediaError.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSMediaError.h
@@ -21,7 +21,6 @@
#ifndef JSMediaError_h
#define JSMediaError_h
-
#if ENABLE(VIDEO)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMediaList.cpp b/src/3rdparty/webkit/WebCore/generated/JSMediaList.cpp
index 84effe0..4a517c8f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMediaList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMediaList.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSMediaList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "KURL.h"
#include "MediaList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMessageChannel.cpp b/src/3rdparty/webkit/WebCore/generated/JSMessageChannel.cpp
index 47dfef6..8f660f2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMessageChannel.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMessageChannel.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSMessageChannel.h"
-#include <wtf/GetPtr.h>
-
#include "JSMessagePort.h"
#include "MessageChannel.h"
#include "MessagePort.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMessageEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSMessageEvent.cpp
index b49fd94..e95dd9c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMessageEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMessageEvent.cpp
@@ -19,21 +19,17 @@
*/
#include "config.h"
-
#include "JSMessageEvent.h"
-#include <wtf/GetPtr.h>
-
#include "DOMWindow.h"
#include "JSDOMWindow.h"
#include "JSMessagePort.h"
#include "KURL.h"
#include "MessageEvent.h"
#include "MessagePort.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMessagePort.cpp b/src/3rdparty/webkit/WebCore/generated/JSMessagePort.cpp
index 5f9eb5e..7cb75b2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMessagePort.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMessagePort.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSMessagePort.h"
-#include <wtf/GetPtr.h>
-
#include "Event.h"
#include "EventListener.h"
#include "Frame.h"
@@ -33,9 +30,8 @@
#include "JSMessagePort.h"
#include "MessagePort.h"
#include "PlatformString.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -45,20 +41,18 @@ ASSERT_CLASS_FITS_IN_CELL(JSMessagePort);
/* Hash table */
-static const HashTableValue JSMessagePortTableValues[5] =
+static const HashTableValue JSMessagePortTableValues[3] =
{
- { "active", DontDelete|ReadOnly, (intptr_t)jsMessagePortActive, (intptr_t)0 },
{ "onmessage", DontDelete, (intptr_t)jsMessagePortOnmessage, (intptr_t)setJSMessagePortOnmessage },
- { "onclose", DontDelete, (intptr_t)jsMessagePortOnclose, (intptr_t)setJSMessagePortOnclose },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsMessagePortConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
static const HashTable JSMessagePortTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 7, JSMessagePortTableValues, 0 };
+ { 1, JSMessagePortTableValues, 0 };
#else
- { 8, 7, JSMessagePortTableValues, 0 };
+ { 4, 3, JSMessagePortTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -101,10 +95,9 @@ bool JSMessagePortConstructor::getOwnPropertySlot(ExecState* exec, const Identif
/* Hash table for prototype */
-static const HashTableValue JSMessagePortPrototypeTableValues[8] =
+static const HashTableValue JSMessagePortPrototypeTableValues[7] =
{
{ "postMessage", DontDelete|Function, (intptr_t)jsMessagePortPrototypeFunctionPostMessage, (intptr_t)2 },
- { "startConversation", DontDelete|Function, (intptr_t)jsMessagePortPrototypeFunctionStartConversation, (intptr_t)1 },
{ "start", DontDelete|Function, (intptr_t)jsMessagePortPrototypeFunctionStart, (intptr_t)0 },
{ "close", DontDelete|Function, (intptr_t)jsMessagePortPrototypeFunctionClose, (intptr_t)0 },
{ "addEventListener", DontDelete|Function, (intptr_t)jsMessagePortPrototypeFunctionAddEventListener, (intptr_t)3 },
@@ -115,9 +108,9 @@ static const HashTableValue JSMessagePortPrototypeTableValues[8] =
static const HashTable JSMessagePortPrototypeTable =
#if ENABLE(PERFECT_HASH_SIZE)
- { 127, JSMessagePortPrototypeTableValues, 0 };
+ { 31, JSMessagePortPrototypeTableValues, 0 };
#else
- { 18, 15, JSMessagePortPrototypeTableValues, 0 };
+ { 17, 15, JSMessagePortPrototypeTableValues, 0 };
#endif
static const HashTable* getJSMessagePortPrototypeTable(ExecState* exec)
@@ -163,13 +156,6 @@ bool JSMessagePort::getOwnPropertySlot(ExecState* exec, const Identifier& proper
return getStaticValueSlot<JSMessagePort, Base>(exec, getJSMessagePortTable(exec), this, propertyName, slot);
}
-JSValue jsMessagePortActive(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- MessagePort* imp = static_cast<MessagePort*>(static_cast<JSMessagePort*>(asObject(slot.slotBase()))->impl());
- return jsBoolean(imp->active());
-}
-
JSValue jsMessagePortOnmessage(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
UNUSED_PARAM(exec);
@@ -181,17 +167,6 @@ JSValue jsMessagePortOnmessage(ExecState* exec, const Identifier&, const Propert
return jsNull();
}
-JSValue jsMessagePortOnclose(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- MessagePort* imp = static_cast<MessagePort*>(static_cast<JSMessagePort*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onclose()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
JSValue jsMessagePortConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSMessagePort*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -211,16 +186,6 @@ void setJSMessagePortOnmessage(ExecState* exec, JSObject* thisObject, JSValue va
imp->setOnmessage(globalObject->createJSAttributeEventListener(value));
}
-void setJSMessagePortOnclose(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- MessagePort* imp = static_cast<MessagePort*>(static_cast<JSMessagePort*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnclose(globalObject->createJSAttributeEventListener(value));
-}
-
JSValue JSMessagePort::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSMessagePortConstructor>(exec);
@@ -250,15 +215,6 @@ JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionPostMessage(ExecState* exec,
return jsUndefined();
}
-JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionStartConversation(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
-{
- UNUSED_PARAM(args);
- if (!thisValue.isObject(&JSMessagePort::s_info))
- return throwError(exec, TypeError);
- JSMessagePort* castedThisObj = static_cast<JSMessagePort*>(asObject(thisValue));
- return castedThisObj->startConversation(exec, args);
-}
-
JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionStart(ExecState* exec, JSObject*, JSValue thisValue, const ArgList& args)
{
UNUSED_PARAM(args);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMessagePort.h b/src/3rdparty/webkit/WebCore/generated/JSMessagePort.h
index 615d649..1804d8d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMessagePort.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSMessagePort.h
@@ -50,7 +50,6 @@ public:
static JSC::JSValue getConstructor(JSC::ExecState*);
// Custom functions
- JSC::JSValue startConversation(JSC::ExecState*, const JSC::ArgList&);
JSC::JSValue addEventListener(JSC::ExecState*, const JSC::ArgList&);
JSC::JSValue removeEventListener(JSC::ExecState*, const JSC::ArgList&);
MessagePort* impl() const { return m_impl.get(); }
@@ -79,7 +78,6 @@ public:
// Functions
JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionPostMessage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
-JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionStartConversation(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionStart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionClose(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionAddEventListener(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
@@ -87,11 +85,8 @@ JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionRemoveEventListener(JSC
JSC::JSValue JSC_HOST_CALL jsMessagePortPrototypeFunctionDispatchEvent(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&);
// Attributes
-JSC::JSValue jsMessagePortActive(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
JSC::JSValue jsMessagePortOnmessage(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSMessagePortOnmessage(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsMessagePortOnclose(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSMessagePortOnclose(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsMessagePortConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
} // namespace WebCore
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMimeType.cpp b/src/3rdparty/webkit/WebCore/generated/JSMimeType.cpp
index 292543d..09a5dbd 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMimeType.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMimeType.cpp
@@ -19,18 +19,14 @@
*/
#include "config.h"
-
#include "JSMimeType.h"
-#include <wtf/GetPtr.h>
-
#include "JSPlugin.h"
#include "KURL.h"
#include "MimeType.h"
#include "Plugin.h"
-
-#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMimeTypeArray.cpp b/src/3rdparty/webkit/WebCore/generated/JSMimeTypeArray.cpp
index 1a5fdc8..509d6d0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMimeTypeArray.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMimeTypeArray.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSMimeTypeArray.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "JSMimeType.h"
#include "MimeType.h"
#include "MimeTypeArray.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMouseEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSMouseEvent.cpp
index 95001ac..6daf2ab 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMouseEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMouseEvent.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSMouseEvent.h"
-#include <wtf/GetPtr.h>
-
#include "Clipboard.h"
#include "EventTarget.h"
#include "JSClipboard.h"
@@ -32,9 +29,9 @@
#include "JSNode.h"
#include "MouseEvent.h"
#include "Node.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSMutationEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSMutationEvent.cpp
index 5195e75..71d339e 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSMutationEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSMutationEvent.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSMutationEvent.h"
-#include <wtf/GetPtr.h>
-
#include "JSNode.h"
#include "KURL.h"
#include "MutationEvent.h"
#include "Node.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNamedNodeMap.cpp b/src/3rdparty/webkit/WebCore/generated/JSNamedNodeMap.cpp
index c89ba55..9c6a5a9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNamedNodeMap.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNamedNodeMap.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSNamedNodeMap.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "JSNode.h"
#include "NamedNodeMap.h"
#include "Node.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNavigator.cpp b/src/3rdparty/webkit/WebCore/generated/JSNavigator.cpp
index 0d343fb..feefecc 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNavigator.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNavigator.cpp
@@ -19,20 +19,17 @@
*/
#include "config.h"
-
#include "JSNavigator.h"
-#include <wtf/GetPtr.h>
-
#include "JSMimeTypeArray.h"
#include "JSPluginArray.h"
#include "KURL.h"
#include "MimeTypeArray.h"
#include "Navigator.h"
#include "PluginArray.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNode.cpp b/src/3rdparty/webkit/WebCore/generated/JSNode.cpp
index 6cb55ee..fda843c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNode.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNode.cpp
@@ -19,21 +19,14 @@
*/
#include "config.h"
-
#include "JSNode.h"
-#include <wtf/GetPtr.h>
-
#include "Document.h"
#include "Element.h"
#include "Event.h"
-#include "EventListener.h"
-#include "Frame.h"
-#include "JSDOMGlobalObject.h"
#include "JSDocument.h"
#include "JSElement.h"
#include "JSEvent.h"
-#include "JSEventListener.h"
#include "JSNamedNodeMap.h"
#include "JSNode.h"
#include "JSNodeList.h"
@@ -43,9 +36,9 @@
#include "Node.h"
#include "NodeList.h"
#include "RegisteredEventListener.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
@@ -55,7 +48,7 @@ ASSERT_CLASS_FITS_IN_CELL(JSNode);
/* Hash table */
-static const HashTableValue JSNodeTableValues[59] =
+static const HashTableValue JSNodeTableValues[19] =
{
{ "nodeName", DontDelete|ReadOnly, (intptr_t)jsNodeNodeName, (intptr_t)0 },
{ "nodeValue", DontDelete, (intptr_t)jsNodeNodeValue, (intptr_t)setJSNodeNodeValue },
@@ -74,46 +67,6 @@ static const HashTableValue JSNodeTableValues[59] =
{ "baseURI", DontDelete|ReadOnly, (intptr_t)jsNodeBaseURI, (intptr_t)0 },
{ "textContent", DontDelete, (intptr_t)jsNodeTextContent, (intptr_t)setJSNodeTextContent },
{ "parentElement", DontDelete|ReadOnly, (intptr_t)jsNodeParentElement, (intptr_t)0 },
- { "onabort", DontDelete|DontEnum, (intptr_t)jsNodeOnabort, (intptr_t)setJSNodeOnabort },
- { "onblur", DontDelete|DontEnum, (intptr_t)jsNodeOnblur, (intptr_t)setJSNodeOnblur },
- { "onchange", DontDelete|DontEnum, (intptr_t)jsNodeOnchange, (intptr_t)setJSNodeOnchange },
- { "onclick", DontDelete|DontEnum, (intptr_t)jsNodeOnclick, (intptr_t)setJSNodeOnclick },
- { "oncontextmenu", DontDelete|DontEnum, (intptr_t)jsNodeOncontextmenu, (intptr_t)setJSNodeOncontextmenu },
- { "ondblclick", DontDelete|DontEnum, (intptr_t)jsNodeOndblclick, (intptr_t)setJSNodeOndblclick },
- { "onerror", DontDelete|DontEnum, (intptr_t)jsNodeOnerror, (intptr_t)setJSNodeOnerror },
- { "onfocus", DontDelete|DontEnum, (intptr_t)jsNodeOnfocus, (intptr_t)setJSNodeOnfocus },
- { "oninput", DontDelete|DontEnum, (intptr_t)jsNodeOninput, (intptr_t)setJSNodeOninput },
- { "onkeydown", DontDelete|DontEnum, (intptr_t)jsNodeOnkeydown, (intptr_t)setJSNodeOnkeydown },
- { "onkeypress", DontDelete|DontEnum, (intptr_t)jsNodeOnkeypress, (intptr_t)setJSNodeOnkeypress },
- { "onkeyup", DontDelete|DontEnum, (intptr_t)jsNodeOnkeyup, (intptr_t)setJSNodeOnkeyup },
- { "onload", DontDelete|DontEnum, (intptr_t)jsNodeOnload, (intptr_t)setJSNodeOnload },
- { "onmousedown", DontDelete|DontEnum, (intptr_t)jsNodeOnmousedown, (intptr_t)setJSNodeOnmousedown },
- { "onmousemove", DontDelete|DontEnum, (intptr_t)jsNodeOnmousemove, (intptr_t)setJSNodeOnmousemove },
- { "onmouseout", DontDelete|DontEnum, (intptr_t)jsNodeOnmouseout, (intptr_t)setJSNodeOnmouseout },
- { "onmouseover", DontDelete|DontEnum, (intptr_t)jsNodeOnmouseover, (intptr_t)setJSNodeOnmouseover },
- { "onmouseup", DontDelete|DontEnum, (intptr_t)jsNodeOnmouseup, (intptr_t)setJSNodeOnmouseup },
- { "onmousewheel", DontDelete|DontEnum, (intptr_t)jsNodeOnmousewheel, (intptr_t)setJSNodeOnmousewheel },
- { "onbeforecut", DontDelete|DontEnum, (intptr_t)jsNodeOnbeforecut, (intptr_t)setJSNodeOnbeforecut },
- { "oncut", DontDelete|DontEnum, (intptr_t)jsNodeOncut, (intptr_t)setJSNodeOncut },
- { "onbeforecopy", DontDelete|DontEnum, (intptr_t)jsNodeOnbeforecopy, (intptr_t)setJSNodeOnbeforecopy },
- { "oncopy", DontDelete|DontEnum, (intptr_t)jsNodeOncopy, (intptr_t)setJSNodeOncopy },
- { "onbeforepaste", DontDelete|DontEnum, (intptr_t)jsNodeOnbeforepaste, (intptr_t)setJSNodeOnbeforepaste },
- { "onpaste", DontDelete|DontEnum, (intptr_t)jsNodeOnpaste, (intptr_t)setJSNodeOnpaste },
- { "ondragenter", DontDelete|DontEnum, (intptr_t)jsNodeOndragenter, (intptr_t)setJSNodeOndragenter },
- { "ondragover", DontDelete|DontEnum, (intptr_t)jsNodeOndragover, (intptr_t)setJSNodeOndragover },
- { "ondragleave", DontDelete|DontEnum, (intptr_t)jsNodeOndragleave, (intptr_t)setJSNodeOndragleave },
- { "ondrop", DontDelete|DontEnum, (intptr_t)jsNodeOndrop, (intptr_t)setJSNodeOndrop },
- { "ondragstart", DontDelete|DontEnum, (intptr_t)jsNodeOndragstart, (intptr_t)setJSNodeOndragstart },
- { "ondrag", DontDelete|DontEnum, (intptr_t)jsNodeOndrag, (intptr_t)setJSNodeOndrag },
- { "ondragend", DontDelete|DontEnum, (intptr_t)jsNodeOndragend, (intptr_t)setJSNodeOndragend },
- { "onreset", DontDelete|DontEnum, (intptr_t)jsNodeOnreset, (intptr_t)setJSNodeOnreset },
- { "onresize", DontDelete|DontEnum, (intptr_t)jsNodeOnresize, (intptr_t)setJSNodeOnresize },
- { "onscroll", DontDelete|DontEnum, (intptr_t)jsNodeOnscroll, (intptr_t)setJSNodeOnscroll },
- { "onsearch", DontDelete|DontEnum, (intptr_t)jsNodeOnsearch, (intptr_t)setJSNodeOnsearch },
- { "onselect", DontDelete|DontEnum, (intptr_t)jsNodeOnselect, (intptr_t)setJSNodeOnselect },
- { "onselectstart", DontDelete|DontEnum, (intptr_t)jsNodeOnselectstart, (intptr_t)setJSNodeOnselectstart },
- { "onsubmit", DontDelete|DontEnum, (intptr_t)jsNodeOnsubmit, (intptr_t)setJSNodeOnsubmit },
- { "onunload", DontDelete|DontEnum, (intptr_t)jsNodeOnunload, (intptr_t)setJSNodeOnunload },
{ "constructor", DontEnum|ReadOnly, (intptr_t)jsNodeConstructor, (intptr_t)0 },
{ 0, 0, 0, 0 }
};
@@ -122,7 +75,7 @@ static const HashTable JSNodeTable =
#if ENABLE(PERFECT_HASH_SIZE)
{ 4095, JSNodeTableValues, 0 };
#else
- { 140, 127, JSNodeTableValues, 0 };
+ { 68, 63, JSNodeTableValues, 0 };
#endif
/* Hash table for constructor */
@@ -381,446 +334,6 @@ JSValue jsNodeParentElement(ExecState* exec, const Identifier&, const PropertySl
return toJS(exec, WTF::getPtr(imp->parentElement()));
}
-JSValue jsNodeOnabort(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onabort()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnblur(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onblur()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnchange(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onchange()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onclick()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOncontextmenu(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->oncontextmenu()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndblclick(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondblclick()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnerror(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onerror()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnfocus(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onfocus()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOninput(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->oninput()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnkeydown(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onkeydown()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnkeypress(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onkeypress()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnkeyup(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onkeyup()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnload(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onload()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmousedown(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmousedown()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmousemove(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmousemove()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmouseout(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmouseout()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmouseover(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmouseover()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmouseup(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmouseup()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnmousewheel(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onmousewheel()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnbeforecut(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onbeforecut()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOncut(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->oncut()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnbeforecopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onbeforecopy()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOncopy(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->oncopy()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnbeforepaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onbeforepaste()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnpaste(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onpaste()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndragenter(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondragenter()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndragover(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondragover()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndragleave(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondragleave()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndrop(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondrop()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndragstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondragstart()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndrag(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondrag()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOndragend(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->ondragend()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnreset(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onreset()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnresize(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onresize()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnscroll(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onscroll()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnsearch(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onsearch()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnselect(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onselect()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnselectstart(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onselectstart()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnsubmit(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onsubmit()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
-JSValue jsNodeOnunload(ExecState* exec, const Identifier&, const PropertySlot& slot)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(asObject(slot.slotBase()))->impl());
- if (EventListener* listener = imp->onunload()) {
- if (JSObject* jsFunction = listener->jsFunction())
- return jsFunction;
- }
- return jsNull();
-}
-
JSValue jsNodeConstructor(ExecState* exec, const Identifier&, const PropertySlot& slot)
{
return static_cast<JSNode*>(asObject(slot.slotBase()))->getConstructor(exec);
@@ -854,406 +367,6 @@ void setJSNodeTextContent(ExecState* exec, JSObject* thisObject, JSValue value)
setDOMException(exec, ec);
}
-void setJSNodeOnabort(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnabort(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnblur(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnblur(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnchange(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnchange(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnclick(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnclick(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOncontextmenu(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOncontextmenu(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndblclick(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndblclick(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnerror(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnerror(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnfocus(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnfocus(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOninput(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOninput(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnkeydown(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnkeydown(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnkeypress(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnkeypress(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnkeyup(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnkeyup(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnload(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnload(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmousedown(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmousedown(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmousemove(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmousemove(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmouseout(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmouseout(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmouseover(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmouseover(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmouseup(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmouseup(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnmousewheel(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnmousewheel(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnbeforecut(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnbeforecut(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOncut(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOncut(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnbeforecopy(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnbeforecopy(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOncopy(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOncopy(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnbeforepaste(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnbeforepaste(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnpaste(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnpaste(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndragenter(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndragenter(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndragover(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndragover(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndragleave(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndragleave(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndrop(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndrop(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndragstart(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndragstart(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndrag(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndrag(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOndragend(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOndragend(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnreset(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnreset(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnresize(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnresize(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnscroll(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnscroll(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnsearch(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnsearch(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnselect(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnselect(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnselectstart(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnselectstart(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnsubmit(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnsubmit(globalObject->createJSAttributeEventListener(value));
-}
-
-void setJSNodeOnunload(ExecState* exec, JSObject* thisObject, JSValue value)
-{
- UNUSED_PARAM(exec);
- Node* imp = static_cast<Node*>(static_cast<JSNode*>(thisObject)->impl());
- JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(imp->scriptExecutionContext());
- if (!globalObject)
- return;
- imp->setOnunload(globalObject->createJSAttributeEventListener(value));
-}
-
JSValue JSNode::getConstructor(ExecState* exec)
{
return getDOMConstructor<JSNodeConstructor>(exec);
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNode.h b/src/3rdparty/webkit/WebCore/generated/JSNode.h
index fd1f2d0..3fdc5a3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNode.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSNode.h
@@ -23,8 +23,8 @@
#include "JSDOMBinding.h"
#include <runtime/JSGlobalObject.h>
-#include <runtime/ObjectPrototype.h>
#include <runtime/Lookup.h>
+#include <runtime/ObjectPrototype.h>
#include <wtf/AlwaysInline.h>
namespace WebCore {
@@ -131,86 +131,6 @@ JSC::JSValue jsNodeBaseURI(JSC::ExecState*, const JSC::Identifier&, const JSC::P
JSC::JSValue jsNodeTextContent(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
void setJSNodeTextContent(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsNodeParentElement(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-JSC::JSValue jsNodeOnabort(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnabort(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnblur(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnblur(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnchange(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnchange(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOncontextmenu(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOncontextmenu(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndblclick(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndblclick(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnerror(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnerror(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnfocus(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnfocus(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOninput(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOninput(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnkeydown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnkeydown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnkeypress(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnkeypress(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnkeyup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnkeyup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmousedown(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmousedown(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmousemove(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmousemove(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmouseout(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmouseout(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmouseover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmouseover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmouseup(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmouseup(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnmousewheel(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnmousewheel(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnbeforecut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnbeforecut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOncut(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOncut(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnbeforecopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnbeforecopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOncopy(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOncopy(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnbeforepaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnbeforepaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnpaste(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnpaste(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndragenter(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndragenter(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndragover(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndragover(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndragleave(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndragleave(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndrop(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndrop(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndragstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndragstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndrag(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndrag(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOndragend(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOndragend(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnreset(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnreset(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnresize(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnresize(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnscroll(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnscroll(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnsearch(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnsearch(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnselect(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnselect(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnselectstart(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnselectstart(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnsubmit(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnsubmit(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
-JSC::JSValue jsNodeOnunload(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
-void setJSNodeOnunload(JSC::ExecState*, JSC::JSObject*, JSC::JSValue);
JSC::JSValue jsNodeConstructor(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);
// Constants
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNodeFilter.cpp b/src/3rdparty/webkit/WebCore/generated/JSNodeFilter.cpp
index d0eb79f..3084eed 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNodeFilter.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNodeFilter.cpp
@@ -19,15 +19,11 @@
*/
#include "config.h"
-
#include "JSNodeFilter.h"
-#include <wtf/GetPtr.h>
-
#include "NodeFilter.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNodeIterator.cpp b/src/3rdparty/webkit/WebCore/generated/JSNodeIterator.cpp
index 6fe8cc2..152ab6f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNodeIterator.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNodeIterator.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSNodeIterator.h"
-#include <wtf/GetPtr.h>
-
#include "JSNode.h"
#include "JSNodeFilter.h"
#include "Node.h"
#include "NodeFilter.h"
#include "NodeIterator.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNodeList.cpp b/src/3rdparty/webkit/WebCore/generated/JSNodeList.cpp
index b7fa2c5..80e1f22 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNodeList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNodeList.cpp
@@ -19,20 +19,17 @@
*/
#include "config.h"
-
#include "JSNodeList.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "ExceptionCode.h"
#include "JSNode.h"
#include "Node.h"
#include "NodeList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNodeList.h b/src/3rdparty/webkit/WebCore/generated/JSNodeList.h
index 2a64c59..c4fce0b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNodeList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSNodeList.h
@@ -22,9 +22,9 @@
#define JSNodeList_h
#include "JSDOMBinding.h"
+#include <runtime/CallData.h>
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
-#include <runtime/CallData.h>
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSNotation.cpp b/src/3rdparty/webkit/WebCore/generated/JSNotation.cpp
index 5187c8f..95dacaa 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSNotation.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSNotation.cpp
@@ -19,15 +19,11 @@
*/
#include "config.h"
-
#include "JSNotation.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "Notation.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSONObject.lut.h b/src/3rdparty/webkit/WebCore/generated/JSONObject.lut.h
new file mode 100644
index 0000000..9a12bb4
--- /dev/null
+++ b/src/3rdparty/webkit/WebCore/generated/JSONObject.lut.h
@@ -0,0 +1,15 @@
+// Automatically generated from ../../JavaScriptCore/runtime/JSONObject.cpp using JavaScriptCore/create_hash_table. DO NOT EDIT!
+
+#include "Lookup.h"
+
+namespace JSC {
+
+static const struct HashTableValue jsonTableValues[3] = {
+ { "parse", DontEnum|Function, (intptr_t)JSONProtoFuncParse, (intptr_t)1 },
+ { "stringify", DontEnum|Function, (intptr_t)JSONProtoFuncStringify, (intptr_t)1 },
+ { 0, 0, 0, 0 }
+};
+
+extern const struct HashTable jsonTable =
+ { 4, 3, jsonTableValues, 0 };
+} // namespace
diff --git a/src/3rdparty/webkit/WebCore/generated/JSOverflowEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSOverflowEvent.cpp
index 0ae7a26..b704dcb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSOverflowEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSOverflowEvent.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSOverflowEvent.h"
-#include <wtf/GetPtr.h>
-
#include "OverflowEvent.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSPlugin.cpp b/src/3rdparty/webkit/WebCore/generated/JSPlugin.cpp
index 04f24fe..9b3c480 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSPlugin.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSPlugin.cpp
@@ -19,21 +19,18 @@
*/
#include "config.h"
-
#include "JSPlugin.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "JSMimeType.h"
#include "KURL.h"
#include "MimeType.h"
#include "Plugin.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSPluginArray.cpp b/src/3rdparty/webkit/WebCore/generated/JSPluginArray.cpp
index 26b5515..ba960da 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSPluginArray.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSPluginArray.cpp
@@ -19,19 +19,16 @@
*/
#include "config.h"
-
#include "JSPluginArray.h"
-#include <wtf/GetPtr.h>
-
-#include <runtime/PropertyNameArray.h>
#include "AtomicString.h"
#include "JSPlugin.h"
#include "Plugin.h"
#include "PluginArray.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <runtime/PropertyNameArray.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSPositionError.cpp b/src/3rdparty/webkit/WebCore/generated/JSPositionError.cpp
index 7c4896f..89f9e56 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSPositionError.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSPositionError.cpp
@@ -19,16 +19,13 @@
*/
#include "config.h"
-
#include "JSPositionError.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "PositionError.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSProcessingInstruction.cpp b/src/3rdparty/webkit/WebCore/generated/JSProcessingInstruction.cpp
index 56f9b61..7ca8069 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSProcessingInstruction.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSProcessingInstruction.cpp
@@ -19,17 +19,13 @@
*/
#include "config.h"
-
#include "JSProcessingInstruction.h"
-#include <wtf/GetPtr.h>
-
#include "JSStyleSheet.h"
#include "KURL.h"
#include "ProcessingInstruction.h"
#include "StyleSheet.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSProgressEvent.cpp b/src/3rdparty/webkit/WebCore/generated/JSProgressEvent.cpp
index 92d6a68..b70c3c2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSProgressEvent.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSProgressEvent.cpp
@@ -19,15 +19,12 @@
*/
#include "config.h"
-
#include "JSProgressEvent.h"
-#include <wtf/GetPtr.h>
-
#include "ProgressEvent.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSRange.cpp b/src/3rdparty/webkit/WebCore/generated/JSRange.cpp
index a8e828b..901b8f3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSRange.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSRange.cpp
@@ -19,11 +19,8 @@
*/
#include "config.h"
-
#include "JSRange.h"
-#include <wtf/GetPtr.h>
-
#include "DocumentFragment.h"
#include "JSDocumentFragment.h"
#include "JSNode.h"
@@ -31,10 +28,10 @@
#include "KURL.h"
#include "Node.h"
#include "Range.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSRangeException.cpp b/src/3rdparty/webkit/WebCore/generated/JSRangeException.cpp
index faf9794..3cf51ee 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSRangeException.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSRangeException.cpp
@@ -19,17 +19,14 @@
*/
#include "config.h"
-
#include "JSRangeException.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "RangeException.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSRect.cpp b/src/3rdparty/webkit/WebCore/generated/JSRect.cpp
index 3fdee7c..02423ef 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSRect.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSRect.cpp
@@ -19,16 +19,12 @@
*/
#include "config.h"
-
#include "JSRect.h"
-#include <wtf/GetPtr.h>
-
#include "CSSPrimitiveValue.h"
#include "JSCSSPrimitiveValue.h"
#include "Rect.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLError.cpp b/src/3rdparty/webkit/WebCore/generated/JSSQLError.cpp
index 2d6abf1..77cdc74 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLError.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLError.cpp
@@ -20,18 +20,15 @@
#include "config.h"
-
#if ENABLE(DATABASE)
#include "JSSQLError.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "SQLError.h"
-
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLError.h b/src/3rdparty/webkit/WebCore/generated/JSSQLError.h
index a2389c7..d500434f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLError.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLError.h
@@ -21,7 +21,6 @@
#ifndef JSSQLError_h
#define JSSQLError_h
-
#if ENABLE(DATABASE)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.cpp b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.cpp
index 6aa3394..8852997 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.cpp
@@ -20,18 +20,15 @@
#include "config.h"
-
#if ENABLE(DATABASE)
#include "JSSQLResultSet.h"
-#include <wtf/GetPtr.h>
-
#include "JSSQLResultSetRowList.h"
#include "SQLResultSet.h"
#include "SQLResultSetRowList.h"
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.h b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.h
index a708847..d009dad 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSet.h
@@ -21,7 +21,6 @@
#ifndef JSSQLResultSet_h
#define JSSQLResultSet_h
-
#if ENABLE(DATABASE)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.cpp b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.cpp
index 8f60335..daf19f5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.cpp
@@ -20,17 +20,14 @@
#include "config.h"
-
#if ENABLE(DATABASE)
#include "JSSQLResultSetRowList.h"
-#include <wtf/GetPtr.h>
-
#include "SQLResultSetRowList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.h b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.h
index c5b30f7..df28567 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLResultSetRowList.h
@@ -21,7 +21,6 @@
#ifndef JSSQLResultSetRowList_h
#define JSSQLResultSetRowList_h
-
#if ENABLE(DATABASE)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.cpp b/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.cpp
index d65771e..1f086ee 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.cpp
@@ -20,16 +20,13 @@
#include "config.h"
-
#if ENABLE(DATABASE)
#include "JSSQLTransaction.h"
-#include <wtf/GetPtr.h>
-
#include "SQLTransaction.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.h b/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.h
index e0190a8..94c10a5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSQLTransaction.h
@@ -21,7 +21,6 @@
#ifndef JSSQLTransaction_h
#define JSSQLTransaction_h
-
#if ENABLE(DATABASE)
#include "JSDOMBinding.h"
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.cpp
index ee98ed0..3e6d235 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -44,9 +40,9 @@
#include "SVGAElement.h"
#include "SVGElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.h
index 8b3f3da..78406f6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAElement_h
#define JSSVGAElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.cpp
index 81a4c84..89543b1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.cpp
@@ -20,19 +20,15 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(SVG_FONTS)
-#include "SVGElement.h"
#include "JSSVGAltGlyphElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAnimatedString.h"
#include "KURL.h"
#include "SVGAltGlyphElement.h"
-
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.h
index 8498546..f92bdcd 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAltGlyphElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAltGlyphElement_h
#define JSSVGAltGlyphElement_h
-
#if ENABLE(SVG) && ENABLE(SVG_FONTS)
#include "JSSVGTextPositioningElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.cpp
index 190edea..39c7e73 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.cpp
@@ -20,20 +20,16 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAngle.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "SVGAngle.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.h
index 0172d92..5312581 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAngle.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAngle_h
#define JSSVGAngle_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.cpp
index 312836b..cbb2269 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG_ANIMATION)
-#include "SVGElement.h"
#include "JSSVGAnimateColorElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGAnimateColorElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.h
index b2b654a..a1519a4 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateColorElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimateColorElement_h
#define JSSVGAnimateColorElement_h
-
#if ENABLE(SVG_ANIMATION)
#include "JSSVGAnimationElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.cpp
index 9b57d63..77d0331 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(SVG_ANIMATION)
-#include "SVGElement.h"
#include "JSSVGAnimateElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGAnimateElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.h
index 0a8e472..77415d9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimateElement_h
#define JSSVGAnimateElement_h
-
#if ENABLE(SVG) && ENABLE(SVG_ANIMATION)
#include "JSSVGAnimationElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.cpp
index cb789f2..511108f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(SVG_ANIMATION)
-#include "SVGElement.h"
#include "JSSVGAnimateTransformElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGAnimateTransformElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.h
index b719266..ed8d9bb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimateTransformElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimateTransformElement_h
#define JSSVGAnimateTransformElement_h
-
#if ENABLE(SVG) && ENABLE(SVG_ANIMATION)
#include "JSSVGAnimationElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.cpp
index 5c62b0f..92c485a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedAngle.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAngle.h"
#include "SVGAngle.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.h
index 3be1901..9500054 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedAngle.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedAngle_h
#define JSSVGAnimatedAngle_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.cpp
index 33301b2..2821aaa 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedBoolean.h"
#include <wtf/GetPtr.h>
-
-
using namespace JSC;
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.h
index ddebd8a..4a4d6f6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedBoolean.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedBoolean_h
#define JSSVGAnimatedBoolean_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.cpp
index ae30a65..3af330f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedEnumeration.h"
-#include <wtf/GetPtr.h>
-
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.h
index e09b4f5..b021183 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedEnumeration.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedEnumeration_h
#define JSSVGAnimatedEnumeration_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.cpp
index ebee00b..11337a2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedInteger.h"
-#include <wtf/GetPtr.h>
-
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.h
index 5804a92..34947f0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedInteger.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedInteger_h
#define JSSVGAnimatedInteger_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.cpp
index 05de831..2e1fc5b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedLength.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGLength.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.h
index 5f78e4b..430d78b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLength.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedLength_h
#define JSSVGAnimatedLength_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.cpp
index 2debf26..04fa5f2 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedLengthList.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGLengthList.h"
#include "SVGLengthList.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.h
index 68ff457..bd19ac9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedLengthList.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedLengthList_h
#define JSSVGAnimatedLengthList_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.cpp
index d6baa65..0b1d5a3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedNumber.h"
-#include <wtf/GetPtr.h>
-
-
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.h
index 8e058b8..77f77a6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumber.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedNumber_h
#define JSSVGAnimatedNumber_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.cpp
index 610ba23..3e07104 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedNumberList.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGNumberList.h"
#include "SVGNumberList.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.h
index a6d997c..bc1c751 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedNumberList.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedNumberList_h
#define JSSVGAnimatedNumberList_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.cpp
index 5c03cce..6209832 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedPreserveAspectRatio.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGPreserveAspectRatio.h"
#include "SVGPreserveAspectRatio.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.h
index f74ae85..3a36ff9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedPreserveAspectRatio.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedPreserveAspectRatio_h
#define JSSVGAnimatedPreserveAspectRatio_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.cpp
index dfe0795..41698eb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedRect.h"
-#include <wtf/GetPtr.h>
-
#include "FloatRect.h"
#include "JSSVGRect.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.h
index 909f7db..00c9ffa 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedRect.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedRect_h
#define JSSVGAnimatedRect_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.cpp
index 0088054..8d29f52 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.cpp
@@ -20,18 +20,14 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedString.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "PlatformString.h"
-
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.h
index d95a8fe..c7fd6db 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedString.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedString_h
#define JSSVGAnimatedString_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.cpp
index 8c9b0ef..ecdf262 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGAnimatedTransformList.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGTransformList.h"
#include "SVGTransformList.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.h
index c3300af..eb129ef 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimatedTransformList.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimatedTransformList_h
#define JSSVGAnimatedTransformList_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.cpp
index d133b03..12d6f19 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.cpp
@@ -20,23 +20,19 @@
#include "config.h"
-
#if ENABLE(SVG_ANIMATION)
-#include "SVGElement.h"
#include "JSSVGAnimationElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAnimatedBoolean.h"
#include "JSSVGElement.h"
#include "JSSVGStringList.h"
#include "SVGAnimationElement.h"
#include "SVGElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.h
index 5bed840..989c0d0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGAnimationElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGAnimationElement_h
#define JSSVGAnimationElement_h
-
#if ENABLE(SVG_ANIMATION)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.cpp
index 0c2fe13..f9fa2aa 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGCircleElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -45,9 +41,9 @@
#include "SVGCircleElement.h"
#include "SVGElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.h
index a9d797d..8c9acda 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGCircleElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGCircleElement_h
#define JSSVGCircleElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.cpp
index 39b04ed..73e31af 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGClipPathElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -45,9 +41,9 @@
#include "SVGClipPathElement.h"
#include "SVGElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.h
index 97fe6a0..b4a44cf 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGClipPathElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGClipPathElement_h
#define JSSVGClipPathElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGColor.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGColor.cpp
index bb0cc4f..88c62e4 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGColor.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGColor.cpp
@@ -20,19 +20,15 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGColor.h"
-#include <wtf/GetPtr.h>
-
#include "JSRGBColor.h"
#include "SVGColor.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGColor.h b/src/3rdparty/webkit/WebCore/generated/JSSVGColor.h
index da77c7d..43baabb 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGColor.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGColor.h
@@ -21,10 +21,10 @@
#ifndef JSSVGColor_h
#define JSSVGColor_h
-
#if ENABLE(SVG)
#include "JSCSSValue.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.cpp
index a9b2fb0..d5be3bc 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.cpp
@@ -20,20 +20,15 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGComponentTransferFunctionElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAnimatedEnumeration.h"
#include "JSSVGAnimatedNumber.h"
#include "JSSVGAnimatedNumberList.h"
#include "SVGComponentTransferFunctionElement.h"
-
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.h
index 98f427e..6576e32 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGComponentTransferFunctionElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGComponentTransferFunctionElement_h
#define JSSVGComponentTransferFunctionElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.cpp
index 8a35456..d6171c6 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.cpp
@@ -20,22 +20,18 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGCursorElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAnimatedBoolean.h"
#include "JSSVGAnimatedLength.h"
#include "JSSVGAnimatedString.h"
#include "JSSVGStringList.h"
#include "SVGCursorElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.h
index ff680ba..3771090 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGCursorElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGCursorElement_h
#define JSSVGCursorElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.cpp
index 98981c1..6947dda 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(SVG_FONTS)
-#include "SVGElement.h"
#include "JSSVGDefinitionSrcElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGDefinitionSrcElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.h
index 9c89886..9997f52 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDefinitionSrcElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGDefinitionSrcElement_h
#define JSSVGDefinitionSrcElement_h
-
#if ENABLE(SVG) && ENABLE(SVG_FONTS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.cpp
index 5cdeffc..83e26d0 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGDefsElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -44,9 +40,9 @@
#include "SVGDefsElement.h"
#include "SVGElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.h
index 0b4932c..e4fa8b5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDefsElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGDefsElement_h
#define JSSVGDefsElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.cpp
index 80b5adf..28641ab 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGDescElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -36,9 +32,9 @@
#include "JSSVGAnimatedString.h"
#include "KURL.h"
#include "SVGDescElement.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.h
index b89076e..b8ca101 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDescElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGDescElement_h
#define JSSVGDescElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.cpp
index 47de284..840e6c9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.cpp
@@ -20,21 +20,17 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGDocument.h"
-#include <wtf/GetPtr.h>
-
#include "Event.h"
#include "JSEvent.h"
#include "JSSVGSVGElement.h"
#include "SVGDocument.h"
#include "SVGSVGElement.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.h b/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.h
index e9541dd..d4bd50e 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGDocument.h
@@ -21,10 +21,10 @@
#ifndef JSSVGDocument_h
#define JSSVGDocument_h
-
#if ENABLE(SVG)
#include "JSDocument.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGElement.cpp
index 94f7c29..e4defcf 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElement.cpp
@@ -20,21 +20,17 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGElement.h"
#include "JSSVGSVGElement.h"
#include "KURL.h"
#include "SVGElement.h"
#include "SVGSVGElement.h"
-
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGElement.h
index a06116e..7123c7d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElement.h
@@ -21,11 +21,11 @@
#ifndef JSSVGElement_h
#define JSSVGElement_h
-
#if ENABLE(SVG)
#include "JSElement.h"
#include "SVGElement.h"
+
namespace WebCore {
class SVGElement;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.cpp
index 2c8ad7d..3b4d6b1 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGElementInstance.h"
-#include <wtf/GetPtr.h>
-
#include "Event.h"
#include "EventListener.h"
#include "Frame.h"
@@ -42,8 +38,8 @@
#include "SVGElementInstance.h"
#include "SVGElementInstanceList.h"
#include "SVGUseElement.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.h b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.h
index f529a39..59a9c10 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstance.h
@@ -21,10 +21,10 @@
#ifndef JSSVGElementInstance_h
#define JSSVGElementInstance_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.cpp
index bf0d240..81c9335 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.cpp
@@ -20,20 +20,16 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGElementInstanceList.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGElementInstance.h"
#include "SVGElementInstance.h"
#include "SVGElementInstanceList.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.h b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.h
index 3f5365c..956d44a 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGElementInstanceList.h
@@ -21,10 +21,10 @@
#ifndef JSSVGElementInstanceList_h
#define JSSVGElementInstanceList_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.cpp
index 435db96..8d6d8ec 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGEllipseElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -45,9 +41,9 @@
#include "SVGElement.h"
#include "SVGEllipseElement.h"
#include "SVGStringList.h"
-
#include <runtime/Error.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.h
index 7dd50fa..2ccb260 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGEllipseElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGEllipseElement_h
#define JSSVGEllipseElement_h
-
#if ENABLE(SVG)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGException.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGException.cpp
index a3eccbd..af6a2090 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGException.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGException.cpp
@@ -20,20 +20,16 @@
#include "config.h"
-
#if ENABLE(SVG)
-#include "SVGElement.h"
#include "JSSVGException.h"
-#include <wtf/GetPtr.h>
-
#include "KURL.h"
#include "SVGException.h"
-
#include <runtime/Error.h>
#include <runtime/JSNumberCell.h>
#include <runtime/JSString.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGException.h b/src/3rdparty/webkit/WebCore/generated/JSSVGException.h
index 374d2e6..e8fb53d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGException.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGException.h
@@ -21,10 +21,10 @@
#ifndef JSSVGException_h
#define JSSVGException_h
-
#if ENABLE(SVG)
#include "JSDOMBinding.h"
+#include "SVGElement.h"
#include <runtime/JSGlobalObject.h>
#include <runtime/ObjectPrototype.h>
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.cpp
index fd3bc91..0ecbe59 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEBlendElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -37,9 +33,8 @@
#include "JSSVGAnimatedLength.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEBlendElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.h
index a817f30..34750a9 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEBlendElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEBlendElement_h
#define JSSVGFEBlendElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.cpp
index 12af6e8..dd8db83 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEColorMatrixElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -38,9 +34,8 @@
#include "JSSVGAnimatedNumberList.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEColorMatrixElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.h
index 29dcd58..de9ef2f 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEColorMatrixElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEColorMatrixElement_h
#define JSSVGFEColorMatrixElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.cpp
index bbb07e7..cf4de5c 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEComponentTransferElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -36,8 +32,8 @@
#include "JSSVGAnimatedLength.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEComponentTransferElement.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.h
index ba98d41..803a32b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEComponentTransferElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEComponentTransferElement_h
#define JSSVGFEComponentTransferElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.cpp
index 3a05a50..6aff814 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFECompositeElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -38,9 +34,8 @@
#include "JSSVGAnimatedNumber.h"
#include "JSSVGAnimatedString.h"
#include "SVGFECompositeElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.h
index 5d267b7..b2876c3 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFECompositeElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFECompositeElement_h
#define JSSVGFECompositeElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.cpp
index d049fa1..4549381 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEDiffuseLightingElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -37,8 +33,8 @@
#include "JSSVGAnimatedNumber.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEDiffuseLightingElement.h"
-
#include <runtime/Error.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.h
index 2368f25..96bb14d 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDiffuseLightingElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEDiffuseLightingElement_h
#define JSSVGFEDiffuseLightingElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.cpp
index 74b6433..dca7363 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEDisplacementMapElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -38,9 +34,8 @@
#include "JSSVGAnimatedNumber.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEDisplacementMapElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.h
index 0ee1270..93c9fe5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDisplacementMapElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEDisplacementMapElement_h
#define JSSVGFEDisplacementMapElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.cpp
index 95092e4..55abac8 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.cpp
@@ -20,17 +20,13 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEDistantLightElement.h"
-#include <wtf/GetPtr.h>
-
#include "JSSVGAnimatedNumber.h"
#include "SVGFEDistantLightElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.h
index 4e798c8..1a61871 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEDistantLightElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEDistantLightElement_h
#define JSSVGFEDistantLightElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.cpp
index 52461a6..1b7cab5 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.cpp
@@ -20,14 +20,10 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEFloodElement.h"
-#include <wtf/GetPtr.h>
-
#include "CSSMutableStyleDeclaration.h"
#include "CSSStyleDeclaration.h"
#include "CSSValue.h"
@@ -36,9 +32,8 @@
#include "JSSVGAnimatedLength.h"
#include "JSSVGAnimatedString.h"
#include "SVGFEFloodElement.h"
-
#include <runtime/Error.h>
-#include <runtime/JSNumberCell.h>
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.h
index ad0a9ea..fe54ca4 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFloodElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEFloodElement_h
#define JSSVGFEFloodElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.cpp
index cf95412..90dbf26 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEFuncAElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGFEFuncAElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.h
index a072d4f..1afcb58 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncAElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEFuncAElement_h
#define JSSVGFEFuncAElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGComponentTransferFunctionElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.cpp
index c5a6dd7..a2c895b 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.cpp
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.cpp
@@ -20,16 +20,12 @@
#include "config.h"
-
#if ENABLE(SVG) && ENABLE(FILTERS)
-#include "SVGElement.h"
#include "JSSVGFEFuncBElement.h"
-#include <wtf/GetPtr.h>
-
#include "SVGFEFuncBElement.h"
-
+#include <wtf/GetPtr.h>
using namespace JSC;
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.h b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.h
index 70cbb22..5f44847 100644
--- a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.h
+++ b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncBElement.h
@@ -21,10 +21,10 @@
#ifndef JSSVGFEFuncBElement_h
#define JSSVGFEFuncBElement_h
-
#if ENABLE(SVG) && ENABLE(FILTERS)
#include "JSSVGComponentTransferFunctionElement.h"
+#include "SVGElement.h"
namespace WebCore {
diff --git a/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncGElement.cpp b/src/3rdparty/webkit/WebCore/generated/JSSVGFEFuncGElement.cpp